gdb/ChangeLog

   1 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
   2
   3         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
   4         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
   5         * ctfread.c: New file.
   6         * ctfread.h: New file.
   7         * elfread.c: Include ctfread.h.
   8         (struct elfinfo text_p): New member ctfsect.
   9         (elf_locate_sections): Mark CTF section.
  10         (elf_symfile_read): Call elfctf_build_psymtabs.
  11         * Makefile.in (LIBCTF): Add.
  12         (CLIBS): Use it.
  13         (CDEPS): Likewise.
  14         (DIST): Add ctfread.c.
  15
  16 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * ctfread.c (struct nextfield): Renamed to ...
  19         (struct ctf_nextfield): ... this.
  20         (struct field_info): Renamed to ...
  21         (strut ctf_field_info): ... this.
  22         (attach_fields_to_type): Update for renamed structures.
  23         (ctf_add_member_cb): Likewise.
  24         (ctf_add_enum_member_cb): Likewise.
  25         (process_struct_members): Likewise.
  26         (process_enum_type): Likewise.
  27
  28 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
  29
  30         * tracectf.h: Rename, was ctf.h.
  31         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
  32         * tracefile.c: Likewise.
  33         * tracepoint.c: Remove unused include ctf.h.
  34         * mi/mi-main.c: Likewise.
  35         * Makefile.in Replace ctf.c with tracectf.c.
  36
  37 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
  38
  39         * version.in: Change version number to "9.0.50.DATE-git".
  40
  41 2019-10-03  Tom Tromey  <tom@tromey.com>
  42
  43         PR rust/24976:
  44         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
  45
  46 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  47
  48         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
  49         cp_search_name_hash.
  50         * NEWS: Add entry about nested function support.
  51
  52 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
  53             Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
  56         for nested static variables when searchin VAR_DOMAIN.
  57         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
  58         global scope, update comment.
  59         (add_partial_subprogram): Call add_partial_subprogram recursively
  60         for nested subroutines when processinng Fortran.
  61         (load_partial_dies): Process the child entities of a subprogram
  62         when processing Fortran.
  63         (partial_die_parent_scope): Handle building scope
  64         for Fortran nested functions.
  65         (process_die): Record that nested functions have a scope.
  66         (new_symbol): Always record Fortran subprograms on the global
  67         symbol list.
  68         (determine_prefix): How to build the prefix for Fortran
  69         subprograms.
  70
  71 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  72
  73         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
  74         have just sent the thread a SIGSTOP and are waiting for it to
  75         arrive.
  76
  77 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  78
  79         * btrace.c (btrace_add_pc): Remove whitespace before the template
  80         parameter in 'std::vector <...>'.
  81         (parse_xml_btrace_block): Likewise.
  82         (btrace_maint_decode_pt): Likewise.
  83         (btrace_maint_update_packets): Likewise.
  84         (btrace_maint_print_packets): Likewise.
  85         * btrace.h (struct btrace_maint_info): Likewise.
  86         * dwarf2read.c (struct type_unit_group): Likewise.
  87         (build_type_psymtabs_reader): Likewise.
  88         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  89         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  90         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  91
  92 2019-10-03  Tom de Vries  <tdevries@suse.de>
  93
  94         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  95         the first line of the help text for set/show style metadata.
  96
  97 2019-10-02  Tom Tromey  <tromey@adacore.com>
  98
  99         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 100         * gdbsupport/common-inferior.c: New file.
 101         * infcmd.c (startup_with_shell): Don't define.
 102         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 103         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 104         * inferior.h (startup_with_shell): Don't declare.
 105
 106 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 107
 108         * gdbsupport/gdb_assert.h: Include errors.h.
 109         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 110
 111 2019-10-02  Tom Tromey  <tromey@adacore.com>
 112
 113         * NEWS: Add $_ada_exception entry.
 114         * ada-lang.c (struct ada_catchpoint): Add constructor.
 115         <m_kind>: New member.
 116         (allocate_location_exception, re_set_exception): Remove
 117         "ex" parameter.
 118         (should_stop_exception): Compute $_ada_exception.
 119         (check_status_exception, print_it_exception)
 120         (print_one_exception, print_mention_exception): Remove
 121         "ex" parameter.
 122         (allocate_location_catch_exception, re_set_catch_exception)
 123         (check_status_exception, print_it_catch_exception)
 124         (print_one_catch_exception, print_mention_catch_exception)
 125         (print_recreate_catch_exception)
 126         (allocate_location_catch_exception_unhandled)
 127         (re_set_catch_exception_unhandled)
 128         (check_status_exception, print_it_catch_exception_unhandled)
 129         (print_one_catch_exception_unhandled)
 130         (print_mention_catch_exception_unhandled)
 131         (print_recreate_catch_exception_unhandled)
 132         (allocate_location_catch_assert, re_set_catch_assert)
 133         (check_status_assert, print_it_catch_assert)
 134         (print_one_catch_assert, print_mention_catch_assert)
 135         (print_recreate_catch_assert)
 136         (allocate_location_catch_handlers, re_set_catch_handlers)
 137         (check_status_handlers, print_it_catch_handlers)
 138         (print_one_catch_handlers, print_mention_catch_handlers)
 139         (print_recreate_catch_handlers): Remove.
 140         (create_ada_exception_catchpoint): Update.
 141         (initialize_ada_catchpoint_ops): Update.
 142
 143 2019-10-02  Tom Tromey  <tromey@adacore.com>
 144
 145         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 146         (create_excep_cond_exprs): Simplify exception string computation.
 147         (ada_exception_catchpoint_cond_string): Likewise.
 148
 149 2019-10-02  Tom Tromey  <tromey@adacore.com>
 150
 151         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 152         * ada-lang.c (lesseq_defined_than): Handle
 153         LOC_STATIC.
 154         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 155         parameter.
 156         (dwarf2_has_info): Likewise.
 157         (new_symbol): Set maybe_copied on symbol when
 158         appropriate.
 159         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 160         parameter.
 161         <can_copy>: New member.
 162         * elfread.c (record_minimal_symbol): Set maybe_copied
 163         on symbol when appropriate.
 164         (elf_symfile_read): Update call to dwarf2_has_info.
 165         * minsyms.c (lookup_minimal_symbol_linkage): New
 166         function.
 167         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 168         * symtab.c (get_symbol_address, get_msymbol_address):
 169         New functions.
 170         * symtab.h (get_symbol_address, get_msymbol_address):
 171         Declare.
 172         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 173         maybe_copied.
 174         (struct symbol, struct minimal_symbol) <maybe_copied>:
 175         New member.
 176
 177 2019-10-02  Tom Tromey  <tromey@adacore.com>
 178
 179         * source.c (struct current_source_location): New.
 180         (current_source_key): New global.
 181         (current_source_symtab, current_source_line)
 182         (current_source_pspace): Remove.
 183         (get_source_location): New function.
 184         (get_current_source_symtab_and_line)
 185         (set_default_source_symtab_and_line)
 186         (set_current_source_symtab_and_line)
 187         (clear_current_source_symtab_and_line, select_source_symtab)
 188         (info_source_command, print_source_lines_base)
 189         (info_line_command, search_command_helper, _initialize_source):
 190         Update.
 191
 192 2019-10-02  Tom Tromey  <tromey@adacore.com>
 193
 194         * source.c (select_source_symtab): Don't call
 195         decode_line_with_current_source.
 196
 197 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 198
 199         * symtab.c (lookup_global_symbol): Search global block.
 200
 201 2019-10-02  Tom Tromey  <tromey@adacore.com>
 202
 203         * coffread.c (process_coff_symbol): Update.
 204         * dwarf2read.c (var_decode_location, new_symbol): Update.
 205         * mdebugread.c (parse_symbol): Update.
 206         * objfiles.c (relocate_one_symbol): Update.
 207         * stabsread.c (define_symbol, fix_common_block)
 208         (scan_file_globals): Update.
 209         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 210         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 211         * xcoffread.c (process_xcoff_symbol): Update.
 212
 213 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 214
 215         * MAINTAINERS: Update my email address.
 216
 217 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 220         std::vector.
 221         (build_type_psymtabs_reader): Update for std::vector.
 222         (build_type_psymtab_dependencies): Likewise.
 223         * dwarf2read.h: Remove use of DEF_VEC_P.
 224         (typedef sig_type_ptr): Delete.
 225
 226 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 227
 228         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 229         to std::vector.
 230         (btrace_maint_decode_pt): Likewise, and move allocation of the
 231         vector outside of the loop.
 232         (btrace_maint_update_packets): Update to handle change from VEC to
 233         std::vector.
 234         (btrace_maint_print_packets): Likewise.
 235         (maint_info_btrace_cmd): Likewise.
 236         * btrace.h: Remove use of DEF_VEC_O.
 237         (typedef btrace_pt_packet_s): Delete.
 238         (struct btrace_maint_info) <packets>: Change fromm VEC to
 239         std::vector.
 240         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 241
 242 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 245         make accesses into the vector constant references.
 246         (btrace_add_pc): Update for std::vector.
 247         (btrace_stitch_bts): Likewise.
 248         (parse_xml_btrace_block): Likewise.
 249         (btrace_maint_update_packets): Likewise.
 250         (btrace_maint_print_packets): Likewise.
 251         (maint_info_btrace_cmd): Likewise.
 252         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 253         std::vector.
 254         (btrace_data::empty): Likewise.
 255         (btrace_data_append): Likewise.
 256         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 257         (typedef btrace_block_s): Delete.
 258         (struct btrace_block): Add constructor.
 259         (struct btrace_data_bts) <blocks>: Change to std::vector.
 260         * nat/linux-btrace.c (perf_event_read_bts): Update for
 261         std::vector.
 262         (linux_read_bts): Likewise.
 263
 264 2019-10-01  Tom Tromey  <tom@tromey.com>
 265
 266         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 267
 268 2019-10-01  Tom Tromey  <tom@tromey.com>
 269
 270         * stack.c (print_frame, info_frame_command_core): Use
 271         styled_string.
 272         * linux-thread-db.c (try_thread_db_load_1)
 273         (try_thread_db_load_from_pdir_1): Use styled_string.
 274         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 275         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 276         (maybe_print_unsupported_script_warning)
 277         (maybe_print_script_not_found_warning): Use styled_string.
 278         * ada-lang.c (user_select_syms): Use styled_string.
 279
 280 2019-10-01  Tom Tromey  <tom@tromey.com>
 281
 282         * p-lang.c (pascal_printstr): Use metadata style.
 283         * value.c (show_convenience): Use metadata style.
 284         * valprint.c (valprint_check_validity, val_print_optimized_out)
 285         (val_print_not_saved, val_print_unavailable)
 286         (val_print_invalid_address, generic_val_print, val_print)
 287         (value_check_printable, val_print_array_elements): Use metadata
 288         style.
 289         * ui-out.h (class ui_out) <field_fmt>: New overload.
 290         <do_field_fmt>: Add style parameter.
 291         * ui-out.c (ui_out::field_fmt): New overload.
 292         * typeprint.c (type_print_unknown_return_type)
 293         (val_print_not_allocated, val_print_not_associated): Use metadata
 294         style.
 295         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 296         parameter.
 297         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 298         * tracepoint.c (tvariables_info_1): Use metadata style.
 299         * stack.c (print_frame_arg, print_frame_info, print_frame)
 300         (info_frame_command_core): Use metadata style.
 301         * skip.c (info_skip_command): Use metadata style.
 302         * rust-lang.c (rust_print_enum): Use metadata style.
 303         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 304         metadata style.
 305         * python/py-framefilter.c (py_print_single_arg): Use metadata
 306         style.
 307         * printcmd.c (do_one_display, print_variable_and_value): Use
 308         metadata style.
 309         * p-valprint.c (pascal_val_print)
 310         (pascal_object_print_value_fields): Use metadata style.
 311         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 312         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 313         parameter.
 314         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 315         * m2-valprint.c (m2_print_long_set): Use metadata style.
 316         * m2-typeprint.c (m2_print_type): Use metadata style.
 317         * infcmd.c (print_return_value_1): Use metadata style.
 318         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 319         * f-valprint.c (info_common_command_for_block): Use metadata
 320         style.
 321         * f-typeprint.c (f_type_print_base): Use metadata style.
 322         * expprint.c (print_subexp_standard): Use metadata style.
 323         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 324         * cli/cli-style.h (class cli_style_option): Add constructor.
 325         (metadata_style): Declare.
 326         * cli/cli-style.c (metadata_style): New global.
 327         (_initialize_cli_style): Register metadata style.
 328         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 329         parameter.
 330         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 331         * c-typeprint.c (c_type_print_base_struct_union)
 332         (c_type_print_base_1): Use metadata style.
 333         * breakpoint.c (watchpoint_value_print)
 334         (print_one_breakpoint_location): Use metadata style.
 335         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 336         style.
 337         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 338         style.
 339         * ada-valprint.c (val_print_packed_array_elements, printstr)
 340         (print_field_values, ada_val_print_ref, ada_val_print): Use
 341         metadata style.
 342         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 343         style.
 344         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 345         style.
 346         * ada-lang.c (user_select_syms): Use metadata style.
 347
 348 2019-10-01  Tom Tromey  <tom@tromey.com>
 349
 350         * cli/cli-cmds.c (pwd_command): Style output.
 351
 352 2019-10-01  Pedro Alves  <palves@redhat.com>
 353             Tom Tromey  <tom@tromey.com>
 354
 355         * symtab.c (print_symbol_info): Use %ps.
 356         (print_msymbol_info): Use %ps.
 357         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 358         * printcmd.c (print_variable_and_value): Use %ps.
 359         * macrocmd.c (show_pp_source_pos): Use %ps.
 360         * infrun.c (print_exited_reason): Use ui_out::message.
 361         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 362         (describe_other_breakpoints): Use ui_out::message and new
 363         formats.
 364         (say_where): Use new formats.
 365         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 366         and new formats.
 367
 368 2019-10-01  Pedro Alves  <palves@redhat.com>
 369             Tom Tromey  <tom@tromey.com>
 370
 371         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 372         (test_gdb_formats): New function.
 373         (run_tests): Call it.
 374         (test_format_specifier): Update.
 375         * utils.h (fputs_filtered): Update comment.
 376         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 377         (fputs_styled_unfiltered): Declare.
 378         * utils.c (fputs_styled_unfiltered): New function.
 379         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 380         (vfprintf_filtered): Update.
 381         (vfprintf_unfiltered, vprintf_filtered): Update.
 382         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 383         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 384         disallow_ui_out_field>: New constants.
 385         (enum class field_kind): New.
 386         (struct base_field_s, struct signed_field_s): New.
 387         (signed_field): New function.
 388         (struct string_field_s): New.
 389         (string_field): New function.
 390         (struct styled_string_s): New.
 391         (styled_string): New function.
 392         (class ui_out) <message>: Add comment.
 393         <vmessage, call_do_message>: New methods.
 394         <do_message>: Add style parameter.
 395         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 396         methods.
 397         (ui_out::message): Rewrite.
 398         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 399         parameter.
 400         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 401         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 402         gdb_extensions parameter.
 403         (class format_piece): Add parameter to constructor.
 404         (n_int_args): New field.
 405         * gdbsupport/format.c (format_pieces::format_pieces): Add
 406         gdb_extensions parameter.  Handle '*'.
 407         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 408         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 409         vfprintf_styled_no_gdbfmt.
 410         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 411         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 412         unfiltered output.
 413         * ui-style.h (struct ui_file_style) <ptr>: New method.
 414
 415 2019-10-01  Tom Tromey  <tom@tromey.com>
 416
 417         * unittests/format_pieces-selftests.c: Update.  Add final format.
 418         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 419         empty literal pieces.
 420
 421 2019-10-01  Tom Tromey  <tom@tromey.com>
 422
 423         * ui-out.h (enum class ui_out_style_kind): Remove.
 424         (class ui_out) <field_string, field_stsream, do_field_string>:
 425         Change type of "style".
 426         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 427         (ui_out::field_string): Update.
 428         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 429         of "style".
 430         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 431         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 432         * stack.c (print_frame_arg, print_frame_info, print_frame):
 433         Update.
 434         * source.c (print_source_lines_base): Update.
 435         * solib.c (info_sharedlibrary_command): Update.
 436         * skip.c (info_skip_command): Update.
 437         * record-btrace.c (btrace_call_history_src_line)
 438         (btrace_call_history): Update.
 439         * python/py-framefilter.c (py_print_frame): Update.
 440         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 441         "style".
 442         * mi/mi-out.c (mi_ui_out::do_table_header)
 443         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 444         (mi_ui_out::do_field_string): Update.
 445         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 446         Update.
 447         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 448         "style".
 449         * cli-out.c (cli_ui_out::do_table_header)
 450         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 451         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 452         (cli_ui_out::do_field_fmt): Update.
 453         * breakpoint.c (print_breakpoint_location): Update.
 454         (update_static_tracepoint): Update.
 455
 456 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 457
 458         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 459         conversion of gdb_datadir.
 460         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 461         remove not needed c_str ().
 462
 463 2019-09-30  Ali Tamur <tamur@google.com>
 464
 465         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 466         (dwarf2_string_attr): Likewise.
 467
 468 2019-09-30  Ali Tamur <tamur@google.com>
 469
 470         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 471         (process_full_type_unit): Likewise.
 472         (dump_die_shallow): Likewise.
 473         (cu_debug_loc_section): Likewise.
 474
 475 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 476
 477         * minsyms.c (compare_minimal_symbols): Rename to...
 478         (minimal_symbol_is_less_than): ...this, and adjust to STL
 479         conventions (return bool, take arguments as references)
 480         (minimal_symbol_reader::install): Call std::sort instead
 481         of qsort.
 482
 483 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 484
 485         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 486         hash and why.
 487         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 488         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 489
 490 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 491
 492         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 493         * psympriv.h (add_psymbol_to_list): Move comment here and update
 494         it.
 495
 496 2019-09-29  Tom de Vries  <tdevries@suse.de>
 497
 498         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 499         Use $tmpdir/$(basename "$output_file").dwz instead of
 500         "${output_file}.dwz".
 501
 502 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 503
 504         PR gdb/25045
 505         * hppa-linux-nat.c: Include gdbarch.h.
 506
 507 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * blockframe.c (find_pc_partial_function): Change return type to bool.
 510         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 511         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 512         (stub_gnu_ifunc_resolve_name): Likewise.
 513         * symtab.c (compare_filenames_for_search): Likewise.
 514         (compare_glob_filenames_for_search): Likewise.
 515         (matching_obj_sections): Likewise.
 516         (symbol_matches_domain): Likewise.
 517         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 518         (find_line_pc): Change return type to bool.
 519         (find_line_pc_range): Likewise.
 520         (producer_is_realview): Likewise.
 521         * symtab.h (symbol_matches_domain): Likewise.
 522         (find_pc_partial_function): Likewise.
 523         (find_pc_line_pc_range): Likewise.
 524         (in_gnu_ifunc_stub): Likewise.
 525         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 526         (find_line_pc): Likewise.
 527         (find_line_pc_range): Likewise.
 528         (matching_obj_sections): Likewise.
 529         (find_line_symtab): Change out parameter to bool.
 530         (producer_is_realview): Change return type to bool.
 531         (compare_filenames_for_search): Likewise.
 532         (compare_glob_filenames_for_search): Likewise.
 533
 534 2019-09-26  Tom Tromey  <tom@tromey.com>
 535
 536         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 537         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 538         * gdb_usleep.h: Remove.
 539         * gdb_usleep.c: Remove.
 540         * utils.c: Don't include gdb_usleep.h.
 541
 542 2019-09-26  Tom Tromey  <tromey@adacore.com>
 543
 544         * python/py-type.c (type_to_type_object): Call check_typedef
 545         for stub types.
 546
 547 2019-09-26  Tom Tromey  <tom@tromey.com>
 548
 549         * utils.h (initialize_utils): Don't declare.
 550         * top.c (gdb_init): Don't call initialize_utils.
 551         * utils.c (initialize_utils): Remove.  Move contents...
 552         (_initialize_utils): ... here.
 553
 554 2019-09-25  Tom Tromey  <tom@tromey.com>
 555
 556         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 557         * utils.h (make_hex_string): Don't declare.
 558         * utils.c (make_hex_string): Remove.
 559
 560 2019-09-24  Tom de Vries  <tdevries@suse.de>
 561
 562         PR gdb/23815
 563         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 564         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 565
 566 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 567
 568         * NEWS: Mention new simulator port for PRU.
 569
 570 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * ada-exp.y (write_object_remaining): Update.
 573         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 574         and eliminate the static buffer.
 575         (ada_decode_symbol): Update.
 576         (ada_la_decode): Update.
 577         (ada_sniff_from_mangled_name): Update.
 578         (is_valid_name_for_wild_match): Update.
 579         (ada_lookup_name_info::matches): Update and simplify.
 580         (name_matches_regex): Update.
 581         (ada_add_global_exceptions): Update.
 582         * ada-lang.h (ada_decode): Update signature.
 583         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 584         * dwarf-index-write.c (debug_names::insert): Update.
 585
 586 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 587
 588         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 589         formatting.
 590
 591 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 592
 593         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 594         Change "nonzero" to "true" in documentation.
 595
 596 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 597
 598         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 599         (_initialize_darwin_solib): Don't set
 600         darwin_so_ops.lookup_lib_global_symbol.
 601         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 602         set_gdbarch_iterate_over_objfiles_in_search_order.
 603         (elf_lookup_lib_symbol): Rename to...
 604         (svr4_iterate_over_objfiles_in_search_order): this, and update
 605         to iterate semantics.
 606         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 607         * solib.c (solib_global_lookup): Remove.
 608         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 609         (solib_global_lookup): Remove.
 610         * symtab.c (lookup_global_or_static_symbol): Remove call to
 611         solib_global_lookup.
 612
 613 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 614
 615         * NEWS: Move entries about default MI version now being
 616         version 3, and about the GDB/MI fix for multi-location
 617         breakpoints to the "since GDB 8.3" section.
 618
 619 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 620
 621         GDB 8.3.1 released.
 622
 623 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 624
 625         * NEWS: Mention that Cell/B.E. debugging support was removed.
 626         * MAINTAINERS: Remove spu target.
 627
 628         * config/djgpp/fnchange.lst: Remove entries for removed files.
 629
 630         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 631         spu-multiarch.o, and spu-tdep.o.
 632         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 633         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 634         spu-multiarch.c, and spu-tdep.c.
 635         * spu-linux-nat.c: Remove file.
 636         * spu-multiarch.c: Remove file.
 637         * spu-tdep.c: Remove file.
 638         * spu-tdep.h: Remove file.
 639         * solib-spu.c: Remove file.
 640         * solib-spu.h: Remove file.
 641
 642         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 643         * configure.nat (spu-linux): Remove.
 644         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 645         solib-multiarch.o from gdb_target_obs.
 646         (spu*-*-*): Remove.
 647
 648         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 649         feature flag.
 650         (ppc_linux_no_features): Update.
 651         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 652         Cell/B.E. support.
 653         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 654         (tdesc_powerpc_cell64l): Likewise.
 655         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 656         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 657         Cell/B.E. support.
 658         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 659         Do not include "features/rs6000/powerpc-cell32l.c" or
 660         "features/rs6000/powerpc-cell64l.c".
 661         (ppc_linux_spu_section): Remove.
 662         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 663         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 664         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 665         (ppc_linux_spe_context_lookup): Remove.
 666         (ppc_linux_spe_context_inferior_created): Remove.
 667         (ppc_linux_spe_context_solib_loaded): Remove.
 668         (ppc_linux_spe_context_solib_unloaded): Remove.
 669         (ppc_linux_spe_context): Remove.
 670         (struct ppu2spu_cache): Remove.
 671         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 672         (struct ppu2spu_data): Remove.
 673         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 674         ppu2spu_unwind): Remove.
 675         (ppc_linux_init_abi): Remove Cell/B.E. support.
 676         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 677
 678         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 679         (rs6000/powerpc-cell64l-expedite): Likewise
 680         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 681         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 682         rs6000/powerpc-cell64l.xml.
 683         * features/rs6000/powerpc-cell32l.xml: Remove.
 684         * features/rs6000/powerpc-cell64l.xml: Likewise.
 685         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 686         * features/rs6000/powerpc-cell64l.c: Likewise.
 687         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 688         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 689         * regformats/reg-spu.dat: Remove.
 690
 691         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 692         * corelow.c (struct spuid_list): Remove.
 693         (add_to_spuid_list): Remove.
 694         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 695         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 696         (remote_protocol_features): Remove associated entries.
 697         (_initialize_remote): No longer initialize them.
 698         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 699         * linux-nat.c (SPUFS_MAGIC): Remove.
 700         (linux_proc_xfer_spu): Remove.
 701         (spu_enumerate_spu_ids): Remove.
 702         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 703         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 704         (linux_make_corefile_notes): No longer call it.
 705
 706         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 707         (cooked_write_test): Likewise.
 708
 709 2019-09-20  Tom Tromey  <tom@tromey.com>
 710
 711         * NEWS: Mention case-sensitivity of TUI commands.
 712         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 713         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 714         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 715
 716 2019-09-20  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-source.c (tui_source_window::set_contents): Use
 719         make_unique_xstrdup.
 720         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 721         make_unique_xstrdup.
 722
 723 2019-09-20  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-data.c: Remove separator comments.
 726         * tui/tui-layout.c: Remove separator comments.
 727         * tui/tui-win.c: Remove separator comments.
 728         * tui/tui-wingeneral.c: Remove separator comments.
 729
 730 2019-09-20  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui.h (strcat_to_buf): Don't declare.
 733         * tui/tui.c (strcat_to_buf): Remove.
 734
 735 2019-09-20  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 738         from "fullname".
 739         * tui/tui-source.c (tui_source_window::set_contents)
 740         (tui_source_window::location_matches_p)
 741         (tui_source_window::maybe_update): Update.
 742
 743 2019-09-20  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 746         Update.
 747         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 748         prefix.
 749         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 750         (tui_data_window::line_from_reg_element_no)
 751         (tui_data_window::first_reg_element_no_inline)
 752         (tui_data_window::show_registers)
 753         (tui_data_window::show_register_group)
 754         (tui_data_window::display_registers_from)
 755         (tui_data_window::display_registers_from_line)
 756         (tui_data_window::first_data_item_displayed)
 757         (tui_data_window::delete_data_content_windows)
 758         (tui_data_window::erase_data_content)
 759         (tui_data_window::do_scroll_vertical)
 760         (tui_data_window::refresh_window)
 761         (tui_data_window::check_register_values): Update.
 762
 763 2019-09-20  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 766         (struct tui_locator_window) <full_name, proc_name>: Now
 767         std::string.
 768         * tui/tui-stack.c (tui_locator_window::make_status_line)
 769         (tui_locator_window::set_locator_fullname)
 770         (tui_locator_window::set_locator_info): Update.
 771         * tui/tui-source.c (tui_source_window::set_contents)
 772         (tui_source_window::showing_source_p): Update.
 773
 774 2019-09-20  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 777         Don't call tui_locator_win_info_ptr.
 778
 779 2019-09-20  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 782
 783 2019-09-20  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 786         height for locator.
 787         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 788         * tui/tui-layout.c (show_source_disasm_command, show_data)
 789         (show_source_or_disasm_and_command): Use 1 as height for locator.
 790
 791 2019-09-20  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui.c (tui_enable): Update.
 794         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 795         Update.
 796         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 797         Update.
 798         * tui/tui-data.c (win_resized): Now bool.
 799         (tui_win_resized): Return bool.
 800         (tui_set_win_resized_to): Accept a bool.
 801
 802 2019-09-20  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 805         Change type of "refresh_values_only".
 806         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 807         type of "refresh_values_only".
 808
 809 2019-09-20  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 812         std::string.
 813         (tui_disassemble): Add "pos" parameter.
 814         (tui_disasm_window::set_contents): Simplify.
 815
 816 2019-09-20  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-winsource.h (struct tui_source_window_base)
 819         <show_source_content>: Now private.
 820         * tui/tui-winsource.c
 821         (tui_source_window_base::show_source_content): Don't handle empty
 822         content case.
 823
 824 2019-09-20  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-layout.c (show_source_disasm_command)
 827         (show_source_or_disasm_and_command): Don't call
 828         show_source_content.
 829
 830 2019-09-20  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 833         Declare.
 834         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 835         from tui_make_status_line.
 836         (tui_locator_window::rerender): Update.
 837
 838 2019-09-20  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 841         (tui_locator_window::rerender): Update.
 842
 843 2019-09-20  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.h (struct tui_source_window_base)
 846         <~tui_source_window_base>: Don't declare.
 847         <fullname>: Remove.
 848         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 849         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 850         member.
 851         * tui/tui-source.c (tui_source_window::set_contents): Update.
 852         (tui_source_window::location_matches_p)
 853         (tui_source_window::maybe_update): Update.
 854
 855 2019-09-20  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-winsource.h (~tui_source_element): Remove.
 858         (tui_source_element): Update.
 859         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 860         * tui/tui-winsource.c (tui_show_source_line): Update.
 861         * tui/tui-source.c (tui_source_window::set_contents): Update.
 862         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 863
 864 2019-09-20  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 867         declare.
 868         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 869         tui_clear_source_windows_detail.
 870         * tui/tui-winsource.h (struct tui_source_window_base)
 871         <clear_detail>: Don't declare.
 872         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 873         Remove.
 874         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 875
 876 2019-09-20  Tom Tromey  <tromey@adacore.com>
 877
 878         PR ada/24919:
 879         * block.c (contained_in): Fix final return value.
 880
 881 2019-09-20  Alan Modra  <amodra@gmail.com>
 882
 883         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 884         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 885         (read_indirect_string_from_dwz): Use bfd accessor.
 886         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 887         * machoread.c (macho_symfile_read_all_oso): Likewise.
 888         * solib.c (solib_bfd_open): Likewise.
 889
 890 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 891
 892         * eval.c: Move declaration of overload_resolution to...
 893         * value.h: ...here.
 894
 895 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 898         * arm-linux-tdep.c: Likewise.
 899         * arm-nbsd-nat.c: Likewise.
 900         * arm-tdep.h: Declare arm_apcs_32.
 901         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 902
 903 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 906         * dwarf2read.h: Declare dwarf_always_disassemble.
 907
 908 2019-09-19  Tom de Vries  <tdevries@suse.de>
 909
 910         PR gdb/25009
 911         * source-cache.c (source_cache::ensure): Catch exception thrown during
 912         construction of the highlighter.
 913
 914 2019-09-18  Alan Modra  <amodra@gmail.com>
 915
 916         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 917         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 918         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 919         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 920         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 921         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 922         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 923         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 924         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 925         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 926         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 927         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 928         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 929         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 930         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 931         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 932         * mi/mi-interp.c: Update throughout for bfd section macro and
 933         function changes.
 934         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 935         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 936
 937 2019-09-18  Tom Tromey  <tom@tromey.com>
 938
 939         * NEWS: Add entry.
 940         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 941         call rl_initialize.
 942         (tui_enable): Do not call rl_initialize.
 943
 944 2019-09-18  Christian Groessler  <chris@groessler.org>
 945
 946         * alpha-linux-nat.c: Include gdbarch.h.
 947
 948 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 949
 950         * ui-file.c: Include cli/cli-style.h.
 951         (term_cli_styling): Remove cli_styling declaration.
 952
 953 2019-09-18  Alan Modra  <amodra@gmail.com>
 954
 955         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 956         to bfd_asymbol_section.
 957
 958 2019-09-18  Alan Modra  <amodra@gmail.com>
 959
 960         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 961         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 962         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 963
 964 2019-09-18  Alan Modra  <amodra@gmail.com>
 965
 966         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 967         * spu-linux-nat.c (spu_bfd_open): Likewise.
 968
 969 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 970
 971         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 972         to bool to match definition in dwarf2read.c.
 973
 974 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 975
 976         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 977         (print_signatures): Likewise.
 978         (trust_pad_over_xvs): Likewise.
 979         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 980         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 981         * arm-linux-nat.c (arm_apcs_32): Likewise.
 982         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 983         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 984         * arm-tdep.c (arm_debug): Likewise.
 985         (arm_apcs_32): Likewise.
 986         * auto-load.c (debug_auto_load): Likewise.
 987         (auto_load_gdb_scripts): Likewise.
 988         (global_auto_load): Likewise.
 989         (auto_load_local_gdbinit): Likewise.
 990         (auto_load_local_gdbinit_loaded): Likewise.
 991         * auto-load.h (global_auto_load): Likewise.
 992         (auto_load_local_gdbinit): Likewise.
 993         (auto_load_local_gdbinit_loaded): Likewise.
 994         * breakpoint.c (disconnected_dprintf): Likewise.
 995         (breakpoint_proceeded): Likewise.
 996         (automatic_hardware_breakpoints): Likewise.
 997         (always_inserted_mode): Likewise.
 998         (target_exact_watchpoints): Likewise.
 999         (_initialize_breakpoint): Update.
1000         * breakpoint.h (target_exact_watchpoints): Change to bool.
1001         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1002         * cli/cli-cmds.c (trace_commands): Likewise.
1003         * cli/cli-cmds.h (trace_commands): Likewise.
1004         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1005         to bool*.
1006         * cli/cli-logging.c (logging_overwrite): Change to bool.
1007         (logging_redirect): Likewise.
1008         (debug_redirect): Likewise.
1009         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1010         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1011         to bool.
1012         <boolean_option_def>: Update.
1013         (struct flag_option_def): Change default type of Context to bool
1014         from int.
1015         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1016         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1017         (get_setshow_command_value_string): Likewise.
1018         * cli/cli-style.c (cli_styling): Change to bool.
1019         (source_styling): Likewise.
1020         * cli/cli-style.h (source_styling): Likewise.
1021         (cli_styling): Likewise.
1022         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1023         to bool.
1024         * command.h (var_types): Update comment.
1025         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1026         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1027         bool.
1028         (debug_compile_cplus_scopes): Likewise.
1029         * compile/compile-internal.h (compile_debug): Likewise.
1030         * compile/compile.c (compile_debug): Likewise.
1031         (struct compile_options) <raw>: Likewise.
1032         * cp-support.c (catch_demangler_crashes): Likewise.
1033         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1034         (usr_cmd_cris_dwarf2_cfi): Likewise.
1035         * csky-tdep.c (csky_debug): Likewise.
1036         * darwin-nat.c (enable_mach_exceptions): Likewise.
1037         * dcache.c (dcache_enabled_p): Likewise.
1038         * defs.h (info_verbose): Likewise.
1039         * demangle.c (demangle): Likewise.
1040         (asm_demangle): Likewise.
1041         * dwarf-index-cache.c (debug_index_cache): Likewise.
1042         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1043         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1044         * dwarf2read.c (check_physname): Likewise.
1045         (use_deprecated_index_sections): Likewise.
1046         (dwarf_always_disassemble): Likewise.
1047         * eval.c (overload_resolution): Likewise.
1048         * event-top.c (set_editing_cmd_var): Likewise.
1049         (exec_done_display_p): Likewise.
1050         * event-top.h (set_editing_cmd_var): Likewise.
1051         (exec_done_display_p): Likewise.
1052         * exec.c (write_files): Likewise.
1053         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1054         (debug_fbsd_nat): Likewise.
1055         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1056         Likewise.
1057         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1058         <backtrace_past_entry> Likewise.
1059         * gdb-demangle.h (demangle): Likewise.
1060         (asm_demangle): Likewise.
1061         * gdb_bfd.c (bfd_sharing): Likewise.
1062         * gdbcore.h (write_files): Likewise.
1063         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1064         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1065         * gdbthread.h (print_thread_events): Likewise.
1066         * gdbtypes.c (opaque_type_resolution): Likewise.
1067         (strict_type_checking): Likewise.
1068         * gnu-nat.c (gnu_debug_flag): Likewise.
1069         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1070         * guile/scm-param.c (pascm_variable): Add boolval.
1071         (add_setshow_generic): Update.
1072         (pascm_param_value): Update.
1073         (pascm_set_param_value_x): Update.
1074         * hppa-tdep.c (hppa_debug): Change to bool..
1075         * infcall.c (may_call_functions_p): Likewise.
1076         (coerce_float_to_double_p): Likewise.
1077         (unwind_on_signal_p): Likewise.
1078         (unwind_on_terminating_exception_p): Likewise.
1079         * infcmd.c (startup_with_shell): Likewise.
1080         * inferior.c (print_inferior_events): Likewise.
1081         * inferior.h (startup_with_shell): Likewise.
1082         (print_inferior_events): Likewise.
1083         * infrun.c (step_stop_if_no_debug): Likewise.
1084         (detach_fork): Likewise.
1085         (debug_displaced): Likewise.
1086         (disable_randomization): Likewise.
1087         (non_stop): Likewise.
1088         (non_stop_1): Likewise.
1089         (observer_mode): Likewise.
1090         (observer_mode_1): Likewise.
1091         (set_observer_mode): Update.
1092         (sched_multi): Change to bool.
1093         * infrun.h (debug_displaced): Likewise.
1094         (sched_multi): Likewise.
1095         (step_stop_if_no_debug): Likewise.
1096         (non_stop): Likewise.
1097         (disable_randomization): Likewise.
1098         * linux-tdep.c (use_coredump_filter): Likewise.
1099         (dump_excluded_mappings): Likewise.
1100         * linux-thread-db.c (auto_load_thread_db): Likewise.
1101         (check_thread_db_on_load): Likewise.
1102         * main.c (captured_main_1): Update.
1103         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1104         xx2_opt, boolean_opt>: Change to bool.
1105         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1106         * maint.c (maintenance_profile_p): Likewise.
1107         (per_command_time): Likewise.
1108         (per_command_space): Likewise.
1109         (per_command_symtab): Likewise.
1110         * memattr.c (inaccessible_by_default): Likewise.
1111         * mi/mi-main.c (mi_async): Likewise.
1112         (mi_async_1): Likewise.
1113         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1114         * nat/fork-inferior.h (startup_with_shell): Likewise.
1115         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1116         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1117         * nios2-tdep.c (nios2_debug): Likewise.
1118         * or1k-tdep.c (or1k_debug): Likewise.
1119         * parse.c (parser_debug): Likewise.
1120         * parser-defs.h (parser_debug): Likewise.
1121         * printcmd.c (print_symbol_filename): Likewise.
1122         * proc-api.c (procfs_trace): Likewise.
1123         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1124         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1125         (set_parameter_value): Update.
1126         (add_setshow_generic): Update.
1127         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1128         to bool*.
1129         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1130         int*.
1131         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1132         * record-btrace.c (record_btrace_target::store_registers): Update.
1133         * record-full.c (record_full_memory_query): Change to bool.
1134         (record_full_stop_at_limit): Likewise.
1135         * record-full.h (record_full_memory_query): Likewise.
1136         * remote-notif.c (notif_debug): Likewise.
1137         * remote-notif.h (notif_debug): Likewise.
1138         * remote.c (use_range_stepping): Likewise.
1139         (interrupt_on_connect): Likewise.
1140         (remote_break): Likewise.
1141         * ser-tcp.c (tcp_auto_retry): Likewise.
1142         * ser-unix.c (serial_hwflow): Likewise.
1143         * skip.c (debug_skip): Likewise.
1144         * solib-aix.c (solib_aix_debug): Likewise.
1145         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1146         (spu_auto_flush_cache_p): Likewise.
1147         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1148         Likewise.
1149         (struct info_print_options) <quiet>: Likewise.
1150         * symfile-debug.c (debug_symfile): Likewise.
1151         * symfile.c (auto_solib_add): Likewise.
1152         (separate_debug_file_debug): Likewise.
1153         * symfile.h (auto_solib_add): Likewise.
1154         (separate_debug_file_debug): Likewise.
1155         * symtab.c (basenames_may_differ): Likewise.
1156         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1157         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1158         (struct info_types_options) <quiet>: Likewise.
1159         * symtab.h (demangle): Likewise.
1160         (basenames_may_differ): Likewise.
1161         * target-dcache.c (stack_cache_enabled_1): Likewise.
1162         (code_cache_enabled_1): Likewise.
1163         * target.c (trust_readonly): Likewise.
1164         (may_write_registers): Likewise.
1165         (may_write_memory): Likewise.
1166         (may_insert_breakpoints): Likewise.
1167         (may_insert_tracepoints): Likewise.
1168         (may_insert_fast_tracepoints): Likewise.
1169         (may_stop): Likewise.
1170         (auto_connect_native_target): Likewise.
1171         (target_stop_and_wait): Update.
1172         (target_async_permitted): Change to bool.
1173         (target_async_permitted_1): Likewise.
1174         (may_write_registers_1): Likewise.
1175         (may_write_memory_1): Likewise.
1176         (may_insert_breakpoints_1): Likewise.
1177         (may_insert_tracepoints_1): Likewise.
1178         (may_insert_fast_tracepoints_1): Likewise.
1179         (may_stop_1): Likewise.
1180         * target.h (target_async_permitted): Likewise.
1181         (may_write_registers): Likewise.
1182         (may_write_memory): Likewise.
1183         (may_insert_breakpoints): Likewise.
1184         (may_insert_tracepoints): Likewise.
1185         (may_insert_fast_tracepoints): Likewise.
1186         (may_stop): Likewise.
1187         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1188         (make_thread_apply_all_options_def_group): Change argument from int*
1189         to bool*.
1190         (thread_apply_all_command): Update.
1191         (print_thread_events): Change to bool.
1192         * top.c (confirm): Likewise.
1193         (command_editing_p): Likewise.
1194         (history_expansion_p): Likewise.
1195         (write_history_p): Likewise.
1196         (info_verbose): Likewise.
1197         * top.h (confirm): Likewise.
1198         (history_expansion_p): Likewise.
1199         * tracepoint.c (disconnected_tracing): Likewise.
1200         (circular_trace_buffer): Likewise.
1201         * typeprint.c (print_methods): Likewise.
1202         (print_typedefs): Likewise.
1203         * utils.c (debug_timestamp): Likewise.
1204         (sevenbit_strings): Likewise.
1205         (pagination_enabled): Likewise.
1206         * utils.h (sevenbit_strings): Likewise.
1207         (pagination_enabled): Likewise.
1208         * valops.c (overload_resolution): Likewise.
1209         * valprint.h (struct value_print_options) <prettyformat_arrays,
1210         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1211         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1212         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1213         Likewise.
1214         * windows-nat.c (new_console): Likewise.
1215         (cygwin_exceptions): Likewise.
1216         (new_group): Likewise.
1217         (debug_exec): Likewise.
1218         (debug_events): Likewise.
1219         (debug_memory): Likewise.
1220         (debug_exceptions): Likewise.
1221         (useshell): Likewise.
1222         * windows-tdep.c (maint_display_all_tib): Likewise.
1223         * xml-support.c (debug_xml): Likewise.
1224
1225 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1226
1227         * source.c (prepare_path_for_appending): New function.
1228         (openp): Make use of new function.
1229         (find_and_open_source): Search for the compilation directory and
1230         source file as a relative path beneath the directory search path.
1231
1232 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * source-cache.c (source_cache::get_line_charpos): Catch
1235         exceptions and return false, this matches the behaviour documented
1236         in the header file.
1237
1238 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1239
1240         * ada-tasks.c (info_task): Remove quoting of the task's name.
1241
1242 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1243
1244         * symfile.c (auto_solib_add): Replace comment with a reference
1245         to the header file.
1246
1247 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1248
1249         * NEWS: Mention that gdb can now be compiled with Python 3
1250         on Windows.
1251
1252 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * maint.c (maint_print_section_data::maint_print_section_data):
1255         Force use of 'float log10 (float)' by casting the argument to
1256         float.
1257
1258 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * maint.c: Add 'cmath' include.
1261         (struct maint_print_section_data): New structure.
1262         (print_section_index): New function.
1263         (print_bfd_section_info): Add header comment, small whitespace
1264         cleanup, and update to call new print_section_index function.
1265         (print_objfile_section_info): Likewise.
1266         (maint_obj_section_from_bfd_section): New function.
1267         (print_bfd_section_info_maybe_relocated): New function.
1268         (maintenance_info_sections): Add header comment, always use
1269         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1270
1271 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1274         inner scope, add check that the objfile has psymtabs before
1275         checking psymtabs_addrmap.
1276         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1277
1278 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1279
1280         * NEWS: Announce that Ada task names are now shown at more places,
1281         and between quotes (except in info task output).
1282         * gdb/ada-tasks.c (task_to_str): New function.
1283         (display_current_task_id): Call task_to_str.
1284         (task_command_1): Likewise.
1285         (print_ada_task_info): In non-mi mode, Properly align headers and data
1286         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1287
1288 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1289
1290         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1291         prstatus.pr_lwp.pr_info instead of making it up.
1292
1293 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1294
1295         * auto-load.c (auto_load_expand_dir_vars): Update.
1296         * defs.h (gdb_datadir): Change to std::string.
1297         (python_libdir): Likewise.
1298         (relocate_gdb_directory): Change return type to std::string.
1299         * guile/guile.c (gdbscm_data_directory): Update.
1300         (initialize_scheme_side): Update.
1301         * jit.c (jit_reader_dir): Change to std::string.
1302         (jit_reader_load_command): Update.
1303         * main.c (gdb_datadir): Change to std::string.
1304         (python_libdir): Likewise.
1305         (set_gdb_data_directory): Update.
1306         (relocate_path): Change to return std::string.
1307         (relocate_gdb_directory): Change to return std::string.
1308         (relocate_gdbinit_path_maybe_in_datadir): Update.
1309         (captured_main_1): Update.
1310         * python/python.c (do_start_initialization): Update.
1311         * top.c (show_gdb_datadir): Update.
1312         * xml-syscall.c (xml_init_syscalls_info): Update.
1313         (init_syscalls_info): Update.
1314
1315 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1316
1317         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1318         out of get_init_files.
1319         (get_init_files): Update.
1320
1321 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1322
1323         * main.c (get_init_files): Change to use std::string.
1324         (captured_main_1): Update.
1325         (print_gdb_help): Update.
1326
1327 2019-09-11  Ali Tamur  <tamur@google.com>
1328
1329         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1330         implementation.
1331
1332 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1333
1334         * dbxread.c (read_dbx_symtab): Update.
1335         * dwarf2read.c (load_partial_dies): Update.
1336         * mdebugread.c (parse_partial_symbols): Update.
1337         (handle_psymbol_enumerators): Update.
1338         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1339         * psymtab.c (add_psymbol_to_bcache): Likewise.
1340         (add_psymbol_to_list): Likewise.
1341         * symtab.c (symbol_set_names): Likewise.
1342         * symtab.h (symbol_set_names): Likewise.
1343         * xcoffread.c (scan_xcoff_symtab): Update.
1344
1345 2019-09-11  Tom Tromey  <tom@tromey.com>
1346
1347         * symfile-mem.c (symbol_file_add_from_memory): Use
1348         bfd_set_filename.
1349         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1350         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1351
1352 2019-09-10  Tom Tromey  <tromey@adacore.com>
1353
1354         * dwarf-index-write.c (write_psymbols): Extend error message.
1355         (debug_names::insert): Add Ada code.
1356         (debug_names::write_psymbols): Remove Ada check.
1357         (debug_names) <m_string_obstack>: New member.
1358         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1359         (gdb_index_symbol_name_matcher::matches): Remove.
1360         (mapped_index_base::find_name_components_bounds): Add "lang"
1361         parameter.
1362         (mapped_index_base::build_name_components): Also split names
1363         according to Ada syntax.
1364         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1365         type of "match_callback".
1366         (check_match, check_find_bounds_finds)
1367         (dw2_expand_symtabs_matching): Update.
1368         (dw2_debug_names_iterator): Add new constructor.
1369         (dw2_debug_names_map_matching_symbols): New function.
1370         (dw2_debug_names_expand_symtabs_matching): Update.
1371         (dwarf2_debug_names_functions): Use
1372         dw2_debug_names_map_matching_symbols.
1373
1374 2019-09-10  Tom Tromey  <tromey@adacore.com>
1375
1376         * dwarf2read.c (dw2_get_file_names_reader): Add the
1377         CU's file name to the results.
1378
1379 2019-09-10  Tom Tromey  <tromey@adacore.com>
1380
1381         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1382         map_matching_symbols.  Update.
1383         * dwarf2read.c (dw2_map_matching_symbols): Update.
1384         * psymtab.c (match_partial_symbol): Change type; update.
1385         (psym_map_matching_symbols): Likewise.
1386         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1387         type; update.
1388         * symfile.h (struct quick_symbol_functions)
1389         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1390         Remove "match".
1391
1392 2019-09-10  Tom Tromey  <tromey@adacore.com>
1393
1394         * psymtab.c (map_block): Remove.
1395         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1396         * symtab.c (iterate_over_symbols_terminated): New function.
1397         * symtab.c (iterate_over_symbols_terminated): Declare.
1398
1399 2019-09-10  Tom Tromey  <tromey@adacore.com>
1400
1401         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1402         * language.h (struct language_defn) <la_iterate_over_symbols>:
1403         Return bool.
1404         * symtab.c (iterate_over_symbols): Return bool.
1405         * symtab.h (iterate_over_symbols): Return bool.
1406
1407 2019-09-10  Tom Tromey  <tromey@adacore.com>
1408
1409         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1410         (add_nonlocal_symbols): Update.
1411         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1412         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1413         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1414         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1415         Change type of "callback".  Remove "data".
1416
1417
1418 2019-09-09  Ali Tamur  <tamur@google.com>
1419
1420         * dwarf2read.c (comp_unit_head): Update comment.
1421         (dwarf2_dwo_name): New function declaration.
1422         (dwarf_unit_type_name): New function declaration.
1423         (read_comp_unit_head): Add support for new compilation units,
1424         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1425         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1426         (currently named as "signature") in their header. Also clarify error
1427         messages.
1428         (lookup_dwo_id): New function. Returns the dwo id of the given
1429         compile unit.
1430         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1431         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1432         functions.
1433         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1434         (dwarf2_dwo_name): Get the dwo name if present.
1435         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1436         purposes.
1437
1438 2019-09-09  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1441
1442 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1443
1444         * python/python.c (do_start_initialization): Make progname_copy static,
1445         to avoid a leak report.
1446
1447 2019-09-08  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1450
1451 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1452
1453         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1454         Change type to gdb::optional<block_enum>.
1455         (dw2_symtab_iter_init): Change block_index parameter type
1456         to gdb::optional<block_enum>.
1457         (dw2_lookup_symbol): Change block_index parameter
1458         type to block_enum.c
1459         (dw2_debug_names_lookup_symbol): Likewise.
1460         * psymtab.c (psym_lookup_symbol): Likewise.
1461         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1462         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1463         Likewise.
1464
1465 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1466
1467         * defs.h (relocate_gdb_directory): Change int to bool in
1468         signature and rename flag to relocatable.
1469         * main.c (relocate_path): Likewise.
1470         (relocate_gdb_directory): Likewise.
1471
1472 2019-09-06  Alan Modra  <amodra@gmail.com>
1473
1474         * coffread.c (coff_symfile_read): Constify filename variable.
1475         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1476         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1477         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1478         * solib.c (reload_shared_libraries_1): Likewise.
1479         * symfile.c (reread_symbols): Likewise.
1480         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1481         * solib-darwin.c (darwin_bfd_open): Likewise.
1482         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1483
1484 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1487         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1488
1489 2019-09-03  Tom Tromey  <tromey@adacore.com>
1490
1491         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1492         types.
1493         (has_negatives): Unbias a range type bound.
1494         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1495         * gdbtypes.c (operator==): Handle new field.
1496         (create_range_type): Add "bias" parameter.
1497         (create_static_range_type, resolve_dynamic_range): Update.
1498         * gdbtypes.h (struct range_bounds) <bias>: New member.
1499         (create_range_type): Add bias parameter.
1500         * printcmd.c (print_scalar_formatted): Unbias range types.
1501         * value.c (unpack_long): Unbias range types.
1502         (pack_long): Bias range types.
1503
1504 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1505
1506         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1507         probe arguments.
1508
1509 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1510
1511         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1512         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1513         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1514         (compile_probe_arg): Likewise.
1515         * probe.h (get_argument_count): Likewise.
1516         * solib-svr4.c (solib_event_probe_action): Likewise.
1517         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1518
1519 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1522         code to here...
1523         (svr4_create_solib_event_breakpoints): ...from here.
1524
1525 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1526
1527         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1528         suffix from warning message.
1529
1530 2019-08-30  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-winsource.h (struct tui_source_window_base)
1533         <refresh_all>: Don't declare.
1534         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1535         Remove.
1536         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1537         tui_show_locator_content.
1538         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1539         declare.
1540         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1541         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1542         declare.
1543
1544 2019-08-30  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1547
1548 2019-08-30  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1551         Remove unnecessary forward declarations.
1552
1553 2019-08-30  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1556         rerender.
1557         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1558         tui_show_locator_content.
1559
1560 2019-08-30  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1563         (tui_locator_window::rerender): Rewrite using body of previous
1564         tui_show_locator_content.
1565
1566 2019-08-30  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1569         set_locator_fullname>: New methods.
1570         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1571         Rename from tui_set_locator_fullname.
1572         (tui_locator_window::set_locator_info): Rename from
1573         tui_set_locator_info.  Return bool.
1574         (tui_update_locator_fullname, tui_show_frame_info): Update.
1575
1576 2019-08-30  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1579
1580 2019-08-30  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1583         call touchwin.
1584
1585 2019-08-30  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-wingeneral.c (box_win): Assume win_info and
1588         win_info->handle cannot be NULL.
1589
1590 2019-08-30  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1593         refresh_window>: Declare.
1594         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1595         resize.
1596         (tui_data_item_window::rerender): Rename from
1597         tui_display_register.
1598         (tui_data_item_window::refresh_window): New method.
1599         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1600         no-op.
1601
1602 2019-08-30  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1605         regs_column_count, current_group>: Move later.  Now private.
1606         <get_current_group>: New method.
1607         * tui/tui-regs.c (tui_reg_command): Update.
1608         * tui/tui-layout.c (tui_set_layout): Update.
1609
1610 2019-08-30  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1613         (tui_data_window::rerender): Don't call
1614         check_and_display_highlight_if_needed.
1615         (tui_data_window::refresh_all): Remove call to
1616         erase_data_content.
1617
1618 2019-08-30  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1621         (tui_data_window::display_registers_from)
1622         (tui_data_window::display_reg_element_at_line)
1623         (tui_data_window::display_registers_from_line): Remove checks of
1624         "empty".
1625
1626 2019-08-30  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1629         Don't declare.
1630         * tui/tui-regs.c (tui_data_window::show_registers): Call
1631         rerender.
1632         (tui_data_window::rerender): Rename from display_all_data.
1633         (tui_data_window::rerender): Remove old implementation.
1634
1635 2019-08-30  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1638         text.
1639         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1640
1641 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1642             Sergio Durigan Junior  <sergiodj@redhat.com>
1643
1644         PR win32/24284
1645         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1646
1647 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1650         when searching for types.
1651
1652 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * f-lang.c (f_language_defn): Use f_print_typedef.
1655         * f-lang.h (f_print_typedef): Declare.
1656         * f-typeprint.c (f_print_typedef): Define.
1657
1658 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1659
1660         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1661
1662 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * cli/cli-utils.c (info_print_options_defs): Delete.
1665         (make_info_print_options_def_group): Delete.
1666         (extract_info_print_options): Delete.
1667         (info_print_command_completer): Delete.
1668         (info_print_args_help): Add extra parameter, and optionally
1669         include text about -n flag.
1670         * cli/cli-utils.h (struct info_print_options): Delete.
1671         (extract_info_print_options): Delete declaration.
1672         (info_print_command_completer): Delete declaration.
1673         (info_print_args_help): Add extra parameter, extend header
1674         comment.
1675         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1676         search_symbols.
1677         * stack.c (struct info_print_options): New type.
1678         (info_print_options_defs): New file scoped variable.
1679         (make_info_print_options_def_group): New static function.
1680         (info_print_command_completer): New static function.
1681         (info_locals_command): Update to use new local functions.
1682         (info_args_command): Likewise.
1683         (_initialize_stack): Add extra parameter to calls to
1684         info_print_args_help.
1685         * symtab.c (search_symbols): Add extra parameter, use this to
1686         possibly excluse non-debug symbols.
1687         (symtab_symbol_info): Add extra parameter, which is passed on to
1688         search_symbols.
1689         (struct info_print_options): New type.
1690         (info_print_options_defs): New file scoped variable.
1691         (make_info_print_options_def_group): New static function.
1692         (info_print_command_completer): New static function.
1693         (info_variables_command): Update to use local functions, and pass
1694         extra parameter through to symtab_symbol_info.
1695         (info_functions_command): Likewise.
1696         (info_types_command): Pass additional argument through to
1697         symtab_symbol_info.
1698         (rbreak_command): Pass extra argument to search_symbols.
1699         (_initialize_symtab): Add extra arguments for calls to
1700         info_print_args_help, and update help text for 'info variables',
1701         'whereis', and 'info functions' commands.
1702         * symtab.h (search_symbols): Add extra argument to declaration.
1703         * NEWS: Mention new flags.
1704
1705 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1706
1707         * symtab.c (lookup_static_symbol): Call the new function (and move
1708         it down to be next to lookup_global_symbol).
1709         (struct global_sym_lookup_data): Add block_enum member and rename to...
1710         (struct global_or_static_sym_lookup_data): ...this.
1711         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1712         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1713         (lookup_symbol_global_or_static_iterator_cb): ...this.
1714         (lookup_global_or_static_symbol): New function.
1715         (lookup_global_symbol): Call new function.
1716
1717 2019-08-26  Tom de Vries  <tdevries@suse.de>
1718
1719         PR c++/24852
1720         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1721         when pc_probe.prob == NULL.
1722
1723 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1724
1725         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1726         variable symbol_linkage to symbol_linkage_.
1727
1728 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1729
1730         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1731         represent whether the symbol is static, dynamic, or we don't
1732         know.
1733
1734 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1735
1736         * gdb/rx-tdep.c (rx_register_names): New.
1737         (rx_register_name): Delete.
1738         (rx_psw_type): Delete.
1739         (rx_fpsw_type): Delete.
1740         (rx_register_type): Delete.
1741         (rx_gdbarch_init): Convert target-descriptions.
1742         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1743         * gdb/features/Makefile: Add rx.xml.
1744         * gdb/features/rx.xml: New.
1745         * gdb/features/rx.c: Generated.
1746         * gdb/NEWS: Mention target description support.
1747
1748 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1749
1750         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1751         *slot_ptr.
1752
1753 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1754
1755         * configure.ac: Don't check for 'dlfcn.h' (moved to
1756         gdbsupport/common.m4).
1757         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1758         'gdbsupport/'.
1759         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1760         * compile/compile-c-support.c: Include
1761         'gdbsupport/gdb-dlfcn.h'.
1762         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1763         * gdb-dlfcn.c: Move to...
1764         * gdbsupport/gdb-dlfcn.c: ... here.
1765         * gdb-dlfcn.h: Move to...
1766         * gdbsupport/gdb-dlfcn.h: ... here.
1767
1768 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1769
1770         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1771         the offset field signed.
1772
1773 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1774
1775         * python/lib/gdb/__init__.py (_execute_file): New function.
1776         * python/python.c (python_run_simple_file): Call gdb._execute_file
1777         on Windows.
1778
1779 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1782         all uses as this was never set to anything but a zero value.
1783
1784 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1785
1786         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1787
1788 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1789
1790         * tui/tui-data.h (tui_gen_win_info): Add an =default
1791         move constructor, required by some GCC versions.
1792
1793 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1794
1795         * go32-nat.c (go32_sysinfo): Add hygon_p.
1796
1797 2019-08-20  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1800         line_from_reg_element_no, first_reg_element_no_inline,
1801         display_all_data, delete_data_content_windows,
1802         erase_data_content>: Now private.
1803
1804 2019-08-20  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1807         (tui_unhighlight_win, tui_highlight_win)
1808         (tui_win_info::make_window): Update.
1809         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1810
1811 2019-08-20  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1814         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1815         (MAX_PID_WIDTH): Move to tui-stack.c.
1816         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1817         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1818         (MAX_PID_WIDTH): Move from tui-data.h.
1819
1820 2019-08-20  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1823         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1824         (box_win): Update.
1825         (tui_gen_win_info::make_window): Rename from tui_make_window.
1826         (tui_win_info::make_window): New method.
1827         (tui_gen_win_info::make_visible): Update.
1828         * tui/tui-source.c (tui_source_window::set_contents): Update.
1829         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1830         (tui_data_window::display_registers_from): Update.
1831         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1832         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1833         Declare.
1834         <can_box>: Remove.
1835         <title>: Remove.
1836         (struct tui_win_info) <make_window>: Declare.
1837         <can_box>: Now virtual.
1838         <title>: New member.
1839         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1840         * tui/tui-command.c (tui_cmd_window::resize): Update.
1841
1842 2019-08-20  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1845         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1846         (tui_data_window::check_register_values): Update.
1847
1848 2019-08-20  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-regs.h (struct tui_data_window): Use
1851         DISABLE_COPY_AND_ASSIGN.
1852         <regs_content>: Change type, removing unique_ptr.
1853         <tui_data_window>: Add move constructor.
1854         * tui/tui-regs.c (tui_data_window::show_registers)
1855         (tui_data_window::show_register_group)
1856         (tui_data_window::display_registers_from)
1857         (tui_data_window::display_registers_from)
1858         (tui_data_window::first_data_item_displayed)
1859         (tui_data_window::delete_data_content_windows)
1860         (tui_data_window::rerender, tui_data_window::refresh_window)
1861         (tui_data_window::check_register_values): Update.
1862
1863 2019-08-20  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1866         show_register_group>: Declare.
1867         (tui_show_register_group): Don't declare.
1868         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1869         tui_show_registers.
1870         (tui_data_window::show_register_group): Rename from
1871         tui_show_register_group.
1872         (tui_data_window::check_register_values, tui_reg_command):
1873         Update.
1874         * tui/tui-layout.c (tui_set_layout): Update.
1875
1876 2019-08-20  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1879         Declare.
1880         (tui_check_register_values): Don't declare.
1881         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1882         from tui_check_register_values.
1883         * tui/tui-hooks.c (tui_register_changed): Update.
1884
1885 2019-08-20  Tom Tromey  <tom@tromey.com>
1886
1887         * tui/tui-regs.c (tui_reg_layout): Move later.
1888         (tui_show_registers): Don't enable TUI mode or change layout.
1889
1890 2019-08-20  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-regs.h (struct tui_data_item_window)
1893         <~tui_data_item_window>: Remove.
1894         <content>: Now a unique_xmalloc_ptr.
1895         * tui/tui-regs.c (tui_register_format): Return a
1896         unique_xmalloc_ptr.
1897         (tui_get_register): Update.
1898         (~tui_data_item_window): Remove.
1899         (tui_data_window::display_registers_from, tui_display_register):
1900         Update.
1901         * tui/tui-io.h (tui_expand_tabs): Update.
1902         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1903         Remove "col" parameter.
1904
1905 2019-08-20  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1908         field.
1909         * tui/tui-regs.c (~tui_data_item_window): Update.
1910
1911 2019-08-20  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1914         earlier.
1915
1916 2019-08-20  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1919
1920 2019-08-20  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-source.h (struct tui_source_window): Update.
1923         * tui/tui-regs.c (tui_show_registers): Update.
1924         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1925         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1926         (NO_REGS_STRING): Remove defines.
1927
1928 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1929
1930         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1931         unnecessary thread walk if remote doesn't support the packet.
1932
1933 2019-08-19  Tom Tromey  <tromey@adacore.com>
1934
1935         * python/py-value.c (value_has_field): Fix indentation.
1936
1937 2019-08-19  Tom Tromey  <tromey@adacore.com>
1938
1939         * printcmd.c (do_one_display, info_display_command): Update.
1940         * block.h (contained_in): Return bool.  Add allow_nested
1941         parameter.
1942         * block.c (contained_in): Return bool.  Add allow_nested
1943         parameter.
1944
1945 2019-08-19  Tom Tromey  <tom@tromey.com>
1946
1947         * configure: Rebuild.
1948         * configure.ac: Disallow the combination of -static-libstdc++ and
1949         source highlight.
1950         * source-cache.c (get_language_name): Handle rust.
1951         (source_cache::get_source_lines): Ignore highlighting exceptions.
1952
1953 2019-08-16  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1956         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1957         (struct tui_source_window_base) <make_visible, refresh_window,
1958         resize>: Remove methods.
1959         <execution_info>: Remove field.
1960         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1961         (tui_show_source_line, tui_source_window_base)
1962         (~tui_source_window_base): Update.
1963         (tui_source_window_base::resize)
1964         (tui_source_window_base::make_visible)
1965         (tui_source_window_base::refresh_window): Remove.
1966         (tui_source_window_base::update_exec_info): Update.
1967         * tui/tui-source.c (tui_source_window::set_contents): Update.
1968         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1969
1970 2019-08-16  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1973         deprecated_query_hook.
1974
1975 2019-08-16  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1978         (tui_update_source_windows_with_line): Update.
1979         * tui/tui-source.h (struct tui_source_window)
1980         <show_symtab_source>: Declare.
1981         (tui_show_symtab_source): Don't declare.
1982         * tui/tui-source.c (tui_show_symtab_source): Rename from
1983         tui_show_symtab_source.
1984
1985 2019-08-16  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.h (struct tui_source_window_base)
1988         <set_contents>: Declare.
1989         * tui/tui-winsource.c
1990         (tui_source_window_base::update_source_window_as_is): Update.
1991         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1992         Declare.
1993         (tui_set_source_content): Don't declare.
1994         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1995         tui_set_source_content.
1996         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1997         Declare.
1998         (tui_set_disassem_content): Don't declare.
1999         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2000         tui_set_disassem_content.
2001
2002 2019-08-16  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-winsource.h (struct tui_source_window_base)
2005         <update_breakpoint_info>: Declare.
2006         (tui_update_breakpoint_info): Don't declare.
2007         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2008         (tui_update_all_breakpoint_info): Update.
2009         (tui_source_window_base::update_breakpoint_info): Rename from
2010         tui_update_breakpoint_info.
2011         (tui_source_window_base::update_exec_info): Update.
2012
2013 2019-08-16  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.h (struct tui_source_window_base)
2016         <update_source_window>: Declare.
2017         (tui_update_source_window): Don't declare.
2018         * tui/tui-winsource.c
2019         (tui_source_window_base::update_source_window): Rename from
2020         tui_update_source_window.
2021         (tui_source_window_base::rerender): Update.
2022         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2023         * tui/tui-disasm.c (tui_show_disassem)
2024         (tui_show_disassem_and_update_source)
2025         (tui_disasm_window::maybe_update): Update.
2026
2027 2019-08-16  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-winsource.h (struct tui_source_window_base)
2030         <update_source_window_as_is>: Declare.
2031         (tui_update_source_window_as_is): Don't declare.
2032         * tui/tui-winsource.c (tui_update_source_window): Update
2033         (tui_source_window_base::update_source_window_as_is): Rename from
2034         tui_update_source_window_as_is.
2035         (tui_source_window_base::refill): Update.
2036         * tui/tui-source.c (tui_show_symtab_source): Update.
2037         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2038         Update.
2039
2040 2019-08-16  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-winsource.h (tui_update_source_window)
2043         (tui_update_source_window_as_is): Remove "noerror" parameter.
2044         * tui/tui-winsource.c (tui_update_source_window)
2045         (tui_update_source_window_as_is): Remove "noerror" parameter.
2046         (tui_update_source_windows_with_addr)
2047         (tui_update_source_windows_with_line)
2048         (tui_source_window_base::rerender)
2049         (tui_source_window_base::refill): Update.
2050         * tui/tui-source.h (tui_set_source_content)
2051         (tui_show_symtab_source): Remove "noerror" parameter.
2052         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2053         parameter.
2054         (tui_show_symtab_source): Likewise.
2055         (tui_source_window::maybe_update): Update.
2056         * tui/tui-disasm.c (tui_show_disassem)
2057         (tui_show_disassem_and_update_source)
2058         (tui_disasm_window::do_scroll_vertical)
2059         (tui_disasm_window::maybe_update): Update.
2060
2061 2019-08-16  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui.c (tui_is_window_visible): Update.
2064         * tui/tui-wingeneral.c (tui_make_window)
2065         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2066         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2067         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2068         (tui_set_win_height_command, parse_scrolling_args): Update.
2069         * tui/tui-source.c (tui_source_window::style_changed): Update.
2070         * tui/tui-regs.c (tui_show_registers)
2071         (tui_data_window::first_data_item_displayed)
2072         (tui_data_window::delete_data_content_windows)
2073         (tui_check_register_values, tui_reg_command): Update.
2074         * tui/tui-disasm.c (tui_show_disassem): Update.
2075         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2076         method.
2077         <is_visible>: Remove field.
2078         * tui/tui-data.c (tui_next_win, tui_prev_win)
2079         (tui_delete_invisible_windows): Update.
2080
2081 2019-08-16  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-winsource.h (struct tui_source_window_base)
2084         <m_has_locator>: Remove.
2085         * tui/tui-layout.c (show_source_disasm_command, show_data)
2086         (show_source_or_disasm_and_command): Update.
2087
2088 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2089
2090         * NEWS (Other MI changes): New subsection.
2091         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2092         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2093         * arch-utils.c (default_get_pc_address_flags): New function.
2094         * arch-utils.h (default_get_pc_address_flags): New declaration.
2095         * gdbarch.sh: Add get_pc_address_flags.
2096         * gdbarch.c: Regenerate.
2097         * gdbarch.h: Likewise.
2098         * stack.c (print_pc): New function.
2099         (print_frame_info) (print_frame): Call print_pc.
2100
2101 2019-08-16  Tom de Vries  <tdevries@suse.de>
2102
2103         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2104         print_objfile_section_info.
2105
2106 2019-08-15  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2109         calling update_cmdwin_start_line.
2110         * tui/tui-winsource.h (struct tui_source_window_base)
2111         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2112         <rerender>: Declare.
2113         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2114         Call rerender.
2115         (tui_source_window_base::set_new_height): Remove.
2116         (tui_source_window_base::rerender): Rename from
2117         do_make_visible_with_new_height.
2118         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2119         resize method.
2120         (tui_win_info::make_invisible_and_set_new_height)
2121         (tui_win_info::make_visible_with_new_height): Remove.
2122         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2123         Declare.
2124         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2125         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2126         do_make_visible_with_new_height>: Don't declare.
2127         <rerender>: Declare.
2128         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2129         set_new_height.
2130         (tui_data_window::do_make_visible_with_new_height): Remove.
2131         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2132         call tui_show_locator_content.
2133         (tui_gen_win_info::resize): Call rerender.
2134         (show_source_or_disasm_and_command): Don't call
2135         tui_show_locator_content.
2136         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2137         method.
2138         (struct tui_win_info) <rerender>: Declare.
2139         <set_new_height, make_invisible_and_set_new_height,
2140         make_visible_with_new_height>: Don't declare.
2141         * tui/tui-data.c (tui_win_list::rerender): New method.
2142         * tui/tui-command.h (struct tui_cmd_window)
2143         <do_make_visible_with_new_height>: Don't declare.
2144         * tui/tui-command.c
2145         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2146
2147 2019-08-15  Tom Tromey  <tromey@adacore.com>
2148
2149         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2150         * ada-lang.c (ada_enum_name): Likewise.
2151
2152 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2153
2154         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2155         leading underscore.
2156         (GdbOutputErrorFile): Likewise.
2157         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2158         accordingly.
2159         (execute_unwinders): Rename to have a leading underscore.
2160         (auto_load_packages): Likewise.
2161         (global scope): Adjust call to auto_load_packages accordingly.
2162         (GdbSetPythonDirectory): Likewise.
2163         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2164         instead of execute_unwinders.
2165
2166 2019-08-15  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2169         (show_data): Don't change window visibility.
2170         (tui_gen_win_info::resize): Remove special case for command
2171         window.  Use wresize, when available.
2172         (show_source_or_disasm_and_command): Don't change window
2173         visibility.
2174         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2175         <make_visible>: New method.
2176         * tui/tui-command.c (tui_cmd_window::resize): New method.
2177
2178 2019-08-15  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2181         (struct tui_source_windows): New.
2182         * tui/tui-winsource.c (tui_display_main): Update.
2183         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2184         (new_height_ok, parse_scrolling_args): Update.
2185         * tui/tui-layout.c (show_layout, show_data): Update.
2186         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2187         (tui_add_to_source_windows): Don't declare.
2188         * tui/tui-data.c (source_windows, tui_source_windows)
2189         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2190
2191 2019-08-15  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2194         Rename from reset.
2195         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2196         * tui/tui-layout.c (show_source_disasm_command, show_data):
2197         Update.
2198         (tui_gen_win_info::resize): Rename.
2199         (show_source_or_disasm_and_command): Update.
2200         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2201         reset.
2202
2203 2019-08-15  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2206         * tui/tui-interp.c (tui_interp::init): Don't call
2207         tui_initialize_static_data.
2208         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2209
2210 2019-08-15  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2213         examine tui_win_list.
2214
2215 2019-08-15  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2218         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2219         tui_clear_source_content.
2220         (tui_clear_source_content): Remove.
2221         (tui_source_window_base::do_erase_source_content): Hoist call to
2222         content.clear().
2223         * tui/tui-stack.c (tui_show_frame_info): Don't call
2224         tui_clear_source_content.
2225
2226 2019-08-15  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-winsource.h (struct tui_source_window_base)
2229         <do_erase_source_content>: New method.
2230         <erase_source_content>: New method.
2231         (tui_erase_source_content): Don't declare.
2232         * tui/tui-winsource.c (tui_clear_source_content): Update.
2233         (tui_source_window_base::do_erase_source_content): Rename from
2234         tui_erase_source_content.
2235         (tui_source_window_base::show_source_content): Update.
2236         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2237         * tui/tui-source.h (struct tui_source_window)
2238         <erase_source_content>: New method.
2239         * tui/tui-disasm.h (struct tui_disasm_window)
2240         <erase_source_content>: New method.
2241
2242 2019-08-15  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2245         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2246         constructor.
2247         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2248         * tui/tui-source.c (tui_set_source_content): Update.
2249         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2250
2251 2019-08-15  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2254         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2255         tui-source.c.
2256         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2257         Declare.
2258         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2259         method.
2260         (tui_source_window::maybe_update): Update.
2261
2262 2019-08-15  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2265         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2266         tui-disasm.c.
2267         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2268         Declare.
2269         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2270         method.
2271         (tui_disasm_window::maybe_update): Update.
2272
2273 2019-08-15  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-winsource.h (struct tui_source_window_base)
2276         <maybe_update>: Declare.
2277         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2278         method.
2279         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2280         Declare.
2281         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2282         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2283         Declare.
2284         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2285
2286 2019-08-15  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2289
2290 2019-08-15  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.c: Include tui-stack.h.
2293         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2294         (struct tui_locator_window): Move from tui-data.h.
2295         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2296         (tui_initialize_static_data): Move from tui-data.c.
2297         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2298         (struct tui_locator_window): Move to tui-stack.c.
2299         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2300         (tui_initialize_static_data): Move to tui-stack.c.
2301
2302 2019-08-15  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-layout.c (show_source_disasm_command)
2305         (show_source_or_disasm_and_command): Use make_visible method, not
2306         tui_make_window.
2307         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2308         Remove.
2309
2310 2019-08-15  Tom Tromey  <tom@tromey.com>
2311
2312         * tui/tui-wingeneral.h (tui_make_window): Update.
2313         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2314         parameter.
2315         (tui_gen_win_info::make_visible): Update.
2316         * tui/tui-regs.c (tui_data_window::display_registers_from):
2317         Update.
2318         * tui/tui-layout.c (show_source_disasm_command)
2319         (show_source_or_disasm_and_command): Update.
2320         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2321         (enum tui_box): Remove.
2322         (struct tui_win_info) <can_box>: New method.
2323         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2324         method.
2325
2326 2019-08-15  Tom de Vries  <tdevries@suse.de>
2327
2328         * linux-nat-trad.c: Include gdbarch.h.
2329
2330 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2331
2332         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2333         register sizes.
2334
2335 2019-08-14  Tom Tromey  <tromey@adacore.com>
2336
2337         * darwin-nat.c: Include gdbarch.h.
2338         * darwin-nat-info.c: Include gdbarch.h.
2339
2340 2019-08-13  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2343         Remove.
2344         * tui/tui-data.c (tui_initialize_static_data): Update.
2345
2346 2019-08-13  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-winsource.h (struct tui_exec_info_window)
2349         <~tui_exec_info_window, maybe_allocate_content, get_content,
2350         m_content>: Remove.
2351         (struct tui_source_window_base) <set_exec_info_content,
2352         show_exec_info_content>: Don't declare.
2353         * tui/tui-winsource.c
2354         (tui_exec_info_window::maybe_allocate_content): Remove.
2355         (tui_source_window_base::update_exec_info): Rename from
2356         set_exec_info_content.
2357         (tui_source_window_base::show_exec_info_content)
2358         (tui_source_window_base::update_exec_info): Remove.
2359
2360 2019-08-13  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2363         declare.
2364         * tui/tui-winsource.c (tui_update_source_window_as_is)
2365         (tui_update_source_windows_with_addr, tui_erase_source_content):
2366         Update.
2367         (tui_clear_exec_info_content): Remove.
2368
2369 2019-08-13  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2372         declare.
2373         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2374         call tui_erase_exec_info_content.
2375         (tui_clear_exec_info_content): Rename from
2376         tui_erase_exec_info_content.
2377         (tui_clear_exec_info_content): Delete.
2378
2379 2019-08-13  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-winsource.h (struct tui_source_window_base)
2382         <show_exec_info_content>: Declare.
2383         (tui_show_exec_info_content): Don't declare.
2384         * tui/tui-winsource.c
2385         (tui_source_window_base::show_exec_info_content): Rename from
2386         tui_show_exec_info_content.
2387         (tui_source_window_base::update_exec_info): Update.
2388
2389 2019-08-13  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2392         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2393         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2394         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2395         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2396         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2397         ... here.
2398
2399 2019-08-13  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-winsource.h (struct tui_source_window_base)
2402         <update_exec_info>: Declare.
2403         (tui_update_exec_info): Don't declare.
2404         * tui/tui-winsource.c (tui_update_source_window_as_is)
2405         (tui_source_window_base::refresh_all)
2406         (tui_update_all_breakpoint_info): Update.
2407         (tui_source_window_base::update_exec_info): Rename from
2408         tui_update_exec_info.
2409         * tui/tui-stack.c (tui_show_frame_info): Update.
2410
2411 2019-08-13  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-winsource.h (struct tui_source_window_base)
2414         <set_exec_info_content>: Declare.
2415         (tui_set_exec_info_content): Don't declare.
2416         * tui/tui-winsource.c
2417         (tui_source_window_base::set_exec_info_content): Rename from
2418         tui_set_exec_info_content.
2419         (tui_update_exec_info): Update.
2420
2421 2019-08-13  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-winsource.h (struct tui_source_window_base)
2424         <show_source_content>: Declare.
2425         (tui_show_source_content): Don't declare.
2426         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2427         (tui_source_window_base::show_source_content): Rename from
2428         tui_show_source_content.
2429         (tui_source_window_base::refresh_all): Update.
2430         * tui/tui-layout.c (show_source_disasm_command)
2431         (show_source_or_disasm_and_command): Update.
2432
2433 2019-08-13  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-winsource.c (tui_erase_source_content)
2436         (tui_show_source_content, tui_source_window_base::refresh_all):
2437         Update.
2438         * tui/tui-wingeneral.h
2439         (tui_check_and_display_highlight_if_needed): Don't declare.
2440         * tui/tui-wingeneral.c
2441         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2442         check_and_display_highlight_if_needed.
2443         * tui/tui-win.c (tui_rehighlight_all)
2444         (tui_win_info::make_visible_with_new_height): Update.
2445         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2446         (tui_data_window::erase_data_content)
2447         (tui_data_window::display_all_data): Update.
2448         * tui/tui-data.h (struct tui_win_info)
2449         <check_and_display_highlight_if_needed>: Declare.
2450
2451 2019-08-13  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-win.c (tui_resize_all): Call
2454         tui_delete_invisible_windows.
2455         * tui/tui-layout.c (show_layout): Call
2456         tui_delete_invisible_windows.
2457         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2458         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2459
2460 2019-08-13  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2463         tui_add_win_to_layout.
2464
2465 2019-08-13  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2468         * tui/tui-layout.c (tui_default_win_height): Now static.
2469
2470 2019-08-13  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2473         single switch.
2474         (show_source_disasm_command, show_source_or_disasm_and_command):
2475         Don't check current layout.
2476
2477 2019-08-13  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-wingeneral.c (make_all_visible): Remove.
2480         (tui_make_all_invisible): Simplify.
2481         * tui/tui-layout.c (tui_make_all_invisible): Move from
2482         tui-wingeneral.c; simplify.
2483         (show_layout): Hoist call to tui_make_all_invisible.
2484         (show_data): Don't call tui_make_all_invisible.
2485
2486 2019-08-13  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2489         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2490
2491 2019-08-13  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2494         tui-data.c.
2495         (show_source_disasm_command, show_data)
2496         (show_source_or_disasm_and_command): Don't use
2497         tui_set_current_layout_to.
2498         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2499         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2500         tui-layout.c.
2501         (tui_set_current_layout_to): Remove.
2502
2503 2019-08-13  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-layout.c (tui_set_layout): Update.
2506         * tui/tui-data.h (struct tui_layout_def): Remove.
2507         (tui_layout_def): Don't declare.
2508         * tui/tui-data.c (layout_def): Remove.
2509         (tui_layout_def): Remove.
2510
2511 2019-08-13  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-winsource.h (struct tui_source_window_base)
2514         <clear_detail>: No longer "override".
2515         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2516         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2517         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2518         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2519         Remove.
2520         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2521
2522 2019-08-13  Tom Tromey  <tromey@adacore.com>
2523
2524         * tracepoint.c: Don't include readline.h or history.h.
2525
2526 2019-08-12  Tom Tromey  <tom@tromey.com>
2527
2528         * configure: Rebuild.
2529         * configure.ac: Check for readline 7.
2530         * NEWS: Mention readline 7 requirement.
2531         * README: Update.
2532
2533 2019-08-12  Tom Tromey  <tom@tromey.com>
2534
2535         * mingw-hdep.c (gdb_select): Remove readline hack.
2536
2537 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2538
2539         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2540         when the function fails.
2541
2542 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2543
2544         * s390-tdep.c (s390_type_align): New function.
2545         (s390_gdbarch_init): Set it as type_align gdbarch method.
2546
2547 2019-08-09  Tom de Vries  <tdevries@suse.de>
2548
2549         PR gdb/24591
2550         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2551         pc_low with relocation offset.
2552
2553 2019-08-07  Tom Tromey  <tromey@adacore.com>
2554
2555         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2556         (print_frame_args): Update.
2557         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2558         Update.
2559         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2560         * frame.h (struct frame_arg): Add initializers.
2561         <error>: Now a unique_xmalloc_ptr.
2562
2563 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * NEWS: Expand the Pointer Authentication entry.
2566         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2567         (aarch64_frame_unmask_lr): ... to this.
2568         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2569         Call aarch64_frame_unmask_lr.
2570         * frame.c (struct frame_info): Add "masked" variable.
2571         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2572         (fprint_frame): Check for masked pc.
2573         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2574         declarations.
2575         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2576         * stack.c (print_frame): Check for masked pc.
2577
2578 2019-08-06  Tom Tromey  <tom@tromey.com>
2579
2580         * stabsread.c (patch_block_stabs, read_one_struct_field)
2581         (read_enum_type): Use obstack_strndup.
2582         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2583         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2584         * dwarf2read.c (guess_full_die_structure_name)
2585         (anonymous_struct_prefix): Use obstack_strndup.
2586         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2587         * c-exp.y (yylex): Use obstack_strndup.
2588         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2589         (write_var_or_type): Use obstack_strndup.
2590
2591 2019-08-06  Tom Tromey  <tom@tromey.com>
2592
2593         * symfile.c (reread_symbols): Use obstack_strdup.
2594         * stabsread.c (read_type): Use obstack_strdup.
2595         * gdb_obstack.h (obstack_strdup): New overload.
2596         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2597         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2598         (dwarf2_canonicalize_name): Use obstack_strdup.
2599         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2600         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2601         Use obstack_strdup.
2602
2603 2019-08-06  Tom Tromey  <tom@tromey.com>
2604
2605         * gdb_obstack.h (obstack_strdup): Define.
2606         * gdb_obstack.c (obstack_strdup): Don't define.
2607
2608 2019-08-06  Tom Tromey  <tom@tromey.com>
2609
2610         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2611         obstack_strdup.
2612         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2613         obstack_strdup.
2614         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2615         * stabsread.c (common_block_start): Use obstack_strdup.
2616         * objfiles.c (set_objfile_main_name, objfile): Use
2617         obstack_strdup.
2618         * namespace.c (add_using_directive): Use obstack_strdup.
2619         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2620         * jit.c (finalize_symtab): Use obstack_strdup.
2621         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2622         (guess_partial_die_structure_name, partial_die_info::fixup)
2623         (dwarf2_name): Use obstack_strdup.
2624         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2625         obstack_strdup.
2626         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2627         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2628         obstack_strdup.
2629         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2630
2631 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2632
2633         * unittests/help-doc-selftests.c: New file.
2634         * Makefile.in: Add the new file.
2635
2636 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2637
2638         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2639         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2640         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2641         the trailing '.' is not output, and the first character is uppercased.
2642         (print_help_for_command): Update call to print_doc_line.
2643         (print_doc_of_command): Likewise.
2644         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2645         * cli/cli-option.c (append_indented_doc): Do not append newline.
2646         (build_help_option): Append newline after first appended_indented_doc
2647         only if a second call is done.
2648         (build_help): Append 2 new lines before each option, except the first
2649         one.
2650         * compile/compile.c (_initialize_compile): Add new lines after
2651         %OPTIONS%, when not at the end of the help.
2652         Change help doc or code
2653         producing the help doc to respect the invariants.
2654         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2655         Also removed the new line after 'Options:', as all other commands
2656         do not put an empty line between 'Options:' and the first option.
2657         * printcmd.c (_initialize_printcmd): Likewise.
2658         * stack.c (_initialize_stack): Likewise.
2659         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2660         incorrectly telling COMMAND is optional.
2661         * ada-lang.c (_initialize_ada_language): Change help doc or code
2662         producing the help doc to respect the invariants.
2663         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2664         * breakpoint.c (_initialize_breakpoint): Likewise.
2665         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2666         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2667         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2668         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2669         _initialize_cli_style): Likewise.
2670         * corelow.c (core_target_info): Likewise.
2671         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2672         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2673         * filesystem.c (_initialize_filesystem): Likewise.
2674         * frame.c (_initialize_frame): Likewise.
2675         * gnu-nat.c (add_task_commands): Likewise.
2676         * infcall.c (_initialize_infcall): Likewise.
2677         * infcmd.c (_initialize_infcmd): Likewise.
2678         * interps.c (_initialize_interpreter): Likewise.
2679         * language.c (_initialize_language): Likewise.
2680         * linux-fork.c (_initialize_linux_fork): Likewise.
2681         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2682         * maint.c (_initialize_maint_cmds): Likewise.
2683         * memattr.c (_initialize_mem): Likewise.
2684         * printcmd.c (_initialize_printcmd): Likewise.
2685         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2686         _RegEx): Likewise.
2687         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2688         * record-btrace.c (_initialize_record_btrace): Likewise.
2689         * record-full.c (_initialize_record_full): Likewise.
2690         * record.c (_initialize_record): Likewise.
2691         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2692         * regcache.c (_initialize_regcache): Likewise.
2693         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2694         _initialize_remote): Likewise.
2695         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2696         * serial.c (_initialize_serial): Likewise.
2697         * skip.c (_initialize_step_skip): Likewise.
2698         * source.c (_initialize_source): Likewise.
2699         * stack.c (_initialize_stack): Likewise.
2700         * symfile.c (_initialize_symfile): Likewise.
2701         * symtab.c (_initialize_symtab): Likewise.
2702         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2703         * top.c (init_main): Likewise.
2704         * tracefile-tfile.c (tfile_target_info): Likewise.
2705         * tracepoint.c (_initialize_tracepoint): Likewise.
2706         * tui/tui-win.c (_initialize_tui_win): Likewise.
2707         * utils.c (add_internal_problem_command): Likewise.
2708         * valprint.c (value_print_option_defs): Likewise.
2709
2710 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2711
2712         PR build/24886
2713         * configure.ac: Drop enable-libmcheck support.
2714         * configure, config.in: Rebuild.
2715         * libmcheck.m4: Remove.
2716         * acinclude.m4: Don't include it.
2717         * Makefile.in: Don't distribute it.
2718         * top.c (print_gdb_configuration): Don't mention it.
2719
2720 2019-08-06  Tom Tromey  <tom@tromey.com>
2721
2722         * utils.c (set_output_style): Sometimes pass stream to
2723         emit_style_escape.
2724         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2725         * record-btrace.c (btrace_insn_history): Update.
2726         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2727         method.
2728         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2729         Update initializers.
2730         <m_uiout>: New field.
2731         <m_di>: Move lower.
2732         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2733         Remove "uiout" parameter.
2734         (dump_insns): Update.
2735         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2736         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2737
2738 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2739
2740         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2741         (error_in_psymtab_expansion): Likewise.
2742         (lookup_symbol_via_quick_fns): Likewise.
2743         (basic_lookup_transparent_type_quick): Likewise.
2744         (basic_lookup_transparent_type_1): Likewise.
2745
2746 2019-08-06  Tom Tromey  <tromey@adacore.com>
2747
2748         * source.c (last_source_error): Now bool.
2749         (print_source_lines_base): Make "noprint" bool.  Only open
2750         source file when last_source_visited changes.
2751
2752 2019-08-06  Tom Tromey  <tromey@adacore.com>
2753
2754         * annotate.c (annotate_source_line): Use g_source_cache.
2755         * source-cache.c (source_cache::get_plain_source_lines): Change
2756         parameters.  Populate m_offset_cache.
2757         (source_cache::ensure): New method.
2758         (source_cache::get_line_charpos): New method.
2759         (extract_lines): Move lower.  Change parameters.
2760         (source_cache::get_source_lines): Move lower.
2761         * source-cache.h (class source_cache): Update comment.
2762         <get_line_charpos>: New method.
2763         <get_source_lines>: Update comment.
2764         <clear>: Clear m_offset_cache.
2765         <get_plain_source_lines>: Change parameters.
2766         <ensure>: New method
2767         <m_offset_cache>: New member.
2768         * source.c (forget_cached_source_info_for_objfile): Update.
2769         (info_source_command): Use g_source_cache.
2770         (find_source_lines, open_source_file_with_line_charpos): Remove.
2771         (print_source_lines_base, search_command_helper): Use g_source_cache.
2772         * source.h (open_source_file_with_line_charpos): Don't declare.
2773         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2774         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2775         Use g_source_cache.
2776
2777 2019-08-06  Tom Tromey  <tromey@adacore.com>
2778
2779         * source-cache.c (source_cache::get_plain_source_lines):
2780         Remove "first_line" and "last_line" parameters.
2781         (source_cache::get_source_lines): Cache plain text.
2782         * source-cache.h (class source_cache)
2783         <get_plain_source_lines>: Update.
2784
2785 2019-08-06  Tom Tromey  <tromey@adacore.com>
2786
2787         * source-cache.c (extract_lines): No longer a method.
2788         Changed type of parameter.  Include final newline.
2789         (selftests::extract_lines_test): New function.
2790         (_initialize_source_cache): Likewise.
2791         * source-cache.h (class source_cache)
2792         <extract_lines>: Don't declare.
2793
2794 2019-08-06  Tom Tromey  <tromey@adacore.com>
2795
2796         * breakpoint.c (init_breakpoint_sal): Update.
2797         (breakpoint): Update.
2798         * breakpoint.h (struct breakpoint) <filter>: Now a
2799         unique_xmalloc_ptr.
2800
2801 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2802
2803         * NEWS: Mention dictionary access on blocks.
2804         * python/py-block.c (blpy_getitem): New function.
2805         (block_object_as_mapping): New struct.
2806         (block_object_type): Use new struct for tp_as_mapping field.
2807
2808 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2809
2810         * objfiles.h (objfile): Add a comment describing partial symbols.
2811
2812 2019-08-05  Tom Tromey  <tromey@adacore.com>
2813
2814         * compile/compile.c (_initialize_compile): Use _(), not N_().
2815         * thread.c (_initialize_thread): Use _(), not N_().
2816         * stack.c (_initialize_stack): Use _(), not N_().
2817         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2818
2819 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2820
2821         * dwarf2read.c (struct dw2_symtab_iterator):
2822         <want_specific_block>: Remove.
2823         <block_index>: Change type to gdb::optional.
2824         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2825         change type of BLOCK_INDEX parameter to gdb::optional.
2826         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2827         (dw2_lookup_symbol): Don't pass argument for
2828         WANT_SPECIFIC_BLOCK.
2829         (dw2_expand_symtabs_for_function): Don't pass argument for
2830         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2831         (class dw2_debug_names_iterator)
2832         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2833         parameter, change BLOCK_INDEX type to gdb::optional.
2834         <m_want_specific_block>: Remove.
2835         <m_block_index>: Change type to gdb::optional.
2836         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2837         gdb::optional.  Re-write in function of gdb::optional.
2838         (dw2_debug_names_lookup_symbol): Don't pass argument for
2839         WANT_SPECIFIC_BLOCK.
2840         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2841         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2842         BLOCK_INDEX.
2843
2844 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2845
2846         * NEWS: Mention changes to "info sources" command.
2847
2848 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2849
2850         * symtab.c (filename_partial_match_opts): New struct type.
2851         (struct output_source_filename_data): New members
2852         regexp, c_regexp, partial_match.
2853         (output_source_filename): Use new members to decide to print file.
2854         (info_sources_option_defs): New variable.
2855         (make_info_sources_options_def_group, print_info_sources_header,
2856         info_sources_command_completer):
2857         New functions.
2858         (info_sources_command): Read new optional arguments.
2859         (_initialize_symtab): Update info sources help.
2860
2861 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2862
2863         * ada-lang.c (exception_support_info_v0): Renamed from...
2864         (default_exception_support_info): ... this.  Create new
2865         definition for v1.
2866         (ada_has_this_exception_support): Look up catch_handlers_sym.
2867         (ada_exception_support_info_sniffer): Try v0 after default.
2868
2869 2019-08-01  Tom Tromey  <tromey@adacore.com>
2870
2871         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2872         gdbarch.h.
2873
2874 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2875
2876         * s12z-tdep.c: Fix include path for s12z-opc.h.
2877
2878 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2879
2880         * NEWS: Require GNU make 3.82.
2881
2882 2019-07-16  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2885         declare.
2886
2887 2019-07-30  Tom Tromey  <tromey@adacore.com>
2888
2889         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2890
2891 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2892
2893         * printcmd.c (print_address_symbolic): Print negative offsets.
2894         (build_address_symbolic): Force signed arithmetic when computing
2895         offset.
2896
2897 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2898
2899         PR/24474: Add a function to lookup static variables.
2900         * NEWS: Mention this new function.
2901         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2902         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2903         * python/python.c (python_GdbMethods): Add new function.
2904
2905 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2906
2907         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2908         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2909         (objfpy_lookup_static_symbol): New function.
2910         (objfile_object_methods): Add new functions.
2911
2912 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2913
2914         * NEWS: Mention 'set|show print frame-info'.  Mention new
2915         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2916         backtrace argument.  Mention that python frame filtering code
2917         is now consistent with what 'backtrace' command prints.
2918
2919 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2920
2921         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2922         comments.
2923         (print_frame_info_auto, print_frame_info_source_line,
2924         print_frame_info_location, print_frame_info_source_and_location,
2925         print_frame_info_location_and_address, print_frame_info_short_location):
2926         New declarations.
2927         (struct frame_print_options): New member print_frame_info.
2928         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2929         * stack.h (get_user_print_what_frame_info): New declaration.
2930         (frame_show_address): New declaration.
2931         * stack.c (print_frame_arguments_choices): New value 'presence'.
2932         (print_frame_info_auto, print_frame_info_source_line,
2933         print_frame_info_location, print_frame_info_source_and_location,
2934         print_frame_info_location_and_address, print_frame_info_short_location,
2935         print_frame_info_choices, print_frame_info_print_what): New definitions.
2936         (print_frame_args): Only print dots for args if print frame-arguments
2937         is 'presence'.
2938         (frame_print_option_defs): New element for "frame-info".
2939         (get_user_print_what_frame_info): New function.
2940         (frame_show_address): Make non static.  Move comment to stack.h.
2941         (print_frame_info_to_print_what): New function.
2942         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2943         to decide what to print.
2944         (backtrace_command_1): Handle the new print_frame_arguments_presence
2945         value.
2946         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2947         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2948         (py_print_frame): In non-mi mode, use LOCATION as default for
2949         print_what, similarly to frame information printed directly by
2950         backtrace command. Handle frame-info user option in non MI mode.
2951
2952 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2953
2954         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2955         Add case for debugging 32-bit target on 64-bit host.  Revise
2956         comment.
2957
2958 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2959
2960         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2961         instead of find_function_entry_range_from_pc.
2962
2963 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2964
2965         * stack.c (find_frame_funname): Remove code which preferred
2966         minsym over symtab sym in "certain pathological cases".
2967
2968         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2969         parameter.  Change type of "do_demangle" to bool.
2970         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2971         Pass suitable "prefer_sym_over_minsym" flag to
2972         build_address_symbolic().  Don't output "+" for negative offsets.
2973         * printcmd.c (print_address_symbolic): Update invocation of
2974         build_address_symbolic to include a "prefer_sym_over_minsym"
2975         flag.
2976         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2977         Restrict cases in which use of minimal symbol is preferred to that
2978         of a found symbol.  Update comments.
2979
2980         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2981         for entry pc when entry pc is out of range for that FDE.
2982
2983 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2984
2985         PR gdb/24839:
2986         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2987         type.
2988
2989 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2990
2991         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2992         this function's Python signature.
2993
2994
2995 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2996
2997         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2998         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2999         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3000         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3001         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3002
3003
3004 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3005
3006         * h8300-tdep.c (h8300_register_name_common): New.
3007         h8300_register_name): Use h8300_register_name_common.
3008         (h8300s_register_name): Likewise.
3009         (h8300sx_register_name): Likewise.
3010         (h8300h_register_nam): New.
3011         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3012
3013
3014 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3015
3016         * arm-tdep.c (arm_skip_cmse_entry): New function.
3017         (arm_is_sgstubs_section): New function.
3018         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3019
3020 2019-07-22  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3023         Don't self-assign.
3024
3025 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3028         type_print.
3029
3030 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3033         so that GDB doesn't match any msymbols when searching in the
3034         TYPES_DOMAIN.
3035         (print_symbol_info): Print using typedef_print or type_print based
3036         on the type of the symbol.  Add updated FIXME comment moved from...
3037         (_initialize_symtab): ... move and update FIXME comment to above.
3038
3039 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * NEWS: Mention adding -q option to "info types".
3042         * symtab.c (struct info_types_options): New struct.
3043         (info_types_options_defs): New variable.
3044         (make_info_types_options_def_group): New function.
3045         (info_types_command): Use gdb::option framework to parse options.
3046         (info_types_command_completer): New function.
3047         (_initialize_symtab): Extend the help text on "info types" and
3048         register command completer.
3049
3050 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3051
3052         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3053         (lookup_symbol_in_objfile): Change int to block_enum and add a
3054         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3055
3056 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3057
3058         * MAINTAINERS (Write After Approval): Add self.
3059
3060 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3061
3062         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3063         instruction to the dummy code region.
3064
3065 2019-07-19  Tom Tromey  <tromey@adacore.com>
3066
3067         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3068         (ARGSUSED, PARAMS, __func__): Remove rules.
3069
3070 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3071
3072         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3073         * features/arm/arm-with-iwmmxt.c: Remove.
3074         * features/arm/arm-with-iwmmxt.xml: Remove.
3075         * features/arm/arm-with-m-fpa-layout.c: Remove.
3076         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3077         * features/arm/arm-with-m-vfp-d16.c: Remove.
3078         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3079         * features/arm/arm-with-m.c: Remove.
3080         * features/arm/arm-with-m.xml: Remove.
3081         * features/arm/arm-with-neon.c: Remove.
3082         * features/arm/arm-with-neon.xml: Remove.
3083         * features/arm/arm-with-vfpv2.c: Remove.
3084         * features/arm/arm-with-vfpv2.xml: Remove.
3085         * features/arm/arm-with-vfpv3.c: Remove.
3086         * features/arm/arm-with-vfpv3.xml: Remove.
3087
3088 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3089
3090         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3091
3092 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3093
3094         * arch/aarch32.c (aarch32_create_target_description): Create
3095         target descriptions using features.
3096         * arch/arm.c (arm_create_target_description)
3097         (arm_create_mprofile_target_description): Likewise.
3098         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3099
3100 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * Makefile.in: Add new files.
3103         * aarch32-tdep.c: New file.
3104         * aarch32-tdep.h: New file.
3105         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3106         Call aarch32_read_description.
3107         * arch/aarch32.c: New file.
3108         * arch/aarch32.h: New file.
3109         * arch/arm.c (arm_create_target_description)
3110         (arm_create_mprofile_target_description): New function.
3111         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3112         (arm_create_target_description)
3113         (arm_create_mprofile_target_description): New declaration.
3114         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3115         read_description functions.
3116         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3117         Likewise.
3118         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3119         * arm-tdep.c (tdesc_arm_list): New variable.
3120         (arm_register_g_packet_guesses): Call create description functions.
3121         (arm_read_description) (arm_read_mprofile_description): New
3122         function.
3123         * arm-tdep.h (arm_read_description)
3124         (arm_read_mprofile_description): Add declaration.
3125         * configure.tgt: Add new files.
3126
3127 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3128
3129         * top.c (new_ui_command): Open specified terminal just once.
3130
3131 2019-07-18  Tom Tromey  <tromey@adacore.com>
3132
3133         * symtab.c (main_name): Constify return type.
3134         * symfile.c (set_initial_language): Update.
3135         * symtab.h (main_name): Constify return type.
3136
3137 2019-07-17  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui-winsource.c (tui_update_source_window)
3140         (tui_update_source_window_as_is)
3141         (tui_update_source_windows_with_line): Remove return.
3142         * tui/tui-disasm.c (tui_show_disassem)
3143         (tui_show_disassem_and_update_source): Remove return.
3144         * tui/tui.c (tui_reset): Remove return.
3145         * tui/tui-wingeneral.c
3146         (tui_check_and_display_highlight_if_needed): Remove return.
3147
3148 2019-07-17  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.h (struct tui_exec_info_window)
3155         (struct tui_source_window_base): Move from tui-data.h.
3156         * tui/tui-winsource.c: Move many method definitions from
3157         elsewhere.  Remove "structuring" comments.
3158         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3159         (tui_source_window_base::refresh_window): Move to
3160         tui-winsource.c.
3161         * tui/tui-win.c (tui_source_window_base::refresh_all)
3162         (tui_source_window_base::update_tab_width)
3163         (tui_source_window_base::set_new_height)
3164         (tui_source_window_base::do_make_visible_with_new_height): Move to
3165         tui-winsource.c.
3166         * tui/tui-source.h: Update.
3167         * tui/tui-source.c (tui_source_window_base::reset): Move to
3168         tui-winsource.c.
3169         * tui/tui-disasm.h: Update.
3170         * tui/tui-data.h (struct tui_exec_info_window): Move to
3171         tui-winsource.h.
3172         (struct tui_source_window_base): Likewise.
3173         * tui/tui-data.c (tui_source_window_base::clear_detail)
3174         (tui_source_window_base, ~tui_source_window_base): Move to
3175         tui-winsource.c.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-win.c (tui_resize_all)
3180         (tui_source_window_base::update_tab_width)
3181         (tui_adjust_win_heights): Update.
3182         (tui_win_info::make_invisible_and_set_new_height): Rename from
3183         make_invisible_and_set_new_height.
3184         * tui/tui-data.h (struct tui_win_info)
3185         <make_invisible_and_set_new_height>: New method.
3186
3187 2019-07-17  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui.c: Update.
3190         * tui/tui-source.h (struct tui_source_window): Move from
3191         tui-data.h.
3192         * tui/tui-layout.c: Update.
3193         * tui/tui-disasm.c: Update.
3194         * tui/tui-data.h (struct tui_source_window): Move to
3195         tui-source.h.
3196
3197 2019-07-17  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3200         tui-data.h.
3201         * tui/tui-data.h (struct tui_disasm_window): Move to
3202         tui-disasm.h.
3203
3204 2019-07-17  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-regs.h (struct tui_data_item_window): Move from
3207         tui-data.h.
3208         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3209         * tui/tui-data.h (struct tui_data_item_window): Move to
3210         tui-regs.h.
3211         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3212
3213 2019-07-17  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui.c: Update.
3216         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3217         (tui_cmd_window::max_height): Move to tui-command.c.
3218         * tui/tui-layout.c: Update.
3219         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3220         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3221         tui-command.c.
3222         * tui/tui-command.h (struct tui_cmd_window): Move from
3223         tui-data.h.
3224         * tui/tui-command.c: Remove "structuring" comments.
3225         (tui_cmd_window::clear_detail)
3226         (tui_cmd_window::do_make_visible_with_new_height)
3227         (tui_cmd_window::max_height): Move from elsewhere.
3228
3229 2019-07-17  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3232         Now static.
3233         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3234         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui.c: Update.
3239         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3240         tui-regs.c.
3241         * tui/tui-windata.h: Remove file.
3242         * tui/tui-windata.c: Remove file.
3243         * tui/tui-win.c (tui_data_window::set_new_height)
3244         (tui_data_window::do_make_visible_with_new_height): Move to
3245         tui-regs.c.
3246         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3247         * tui/tui-regs.c: Remove "structuring" comments.
3248         (tui_data_window::first_data_item_displayed)
3249         (tui_data_window::delete_data_content_windows)
3250         (tui_data_window::erase_data_content)
3251         (tui_data_window::display_all_data)
3252         (tui_data_window::refresh_all)
3253         (tui_data_window::do_scroll_vertical)
3254         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3255         (tui_data_window::do_make_visible_with_new_height)
3256         (tui_data_window::refresh_window): Move from elsewhere.
3257         (_initialize_tui_regs): Move to end of file.
3258         * tui/tui-layout.c: Update.
3259         * tui/tui-hooks.c: Update.
3260         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3261         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3262         tui-regs.c.
3263         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3264
3265 2019-07-17  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3268         seen.
3269
3270 2019-07-17  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-win.c (tui_source_window_base::set_new_height)
3273         (tui_source_window_base::do_make_visible_with_new_height): Use
3274         m_has_locator field directly.
3275         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3276         method.
3277         (struct tui_source_window_base) <has_locator>: Likewise.
3278
3279 2019-07-17  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3282         Don't declare.
3283         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3284         Remove.
3285         * tui/tui-win.c (tui_source_window_base::set_new_height)
3286         (tui_source_window_base::set_new_height)
3287         (make_invisible_and_set_new_height)
3288         (tui_source_window_base::do_make_visible_with_new_height)
3289         (tui_source_window_base::do_make_visible_with_new_height):
3290         Update.
3291         * tui/tui-layout.c (show_source_disasm_command, show_data)
3292         (show_source_or_disasm_and_command): Update.
3293         * tui/tui-layout.c (show_layout): Update.
3294
3295 2019-07-17  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-layout.c (make_data_window): Remove.
3298         (show_data): Unify creation and re-initialization cases.
3299
3300 2019-07-17  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-layout.c (make_source_window, make_disasm_window):
3303         Remove.
3304         (show_data): Unify creation and re-initialization cases.
3305
3306 2019-07-17  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-layout.c (make_command_window): Remove.
3309         (show_source_disasm_command, show_source_or_disasm_and_command):
3310         Unify creation and re-initialization cases.
3311
3312 2019-07-17  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3315         creation and re-initialization cases.
3316
3317 2019-07-17  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-regs.c (tui_get_register): Return void.
3320
3321 2019-07-17  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3324         Simplify.
3325
3326 2019-07-17  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3329         resetting.
3330
3331 2019-07-17  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3334         * tui/tui-regs.c (tui_reg_layout): New function.
3335         (tui_show_registers, tui_reg_command): Use it.
3336         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3337         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3338         parameters.
3339         (tui_layout_command): Remove.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-layout.h (tui/tui-layout): Return void.
3344         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3345
3346 2019-07-17  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-layout.c (show_source_disasm_command, show_data):
3349         Update.
3350         (reset_locator): Remove.
3351         (show_source_or_disasm_and_command): Update.
3352
3353 2019-07-17  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-source.c (tui_source_window_base::reset): Remove
3356         win_type parameter.
3357         * tui/tui-layout.c (make_command_window, make_source_window)
3358         (make_disasm_window, make_data_window)
3359         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3360         (reset_locator, show_source_or_disasm_and_command): Update.
3361         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3362         win_type parameter.
3363         (struct tui_source_window_base) <reset>: Likewise.
3364
3365 2019-07-17  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-layout.c (show_source_disasm_command): Use
3368         reset_locator.
3369         (reset_locator): New function.
3370         (init_and_make_win): Remove.
3371         (show_source_or_disasm_and_command): Use reset_locator.
3372
3373 2019-07-17  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3376         condition.
3377         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3378         Remove condition.
3379         * tui/tui-source.c (tui_source_window_base::reset): New method.
3380         * tui/tui-layout.c (make_command_window): Don't call
3381         init_and_make_win.
3382         (make_source_window, make_disasm_window): Don't call
3383         make_source_or_disasm_window.
3384         (make_data_window): Don't call init_and_make_win.  Change calling
3385         convention.
3386         (show_source_disasm_command, show_data): Simplify.
3387         (make_source_or_disasm_window): Remove.
3388         (show_source_or_disasm_and_command): Simplify.
3389         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3390         (struct tui_source_window_base) <reset>: Likewise.
3391         <execution_info>: Remove initializer.
3392         * tui/tui-data.c (tui_source_window_base): Initialize
3393         execution_info.
3394
3395 2019-07-17  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3398         variable.
3399
3400 2019-07-17  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui.c (tui_rl_other_window): Update.
3403         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3404         superclass method first.  Always iterate over regs_content.
3405         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3406         method.
3407         * tui/tui-win.c (tui_set_focus_command): Update.
3408
3409 2019-07-17  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-win.c (tui_set_focus_command): Rename from
3412         tui_set_focus.  Call tui_enable.
3413         (tui_set_focus_command): Remove.
3414
3415 2019-07-17  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3418         refresh_window.
3419         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3420         touchwin.
3421         (tui_data_window::refresh_window): Call refresh_window on data
3422         items.  Always call superclass refresh_window.
3423         (tui_win_info::refresh): Remove.
3424         (tui_source_window_base::refresh_window): Update.
3425         (tui_refresh_all): Update.
3426         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3427         refresh_window.
3428         (show_source_or_disasm_and_command): Likewise.
3429         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3430         (struct tui_source_window_base) <refresh>: Likewise.
3431
3432 2019-07-17  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-winsource.c (tui_clear_source_content)
3435         (tui_show_source_content): Update.
3436         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3437         whether content is empty.
3438         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3439         Remove.
3440
3441 2019-07-17  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3444         window's contents.
3445         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3446         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3447
3448 2019-07-17  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3451         (struct tui_data_item_window): Update.
3452
3453 2019-07-17  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3456         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3457         defines.
3458
3459 2019-07-17  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-winsource.h (tui_erase_source_content)
3462         (tui_clear_source_content): Remove "display_prompt" parameter.
3463         * tui/tui-winsource.c (tui_update_source_window_as_is)
3464         (tui_update_source_windows_with_addr): Update.
3465         (tui_clear_source_content): Remove "display_prompt" parameter.
3466         (tui_erase_source_content): Likewise.  Simplify.
3467         (tui_show_source_content): Update.
3468         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3469         * tui/tui-stack.c (tui_show_frame_info): Update.
3470         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3471         Remove defines.
3472
3473 2019-07-17  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3476         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3477         parameter.
3478         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3479         parameter.
3480
3481 2019-07-17  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-winsource.c (tui_clear_source_content)
3484         (tui_show_source_content, tui_show_exec_info_content)
3485         (tui_clear_exec_info_content): Update.
3486         * tui/tui-stack.c (tui_show_locator_content): Update.
3487         (tui_show_frame_info): Update.
3488         * tui/tui-source.h (tui_source_window): Don't declare.
3489         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3490         from tui_source_is_displayed.
3491         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3492         Remove field.
3493         (struct tui_source_window_base) <content_in_use>: New field.  Now
3494         bool.
3495         (struct tui_source_window) <showing_source_p>: New method.
3496         (TUI_SRC_WIN): Change cast.
3497         * tui/tui-data.c (tui_initialize_static_data): Update.
3498
3499 2019-07-17  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3502         location_matches_p.
3503         * tui/tui-source.c (tui_source_window::location_matches_p): New
3504         method.
3505         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3506         method.
3507         * tui/tui-data.h (struct tui_source_window_base)
3508         <location_matches_p>: New method.
3509         (struct tui_source_window, struct tui_disasm_window)
3510         <location_matches_p>: Likewise.
3511
3512 2019-07-17  Tom Tromey  <tom@tromey.com>
3513
3514         * tui/tui-win.c (tui_set_win_height_command): Rename from
3515         tui_set_win_height.
3516         (tui_set_win_height_command): Remove.
3517
3518 2019-07-17  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-source.c (tui_source_window): New constructor.  Add
3521         observer.
3522         (~tui_source_window): New destructor.
3523         (tui_source_window::style_changed): New method.
3524         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3525         (tui_attach_detach_observers): Update.
3526         * tui/tui-data.h (struct tui_source_window): Make constructor not
3527         inline.  Add destructor.
3528         (struct tui_source_window) <style_changed>: New method.
3529         <m_observable>: New member.
3530
3531 2019-07-17  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3534         * tui/tui-win.c (tui_resize_all): Fix typo.
3535
3536 2019-07-17  Tom Tromey  <tom@tromey.com>
3537
3538         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3539         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3540         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3541         * tui/tui-win.c (window_name_completer): Use foreach.
3542         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3543         (update_tab_width): Likewise.
3544         * tui/tui-layout.c (show_layout): Update.
3545         * tui/tui-data.h (class tui_window_iterator): New.
3546         (struct all_tui_windows): New.
3547         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3548
3549 2019-07-17  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3552         parameter.  Don't reference globals.
3553         (tui_reg_command): Update.
3554
3555 2019-07-17  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-regs.c (tui_show_registers): Simplify.
3558
3559 2019-07-17  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-regs.c (tui_show_registers): Update.
3562         (tui_show_register_group): Add win_info parameter.
3563
3564 2019-07-17  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3567         Rename from tui_display_reg_element_at_line.
3568         (tui_data_window::display_registers_from_line): Update.
3569         * tui/tui-data.h (struct tui_data_window)
3570         <display_reg_element_at_line>: New method.
3571
3572 2019-07-17  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-regs.h (tui_display_registers_from)
3575         (tui_display_registers_from_line): Don't declare.
3576         * tui/tui-windata.c (tui_data_window::display_all_data)
3577         (tui_data_window::refresh_all)
3578         (tui_data_window::do_scroll_vertical): Update.
3579         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3580         from tui_display_registers_from.
3581         (tui_display_reg_element_at_line): Update.
3582         (tui_data_window::display_registers_from_line): Rename from
3583         tui_display_registers_from_line.
3584         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3585         display_registers_from_line>: New methods.
3586
3587 2019-07-17  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3590         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3591         from tui_erase_data_content.
3592         (tui_data_window::display_all_data)
3593         (tui_data_window::refresh_all)
3594         (tui_data_window::do_scroll_vertical): Update.
3595         * tui/tui-regs.c (tui_show_registers): Update.
3596         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3597         New method.
3598
3599 2019-07-17  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3602         declare.
3603         * tui/tui-windata.c
3604         (tui_data_window::delete_data_content_windows): Rename from
3605         tui_delete_data_content_windows.
3606         (tui_data_window::display_all_data)
3607         (tui_data_window::do_scroll_vertical): Update.
3608         * tui/tui-data.h (struct tui_data_window)
3609         <delete_data_content_windows>: New method.
3610
3611 2019-07-17  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3614         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3615
3616 2019-07-17  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3619         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3620         from tui_display_all_data.
3621         * tui/tui-win.c
3622         (tui_data_window::do_make_visible_with_new_height): Update.
3623         * tui/tui-regs.c (tui_show_registers): Update.
3624         * tui/tui-layout.c (tui_set_layout): Update.
3625         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3626         method.
3627
3628 2019-07-17  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3631         * tui/tui-windata.c (tui_display_data_from): Remove.
3632         (tui_data_window::refresh_all): Update.
3633
3634 2019-07-17  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3637         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3638         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3639         tui_display_registers_from_line.
3640         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3641         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3642         "force_display" parameter.
3643
3644 2019-07-17  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3647         declare.
3648         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3649         Rename from tui_first_reg_element_no_inline.
3650         (tui_display_reg_element_at_line)
3651         (tui_display_registers_from_line): Update.
3652         * tui/tui-data.h (struct tui_data_window)
3653         <first_reg_element_no_inline>: New method.
3654
3655 2019-07-17  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-windata.c (tui_display_data_from)
3658         (tui_data_window::do_scroll_vertical): Update.
3659         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3660         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3661         Rename from tui_line_from_reg_element_no.
3662         (tui_display_registers_from_line): Update.
3663         * tui/tui-data.h (struct tui_data_window)
3664         <line_from_reg_element_no>: New method.
3665
3666 2019-07-17  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3669         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3670         tui_last_regs_line_no.
3671         (tui_display_reg_element_at_line)
3672         (tui_display_registers_from_line): Update.
3673         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3674         method.
3675
3676 2019-07-17  Tom Tromey  <tom@tromey.com>
3677
3678         PR tui/24722:
3679         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3680         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3681         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3682         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3683         (tui_update_breakpoint_info): Likewise.
3684         * tui/tui-hooks.c (tui_event_create_breakpoint)
3685         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3686         Update.
3687
3688 2019-07-17  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3691
3692 2019-07-17  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui-winsource.c (tui_update_source_window_as_is)
3695         (tui_update_source_windows_with_addr): Update.
3696         * tui/tui-source.h (tui_set_source_content)
3697         (tui_show_symtab_source): Add "win_info" parameter.
3698         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3699         parameter.
3700         (tui_show_symtab_source): Likewise.
3701
3702 2019-07-17  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-wingeneral.c
3705         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3706
3707 2019-07-17  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3710         (struct tui_cmd_window) <can_scroll>: New method.
3711         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3712         method.
3713
3714 2019-07-17  Tom Tromey  <tromey@adacore.com>
3715
3716         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3717         do_field_signed>: Rename.  Change type of "value".
3718         * ui-out.c (ui_out::field_signed): Rename from field_int.
3719         Change type of "value".
3720         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3721         type of "value".
3722         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3723         do_field_int.  Change type of "value".
3724         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3725         do_field_int.  Change type of "value".
3726         * tracepoint.c (trace_status_mi, tfind_1)
3727         (print_one_static_tracepoint_marker): Update.
3728         * thread.c (print_thread_info_1, print_selected_thread_frame):
3729         Update.
3730         * stack.c (print_frame, print_frame_info): Update.
3731         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3732         Update.
3733         * source.c (print_source_lines_base): Update.
3734         * skip.c (info_skip_command): Update.
3735         * record-btrace.c (btrace_ui_out_decode_error)
3736         (btrace_call_history_src_line): Update.
3737         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3738         Update.
3739         * progspace.c (print_program_space): Update.
3740         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3741         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3742         do_field_int.  Change type of "value".
3743         * mi/mi-out.c (mi_ui_out::do_table_begin)
3744         (mi_ui_out::do_table_header): Update.
3745         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3746         type of "value".
3747         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3748         (mi_cmd_data_list_changed_registers, output_register)
3749         (mi_cmd_data_read_memory, mi_load_progress)
3750         (mi_cmd_trace_frame_collected): Update.
3751         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3752         Update.
3753         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3754         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3755         (mi_cmd_var_list_children, varobj_update_one): Update.
3756         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3757         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3759         * inferior.c (print_inferior): Update.
3760         * gdb_bfd.c (print_one_bfd): Update.
3761         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3762         Update.
3763         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3764         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3765         do_field_int.  Change type of "value".
3766         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3767         do_field_int.  Change type of "value".
3768         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3769         (print_one_breakpoint_location, print_it_catch_fork)
3770         (print_one_catch_fork, print_it_catch_vfork)
3771         (print_one_catch_vfork, print_it_catch_solib)
3772         (print_it_catch_exec, print_it_ranged_breakpoint)
3773         (print_mention_watchpoint, print_mention_masked_watchpoint)
3774         (bkpt_print_it, update_static_tracepoint): Update.
3775         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3776         * break-catch-syscall.c (print_it_catch_syscall): Update.
3777         * ada-tasks.c (print_ada_task_info): Update.
3778         * ada-lang.c (print_it_exception, print_mention_exception):
3779         Update.
3780
3781 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         PR breakpoints/24541
3784         * gdbarch.c: Regenerate.
3785         * gdbarch.h: Regenerate.
3786         * gdbarch.sh: Adjust return type and parameter types for
3787         'stap_adjust_register'.
3788         (i386_stap_adjust_register): Adjust signature and return new
3789         register name.
3790         * stap-probe.c (stap_parse_register_operand): Adjust use of
3791         'gdbarch_stap_adjust_register'.
3792
3793 2019-07-17  Tom Tromey  <tromey@adacore.com>
3794
3795         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3796         declare VEC.
3797         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3798         std::vector.
3799         (struct s390_process_info): Add initializers.
3800         (s390_add_process): Use new.
3801         (s390_linux_nat_target::low_forget_process): Use delete.
3802         (s390_linux_nat_target::low_new_fork)
3803         (s390_linux_nat_target::stopped_by_watchpoint)
3804         (s390_linux_nat_target::low_prepare_to_resume)
3805         (s390_linux_nat_target::insert_watchpoint)
3806         (s390_linux_nat_target::insert_hw_breakpoint)
3807         (s390_linux_nat_target::remove_watchpoint)
3808         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3809
3810 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3811
3812         * aarch64-fbsd-nat.c: Include regcache.h.
3813         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3814         argument.
3815         (aarch64_fbsd_nat_target::fetch_registers)
3816         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3817         variable.
3818         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3819
3820 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3821
3822         * fbsd-nat.c: Include gdbarch.h.
3823
3824 2019-07-15  Tom Tromey  <tromey@adacore.com>
3825
3826         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3827
3828 2019-07-15  Tom Tromey  <tromey@adacore.com>
3829
3830         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3831         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3832         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3833         * cli-out.c (cli_ui_out::do_field_int): New method.
3834         * ui-out.c (ui_out::field_unsigned): New method.
3835         * symfile.c (generic_load): Use field_unsigned.
3836         (print_transfer_performance): Likewise.
3837         * record-btrace.c (ui_out_field_uint): Remove.
3838         (btrace_call_history_insn_range, btrace_call_history): Use
3839         field_unsigned.
3840         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3841         field_unsigned.
3842         * ui-out.h (class ui_out) <field_unsigned>: New method.
3843         <do_field_unsigned>: Likewise.
3844
3845 2019-07-15  Tom Tromey  <tromey@adacore.com>
3846
3847         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3848         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3849         * target.c (flash_erase_command): Use field_string.
3850         * infrun.c (print_signal_received_reason): Use field_string.
3851         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3852         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3853         field_string.
3854         * ada-tasks.c (print_ada_task_info): Use field_string.
3855
3856 2019-07-15  Tom Tromey  <tromey@adacore.com>
3857
3858         * target.c (flash_erase_command): Use field_core_addr.
3859         * symfile.c (generic_load): Use field_core_addr.
3860         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3861         Use field_core_addr.
3862         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3863         field_core_addr.
3864
3865 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3868         value if its desired type is smaller than a CORE_ADDR and signed.
3869
3870 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3873         of changes to field names, and use new is_reference field to
3874         decide if a property is a reference or not.
3875         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3876         field.
3877         (struct dwarf2_property_baton): Update header comment, rename
3878         'referenced_type' to 'property_type' and update comments.
3879         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3880         default property type, store in property baton, update to take
3881         accound of renamed field.
3882         (read_func_scope): Update call to attr_to_dynamic_prop.
3883         (read_array_type): Likewise.
3884         (dwarf2_per_cu_addr_sized_int_type): New function.
3885         (read_subrange_index_type): Move type finding code to
3886         dwarf2_per_cu_addr_sized_int_type.
3887         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3888         (dwarf2_per_cu_addr_type): New function.
3889         (set_die_type): Update calls to attr_to_dynamic_prop.
3890
3891 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * dwarf2read.c (read_subrange_index_type): New function.
3894         (read_subrange_type): Move code into new function and call it.
3895         * gdbtypes.c (create_range_type): Add some asserts.
3896
3897 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3900         update return statements.
3901         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3902         declaration, and update comment to match.
3903         * gdbtypes.c (resolve_dynamic_array): Update call to
3904         dwarf2_evaluate_property to match new return type.
3905
3906 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * valarith.c (value_subscripted_rvalue): Change lowerbound
3909         parameter type from int to LONGEST.
3910         * value.h (value_subscripted_rvalue): Likewise in declaration.
3911
3912 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * cli/cli-utils.c (info_print_command_completer): New function.
3915         * cli/cli-utils.h: Add 'completer.h' include, and forward
3916         declaration for 'struct cmd_list_element'.
3917         (info_print_command_completer): Declare.
3918         * stack.c (_initialize_stack): Add completer for 'info locals' and
3919         'info args'.
3920         * symtab.c (_initialize_symtab): Add completer for 'info
3921         variables' and 'info functions'.
3922         * NEWS: Mention completion for additional info commands.
3923
3924 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3925
3926         * cli/cli-utils.c (extract_info_print_args): Delete.
3927         (extract_arg_maybe_quoted): Delete.
3928         (info_print_options_defs): New variable.
3929         (make_info_print_options_def_group): New function.
3930         (extract_info_print_options): Define new function.
3931         * cli/cli-utils.h (extract_info_print_args): Delete.
3932         (struct info_print_options): New structure.
3933         (extract_info_print_options): Declare new function.
3934         * stack.c (info_locals_command): Update to use new
3935         extract_info_print_options, also add a header comment.
3936         (info_args_command): Likewise.
3937         * symtab.c (info_variables_command): Likewise.
3938         (info_functions_command): Likewise.
3939
3940 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3943         to extract string arguments.
3944         * common/common-utils.c (extract_string_maybe_quoted): New function.
3945         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3946
3947 2019-07-11  Tom Tromey  <tromey@adacore.com>
3948
3949         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3950         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3951         * top.h (gdbinit): Don't declare.
3952         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3953         into...
3954         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3955         * top.c (gdb_init): Don't call init_cli_cmds.
3956         (gdbinit): Remove.
3957         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3958
3959 2019-07-11  Tom Tromey  <tromey@adacore.com>
3960
3961         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3962         after it has been moved.
3963
3964 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3965
3966         * valops.c (value_must_coerce_to_target): Change return type to
3967         bool.
3968         * value.h (value_must_coerce_to_target): Likewise.
3969
3970 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3971
3972         * breakpoint.c (is_hardware_watchpoint): Remove
3973         forward-declaration.
3974         (is_masked_watchpoint): Change return type to bool.
3975         (is_tracepoint): Likewise.
3976         (is_breakpoint): Likewise.
3977         (is_hardware_watchpoint): Likewise.
3978         (is_watchpoint): Likewise.
3979         (is_no_memory_software_watchpoint): Likewise.
3980         (is_catchpoint): Likewise.
3981         (breakpoint_1): Make FILTER parameter's return type bool.
3982         is_masked_watchpoint): Change return type to bool.
3983         (save_breakpoints): Make FILTER parameter's return type bool.
3984         * breakpoint.h (is_breakpoint): Change return type to bool.
3985         (is_watchpoint): Likewise.
3986         (is_catchpoint): Likewise.
3987         (is_tracepoint): Likewise.
3988
3989 2019-07-10  Tom Tromey  <tom@tromey.com>
3990
3991         * defs.h: Don't include gdbarch.h.
3992         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3993         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3994         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3995         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3996         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3997         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3998         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3999         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4000         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4001         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4002         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4003         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4004         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4005         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4006         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4007         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4008         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4009         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4010         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4011         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4012         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4013         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4014         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4015         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4016         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4017         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4018         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4019
4020 2019-07-10  Tom Tromey  <tromey@adacore.com>
4021
4022         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4023         * breakpoint.c (init_ada_exception_breakpoint): Register as
4024         bp_catchpoint.
4025         (print_one_breakpoint_location, print_one_breakpoint): Use
4026         is_ada_exception_catchpoint.
4027         * ada-lang.c (class ada_catchpoint_location): Pass
4028         bp_loc_software_breakpoint to bp_location constructor.
4029         (is_ada_exception_catchpoint): New function.
4030
4031 2019-07-10  Tom Tromey  <tromey@adacore.com>
4032
4033         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4034         VEC.
4035         (struct arm_exidx_entry): New method operator<.
4036         (struct arm_exidx_data) <section_maps>: Change type.
4037         (arm_exidx_data_free): Remove.
4038         (arm_exidx_data_key): Change type.  Move lower.
4039         (arm_exidx_new_objfile): Update.
4040         (arm_compare_exidx_entries): Remove.
4041         (arm_find_exidx_entry, _initialize_arm_tdep)
4042
4043 2019-07-10  Tom Tromey  <tromey@adacore.com>
4044
4045         * solib-spu.c (ocl_program_data_key): Change type.
4046         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4047         Update.
4048
4049 2019-07-10  Tom Tromey  <tromey@adacore.com>
4050
4051         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4052         (struct solib_aix_inferior_data) <library_list>: Change type.
4053         (solib_aix_inferior_data_handle): Change type.
4054         (get_solib_aix_inferior_data): Update.
4055         (solib_aix_free_library_list): Remove.
4056         (library_list_start_library): Update.
4057         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4058         return type.
4059         (solib_aix_get_library_list)
4060         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4061         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4062
4063 2019-07-10  Tom Tromey  <tromey@adacore.com>
4064
4065         * solib-dsbt.c (struct dsbt_info): Add initializers.
4066         (solib_dsbt_pspace_data): Change type.
4067         (dsbt_pspace_data_cleanup): Remove.
4068         (get_dsbt_info, _initialize_dsbt_solib): Update.
4069
4070 2019-07-10  Tom Tromey  <tromey@adacore.com>
4071
4072         * spu-tdep.c (spu_overlay_data): Change type.
4073         (spu_get_overlay_table, spu_overlay_new_objfile)
4074         (_initialize_spu_tdep): Update.
4075
4076 2019-07-10  Tom Tromey  <tromey@adacore.com>
4077
4078         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4079         destructor.
4080         (dbx_objfile_data_key): Change type and declare later.
4081         (DBX_SYMFILE_INFO): Rewrite.
4082         * dbxread.c (dbx_objfile_data_key): Change type.
4083         (dbx_symfile_init): Update.
4084         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4085         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4086         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4087
4088 2019-07-10  Tom Tromey  <tromey@adacore.com>
4089
4090         * jit.c (jit_program_space_key): Change type.  Move lower.
4091         (get_jit_program_space_data): Update.
4092         (jit_program_space_data_cleanup): Remove.
4093         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4094         Update.
4095         (struct jit_program_space_data): Add initializers.
4096
4097 2019-07-10  Tom Tromey  <tromey@adacore.com>
4098
4099         * solib-darwin.c (struct darwin_info): Add initializers.
4100         (solib_darwin_pspace_data): Change type.
4101         (darwin_pspace_data_cleanup): Remove.
4102         (get_darwin_info, _initialize_darwin_solib): Update.
4103
4104 2019-07-10  Tom Tromey  <tromey@adacore.com>
4105
4106         * remote-sim.c (struct sim_inferior_data): Add initializers,
4107         constructor, and destructor.
4108         (sim_inferior_data_key): Change type.  Move lower.
4109         (check_for_duplicate_sim_descriptor): Update.
4110         (get_sim_inferior_data): Use new.  Update.
4111         (~sim_inferior_data_cleanup): Rename from
4112         sim_inferior_data_cleanup.  Simplify.
4113         (gdbsim_close_inferior, simulator_command)
4114         (sim_command_completer, _initialize_remote_sim): Update.
4115         (next_pid, INITIAL_PID): Move earlier.
4116
4117 2019-07-10  Tom Tromey  <tromey@adacore.com>
4118
4119         * python/python-internal.h (create_thread_object): Return
4120         gdbpy_ref.
4121         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4122         * python/py-inferior.c (struct threadlist_entry): Add
4123         constructor.
4124         <thread_obj>: Now a gdbpy_ref.
4125         (thread_to_thread_object): Update.
4126         (add_thread_object): Use new.
4127         (delete_thread_object): Use delete.
4128         (infpy_threads): Update.
4129         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4130         GIL.
4131
4132 2019-07-10  Tom Tromey  <tromey@adacore.com>
4133
4134         * valops.c (value_cast): Specialize error message for Ada.
4135
4136 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4137
4138         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4139
4140 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4141
4142         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4143         bpstat_should_step): Return bool, adjust comments.
4144         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4145         bpstat_should_step): Likewise.
4146
4147 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4148
4149         * features/Makefile: Use feature target descriptions for Arm.
4150         * features/arm/arm-core.c: Generate new file.
4151         * features/arm/arm-fpa.c: Likewise.
4152         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4153         * features/arm/arm-m-profile.c: Likewise.
4154         * features/arm/arm-vfpv2.c: Likewise.
4155         * features/arm/arm-vfpv3.c: Likewise.
4156         * features/arm/xscale-iwmmxt.c: Likewise.
4157         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4158
4159 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4160
4161         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4162         ptrace earlier.
4163
4164 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4165
4166         * features/aarch64-pauth.c: Regenerate.
4167
4168 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4169
4170         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4171         bool.
4172         (bpstat_what): Use false instead of 0.
4173
4174 2019-07-09  Pedro Alves  <palves@redhat.com>
4175
4176         * break-catch-throw.c (is_exception_catchpoint): New.
4177         * breakpoint.c (print_one_breakpoint_location): New parameter
4178         'raw_loc'.  Handle it.  Use
4179         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4180         looking at the breakpoint's type.
4181         (print_one_breakpoint): If handling "maint info breakpoints", also
4182         print locations of exception catchpoints.
4183         * breakpoint.h (is_exception_catchpoint): Declare.
4184
4185 2019-07-09  Pedro Alves  <palves@redhat.com>
4186
4187         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4188         "addr" field.
4189         (allocate_location_exception_catchpoint): New.
4190         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4191         (initialize_throw_catchpoint_ops): Install
4192         allocate_location_exception_catchpoint as allocate_location
4193         method.
4194         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4195         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4196         bp_loc_other.
4197         (breakpoint_address_is_meaningful): Delete.
4198         (bl_address_is_meaningful): New.
4199         (breakpoint_locations_match): Adjust comment.
4200         (bp_location_from_bp_type): New, factored out of...
4201         (bp_location::bp_location(breakpoint *)): ... this.
4202         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4203         factored out of...
4204         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4205         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4206         breakpoint_address_is_meaningful.
4207         (bp_locations_compare): Adjust comment.
4208         (update_global_location_list): Use bl_address_is_meaningful
4209         instead of breakpoint_address_is_meaningful.
4210         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4211         explicit.
4212         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4213         * python/py-breakpoint.c (bppy_get_location): No longer check
4214         whether location is null.
4215
4216 2019-07-09  Pedro Alves  <palves@redhat.com>
4217
4218         PR c++/15468
4219         * breakpoint.c (print_one_breakpoint_location): Remove
4220         single-location assert.
4221
4222 2019-07-09  Tom Tromey  <tom@tromey.com>
4223
4224         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4225         * configure: Rebuild.
4226         * configure.ac: Change common to gdbsupport.
4227         * gdbsupport: Rename from common.
4228         * acinclude.m4: Change common to gdbsupport.
4229         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4230         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4231         gdbsupport.
4232         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4233         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4234         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4235         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4236         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4237         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4238         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4239         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4240         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4241         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4242         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4243         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4244         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4245         coff-pe-read.c, command.h, compile/compile-c-support.c,
4246         compile/compile-c.h, compile/compile-cplus-symbols.c,
4247         compile/compile-cplus-types.c, compile/compile-cplus.h,
4248         compile/compile-loc2c.c, compile/compile.c, completer.c,
4249         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4250         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4251         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4252         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4253         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4254         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4255         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4256         features/aarch64-core.c, features/aarch64-fpu.c,
4257         features/aarch64-pauth.c, features/aarch64-sve.c,
4258         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4259         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4260         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4261         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4262         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4263         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4264         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4265         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4266         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4267         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4268         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4269         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4270         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4271         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4272         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4273         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4274         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4275         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4276         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4277         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4278         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4279         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4280         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4281         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4282         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4283         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4284         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4285         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4286         minsyms.c, mips-linux-tdep.c, namespace.h,
4287         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4288         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4289         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4290         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4291         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4292         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4293         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4294         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4295         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4296         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4297         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4298         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4299         procfs.c, producer.c, progspace.h, psymtab.h,
4300         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4301         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4302         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4303         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4304         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4305         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4306         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4307         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4308         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4309         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4310         target-memory.c, target.c, target.h, target/waitstatus.c,
4311         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4312         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4313         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4314         unittests/array-view-selftests.c,
4315         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4316         unittests/common-utils-selftests.c,
4317         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4318         unittests/format_pieces-selftests.c,
4319         unittests/function-view-selftests.c,
4320         unittests/lookup_name_info-selftests.c,
4321         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4322         unittests/mkdir-recursive-selftests.c,
4323         unittests/observable-selftests.c,
4324         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4325         unittests/parse-connection-spec-selftests.c,
4326         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4327         unittests/scoped_fd-selftests.c,
4328         unittests/scoped_mmap-selftests.c,
4329         unittests/scoped_restore-selftests.c,
4330         unittests/string_view-selftests.c, unittests/style-selftests.c,
4331         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4332         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4333         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4334         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4335         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4336         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4337
4338 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4341         bool value.
4342         (decode_digits_ordinary): Set explicit_line field in sal.
4343         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4344         symtab_and_line that was set on an explicit line number in
4345         assembler code.  Do always update the recorded symtab and line if
4346         we do skip the prologue.
4347
4348 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * breakpoint.c (set_breakpoint_location_function): Remove
4351         explicit_loc parameter.
4352         (momentary_breakpoint_from_master): Update call to
4353         set_breakpoint_location_function.
4354         (add_location_to_breakpoint): Likewise.
4355
4356 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4357
4358         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4359         required features based on default bfd type when no specific bfd
4360         is present.
4361
4362 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4363
4364         * NEWS: Mention that GDB printf and eval commands can now print
4365         C-style and Ada-style convenience var strings without
4366         calling the inferior.
4367         * printcmd.c (printf_c_string): Locally print GDB internal var
4368         instead of transiting via the inferior.
4369         (printf_wide_c_string): Likewise.
4370
4371 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4374
4375 2019-07-04  Tom Tromey  <tom@tromey.com>
4376
4377         PR tui/24724:
4378         * tui/tui-winsource.c (tui_clear_source_content): Update.
4379         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4380         (tui_update_breakpoint_info): Update.
4381         (tui_set_exec_info_content): Update.
4382         * tui/tui-source.c (tui_set_source_content_nil): Update.
4383         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4384         has_break.
4385         * tui/tui-data.h (enum tui_bp_flag): New.
4386         (tui_bp_flags): New enum flags type.
4387         (struct tui_source_element) <break_mode>: Change type.  Rename
4388         from has_break.
4389         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4390         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4391         constants.
4392         * tui/tui-winsource.h: Fix comment.
4393
4394 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4395
4396         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4397         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4398         (store_fpregs_to_thread)
4399         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4400         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4401         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4402         (IWMMXT_REGS_SIZE): Add define.
4403         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4404         (fetch_vfp_regs, store_vfp_regs)
4405         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4406         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4407
4408 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4409
4410         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4411         defines.
4412         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4413         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4414         (ARM_INT_REGISTER_SIZE): ...to this.
4415         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4416         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4417         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4418         (arm_linux_collect_gregset, supply_nwfpe_register)
4419         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4420         defines.
4421         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4422         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4423         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4424         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4425         (arm_return_in_memory, arm_store_return_value)
4426         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4427         (arm_record_ld_st_multiple): Likewise.
4428         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4429         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4430
4431 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4432
4433         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4434         AARCH64_DISPLACED_MODIFIED_INSNS.
4435         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4436         (aarch64_displaced_step_copy_insn): Likewise.
4437         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4438         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4439         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4440         ARM_DISPLACED_MODIFIED_INSNS.
4441         * arm-tdep.c (arm_gdbarch_init): Likewise.
4442         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4443         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4444         (struct arm_displaced_step_closure): Use
4445         ARM_DISPLACED_MODIFIED_INSNS.
4446
4447 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4448
4449         * features/Makefile: Remove unused xml files.
4450         * features/aarch64.xml: Remove.
4451         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4452         * features/i386/amd64-avx-avx512.xml: Remove.
4453         * features/i386/amd64-avx-linux.xml: Remove.
4454         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4455         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4456         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4457         * features/i386/amd64-avx-mpx.xml: Remove.
4458         * features/i386/amd64-avx.xml: Remove.
4459         * features/i386/amd64-linux.xml: Remove.
4460         * features/i386/amd64-mpx-linux.xml: Remove.
4461         * features/i386/amd64-mpx.xml: Remove.
4462         * features/i386/amd64.xml: Remove.
4463         * features/i386/i386-avx-avx512-linux.xml: Remove.
4464         * features/i386/i386-avx-avx512.xml: Remove.
4465         * features/i386/i386-avx-linux.xml: Remove.
4466         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4467         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4468         * features/i386/i386-avx-mpx-linux.xml: Remove.
4469         * features/i386/i386-avx-mpx.xml: Remove.
4470         * features/i386/i386-avx.xml: Remove.
4471         * features/i386/i386-linux.xml: Remove.
4472         * features/i386/i386-mmx-linux.xml: Remove.
4473         * features/i386/i386-mmx.xml: Remove.
4474         * features/i386/i386-mpx-linux.xml: Remove.
4475         * features/i386/i386-mpx.xml: Remove.
4476         * features/i386/i386.xml: Remove.
4477         * features/i386/x32-avx-avx512-linux.xml: Remove.
4478         * features/i386/x32-avx-linux.xml: Remove.
4479         * features/i386/x32-linux.xml: Remove.
4480
4481 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * regformats/aarch64.dat: Remove.
4484         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4485         * regformats/i386/amd64-avx-linux.dat: Remove.
4486         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4487         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4488         * regformats/i386/amd64-linux.dat: Remove.
4489         * regformats/i386/amd64-mpx-linux.dat: Remove.
4490         * regformats/i386/amd64.dat: Remove.
4491         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4492         * regformats/i386/i386-avx-linux.dat: Remove.
4493         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4494         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4495         * regformats/i386/i386-linux.dat: Remove.
4496         * regformats/i386/i386-mmx-linux.dat: Remove.
4497         * regformats/i386/i386-mpx-linux.dat: Remove.
4498         * regformats/i386/i386.dat: Remove.
4499         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4500         * regformats/i386/x32-avx-linux.dat: Remove.
4501         * regformats/i386/x32-linux.dat: Remove.
4502
4503 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4504
4505         * aarch64-tdep.c: Remove xml self tests.
4506         * amd64-linux-tdep.c: Likewise.
4507         * amd64-tdep.c: Likewise.
4508         * i386-linux-tdep.c: Likewise.
4509         * i386-tdep.c: Likewise.
4510
4511 2019-07-03  Pedro Alves  <palves@redhat.com>
4512
4513         PR cli/24732
4514         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4515         (pipe_cmd_option_defs): New.
4516         (make_pipe_cmd_options_def_group): New.
4517         (pipe_command): Use gdb::option::process_options.
4518         (pipe_command_completer): New function.
4519         (_initialize_cli_cmds): Install completer for "pipe" command.
4520
4521 2019-07-03  Pedro Alves  <palves@redhat.com>
4522
4523         * cli/cli-option.c (union option_value) <string>: New field.
4524         (struct option_def_and_value): Add ctor, move ctor, dtor and
4525         use DISABLE_COPY_AND_ASSIGN.
4526         (option_def_and_value::clear_value): New.
4527         (parse_option, save_option_value_in_ctx, get_val_type_str)
4528         (add_setshow_cmds_for_options): Handle var_string.
4529         * cli-option.h (union option_def::var_address) <string>: New
4530         field.
4531         (struct string_option_def): New.
4532         * maint-test-options.c (struct test_options_opts): Add default
4533         ctor and use DISABLE_COPY_AND_ASSIGN.
4534         <string_opt>: New field.
4535         (test_options_opts::~test_options_opts): New.
4536         (test_options_opts::dump): Also dump "-string".
4537         (test_options_option_defs): Install "string.
4538
4539 2019-07-03  Pedro Alves  <palves@redhat.com>
4540
4541         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4542         option_value with a null enumeration.
4543         (complete_options): Save the option values in the context.
4544         (save_option_value_in_ctx): New, factored out from ...
4545         (process_options): ... here.
4546         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4547         of the function.
4548         * maint-test-options.c (test_options_opts::dump): New, factored
4549         out from ...
4550         (maintenance_test_options_command_mode): ... here.
4551         (maintenance_test_options_command_completion_result): Delete.
4552         (maintenance_test_options_command_completion_text): Update
4553         comment.
4554         (maintenance_show_test_options_completion_result): Change
4555         prototype.  Just print
4556         maintenance_test_options_command_completion_text.
4557         (save_completion_result): New.
4558         (maintenance_test_options_completer_mode): Pass options context to
4559         complete_options, and then save a dump.
4560         (_initialize_maint_test_options): Use add_cmd to install "maint
4561         show test-options-completion-result".
4562
4563 2019-07-03  Pedro Alves  <palves@redhat.com>
4564
4565         * NEWS (New commands): Mention "with" and "maint with".
4566         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4567         (with_command, with_command_completer): New.
4568         (pipe_command): Adjust to new repeat_previous
4569         interface.
4570         (_initialize_cli_cmds): Install the "with" command and its "w"
4571         alias.
4572         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4573         declarations.
4574         * cli/cli-setshow.c (parse_cli_var_uinteger)
4575         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4576         argument strings for all var_types.
4577         (get_setshow_command_value_string): New, factored out from ...
4578         (do_show_command): ... this.
4579         * cli/cli-setshow.h: Include <string>.
4580         (get_setshow_command_value_string): Declare.
4581         * command.h (repeat_previous): Now returns const char *.  Adjust
4582         comment.
4583         * maint.c: Include "cli/cli-cmds.h".
4584         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4585         (_initialize_maint_cmds): Register the "maintenance with" command.
4586         * top.c (repeat_previous): Move bits from pipe_command here:
4587         Return the saved command line, if any; error out if there's no
4588         command to relaunch.
4589
4590 2019-07-03  Pedro Alves  <palves@redhat.com>
4591
4592         * NEWS (New commands): Mention "maint set/show test-settings"
4593         instead of "maint test-settings".
4594         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4595         (maintenance_test_settings_set_list): Rename to ...
4596         (maintenance_set_test_settings_list): ... this.
4597         (maintenance_test_settings_show_list): Rename to  ...
4598         (maintenance_show_test_settings_list): ... this.
4599         (maintenance_test_settings_cmd): Delete.
4600         (maintenance_test_settings_set_cmd): ...
4601         (maintenance_set_test_settings_cmd): ... this.
4602         (maintenance_test_settings_show_cmd): ...
4603         (maintenance_show_test_settings_cmd): ... this.
4604         (maintenance_test_settings_show_value_cmd):
4605         (maintenance_show_test_settings_value_cmd): ... this.
4606         (_initialize_maint_test_settings): No longer install the "maint
4607         test-settings" prefix command.  Rename "maint test-settings set"
4608         to "maint set test-settings", and "maint test-settings show" to
4609         "maint show test-settings".  Adjust all subcommands.
4610
4611 2019-07-03  Pedro Alves  <palves@redhat.com>
4612
4613         * maint-test-settings.c: Fix file's intro comment.  Replace all
4614         references to "test-options" with references to "test-settings",
4615         in comments.
4616
4617 2019-07-03  Pedro Alves  <palves@redhat.com>
4618
4619         * maint-test-settings.c (maintenance_test_settings_xxx)
4620         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4621         New.
4622         (maintenance_test_settings_enums): Use them.
4623         (maintenance_test_settings_enum): Default to
4624         maintenance_test_settings_xxx.
4625         (_initialize_maint_test_settings): Initialize
4626         MAINTENANCE_TEST_SETTINGS_FILENAME.
4627
4628 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4629
4630         * breakpoint.h (remove_breakpoints_inf): Change return type to
4631         void, move function documentation here.
4632         * breakpoint.c (remove_breakpoints_inf): Change return type to
4633         void, move function documentation to header.
4634
4635 2019-07-02  Pedro Alves  <palves@redhat.com>
4636
4637         * NEWS (Completion improvements): Mention "info threads".
4638         * thread.c (struct info_threads_opts, info_threads_option_defs)
4639         (make_info_threads_options_def_group): New.
4640         (info_threads_command): Use gdb::option::process_options.
4641         (info_threads_command_completer): New.
4642         (_initialize_thread): Use gdb::option::build_help to build the
4643         help text for "info threads".
4644
4645 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4646
4647         * defs.h (generic_load): Move from here...
4648         * symfile.h (generic_load): ... to here.  Rename name parameter
4649         to args.
4650         * symfile.c (generic_load): Add comment.
4651
4652 2019-07-01  Tom Tromey  <tromey@adacore.com>
4653
4654         * dwarf2read.c
4655         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4656         declaration of without_params.  Fix formatting.
4657
4658 2019-07-01  Tom Tromey  <tromey@adacore.com>
4659
4660         * ada-exp.y (find_primitive_type): Update.
4661         * ada-lang.h (ada_lookup_symbol): Update.
4662         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4663         parameter.
4664         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4665
4666 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4667
4668         PR breakpoints/24541
4669         * gdbarch.c: Regenerate.
4670         * gdbarch.h: Regenerate.
4671         * gdbarch.sh: Add 'stap_adjust_register'.
4672         * i386-tdep.c: Include '<unordered_set>'.
4673         (i386_stap_adjust_register): New function.
4674         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4675         * stap-probe.c (stap_parse_register_operand): Call
4676         'gdbarch_stap_adjust_register'.
4677
4678 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4679
4680         PR python/24742
4681         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4682         * python/python.c (do_start_initialization): Use 'xmalloc'
4683         instead of 'PyMem_Malloc'.
4684
4685 2019-06-28  Tom Tromey  <tromey@adacore.com>
4686
4687         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4688         for Ada.
4689
4690 2019-06-27  Tom Tromey  <tromey@adacore.com>
4691
4692         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4693         objfile_key.
4694         (arm_find_mapping_symbol, arm_record_special_symbol)
4695         (_initialize_arm_tdep): Update.
4696         (arm_objfile_data_free): Remove.
4697
4698 2019-06-27  Tom Tromey  <tromey@adacore.com>
4699
4700         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4701         to cp_print_static_field.
4702
4703 2019-06-26  Tom Tromey  <tromey@adacore.com>
4704
4705         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4706         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4707         declare.
4708
4709 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4710
4711         * features/aarch64-core.c (create_feature_aarch64_core):
4712         Regenerate.
4713         * features/aarch64-core.xml: Add cpsr flags.
4714
4715 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4716
4717         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4718         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4719
4720 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4721
4722         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4723         field.
4724         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4725         use.
4726         (arm_record_special_symbol): Don't insert new symbol in sorted
4727         position, push it at the end.
4728
4729 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4730
4731         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4732         (arm_mapping_symbol_s): Remove.
4733         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4734         (arm_mapping_symbol_vec): New typedef.
4735         (struct arm_per_objfile): Add constructor.
4736         <section_maps>: Change type to
4737         std::unique_ptr<arm_mapping_symbol_vec[]>.
4738         (arm_compare_mapping_symbols): Remove.
4739         (arm_find_mapping_symbol): Adjust to section_maps type change.
4740         (arm_objfile_data_free): Call delete on arm_per_objfile.
4741         (arm_record_special_symbol): Adjust to section_maps type change.
4742         Allocate arm_per_objfile with new.
4743
4744 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4745
4746         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4747         with the command prefix.
4748
4749 2019-06-25  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4752         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4753
4754 2019-06-25  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4757         type.
4758         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4759         protected.
4760
4761 2019-06-25  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-winsource.c
4764         (tui_source_window_base::set_is_exec_point_at): Add check against
4765         LOA_ADDRESS.
4766
4767 2019-06-25  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-source.c (tui_set_source_content): Don't check before
4770         xfree.
4771         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4772
4773 2019-06-25  Tom Tromey  <tom@tromey.com>
4774
4775         * tui/tui-winsource.h (tui_update_source_window_as_is)
4776         (tui_alloc_source_buffer, tui_line_is_displayed)
4777         (tui_addr_is_displayed): Change type of win_info.
4778         * tui/tui-winsource.c (tui_update_source_window_as_is)
4779         (tui_clear_source_content, tui_show_source_line)
4780         (tui_show_source_content, tui_source_window_base::refill)
4781         (tui_source_window_base::set_is_exec_point_at)
4782         (tui_source_window_base::set_is_exec_point_at)
4783         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4784         (tui_alloc_source_buffer, tui_line_is_displayed)
4785         (tui_addr_is_displayed): Change type of win_info.  Update.
4786         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4787         (tui_source_window_base::do_make_visible_with_new_height):
4788         Update.
4789         * tui/tui-source.c (tui_set_source_content)
4790         (tui_set_source_content_nil)
4791         (tui_source_window::do_scroll_vertical): Update.
4792         * tui/tui-layout.c (show_layout): Update.
4793         * tui/tui-disasm.c (tui_set_disassem_content)
4794         (tui_disasm_window::do_scroll_vertical): Update.
4795         * tui/tui-data.h (tui_win_content): Remove.
4796         (struct tui_gen_win_info) <content, content_size>: Remove.
4797         (struct tui_source_element): Add initializers and destructor.
4798         (union tui_which_element, struct tui_win_element): Remove.
4799         (struct tui_source_window_base) <content>: New field.
4800         (struct tui_data_window): Remove destructor.
4801         (tui_alloc_content, tui_free_win_content)
4802         (tui_free_all_source_wins_content): Don't declare.
4803         * tui/tui-data.c (tui_initialize_static_data): Update.
4804         (init_content_element, tui_alloc_content): Remove.
4805         (~tui_gen_win_info): Update.
4806         (~tui_data_window, tui_free_all_source_wins_content)
4807         (tui_free_win_content, free_content, free_content_elements):
4808         Remove.
4809
4810 2019-06-25  Tom Tromey  <tom@tromey.com>
4811
4812         * tui/tui-winsource.h (tui_clear_source_content)
4813         (tui_erase_source_content, tui_show_source_content): Change type
4814         of win_info.
4815         * tui/tui-winsource.c (tui_clear_source_content)
4816         (tui_erase_source_content, tui_show_source_content): Change type
4817         of win_info.
4818         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4819         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4820         win_info.
4821         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4822         win_info.
4823         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4824
4825 2019-06-25  Tom Tromey  <tom@tromey.com>
4826
4827         * tui/tui-winsource.c (tui_clear_source_content)
4828         (tui_source_window_base::set_is_exec_point_at): Update.
4829         * tui/tui-source.c (tui_set_source_content_nil): Update.
4830         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4831         a bool.
4832         * tui/tui-data.c (init_content_element): Update.
4833
4834 2019-06-25  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4837         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4838         * tui/tui-layout.c (init_and_make_win): Update.
4839         * tui/tui.h (enum tui_win_type): Update.
4840         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4841         tui_win_is_auxillary.
4842         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4843         tui_win_is_auxillary.
4844
4845 2019-06-25  Tom Tromey  <tom@tromey.com>
4846
4847         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4848         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4849         (tui_delete_data_content_windows, tui_display_all_data)
4850         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4851         Update.
4852         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4853         * tui/tui-regs.c (tui_last_regs_line_no)
4854         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4855         (tui_show_registers): Update.
4856         (tui_show_register_group): Return void.  Update.
4857         (tui_display_registers_from, tui_display_reg_element_at_line)
4858         (tui_display_registers_from_line, tui_check_register_values):
4859         Update.
4860         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4861         member.
4862         (struct tui_data_window) <regs_content>: Now a std::vector.
4863         <regs_content_count>: Remove.
4864         (tui_add_content_elements, tui_free_data_content): Don't declare.
4865         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4866         (init_content_element): Remove DATA_WIN case.  Add assert.
4867         (tui_add_content_elements): Remove.
4868         (tui_data_window): Update.
4869         (tui_free_data_content): Remove.
4870         (free_content_elements): Remove DATA_WIN case.
4871
4872 2019-06-25  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-data.c (tui_data_item_window): Update.
4875         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4876         * tui/tui-windata.c (tui_display_all_data)
4877         (tui_display_data_from_line): Update.
4878         (tui_check_data_values): Remove.
4879         * tui/tui-regs.c (tui_show_register_group)
4880         (tui_display_reg_element_at_line): Update.
4881         * tui/tui-hooks.c (tui_register_changed)
4882         (tui_refresh_frame_and_register_information): Call
4883         tui_check_register_values.
4884         * tui/tui-data.h (struct tui_data_window) <data_content,
4885         data_content_count, data_type>: Remove.
4886         (enum tui_data_type): Remove.
4887
4888         * tui/tui-data.c (tui_data_window::clear_detail)
4889         (~tui_data_window): Update.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4894         declare.
4895         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4896         Rename from tui_first_data_item_displayed.  Update.
4897         (tui_data_window::refresh_all)
4898         (tui_data_window::do_scroll_vertical): Update.
4899         * tui/tui-data.h (struct tui_data_window)
4900         <first_data_item_displayed>: Declare new method.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4905         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4906         contents...
4907         (tui_initialize_static_data): ...here.
4908
4909 2019-06-25  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4912         (tui_display_registers_from, tui_check_register_values): Update.
4913         (tui_display_register): Remove win_info parameter; update.
4914         (tui_get_register): Change type of parameters.
4915         * tui/tui-data.h (struct tui_data_element): Remove.
4916         (union tui_which_element) <data>: Remove.
4917         <data_window>: Change type.
4918         (struct tui_data_item_window): New.
4919         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4920         case.  Add assert.
4921         (~tui_data_item_window): New destructor.
4922         (free_content_elements): Remove DATA_ITEM_WIN case.
4923
4924 2019-06-25  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4927         Remove.
4928
4929 2019-06-25  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-data.h (struct tui_command_element): Remove.
4932         (union tui_which_element) <command>: Remove.
4933         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4934         assert.
4935         (free_content_elements): Remove CMD_WIN case.
4936
4937 2019-06-25  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-layout.c (tui_set_layout): Update.
4940         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4941         * tui/tui-data.c (layout_def): Update.
4942
4943 2019-06-25  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4946         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4947         (tui_source_window_base::set_new_height): Update.
4948         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4949         Update.
4950         (tui_set_locator_fullname, tui_set_locator_info)
4951         (tui_show_frame_info): Update.
4952         * tui/tui-source.c (tui_set_source_content)
4953         (tui_source_is_displayed): Update.
4954         * tui/tui-layout.c (show_source_disasm_command, show_data)
4955         (show_source_or_disasm_and_command): Update.
4956         * tui/tui-disasm.c (tui_set_disassem_content)
4957         (tui_get_begin_asm_address): Update.
4958         * tui/tui-data.h (struct tui_locator_element): Remove.
4959         (union tui_which_element) <locator>: Remove.
4960         (struct tui_locator_window): New.
4961         (tui_locator_win_info_ptr): Change return type.
4962         * tui/tui-data.c (_locator): Change type.
4963         (tui_locator_win_info_ptr): Change return type.
4964         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4965         (tui_alloc_content): Add assert.
4966
4967 2019-06-25  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-winsource.c
4970         (tui_exec_info_window::maybe_allocate_content): New method.
4971         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4972         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4973         (make_source_or_disasm_window): Add cast.
4974         * tui/tui-data.h (union tui_which_element) <simple_string>:
4975         Remove.
4976         (struct tui_source_info): New.
4977         (struct tui_source_window_base) <execution_info>: Change type.
4978         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4979         case, and add assert.
4980         (tui_alloc_content): Add assert.
4981
4982 2019-06-25  Tom Tromey  <tom@tromey.com>
4983
4984         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4985         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4986         * tui/tui-data.c (tui_alloc_win_info): Remove.
4987
4988 2019-06-25  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4991         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4992         can_highlight.
4993
4994 2019-06-25  Tom Tromey  <tom@tromey.com>
4995
4996         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4997         make_visible_with_new_height method.
4998         (tui_win_info::make_visible_with_new_height): New method.
4999         (tui_source_window_base::do_make_visible_with_new_height)
5000         (tui_data_window::do_make_visible_with_new_height)
5001         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5002         (make_visible_with_new_height): Remove.
5003         (tui_resize_all, tui_adjust_win_heights): Use
5004         make_visible_with_new_height method.
5005         * tui/tui-data.h (struct tui_win_info)
5006         <do_make_visible_with_new_height, make_visible_with_new_height>:
5007         New methods.
5008         (struct tui_source_window_base, struct tui_data_window)
5009         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5010         methods.
5011
5012 2019-06-25  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5015         method.
5016         (update_tab_width): Call update_tab_width method.
5017         * tui/tui-data.h (struct tui_win_info)
5018         (struct tui_source_window_base) <update_tab_width>: New methods.
5019
5020 2019-06-25  Tom Tromey  <tom@tromey.com>
5021
5022         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5023         parameter.
5024         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5025         parameter.
5026         (tui_gen_win_info::make_visible): Update.
5027         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5028         parameter.
5029         * tui/tui-data.h (enum tui_box): New enum.
5030         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5031
5032 2019-06-25  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5035         init_and_make_win for EXEC_INFO_WIN.
5036         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5037         longer inline.
5038         (struct tui_win_info) <~tui_win_info>: Inline.
5039         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5040         Don't declare.
5041         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5042         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5043         Remove.
5044         (tui_initialize_static_data): Update.
5045         (~tui_gen_win_info): Handle more cleanup here.
5046         (~tui_source_window_base): Delete "execution_info".
5047         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5048
5049 2019-06-25  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui-layout.c (make_command_window): Don't set
5052         can_highlight.
5053         (show_source_disasm_command): Call the reset method.
5054         (show_data): Don't set can_highlight.  Call the reset method.
5055         (tui_gen_win_info::reset): Rename from init_gen_win_info
5056         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5057         (show_source_or_disasm_and_command): Call the reset method.
5058         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5059         (struct tui_cmd_window): Set can_highlight.
5060
5061 2019-06-25  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5064         from make_visible.
5065         (tui_make_visible, tui_make_invisible): Rewrite.
5066         (tui_win_info::make_visible): Remove.
5067         (tui_source_window_base::make_visible): Update.
5068         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5069         method.  Moved from...
5070         (struct tui_win_info) <make_visible>: ...here.
5071
5072 2019-06-25  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-winsource.c
5075         (tui_source_window_base::do_scroll_horizontal): Remove direction
5076         parameter.
5077         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5078         direction parameter.
5079         * tui/tui-win.c (tui_win_info::forward_scroll)
5080         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5081         (tui_win_info::right_scroll): Update.
5082         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5083         direction parameter.
5084         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5085         direction parameter.
5086         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5087         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5088         Remove direction parameter.
5089         (struct tui_source_window_base, struct tui_source_window)
5090         (struct tui_disasm_window, struct tui_data_window)
5091         (struct tui_cmd_window): Update.
5092
5093 2019-06-25  Tom Tromey  <tom@tromey.com>
5094
5095         * tui/tui-winsource.h (tui_set_exec_info_content)
5096         (tui_show_exec_info_content, tui_erase_exec_info_content)
5097         (tui_clear_exec_info_content, tui_update_exec_info): Change
5098         argument to tui_source_window_base.
5099         * tui/tui-winsource.c (tui_set_exec_info_content)
5100         (tui_show_exec_info_content, tui_erase_exec_info_content)
5101         (tui_clear_exec_info_content, tui_update_exec_info): Change
5102         argument to tui_source_window_base.
5103
5104 2019-06-25  Tom Tromey  <tom@tromey.com>
5105
5106         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5107         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5108
5109 2019-06-25  Tom Tromey  <tom@tromey.com>
5110
5111         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5112         check.
5113
5114 2019-06-25  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5117         type to void.
5118         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5119         type to void.
5120         * tui/tui-source.c (tui_set_source_content): Update.
5121         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-win.c (window_name_completer, tui_set_focus)
5126         (tui_all_windows_info): Use name method.
5127         * tui/tui-data.h (struct tui_gen_win_info)
5128         (struct tui_source_window, struct tui_disasm_window)
5129         (struct tui_data_window, struct tui_cmd_window) <name>: New
5130         method.
5131         (tui_win_name): Don't declare.
5132         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5133         (tui_win_name): Remove.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-winsource.h (tui_update_source_window)
5138         (tui_update_source_window_as_is): Change parameter type.
5139         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5140         to be a tui_source_window_base.
5141         (tui_update_source_window_as_is): Likewise.
5142         * tui/tui-win.c (make_visible_with_new_height): Update.
5143
5144 2019-06-25  Tom Tromey  <tom@tromey.com>
5145
5146         * tui/tui-winsource.c (tui_erase_source_content)
5147         (tui_show_source_content, tui_show_exec_info_content)
5148         (tui_erase_exec_info_content): Use refresh_window method.
5149         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5150         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5151         from tui_refresh_win.
5152         (tui_data_window::refresh_window): New method.
5153         (tui_win_info::refresh, tui_source_window_base::refresh)
5154         (tui_refresh_all): Use refresh_window method.
5155         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5156         method.
5157         * tui/tui-regs.c (tui_display_register): Call refresh_window
5158         method.
5159         * tui/tui-layout.c (show_source_disasm_command)
5160         (show_source_or_disasm_and_command): Call refresh_window method.
5161         * tui/tui-data.h (struct tui_gen_win_info)
5162         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5163         New method.
5164
5165 2019-06-25  Tom Tromey  <tom@tromey.com>
5166
5167         * tui/tui.c (tui_rl_other_window, tui_enable)
5168         (tui_is_window_visible, tui_get_command_dimension): Update.
5169         * tui/tui-winsource.c (tui_update_source_window_as_is)
5170         (tui_clear_source_content, tui_erase_source_content)
5171         (tui_show_source_line, tui_source_window_base::refill)
5172         (tui_source_window_base::do_scroll_horizontal)
5173         (tui_source_window_base::set_is_exec_point_at)
5174         (tui_update_breakpoint_info, tui_set_exec_info_content)
5175         (tui_alloc_source_buffer, tui_line_is_displayed)
5176         (tui_addr_is_displayed): Update.
5177         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5178         (tui_check_and_display_highlight_if_needed)
5179         (tui_win_info::make_visible, tui_win_info::refresh)
5180         (tui_refresh_all): Update.
5181         * tui/tui-windata.c (tui_first_data_item_displayed)
5182         (tui_delete_data_content_windows, tui_erase_data_content)
5183         (tui_display_all_data, tui_data_window::refresh_all)
5184         (tui_check_data_values): Update.
5185         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5186         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5187         (tui_win_info::backward_scroll, tui_refresh_all_win)
5188         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5189         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5190         (tui_source_window_base::set_new_height)
5191         (tui_data_window::set_new_height)
5192         (make_invisible_and_set_new_height)
5193         (make_visible_with_new_height, new_height_ok)
5194         (parse_scrolling_args): Update.
5195         * tui/tui-stack.c (tui_show_frame_info): Update.
5196         * tui/tui-source.c (tui_set_source_content)
5197         (tui_set_source_content_nil, tui_source_is_displayed)
5198         (tui_source_window::do_scroll_vertical): Update.
5199         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5200         (tui_display_registers_from, tui_display_reg_element_at_line)
5201         (tui_check_register_values, tui_reg_command): Update.
5202         * tui/tui-layout.c (tui_default_win_height)
5203         (show_source_disasm_command, show_data, init_and_make_win)
5204         (show_source_or_disasm_and_command): Update.
5205         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5206         (tui_redisplay_readline, tui_mld_flush)
5207         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5208         (tui_getc): Update.
5209         * tui/tui-disasm.c (tui_set_disassem_content)
5210         (tui_disasm_window::do_scroll_vertical): Update.
5211         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5212         Now virtual.
5213         (struct tui_win_info): Derive from tui_gen_win_info.
5214         <~tui_win_info>: Mark as override.
5215         <generic>: Remove member.
5216         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5217         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5218         (~tui_data_window, ~tui_win_info)
5219         (tui_free_all_source_wins_content): Update.
5220         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5221
5222 2019-06-25  Tom Tromey  <tom@tromey.com>
5223
5224         * tui/tui-layout.c (init_and_make_win): Use new.
5225         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5226         destructor, initializers.
5227         (tui_alloc_generic_win_info): Don't declare.
5228         * tui/tui-data.c (_locator): Add argument to constructor.
5229         (source_win, disasm_win): New globals.
5230         (exec_info): Remove.
5231         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5232         Update.
5233         (tui_alloc_generic_win_info): Remove.
5234         (init_content_element): Use new.
5235         (tui_win_info::tui_win_info): Update.
5236         (free_content_elements) <case DATA_WIN>: Use delete.
5237
5238 2019-06-25  Tom Tromey  <tom@tromey.com>
5239
5240         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5241         * tui/tui-windata.c (tui_first_data_item_displayed)
5242         (tui_delete_data_content_windows): Update.
5243         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5244         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5245         (tui_display_registers_from, tui_check_register_values): Update.
5246         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5247         pointer.
5248         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5249         window.
5250         (tui_free_data_content): Update.
5251         (free_content_elements) <case DATA_WIN>: Free the window.
5252
5253 2019-06-25  Tom Tromey  <tom@tromey.com>
5254
5255         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5256         Update.
5257         * tui/tui-layout.c (make_command_window)
5258         (show_source_disasm_command, show_data, init_and_make_win)
5259         (show_source_or_disasm_and_command): Update.
5260         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5261         method.
5262         <can_highight, is_highlighted>: Now bool.
5263         (tui_set_win_highlight): Don't declare.
5264         * tui/tui-data.c (tui_set_win_highlight): Remove.
5265
5266 2019-06-25  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-wingeneral.c (make_visible): Remove check of window
5269         type.
5270
5271 2019-06-25  Tom Tromey  <tom@tromey.com>
5272
5273         * tui/tui-win.c (tui_win_info::max_height)
5274         (tui_cmd_window::max_height): New methods.
5275         (new_height_ok): Call max_height.
5276         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5277         <max_height>: New method.
5278
5279 2019-06-25  Tom Tromey  <tom@tromey.com>
5280
5281         * tui/tui-win.c (tui_source_window_base::set_new_height)
5282         (tui_data_window::set_new_height): New methods.
5283         (make_invisible_and_set_new_height): Call set_new_height method.
5284         * tui/tui-data.h (struct tui_win_info)
5285         (struct tui_source_window_base, struct tui_data_window)
5286         <set_new_height>: New method.
5287
5288 2019-06-25  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5291         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5292         tui_refresh_data_win.
5293         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5294         method.
5295         (tui_refresh_all_win): Call the refresh_all method.
5296         (tui_set_focus): Likewise.
5297         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5298         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5299         Likewise.
5300
5301 2019-06-25  Tom Tromey  <tom@tromey.com>
5302
5303         * tui/tui-winsource.h (tui_refill_source_window)
5304         (tui_set_is_exec_point_at): Don't declare.
5305         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5306         (tui_source_window_base::refill): Rename from
5307         tui_refill_source_window.
5308         (tui_source_window_base::do_scroll_horizontal): Update.
5309         (tui_source_window_base::set_is_exec_point_at): Rename from
5310         tui_set_is_exec_point_at.
5311         (tui_update_all_breakpoint_info): Update.
5312         * tui/tui-stack.c (tui_show_frame_info): Update.
5313         * tui/tui-layout.c (show_data): Add cast.
5314         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5315         * tui/tui-data.h (struct tui_source_window_base) <refill,
5316         set_is_exec_point_at>: New methods.
5317         (tui_source_windows, tui_add_to_source_windows): Update types.
5318         (tui_add_to_source_windows): Remove redundant declaration.
5319         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5320         (tui_source_windows): Change return type.
5321         (tui_clear_source_windows_detail): Update.
5322         (tui_add_to_source_windows): Change type of parameter.
5323         (tui_free_all_source_wins_content): Update.
5324
5325 2019-06-25  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-wingeneral.c (tui_win_info::refresh)
5328         (tui_source_window_base::refresh): New methods.
5329         (tui_refresh_all): Call the refresh method.
5330         * tui/tui-data.h (struct tui_win_info)
5331         (struct tui_source_window_base) <refresh>: New method.
5332
5333 2019-06-25  Tom Tromey  <tom@tromey.com>
5334
5335         * tui/tui.h (tui_is_window_visible): Return bool.
5336         * tui/tui.c (tui_is_window_visible): Return bool.
5337         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5338         (tui_make_visible, tui_make_invisible)
5339         (tui_win_info::make_visible)
5340         (tui_source_window_base::make_visible, make_all_visible)
5341         (tui_make_all_visible, tui_make_all_invisible): Update.
5342         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5343         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5344         bool.
5345         (struct tui_win_info, struct tui_source_window_base)
5346         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5347         * tui/tui-data.c (tui_init_generic_part): Update.
5348
5349 2019-06-25  Tom Tromey  <tom@tromey.com>
5350
5351         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5352         (tui_source_window_base::make_visible): New methods.
5353         (make_all_visible): Make method call.
5354         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5355         (struct tui_source_window_base, struct tui_cmd_window): Override
5356         make_visible.
5357         (tui_win_is_source_type): Don't declare.
5358         * tui/tui-data.c (tui_win_is_source_type): Remove.
5359
5360 2019-06-25  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5363         NULL check.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5368         Inline constructor.  Add initializers for members.
5369         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5370         constructors; now inline in class.
5371
5372 2019-06-25  Tom Tromey  <tom@tromey.com>
5373
5374         * tui/tui-regs.c (tui_show_registers): Update.
5375         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5376         bool.
5377         * tui/tui-data.c (tui_data_window::clear_detail)
5378         (tui_data_window): Update.
5379
5380 2019-06-25  Tom Tromey  <tom@tromey.com>
5381
5382         * tui/tui-windata.c (tui_display_all_data)
5383         (tui_display_data_from_line, tui_display_data_from)
5384         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5385         Update.
5386         * tui/tui-regs.c (tui_last_regs_line_no)
5387         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5388         (tui_show_registers, tui_show_register_group)
5389         (tui_display_registers_from, tui_display_reg_element_at_line)
5390         (tui_display_registers_from_line, tui_check_register_values)
5391         (tui_reg_next, tui_reg_prev): Update.
5392         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5393         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5394         tui_data_window.
5395         (struct tui_win_info) <detail>: Remove.  Add new fields from
5396         tui_data_info.
5397         (TUI_DATA_WIN): Add cast.
5398         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5399         (~tui_data_window): Simplify.
5400
5401 2019-06-25  Tom Tromey  <tom@tromey.com>
5402
5403         * tui/tui-layout.c (show_source_disasm_command)
5404         (show_source_or_disasm_and_command): Update.
5405         * tui/tui-io.c (update_cmdwin_start_line)
5406         (tui_redisplay_readline): Update.
5407         * tui/tui-data.h (struct tui_command_info): Remove.
5408         (struct tui_win_info) <detail>: Remove command_info member.
5409         (struct tui_data_window) <start_line>: New member, from
5410         tui_command_info.
5411         (TUI_CMD_WIN): Add casts.
5412
5413 2019-06-25  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-winsource.c (tui_update_source_window)
5416         (tui_refill_source_window)
5417         (tui_source_window_base::do_scroll_horizontal)
5418         (tui_update_breakpoint_info, tui_set_exec_info_content)
5419         (tui_show_exec_info_content, tui_erase_exec_info_content)
5420         (tui_clear_exec_info_content): Update.
5421         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5422         Update.
5423         * tui/tui-win.c (make_invisible_and_set_new_height)
5424         (make_visible_with_new_height): Update.
5425         * tui/tui-source.c (tui_set_source_content)
5426         (tui_show_symtab_source): Update.
5427         * tui/tui-layout.c (extract_display_start_addr)
5428         (show_source_disasm_command, show_data)
5429         (make_source_or_disasm_window)
5430         (show_source_or_disasm_and_command): Update.
5431         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5432         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5433         "gdbarch".
5434         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5435         to tui_source_window_base.
5436         (struct tui_win_info) <detail>: Remove source_info member.
5437         (struct tui_source_window_base) <has_locator>: Inline.
5438         Move contents from tui_source_info; rename has_locator member to
5439         m_has_locator.
5440         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5441         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5442         header file.
5443         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5444         Simplify.
5445         (tui_free_all_source_wins_content): Cast to
5446         tui_source_window_base.
5447
5448 2019-06-25  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-win.c (make_invisible_and_set_new_height)
5451         (make_visible_with_new_height): Call has_locator method.
5452         * tui/tui-layout.c (show_source_disasm_command, show_data)
5453         (show_source_or_disasm_and_command): Update for bool change.
5454         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5455         (tui_win_info) <has_locator>: New method.
5456         (struct tui_source_window_base) <has_locator>: New method.
5457         (tui_win_has_locator): Don't declare.
5458         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5459         from tui_win_has_locator.
5460         (tui_source_window_base): Use false, not FALSE.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5465         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5466         clear_detail method directly.
5467         (tui_clear_win_detail): Remove.
5468
5469 2019-06-25  Tom Tromey  <tom@tromey.com>
5470
5471         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5472         "this", not TUI_DISASM_WIN.
5473
5474 2019-06-25  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5477         declare.
5478         * tui/tui-winsource.c
5479         (tui_source_window_base::do_scroll_horizontal): Rename from
5480         tui_horizontal_source_scroll.
5481         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5482         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5483         from tui_vertical_data_scroll.
5484         * tui/tui-win.h (tui_scroll): Don't declare.
5485         * tui/tui-win.c (tui_win_info::forward_scroll)
5486         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5487         (tui_win_info::right_scroll): Rename and update.
5488         (tui_scroll_forward_command, tui_scroll_backward_command)
5489         (tui_scroll_left_command, tui_scroll_right_command): Update.
5490         (tui_scroll): Remove.
5491         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5492         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5493         from tui_vertical_source_scroll.
5494         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5495         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5496         from tui_vertical_disassem_scroll.
5497         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5498         do_scroll_horizontal>: New methods.
5499         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5500         Likewise.
5501         (struct tui_source_window_base): Add do_scroll_horizontal.
5502         (struct tui_source_window, struct tui_disasm_window): Add
5503         do_scroll_vertical.
5504         (struct tui_data_window, struct tui_cmd_window): Add
5505         do_scroll_horizontal and do_scroll_vertical.
5506         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5507
5508 2019-06-25  Tom Tromey  <tom@tromey.com>
5509
5510         * tui/tui-data.h (struct tui_source_window_base): New struct.
5511         (struct tui_source_window): Derive from tui_source_window_base.
5512         (struct tui_disasm_window): New struct.
5513         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5514         from tui_source_window::clear_detail.
5515         (tui_source_window_base): Rename from tui_source_window.
5516         (~tui_source_window_base): Rename from ~tui_source_window.
5517         (tui_alloc_win_info): Create a tui_disasm_window.
5518
5519 2019-06-25  Tom Tromey  <tom@tromey.com>
5520
5521         * tui/tui-data.h (struct tui_source_window)
5522         (struct tui_data_window): Declare destructors.
5523         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5524         destructors.
5525         (tui_win_info): Simplify.
5526
5527 2019-06-25  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-winsource.c (tui_display_main)
5530         (tui_update_source_windows_with_addr)
5531         (tui_update_all_breakpoint_info): Update.
5532         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5533         (new_height_ok, parse_scrolling_args): Update.
5534         * tui/tui-stack.c (tui_show_frame_info): Update.
5535         * tui/tui-data.h (struct tui_list): Remove.
5536         (tui_source_windows): Return a reference to a std::vector.
5537         * tui/tui-data.c (source_windows): Now a std::vector.
5538         (tui_source_windows): Change return type.
5539         (tui_clear_source_windows): Rewrite.
5540         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5541         (tui_free_all_source_wins_content): Rewrite.
5542
5543 2019-06-25  Tom Tromey  <tom@tromey.com>
5544
5545         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5546         (struct tui_data_window, struct tui_cmd_window): Declare
5547         clear_detail method.
5548         * tui/tui-data.c (tui_source_window::clear_detail)
5549         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5550         methods.
5551         (tui_clear_win_detail): Simplify.
5552
5553 2019-06-25  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-layout.c (make_source_window, make_disasm_window)
5556         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5557         Return the new window.
5558         (show_source_disasm_command, show_data)
5559         (show_source_or_disasm_and_command): Update.
5560
5561 2019-06-25  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5564         parameter.  Return the new window.
5565         (show_source_disasm_command): Update and remove NULL check.
5566         (show_source_or_disasm_and_command): Update.
5567
5568 2019-06-25  Tom Tromey  <tom@tromey.com>
5569
5570         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-data.h (struct tui_win_info): Make constructor
5575         protected.  Make destructor virtual.  Add initializers.
5576         (tui_source_window, tui_data_window, tui_cmd_window): New
5577         classes.
5578         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5579         constructor.  Add "type" parameter.
5580         (tui_source_window, tui_data_window, tui_cmd_window): New
5581         constructors.
5582         (tui_alloc_win_info): Instantiate the appropriate subclass.
5583
5584 2019-06-25  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-win.c (tui_resize_all): Use delete.
5587         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5588         destructor.
5589         (tui_free_window): Don't declare.
5590         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5591         Update.
5592
5593 2019-06-25  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-data.h (struct tui_win_info): Add constructor.
5596         * tui/tui-data.c (tui_alloc_win_info): Use new.
5597         (tui_free_window): Use delete.
5598
5599 2019-06-22  Tom Tromey  <tom@tromey.com>
5600
5601         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5602         declare.
5603         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5604
5605 2019-06-22  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5608         declare.
5609         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5610
5611 2019-06-22  Tom de Vries  <tdevries@suse.de>
5612
5613         * dwarf2read.c (create_addrmap_from_aranges)
5614         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5615         instead of '%zu'.
5616
5617 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5618
5619         * dwarf2read.h (dwarf2_section_info_def): Remove.
5620         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5621         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5622         std::vector<dwarf2_section_info>.
5623         (struct dwo_file) <~dwo_file>: Remove.
5624         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5625         types field.
5626         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5627         (dwarf2_read_debug_names): Likewise.
5628         (create_debug_types_hash_table): Change parameter type to
5629         array_view, adjust code accordingly.
5630         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5631         (partial_die_info::fixup): Likewise.
5632         (determine_prefix): Likewise.
5633         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5634
5635 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5636
5637         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5638         gdb_bfd_ref_ptr.
5639         <~dwo_file>: Remove call to gdb_bfd_unref.
5640         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5641         gdb_bfd_ref_ptr::get.
5642
5643 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5644
5645         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5646         type to htab_up.
5647         * dwarf2read.c (struct dwo_file): Initialize fields.
5648         <~dwo_file>: New.
5649         (free_dwo_file): Remove, move content to ~dwo_file.
5650         (struct dwo_file_deleter): Remove.
5651         (dwo_file_up>: Remove custom deleter.
5652         (free_dwo_files): Remove.
5653         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5654         dwo_files.
5655         (process_skeletonless_type_units): Call unique_ptr::get.
5656         (allocate_dwo_file_hash_table): Add deleter to created hash
5657         table.  Change return type to htab_up.
5658         (lookup_dwo_file_slot): Don't memset dwo_file, call
5659         unique_ptr::get.
5660         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5661         (create_dwo_unit_in_dwp_v2): Likewise.
5662         (open_and_init_dwo_file): Likewise.
5663         (free_dwo_file_from_slot): Remove.
5664
5665 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5666
5667         * dwarf2read.h (struct dwarf2_section_info) <readin,
5668         is_virtual>: Change type to bool.
5669         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5670         true instead of 1.
5671
5672 2019-06-19  Tom Tromey  <tom@tromey.com>
5673
5674         * tui/tui-data.h (tui_init_content_element): Don't declare.
5675
5676 2019-06-19  Tom Tromey  <tom@tromey.com>
5677
5678         * tui/tui-data.h (tui_init_win_info): Don't declare.
5679
5680 2019-06-19  Tom de Vries  <tdevries@suse.de>
5681
5682         * dwarf2read.h (abstract_to_concrete): Change type to
5683         std::unordered_map<sect_offset, std::vector<sect_offset>,
5684         gdb::hash_enum<sect_offset>>.
5685
5686 2019-06-19  Tom Tromey  <tromey@adacore.com>
5687
5688         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5689         EVAL_AVOID_SIDE_EFFECTS specially.
5690
5691 2019-06-19  Tom Tromey  <tromey@adacore.com>
5692
5693         * source-cache.c (highlighter): New global.
5694         (source_cache::get_source_lines): Create a highlighter on demand.
5695
5696 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5697
5698         * defs.h (deprecated_interactive_hook): Delete declaration.
5699         * interps.c (clear_interpreter_hooks): Remove use of
5700         deprecated_interactive_hook.
5701         * top.c (deprecated_interactive_hook): Delete definition.
5702         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5703
5704 2019-06-18  Tom de Vries  <tdevries@suse.de>
5705
5706         PR gdb/24515
5707         * dwarf2read.h (abstract_to_concrete): Change type from
5708         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5709         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5710         * dwarf2read.c (read_variable): Update.
5711         (dwarf2_fetch_die_loc_sect_off): Update.
5712
5713 2019-06-17  Tom de Vries  <tdevries@suse.de>
5714
5715         PR gdb/24617
5716         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5717         accessing parent[parent_len - 1].
5718
5719 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5720
5721         PR gdb/24364
5722         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5723         call dtrace_process_dof with NULL dof.
5724
5725 2019-06-16  Tom de Vries  <tdevries@suse.de>
5726
5727         PR gdb/24445
5728         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5729
5730 2019-06-16  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5733         (make_all_visible): Use address of member.
5734
5735 2019-06-16  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5738         (tui_free_window, free_content, free_content_elements): Remove
5739         unnecessary cast.
5740         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5741         cast.
5742         * tui/tui-regs.c (tui_show_register_group)
5743         (tui_display_registers_from, tui_display_reg_element_at_line):
5744         Remove unnecessary cast.
5745
5746 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5747
5748         * linux-nat.c (normal_mask): Delete.
5749         (_initialize_linux_nat): Don't initialise normal_mask.
5750
5751 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5752
5753         PR gdb/24445
5754         * dwarf-index-write.h (write_psymtabs_to_index): Add
5755         dwz_basename parameter.
5756         * dwarf-index-write.c (write_gdbindex): Move file writing to
5757         write_gdbindex_1.  Change return type void.
5758         (assert_file_size): Move up, remove filename parameter.
5759         (write_gdbindex_1): New function.
5760         (write_debug_names): Change return type to void, call
5761         assert_file_size.
5762         (struct index_wip_file): New struct.
5763         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5764         file logic to index_wip_file.  Write index for dwz file if
5765         needed.
5766         (save_gdb_index_command): Pass basename of dwz file, if present.
5767         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5768         build-id of dwz file, if present.
5769         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5770         (dwarf2_get_dwz_file): Likewise.
5771         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5772         (dwarf2_get_dwz_file): Likewise.
5773
5774 2019-06-16  Tom Tromey  <tom@tromey.com>
5775
5776         * coffread.c (process_coff_symbol): Use xstrdup.
5777         * value.c (create_internalvar): Use xstrdup.
5778
5779 2019-06-16  Tom Tromey  <tom@tromey.com>
5780
5781         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5782         * breakpoint.c (stopin_command, stopat_command)
5783         (until_break_command, decode_location_default): Remove unnecessary
5784         cast.
5785         * utils.c (subset_compare): Remove unnecessary cast.
5786         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5787         cast.
5788         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5789         cast.
5790         * infcmd.c (path_command): Remove unnecessary cast.
5791         * coffread.c (decode_type): Remove unnecessary cast.
5792         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5793         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5794         * tui/tui-stack.c (tui_show_locator_content)
5795         (tui_show_frame_info): Remove unnecessary cast.
5796         * tui/tui-win.c (tui_scroll_forward_command)
5797         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5798         (parse_scrolling_args): Remove unnecessary cast.
5799         * tui/tui-data.c (init_win_info, tui_del_window)
5800         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5801         (free_content_elements): Remove unnecessary cast.
5802         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5803         unnecessary cast.
5804         * tui/tui-source.c (tui_set_source_content)
5805         (tui_vertical_source_scroll): Remove unnecessary cast.
5806         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5807         cast.
5808         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5809         * tui/tui-regs.c (tui_display_registers_from)
5810         (tui_display_register): Remove unnecessary cast.
5811         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5812         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5813         (make_visible): Remove unnecessary cast.
5814         * tui/tui-winsource.c (tui_erase_source_content)
5815         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5816         unnecessary cast.
5817         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5818         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5819         * stabsread.c (read_type, read_array_type, read_range_type):
5820         Remove unnecessary cast.
5821         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5822         (parse_symbol, parse_type, upgrade_type, parse_external)
5823         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5824         unnecessary cast.
5825         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5826
5827 2019-06-16  Tom Tromey  <tom@tromey.com>
5828
5829         * tui/tui-data.c (tui_alloc_generic_win_info)
5830         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5831         checks.
5832
5833 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5834             Andrew Burgess  <andrew.burgess@embecosm.com>
5835
5836         * f-typeprint.c (f_print_type): Don't return early for not
5837         associated or not allocated types.
5838         (f_type_print_varspec_suffix): Add print_rank parameter and print
5839         ranks of array types in case they dangling.
5840         (f_type_print_base): Add print_rank parameter.
5841
5842 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * NEWS: Mention new MI commands.
5845         * break-catch-throw.c (enum exception_event_kind): Move to
5846         breakpoint.h.
5847         (print_mention_exception_catchpoint): Output text as a single
5848         message.
5849         (catch_exception_command_1): Rename to...
5850         (catch_exception_event): ...this, make non-static, update header
5851         command, and change some parameter types.
5852         (catch_catch_command): Update for changes to
5853         catch_exception_command_1.
5854         (catch_throw_command): Likewise.
5855         (catch_rethrow_command): Likewise.
5856         * breakpoint.c (enum exception_event_kind): Delete.
5857         * breakpoint.h (enum exception_event_kind): Moved here from
5858         break-catch-throw.c.
5859         (catch_exception_event): Declare.
5860         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5861         (mi_cmd_catch_throw): New function.
5862         (mi_cmd_catch_rethrow): New function.
5863         (mi_cmd_catch_catch): New function.
5864         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5865         'catch-catch' entries.
5866         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5867         (mi_cmd_catch_rethrow): Declare.
5868         (mi_cmd_catch_catch): Declare.
5869
5870 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * annotate.c (annotate_source_line): Change return type to void,
5873         update implementation to match.
5874         * annotate.h (annotate_source_line): Change return type to void,
5875         update header comment.
5876         * stack.c (print_frame_info): Don't change what frame information
5877         is printed based on whether annotations are on or not.
5878
5879 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5882         (annotate_source): Make static.
5883         (annotate_source_line): Moved from source.c and renamed from
5884         identify_source_line.  Update the return type.
5885         * annotate.h (annotate_source): Delete declaration.
5886         (annotate_source_line): Declaration moved from source.h, and
5887         renamed from identify_source_line.  Return type updated.
5888         * source.c (identify_source_line): Moved to annotate.c and renamed
5889         to annotate_source_line.
5890         (info_line_command): Remove check of annotation_level.
5891         * source.h (identify_source_line): Move declaration to annotate.h
5892         and rename to annotate_source_line.
5893         * stack.c: Add 'annotate.h' include.
5894         (print_frame_info): Remove check of annotation_level before
5895         calling annotate_source_line.
5896
5897 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5898
5899         * source-cache.c (source_cache::get_plain_source_lines): Use
5900         open_source_file_with_line_charpos instead of just
5901         open_source_file, remove call to find_source_lines.
5902         (source_cache::get_source_lines): Likewise.
5903         * source.c (find_source_lines): Make static.
5904         (get_filename_and_charpos): Renamed into...
5905         (open_source_file_with_line_charpos): ..this along with changes to
5906         return a scoped_fd, and some other minor clean ups.
5907         (identify_source_line): Use open_source_file_with_line_charpos.
5908         (search_command_helper): Use open_source_file_with_line_charpos
5909         instead of just open_source_file, remove call to
5910         find_source_lines.
5911         * source.h (open_source_file_with_line_charpos): Declare new
5912         function.
5913         (find_source_lines): Delete declaration.
5914
5915 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5916
5917         * source.c (get_filename_and_charpos): Remove fullname
5918         parameter.
5919         (identify_source_line): Update call to get_filename_and_charpos.
5920
5921 2019-06-14  Tom Tromey  <tromey@adacore.com>
5922
5923         PR gdb/24502:
5924         * ui-style.h (skip_ansi_escape): Update comment.
5925         * ui-file.h (class no_terminal_escape_file): New class.
5926         * ui-file.c (no_terminal_escape_file::write)
5927         (no_terminal_escape_file::puts): New methods.
5928         * cli/cli-logging.c (handle_redirections): Use
5929         no_terminal_escape_file.
5930
5931 2019-06-14  Tom Tromey  <tromey@adacore.com>
5932
5933         * NEWS: Move convenience variable news above Python news.
5934
5935 2019-06-14  Tom Tromey  <tom@tromey.com>
5936
5937         * gnulib: Move directory to top-level.
5938         * configure.ac: Don't configure gnulib.
5939         * configure: Rebuild.
5940         * common/common-defs.h: Use new path to gnulib.
5941         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5942         (GNULIB_H): Remove.
5943         (INCGNU): Look in new gnulib location.
5944         (HFILES_NO_SRCDIR): Remove gnulib files.
5945         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5946         (generated_files): Remove GNULIB_H.
5947         ($(LIBGNU), all-lib): Remove targets.
5948         (distclean): Don't mention GNULIB_BUILDDIR.
5949         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5950
5951 2019-06-14  Tom Tromey  <tromey@adacore.com>
5952
5953         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5954         Warn if symbol file does not provide any symbols.
5955
5956 2019-06-14  Tom Tromey  <tromey@adacore.com>
5957
5958         * source.c (find_and_open_source): Respect basenames_may_differ.
5959
5960 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * annotate.c (annotate_breakpoints_invalid): Make use of
5963         scoped_restore_terminal_state.
5964         (annotate_frames_invalid): Likewise.
5965
5966 2019-06-14  Tom Tromey  <tromey@adacore.com>
5967
5968         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5969         allow assignment to an internalvar.
5970
5971 2019-06-14  Tom Tromey  <tromey@adacore.com>
5972
5973         * ada-lex.l: Allow "_" in attribute names.
5974
5975 2019-06-14  Tom Tromey  <tromey@adacore.com>
5976
5977         PR gdb/24653:
5978         * regcache.c (registers_changed): Don't call alloca.
5979         * top.c (execute_command): Don't call alloca.
5980
5981 2019-06-13  Pedro Alves  <palves@redhat.com>
5982
5983         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5984         'expression'.  When parsing an expression, error out if there's
5985         junk after "unlimited".
5986         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5987         (do_set_command): Adjust calls to is_unlimited_literal.
5988
5989 2019-06-13  Pedro Alves  <palves@redhat.com>
5990
5991         * compile/compile.c (make_compile_options_def_group): Add braces
5992         around array_view initializer.
5993         * thread.c (make_thread_apply_all_options_def_group)
5994         (make_thread_apply_all_options_def_group): Likewise.
5995
5996 2019-06-13  Pedro Alves  <palves@redhat.com>
5997
5998         * NEWS (New commands): Mention "maint test-options
5999         require-delimiter", "maint test-options unknown-is-error", "maint
6000         test-options unknown-is-operand" and "maint show
6001         test-options-completion-result".
6002         (New command options, command completion): New section.
6003         (Completion improvements): New section.
6004         Mention that you can abbreviate "unlimited".
6005
6006 2019-06-13  Pedro Alves  <palves@redhat.com>
6007
6008         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6009         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6010         * unittests/cli-utils-selftests.c (test_parse_flags)
6011         (test_parse_flags_qcs): Delete.
6012         (test_cli_utils): Don't call deleted functions.
6013
6014 2019-06-13  Pedro Alves  <palves@redhat.com>
6015
6016         * thread.c: Include "cli/cli-option.h".
6017         (tp_array_compar_ascending): Global.
6018         (tp_array_compar): Delete function.
6019         (tp_array_compar_ascending, tp_array_compar_descending): New
6020         functions.
6021         (ascending_option_def, qcs_flag_option_def)
6022         (thr_qcs_flags_option_defs)
6023         (make_thread_apply_all_options_def_group)
6024         (make_thread_apply_options_def_group): New.
6025         (thread_apply_all_command): Use gdb::option::process_options.
6026         (thread_apply_command_completer)
6027         (thread_apply_all_command_completer): New.
6028         (thread_apply_command): Use gdb::option::process_options.
6029         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6030         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6031         to generate help text of "thread apply".  Adjust "taas"'s help.
6032         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6033         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6034
6035 2019-06-13  Pedro Alves  <palves@redhat.com>
6036
6037         * thread.c (thread_apply_command): Check for invalid TID with
6038         isdigit instead of !isalpha.
6039
6040 2019-06-13  Pedro Alves  <palves@redhat.com>
6041
6042         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6043         (validate_flags_qcs): New.
6044         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6045         (validate_flags_qcs): Declare.
6046         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6047         (make_frame_apply_options_def_group): New.
6048         (frame_apply_command_count): Process options with
6049         gdb::option::process_options.
6050         (frame_apply_completer): New.
6051         (frame_apply_level_completer, frame_apply_all_completer)
6052         (frame_apply_completer): New.
6053         (_initialize_stack): Update help of "frame apply", "frame apply
6054         level", "frame apply all" and "faas" to mention supported options
6055         and install command completers.
6056         * stack.h (frame_apply_all_completer): Declare.
6057         * thread.c: Include "stack.h".
6058         (tfaas_command): Add "--".
6059         (_initialize_thread): Update help "tfaas" to mention supported
6060         options and install command completer.
6061
6062 2019-06-13  Pedro Alves  <palves@redhat.com>
6063
6064         * completer.c (complete_nested_command_line): New.
6065         (gdb_completion_word_break_characters_throw): Add assertion.
6066         * completer.h (complete_nested_command_line): Declare.
6067
6068 2019-06-13  Pedro Alves  <palves@redhat.com>
6069
6070         * stack.c (parse_backtrace_qualifiers): New.
6071         (backtrace_command): Use it.
6072         (backtrace_command_completer): Complete on qualifiers.
6073
6074 2019-06-13  Pedro Alves  <palves@redhat.com>
6075
6076         * frame.c: Include "cli/cli-option.h.
6077         (user_set_backtrace_options): New.
6078         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6079         Delete.
6080         (get_prev_frame): Adjust.
6081         (boolean_option_def, uinteger_option_def)
6082         (set_backtrace_option_defs): New.
6083         (_initialize_frame): Adjust and use
6084         gdb::option::add_setshow_cmds_for_options to install "set
6085         backtrace past-main" and "set backtrace past-entry".
6086         * frame.h: Include "cli/cli-option.h".
6087         (struct frame_print_options): Forward declare.
6088         (print_frame_arguments_all, print_frame_arguments_scalars)
6089         (print_frame_arguments_none): Declare.
6090         (print_entry_values): Delete declaration.
6091         (struct frame_print_options, user_frame_print_options): New.
6092         (struct set_backtrace_options): New.
6093         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6094         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6095         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6096         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6097         (list_args_or_locals): Add frame_print_options parameter.
6098         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6099         * python/py-framefilter.c (enumerate_args): Pass down
6100         USER_FRAME_PRINT_OPTIONS.
6101         * stack.c: Include "cli/cli-option.h".
6102         (print_frame_arguments_all, print_frame_arguments_scalars)
6103         (print_frame_arguments_none): Declare.
6104         (print_raw_frame_arguments, print_entry_values): Delete.
6105         (user_frame_print_options): New.
6106         (boolean_option_def, enum_option_def, frame_print_option_defs):
6107         New.
6108         (struct backtrace_cmd_options): New.
6109         (bt_flag_option_def): New.
6110         (backtrace_command_option_defs): New.
6111         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6112         (print_frame_arg, read_frame_arg, print_frame_args)
6113         (print_frame_info, print_frame): Add frame_print_options parameter
6114         and use it.
6115         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6116         (backtrace_command_1): Add frame_print_options and
6117         backtrace_cmd_options parameters and use them.
6118         (make_backtrace_options_def_group): New.
6119         (backtrace_command): Process command options with
6120         gdb::option::process_options.
6121         (backtrace_command_completer): New.
6122         (_initialize_stack): Extend "backtrace"'s help to mention
6123         supported options.  Install completer for "backtrace".
6124         Install some settings commands with add_setshow_cmds_for_options.
6125
6126 2019-06-13  Pedro Alves  <palves@redhat.com>
6127
6128         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6129         and that "set/show print raw frame-arguments" are now deprecated.
6130
6131         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6132         command.
6133         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6134         * stack.c (_initialize_stack): Install "set/show print
6135         raw-frame-arguments", and deprecate "set/show print raw
6136         frame-arguments".
6137         * valprint.c (_initialize_valprint): Deprecate "set/show print
6138         raw".
6139
6140 2019-06-13  Pedro Alves  <palves@redhat.com>
6141
6142         * compile/compile.c (struct compile_options): New.
6143         (compile_flag_option_def, compile_command_option_defs)
6144         (make_compile_options_def_group): New.
6145         (compile_file_command): Handle options with
6146         gdb::option::process_options.
6147         (compile_file_command_completer): New function.
6148         (compile_code_command): Handle options with
6149         gdb::option::process_options.
6150         (compile_code_command_completer): New function.
6151         (_initialize_compiler): Install completers for "compile code" and
6152         "compile file".  Mention available options in "compile code" and
6153         "compile code"'s help.
6154         * completer.c (advance_to_completion_word): New, factored out from
6155         ...
6156         (advance_to_expression_complete_word_point): ... this.
6157         (advance_to_filename_complete_word_point): New.
6158         * completer.h (advance_to_filename_complete_word_point): New
6159         declaration.
6160
6161 2019-06-13  Pedro Alves  <palves@redhat.com>
6162
6163         * compile/compile.c: Include "cli/cli-option.h".
6164         (compile_print_value): Scope data pointer is now a
6165         value_print_options pointer; adjust.
6166         (compile_print_command): Process options.  Scope data pointer is
6167         now a value_print_options pointer; adjust.
6168         (_initialize_compile): Update "compile print"'s help to include
6169         supported options.  Install a completer for "compile print".
6170         * cp-valprint.c (show_vtblprint, show_objectprint)
6171         (show_static_field_print): Delete.
6172         (_initialize_cp_valprint): Don't install "set print
6173         static-members", "set print vtbl", "set print object" here.
6174         * printcmd.c: Include "cli/cli-option.h" and
6175         "common/gdb_optional.h".
6176         (print_command_parse_format): Rework to fill in a
6177         value_print_options instead of a format_data.
6178         (print_value): Change parameter type from format_data pointer to
6179         value_print_options reference.  Adjust.
6180         (print_command_1): Process options.  Adjust to pass down a
6181         value_print_options.
6182         (print_command_completer): New.
6183         (_initialize_printcmd): Install print_command_completer as
6184         handle_brkchars completer for the "print" command.  Update
6185         "print"'s help to include supported options.
6186         * valprint.c: Include "cli/cli-option.h".
6187         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6188         here from cp-valprint.c.
6189         (boolean_option_def, uinteger_option_def)
6190         (value_print_option_defs, make_value_print_options_def_group):
6191         New.  Use gdb::option::add_setshow_cmds_for_options to install
6192         "set print elements", "set print null-stop", "set print repeats",
6193         "set print pretty", "set print union", "set print array", "set
6194         print address", "set print symbol", "set print array-indexes".
6195         * valprint.h: Include <string> and "cli/cli-option.h".
6196         (make_value_print_options_def_group): Declare.
6197         (print_value): Change parameter type from format_data pointer to
6198         value_print_options reference.
6199         (print_command_completer): Declare.
6200
6201 2019-06-13  Pedro Alves  <palves@redhat.com>
6202
6203         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6204         (COMMON_SFILES): Add maint-test-settings.c.
6205         * cli/cli-decode.c (boolean_enums): New global, factored out from
6206         ...
6207         (add_setshow_boolean_cmd): ... here.
6208         * cli/cli-decode.h (boolean_enums): Declare.
6209         * cli/cli-option.c: New file.
6210         * cli/cli-option.h: New file.
6211         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6212         factored out from ...
6213         (parse_cli_boolean_value(const char *)): ... this.
6214         (is_unlimited_literal): Change parameter type to pointer to
6215         pointer.  Adjust and advance ARG pointer.
6216         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6217         (parse_cli_var_enum): New, factored out from ...
6218         (do_set_command): ... this.  Adjust.
6219         * cli/cli-setshow.h (parse_cli_boolean_value)
6220         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6221         (parse_cli_var_enum): Declare.
6222         * cli/cli-utils.c: Include "cli/cli-option.h".
6223         (get_ulongest): New.
6224         * cli/cli-utils.h (get_ulongest): Declare.
6225         (check_for_argument): New overloads.
6226         * maint-test-options.c: New file.
6227
6228 2019-06-13  Pedro Alves  <palves@redhat.com>
6229
6230         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6231         parse a range if "-" is at the end of the string.
6232
6233 2019-06-13  Pedro Alves  <palves@redhat.com>
6234
6235         * cli/cli-setshow.c (parse_auto_binary_operation)
6236         (parse_cli_boolean_value): Don't allow "o".
6237
6238 2019-06-13  Pedro Alves  <palves@redhat.com>
6239
6240         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6241         * NEWS: Mention maint test-settings KIND.
6242         * maint-test-settings.c: New file.
6243
6244 2019-06-13  Pedro Alves  <palves@redhat.com>
6245
6246         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6247         completer.
6248         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6249         "set" completers.
6250
6251 2019-06-13  Pedro Alves  <palves@redhat.com>
6252
6253         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6254         after item.
6255
6256 2019-06-13  Pedro Alves  <palves@redhat.com>
6257
6258         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6259
6260 2019-06-13  Pedro Alves <palves@redhat.com>
6261
6262         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6263         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6264         call.
6265         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6266         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6267         calls.
6268         (check_for_argument): Skip spaces after argument.
6269
6270 2019-06-13  Pedro Alves  <palves@redhat.com>
6271
6272         * thread.c (thread_apply_command): Adjust TID parsing.
6273         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6274         detected before end of string.
6275         (tid_is_in_list): Error out if LIST is invalid.
6276
6277 2019-06-13  Pedro Alves  <palves@redhat.com>
6278
6279         * completer.c (complete_line_internal_1): Rewind completion word
6280         point.
6281         (completion_tracker::advance_custom_word_point_by): Change
6282         parameter type to int.
6283         * completer.h (completion_tracker::advance_custom_word_point_by):
6284         Likewise.
6285
6286 2019-06-13  Pedro Alves  <palves@redhat.com>
6287
6288         * completer.c (advance_to_completion_word): Handle delimiters.
6289
6290 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6291
6292         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6293
6294 2019-06-11  Tom Tromey  <tom@tromey.com>
6295
6296         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6297         (xmalloc_failed): Move to alloc.c.
6298         * alloc.c: New file.
6299         * Makefile.in (COMMON_SFILES): Add alloc.c.
6300
6301 2019-06-11  Tom Tromey  <tom@tromey.com>
6302
6303         * nat/linux-waitpid.c: Don't include server.h.
6304         (linux_debug): Remove.
6305         (my_waitpid): Update.
6306
6307 2019-06-11  Tom Tromey  <tromey@adacore.com>
6308
6309         * infcall.c (_initialize_infcall): Remove trailing newline from
6310         help.
6311         * user-regs.c (_initialize_user_regs): Remove trailing newline
6312         from help.
6313         * typeprint.c (_initialize_typeprint): Remove trailing newline
6314         from help.
6315         * reverse.c (_initialize_reverse): Remove trailing newlines from
6316         help.
6317         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6318         from help.
6319         * language.c (add_set_language_command): Remove trailing newline
6320         from help.
6321         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6322         help.
6323         * disasm.c (_initialize_disasm): Remove trailing newline from
6324         help.
6325         * top.c (init_main): Remove trailing newline from help.
6326         * interps.c (_initialize_interpreter): Remove trailing newline
6327         from help.
6328         * btrace.c (_initialize_btrace): Remove trailing newlines from
6329         help.
6330         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6331         from help.
6332         * python/python.c (_initialize_python): Remove trailing newline
6333         from help.
6334         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6335         help.
6336         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6337         from help.  Reformat some text.
6338         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6339         from help.
6340         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6341         newline from help.
6342
6343 2019-06-11  Tom Tromey  <tromey@adacore.com>
6344
6345         * darwin-nat.c (darwin_decode_exception_message)
6346         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6347
6348 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * valops.c (value_slice): Check for not allocated or not
6351         associated values.
6352
6353 2019-06-10  Tom de Vries  <tdevries@suse.de>
6354
6355         PR gdb/24618
6356         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6357         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6358         invalid.
6359
6360 2019-06-10  Tom de Vries  <tdevries@suse.de>
6361
6362         PR gdb/24611
6363         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6364         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6365
6366 2019-06-10  Tom de Vries  <tdevries@suse.de>
6367
6368         PR symtab/24545
6369         * symtab.c (struct demangled_name_entry): Add language field.
6370         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6371         static minimal symbol".  Set and use language field.
6372
6373 2019-06-10  Tom Tromey  <tromey@adacore.com>
6374
6375         * ada-lang.c (_initialize_ada_language): Update help text.
6376
6377 2019-06-10  Tom Tromey  <tromey@adacore.com>
6378
6379         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6380         with a newline.
6381         * guile/guile.c (handle_boot_error): Don't end warning with a
6382         newline.
6383         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6384         warning with a newline.
6385         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6386         newline.
6387         (s12z_frame_cache): Likewise.
6388         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6389         a newline.
6390         * solib-svr4.c (disable_probes_interface): Don't end warning with
6391         a newline.
6392         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6393         newline.
6394         * python/python.c (do_finish_initialization): Don't end warning
6395         with a newline.
6396
6397 2019-06-10  Tom Tromey  <tom@tromey.com>
6398
6399         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6400         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6401         gdbpy_enter.
6402
6403 2019-06-10  Tom Tromey  <tromey@adacore.com>
6404
6405         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6406         data.
6407         (elf_new_init): Don't call stabsread_new_init.
6408         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6409         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6410         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6411
6412 2019-06-10  Tom de Vries  <tdevries@suse.de>
6413
6414         PR symtab/16264
6415         PR symtab/24517
6416         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6417
6418 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6419
6420         * source.c (find_and_open_source): Also rewrite relative file
6421         names.
6422
6423 2019-04-26  Amos Bird  <amosbird@gmail.com>
6424
6425         * annotate.c (annotate_thread_exited): Add "thread-exited"
6426         annotation.
6427
6428 2019-06-06  Tom Tromey  <tromey@adacore.com>
6429
6430         * maint.h (class scoped_command_stats): Use
6431         DISABLE_COPY_AND_ASSIGN.
6432         <print_time>: New method.
6433         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6434         print_time.
6435         (scoped_command_stats::print_time): New method.
6436
6437 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6438
6439         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6440         instructions of lengths 6 or 8 bytes.
6441
6442 2019-06-04  Pedro Alves  <palves@redhat.com>
6443
6444         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6445
6446         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6447         * breakpoint.c (condition_completer): Likewise.
6448         * cli/cli-dump.c (scan_expression): Likewise.
6449         * common/filestuff.c (mkdir_recursive): Likewise.
6450         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6451         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6452         (gdb_abspath): Likewise.
6453         * compile/compile-cplus-types.c
6454         (compile_cplus_instance::decl_name): Likewise.
6455         * completer.c (complete_explicit_location):
6456         (signal_completer, reg_or_group_completer_1): Likewise.
6457         * cp-support.c (cp_remove_params_if_any): Likewise.
6458         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6459         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6460         * infcmd.c (strip_bg_char): Likewise.
6461         * linespec.c (copy_token_string): Likewise.
6462         * mi/mi-main.c (output_cores): Likewise.
6463         * psymtab.c (psymtab_search_name):
6464         * symfile.c (test_set_ext_lang_command): Likewise.
6465         * target.c (target_fileio_read_stralloc): Likewise.
6466         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6467         * value.c (complete_internalvar): Likewise.
6468
6469 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6470
6471         Add objfile property to gdb.Type.
6472         * NEWS: Mention Python API addition.
6473         * python/py-type.c (typy_get_objfile): New method.
6474
6475 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6476
6477         * NEWS: Mention the new set|show style [title|highlight].
6478         Mention changes to "show style", "help" and "apropos".
6479
6480 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6481
6482         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6483         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6484         instead of print_help_for_command.
6485         (print_doc_of_command): New function.
6486         (help_list): Add 'apropos -v word' suggestion.
6487         (print_help_for_command): Style the command name using title style.
6488         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6489         (_initialize_cli_cmds): Describe -v in apropos_command help.
6490
6491 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6492
6493         * cli/cli-style.h (cli_style_option): Add name in constructor,
6494         add m_name class member, add constructor with intensity,
6495         add name class function.
6496         (cli_style_option::add_setshow_commands): Remove name argument.
6497         (highlight_style, title_style): New styles.
6498         * cli/cli-style.c (do_show): New function that shows a style
6499         characteristic styling the style name with itself.
6500         (set_style_name): New function.
6501         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6502         Update all callers according to the changes in cli/cli-style.h.
6503         * utils.h (fputs_highlighted): New function.
6504         * utils.c (fputs_highlighted): Likewise.
6505
6506 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6507
6508         * NEWS: Mention new pipe command and new convenience variables.
6509
6510 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6511
6512         * cli/cli-cmds.c (pipe_command): New function.
6513         (_initialize_cli_cmds): Call add_com for pipe_command.
6514         Define | as an alias for pipe.
6515         (exit_status_set_internal_vars): New function.
6516         (shell_escape): Call exit_status_set_internal_vars.
6517         cli/cli-decode.c (find_command_name_length): Recognize | as
6518         a single character command.
6519
6520 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6521
6522         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6523         top.c (execute_command_to_ui_file): New function, mostly a copy
6524         of execute_command_to_string.
6525         (execute_command_to_string): Implement by calling
6526         execute_command_to_ui_file.
6527
6528 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6529
6530         * top.h (saved_command_line): Remove declaration.
6531         * top.c (previous_saved_command_line, previous_repeat_arguments):
6532         New variables.
6533         (saved_command_line): Make static, define together with other
6534         'repeat variables'.
6535         (dont_repeat): Clear repeat_arguments.
6536         (repeat_previous, get_saved_command_line, save_command_line):
6537         New functions.
6538         (gdb_init): Initialize saved_command_line
6539         and previous_saved_command_line.
6540         * main.c (captured_main_1): Remove saved_command_line initialization.
6541         * event-top.c (handle_line_of_input): Update to use
6542         the new 'repeat' related functions instead of direct access to
6543         saved_command_line.
6544         * command.h (repeat_previous, get_saved_command_line,
6545         save_command_line): New declarations.
6546         (dont_repeat): Add comment.
6547
6548 2019-05-30  Tom Tromey  <tromey@adacore.com>
6549
6550         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6551         Fix comment.
6552         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6553
6554 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6555
6556         PR cli/24587
6557         * completer.c (complete): Initialize variable word.
6558
6559 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6560
6561         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6562         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6563         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6564         'body' is NULL to the outter 'if', protecting the '!is_define'
6565         situation as well.
6566
6567 2019-05-29  Tom Tromey  <tromey@adacore.com>
6568
6569         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6570         (dwarf_unknown): New function.
6571         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6572         (dwarf_type_encoding_name): Use dwarf_unknown.
6573
6574 2019-05-29  Tom Tromey  <tromey@adacore.com>
6575
6576         PR c++/20020:
6577         * cp-valprint.c (cp_print_value_fields): Call
6578         cp_print_static_field inside "try".
6579
6580 2019-05-29  Tom Tromey  <tromey@adacore.com>
6581
6582         * inflow.c (struct terminal_info): Add default operator=.
6583         * configure: Rebuild.
6584         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6585         -Wdeprecated-copy-dtor, -Wredundant-move.
6586
6587 2019-05-29  Tom Tromey  <tromey@adacore.com>
6588
6589         * NEWS: Add entry.
6590         * infcmd.c (print_return_value_1): Handle finish_print
6591         option.
6592         (show_print_finish): New function.
6593         (_initialize_infcmd): Add "set/show print finish" commands.
6594         * valprint.c (user_print_options): Initialize new member.
6595         * valprint.h (struct value_print_options) <finish_print>: New
6596         member.
6597
6598 2019-05-28  Tom Tromey  <tromey@adacore.com>
6599
6600         * ada-lang.c (ada_remove_Xbn_suffix)
6601         (find_old_style_renaming_symbol)
6602         (parse_old_style_renaming): Remove.
6603         (ada_find_renaming_symbol): Don't call
6604         find_old_style_renaming_symbol.
6605         (ada_is_renaming_symbol): Rename from
6606         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6607         bool.  Now static.
6608         (ada_read_var_value): Update and simplify.
6609         * ada-exp.y (write_var_or_type): Remove old code.
6610
6611 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6612
6613         * event-top.c: Remove include comment.
6614         * inflow.c (class scoped_ignore_sigttou): Move from here...
6615         * inflow.h (class scoped_ignore_sigttou): ...to here.
6616         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6617         * top.c:  Remove include comment.
6618
6619 2019-05-27  Tom Tromey  <tom@tromey.com>
6620
6621         * NEWS: Fix typo.
6622
6623 2019-05-22  Tom Tromey  <tromey@adacore.com>
6624
6625         * target.c (target_follow_exec): Constify parameter.
6626         * target-delegates.c: Rebuild.
6627         * remote.c (remote_target::follow_exec): Constify parameter.
6628         * infrun.c (follow_exec): Constify parameter.
6629         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6630         (target_follow_exec): Likewise.
6631
6632 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6633
6634         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6635         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6636
6637 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6638
6639         * NEWS: Add debugredirect and testsuite sections.
6640
6641 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6642
6643         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6644         target descriptions using exclusively floating point register name
6645         aliases.
6646
6647 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         PR gdb/18644:
6650         * f-lang.c (build_fortran_types): Handle the case where
6651         gdbarch_floatformat_for_type returns a nullptr.
6652
6653 2019-05-21  Tom de Vries  <tdevries@suse.de>
6654
6655         PR cli/24587
6656         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6657
6658 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6659
6660         PR gdb/18644:
6661         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6662         16-byte floats.
6663         * i386-tdep.c (i386_floatformat_for_type): Use
6664         floatformats_ia64_quad for the 16-byte floating point component
6665         within a fortran 32-byte complex number.
6666
6667 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6670         delete default constructor.
6671         (find_partial_die): Update to return const struct.
6672         (partial_die_parent_scope): Move variable declaration into scope
6673         of its use and change its type to auto.
6674         (guess_partial_die_structure_name): Likewise.
6675         (partial_die_info::fixup): Likewise.
6676
6677 2019-05-17  Tom Tromey  <tromey@adacore.com>
6678
6679         * source.c (find_and_open_source): Remove cast.
6680
6681 2019-05-17  Tom Tromey  <tromey@adacore.com>
6682
6683         * annotate.c (annotate_source): Make "filename" const.
6684         * annotate.h (annotate_source): Use const.
6685
6686 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6687
6688         * disasm.c (set_disassembler_options): Send errors to stderr.
6689
6690 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6691
6692         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6693         (cli_interp_base::set_logging): Check debug_redirect.
6694         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6695         * cli/cli-logging.c (debug_redirect): Add static variable.
6696         (pop_output_files): Add default param.
6697         (handle_redirections): Print debug setting.
6698         (show_logging_command): Likewise.
6699         (_initialize_cli_logging): Add debugredirect command.
6700         * interps.c (current_interp_set_logging): Add debug_redirect
6701         parameter.
6702         * interps.h (set_logging): Add debug_redirect parameter.
6703         (current_interp_set_logging): Likewise.
6704         * mi/mi-common.h: Likewise.
6705         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6706
6707 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6708             Tom Tromey  <tromey@adacore.com>
6709
6710         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6711         directly.
6712         * cli/cli-interp.h (make_logging_output): Remove declaration.
6713         * cli/cli-logging.c (make_logging_output): Remove function.
6714         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6715         directly.
6716         * ui-file.c (tee_file::tee_file): Remove bools.
6717         (tee_file::~tee_file): Remove deletes.
6718         * ui-file.h (tee_file): Remove bools.
6719
6720 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6721
6722         * mi/mi-cmds.h (mi_cmd_complete): New function.
6723         * mi/mi-main.c (mi_cmd_complete): Likewise.
6724         * mi/mi-cmds.c: Define new MI command -complete.
6725         * NEWS: Mention new -complete command.
6726
6727 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6728
6729         * completer.h (complete): New function.
6730         * completer.c (complete): Likewise.
6731         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6732         function defined in completer.h.
6733
6734 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6735
6736         * MAINTAINERS (Write After Approval): Add myself.
6737
6738 2019-05-17  Tom de Vries  <tdevries@suse.de>
6739
6740         PR gdb/24094
6741         * dwarf2read.c (struct cu_partial_die_info): New struct.
6742         (find_partial_die): Return cu_partial_die_info.
6743         (partial_die_parent_scope, guess_partial_die_structure_name)
6744         (partial_die_info::fixup): Handle new return type of find_partial_die.
6745
6746 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6747
6748         PR breakpoints/24541
6749         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6750         "std::string", simplifying the algorithm.
6751
6752 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6753
6754         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6755         (stap_static_probe_ops::get_probes): Likewise.
6756
6757 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6758
6759         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6760         '-')" and "else if".
6761         (stap_parse_single_operand): Join checks for
6762         "gdbarch_stap_parse_special_token_p" and
6763         "gdbarch_stap_parse_special_token" in the same "if" statement.
6764         Invert check when verifying for operation on register
6765         displacement.
6766
6767 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6768
6769         * stap-probe.c (stap_get_opcode): Update comment.
6770         (stap_get_expected_argument_type): Likewise.
6771         (handle_stap_probe): Likewise.
6772
6773 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6774
6775         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6776         return type to 'bool'.  Adjust comment.  Use 'bool' when
6777         appropriate.
6778         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6779         * stap-probe.c (stap_parse_argument_1): Likewise.
6780         (stap_is_operator): Likewise.
6781         (stap_is_generic_prefix): Likewise.
6782         (stap_is_register_prefix): Likewise.
6783         (stap_is_register_indirection_prefix): Likewise.
6784         (stap_is_integer_prefix): Likewise.
6785         (stap_generic_check_suffix): Likewise.
6786         (stap_check_integer_suffix): Likewise.
6787         (stap_check_register_suffix): Likewise.
6788         (stap_check_register_indirection_suffix): Likewise.
6789         (stap_parse_register_operand): Likewise.
6790         (stap_parse_single_operand): Likewise.
6791         (stap_parse_argument_1): Likewise.
6792         (stap_probe::get_argument_count): Likewise.
6793         (stap_is_operator): Likewise.
6794
6795 2019-05-16  Tom Tromey  <tromey@adacore.com>
6796
6797         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6798         keyword to foreach.
6799
6800 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6801
6802         * linux-thread-db.c (try_thread_db_load_1): Change return type
6803         to bool.
6804         (try_thread_db_load): Likewise.
6805         (try_thread_db_load_from_pdir_1): Likewise.
6806         (try_thread_db_load_from_pdir): Likewise.
6807         (try_thread_db_load_from_sdir): Likewise.
6808         (try_thread_db_load_from_dir): Likewise.
6809         (thread_db_load_search): Likewise.
6810         (has_libpthread): Likewise.
6811         (thread_db_load): Likewise.
6812
6813 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6814
6815         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6816         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6817         NULL, and complain/return if that's the case.
6818
6819 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6820
6821         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6822         (advance, posn, abstract_read_memory): New functions.
6823         [struct mem_read_abstraction]: New struct.
6824         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6825
6826 2019-05-14  Tom Tromey  <tromey@adacore.com>
6827
6828         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6829         value is not lval_memory.
6830
6831 2019-05-14  Tom Tromey  <tromey@adacore.com>
6832
6833         * solib.c (info_sharedlibrary_command): Style the file name.
6834
6835 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6836
6837         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6838         (aarch64_vnv_type): Likewise.
6839         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6840         * common/tdesc.c: Likewise.
6841         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6842         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6843         * features/aarch64-fpu.xml: Add ieee half view.
6844         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6845         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6846         * gdbtypes.h (struct builtin_type): Likewise.
6847         (struct objfile_type): Likewise.
6848
6849 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6850
6851         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6852         typo.
6853         * location.h (string_to_event_location): Likewise.
6854
6855 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6856
6857         GDB 8.3 released.
6858
6859 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6860
6861         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6862         New variable declaration.
6863         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6864         New variable.
6865         (print_one_breakpoint): Use ui_out::test_flags and new global
6866         variable to compute use_fixed_output.
6867         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6868         Remove.
6869         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6870         (mi_multi_location_breakpoint_output_fixed): Remove.
6871         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6872         new variable.
6873         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6874         fix_multi_location_breakpoint_output flag if version >= 3.
6875         * ui-out.h (enum ui_out_flag)
6876         <fix_multi_location_breakpoint_output>: New enumerator.
6877
6878 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6879
6880         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6881
6882 2019-05-10  Tom Tromey  <tromey@adacore.com>
6883
6884         * ada-lang.c (catch_ada_completer): New function.
6885         (_initialize_ada_language): Use it.
6886
6887 2019-05-10  Tom Tromey  <tromey@adacore.com>
6888
6889         * thread.c (print_thread_info): Make "requested_threads" const.
6890         * gdbthread.h (print_thread_info): Make "requested_threads"
6891         const.
6892         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6893         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6894
6895 2019-05-08  Tom Tromey  <tom@tromey.com>
6896
6897         * gdbtypes.c (objfile_type_data): Change type.
6898         (objfile_type, _initialize_gdbtypes): Update.
6899
6900 2019-05-08  Tom Tromey  <tom@tromey.com>
6901
6902         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6903         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6904         (_initialize_dwarf2_frame): Update.
6905
6906 2019-05-08  Tom Tromey  <tom@tromey.com>
6907
6908         * objc-lang.c (objc_objfile_data): Change type.
6909         (find_methods): Update.
6910         (_initialize_objc_lang): Remove.
6911
6912 2019-05-08  Tom Tromey  <tom@tromey.com>
6913
6914         * stabsread.c (rs6000_builtin_type_data): Change type.
6915         (rs6000_builtin_type, _initialize_stabsread): Update.
6916
6917 2019-05-08  Tom Tromey  <tom@tromey.com>
6918
6919         * mips-tdep.c (mips_pdr_data): Remove.
6920         (_initialize_mips_tdep): Update.
6921
6922 2019-05-08  Tom Tromey  <tom@tromey.com>
6923
6924         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6925         (hppa_init_objfile_priv_data, read_unwind_info)
6926         (find_unwind_entry, _initialize_hppa_tdep): Update.
6927
6928 2019-05-08  Tom Tromey  <tom@tromey.com>
6929
6930         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6931         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6932         on obstack.
6933         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6934
6935 2019-05-08  Tom Tromey  <tom@tromey.com>
6936
6937         * mdebugread.c (basic_type_data): Change type.
6938         (basic_type, _initialize_mdebugread): Update.
6939
6940 2019-05-08  Tom Tromey  <tom@tromey.com>
6941
6942         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6943
6944 2019-05-08  Tom Tromey  <tom@tromey.com>
6945
6946         * nto-tdep.c (nto_inferior_data_reg): Change type.
6947         (nto_inferior_data): Update.
6948         (nto_inferior_data_cleanup, nto_new_inferior_data)
6949         (_initialize_nto_tdep): Remove.
6950         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6951
6952 2019-05-08  Tom Tromey  <tom@tromey.com>
6953
6954         * ada-lang.c (struct ada_inferior_data): Add initializers.
6955         (ada_inferior_data): Change type.
6956         (ada_inferior_data_cleanup): Remove.
6957         (get_ada_inferior_data, ada_inferior_exit)
6958         (struct ada_pspace_data): Add initializers, destructor.
6959         (ada_pspace_data_handle): Change type.
6960         (get_ada_pspace_data): Update.
6961         (ada_pspace_data_cleanup): Remove.
6962
6963 2019-05-08  Tom Tromey  <tom@tromey.com>
6964
6965         * coffread.c (struct coff_symfile_info): Add initializers.
6966         (coff_objfile_data_key): Move lower.  Change type.
6967         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6968         Update.
6969         (coff_free_info): Remove.
6970
6971 2019-05-08  Tom Tromey  <tom@tromey.com>
6972
6973         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6974         (fbsd_pspace_data_handle): Move lower.  Change type.
6975         (get_fbsd_pspace_data): Update.
6976         (fbsd_pspace_data_cleanup): Remove.
6977         (_initialize_fbsd_tdep): Update.
6978
6979 2019-05-08  Tom Tromey  <tom@tromey.com>
6980
6981         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6982         (get_ada_tasks_pspace_data): Update.
6983         (ada_tasks_pspace_data_cleanup): Remove.
6984         (_initialize_tasks): Update.
6985         (ada_tasks_inferior_data_handle): Change type.
6986         (get_ada_tasks_inferior_data): Update.
6987         (ada_tasks_inferior_data_cleanup): Remove.
6988         (struct ada_tasks_pspace_data): Add initializers.
6989
6990 2019-05-08  Tom Tromey  <tom@tromey.com>
6991
6992         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6993         * symfile-debug.c (debug_sym_get_probes): Change type.
6994         * stap-probe.c (handle_stap_probe):
6995         (stap_static_probe_ops::get_probes): Change type.
6996         * probe.h (class static_probe_ops) <get_probes>: Change type.
6997         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6998         (parse_probes_in_pspace): Update.
6999         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7000         Update.
7001         (any_static_probe_ops::get_probes): Change type.
7002         * elfread.c (elfread_data): New typedef.
7003         (probe_key): Change type.
7004         (elf_get_probes): Likewise.  Update.
7005         (probe_key_free): Remove.
7006         (_initialize_elfread): Update.
7007         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7008         Change type.
7009         (dtrace_process_dof_probe, dtrace_process_dof)
7010         (dtrace_static_probe_ops::get_probe): Change type.
7011
7012 2019-05-08  Tom Tromey  <tom@tromey.com>
7013
7014         * xcoffread.c (struct xcoff_symfile_info): Rename from
7015         coff_symfile_info.  Add initializers.
7016         (xcoff_objfile_data_key): Move lower.  Change type.
7017         (XCOFF_DATA): Rewrite.
7018         (xcoff_free_info): Remove.
7019         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7020         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7021         (xcoff_initial_scan): Update.
7022
7023 2019-05-08  Tom Tromey  <tom@tromey.com>
7024
7025         * solib-svr4.c (struct svr4_info): Add initializers and
7026         destructor.
7027         <probes_table>: Now an htab_up.
7028         (solib_svr4_pspace_data): Change type.
7029         (free_probes_table): Simplify.
7030         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7031         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7032         (probes_table_remove_objfile_probes, register_solib_event_probe)
7033         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7034         (_initialize_svr4_solib): Update.
7035
7036 2019-05-08  Tom Tromey  <tom@tromey.com>
7037
7038         * remote.c (remote_pspace_data): Change type.
7039         (remote_pspace_data_cleanup): Remove.
7040         (get_remote_exec_file, set_pspace_remote_exec_file)
7041         (_initialize_remote): Update.
7042
7043 2019-05-08  Tom Tromey  <tom@tromey.com>
7044
7045         * breakpoint.c (breakpoint_objfile_key): Change type.
7046         (get_breakpoint_objfile_data): Update.
7047         (free_breakpoint_objfile_data): Remove.
7048         (_initialize_breakpoint): Update.
7049
7050 2019-05-08  Tom Tromey  <tom@tromey.com>
7051
7052         * linux-tdep.c (struct linux_info): Add initializers.
7053         (linux_inferior_data): Move.  Change type.
7054         (invalidate_linux_cache_inf): Update.
7055         (linux_inferior_data_cleanup): Remove.
7056         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7057
7058 2019-05-08  Tom Tromey  <tom@tromey.com>
7059
7060         * auxv.c (auxv_inferior_data): Move.  Change type.
7061         (auxv_inferior_data_cleanup): Remove.
7062         (invalidate_auxv_cache_inf): Rewrite.
7063         (get_auxv_inferior_data, _initialize_auxv): Update.
7064
7065 2019-05-08  Tom Tromey  <tom@tromey.com>
7066
7067         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7068         (symfile_debug_objfile_data_key): Change type.
7069         (symfile_debug_installed, debug_qf_has_symbols)
7070         (debug_qf_find_last_source_symtab)
7071         (debug_qf_forget_cached_source_info)
7072         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7073         (debug_qf_print_stats, debug_qf_dump)
7074         (debug_qf_expand_symtabs_for_function)
7075         (debug_qf_expand_all_symtabs)
7076         (debug_qf_expand_symtabs_with_fullname)
7077         (debug_qf_map_matching_symbols)
7078         (debug_qf_expand_symtabs_matching)
7079         (debug_qf_find_pc_sect_compunit_symtab)
7080         (debug_qf_map_symbol_filenames)
7081         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7082         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7083         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7084         (debug_sym_read_linetable, debug_sym_relocate): Update.
7085         (symfile_debug_free_objfile): Remove.
7086         (install_symfile_debug_logging, _initialize_symfile_debug):
7087         Update.
7088
7089 2019-05-08  Tom Tromey  <tom@tromey.com>
7090
7091         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7092         allocate_on_obstack.
7093         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7094         (get_dwarf2_per_objfile): Update.
7095         (set_dwarf2_per_objfile): Remove.
7096         (dwarf2_has_info, dwarf2_get_section_info): Update.
7097         (dwarf2_free_objfile): Remove.
7098         (_initialize_dwarf2_read): Update.
7099
7100 2019-05-08  Tom Tromey  <tom@tromey.com>
7101
7102         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7103         initializers.
7104         <unsupported_script_warning_printed,
7105         script_not_found_warning_printed>: Now bool.
7106         (auto_load_pspace_data): Change type.
7107         (~auto_load_pspace_info): Rename from
7108         auto_load_pspace_data_cleanup.
7109         (get_auto_load_pspace_data, init_loaded_scripts_info)
7110         (clear_section_scripts, maybe_print_unsupported_script_warning)
7111         (maybe_print_script_not_found_warning, _initialize_auto_load):
7112         Update.
7113
7114 2019-05-08  Tom Tromey  <tom@tromey.com>
7115
7116         * objfiles.c (objfile_pspace_info): Add destructor and
7117         initializers.
7118         (objfiles_pspace_data): Change type.
7119         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7120         (get_objfile_pspace_data): Update.
7121         (objfiles_bfd_data): Change type.
7122         (get_objfile_bfd_data): Update.
7123         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7124
7125 2019-05-08  Tom Tromey  <tom@tromey.com>
7126
7127         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7128         Change type.
7129         (get_catch_syscall_inferior_data): Update.
7130         (catch_syscall_inferior_data_cleanup): Remove.
7131         (_initialize_break_catch_syscall): Update.
7132
7133 2019-05-08  Tom Tromey  <tom@tromey.com>
7134
7135         * inflow.c (struct terminal_info): Add destructor and
7136         initializers.
7137         (inflow_inferior_data): Change type.
7138         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7139         (get_inflow_inferior_data, inflow_inferior_exit)
7140         (swap_terminal_info, _initialize_inflow): Update.
7141
7142 2019-05-08  Tom Tromey  <tom@tromey.com>
7143
7144         * target-dcache.c (target_dcache_cleanup): Remove.
7145         (target_dcache_aspace_key): Change type.
7146         (target_dcache_init_p, target_dcache_invalidate)
7147         (target_dcache_get, target_dcache_get_or_init)
7148         (_initialize_target_dcache): Update.
7149         * dcache.h (struct dcache_deleter): New.
7150
7151 2019-05-08  Tom Tromey  <tom@tromey.com>
7152
7153         * symtab.c (struct symbol_cache): Add destructor and
7154         initializers.
7155         (symbol_cache_key): Move.  Change type.
7156         (make_symbol_cache, free_symbol_cache): Remove.
7157         (get_symbol_cache): Update.
7158         (symbol_cache_cleanup): Remove.
7159         (ALL_PSPACES, symbol_cache_flush)
7160         (maintenance_print_symbol_cache)
7161         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7162         Update.
7163
7164 2019-05-08  Tom Tromey  <tom@tromey.com>
7165
7166         * symtab.c (struct main_info): Add destructor and initializers.
7167         (main_progspace_key): Move.  Change type.
7168         (get_main_info): Update.
7169         (main_info_cleanup): Remove.
7170         (_initialize_symtab): Update.
7171
7172 2019-05-08  Tom Tromey  <tom@tromey.com>
7173
7174         * registry.h (DECLARE_REGISTRY): Define the _key class.
7175
7176 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7177
7178         * NEWS: Merge two 'New commands' sections.
7179
7180 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7181
7182         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7183         parameter and use Ada language definition instead.
7184         (ada_val_print_ptr): Remove unused language parameter.
7185         (ada_val_print_num): Remove language parameter and use Ada language
7186         definition instead.
7187         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7188         parameter.
7189         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7190         parameter and use Ada language definition instead.
7191         (ada_val_print_1): Update all ada_val_print_xxx calls.
7192         Remove language parameter.
7193         (ada_val_print): Update ada_val_print_1 call.
7194
7195 2019-05-08  Tom Tromey  <tromey@adacore.com>
7196
7197         * remote.c (remote_hw_watchpoint_limit)
7198         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7199         Now static.
7200
7201 2019-05-08  Tom Tromey  <tromey@adacore.com>
7202
7203         * maint.c (_initialize_maint_cmds): Move initialization code to
7204         remote.c.
7205         (watchdog, show_watchdog): Move to remote.c.
7206         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7207         "watchdog" static.
7208         (_initialize_remote): Move initialization code from maint.c.
7209         * defs.h (watchdog): Don't declare.
7210
7211 2019-05-08  Tom Tromey  <tromey@adacore.com>
7212
7213         * tui/tui-interp.c: Include main.h.
7214         * interps.c: Include main.h.
7215         * main.h (interpreter_p): Declare.
7216         * defs.h (interpreter_p): Don't declare.
7217
7218 2019-05-08  Tom Tromey  <tromey@adacore.com>
7219
7220         * dwarf2loc.c: Include dwarf2read.h.
7221         * defs.h (read_unsigned_leb128): Don't declare.
7222         * dwarf2read.h (read_unsigned_leb128): Declare.
7223
7224 2019-05-08  Tom Tromey  <tromey@adacore.com>
7225
7226         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7227         method.
7228
7229 2019-05-08  Tom Tromey  <tromey@adacore.com>
7230
7231         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7232         when no wrap column is set.
7233
7234 2019-05-08  Tom Tromey  <tromey@adacore.com>
7235
7236         * c-lang.c (c_get_string): Handle non-C-style arrays.
7237
7238 2019-05-08  Tom Tromey  <tromey@adacore.com>
7239
7240         * typeprint.c (print_offset_data::update): Print the bit offset,
7241         not the number of bits remaining.
7242
7243 2019-05-08  Tom Tromey  <tromey@adacore.com>
7244
7245         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7246         padding at end of comment.
7247
7248 2019-05-08  Tom Tromey  <tromey@adacore.com>
7249
7250         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7251         Compare main types.
7252
7253 2019-05-06  Tom Tromey  <tom@tromey.com>
7254
7255         * common/scoped_mmap.c: Include common-defs.h.
7256         * common/scoped_mmap.h: Don't include config.h.
7257
7258 2019-05-04  Tom Tromey  <tom@tromey.com>
7259
7260         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7261         (struct aarch64_call_info): Add initializers.
7262         <si>: Now a std::vector.
7263         (pass_on_stack, aarch64_push_dummy_call): Update.
7264
7265 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7266             Tom Tromey  <tom@tromey.com>
7267
7268         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7269         (ppc_threads): Now a std::vector.  Now static.
7270         (hwdebug_find_thread_points_by_tid)
7271         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7272         Update.
7273
7274 2019-05-04  Tom Tromey  <tom@tromey.com>
7275
7276         * arc-tdep.c (arc_tdesc_init): Return bool.
7277
7278 2019-05-04  Tom Tromey  <tom@tromey.com>
7279
7280         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7281         Use gdb_assert_not_reached.
7282
7283 2019-05-04  Tom Tromey  <tom@tromey.com>
7284
7285         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7286         "false".
7287
7288 2019-05-04  Tom Tromey  <tom@tromey.com>
7289
7290         * arc-tdep.c (arc_tdesc_init): Use bool.
7291
7292 2019-05-04  Tom Tromey  <tom@tromey.com>
7293
7294         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7295
7296 2019-05-04  Tom Tromey  <tom@tromey.com>
7297
7298         * cli/cli-cmds.c (valid_command_p): Return bool.
7299
7300 2019-05-04  Tom Tromey  <tom@tromey.com>
7301
7302         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7303         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7304
7305 2019-05-04  Raul Tambre  <raul@tambre.ee>
7306
7307         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7308         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7309         operator for comparison.
7310
7311 2019-05-04  Tom Tromey  <tom@tromey.com>
7312
7313         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7314         (lookup_partial_symbol, print_partial_symbols)
7315         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7316         (psymbol_compare): Update.
7317         (add_psymbol_to_bcache): Clear the entire psymbol.
7318         (maintenance_check_psymtabs): Update.
7319         * psympriv.h (struct partial_symbol): Don't derive from
7320         general_symbol_info.
7321         <obj_section, unrelocated_address, address,
7322         set_unrelocated_address>: Update.
7323         <ginfo>: New member.
7324         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7325         (debug_names::write_psymbols): Update.
7326
7327 2019-05-04  Tom de Vries  <tdevries@suse.de>
7328
7329         * contrib/cc-with-tweaks.sh: Support -n arg.
7330
7331 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7332
7333         * corelow.c (core_target::detach): Ensure frame cache and
7334         register caches are cleared.
7335         inferior.c (exit_inferior_1): Likewise.
7336
7337 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7338             Tom Tromey  <tom@tromey.com>
7339
7340         * dictionary.c (collate_pending_symbols_by_language): Remove
7341         "struct" from foreach.
7342         * symtab.c (lookup_global_symbol_from_objfile)
7343         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7344         foreach.
7345         * ser-tcp.c (net_open): Remove "struct" from foreach.
7346         * objfiles.c (objfile_relocate, objfile_rebase)
7347         (objfile_has_symbols): Remove "struct" from foreach.
7348         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7349         from foreach.
7350         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7351         foreach.
7352         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7353         "struct" from foreach.
7354         * ada-lang.c (create_excep_cond_exprs)
7355         (ada_exception_catchpoint_cond_string): Remove "struct" from
7356         foreach.
7357
7358 2019-05-03  Tom Tromey  <tromey@adacore.com>
7359
7360         * ada-exp.y (convert_char_literal): Check suffix of each
7361         enumerator.
7362
7363 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7364
7365         PR ada/21406:
7366         * ada-exp.y (yywrap): Don't define.
7367         * ada-lex.l (%option): Add noyywrap
7368         (yywrap): Remove.
7369
7370 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7371
7372         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7373         _WIN32_WINNT to the XP level, unless already defined to a higher
7374         level.
7375
7376         * unittests/parse-connection-spec-selftests.c:
7377         * ser-tcp.c:
7378         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7379         override.
7380
7381         * symfile.c (find_separate_debug_file): Remove colon from the
7382         drive spec of DOS/Windows file names of the target, so that the
7383         file name produced from DEBUGDIR and the target's directory will
7384         be valid on DOS/Windows systems.
7385
7386 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7387
7388         * rust-lang.c (val_print_struct): Handle printing structures
7389         containing strings.
7390
7391 2019-05-02  Tom Tromey  <tromey@adacore.com>
7392
7393         * valarith.c (_initialize_valarith): Remove.
7394
7395 2019-05-01  Tom Tromey  <tromey@adacore.com>
7396
7397         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7398         bitfields.
7399
7400 2019-05-01  Tom Tromey  <tromey@adacore.com>
7401
7402         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7403         for big-endian copies.
7404
7405 2019-04-30  Ali Tamur  <tamur@google.com>
7406         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7407         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7408         (read_3_bytes): New function.
7409
7410 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7411
7412         * windows-nat.c (main_thread_id): Delete.
7413         (handle_output_debug_string): Replace main_thread_id by
7414         current_event.dwThreadId.
7415         (fake_create_process): Likewise.
7416         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7417         Do not set main_thread_id.
7418         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7419         current_event.dwThreadId.
7420         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7421
7422 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7423
7424         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7425         Use current_event.dwThreadId instead of main_thread_id.
7426
7427 2019-04-30  Tom Tromey  <tromey@adacore.com>
7428
7429         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7430         (create_excep_cond_exprs): Iterate over program spaces.
7431         (ada_exception_catchpoint_cond_string): Examine all minimal
7432         symbols for exception types.
7433
7434 2019-04-30  Tom Tromey  <tromey@adacore.com>
7435
7436         PR c++/24470:
7437         * dwarf2read.c (process_structure_scope): Handle case where type
7438         has template parameters but no symbol was created.
7439
7440 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7441             Chris January  <chris.january@arm.com>
7442
7443         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7444         qualifier.
7445         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7446
7447 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * f-typeprint.c (f_print_type): Update rules for printing
7450         whitespace.
7451         (f_type_print_varspec_suffix): Likewise.
7452
7453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7454             Chris January  <chris.january@arm.com>
7455
7456         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7457         function arguments.
7458
7459 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7460
7461         * f-lang.c (build_fortran_types): Change name of void type to
7462         lower case.
7463         * f-typeprint.c (f_type_print_base): Print the name of the void
7464         type, rather than a fixed string.
7465         * f-valprint.c (f_decorations): Use lower case void string.
7466
7467 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7468             Chris January  <chris.january@arm.com>
7469
7470         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7471         types for Fortran.
7472
7473 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7474             Chris January  <chris.january@arm.com>
7475             David Lecomber  <david.lecomber@arm.com>
7476
7477         * f-exp.y (BINOP_INTRINSIC): New token.
7478         (exp): New parser rule handling BINOP_INTRINSIC.
7479         (f77_keywords): Add new builtin procedures.
7480         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7481         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7482         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7483         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7484         (print_unop_subexp_f): New function.
7485         (print_binop_subexp_f): New function.
7486         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7487         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7488         (dump_subexp_body_f): Likewise.
7489         (operator_check_f): Likewise.
7490         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7491         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7492
7493 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7494
7495         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7496         UNOP_KIND.
7497         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7498         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7499         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7500         (operator_length_f): New fuction.
7501         (print_subexp_f): New function.
7502         (op_name_f): New function.
7503         (dump_subexp_body_f): New function.
7504         (operator_check_f): New function.
7505         (exp_descriptor_f): Replace standard expression handling functions
7506         with new functions.
7507         * gdb/fortran-operator.def: New file.
7508         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7509         * gdb/std-operator.def: Remove UNOP_KIND.
7510
7511 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7512
7513         * std-operator.def: Remove unbalanced, stray double quote
7514         character.
7515
7516 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7517             Chris January  <chris.january@arm.com>
7518             Daniel Everett  <daniel.everett@arm.com>
7519             Nick Forrington  <nick.forrington@arm.com>
7520             Richard Bunt  <richard.bunt@arm.com>
7521
7522         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7523         of depth when printing anonymous structs or unions.
7524         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7525         Don't print either the top-level value, or the children if the
7526         max-depth is exceeded.
7527         (ppscm_print_children): When printing the key of a map, allow one
7528         extra level of depth.
7529         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7530         print either the top-level value, or the children if the max-depth
7531         is exceeded.
7532         (print_children): When printing the key of a map, allow one extra
7533         level of depth.
7534         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7535         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7536         (user_print_options): Initialise max_depth field.
7537         (val_print_scalar_or_string_type_p): New function.
7538         (val_print): Check to see if the max depth has been reached.
7539         (val_print_check_max_depth): Define new function.
7540         (show_print_max_depth): New function.
7541         (_initialize_valprint): Add 'print max-depth' option.
7542         * valprint.h (struct value_print_options) <max_depth>: New field.
7543         (val_print_check_max_depth): Declare new function.
7544         * NEWS: Document new feature.
7545
7546 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * ada-lang.c (ada_language_defn): Initialise new field.
7549         * c-lang.c (c_is_string_type_p): New function.
7550         (c_language_defn): Initialise new field.
7551         (cplus_language_defn): Initialise new field.
7552         (asm_language_defn): Initialise new field.
7553         (minimal_language_defn): Initialise new field.
7554         * c-lang.h (c_is_string_type_p): Declare new function.
7555         * d-lang.c (d_language_defn): Initialise new field.
7556         * f-lang.c (f_is_string_type_p): New function.
7557         (f_language_defn): Initialise new field.
7558         * go-lang.c (go_is_string_type_p): New function.
7559         (go_language_defn): Initialise new field.
7560         * language.c (default_is_string_type_p): New function.
7561         (unknown_language_defn): Initialise new field.
7562         (auto_language_defn): Initialise new field.
7563         * language.h (struct language_defn) <la_is_string_type_p>: New
7564         member variable.
7565         (default_is_string_type_p): Declare new function.
7566         * m2-lang.c (m2_language_defn): Initialise new field.
7567         * objc-lang.c (objc_language_defn): Initialise new field.
7568         * opencl-lang.c (opencl_language_defn): Initialise new field.
7569         * p-lang.c (pascal_is_string_type_p): New function.
7570         (pascal_language_defn): Initialise new field.
7571         * rust-lang.c (rust_is_string_type_p): New function.
7572         (rust_language_defn): Initialise new field.
7573
7574 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7575
7576         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7577         New field.
7578         * ada-lang.c (ada_language_defn): Initialise new field.
7579         * c-lang.c (c_language_defn): Likewise.
7580         (cplus_language_defn): Likewise.
7581         (asm_language_defn): Likewise.
7582         (minimal_language_defn): Likewise.
7583         * d-lang.c (d_language_defn): Likewise.
7584         * f-lang.c (f_language_defn): Likewise.
7585         * go-lang.c (go_language_defn): Likewise.
7586         * language.c (unknown_language_defn): Likewise.
7587         (auto_language_defn): Likewise.
7588         * m2-lang.c (m2_language_defn): Likewise.
7589         * objc-lang.c (objc_language_defn): Likewise.
7590         * opencl-lang.c (opencl_language_defn): Likewise.
7591         * p-lang.c (pascal_language_defn): Likewise.
7592         * rust-lang.c (rust_language_defn): Likewise.
7593
7594 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7595
7596         * ada-lang.c (ada_is_character_type): Change return type to bool.
7597         (ada_is_string_type): Likewise.
7598         * ada-lang.h (ada_is_character_type): Update declaration
7599         (ada_is_string_type): Likewise.
7600
7601 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7602
7603         Support style in 'frame|thread apply'
7604
7605         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7606         * record.c (record_start, record_stop): Update callers of
7607         execute_command_to_string with false.
7608         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7609         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7610         methods.
7611         (class string_file): New constructor with term_out parameter.
7612         Override methods term_out and can_emit_style_escape.  New member
7613         term_out.
7614         (class stdio_file): Override can_emit_style_escape.
7615         (class tee_file): Override term_out and can_emit_style_escape.
7616         * utils.h (can_emit_style_escape): Remove.
7617         * utils.c (can_emit_style_escape): Likewise.
7618         Update all callers of can_emit_style_escape (SOMESTREAM) to
7619         SOMESTREAM->can_emit_style_escape.
7620         * source-cache.c (source_cache::get_source_lines): Likewise.
7621         * stack.c (frame_apply_command_count): Call execute_command_to_string
7622         passing the term_out characteristic of the current gdb_stdout.
7623         * thread.c (thr_try_catch_cmd): Likewise.
7624         * top.c (execute_command_to_string): pass term_out parameter
7625         to construct the string_file for the command output.
7626         * ui-file.c (term_cli_styling): New function (most code moved
7627         from utils.c can_emit_style_escape).
7628         (string_file::string_file, string_file::can_emit_style_escape,
7629         stdio_file::can_emit_style_escape, tee_file::term_out,
7630         tee_file::can_emit_style_escape): New functions.
7631
7632 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7633
7634         * NEWS: Mention the new set|show may-call-functions.
7635         * infcall.c (may_call_functions_p): New variable.
7636         (show_may_call_functions_p): New function.
7637         (call_function_by_hand_dummy): Throws an error if not
7638         may-call-functions.
7639         (_initialize_infcall): Call add_setshow_boolean_cmd for
7640         may-call-functions.
7641
7642 2019-04-25  Keith Seitz  <keiths@redhat.com>
7643
7644         PR c++/24367
7645         * cp-support.c (inspect_type): Don't attempt substitutions
7646         of symbol with the same name.
7647
7648 2019-04-25  Tom Tromey  <tromey@adacore.com>
7649
7650         PR gdb/24475:
7651         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7652         static.
7653
7654 2019-04-25  Tom Tromey  <tromey@adacore.com>
7655
7656         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7657         rvalue reference.
7658         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7659         (gdb_xml_parser::parse): Use std::move.
7660         * python/python-internal.h (gdbpy_convert_exception): Take a const
7661         reference.
7662         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7663         std::move.
7664         * python/py-utils.c (gdbpy_convert_exception): Take a const
7665         reference.
7666         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7667         Use std::move.
7668         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7669         Use std::move.
7670         * mi/mi-main.c (mi_print_exception): Take a const reference.
7671         * main.c (handle_command_errors): Take a const reference.
7672         * linespec.c (parse_linespec): Use std::move.
7673         * infcall.c (run_inferior_call): Use std::move.
7674         (call_function_by_hand_dummy): Use std::move.
7675         * exec.c (try_open_exec_file): Use std::move.
7676         * exceptions.h (exception_print, exception_fprintf)
7677         (exception_print_same): Update.
7678         * exceptions.c (print_exception, exception_print)
7679         (exception_fprintf, exception_print_same): Change parameters to
7680         const reference.
7681         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7682         * common/new-op.c: Use std::move.
7683         * common/common-exceptions.h (struct gdb_exception): Add move
7684         constructor.
7685         (struct gdb_exception_error, struct gdb_exception_quit, struct
7686         gdb_quit_bad_alloc): Change constructor to move constructor.
7687         (throw_exception): Change parameter to rvalue reference.
7688         * common/common-exceptions.c (throw_exception): Take rvalue
7689         reference.
7690         * cli/cli-interp.c (safe_execute_command): Use std::move.
7691         * breakpoint.c (insert_bp_location, location_to_sals): Use
7692         std::move.
7693
7694 2019-04-25  Tom Tromey  <tromey@adacore.com>
7695
7696         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7697         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7698         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7699         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7700         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7701         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7702         guile/scm-value.c: Use unpack.
7703         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7704         gdbscm_gdb_exception.
7705         (gdbscm_throw_gdb_exception): Likewise.
7706         (struct gdbscm_gdb_exception): New.
7707         (unpack): New function.
7708         (gdbscm_wrap): Use unpack.
7709
7710 2019-04-25  Tom Tromey  <tromey@adacore.com>
7711
7712         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7713         (gdb_rl_callback_handler): Use std::move.
7714         * common/common-exceptions.h (struct gdb_exception): Add move
7715         assignment operator.
7716         (throw_exception_sjlj): Change "exception" to const reference.
7717         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7718         (throw_exception_sjlj): Change "exception" to const reference.
7719
7720 2019-04-25  Tom Tromey  <tromey@adacore.com>
7721
7722         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7723         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7724         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7725         Update.
7726         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7727         Update.
7728         * mi/mi-interp.c (mi_interp::exec): Update.
7729         * linespec.c (parse_linespec): Update.
7730         * infcall.c (run_inferior_call): Update.
7731         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7732         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7733         (gdbscm_lookup_global_symbol): Update.
7734         * guile/scm-param.c (gdbscm_parameter_value): Update.
7735         * guile/scm-frame.c (gdbscm_frame_read_register)
7736         (gdbscm_frame_read_var): Update.
7737         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7738         * exec.c (try_open_exec_file): Update.
7739         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7740         (gdb_rl_callback_handler): Update.
7741         * common/common-exceptions.h (exception_none): Don't declare.
7742         * common/common-exceptions.c (exception_none): Don't define.
7743         (struct catcher) <exception>: Update.
7744         * cli/cli-interp.c (safe_execute_command): Update.
7745         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7746
7747 2019-04-25  Ali Tamur  <tamur@google.com>
7748
7749         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7750         (read_attribute_value): Likewise.
7751         (dwarf2_read_addr_index): Update comment.
7752         (read_str_index): Add DW_FORM_strx.
7753         (dwarf2_string_attr): Likewise.
7754         (dwarf2_const_value_attr): Likewise.
7755         (dump_die_shallow): Likewise.
7756         (dwarf2_fetch_constant_bytes): Likewise.
7757         (skip_form_bytes): Likewise.
7758         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7759
7760 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7761
7762         PR corefiles/11608
7763         PR corefiles/18187
7764         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7765         OFFSET.  Verify if current mapping contains an ELF header.
7766         (linux_find_memory_regions_full): Adjust call to
7767         dump_mapping_p.
7768
7769 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7770             Kang Li <kanglictf@gmail.com>
7771
7772         PR gdb/21600
7773
7774         * dwarf2-frame.c (read_initial_length): Be consistent about using
7775         unsigned representation of length.
7776         (decode_frame_entry_1): Likewise.  Check for wraparound of
7777         end pointer as well as buffer overflow.
7778
7779 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7780
7781         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7782         "vq".
7783
7784 2019-04-24  Tom Tromey  <tromey@adacore.com>
7785
7786         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7787
7788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7789
7790         * s12z-tdep.c (s12z_unwind_pc): Delete.
7791         (s12z_unwind_sp): Delete.
7792         (s12z_gdbarch_init): Don't register deleted functions with
7793         gdbarch.
7794
7795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * rl78-tdep.c (rl78_unwind_sp): Delete.
7798         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7799
7800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7803         (xstormy16_unwind_pc): Delete.
7804         (xstormy16_dummy_id): Delete.
7805         (xstormy16_gdbarch_init): Don't register deleted functions with
7806         gdbarch.
7807
7808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * vax-tdep.c (vax_unwind_pc): Delete.
7811         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7812
7813 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7814
7815         * v850-tdep.c (v850_unwind_sp): Delete.
7816         (v850_unwind_pc): Delete.
7817         (v850_dummy_id): Delete.
7818         (v850_gdbarch_init): Don't register deleted functions with
7819         gdbarch.
7820
7821 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7822
7823         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7824         (tilegx_unwind_pc): Delete.
7825         (tilegx_unwind_dummy_id): Delete.
7826         (tilegx_gdbarch_init): Don't register deleted functions with
7827         gdbarch.
7828
7829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7832         (tic6x_dummy_id): Delete.
7833         (tic6x_gdbarch_init): Don't register deleted functions with
7834         gdbarch.
7835
7836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7837
7838         * sparc-tdep.c (sparc_unwind_pc): Delete.
7839         (sparc32_gdbarch_init): Don't register deleted function with
7840         gdbarch.
7841
7842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * sh-tdep.c (sh_unwind_sp): Delete.
7845         (sh_unwind_pc): Delete.
7846         (sh_dummy_id): Delete.
7847         (sh_gdbarch_init): Don't register deleted functions with
7848         gdbarch.
7849
7850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7851
7852         * score-tdep.c (score_unwind_sp): Delete.
7853         (score_unwind_pc): Delete.
7854         (score_dummy_id): Delete.
7855         (score_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * rx-tdep.c (rx_unwind_pc): Delete.
7861         (rx_unwind_sp): Delete.
7862         (rx_dummy_id): Delete.
7863         (rx_gdbarch_init): Don't register deleted functions with
7864         gdbarch.  Update comment.
7865
7866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7869         (rs6000_dummy_id): Delete.
7870         (rs6000_gdbarch_init): Don't register deleted functions with
7871         gdbarch.
7872
7873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * or1k-tdep.c (or1k_dummy_id): Delete.
7876         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7877
7878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7879
7880         * nios2-tdep.c (nios2_dummy_id): Delete.
7881         (nios2_unwind_sp): Delete.
7882         (nios2_gdbarch_init): Don't register deleted functions with
7883         gdbarch.
7884
7885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7886
7887         * nds32-tdep.c (nds32_dummy_id): Delete.
7888         (nds32_unwind_pc): Delete.
7889         (nds32_unwind_sp): Delete.
7890         (nds32_gdbarch_init): Don't register deleted functions with
7891         gdbarch.
7892
7893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * msp430-tdep.c (msp430_unwind_pc): Delete.
7896         (msp430_unwind_sp): Delete.
7897         (msp430_dummy_id): Delete.
7898         (msp430_gdbarch_init): Don't register deleted functions with
7899         gdbarch.
7900
7901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7902
7903         * moxie-tdep.c (moxie_unwind_sp): Delete.
7904         (moxie_unwind_pc): Delete.
7905         (moxie_dummy_id): Delete.
7906         (moxie_gdbarch_init): Don't register deleted functions with
7907         gdbarch.
7908
7909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7912         (mn10300_unwind_pc): Delete.
7913         (mn10300_unwind_sp): Delete.
7914         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7915         mn10300_unwind_sp.
7916         (mn10300_frame_unwind_init): Don't register deleted functions with
7917         gdbarch.
7918
7919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * mep-tdep.c (mep_unwind_pc): Delete.
7922         (mep_unwind_sp): Delete.
7923         (mep_dummy_id): Delete.
7924         (mep_gdbarch_init): Don't register deleted functions with
7925         gdbarch.
7926
7927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7930         (m68hc11_unwind_sp): Delete.
7931         (m68hc11_gdbarch_init): Don't register deleted functions with
7932         gdbarch.
7933
7934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7935
7936         * m32r-tdep.c (m32r_unwind_sp): Delete.
7937         (m32r_unwind_pc): Delete.
7938         (m32r_dummy_id): Delete.
7939         (m32r_gdbarch_init): Don't register deleted functions with
7940         gdbarch.
7941
7942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7943
7944         * m32c-tdep.c (m32c_unwind_pc): Delete.
7945         (m32c_unwind_sp): Delete.
7946         (m32c_dummy_id): Delete.
7947         (m32c_gdbarch_init): Don't register deleted functions with
7948         gdbarch.
7949
7950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7953         (lm32_unwind_pc): Delete.
7954         (lm32_dummy_id): Delete.
7955         (lm32_gdbarch_init): Don't register deleted functions with
7956         gdbarch.
7957
7958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7959
7960         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7961         (iq2000_unwind_pc): Delete.
7962         (iq2000_dummy_id): Delete.
7963         (iq2000_gdbarch_init): Don't register deleted functions with
7964         gdbarch.
7965
7966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7967
7968         * nds32-tdep.c (nds32_type_align): Delete.
7969         (nds32_push_dummy_call): Use type_align instead.
7970
7971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * arm-tdep.c (arm_type_align): Only handle vector override case.
7974         (arm_push_dummy_call): Use type_align.
7975         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7976
7977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7978
7979         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7980         case.
7981         (pass_on_stack): Use type_align.
7982         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7983         function.
7984
7985 2019-04-23  Tom Tromey  <tromey@adacore.com>
7986
7987         * dwarf2read.c (line_header::file_name_at): Remove unused
7988         overload.
7989
7990 2019-04-23  Tom de Vries  <tdevries@suse.de>
7991
7992         PR gdb/24438
7993         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7994         invocation.
7995
7996
7997 2019-03-27  Ali Tamur  <tamur@google.com>
7998
7999         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8000         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8001         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8002         (dwarf_expr_context::get_addr_index): Likewise
8003         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8004         (symbol_needs_eval_context::get_addr_index): Likewise
8005         (disassemble_dwarf_expression): Add DW_OP_addrx
8006         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8007         (read_cutu_die_from_dwo): Update comment
8008         (skip_one_die): Add DW_FORM_addrx
8009         (read_attribute_value): Likewise
8010         (var_decode_location): Add DW_OP_addrx
8011         (dwarf2_const_value_attr): Add DW_FORM_addrx
8012         (dump_die_shallow): Likewise
8013         (dwarf2_fetch_constant_bytes): Likewise
8014         (decode_locdesc): Add DW_OP_addrx
8015         (skip_form_bytes): Add DW_FORM_addrx
8016
8017 2019-04-22  Ali Tamur  <tamur@google.com>
8018
8019         * MAINTAINERS (Write After Approval): Add self.
8020
8021 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8022
8023         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8024         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8025         (open_symbol_file_object): Likewise.
8026         (svr4_default_sos): Add info parameter.
8027         (svr4_read_so_list): Likewise.
8028         (svr4_current_sos_direct): Adjust functions calls to pass down
8029         info.
8030         (svr4_current_sos_1): Add info parameter.
8031         (svr4_current_sos): Call get_svr4_info, pass info down to
8032         svr4_current_sos_1.
8033         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8034         get_svr4_info.
8035         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8036         get_svr4_info.
8037         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8038         to get_svr4_info.
8039         (probes_table_remove_objfile_probes): Likewise.
8040         (register_solib_event_probe): Add info parameter.
8041         (solist_update_incremental): Pass info parameter down to
8042         svr4_read_so_list.
8043         (disable_probes_interface): Add info parameter.
8044         (svr4_handle_solib_event): Pass current_program_space to
8045         get_svr4_info.  Adjust disable_probes_interface cleanup.
8046         (svr4_create_probe_breakpoints): Add info parameter, pass it
8047         down to register_solib_event_probe.
8048         (svr4_create_solib_event_breakpoints): Add info parameter,
8049         pass it down to svr4_create_probe_breakpoints.
8050         (enable_break): Pass info down to
8051         svr4_create_solib_event_breakpoints.
8052         (svr4_solib_create_inferior_hook): Pass current_program_space to
8053         get_svr4_info.
8054         (svr4_clear_solib): Likewise.
8055
8056 2019-04-22  Pedro Alves  <palves@redhat.com>
8057
8058         * solib-svr4.c (svr4_free_objfile_observer): New.
8059         (probe_and_action::objfile): New field.
8060         (probes_table_htab_remove_objfile_probes)
8061         (probes_table_remove_objfile_probes): New functions.
8062         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8063         in the new probe_and_action.  Don't store the probe in 'lookup'.
8064         (svr4_create_probe_breakpoints): Pass objfile to
8065         register_solib_event_probe.
8066         (_initialize_svr4_solib): Register a free_objfile observer.
8067
8068 2019-04-19  Tom Tromey  <tom@tromey.com>
8069
8070         * common/queue.h: Remove.
8071
8072 2019-04-19  Tom Tromey  <tom@tromey.com>
8073
8074         * event-loop.c: Don't include "common/queue.h".
8075
8076 2019-04-19  Tom Tromey  <tom@tromey.com>
8077
8078         * remote.c (remote_target): Use delete.
8079         * remote-notif.h: Include <list>, not "common/queue.h".
8080         (notif_client_p): Remove typedef.
8081         (remote_notif_state): Add constructor, destructor, initializer.
8082         <notif_queue>: Now a std::list.
8083         (remote_notif_state_xfree): Don't declare.
8084         * remote-notif.c (remote_notif_process, handle_notification)
8085         (remote_notif_state_allocate): Update.
8086         (~remote_notif_state): Rename from remote_notif_state_xfree.
8087
8088 2019-04-19  Tom Tromey  <tom@tromey.com>
8089
8090         * symfile.c (reread_symbols): Update.
8091         * objfiles.c (objfile_register_static_link)
8092         (objfile_lookup_static_link): Update
8093         (~objfile) Don't delete static_links.
8094         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8095
8096 2019-04-19  Tom Tromey  <tom@tromey.com>
8097
8098         * type-stack.h (struct type_stack) <insert>: Constify string.
8099         * type-stack.c (type_stack::insert): Constify string.
8100         * gdbtypes.h (lookup_template_type): Update.
8101         (address_space_name_to_int): Update.
8102         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8103         const.
8104         (lookup_template_type): Make name const.
8105         * c-exp.y: Update rules.
8106         (lex_one_token, classify_name, classify_inner_name)
8107         (c_print_token): Update.
8108         * p-exp.y: Update rules.
8109         (yylex): Update.
8110         * f-exp.y: Update rules.
8111         (yylex): Update.
8112         * d-exp.y: Update rules.
8113         (lex_one_token, classify_name, classify_inner_name): Update.
8114         * parse.c (write_dollar_variable, copy_name): Return std::string.
8115         * parser-defs.h (copy_name): Change return type.
8116         * m2-exp.y: Update rules.
8117         (yylex): Update.
8118         * go-exp.y (lex_one_token): Update.
8119         Update rules.
8120         (classify_unsafe_function, classify_packaged_name)
8121         (classify_name, yylex): Update.
8122
8123 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8124
8125         * configure.ac: add --enable-source-highlight switch.
8126         * configure: Regenerate.
8127         * top.c (print_gdb_version): plumb --enable-source-highlight
8128         status to "show configuration".
8129
8130 2019-04-19  Tom Tromey  <tromey@adacore.com>
8131
8132         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8133         Check ADA_TYPE_P.
8134         (empty_record, ada_template_to_fixed_record_type_1)
8135         (template_to_static_fixed_type)
8136         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8137         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8138         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8139         macros.
8140
8141 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8142
8143         PR symtab/24423:
8144         * source.c (print_source_lines_base): Advance "iter" when a
8145         control character is seen.
8146
8147 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8148
8149         * inferior.h (struct infcall_suspend_state_deleter):
8150         Catch exception in destructor to avoid crash.
8151
8152 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8153
8154         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8155         close to the add_com "shell".
8156
8157 2019-04-18  Tom Tromey  <tromey@adacore.com>
8158
8159         * process-stratum-target.h (class process_stratum_target)
8160         <stratum>: Add "final".
8161
8162 2019-04-17  Tom Tromey  <tromey@adacore.com>
8163
8164         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8165         against nullptr before use.
8166
8167 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8168
8169         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8170
8171 2019-04-17  Jim Wilson  <jimw@sifive.com>
8172             Andrew Burgess  <andrew.burgess@embecosm.com>
8173
8174         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8175         code read might fail, assume 4-byte breakpoint in that case.
8176
8177 2019-04-15  Leszek Swirski  <leszeks@google.com>
8178
8179         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8180         rather than a hand-rolled POD check when checking for forced MEMORY
8181         classification.
8182
8183 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8184
8185         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8186         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8187         function.
8188         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8189         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8190         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8191         declaration.
8192
8193 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8194
8195         * aarch64-linux-nat.c
8196         (aarch64_linux_nat_target::thread_architecture): Add override.
8197         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8198         each VQ.
8199
8200 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8201
8202         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8203
8204 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8205
8206         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8207         target types of size 96-bits, add some additional comments, and
8208         check that the builtin type we found was the correct size.
8209
8210 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8211
8212         * utils.c (prompt_for_continue): Don't restore the styling at the
8213         end, as applied_style has the wrong value.  This fixes styling in
8214         long lists of file names that are interrupted by the "Continue?"
8215         prompt.
8216
8217 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8220         * c-lang.c (c_language_defn): Likewise.
8221         (cplus_language_defn): Likewise.
8222         (asm_language_defn): Likewise.
8223         (minimal_language_defn): Likewise.
8224         * d-lang.c (d_language_defn): Likewise.
8225         * f-lang.c (f_language_defn): Likewise.
8226         * go-lang.c (go_language_defn): Likewise.
8227         * language.c (unknown_language_defn): Likewise.
8228         (auto_language_defn): Likewise.
8229         * language.h (struct language_defn): Remove la_magic field.
8230         (LANG_MAGIC): Delete.
8231         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8232         * objc-lang.c (objc_language_defn): Likewise.
8233         * opencl-lang.c (opencl_language_defn): Likewise.
8234         * p-lang.c (pascal_language_defn): Likewise.
8235         * rust-lang.c (rust_language_defn): Likewise.
8236
8237 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8238
8239         * riscv-tdep.c (riscv_type_align): New function.
8240         (riscv_type_alignment): Delete.
8241         (riscv_arg_location): Use 'type_align'.
8242         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8243
8244 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8245
8246         * gdbtypes.c (type_align): A struct with no non-static fields also
8247         has alignment of 1.
8248
8249 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8250
8251         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8252         component to 0.
8253         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8254         member.
8255         (riscv_struct_info::analyse): New implementation using new
8256         analyse_inner member function.
8257         (riscv_struct_info::field_offset): New member function.
8258         (riscv_struct_info::m_offsets): New member variable.
8259         (riscv_struct_info::analyse_inner): New private member function,
8260         takes the old implementation of riscv_struct_info::analyse but
8261         extended to track field offsets.
8262         (riscv_call_arg_struct): Update the struct folding special cases
8263         to handle cases where empty C++ structs, which are non-zero
8264         length, are found.
8265         (riscv_arg_location): Initialise the length of each location, a
8266         non-zero length now indicates the location is in use.
8267         (riscv_push_dummy_call): Allow for the first location having a
8268         non-zero offset when setting up arguments.
8269         (riscv_return_value): Likewise, but for return values.
8270
8271 2019-04-11  Tom Tromey  <tromey@adacore.com>
8272
8273         * utils.c (internal_vproblem): Make "msg" const.
8274
8275 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8276
8277         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8278         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8279         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8280         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8281
8282 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8283
8284         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8285         function.
8286         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8287         of amd64_collect_native_gregset.
8288         (amd64_linux_nat_target::store_registers): Likewise.
8289
8290 2019-04-10  Tom Tromey  <tom@tromey.com>
8291
8292         * symtab.c (lookup_global_symbol_from_objfile)
8293         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8294         * objfiles.h (class separate_debug_iterator): New.
8295         (class separate_debug_range): New.
8296         (struct objfile) <separate_debug_objfiles>: New method.
8297         (objfile_separate_debug_iterate): Don't declare.
8298         * objfiles.c (separate_debug_iterator::operator++): Rename from
8299         objfile_separate_debug_iterate.
8300         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8301         iterator.
8302         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8303         iterator.
8304
8305 2019-04-10  Tom Tromey  <tom@tromey.com>
8306
8307         * symfile.c (reread_symbols): Remove old comment.
8308         * objfiles.c (free_all_objfiles): Fix a typo.
8309
8310 2019-04-10  Tom Tromey  <tom@tromey.com>
8311
8312         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8313         * minsyms.c (lookup_minimal_symbol): Use foreach.
8314         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8315         (lookup_minimal_symbol_solib_trampoline): Likewise.
8316         * symfile.c (reread_symbols): Use foreach.
8317
8318 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8319             Tom Tromey  <tromey@adacore.com>
8320
8321         PR rust/24414:
8322         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8323         (rust_lex_int_test): Change "value" to be LONGEST.
8324         (rust_lex_tests): Add test for long integer literal.
8325
8326 2019-04-09  Tom Tromey  <tromey@adacore.com>
8327
8328         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8329         to bool.
8330         (extended_remote_target::attach): Update.
8331         (remote_target::remote_notice_new_inferior): Update.
8332         (remote_target::add_current_inferior_and_thread): Update.
8333         * inferior.c (exit_inferior_1): Use "false".
8334         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8335
8336 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8337
8338         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8339         the "start" command.
8340
8341 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8342
8343         * python/py-inferior.c (infpy_thread_from_thread_handle):
8344         Adjust comments to reflect renaming of thread_from_thread_handle
8345         to thread_from_handle.  Adjust keywords.  Fix type error message.
8346         (inferior_object_methods): Add thread_from_handle.  Retain
8347         thread_from_thread_handle, but mark it as deprecated.
8348
8349 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8350
8351         * gdbthread.h (find_thread_by_handle): Revise declaration.
8352         * thread.c (find_thread_by_handle): Likewise.  Adjust
8353         implementation too.
8354         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8355         support for buffer objects as handles.
8356
8357 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8358
8359         * python/py-infthread.c (thpy_thread_handle): New function.
8360         (thread_object_methods): Register thpy_thread_handle.
8361
8362 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8363
8364         * gdbthread.h (thread_to_thread_handle): Declare.
8365         * thread.c (gdbtypes.h): Include.
8366         (thread_to_thread_handle): New function.
8367
8368         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8369         (target_thread_info_to_thread_handle): Declare.
8370         * target.c (target_thread_info_to_thread_handle): New function.
8371         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8372         * target-delegates.c: Regenerate.
8373
8374         * linux-thread-db.c (class thread_db_target): Add method
8375         thread_info_to_thread_handle.
8376         (thread_db_target::thread_info_to_thread_handle): Define.
8377         * remote.c (class remote_target): Add new method
8378         thread_info_to_thread_handle.
8379         (remote_target::thread_info_to_thread_handle): Define.
8380
8381 2019-04-08  Pedro Alves  <palves@redhat.com>
8382
8383         * common/common-exceptions.c (throw_exception): Don't create
8384         named object to throw; throw directly.
8385         (throw_it): Likewise.  Don't initialize gdb_exception::message
8386         here, with new; pass FMT and AP to the ctor instead.
8387         * common/common-exceptions.h: Include <string>.
8388         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8389         const char *, va_list)): New ctor.  Use std::make_shared.
8390         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8391         errors)): Delete.
8392         (gdb_exception_error::gdb_exception_error(enum errors, const char
8393         *, va_list)): New.
8394         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8395         Add assertion.
8396         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8397         errors)): Delete.
8398         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8399         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8400         Add assertion.
8401
8402 2019-04-08  Tom Tromey  <tom@tromey.com>
8403
8404         * valops.c (value_rtti_indirect_type): Replace throw_exception
8405         with throw.
8406         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8407         with throw.
8408         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8409         throw.
8410         * target.c (target_translate_tls_address): Replace throw_exception
8411         with throw.
8412         * stack.c (frame_apply_command_count): Replace throw_exception
8413         with throw.
8414         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8415         throw.
8416         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8417         with throw.
8418         * rs6000-tdep.c (rs6000_frame_cache)
8419         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8420         * remote.c: Replace throw_exception with throw.
8421         * record-full.c (record_full_message, record_full_wait_1)
8422         (record_full_restore): Replace throw_exception with throw.
8423         * record-btrace.c:
8424         (get_thread_current_frame_id, record_btrace_start_replaying)
8425         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8426         (cmd_record_btrace_start): Replace throw_exception with throw.
8427         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8428         throw.
8429         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8430         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8431         * linespec.c:
8432         (find_linespec_symbols): Replace throw_exception with throw.
8433         * infrun.c (displaced_step_prepare, resume): Replace
8434         throw_exception with throw.
8435         * infcmd.c (post_create_inferior): Replace throw_exception with
8436         throw.
8437         * inf-loop.c (inferior_event_handler): Replace throw_exception
8438         with throw.
8439         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8440         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8441         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8442         (get_prev_frame_always, get_frame_pc_if_available)
8443         (get_frame_address_in_block_if_available, get_frame_language):
8444         Replace throw_exception with throw.
8445         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8446         throw_exception with throw.
8447         * eval.c (fetch_subexp_value, evaluate_var_value)
8448         (evaluate_funcall, evaluate_subexp_standard): Replace
8449         throw_exception with throw.
8450         * dwarf2loc.c (call_site_find_chain)
8451         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8452         Replace throw_exception with throw.
8453         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8454         with throw.
8455         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8456         throw.
8457         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8458         * completer.c (complete_line_internal): Replace throw_exception
8459         with throw.
8460         * compile/compile-object-run.c (compile_object_run): Replace
8461         throw_exception with throw.
8462         * cli/cli-script.c (process_next_line): Replace throw_exception
8463         with throw.
8464         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8465         (btrace_enable, btrace_maint_update_pt_packets): Replace
8466         throw_exception with throw.
8467         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8468         throw_exception with throw.
8469         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8470         throw_exception with throw.
8471         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8472         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8473         * aarch64-tdep.c (aarch64_make_prologue_cache)
8474         (aarch64_make_stub_cache): Replace throw_exception with throw.
8475
8476 2019-04-08  Tom Tromey  <tom@tromey.com>
8477
8478         * common/common-exceptions.c (throw_exception): Rename from
8479         throw_exception_cxx.  Remove old copy.  Make argument const.
8480         (throw_it): Create and throw exception objects directly.
8481         * common/common-exceptions.h (throw_exception): Make argument
8482         const.
8483         (struct gdb_exception_error): Add constructor.
8484         (struct gdb_exception_quit): Add constructor.
8485
8486 2019-04-08  Tom Tromey  <tom@tromey.com>
8487
8488         * common/common-exceptions.h (exception_rethrow): Don't declare.
8489         (TRY_SJLJ): Update comment.
8490         (TRY, CATCH, END_CATCH): Remove.
8491         * common/common-exceptions.c (exception_rethrow): Remove.
8492
8493 2019-04-08  Tom Tromey  <tom@tromey.com>
8494
8495         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8496         Remove.
8497         (gdb_exception_error): Rename from
8498         gdb_exception_RETURN_MASK_ERROR.
8499         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8500         (gdb_quit_bad_alloc): Update.
8501         * aarch64-tdep.c: Update.
8502         * ada-lang.c: Update.
8503         * ada-typeprint.c: Update.
8504         * ada-valprint.c: Update.
8505         * amd64-tdep.c: Update.
8506         * arch-utils.c: Update.
8507         * break-catch-throw.c: Update.
8508         * breakpoint.c: Update.
8509         * btrace.c: Update.
8510         * c-varobj.c: Update.
8511         * cli/cli-cmds.c: Update.
8512         * cli/cli-interp.c: Update.
8513         * cli/cli-script.c: Update.
8514         * common/common-exceptions.c: Update.
8515         * common/new-op.c: Update.
8516         * common/selftest.c: Update.
8517         * compile/compile-c-symbols.c: Update.
8518         * compile/compile-cplus-symbols.c: Update.
8519         * compile/compile-object-load.c: Update.
8520         * compile/compile-object-run.c: Update.
8521         * completer.c: Update.
8522         * corelow.c: Update.
8523         * cp-abi.c: Update.
8524         * cp-support.c: Update.
8525         * cp-valprint.c: Update.
8526         * darwin-nat.c: Update.
8527         * disasm-selftests.c: Update.
8528         * dtrace-probe.c: Update.
8529         * dwarf-index-cache.c: Update.
8530         * dwarf-index-write.c: Update.
8531         * dwarf2-frame-tailcall.c: Update.
8532         * dwarf2-frame.c: Update.
8533         * dwarf2loc.c: Update.
8534         * dwarf2read.c: Update.
8535         * eval.c: Update.
8536         * event-loop.c: Update.
8537         * event-top.c: Update.
8538         * exec.c: Update.
8539         * f-valprint.c: Update.
8540         * fbsd-tdep.c: Update.
8541         * frame-unwind.c: Update.
8542         * frame.c: Update.
8543         * gdbtypes.c: Update.
8544         * gnu-v3-abi.c: Update.
8545         * guile/guile-internal.h: Update.
8546         * guile/scm-block.c: Update.
8547         * guile/scm-breakpoint.c: Update.
8548         * guile/scm-cmd.c: Update.
8549         * guile/scm-disasm.c: Update.
8550         * guile/scm-frame.c: Update.
8551         * guile/scm-lazy-string.c: Update.
8552         * guile/scm-math.c: Update.
8553         * guile/scm-param.c: Update.
8554         * guile/scm-ports.c: Update.
8555         * guile/scm-pretty-print.c: Update.
8556         * guile/scm-symbol.c: Update.
8557         * guile/scm-symtab.c: Update.
8558         * guile/scm-type.c: Update.
8559         * guile/scm-value.c: Update.
8560         * i386-linux-tdep.c: Update.
8561         * i386-tdep.c: Update.
8562         * inf-loop.c: Update.
8563         * infcall.c: Update.
8564         * infcmd.c: Update.
8565         * infrun.c: Update.
8566         * jit.c: Update.
8567         * language.c: Update.
8568         * linespec.c: Update.
8569         * linux-fork.c: Update.
8570         * linux-nat.c: Update.
8571         * linux-tdep.c: Update.
8572         * linux-thread-db.c: Update.
8573         * main.c: Update.
8574         * mi/mi-cmd-break.c: Update.
8575         * mi/mi-cmd-stack.c: Update.
8576         * mi/mi-interp.c: Update.
8577         * mi/mi-main.c: Update.
8578         * objc-lang.c: Update.
8579         * p-valprint.c: Update.
8580         * parse.c: Update.
8581         * ppc-linux-tdep.c: Update.
8582         * printcmd.c: Update.
8583         * python/py-arch.c: Update.
8584         * python/py-breakpoint.c: Update.
8585         * python/py-cmd.c: Update.
8586         * python/py-finishbreakpoint.c: Update.
8587         * python/py-frame.c: Update.
8588         * python/py-framefilter.c: Update.
8589         * python/py-gdb-readline.c: Update.
8590         * python/py-inferior.c: Update.
8591         * python/py-infthread.c: Update.
8592         * python/py-lazy-string.c: Update.
8593         * python/py-linetable.c: Update.
8594         * python/py-objfile.c: Update.
8595         * python/py-param.c: Update.
8596         * python/py-prettyprint.c: Update.
8597         * python/py-progspace.c: Update.
8598         * python/py-record-btrace.c: Update.
8599         * python/py-record.c: Update.
8600         * python/py-symbol.c: Update.
8601         * python/py-type.c: Update.
8602         * python/py-unwind.c: Update.
8603         * python/py-utils.c: Update.
8604         * python/py-value.c: Update.
8605         * python/python.c: Update.
8606         * record-btrace.c: Update.
8607         * record-full.c: Update.
8608         * remote-fileio.c: Update.
8609         * remote.c: Update.
8610         * riscv-tdep.c: Update.
8611         * rs6000-aix-tdep.c: Update.
8612         * rs6000-tdep.c: Update.
8613         * rust-exp.y: Update.
8614         * rust-lang.c: Update.
8615         * s390-tdep.c: Update.
8616         * selftest-arch.c: Update.
8617         * solib-dsbt.c: Update.
8618         * solib-frv.c: Update.
8619         * solib-spu.c: Update.
8620         * solib-svr4.c: Update.
8621         * solib.c: Update.
8622         * sparc64-linux-tdep.c: Update.
8623         * stack.c: Update.
8624         * symfile-mem.c: Update.
8625         * symmisc.c: Update.
8626         * target.c: Update.
8627         * thread.c: Update.
8628         * top.c: Update.
8629         * tracefile-tfile.c: Update.
8630         * tui/tui.c: Update.
8631         * typeprint.c: Update.
8632         * unittests/cli-utils-selftests.c: Update.
8633         * unittests/parse-connection-spec-selftests.c: Update.
8634         * valops.c: Update.
8635         * valprint.c: Update.
8636         * value.c: Update.
8637         * varobj.c: Update.
8638         * windows-nat.c: Update.
8639         * x86-linux-nat.c: Update.
8640         * xml-support.c: Update.
8641
8642 2019-04-08  Tom Tromey  <tom@tromey.com>
8643
8644         * xml-support.c: Use C++ exception handling.
8645         * x86-linux-nat.c: Use C++ exception handling.
8646         * windows-nat.c: Use C++ exception handling.
8647         * varobj.c: Use C++ exception handling.
8648         * value.c: Use C++ exception handling.
8649         * valprint.c: Use C++ exception handling.
8650         * valops.c: Use C++ exception handling.
8651         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8652         handling.
8653         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8654         * typeprint.c: Use C++ exception handling.
8655         * tui/tui.c: Use C++ exception handling.
8656         * tracefile-tfile.c: Use C++ exception handling.
8657         * top.c: Use C++ exception handling.
8658         * thread.c: Use C++ exception handling.
8659         * target.c: Use C++ exception handling.
8660         * symmisc.c: Use C++ exception handling.
8661         * symfile-mem.c: Use C++ exception handling.
8662         * stack.c: Use C++ exception handling.
8663         * sparc64-linux-tdep.c: Use C++ exception handling.
8664         * solib.c: Use C++ exception handling.
8665         * solib-svr4.c: Use C++ exception handling.
8666         * solib-spu.c: Use C++ exception handling.
8667         * solib-frv.c: Use C++ exception handling.
8668         * solib-dsbt.c: Use C++ exception handling.
8669         * selftest-arch.c: Use C++ exception handling.
8670         * s390-tdep.c: Use C++ exception handling.
8671         * rust-lang.c: Use C++ exception handling.
8672         * rust-exp.y: Use C++ exception handling.
8673         * rs6000-tdep.c: Use C++ exception handling.
8674         * rs6000-aix-tdep.c: Use C++ exception handling.
8675         * riscv-tdep.c: Use C++ exception handling.
8676         * remote.c: Use C++ exception handling.
8677         * remote-fileio.c: Use C++ exception handling.
8678         * record-full.c: Use C++ exception handling.
8679         * record-btrace.c: Use C++ exception handling.
8680         * python/python.c: Use C++ exception handling.
8681         * python/py-value.c: Use C++ exception handling.
8682         * python/py-utils.c: Use C++ exception handling.
8683         * python/py-unwind.c: Use C++ exception handling.
8684         * python/py-type.c: Use C++ exception handling.
8685         * python/py-symbol.c: Use C++ exception handling.
8686         * python/py-record.c: Use C++ exception handling.
8687         * python/py-record-btrace.c: Use C++ exception handling.
8688         * python/py-progspace.c: Use C++ exception handling.
8689         * python/py-prettyprint.c: Use C++ exception handling.
8690         * python/py-param.c: Use C++ exception handling.
8691         * python/py-objfile.c: Use C++ exception handling.
8692         * python/py-linetable.c: Use C++ exception handling.
8693         * python/py-lazy-string.c: Use C++ exception handling.
8694         * python/py-infthread.c: Use C++ exception handling.
8695         * python/py-inferior.c: Use C++ exception handling.
8696         * python/py-gdb-readline.c: Use C++ exception handling.
8697         * python/py-framefilter.c: Use C++ exception handling.
8698         * python/py-frame.c: Use C++ exception handling.
8699         * python/py-finishbreakpoint.c: Use C++ exception handling.
8700         * python/py-cmd.c: Use C++ exception handling.
8701         * python/py-breakpoint.c: Use C++ exception handling.
8702         * python/py-arch.c: Use C++ exception handling.
8703         * printcmd.c: Use C++ exception handling.
8704         * ppc-linux-tdep.c: Use C++ exception handling.
8705         * parse.c: Use C++ exception handling.
8706         * p-valprint.c: Use C++ exception handling.
8707         * objc-lang.c: Use C++ exception handling.
8708         * mi/mi-main.c: Use C++ exception handling.
8709         * mi/mi-interp.c: Use C++ exception handling.
8710         * mi/mi-cmd-stack.c: Use C++ exception handling.
8711         * mi/mi-cmd-break.c: Use C++ exception handling.
8712         * main.c: Use C++ exception handling.
8713         * linux-thread-db.c: Use C++ exception handling.
8714         * linux-tdep.c: Use C++ exception handling.
8715         * linux-nat.c: Use C++ exception handling.
8716         * linux-fork.c: Use C++ exception handling.
8717         * linespec.c: Use C++ exception handling.
8718         * language.c: Use C++ exception handling.
8719         * jit.c: Use C++ exception handling.
8720         * infrun.c: Use C++ exception handling.
8721         * infcmd.c: Use C++ exception handling.
8722         * infcall.c: Use C++ exception handling.
8723         * inf-loop.c: Use C++ exception handling.
8724         * i386-tdep.c: Use C++ exception handling.
8725         * i386-linux-tdep.c: Use C++ exception handling.
8726         * guile/scm-value.c: Use C++ exception handling.
8727         * guile/scm-type.c: Use C++ exception handling.
8728         * guile/scm-symtab.c: Use C++ exception handling.
8729         * guile/scm-symbol.c: Use C++ exception handling.
8730         * guile/scm-pretty-print.c: Use C++ exception handling.
8731         * guile/scm-ports.c: Use C++ exception handling.
8732         * guile/scm-param.c: Use C++ exception handling.
8733         * guile/scm-math.c: Use C++ exception handling.
8734         * guile/scm-lazy-string.c: Use C++ exception handling.
8735         * guile/scm-frame.c: Use C++ exception handling.
8736         * guile/scm-disasm.c: Use C++ exception handling.
8737         * guile/scm-cmd.c: Use C++ exception handling.
8738         * guile/scm-breakpoint.c: Use C++ exception handling.
8739         * guile/scm-block.c: Use C++ exception handling.
8740         * guile/guile-internal.h: Use C++ exception handling.
8741         * gnu-v3-abi.c: Use C++ exception handling.
8742         * gdbtypes.c: Use C++ exception handling.
8743         * frame.c: Use C++ exception handling.
8744         * frame-unwind.c: Use C++ exception handling.
8745         * fbsd-tdep.c: Use C++ exception handling.
8746         * f-valprint.c: Use C++ exception handling.
8747         * exec.c: Use C++ exception handling.
8748         * event-top.c: Use C++ exception handling.
8749         * event-loop.c: Use C++ exception handling.
8750         * eval.c: Use C++ exception handling.
8751         * dwarf2read.c: Use C++ exception handling.
8752         * dwarf2loc.c: Use C++ exception handling.
8753         * dwarf2-frame.c: Use C++ exception handling.
8754         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8755         * dwarf-index-write.c: Use C++ exception handling.
8756         * dwarf-index-cache.c: Use C++ exception handling.
8757         * dtrace-probe.c: Use C++ exception handling.
8758         * disasm-selftests.c: Use C++ exception handling.
8759         * darwin-nat.c: Use C++ exception handling.
8760         * cp-valprint.c: Use C++ exception handling.
8761         * cp-support.c: Use C++ exception handling.
8762         * cp-abi.c: Use C++ exception handling.
8763         * corelow.c: Use C++ exception handling.
8764         * completer.c: Use C++ exception handling.
8765         * compile/compile-object-run.c: Use C++ exception handling.
8766         * compile/compile-object-load.c: Use C++ exception handling.
8767         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8768         * compile/compile-c-symbols.c: Use C++ exception handling.
8769         * common/selftest.c: Use C++ exception handling.
8770         * common/new-op.c: Use C++ exception handling.
8771         * cli/cli-script.c: Use C++ exception handling.
8772         * cli/cli-interp.c: Use C++ exception handling.
8773         * cli/cli-cmds.c: Use C++ exception handling.
8774         * c-varobj.c: Use C++ exception handling.
8775         * btrace.c: Use C++ exception handling.
8776         * breakpoint.c: Use C++ exception handling.
8777         * break-catch-throw.c: Use C++ exception handling.
8778         * arch-utils.c: Use C++ exception handling.
8779         * amd64-tdep.c: Use C++ exception handling.
8780         * ada-valprint.c: Use C++ exception handling.
8781         * ada-typeprint.c: Use C++ exception handling.
8782         * ada-lang.c: Use C++ exception handling.
8783         * aarch64-tdep.c: Use C++ exception handling.
8784
8785 2019-04-08  Tom Tromey  <tom@tromey.com>
8786
8787         * xml-support.c (gdb_xml_parser::parse): Update.
8788         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8789         * value.c (show_convenience): Update.
8790         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8791         (test_parse_flags_qcs): Update.
8792         * thread.c (thr_try_catch_cmd): Update.
8793         * target.c (target_translate_tls_address): Update.
8794         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8795         (info_frame_command_core, frame_apply_command_count): Update.
8796         * rust-exp.y (rust_lex_exception_test): Update.
8797         * riscv-tdep.c (riscv_print_one_register_info): Update.
8798         * remote.c (remote_target::enable_btrace): Update.
8799         * record-btrace.c (record_btrace_enable_warn): Update.
8800         * python/py-utils.c (gdbpy_convert_exception): Update.
8801         * printcmd.c (do_one_display, print_variable_and_value): Update.
8802         * mi/mi-main.c (mi_print_exception): Update.
8803         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8804         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8805         * linux-nat.c (linux_nat_target::attach): Update.
8806         * linux-fork.c (class scoped_switch_fork_info): Update.
8807         * infrun.c (displaced_step_prepare): Update.
8808         * infcall.c (call_function_by_hand_dummy): Update.
8809         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8810         * gnu-v3-abi.c (print_one_vtable): Update.
8811         * frame.c (get_prev_frame_always): Update.
8812         * f-valprint.c (info_common_command_for_block): Update.
8813         * exec.c (try_open_exec_file): Update.
8814         * exceptions.c (print_exception, exception_print)
8815         (exception_fprintf, exception_print_same): Update.
8816         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8817         * dwarf-index-cache.c (index_cache::store)
8818         (index_cache::lookup_gdb_index): Update.
8819         * darwin-nat.c (maybe_cache_shell): Update.
8820         * cp-valprint.c (cp_print_value_fields): Update.
8821         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8822         (gcc_cplus_symbol_address): Update.
8823         * compile/compile-c-symbols.c (gcc_convert_symbol)
8824         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8825         * common/selftest.c: Update.
8826         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8827         a std::string.
8828         (exception_try_scope_entry, exception_try_scope_exit): Don't
8829         declare.
8830         (struct exception_try_scope): Remove.
8831         (TRY): Don't use exception_try_scope.
8832         (struct gdb_exception): Add constructor, operator=.
8833         <what>: New method.
8834         (struct gdb_exception_RETURN_MASK_ALL)
8835         (struct gdb_exception_RETURN_MASK_ERROR)
8836         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8837         (struct gdb_quit_bad_alloc): Update.
8838         * common/common-exceptions.c (exception_none): Change
8839         initializer.
8840         (struct catcher) <state, exception>: Initialize inline.
8841         <prev>: Remove member.
8842         (current_catcher): Remove.
8843         (catchers): New global.
8844         (exceptions_state_mc_init): Simplify.
8845         (catcher_pop): Remove.
8846         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8847         (try_scope_depth, exception_try_scope_entry)
8848         (exception_try_scope_exit): Remove.
8849         (throw_exception_sjlj): Update.
8850         (exception_messages, exception_messages_size): Remove.
8851         (throw_it): Simplify.
8852         (gdb_exception_sliced_copy): Remove.
8853         (throw_exception_cxx): Update.
8854         * cli/cli-script.c (script_from_file): Update.
8855         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8856         Update.
8857         * ada-valprint.c (ada_val_print): Update.
8858         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8859         (create_excep_cond_exprs): Update.
8860
8861 2019-04-08  Tom Tromey  <tom@tromey.com>
8862
8863         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8864         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8865         (TRY, CATCH, END_CATCH): Remove some definitions.
8866         * common/common-exceptions.c: Don't use GDB_XCPT.
8867         (catcher_list_size): Remove.
8868         (throw_exception, throw_it): Simplify.
8869
8870 2019-04-05  Tom Tromey  <tom@tromey.com>
8871
8872         Revert the header-sorting patch.
8873         * ft32-tdep.c: Revert.
8874         * frv-tdep.c: Revert.
8875         * frv-linux-tdep.c: Revert.
8876         * frame.c: Revert.
8877         * frame-unwind.c: Revert.
8878         * frame-base.c: Revert.
8879         * fork-child.c: Revert.
8880         * findvar.c: Revert.
8881         * findcmd.c: Revert.
8882         * filesystem.c: Revert.
8883         * filename-seen-cache.h: Revert.
8884         * filename-seen-cache.c: Revert.
8885         * fbsd-tdep.c: Revert.
8886         * fbsd-nat.h: Revert.
8887         * fbsd-nat.c: Revert.
8888         * f-valprint.c: Revert.
8889         * f-typeprint.c: Revert.
8890         * f-lang.c: Revert.
8891         * extension.h: Revert.
8892         * extension.c: Revert.
8893         * extension-priv.h: Revert.
8894         * expprint.c: Revert.
8895         * exec.h: Revert.
8896         * exec.c: Revert.
8897         * exceptions.c: Revert.
8898         * event-top.c: Revert.
8899         * event-loop.c: Revert.
8900         * eval.c: Revert.
8901         * elfread.c: Revert.
8902         * dwarf2read.h: Revert.
8903         * dwarf2read.c: Revert.
8904         * dwarf2loc.c: Revert.
8905         * dwarf2expr.h: Revert.
8906         * dwarf2expr.c: Revert.
8907         * dwarf2-frame.c: Revert.
8908         * dwarf2-frame-tailcall.c: Revert.
8909         * dwarf-index-write.h: Revert.
8910         * dwarf-index-write.c: Revert.
8911         * dwarf-index-common.c: Revert.
8912         * dwarf-index-cache.h: Revert.
8913         * dwarf-index-cache.c: Revert.
8914         * dummy-frame.c: Revert.
8915         * dtrace-probe.c: Revert.
8916         * disasm.h: Revert.
8917         * disasm.c: Revert.
8918         * disasm-selftests.c: Revert.
8919         * dictionary.c: Revert.
8920         * dicos-tdep.c: Revert.
8921         * demangle.c: Revert.
8922         * dcache.h: Revert.
8923         * dcache.c: Revert.
8924         * darwin-nat.h: Revert.
8925         * darwin-nat.c: Revert.
8926         * darwin-nat-info.c: Revert.
8927         * d-valprint.c: Revert.
8928         * d-namespace.c: Revert.
8929         * d-lang.c: Revert.
8930         * ctf.c: Revert.
8931         * csky-tdep.c: Revert.
8932         * csky-linux-tdep.c: Revert.
8933         * cris-tdep.c: Revert.
8934         * cris-linux-tdep.c: Revert.
8935         * cp-valprint.c: Revert.
8936         * cp-support.c: Revert.
8937         * cp-namespace.c: Revert.
8938         * cp-abi.c: Revert.
8939         * corelow.c: Revert.
8940         * corefile.c: Revert.
8941         * continuations.c: Revert.
8942         * completer.h: Revert.
8943         * completer.c: Revert.
8944         * complaints.c: Revert.
8945         * coffread.c: Revert.
8946         * coff-pe-read.c: Revert.
8947         * cli-out.h: Revert.
8948         * cli-out.c: Revert.
8949         * charset.c: Revert.
8950         * c-varobj.c: Revert.
8951         * c-valprint.c: Revert.
8952         * c-typeprint.c: Revert.
8953         * c-lang.c: Revert.
8954         * buildsym.c: Revert.
8955         * buildsym-legacy.c: Revert.
8956         * build-id.h: Revert.
8957         * build-id.c: Revert.
8958         * btrace.c: Revert.
8959         * bsd-uthread.c: Revert.
8960         * breakpoint.h: Revert.
8961         * breakpoint.c: Revert.
8962         * break-catch-throw.c: Revert.
8963         * break-catch-syscall.c: Revert.
8964         * break-catch-sig.c: Revert.
8965         * blockframe.c: Revert.
8966         * block.c: Revert.
8967         * bfin-tdep.c: Revert.
8968         * bfin-linux-tdep.c: Revert.
8969         * bfd-target.c: Revert.
8970         * bcache.c: Revert.
8971         * ax-general.c: Revert.
8972         * ax-gdb.h: Revert.
8973         * ax-gdb.c: Revert.
8974         * avr-tdep.c: Revert.
8975         * auxv.c: Revert.
8976         * auto-load.c: Revert.
8977         * arm-wince-tdep.c: Revert.
8978         * arm-tdep.c: Revert.
8979         * arm-symbian-tdep.c: Revert.
8980         * arm-pikeos-tdep.c: Revert.
8981         * arm-obsd-tdep.c: Revert.
8982         * arm-nbsd-tdep.c: Revert.
8983         * arm-nbsd-nat.c: Revert.
8984         * arm-linux-tdep.c: Revert.
8985         * arm-linux-nat.c: Revert.
8986         * arm-fbsd-tdep.c: Revert.
8987         * arm-fbsd-nat.c: Revert.
8988         * arm-bsd-tdep.c: Revert.
8989         * arch-utils.c: Revert.
8990         * arc-tdep.c: Revert.
8991         * arc-newlib-tdep.c: Revert.
8992         * annotate.h: Revert.
8993         * annotate.c: Revert.
8994         * amd64-windows-tdep.c: Revert.
8995         * amd64-windows-nat.c: Revert.
8996         * amd64-tdep.c: Revert.
8997         * amd64-sol2-tdep.c: Revert.
8998         * amd64-obsd-tdep.c: Revert.
8999         * amd64-obsd-nat.c: Revert.
9000         * amd64-nbsd-tdep.c: Revert.
9001         * amd64-nbsd-nat.c: Revert.
9002         * amd64-nat.c: Revert.
9003         * amd64-linux-tdep.c: Revert.
9004         * amd64-linux-nat.c: Revert.
9005         * amd64-fbsd-tdep.c: Revert.
9006         * amd64-fbsd-nat.c: Revert.
9007         * amd64-dicos-tdep.c: Revert.
9008         * amd64-darwin-tdep.c: Revert.
9009         * amd64-bsd-nat.c: Revert.
9010         * alpha-tdep.c: Revert.
9011         * alpha-obsd-tdep.c: Revert.
9012         * alpha-nbsd-tdep.c: Revert.
9013         * alpha-mdebug-tdep.c: Revert.
9014         * alpha-linux-tdep.c: Revert.
9015         * alpha-linux-nat.c: Revert.
9016         * alpha-bsd-tdep.c: Revert.
9017         * alpha-bsd-nat.c: Revert.
9018         * aix-thread.c: Revert.
9019         * agent.c: Revert.
9020         * addrmap.c: Revert.
9021         * ada-varobj.c: Revert.
9022         * ada-valprint.c: Revert.
9023         * ada-typeprint.c: Revert.
9024         * ada-tasks.c: Revert.
9025         * ada-lang.c: Revert.
9026         * aarch64-tdep.c: Revert.
9027         * aarch64-ravenscar-thread.c: Revert.
9028         * aarch64-newlib-tdep.c: Revert.
9029         * aarch64-linux-tdep.c: Revert.
9030         * aarch64-linux-nat.c: Revert.
9031         * aarch64-fbsd-tdep.c: Revert.
9032         * aarch64-fbsd-nat.c: Revert.
9033         * aarch32-linux-nat.c: Revert.
9034
9035 2019-04-05  Tom Tromey  <tom@tromey.com>
9036
9037         * ft32-tdep.c: Sort headers.
9038         * frv-tdep.c: Sort headers.
9039         * frv-linux-tdep.c: Sort headers.
9040         * frame.c: Sort headers.
9041         * frame-unwind.c: Sort headers.
9042         * frame-base.c: Sort headers.
9043         * fork-child.c: Sort headers.
9044         * findvar.c: Sort headers.
9045         * findcmd.c: Sort headers.
9046         * filesystem.c: Sort headers.
9047         * filename-seen-cache.h: Sort headers.
9048         * filename-seen-cache.c: Sort headers.
9049         * fbsd-tdep.c: Sort headers.
9050         * fbsd-nat.h: Sort headers.
9051         * fbsd-nat.c: Sort headers.
9052         * f-valprint.c: Sort headers.
9053         * f-typeprint.c: Sort headers.
9054         * f-lang.c: Sort headers.
9055         * extension.h: Sort headers.
9056         * extension.c: Sort headers.
9057         * extension-priv.h: Sort headers.
9058         * expprint.c: Sort headers.
9059         * exec.h: Sort headers.
9060         * exec.c: Sort headers.
9061         * exceptions.c: Sort headers.
9062         * event-top.c: Sort headers.
9063         * event-loop.c: Sort headers.
9064         * eval.c: Sort headers.
9065         * elfread.c: Sort headers.
9066         * dwarf2read.h: Sort headers.
9067         * dwarf2read.c: Sort headers.
9068         * dwarf2loc.c: Sort headers.
9069         * dwarf2expr.h: Sort headers.
9070         * dwarf2expr.c: Sort headers.
9071         * dwarf2-frame.c: Sort headers.
9072         * dwarf2-frame-tailcall.c: Sort headers.
9073         * dwarf-index-write.h: Sort headers.
9074         * dwarf-index-write.c: Sort headers.
9075         * dwarf-index-common.c: Sort headers.
9076         * dwarf-index-cache.h: Sort headers.
9077         * dwarf-index-cache.c: Sort headers.
9078         * dummy-frame.c: Sort headers.
9079         * dtrace-probe.c: Sort headers.
9080         * disasm.h: Sort headers.
9081         * disasm.c: Sort headers.
9082         * disasm-selftests.c: Sort headers.
9083         * dictionary.c: Sort headers.
9084         * dicos-tdep.c: Sort headers.
9085         * demangle.c: Sort headers.
9086         * dcache.h: Sort headers.
9087         * dcache.c: Sort headers.
9088         * darwin-nat.h: Sort headers.
9089         * darwin-nat.c: Sort headers.
9090         * darwin-nat-info.c: Sort headers.
9091         * d-valprint.c: Sort headers.
9092         * d-namespace.c: Sort headers.
9093         * d-lang.c: Sort headers.
9094         * ctf.c: Sort headers.
9095         * csky-tdep.c: Sort headers.
9096         * csky-linux-tdep.c: Sort headers.
9097         * cris-tdep.c: Sort headers.
9098         * cris-linux-tdep.c: Sort headers.
9099         * cp-valprint.c: Sort headers.
9100         * cp-support.c: Sort headers.
9101         * cp-namespace.c: Sort headers.
9102         * cp-abi.c: Sort headers.
9103         * corelow.c: Sort headers.
9104         * corefile.c: Sort headers.
9105         * continuations.c: Sort headers.
9106         * completer.h: Sort headers.
9107         * completer.c: Sort headers.
9108         * complaints.c: Sort headers.
9109         * coffread.c: Sort headers.
9110         * coff-pe-read.c: Sort headers.
9111         * cli-out.h: Sort headers.
9112         * cli-out.c: Sort headers.
9113         * charset.c: Sort headers.
9114         * c-varobj.c: Sort headers.
9115         * c-valprint.c: Sort headers.
9116         * c-typeprint.c: Sort headers.
9117         * c-lang.c: Sort headers.
9118         * buildsym.c: Sort headers.
9119         * buildsym-legacy.c: Sort headers.
9120         * build-id.h: Sort headers.
9121         * build-id.c: Sort headers.
9122         * btrace.c: Sort headers.
9123         * bsd-uthread.c: Sort headers.
9124         * breakpoint.h: Sort headers.
9125         * breakpoint.c: Sort headers.
9126         * break-catch-throw.c: Sort headers.
9127         * break-catch-syscall.c: Sort headers.
9128         * break-catch-sig.c: Sort headers.
9129         * blockframe.c: Sort headers.
9130         * block.c: Sort headers.
9131         * bfin-tdep.c: Sort headers.
9132         * bfin-linux-tdep.c: Sort headers.
9133         * bfd-target.c: Sort headers.
9134         * bcache.c: Sort headers.
9135         * ax-general.c: Sort headers.
9136         * ax-gdb.h: Sort headers.
9137         * ax-gdb.c: Sort headers.
9138         * avr-tdep.c: Sort headers.
9139         * auxv.c: Sort headers.
9140         * auto-load.c: Sort headers.
9141         * arm-wince-tdep.c: Sort headers.
9142         * arm-tdep.c: Sort headers.
9143         * arm-symbian-tdep.c: Sort headers.
9144         * arm-pikeos-tdep.c: Sort headers.
9145         * arm-obsd-tdep.c: Sort headers.
9146         * arm-nbsd-tdep.c: Sort headers.
9147         * arm-nbsd-nat.c: Sort headers.
9148         * arm-linux-tdep.c: Sort headers.
9149         * arm-linux-nat.c: Sort headers.
9150         * arm-fbsd-tdep.c: Sort headers.
9151         * arm-fbsd-nat.c: Sort headers.
9152         * arm-bsd-tdep.c: Sort headers.
9153         * arch-utils.c: Sort headers.
9154         * arc-tdep.c: Sort headers.
9155         * arc-newlib-tdep.c: Sort headers.
9156         * annotate.h: Sort headers.
9157         * annotate.c: Sort headers.
9158         * amd64-windows-tdep.c: Sort headers.
9159         * amd64-windows-nat.c: Sort headers.
9160         * amd64-tdep.c: Sort headers.
9161         * amd64-sol2-tdep.c: Sort headers.
9162         * amd64-obsd-tdep.c: Sort headers.
9163         * amd64-obsd-nat.c: Sort headers.
9164         * amd64-nbsd-tdep.c: Sort headers.
9165         * amd64-nbsd-nat.c: Sort headers.
9166         * amd64-nat.c: Sort headers.
9167         * amd64-linux-tdep.c: Sort headers.
9168         * amd64-linux-nat.c: Sort headers.
9169         * amd64-fbsd-tdep.c: Sort headers.
9170         * amd64-fbsd-nat.c: Sort headers.
9171         * amd64-dicos-tdep.c: Sort headers.
9172         * amd64-darwin-tdep.c: Sort headers.
9173         * amd64-bsd-nat.c: Sort headers.
9174         * alpha-tdep.c: Sort headers.
9175         * alpha-obsd-tdep.c: Sort headers.
9176         * alpha-nbsd-tdep.c: Sort headers.
9177         * alpha-mdebug-tdep.c: Sort headers.
9178         * alpha-linux-tdep.c: Sort headers.
9179         * alpha-linux-nat.c: Sort headers.
9180         * alpha-bsd-tdep.c: Sort headers.
9181         * alpha-bsd-nat.c: Sort headers.
9182         * aix-thread.c: Sort headers.
9183         * agent.c: Sort headers.
9184         * addrmap.c: Sort headers.
9185         * ada-varobj.c: Sort headers.
9186         * ada-valprint.c: Sort headers.
9187         * ada-typeprint.c: Sort headers.
9188         * ada-tasks.c: Sort headers.
9189         * ada-lang.c: Sort headers.
9190         * aarch64-tdep.c: Sort headers.
9191         * aarch64-ravenscar-thread.c: Sort headers.
9192         * aarch64-newlib-tdep.c: Sort headers.
9193         * aarch64-linux-tdep.c: Sort headers.
9194         * aarch64-linux-nat.c: Sort headers.
9195         * aarch64-fbsd-tdep.c: Sort headers.
9196         * aarch64-fbsd-nat.c: Sort headers.
9197         * aarch32-linux-nat.c: Sort headers.
9198
9199 2019-04-04  Tom Tromey  <tom@tromey.com>
9200
9201         * varobj.c (varobj_create): Update.
9202         * rust-exp.y (struct rust_parser) <update_innermost_block,
9203         lookup_symbol>: New methods.
9204         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9205         Rename.
9206         (rust_parser::rust_lookup_type)
9207         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9208         * printcmd.c (display_command, do_one_display): Update.
9209         * parser-defs.h (struct parser_state) <parser_state>: Add
9210         "tracker" parameter.
9211         (block_tracker): New member.
9212         (class innermost_block_tracker) <innermost_block_tracker>: Add
9213         "types" parameter.
9214         <reset>: Remove method.
9215         (innermost_block): Don't declare.
9216         (null_post_parser): Update.
9217         * parse.c (innermost_block): Remove global.
9218         (write_dollar_variable): Update.
9219         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9220         Remove "tracker_types" parameter.
9221         (parse_expression): Add "tracker" parameter.
9222         (parse_expression_for_completion): Update.
9223         (null_post_parser): Add "tracker" parameter.
9224         * p-exp.y: Update rules.
9225         * m2-exp.y: Update rules.
9226         * language.h (struct language_defn) <la_post_parser>: Add
9227         "tracker" parameter.
9228         * go-exp.y: Update rules.
9229         * f-exp.y: Update rules.
9230         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9231         parameter.
9232         * d-exp.y: Update rules.
9233         * c-exp.y: Update rules.
9234         * breakpoint.c (set_breakpoint_condition): Create an
9235         innermost_block_tracker.
9236         (watch_command_1): Likewise.
9237         * ada-lang.c (resolve): Add "tracker" parameter.
9238         (resolve_subexp): Likewise.
9239         * ada-exp.y (write_var_from_sym): Update.
9240
9241 2019-04-04  Tom Tromey  <tom@tromey.com>
9242
9243         * type-stack.h: New file.
9244         * type-stack.c: New file.
9245         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9246         type-stack.h.
9247         (insert_into_type_stack, insert_type, push_type, push_type_int)
9248         (insert_type_address_space, pop_type, pop_type_int)
9249         (pop_typelist, pop_type_stack, append_type_stack)
9250         (push_type_stack, get_type_stack, push_typelist)
9251         (follow_type_instance_flags, follow_types): Don't declare.
9252         * parse.c (type_stack): Remove global.
9253         (parse_exp_in_context): Update.
9254         (insert_into_type_stack, insert_type, push_type, push_type_int)
9255         (insert_type_address_space, pop_type, pop_type_int)
9256         (pop_typelist, pop_type_stack, append_type_stack)
9257         (push_type_stack, get_type_stack, push_typelist)
9258         (follow_type_instance_flags, follow_types): Remove (moved to
9259         type-stack.c).
9260         * f-exp.y (type_stack): New global.
9261         Update rules.
9262         (push_kind_type, f_parse): Update.
9263         * d-exp.y (type_stack): New global.
9264         Update rules.
9265         (d_parse): Update.
9266         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9267         Update rules.
9268         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9269         (HFILES_NO_SRCDIR): Add type-stack.h.
9270
9271 2019-04-04  Tom Tromey  <tom@tromey.com>
9272
9273         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9274         (rust_parser::convert_ast_to_expression, rust_parse)
9275         (rust_lex_test_completion, rust_lex_tests): Update.
9276         * parser-defs.h (struct expr_completion_state): New.
9277         (struct parser_state) <parser_state>: Add completion parameter.
9278         <mark_struct_expression, mark_completion_tag>: New methods.
9279         <parse_completion, m_completion_state>: New members.
9280         (prefixify_expression, null_post_parser): Update.
9281         (mark_struct_expression, mark_completion_tag): Don't declare.
9282         * parse.c (parse_completion, expout_last_struct)
9283         (expout_tag_completion_type, expout_completion_name): Remove
9284         globals.
9285         (parser_state::mark_struct_expression)
9286         (parser_state::mark_completion_tag): Now methods.
9287         (prefixify_expression): Add last_struct parameter.
9288         (prefixify_subexp): Likewise.
9289         (parse_exp_1): Update.
9290         (parse_exp_in_context): Add cstate parameter.  Update.
9291         (parse_expression_for_completion): Create an
9292         expr_completion_state.
9293         (null_post_parser): Add "completion" parameter.
9294         * p-exp.y: Update rules.
9295         (yylex): Update.
9296         * language.h (struct language_defn) <la_post_parser>: Add
9297         "completing" parameter.
9298         * go-exp.y: Update rules.
9299         (lex_one_token): Update.
9300         * expression.h (parse_completion): Don't declare.
9301         * d-exp.y: Update rules.
9302         (lex_one_token): Update rules.
9303         * c-exp.y: Update rules.
9304         (lex_one_token): Update.
9305         * ada-lang.c (resolve): Add "parse_completion" parameter.
9306         (resolve_subexp): Likewise.
9307         (ada_resolve_function): Likewise.
9308
9309 2019-04-04  Tom Tromey  <tom@tromey.com>
9310
9311         * parser-defs.h (struct parser_state) <start_arglist,
9312         end_arglist>: New methods.
9313         <arglist_len, m_funcall_chain>: New members.
9314         (arglist_len, start_arglist, end_arglist): Don't declare.
9315         * parse.c (arglist_len, funcall_chain): Remove global.
9316         (start_arglist, end_arglist): Remove functions.
9317         (parse_exp_in_context): Update.
9318         * p-exp.y: Update rules.
9319         * m2-exp.y: Update rules.
9320         * go-exp.y: Update rules.
9321         * f-exp.y: Update rules.
9322         * d-exp.y: Update rules.
9323         * c-exp.y: Update rules.
9324
9325 2019-04-04  Tom Tromey  <tom@tromey.com>
9326
9327         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9328         lex_operator, push_back>: New methods.
9329         Update all rules.
9330         (rust_parser::lex_hex, lex_escape): Rename and update.
9331         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9332         (rust_parser::lex_operator): Rename and update.
9333         (rust_parser::lex_number, rustyylex, rustyyerror)
9334         (rust_lex_test_init, rust_lex_test_sequence)
9335         (rust_lex_test_push_back, rust_lex_tests): Update.
9336         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9337         parameter.
9338         <lexptr, prev_lexptr>: New members.
9339         (lexptr, prev_lexptr): Don't declare.
9340         * parse.c (lexptr, prev_lexptr): Remove globals.
9341         (parse_exp_in_context): Update.
9342         * p-exp.y (yylex, yyerror): Update.
9343         * m2-exp.y (parse_number, yylex, yyerror): Update.
9344         * go-exp.y (lex_one_token, yyerror): Update.
9345         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9346         * d-exp.y (lex_one_token, yyerror): Update.
9347         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9348         (lex_one_token, yyerror): Update.
9349         * ada-lex.l (YY_INPUT): Update.
9350         (rewind_to_char): Update.
9351         * ada-exp.y (yyerror): Update.
9352
9353 2019-04-04  Tom Tromey  <tom@tromey.com>
9354
9355         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9356         * parser-defs.h (struct parser_state) <parser_state>: Add new
9357         parameter.
9358         <comma_terminates>: New member.
9359         (comma_terminates): Don't declare global.
9360         * parse.c (comma_terminates): Remove global.
9361         (parse_exp_in_context): Update.
9362         * p-exp.y (yylex): Update.
9363         * m2-exp.y (yylex): Update.
9364         * go-exp.y (lex_one_token): Update.
9365         * f-exp.y (yylex): Update.
9366         * d-exp.y (lex_one_token): Update.
9367         * c-exp.y (lex_one_token): Update.
9368         * ada-lex.l: Update.
9369
9370 2019-04-04  Tom Tromey  <tom@tromey.com>
9371
9372         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9373         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9374         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9375         * parser-defs.h (paren_depth): Don't declare.
9376         * parse.c (paren_depth): Remove global.
9377         (parse_exp_in_context): Update.
9378         * p-exp.y (paren_depth): New global.
9379         (pascal_parse): Initialize it.
9380         * m2-exp.y (paren_depth): New global.
9381         (m2_parse): Initialize it.
9382         * go-exp.y (paren_depth): New global.
9383         (go_parse): Initialize it.
9384         * f-exp.y (paren_depth): New global.
9385         (f_parse): Initialize it.
9386         * d-exp.y (paren_depth): New global.
9387         (d_parse): Initialize it.
9388         * c-exp.y (paren_depth): New global.
9389         (c_parse): Initialize it.
9390         * ada-lex.l (paren_depth): New global.
9391         (lexer_init): Initialize it.
9392
9393 2019-04-04  Tom Tromey  <tom@tromey.com>
9394
9395         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9396         (rust_parser::convert_ast_to_type)
9397         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9398         * parser-defs.h (struct parser_state) <parser_state>: Add
9399         parameters.  Initialize new members.
9400         <expression_context_block, expression_context_pc>: New members.
9401         * parse.c (expression_context_block, expression_context_pc):
9402         Remove globals.
9403         (parse_exp_in_context): Update.
9404         * p-exp.y: Update all rules.
9405         (yylex): Update.
9406         * m2-exp.y: Update all rules.
9407         (yylex): Update.
9408         * go-exp.y (yylex): Update.
9409         * f-exp.y (yylex): Update.
9410         * d-exp.y: Update all rules.
9411         (yylex): Update.
9412         * c-exp.y: Update all rules.
9413         (lex_one_token, classify_name, yylex, c_parse): Update.
9414         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9415
9416 2019-04-04  Tom Tromey  <tom@tromey.com>
9417
9418         * gdbarch.h, gdbarch.c: Rebuild.
9419         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9420         * stap-probe.h:
9421         (struct stap_parse_info): Replace "parser_state" with
9422         "expr_builder".
9423         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9424         (parser_state): New class.
9425         * parse.c (expr_builder): Rename.
9426         (expr_builder::release): Rename.
9427         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9428         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9429         (write_exp_elt_longcst, write_exp_elt_floatcst)
9430         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9431         (write_exp_string_vector, write_exp_bitstring)
9432         (write_exp_msymbol, mark_struct_expression)
9433         (write_dollar_variable)
9434         (insert_type_address_space, increase_expout_size): Replace
9435         "parser_state" with "expr_builder".
9436         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9437         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9438         "parser_state" with "expr_builder".
9439
9440 2019-04-04  Tom Tromey  <tom@tromey.com>
9441
9442         * rust-exp.y: Replace "parse_language" with method call.
9443         * p-exp.y:
9444         (yylex): Replace "parse_language" with method call.
9445         * m2-exp.y:
9446         (yylex): Replace "parse_language" with method call.
9447         * go-exp.y (classify_name): Replace "parse_language" with method
9448         call.
9449         * f-exp.y (yylex): Replace "parse_language" with method call.
9450         * d-exp.y (lex_one_token): Replace "parse_language" with method
9451         call.
9452         * c-exp.y:
9453         (lex_one_token, classify_name, yylex): Replace "parse_language"
9454         with method call.
9455         * ada-exp.y (find_primitive_type, type_char)
9456         (type_system_address): Replace "parse_language" with method call.
9457
9458 2019-04-04  Tom Tromey  <tom@tromey.com>
9459
9460         * rust-exp.y: Replace "parse_gdbarch" with method call.
9461         * parse.c (write_dollar_variable, insert_type_address_space):
9462         Replace "parse_gdbarch" with method call.
9463         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9464         call.
9465         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9466         call.
9467         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9468         "parse_gdbarch" with method call.
9469         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9470         with method call.
9471         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9472         "parse_gdbarch" with method call.
9473         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9474         "parse_gdbarch" with method call.
9475         * c-exp.y (parse_type, parse_number, classify_name): Replace
9476         "parse_gdbarch" with method call.
9477         * ada-lex.l: Replace "parse_gdbarch" with method call.
9478         * ada-exp.y (parse_type, find_primitive_type, type_char)
9479         (type_system_address): Replace "parse_gdbarch" with method call.
9480
9481 2019-04-04  Tom Tromey  <tom@tromey.com>
9482
9483         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9484         * stap-probe.c (stap_parse_argument): Update.
9485         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9486         initial_size parameter.
9487         * rust-exp.y (rust_lex_tests): Update.
9488         * parse.c (parser_state): Update.
9489         (parse_exp_in_context): Update.
9490         * parser-defs.h (struct parser_state) <parser_state>: Remove
9491         "initial_size" parameter.
9492
9493 2019-04-04  Tom Tromey  <tom@tromey.com>
9494
9495         * parser-defs.h (increase_expout_size): Don't declare.
9496         * parse.c (increase_expout_size): Now static.
9497
9498 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9499
9500         * gnu-nat.c (gnu_nat_target::wait): Fix
9501         target_waitstatus_to_string call.
9502
9503 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9504
9505         * eval.c (evaluate_subexp_standard): Handle internal functions
9506         during Fortran function call handling.
9507
9508 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9509
9510         * NEWS: Mention new internal functions.
9511         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9512         (read_base_type): Use dwarf2_init_complex_target_type.
9513         * value.c (creal_internal_fn): New function.
9514         (cimag_internal_fn): New function.
9515         (_initialize_values): Register new internal functions.
9516
9517 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9518
9519         * infrun.c (stop_all_threads): If debug_infrun, always
9520         trace the wait status after wait_one, using
9521         target_waitstatus_to_string and target_pid_to_str.
9522         (handle_inferior_event): Replace various trace of
9523         wait status kind by a single trace.
9524         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9525         wait status kind image by target_waitstatus_to_string.
9526         * target/waitstatus.c (target_waitstatus_to_string): Fix
9527         obsolete comment.
9528
9529 2019-04-01  Tom Tromey  <tromey@adacore.com>
9530
9531         PR symtab/23331:
9532         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9533
9534 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9535             Pedro Alves  <palves@redhat.com>
9536
9537         * top.c (quit_force): Call 'finalize_values'.
9538         * value.c (finalize_values): New function.
9539         * value.h (finalize_values): Declare.
9540
9541 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9542
9543         * NEWS: Announce $_gdb_major and $_gdb_minor.
9544
9545         * top.c (init_gdb_version_vars): New function.
9546         (gdb_init): Call init_gdb_version_vars.
9547
9548 2019-03-29  Tom Tromey  <tromey@adacore.com>
9549
9550         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9551         help text.  Remove dead code.
9552
9553 2019-03-29  Keith Seitz  <keiths@redhat.com>
9554
9555         From Siddhesh Poyarekar:
9556         * f-lang.h (f77_get_upperbound): Return LONGEST.
9557         (f77_get_lowerbound): Likewise.
9558         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9559         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9560         print them.
9561         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9562         plongest to format print it.
9563         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9564         (f77_get_upperbound): Likewise.
9565         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9566         LOWER_BOUND to LONGEST.
9567         (f77_create_arrayprint_offset_tbl): Likewise.
9568
9569 2019-03-29  Keith Seitz  <keiths@redhat.com>
9570
9571         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9572         %s/pulongest for TYPE_LENGTH instead of %d in format
9573         strings.
9574         * ada-typerint.c (ada_print_type): Likewise.
9575         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9576         * compile/compile-c-support.c (generate_register_struct): Likewise.
9577         * gdbtypes.c (recursive_dump_type): Likewise.
9578         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9579         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9580         instead of %d in format strings.
9581         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9582         to std::min to ULONGEST.
9583         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9584         instead of %d in format strings.
9585         * tracepoint.c (info_scope_command): Likewise.
9586         * typeprint.c (print_offset_data::update)
9587         (print_offset_data::finish): Likewise.
9588         * xtensa-tdep.c (xtensa_store_return_value)
9589         (xtensa_push_dummy_call): Likewise.
9590
9591 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9592
9593         * windows-nat.c (display_selector): Fixed format specifications
9594         for 64-bit Cygwin.
9595
9596 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9597
9598         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9599
9600 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9601
9602         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9603         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9604         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9605         (nios2_linux_init_abi): Install it.
9606
9607 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9608
9609         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9610
9611 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9612
9613         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9614
9615 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9616             Tom Tromey  <tromey@adacore.com>
9617
9618         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9619
9620 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9621
9622         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9623         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9624         method to compute the bounds of range types. Also print "[evaluated]"
9625         if the bounds' values come from a dynamic evaluation.
9626
9627 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9628
9629         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9630         whitespace when pretty printing is on.
9631
9632 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9633
9634         * ppc-linux-nat.c: Add include.
9635
9636 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9637
9638         * NEWS: Mention AArch64 Pointer Authentication.
9639
9640 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9641
9642         * arm-linux-nat.c: Add include.
9643
9644 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9645
9646         * source-cache.c (source_cache::get_source_lines): Re-read
9647         fullname after calling open_source_file.
9648
9649 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9650
9651         * NEWS: Mention TLS support for FreeBSD.
9652
9653 2019-03-25  Tom Tromey  <tromey@adacore.com>
9654
9655         * minsyms.c (BUNCH_SIZE): Update comment.
9656         (~minimal_symbol_reader): Remove old comment.
9657         (compact_minimal_symbols): Update comment.
9658         (minimal_symbol_reader::install): Remove old comment.  Update
9659         other comments.
9660
9661 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9662
9663         * s390-linux-nat.c: Add include.
9664
9665 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9666
9667         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9668         Call linux_get_hwcap.
9669         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9670         Likewise.
9671         (aarch64_linux_get_hwcap): Remove function.
9672         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9673         declaration.
9674         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9675         linux_get_hwcap.
9676         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9677         * linux-tdep.c (linux_get_hwcap): Add function.
9678         (linux_get_hwcap2): Likewise.
9679         * linux-tdep.h (linux_get_hwcap): Add declaration.
9680         (linux_get_hwcap2): Likewise.
9681         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9682         (ppc_linux_get_hwcap2): Likewise.
9683         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9684         linux_get_hwcap.
9685         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9686         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9687         (ppc_linux_nat_target::read_description): Likewise.
9688         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9689         * s390-linux-nat.c: Likewise.
9690         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9691
9692 2019-03-24  Tom Tromey  <tom@tromey.com>
9693
9694         * ada-lang.c (standard_lookup): Simplify initialization.
9695         (ada_lookup_symbol_nonlocal): Simplify return.
9696         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9697         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9698         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9699         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9700         initialization.
9701         * solib.c (solib_global_lookup): Simplify.
9702         * symtab.c (null_block_symbol): Remove.
9703         (symbol_cache_lookup): Simplify returns.
9704         (lookup_language_this): Simplify returns.
9705         (lookup_symbol_aux): Simplify return.
9706         (lookup_local_symbol): Simplify returns.
9707         (lookup_global_symbol_from_objfile): Simplify return.
9708         (lookup_symbol_in_objfile_symtabs)
9709         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9710         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9711         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9712         * cp-namespace.c (cp_lookup_bare_symbol)
9713         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9714         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9715         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9716         (cp_lookup_symbol_via_imports): Simplify initialization.
9717         (find_symbol_in_baseclass): Likewise.
9718         * symtab.h (null_block_symbol): Remove.
9719         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9720         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9721         (d_lookup_symbol_module): Likewise.
9722         (find_symbol_in_baseclass): Simplify initialization.
9723
9724 2019-03-24  Tom Tromey  <tom@tromey.com>
9725
9726         * expression.h: Don't include symtab.h.
9727         (struct block): Forward declare.
9728
9729 2019-03-24  Tom Tromey  <tom@tromey.com>
9730
9731         * c-exp.y (typebase): Remove casts.
9732         * gdbtypes.c (lookup_unsigned_typename, )
9733         (lookup_signed_typename): Remove cast.
9734         * eval.c (parse_to_comma_and_eval): Remove cast.
9735         * parse.c (write_dollar_variable): Remove cast.
9736         * block.h (struct block) <superblock>: Now const.
9737         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9738         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9739         (map_block): Make "block" const.
9740         * symfile.h (struct quick_symbol_functions)
9741         <map_matching_symbols>: Constify block argument to "callback".
9742         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9743         const.
9744         (find_pc_sect_compunit_symtab): Make "b" const.
9745         (find_symbol_at_address): Likewise.
9746         (search_symbols): Likewise.
9747         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9748         (dw2_debug_names_lookup_symbol): Likewise.
9749         (dw2_map_matching_symbols): Update.
9750         * p-valprint.c (pascal_val_print): Remove "block".
9751         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9752         (aux_add_nonlocal_symbols): Make "block" const.
9753         (resolve_subexp): Remove cast.
9754         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9755         const.
9756         (iterate_over_file_blocks): Likewise.
9757         * f-exp.y (%union) <bval>: Remove.
9758         * coffread.c (patch_opaque_types): Make "b" const.
9759         * spu-tdep.c (spu_catch_start): Make "block" const.
9760         * c-valprint.c (print_unpacked_pointer): Remove "block".
9761         * symmisc.c (dump_symtab_1): Make "b" const.
9762         (block_depth): Make "block" const.
9763         * d-exp.y (%union) <bval>: Remove.
9764         * cp-support.h (cp_lookup_rtti_type): Update.
9765         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9766         * psymtab.c (psym_lookup_symbol): Make "block" const.
9767         (maintenance_check_psymtabs): Make "b" const.
9768         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9769         (enumerate_locals, enumerate_args): Update.
9770         * python/py-symtab.c (stpy_global_block): Make "block" const.
9771         (stpy_static_block): Likewise.
9772         * inline-frame.c (block_starting_point_at): Make "new_block"
9773         const.
9774         * block.c (find_block_in_blockvector): Make return type const.
9775         (blockvector_for_pc_sect): Make "b" const.
9776         (find_block_in_blockvector): Make "b" const.
9777
9778 2019-03-23  Tom Tromey  <tom@tromey.com>
9779
9780         * varobj.c (varobj_create): Update.
9781         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9782         * printcmd.c (display_command, do_one_display): Don't reset
9783         innermost_block.
9784         * parser-defs.h (enum innermost_block_tracker_type): Move to
9785         expression.h.
9786         (innermost_block): Update comment.
9787         * parse.c (parse_exp_1): Add tracker_types parameter.
9788         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9789         tracker_types parameter.  Reset innermost_block.
9790         (parse_exp_in_context): Remove.
9791         (parse_expression_for_completion): Update.
9792         * objfiles.c (~objfile): Don't reset expression_context_block or
9793         innermost_block.
9794         * expression.h (enum innermost_block_tracker_type): Move from
9795         parser-defs.h.
9796         (parse_exp_1): Add tracker_types parameter.
9797         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9798         reset innermost_block.
9799
9800 2019-03-23  Tom Tromey  <tom@tromey.com>
9801
9802         * objfiles.h: Include bcache.h.
9803
9804 2019-03-23  Tom Tromey  <tom@tromey.com>
9805
9806         * linespec.c (get_current_search_block): Use
9807         scoped_restore_current_language.
9808         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9809
9810 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9811             Jiong Wang  <jiong.wang@arm.com>
9812
9813         * aarch64-linux-tdep.c
9814         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9815         section.
9816         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9817
9818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9819             Jiong Wang  <jiong.wang@arm.com>
9820
9821         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9822         instructions.
9823         (aarch64_analyze_prologue_test): Add PACIASP test.
9824         (aarch64_prologue_prev_register): Unmask PC value.
9825
9826 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9827             Jiong Wang  <jiong.wang@arm.com>
9828
9829         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9830         (aarch64_dwarf2_prev_register): Unmask PC value.
9831         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9832         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9833         DW_CFA_AARCH64_negate_ra_state.
9834         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9835
9836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9837             Jiong Wang  <jiong.wang@arm.com>
9838
9839         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9840         registers.
9841         (aarch64_pseudo_register_name): Likewise.
9842         (aarch64_pseudo_register_type): Likewise.
9843         (aarch64_pseudo_register_reggroup_p): Likewise.
9844         (aarch64_gdbarch_init): Add pauth registers.
9845         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9846         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9847         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9848         (struct gdbarch_tdep): Add regnum for ra_state.
9849
9850 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9851             Jiong Wang  <jiong.wang@arm.com>
9852
9853         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9854
9855 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9856             Jiong Wang  <jiong.wang@arm.com>
9857
9858         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9859         function.
9860         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9861         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9862         (aarch64_gdbarch_init): Add puth registers.
9863         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9864         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9865         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9866
9867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9868             Jiong Wang  <jiong.wang@arm.com>
9869
9870         * aarch64-linux-nat.c
9871         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9872         * aarch64-linux-tdep.c
9873         (aarch64_linux_core_read_description): Likewise.
9874         (aarch64_linux_get_hwcap): New function.
9875         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9876         (aarch64_linux_get_hwcap): New declaration.
9877
9878 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9879             Jiong Wang  <jiong.wang@arm.com>
9880
9881         * aarch64-linux-nat.c
9882         (aarch64_linux_nat_target::read_description): Add pauth param.
9883         * aarch64-linux-tdep.c
9884         (aarch64_linux_core_read_description): Likewise.
9885         * aarch64-tdep.c (struct target_desc): Add in pauth.
9886         (aarch64_read_description): Add pauth param.
9887         (aarch64_gdbarch_init): Likewise.
9888         * aarch64-tdep.h (aarch64_read_description): Likewise.
9889         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9890         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9891         * features/Makefile: Add new files.
9892         * features/aarch64-pauth.c: New file.
9893         * features/aarch64-pauth.xml: New file.
9894
9895 2019-03-20  Tom Tromey  <tromey@adacore.com>
9896
9897         * infrun.c (handle_inferior_event): Rename from
9898         handle_inferior_event_1.  Create a scoped_value_mark.
9899         (handle_inferior_event): Remove.
9900
9901 2019-03-19  Tom Tromey  <tromey@adacore.com>
9902
9903         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9904         * infrun.h (print_stop_event): Add "displays" parameter.
9905         * infrun.c (print_stop_event): Add "displays" parameter.
9906
9907 2019-03-19  Pedro Alves  <palves@redhat.com>
9908
9909         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9910         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9911         to -1.  Fix TABs vs spaces.
9912         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9913         * tui/tui-out.h (tui_ui_out) Add intro comments.
9914         <m_line, m_start_of_line>: In-class initialize, and add describing
9915         comment.
9916
9917 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9918
9919         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9920         variable names.
9921         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9922
9923 2019-03-18  Pedro Alves  <palves@redhat.com>
9924             Eli Zaretskii <eliz@gnu.org>
9925
9926         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9927         m_line and m_start_of_line.
9928
9929 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9930
9931         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9932         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9933         it returns a newline.  This fixes a regression in TU mode, whereby
9934         the next line is output on the same screen line as the user input.
9935
9936 2019-03-18  Tom Tromey  <tromey@adacore.com>
9937
9938         * minsyms.c (minimal_symbol_reader::install): Remove call to
9939         obstack_blank.
9940
9941 2019-03-18  Pedro Alves  <palves@redhat.com>
9942
9943         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9944         New globals.
9945         (apply_style): New, factored out from ...
9946         (apply_ansi_escape): ... this.  Handle reverse video mode.
9947         (tui_set_reverse_mode): New function.
9948         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9949         * tui/tui-winsource.c (tui_show_source_line): Use
9950         tui_set_reverse_mode instead of setting A_STANDOUT.
9951         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9952         New setter methods.
9953
9954 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9955
9956         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9957         Handle tabs.
9958
9959 2019-03-18  Tom Tromey  <tromey@adacore.com>
9960
9961         * ada-lang.c (empty_array): Add "high" parameter.
9962         (ada_evaluate_subexp): Update.
9963
9964 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9965
9966         * unittests/string_view-selftests.c: Define
9967         _initialize_string_view_selftests unconditionally.
9968
9969 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9970
9971         PR gdb/24350
9972         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9973
9974 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9975
9976         PR gdb/24351
9977         * windows-nat.c (display_selector): Fix format specifiers.
9978
9979 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9980
9981         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9982         tui_refill_source_window instead of tui_refresh_win, to update the
9983         current execution line.  This fixes redisplay of the current line
9984         when stepping through the code with "next" or "step".
9985
9986 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9987
9988         * source-cache.c (source_cache::get_source_lines): Call
9989         find_source_lines to initialize s->nlines.  This fixes vertical
9990         scrolling of TUI source window when the DOWN arrow is pressed.
9991
9992 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9993
9994         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9995         linux-thread-db.c (_initialize_thread_db): Likewise.
9996
9997 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9998
9999         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10000         wclrtoeol in tui_show_source_line".  This reverts changes made in
10001         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10002
10003 2019-03-15  Tom Tromey  <tom@tromey.com>
10004
10005         * symtab.h (struct minimal_symbol): Derive from
10006         general_symbol_info.
10007         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10008         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10009         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10010         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10011         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10012         (MSYMBOL_SEARCH_NAME): Update.
10013         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10014         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10015         * minsyms.c (minimal_symbol_reader::record_full): Update.
10016
10017 2019-03-15  Tom Tromey  <tom@tromey.com>
10018
10019         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10020
10021 2019-03-15  Tom Tromey  <tom@tromey.com>
10022
10023         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10024         unique_xmalloc_ptr.
10025         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10026         Update.
10027         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10028         (build_minimal_symbol_hash_tables)
10029         (minimal_symbol_reader::install): Update.
10030
10031 2019-03-15  Tom Tromey  <tom@tromey.com>
10032
10033         * symtab.c (create_demangled_names_hash): Update.
10034         (symbol_set_names): Update.
10035         * objfiles.h (struct objfile_per_bfd_storage)
10036         <demangled_names_hash>: Now an htab_up.
10037         * objfiles.c (objfile_per_bfd_storage): Simplify.
10038
10039 2019-03-15  Tom Tromey  <tom@tromey.com>
10040
10041         * objfiles.h (struct objfile_per_bfd_storage): Declare
10042         destructor.
10043         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10044         New.
10045         (get_objfile_bfd_data): Use new.  Don't initialize
10046         language_of_main.
10047         (free_objfile_per_bfd_storage): Remove.
10048         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10049
10050 2019-03-15  Tom Tromey  <tom@tromey.com>
10051
10052         * symfile.c (reread_symbols): Update.
10053         * objfiles.c (objfile::objfile): Update.
10054         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10055         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10056         comment.
10057         (minimal_symbol_reader::install): Update.
10058         (terminate_minimal_symbol_table): Remove.
10059         * jit.c (jit_object_close_impl): Update.
10060
10061 2019-03-15  Tom Tromey  <tom@tromey.com>
10062
10063         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10064         initializations.
10065
10066 2019-03-15  Tom Tromey  <tom@tromey.com>
10067
10068         * objfiles.h (struct objfile_per_bfd_storage)
10069         <demangled_hash_languages>: Now a bitset.
10070         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10071         (lookup_minimal_symbol): Update.
10072
10073 2019-03-15  Tom Tromey  <tom@tromey.com>
10074
10075         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10076         Don't return the symbol.
10077         * coffread.c (record_minimal_symbol): Use record_full.
10078
10079 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10080
10081         The MS-Windows port of ncurses fails to switch to a color pair if
10082         one or both of the colors are the implicit default colors.  This
10083         change records the default colors when TUI is initialized, and
10084         then specifies them explicitly when a color pair uses the default
10085         colors.  This allows color styling in TUI mode on MS-Windows.
10086
10087         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10088         ncurses_norm_attr.
10089         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10090         colors in ncurses_norm_attr.
10091         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10092         "none", replace it with the default color recorded in
10093         ncurses_norm_attr.
10094
10095 2019-03-14  Tom Tromey  <tromey@adacore.com>
10096
10097         * source-cache.h (class source_cache) <get_source_lines>: Return
10098         std::string.
10099         * source-cache.c (source_cache::extract_lines): Handle case where
10100         first_pos==npos.  Return std::string.
10101         (source_cache::get_source_lines): Update.
10102
10103 2019-03-14  Tom Tromey  <tromey@adacore.com>
10104
10105         * NEWS: Add item for "style sources" commands.
10106         * source-cache.c (source_cache::get_source_lines): Check
10107         source_styling.
10108         * cli/cli-style.c (source_styling): New global.
10109         (_initialize_cli_style): Add "style sources" commands.
10110         (show_style_sources): New function.
10111         * cli/cli-style.h (source_styling): Declare.
10112
10113 2019-03-14  Pedro Alves  <palves@redhat.com>
10114             Tom Tromey  <tromey@adacore.com>
10115
10116         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10117         * tui/tui-winsource.c (tui_refill_source_window): New function,
10118         from...
10119         (tui_horizontal_source_scroll): ... here.  Move some logic.
10120         * cli/cli-style.c (set_style_enabled): Notify new observable.
10121         * tui/tui-hooks.c (tui_redisplay_source): New function.
10122         (tui_attach_detach_observers): Attach or detach
10123         tui_redisplay_source.
10124         * observable.h (source_styling_changed): New observable.
10125         * observable.c: Define source_styling_changed observable.
10126
10127 2019-03-13  Tom Tromey  <tromey@adacore.com>
10128
10129         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10130         (i386_gnu_nat_target::store_registers): Update.
10131         * target-debug.h (target_debug_print_std_string): New macro.
10132         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10133         * windows-tdep.c (display_one_tib): Update.
10134         * tui/tui-stack.c (tui_make_status_line): Update.
10135         * top.c (print_inferior_quit_action): Update.
10136         * thread.c (thr_try_catch_cmd): Update.
10137         (add_thread_with_info): Update.
10138         (thread_target_id_str): Update.
10139         (thr_try_catch_cmd): Update.
10140         (thread_command): Update.
10141         (thread_find_command): Update.
10142         * record-btrace.c (record_btrace_target::info_record)
10143         (record_btrace_resume_thread, record_btrace_target::resume)
10144         (record_btrace_cancel_resume, record_btrace_step_thread)
10145         (record_btrace_target::wait, record_btrace_target::wait)
10146         (record_btrace_target::wait, record_btrace_target::stop): Update.
10147         * progspace.c (print_program_space): Update.
10148         * process-stratum-target.c
10149         (process_stratum_target::thread_address_space): Update.
10150         * linux-fork.c (linux_fork_mourn_inferior)
10151         (detach_checkpoint_command, info_checkpoints_command)
10152         (linux_fork_context): Update.
10153         (linux_fork_detach): Update.
10154         (class scoped_switch_fork_info): Update.
10155         (delete_checkpoint_command): Update.
10156         * infrun.c (follow_fork_inferior): Update.
10157         (follow_fork_inferior): Update.
10158         (proceed_after_vfork_done): Update.
10159         (handle_vfork_child_exec_or_exit): Update.
10160         (follow_exec): Update.
10161         (displaced_step_prepare_throw): Update.
10162         (displaced_step_restore): Update.
10163         (start_step_over): Update.
10164         (resume_1): Update.
10165         (clear_proceed_status_thread): Update.
10166         (proceed): Update.
10167         (print_target_wait_results): Update.
10168         (do_target_wait): Update.
10169         (context_switch): Update.
10170         (stop_all_threads): Update.
10171         (restart_threads): Update.
10172         (finish_step_over): Update.
10173         (handle_signal_stop): Update.
10174         (switch_back_to_stepped_thread): Update.
10175         (keep_going_pass_signal): Update.
10176         (print_exited_reason): Update.
10177         (normal_stop): Update.
10178         * inferior.c (inferior_pid_to_str): Change return type.
10179         (print_selected_inferior): Update.
10180         (add_inferior): Update.
10181         (detach_inferior): Update.
10182         * dummy-frame.c (fprint_dummy_frames): Update.
10183         * dcache.c (dcache_info_1): Update.
10184         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10185         (btrace_fetch, btrace_clear): Update.
10186         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10187         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10188         type.
10189         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10190         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10191         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10192         * gdbarch.c, gdbarch.h: Rebuild.
10193         * gdbarch.sh (core_pid_to_str): Change return type.
10194         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10195         return type.
10196         (windows_nat_target::pid_to_str): Change return type.
10197         (windows_delete_thread): Update.
10198         (windows_nat_target::attach): Update.
10199         (windows_nat_target::files_info): Update.
10200         * target-delegates.c: Rebuild.
10201         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10202         return type.
10203         (sol_thread_target::pid_to_str): Change return type.
10204         * remote.c (class remote_target) <pid_to_str>: Change return
10205         type.
10206         (remote_target::pid_to_str): Change return type.
10207         (extended_remote_target::attach, remote_target::remote_stop_ns)
10208         (remote_target::remote_notif_remove_queued_reply)
10209         (remote_target::push_stop_reply, remote_target::disable_btrace):
10210         Update.
10211         (extended_remote_target::attach): Update.
10212         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10213         type.
10214         (gdbsim_target::pid_to_str): Change return type.
10215         * ravenscar-thread.c (struct ravenscar_thread_target)
10216         <pid_to_str>: Change return type.
10217         (ravenscar_thread_target::pid_to_str): Change return type.
10218         * procfs.c (class procfs_target) <pid_to_str>: Change return
10219         type.
10220         (procfs_target::pid_to_str): Change return type.
10221         (procfs_target::attach): Update.
10222         (procfs_target::detach): Update.
10223         (procfs_target::fetch_registers): Update.
10224         (procfs_target::store_registers): Update.
10225         (procfs_target::wait): Update.
10226         (procfs_target::files_info): Update.
10227         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10228         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10229         return type.
10230         (nto_procfs_target::pid_to_str): Change return type.
10231         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10232         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10233         return type.
10234         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10235         (exit_lwp): Update.
10236         (attach_proc_task_lwp_callback, get_detach_signal)
10237         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10238         (linux_nat_target::resume, wait_lwp, stop_callback)
10239         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10240         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10241         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10242         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10243         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10244         type.
10245         (inf_ptrace_target::attach): Update.
10246         (inf_ptrace_target::files_info): Update.
10247         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10248         type.
10249         (go32_nat_target::pid_to_str): Change return type.
10250         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10251         (gnu_nat_target::wait): Update.
10252         (gnu_nat_target::wait): Update.
10253         (gnu_nat_target::resume): Update.
10254         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10255         (fbsd_nat_target::wait): Update.
10256         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10257         type.
10258         (darwin_nat_target::attach): Update.
10259         * corelow.c (class core_target) <pid_to_str>: Change return type.
10260         (core_target::pid_to_str): Change return type.
10261         * target.c (normal_pid_to_str): Change return type.
10262         (default_pid_to_str): Likewise.
10263         (target_pid_to_str): Change return type.
10264         (target_translate_tls_address): Update.
10265         (target_announce_detach): Update.
10266         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10267         return type.
10268         (bsd_uthread_target::pid_to_str): Change return type.
10269         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10270         type.
10271         (bsd_kvm_target::pid_to_str): Change return type.
10272         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10273         return type.
10274         (aix_thread_target::pid_to_str): Change return type.
10275         * target.h (struct target_ops) <pid_to_str>: Change return type.
10276         (target_pid_to_str, normal_pid_to_str): Likewise.
10277         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10278         type.
10279         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10280         type.
10281         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10282         return type.
10283         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10284         type.
10285         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10286         type.
10287         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10288         return type.
10289
10290 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10291
10292         * NEWS: Mention that the new default MI version is 3.  Mention
10293         changes to the output of commands and events that deal with
10294         multi-location breakpoints.
10295         * breakpoint.c: Include "mi/mi-out.h".
10296         (print_one_breakpoint): Change output syntax if using MI version
10297         >= 3.
10298         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10299         New.
10300         (mi_multi_location_breakpoint_output_fixed): New.
10301         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10302         (mi_cmd_fix_multi_location_breakpoint_output): New.
10303         (mi_multi_location_breakpoint_output_fixed): New.
10304         * mi/mi-cmds.c (mi_cmds): Register command
10305         -fix-multi-location-breakpoint-output.
10306         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10307         interpreter "mi".
10308
10309 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10310
10311         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10312         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10313         instantiate mi_ui_out based on interpreter name.
10314         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10315         * mi/mi-main.c (mi_load_progress): Likewise.
10316
10317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10318
10319         * NEWS: Combine separate "New targets" sections for 8.3.
10320
10321 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10322
10323         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10324         (ppcfbsd_init_abi): Install gdbarch
10325         "fetch_tls_load_module_address" and "get_thread_local_address"
10326         methods.
10327
10328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10329
10330         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10331         (riscv_fbsd_init_abi): Install gdbarch
10332         "fetch_tls_load_module_address" and "get_thread_local_address"
10333         methods.
10334
10335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10336
10337         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10338         (i386fbsd_init_abi): Install gdbarch
10339         "fetch_tls_load_module_address" and "get_thread_local_address"
10340         methods.
10341
10342 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10343
10344         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10345         (amd64fbsd_init_abi): Install gdbarch
10346         "fetch_tls_load_module_address" and "get_thread_local_address"
10347         methods.
10348
10349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10350
10351         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10352         (struct fbsd_pspace_data): New type.
10353         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10354         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10355         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10356         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10357         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10358
10359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10360
10361         * gdbtypes.c (lookup_struct_elt): New function.
10362         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10363         * gdbtypes.h (struct struct_elt): New type.
10364         (lookup_struct_elt): New prototype.
10365
10366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10367
10368         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10369         remove disabled code block.
10370
10371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10372
10373         * gdbarch.sh (get_thread_local_address): New method.
10374         * gdbarch.h, gdbarch.c: Regenerate.
10375         * target.c (target_translate_tls_address): Use
10376         gdbarch_get_thread_local_address if present instead of
10377         target::get_thread_local_address.
10378
10379 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10380
10381         * target.h (target::get_thread_local_address): Update comment.
10382
10383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10384
10385         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10386         objfile->separate_debug_objfile_backlink if not NULL.
10387
10388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10389
10390         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10391         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10392         (amd64bsd_store_inferior_registers): Likewise.
10393         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10394         Enable segment base registers.
10395         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10396         PT_GETFSBASE and PT_GETGSBASE.
10397         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10398         PT_SETGSBASE.
10399         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10400         segment base registers.
10401         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10402
10403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10404
10405         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10406         Update calls to i386_target_description to add 'segments'
10407         parameter.
10408         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10409         add segment base registers.
10410         * arch/i386.c (i386_create_target_description): Add 'segments'
10411         parameter to enable segment base registers.
10412         * arch/i386.h (i386_create_target_description): Likewise.
10413         * features/i386/32bit-segments.xml: New file.
10414         * features/i386/32bit-segments.c: Generate.
10415         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10416         call to i386_target_description to add 'segments' parameter.
10417         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10418         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10419         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10420         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10421         if feature is present.
10422         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10423         Add 'segments' parameter to call to i386_target_description.
10424         (i386_target_description): Add 'segments' parameter to enable
10425         segment base registers.
10426         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10427         to call to i386_target_description.
10428         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10429         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10430         Define I386_NUM_REGS.
10431         (i386_target_description): Add 'segments' parameter to enable
10432         segment base registers.
10433
10434 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10435
10436         PR/24325
10437         * source-cache.c: #undef open and close, to avoid unresolved
10438         externals during linking.
10439
10440 2019-03-12  Tom Tromey  <tromey@adacore.com>
10441
10442         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10443         const.  Add initializers.
10444         (_initialize_remote): Don't initialize ptid globals.
10445
10446 2019-03-12  Pedro Alves  <palves@redhat.com>
10447
10448         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10449
10450 2019-03-12  Pedro Alves  <palves@redhat.com>
10451
10452         * cp-name-parser.y (main): Remove unused 'len' variable.
10453
10454 2019-03-12  Tom Tromey  <tromey@adacore.com>
10455
10456         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10457         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10458
10459 2019-03-12  Tom Tromey  <tromey@adacore.com>
10460
10461         * linux-nat.c (iterate_over_lwps): Update.
10462         (stop_callback): Remove parameter.
10463         (stop_wait_callback, detach_callback, resume_set_callback)
10464         (select_singlestep_lwp_callback, set_ignore_sigint)
10465         (status_callback, resumed_callback, resume_clear_callback)
10466         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10467         data parameter.
10468         (linux_nat_target::detach, linux_nat_target::resume)
10469         (linux_stop_and_wait_all_lwps, select_event_lwp)
10470         (linux_nat_filter_event, linux_nat_wait_1)
10471         (linux_nat_target::kill, linux_nat_target::stop)
10472         (linux_nat_target::stop): Update.
10473         (linux_nat_resume_callback): Change type.
10474         (resume_stopped_resumed_lwps, count_events_callback)
10475         (select_event_lwp_callback): Likewise.
10476         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10477         * arm-linux-nat.c (struct update_registers_data): Remove.
10478         (update_registers_callback): Change type.
10479         (arm_linux_insert_hw_breakpoint1): Update.
10480         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10481         parameter.
10482         (x86_linux_dr_set_addr): Update.
10483         (x86_linux_dr_set_control): Update.
10484         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10485         (iterate_over_lwps): Use gdb::function_view.
10486         * nat/aarch64-linux-hw-point.c (struct
10487         aarch64_dr_update_callback_param): Remove.
10488         (debug_reg_change_callback): Change type.
10489         (aarch64_notify_debug_reg_change): Update.
10490         * s390-linux-nat.c (s390_refresh_per_info): Update.
10491
10492 2019-03-11  Tom Tromey  <tromey@adacore.com>
10493
10494         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10495         redundant assignment to "this_cu".
10496
10497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10498
10499         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10500
10501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10502
10503         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10504         from...
10505         (rank_one_type): ... this.
10506
10507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10508
10509         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10510         from...
10511         (rank_one_type): ... this.
10512
10513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10514
10515         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10516         from...
10517         (rank_one_type): ... this.
10518
10519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10520
10521         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10522         from...
10523         (rank_one_type): ... this.
10524
10525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10526
10527         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10528         from...
10529         (rank_one_type): ... this.
10530
10531 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10532
10533         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10534         from...
10535         (rank_one_type): ... this.
10536
10537 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10538
10539         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10540         from...
10541         (rank_one_type): ... this.
10542
10543 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10544
10545         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10546         from...
10547         (rank_one_type): ... this.
10548
10549 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10550
10551         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10552         from...
10553         (rank_one_type): ... this.
10554
10555 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10556
10557         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10558         from...
10559         (rank_one_type): ... this.
10560
10561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10562
10563         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10564         from...
10565         (rank_one_type): ... this.
10566
10567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10568
10569         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10570         from...
10571         (rank_one_type): ... this.
10572
10573 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10574
10575         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10576         inferior-events' shows the example events.
10577
10578 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10579
10580         Support styling on native MS-Windows console
10581
10582         PR/24315
10583         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10584         on MS-Windows if $TERM is not defined.
10585
10586         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10587
10588         * posix-hdep.c (gdb_console_fputs):
10589         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10590         functions.
10591         * ui-file.h (gdb_console_fputs): Add prototype.
10592
10593         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10594         back to fputs only if the former returns zero.
10595
10596 2019-03-07  Tom Tromey  <tom@tromey.com>
10597
10598         * symmisc.c (print_symbol_bcache_statistics): Update.
10599         (print_objfile_statistics): Update.
10600         * symfile.c (allocate_symtab): Update.
10601         * stabsread.c: Don't include bcache.h.
10602         * psymtab.h (struct psymbol_bcache): Don't declare.
10603         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10604         (psymbol_bcache_init, psymbol_bcache_free)
10605         (psymbol_bcache_get_bcache): Don't declare.
10606         * psymtab.c (struct psymbol_bcache): Remove.
10607         (psymtab_storage::psymtab_storage): Update.
10608         (psymtab_storage::~psymtab_storage): Update.
10609         (psymbol_bcache_init, psymbol_bcache_free)
10610         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10611         (add_psymbol_to_bcache): Update.
10612         (allocate_psymtab): Update.
10613         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10614         macro_cache>: No longer pointers.
10615         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10616         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10617         * macrotab.c (macro_bcache): Update.
10618         * macroexp.c: Don't include bcache.h.
10619         * gdbtypes.c (check_types_worklist): Update.
10620         (types_deeply_equal): Remove TRY/CATCH.  Update.
10621         * elfread.c (elf_symtab_read): Update.
10622         * dwarf2read.c: Don't include bcache.h.
10623         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10624         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10625         (print_bcache_statistics, bcache_memory_used): Don't declare.
10626         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10627         methods.  Rename all data members.
10628         * bcache.c (struct bcache): Move to bcache.h.
10629         (bcache::expand_hash_table): Rename from expand_hash_table.
10630         (bcache): Remove.
10631         (bcache::insert): Rename from bcache_full.
10632         (bcache::compare): Rename from bcache_compare.
10633         (bcache_xmalloc): Remove.
10634         (bcache::~bcache): Rename from bcache_xfree.
10635         (bcache::print_statistics): Rename from print_bcache_statistics.
10636         (bcache::memory_used): Rename from bcache_memory_used.
10637
10638 2019-03-07  Pedro Alves  <palves@redhat.com>
10639
10640         * infrun.c (normal_stop): Also check for
10641         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10642
10643 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10644
10645         * f-lang.c (value_from_host_double): Moved to...
10646         * value.c (value_from_host_double): ...here.
10647         * value.h (value_from_host_double): Declare.
10648         * guile/scm-math.c (vlscm_convert_typed_number): Use
10649         value_from_host_double.
10650         (vlscm_convert_number): Likewise.
10651         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10652         * python/py-value.c (convert_value_from_python): Likewise.
10653
10654 2019-03-06  Tom Tromey  <tom@tromey.com>
10655
10656         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10657
10658 2019-03-06  Tom Tromey  <tom@tromey.com>
10659
10660         * utils.h (free_current_contents): Don't declare.
10661         * utils.c (free_current_contents): Remove.
10662
10663 2019-03-06  Tom Tromey  <tom@tromey.com>
10664
10665         * top.c (quit_force): Update.
10666         * main.c (captured_command_loop): Update.
10667         * common/new-op.c (operator new): Update.
10668         * common/common-exceptions.c (struct catcher)
10669         <save_cleanup_chain>: Remove member.
10670         (exceptions_state_mc_init): Update.
10671         (exception_try_scope_entry): Return nullptr.
10672         (exception_try_scope_exit, exception_rethrow)
10673         (throw_exception_sjlj, throw_exception_cxx): Update.
10674         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10675         (all_cleanups, do_cleanups, discard_cleanups)
10676         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10677         (restore_cleanups, restore_final_cleanups): Don't declare.
10678         (do_final_cleanups): Remove parameter.
10679         * common/cleanups.c (cleanup_chain, make_cleanup)
10680         (make_cleanup_dtor, all_cleanups, do_cleanups)
10681         (discard_my_cleanups, discard_cleanups)
10682         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10683         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10684         (null_cleanup): Remove.
10685         (do_final_cleanups): Remove parameter.
10686
10687 2019-03-06  Tom Tromey  <tom@tromey.com>
10688
10689         * remote.c (remote_target::remote_parse_stop_reply): Use
10690         unique_xmalloc_ptr.
10691
10692 2019-03-06  Tom Tromey  <tom@tromey.com>
10693
10694         * stabsread.c (struct stabs_field_info): Rename from field_info.
10695         <list, fnlist>: Add initializers.
10696         <obstack>: New member.
10697         (read_member_functions, read_struct_fields, read_baseclasses):
10698         Allocate on obstack.  Don't use cleanups.
10699         (read_one_struct_field, read_member_functions, read_struct_fields)
10700         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10701         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10702         (read_struct_type): Update.
10703
10704 2019-03-06  Tom Tromey  <tom@tromey.com>
10705
10706         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10707         * common/filestuff.h (make_cleanup_close): Don't declare.
10708         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10709         Remove.
10710
10711 2019-03-06  Tom Tromey  <tom@tromey.com>
10712
10713         * solib-aix.c: Use make_scope_exit.
10714
10715 2019-03-06  Tom Tromey  <tom@tromey.com>
10716
10717         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10718         Use make_scope_exit.
10719
10720 2019-03-06  Tom Tromey  <tom@tromey.com>
10721
10722         * solib-svr4.c (disable_probes_interface): Remove parameter.
10723         (svr4_handle_solib_event): Use make_scope_exit.
10724
10725 2019-03-06  Tom Tromey  <tom@tromey.com>
10726
10727         * remote.c (struct stop_reply_deleter): Remove.
10728         (stop_reply_up): Update.
10729         (struct stop_reply): Derive from notif_event.  Don't typedef.
10730         <regcache>: Now a std::vector.
10731         (stop_reply_xfree): Remove.
10732         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10733         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10734         (remote_target::discard_pending_stop_replies): Use delete.
10735         (remote_target::remote_parse_stop_reply): Update.
10736         (remote_target::process_stop_reply): Update.
10737         * remote-notif.h (struct notif_event): Add virtual destructor.
10738         Remove "dtr" member.
10739         (struct notif_client) <alloc_event>: Return a unique_ptr.
10740         (notif_event_xfree): Don't declare.
10741         (notif_event_up): New typedef.
10742         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10743         (notif_event_xfree, do_notif_event_xfree): Remove.
10744         (remote_notif_state_xfree): Update.
10745
10746 2019-03-06  Tom Tromey  <tom@tromey.com>
10747
10748         * infrun.c (displaced_step_clear_cleanup): Now a
10749         forward_scope_exit type.
10750         (displaced_step_prepare_throw): Update.
10751         (displaced_step_fixup): Update.
10752
10753 2019-03-06  Tom Tromey  <tom@tromey.com>
10754
10755         * inferior.h (class inferior): Update comment.
10756         * gdbthread.h (class thread_info): Update comment.
10757
10758 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10759             Tom Tromey  <tom@tromey.com>
10760
10761         * stabsread.h (struct stab_section_list): Remove.
10762         (coffstab_build_psymtabs): Update.
10763         * dbxread.c (symbuf_sections): Now a std::vector.
10764         (sect_idx): New global.
10765         (fill_symbuf): Update.
10766         (coffstab_build_psymtabs): Change type of stabsects parameter.
10767         Update.
10768         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10769         std::vector.
10770         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10771         (coff_locate_sections): Update.
10772         (coff_symfile_read): Remove cleanups.  Update.
10773         (init_stringtab): Add storage parameter.
10774         (free_stringtab, free_stringtab_cleanup): Remove.
10775         (init_lineno): Add storage parameter.
10776         (free_linetab, free_linetab_cleanup): Remove.
10777
10778 2019-03-06  Pedro Alves  <palves@redhat.com>
10779
10780         * linux-fork.c (fork_info::clobber_regs): Delete.
10781         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10782         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10783         comment.  Adjust.
10784         (scoped_switch_fork_info::scoped_switch_fork_info)
10785         (checkpoint_command, linux_fork_context): Adjust
10786         fork_save_infrun_state calls.
10787
10788 2019-03-06  Pedro Alves  <palves@redhat.com>
10789
10790         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10791         (inf_has_multiple_threads): Return 'bool' and rewrite using
10792         inferior_info::threads().
10793
10794 2019-03-06  Pedro Alves  <palves@redhat.com>
10795
10796         * linux-fork.c: Include <list>.
10797         (fork_list): Now a std::list instance.
10798         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10799         (forks_exist_p, find_last_fork): Adjust.
10800         (new_fork): Delete.
10801         (one_fork_p): New.
10802         (add_fork): Adjust.
10803         (free_fork): Delete, folded into fork_info::~fork_info().
10804         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10805         Adjust.
10806         (init_fork_list): Delete.
10807         (linux_fork_killall, linux_fork_mourn_inferior)
10808         (linux_fork_detach, info_checkpoints_command): Adjust.
10809         (_initialize_linux_fork): No longer call init_fork_list.
10810
10811 2019-03-06  Pedro Alves  <palves@redhat.com>
10812
10813         * linux-fork.c (new_fork): New, split out of ...
10814         (add_fork): ... this.  Return void.  Move "first fork" special
10815         case from here, to ...
10816         (checkpoint_command): ... here.
10817         * linux-linux.h (add_fork): Return void.
10818
10819 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10820
10821         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10822
10823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10824             Chris January  <chris.january@arm.com>
10825             David Lecomber  <david.lecomber@arm.com>
10826
10827         * f-exp.y: New token, UNOP_INTRINSIC.
10828         (exp): New pattern using UNOP_INTRINSIC token.
10829         (f77_keywords): Add 'abs' keyword.
10830         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10831         (value_from_host_double): New function.
10832         (evaluate_subexp_f): Support UNOP_ABS.
10833
10834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10835
10836         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10837         types.
10838
10839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10840
10841         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10842         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10843         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10844
10845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10846
10847         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10848
10849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10850             Chris January  <chris.january@arm.com>
10851
10852         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10853         * f-exp.y: Define 'KIND' token.
10854         (exp): New pattern for KIND expressions.
10855         (ptype): Handle types with a kind extension.
10856         (direct_abs_decl): Extend to spot kind extensions.
10857         (f77_keywords): Add 'kind' to the list.
10858         (push_kind_type): New function.
10859         (convert_to_kind_type): New function.
10860         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10861         * parse.c (operator_length_standard): Likewise.
10862         * parser-defs.h (enum type_pieces): Add tp_kind.
10863         * std-operator.def: Add UNOP_KIND.
10864
10865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10866
10867         * f-exp.y (f_parse): Set yydebug.
10868
10869 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10870
10871         * f-lang.c (evaluate_subexp_f): New function.
10872         (exp_descriptor_f): New global.
10873         (f_language_defn): Use exp_descriptor_f instead of
10874         exp_descriptor_standard.
10875
10876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10877
10878         * f-exp.y (struct token): Add comments.
10879         (dot_ops): Remove uppercase versions and the end marker.
10880         (f77_keywords): Likewise.
10881         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10882         entries in the dot_ops array are case insensitive, and use
10883         strncasecmp to compare strings.  Also some whitespace cleanup in
10884         this area.  Similar for the f77_keywords array, except entries in
10885         this list might be case sensitive.
10886
10887 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * f-exp.y (struct f77_boolean_val): Add comments.
10890         (boolean_values): Remove uppercase versions, and end marker.
10891         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10892         and use strncasecmp to achieve case insensitivity.  Additionally,
10893         perform whitespace cleanup around this code.
10894
10895 2019-03-06  Tom Tromey  <tromey@adacore.com>
10896
10897         * remote-sim.c (gdbsim_target_open): Use result of
10898         gdb_argv::release.
10899
10900 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10901         Dirk Schubert  <dirk.schubert@arm.com>
10902         Chris January  <chris.january@arm.com>
10903
10904         * eval.c (evaluate_subexp_standard): Call Fortran argument
10905         wrapping logic.
10906         * f-lang.c (struct value): A value which can be passed into a
10907         Fortran function call.
10908         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10909         where appropriate.
10910         (struct type): Value ready for a Fortran function call.
10911         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10912         is needed.
10913         * f-lang.h (fortran_argument_convert): Declaration.
10914         (fortran_preserve_arg_pointer): Declaration.
10915         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10916
10917 2019-03-05  Tom Tromey  <tromey@adacore.com>
10918
10919         * python/py-prettyprint.c (print_string_repr): Remove #if.
10920         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10921
10922 2019-03-05  Tom Tromey  <tromey@adacore.com>
10923
10924         * target.c (the_dummy_target): Move later.  Change type to
10925         "dummy_target".
10926         (initialize_targets): Don't initialize the_dummy_target.
10927
10928 2019-03-05  Tom Tromey  <tromey@adacore.com>
10929
10930         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10931         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10932
10933 2019-03-05  Tom Tromey  <tromey@adacore.com>
10934
10935         * windows-nat.c (windows_nat_target::attach)
10936         (windows_nat_target::detach): Don't call gdb_flush.
10937         * valprint.c (generic_val_print, val_print, val_print_string):
10938         Don't call gdb_flush.
10939         * utils.c (defaulted_query): Don't call gdb_flush.
10940         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10941         * target.c (target_announce_detach): Don't call gdb_flush.
10942         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10943         * remote.c (extended_remote_target::attach): Don't call
10944         gdb_flush.
10945         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10946         * printcmd.c (do_examine): Don't call gdb_flush.
10947         (info_display_command): Don't call gdb_flush.
10948         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10949         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10950         * memattr.c (info_mem_command): Don't call gdb_flush.
10951         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10952         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10953         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10954         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10955         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10956         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10957         (gnu_nat_target::detach): Don't call gdb_flush.
10958         * f-valprint.c (f_val_print): Don't call gdb_flush.
10959         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10960         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10961         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10962         gdb_flush.
10963         * c-valprint.c (c_val_print): Don't call gdb_flush.
10964         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10965
10966 2019-03-05  Tom Tromey  <tromey@adacore.com>
10967
10968         * varobj.c (update_dynamic_varobj_children): Update.
10969         (install_default_visualizer): Use reset, not release.
10970         * value.c (set_internalvar): Update.
10971         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10972         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10973         ATTRIBUTE_UNUSED_RESULT.
10974
10975 2019-03-05  Tom Tromey  <tromey@adacore.com>
10976
10977         * remote.c (class scoped_remote_fd) <release>: Add
10978         ATTRIBUTE_UNUSED_RESULT.
10979
10980 2019-03-05  Tom Tromey  <tromey@adacore.com>
10981
10982         * macroexp.c (struct macro_buffer) <release>: Add
10983         ATTRIBUTE_UNUSED_RESULT.
10984
10985 2019-03-05  Tom Tromey  <tromey@adacore.com>
10986
10987         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10988         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10989         ATTRIBUTE_UNUSED_RESULT.
10990
10991 2019-03-05  Tom Tromey  <tromey@adacore.com>
10992
10993         * common/scoped_fd.h (class scoped_fd) <release>: Add
10994         ATTRIBUTE_UNUSED_RESULT.
10995
10996 2019-03-05  Tom Tromey  <tromey@adacore.com>
10997
10998         * parser-defs.h (struct parser_state) <release>: Add
10999         ATTRIBUTE_UNUSED_RESULT.
11000
11001 2019-03-05  Tom Tromey  <tromey@adacore.com>
11002
11003         * utils.h (class gdb_argv) <release>: Add
11004         ATTRIBUTE_UNUSED_RESULT.
11005         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11006
11007 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11008
11009         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11010         for-loop range, to avoid compiler warnings.
11011
11012         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11013         avoid compiler warnings about unused variables.
11014
11015         * NEWS: Mention end of support for native debugging on MS-Windows
11016         before XP.
11017
11018         PR gdb/24292
11019         * common/netstuff.c:
11020         * gdbserver/gdbreplay.c
11021         * gdbserver/remote-utils.c:
11022         * ser-tcp.c:
11023         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11024         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11025         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11026         'getaddrinfo' and 'freeaddrinfo' were not available before
11027         Windows XP, and mingw.org's MinGW headers by default define
11028         _WIN32_WINNT to 0x500.
11029
11030 2019-03-01  Gary Benson <gbenson@redhat.com>
11031
11032         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11033
11034 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11035             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11036
11037         PR gdb/8527
11038         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11039         set_sigint_trap, clear_sigint_trap.
11040
11041 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11042
11043         * target.c (target_detach): Clear the regcache and the
11044         frame cache.
11045
11046 2019-02-27  Pedro Alves  <palves@redhat.com>
11047
11048         * utils.c (set_screen_size): When we cap the height/width sizes,
11049         tweak the corresponding command variable to show "unlimited":
11050
11051 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11052             Pedro Alves  <palves@redhat.com>
11053
11054         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11055         before calling rl_set_screen_size.
11056
11057 2019-02-27  Tom Tromey  <tromey@adacore.com>
11058
11059         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11060         define.
11061         * python/py-value.c: Remove Python 2.4 workaround.
11062         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11063         workaround.
11064         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11065         Python 2.4 workaround.
11066         * python/python-internal.h: Remove Python 2.4 comment.
11067         (Py_ssize_t): Don't define.
11068         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11069         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11070         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11071         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11072         * python/python.c (do_start_initialization): Remove Python 2.4
11073         workaround.
11074         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11075         (print_children): Remove Python 2.4 workaround.
11076         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11077         workaround.
11078         (CHARBUFFERPROC_NAME): Remove.
11079         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11080         Python 2.4 workaround.
11081
11082 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11083
11084         * NEWS: Note minimum Python version.
11085
11086 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11087
11088         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11089         code from these functions.  Remove corresponding ifdefs.  Use
11090         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11091         Remove gotos and target of gotos.
11092         (infpy_search_memory): Likewise.
11093
11094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11095
11096         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11097         (hppa_gdbarch_init): Don't register deleted functions with
11098         gdbarch.
11099
11100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11101
11102         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11103         (h8300_unwind_sp): Delete.
11104         (h8300_dummy_id): Delete.
11105         (h8300_gdbarch_init): Don't register deleted functions with
11106         gdbarch.
11107
11108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11109
11110         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11111         (ft32_unwind_pc): Delete.
11112         (ft32_unwind_sp): Delete.
11113         (ft32_gdbarch_init): Don't register deleted functions with
11114         gdbarch.
11115
11116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11117
11118         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11119         (frv_unwind_pc): Delete.
11120         (frv_unwind_sp): Delete.
11121         (frv_gdbarch_init): Don't register deleted functions with
11122         gdbarch.
11123
11124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11125
11126         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11127         (riscv_unwind_pc): Delete.
11128         (riscv_unwind_sp): Delete.
11129         (riscv_gdbarch_init): Don't register deleted functions with
11130         gdbarch.
11131
11132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11133
11134         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11135         (csky_unwind_pc): Delete.
11136         (csky_unwind_sp): Delete.
11137         (csky_gdbarch_init): Don't register deleted functions with
11138         gdbarch.
11139
11140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11141
11142         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11143         (cris_unwind_pc): Delete.
11144         (cris_unwind_sp): Delete.
11145         (cris_gdbarch_init): Don't register deleted functions with
11146         gdbarch.
11147
11148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11149
11150         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11151         (bfin_unwind_pc): Delete.
11152         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11153
11154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11155
11156         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11157         (arm_unwind_pc): Delete.
11158         (arm_unwind_sp): Delete.
11159         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11160
11161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11162
11163         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11164         (arc_unwind_pc): Delete.
11165         (arc_unwind_sp): Delete.
11166         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11167
11168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11169
11170         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11171         (alpha_unwind_pc): Delete.
11172         (alpha_gdbarch_init): Don't register deleted functions with
11173         gdbarch.
11174
11175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11176
11177         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11178         (aarch64_unwind_pc): Delete.
11179         (aarch64_unwind_sp): Delete.
11180         (aarch64_gdbarch_init): Don't register deleted functions with
11181         gdbarch.
11182
11183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * gdbtypes.c (type_align): Don't consider static members when
11186         computing structure alignment.
11187
11188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11189
11190         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11191         return 0 for other types.
11192         * arch-utils.c (default_type_align): Always return 0.
11193         * gdbarch.h: Regenerate.
11194         * gdbarch.sh (type_align): Extend comment.
11195         * gdbtypes.c (type_align): Add additional comments, always call
11196         gdbarch_type_align before applying the default rules.
11197         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11198         generic code will then apply a suitable default.
11199         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11200         types, return 0 for other types.
11201
11202 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11203
11204         * NEWS: Create a new section for the next release branch.
11205         Rename the section of the current branch, now that it has
11206         been cut.
11207
11208 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11209
11210         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11211         * version.in: Bump version to 8.3.50.DATE-git.
11212
11213 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11214
11215         * aix-thread.c (ptid_cmp): Remove unused variable.
11216         (get_signaled_thread): Likewise.
11217         (store_regs_user_thread): Likewise.
11218         (store_regs_kernel_thread): Likewise.
11219         (fetch_regs_kernel_thread): Remove shadowed variable.
11220
11221 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11222
11223         * features/riscv/32bit-cpu.xml: Add register numbers.
11224         * features/riscv/32bit-fpu.c: Regenerate.
11225         * features/riscv/32bit-fpu.xml: Add register numbers.
11226         * features/riscv/64bit-cpu.xml: Add register numbers.
11227         * features/riscv/64bit-fpu.c: Regenerate.
11228         * features/riscv/64bit-fpu.xml: Add register numbers.
11229
11230 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11231
11232         * NEWS: Mention two argument form of gdb.Value constructor.
11233         * python/py-value.c (convert_buffer_and_type_to_value): New
11234         function.
11235         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11236         Add support for handling an optional second argument.  Call
11237         convert_buffer_and_type_to_value as appropriate.
11238         * python/python-internal.h (Py_buffer_deleter): New struct.
11239         (Py_buffer_up): New typedef.
11240
11241 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11242
11243         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11244         instead of releasing ownership.
11245
11246 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11247
11248         * dwarf2read.c (open_and_init_dwp_file): Call
11249         elf_numsections instead of bfd_count_sections to initialize
11250         dwp_file->num_sections.
11251
11252 2019-02-25  Tom Tromey  <tromey@adacore.com>
11253
11254         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11255
11256 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11257
11258         * gcore.in: Add '--readnever' option when invoking GDB.
11259
11260 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11261
11262         * MAINTAINERS: Update my email address.
11263
11264 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11265
11266         * build-id.c (build_id_to_debug_bfd_1): New function.
11267         (build_id_to_debug_bfd): Look for separate debug file in
11268         sysroot.
11269
11270 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * gdbarch.sh: Update the copyright year range that is placed into
11273         generated files.
11274
11275 2019-02-22  Keith Seitz  <keiths@redhat.com>
11276
11277         PR symtab/23853
11278         * linespec.c (create_sals_line_offset): Search for the default
11279         symtab's filename instead of its fullname.
11280
11281 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11282
11283         * NEWS: Update style defaults.
11284
11285 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11286
11287         * main.c (captured_main_1): Disable styling in batch mode.
11288
11289 2019-02-20  Tom Tromey  <tom@tromey.com>
11290
11291         * symtab.c (symtab_symbol_info): Fix typos.
11292
11293 2019-02-20  Tom Tromey  <tromey@adacore.com>
11294
11295         * findcmd.c (_initialize_mem_search): Use upper case for
11296         metasyntactic variables.
11297
11298 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11299
11300         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11301         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11302
11303 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11304
11305         * top.h (source_file_name): Change to std::string.
11306         * top.c (source_file_name): Likewise.
11307         (command_line_input): Adjust.
11308         * cli/cli-script.c (script_from_file): Adjust.
11309
11310 2019-02-19  Tom Tromey  <tromey@adacore.com>
11311
11312         * ravenscar-thread.c
11313         (ravenscar_thread_target::update_thread_list): Don't call
11314         ada_build_task_list.
11315         * ada-lang.h (ada_build_task_list): Don't declare.
11316         * ada-tasks.c (struct ada_tasks_inferior_data)
11317         <task_list_valid_p>: Now bool.
11318         (read_known_tasks, ada_task_list_changed)
11319         (ada_tasks_invalidate_inferior_data): Update.
11320         (read_known_tasks_array): Return bool.
11321         (read_known_tasks_list): Likewise.
11322         (read_known_tasks): Return void.
11323         (ada_build_task_list): Now static.
11324
11325 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11326
11327         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11328         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11329
11330 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11331
11332         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11333         variant for ada_tasks_pspace_data_handle and
11334         ada_tasks_inferior_data_handle.
11335         (ada_tasks_pspace_data_cleanup): New function.
11336         (ada_tasks_inferior_data_cleanup): New function.
11337
11338 2019-02-17  Tom Tromey  <tom@tromey.com>
11339
11340         * macrotab.h (macro_source_fullname): Return a std::string.
11341         * macrotab.c (macro_include, check_for_redefinition)
11342         (macro_undef, macro_lookup_definition, foreach_macro)
11343         (foreach_macro_in_scope): Update.
11344         (macro_source_fullname): Return a std::string.
11345         * macrocmd.c (show_pp_source_pos): Update.
11346
11347 2019-02-17  Tom Tromey  <tom@tromey.com>
11348
11349         * macrocmd.c (show_pp_source_pos): Style the file names.
11350
11351 2019-02-17  Tom Tromey  <tom@tromey.com>
11352
11353         PR tui/24197:
11354         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11355
11356 2019-02-17  Tom Tromey  <tom@tromey.com>
11357
11358         * ada-lang.c (user_select_syms): Use filtered printing.
11359         * utils.c (wrap_style): New global.
11360         (desired_style): Remove.
11361         (emit_style_escape): Add stream parameter.
11362         (set_output_style, reset_terminal_style, prompt_for_continue):
11363         Update.
11364         (flush_wrap_buffer): Only flush gdb_stdout.
11365         (wrap_here): Set wrap_style.
11366         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11367         treat escape sequences as a character.  Change when wrap buffer is
11368         flushed.
11369         (fputs_styled): Do not set the output style when the default is
11370         requested.
11371         * ui-style.h (struct ui_file_style) <is_default>: New method.
11372         * source.c (print_source_lines_base): Emit escape sequences in one
11373         piece.
11374
11375 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11376
11377         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11378         integers and enumeration types.
11379
11380 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11381
11382         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11383         instead of lookup_symbol_in_language
11384         (do_exact_match): New function.
11385         (ada_get_symbol_name_matcher): Return do_exact_match when
11386         doing a verbatim match.
11387
11388 2019-02-15  Tom Tromey  <tromey@adacore.com>
11389
11390         * ravenscar-thread.c (ravenscar_thread_target::resume)
11391         (ravenscar_thread_target::wait): Special case wildcard requests.
11392
11393 2019-02-15  Tom Tromey  <tromey@adacore.com>
11394
11395         * ravenscar-thread.c (base_ptid): Remove.
11396         (struct ravenscar_thread_target) <close>: New method.
11397         <m_base_ptid>: New member.
11398         <update_inferior_ptid, active_task, task_is_currently_active,
11399         runtime_initialized>: Declare methods.
11400         <ravenscar_thread_target>: Add constructor.
11401         (ravenscar_thread_target::task_is_currently_active)
11402         (ravenscar_thread_target::update_inferior_ptid)
11403         (ravenscar_runtime_initialized): Rename.  Now methods.
11404         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11405         (ravenscar_thread_target::update_thread_list): Update.
11406         (ravenscar_thread_target::active_task): Now method.
11407         (ravenscar_thread_target::store_registers)
11408         (ravenscar_thread_target::prepare_to_store)
11409         (ravenscar_thread_target::prepare_to_store)
11410         (ravenscar_thread_target::mourn_inferior): Update.
11411         (ravenscar_inferior_created): Use "new" to create target.
11412         (ravenscar_thread_target::get_ada_task_ptid): Update.
11413         (_initialize_ravenscar): Don't initialize base_ptid.
11414         (ravenscar_ops): Remove global.
11415
11416 2019-02-15  Tom Tromey  <tromey@adacore.com>
11417
11418         * target.h (push_target): Declare new overload.
11419         * target.c (push_target): New overload, taking an rvalue reference.
11420         * remote.c (remote_target::open_1): Use push_target overload.
11421         * corelow.c (core_target_open): Use push_target overload.
11422
11423 2019-02-15  Tom Tromey  <tromey@adacore.com>
11424
11425         * ravenscar-thread.c (is_ravenscar_task)
11426         (ravenscar_task_is_currently_active): Return bool.
11427         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11428         (_initialize_ravenscar): Remove "(void)".
11429         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11430         Return bool.
11431
11432 2019-02-15  Tom Tromey  <tromey@adacore.com>
11433
11434         * ravenscar-thread.c (ravenscar_runtime_initializer)
11435         (has_ravenscar_runtime, get_running_thread_id)
11436         (ravenscar_thread_target::resume): Fix indentation.
11437
11438 2019-02-15  Tom Tromey  <tromey@adacore.com>
11439
11440         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11441         from ravenscar_arch_ops.
11442         (sparc_ravenscar_ops::fetch_registers)
11443         (sparc_ravenscar_ops::store_registers): Now methods.
11444         (sparc_ravenscar_prepare_to_store): Remove.
11445         (sparc_ravenscar_ops): Redefine.
11446         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11447         methods and destructor.  Remove members.
11448         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11449         (ravenscar_thread_target::store_registers)
11450         (ravenscar_thread_target::prepare_to_store): Update.
11451         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11452         Remove.
11453         (struct ppc_ravenscar_powerpc_ops): Derive from
11454         ravenscar_arch_ops.
11455         (ppc_ravenscar_powerpc_ops::fetch_registers)
11456         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11457         (ppc_ravenscar_powerpc_ops): Redefine.
11458         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11459         (ppc_ravenscar_e500_ops::fetch_registers)
11460         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11461         (ppc_ravenscar_e500_ops): Redefine.
11462         * aarch64-ravenscar-thread.c
11463         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11464         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11465         (aarch64_ravenscar_fetch_registers)
11466         (aarch64_ravenscar_store_registers): Now methods.
11467         (aarch64_ravenscar_ops): Redefine.
11468
11469 2019-02-15  Tom Tromey  <tromey@adacore.com>
11470
11471         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11472         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11473         (ravenscar_thread_target::stopped_by_watchpoint)
11474         (ravenscar_thread_target::stopped_data_address)
11475         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11476
11477 2019-02-15  Tom Tromey  <tromey@adacore.com>
11478
11479         * ravenscar-thread.c: Fix some typos.
11480
11481 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11482             Tom Tromey  <tromey@adacore.com>
11483
11484         * ada-lang.c (ada_exception_sal): Change addr_string to a
11485         std::string.
11486         (create_ada_exception_catchpoint): Update.
11487
11488 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11489             Tom Tromey  <tromey@adacore.com>
11490
11491         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11492         (bp_location_ops): Remove.
11493         (base_breakpoint_allocate_location): Update.
11494         (free_bp_location): Update.
11495         * ada-lang.c (class ada_catchpoint_location)
11496         <ada_catchpoint_location>: Remove ops parameter.
11497         (ada_catchpoint_location_dtor): Remove.
11498         (ada_catchpoint_location_ops): Remove.
11499         (allocate_location_exception): Update.
11500         * breakpoint.h (struct bp_location_ops): Remove.
11501         (class bp_location) <bp_location>: Remove bp_location_ops
11502         parameter.
11503         <~bp_location>: Add destructor.
11504         <ops>: Remove.
11505
11506 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11507             Pedro Alves  <palves@redhat.com>
11508
11509         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11510         'PATH_MAX'.
11511
11512 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11513             Samuel Thibault  <samuel.thibault@gnu.org>
11514             Thomas Schwinge  <thomas@codesourcery.com>
11515
11516         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11517         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11518
11519 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11520
11521         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11522         (check_empty): Use "const char *".
11523
11524         * gnu-nat.c (gnu_nat_target::detach): Instead of
11525         'detach_inferior (pid)' call
11526         'detach_inferior (find_inferior_pid (pid))'.
11527
11528         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11529         'nat/fork-inferior.o'.
11530         * gnu-nat.c: #include "nat/fork-inferior.h".
11531
11532         * gnu-nat.c (gnu_nat_target::detach): Instead of
11533         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11534         * gnu-nat.h: #include "inf-child.h".
11535         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11536         'i386_gnu_nat_target::fetch_registers'.
11537         (gnu_store_registers): Rename/move to
11538         'i386_gnu_nat_target::store_registers'.
11539
11540         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11541         * gnu-nat.h (mach_thread_info): New function.
11542         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11543
11544         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11545
11546 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11547
11548         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11549
11550 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11551
11552         * windows-nat.c (windows_add_thread): Add new parameter
11553         "main_thread_p" with default value set to false.  Update
11554         function documentation as well as all callers.
11555         (windows_delete_thread): Likewise.
11556         (fake_create_process): Update call to windows_add_thread.
11557         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11558         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11559         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11560         call to windows_delete_thread.
11561
11562 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11563
11564         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11565
11566 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11567
11568         * symfile.c (find_separate_debug_file): Use canonical path of
11569         sysroot with child_path instead of gdb_sysroot if it is valid.
11570
11571 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11572
11573         * symfile.c (find_separate_debug_file): Use child_path to
11574         determine if an object file is under a sysroot.
11575
11576 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11577
11578         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11579         unittests/child-path-selftests.c.
11580         * common/pathstuff.c (child_path): New function.
11581         * common/pathstuff.h (child_path): New prototype.
11582         * unittests/child-path-selftests.c: New file.
11583
11584 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11585
11586         * symfile.c (find_separate_debug_file): Look for separate debug
11587         files in debug directories under the sysroot.
11588
11589 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11590
11591         * symtab.h (struct minimal_symbol data_p): New const method.
11592         (struct minimal_symbol text_p): Likewise.
11593         * symtab.c (output_source_filename): Use file name style
11594         to print file name.
11595         (print_symbol_info): Likewise.
11596         (print_msymbol_info): Use address style to print addresses.
11597         Use function name style to print executable text symbols.
11598         (expand_symtab_containing_pc): Use data_p.
11599         (find_pc_sect_compunit_symtab): Likewise.
11600
11601 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11602
11603         * breakpoint.c (describe_other_breakpoints): Use address style
11604         to print addresses.
11605         (say_where): Likewise.
11606
11607 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11608
11609         * ada-typeprint.c (print_func_type): Print function name
11610         style to print function name.
11611         * c-typeprint.c (c_print_type_1): Likewise.
11612
11613 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11614
11615         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11616         for execve.
11617
11618 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11619
11620         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11621         type_stack.
11622
11623 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11624
11625         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11626         TYPE_CODE_REF types.
11627
11628 2019-02-08  Jim Wilson  <jimw@sifive.com>
11629
11630         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11631         (riscv_linux_fregset): New.
11632         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11633
11634 2019-02-07  Tom Tromey  <tom@tromey.com>
11635
11636         * thread.c (thread_cancel_execution_command): Update.
11637         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11638         methods.
11639         (struct thread_fsm_ops): Remove.
11640         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11641         (thread_fsm_should_stop, thread_fsm_return_value)
11642         (thread_fsm_set_finished, thread_fsm_finished_p)
11643         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11644         Don't declare.
11645         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11646         * infrun.c (clear_proceed_status_thread)
11647         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11648         (print_stop_event): Update.
11649         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11650         Add constructor.
11651         (step_command_fsm_ops): Remove.
11652         (new_step_command_fsm): Remove.
11653         (step_1): Update.
11654         (step_command_fsm::should_stop): Rename from
11655         step_command_fsm_should_stop.
11656         (step_command_fsm::clean_up): Rename from
11657         step_command_fsm_clean_up.
11658         (step_command_fsm::do_async_reply_reason): Rename from
11659         step_command_fsm_async_reply_reason.
11660         (struct until_next_fsm): Inherit from thread_fsm.  Add
11661         constructor.
11662         (until_next_fsm_ops): Remove.
11663         (new_until_next_fsm): Remove.
11664         (until_next_fsm::should_stop): Rename from
11665         until_next_fsm_should_stop.
11666         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11667         (until_next_fsm::do_async_reply_reason): Rename from
11668         until_next_fsm_async_reply_reason.
11669         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11670         constructor.  Change type of breakpoint.
11671         (finish_command_fsm_ops): Remove.
11672         (new_finish_command_fsm): Remove.
11673         (finish_command_fsm::should_stop): Rename from
11674         finish_command_fsm_should_stop.
11675         (finish_command_fsm::clean_up): Rename from
11676         finish_command_fsm_clean_up.
11677         (finish_command_fsm::return_value): Rename from
11678         finish_command_fsm_return_value.
11679         (finish_command_fsm::do_async_reply_reason): Rename from
11680         finish_command_fsm_async_reply_reason.
11681         (finish_command): Update.
11682         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11683         Add constructor.
11684         (call_thread_fsm_ops): Remove.
11685         (call_thread_fsm::call_thread_fsm): Rename from
11686         new_call_thread_fsm.
11687         (call_thread_fsm::should_stop): Rename from
11688         call_thread_fsm_should_stop.
11689         (call_thread_fsm::should_notify_stop): Rename from
11690         call_thread_fsm_should_notify_stop.
11691         (run_inferior_call, call_function_by_hand_dummy): Update.
11692         * cli/cli-interp.c (should_print_stop_to_console): Update.
11693         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11694         Add constructor.  Change type of location_breakpoint,
11695         caller_breakpoint.
11696         (until_break_fsm_ops): Remove.
11697         (new_until_break_fsm): Remove.
11698         (until_break_fsm::should_stop): Rename from
11699         until_break_fsm_should_stop.
11700         (until_break_fsm::clean_up): Rename from
11701         until_break_fsm_clean_up.
11702         (until_break_fsm::do_async_reply_reason): Rename from
11703         until_break_fsm_async_reply_reason.
11704         (until_break_command): Update.
11705         * thread-fsm.c: Remove.
11706         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11707
11708 2019-02-07  Tom Tromey  <tom@tromey.com>
11709
11710         * yy-remap.h: Add include guard.
11711         * xtensa-tdep.h: Add include guard.
11712         * xcoffread.h: Rename include guard.
11713         * varobj-iter.h: Add include guard.
11714         * tui/tui.h: Rename include guard.
11715         * tui/tui-winsource.h: Rename include guard.
11716         * tui/tui-wingeneral.h: Rename include guard.
11717         * tui/tui-windata.h: Rename include guard.
11718         * tui/tui-win.h: Rename include guard.
11719         * tui/tui-stack.h: Rename include guard.
11720         * tui/tui-source.h: Rename include guard.
11721         * tui/tui-regs.h: Rename include guard.
11722         * tui/tui-out.h: Rename include guard.
11723         * tui/tui-layout.h: Rename include guard.
11724         * tui/tui-io.h: Rename include guard.
11725         * tui/tui-hooks.h: Rename include guard.
11726         * tui/tui-file.h: Rename include guard.
11727         * tui/tui-disasm.h: Rename include guard.
11728         * tui/tui-data.h: Rename include guard.
11729         * tui/tui-command.h: Rename include guard.
11730         * tic6x-tdep.h: Add include guard.
11731         * target/waitstatus.h: Rename include guard.
11732         * target/wait.h: Rename include guard.
11733         * target/target.h: Rename include guard.
11734         * target/resume.h: Rename include guard.
11735         * target-float.h: Rename include guard.
11736         * stabsread.h: Add include guard.
11737         * rs6000-tdep.h: Add include guard.
11738         * riscv-fbsd-tdep.h: Add include guard.
11739         * regformats/regdef.h: Rename include guard.
11740         * record.h: Rename include guard.
11741         * python/python.h: Rename include guard.
11742         * python/python-internal.h: Rename include guard.
11743         * python/py-stopevent.h: Rename include guard.
11744         * python/py-ref.h: Rename include guard.
11745         * python/py-record.h: Rename include guard.
11746         * python/py-record-full.h: Rename include guard.
11747         * python/py-record-btrace.h: Rename include guard.
11748         * python/py-instruction.h: Rename include guard.
11749         * python/py-events.h: Rename include guard.
11750         * python/py-event.h: Rename include guard.
11751         * procfs.h: Add include guard.
11752         * proc-utils.h: Add include guard.
11753         * p-lang.h: Add include guard.
11754         * or1k-tdep.h: Rename include guard.
11755         * observable.h: Rename include guard.
11756         * nto-tdep.h: Rename include guard.
11757         * nat/x86-linux.h: Rename include guard.
11758         * nat/x86-linux-dregs.h: Rename include guard.
11759         * nat/x86-gcc-cpuid.h: Add include guard.
11760         * nat/x86-dregs.h: Rename include guard.
11761         * nat/x86-cpuid.h: Rename include guard.
11762         * nat/ppc-linux.h: Rename include guard.
11763         * nat/mips-linux-watch.h: Rename include guard.
11764         * nat/linux-waitpid.h: Rename include guard.
11765         * nat/linux-ptrace.h: Rename include guard.
11766         * nat/linux-procfs.h: Rename include guard.
11767         * nat/linux-osdata.h: Rename include guard.
11768         * nat/linux-nat.h: Rename include guard.
11769         * nat/linux-namespaces.h: Rename include guard.
11770         * nat/linux-btrace.h: Rename include guard.
11771         * nat/glibc_thread_db.h: Rename include guard.
11772         * nat/gdb_thread_db.h: Rename include guard.
11773         * nat/gdb_ptrace.h: Rename include guard.
11774         * nat/fork-inferior.h: Rename include guard.
11775         * nat/amd64-linux-siginfo.h: Rename include guard.
11776         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11777         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11778         * nat/aarch64-linux.h: Rename include guard.
11779         * nat/aarch64-linux-hw-point.h: Rename include guard.
11780         * mn10300-tdep.h: Add include guard.
11781         * mips-linux-tdep.h: Add include guard.
11782         * mi/mi-parse.h: Rename include guard.
11783         * mi/mi-out.h: Rename include guard.
11784         * mi/mi-main.h: Rename include guard.
11785         * mi/mi-interp.h: Rename include guard.
11786         * mi/mi-getopt.h: Rename include guard.
11787         * mi/mi-console.h: Rename include guard.
11788         * mi/mi-common.h: Rename include guard.
11789         * mi/mi-cmds.h: Rename include guard.
11790         * mi/mi-cmd-break.h: Rename include guard.
11791         * m2-lang.h: Add include guard.
11792         * location.h: Rename include guard.
11793         * linux-record.h: Rename include guard.
11794         * linux-nat.h: Add include guard.
11795         * linux-fork.h: Add include guard.
11796         * i386-darwin-tdep.h: Rename include guard.
11797         * hppa-linux-offsets.h: Add include guard.
11798         * guile/guile.h: Rename include guard.
11799         * guile/guile-internal.h: Rename include guard.
11800         * gnu-nat.h: Rename include guard.
11801         * gdb-stabs.h: Rename include guard.
11802         * frv-tdep.h: Add include guard.
11803         * f-lang.h: Add include guard.
11804         * event-loop.h: Add include guard.
11805         * darwin-nat.h: Rename include guard.
11806         * cp-abi.h: Rename include guard.
11807         * config/sparc/nm-sol2.h: Rename include guard.
11808         * config/nm-nto.h: Rename include guard.
11809         * config/nm-linux.h: Add include guard.
11810         * config/i386/nm-i386gnu.h: Rename include guard.
11811         * config/djgpp/nl_types.h: Rename include guard.
11812         * config/djgpp/langinfo.h: Rename include guard.
11813         * compile/gcc-cp-plugin.h: Add include guard.
11814         * compile/gcc-c-plugin.h: Add include guard.
11815         * compile/compile.h: Rename include guard.
11816         * compile/compile-object-run.h: Rename include guard.
11817         * compile/compile-object-load.h: Rename include guard.
11818         * compile/compile-internal.h: Rename include guard.
11819         * compile/compile-cplus.h: Rename include guard.
11820         * compile/compile-c.h: Rename include guard.
11821         * common/xml-utils.h: Rename include guard.
11822         * common/x86-xstate.h: Rename include guard.
11823         * common/version.h: Rename include guard.
11824         * common/vec.h: Rename include guard.
11825         * common/tdesc.h: Rename include guard.
11826         * common/selftest.h: Rename include guard.
11827         * common/scoped_restore.h: Rename include guard.
11828         * common/scoped_mmap.h: Rename include guard.
11829         * common/scoped_fd.h: Rename include guard.
11830         * common/safe-iterator.h: Rename include guard.
11831         * common/run-time-clock.h: Rename include guard.
11832         * common/refcounted-object.h: Rename include guard.
11833         * common/queue.h: Rename include guard.
11834         * common/ptid.h: Rename include guard.
11835         * common/print-utils.h: Rename include guard.
11836         * common/preprocessor.h: Rename include guard.
11837         * common/pathstuff.h: Rename include guard.
11838         * common/observable.h: Rename include guard.
11839         * common/netstuff.h: Rename include guard.
11840         * common/job-control.h: Rename include guard.
11841         * common/host-defs.h: Rename include guard.
11842         * common/gdb_wait.h: Rename include guard.
11843         * common/gdb_vecs.h: Rename include guard.
11844         * common/gdb_unlinker.h: Rename include guard.
11845         * common/gdb_unique_ptr.h: Rename include guard.
11846         * common/gdb_tilde_expand.h: Rename include guard.
11847         * common/gdb_sys_time.h: Rename include guard.
11848         * common/gdb_string_view.h: Rename include guard.
11849         * common/gdb_splay_tree.h: Rename include guard.
11850         * common/gdb_setjmp.h: Rename include guard.
11851         * common/gdb_ref_ptr.h: Rename include guard.
11852         * common/gdb_optional.h: Rename include guard.
11853         * common/gdb_locale.h: Rename include guard.
11854         * common/gdb_assert.h: Rename include guard.
11855         * common/filtered-iterator.h: Rename include guard.
11856         * common/filestuff.h: Rename include guard.
11857         * common/fileio.h: Rename include guard.
11858         * common/environ.h: Rename include guard.
11859         * common/common-utils.h: Rename include guard.
11860         * common/common-types.h: Rename include guard.
11861         * common/common-regcache.h: Rename include guard.
11862         * common/common-inferior.h: Rename include guard.
11863         * common/common-gdbthread.h: Rename include guard.
11864         * common/common-exceptions.h: Rename include guard.
11865         * common/common-defs.h: Rename include guard.
11866         * common/common-debug.h: Rename include guard.
11867         * common/cleanups.h: Rename include guard.
11868         * common/buffer.h: Rename include guard.
11869         * common/btrace-common.h: Rename include guard.
11870         * common/break-common.h: Rename include guard.
11871         * cli/cli-utils.h: Rename include guard.
11872         * cli/cli-style.h: Rename include guard.
11873         * cli/cli-setshow.h: Rename include guard.
11874         * cli/cli-script.h: Rename include guard.
11875         * cli/cli-interp.h: Rename include guard.
11876         * cli/cli-decode.h: Rename include guard.
11877         * cli/cli-cmds.h: Rename include guard.
11878         * charset-list.h: Add include guard.
11879         * buildsym-legacy.h: Rename include guard.
11880         * bfin-tdep.h: Add include guard.
11881         * ax.h: Rename include guard.
11882         * arm-linux-tdep.h: Add include guard.
11883         * arm-fbsd-tdep.h: Add include guard.
11884         * arch/xtensa.h: Rename include guard.
11885         * arch/tic6x.h: Add include guard.
11886         * arch/i386.h: Add include guard.
11887         * arch/arm.h: Rename include guard.
11888         * arch/arm-linux.h: Rename include guard.
11889         * arch/arm-get-next-pcs.h: Rename include guard.
11890         * arch/amd64.h: Add include guard.
11891         * arch/aarch64-insn.h: Rename include guard.
11892         * arch-utils.h: Rename include guard.
11893         * annotate.h: Add include guard.
11894         * amd64-darwin-tdep.h: Rename include guard.
11895         * aarch64-linux-tdep.h: Add include guard.
11896         * aarch64-fbsd-tdep.h: Add include guard.
11897         * aarch32-linux-nat.h: Add include guard.
11898
11899 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11900
11901         * macrotab.c (macro_define_internal): New function that
11902         factorizes macro_define_object_internal and macro_define_function
11903         code.
11904         (macro_define_object_internal): Use macro_define_internal.
11905         (macro_define_function): Likewise.
11906
11907 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11908
11909         * macrocmd.c (extract_identifier): Return
11910         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11911         callers.
11912
11913 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11914
11915         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11916
11917 2019-02-05  Tom Tromey  <tom@tromey.com>
11918
11919         * target.c (target_stack::unpush): Move assertion earlier.
11920
11921 2019-01-30  Tom Tromey  <tom@tromey.com>
11922
11923         PR python/23615:
11924         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11925         (gdbpy_parse_and_eval): Likewise.
11926         * python/python-internal.h (gdbpy_allow_threads): New class.
11927
11928 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11929
11930         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11931         (aarch64_fbsd_fpregmap): Move earlier.
11932         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11933         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11934         instead of individual calls to trad_frame_set_reg_addr.
11935         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11936         earlier.
11937         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11938         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11939         instead of individual calls to trad_frame_set_reg_addr.
11940
11941 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11942
11943         * CONTRIBUTE: Replace contribution list with wiki link.
11944
11945 2019-01-25  Tom Tromey  <tom@tromey.com>
11946
11947         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11948
11949 2019-01-25  Tom Tromey  <tom@tromey.com>
11950
11951         * xtensa-linux-nat.c: Fix common/ includes.
11952         * xml-support.h: Fix common/ includes.
11953         * xml-support.c: Fix common/ includes.
11954         * x86-linux-nat.c: Fix common/ includes.
11955         * windows-nat.c: Fix common/ includes.
11956         * varobj.h: Fix common/ includes.
11957         * varobj.c: Fix common/ includes.
11958         * value.c: Fix common/ includes.
11959         * valops.c: Fix common/ includes.
11960         * utils.c: Fix common/ includes.
11961         * unittests/xml-utils-selftests.c: Fix common/ includes.
11962         * unittests/utils-selftests.c: Fix common/ includes.
11963         * unittests/unpack-selftests.c: Fix common/ includes.
11964         * unittests/tracepoint-selftests.c: Fix common/ includes.
11965         * unittests/style-selftests.c: Fix common/ includes.
11966         * unittests/string_view-selftests.c: Fix common/ includes.
11967         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11968         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11969         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11970         * unittests/rsp-low-selftests.c: Fix common/ includes.
11971         * unittests/parse-connection-spec-selftests.c: Fix common/
11972         includes.
11973         * unittests/optional-selftests.c: Fix common/ includes.
11974         * unittests/offset-type-selftests.c: Fix common/ includes.
11975         * unittests/observable-selftests.c: Fix common/ includes.
11976         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11977         * unittests/memrange-selftests.c: Fix common/ includes.
11978         * unittests/memory-map-selftests.c: Fix common/ includes.
11979         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11980         * unittests/function-view-selftests.c: Fix common/ includes.
11981         * unittests/environ-selftests.c: Fix common/ includes.
11982         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11983         * unittests/common-utils-selftests.c: Fix common/ includes.
11984         * unittests/cli-utils-selftests.c: Fix common/ includes.
11985         * unittests/array-view-selftests.c: Fix common/ includes.
11986         * ui-file.c: Fix common/ includes.
11987         * tui/tui-io.c: Fix common/ includes.
11988         * tracepoint.h: Fix common/ includes.
11989         * tracepoint.c: Fix common/ includes.
11990         * tracefile-tfile.c: Fix common/ includes.
11991         * top.h: Fix common/ includes.
11992         * top.c: Fix common/ includes.
11993         * thread.c: Fix common/ includes.
11994         * target/waitstatus.h: Fix common/ includes.
11995         * target/waitstatus.c: Fix common/ includes.
11996         * target.h: Fix common/ includes.
11997         * target.c: Fix common/ includes.
11998         * target-memory.c: Fix common/ includes.
11999         * target-descriptions.c: Fix common/ includes.
12000         * symtab.h: Fix common/ includes.
12001         * symfile.c: Fix common/ includes.
12002         * stap-probe.c: Fix common/ includes.
12003         * spu-linux-nat.c: Fix common/ includes.
12004         * sparc-nat.c: Fix common/ includes.
12005         * source.c: Fix common/ includes.
12006         * solib.c: Fix common/ includes.
12007         * solib-target.c: Fix common/ includes.
12008         * ser-unix.c: Fix common/ includes.
12009         * ser-tcp.c: Fix common/ includes.
12010         * ser-pipe.c: Fix common/ includes.
12011         * ser-base.c: Fix common/ includes.
12012         * selftest-arch.c: Fix common/ includes.
12013         * s12z-tdep.c: Fix common/ includes.
12014         * rust-exp.y: Fix common/ includes.
12015         * rs6000-aix-tdep.c: Fix common/ includes.
12016         * riscv-tdep.c: Fix common/ includes.
12017         * remote.c: Fix common/ includes.
12018         * remote-notif.h: Fix common/ includes.
12019         * remote-fileio.h: Fix common/ includes.
12020         * remote-fileio.c: Fix common/ includes.
12021         * regcache.h: Fix common/ includes.
12022         * regcache.c: Fix common/ includes.
12023         * record-btrace.c: Fix common/ includes.
12024         * python/python.c: Fix common/ includes.
12025         * python/py-type.c: Fix common/ includes.
12026         * python/py-inferior.c: Fix common/ includes.
12027         * progspace.h: Fix common/ includes.
12028         * producer.c: Fix common/ includes.
12029         * procfs.c: Fix common/ includes.
12030         * proc-api.c: Fix common/ includes.
12031         * printcmd.c: Fix common/ includes.
12032         * ppc-linux-nat.c: Fix common/ includes.
12033         * parser-defs.h: Fix common/ includes.
12034         * osdata.c: Fix common/ includes.
12035         * obsd-nat.c: Fix common/ includes.
12036         * nat/x86-linux.c: Fix common/ includes.
12037         * nat/x86-linux-dregs.c: Fix common/ includes.
12038         * nat/x86-dregs.h: Fix common/ includes.
12039         * nat/x86-dregs.c: Fix common/ includes.
12040         * nat/ppc-linux.c: Fix common/ includes.
12041         * nat/mips-linux-watch.h: Fix common/ includes.
12042         * nat/mips-linux-watch.c: Fix common/ includes.
12043         * nat/linux-waitpid.c: Fix common/ includes.
12044         * nat/linux-ptrace.h: Fix common/ includes.
12045         * nat/linux-ptrace.c: Fix common/ includes.
12046         * nat/linux-procfs.c: Fix common/ includes.
12047         * nat/linux-personality.c: Fix common/ includes.
12048         * nat/linux-osdata.c: Fix common/ includes.
12049         * nat/linux-namespaces.c: Fix common/ includes.
12050         * nat/linux-btrace.h: Fix common/ includes.
12051         * nat/linux-btrace.c: Fix common/ includes.
12052         * nat/fork-inferior.c: Fix common/ includes.
12053         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12054         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12055         * nat/aarch64-linux.c: Fix common/ includes.
12056         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12057         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12058         * namespace.h: Fix common/ includes.
12059         * mips-linux-tdep.c: Fix common/ includes.
12060         * minsyms.c: Fix common/ includes.
12061         * mi/mi-parse.h: Fix common/ includes.
12062         * mi/mi-main.c: Fix common/ includes.
12063         * mi/mi-cmd-env.c: Fix common/ includes.
12064         * memrange.h: Fix common/ includes.
12065         * memattr.c: Fix common/ includes.
12066         * maint.h: Fix common/ includes.
12067         * maint.c: Fix common/ includes.
12068         * main.c: Fix common/ includes.
12069         * machoread.c: Fix common/ includes.
12070         * location.c: Fix common/ includes.
12071         * linux-thread-db.c: Fix common/ includes.
12072         * linux-nat.c: Fix common/ includes.
12073         * linux-fork.c: Fix common/ includes.
12074         * inline-frame.c: Fix common/ includes.
12075         * infrun.c: Fix common/ includes.
12076         * inflow.c: Fix common/ includes.
12077         * inferior.h: Fix common/ includes.
12078         * inferior.c: Fix common/ includes.
12079         * infcmd.c: Fix common/ includes.
12080         * inf-ptrace.c: Fix common/ includes.
12081         * inf-child.c: Fix common/ includes.
12082         * ia64-linux-nat.c: Fix common/ includes.
12083         * i387-tdep.c: Fix common/ includes.
12084         * i386-tdep.c: Fix common/ includes.
12085         * i386-linux-tdep.c: Fix common/ includes.
12086         * i386-linux-nat.c: Fix common/ includes.
12087         * i386-go32-tdep.c: Fix common/ includes.
12088         * i386-fbsd-tdep.c: Fix common/ includes.
12089         * i386-fbsd-nat.c: Fix common/ includes.
12090         * guile/scm-type.c: Fix common/ includes.
12091         * guile/guile.c: Fix common/ includes.
12092         * go32-nat.c: Fix common/ includes.
12093         * gnu-nat.c: Fix common/ includes.
12094         * gdbthread.h: Fix common/ includes.
12095         * gdbarch-selftests.c: Fix common/ includes.
12096         * gdb_usleep.c: Fix common/ includes.
12097         * gdb_select.h: Fix common/ includes.
12098         * gdb_bfd.c: Fix common/ includes.
12099         * gcore.c: Fix common/ includes.
12100         * fork-child.c: Fix common/ includes.
12101         * findvar.c: Fix common/ includes.
12102         * fbsd-nat.c: Fix common/ includes.
12103         * event-top.c: Fix common/ includes.
12104         * event-loop.c: Fix common/ includes.
12105         * dwarf2read.c: Fix common/ includes.
12106         * dwarf2loc.c: Fix common/ includes.
12107         * dwarf2-frame.c: Fix common/ includes.
12108         * dwarf-index-cache.c: Fix common/ includes.
12109         * dtrace-probe.c: Fix common/ includes.
12110         * disasm-selftests.c: Fix common/ includes.
12111         * defs.h: Fix common/ includes.
12112         * csky-tdep.c: Fix common/ includes.
12113         * cp-valprint.c: Fix common/ includes.
12114         * cp-support.h: Fix common/ includes.
12115         * cp-support.c: Fix common/ includes.
12116         * corelow.c: Fix common/ includes.
12117         * completer.h: Fix common/ includes.
12118         * completer.c: Fix common/ includes.
12119         * compile/compile.c: Fix common/ includes.
12120         * compile/compile-loc2c.c: Fix common/ includes.
12121         * compile/compile-cplus-types.c: Fix common/ includes.
12122         * compile/compile-cplus-symbols.c: Fix common/ includes.
12123         * command.h: Fix common/ includes.
12124         * cli/cli-dump.c: Fix common/ includes.
12125         * cli/cli-cmds.c: Fix common/ includes.
12126         * charset.c: Fix common/ includes.
12127         * build-id.c: Fix common/ includes.
12128         * btrace.h: Fix common/ includes.
12129         * btrace.c: Fix common/ includes.
12130         * breakpoint.h: Fix common/ includes.
12131         * breakpoint.c: Fix common/ includes.
12132         * ax.h:
12133         (enum agent_op): Fix common/ includes.
12134         * ax-general.c (struct aop_map): Fix common/ includes.
12135         * ax-gdb.c: Fix common/ includes.
12136         * auxv.c: Fix common/ includes.
12137         * auto-load.c: Fix common/ includes.
12138         * arm-tdep.c: Fix common/ includes.
12139         * arch/riscv.c: Fix common/ includes.
12140         * arch/ppc-linux-common.c: Fix common/ includes.
12141         * arch/i386.c: Fix common/ includes.
12142         * arch/arm.c: Fix common/ includes.
12143         * arch/arm-linux.c: Fix common/ includes.
12144         * arch/arm-get-next-pcs.c: Fix common/ includes.
12145         * arch/amd64.c: Fix common/ includes.
12146         * arch/aarch64.c: Fix common/ includes.
12147         * arch/aarch64-insn.c: Fix common/ includes.
12148         * arch-utils.c: Fix common/ includes.
12149         * amd64-windows-tdep.c: Fix common/ includes.
12150         * amd64-tdep.c: Fix common/ includes.
12151         * amd64-sol2-tdep.c: Fix common/ includes.
12152         * amd64-obsd-tdep.c: Fix common/ includes.
12153         * amd64-nbsd-tdep.c: Fix common/ includes.
12154         * amd64-linux-tdep.c: Fix common/ includes.
12155         * amd64-linux-nat.c: Fix common/ includes.
12156         * amd64-fbsd-tdep.c: Fix common/ includes.
12157         * amd64-fbsd-nat.c: Fix common/ includes.
12158         * amd64-dicos-tdep.c: Fix common/ includes.
12159         * amd64-darwin-tdep.c: Fix common/ includes.
12160         * agent.c: Fix common/ includes.
12161         * ada-lang.h: Fix common/ includes.
12162         * ada-lang.c: Fix common/ includes.
12163         * aarch64-tdep.c: Fix common/ includes.
12164
12165 2019-01-25  Tom Tromey  <tom@tromey.com>
12166
12167         * common/create-version.sh: Use common/version.h.
12168
12169 2019-01-24  Pedro Alves  <palves@redhat.com>
12170
12171         * infrun.c (signal_stop, signal_print, signal_program)
12172         (signal_catch, signal_pass): Now arrays instead of pointers.
12173         (update_signals_program_target, do_target_resume)
12174         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12175         * linux-nat.c (linux_nat_target::pass_signals)
12176         (linux_nat_target::create_inferior, linux_nat_target::attach):
12177         Adjust.
12178         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12179         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12180         * procfs.c (procfs_target::pass_signals): Adjust.
12181         * record-full.c (record_full_target::resume): Adjust.
12182         * remote.c (remote_target::pass_signals)
12183         (remote_target::program_signals): Adjust.
12184         * target-debug.h (target_debug_print_signals): Now takes a
12185         gdb::array_view as parameter.  Adjust.
12186         * target.h (target_ops) <pass_signals, program_signals>: Replace
12187         pointer and length parameters with gdb::array_view.
12188         (target_pass_signals, target_program_signals): Likewise.
12189         * target-delegates.c: Regenerate.
12190
12191 2019-01-24  Pedro Alves  <palves@redhat.com>
12192
12193         * common/forward-scope-exit.h
12194         (forward_scope_exit::forward_scope_exit): Pass arguments to
12195         m_bind_function directly, instead of creating a std::bind and
12196         copying that.
12197
12198 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12199
12200         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12201         for static members.
12202         (pass_in_v_vfp_candidate): Likewise.
12203
12204 2019-01-23  Tom Tromey  <tom@tromey.com>
12205             Pedro Alves  <palves@redhat.com>
12206
12207         * regcache.c (class regcache_invalidator): Remove.
12208         (regcache::raw_write): Use make_scope_exit.
12209
12210 2019-01-23  Tom Tromey  <tom@tromey.com>
12211
12212         * ui-out.h (class ui_out_emit_type): Update comment.
12213
12214 2019-01-23  Tom Tromey  <tom@tromey.com>
12215
12216         * infrun.c (fetch_inferior_event): Update comment.
12217
12218 2019-01-23  Tom Tromey  <tom@tromey.com>
12219             Pedro Alves  <palves@redhat.com>
12220
12221         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12222         parameter.
12223         (fetch_inferior_event): Use SCOPE_EXIT.
12224
12225
12226 2019-01-23  Tom Tromey  <tom@tromey.com>
12227             Pedro Alves  <palves@redhat.com>
12228
12229         * infrun.c (disable_thread_events): Delete.
12230         (stop_all_threads): Use SCOPE_EXIT.
12231
12232 2019-01-23  Tom Tromey  <tom@tromey.com>
12233             Pedro Alves  <palves@redhat.com>
12234
12235         * symfile.c: Include forward-scope-exit.h.
12236         (clear_symtab_users_cleanup): Replace forward declaration with
12237         a FORWARD_SCOPE_EXIT.
12238         (syms_from_objfile_1): Use the forward_scope_exit and
12239         gdb::optional instead of cleanup_function.
12240         (reread_symbols): Use the forward_scope_exit instead of
12241         cleanup_function.
12242         (clear_symtab_users_cleanup): Remove function.
12243
12244 2019-01-23  Tom Tromey  <tom@tromey.com>
12245             Pedro Alves  <palves@redhat.com>
12246
12247         * linux-nat.c: Include scope-exit.h.
12248         (cleanup_target_stop): Remove.
12249         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12250         SCOPE_EXIT.
12251
12252 2019-01-23  Tom Tromey  <tom@tromey.com>
12253             Pedro Alves  <palves@redhat.com>
12254
12255         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12256         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12257
12258 2019-01-23  Tom Tromey  <tom@tromey.com>
12259             Andrew Burgess  <andrew.burgess@embecosm.com>
12260             Pedro Alves  <palves@redhat.com>
12261
12262         * infrun.c (fetch_inferior_event): Use scope_exit.
12263         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12264         * top.c (execute_command): Use scope_exit.
12265         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12266         * utils.c (do_bpstat_clear_actions_cleanup)
12267         (make_bpstat_clear_actions_cleanup): Remove.
12268
12269 2019-01-23  Tom Tromey  <tom@tromey.com>
12270             Pedro Alves  <palves@redhat.com>
12271
12272         * infrun.c: Include "common/scope-exit.h"
12273         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12274         (wait_for_inferior): Use SCOPE_EXIT.
12275         (fetch_inferior_event): Use scope_exit.
12276
12277 2019-01-23  Tom Tromey  <tom@tromey.com>
12278             Pedro Alves  <palves@redhat.com>
12279
12280         * breakpoint.c (create_breakpoint): Remove cleanup.
12281
12282 2019-01-23  Tom Tromey  <tom@tromey.com>
12283             Andrew Burgess  <andrew.burgess@embecosm.com>
12284             Pedro Alves  <palves@redhat.com>
12285
12286 2019-01-23  Pedro Alves  <palves@redhat.com>
12287
12288         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12289
12290 2019-01-23  Pedro Alves  <palves@redhat.com>
12291             Andrew Burgess  <andrew.burgess@embecosm.com>
12292
12293         * gdbthread.h: Include "common/forward-scope-exit.h".
12294         (scoped_finish_thread_state): Redefine custom class in terms of
12295         forward_scope_exit.
12296
12297 2019-01-23  Pedro Alves  <palves@redhat.com>
12298             Andrew Burgess  <andrew.burgess@embecosm.com>
12299
12300         * common/forward-scope-exit.h: New file.
12301
12302 2019-01-23  Pedro Alves  <palves@redhat.com>
12303             Andrew Burgess  <andrew.burgess@embecosm.com>
12304             Tom Tromey  <tom@tromey.com>
12305
12306         * common/scope-exit.h: New file.
12307
12308 2019-01-23  Pedro Alves  <palves@redhat.com>
12309
12310         * common/preprocessor.h (ESC): Rename to ...
12311         (ESC_PARENS): ... this.
12312         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12313         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12314
12315 2019-01-23  Tom Tromey  <tom@tromey.com>
12316
12317         * language.h (class scoped_switch_to_sym_language_if_auto):
12318         Initialize m_lang in both cases.
12319
12320 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12321
12322         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12323         with XCNEW.
12324
12325 2019-01-22  Tom Tromey  <tom@tromey.com>
12326
12327         * corelow.c: Do not include sys/file.h.
12328
12329 2019-01-22  Tom Tromey  <tom@tromey.com>
12330
12331         * tui/tui-wingeneral.h: Include gdb_curses.h.
12332
12333 2019-01-22  Tom Tromey  <tom@tromey.com>
12334
12335         * source-cache.h (class source_cache) <get_source_lines,
12336         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12337
12338 2019-01-22  Tom Tromey  <tom@tromey.com>
12339
12340         * remote-fileio.h (struct remote_target): Declare.
12341
12342 2019-01-22  Tom Tromey  <tom@tromey.com>
12343
12344         * python/py-arch.c: Do not include py-ref.h.
12345         * python/py-bpevent.c: Do not include py-ref.h.
12346         * python/py-cmd.c: Do not include py-ref.h.
12347         * python/py-continueevent.c: Do not include py-ref.h.
12348         * python/py-event.h: Do not include py-ref.h.
12349         * python/py-evtregistry.c: Do not include py-ref.h.
12350         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12351         * python/py-frame.c: Do not include py-ref.h.
12352         * python/py-framefilter.c: Do not include py-ref.h.
12353         * python/py-function.c: Do not include py-ref.h.
12354         * python/py-infevents.c: Do not include py-ref.h.
12355         * python/py-linetable.c: Do not include py-ref.h.
12356         * python/py-objfile.c: Do not include py-ref.h.
12357         * python/py-param.c: Do not include py-ref.h.
12358         * python/py-prettyprint.c: Do not include py-ref.h.
12359         * python/py-progspace.c: Do not include py-ref.h.
12360         * python/py-symbol.c: Do not include py-ref.h.
12361         * python/py-symtab.c: Do not include py-ref.h.
12362         * python/py-type.c: Do not include py-ref.h.
12363         * python/py-unwind.c: Do not include py-ref.h.
12364         * python/py-utils.c: Do not include py-ref.h.
12365         * python/py-value.c: Do not include py-ref.h.
12366         * python/py-varobj.c: Do not include py-ref.h.
12367         * python/py-xmethods.c: Do not include py-ref.h.
12368         * python/python.c: Do not include py-ref.h.
12369         * varobj.c: Do not include py-ref.h.
12370
12371 2019-01-22  Tom Tromey  <tom@tromey.com>
12372
12373         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12374         keyword for bcache.
12375
12376 2019-01-22  Tom Tromey  <tom@tromey.com>
12377
12378         * compile/compile-cplus-types.c: Remove a comment by #include.
12379
12380 2019-01-22  Tom Tromey  <tom@tromey.com>
12381
12382         * compile/gcc-c-plugin.h: Include compile-internal.h.
12383
12384 2019-01-22  Tom Tromey  <tom@tromey.com>
12385
12386         * stabsread.c (EXTERN): Do not define.
12387         (symnum, next_symbol_text_func, processing_gcc_compilation)
12388         (within_function, global_sym_chain, global_stabs)
12389         (previous_stab_code, this_object_header_files)
12390         (n_this_object_header_files)
12391         (n_allocated_this_object_header_files): Define.
12392         * stabsread.h (EXTERN): Never define.  Use "extern".
12393
12394 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12395
12396         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12397         history_value.
12398
12399 2019-01-21  Tom Tromey  <tom@tromey.com>
12400
12401         * ui-out.c: Fix includes.
12402         * tui/tui-source.c: Fix includes.
12403         * target.c: Fix includes.
12404         * remote.c: Fix includes.
12405         * regcache.c: Fix includes.
12406         * python/py-block.c: Fix includes.
12407         * printcmd.c: Fix includes.
12408         * or1k-tdep.c: Fix includes.
12409         * mi/mi-main.c: Fix includes.
12410         * m32r-tdep.c: Fix includes.
12411         * csky-tdep.c: Fix includes.
12412         * compile/compile-cplus-types.c: Fix includes.
12413         * cli/cli-interp.c: Fix includes.
12414
12415 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12416
12417         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12418         for padding.
12419
12420 2019-01-16  Tom Tromey  <tom@tromey.com>
12421
12422         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12423         earlier.
12424         (struct objfile) <msymbols_range>: Move from top level.
12425         <msymbols>: New method.
12426         (class objfile_msymbols): Remove.
12427         * symtab.c (default_collect_symbol_completion_matches_break_on):
12428         Update.
12429         * symmisc.c (dump_msymbols): Update.
12430         * stabsread.c (scan_file_globals): Update.
12431         * objc-lang.c (info_selectors_command, info_classes_command)
12432         (find_methods): Update.
12433         * minsyms.c (find_solib_trampoline_target): Update.
12434         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12435         * coffread.c (coff_symfile_read): Update.
12436         * ada-lang.c (ada_lookup_simple_minsym)
12437         (ada_collect_symbol_completion_matches): Update.
12438
12439 2019-01-16  Tom Tromey  <tom@tromey.com>
12440
12441         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12442         type.  Remove no-argument constructor.
12443         <iterator::operator++>: Simplify.
12444         <begin>: Update.
12445         <end>: Use minimal_symbol_count.
12446
12447 2019-01-16  Tom Tromey  <tom@tromey.com>
12448
12449         * objfiles.h (struct objfile) <psymtabs>: New method.
12450         (class objfile_psymtabs): Remove.
12451         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12452         typedef.
12453         <range>: New method.
12454         (require_partial_symbols): Change return type.
12455         * psymtab.c (require_partial_symbols)
12456         (psym_expand_symtabs_matching): Update.
12457         * mdebugread.c (parse_partial_symbols): Update.
12458         * dbxread.c (dbx_end_psymtab): Update.
12459
12460 2019-01-15  Tom Tromey  <tom@tromey.com>
12461
12462         * symtab.c (lookup_objfile_from_block)
12463         (lookup_symbol_in_objfile_symtabs)
12464         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12465         (find_line_symtab, info_sources_command)
12466         (default_collect_symbol_completion_matches_break_on)
12467         (make_source_files_completion_list): Update.
12468         * symmisc.c (print_objfile_statistics, dump_objfile)
12469         (maintenance_print_symbols, maintenance_info_symtabs)
12470         (maintenance_check_symtabs, maintenance_info_line_tables):
12471         Update.
12472         * source.c (select_source_symtab)
12473         (forget_cached_source_info_for_objfile): Update.
12474         * objfiles.h (class objfile_compunits): Remove.
12475         (struct objfile) <compunits_range>: New typedef.
12476         (compunits): New method.
12477         * objfiles.c (objfile_relocate1): Update.
12478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12479         * maint.c (count_symtabs_and_blocks): Update.
12480         * linespec.c (iterate_over_all_matching_symtabs): Update.
12481         * cp-support.c (add_symbol_overload_list_qualified): Update.
12482         * coffread.c (coff_symtab_read): Update.
12483         * ada-lang.c (add_nonlocal_symbols)
12484         (ada_collect_symbol_completion_matches)
12485         (ada_add_global_exceptions): Update.
12486
12487 2019-01-15  Tom Tromey  <tom@tromey.com>
12488
12489         * progspace.h (program_space) <objfiles_safe_range>: New
12490         typedef.
12491         <objfiles_safe>: New method.
12492         * objfiles.h (class all_objfiles_safe): Remove.
12493         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12494         * jit.c (jit_inferior_exit_hook): Update.
12495
12496 2019-01-17  Tom Tromey  <tom@tromey.com>
12497
12498         * progspace.h (program_space) <objfiles_range>: New typedef.
12499         <objfiles>: New method.
12500         <objfiles_head>: Rename from objfiles.
12501         (object_files): Update.
12502         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12503         * guile/scm-pretty-print.c
12504         (ppscm_find_pretty_printer_from_objfiles): Update.
12505         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12506         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12507         Update.
12508         * python/py-progspace.c (pspy_get_objfiles): Update.
12509         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12510         Update.
12511         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12512         (objfpy_lookup_objfile_by_build_id): Update.
12513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12514         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12515         Update.
12516         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12517         (expand_symtab_containing_pc, lookup_objfile_from_block)
12518         (lookup_static_symbol, basic_lookup_transparent_type)
12519         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12520         (find_line_symtab, info_sources_command)
12521         (default_collect_symbol_completion_matches_break_on)
12522         (make_source_files_completion_list, find_main_name): Update.
12523         * symmisc.c (print_symbol_bcache_statistics)
12524         (print_objfile_statistics, maintenance_print_symbols)
12525         (maintenance_print_msymbols, maintenance_print_objfiles)
12526         (maintenance_info_symtabs, maintenance_check_symtabs)
12527         (maintenance_expand_symtabs, maintenance_info_line_tables):
12528         Update.
12529         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12530         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12531         (map_overlay_command, unmap_overlay_command)
12532         (simple_overlay_update, expand_symtabs_matching)
12533         (map_symbol_filenames): Update.
12534         * symfile-debug.c (set_debug_symfile): Update.
12535         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12536         Update.
12537         * source.c (select_source_symtab, forget_cached_source_info):
12538         Update.
12539         * solib.c (solib_read_symbols): Update.
12540         * solib-spu.c (append_ocl_sos): Update.
12541         * psymtab.c (maintenance_print_psymbols)
12542         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12543         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12544         * printcmd.c (info_symbol_command): Update.
12545         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12546         Update.
12547         * objfiles.h (class all_objfiles): Remove.
12548         * objfiles.c (have_partial_symbols, have_full_symbols)
12549         (have_minimal_symbols, qsort_cmp, update_section_map)
12550         (shared_objfile_contains_address_p)
12551         (default_iterate_over_objfiles_in_search_order): Update.
12552         * objc-lang.c (info_selectors_command, info_classes_command)
12553         (find_methods): Update.
12554         * minsyms.c (find_solib_trampoline_target): Update.
12555         * maint.c (maintenance_info_sections)
12556         (maintenance_translate_address, count_symtabs_and_blocks):
12557         Update.
12558         * main.c (captured_main_1): Update.
12559         * linux-thread-db.c (try_thread_db_load_from_pdir)
12560         (has_libpthread): Update.
12561         * linespec.c (iterate_over_all_matching_symtabs)
12562         (search_minsyms_for_name): Update.
12563         * jit.c (jit_find_objf_with_entry_addr): Update.
12564         * hppa-tdep.c (find_unwind_entry)
12565         (hppa_lookup_stub_minimal_symbol): Update.
12566         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12567         Update.
12568         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12569         (elf_gnu_ifunc_resolve_by_got): Update.
12570         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12571         * dwarf-index-write.c (save_gdb_index_command): Update.
12572         * cp-support.c (add_symbol_overload_list_qualified): Update.
12573         * breakpoint.c (create_overlay_event_breakpoint)
12574         (create_longjmp_master_breakpoint)
12575         (create_std_terminate_master_breakpoint)
12576         (create_exception_master_breakpoint): Update.
12577         * blockframe.c (find_pc_partial_function): Update.
12578         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12579         (ada_collect_symbol_completion_matches)
12580         (ada_add_global_exceptions): Update.
12581
12582 2019-01-17  Tom Tromey  <tom@tromey.com>
12583
12584         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12585         declare VEC.
12586         (solib_target_parse_libraries): Change return type.
12587         (library_list_start_segment, library_list_start_section)
12588         (library_list_end_library, library_list_start_library); Update.
12589         (solib_target_free_library_list): Remove.
12590         (solib_target_parse_libraries): Remove cleanup.  Change return
12591         type.
12592         (solib_target_current_sos): Update.
12593
12594 2019-01-17  Tom Tromey  <tromey@bapiya>
12595
12596         * valprint.c: Replace "the the" with "the".
12597         * symtab.c: Replace "the the" with "the".
12598         * solib.c: Replace "the the" with "the".
12599         * solib-dsbt.c: Replace "the the" with "the".
12600         * linespec.c: Replace "the the" with "the".
12601         * dwarf2loc.h: Replace "the the" with "the".
12602         * amd64-windows-tdep.c: Replace "the the" with "the".
12603         * aarch64-tdep.c: Replace "the the" with "the".
12604
12605 2019-01-16  Keith Seitz  <keiths@redhat.com>
12606
12607         PR gdb/23773
12608         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12609         <builder>: Rename to ..
12610         <m_builder>: ... this and make private.
12611         (dwarf2_cu::get_builder): New method.  Change all users of
12612         `builder' to use this method.
12613         (dwarf2_start_symtab): Move to ...
12614         (dwarf2_cu::start_symtab): ... here.  Update all callers
12615         (setup_type_unit_groups): Move to ...
12616         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12617         callers.
12618         (dwarf2_cu::reset_builder): New method.
12619         (process_full_compunit, process_full_type_unit): Use
12620         dwarf2_cu::reset_builder.
12621         (follow_die_offset): Record the ancestor CU if it is different
12622         from the followed DIE's CU.
12623         (follow_die_sig_1): Likewise.
12624
12625 2019-01-15  Tom Tromey  <tom@tromey.com>
12626
12627         * remote.c (class remote_state) <buf>: Now a char_vector.
12628         <buf_size>: Remove.
12629         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12630         parameter.
12631         (remote_target::getpkt_or_notif_sane_1)
12632         (remote_target::getpkt_sane)
12633         (remote_target::getpkt_or_notif_sane): Likewise.
12634         (class remote_target) <putpkt>: New overload.
12635         (remote_target::read_frame): Change type of "buf_p".  Remove
12636         sizeof_p parameter.
12637         (packet_ok): New overload.
12638         (packet_check_result): New overload.
12639         Update all uses.
12640
12641 2019-01-14  Tom Tromey  <tom@tromey.com>
12642
12643         * remote-notif.c (handle_notification, remote_notif_ack)
12644         (remote_notif_parse): Make "buf" const.
12645         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12646         const.
12647         (remote_notif_parse, remote_notif_ack, handle_notification):
12648         Likewise.
12649         * remote.c (remote_notif_stop_parse): Make "buf" const.
12650         (remote_target::remote_parse_stop_reply): Make "buf" const.
12651         (remote_notif_stop_ack): Make "buf" const.
12652
12653 2019-01-14  Tom Tromey  <tom@tromey.com>
12654
12655         * remote.c (remote_console_output): Make parameter const.
12656
12657 2019-01-14  Tom Tromey  <tom@tromey.com>
12658
12659         * target-debug.h (target_debug_print_signals): Constify.
12660         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12661         * procfs.c (procfs_target::pass_signals): Update.
12662         * linux-nat.c (linux_nat_target::pass_signals): Update.
12663         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12664         * target-delegates.c: Rebuild.
12665         * remote.c (remote_target::program_signals): Update.
12666         (remote_target::pass_signals): Update.
12667         * target.c (target_pass_signals): Constify argument.
12668         (target_program_signals): Likewise.
12669         * target.h (struct target_ops) <pass_signals, program_signals>:
12670         Constify argument.
12671         (target_pass_signals, target_program_signals): Constify argument.
12672
12673 2019-01-14  Tom Tromey  <tom@tromey.com>
12674
12675         PR tui/28819:
12676         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12677
12678 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12679
12680         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12681         field.
12682         * rs6000-tdep.c: Include reggroups.h.
12683         (IS_V_ALIAS_PSEUDOREG): Define.
12684         (rs6000_register_name): Return names for the "vX" aliases.
12685         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12686         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12687         aliases.  Call default_register_reggroup_p for all other
12688         pseudo-registers.
12689         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12690         New functions.
12691         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12692         Handle "vX" aliases.
12693         (v_alias_pseudo_register_collect): New function.
12694         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12695         (rs6000_gdbarch_init): Initialize "vX" aliases as
12696         pseudo-registers.  Restore registration of
12697         rs6000_pseudo_register_reggroup_p with
12698         set_tdesc_pseudo_register_reggroup_p.
12699
12700 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12701
12702         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12703         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12704         set_gdbarch_num_pseudo_regs.
12705
12706 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12707
12708         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12709         Remove arg prefixname, add do_set and do_show.
12710         Add member functions set_list and show_list.
12711         * cli/cli-style.c (class cli_style_option): Update accordingly.
12712         (style_set_list): Move to file scope.
12713         (style_show_list): Likewise.
12714         (set_style): Call help_list.
12715         (show_style): Call cmd_show_list.
12716         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12717         Update to use the new macro.
12718
12719 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12720
12721         * ada-lang.c (_initialize_ada_language): Expand the help text
12722         for the "catch exception" command.
12723
12724 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12725
12726         * symtab.c (matching_obj_sections): Initialize obj,
12727         declare it closer to its usage.
12728
12729 2019-01-10  Tom Tromey  <tom@tromey.com>
12730
12731         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12732         (basic_inf_threads_range): Remove.
12733         (inf_threads_range, inf_non_exited_threads_range)
12734         (safe_inf_threads_range): Use next_adapter.
12735
12736 2019-01-10  Keith Seitz  <keiths@redhat.com>
12737
12738         PR gdb/23712
12739         PR symtab/23010
12740         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12741         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12742
12743 2019-01-10  Keith Seitz  <keiths@redhat.com>
12744
12745         PR gdb/23712
12746         PR symtab/23010
12747         * dictionary.c (pending_to_vector): Remove.
12748         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12749         Remove _1 suffix, replacing functions of the same name.  Update
12750         all callers.
12751         (dict_create_hashed, dict_create_hashed_expandable)
12752         (dict_create_linear, dict_create_linear_expandable, dict_free)
12753         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12754         Make functions static.
12755
12756 2019-01-10  Keith Seitz  <keiths@redhat.com>
12757
12758         PR gdb/23712
12759         PR symtab/23010
12760         * dictionary.h (struct dictionary): Replace declaration with
12761         multidictionary.
12762         (dict_create_hashed, dict_create_hashed_expandable)
12763         (dict_create_linear, dict_create_linear_expandable)
12764         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12765         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12766         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12767         taking multidictionary argument.
12768         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12769         * block.h (struct block) <dict>: Change to multidictionary
12770         and rename `multidict'.
12771         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12772         symmisc.c: Update all dictionary references to multidictionary.
12773
12774 2019-01-10  Keith Seitz  <keiths@redhat.com>
12775
12776         PR gdb/23712
12777         PR symtab/23010
12778         * dictionary.c: Include unordered_map.
12779         (pending_to_vector): New function.
12780         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12781         Rewrite the non-"_1" functions to take vector instead
12782         of linked list.
12783         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12784         "new" _1 versions of the same name.
12785         (multidictionary): Define.
12786         (std::hash<enum language): New definition.
12787         (collate_pending_symbols_by_language, mdict_create_hashed)
12788         (mdict_create_hashed_expandable, mdict_create_linear)
12789         (mdict_create_linear_expandable, mdict_free)
12790         (find_language_dictionary, create_new_language_dictionary)
12791         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12792         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12793         (mdict_size, mdict_empty): New functions.
12794         * dictionary.h (mdict_iterator): Define.
12795
12796 2019-01-10  Pedro Alves  <palves@redhat.com>
12797
12798         * breakpoint.c (read_uploaded_action)
12799         (create_tracepoint_from_upload): Adjust to use
12800         gdb::unique_xmalloc_ptr.
12801         * ctf.c (ctf_write_uploaded_tp):
12802         (SET_ARRAY_FIELD): Use emplace_back.
12803         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12804         * tracefile-tfile.c (tfile_write_uploaded_tp):
12805         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12806         gdb::unique_xmalloc_ptr.
12807         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12808         at_string, cond_string, cmd_strings>: Replace char pointers
12809         with gdb::unique_xmalloc_ptr.
12810
12811 2019-01-10  Pedro Alves  <palves@redhat.com>
12812
12813         * solib-target.c (library_list_start_library): Don't xstrdup name.
12814
12815 2019-01-10  Pedro Alves  <palves@redhat.com>
12816
12817         * mdebugread.c (parse_partial_symbols): Use
12818         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12819
12820 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12821
12822         * linux-fork.c (scoped_switch_fork_info)
12823         <~scoped_switch_fork_info>: Fix incorrect variable name.
12824
12825 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12826
12827         * linux-fork.c (scoped_switch_fork_info)
12828         <scoped_switch_fork_info>: Make explicit.
12829         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12830
12831 2019-01-10  Tom Tromey  <tom@tromey.com>
12832
12833         * objfiles.h (objfile::reset_psymtabs): Update.
12834         * objfiles.c (objfile::objfile): Update.
12835         * psymtab.h (psymtab_storage::obstack): Update.
12836         (psymtab_storage::m_obstack): Use gdb::optional.
12837         (class psymtab_storage): Update comment.  Remove objfile
12838         parameter.
12839         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12840
12841 2019-01-10  Tom Tromey  <tom@tromey.com>
12842
12843         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12844         <free_psymtabs>: Now private.
12845         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12846         (allocate_psymtab): Use new method.
12847
12848 2019-01-10  Tom Tromey  <tom@tromey.com>
12849
12850         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12851         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12852         * mdebugread.c (parse_partial_symbols): Use
12853         allocate_dependencies.
12854         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12855         allocate_dependencies.
12856         (process_psymtab_comp_unit_reader)
12857         (build_type_psymtab_dependencies): Likewise.
12858         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12859
12860 2019-01-10  Tom Tromey  <tom@tromey.com>
12861
12862         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12863         PSYMBOL_SET_LANGUAGE.
12864         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12865
12866 2019-01-10  Tom Tromey  <tom@tromey.com>
12867
12868         * psymtab.h (psymtab_storage::obstack): New method.
12869         <m_obstack>: Rename from obstack; now private.
12870         * psymtab.c (psymtab_storage): Update.
12871         * dwarf2read.c (create_addrmap_from_index)
12872         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12873         Update.
12874
12875 2019-01-10  Tom Tromey  <tom@tromey.com>
12876
12877         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12878         * objfiles.h (objfile::reset_psymtabs): New method.
12879
12880 2019-01-10  Tom Tromey  <tom@tromey.com>
12881
12882         * symmisc.c (print_symbol_bcache_statistics): Update.
12883         (print_objfile_statistics): Update.
12884         * symfile.c (reread_symbols): Update.
12885         * psymtab.h (class psymtab_storage): New.
12886         * psymtab.c (psymtab_storage): New constructor.
12887         (~psymtab_storage): New destructor.
12888         (require_partial_symbols): Update.
12889         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12890         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12891         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12892         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12893         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12894         (start_psymtab_common, end_psymtab_common)
12895         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12896         (allocate_psymtab): Update.
12897         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12898         Update.
12899         (dump_psymtab_addrmap, maintenance_print_psymbols)
12900         (maintenance_check_psymtabs): Update.
12901         (class objfile_psymtabs): Move to objfiles.h.
12902         * psympriv.h (discard_psymtab): Now inline.
12903         (psymtab_discarder::psymtab_discarder): Update.
12904         (psymtab_discarder::~psymtab_discarder): Update.
12905         (ALL_OBJFILE_PSYMTABS): Rewrite.
12906         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12907         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12908         Remove fields.
12909         <partial_symtabs>: New field.
12910         (class objfile_psymtabs): Move from psymtab.h.  Update.
12911         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12912         psymbol_cache.
12913         (objfile::~objfile): Don't destroy psymbol_cache.
12914         * mdebugread.c (parse_partial_symbols): Update.
12915         * dwarf2read.c (create_addrmap_from_index)
12916         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12917         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12918         (add_partial_subprogram, dwarf2_ranges_read): Update.
12919         * dwarf-index-write.c (write_address_map)
12920         (write_one_signatured_type, recursively_write_psymbols)
12921         (class debug_names, class debug_names, write_psymtabs_to_index):
12922         Update.
12923
12924 2019-01-10  Tom Tromey  <tom@tromey.com>
12925
12926         * symtab.h (SYMBOL_SET_NAMES): Update.
12927         (symbol_set_names): Update.
12928         (MSYMBOL_SET_NAMES): Update.
12929         * symtab.c (symbol_set_names): Change argument to be an
12930         objfile_per_bfd_storage.
12931         * psymtab.c (add_psymbol_to_bcache): Update.
12932         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12933
12934 2019-01-10  Tom Tromey  <tom@tromey.com>
12935
12936         * symtab.c (create_demangled_names_hash): Change argument to be an
12937         objfile_per_bfd_storage.
12938         (symbol_set_names): Update.
12939
12940 2019-01-10  Tom Tromey  <tom@tromey.com>
12941
12942         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12943         init_psymbol_list.
12944         * psymtab.c (init_psymbol_list): Do nothing if already called.
12945         * psympriv.h (init_psymbol_list): Add comment.
12946         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12947         init_psymbol_list.
12948         * dbxread.c (dbx_symfile_read): Unconditionally call
12949         init_psymbol_list.
12950
12951 2019-01-10  Tom Tromey  <tom@tromey.com>
12952
12953         * xcoffread.c (scan_xcoff_symtab): Update.
12954         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12955         "where".
12956         * mdebugread.c (parse_partial_symbols)
12957         (handle_psymbol_enumerators): Update.
12958         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12959         * dbxread.c (read_dbx_symtab): Update.
12960         * psympriv.h (psymbol_placement): New enum.
12961         (add_psymbol_to_list): Update.
12962
12963 2019-01-10  Tom Tromey  <tom@tromey.com>
12964
12965         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12966         static_psymbols parameters.
12967         (scan_xcoff_symtab): Update.
12968         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12969         static_psymbols parameters.
12970         * psympriv.h (start_psymtab_common): Update.
12971         * mdebugread.c (parse_partial_symbols): Update.
12972         * dwarf2read.c (create_partial_symtab): Update.
12973         * dbxread.c (read_dbx_symtab): Update.
12974         (start_psymtab): Remove global_psymbols and static_psymbols
12975         parameters.
12976
12977 2019-01-10  Tom Tromey  <tom@tromey.com>
12978
12979         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12980         * psymtab.c (allocate_psymtab): Add comment.
12981         * psympriv.h (allocate_psymtab): Add comment.
12982         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12983         initializations.
12984         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12985
12986 2019-01-10  Tom Tromey  <tom@tromey.com>
12987
12988         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12989         Don't declare.
12990         * mipsread.c: Include mdebugread.h.
12991         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12992         Declare.
12993         * elfread.c: Include mdebugread.h.
12994
12995 2019-01-09  Tom Tromey  <tom@tromey.com>
12996
12997         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12998         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12999         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13000         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13001         (psym_lookup_symbol, psym_find_last_source_symtab)
13002         (psym_forget_cached_source_info, psym_print_stats)
13003         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13004         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13005         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13006         (psym_find_compunit_symtab_by_address)
13007         (maintenance_print_psymbols, maintenance_info_psymtabs)
13008         (maintenance_check_psymtabs): Use ranged for.
13009         * psymtab.h (class objfile_psymtabs): New.
13010         (require_partial_symbols): Return objfile_psymtabs.
13011         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13012
13013 2019-01-09  Tom Tromey  <tom@tromey.com>
13014
13015         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13016         (find_pc_mapped_section, list_overlays_command)
13017         (map_overlay_command, unmap_overlay_command)
13018         (simple_overlay_update): Use all_objfiles.
13019         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13020         * printcmd.c (info_symbol_command): Use all_objfiles.
13021         * objfiles.h (ALL_OBJSECTIONS): Remove.
13022         * maint.c (maintenance_translate_address): Use all_objfiles.
13023         * gcore.c (gcore_create_callback): Use all_objfiles.
13024         (objfile_find_memory_regions): Likewise.
13025
13026 2019-01-09  Tom Tromey  <tom@tromey.com>
13027
13028         * symtab.c (find_line_symtab, info_sources_command)
13029         (make_source_files_completion_list): Use objfile_compunits.
13030         * source.c (select_source_symtab): Use objfile_compunits.
13031         * objfiles.h (struct objfile): Update comment.
13032         (ALL_OBJFILES): Remove.
13033         (ALL_FILETABS): Remove.
13034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13035         objfile_compunits.
13036
13037 2019-01-09  Tom Tromey  <tom@tromey.com>
13038
13039         * symmisc.c (print_objfile_statistics, dump_objfile)
13040         (maintenance_print_symbols): Use compunit_filetabs.
13041         * source.c (forget_cached_source_info_for_objfile): Use
13042         compunit_filetabs.
13043         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13044         (ALL_FILETABS): Use compunit_filetabs.
13045         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13046         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13047
13048 2019-01-09  Tom Tromey  <tom@tromey.com>
13049
13050         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13051         (compunit_filetabs): New.
13052         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13053         compunit_filetabs.
13054         (info_sources_command, make_source_files_completion_list): Remove
13055         declaration.
13056         * symmisc.c (print_objfile_statistics, dump_objfile)
13057         (maintenance_print_symbols): Remove declaration.
13058         (maintenance_info_symtabs): Use compunit_filetabs.
13059         (maintenance_info_line_tables): Likewise.
13060         * source.c (select_source_symtab): Change local variable name.
13061         (forget_cached_source_info_for_objfile): Remove declaration.
13062         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13063         * objfiles.c (objfile_relocate1): Remove declaration.
13064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13065         declaration.
13066         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13067         * coffread.c (coff_symtab_read): Remove declaration.
13068         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13069         compunit_filetabs.
13070
13071 2019-01-09  Tom Tromey  <tom@tromey.com>
13072
13073         * symtab.c (lookup_objfile_from_block)
13074         (find_pc_sect_compunit_symtab, search_symbols)
13075         (default_collect_symbol_completion_matches_break_on): Use
13076         objfile_compunits.
13077         * objfiles.h (ALL_COMPUNITS): Remove.
13078         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13079         * cp-support.c (add_symbol_overload_list_qualified): Use
13080         objfile_compunits.
13081         * ada-lang.c (ada_collect_symbol_completion_matches)
13082         (ada_add_global_exceptions): Use objfile_compunits.
13083
13084 2019-01-09  Tom Tromey  <tom@tromey.com>
13085
13086         * source.c (select_source_symtab)
13087         (forget_cached_source_info_for_objfile): Remove declaration.
13088         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13089         declaration.
13090         * maint.c (count_symtabs_and_blocks): Remove declaration.
13091         * cp-support.c (add_symbol_overload_list_qualified): Remove
13092         declaration.
13093         * coffread.c (coff_symtab_read): Remove declaration.
13094         * symtab.c (lookup_symbol_in_objfile_symtabs)
13095         (basic_lookup_transparent_type_1): Use objfile_compunits.
13096         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13097         (info_sources_command, search_symbols)
13098         (default_collect_symbol_completion_matches_break_on)
13099         (make_source_files_completion_list): Remove declaration.
13100         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13101         (ada_collect_symbol_completion_matches)
13102         (ada_add_global_exceptions): Remove declaration.
13103         * linespec.c (iterate_over_all_matching_symtabs): Use
13104         objfile_compunits.
13105         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13106         (class objfile_compunits): New.
13107         (ALL_COMPUNITS): Use objfile_compunits.
13108         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13109         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13110         objfile_compunits.
13111         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13112
13113 2019-01-09  Tom Tromey  <tom@tromey.com>
13114
13115         * symtab.c (search_symbols)
13116         (default_collect_symbol_completion_matches_break_on): Use
13117         objfile_msymbols.
13118         * ada-lang.c (ada_lookup_simple_minsym)
13119         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13120         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13121         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13122         objfile_msymbols.
13123         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13124         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13125         * objc-lang.c (find_methods): Use objfile_msymbols.
13126         (info_selectors_command, info_classes_command): Likewise.
13127         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13128         * objfiles.h (class objfile_msymbols): New.
13129         (ALL_OBJFILE_MSYMBOLS): Remove.
13130         (ALL_MSYMBOLS): Remove.
13131
13132 2019-01-09  Tom Tromey  <tom@tromey.com>
13133
13134         * common/next-iterator.h (next_adapter): Add Iterator template
13135         parameter.
13136         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13137         (class all_objfiles_safe): New.
13138         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13139         * objfiles.c (put_objfile_before): Update comment.
13140         (add_separate_debug_objfile): Likewise.
13141         (free_all_objfiles): Use all_objfiles_safe.
13142         (objfile_purge_solibs): Likewise.
13143
13144 2019-01-09  Tom Tromey  <tom@tromey.com>
13145
13146         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13147         (expand_symtab_containing_pc, lookup_static_symbol)
13148         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13149         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13150         all_objfiles.
13151         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13152         * breakpoint.c (create_overlay_event_breakpoint)
13153         (create_longjmp_master_breakpoint)
13154         (create_std_terminate_master_breakpoint)
13155         (create_exception_master_breakpoint): Use all_objfiles.
13156         * linux-thread-db.c (try_thread_db_load_from_pdir)
13157         (has_libpthread): Use all_objfiles.
13158         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13159         * linespec.c (iterate_over_all_matching_symtabs)
13160         (search_minsyms_for_name): Use all_objfiles.
13161         * maint.c (maintenance_info_sections): Use all_objfiles.
13162         * main.c (captured_main_1): Use all_objfiles.
13163         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13164         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13165         * guile/scm-pretty-print.c
13166         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13167         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13168         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13169         (maintenance_print_msymbols): Use all_objfiles.
13170         * source.c (select_source_symtab): Use all_objfiles.
13171         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13172         * symfile.c (remove_symbol_file_command)
13173         (expand_symtabs_matching, map_symbol_filenames): Use
13174         all_objfiles.
13175         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13176         all_objfiles.
13177         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13178         * objc-lang.c (find_methods): Use all_objfiles.
13179         * objfiles.c (have_partial_symbols, have_full_symbols)
13180         (have_minimal_symbols, qsort_cmp)
13181         (default_iterate_over_objfiles_in_search_order): Use
13182         all_objfiles.
13183         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13184         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13185         (maintenance_check_psymtabs): Use all_objfiles.
13186         (ALL_PSYMTABS): Remove.
13187         * compile/compile-object-run.c (do_module_cleanup): Use
13188         all_objfiles.
13189         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13190         * cp-support.c (add_symbol_overload_list_qualified): Use
13191         all_objfiles.
13192         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13193         Use all_objfiles.
13194         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13195         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13196         all_objfiles.
13197         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13198         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13199         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13200         Uses all_objfiles.
13201         * solib.c (solib_read_symbols): Use all_objfiles
13202
13203 2019-01-09  Tom Tromey  <tom@tromey.com>
13204
13205         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13206         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13207         all_objfiles.
13208         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13209         * symmisc.c (print_symbol_bcache_statistics)
13210         (print_objfile_statistics, maintenance_print_objfiles)
13211         (maintenance_info_symtabs, maintenance_check_symtabs)
13212         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13213         all_objfiles.
13214         * source.c (forget_cached_source_info): Use all_objfiles.
13215         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13216         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13217         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13218         * objfiles.c (update_section_map): Use all_objfiles.
13219         (shared_objfile_contains_address_p): Likewise.
13220         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13221         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13222
13223 2019-01-09  Tom Tromey  <tom@tromey.com>
13224
13225         * common/next-iterator.h: New file.
13226         * objfiles.h (class all_objfiles): New.
13227         (struct objfile_iterator): New.
13228
13229 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13230
13231         * NEWS: Move the description of the changed "frame", "select-frame",
13232          and "info frame" commands to the Changed commands section.
13233
13234 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13235
13236         * gdbtypes.c (check_stub_method_group): Remove handling of old
13237         mangling schemes.
13238         * linespec.c (find_methods): Likewise.
13239         * stabsread.c (read_member_functions): Likewise.
13240         * valops.c (search_struct_method): Likewise.
13241         (value_struct_elt_for_reference): Likewise.
13242         * NEWS: Mention this change.
13243
13244 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13245
13246         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13247         print_source_lines.
13248         * source.c (print_source_lines_base): Update line number check.
13249         (print_source_lines): New function.
13250         (source_lines_range::source_lines_range): New function.
13251         * source.h (class source_lines_range): New class.
13252         (print_source_lines): New declaration.
13253
13254 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13255
13256         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13257
13258 2019-01-08  Tom Tromey  <tom@tromey.com>
13259             Simon Marchi  <simon.marchi@ericsson.com>
13260
13261         PR gdb/24060
13262         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13263         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13264         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13265         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13266         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13267         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13268
13269 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13270
13271         * source.c (select_source_symtab): Move header comment to
13272         declaration in source.h.
13273         (forget_cached_source_info_for_objfile): Likewise.
13274         (forget_cached_source_info): Likewise.
13275         (identify_source_line): Likewise.
13276         * source.h (identify_source_line): Move declaration from symtab.h
13277         and add comment from source.c
13278         (print_source_lines): Likewise.
13279         (forget_cached_source_info_for_objfile): Likewise.
13280         (forget_cached_source_info): Likewise.
13281         (select_source_symtab): Likewise.
13282         (enum print_source_lines_flag): Move definition from symtab.h.
13283         * symtab.h (identify_source_line): Move declaration to source.h.
13284         (print_source_lines): Likewise.
13285         (forget_cached_source_info_for_objfile): Likewise.
13286         (forget_cached_source_info): Likewise.
13287         (select_source_symtab): Likewise.
13288         (enum print_source_lines_flag): Move definition to source.h.
13289         * tui/tui-hooks.c: Add 'source.h' include.
13290
13291 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13292
13293         * source.c (print_source_lines_base): Handle requests to print
13294         reverse line number sequences, and guard against empty lines
13295         string.
13296
13297 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13298
13299         * source.c (print_source_lines_base): Fix skip of '\r' if next
13300         character is '\n'.
13301
13302 2019-01-06  Tom Tromey  <tom@tromey.com>
13303
13304         * c-exp.y (struct c_parse_state) <macro_original_text,
13305         expansion_obstack>: New member.
13306         (macro_original_text, expansion_obstack): Remove globals.
13307         (scan_macro_expansion, scanning_macro_expansion)
13308         (finished_macro_expansion): Update.
13309         (scan_macro_cleanup): Remove.
13310         (yylex, c_parse): Update.
13311
13312 2019-01-06  Tom Tromey  <tom@tromey.com>
13313
13314         * c-exp.y (struct c_parse_state) <strings>: New member.
13315         (operator_stoken): Update.
13316
13317 2019-01-06  Tom Tromey  <tom@tromey.com>
13318
13319         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13320         (union type_stack_elt) <typelist_val>: Now a pointer to
13321         std::vector.
13322         (type_stack_cleanup): Don't declare.
13323         (push_typelist): Update.
13324         * parse.c (pop_typelist): Return a std::vector.
13325         (push_typelist): Take a std::vector.
13326         (follow_types): Update.  Do not free args.
13327         (type_stack_cleanup): Remove.
13328         * c-exp.y (struct c_parse_state): New.
13329         (cpstate): New global.
13330         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13331         (nonempty_typelist): Update.
13332         (func_mod): Create a new vector.
13333         (c_parse): Create a c_parse_state.
13334         (check_parameter_typelist): Do not delete params.
13335         (function_method): Update.  Do not delete type_list.
13336
13337 2019-01-06  Tom Tromey  <tom@tromey.com>
13338
13339         PR gdb/28155:
13340         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13341         check_typedef.
13342         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13343         (print_return_value): Likewise.
13344
13345 2019-01-05  Tom Tromey  <tom@tromey.com>
13346
13347         * contrib/cleanup_check.py: Remove.
13348         * contrib/gcc-with-excheck: Remove.
13349         * contrib/exsummary.py: Remove.
13350         * contrib/excheck.py: Remove.
13351
13352 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13353
13354         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13355         NULL. Initialize tpprev to NULL instead of assigning it
13356         to NULL on the next statement.
13357         * windows-nat.c (windows_delete_thread): Remove check for
13358         main_thread_id before printing thread exit notifications.
13359         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13360         Remove thread ID check against main_thread_id.
13361         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13362         windows_delete_thread.
13363         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13364
13365 2019-01-04  Tom Tromey  <tom@tromey.com>
13366
13367         * compile/compile.c (_initialize_compile): Use upper case for
13368         metasyntactic variables.
13369         * symmisc.c (_initialize_symmisc): Use upper case for
13370         metasyntactic variables.
13371         * psymtab.c (_initialize_psymtab): Use upper case for
13372         metasyntactic variables.
13373         * demangle.c (demangle_command): Use upper case for metasyntactic
13374         variables.
13375         (_initialize_demangler): Likewise.
13376         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13377         variables.
13378
13379 2019-01-03  Tom Tromey  <tom@tromey.com>
13380
13381         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13382
13383 2019-01-03  Tom Tromey  <tom@tromey.com>
13384
13385         * python/py-symtab.c (salpy_str): Update.
13386         (struct salpy_sal_object) <symtab>: Now a PyObject.
13387         (salpy_dealloc): Update.
13388         (del_objfile_sal): Use gdbpy_ref.
13389
13390 2019-01-03  Tom Tromey  <tom@tromey.com>
13391
13392         * python/py-type.c (convert_field): Use new_reference.  Return
13393         gdbpy_ref.
13394         (make_fielditem): Return gdbpy_ref.
13395         (typy_fields): Update.
13396         (typy_getitem): Update.
13397         (field_name): Return gdbpy_ref.  Use new_reference.
13398         (typy_iterator_iternext): Update.
13399
13400 2019-01-03  Tom Tromey  <tom@tromey.com>
13401
13402         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13403
13404 2019-01-03  Tom Tromey  <tom@tromey.com>
13405
13406         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13407         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13408         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13409         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13410         (pspy_set_type_printers): Likewise.
13411         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13412         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13413         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13414         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13415         (objfpy_set_type_printers): Likewise.
13416
13417 2019-01-03  Tom Tromey  <tom@tromey.com>
13418
13419         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13420         (gdbpy_print_stack): Use gdbpy_err_fetch.
13421         * python/python-internal.h (class gdbpy_err_fetch): New class.
13422         (class gdbpy_enter) <m_error_type, m_error_value,
13423         m_error_traceback>: Remove.
13424         <m_error>: New member.
13425         (gdbpy_exception_to_string): Don't declare.
13426         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13427         * python/py-value.c (convert_value_from_python): Use
13428         gdbpy_err_fetch.
13429         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13430         gdbpy_exception_to_string.
13431         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13432         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13433         gdbpy_err_fetch.
13434
13435 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13436
13437         * linux-nat.c (delete_lwp_cleanup): Delete.
13438         (struct lwp_deleter): New struct.
13439         (lwp_info_up): New typedef.
13440         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13441         lwp_info_up.
13442
13443 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13444
13445         * linux-fork.c (class scoped_switch_fork_info): New class.
13446         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13447
13448 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13449
13450         * valops.c (find_overload_match): Remove use of null_cleanup, and
13451         calls to do_cleanups.
13452
13453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13454
13455         * compile/compile-cplus-types.c
13456         (compile_cplus_instance::decl_name): Handle changes to
13457         cp_func_name.
13458         * cp-support.c (cp_func_name): Update header comment, update
13459         return type.
13460         * cp-support.h (cp_func_name): Update return type in declaration.
13461         * valops.c (find_overload_match): Move temp_func local to top
13462         level of function and change its type.  Use temp_func to hold and
13463         delete temporary string obtained from cp_func_name.
13464
13465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13466
13467         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13468         gdb::char_vector, remove cleanup, and update uses of `msg`.
13469
13470 2019-01-03  Jim Wilson  <jimw@sifive.com>
13471
13472         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13473
13474 2019-01-02  Tom Tromey  <tom@tromey.com>
13475
13476         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13477         (tdesc_parse_xml): Remove cleanups.
13478         * target-descriptions.h (make_cleanup_free_target_description):
13479         Don't declare.
13480         (target_desc_deleter): New struct.
13481         (target_desc_up): New typedef.
13482         * target-descriptions.c (target_desc_deleter::operator()): Rename
13483         from free_target_description.
13484         (make_cleanup_free_target_description): Remove.
13485
13486 2019-01-02  Tom Tromey  <tom@tromey.com>
13487
13488         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13489         constructor, destructor.
13490         (linespec_parser): Remove typedef.
13491         (~linespec_parser): Rename from linespec_parser_delete.
13492         (linespec_lex_to_end, linespec_complete_label)
13493         (linespec_complete): Update.
13494         (decode_line_full): Remove cleanups.
13495         (decode_line_1): Update.
13496
13497 2019-01-02  Tom Tromey  <tom@tromey.com>
13498
13499         * python/python-internal.h (inferior_to_inferior_object): Change
13500         return type.
13501         * python/py-exitedevent.c (create_exited_event_object): Update.
13502         * python/py-inferior.c (inferior_to_inferior_object): Return
13503         gdbpy_ref.
13504         (python_new_inferior, python_inferior_deleted)
13505         (thread_to_thread_object, delete_thread_object)
13506         (build_inferior_list, gdbpy_selected_inferior): Update.
13507         * python/py-infthread.c (create_thread_object): Update.  Also fail
13508         if inferior_to_inferior_object fails.
13509
13510 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13511
13512         * inferior.h (class inferior) <displaced_step_state>: New field.
13513         * infrun.h (struct displaced_step_state): Move here from
13514         infrun.c.  Initialize fields, add constructor.
13515         <inf>: Remove field.
13516         <reset>: New method.
13517         * infrun.c (struct displaced_step_inferior_state): Move to
13518         infrun.h.
13519         (displaced_step_inferior_states): Remove.
13520         (get_displaced_stepping_state): Adust.
13521         (displaced_step_in_progress_any_inferior): Adjust.
13522         (displaced_step_in_progress_thread): Adjust.
13523         (displaced_step_in_progress): Adjust.
13524         (add_displaced_stepping_state): Remove.
13525         (get_displaced_step_closure_by_addr): Adjust.
13526         (remove_displaced_stepping_state): Remove.
13527         (infrun_inferior_exit): Call displaced_step_state.reset.
13528         (use_displaced_stepping): Don't check for NULL.
13529         (displaced_step_prepare_throw): Call
13530         get_displaced_stepping_state.
13531         (displaced_step_fixup): Don't check for NULL.
13532         (prepare_for_detach): Don't check for NULL.
13533
13534 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13535
13536         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13537          in case of call that did not complete.
13538
13539 2019-01-02  Andrey Utkin  <autkin@undo.io>
13540
13541         * symfile.c (find_separate_debug_file): Fix search of debug files for
13542         remote debuggee.
13543
13544 2019-01-02  Tom Tromey  <tom@tromey.com>
13545
13546         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13547         indentation.
13548         * python/py-frame.c (frapy_older): Remove cast.
13549         (frapy_newer): Likewise.
13550         * python/py-breakpoint.c (local_setattro): Remove cast.
13551         * python/py-arch.c (archpy_name): Remove local variable.
13552         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13553
13554 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13555
13556         * unittests/basic_string_view/element_access/char/empty.cc:
13557         Fix year range in copyright header.
13558
13559 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13560
13561         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13562         Delete.
13563         <operator==>: Update with for removed field.
13564         <hash>: Likewise.
13565         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13566         <isa_features>: ...this.
13567         <abi_features>: New field.
13568         (riscv_isa_flen): Update comment.
13569         (riscv_abi_xlen): New declaration.
13570         (riscv_abi_flen): New declaration.
13571         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13572         isa_features.
13573         (riscv_abi_xlen): New function.
13574         (riscv_isa_flen): Update to get answer from isa_features.
13575         (riscv_abi_flen): New function.
13576         (riscv_has_fp_abi): Update to get answer from abi_features.
13577         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13578         xlen and flen.
13579         (riscv_call_info) <xlen, flen>: Update comment.
13580         (riscv_call_arg_struct): Remove invalid assertions
13581         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13582         is removed.
13583         (riscv_gdbarch_init): Gather isa features and abi features
13584         separately, ensure both match on the gdbarch when reusing an old
13585         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13586         a target with 64-bit float hardware.
13587
13588 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13589
13590         * source.c (search_command_helper): Stop reverse search
13591         when line 1 has been searched.
13592
13593 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13594
13595         * record-full.c (record_full_base_target::close): Rewrite
13596         record_full_core_buf_list free logic.
13597
13598 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13599
13600         * break-catch-syscall.c (print_one_catch_syscall): xfree
13601         the last text.
13602
13603 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13604
13605         * top.c (print_gdb_version): Update Copyright year in version
13606         message.
13607
13608 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13609
13610         Update copyright year range in all GDB files.
13611
13612 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13613
13614         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13615
13616 For older changes see ChangeLog-2018.
13617 \f
13618 Local Variables:
13619 mode: change-log
13620 left-margin: 8
13621 fill-column: 74
13622 version-control: never
13623 coding: utf-8
13624 End:
13625