gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
   4         Declare.
   5         (tui_check_register_values): Don't declare.
   6         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
   7         from tui_check_register_values.
   8         * tui/tui-hooks.c (tui_register_changed): Update.
   9
  10 2019-08-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-regs.c (tui_reg_layout): Move later.
  13         (tui_show_registers): Don't enable TUI mode or change layout.
  14
  15 2019-08-20  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-regs.h (struct tui_data_item_window)
  18         <~tui_data_item_window>: Remove.
  19         <content>: Now a unique_xmalloc_ptr.
  20         * tui/tui-regs.c (tui_register_format): Return a
  21         unique_xmalloc_ptr.
  22         (tui_get_register): Update.
  23         (~tui_data_item_window): Remove.
  24         (tui_data_window::display_registers_from, tui_display_register):
  25         Update.
  26         * tui/tui-io.h (tui_expand_tabs): Update.
  27         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  28         Remove "col" parameter.
  29
  30 2019-08-20  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  33         field.
  34         * tui/tui-regs.c (~tui_data_item_window): Update.
  35
  36 2019-08-20  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  39         earlier.
  40
  41 2019-08-20  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  44
  45 2019-08-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-source.h (struct tui_source_window): Update.
  48         * tui/tui-regs.c (tui_show_registers): Update.
  49         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  50         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  51         (NO_REGS_STRING): Remove defines.
  52
  53 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  54
  55         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  56         unnecessary thread walk if remote doesn't support the packet.
  57
  58 2019-08-19  Tom Tromey  <tromey@adacore.com>
  59
  60         * python/py-value.c (value_has_field): Fix indentation.
  61
  62 2019-08-19  Tom Tromey  <tromey@adacore.com>
  63
  64         * printcmd.c (do_one_display, info_display_command): Update.
  65         * block.h (contained_in): Return bool.  Add allow_nested
  66         parameter.
  67         * block.c (contained_in): Return bool.  Add allow_nested
  68         parameter.
  69
  70 2019-08-19  Tom Tromey  <tom@tromey.com>
  71
  72         * configure: Rebuild.
  73         * configure.ac: Disallow the combination of -static-libstdc++ and
  74         source highlight.
  75         * source-cache.c (get_language_name): Handle rust.
  76         (source_cache::get_source_lines): Ignore highlighting exceptions.
  77
  78 2019-08-16  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  81         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  82         (struct tui_source_window_base) <make_visible, refresh_window,
  83         resize>: Remove methods.
  84         <execution_info>: Remove field.
  85         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  86         (tui_show_source_line, tui_source_window_base)
  87         (~tui_source_window_base): Update.
  88         (tui_source_window_base::resize)
  89         (tui_source_window_base::make_visible)
  90         (tui_source_window_base::refresh_window): Remove.
  91         (tui_source_window_base::update_exec_info): Update.
  92         * tui/tui-source.c (tui_source_window::set_contents): Update.
  93         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  94
  95 2019-08-16  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  98         deprecated_query_hook.
  99
 100 2019-08-16  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 103         (tui_update_source_windows_with_line): Update.
 104         * tui/tui-source.h (struct tui_source_window)
 105         <show_symtab_source>: Declare.
 106         (tui_show_symtab_source): Don't declare.
 107         * tui/tui-source.c (tui_show_symtab_source): Rename from
 108         tui_show_symtab_source.
 109
 110 2019-08-16  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.h (struct tui_source_window_base)
 113         <set_contents>: Declare.
 114         * tui/tui-winsource.c
 115         (tui_source_window_base::update_source_window_as_is): Update.
 116         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 117         Declare.
 118         (tui_set_source_content): Don't declare.
 119         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 120         tui_set_source_content.
 121         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 122         Declare.
 123         (tui_set_disassem_content): Don't declare.
 124         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 125         tui_set_disassem_content.
 126
 127 2019-08-16  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.h (struct tui_source_window_base)
 130         <update_breakpoint_info>: Declare.
 131         (tui_update_breakpoint_info): Don't declare.
 132         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 133         (tui_update_all_breakpoint_info): Update.
 134         (tui_source_window_base::update_breakpoint_info): Rename from
 135         tui_update_breakpoint_info.
 136         (tui_source_window_base::update_exec_info): Update.
 137
 138 2019-08-16  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.h (struct tui_source_window_base)
 141         <update_source_window>: Declare.
 142         (tui_update_source_window): Don't declare.
 143         * tui/tui-winsource.c
 144         (tui_source_window_base::update_source_window): Rename from
 145         tui_update_source_window.
 146         (tui_source_window_base::rerender): Update.
 147         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 148         * tui/tui-disasm.c (tui_show_disassem)
 149         (tui_show_disassem_and_update_source)
 150         (tui_disasm_window::maybe_update): Update.
 151
 152 2019-08-16  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-winsource.h (struct tui_source_window_base)
 155         <update_source_window_as_is>: Declare.
 156         (tui_update_source_window_as_is): Don't declare.
 157         * tui/tui-winsource.c (tui_update_source_window): Update
 158         (tui_source_window_base::update_source_window_as_is): Rename from
 159         tui_update_source_window_as_is.
 160         (tui_source_window_base::refill): Update.
 161         * tui/tui-source.c (tui_show_symtab_source): Update.
 162         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 163         Update.
 164
 165 2019-08-16  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.h (tui_update_source_window)
 168         (tui_update_source_window_as_is): Remove "noerror" parameter.
 169         * tui/tui-winsource.c (tui_update_source_window)
 170         (tui_update_source_window_as_is): Remove "noerror" parameter.
 171         (tui_update_source_windows_with_addr)
 172         (tui_update_source_windows_with_line)
 173         (tui_source_window_base::rerender)
 174         (tui_source_window_base::refill): Update.
 175         * tui/tui-source.h (tui_set_source_content)
 176         (tui_show_symtab_source): Remove "noerror" parameter.
 177         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 178         parameter.
 179         (tui_show_symtab_source): Likewise.
 180         (tui_source_window::maybe_update): Update.
 181         * tui/tui-disasm.c (tui_show_disassem)
 182         (tui_show_disassem_and_update_source)
 183         (tui_disasm_window::do_scroll_vertical)
 184         (tui_disasm_window::maybe_update): Update.
 185
 186 2019-08-16  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui.c (tui_is_window_visible): Update.
 189         * tui/tui-wingeneral.c (tui_make_window)
 190         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 191         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 192         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 193         (tui_set_win_height_command, parse_scrolling_args): Update.
 194         * tui/tui-source.c (tui_source_window::style_changed): Update.
 195         * tui/tui-regs.c (tui_show_registers)
 196         (tui_data_window::first_data_item_displayed)
 197         (tui_data_window::delete_data_content_windows)
 198         (tui_check_register_values, tui_reg_command): Update.
 199         * tui/tui-disasm.c (tui_show_disassem): Update.
 200         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 201         method.
 202         <is_visible>: Remove field.
 203         * tui/tui-data.c (tui_next_win, tui_prev_win)
 204         (tui_delete_invisible_windows): Update.
 205
 206 2019-08-16  Tom Tromey  <tom@tromey.com>
 207
 208         * tui/tui-winsource.h (struct tui_source_window_base)
 209         <m_has_locator>: Remove.
 210         * tui/tui-layout.c (show_source_disasm_command, show_data)
 211         (show_source_or_disasm_and_command): Update.
 212
 213 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 214
 215         * NEWS (Other MI changes): New subsection.
 216         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 217         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 218         * arch-utils.c (default_get_pc_address_flags): New function.
 219         * arch-utils.h (default_get_pc_address_flags): New declaration.
 220         * gdbarch.sh: Add get_pc_address_flags.
 221         * gdbarch.c: Regenerate.
 222         * gdbarch.h: Likewise.
 223         * stack.c (print_pc): New function.
 224         (print_frame_info) (print_frame): Call print_pc.
 225
 226 2019-08-16  Tom de Vries  <tdevries@suse.de>
 227
 228         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 229         print_objfile_section_info.
 230
 231 2019-08-15  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 234         calling update_cmdwin_start_line.
 235         * tui/tui-winsource.h (struct tui_source_window_base)
 236         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 237         <rerender>: Declare.
 238         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 239         Call rerender.
 240         (tui_source_window_base::set_new_height): Remove.
 241         (tui_source_window_base::rerender): Rename from
 242         do_make_visible_with_new_height.
 243         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 244         resize method.
 245         (tui_win_info::make_invisible_and_set_new_height)
 246         (tui_win_info::make_visible_with_new_height): Remove.
 247         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 248         Declare.
 249         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 250         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 251         do_make_visible_with_new_height>: Don't declare.
 252         <rerender>: Declare.
 253         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 254         set_new_height.
 255         (tui_data_window::do_make_visible_with_new_height): Remove.
 256         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 257         call tui_show_locator_content.
 258         (tui_gen_win_info::resize): Call rerender.
 259         (show_source_or_disasm_and_command): Don't call
 260         tui_show_locator_content.
 261         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 262         method.
 263         (struct tui_win_info) <rerender>: Declare.
 264         <set_new_height, make_invisible_and_set_new_height,
 265         make_visible_with_new_height>: Don't declare.
 266         * tui/tui-data.c (tui_win_list::rerender): New method.
 267         * tui/tui-command.h (struct tui_cmd_window)
 268         <do_make_visible_with_new_height>: Don't declare.
 269         * tui/tui-command.c
 270         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 271
 272 2019-08-15  Tom Tromey  <tromey@adacore.com>
 273
 274         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 275         * ada-lang.c (ada_enum_name): Likewise.
 276
 277 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 280         leading underscore.
 281         (GdbOutputErrorFile): Likewise.
 282         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 283         accordingly.
 284         (execute_unwinders): Rename to have a leading underscore.
 285         (auto_load_packages): Likewise.
 286         (global scope): Adjust call to auto_load_packages accordingly.
 287         (GdbSetPythonDirectory): Likewise.
 288         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 289         instead of execute_unwinders.
 290
 291 2019-08-15  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 294         (show_data): Don't change window visibility.
 295         (tui_gen_win_info::resize): Remove special case for command
 296         window.  Use wresize, when available.
 297         (show_source_or_disasm_and_command): Don't change window
 298         visibility.
 299         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 300         <make_visible>: New method.
 301         * tui/tui-command.c (tui_cmd_window::resize): New method.
 302
 303 2019-08-15  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 306         (struct tui_source_windows): New.
 307         * tui/tui-winsource.c (tui_display_main): Update.
 308         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 309         (new_height_ok, parse_scrolling_args): Update.
 310         * tui/tui-layout.c (show_layout, show_data): Update.
 311         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 312         (tui_add_to_source_windows): Don't declare.
 313         * tui/tui-data.c (source_windows, tui_source_windows)
 314         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 315
 316 2019-08-15  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 319         Rename from reset.
 320         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 321         * tui/tui-layout.c (show_source_disasm_command, show_data):
 322         Update.
 323         (tui_gen_win_info::resize): Rename.
 324         (show_source_or_disasm_and_command): Update.
 325         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 326         reset.
 327
 328 2019-08-15  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 331         * tui/tui-interp.c (tui_interp::init): Don't call
 332         tui_initialize_static_data.
 333         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 334
 335 2019-08-15  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 338         examine tui_win_list.
 339
 340 2019-08-15  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 343         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 344         tui_clear_source_content.
 345         (tui_clear_source_content): Remove.
 346         (tui_source_window_base::do_erase_source_content): Hoist call to
 347         content.clear().
 348         * tui/tui-stack.c (tui_show_frame_info): Don't call
 349         tui_clear_source_content.
 350
 351 2019-08-15  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.h (struct tui_source_window_base)
 354         <do_erase_source_content>: New method.
 355         <erase_source_content>: New method.
 356         (tui_erase_source_content): Don't declare.
 357         * tui/tui-winsource.c (tui_clear_source_content): Update.
 358         (tui_source_window_base::do_erase_source_content): Rename from
 359         tui_erase_source_content.
 360         (tui_source_window_base::show_source_content): Update.
 361         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 362         * tui/tui-source.h (struct tui_source_window)
 363         <erase_source_content>: New method.
 364         * tui/tui-disasm.h (struct tui_disasm_window)
 365         <erase_source_content>: New method.
 366
 367 2019-08-15  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 370         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 371         constructor.
 372         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 373         * tui/tui-source.c (tui_set_source_content): Update.
 374         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 375
 376 2019-08-15  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 379         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 380         tui-source.c.
 381         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 382         Declare.
 383         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 384         method.
 385         (tui_source_window::maybe_update): Update.
 386
 387 2019-08-15  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 390         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 391         tui-disasm.c.
 392         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 393         Declare.
 394         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 395         method.
 396         (tui_disasm_window::maybe_update): Update.
 397
 398 2019-08-15  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-winsource.h (struct tui_source_window_base)
 401         <maybe_update>: Declare.
 402         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 403         method.
 404         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 405         Declare.
 406         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 407         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 408         Declare.
 409         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 410
 411 2019-08-15  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 414
 415 2019-08-15  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-wingeneral.c: Include tui-stack.h.
 418         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 419         (struct tui_locator_window): Move from tui-data.h.
 420         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 421         (tui_initialize_static_data): Move from tui-data.c.
 422         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 423         (struct tui_locator_window): Move to tui-stack.c.
 424         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 425         (tui_initialize_static_data): Move to tui-stack.c.
 426
 427 2019-08-15  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (show_source_disasm_command)
 430         (show_source_or_disasm_and_command): Use make_visible method, not
 431         tui_make_window.
 432         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 433         Remove.
 434
 435 2019-08-15  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-wingeneral.h (tui_make_window): Update.
 438         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 439         parameter.
 440         (tui_gen_win_info::make_visible): Update.
 441         * tui/tui-regs.c (tui_data_window::display_registers_from):
 442         Update.
 443         * tui/tui-layout.c (show_source_disasm_command)
 444         (show_source_or_disasm_and_command): Update.
 445         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 446         (enum tui_box): Remove.
 447         (struct tui_win_info) <can_box>: New method.
 448         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 449         method.
 450
 451 2019-08-15  Tom de Vries  <tdevries@suse.de>
 452
 453         * linux-nat-trad.c: Include gdbarch.h.
 454
 455 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 456
 457         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 458         register sizes.
 459
 460 2019-08-14  Tom Tromey  <tromey@adacore.com>
 461
 462         * darwin-nat.c: Include gdbarch.h.
 463         * darwin-nat-info.c: Include gdbarch.h.
 464
 465 2019-08-13  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 468         Remove.
 469         * tui/tui-data.c (tui_initialize_static_data): Update.
 470
 471 2019-08-13  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-winsource.h (struct tui_exec_info_window)
 474         <~tui_exec_info_window, maybe_allocate_content, get_content,
 475         m_content>: Remove.
 476         (struct tui_source_window_base) <set_exec_info_content,
 477         show_exec_info_content>: Don't declare.
 478         * tui/tui-winsource.c
 479         (tui_exec_info_window::maybe_allocate_content): Remove.
 480         (tui_source_window_base::update_exec_info): Rename from
 481         set_exec_info_content.
 482         (tui_source_window_base::show_exec_info_content)
 483         (tui_source_window_base::update_exec_info): Remove.
 484
 485 2019-08-13  Tom Tromey  <tom@tromey.com>
 486
 487         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 488         declare.
 489         * tui/tui-winsource.c (tui_update_source_window_as_is)
 490         (tui_update_source_windows_with_addr, tui_erase_source_content):
 491         Update.
 492         (tui_clear_exec_info_content): Remove.
 493
 494 2019-08-13  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 497         declare.
 498         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 499         call tui_erase_exec_info_content.
 500         (tui_clear_exec_info_content): Rename from
 501         tui_erase_exec_info_content.
 502         (tui_clear_exec_info_content): Delete.
 503
 504 2019-08-13  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-winsource.h (struct tui_source_window_base)
 507         <show_exec_info_content>: Declare.
 508         (tui_show_exec_info_content): Don't declare.
 509         * tui/tui-winsource.c
 510         (tui_source_window_base::show_exec_info_content): Rename from
 511         tui_show_exec_info_content.
 512         (tui_source_window_base::update_exec_info): Update.
 513
 514 2019-08-13  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 517         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 518         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 519         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 520         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 521         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 522         ... here.
 523
 524 2019-08-13  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-winsource.h (struct tui_source_window_base)
 527         <update_exec_info>: Declare.
 528         (tui_update_exec_info): Don't declare.
 529         * tui/tui-winsource.c (tui_update_source_window_as_is)
 530         (tui_source_window_base::refresh_all)
 531         (tui_update_all_breakpoint_info): Update.
 532         (tui_source_window_base::update_exec_info): Rename from
 533         tui_update_exec_info.
 534         * tui/tui-stack.c (tui_show_frame_info): Update.
 535
 536 2019-08-13  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-winsource.h (struct tui_source_window_base)
 539         <set_exec_info_content>: Declare.
 540         (tui_set_exec_info_content): Don't declare.
 541         * tui/tui-winsource.c
 542         (tui_source_window_base::set_exec_info_content): Rename from
 543         tui_set_exec_info_content.
 544         (tui_update_exec_info): Update.
 545
 546 2019-08-13  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-winsource.h (struct tui_source_window_base)
 549         <show_source_content>: Declare.
 550         (tui_show_source_content): Don't declare.
 551         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 552         (tui_source_window_base::show_source_content): Rename from
 553         tui_show_source_content.
 554         (tui_source_window_base::refresh_all): Update.
 555         * tui/tui-layout.c (show_source_disasm_command)
 556         (show_source_or_disasm_and_command): Update.
 557
 558 2019-08-13  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-winsource.c (tui_erase_source_content)
 561         (tui_show_source_content, tui_source_window_base::refresh_all):
 562         Update.
 563         * tui/tui-wingeneral.h
 564         (tui_check_and_display_highlight_if_needed): Don't declare.
 565         * tui/tui-wingeneral.c
 566         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 567         check_and_display_highlight_if_needed.
 568         * tui/tui-win.c (tui_rehighlight_all)
 569         (tui_win_info::make_visible_with_new_height): Update.
 570         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 571         (tui_data_window::erase_data_content)
 572         (tui_data_window::display_all_data): Update.
 573         * tui/tui-data.h (struct tui_win_info)
 574         <check_and_display_highlight_if_needed>: Declare.
 575
 576 2019-08-13  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-win.c (tui_resize_all): Call
 579         tui_delete_invisible_windows.
 580         * tui/tui-layout.c (show_layout): Call
 581         tui_delete_invisible_windows.
 582         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 583         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 584
 585 2019-08-13  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 588         tui_add_win_to_layout.
 589
 590 2019-08-13  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 593         * tui/tui-layout.c (tui_default_win_height): Now static.
 594
 595 2019-08-13  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 598         single switch.
 599         (show_source_disasm_command, show_source_or_disasm_and_command):
 600         Don't check current layout.
 601
 602 2019-08-13  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-wingeneral.c (make_all_visible): Remove.
 605         (tui_make_all_invisible): Simplify.
 606         * tui/tui-layout.c (tui_make_all_invisible): Move from
 607         tui-wingeneral.c; simplify.
 608         (show_layout): Hoist call to tui_make_all_invisible.
 609         (show_data): Don't call tui_make_all_invisible.
 610
 611 2019-08-13  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 614         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 615
 616 2019-08-13  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 619         tui-data.c.
 620         (show_source_disasm_command, show_data)
 621         (show_source_or_disasm_and_command): Don't use
 622         tui_set_current_layout_to.
 623         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 624         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 625         tui-layout.c.
 626         (tui_set_current_layout_to): Remove.
 627
 628 2019-08-13  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-layout.c (tui_set_layout): Update.
 631         * tui/tui-data.h (struct tui_layout_def): Remove.
 632         (tui_layout_def): Don't declare.
 633         * tui/tui-data.c (layout_def): Remove.
 634         (tui_layout_def): Remove.
 635
 636 2019-08-13  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (struct tui_source_window_base)
 639         <clear_detail>: No longer "override".
 640         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 641         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 642         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 643         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 644         Remove.
 645         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 646
 647 2019-08-13  Tom Tromey  <tromey@adacore.com>
 648
 649         * tracepoint.c: Don't include readline.h or history.h.
 650
 651 2019-08-12  Tom Tromey  <tom@tromey.com>
 652
 653         * configure: Rebuild.
 654         * configure.ac: Check for readline 7.
 655         * NEWS: Mention readline 7 requirement.
 656         * README: Update.
 657
 658 2019-08-12  Tom Tromey  <tom@tromey.com>
 659
 660         * mingw-hdep.c (gdb_select): Remove readline hack.
 661
 662 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 663
 664         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 665         when the function fails.
 666
 667 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 668
 669         * s390-tdep.c (s390_type_align): New function.
 670         (s390_gdbarch_init): Set it as type_align gdbarch method.
 671
 672 2019-08-09  Tom de Vries  <tdevries@suse.de>
 673
 674         PR gdb/24591
 675         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 676         pc_low with relocation offset.
 677
 678 2019-08-07  Tom Tromey  <tromey@adacore.com>
 679
 680         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 681         (print_frame_args): Update.
 682         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 683         Update.
 684         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 685         * frame.h (struct frame_arg): Add initializers.
 686         <error>: Now a unique_xmalloc_ptr.
 687
 688 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 689
 690         * NEWS: Expand the Pointer Authentication entry.
 691         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 692         (aarch64_frame_unmask_lr): ... to this.
 693         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 694         Call aarch64_frame_unmask_lr.
 695         * frame.c (struct frame_info): Add "masked" variable.
 696         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 697         (fprint_frame): Check for masked pc.
 698         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 699         declarations.
 700         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 701         * stack.c (print_frame): Check for masked pc.
 702
 703 2019-08-06  Tom Tromey  <tom@tromey.com>
 704
 705         * stabsread.c (patch_block_stabs, read_one_struct_field)
 706         (read_enum_type): Use obstack_strndup.
 707         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 708         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 709         * dwarf2read.c (guess_full_die_structure_name)
 710         (anonymous_struct_prefix): Use obstack_strndup.
 711         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 712         * c-exp.y (yylex): Use obstack_strndup.
 713         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 714         (write_var_or_type): Use obstack_strndup.
 715
 716 2019-08-06  Tom Tromey  <tom@tromey.com>
 717
 718         * symfile.c (reread_symbols): Use obstack_strdup.
 719         * stabsread.c (read_type): Use obstack_strdup.
 720         * gdb_obstack.h (obstack_strdup): New overload.
 721         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 722         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 723         (dwarf2_canonicalize_name): Use obstack_strdup.
 724         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 725         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 726         Use obstack_strdup.
 727
 728 2019-08-06  Tom Tromey  <tom@tromey.com>
 729
 730         * gdb_obstack.h (obstack_strdup): Define.
 731         * gdb_obstack.c (obstack_strdup): Don't define.
 732
 733 2019-08-06  Tom Tromey  <tom@tromey.com>
 734
 735         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 736         obstack_strdup.
 737         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 738         obstack_strdup.
 739         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 740         * stabsread.c (common_block_start): Use obstack_strdup.
 741         * objfiles.c (set_objfile_main_name, objfile): Use
 742         obstack_strdup.
 743         * namespace.c (add_using_directive): Use obstack_strdup.
 744         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 745         * jit.c (finalize_symtab): Use obstack_strdup.
 746         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 747         (guess_partial_die_structure_name, partial_die_info::fixup)
 748         (dwarf2_name): Use obstack_strdup.
 749         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 750         obstack_strdup.
 751         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 752         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 753         obstack_strdup.
 754         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 755
 756 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 757
 758         * unittests/help-doc-selftests.c: New file.
 759         * Makefile.in: Add the new file.
 760
 761 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 762
 763         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 764         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 765         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 766         the trailing '.' is not output, and the first character is uppercased.
 767         (print_help_for_command): Update call to print_doc_line.
 768         (print_doc_of_command): Likewise.
 769         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 770         * cli/cli-option.c (append_indented_doc): Do not append newline.
 771         (build_help_option): Append newline after first appended_indented_doc
 772         only if a second call is done.
 773         (build_help): Append 2 new lines before each option, except the first
 774         one.
 775         * compile/compile.c (_initialize_compile): Add new lines after
 776         %OPTIONS%, when not at the end of the help.
 777         Change help doc or code
 778         producing the help doc to respect the invariants.
 779         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 780         Also removed the new line after 'Options:', as all other commands
 781         do not put an empty line between 'Options:' and the first option.
 782         * printcmd.c (_initialize_printcmd): Likewise.
 783         * stack.c (_initialize_stack): Likewise.
 784         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 785         incorrectly telling COMMAND is optional.
 786         * ada-lang.c (_initialize_ada_language): Change help doc or code
 787         producing the help doc to respect the invariants.
 788         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 789         * breakpoint.c (_initialize_breakpoint): Likewise.
 790         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 791         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 792         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 793         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 794         _initialize_cli_style): Likewise.
 795         * corelow.c (core_target_info): Likewise.
 796         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 797         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 798         * filesystem.c (_initialize_filesystem): Likewise.
 799         * frame.c (_initialize_frame): Likewise.
 800         * gnu-nat.c (add_task_commands): Likewise.
 801         * infcall.c (_initialize_infcall): Likewise.
 802         * infcmd.c (_initialize_infcmd): Likewise.
 803         * interps.c (_initialize_interpreter): Likewise.
 804         * language.c (_initialize_language): Likewise.
 805         * linux-fork.c (_initialize_linux_fork): Likewise.
 806         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 807         * maint.c (_initialize_maint_cmds): Likewise.
 808         * memattr.c (_initialize_mem): Likewise.
 809         * printcmd.c (_initialize_printcmd): Likewise.
 810         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 811         _RegEx): Likewise.
 812         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 813         * record-btrace.c (_initialize_record_btrace): Likewise.
 814         * record-full.c (_initialize_record_full): Likewise.
 815         * record.c (_initialize_record): Likewise.
 816         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 817         * regcache.c (_initialize_regcache): Likewise.
 818         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 819         _initialize_remote): Likewise.
 820         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 821         * serial.c (_initialize_serial): Likewise.
 822         * skip.c (_initialize_step_skip): Likewise.
 823         * source.c (_initialize_source): Likewise.
 824         * stack.c (_initialize_stack): Likewise.
 825         * symfile.c (_initialize_symfile): Likewise.
 826         * symtab.c (_initialize_symtab): Likewise.
 827         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 828         * top.c (init_main): Likewise.
 829         * tracefile-tfile.c (tfile_target_info): Likewise.
 830         * tracepoint.c (_initialize_tracepoint): Likewise.
 831         * tui/tui-win.c (_initialize_tui_win): Likewise.
 832         * utils.c (add_internal_problem_command): Likewise.
 833         * valprint.c (value_print_option_defs): Likewise.
 834
 835 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 836
 837         PR build/24886
 838         * configure.ac: Drop enable-libmcheck support.
 839         * configure, config.in: Rebuild.
 840         * libmcheck.m4: Remove.
 841         * acinclude.m4: Don't include it.
 842         * Makefile.in: Don't distribute it.
 843         * top.c (print_gdb_configuration): Don't mention it.
 844
 845 2019-08-06  Tom Tromey  <tom@tromey.com>
 846
 847         * utils.c (set_output_style): Sometimes pass stream to
 848         emit_style_escape.
 849         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 850         * record-btrace.c (btrace_insn_history): Update.
 851         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 852         method.
 853         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 854         Update initializers.
 855         <m_uiout>: New field.
 856         <m_di>: Move lower.
 857         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 858         Remove "uiout" parameter.
 859         (dump_insns): Update.
 860         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 861         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 862
 863 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 864
 865         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 866         (error_in_psymtab_expansion): Likewise.
 867         (lookup_symbol_via_quick_fns): Likewise.
 868         (basic_lookup_transparent_type_quick): Likewise.
 869         (basic_lookup_transparent_type_1): Likewise.
 870
 871 2019-08-06  Tom Tromey  <tromey@adacore.com>
 872
 873         * source.c (last_source_error): Now bool.
 874         (print_source_lines_base): Make "noprint" bool.  Only open
 875         source file when last_source_visited changes.
 876
 877 2019-08-06  Tom Tromey  <tromey@adacore.com>
 878
 879         * annotate.c (annotate_source_line): Use g_source_cache.
 880         * source-cache.c (source_cache::get_plain_source_lines): Change
 881         parameters.  Populate m_offset_cache.
 882         (source_cache::ensure): New method.
 883         (source_cache::get_line_charpos): New method.
 884         (extract_lines): Move lower.  Change parameters.
 885         (source_cache::get_source_lines): Move lower.
 886         * source-cache.h (class source_cache): Update comment.
 887         <get_line_charpos>: New method.
 888         <get_source_lines>: Update comment.
 889         <clear>: Clear m_offset_cache.
 890         <get_plain_source_lines>: Change parameters.
 891         <ensure>: New method
 892         <m_offset_cache>: New member.
 893         * source.c (forget_cached_source_info_for_objfile): Update.
 894         (info_source_command): Use g_source_cache.
 895         (find_source_lines, open_source_file_with_line_charpos): Remove.
 896         (print_source_lines_base, search_command_helper): Use g_source_cache.
 897         * source.h (open_source_file_with_line_charpos): Don't declare.
 898         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 899         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 900         Use g_source_cache.
 901
 902 2019-08-06  Tom Tromey  <tromey@adacore.com>
 903
 904         * source-cache.c (source_cache::get_plain_source_lines):
 905         Remove "first_line" and "last_line" parameters.
 906         (source_cache::get_source_lines): Cache plain text.
 907         * source-cache.h (class source_cache)
 908         <get_plain_source_lines>: Update.
 909
 910 2019-08-06  Tom Tromey  <tromey@adacore.com>
 911
 912         * source-cache.c (extract_lines): No longer a method.
 913         Changed type of parameter.  Include final newline.
 914         (selftests::extract_lines_test): New function.
 915         (_initialize_source_cache): Likewise.
 916         * source-cache.h (class source_cache)
 917         <extract_lines>: Don't declare.
 918
 919 2019-08-06  Tom Tromey  <tromey@adacore.com>
 920
 921         * breakpoint.c (init_breakpoint_sal): Update.
 922         (breakpoint): Update.
 923         * breakpoint.h (struct breakpoint) <filter>: Now a
 924         unique_xmalloc_ptr.
 925
 926 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 927
 928         * NEWS: Mention dictionary access on blocks.
 929         * python/py-block.c (blpy_getitem): New function.
 930         (block_object_as_mapping): New struct.
 931         (block_object_type): Use new struct for tp_as_mapping field.
 932
 933 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 934
 935         * objfiles.h (objfile): Add a comment describing partial symbols.
 936
 937 2019-08-05  Tom Tromey  <tromey@adacore.com>
 938
 939         * compile/compile.c (_initialize_compile): Use _(), not N_().
 940         * thread.c (_initialize_thread): Use _(), not N_().
 941         * stack.c (_initialize_stack): Use _(), not N_().
 942         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 943
 944 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 945
 946         * dwarf2read.c (struct dw2_symtab_iterator):
 947         <want_specific_block>: Remove.
 948         <block_index>: Change type to gdb::optional.
 949         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 950         change type of BLOCK_INDEX parameter to gdb::optional.
 951         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 952         (dw2_lookup_symbol): Don't pass argument for
 953         WANT_SPECIFIC_BLOCK.
 954         (dw2_expand_symtabs_for_function): Don't pass argument for
 955         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 956         (class dw2_debug_names_iterator)
 957         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 958         parameter, change BLOCK_INDEX type to gdb::optional.
 959         <m_want_specific_block>: Remove.
 960         <m_block_index>: Change type to gdb::optional.
 961         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 962         gdb::optional.  Re-write in function of gdb::optional.
 963         (dw2_debug_names_lookup_symbol): Don't pass argument for
 964         WANT_SPECIFIC_BLOCK.
 965         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 966         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 967         BLOCK_INDEX.
 968
 969 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 970
 971         * NEWS: Mention changes to "info sources" command.
 972
 973 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974
 975         * symtab.c (filename_partial_match_opts): New struct type.
 976         (struct output_source_filename_data): New members
 977         regexp, c_regexp, partial_match.
 978         (output_source_filename): Use new members to decide to print file.
 979         (info_sources_option_defs): New variable.
 980         (make_info_sources_options_def_group, print_info_sources_header,
 981         info_sources_command_completer):
 982         New functions.
 983         (info_sources_command): Read new optional arguments.
 984         (_initialize_symtab): Update info sources help.
 985
 986 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 987
 988         * ada-lang.c (exception_support_info_v0): Renamed from...
 989         (default_exception_support_info): ... this.  Create new
 990         definition for v1.
 991         (ada_has_this_exception_support): Look up catch_handlers_sym.
 992         (ada_exception_support_info_sniffer): Try v0 after default.
 993
 994 2019-08-01  Tom Tromey  <tromey@adacore.com>
 995
 996         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 997         gdbarch.h.
 998
 999 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1000
1001         * s12z-tdep.c: Fix include path for s12z-opc.h.
1002
1003 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1004
1005         * NEWS: Require GNU make 3.82.
1006
1007 2019-07-16  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1010         declare.
1011
1012 2019-07-30  Tom Tromey  <tromey@adacore.com>
1013
1014         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1015
1016 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1017
1018         * printcmd.c (print_address_symbolic): Print negative offsets.
1019         (build_address_symbolic): Force signed arithmetic when computing
1020         offset.
1021
1022 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1023
1024         PR/24474: Add a function to lookup static variables.
1025         * NEWS: Mention this new function.
1026         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1027         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1028         * python/python.c (python_GdbMethods): Add new function.
1029
1030 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1031
1032         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1033         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1034         (objfpy_lookup_static_symbol): New function.
1035         (objfile_object_methods): Add new functions.
1036
1037 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1038
1039         * NEWS: Mention 'set|show print frame-info'.  Mention new
1040         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1041         backtrace argument.  Mention that python frame filtering code
1042         is now consistent with what 'backtrace' command prints.
1043
1044 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1045
1046         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1047         comments.
1048         (print_frame_info_auto, print_frame_info_source_line,
1049         print_frame_info_location, print_frame_info_source_and_location,
1050         print_frame_info_location_and_address, print_frame_info_short_location):
1051         New declarations.
1052         (struct frame_print_options): New member print_frame_info.
1053         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1054         * stack.h (get_user_print_what_frame_info): New declaration.
1055         (frame_show_address): New declaration.
1056         * stack.c (print_frame_arguments_choices): New value 'presence'.
1057         (print_frame_info_auto, print_frame_info_source_line,
1058         print_frame_info_location, print_frame_info_source_and_location,
1059         print_frame_info_location_and_address, print_frame_info_short_location,
1060         print_frame_info_choices, print_frame_info_print_what): New definitions.
1061         (print_frame_args): Only print dots for args if print frame-arguments
1062         is 'presence'.
1063         (frame_print_option_defs): New element for "frame-info".
1064         (get_user_print_what_frame_info): New function.
1065         (frame_show_address): Make non static.  Move comment to stack.h.
1066         (print_frame_info_to_print_what): New function.
1067         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1068         to decide what to print.
1069         (backtrace_command_1): Handle the new print_frame_arguments_presence
1070         value.
1071         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1072         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1073         (py_print_frame): In non-mi mode, use LOCATION as default for
1074         print_what, similarly to frame information printed directly by
1075         backtrace command. Handle frame-info user option in non MI mode.
1076
1077 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1078
1079         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1080         Add case for debugging 32-bit target on 64-bit host.  Revise
1081         comment.
1082
1083 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1084
1085         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1086         instead of find_function_entry_range_from_pc.
1087
1088 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1089
1090         * stack.c (find_frame_funname): Remove code which preferred
1091         minsym over symtab sym in "certain pathological cases".
1092
1093         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1094         parameter.  Change type of "do_demangle" to bool.
1095         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1096         Pass suitable "prefer_sym_over_minsym" flag to
1097         build_address_symbolic().  Don't output "+" for negative offsets.
1098         * printcmd.c (print_address_symbolic): Update invocation of
1099         build_address_symbolic to include a "prefer_sym_over_minsym"
1100         flag.
1101         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1102         Restrict cases in which use of minimal symbol is preferred to that
1103         of a found symbol.  Update comments.
1104
1105         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1106         for entry pc when entry pc is out of range for that FDE.
1107
1108 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1109
1110         PR gdb/24839:
1111         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1112         type.
1113
1114 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1115
1116         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1117         this function's Python signature.
1118
1119
1120 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1121
1122         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1123         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1124         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1125         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1126         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1127
1128
1129 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1130
1131         * h8300-tdep.c (h8300_register_name_common): New.
1132         h8300_register_name): Use h8300_register_name_common.
1133         (h8300s_register_name): Likewise.
1134         (h8300sx_register_name): Likewise.
1135         (h8300h_register_nam): New.
1136         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1137
1138
1139 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1140
1141         * arm-tdep.c (arm_skip_cmse_entry): New function.
1142         (arm_is_sgstubs_section): New function.
1143         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1144
1145 2019-07-22  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1148         Don't self-assign.
1149
1150 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1153         type_print.
1154
1155 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1158         so that GDB doesn't match any msymbols when searching in the
1159         TYPES_DOMAIN.
1160         (print_symbol_info): Print using typedef_print or type_print based
1161         on the type of the symbol.  Add updated FIXME comment moved from...
1162         (_initialize_symtab): ... move and update FIXME comment to above.
1163
1164 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1165
1166         * NEWS: Mention adding -q option to "info types".
1167         * symtab.c (struct info_types_options): New struct.
1168         (info_types_options_defs): New variable.
1169         (make_info_types_options_def_group): New function.
1170         (info_types_command): Use gdb::option framework to parse options.
1171         (info_types_command_completer): New function.
1172         (_initialize_symtab): Extend the help text on "info types" and
1173         register command completer.
1174
1175 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1176
1177         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1178         (lookup_symbol_in_objfile): Change int to block_enum and add a
1179         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1180
1181 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1182
1183         * MAINTAINERS (Write After Approval): Add self.
1184
1185 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1188         instruction to the dummy code region.
1189
1190 2019-07-19  Tom Tromey  <tromey@adacore.com>
1191
1192         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1193         (ARGSUSED, PARAMS, __func__): Remove rules.
1194
1195 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1196
1197         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1198         * features/arm/arm-with-iwmmxt.c: Remove.
1199         * features/arm/arm-with-iwmmxt.xml: Remove.
1200         * features/arm/arm-with-m-fpa-layout.c: Remove.
1201         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1202         * features/arm/arm-with-m-vfp-d16.c: Remove.
1203         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1204         * features/arm/arm-with-m.c: Remove.
1205         * features/arm/arm-with-m.xml: Remove.
1206         * features/arm/arm-with-neon.c: Remove.
1207         * features/arm/arm-with-neon.xml: Remove.
1208         * features/arm/arm-with-vfpv2.c: Remove.
1209         * features/arm/arm-with-vfpv2.xml: Remove.
1210         * features/arm/arm-with-vfpv3.c: Remove.
1211         * features/arm/arm-with-vfpv3.xml: Remove.
1212
1213 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1214
1215         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1216
1217 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1218
1219         * arch/aarch32.c (aarch32_create_target_description): Create
1220         target descriptions using features.
1221         * arch/arm.c (arm_create_target_description)
1222         (arm_create_mprofile_target_description): Likewise.
1223         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1224
1225 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1226
1227         * Makefile.in: Add new files.
1228         * aarch32-tdep.c: New file.
1229         * aarch32-tdep.h: New file.
1230         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1231         Call aarch32_read_description.
1232         * arch/aarch32.c: New file.
1233         * arch/aarch32.h: New file.
1234         * arch/arm.c (arm_create_target_description)
1235         (arm_create_mprofile_target_description): New function.
1236         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1237         (arm_create_target_description)
1238         (arm_create_mprofile_target_description): New declaration.
1239         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1240         read_description functions.
1241         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1242         Likewise.
1243         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1244         * arm-tdep.c (tdesc_arm_list): New variable.
1245         (arm_register_g_packet_guesses): Call create description functions.
1246         (arm_read_description) (arm_read_mprofile_description): New
1247         function.
1248         * arm-tdep.h (arm_read_description)
1249         (arm_read_mprofile_description): Add declaration.
1250         * configure.tgt: Add new files.
1251
1252 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1253
1254         * top.c (new_ui_command): Open specified terminal just once.
1255
1256 2019-07-18  Tom Tromey  <tromey@adacore.com>
1257
1258         * symtab.c (main_name): Constify return type.
1259         * symfile.c (set_initial_language): Update.
1260         * symtab.h (main_name): Constify return type.
1261
1262 2019-07-17  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-winsource.c (tui_update_source_window)
1265         (tui_update_source_window_as_is)
1266         (tui_update_source_windows_with_line): Remove return.
1267         * tui/tui-disasm.c (tui_show_disassem)
1268         (tui_show_disassem_and_update_source): Remove return.
1269         * tui/tui.c (tui_reset): Remove return.
1270         * tui/tui-wingeneral.c
1271         (tui_check_and_display_highlight_if_needed): Remove return.
1272
1273 2019-07-17  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-winsource.h (struct tui_exec_info_window)
1280         (struct tui_source_window_base): Move from tui-data.h.
1281         * tui/tui-winsource.c: Move many method definitions from
1282         elsewhere.  Remove "structuring" comments.
1283         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1284         (tui_source_window_base::refresh_window): Move to
1285         tui-winsource.c.
1286         * tui/tui-win.c (tui_source_window_base::refresh_all)
1287         (tui_source_window_base::update_tab_width)
1288         (tui_source_window_base::set_new_height)
1289         (tui_source_window_base::do_make_visible_with_new_height): Move to
1290         tui-winsource.c.
1291         * tui/tui-source.h: Update.
1292         * tui/tui-source.c (tui_source_window_base::reset): Move to
1293         tui-winsource.c.
1294         * tui/tui-disasm.h: Update.
1295         * tui/tui-data.h (struct tui_exec_info_window): Move to
1296         tui-winsource.h.
1297         (struct tui_source_window_base): Likewise.
1298         * tui/tui-data.c (tui_source_window_base::clear_detail)
1299         (tui_source_window_base, ~tui_source_window_base): Move to
1300         tui-winsource.c.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-win.c (tui_resize_all)
1305         (tui_source_window_base::update_tab_width)
1306         (tui_adjust_win_heights): Update.
1307         (tui_win_info::make_invisible_and_set_new_height): Rename from
1308         make_invisible_and_set_new_height.
1309         * tui/tui-data.h (struct tui_win_info)
1310         <make_invisible_and_set_new_height>: New method.
1311
1312 2019-07-17  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui.c: Update.
1315         * tui/tui-source.h (struct tui_source_window): Move from
1316         tui-data.h.
1317         * tui/tui-layout.c: Update.
1318         * tui/tui-disasm.c: Update.
1319         * tui/tui-data.h (struct tui_source_window): Move to
1320         tui-source.h.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1325         tui-data.h.
1326         * tui/tui-data.h (struct tui_disasm_window): Move to
1327         tui-disasm.h.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-regs.h (struct tui_data_item_window): Move from
1332         tui-data.h.
1333         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1334         * tui/tui-data.h (struct tui_data_item_window): Move to
1335         tui-regs.h.
1336         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1337
1338 2019-07-17  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui.c: Update.
1341         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1342         (tui_cmd_window::max_height): Move to tui-command.c.
1343         * tui/tui-layout.c: Update.
1344         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1345         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1346         tui-command.c.
1347         * tui/tui-command.h (struct tui_cmd_window): Move from
1348         tui-data.h.
1349         * tui/tui-command.c: Remove "structuring" comments.
1350         (tui_cmd_window::clear_detail)
1351         (tui_cmd_window::do_make_visible_with_new_height)
1352         (tui_cmd_window::max_height): Move from elsewhere.
1353
1354 2019-07-17  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1357         Now static.
1358         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1359         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui.c: Update.
1364         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1365         tui-regs.c.
1366         * tui/tui-windata.h: Remove file.
1367         * tui/tui-windata.c: Remove file.
1368         * tui/tui-win.c (tui_data_window::set_new_height)
1369         (tui_data_window::do_make_visible_with_new_height): Move to
1370         tui-regs.c.
1371         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1372         * tui/tui-regs.c: Remove "structuring" comments.
1373         (tui_data_window::first_data_item_displayed)
1374         (tui_data_window::delete_data_content_windows)
1375         (tui_data_window::erase_data_content)
1376         (tui_data_window::display_all_data)
1377         (tui_data_window::refresh_all)
1378         (tui_data_window::do_scroll_vertical)
1379         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1380         (tui_data_window::do_make_visible_with_new_height)
1381         (tui_data_window::refresh_window): Move from elsewhere.
1382         (_initialize_tui_regs): Move to end of file.
1383         * tui/tui-layout.c: Update.
1384         * tui/tui-hooks.c: Update.
1385         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1386         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1387         tui-regs.c.
1388         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1393         seen.
1394
1395 2019-07-17  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-win.c (tui_source_window_base::set_new_height)
1398         (tui_source_window_base::do_make_visible_with_new_height): Use
1399         m_has_locator field directly.
1400         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1401         method.
1402         (struct tui_source_window_base) <has_locator>: Likewise.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1407         Don't declare.
1408         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1409         Remove.
1410         * tui/tui-win.c (tui_source_window_base::set_new_height)
1411         (tui_source_window_base::set_new_height)
1412         (make_invisible_and_set_new_height)
1413         (tui_source_window_base::do_make_visible_with_new_height)
1414         (tui_source_window_base::do_make_visible_with_new_height):
1415         Update.
1416         * tui/tui-layout.c (show_source_disasm_command, show_data)
1417         (show_source_or_disasm_and_command): Update.
1418         * tui/tui-layout.c (show_layout): Update.
1419
1420 2019-07-17  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-layout.c (make_data_window): Remove.
1423         (show_data): Unify creation and re-initialization cases.
1424
1425 2019-07-17  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-layout.c (make_source_window, make_disasm_window):
1428         Remove.
1429         (show_data): Unify creation and re-initialization cases.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-layout.c (make_command_window): Remove.
1434         (show_source_disasm_command, show_source_or_disasm_and_command):
1435         Unify creation and re-initialization cases.
1436
1437 2019-07-17  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1440         creation and re-initialization cases.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-regs.c (tui_get_register): Return void.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1449         Simplify.
1450
1451 2019-07-17  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1454         resetting.
1455
1456 2019-07-17  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1459         * tui/tui-regs.c (tui_reg_layout): New function.
1460         (tui_show_registers, tui_reg_command): Use it.
1461         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1462         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1463         parameters.
1464         (tui_layout_command): Remove.
1465
1466 2019-07-17  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-layout.h (tui/tui-layout): Return void.
1469         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1470
1471 2019-07-17  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-layout.c (show_source_disasm_command, show_data):
1474         Update.
1475         (reset_locator): Remove.
1476         (show_source_or_disasm_and_command): Update.
1477
1478 2019-07-17  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-source.c (tui_source_window_base::reset): Remove
1481         win_type parameter.
1482         * tui/tui-layout.c (make_command_window, make_source_window)
1483         (make_disasm_window, make_data_window)
1484         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1485         (reset_locator, show_source_or_disasm_and_command): Update.
1486         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1487         win_type parameter.
1488         (struct tui_source_window_base) <reset>: Likewise.
1489
1490 2019-07-17  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-layout.c (show_source_disasm_command): Use
1493         reset_locator.
1494         (reset_locator): New function.
1495         (init_and_make_win): Remove.
1496         (show_source_or_disasm_and_command): Use reset_locator.
1497
1498 2019-07-17  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1501         condition.
1502         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1503         Remove condition.
1504         * tui/tui-source.c (tui_source_window_base::reset): New method.
1505         * tui/tui-layout.c (make_command_window): Don't call
1506         init_and_make_win.
1507         (make_source_window, make_disasm_window): Don't call
1508         make_source_or_disasm_window.
1509         (make_data_window): Don't call init_and_make_win.  Change calling
1510         convention.
1511         (show_source_disasm_command, show_data): Simplify.
1512         (make_source_or_disasm_window): Remove.
1513         (show_source_or_disasm_and_command): Simplify.
1514         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1515         (struct tui_source_window_base) <reset>: Likewise.
1516         <execution_info>: Remove initializer.
1517         * tui/tui-data.c (tui_source_window_base): Initialize
1518         execution_info.
1519
1520 2019-07-17  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1523         variable.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui.c (tui_rl_other_window): Update.
1528         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1529         superclass method first.  Always iterate over regs_content.
1530         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1531         method.
1532         * tui/tui-win.c (tui_set_focus_command): Update.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-win.c (tui_set_focus_command): Rename from
1537         tui_set_focus.  Call tui_enable.
1538         (tui_set_focus_command): Remove.
1539
1540 2019-07-17  Tom Tromey  <tom@tromey.com>
1541
1542         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1543         refresh_window.
1544         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1545         touchwin.
1546         (tui_data_window::refresh_window): Call refresh_window on data
1547         items.  Always call superclass refresh_window.
1548         (tui_win_info::refresh): Remove.
1549         (tui_source_window_base::refresh_window): Update.
1550         (tui_refresh_all): Update.
1551         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1552         refresh_window.
1553         (show_source_or_disasm_and_command): Likewise.
1554         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1555         (struct tui_source_window_base) <refresh>: Likewise.
1556
1557 2019-07-17  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-winsource.c (tui_clear_source_content)
1560         (tui_show_source_content): Update.
1561         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1562         whether content is empty.
1563         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1564         Remove.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1569         window's contents.
1570         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1571         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1576         (struct tui_data_item_window): Update.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1581         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1582         defines.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-winsource.h (tui_erase_source_content)
1587         (tui_clear_source_content): Remove "display_prompt" parameter.
1588         * tui/tui-winsource.c (tui_update_source_window_as_is)
1589         (tui_update_source_windows_with_addr): Update.
1590         (tui_clear_source_content): Remove "display_prompt" parameter.
1591         (tui_erase_source_content): Likewise.  Simplify.
1592         (tui_show_source_content): Update.
1593         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1594         * tui/tui-stack.c (tui_show_frame_info): Update.
1595         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1596         Remove defines.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1601         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1602         parameter.
1603         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1604         parameter.
1605
1606 2019-07-17  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-winsource.c (tui_clear_source_content)
1609         (tui_show_source_content, tui_show_exec_info_content)
1610         (tui_clear_exec_info_content): Update.
1611         * tui/tui-stack.c (tui_show_locator_content): Update.
1612         (tui_show_frame_info): Update.
1613         * tui/tui-source.h (tui_source_window): Don't declare.
1614         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1615         from tui_source_is_displayed.
1616         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1617         Remove field.
1618         (struct tui_source_window_base) <content_in_use>: New field.  Now
1619         bool.
1620         (struct tui_source_window) <showing_source_p>: New method.
1621         (TUI_SRC_WIN): Change cast.
1622         * tui/tui-data.c (tui_initialize_static_data): Update.
1623
1624 2019-07-17  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1627         location_matches_p.
1628         * tui/tui-source.c (tui_source_window::location_matches_p): New
1629         method.
1630         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1631         method.
1632         * tui/tui-data.h (struct tui_source_window_base)
1633         <location_matches_p>: New method.
1634         (struct tui_source_window, struct tui_disasm_window)
1635         <location_matches_p>: Likewise.
1636
1637 2019-07-17  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-win.c (tui_set_win_height_command): Rename from
1640         tui_set_win_height.
1641         (tui_set_win_height_command): Remove.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-source.c (tui_source_window): New constructor.  Add
1646         observer.
1647         (~tui_source_window): New destructor.
1648         (tui_source_window::style_changed): New method.
1649         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1650         (tui_attach_detach_observers): Update.
1651         * tui/tui-data.h (struct tui_source_window): Make constructor not
1652         inline.  Add destructor.
1653         (struct tui_source_window) <style_changed>: New method.
1654         <m_observable>: New member.
1655
1656 2019-07-17  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1659         * tui/tui-win.c (tui_resize_all): Fix typo.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1664         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1665         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1666         * tui/tui-win.c (window_name_completer): Use foreach.
1667         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1668         (update_tab_width): Likewise.
1669         * tui/tui-layout.c (show_layout): Update.
1670         * tui/tui-data.h (class tui_window_iterator): New.
1671         (struct all_tui_windows): New.
1672         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1673
1674 2019-07-17  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1677         parameter.  Don't reference globals.
1678         (tui_reg_command): Update.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-regs.c (tui_show_registers): Simplify.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-regs.c (tui_show_registers): Update.
1687         (tui_show_register_group): Add win_info parameter.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1692         Rename from tui_display_reg_element_at_line.
1693         (tui_data_window::display_registers_from_line): Update.
1694         * tui/tui-data.h (struct tui_data_window)
1695         <display_reg_element_at_line>: New method.
1696
1697 2019-07-17  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-regs.h (tui_display_registers_from)
1700         (tui_display_registers_from_line): Don't declare.
1701         * tui/tui-windata.c (tui_data_window::display_all_data)
1702         (tui_data_window::refresh_all)
1703         (tui_data_window::do_scroll_vertical): Update.
1704         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1705         from tui_display_registers_from.
1706         (tui_display_reg_element_at_line): Update.
1707         (tui_data_window::display_registers_from_line): Rename from
1708         tui_display_registers_from_line.
1709         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1710         display_registers_from_line>: New methods.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1715         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1716         from tui_erase_data_content.
1717         (tui_data_window::display_all_data)
1718         (tui_data_window::refresh_all)
1719         (tui_data_window::do_scroll_vertical): Update.
1720         * tui/tui-regs.c (tui_show_registers): Update.
1721         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1722         New method.
1723
1724 2019-07-17  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1727         declare.
1728         * tui/tui-windata.c
1729         (tui_data_window::delete_data_content_windows): Rename from
1730         tui_delete_data_content_windows.
1731         (tui_data_window::display_all_data)
1732         (tui_data_window::do_scroll_vertical): Update.
1733         * tui/tui-data.h (struct tui_data_window)
1734         <delete_data_content_windows>: New method.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1739         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1744         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1745         from tui_display_all_data.
1746         * tui/tui-win.c
1747         (tui_data_window::do_make_visible_with_new_height): Update.
1748         * tui/tui-regs.c (tui_show_registers): Update.
1749         * tui/tui-layout.c (tui_set_layout): Update.
1750         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1751         method.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1756         * tui/tui-windata.c (tui_display_data_from): Remove.
1757         (tui_data_window::refresh_all): Update.
1758
1759 2019-07-17  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1762         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1763         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1764         tui_display_registers_from_line.
1765         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1766         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1767         "force_display" parameter.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1772         declare.
1773         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1774         Rename from tui_first_reg_element_no_inline.
1775         (tui_display_reg_element_at_line)
1776         (tui_display_registers_from_line): Update.
1777         * tui/tui-data.h (struct tui_data_window)
1778         <first_reg_element_no_inline>: New method.
1779
1780 2019-07-17  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-windata.c (tui_display_data_from)
1783         (tui_data_window::do_scroll_vertical): Update.
1784         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1785         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1786         Rename from tui_line_from_reg_element_no.
1787         (tui_display_registers_from_line): Update.
1788         * tui/tui-data.h (struct tui_data_window)
1789         <line_from_reg_element_no>: New method.
1790
1791 2019-07-17  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1794         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1795         tui_last_regs_line_no.
1796         (tui_display_reg_element_at_line)
1797         (tui_display_registers_from_line): Update.
1798         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1799         method.
1800
1801 2019-07-17  Tom Tromey  <tom@tromey.com>
1802
1803         PR tui/24722:
1804         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1805         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1806         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1807         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1808         (tui_update_breakpoint_info): Likewise.
1809         * tui/tui-hooks.c (tui_event_create_breakpoint)
1810         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1811         Update.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-winsource.c (tui_update_source_window_as_is)
1820         (tui_update_source_windows_with_addr): Update.
1821         * tui/tui-source.h (tui_set_source_content)
1822         (tui_show_symtab_source): Add "win_info" parameter.
1823         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1824         parameter.
1825         (tui_show_symtab_source): Likewise.
1826
1827 2019-07-17  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-wingeneral.c
1830         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1831
1832 2019-07-17  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1835         (struct tui_cmd_window) <can_scroll>: New method.
1836         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1837         method.
1838
1839 2019-07-17  Tom Tromey  <tromey@adacore.com>
1840
1841         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1842         do_field_signed>: Rename.  Change type of "value".
1843         * ui-out.c (ui_out::field_signed): Rename from field_int.
1844         Change type of "value".
1845         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1846         type of "value".
1847         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1848         do_field_int.  Change type of "value".
1849         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1850         do_field_int.  Change type of "value".
1851         * tracepoint.c (trace_status_mi, tfind_1)
1852         (print_one_static_tracepoint_marker): Update.
1853         * thread.c (print_thread_info_1, print_selected_thread_frame):
1854         Update.
1855         * stack.c (print_frame, print_frame_info): Update.
1856         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1857         Update.
1858         * source.c (print_source_lines_base): Update.
1859         * skip.c (info_skip_command): Update.
1860         * record-btrace.c (btrace_ui_out_decode_error)
1861         (btrace_call_history_src_line): Update.
1862         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1863         Update.
1864         * progspace.c (print_program_space): Update.
1865         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1866         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1867         do_field_int.  Change type of "value".
1868         * mi/mi-out.c (mi_ui_out::do_table_begin)
1869         (mi_ui_out::do_table_header): Update.
1870         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1871         type of "value".
1872         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1873         (mi_cmd_data_list_changed_registers, output_register)
1874         (mi_cmd_data_read_memory, mi_load_progress)
1875         (mi_cmd_trace_frame_collected): Update.
1876         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1877         Update.
1878         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1879         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1880         (mi_cmd_var_list_children, varobj_update_one): Update.
1881         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1882         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1883         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1884         * inferior.c (print_inferior): Update.
1885         * gdb_bfd.c (print_one_bfd): Update.
1886         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1887         Update.
1888         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1889         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1890         do_field_int.  Change type of "value".
1891         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1892         do_field_int.  Change type of "value".
1893         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1894         (print_one_breakpoint_location, print_it_catch_fork)
1895         (print_one_catch_fork, print_it_catch_vfork)
1896         (print_one_catch_vfork, print_it_catch_solib)
1897         (print_it_catch_exec, print_it_ranged_breakpoint)
1898         (print_mention_watchpoint, print_mention_masked_watchpoint)
1899         (bkpt_print_it, update_static_tracepoint): Update.
1900         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1901         * break-catch-syscall.c (print_it_catch_syscall): Update.
1902         * ada-tasks.c (print_ada_task_info): Update.
1903         * ada-lang.c (print_it_exception, print_mention_exception):
1904         Update.
1905
1906 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         PR breakpoints/24541
1909         * gdbarch.c: Regenerate.
1910         * gdbarch.h: Regenerate.
1911         * gdbarch.sh: Adjust return type and parameter types for
1912         'stap_adjust_register'.
1913         (i386_stap_adjust_register): Adjust signature and return new
1914         register name.
1915         * stap-probe.c (stap_parse_register_operand): Adjust use of
1916         'gdbarch_stap_adjust_register'.
1917
1918 2019-07-17  Tom Tromey  <tromey@adacore.com>
1919
1920         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1921         declare VEC.
1922         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1923         std::vector.
1924         (struct s390_process_info): Add initializers.
1925         (s390_add_process): Use new.
1926         (s390_linux_nat_target::low_forget_process): Use delete.
1927         (s390_linux_nat_target::low_new_fork)
1928         (s390_linux_nat_target::stopped_by_watchpoint)
1929         (s390_linux_nat_target::low_prepare_to_resume)
1930         (s390_linux_nat_target::insert_watchpoint)
1931         (s390_linux_nat_target::insert_hw_breakpoint)
1932         (s390_linux_nat_target::remove_watchpoint)
1933         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1934
1935 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1936
1937         * aarch64-fbsd-nat.c: Include regcache.h.
1938         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1939         argument.
1940         (aarch64_fbsd_nat_target::fetch_registers)
1941         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1942         variable.
1943         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1944
1945 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1946
1947         * fbsd-nat.c: Include gdbarch.h.
1948
1949 2019-07-15  Tom Tromey  <tromey@adacore.com>
1950
1951         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1952
1953 2019-07-15  Tom Tromey  <tromey@adacore.com>
1954
1955         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1956         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1957         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1958         * cli-out.c (cli_ui_out::do_field_int): New method.
1959         * ui-out.c (ui_out::field_unsigned): New method.
1960         * symfile.c (generic_load): Use field_unsigned.
1961         (print_transfer_performance): Likewise.
1962         * record-btrace.c (ui_out_field_uint): Remove.
1963         (btrace_call_history_insn_range, btrace_call_history): Use
1964         field_unsigned.
1965         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1966         field_unsigned.
1967         * ui-out.h (class ui_out) <field_unsigned>: New method.
1968         <do_field_unsigned>: Likewise.
1969
1970 2019-07-15  Tom Tromey  <tromey@adacore.com>
1971
1972         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1973         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1974         * target.c (flash_erase_command): Use field_string.
1975         * infrun.c (print_signal_received_reason): Use field_string.
1976         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1977         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1978         field_string.
1979         * ada-tasks.c (print_ada_task_info): Use field_string.
1980
1981 2019-07-15  Tom Tromey  <tromey@adacore.com>
1982
1983         * target.c (flash_erase_command): Use field_core_addr.
1984         * symfile.c (generic_load): Use field_core_addr.
1985         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1986         Use field_core_addr.
1987         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1988         field_core_addr.
1989
1990 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1993         value if its desired type is smaller than a CORE_ADDR and signed.
1994
1995 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1998         of changes to field names, and use new is_reference field to
1999         decide if a property is a reference or not.
2000         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2001         field.
2002         (struct dwarf2_property_baton): Update header comment, rename
2003         'referenced_type' to 'property_type' and update comments.
2004         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2005         default property type, store in property baton, update to take
2006         accound of renamed field.
2007         (read_func_scope): Update call to attr_to_dynamic_prop.
2008         (read_array_type): Likewise.
2009         (dwarf2_per_cu_addr_sized_int_type): New function.
2010         (read_subrange_index_type): Move type finding code to
2011         dwarf2_per_cu_addr_sized_int_type.
2012         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2013         (dwarf2_per_cu_addr_type): New function.
2014         (set_die_type): Update calls to attr_to_dynamic_prop.
2015
2016 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2017
2018         * dwarf2read.c (read_subrange_index_type): New function.
2019         (read_subrange_type): Move code into new function and call it.
2020         * gdbtypes.c (create_range_type): Add some asserts.
2021
2022 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2025         update return statements.
2026         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2027         declaration, and update comment to match.
2028         * gdbtypes.c (resolve_dynamic_array): Update call to
2029         dwarf2_evaluate_property to match new return type.
2030
2031 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2032
2033         * valarith.c (value_subscripted_rvalue): Change lowerbound
2034         parameter type from int to LONGEST.
2035         * value.h (value_subscripted_rvalue): Likewise in declaration.
2036
2037 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * cli/cli-utils.c (info_print_command_completer): New function.
2040         * cli/cli-utils.h: Add 'completer.h' include, and forward
2041         declaration for 'struct cmd_list_element'.
2042         (info_print_command_completer): Declare.
2043         * stack.c (_initialize_stack): Add completer for 'info locals' and
2044         'info args'.
2045         * symtab.c (_initialize_symtab): Add completer for 'info
2046         variables' and 'info functions'.
2047         * NEWS: Mention completion for additional info commands.
2048
2049 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * cli/cli-utils.c (extract_info_print_args): Delete.
2052         (extract_arg_maybe_quoted): Delete.
2053         (info_print_options_defs): New variable.
2054         (make_info_print_options_def_group): New function.
2055         (extract_info_print_options): Define new function.
2056         * cli/cli-utils.h (extract_info_print_args): Delete.
2057         (struct info_print_options): New structure.
2058         (extract_info_print_options): Declare new function.
2059         * stack.c (info_locals_command): Update to use new
2060         extract_info_print_options, also add a header comment.
2061         (info_args_command): Likewise.
2062         * symtab.c (info_variables_command): Likewise.
2063         (info_functions_command): Likewise.
2064
2065 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2066
2067         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2068         to extract string arguments.
2069         * common/common-utils.c (extract_string_maybe_quoted): New function.
2070         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2071
2072 2019-07-11  Tom Tromey  <tromey@adacore.com>
2073
2074         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2075         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2076         * top.h (gdbinit): Don't declare.
2077         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2078         into...
2079         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2080         * top.c (gdb_init): Don't call init_cli_cmds.
2081         (gdbinit): Remove.
2082         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2083
2084 2019-07-11  Tom Tromey  <tromey@adacore.com>
2085
2086         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2087         after it has been moved.
2088
2089 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2090
2091         * valops.c (value_must_coerce_to_target): Change return type to
2092         bool.
2093         * value.h (value_must_coerce_to_target): Likewise.
2094
2095 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2096
2097         * breakpoint.c (is_hardware_watchpoint): Remove
2098         forward-declaration.
2099         (is_masked_watchpoint): Change return type to bool.
2100         (is_tracepoint): Likewise.
2101         (is_breakpoint): Likewise.
2102         (is_hardware_watchpoint): Likewise.
2103         (is_watchpoint): Likewise.
2104         (is_no_memory_software_watchpoint): Likewise.
2105         (is_catchpoint): Likewise.
2106         (breakpoint_1): Make FILTER parameter's return type bool.
2107         is_masked_watchpoint): Change return type to bool.
2108         (save_breakpoints): Make FILTER parameter's return type bool.
2109         * breakpoint.h (is_breakpoint): Change return type to bool.
2110         (is_watchpoint): Likewise.
2111         (is_catchpoint): Likewise.
2112         (is_tracepoint): Likewise.
2113
2114 2019-07-10  Tom Tromey  <tom@tromey.com>
2115
2116         * defs.h: Don't include gdbarch.h.
2117         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2118         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2119         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2120         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2121         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2122         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2123         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2124         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2125         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2126         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2127         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2128         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2129         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2130         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2131         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2132         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2133         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2134         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2135         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2136         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2137         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2138         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2139         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2140         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2141         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2142         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2143         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2144
2145 2019-07-10  Tom Tromey  <tromey@adacore.com>
2146
2147         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2148         * breakpoint.c (init_ada_exception_breakpoint): Register as
2149         bp_catchpoint.
2150         (print_one_breakpoint_location, print_one_breakpoint): Use
2151         is_ada_exception_catchpoint.
2152         * ada-lang.c (class ada_catchpoint_location): Pass
2153         bp_loc_software_breakpoint to bp_location constructor.
2154         (is_ada_exception_catchpoint): New function.
2155
2156 2019-07-10  Tom Tromey  <tromey@adacore.com>
2157
2158         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2159         VEC.
2160         (struct arm_exidx_entry): New method operator<.
2161         (struct arm_exidx_data) <section_maps>: Change type.
2162         (arm_exidx_data_free): Remove.
2163         (arm_exidx_data_key): Change type.  Move lower.
2164         (arm_exidx_new_objfile): Update.
2165         (arm_compare_exidx_entries): Remove.
2166         (arm_find_exidx_entry, _initialize_arm_tdep)
2167
2168 2019-07-10  Tom Tromey  <tromey@adacore.com>
2169
2170         * solib-spu.c (ocl_program_data_key): Change type.
2171         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2172         Update.
2173
2174 2019-07-10  Tom Tromey  <tromey@adacore.com>
2175
2176         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2177         (struct solib_aix_inferior_data) <library_list>: Change type.
2178         (solib_aix_inferior_data_handle): Change type.
2179         (get_solib_aix_inferior_data): Update.
2180         (solib_aix_free_library_list): Remove.
2181         (library_list_start_library): Update.
2182         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2183         return type.
2184         (solib_aix_get_library_list)
2185         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2186         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2187
2188 2019-07-10  Tom Tromey  <tromey@adacore.com>
2189
2190         * solib-dsbt.c (struct dsbt_info): Add initializers.
2191         (solib_dsbt_pspace_data): Change type.
2192         (dsbt_pspace_data_cleanup): Remove.
2193         (get_dsbt_info, _initialize_dsbt_solib): Update.
2194
2195 2019-07-10  Tom Tromey  <tromey@adacore.com>
2196
2197         * spu-tdep.c (spu_overlay_data): Change type.
2198         (spu_get_overlay_table, spu_overlay_new_objfile)
2199         (_initialize_spu_tdep): Update.
2200
2201 2019-07-10  Tom Tromey  <tromey@adacore.com>
2202
2203         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2204         destructor.
2205         (dbx_objfile_data_key): Change type and declare later.
2206         (DBX_SYMFILE_INFO): Rewrite.
2207         * dbxread.c (dbx_objfile_data_key): Change type.
2208         (dbx_symfile_init): Update.
2209         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2210         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2211         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2212
2213 2019-07-10  Tom Tromey  <tromey@adacore.com>
2214
2215         * jit.c (jit_program_space_key): Change type.  Move lower.
2216         (get_jit_program_space_data): Update.
2217         (jit_program_space_data_cleanup): Remove.
2218         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2219         Update.
2220         (struct jit_program_space_data): Add initializers.
2221
2222 2019-07-10  Tom Tromey  <tromey@adacore.com>
2223
2224         * solib-darwin.c (struct darwin_info): Add initializers.
2225         (solib_darwin_pspace_data): Change type.
2226         (darwin_pspace_data_cleanup): Remove.
2227         (get_darwin_info, _initialize_darwin_solib): Update.
2228
2229 2019-07-10  Tom Tromey  <tromey@adacore.com>
2230
2231         * remote-sim.c (struct sim_inferior_data): Add initializers,
2232         constructor, and destructor.
2233         (sim_inferior_data_key): Change type.  Move lower.
2234         (check_for_duplicate_sim_descriptor): Update.
2235         (get_sim_inferior_data): Use new.  Update.
2236         (~sim_inferior_data_cleanup): Rename from
2237         sim_inferior_data_cleanup.  Simplify.
2238         (gdbsim_close_inferior, simulator_command)
2239         (sim_command_completer, _initialize_remote_sim): Update.
2240         (next_pid, INITIAL_PID): Move earlier.
2241
2242 2019-07-10  Tom Tromey  <tromey@adacore.com>
2243
2244         * python/python-internal.h (create_thread_object): Return
2245         gdbpy_ref.
2246         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2247         * python/py-inferior.c (struct threadlist_entry): Add
2248         constructor.
2249         <thread_obj>: Now a gdbpy_ref.
2250         (thread_to_thread_object): Update.
2251         (add_thread_object): Use new.
2252         (delete_thread_object): Use delete.
2253         (infpy_threads): Update.
2254         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2255         GIL.
2256
2257 2019-07-10  Tom Tromey  <tromey@adacore.com>
2258
2259         * valops.c (value_cast): Specialize error message for Ada.
2260
2261 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2262
2263         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2264
2265 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2266
2267         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2268         bpstat_should_step): Return bool, adjust comments.
2269         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2270         bpstat_should_step): Likewise.
2271
2272 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2273
2274         * features/Makefile: Use feature target descriptions for Arm.
2275         * features/arm/arm-core.c: Generate new file.
2276         * features/arm/arm-fpa.c: Likewise.
2277         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2278         * features/arm/arm-m-profile.c: Likewise.
2279         * features/arm/arm-vfpv2.c: Likewise.
2280         * features/arm/arm-vfpv3.c: Likewise.
2281         * features/arm/xscale-iwmmxt.c: Likewise.
2282         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2283
2284 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2285
2286         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2287         ptrace earlier.
2288
2289 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2290
2291         * features/aarch64-pauth.c: Regenerate.
2292
2293 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2294
2295         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2296         bool.
2297         (bpstat_what): Use false instead of 0.
2298
2299 2019-07-09  Pedro Alves  <palves@redhat.com>
2300
2301         * break-catch-throw.c (is_exception_catchpoint): New.
2302         * breakpoint.c (print_one_breakpoint_location): New parameter
2303         'raw_loc'.  Handle it.  Use
2304         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2305         looking at the breakpoint's type.
2306         (print_one_breakpoint): If handling "maint info breakpoints", also
2307         print locations of exception catchpoints.
2308         * breakpoint.h (is_exception_catchpoint): Declare.
2309
2310 2019-07-09  Pedro Alves  <palves@redhat.com>
2311
2312         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2313         "addr" field.
2314         (allocate_location_exception_catchpoint): New.
2315         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2316         (initialize_throw_catchpoint_ops): Install
2317         allocate_location_exception_catchpoint as allocate_location
2318         method.
2319         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2320         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2321         bp_loc_other.
2322         (breakpoint_address_is_meaningful): Delete.
2323         (bl_address_is_meaningful): New.
2324         (breakpoint_locations_match): Adjust comment.
2325         (bp_location_from_bp_type): New, factored out of...
2326         (bp_location::bp_location(breakpoint *)): ... this.
2327         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2328         factored out of...
2329         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2330         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2331         breakpoint_address_is_meaningful.
2332         (bp_locations_compare): Adjust comment.
2333         (update_global_location_list): Use bl_address_is_meaningful
2334         instead of breakpoint_address_is_meaningful.
2335         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2336         explicit.
2337         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2338         * python/py-breakpoint.c (bppy_get_location): No longer check
2339         whether location is null.
2340
2341 2019-07-09  Pedro Alves  <palves@redhat.com>
2342
2343         PR c++/15468
2344         * breakpoint.c (print_one_breakpoint_location): Remove
2345         single-location assert.
2346
2347 2019-07-09  Tom Tromey  <tom@tromey.com>
2348
2349         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2350         * configure: Rebuild.
2351         * configure.ac: Change common to gdbsupport.
2352         * gdbsupport: Rename from common.
2353         * acinclude.m4: Change common to gdbsupport.
2354         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2355         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2356         gdbsupport.
2357         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2358         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2359         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2360         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2361         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2362         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2363         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2364         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2365         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2366         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2367         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2368         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2369         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2370         coff-pe-read.c, command.h, compile/compile-c-support.c,
2371         compile/compile-c.h, compile/compile-cplus-symbols.c,
2372         compile/compile-cplus-types.c, compile/compile-cplus.h,
2373         compile/compile-loc2c.c, compile/compile.c, completer.c,
2374         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2375         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2376         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2377         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2378         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2379         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2380         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2381         features/aarch64-core.c, features/aarch64-fpu.c,
2382         features/aarch64-pauth.c, features/aarch64-sve.c,
2383         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2384         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2385         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2386         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2387         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2388         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2389         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2390         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2391         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2392         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2393         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2394         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2395         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2396         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2397         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2398         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2399         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2400         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2401         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2402         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2403         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2404         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2405         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2406         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2407         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2408         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2409         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2410         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2411         minsyms.c, mips-linux-tdep.c, namespace.h,
2412         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2413         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2414         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2415         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2416         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2417         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2418         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2419         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2420         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2421         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2422         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2423         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2424         procfs.c, producer.c, progspace.h, psymtab.h,
2425         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2426         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2427         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2428         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2429         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2430         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2431         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2432         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2433         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2434         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2435         target-memory.c, target.c, target.h, target/waitstatus.c,
2436         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2437         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2438         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2439         unittests/array-view-selftests.c,
2440         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2441         unittests/common-utils-selftests.c,
2442         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2443         unittests/format_pieces-selftests.c,
2444         unittests/function-view-selftests.c,
2445         unittests/lookup_name_info-selftests.c,
2446         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2447         unittests/mkdir-recursive-selftests.c,
2448         unittests/observable-selftests.c,
2449         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2450         unittests/parse-connection-spec-selftests.c,
2451         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2452         unittests/scoped_fd-selftests.c,
2453         unittests/scoped_mmap-selftests.c,
2454         unittests/scoped_restore-selftests.c,
2455         unittests/string_view-selftests.c, unittests/style-selftests.c,
2456         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2457         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2458         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2459         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2460         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2461         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2462
2463 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2466         bool value.
2467         (decode_digits_ordinary): Set explicit_line field in sal.
2468         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2469         symtab_and_line that was set on an explicit line number in
2470         assembler code.  Do always update the recorded symtab and line if
2471         we do skip the prologue.
2472
2473 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * breakpoint.c (set_breakpoint_location_function): Remove
2476         explicit_loc parameter.
2477         (momentary_breakpoint_from_master): Update call to
2478         set_breakpoint_location_function.
2479         (add_location_to_breakpoint): Likewise.
2480
2481 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2484         required features based on default bfd type when no specific bfd
2485         is present.
2486
2487 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2488
2489         * NEWS: Mention that GDB printf and eval commands can now print
2490         C-style and Ada-style convenience var strings without
2491         calling the inferior.
2492         * printcmd.c (printf_c_string): Locally print GDB internal var
2493         instead of transiting via the inferior.
2494         (printf_wide_c_string): Likewise.
2495
2496 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2497
2498         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2499
2500 2019-07-04  Tom Tromey  <tom@tromey.com>
2501
2502         PR tui/24724:
2503         * tui/tui-winsource.c (tui_clear_source_content): Update.
2504         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2505         (tui_update_breakpoint_info): Update.
2506         (tui_set_exec_info_content): Update.
2507         * tui/tui-source.c (tui_set_source_content_nil): Update.
2508         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2509         has_break.
2510         * tui/tui-data.h (enum tui_bp_flag): New.
2511         (tui_bp_flags): New enum flags type.
2512         (struct tui_source_element) <break_mode>: Change type.  Rename
2513         from has_break.
2514         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2515         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2516         constants.
2517         * tui/tui-winsource.h: Fix comment.
2518
2519 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2522         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2523         (store_fpregs_to_thread)
2524         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2525         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2526         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2527         (IWMMXT_REGS_SIZE): Add define.
2528         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2529         (fetch_vfp_regs, store_vfp_regs)
2530         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2531         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2532
2533 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2534
2535         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2536         defines.
2537         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2538         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2539         (ARM_INT_REGISTER_SIZE): ...to this.
2540         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2541         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2542         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2543         (arm_linux_collect_gregset, supply_nwfpe_register)
2544         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2545         defines.
2546         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2547         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2548         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2549         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2550         (arm_return_in_memory, arm_store_return_value)
2551         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2552         (arm_record_ld_st_multiple): Likewise.
2553         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2554         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2555
2556 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2557
2558         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2559         AARCH64_DISPLACED_MODIFIED_INSNS.
2560         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2561         (aarch64_displaced_step_copy_insn): Likewise.
2562         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2563         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2564         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2565         ARM_DISPLACED_MODIFIED_INSNS.
2566         * arm-tdep.c (arm_gdbarch_init): Likewise.
2567         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2568         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2569         (struct arm_displaced_step_closure): Use
2570         ARM_DISPLACED_MODIFIED_INSNS.
2571
2572 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * features/Makefile: Remove unused xml files.
2575         * features/aarch64.xml: Remove.
2576         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2577         * features/i386/amd64-avx-avx512.xml: Remove.
2578         * features/i386/amd64-avx-linux.xml: Remove.
2579         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2580         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2581         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2582         * features/i386/amd64-avx-mpx.xml: Remove.
2583         * features/i386/amd64-avx.xml: Remove.
2584         * features/i386/amd64-linux.xml: Remove.
2585         * features/i386/amd64-mpx-linux.xml: Remove.
2586         * features/i386/amd64-mpx.xml: Remove.
2587         * features/i386/amd64.xml: Remove.
2588         * features/i386/i386-avx-avx512-linux.xml: Remove.
2589         * features/i386/i386-avx-avx512.xml: Remove.
2590         * features/i386/i386-avx-linux.xml: Remove.
2591         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2592         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2593         * features/i386/i386-avx-mpx-linux.xml: Remove.
2594         * features/i386/i386-avx-mpx.xml: Remove.
2595         * features/i386/i386-avx.xml: Remove.
2596         * features/i386/i386-linux.xml: Remove.
2597         * features/i386/i386-mmx-linux.xml: Remove.
2598         * features/i386/i386-mmx.xml: Remove.
2599         * features/i386/i386-mpx-linux.xml: Remove.
2600         * features/i386/i386-mpx.xml: Remove.
2601         * features/i386/i386.xml: Remove.
2602         * features/i386/x32-avx-avx512-linux.xml: Remove.
2603         * features/i386/x32-avx-linux.xml: Remove.
2604         * features/i386/x32-linux.xml: Remove.
2605
2606 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2607
2608         * regformats/aarch64.dat: Remove.
2609         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2610         * regformats/i386/amd64-avx-linux.dat: Remove.
2611         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2612         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2613         * regformats/i386/amd64-linux.dat: Remove.
2614         * regformats/i386/amd64-mpx-linux.dat: Remove.
2615         * regformats/i386/amd64.dat: Remove.
2616         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2617         * regformats/i386/i386-avx-linux.dat: Remove.
2618         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2619         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2620         * regformats/i386/i386-linux.dat: Remove.
2621         * regformats/i386/i386-mmx-linux.dat: Remove.
2622         * regformats/i386/i386-mpx-linux.dat: Remove.
2623         * regformats/i386/i386.dat: Remove.
2624         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2625         * regformats/i386/x32-avx-linux.dat: Remove.
2626         * regformats/i386/x32-linux.dat: Remove.
2627
2628 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2629
2630         * aarch64-tdep.c: Remove xml self tests.
2631         * amd64-linux-tdep.c: Likewise.
2632         * amd64-tdep.c: Likewise.
2633         * i386-linux-tdep.c: Likewise.
2634         * i386-tdep.c: Likewise.
2635
2636 2019-07-03  Pedro Alves  <palves@redhat.com>
2637
2638         PR cli/24732
2639         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2640         (pipe_cmd_option_defs): New.
2641         (make_pipe_cmd_options_def_group): New.
2642         (pipe_command): Use gdb::option::process_options.
2643         (pipe_command_completer): New function.
2644         (_initialize_cli_cmds): Install completer for "pipe" command.
2645
2646 2019-07-03  Pedro Alves  <palves@redhat.com>
2647
2648         * cli/cli-option.c (union option_value) <string>: New field.
2649         (struct option_def_and_value): Add ctor, move ctor, dtor and
2650         use DISABLE_COPY_AND_ASSIGN.
2651         (option_def_and_value::clear_value): New.
2652         (parse_option, save_option_value_in_ctx, get_val_type_str)
2653         (add_setshow_cmds_for_options): Handle var_string.
2654         * cli-option.h (union option_def::var_address) <string>: New
2655         field.
2656         (struct string_option_def): New.
2657         * maint-test-options.c (struct test_options_opts): Add default
2658         ctor and use DISABLE_COPY_AND_ASSIGN.
2659         <string_opt>: New field.
2660         (test_options_opts::~test_options_opts): New.
2661         (test_options_opts::dump): Also dump "-string".
2662         (test_options_option_defs): Install "string.
2663
2664 2019-07-03  Pedro Alves  <palves@redhat.com>
2665
2666         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2667         option_value with a null enumeration.
2668         (complete_options): Save the option values in the context.
2669         (save_option_value_in_ctx): New, factored out from ...
2670         (process_options): ... here.
2671         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2672         of the function.
2673         * maint-test-options.c (test_options_opts::dump): New, factored
2674         out from ...
2675         (maintenance_test_options_command_mode): ... here.
2676         (maintenance_test_options_command_completion_result): Delete.
2677         (maintenance_test_options_command_completion_text): Update
2678         comment.
2679         (maintenance_show_test_options_completion_result): Change
2680         prototype.  Just print
2681         maintenance_test_options_command_completion_text.
2682         (save_completion_result): New.
2683         (maintenance_test_options_completer_mode): Pass options context to
2684         complete_options, and then save a dump.
2685         (_initialize_maint_test_options): Use add_cmd to install "maint
2686         show test-options-completion-result".
2687
2688 2019-07-03  Pedro Alves  <palves@redhat.com>
2689
2690         * NEWS (New commands): Mention "with" and "maint with".
2691         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2692         (with_command, with_command_completer): New.
2693         (pipe_command): Adjust to new repeat_previous
2694         interface.
2695         (_initialize_cli_cmds): Install the "with" command and its "w"
2696         alias.
2697         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2698         declarations.
2699         * cli/cli-setshow.c (parse_cli_var_uinteger)
2700         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2701         argument strings for all var_types.
2702         (get_setshow_command_value_string): New, factored out from ...
2703         (do_show_command): ... this.
2704         * cli/cli-setshow.h: Include <string>.
2705         (get_setshow_command_value_string): Declare.
2706         * command.h (repeat_previous): Now returns const char *.  Adjust
2707         comment.
2708         * maint.c: Include "cli/cli-cmds.h".
2709         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2710         (_initialize_maint_cmds): Register the "maintenance with" command.
2711         * top.c (repeat_previous): Move bits from pipe_command here:
2712         Return the saved command line, if any; error out if there's no
2713         command to relaunch.
2714
2715 2019-07-03  Pedro Alves  <palves@redhat.com>
2716
2717         * NEWS (New commands): Mention "maint set/show test-settings"
2718         instead of "maint test-settings".
2719         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2720         (maintenance_test_settings_set_list): Rename to ...
2721         (maintenance_set_test_settings_list): ... this.
2722         (maintenance_test_settings_show_list): Rename to  ...
2723         (maintenance_show_test_settings_list): ... this.
2724         (maintenance_test_settings_cmd): Delete.
2725         (maintenance_test_settings_set_cmd): ...
2726         (maintenance_set_test_settings_cmd): ... this.
2727         (maintenance_test_settings_show_cmd): ...
2728         (maintenance_show_test_settings_cmd): ... this.
2729         (maintenance_test_settings_show_value_cmd):
2730         (maintenance_show_test_settings_value_cmd): ... this.
2731         (_initialize_maint_test_settings): No longer install the "maint
2732         test-settings" prefix command.  Rename "maint test-settings set"
2733         to "maint set test-settings", and "maint test-settings show" to
2734         "maint show test-settings".  Adjust all subcommands.
2735
2736 2019-07-03  Pedro Alves  <palves@redhat.com>
2737
2738         * maint-test-settings.c: Fix file's intro comment.  Replace all
2739         references to "test-options" with references to "test-settings",
2740         in comments.
2741
2742 2019-07-03  Pedro Alves  <palves@redhat.com>
2743
2744         * maint-test-settings.c (maintenance_test_settings_xxx)
2745         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2746         New.
2747         (maintenance_test_settings_enums): Use them.
2748         (maintenance_test_settings_enum): Default to
2749         maintenance_test_settings_xxx.
2750         (_initialize_maint_test_settings): Initialize
2751         MAINTENANCE_TEST_SETTINGS_FILENAME.
2752
2753 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2754
2755         * breakpoint.h (remove_breakpoints_inf): Change return type to
2756         void, move function documentation here.
2757         * breakpoint.c (remove_breakpoints_inf): Change return type to
2758         void, move function documentation to header.
2759
2760 2019-07-02  Pedro Alves  <palves@redhat.com>
2761
2762         * NEWS (Completion improvements): Mention "info threads".
2763         * thread.c (struct info_threads_opts, info_threads_option_defs)
2764         (make_info_threads_options_def_group): New.
2765         (info_threads_command): Use gdb::option::process_options.
2766         (info_threads_command_completer): New.
2767         (_initialize_thread): Use gdb::option::build_help to build the
2768         help text for "info threads".
2769
2770 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2771
2772         * defs.h (generic_load): Move from here...
2773         * symfile.h (generic_load): ... to here.  Rename name parameter
2774         to args.
2775         * symfile.c (generic_load): Add comment.
2776
2777 2019-07-01  Tom Tromey  <tromey@adacore.com>
2778
2779         * dwarf2read.c
2780         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2781         declaration of without_params.  Fix formatting.
2782
2783 2019-07-01  Tom Tromey  <tromey@adacore.com>
2784
2785         * ada-exp.y (find_primitive_type): Update.
2786         * ada-lang.h (ada_lookup_symbol): Update.
2787         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2788         parameter.
2789         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2790
2791 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2792
2793         PR breakpoints/24541
2794         * gdbarch.c: Regenerate.
2795         * gdbarch.h: Regenerate.
2796         * gdbarch.sh: Add 'stap_adjust_register'.
2797         * i386-tdep.c: Include '<unordered_set>'.
2798         (i386_stap_adjust_register): New function.
2799         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2800         * stap-probe.c (stap_parse_register_operand): Call
2801         'gdbarch_stap_adjust_register'.
2802
2803 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2804
2805         PR python/24742
2806         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2807         * python/python.c (do_start_initialization): Use 'xmalloc'
2808         instead of 'PyMem_Malloc'.
2809
2810 2019-06-28  Tom Tromey  <tromey@adacore.com>
2811
2812         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2813         for Ada.
2814
2815 2019-06-27  Tom Tromey  <tromey@adacore.com>
2816
2817         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2818         objfile_key.
2819         (arm_find_mapping_symbol, arm_record_special_symbol)
2820         (_initialize_arm_tdep): Update.
2821         (arm_objfile_data_free): Remove.
2822
2823 2019-06-27  Tom Tromey  <tromey@adacore.com>
2824
2825         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2826         to cp_print_static_field.
2827
2828 2019-06-26  Tom Tromey  <tromey@adacore.com>
2829
2830         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2831         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2832         declare.
2833
2834 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2835
2836         * features/aarch64-core.c (create_feature_aarch64_core):
2837         Regenerate.
2838         * features/aarch64-core.xml: Add cpsr flags.
2839
2840 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2841
2842         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2843         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2844
2845 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2846
2847         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2848         field.
2849         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2850         use.
2851         (arm_record_special_symbol): Don't insert new symbol in sorted
2852         position, push it at the end.
2853
2854 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2855
2856         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2857         (arm_mapping_symbol_s): Remove.
2858         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2859         (arm_mapping_symbol_vec): New typedef.
2860         (struct arm_per_objfile): Add constructor.
2861         <section_maps>: Change type to
2862         std::unique_ptr<arm_mapping_symbol_vec[]>.
2863         (arm_compare_mapping_symbols): Remove.
2864         (arm_find_mapping_symbol): Adjust to section_maps type change.
2865         (arm_objfile_data_free): Call delete on arm_per_objfile.
2866         (arm_record_special_symbol): Adjust to section_maps type change.
2867         Allocate arm_per_objfile with new.
2868
2869 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2870
2871         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2872         with the command prefix.
2873
2874 2019-06-25  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2877         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2878
2879 2019-06-25  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2882         type.
2883         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2884         protected.
2885
2886 2019-06-25  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-winsource.c
2889         (tui_source_window_base::set_is_exec_point_at): Add check against
2890         LOA_ADDRESS.
2891
2892 2019-06-25  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-source.c (tui_set_source_content): Don't check before
2895         xfree.
2896         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.h (tui_update_source_window_as_is)
2901         (tui_alloc_source_buffer, tui_line_is_displayed)
2902         (tui_addr_is_displayed): Change type of win_info.
2903         * tui/tui-winsource.c (tui_update_source_window_as_is)
2904         (tui_clear_source_content, tui_show_source_line)
2905         (tui_show_source_content, tui_source_window_base::refill)
2906         (tui_source_window_base::set_is_exec_point_at)
2907         (tui_source_window_base::set_is_exec_point_at)
2908         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2909         (tui_alloc_source_buffer, tui_line_is_displayed)
2910         (tui_addr_is_displayed): Change type of win_info.  Update.
2911         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2912         (tui_source_window_base::do_make_visible_with_new_height):
2913         Update.
2914         * tui/tui-source.c (tui_set_source_content)
2915         (tui_set_source_content_nil)
2916         (tui_source_window::do_scroll_vertical): Update.
2917         * tui/tui-layout.c (show_layout): Update.
2918         * tui/tui-disasm.c (tui_set_disassem_content)
2919         (tui_disasm_window::do_scroll_vertical): Update.
2920         * tui/tui-data.h (tui_win_content): Remove.
2921         (struct tui_gen_win_info) <content, content_size>: Remove.
2922         (struct tui_source_element): Add initializers and destructor.
2923         (union tui_which_element, struct tui_win_element): Remove.
2924         (struct tui_source_window_base) <content>: New field.
2925         (struct tui_data_window): Remove destructor.
2926         (tui_alloc_content, tui_free_win_content)
2927         (tui_free_all_source_wins_content): Don't declare.
2928         * tui/tui-data.c (tui_initialize_static_data): Update.
2929         (init_content_element, tui_alloc_content): Remove.
2930         (~tui_gen_win_info): Update.
2931         (~tui_data_window, tui_free_all_source_wins_content)
2932         (tui_free_win_content, free_content, free_content_elements):
2933         Remove.
2934
2935 2019-06-25  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-winsource.h (tui_clear_source_content)
2938         (tui_erase_source_content, tui_show_source_content): Change type
2939         of win_info.
2940         * tui/tui-winsource.c (tui_clear_source_content)
2941         (tui_erase_source_content, tui_show_source_content): Change type
2942         of win_info.
2943         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2944         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2945         win_info.
2946         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2947         win_info.
2948         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-winsource.c (tui_clear_source_content)
2953         (tui_source_window_base::set_is_exec_point_at): Update.
2954         * tui/tui-source.c (tui_set_source_content_nil): Update.
2955         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2956         a bool.
2957         * tui/tui-data.c (init_content_element): Update.
2958
2959 2019-06-25  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2962         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2963         * tui/tui-layout.c (init_and_make_win): Update.
2964         * tui/tui.h (enum tui_win_type): Update.
2965         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2966         tui_win_is_auxillary.
2967         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2968         tui_win_is_auxillary.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2973         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2974         (tui_delete_data_content_windows, tui_display_all_data)
2975         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2976         Update.
2977         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2978         * tui/tui-regs.c (tui_last_regs_line_no)
2979         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2980         (tui_show_registers): Update.
2981         (tui_show_register_group): Return void.  Update.
2982         (tui_display_registers_from, tui_display_reg_element_at_line)
2983         (tui_display_registers_from_line, tui_check_register_values):
2984         Update.
2985         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2986         member.
2987         (struct tui_data_window) <regs_content>: Now a std::vector.
2988         <regs_content_count>: Remove.
2989         (tui_add_content_elements, tui_free_data_content): Don't declare.
2990         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2991         (init_content_element): Remove DATA_WIN case.  Add assert.
2992         (tui_add_content_elements): Remove.
2993         (tui_data_window): Update.
2994         (tui_free_data_content): Remove.
2995         (free_content_elements): Remove DATA_WIN case.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-data.c (tui_data_item_window): Update.
3000         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3001         * tui/tui-windata.c (tui_display_all_data)
3002         (tui_display_data_from_line): Update.
3003         (tui_check_data_values): Remove.
3004         * tui/tui-regs.c (tui_show_register_group)
3005         (tui_display_reg_element_at_line): Update.
3006         * tui/tui-hooks.c (tui_register_changed)
3007         (tui_refresh_frame_and_register_information): Call
3008         tui_check_register_values.
3009         * tui/tui-data.h (struct tui_data_window) <data_content,
3010         data_content_count, data_type>: Remove.
3011         (enum tui_data_type): Remove.
3012
3013         * tui/tui-data.c (tui_data_window::clear_detail)
3014         (~tui_data_window): Update.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3019         declare.
3020         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3021         Rename from tui_first_data_item_displayed.  Update.
3022         (tui_data_window::refresh_all)
3023         (tui_data_window::do_scroll_vertical): Update.
3024         * tui/tui-data.h (struct tui_data_window)
3025         <first_data_item_displayed>: Declare new method.
3026
3027 2019-06-25  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3030         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3031         contents...
3032         (tui_initialize_static_data): ...here.
3033
3034 2019-06-25  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3037         (tui_display_registers_from, tui_check_register_values): Update.
3038         (tui_display_register): Remove win_info parameter; update.
3039         (tui_get_register): Change type of parameters.
3040         * tui/tui-data.h (struct tui_data_element): Remove.
3041         (union tui_which_element) <data>: Remove.
3042         <data_window>: Change type.
3043         (struct tui_data_item_window): New.
3044         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3045         case.  Add assert.
3046         (~tui_data_item_window): New destructor.
3047         (free_content_elements): Remove DATA_ITEM_WIN case.
3048
3049 2019-06-25  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3052         Remove.
3053
3054 2019-06-25  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-data.h (struct tui_command_element): Remove.
3057         (union tui_which_element) <command>: Remove.
3058         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3059         assert.
3060         (free_content_elements): Remove CMD_WIN case.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-layout.c (tui_set_layout): Update.
3065         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3066         * tui/tui-data.c (layout_def): Update.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3071         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3072         (tui_source_window_base::set_new_height): Update.
3073         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3074         Update.
3075         (tui_set_locator_fullname, tui_set_locator_info)
3076         (tui_show_frame_info): Update.
3077         * tui/tui-source.c (tui_set_source_content)
3078         (tui_source_is_displayed): Update.
3079         * tui/tui-layout.c (show_source_disasm_command, show_data)
3080         (show_source_or_disasm_and_command): Update.
3081         * tui/tui-disasm.c (tui_set_disassem_content)
3082         (tui_get_begin_asm_address): Update.
3083         * tui/tui-data.h (struct tui_locator_element): Remove.
3084         (union tui_which_element) <locator>: Remove.
3085         (struct tui_locator_window): New.
3086         (tui_locator_win_info_ptr): Change return type.
3087         * tui/tui-data.c (_locator): Change type.
3088         (tui_locator_win_info_ptr): Change return type.
3089         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3090         (tui_alloc_content): Add assert.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.c
3095         (tui_exec_info_window::maybe_allocate_content): New method.
3096         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3097         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3098         (make_source_or_disasm_window): Add cast.
3099         * tui/tui-data.h (union tui_which_element) <simple_string>:
3100         Remove.
3101         (struct tui_source_info): New.
3102         (struct tui_source_window_base) <execution_info>: Change type.
3103         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3104         case, and add assert.
3105         (tui_alloc_content): Add assert.
3106
3107 2019-06-25  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3110         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3111         * tui/tui-data.c (tui_alloc_win_info): Remove.
3112
3113 2019-06-25  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3116         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3117         can_highlight.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3122         make_visible_with_new_height method.
3123         (tui_win_info::make_visible_with_new_height): New method.
3124         (tui_source_window_base::do_make_visible_with_new_height)
3125         (tui_data_window::do_make_visible_with_new_height)
3126         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3127         (make_visible_with_new_height): Remove.
3128         (tui_resize_all, tui_adjust_win_heights): Use
3129         make_visible_with_new_height method.
3130         * tui/tui-data.h (struct tui_win_info)
3131         <do_make_visible_with_new_height, make_visible_with_new_height>:
3132         New methods.
3133         (struct tui_source_window_base, struct tui_data_window)
3134         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3135         methods.
3136
3137 2019-06-25  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3140         method.
3141         (update_tab_width): Call update_tab_width method.
3142         * tui/tui-data.h (struct tui_win_info)
3143         (struct tui_source_window_base) <update_tab_width>: New methods.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3148         parameter.
3149         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3150         parameter.
3151         (tui_gen_win_info::make_visible): Update.
3152         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3153         parameter.
3154         * tui/tui-data.h (enum tui_box): New enum.
3155         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3156
3157 2019-06-25  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3160         init_and_make_win for EXEC_INFO_WIN.
3161         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3162         longer inline.
3163         (struct tui_win_info) <~tui_win_info>: Inline.
3164         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3165         Don't declare.
3166         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3167         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3168         Remove.
3169         (tui_initialize_static_data): Update.
3170         (~tui_gen_win_info): Handle more cleanup here.
3171         (~tui_source_window_base): Delete "execution_info".
3172         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-layout.c (make_command_window): Don't set
3177         can_highlight.
3178         (show_source_disasm_command): Call the reset method.
3179         (show_data): Don't set can_highlight.  Call the reset method.
3180         (tui_gen_win_info::reset): Rename from init_gen_win_info
3181         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3182         (show_source_or_disasm_and_command): Call the reset method.
3183         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3184         (struct tui_cmd_window): Set can_highlight.
3185
3186 2019-06-25  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3189         from make_visible.
3190         (tui_make_visible, tui_make_invisible): Rewrite.
3191         (tui_win_info::make_visible): Remove.
3192         (tui_source_window_base::make_visible): Update.
3193         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3194         method.  Moved from...
3195         (struct tui_win_info) <make_visible>: ...here.
3196
3197 2019-06-25  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-winsource.c
3200         (tui_source_window_base::do_scroll_horizontal): Remove direction
3201         parameter.
3202         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3203         direction parameter.
3204         * tui/tui-win.c (tui_win_info::forward_scroll)
3205         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3206         (tui_win_info::right_scroll): Update.
3207         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3208         direction parameter.
3209         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3210         direction parameter.
3211         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3212         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3213         Remove direction parameter.
3214         (struct tui_source_window_base, struct tui_source_window)
3215         (struct tui_disasm_window, struct tui_data_window)
3216         (struct tui_cmd_window): Update.
3217
3218 2019-06-25  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.h (tui_set_exec_info_content)
3221         (tui_show_exec_info_content, tui_erase_exec_info_content)
3222         (tui_clear_exec_info_content, tui_update_exec_info): Change
3223         argument to tui_source_window_base.
3224         * tui/tui-winsource.c (tui_set_exec_info_content)
3225         (tui_show_exec_info_content, tui_erase_exec_info_content)
3226         (tui_clear_exec_info_content, tui_update_exec_info): Change
3227         argument to tui_source_window_base.
3228
3229 2019-06-25  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3232         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3237         check.
3238
3239 2019-06-25  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3242         type to void.
3243         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3244         type to void.
3245         * tui/tui-source.c (tui_set_source_content): Update.
3246         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3247
3248 2019-06-25  Tom Tromey  <tom@tromey.com>
3249
3250         * tui/tui-win.c (window_name_completer, tui_set_focus)
3251         (tui_all_windows_info): Use name method.
3252         * tui/tui-data.h (struct tui_gen_win_info)
3253         (struct tui_source_window, struct tui_disasm_window)
3254         (struct tui_data_window, struct tui_cmd_window) <name>: New
3255         method.
3256         (tui_win_name): Don't declare.
3257         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3258         (tui_win_name): Remove.
3259
3260 2019-06-25  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-winsource.h (tui_update_source_window)
3263         (tui_update_source_window_as_is): Change parameter type.
3264         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3265         to be a tui_source_window_base.
3266         (tui_update_source_window_as_is): Likewise.
3267         * tui/tui-win.c (make_visible_with_new_height): Update.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-winsource.c (tui_erase_source_content)
3272         (tui_show_source_content, tui_show_exec_info_content)
3273         (tui_erase_exec_info_content): Use refresh_window method.
3274         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3275         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3276         from tui_refresh_win.
3277         (tui_data_window::refresh_window): New method.
3278         (tui_win_info::refresh, tui_source_window_base::refresh)
3279         (tui_refresh_all): Use refresh_window method.
3280         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3281         method.
3282         * tui/tui-regs.c (tui_display_register): Call refresh_window
3283         method.
3284         * tui/tui-layout.c (show_source_disasm_command)
3285         (show_source_or_disasm_and_command): Call refresh_window method.
3286         * tui/tui-data.h (struct tui_gen_win_info)
3287         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3288         New method.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui.c (tui_rl_other_window, tui_enable)
3293         (tui_is_window_visible, tui_get_command_dimension): Update.
3294         * tui/tui-winsource.c (tui_update_source_window_as_is)
3295         (tui_clear_source_content, tui_erase_source_content)
3296         (tui_show_source_line, tui_source_window_base::refill)
3297         (tui_source_window_base::do_scroll_horizontal)
3298         (tui_source_window_base::set_is_exec_point_at)
3299         (tui_update_breakpoint_info, tui_set_exec_info_content)
3300         (tui_alloc_source_buffer, tui_line_is_displayed)
3301         (tui_addr_is_displayed): Update.
3302         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3303         (tui_check_and_display_highlight_if_needed)
3304         (tui_win_info::make_visible, tui_win_info::refresh)
3305         (tui_refresh_all): Update.
3306         * tui/tui-windata.c (tui_first_data_item_displayed)
3307         (tui_delete_data_content_windows, tui_erase_data_content)
3308         (tui_display_all_data, tui_data_window::refresh_all)
3309         (tui_check_data_values): Update.
3310         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3311         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3312         (tui_win_info::backward_scroll, tui_refresh_all_win)
3313         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3314         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3315         (tui_source_window_base::set_new_height)
3316         (tui_data_window::set_new_height)
3317         (make_invisible_and_set_new_height)
3318         (make_visible_with_new_height, new_height_ok)
3319         (parse_scrolling_args): Update.
3320         * tui/tui-stack.c (tui_show_frame_info): Update.
3321         * tui/tui-source.c (tui_set_source_content)
3322         (tui_set_source_content_nil, tui_source_is_displayed)
3323         (tui_source_window::do_scroll_vertical): Update.
3324         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3325         (tui_display_registers_from, tui_display_reg_element_at_line)
3326         (tui_check_register_values, tui_reg_command): Update.
3327         * tui/tui-layout.c (tui_default_win_height)
3328         (show_source_disasm_command, show_data, init_and_make_win)
3329         (show_source_or_disasm_and_command): Update.
3330         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3331         (tui_redisplay_readline, tui_mld_flush)
3332         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3333         (tui_getc): Update.
3334         * tui/tui-disasm.c (tui_set_disassem_content)
3335         (tui_disasm_window::do_scroll_vertical): Update.
3336         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3337         Now virtual.
3338         (struct tui_win_info): Derive from tui_gen_win_info.
3339         <~tui_win_info>: Mark as override.
3340         <generic>: Remove member.
3341         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3342         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3343         (~tui_data_window, ~tui_win_info)
3344         (tui_free_all_source_wins_content): Update.
3345         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3346
3347 2019-06-25  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-layout.c (init_and_make_win): Use new.
3350         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3351         destructor, initializers.
3352         (tui_alloc_generic_win_info): Don't declare.
3353         * tui/tui-data.c (_locator): Add argument to constructor.
3354         (source_win, disasm_win): New globals.
3355         (exec_info): Remove.
3356         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3357         Update.
3358         (tui_alloc_generic_win_info): Remove.
3359         (init_content_element): Use new.
3360         (tui_win_info::tui_win_info): Update.
3361         (free_content_elements) <case DATA_WIN>: Use delete.
3362
3363 2019-06-25  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3366         * tui/tui-windata.c (tui_first_data_item_displayed)
3367         (tui_delete_data_content_windows): Update.
3368         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3369         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3370         (tui_display_registers_from, tui_check_register_values): Update.
3371         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3372         pointer.
3373         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3374         window.
3375         (tui_free_data_content): Update.
3376         (free_content_elements) <case DATA_WIN>: Free the window.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3381         Update.
3382         * tui/tui-layout.c (make_command_window)
3383         (show_source_disasm_command, show_data, init_and_make_win)
3384         (show_source_or_disasm_and_command): Update.
3385         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3386         method.
3387         <can_highight, is_highlighted>: Now bool.
3388         (tui_set_win_highlight): Don't declare.
3389         * tui/tui-data.c (tui_set_win_highlight): Remove.
3390
3391 2019-06-25  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-wingeneral.c (make_visible): Remove check of window
3394         type.
3395
3396 2019-06-25  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-win.c (tui_win_info::max_height)
3399         (tui_cmd_window::max_height): New methods.
3400         (new_height_ok): Call max_height.
3401         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3402         <max_height>: New method.
3403
3404 2019-06-25  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-win.c (tui_source_window_base::set_new_height)
3407         (tui_data_window::set_new_height): New methods.
3408         (make_invisible_and_set_new_height): Call set_new_height method.
3409         * tui/tui-data.h (struct tui_win_info)
3410         (struct tui_source_window_base, struct tui_data_window)
3411         <set_new_height>: New method.
3412
3413 2019-06-25  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3416         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3417         tui_refresh_data_win.
3418         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3419         method.
3420         (tui_refresh_all_win): Call the refresh_all method.
3421         (tui_set_focus): Likewise.
3422         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3423         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3424         Likewise.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-winsource.h (tui_refill_source_window)
3429         (tui_set_is_exec_point_at): Don't declare.
3430         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3431         (tui_source_window_base::refill): Rename from
3432         tui_refill_source_window.
3433         (tui_source_window_base::do_scroll_horizontal): Update.
3434         (tui_source_window_base::set_is_exec_point_at): Rename from
3435         tui_set_is_exec_point_at.
3436         (tui_update_all_breakpoint_info): Update.
3437         * tui/tui-stack.c (tui_show_frame_info): Update.
3438         * tui/tui-layout.c (show_data): Add cast.
3439         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3440         * tui/tui-data.h (struct tui_source_window_base) <refill,
3441         set_is_exec_point_at>: New methods.
3442         (tui_source_windows, tui_add_to_source_windows): Update types.
3443         (tui_add_to_source_windows): Remove redundant declaration.
3444         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3445         (tui_source_windows): Change return type.
3446         (tui_clear_source_windows_detail): Update.
3447         (tui_add_to_source_windows): Change type of parameter.
3448         (tui_free_all_source_wins_content): Update.
3449
3450 2019-06-25  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-wingeneral.c (tui_win_info::refresh)
3453         (tui_source_window_base::refresh): New methods.
3454         (tui_refresh_all): Call the refresh method.
3455         * tui/tui-data.h (struct tui_win_info)
3456         (struct tui_source_window_base) <refresh>: New method.
3457
3458 2019-06-25  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui.h (tui_is_window_visible): Return bool.
3461         * tui/tui.c (tui_is_window_visible): Return bool.
3462         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3463         (tui_make_visible, tui_make_invisible)
3464         (tui_win_info::make_visible)
3465         (tui_source_window_base::make_visible, make_all_visible)
3466         (tui_make_all_visible, tui_make_all_invisible): Update.
3467         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3468         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3469         bool.
3470         (struct tui_win_info, struct tui_source_window_base)
3471         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3472         * tui/tui-data.c (tui_init_generic_part): Update.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3477         (tui_source_window_base::make_visible): New methods.
3478         (make_all_visible): Make method call.
3479         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3480         (struct tui_source_window_base, struct tui_cmd_window): Override
3481         make_visible.
3482         (tui_win_is_source_type): Don't declare.
3483         * tui/tui-data.c (tui_win_is_source_type): Remove.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3488         NULL check.
3489
3490 2019-06-25  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3493         Inline constructor.  Add initializers for members.
3494         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3495         constructors; now inline in class.
3496
3497 2019-06-25  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-regs.c (tui_show_registers): Update.
3500         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3501         bool.
3502         * tui/tui-data.c (tui_data_window::clear_detail)
3503         (tui_data_window): Update.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-windata.c (tui_display_all_data)
3508         (tui_display_data_from_line, tui_display_data_from)
3509         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3510         Update.
3511         * tui/tui-regs.c (tui_last_regs_line_no)
3512         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3513         (tui_show_registers, tui_show_register_group)
3514         (tui_display_registers_from, tui_display_reg_element_at_line)
3515         (tui_display_registers_from_line, tui_check_register_values)
3516         (tui_reg_next, tui_reg_prev): Update.
3517         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3518         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3519         tui_data_window.
3520         (struct tui_win_info) <detail>: Remove.  Add new fields from
3521         tui_data_info.
3522         (TUI_DATA_WIN): Add cast.
3523         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3524         (~tui_data_window): Simplify.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-layout.c (show_source_disasm_command)
3529         (show_source_or_disasm_and_command): Update.
3530         * tui/tui-io.c (update_cmdwin_start_line)
3531         (tui_redisplay_readline): Update.
3532         * tui/tui-data.h (struct tui_command_info): Remove.
3533         (struct tui_win_info) <detail>: Remove command_info member.
3534         (struct tui_data_window) <start_line>: New member, from
3535         tui_command_info.
3536         (TUI_CMD_WIN): Add casts.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-winsource.c (tui_update_source_window)
3541         (tui_refill_source_window)
3542         (tui_source_window_base::do_scroll_horizontal)
3543         (tui_update_breakpoint_info, tui_set_exec_info_content)
3544         (tui_show_exec_info_content, tui_erase_exec_info_content)
3545         (tui_clear_exec_info_content): Update.
3546         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3547         Update.
3548         * tui/tui-win.c (make_invisible_and_set_new_height)
3549         (make_visible_with_new_height): Update.
3550         * tui/tui-source.c (tui_set_source_content)
3551         (tui_show_symtab_source): Update.
3552         * tui/tui-layout.c (extract_display_start_addr)
3553         (show_source_disasm_command, show_data)
3554         (make_source_or_disasm_window)
3555         (show_source_or_disasm_and_command): Update.
3556         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3557         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3558         "gdbarch".
3559         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3560         to tui_source_window_base.
3561         (struct tui_win_info) <detail>: Remove source_info member.
3562         (struct tui_source_window_base) <has_locator>: Inline.
3563         Move contents from tui_source_info; rename has_locator member to
3564         m_has_locator.
3565         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3566         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3567         header file.
3568         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3569         Simplify.
3570         (tui_free_all_source_wins_content): Cast to
3571         tui_source_window_base.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-win.c (make_invisible_and_set_new_height)
3576         (make_visible_with_new_height): Call has_locator method.
3577         * tui/tui-layout.c (show_source_disasm_command, show_data)
3578         (show_source_or_disasm_and_command): Update for bool change.
3579         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3580         (tui_win_info) <has_locator>: New method.
3581         (struct tui_source_window_base) <has_locator>: New method.
3582         (tui_win_has_locator): Don't declare.
3583         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3584         from tui_win_has_locator.
3585         (tui_source_window_base): Use false, not FALSE.
3586
3587 2019-06-25  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3590         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3591         clear_detail method directly.
3592         (tui_clear_win_detail): Remove.
3593
3594 2019-06-25  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3597         "this", not TUI_DISASM_WIN.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3602         declare.
3603         * tui/tui-winsource.c
3604         (tui_source_window_base::do_scroll_horizontal): Rename from
3605         tui_horizontal_source_scroll.
3606         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3607         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3608         from tui_vertical_data_scroll.
3609         * tui/tui-win.h (tui_scroll): Don't declare.
3610         * tui/tui-win.c (tui_win_info::forward_scroll)
3611         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3612         (tui_win_info::right_scroll): Rename and update.
3613         (tui_scroll_forward_command, tui_scroll_backward_command)
3614         (tui_scroll_left_command, tui_scroll_right_command): Update.
3615         (tui_scroll): Remove.
3616         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3617         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3618         from tui_vertical_source_scroll.
3619         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3620         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3621         from tui_vertical_disassem_scroll.
3622         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3623         do_scroll_horizontal>: New methods.
3624         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3625         Likewise.
3626         (struct tui_source_window_base): Add do_scroll_horizontal.
3627         (struct tui_source_window, struct tui_disasm_window): Add
3628         do_scroll_vertical.
3629         (struct tui_data_window, struct tui_cmd_window): Add
3630         do_scroll_horizontal and do_scroll_vertical.
3631         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3632
3633 2019-06-25  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-data.h (struct tui_source_window_base): New struct.
3636         (struct tui_source_window): Derive from tui_source_window_base.
3637         (struct tui_disasm_window): New struct.
3638         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3639         from tui_source_window::clear_detail.
3640         (tui_source_window_base): Rename from tui_source_window.
3641         (~tui_source_window_base): Rename from ~tui_source_window.
3642         (tui_alloc_win_info): Create a tui_disasm_window.
3643
3644 2019-06-25  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-data.h (struct tui_source_window)
3647         (struct tui_data_window): Declare destructors.
3648         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3649         destructors.
3650         (tui_win_info): Simplify.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-winsource.c (tui_display_main)
3655         (tui_update_source_windows_with_addr)
3656         (tui_update_all_breakpoint_info): Update.
3657         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3658         (new_height_ok, parse_scrolling_args): Update.
3659         * tui/tui-stack.c (tui_show_frame_info): Update.
3660         * tui/tui-data.h (struct tui_list): Remove.
3661         (tui_source_windows): Return a reference to a std::vector.
3662         * tui/tui-data.c (source_windows): Now a std::vector.
3663         (tui_source_windows): Change return type.
3664         (tui_clear_source_windows): Rewrite.
3665         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3666         (tui_free_all_source_wins_content): Rewrite.
3667
3668 2019-06-25  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3671         (struct tui_data_window, struct tui_cmd_window): Declare
3672         clear_detail method.
3673         * tui/tui-data.c (tui_source_window::clear_detail)
3674         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3675         methods.
3676         (tui_clear_win_detail): Simplify.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-layout.c (make_source_window, make_disasm_window)
3681         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3682         Return the new window.
3683         (show_source_disasm_command, show_data)
3684         (show_source_or_disasm_and_command): Update.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3689         parameter.  Return the new window.
3690         (show_source_disasm_command): Update and remove NULL check.
3691         (show_source_or_disasm_and_command): Update.
3692
3693 2019-06-25  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3696
3697 2019-06-25  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-data.h (struct tui_win_info): Make constructor
3700         protected.  Make destructor virtual.  Add initializers.
3701         (tui_source_window, tui_data_window, tui_cmd_window): New
3702         classes.
3703         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3704         constructor.  Add "type" parameter.
3705         (tui_source_window, tui_data_window, tui_cmd_window): New
3706         constructors.
3707         (tui_alloc_win_info): Instantiate the appropriate subclass.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-win.c (tui_resize_all): Use delete.
3712         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3713         destructor.
3714         (tui_free_window): Don't declare.
3715         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3716         Update.
3717
3718 2019-06-25  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-data.h (struct tui_win_info): Add constructor.
3721         * tui/tui-data.c (tui_alloc_win_info): Use new.
3722         (tui_free_window): Use delete.
3723
3724 2019-06-22  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3727         declare.
3728         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3729
3730 2019-06-22  Tom Tromey  <tom@tromey.com>
3731
3732         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3733         declare.
3734         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3735
3736 2019-06-22  Tom de Vries  <tdevries@suse.de>
3737
3738         * dwarf2read.c (create_addrmap_from_aranges)
3739         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3740         instead of '%zu'.
3741
3742 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3743
3744         * dwarf2read.h (dwarf2_section_info_def): Remove.
3745         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3746         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3747         std::vector<dwarf2_section_info>.
3748         (struct dwo_file) <~dwo_file>: Remove.
3749         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3750         types field.
3751         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3752         (dwarf2_read_debug_names): Likewise.
3753         (create_debug_types_hash_table): Change parameter type to
3754         array_view, adjust code accordingly.
3755         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3756         (partial_die_info::fixup): Likewise.
3757         (determine_prefix): Likewise.
3758         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3759
3760 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3761
3762         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3763         gdb_bfd_ref_ptr.
3764         <~dwo_file>: Remove call to gdb_bfd_unref.
3765         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3766         gdb_bfd_ref_ptr::get.
3767
3768 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3769
3770         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3771         type to htab_up.
3772         * dwarf2read.c (struct dwo_file): Initialize fields.
3773         <~dwo_file>: New.
3774         (free_dwo_file): Remove, move content to ~dwo_file.
3775         (struct dwo_file_deleter): Remove.
3776         (dwo_file_up>: Remove custom deleter.
3777         (free_dwo_files): Remove.
3778         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3779         dwo_files.
3780         (process_skeletonless_type_units): Call unique_ptr::get.
3781         (allocate_dwo_file_hash_table): Add deleter to created hash
3782         table.  Change return type to htab_up.
3783         (lookup_dwo_file_slot): Don't memset dwo_file, call
3784         unique_ptr::get.
3785         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3786         (create_dwo_unit_in_dwp_v2): Likewise.
3787         (open_and_init_dwo_file): Likewise.
3788         (free_dwo_file_from_slot): Remove.
3789
3790 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3791
3792         * dwarf2read.h (struct dwarf2_section_info) <readin,
3793         is_virtual>: Change type to bool.
3794         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3795         true instead of 1.
3796
3797 2019-06-19  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-data.h (tui_init_content_element): Don't declare.
3800
3801 2019-06-19  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-data.h (tui_init_win_info): Don't declare.
3804
3805 2019-06-19  Tom de Vries  <tdevries@suse.de>
3806
3807         * dwarf2read.h (abstract_to_concrete): Change type to
3808         std::unordered_map<sect_offset, std::vector<sect_offset>,
3809         gdb::hash_enum<sect_offset>>.
3810
3811 2019-06-19  Tom Tromey  <tromey@adacore.com>
3812
3813         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3814         EVAL_AVOID_SIDE_EFFECTS specially.
3815
3816 2019-06-19  Tom Tromey  <tromey@adacore.com>
3817
3818         * source-cache.c (highlighter): New global.
3819         (source_cache::get_source_lines): Create a highlighter on demand.
3820
3821 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * defs.h (deprecated_interactive_hook): Delete declaration.
3824         * interps.c (clear_interpreter_hooks): Remove use of
3825         deprecated_interactive_hook.
3826         * top.c (deprecated_interactive_hook): Delete definition.
3827         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3828
3829 2019-06-18  Tom de Vries  <tdevries@suse.de>
3830
3831         PR gdb/24515
3832         * dwarf2read.h (abstract_to_concrete): Change type from
3833         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3834         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3835         * dwarf2read.c (read_variable): Update.
3836         (dwarf2_fetch_die_loc_sect_off): Update.
3837
3838 2019-06-17  Tom de Vries  <tdevries@suse.de>
3839
3840         PR gdb/24617
3841         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3842         accessing parent[parent_len - 1].
3843
3844 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3845
3846         PR gdb/24364
3847         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3848         call dtrace_process_dof with NULL dof.
3849
3850 2019-06-16  Tom de Vries  <tdevries@suse.de>
3851
3852         PR gdb/24445
3853         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3854
3855 2019-06-16  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3858         (make_all_visible): Use address of member.
3859
3860 2019-06-16  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3863         (tui_free_window, free_content, free_content_elements): Remove
3864         unnecessary cast.
3865         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3866         cast.
3867         * tui/tui-regs.c (tui_show_register_group)
3868         (tui_display_registers_from, tui_display_reg_element_at_line):
3869         Remove unnecessary cast.
3870
3871 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * linux-nat.c (normal_mask): Delete.
3874         (_initialize_linux_nat): Don't initialise normal_mask.
3875
3876 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3877
3878         PR gdb/24445
3879         * dwarf-index-write.h (write_psymtabs_to_index): Add
3880         dwz_basename parameter.
3881         * dwarf-index-write.c (write_gdbindex): Move file writing to
3882         write_gdbindex_1.  Change return type void.
3883         (assert_file_size): Move up, remove filename parameter.
3884         (write_gdbindex_1): New function.
3885         (write_debug_names): Change return type to void, call
3886         assert_file_size.
3887         (struct index_wip_file): New struct.
3888         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3889         file logic to index_wip_file.  Write index for dwz file if
3890         needed.
3891         (save_gdb_index_command): Pass basename of dwz file, if present.
3892         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3893         build-id of dwz file, if present.
3894         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3895         (dwarf2_get_dwz_file): Likewise.
3896         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3897         (dwarf2_get_dwz_file): Likewise.
3898
3899 2019-06-16  Tom Tromey  <tom@tromey.com>
3900
3901         * coffread.c (process_coff_symbol): Use xstrdup.
3902         * value.c (create_internalvar): Use xstrdup.
3903
3904 2019-06-16  Tom Tromey  <tom@tromey.com>
3905
3906         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3907         * breakpoint.c (stopin_command, stopat_command)
3908         (until_break_command, decode_location_default): Remove unnecessary
3909         cast.
3910         * utils.c (subset_compare): Remove unnecessary cast.
3911         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3912         cast.
3913         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3914         cast.
3915         * infcmd.c (path_command): Remove unnecessary cast.
3916         * coffread.c (decode_type): Remove unnecessary cast.
3917         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3918         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3919         * tui/tui-stack.c (tui_show_locator_content)
3920         (tui_show_frame_info): Remove unnecessary cast.
3921         * tui/tui-win.c (tui_scroll_forward_command)
3922         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3923         (parse_scrolling_args): Remove unnecessary cast.
3924         * tui/tui-data.c (init_win_info, tui_del_window)
3925         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3926         (free_content_elements): Remove unnecessary cast.
3927         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3928         unnecessary cast.
3929         * tui/tui-source.c (tui_set_source_content)
3930         (tui_vertical_source_scroll): Remove unnecessary cast.
3931         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3932         cast.
3933         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3934         * tui/tui-regs.c (tui_display_registers_from)
3935         (tui_display_register): Remove unnecessary cast.
3936         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3937         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3938         (make_visible): Remove unnecessary cast.
3939         * tui/tui-winsource.c (tui_erase_source_content)
3940         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3941         unnecessary cast.
3942         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3943         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3944         * stabsread.c (read_type, read_array_type, read_range_type):
3945         Remove unnecessary cast.
3946         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3947         (parse_symbol, parse_type, upgrade_type, parse_external)
3948         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3949         unnecessary cast.
3950         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3951
3952 2019-06-16  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-data.c (tui_alloc_generic_win_info)
3955         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3956         checks.
3957
3958 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3959             Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * f-typeprint.c (f_print_type): Don't return early for not
3962         associated or not allocated types.
3963         (f_type_print_varspec_suffix): Add print_rank parameter and print
3964         ranks of array types in case they dangling.
3965         (f_type_print_base): Add print_rank parameter.
3966
3967 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3968
3969         * NEWS: Mention new MI commands.
3970         * break-catch-throw.c (enum exception_event_kind): Move to
3971         breakpoint.h.
3972         (print_mention_exception_catchpoint): Output text as a single
3973         message.
3974         (catch_exception_command_1): Rename to...
3975         (catch_exception_event): ...this, make non-static, update header
3976         command, and change some parameter types.
3977         (catch_catch_command): Update for changes to
3978         catch_exception_command_1.
3979         (catch_throw_command): Likewise.
3980         (catch_rethrow_command): Likewise.
3981         * breakpoint.c (enum exception_event_kind): Delete.
3982         * breakpoint.h (enum exception_event_kind): Moved here from
3983         break-catch-throw.c.
3984         (catch_exception_event): Declare.
3985         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3986         (mi_cmd_catch_throw): New function.
3987         (mi_cmd_catch_rethrow): New function.
3988         (mi_cmd_catch_catch): New function.
3989         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3990         'catch-catch' entries.
3991         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3992         (mi_cmd_catch_rethrow): Declare.
3993         (mi_cmd_catch_catch): Declare.
3994
3995 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * annotate.c (annotate_source_line): Change return type to void,
3998         update implementation to match.
3999         * annotate.h (annotate_source_line): Change return type to void,
4000         update header comment.
4001         * stack.c (print_frame_info): Don't change what frame information
4002         is printed based on whether annotations are on or not.
4003
4004 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4007         (annotate_source): Make static.
4008         (annotate_source_line): Moved from source.c and renamed from
4009         identify_source_line.  Update the return type.
4010         * annotate.h (annotate_source): Delete declaration.
4011         (annotate_source_line): Declaration moved from source.h, and
4012         renamed from identify_source_line.  Return type updated.
4013         * source.c (identify_source_line): Moved to annotate.c and renamed
4014         to annotate_source_line.
4015         (info_line_command): Remove check of annotation_level.
4016         * source.h (identify_source_line): Move declaration to annotate.h
4017         and rename to annotate_source_line.
4018         * stack.c: Add 'annotate.h' include.
4019         (print_frame_info): Remove check of annotation_level before
4020         calling annotate_source_line.
4021
4022 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * source-cache.c (source_cache::get_plain_source_lines): Use
4025         open_source_file_with_line_charpos instead of just
4026         open_source_file, remove call to find_source_lines.
4027         (source_cache::get_source_lines): Likewise.
4028         * source.c (find_source_lines): Make static.
4029         (get_filename_and_charpos): Renamed into...
4030         (open_source_file_with_line_charpos): ..this along with changes to
4031         return a scoped_fd, and some other minor clean ups.
4032         (identify_source_line): Use open_source_file_with_line_charpos.
4033         (search_command_helper): Use open_source_file_with_line_charpos
4034         instead of just open_source_file, remove call to
4035         find_source_lines.
4036         * source.h (open_source_file_with_line_charpos): Declare new
4037         function.
4038         (find_source_lines): Delete declaration.
4039
4040 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * source.c (get_filename_and_charpos): Remove fullname
4043         parameter.
4044         (identify_source_line): Update call to get_filename_and_charpos.
4045
4046 2019-06-14  Tom Tromey  <tromey@adacore.com>
4047
4048         PR gdb/24502:
4049         * ui-style.h (skip_ansi_escape): Update comment.
4050         * ui-file.h (class no_terminal_escape_file): New class.
4051         * ui-file.c (no_terminal_escape_file::write)
4052         (no_terminal_escape_file::puts): New methods.
4053         * cli/cli-logging.c (handle_redirections): Use
4054         no_terminal_escape_file.
4055
4056 2019-06-14  Tom Tromey  <tromey@adacore.com>
4057
4058         * NEWS: Move convenience variable news above Python news.
4059
4060 2019-06-14  Tom Tromey  <tom@tromey.com>
4061
4062         * gnulib: Move directory to top-level.
4063         * configure.ac: Don't configure gnulib.
4064         * configure: Rebuild.
4065         * common/common-defs.h: Use new path to gnulib.
4066         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4067         (GNULIB_H): Remove.
4068         (INCGNU): Look in new gnulib location.
4069         (HFILES_NO_SRCDIR): Remove gnulib files.
4070         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4071         (generated_files): Remove GNULIB_H.
4072         ($(LIBGNU), all-lib): Remove targets.
4073         (distclean): Don't mention GNULIB_BUILDDIR.
4074         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4075
4076 2019-06-14  Tom Tromey  <tromey@adacore.com>
4077
4078         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4079         Warn if symbol file does not provide any symbols.
4080
4081 2019-06-14  Tom Tromey  <tromey@adacore.com>
4082
4083         * source.c (find_and_open_source): Respect basenames_may_differ.
4084
4085 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * annotate.c (annotate_breakpoints_invalid): Make use of
4088         scoped_restore_terminal_state.
4089         (annotate_frames_invalid): Likewise.
4090
4091 2019-06-14  Tom Tromey  <tromey@adacore.com>
4092
4093         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4094         allow assignment to an internalvar.
4095
4096 2019-06-14  Tom Tromey  <tromey@adacore.com>
4097
4098         * ada-lex.l: Allow "_" in attribute names.
4099
4100 2019-06-14  Tom Tromey  <tromey@adacore.com>
4101
4102         PR gdb/24653:
4103         * regcache.c (registers_changed): Don't call alloca.
4104         * top.c (execute_command): Don't call alloca.
4105
4106 2019-06-13  Pedro Alves  <palves@redhat.com>
4107
4108         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4109         'expression'.  When parsing an expression, error out if there's
4110         junk after "unlimited".
4111         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4112         (do_set_command): Adjust calls to is_unlimited_literal.
4113
4114 2019-06-13  Pedro Alves  <palves@redhat.com>
4115
4116         * compile/compile.c (make_compile_options_def_group): Add braces
4117         around array_view initializer.
4118         * thread.c (make_thread_apply_all_options_def_group)
4119         (make_thread_apply_all_options_def_group): Likewise.
4120
4121 2019-06-13  Pedro Alves  <palves@redhat.com>
4122
4123         * NEWS (New commands): Mention "maint test-options
4124         require-delimiter", "maint test-options unknown-is-error", "maint
4125         test-options unknown-is-operand" and "maint show
4126         test-options-completion-result".
4127         (New command options, command completion): New section.
4128         (Completion improvements): New section.
4129         Mention that you can abbreviate "unlimited".
4130
4131 2019-06-13  Pedro Alves  <palves@redhat.com>
4132
4133         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4134         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4135         * unittests/cli-utils-selftests.c (test_parse_flags)
4136         (test_parse_flags_qcs): Delete.
4137         (test_cli_utils): Don't call deleted functions.
4138
4139 2019-06-13  Pedro Alves  <palves@redhat.com>
4140
4141         * thread.c: Include "cli/cli-option.h".
4142         (tp_array_compar_ascending): Global.
4143         (tp_array_compar): Delete function.
4144         (tp_array_compar_ascending, tp_array_compar_descending): New
4145         functions.
4146         (ascending_option_def, qcs_flag_option_def)
4147         (thr_qcs_flags_option_defs)
4148         (make_thread_apply_all_options_def_group)
4149         (make_thread_apply_options_def_group): New.
4150         (thread_apply_all_command): Use gdb::option::process_options.
4151         (thread_apply_command_completer)
4152         (thread_apply_all_command_completer): New.
4153         (thread_apply_command): Use gdb::option::process_options.
4154         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4155         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4156         to generate help text of "thread apply".  Adjust "taas"'s help.
4157         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4158         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4159
4160 2019-06-13  Pedro Alves  <palves@redhat.com>
4161
4162         * thread.c (thread_apply_command): Check for invalid TID with
4163         isdigit instead of !isalpha.
4164
4165 2019-06-13  Pedro Alves  <palves@redhat.com>
4166
4167         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4168         (validate_flags_qcs): New.
4169         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4170         (validate_flags_qcs): Declare.
4171         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4172         (make_frame_apply_options_def_group): New.
4173         (frame_apply_command_count): Process options with
4174         gdb::option::process_options.
4175         (frame_apply_completer): New.
4176         (frame_apply_level_completer, frame_apply_all_completer)
4177         (frame_apply_completer): New.
4178         (_initialize_stack): Update help of "frame apply", "frame apply
4179         level", "frame apply all" and "faas" to mention supported options
4180         and install command completers.
4181         * stack.h (frame_apply_all_completer): Declare.
4182         * thread.c: Include "stack.h".
4183         (tfaas_command): Add "--".
4184         (_initialize_thread): Update help "tfaas" to mention supported
4185         options and install command completer.
4186
4187 2019-06-13  Pedro Alves  <palves@redhat.com>
4188
4189         * completer.c (complete_nested_command_line): New.
4190         (gdb_completion_word_break_characters_throw): Add assertion.
4191         * completer.h (complete_nested_command_line): Declare.
4192
4193 2019-06-13  Pedro Alves  <palves@redhat.com>
4194
4195         * stack.c (parse_backtrace_qualifiers): New.
4196         (backtrace_command): Use it.
4197         (backtrace_command_completer): Complete on qualifiers.
4198
4199 2019-06-13  Pedro Alves  <palves@redhat.com>
4200
4201         * frame.c: Include "cli/cli-option.h.
4202         (user_set_backtrace_options): New.
4203         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4204         Delete.
4205         (get_prev_frame): Adjust.
4206         (boolean_option_def, uinteger_option_def)
4207         (set_backtrace_option_defs): New.
4208         (_initialize_frame): Adjust and use
4209         gdb::option::add_setshow_cmds_for_options to install "set
4210         backtrace past-main" and "set backtrace past-entry".
4211         * frame.h: Include "cli/cli-option.h".
4212         (struct frame_print_options): Forward declare.
4213         (print_frame_arguments_all, print_frame_arguments_scalars)
4214         (print_frame_arguments_none): Declare.
4215         (print_entry_values): Delete declaration.
4216         (struct frame_print_options, user_frame_print_options): New.
4217         (struct set_backtrace_options): New.
4218         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4219         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4220         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4221         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4222         (list_args_or_locals): Add frame_print_options parameter.
4223         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4224         * python/py-framefilter.c (enumerate_args): Pass down
4225         USER_FRAME_PRINT_OPTIONS.
4226         * stack.c: Include "cli/cli-option.h".
4227         (print_frame_arguments_all, print_frame_arguments_scalars)
4228         (print_frame_arguments_none): Declare.
4229         (print_raw_frame_arguments, print_entry_values): Delete.
4230         (user_frame_print_options): New.
4231         (boolean_option_def, enum_option_def, frame_print_option_defs):
4232         New.
4233         (struct backtrace_cmd_options): New.
4234         (bt_flag_option_def): New.
4235         (backtrace_command_option_defs): New.
4236         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4237         (print_frame_arg, read_frame_arg, print_frame_args)
4238         (print_frame_info, print_frame): Add frame_print_options parameter
4239         and use it.
4240         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4241         (backtrace_command_1): Add frame_print_options and
4242         backtrace_cmd_options parameters and use them.
4243         (make_backtrace_options_def_group): New.
4244         (backtrace_command): Process command options with
4245         gdb::option::process_options.
4246         (backtrace_command_completer): New.
4247         (_initialize_stack): Extend "backtrace"'s help to mention
4248         supported options.  Install completer for "backtrace".
4249         Install some settings commands with add_setshow_cmds_for_options.
4250
4251 2019-06-13  Pedro Alves  <palves@redhat.com>
4252
4253         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4254         and that "set/show print raw frame-arguments" are now deprecated.
4255
4256         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4257         command.
4258         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4259         * stack.c (_initialize_stack): Install "set/show print
4260         raw-frame-arguments", and deprecate "set/show print raw
4261         frame-arguments".
4262         * valprint.c (_initialize_valprint): Deprecate "set/show print
4263         raw".
4264
4265 2019-06-13  Pedro Alves  <palves@redhat.com>
4266
4267         * compile/compile.c (struct compile_options): New.
4268         (compile_flag_option_def, compile_command_option_defs)
4269         (make_compile_options_def_group): New.
4270         (compile_file_command): Handle options with
4271         gdb::option::process_options.
4272         (compile_file_command_completer): New function.
4273         (compile_code_command): Handle options with
4274         gdb::option::process_options.
4275         (compile_code_command_completer): New function.
4276         (_initialize_compiler): Install completers for "compile code" and
4277         "compile file".  Mention available options in "compile code" and
4278         "compile code"'s help.
4279         * completer.c (advance_to_completion_word): New, factored out from
4280         ...
4281         (advance_to_expression_complete_word_point): ... this.
4282         (advance_to_filename_complete_word_point): New.
4283         * completer.h (advance_to_filename_complete_word_point): New
4284         declaration.
4285
4286 2019-06-13  Pedro Alves  <palves@redhat.com>
4287
4288         * compile/compile.c: Include "cli/cli-option.h".
4289         (compile_print_value): Scope data pointer is now a
4290         value_print_options pointer; adjust.
4291         (compile_print_command): Process options.  Scope data pointer is
4292         now a value_print_options pointer; adjust.
4293         (_initialize_compile): Update "compile print"'s help to include
4294         supported options.  Install a completer for "compile print".
4295         * cp-valprint.c (show_vtblprint, show_objectprint)
4296         (show_static_field_print): Delete.
4297         (_initialize_cp_valprint): Don't install "set print
4298         static-members", "set print vtbl", "set print object" here.
4299         * printcmd.c: Include "cli/cli-option.h" and
4300         "common/gdb_optional.h".
4301         (print_command_parse_format): Rework to fill in a
4302         value_print_options instead of a format_data.
4303         (print_value): Change parameter type from format_data pointer to
4304         value_print_options reference.  Adjust.
4305         (print_command_1): Process options.  Adjust to pass down a
4306         value_print_options.
4307         (print_command_completer): New.
4308         (_initialize_printcmd): Install print_command_completer as
4309         handle_brkchars completer for the "print" command.  Update
4310         "print"'s help to include supported options.
4311         * valprint.c: Include "cli/cli-option.h".
4312         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4313         here from cp-valprint.c.
4314         (boolean_option_def, uinteger_option_def)
4315         (value_print_option_defs, make_value_print_options_def_group):
4316         New.  Use gdb::option::add_setshow_cmds_for_options to install
4317         "set print elements", "set print null-stop", "set print repeats",
4318         "set print pretty", "set print union", "set print array", "set
4319         print address", "set print symbol", "set print array-indexes".
4320         * valprint.h: Include <string> and "cli/cli-option.h".
4321         (make_value_print_options_def_group): Declare.
4322         (print_value): Change parameter type from format_data pointer to
4323         value_print_options reference.
4324         (print_command_completer): Declare.
4325
4326 2019-06-13  Pedro Alves  <palves@redhat.com>
4327
4328         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4329         (COMMON_SFILES): Add maint-test-settings.c.
4330         * cli/cli-decode.c (boolean_enums): New global, factored out from
4331         ...
4332         (add_setshow_boolean_cmd): ... here.
4333         * cli/cli-decode.h (boolean_enums): Declare.
4334         * cli/cli-option.c: New file.
4335         * cli/cli-option.h: New file.
4336         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4337         factored out from ...
4338         (parse_cli_boolean_value(const char *)): ... this.
4339         (is_unlimited_literal): Change parameter type to pointer to
4340         pointer.  Adjust and advance ARG pointer.
4341         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4342         (parse_cli_var_enum): New, factored out from ...
4343         (do_set_command): ... this.  Adjust.
4344         * cli/cli-setshow.h (parse_cli_boolean_value)
4345         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4346         (parse_cli_var_enum): Declare.
4347         * cli/cli-utils.c: Include "cli/cli-option.h".
4348         (get_ulongest): New.
4349         * cli/cli-utils.h (get_ulongest): Declare.
4350         (check_for_argument): New overloads.
4351         * maint-test-options.c: New file.
4352
4353 2019-06-13  Pedro Alves  <palves@redhat.com>
4354
4355         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4356         parse a range if "-" is at the end of the string.
4357
4358 2019-06-13  Pedro Alves  <palves@redhat.com>
4359
4360         * cli/cli-setshow.c (parse_auto_binary_operation)
4361         (parse_cli_boolean_value): Don't allow "o".
4362
4363 2019-06-13  Pedro Alves  <palves@redhat.com>
4364
4365         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4366         * NEWS: Mention maint test-settings KIND.
4367         * maint-test-settings.c: New file.
4368
4369 2019-06-13  Pedro Alves  <palves@redhat.com>
4370
4371         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4372         completer.
4373         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4374         "set" completers.
4375
4376 2019-06-13  Pedro Alves  <palves@redhat.com>
4377
4378         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4379         after item.
4380
4381 2019-06-13  Pedro Alves  <palves@redhat.com>
4382
4383         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4384
4385 2019-06-13  Pedro Alves <palves@redhat.com>
4386
4387         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4388         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4389         call.
4390         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4391         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4392         calls.
4393         (check_for_argument): Skip spaces after argument.
4394
4395 2019-06-13  Pedro Alves  <palves@redhat.com>
4396
4397         * thread.c (thread_apply_command): Adjust TID parsing.
4398         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4399         detected before end of string.
4400         (tid_is_in_list): Error out if LIST is invalid.
4401
4402 2019-06-13  Pedro Alves  <palves@redhat.com>
4403
4404         * completer.c (complete_line_internal_1): Rewind completion word
4405         point.
4406         (completion_tracker::advance_custom_word_point_by): Change
4407         parameter type to int.
4408         * completer.h (completion_tracker::advance_custom_word_point_by):
4409         Likewise.
4410
4411 2019-06-13  Pedro Alves  <palves@redhat.com>
4412
4413         * completer.c (advance_to_completion_word): Handle delimiters.
4414
4415 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4416
4417         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4418
4419 2019-06-11  Tom Tromey  <tom@tromey.com>
4420
4421         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4422         (xmalloc_failed): Move to alloc.c.
4423         * alloc.c: New file.
4424         * Makefile.in (COMMON_SFILES): Add alloc.c.
4425
4426 2019-06-11  Tom Tromey  <tom@tromey.com>
4427
4428         * nat/linux-waitpid.c: Don't include server.h.
4429         (linux_debug): Remove.
4430         (my_waitpid): Update.
4431
4432 2019-06-11  Tom Tromey  <tromey@adacore.com>
4433
4434         * infcall.c (_initialize_infcall): Remove trailing newline from
4435         help.
4436         * user-regs.c (_initialize_user_regs): Remove trailing newline
4437         from help.
4438         * typeprint.c (_initialize_typeprint): Remove trailing newline
4439         from help.
4440         * reverse.c (_initialize_reverse): Remove trailing newlines from
4441         help.
4442         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4443         from help.
4444         * language.c (add_set_language_command): Remove trailing newline
4445         from help.
4446         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4447         help.
4448         * disasm.c (_initialize_disasm): Remove trailing newline from
4449         help.
4450         * top.c (init_main): Remove trailing newline from help.
4451         * interps.c (_initialize_interpreter): Remove trailing newline
4452         from help.
4453         * btrace.c (_initialize_btrace): Remove trailing newlines from
4454         help.
4455         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4456         from help.
4457         * python/python.c (_initialize_python): Remove trailing newline
4458         from help.
4459         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4460         help.
4461         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4462         from help.  Reformat some text.
4463         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4464         from help.
4465         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4466         newline from help.
4467
4468 2019-06-11  Tom Tromey  <tromey@adacore.com>
4469
4470         * darwin-nat.c (darwin_decode_exception_message)
4471         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4472
4473 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * valops.c (value_slice): Check for not allocated or not
4476         associated values.
4477
4478 2019-06-10  Tom de Vries  <tdevries@suse.de>
4479
4480         PR gdb/24618
4481         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4482         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4483         invalid.
4484
4485 2019-06-10  Tom de Vries  <tdevries@suse.de>
4486
4487         PR gdb/24611
4488         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4489         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4490
4491 2019-06-10  Tom de Vries  <tdevries@suse.de>
4492
4493         PR symtab/24545
4494         * symtab.c (struct demangled_name_entry): Add language field.
4495         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4496         static minimal symbol".  Set and use language field.
4497
4498 2019-06-10  Tom Tromey  <tromey@adacore.com>
4499
4500         * ada-lang.c (_initialize_ada_language): Update help text.
4501
4502 2019-06-10  Tom Tromey  <tromey@adacore.com>
4503
4504         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4505         with a newline.
4506         * guile/guile.c (handle_boot_error): Don't end warning with a
4507         newline.
4508         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4509         warning with a newline.
4510         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4511         newline.
4512         (s12z_frame_cache): Likewise.
4513         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4514         a newline.
4515         * solib-svr4.c (disable_probes_interface): Don't end warning with
4516         a newline.
4517         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4518         newline.
4519         * python/python.c (do_finish_initialization): Don't end warning
4520         with a newline.
4521
4522 2019-06-10  Tom Tromey  <tom@tromey.com>
4523
4524         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4525         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4526         gdbpy_enter.
4527
4528 2019-06-10  Tom Tromey  <tromey@adacore.com>
4529
4530         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4531         data.
4532         (elf_new_init): Don't call stabsread_new_init.
4533         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4534         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4535         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4536
4537 2019-06-10  Tom de Vries  <tdevries@suse.de>
4538
4539         PR symtab/16264
4540         PR symtab/24517
4541         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4542
4543 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4544
4545         * source.c (find_and_open_source): Also rewrite relative file
4546         names.
4547
4548 2019-04-26  Amos Bird  <amosbird@gmail.com>
4549
4550         * annotate.c (annotate_thread_exited): Add "thread-exited"
4551         annotation.
4552
4553 2019-06-06  Tom Tromey  <tromey@adacore.com>
4554
4555         * maint.h (class scoped_command_stats): Use
4556         DISABLE_COPY_AND_ASSIGN.
4557         <print_time>: New method.
4558         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4559         print_time.
4560         (scoped_command_stats::print_time): New method.
4561
4562 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4565         instructions of lengths 6 or 8 bytes.
4566
4567 2019-06-04  Pedro Alves  <palves@redhat.com>
4568
4569         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4570
4571         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4572         * breakpoint.c (condition_completer): Likewise.
4573         * cli/cli-dump.c (scan_expression): Likewise.
4574         * common/filestuff.c (mkdir_recursive): Likewise.
4575         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4576         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4577         (gdb_abspath): Likewise.
4578         * compile/compile-cplus-types.c
4579         (compile_cplus_instance::decl_name): Likewise.
4580         * completer.c (complete_explicit_location):
4581         (signal_completer, reg_or_group_completer_1): Likewise.
4582         * cp-support.c (cp_remove_params_if_any): Likewise.
4583         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4584         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4585         * infcmd.c (strip_bg_char): Likewise.
4586         * linespec.c (copy_token_string): Likewise.
4587         * mi/mi-main.c (output_cores): Likewise.
4588         * psymtab.c (psymtab_search_name):
4589         * symfile.c (test_set_ext_lang_command): Likewise.
4590         * target.c (target_fileio_read_stralloc): Likewise.
4591         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4592         * value.c (complete_internalvar): Likewise.
4593
4594 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4595
4596         Add objfile property to gdb.Type.
4597         * NEWS: Mention Python API addition.
4598         * python/py-type.c (typy_get_objfile): New method.
4599
4600 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4601
4602         * NEWS: Mention the new set|show style [title|highlight].
4603         Mention changes to "show style", "help" and "apropos".
4604
4605 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4606
4607         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4608         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4609         instead of print_help_for_command.
4610         (print_doc_of_command): New function.
4611         (help_list): Add 'apropos -v word' suggestion.
4612         (print_help_for_command): Style the command name using title style.
4613         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4614         (_initialize_cli_cmds): Describe -v in apropos_command help.
4615
4616 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4617
4618         * cli/cli-style.h (cli_style_option): Add name in constructor,
4619         add m_name class member, add constructor with intensity,
4620         add name class function.
4621         (cli_style_option::add_setshow_commands): Remove name argument.
4622         (highlight_style, title_style): New styles.
4623         * cli/cli-style.c (do_show): New function that shows a style
4624         characteristic styling the style name with itself.
4625         (set_style_name): New function.
4626         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4627         Update all callers according to the changes in cli/cli-style.h.
4628         * utils.h (fputs_highlighted): New function.
4629         * utils.c (fputs_highlighted): Likewise.
4630
4631 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4632
4633         * NEWS: Mention new pipe command and new convenience variables.
4634
4635 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4636
4637         * cli/cli-cmds.c (pipe_command): New function.
4638         (_initialize_cli_cmds): Call add_com for pipe_command.
4639         Define | as an alias for pipe.
4640         (exit_status_set_internal_vars): New function.
4641         (shell_escape): Call exit_status_set_internal_vars.
4642         cli/cli-decode.c (find_command_name_length): Recognize | as
4643         a single character command.
4644
4645 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4646
4647         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4648         top.c (execute_command_to_ui_file): New function, mostly a copy
4649         of execute_command_to_string.
4650         (execute_command_to_string): Implement by calling
4651         execute_command_to_ui_file.
4652
4653 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4654
4655         * top.h (saved_command_line): Remove declaration.
4656         * top.c (previous_saved_command_line, previous_repeat_arguments):
4657         New variables.
4658         (saved_command_line): Make static, define together with other
4659         'repeat variables'.
4660         (dont_repeat): Clear repeat_arguments.
4661         (repeat_previous, get_saved_command_line, save_command_line):
4662         New functions.
4663         (gdb_init): Initialize saved_command_line
4664         and previous_saved_command_line.
4665         * main.c (captured_main_1): Remove saved_command_line initialization.
4666         * event-top.c (handle_line_of_input): Update to use
4667         the new 'repeat' related functions instead of direct access to
4668         saved_command_line.
4669         * command.h (repeat_previous, get_saved_command_line,
4670         save_command_line): New declarations.
4671         (dont_repeat): Add comment.
4672
4673 2019-05-30  Tom Tromey  <tromey@adacore.com>
4674
4675         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4676         Fix comment.
4677         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4678
4679 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4680
4681         PR cli/24587
4682         * completer.c (complete): Initialize variable word.
4683
4684 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4685
4686         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4687         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4688         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4689         'body' is NULL to the outter 'if', protecting the '!is_define'
4690         situation as well.
4691
4692 2019-05-29  Tom Tromey  <tromey@adacore.com>
4693
4694         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4695         (dwarf_unknown): New function.
4696         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4697         (dwarf_type_encoding_name): Use dwarf_unknown.
4698
4699 2019-05-29  Tom Tromey  <tromey@adacore.com>
4700
4701         PR c++/20020:
4702         * cp-valprint.c (cp_print_value_fields): Call
4703         cp_print_static_field inside "try".
4704
4705 2019-05-29  Tom Tromey  <tromey@adacore.com>
4706
4707         * inflow.c (struct terminal_info): Add default operator=.
4708         * configure: Rebuild.
4709         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4710         -Wdeprecated-copy-dtor, -Wredundant-move.
4711
4712 2019-05-29  Tom Tromey  <tromey@adacore.com>
4713
4714         * NEWS: Add entry.
4715         * infcmd.c (print_return_value_1): Handle finish_print
4716         option.
4717         (show_print_finish): New function.
4718         (_initialize_infcmd): Add "set/show print finish" commands.
4719         * valprint.c (user_print_options): Initialize new member.
4720         * valprint.h (struct value_print_options) <finish_print>: New
4721         member.
4722
4723 2019-05-28  Tom Tromey  <tromey@adacore.com>
4724
4725         * ada-lang.c (ada_remove_Xbn_suffix)
4726         (find_old_style_renaming_symbol)
4727         (parse_old_style_renaming): Remove.
4728         (ada_find_renaming_symbol): Don't call
4729         find_old_style_renaming_symbol.
4730         (ada_is_renaming_symbol): Rename from
4731         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4732         bool.  Now static.
4733         (ada_read_var_value): Update and simplify.
4734         * ada-exp.y (write_var_or_type): Remove old code.
4735
4736 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4737
4738         * event-top.c: Remove include comment.
4739         * inflow.c (class scoped_ignore_sigttou): Move from here...
4740         * inflow.h (class scoped_ignore_sigttou): ...to here.
4741         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4742         * top.c:  Remove include comment.
4743
4744 2019-05-27  Tom Tromey  <tom@tromey.com>
4745
4746         * NEWS: Fix typo.
4747
4748 2019-05-22  Tom Tromey  <tromey@adacore.com>
4749
4750         * target.c (target_follow_exec): Constify parameter.
4751         * target-delegates.c: Rebuild.
4752         * remote.c (remote_target::follow_exec): Constify parameter.
4753         * infrun.c (follow_exec): Constify parameter.
4754         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4755         (target_follow_exec): Likewise.
4756
4757 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4758
4759         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4760         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4761
4762 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4763
4764         * NEWS: Add debugredirect and testsuite sections.
4765
4766 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4767
4768         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4769         target descriptions using exclusively floating point register name
4770         aliases.
4771
4772 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         PR gdb/18644:
4775         * f-lang.c (build_fortran_types): Handle the case where
4776         gdbarch_floatformat_for_type returns a nullptr.
4777
4778 2019-05-21  Tom de Vries  <tdevries@suse.de>
4779
4780         PR cli/24587
4781         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4782
4783 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         PR gdb/18644:
4786         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4787         16-byte floats.
4788         * i386-tdep.c (i386_floatformat_for_type): Use
4789         floatformats_ia64_quad for the 16-byte floating point component
4790         within a fortran 32-byte complex number.
4791
4792 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4793
4794         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4795         delete default constructor.
4796         (find_partial_die): Update to return const struct.
4797         (partial_die_parent_scope): Move variable declaration into scope
4798         of its use and change its type to auto.
4799         (guess_partial_die_structure_name): Likewise.
4800         (partial_die_info::fixup): Likewise.
4801
4802 2019-05-17  Tom Tromey  <tromey@adacore.com>
4803
4804         * source.c (find_and_open_source): Remove cast.
4805
4806 2019-05-17  Tom Tromey  <tromey@adacore.com>
4807
4808         * annotate.c (annotate_source): Make "filename" const.
4809         * annotate.h (annotate_source): Use const.
4810
4811 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4812
4813         * disasm.c (set_disassembler_options): Send errors to stderr.
4814
4815 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4816
4817         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4818         (cli_interp_base::set_logging): Check debug_redirect.
4819         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4820         * cli/cli-logging.c (debug_redirect): Add static variable.
4821         (pop_output_files): Add default param.
4822         (handle_redirections): Print debug setting.
4823         (show_logging_command): Likewise.
4824         (_initialize_cli_logging): Add debugredirect command.
4825         * interps.c (current_interp_set_logging): Add debug_redirect
4826         parameter.
4827         * interps.h (set_logging): Add debug_redirect parameter.
4828         (current_interp_set_logging): Likewise.
4829         * mi/mi-common.h: Likewise.
4830         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4831
4832 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4833             Tom Tromey  <tromey@adacore.com>
4834
4835         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4836         directly.
4837         * cli/cli-interp.h (make_logging_output): Remove declaration.
4838         * cli/cli-logging.c (make_logging_output): Remove function.
4839         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4840         directly.
4841         * ui-file.c (tee_file::tee_file): Remove bools.
4842         (tee_file::~tee_file): Remove deletes.
4843         * ui-file.h (tee_file): Remove bools.
4844
4845 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4846
4847         * mi/mi-cmds.h (mi_cmd_complete): New function.
4848         * mi/mi-main.c (mi_cmd_complete): Likewise.
4849         * mi/mi-cmds.c: Define new MI command -complete.
4850         * NEWS: Mention new -complete command.
4851
4852 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4853
4854         * completer.h (complete): New function.
4855         * completer.c (complete): Likewise.
4856         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4857         function defined in completer.h.
4858
4859 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4860
4861         * MAINTAINERS (Write After Approval): Add myself.
4862
4863 2019-05-17  Tom de Vries  <tdevries@suse.de>
4864
4865         PR gdb/24094
4866         * dwarf2read.c (struct cu_partial_die_info): New struct.
4867         (find_partial_die): Return cu_partial_die_info.
4868         (partial_die_parent_scope, guess_partial_die_structure_name)
4869         (partial_die_info::fixup): Handle new return type of find_partial_die.
4870
4871 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4872
4873         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4874         "std::string", simplifying the algorithm.
4875
4876 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4877
4878         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4879         (stap_static_probe_ops::get_probes): Likewise.
4880
4881 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4882
4883         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4884         '-')" and "else if".
4885         (stap_parse_single_operand): Join checks for
4886         "gdbarch_stap_parse_special_token_p" and
4887         "gdbarch_stap_parse_special_token" in the same "if" statement.
4888         Invert check when verifying for operation on register
4889         displacement.
4890
4891 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4892
4893         * stap-probe.c (stap_get_opcode): Update comment.
4894         (stap_get_expected_argument_type): Likewise.
4895         (handle_stap_probe): Likewise.
4896
4897 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4898
4899         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4900         return type to 'bool'.  Adjust comment.  Use 'bool' when
4901         appropriate.
4902         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4903         * stap-probe.c (stap_parse_argument_1): Likewise.
4904         (stap_is_operator): Likewise.
4905         (stap_is_generic_prefix): Likewise.
4906         (stap_is_register_prefix): Likewise.
4907         (stap_is_register_indirection_prefix): Likewise.
4908         (stap_is_integer_prefix): Likewise.
4909         (stap_generic_check_suffix): Likewise.
4910         (stap_check_integer_suffix): Likewise.
4911         (stap_check_register_suffix): Likewise.
4912         (stap_check_register_indirection_suffix): Likewise.
4913         (stap_parse_register_operand): Likewise.
4914         (stap_parse_single_operand): Likewise.
4915         (stap_parse_argument_1): Likewise.
4916         (stap_probe::get_argument_count): Likewise.
4917         (stap_is_operator): Likewise.
4918
4919 2019-05-16  Tom Tromey  <tromey@adacore.com>
4920
4921         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4922         keyword to foreach.
4923
4924 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4925
4926         * linux-thread-db.c (try_thread_db_load_1): Change return type
4927         to bool.
4928         (try_thread_db_load): Likewise.
4929         (try_thread_db_load_from_pdir_1): Likewise.
4930         (try_thread_db_load_from_pdir): Likewise.
4931         (try_thread_db_load_from_sdir): Likewise.
4932         (try_thread_db_load_from_dir): Likewise.
4933         (thread_db_load_search): Likewise.
4934         (has_libpthread): Likewise.
4935         (thread_db_load): Likewise.
4936
4937 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4938
4939         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4940         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4941         NULL, and complain/return if that's the case.
4942
4943 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4944
4945         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4946         (advance, posn, abstract_read_memory): New functions.
4947         [struct mem_read_abstraction]: New struct.
4948         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4949
4950 2019-05-14  Tom Tromey  <tromey@adacore.com>
4951
4952         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4953         value is not lval_memory.
4954
4955 2019-05-14  Tom Tromey  <tromey@adacore.com>
4956
4957         * solib.c (info_sharedlibrary_command): Style the file name.
4958
4959 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4960
4961         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4962         (aarch64_vnv_type): Likewise.
4963         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4964         * common/tdesc.c: Likewise.
4965         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4966         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4967         * features/aarch64-fpu.xml: Add ieee half view.
4968         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4969         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4970         * gdbtypes.h (struct builtin_type): Likewise.
4971         (struct objfile_type): Likewise.
4972
4973 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4974
4975         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4976         typo.
4977         * location.h (string_to_event_location): Likewise.
4978
4979 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4980
4981         GDB 8.3 released.
4982
4983 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4984
4985         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4986         New variable declaration.
4987         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4988         New variable.
4989         (print_one_breakpoint): Use ui_out::test_flags and new global
4990         variable to compute use_fixed_output.
4991         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4992         Remove.
4993         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4994         (mi_multi_location_breakpoint_output_fixed): Remove.
4995         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4996         new variable.
4997         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4998         fix_multi_location_breakpoint_output flag if version >= 3.
4999         * ui-out.h (enum ui_out_flag)
5000         <fix_multi_location_breakpoint_output>: New enumerator.
5001
5002 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5003
5004         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5005
5006 2019-05-10  Tom Tromey  <tromey@adacore.com>
5007
5008         * ada-lang.c (catch_ada_completer): New function.
5009         (_initialize_ada_language): Use it.
5010
5011 2019-05-10  Tom Tromey  <tromey@adacore.com>
5012
5013         * thread.c (print_thread_info): Make "requested_threads" const.
5014         * gdbthread.h (print_thread_info): Make "requested_threads"
5015         const.
5016         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5017         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5018
5019 2019-05-08  Tom Tromey  <tom@tromey.com>
5020
5021         * gdbtypes.c (objfile_type_data): Change type.
5022         (objfile_type, _initialize_gdbtypes): Update.
5023
5024 2019-05-08  Tom Tromey  <tom@tromey.com>
5025
5026         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5027         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5028         (_initialize_dwarf2_frame): Update.
5029
5030 2019-05-08  Tom Tromey  <tom@tromey.com>
5031
5032         * objc-lang.c (objc_objfile_data): Change type.
5033         (find_methods): Update.
5034         (_initialize_objc_lang): Remove.
5035
5036 2019-05-08  Tom Tromey  <tom@tromey.com>
5037
5038         * stabsread.c (rs6000_builtin_type_data): Change type.
5039         (rs6000_builtin_type, _initialize_stabsread): Update.
5040
5041 2019-05-08  Tom Tromey  <tom@tromey.com>
5042
5043         * mips-tdep.c (mips_pdr_data): Remove.
5044         (_initialize_mips_tdep): Update.
5045
5046 2019-05-08  Tom Tromey  <tom@tromey.com>
5047
5048         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5049         (hppa_init_objfile_priv_data, read_unwind_info)
5050         (find_unwind_entry, _initialize_hppa_tdep): Update.
5051
5052 2019-05-08  Tom Tromey  <tom@tromey.com>
5053
5054         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5055         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5056         on obstack.
5057         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5058
5059 2019-05-08  Tom Tromey  <tom@tromey.com>
5060
5061         * mdebugread.c (basic_type_data): Change type.
5062         (basic_type, _initialize_mdebugread): Update.
5063
5064 2019-05-08  Tom Tromey  <tom@tromey.com>
5065
5066         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5067
5068 2019-05-08  Tom Tromey  <tom@tromey.com>
5069
5070         * nto-tdep.c (nto_inferior_data_reg): Change type.
5071         (nto_inferior_data): Update.
5072         (nto_inferior_data_cleanup, nto_new_inferior_data)
5073         (_initialize_nto_tdep): Remove.
5074         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5075
5076 2019-05-08  Tom Tromey  <tom@tromey.com>
5077
5078         * ada-lang.c (struct ada_inferior_data): Add initializers.
5079         (ada_inferior_data): Change type.
5080         (ada_inferior_data_cleanup): Remove.
5081         (get_ada_inferior_data, ada_inferior_exit)
5082         (struct ada_pspace_data): Add initializers, destructor.
5083         (ada_pspace_data_handle): Change type.
5084         (get_ada_pspace_data): Update.
5085         (ada_pspace_data_cleanup): Remove.
5086
5087 2019-05-08  Tom Tromey  <tom@tromey.com>
5088
5089         * coffread.c (struct coff_symfile_info): Add initializers.
5090         (coff_objfile_data_key): Move lower.  Change type.
5091         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5092         Update.
5093         (coff_free_info): Remove.
5094
5095 2019-05-08  Tom Tromey  <tom@tromey.com>
5096
5097         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5098         (fbsd_pspace_data_handle): Move lower.  Change type.
5099         (get_fbsd_pspace_data): Update.
5100         (fbsd_pspace_data_cleanup): Remove.
5101         (_initialize_fbsd_tdep): Update.
5102
5103 2019-05-08  Tom Tromey  <tom@tromey.com>
5104
5105         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5106         (get_ada_tasks_pspace_data): Update.
5107         (ada_tasks_pspace_data_cleanup): Remove.
5108         (_initialize_tasks): Update.
5109         (ada_tasks_inferior_data_handle): Change type.
5110         (get_ada_tasks_inferior_data): Update.
5111         (ada_tasks_inferior_data_cleanup): Remove.
5112         (struct ada_tasks_pspace_data): Add initializers.
5113
5114 2019-05-08  Tom Tromey  <tom@tromey.com>
5115
5116         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5117         * symfile-debug.c (debug_sym_get_probes): Change type.
5118         * stap-probe.c (handle_stap_probe):
5119         (stap_static_probe_ops::get_probes): Change type.
5120         * probe.h (class static_probe_ops) <get_probes>: Change type.
5121         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5122         (parse_probes_in_pspace): Update.
5123         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5124         Update.
5125         (any_static_probe_ops::get_probes): Change type.
5126         * elfread.c (elfread_data): New typedef.
5127         (probe_key): Change type.
5128         (elf_get_probes): Likewise.  Update.
5129         (probe_key_free): Remove.
5130         (_initialize_elfread): Update.
5131         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5132         Change type.
5133         (dtrace_process_dof_probe, dtrace_process_dof)
5134         (dtrace_static_probe_ops::get_probe): Change type.
5135
5136 2019-05-08  Tom Tromey  <tom@tromey.com>
5137
5138         * xcoffread.c (struct xcoff_symfile_info): Rename from
5139         coff_symfile_info.  Add initializers.
5140         (xcoff_objfile_data_key): Move lower.  Change type.
5141         (XCOFF_DATA): Rewrite.
5142         (xcoff_free_info): Remove.
5143         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5144         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5145         (xcoff_initial_scan): Update.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * solib-svr4.c (struct svr4_info): Add initializers and
5150         destructor.
5151         <probes_table>: Now an htab_up.
5152         (solib_svr4_pspace_data): Change type.
5153         (free_probes_table): Simplify.
5154         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5155         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5156         (probes_table_remove_objfile_probes, register_solib_event_probe)
5157         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5158         (_initialize_svr4_solib): Update.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * remote.c (remote_pspace_data): Change type.
5163         (remote_pspace_data_cleanup): Remove.
5164         (get_remote_exec_file, set_pspace_remote_exec_file)
5165         (_initialize_remote): Update.
5166
5167 2019-05-08  Tom Tromey  <tom@tromey.com>
5168
5169         * breakpoint.c (breakpoint_objfile_key): Change type.
5170         (get_breakpoint_objfile_data): Update.
5171         (free_breakpoint_objfile_data): Remove.
5172         (_initialize_breakpoint): Update.
5173
5174 2019-05-08  Tom Tromey  <tom@tromey.com>
5175
5176         * linux-tdep.c (struct linux_info): Add initializers.
5177         (linux_inferior_data): Move.  Change type.
5178         (invalidate_linux_cache_inf): Update.
5179         (linux_inferior_data_cleanup): Remove.
5180         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5181
5182 2019-05-08  Tom Tromey  <tom@tromey.com>
5183
5184         * auxv.c (auxv_inferior_data): Move.  Change type.
5185         (auxv_inferior_data_cleanup): Remove.
5186         (invalidate_auxv_cache_inf): Rewrite.
5187         (get_auxv_inferior_data, _initialize_auxv): Update.
5188
5189 2019-05-08  Tom Tromey  <tom@tromey.com>
5190
5191         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5192         (symfile_debug_objfile_data_key): Change type.
5193         (symfile_debug_installed, debug_qf_has_symbols)
5194         (debug_qf_find_last_source_symtab)
5195         (debug_qf_forget_cached_source_info)
5196         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5197         (debug_qf_print_stats, debug_qf_dump)
5198         (debug_qf_expand_symtabs_for_function)
5199         (debug_qf_expand_all_symtabs)
5200         (debug_qf_expand_symtabs_with_fullname)
5201         (debug_qf_map_matching_symbols)
5202         (debug_qf_expand_symtabs_matching)
5203         (debug_qf_find_pc_sect_compunit_symtab)
5204         (debug_qf_map_symbol_filenames)
5205         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5206         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5207         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5208         (debug_sym_read_linetable, debug_sym_relocate): Update.
5209         (symfile_debug_free_objfile): Remove.
5210         (install_symfile_debug_logging, _initialize_symfile_debug):
5211         Update.
5212
5213 2019-05-08  Tom Tromey  <tom@tromey.com>
5214
5215         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5216         allocate_on_obstack.
5217         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5218         (get_dwarf2_per_objfile): Update.
5219         (set_dwarf2_per_objfile): Remove.
5220         (dwarf2_has_info, dwarf2_get_section_info): Update.
5221         (dwarf2_free_objfile): Remove.
5222         (_initialize_dwarf2_read): Update.
5223
5224 2019-05-08  Tom Tromey  <tom@tromey.com>
5225
5226         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5227         initializers.
5228         <unsupported_script_warning_printed,
5229         script_not_found_warning_printed>: Now bool.
5230         (auto_load_pspace_data): Change type.
5231         (~auto_load_pspace_info): Rename from
5232         auto_load_pspace_data_cleanup.
5233         (get_auto_load_pspace_data, init_loaded_scripts_info)
5234         (clear_section_scripts, maybe_print_unsupported_script_warning)
5235         (maybe_print_script_not_found_warning, _initialize_auto_load):
5236         Update.
5237
5238 2019-05-08  Tom Tromey  <tom@tromey.com>
5239
5240         * objfiles.c (objfile_pspace_info): Add destructor and
5241         initializers.
5242         (objfiles_pspace_data): Change type.
5243         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5244         (get_objfile_pspace_data): Update.
5245         (objfiles_bfd_data): Change type.
5246         (get_objfile_bfd_data): Update.
5247         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5248
5249 2019-05-08  Tom Tromey  <tom@tromey.com>
5250
5251         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5252         Change type.
5253         (get_catch_syscall_inferior_data): Update.
5254         (catch_syscall_inferior_data_cleanup): Remove.
5255         (_initialize_break_catch_syscall): Update.
5256
5257 2019-05-08  Tom Tromey  <tom@tromey.com>
5258
5259         * inflow.c (struct terminal_info): Add destructor and
5260         initializers.
5261         (inflow_inferior_data): Change type.
5262         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5263         (get_inflow_inferior_data, inflow_inferior_exit)
5264         (swap_terminal_info, _initialize_inflow): Update.
5265
5266 2019-05-08  Tom Tromey  <tom@tromey.com>
5267
5268         * target-dcache.c (target_dcache_cleanup): Remove.
5269         (target_dcache_aspace_key): Change type.
5270         (target_dcache_init_p, target_dcache_invalidate)
5271         (target_dcache_get, target_dcache_get_or_init)
5272         (_initialize_target_dcache): Update.
5273         * dcache.h (struct dcache_deleter): New.
5274
5275 2019-05-08  Tom Tromey  <tom@tromey.com>
5276
5277         * symtab.c (struct symbol_cache): Add destructor and
5278         initializers.
5279         (symbol_cache_key): Move.  Change type.
5280         (make_symbol_cache, free_symbol_cache): Remove.
5281         (get_symbol_cache): Update.
5282         (symbol_cache_cleanup): Remove.
5283         (ALL_PSPACES, symbol_cache_flush)
5284         (maintenance_print_symbol_cache)
5285         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5286         Update.
5287
5288 2019-05-08  Tom Tromey  <tom@tromey.com>
5289
5290         * symtab.c (struct main_info): Add destructor and initializers.
5291         (main_progspace_key): Move.  Change type.
5292         (get_main_info): Update.
5293         (main_info_cleanup): Remove.
5294         (_initialize_symtab): Update.
5295
5296 2019-05-08  Tom Tromey  <tom@tromey.com>
5297
5298         * registry.h (DECLARE_REGISTRY): Define the _key class.
5299
5300 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * NEWS: Merge two 'New commands' sections.
5303
5304 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5305
5306         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5307         parameter and use Ada language definition instead.
5308         (ada_val_print_ptr): Remove unused language parameter.
5309         (ada_val_print_num): Remove language parameter and use Ada language
5310         definition instead.
5311         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5312         parameter.
5313         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5314         parameter and use Ada language definition instead.
5315         (ada_val_print_1): Update all ada_val_print_xxx calls.
5316         Remove language parameter.
5317         (ada_val_print): Update ada_val_print_1 call.
5318
5319 2019-05-08  Tom Tromey  <tromey@adacore.com>
5320
5321         * remote.c (remote_hw_watchpoint_limit)
5322         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5323         Now static.
5324
5325 2019-05-08  Tom Tromey  <tromey@adacore.com>
5326
5327         * maint.c (_initialize_maint_cmds): Move initialization code to
5328         remote.c.
5329         (watchdog, show_watchdog): Move to remote.c.
5330         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5331         "watchdog" static.
5332         (_initialize_remote): Move initialization code from maint.c.
5333         * defs.h (watchdog): Don't declare.
5334
5335 2019-05-08  Tom Tromey  <tromey@adacore.com>
5336
5337         * tui/tui-interp.c: Include main.h.
5338         * interps.c: Include main.h.
5339         * main.h (interpreter_p): Declare.
5340         * defs.h (interpreter_p): Don't declare.
5341
5342 2019-05-08  Tom Tromey  <tromey@adacore.com>
5343
5344         * dwarf2loc.c: Include dwarf2read.h.
5345         * defs.h (read_unsigned_leb128): Don't declare.
5346         * dwarf2read.h (read_unsigned_leb128): Declare.
5347
5348 2019-05-08  Tom Tromey  <tromey@adacore.com>
5349
5350         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5351         method.
5352
5353 2019-05-08  Tom Tromey  <tromey@adacore.com>
5354
5355         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5356         when no wrap column is set.
5357
5358 2019-05-08  Tom Tromey  <tromey@adacore.com>
5359
5360         * c-lang.c (c_get_string): Handle non-C-style arrays.
5361
5362 2019-05-08  Tom Tromey  <tromey@adacore.com>
5363
5364         * typeprint.c (print_offset_data::update): Print the bit offset,
5365         not the number of bits remaining.
5366
5367 2019-05-08  Tom Tromey  <tromey@adacore.com>
5368
5369         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5370         padding at end of comment.
5371
5372 2019-05-08  Tom Tromey  <tromey@adacore.com>
5373
5374         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5375         Compare main types.
5376
5377 2019-05-06  Tom Tromey  <tom@tromey.com>
5378
5379         * common/scoped_mmap.c: Include common-defs.h.
5380         * common/scoped_mmap.h: Don't include config.h.
5381
5382 2019-05-04  Tom Tromey  <tom@tromey.com>
5383
5384         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5385         (struct aarch64_call_info): Add initializers.
5386         <si>: Now a std::vector.
5387         (pass_on_stack, aarch64_push_dummy_call): Update.
5388
5389 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5390             Tom Tromey  <tom@tromey.com>
5391
5392         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5393         (ppc_threads): Now a std::vector.  Now static.
5394         (hwdebug_find_thread_points_by_tid)
5395         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5396         Update.
5397
5398 2019-05-04  Tom Tromey  <tom@tromey.com>
5399
5400         * arc-tdep.c (arc_tdesc_init): Return bool.
5401
5402 2019-05-04  Tom Tromey  <tom@tromey.com>
5403
5404         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5405         Use gdb_assert_not_reached.
5406
5407 2019-05-04  Tom Tromey  <tom@tromey.com>
5408
5409         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5410         "false".
5411
5412 2019-05-04  Tom Tromey  <tom@tromey.com>
5413
5414         * arc-tdep.c (arc_tdesc_init): Use bool.
5415
5416 2019-05-04  Tom Tromey  <tom@tromey.com>
5417
5418         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5419
5420 2019-05-04  Tom Tromey  <tom@tromey.com>
5421
5422         * cli/cli-cmds.c (valid_command_p): Return bool.
5423
5424 2019-05-04  Tom Tromey  <tom@tromey.com>
5425
5426         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5427         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5428
5429 2019-05-04  Raul Tambre  <raul@tambre.ee>
5430
5431         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5432         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5433         operator for comparison.
5434
5435 2019-05-04  Tom Tromey  <tom@tromey.com>
5436
5437         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5438         (lookup_partial_symbol, print_partial_symbols)
5439         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5440         (psymbol_compare): Update.
5441         (add_psymbol_to_bcache): Clear the entire psymbol.
5442         (maintenance_check_psymtabs): Update.
5443         * psympriv.h (struct partial_symbol): Don't derive from
5444         general_symbol_info.
5445         <obj_section, unrelocated_address, address,
5446         set_unrelocated_address>: Update.
5447         <ginfo>: New member.
5448         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5449         (debug_names::write_psymbols): Update.
5450
5451 2019-05-04  Tom de Vries  <tdevries@suse.de>
5452
5453         * contrib/cc-with-tweaks.sh: Support -n arg.
5454
5455 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5456
5457         * corelow.c (core_target::detach): Ensure frame cache and
5458         register caches are cleared.
5459         inferior.c (exit_inferior_1): Likewise.
5460
5461 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5462             Tom Tromey  <tom@tromey.com>
5463
5464         * dictionary.c (collate_pending_symbols_by_language): Remove
5465         "struct" from foreach.
5466         * symtab.c (lookup_global_symbol_from_objfile)
5467         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5468         foreach.
5469         * ser-tcp.c (net_open): Remove "struct" from foreach.
5470         * objfiles.c (objfile_relocate, objfile_rebase)
5471         (objfile_has_symbols): Remove "struct" from foreach.
5472         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5473         from foreach.
5474         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5475         foreach.
5476         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5477         "struct" from foreach.
5478         * ada-lang.c (create_excep_cond_exprs)
5479         (ada_exception_catchpoint_cond_string): Remove "struct" from
5480         foreach.
5481
5482 2019-05-03  Tom Tromey  <tromey@adacore.com>
5483
5484         * ada-exp.y (convert_char_literal): Check suffix of each
5485         enumerator.
5486
5487 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5488
5489         PR ada/21406:
5490         * ada-exp.y (yywrap): Don't define.
5491         * ada-lex.l (%option): Add noyywrap
5492         (yywrap): Remove.
5493
5494 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5495
5496         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5497         _WIN32_WINNT to the XP level, unless already defined to a higher
5498         level.
5499
5500         * unittests/parse-connection-spec-selftests.c:
5501         * ser-tcp.c:
5502         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5503         override.
5504
5505         * symfile.c (find_separate_debug_file): Remove colon from the
5506         drive spec of DOS/Windows file names of the target, so that the
5507         file name produced from DEBUGDIR and the target's directory will
5508         be valid on DOS/Windows systems.
5509
5510 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * rust-lang.c (val_print_struct): Handle printing structures
5513         containing strings.
5514
5515 2019-05-02  Tom Tromey  <tromey@adacore.com>
5516
5517         * valarith.c (_initialize_valarith): Remove.
5518
5519 2019-05-01  Tom Tromey  <tromey@adacore.com>
5520
5521         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5522         bitfields.
5523
5524 2019-05-01  Tom Tromey  <tromey@adacore.com>
5525
5526         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5527         for big-endian copies.
5528
5529 2019-04-30  Ali Tamur  <tamur@google.com>
5530         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5531         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5532         (read_3_bytes): New function.
5533
5534 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5535
5536         * windows-nat.c (main_thread_id): Delete.
5537         (handle_output_debug_string): Replace main_thread_id by
5538         current_event.dwThreadId.
5539         (fake_create_process): Likewise.
5540         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5541         Do not set main_thread_id.
5542         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5543         current_event.dwThreadId.
5544         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5545
5546 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5547
5548         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5549         Use current_event.dwThreadId instead of main_thread_id.
5550
5551 2019-04-30  Tom Tromey  <tromey@adacore.com>
5552
5553         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5554         (create_excep_cond_exprs): Iterate over program spaces.
5555         (ada_exception_catchpoint_cond_string): Examine all minimal
5556         symbols for exception types.
5557
5558 2019-04-30  Tom Tromey  <tromey@adacore.com>
5559
5560         PR c++/24470:
5561         * dwarf2read.c (process_structure_scope): Handle case where type
5562         has template parameters but no symbol was created.
5563
5564 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5565             Chris January  <chris.january@arm.com>
5566
5567         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5568         qualifier.
5569         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5570
5571 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * f-typeprint.c (f_print_type): Update rules for printing
5574         whitespace.
5575         (f_type_print_varspec_suffix): Likewise.
5576
5577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5578             Chris January  <chris.january@arm.com>
5579
5580         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5581         function arguments.
5582
5583 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * f-lang.c (build_fortran_types): Change name of void type to
5586         lower case.
5587         * f-typeprint.c (f_type_print_base): Print the name of the void
5588         type, rather than a fixed string.
5589         * f-valprint.c (f_decorations): Use lower case void string.
5590
5591 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5592             Chris January  <chris.january@arm.com>
5593
5594         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5595         types for Fortran.
5596
5597 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5598             Chris January  <chris.january@arm.com>
5599             David Lecomber  <david.lecomber@arm.com>
5600
5601         * f-exp.y (BINOP_INTRINSIC): New token.
5602         (exp): New parser rule handling BINOP_INTRINSIC.
5603         (f77_keywords): Add new builtin procedures.
5604         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5605         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5606         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5607         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5608         (print_unop_subexp_f): New function.
5609         (print_binop_subexp_f): New function.
5610         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5611         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5612         (dump_subexp_body_f): Likewise.
5613         (operator_check_f): Likewise.
5614         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5615         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5616
5617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5618
5619         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5620         UNOP_KIND.
5621         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5622         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5623         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5624         (operator_length_f): New fuction.
5625         (print_subexp_f): New function.
5626         (op_name_f): New function.
5627         (dump_subexp_body_f): New function.
5628         (operator_check_f): New function.
5629         (exp_descriptor_f): Replace standard expression handling functions
5630         with new functions.
5631         * gdb/fortran-operator.def: New file.
5632         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5633         * gdb/std-operator.def: Remove UNOP_KIND.
5634
5635 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5636
5637         * std-operator.def: Remove unbalanced, stray double quote
5638         character.
5639
5640 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5641             Chris January  <chris.january@arm.com>
5642             Daniel Everett  <daniel.everett@arm.com>
5643             Nick Forrington  <nick.forrington@arm.com>
5644             Richard Bunt  <richard.bunt@arm.com>
5645
5646         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5647         of depth when printing anonymous structs or unions.
5648         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5649         Don't print either the top-level value, or the children if the
5650         max-depth is exceeded.
5651         (ppscm_print_children): When printing the key of a map, allow one
5652         extra level of depth.
5653         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5654         print either the top-level value, or the children if the max-depth
5655         is exceeded.
5656         (print_children): When printing the key of a map, allow one extra
5657         level of depth.
5658         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5659         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5660         (user_print_options): Initialise max_depth field.
5661         (val_print_scalar_or_string_type_p): New function.
5662         (val_print): Check to see if the max depth has been reached.
5663         (val_print_check_max_depth): Define new function.
5664         (show_print_max_depth): New function.
5665         (_initialize_valprint): Add 'print max-depth' option.
5666         * valprint.h (struct value_print_options) <max_depth>: New field.
5667         (val_print_check_max_depth): Declare new function.
5668         * NEWS: Document new feature.
5669
5670 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5671
5672         * ada-lang.c (ada_language_defn): Initialise new field.
5673         * c-lang.c (c_is_string_type_p): New function.
5674         (c_language_defn): Initialise new field.
5675         (cplus_language_defn): Initialise new field.
5676         (asm_language_defn): Initialise new field.
5677         (minimal_language_defn): Initialise new field.
5678         * c-lang.h (c_is_string_type_p): Declare new function.
5679         * d-lang.c (d_language_defn): Initialise new field.
5680         * f-lang.c (f_is_string_type_p): New function.
5681         (f_language_defn): Initialise new field.
5682         * go-lang.c (go_is_string_type_p): New function.
5683         (go_language_defn): Initialise new field.
5684         * language.c (default_is_string_type_p): New function.
5685         (unknown_language_defn): Initialise new field.
5686         (auto_language_defn): Initialise new field.
5687         * language.h (struct language_defn) <la_is_string_type_p>: New
5688         member variable.
5689         (default_is_string_type_p): Declare new function.
5690         * m2-lang.c (m2_language_defn): Initialise new field.
5691         * objc-lang.c (objc_language_defn): Initialise new field.
5692         * opencl-lang.c (opencl_language_defn): Initialise new field.
5693         * p-lang.c (pascal_is_string_type_p): New function.
5694         (pascal_language_defn): Initialise new field.
5695         * rust-lang.c (rust_is_string_type_p): New function.
5696         (rust_language_defn): Initialise new field.
5697
5698 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5699
5700         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5701         New field.
5702         * ada-lang.c (ada_language_defn): Initialise new field.
5703         * c-lang.c (c_language_defn): Likewise.
5704         (cplus_language_defn): Likewise.
5705         (asm_language_defn): Likewise.
5706         (minimal_language_defn): Likewise.
5707         * d-lang.c (d_language_defn): Likewise.
5708         * f-lang.c (f_language_defn): Likewise.
5709         * go-lang.c (go_language_defn): Likewise.
5710         * language.c (unknown_language_defn): Likewise.
5711         (auto_language_defn): Likewise.
5712         * m2-lang.c (m2_language_defn): Likewise.
5713         * objc-lang.c (objc_language_defn): Likewise.
5714         * opencl-lang.c (opencl_language_defn): Likewise.
5715         * p-lang.c (pascal_language_defn): Likewise.
5716         * rust-lang.c (rust_language_defn): Likewise.
5717
5718 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5719
5720         * ada-lang.c (ada_is_character_type): Change return type to bool.
5721         (ada_is_string_type): Likewise.
5722         * ada-lang.h (ada_is_character_type): Update declaration
5723         (ada_is_string_type): Likewise.
5724
5725 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5726
5727         Support style in 'frame|thread apply'
5728
5729         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5730         * record.c (record_start, record_stop): Update callers of
5731         execute_command_to_string with false.
5732         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5733         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5734         methods.
5735         (class string_file): New constructor with term_out parameter.
5736         Override methods term_out and can_emit_style_escape.  New member
5737         term_out.
5738         (class stdio_file): Override can_emit_style_escape.
5739         (class tee_file): Override term_out and can_emit_style_escape.
5740         * utils.h (can_emit_style_escape): Remove.
5741         * utils.c (can_emit_style_escape): Likewise.
5742         Update all callers of can_emit_style_escape (SOMESTREAM) to
5743         SOMESTREAM->can_emit_style_escape.
5744         * source-cache.c (source_cache::get_source_lines): Likewise.
5745         * stack.c (frame_apply_command_count): Call execute_command_to_string
5746         passing the term_out characteristic of the current gdb_stdout.
5747         * thread.c (thr_try_catch_cmd): Likewise.
5748         * top.c (execute_command_to_string): pass term_out parameter
5749         to construct the string_file for the command output.
5750         * ui-file.c (term_cli_styling): New function (most code moved
5751         from utils.c can_emit_style_escape).
5752         (string_file::string_file, string_file::can_emit_style_escape,
5753         stdio_file::can_emit_style_escape, tee_file::term_out,
5754         tee_file::can_emit_style_escape): New functions.
5755
5756 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5757
5758         * NEWS: Mention the new set|show may-call-functions.
5759         * infcall.c (may_call_functions_p): New variable.
5760         (show_may_call_functions_p): New function.
5761         (call_function_by_hand_dummy): Throws an error if not
5762         may-call-functions.
5763         (_initialize_infcall): Call add_setshow_boolean_cmd for
5764         may-call-functions.
5765
5766 2019-04-25  Keith Seitz  <keiths@redhat.com>
5767
5768         PR c++/24367
5769         * cp-support.c (inspect_type): Don't attempt substitutions
5770         of symbol with the same name.
5771
5772 2019-04-25  Tom Tromey  <tromey@adacore.com>
5773
5774         PR gdb/24475:
5775         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5776         static.
5777
5778 2019-04-25  Tom Tromey  <tromey@adacore.com>
5779
5780         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5781         rvalue reference.
5782         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5783         (gdb_xml_parser::parse): Use std::move.
5784         * python/python-internal.h (gdbpy_convert_exception): Take a const
5785         reference.
5786         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5787         std::move.
5788         * python/py-utils.c (gdbpy_convert_exception): Take a const
5789         reference.
5790         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5791         Use std::move.
5792         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5793         Use std::move.
5794         * mi/mi-main.c (mi_print_exception): Take a const reference.
5795         * main.c (handle_command_errors): Take a const reference.
5796         * linespec.c (parse_linespec): Use std::move.
5797         * infcall.c (run_inferior_call): Use std::move.
5798         (call_function_by_hand_dummy): Use std::move.
5799         * exec.c (try_open_exec_file): Use std::move.
5800         * exceptions.h (exception_print, exception_fprintf)
5801         (exception_print_same): Update.
5802         * exceptions.c (print_exception, exception_print)
5803         (exception_fprintf, exception_print_same): Change parameters to
5804         const reference.
5805         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5806         * common/new-op.c: Use std::move.
5807         * common/common-exceptions.h (struct gdb_exception): Add move
5808         constructor.
5809         (struct gdb_exception_error, struct gdb_exception_quit, struct
5810         gdb_quit_bad_alloc): Change constructor to move constructor.
5811         (throw_exception): Change parameter to rvalue reference.
5812         * common/common-exceptions.c (throw_exception): Take rvalue
5813         reference.
5814         * cli/cli-interp.c (safe_execute_command): Use std::move.
5815         * breakpoint.c (insert_bp_location, location_to_sals): Use
5816         std::move.
5817
5818 2019-04-25  Tom Tromey  <tromey@adacore.com>
5819
5820         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5821         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5822         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5823         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5824         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5825         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5826         guile/scm-value.c: Use unpack.
5827         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5828         gdbscm_gdb_exception.
5829         (gdbscm_throw_gdb_exception): Likewise.
5830         (struct gdbscm_gdb_exception): New.
5831         (unpack): New function.
5832         (gdbscm_wrap): Use unpack.
5833
5834 2019-04-25  Tom Tromey  <tromey@adacore.com>
5835
5836         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5837         (gdb_rl_callback_handler): Use std::move.
5838         * common/common-exceptions.h (struct gdb_exception): Add move
5839         assignment operator.
5840         (throw_exception_sjlj): Change "exception" to const reference.
5841         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5842         (throw_exception_sjlj): Change "exception" to const reference.
5843
5844 2019-04-25  Tom Tromey  <tromey@adacore.com>
5845
5846         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5847         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5848         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5849         Update.
5850         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5851         Update.
5852         * mi/mi-interp.c (mi_interp::exec): Update.
5853         * linespec.c (parse_linespec): Update.
5854         * infcall.c (run_inferior_call): Update.
5855         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5856         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5857         (gdbscm_lookup_global_symbol): Update.
5858         * guile/scm-param.c (gdbscm_parameter_value): Update.
5859         * guile/scm-frame.c (gdbscm_frame_read_register)
5860         (gdbscm_frame_read_var): Update.
5861         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5862         * exec.c (try_open_exec_file): Update.
5863         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5864         (gdb_rl_callback_handler): Update.
5865         * common/common-exceptions.h (exception_none): Don't declare.
5866         * common/common-exceptions.c (exception_none): Don't define.
5867         (struct catcher) <exception>: Update.
5868         * cli/cli-interp.c (safe_execute_command): Update.
5869         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5870
5871 2019-04-25  Ali Tamur  <tamur@google.com>
5872
5873         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5874         (read_attribute_value): Likewise.
5875         (dwarf2_read_addr_index): Update comment.
5876         (read_str_index): Add DW_FORM_strx.
5877         (dwarf2_string_attr): Likewise.
5878         (dwarf2_const_value_attr): Likewise.
5879         (dump_die_shallow): Likewise.
5880         (dwarf2_fetch_constant_bytes): Likewise.
5881         (skip_form_bytes): Likewise.
5882         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5883
5884 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5885
5886         PR corefiles/11608
5887         PR corefiles/18187
5888         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5889         OFFSET.  Verify if current mapping contains an ELF header.
5890         (linux_find_memory_regions_full): Adjust call to
5891         dump_mapping_p.
5892
5893 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5894             Kang Li <kanglictf@gmail.com>
5895
5896         PR gdb/21600
5897
5898         * dwarf2-frame.c (read_initial_length): Be consistent about using
5899         unsigned representation of length.
5900         (decode_frame_entry_1): Likewise.  Check for wraparound of
5901         end pointer as well as buffer overflow.
5902
5903 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5904
5905         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5906         "vq".
5907
5908 2019-04-24  Tom Tromey  <tromey@adacore.com>
5909
5910         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5911
5912 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5913
5914         * s12z-tdep.c (s12z_unwind_pc): Delete.
5915         (s12z_unwind_sp): Delete.
5916         (s12z_gdbarch_init): Don't register deleted functions with
5917         gdbarch.
5918
5919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5920
5921         * rl78-tdep.c (rl78_unwind_sp): Delete.
5922         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5923
5924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5927         (xstormy16_unwind_pc): Delete.
5928         (xstormy16_dummy_id): Delete.
5929         (xstormy16_gdbarch_init): Don't register deleted functions with
5930         gdbarch.
5931
5932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5933
5934         * vax-tdep.c (vax_unwind_pc): Delete.
5935         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5936
5937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5938
5939         * v850-tdep.c (v850_unwind_sp): Delete.
5940         (v850_unwind_pc): Delete.
5941         (v850_dummy_id): Delete.
5942         (v850_gdbarch_init): Don't register deleted functions with
5943         gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5948         (tilegx_unwind_pc): Delete.
5949         (tilegx_unwind_dummy_id): Delete.
5950         (tilegx_gdbarch_init): Don't register deleted functions with
5951         gdbarch.
5952
5953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5956         (tic6x_dummy_id): Delete.
5957         (tic6x_gdbarch_init): Don't register deleted functions with
5958         gdbarch.
5959
5960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * sparc-tdep.c (sparc_unwind_pc): Delete.
5963         (sparc32_gdbarch_init): Don't register deleted function with
5964         gdbarch.
5965
5966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * sh-tdep.c (sh_unwind_sp): Delete.
5969         (sh_unwind_pc): Delete.
5970         (sh_dummy_id): Delete.
5971         (sh_gdbarch_init): Don't register deleted functions with
5972         gdbarch.
5973
5974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * score-tdep.c (score_unwind_sp): Delete.
5977         (score_unwind_pc): Delete.
5978         (score_dummy_id): Delete.
5979         (score_gdbarch_init): Don't register deleted functions with
5980         gdbarch.
5981
5982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * rx-tdep.c (rx_unwind_pc): Delete.
5985         (rx_unwind_sp): Delete.
5986         (rx_dummy_id): Delete.
5987         (rx_gdbarch_init): Don't register deleted functions with
5988         gdbarch.  Update comment.
5989
5990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5993         (rs6000_dummy_id): Delete.
5994         (rs6000_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * or1k-tdep.c (or1k_dummy_id): Delete.
6000         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6001
6002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * nios2-tdep.c (nios2_dummy_id): Delete.
6005         (nios2_unwind_sp): Delete.
6006         (nios2_gdbarch_init): Don't register deleted functions with
6007         gdbarch.
6008
6009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * nds32-tdep.c (nds32_dummy_id): Delete.
6012         (nds32_unwind_pc): Delete.
6013         (nds32_unwind_sp): Delete.
6014         (nds32_gdbarch_init): Don't register deleted functions with
6015         gdbarch.
6016
6017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * msp430-tdep.c (msp430_unwind_pc): Delete.
6020         (msp430_unwind_sp): Delete.
6021         (msp430_dummy_id): Delete.
6022         (msp430_gdbarch_init): Don't register deleted functions with
6023         gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * moxie-tdep.c (moxie_unwind_sp): Delete.
6028         (moxie_unwind_pc): Delete.
6029         (moxie_dummy_id): Delete.
6030         (moxie_gdbarch_init): Don't register deleted functions with
6031         gdbarch.
6032
6033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6036         (mn10300_unwind_pc): Delete.
6037         (mn10300_unwind_sp): Delete.
6038         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6039         mn10300_unwind_sp.
6040         (mn10300_frame_unwind_init): Don't register deleted functions with
6041         gdbarch.
6042
6043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6044
6045         * mep-tdep.c (mep_unwind_pc): Delete.
6046         (mep_unwind_sp): Delete.
6047         (mep_dummy_id): Delete.
6048         (mep_gdbarch_init): Don't register deleted functions with
6049         gdbarch.
6050
6051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6052
6053         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6054         (m68hc11_unwind_sp): Delete.
6055         (m68hc11_gdbarch_init): Don't register deleted functions with
6056         gdbarch.
6057
6058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * m32r-tdep.c (m32r_unwind_sp): Delete.
6061         (m32r_unwind_pc): Delete.
6062         (m32r_dummy_id): Delete.
6063         (m32r_gdbarch_init): Don't register deleted functions with
6064         gdbarch.
6065
6066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * m32c-tdep.c (m32c_unwind_pc): Delete.
6069         (m32c_unwind_sp): Delete.
6070         (m32c_dummy_id): Delete.
6071         (m32c_gdbarch_init): Don't register deleted functions with
6072         gdbarch.
6073
6074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6077         (lm32_unwind_pc): Delete.
6078         (lm32_dummy_id): Delete.
6079         (lm32_gdbarch_init): Don't register deleted functions with
6080         gdbarch.
6081
6082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6083
6084         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6085         (iq2000_unwind_pc): Delete.
6086         (iq2000_dummy_id): Delete.
6087         (iq2000_gdbarch_init): Don't register deleted functions with
6088         gdbarch.
6089
6090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * nds32-tdep.c (nds32_type_align): Delete.
6093         (nds32_push_dummy_call): Use type_align instead.
6094
6095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6096
6097         * arm-tdep.c (arm_type_align): Only handle vector override case.
6098         (arm_push_dummy_call): Use type_align.
6099         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6100
6101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6104         case.
6105         (pass_on_stack): Use type_align.
6106         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6107         function.
6108
6109 2019-04-23  Tom Tromey  <tromey@adacore.com>
6110
6111         * dwarf2read.c (line_header::file_name_at): Remove unused
6112         overload.
6113
6114 2019-04-23  Tom de Vries  <tdevries@suse.de>
6115
6116         PR gdb/24438
6117         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6118         invocation.
6119
6120
6121 2019-03-27  Ali Tamur  <tamur@google.com>
6122
6123         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6124         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6125         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6126         (dwarf_expr_context::get_addr_index): Likewise
6127         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6128         (symbol_needs_eval_context::get_addr_index): Likewise
6129         (disassemble_dwarf_expression): Add DW_OP_addrx
6130         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6131         (read_cutu_die_from_dwo): Update comment
6132         (skip_one_die): Add DW_FORM_addrx
6133         (read_attribute_value): Likewise
6134         (var_decode_location): Add DW_OP_addrx
6135         (dwarf2_const_value_attr): Add DW_FORM_addrx
6136         (dump_die_shallow): Likewise
6137         (dwarf2_fetch_constant_bytes): Likewise
6138         (decode_locdesc): Add DW_OP_addrx
6139         (skip_form_bytes): Add DW_FORM_addrx
6140
6141 2019-04-22  Ali Tamur  <tamur@google.com>
6142
6143         * MAINTAINERS (Write After Approval): Add self.
6144
6145 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6146
6147         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6148         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6149         (open_symbol_file_object): Likewise.
6150         (svr4_default_sos): Add info parameter.
6151         (svr4_read_so_list): Likewise.
6152         (svr4_current_sos_direct): Adjust functions calls to pass down
6153         info.
6154         (svr4_current_sos_1): Add info parameter.
6155         (svr4_current_sos): Call get_svr4_info, pass info down to
6156         svr4_current_sos_1.
6157         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6158         get_svr4_info.
6159         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6160         get_svr4_info.
6161         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6162         to get_svr4_info.
6163         (probes_table_remove_objfile_probes): Likewise.
6164         (register_solib_event_probe): Add info parameter.
6165         (solist_update_incremental): Pass info parameter down to
6166         svr4_read_so_list.
6167         (disable_probes_interface): Add info parameter.
6168         (svr4_handle_solib_event): Pass current_program_space to
6169         get_svr4_info.  Adjust disable_probes_interface cleanup.
6170         (svr4_create_probe_breakpoints): Add info parameter, pass it
6171         down to register_solib_event_probe.
6172         (svr4_create_solib_event_breakpoints): Add info parameter,
6173         pass it down to svr4_create_probe_breakpoints.
6174         (enable_break): Pass info down to
6175         svr4_create_solib_event_breakpoints.
6176         (svr4_solib_create_inferior_hook): Pass current_program_space to
6177         get_svr4_info.
6178         (svr4_clear_solib): Likewise.
6179
6180 2019-04-22  Pedro Alves  <palves@redhat.com>
6181
6182         * solib-svr4.c (svr4_free_objfile_observer): New.
6183         (probe_and_action::objfile): New field.
6184         (probes_table_htab_remove_objfile_probes)
6185         (probes_table_remove_objfile_probes): New functions.
6186         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6187         in the new probe_and_action.  Don't store the probe in 'lookup'.
6188         (svr4_create_probe_breakpoints): Pass objfile to
6189         register_solib_event_probe.
6190         (_initialize_svr4_solib): Register a free_objfile observer.
6191
6192 2019-04-19  Tom Tromey  <tom@tromey.com>
6193
6194         * common/queue.h: Remove.
6195
6196 2019-04-19  Tom Tromey  <tom@tromey.com>
6197
6198         * event-loop.c: Don't include "common/queue.h".
6199
6200 2019-04-19  Tom Tromey  <tom@tromey.com>
6201
6202         * remote.c (remote_target): Use delete.
6203         * remote-notif.h: Include <list>, not "common/queue.h".
6204         (notif_client_p): Remove typedef.
6205         (remote_notif_state): Add constructor, destructor, initializer.
6206         <notif_queue>: Now a std::list.
6207         (remote_notif_state_xfree): Don't declare.
6208         * remote-notif.c (remote_notif_process, handle_notification)
6209         (remote_notif_state_allocate): Update.
6210         (~remote_notif_state): Rename from remote_notif_state_xfree.
6211
6212 2019-04-19  Tom Tromey  <tom@tromey.com>
6213
6214         * symfile.c (reread_symbols): Update.
6215         * objfiles.c (objfile_register_static_link)
6216         (objfile_lookup_static_link): Update
6217         (~objfile) Don't delete static_links.
6218         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6219
6220 2019-04-19  Tom Tromey  <tom@tromey.com>
6221
6222         * type-stack.h (struct type_stack) <insert>: Constify string.
6223         * type-stack.c (type_stack::insert): Constify string.
6224         * gdbtypes.h (lookup_template_type): Update.
6225         (address_space_name_to_int): Update.
6226         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6227         const.
6228         (lookup_template_type): Make name const.
6229         * c-exp.y: Update rules.
6230         (lex_one_token, classify_name, classify_inner_name)
6231         (c_print_token): Update.
6232         * p-exp.y: Update rules.
6233         (yylex): Update.
6234         * f-exp.y: Update rules.
6235         (yylex): Update.
6236         * d-exp.y: Update rules.
6237         (lex_one_token, classify_name, classify_inner_name): Update.
6238         * parse.c (write_dollar_variable, copy_name): Return std::string.
6239         * parser-defs.h (copy_name): Change return type.
6240         * m2-exp.y: Update rules.
6241         (yylex): Update.
6242         * go-exp.y (lex_one_token): Update.
6243         Update rules.
6244         (classify_unsafe_function, classify_packaged_name)
6245         (classify_name, yylex): Update.
6246
6247 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6248
6249         * configure.ac: add --enable-source-highlight switch.
6250         * configure: Regenerate.
6251         * top.c (print_gdb_version): plumb --enable-source-highlight
6252         status to "show configuration".
6253
6254 2019-04-19  Tom Tromey  <tromey@adacore.com>
6255
6256         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6257         Check ADA_TYPE_P.
6258         (empty_record, ada_template_to_fixed_record_type_1)
6259         (template_to_static_fixed_type)
6260         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6261         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6262         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6263         macros.
6264
6265 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6266
6267         PR symtab/24423:
6268         * source.c (print_source_lines_base): Advance "iter" when a
6269         control character is seen.
6270
6271 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6272
6273         * inferior.h (struct infcall_suspend_state_deleter):
6274         Catch exception in destructor to avoid crash.
6275
6276 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6277
6278         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6279         close to the add_com "shell".
6280
6281 2019-04-18  Tom Tromey  <tromey@adacore.com>
6282
6283         * process-stratum-target.h (class process_stratum_target)
6284         <stratum>: Add "final".
6285
6286 2019-04-17  Tom Tromey  <tromey@adacore.com>
6287
6288         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6289         against nullptr before use.
6290
6291 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6292
6293         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6294
6295 2019-04-17  Jim Wilson  <jimw@sifive.com>
6296             Andrew Burgess  <andrew.burgess@embecosm.com>
6297
6298         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6299         code read might fail, assume 4-byte breakpoint in that case.
6300
6301 2019-04-15  Leszek Swirski  <leszeks@google.com>
6302
6303         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6304         rather than a hand-rolled POD check when checking for forced MEMORY
6305         classification.
6306
6307 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6308
6309         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6310         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6311         function.
6312         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6313         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6314         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6315         declaration.
6316
6317 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6318
6319         * aarch64-linux-nat.c
6320         (aarch64_linux_nat_target::thread_architecture): Add override.
6321         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6322         each VQ.
6323
6324 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6325
6326         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6327
6328 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6329
6330         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6331         target types of size 96-bits, add some additional comments, and
6332         check that the builtin type we found was the correct size.
6333
6334 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6335
6336         * utils.c (prompt_for_continue): Don't restore the styling at the
6337         end, as applied_style has the wrong value.  This fixes styling in
6338         long lists of file names that are interrupted by the "Continue?"
6339         prompt.
6340
6341 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6344         * c-lang.c (c_language_defn): Likewise.
6345         (cplus_language_defn): Likewise.
6346         (asm_language_defn): Likewise.
6347         (minimal_language_defn): Likewise.
6348         * d-lang.c (d_language_defn): Likewise.
6349         * f-lang.c (f_language_defn): Likewise.
6350         * go-lang.c (go_language_defn): Likewise.
6351         * language.c (unknown_language_defn): Likewise.
6352         (auto_language_defn): Likewise.
6353         * language.h (struct language_defn): Remove la_magic field.
6354         (LANG_MAGIC): Delete.
6355         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6356         * objc-lang.c (objc_language_defn): Likewise.
6357         * opencl-lang.c (opencl_language_defn): Likewise.
6358         * p-lang.c (pascal_language_defn): Likewise.
6359         * rust-lang.c (rust_language_defn): Likewise.
6360
6361 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * riscv-tdep.c (riscv_type_align): New function.
6364         (riscv_type_alignment): Delete.
6365         (riscv_arg_location): Use 'type_align'.
6366         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6367
6368 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * gdbtypes.c (type_align): A struct with no non-static fields also
6371         has alignment of 1.
6372
6373 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6374
6375         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6376         component to 0.
6377         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6378         member.
6379         (riscv_struct_info::analyse): New implementation using new
6380         analyse_inner member function.
6381         (riscv_struct_info::field_offset): New member function.
6382         (riscv_struct_info::m_offsets): New member variable.
6383         (riscv_struct_info::analyse_inner): New private member function,
6384         takes the old implementation of riscv_struct_info::analyse but
6385         extended to track field offsets.
6386         (riscv_call_arg_struct): Update the struct folding special cases
6387         to handle cases where empty C++ structs, which are non-zero
6388         length, are found.
6389         (riscv_arg_location): Initialise the length of each location, a
6390         non-zero length now indicates the location is in use.
6391         (riscv_push_dummy_call): Allow for the first location having a
6392         non-zero offset when setting up arguments.
6393         (riscv_return_value): Likewise, but for return values.
6394
6395 2019-04-11  Tom Tromey  <tromey@adacore.com>
6396
6397         * utils.c (internal_vproblem): Make "msg" const.
6398
6399 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6400
6401         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6402         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6403         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6404         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6405
6406 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6407
6408         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6409         function.
6410         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6411         of amd64_collect_native_gregset.
6412         (amd64_linux_nat_target::store_registers): Likewise.
6413
6414 2019-04-10  Tom Tromey  <tom@tromey.com>
6415
6416         * symtab.c (lookup_global_symbol_from_objfile)
6417         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6418         * objfiles.h (class separate_debug_iterator): New.
6419         (class separate_debug_range): New.
6420         (struct objfile) <separate_debug_objfiles>: New method.
6421         (objfile_separate_debug_iterate): Don't declare.
6422         * objfiles.c (separate_debug_iterator::operator++): Rename from
6423         objfile_separate_debug_iterate.
6424         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6425         iterator.
6426         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6427         iterator.
6428
6429 2019-04-10  Tom Tromey  <tom@tromey.com>
6430
6431         * symfile.c (reread_symbols): Remove old comment.
6432         * objfiles.c (free_all_objfiles): Fix a typo.
6433
6434 2019-04-10  Tom Tromey  <tom@tromey.com>
6435
6436         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6437         * minsyms.c (lookup_minimal_symbol): Use foreach.
6438         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6439         (lookup_minimal_symbol_solib_trampoline): Likewise.
6440         * symfile.c (reread_symbols): Use foreach.
6441
6442 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6443             Tom Tromey  <tromey@adacore.com>
6444
6445         PR rust/24414:
6446         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6447         (rust_lex_int_test): Change "value" to be LONGEST.
6448         (rust_lex_tests): Add test for long integer literal.
6449
6450 2019-04-09  Tom Tromey  <tromey@adacore.com>
6451
6452         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6453         to bool.
6454         (extended_remote_target::attach): Update.
6455         (remote_target::remote_notice_new_inferior): Update.
6456         (remote_target::add_current_inferior_and_thread): Update.
6457         * inferior.c (exit_inferior_1): Use "false".
6458         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6459
6460 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6461
6462         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6463         the "start" command.
6464
6465 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6466
6467         * python/py-inferior.c (infpy_thread_from_thread_handle):
6468         Adjust comments to reflect renaming of thread_from_thread_handle
6469         to thread_from_handle.  Adjust keywords.  Fix type error message.
6470         (inferior_object_methods): Add thread_from_handle.  Retain
6471         thread_from_thread_handle, but mark it as deprecated.
6472
6473 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6474
6475         * gdbthread.h (find_thread_by_handle): Revise declaration.
6476         * thread.c (find_thread_by_handle): Likewise.  Adjust
6477         implementation too.
6478         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6479         support for buffer objects as handles.
6480
6481 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6482
6483         * python/py-infthread.c (thpy_thread_handle): New function.
6484         (thread_object_methods): Register thpy_thread_handle.
6485
6486 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6487
6488         * gdbthread.h (thread_to_thread_handle): Declare.
6489         * thread.c (gdbtypes.h): Include.
6490         (thread_to_thread_handle): New function.
6491
6492         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6493         (target_thread_info_to_thread_handle): Declare.
6494         * target.c (target_thread_info_to_thread_handle): New function.
6495         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6496         * target-delegates.c: Regenerate.
6497
6498         * linux-thread-db.c (class thread_db_target): Add method
6499         thread_info_to_thread_handle.
6500         (thread_db_target::thread_info_to_thread_handle): Define.
6501         * remote.c (class remote_target): Add new method
6502         thread_info_to_thread_handle.
6503         (remote_target::thread_info_to_thread_handle): Define.
6504
6505 2019-04-08  Pedro Alves  <palves@redhat.com>
6506
6507         * common/common-exceptions.c (throw_exception): Don't create
6508         named object to throw; throw directly.
6509         (throw_it): Likewise.  Don't initialize gdb_exception::message
6510         here, with new; pass FMT and AP to the ctor instead.
6511         * common/common-exceptions.h: Include <string>.
6512         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6513         const char *, va_list)): New ctor.  Use std::make_shared.
6514         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6515         errors)): Delete.
6516         (gdb_exception_error::gdb_exception_error(enum errors, const char
6517         *, va_list)): New.
6518         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6519         Add assertion.
6520         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6521         errors)): Delete.
6522         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6523         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6524         Add assertion.
6525
6526 2019-04-08  Tom Tromey  <tom@tromey.com>
6527
6528         * valops.c (value_rtti_indirect_type): Replace throw_exception
6529         with throw.
6530         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6531         with throw.
6532         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6533         throw.
6534         * target.c (target_translate_tls_address): Replace throw_exception
6535         with throw.
6536         * stack.c (frame_apply_command_count): Replace throw_exception
6537         with throw.
6538         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6539         throw.
6540         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6541         with throw.
6542         * rs6000-tdep.c (rs6000_frame_cache)
6543         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6544         * remote.c: Replace throw_exception with throw.
6545         * record-full.c (record_full_message, record_full_wait_1)
6546         (record_full_restore): Replace throw_exception with throw.
6547         * record-btrace.c:
6548         (get_thread_current_frame_id, record_btrace_start_replaying)
6549         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6550         (cmd_record_btrace_start): Replace throw_exception with throw.
6551         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6552         throw.
6553         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6554         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6555         * linespec.c:
6556         (find_linespec_symbols): Replace throw_exception with throw.
6557         * infrun.c (displaced_step_prepare, resume): Replace
6558         throw_exception with throw.
6559         * infcmd.c (post_create_inferior): Replace throw_exception with
6560         throw.
6561         * inf-loop.c (inferior_event_handler): Replace throw_exception
6562         with throw.
6563         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6564         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6565         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6566         (get_prev_frame_always, get_frame_pc_if_available)
6567         (get_frame_address_in_block_if_available, get_frame_language):
6568         Replace throw_exception with throw.
6569         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6570         throw_exception with throw.
6571         * eval.c (fetch_subexp_value, evaluate_var_value)
6572         (evaluate_funcall, evaluate_subexp_standard): Replace
6573         throw_exception with throw.
6574         * dwarf2loc.c (call_site_find_chain)
6575         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6576         Replace throw_exception with throw.
6577         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6578         with throw.
6579         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6580         throw.
6581         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6582         * completer.c (complete_line_internal): Replace throw_exception
6583         with throw.
6584         * compile/compile-object-run.c (compile_object_run): Replace
6585         throw_exception with throw.
6586         * cli/cli-script.c (process_next_line): Replace throw_exception
6587         with throw.
6588         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6589         (btrace_enable, btrace_maint_update_pt_packets): Replace
6590         throw_exception with throw.
6591         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6592         throw_exception with throw.
6593         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6594         throw_exception with throw.
6595         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6596         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6597         * aarch64-tdep.c (aarch64_make_prologue_cache)
6598         (aarch64_make_stub_cache): Replace throw_exception with throw.
6599
6600 2019-04-08  Tom Tromey  <tom@tromey.com>
6601
6602         * common/common-exceptions.c (throw_exception): Rename from
6603         throw_exception_cxx.  Remove old copy.  Make argument const.
6604         (throw_it): Create and throw exception objects directly.
6605         * common/common-exceptions.h (throw_exception): Make argument
6606         const.
6607         (struct gdb_exception_error): Add constructor.
6608         (struct gdb_exception_quit): Add constructor.
6609
6610 2019-04-08  Tom Tromey  <tom@tromey.com>
6611
6612         * common/common-exceptions.h (exception_rethrow): Don't declare.
6613         (TRY_SJLJ): Update comment.
6614         (TRY, CATCH, END_CATCH): Remove.
6615         * common/common-exceptions.c (exception_rethrow): Remove.
6616
6617 2019-04-08  Tom Tromey  <tom@tromey.com>
6618
6619         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6620         Remove.
6621         (gdb_exception_error): Rename from
6622         gdb_exception_RETURN_MASK_ERROR.
6623         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6624         (gdb_quit_bad_alloc): Update.
6625         * aarch64-tdep.c: Update.
6626         * ada-lang.c: Update.
6627         * ada-typeprint.c: Update.
6628         * ada-valprint.c: Update.
6629         * amd64-tdep.c: Update.
6630         * arch-utils.c: Update.
6631         * break-catch-throw.c: Update.
6632         * breakpoint.c: Update.
6633         * btrace.c: Update.
6634         * c-varobj.c: Update.
6635         * cli/cli-cmds.c: Update.
6636         * cli/cli-interp.c: Update.
6637         * cli/cli-script.c: Update.
6638         * common/common-exceptions.c: Update.
6639         * common/new-op.c: Update.
6640         * common/selftest.c: Update.
6641         * compile/compile-c-symbols.c: Update.
6642         * compile/compile-cplus-symbols.c: Update.
6643         * compile/compile-object-load.c: Update.
6644         * compile/compile-object-run.c: Update.
6645         * completer.c: Update.
6646         * corelow.c: Update.
6647         * cp-abi.c: Update.
6648         * cp-support.c: Update.
6649         * cp-valprint.c: Update.
6650         * darwin-nat.c: Update.
6651         * disasm-selftests.c: Update.
6652         * dtrace-probe.c: Update.
6653         * dwarf-index-cache.c: Update.
6654         * dwarf-index-write.c: Update.
6655         * dwarf2-frame-tailcall.c: Update.
6656         * dwarf2-frame.c: Update.
6657         * dwarf2loc.c: Update.
6658         * dwarf2read.c: Update.
6659         * eval.c: Update.
6660         * event-loop.c: Update.
6661         * event-top.c: Update.
6662         * exec.c: Update.
6663         * f-valprint.c: Update.
6664         * fbsd-tdep.c: Update.
6665         * frame-unwind.c: Update.
6666         * frame.c: Update.
6667         * gdbtypes.c: Update.
6668         * gnu-v3-abi.c: Update.
6669         * guile/guile-internal.h: Update.
6670         * guile/scm-block.c: Update.
6671         * guile/scm-breakpoint.c: Update.
6672         * guile/scm-cmd.c: Update.
6673         * guile/scm-disasm.c: Update.
6674         * guile/scm-frame.c: Update.
6675         * guile/scm-lazy-string.c: Update.
6676         * guile/scm-math.c: Update.
6677         * guile/scm-param.c: Update.
6678         * guile/scm-ports.c: Update.
6679         * guile/scm-pretty-print.c: Update.
6680         * guile/scm-symbol.c: Update.
6681         * guile/scm-symtab.c: Update.
6682         * guile/scm-type.c: Update.
6683         * guile/scm-value.c: Update.
6684         * i386-linux-tdep.c: Update.
6685         * i386-tdep.c: Update.
6686         * inf-loop.c: Update.
6687         * infcall.c: Update.
6688         * infcmd.c: Update.
6689         * infrun.c: Update.
6690         * jit.c: Update.
6691         * language.c: Update.
6692         * linespec.c: Update.
6693         * linux-fork.c: Update.
6694         * linux-nat.c: Update.
6695         * linux-tdep.c: Update.
6696         * linux-thread-db.c: Update.
6697         * main.c: Update.
6698         * mi/mi-cmd-break.c: Update.
6699         * mi/mi-cmd-stack.c: Update.
6700         * mi/mi-interp.c: Update.
6701         * mi/mi-main.c: Update.
6702         * objc-lang.c: Update.
6703         * p-valprint.c: Update.
6704         * parse.c: Update.
6705         * ppc-linux-tdep.c: Update.
6706         * printcmd.c: Update.
6707         * python/py-arch.c: Update.
6708         * python/py-breakpoint.c: Update.
6709         * python/py-cmd.c: Update.
6710         * python/py-finishbreakpoint.c: Update.
6711         * python/py-frame.c: Update.
6712         * python/py-framefilter.c: Update.
6713         * python/py-gdb-readline.c: Update.
6714         * python/py-inferior.c: Update.
6715         * python/py-infthread.c: Update.
6716         * python/py-lazy-string.c: Update.
6717         * python/py-linetable.c: Update.
6718         * python/py-objfile.c: Update.
6719         * python/py-param.c: Update.
6720         * python/py-prettyprint.c: Update.
6721         * python/py-progspace.c: Update.
6722         * python/py-record-btrace.c: Update.
6723         * python/py-record.c: Update.
6724         * python/py-symbol.c: Update.
6725         * python/py-type.c: Update.
6726         * python/py-unwind.c: Update.
6727         * python/py-utils.c: Update.
6728         * python/py-value.c: Update.
6729         * python/python.c: Update.
6730         * record-btrace.c: Update.
6731         * record-full.c: Update.
6732         * remote-fileio.c: Update.
6733         * remote.c: Update.
6734         * riscv-tdep.c: Update.
6735         * rs6000-aix-tdep.c: Update.
6736         * rs6000-tdep.c: Update.
6737         * rust-exp.y: Update.
6738         * rust-lang.c: Update.
6739         * s390-tdep.c: Update.
6740         * selftest-arch.c: Update.
6741         * solib-dsbt.c: Update.
6742         * solib-frv.c: Update.
6743         * solib-spu.c: Update.
6744         * solib-svr4.c: Update.
6745         * solib.c: Update.
6746         * sparc64-linux-tdep.c: Update.
6747         * stack.c: Update.
6748         * symfile-mem.c: Update.
6749         * symmisc.c: Update.
6750         * target.c: Update.
6751         * thread.c: Update.
6752         * top.c: Update.
6753         * tracefile-tfile.c: Update.
6754         * tui/tui.c: Update.
6755         * typeprint.c: Update.
6756         * unittests/cli-utils-selftests.c: Update.
6757         * unittests/parse-connection-spec-selftests.c: Update.
6758         * valops.c: Update.
6759         * valprint.c: Update.
6760         * value.c: Update.
6761         * varobj.c: Update.
6762         * windows-nat.c: Update.
6763         * x86-linux-nat.c: Update.
6764         * xml-support.c: Update.
6765
6766 2019-04-08  Tom Tromey  <tom@tromey.com>
6767
6768         * xml-support.c: Use C++ exception handling.
6769         * x86-linux-nat.c: Use C++ exception handling.
6770         * windows-nat.c: Use C++ exception handling.
6771         * varobj.c: Use C++ exception handling.
6772         * value.c: Use C++ exception handling.
6773         * valprint.c: Use C++ exception handling.
6774         * valops.c: Use C++ exception handling.
6775         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6776         handling.
6777         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6778         * typeprint.c: Use C++ exception handling.
6779         * tui/tui.c: Use C++ exception handling.
6780         * tracefile-tfile.c: Use C++ exception handling.
6781         * top.c: Use C++ exception handling.
6782         * thread.c: Use C++ exception handling.
6783         * target.c: Use C++ exception handling.
6784         * symmisc.c: Use C++ exception handling.
6785         * symfile-mem.c: Use C++ exception handling.
6786         * stack.c: Use C++ exception handling.
6787         * sparc64-linux-tdep.c: Use C++ exception handling.
6788         * solib.c: Use C++ exception handling.
6789         * solib-svr4.c: Use C++ exception handling.
6790         * solib-spu.c: Use C++ exception handling.
6791         * solib-frv.c: Use C++ exception handling.
6792         * solib-dsbt.c: Use C++ exception handling.
6793         * selftest-arch.c: Use C++ exception handling.
6794         * s390-tdep.c: Use C++ exception handling.
6795         * rust-lang.c: Use C++ exception handling.
6796         * rust-exp.y: Use C++ exception handling.
6797         * rs6000-tdep.c: Use C++ exception handling.
6798         * rs6000-aix-tdep.c: Use C++ exception handling.
6799         * riscv-tdep.c: Use C++ exception handling.
6800         * remote.c: Use C++ exception handling.
6801         * remote-fileio.c: Use C++ exception handling.
6802         * record-full.c: Use C++ exception handling.
6803         * record-btrace.c: Use C++ exception handling.
6804         * python/python.c: Use C++ exception handling.
6805         * python/py-value.c: Use C++ exception handling.
6806         * python/py-utils.c: Use C++ exception handling.
6807         * python/py-unwind.c: Use C++ exception handling.
6808         * python/py-type.c: Use C++ exception handling.
6809         * python/py-symbol.c: Use C++ exception handling.
6810         * python/py-record.c: Use C++ exception handling.
6811         * python/py-record-btrace.c: Use C++ exception handling.
6812         * python/py-progspace.c: Use C++ exception handling.
6813         * python/py-prettyprint.c: Use C++ exception handling.
6814         * python/py-param.c: Use C++ exception handling.
6815         * python/py-objfile.c: Use C++ exception handling.
6816         * python/py-linetable.c: Use C++ exception handling.
6817         * python/py-lazy-string.c: Use C++ exception handling.
6818         * python/py-infthread.c: Use C++ exception handling.
6819         * python/py-inferior.c: Use C++ exception handling.
6820         * python/py-gdb-readline.c: Use C++ exception handling.
6821         * python/py-framefilter.c: Use C++ exception handling.
6822         * python/py-frame.c: Use C++ exception handling.
6823         * python/py-finishbreakpoint.c: Use C++ exception handling.
6824         * python/py-cmd.c: Use C++ exception handling.
6825         * python/py-breakpoint.c: Use C++ exception handling.
6826         * python/py-arch.c: Use C++ exception handling.
6827         * printcmd.c: Use C++ exception handling.
6828         * ppc-linux-tdep.c: Use C++ exception handling.
6829         * parse.c: Use C++ exception handling.
6830         * p-valprint.c: Use C++ exception handling.
6831         * objc-lang.c: Use C++ exception handling.
6832         * mi/mi-main.c: Use C++ exception handling.
6833         * mi/mi-interp.c: Use C++ exception handling.
6834         * mi/mi-cmd-stack.c: Use C++ exception handling.
6835         * mi/mi-cmd-break.c: Use C++ exception handling.
6836         * main.c: Use C++ exception handling.
6837         * linux-thread-db.c: Use C++ exception handling.
6838         * linux-tdep.c: Use C++ exception handling.
6839         * linux-nat.c: Use C++ exception handling.
6840         * linux-fork.c: Use C++ exception handling.
6841         * linespec.c: Use C++ exception handling.
6842         * language.c: Use C++ exception handling.
6843         * jit.c: Use C++ exception handling.
6844         * infrun.c: Use C++ exception handling.
6845         * infcmd.c: Use C++ exception handling.
6846         * infcall.c: Use C++ exception handling.
6847         * inf-loop.c: Use C++ exception handling.
6848         * i386-tdep.c: Use C++ exception handling.
6849         * i386-linux-tdep.c: Use C++ exception handling.
6850         * guile/scm-value.c: Use C++ exception handling.
6851         * guile/scm-type.c: Use C++ exception handling.
6852         * guile/scm-symtab.c: Use C++ exception handling.
6853         * guile/scm-symbol.c: Use C++ exception handling.
6854         * guile/scm-pretty-print.c: Use C++ exception handling.
6855         * guile/scm-ports.c: Use C++ exception handling.
6856         * guile/scm-param.c: Use C++ exception handling.
6857         * guile/scm-math.c: Use C++ exception handling.
6858         * guile/scm-lazy-string.c: Use C++ exception handling.
6859         * guile/scm-frame.c: Use C++ exception handling.
6860         * guile/scm-disasm.c: Use C++ exception handling.
6861         * guile/scm-cmd.c: Use C++ exception handling.
6862         * guile/scm-breakpoint.c: Use C++ exception handling.
6863         * guile/scm-block.c: Use C++ exception handling.
6864         * guile/guile-internal.h: Use C++ exception handling.
6865         * gnu-v3-abi.c: Use C++ exception handling.
6866         * gdbtypes.c: Use C++ exception handling.
6867         * frame.c: Use C++ exception handling.
6868         * frame-unwind.c: Use C++ exception handling.
6869         * fbsd-tdep.c: Use C++ exception handling.
6870         * f-valprint.c: Use C++ exception handling.
6871         * exec.c: Use C++ exception handling.
6872         * event-top.c: Use C++ exception handling.
6873         * event-loop.c: Use C++ exception handling.
6874         * eval.c: Use C++ exception handling.
6875         * dwarf2read.c: Use C++ exception handling.
6876         * dwarf2loc.c: Use C++ exception handling.
6877         * dwarf2-frame.c: Use C++ exception handling.
6878         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6879         * dwarf-index-write.c: Use C++ exception handling.
6880         * dwarf-index-cache.c: Use C++ exception handling.
6881         * dtrace-probe.c: Use C++ exception handling.
6882         * disasm-selftests.c: Use C++ exception handling.
6883         * darwin-nat.c: Use C++ exception handling.
6884         * cp-valprint.c: Use C++ exception handling.
6885         * cp-support.c: Use C++ exception handling.
6886         * cp-abi.c: Use C++ exception handling.
6887         * corelow.c: Use C++ exception handling.
6888         * completer.c: Use C++ exception handling.
6889         * compile/compile-object-run.c: Use C++ exception handling.
6890         * compile/compile-object-load.c: Use C++ exception handling.
6891         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6892         * compile/compile-c-symbols.c: Use C++ exception handling.
6893         * common/selftest.c: Use C++ exception handling.
6894         * common/new-op.c: Use C++ exception handling.
6895         * cli/cli-script.c: Use C++ exception handling.
6896         * cli/cli-interp.c: Use C++ exception handling.
6897         * cli/cli-cmds.c: Use C++ exception handling.
6898         * c-varobj.c: Use C++ exception handling.
6899         * btrace.c: Use C++ exception handling.
6900         * breakpoint.c: Use C++ exception handling.
6901         * break-catch-throw.c: Use C++ exception handling.
6902         * arch-utils.c: Use C++ exception handling.
6903         * amd64-tdep.c: Use C++ exception handling.
6904         * ada-valprint.c: Use C++ exception handling.
6905         * ada-typeprint.c: Use C++ exception handling.
6906         * ada-lang.c: Use C++ exception handling.
6907         * aarch64-tdep.c: Use C++ exception handling.
6908
6909 2019-04-08  Tom Tromey  <tom@tromey.com>
6910
6911         * xml-support.c (gdb_xml_parser::parse): Update.
6912         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6913         * value.c (show_convenience): Update.
6914         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6915         (test_parse_flags_qcs): Update.
6916         * thread.c (thr_try_catch_cmd): Update.
6917         * target.c (target_translate_tls_address): Update.
6918         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6919         (info_frame_command_core, frame_apply_command_count): Update.
6920         * rust-exp.y (rust_lex_exception_test): Update.
6921         * riscv-tdep.c (riscv_print_one_register_info): Update.
6922         * remote.c (remote_target::enable_btrace): Update.
6923         * record-btrace.c (record_btrace_enable_warn): Update.
6924         * python/py-utils.c (gdbpy_convert_exception): Update.
6925         * printcmd.c (do_one_display, print_variable_and_value): Update.
6926         * mi/mi-main.c (mi_print_exception): Update.
6927         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6928         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6929         * linux-nat.c (linux_nat_target::attach): Update.
6930         * linux-fork.c (class scoped_switch_fork_info): Update.
6931         * infrun.c (displaced_step_prepare): Update.
6932         * infcall.c (call_function_by_hand_dummy): Update.
6933         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6934         * gnu-v3-abi.c (print_one_vtable): Update.
6935         * frame.c (get_prev_frame_always): Update.
6936         * f-valprint.c (info_common_command_for_block): Update.
6937         * exec.c (try_open_exec_file): Update.
6938         * exceptions.c (print_exception, exception_print)
6939         (exception_fprintf, exception_print_same): Update.
6940         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6941         * dwarf-index-cache.c (index_cache::store)
6942         (index_cache::lookup_gdb_index): Update.
6943         * darwin-nat.c (maybe_cache_shell): Update.
6944         * cp-valprint.c (cp_print_value_fields): Update.
6945         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6946         (gcc_cplus_symbol_address): Update.
6947         * compile/compile-c-symbols.c (gcc_convert_symbol)
6948         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6949         * common/selftest.c: Update.
6950         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6951         a std::string.
6952         (exception_try_scope_entry, exception_try_scope_exit): Don't
6953         declare.
6954         (struct exception_try_scope): Remove.
6955         (TRY): Don't use exception_try_scope.
6956         (struct gdb_exception): Add constructor, operator=.
6957         <what>: New method.
6958         (struct gdb_exception_RETURN_MASK_ALL)
6959         (struct gdb_exception_RETURN_MASK_ERROR)
6960         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6961         (struct gdb_quit_bad_alloc): Update.
6962         * common/common-exceptions.c (exception_none): Change
6963         initializer.
6964         (struct catcher) <state, exception>: Initialize inline.
6965         <prev>: Remove member.
6966         (current_catcher): Remove.
6967         (catchers): New global.
6968         (exceptions_state_mc_init): Simplify.
6969         (catcher_pop): Remove.
6970         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6971         (try_scope_depth, exception_try_scope_entry)
6972         (exception_try_scope_exit): Remove.
6973         (throw_exception_sjlj): Update.
6974         (exception_messages, exception_messages_size): Remove.
6975         (throw_it): Simplify.
6976         (gdb_exception_sliced_copy): Remove.
6977         (throw_exception_cxx): Update.
6978         * cli/cli-script.c (script_from_file): Update.
6979         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6980         Update.
6981         * ada-valprint.c (ada_val_print): Update.
6982         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6983         (create_excep_cond_exprs): Update.
6984
6985 2019-04-08  Tom Tromey  <tom@tromey.com>
6986
6987         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6988         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6989         (TRY, CATCH, END_CATCH): Remove some definitions.
6990         * common/common-exceptions.c: Don't use GDB_XCPT.
6991         (catcher_list_size): Remove.
6992         (throw_exception, throw_it): Simplify.
6993
6994 2019-04-05  Tom Tromey  <tom@tromey.com>
6995
6996         Revert the header-sorting patch.
6997         * ft32-tdep.c: Revert.
6998         * frv-tdep.c: Revert.
6999         * frv-linux-tdep.c: Revert.
7000         * frame.c: Revert.
7001         * frame-unwind.c: Revert.
7002         * frame-base.c: Revert.
7003         * fork-child.c: Revert.
7004         * findvar.c: Revert.
7005         * findcmd.c: Revert.
7006         * filesystem.c: Revert.
7007         * filename-seen-cache.h: Revert.
7008         * filename-seen-cache.c: Revert.
7009         * fbsd-tdep.c: Revert.
7010         * fbsd-nat.h: Revert.
7011         * fbsd-nat.c: Revert.
7012         * f-valprint.c: Revert.
7013         * f-typeprint.c: Revert.
7014         * f-lang.c: Revert.
7015         * extension.h: Revert.
7016         * extension.c: Revert.
7017         * extension-priv.h: Revert.
7018         * expprint.c: Revert.
7019         * exec.h: Revert.
7020         * exec.c: Revert.
7021         * exceptions.c: Revert.
7022         * event-top.c: Revert.
7023         * event-loop.c: Revert.
7024         * eval.c: Revert.
7025         * elfread.c: Revert.
7026         * dwarf2read.h: Revert.
7027         * dwarf2read.c: Revert.
7028         * dwarf2loc.c: Revert.
7029         * dwarf2expr.h: Revert.
7030         * dwarf2expr.c: Revert.
7031         * dwarf2-frame.c: Revert.
7032         * dwarf2-frame-tailcall.c: Revert.
7033         * dwarf-index-write.h: Revert.
7034         * dwarf-index-write.c: Revert.
7035         * dwarf-index-common.c: Revert.
7036         * dwarf-index-cache.h: Revert.
7037         * dwarf-index-cache.c: Revert.
7038         * dummy-frame.c: Revert.
7039         * dtrace-probe.c: Revert.
7040         * disasm.h: Revert.
7041         * disasm.c: Revert.
7042         * disasm-selftests.c: Revert.
7043         * dictionary.c: Revert.
7044         * dicos-tdep.c: Revert.
7045         * demangle.c: Revert.
7046         * dcache.h: Revert.
7047         * dcache.c: Revert.
7048         * darwin-nat.h: Revert.
7049         * darwin-nat.c: Revert.
7050         * darwin-nat-info.c: Revert.
7051         * d-valprint.c: Revert.
7052         * d-namespace.c: Revert.
7053         * d-lang.c: Revert.
7054         * ctf.c: Revert.
7055         * csky-tdep.c: Revert.
7056         * csky-linux-tdep.c: Revert.
7057         * cris-tdep.c: Revert.
7058         * cris-linux-tdep.c: Revert.
7059         * cp-valprint.c: Revert.
7060         * cp-support.c: Revert.
7061         * cp-namespace.c: Revert.
7062         * cp-abi.c: Revert.
7063         * corelow.c: Revert.
7064         * corefile.c: Revert.
7065         * continuations.c: Revert.
7066         * completer.h: Revert.
7067         * completer.c: Revert.
7068         * complaints.c: Revert.
7069         * coffread.c: Revert.
7070         * coff-pe-read.c: Revert.
7071         * cli-out.h: Revert.
7072         * cli-out.c: Revert.
7073         * charset.c: Revert.
7074         * c-varobj.c: Revert.
7075         * c-valprint.c: Revert.
7076         * c-typeprint.c: Revert.
7077         * c-lang.c: Revert.
7078         * buildsym.c: Revert.
7079         * buildsym-legacy.c: Revert.
7080         * build-id.h: Revert.
7081         * build-id.c: Revert.
7082         * btrace.c: Revert.
7083         * bsd-uthread.c: Revert.
7084         * breakpoint.h: Revert.
7085         * breakpoint.c: Revert.
7086         * break-catch-throw.c: Revert.
7087         * break-catch-syscall.c: Revert.
7088         * break-catch-sig.c: Revert.
7089         * blockframe.c: Revert.
7090         * block.c: Revert.
7091         * bfin-tdep.c: Revert.
7092         * bfin-linux-tdep.c: Revert.
7093         * bfd-target.c: Revert.
7094         * bcache.c: Revert.
7095         * ax-general.c: Revert.
7096         * ax-gdb.h: Revert.
7097         * ax-gdb.c: Revert.
7098         * avr-tdep.c: Revert.
7099         * auxv.c: Revert.
7100         * auto-load.c: Revert.
7101         * arm-wince-tdep.c: Revert.
7102         * arm-tdep.c: Revert.
7103         * arm-symbian-tdep.c: Revert.
7104         * arm-pikeos-tdep.c: Revert.
7105         * arm-obsd-tdep.c: Revert.
7106         * arm-nbsd-tdep.c: Revert.
7107         * arm-nbsd-nat.c: Revert.
7108         * arm-linux-tdep.c: Revert.
7109         * arm-linux-nat.c: Revert.
7110         * arm-fbsd-tdep.c: Revert.
7111         * arm-fbsd-nat.c: Revert.
7112         * arm-bsd-tdep.c: Revert.
7113         * arch-utils.c: Revert.
7114         * arc-tdep.c: Revert.
7115         * arc-newlib-tdep.c: Revert.
7116         * annotate.h: Revert.
7117         * annotate.c: Revert.
7118         * amd64-windows-tdep.c: Revert.
7119         * amd64-windows-nat.c: Revert.
7120         * amd64-tdep.c: Revert.
7121         * amd64-sol2-tdep.c: Revert.
7122         * amd64-obsd-tdep.c: Revert.
7123         * amd64-obsd-nat.c: Revert.
7124         * amd64-nbsd-tdep.c: Revert.
7125         * amd64-nbsd-nat.c: Revert.
7126         * amd64-nat.c: Revert.
7127         * amd64-linux-tdep.c: Revert.
7128         * amd64-linux-nat.c: Revert.
7129         * amd64-fbsd-tdep.c: Revert.
7130         * amd64-fbsd-nat.c: Revert.
7131         * amd64-dicos-tdep.c: Revert.
7132         * amd64-darwin-tdep.c: Revert.
7133         * amd64-bsd-nat.c: Revert.
7134         * alpha-tdep.c: Revert.
7135         * alpha-obsd-tdep.c: Revert.
7136         * alpha-nbsd-tdep.c: Revert.
7137         * alpha-mdebug-tdep.c: Revert.
7138         * alpha-linux-tdep.c: Revert.
7139         * alpha-linux-nat.c: Revert.
7140         * alpha-bsd-tdep.c: Revert.
7141         * alpha-bsd-nat.c: Revert.
7142         * aix-thread.c: Revert.
7143         * agent.c: Revert.
7144         * addrmap.c: Revert.
7145         * ada-varobj.c: Revert.
7146         * ada-valprint.c: Revert.
7147         * ada-typeprint.c: Revert.
7148         * ada-tasks.c: Revert.
7149         * ada-lang.c: Revert.
7150         * aarch64-tdep.c: Revert.
7151         * aarch64-ravenscar-thread.c: Revert.
7152         * aarch64-newlib-tdep.c: Revert.
7153         * aarch64-linux-tdep.c: Revert.
7154         * aarch64-linux-nat.c: Revert.
7155         * aarch64-fbsd-tdep.c: Revert.
7156         * aarch64-fbsd-nat.c: Revert.
7157         * aarch32-linux-nat.c: Revert.
7158
7159 2019-04-05  Tom Tromey  <tom@tromey.com>
7160
7161         * ft32-tdep.c: Sort headers.
7162         * frv-tdep.c: Sort headers.
7163         * frv-linux-tdep.c: Sort headers.
7164         * frame.c: Sort headers.
7165         * frame-unwind.c: Sort headers.
7166         * frame-base.c: Sort headers.
7167         * fork-child.c: Sort headers.
7168         * findvar.c: Sort headers.
7169         * findcmd.c: Sort headers.
7170         * filesystem.c: Sort headers.
7171         * filename-seen-cache.h: Sort headers.
7172         * filename-seen-cache.c: Sort headers.
7173         * fbsd-tdep.c: Sort headers.
7174         * fbsd-nat.h: Sort headers.
7175         * fbsd-nat.c: Sort headers.
7176         * f-valprint.c: Sort headers.
7177         * f-typeprint.c: Sort headers.
7178         * f-lang.c: Sort headers.
7179         * extension.h: Sort headers.
7180         * extension.c: Sort headers.
7181         * extension-priv.h: Sort headers.
7182         * expprint.c: Sort headers.
7183         * exec.h: Sort headers.
7184         * exec.c: Sort headers.
7185         * exceptions.c: Sort headers.
7186         * event-top.c: Sort headers.
7187         * event-loop.c: Sort headers.
7188         * eval.c: Sort headers.
7189         * elfread.c: Sort headers.
7190         * dwarf2read.h: Sort headers.
7191         * dwarf2read.c: Sort headers.
7192         * dwarf2loc.c: Sort headers.
7193         * dwarf2expr.h: Sort headers.
7194         * dwarf2expr.c: Sort headers.
7195         * dwarf2-frame.c: Sort headers.
7196         * dwarf2-frame-tailcall.c: Sort headers.
7197         * dwarf-index-write.h: Sort headers.
7198         * dwarf-index-write.c: Sort headers.
7199         * dwarf-index-common.c: Sort headers.
7200         * dwarf-index-cache.h: Sort headers.
7201         * dwarf-index-cache.c: Sort headers.
7202         * dummy-frame.c: Sort headers.
7203         * dtrace-probe.c: Sort headers.
7204         * disasm.h: Sort headers.
7205         * disasm.c: Sort headers.
7206         * disasm-selftests.c: Sort headers.
7207         * dictionary.c: Sort headers.
7208         * dicos-tdep.c: Sort headers.
7209         * demangle.c: Sort headers.
7210         * dcache.h: Sort headers.
7211         * dcache.c: Sort headers.
7212         * darwin-nat.h: Sort headers.
7213         * darwin-nat.c: Sort headers.
7214         * darwin-nat-info.c: Sort headers.
7215         * d-valprint.c: Sort headers.
7216         * d-namespace.c: Sort headers.
7217         * d-lang.c: Sort headers.
7218         * ctf.c: Sort headers.
7219         * csky-tdep.c: Sort headers.
7220         * csky-linux-tdep.c: Sort headers.
7221         * cris-tdep.c: Sort headers.
7222         * cris-linux-tdep.c: Sort headers.
7223         * cp-valprint.c: Sort headers.
7224         * cp-support.c: Sort headers.
7225         * cp-namespace.c: Sort headers.
7226         * cp-abi.c: Sort headers.
7227         * corelow.c: Sort headers.
7228         * corefile.c: Sort headers.
7229         * continuations.c: Sort headers.
7230         * completer.h: Sort headers.
7231         * completer.c: Sort headers.
7232         * complaints.c: Sort headers.
7233         * coffread.c: Sort headers.
7234         * coff-pe-read.c: Sort headers.
7235         * cli-out.h: Sort headers.
7236         * cli-out.c: Sort headers.
7237         * charset.c: Sort headers.
7238         * c-varobj.c: Sort headers.
7239         * c-valprint.c: Sort headers.
7240         * c-typeprint.c: Sort headers.
7241         * c-lang.c: Sort headers.
7242         * buildsym.c: Sort headers.
7243         * buildsym-legacy.c: Sort headers.
7244         * build-id.h: Sort headers.
7245         * build-id.c: Sort headers.
7246         * btrace.c: Sort headers.
7247         * bsd-uthread.c: Sort headers.
7248         * breakpoint.h: Sort headers.
7249         * breakpoint.c: Sort headers.
7250         * break-catch-throw.c: Sort headers.
7251         * break-catch-syscall.c: Sort headers.
7252         * break-catch-sig.c: Sort headers.
7253         * blockframe.c: Sort headers.
7254         * block.c: Sort headers.
7255         * bfin-tdep.c: Sort headers.
7256         * bfin-linux-tdep.c: Sort headers.
7257         * bfd-target.c: Sort headers.
7258         * bcache.c: Sort headers.
7259         * ax-general.c: Sort headers.
7260         * ax-gdb.h: Sort headers.
7261         * ax-gdb.c: Sort headers.
7262         * avr-tdep.c: Sort headers.
7263         * auxv.c: Sort headers.
7264         * auto-load.c: Sort headers.
7265         * arm-wince-tdep.c: Sort headers.
7266         * arm-tdep.c: Sort headers.
7267         * arm-symbian-tdep.c: Sort headers.
7268         * arm-pikeos-tdep.c: Sort headers.
7269         * arm-obsd-tdep.c: Sort headers.
7270         * arm-nbsd-tdep.c: Sort headers.
7271         * arm-nbsd-nat.c: Sort headers.
7272         * arm-linux-tdep.c: Sort headers.
7273         * arm-linux-nat.c: Sort headers.
7274         * arm-fbsd-tdep.c: Sort headers.
7275         * arm-fbsd-nat.c: Sort headers.
7276         * arm-bsd-tdep.c: Sort headers.
7277         * arch-utils.c: Sort headers.
7278         * arc-tdep.c: Sort headers.
7279         * arc-newlib-tdep.c: Sort headers.
7280         * annotate.h: Sort headers.
7281         * annotate.c: Sort headers.
7282         * amd64-windows-tdep.c: Sort headers.
7283         * amd64-windows-nat.c: Sort headers.
7284         * amd64-tdep.c: Sort headers.
7285         * amd64-sol2-tdep.c: Sort headers.
7286         * amd64-obsd-tdep.c: Sort headers.
7287         * amd64-obsd-nat.c: Sort headers.
7288         * amd64-nbsd-tdep.c: Sort headers.
7289         * amd64-nbsd-nat.c: Sort headers.
7290         * amd64-nat.c: Sort headers.
7291         * amd64-linux-tdep.c: Sort headers.
7292         * amd64-linux-nat.c: Sort headers.
7293         * amd64-fbsd-tdep.c: Sort headers.
7294         * amd64-fbsd-nat.c: Sort headers.
7295         * amd64-dicos-tdep.c: Sort headers.
7296         * amd64-darwin-tdep.c: Sort headers.
7297         * amd64-bsd-nat.c: Sort headers.
7298         * alpha-tdep.c: Sort headers.
7299         * alpha-obsd-tdep.c: Sort headers.
7300         * alpha-nbsd-tdep.c: Sort headers.
7301         * alpha-mdebug-tdep.c: Sort headers.
7302         * alpha-linux-tdep.c: Sort headers.
7303         * alpha-linux-nat.c: Sort headers.
7304         * alpha-bsd-tdep.c: Sort headers.
7305         * alpha-bsd-nat.c: Sort headers.
7306         * aix-thread.c: Sort headers.
7307         * agent.c: Sort headers.
7308         * addrmap.c: Sort headers.
7309         * ada-varobj.c: Sort headers.
7310         * ada-valprint.c: Sort headers.
7311         * ada-typeprint.c: Sort headers.
7312         * ada-tasks.c: Sort headers.
7313         * ada-lang.c: Sort headers.
7314         * aarch64-tdep.c: Sort headers.
7315         * aarch64-ravenscar-thread.c: Sort headers.
7316         * aarch64-newlib-tdep.c: Sort headers.
7317         * aarch64-linux-tdep.c: Sort headers.
7318         * aarch64-linux-nat.c: Sort headers.
7319         * aarch64-fbsd-tdep.c: Sort headers.
7320         * aarch64-fbsd-nat.c: Sort headers.
7321         * aarch32-linux-nat.c: Sort headers.
7322
7323 2019-04-04  Tom Tromey  <tom@tromey.com>
7324
7325         * varobj.c (varobj_create): Update.
7326         * rust-exp.y (struct rust_parser) <update_innermost_block,
7327         lookup_symbol>: New methods.
7328         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7329         Rename.
7330         (rust_parser::rust_lookup_type)
7331         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7332         * printcmd.c (display_command, do_one_display): Update.
7333         * parser-defs.h (struct parser_state) <parser_state>: Add
7334         "tracker" parameter.
7335         (block_tracker): New member.
7336         (class innermost_block_tracker) <innermost_block_tracker>: Add
7337         "types" parameter.
7338         <reset>: Remove method.
7339         (innermost_block): Don't declare.
7340         (null_post_parser): Update.
7341         * parse.c (innermost_block): Remove global.
7342         (write_dollar_variable): Update.
7343         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7344         Remove "tracker_types" parameter.
7345         (parse_expression): Add "tracker" parameter.
7346         (parse_expression_for_completion): Update.
7347         (null_post_parser): Add "tracker" parameter.
7348         * p-exp.y: Update rules.
7349         * m2-exp.y: Update rules.
7350         * language.h (struct language_defn) <la_post_parser>: Add
7351         "tracker" parameter.
7352         * go-exp.y: Update rules.
7353         * f-exp.y: Update rules.
7354         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7355         parameter.
7356         * d-exp.y: Update rules.
7357         * c-exp.y: Update rules.
7358         * breakpoint.c (set_breakpoint_condition): Create an
7359         innermost_block_tracker.
7360         (watch_command_1): Likewise.
7361         * ada-lang.c (resolve): Add "tracker" parameter.
7362         (resolve_subexp): Likewise.
7363         * ada-exp.y (write_var_from_sym): Update.
7364
7365 2019-04-04  Tom Tromey  <tom@tromey.com>
7366
7367         * type-stack.h: New file.
7368         * type-stack.c: New file.
7369         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7370         type-stack.h.
7371         (insert_into_type_stack, insert_type, push_type, push_type_int)
7372         (insert_type_address_space, pop_type, pop_type_int)
7373         (pop_typelist, pop_type_stack, append_type_stack)
7374         (push_type_stack, get_type_stack, push_typelist)
7375         (follow_type_instance_flags, follow_types): Don't declare.
7376         * parse.c (type_stack): Remove global.
7377         (parse_exp_in_context): Update.
7378         (insert_into_type_stack, insert_type, push_type, push_type_int)
7379         (insert_type_address_space, pop_type, pop_type_int)
7380         (pop_typelist, pop_type_stack, append_type_stack)
7381         (push_type_stack, get_type_stack, push_typelist)
7382         (follow_type_instance_flags, follow_types): Remove (moved to
7383         type-stack.c).
7384         * f-exp.y (type_stack): New global.
7385         Update rules.
7386         (push_kind_type, f_parse): Update.
7387         * d-exp.y (type_stack): New global.
7388         Update rules.
7389         (d_parse): Update.
7390         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7391         Update rules.
7392         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7393         (HFILES_NO_SRCDIR): Add type-stack.h.
7394
7395 2019-04-04  Tom Tromey  <tom@tromey.com>
7396
7397         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7398         (rust_parser::convert_ast_to_expression, rust_parse)
7399         (rust_lex_test_completion, rust_lex_tests): Update.
7400         * parser-defs.h (struct expr_completion_state): New.
7401         (struct parser_state) <parser_state>: Add completion parameter.
7402         <mark_struct_expression, mark_completion_tag>: New methods.
7403         <parse_completion, m_completion_state>: New members.
7404         (prefixify_expression, null_post_parser): Update.
7405         (mark_struct_expression, mark_completion_tag): Don't declare.
7406         * parse.c (parse_completion, expout_last_struct)
7407         (expout_tag_completion_type, expout_completion_name): Remove
7408         globals.
7409         (parser_state::mark_struct_expression)
7410         (parser_state::mark_completion_tag): Now methods.
7411         (prefixify_expression): Add last_struct parameter.
7412         (prefixify_subexp): Likewise.
7413         (parse_exp_1): Update.
7414         (parse_exp_in_context): Add cstate parameter.  Update.
7415         (parse_expression_for_completion): Create an
7416         expr_completion_state.
7417         (null_post_parser): Add "completion" parameter.
7418         * p-exp.y: Update rules.
7419         (yylex): Update.
7420         * language.h (struct language_defn) <la_post_parser>: Add
7421         "completing" parameter.
7422         * go-exp.y: Update rules.
7423         (lex_one_token): Update.
7424         * expression.h (parse_completion): Don't declare.
7425         * d-exp.y: Update rules.
7426         (lex_one_token): Update rules.
7427         * c-exp.y: Update rules.
7428         (lex_one_token): Update.
7429         * ada-lang.c (resolve): Add "parse_completion" parameter.
7430         (resolve_subexp): Likewise.
7431         (ada_resolve_function): Likewise.
7432
7433 2019-04-04  Tom Tromey  <tom@tromey.com>
7434
7435         * parser-defs.h (struct parser_state) <start_arglist,
7436         end_arglist>: New methods.
7437         <arglist_len, m_funcall_chain>: New members.
7438         (arglist_len, start_arglist, end_arglist): Don't declare.
7439         * parse.c (arglist_len, funcall_chain): Remove global.
7440         (start_arglist, end_arglist): Remove functions.
7441         (parse_exp_in_context): Update.
7442         * p-exp.y: Update rules.
7443         * m2-exp.y: Update rules.
7444         * go-exp.y: Update rules.
7445         * f-exp.y: Update rules.
7446         * d-exp.y: Update rules.
7447         * c-exp.y: Update rules.
7448
7449 2019-04-04  Tom Tromey  <tom@tromey.com>
7450
7451         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7452         lex_operator, push_back>: New methods.
7453         Update all rules.
7454         (rust_parser::lex_hex, lex_escape): Rename and update.
7455         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7456         (rust_parser::lex_operator): Rename and update.
7457         (rust_parser::lex_number, rustyylex, rustyyerror)
7458         (rust_lex_test_init, rust_lex_test_sequence)
7459         (rust_lex_test_push_back, rust_lex_tests): Update.
7460         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7461         parameter.
7462         <lexptr, prev_lexptr>: New members.
7463         (lexptr, prev_lexptr): Don't declare.
7464         * parse.c (lexptr, prev_lexptr): Remove globals.
7465         (parse_exp_in_context): Update.
7466         * p-exp.y (yylex, yyerror): Update.
7467         * m2-exp.y (parse_number, yylex, yyerror): Update.
7468         * go-exp.y (lex_one_token, yyerror): Update.
7469         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7470         * d-exp.y (lex_one_token, yyerror): Update.
7471         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7472         (lex_one_token, yyerror): Update.
7473         * ada-lex.l (YY_INPUT): Update.
7474         (rewind_to_char): Update.
7475         * ada-exp.y (yyerror): Update.
7476
7477 2019-04-04  Tom Tromey  <tom@tromey.com>
7478
7479         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7480         * parser-defs.h (struct parser_state) <parser_state>: Add new
7481         parameter.
7482         <comma_terminates>: New member.
7483         (comma_terminates): Don't declare global.
7484         * parse.c (comma_terminates): Remove global.
7485         (parse_exp_in_context): Update.
7486         * p-exp.y (yylex): Update.
7487         * m2-exp.y (yylex): Update.
7488         * go-exp.y (lex_one_token): Update.
7489         * f-exp.y (yylex): Update.
7490         * d-exp.y (lex_one_token): Update.
7491         * c-exp.y (lex_one_token): Update.
7492         * ada-lex.l: Update.
7493
7494 2019-04-04  Tom Tromey  <tom@tromey.com>
7495
7496         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7497         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7498         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7499         * parser-defs.h (paren_depth): Don't declare.
7500         * parse.c (paren_depth): Remove global.
7501         (parse_exp_in_context): Update.
7502         * p-exp.y (paren_depth): New global.
7503         (pascal_parse): Initialize it.
7504         * m2-exp.y (paren_depth): New global.
7505         (m2_parse): Initialize it.
7506         * go-exp.y (paren_depth): New global.
7507         (go_parse): Initialize it.
7508         * f-exp.y (paren_depth): New global.
7509         (f_parse): Initialize it.
7510         * d-exp.y (paren_depth): New global.
7511         (d_parse): Initialize it.
7512         * c-exp.y (paren_depth): New global.
7513         (c_parse): Initialize it.
7514         * ada-lex.l (paren_depth): New global.
7515         (lexer_init): Initialize it.
7516
7517 2019-04-04  Tom Tromey  <tom@tromey.com>
7518
7519         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7520         (rust_parser::convert_ast_to_type)
7521         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7522         * parser-defs.h (struct parser_state) <parser_state>: Add
7523         parameters.  Initialize new members.
7524         <expression_context_block, expression_context_pc>: New members.
7525         * parse.c (expression_context_block, expression_context_pc):
7526         Remove globals.
7527         (parse_exp_in_context): Update.
7528         * p-exp.y: Update all rules.
7529         (yylex): Update.
7530         * m2-exp.y: Update all rules.
7531         (yylex): Update.
7532         * go-exp.y (yylex): Update.
7533         * f-exp.y (yylex): Update.
7534         * d-exp.y: Update all rules.
7535         (yylex): Update.
7536         * c-exp.y: Update all rules.
7537         (lex_one_token, classify_name, yylex, c_parse): Update.
7538         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7539
7540 2019-04-04  Tom Tromey  <tom@tromey.com>
7541
7542         * gdbarch.h, gdbarch.c: Rebuild.
7543         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7544         * stap-probe.h:
7545         (struct stap_parse_info): Replace "parser_state" with
7546         "expr_builder".
7547         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7548         (parser_state): New class.
7549         * parse.c (expr_builder): Rename.
7550         (expr_builder::release): Rename.
7551         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7552         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7553         (write_exp_elt_longcst, write_exp_elt_floatcst)
7554         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7555         (write_exp_string_vector, write_exp_bitstring)
7556         (write_exp_msymbol, mark_struct_expression)
7557         (write_dollar_variable)
7558         (insert_type_address_space, increase_expout_size): Replace
7559         "parser_state" with "expr_builder".
7560         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7561         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7562         "parser_state" with "expr_builder".
7563
7564 2019-04-04  Tom Tromey  <tom@tromey.com>
7565
7566         * rust-exp.y: Replace "parse_language" with method call.
7567         * p-exp.y:
7568         (yylex): Replace "parse_language" with method call.
7569         * m2-exp.y:
7570         (yylex): Replace "parse_language" with method call.
7571         * go-exp.y (classify_name): Replace "parse_language" with method
7572         call.
7573         * f-exp.y (yylex): Replace "parse_language" with method call.
7574         * d-exp.y (lex_one_token): Replace "parse_language" with method
7575         call.
7576         * c-exp.y:
7577         (lex_one_token, classify_name, yylex): Replace "parse_language"
7578         with method call.
7579         * ada-exp.y (find_primitive_type, type_char)
7580         (type_system_address): Replace "parse_language" with method call.
7581
7582 2019-04-04  Tom Tromey  <tom@tromey.com>
7583
7584         * rust-exp.y: Replace "parse_gdbarch" with method call.
7585         * parse.c (write_dollar_variable, insert_type_address_space):
7586         Replace "parse_gdbarch" with method call.
7587         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7588         call.
7589         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7590         call.
7591         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7592         "parse_gdbarch" with method call.
7593         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7594         with method call.
7595         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7596         "parse_gdbarch" with method call.
7597         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7598         "parse_gdbarch" with method call.
7599         * c-exp.y (parse_type, parse_number, classify_name): Replace
7600         "parse_gdbarch" with method call.
7601         * ada-lex.l: Replace "parse_gdbarch" with method call.
7602         * ada-exp.y (parse_type, find_primitive_type, type_char)
7603         (type_system_address): Replace "parse_gdbarch" with method call.
7604
7605 2019-04-04  Tom Tromey  <tom@tromey.com>
7606
7607         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7608         * stap-probe.c (stap_parse_argument): Update.
7609         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7610         initial_size parameter.
7611         * rust-exp.y (rust_lex_tests): Update.
7612         * parse.c (parser_state): Update.
7613         (parse_exp_in_context): Update.
7614         * parser-defs.h (struct parser_state) <parser_state>: Remove
7615         "initial_size" parameter.
7616
7617 2019-04-04  Tom Tromey  <tom@tromey.com>
7618
7619         * parser-defs.h (increase_expout_size): Don't declare.
7620         * parse.c (increase_expout_size): Now static.
7621
7622 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7623
7624         * gnu-nat.c (gnu_nat_target::wait): Fix
7625         target_waitstatus_to_string call.
7626
7627 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         * eval.c (evaluate_subexp_standard): Handle internal functions
7630         during Fortran function call handling.
7631
7632 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * NEWS: Mention new internal functions.
7635         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7636         (read_base_type): Use dwarf2_init_complex_target_type.
7637         * value.c (creal_internal_fn): New function.
7638         (cimag_internal_fn): New function.
7639         (_initialize_values): Register new internal functions.
7640
7641 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7642
7643         * infrun.c (stop_all_threads): If debug_infrun, always
7644         trace the wait status after wait_one, using
7645         target_waitstatus_to_string and target_pid_to_str.
7646         (handle_inferior_event): Replace various trace of
7647         wait status kind by a single trace.
7648         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7649         wait status kind image by target_waitstatus_to_string.
7650         * target/waitstatus.c (target_waitstatus_to_string): Fix
7651         obsolete comment.
7652
7653 2019-04-01  Tom Tromey  <tromey@adacore.com>
7654
7655         PR symtab/23331:
7656         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7657
7658 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7659             Pedro Alves  <palves@redhat.com>
7660
7661         * top.c (quit_force): Call 'finalize_values'.
7662         * value.c (finalize_values): New function.
7663         * value.h (finalize_values): Declare.
7664
7665 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7666
7667         * NEWS: Announce $_gdb_major and $_gdb_minor.
7668
7669         * top.c (init_gdb_version_vars): New function.
7670         (gdb_init): Call init_gdb_version_vars.
7671
7672 2019-03-29  Tom Tromey  <tromey@adacore.com>
7673
7674         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7675         help text.  Remove dead code.
7676
7677 2019-03-29  Keith Seitz  <keiths@redhat.com>
7678
7679         From Siddhesh Poyarekar:
7680         * f-lang.h (f77_get_upperbound): Return LONGEST.
7681         (f77_get_lowerbound): Likewise.
7682         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7683         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7684         print them.
7685         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7686         plongest to format print it.
7687         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7688         (f77_get_upperbound): Likewise.
7689         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7690         LOWER_BOUND to LONGEST.
7691         (f77_create_arrayprint_offset_tbl): Likewise.
7692
7693 2019-03-29  Keith Seitz  <keiths@redhat.com>
7694
7695         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7696         %s/pulongest for TYPE_LENGTH instead of %d in format
7697         strings.
7698         * ada-typerint.c (ada_print_type): Likewise.
7699         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7700         * compile/compile-c-support.c (generate_register_struct): Likewise.
7701         * gdbtypes.c (recursive_dump_type): Likewise.
7702         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7703         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7704         instead of %d in format strings.
7705         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7706         to std::min to ULONGEST.
7707         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7708         instead of %d in format strings.
7709         * tracepoint.c (info_scope_command): Likewise.
7710         * typeprint.c (print_offset_data::update)
7711         (print_offset_data::finish): Likewise.
7712         * xtensa-tdep.c (xtensa_store_return_value)
7713         (xtensa_push_dummy_call): Likewise.
7714
7715 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7716
7717         * windows-nat.c (display_selector): Fixed format specifications
7718         for 64-bit Cygwin.
7719
7720 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7721
7722         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7723
7724 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7725
7726         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7727         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7728         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7729         (nios2_linux_init_abi): Install it.
7730
7731 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7732
7733         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7734
7735 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7736
7737         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7738
7739 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7740             Tom Tromey  <tromey@adacore.com>
7741
7742         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7743
7744 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7745
7746         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7747         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7748         method to compute the bounds of range types. Also print "[evaluated]"
7749         if the bounds' values come from a dynamic evaluation.
7750
7751 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7754         whitespace when pretty printing is on.
7755
7756 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * ppc-linux-nat.c: Add include.
7759
7760 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7761
7762         * NEWS: Mention AArch64 Pointer Authentication.
7763
7764 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7765
7766         * arm-linux-nat.c: Add include.
7767
7768 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7769
7770         * source-cache.c (source_cache::get_source_lines): Re-read
7771         fullname after calling open_source_file.
7772
7773 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7774
7775         * NEWS: Mention TLS support for FreeBSD.
7776
7777 2019-03-25  Tom Tromey  <tromey@adacore.com>
7778
7779         * minsyms.c (BUNCH_SIZE): Update comment.
7780         (~minimal_symbol_reader): Remove old comment.
7781         (compact_minimal_symbols): Update comment.
7782         (minimal_symbol_reader::install): Remove old comment.  Update
7783         other comments.
7784
7785 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7786
7787         * s390-linux-nat.c: Add include.
7788
7789 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7790
7791         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7792         Call linux_get_hwcap.
7793         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7794         Likewise.
7795         (aarch64_linux_get_hwcap): Remove function.
7796         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7797         declaration.
7798         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7799         linux_get_hwcap.
7800         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7801         * linux-tdep.c (linux_get_hwcap): Add function.
7802         (linux_get_hwcap2): Likewise.
7803         * linux-tdep.h (linux_get_hwcap): Add declaration.
7804         (linux_get_hwcap2): Likewise.
7805         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7806         (ppc_linux_get_hwcap2): Likewise.
7807         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7808         linux_get_hwcap.
7809         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7810         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7811         (ppc_linux_nat_target::read_description): Likewise.
7812         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7813         * s390-linux-nat.c: Likewise.
7814         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7815
7816 2019-03-24  Tom Tromey  <tom@tromey.com>
7817
7818         * ada-lang.c (standard_lookup): Simplify initialization.
7819         (ada_lookup_symbol_nonlocal): Simplify return.
7820         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7821         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7822         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7823         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7824         initialization.
7825         * solib.c (solib_global_lookup): Simplify.
7826         * symtab.c (null_block_symbol): Remove.
7827         (symbol_cache_lookup): Simplify returns.
7828         (lookup_language_this): Simplify returns.
7829         (lookup_symbol_aux): Simplify return.
7830         (lookup_local_symbol): Simplify returns.
7831         (lookup_global_symbol_from_objfile): Simplify return.
7832         (lookup_symbol_in_objfile_symtabs)
7833         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7834         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7835         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7836         * cp-namespace.c (cp_lookup_bare_symbol)
7837         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7838         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7839         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7840         (cp_lookup_symbol_via_imports): Simplify initialization.
7841         (find_symbol_in_baseclass): Likewise.
7842         * symtab.h (null_block_symbol): Remove.
7843         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7844         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7845         (d_lookup_symbol_module): Likewise.
7846         (find_symbol_in_baseclass): Simplify initialization.
7847
7848 2019-03-24  Tom Tromey  <tom@tromey.com>
7849
7850         * expression.h: Don't include symtab.h.
7851         (struct block): Forward declare.
7852
7853 2019-03-24  Tom Tromey  <tom@tromey.com>
7854
7855         * c-exp.y (typebase): Remove casts.
7856         * gdbtypes.c (lookup_unsigned_typename, )
7857         (lookup_signed_typename): Remove cast.
7858         * eval.c (parse_to_comma_and_eval): Remove cast.
7859         * parse.c (write_dollar_variable): Remove cast.
7860         * block.h (struct block) <superblock>: Now const.
7861         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7862         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7863         (map_block): Make "block" const.
7864         * symfile.h (struct quick_symbol_functions)
7865         <map_matching_symbols>: Constify block argument to "callback".
7866         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7867         const.
7868         (find_pc_sect_compunit_symtab): Make "b" const.
7869         (find_symbol_at_address): Likewise.
7870         (search_symbols): Likewise.
7871         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7872         (dw2_debug_names_lookup_symbol): Likewise.
7873         (dw2_map_matching_symbols): Update.
7874         * p-valprint.c (pascal_val_print): Remove "block".
7875         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7876         (aux_add_nonlocal_symbols): Make "block" const.
7877         (resolve_subexp): Remove cast.
7878         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7879         const.
7880         (iterate_over_file_blocks): Likewise.
7881         * f-exp.y (%union) <bval>: Remove.
7882         * coffread.c (patch_opaque_types): Make "b" const.
7883         * spu-tdep.c (spu_catch_start): Make "block" const.
7884         * c-valprint.c (print_unpacked_pointer): Remove "block".
7885         * symmisc.c (dump_symtab_1): Make "b" const.
7886         (block_depth): Make "block" const.
7887         * d-exp.y (%union) <bval>: Remove.
7888         * cp-support.h (cp_lookup_rtti_type): Update.
7889         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7890         * psymtab.c (psym_lookup_symbol): Make "block" const.
7891         (maintenance_check_psymtabs): Make "b" const.
7892         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7893         (enumerate_locals, enumerate_args): Update.
7894         * python/py-symtab.c (stpy_global_block): Make "block" const.
7895         (stpy_static_block): Likewise.
7896         * inline-frame.c (block_starting_point_at): Make "new_block"
7897         const.
7898         * block.c (find_block_in_blockvector): Make return type const.
7899         (blockvector_for_pc_sect): Make "b" const.
7900         (find_block_in_blockvector): Make "b" const.
7901
7902 2019-03-23  Tom Tromey  <tom@tromey.com>
7903
7904         * varobj.c (varobj_create): Update.
7905         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7906         * printcmd.c (display_command, do_one_display): Don't reset
7907         innermost_block.
7908         * parser-defs.h (enum innermost_block_tracker_type): Move to
7909         expression.h.
7910         (innermost_block): Update comment.
7911         * parse.c (parse_exp_1): Add tracker_types parameter.
7912         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7913         tracker_types parameter.  Reset innermost_block.
7914         (parse_exp_in_context): Remove.
7915         (parse_expression_for_completion): Update.
7916         * objfiles.c (~objfile): Don't reset expression_context_block or
7917         innermost_block.
7918         * expression.h (enum innermost_block_tracker_type): Move from
7919         parser-defs.h.
7920         (parse_exp_1): Add tracker_types parameter.
7921         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7922         reset innermost_block.
7923
7924 2019-03-23  Tom Tromey  <tom@tromey.com>
7925
7926         * objfiles.h: Include bcache.h.
7927
7928 2019-03-23  Tom Tromey  <tom@tromey.com>
7929
7930         * linespec.c (get_current_search_block): Use
7931         scoped_restore_current_language.
7932         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7933
7934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7935             Jiong Wang  <jiong.wang@arm.com>
7936
7937         * aarch64-linux-tdep.c
7938         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7939         section.
7940         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7941
7942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7943             Jiong Wang  <jiong.wang@arm.com>
7944
7945         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7946         instructions.
7947         (aarch64_analyze_prologue_test): Add PACIASP test.
7948         (aarch64_prologue_prev_register): Unmask PC value.
7949
7950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7951             Jiong Wang  <jiong.wang@arm.com>
7952
7953         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7954         (aarch64_dwarf2_prev_register): Unmask PC value.
7955         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7956         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7957         DW_CFA_AARCH64_negate_ra_state.
7958         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7959
7960 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7961             Jiong Wang  <jiong.wang@arm.com>
7962
7963         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7964         registers.
7965         (aarch64_pseudo_register_name): Likewise.
7966         (aarch64_pseudo_register_type): Likewise.
7967         (aarch64_pseudo_register_reggroup_p): Likewise.
7968         (aarch64_gdbarch_init): Add pauth registers.
7969         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7970         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7971         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7972         (struct gdbarch_tdep): Add regnum for ra_state.
7973
7974 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7975             Jiong Wang  <jiong.wang@arm.com>
7976
7977         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7978
7979 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7980             Jiong Wang  <jiong.wang@arm.com>
7981
7982         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7983         function.
7984         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7985         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7986         (aarch64_gdbarch_init): Add puth registers.
7987         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7988         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7989         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7990
7991 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7992             Jiong Wang  <jiong.wang@arm.com>
7993
7994         * aarch64-linux-nat.c
7995         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7996         * aarch64-linux-tdep.c
7997         (aarch64_linux_core_read_description): Likewise.
7998         (aarch64_linux_get_hwcap): New function.
7999         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8000         (aarch64_linux_get_hwcap): New declaration.
8001
8002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8003             Jiong Wang  <jiong.wang@arm.com>
8004
8005         * aarch64-linux-nat.c
8006         (aarch64_linux_nat_target::read_description): Add pauth param.
8007         * aarch64-linux-tdep.c
8008         (aarch64_linux_core_read_description): Likewise.
8009         * aarch64-tdep.c (struct target_desc): Add in pauth.
8010         (aarch64_read_description): Add pauth param.
8011         (aarch64_gdbarch_init): Likewise.
8012         * aarch64-tdep.h (aarch64_read_description): Likewise.
8013         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8014         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8015         * features/Makefile: Add new files.
8016         * features/aarch64-pauth.c: New file.
8017         * features/aarch64-pauth.xml: New file.
8018
8019 2019-03-20  Tom Tromey  <tromey@adacore.com>
8020
8021         * infrun.c (handle_inferior_event): Rename from
8022         handle_inferior_event_1.  Create a scoped_value_mark.
8023         (handle_inferior_event): Remove.
8024
8025 2019-03-19  Tom Tromey  <tromey@adacore.com>
8026
8027         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8028         * infrun.h (print_stop_event): Add "displays" parameter.
8029         * infrun.c (print_stop_event): Add "displays" parameter.
8030
8031 2019-03-19  Pedro Alves  <palves@redhat.com>
8032
8033         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8034         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8035         to -1.  Fix TABs vs spaces.
8036         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8037         * tui/tui-out.h (tui_ui_out) Add intro comments.
8038         <m_line, m_start_of_line>: In-class initialize, and add describing
8039         comment.
8040
8041 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8042
8043         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8044         variable names.
8045         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8046
8047 2019-03-18  Pedro Alves  <palves@redhat.com>
8048             Eli Zaretskii <eliz@gnu.org>
8049
8050         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8051         m_line and m_start_of_line.
8052
8053 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8054
8055         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8056         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8057         it returns a newline.  This fixes a regression in TU mode, whereby
8058         the next line is output on the same screen line as the user input.
8059
8060 2019-03-18  Tom Tromey  <tromey@adacore.com>
8061
8062         * minsyms.c (minimal_symbol_reader::install): Remove call to
8063         obstack_blank.
8064
8065 2019-03-18  Pedro Alves  <palves@redhat.com>
8066
8067         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8068         New globals.
8069         (apply_style): New, factored out from ...
8070         (apply_ansi_escape): ... this.  Handle reverse video mode.
8071         (tui_set_reverse_mode): New function.
8072         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8073         * tui/tui-winsource.c (tui_show_source_line): Use
8074         tui_set_reverse_mode instead of setting A_STANDOUT.
8075         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8076         New setter methods.
8077
8078 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8079
8080         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8081         Handle tabs.
8082
8083 2019-03-18  Tom Tromey  <tromey@adacore.com>
8084
8085         * ada-lang.c (empty_array): Add "high" parameter.
8086         (ada_evaluate_subexp): Update.
8087
8088 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8089
8090         * unittests/string_view-selftests.c: Define
8091         _initialize_string_view_selftests unconditionally.
8092
8093 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8094
8095         PR gdb/24350
8096         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8097
8098 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8099
8100         PR gdb/24351
8101         * windows-nat.c (display_selector): Fix format specifiers.
8102
8103 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8104
8105         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8106         tui_refill_source_window instead of tui_refresh_win, to update the
8107         current execution line.  This fixes redisplay of the current line
8108         when stepping through the code with "next" or "step".
8109
8110 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8111
8112         * source-cache.c (source_cache::get_source_lines): Call
8113         find_source_lines to initialize s->nlines.  This fixes vertical
8114         scrolling of TUI source window when the DOWN arrow is pressed.
8115
8116 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8117
8118         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8119         linux-thread-db.c (_initialize_thread_db): Likewise.
8120
8121 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8122
8123         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8124         wclrtoeol in tui_show_source_line".  This reverts changes made in
8125         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8126
8127 2019-03-15  Tom Tromey  <tom@tromey.com>
8128
8129         * symtab.h (struct minimal_symbol): Derive from
8130         general_symbol_info.
8131         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8132         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8133         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8134         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8135         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8136         (MSYMBOL_SEARCH_NAME): Update.
8137         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8138         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8139         * minsyms.c (minimal_symbol_reader::record_full): Update.
8140
8141 2019-03-15  Tom Tromey  <tom@tromey.com>
8142
8143         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8144
8145 2019-03-15  Tom Tromey  <tom@tromey.com>
8146
8147         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8148         unique_xmalloc_ptr.
8149         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8150         Update.
8151         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8152         (build_minimal_symbol_hash_tables)
8153         (minimal_symbol_reader::install): Update.
8154
8155 2019-03-15  Tom Tromey  <tom@tromey.com>
8156
8157         * symtab.c (create_demangled_names_hash): Update.
8158         (symbol_set_names): Update.
8159         * objfiles.h (struct objfile_per_bfd_storage)
8160         <demangled_names_hash>: Now an htab_up.
8161         * objfiles.c (objfile_per_bfd_storage): Simplify.
8162
8163 2019-03-15  Tom Tromey  <tom@tromey.com>
8164
8165         * objfiles.h (struct objfile_per_bfd_storage): Declare
8166         destructor.
8167         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8168         New.
8169         (get_objfile_bfd_data): Use new.  Don't initialize
8170         language_of_main.
8171         (free_objfile_per_bfd_storage): Remove.
8172         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8173
8174 2019-03-15  Tom Tromey  <tom@tromey.com>
8175
8176         * symfile.c (reread_symbols): Update.
8177         * objfiles.c (objfile::objfile): Update.
8178         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8179         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8180         comment.
8181         (minimal_symbol_reader::install): Update.
8182         (terminate_minimal_symbol_table): Remove.
8183         * jit.c (jit_object_close_impl): Update.
8184
8185 2019-03-15  Tom Tromey  <tom@tromey.com>
8186
8187         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8188         initializations.
8189
8190 2019-03-15  Tom Tromey  <tom@tromey.com>
8191
8192         * objfiles.h (struct objfile_per_bfd_storage)
8193         <demangled_hash_languages>: Now a bitset.
8194         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8195         (lookup_minimal_symbol): Update.
8196
8197 2019-03-15  Tom Tromey  <tom@tromey.com>
8198
8199         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8200         Don't return the symbol.
8201         * coffread.c (record_minimal_symbol): Use record_full.
8202
8203 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8204
8205         The MS-Windows port of ncurses fails to switch to a color pair if
8206         one or both of the colors are the implicit default colors.  This
8207         change records the default colors when TUI is initialized, and
8208         then specifies them explicitly when a color pair uses the default
8209         colors.  This allows color styling in TUI mode on MS-Windows.
8210
8211         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8212         ncurses_norm_attr.
8213         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8214         colors in ncurses_norm_attr.
8215         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8216         "none", replace it with the default color recorded in
8217         ncurses_norm_attr.
8218
8219 2019-03-14  Tom Tromey  <tromey@adacore.com>
8220
8221         * source-cache.h (class source_cache) <get_source_lines>: Return
8222         std::string.
8223         * source-cache.c (source_cache::extract_lines): Handle case where
8224         first_pos==npos.  Return std::string.
8225         (source_cache::get_source_lines): Update.
8226
8227 2019-03-14  Tom Tromey  <tromey@adacore.com>
8228
8229         * NEWS: Add item for "style sources" commands.
8230         * source-cache.c (source_cache::get_source_lines): Check
8231         source_styling.
8232         * cli/cli-style.c (source_styling): New global.
8233         (_initialize_cli_style): Add "style sources" commands.
8234         (show_style_sources): New function.
8235         * cli/cli-style.h (source_styling): Declare.
8236
8237 2019-03-14  Pedro Alves  <palves@redhat.com>
8238             Tom Tromey  <tromey@adacore.com>
8239
8240         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8241         * tui/tui-winsource.c (tui_refill_source_window): New function,
8242         from...
8243         (tui_horizontal_source_scroll): ... here.  Move some logic.
8244         * cli/cli-style.c (set_style_enabled): Notify new observable.
8245         * tui/tui-hooks.c (tui_redisplay_source): New function.
8246         (tui_attach_detach_observers): Attach or detach
8247         tui_redisplay_source.
8248         * observable.h (source_styling_changed): New observable.
8249         * observable.c: Define source_styling_changed observable.
8250
8251 2019-03-13  Tom Tromey  <tromey@adacore.com>
8252
8253         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8254         (i386_gnu_nat_target::store_registers): Update.
8255         * target-debug.h (target_debug_print_std_string): New macro.
8256         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8257         * windows-tdep.c (display_one_tib): Update.
8258         * tui/tui-stack.c (tui_make_status_line): Update.
8259         * top.c (print_inferior_quit_action): Update.
8260         * thread.c (thr_try_catch_cmd): Update.
8261         (add_thread_with_info): Update.
8262         (thread_target_id_str): Update.
8263         (thr_try_catch_cmd): Update.
8264         (thread_command): Update.
8265         (thread_find_command): Update.
8266         * record-btrace.c (record_btrace_target::info_record)
8267         (record_btrace_resume_thread, record_btrace_target::resume)
8268         (record_btrace_cancel_resume, record_btrace_step_thread)
8269         (record_btrace_target::wait, record_btrace_target::wait)
8270         (record_btrace_target::wait, record_btrace_target::stop): Update.
8271         * progspace.c (print_program_space): Update.
8272         * process-stratum-target.c
8273         (process_stratum_target::thread_address_space): Update.
8274         * linux-fork.c (linux_fork_mourn_inferior)
8275         (detach_checkpoint_command, info_checkpoints_command)
8276         (linux_fork_context): Update.
8277         (linux_fork_detach): Update.
8278         (class scoped_switch_fork_info): Update.
8279         (delete_checkpoint_command): Update.
8280         * infrun.c (follow_fork_inferior): Update.
8281         (follow_fork_inferior): Update.
8282         (proceed_after_vfork_done): Update.
8283         (handle_vfork_child_exec_or_exit): Update.
8284         (follow_exec): Update.
8285         (displaced_step_prepare_throw): Update.
8286         (displaced_step_restore): Update.
8287         (start_step_over): Update.
8288         (resume_1): Update.
8289         (clear_proceed_status_thread): Update.
8290         (proceed): Update.
8291         (print_target_wait_results): Update.
8292         (do_target_wait): Update.
8293         (context_switch): Update.
8294         (stop_all_threads): Update.
8295         (restart_threads): Update.
8296         (finish_step_over): Update.
8297         (handle_signal_stop): Update.
8298         (switch_back_to_stepped_thread): Update.
8299         (keep_going_pass_signal): Update.
8300         (print_exited_reason): Update.
8301         (normal_stop): Update.
8302         * inferior.c (inferior_pid_to_str): Change return type.
8303         (print_selected_inferior): Update.
8304         (add_inferior): Update.
8305         (detach_inferior): Update.
8306         * dummy-frame.c (fprint_dummy_frames): Update.
8307         * dcache.c (dcache_info_1): Update.
8308         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8309         (btrace_fetch, btrace_clear): Update.
8310         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8311         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8312         type.
8313         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8314         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8315         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8316         * gdbarch.c, gdbarch.h: Rebuild.
8317         * gdbarch.sh (core_pid_to_str): Change return type.
8318         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8319         return type.
8320         (windows_nat_target::pid_to_str): Change return type.
8321         (windows_delete_thread): Update.
8322         (windows_nat_target::attach): Update.
8323         (windows_nat_target::files_info): Update.
8324         * target-delegates.c: Rebuild.
8325         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8326         return type.
8327         (sol_thread_target::pid_to_str): Change return type.
8328         * remote.c (class remote_target) <pid_to_str>: Change return
8329         type.
8330         (remote_target::pid_to_str): Change return type.
8331         (extended_remote_target::attach, remote_target::remote_stop_ns)
8332         (remote_target::remote_notif_remove_queued_reply)
8333         (remote_target::push_stop_reply, remote_target::disable_btrace):
8334         Update.
8335         (extended_remote_target::attach): Update.
8336         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8337         type.
8338         (gdbsim_target::pid_to_str): Change return type.
8339         * ravenscar-thread.c (struct ravenscar_thread_target)
8340         <pid_to_str>: Change return type.
8341         (ravenscar_thread_target::pid_to_str): Change return type.
8342         * procfs.c (class procfs_target) <pid_to_str>: Change return
8343         type.
8344         (procfs_target::pid_to_str): Change return type.
8345         (procfs_target::attach): Update.
8346         (procfs_target::detach): Update.
8347         (procfs_target::fetch_registers): Update.
8348         (procfs_target::store_registers): Update.
8349         (procfs_target::wait): Update.
8350         (procfs_target::files_info): Update.
8351         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8352         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8353         return type.
8354         (nto_procfs_target::pid_to_str): Change return type.
8355         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8356         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8357         return type.
8358         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8359         (exit_lwp): Update.
8360         (attach_proc_task_lwp_callback, get_detach_signal)
8361         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8362         (linux_nat_target::resume, wait_lwp, stop_callback)
8363         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8364         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8365         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8366         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8367         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8368         type.
8369         (inf_ptrace_target::attach): Update.
8370         (inf_ptrace_target::files_info): Update.
8371         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8372         type.
8373         (go32_nat_target::pid_to_str): Change return type.
8374         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8375         (gnu_nat_target::wait): Update.
8376         (gnu_nat_target::wait): Update.
8377         (gnu_nat_target::resume): Update.
8378         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8379         (fbsd_nat_target::wait): Update.
8380         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8381         type.
8382         (darwin_nat_target::attach): Update.
8383         * corelow.c (class core_target) <pid_to_str>: Change return type.
8384         (core_target::pid_to_str): Change return type.
8385         * target.c (normal_pid_to_str): Change return type.
8386         (default_pid_to_str): Likewise.
8387         (target_pid_to_str): Change return type.
8388         (target_translate_tls_address): Update.
8389         (target_announce_detach): Update.
8390         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8391         return type.
8392         (bsd_uthread_target::pid_to_str): Change return type.
8393         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8394         type.
8395         (bsd_kvm_target::pid_to_str): Change return type.
8396         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8397         return type.
8398         (aix_thread_target::pid_to_str): Change return type.
8399         * target.h (struct target_ops) <pid_to_str>: Change return type.
8400         (target_pid_to_str, normal_pid_to_str): Likewise.
8401         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8402         type.
8403         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8404         type.
8405         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8406         return type.
8407         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8408         type.
8409         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8410         type.
8411         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8412         return type.
8413
8414 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8415
8416         * NEWS: Mention that the new default MI version is 3.  Mention
8417         changes to the output of commands and events that deal with
8418         multi-location breakpoints.
8419         * breakpoint.c: Include "mi/mi-out.h".
8420         (print_one_breakpoint): Change output syntax if using MI version
8421         >= 3.
8422         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8423         New.
8424         (mi_multi_location_breakpoint_output_fixed): New.
8425         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8426         (mi_cmd_fix_multi_location_breakpoint_output): New.
8427         (mi_multi_location_breakpoint_output_fixed): New.
8428         * mi/mi-cmds.c (mi_cmds): Register command
8429         -fix-multi-location-breakpoint-output.
8430         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8431         interpreter "mi".
8432
8433 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8434
8435         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8436         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8437         instantiate mi_ui_out based on interpreter name.
8438         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8439         * mi/mi-main.c (mi_load_progress): Likewise.
8440
8441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8442
8443         * NEWS: Combine separate "New targets" sections for 8.3.
8444
8445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8446
8447         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8448         (ppcfbsd_init_abi): Install gdbarch
8449         "fetch_tls_load_module_address" and "get_thread_local_address"
8450         methods.
8451
8452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8453
8454         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8455         (riscv_fbsd_init_abi): Install gdbarch
8456         "fetch_tls_load_module_address" and "get_thread_local_address"
8457         methods.
8458
8459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8460
8461         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8462         (i386fbsd_init_abi): Install gdbarch
8463         "fetch_tls_load_module_address" and "get_thread_local_address"
8464         methods.
8465
8466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8467
8468         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8469         (amd64fbsd_init_abi): Install gdbarch
8470         "fetch_tls_load_module_address" and "get_thread_local_address"
8471         methods.
8472
8473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8474
8475         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8476         (struct fbsd_pspace_data): New type.
8477         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8478         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8479         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8480         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8481         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8482
8483 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8484
8485         * gdbtypes.c (lookup_struct_elt): New function.
8486         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8487         * gdbtypes.h (struct struct_elt): New type.
8488         (lookup_struct_elt): New prototype.
8489
8490 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8491
8492         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8493         remove disabled code block.
8494
8495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8496
8497         * gdbarch.sh (get_thread_local_address): New method.
8498         * gdbarch.h, gdbarch.c: Regenerate.
8499         * target.c (target_translate_tls_address): Use
8500         gdbarch_get_thread_local_address if present instead of
8501         target::get_thread_local_address.
8502
8503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8504
8505         * target.h (target::get_thread_local_address): Update comment.
8506
8507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8508
8509         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8510         objfile->separate_debug_objfile_backlink if not NULL.
8511
8512 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8513
8514         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8515         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8516         (amd64bsd_store_inferior_registers): Likewise.
8517         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8518         Enable segment base registers.
8519         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8520         PT_GETFSBASE and PT_GETGSBASE.
8521         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8522         PT_SETGSBASE.
8523         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8524         segment base registers.
8525         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8526
8527 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8528
8529         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8530         Update calls to i386_target_description to add 'segments'
8531         parameter.
8532         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8533         add segment base registers.
8534         * arch/i386.c (i386_create_target_description): Add 'segments'
8535         parameter to enable segment base registers.
8536         * arch/i386.h (i386_create_target_description): Likewise.
8537         * features/i386/32bit-segments.xml: New file.
8538         * features/i386/32bit-segments.c: Generate.
8539         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8540         call to i386_target_description to add 'segments' parameter.
8541         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8542         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8543         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8544         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8545         if feature is present.
8546         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8547         Add 'segments' parameter to call to i386_target_description.
8548         (i386_target_description): Add 'segments' parameter to enable
8549         segment base registers.
8550         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8551         to call to i386_target_description.
8552         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8553         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8554         Define I386_NUM_REGS.
8555         (i386_target_description): Add 'segments' parameter to enable
8556         segment base registers.
8557
8558 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8559
8560         PR/24325
8561         * source-cache.c: #undef open and close, to avoid unresolved
8562         externals during linking.
8563
8564 2019-03-12  Tom Tromey  <tromey@adacore.com>
8565
8566         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8567         const.  Add initializers.
8568         (_initialize_remote): Don't initialize ptid globals.
8569
8570 2019-03-12  Pedro Alves  <palves@redhat.com>
8571
8572         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8573
8574 2019-03-12  Pedro Alves  <palves@redhat.com>
8575
8576         * cp-name-parser.y (main): Remove unused 'len' variable.
8577
8578 2019-03-12  Tom Tromey  <tromey@adacore.com>
8579
8580         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8581         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8582
8583 2019-03-12  Tom Tromey  <tromey@adacore.com>
8584
8585         * linux-nat.c (iterate_over_lwps): Update.
8586         (stop_callback): Remove parameter.
8587         (stop_wait_callback, detach_callback, resume_set_callback)
8588         (select_singlestep_lwp_callback, set_ignore_sigint)
8589         (status_callback, resumed_callback, resume_clear_callback)
8590         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8591         data parameter.
8592         (linux_nat_target::detach, linux_nat_target::resume)
8593         (linux_stop_and_wait_all_lwps, select_event_lwp)
8594         (linux_nat_filter_event, linux_nat_wait_1)
8595         (linux_nat_target::kill, linux_nat_target::stop)
8596         (linux_nat_target::stop): Update.
8597         (linux_nat_resume_callback): Change type.
8598         (resume_stopped_resumed_lwps, count_events_callback)
8599         (select_event_lwp_callback): Likewise.
8600         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8601         * arm-linux-nat.c (struct update_registers_data): Remove.
8602         (update_registers_callback): Change type.
8603         (arm_linux_insert_hw_breakpoint1): Update.
8604         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8605         parameter.
8606         (x86_linux_dr_set_addr): Update.
8607         (x86_linux_dr_set_control): Update.
8608         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8609         (iterate_over_lwps): Use gdb::function_view.
8610         * nat/aarch64-linux-hw-point.c (struct
8611         aarch64_dr_update_callback_param): Remove.
8612         (debug_reg_change_callback): Change type.
8613         (aarch64_notify_debug_reg_change): Update.
8614         * s390-linux-nat.c (s390_refresh_per_info): Update.
8615
8616 2019-03-11  Tom Tromey  <tromey@adacore.com>
8617
8618         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8619         redundant assignment to "this_cu".
8620
8621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8622
8623         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8624
8625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8626
8627         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8628         from...
8629         (rank_one_type): ... this.
8630
8631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8632
8633         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8634         from...
8635         (rank_one_type): ... this.
8636
8637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8638
8639         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8640         from...
8641         (rank_one_type): ... this.
8642
8643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8644
8645         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8646         from...
8647         (rank_one_type): ... this.
8648
8649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8650
8651         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8652         from...
8653         (rank_one_type): ... this.
8654
8655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8656
8657         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8658         from...
8659         (rank_one_type): ... this.
8660
8661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8662
8663         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8664         from...
8665         (rank_one_type): ... this.
8666
8667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8668
8669         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8670         from...
8671         (rank_one_type): ... this.
8672
8673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8674
8675         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8676         from...
8677         (rank_one_type): ... this.
8678
8679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8680
8681         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8682         from...
8683         (rank_one_type): ... this.
8684
8685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8686
8687         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8688         from...
8689         (rank_one_type): ... this.
8690
8691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8692
8693         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8694         from...
8695         (rank_one_type): ... this.
8696
8697 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8698
8699         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8700         inferior-events' shows the example events.
8701
8702 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8703
8704         Support styling on native MS-Windows console
8705
8706         PR/24315
8707         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8708         on MS-Windows if $TERM is not defined.
8709
8710         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8711
8712         * posix-hdep.c (gdb_console_fputs):
8713         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8714         functions.
8715         * ui-file.h (gdb_console_fputs): Add prototype.
8716
8717         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8718         back to fputs only if the former returns zero.
8719
8720 2019-03-07  Tom Tromey  <tom@tromey.com>
8721
8722         * symmisc.c (print_symbol_bcache_statistics): Update.
8723         (print_objfile_statistics): Update.
8724         * symfile.c (allocate_symtab): Update.
8725         * stabsread.c: Don't include bcache.h.
8726         * psymtab.h (struct psymbol_bcache): Don't declare.
8727         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8728         (psymbol_bcache_init, psymbol_bcache_free)
8729         (psymbol_bcache_get_bcache): Don't declare.
8730         * psymtab.c (struct psymbol_bcache): Remove.
8731         (psymtab_storage::psymtab_storage): Update.
8732         (psymtab_storage::~psymtab_storage): Update.
8733         (psymbol_bcache_init, psymbol_bcache_free)
8734         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8735         (add_psymbol_to_bcache): Update.
8736         (allocate_psymtab): Update.
8737         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8738         macro_cache>: No longer pointers.
8739         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8740         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8741         * macrotab.c (macro_bcache): Update.
8742         * macroexp.c: Don't include bcache.h.
8743         * gdbtypes.c (check_types_worklist): Update.
8744         (types_deeply_equal): Remove TRY/CATCH.  Update.
8745         * elfread.c (elf_symtab_read): Update.
8746         * dwarf2read.c: Don't include bcache.h.
8747         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8748         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8749         (print_bcache_statistics, bcache_memory_used): Don't declare.
8750         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8751         methods.  Rename all data members.
8752         * bcache.c (struct bcache): Move to bcache.h.
8753         (bcache::expand_hash_table): Rename from expand_hash_table.
8754         (bcache): Remove.
8755         (bcache::insert): Rename from bcache_full.
8756         (bcache::compare): Rename from bcache_compare.
8757         (bcache_xmalloc): Remove.
8758         (bcache::~bcache): Rename from bcache_xfree.
8759         (bcache::print_statistics): Rename from print_bcache_statistics.
8760         (bcache::memory_used): Rename from bcache_memory_used.
8761
8762 2019-03-07  Pedro Alves  <palves@redhat.com>
8763
8764         * infrun.c (normal_stop): Also check for
8765         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8766
8767 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8768
8769         * f-lang.c (value_from_host_double): Moved to...
8770         * value.c (value_from_host_double): ...here.
8771         * value.h (value_from_host_double): Declare.
8772         * guile/scm-math.c (vlscm_convert_typed_number): Use
8773         value_from_host_double.
8774         (vlscm_convert_number): Likewise.
8775         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8776         * python/py-value.c (convert_value_from_python): Likewise.
8777
8778 2019-03-06  Tom Tromey  <tom@tromey.com>
8779
8780         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8781
8782 2019-03-06  Tom Tromey  <tom@tromey.com>
8783
8784         * utils.h (free_current_contents): Don't declare.
8785         * utils.c (free_current_contents): Remove.
8786
8787 2019-03-06  Tom Tromey  <tom@tromey.com>
8788
8789         * top.c (quit_force): Update.
8790         * main.c (captured_command_loop): Update.
8791         * common/new-op.c (operator new): Update.
8792         * common/common-exceptions.c (struct catcher)
8793         <save_cleanup_chain>: Remove member.
8794         (exceptions_state_mc_init): Update.
8795         (exception_try_scope_entry): Return nullptr.
8796         (exception_try_scope_exit, exception_rethrow)
8797         (throw_exception_sjlj, throw_exception_cxx): Update.
8798         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8799         (all_cleanups, do_cleanups, discard_cleanups)
8800         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8801         (restore_cleanups, restore_final_cleanups): Don't declare.
8802         (do_final_cleanups): Remove parameter.
8803         * common/cleanups.c (cleanup_chain, make_cleanup)
8804         (make_cleanup_dtor, all_cleanups, do_cleanups)
8805         (discard_my_cleanups, discard_cleanups)
8806         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8807         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8808         (null_cleanup): Remove.
8809         (do_final_cleanups): Remove parameter.
8810
8811 2019-03-06  Tom Tromey  <tom@tromey.com>
8812
8813         * remote.c (remote_target::remote_parse_stop_reply): Use
8814         unique_xmalloc_ptr.
8815
8816 2019-03-06  Tom Tromey  <tom@tromey.com>
8817
8818         * stabsread.c (struct stabs_field_info): Rename from field_info.
8819         <list, fnlist>: Add initializers.
8820         <obstack>: New member.
8821         (read_member_functions, read_struct_fields, read_baseclasses):
8822         Allocate on obstack.  Don't use cleanups.
8823         (read_one_struct_field, read_member_functions, read_struct_fields)
8824         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8825         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8826         (read_struct_type): Update.
8827
8828 2019-03-06  Tom Tromey  <tom@tromey.com>
8829
8830         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8831         * common/filestuff.h (make_cleanup_close): Don't declare.
8832         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8833         Remove.
8834
8835 2019-03-06  Tom Tromey  <tom@tromey.com>
8836
8837         * solib-aix.c: Use make_scope_exit.
8838
8839 2019-03-06  Tom Tromey  <tom@tromey.com>
8840
8841         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8842         Use make_scope_exit.
8843
8844 2019-03-06  Tom Tromey  <tom@tromey.com>
8845
8846         * solib-svr4.c (disable_probes_interface): Remove parameter.
8847         (svr4_handle_solib_event): Use make_scope_exit.
8848
8849 2019-03-06  Tom Tromey  <tom@tromey.com>
8850
8851         * remote.c (struct stop_reply_deleter): Remove.
8852         (stop_reply_up): Update.
8853         (struct stop_reply): Derive from notif_event.  Don't typedef.
8854         <regcache>: Now a std::vector.
8855         (stop_reply_xfree): Remove.
8856         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8857         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8858         (remote_target::discard_pending_stop_replies): Use delete.
8859         (remote_target::remote_parse_stop_reply): Update.
8860         (remote_target::process_stop_reply): Update.
8861         * remote-notif.h (struct notif_event): Add virtual destructor.
8862         Remove "dtr" member.
8863         (struct notif_client) <alloc_event>: Return a unique_ptr.
8864         (notif_event_xfree): Don't declare.
8865         (notif_event_up): New typedef.
8866         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8867         (notif_event_xfree, do_notif_event_xfree): Remove.
8868         (remote_notif_state_xfree): Update.
8869
8870 2019-03-06  Tom Tromey  <tom@tromey.com>
8871
8872         * infrun.c (displaced_step_clear_cleanup): Now a
8873         forward_scope_exit type.
8874         (displaced_step_prepare_throw): Update.
8875         (displaced_step_fixup): Update.
8876
8877 2019-03-06  Tom Tromey  <tom@tromey.com>
8878
8879         * inferior.h (class inferior): Update comment.
8880         * gdbthread.h (class thread_info): Update comment.
8881
8882 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8883             Tom Tromey  <tom@tromey.com>
8884
8885         * stabsread.h (struct stab_section_list): Remove.
8886         (coffstab_build_psymtabs): Update.
8887         * dbxread.c (symbuf_sections): Now a std::vector.
8888         (sect_idx): New global.
8889         (fill_symbuf): Update.
8890         (coffstab_build_psymtabs): Change type of stabsects parameter.
8891         Update.
8892         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8893         std::vector.
8894         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8895         (coff_locate_sections): Update.
8896         (coff_symfile_read): Remove cleanups.  Update.
8897         (init_stringtab): Add storage parameter.
8898         (free_stringtab, free_stringtab_cleanup): Remove.
8899         (init_lineno): Add storage parameter.
8900         (free_linetab, free_linetab_cleanup): Remove.
8901
8902 2019-03-06  Pedro Alves  <palves@redhat.com>
8903
8904         * linux-fork.c (fork_info::clobber_regs): Delete.
8905         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8906         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8907         comment.  Adjust.
8908         (scoped_switch_fork_info::scoped_switch_fork_info)
8909         (checkpoint_command, linux_fork_context): Adjust
8910         fork_save_infrun_state calls.
8911
8912 2019-03-06  Pedro Alves  <palves@redhat.com>
8913
8914         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8915         (inf_has_multiple_threads): Return 'bool' and rewrite using
8916         inferior_info::threads().
8917
8918 2019-03-06  Pedro Alves  <palves@redhat.com>
8919
8920         * linux-fork.c: Include <list>.
8921         (fork_list): Now a std::list instance.
8922         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8923         (forks_exist_p, find_last_fork): Adjust.
8924         (new_fork): Delete.
8925         (one_fork_p): New.
8926         (add_fork): Adjust.
8927         (free_fork): Delete, folded into fork_info::~fork_info().
8928         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8929         Adjust.
8930         (init_fork_list): Delete.
8931         (linux_fork_killall, linux_fork_mourn_inferior)
8932         (linux_fork_detach, info_checkpoints_command): Adjust.
8933         (_initialize_linux_fork): No longer call init_fork_list.
8934
8935 2019-03-06  Pedro Alves  <palves@redhat.com>
8936
8937         * linux-fork.c (new_fork): New, split out of ...
8938         (add_fork): ... this.  Return void.  Move "first fork" special
8939         case from here, to ...
8940         (checkpoint_command): ... here.
8941         * linux-linux.h (add_fork): Return void.
8942
8943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8944
8945         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8946
8947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8948             Chris January  <chris.january@arm.com>
8949             David Lecomber  <david.lecomber@arm.com>
8950
8951         * f-exp.y: New token, UNOP_INTRINSIC.
8952         (exp): New pattern using UNOP_INTRINSIC token.
8953         (f77_keywords): Add 'abs' keyword.
8954         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8955         (value_from_host_double): New function.
8956         (evaluate_subexp_f): Support UNOP_ABS.
8957
8958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8959
8960         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8961         types.
8962
8963 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8964
8965         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8966         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8967         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8968
8969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8970
8971         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8972
8973 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8974             Chris January  <chris.january@arm.com>
8975
8976         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8977         * f-exp.y: Define 'KIND' token.
8978         (exp): New pattern for KIND expressions.
8979         (ptype): Handle types with a kind extension.
8980         (direct_abs_decl): Extend to spot kind extensions.
8981         (f77_keywords): Add 'kind' to the list.
8982         (push_kind_type): New function.
8983         (convert_to_kind_type): New function.
8984         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8985         * parse.c (operator_length_standard): Likewise.
8986         * parser-defs.h (enum type_pieces): Add tp_kind.
8987         * std-operator.def: Add UNOP_KIND.
8988
8989 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8990
8991         * f-exp.y (f_parse): Set yydebug.
8992
8993 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8994
8995         * f-lang.c (evaluate_subexp_f): New function.
8996         (exp_descriptor_f): New global.
8997         (f_language_defn): Use exp_descriptor_f instead of
8998         exp_descriptor_standard.
8999
9000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9001
9002         * f-exp.y (struct token): Add comments.
9003         (dot_ops): Remove uppercase versions and the end marker.
9004         (f77_keywords): Likewise.
9005         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9006         entries in the dot_ops array are case insensitive, and use
9007         strncasecmp to compare strings.  Also some whitespace cleanup in
9008         this area.  Similar for the f77_keywords array, except entries in
9009         this list might be case sensitive.
9010
9011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9012
9013         * f-exp.y (struct f77_boolean_val): Add comments.
9014         (boolean_values): Remove uppercase versions, and end marker.
9015         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9016         and use strncasecmp to achieve case insensitivity.  Additionally,
9017         perform whitespace cleanup around this code.
9018
9019 2019-03-06  Tom Tromey  <tromey@adacore.com>
9020
9021         * remote-sim.c (gdbsim_target_open): Use result of
9022         gdb_argv::release.
9023
9024 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9025         Dirk Schubert  <dirk.schubert@arm.com>
9026         Chris January  <chris.january@arm.com>
9027
9028         * eval.c (evaluate_subexp_standard): Call Fortran argument
9029         wrapping logic.
9030         * f-lang.c (struct value): A value which can be passed into a
9031         Fortran function call.
9032         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9033         where appropriate.
9034         (struct type): Value ready for a Fortran function call.
9035         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9036         is needed.
9037         * f-lang.h (fortran_argument_convert): Declaration.
9038         (fortran_preserve_arg_pointer): Declaration.
9039         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9040
9041 2019-03-05  Tom Tromey  <tromey@adacore.com>
9042
9043         * python/py-prettyprint.c (print_string_repr): Remove #if.
9044         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9045
9046 2019-03-05  Tom Tromey  <tromey@adacore.com>
9047
9048         * target.c (the_dummy_target): Move later.  Change type to
9049         "dummy_target".
9050         (initialize_targets): Don't initialize the_dummy_target.
9051
9052 2019-03-05  Tom Tromey  <tromey@adacore.com>
9053
9054         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9055         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9056
9057 2019-03-05  Tom Tromey  <tromey@adacore.com>
9058
9059         * windows-nat.c (windows_nat_target::attach)
9060         (windows_nat_target::detach): Don't call gdb_flush.
9061         * valprint.c (generic_val_print, val_print, val_print_string):
9062         Don't call gdb_flush.
9063         * utils.c (defaulted_query): Don't call gdb_flush.
9064         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9065         * target.c (target_announce_detach): Don't call gdb_flush.
9066         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9067         * remote.c (extended_remote_target::attach): Don't call
9068         gdb_flush.
9069         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9070         * printcmd.c (do_examine): Don't call gdb_flush.
9071         (info_display_command): Don't call gdb_flush.
9072         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9073         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9074         * memattr.c (info_mem_command): Don't call gdb_flush.
9075         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9076         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9077         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9078         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9079         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9080         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9081         (gnu_nat_target::detach): Don't call gdb_flush.
9082         * f-valprint.c (f_val_print): Don't call gdb_flush.
9083         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9084         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9085         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9086         gdb_flush.
9087         * c-valprint.c (c_val_print): Don't call gdb_flush.
9088         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9089
9090 2019-03-05  Tom Tromey  <tromey@adacore.com>
9091
9092         * varobj.c (update_dynamic_varobj_children): Update.
9093         (install_default_visualizer): Use reset, not release.
9094         * value.c (set_internalvar): Update.
9095         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9096         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9097         ATTRIBUTE_UNUSED_RESULT.
9098
9099 2019-03-05  Tom Tromey  <tromey@adacore.com>
9100
9101         * remote.c (class scoped_remote_fd) <release>: Add
9102         ATTRIBUTE_UNUSED_RESULT.
9103
9104 2019-03-05  Tom Tromey  <tromey@adacore.com>
9105
9106         * macroexp.c (struct macro_buffer) <release>: Add
9107         ATTRIBUTE_UNUSED_RESULT.
9108
9109 2019-03-05  Tom Tromey  <tromey@adacore.com>
9110
9111         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9112         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9113         ATTRIBUTE_UNUSED_RESULT.
9114
9115 2019-03-05  Tom Tromey  <tromey@adacore.com>
9116
9117         * common/scoped_fd.h (class scoped_fd) <release>: Add
9118         ATTRIBUTE_UNUSED_RESULT.
9119
9120 2019-03-05  Tom Tromey  <tromey@adacore.com>
9121
9122         * parser-defs.h (struct parser_state) <release>: Add
9123         ATTRIBUTE_UNUSED_RESULT.
9124
9125 2019-03-05  Tom Tromey  <tromey@adacore.com>
9126
9127         * utils.h (class gdb_argv) <release>: Add
9128         ATTRIBUTE_UNUSED_RESULT.
9129         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9130
9131 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9132
9133         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9134         for-loop range, to avoid compiler warnings.
9135
9136         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9137         avoid compiler warnings about unused variables.
9138
9139         * NEWS: Mention end of support for native debugging on MS-Windows
9140         before XP.
9141
9142         PR gdb/24292
9143         * common/netstuff.c:
9144         * gdbserver/gdbreplay.c
9145         * gdbserver/remote-utils.c:
9146         * ser-tcp.c:
9147         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9148         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9149         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9150         'getaddrinfo' and 'freeaddrinfo' were not available before
9151         Windows XP, and mingw.org's MinGW headers by default define
9152         _WIN32_WINNT to 0x500.
9153
9154 2019-03-01  Gary Benson <gbenson@redhat.com>
9155
9156         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9157
9158 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9159             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9160
9161         PR gdb/8527
9162         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9163         set_sigint_trap, clear_sigint_trap.
9164
9165 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9166
9167         * target.c (target_detach): Clear the regcache and the
9168         frame cache.
9169
9170 2019-02-27  Pedro Alves  <palves@redhat.com>
9171
9172         * utils.c (set_screen_size): When we cap the height/width sizes,
9173         tweak the corresponding command variable to show "unlimited":
9174
9175 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9176             Pedro Alves  <palves@redhat.com>
9177
9178         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9179         before calling rl_set_screen_size.
9180
9181 2019-02-27  Tom Tromey  <tromey@adacore.com>
9182
9183         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9184         define.
9185         * python/py-value.c: Remove Python 2.4 workaround.
9186         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9187         workaround.
9188         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9189         Python 2.4 workaround.
9190         * python/python-internal.h: Remove Python 2.4 comment.
9191         (Py_ssize_t): Don't define.
9192         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9193         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9194         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9195         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9196         * python/python.c (do_start_initialization): Remove Python 2.4
9197         workaround.
9198         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9199         (print_children): Remove Python 2.4 workaround.
9200         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9201         workaround.
9202         (CHARBUFFERPROC_NAME): Remove.
9203         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9204         Python 2.4 workaround.
9205
9206 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9207
9208         * NEWS: Note minimum Python version.
9209
9210 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9211
9212         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9213         code from these functions.  Remove corresponding ifdefs.  Use
9214         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9215         Remove gotos and target of gotos.
9216         (infpy_search_memory): Likewise.
9217
9218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9221         (hppa_gdbarch_init): Don't register deleted functions with
9222         gdbarch.
9223
9224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9227         (h8300_unwind_sp): Delete.
9228         (h8300_dummy_id): Delete.
9229         (h8300_gdbarch_init): Don't register deleted functions with
9230         gdbarch.
9231
9232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9233
9234         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9235         (ft32_unwind_pc): Delete.
9236         (ft32_unwind_sp): Delete.
9237         (ft32_gdbarch_init): Don't register deleted functions with
9238         gdbarch.
9239
9240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9241
9242         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9243         (frv_unwind_pc): Delete.
9244         (frv_unwind_sp): Delete.
9245         (frv_gdbarch_init): Don't register deleted functions with
9246         gdbarch.
9247
9248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9251         (riscv_unwind_pc): Delete.
9252         (riscv_unwind_sp): Delete.
9253         (riscv_gdbarch_init): Don't register deleted functions with
9254         gdbarch.
9255
9256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9257
9258         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9259         (csky_unwind_pc): Delete.
9260         (csky_unwind_sp): Delete.
9261         (csky_gdbarch_init): Don't register deleted functions with
9262         gdbarch.
9263
9264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9267         (cris_unwind_pc): Delete.
9268         (cris_unwind_sp): Delete.
9269         (cris_gdbarch_init): Don't register deleted functions with
9270         gdbarch.
9271
9272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9273
9274         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9275         (bfin_unwind_pc): Delete.
9276         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9277
9278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9281         (arm_unwind_pc): Delete.
9282         (arm_unwind_sp): Delete.
9283         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9284
9285 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9288         (arc_unwind_pc): Delete.
9289         (arc_unwind_sp): Delete.
9290         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9291
9292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9293
9294         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9295         (alpha_unwind_pc): Delete.
9296         (alpha_gdbarch_init): Don't register deleted functions with
9297         gdbarch.
9298
9299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9302         (aarch64_unwind_pc): Delete.
9303         (aarch64_unwind_sp): Delete.
9304         (aarch64_gdbarch_init): Don't register deleted functions with
9305         gdbarch.
9306
9307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * gdbtypes.c (type_align): Don't consider static members when
9310         computing structure alignment.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9315         return 0 for other types.
9316         * arch-utils.c (default_type_align): Always return 0.
9317         * gdbarch.h: Regenerate.
9318         * gdbarch.sh (type_align): Extend comment.
9319         * gdbtypes.c (type_align): Add additional comments, always call
9320         gdbarch_type_align before applying the default rules.
9321         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9322         generic code will then apply a suitable default.
9323         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9324         types, return 0 for other types.
9325
9326 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9327
9328         * NEWS: Create a new section for the next release branch.
9329         Rename the section of the current branch, now that it has
9330         been cut.
9331
9332 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9333
9334         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9335         * version.in: Bump version to 8.3.50.DATE-git.
9336
9337 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9338
9339         * aix-thread.c (ptid_cmp): Remove unused variable.
9340         (get_signaled_thread): Likewise.
9341         (store_regs_user_thread): Likewise.
9342         (store_regs_kernel_thread): Likewise.
9343         (fetch_regs_kernel_thread): Remove shadowed variable.
9344
9345 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9346
9347         * features/riscv/32bit-cpu.xml: Add register numbers.
9348         * features/riscv/32bit-fpu.c: Regenerate.
9349         * features/riscv/32bit-fpu.xml: Add register numbers.
9350         * features/riscv/64bit-cpu.xml: Add register numbers.
9351         * features/riscv/64bit-fpu.c: Regenerate.
9352         * features/riscv/64bit-fpu.xml: Add register numbers.
9353
9354 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9355
9356         * NEWS: Mention two argument form of gdb.Value constructor.
9357         * python/py-value.c (convert_buffer_and_type_to_value): New
9358         function.
9359         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9360         Add support for handling an optional second argument.  Call
9361         convert_buffer_and_type_to_value as appropriate.
9362         * python/python-internal.h (Py_buffer_deleter): New struct.
9363         (Py_buffer_up): New typedef.
9364
9365 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9366
9367         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9368         instead of releasing ownership.
9369
9370 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9371
9372         * dwarf2read.c (open_and_init_dwp_file): Call
9373         elf_numsections instead of bfd_count_sections to initialize
9374         dwp_file->num_sections.
9375
9376 2019-02-25  Tom Tromey  <tromey@adacore.com>
9377
9378         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9379
9380 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9381
9382         * gcore.in: Add '--readnever' option when invoking GDB.
9383
9384 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9385
9386         * MAINTAINERS: Update my email address.
9387
9388 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9389
9390         * build-id.c (build_id_to_debug_bfd_1): New function.
9391         (build_id_to_debug_bfd): Look for separate debug file in
9392         sysroot.
9393
9394 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * gdbarch.sh: Update the copyright year range that is placed into
9397         generated files.
9398
9399 2019-02-22  Keith Seitz  <keiths@redhat.com>
9400
9401         PR symtab/23853
9402         * linespec.c (create_sals_line_offset): Search for the default
9403         symtab's filename instead of its fullname.
9404
9405 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9406
9407         * NEWS: Update style defaults.
9408
9409 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9410
9411         * main.c (captured_main_1): Disable styling in batch mode.
9412
9413 2019-02-20  Tom Tromey  <tom@tromey.com>
9414
9415         * symtab.c (symtab_symbol_info): Fix typos.
9416
9417 2019-02-20  Tom Tromey  <tromey@adacore.com>
9418
9419         * findcmd.c (_initialize_mem_search): Use upper case for
9420         metasyntactic variables.
9421
9422 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9423
9424         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9425         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9426
9427 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9428
9429         * top.h (source_file_name): Change to std::string.
9430         * top.c (source_file_name): Likewise.
9431         (command_line_input): Adjust.
9432         * cli/cli-script.c (script_from_file): Adjust.
9433
9434 2019-02-19  Tom Tromey  <tromey@adacore.com>
9435
9436         * ravenscar-thread.c
9437         (ravenscar_thread_target::update_thread_list): Don't call
9438         ada_build_task_list.
9439         * ada-lang.h (ada_build_task_list): Don't declare.
9440         * ada-tasks.c (struct ada_tasks_inferior_data)
9441         <task_list_valid_p>: Now bool.
9442         (read_known_tasks, ada_task_list_changed)
9443         (ada_tasks_invalidate_inferior_data): Update.
9444         (read_known_tasks_array): Return bool.
9445         (read_known_tasks_list): Likewise.
9446         (read_known_tasks): Return void.
9447         (ada_build_task_list): Now static.
9448
9449 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9450
9451         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9452         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9453
9454 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9455
9456         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9457         variant for ada_tasks_pspace_data_handle and
9458         ada_tasks_inferior_data_handle.
9459         (ada_tasks_pspace_data_cleanup): New function.
9460         (ada_tasks_inferior_data_cleanup): New function.
9461
9462 2019-02-17  Tom Tromey  <tom@tromey.com>
9463
9464         * macrotab.h (macro_source_fullname): Return a std::string.
9465         * macrotab.c (macro_include, check_for_redefinition)
9466         (macro_undef, macro_lookup_definition, foreach_macro)
9467         (foreach_macro_in_scope): Update.
9468         (macro_source_fullname): Return a std::string.
9469         * macrocmd.c (show_pp_source_pos): Update.
9470
9471 2019-02-17  Tom Tromey  <tom@tromey.com>
9472
9473         * macrocmd.c (show_pp_source_pos): Style the file names.
9474
9475 2019-02-17  Tom Tromey  <tom@tromey.com>
9476
9477         PR tui/24197:
9478         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9479
9480 2019-02-17  Tom Tromey  <tom@tromey.com>
9481
9482         * ada-lang.c (user_select_syms): Use filtered printing.
9483         * utils.c (wrap_style): New global.
9484         (desired_style): Remove.
9485         (emit_style_escape): Add stream parameter.
9486         (set_output_style, reset_terminal_style, prompt_for_continue):
9487         Update.
9488         (flush_wrap_buffer): Only flush gdb_stdout.
9489         (wrap_here): Set wrap_style.
9490         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9491         treat escape sequences as a character.  Change when wrap buffer is
9492         flushed.
9493         (fputs_styled): Do not set the output style when the default is
9494         requested.
9495         * ui-style.h (struct ui_file_style) <is_default>: New method.
9496         * source.c (print_source_lines_base): Emit escape sequences in one
9497         piece.
9498
9499 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9500
9501         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9502         integers and enumeration types.
9503
9504 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9505
9506         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9507         instead of lookup_symbol_in_language
9508         (do_exact_match): New function.
9509         (ada_get_symbol_name_matcher): Return do_exact_match when
9510         doing a verbatim match.
9511
9512 2019-02-15  Tom Tromey  <tromey@adacore.com>
9513
9514         * ravenscar-thread.c (ravenscar_thread_target::resume)
9515         (ravenscar_thread_target::wait): Special case wildcard requests.
9516
9517 2019-02-15  Tom Tromey  <tromey@adacore.com>
9518
9519         * ravenscar-thread.c (base_ptid): Remove.
9520         (struct ravenscar_thread_target) <close>: New method.
9521         <m_base_ptid>: New member.
9522         <update_inferior_ptid, active_task, task_is_currently_active,
9523         runtime_initialized>: Declare methods.
9524         <ravenscar_thread_target>: Add constructor.
9525         (ravenscar_thread_target::task_is_currently_active)
9526         (ravenscar_thread_target::update_inferior_ptid)
9527         (ravenscar_runtime_initialized): Rename.  Now methods.
9528         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9529         (ravenscar_thread_target::update_thread_list): Update.
9530         (ravenscar_thread_target::active_task): Now method.
9531         (ravenscar_thread_target::store_registers)
9532         (ravenscar_thread_target::prepare_to_store)
9533         (ravenscar_thread_target::prepare_to_store)
9534         (ravenscar_thread_target::mourn_inferior): Update.
9535         (ravenscar_inferior_created): Use "new" to create target.
9536         (ravenscar_thread_target::get_ada_task_ptid): Update.
9537         (_initialize_ravenscar): Don't initialize base_ptid.
9538         (ravenscar_ops): Remove global.
9539
9540 2019-02-15  Tom Tromey  <tromey@adacore.com>
9541
9542         * target.h (push_target): Declare new overload.
9543         * target.c (push_target): New overload, taking an rvalue reference.
9544         * remote.c (remote_target::open_1): Use push_target overload.
9545         * corelow.c (core_target_open): Use push_target overload.
9546
9547 2019-02-15  Tom Tromey  <tromey@adacore.com>
9548
9549         * ravenscar-thread.c (is_ravenscar_task)
9550         (ravenscar_task_is_currently_active): Return bool.
9551         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9552         (_initialize_ravenscar): Remove "(void)".
9553         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9554         Return bool.
9555
9556 2019-02-15  Tom Tromey  <tromey@adacore.com>
9557
9558         * ravenscar-thread.c (ravenscar_runtime_initializer)
9559         (has_ravenscar_runtime, get_running_thread_id)
9560         (ravenscar_thread_target::resume): Fix indentation.
9561
9562 2019-02-15  Tom Tromey  <tromey@adacore.com>
9563
9564         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9565         from ravenscar_arch_ops.
9566         (sparc_ravenscar_ops::fetch_registers)
9567         (sparc_ravenscar_ops::store_registers): Now methods.
9568         (sparc_ravenscar_prepare_to_store): Remove.
9569         (sparc_ravenscar_ops): Redefine.
9570         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9571         methods and destructor.  Remove members.
9572         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9573         (ravenscar_thread_target::store_registers)
9574         (ravenscar_thread_target::prepare_to_store): Update.
9575         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9576         Remove.
9577         (struct ppc_ravenscar_powerpc_ops): Derive from
9578         ravenscar_arch_ops.
9579         (ppc_ravenscar_powerpc_ops::fetch_registers)
9580         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9581         (ppc_ravenscar_powerpc_ops): Redefine.
9582         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9583         (ppc_ravenscar_e500_ops::fetch_registers)
9584         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9585         (ppc_ravenscar_e500_ops): Redefine.
9586         * aarch64-ravenscar-thread.c
9587         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9588         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9589         (aarch64_ravenscar_fetch_registers)
9590         (aarch64_ravenscar_store_registers): Now methods.
9591         (aarch64_ravenscar_ops): Redefine.
9592
9593 2019-02-15  Tom Tromey  <tromey@adacore.com>
9594
9595         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9596         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9597         (ravenscar_thread_target::stopped_by_watchpoint)
9598         (ravenscar_thread_target::stopped_data_address)
9599         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9600
9601 2019-02-15  Tom Tromey  <tromey@adacore.com>
9602
9603         * ravenscar-thread.c: Fix some typos.
9604
9605 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9606             Tom Tromey  <tromey@adacore.com>
9607
9608         * ada-lang.c (ada_exception_sal): Change addr_string to a
9609         std::string.
9610         (create_ada_exception_catchpoint): Update.
9611
9612 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9613             Tom Tromey  <tromey@adacore.com>
9614
9615         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9616         (bp_location_ops): Remove.
9617         (base_breakpoint_allocate_location): Update.
9618         (free_bp_location): Update.
9619         * ada-lang.c (class ada_catchpoint_location)
9620         <ada_catchpoint_location>: Remove ops parameter.
9621         (ada_catchpoint_location_dtor): Remove.
9622         (ada_catchpoint_location_ops): Remove.
9623         (allocate_location_exception): Update.
9624         * breakpoint.h (struct bp_location_ops): Remove.
9625         (class bp_location) <bp_location>: Remove bp_location_ops
9626         parameter.
9627         <~bp_location>: Add destructor.
9628         <ops>: Remove.
9629
9630 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9631             Pedro Alves  <palves@redhat.com>
9632
9633         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9634         'PATH_MAX'.
9635
9636 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9637             Samuel Thibault  <samuel.thibault@gnu.org>
9638             Thomas Schwinge  <thomas@codesourcery.com>
9639
9640         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9641         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9642
9643 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9644
9645         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9646         (check_empty): Use "const char *".
9647
9648         * gnu-nat.c (gnu_nat_target::detach): Instead of
9649         'detach_inferior (pid)' call
9650         'detach_inferior (find_inferior_pid (pid))'.
9651
9652         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9653         'nat/fork-inferior.o'.
9654         * gnu-nat.c: #include "nat/fork-inferior.h".
9655
9656         * gnu-nat.c (gnu_nat_target::detach): Instead of
9657         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9658         * gnu-nat.h: #include "inf-child.h".
9659         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9660         'i386_gnu_nat_target::fetch_registers'.
9661         (gnu_store_registers): Rename/move to
9662         'i386_gnu_nat_target::store_registers'.
9663
9664         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9665         * gnu-nat.h (mach_thread_info): New function.
9666         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9667
9668         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9669
9670 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9671
9672         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9673
9674 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9675
9676         * windows-nat.c (windows_add_thread): Add new parameter
9677         "main_thread_p" with default value set to false.  Update
9678         function documentation as well as all callers.
9679         (windows_delete_thread): Likewise.
9680         (fake_create_process): Update call to windows_add_thread.
9681         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9682         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9683         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9684         call to windows_delete_thread.
9685
9686 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9687
9688         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9689
9690 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9691
9692         * symfile.c (find_separate_debug_file): Use canonical path of
9693         sysroot with child_path instead of gdb_sysroot if it is valid.
9694
9695 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9696
9697         * symfile.c (find_separate_debug_file): Use child_path to
9698         determine if an object file is under a sysroot.
9699
9700 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9701
9702         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9703         unittests/child-path-selftests.c.
9704         * common/pathstuff.c (child_path): New function.
9705         * common/pathstuff.h (child_path): New prototype.
9706         * unittests/child-path-selftests.c: New file.
9707
9708 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9709
9710         * symfile.c (find_separate_debug_file): Look for separate debug
9711         files in debug directories under the sysroot.
9712
9713 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9714
9715         * symtab.h (struct minimal_symbol data_p): New const method.
9716         (struct minimal_symbol text_p): Likewise.
9717         * symtab.c (output_source_filename): Use file name style
9718         to print file name.
9719         (print_symbol_info): Likewise.
9720         (print_msymbol_info): Use address style to print addresses.
9721         Use function name style to print executable text symbols.
9722         (expand_symtab_containing_pc): Use data_p.
9723         (find_pc_sect_compunit_symtab): Likewise.
9724
9725 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9726
9727         * breakpoint.c (describe_other_breakpoints): Use address style
9728         to print addresses.
9729         (say_where): Likewise.
9730
9731 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9732
9733         * ada-typeprint.c (print_func_type): Print function name
9734         style to print function name.
9735         * c-typeprint.c (c_print_type_1): Likewise.
9736
9737 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9738
9739         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9740         for execve.
9741
9742 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9743
9744         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9745         type_stack.
9746
9747 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9748
9749         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9750         TYPE_CODE_REF types.
9751
9752 2019-02-08  Jim Wilson  <jimw@sifive.com>
9753
9754         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9755         (riscv_linux_fregset): New.
9756         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9757
9758 2019-02-07  Tom Tromey  <tom@tromey.com>
9759
9760         * thread.c (thread_cancel_execution_command): Update.
9761         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9762         methods.
9763         (struct thread_fsm_ops): Remove.
9764         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9765         (thread_fsm_should_stop, thread_fsm_return_value)
9766         (thread_fsm_set_finished, thread_fsm_finished_p)
9767         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9768         Don't declare.
9769         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9770         * infrun.c (clear_proceed_status_thread)
9771         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9772         (print_stop_event): Update.
9773         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9774         Add constructor.
9775         (step_command_fsm_ops): Remove.
9776         (new_step_command_fsm): Remove.
9777         (step_1): Update.
9778         (step_command_fsm::should_stop): Rename from
9779         step_command_fsm_should_stop.
9780         (step_command_fsm::clean_up): Rename from
9781         step_command_fsm_clean_up.
9782         (step_command_fsm::do_async_reply_reason): Rename from
9783         step_command_fsm_async_reply_reason.
9784         (struct until_next_fsm): Inherit from thread_fsm.  Add
9785         constructor.
9786         (until_next_fsm_ops): Remove.
9787         (new_until_next_fsm): Remove.
9788         (until_next_fsm::should_stop): Rename from
9789         until_next_fsm_should_stop.
9790         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9791         (until_next_fsm::do_async_reply_reason): Rename from
9792         until_next_fsm_async_reply_reason.
9793         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9794         constructor.  Change type of breakpoint.
9795         (finish_command_fsm_ops): Remove.
9796         (new_finish_command_fsm): Remove.
9797         (finish_command_fsm::should_stop): Rename from
9798         finish_command_fsm_should_stop.
9799         (finish_command_fsm::clean_up): Rename from
9800         finish_command_fsm_clean_up.
9801         (finish_command_fsm::return_value): Rename from
9802         finish_command_fsm_return_value.
9803         (finish_command_fsm::do_async_reply_reason): Rename from
9804         finish_command_fsm_async_reply_reason.
9805         (finish_command): Update.
9806         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9807         Add constructor.
9808         (call_thread_fsm_ops): Remove.
9809         (call_thread_fsm::call_thread_fsm): Rename from
9810         new_call_thread_fsm.
9811         (call_thread_fsm::should_stop): Rename from
9812         call_thread_fsm_should_stop.
9813         (call_thread_fsm::should_notify_stop): Rename from
9814         call_thread_fsm_should_notify_stop.
9815         (run_inferior_call, call_function_by_hand_dummy): Update.
9816         * cli/cli-interp.c (should_print_stop_to_console): Update.
9817         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9818         Add constructor.  Change type of location_breakpoint,
9819         caller_breakpoint.
9820         (until_break_fsm_ops): Remove.
9821         (new_until_break_fsm): Remove.
9822         (until_break_fsm::should_stop): Rename from
9823         until_break_fsm_should_stop.
9824         (until_break_fsm::clean_up): Rename from
9825         until_break_fsm_clean_up.
9826         (until_break_fsm::do_async_reply_reason): Rename from
9827         until_break_fsm_async_reply_reason.
9828         (until_break_command): Update.
9829         * thread-fsm.c: Remove.
9830         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9831
9832 2019-02-07  Tom Tromey  <tom@tromey.com>
9833
9834         * yy-remap.h: Add include guard.
9835         * xtensa-tdep.h: Add include guard.
9836         * xcoffread.h: Rename include guard.
9837         * varobj-iter.h: Add include guard.
9838         * tui/tui.h: Rename include guard.
9839         * tui/tui-winsource.h: Rename include guard.
9840         * tui/tui-wingeneral.h: Rename include guard.
9841         * tui/tui-windata.h: Rename include guard.
9842         * tui/tui-win.h: Rename include guard.
9843         * tui/tui-stack.h: Rename include guard.
9844         * tui/tui-source.h: Rename include guard.
9845         * tui/tui-regs.h: Rename include guard.
9846         * tui/tui-out.h: Rename include guard.
9847         * tui/tui-layout.h: Rename include guard.
9848         * tui/tui-io.h: Rename include guard.
9849         * tui/tui-hooks.h: Rename include guard.
9850         * tui/tui-file.h: Rename include guard.
9851         * tui/tui-disasm.h: Rename include guard.
9852         * tui/tui-data.h: Rename include guard.
9853         * tui/tui-command.h: Rename include guard.
9854         * tic6x-tdep.h: Add include guard.
9855         * target/waitstatus.h: Rename include guard.
9856         * target/wait.h: Rename include guard.
9857         * target/target.h: Rename include guard.
9858         * target/resume.h: Rename include guard.
9859         * target-float.h: Rename include guard.
9860         * stabsread.h: Add include guard.
9861         * rs6000-tdep.h: Add include guard.
9862         * riscv-fbsd-tdep.h: Add include guard.
9863         * regformats/regdef.h: Rename include guard.
9864         * record.h: Rename include guard.
9865         * python/python.h: Rename include guard.
9866         * python/python-internal.h: Rename include guard.
9867         * python/py-stopevent.h: Rename include guard.
9868         * python/py-ref.h: Rename include guard.
9869         * python/py-record.h: Rename include guard.
9870         * python/py-record-full.h: Rename include guard.
9871         * python/py-record-btrace.h: Rename include guard.
9872         * python/py-instruction.h: Rename include guard.
9873         * python/py-events.h: Rename include guard.
9874         * python/py-event.h: Rename include guard.
9875         * procfs.h: Add include guard.
9876         * proc-utils.h: Add include guard.
9877         * p-lang.h: Add include guard.
9878         * or1k-tdep.h: Rename include guard.
9879         * observable.h: Rename include guard.
9880         * nto-tdep.h: Rename include guard.
9881         * nat/x86-linux.h: Rename include guard.
9882         * nat/x86-linux-dregs.h: Rename include guard.
9883         * nat/x86-gcc-cpuid.h: Add include guard.
9884         * nat/x86-dregs.h: Rename include guard.
9885         * nat/x86-cpuid.h: Rename include guard.
9886         * nat/ppc-linux.h: Rename include guard.
9887         * nat/mips-linux-watch.h: Rename include guard.
9888         * nat/linux-waitpid.h: Rename include guard.
9889         * nat/linux-ptrace.h: Rename include guard.
9890         * nat/linux-procfs.h: Rename include guard.
9891         * nat/linux-osdata.h: Rename include guard.
9892         * nat/linux-nat.h: Rename include guard.
9893         * nat/linux-namespaces.h: Rename include guard.
9894         * nat/linux-btrace.h: Rename include guard.
9895         * nat/glibc_thread_db.h: Rename include guard.
9896         * nat/gdb_thread_db.h: Rename include guard.
9897         * nat/gdb_ptrace.h: Rename include guard.
9898         * nat/fork-inferior.h: Rename include guard.
9899         * nat/amd64-linux-siginfo.h: Rename include guard.
9900         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9901         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9902         * nat/aarch64-linux.h: Rename include guard.
9903         * nat/aarch64-linux-hw-point.h: Rename include guard.
9904         * mn10300-tdep.h: Add include guard.
9905         * mips-linux-tdep.h: Add include guard.
9906         * mi/mi-parse.h: Rename include guard.
9907         * mi/mi-out.h: Rename include guard.
9908         * mi/mi-main.h: Rename include guard.
9909         * mi/mi-interp.h: Rename include guard.
9910         * mi/mi-getopt.h: Rename include guard.
9911         * mi/mi-console.h: Rename include guard.
9912         * mi/mi-common.h: Rename include guard.
9913         * mi/mi-cmds.h: Rename include guard.
9914         * mi/mi-cmd-break.h: Rename include guard.
9915         * m2-lang.h: Add include guard.
9916         * location.h: Rename include guard.
9917         * linux-record.h: Rename include guard.
9918         * linux-nat.h: Add include guard.
9919         * linux-fork.h: Add include guard.
9920         * i386-darwin-tdep.h: Rename include guard.
9921         * hppa-linux-offsets.h: Add include guard.
9922         * guile/guile.h: Rename include guard.
9923         * guile/guile-internal.h: Rename include guard.
9924         * gnu-nat.h: Rename include guard.
9925         * gdb-stabs.h: Rename include guard.
9926         * frv-tdep.h: Add include guard.
9927         * f-lang.h: Add include guard.
9928         * event-loop.h: Add include guard.
9929         * darwin-nat.h: Rename include guard.
9930         * cp-abi.h: Rename include guard.
9931         * config/sparc/nm-sol2.h: Rename include guard.
9932         * config/nm-nto.h: Rename include guard.
9933         * config/nm-linux.h: Add include guard.
9934         * config/i386/nm-i386gnu.h: Rename include guard.
9935         * config/djgpp/nl_types.h: Rename include guard.
9936         * config/djgpp/langinfo.h: Rename include guard.
9937         * compile/gcc-cp-plugin.h: Add include guard.
9938         * compile/gcc-c-plugin.h: Add include guard.
9939         * compile/compile.h: Rename include guard.
9940         * compile/compile-object-run.h: Rename include guard.
9941         * compile/compile-object-load.h: Rename include guard.
9942         * compile/compile-internal.h: Rename include guard.
9943         * compile/compile-cplus.h: Rename include guard.
9944         * compile/compile-c.h: Rename include guard.
9945         * common/xml-utils.h: Rename include guard.
9946         * common/x86-xstate.h: Rename include guard.
9947         * common/version.h: Rename include guard.
9948         * common/vec.h: Rename include guard.
9949         * common/tdesc.h: Rename include guard.
9950         * common/selftest.h: Rename include guard.
9951         * common/scoped_restore.h: Rename include guard.
9952         * common/scoped_mmap.h: Rename include guard.
9953         * common/scoped_fd.h: Rename include guard.
9954         * common/safe-iterator.h: Rename include guard.
9955         * common/run-time-clock.h: Rename include guard.
9956         * common/refcounted-object.h: Rename include guard.
9957         * common/queue.h: Rename include guard.
9958         * common/ptid.h: Rename include guard.
9959         * common/print-utils.h: Rename include guard.
9960         * common/preprocessor.h: Rename include guard.
9961         * common/pathstuff.h: Rename include guard.
9962         * common/observable.h: Rename include guard.
9963         * common/netstuff.h: Rename include guard.
9964         * common/job-control.h: Rename include guard.
9965         * common/host-defs.h: Rename include guard.
9966         * common/gdb_wait.h: Rename include guard.
9967         * common/gdb_vecs.h: Rename include guard.
9968         * common/gdb_unlinker.h: Rename include guard.
9969         * common/gdb_unique_ptr.h: Rename include guard.
9970         * common/gdb_tilde_expand.h: Rename include guard.
9971         * common/gdb_sys_time.h: Rename include guard.
9972         * common/gdb_string_view.h: Rename include guard.
9973         * common/gdb_splay_tree.h: Rename include guard.
9974         * common/gdb_setjmp.h: Rename include guard.
9975         * common/gdb_ref_ptr.h: Rename include guard.
9976         * common/gdb_optional.h: Rename include guard.
9977         * common/gdb_locale.h: Rename include guard.
9978         * common/gdb_assert.h: Rename include guard.
9979         * common/filtered-iterator.h: Rename include guard.
9980         * common/filestuff.h: Rename include guard.
9981         * common/fileio.h: Rename include guard.
9982         * common/environ.h: Rename include guard.
9983         * common/common-utils.h: Rename include guard.
9984         * common/common-types.h: Rename include guard.
9985         * common/common-regcache.h: Rename include guard.
9986         * common/common-inferior.h: Rename include guard.
9987         * common/common-gdbthread.h: Rename include guard.
9988         * common/common-exceptions.h: Rename include guard.
9989         * common/common-defs.h: Rename include guard.
9990         * common/common-debug.h: Rename include guard.
9991         * common/cleanups.h: Rename include guard.
9992         * common/buffer.h: Rename include guard.
9993         * common/btrace-common.h: Rename include guard.
9994         * common/break-common.h: Rename include guard.
9995         * cli/cli-utils.h: Rename include guard.
9996         * cli/cli-style.h: Rename include guard.
9997         * cli/cli-setshow.h: Rename include guard.
9998         * cli/cli-script.h: Rename include guard.
9999         * cli/cli-interp.h: Rename include guard.
10000         * cli/cli-decode.h: Rename include guard.
10001         * cli/cli-cmds.h: Rename include guard.
10002         * charset-list.h: Add include guard.
10003         * buildsym-legacy.h: Rename include guard.
10004         * bfin-tdep.h: Add include guard.
10005         * ax.h: Rename include guard.
10006         * arm-linux-tdep.h: Add include guard.
10007         * arm-fbsd-tdep.h: Add include guard.
10008         * arch/xtensa.h: Rename include guard.
10009         * arch/tic6x.h: Add include guard.
10010         * arch/i386.h: Add include guard.
10011         * arch/arm.h: Rename include guard.
10012         * arch/arm-linux.h: Rename include guard.
10013         * arch/arm-get-next-pcs.h: Rename include guard.
10014         * arch/amd64.h: Add include guard.
10015         * arch/aarch64-insn.h: Rename include guard.
10016         * arch-utils.h: Rename include guard.
10017         * annotate.h: Add include guard.
10018         * amd64-darwin-tdep.h: Rename include guard.
10019         * aarch64-linux-tdep.h: Add include guard.
10020         * aarch64-fbsd-tdep.h: Add include guard.
10021         * aarch32-linux-nat.h: Add include guard.
10022
10023 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10024
10025         * macrotab.c (macro_define_internal): New function that
10026         factorizes macro_define_object_internal and macro_define_function
10027         code.
10028         (macro_define_object_internal): Use macro_define_internal.
10029         (macro_define_function): Likewise.
10030
10031 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10032
10033         * macrocmd.c (extract_identifier): Return
10034         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10035         callers.
10036
10037 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10038
10039         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10040
10041 2019-02-05  Tom Tromey  <tom@tromey.com>
10042
10043         * target.c (target_stack::unpush): Move assertion earlier.
10044
10045 2019-01-30  Tom Tromey  <tom@tromey.com>
10046
10047         PR python/23615:
10048         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10049         (gdbpy_parse_and_eval): Likewise.
10050         * python/python-internal.h (gdbpy_allow_threads): New class.
10051
10052 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10053
10054         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10055         (aarch64_fbsd_fpregmap): Move earlier.
10056         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10057         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10058         instead of individual calls to trad_frame_set_reg_addr.
10059         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10060         earlier.
10061         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10062         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10063         instead of individual calls to trad_frame_set_reg_addr.
10064
10065 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10066
10067         * CONTRIBUTE: Replace contribution list with wiki link.
10068
10069 2019-01-25  Tom Tromey  <tom@tromey.com>
10070
10071         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10072
10073 2019-01-25  Tom Tromey  <tom@tromey.com>
10074
10075         * xtensa-linux-nat.c: Fix common/ includes.
10076         * xml-support.h: Fix common/ includes.
10077         * xml-support.c: Fix common/ includes.
10078         * x86-linux-nat.c: Fix common/ includes.
10079         * windows-nat.c: Fix common/ includes.
10080         * varobj.h: Fix common/ includes.
10081         * varobj.c: Fix common/ includes.
10082         * value.c: Fix common/ includes.
10083         * valops.c: Fix common/ includes.
10084         * utils.c: Fix common/ includes.
10085         * unittests/xml-utils-selftests.c: Fix common/ includes.
10086         * unittests/utils-selftests.c: Fix common/ includes.
10087         * unittests/unpack-selftests.c: Fix common/ includes.
10088         * unittests/tracepoint-selftests.c: Fix common/ includes.
10089         * unittests/style-selftests.c: Fix common/ includes.
10090         * unittests/string_view-selftests.c: Fix common/ includes.
10091         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10092         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10093         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10094         * unittests/rsp-low-selftests.c: Fix common/ includes.
10095         * unittests/parse-connection-spec-selftests.c: Fix common/
10096         includes.
10097         * unittests/optional-selftests.c: Fix common/ includes.
10098         * unittests/offset-type-selftests.c: Fix common/ includes.
10099         * unittests/observable-selftests.c: Fix common/ includes.
10100         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10101         * unittests/memrange-selftests.c: Fix common/ includes.
10102         * unittests/memory-map-selftests.c: Fix common/ includes.
10103         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10104         * unittests/function-view-selftests.c: Fix common/ includes.
10105         * unittests/environ-selftests.c: Fix common/ includes.
10106         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10107         * unittests/common-utils-selftests.c: Fix common/ includes.
10108         * unittests/cli-utils-selftests.c: Fix common/ includes.
10109         * unittests/array-view-selftests.c: Fix common/ includes.
10110         * ui-file.c: Fix common/ includes.
10111         * tui/tui-io.c: Fix common/ includes.
10112         * tracepoint.h: Fix common/ includes.
10113         * tracepoint.c: Fix common/ includes.
10114         * tracefile-tfile.c: Fix common/ includes.
10115         * top.h: Fix common/ includes.
10116         * top.c: Fix common/ includes.
10117         * thread.c: Fix common/ includes.
10118         * target/waitstatus.h: Fix common/ includes.
10119         * target/waitstatus.c: Fix common/ includes.
10120         * target.h: Fix common/ includes.
10121         * target.c: Fix common/ includes.
10122         * target-memory.c: Fix common/ includes.
10123         * target-descriptions.c: Fix common/ includes.
10124         * symtab.h: Fix common/ includes.
10125         * symfile.c: Fix common/ includes.
10126         * stap-probe.c: Fix common/ includes.
10127         * spu-linux-nat.c: Fix common/ includes.
10128         * sparc-nat.c: Fix common/ includes.
10129         * source.c: Fix common/ includes.
10130         * solib.c: Fix common/ includes.
10131         * solib-target.c: Fix common/ includes.
10132         * ser-unix.c: Fix common/ includes.
10133         * ser-tcp.c: Fix common/ includes.
10134         * ser-pipe.c: Fix common/ includes.
10135         * ser-base.c: Fix common/ includes.
10136         * selftest-arch.c: Fix common/ includes.
10137         * s12z-tdep.c: Fix common/ includes.
10138         * rust-exp.y: Fix common/ includes.
10139         * rs6000-aix-tdep.c: Fix common/ includes.
10140         * riscv-tdep.c: Fix common/ includes.
10141         * remote.c: Fix common/ includes.
10142         * remote-notif.h: Fix common/ includes.
10143         * remote-fileio.h: Fix common/ includes.
10144         * remote-fileio.c: Fix common/ includes.
10145         * regcache.h: Fix common/ includes.
10146         * regcache.c: Fix common/ includes.
10147         * record-btrace.c: Fix common/ includes.
10148         * python/python.c: Fix common/ includes.
10149         * python/py-type.c: Fix common/ includes.
10150         * python/py-inferior.c: Fix common/ includes.
10151         * progspace.h: Fix common/ includes.
10152         * producer.c: Fix common/ includes.
10153         * procfs.c: Fix common/ includes.
10154         * proc-api.c: Fix common/ includes.
10155         * printcmd.c: Fix common/ includes.
10156         * ppc-linux-nat.c: Fix common/ includes.
10157         * parser-defs.h: Fix common/ includes.
10158         * osdata.c: Fix common/ includes.
10159         * obsd-nat.c: Fix common/ includes.
10160         * nat/x86-linux.c: Fix common/ includes.
10161         * nat/x86-linux-dregs.c: Fix common/ includes.
10162         * nat/x86-dregs.h: Fix common/ includes.
10163         * nat/x86-dregs.c: Fix common/ includes.
10164         * nat/ppc-linux.c: Fix common/ includes.
10165         * nat/mips-linux-watch.h: Fix common/ includes.
10166         * nat/mips-linux-watch.c: Fix common/ includes.
10167         * nat/linux-waitpid.c: Fix common/ includes.
10168         * nat/linux-ptrace.h: Fix common/ includes.
10169         * nat/linux-ptrace.c: Fix common/ includes.
10170         * nat/linux-procfs.c: Fix common/ includes.
10171         * nat/linux-personality.c: Fix common/ includes.
10172         * nat/linux-osdata.c: Fix common/ includes.
10173         * nat/linux-namespaces.c: Fix common/ includes.
10174         * nat/linux-btrace.h: Fix common/ includes.
10175         * nat/linux-btrace.c: Fix common/ includes.
10176         * nat/fork-inferior.c: Fix common/ includes.
10177         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10178         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10179         * nat/aarch64-linux.c: Fix common/ includes.
10180         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10181         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10182         * namespace.h: Fix common/ includes.
10183         * mips-linux-tdep.c: Fix common/ includes.
10184         * minsyms.c: Fix common/ includes.
10185         * mi/mi-parse.h: Fix common/ includes.
10186         * mi/mi-main.c: Fix common/ includes.
10187         * mi/mi-cmd-env.c: Fix common/ includes.
10188         * memrange.h: Fix common/ includes.
10189         * memattr.c: Fix common/ includes.
10190         * maint.h: Fix common/ includes.
10191         * maint.c: Fix common/ includes.
10192         * main.c: Fix common/ includes.
10193         * machoread.c: Fix common/ includes.
10194         * location.c: Fix common/ includes.
10195         * linux-thread-db.c: Fix common/ includes.
10196         * linux-nat.c: Fix common/ includes.
10197         * linux-fork.c: Fix common/ includes.
10198         * inline-frame.c: Fix common/ includes.
10199         * infrun.c: Fix common/ includes.
10200         * inflow.c: Fix common/ includes.
10201         * inferior.h: Fix common/ includes.
10202         * inferior.c: Fix common/ includes.
10203         * infcmd.c: Fix common/ includes.
10204         * inf-ptrace.c: Fix common/ includes.
10205         * inf-child.c: Fix common/ includes.
10206         * ia64-linux-nat.c: Fix common/ includes.
10207         * i387-tdep.c: Fix common/ includes.
10208         * i386-tdep.c: Fix common/ includes.
10209         * i386-linux-tdep.c: Fix common/ includes.
10210         * i386-linux-nat.c: Fix common/ includes.
10211         * i386-go32-tdep.c: Fix common/ includes.
10212         * i386-fbsd-tdep.c: Fix common/ includes.
10213         * i386-fbsd-nat.c: Fix common/ includes.
10214         * guile/scm-type.c: Fix common/ includes.
10215         * guile/guile.c: Fix common/ includes.
10216         * go32-nat.c: Fix common/ includes.
10217         * gnu-nat.c: Fix common/ includes.
10218         * gdbthread.h: Fix common/ includes.
10219         * gdbarch-selftests.c: Fix common/ includes.
10220         * gdb_usleep.c: Fix common/ includes.
10221         * gdb_select.h: Fix common/ includes.
10222         * gdb_bfd.c: Fix common/ includes.
10223         * gcore.c: Fix common/ includes.
10224         * fork-child.c: Fix common/ includes.
10225         * findvar.c: Fix common/ includes.
10226         * fbsd-nat.c: Fix common/ includes.
10227         * event-top.c: Fix common/ includes.
10228         * event-loop.c: Fix common/ includes.
10229         * dwarf2read.c: Fix common/ includes.
10230         * dwarf2loc.c: Fix common/ includes.
10231         * dwarf2-frame.c: Fix common/ includes.
10232         * dwarf-index-cache.c: Fix common/ includes.
10233         * dtrace-probe.c: Fix common/ includes.
10234         * disasm-selftests.c: Fix common/ includes.
10235         * defs.h: Fix common/ includes.
10236         * csky-tdep.c: Fix common/ includes.
10237         * cp-valprint.c: Fix common/ includes.
10238         * cp-support.h: Fix common/ includes.
10239         * cp-support.c: Fix common/ includes.
10240         * corelow.c: Fix common/ includes.
10241         * completer.h: Fix common/ includes.
10242         * completer.c: Fix common/ includes.
10243         * compile/compile.c: Fix common/ includes.
10244         * compile/compile-loc2c.c: Fix common/ includes.
10245         * compile/compile-cplus-types.c: Fix common/ includes.
10246         * compile/compile-cplus-symbols.c: Fix common/ includes.
10247         * command.h: Fix common/ includes.
10248         * cli/cli-dump.c: Fix common/ includes.
10249         * cli/cli-cmds.c: Fix common/ includes.
10250         * charset.c: Fix common/ includes.
10251         * build-id.c: Fix common/ includes.
10252         * btrace.h: Fix common/ includes.
10253         * btrace.c: Fix common/ includes.
10254         * breakpoint.h: Fix common/ includes.
10255         * breakpoint.c: Fix common/ includes.
10256         * ax.h:
10257         (enum agent_op): Fix common/ includes.
10258         * ax-general.c (struct aop_map): Fix common/ includes.
10259         * ax-gdb.c: Fix common/ includes.
10260         * auxv.c: Fix common/ includes.
10261         * auto-load.c: Fix common/ includes.
10262         * arm-tdep.c: Fix common/ includes.
10263         * arch/riscv.c: Fix common/ includes.
10264         * arch/ppc-linux-common.c: Fix common/ includes.
10265         * arch/i386.c: Fix common/ includes.
10266         * arch/arm.c: Fix common/ includes.
10267         * arch/arm-linux.c: Fix common/ includes.
10268         * arch/arm-get-next-pcs.c: Fix common/ includes.
10269         * arch/amd64.c: Fix common/ includes.
10270         * arch/aarch64.c: Fix common/ includes.
10271         * arch/aarch64-insn.c: Fix common/ includes.
10272         * arch-utils.c: Fix common/ includes.
10273         * amd64-windows-tdep.c: Fix common/ includes.
10274         * amd64-tdep.c: Fix common/ includes.
10275         * amd64-sol2-tdep.c: Fix common/ includes.
10276         * amd64-obsd-tdep.c: Fix common/ includes.
10277         * amd64-nbsd-tdep.c: Fix common/ includes.
10278         * amd64-linux-tdep.c: Fix common/ includes.
10279         * amd64-linux-nat.c: Fix common/ includes.
10280         * amd64-fbsd-tdep.c: Fix common/ includes.
10281         * amd64-fbsd-nat.c: Fix common/ includes.
10282         * amd64-dicos-tdep.c: Fix common/ includes.
10283         * amd64-darwin-tdep.c: Fix common/ includes.
10284         * agent.c: Fix common/ includes.
10285         * ada-lang.h: Fix common/ includes.
10286         * ada-lang.c: Fix common/ includes.
10287         * aarch64-tdep.c: Fix common/ includes.
10288
10289 2019-01-25  Tom Tromey  <tom@tromey.com>
10290
10291         * common/create-version.sh: Use common/version.h.
10292
10293 2019-01-24  Pedro Alves  <palves@redhat.com>
10294
10295         * infrun.c (signal_stop, signal_print, signal_program)
10296         (signal_catch, signal_pass): Now arrays instead of pointers.
10297         (update_signals_program_target, do_target_resume)
10298         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10299         * linux-nat.c (linux_nat_target::pass_signals)
10300         (linux_nat_target::create_inferior, linux_nat_target::attach):
10301         Adjust.
10302         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10303         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10304         * procfs.c (procfs_target::pass_signals): Adjust.
10305         * record-full.c (record_full_target::resume): Adjust.
10306         * remote.c (remote_target::pass_signals)
10307         (remote_target::program_signals): Adjust.
10308         * target-debug.h (target_debug_print_signals): Now takes a
10309         gdb::array_view as parameter.  Adjust.
10310         * target.h (target_ops) <pass_signals, program_signals>: Replace
10311         pointer and length parameters with gdb::array_view.
10312         (target_pass_signals, target_program_signals): Likewise.
10313         * target-delegates.c: Regenerate.
10314
10315 2019-01-24  Pedro Alves  <palves@redhat.com>
10316
10317         * common/forward-scope-exit.h
10318         (forward_scope_exit::forward_scope_exit): Pass arguments to
10319         m_bind_function directly, instead of creating a std::bind and
10320         copying that.
10321
10322 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10323
10324         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10325         for static members.
10326         (pass_in_v_vfp_candidate): Likewise.
10327
10328 2019-01-23  Tom Tromey  <tom@tromey.com>
10329             Pedro Alves  <palves@redhat.com>
10330
10331         * regcache.c (class regcache_invalidator): Remove.
10332         (regcache::raw_write): Use make_scope_exit.
10333
10334 2019-01-23  Tom Tromey  <tom@tromey.com>
10335
10336         * ui-out.h (class ui_out_emit_type): Update comment.
10337
10338 2019-01-23  Tom Tromey  <tom@tromey.com>
10339
10340         * infrun.c (fetch_inferior_event): Update comment.
10341
10342 2019-01-23  Tom Tromey  <tom@tromey.com>
10343             Pedro Alves  <palves@redhat.com>
10344
10345         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10346         parameter.
10347         (fetch_inferior_event): Use SCOPE_EXIT.
10348
10349
10350 2019-01-23  Tom Tromey  <tom@tromey.com>
10351             Pedro Alves  <palves@redhat.com>
10352
10353         * infrun.c (disable_thread_events): Delete.
10354         (stop_all_threads): Use SCOPE_EXIT.
10355
10356 2019-01-23  Tom Tromey  <tom@tromey.com>
10357             Pedro Alves  <palves@redhat.com>
10358
10359         * symfile.c: Include forward-scope-exit.h.
10360         (clear_symtab_users_cleanup): Replace forward declaration with
10361         a FORWARD_SCOPE_EXIT.
10362         (syms_from_objfile_1): Use the forward_scope_exit and
10363         gdb::optional instead of cleanup_function.
10364         (reread_symbols): Use the forward_scope_exit instead of
10365         cleanup_function.
10366         (clear_symtab_users_cleanup): Remove function.
10367
10368 2019-01-23  Tom Tromey  <tom@tromey.com>
10369             Pedro Alves  <palves@redhat.com>
10370
10371         * linux-nat.c: Include scope-exit.h.
10372         (cleanup_target_stop): Remove.
10373         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10374         SCOPE_EXIT.
10375
10376 2019-01-23  Tom Tromey  <tom@tromey.com>
10377             Pedro Alves  <palves@redhat.com>
10378
10379         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10380         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10381
10382 2019-01-23  Tom Tromey  <tom@tromey.com>
10383             Andrew Burgess  <andrew.burgess@embecosm.com>
10384             Pedro Alves  <palves@redhat.com>
10385
10386         * infrun.c (fetch_inferior_event): Use scope_exit.
10387         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10388         * top.c (execute_command): Use scope_exit.
10389         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10390         * utils.c (do_bpstat_clear_actions_cleanup)
10391         (make_bpstat_clear_actions_cleanup): Remove.
10392
10393 2019-01-23  Tom Tromey  <tom@tromey.com>
10394             Pedro Alves  <palves@redhat.com>
10395
10396         * infrun.c: Include "common/scope-exit.h"
10397         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10398         (wait_for_inferior): Use SCOPE_EXIT.
10399         (fetch_inferior_event): Use scope_exit.
10400
10401 2019-01-23  Tom Tromey  <tom@tromey.com>
10402             Pedro Alves  <palves@redhat.com>
10403
10404         * breakpoint.c (create_breakpoint): Remove cleanup.
10405
10406 2019-01-23  Tom Tromey  <tom@tromey.com>
10407             Andrew Burgess  <andrew.burgess@embecosm.com>
10408             Pedro Alves  <palves@redhat.com>
10409
10410 2019-01-23  Pedro Alves  <palves@redhat.com>
10411
10412         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10413
10414 2019-01-23  Pedro Alves  <palves@redhat.com>
10415             Andrew Burgess  <andrew.burgess@embecosm.com>
10416
10417         * gdbthread.h: Include "common/forward-scope-exit.h".
10418         (scoped_finish_thread_state): Redefine custom class in terms of
10419         forward_scope_exit.
10420
10421 2019-01-23  Pedro Alves  <palves@redhat.com>
10422             Andrew Burgess  <andrew.burgess@embecosm.com>
10423
10424         * common/forward-scope-exit.h: New file.
10425
10426 2019-01-23  Pedro Alves  <palves@redhat.com>
10427             Andrew Burgess  <andrew.burgess@embecosm.com>
10428             Tom Tromey  <tom@tromey.com>
10429
10430         * common/scope-exit.h: New file.
10431
10432 2019-01-23  Pedro Alves  <palves@redhat.com>
10433
10434         * common/preprocessor.h (ESC): Rename to ...
10435         (ESC_PARENS): ... this.
10436         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10437         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10438
10439 2019-01-23  Tom Tromey  <tom@tromey.com>
10440
10441         * language.h (class scoped_switch_to_sym_language_if_auto):
10442         Initialize m_lang in both cases.
10443
10444 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10445
10446         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10447         with XCNEW.
10448
10449 2019-01-22  Tom Tromey  <tom@tromey.com>
10450
10451         * corelow.c: Do not include sys/file.h.
10452
10453 2019-01-22  Tom Tromey  <tom@tromey.com>
10454
10455         * tui/tui-wingeneral.h: Include gdb_curses.h.
10456
10457 2019-01-22  Tom Tromey  <tom@tromey.com>
10458
10459         * source-cache.h (class source_cache) <get_source_lines,
10460         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10461
10462 2019-01-22  Tom Tromey  <tom@tromey.com>
10463
10464         * remote-fileio.h (struct remote_target): Declare.
10465
10466 2019-01-22  Tom Tromey  <tom@tromey.com>
10467
10468         * python/py-arch.c: Do not include py-ref.h.
10469         * python/py-bpevent.c: Do not include py-ref.h.
10470         * python/py-cmd.c: Do not include py-ref.h.
10471         * python/py-continueevent.c: Do not include py-ref.h.
10472         * python/py-event.h: Do not include py-ref.h.
10473         * python/py-evtregistry.c: Do not include py-ref.h.
10474         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10475         * python/py-frame.c: Do not include py-ref.h.
10476         * python/py-framefilter.c: Do not include py-ref.h.
10477         * python/py-function.c: Do not include py-ref.h.
10478         * python/py-infevents.c: Do not include py-ref.h.
10479         * python/py-linetable.c: Do not include py-ref.h.
10480         * python/py-objfile.c: Do not include py-ref.h.
10481         * python/py-param.c: Do not include py-ref.h.
10482         * python/py-prettyprint.c: Do not include py-ref.h.
10483         * python/py-progspace.c: Do not include py-ref.h.
10484         * python/py-symbol.c: Do not include py-ref.h.
10485         * python/py-symtab.c: Do not include py-ref.h.
10486         * python/py-type.c: Do not include py-ref.h.
10487         * python/py-unwind.c: Do not include py-ref.h.
10488         * python/py-utils.c: Do not include py-ref.h.
10489         * python/py-value.c: Do not include py-ref.h.
10490         * python/py-varobj.c: Do not include py-ref.h.
10491         * python/py-xmethods.c: Do not include py-ref.h.
10492         * python/python.c: Do not include py-ref.h.
10493         * varobj.c: Do not include py-ref.h.
10494
10495 2019-01-22  Tom Tromey  <tom@tromey.com>
10496
10497         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10498         keyword for bcache.
10499
10500 2019-01-22  Tom Tromey  <tom@tromey.com>
10501
10502         * compile/compile-cplus-types.c: Remove a comment by #include.
10503
10504 2019-01-22  Tom Tromey  <tom@tromey.com>
10505
10506         * compile/gcc-c-plugin.h: Include compile-internal.h.
10507
10508 2019-01-22  Tom Tromey  <tom@tromey.com>
10509
10510         * stabsread.c (EXTERN): Do not define.
10511         (symnum, next_symbol_text_func, processing_gcc_compilation)
10512         (within_function, global_sym_chain, global_stabs)
10513         (previous_stab_code, this_object_header_files)
10514         (n_this_object_header_files)
10515         (n_allocated_this_object_header_files): Define.
10516         * stabsread.h (EXTERN): Never define.  Use "extern".
10517
10518 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10519
10520         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10521         history_value.
10522
10523 2019-01-21  Tom Tromey  <tom@tromey.com>
10524
10525         * ui-out.c: Fix includes.
10526         * tui/tui-source.c: Fix includes.
10527         * target.c: Fix includes.
10528         * remote.c: Fix includes.
10529         * regcache.c: Fix includes.
10530         * python/py-block.c: Fix includes.
10531         * printcmd.c: Fix includes.
10532         * or1k-tdep.c: Fix includes.
10533         * mi/mi-main.c: Fix includes.
10534         * m32r-tdep.c: Fix includes.
10535         * csky-tdep.c: Fix includes.
10536         * compile/compile-cplus-types.c: Fix includes.
10537         * cli/cli-interp.c: Fix includes.
10538
10539 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10540
10541         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10542         for padding.
10543
10544 2019-01-16  Tom Tromey  <tom@tromey.com>
10545
10546         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10547         earlier.
10548         (struct objfile) <msymbols_range>: Move from top level.
10549         <msymbols>: New method.
10550         (class objfile_msymbols): Remove.
10551         * symtab.c (default_collect_symbol_completion_matches_break_on):
10552         Update.
10553         * symmisc.c (dump_msymbols): Update.
10554         * stabsread.c (scan_file_globals): Update.
10555         * objc-lang.c (info_selectors_command, info_classes_command)
10556         (find_methods): Update.
10557         * minsyms.c (find_solib_trampoline_target): Update.
10558         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10559         * coffread.c (coff_symfile_read): Update.
10560         * ada-lang.c (ada_lookup_simple_minsym)
10561         (ada_collect_symbol_completion_matches): Update.
10562
10563 2019-01-16  Tom Tromey  <tom@tromey.com>
10564
10565         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10566         type.  Remove no-argument constructor.
10567         <iterator::operator++>: Simplify.
10568         <begin>: Update.
10569         <end>: Use minimal_symbol_count.
10570
10571 2019-01-16  Tom Tromey  <tom@tromey.com>
10572
10573         * objfiles.h (struct objfile) <psymtabs>: New method.
10574         (class objfile_psymtabs): Remove.
10575         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10576         typedef.
10577         <range>: New method.
10578         (require_partial_symbols): Change return type.
10579         * psymtab.c (require_partial_symbols)
10580         (psym_expand_symtabs_matching): Update.
10581         * mdebugread.c (parse_partial_symbols): Update.
10582         * dbxread.c (dbx_end_psymtab): Update.
10583
10584 2019-01-15  Tom Tromey  <tom@tromey.com>
10585
10586         * symtab.c (lookup_objfile_from_block)
10587         (lookup_symbol_in_objfile_symtabs)
10588         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10589         (find_line_symtab, info_sources_command)
10590         (default_collect_symbol_completion_matches_break_on)
10591         (make_source_files_completion_list): Update.
10592         * symmisc.c (print_objfile_statistics, dump_objfile)
10593         (maintenance_print_symbols, maintenance_info_symtabs)
10594         (maintenance_check_symtabs, maintenance_info_line_tables):
10595         Update.
10596         * source.c (select_source_symtab)
10597         (forget_cached_source_info_for_objfile): Update.
10598         * objfiles.h (class objfile_compunits): Remove.
10599         (struct objfile) <compunits_range>: New typedef.
10600         (compunits): New method.
10601         * objfiles.c (objfile_relocate1): Update.
10602         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10603         * maint.c (count_symtabs_and_blocks): Update.
10604         * linespec.c (iterate_over_all_matching_symtabs): Update.
10605         * cp-support.c (add_symbol_overload_list_qualified): Update.
10606         * coffread.c (coff_symtab_read): Update.
10607         * ada-lang.c (add_nonlocal_symbols)
10608         (ada_collect_symbol_completion_matches)
10609         (ada_add_global_exceptions): Update.
10610
10611 2019-01-15  Tom Tromey  <tom@tromey.com>
10612
10613         * progspace.h (program_space) <objfiles_safe_range>: New
10614         typedef.
10615         <objfiles_safe>: New method.
10616         * objfiles.h (class all_objfiles_safe): Remove.
10617         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10618         * jit.c (jit_inferior_exit_hook): Update.
10619
10620 2019-01-17  Tom Tromey  <tom@tromey.com>
10621
10622         * progspace.h (program_space) <objfiles_range>: New typedef.
10623         <objfiles>: New method.
10624         <objfiles_head>: Rename from objfiles.
10625         (object_files): Update.
10626         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10627         * guile/scm-pretty-print.c
10628         (ppscm_find_pretty_printer_from_objfiles): Update.
10629         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10630         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10631         Update.
10632         * python/py-progspace.c (pspy_get_objfiles): Update.
10633         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10634         Update.
10635         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10636         (objfpy_lookup_objfile_by_build_id): Update.
10637         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10638         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10639         Update.
10640         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10641         (expand_symtab_containing_pc, lookup_objfile_from_block)
10642         (lookup_static_symbol, basic_lookup_transparent_type)
10643         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10644         (find_line_symtab, info_sources_command)
10645         (default_collect_symbol_completion_matches_break_on)
10646         (make_source_files_completion_list, find_main_name): Update.
10647         * symmisc.c (print_symbol_bcache_statistics)
10648         (print_objfile_statistics, maintenance_print_symbols)
10649         (maintenance_print_msymbols, maintenance_print_objfiles)
10650         (maintenance_info_symtabs, maintenance_check_symtabs)
10651         (maintenance_expand_symtabs, maintenance_info_line_tables):
10652         Update.
10653         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10654         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10655         (map_overlay_command, unmap_overlay_command)
10656         (simple_overlay_update, expand_symtabs_matching)
10657         (map_symbol_filenames): Update.
10658         * symfile-debug.c (set_debug_symfile): Update.
10659         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10660         Update.
10661         * source.c (select_source_symtab, forget_cached_source_info):
10662         Update.
10663         * solib.c (solib_read_symbols): Update.
10664         * solib-spu.c (append_ocl_sos): Update.
10665         * psymtab.c (maintenance_print_psymbols)
10666         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10667         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10668         * printcmd.c (info_symbol_command): Update.
10669         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10670         Update.
10671         * objfiles.h (class all_objfiles): Remove.
10672         * objfiles.c (have_partial_symbols, have_full_symbols)
10673         (have_minimal_symbols, qsort_cmp, update_section_map)
10674         (shared_objfile_contains_address_p)
10675         (default_iterate_over_objfiles_in_search_order): Update.
10676         * objc-lang.c (info_selectors_command, info_classes_command)
10677         (find_methods): Update.
10678         * minsyms.c (find_solib_trampoline_target): Update.
10679         * maint.c (maintenance_info_sections)
10680         (maintenance_translate_address, count_symtabs_and_blocks):
10681         Update.
10682         * main.c (captured_main_1): Update.
10683         * linux-thread-db.c (try_thread_db_load_from_pdir)
10684         (has_libpthread): Update.
10685         * linespec.c (iterate_over_all_matching_symtabs)
10686         (search_minsyms_for_name): Update.
10687         * jit.c (jit_find_objf_with_entry_addr): Update.
10688         * hppa-tdep.c (find_unwind_entry)
10689         (hppa_lookup_stub_minimal_symbol): Update.
10690         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10691         Update.
10692         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10693         (elf_gnu_ifunc_resolve_by_got): Update.
10694         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10695         * dwarf-index-write.c (save_gdb_index_command): Update.
10696         * cp-support.c (add_symbol_overload_list_qualified): Update.
10697         * breakpoint.c (create_overlay_event_breakpoint)
10698         (create_longjmp_master_breakpoint)
10699         (create_std_terminate_master_breakpoint)
10700         (create_exception_master_breakpoint): Update.
10701         * blockframe.c (find_pc_partial_function): Update.
10702         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10703         (ada_collect_symbol_completion_matches)
10704         (ada_add_global_exceptions): Update.
10705
10706 2019-01-17  Tom Tromey  <tom@tromey.com>
10707
10708         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10709         declare VEC.
10710         (solib_target_parse_libraries): Change return type.
10711         (library_list_start_segment, library_list_start_section)
10712         (library_list_end_library, library_list_start_library); Update.
10713         (solib_target_free_library_list): Remove.
10714         (solib_target_parse_libraries): Remove cleanup.  Change return
10715         type.
10716         (solib_target_current_sos): Update.
10717
10718 2019-01-17  Tom Tromey  <tromey@bapiya>
10719
10720         * valprint.c: Replace "the the" with "the".
10721         * symtab.c: Replace "the the" with "the".
10722         * solib.c: Replace "the the" with "the".
10723         * solib-dsbt.c: Replace "the the" with "the".
10724         * linespec.c: Replace "the the" with "the".
10725         * dwarf2loc.h: Replace "the the" with "the".
10726         * amd64-windows-tdep.c: Replace "the the" with "the".
10727         * aarch64-tdep.c: Replace "the the" with "the".
10728
10729 2019-01-16  Keith Seitz  <keiths@redhat.com>
10730
10731         PR gdb/23773
10732         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10733         <builder>: Rename to ..
10734         <m_builder>: ... this and make private.
10735         (dwarf2_cu::get_builder): New method.  Change all users of
10736         `builder' to use this method.
10737         (dwarf2_start_symtab): Move to ...
10738         (dwarf2_cu::start_symtab): ... here.  Update all callers
10739         (setup_type_unit_groups): Move to ...
10740         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10741         callers.
10742         (dwarf2_cu::reset_builder): New method.
10743         (process_full_compunit, process_full_type_unit): Use
10744         dwarf2_cu::reset_builder.
10745         (follow_die_offset): Record the ancestor CU if it is different
10746         from the followed DIE's CU.
10747         (follow_die_sig_1): Likewise.
10748
10749 2019-01-15  Tom Tromey  <tom@tromey.com>
10750
10751         * remote.c (class remote_state) <buf>: Now a char_vector.
10752         <buf_size>: Remove.
10753         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10754         parameter.
10755         (remote_target::getpkt_or_notif_sane_1)
10756         (remote_target::getpkt_sane)
10757         (remote_target::getpkt_or_notif_sane): Likewise.
10758         (class remote_target) <putpkt>: New overload.
10759         (remote_target::read_frame): Change type of "buf_p".  Remove
10760         sizeof_p parameter.
10761         (packet_ok): New overload.
10762         (packet_check_result): New overload.
10763         Update all uses.
10764
10765 2019-01-14  Tom Tromey  <tom@tromey.com>
10766
10767         * remote-notif.c (handle_notification, remote_notif_ack)
10768         (remote_notif_parse): Make "buf" const.
10769         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10770         const.
10771         (remote_notif_parse, remote_notif_ack, handle_notification):
10772         Likewise.
10773         * remote.c (remote_notif_stop_parse): Make "buf" const.
10774         (remote_target::remote_parse_stop_reply): Make "buf" const.
10775         (remote_notif_stop_ack): Make "buf" const.
10776
10777 2019-01-14  Tom Tromey  <tom@tromey.com>
10778
10779         * remote.c (remote_console_output): Make parameter const.
10780
10781 2019-01-14  Tom Tromey  <tom@tromey.com>
10782
10783         * target-debug.h (target_debug_print_signals): Constify.
10784         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10785         * procfs.c (procfs_target::pass_signals): Update.
10786         * linux-nat.c (linux_nat_target::pass_signals): Update.
10787         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10788         * target-delegates.c: Rebuild.
10789         * remote.c (remote_target::program_signals): Update.
10790         (remote_target::pass_signals): Update.
10791         * target.c (target_pass_signals): Constify argument.
10792         (target_program_signals): Likewise.
10793         * target.h (struct target_ops) <pass_signals, program_signals>:
10794         Constify argument.
10795         (target_pass_signals, target_program_signals): Constify argument.
10796
10797 2019-01-14  Tom Tromey  <tom@tromey.com>
10798
10799         PR tui/28819:
10800         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10801
10802 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10803
10804         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10805         field.
10806         * rs6000-tdep.c: Include reggroups.h.
10807         (IS_V_ALIAS_PSEUDOREG): Define.
10808         (rs6000_register_name): Return names for the "vX" aliases.
10809         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10810         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10811         aliases.  Call default_register_reggroup_p for all other
10812         pseudo-registers.
10813         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10814         New functions.
10815         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10816         Handle "vX" aliases.
10817         (v_alias_pseudo_register_collect): New function.
10818         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10819         (rs6000_gdbarch_init): Initialize "vX" aliases as
10820         pseudo-registers.  Restore registration of
10821         rs6000_pseudo_register_reggroup_p with
10822         set_tdesc_pseudo_register_reggroup_p.
10823
10824 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10825
10826         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10827         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10828         set_gdbarch_num_pseudo_regs.
10829
10830 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10831
10832         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10833         Remove arg prefixname, add do_set and do_show.
10834         Add member functions set_list and show_list.
10835         * cli/cli-style.c (class cli_style_option): Update accordingly.
10836         (style_set_list): Move to file scope.
10837         (style_show_list): Likewise.
10838         (set_style): Call help_list.
10839         (show_style): Call cmd_show_list.
10840         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10841         Update to use the new macro.
10842
10843 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10844
10845         * ada-lang.c (_initialize_ada_language): Expand the help text
10846         for the "catch exception" command.
10847
10848 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10849
10850         * symtab.c (matching_obj_sections): Initialize obj,
10851         declare it closer to its usage.
10852
10853 2019-01-10  Tom Tromey  <tom@tromey.com>
10854
10855         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10856         (basic_inf_threads_range): Remove.
10857         (inf_threads_range, inf_non_exited_threads_range)
10858         (safe_inf_threads_range): Use next_adapter.
10859
10860 2019-01-10  Keith Seitz  <keiths@redhat.com>
10861
10862         PR gdb/23712
10863         PR symtab/23010
10864         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10865         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10866
10867 2019-01-10  Keith Seitz  <keiths@redhat.com>
10868
10869         PR gdb/23712
10870         PR symtab/23010
10871         * dictionary.c (pending_to_vector): Remove.
10872         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10873         Remove _1 suffix, replacing functions of the same name.  Update
10874         all callers.
10875         (dict_create_hashed, dict_create_hashed_expandable)
10876         (dict_create_linear, dict_create_linear_expandable, dict_free)
10877         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10878         Make functions static.
10879
10880 2019-01-10  Keith Seitz  <keiths@redhat.com>
10881
10882         PR gdb/23712
10883         PR symtab/23010
10884         * dictionary.h (struct dictionary): Replace declaration with
10885         multidictionary.
10886         (dict_create_hashed, dict_create_hashed_expandable)
10887         (dict_create_linear, dict_create_linear_expandable)
10888         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10889         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10890         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10891         taking multidictionary argument.
10892         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10893         * block.h (struct block) <dict>: Change to multidictionary
10894         and rename `multidict'.
10895         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10896         symmisc.c: Update all dictionary references to multidictionary.
10897
10898 2019-01-10  Keith Seitz  <keiths@redhat.com>
10899
10900         PR gdb/23712
10901         PR symtab/23010
10902         * dictionary.c: Include unordered_map.
10903         (pending_to_vector): New function.
10904         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10905         Rewrite the non-"_1" functions to take vector instead
10906         of linked list.
10907         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10908         "new" _1 versions of the same name.
10909         (multidictionary): Define.
10910         (std::hash<enum language): New definition.
10911         (collate_pending_symbols_by_language, mdict_create_hashed)
10912         (mdict_create_hashed_expandable, mdict_create_linear)
10913         (mdict_create_linear_expandable, mdict_free)
10914         (find_language_dictionary, create_new_language_dictionary)
10915         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10916         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10917         (mdict_size, mdict_empty): New functions.
10918         * dictionary.h (mdict_iterator): Define.
10919
10920 2019-01-10  Pedro Alves  <palves@redhat.com>
10921
10922         * breakpoint.c (read_uploaded_action)
10923         (create_tracepoint_from_upload): Adjust to use
10924         gdb::unique_xmalloc_ptr.
10925         * ctf.c (ctf_write_uploaded_tp):
10926         (SET_ARRAY_FIELD): Use emplace_back.
10927         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10928         * tracefile-tfile.c (tfile_write_uploaded_tp):
10929         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10930         gdb::unique_xmalloc_ptr.
10931         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10932         at_string, cond_string, cmd_strings>: Replace char pointers
10933         with gdb::unique_xmalloc_ptr.
10934
10935 2019-01-10  Pedro Alves  <palves@redhat.com>
10936
10937         * solib-target.c (library_list_start_library): Don't xstrdup name.
10938
10939 2019-01-10  Pedro Alves  <palves@redhat.com>
10940
10941         * mdebugread.c (parse_partial_symbols): Use
10942         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10943
10944 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10945
10946         * linux-fork.c (scoped_switch_fork_info)
10947         <~scoped_switch_fork_info>: Fix incorrect variable name.
10948
10949 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10950
10951         * linux-fork.c (scoped_switch_fork_info)
10952         <scoped_switch_fork_info>: Make explicit.
10953         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10954
10955 2019-01-10  Tom Tromey  <tom@tromey.com>
10956
10957         * objfiles.h (objfile::reset_psymtabs): Update.
10958         * objfiles.c (objfile::objfile): Update.
10959         * psymtab.h (psymtab_storage::obstack): Update.
10960         (psymtab_storage::m_obstack): Use gdb::optional.
10961         (class psymtab_storage): Update comment.  Remove objfile
10962         parameter.
10963         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10964
10965 2019-01-10  Tom Tromey  <tom@tromey.com>
10966
10967         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10968         <free_psymtabs>: Now private.
10969         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10970         (allocate_psymtab): Use new method.
10971
10972 2019-01-10  Tom Tromey  <tom@tromey.com>
10973
10974         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10975         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10976         * mdebugread.c (parse_partial_symbols): Use
10977         allocate_dependencies.
10978         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10979         allocate_dependencies.
10980         (process_psymtab_comp_unit_reader)
10981         (build_type_psymtab_dependencies): Likewise.
10982         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10983
10984 2019-01-10  Tom Tromey  <tom@tromey.com>
10985
10986         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10987         PSYMBOL_SET_LANGUAGE.
10988         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10989
10990 2019-01-10  Tom Tromey  <tom@tromey.com>
10991
10992         * psymtab.h (psymtab_storage::obstack): New method.
10993         <m_obstack>: Rename from obstack; now private.
10994         * psymtab.c (psymtab_storage): Update.
10995         * dwarf2read.c (create_addrmap_from_index)
10996         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10997         Update.
10998
10999 2019-01-10  Tom Tromey  <tom@tromey.com>
11000
11001         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11002         * objfiles.h (objfile::reset_psymtabs): New method.
11003
11004 2019-01-10  Tom Tromey  <tom@tromey.com>
11005
11006         * symmisc.c (print_symbol_bcache_statistics): Update.
11007         (print_objfile_statistics): Update.
11008         * symfile.c (reread_symbols): Update.
11009         * psymtab.h (class psymtab_storage): New.
11010         * psymtab.c (psymtab_storage): New constructor.
11011         (~psymtab_storage): New destructor.
11012         (require_partial_symbols): Update.
11013         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11014         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11015         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11016         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11017         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11018         (start_psymtab_common, end_psymtab_common)
11019         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11020         (allocate_psymtab): Update.
11021         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11022         Update.
11023         (dump_psymtab_addrmap, maintenance_print_psymbols)
11024         (maintenance_check_psymtabs): Update.
11025         (class objfile_psymtabs): Move to objfiles.h.
11026         * psympriv.h (discard_psymtab): Now inline.
11027         (psymtab_discarder::psymtab_discarder): Update.
11028         (psymtab_discarder::~psymtab_discarder): Update.
11029         (ALL_OBJFILE_PSYMTABS): Rewrite.
11030         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11031         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11032         Remove fields.
11033         <partial_symtabs>: New field.
11034         (class objfile_psymtabs): Move from psymtab.h.  Update.
11035         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11036         psymbol_cache.
11037         (objfile::~objfile): Don't destroy psymbol_cache.
11038         * mdebugread.c (parse_partial_symbols): Update.
11039         * dwarf2read.c (create_addrmap_from_index)
11040         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11041         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11042         (add_partial_subprogram, dwarf2_ranges_read): Update.
11043         * dwarf-index-write.c (write_address_map)
11044         (write_one_signatured_type, recursively_write_psymbols)
11045         (class debug_names, class debug_names, write_psymtabs_to_index):
11046         Update.
11047
11048 2019-01-10  Tom Tromey  <tom@tromey.com>
11049
11050         * symtab.h (SYMBOL_SET_NAMES): Update.
11051         (symbol_set_names): Update.
11052         (MSYMBOL_SET_NAMES): Update.
11053         * symtab.c (symbol_set_names): Change argument to be an
11054         objfile_per_bfd_storage.
11055         * psymtab.c (add_psymbol_to_bcache): Update.
11056         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11057
11058 2019-01-10  Tom Tromey  <tom@tromey.com>
11059
11060         * symtab.c (create_demangled_names_hash): Change argument to be an
11061         objfile_per_bfd_storage.
11062         (symbol_set_names): Update.
11063
11064 2019-01-10  Tom Tromey  <tom@tromey.com>
11065
11066         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11067         init_psymbol_list.
11068         * psymtab.c (init_psymbol_list): Do nothing if already called.
11069         * psympriv.h (init_psymbol_list): Add comment.
11070         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11071         init_psymbol_list.
11072         * dbxread.c (dbx_symfile_read): Unconditionally call
11073         init_psymbol_list.
11074
11075 2019-01-10  Tom Tromey  <tom@tromey.com>
11076
11077         * xcoffread.c (scan_xcoff_symtab): Update.
11078         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11079         "where".
11080         * mdebugread.c (parse_partial_symbols)
11081         (handle_psymbol_enumerators): Update.
11082         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11083         * dbxread.c (read_dbx_symtab): Update.
11084         * psympriv.h (psymbol_placement): New enum.
11085         (add_psymbol_to_list): Update.
11086
11087 2019-01-10  Tom Tromey  <tom@tromey.com>
11088
11089         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11090         static_psymbols parameters.
11091         (scan_xcoff_symtab): Update.
11092         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11093         static_psymbols parameters.
11094         * psympriv.h (start_psymtab_common): Update.
11095         * mdebugread.c (parse_partial_symbols): Update.
11096         * dwarf2read.c (create_partial_symtab): Update.
11097         * dbxread.c (read_dbx_symtab): Update.
11098         (start_psymtab): Remove global_psymbols and static_psymbols
11099         parameters.
11100
11101 2019-01-10  Tom Tromey  <tom@tromey.com>
11102
11103         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11104         * psymtab.c (allocate_psymtab): Add comment.
11105         * psympriv.h (allocate_psymtab): Add comment.
11106         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11107         initializations.
11108         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11109
11110 2019-01-10  Tom Tromey  <tom@tromey.com>
11111
11112         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11113         Don't declare.
11114         * mipsread.c: Include mdebugread.h.
11115         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11116         Declare.
11117         * elfread.c: Include mdebugread.h.
11118
11119 2019-01-09  Tom Tromey  <tom@tromey.com>
11120
11121         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11122         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11123         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11124         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11125         (psym_lookup_symbol, psym_find_last_source_symtab)
11126         (psym_forget_cached_source_info, psym_print_stats)
11127         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11128         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11129         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11130         (psym_find_compunit_symtab_by_address)
11131         (maintenance_print_psymbols, maintenance_info_psymtabs)
11132         (maintenance_check_psymtabs): Use ranged for.
11133         * psymtab.h (class objfile_psymtabs): New.
11134         (require_partial_symbols): Return objfile_psymtabs.
11135         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11136
11137 2019-01-09  Tom Tromey  <tom@tromey.com>
11138
11139         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11140         (find_pc_mapped_section, list_overlays_command)
11141         (map_overlay_command, unmap_overlay_command)
11142         (simple_overlay_update): Use all_objfiles.
11143         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11144         * printcmd.c (info_symbol_command): Use all_objfiles.
11145         * objfiles.h (ALL_OBJSECTIONS): Remove.
11146         * maint.c (maintenance_translate_address): Use all_objfiles.
11147         * gcore.c (gcore_create_callback): Use all_objfiles.
11148         (objfile_find_memory_regions): Likewise.
11149
11150 2019-01-09  Tom Tromey  <tom@tromey.com>
11151
11152         * symtab.c (find_line_symtab, info_sources_command)
11153         (make_source_files_completion_list): Use objfile_compunits.
11154         * source.c (select_source_symtab): Use objfile_compunits.
11155         * objfiles.h (struct objfile): Update comment.
11156         (ALL_OBJFILES): Remove.
11157         (ALL_FILETABS): Remove.
11158         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11159         objfile_compunits.
11160
11161 2019-01-09  Tom Tromey  <tom@tromey.com>
11162
11163         * symmisc.c (print_objfile_statistics, dump_objfile)
11164         (maintenance_print_symbols): Use compunit_filetabs.
11165         * source.c (forget_cached_source_info_for_objfile): Use
11166         compunit_filetabs.
11167         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11168         (ALL_FILETABS): Use compunit_filetabs.
11169         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11170         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11171
11172 2019-01-09  Tom Tromey  <tom@tromey.com>
11173
11174         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11175         (compunit_filetabs): New.
11176         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11177         compunit_filetabs.
11178         (info_sources_command, make_source_files_completion_list): Remove
11179         declaration.
11180         * symmisc.c (print_objfile_statistics, dump_objfile)
11181         (maintenance_print_symbols): Remove declaration.
11182         (maintenance_info_symtabs): Use compunit_filetabs.
11183         (maintenance_info_line_tables): Likewise.
11184         * source.c (select_source_symtab): Change local variable name.
11185         (forget_cached_source_info_for_objfile): Remove declaration.
11186         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11187         * objfiles.c (objfile_relocate1): Remove declaration.
11188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11189         declaration.
11190         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11191         * coffread.c (coff_symtab_read): Remove declaration.
11192         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11193         compunit_filetabs.
11194
11195 2019-01-09  Tom Tromey  <tom@tromey.com>
11196
11197         * symtab.c (lookup_objfile_from_block)
11198         (find_pc_sect_compunit_symtab, search_symbols)
11199         (default_collect_symbol_completion_matches_break_on): Use
11200         objfile_compunits.
11201         * objfiles.h (ALL_COMPUNITS): Remove.
11202         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11203         * cp-support.c (add_symbol_overload_list_qualified): Use
11204         objfile_compunits.
11205         * ada-lang.c (ada_collect_symbol_completion_matches)
11206         (ada_add_global_exceptions): Use objfile_compunits.
11207
11208 2019-01-09  Tom Tromey  <tom@tromey.com>
11209
11210         * source.c (select_source_symtab)
11211         (forget_cached_source_info_for_objfile): Remove declaration.
11212         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11213         declaration.
11214         * maint.c (count_symtabs_and_blocks): Remove declaration.
11215         * cp-support.c (add_symbol_overload_list_qualified): Remove
11216         declaration.
11217         * coffread.c (coff_symtab_read): Remove declaration.
11218         * symtab.c (lookup_symbol_in_objfile_symtabs)
11219         (basic_lookup_transparent_type_1): Use objfile_compunits.
11220         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11221         (info_sources_command, search_symbols)
11222         (default_collect_symbol_completion_matches_break_on)
11223         (make_source_files_completion_list): Remove declaration.
11224         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11225         (ada_collect_symbol_completion_matches)
11226         (ada_add_global_exceptions): Remove declaration.
11227         * linespec.c (iterate_over_all_matching_symtabs): Use
11228         objfile_compunits.
11229         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11230         (class objfile_compunits): New.
11231         (ALL_COMPUNITS): Use objfile_compunits.
11232         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11233         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11234         objfile_compunits.
11235         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11236
11237 2019-01-09  Tom Tromey  <tom@tromey.com>
11238
11239         * symtab.c (search_symbols)
11240         (default_collect_symbol_completion_matches_break_on): Use
11241         objfile_msymbols.
11242         * ada-lang.c (ada_lookup_simple_minsym)
11243         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11244         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11245         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11246         objfile_msymbols.
11247         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11248         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11249         * objc-lang.c (find_methods): Use objfile_msymbols.
11250         (info_selectors_command, info_classes_command): Likewise.
11251         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11252         * objfiles.h (class objfile_msymbols): New.
11253         (ALL_OBJFILE_MSYMBOLS): Remove.
11254         (ALL_MSYMBOLS): Remove.
11255
11256 2019-01-09  Tom Tromey  <tom@tromey.com>
11257
11258         * common/next-iterator.h (next_adapter): Add Iterator template
11259         parameter.
11260         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11261         (class all_objfiles_safe): New.
11262         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11263         * objfiles.c (put_objfile_before): Update comment.
11264         (add_separate_debug_objfile): Likewise.
11265         (free_all_objfiles): Use all_objfiles_safe.
11266         (objfile_purge_solibs): Likewise.
11267
11268 2019-01-09  Tom Tromey  <tom@tromey.com>
11269
11270         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11271         (expand_symtab_containing_pc, lookup_static_symbol)
11272         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11273         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11274         all_objfiles.
11275         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11276         * breakpoint.c (create_overlay_event_breakpoint)
11277         (create_longjmp_master_breakpoint)
11278         (create_std_terminate_master_breakpoint)
11279         (create_exception_master_breakpoint): Use all_objfiles.
11280         * linux-thread-db.c (try_thread_db_load_from_pdir)
11281         (has_libpthread): Use all_objfiles.
11282         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11283         * linespec.c (iterate_over_all_matching_symtabs)
11284         (search_minsyms_for_name): Use all_objfiles.
11285         * maint.c (maintenance_info_sections): Use all_objfiles.
11286         * main.c (captured_main_1): Use all_objfiles.
11287         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11288         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11289         * guile/scm-pretty-print.c
11290         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11291         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11292         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11293         (maintenance_print_msymbols): Use all_objfiles.
11294         * source.c (select_source_symtab): Use all_objfiles.
11295         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11296         * symfile.c (remove_symbol_file_command)
11297         (expand_symtabs_matching, map_symbol_filenames): Use
11298         all_objfiles.
11299         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11300         all_objfiles.
11301         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11302         * objc-lang.c (find_methods): Use all_objfiles.
11303         * objfiles.c (have_partial_symbols, have_full_symbols)
11304         (have_minimal_symbols, qsort_cmp)
11305         (default_iterate_over_objfiles_in_search_order): Use
11306         all_objfiles.
11307         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11308         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11309         (maintenance_check_psymtabs): Use all_objfiles.
11310         (ALL_PSYMTABS): Remove.
11311         * compile/compile-object-run.c (do_module_cleanup): Use
11312         all_objfiles.
11313         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11314         * cp-support.c (add_symbol_overload_list_qualified): Use
11315         all_objfiles.
11316         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11317         Use all_objfiles.
11318         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11319         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11320         all_objfiles.
11321         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11322         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11323         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11324         Uses all_objfiles.
11325         * solib.c (solib_read_symbols): Use all_objfiles
11326
11327 2019-01-09  Tom Tromey  <tom@tromey.com>
11328
11329         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11330         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11331         all_objfiles.
11332         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11333         * symmisc.c (print_symbol_bcache_statistics)
11334         (print_objfile_statistics, maintenance_print_objfiles)
11335         (maintenance_info_symtabs, maintenance_check_symtabs)
11336         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11337         all_objfiles.
11338         * source.c (forget_cached_source_info): Use all_objfiles.
11339         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11340         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11341         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11342         * objfiles.c (update_section_map): Use all_objfiles.
11343         (shared_objfile_contains_address_p): Likewise.
11344         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11345         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11346
11347 2019-01-09  Tom Tromey  <tom@tromey.com>
11348
11349         * common/next-iterator.h: New file.
11350         * objfiles.h (class all_objfiles): New.
11351         (struct objfile_iterator): New.
11352
11353 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11354
11355         * NEWS: Move the description of the changed "frame", "select-frame",
11356          and "info frame" commands to the Changed commands section.
11357
11358 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11359
11360         * gdbtypes.c (check_stub_method_group): Remove handling of old
11361         mangling schemes.
11362         * linespec.c (find_methods): Likewise.
11363         * stabsread.c (read_member_functions): Likewise.
11364         * valops.c (search_struct_method): Likewise.
11365         (value_struct_elt_for_reference): Likewise.
11366         * NEWS: Mention this change.
11367
11368 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11369
11370         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11371         print_source_lines.
11372         * source.c (print_source_lines_base): Update line number check.
11373         (print_source_lines): New function.
11374         (source_lines_range::source_lines_range): New function.
11375         * source.h (class source_lines_range): New class.
11376         (print_source_lines): New declaration.
11377
11378 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11379
11380         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11381
11382 2019-01-08  Tom Tromey  <tom@tromey.com>
11383             Simon Marchi  <simon.marchi@ericsson.com>
11384
11385         PR gdb/24060
11386         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11387         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11388         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11389         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11390         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11391         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11392
11393 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11394
11395         * source.c (select_source_symtab): Move header comment to
11396         declaration in source.h.
11397         (forget_cached_source_info_for_objfile): Likewise.
11398         (forget_cached_source_info): Likewise.
11399         (identify_source_line): Likewise.
11400         * source.h (identify_source_line): Move declaration from symtab.h
11401         and add comment from source.c
11402         (print_source_lines): Likewise.
11403         (forget_cached_source_info_for_objfile): Likewise.
11404         (forget_cached_source_info): Likewise.
11405         (select_source_symtab): Likewise.
11406         (enum print_source_lines_flag): Move definition from symtab.h.
11407         * symtab.h (identify_source_line): Move declaration to source.h.
11408         (print_source_lines): Likewise.
11409         (forget_cached_source_info_for_objfile): Likewise.
11410         (forget_cached_source_info): Likewise.
11411         (select_source_symtab): Likewise.
11412         (enum print_source_lines_flag): Move definition to source.h.
11413         * tui/tui-hooks.c: Add 'source.h' include.
11414
11415 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11416
11417         * source.c (print_source_lines_base): Handle requests to print
11418         reverse line number sequences, and guard against empty lines
11419         string.
11420
11421 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * source.c (print_source_lines_base): Fix skip of '\r' if next
11424         character is '\n'.
11425
11426 2019-01-06  Tom Tromey  <tom@tromey.com>
11427
11428         * c-exp.y (struct c_parse_state) <macro_original_text,
11429         expansion_obstack>: New member.
11430         (macro_original_text, expansion_obstack): Remove globals.
11431         (scan_macro_expansion, scanning_macro_expansion)
11432         (finished_macro_expansion): Update.
11433         (scan_macro_cleanup): Remove.
11434         (yylex, c_parse): Update.
11435
11436 2019-01-06  Tom Tromey  <tom@tromey.com>
11437
11438         * c-exp.y (struct c_parse_state) <strings>: New member.
11439         (operator_stoken): Update.
11440
11441 2019-01-06  Tom Tromey  <tom@tromey.com>
11442
11443         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11444         (union type_stack_elt) <typelist_val>: Now a pointer to
11445         std::vector.
11446         (type_stack_cleanup): Don't declare.
11447         (push_typelist): Update.
11448         * parse.c (pop_typelist): Return a std::vector.
11449         (push_typelist): Take a std::vector.
11450         (follow_types): Update.  Do not free args.
11451         (type_stack_cleanup): Remove.
11452         * c-exp.y (struct c_parse_state): New.
11453         (cpstate): New global.
11454         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11455         (nonempty_typelist): Update.
11456         (func_mod): Create a new vector.
11457         (c_parse): Create a c_parse_state.
11458         (check_parameter_typelist): Do not delete params.
11459         (function_method): Update.  Do not delete type_list.
11460
11461 2019-01-06  Tom Tromey  <tom@tromey.com>
11462
11463         PR gdb/28155:
11464         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11465         check_typedef.
11466         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11467         (print_return_value): Likewise.
11468
11469 2019-01-05  Tom Tromey  <tom@tromey.com>
11470
11471         * contrib/cleanup_check.py: Remove.
11472         * contrib/gcc-with-excheck: Remove.
11473         * contrib/exsummary.py: Remove.
11474         * contrib/excheck.py: Remove.
11475
11476 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11477
11478         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11479         NULL. Initialize tpprev to NULL instead of assigning it
11480         to NULL on the next statement.
11481         * windows-nat.c (windows_delete_thread): Remove check for
11482         main_thread_id before printing thread exit notifications.
11483         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11484         Remove thread ID check against main_thread_id.
11485         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11486         windows_delete_thread.
11487         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11488
11489 2019-01-04  Tom Tromey  <tom@tromey.com>
11490
11491         * compile/compile.c (_initialize_compile): Use upper case for
11492         metasyntactic variables.
11493         * symmisc.c (_initialize_symmisc): Use upper case for
11494         metasyntactic variables.
11495         * psymtab.c (_initialize_psymtab): Use upper case for
11496         metasyntactic variables.
11497         * demangle.c (demangle_command): Use upper case for metasyntactic
11498         variables.
11499         (_initialize_demangler): Likewise.
11500         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11501         variables.
11502
11503 2019-01-03  Tom Tromey  <tom@tromey.com>
11504
11505         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11506
11507 2019-01-03  Tom Tromey  <tom@tromey.com>
11508
11509         * python/py-symtab.c (salpy_str): Update.
11510         (struct salpy_sal_object) <symtab>: Now a PyObject.
11511         (salpy_dealloc): Update.
11512         (del_objfile_sal): Use gdbpy_ref.
11513
11514 2019-01-03  Tom Tromey  <tom@tromey.com>
11515
11516         * python/py-type.c (convert_field): Use new_reference.  Return
11517         gdbpy_ref.
11518         (make_fielditem): Return gdbpy_ref.
11519         (typy_fields): Update.
11520         (typy_getitem): Update.
11521         (field_name): Return gdbpy_ref.  Use new_reference.
11522         (typy_iterator_iternext): Update.
11523
11524 2019-01-03  Tom Tromey  <tom@tromey.com>
11525
11526         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11527
11528 2019-01-03  Tom Tromey  <tom@tromey.com>
11529
11530         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11531         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11532         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11533         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11534         (pspy_set_type_printers): Likewise.
11535         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11536         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11537         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11538         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11539         (objfpy_set_type_printers): Likewise.
11540
11541 2019-01-03  Tom Tromey  <tom@tromey.com>
11542
11543         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11544         (gdbpy_print_stack): Use gdbpy_err_fetch.
11545         * python/python-internal.h (class gdbpy_err_fetch): New class.
11546         (class gdbpy_enter) <m_error_type, m_error_value,
11547         m_error_traceback>: Remove.
11548         <m_error>: New member.
11549         (gdbpy_exception_to_string): Don't declare.
11550         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11551         * python/py-value.c (convert_value_from_python): Use
11552         gdbpy_err_fetch.
11553         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11554         gdbpy_exception_to_string.
11555         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11556         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11557         gdbpy_err_fetch.
11558
11559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11560
11561         * linux-nat.c (delete_lwp_cleanup): Delete.
11562         (struct lwp_deleter): New struct.
11563         (lwp_info_up): New typedef.
11564         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11565         lwp_info_up.
11566
11567 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11568
11569         * linux-fork.c (class scoped_switch_fork_info): New class.
11570         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11571
11572 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11573
11574         * valops.c (find_overload_match): Remove use of null_cleanup, and
11575         calls to do_cleanups.
11576
11577 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11578
11579         * compile/compile-cplus-types.c
11580         (compile_cplus_instance::decl_name): Handle changes to
11581         cp_func_name.
11582         * cp-support.c (cp_func_name): Update header comment, update
11583         return type.
11584         * cp-support.h (cp_func_name): Update return type in declaration.
11585         * valops.c (find_overload_match): Move temp_func local to top
11586         level of function and change its type.  Use temp_func to hold and
11587         delete temporary string obtained from cp_func_name.
11588
11589 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11590
11591         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11592         gdb::char_vector, remove cleanup, and update uses of `msg`.
11593
11594 2019-01-03  Jim Wilson  <jimw@sifive.com>
11595
11596         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11597
11598 2019-01-02  Tom Tromey  <tom@tromey.com>
11599
11600         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11601         (tdesc_parse_xml): Remove cleanups.
11602         * target-descriptions.h (make_cleanup_free_target_description):
11603         Don't declare.
11604         (target_desc_deleter): New struct.
11605         (target_desc_up): New typedef.
11606         * target-descriptions.c (target_desc_deleter::operator()): Rename
11607         from free_target_description.
11608         (make_cleanup_free_target_description): Remove.
11609
11610 2019-01-02  Tom Tromey  <tom@tromey.com>
11611
11612         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11613         constructor, destructor.
11614         (linespec_parser): Remove typedef.
11615         (~linespec_parser): Rename from linespec_parser_delete.
11616         (linespec_lex_to_end, linespec_complete_label)
11617         (linespec_complete): Update.
11618         (decode_line_full): Remove cleanups.
11619         (decode_line_1): Update.
11620
11621 2019-01-02  Tom Tromey  <tom@tromey.com>
11622
11623         * python/python-internal.h (inferior_to_inferior_object): Change
11624         return type.
11625         * python/py-exitedevent.c (create_exited_event_object): Update.
11626         * python/py-inferior.c (inferior_to_inferior_object): Return
11627         gdbpy_ref.
11628         (python_new_inferior, python_inferior_deleted)
11629         (thread_to_thread_object, delete_thread_object)
11630         (build_inferior_list, gdbpy_selected_inferior): Update.
11631         * python/py-infthread.c (create_thread_object): Update.  Also fail
11632         if inferior_to_inferior_object fails.
11633
11634 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11635
11636         * inferior.h (class inferior) <displaced_step_state>: New field.
11637         * infrun.h (struct displaced_step_state): Move here from
11638         infrun.c.  Initialize fields, add constructor.
11639         <inf>: Remove field.
11640         <reset>: New method.
11641         * infrun.c (struct displaced_step_inferior_state): Move to
11642         infrun.h.
11643         (displaced_step_inferior_states): Remove.
11644         (get_displaced_stepping_state): Adust.
11645         (displaced_step_in_progress_any_inferior): Adjust.
11646         (displaced_step_in_progress_thread): Adjust.
11647         (displaced_step_in_progress): Adjust.
11648         (add_displaced_stepping_state): Remove.
11649         (get_displaced_step_closure_by_addr): Adjust.
11650         (remove_displaced_stepping_state): Remove.
11651         (infrun_inferior_exit): Call displaced_step_state.reset.
11652         (use_displaced_stepping): Don't check for NULL.
11653         (displaced_step_prepare_throw): Call
11654         get_displaced_stepping_state.
11655         (displaced_step_fixup): Don't check for NULL.
11656         (prepare_for_detach): Don't check for NULL.
11657
11658 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11659
11660         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11661          in case of call that did not complete.
11662
11663 2019-01-02  Andrey Utkin  <autkin@undo.io>
11664
11665         * symfile.c (find_separate_debug_file): Fix search of debug files for
11666         remote debuggee.
11667
11668 2019-01-02  Tom Tromey  <tom@tromey.com>
11669
11670         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11671         indentation.
11672         * python/py-frame.c (frapy_older): Remove cast.
11673         (frapy_newer): Likewise.
11674         * python/py-breakpoint.c (local_setattro): Remove cast.
11675         * python/py-arch.c (archpy_name): Remove local variable.
11676         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11677
11678 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11679
11680         * unittests/basic_string_view/element_access/char/empty.cc:
11681         Fix year range in copyright header.
11682
11683 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11684
11685         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11686         Delete.
11687         <operator==>: Update with for removed field.
11688         <hash>: Likewise.
11689         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11690         <isa_features>: ...this.
11691         <abi_features>: New field.
11692         (riscv_isa_flen): Update comment.
11693         (riscv_abi_xlen): New declaration.
11694         (riscv_abi_flen): New declaration.
11695         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11696         isa_features.
11697         (riscv_abi_xlen): New function.
11698         (riscv_isa_flen): Update to get answer from isa_features.
11699         (riscv_abi_flen): New function.
11700         (riscv_has_fp_abi): Update to get answer from abi_features.
11701         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11702         xlen and flen.
11703         (riscv_call_info) <xlen, flen>: Update comment.
11704         (riscv_call_arg_struct): Remove invalid assertions
11705         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11706         is removed.
11707         (riscv_gdbarch_init): Gather isa features and abi features
11708         separately, ensure both match on the gdbarch when reusing an old
11709         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11710         a target with 64-bit float hardware.
11711
11712 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11713
11714         * source.c (search_command_helper): Stop reverse search
11715         when line 1 has been searched.
11716
11717 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11718
11719         * record-full.c (record_full_base_target::close): Rewrite
11720         record_full_core_buf_list free logic.
11721
11722 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11723
11724         * break-catch-syscall.c (print_one_catch_syscall): xfree
11725         the last text.
11726
11727 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11728
11729         * top.c (print_gdb_version): Update Copyright year in version
11730         message.
11731
11732 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11733
11734         Update copyright year range in all GDB files.
11735
11736 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11737
11738         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11739
11740 For older changes see ChangeLog-2018.
11741 \f
11742 Local Variables:
11743 mode: change-log
11744 left-margin: 8
11745 fill-column: 74
11746 version-control: never
11747 coding: utf-8
11748 End:
11749