gdb/ChangeLog

   1 2019-06-19  Tom de Vries  <tdevries@suse.de>
   2
   3         * dwarf2read.h (abstract_to_concrete): Change type to
   4         std::unordered_map<sect_offset, std::vector<sect_offset>,
   5         gdb::hash_enum<sect_offset>>.
   6
   7 2019-06-19  Tom Tromey  <tromey@adacore.com>
   8
   9         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  10         EVAL_AVOID_SIDE_EFFECTS specially.
  11
  12 2019-06-19  Tom Tromey  <tromey@adacore.com>
  13
  14         * source-cache.c (highlighter): New global.
  15         (source_cache::get_source_lines): Create a highlighter on demand.
  16
  17 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * defs.h (deprecated_interactive_hook): Delete declaration.
  20         * interps.c (clear_interpreter_hooks): Remove use of
  21         deprecated_interactive_hook.
  22         * top.c (deprecated_interactive_hook): Delete definition.
  23         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  24
  25 2019-06-18  Tom de Vries  <tdevries@suse.de>
  26
  27         PR gdb/24515
  28         * dwarf2read.h (abstract_to_concrete): Change type from
  29         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  30         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  31         * dwarf2read.c (read_variable): Update.
  32         (dwarf2_fetch_die_loc_sect_off): Update.
  33
  34 2019-06-17  Tom de Vries  <tdevries@suse.de>
  35
  36         PR gdb/24617
  37         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  38         accessing parent[parent_len - 1].
  39
  40 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  41
  42         PR gdb/24364
  43         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  44         call dtrace_process_dof with NULL dof.
  45
  46 2019-06-16  Tom de Vries  <tdevries@suse.de>
  47
  48         PR gdb/24445
  49         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  50
  51 2019-06-16  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  54         (make_all_visible): Use address of member.
  55
  56 2019-06-16  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  59         (tui_free_window, free_content, free_content_elements): Remove
  60         unnecessary cast.
  61         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  62         cast.
  63         * tui/tui-regs.c (tui_show_register_group)
  64         (tui_display_registers_from, tui_display_reg_element_at_line):
  65         Remove unnecessary cast.
  66
  67 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  68
  69         * linux-nat.c (normal_mask): Delete.
  70         (_initialize_linux_nat): Don't initialise normal_mask.
  71
  72 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         PR gdb/24445
  75         * dwarf-index-write.h (write_psymtabs_to_index): Add
  76         dwz_basename parameter.
  77         * dwarf-index-write.c (write_gdbindex): Move file writing to
  78         write_gdbindex_1.  Change return type void.
  79         (assert_file_size): Move up, remove filename parameter.
  80         (write_gdbindex_1): New function.
  81         (write_debug_names): Change return type to void, call
  82         assert_file_size.
  83         (struct index_wip_file): New struct.
  84         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  85         file logic to index_wip_file.  Write index for dwz file if
  86         needed.
  87         (save_gdb_index_command): Pass basename of dwz file, if present.
  88         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  89         build-id of dwz file, if present.
  90         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  91         (dwarf2_get_dwz_file): Likewise.
  92         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  93         (dwarf2_get_dwz_file): Likewise.
  94
  95 2019-06-16  Tom Tromey  <tom@tromey.com>
  96
  97         * coffread.c (process_coff_symbol): Use xstrdup.
  98         * value.c (create_internalvar): Use xstrdup.
  99
 100 2019-06-16  Tom Tromey  <tom@tromey.com>
 101
 102         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 103         * breakpoint.c (stopin_command, stopat_command)
 104         (until_break_command, decode_location_default): Remove unnecessary
 105         cast.
 106         * utils.c (subset_compare): Remove unnecessary cast.
 107         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 108         cast.
 109         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 110         cast.
 111         * infcmd.c (path_command): Remove unnecessary cast.
 112         * coffread.c (decode_type): Remove unnecessary cast.
 113         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 114         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 115         * tui/tui-stack.c (tui_show_locator_content)
 116         (tui_show_frame_info): Remove unnecessary cast.
 117         * tui/tui-win.c (tui_scroll_forward_command)
 118         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 119         (parse_scrolling_args): Remove unnecessary cast.
 120         * tui/tui-data.c (init_win_info, tui_del_window)
 121         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 122         (free_content_elements): Remove unnecessary cast.
 123         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 124         unnecessary cast.
 125         * tui/tui-source.c (tui_set_source_content)
 126         (tui_vertical_source_scroll): Remove unnecessary cast.
 127         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 128         cast.
 129         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 130         * tui/tui-regs.c (tui_display_registers_from)
 131         (tui_display_register): Remove unnecessary cast.
 132         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 133         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 134         (make_visible): Remove unnecessary cast.
 135         * tui/tui-winsource.c (tui_erase_source_content)
 136         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 137         unnecessary cast.
 138         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 139         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 140         * stabsread.c (read_type, read_array_type, read_range_type):
 141         Remove unnecessary cast.
 142         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 143         (parse_symbol, parse_type, upgrade_type, parse_external)
 144         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 145         unnecessary cast.
 146         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 147
 148 2019-06-16  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-data.c (tui_alloc_generic_win_info)
 151         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 152         checks.
 153
 154 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 155             Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * f-typeprint.c (f_print_type): Don't return early for not
 158         associated or not allocated types.
 159         (f_type_print_varspec_suffix): Add print_rank parameter and print
 160         ranks of array types in case they dangling.
 161         (f_type_print_base): Add print_rank parameter.
 162
 163 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * NEWS: Mention new MI commands.
 166         * break-catch-throw.c (enum exception_event_kind): Move to
 167         breakpoint.h.
 168         (print_mention_exception_catchpoint): Output text as a single
 169         message.
 170         (catch_exception_command_1): Rename to...
 171         (catch_exception_event): ...this, make non-static, update header
 172         command, and change some parameter types.
 173         (catch_catch_command): Update for changes to
 174         catch_exception_command_1.
 175         (catch_throw_command): Likewise.
 176         (catch_rethrow_command): Likewise.
 177         * breakpoint.c (enum exception_event_kind): Delete.
 178         * breakpoint.h (enum exception_event_kind): Moved here from
 179         break-catch-throw.c.
 180         (catch_exception_event): Declare.
 181         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 182         (mi_cmd_catch_throw): New function.
 183         (mi_cmd_catch_rethrow): New function.
 184         (mi_cmd_catch_catch): New function.
 185         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 186         'catch-catch' entries.
 187         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 188         (mi_cmd_catch_rethrow): Declare.
 189         (mi_cmd_catch_catch): Declare.
 190
 191 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 192
 193         * annotate.c (annotate_source_line): Change return type to void,
 194         update implementation to match.
 195         * annotate.h (annotate_source_line): Change return type to void,
 196         update header comment.
 197         * stack.c (print_frame_info): Don't change what frame information
 198         is printed based on whether annotations are on or not.
 199
 200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 203         (annotate_source): Make static.
 204         (annotate_source_line): Moved from source.c and renamed from
 205         identify_source_line.  Update the return type.
 206         * annotate.h (annotate_source): Delete declaration.
 207         (annotate_source_line): Declaration moved from source.h, and
 208         renamed from identify_source_line.  Return type updated.
 209         * source.c (identify_source_line): Moved to annotate.c and renamed
 210         to annotate_source_line.
 211         (info_line_command): Remove check of annotation_level.
 212         * source.h (identify_source_line): Move declaration to annotate.h
 213         and rename to annotate_source_line.
 214         * stack.c: Add 'annotate.h' include.
 215         (print_frame_info): Remove check of annotation_level before
 216         calling annotate_source_line.
 217
 218 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         * source-cache.c (source_cache::get_plain_source_lines): Use
 221         open_source_file_with_line_charpos instead of just
 222         open_source_file, remove call to find_source_lines.
 223         (source_cache::get_source_lines): Likewise.
 224         * source.c (find_source_lines): Make static.
 225         (get_filename_and_charpos): Renamed into...
 226         (open_source_file_with_line_charpos): ..this along with changes to
 227         return a scoped_fd, and some other minor clean ups.
 228         (identify_source_line): Use open_source_file_with_line_charpos.
 229         (search_command_helper): Use open_source_file_with_line_charpos
 230         instead of just open_source_file, remove call to
 231         find_source_lines.
 232         * source.h (open_source_file_with_line_charpos): Declare new
 233         function.
 234         (find_source_lines): Delete declaration.
 235
 236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * source.c (get_filename_and_charpos): Remove fullname
 239         parameter.
 240         (identify_source_line): Update call to get_filename_and_charpos.
 241
 242 2019-06-14  Tom Tromey  <tromey@adacore.com>
 243
 244         PR gdb/24502:
 245         * ui-style.h (skip_ansi_escape): Update comment.
 246         * ui-file.h (class no_terminal_escape_file): New class.
 247         * ui-file.c (no_terminal_escape_file::write)
 248         (no_terminal_escape_file::puts): New methods.
 249         * cli/cli-logging.c (handle_redirections): Use
 250         no_terminal_escape_file.
 251
 252 2019-06-14  Tom Tromey  <tromey@adacore.com>
 253
 254         * NEWS: Move convenience variable news above Python news.
 255
 256 2019-06-14  Tom Tromey  <tom@tromey.com>
 257
 258         * gnulib: Move directory to top-level.
 259         * configure.ac: Don't configure gnulib.
 260         * configure: Rebuild.
 261         * common/common-defs.h: Use new path to gnulib.
 262         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 263         (GNULIB_H): Remove.
 264         (INCGNU): Look in new gnulib location.
 265         (HFILES_NO_SRCDIR): Remove gnulib files.
 266         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 267         (generated_files): Remove GNULIB_H.
 268         ($(LIBGNU), all-lib): Remove targets.
 269         (distclean): Don't mention GNULIB_BUILDDIR.
 270         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 271
 272 2019-06-14  Tom Tromey  <tromey@adacore.com>
 273
 274         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 275         Warn if symbol file does not provide any symbols.
 276
 277 2019-06-14  Tom Tromey  <tromey@adacore.com>
 278
 279         * source.c (find_and_open_source): Respect basenames_may_differ.
 280
 281 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * annotate.c (annotate_breakpoints_invalid): Make use of
 284         scoped_restore_terminal_state.
 285         (annotate_frames_invalid): Likewise.
 286
 287 2019-06-14  Tom Tromey  <tromey@adacore.com>
 288
 289         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 290         allow assignment to an internalvar.
 291
 292 2019-06-14  Tom Tromey  <tromey@adacore.com>
 293
 294         * ada-lex.l: Allow "_" in attribute names.
 295
 296 2019-06-14  Tom Tromey  <tromey@adacore.com>
 297
 298         PR gdb/24653:
 299         * regcache.c (registers_changed): Don't call alloca.
 300         * top.c (execute_command): Don't call alloca.
 301
 302 2019-06-13  Pedro Alves  <palves@redhat.com>
 303
 304         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 305         'expression'.  When parsing an expression, error out if there's
 306         junk after "unlimited".
 307         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 308         (do_set_command): Adjust calls to is_unlimited_literal.
 309
 310 2019-06-13  Pedro Alves  <palves@redhat.com>
 311
 312         * compile/compile.c (make_compile_options_def_group): Add braces
 313         around array_view initializer.
 314         * thread.c (make_thread_apply_all_options_def_group)
 315         (make_thread_apply_all_options_def_group): Likewise.
 316
 317 2019-06-13  Pedro Alves  <palves@redhat.com>
 318
 319         * NEWS (New commands): Mention "maint test-options
 320         require-delimiter", "maint test-options unknown-is-error", "maint
 321         test-options unknown-is-operand" and "maint show
 322         test-options-completion-result".
 323         (New command options, command completion): New section.
 324         (Completion improvements): New section.
 325         Mention that you can abbreviate "unlimited".
 326
 327 2019-06-13  Pedro Alves  <palves@redhat.com>
 328
 329         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 330         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 331         * unittests/cli-utils-selftests.c (test_parse_flags)
 332         (test_parse_flags_qcs): Delete.
 333         (test_cli_utils): Don't call deleted functions.
 334
 335 2019-06-13  Pedro Alves  <palves@redhat.com>
 336
 337         * thread.c: Include "cli/cli-option.h".
 338         (tp_array_compar_ascending): Global.
 339         (tp_array_compar): Delete function.
 340         (tp_array_compar_ascending, tp_array_compar_descending): New
 341         functions.
 342         (ascending_option_def, qcs_flag_option_def)
 343         (thr_qcs_flags_option_defs)
 344         (make_thread_apply_all_options_def_group)
 345         (make_thread_apply_options_def_group): New.
 346         (thread_apply_all_command): Use gdb::option::process_options.
 347         (thread_apply_command_completer)
 348         (thread_apply_all_command_completer): New.
 349         (thread_apply_command): Use gdb::option::process_options.
 350         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 351         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 352         to generate help text of "thread apply".  Adjust "taas"'s help.
 353         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 354         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 355
 356 2019-06-13  Pedro Alves  <palves@redhat.com>
 357
 358         * thread.c (thread_apply_command): Check for invalid TID with
 359         isdigit instead of !isalpha.
 360
 361 2019-06-13  Pedro Alves  <palves@redhat.com>
 362
 363         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 364         (validate_flags_qcs): New.
 365         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 366         (validate_flags_qcs): Declare.
 367         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 368         (make_frame_apply_options_def_group): New.
 369         (frame_apply_command_count): Process options with
 370         gdb::option::process_options.
 371         (frame_apply_completer): New.
 372         (frame_apply_level_completer, frame_apply_all_completer)
 373         (frame_apply_completer): New.
 374         (_initialize_stack): Update help of "frame apply", "frame apply
 375         level", "frame apply all" and "faas" to mention supported options
 376         and install command completers.
 377         * stack.h (frame_apply_all_completer): Declare.
 378         * thread.c: Include "stack.h".
 379         (tfaas_command): Add "--".
 380         (_initialize_thread): Update help "tfaas" to mention supported
 381         options and install command completer.
 382
 383 2019-06-13  Pedro Alves  <palves@redhat.com>
 384
 385         * completer.c (complete_nested_command_line): New.
 386         (gdb_completion_word_break_characters_throw): Add assertion.
 387         * completer.h (complete_nested_command_line): Declare.
 388
 389 2019-06-13  Pedro Alves  <palves@redhat.com>
 390
 391         * stack.c (parse_backtrace_qualifiers): New.
 392         (backtrace_command): Use it.
 393         (backtrace_command_completer): Complete on qualifiers.
 394
 395 2019-06-13  Pedro Alves  <palves@redhat.com>
 396
 397         * frame.c: Include "cli/cli-option.h.
 398         (user_set_backtrace_options): New.
 399         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 400         Delete.
 401         (get_prev_frame): Adjust.
 402         (boolean_option_def, uinteger_option_def)
 403         (set_backtrace_option_defs): New.
 404         (_initialize_frame): Adjust and use
 405         gdb::option::add_setshow_cmds_for_options to install "set
 406         backtrace past-main" and "set backtrace past-entry".
 407         * frame.h: Include "cli/cli-option.h".
 408         (struct frame_print_options): Forward declare.
 409         (print_frame_arguments_all, print_frame_arguments_scalars)
 410         (print_frame_arguments_none): Declare.
 411         (print_entry_values): Delete declaration.
 412         (struct frame_print_options, user_frame_print_options): New.
 413         (struct set_backtrace_options): New.
 414         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 415         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 416         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 417         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 418         (list_args_or_locals): Add frame_print_options parameter.
 419         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 420         * python/py-framefilter.c (enumerate_args): Pass down
 421         USER_FRAME_PRINT_OPTIONS.
 422         * stack.c: Include "cli/cli-option.h".
 423         (print_frame_arguments_all, print_frame_arguments_scalars)
 424         (print_frame_arguments_none): Declare.
 425         (print_raw_frame_arguments, print_entry_values): Delete.
 426         (user_frame_print_options): New.
 427         (boolean_option_def, enum_option_def, frame_print_option_defs):
 428         New.
 429         (struct backtrace_cmd_options): New.
 430         (bt_flag_option_def): New.
 431         (backtrace_command_option_defs): New.
 432         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 433         (print_frame_arg, read_frame_arg, print_frame_args)
 434         (print_frame_info, print_frame): Add frame_print_options parameter
 435         and use it.
 436         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 437         (backtrace_command_1): Add frame_print_options and
 438         backtrace_cmd_options parameters and use them.
 439         (make_backtrace_options_def_group): New.
 440         (backtrace_command): Process command options with
 441         gdb::option::process_options.
 442         (backtrace_command_completer): New.
 443         (_initialize_stack): Extend "backtrace"'s help to mention
 444         supported options.  Install completer for "backtrace".
 445         Install some settings commands with add_setshow_cmds_for_options.
 446
 447 2019-06-13  Pedro Alves  <palves@redhat.com>
 448
 449         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 450         and that "set/show print raw frame-arguments" are now deprecated.
 451
 452         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 453         command.
 454         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 455         * stack.c (_initialize_stack): Install "set/show print
 456         raw-frame-arguments", and deprecate "set/show print raw
 457         frame-arguments".
 458         * valprint.c (_initialize_valprint): Deprecate "set/show print
 459         raw".
 460
 461 2019-06-13  Pedro Alves  <palves@redhat.com>
 462
 463         * compile/compile.c (struct compile_options): New.
 464         (compile_flag_option_def, compile_command_option_defs)
 465         (make_compile_options_def_group): New.
 466         (compile_file_command): Handle options with
 467         gdb::option::process_options.
 468         (compile_file_command_completer): New function.
 469         (compile_code_command): Handle options with
 470         gdb::option::process_options.
 471         (compile_code_command_completer): New function.
 472         (_initialize_compiler): Install completers for "compile code" and
 473         "compile file".  Mention available options in "compile code" and
 474         "compile code"'s help.
 475         * completer.c (advance_to_completion_word): New, factored out from
 476         ...
 477         (advance_to_expression_complete_word_point): ... this.
 478         (advance_to_filename_complete_word_point): New.
 479         * completer.h (advance_to_filename_complete_word_point): New
 480         declaration.
 481
 482 2019-06-13  Pedro Alves  <palves@redhat.com>
 483
 484         * compile/compile.c: Include "cli/cli-option.h".
 485         (compile_print_value): Scope data pointer is now a
 486         value_print_options pointer; adjust.
 487         (compile_print_command): Process options.  Scope data pointer is
 488         now a value_print_options pointer; adjust.
 489         (_initialize_compile): Update "compile print"'s help to include
 490         supported options.  Install a completer for "compile print".
 491         * cp-valprint.c (show_vtblprint, show_objectprint)
 492         (show_static_field_print): Delete.
 493         (_initialize_cp_valprint): Don't install "set print
 494         static-members", "set print vtbl", "set print object" here.
 495         * printcmd.c: Include "cli/cli-option.h" and
 496         "common/gdb_optional.h".
 497         (print_command_parse_format): Rework to fill in a
 498         value_print_options instead of a format_data.
 499         (print_value): Change parameter type from format_data pointer to
 500         value_print_options reference.  Adjust.
 501         (print_command_1): Process options.  Adjust to pass down a
 502         value_print_options.
 503         (print_command_completer): New.
 504         (_initialize_printcmd): Install print_command_completer as
 505         handle_brkchars completer for the "print" command.  Update
 506         "print"'s help to include supported options.
 507         * valprint.c: Include "cli/cli-option.h".
 508         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 509         here from cp-valprint.c.
 510         (boolean_option_def, uinteger_option_def)
 511         (value_print_option_defs, make_value_print_options_def_group):
 512         New.  Use gdb::option::add_setshow_cmds_for_options to install
 513         "set print elements", "set print null-stop", "set print repeats",
 514         "set print pretty", "set print union", "set print array", "set
 515         print address", "set print symbol", "set print array-indexes".
 516         * valprint.h: Include <string> and "cli/cli-option.h".
 517         (make_value_print_options_def_group): Declare.
 518         (print_value): Change parameter type from format_data pointer to
 519         value_print_options reference.
 520         (print_command_completer): Declare.
 521
 522 2019-06-13  Pedro Alves  <palves@redhat.com>
 523
 524         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 525         (COMMON_SFILES): Add maint-test-settings.c.
 526         * cli/cli-decode.c (boolean_enums): New global, factored out from
 527         ...
 528         (add_setshow_boolean_cmd): ... here.
 529         * cli/cli-decode.h (boolean_enums): Declare.
 530         * cli/cli-option.c: New file.
 531         * cli/cli-option.h: New file.
 532         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 533         factored out from ...
 534         (parse_cli_boolean_value(const char *)): ... this.
 535         (is_unlimited_literal): Change parameter type to pointer to
 536         pointer.  Adjust and advance ARG pointer.
 537         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 538         (parse_cli_var_enum): New, factored out from ...
 539         (do_set_command): ... this.  Adjust.
 540         * cli/cli-setshow.h (parse_cli_boolean_value)
 541         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 542         (parse_cli_var_enum): Declare.
 543         * cli/cli-utils.c: Include "cli/cli-option.h".
 544         (get_ulongest): New.
 545         * cli/cli-utils.h (get_ulongest): Declare.
 546         (check_for_argument): New overloads.
 547         * maint-test-options.c: New file.
 548
 549 2019-06-13  Pedro Alves  <palves@redhat.com>
 550
 551         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 552         parse a range if "-" is at the end of the string.
 553
 554 2019-06-13  Pedro Alves  <palves@redhat.com>
 555
 556         * cli/cli-setshow.c (parse_auto_binary_operation)
 557         (parse_cli_boolean_value): Don't allow "o".
 558
 559 2019-06-13  Pedro Alves  <palves@redhat.com>
 560
 561         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 562         * NEWS: Mention maint test-settings KIND.
 563         * maint-test-settings.c: New file.
 564
 565 2019-06-13  Pedro Alves  <palves@redhat.com>
 566
 567         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 568         completer.
 569         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 570         "set" completers.
 571
 572 2019-06-13  Pedro Alves  <palves@redhat.com>
 573
 574         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 575         after item.
 576
 577 2019-06-13  Pedro Alves  <palves@redhat.com>
 578
 579         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 580
 581 2019-06-13  Pedro Alves <palves@redhat.com>
 582
 583         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 584         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 585         call.
 586         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 587         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 588         calls.
 589         (check_for_argument): Skip spaces after argument.
 590
 591 2019-06-13  Pedro Alves  <palves@redhat.com>
 592
 593         * thread.c (thread_apply_command): Adjust TID parsing.
 594         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 595         detected before end of string.
 596         (tid_is_in_list): Error out if LIST is invalid.
 597
 598 2019-06-13  Pedro Alves  <palves@redhat.com>
 599
 600         * completer.c (complete_line_internal_1): Rewind completion word
 601         point.
 602         (completion_tracker::advance_custom_word_point_by): Change
 603         parameter type to int.
 604         * completer.h (completion_tracker::advance_custom_word_point_by):
 605         Likewise.
 606
 607 2019-06-13  Pedro Alves  <palves@redhat.com>
 608
 609         * completer.c (advance_to_completion_word): Handle delimiters.
 610
 611 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 612
 613         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 614
 615 2019-06-11  Tom Tromey  <tom@tromey.com>
 616
 617         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 618         (xmalloc_failed): Move to alloc.c.
 619         * alloc.c: New file.
 620         * Makefile.in (COMMON_SFILES): Add alloc.c.
 621
 622 2019-06-11  Tom Tromey  <tom@tromey.com>
 623
 624         * nat/linux-waitpid.c: Don't include server.h.
 625         (linux_debug): Remove.
 626         (my_waitpid): Update.
 627
 628 2019-06-11  Tom Tromey  <tromey@adacore.com>
 629
 630         * infcall.c (_initialize_infcall): Remove trailing newline from
 631         help.
 632         * user-regs.c (_initialize_user_regs): Remove trailing newline
 633         from help.
 634         * typeprint.c (_initialize_typeprint): Remove trailing newline
 635         from help.
 636         * reverse.c (_initialize_reverse): Remove trailing newlines from
 637         help.
 638         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 639         from help.
 640         * language.c (add_set_language_command): Remove trailing newline
 641         from help.
 642         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 643         help.
 644         * disasm.c (_initialize_disasm): Remove trailing newline from
 645         help.
 646         * top.c (init_main): Remove trailing newline from help.
 647         * interps.c (_initialize_interpreter): Remove trailing newline
 648         from help.
 649         * btrace.c (_initialize_btrace): Remove trailing newlines from
 650         help.
 651         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 652         from help.
 653         * python/python.c (_initialize_python): Remove trailing newline
 654         from help.
 655         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 656         help.
 657         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 658         from help.  Reformat some text.
 659         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 660         from help.
 661         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 662         newline from help.
 663
 664 2019-06-11  Tom Tromey  <tromey@adacore.com>
 665
 666         * darwin-nat.c (darwin_decode_exception_message)
 667         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 668
 669 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * valops.c (value_slice): Check for not allocated or not
 672         associated values.
 673
 674 2019-06-10  Tom de Vries  <tdevries@suse.de>
 675
 676         PR gdb/24618
 677         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 678         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 679         invalid.
 680
 681 2019-06-10  Tom de Vries  <tdevries@suse.de>
 682
 683         PR gdb/24611
 684         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 685         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 686
 687 2019-06-10  Tom de Vries  <tdevries@suse.de>
 688
 689         PR symtab/24545
 690         * symtab.c (struct demangled_name_entry): Add language field.
 691         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 692         static minimal symbol".  Set and use language field.
 693
 694 2019-06-10  Tom Tromey  <tromey@adacore.com>
 695
 696         * ada-lang.c (_initialize_ada_language): Update help text.
 697
 698 2019-06-10  Tom Tromey  <tromey@adacore.com>
 699
 700         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 701         with a newline.
 702         * guile/guile.c (handle_boot_error): Don't end warning with a
 703         newline.
 704         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 705         warning with a newline.
 706         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 707         newline.
 708         (s12z_frame_cache): Likewise.
 709         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 710         a newline.
 711         * solib-svr4.c (disable_probes_interface): Don't end warning with
 712         a newline.
 713         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 714         newline.
 715         * python/python.c (do_finish_initialization): Don't end warning
 716         with a newline.
 717
 718 2019-06-10  Tom Tromey  <tom@tromey.com>
 719
 720         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 721         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 722         gdbpy_enter.
 723
 724 2019-06-10  Tom Tromey  <tromey@adacore.com>
 725
 726         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 727         data.
 728         (elf_new_init): Don't call stabsread_new_init.
 729         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 730         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 731         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 732
 733 2019-06-10  Tom de Vries  <tdevries@suse.de>
 734
 735         PR symtab/16264
 736         PR symtab/24517
 737         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 738
 739 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 740
 741         * source.c (find_and_open_source): Also rewrite relative file
 742         names.
 743
 744 2019-04-26  Amos Bird  <amosbird@gmail.com>
 745
 746         * annotate.c (annotate_thread_exited): Add "thread-exited"
 747         annotation.
 748
 749 2019-06-06  Tom Tromey  <tromey@adacore.com>
 750
 751         * maint.h (class scoped_command_stats): Use
 752         DISABLE_COPY_AND_ASSIGN.
 753         <print_time>: New method.
 754         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 755         print_time.
 756         (scoped_command_stats::print_time): New method.
 757
 758 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 761         instructions of lengths 6 or 8 bytes.
 762
 763 2019-06-04  Pedro Alves  <palves@redhat.com>
 764
 765         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 766
 767         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 768         * breakpoint.c (condition_completer): Likewise.
 769         * cli/cli-dump.c (scan_expression): Likewise.
 770         * common/filestuff.c (mkdir_recursive): Likewise.
 771         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 772         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 773         (gdb_abspath): Likewise.
 774         * compile/compile-cplus-types.c
 775         (compile_cplus_instance::decl_name): Likewise.
 776         * completer.c (complete_explicit_location):
 777         (signal_completer, reg_or_group_completer_1): Likewise.
 778         * cp-support.c (cp_remove_params_if_any): Likewise.
 779         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 780         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 781         * infcmd.c (strip_bg_char): Likewise.
 782         * linespec.c (copy_token_string): Likewise.
 783         * mi/mi-main.c (output_cores): Likewise.
 784         * psymtab.c (psymtab_search_name):
 785         * symfile.c (test_set_ext_lang_command): Likewise.
 786         * target.c (target_fileio_read_stralloc): Likewise.
 787         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 788         * value.c (complete_internalvar): Likewise.
 789
 790 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 791
 792         Add objfile property to gdb.Type.
 793         * NEWS: Mention Python API addition.
 794         * python/py-type.c (typy_get_objfile): New method.
 795
 796 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 797
 798         * NEWS: Mention the new set|show style [title|highlight].
 799         Mention changes to "show style", "help" and "apropos".
 800
 801 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 802
 803         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 804         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 805         instead of print_help_for_command.
 806         (print_doc_of_command): New function.
 807         (help_list): Add 'apropos -v word' suggestion.
 808         (print_help_for_command): Style the command name using title style.
 809         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 810         (_initialize_cli_cmds): Describe -v in apropos_command help.
 811
 812 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813
 814         * cli/cli-style.h (cli_style_option): Add name in constructor,
 815         add m_name class member, add constructor with intensity,
 816         add name class function.
 817         (cli_style_option::add_setshow_commands): Remove name argument.
 818         (highlight_style, title_style): New styles.
 819         * cli/cli-style.c (do_show): New function that shows a style
 820         characteristic styling the style name with itself.
 821         (set_style_name): New function.
 822         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 823         Update all callers according to the changes in cli/cli-style.h.
 824         * utils.h (fputs_highlighted): New function.
 825         * utils.c (fputs_highlighted): Likewise.
 826
 827 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 828
 829         * NEWS: Mention new pipe command and new convenience variables.
 830
 831 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 832
 833         * cli/cli-cmds.c (pipe_command): New function.
 834         (_initialize_cli_cmds): Call add_com for pipe_command.
 835         Define | as an alias for pipe.
 836         (exit_status_set_internal_vars): New function.
 837         (shell_escape): Call exit_status_set_internal_vars.
 838         cli/cli-decode.c (find_command_name_length): Recognize | as
 839         a single character command.
 840
 841 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 842
 843         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 844         top.c (execute_command_to_ui_file): New function, mostly a copy
 845         of execute_command_to_string.
 846         (execute_command_to_string): Implement by calling
 847         execute_command_to_ui_file.
 848
 849 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * top.h (saved_command_line): Remove declaration.
 852         * top.c (previous_saved_command_line, previous_repeat_arguments):
 853         New variables.
 854         (saved_command_line): Make static, define together with other
 855         'repeat variables'.
 856         (dont_repeat): Clear repeat_arguments.
 857         (repeat_previous, get_saved_command_line, save_command_line):
 858         New functions.
 859         (gdb_init): Initialize saved_command_line
 860         and previous_saved_command_line.
 861         * main.c (captured_main_1): Remove saved_command_line initialization.
 862         * event-top.c (handle_line_of_input): Update to use
 863         the new 'repeat' related functions instead of direct access to
 864         saved_command_line.
 865         * command.h (repeat_previous, get_saved_command_line,
 866         save_command_line): New declarations.
 867         (dont_repeat): Add comment.
 868
 869 2019-05-30  Tom Tromey  <tromey@adacore.com>
 870
 871         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 872         Fix comment.
 873         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 874
 875 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 876
 877         PR cli/24587
 878         * completer.c (complete): Initialize variable word.
 879
 880 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 881
 882         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 883         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 884         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 885         'body' is NULL to the outter 'if', protecting the '!is_define'
 886         situation as well.
 887
 888 2019-05-29  Tom Tromey  <tromey@adacore.com>
 889
 890         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 891         (dwarf_unknown): New function.
 892         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 893         (dwarf_type_encoding_name): Use dwarf_unknown.
 894
 895 2019-05-29  Tom Tromey  <tromey@adacore.com>
 896
 897         PR c++/20020:
 898         * cp-valprint.c (cp_print_value_fields): Call
 899         cp_print_static_field inside "try".
 900
 901 2019-05-29  Tom Tromey  <tromey@adacore.com>
 902
 903         * inflow.c (struct terminal_info): Add default operator=.
 904         * configure: Rebuild.
 905         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 906         -Wdeprecated-copy-dtor, -Wredundant-move.
 907
 908 2019-05-29  Tom Tromey  <tromey@adacore.com>
 909
 910         * NEWS: Add entry.
 911         * infcmd.c (print_return_value_1): Handle finish_print
 912         option.
 913         (show_print_finish): New function.
 914         (_initialize_infcmd): Add "set/show print finish" commands.
 915         * valprint.c (user_print_options): Initialize new member.
 916         * valprint.h (struct value_print_options) <finish_print>: New
 917         member.
 918
 919 2019-05-28  Tom Tromey  <tromey@adacore.com>
 920
 921         * ada-lang.c (ada_remove_Xbn_suffix)
 922         (find_old_style_renaming_symbol)
 923         (parse_old_style_renaming): Remove.
 924         (ada_find_renaming_symbol): Don't call
 925         find_old_style_renaming_symbol.
 926         (ada_is_renaming_symbol): Rename from
 927         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 928         bool.  Now static.
 929         (ada_read_var_value): Update and simplify.
 930         * ada-exp.y (write_var_or_type): Remove old code.
 931
 932 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 933
 934         * event-top.c: Remove include comment.
 935         * inflow.c (class scoped_ignore_sigttou): Move from here...
 936         * inflow.h (class scoped_ignore_sigttou): ...to here.
 937         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 938         * top.c:  Remove include comment.
 939
 940 2019-05-27  Tom Tromey  <tom@tromey.com>
 941
 942         * NEWS: Fix typo.
 943
 944 2019-05-22  Tom Tromey  <tromey@adacore.com>
 945
 946         * target.c (target_follow_exec): Constify parameter.
 947         * target-delegates.c: Rebuild.
 948         * remote.c (remote_target::follow_exec): Constify parameter.
 949         * infrun.c (follow_exec): Constify parameter.
 950         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 951         (target_follow_exec): Likewise.
 952
 953 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 954
 955         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 956         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 957
 958 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 959
 960         * NEWS: Add debugredirect and testsuite sections.
 961
 962 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 963
 964         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 965         target descriptions using exclusively floating point register name
 966         aliases.
 967
 968 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         PR gdb/18644:
 971         * f-lang.c (build_fortran_types): Handle the case where
 972         gdbarch_floatformat_for_type returns a nullptr.
 973
 974 2019-05-21  Tom de Vries  <tdevries@suse.de>
 975
 976         PR cli/24587
 977         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 978
 979 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         PR gdb/18644:
 982         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 983         16-byte floats.
 984         * i386-tdep.c (i386_floatformat_for_type): Use
 985         floatformats_ia64_quad for the 16-byte floating point component
 986         within a fortran 32-byte complex number.
 987
 988 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 989
 990         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 991         delete default constructor.
 992         (find_partial_die): Update to return const struct.
 993         (partial_die_parent_scope): Move variable declaration into scope
 994         of its use and change its type to auto.
 995         (guess_partial_die_structure_name): Likewise.
 996         (partial_die_info::fixup): Likewise.
 997
 998 2019-05-17  Tom Tromey  <tromey@adacore.com>
 999
1000         * source.c (find_and_open_source): Remove cast.
1001
1002 2019-05-17  Tom Tromey  <tromey@adacore.com>
1003
1004         * annotate.c (annotate_source): Make "filename" const.
1005         * annotate.h (annotate_source): Use const.
1006
1007 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1008
1009         * disasm.c (set_disassembler_options): Send errors to stderr.
1010
1011 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1014         (cli_interp_base::set_logging): Check debug_redirect.
1015         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1016         * cli/cli-logging.c (debug_redirect): Add static variable.
1017         (pop_output_files): Add default param.
1018         (handle_redirections): Print debug setting.
1019         (show_logging_command): Likewise.
1020         (_initialize_cli_logging): Add debugredirect command.
1021         * interps.c (current_interp_set_logging): Add debug_redirect
1022         parameter.
1023         * interps.h (set_logging): Add debug_redirect parameter.
1024         (current_interp_set_logging): Likewise.
1025         * mi/mi-common.h: Likewise.
1026         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1027
1028 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1029             Tom Tromey  <tromey@adacore.com>
1030
1031         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1032         directly.
1033         * cli/cli-interp.h (make_logging_output): Remove declaration.
1034         * cli/cli-logging.c (make_logging_output): Remove function.
1035         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1036         directly.
1037         * ui-file.c (tee_file::tee_file): Remove bools.
1038         (tee_file::~tee_file): Remove deletes.
1039         * ui-file.h (tee_file): Remove bools.
1040
1041 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1042
1043         * mi/mi-cmds.h (mi_cmd_complete): New function.
1044         * mi/mi-main.c (mi_cmd_complete): Likewise.
1045         * mi/mi-cmds.c: Define new MI command -complete.
1046         * NEWS: Mention new -complete command.
1047
1048 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1049
1050         * completer.h (complete): New function.
1051         * completer.c (complete): Likewise.
1052         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1053         function defined in completer.h.
1054
1055 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1056
1057         * MAINTAINERS (Write After Approval): Add myself.
1058
1059 2019-05-17  Tom de Vries  <tdevries@suse.de>
1060
1061         PR gdb/24094
1062         * dwarf2read.c (struct cu_partial_die_info): New struct.
1063         (find_partial_die): Return cu_partial_die_info.
1064         (partial_die_parent_scope, guess_partial_die_structure_name)
1065         (partial_die_info::fixup): Handle new return type of find_partial_die.
1066
1067 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1068
1069         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1070         "std::string", simplifying the algorithm.
1071
1072 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1073
1074         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1075         (stap_static_probe_ops::get_probes): Likewise.
1076
1077 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1078
1079         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1080         '-')" and "else if".
1081         (stap_parse_single_operand): Join checks for
1082         "gdbarch_stap_parse_special_token_p" and
1083         "gdbarch_stap_parse_special_token" in the same "if" statement.
1084         Invert check when verifying for operation on register
1085         displacement.
1086
1087 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1088
1089         * stap-probe.c (stap_get_opcode): Update comment.
1090         (stap_get_expected_argument_type): Likewise.
1091         (handle_stap_probe): Likewise.
1092
1093 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1094
1095         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1096         return type to 'bool'.  Adjust comment.  Use 'bool' when
1097         appropriate.
1098         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1099         * stap-probe.c (stap_parse_argument_1): Likewise.
1100         (stap_is_operator): Likewise.
1101         (stap_is_generic_prefix): Likewise.
1102         (stap_is_register_prefix): Likewise.
1103         (stap_is_register_indirection_prefix): Likewise.
1104         (stap_is_integer_prefix): Likewise.
1105         (stap_generic_check_suffix): Likewise.
1106         (stap_check_integer_suffix): Likewise.
1107         (stap_check_register_suffix): Likewise.
1108         (stap_check_register_indirection_suffix): Likewise.
1109         (stap_parse_register_operand): Likewise.
1110         (stap_parse_single_operand): Likewise.
1111         (stap_parse_argument_1): Likewise.
1112         (stap_probe::get_argument_count): Likewise.
1113         (stap_is_operator): Likewise.
1114
1115 2019-05-16  Tom Tromey  <tromey@adacore.com>
1116
1117         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1118         keyword to foreach.
1119
1120 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1121
1122         * linux-thread-db.c (try_thread_db_load_1): Change return type
1123         to bool.
1124         (try_thread_db_load): Likewise.
1125         (try_thread_db_load_from_pdir_1): Likewise.
1126         (try_thread_db_load_from_pdir): Likewise.
1127         (try_thread_db_load_from_sdir): Likewise.
1128         (try_thread_db_load_from_dir): Likewise.
1129         (thread_db_load_search): Likewise.
1130         (has_libpthread): Likewise.
1131         (thread_db_load): Likewise.
1132
1133 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1134
1135         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1136         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1137         NULL, and complain/return if that's the case.
1138
1139 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1140
1141         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1142         (advance, posn, abstract_read_memory): New functions.
1143         [struct mem_read_abstraction]: New struct.
1144         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1145
1146 2019-05-14  Tom Tromey  <tromey@adacore.com>
1147
1148         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1149         value is not lval_memory.
1150
1151 2019-05-14  Tom Tromey  <tromey@adacore.com>
1152
1153         * solib.c (info_sharedlibrary_command): Style the file name.
1154
1155 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1156
1157         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1158         (aarch64_vnv_type): Likewise.
1159         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1160         * common/tdesc.c: Likewise.
1161         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1162         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1163         * features/aarch64-fpu.xml: Add ieee half view.
1164         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1165         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1166         * gdbtypes.h (struct builtin_type): Likewise.
1167         (struct objfile_type): Likewise.
1168
1169 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1170
1171         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1172         typo.
1173         * location.h (string_to_event_location): Likewise.
1174
1175 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1176
1177         GDB 8.3 released.
1178
1179 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1180
1181         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1182         New variable declaration.
1183         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1184         New variable.
1185         (print_one_breakpoint): Use ui_out::test_flags and new global
1186         variable to compute use_fixed_output.
1187         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1188         Remove.
1189         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1190         (mi_multi_location_breakpoint_output_fixed): Remove.
1191         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1192         new variable.
1193         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1194         fix_multi_location_breakpoint_output flag if version >= 3.
1195         * ui-out.h (enum ui_out_flag)
1196         <fix_multi_location_breakpoint_output>: New enumerator.
1197
1198 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1199
1200         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1201
1202 2019-05-10  Tom Tromey  <tromey@adacore.com>
1203
1204         * ada-lang.c (catch_ada_completer): New function.
1205         (_initialize_ada_language): Use it.
1206
1207 2019-05-10  Tom Tromey  <tromey@adacore.com>
1208
1209         * thread.c (print_thread_info): Make "requested_threads" const.
1210         * gdbthread.h (print_thread_info): Make "requested_threads"
1211         const.
1212         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1213         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1214
1215 2019-05-08  Tom Tromey  <tom@tromey.com>
1216
1217         * gdbtypes.c (objfile_type_data): Change type.
1218         (objfile_type, _initialize_gdbtypes): Update.
1219
1220 2019-05-08  Tom Tromey  <tom@tromey.com>
1221
1222         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1223         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1224         (_initialize_dwarf2_frame): Update.
1225
1226 2019-05-08  Tom Tromey  <tom@tromey.com>
1227
1228         * objc-lang.c (objc_objfile_data): Change type.
1229         (find_methods): Update.
1230         (_initialize_objc_lang): Remove.
1231
1232 2019-05-08  Tom Tromey  <tom@tromey.com>
1233
1234         * stabsread.c (rs6000_builtin_type_data): Change type.
1235         (rs6000_builtin_type, _initialize_stabsread): Update.
1236
1237 2019-05-08  Tom Tromey  <tom@tromey.com>
1238
1239         * mips-tdep.c (mips_pdr_data): Remove.
1240         (_initialize_mips_tdep): Update.
1241
1242 2019-05-08  Tom Tromey  <tom@tromey.com>
1243
1244         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1245         (hppa_init_objfile_priv_data, read_unwind_info)
1246         (find_unwind_entry, _initialize_hppa_tdep): Update.
1247
1248 2019-05-08  Tom Tromey  <tom@tromey.com>
1249
1250         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1251         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1252         on obstack.
1253         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1254
1255 2019-05-08  Tom Tromey  <tom@tromey.com>
1256
1257         * mdebugread.c (basic_type_data): Change type.
1258         (basic_type, _initialize_mdebugread): Update.
1259
1260 2019-05-08  Tom Tromey  <tom@tromey.com>
1261
1262         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1263
1264 2019-05-08  Tom Tromey  <tom@tromey.com>
1265
1266         * nto-tdep.c (nto_inferior_data_reg): Change type.
1267         (nto_inferior_data): Update.
1268         (nto_inferior_data_cleanup, nto_new_inferior_data)
1269         (_initialize_nto_tdep): Remove.
1270         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1271
1272 2019-05-08  Tom Tromey  <tom@tromey.com>
1273
1274         * ada-lang.c (struct ada_inferior_data): Add initializers.
1275         (ada_inferior_data): Change type.
1276         (ada_inferior_data_cleanup): Remove.
1277         (get_ada_inferior_data, ada_inferior_exit)
1278         (struct ada_pspace_data): Add initializers, destructor.
1279         (ada_pspace_data_handle): Change type.
1280         (get_ada_pspace_data): Update.
1281         (ada_pspace_data_cleanup): Remove.
1282
1283 2019-05-08  Tom Tromey  <tom@tromey.com>
1284
1285         * coffread.c (struct coff_symfile_info): Add initializers.
1286         (coff_objfile_data_key): Move lower.  Change type.
1287         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1288         Update.
1289         (coff_free_info): Remove.
1290
1291 2019-05-08  Tom Tromey  <tom@tromey.com>
1292
1293         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1294         (fbsd_pspace_data_handle): Move lower.  Change type.
1295         (get_fbsd_pspace_data): Update.
1296         (fbsd_pspace_data_cleanup): Remove.
1297         (_initialize_fbsd_tdep): Update.
1298
1299 2019-05-08  Tom Tromey  <tom@tromey.com>
1300
1301         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1302         (get_ada_tasks_pspace_data): Update.
1303         (ada_tasks_pspace_data_cleanup): Remove.
1304         (_initialize_tasks): Update.
1305         (ada_tasks_inferior_data_handle): Change type.
1306         (get_ada_tasks_inferior_data): Update.
1307         (ada_tasks_inferior_data_cleanup): Remove.
1308         (struct ada_tasks_pspace_data): Add initializers.
1309
1310 2019-05-08  Tom Tromey  <tom@tromey.com>
1311
1312         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1313         * symfile-debug.c (debug_sym_get_probes): Change type.
1314         * stap-probe.c (handle_stap_probe):
1315         (stap_static_probe_ops::get_probes): Change type.
1316         * probe.h (class static_probe_ops) <get_probes>: Change type.
1317         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1318         (parse_probes_in_pspace): Update.
1319         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1320         Update.
1321         (any_static_probe_ops::get_probes): Change type.
1322         * elfread.c (elfread_data): New typedef.
1323         (probe_key): Change type.
1324         (elf_get_probes): Likewise.  Update.
1325         (probe_key_free): Remove.
1326         (_initialize_elfread): Update.
1327         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1328         Change type.
1329         (dtrace_process_dof_probe, dtrace_process_dof)
1330         (dtrace_static_probe_ops::get_probe): Change type.
1331
1332 2019-05-08  Tom Tromey  <tom@tromey.com>
1333
1334         * xcoffread.c (struct xcoff_symfile_info): Rename from
1335         coff_symfile_info.  Add initializers.
1336         (xcoff_objfile_data_key): Move lower.  Change type.
1337         (XCOFF_DATA): Rewrite.
1338         (xcoff_free_info): Remove.
1339         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1340         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1341         (xcoff_initial_scan): Update.
1342
1343 2019-05-08  Tom Tromey  <tom@tromey.com>
1344
1345         * solib-svr4.c (struct svr4_info): Add initializers and
1346         destructor.
1347         <probes_table>: Now an htab_up.
1348         (solib_svr4_pspace_data): Change type.
1349         (free_probes_table): Simplify.
1350         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1351         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1352         (probes_table_remove_objfile_probes, register_solib_event_probe)
1353         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1354         (_initialize_svr4_solib): Update.
1355
1356 2019-05-08  Tom Tromey  <tom@tromey.com>
1357
1358         * remote.c (remote_pspace_data): Change type.
1359         (remote_pspace_data_cleanup): Remove.
1360         (get_remote_exec_file, set_pspace_remote_exec_file)
1361         (_initialize_remote): Update.
1362
1363 2019-05-08  Tom Tromey  <tom@tromey.com>
1364
1365         * breakpoint.c (breakpoint_objfile_key): Change type.
1366         (get_breakpoint_objfile_data): Update.
1367         (free_breakpoint_objfile_data): Remove.
1368         (_initialize_breakpoint): Update.
1369
1370 2019-05-08  Tom Tromey  <tom@tromey.com>
1371
1372         * linux-tdep.c (struct linux_info): Add initializers.
1373         (linux_inferior_data): Move.  Change type.
1374         (invalidate_linux_cache_inf): Update.
1375         (linux_inferior_data_cleanup): Remove.
1376         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1377
1378 2019-05-08  Tom Tromey  <tom@tromey.com>
1379
1380         * auxv.c (auxv_inferior_data): Move.  Change type.
1381         (auxv_inferior_data_cleanup): Remove.
1382         (invalidate_auxv_cache_inf): Rewrite.
1383         (get_auxv_inferior_data, _initialize_auxv): Update.
1384
1385 2019-05-08  Tom Tromey  <tom@tromey.com>
1386
1387         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1388         (symfile_debug_objfile_data_key): Change type.
1389         (symfile_debug_installed, debug_qf_has_symbols)
1390         (debug_qf_find_last_source_symtab)
1391         (debug_qf_forget_cached_source_info)
1392         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1393         (debug_qf_print_stats, debug_qf_dump)
1394         (debug_qf_expand_symtabs_for_function)
1395         (debug_qf_expand_all_symtabs)
1396         (debug_qf_expand_symtabs_with_fullname)
1397         (debug_qf_map_matching_symbols)
1398         (debug_qf_expand_symtabs_matching)
1399         (debug_qf_find_pc_sect_compunit_symtab)
1400         (debug_qf_map_symbol_filenames)
1401         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1402         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1403         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1404         (debug_sym_read_linetable, debug_sym_relocate): Update.
1405         (symfile_debug_free_objfile): Remove.
1406         (install_symfile_debug_logging, _initialize_symfile_debug):
1407         Update.
1408
1409 2019-05-08  Tom Tromey  <tom@tromey.com>
1410
1411         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1412         allocate_on_obstack.
1413         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1414         (get_dwarf2_per_objfile): Update.
1415         (set_dwarf2_per_objfile): Remove.
1416         (dwarf2_has_info, dwarf2_get_section_info): Update.
1417         (dwarf2_free_objfile): Remove.
1418         (_initialize_dwarf2_read): Update.
1419
1420 2019-05-08  Tom Tromey  <tom@tromey.com>
1421
1422         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1423         initializers.
1424         <unsupported_script_warning_printed,
1425         script_not_found_warning_printed>: Now bool.
1426         (auto_load_pspace_data): Change type.
1427         (~auto_load_pspace_info): Rename from
1428         auto_load_pspace_data_cleanup.
1429         (get_auto_load_pspace_data, init_loaded_scripts_info)
1430         (clear_section_scripts, maybe_print_unsupported_script_warning)
1431         (maybe_print_script_not_found_warning, _initialize_auto_load):
1432         Update.
1433
1434 2019-05-08  Tom Tromey  <tom@tromey.com>
1435
1436         * objfiles.c (objfile_pspace_info): Add destructor and
1437         initializers.
1438         (objfiles_pspace_data): Change type.
1439         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1440         (get_objfile_pspace_data): Update.
1441         (objfiles_bfd_data): Change type.
1442         (get_objfile_bfd_data): Update.
1443         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1444
1445 2019-05-08  Tom Tromey  <tom@tromey.com>
1446
1447         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1448         Change type.
1449         (get_catch_syscall_inferior_data): Update.
1450         (catch_syscall_inferior_data_cleanup): Remove.
1451         (_initialize_break_catch_syscall): Update.
1452
1453 2019-05-08  Tom Tromey  <tom@tromey.com>
1454
1455         * inflow.c (struct terminal_info): Add destructor and
1456         initializers.
1457         (inflow_inferior_data): Change type.
1458         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1459         (get_inflow_inferior_data, inflow_inferior_exit)
1460         (swap_terminal_info, _initialize_inflow): Update.
1461
1462 2019-05-08  Tom Tromey  <tom@tromey.com>
1463
1464         * target-dcache.c (target_dcache_cleanup): Remove.
1465         (target_dcache_aspace_key): Change type.
1466         (target_dcache_init_p, target_dcache_invalidate)
1467         (target_dcache_get, target_dcache_get_or_init)
1468         (_initialize_target_dcache): Update.
1469         * dcache.h (struct dcache_deleter): New.
1470
1471 2019-05-08  Tom Tromey  <tom@tromey.com>
1472
1473         * symtab.c (struct symbol_cache): Add destructor and
1474         initializers.
1475         (symbol_cache_key): Move.  Change type.
1476         (make_symbol_cache, free_symbol_cache): Remove.
1477         (get_symbol_cache): Update.
1478         (symbol_cache_cleanup): Remove.
1479         (ALL_PSPACES, symbol_cache_flush)
1480         (maintenance_print_symbol_cache)
1481         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1482         Update.
1483
1484 2019-05-08  Tom Tromey  <tom@tromey.com>
1485
1486         * symtab.c (struct main_info): Add destructor and initializers.
1487         (main_progspace_key): Move.  Change type.
1488         (get_main_info): Update.
1489         (main_info_cleanup): Remove.
1490         (_initialize_symtab): Update.
1491
1492 2019-05-08  Tom Tromey  <tom@tromey.com>
1493
1494         * registry.h (DECLARE_REGISTRY): Define the _key class.
1495
1496 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * NEWS: Merge two 'New commands' sections.
1499
1500 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1501
1502         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1503         parameter and use Ada language definition instead.
1504         (ada_val_print_ptr): Remove unused language parameter.
1505         (ada_val_print_num): Remove language parameter and use Ada language
1506         definition instead.
1507         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1508         parameter.
1509         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1510         parameter and use Ada language definition instead.
1511         (ada_val_print_1): Update all ada_val_print_xxx calls.
1512         Remove language parameter.
1513         (ada_val_print): Update ada_val_print_1 call.
1514
1515 2019-05-08  Tom Tromey  <tromey@adacore.com>
1516
1517         * remote.c (remote_hw_watchpoint_limit)
1518         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1519         Now static.
1520
1521 2019-05-08  Tom Tromey  <tromey@adacore.com>
1522
1523         * maint.c (_initialize_maint_cmds): Move initialization code to
1524         remote.c.
1525         (watchdog, show_watchdog): Move to remote.c.
1526         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1527         "watchdog" static.
1528         (_initialize_remote): Move initialization code from maint.c.
1529         * defs.h (watchdog): Don't declare.
1530
1531 2019-05-08  Tom Tromey  <tromey@adacore.com>
1532
1533         * tui/tui-interp.c: Include main.h.
1534         * interps.c: Include main.h.
1535         * main.h (interpreter_p): Declare.
1536         * defs.h (interpreter_p): Don't declare.
1537
1538 2019-05-08  Tom Tromey  <tromey@adacore.com>
1539
1540         * dwarf2loc.c: Include dwarf2read.h.
1541         * defs.h (read_unsigned_leb128): Don't declare.
1542         * dwarf2read.h (read_unsigned_leb128): Declare.
1543
1544 2019-05-08  Tom Tromey  <tromey@adacore.com>
1545
1546         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1547         method.
1548
1549 2019-05-08  Tom Tromey  <tromey@adacore.com>
1550
1551         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1552         when no wrap column is set.
1553
1554 2019-05-08  Tom Tromey  <tromey@adacore.com>
1555
1556         * c-lang.c (c_get_string): Handle non-C-style arrays.
1557
1558 2019-05-08  Tom Tromey  <tromey@adacore.com>
1559
1560         * typeprint.c (print_offset_data::update): Print the bit offset,
1561         not the number of bits remaining.
1562
1563 2019-05-08  Tom Tromey  <tromey@adacore.com>
1564
1565         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1566         padding at end of comment.
1567
1568 2019-05-08  Tom Tromey  <tromey@adacore.com>
1569
1570         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1571         Compare main types.
1572
1573 2019-05-06  Tom Tromey  <tom@tromey.com>
1574
1575         * common/scoped_mmap.c: Include common-defs.h.
1576         * common/scoped_mmap.h: Don't include config.h.
1577
1578 2019-05-04  Tom Tromey  <tom@tromey.com>
1579
1580         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1581         (struct aarch64_call_info): Add initializers.
1582         <si>: Now a std::vector.
1583         (pass_on_stack, aarch64_push_dummy_call): Update.
1584
1585 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1586             Tom Tromey  <tom@tromey.com>
1587
1588         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1589         (ppc_threads): Now a std::vector.  Now static.
1590         (hwdebug_find_thread_points_by_tid)
1591         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1592         Update.
1593
1594 2019-05-04  Tom Tromey  <tom@tromey.com>
1595
1596         * arc-tdep.c (arc_tdesc_init): Return bool.
1597
1598 2019-05-04  Tom Tromey  <tom@tromey.com>
1599
1600         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1601         Use gdb_assert_not_reached.
1602
1603 2019-05-04  Tom Tromey  <tom@tromey.com>
1604
1605         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1606         "false".
1607
1608 2019-05-04  Tom Tromey  <tom@tromey.com>
1609
1610         * arc-tdep.c (arc_tdesc_init): Use bool.
1611
1612 2019-05-04  Tom Tromey  <tom@tromey.com>
1613
1614         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1615
1616 2019-05-04  Tom Tromey  <tom@tromey.com>
1617
1618         * cli/cli-cmds.c (valid_command_p): Return bool.
1619
1620 2019-05-04  Tom Tromey  <tom@tromey.com>
1621
1622         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1623         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1624
1625 2019-05-04  Raul Tambre  <raul@tambre.ee>
1626
1627         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1628         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1629         operator for comparison.
1630
1631 2019-05-04  Tom Tromey  <tom@tromey.com>
1632
1633         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1634         (lookup_partial_symbol, print_partial_symbols)
1635         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1636         (psymbol_compare): Update.
1637         (add_psymbol_to_bcache): Clear the entire psymbol.
1638         (maintenance_check_psymtabs): Update.
1639         * psympriv.h (struct partial_symbol): Don't derive from
1640         general_symbol_info.
1641         <obj_section, unrelocated_address, address,
1642         set_unrelocated_address>: Update.
1643         <ginfo>: New member.
1644         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1645         (debug_names::write_psymbols): Update.
1646
1647 2019-05-04  Tom de Vries  <tdevries@suse.de>
1648
1649         * contrib/cc-with-tweaks.sh: Support -n arg.
1650
1651 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1652
1653         * corelow.c (core_target::detach): Ensure frame cache and
1654         register caches are cleared.
1655         inferior.c (exit_inferior_1): Likewise.
1656
1657 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1658             Tom Tromey  <tom@tromey.com>
1659
1660         * dictionary.c (collate_pending_symbols_by_language): Remove
1661         "struct" from foreach.
1662         * symtab.c (lookup_global_symbol_from_objfile)
1663         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1664         foreach.
1665         * ser-tcp.c (net_open): Remove "struct" from foreach.
1666         * objfiles.c (objfile_relocate, objfile_rebase)
1667         (objfile_has_symbols): Remove "struct" from foreach.
1668         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1669         from foreach.
1670         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1671         foreach.
1672         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1673         "struct" from foreach.
1674         * ada-lang.c (create_excep_cond_exprs)
1675         (ada_exception_catchpoint_cond_string): Remove "struct" from
1676         foreach.
1677
1678 2019-05-03  Tom Tromey  <tromey@adacore.com>
1679
1680         * ada-exp.y (convert_char_literal): Check suffix of each
1681         enumerator.
1682
1683 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1684
1685         PR ada/21406:
1686         * ada-exp.y (yywrap): Don't define.
1687         * ada-lex.l (%option): Add noyywrap
1688         (yywrap): Remove.
1689
1690 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1691
1692         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1693         _WIN32_WINNT to the XP level, unless already defined to a higher
1694         level.
1695
1696         * unittests/parse-connection-spec-selftests.c:
1697         * ser-tcp.c:
1698         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1699         override.
1700
1701         * symfile.c (find_separate_debug_file): Remove colon from the
1702         drive spec of DOS/Windows file names of the target, so that the
1703         file name produced from DEBUGDIR and the target's directory will
1704         be valid on DOS/Windows systems.
1705
1706 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * rust-lang.c (val_print_struct): Handle printing structures
1709         containing strings.
1710
1711 2019-05-02  Tom Tromey  <tromey@adacore.com>
1712
1713         * valarith.c (_initialize_valarith): Remove.
1714
1715 2019-05-01  Tom Tromey  <tromey@adacore.com>
1716
1717         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1718         bitfields.
1719
1720 2019-05-01  Tom Tromey  <tromey@adacore.com>
1721
1722         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1723         for big-endian copies.
1724
1725 2019-04-30  Ali Tamur  <tamur@google.com>
1726         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1727         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1728         (read_3_bytes): New function.
1729
1730 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1731
1732         * windows-nat.c (main_thread_id): Delete.
1733         (handle_output_debug_string): Replace main_thread_id by
1734         current_event.dwThreadId.
1735         (fake_create_process): Likewise.
1736         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1737         Do not set main_thread_id.
1738         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1739         current_event.dwThreadId.
1740         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1741
1742 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1743
1744         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1745         Use current_event.dwThreadId instead of main_thread_id.
1746
1747 2019-04-30  Tom Tromey  <tromey@adacore.com>
1748
1749         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1750         (create_excep_cond_exprs): Iterate over program spaces.
1751         (ada_exception_catchpoint_cond_string): Examine all minimal
1752         symbols for exception types.
1753
1754 2019-04-30  Tom Tromey  <tromey@adacore.com>
1755
1756         PR c++/24470:
1757         * dwarf2read.c (process_structure_scope): Handle case where type
1758         has template parameters but no symbol was created.
1759
1760 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1761             Chris January  <chris.january@arm.com>
1762
1763         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1764         qualifier.
1765         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1766
1767 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * f-typeprint.c (f_print_type): Update rules for printing
1770         whitespace.
1771         (f_type_print_varspec_suffix): Likewise.
1772
1773 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1774             Chris January  <chris.january@arm.com>
1775
1776         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1777         function arguments.
1778
1779 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * f-lang.c (build_fortran_types): Change name of void type to
1782         lower case.
1783         * f-typeprint.c (f_type_print_base): Print the name of the void
1784         type, rather than a fixed string.
1785         * f-valprint.c (f_decorations): Use lower case void string.
1786
1787 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1788             Chris January  <chris.january@arm.com>
1789
1790         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1791         types for Fortran.
1792
1793 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1794             Chris January  <chris.january@arm.com>
1795             David Lecomber  <david.lecomber@arm.com>
1796
1797         * f-exp.y (BINOP_INTRINSIC): New token.
1798         (exp): New parser rule handling BINOP_INTRINSIC.
1799         (f77_keywords): Add new builtin procedures.
1800         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1801         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1802         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1803         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1804         (print_unop_subexp_f): New function.
1805         (print_binop_subexp_f): New function.
1806         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1807         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1808         (dump_subexp_body_f): Likewise.
1809         (operator_check_f): Likewise.
1810         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1811         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1812
1813 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1816         UNOP_KIND.
1817         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1818         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1819         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1820         (operator_length_f): New fuction.
1821         (print_subexp_f): New function.
1822         (op_name_f): New function.
1823         (dump_subexp_body_f): New function.
1824         (operator_check_f): New function.
1825         (exp_descriptor_f): Replace standard expression handling functions
1826         with new functions.
1827         * gdb/fortran-operator.def: New file.
1828         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1829         * gdb/std-operator.def: Remove UNOP_KIND.
1830
1831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * std-operator.def: Remove unbalanced, stray double quote
1834         character.
1835
1836 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1837             Chris January  <chris.january@arm.com>
1838             Daniel Everett  <daniel.everett@arm.com>
1839             Nick Forrington  <nick.forrington@arm.com>
1840             Richard Bunt  <richard.bunt@arm.com>
1841
1842         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1843         of depth when printing anonymous structs or unions.
1844         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1845         Don't print either the top-level value, or the children if the
1846         max-depth is exceeded.
1847         (ppscm_print_children): When printing the key of a map, allow one
1848         extra level of depth.
1849         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1850         print either the top-level value, or the children if the max-depth
1851         is exceeded.
1852         (print_children): When printing the key of a map, allow one extra
1853         level of depth.
1854         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1855         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1856         (user_print_options): Initialise max_depth field.
1857         (val_print_scalar_or_string_type_p): New function.
1858         (val_print): Check to see if the max depth has been reached.
1859         (val_print_check_max_depth): Define new function.
1860         (show_print_max_depth): New function.
1861         (_initialize_valprint): Add 'print max-depth' option.
1862         * valprint.h (struct value_print_options) <max_depth>: New field.
1863         (val_print_check_max_depth): Declare new function.
1864         * NEWS: Document new feature.
1865
1866 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * ada-lang.c (ada_language_defn): Initialise new field.
1869         * c-lang.c (c_is_string_type_p): New function.
1870         (c_language_defn): Initialise new field.
1871         (cplus_language_defn): Initialise new field.
1872         (asm_language_defn): Initialise new field.
1873         (minimal_language_defn): Initialise new field.
1874         * c-lang.h (c_is_string_type_p): Declare new function.
1875         * d-lang.c (d_language_defn): Initialise new field.
1876         * f-lang.c (f_is_string_type_p): New function.
1877         (f_language_defn): Initialise new field.
1878         * go-lang.c (go_is_string_type_p): New function.
1879         (go_language_defn): Initialise new field.
1880         * language.c (default_is_string_type_p): New function.
1881         (unknown_language_defn): Initialise new field.
1882         (auto_language_defn): Initialise new field.
1883         * language.h (struct language_defn) <la_is_string_type_p>: New
1884         member variable.
1885         (default_is_string_type_p): Declare new function.
1886         * m2-lang.c (m2_language_defn): Initialise new field.
1887         * objc-lang.c (objc_language_defn): Initialise new field.
1888         * opencl-lang.c (opencl_language_defn): Initialise new field.
1889         * p-lang.c (pascal_is_string_type_p): New function.
1890         (pascal_language_defn): Initialise new field.
1891         * rust-lang.c (rust_is_string_type_p): New function.
1892         (rust_language_defn): Initialise new field.
1893
1894 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1897         New field.
1898         * ada-lang.c (ada_language_defn): Initialise new field.
1899         * c-lang.c (c_language_defn): Likewise.
1900         (cplus_language_defn): Likewise.
1901         (asm_language_defn): Likewise.
1902         (minimal_language_defn): Likewise.
1903         * d-lang.c (d_language_defn): Likewise.
1904         * f-lang.c (f_language_defn): Likewise.
1905         * go-lang.c (go_language_defn): Likewise.
1906         * language.c (unknown_language_defn): Likewise.
1907         (auto_language_defn): Likewise.
1908         * m2-lang.c (m2_language_defn): Likewise.
1909         * objc-lang.c (objc_language_defn): Likewise.
1910         * opencl-lang.c (opencl_language_defn): Likewise.
1911         * p-lang.c (pascal_language_defn): Likewise.
1912         * rust-lang.c (rust_language_defn): Likewise.
1913
1914 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * ada-lang.c (ada_is_character_type): Change return type to bool.
1917         (ada_is_string_type): Likewise.
1918         * ada-lang.h (ada_is_character_type): Update declaration
1919         (ada_is_string_type): Likewise.
1920
1921 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1922
1923         Support style in 'frame|thread apply'
1924
1925         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1926         * record.c (record_start, record_stop): Update callers of
1927         execute_command_to_string with false.
1928         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1929         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1930         methods.
1931         (class string_file): New constructor with term_out parameter.
1932         Override methods term_out and can_emit_style_escape.  New member
1933         term_out.
1934         (class stdio_file): Override can_emit_style_escape.
1935         (class tee_file): Override term_out and can_emit_style_escape.
1936         * utils.h (can_emit_style_escape): Remove.
1937         * utils.c (can_emit_style_escape): Likewise.
1938         Update all callers of can_emit_style_escape (SOMESTREAM) to
1939         SOMESTREAM->can_emit_style_escape.
1940         * source-cache.c (source_cache::get_source_lines): Likewise.
1941         * stack.c (frame_apply_command_count): Call execute_command_to_string
1942         passing the term_out characteristic of the current gdb_stdout.
1943         * thread.c (thr_try_catch_cmd): Likewise.
1944         * top.c (execute_command_to_string): pass term_out parameter
1945         to construct the string_file for the command output.
1946         * ui-file.c (term_cli_styling): New function (most code moved
1947         from utils.c can_emit_style_escape).
1948         (string_file::string_file, string_file::can_emit_style_escape,
1949         stdio_file::can_emit_style_escape, tee_file::term_out,
1950         tee_file::can_emit_style_escape): New functions.
1951
1952 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1953
1954         * NEWS: Mention the new set|show may-call-functions.
1955         * infcall.c (may_call_functions_p): New variable.
1956         (show_may_call_functions_p): New function.
1957         (call_function_by_hand_dummy): Throws an error if not
1958         may-call-functions.
1959         (_initialize_infcall): Call add_setshow_boolean_cmd for
1960         may-call-functions.
1961
1962 2019-04-25  Keith Seitz  <keiths@redhat.com>
1963
1964         PR c++/24367
1965         * cp-support.c (inspect_type): Don't attempt substitutions
1966         of symbol with the same name.
1967
1968 2019-04-25  Tom Tromey  <tromey@adacore.com>
1969
1970         PR gdb/24475:
1971         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1972         static.
1973
1974 2019-04-25  Tom Tromey  <tromey@adacore.com>
1975
1976         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1977         rvalue reference.
1978         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1979         (gdb_xml_parser::parse): Use std::move.
1980         * python/python-internal.h (gdbpy_convert_exception): Take a const
1981         reference.
1982         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1983         std::move.
1984         * python/py-utils.c (gdbpy_convert_exception): Take a const
1985         reference.
1986         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1987         Use std::move.
1988         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1989         Use std::move.
1990         * mi/mi-main.c (mi_print_exception): Take a const reference.
1991         * main.c (handle_command_errors): Take a const reference.
1992         * linespec.c (parse_linespec): Use std::move.
1993         * infcall.c (run_inferior_call): Use std::move.
1994         (call_function_by_hand_dummy): Use std::move.
1995         * exec.c (try_open_exec_file): Use std::move.
1996         * exceptions.h (exception_print, exception_fprintf)
1997         (exception_print_same): Update.
1998         * exceptions.c (print_exception, exception_print)
1999         (exception_fprintf, exception_print_same): Change parameters to
2000         const reference.
2001         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2002         * common/new-op.c: Use std::move.
2003         * common/common-exceptions.h (struct gdb_exception): Add move
2004         constructor.
2005         (struct gdb_exception_error, struct gdb_exception_quit, struct
2006         gdb_quit_bad_alloc): Change constructor to move constructor.
2007         (throw_exception): Change parameter to rvalue reference.
2008         * common/common-exceptions.c (throw_exception): Take rvalue
2009         reference.
2010         * cli/cli-interp.c (safe_execute_command): Use std::move.
2011         * breakpoint.c (insert_bp_location, location_to_sals): Use
2012         std::move.
2013
2014 2019-04-25  Tom Tromey  <tromey@adacore.com>
2015
2016         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2017         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2018         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2019         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2020         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2021         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2022         guile/scm-value.c: Use unpack.
2023         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2024         gdbscm_gdb_exception.
2025         (gdbscm_throw_gdb_exception): Likewise.
2026         (struct gdbscm_gdb_exception): New.
2027         (unpack): New function.
2028         (gdbscm_wrap): Use unpack.
2029
2030 2019-04-25  Tom Tromey  <tromey@adacore.com>
2031
2032         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2033         (gdb_rl_callback_handler): Use std::move.
2034         * common/common-exceptions.h (struct gdb_exception): Add move
2035         assignment operator.
2036         (throw_exception_sjlj): Change "exception" to const reference.
2037         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2038         (throw_exception_sjlj): Change "exception" to const reference.
2039
2040 2019-04-25  Tom Tromey  <tromey@adacore.com>
2041
2042         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2043         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2044         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2045         Update.
2046         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2047         Update.
2048         * mi/mi-interp.c (mi_interp::exec): Update.
2049         * linespec.c (parse_linespec): Update.
2050         * infcall.c (run_inferior_call): Update.
2051         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2052         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2053         (gdbscm_lookup_global_symbol): Update.
2054         * guile/scm-param.c (gdbscm_parameter_value): Update.
2055         * guile/scm-frame.c (gdbscm_frame_read_register)
2056         (gdbscm_frame_read_var): Update.
2057         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2058         * exec.c (try_open_exec_file): Update.
2059         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2060         (gdb_rl_callback_handler): Update.
2061         * common/common-exceptions.h (exception_none): Don't declare.
2062         * common/common-exceptions.c (exception_none): Don't define.
2063         (struct catcher) <exception>: Update.
2064         * cli/cli-interp.c (safe_execute_command): Update.
2065         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2066
2067 2019-04-25  Ali Tamur  <tamur@google.com>
2068
2069         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2070         (read_attribute_value): Likewise.
2071         (dwarf2_read_addr_index): Update comment.
2072         (read_str_index): Add DW_FORM_strx.
2073         (dwarf2_string_attr): Likewise.
2074         (dwarf2_const_value_attr): Likewise.
2075         (dump_die_shallow): Likewise.
2076         (dwarf2_fetch_constant_bytes): Likewise.
2077         (skip_form_bytes): Likewise.
2078         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2079
2080 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2081
2082         PR corefiles/11608
2083         PR corefiles/18187
2084         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2085         OFFSET.  Verify if current mapping contains an ELF header.
2086         (linux_find_memory_regions_full): Adjust call to
2087         dump_mapping_p.
2088
2089 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2090             Kang Li <kanglictf@gmail.com>
2091
2092         PR gdb/21600
2093
2094         * dwarf2-frame.c (read_initial_length): Be consistent about using
2095         unsigned representation of length.
2096         (decode_frame_entry_1): Likewise.  Check for wraparound of
2097         end pointer as well as buffer overflow.
2098
2099 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2100
2101         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2102         "vq".
2103
2104 2019-04-24  Tom Tromey  <tromey@adacore.com>
2105
2106         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2107
2108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2109
2110         * s12z-tdep.c (s12z_unwind_pc): Delete.
2111         (s12z_unwind_sp): Delete.
2112         (s12z_gdbarch_init): Don't register deleted functions with
2113         gdbarch.
2114
2115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * rl78-tdep.c (rl78_unwind_sp): Delete.
2118         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2119
2120 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2121
2122         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2123         (xstormy16_unwind_pc): Delete.
2124         (xstormy16_dummy_id): Delete.
2125         (xstormy16_gdbarch_init): Don't register deleted functions with
2126         gdbarch.
2127
2128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * vax-tdep.c (vax_unwind_pc): Delete.
2131         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2132
2133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * v850-tdep.c (v850_unwind_sp): Delete.
2136         (v850_unwind_pc): Delete.
2137         (v850_dummy_id): Delete.
2138         (v850_gdbarch_init): Don't register deleted functions with
2139         gdbarch.
2140
2141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2144         (tilegx_unwind_pc): Delete.
2145         (tilegx_unwind_dummy_id): Delete.
2146         (tilegx_gdbarch_init): Don't register deleted functions with
2147         gdbarch.
2148
2149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2150
2151         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2152         (tic6x_dummy_id): Delete.
2153         (tic6x_gdbarch_init): Don't register deleted functions with
2154         gdbarch.
2155
2156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * sparc-tdep.c (sparc_unwind_pc): Delete.
2159         (sparc32_gdbarch_init): Don't register deleted function with
2160         gdbarch.
2161
2162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2163
2164         * sh-tdep.c (sh_unwind_sp): Delete.
2165         (sh_unwind_pc): Delete.
2166         (sh_dummy_id): Delete.
2167         (sh_gdbarch_init): Don't register deleted functions with
2168         gdbarch.
2169
2170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2171
2172         * score-tdep.c (score_unwind_sp): Delete.
2173         (score_unwind_pc): Delete.
2174         (score_dummy_id): Delete.
2175         (score_gdbarch_init): Don't register deleted functions with
2176         gdbarch.
2177
2178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * rx-tdep.c (rx_unwind_pc): Delete.
2181         (rx_unwind_sp): Delete.
2182         (rx_dummy_id): Delete.
2183         (rx_gdbarch_init): Don't register deleted functions with
2184         gdbarch.  Update comment.
2185
2186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2189         (rs6000_dummy_id): Delete.
2190         (rs6000_gdbarch_init): Don't register deleted functions with
2191         gdbarch.
2192
2193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * or1k-tdep.c (or1k_dummy_id): Delete.
2196         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2197
2198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * nios2-tdep.c (nios2_dummy_id): Delete.
2201         (nios2_unwind_sp): Delete.
2202         (nios2_gdbarch_init): Don't register deleted functions with
2203         gdbarch.
2204
2205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2206
2207         * nds32-tdep.c (nds32_dummy_id): Delete.
2208         (nds32_unwind_pc): Delete.
2209         (nds32_unwind_sp): Delete.
2210         (nds32_gdbarch_init): Don't register deleted functions with
2211         gdbarch.
2212
2213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * msp430-tdep.c (msp430_unwind_pc): Delete.
2216         (msp430_unwind_sp): Delete.
2217         (msp430_dummy_id): Delete.
2218         (msp430_gdbarch_init): Don't register deleted functions with
2219         gdbarch.
2220
2221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * moxie-tdep.c (moxie_unwind_sp): Delete.
2224         (moxie_unwind_pc): Delete.
2225         (moxie_dummy_id): Delete.
2226         (moxie_gdbarch_init): Don't register deleted functions with
2227         gdbarch.
2228
2229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2232         (mn10300_unwind_pc): Delete.
2233         (mn10300_unwind_sp): Delete.
2234         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2235         mn10300_unwind_sp.
2236         (mn10300_frame_unwind_init): Don't register deleted functions with
2237         gdbarch.
2238
2239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2240
2241         * mep-tdep.c (mep_unwind_pc): Delete.
2242         (mep_unwind_sp): Delete.
2243         (mep_dummy_id): Delete.
2244         (mep_gdbarch_init): Don't register deleted functions with
2245         gdbarch.
2246
2247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2250         (m68hc11_unwind_sp): Delete.
2251         (m68hc11_gdbarch_init): Don't register deleted functions with
2252         gdbarch.
2253
2254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2255
2256         * m32r-tdep.c (m32r_unwind_sp): Delete.
2257         (m32r_unwind_pc): Delete.
2258         (m32r_dummy_id): Delete.
2259         (m32r_gdbarch_init): Don't register deleted functions with
2260         gdbarch.
2261
2262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * m32c-tdep.c (m32c_unwind_pc): Delete.
2265         (m32c_unwind_sp): Delete.
2266         (m32c_dummy_id): Delete.
2267         (m32c_gdbarch_init): Don't register deleted functions with
2268         gdbarch.
2269
2270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2273         (lm32_unwind_pc): Delete.
2274         (lm32_dummy_id): Delete.
2275         (lm32_gdbarch_init): Don't register deleted functions with
2276         gdbarch.
2277
2278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2281         (iq2000_unwind_pc): Delete.
2282         (iq2000_dummy_id): Delete.
2283         (iq2000_gdbarch_init): Don't register deleted functions with
2284         gdbarch.
2285
2286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * nds32-tdep.c (nds32_type_align): Delete.
2289         (nds32_push_dummy_call): Use type_align instead.
2290
2291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * arm-tdep.c (arm_type_align): Only handle vector override case.
2294         (arm_push_dummy_call): Use type_align.
2295         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2296
2297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2300         case.
2301         (pass_on_stack): Use type_align.
2302         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2303         function.
2304
2305 2019-04-23  Tom Tromey  <tromey@adacore.com>
2306
2307         * dwarf2read.c (line_header::file_name_at): Remove unused
2308         overload.
2309
2310 2019-04-23  Tom de Vries  <tdevries@suse.de>
2311
2312         PR gdb/24438
2313         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2314         invocation.
2315
2316
2317 2019-03-27  Ali Tamur  <tamur@google.com>
2318
2319         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2320         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2321         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2322         (dwarf_expr_context::get_addr_index): Likewise
2323         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2324         (symbol_needs_eval_context::get_addr_index): Likewise
2325         (disassemble_dwarf_expression): Add DW_OP_addrx
2326         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2327         (read_cutu_die_from_dwo): Update comment
2328         (skip_one_die): Add DW_FORM_addrx
2329         (read_attribute_value): Likewise
2330         (var_decode_location): Add DW_OP_addrx
2331         (dwarf2_const_value_attr): Add DW_FORM_addrx
2332         (dump_die_shallow): Likewise
2333         (dwarf2_fetch_constant_bytes): Likewise
2334         (decode_locdesc): Add DW_OP_addrx
2335         (skip_form_bytes): Add DW_FORM_addrx
2336
2337 2019-04-22  Ali Tamur  <tamur@google.com>
2338
2339         * MAINTAINERS (Write After Approval): Add self.
2340
2341 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2342
2343         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2344         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2345         (open_symbol_file_object): Likewise.
2346         (svr4_default_sos): Add info parameter.
2347         (svr4_read_so_list): Likewise.
2348         (svr4_current_sos_direct): Adjust functions calls to pass down
2349         info.
2350         (svr4_current_sos_1): Add info parameter.
2351         (svr4_current_sos): Call get_svr4_info, pass info down to
2352         svr4_current_sos_1.
2353         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2354         get_svr4_info.
2355         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2356         get_svr4_info.
2357         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2358         to get_svr4_info.
2359         (probes_table_remove_objfile_probes): Likewise.
2360         (register_solib_event_probe): Add info parameter.
2361         (solist_update_incremental): Pass info parameter down to
2362         svr4_read_so_list.
2363         (disable_probes_interface): Add info parameter.
2364         (svr4_handle_solib_event): Pass current_program_space to
2365         get_svr4_info.  Adjust disable_probes_interface cleanup.
2366         (svr4_create_probe_breakpoints): Add info parameter, pass it
2367         down to register_solib_event_probe.
2368         (svr4_create_solib_event_breakpoints): Add info parameter,
2369         pass it down to svr4_create_probe_breakpoints.
2370         (enable_break): Pass info down to
2371         svr4_create_solib_event_breakpoints.
2372         (svr4_solib_create_inferior_hook): Pass current_program_space to
2373         get_svr4_info.
2374         (svr4_clear_solib): Likewise.
2375
2376 2019-04-22  Pedro Alves  <palves@redhat.com>
2377
2378         * solib-svr4.c (svr4_free_objfile_observer): New.
2379         (probe_and_action::objfile): New field.
2380         (probes_table_htab_remove_objfile_probes)
2381         (probes_table_remove_objfile_probes): New functions.
2382         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2383         in the new probe_and_action.  Don't store the probe in 'lookup'.
2384         (svr4_create_probe_breakpoints): Pass objfile to
2385         register_solib_event_probe.
2386         (_initialize_svr4_solib): Register a free_objfile observer.
2387
2388 2019-04-19  Tom Tromey  <tom@tromey.com>
2389
2390         * common/queue.h: Remove.
2391
2392 2019-04-19  Tom Tromey  <tom@tromey.com>
2393
2394         * event-loop.c: Don't include "common/queue.h".
2395
2396 2019-04-19  Tom Tromey  <tom@tromey.com>
2397
2398         * remote.c (remote_target): Use delete.
2399         * remote-notif.h: Include <list>, not "common/queue.h".
2400         (notif_client_p): Remove typedef.
2401         (remote_notif_state): Add constructor, destructor, initializer.
2402         <notif_queue>: Now a std::list.
2403         (remote_notif_state_xfree): Don't declare.
2404         * remote-notif.c (remote_notif_process, handle_notification)
2405         (remote_notif_state_allocate): Update.
2406         (~remote_notif_state): Rename from remote_notif_state_xfree.
2407
2408 2019-04-19  Tom Tromey  <tom@tromey.com>
2409
2410         * symfile.c (reread_symbols): Update.
2411         * objfiles.c (objfile_register_static_link)
2412         (objfile_lookup_static_link): Update
2413         (~objfile) Don't delete static_links.
2414         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2415
2416 2019-04-19  Tom Tromey  <tom@tromey.com>
2417
2418         * type-stack.h (struct type_stack) <insert>: Constify string.
2419         * type-stack.c (type_stack::insert): Constify string.
2420         * gdbtypes.h (lookup_template_type): Update.
2421         (address_space_name_to_int): Update.
2422         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2423         const.
2424         (lookup_template_type): Make name const.
2425         * c-exp.y: Update rules.
2426         (lex_one_token, classify_name, classify_inner_name)
2427         (c_print_token): Update.
2428         * p-exp.y: Update rules.
2429         (yylex): Update.
2430         * f-exp.y: Update rules.
2431         (yylex): Update.
2432         * d-exp.y: Update rules.
2433         (lex_one_token, classify_name, classify_inner_name): Update.
2434         * parse.c (write_dollar_variable, copy_name): Return std::string.
2435         * parser-defs.h (copy_name): Change return type.
2436         * m2-exp.y: Update rules.
2437         (yylex): Update.
2438         * go-exp.y (lex_one_token): Update.
2439         Update rules.
2440         (classify_unsafe_function, classify_packaged_name)
2441         (classify_name, yylex): Update.
2442
2443 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2444
2445         * configure.ac: add --enable-source-highlight switch.
2446         * configure: Regenerate.
2447         * top.c (print_gdb_version): plumb --enable-source-highlight
2448         status to "show configuration".
2449
2450 2019-04-19  Tom Tromey  <tromey@adacore.com>
2451
2452         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2453         Check ADA_TYPE_P.
2454         (empty_record, ada_template_to_fixed_record_type_1)
2455         (template_to_static_fixed_type)
2456         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2457         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2458         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2459         macros.
2460
2461 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2462
2463         PR symtab/24423:
2464         * source.c (print_source_lines_base): Advance "iter" when a
2465         control character is seen.
2466
2467 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2468
2469         * inferior.h (struct infcall_suspend_state_deleter):
2470         Catch exception in destructor to avoid crash.
2471
2472 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2473
2474         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2475         close to the add_com "shell".
2476
2477 2019-04-18  Tom Tromey  <tromey@adacore.com>
2478
2479         * process-stratum-target.h (class process_stratum_target)
2480         <stratum>: Add "final".
2481
2482 2019-04-17  Tom Tromey  <tromey@adacore.com>
2483
2484         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2485         against nullptr before use.
2486
2487 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2488
2489         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2490
2491 2019-04-17  Jim Wilson  <jimw@sifive.com>
2492             Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2495         code read might fail, assume 4-byte breakpoint in that case.
2496
2497 2019-04-15  Leszek Swirski  <leszeks@google.com>
2498
2499         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2500         rather than a hand-rolled POD check when checking for forced MEMORY
2501         classification.
2502
2503 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2504
2505         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2506         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2507         function.
2508         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2509         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2510         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2511         declaration.
2512
2513 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * aarch64-linux-nat.c
2516         (aarch64_linux_nat_target::thread_architecture): Add override.
2517         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2518         each VQ.
2519
2520 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2521
2522         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2523
2524 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2525
2526         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2527         target types of size 96-bits, add some additional comments, and
2528         check that the builtin type we found was the correct size.
2529
2530 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2531
2532         * utils.c (prompt_for_continue): Don't restore the styling at the
2533         end, as applied_style has the wrong value.  This fixes styling in
2534         long lists of file names that are interrupted by the "Continue?"
2535         prompt.
2536
2537 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2540         * c-lang.c (c_language_defn): Likewise.
2541         (cplus_language_defn): Likewise.
2542         (asm_language_defn): Likewise.
2543         (minimal_language_defn): Likewise.
2544         * d-lang.c (d_language_defn): Likewise.
2545         * f-lang.c (f_language_defn): Likewise.
2546         * go-lang.c (go_language_defn): Likewise.
2547         * language.c (unknown_language_defn): Likewise.
2548         (auto_language_defn): Likewise.
2549         * language.h (struct language_defn): Remove la_magic field.
2550         (LANG_MAGIC): Delete.
2551         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2552         * objc-lang.c (objc_language_defn): Likewise.
2553         * opencl-lang.c (opencl_language_defn): Likewise.
2554         * p-lang.c (pascal_language_defn): Likewise.
2555         * rust-lang.c (rust_language_defn): Likewise.
2556
2557 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2558
2559         * riscv-tdep.c (riscv_type_align): New function.
2560         (riscv_type_alignment): Delete.
2561         (riscv_arg_location): Use 'type_align'.
2562         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2563
2564 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * gdbtypes.c (type_align): A struct with no non-static fields also
2567         has alignment of 1.
2568
2569 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2572         component to 0.
2573         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2574         member.
2575         (riscv_struct_info::analyse): New implementation using new
2576         analyse_inner member function.
2577         (riscv_struct_info::field_offset): New member function.
2578         (riscv_struct_info::m_offsets): New member variable.
2579         (riscv_struct_info::analyse_inner): New private member function,
2580         takes the old implementation of riscv_struct_info::analyse but
2581         extended to track field offsets.
2582         (riscv_call_arg_struct): Update the struct folding special cases
2583         to handle cases where empty C++ structs, which are non-zero
2584         length, are found.
2585         (riscv_arg_location): Initialise the length of each location, a
2586         non-zero length now indicates the location is in use.
2587         (riscv_push_dummy_call): Allow for the first location having a
2588         non-zero offset when setting up arguments.
2589         (riscv_return_value): Likewise, but for return values.
2590
2591 2019-04-11  Tom Tromey  <tromey@adacore.com>
2592
2593         * utils.c (internal_vproblem): Make "msg" const.
2594
2595 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2596
2597         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2598         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2599         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2600         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2601
2602 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2603
2604         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2605         function.
2606         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2607         of amd64_collect_native_gregset.
2608         (amd64_linux_nat_target::store_registers): Likewise.
2609
2610 2019-04-10  Tom Tromey  <tom@tromey.com>
2611
2612         * symtab.c (lookup_global_symbol_from_objfile)
2613         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2614         * objfiles.h (class separate_debug_iterator): New.
2615         (class separate_debug_range): New.
2616         (struct objfile) <separate_debug_objfiles>: New method.
2617         (objfile_separate_debug_iterate): Don't declare.
2618         * objfiles.c (separate_debug_iterator::operator++): Rename from
2619         objfile_separate_debug_iterate.
2620         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2621         iterator.
2622         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2623         iterator.
2624
2625 2019-04-10  Tom Tromey  <tom@tromey.com>
2626
2627         * symfile.c (reread_symbols): Remove old comment.
2628         * objfiles.c (free_all_objfiles): Fix a typo.
2629
2630 2019-04-10  Tom Tromey  <tom@tromey.com>
2631
2632         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2633         * minsyms.c (lookup_minimal_symbol): Use foreach.
2634         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2635         (lookup_minimal_symbol_solib_trampoline): Likewise.
2636         * symfile.c (reread_symbols): Use foreach.
2637
2638 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2639             Tom Tromey  <tromey@adacore.com>
2640
2641         PR rust/24414:
2642         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2643         (rust_lex_int_test): Change "value" to be LONGEST.
2644         (rust_lex_tests): Add test for long integer literal.
2645
2646 2019-04-09  Tom Tromey  <tromey@adacore.com>
2647
2648         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2649         to bool.
2650         (extended_remote_target::attach): Update.
2651         (remote_target::remote_notice_new_inferior): Update.
2652         (remote_target::add_current_inferior_and_thread): Update.
2653         * inferior.c (exit_inferior_1): Use "false".
2654         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2655
2656 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2657
2658         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2659         the "start" command.
2660
2661 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2662
2663         * python/py-inferior.c (infpy_thread_from_thread_handle):
2664         Adjust comments to reflect renaming of thread_from_thread_handle
2665         to thread_from_handle.  Adjust keywords.  Fix type error message.
2666         (inferior_object_methods): Add thread_from_handle.  Retain
2667         thread_from_thread_handle, but mark it as deprecated.
2668
2669 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2670
2671         * gdbthread.h (find_thread_by_handle): Revise declaration.
2672         * thread.c (find_thread_by_handle): Likewise.  Adjust
2673         implementation too.
2674         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2675         support for buffer objects as handles.
2676
2677 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2678
2679         * python/py-infthread.c (thpy_thread_handle): New function.
2680         (thread_object_methods): Register thpy_thread_handle.
2681
2682 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2683
2684         * gdbthread.h (thread_to_thread_handle): Declare.
2685         * thread.c (gdbtypes.h): Include.
2686         (thread_to_thread_handle): New function.
2687
2688         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2689         (target_thread_info_to_thread_handle): Declare.
2690         * target.c (target_thread_info_to_thread_handle): New function.
2691         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2692         * target-delegates.c: Regenerate.
2693
2694         * linux-thread-db.c (class thread_db_target): Add method
2695         thread_info_to_thread_handle.
2696         (thread_db_target::thread_info_to_thread_handle): Define.
2697         * remote.c (class remote_target): Add new method
2698         thread_info_to_thread_handle.
2699         (remote_target::thread_info_to_thread_handle): Define.
2700
2701 2019-04-08  Pedro Alves  <palves@redhat.com>
2702
2703         * common/common-exceptions.c (throw_exception): Don't create
2704         named object to throw; throw directly.
2705         (throw_it): Likewise.  Don't initialize gdb_exception::message
2706         here, with new; pass FMT and AP to the ctor instead.
2707         * common/common-exceptions.h: Include <string>.
2708         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2709         const char *, va_list)): New ctor.  Use std::make_shared.
2710         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2711         errors)): Delete.
2712         (gdb_exception_error::gdb_exception_error(enum errors, const char
2713         *, va_list)): New.
2714         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2715         Add assertion.
2716         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2717         errors)): Delete.
2718         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2719         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2720         Add assertion.
2721
2722 2019-04-08  Tom Tromey  <tom@tromey.com>
2723
2724         * valops.c (value_rtti_indirect_type): Replace throw_exception
2725         with throw.
2726         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2727         with throw.
2728         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2729         throw.
2730         * target.c (target_translate_tls_address): Replace throw_exception
2731         with throw.
2732         * stack.c (frame_apply_command_count): Replace throw_exception
2733         with throw.
2734         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2735         throw.
2736         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2737         with throw.
2738         * rs6000-tdep.c (rs6000_frame_cache)
2739         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2740         * remote.c: Replace throw_exception with throw.
2741         * record-full.c (record_full_message, record_full_wait_1)
2742         (record_full_restore): Replace throw_exception with throw.
2743         * record-btrace.c:
2744         (get_thread_current_frame_id, record_btrace_start_replaying)
2745         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2746         (cmd_record_btrace_start): Replace throw_exception with throw.
2747         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2748         throw.
2749         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2750         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2751         * linespec.c:
2752         (find_linespec_symbols): Replace throw_exception with throw.
2753         * infrun.c (displaced_step_prepare, resume): Replace
2754         throw_exception with throw.
2755         * infcmd.c (post_create_inferior): Replace throw_exception with
2756         throw.
2757         * inf-loop.c (inferior_event_handler): Replace throw_exception
2758         with throw.
2759         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2760         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2761         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2762         (get_prev_frame_always, get_frame_pc_if_available)
2763         (get_frame_address_in_block_if_available, get_frame_language):
2764         Replace throw_exception with throw.
2765         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2766         throw_exception with throw.
2767         * eval.c (fetch_subexp_value, evaluate_var_value)
2768         (evaluate_funcall, evaluate_subexp_standard): Replace
2769         throw_exception with throw.
2770         * dwarf2loc.c (call_site_find_chain)
2771         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2772         Replace throw_exception with throw.
2773         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2774         with throw.
2775         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2776         throw.
2777         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2778         * completer.c (complete_line_internal): Replace throw_exception
2779         with throw.
2780         * compile/compile-object-run.c (compile_object_run): Replace
2781         throw_exception with throw.
2782         * cli/cli-script.c (process_next_line): Replace throw_exception
2783         with throw.
2784         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2785         (btrace_enable, btrace_maint_update_pt_packets): Replace
2786         throw_exception with throw.
2787         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2788         throw_exception with throw.
2789         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2790         throw_exception with throw.
2791         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2792         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2793         * aarch64-tdep.c (aarch64_make_prologue_cache)
2794         (aarch64_make_stub_cache): Replace throw_exception with throw.
2795
2796 2019-04-08  Tom Tromey  <tom@tromey.com>
2797
2798         * common/common-exceptions.c (throw_exception): Rename from
2799         throw_exception_cxx.  Remove old copy.  Make argument const.
2800         (throw_it): Create and throw exception objects directly.
2801         * common/common-exceptions.h (throw_exception): Make argument
2802         const.
2803         (struct gdb_exception_error): Add constructor.
2804         (struct gdb_exception_quit): Add constructor.
2805
2806 2019-04-08  Tom Tromey  <tom@tromey.com>
2807
2808         * common/common-exceptions.h (exception_rethrow): Don't declare.
2809         (TRY_SJLJ): Update comment.
2810         (TRY, CATCH, END_CATCH): Remove.
2811         * common/common-exceptions.c (exception_rethrow): Remove.
2812
2813 2019-04-08  Tom Tromey  <tom@tromey.com>
2814
2815         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2816         Remove.
2817         (gdb_exception_error): Rename from
2818         gdb_exception_RETURN_MASK_ERROR.
2819         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2820         (gdb_quit_bad_alloc): Update.
2821         * aarch64-tdep.c: Update.
2822         * ada-lang.c: Update.
2823         * ada-typeprint.c: Update.
2824         * ada-valprint.c: Update.
2825         * amd64-tdep.c: Update.
2826         * arch-utils.c: Update.
2827         * break-catch-throw.c: Update.
2828         * breakpoint.c: Update.
2829         * btrace.c: Update.
2830         * c-varobj.c: Update.
2831         * cli/cli-cmds.c: Update.
2832         * cli/cli-interp.c: Update.
2833         * cli/cli-script.c: Update.
2834         * common/common-exceptions.c: Update.
2835         * common/new-op.c: Update.
2836         * common/selftest.c: Update.
2837         * compile/compile-c-symbols.c: Update.
2838         * compile/compile-cplus-symbols.c: Update.
2839         * compile/compile-object-load.c: Update.
2840         * compile/compile-object-run.c: Update.
2841         * completer.c: Update.
2842         * corelow.c: Update.
2843         * cp-abi.c: Update.
2844         * cp-support.c: Update.
2845         * cp-valprint.c: Update.
2846         * darwin-nat.c: Update.
2847         * disasm-selftests.c: Update.
2848         * dtrace-probe.c: Update.
2849         * dwarf-index-cache.c: Update.
2850         * dwarf-index-write.c: Update.
2851         * dwarf2-frame-tailcall.c: Update.
2852         * dwarf2-frame.c: Update.
2853         * dwarf2loc.c: Update.
2854         * dwarf2read.c: Update.
2855         * eval.c: Update.
2856         * event-loop.c: Update.
2857         * event-top.c: Update.
2858         * exec.c: Update.
2859         * f-valprint.c: Update.
2860         * fbsd-tdep.c: Update.
2861         * frame-unwind.c: Update.
2862         * frame.c: Update.
2863         * gdbtypes.c: Update.
2864         * gnu-v3-abi.c: Update.
2865         * guile/guile-internal.h: Update.
2866         * guile/scm-block.c: Update.
2867         * guile/scm-breakpoint.c: Update.
2868         * guile/scm-cmd.c: Update.
2869         * guile/scm-disasm.c: Update.
2870         * guile/scm-frame.c: Update.
2871         * guile/scm-lazy-string.c: Update.
2872         * guile/scm-math.c: Update.
2873         * guile/scm-param.c: Update.
2874         * guile/scm-ports.c: Update.
2875         * guile/scm-pretty-print.c: Update.
2876         * guile/scm-symbol.c: Update.
2877         * guile/scm-symtab.c: Update.
2878         * guile/scm-type.c: Update.
2879         * guile/scm-value.c: Update.
2880         * i386-linux-tdep.c: Update.
2881         * i386-tdep.c: Update.
2882         * inf-loop.c: Update.
2883         * infcall.c: Update.
2884         * infcmd.c: Update.
2885         * infrun.c: Update.
2886         * jit.c: Update.
2887         * language.c: Update.
2888         * linespec.c: Update.
2889         * linux-fork.c: Update.
2890         * linux-nat.c: Update.
2891         * linux-tdep.c: Update.
2892         * linux-thread-db.c: Update.
2893         * main.c: Update.
2894         * mi/mi-cmd-break.c: Update.
2895         * mi/mi-cmd-stack.c: Update.
2896         * mi/mi-interp.c: Update.
2897         * mi/mi-main.c: Update.
2898         * objc-lang.c: Update.
2899         * p-valprint.c: Update.
2900         * parse.c: Update.
2901         * ppc-linux-tdep.c: Update.
2902         * printcmd.c: Update.
2903         * python/py-arch.c: Update.
2904         * python/py-breakpoint.c: Update.
2905         * python/py-cmd.c: Update.
2906         * python/py-finishbreakpoint.c: Update.
2907         * python/py-frame.c: Update.
2908         * python/py-framefilter.c: Update.
2909         * python/py-gdb-readline.c: Update.
2910         * python/py-inferior.c: Update.
2911         * python/py-infthread.c: Update.
2912         * python/py-lazy-string.c: Update.
2913         * python/py-linetable.c: Update.
2914         * python/py-objfile.c: Update.
2915         * python/py-param.c: Update.
2916         * python/py-prettyprint.c: Update.
2917         * python/py-progspace.c: Update.
2918         * python/py-record-btrace.c: Update.
2919         * python/py-record.c: Update.
2920         * python/py-symbol.c: Update.
2921         * python/py-type.c: Update.
2922         * python/py-unwind.c: Update.
2923         * python/py-utils.c: Update.
2924         * python/py-value.c: Update.
2925         * python/python.c: Update.
2926         * record-btrace.c: Update.
2927         * record-full.c: Update.
2928         * remote-fileio.c: Update.
2929         * remote.c: Update.
2930         * riscv-tdep.c: Update.
2931         * rs6000-aix-tdep.c: Update.
2932         * rs6000-tdep.c: Update.
2933         * rust-exp.y: Update.
2934         * rust-lang.c: Update.
2935         * s390-tdep.c: Update.
2936         * selftest-arch.c: Update.
2937         * solib-dsbt.c: Update.
2938         * solib-frv.c: Update.
2939         * solib-spu.c: Update.
2940         * solib-svr4.c: Update.
2941         * solib.c: Update.
2942         * sparc64-linux-tdep.c: Update.
2943         * stack.c: Update.
2944         * symfile-mem.c: Update.
2945         * symmisc.c: Update.
2946         * target.c: Update.
2947         * thread.c: Update.
2948         * top.c: Update.
2949         * tracefile-tfile.c: Update.
2950         * tui/tui.c: Update.
2951         * typeprint.c: Update.
2952         * unittests/cli-utils-selftests.c: Update.
2953         * unittests/parse-connection-spec-selftests.c: Update.
2954         * valops.c: Update.
2955         * valprint.c: Update.
2956         * value.c: Update.
2957         * varobj.c: Update.
2958         * windows-nat.c: Update.
2959         * x86-linux-nat.c: Update.
2960         * xml-support.c: Update.
2961
2962 2019-04-08  Tom Tromey  <tom@tromey.com>
2963
2964         * xml-support.c: Use C++ exception handling.
2965         * x86-linux-nat.c: Use C++ exception handling.
2966         * windows-nat.c: Use C++ exception handling.
2967         * varobj.c: Use C++ exception handling.
2968         * value.c: Use C++ exception handling.
2969         * valprint.c: Use C++ exception handling.
2970         * valops.c: Use C++ exception handling.
2971         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2972         handling.
2973         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2974         * typeprint.c: Use C++ exception handling.
2975         * tui/tui.c: Use C++ exception handling.
2976         * tracefile-tfile.c: Use C++ exception handling.
2977         * top.c: Use C++ exception handling.
2978         * thread.c: Use C++ exception handling.
2979         * target.c: Use C++ exception handling.
2980         * symmisc.c: Use C++ exception handling.
2981         * symfile-mem.c: Use C++ exception handling.
2982         * stack.c: Use C++ exception handling.
2983         * sparc64-linux-tdep.c: Use C++ exception handling.
2984         * solib.c: Use C++ exception handling.
2985         * solib-svr4.c: Use C++ exception handling.
2986         * solib-spu.c: Use C++ exception handling.
2987         * solib-frv.c: Use C++ exception handling.
2988         * solib-dsbt.c: Use C++ exception handling.
2989         * selftest-arch.c: Use C++ exception handling.
2990         * s390-tdep.c: Use C++ exception handling.
2991         * rust-lang.c: Use C++ exception handling.
2992         * rust-exp.y: Use C++ exception handling.
2993         * rs6000-tdep.c: Use C++ exception handling.
2994         * rs6000-aix-tdep.c: Use C++ exception handling.
2995         * riscv-tdep.c: Use C++ exception handling.
2996         * remote.c: Use C++ exception handling.
2997         * remote-fileio.c: Use C++ exception handling.
2998         * record-full.c: Use C++ exception handling.
2999         * record-btrace.c: Use C++ exception handling.
3000         * python/python.c: Use C++ exception handling.
3001         * python/py-value.c: Use C++ exception handling.
3002         * python/py-utils.c: Use C++ exception handling.
3003         * python/py-unwind.c: Use C++ exception handling.
3004         * python/py-type.c: Use C++ exception handling.
3005         * python/py-symbol.c: Use C++ exception handling.
3006         * python/py-record.c: Use C++ exception handling.
3007         * python/py-record-btrace.c: Use C++ exception handling.
3008         * python/py-progspace.c: Use C++ exception handling.
3009         * python/py-prettyprint.c: Use C++ exception handling.
3010         * python/py-param.c: Use C++ exception handling.
3011         * python/py-objfile.c: Use C++ exception handling.
3012         * python/py-linetable.c: Use C++ exception handling.
3013         * python/py-lazy-string.c: Use C++ exception handling.
3014         * python/py-infthread.c: Use C++ exception handling.
3015         * python/py-inferior.c: Use C++ exception handling.
3016         * python/py-gdb-readline.c: Use C++ exception handling.
3017         * python/py-framefilter.c: Use C++ exception handling.
3018         * python/py-frame.c: Use C++ exception handling.
3019         * python/py-finishbreakpoint.c: Use C++ exception handling.
3020         * python/py-cmd.c: Use C++ exception handling.
3021         * python/py-breakpoint.c: Use C++ exception handling.
3022         * python/py-arch.c: Use C++ exception handling.
3023         * printcmd.c: Use C++ exception handling.
3024         * ppc-linux-tdep.c: Use C++ exception handling.
3025         * parse.c: Use C++ exception handling.
3026         * p-valprint.c: Use C++ exception handling.
3027         * objc-lang.c: Use C++ exception handling.
3028         * mi/mi-main.c: Use C++ exception handling.
3029         * mi/mi-interp.c: Use C++ exception handling.
3030         * mi/mi-cmd-stack.c: Use C++ exception handling.
3031         * mi/mi-cmd-break.c: Use C++ exception handling.
3032         * main.c: Use C++ exception handling.
3033         * linux-thread-db.c: Use C++ exception handling.
3034         * linux-tdep.c: Use C++ exception handling.
3035         * linux-nat.c: Use C++ exception handling.
3036         * linux-fork.c: Use C++ exception handling.
3037         * linespec.c: Use C++ exception handling.
3038         * language.c: Use C++ exception handling.
3039         * jit.c: Use C++ exception handling.
3040         * infrun.c: Use C++ exception handling.
3041         * infcmd.c: Use C++ exception handling.
3042         * infcall.c: Use C++ exception handling.
3043         * inf-loop.c: Use C++ exception handling.
3044         * i386-tdep.c: Use C++ exception handling.
3045         * i386-linux-tdep.c: Use C++ exception handling.
3046         * guile/scm-value.c: Use C++ exception handling.
3047         * guile/scm-type.c: Use C++ exception handling.
3048         * guile/scm-symtab.c: Use C++ exception handling.
3049         * guile/scm-symbol.c: Use C++ exception handling.
3050         * guile/scm-pretty-print.c: Use C++ exception handling.
3051         * guile/scm-ports.c: Use C++ exception handling.
3052         * guile/scm-param.c: Use C++ exception handling.
3053         * guile/scm-math.c: Use C++ exception handling.
3054         * guile/scm-lazy-string.c: Use C++ exception handling.
3055         * guile/scm-frame.c: Use C++ exception handling.
3056         * guile/scm-disasm.c: Use C++ exception handling.
3057         * guile/scm-cmd.c: Use C++ exception handling.
3058         * guile/scm-breakpoint.c: Use C++ exception handling.
3059         * guile/scm-block.c: Use C++ exception handling.
3060         * guile/guile-internal.h: Use C++ exception handling.
3061         * gnu-v3-abi.c: Use C++ exception handling.
3062         * gdbtypes.c: Use C++ exception handling.
3063         * frame.c: Use C++ exception handling.
3064         * frame-unwind.c: Use C++ exception handling.
3065         * fbsd-tdep.c: Use C++ exception handling.
3066         * f-valprint.c: Use C++ exception handling.
3067         * exec.c: Use C++ exception handling.
3068         * event-top.c: Use C++ exception handling.
3069         * event-loop.c: Use C++ exception handling.
3070         * eval.c: Use C++ exception handling.
3071         * dwarf2read.c: Use C++ exception handling.
3072         * dwarf2loc.c: Use C++ exception handling.
3073         * dwarf2-frame.c: Use C++ exception handling.
3074         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3075         * dwarf-index-write.c: Use C++ exception handling.
3076         * dwarf-index-cache.c: Use C++ exception handling.
3077         * dtrace-probe.c: Use C++ exception handling.
3078         * disasm-selftests.c: Use C++ exception handling.
3079         * darwin-nat.c: Use C++ exception handling.
3080         * cp-valprint.c: Use C++ exception handling.
3081         * cp-support.c: Use C++ exception handling.
3082         * cp-abi.c: Use C++ exception handling.
3083         * corelow.c: Use C++ exception handling.
3084         * completer.c: Use C++ exception handling.
3085         * compile/compile-object-run.c: Use C++ exception handling.
3086         * compile/compile-object-load.c: Use C++ exception handling.
3087         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3088         * compile/compile-c-symbols.c: Use C++ exception handling.
3089         * common/selftest.c: Use C++ exception handling.
3090         * common/new-op.c: Use C++ exception handling.
3091         * cli/cli-script.c: Use C++ exception handling.
3092         * cli/cli-interp.c: Use C++ exception handling.
3093         * cli/cli-cmds.c: Use C++ exception handling.
3094         * c-varobj.c: Use C++ exception handling.
3095         * btrace.c: Use C++ exception handling.
3096         * breakpoint.c: Use C++ exception handling.
3097         * break-catch-throw.c: Use C++ exception handling.
3098         * arch-utils.c: Use C++ exception handling.
3099         * amd64-tdep.c: Use C++ exception handling.
3100         * ada-valprint.c: Use C++ exception handling.
3101         * ada-typeprint.c: Use C++ exception handling.
3102         * ada-lang.c: Use C++ exception handling.
3103         * aarch64-tdep.c: Use C++ exception handling.
3104
3105 2019-04-08  Tom Tromey  <tom@tromey.com>
3106
3107         * xml-support.c (gdb_xml_parser::parse): Update.
3108         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3109         * value.c (show_convenience): Update.
3110         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3111         (test_parse_flags_qcs): Update.
3112         * thread.c (thr_try_catch_cmd): Update.
3113         * target.c (target_translate_tls_address): Update.
3114         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3115         (info_frame_command_core, frame_apply_command_count): Update.
3116         * rust-exp.y (rust_lex_exception_test): Update.
3117         * riscv-tdep.c (riscv_print_one_register_info): Update.
3118         * remote.c (remote_target::enable_btrace): Update.
3119         * record-btrace.c (record_btrace_enable_warn): Update.
3120         * python/py-utils.c (gdbpy_convert_exception): Update.
3121         * printcmd.c (do_one_display, print_variable_and_value): Update.
3122         * mi/mi-main.c (mi_print_exception): Update.
3123         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3124         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3125         * linux-nat.c (linux_nat_target::attach): Update.
3126         * linux-fork.c (class scoped_switch_fork_info): Update.
3127         * infrun.c (displaced_step_prepare): Update.
3128         * infcall.c (call_function_by_hand_dummy): Update.
3129         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3130         * gnu-v3-abi.c (print_one_vtable): Update.
3131         * frame.c (get_prev_frame_always): Update.
3132         * f-valprint.c (info_common_command_for_block): Update.
3133         * exec.c (try_open_exec_file): Update.
3134         * exceptions.c (print_exception, exception_print)
3135         (exception_fprintf, exception_print_same): Update.
3136         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3137         * dwarf-index-cache.c (index_cache::store)
3138         (index_cache::lookup_gdb_index): Update.
3139         * darwin-nat.c (maybe_cache_shell): Update.
3140         * cp-valprint.c (cp_print_value_fields): Update.
3141         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3142         (gcc_cplus_symbol_address): Update.
3143         * compile/compile-c-symbols.c (gcc_convert_symbol)
3144         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3145         * common/selftest.c: Update.
3146         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3147         a std::string.
3148         (exception_try_scope_entry, exception_try_scope_exit): Don't
3149         declare.
3150         (struct exception_try_scope): Remove.
3151         (TRY): Don't use exception_try_scope.
3152         (struct gdb_exception): Add constructor, operator=.
3153         <what>: New method.
3154         (struct gdb_exception_RETURN_MASK_ALL)
3155         (struct gdb_exception_RETURN_MASK_ERROR)
3156         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3157         (struct gdb_quit_bad_alloc): Update.
3158         * common/common-exceptions.c (exception_none): Change
3159         initializer.
3160         (struct catcher) <state, exception>: Initialize inline.
3161         <prev>: Remove member.
3162         (current_catcher): Remove.
3163         (catchers): New global.
3164         (exceptions_state_mc_init): Simplify.
3165         (catcher_pop): Remove.
3166         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3167         (try_scope_depth, exception_try_scope_entry)
3168         (exception_try_scope_exit): Remove.
3169         (throw_exception_sjlj): Update.
3170         (exception_messages, exception_messages_size): Remove.
3171         (throw_it): Simplify.
3172         (gdb_exception_sliced_copy): Remove.
3173         (throw_exception_cxx): Update.
3174         * cli/cli-script.c (script_from_file): Update.
3175         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3176         Update.
3177         * ada-valprint.c (ada_val_print): Update.
3178         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3179         (create_excep_cond_exprs): Update.
3180
3181 2019-04-08  Tom Tromey  <tom@tromey.com>
3182
3183         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3184         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3185         (TRY, CATCH, END_CATCH): Remove some definitions.
3186         * common/common-exceptions.c: Don't use GDB_XCPT.
3187         (catcher_list_size): Remove.
3188         (throw_exception, throw_it): Simplify.
3189
3190 2019-04-05  Tom Tromey  <tom@tromey.com>
3191
3192         Revert the header-sorting patch.
3193         * ft32-tdep.c: Revert.
3194         * frv-tdep.c: Revert.
3195         * frv-linux-tdep.c: Revert.
3196         * frame.c: Revert.
3197         * frame-unwind.c: Revert.
3198         * frame-base.c: Revert.
3199         * fork-child.c: Revert.
3200         * findvar.c: Revert.
3201         * findcmd.c: Revert.
3202         * filesystem.c: Revert.
3203         * filename-seen-cache.h: Revert.
3204         * filename-seen-cache.c: Revert.
3205         * fbsd-tdep.c: Revert.
3206         * fbsd-nat.h: Revert.
3207         * fbsd-nat.c: Revert.
3208         * f-valprint.c: Revert.
3209         * f-typeprint.c: Revert.
3210         * f-lang.c: Revert.
3211         * extension.h: Revert.
3212         * extension.c: Revert.
3213         * extension-priv.h: Revert.
3214         * expprint.c: Revert.
3215         * exec.h: Revert.
3216         * exec.c: Revert.
3217         * exceptions.c: Revert.
3218         * event-top.c: Revert.
3219         * event-loop.c: Revert.
3220         * eval.c: Revert.
3221         * elfread.c: Revert.
3222         * dwarf2read.h: Revert.
3223         * dwarf2read.c: Revert.
3224         * dwarf2loc.c: Revert.
3225         * dwarf2expr.h: Revert.
3226         * dwarf2expr.c: Revert.
3227         * dwarf2-frame.c: Revert.
3228         * dwarf2-frame-tailcall.c: Revert.
3229         * dwarf-index-write.h: Revert.
3230         * dwarf-index-write.c: Revert.
3231         * dwarf-index-common.c: Revert.
3232         * dwarf-index-cache.h: Revert.
3233         * dwarf-index-cache.c: Revert.
3234         * dummy-frame.c: Revert.
3235         * dtrace-probe.c: Revert.
3236         * disasm.h: Revert.
3237         * disasm.c: Revert.
3238         * disasm-selftests.c: Revert.
3239         * dictionary.c: Revert.
3240         * dicos-tdep.c: Revert.
3241         * demangle.c: Revert.
3242         * dcache.h: Revert.
3243         * dcache.c: Revert.
3244         * darwin-nat.h: Revert.
3245         * darwin-nat.c: Revert.
3246         * darwin-nat-info.c: Revert.
3247         * d-valprint.c: Revert.
3248         * d-namespace.c: Revert.
3249         * d-lang.c: Revert.
3250         * ctf.c: Revert.
3251         * csky-tdep.c: Revert.
3252         * csky-linux-tdep.c: Revert.
3253         * cris-tdep.c: Revert.
3254         * cris-linux-tdep.c: Revert.
3255         * cp-valprint.c: Revert.
3256         * cp-support.c: Revert.
3257         * cp-namespace.c: Revert.
3258         * cp-abi.c: Revert.
3259         * corelow.c: Revert.
3260         * corefile.c: Revert.
3261         * continuations.c: Revert.
3262         * completer.h: Revert.
3263         * completer.c: Revert.
3264         * complaints.c: Revert.
3265         * coffread.c: Revert.
3266         * coff-pe-read.c: Revert.
3267         * cli-out.h: Revert.
3268         * cli-out.c: Revert.
3269         * charset.c: Revert.
3270         * c-varobj.c: Revert.
3271         * c-valprint.c: Revert.
3272         * c-typeprint.c: Revert.
3273         * c-lang.c: Revert.
3274         * buildsym.c: Revert.
3275         * buildsym-legacy.c: Revert.
3276         * build-id.h: Revert.
3277         * build-id.c: Revert.
3278         * btrace.c: Revert.
3279         * bsd-uthread.c: Revert.
3280         * breakpoint.h: Revert.
3281         * breakpoint.c: Revert.
3282         * break-catch-throw.c: Revert.
3283         * break-catch-syscall.c: Revert.
3284         * break-catch-sig.c: Revert.
3285         * blockframe.c: Revert.
3286         * block.c: Revert.
3287         * bfin-tdep.c: Revert.
3288         * bfin-linux-tdep.c: Revert.
3289         * bfd-target.c: Revert.
3290         * bcache.c: Revert.
3291         * ax-general.c: Revert.
3292         * ax-gdb.h: Revert.
3293         * ax-gdb.c: Revert.
3294         * avr-tdep.c: Revert.
3295         * auxv.c: Revert.
3296         * auto-load.c: Revert.
3297         * arm-wince-tdep.c: Revert.
3298         * arm-tdep.c: Revert.
3299         * arm-symbian-tdep.c: Revert.
3300         * arm-pikeos-tdep.c: Revert.
3301         * arm-obsd-tdep.c: Revert.
3302         * arm-nbsd-tdep.c: Revert.
3303         * arm-nbsd-nat.c: Revert.
3304         * arm-linux-tdep.c: Revert.
3305         * arm-linux-nat.c: Revert.
3306         * arm-fbsd-tdep.c: Revert.
3307         * arm-fbsd-nat.c: Revert.
3308         * arm-bsd-tdep.c: Revert.
3309         * arch-utils.c: Revert.
3310         * arc-tdep.c: Revert.
3311         * arc-newlib-tdep.c: Revert.
3312         * annotate.h: Revert.
3313         * annotate.c: Revert.
3314         * amd64-windows-tdep.c: Revert.
3315         * amd64-windows-nat.c: Revert.
3316         * amd64-tdep.c: Revert.
3317         * amd64-sol2-tdep.c: Revert.
3318         * amd64-obsd-tdep.c: Revert.
3319         * amd64-obsd-nat.c: Revert.
3320         * amd64-nbsd-tdep.c: Revert.
3321         * amd64-nbsd-nat.c: Revert.
3322         * amd64-nat.c: Revert.
3323         * amd64-linux-tdep.c: Revert.
3324         * amd64-linux-nat.c: Revert.
3325         * amd64-fbsd-tdep.c: Revert.
3326         * amd64-fbsd-nat.c: Revert.
3327         * amd64-dicos-tdep.c: Revert.
3328         * amd64-darwin-tdep.c: Revert.
3329         * amd64-bsd-nat.c: Revert.
3330         * alpha-tdep.c: Revert.
3331         * alpha-obsd-tdep.c: Revert.
3332         * alpha-nbsd-tdep.c: Revert.
3333         * alpha-mdebug-tdep.c: Revert.
3334         * alpha-linux-tdep.c: Revert.
3335         * alpha-linux-nat.c: Revert.
3336         * alpha-bsd-tdep.c: Revert.
3337         * alpha-bsd-nat.c: Revert.
3338         * aix-thread.c: Revert.
3339         * agent.c: Revert.
3340         * addrmap.c: Revert.
3341         * ada-varobj.c: Revert.
3342         * ada-valprint.c: Revert.
3343         * ada-typeprint.c: Revert.
3344         * ada-tasks.c: Revert.
3345         * ada-lang.c: Revert.
3346         * aarch64-tdep.c: Revert.
3347         * aarch64-ravenscar-thread.c: Revert.
3348         * aarch64-newlib-tdep.c: Revert.
3349         * aarch64-linux-tdep.c: Revert.
3350         * aarch64-linux-nat.c: Revert.
3351         * aarch64-fbsd-tdep.c: Revert.
3352         * aarch64-fbsd-nat.c: Revert.
3353         * aarch32-linux-nat.c: Revert.
3354
3355 2019-04-05  Tom Tromey  <tom@tromey.com>
3356
3357         * ft32-tdep.c: Sort headers.
3358         * frv-tdep.c: Sort headers.
3359         * frv-linux-tdep.c: Sort headers.
3360         * frame.c: Sort headers.
3361         * frame-unwind.c: Sort headers.
3362         * frame-base.c: Sort headers.
3363         * fork-child.c: Sort headers.
3364         * findvar.c: Sort headers.
3365         * findcmd.c: Sort headers.
3366         * filesystem.c: Sort headers.
3367         * filename-seen-cache.h: Sort headers.
3368         * filename-seen-cache.c: Sort headers.
3369         * fbsd-tdep.c: Sort headers.
3370         * fbsd-nat.h: Sort headers.
3371         * fbsd-nat.c: Sort headers.
3372         * f-valprint.c: Sort headers.
3373         * f-typeprint.c: Sort headers.
3374         * f-lang.c: Sort headers.
3375         * extension.h: Sort headers.
3376         * extension.c: Sort headers.
3377         * extension-priv.h: Sort headers.
3378         * expprint.c: Sort headers.
3379         * exec.h: Sort headers.
3380         * exec.c: Sort headers.
3381         * exceptions.c: Sort headers.
3382         * event-top.c: Sort headers.
3383         * event-loop.c: Sort headers.
3384         * eval.c: Sort headers.
3385         * elfread.c: Sort headers.
3386         * dwarf2read.h: Sort headers.
3387         * dwarf2read.c: Sort headers.
3388         * dwarf2loc.c: Sort headers.
3389         * dwarf2expr.h: Sort headers.
3390         * dwarf2expr.c: Sort headers.
3391         * dwarf2-frame.c: Sort headers.
3392         * dwarf2-frame-tailcall.c: Sort headers.
3393         * dwarf-index-write.h: Sort headers.
3394         * dwarf-index-write.c: Sort headers.
3395         * dwarf-index-common.c: Sort headers.
3396         * dwarf-index-cache.h: Sort headers.
3397         * dwarf-index-cache.c: Sort headers.
3398         * dummy-frame.c: Sort headers.
3399         * dtrace-probe.c: Sort headers.
3400         * disasm.h: Sort headers.
3401         * disasm.c: Sort headers.
3402         * disasm-selftests.c: Sort headers.
3403         * dictionary.c: Sort headers.
3404         * dicos-tdep.c: Sort headers.
3405         * demangle.c: Sort headers.
3406         * dcache.h: Sort headers.
3407         * dcache.c: Sort headers.
3408         * darwin-nat.h: Sort headers.
3409         * darwin-nat.c: Sort headers.
3410         * darwin-nat-info.c: Sort headers.
3411         * d-valprint.c: Sort headers.
3412         * d-namespace.c: Sort headers.
3413         * d-lang.c: Sort headers.
3414         * ctf.c: Sort headers.
3415         * csky-tdep.c: Sort headers.
3416         * csky-linux-tdep.c: Sort headers.
3417         * cris-tdep.c: Sort headers.
3418         * cris-linux-tdep.c: Sort headers.
3419         * cp-valprint.c: Sort headers.
3420         * cp-support.c: Sort headers.
3421         * cp-namespace.c: Sort headers.
3422         * cp-abi.c: Sort headers.
3423         * corelow.c: Sort headers.
3424         * corefile.c: Sort headers.
3425         * continuations.c: Sort headers.
3426         * completer.h: Sort headers.
3427         * completer.c: Sort headers.
3428         * complaints.c: Sort headers.
3429         * coffread.c: Sort headers.
3430         * coff-pe-read.c: Sort headers.
3431         * cli-out.h: Sort headers.
3432         * cli-out.c: Sort headers.
3433         * charset.c: Sort headers.
3434         * c-varobj.c: Sort headers.
3435         * c-valprint.c: Sort headers.
3436         * c-typeprint.c: Sort headers.
3437         * c-lang.c: Sort headers.
3438         * buildsym.c: Sort headers.
3439         * buildsym-legacy.c: Sort headers.
3440         * build-id.h: Sort headers.
3441         * build-id.c: Sort headers.
3442         * btrace.c: Sort headers.
3443         * bsd-uthread.c: Sort headers.
3444         * breakpoint.h: Sort headers.
3445         * breakpoint.c: Sort headers.
3446         * break-catch-throw.c: Sort headers.
3447         * break-catch-syscall.c: Sort headers.
3448         * break-catch-sig.c: Sort headers.
3449         * blockframe.c: Sort headers.
3450         * block.c: Sort headers.
3451         * bfin-tdep.c: Sort headers.
3452         * bfin-linux-tdep.c: Sort headers.
3453         * bfd-target.c: Sort headers.
3454         * bcache.c: Sort headers.
3455         * ax-general.c: Sort headers.
3456         * ax-gdb.h: Sort headers.
3457         * ax-gdb.c: Sort headers.
3458         * avr-tdep.c: Sort headers.
3459         * auxv.c: Sort headers.
3460         * auto-load.c: Sort headers.
3461         * arm-wince-tdep.c: Sort headers.
3462         * arm-tdep.c: Sort headers.
3463         * arm-symbian-tdep.c: Sort headers.
3464         * arm-pikeos-tdep.c: Sort headers.
3465         * arm-obsd-tdep.c: Sort headers.
3466         * arm-nbsd-tdep.c: Sort headers.
3467         * arm-nbsd-nat.c: Sort headers.
3468         * arm-linux-tdep.c: Sort headers.
3469         * arm-linux-nat.c: Sort headers.
3470         * arm-fbsd-tdep.c: Sort headers.
3471         * arm-fbsd-nat.c: Sort headers.
3472         * arm-bsd-tdep.c: Sort headers.
3473         * arch-utils.c: Sort headers.
3474         * arc-tdep.c: Sort headers.
3475         * arc-newlib-tdep.c: Sort headers.
3476         * annotate.h: Sort headers.
3477         * annotate.c: Sort headers.
3478         * amd64-windows-tdep.c: Sort headers.
3479         * amd64-windows-nat.c: Sort headers.
3480         * amd64-tdep.c: Sort headers.
3481         * amd64-sol2-tdep.c: Sort headers.
3482         * amd64-obsd-tdep.c: Sort headers.
3483         * amd64-obsd-nat.c: Sort headers.
3484         * amd64-nbsd-tdep.c: Sort headers.
3485         * amd64-nbsd-nat.c: Sort headers.
3486         * amd64-nat.c: Sort headers.
3487         * amd64-linux-tdep.c: Sort headers.
3488         * amd64-linux-nat.c: Sort headers.
3489         * amd64-fbsd-tdep.c: Sort headers.
3490         * amd64-fbsd-nat.c: Sort headers.
3491         * amd64-dicos-tdep.c: Sort headers.
3492         * amd64-darwin-tdep.c: Sort headers.
3493         * amd64-bsd-nat.c: Sort headers.
3494         * alpha-tdep.c: Sort headers.
3495         * alpha-obsd-tdep.c: Sort headers.
3496         * alpha-nbsd-tdep.c: Sort headers.
3497         * alpha-mdebug-tdep.c: Sort headers.
3498         * alpha-linux-tdep.c: Sort headers.
3499         * alpha-linux-nat.c: Sort headers.
3500         * alpha-bsd-tdep.c: Sort headers.
3501         * alpha-bsd-nat.c: Sort headers.
3502         * aix-thread.c: Sort headers.
3503         * agent.c: Sort headers.
3504         * addrmap.c: Sort headers.
3505         * ada-varobj.c: Sort headers.
3506         * ada-valprint.c: Sort headers.
3507         * ada-typeprint.c: Sort headers.
3508         * ada-tasks.c: Sort headers.
3509         * ada-lang.c: Sort headers.
3510         * aarch64-tdep.c: Sort headers.
3511         * aarch64-ravenscar-thread.c: Sort headers.
3512         * aarch64-newlib-tdep.c: Sort headers.
3513         * aarch64-linux-tdep.c: Sort headers.
3514         * aarch64-linux-nat.c: Sort headers.
3515         * aarch64-fbsd-tdep.c: Sort headers.
3516         * aarch64-fbsd-nat.c: Sort headers.
3517         * aarch32-linux-nat.c: Sort headers.
3518
3519 2019-04-04  Tom Tromey  <tom@tromey.com>
3520
3521         * varobj.c (varobj_create): Update.
3522         * rust-exp.y (struct rust_parser) <update_innermost_block,
3523         lookup_symbol>: New methods.
3524         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3525         Rename.
3526         (rust_parser::rust_lookup_type)
3527         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3528         * printcmd.c (display_command, do_one_display): Update.
3529         * parser-defs.h (struct parser_state) <parser_state>: Add
3530         "tracker" parameter.
3531         (block_tracker): New member.
3532         (class innermost_block_tracker) <innermost_block_tracker>: Add
3533         "types" parameter.
3534         <reset>: Remove method.
3535         (innermost_block): Don't declare.
3536         (null_post_parser): Update.
3537         * parse.c (innermost_block): Remove global.
3538         (write_dollar_variable): Update.
3539         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3540         Remove "tracker_types" parameter.
3541         (parse_expression): Add "tracker" parameter.
3542         (parse_expression_for_completion): Update.
3543         (null_post_parser): Add "tracker" parameter.
3544         * p-exp.y: Update rules.
3545         * m2-exp.y: Update rules.
3546         * language.h (struct language_defn) <la_post_parser>: Add
3547         "tracker" parameter.
3548         * go-exp.y: Update rules.
3549         * f-exp.y: Update rules.
3550         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3551         parameter.
3552         * d-exp.y: Update rules.
3553         * c-exp.y: Update rules.
3554         * breakpoint.c (set_breakpoint_condition): Create an
3555         innermost_block_tracker.
3556         (watch_command_1): Likewise.
3557         * ada-lang.c (resolve): Add "tracker" parameter.
3558         (resolve_subexp): Likewise.
3559         * ada-exp.y (write_var_from_sym): Update.
3560
3561 2019-04-04  Tom Tromey  <tom@tromey.com>
3562
3563         * type-stack.h: New file.
3564         * type-stack.c: New file.
3565         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3566         type-stack.h.
3567         (insert_into_type_stack, insert_type, push_type, push_type_int)
3568         (insert_type_address_space, pop_type, pop_type_int)
3569         (pop_typelist, pop_type_stack, append_type_stack)
3570         (push_type_stack, get_type_stack, push_typelist)
3571         (follow_type_instance_flags, follow_types): Don't declare.
3572         * parse.c (type_stack): Remove global.
3573         (parse_exp_in_context): Update.
3574         (insert_into_type_stack, insert_type, push_type, push_type_int)
3575         (insert_type_address_space, pop_type, pop_type_int)
3576         (pop_typelist, pop_type_stack, append_type_stack)
3577         (push_type_stack, get_type_stack, push_typelist)
3578         (follow_type_instance_flags, follow_types): Remove (moved to
3579         type-stack.c).
3580         * f-exp.y (type_stack): New global.
3581         Update rules.
3582         (push_kind_type, f_parse): Update.
3583         * d-exp.y (type_stack): New global.
3584         Update rules.
3585         (d_parse): Update.
3586         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3587         Update rules.
3588         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3589         (HFILES_NO_SRCDIR): Add type-stack.h.
3590
3591 2019-04-04  Tom Tromey  <tom@tromey.com>
3592
3593         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3594         (rust_parser::convert_ast_to_expression, rust_parse)
3595         (rust_lex_test_completion, rust_lex_tests): Update.
3596         * parser-defs.h (struct expr_completion_state): New.
3597         (struct parser_state) <parser_state>: Add completion parameter.
3598         <mark_struct_expression, mark_completion_tag>: New methods.
3599         <parse_completion, m_completion_state>: New members.
3600         (prefixify_expression, null_post_parser): Update.
3601         (mark_struct_expression, mark_completion_tag): Don't declare.
3602         * parse.c (parse_completion, expout_last_struct)
3603         (expout_tag_completion_type, expout_completion_name): Remove
3604         globals.
3605         (parser_state::mark_struct_expression)
3606         (parser_state::mark_completion_tag): Now methods.
3607         (prefixify_expression): Add last_struct parameter.
3608         (prefixify_subexp): Likewise.
3609         (parse_exp_1): Update.
3610         (parse_exp_in_context): Add cstate parameter.  Update.
3611         (parse_expression_for_completion): Create an
3612         expr_completion_state.
3613         (null_post_parser): Add "completion" parameter.
3614         * p-exp.y: Update rules.
3615         (yylex): Update.
3616         * language.h (struct language_defn) <la_post_parser>: Add
3617         "completing" parameter.
3618         * go-exp.y: Update rules.
3619         (lex_one_token): Update.
3620         * expression.h (parse_completion): Don't declare.
3621         * d-exp.y: Update rules.
3622         (lex_one_token): Update rules.
3623         * c-exp.y: Update rules.
3624         (lex_one_token): Update.
3625         * ada-lang.c (resolve): Add "parse_completion" parameter.
3626         (resolve_subexp): Likewise.
3627         (ada_resolve_function): Likewise.
3628
3629 2019-04-04  Tom Tromey  <tom@tromey.com>
3630
3631         * parser-defs.h (struct parser_state) <start_arglist,
3632         end_arglist>: New methods.
3633         <arglist_len, m_funcall_chain>: New members.
3634         (arglist_len, start_arglist, end_arglist): Don't declare.
3635         * parse.c (arglist_len, funcall_chain): Remove global.
3636         (start_arglist, end_arglist): Remove functions.
3637         (parse_exp_in_context): Update.
3638         * p-exp.y: Update rules.
3639         * m2-exp.y: Update rules.
3640         * go-exp.y: Update rules.
3641         * f-exp.y: Update rules.
3642         * d-exp.y: Update rules.
3643         * c-exp.y: Update rules.
3644
3645 2019-04-04  Tom Tromey  <tom@tromey.com>
3646
3647         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3648         lex_operator, push_back>: New methods.
3649         Update all rules.
3650         (rust_parser::lex_hex, lex_escape): Rename and update.
3651         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3652         (rust_parser::lex_operator): Rename and update.
3653         (rust_parser::lex_number, rustyylex, rustyyerror)
3654         (rust_lex_test_init, rust_lex_test_sequence)
3655         (rust_lex_test_push_back, rust_lex_tests): Update.
3656         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3657         parameter.
3658         <lexptr, prev_lexptr>: New members.
3659         (lexptr, prev_lexptr): Don't declare.
3660         * parse.c (lexptr, prev_lexptr): Remove globals.
3661         (parse_exp_in_context): Update.
3662         * p-exp.y (yylex, yyerror): Update.
3663         * m2-exp.y (parse_number, yylex, yyerror): Update.
3664         * go-exp.y (lex_one_token, yyerror): Update.
3665         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3666         * d-exp.y (lex_one_token, yyerror): Update.
3667         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3668         (lex_one_token, yyerror): Update.
3669         * ada-lex.l (YY_INPUT): Update.
3670         (rewind_to_char): Update.
3671         * ada-exp.y (yyerror): Update.
3672
3673 2019-04-04  Tom Tromey  <tom@tromey.com>
3674
3675         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3676         * parser-defs.h (struct parser_state) <parser_state>: Add new
3677         parameter.
3678         <comma_terminates>: New member.
3679         (comma_terminates): Don't declare global.
3680         * parse.c (comma_terminates): Remove global.
3681         (parse_exp_in_context): Update.
3682         * p-exp.y (yylex): Update.
3683         * m2-exp.y (yylex): Update.
3684         * go-exp.y (lex_one_token): Update.
3685         * f-exp.y (yylex): Update.
3686         * d-exp.y (lex_one_token): Update.
3687         * c-exp.y (lex_one_token): Update.
3688         * ada-lex.l: Update.
3689
3690 2019-04-04  Tom Tromey  <tom@tromey.com>
3691
3692         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3693         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3694         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3695         * parser-defs.h (paren_depth): Don't declare.
3696         * parse.c (paren_depth): Remove global.
3697         (parse_exp_in_context): Update.
3698         * p-exp.y (paren_depth): New global.
3699         (pascal_parse): Initialize it.
3700         * m2-exp.y (paren_depth): New global.
3701         (m2_parse): Initialize it.
3702         * go-exp.y (paren_depth): New global.
3703         (go_parse): Initialize it.
3704         * f-exp.y (paren_depth): New global.
3705         (f_parse): Initialize it.
3706         * d-exp.y (paren_depth): New global.
3707         (d_parse): Initialize it.
3708         * c-exp.y (paren_depth): New global.
3709         (c_parse): Initialize it.
3710         * ada-lex.l (paren_depth): New global.
3711         (lexer_init): Initialize it.
3712
3713 2019-04-04  Tom Tromey  <tom@tromey.com>
3714
3715         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3716         (rust_parser::convert_ast_to_type)
3717         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3718         * parser-defs.h (struct parser_state) <parser_state>: Add
3719         parameters.  Initialize new members.
3720         <expression_context_block, expression_context_pc>: New members.
3721         * parse.c (expression_context_block, expression_context_pc):
3722         Remove globals.
3723         (parse_exp_in_context): Update.
3724         * p-exp.y: Update all rules.
3725         (yylex): Update.
3726         * m2-exp.y: Update all rules.
3727         (yylex): Update.
3728         * go-exp.y (yylex): Update.
3729         * f-exp.y (yylex): Update.
3730         * d-exp.y: Update all rules.
3731         (yylex): Update.
3732         * c-exp.y: Update all rules.
3733         (lex_one_token, classify_name, yylex, c_parse): Update.
3734         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3735
3736 2019-04-04  Tom Tromey  <tom@tromey.com>
3737
3738         * gdbarch.h, gdbarch.c: Rebuild.
3739         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3740         * stap-probe.h:
3741         (struct stap_parse_info): Replace "parser_state" with
3742         "expr_builder".
3743         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3744         (parser_state): New class.
3745         * parse.c (expr_builder): Rename.
3746         (expr_builder::release): Rename.
3747         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3748         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3749         (write_exp_elt_longcst, write_exp_elt_floatcst)
3750         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3751         (write_exp_string_vector, write_exp_bitstring)
3752         (write_exp_msymbol, mark_struct_expression)
3753         (write_dollar_variable)
3754         (insert_type_address_space, increase_expout_size): Replace
3755         "parser_state" with "expr_builder".
3756         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3757         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3758         "parser_state" with "expr_builder".
3759
3760 2019-04-04  Tom Tromey  <tom@tromey.com>
3761
3762         * rust-exp.y: Replace "parse_language" with method call.
3763         * p-exp.y:
3764         (yylex): Replace "parse_language" with method call.
3765         * m2-exp.y:
3766         (yylex): Replace "parse_language" with method call.
3767         * go-exp.y (classify_name): Replace "parse_language" with method
3768         call.
3769         * f-exp.y (yylex): Replace "parse_language" with method call.
3770         * d-exp.y (lex_one_token): Replace "parse_language" with method
3771         call.
3772         * c-exp.y:
3773         (lex_one_token, classify_name, yylex): Replace "parse_language"
3774         with method call.
3775         * ada-exp.y (find_primitive_type, type_char)
3776         (type_system_address): Replace "parse_language" with method call.
3777
3778 2019-04-04  Tom Tromey  <tom@tromey.com>
3779
3780         * rust-exp.y: Replace "parse_gdbarch" with method call.
3781         * parse.c (write_dollar_variable, insert_type_address_space):
3782         Replace "parse_gdbarch" with method call.
3783         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3784         call.
3785         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3786         call.
3787         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3788         "parse_gdbarch" with method call.
3789         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3790         with method call.
3791         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3792         "parse_gdbarch" with method call.
3793         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3794         "parse_gdbarch" with method call.
3795         * c-exp.y (parse_type, parse_number, classify_name): Replace
3796         "parse_gdbarch" with method call.
3797         * ada-lex.l: Replace "parse_gdbarch" with method call.
3798         * ada-exp.y (parse_type, find_primitive_type, type_char)
3799         (type_system_address): Replace "parse_gdbarch" with method call.
3800
3801 2019-04-04  Tom Tromey  <tom@tromey.com>
3802
3803         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3804         * stap-probe.c (stap_parse_argument): Update.
3805         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3806         initial_size parameter.
3807         * rust-exp.y (rust_lex_tests): Update.
3808         * parse.c (parser_state): Update.
3809         (parse_exp_in_context): Update.
3810         * parser-defs.h (struct parser_state) <parser_state>: Remove
3811         "initial_size" parameter.
3812
3813 2019-04-04  Tom Tromey  <tom@tromey.com>
3814
3815         * parser-defs.h (increase_expout_size): Don't declare.
3816         * parse.c (increase_expout_size): Now static.
3817
3818 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3819
3820         * gnu-nat.c (gnu_nat_target::wait): Fix
3821         target_waitstatus_to_string call.
3822
3823 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * eval.c (evaluate_subexp_standard): Handle internal functions
3826         during Fortran function call handling.
3827
3828 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3829
3830         * NEWS: Mention new internal functions.
3831         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3832         (read_base_type): Use dwarf2_init_complex_target_type.
3833         * value.c (creal_internal_fn): New function.
3834         (cimag_internal_fn): New function.
3835         (_initialize_values): Register new internal functions.
3836
3837 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3838
3839         * infrun.c (stop_all_threads): If debug_infrun, always
3840         trace the wait status after wait_one, using
3841         target_waitstatus_to_string and target_pid_to_str.
3842         (handle_inferior_event): Replace various trace of
3843         wait status kind by a single trace.
3844         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3845         wait status kind image by target_waitstatus_to_string.
3846         * target/waitstatus.c (target_waitstatus_to_string): Fix
3847         obsolete comment.
3848
3849 2019-04-01  Tom Tromey  <tromey@adacore.com>
3850
3851         PR symtab/23331:
3852         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3853
3854 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3855             Pedro Alves  <palves@redhat.com>
3856
3857         * top.c (quit_force): Call 'finalize_values'.
3858         * value.c (finalize_values): New function.
3859         * value.h (finalize_values): Declare.
3860
3861 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3862
3863         * NEWS: Announce $_gdb_major and $_gdb_minor.
3864
3865         * top.c (init_gdb_version_vars): New function.
3866         (gdb_init): Call init_gdb_version_vars.
3867
3868 2019-03-29  Tom Tromey  <tromey@adacore.com>
3869
3870         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3871         help text.  Remove dead code.
3872
3873 2019-03-29  Keith Seitz  <keiths@redhat.com>
3874
3875         From Siddhesh Poyarekar:
3876         * f-lang.h (f77_get_upperbound): Return LONGEST.
3877         (f77_get_lowerbound): Likewise.
3878         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3879         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3880         print them.
3881         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3882         plongest to format print it.
3883         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3884         (f77_get_upperbound): Likewise.
3885         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3886         LOWER_BOUND to LONGEST.
3887         (f77_create_arrayprint_offset_tbl): Likewise.
3888
3889 2019-03-29  Keith Seitz  <keiths@redhat.com>
3890
3891         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3892         %s/pulongest for TYPE_LENGTH instead of %d in format
3893         strings.
3894         * ada-typerint.c (ada_print_type): Likewise.
3895         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3896         * compile/compile-c-support.c (generate_register_struct): Likewise.
3897         * gdbtypes.c (recursive_dump_type): Likewise.
3898         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3899         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3900         instead of %d in format strings.
3901         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3902         to std::min to ULONGEST.
3903         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3904         instead of %d in format strings.
3905         * tracepoint.c (info_scope_command): Likewise.
3906         * typeprint.c (print_offset_data::update)
3907         (print_offset_data::finish): Likewise.
3908         * xtensa-tdep.c (xtensa_store_return_value)
3909         (xtensa_push_dummy_call): Likewise.
3910
3911 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3912
3913         * windows-nat.c (display_selector): Fixed format specifications
3914         for 64-bit Cygwin.
3915
3916 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3917
3918         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3919
3920 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3921
3922         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3923         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3924         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3925         (nios2_linux_init_abi): Install it.
3926
3927 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3928
3929         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3930
3931 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3932
3933         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3934
3935 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3936             Tom Tromey  <tromey@adacore.com>
3937
3938         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3939
3940 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3941
3942         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3943         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3944         method to compute the bounds of range types. Also print "[evaluated]"
3945         if the bounds' values come from a dynamic evaluation.
3946
3947 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3950         whitespace when pretty printing is on.
3951
3952 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3953
3954         * ppc-linux-nat.c: Add include.
3955
3956 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3957
3958         * NEWS: Mention AArch64 Pointer Authentication.
3959
3960 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3961
3962         * arm-linux-nat.c: Add include.
3963
3964 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3965
3966         * source-cache.c (source_cache::get_source_lines): Re-read
3967         fullname after calling open_source_file.
3968
3969 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3970
3971         * NEWS: Mention TLS support for FreeBSD.
3972
3973 2019-03-25  Tom Tromey  <tromey@adacore.com>
3974
3975         * minsyms.c (BUNCH_SIZE): Update comment.
3976         (~minimal_symbol_reader): Remove old comment.
3977         (compact_minimal_symbols): Update comment.
3978         (minimal_symbol_reader::install): Remove old comment.  Update
3979         other comments.
3980
3981 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3982
3983         * s390-linux-nat.c: Add include.
3984
3985 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3986
3987         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3988         Call linux_get_hwcap.
3989         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3990         Likewise.
3991         (aarch64_linux_get_hwcap): Remove function.
3992         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3993         declaration.
3994         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3995         linux_get_hwcap.
3996         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3997         * linux-tdep.c (linux_get_hwcap): Add function.
3998         (linux_get_hwcap2): Likewise.
3999         * linux-tdep.h (linux_get_hwcap): Add declaration.
4000         (linux_get_hwcap2): Likewise.
4001         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4002         (ppc_linux_get_hwcap2): Likewise.
4003         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4004         linux_get_hwcap.
4005         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4006         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4007         (ppc_linux_nat_target::read_description): Likewise.
4008         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4009         * s390-linux-nat.c: Likewise.
4010         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4011
4012 2019-03-24  Tom Tromey  <tom@tromey.com>
4013
4014         * ada-lang.c (standard_lookup): Simplify initialization.
4015         (ada_lookup_symbol_nonlocal): Simplify return.
4016         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4017         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4018         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4019         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4020         initialization.
4021         * solib.c (solib_global_lookup): Simplify.
4022         * symtab.c (null_block_symbol): Remove.
4023         (symbol_cache_lookup): Simplify returns.
4024         (lookup_language_this): Simplify returns.
4025         (lookup_symbol_aux): Simplify return.
4026         (lookup_local_symbol): Simplify returns.
4027         (lookup_global_symbol_from_objfile): Simplify return.
4028         (lookup_symbol_in_objfile_symtabs)
4029         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4030         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4031         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4032         * cp-namespace.c (cp_lookup_bare_symbol)
4033         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4034         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4035         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4036         (cp_lookup_symbol_via_imports): Simplify initialization.
4037         (find_symbol_in_baseclass): Likewise.
4038         * symtab.h (null_block_symbol): Remove.
4039         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4040         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4041         (d_lookup_symbol_module): Likewise.
4042         (find_symbol_in_baseclass): Simplify initialization.
4043
4044 2019-03-24  Tom Tromey  <tom@tromey.com>
4045
4046         * expression.h: Don't include symtab.h.
4047         (struct block): Forward declare.
4048
4049 2019-03-24  Tom Tromey  <tom@tromey.com>
4050
4051         * c-exp.y (typebase): Remove casts.
4052         * gdbtypes.c (lookup_unsigned_typename, )
4053         (lookup_signed_typename): Remove cast.
4054         * eval.c (parse_to_comma_and_eval): Remove cast.
4055         * parse.c (write_dollar_variable): Remove cast.
4056         * block.h (struct block) <superblock>: Now const.
4057         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4058         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4059         (map_block): Make "block" const.
4060         * symfile.h (struct quick_symbol_functions)
4061         <map_matching_symbols>: Constify block argument to "callback".
4062         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4063         const.
4064         (find_pc_sect_compunit_symtab): Make "b" const.
4065         (find_symbol_at_address): Likewise.
4066         (search_symbols): Likewise.
4067         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4068         (dw2_debug_names_lookup_symbol): Likewise.
4069         (dw2_map_matching_symbols): Update.
4070         * p-valprint.c (pascal_val_print): Remove "block".
4071         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4072         (aux_add_nonlocal_symbols): Make "block" const.
4073         (resolve_subexp): Remove cast.
4074         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4075         const.
4076         (iterate_over_file_blocks): Likewise.
4077         * f-exp.y (%union) <bval>: Remove.
4078         * coffread.c (patch_opaque_types): Make "b" const.
4079         * spu-tdep.c (spu_catch_start): Make "block" const.
4080         * c-valprint.c (print_unpacked_pointer): Remove "block".
4081         * symmisc.c (dump_symtab_1): Make "b" const.
4082         (block_depth): Make "block" const.
4083         * d-exp.y (%union) <bval>: Remove.
4084         * cp-support.h (cp_lookup_rtti_type): Update.
4085         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4086         * psymtab.c (psym_lookup_symbol): Make "block" const.
4087         (maintenance_check_psymtabs): Make "b" const.
4088         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4089         (enumerate_locals, enumerate_args): Update.
4090         * python/py-symtab.c (stpy_global_block): Make "block" const.
4091         (stpy_static_block): Likewise.
4092         * inline-frame.c (block_starting_point_at): Make "new_block"
4093         const.
4094         * block.c (find_block_in_blockvector): Make return type const.
4095         (blockvector_for_pc_sect): Make "b" const.
4096         (find_block_in_blockvector): Make "b" const.
4097
4098 2019-03-23  Tom Tromey  <tom@tromey.com>
4099
4100         * varobj.c (varobj_create): Update.
4101         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4102         * printcmd.c (display_command, do_one_display): Don't reset
4103         innermost_block.
4104         * parser-defs.h (enum innermost_block_tracker_type): Move to
4105         expression.h.
4106         (innermost_block): Update comment.
4107         * parse.c (parse_exp_1): Add tracker_types parameter.
4108         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4109         tracker_types parameter.  Reset innermost_block.
4110         (parse_exp_in_context): Remove.
4111         (parse_expression_for_completion): Update.
4112         * objfiles.c (~objfile): Don't reset expression_context_block or
4113         innermost_block.
4114         * expression.h (enum innermost_block_tracker_type): Move from
4115         parser-defs.h.
4116         (parse_exp_1): Add tracker_types parameter.
4117         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4118         reset innermost_block.
4119
4120 2019-03-23  Tom Tromey  <tom@tromey.com>
4121
4122         * objfiles.h: Include bcache.h.
4123
4124 2019-03-23  Tom Tromey  <tom@tromey.com>
4125
4126         * linespec.c (get_current_search_block): Use
4127         scoped_restore_current_language.
4128         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4129
4130 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4131             Jiong Wang  <jiong.wang@arm.com>
4132
4133         * aarch64-linux-tdep.c
4134         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4135         section.
4136         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4137
4138 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4139             Jiong Wang  <jiong.wang@arm.com>
4140
4141         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4142         instructions.
4143         (aarch64_analyze_prologue_test): Add PACIASP test.
4144         (aarch64_prologue_prev_register): Unmask PC value.
4145
4146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4147             Jiong Wang  <jiong.wang@arm.com>
4148
4149         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4150         (aarch64_dwarf2_prev_register): Unmask PC value.
4151         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4152         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4153         DW_CFA_AARCH64_negate_ra_state.
4154         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4155
4156 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4157             Jiong Wang  <jiong.wang@arm.com>
4158
4159         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4160         registers.
4161         (aarch64_pseudo_register_name): Likewise.
4162         (aarch64_pseudo_register_type): Likewise.
4163         (aarch64_pseudo_register_reggroup_p): Likewise.
4164         (aarch64_gdbarch_init): Add pauth registers.
4165         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4166         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4167         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4168         (struct gdbarch_tdep): Add regnum for ra_state.
4169
4170 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4171             Jiong Wang  <jiong.wang@arm.com>
4172
4173         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4174
4175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4176             Jiong Wang  <jiong.wang@arm.com>
4177
4178         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4179         function.
4180         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4181         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4182         (aarch64_gdbarch_init): Add puth registers.
4183         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4184         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4185         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4186
4187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4188             Jiong Wang  <jiong.wang@arm.com>
4189
4190         * aarch64-linux-nat.c
4191         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4192         * aarch64-linux-tdep.c
4193         (aarch64_linux_core_read_description): Likewise.
4194         (aarch64_linux_get_hwcap): New function.
4195         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4196         (aarch64_linux_get_hwcap): New declaration.
4197
4198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4199             Jiong Wang  <jiong.wang@arm.com>
4200
4201         * aarch64-linux-nat.c
4202         (aarch64_linux_nat_target::read_description): Add pauth param.
4203         * aarch64-linux-tdep.c
4204         (aarch64_linux_core_read_description): Likewise.
4205         * aarch64-tdep.c (struct target_desc): Add in pauth.
4206         (aarch64_read_description): Add pauth param.
4207         (aarch64_gdbarch_init): Likewise.
4208         * aarch64-tdep.h (aarch64_read_description): Likewise.
4209         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4210         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4211         * features/Makefile: Add new files.
4212         * features/aarch64-pauth.c: New file.
4213         * features/aarch64-pauth.xml: New file.
4214
4215 2019-03-20  Tom Tromey  <tromey@adacore.com>
4216
4217         * infrun.c (handle_inferior_event): Rename from
4218         handle_inferior_event_1.  Create a scoped_value_mark.
4219         (handle_inferior_event): Remove.
4220
4221 2019-03-19  Tom Tromey  <tromey@adacore.com>
4222
4223         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4224         * infrun.h (print_stop_event): Add "displays" parameter.
4225         * infrun.c (print_stop_event): Add "displays" parameter.
4226
4227 2019-03-19  Pedro Alves  <palves@redhat.com>
4228
4229         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4230         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4231         to -1.  Fix TABs vs spaces.
4232         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4233         * tui/tui-out.h (tui_ui_out) Add intro comments.
4234         <m_line, m_start_of_line>: In-class initialize, and add describing
4235         comment.
4236
4237 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4238
4239         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4240         variable names.
4241         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4242
4243 2019-03-18  Pedro Alves  <palves@redhat.com>
4244             Eli Zaretskii <eliz@gnu.org>
4245
4246         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4247         m_line and m_start_of_line.
4248
4249 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4250
4251         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4252         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4253         it returns a newline.  This fixes a regression in TU mode, whereby
4254         the next line is output on the same screen line as the user input.
4255
4256 2019-03-18  Tom Tromey  <tromey@adacore.com>
4257
4258         * minsyms.c (minimal_symbol_reader::install): Remove call to
4259         obstack_blank.
4260
4261 2019-03-18  Pedro Alves  <palves@redhat.com>
4262
4263         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4264         New globals.
4265         (apply_style): New, factored out from ...
4266         (apply_ansi_escape): ... this.  Handle reverse video mode.
4267         (tui_set_reverse_mode): New function.
4268         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4269         * tui/tui-winsource.c (tui_show_source_line): Use
4270         tui_set_reverse_mode instead of setting A_STANDOUT.
4271         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4272         New setter methods.
4273
4274 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4275
4276         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4277         Handle tabs.
4278
4279 2019-03-18  Tom Tromey  <tromey@adacore.com>
4280
4281         * ada-lang.c (empty_array): Add "high" parameter.
4282         (ada_evaluate_subexp): Update.
4283
4284 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4285
4286         * unittests/string_view-selftests.c: Define
4287         _initialize_string_view_selftests unconditionally.
4288
4289 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4290
4291         PR gdb/24350
4292         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4293
4294 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4295
4296         PR gdb/24351
4297         * windows-nat.c (display_selector): Fix format specifiers.
4298
4299 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4300
4301         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4302         tui_refill_source_window instead of tui_refresh_win, to update the
4303         current execution line.  This fixes redisplay of the current line
4304         when stepping through the code with "next" or "step".
4305
4306 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4307
4308         * source-cache.c (source_cache::get_source_lines): Call
4309         find_source_lines to initialize s->nlines.  This fixes vertical
4310         scrolling of TUI source window when the DOWN arrow is pressed.
4311
4312 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4313
4314         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4315         linux-thread-db.c (_initialize_thread_db): Likewise.
4316
4317 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4318
4319         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4320         wclrtoeol in tui_show_source_line".  This reverts changes made in
4321         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4322
4323 2019-03-15  Tom Tromey  <tom@tromey.com>
4324
4325         * symtab.h (struct minimal_symbol): Derive from
4326         general_symbol_info.
4327         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4328         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4329         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4330         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4331         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4332         (MSYMBOL_SEARCH_NAME): Update.
4333         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4334         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4335         * minsyms.c (minimal_symbol_reader::record_full): Update.
4336
4337 2019-03-15  Tom Tromey  <tom@tromey.com>
4338
4339         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4340
4341 2019-03-15  Tom Tromey  <tom@tromey.com>
4342
4343         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4344         unique_xmalloc_ptr.
4345         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4346         Update.
4347         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4348         (build_minimal_symbol_hash_tables)
4349         (minimal_symbol_reader::install): Update.
4350
4351 2019-03-15  Tom Tromey  <tom@tromey.com>
4352
4353         * symtab.c (create_demangled_names_hash): Update.
4354         (symbol_set_names): Update.
4355         * objfiles.h (struct objfile_per_bfd_storage)
4356         <demangled_names_hash>: Now an htab_up.
4357         * objfiles.c (objfile_per_bfd_storage): Simplify.
4358
4359 2019-03-15  Tom Tromey  <tom@tromey.com>
4360
4361         * objfiles.h (struct objfile_per_bfd_storage): Declare
4362         destructor.
4363         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4364         New.
4365         (get_objfile_bfd_data): Use new.  Don't initialize
4366         language_of_main.
4367         (free_objfile_per_bfd_storage): Remove.
4368         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4369
4370 2019-03-15  Tom Tromey  <tom@tromey.com>
4371
4372         * symfile.c (reread_symbols): Update.
4373         * objfiles.c (objfile::objfile): Update.
4374         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4375         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4376         comment.
4377         (minimal_symbol_reader::install): Update.
4378         (terminate_minimal_symbol_table): Remove.
4379         * jit.c (jit_object_close_impl): Update.
4380
4381 2019-03-15  Tom Tromey  <tom@tromey.com>
4382
4383         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4384         initializations.
4385
4386 2019-03-15  Tom Tromey  <tom@tromey.com>
4387
4388         * objfiles.h (struct objfile_per_bfd_storage)
4389         <demangled_hash_languages>: Now a bitset.
4390         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4391         (lookup_minimal_symbol): Update.
4392
4393 2019-03-15  Tom Tromey  <tom@tromey.com>
4394
4395         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4396         Don't return the symbol.
4397         * coffread.c (record_minimal_symbol): Use record_full.
4398
4399 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4400
4401         The MS-Windows port of ncurses fails to switch to a color pair if
4402         one or both of the colors are the implicit default colors.  This
4403         change records the default colors when TUI is initialized, and
4404         then specifies them explicitly when a color pair uses the default
4405         colors.  This allows color styling in TUI mode on MS-Windows.
4406
4407         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4408         ncurses_norm_attr.
4409         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4410         colors in ncurses_norm_attr.
4411         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4412         "none", replace it with the default color recorded in
4413         ncurses_norm_attr.
4414
4415 2019-03-14  Tom Tromey  <tromey@adacore.com>
4416
4417         * source-cache.h (class source_cache) <get_source_lines>: Return
4418         std::string.
4419         * source-cache.c (source_cache::extract_lines): Handle case where
4420         first_pos==npos.  Return std::string.
4421         (source_cache::get_source_lines): Update.
4422
4423 2019-03-14  Tom Tromey  <tromey@adacore.com>
4424
4425         * NEWS: Add item for "style sources" commands.
4426         * source-cache.c (source_cache::get_source_lines): Check
4427         source_styling.
4428         * cli/cli-style.c (source_styling): New global.
4429         (_initialize_cli_style): Add "style sources" commands.
4430         (show_style_sources): New function.
4431         * cli/cli-style.h (source_styling): Declare.
4432
4433 2019-03-14  Pedro Alves  <palves@redhat.com>
4434             Tom Tromey  <tromey@adacore.com>
4435
4436         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4437         * tui/tui-winsource.c (tui_refill_source_window): New function,
4438         from...
4439         (tui_horizontal_source_scroll): ... here.  Move some logic.
4440         * cli/cli-style.c (set_style_enabled): Notify new observable.
4441         * tui/tui-hooks.c (tui_redisplay_source): New function.
4442         (tui_attach_detach_observers): Attach or detach
4443         tui_redisplay_source.
4444         * observable.h (source_styling_changed): New observable.
4445         * observable.c: Define source_styling_changed observable.
4446
4447 2019-03-13  Tom Tromey  <tromey@adacore.com>
4448
4449         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4450         (i386_gnu_nat_target::store_registers): Update.
4451         * target-debug.h (target_debug_print_std_string): New macro.
4452         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4453         * windows-tdep.c (display_one_tib): Update.
4454         * tui/tui-stack.c (tui_make_status_line): Update.
4455         * top.c (print_inferior_quit_action): Update.
4456         * thread.c (thr_try_catch_cmd): Update.
4457         (add_thread_with_info): Update.
4458         (thread_target_id_str): Update.
4459         (thr_try_catch_cmd): Update.
4460         (thread_command): Update.
4461         (thread_find_command): Update.
4462         * record-btrace.c (record_btrace_target::info_record)
4463         (record_btrace_resume_thread, record_btrace_target::resume)
4464         (record_btrace_cancel_resume, record_btrace_step_thread)
4465         (record_btrace_target::wait, record_btrace_target::wait)
4466         (record_btrace_target::wait, record_btrace_target::stop): Update.
4467         * progspace.c (print_program_space): Update.
4468         * process-stratum-target.c
4469         (process_stratum_target::thread_address_space): Update.
4470         * linux-fork.c (linux_fork_mourn_inferior)
4471         (detach_checkpoint_command, info_checkpoints_command)
4472         (linux_fork_context): Update.
4473         (linux_fork_detach): Update.
4474         (class scoped_switch_fork_info): Update.
4475         (delete_checkpoint_command): Update.
4476         * infrun.c (follow_fork_inferior): Update.
4477         (follow_fork_inferior): Update.
4478         (proceed_after_vfork_done): Update.
4479         (handle_vfork_child_exec_or_exit): Update.
4480         (follow_exec): Update.
4481         (displaced_step_prepare_throw): Update.
4482         (displaced_step_restore): Update.
4483         (start_step_over): Update.
4484         (resume_1): Update.
4485         (clear_proceed_status_thread): Update.
4486         (proceed): Update.
4487         (print_target_wait_results): Update.
4488         (do_target_wait): Update.
4489         (context_switch): Update.
4490         (stop_all_threads): Update.
4491         (restart_threads): Update.
4492         (finish_step_over): Update.
4493         (handle_signal_stop): Update.
4494         (switch_back_to_stepped_thread): Update.
4495         (keep_going_pass_signal): Update.
4496         (print_exited_reason): Update.
4497         (normal_stop): Update.
4498         * inferior.c (inferior_pid_to_str): Change return type.
4499         (print_selected_inferior): Update.
4500         (add_inferior): Update.
4501         (detach_inferior): Update.
4502         * dummy-frame.c (fprint_dummy_frames): Update.
4503         * dcache.c (dcache_info_1): Update.
4504         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4505         (btrace_fetch, btrace_clear): Update.
4506         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4507         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4508         type.
4509         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4510         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4511         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4512         * gdbarch.c, gdbarch.h: Rebuild.
4513         * gdbarch.sh (core_pid_to_str): Change return type.
4514         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4515         return type.
4516         (windows_nat_target::pid_to_str): Change return type.
4517         (windows_delete_thread): Update.
4518         (windows_nat_target::attach): Update.
4519         (windows_nat_target::files_info): Update.
4520         * target-delegates.c: Rebuild.
4521         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4522         return type.
4523         (sol_thread_target::pid_to_str): Change return type.
4524         * remote.c (class remote_target) <pid_to_str>: Change return
4525         type.
4526         (remote_target::pid_to_str): Change return type.
4527         (extended_remote_target::attach, remote_target::remote_stop_ns)
4528         (remote_target::remote_notif_remove_queued_reply)
4529         (remote_target::push_stop_reply, remote_target::disable_btrace):
4530         Update.
4531         (extended_remote_target::attach): Update.
4532         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4533         type.
4534         (gdbsim_target::pid_to_str): Change return type.
4535         * ravenscar-thread.c (struct ravenscar_thread_target)
4536         <pid_to_str>: Change return type.
4537         (ravenscar_thread_target::pid_to_str): Change return type.
4538         * procfs.c (class procfs_target) <pid_to_str>: Change return
4539         type.
4540         (procfs_target::pid_to_str): Change return type.
4541         (procfs_target::attach): Update.
4542         (procfs_target::detach): Update.
4543         (procfs_target::fetch_registers): Update.
4544         (procfs_target::store_registers): Update.
4545         (procfs_target::wait): Update.
4546         (procfs_target::files_info): Update.
4547         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4548         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4549         return type.
4550         (nto_procfs_target::pid_to_str): Change return type.
4551         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4552         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4553         return type.
4554         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4555         (exit_lwp): Update.
4556         (attach_proc_task_lwp_callback, get_detach_signal)
4557         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4558         (linux_nat_target::resume, wait_lwp, stop_callback)
4559         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4560         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4561         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4562         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4563         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4564         type.
4565         (inf_ptrace_target::attach): Update.
4566         (inf_ptrace_target::files_info): Update.
4567         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4568         type.
4569         (go32_nat_target::pid_to_str): Change return type.
4570         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4571         (gnu_nat_target::wait): Update.
4572         (gnu_nat_target::wait): Update.
4573         (gnu_nat_target::resume): Update.
4574         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4575         (fbsd_nat_target::wait): Update.
4576         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4577         type.
4578         (darwin_nat_target::attach): Update.
4579         * corelow.c (class core_target) <pid_to_str>: Change return type.
4580         (core_target::pid_to_str): Change return type.
4581         * target.c (normal_pid_to_str): Change return type.
4582         (default_pid_to_str): Likewise.
4583         (target_pid_to_str): Change return type.
4584         (target_translate_tls_address): Update.
4585         (target_announce_detach): Update.
4586         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4587         return type.
4588         (bsd_uthread_target::pid_to_str): Change return type.
4589         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4590         type.
4591         (bsd_kvm_target::pid_to_str): Change return type.
4592         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4593         return type.
4594         (aix_thread_target::pid_to_str): Change return type.
4595         * target.h (struct target_ops) <pid_to_str>: Change return type.
4596         (target_pid_to_str, normal_pid_to_str): Likewise.
4597         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4598         type.
4599         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4600         type.
4601         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4602         return type.
4603         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4604         type.
4605         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4606         type.
4607         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4608         return type.
4609
4610 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4611
4612         * NEWS: Mention that the new default MI version is 3.  Mention
4613         changes to the output of commands and events that deal with
4614         multi-location breakpoints.
4615         * breakpoint.c: Include "mi/mi-out.h".
4616         (print_one_breakpoint): Change output syntax if using MI version
4617         >= 3.
4618         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4619         New.
4620         (mi_multi_location_breakpoint_output_fixed): New.
4621         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4622         (mi_cmd_fix_multi_location_breakpoint_output): New.
4623         (mi_multi_location_breakpoint_output_fixed): New.
4624         * mi/mi-cmds.c (mi_cmds): Register command
4625         -fix-multi-location-breakpoint-output.
4626         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4627         interpreter "mi".
4628
4629 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4630
4631         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4632         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4633         instantiate mi_ui_out based on interpreter name.
4634         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4635         * mi/mi-main.c (mi_load_progress): Likewise.
4636
4637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * NEWS: Combine separate "New targets" sections for 8.3.
4640
4641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4644         (ppcfbsd_init_abi): Install gdbarch
4645         "fetch_tls_load_module_address" and "get_thread_local_address"
4646         methods.
4647
4648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4649
4650         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4651         (riscv_fbsd_init_abi): Install gdbarch
4652         "fetch_tls_load_module_address" and "get_thread_local_address"
4653         methods.
4654
4655 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4656
4657         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4658         (i386fbsd_init_abi): Install gdbarch
4659         "fetch_tls_load_module_address" and "get_thread_local_address"
4660         methods.
4661
4662 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4663
4664         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4665         (amd64fbsd_init_abi): Install gdbarch
4666         "fetch_tls_load_module_address" and "get_thread_local_address"
4667         methods.
4668
4669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4670
4671         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4672         (struct fbsd_pspace_data): New type.
4673         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4674         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4675         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4676         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4677         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4678
4679 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4680
4681         * gdbtypes.c (lookup_struct_elt): New function.
4682         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4683         * gdbtypes.h (struct struct_elt): New type.
4684         (lookup_struct_elt): New prototype.
4685
4686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4687
4688         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4689         remove disabled code block.
4690
4691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4692
4693         * gdbarch.sh (get_thread_local_address): New method.
4694         * gdbarch.h, gdbarch.c: Regenerate.
4695         * target.c (target_translate_tls_address): Use
4696         gdbarch_get_thread_local_address if present instead of
4697         target::get_thread_local_address.
4698
4699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4700
4701         * target.h (target::get_thread_local_address): Update comment.
4702
4703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4704
4705         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4706         objfile->separate_debug_objfile_backlink if not NULL.
4707
4708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4709
4710         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4711         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4712         (amd64bsd_store_inferior_registers): Likewise.
4713         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4714         Enable segment base registers.
4715         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4716         PT_GETFSBASE and PT_GETGSBASE.
4717         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4718         PT_SETGSBASE.
4719         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4720         segment base registers.
4721         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4722
4723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4724
4725         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4726         Update calls to i386_target_description to add 'segments'
4727         parameter.
4728         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4729         add segment base registers.
4730         * arch/i386.c (i386_create_target_description): Add 'segments'
4731         parameter to enable segment base registers.
4732         * arch/i386.h (i386_create_target_description): Likewise.
4733         * features/i386/32bit-segments.xml: New file.
4734         * features/i386/32bit-segments.c: Generate.
4735         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4736         call to i386_target_description to add 'segments' parameter.
4737         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4738         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4739         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4740         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4741         if feature is present.
4742         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4743         Add 'segments' parameter to call to i386_target_description.
4744         (i386_target_description): Add 'segments' parameter to enable
4745         segment base registers.
4746         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4747         to call to i386_target_description.
4748         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4749         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4750         Define I386_NUM_REGS.
4751         (i386_target_description): Add 'segments' parameter to enable
4752         segment base registers.
4753
4754 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4755
4756         PR/24325
4757         * source-cache.c: #undef open and close, to avoid unresolved
4758         externals during linking.
4759
4760 2019-03-12  Tom Tromey  <tromey@adacore.com>
4761
4762         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4763         const.  Add initializers.
4764         (_initialize_remote): Don't initialize ptid globals.
4765
4766 2019-03-12  Pedro Alves  <palves@redhat.com>
4767
4768         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4769
4770 2019-03-12  Pedro Alves  <palves@redhat.com>
4771
4772         * cp-name-parser.y (main): Remove unused 'len' variable.
4773
4774 2019-03-12  Tom Tromey  <tromey@adacore.com>
4775
4776         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4777         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4778
4779 2019-03-12  Tom Tromey  <tromey@adacore.com>
4780
4781         * linux-nat.c (iterate_over_lwps): Update.
4782         (stop_callback): Remove parameter.
4783         (stop_wait_callback, detach_callback, resume_set_callback)
4784         (select_singlestep_lwp_callback, set_ignore_sigint)
4785         (status_callback, resumed_callback, resume_clear_callback)
4786         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4787         data parameter.
4788         (linux_nat_target::detach, linux_nat_target::resume)
4789         (linux_stop_and_wait_all_lwps, select_event_lwp)
4790         (linux_nat_filter_event, linux_nat_wait_1)
4791         (linux_nat_target::kill, linux_nat_target::stop)
4792         (linux_nat_target::stop): Update.
4793         (linux_nat_resume_callback): Change type.
4794         (resume_stopped_resumed_lwps, count_events_callback)
4795         (select_event_lwp_callback): Likewise.
4796         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4797         * arm-linux-nat.c (struct update_registers_data): Remove.
4798         (update_registers_callback): Change type.
4799         (arm_linux_insert_hw_breakpoint1): Update.
4800         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4801         parameter.
4802         (x86_linux_dr_set_addr): Update.
4803         (x86_linux_dr_set_control): Update.
4804         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4805         (iterate_over_lwps): Use gdb::function_view.
4806         * nat/aarch64-linux-hw-point.c (struct
4807         aarch64_dr_update_callback_param): Remove.
4808         (debug_reg_change_callback): Change type.
4809         (aarch64_notify_debug_reg_change): Update.
4810         * s390-linux-nat.c (s390_refresh_per_info): Update.
4811
4812 2019-03-11  Tom Tromey  <tromey@adacore.com>
4813
4814         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4815         redundant assignment to "this_cu".
4816
4817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4818
4819         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4820
4821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4822
4823         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4824         from...
4825         (rank_one_type): ... this.
4826
4827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4828
4829         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4830         from...
4831         (rank_one_type): ... this.
4832
4833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4834
4835         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4836         from...
4837         (rank_one_type): ... this.
4838
4839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4840
4841         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4842         from...
4843         (rank_one_type): ... this.
4844
4845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4846
4847         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4848         from...
4849         (rank_one_type): ... this.
4850
4851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4852
4853         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4854         from...
4855         (rank_one_type): ... this.
4856
4857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4858
4859         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4860         from...
4861         (rank_one_type): ... this.
4862
4863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4864
4865         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4866         from...
4867         (rank_one_type): ... this.
4868
4869 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4870
4871         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4872         from...
4873         (rank_one_type): ... this.
4874
4875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4876
4877         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4878         from...
4879         (rank_one_type): ... this.
4880
4881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4882
4883         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4884         from...
4885         (rank_one_type): ... this.
4886
4887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4888
4889         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4890         from...
4891         (rank_one_type): ... this.
4892
4893 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4894
4895         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4896         inferior-events' shows the example events.
4897
4898 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4899
4900         Support styling on native MS-Windows console
4901
4902         PR/24315
4903         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4904         on MS-Windows if $TERM is not defined.
4905
4906         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4907
4908         * posix-hdep.c (gdb_console_fputs):
4909         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4910         functions.
4911         * ui-file.h (gdb_console_fputs): Add prototype.
4912
4913         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4914         back to fputs only if the former returns zero.
4915
4916 2019-03-07  Tom Tromey  <tom@tromey.com>
4917
4918         * symmisc.c (print_symbol_bcache_statistics): Update.
4919         (print_objfile_statistics): Update.
4920         * symfile.c (allocate_symtab): Update.
4921         * stabsread.c: Don't include bcache.h.
4922         * psymtab.h (struct psymbol_bcache): Don't declare.
4923         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4924         (psymbol_bcache_init, psymbol_bcache_free)
4925         (psymbol_bcache_get_bcache): Don't declare.
4926         * psymtab.c (struct psymbol_bcache): Remove.
4927         (psymtab_storage::psymtab_storage): Update.
4928         (psymtab_storage::~psymtab_storage): Update.
4929         (psymbol_bcache_init, psymbol_bcache_free)
4930         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4931         (add_psymbol_to_bcache): Update.
4932         (allocate_psymtab): Update.
4933         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4934         macro_cache>: No longer pointers.
4935         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4936         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4937         * macrotab.c (macro_bcache): Update.
4938         * macroexp.c: Don't include bcache.h.
4939         * gdbtypes.c (check_types_worklist): Update.
4940         (types_deeply_equal): Remove TRY/CATCH.  Update.
4941         * elfread.c (elf_symtab_read): Update.
4942         * dwarf2read.c: Don't include bcache.h.
4943         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4944         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4945         (print_bcache_statistics, bcache_memory_used): Don't declare.
4946         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4947         methods.  Rename all data members.
4948         * bcache.c (struct bcache): Move to bcache.h.
4949         (bcache::expand_hash_table): Rename from expand_hash_table.
4950         (bcache): Remove.
4951         (bcache::insert): Rename from bcache_full.
4952         (bcache::compare): Rename from bcache_compare.
4953         (bcache_xmalloc): Remove.
4954         (bcache::~bcache): Rename from bcache_xfree.
4955         (bcache::print_statistics): Rename from print_bcache_statistics.
4956         (bcache::memory_used): Rename from bcache_memory_used.
4957
4958 2019-03-07  Pedro Alves  <palves@redhat.com>
4959
4960         * infrun.c (normal_stop): Also check for
4961         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4962
4963 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * f-lang.c (value_from_host_double): Moved to...
4966         * value.c (value_from_host_double): ...here.
4967         * value.h (value_from_host_double): Declare.
4968         * guile/scm-math.c (vlscm_convert_typed_number): Use
4969         value_from_host_double.
4970         (vlscm_convert_number): Likewise.
4971         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4972         * python/py-value.c (convert_value_from_python): Likewise.
4973
4974 2019-03-06  Tom Tromey  <tom@tromey.com>
4975
4976         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4977
4978 2019-03-06  Tom Tromey  <tom@tromey.com>
4979
4980         * utils.h (free_current_contents): Don't declare.
4981         * utils.c (free_current_contents): Remove.
4982
4983 2019-03-06  Tom Tromey  <tom@tromey.com>
4984
4985         * top.c (quit_force): Update.
4986         * main.c (captured_command_loop): Update.
4987         * common/new-op.c (operator new): Update.
4988         * common/common-exceptions.c (struct catcher)
4989         <save_cleanup_chain>: Remove member.
4990         (exceptions_state_mc_init): Update.
4991         (exception_try_scope_entry): Return nullptr.
4992         (exception_try_scope_exit, exception_rethrow)
4993         (throw_exception_sjlj, throw_exception_cxx): Update.
4994         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4995         (all_cleanups, do_cleanups, discard_cleanups)
4996         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4997         (restore_cleanups, restore_final_cleanups): Don't declare.
4998         (do_final_cleanups): Remove parameter.
4999         * common/cleanups.c (cleanup_chain, make_cleanup)
5000         (make_cleanup_dtor, all_cleanups, do_cleanups)
5001         (discard_my_cleanups, discard_cleanups)
5002         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5003         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5004         (null_cleanup): Remove.
5005         (do_final_cleanups): Remove parameter.
5006
5007 2019-03-06  Tom Tromey  <tom@tromey.com>
5008
5009         * remote.c (remote_target::remote_parse_stop_reply): Use
5010         unique_xmalloc_ptr.
5011
5012 2019-03-06  Tom Tromey  <tom@tromey.com>
5013
5014         * stabsread.c (struct stabs_field_info): Rename from field_info.
5015         <list, fnlist>: Add initializers.
5016         <obstack>: New member.
5017         (read_member_functions, read_struct_fields, read_baseclasses):
5018         Allocate on obstack.  Don't use cleanups.
5019         (read_one_struct_field, read_member_functions, read_struct_fields)
5020         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5021         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5022         (read_struct_type): Update.
5023
5024 2019-03-06  Tom Tromey  <tom@tromey.com>
5025
5026         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5027         * common/filestuff.h (make_cleanup_close): Don't declare.
5028         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5029         Remove.
5030
5031 2019-03-06  Tom Tromey  <tom@tromey.com>
5032
5033         * solib-aix.c: Use make_scope_exit.
5034
5035 2019-03-06  Tom Tromey  <tom@tromey.com>
5036
5037         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5038         Use make_scope_exit.
5039
5040 2019-03-06  Tom Tromey  <tom@tromey.com>
5041
5042         * solib-svr4.c (disable_probes_interface): Remove parameter.
5043         (svr4_handle_solib_event): Use make_scope_exit.
5044
5045 2019-03-06  Tom Tromey  <tom@tromey.com>
5046
5047         * remote.c (struct stop_reply_deleter): Remove.
5048         (stop_reply_up): Update.
5049         (struct stop_reply): Derive from notif_event.  Don't typedef.
5050         <regcache>: Now a std::vector.
5051         (stop_reply_xfree): Remove.
5052         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5053         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5054         (remote_target::discard_pending_stop_replies): Use delete.
5055         (remote_target::remote_parse_stop_reply): Update.
5056         (remote_target::process_stop_reply): Update.
5057         * remote-notif.h (struct notif_event): Add virtual destructor.
5058         Remove "dtr" member.
5059         (struct notif_client) <alloc_event>: Return a unique_ptr.
5060         (notif_event_xfree): Don't declare.
5061         (notif_event_up): New typedef.
5062         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5063         (notif_event_xfree, do_notif_event_xfree): Remove.
5064         (remote_notif_state_xfree): Update.
5065
5066 2019-03-06  Tom Tromey  <tom@tromey.com>
5067
5068         * infrun.c (displaced_step_clear_cleanup): Now a
5069         forward_scope_exit type.
5070         (displaced_step_prepare_throw): Update.
5071         (displaced_step_fixup): Update.
5072
5073 2019-03-06  Tom Tromey  <tom@tromey.com>
5074
5075         * inferior.h (class inferior): Update comment.
5076         * gdbthread.h (class thread_info): Update comment.
5077
5078 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5079             Tom Tromey  <tom@tromey.com>
5080
5081         * stabsread.h (struct stab_section_list): Remove.
5082         (coffstab_build_psymtabs): Update.
5083         * dbxread.c (symbuf_sections): Now a std::vector.
5084         (sect_idx): New global.
5085         (fill_symbuf): Update.
5086         (coffstab_build_psymtabs): Change type of stabsects parameter.
5087         Update.
5088         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5089         std::vector.
5090         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5091         (coff_locate_sections): Update.
5092         (coff_symfile_read): Remove cleanups.  Update.
5093         (init_stringtab): Add storage parameter.
5094         (free_stringtab, free_stringtab_cleanup): Remove.
5095         (init_lineno): Add storage parameter.
5096         (free_linetab, free_linetab_cleanup): Remove.
5097
5098 2019-03-06  Pedro Alves  <palves@redhat.com>
5099
5100         * linux-fork.c (fork_info::clobber_regs): Delete.
5101         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5102         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5103         comment.  Adjust.
5104         (scoped_switch_fork_info::scoped_switch_fork_info)
5105         (checkpoint_command, linux_fork_context): Adjust
5106         fork_save_infrun_state calls.
5107
5108 2019-03-06  Pedro Alves  <palves@redhat.com>
5109
5110         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5111         (inf_has_multiple_threads): Return 'bool' and rewrite using
5112         inferior_info::threads().
5113
5114 2019-03-06  Pedro Alves  <palves@redhat.com>
5115
5116         * linux-fork.c: Include <list>.
5117         (fork_list): Now a std::list instance.
5118         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5119         (forks_exist_p, find_last_fork): Adjust.
5120         (new_fork): Delete.
5121         (one_fork_p): New.
5122         (add_fork): Adjust.
5123         (free_fork): Delete, folded into fork_info::~fork_info().
5124         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5125         Adjust.
5126         (init_fork_list): Delete.
5127         (linux_fork_killall, linux_fork_mourn_inferior)
5128         (linux_fork_detach, info_checkpoints_command): Adjust.
5129         (_initialize_linux_fork): No longer call init_fork_list.
5130
5131 2019-03-06  Pedro Alves  <palves@redhat.com>
5132
5133         * linux-fork.c (new_fork): New, split out of ...
5134         (add_fork): ... this.  Return void.  Move "first fork" special
5135         case from here, to ...
5136         (checkpoint_command): ... here.
5137         * linux-linux.h (add_fork): Return void.
5138
5139 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5140
5141         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5142
5143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5144             Chris January  <chris.january@arm.com>
5145             David Lecomber  <david.lecomber@arm.com>
5146
5147         * f-exp.y: New token, UNOP_INTRINSIC.
5148         (exp): New pattern using UNOP_INTRINSIC token.
5149         (f77_keywords): Add 'abs' keyword.
5150         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5151         (value_from_host_double): New function.
5152         (evaluate_subexp_f): Support UNOP_ABS.
5153
5154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5155
5156         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5157         types.
5158
5159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5162         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5163         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5164
5165 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5168
5169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5170             Chris January  <chris.january@arm.com>
5171
5172         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5173         * f-exp.y: Define 'KIND' token.
5174         (exp): New pattern for KIND expressions.
5175         (ptype): Handle types with a kind extension.
5176         (direct_abs_decl): Extend to spot kind extensions.
5177         (f77_keywords): Add 'kind' to the list.
5178         (push_kind_type): New function.
5179         (convert_to_kind_type): New function.
5180         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5181         * parse.c (operator_length_standard): Likewise.
5182         * parser-defs.h (enum type_pieces): Add tp_kind.
5183         * std-operator.def: Add UNOP_KIND.
5184
5185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5186
5187         * f-exp.y (f_parse): Set yydebug.
5188
5189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * f-lang.c (evaluate_subexp_f): New function.
5192         (exp_descriptor_f): New global.
5193         (f_language_defn): Use exp_descriptor_f instead of
5194         exp_descriptor_standard.
5195
5196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * f-exp.y (struct token): Add comments.
5199         (dot_ops): Remove uppercase versions and the end marker.
5200         (f77_keywords): Likewise.
5201         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5202         entries in the dot_ops array are case insensitive, and use
5203         strncasecmp to compare strings.  Also some whitespace cleanup in
5204         this area.  Similar for the f77_keywords array, except entries in
5205         this list might be case sensitive.
5206
5207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5208
5209         * f-exp.y (struct f77_boolean_val): Add comments.
5210         (boolean_values): Remove uppercase versions, and end marker.
5211         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5212         and use strncasecmp to achieve case insensitivity.  Additionally,
5213         perform whitespace cleanup around this code.
5214
5215 2019-03-06  Tom Tromey  <tromey@adacore.com>
5216
5217         * remote-sim.c (gdbsim_target_open): Use result of
5218         gdb_argv::release.
5219
5220 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5221         Dirk Schubert  <dirk.schubert@arm.com>
5222         Chris January  <chris.january@arm.com>
5223
5224         * eval.c (evaluate_subexp_standard): Call Fortran argument
5225         wrapping logic.
5226         * f-lang.c (struct value): A value which can be passed into a
5227         Fortran function call.
5228         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5229         where appropriate.
5230         (struct type): Value ready for a Fortran function call.
5231         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5232         is needed.
5233         * f-lang.h (fortran_argument_convert): Declaration.
5234         (fortran_preserve_arg_pointer): Declaration.
5235         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5236
5237 2019-03-05  Tom Tromey  <tromey@adacore.com>
5238
5239         * python/py-prettyprint.c (print_string_repr): Remove #if.
5240         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5241
5242 2019-03-05  Tom Tromey  <tromey@adacore.com>
5243
5244         * target.c (the_dummy_target): Move later.  Change type to
5245         "dummy_target".
5246         (initialize_targets): Don't initialize the_dummy_target.
5247
5248 2019-03-05  Tom Tromey  <tromey@adacore.com>
5249
5250         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5251         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5252
5253 2019-03-05  Tom Tromey  <tromey@adacore.com>
5254
5255         * windows-nat.c (windows_nat_target::attach)
5256         (windows_nat_target::detach): Don't call gdb_flush.
5257         * valprint.c (generic_val_print, val_print, val_print_string):
5258         Don't call gdb_flush.
5259         * utils.c (defaulted_query): Don't call gdb_flush.
5260         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5261         * target.c (target_announce_detach): Don't call gdb_flush.
5262         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5263         * remote.c (extended_remote_target::attach): Don't call
5264         gdb_flush.
5265         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5266         * printcmd.c (do_examine): Don't call gdb_flush.
5267         (info_display_command): Don't call gdb_flush.
5268         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5269         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5270         * memattr.c (info_mem_command): Don't call gdb_flush.
5271         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5272         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5273         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5274         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5275         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5276         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5277         (gnu_nat_target::detach): Don't call gdb_flush.
5278         * f-valprint.c (f_val_print): Don't call gdb_flush.
5279         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5280         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5281         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5282         gdb_flush.
5283         * c-valprint.c (c_val_print): Don't call gdb_flush.
5284         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5285
5286 2019-03-05  Tom Tromey  <tromey@adacore.com>
5287
5288         * varobj.c (update_dynamic_varobj_children): Update.
5289         (install_default_visualizer): Use reset, not release.
5290         * value.c (set_internalvar): Update.
5291         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5292         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5293         ATTRIBUTE_UNUSED_RESULT.
5294
5295 2019-03-05  Tom Tromey  <tromey@adacore.com>
5296
5297         * remote.c (class scoped_remote_fd) <release>: Add
5298         ATTRIBUTE_UNUSED_RESULT.
5299
5300 2019-03-05  Tom Tromey  <tromey@adacore.com>
5301
5302         * macroexp.c (struct macro_buffer) <release>: Add
5303         ATTRIBUTE_UNUSED_RESULT.
5304
5305 2019-03-05  Tom Tromey  <tromey@adacore.com>
5306
5307         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5308         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5309         ATTRIBUTE_UNUSED_RESULT.
5310
5311 2019-03-05  Tom Tromey  <tromey@adacore.com>
5312
5313         * common/scoped_fd.h (class scoped_fd) <release>: Add
5314         ATTRIBUTE_UNUSED_RESULT.
5315
5316 2019-03-05  Tom Tromey  <tromey@adacore.com>
5317
5318         * parser-defs.h (struct parser_state) <release>: Add
5319         ATTRIBUTE_UNUSED_RESULT.
5320
5321 2019-03-05  Tom Tromey  <tromey@adacore.com>
5322
5323         * utils.h (class gdb_argv) <release>: Add
5324         ATTRIBUTE_UNUSED_RESULT.
5325         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5326
5327 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5328
5329         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5330         for-loop range, to avoid compiler warnings.
5331
5332         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5333         avoid compiler warnings about unused variables.
5334
5335         * NEWS: Mention end of support for native debugging on MS-Windows
5336         before XP.
5337
5338         PR gdb/24292
5339         * common/netstuff.c:
5340         * gdbserver/gdbreplay.c
5341         * gdbserver/remote-utils.c:
5342         * ser-tcp.c:
5343         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5344         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5345         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5346         'getaddrinfo' and 'freeaddrinfo' were not available before
5347         Windows XP, and mingw.org's MinGW headers by default define
5348         _WIN32_WINNT to 0x500.
5349
5350 2019-03-01  Gary Benson <gbenson@redhat.com>
5351
5352         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5353
5354 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5355             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5356
5357         PR gdb/8527
5358         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5359         set_sigint_trap, clear_sigint_trap.
5360
5361 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5362
5363         * target.c (target_detach): Clear the regcache and the
5364         frame cache.
5365
5366 2019-02-27  Pedro Alves  <palves@redhat.com>
5367
5368         * utils.c (set_screen_size): When we cap the height/width sizes,
5369         tweak the corresponding command variable to show "unlimited":
5370
5371 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5372             Pedro Alves  <palves@redhat.com>
5373
5374         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5375         before calling rl_set_screen_size.
5376
5377 2019-02-27  Tom Tromey  <tromey@adacore.com>
5378
5379         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5380         define.
5381         * python/py-value.c: Remove Python 2.4 workaround.
5382         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5383         workaround.
5384         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5385         Python 2.4 workaround.
5386         * python/python-internal.h: Remove Python 2.4 comment.
5387         (Py_ssize_t): Don't define.
5388         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5389         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5390         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5391         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5392         * python/python.c (do_start_initialization): Remove Python 2.4
5393         workaround.
5394         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5395         (print_children): Remove Python 2.4 workaround.
5396         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5397         workaround.
5398         (CHARBUFFERPROC_NAME): Remove.
5399         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5400         Python 2.4 workaround.
5401
5402 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5403
5404         * NEWS: Note minimum Python version.
5405
5406 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5407
5408         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5409         code from these functions.  Remove corresponding ifdefs.  Use
5410         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5411         Remove gotos and target of gotos.
5412         (infpy_search_memory): Likewise.
5413
5414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5417         (hppa_gdbarch_init): Don't register deleted functions with
5418         gdbarch.
5419
5420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5423         (h8300_unwind_sp): Delete.
5424         (h8300_dummy_id): Delete.
5425         (h8300_gdbarch_init): Don't register deleted functions with
5426         gdbarch.
5427
5428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5431         (ft32_unwind_pc): Delete.
5432         (ft32_unwind_sp): Delete.
5433         (ft32_gdbarch_init): Don't register deleted functions with
5434         gdbarch.
5435
5436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5439         (frv_unwind_pc): Delete.
5440         (frv_unwind_sp): Delete.
5441         (frv_gdbarch_init): Don't register deleted functions with
5442         gdbarch.
5443
5444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5447         (riscv_unwind_pc): Delete.
5448         (riscv_unwind_sp): Delete.
5449         (riscv_gdbarch_init): Don't register deleted functions with
5450         gdbarch.
5451
5452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5455         (csky_unwind_pc): Delete.
5456         (csky_unwind_sp): Delete.
5457         (csky_gdbarch_init): Don't register deleted functions with
5458         gdbarch.
5459
5460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5463         (cris_unwind_pc): Delete.
5464         (cris_unwind_sp): Delete.
5465         (cris_gdbarch_init): Don't register deleted functions with
5466         gdbarch.
5467
5468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5471         (bfin_unwind_pc): Delete.
5472         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5473
5474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5477         (arm_unwind_pc): Delete.
5478         (arm_unwind_sp): Delete.
5479         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5480
5481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5484         (arc_unwind_pc): Delete.
5485         (arc_unwind_sp): Delete.
5486         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5487
5488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5489
5490         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5491         (alpha_unwind_pc): Delete.
5492         (alpha_gdbarch_init): Don't register deleted functions with
5493         gdbarch.
5494
5495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5498         (aarch64_unwind_pc): Delete.
5499         (aarch64_unwind_sp): Delete.
5500         (aarch64_gdbarch_init): Don't register deleted functions with
5501         gdbarch.
5502
5503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * gdbtypes.c (type_align): Don't consider static members when
5506         computing structure alignment.
5507
5508 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5511         return 0 for other types.
5512         * arch-utils.c (default_type_align): Always return 0.
5513         * gdbarch.h: Regenerate.
5514         * gdbarch.sh (type_align): Extend comment.
5515         * gdbtypes.c (type_align): Add additional comments, always call
5516         gdbarch_type_align before applying the default rules.
5517         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5518         generic code will then apply a suitable default.
5519         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5520         types, return 0 for other types.
5521
5522 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5523
5524         * NEWS: Create a new section for the next release branch.
5525         Rename the section of the current branch, now that it has
5526         been cut.
5527
5528 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5529
5530         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5531         * version.in: Bump version to 8.3.50.DATE-git.
5532
5533 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5534
5535         * aix-thread.c (ptid_cmp): Remove unused variable.
5536         (get_signaled_thread): Likewise.
5537         (store_regs_user_thread): Likewise.
5538         (store_regs_kernel_thread): Likewise.
5539         (fetch_regs_kernel_thread): Remove shadowed variable.
5540
5541 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * features/riscv/32bit-cpu.xml: Add register numbers.
5544         * features/riscv/32bit-fpu.c: Regenerate.
5545         * features/riscv/32bit-fpu.xml: Add register numbers.
5546         * features/riscv/64bit-cpu.xml: Add register numbers.
5547         * features/riscv/64bit-fpu.c: Regenerate.
5548         * features/riscv/64bit-fpu.xml: Add register numbers.
5549
5550 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5551
5552         * NEWS: Mention two argument form of gdb.Value constructor.
5553         * python/py-value.c (convert_buffer_and_type_to_value): New
5554         function.
5555         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5556         Add support for handling an optional second argument.  Call
5557         convert_buffer_and_type_to_value as appropriate.
5558         * python/python-internal.h (Py_buffer_deleter): New struct.
5559         (Py_buffer_up): New typedef.
5560
5561 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5562
5563         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5564         instead of releasing ownership.
5565
5566 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5567
5568         * dwarf2read.c (open_and_init_dwp_file): Call
5569         elf_numsections instead of bfd_count_sections to initialize
5570         dwp_file->num_sections.
5571
5572 2019-02-25  Tom Tromey  <tromey@adacore.com>
5573
5574         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5575
5576 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5577
5578         * gcore.in: Add '--readnever' option when invoking GDB.
5579
5580 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5581
5582         * MAINTAINERS: Update my email address.
5583
5584 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5585
5586         * build-id.c (build_id_to_debug_bfd_1): New function.
5587         (build_id_to_debug_bfd): Look for separate debug file in
5588         sysroot.
5589
5590 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5591
5592         * gdbarch.sh: Update the copyright year range that is placed into
5593         generated files.
5594
5595 2019-02-22  Keith Seitz  <keiths@redhat.com>
5596
5597         PR symtab/23853
5598         * linespec.c (create_sals_line_offset): Search for the default
5599         symtab's filename instead of its fullname.
5600
5601 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5602
5603         * NEWS: Update style defaults.
5604
5605 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5606
5607         * main.c (captured_main_1): Disable styling in batch mode.
5608
5609 2019-02-20  Tom Tromey  <tom@tromey.com>
5610
5611         * symtab.c (symtab_symbol_info): Fix typos.
5612
5613 2019-02-20  Tom Tromey  <tromey@adacore.com>
5614
5615         * findcmd.c (_initialize_mem_search): Use upper case for
5616         metasyntactic variables.
5617
5618 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5619
5620         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5621         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5622
5623 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5624
5625         * top.h (source_file_name): Change to std::string.
5626         * top.c (source_file_name): Likewise.
5627         (command_line_input): Adjust.
5628         * cli/cli-script.c (script_from_file): Adjust.
5629
5630 2019-02-19  Tom Tromey  <tromey@adacore.com>
5631
5632         * ravenscar-thread.c
5633         (ravenscar_thread_target::update_thread_list): Don't call
5634         ada_build_task_list.
5635         * ada-lang.h (ada_build_task_list): Don't declare.
5636         * ada-tasks.c (struct ada_tasks_inferior_data)
5637         <task_list_valid_p>: Now bool.
5638         (read_known_tasks, ada_task_list_changed)
5639         (ada_tasks_invalidate_inferior_data): Update.
5640         (read_known_tasks_array): Return bool.
5641         (read_known_tasks_list): Likewise.
5642         (read_known_tasks): Return void.
5643         (ada_build_task_list): Now static.
5644
5645 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5646
5647         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5648         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5649
5650 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5651
5652         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5653         variant for ada_tasks_pspace_data_handle and
5654         ada_tasks_inferior_data_handle.
5655         (ada_tasks_pspace_data_cleanup): New function.
5656         (ada_tasks_inferior_data_cleanup): New function.
5657
5658 2019-02-17  Tom Tromey  <tom@tromey.com>
5659
5660         * macrotab.h (macro_source_fullname): Return a std::string.
5661         * macrotab.c (macro_include, check_for_redefinition)
5662         (macro_undef, macro_lookup_definition, foreach_macro)
5663         (foreach_macro_in_scope): Update.
5664         (macro_source_fullname): Return a std::string.
5665         * macrocmd.c (show_pp_source_pos): Update.
5666
5667 2019-02-17  Tom Tromey  <tom@tromey.com>
5668
5669         * macrocmd.c (show_pp_source_pos): Style the file names.
5670
5671 2019-02-17  Tom Tromey  <tom@tromey.com>
5672
5673         PR tui/24197:
5674         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5675
5676 2019-02-17  Tom Tromey  <tom@tromey.com>
5677
5678         * ada-lang.c (user_select_syms): Use filtered printing.
5679         * utils.c (wrap_style): New global.
5680         (desired_style): Remove.
5681         (emit_style_escape): Add stream parameter.
5682         (set_output_style, reset_terminal_style, prompt_for_continue):
5683         Update.
5684         (flush_wrap_buffer): Only flush gdb_stdout.
5685         (wrap_here): Set wrap_style.
5686         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5687         treat escape sequences as a character.  Change when wrap buffer is
5688         flushed.
5689         (fputs_styled): Do not set the output style when the default is
5690         requested.
5691         * ui-style.h (struct ui_file_style) <is_default>: New method.
5692         * source.c (print_source_lines_base): Emit escape sequences in one
5693         piece.
5694
5695 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5696
5697         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5698         integers and enumeration types.
5699
5700 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5701
5702         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5703         instead of lookup_symbol_in_language
5704         (do_exact_match): New function.
5705         (ada_get_symbol_name_matcher): Return do_exact_match when
5706         doing a verbatim match.
5707
5708 2019-02-15  Tom Tromey  <tromey@adacore.com>
5709
5710         * ravenscar-thread.c (ravenscar_thread_target::resume)
5711         (ravenscar_thread_target::wait): Special case wildcard requests.
5712
5713 2019-02-15  Tom Tromey  <tromey@adacore.com>
5714
5715         * ravenscar-thread.c (base_ptid): Remove.
5716         (struct ravenscar_thread_target) <close>: New method.
5717         <m_base_ptid>: New member.
5718         <update_inferior_ptid, active_task, task_is_currently_active,
5719         runtime_initialized>: Declare methods.
5720         <ravenscar_thread_target>: Add constructor.
5721         (ravenscar_thread_target::task_is_currently_active)
5722         (ravenscar_thread_target::update_inferior_ptid)
5723         (ravenscar_runtime_initialized): Rename.  Now methods.
5724         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5725         (ravenscar_thread_target::update_thread_list): Update.
5726         (ravenscar_thread_target::active_task): Now method.
5727         (ravenscar_thread_target::store_registers)
5728         (ravenscar_thread_target::prepare_to_store)
5729         (ravenscar_thread_target::prepare_to_store)
5730         (ravenscar_thread_target::mourn_inferior): Update.
5731         (ravenscar_inferior_created): Use "new" to create target.
5732         (ravenscar_thread_target::get_ada_task_ptid): Update.
5733         (_initialize_ravenscar): Don't initialize base_ptid.
5734         (ravenscar_ops): Remove global.
5735
5736 2019-02-15  Tom Tromey  <tromey@adacore.com>
5737
5738         * target.h (push_target): Declare new overload.
5739         * target.c (push_target): New overload, taking an rvalue reference.
5740         * remote.c (remote_target::open_1): Use push_target overload.
5741         * corelow.c (core_target_open): Use push_target overload.
5742
5743 2019-02-15  Tom Tromey  <tromey@adacore.com>
5744
5745         * ravenscar-thread.c (is_ravenscar_task)
5746         (ravenscar_task_is_currently_active): Return bool.
5747         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5748         (_initialize_ravenscar): Remove "(void)".
5749         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5750         Return bool.
5751
5752 2019-02-15  Tom Tromey  <tromey@adacore.com>
5753
5754         * ravenscar-thread.c (ravenscar_runtime_initializer)
5755         (has_ravenscar_runtime, get_running_thread_id)
5756         (ravenscar_thread_target::resume): Fix indentation.
5757
5758 2019-02-15  Tom Tromey  <tromey@adacore.com>
5759
5760         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5761         from ravenscar_arch_ops.
5762         (sparc_ravenscar_ops::fetch_registers)
5763         (sparc_ravenscar_ops::store_registers): Now methods.
5764         (sparc_ravenscar_prepare_to_store): Remove.
5765         (sparc_ravenscar_ops): Redefine.
5766         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5767         methods and destructor.  Remove members.
5768         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5769         (ravenscar_thread_target::store_registers)
5770         (ravenscar_thread_target::prepare_to_store): Update.
5771         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5772         Remove.
5773         (struct ppc_ravenscar_powerpc_ops): Derive from
5774         ravenscar_arch_ops.
5775         (ppc_ravenscar_powerpc_ops::fetch_registers)
5776         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5777         (ppc_ravenscar_powerpc_ops): Redefine.
5778         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5779         (ppc_ravenscar_e500_ops::fetch_registers)
5780         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5781         (ppc_ravenscar_e500_ops): Redefine.
5782         * aarch64-ravenscar-thread.c
5783         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5784         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5785         (aarch64_ravenscar_fetch_registers)
5786         (aarch64_ravenscar_store_registers): Now methods.
5787         (aarch64_ravenscar_ops): Redefine.
5788
5789 2019-02-15  Tom Tromey  <tromey@adacore.com>
5790
5791         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5792         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5793         (ravenscar_thread_target::stopped_by_watchpoint)
5794         (ravenscar_thread_target::stopped_data_address)
5795         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5796
5797 2019-02-15  Tom Tromey  <tromey@adacore.com>
5798
5799         * ravenscar-thread.c: Fix some typos.
5800
5801 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5802             Tom Tromey  <tromey@adacore.com>
5803
5804         * ada-lang.c (ada_exception_sal): Change addr_string to a
5805         std::string.
5806         (create_ada_exception_catchpoint): Update.
5807
5808 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5809             Tom Tromey  <tromey@adacore.com>
5810
5811         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5812         (bp_location_ops): Remove.
5813         (base_breakpoint_allocate_location): Update.
5814         (free_bp_location): Update.
5815         * ada-lang.c (class ada_catchpoint_location)
5816         <ada_catchpoint_location>: Remove ops parameter.
5817         (ada_catchpoint_location_dtor): Remove.
5818         (ada_catchpoint_location_ops): Remove.
5819         (allocate_location_exception): Update.
5820         * breakpoint.h (struct bp_location_ops): Remove.
5821         (class bp_location) <bp_location>: Remove bp_location_ops
5822         parameter.
5823         <~bp_location>: Add destructor.
5824         <ops>: Remove.
5825
5826 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5827             Pedro Alves  <palves@redhat.com>
5828
5829         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5830         'PATH_MAX'.
5831
5832 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5833             Samuel Thibault  <samuel.thibault@gnu.org>
5834             Thomas Schwinge  <thomas@codesourcery.com>
5835
5836         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5837         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5838
5839 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5840
5841         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5842         (check_empty): Use "const char *".
5843
5844         * gnu-nat.c (gnu_nat_target::detach): Instead of
5845         'detach_inferior (pid)' call
5846         'detach_inferior (find_inferior_pid (pid))'.
5847
5848         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5849         'nat/fork-inferior.o'.
5850         * gnu-nat.c: #include "nat/fork-inferior.h".
5851
5852         * gnu-nat.c (gnu_nat_target::detach): Instead of
5853         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5854         * gnu-nat.h: #include "inf-child.h".
5855         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5856         'i386_gnu_nat_target::fetch_registers'.
5857         (gnu_store_registers): Rename/move to
5858         'i386_gnu_nat_target::store_registers'.
5859
5860         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5861         * gnu-nat.h (mach_thread_info): New function.
5862         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5863
5864         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5865
5866 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5867
5868         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5869
5870 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5871
5872         * windows-nat.c (windows_add_thread): Add new parameter
5873         "main_thread_p" with default value set to false.  Update
5874         function documentation as well as all callers.
5875         (windows_delete_thread): Likewise.
5876         (fake_create_process): Update call to windows_add_thread.
5877         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5878         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5879         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5880         call to windows_delete_thread.
5881
5882 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5883
5884         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5885
5886 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5887
5888         * symfile.c (find_separate_debug_file): Use canonical path of
5889         sysroot with child_path instead of gdb_sysroot if it is valid.
5890
5891 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5892
5893         * symfile.c (find_separate_debug_file): Use child_path to
5894         determine if an object file is under a sysroot.
5895
5896 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5897
5898         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5899         unittests/child-path-selftests.c.
5900         * common/pathstuff.c (child_path): New function.
5901         * common/pathstuff.h (child_path): New prototype.
5902         * unittests/child-path-selftests.c: New file.
5903
5904 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5905
5906         * symfile.c (find_separate_debug_file): Look for separate debug
5907         files in debug directories under the sysroot.
5908
5909 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5910
5911         * symtab.h (struct minimal_symbol data_p): New const method.
5912         (struct minimal_symbol text_p): Likewise.
5913         * symtab.c (output_source_filename): Use file name style
5914         to print file name.
5915         (print_symbol_info): Likewise.
5916         (print_msymbol_info): Use address style to print addresses.
5917         Use function name style to print executable text symbols.
5918         (expand_symtab_containing_pc): Use data_p.
5919         (find_pc_sect_compunit_symtab): Likewise.
5920
5921 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5922
5923         * breakpoint.c (describe_other_breakpoints): Use address style
5924         to print addresses.
5925         (say_where): Likewise.
5926
5927 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5928
5929         * ada-typeprint.c (print_func_type): Print function name
5930         style to print function name.
5931         * c-typeprint.c (c_print_type_1): Likewise.
5932
5933 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5934
5935         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5936         for execve.
5937
5938 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5939
5940         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5941         type_stack.
5942
5943 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5944
5945         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5946         TYPE_CODE_REF types.
5947
5948 2019-02-08  Jim Wilson  <jimw@sifive.com>
5949
5950         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5951         (riscv_linux_fregset): New.
5952         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5953
5954 2019-02-07  Tom Tromey  <tom@tromey.com>
5955
5956         * thread.c (thread_cancel_execution_command): Update.
5957         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5958         methods.
5959         (struct thread_fsm_ops): Remove.
5960         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5961         (thread_fsm_should_stop, thread_fsm_return_value)
5962         (thread_fsm_set_finished, thread_fsm_finished_p)
5963         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5964         Don't declare.
5965         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5966         * infrun.c (clear_proceed_status_thread)
5967         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5968         (print_stop_event): Update.
5969         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5970         Add constructor.
5971         (step_command_fsm_ops): Remove.
5972         (new_step_command_fsm): Remove.
5973         (step_1): Update.
5974         (step_command_fsm::should_stop): Rename from
5975         step_command_fsm_should_stop.
5976         (step_command_fsm::clean_up): Rename from
5977         step_command_fsm_clean_up.
5978         (step_command_fsm::do_async_reply_reason): Rename from
5979         step_command_fsm_async_reply_reason.
5980         (struct until_next_fsm): Inherit from thread_fsm.  Add
5981         constructor.
5982         (until_next_fsm_ops): Remove.
5983         (new_until_next_fsm): Remove.
5984         (until_next_fsm::should_stop): Rename from
5985         until_next_fsm_should_stop.
5986         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5987         (until_next_fsm::do_async_reply_reason): Rename from
5988         until_next_fsm_async_reply_reason.
5989         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5990         constructor.  Change type of breakpoint.
5991         (finish_command_fsm_ops): Remove.
5992         (new_finish_command_fsm): Remove.
5993         (finish_command_fsm::should_stop): Rename from
5994         finish_command_fsm_should_stop.
5995         (finish_command_fsm::clean_up): Rename from
5996         finish_command_fsm_clean_up.
5997         (finish_command_fsm::return_value): Rename from
5998         finish_command_fsm_return_value.
5999         (finish_command_fsm::do_async_reply_reason): Rename from
6000         finish_command_fsm_async_reply_reason.
6001         (finish_command): Update.
6002         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6003         Add constructor.
6004         (call_thread_fsm_ops): Remove.
6005         (call_thread_fsm::call_thread_fsm): Rename from
6006         new_call_thread_fsm.
6007         (call_thread_fsm::should_stop): Rename from
6008         call_thread_fsm_should_stop.
6009         (call_thread_fsm::should_notify_stop): Rename from
6010         call_thread_fsm_should_notify_stop.
6011         (run_inferior_call, call_function_by_hand_dummy): Update.
6012         * cli/cli-interp.c (should_print_stop_to_console): Update.
6013         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6014         Add constructor.  Change type of location_breakpoint,
6015         caller_breakpoint.
6016         (until_break_fsm_ops): Remove.
6017         (new_until_break_fsm): Remove.
6018         (until_break_fsm::should_stop): Rename from
6019         until_break_fsm_should_stop.
6020         (until_break_fsm::clean_up): Rename from
6021         until_break_fsm_clean_up.
6022         (until_break_fsm::do_async_reply_reason): Rename from
6023         until_break_fsm_async_reply_reason.
6024         (until_break_command): Update.
6025         * thread-fsm.c: Remove.
6026         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6027
6028 2019-02-07  Tom Tromey  <tom@tromey.com>
6029
6030         * yy-remap.h: Add include guard.
6031         * xtensa-tdep.h: Add include guard.
6032         * xcoffread.h: Rename include guard.
6033         * varobj-iter.h: Add include guard.
6034         * tui/tui.h: Rename include guard.
6035         * tui/tui-winsource.h: Rename include guard.
6036         * tui/tui-wingeneral.h: Rename include guard.
6037         * tui/tui-windata.h: Rename include guard.
6038         * tui/tui-win.h: Rename include guard.
6039         * tui/tui-stack.h: Rename include guard.
6040         * tui/tui-source.h: Rename include guard.
6041         * tui/tui-regs.h: Rename include guard.
6042         * tui/tui-out.h: Rename include guard.
6043         * tui/tui-layout.h: Rename include guard.
6044         * tui/tui-io.h: Rename include guard.
6045         * tui/tui-hooks.h: Rename include guard.
6046         * tui/tui-file.h: Rename include guard.
6047         * tui/tui-disasm.h: Rename include guard.
6048         * tui/tui-data.h: Rename include guard.
6049         * tui/tui-command.h: Rename include guard.
6050         * tic6x-tdep.h: Add include guard.
6051         * target/waitstatus.h: Rename include guard.
6052         * target/wait.h: Rename include guard.
6053         * target/target.h: Rename include guard.
6054         * target/resume.h: Rename include guard.
6055         * target-float.h: Rename include guard.
6056         * stabsread.h: Add include guard.
6057         * rs6000-tdep.h: Add include guard.
6058         * riscv-fbsd-tdep.h: Add include guard.
6059         * regformats/regdef.h: Rename include guard.
6060         * record.h: Rename include guard.
6061         * python/python.h: Rename include guard.
6062         * python/python-internal.h: Rename include guard.
6063         * python/py-stopevent.h: Rename include guard.
6064         * python/py-ref.h: Rename include guard.
6065         * python/py-record.h: Rename include guard.
6066         * python/py-record-full.h: Rename include guard.
6067         * python/py-record-btrace.h: Rename include guard.
6068         * python/py-instruction.h: Rename include guard.
6069         * python/py-events.h: Rename include guard.
6070         * python/py-event.h: Rename include guard.
6071         * procfs.h: Add include guard.
6072         * proc-utils.h: Add include guard.
6073         * p-lang.h: Add include guard.
6074         * or1k-tdep.h: Rename include guard.
6075         * observable.h: Rename include guard.
6076         * nto-tdep.h: Rename include guard.
6077         * nat/x86-linux.h: Rename include guard.
6078         * nat/x86-linux-dregs.h: Rename include guard.
6079         * nat/x86-gcc-cpuid.h: Add include guard.
6080         * nat/x86-dregs.h: Rename include guard.
6081         * nat/x86-cpuid.h: Rename include guard.
6082         * nat/ppc-linux.h: Rename include guard.
6083         * nat/mips-linux-watch.h: Rename include guard.
6084         * nat/linux-waitpid.h: Rename include guard.
6085         * nat/linux-ptrace.h: Rename include guard.
6086         * nat/linux-procfs.h: Rename include guard.
6087         * nat/linux-osdata.h: Rename include guard.
6088         * nat/linux-nat.h: Rename include guard.
6089         * nat/linux-namespaces.h: Rename include guard.
6090         * nat/linux-btrace.h: Rename include guard.
6091         * nat/glibc_thread_db.h: Rename include guard.
6092         * nat/gdb_thread_db.h: Rename include guard.
6093         * nat/gdb_ptrace.h: Rename include guard.
6094         * nat/fork-inferior.h: Rename include guard.
6095         * nat/amd64-linux-siginfo.h: Rename include guard.
6096         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6097         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6098         * nat/aarch64-linux.h: Rename include guard.
6099         * nat/aarch64-linux-hw-point.h: Rename include guard.
6100         * mn10300-tdep.h: Add include guard.
6101         * mips-linux-tdep.h: Add include guard.
6102         * mi/mi-parse.h: Rename include guard.
6103         * mi/mi-out.h: Rename include guard.
6104         * mi/mi-main.h: Rename include guard.
6105         * mi/mi-interp.h: Rename include guard.
6106         * mi/mi-getopt.h: Rename include guard.
6107         * mi/mi-console.h: Rename include guard.
6108         * mi/mi-common.h: Rename include guard.
6109         * mi/mi-cmds.h: Rename include guard.
6110         * mi/mi-cmd-break.h: Rename include guard.
6111         * m2-lang.h: Add include guard.
6112         * location.h: Rename include guard.
6113         * linux-record.h: Rename include guard.
6114         * linux-nat.h: Add include guard.
6115         * linux-fork.h: Add include guard.
6116         * i386-darwin-tdep.h: Rename include guard.
6117         * hppa-linux-offsets.h: Add include guard.
6118         * guile/guile.h: Rename include guard.
6119         * guile/guile-internal.h: Rename include guard.
6120         * gnu-nat.h: Rename include guard.
6121         * gdb-stabs.h: Rename include guard.
6122         * frv-tdep.h: Add include guard.
6123         * f-lang.h: Add include guard.
6124         * event-loop.h: Add include guard.
6125         * darwin-nat.h: Rename include guard.
6126         * cp-abi.h: Rename include guard.
6127         * config/sparc/nm-sol2.h: Rename include guard.
6128         * config/nm-nto.h: Rename include guard.
6129         * config/nm-linux.h: Add include guard.
6130         * config/i386/nm-i386gnu.h: Rename include guard.
6131         * config/djgpp/nl_types.h: Rename include guard.
6132         * config/djgpp/langinfo.h: Rename include guard.
6133         * compile/gcc-cp-plugin.h: Add include guard.
6134         * compile/gcc-c-plugin.h: Add include guard.
6135         * compile/compile.h: Rename include guard.
6136         * compile/compile-object-run.h: Rename include guard.
6137         * compile/compile-object-load.h: Rename include guard.
6138         * compile/compile-internal.h: Rename include guard.
6139         * compile/compile-cplus.h: Rename include guard.
6140         * compile/compile-c.h: Rename include guard.
6141         * common/xml-utils.h: Rename include guard.
6142         * common/x86-xstate.h: Rename include guard.
6143         * common/version.h: Rename include guard.
6144         * common/vec.h: Rename include guard.
6145         * common/tdesc.h: Rename include guard.
6146         * common/selftest.h: Rename include guard.
6147         * common/scoped_restore.h: Rename include guard.
6148         * common/scoped_mmap.h: Rename include guard.
6149         * common/scoped_fd.h: Rename include guard.
6150         * common/safe-iterator.h: Rename include guard.
6151         * common/run-time-clock.h: Rename include guard.
6152         * common/refcounted-object.h: Rename include guard.
6153         * common/queue.h: Rename include guard.
6154         * common/ptid.h: Rename include guard.
6155         * common/print-utils.h: Rename include guard.
6156         * common/preprocessor.h: Rename include guard.
6157         * common/pathstuff.h: Rename include guard.
6158         * common/observable.h: Rename include guard.
6159         * common/netstuff.h: Rename include guard.
6160         * common/job-control.h: Rename include guard.
6161         * common/host-defs.h: Rename include guard.
6162         * common/gdb_wait.h: Rename include guard.
6163         * common/gdb_vecs.h: Rename include guard.
6164         * common/gdb_unlinker.h: Rename include guard.
6165         * common/gdb_unique_ptr.h: Rename include guard.
6166         * common/gdb_tilde_expand.h: Rename include guard.
6167         * common/gdb_sys_time.h: Rename include guard.
6168         * common/gdb_string_view.h: Rename include guard.
6169         * common/gdb_splay_tree.h: Rename include guard.
6170         * common/gdb_setjmp.h: Rename include guard.
6171         * common/gdb_ref_ptr.h: Rename include guard.
6172         * common/gdb_optional.h: Rename include guard.
6173         * common/gdb_locale.h: Rename include guard.
6174         * common/gdb_assert.h: Rename include guard.
6175         * common/filtered-iterator.h: Rename include guard.
6176         * common/filestuff.h: Rename include guard.
6177         * common/fileio.h: Rename include guard.
6178         * common/environ.h: Rename include guard.
6179         * common/common-utils.h: Rename include guard.
6180         * common/common-types.h: Rename include guard.
6181         * common/common-regcache.h: Rename include guard.
6182         * common/common-inferior.h: Rename include guard.
6183         * common/common-gdbthread.h: Rename include guard.
6184         * common/common-exceptions.h: Rename include guard.
6185         * common/common-defs.h: Rename include guard.
6186         * common/common-debug.h: Rename include guard.
6187         * common/cleanups.h: Rename include guard.
6188         * common/buffer.h: Rename include guard.
6189         * common/btrace-common.h: Rename include guard.
6190         * common/break-common.h: Rename include guard.
6191         * cli/cli-utils.h: Rename include guard.
6192         * cli/cli-style.h: Rename include guard.
6193         * cli/cli-setshow.h: Rename include guard.
6194         * cli/cli-script.h: Rename include guard.
6195         * cli/cli-interp.h: Rename include guard.
6196         * cli/cli-decode.h: Rename include guard.
6197         * cli/cli-cmds.h: Rename include guard.
6198         * charset-list.h: Add include guard.
6199         * buildsym-legacy.h: Rename include guard.
6200         * bfin-tdep.h: Add include guard.
6201         * ax.h: Rename include guard.
6202         * arm-linux-tdep.h: Add include guard.
6203         * arm-fbsd-tdep.h: Add include guard.
6204         * arch/xtensa.h: Rename include guard.
6205         * arch/tic6x.h: Add include guard.
6206         * arch/i386.h: Add include guard.
6207         * arch/arm.h: Rename include guard.
6208         * arch/arm-linux.h: Rename include guard.
6209         * arch/arm-get-next-pcs.h: Rename include guard.
6210         * arch/amd64.h: Add include guard.
6211         * arch/aarch64-insn.h: Rename include guard.
6212         * arch-utils.h: Rename include guard.
6213         * annotate.h: Add include guard.
6214         * amd64-darwin-tdep.h: Rename include guard.
6215         * aarch64-linux-tdep.h: Add include guard.
6216         * aarch64-fbsd-tdep.h: Add include guard.
6217         * aarch32-linux-nat.h: Add include guard.
6218
6219 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6220
6221         * macrotab.c (macro_define_internal): New function that
6222         factorizes macro_define_object_internal and macro_define_function
6223         code.
6224         (macro_define_object_internal): Use macro_define_internal.
6225         (macro_define_function): Likewise.
6226
6227 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6228
6229         * macrocmd.c (extract_identifier): Return
6230         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6231         callers.
6232
6233 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6234
6235         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6236
6237 2019-02-05  Tom Tromey  <tom@tromey.com>
6238
6239         * target.c (target_stack::unpush): Move assertion earlier.
6240
6241 2019-01-30  Tom Tromey  <tom@tromey.com>
6242
6243         PR python/23615:
6244         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6245         (gdbpy_parse_and_eval): Likewise.
6246         * python/python-internal.h (gdbpy_allow_threads): New class.
6247
6248 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6249
6250         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6251         (aarch64_fbsd_fpregmap): Move earlier.
6252         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6253         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6254         instead of individual calls to trad_frame_set_reg_addr.
6255         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6256         earlier.
6257         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6258         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6259         instead of individual calls to trad_frame_set_reg_addr.
6260
6261 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6262
6263         * CONTRIBUTE: Replace contribution list with wiki link.
6264
6265 2019-01-25  Tom Tromey  <tom@tromey.com>
6266
6267         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6268
6269 2019-01-25  Tom Tromey  <tom@tromey.com>
6270
6271         * xtensa-linux-nat.c: Fix common/ includes.
6272         * xml-support.h: Fix common/ includes.
6273         * xml-support.c: Fix common/ includes.
6274         * x86-linux-nat.c: Fix common/ includes.
6275         * windows-nat.c: Fix common/ includes.
6276         * varobj.h: Fix common/ includes.
6277         * varobj.c: Fix common/ includes.
6278         * value.c: Fix common/ includes.
6279         * valops.c: Fix common/ includes.
6280         * utils.c: Fix common/ includes.
6281         * unittests/xml-utils-selftests.c: Fix common/ includes.
6282         * unittests/utils-selftests.c: Fix common/ includes.
6283         * unittests/unpack-selftests.c: Fix common/ includes.
6284         * unittests/tracepoint-selftests.c: Fix common/ includes.
6285         * unittests/style-selftests.c: Fix common/ includes.
6286         * unittests/string_view-selftests.c: Fix common/ includes.
6287         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6288         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6289         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6290         * unittests/rsp-low-selftests.c: Fix common/ includes.
6291         * unittests/parse-connection-spec-selftests.c: Fix common/
6292         includes.
6293         * unittests/optional-selftests.c: Fix common/ includes.
6294         * unittests/offset-type-selftests.c: Fix common/ includes.
6295         * unittests/observable-selftests.c: Fix common/ includes.
6296         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6297         * unittests/memrange-selftests.c: Fix common/ includes.
6298         * unittests/memory-map-selftests.c: Fix common/ includes.
6299         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6300         * unittests/function-view-selftests.c: Fix common/ includes.
6301         * unittests/environ-selftests.c: Fix common/ includes.
6302         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6303         * unittests/common-utils-selftests.c: Fix common/ includes.
6304         * unittests/cli-utils-selftests.c: Fix common/ includes.
6305         * unittests/array-view-selftests.c: Fix common/ includes.
6306         * ui-file.c: Fix common/ includes.
6307         * tui/tui-io.c: Fix common/ includes.
6308         * tracepoint.h: Fix common/ includes.
6309         * tracepoint.c: Fix common/ includes.
6310         * tracefile-tfile.c: Fix common/ includes.
6311         * top.h: Fix common/ includes.
6312         * top.c: Fix common/ includes.
6313         * thread.c: Fix common/ includes.
6314         * target/waitstatus.h: Fix common/ includes.
6315         * target/waitstatus.c: Fix common/ includes.
6316         * target.h: Fix common/ includes.
6317         * target.c: Fix common/ includes.
6318         * target-memory.c: Fix common/ includes.
6319         * target-descriptions.c: Fix common/ includes.
6320         * symtab.h: Fix common/ includes.
6321         * symfile.c: Fix common/ includes.
6322         * stap-probe.c: Fix common/ includes.
6323         * spu-linux-nat.c: Fix common/ includes.
6324         * sparc-nat.c: Fix common/ includes.
6325         * source.c: Fix common/ includes.
6326         * solib.c: Fix common/ includes.
6327         * solib-target.c: Fix common/ includes.
6328         * ser-unix.c: Fix common/ includes.
6329         * ser-tcp.c: Fix common/ includes.
6330         * ser-pipe.c: Fix common/ includes.
6331         * ser-base.c: Fix common/ includes.
6332         * selftest-arch.c: Fix common/ includes.
6333         * s12z-tdep.c: Fix common/ includes.
6334         * rust-exp.y: Fix common/ includes.
6335         * rs6000-aix-tdep.c: Fix common/ includes.
6336         * riscv-tdep.c: Fix common/ includes.
6337         * remote.c: Fix common/ includes.
6338         * remote-notif.h: Fix common/ includes.
6339         * remote-fileio.h: Fix common/ includes.
6340         * remote-fileio.c: Fix common/ includes.
6341         * regcache.h: Fix common/ includes.
6342         * regcache.c: Fix common/ includes.
6343         * record-btrace.c: Fix common/ includes.
6344         * python/python.c: Fix common/ includes.
6345         * python/py-type.c: Fix common/ includes.
6346         * python/py-inferior.c: Fix common/ includes.
6347         * progspace.h: Fix common/ includes.
6348         * producer.c: Fix common/ includes.
6349         * procfs.c: Fix common/ includes.
6350         * proc-api.c: Fix common/ includes.
6351         * printcmd.c: Fix common/ includes.
6352         * ppc-linux-nat.c: Fix common/ includes.
6353         * parser-defs.h: Fix common/ includes.
6354         * osdata.c: Fix common/ includes.
6355         * obsd-nat.c: Fix common/ includes.
6356         * nat/x86-linux.c: Fix common/ includes.
6357         * nat/x86-linux-dregs.c: Fix common/ includes.
6358         * nat/x86-dregs.h: Fix common/ includes.
6359         * nat/x86-dregs.c: Fix common/ includes.
6360         * nat/ppc-linux.c: Fix common/ includes.
6361         * nat/mips-linux-watch.h: Fix common/ includes.
6362         * nat/mips-linux-watch.c: Fix common/ includes.
6363         * nat/linux-waitpid.c: Fix common/ includes.
6364         * nat/linux-ptrace.h: Fix common/ includes.
6365         * nat/linux-ptrace.c: Fix common/ includes.
6366         * nat/linux-procfs.c: Fix common/ includes.
6367         * nat/linux-personality.c: Fix common/ includes.
6368         * nat/linux-osdata.c: Fix common/ includes.
6369         * nat/linux-namespaces.c: Fix common/ includes.
6370         * nat/linux-btrace.h: Fix common/ includes.
6371         * nat/linux-btrace.c: Fix common/ includes.
6372         * nat/fork-inferior.c: Fix common/ includes.
6373         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6374         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6375         * nat/aarch64-linux.c: Fix common/ includes.
6376         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6377         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6378         * namespace.h: Fix common/ includes.
6379         * mips-linux-tdep.c: Fix common/ includes.
6380         * minsyms.c: Fix common/ includes.
6381         * mi/mi-parse.h: Fix common/ includes.
6382         * mi/mi-main.c: Fix common/ includes.
6383         * mi/mi-cmd-env.c: Fix common/ includes.
6384         * memrange.h: Fix common/ includes.
6385         * memattr.c: Fix common/ includes.
6386         * maint.h: Fix common/ includes.
6387         * maint.c: Fix common/ includes.
6388         * main.c: Fix common/ includes.
6389         * machoread.c: Fix common/ includes.
6390         * location.c: Fix common/ includes.
6391         * linux-thread-db.c: Fix common/ includes.
6392         * linux-nat.c: Fix common/ includes.
6393         * linux-fork.c: Fix common/ includes.
6394         * inline-frame.c: Fix common/ includes.
6395         * infrun.c: Fix common/ includes.
6396         * inflow.c: Fix common/ includes.
6397         * inferior.h: Fix common/ includes.
6398         * inferior.c: Fix common/ includes.
6399         * infcmd.c: Fix common/ includes.
6400         * inf-ptrace.c: Fix common/ includes.
6401         * inf-child.c: Fix common/ includes.
6402         * ia64-linux-nat.c: Fix common/ includes.
6403         * i387-tdep.c: Fix common/ includes.
6404         * i386-tdep.c: Fix common/ includes.
6405         * i386-linux-tdep.c: Fix common/ includes.
6406         * i386-linux-nat.c: Fix common/ includes.
6407         * i386-go32-tdep.c: Fix common/ includes.
6408         * i386-fbsd-tdep.c: Fix common/ includes.
6409         * i386-fbsd-nat.c: Fix common/ includes.
6410         * guile/scm-type.c: Fix common/ includes.
6411         * guile/guile.c: Fix common/ includes.
6412         * go32-nat.c: Fix common/ includes.
6413         * gnu-nat.c: Fix common/ includes.
6414         * gdbthread.h: Fix common/ includes.
6415         * gdbarch-selftests.c: Fix common/ includes.
6416         * gdb_usleep.c: Fix common/ includes.
6417         * gdb_select.h: Fix common/ includes.
6418         * gdb_bfd.c: Fix common/ includes.
6419         * gcore.c: Fix common/ includes.
6420         * fork-child.c: Fix common/ includes.
6421         * findvar.c: Fix common/ includes.
6422         * fbsd-nat.c: Fix common/ includes.
6423         * event-top.c: Fix common/ includes.
6424         * event-loop.c: Fix common/ includes.
6425         * dwarf2read.c: Fix common/ includes.
6426         * dwarf2loc.c: Fix common/ includes.
6427         * dwarf2-frame.c: Fix common/ includes.
6428         * dwarf-index-cache.c: Fix common/ includes.
6429         * dtrace-probe.c: Fix common/ includes.
6430         * disasm-selftests.c: Fix common/ includes.
6431         * defs.h: Fix common/ includes.
6432         * csky-tdep.c: Fix common/ includes.
6433         * cp-valprint.c: Fix common/ includes.
6434         * cp-support.h: Fix common/ includes.
6435         * cp-support.c: Fix common/ includes.
6436         * corelow.c: Fix common/ includes.
6437         * completer.h: Fix common/ includes.
6438         * completer.c: Fix common/ includes.
6439         * compile/compile.c: Fix common/ includes.
6440         * compile/compile-loc2c.c: Fix common/ includes.
6441         * compile/compile-cplus-types.c: Fix common/ includes.
6442         * compile/compile-cplus-symbols.c: Fix common/ includes.
6443         * command.h: Fix common/ includes.
6444         * cli/cli-dump.c: Fix common/ includes.
6445         * cli/cli-cmds.c: Fix common/ includes.
6446         * charset.c: Fix common/ includes.
6447         * build-id.c: Fix common/ includes.
6448         * btrace.h: Fix common/ includes.
6449         * btrace.c: Fix common/ includes.
6450         * breakpoint.h: Fix common/ includes.
6451         * breakpoint.c: Fix common/ includes.
6452         * ax.h:
6453         (enum agent_op): Fix common/ includes.
6454         * ax-general.c (struct aop_map): Fix common/ includes.
6455         * ax-gdb.c: Fix common/ includes.
6456         * auxv.c: Fix common/ includes.
6457         * auto-load.c: Fix common/ includes.
6458         * arm-tdep.c: Fix common/ includes.
6459         * arch/riscv.c: Fix common/ includes.
6460         * arch/ppc-linux-common.c: Fix common/ includes.
6461         * arch/i386.c: Fix common/ includes.
6462         * arch/arm.c: Fix common/ includes.
6463         * arch/arm-linux.c: Fix common/ includes.
6464         * arch/arm-get-next-pcs.c: Fix common/ includes.
6465         * arch/amd64.c: Fix common/ includes.
6466         * arch/aarch64.c: Fix common/ includes.
6467         * arch/aarch64-insn.c: Fix common/ includes.
6468         * arch-utils.c: Fix common/ includes.
6469         * amd64-windows-tdep.c: Fix common/ includes.
6470         * amd64-tdep.c: Fix common/ includes.
6471         * amd64-sol2-tdep.c: Fix common/ includes.
6472         * amd64-obsd-tdep.c: Fix common/ includes.
6473         * amd64-nbsd-tdep.c: Fix common/ includes.
6474         * amd64-linux-tdep.c: Fix common/ includes.
6475         * amd64-linux-nat.c: Fix common/ includes.
6476         * amd64-fbsd-tdep.c: Fix common/ includes.
6477         * amd64-fbsd-nat.c: Fix common/ includes.
6478         * amd64-dicos-tdep.c: Fix common/ includes.
6479         * amd64-darwin-tdep.c: Fix common/ includes.
6480         * agent.c: Fix common/ includes.
6481         * ada-lang.h: Fix common/ includes.
6482         * ada-lang.c: Fix common/ includes.
6483         * aarch64-tdep.c: Fix common/ includes.
6484
6485 2019-01-25  Tom Tromey  <tom@tromey.com>
6486
6487         * common/create-version.sh: Use common/version.h.
6488
6489 2019-01-24  Pedro Alves  <palves@redhat.com>
6490
6491         * infrun.c (signal_stop, signal_print, signal_program)
6492         (signal_catch, signal_pass): Now arrays instead of pointers.
6493         (update_signals_program_target, do_target_resume)
6494         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6495         * linux-nat.c (linux_nat_target::pass_signals)
6496         (linux_nat_target::create_inferior, linux_nat_target::attach):
6497         Adjust.
6498         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6499         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6500         * procfs.c (procfs_target::pass_signals): Adjust.
6501         * record-full.c (record_full_target::resume): Adjust.
6502         * remote.c (remote_target::pass_signals)
6503         (remote_target::program_signals): Adjust.
6504         * target-debug.h (target_debug_print_signals): Now takes a
6505         gdb::array_view as parameter.  Adjust.
6506         * target.h (target_ops) <pass_signals, program_signals>: Replace
6507         pointer and length parameters with gdb::array_view.
6508         (target_pass_signals, target_program_signals): Likewise.
6509         * target-delegates.c: Regenerate.
6510
6511 2019-01-24  Pedro Alves  <palves@redhat.com>
6512
6513         * common/forward-scope-exit.h
6514         (forward_scope_exit::forward_scope_exit): Pass arguments to
6515         m_bind_function directly, instead of creating a std::bind and
6516         copying that.
6517
6518 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6519
6520         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6521         for static members.
6522         (pass_in_v_vfp_candidate): Likewise.
6523
6524 2019-01-23  Tom Tromey  <tom@tromey.com>
6525             Pedro Alves  <palves@redhat.com>
6526
6527         * regcache.c (class regcache_invalidator): Remove.
6528         (regcache::raw_write): Use make_scope_exit.
6529
6530 2019-01-23  Tom Tromey  <tom@tromey.com>
6531
6532         * ui-out.h (class ui_out_emit_type): Update comment.
6533
6534 2019-01-23  Tom Tromey  <tom@tromey.com>
6535
6536         * infrun.c (fetch_inferior_event): Update comment.
6537
6538 2019-01-23  Tom Tromey  <tom@tromey.com>
6539             Pedro Alves  <palves@redhat.com>
6540
6541         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6542         parameter.
6543         (fetch_inferior_event): Use SCOPE_EXIT.
6544
6545
6546 2019-01-23  Tom Tromey  <tom@tromey.com>
6547             Pedro Alves  <palves@redhat.com>
6548
6549         * infrun.c (disable_thread_events): Delete.
6550         (stop_all_threads): Use SCOPE_EXIT.
6551
6552 2019-01-23  Tom Tromey  <tom@tromey.com>
6553             Pedro Alves  <palves@redhat.com>
6554
6555         * symfile.c: Include forward-scope-exit.h.
6556         (clear_symtab_users_cleanup): Replace forward declaration with
6557         a FORWARD_SCOPE_EXIT.
6558         (syms_from_objfile_1): Use the forward_scope_exit and
6559         gdb::optional instead of cleanup_function.
6560         (reread_symbols): Use the forward_scope_exit instead of
6561         cleanup_function.
6562         (clear_symtab_users_cleanup): Remove function.
6563
6564 2019-01-23  Tom Tromey  <tom@tromey.com>
6565             Pedro Alves  <palves@redhat.com>
6566
6567         * linux-nat.c: Include scope-exit.h.
6568         (cleanup_target_stop): Remove.
6569         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6570         SCOPE_EXIT.
6571
6572 2019-01-23  Tom Tromey  <tom@tromey.com>
6573             Pedro Alves  <palves@redhat.com>
6574
6575         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6576         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6577
6578 2019-01-23  Tom Tromey  <tom@tromey.com>
6579             Andrew Burgess  <andrew.burgess@embecosm.com>
6580             Pedro Alves  <palves@redhat.com>
6581
6582         * infrun.c (fetch_inferior_event): Use scope_exit.
6583         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6584         * top.c (execute_command): Use scope_exit.
6585         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6586         * utils.c (do_bpstat_clear_actions_cleanup)
6587         (make_bpstat_clear_actions_cleanup): Remove.
6588
6589 2019-01-23  Tom Tromey  <tom@tromey.com>
6590             Pedro Alves  <palves@redhat.com>
6591
6592         * infrun.c: Include "common/scope-exit.h"
6593         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6594         (wait_for_inferior): Use SCOPE_EXIT.
6595         (fetch_inferior_event): Use scope_exit.
6596
6597 2019-01-23  Tom Tromey  <tom@tromey.com>
6598             Pedro Alves  <palves@redhat.com>
6599
6600         * breakpoint.c (create_breakpoint): Remove cleanup.
6601
6602 2019-01-23  Tom Tromey  <tom@tromey.com>
6603             Andrew Burgess  <andrew.burgess@embecosm.com>
6604             Pedro Alves  <palves@redhat.com>
6605
6606 2019-01-23  Pedro Alves  <palves@redhat.com>
6607
6608         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6609
6610 2019-01-23  Pedro Alves  <palves@redhat.com>
6611             Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * gdbthread.h: Include "common/forward-scope-exit.h".
6614         (scoped_finish_thread_state): Redefine custom class in terms of
6615         forward_scope_exit.
6616
6617 2019-01-23  Pedro Alves  <palves@redhat.com>
6618             Andrew Burgess  <andrew.burgess@embecosm.com>
6619
6620         * common/forward-scope-exit.h: New file.
6621
6622 2019-01-23  Pedro Alves  <palves@redhat.com>
6623             Andrew Burgess  <andrew.burgess@embecosm.com>
6624             Tom Tromey  <tom@tromey.com>
6625
6626         * common/scope-exit.h: New file.
6627
6628 2019-01-23  Pedro Alves  <palves@redhat.com>
6629
6630         * common/preprocessor.h (ESC): Rename to ...
6631         (ESC_PARENS): ... this.
6632         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6633         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6634
6635 2019-01-23  Tom Tromey  <tom@tromey.com>
6636
6637         * language.h (class scoped_switch_to_sym_language_if_auto):
6638         Initialize m_lang in both cases.
6639
6640 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6643         with XCNEW.
6644
6645 2019-01-22  Tom Tromey  <tom@tromey.com>
6646
6647         * corelow.c: Do not include sys/file.h.
6648
6649 2019-01-22  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-wingeneral.h: Include gdb_curses.h.
6652
6653 2019-01-22  Tom Tromey  <tom@tromey.com>
6654
6655         * source-cache.h (class source_cache) <get_source_lines,
6656         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6657
6658 2019-01-22  Tom Tromey  <tom@tromey.com>
6659
6660         * remote-fileio.h (struct remote_target): Declare.
6661
6662 2019-01-22  Tom Tromey  <tom@tromey.com>
6663
6664         * python/py-arch.c: Do not include py-ref.h.
6665         * python/py-bpevent.c: Do not include py-ref.h.
6666         * python/py-cmd.c: Do not include py-ref.h.
6667         * python/py-continueevent.c: Do not include py-ref.h.
6668         * python/py-event.h: Do not include py-ref.h.
6669         * python/py-evtregistry.c: Do not include py-ref.h.
6670         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6671         * python/py-frame.c: Do not include py-ref.h.
6672         * python/py-framefilter.c: Do not include py-ref.h.
6673         * python/py-function.c: Do not include py-ref.h.
6674         * python/py-infevents.c: Do not include py-ref.h.
6675         * python/py-linetable.c: Do not include py-ref.h.
6676         * python/py-objfile.c: Do not include py-ref.h.
6677         * python/py-param.c: Do not include py-ref.h.
6678         * python/py-prettyprint.c: Do not include py-ref.h.
6679         * python/py-progspace.c: Do not include py-ref.h.
6680         * python/py-symbol.c: Do not include py-ref.h.
6681         * python/py-symtab.c: Do not include py-ref.h.
6682         * python/py-type.c: Do not include py-ref.h.
6683         * python/py-unwind.c: Do not include py-ref.h.
6684         * python/py-utils.c: Do not include py-ref.h.
6685         * python/py-value.c: Do not include py-ref.h.
6686         * python/py-varobj.c: Do not include py-ref.h.
6687         * python/py-xmethods.c: Do not include py-ref.h.
6688         * python/python.c: Do not include py-ref.h.
6689         * varobj.c: Do not include py-ref.h.
6690
6691 2019-01-22  Tom Tromey  <tom@tromey.com>
6692
6693         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6694         keyword for bcache.
6695
6696 2019-01-22  Tom Tromey  <tom@tromey.com>
6697
6698         * compile/compile-cplus-types.c: Remove a comment by #include.
6699
6700 2019-01-22  Tom Tromey  <tom@tromey.com>
6701
6702         * compile/gcc-c-plugin.h: Include compile-internal.h.
6703
6704 2019-01-22  Tom Tromey  <tom@tromey.com>
6705
6706         * stabsread.c (EXTERN): Do not define.
6707         (symnum, next_symbol_text_func, processing_gcc_compilation)
6708         (within_function, global_sym_chain, global_stabs)
6709         (previous_stab_code, this_object_header_files)
6710         (n_this_object_header_files)
6711         (n_allocated_this_object_header_files): Define.
6712         * stabsread.h (EXTERN): Never define.  Use "extern".
6713
6714 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6715
6716         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6717         history_value.
6718
6719 2019-01-21  Tom Tromey  <tom@tromey.com>
6720
6721         * ui-out.c: Fix includes.
6722         * tui/tui-source.c: Fix includes.
6723         * target.c: Fix includes.
6724         * remote.c: Fix includes.
6725         * regcache.c: Fix includes.
6726         * python/py-block.c: Fix includes.
6727         * printcmd.c: Fix includes.
6728         * or1k-tdep.c: Fix includes.
6729         * mi/mi-main.c: Fix includes.
6730         * m32r-tdep.c: Fix includes.
6731         * csky-tdep.c: Fix includes.
6732         * compile/compile-cplus-types.c: Fix includes.
6733         * cli/cli-interp.c: Fix includes.
6734
6735 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6736
6737         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6738         for padding.
6739
6740 2019-01-16  Tom Tromey  <tom@tromey.com>
6741
6742         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6743         earlier.
6744         (struct objfile) <msymbols_range>: Move from top level.
6745         <msymbols>: New method.
6746         (class objfile_msymbols): Remove.
6747         * symtab.c (default_collect_symbol_completion_matches_break_on):
6748         Update.
6749         * symmisc.c (dump_msymbols): Update.
6750         * stabsread.c (scan_file_globals): Update.
6751         * objc-lang.c (info_selectors_command, info_classes_command)
6752         (find_methods): Update.
6753         * minsyms.c (find_solib_trampoline_target): Update.
6754         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6755         * coffread.c (coff_symfile_read): Update.
6756         * ada-lang.c (ada_lookup_simple_minsym)
6757         (ada_collect_symbol_completion_matches): Update.
6758
6759 2019-01-16  Tom Tromey  <tom@tromey.com>
6760
6761         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6762         type.  Remove no-argument constructor.
6763         <iterator::operator++>: Simplify.
6764         <begin>: Update.
6765         <end>: Use minimal_symbol_count.
6766
6767 2019-01-16  Tom Tromey  <tom@tromey.com>
6768
6769         * objfiles.h (struct objfile) <psymtabs>: New method.
6770         (class objfile_psymtabs): Remove.
6771         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6772         typedef.
6773         <range>: New method.
6774         (require_partial_symbols): Change return type.
6775         * psymtab.c (require_partial_symbols)
6776         (psym_expand_symtabs_matching): Update.
6777         * mdebugread.c (parse_partial_symbols): Update.
6778         * dbxread.c (dbx_end_psymtab): Update.
6779
6780 2019-01-15  Tom Tromey  <tom@tromey.com>
6781
6782         * symtab.c (lookup_objfile_from_block)
6783         (lookup_symbol_in_objfile_symtabs)
6784         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6785         (find_line_symtab, info_sources_command)
6786         (default_collect_symbol_completion_matches_break_on)
6787         (make_source_files_completion_list): Update.
6788         * symmisc.c (print_objfile_statistics, dump_objfile)
6789         (maintenance_print_symbols, maintenance_info_symtabs)
6790         (maintenance_check_symtabs, maintenance_info_line_tables):
6791         Update.
6792         * source.c (select_source_symtab)
6793         (forget_cached_source_info_for_objfile): Update.
6794         * objfiles.h (class objfile_compunits): Remove.
6795         (struct objfile) <compunits_range>: New typedef.
6796         (compunits): New method.
6797         * objfiles.c (objfile_relocate1): Update.
6798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6799         * maint.c (count_symtabs_and_blocks): Update.
6800         * linespec.c (iterate_over_all_matching_symtabs): Update.
6801         * cp-support.c (add_symbol_overload_list_qualified): Update.
6802         * coffread.c (coff_symtab_read): Update.
6803         * ada-lang.c (add_nonlocal_symbols)
6804         (ada_collect_symbol_completion_matches)
6805         (ada_add_global_exceptions): Update.
6806
6807 2019-01-15  Tom Tromey  <tom@tromey.com>
6808
6809         * progspace.h (program_space) <objfiles_safe_range>: New
6810         typedef.
6811         <objfiles_safe>: New method.
6812         * objfiles.h (class all_objfiles_safe): Remove.
6813         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6814         * jit.c (jit_inferior_exit_hook): Update.
6815
6816 2019-01-17  Tom Tromey  <tom@tromey.com>
6817
6818         * progspace.h (program_space) <objfiles_range>: New typedef.
6819         <objfiles>: New method.
6820         <objfiles_head>: Rename from objfiles.
6821         (object_files): Update.
6822         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6823         * guile/scm-pretty-print.c
6824         (ppscm_find_pretty_printer_from_objfiles): Update.
6825         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6826         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6827         Update.
6828         * python/py-progspace.c (pspy_get_objfiles): Update.
6829         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6830         Update.
6831         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6832         (objfpy_lookup_objfile_by_build_id): Update.
6833         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6834         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6835         Update.
6836         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6837         (expand_symtab_containing_pc, lookup_objfile_from_block)
6838         (lookup_static_symbol, basic_lookup_transparent_type)
6839         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6840         (find_line_symtab, info_sources_command)
6841         (default_collect_symbol_completion_matches_break_on)
6842         (make_source_files_completion_list, find_main_name): Update.
6843         * symmisc.c (print_symbol_bcache_statistics)
6844         (print_objfile_statistics, maintenance_print_symbols)
6845         (maintenance_print_msymbols, maintenance_print_objfiles)
6846         (maintenance_info_symtabs, maintenance_check_symtabs)
6847         (maintenance_expand_symtabs, maintenance_info_line_tables):
6848         Update.
6849         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6850         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6851         (map_overlay_command, unmap_overlay_command)
6852         (simple_overlay_update, expand_symtabs_matching)
6853         (map_symbol_filenames): Update.
6854         * symfile-debug.c (set_debug_symfile): Update.
6855         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6856         Update.
6857         * source.c (select_source_symtab, forget_cached_source_info):
6858         Update.
6859         * solib.c (solib_read_symbols): Update.
6860         * solib-spu.c (append_ocl_sos): Update.
6861         * psymtab.c (maintenance_print_psymbols)
6862         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6863         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6864         * printcmd.c (info_symbol_command): Update.
6865         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6866         Update.
6867         * objfiles.h (class all_objfiles): Remove.
6868         * objfiles.c (have_partial_symbols, have_full_symbols)
6869         (have_minimal_symbols, qsort_cmp, update_section_map)
6870         (shared_objfile_contains_address_p)
6871         (default_iterate_over_objfiles_in_search_order): Update.
6872         * objc-lang.c (info_selectors_command, info_classes_command)
6873         (find_methods): Update.
6874         * minsyms.c (find_solib_trampoline_target): Update.
6875         * maint.c (maintenance_info_sections)
6876         (maintenance_translate_address, count_symtabs_and_blocks):
6877         Update.
6878         * main.c (captured_main_1): Update.
6879         * linux-thread-db.c (try_thread_db_load_from_pdir)
6880         (has_libpthread): Update.
6881         * linespec.c (iterate_over_all_matching_symtabs)
6882         (search_minsyms_for_name): Update.
6883         * jit.c (jit_find_objf_with_entry_addr): Update.
6884         * hppa-tdep.c (find_unwind_entry)
6885         (hppa_lookup_stub_minimal_symbol): Update.
6886         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6887         Update.
6888         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6889         (elf_gnu_ifunc_resolve_by_got): Update.
6890         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6891         * dwarf-index-write.c (save_gdb_index_command): Update.
6892         * cp-support.c (add_symbol_overload_list_qualified): Update.
6893         * breakpoint.c (create_overlay_event_breakpoint)
6894         (create_longjmp_master_breakpoint)
6895         (create_std_terminate_master_breakpoint)
6896         (create_exception_master_breakpoint): Update.
6897         * blockframe.c (find_pc_partial_function): Update.
6898         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6899         (ada_collect_symbol_completion_matches)
6900         (ada_add_global_exceptions): Update.
6901
6902 2019-01-17  Tom Tromey  <tom@tromey.com>
6903
6904         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6905         declare VEC.
6906         (solib_target_parse_libraries): Change return type.
6907         (library_list_start_segment, library_list_start_section)
6908         (library_list_end_library, library_list_start_library); Update.
6909         (solib_target_free_library_list): Remove.
6910         (solib_target_parse_libraries): Remove cleanup.  Change return
6911         type.
6912         (solib_target_current_sos): Update.
6913
6914 2019-01-17  Tom Tromey  <tromey@bapiya>
6915
6916         * valprint.c: Replace "the the" with "the".
6917         * symtab.c: Replace "the the" with "the".
6918         * solib.c: Replace "the the" with "the".
6919         * solib-dsbt.c: Replace "the the" with "the".
6920         * linespec.c: Replace "the the" with "the".
6921         * dwarf2loc.h: Replace "the the" with "the".
6922         * amd64-windows-tdep.c: Replace "the the" with "the".
6923         * aarch64-tdep.c: Replace "the the" with "the".
6924
6925 2019-01-16  Keith Seitz  <keiths@redhat.com>
6926
6927         PR gdb/23773
6928         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6929         <builder>: Rename to ..
6930         <m_builder>: ... this and make private.
6931         (dwarf2_cu::get_builder): New method.  Change all users of
6932         `builder' to use this method.
6933         (dwarf2_start_symtab): Move to ...
6934         (dwarf2_cu::start_symtab): ... here.  Update all callers
6935         (setup_type_unit_groups): Move to ...
6936         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6937         callers.
6938         (dwarf2_cu::reset_builder): New method.
6939         (process_full_compunit, process_full_type_unit): Use
6940         dwarf2_cu::reset_builder.
6941         (follow_die_offset): Record the ancestor CU if it is different
6942         from the followed DIE's CU.
6943         (follow_die_sig_1): Likewise.
6944
6945 2019-01-15  Tom Tromey  <tom@tromey.com>
6946
6947         * remote.c (class remote_state) <buf>: Now a char_vector.
6948         <buf_size>: Remove.
6949         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6950         parameter.
6951         (remote_target::getpkt_or_notif_sane_1)
6952         (remote_target::getpkt_sane)
6953         (remote_target::getpkt_or_notif_sane): Likewise.
6954         (class remote_target) <putpkt>: New overload.
6955         (remote_target::read_frame): Change type of "buf_p".  Remove
6956         sizeof_p parameter.
6957         (packet_ok): New overload.
6958         (packet_check_result): New overload.
6959         Update all uses.
6960
6961 2019-01-14  Tom Tromey  <tom@tromey.com>
6962
6963         * remote-notif.c (handle_notification, remote_notif_ack)
6964         (remote_notif_parse): Make "buf" const.
6965         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6966         const.
6967         (remote_notif_parse, remote_notif_ack, handle_notification):
6968         Likewise.
6969         * remote.c (remote_notif_stop_parse): Make "buf" const.
6970         (remote_target::remote_parse_stop_reply): Make "buf" const.
6971         (remote_notif_stop_ack): Make "buf" const.
6972
6973 2019-01-14  Tom Tromey  <tom@tromey.com>
6974
6975         * remote.c (remote_console_output): Make parameter const.
6976
6977 2019-01-14  Tom Tromey  <tom@tromey.com>
6978
6979         * target-debug.h (target_debug_print_signals): Constify.
6980         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6981         * procfs.c (procfs_target::pass_signals): Update.
6982         * linux-nat.c (linux_nat_target::pass_signals): Update.
6983         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6984         * target-delegates.c: Rebuild.
6985         * remote.c (remote_target::program_signals): Update.
6986         (remote_target::pass_signals): Update.
6987         * target.c (target_pass_signals): Constify argument.
6988         (target_program_signals): Likewise.
6989         * target.h (struct target_ops) <pass_signals, program_signals>:
6990         Constify argument.
6991         (target_pass_signals, target_program_signals): Constify argument.
6992
6993 2019-01-14  Tom Tromey  <tom@tromey.com>
6994
6995         PR tui/28819:
6996         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6997
6998 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6999
7000         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7001         field.
7002         * rs6000-tdep.c: Include reggroups.h.
7003         (IS_V_ALIAS_PSEUDOREG): Define.
7004         (rs6000_register_name): Return names for the "vX" aliases.
7005         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7006         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7007         aliases.  Call default_register_reggroup_p for all other
7008         pseudo-registers.
7009         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7010         New functions.
7011         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7012         Handle "vX" aliases.
7013         (v_alias_pseudo_register_collect): New function.
7014         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7015         (rs6000_gdbarch_init): Initialize "vX" aliases as
7016         pseudo-registers.  Restore registration of
7017         rs6000_pseudo_register_reggroup_p with
7018         set_tdesc_pseudo_register_reggroup_p.
7019
7020 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7021
7022         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7023         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7024         set_gdbarch_num_pseudo_regs.
7025
7026 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7027
7028         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7029         Remove arg prefixname, add do_set and do_show.
7030         Add member functions set_list and show_list.
7031         * cli/cli-style.c (class cli_style_option): Update accordingly.
7032         (style_set_list): Move to file scope.
7033         (style_show_list): Likewise.
7034         (set_style): Call help_list.
7035         (show_style): Call cmd_show_list.
7036         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7037         Update to use the new macro.
7038
7039 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7040
7041         * ada-lang.c (_initialize_ada_language): Expand the help text
7042         for the "catch exception" command.
7043
7044 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7045
7046         * symtab.c (matching_obj_sections): Initialize obj,
7047         declare it closer to its usage.
7048
7049 2019-01-10  Tom Tromey  <tom@tromey.com>
7050
7051         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7052         (basic_inf_threads_range): Remove.
7053         (inf_threads_range, inf_non_exited_threads_range)
7054         (safe_inf_threads_range): Use next_adapter.
7055
7056 2019-01-10  Keith Seitz  <keiths@redhat.com>
7057
7058         PR gdb/23712
7059         PR symtab/23010
7060         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7061         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7062
7063 2019-01-10  Keith Seitz  <keiths@redhat.com>
7064
7065         PR gdb/23712
7066         PR symtab/23010
7067         * dictionary.c (pending_to_vector): Remove.
7068         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7069         Remove _1 suffix, replacing functions of the same name.  Update
7070         all callers.
7071         (dict_create_hashed, dict_create_hashed_expandable)
7072         (dict_create_linear, dict_create_linear_expandable, dict_free)
7073         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7074         Make functions static.
7075
7076 2019-01-10  Keith Seitz  <keiths@redhat.com>
7077
7078         PR gdb/23712
7079         PR symtab/23010
7080         * dictionary.h (struct dictionary): Replace declaration with
7081         multidictionary.
7082         (dict_create_hashed, dict_create_hashed_expandable)
7083         (dict_create_linear, dict_create_linear_expandable)
7084         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7085         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7086         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7087         taking multidictionary argument.
7088         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7089         * block.h (struct block) <dict>: Change to multidictionary
7090         and rename `multidict'.
7091         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7092         symmisc.c: Update all dictionary references to multidictionary.
7093
7094 2019-01-10  Keith Seitz  <keiths@redhat.com>
7095
7096         PR gdb/23712
7097         PR symtab/23010
7098         * dictionary.c: Include unordered_map.
7099         (pending_to_vector): New function.
7100         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7101         Rewrite the non-"_1" functions to take vector instead
7102         of linked list.
7103         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7104         "new" _1 versions of the same name.
7105         (multidictionary): Define.
7106         (std::hash<enum language): New definition.
7107         (collate_pending_symbols_by_language, mdict_create_hashed)
7108         (mdict_create_hashed_expandable, mdict_create_linear)
7109         (mdict_create_linear_expandable, mdict_free)
7110         (find_language_dictionary, create_new_language_dictionary)
7111         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7112         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7113         (mdict_size, mdict_empty): New functions.
7114         * dictionary.h (mdict_iterator): Define.
7115
7116 2019-01-10  Pedro Alves  <palves@redhat.com>
7117
7118         * breakpoint.c (read_uploaded_action)
7119         (create_tracepoint_from_upload): Adjust to use
7120         gdb::unique_xmalloc_ptr.
7121         * ctf.c (ctf_write_uploaded_tp):
7122         (SET_ARRAY_FIELD): Use emplace_back.
7123         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7124         * tracefile-tfile.c (tfile_write_uploaded_tp):
7125         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7126         gdb::unique_xmalloc_ptr.
7127         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7128         at_string, cond_string, cmd_strings>: Replace char pointers
7129         with gdb::unique_xmalloc_ptr.
7130
7131 2019-01-10  Pedro Alves  <palves@redhat.com>
7132
7133         * solib-target.c (library_list_start_library): Don't xstrdup name.
7134
7135 2019-01-10  Pedro Alves  <palves@redhat.com>
7136
7137         * mdebugread.c (parse_partial_symbols): Use
7138         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7139
7140 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7141
7142         * linux-fork.c (scoped_switch_fork_info)
7143         <~scoped_switch_fork_info>: Fix incorrect variable name.
7144
7145 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * linux-fork.c (scoped_switch_fork_info)
7148         <scoped_switch_fork_info>: Make explicit.
7149         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7150
7151 2019-01-10  Tom Tromey  <tom@tromey.com>
7152
7153         * objfiles.h (objfile::reset_psymtabs): Update.
7154         * objfiles.c (objfile::objfile): Update.
7155         * psymtab.h (psymtab_storage::obstack): Update.
7156         (psymtab_storage::m_obstack): Use gdb::optional.
7157         (class psymtab_storage): Update comment.  Remove objfile
7158         parameter.
7159         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7160
7161 2019-01-10  Tom Tromey  <tom@tromey.com>
7162
7163         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7164         <free_psymtabs>: Now private.
7165         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7166         (allocate_psymtab): Use new method.
7167
7168 2019-01-10  Tom Tromey  <tom@tromey.com>
7169
7170         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7171         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7172         * mdebugread.c (parse_partial_symbols): Use
7173         allocate_dependencies.
7174         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7175         allocate_dependencies.
7176         (process_psymtab_comp_unit_reader)
7177         (build_type_psymtab_dependencies): Likewise.
7178         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7179
7180 2019-01-10  Tom Tromey  <tom@tromey.com>
7181
7182         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7183         PSYMBOL_SET_LANGUAGE.
7184         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7185
7186 2019-01-10  Tom Tromey  <tom@tromey.com>
7187
7188         * psymtab.h (psymtab_storage::obstack): New method.
7189         <m_obstack>: Rename from obstack; now private.
7190         * psymtab.c (psymtab_storage): Update.
7191         * dwarf2read.c (create_addrmap_from_index)
7192         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7193         Update.
7194
7195 2019-01-10  Tom Tromey  <tom@tromey.com>
7196
7197         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7198         * objfiles.h (objfile::reset_psymtabs): New method.
7199
7200 2019-01-10  Tom Tromey  <tom@tromey.com>
7201
7202         * symmisc.c (print_symbol_bcache_statistics): Update.
7203         (print_objfile_statistics): Update.
7204         * symfile.c (reread_symbols): Update.
7205         * psymtab.h (class psymtab_storage): New.
7206         * psymtab.c (psymtab_storage): New constructor.
7207         (~psymtab_storage): New destructor.
7208         (require_partial_symbols): Update.
7209         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7210         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7211         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7212         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7213         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7214         (start_psymtab_common, end_psymtab_common)
7215         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7216         (allocate_psymtab): Update.
7217         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7218         Update.
7219         (dump_psymtab_addrmap, maintenance_print_psymbols)
7220         (maintenance_check_psymtabs): Update.
7221         (class objfile_psymtabs): Move to objfiles.h.
7222         * psympriv.h (discard_psymtab): Now inline.
7223         (psymtab_discarder::psymtab_discarder): Update.
7224         (psymtab_discarder::~psymtab_discarder): Update.
7225         (ALL_OBJFILE_PSYMTABS): Rewrite.
7226         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7227         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7228         Remove fields.
7229         <partial_symtabs>: New field.
7230         (class objfile_psymtabs): Move from psymtab.h.  Update.
7231         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7232         psymbol_cache.
7233         (objfile::~objfile): Don't destroy psymbol_cache.
7234         * mdebugread.c (parse_partial_symbols): Update.
7235         * dwarf2read.c (create_addrmap_from_index)
7236         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7237         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7238         (add_partial_subprogram, dwarf2_ranges_read): Update.
7239         * dwarf-index-write.c (write_address_map)
7240         (write_one_signatured_type, recursively_write_psymbols)
7241         (class debug_names, class debug_names, write_psymtabs_to_index):
7242         Update.
7243
7244 2019-01-10  Tom Tromey  <tom@tromey.com>
7245
7246         * symtab.h (SYMBOL_SET_NAMES): Update.
7247         (symbol_set_names): Update.
7248         (MSYMBOL_SET_NAMES): Update.
7249         * symtab.c (symbol_set_names): Change argument to be an
7250         objfile_per_bfd_storage.
7251         * psymtab.c (add_psymbol_to_bcache): Update.
7252         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7253
7254 2019-01-10  Tom Tromey  <tom@tromey.com>
7255
7256         * symtab.c (create_demangled_names_hash): Change argument to be an
7257         objfile_per_bfd_storage.
7258         (symbol_set_names): Update.
7259
7260 2019-01-10  Tom Tromey  <tom@tromey.com>
7261
7262         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7263         init_psymbol_list.
7264         * psymtab.c (init_psymbol_list): Do nothing if already called.
7265         * psympriv.h (init_psymbol_list): Add comment.
7266         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7267         init_psymbol_list.
7268         * dbxread.c (dbx_symfile_read): Unconditionally call
7269         init_psymbol_list.
7270
7271 2019-01-10  Tom Tromey  <tom@tromey.com>
7272
7273         * xcoffread.c (scan_xcoff_symtab): Update.
7274         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7275         "where".
7276         * mdebugread.c (parse_partial_symbols)
7277         (handle_psymbol_enumerators): Update.
7278         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7279         * dbxread.c (read_dbx_symtab): Update.
7280         * psympriv.h (psymbol_placement): New enum.
7281         (add_psymbol_to_list): Update.
7282
7283 2019-01-10  Tom Tromey  <tom@tromey.com>
7284
7285         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7286         static_psymbols parameters.
7287         (scan_xcoff_symtab): Update.
7288         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7289         static_psymbols parameters.
7290         * psympriv.h (start_psymtab_common): Update.
7291         * mdebugread.c (parse_partial_symbols): Update.
7292         * dwarf2read.c (create_partial_symtab): Update.
7293         * dbxread.c (read_dbx_symtab): Update.
7294         (start_psymtab): Remove global_psymbols and static_psymbols
7295         parameters.
7296
7297 2019-01-10  Tom Tromey  <tom@tromey.com>
7298
7299         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7300         * psymtab.c (allocate_psymtab): Add comment.
7301         * psympriv.h (allocate_psymtab): Add comment.
7302         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7303         initializations.
7304         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7305
7306 2019-01-10  Tom Tromey  <tom@tromey.com>
7307
7308         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7309         Don't declare.
7310         * mipsread.c: Include mdebugread.h.
7311         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7312         Declare.
7313         * elfread.c: Include mdebugread.h.
7314
7315 2019-01-09  Tom Tromey  <tom@tromey.com>
7316
7317         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7318         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7319         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7320         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7321         (psym_lookup_symbol, psym_find_last_source_symtab)
7322         (psym_forget_cached_source_info, psym_print_stats)
7323         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7324         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7325         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7326         (psym_find_compunit_symtab_by_address)
7327         (maintenance_print_psymbols, maintenance_info_psymtabs)
7328         (maintenance_check_psymtabs): Use ranged for.
7329         * psymtab.h (class objfile_psymtabs): New.
7330         (require_partial_symbols): Return objfile_psymtabs.
7331         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7332
7333 2019-01-09  Tom Tromey  <tom@tromey.com>
7334
7335         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7336         (find_pc_mapped_section, list_overlays_command)
7337         (map_overlay_command, unmap_overlay_command)
7338         (simple_overlay_update): Use all_objfiles.
7339         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7340         * printcmd.c (info_symbol_command): Use all_objfiles.
7341         * objfiles.h (ALL_OBJSECTIONS): Remove.
7342         * maint.c (maintenance_translate_address): Use all_objfiles.
7343         * gcore.c (gcore_create_callback): Use all_objfiles.
7344         (objfile_find_memory_regions): Likewise.
7345
7346 2019-01-09  Tom Tromey  <tom@tromey.com>
7347
7348         * symtab.c (find_line_symtab, info_sources_command)
7349         (make_source_files_completion_list): Use objfile_compunits.
7350         * source.c (select_source_symtab): Use objfile_compunits.
7351         * objfiles.h (struct objfile): Update comment.
7352         (ALL_OBJFILES): Remove.
7353         (ALL_FILETABS): Remove.
7354         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7355         objfile_compunits.
7356
7357 2019-01-09  Tom Tromey  <tom@tromey.com>
7358
7359         * symmisc.c (print_objfile_statistics, dump_objfile)
7360         (maintenance_print_symbols): Use compunit_filetabs.
7361         * source.c (forget_cached_source_info_for_objfile): Use
7362         compunit_filetabs.
7363         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7364         (ALL_FILETABS): Use compunit_filetabs.
7365         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7366         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7367
7368 2019-01-09  Tom Tromey  <tom@tromey.com>
7369
7370         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7371         (compunit_filetabs): New.
7372         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7373         compunit_filetabs.
7374         (info_sources_command, make_source_files_completion_list): Remove
7375         declaration.
7376         * symmisc.c (print_objfile_statistics, dump_objfile)
7377         (maintenance_print_symbols): Remove declaration.
7378         (maintenance_info_symtabs): Use compunit_filetabs.
7379         (maintenance_info_line_tables): Likewise.
7380         * source.c (select_source_symtab): Change local variable name.
7381         (forget_cached_source_info_for_objfile): Remove declaration.
7382         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7383         * objfiles.c (objfile_relocate1): Remove declaration.
7384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7385         declaration.
7386         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7387         * coffread.c (coff_symtab_read): Remove declaration.
7388         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7389         compunit_filetabs.
7390
7391 2019-01-09  Tom Tromey  <tom@tromey.com>
7392
7393         * symtab.c (lookup_objfile_from_block)
7394         (find_pc_sect_compunit_symtab, search_symbols)
7395         (default_collect_symbol_completion_matches_break_on): Use
7396         objfile_compunits.
7397         * objfiles.h (ALL_COMPUNITS): Remove.
7398         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7399         * cp-support.c (add_symbol_overload_list_qualified): Use
7400         objfile_compunits.
7401         * ada-lang.c (ada_collect_symbol_completion_matches)
7402         (ada_add_global_exceptions): Use objfile_compunits.
7403
7404 2019-01-09  Tom Tromey  <tom@tromey.com>
7405
7406         * source.c (select_source_symtab)
7407         (forget_cached_source_info_for_objfile): Remove declaration.
7408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7409         declaration.
7410         * maint.c (count_symtabs_and_blocks): Remove declaration.
7411         * cp-support.c (add_symbol_overload_list_qualified): Remove
7412         declaration.
7413         * coffread.c (coff_symtab_read): Remove declaration.
7414         * symtab.c (lookup_symbol_in_objfile_symtabs)
7415         (basic_lookup_transparent_type_1): Use objfile_compunits.
7416         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7417         (info_sources_command, search_symbols)
7418         (default_collect_symbol_completion_matches_break_on)
7419         (make_source_files_completion_list): Remove declaration.
7420         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7421         (ada_collect_symbol_completion_matches)
7422         (ada_add_global_exceptions): Remove declaration.
7423         * linespec.c (iterate_over_all_matching_symtabs): Use
7424         objfile_compunits.
7425         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7426         (class objfile_compunits): New.
7427         (ALL_COMPUNITS): Use objfile_compunits.
7428         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7429         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7430         objfile_compunits.
7431         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7432
7433 2019-01-09  Tom Tromey  <tom@tromey.com>
7434
7435         * symtab.c (search_symbols)
7436         (default_collect_symbol_completion_matches_break_on): Use
7437         objfile_msymbols.
7438         * ada-lang.c (ada_lookup_simple_minsym)
7439         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7440         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7441         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7442         objfile_msymbols.
7443         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7444         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7445         * objc-lang.c (find_methods): Use objfile_msymbols.
7446         (info_selectors_command, info_classes_command): Likewise.
7447         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7448         * objfiles.h (class objfile_msymbols): New.
7449         (ALL_OBJFILE_MSYMBOLS): Remove.
7450         (ALL_MSYMBOLS): Remove.
7451
7452 2019-01-09  Tom Tromey  <tom@tromey.com>
7453
7454         * common/next-iterator.h (next_adapter): Add Iterator template
7455         parameter.
7456         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7457         (class all_objfiles_safe): New.
7458         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7459         * objfiles.c (put_objfile_before): Update comment.
7460         (add_separate_debug_objfile): Likewise.
7461         (free_all_objfiles): Use all_objfiles_safe.
7462         (objfile_purge_solibs): Likewise.
7463
7464 2019-01-09  Tom Tromey  <tom@tromey.com>
7465
7466         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7467         (expand_symtab_containing_pc, lookup_static_symbol)
7468         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7469         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7470         all_objfiles.
7471         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7472         * breakpoint.c (create_overlay_event_breakpoint)
7473         (create_longjmp_master_breakpoint)
7474         (create_std_terminate_master_breakpoint)
7475         (create_exception_master_breakpoint): Use all_objfiles.
7476         * linux-thread-db.c (try_thread_db_load_from_pdir)
7477         (has_libpthread): Use all_objfiles.
7478         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7479         * linespec.c (iterate_over_all_matching_symtabs)
7480         (search_minsyms_for_name): Use all_objfiles.
7481         * maint.c (maintenance_info_sections): Use all_objfiles.
7482         * main.c (captured_main_1): Use all_objfiles.
7483         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7484         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7485         * guile/scm-pretty-print.c
7486         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7487         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7488         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7489         (maintenance_print_msymbols): Use all_objfiles.
7490         * source.c (select_source_symtab): Use all_objfiles.
7491         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7492         * symfile.c (remove_symbol_file_command)
7493         (expand_symtabs_matching, map_symbol_filenames): Use
7494         all_objfiles.
7495         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7496         all_objfiles.
7497         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7498         * objc-lang.c (find_methods): Use all_objfiles.
7499         * objfiles.c (have_partial_symbols, have_full_symbols)
7500         (have_minimal_symbols, qsort_cmp)
7501         (default_iterate_over_objfiles_in_search_order): Use
7502         all_objfiles.
7503         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7504         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7505         (maintenance_check_psymtabs): Use all_objfiles.
7506         (ALL_PSYMTABS): Remove.
7507         * compile/compile-object-run.c (do_module_cleanup): Use
7508         all_objfiles.
7509         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7510         * cp-support.c (add_symbol_overload_list_qualified): Use
7511         all_objfiles.
7512         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7513         Use all_objfiles.
7514         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7515         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7516         all_objfiles.
7517         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7518         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7519         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7520         Uses all_objfiles.
7521         * solib.c (solib_read_symbols): Use all_objfiles
7522
7523 2019-01-09  Tom Tromey  <tom@tromey.com>
7524
7525         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7526         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7527         all_objfiles.
7528         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7529         * symmisc.c (print_symbol_bcache_statistics)
7530         (print_objfile_statistics, maintenance_print_objfiles)
7531         (maintenance_info_symtabs, maintenance_check_symtabs)
7532         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7533         all_objfiles.
7534         * source.c (forget_cached_source_info): Use all_objfiles.
7535         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7536         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7537         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7538         * objfiles.c (update_section_map): Use all_objfiles.
7539         (shared_objfile_contains_address_p): Likewise.
7540         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7541         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7542
7543 2019-01-09  Tom Tromey  <tom@tromey.com>
7544
7545         * common/next-iterator.h: New file.
7546         * objfiles.h (class all_objfiles): New.
7547         (struct objfile_iterator): New.
7548
7549 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7550
7551         * NEWS: Move the description of the changed "frame", "select-frame",
7552          and "info frame" commands to the Changed commands section.
7553
7554 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7555
7556         * gdbtypes.c (check_stub_method_group): Remove handling of old
7557         mangling schemes.
7558         * linespec.c (find_methods): Likewise.
7559         * stabsread.c (read_member_functions): Likewise.
7560         * valops.c (search_struct_method): Likewise.
7561         (value_struct_elt_for_reference): Likewise.
7562         * NEWS: Mention this change.
7563
7564 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7567         print_source_lines.
7568         * source.c (print_source_lines_base): Update line number check.
7569         (print_source_lines): New function.
7570         (source_lines_range::source_lines_range): New function.
7571         * source.h (class source_lines_range): New class.
7572         (print_source_lines): New declaration.
7573
7574 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7575
7576         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7577
7578 2019-01-08  Tom Tromey  <tom@tromey.com>
7579             Simon Marchi  <simon.marchi@ericsson.com>
7580
7581         PR gdb/24060
7582         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7583         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7584         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7585         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7586         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7587         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7588
7589 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7590
7591         * source.c (select_source_symtab): Move header comment to
7592         declaration in source.h.
7593         (forget_cached_source_info_for_objfile): Likewise.
7594         (forget_cached_source_info): Likewise.
7595         (identify_source_line): Likewise.
7596         * source.h (identify_source_line): Move declaration from symtab.h
7597         and add comment from source.c
7598         (print_source_lines): Likewise.
7599         (forget_cached_source_info_for_objfile): Likewise.
7600         (forget_cached_source_info): Likewise.
7601         (select_source_symtab): Likewise.
7602         (enum print_source_lines_flag): Move definition from symtab.h.
7603         * symtab.h (identify_source_line): Move declaration to source.h.
7604         (print_source_lines): Likewise.
7605         (forget_cached_source_info_for_objfile): Likewise.
7606         (forget_cached_source_info): Likewise.
7607         (select_source_symtab): Likewise.
7608         (enum print_source_lines_flag): Move definition to source.h.
7609         * tui/tui-hooks.c: Add 'source.h' include.
7610
7611 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * source.c (print_source_lines_base): Handle requests to print
7614         reverse line number sequences, and guard against empty lines
7615         string.
7616
7617 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * source.c (print_source_lines_base): Fix skip of '\r' if next
7620         character is '\n'.
7621
7622 2019-01-06  Tom Tromey  <tom@tromey.com>
7623
7624         * c-exp.y (struct c_parse_state) <macro_original_text,
7625         expansion_obstack>: New member.
7626         (macro_original_text, expansion_obstack): Remove globals.
7627         (scan_macro_expansion, scanning_macro_expansion)
7628         (finished_macro_expansion): Update.
7629         (scan_macro_cleanup): Remove.
7630         (yylex, c_parse): Update.
7631
7632 2019-01-06  Tom Tromey  <tom@tromey.com>
7633
7634         * c-exp.y (struct c_parse_state) <strings>: New member.
7635         (operator_stoken): Update.
7636
7637 2019-01-06  Tom Tromey  <tom@tromey.com>
7638
7639         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7640         (union type_stack_elt) <typelist_val>: Now a pointer to
7641         std::vector.
7642         (type_stack_cleanup): Don't declare.
7643         (push_typelist): Update.
7644         * parse.c (pop_typelist): Return a std::vector.
7645         (push_typelist): Take a std::vector.
7646         (follow_types): Update.  Do not free args.
7647         (type_stack_cleanup): Remove.
7648         * c-exp.y (struct c_parse_state): New.
7649         (cpstate): New global.
7650         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7651         (nonempty_typelist): Update.
7652         (func_mod): Create a new vector.
7653         (c_parse): Create a c_parse_state.
7654         (check_parameter_typelist): Do not delete params.
7655         (function_method): Update.  Do not delete type_list.
7656
7657 2019-01-06  Tom Tromey  <tom@tromey.com>
7658
7659         PR gdb/28155:
7660         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7661         check_typedef.
7662         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7663         (print_return_value): Likewise.
7664
7665 2019-01-05  Tom Tromey  <tom@tromey.com>
7666
7667         * contrib/cleanup_check.py: Remove.
7668         * contrib/gcc-with-excheck: Remove.
7669         * contrib/exsummary.py: Remove.
7670         * contrib/excheck.py: Remove.
7671
7672 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7673
7674         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7675         NULL. Initialize tpprev to NULL instead of assigning it
7676         to NULL on the next statement.
7677         * windows-nat.c (windows_delete_thread): Remove check for
7678         main_thread_id before printing thread exit notifications.
7679         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7680         Remove thread ID check against main_thread_id.
7681         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7682         windows_delete_thread.
7683         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7684
7685 2019-01-04  Tom Tromey  <tom@tromey.com>
7686
7687         * compile/compile.c (_initialize_compile): Use upper case for
7688         metasyntactic variables.
7689         * symmisc.c (_initialize_symmisc): Use upper case for
7690         metasyntactic variables.
7691         * psymtab.c (_initialize_psymtab): Use upper case for
7692         metasyntactic variables.
7693         * demangle.c (demangle_command): Use upper case for metasyntactic
7694         variables.
7695         (_initialize_demangler): Likewise.
7696         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7697         variables.
7698
7699 2019-01-03  Tom Tromey  <tom@tromey.com>
7700
7701         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7702
7703 2019-01-03  Tom Tromey  <tom@tromey.com>
7704
7705         * python/py-symtab.c (salpy_str): Update.
7706         (struct salpy_sal_object) <symtab>: Now a PyObject.
7707         (salpy_dealloc): Update.
7708         (del_objfile_sal): Use gdbpy_ref.
7709
7710 2019-01-03  Tom Tromey  <tom@tromey.com>
7711
7712         * python/py-type.c (convert_field): Use new_reference.  Return
7713         gdbpy_ref.
7714         (make_fielditem): Return gdbpy_ref.
7715         (typy_fields): Update.
7716         (typy_getitem): Update.
7717         (field_name): Return gdbpy_ref.  Use new_reference.
7718         (typy_iterator_iternext): Update.
7719
7720 2019-01-03  Tom Tromey  <tom@tromey.com>
7721
7722         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7723
7724 2019-01-03  Tom Tromey  <tom@tromey.com>
7725
7726         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7727         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7728         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7729         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7730         (pspy_set_type_printers): Likewise.
7731         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7732         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7733         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7734         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7735         (objfpy_set_type_printers): Likewise.
7736
7737 2019-01-03  Tom Tromey  <tom@tromey.com>
7738
7739         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7740         (gdbpy_print_stack): Use gdbpy_err_fetch.
7741         * python/python-internal.h (class gdbpy_err_fetch): New class.
7742         (class gdbpy_enter) <m_error_type, m_error_value,
7743         m_error_traceback>: Remove.
7744         <m_error>: New member.
7745         (gdbpy_exception_to_string): Don't declare.
7746         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7747         * python/py-value.c (convert_value_from_python): Use
7748         gdbpy_err_fetch.
7749         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7750         gdbpy_exception_to_string.
7751         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7752         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7753         gdbpy_err_fetch.
7754
7755 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * linux-nat.c (delete_lwp_cleanup): Delete.
7758         (struct lwp_deleter): New struct.
7759         (lwp_info_up): New typedef.
7760         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7761         lwp_info_up.
7762
7763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * linux-fork.c (class scoped_switch_fork_info): New class.
7766         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7767
7768 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * valops.c (find_overload_match): Remove use of null_cleanup, and
7771         calls to do_cleanups.
7772
7773 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * compile/compile-cplus-types.c
7776         (compile_cplus_instance::decl_name): Handle changes to
7777         cp_func_name.
7778         * cp-support.c (cp_func_name): Update header comment, update
7779         return type.
7780         * cp-support.h (cp_func_name): Update return type in declaration.
7781         * valops.c (find_overload_match): Move temp_func local to top
7782         level of function and change its type.  Use temp_func to hold and
7783         delete temporary string obtained from cp_func_name.
7784
7785 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7788         gdb::char_vector, remove cleanup, and update uses of `msg`.
7789
7790 2019-01-03  Jim Wilson  <jimw@sifive.com>
7791
7792         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7793
7794 2019-01-02  Tom Tromey  <tom@tromey.com>
7795
7796         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7797         (tdesc_parse_xml): Remove cleanups.
7798         * target-descriptions.h (make_cleanup_free_target_description):
7799         Don't declare.
7800         (target_desc_deleter): New struct.
7801         (target_desc_up): New typedef.
7802         * target-descriptions.c (target_desc_deleter::operator()): Rename
7803         from free_target_description.
7804         (make_cleanup_free_target_description): Remove.
7805
7806 2019-01-02  Tom Tromey  <tom@tromey.com>
7807
7808         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7809         constructor, destructor.
7810         (linespec_parser): Remove typedef.
7811         (~linespec_parser): Rename from linespec_parser_delete.
7812         (linespec_lex_to_end, linespec_complete_label)
7813         (linespec_complete): Update.
7814         (decode_line_full): Remove cleanups.
7815         (decode_line_1): Update.
7816
7817 2019-01-02  Tom Tromey  <tom@tromey.com>
7818
7819         * python/python-internal.h (inferior_to_inferior_object): Change
7820         return type.
7821         * python/py-exitedevent.c (create_exited_event_object): Update.
7822         * python/py-inferior.c (inferior_to_inferior_object): Return
7823         gdbpy_ref.
7824         (python_new_inferior, python_inferior_deleted)
7825         (thread_to_thread_object, delete_thread_object)
7826         (build_inferior_list, gdbpy_selected_inferior): Update.
7827         * python/py-infthread.c (create_thread_object): Update.  Also fail
7828         if inferior_to_inferior_object fails.
7829
7830 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7831
7832         * inferior.h (class inferior) <displaced_step_state>: New field.
7833         * infrun.h (struct displaced_step_state): Move here from
7834         infrun.c.  Initialize fields, add constructor.
7835         <inf>: Remove field.
7836         <reset>: New method.
7837         * infrun.c (struct displaced_step_inferior_state): Move to
7838         infrun.h.
7839         (displaced_step_inferior_states): Remove.
7840         (get_displaced_stepping_state): Adust.
7841         (displaced_step_in_progress_any_inferior): Adjust.
7842         (displaced_step_in_progress_thread): Adjust.
7843         (displaced_step_in_progress): Adjust.
7844         (add_displaced_stepping_state): Remove.
7845         (get_displaced_step_closure_by_addr): Adjust.
7846         (remove_displaced_stepping_state): Remove.
7847         (infrun_inferior_exit): Call displaced_step_state.reset.
7848         (use_displaced_stepping): Don't check for NULL.
7849         (displaced_step_prepare_throw): Call
7850         get_displaced_stepping_state.
7851         (displaced_step_fixup): Don't check for NULL.
7852         (prepare_for_detach): Don't check for NULL.
7853
7854 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7855
7856         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7857          in case of call that did not complete.
7858
7859 2019-01-02  Andrey Utkin  <autkin@undo.io>
7860
7861         * symfile.c (find_separate_debug_file): Fix search of debug files for
7862         remote debuggee.
7863
7864 2019-01-02  Tom Tromey  <tom@tromey.com>
7865
7866         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7867         indentation.
7868         * python/py-frame.c (frapy_older): Remove cast.
7869         (frapy_newer): Likewise.
7870         * python/py-breakpoint.c (local_setattro): Remove cast.
7871         * python/py-arch.c (archpy_name): Remove local variable.
7872         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7873
7874 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7875
7876         * unittests/basic_string_view/element_access/char/empty.cc:
7877         Fix year range in copyright header.
7878
7879 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7882         Delete.
7883         <operator==>: Update with for removed field.
7884         <hash>: Likewise.
7885         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7886         <isa_features>: ...this.
7887         <abi_features>: New field.
7888         (riscv_isa_flen): Update comment.
7889         (riscv_abi_xlen): New declaration.
7890         (riscv_abi_flen): New declaration.
7891         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7892         isa_features.
7893         (riscv_abi_xlen): New function.
7894         (riscv_isa_flen): Update to get answer from isa_features.
7895         (riscv_abi_flen): New function.
7896         (riscv_has_fp_abi): Update to get answer from abi_features.
7897         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7898         xlen and flen.
7899         (riscv_call_info) <xlen, flen>: Update comment.
7900         (riscv_call_arg_struct): Remove invalid assertions
7901         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7902         is removed.
7903         (riscv_gdbarch_init): Gather isa features and abi features
7904         separately, ensure both match on the gdbarch when reusing an old
7905         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7906         a target with 64-bit float hardware.
7907
7908 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7909
7910         * source.c (search_command_helper): Stop reverse search
7911         when line 1 has been searched.
7912
7913 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7914
7915         * record-full.c (record_full_base_target::close): Rewrite
7916         record_full_core_buf_list free logic.
7917
7918 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7919
7920         * break-catch-syscall.c (print_one_catch_syscall): xfree
7921         the last text.
7922
7923 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7924
7925         * top.c (print_gdb_version): Update Copyright year in version
7926         message.
7927
7928 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7929
7930         Update copyright year range in all GDB files.
7931
7932 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7933
7934         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7935
7936 For older changes see ChangeLog-2018.
7937 \f
7938 Local Variables:
7939 mode: change-log
7940 left-margin: 8
7941 fill-column: 74
7942 version-control: never
7943 coding: utf-8
7944 End:
7945