gdb/ChangeLog

   1 2019-10-16  Tom de Vries  <tdevries@suse.de>
   2
   3         PR tdep/24104
   4         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
   5         that handles 'theclass'.
   6
   7 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         * linespec.c (decode_digits_ordinary): Update comment.
  10         * make-target-delegates: No longer need to handle VEC case.
  11         * memrange.c (normalize_mem_ranges): Update comment.
  12         * namespace.c (add_using_directive): Update comment.
  13         * objc-lang.c (uniquify_strings): Update comment.
  14         * ppc-linux-nat.c (struct thread_points): Update comment.
  15         * probe.h (find_probes_in_objfile): Update comment.
  16         * target.h (enum flash_preserve_mode): Update comment.
  17         * varobj.c (varobj_restrict_range): Update comment.
  18         * varobj.h (varobj_list_children): Update comment.
  19
  20 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  21
  22         * Makefile.in: Remove references to vec.h and vec.c.
  23         * aarch64-tdep.c: No longer include vec.h.
  24         * ada-lang.c: Likewise.
  25         * ada-lang.h: Likewise.
  26         * arm-tdep.c: Likewise.
  27         * ax.h: Likewise.
  28         * breakpoint.h: Likewise.
  29         * charset.c: Likewise.
  30         * cp-support.h: Likewise.
  31         * dtrace-probe.c: Likewise.
  32         * dwarf2read.c: Likewise.
  33         * extension.h: Likewise.
  34         * gdb_bfd.c: Likewise.
  35         * gdbsupport/gdb_vecs.h: Likewise.
  36         * gdbsupport/vec.c: Remove.
  37         * gdbsupport/vec.h: Remove.
  38         * gdbthread.h: Likewise.
  39         * guile/scm-type.c: Likewise.
  40         * inline-frame.c: Likewise.
  41         * machoread.c: Likewise.
  42         * memattr.c: Likewise.
  43         * memrange.h: Likewise.
  44         * namespace.h: Likewise.
  45         * nat/linux-btrace.h: Likewise.
  46         * osdata.c: Likewise.
  47         * parser-defs.h: Likewise.
  48         * progspace.h: Likewise.
  49         * python/py-type.c: Likewise.
  50         * record-btrace.c: Likewise.
  51         * rust-exp.y: Likewise.
  52         * solib-target.c: Likewise.
  53         * stap-probe.c: Likewise.
  54         * target-descriptions.c: Likewise.
  55         * target-memory.c: Likewise.
  56         * target.h: Likewise.
  57         * varobj.c: Likewise.
  58         * varobj.h: Likewise.
  59         * xml-support.h: Likewise.
  60
  61 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
  64         Update for new std::vector based implementation.
  65         (process_psymtab_comp_unit_reader): Likewise.
  66         (scan_partial_symbols): Likewise.
  67         (recursively_compute_inclusions): Likewise.
  68         (compute_compunit_symtab_includes): Likewise.
  69         (process_imported_unit_die): Likewise.
  70         (queue_and_load_dwo_tu): Likewise.
  71         (follow_die_sig_1): Likewise.
  72         * gdb/dwarf2read.h: Remove DEF_VEC_P.
  73         (typedef dwarf2_per_cu_ptr): Remove.
  74         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
  75         function.
  76         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
  77         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
  78         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
  79         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
  80         std::vector.
  81
  82 2019-10-15  Tom Tromey  <tromey@adacore.com>
  83
  84         * windows-nat.c (windows_nat_target::resume): Use %x when logging
  85         TID.
  86
  87 2019-10-15  Tom Tromey  <tromey@adacore.com>
  88
  89         * windows-nat.c (windows_nat_target::fetch_registers)
  90         (windows_nat_target::store_registers): Rename "pid" to "tid".
  91
  92 2019-10-15  Tom Tromey  <tromey@adacore.com>
  93
  94         * gdbarch.h, gdbarch.c: Rebuild.
  95         * gdbarch.sh (gcc_target_options): Change return type to
  96         std::string.
  97         * compile/compile.c (get_args): Update.
  98         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
  99         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 100         std::string.
 101         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 102         std::string.
 103         * arch-utils.c (default_gcc_target_options): Return std::string.
 104         * arch-utils.h (default_gcc_target_options): Return std::string.
 105         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 106
 107 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 108
 109         * breakpoint.c (breakpoint_chain): Make static.
 110         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 111         of accessing breakpoint_chain.
 112
 113 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 114
 115         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 116         to a gdb::function_view and return value to bool.
 117         * breakpoint.h (iterate_over_breakpoints): Likewise.
 118         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 119         (pop_dummy_frame): Update.
 120         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 121         (gdbscm_breakpoints): Update.
 122         * python/py-breakpoint.c (build_bp_list): Update.
 123         (gdbpy_breakpoints): Update.
 124         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 125         Update.
 126         (bpfinishpy_handle_stop): Update.
 127         (bpfinishpy_handle_exit): Update.
 128         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 129         (svr4_update_solib_event_breakpoints): Update.
 130
 131 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 132
 133         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 134         when unwrapping single-field structs.
 135
 136 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 137
 138         * dwarf2read.c: Remove includes.
 139
 140 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 141
 142         * ui-out.c (ui_out::call_do_message): Silence
 143         -Wformat-nonliteral warning.
 144
 145 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 146
 147         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 148         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 149         include: readline/tilde.h.
 150
 151 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 152
 153         * remote.c (remote_target::get_trace_status): Remove declaration of
 154         trace_regblock_size.
 155
 156 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 157
 158         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 159         (show_user): Remove declaration of cmdlist.
 160         * cli/cli-cmds.h (max_user_call_depth): Declare.
 161         * cli/cli-script.c (execute_user_command): Remove declaration
 162         of max_user_call_depth.
 163
 164 2019-10-11  Jim Wilson  <jimw@sifive.com>
 165
 166         * gdbsupport/print-utils.h (pulongest): Fix comment.
 167         (plongest): Likewise.
 168         (phex): Add missing comment, mention leading zeros.
 169         (phex_nz): Add mention of no leading zeros to comment.
 170
 171         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 172         plongest instead of unsigned long long cast.
 173
 174 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 175
 176         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 177         for external_editor_command and gdbtk_test.
 178
 179 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 180
 181         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 182         * varobj.c (varobjdebug): Move comment to...
 183         * varobj.h (varobjdebug): ...here, and declare.
 184
 185 2019-10-09  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 188         erase_data_content.
 189
 190 2019-10-09  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 193         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 194         * tui/tui-command.c (tui_cmd_window::resize)
 195         (tui_refresh_cmd_win): Update.
 196         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 197         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 198         * tui/tui-data.c (~tui_gen_win_info): Remove.
 199         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 200         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 201         (tui_redisplay_readline, tui_mld_flush)
 202         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 203         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 204         (tui_data_window::erase_data_content)
 205         (tui_data_item_window::rerender)
 206         (tui_data_item_window::refresh_window): Update.
 207         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 208         (box_win, tui_gen_win_info::make_window)
 209         (tui_gen_win_info::make_visible): Update.
 210         (tui_delete_win): Remove.
 211         * tui/tui-winsource.c
 212         (tui_source_window_base::do_erase_source_content): Update.
 213         (tui_show_source_line, tui_source_window_base::update_tab_width)
 214         (tui_source_window_base::update_exec_info): Update.
 215         * tui/tui-data.h (struct curses_deleter): New.
 216         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 217         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 218
 219 2019-10-09  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 222
 223 2019-10-09  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 226         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 227
 228 2019-10-09  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 231         window height directly.
 232         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 233         declare.
 234         * tui/tui-layout.c (tui_default_win_height): Remove.
 235         (tui_default_win_viewport_height): Remove.
 236
 237 2019-10-09  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui.h: Remove comments.
 240
 241 2019-10-09  Tom de Vries  <tdevries@suse.de>
 242
 243         * python/lib/gdb/printer/bound_registers.py: Use
 244         '^builtin_type_bound128' as regexp argument for
 245         add_builtin_pretty_printer.
 246
 247 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 248
 249         * guile/guile.c (guile_extension_script_ops): Remove forward
 250         declaration and mark as static.
 251         (guile_script_ops): Likewise.
 252         (extension_language_guile): Move further down in the file so
 253         it can reference the definitions for guile_{extension_,}script_ops.
 254
 255 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 256
 257         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 258         except SORTL, DFLTCC, and KDSA.
 259
 260 2019-10-08  Tom Tromey  <tromey@adacore.com>
 261
 262         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 263         (struct safe_symbol_file_add_args): Remove.
 264
 265 2019-10-08  Tom Tromey  <tromey@adacore.com>
 266
 267         * windows-nat.c: Don't include buildsym-legacy.h.
 268
 269 2019-10-08  Tom Tromey  <tromey@adacore.com>
 270
 271         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 272
 273 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * gdbtypes.c (overload_debug): Move comment to header.
 276         * gdbtypes.h (overload_debug): Declare.
 277         * valops.c: Remove declaration of overload_debug, instead
 278         include gdbtypes.h.
 279
 280 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 283         through _().
 284         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 285         move comment...
 286         * language.h (lang_frame_mismatch_warn): ... here. Also add
 287         declaration.
 288         * top.c (lang_frame_mismatch_warn): Remove declaration.
 289         (check_frame_language_change): Pass lang_frame_mismatch_warn
 290         through _().
 291
 292 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 293
 294         * c-lang.h (vtbl_ptr_name): Declare.
 295         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 296         it from the header.
 297         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 298
 299 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 302         gdb_static_assert.
 303
 304 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 305
 306         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 307         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 308         * ctfread.c: New file.
 309         * ctfread.h: New file.
 310         * elfread.c: Include ctfread.h.
 311         (struct elfinfo text_p): New member ctfsect.
 312         (elf_locate_sections): Mark CTF section.
 313         (elf_symfile_read): Call elfctf_build_psymtabs.
 314         * Makefile.in (LIBCTF): Add.
 315         (CLIBS): Use it.
 316         (CDEPS): Likewise.
 317         (DIST): Add ctfread.c.
 318
 319 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 320
 321         * ctfread.c (struct nextfield): Renamed to ...
 322         (struct ctf_nextfield): ... this.
 323         (struct field_info): Renamed to ...
 324         (strut ctf_field_info): ... this.
 325         (attach_fields_to_type): Update for renamed structures.
 326         (ctf_add_member_cb): Likewise.
 327         (ctf_add_enum_member_cb): Likewise.
 328         (process_struct_members): Likewise.
 329         (process_enum_type): Likewise.
 330
 331 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 332
 333         * tracectf.h: Rename, was ctf.h.
 334         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 335         * tracefile.c: Likewise.
 336         * tracepoint.c: Remove unused include ctf.h.
 337         * mi/mi-main.c: Likewise.
 338         * Makefile.in Replace ctf.c with tracectf.c.
 339
 340 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 341
 342         * version.in: Change version number to "9.0.50.DATE-git".
 343
 344 2019-10-03  Tom Tromey  <tom@tromey.com>
 345
 346         PR rust/24976:
 347         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 348
 349 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 352         cp_search_name_hash.
 353         * NEWS: Add entry about nested function support.
 354
 355 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 356             Andrew Burgess  <andrew.burgess@embecosm.com>
 357
 358         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 359         for nested static variables when searchin VAR_DOMAIN.
 360         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 361         global scope, update comment.
 362         (add_partial_subprogram): Call add_partial_subprogram recursively
 363         for nested subroutines when processinng Fortran.
 364         (load_partial_dies): Process the child entities of a subprogram
 365         when processing Fortran.
 366         (partial_die_parent_scope): Handle building scope
 367         for Fortran nested functions.
 368         (process_die): Record that nested functions have a scope.
 369         (new_symbol): Always record Fortran subprograms on the global
 370         symbol list.
 371         (determine_prefix): How to build the prefix for Fortran
 372         subprograms.
 373
 374 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 377         have just sent the thread a SIGSTOP and are waiting for it to
 378         arrive.
 379
 380 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * btrace.c (btrace_add_pc): Remove whitespace before the template
 383         parameter in 'std::vector <...>'.
 384         (parse_xml_btrace_block): Likewise.
 385         (btrace_maint_decode_pt): Likewise.
 386         (btrace_maint_update_packets): Likewise.
 387         (btrace_maint_print_packets): Likewise.
 388         * btrace.h (struct btrace_maint_info): Likewise.
 389         * dwarf2read.c (struct type_unit_group): Likewise.
 390         (build_type_psymtabs_reader): Likewise.
 391         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 392         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 393         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 394
 395 2019-10-03  Tom de Vries  <tdevries@suse.de>
 396
 397         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 398         the first line of the help text for set/show style metadata.
 399
 400 2019-10-02  Tom Tromey  <tromey@adacore.com>
 401
 402         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 403         * gdbsupport/common-inferior.c: New file.
 404         * infcmd.c (startup_with_shell): Don't define.
 405         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 406         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 407         * inferior.h (startup_with_shell): Don't declare.
 408
 409 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 410
 411         * gdbsupport/gdb_assert.h: Include errors.h.
 412         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 413
 414 2019-10-02  Tom Tromey  <tromey@adacore.com>
 415
 416         * NEWS: Add $_ada_exception entry.
 417         * ada-lang.c (struct ada_catchpoint): Add constructor.
 418         <m_kind>: New member.
 419         (allocate_location_exception, re_set_exception): Remove
 420         "ex" parameter.
 421         (should_stop_exception): Compute $_ada_exception.
 422         (check_status_exception, print_it_exception)
 423         (print_one_exception, print_mention_exception): Remove
 424         "ex" parameter.
 425         (allocate_location_catch_exception, re_set_catch_exception)
 426         (check_status_exception, print_it_catch_exception)
 427         (print_one_catch_exception, print_mention_catch_exception)
 428         (print_recreate_catch_exception)
 429         (allocate_location_catch_exception_unhandled)
 430         (re_set_catch_exception_unhandled)
 431         (check_status_exception, print_it_catch_exception_unhandled)
 432         (print_one_catch_exception_unhandled)
 433         (print_mention_catch_exception_unhandled)
 434         (print_recreate_catch_exception_unhandled)
 435         (allocate_location_catch_assert, re_set_catch_assert)
 436         (check_status_assert, print_it_catch_assert)
 437         (print_one_catch_assert, print_mention_catch_assert)
 438         (print_recreate_catch_assert)
 439         (allocate_location_catch_handlers, re_set_catch_handlers)
 440         (check_status_handlers, print_it_catch_handlers)
 441         (print_one_catch_handlers, print_mention_catch_handlers)
 442         (print_recreate_catch_handlers): Remove.
 443         (create_ada_exception_catchpoint): Update.
 444         (initialize_ada_catchpoint_ops): Update.
 445
 446 2019-10-02  Tom Tromey  <tromey@adacore.com>
 447
 448         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 449         (create_excep_cond_exprs): Simplify exception string computation.
 450         (ada_exception_catchpoint_cond_string): Likewise.
 451
 452 2019-10-02  Tom Tromey  <tromey@adacore.com>
 453
 454         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 455         * ada-lang.c (lesseq_defined_than): Handle
 456         LOC_STATIC.
 457         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 458         parameter.
 459         (dwarf2_has_info): Likewise.
 460         (new_symbol): Set maybe_copied on symbol when
 461         appropriate.
 462         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 463         parameter.
 464         <can_copy>: New member.
 465         * elfread.c (record_minimal_symbol): Set maybe_copied
 466         on symbol when appropriate.
 467         (elf_symfile_read): Update call to dwarf2_has_info.
 468         * minsyms.c (lookup_minimal_symbol_linkage): New
 469         function.
 470         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 471         * symtab.c (get_symbol_address, get_msymbol_address):
 472         New functions.
 473         * symtab.h (get_symbol_address, get_msymbol_address):
 474         Declare.
 475         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 476         maybe_copied.
 477         (struct symbol, struct minimal_symbol) <maybe_copied>:
 478         New member.
 479
 480 2019-10-02  Tom Tromey  <tromey@adacore.com>
 481
 482         * source.c (struct current_source_location): New.
 483         (current_source_key): New global.
 484         (current_source_symtab, current_source_line)
 485         (current_source_pspace): Remove.
 486         (get_source_location): New function.
 487         (get_current_source_symtab_and_line)
 488         (set_default_source_symtab_and_line)
 489         (set_current_source_symtab_and_line)
 490         (clear_current_source_symtab_and_line, select_source_symtab)
 491         (info_source_command, print_source_lines_base)
 492         (info_line_command, search_command_helper, _initialize_source):
 493         Update.
 494
 495 2019-10-02  Tom Tromey  <tromey@adacore.com>
 496
 497         * source.c (select_source_symtab): Don't call
 498         decode_line_with_current_source.
 499
 500 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * symtab.c (lookup_global_symbol): Search global block.
 503
 504 2019-10-02  Tom Tromey  <tromey@adacore.com>
 505
 506         * coffread.c (process_coff_symbol): Update.
 507         * dwarf2read.c (var_decode_location, new_symbol): Update.
 508         * mdebugread.c (parse_symbol): Update.
 509         * objfiles.c (relocate_one_symbol): Update.
 510         * stabsread.c (define_symbol, fix_common_block)
 511         (scan_file_globals): Update.
 512         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 513         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 514         * xcoffread.c (process_xcoff_symbol): Update.
 515
 516 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 517
 518         * MAINTAINERS: Update my email address.
 519
 520 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 523         std::vector.
 524         (build_type_psymtabs_reader): Update for std::vector.
 525         (build_type_psymtab_dependencies): Likewise.
 526         * dwarf2read.h: Remove use of DEF_VEC_P.
 527         (typedef sig_type_ptr): Delete.
 528
 529 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 532         to std::vector.
 533         (btrace_maint_decode_pt): Likewise, and move allocation of the
 534         vector outside of the loop.
 535         (btrace_maint_update_packets): Update to handle change from VEC to
 536         std::vector.
 537         (btrace_maint_print_packets): Likewise.
 538         (maint_info_btrace_cmd): Likewise.
 539         * btrace.h: Remove use of DEF_VEC_O.
 540         (typedef btrace_pt_packet_s): Delete.
 541         (struct btrace_maint_info) <packets>: Change fromm VEC to
 542         std::vector.
 543         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 544
 545 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 548         make accesses into the vector constant references.
 549         (btrace_add_pc): Update for std::vector.
 550         (btrace_stitch_bts): Likewise.
 551         (parse_xml_btrace_block): Likewise.
 552         (btrace_maint_update_packets): Likewise.
 553         (btrace_maint_print_packets): Likewise.
 554         (maint_info_btrace_cmd): Likewise.
 555         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 556         std::vector.
 557         (btrace_data::empty): Likewise.
 558         (btrace_data_append): Likewise.
 559         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 560         (typedef btrace_block_s): Delete.
 561         (struct btrace_block): Add constructor.
 562         (struct btrace_data_bts) <blocks>: Change to std::vector.
 563         * nat/linux-btrace.c (perf_event_read_bts): Update for
 564         std::vector.
 565         (linux_read_bts): Likewise.
 566
 567 2019-10-01  Tom Tromey  <tom@tromey.com>
 568
 569         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 570
 571 2019-10-01  Tom Tromey  <tom@tromey.com>
 572
 573         * stack.c (print_frame, info_frame_command_core): Use
 574         styled_string.
 575         * linux-thread-db.c (try_thread_db_load_1)
 576         (try_thread_db_load_from_pdir_1): Use styled_string.
 577         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 578         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 579         (maybe_print_unsupported_script_warning)
 580         (maybe_print_script_not_found_warning): Use styled_string.
 581         * ada-lang.c (user_select_syms): Use styled_string.
 582
 583 2019-10-01  Tom Tromey  <tom@tromey.com>
 584
 585         * p-lang.c (pascal_printstr): Use metadata style.
 586         * value.c (show_convenience): Use metadata style.
 587         * valprint.c (valprint_check_validity, val_print_optimized_out)
 588         (val_print_not_saved, val_print_unavailable)
 589         (val_print_invalid_address, generic_val_print, val_print)
 590         (value_check_printable, val_print_array_elements): Use metadata
 591         style.
 592         * ui-out.h (class ui_out) <field_fmt>: New overload.
 593         <do_field_fmt>: Add style parameter.
 594         * ui-out.c (ui_out::field_fmt): New overload.
 595         * typeprint.c (type_print_unknown_return_type)
 596         (val_print_not_allocated, val_print_not_associated): Use metadata
 597         style.
 598         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 599         parameter.
 600         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 601         * tracepoint.c (tvariables_info_1): Use metadata style.
 602         * stack.c (print_frame_arg, print_frame_info, print_frame)
 603         (info_frame_command_core): Use metadata style.
 604         * skip.c (info_skip_command): Use metadata style.
 605         * rust-lang.c (rust_print_enum): Use metadata style.
 606         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 607         metadata style.
 608         * python/py-framefilter.c (py_print_single_arg): Use metadata
 609         style.
 610         * printcmd.c (do_one_display, print_variable_and_value): Use
 611         metadata style.
 612         * p-valprint.c (pascal_val_print)
 613         (pascal_object_print_value_fields): Use metadata style.
 614         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 615         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 616         parameter.
 617         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 618         * m2-valprint.c (m2_print_long_set): Use metadata style.
 619         * m2-typeprint.c (m2_print_type): Use metadata style.
 620         * infcmd.c (print_return_value_1): Use metadata style.
 621         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 622         * f-valprint.c (info_common_command_for_block): Use metadata
 623         style.
 624         * f-typeprint.c (f_type_print_base): Use metadata style.
 625         * expprint.c (print_subexp_standard): Use metadata style.
 626         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 627         * cli/cli-style.h (class cli_style_option): Add constructor.
 628         (metadata_style): Declare.
 629         * cli/cli-style.c (metadata_style): New global.
 630         (_initialize_cli_style): Register metadata style.
 631         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 632         parameter.
 633         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 634         * c-typeprint.c (c_type_print_base_struct_union)
 635         (c_type_print_base_1): Use metadata style.
 636         * breakpoint.c (watchpoint_value_print)
 637         (print_one_breakpoint_location): Use metadata style.
 638         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 639         style.
 640         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 641         style.
 642         * ada-valprint.c (val_print_packed_array_elements, printstr)
 643         (print_field_values, ada_val_print_ref, ada_val_print): Use
 644         metadata style.
 645         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 646         style.
 647         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 648         style.
 649         * ada-lang.c (user_select_syms): Use metadata style.
 650
 651 2019-10-01  Tom Tromey  <tom@tromey.com>
 652
 653         * cli/cli-cmds.c (pwd_command): Style output.
 654
 655 2019-10-01  Pedro Alves  <palves@redhat.com>
 656             Tom Tromey  <tom@tromey.com>
 657
 658         * symtab.c (print_symbol_info): Use %ps.
 659         (print_msymbol_info): Use %ps.
 660         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 661         * printcmd.c (print_variable_and_value): Use %ps.
 662         * macrocmd.c (show_pp_source_pos): Use %ps.
 663         * infrun.c (print_exited_reason): Use ui_out::message.
 664         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 665         (describe_other_breakpoints): Use ui_out::message and new
 666         formats.
 667         (say_where): Use new formats.
 668         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 669         and new formats.
 670
 671 2019-10-01  Pedro Alves  <palves@redhat.com>
 672             Tom Tromey  <tom@tromey.com>
 673
 674         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 675         (test_gdb_formats): New function.
 676         (run_tests): Call it.
 677         (test_format_specifier): Update.
 678         * utils.h (fputs_filtered): Update comment.
 679         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 680         (fputs_styled_unfiltered): Declare.
 681         * utils.c (fputs_styled_unfiltered): New function.
 682         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 683         (vfprintf_filtered): Update.
 684         (vfprintf_unfiltered, vprintf_filtered): Update.
 685         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 686         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 687         disallow_ui_out_field>: New constants.
 688         (enum class field_kind): New.
 689         (struct base_field_s, struct signed_field_s): New.
 690         (signed_field): New function.
 691         (struct string_field_s): New.
 692         (string_field): New function.
 693         (struct styled_string_s): New.
 694         (styled_string): New function.
 695         (class ui_out) <message>: Add comment.
 696         <vmessage, call_do_message>: New methods.
 697         <do_message>: Add style parameter.
 698         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 699         methods.
 700         (ui_out::message): Rewrite.
 701         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 702         parameter.
 703         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 704         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 705         gdb_extensions parameter.
 706         (class format_piece): Add parameter to constructor.
 707         (n_int_args): New field.
 708         * gdbsupport/format.c (format_pieces::format_pieces): Add
 709         gdb_extensions parameter.  Handle '*'.
 710         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 711         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 712         vfprintf_styled_no_gdbfmt.
 713         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 714         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 715         unfiltered output.
 716         * ui-style.h (struct ui_file_style) <ptr>: New method.
 717
 718 2019-10-01  Tom Tromey  <tom@tromey.com>
 719
 720         * unittests/format_pieces-selftests.c: Update.  Add final format.
 721         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 722         empty literal pieces.
 723
 724 2019-10-01  Tom Tromey  <tom@tromey.com>
 725
 726         * ui-out.h (enum class ui_out_style_kind): Remove.
 727         (class ui_out) <field_string, field_stsream, do_field_string>:
 728         Change type of "style".
 729         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 730         (ui_out::field_string): Update.
 731         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 732         of "style".
 733         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 734         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 735         * stack.c (print_frame_arg, print_frame_info, print_frame):
 736         Update.
 737         * source.c (print_source_lines_base): Update.
 738         * solib.c (info_sharedlibrary_command): Update.
 739         * skip.c (info_skip_command): Update.
 740         * record-btrace.c (btrace_call_history_src_line)
 741         (btrace_call_history): Update.
 742         * python/py-framefilter.c (py_print_frame): Update.
 743         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 744         "style".
 745         * mi/mi-out.c (mi_ui_out::do_table_header)
 746         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 747         (mi_ui_out::do_field_string): Update.
 748         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 749         Update.
 750         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 751         "style".
 752         * cli-out.c (cli_ui_out::do_table_header)
 753         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 754         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 755         (cli_ui_out::do_field_fmt): Update.
 756         * breakpoint.c (print_breakpoint_location): Update.
 757         (update_static_tracepoint): Update.
 758
 759 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 760
 761         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 762         conversion of gdb_datadir.
 763         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 764         remove not needed c_str ().
 765
 766 2019-09-30  Ali Tamur <tamur@google.com>
 767
 768         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 769         (dwarf2_string_attr): Likewise.
 770
 771 2019-09-30  Ali Tamur <tamur@google.com>
 772
 773         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 774         (process_full_type_unit): Likewise.
 775         (dump_die_shallow): Likewise.
 776         (cu_debug_loc_section): Likewise.
 777
 778 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 779
 780         * minsyms.c (compare_minimal_symbols): Rename to...
 781         (minimal_symbol_is_less_than): ...this, and adjust to STL
 782         conventions (return bool, take arguments as references)
 783         (minimal_symbol_reader::install): Call std::sort instead
 784         of qsort.
 785
 786 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 787
 788         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 789         hash and why.
 790         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 791         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 792
 793 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 794
 795         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 796         * psympriv.h (add_psymbol_to_list): Move comment here and update
 797         it.
 798
 799 2019-09-29  Tom de Vries  <tdevries@suse.de>
 800
 801         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 802         Use $tmpdir/$(basename "$output_file").dwz instead of
 803         "${output_file}.dwz".
 804
 805 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 806
 807         PR gdb/25045
 808         * hppa-linux-nat.c: Include gdbarch.h.
 809
 810 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 811
 812         * blockframe.c (find_pc_partial_function): Change return type to bool.
 813         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 814         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 815         (stub_gnu_ifunc_resolve_name): Likewise.
 816         * symtab.c (compare_filenames_for_search): Likewise.
 817         (compare_glob_filenames_for_search): Likewise.
 818         (matching_obj_sections): Likewise.
 819         (symbol_matches_domain): Likewise.
 820         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 821         (find_line_pc): Change return type to bool.
 822         (find_line_pc_range): Likewise.
 823         (producer_is_realview): Likewise.
 824         * symtab.h (symbol_matches_domain): Likewise.
 825         (find_pc_partial_function): Likewise.
 826         (find_pc_line_pc_range): Likewise.
 827         (in_gnu_ifunc_stub): Likewise.
 828         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 829         (find_line_pc): Likewise.
 830         (find_line_pc_range): Likewise.
 831         (matching_obj_sections): Likewise.
 832         (find_line_symtab): Change out parameter to bool.
 833         (producer_is_realview): Change return type to bool.
 834         (compare_filenames_for_search): Likewise.
 835         (compare_glob_filenames_for_search): Likewise.
 836
 837 2019-09-26  Tom Tromey  <tom@tromey.com>
 838
 839         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 840         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 841         * gdb_usleep.h: Remove.
 842         * gdb_usleep.c: Remove.
 843         * utils.c: Don't include gdb_usleep.h.
 844
 845 2019-09-26  Tom Tromey  <tromey@adacore.com>
 846
 847         * python/py-type.c (type_to_type_object): Call check_typedef
 848         for stub types.
 849
 850 2019-09-26  Tom Tromey  <tom@tromey.com>
 851
 852         * utils.h (initialize_utils): Don't declare.
 853         * top.c (gdb_init): Don't call initialize_utils.
 854         * utils.c (initialize_utils): Remove.  Move contents...
 855         (_initialize_utils): ... here.
 856
 857 2019-09-25  Tom Tromey  <tom@tromey.com>
 858
 859         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 860         * utils.h (make_hex_string): Don't declare.
 861         * utils.c (make_hex_string): Remove.
 862
 863 2019-09-24  Tom de Vries  <tdevries@suse.de>
 864
 865         PR gdb/23815
 866         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 867         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 868
 869 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 870
 871         * NEWS: Mention new simulator port for PRU.
 872
 873 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 874
 875         * ada-exp.y (write_object_remaining): Update.
 876         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 877         and eliminate the static buffer.
 878         (ada_decode_symbol): Update.
 879         (ada_la_decode): Update.
 880         (ada_sniff_from_mangled_name): Update.
 881         (is_valid_name_for_wild_match): Update.
 882         (ada_lookup_name_info::matches): Update and simplify.
 883         (name_matches_regex): Update.
 884         (ada_add_global_exceptions): Update.
 885         * ada-lang.h (ada_decode): Update signature.
 886         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 887         * dwarf-index-write.c (debug_names::insert): Update.
 888
 889 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 890
 891         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 892         formatting.
 893
 894 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 895
 896         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 897         Change "nonzero" to "true" in documentation.
 898
 899 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 900
 901         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 902         (_initialize_darwin_solib): Don't set
 903         darwin_so_ops.lookup_lib_global_symbol.
 904         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 905         set_gdbarch_iterate_over_objfiles_in_search_order.
 906         (elf_lookup_lib_symbol): Rename to...
 907         (svr4_iterate_over_objfiles_in_search_order): this, and update
 908         to iterate semantics.
 909         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 910         * solib.c (solib_global_lookup): Remove.
 911         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 912         (solib_global_lookup): Remove.
 913         * symtab.c (lookup_global_or_static_symbol): Remove call to
 914         solib_global_lookup.
 915
 916 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 917
 918         * NEWS: Move entries about default MI version now being
 919         version 3, and about the GDB/MI fix for multi-location
 920         breakpoints to the "since GDB 8.3" section.
 921
 922 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 923
 924         GDB 8.3.1 released.
 925
 926 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 927
 928         * NEWS: Mention that Cell/B.E. debugging support was removed.
 929         * MAINTAINERS: Remove spu target.
 930
 931         * config/djgpp/fnchange.lst: Remove entries for removed files.
 932
 933         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 934         spu-multiarch.o, and spu-tdep.o.
 935         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 936         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 937         spu-multiarch.c, and spu-tdep.c.
 938         * spu-linux-nat.c: Remove file.
 939         * spu-multiarch.c: Remove file.
 940         * spu-tdep.c: Remove file.
 941         * spu-tdep.h: Remove file.
 942         * solib-spu.c: Remove file.
 943         * solib-spu.h: Remove file.
 944
 945         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 946         * configure.nat (spu-linux): Remove.
 947         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 948         solib-multiarch.o from gdb_target_obs.
 949         (spu*-*-*): Remove.
 950
 951         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 952         feature flag.
 953         (ppc_linux_no_features): Update.
 954         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 955         Cell/B.E. support.
 956         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 957         (tdesc_powerpc_cell64l): Likewise.
 958         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 959         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 960         Cell/B.E. support.
 961         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 962         Do not include "features/rs6000/powerpc-cell32l.c" or
 963         "features/rs6000/powerpc-cell64l.c".
 964         (ppc_linux_spu_section): Remove.
 965         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 966         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 967         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 968         (ppc_linux_spe_context_lookup): Remove.
 969         (ppc_linux_spe_context_inferior_created): Remove.
 970         (ppc_linux_spe_context_solib_loaded): Remove.
 971         (ppc_linux_spe_context_solib_unloaded): Remove.
 972         (ppc_linux_spe_context): Remove.
 973         (struct ppu2spu_cache): Remove.
 974         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 975         (struct ppu2spu_data): Remove.
 976         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 977         ppu2spu_unwind): Remove.
 978         (ppc_linux_init_abi): Remove Cell/B.E. support.
 979         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 980
 981         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 982         (rs6000/powerpc-cell64l-expedite): Likewise
 983         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 984         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 985         rs6000/powerpc-cell64l.xml.
 986         * features/rs6000/powerpc-cell32l.xml: Remove.
 987         * features/rs6000/powerpc-cell64l.xml: Likewise.
 988         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 989         * features/rs6000/powerpc-cell64l.c: Likewise.
 990         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 991         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 992         * regformats/reg-spu.dat: Remove.
 993
 994         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 995         * corelow.c (struct spuid_list): Remove.
 996         (add_to_spuid_list): Remove.
 997         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 998         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 999         (remote_protocol_features): Remove associated entries.
1000         (_initialize_remote): No longer initialize them.
1001         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1002         * linux-nat.c (SPUFS_MAGIC): Remove.
1003         (linux_proc_xfer_spu): Remove.
1004         (spu_enumerate_spu_ids): Remove.
1005         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1006         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1007         (linux_make_corefile_notes): No longer call it.
1008
1009         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1010         (cooked_write_test): Likewise.
1011
1012 2019-09-20  Tom Tromey  <tom@tromey.com>
1013
1014         * NEWS: Mention case-sensitivity of TUI commands.
1015         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1016         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1017         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1018
1019 2019-09-20  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-source.c (tui_source_window::set_contents): Use
1022         make_unique_xstrdup.
1023         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1024         make_unique_xstrdup.
1025
1026 2019-09-20  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-data.c: Remove separator comments.
1029         * tui/tui-layout.c: Remove separator comments.
1030         * tui/tui-win.c: Remove separator comments.
1031         * tui/tui-wingeneral.c: Remove separator comments.
1032
1033 2019-09-20  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui.h (strcat_to_buf): Don't declare.
1036         * tui/tui.c (strcat_to_buf): Remove.
1037
1038 2019-09-20  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1041         from "fullname".
1042         * tui/tui-source.c (tui_source_window::set_contents)
1043         (tui_source_window::location_matches_p)
1044         (tui_source_window::maybe_update): Update.
1045
1046 2019-09-20  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1049         Update.
1050         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1051         prefix.
1052         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1053         (tui_data_window::line_from_reg_element_no)
1054         (tui_data_window::first_reg_element_no_inline)
1055         (tui_data_window::show_registers)
1056         (tui_data_window::show_register_group)
1057         (tui_data_window::display_registers_from)
1058         (tui_data_window::display_registers_from_line)
1059         (tui_data_window::first_data_item_displayed)
1060         (tui_data_window::delete_data_content_windows)
1061         (tui_data_window::erase_data_content)
1062         (tui_data_window::do_scroll_vertical)
1063         (tui_data_window::refresh_window)
1064         (tui_data_window::check_register_values): Update.
1065
1066 2019-09-20  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1069         (struct tui_locator_window) <full_name, proc_name>: Now
1070         std::string.
1071         * tui/tui-stack.c (tui_locator_window::make_status_line)
1072         (tui_locator_window::set_locator_fullname)
1073         (tui_locator_window::set_locator_info): Update.
1074         * tui/tui-source.c (tui_source_window::set_contents)
1075         (tui_source_window::showing_source_p): Update.
1076
1077 2019-09-20  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1080         Don't call tui_locator_win_info_ptr.
1081
1082 2019-09-20  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1085
1086 2019-09-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1089         height for locator.
1090         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1091         * tui/tui-layout.c (show_source_disasm_command, show_data)
1092         (show_source_or_disasm_and_command): Use 1 as height for locator.
1093
1094 2019-09-20  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui.c (tui_enable): Update.
1097         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1098         Update.
1099         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1100         Update.
1101         * tui/tui-data.c (win_resized): Now bool.
1102         (tui_win_resized): Return bool.
1103         (tui_set_win_resized_to): Accept a bool.
1104
1105 2019-09-20  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1108         Change type of "refresh_values_only".
1109         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1110         type of "refresh_values_only".
1111
1112 2019-09-20  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1115         std::string.
1116         (tui_disassemble): Add "pos" parameter.
1117         (tui_disasm_window::set_contents): Simplify.
1118
1119 2019-09-20  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-winsource.h (struct tui_source_window_base)
1122         <show_source_content>: Now private.
1123         * tui/tui-winsource.c
1124         (tui_source_window_base::show_source_content): Don't handle empty
1125         content case.
1126
1127 2019-09-20  Tom Tromey  <tom@tromey.com>
1128
1129         * tui/tui-layout.c (show_source_disasm_command)
1130         (show_source_or_disasm_and_command): Don't call
1131         show_source_content.
1132
1133 2019-09-20  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1136         Declare.
1137         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1138         from tui_make_status_line.
1139         (tui_locator_window::rerender): Update.
1140
1141 2019-09-20  Tom Tromey  <tom@tromey.com>
1142
1143         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1144         (tui_locator_window::rerender): Update.
1145
1146 2019-09-20  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.h (struct tui_source_window_base)
1149         <~tui_source_window_base>: Don't declare.
1150         <fullname>: Remove.
1151         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1152         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1153         member.
1154         * tui/tui-source.c (tui_source_window::set_contents): Update.
1155         (tui_source_window::location_matches_p)
1156         (tui_source_window::maybe_update): Update.
1157
1158 2019-09-20  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-winsource.h (~tui_source_element): Remove.
1161         (tui_source_element): Update.
1162         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1163         * tui/tui-winsource.c (tui_show_source_line): Update.
1164         * tui/tui-source.c (tui_source_window::set_contents): Update.
1165         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1166
1167 2019-09-20  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1170         declare.
1171         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1172         tui_clear_source_windows_detail.
1173         * tui/tui-winsource.h (struct tui_source_window_base)
1174         <clear_detail>: Don't declare.
1175         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1176         Remove.
1177         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1178
1179 2019-09-20  Tom Tromey  <tromey@adacore.com>
1180
1181         PR ada/24919:
1182         * block.c (contained_in): Fix final return value.
1183
1184 2019-09-20  Alan Modra  <amodra@gmail.com>
1185
1186         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1187         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1188         (read_indirect_string_from_dwz): Use bfd accessor.
1189         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1190         * machoread.c (macho_symfile_read_all_oso): Likewise.
1191         * solib.c (solib_bfd_open): Likewise.
1192
1193 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1194
1195         * eval.c: Move declaration of overload_resolution to...
1196         * value.h: ...here.
1197
1198 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1199
1200         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1201         * arm-linux-tdep.c: Likewise.
1202         * arm-nbsd-nat.c: Likewise.
1203         * arm-tdep.h: Declare arm_apcs_32.
1204         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1205
1206 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1209         * dwarf2read.h: Declare dwarf_always_disassemble.
1210
1211 2019-09-19  Tom de Vries  <tdevries@suse.de>
1212
1213         PR gdb/25009
1214         * source-cache.c (source_cache::ensure): Catch exception thrown during
1215         construction of the highlighter.
1216
1217 2019-09-18  Alan Modra  <amodra@gmail.com>
1218
1219         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1220         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1221         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1222         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1223         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1224         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1225         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1226         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1227         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1228         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1229         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1230         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1231         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1232         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1233         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1234         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1235         * mi/mi-interp.c: Update throughout for bfd section macro and
1236         function changes.
1237         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1238         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1239
1240 2019-09-18  Tom Tromey  <tom@tromey.com>
1241
1242         * NEWS: Add entry.
1243         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1244         call rl_initialize.
1245         (tui_enable): Do not call rl_initialize.
1246
1247 2019-09-18  Christian Groessler  <chris@groessler.org>
1248
1249         * alpha-linux-nat.c: Include gdbarch.h.
1250
1251 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1252
1253         * ui-file.c: Include cli/cli-style.h.
1254         (term_cli_styling): Remove cli_styling declaration.
1255
1256 2019-09-18  Alan Modra  <amodra@gmail.com>
1257
1258         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1259         to bfd_asymbol_section.
1260
1261 2019-09-18  Alan Modra  <amodra@gmail.com>
1262
1263         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1264         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1265         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1266
1267 2019-09-18  Alan Modra  <amodra@gmail.com>
1268
1269         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1270         * spu-linux-nat.c (spu_bfd_open): Likewise.
1271
1272 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1273
1274         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1275         to bool to match definition in dwarf2read.c.
1276
1277 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1278
1279         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1280         (print_signatures): Likewise.
1281         (trust_pad_over_xvs): Likewise.
1282         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1283         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1284         * arm-linux-nat.c (arm_apcs_32): Likewise.
1285         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1286         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1287         * arm-tdep.c (arm_debug): Likewise.
1288         (arm_apcs_32): Likewise.
1289         * auto-load.c (debug_auto_load): Likewise.
1290         (auto_load_gdb_scripts): Likewise.
1291         (global_auto_load): Likewise.
1292         (auto_load_local_gdbinit): Likewise.
1293         (auto_load_local_gdbinit_loaded): Likewise.
1294         * auto-load.h (global_auto_load): Likewise.
1295         (auto_load_local_gdbinit): Likewise.
1296         (auto_load_local_gdbinit_loaded): Likewise.
1297         * breakpoint.c (disconnected_dprintf): Likewise.
1298         (breakpoint_proceeded): Likewise.
1299         (automatic_hardware_breakpoints): Likewise.
1300         (always_inserted_mode): Likewise.
1301         (target_exact_watchpoints): Likewise.
1302         (_initialize_breakpoint): Update.
1303         * breakpoint.h (target_exact_watchpoints): Change to bool.
1304         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1305         * cli/cli-cmds.c (trace_commands): Likewise.
1306         * cli/cli-cmds.h (trace_commands): Likewise.
1307         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1308         to bool*.
1309         * cli/cli-logging.c (logging_overwrite): Change to bool.
1310         (logging_redirect): Likewise.
1311         (debug_redirect): Likewise.
1312         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1313         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1314         to bool.
1315         <boolean_option_def>: Update.
1316         (struct flag_option_def): Change default type of Context to bool
1317         from int.
1318         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1319         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1320         (get_setshow_command_value_string): Likewise.
1321         * cli/cli-style.c (cli_styling): Change to bool.
1322         (source_styling): Likewise.
1323         * cli/cli-style.h (source_styling): Likewise.
1324         (cli_styling): Likewise.
1325         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1326         to bool.
1327         * command.h (var_types): Update comment.
1328         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1329         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1330         bool.
1331         (debug_compile_cplus_scopes): Likewise.
1332         * compile/compile-internal.h (compile_debug): Likewise.
1333         * compile/compile.c (compile_debug): Likewise.
1334         (struct compile_options) <raw>: Likewise.
1335         * cp-support.c (catch_demangler_crashes): Likewise.
1336         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1337         (usr_cmd_cris_dwarf2_cfi): Likewise.
1338         * csky-tdep.c (csky_debug): Likewise.
1339         * darwin-nat.c (enable_mach_exceptions): Likewise.
1340         * dcache.c (dcache_enabled_p): Likewise.
1341         * defs.h (info_verbose): Likewise.
1342         * demangle.c (demangle): Likewise.
1343         (asm_demangle): Likewise.
1344         * dwarf-index-cache.c (debug_index_cache): Likewise.
1345         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1346         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1347         * dwarf2read.c (check_physname): Likewise.
1348         (use_deprecated_index_sections): Likewise.
1349         (dwarf_always_disassemble): Likewise.
1350         * eval.c (overload_resolution): Likewise.
1351         * event-top.c (set_editing_cmd_var): Likewise.
1352         (exec_done_display_p): Likewise.
1353         * event-top.h (set_editing_cmd_var): Likewise.
1354         (exec_done_display_p): Likewise.
1355         * exec.c (write_files): Likewise.
1356         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1357         (debug_fbsd_nat): Likewise.
1358         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1359         Likewise.
1360         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1361         <backtrace_past_entry> Likewise.
1362         * gdb-demangle.h (demangle): Likewise.
1363         (asm_demangle): Likewise.
1364         * gdb_bfd.c (bfd_sharing): Likewise.
1365         * gdbcore.h (write_files): Likewise.
1366         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1367         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1368         * gdbthread.h (print_thread_events): Likewise.
1369         * gdbtypes.c (opaque_type_resolution): Likewise.
1370         (strict_type_checking): Likewise.
1371         * gnu-nat.c (gnu_debug_flag): Likewise.
1372         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1373         * guile/scm-param.c (pascm_variable): Add boolval.
1374         (add_setshow_generic): Update.
1375         (pascm_param_value): Update.
1376         (pascm_set_param_value_x): Update.
1377         * hppa-tdep.c (hppa_debug): Change to bool..
1378         * infcall.c (may_call_functions_p): Likewise.
1379         (coerce_float_to_double_p): Likewise.
1380         (unwind_on_signal_p): Likewise.
1381         (unwind_on_terminating_exception_p): Likewise.
1382         * infcmd.c (startup_with_shell): Likewise.
1383         * inferior.c (print_inferior_events): Likewise.
1384         * inferior.h (startup_with_shell): Likewise.
1385         (print_inferior_events): Likewise.
1386         * infrun.c (step_stop_if_no_debug): Likewise.
1387         (detach_fork): Likewise.
1388         (debug_displaced): Likewise.
1389         (disable_randomization): Likewise.
1390         (non_stop): Likewise.
1391         (non_stop_1): Likewise.
1392         (observer_mode): Likewise.
1393         (observer_mode_1): Likewise.
1394         (set_observer_mode): Update.
1395         (sched_multi): Change to bool.
1396         * infrun.h (debug_displaced): Likewise.
1397         (sched_multi): Likewise.
1398         (step_stop_if_no_debug): Likewise.
1399         (non_stop): Likewise.
1400         (disable_randomization): Likewise.
1401         * linux-tdep.c (use_coredump_filter): Likewise.
1402         (dump_excluded_mappings): Likewise.
1403         * linux-thread-db.c (auto_load_thread_db): Likewise.
1404         (check_thread_db_on_load): Likewise.
1405         * main.c (captured_main_1): Update.
1406         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1407         xx2_opt, boolean_opt>: Change to bool.
1408         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1409         * maint.c (maintenance_profile_p): Likewise.
1410         (per_command_time): Likewise.
1411         (per_command_space): Likewise.
1412         (per_command_symtab): Likewise.
1413         * memattr.c (inaccessible_by_default): Likewise.
1414         * mi/mi-main.c (mi_async): Likewise.
1415         (mi_async_1): Likewise.
1416         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1417         * nat/fork-inferior.h (startup_with_shell): Likewise.
1418         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1419         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1420         * nios2-tdep.c (nios2_debug): Likewise.
1421         * or1k-tdep.c (or1k_debug): Likewise.
1422         * parse.c (parser_debug): Likewise.
1423         * parser-defs.h (parser_debug): Likewise.
1424         * printcmd.c (print_symbol_filename): Likewise.
1425         * proc-api.c (procfs_trace): Likewise.
1426         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1427         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1428         (set_parameter_value): Update.
1429         (add_setshow_generic): Update.
1430         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1431         to bool*.
1432         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1433         int*.
1434         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1435         * record-btrace.c (record_btrace_target::store_registers): Update.
1436         * record-full.c (record_full_memory_query): Change to bool.
1437         (record_full_stop_at_limit): Likewise.
1438         * record-full.h (record_full_memory_query): Likewise.
1439         * remote-notif.c (notif_debug): Likewise.
1440         * remote-notif.h (notif_debug): Likewise.
1441         * remote.c (use_range_stepping): Likewise.
1442         (interrupt_on_connect): Likewise.
1443         (remote_break): Likewise.
1444         * ser-tcp.c (tcp_auto_retry): Likewise.
1445         * ser-unix.c (serial_hwflow): Likewise.
1446         * skip.c (debug_skip): Likewise.
1447         * solib-aix.c (solib_aix_debug): Likewise.
1448         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1449         (spu_auto_flush_cache_p): Likewise.
1450         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1451         Likewise.
1452         (struct info_print_options) <quiet>: Likewise.
1453         * symfile-debug.c (debug_symfile): Likewise.
1454         * symfile.c (auto_solib_add): Likewise.
1455         (separate_debug_file_debug): Likewise.
1456         * symfile.h (auto_solib_add): Likewise.
1457         (separate_debug_file_debug): Likewise.
1458         * symtab.c (basenames_may_differ): Likewise.
1459         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1460         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1461         (struct info_types_options) <quiet>: Likewise.
1462         * symtab.h (demangle): Likewise.
1463         (basenames_may_differ): Likewise.
1464         * target-dcache.c (stack_cache_enabled_1): Likewise.
1465         (code_cache_enabled_1): Likewise.
1466         * target.c (trust_readonly): Likewise.
1467         (may_write_registers): Likewise.
1468         (may_write_memory): Likewise.
1469         (may_insert_breakpoints): Likewise.
1470         (may_insert_tracepoints): Likewise.
1471         (may_insert_fast_tracepoints): Likewise.
1472         (may_stop): Likewise.
1473         (auto_connect_native_target): Likewise.
1474         (target_stop_and_wait): Update.
1475         (target_async_permitted): Change to bool.
1476         (target_async_permitted_1): Likewise.
1477         (may_write_registers_1): Likewise.
1478         (may_write_memory_1): Likewise.
1479         (may_insert_breakpoints_1): Likewise.
1480         (may_insert_tracepoints_1): Likewise.
1481         (may_insert_fast_tracepoints_1): Likewise.
1482         (may_stop_1): Likewise.
1483         * target.h (target_async_permitted): Likewise.
1484         (may_write_registers): Likewise.
1485         (may_write_memory): Likewise.
1486         (may_insert_breakpoints): Likewise.
1487         (may_insert_tracepoints): Likewise.
1488         (may_insert_fast_tracepoints): Likewise.
1489         (may_stop): Likewise.
1490         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1491         (make_thread_apply_all_options_def_group): Change argument from int*
1492         to bool*.
1493         (thread_apply_all_command): Update.
1494         (print_thread_events): Change to bool.
1495         * top.c (confirm): Likewise.
1496         (command_editing_p): Likewise.
1497         (history_expansion_p): Likewise.
1498         (write_history_p): Likewise.
1499         (info_verbose): Likewise.
1500         * top.h (confirm): Likewise.
1501         (history_expansion_p): Likewise.
1502         * tracepoint.c (disconnected_tracing): Likewise.
1503         (circular_trace_buffer): Likewise.
1504         * typeprint.c (print_methods): Likewise.
1505         (print_typedefs): Likewise.
1506         * utils.c (debug_timestamp): Likewise.
1507         (sevenbit_strings): Likewise.
1508         (pagination_enabled): Likewise.
1509         * utils.h (sevenbit_strings): Likewise.
1510         (pagination_enabled): Likewise.
1511         * valops.c (overload_resolution): Likewise.
1512         * valprint.h (struct value_print_options) <prettyformat_arrays,
1513         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1514         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1515         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1516         Likewise.
1517         * windows-nat.c (new_console): Likewise.
1518         (cygwin_exceptions): Likewise.
1519         (new_group): Likewise.
1520         (debug_exec): Likewise.
1521         (debug_events): Likewise.
1522         (debug_memory): Likewise.
1523         (debug_exceptions): Likewise.
1524         (useshell): Likewise.
1525         * windows-tdep.c (maint_display_all_tib): Likewise.
1526         * xml-support.c (debug_xml): Likewise.
1527
1528 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1529
1530         * source.c (prepare_path_for_appending): New function.
1531         (openp): Make use of new function.
1532         (find_and_open_source): Search for the compilation directory and
1533         source file as a relative path beneath the directory search path.
1534
1535 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * source-cache.c (source_cache::get_line_charpos): Catch
1538         exceptions and return false, this matches the behaviour documented
1539         in the header file.
1540
1541 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1542
1543         * ada-tasks.c (info_task): Remove quoting of the task's name.
1544
1545 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1546
1547         * symfile.c (auto_solib_add): Replace comment with a reference
1548         to the header file.
1549
1550 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1551
1552         * NEWS: Mention that gdb can now be compiled with Python 3
1553         on Windows.
1554
1555 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         * maint.c (maint_print_section_data::maint_print_section_data):
1558         Force use of 'float log10 (float)' by casting the argument to
1559         float.
1560
1561 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * maint.c: Add 'cmath' include.
1564         (struct maint_print_section_data): New structure.
1565         (print_section_index): New function.
1566         (print_bfd_section_info): Add header comment, small whitespace
1567         cleanup, and update to call new print_section_index function.
1568         (print_objfile_section_info): Likewise.
1569         (maint_obj_section_from_bfd_section): New function.
1570         (print_bfd_section_info_maybe_relocated): New function.
1571         (maintenance_info_sections): Add header comment, always use
1572         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1573
1574 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1577         inner scope, add check that the objfile has psymtabs before
1578         checking psymtabs_addrmap.
1579         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1580
1581 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1582
1583         * NEWS: Announce that Ada task names are now shown at more places,
1584         and between quotes (except in info task output).
1585         * gdb/ada-tasks.c (task_to_str): New function.
1586         (display_current_task_id): Call task_to_str.
1587         (task_command_1): Likewise.
1588         (print_ada_task_info): In non-mi mode, Properly align headers and data
1589         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1590
1591 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1592
1593         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1594         prstatus.pr_lwp.pr_info instead of making it up.
1595
1596 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1597
1598         * auto-load.c (auto_load_expand_dir_vars): Update.
1599         * defs.h (gdb_datadir): Change to std::string.
1600         (python_libdir): Likewise.
1601         (relocate_gdb_directory): Change return type to std::string.
1602         * guile/guile.c (gdbscm_data_directory): Update.
1603         (initialize_scheme_side): Update.
1604         * jit.c (jit_reader_dir): Change to std::string.
1605         (jit_reader_load_command): Update.
1606         * main.c (gdb_datadir): Change to std::string.
1607         (python_libdir): Likewise.
1608         (set_gdb_data_directory): Update.
1609         (relocate_path): Change to return std::string.
1610         (relocate_gdb_directory): Change to return std::string.
1611         (relocate_gdbinit_path_maybe_in_datadir): Update.
1612         (captured_main_1): Update.
1613         * python/python.c (do_start_initialization): Update.
1614         * top.c (show_gdb_datadir): Update.
1615         * xml-syscall.c (xml_init_syscalls_info): Update.
1616         (init_syscalls_info): Update.
1617
1618 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1619
1620         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1621         out of get_init_files.
1622         (get_init_files): Update.
1623
1624 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1625
1626         * main.c (get_init_files): Change to use std::string.
1627         (captured_main_1): Update.
1628         (print_gdb_help): Update.
1629
1630 2019-09-11  Ali Tamur  <tamur@google.com>
1631
1632         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1633         implementation.
1634
1635 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1636
1637         * dbxread.c (read_dbx_symtab): Update.
1638         * dwarf2read.c (load_partial_dies): Update.
1639         * mdebugread.c (parse_partial_symbols): Update.
1640         (handle_psymbol_enumerators): Update.
1641         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1642         * psymtab.c (add_psymbol_to_bcache): Likewise.
1643         (add_psymbol_to_list): Likewise.
1644         * symtab.c (symbol_set_names): Likewise.
1645         * symtab.h (symbol_set_names): Likewise.
1646         * xcoffread.c (scan_xcoff_symtab): Update.
1647
1648 2019-09-11  Tom Tromey  <tom@tromey.com>
1649
1650         * symfile-mem.c (symbol_file_add_from_memory): Use
1651         bfd_set_filename.
1652         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1653         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1654
1655 2019-09-10  Tom Tromey  <tromey@adacore.com>
1656
1657         * dwarf-index-write.c (write_psymbols): Extend error message.
1658         (debug_names::insert): Add Ada code.
1659         (debug_names::write_psymbols): Remove Ada check.
1660         (debug_names) <m_string_obstack>: New member.
1661         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1662         (gdb_index_symbol_name_matcher::matches): Remove.
1663         (mapped_index_base::find_name_components_bounds): Add "lang"
1664         parameter.
1665         (mapped_index_base::build_name_components): Also split names
1666         according to Ada syntax.
1667         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1668         type of "match_callback".
1669         (check_match, check_find_bounds_finds)
1670         (dw2_expand_symtabs_matching): Update.
1671         (dw2_debug_names_iterator): Add new constructor.
1672         (dw2_debug_names_map_matching_symbols): New function.
1673         (dw2_debug_names_expand_symtabs_matching): Update.
1674         (dwarf2_debug_names_functions): Use
1675         dw2_debug_names_map_matching_symbols.
1676
1677 2019-09-10  Tom Tromey  <tromey@adacore.com>
1678
1679         * dwarf2read.c (dw2_get_file_names_reader): Add the
1680         CU's file name to the results.
1681
1682 2019-09-10  Tom Tromey  <tromey@adacore.com>
1683
1684         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1685         map_matching_symbols.  Update.
1686         * dwarf2read.c (dw2_map_matching_symbols): Update.
1687         * psymtab.c (match_partial_symbol): Change type; update.
1688         (psym_map_matching_symbols): Likewise.
1689         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1690         type; update.
1691         * symfile.h (struct quick_symbol_functions)
1692         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1693         Remove "match".
1694
1695 2019-09-10  Tom Tromey  <tromey@adacore.com>
1696
1697         * psymtab.c (map_block): Remove.
1698         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1699         * symtab.c (iterate_over_symbols_terminated): New function.
1700         * symtab.c (iterate_over_symbols_terminated): Declare.
1701
1702 2019-09-10  Tom Tromey  <tromey@adacore.com>
1703
1704         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1705         * language.h (struct language_defn) <la_iterate_over_symbols>:
1706         Return bool.
1707         * symtab.c (iterate_over_symbols): Return bool.
1708         * symtab.h (iterate_over_symbols): Return bool.
1709
1710 2019-09-10  Tom Tromey  <tromey@adacore.com>
1711
1712         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1713         (add_nonlocal_symbols): Update.
1714         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1715         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1716         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1717         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1718         Change type of "callback".  Remove "data".
1719
1720
1721 2019-09-09  Ali Tamur  <tamur@google.com>
1722
1723         * dwarf2read.c (comp_unit_head): Update comment.
1724         (dwarf2_dwo_name): New function declaration.
1725         (dwarf_unit_type_name): New function declaration.
1726         (read_comp_unit_head): Add support for new compilation units,
1727         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1728         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1729         (currently named as "signature") in their header. Also clarify error
1730         messages.
1731         (lookup_dwo_id): New function. Returns the dwo id of the given
1732         compile unit.
1733         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1734         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1735         functions.
1736         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1737         (dwarf2_dwo_name): Get the dwo name if present.
1738         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1739         purposes.
1740
1741 2019-09-09  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1744
1745 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1746
1747         * python/python.c (do_start_initialization): Make progname_copy static,
1748         to avoid a leak report.
1749
1750 2019-09-08  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1753
1754 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1755
1756         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1757         Change type to gdb::optional<block_enum>.
1758         (dw2_symtab_iter_init): Change block_index parameter type
1759         to gdb::optional<block_enum>.
1760         (dw2_lookup_symbol): Change block_index parameter
1761         type to block_enum.c
1762         (dw2_debug_names_lookup_symbol): Likewise.
1763         * psymtab.c (psym_lookup_symbol): Likewise.
1764         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1765         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1766         Likewise.
1767
1768 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1769
1770         * defs.h (relocate_gdb_directory): Change int to bool in
1771         signature and rename flag to relocatable.
1772         * main.c (relocate_path): Likewise.
1773         (relocate_gdb_directory): Likewise.
1774
1775 2019-09-06  Alan Modra  <amodra@gmail.com>
1776
1777         * coffread.c (coff_symfile_read): Constify filename variable.
1778         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1779         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1780         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1781         * solib.c (reload_shared_libraries_1): Likewise.
1782         * symfile.c (reread_symbols): Likewise.
1783         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1784         * solib-darwin.c (darwin_bfd_open): Likewise.
1785         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1786
1787 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1790         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1791
1792 2019-09-03  Tom Tromey  <tromey@adacore.com>
1793
1794         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1795         types.
1796         (has_negatives): Unbias a range type bound.
1797         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1798         * gdbtypes.c (operator==): Handle new field.
1799         (create_range_type): Add "bias" parameter.
1800         (create_static_range_type, resolve_dynamic_range): Update.
1801         * gdbtypes.h (struct range_bounds) <bias>: New member.
1802         (create_range_type): Add bias parameter.
1803         * printcmd.c (print_scalar_formatted): Unbias range types.
1804         * value.c (unpack_long): Unbias range types.
1805         (pack_long): Bias range types.
1806
1807 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1808
1809         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1810         probe arguments.
1811
1812 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1813
1814         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1815         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1816         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1817         (compile_probe_arg): Likewise.
1818         * probe.h (get_argument_count): Likewise.
1819         * solib-svr4.c (solib_event_probe_action): Likewise.
1820         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1821
1822 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1823
1824         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1825         code to here...
1826         (svr4_create_solib_event_breakpoints): ...from here.
1827
1828 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1829
1830         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1831         suffix from warning message.
1832
1833 2019-08-30  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-winsource.h (struct tui_source_window_base)
1836         <refresh_all>: Don't declare.
1837         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1838         Remove.
1839         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1840         tui_show_locator_content.
1841         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1842         declare.
1843         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1844         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1845         declare.
1846
1847 2019-08-30  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1850
1851 2019-08-30  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1854         Remove unnecessary forward declarations.
1855
1856 2019-08-30  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1859         rerender.
1860         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1861         tui_show_locator_content.
1862
1863 2019-08-30  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1866         (tui_locator_window::rerender): Rewrite using body of previous
1867         tui_show_locator_content.
1868
1869 2019-08-30  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1872         set_locator_fullname>: New methods.
1873         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1874         Rename from tui_set_locator_fullname.
1875         (tui_locator_window::set_locator_info): Rename from
1876         tui_set_locator_info.  Return bool.
1877         (tui_update_locator_fullname, tui_show_frame_info): Update.
1878
1879 2019-08-30  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1882
1883 2019-08-30  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1886         call touchwin.
1887
1888 2019-08-30  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-wingeneral.c (box_win): Assume win_info and
1891         win_info->handle cannot be NULL.
1892
1893 2019-08-30  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1896         refresh_window>: Declare.
1897         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1898         resize.
1899         (tui_data_item_window::rerender): Rename from
1900         tui_display_register.
1901         (tui_data_item_window::refresh_window): New method.
1902         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1903         no-op.
1904
1905 2019-08-30  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1908         regs_column_count, current_group>: Move later.  Now private.
1909         <get_current_group>: New method.
1910         * tui/tui-regs.c (tui_reg_command): Update.
1911         * tui/tui-layout.c (tui_set_layout): Update.
1912
1913 2019-08-30  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1916         (tui_data_window::rerender): Don't call
1917         check_and_display_highlight_if_needed.
1918         (tui_data_window::refresh_all): Remove call to
1919         erase_data_content.
1920
1921 2019-08-30  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1924         (tui_data_window::display_registers_from)
1925         (tui_data_window::display_reg_element_at_line)
1926         (tui_data_window::display_registers_from_line): Remove checks of
1927         "empty".
1928
1929 2019-08-30  Tom Tromey  <tom@tromey.com>
1930
1931         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1932         Don't declare.
1933         * tui/tui-regs.c (tui_data_window::show_registers): Call
1934         rerender.
1935         (tui_data_window::rerender): Rename from display_all_data.
1936         (tui_data_window::rerender): Remove old implementation.
1937
1938 2019-08-30  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1941         text.
1942         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1943
1944 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1945             Sergio Durigan Junior  <sergiodj@redhat.com>
1946
1947         PR win32/24284
1948         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1949
1950 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1953         when searching for types.
1954
1955 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1956
1957         * f-lang.c (f_language_defn): Use f_print_typedef.
1958         * f-lang.h (f_print_typedef): Declare.
1959         * f-typeprint.c (f_print_typedef): Define.
1960
1961 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1962
1963         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1964
1965 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * cli/cli-utils.c (info_print_options_defs): Delete.
1968         (make_info_print_options_def_group): Delete.
1969         (extract_info_print_options): Delete.
1970         (info_print_command_completer): Delete.
1971         (info_print_args_help): Add extra parameter, and optionally
1972         include text about -n flag.
1973         * cli/cli-utils.h (struct info_print_options): Delete.
1974         (extract_info_print_options): Delete declaration.
1975         (info_print_command_completer): Delete declaration.
1976         (info_print_args_help): Add extra parameter, extend header
1977         comment.
1978         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1979         search_symbols.
1980         * stack.c (struct info_print_options): New type.
1981         (info_print_options_defs): New file scoped variable.
1982         (make_info_print_options_def_group): New static function.
1983         (info_print_command_completer): New static function.
1984         (info_locals_command): Update to use new local functions.
1985         (info_args_command): Likewise.
1986         (_initialize_stack): Add extra parameter to calls to
1987         info_print_args_help.
1988         * symtab.c (search_symbols): Add extra parameter, use this to
1989         possibly excluse non-debug symbols.
1990         (symtab_symbol_info): Add extra parameter, which is passed on to
1991         search_symbols.
1992         (struct info_print_options): New type.
1993         (info_print_options_defs): New file scoped variable.
1994         (make_info_print_options_def_group): New static function.
1995         (info_print_command_completer): New static function.
1996         (info_variables_command): Update to use local functions, and pass
1997         extra parameter through to symtab_symbol_info.
1998         (info_functions_command): Likewise.
1999         (info_types_command): Pass additional argument through to
2000         symtab_symbol_info.
2001         (rbreak_command): Pass extra argument to search_symbols.
2002         (_initialize_symtab): Add extra arguments for calls to
2003         info_print_args_help, and update help text for 'info variables',
2004         'whereis', and 'info functions' commands.
2005         * symtab.h (search_symbols): Add extra argument to declaration.
2006         * NEWS: Mention new flags.
2007
2008 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2009
2010         * symtab.c (lookup_static_symbol): Call the new function (and move
2011         it down to be next to lookup_global_symbol).
2012         (struct global_sym_lookup_data): Add block_enum member and rename to...
2013         (struct global_or_static_sym_lookup_data): ...this.
2014         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2015         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2016         (lookup_symbol_global_or_static_iterator_cb): ...this.
2017         (lookup_global_or_static_symbol): New function.
2018         (lookup_global_symbol): Call new function.
2019
2020 2019-08-26  Tom de Vries  <tdevries@suse.de>
2021
2022         PR c++/24852
2023         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2024         when pc_probe.prob == NULL.
2025
2026 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2027
2028         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2029         variable symbol_linkage to symbol_linkage_.
2030
2031 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2032
2033         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2034         represent whether the symbol is static, dynamic, or we don't
2035         know.
2036
2037 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2038
2039         * gdb/rx-tdep.c (rx_register_names): New.
2040         (rx_register_name): Delete.
2041         (rx_psw_type): Delete.
2042         (rx_fpsw_type): Delete.
2043         (rx_register_type): Delete.
2044         (rx_gdbarch_init): Convert target-descriptions.
2045         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2046         * gdb/features/Makefile: Add rx.xml.
2047         * gdb/features/rx.xml: New.
2048         * gdb/features/rx.c: Generated.
2049         * gdb/NEWS: Mention target description support.
2050
2051 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2052
2053         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2054         *slot_ptr.
2055
2056 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2057
2058         * configure.ac: Don't check for 'dlfcn.h' (moved to
2059         gdbsupport/common.m4).
2060         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2061         'gdbsupport/'.
2062         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2063         * compile/compile-c-support.c: Include
2064         'gdbsupport/gdb-dlfcn.h'.
2065         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2066         * gdb-dlfcn.c: Move to...
2067         * gdbsupport/gdb-dlfcn.c: ... here.
2068         * gdb-dlfcn.h: Move to...
2069         * gdbsupport/gdb-dlfcn.h: ... here.
2070
2071 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2072
2073         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2074         the offset field signed.
2075
2076 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * python/lib/gdb/__init__.py (_execute_file): New function.
2079         * python/python.c (python_run_simple_file): Call gdb._execute_file
2080         on Windows.
2081
2082 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2085         all uses as this was never set to anything but a zero value.
2086
2087 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2088
2089         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2090
2091 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2092
2093         * tui/tui-data.h (tui_gen_win_info): Add an =default
2094         move constructor, required by some GCC versions.
2095
2096 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2097
2098         * go32-nat.c (go32_sysinfo): Add hygon_p.
2099
2100 2019-08-20  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2103         line_from_reg_element_no, first_reg_element_no_inline,
2104         display_all_data, delete_data_content_windows,
2105         erase_data_content>: Now private.
2106
2107 2019-08-20  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2110         (tui_unhighlight_win, tui_highlight_win)
2111         (tui_win_info::make_window): Update.
2112         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2113
2114 2019-08-20  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2117         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2118         (MAX_PID_WIDTH): Move to tui-stack.c.
2119         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2120         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2121         (MAX_PID_WIDTH): Move from tui-data.h.
2122
2123 2019-08-20  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2126         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2127         (box_win): Update.
2128         (tui_gen_win_info::make_window): Rename from tui_make_window.
2129         (tui_win_info::make_window): New method.
2130         (tui_gen_win_info::make_visible): Update.
2131         * tui/tui-source.c (tui_source_window::set_contents): Update.
2132         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2133         (tui_data_window::display_registers_from): Update.
2134         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2135         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2136         Declare.
2137         <can_box>: Remove.
2138         <title>: Remove.
2139         (struct tui_win_info) <make_window>: Declare.
2140         <can_box>: Now virtual.
2141         <title>: New member.
2142         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2143         * tui/tui-command.c (tui_cmd_window::resize): Update.
2144
2145 2019-08-20  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2148         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2149         (tui_data_window::check_register_values): Update.
2150
2151 2019-08-20  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-regs.h (struct tui_data_window): Use
2154         DISABLE_COPY_AND_ASSIGN.
2155         <regs_content>: Change type, removing unique_ptr.
2156         <tui_data_window>: Add move constructor.
2157         * tui/tui-regs.c (tui_data_window::show_registers)
2158         (tui_data_window::show_register_group)
2159         (tui_data_window::display_registers_from)
2160         (tui_data_window::display_registers_from)
2161         (tui_data_window::first_data_item_displayed)
2162         (tui_data_window::delete_data_content_windows)
2163         (tui_data_window::rerender, tui_data_window::refresh_window)
2164         (tui_data_window::check_register_values): Update.
2165
2166 2019-08-20  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2169         show_register_group>: Declare.
2170         (tui_show_register_group): Don't declare.
2171         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2172         tui_show_registers.
2173         (tui_data_window::show_register_group): Rename from
2174         tui_show_register_group.
2175         (tui_data_window::check_register_values, tui_reg_command):
2176         Update.
2177         * tui/tui-layout.c (tui_set_layout): Update.
2178
2179 2019-08-20  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2182         Declare.
2183         (tui_check_register_values): Don't declare.
2184         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2185         from tui_check_register_values.
2186         * tui/tui-hooks.c (tui_register_changed): Update.
2187
2188 2019-08-20  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-regs.c (tui_reg_layout): Move later.
2191         (tui_show_registers): Don't enable TUI mode or change layout.
2192
2193 2019-08-20  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-regs.h (struct tui_data_item_window)
2196         <~tui_data_item_window>: Remove.
2197         <content>: Now a unique_xmalloc_ptr.
2198         * tui/tui-regs.c (tui_register_format): Return a
2199         unique_xmalloc_ptr.
2200         (tui_get_register): Update.
2201         (~tui_data_item_window): Remove.
2202         (tui_data_window::display_registers_from, tui_display_register):
2203         Update.
2204         * tui/tui-io.h (tui_expand_tabs): Update.
2205         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2206         Remove "col" parameter.
2207
2208 2019-08-20  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2211         field.
2212         * tui/tui-regs.c (~tui_data_item_window): Update.
2213
2214 2019-08-20  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2217         earlier.
2218
2219 2019-08-20  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2222
2223 2019-08-20  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-source.h (struct tui_source_window): Update.
2226         * tui/tui-regs.c (tui_show_registers): Update.
2227         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2228         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2229         (NO_REGS_STRING): Remove defines.
2230
2231 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2232
2233         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2234         unnecessary thread walk if remote doesn't support the packet.
2235
2236 2019-08-19  Tom Tromey  <tromey@adacore.com>
2237
2238         * python/py-value.c (value_has_field): Fix indentation.
2239
2240 2019-08-19  Tom Tromey  <tromey@adacore.com>
2241
2242         * printcmd.c (do_one_display, info_display_command): Update.
2243         * block.h (contained_in): Return bool.  Add allow_nested
2244         parameter.
2245         * block.c (contained_in): Return bool.  Add allow_nested
2246         parameter.
2247
2248 2019-08-19  Tom Tromey  <tom@tromey.com>
2249
2250         * configure: Rebuild.
2251         * configure.ac: Disallow the combination of -static-libstdc++ and
2252         source highlight.
2253         * source-cache.c (get_language_name): Handle rust.
2254         (source_cache::get_source_lines): Ignore highlighting exceptions.
2255
2256 2019-08-16  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2259         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2260         (struct tui_source_window_base) <make_visible, refresh_window,
2261         resize>: Remove methods.
2262         <execution_info>: Remove field.
2263         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2264         (tui_show_source_line, tui_source_window_base)
2265         (~tui_source_window_base): Update.
2266         (tui_source_window_base::resize)
2267         (tui_source_window_base::make_visible)
2268         (tui_source_window_base::refresh_window): Remove.
2269         (tui_source_window_base::update_exec_info): Update.
2270         * tui/tui-source.c (tui_source_window::set_contents): Update.
2271         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2272
2273 2019-08-16  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2276         deprecated_query_hook.
2277
2278 2019-08-16  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2281         (tui_update_source_windows_with_line): Update.
2282         * tui/tui-source.h (struct tui_source_window)
2283         <show_symtab_source>: Declare.
2284         (tui_show_symtab_source): Don't declare.
2285         * tui/tui-source.c (tui_show_symtab_source): Rename from
2286         tui_show_symtab_source.
2287
2288 2019-08-16  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (struct tui_source_window_base)
2291         <set_contents>: Declare.
2292         * tui/tui-winsource.c
2293         (tui_source_window_base::update_source_window_as_is): Update.
2294         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2295         Declare.
2296         (tui_set_source_content): Don't declare.
2297         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2298         tui_set_source_content.
2299         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2300         Declare.
2301         (tui_set_disassem_content): Don't declare.
2302         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2303         tui_set_disassem_content.
2304
2305 2019-08-16  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-winsource.h (struct tui_source_window_base)
2308         <update_breakpoint_info>: Declare.
2309         (tui_update_breakpoint_info): Don't declare.
2310         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2311         (tui_update_all_breakpoint_info): Update.
2312         (tui_source_window_base::update_breakpoint_info): Rename from
2313         tui_update_breakpoint_info.
2314         (tui_source_window_base::update_exec_info): Update.
2315
2316 2019-08-16  Tom Tromey  <tom@tromey.com>
2317
2318         * tui/tui-winsource.h (struct tui_source_window_base)
2319         <update_source_window>: Declare.
2320         (tui_update_source_window): Don't declare.
2321         * tui/tui-winsource.c
2322         (tui_source_window_base::update_source_window): Rename from
2323         tui_update_source_window.
2324         (tui_source_window_base::rerender): Update.
2325         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2326         * tui/tui-disasm.c (tui_show_disassem)
2327         (tui_show_disassem_and_update_source)
2328         (tui_disasm_window::maybe_update): Update.
2329
2330 2019-08-16  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-winsource.h (struct tui_source_window_base)
2333         <update_source_window_as_is>: Declare.
2334         (tui_update_source_window_as_is): Don't declare.
2335         * tui/tui-winsource.c (tui_update_source_window): Update
2336         (tui_source_window_base::update_source_window_as_is): Rename from
2337         tui_update_source_window_as_is.
2338         (tui_source_window_base::refill): Update.
2339         * tui/tui-source.c (tui_show_symtab_source): Update.
2340         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2341         Update.
2342
2343 2019-08-16  Tom Tromey  <tom@tromey.com>
2344
2345         * tui/tui-winsource.h (tui_update_source_window)
2346         (tui_update_source_window_as_is): Remove "noerror" parameter.
2347         * tui/tui-winsource.c (tui_update_source_window)
2348         (tui_update_source_window_as_is): Remove "noerror" parameter.
2349         (tui_update_source_windows_with_addr)
2350         (tui_update_source_windows_with_line)
2351         (tui_source_window_base::rerender)
2352         (tui_source_window_base::refill): Update.
2353         * tui/tui-source.h (tui_set_source_content)
2354         (tui_show_symtab_source): Remove "noerror" parameter.
2355         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2356         parameter.
2357         (tui_show_symtab_source): Likewise.
2358         (tui_source_window::maybe_update): Update.
2359         * tui/tui-disasm.c (tui_show_disassem)
2360         (tui_show_disassem_and_update_source)
2361         (tui_disasm_window::do_scroll_vertical)
2362         (tui_disasm_window::maybe_update): Update.
2363
2364 2019-08-16  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui.c (tui_is_window_visible): Update.
2367         * tui/tui-wingeneral.c (tui_make_window)
2368         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2369         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2370         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2371         (tui_set_win_height_command, parse_scrolling_args): Update.
2372         * tui/tui-source.c (tui_source_window::style_changed): Update.
2373         * tui/tui-regs.c (tui_show_registers)
2374         (tui_data_window::first_data_item_displayed)
2375         (tui_data_window::delete_data_content_windows)
2376         (tui_check_register_values, tui_reg_command): Update.
2377         * tui/tui-disasm.c (tui_show_disassem): Update.
2378         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2379         method.
2380         <is_visible>: Remove field.
2381         * tui/tui-data.c (tui_next_win, tui_prev_win)
2382         (tui_delete_invisible_windows): Update.
2383
2384 2019-08-16  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-winsource.h (struct tui_source_window_base)
2387         <m_has_locator>: Remove.
2388         * tui/tui-layout.c (show_source_disasm_command, show_data)
2389         (show_source_or_disasm_and_command): Update.
2390
2391 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2392
2393         * NEWS (Other MI changes): New subsection.
2394         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2395         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2396         * arch-utils.c (default_get_pc_address_flags): New function.
2397         * arch-utils.h (default_get_pc_address_flags): New declaration.
2398         * gdbarch.sh: Add get_pc_address_flags.
2399         * gdbarch.c: Regenerate.
2400         * gdbarch.h: Likewise.
2401         * stack.c (print_pc): New function.
2402         (print_frame_info) (print_frame): Call print_pc.
2403
2404 2019-08-16  Tom de Vries  <tdevries@suse.de>
2405
2406         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2407         print_objfile_section_info.
2408
2409 2019-08-15  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2412         calling update_cmdwin_start_line.
2413         * tui/tui-winsource.h (struct tui_source_window_base)
2414         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2415         <rerender>: Declare.
2416         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2417         Call rerender.
2418         (tui_source_window_base::set_new_height): Remove.
2419         (tui_source_window_base::rerender): Rename from
2420         do_make_visible_with_new_height.
2421         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2422         resize method.
2423         (tui_win_info::make_invisible_and_set_new_height)
2424         (tui_win_info::make_visible_with_new_height): Remove.
2425         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2426         Declare.
2427         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2428         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2429         do_make_visible_with_new_height>: Don't declare.
2430         <rerender>: Declare.
2431         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2432         set_new_height.
2433         (tui_data_window::do_make_visible_with_new_height): Remove.
2434         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2435         call tui_show_locator_content.
2436         (tui_gen_win_info::resize): Call rerender.
2437         (show_source_or_disasm_and_command): Don't call
2438         tui_show_locator_content.
2439         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2440         method.
2441         (struct tui_win_info) <rerender>: Declare.
2442         <set_new_height, make_invisible_and_set_new_height,
2443         make_visible_with_new_height>: Don't declare.
2444         * tui/tui-data.c (tui_win_list::rerender): New method.
2445         * tui/tui-command.h (struct tui_cmd_window)
2446         <do_make_visible_with_new_height>: Don't declare.
2447         * tui/tui-command.c
2448         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2449
2450 2019-08-15  Tom Tromey  <tromey@adacore.com>
2451
2452         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2453         * ada-lang.c (ada_enum_name): Likewise.
2454
2455 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2456
2457         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2458         leading underscore.
2459         (GdbOutputErrorFile): Likewise.
2460         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2461         accordingly.
2462         (execute_unwinders): Rename to have a leading underscore.
2463         (auto_load_packages): Likewise.
2464         (global scope): Adjust call to auto_load_packages accordingly.
2465         (GdbSetPythonDirectory): Likewise.
2466         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2467         instead of execute_unwinders.
2468
2469 2019-08-15  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2472         (show_data): Don't change window visibility.
2473         (tui_gen_win_info::resize): Remove special case for command
2474         window.  Use wresize, when available.
2475         (show_source_or_disasm_and_command): Don't change window
2476         visibility.
2477         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2478         <make_visible>: New method.
2479         * tui/tui-command.c (tui_cmd_window::resize): New method.
2480
2481 2019-08-15  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2484         (struct tui_source_windows): New.
2485         * tui/tui-winsource.c (tui_display_main): Update.
2486         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2487         (new_height_ok, parse_scrolling_args): Update.
2488         * tui/tui-layout.c (show_layout, show_data): Update.
2489         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2490         (tui_add_to_source_windows): Don't declare.
2491         * tui/tui-data.c (source_windows, tui_source_windows)
2492         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2493
2494 2019-08-15  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2497         Rename from reset.
2498         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2499         * tui/tui-layout.c (show_source_disasm_command, show_data):
2500         Update.
2501         (tui_gen_win_info::resize): Rename.
2502         (show_source_or_disasm_and_command): Update.
2503         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2504         reset.
2505
2506 2019-08-15  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2509         * tui/tui-interp.c (tui_interp::init): Don't call
2510         tui_initialize_static_data.
2511         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2512
2513 2019-08-15  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2516         examine tui_win_list.
2517
2518 2019-08-15  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2521         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2522         tui_clear_source_content.
2523         (tui_clear_source_content): Remove.
2524         (tui_source_window_base::do_erase_source_content): Hoist call to
2525         content.clear().
2526         * tui/tui-stack.c (tui_show_frame_info): Don't call
2527         tui_clear_source_content.
2528
2529 2019-08-15  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-winsource.h (struct tui_source_window_base)
2532         <do_erase_source_content>: New method.
2533         <erase_source_content>: New method.
2534         (tui_erase_source_content): Don't declare.
2535         * tui/tui-winsource.c (tui_clear_source_content): Update.
2536         (tui_source_window_base::do_erase_source_content): Rename from
2537         tui_erase_source_content.
2538         (tui_source_window_base::show_source_content): Update.
2539         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2540         * tui/tui-source.h (struct tui_source_window)
2541         <erase_source_content>: New method.
2542         * tui/tui-disasm.h (struct tui_disasm_window)
2543         <erase_source_content>: New method.
2544
2545 2019-08-15  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2548         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2549         constructor.
2550         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2551         * tui/tui-source.c (tui_set_source_content): Update.
2552         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2553
2554 2019-08-15  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2557         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2558         tui-source.c.
2559         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2560         Declare.
2561         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2562         method.
2563         (tui_source_window::maybe_update): Update.
2564
2565 2019-08-15  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2568         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2569         tui-disasm.c.
2570         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2571         Declare.
2572         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2573         method.
2574         (tui_disasm_window::maybe_update): Update.
2575
2576 2019-08-15  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-winsource.h (struct tui_source_window_base)
2579         <maybe_update>: Declare.
2580         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2581         method.
2582         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2583         Declare.
2584         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2585         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2586         Declare.
2587         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2588
2589 2019-08-15  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2592
2593 2019-08-15  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-wingeneral.c: Include tui-stack.h.
2596         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2597         (struct tui_locator_window): Move from tui-data.h.
2598         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2599         (tui_initialize_static_data): Move from tui-data.c.
2600         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2601         (struct tui_locator_window): Move to tui-stack.c.
2602         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2603         (tui_initialize_static_data): Move to tui-stack.c.
2604
2605 2019-08-15  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-layout.c (show_source_disasm_command)
2608         (show_source_or_disasm_and_command): Use make_visible method, not
2609         tui_make_window.
2610         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2611         Remove.
2612
2613 2019-08-15  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-wingeneral.h (tui_make_window): Update.
2616         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2617         parameter.
2618         (tui_gen_win_info::make_visible): Update.
2619         * tui/tui-regs.c (tui_data_window::display_registers_from):
2620         Update.
2621         * tui/tui-layout.c (show_source_disasm_command)
2622         (show_source_or_disasm_and_command): Update.
2623         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2624         (enum tui_box): Remove.
2625         (struct tui_win_info) <can_box>: New method.
2626         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2627         method.
2628
2629 2019-08-15  Tom de Vries  <tdevries@suse.de>
2630
2631         * linux-nat-trad.c: Include gdbarch.h.
2632
2633 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2634
2635         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2636         register sizes.
2637
2638 2019-08-14  Tom Tromey  <tromey@adacore.com>
2639
2640         * darwin-nat.c: Include gdbarch.h.
2641         * darwin-nat-info.c: Include gdbarch.h.
2642
2643 2019-08-13  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2646         Remove.
2647         * tui/tui-data.c (tui_initialize_static_data): Update.
2648
2649 2019-08-13  Tom Tromey  <tom@tromey.com>
2650
2651         * tui/tui-winsource.h (struct tui_exec_info_window)
2652         <~tui_exec_info_window, maybe_allocate_content, get_content,
2653         m_content>: Remove.
2654         (struct tui_source_window_base) <set_exec_info_content,
2655         show_exec_info_content>: Don't declare.
2656         * tui/tui-winsource.c
2657         (tui_exec_info_window::maybe_allocate_content): Remove.
2658         (tui_source_window_base::update_exec_info): Rename from
2659         set_exec_info_content.
2660         (tui_source_window_base::show_exec_info_content)
2661         (tui_source_window_base::update_exec_info): Remove.
2662
2663 2019-08-13  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2666         declare.
2667         * tui/tui-winsource.c (tui_update_source_window_as_is)
2668         (tui_update_source_windows_with_addr, tui_erase_source_content):
2669         Update.
2670         (tui_clear_exec_info_content): Remove.
2671
2672 2019-08-13  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2675         declare.
2676         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2677         call tui_erase_exec_info_content.
2678         (tui_clear_exec_info_content): Rename from
2679         tui_erase_exec_info_content.
2680         (tui_clear_exec_info_content): Delete.
2681
2682 2019-08-13  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-winsource.h (struct tui_source_window_base)
2685         <show_exec_info_content>: Declare.
2686         (tui_show_exec_info_content): Don't declare.
2687         * tui/tui-winsource.c
2688         (tui_source_window_base::show_exec_info_content): Rename from
2689         tui_show_exec_info_content.
2690         (tui_source_window_base::update_exec_info): Update.
2691
2692 2019-08-13  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2695         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2696         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2697         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2698         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2699         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2700         ... here.
2701
2702 2019-08-13  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-winsource.h (struct tui_source_window_base)
2705         <update_exec_info>: Declare.
2706         (tui_update_exec_info): Don't declare.
2707         * tui/tui-winsource.c (tui_update_source_window_as_is)
2708         (tui_source_window_base::refresh_all)
2709         (tui_update_all_breakpoint_info): Update.
2710         (tui_source_window_base::update_exec_info): Rename from
2711         tui_update_exec_info.
2712         * tui/tui-stack.c (tui_show_frame_info): Update.
2713
2714 2019-08-13  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-winsource.h (struct tui_source_window_base)
2717         <set_exec_info_content>: Declare.
2718         (tui_set_exec_info_content): Don't declare.
2719         * tui/tui-winsource.c
2720         (tui_source_window_base::set_exec_info_content): Rename from
2721         tui_set_exec_info_content.
2722         (tui_update_exec_info): Update.
2723
2724 2019-08-13  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-winsource.h (struct tui_source_window_base)
2727         <show_source_content>: Declare.
2728         (tui_show_source_content): Don't declare.
2729         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2730         (tui_source_window_base::show_source_content): Rename from
2731         tui_show_source_content.
2732         (tui_source_window_base::refresh_all): Update.
2733         * tui/tui-layout.c (show_source_disasm_command)
2734         (show_source_or_disasm_and_command): Update.
2735
2736 2019-08-13  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-winsource.c (tui_erase_source_content)
2739         (tui_show_source_content, tui_source_window_base::refresh_all):
2740         Update.
2741         * tui/tui-wingeneral.h
2742         (tui_check_and_display_highlight_if_needed): Don't declare.
2743         * tui/tui-wingeneral.c
2744         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2745         check_and_display_highlight_if_needed.
2746         * tui/tui-win.c (tui_rehighlight_all)
2747         (tui_win_info::make_visible_with_new_height): Update.
2748         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2749         (tui_data_window::erase_data_content)
2750         (tui_data_window::display_all_data): Update.
2751         * tui/tui-data.h (struct tui_win_info)
2752         <check_and_display_highlight_if_needed>: Declare.
2753
2754 2019-08-13  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-win.c (tui_resize_all): Call
2757         tui_delete_invisible_windows.
2758         * tui/tui-layout.c (show_layout): Call
2759         tui_delete_invisible_windows.
2760         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2761         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2762
2763 2019-08-13  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2766         tui_add_win_to_layout.
2767
2768 2019-08-13  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2771         * tui/tui-layout.c (tui_default_win_height): Now static.
2772
2773 2019-08-13  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2776         single switch.
2777         (show_source_disasm_command, show_source_or_disasm_and_command):
2778         Don't check current layout.
2779
2780 2019-08-13  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-wingeneral.c (make_all_visible): Remove.
2783         (tui_make_all_invisible): Simplify.
2784         * tui/tui-layout.c (tui_make_all_invisible): Move from
2785         tui-wingeneral.c; simplify.
2786         (show_layout): Hoist call to tui_make_all_invisible.
2787         (show_data): Don't call tui_make_all_invisible.
2788
2789 2019-08-13  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2792         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2793
2794 2019-08-13  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2797         tui-data.c.
2798         (show_source_disasm_command, show_data)
2799         (show_source_or_disasm_and_command): Don't use
2800         tui_set_current_layout_to.
2801         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2802         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2803         tui-layout.c.
2804         (tui_set_current_layout_to): Remove.
2805
2806 2019-08-13  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-layout.c (tui_set_layout): Update.
2809         * tui/tui-data.h (struct tui_layout_def): Remove.
2810         (tui_layout_def): Don't declare.
2811         * tui/tui-data.c (layout_def): Remove.
2812         (tui_layout_def): Remove.
2813
2814 2019-08-13  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-winsource.h (struct tui_source_window_base)
2817         <clear_detail>: No longer "override".
2818         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2819         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2820         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2821         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2822         Remove.
2823         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2824
2825 2019-08-13  Tom Tromey  <tromey@adacore.com>
2826
2827         * tracepoint.c: Don't include readline.h or history.h.
2828
2829 2019-08-12  Tom Tromey  <tom@tromey.com>
2830
2831         * configure: Rebuild.
2832         * configure.ac: Check for readline 7.
2833         * NEWS: Mention readline 7 requirement.
2834         * README: Update.
2835
2836 2019-08-12  Tom Tromey  <tom@tromey.com>
2837
2838         * mingw-hdep.c (gdb_select): Remove readline hack.
2839
2840 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2841
2842         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2843         when the function fails.
2844
2845 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2846
2847         * s390-tdep.c (s390_type_align): New function.
2848         (s390_gdbarch_init): Set it as type_align gdbarch method.
2849
2850 2019-08-09  Tom de Vries  <tdevries@suse.de>
2851
2852         PR gdb/24591
2853         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2854         pc_low with relocation offset.
2855
2856 2019-08-07  Tom Tromey  <tromey@adacore.com>
2857
2858         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2859         (print_frame_args): Update.
2860         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2861         Update.
2862         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2863         * frame.h (struct frame_arg): Add initializers.
2864         <error>: Now a unique_xmalloc_ptr.
2865
2866 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2867
2868         * NEWS: Expand the Pointer Authentication entry.
2869         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2870         (aarch64_frame_unmask_lr): ... to this.
2871         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2872         Call aarch64_frame_unmask_lr.
2873         * frame.c (struct frame_info): Add "masked" variable.
2874         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2875         (fprint_frame): Check for masked pc.
2876         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2877         declarations.
2878         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2879         * stack.c (print_frame): Check for masked pc.
2880
2881 2019-08-06  Tom Tromey  <tom@tromey.com>
2882
2883         * stabsread.c (patch_block_stabs, read_one_struct_field)
2884         (read_enum_type): Use obstack_strndup.
2885         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2886         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2887         * dwarf2read.c (guess_full_die_structure_name)
2888         (anonymous_struct_prefix): Use obstack_strndup.
2889         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2890         * c-exp.y (yylex): Use obstack_strndup.
2891         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2892         (write_var_or_type): Use obstack_strndup.
2893
2894 2019-08-06  Tom Tromey  <tom@tromey.com>
2895
2896         * symfile.c (reread_symbols): Use obstack_strdup.
2897         * stabsread.c (read_type): Use obstack_strdup.
2898         * gdb_obstack.h (obstack_strdup): New overload.
2899         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2900         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2901         (dwarf2_canonicalize_name): Use obstack_strdup.
2902         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2903         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2904         Use obstack_strdup.
2905
2906 2019-08-06  Tom Tromey  <tom@tromey.com>
2907
2908         * gdb_obstack.h (obstack_strdup): Define.
2909         * gdb_obstack.c (obstack_strdup): Don't define.
2910
2911 2019-08-06  Tom Tromey  <tom@tromey.com>
2912
2913         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2914         obstack_strdup.
2915         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2916         obstack_strdup.
2917         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2918         * stabsread.c (common_block_start): Use obstack_strdup.
2919         * objfiles.c (set_objfile_main_name, objfile): Use
2920         obstack_strdup.
2921         * namespace.c (add_using_directive): Use obstack_strdup.
2922         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2923         * jit.c (finalize_symtab): Use obstack_strdup.
2924         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2925         (guess_partial_die_structure_name, partial_die_info::fixup)
2926         (dwarf2_name): Use obstack_strdup.
2927         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2928         obstack_strdup.
2929         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2930         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2931         obstack_strdup.
2932         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2933
2934 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935
2936         * unittests/help-doc-selftests.c: New file.
2937         * Makefile.in: Add the new file.
2938
2939 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2940
2941         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2942         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2943         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2944         the trailing '.' is not output, and the first character is uppercased.
2945         (print_help_for_command): Update call to print_doc_line.
2946         (print_doc_of_command): Likewise.
2947         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2948         * cli/cli-option.c (append_indented_doc): Do not append newline.
2949         (build_help_option): Append newline after first appended_indented_doc
2950         only if a second call is done.
2951         (build_help): Append 2 new lines before each option, except the first
2952         one.
2953         * compile/compile.c (_initialize_compile): Add new lines after
2954         %OPTIONS%, when not at the end of the help.
2955         Change help doc or code
2956         producing the help doc to respect the invariants.
2957         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2958         Also removed the new line after 'Options:', as all other commands
2959         do not put an empty line between 'Options:' and the first option.
2960         * printcmd.c (_initialize_printcmd): Likewise.
2961         * stack.c (_initialize_stack): Likewise.
2962         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2963         incorrectly telling COMMAND is optional.
2964         * ada-lang.c (_initialize_ada_language): Change help doc or code
2965         producing the help doc to respect the invariants.
2966         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2967         * breakpoint.c (_initialize_breakpoint): Likewise.
2968         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2969         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2970         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2971         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2972         _initialize_cli_style): Likewise.
2973         * corelow.c (core_target_info): Likewise.
2974         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2975         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2976         * filesystem.c (_initialize_filesystem): Likewise.
2977         * frame.c (_initialize_frame): Likewise.
2978         * gnu-nat.c (add_task_commands): Likewise.
2979         * infcall.c (_initialize_infcall): Likewise.
2980         * infcmd.c (_initialize_infcmd): Likewise.
2981         * interps.c (_initialize_interpreter): Likewise.
2982         * language.c (_initialize_language): Likewise.
2983         * linux-fork.c (_initialize_linux_fork): Likewise.
2984         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2985         * maint.c (_initialize_maint_cmds): Likewise.
2986         * memattr.c (_initialize_mem): Likewise.
2987         * printcmd.c (_initialize_printcmd): Likewise.
2988         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2989         _RegEx): Likewise.
2990         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2991         * record-btrace.c (_initialize_record_btrace): Likewise.
2992         * record-full.c (_initialize_record_full): Likewise.
2993         * record.c (_initialize_record): Likewise.
2994         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2995         * regcache.c (_initialize_regcache): Likewise.
2996         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2997         _initialize_remote): Likewise.
2998         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2999         * serial.c (_initialize_serial): Likewise.
3000         * skip.c (_initialize_step_skip): Likewise.
3001         * source.c (_initialize_source): Likewise.
3002         * stack.c (_initialize_stack): Likewise.
3003         * symfile.c (_initialize_symfile): Likewise.
3004         * symtab.c (_initialize_symtab): Likewise.
3005         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3006         * top.c (init_main): Likewise.
3007         * tracefile-tfile.c (tfile_target_info): Likewise.
3008         * tracepoint.c (_initialize_tracepoint): Likewise.
3009         * tui/tui-win.c (_initialize_tui_win): Likewise.
3010         * utils.c (add_internal_problem_command): Likewise.
3011         * valprint.c (value_print_option_defs): Likewise.
3012
3013 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3014
3015         PR build/24886
3016         * configure.ac: Drop enable-libmcheck support.
3017         * configure, config.in: Rebuild.
3018         * libmcheck.m4: Remove.
3019         * acinclude.m4: Don't include it.
3020         * Makefile.in: Don't distribute it.
3021         * top.c (print_gdb_configuration): Don't mention it.
3022
3023 2019-08-06  Tom Tromey  <tom@tromey.com>
3024
3025         * utils.c (set_output_style): Sometimes pass stream to
3026         emit_style_escape.
3027         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3028         * record-btrace.c (btrace_insn_history): Update.
3029         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3030         method.
3031         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3032         Update initializers.
3033         <m_uiout>: New field.
3034         <m_di>: Move lower.
3035         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3036         Remove "uiout" parameter.
3037         (dump_insns): Update.
3038         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3039         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3040
3041 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3042
3043         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3044         (error_in_psymtab_expansion): Likewise.
3045         (lookup_symbol_via_quick_fns): Likewise.
3046         (basic_lookup_transparent_type_quick): Likewise.
3047         (basic_lookup_transparent_type_1): Likewise.
3048
3049 2019-08-06  Tom Tromey  <tromey@adacore.com>
3050
3051         * source.c (last_source_error): Now bool.
3052         (print_source_lines_base): Make "noprint" bool.  Only open
3053         source file when last_source_visited changes.
3054
3055 2019-08-06  Tom Tromey  <tromey@adacore.com>
3056
3057         * annotate.c (annotate_source_line): Use g_source_cache.
3058         * source-cache.c (source_cache::get_plain_source_lines): Change
3059         parameters.  Populate m_offset_cache.
3060         (source_cache::ensure): New method.
3061         (source_cache::get_line_charpos): New method.
3062         (extract_lines): Move lower.  Change parameters.
3063         (source_cache::get_source_lines): Move lower.
3064         * source-cache.h (class source_cache): Update comment.
3065         <get_line_charpos>: New method.
3066         <get_source_lines>: Update comment.
3067         <clear>: Clear m_offset_cache.
3068         <get_plain_source_lines>: Change parameters.
3069         <ensure>: New method
3070         <m_offset_cache>: New member.
3071         * source.c (forget_cached_source_info_for_objfile): Update.
3072         (info_source_command): Use g_source_cache.
3073         (find_source_lines, open_source_file_with_line_charpos): Remove.
3074         (print_source_lines_base, search_command_helper): Use g_source_cache.
3075         * source.h (open_source_file_with_line_charpos): Don't declare.
3076         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3077         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3078         Use g_source_cache.
3079
3080 2019-08-06  Tom Tromey  <tromey@adacore.com>
3081
3082         * source-cache.c (source_cache::get_plain_source_lines):
3083         Remove "first_line" and "last_line" parameters.
3084         (source_cache::get_source_lines): Cache plain text.
3085         * source-cache.h (class source_cache)
3086         <get_plain_source_lines>: Update.
3087
3088 2019-08-06  Tom Tromey  <tromey@adacore.com>
3089
3090         * source-cache.c (extract_lines): No longer a method.
3091         Changed type of parameter.  Include final newline.
3092         (selftests::extract_lines_test): New function.
3093         (_initialize_source_cache): Likewise.
3094         * source-cache.h (class source_cache)
3095         <extract_lines>: Don't declare.
3096
3097 2019-08-06  Tom Tromey  <tromey@adacore.com>
3098
3099         * breakpoint.c (init_breakpoint_sal): Update.
3100         (breakpoint): Update.
3101         * breakpoint.h (struct breakpoint) <filter>: Now a
3102         unique_xmalloc_ptr.
3103
3104 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3105
3106         * NEWS: Mention dictionary access on blocks.
3107         * python/py-block.c (blpy_getitem): New function.
3108         (block_object_as_mapping): New struct.
3109         (block_object_type): Use new struct for tp_as_mapping field.
3110
3111 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3112
3113         * objfiles.h (objfile): Add a comment describing partial symbols.
3114
3115 2019-08-05  Tom Tromey  <tromey@adacore.com>
3116
3117         * compile/compile.c (_initialize_compile): Use _(), not N_().
3118         * thread.c (_initialize_thread): Use _(), not N_().
3119         * stack.c (_initialize_stack): Use _(), not N_().
3120         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3121
3122 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3123
3124         * dwarf2read.c (struct dw2_symtab_iterator):
3125         <want_specific_block>: Remove.
3126         <block_index>: Change type to gdb::optional.
3127         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3128         change type of BLOCK_INDEX parameter to gdb::optional.
3129         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3130         (dw2_lookup_symbol): Don't pass argument for
3131         WANT_SPECIFIC_BLOCK.
3132         (dw2_expand_symtabs_for_function): Don't pass argument for
3133         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3134         (class dw2_debug_names_iterator)
3135         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3136         parameter, change BLOCK_INDEX type to gdb::optional.
3137         <m_want_specific_block>: Remove.
3138         <m_block_index>: Change type to gdb::optional.
3139         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3140         gdb::optional.  Re-write in function of gdb::optional.
3141         (dw2_debug_names_lookup_symbol): Don't pass argument for
3142         WANT_SPECIFIC_BLOCK.
3143         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3144         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3145         BLOCK_INDEX.
3146
3147 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3148
3149         * NEWS: Mention changes to "info sources" command.
3150
3151 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3152
3153         * symtab.c (filename_partial_match_opts): New struct type.
3154         (struct output_source_filename_data): New members
3155         regexp, c_regexp, partial_match.
3156         (output_source_filename): Use new members to decide to print file.
3157         (info_sources_option_defs): New variable.
3158         (make_info_sources_options_def_group, print_info_sources_header,
3159         info_sources_command_completer):
3160         New functions.
3161         (info_sources_command): Read new optional arguments.
3162         (_initialize_symtab): Update info sources help.
3163
3164 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3165
3166         * ada-lang.c (exception_support_info_v0): Renamed from...
3167         (default_exception_support_info): ... this.  Create new
3168         definition for v1.
3169         (ada_has_this_exception_support): Look up catch_handlers_sym.
3170         (ada_exception_support_info_sniffer): Try v0 after default.
3171
3172 2019-08-01  Tom Tromey  <tromey@adacore.com>
3173
3174         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3175         gdbarch.h.
3176
3177 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3178
3179         * s12z-tdep.c: Fix include path for s12z-opc.h.
3180
3181 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3182
3183         * NEWS: Require GNU make 3.82.
3184
3185 2019-07-16  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3188         declare.
3189
3190 2019-07-30  Tom Tromey  <tromey@adacore.com>
3191
3192         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3193
3194 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3195
3196         * printcmd.c (print_address_symbolic): Print negative offsets.
3197         (build_address_symbolic): Force signed arithmetic when computing
3198         offset.
3199
3200 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3201
3202         PR/24474: Add a function to lookup static variables.
3203         * NEWS: Mention this new function.
3204         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3205         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3206         * python/python.c (python_GdbMethods): Add new function.
3207
3208 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3209
3210         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3211         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3212         (objfpy_lookup_static_symbol): New function.
3213         (objfile_object_methods): Add new functions.
3214
3215 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3216
3217         * NEWS: Mention 'set|show print frame-info'.  Mention new
3218         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3219         backtrace argument.  Mention that python frame filtering code
3220         is now consistent with what 'backtrace' command prints.
3221
3222 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3223
3224         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3225         comments.
3226         (print_frame_info_auto, print_frame_info_source_line,
3227         print_frame_info_location, print_frame_info_source_and_location,
3228         print_frame_info_location_and_address, print_frame_info_short_location):
3229         New declarations.
3230         (struct frame_print_options): New member print_frame_info.
3231         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3232         * stack.h (get_user_print_what_frame_info): New declaration.
3233         (frame_show_address): New declaration.
3234         * stack.c (print_frame_arguments_choices): New value 'presence'.
3235         (print_frame_info_auto, print_frame_info_source_line,
3236         print_frame_info_location, print_frame_info_source_and_location,
3237         print_frame_info_location_and_address, print_frame_info_short_location,
3238         print_frame_info_choices, print_frame_info_print_what): New definitions.
3239         (print_frame_args): Only print dots for args if print frame-arguments
3240         is 'presence'.
3241         (frame_print_option_defs): New element for "frame-info".
3242         (get_user_print_what_frame_info): New function.
3243         (frame_show_address): Make non static.  Move comment to stack.h.
3244         (print_frame_info_to_print_what): New function.
3245         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3246         to decide what to print.
3247         (backtrace_command_1): Handle the new print_frame_arguments_presence
3248         value.
3249         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3250         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3251         (py_print_frame): In non-mi mode, use LOCATION as default for
3252         print_what, similarly to frame information printed directly by
3253         backtrace command. Handle frame-info user option in non MI mode.
3254
3255 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3256
3257         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3258         Add case for debugging 32-bit target on 64-bit host.  Revise
3259         comment.
3260
3261 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3262
3263         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3264         instead of find_function_entry_range_from_pc.
3265
3266 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3267
3268         * stack.c (find_frame_funname): Remove code which preferred
3269         minsym over symtab sym in "certain pathological cases".
3270
3271         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3272         parameter.  Change type of "do_demangle" to bool.
3273         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3274         Pass suitable "prefer_sym_over_minsym" flag to
3275         build_address_symbolic().  Don't output "+" for negative offsets.
3276         * printcmd.c (print_address_symbolic): Update invocation of
3277         build_address_symbolic to include a "prefer_sym_over_minsym"
3278         flag.
3279         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3280         Restrict cases in which use of minimal symbol is preferred to that
3281         of a found symbol.  Update comments.
3282
3283         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3284         for entry pc when entry pc is out of range for that FDE.
3285
3286 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3287
3288         PR gdb/24839:
3289         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3290         type.
3291
3292 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3293
3294         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3295         this function's Python signature.
3296
3297
3298 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3299
3300         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3301         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3302         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3303         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3304         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3305
3306
3307 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3308
3309         * h8300-tdep.c (h8300_register_name_common): New.
3310         h8300_register_name): Use h8300_register_name_common.
3311         (h8300s_register_name): Likewise.
3312         (h8300sx_register_name): Likewise.
3313         (h8300h_register_nam): New.
3314         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3315
3316
3317 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3318
3319         * arm-tdep.c (arm_skip_cmse_entry): New function.
3320         (arm_is_sgstubs_section): New function.
3321         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3322
3323 2019-07-22  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3326         Don't self-assign.
3327
3328 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3329
3330         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3331         type_print.
3332
3333 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3336         so that GDB doesn't match any msymbols when searching in the
3337         TYPES_DOMAIN.
3338         (print_symbol_info): Print using typedef_print or type_print based
3339         on the type of the symbol.  Add updated FIXME comment moved from...
3340         (_initialize_symtab): ... move and update FIXME comment to above.
3341
3342 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         * NEWS: Mention adding -q option to "info types".
3345         * symtab.c (struct info_types_options): New struct.
3346         (info_types_options_defs): New variable.
3347         (make_info_types_options_def_group): New function.
3348         (info_types_command): Use gdb::option framework to parse options.
3349         (info_types_command_completer): New function.
3350         (_initialize_symtab): Extend the help text on "info types" and
3351         register command completer.
3352
3353 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3354
3355         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3356         (lookup_symbol_in_objfile): Change int to block_enum and add a
3357         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3358
3359 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3360
3361         * MAINTAINERS (Write After Approval): Add self.
3362
3363 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3366         instruction to the dummy code region.
3367
3368 2019-07-19  Tom Tromey  <tromey@adacore.com>
3369
3370         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3371         (ARGSUSED, PARAMS, __func__): Remove rules.
3372
3373 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3374
3375         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3376         * features/arm/arm-with-iwmmxt.c: Remove.
3377         * features/arm/arm-with-iwmmxt.xml: Remove.
3378         * features/arm/arm-with-m-fpa-layout.c: Remove.
3379         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3380         * features/arm/arm-with-m-vfp-d16.c: Remove.
3381         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3382         * features/arm/arm-with-m.c: Remove.
3383         * features/arm/arm-with-m.xml: Remove.
3384         * features/arm/arm-with-neon.c: Remove.
3385         * features/arm/arm-with-neon.xml: Remove.
3386         * features/arm/arm-with-vfpv2.c: Remove.
3387         * features/arm/arm-with-vfpv2.xml: Remove.
3388         * features/arm/arm-with-vfpv3.c: Remove.
3389         * features/arm/arm-with-vfpv3.xml: Remove.
3390
3391 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3392
3393         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3394
3395 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3396
3397         * arch/aarch32.c (aarch32_create_target_description): Create
3398         target descriptions using features.
3399         * arch/arm.c (arm_create_target_description)
3400         (arm_create_mprofile_target_description): Likewise.
3401         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3402
3403 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3404
3405         * Makefile.in: Add new files.
3406         * aarch32-tdep.c: New file.
3407         * aarch32-tdep.h: New file.
3408         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3409         Call aarch32_read_description.
3410         * arch/aarch32.c: New file.
3411         * arch/aarch32.h: New file.
3412         * arch/arm.c (arm_create_target_description)
3413         (arm_create_mprofile_target_description): New function.
3414         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3415         (arm_create_target_description)
3416         (arm_create_mprofile_target_description): New declaration.
3417         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3418         read_description functions.
3419         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3420         Likewise.
3421         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3422         * arm-tdep.c (tdesc_arm_list): New variable.
3423         (arm_register_g_packet_guesses): Call create description functions.
3424         (arm_read_description) (arm_read_mprofile_description): New
3425         function.
3426         * arm-tdep.h (arm_read_description)
3427         (arm_read_mprofile_description): Add declaration.
3428         * configure.tgt: Add new files.
3429
3430 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3431
3432         * top.c (new_ui_command): Open specified terminal just once.
3433
3434 2019-07-18  Tom Tromey  <tromey@adacore.com>
3435
3436         * symtab.c (main_name): Constify return type.
3437         * symfile.c (set_initial_language): Update.
3438         * symtab.h (main_name): Constify return type.
3439
3440 2019-07-17  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-winsource.c (tui_update_source_window)
3443         (tui_update_source_window_as_is)
3444         (tui_update_source_windows_with_line): Remove return.
3445         * tui/tui-disasm.c (tui_show_disassem)
3446         (tui_show_disassem_and_update_source): Remove return.
3447         * tui/tui.c (tui_reset): Remove return.
3448         * tui/tui-wingeneral.c
3449         (tui_check_and_display_highlight_if_needed): Remove return.
3450
3451 2019-07-17  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3454
3455 2019-07-17  Tom Tromey  <tom@tromey.com>
3456
3457         * tui/tui-winsource.h (struct tui_exec_info_window)
3458         (struct tui_source_window_base): Move from tui-data.h.
3459         * tui/tui-winsource.c: Move many method definitions from
3460         elsewhere.  Remove "structuring" comments.
3461         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3462         (tui_source_window_base::refresh_window): Move to
3463         tui-winsource.c.
3464         * tui/tui-win.c (tui_source_window_base::refresh_all)
3465         (tui_source_window_base::update_tab_width)
3466         (tui_source_window_base::set_new_height)
3467         (tui_source_window_base::do_make_visible_with_new_height): Move to
3468         tui-winsource.c.
3469         * tui/tui-source.h: Update.
3470         * tui/tui-source.c (tui_source_window_base::reset): Move to
3471         tui-winsource.c.
3472         * tui/tui-disasm.h: Update.
3473         * tui/tui-data.h (struct tui_exec_info_window): Move to
3474         tui-winsource.h.
3475         (struct tui_source_window_base): Likewise.
3476         * tui/tui-data.c (tui_source_window_base::clear_detail)
3477         (tui_source_window_base, ~tui_source_window_base): Move to
3478         tui-winsource.c.
3479
3480 2019-07-17  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-win.c (tui_resize_all)
3483         (tui_source_window_base::update_tab_width)
3484         (tui_adjust_win_heights): Update.
3485         (tui_win_info::make_invisible_and_set_new_height): Rename from
3486         make_invisible_and_set_new_height.
3487         * tui/tui-data.h (struct tui_win_info)
3488         <make_invisible_and_set_new_height>: New method.
3489
3490 2019-07-17  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui.c: Update.
3493         * tui/tui-source.h (struct tui_source_window): Move from
3494         tui-data.h.
3495         * tui/tui-layout.c: Update.
3496         * tui/tui-disasm.c: Update.
3497         * tui/tui-data.h (struct tui_source_window): Move to
3498         tui-source.h.
3499
3500 2019-07-17  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3503         tui-data.h.
3504         * tui/tui-data.h (struct tui_disasm_window): Move to
3505         tui-disasm.h.
3506
3507 2019-07-17  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-regs.h (struct tui_data_item_window): Move from
3510         tui-data.h.
3511         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3512         * tui/tui-data.h (struct tui_data_item_window): Move to
3513         tui-regs.h.
3514         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3515
3516 2019-07-17  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui.c: Update.
3519         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3520         (tui_cmd_window::max_height): Move to tui-command.c.
3521         * tui/tui-layout.c: Update.
3522         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3523         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3524         tui-command.c.
3525         * tui/tui-command.h (struct tui_cmd_window): Move from
3526         tui-data.h.
3527         * tui/tui-command.c: Remove "structuring" comments.
3528         (tui_cmd_window::clear_detail)
3529         (tui_cmd_window::do_make_visible_with_new_height)
3530         (tui_cmd_window::max_height): Move from elsewhere.
3531
3532 2019-07-17  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3535         Now static.
3536         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3537         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3538
3539 2019-07-17  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui.c: Update.
3542         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3543         tui-regs.c.
3544         * tui/tui-windata.h: Remove file.
3545         * tui/tui-windata.c: Remove file.
3546         * tui/tui-win.c (tui_data_window::set_new_height)
3547         (tui_data_window::do_make_visible_with_new_height): Move to
3548         tui-regs.c.
3549         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3550         * tui/tui-regs.c: Remove "structuring" comments.
3551         (tui_data_window::first_data_item_displayed)
3552         (tui_data_window::delete_data_content_windows)
3553         (tui_data_window::erase_data_content)
3554         (tui_data_window::display_all_data)
3555         (tui_data_window::refresh_all)
3556         (tui_data_window::do_scroll_vertical)
3557         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3558         (tui_data_window::do_make_visible_with_new_height)
3559         (tui_data_window::refresh_window): Move from elsewhere.
3560         (_initialize_tui_regs): Move to end of file.
3561         * tui/tui-layout.c: Update.
3562         * tui/tui-hooks.c: Update.
3563         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3564         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3565         tui-regs.c.
3566         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3567
3568 2019-07-17  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3571         seen.
3572
3573 2019-07-17  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-win.c (tui_source_window_base::set_new_height)
3576         (tui_source_window_base::do_make_visible_with_new_height): Use
3577         m_has_locator field directly.
3578         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3579         method.
3580         (struct tui_source_window_base) <has_locator>: Likewise.
3581
3582 2019-07-17  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3585         Don't declare.
3586         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3587         Remove.
3588         * tui/tui-win.c (tui_source_window_base::set_new_height)
3589         (tui_source_window_base::set_new_height)
3590         (make_invisible_and_set_new_height)
3591         (tui_source_window_base::do_make_visible_with_new_height)
3592         (tui_source_window_base::do_make_visible_with_new_height):
3593         Update.
3594         * tui/tui-layout.c (show_source_disasm_command, show_data)
3595         (show_source_or_disasm_and_command): Update.
3596         * tui/tui-layout.c (show_layout): Update.
3597
3598 2019-07-17  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-layout.c (make_data_window): Remove.
3601         (show_data): Unify creation and re-initialization cases.
3602
3603 2019-07-17  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-layout.c (make_source_window, make_disasm_window):
3606         Remove.
3607         (show_data): Unify creation and re-initialization cases.
3608
3609 2019-07-17  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-layout.c (make_command_window): Remove.
3612         (show_source_disasm_command, show_source_or_disasm_and_command):
3613         Unify creation and re-initialization cases.
3614
3615 2019-07-17  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3618         creation and re-initialization cases.
3619
3620 2019-07-17  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-regs.c (tui_get_register): Return void.
3623
3624 2019-07-17  Tom Tromey  <tom@tromey.com>
3625
3626         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3627         Simplify.
3628
3629 2019-07-17  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3632         resetting.
3633
3634 2019-07-17  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3637         * tui/tui-regs.c (tui_reg_layout): New function.
3638         (tui_show_registers, tui_reg_command): Use it.
3639         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3640         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3641         parameters.
3642         (tui_layout_command): Remove.
3643
3644 2019-07-17  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-layout.h (tui/tui-layout): Return void.
3647         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3648
3649 2019-07-17  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-layout.c (show_source_disasm_command, show_data):
3652         Update.
3653         (reset_locator): Remove.
3654         (show_source_or_disasm_and_command): Update.
3655
3656 2019-07-17  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-source.c (tui_source_window_base::reset): Remove
3659         win_type parameter.
3660         * tui/tui-layout.c (make_command_window, make_source_window)
3661         (make_disasm_window, make_data_window)
3662         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3663         (reset_locator, show_source_or_disasm_and_command): Update.
3664         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3665         win_type parameter.
3666         (struct tui_source_window_base) <reset>: Likewise.
3667
3668 2019-07-17  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-layout.c (show_source_disasm_command): Use
3671         reset_locator.
3672         (reset_locator): New function.
3673         (init_and_make_win): Remove.
3674         (show_source_or_disasm_and_command): Use reset_locator.
3675
3676 2019-07-17  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3679         condition.
3680         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3681         Remove condition.
3682         * tui/tui-source.c (tui_source_window_base::reset): New method.
3683         * tui/tui-layout.c (make_command_window): Don't call
3684         init_and_make_win.
3685         (make_source_window, make_disasm_window): Don't call
3686         make_source_or_disasm_window.
3687         (make_data_window): Don't call init_and_make_win.  Change calling
3688         convention.
3689         (show_source_disasm_command, show_data): Simplify.
3690         (make_source_or_disasm_window): Remove.
3691         (show_source_or_disasm_and_command): Simplify.
3692         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3693         (struct tui_source_window_base) <reset>: Likewise.
3694         <execution_info>: Remove initializer.
3695         * tui/tui-data.c (tui_source_window_base): Initialize
3696         execution_info.
3697
3698 2019-07-17  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3701         variable.
3702
3703 2019-07-17  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui.c (tui_rl_other_window): Update.
3706         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3707         superclass method first.  Always iterate over regs_content.
3708         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3709         method.
3710         * tui/tui-win.c (tui_set_focus_command): Update.
3711
3712 2019-07-17  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-win.c (tui_set_focus_command): Rename from
3715         tui_set_focus.  Call tui_enable.
3716         (tui_set_focus_command): Remove.
3717
3718 2019-07-17  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3721         refresh_window.
3722         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3723         touchwin.
3724         (tui_data_window::refresh_window): Call refresh_window on data
3725         items.  Always call superclass refresh_window.
3726         (tui_win_info::refresh): Remove.
3727         (tui_source_window_base::refresh_window): Update.
3728         (tui_refresh_all): Update.
3729         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3730         refresh_window.
3731         (show_source_or_disasm_and_command): Likewise.
3732         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3733         (struct tui_source_window_base) <refresh>: Likewise.
3734
3735 2019-07-17  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui-winsource.c (tui_clear_source_content)
3738         (tui_show_source_content): Update.
3739         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3740         whether content is empty.
3741         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3742         Remove.
3743
3744 2019-07-17  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3747         window's contents.
3748         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3749         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3750
3751 2019-07-17  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3754         (struct tui_data_item_window): Update.
3755
3756 2019-07-17  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3759         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3760         defines.
3761
3762 2019-07-17  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-winsource.h (tui_erase_source_content)
3765         (tui_clear_source_content): Remove "display_prompt" parameter.
3766         * tui/tui-winsource.c (tui_update_source_window_as_is)
3767         (tui_update_source_windows_with_addr): Update.
3768         (tui_clear_source_content): Remove "display_prompt" parameter.
3769         (tui_erase_source_content): Likewise.  Simplify.
3770         (tui_show_source_content): Update.
3771         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3772         * tui/tui-stack.c (tui_show_frame_info): Update.
3773         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3774         Remove defines.
3775
3776 2019-07-17  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3779         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3780         parameter.
3781         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3782         parameter.
3783
3784 2019-07-17  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-winsource.c (tui_clear_source_content)
3787         (tui_show_source_content, tui_show_exec_info_content)
3788         (tui_clear_exec_info_content): Update.
3789         * tui/tui-stack.c (tui_show_locator_content): Update.
3790         (tui_show_frame_info): Update.
3791         * tui/tui-source.h (tui_source_window): Don't declare.
3792         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3793         from tui_source_is_displayed.
3794         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3795         Remove field.
3796         (struct tui_source_window_base) <content_in_use>: New field.  Now
3797         bool.
3798         (struct tui_source_window) <showing_source_p>: New method.
3799         (TUI_SRC_WIN): Change cast.
3800         * tui/tui-data.c (tui_initialize_static_data): Update.
3801
3802 2019-07-17  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3805         location_matches_p.
3806         * tui/tui-source.c (tui_source_window::location_matches_p): New
3807         method.
3808         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3809         method.
3810         * tui/tui-data.h (struct tui_source_window_base)
3811         <location_matches_p>: New method.
3812         (struct tui_source_window, struct tui_disasm_window)
3813         <location_matches_p>: Likewise.
3814
3815 2019-07-17  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-win.c (tui_set_win_height_command): Rename from
3818         tui_set_win_height.
3819         (tui_set_win_height_command): Remove.
3820
3821 2019-07-17  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-source.c (tui_source_window): New constructor.  Add
3824         observer.
3825         (~tui_source_window): New destructor.
3826         (tui_source_window::style_changed): New method.
3827         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3828         (tui_attach_detach_observers): Update.
3829         * tui/tui-data.h (struct tui_source_window): Make constructor not
3830         inline.  Add destructor.
3831         (struct tui_source_window) <style_changed>: New method.
3832         <m_observable>: New member.
3833
3834 2019-07-17  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3837         * tui/tui-win.c (tui_resize_all): Fix typo.
3838
3839 2019-07-17  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3842         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3843         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3844         * tui/tui-win.c (window_name_completer): Use foreach.
3845         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3846         (update_tab_width): Likewise.
3847         * tui/tui-layout.c (show_layout): Update.
3848         * tui/tui-data.h (class tui_window_iterator): New.
3849         (struct all_tui_windows): New.
3850         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3851
3852 2019-07-17  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3855         parameter.  Don't reference globals.
3856         (tui_reg_command): Update.
3857
3858 2019-07-17  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-regs.c (tui_show_registers): Simplify.
3861
3862 2019-07-17  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui-regs.c (tui_show_registers): Update.
3865         (tui_show_register_group): Add win_info parameter.
3866
3867 2019-07-17  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3870         Rename from tui_display_reg_element_at_line.
3871         (tui_data_window::display_registers_from_line): Update.
3872         * tui/tui-data.h (struct tui_data_window)
3873         <display_reg_element_at_line>: New method.
3874
3875 2019-07-17  Tom Tromey  <tom@tromey.com>
3876
3877         * tui/tui-regs.h (tui_display_registers_from)
3878         (tui_display_registers_from_line): Don't declare.
3879         * tui/tui-windata.c (tui_data_window::display_all_data)
3880         (tui_data_window::refresh_all)
3881         (tui_data_window::do_scroll_vertical): Update.
3882         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3883         from tui_display_registers_from.
3884         (tui_display_reg_element_at_line): Update.
3885         (tui_data_window::display_registers_from_line): Rename from
3886         tui_display_registers_from_line.
3887         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3888         display_registers_from_line>: New methods.
3889
3890 2019-07-17  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3893         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3894         from tui_erase_data_content.
3895         (tui_data_window::display_all_data)
3896         (tui_data_window::refresh_all)
3897         (tui_data_window::do_scroll_vertical): Update.
3898         * tui/tui-regs.c (tui_show_registers): Update.
3899         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3900         New method.
3901
3902 2019-07-17  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3905         declare.
3906         * tui/tui-windata.c
3907         (tui_data_window::delete_data_content_windows): Rename from
3908         tui_delete_data_content_windows.
3909         (tui_data_window::display_all_data)
3910         (tui_data_window::do_scroll_vertical): Update.
3911         * tui/tui-data.h (struct tui_data_window)
3912         <delete_data_content_windows>: New method.
3913
3914 2019-07-17  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3917         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3918
3919 2019-07-17  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3922         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3923         from tui_display_all_data.
3924         * tui/tui-win.c
3925         (tui_data_window::do_make_visible_with_new_height): Update.
3926         * tui/tui-regs.c (tui_show_registers): Update.
3927         * tui/tui-layout.c (tui_set_layout): Update.
3928         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3929         method.
3930
3931 2019-07-17  Tom Tromey  <tom@tromey.com>
3932
3933         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3934         * tui/tui-windata.c (tui_display_data_from): Remove.
3935         (tui_data_window::refresh_all): Update.
3936
3937 2019-07-17  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3940         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3941         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3942         tui_display_registers_from_line.
3943         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3944         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3945         "force_display" parameter.
3946
3947 2019-07-17  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3950         declare.
3951         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3952         Rename from tui_first_reg_element_no_inline.
3953         (tui_display_reg_element_at_line)
3954         (tui_display_registers_from_line): Update.
3955         * tui/tui-data.h (struct tui_data_window)
3956         <first_reg_element_no_inline>: New method.
3957
3958 2019-07-17  Tom Tromey  <tom@tromey.com>
3959
3960         * tui/tui-windata.c (tui_display_data_from)
3961         (tui_data_window::do_scroll_vertical): Update.
3962         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3963         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3964         Rename from tui_line_from_reg_element_no.
3965         (tui_display_registers_from_line): Update.
3966         * tui/tui-data.h (struct tui_data_window)
3967         <line_from_reg_element_no>: New method.
3968
3969 2019-07-17  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3972         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3973         tui_last_regs_line_no.
3974         (tui_display_reg_element_at_line)
3975         (tui_display_registers_from_line): Update.
3976         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3977         method.
3978
3979 2019-07-17  Tom Tromey  <tom@tromey.com>
3980
3981         PR tui/24722:
3982         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3983         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3984         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3985         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3986         (tui_update_breakpoint_info): Likewise.
3987         * tui/tui-hooks.c (tui_event_create_breakpoint)
3988         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3989         Update.
3990
3991 2019-07-17  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3994
3995 2019-07-17  Tom Tromey  <tom@tromey.com>
3996
3997         * tui/tui-winsource.c (tui_update_source_window_as_is)
3998         (tui_update_source_windows_with_addr): Update.
3999         * tui/tui-source.h (tui_set_source_content)
4000         (tui_show_symtab_source): Add "win_info" parameter.
4001         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4002         parameter.
4003         (tui_show_symtab_source): Likewise.
4004
4005 2019-07-17  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-wingeneral.c
4008         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4009
4010 2019-07-17  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4013         (struct tui_cmd_window) <can_scroll>: New method.
4014         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4015         method.
4016
4017 2019-07-17  Tom Tromey  <tromey@adacore.com>
4018
4019         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4020         do_field_signed>: Rename.  Change type of "value".
4021         * ui-out.c (ui_out::field_signed): Rename from field_int.
4022         Change type of "value".
4023         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4024         type of "value".
4025         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4026         do_field_int.  Change type of "value".
4027         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4028         do_field_int.  Change type of "value".
4029         * tracepoint.c (trace_status_mi, tfind_1)
4030         (print_one_static_tracepoint_marker): Update.
4031         * thread.c (print_thread_info_1, print_selected_thread_frame):
4032         Update.
4033         * stack.c (print_frame, print_frame_info): Update.
4034         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4035         Update.
4036         * source.c (print_source_lines_base): Update.
4037         * skip.c (info_skip_command): Update.
4038         * record-btrace.c (btrace_ui_out_decode_error)
4039         (btrace_call_history_src_line): Update.
4040         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4041         Update.
4042         * progspace.c (print_program_space): Update.
4043         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4044         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4045         do_field_int.  Change type of "value".
4046         * mi/mi-out.c (mi_ui_out::do_table_begin)
4047         (mi_ui_out::do_table_header): Update.
4048         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4049         type of "value".
4050         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4051         (mi_cmd_data_list_changed_registers, output_register)
4052         (mi_cmd_data_read_memory, mi_load_progress)
4053         (mi_cmd_trace_frame_collected): Update.
4054         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4055         Update.
4056         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4057         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4058         (mi_cmd_var_list_children, varobj_update_one): Update.
4059         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4060         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4061         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4062         * inferior.c (print_inferior): Update.
4063         * gdb_bfd.c (print_one_bfd): Update.
4064         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4065         Update.
4066         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4067         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4068         do_field_int.  Change type of "value".
4069         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4070         do_field_int.  Change type of "value".
4071         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4072         (print_one_breakpoint_location, print_it_catch_fork)
4073         (print_one_catch_fork, print_it_catch_vfork)
4074         (print_one_catch_vfork, print_it_catch_solib)
4075         (print_it_catch_exec, print_it_ranged_breakpoint)
4076         (print_mention_watchpoint, print_mention_masked_watchpoint)
4077         (bkpt_print_it, update_static_tracepoint): Update.
4078         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4079         * break-catch-syscall.c (print_it_catch_syscall): Update.
4080         * ada-tasks.c (print_ada_task_info): Update.
4081         * ada-lang.c (print_it_exception, print_mention_exception):
4082         Update.
4083
4084 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         PR breakpoints/24541
4087         * gdbarch.c: Regenerate.
4088         * gdbarch.h: Regenerate.
4089         * gdbarch.sh: Adjust return type and parameter types for
4090         'stap_adjust_register'.
4091         (i386_stap_adjust_register): Adjust signature and return new
4092         register name.
4093         * stap-probe.c (stap_parse_register_operand): Adjust use of
4094         'gdbarch_stap_adjust_register'.
4095
4096 2019-07-17  Tom Tromey  <tromey@adacore.com>
4097
4098         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4099         declare VEC.
4100         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4101         std::vector.
4102         (struct s390_process_info): Add initializers.
4103         (s390_add_process): Use new.
4104         (s390_linux_nat_target::low_forget_process): Use delete.
4105         (s390_linux_nat_target::low_new_fork)
4106         (s390_linux_nat_target::stopped_by_watchpoint)
4107         (s390_linux_nat_target::low_prepare_to_resume)
4108         (s390_linux_nat_target::insert_watchpoint)
4109         (s390_linux_nat_target::insert_hw_breakpoint)
4110         (s390_linux_nat_target::remove_watchpoint)
4111         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4112
4113 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4114
4115         * aarch64-fbsd-nat.c: Include regcache.h.
4116         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4117         argument.
4118         (aarch64_fbsd_nat_target::fetch_registers)
4119         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4120         variable.
4121         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4122
4123 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4124
4125         * fbsd-nat.c: Include gdbarch.h.
4126
4127 2019-07-15  Tom Tromey  <tromey@adacore.com>
4128
4129         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4130
4131 2019-07-15  Tom Tromey  <tromey@adacore.com>
4132
4133         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4134         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4135         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4136         * cli-out.c (cli_ui_out::do_field_int): New method.
4137         * ui-out.c (ui_out::field_unsigned): New method.
4138         * symfile.c (generic_load): Use field_unsigned.
4139         (print_transfer_performance): Likewise.
4140         * record-btrace.c (ui_out_field_uint): Remove.
4141         (btrace_call_history_insn_range, btrace_call_history): Use
4142         field_unsigned.
4143         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4144         field_unsigned.
4145         * ui-out.h (class ui_out) <field_unsigned>: New method.
4146         <do_field_unsigned>: Likewise.
4147
4148 2019-07-15  Tom Tromey  <tromey@adacore.com>
4149
4150         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4151         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4152         * target.c (flash_erase_command): Use field_string.
4153         * infrun.c (print_signal_received_reason): Use field_string.
4154         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4155         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4156         field_string.
4157         * ada-tasks.c (print_ada_task_info): Use field_string.
4158
4159 2019-07-15  Tom Tromey  <tromey@adacore.com>
4160
4161         * target.c (flash_erase_command): Use field_core_addr.
4162         * symfile.c (generic_load): Use field_core_addr.
4163         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4164         Use field_core_addr.
4165         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4166         field_core_addr.
4167
4168 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4171         value if its desired type is smaller than a CORE_ADDR and signed.
4172
4173 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4176         of changes to field names, and use new is_reference field to
4177         decide if a property is a reference or not.
4178         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4179         field.
4180         (struct dwarf2_property_baton): Update header comment, rename
4181         'referenced_type' to 'property_type' and update comments.
4182         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4183         default property type, store in property baton, update to take
4184         accound of renamed field.
4185         (read_func_scope): Update call to attr_to_dynamic_prop.
4186         (read_array_type): Likewise.
4187         (dwarf2_per_cu_addr_sized_int_type): New function.
4188         (read_subrange_index_type): Move type finding code to
4189         dwarf2_per_cu_addr_sized_int_type.
4190         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4191         (dwarf2_per_cu_addr_type): New function.
4192         (set_die_type): Update calls to attr_to_dynamic_prop.
4193
4194 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * dwarf2read.c (read_subrange_index_type): New function.
4197         (read_subrange_type): Move code into new function and call it.
4198         * gdbtypes.c (create_range_type): Add some asserts.
4199
4200 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4203         update return statements.
4204         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4205         declaration, and update comment to match.
4206         * gdbtypes.c (resolve_dynamic_array): Update call to
4207         dwarf2_evaluate_property to match new return type.
4208
4209 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * valarith.c (value_subscripted_rvalue): Change lowerbound
4212         parameter type from int to LONGEST.
4213         * value.h (value_subscripted_rvalue): Likewise in declaration.
4214
4215 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * cli/cli-utils.c (info_print_command_completer): New function.
4218         * cli/cli-utils.h: Add 'completer.h' include, and forward
4219         declaration for 'struct cmd_list_element'.
4220         (info_print_command_completer): Declare.
4221         * stack.c (_initialize_stack): Add completer for 'info locals' and
4222         'info args'.
4223         * symtab.c (_initialize_symtab): Add completer for 'info
4224         variables' and 'info functions'.
4225         * NEWS: Mention completion for additional info commands.
4226
4227 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * cli/cli-utils.c (extract_info_print_args): Delete.
4230         (extract_arg_maybe_quoted): Delete.
4231         (info_print_options_defs): New variable.
4232         (make_info_print_options_def_group): New function.
4233         (extract_info_print_options): Define new function.
4234         * cli/cli-utils.h (extract_info_print_args): Delete.
4235         (struct info_print_options): New structure.
4236         (extract_info_print_options): Declare new function.
4237         * stack.c (info_locals_command): Update to use new
4238         extract_info_print_options, also add a header comment.
4239         (info_args_command): Likewise.
4240         * symtab.c (info_variables_command): Likewise.
4241         (info_functions_command): Likewise.
4242
4243 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4246         to extract string arguments.
4247         * common/common-utils.c (extract_string_maybe_quoted): New function.
4248         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4249
4250 2019-07-11  Tom Tromey  <tromey@adacore.com>
4251
4252         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4253         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4254         * top.h (gdbinit): Don't declare.
4255         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4256         into...
4257         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4258         * top.c (gdb_init): Don't call init_cli_cmds.
4259         (gdbinit): Remove.
4260         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4261
4262 2019-07-11  Tom Tromey  <tromey@adacore.com>
4263
4264         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4265         after it has been moved.
4266
4267 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4268
4269         * valops.c (value_must_coerce_to_target): Change return type to
4270         bool.
4271         * value.h (value_must_coerce_to_target): Likewise.
4272
4273 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4274
4275         * breakpoint.c (is_hardware_watchpoint): Remove
4276         forward-declaration.
4277         (is_masked_watchpoint): Change return type to bool.
4278         (is_tracepoint): Likewise.
4279         (is_breakpoint): Likewise.
4280         (is_hardware_watchpoint): Likewise.
4281         (is_watchpoint): Likewise.
4282         (is_no_memory_software_watchpoint): Likewise.
4283         (is_catchpoint): Likewise.
4284         (breakpoint_1): Make FILTER parameter's return type bool.
4285         is_masked_watchpoint): Change return type to bool.
4286         (save_breakpoints): Make FILTER parameter's return type bool.
4287         * breakpoint.h (is_breakpoint): Change return type to bool.
4288         (is_watchpoint): Likewise.
4289         (is_catchpoint): Likewise.
4290         (is_tracepoint): Likewise.
4291
4292 2019-07-10  Tom Tromey  <tom@tromey.com>
4293
4294         * defs.h: Don't include gdbarch.h.
4295         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4296         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4297         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4298         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4299         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4300         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4301         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4302         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4303         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4304         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4305         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4306         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4307         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4308         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4309         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4310         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4311         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4312         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4313         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4314         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4315         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4316         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4317         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4318         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4319         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4320         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4321         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4322
4323 2019-07-10  Tom Tromey  <tromey@adacore.com>
4324
4325         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4326         * breakpoint.c (init_ada_exception_breakpoint): Register as
4327         bp_catchpoint.
4328         (print_one_breakpoint_location, print_one_breakpoint): Use
4329         is_ada_exception_catchpoint.
4330         * ada-lang.c (class ada_catchpoint_location): Pass
4331         bp_loc_software_breakpoint to bp_location constructor.
4332         (is_ada_exception_catchpoint): New function.
4333
4334 2019-07-10  Tom Tromey  <tromey@adacore.com>
4335
4336         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4337         VEC.
4338         (struct arm_exidx_entry): New method operator<.
4339         (struct arm_exidx_data) <section_maps>: Change type.
4340         (arm_exidx_data_free): Remove.
4341         (arm_exidx_data_key): Change type.  Move lower.
4342         (arm_exidx_new_objfile): Update.
4343         (arm_compare_exidx_entries): Remove.
4344         (arm_find_exidx_entry, _initialize_arm_tdep)
4345
4346 2019-07-10  Tom Tromey  <tromey@adacore.com>
4347
4348         * solib-spu.c (ocl_program_data_key): Change type.
4349         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4350         Update.
4351
4352 2019-07-10  Tom Tromey  <tromey@adacore.com>
4353
4354         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4355         (struct solib_aix_inferior_data) <library_list>: Change type.
4356         (solib_aix_inferior_data_handle): Change type.
4357         (get_solib_aix_inferior_data): Update.
4358         (solib_aix_free_library_list): Remove.
4359         (library_list_start_library): Update.
4360         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4361         return type.
4362         (solib_aix_get_library_list)
4363         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4364         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4365
4366 2019-07-10  Tom Tromey  <tromey@adacore.com>
4367
4368         * solib-dsbt.c (struct dsbt_info): Add initializers.
4369         (solib_dsbt_pspace_data): Change type.
4370         (dsbt_pspace_data_cleanup): Remove.
4371         (get_dsbt_info, _initialize_dsbt_solib): Update.
4372
4373 2019-07-10  Tom Tromey  <tromey@adacore.com>
4374
4375         * spu-tdep.c (spu_overlay_data): Change type.
4376         (spu_get_overlay_table, spu_overlay_new_objfile)
4377         (_initialize_spu_tdep): Update.
4378
4379 2019-07-10  Tom Tromey  <tromey@adacore.com>
4380
4381         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4382         destructor.
4383         (dbx_objfile_data_key): Change type and declare later.
4384         (DBX_SYMFILE_INFO): Rewrite.
4385         * dbxread.c (dbx_objfile_data_key): Change type.
4386         (dbx_symfile_init): Update.
4387         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4388         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4389         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4390
4391 2019-07-10  Tom Tromey  <tromey@adacore.com>
4392
4393         * jit.c (jit_program_space_key): Change type.  Move lower.
4394         (get_jit_program_space_data): Update.
4395         (jit_program_space_data_cleanup): Remove.
4396         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4397         Update.
4398         (struct jit_program_space_data): Add initializers.
4399
4400 2019-07-10  Tom Tromey  <tromey@adacore.com>
4401
4402         * solib-darwin.c (struct darwin_info): Add initializers.
4403         (solib_darwin_pspace_data): Change type.
4404         (darwin_pspace_data_cleanup): Remove.
4405         (get_darwin_info, _initialize_darwin_solib): Update.
4406
4407 2019-07-10  Tom Tromey  <tromey@adacore.com>
4408
4409         * remote-sim.c (struct sim_inferior_data): Add initializers,
4410         constructor, and destructor.
4411         (sim_inferior_data_key): Change type.  Move lower.
4412         (check_for_duplicate_sim_descriptor): Update.
4413         (get_sim_inferior_data): Use new.  Update.
4414         (~sim_inferior_data_cleanup): Rename from
4415         sim_inferior_data_cleanup.  Simplify.
4416         (gdbsim_close_inferior, simulator_command)
4417         (sim_command_completer, _initialize_remote_sim): Update.
4418         (next_pid, INITIAL_PID): Move earlier.
4419
4420 2019-07-10  Tom Tromey  <tromey@adacore.com>
4421
4422         * python/python-internal.h (create_thread_object): Return
4423         gdbpy_ref.
4424         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4425         * python/py-inferior.c (struct threadlist_entry): Add
4426         constructor.
4427         <thread_obj>: Now a gdbpy_ref.
4428         (thread_to_thread_object): Update.
4429         (add_thread_object): Use new.
4430         (delete_thread_object): Use delete.
4431         (infpy_threads): Update.
4432         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4433         GIL.
4434
4435 2019-07-10  Tom Tromey  <tromey@adacore.com>
4436
4437         * valops.c (value_cast): Specialize error message for Ada.
4438
4439 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4440
4441         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4442
4443 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4444
4445         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4446         bpstat_should_step): Return bool, adjust comments.
4447         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4448         bpstat_should_step): Likewise.
4449
4450 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4451
4452         * features/Makefile: Use feature target descriptions for Arm.
4453         * features/arm/arm-core.c: Generate new file.
4454         * features/arm/arm-fpa.c: Likewise.
4455         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4456         * features/arm/arm-m-profile.c: Likewise.
4457         * features/arm/arm-vfpv2.c: Likewise.
4458         * features/arm/arm-vfpv3.c: Likewise.
4459         * features/arm/xscale-iwmmxt.c: Likewise.
4460         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4461
4462 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4463
4464         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4465         ptrace earlier.
4466
4467 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4468
4469         * features/aarch64-pauth.c: Regenerate.
4470
4471 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4472
4473         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4474         bool.
4475         (bpstat_what): Use false instead of 0.
4476
4477 2019-07-09  Pedro Alves  <palves@redhat.com>
4478
4479         * break-catch-throw.c (is_exception_catchpoint): New.
4480         * breakpoint.c (print_one_breakpoint_location): New parameter
4481         'raw_loc'.  Handle it.  Use
4482         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4483         looking at the breakpoint's type.
4484         (print_one_breakpoint): If handling "maint info breakpoints", also
4485         print locations of exception catchpoints.
4486         * breakpoint.h (is_exception_catchpoint): Declare.
4487
4488 2019-07-09  Pedro Alves  <palves@redhat.com>
4489
4490         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4491         "addr" field.
4492         (allocate_location_exception_catchpoint): New.
4493         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4494         (initialize_throw_catchpoint_ops): Install
4495         allocate_location_exception_catchpoint as allocate_location
4496         method.
4497         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4498         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4499         bp_loc_other.
4500         (breakpoint_address_is_meaningful): Delete.
4501         (bl_address_is_meaningful): New.
4502         (breakpoint_locations_match): Adjust comment.
4503         (bp_location_from_bp_type): New, factored out of...
4504         (bp_location::bp_location(breakpoint *)): ... this.
4505         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4506         factored out of...
4507         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4508         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4509         breakpoint_address_is_meaningful.
4510         (bp_locations_compare): Adjust comment.
4511         (update_global_location_list): Use bl_address_is_meaningful
4512         instead of breakpoint_address_is_meaningful.
4513         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4514         explicit.
4515         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4516         * python/py-breakpoint.c (bppy_get_location): No longer check
4517         whether location is null.
4518
4519 2019-07-09  Pedro Alves  <palves@redhat.com>
4520
4521         PR c++/15468
4522         * breakpoint.c (print_one_breakpoint_location): Remove
4523         single-location assert.
4524
4525 2019-07-09  Tom Tromey  <tom@tromey.com>
4526
4527         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4528         * configure: Rebuild.
4529         * configure.ac: Change common to gdbsupport.
4530         * gdbsupport: Rename from common.
4531         * acinclude.m4: Change common to gdbsupport.
4532         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4533         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4534         gdbsupport.
4535         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4536         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4537         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4538         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4539         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4540         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4541         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4542         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4543         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4544         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4545         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4546         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4547         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4548         coff-pe-read.c, command.h, compile/compile-c-support.c,
4549         compile/compile-c.h, compile/compile-cplus-symbols.c,
4550         compile/compile-cplus-types.c, compile/compile-cplus.h,
4551         compile/compile-loc2c.c, compile/compile.c, completer.c,
4552         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4553         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4554         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4555         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4556         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4557         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4558         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4559         features/aarch64-core.c, features/aarch64-fpu.c,
4560         features/aarch64-pauth.c, features/aarch64-sve.c,
4561         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4562         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4563         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4564         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4565         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4566         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4567         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4568         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4569         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4570         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4571         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4572         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4573         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4574         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4575         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4576         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4577         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4578         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4579         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4580         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4581         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4582         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4583         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4584         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4585         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4586         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4587         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4588         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4589         minsyms.c, mips-linux-tdep.c, namespace.h,
4590         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4591         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4592         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4593         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4594         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4595         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4596         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4597         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4598         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4599         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4600         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4601         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4602         procfs.c, producer.c, progspace.h, psymtab.h,
4603         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4604         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4605         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4606         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4607         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4608         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4609         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4610         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4611         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4612         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4613         target-memory.c, target.c, target.h, target/waitstatus.c,
4614         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4615         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4616         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4617         unittests/array-view-selftests.c,
4618         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4619         unittests/common-utils-selftests.c,
4620         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4621         unittests/format_pieces-selftests.c,
4622         unittests/function-view-selftests.c,
4623         unittests/lookup_name_info-selftests.c,
4624         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4625         unittests/mkdir-recursive-selftests.c,
4626         unittests/observable-selftests.c,
4627         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4628         unittests/parse-connection-spec-selftests.c,
4629         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4630         unittests/scoped_fd-selftests.c,
4631         unittests/scoped_mmap-selftests.c,
4632         unittests/scoped_restore-selftests.c,
4633         unittests/string_view-selftests.c, unittests/style-selftests.c,
4634         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4635         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4636         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4637         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4638         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4639         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4640
4641 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4644         bool value.
4645         (decode_digits_ordinary): Set explicit_line field in sal.
4646         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4647         symtab_and_line that was set on an explicit line number in
4648         assembler code.  Do always update the recorded symtab and line if
4649         we do skip the prologue.
4650
4651 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * breakpoint.c (set_breakpoint_location_function): Remove
4654         explicit_loc parameter.
4655         (momentary_breakpoint_from_master): Update call to
4656         set_breakpoint_location_function.
4657         (add_location_to_breakpoint): Likewise.
4658
4659 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4662         required features based on default bfd type when no specific bfd
4663         is present.
4664
4665 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4666
4667         * NEWS: Mention that GDB printf and eval commands can now print
4668         C-style and Ada-style convenience var strings without
4669         calling the inferior.
4670         * printcmd.c (printf_c_string): Locally print GDB internal var
4671         instead of transiting via the inferior.
4672         (printf_wide_c_string): Likewise.
4673
4674 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4675
4676         PR breakpoints/25011
4677         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4678
4679 2019-07-04  Tom Tromey  <tom@tromey.com>
4680
4681         PR tui/24724:
4682         * tui/tui-winsource.c (tui_clear_source_content): Update.
4683         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4684         (tui_update_breakpoint_info): Update.
4685         (tui_set_exec_info_content): Update.
4686         * tui/tui-source.c (tui_set_source_content_nil): Update.
4687         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4688         has_break.
4689         * tui/tui-data.h (enum tui_bp_flag): New.
4690         (tui_bp_flags): New enum flags type.
4691         (struct tui_source_element) <break_mode>: Change type.  Rename
4692         from has_break.
4693         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4694         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4695         constants.
4696         * tui/tui-winsource.h: Fix comment.
4697
4698 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4699
4700         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4701         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4702         (store_fpregs_to_thread)
4703         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4704         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4705         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4706         (IWMMXT_REGS_SIZE): Add define.
4707         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4708         (fetch_vfp_regs, store_vfp_regs)
4709         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4710         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4711
4712 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4713
4714         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4715         defines.
4716         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4717         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4718         (ARM_INT_REGISTER_SIZE): ...to this.
4719         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4720         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4721         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4722         (arm_linux_collect_gregset, supply_nwfpe_register)
4723         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4724         defines.
4725         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4726         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4727         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4728         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4729         (arm_return_in_memory, arm_store_return_value)
4730         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4731         (arm_record_ld_st_multiple): Likewise.
4732         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4733         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4734
4735 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4736
4737         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4738         AARCH64_DISPLACED_MODIFIED_INSNS.
4739         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4740         (aarch64_displaced_step_copy_insn): Likewise.
4741         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4742         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4743         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4744         ARM_DISPLACED_MODIFIED_INSNS.
4745         * arm-tdep.c (arm_gdbarch_init): Likewise.
4746         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4747         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4748         (struct arm_displaced_step_closure): Use
4749         ARM_DISPLACED_MODIFIED_INSNS.
4750
4751 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4752
4753         * features/Makefile: Remove unused xml files.
4754         * features/aarch64.xml: Remove.
4755         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4756         * features/i386/amd64-avx-avx512.xml: Remove.
4757         * features/i386/amd64-avx-linux.xml: Remove.
4758         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4759         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4760         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4761         * features/i386/amd64-avx-mpx.xml: Remove.
4762         * features/i386/amd64-avx.xml: Remove.
4763         * features/i386/amd64-linux.xml: Remove.
4764         * features/i386/amd64-mpx-linux.xml: Remove.
4765         * features/i386/amd64-mpx.xml: Remove.
4766         * features/i386/amd64.xml: Remove.
4767         * features/i386/i386-avx-avx512-linux.xml: Remove.
4768         * features/i386/i386-avx-avx512.xml: Remove.
4769         * features/i386/i386-avx-linux.xml: Remove.
4770         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4771         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4772         * features/i386/i386-avx-mpx-linux.xml: Remove.
4773         * features/i386/i386-avx-mpx.xml: Remove.
4774         * features/i386/i386-avx.xml: Remove.
4775         * features/i386/i386-linux.xml: Remove.
4776         * features/i386/i386-mmx-linux.xml: Remove.
4777         * features/i386/i386-mmx.xml: Remove.
4778         * features/i386/i386-mpx-linux.xml: Remove.
4779         * features/i386/i386-mpx.xml: Remove.
4780         * features/i386/i386.xml: Remove.
4781         * features/i386/x32-avx-avx512-linux.xml: Remove.
4782         * features/i386/x32-avx-linux.xml: Remove.
4783         * features/i386/x32-linux.xml: Remove.
4784
4785 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4786
4787         * regformats/aarch64.dat: Remove.
4788         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4789         * regformats/i386/amd64-avx-linux.dat: Remove.
4790         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4791         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4792         * regformats/i386/amd64-linux.dat: Remove.
4793         * regformats/i386/amd64-mpx-linux.dat: Remove.
4794         * regformats/i386/amd64.dat: Remove.
4795         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4796         * regformats/i386/i386-avx-linux.dat: Remove.
4797         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4798         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4799         * regformats/i386/i386-linux.dat: Remove.
4800         * regformats/i386/i386-mmx-linux.dat: Remove.
4801         * regformats/i386/i386-mpx-linux.dat: Remove.
4802         * regformats/i386/i386.dat: Remove.
4803         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4804         * regformats/i386/x32-avx-linux.dat: Remove.
4805         * regformats/i386/x32-linux.dat: Remove.
4806
4807 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4808
4809         * aarch64-tdep.c: Remove xml self tests.
4810         * amd64-linux-tdep.c: Likewise.
4811         * amd64-tdep.c: Likewise.
4812         * i386-linux-tdep.c: Likewise.
4813         * i386-tdep.c: Likewise.
4814
4815 2019-07-03  Pedro Alves  <palves@redhat.com>
4816
4817         PR cli/24732
4818         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4819         (pipe_cmd_option_defs): New.
4820         (make_pipe_cmd_options_def_group): New.
4821         (pipe_command): Use gdb::option::process_options.
4822         (pipe_command_completer): New function.
4823         (_initialize_cli_cmds): Install completer for "pipe" command.
4824
4825 2019-07-03  Pedro Alves  <palves@redhat.com>
4826
4827         * cli/cli-option.c (union option_value) <string>: New field.
4828         (struct option_def_and_value): Add ctor, move ctor, dtor and
4829         use DISABLE_COPY_AND_ASSIGN.
4830         (option_def_and_value::clear_value): New.
4831         (parse_option, save_option_value_in_ctx, get_val_type_str)
4832         (add_setshow_cmds_for_options): Handle var_string.
4833         * cli-option.h (union option_def::var_address) <string>: New
4834         field.
4835         (struct string_option_def): New.
4836         * maint-test-options.c (struct test_options_opts): Add default
4837         ctor and use DISABLE_COPY_AND_ASSIGN.
4838         <string_opt>: New field.
4839         (test_options_opts::~test_options_opts): New.
4840         (test_options_opts::dump): Also dump "-string".
4841         (test_options_option_defs): Install "string.
4842
4843 2019-07-03  Pedro Alves  <palves@redhat.com>
4844
4845         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4846         option_value with a null enumeration.
4847         (complete_options): Save the option values in the context.
4848         (save_option_value_in_ctx): New, factored out from ...
4849         (process_options): ... here.
4850         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4851         of the function.
4852         * maint-test-options.c (test_options_opts::dump): New, factored
4853         out from ...
4854         (maintenance_test_options_command_mode): ... here.
4855         (maintenance_test_options_command_completion_result): Delete.
4856         (maintenance_test_options_command_completion_text): Update
4857         comment.
4858         (maintenance_show_test_options_completion_result): Change
4859         prototype.  Just print
4860         maintenance_test_options_command_completion_text.
4861         (save_completion_result): New.
4862         (maintenance_test_options_completer_mode): Pass options context to
4863         complete_options, and then save a dump.
4864         (_initialize_maint_test_options): Use add_cmd to install "maint
4865         show test-options-completion-result".
4866
4867 2019-07-03  Pedro Alves  <palves@redhat.com>
4868
4869         * NEWS (New commands): Mention "with" and "maint with".
4870         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4871         (with_command, with_command_completer): New.
4872         (pipe_command): Adjust to new repeat_previous
4873         interface.
4874         (_initialize_cli_cmds): Install the "with" command and its "w"
4875         alias.
4876         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4877         declarations.
4878         * cli/cli-setshow.c (parse_cli_var_uinteger)
4879         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4880         argument strings for all var_types.
4881         (get_setshow_command_value_string): New, factored out from ...
4882         (do_show_command): ... this.
4883         * cli/cli-setshow.h: Include <string>.
4884         (get_setshow_command_value_string): Declare.
4885         * command.h (repeat_previous): Now returns const char *.  Adjust
4886         comment.
4887         * maint.c: Include "cli/cli-cmds.h".
4888         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4889         (_initialize_maint_cmds): Register the "maintenance with" command.
4890         * top.c (repeat_previous): Move bits from pipe_command here:
4891         Return the saved command line, if any; error out if there's no
4892         command to relaunch.
4893
4894 2019-07-03  Pedro Alves  <palves@redhat.com>
4895
4896         * NEWS (New commands): Mention "maint set/show test-settings"
4897         instead of "maint test-settings".
4898         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4899         (maintenance_test_settings_set_list): Rename to ...
4900         (maintenance_set_test_settings_list): ... this.
4901         (maintenance_test_settings_show_list): Rename to  ...
4902         (maintenance_show_test_settings_list): ... this.
4903         (maintenance_test_settings_cmd): Delete.
4904         (maintenance_test_settings_set_cmd): ...
4905         (maintenance_set_test_settings_cmd): ... this.
4906         (maintenance_test_settings_show_cmd): ...
4907         (maintenance_show_test_settings_cmd): ... this.
4908         (maintenance_test_settings_show_value_cmd):
4909         (maintenance_show_test_settings_value_cmd): ... this.
4910         (_initialize_maint_test_settings): No longer install the "maint
4911         test-settings" prefix command.  Rename "maint test-settings set"
4912         to "maint set test-settings", and "maint test-settings show" to
4913         "maint show test-settings".  Adjust all subcommands.
4914
4915 2019-07-03  Pedro Alves  <palves@redhat.com>
4916
4917         * maint-test-settings.c: Fix file's intro comment.  Replace all
4918         references to "test-options" with references to "test-settings",
4919         in comments.
4920
4921 2019-07-03  Pedro Alves  <palves@redhat.com>
4922
4923         * maint-test-settings.c (maintenance_test_settings_xxx)
4924         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4925         New.
4926         (maintenance_test_settings_enums): Use them.
4927         (maintenance_test_settings_enum): Default to
4928         maintenance_test_settings_xxx.
4929         (_initialize_maint_test_settings): Initialize
4930         MAINTENANCE_TEST_SETTINGS_FILENAME.
4931
4932 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4933
4934         * breakpoint.h (remove_breakpoints_inf): Change return type to
4935         void, move function documentation here.
4936         * breakpoint.c (remove_breakpoints_inf): Change return type to
4937         void, move function documentation to header.
4938
4939 2019-07-02  Pedro Alves  <palves@redhat.com>
4940
4941         * NEWS (Completion improvements): Mention "info threads".
4942         * thread.c (struct info_threads_opts, info_threads_option_defs)
4943         (make_info_threads_options_def_group): New.
4944         (info_threads_command): Use gdb::option::process_options.
4945         (info_threads_command_completer): New.
4946         (_initialize_thread): Use gdb::option::build_help to build the
4947         help text for "info threads".
4948
4949 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4950
4951         * defs.h (generic_load): Move from here...
4952         * symfile.h (generic_load): ... to here.  Rename name parameter
4953         to args.
4954         * symfile.c (generic_load): Add comment.
4955
4956 2019-07-01  Tom Tromey  <tromey@adacore.com>
4957
4958         * dwarf2read.c
4959         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4960         declaration of without_params.  Fix formatting.
4961
4962 2019-07-01  Tom Tromey  <tromey@adacore.com>
4963
4964         * ada-exp.y (find_primitive_type): Update.
4965         * ada-lang.h (ada_lookup_symbol): Update.
4966         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4967         parameter.
4968         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4969
4970 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4971
4972         PR breakpoints/24541
4973         * gdbarch.c: Regenerate.
4974         * gdbarch.h: Regenerate.
4975         * gdbarch.sh: Add 'stap_adjust_register'.
4976         * i386-tdep.c: Include '<unordered_set>'.
4977         (i386_stap_adjust_register): New function.
4978         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4979         * stap-probe.c (stap_parse_register_operand): Call
4980         'gdbarch_stap_adjust_register'.
4981
4982 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4983
4984         PR python/24742
4985         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4986         * python/python.c (do_start_initialization): Use 'xmalloc'
4987         instead of 'PyMem_Malloc'.
4988
4989 2019-06-28  Tom Tromey  <tromey@adacore.com>
4990
4991         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4992         for Ada.
4993
4994 2019-06-27  Tom Tromey  <tromey@adacore.com>
4995
4996         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4997         objfile_key.
4998         (arm_find_mapping_symbol, arm_record_special_symbol)
4999         (_initialize_arm_tdep): Update.
5000         (arm_objfile_data_free): Remove.
5001
5002 2019-06-27  Tom Tromey  <tromey@adacore.com>
5003
5004         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5005         to cp_print_static_field.
5006
5007 2019-06-26  Tom Tromey  <tromey@adacore.com>
5008
5009         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5010         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5011         declare.
5012
5013 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5014
5015         * features/aarch64-core.c (create_feature_aarch64_core):
5016         Regenerate.
5017         * features/aarch64-core.xml: Add cpsr flags.
5018
5019 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5020
5021         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5022         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5023
5024 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5025
5026         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5027         field.
5028         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5029         use.
5030         (arm_record_special_symbol): Don't insert new symbol in sorted
5031         position, push it at the end.
5032
5033 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5034
5035         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5036         (arm_mapping_symbol_s): Remove.
5037         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5038         (arm_mapping_symbol_vec): New typedef.
5039         (struct arm_per_objfile): Add constructor.
5040         <section_maps>: Change type to
5041         std::unique_ptr<arm_mapping_symbol_vec[]>.
5042         (arm_compare_mapping_symbols): Remove.
5043         (arm_find_mapping_symbol): Adjust to section_maps type change.
5044         (arm_objfile_data_free): Call delete on arm_per_objfile.
5045         (arm_record_special_symbol): Adjust to section_maps type change.
5046         Allocate arm_per_objfile with new.
5047
5048 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5049
5050         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5051         with the command prefix.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5056         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5057
5058 2019-06-25  Tom Tromey  <tom@tromey.com>
5059
5060         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5061         type.
5062         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5063         protected.
5064
5065 2019-06-25  Tom Tromey  <tom@tromey.com>
5066
5067         * tui/tui-winsource.c
5068         (tui_source_window_base::set_is_exec_point_at): Add check against
5069         LOA_ADDRESS.
5070
5071 2019-06-25  Tom Tromey  <tom@tromey.com>
5072
5073         * tui/tui-source.c (tui_set_source_content): Don't check before
5074         xfree.
5075         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5076
5077 2019-06-25  Tom Tromey  <tom@tromey.com>
5078
5079         * tui/tui-winsource.h (tui_update_source_window_as_is)
5080         (tui_alloc_source_buffer, tui_line_is_displayed)
5081         (tui_addr_is_displayed): Change type of win_info.
5082         * tui/tui-winsource.c (tui_update_source_window_as_is)
5083         (tui_clear_source_content, tui_show_source_line)
5084         (tui_show_source_content, tui_source_window_base::refill)
5085         (tui_source_window_base::set_is_exec_point_at)
5086         (tui_source_window_base::set_is_exec_point_at)
5087         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5088         (tui_alloc_source_buffer, tui_line_is_displayed)
5089         (tui_addr_is_displayed): Change type of win_info.  Update.
5090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5091         (tui_source_window_base::do_make_visible_with_new_height):
5092         Update.
5093         * tui/tui-source.c (tui_set_source_content)
5094         (tui_set_source_content_nil)
5095         (tui_source_window::do_scroll_vertical): Update.
5096         * tui/tui-layout.c (show_layout): Update.
5097         * tui/tui-disasm.c (tui_set_disassem_content)
5098         (tui_disasm_window::do_scroll_vertical): Update.
5099         * tui/tui-data.h (tui_win_content): Remove.
5100         (struct tui_gen_win_info) <content, content_size>: Remove.
5101         (struct tui_source_element): Add initializers and destructor.
5102         (union tui_which_element, struct tui_win_element): Remove.
5103         (struct tui_source_window_base) <content>: New field.
5104         (struct tui_data_window): Remove destructor.
5105         (tui_alloc_content, tui_free_win_content)
5106         (tui_free_all_source_wins_content): Don't declare.
5107         * tui/tui-data.c (tui_initialize_static_data): Update.
5108         (init_content_element, tui_alloc_content): Remove.
5109         (~tui_gen_win_info): Update.
5110         (~tui_data_window, tui_free_all_source_wins_content)
5111         (tui_free_win_content, free_content, free_content_elements):
5112         Remove.
5113
5114 2019-06-25  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-winsource.h (tui_clear_source_content)
5117         (tui_erase_source_content, tui_show_source_content): Change type
5118         of win_info.
5119         * tui/tui-winsource.c (tui_clear_source_content)
5120         (tui_erase_source_content, tui_show_source_content): Change type
5121         of win_info.
5122         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5123         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5124         win_info.
5125         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5126         win_info.
5127         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5128
5129 2019-06-25  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-winsource.c (tui_clear_source_content)
5132         (tui_source_window_base::set_is_exec_point_at): Update.
5133         * tui/tui-source.c (tui_set_source_content_nil): Update.
5134         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5135         a bool.
5136         * tui/tui-data.c (init_content_element): Update.
5137
5138 2019-06-25  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5141         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5142         * tui/tui-layout.c (init_and_make_win): Update.
5143         * tui/tui.h (enum tui_win_type): Update.
5144         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5145         tui_win_is_auxillary.
5146         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5147         tui_win_is_auxillary.
5148
5149 2019-06-25  Tom Tromey  <tom@tromey.com>
5150
5151         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5152         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5153         (tui_delete_data_content_windows, tui_display_all_data)
5154         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5155         Update.
5156         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5157         * tui/tui-regs.c (tui_last_regs_line_no)
5158         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5159         (tui_show_registers): Update.
5160         (tui_show_register_group): Return void.  Update.
5161         (tui_display_registers_from, tui_display_reg_element_at_line)
5162         (tui_display_registers_from_line, tui_check_register_values):
5163         Update.
5164         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5165         member.
5166         (struct tui_data_window) <regs_content>: Now a std::vector.
5167         <regs_content_count>: Remove.
5168         (tui_add_content_elements, tui_free_data_content): Don't declare.
5169         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5170         (init_content_element): Remove DATA_WIN case.  Add assert.
5171         (tui_add_content_elements): Remove.
5172         (tui_data_window): Update.
5173         (tui_free_data_content): Remove.
5174         (free_content_elements): Remove DATA_WIN case.
5175
5176 2019-06-25  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-data.c (tui_data_item_window): Update.
5179         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5180         * tui/tui-windata.c (tui_display_all_data)
5181         (tui_display_data_from_line): Update.
5182         (tui_check_data_values): Remove.
5183         * tui/tui-regs.c (tui_show_register_group)
5184         (tui_display_reg_element_at_line): Update.
5185         * tui/tui-hooks.c (tui_register_changed)
5186         (tui_refresh_frame_and_register_information): Call
5187         tui_check_register_values.
5188         * tui/tui-data.h (struct tui_data_window) <data_content,
5189         data_content_count, data_type>: Remove.
5190         (enum tui_data_type): Remove.
5191
5192         * tui/tui-data.c (tui_data_window::clear_detail)
5193         (~tui_data_window): Update.
5194
5195 2019-06-25  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5198         declare.
5199         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5200         Rename from tui_first_data_item_displayed.  Update.
5201         (tui_data_window::refresh_all)
5202         (tui_data_window::do_scroll_vertical): Update.
5203         * tui/tui-data.h (struct tui_data_window)
5204         <first_data_item_displayed>: Declare new method.
5205
5206 2019-06-25  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5209         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5210         contents...
5211         (tui_initialize_static_data): ...here.
5212
5213 2019-06-25  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5216         (tui_display_registers_from, tui_check_register_values): Update.
5217         (tui_display_register): Remove win_info parameter; update.
5218         (tui_get_register): Change type of parameters.
5219         * tui/tui-data.h (struct tui_data_element): Remove.
5220         (union tui_which_element) <data>: Remove.
5221         <data_window>: Change type.
5222         (struct tui_data_item_window): New.
5223         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5224         case.  Add assert.
5225         (~tui_data_item_window): New destructor.
5226         (free_content_elements): Remove DATA_ITEM_WIN case.
5227
5228 2019-06-25  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5231         Remove.
5232
5233 2019-06-25  Tom Tromey  <tom@tromey.com>
5234
5235         * tui/tui-data.h (struct tui_command_element): Remove.
5236         (union tui_which_element) <command>: Remove.
5237         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5238         assert.
5239         (free_content_elements): Remove CMD_WIN case.
5240
5241 2019-06-25  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-layout.c (tui_set_layout): Update.
5244         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5245         * tui/tui-data.c (layout_def): Update.
5246
5247 2019-06-25  Tom Tromey  <tom@tromey.com>
5248
5249         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5250         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5251         (tui_source_window_base::set_new_height): Update.
5252         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5253         Update.
5254         (tui_set_locator_fullname, tui_set_locator_info)
5255         (tui_show_frame_info): Update.
5256         * tui/tui-source.c (tui_set_source_content)
5257         (tui_source_is_displayed): Update.
5258         * tui/tui-layout.c (show_source_disasm_command, show_data)
5259         (show_source_or_disasm_and_command): Update.
5260         * tui/tui-disasm.c (tui_set_disassem_content)
5261         (tui_get_begin_asm_address): Update.
5262         * tui/tui-data.h (struct tui_locator_element): Remove.
5263         (union tui_which_element) <locator>: Remove.
5264         (struct tui_locator_window): New.
5265         (tui_locator_win_info_ptr): Change return type.
5266         * tui/tui-data.c (_locator): Change type.
5267         (tui_locator_win_info_ptr): Change return type.
5268         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5269         (tui_alloc_content): Add assert.
5270
5271 2019-06-25  Tom Tromey  <tom@tromey.com>
5272
5273         * tui/tui-winsource.c
5274         (tui_exec_info_window::maybe_allocate_content): New method.
5275         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5276         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5277         (make_source_or_disasm_window): Add cast.
5278         * tui/tui-data.h (union tui_which_element) <simple_string>:
5279         Remove.
5280         (struct tui_source_info): New.
5281         (struct tui_source_window_base) <execution_info>: Change type.
5282         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5283         case, and add assert.
5284         (tui_alloc_content): Add assert.
5285
5286 2019-06-25  Tom Tromey  <tom@tromey.com>
5287
5288         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5289         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5290         * tui/tui-data.c (tui_alloc_win_info): Remove.
5291
5292 2019-06-25  Tom Tromey  <tom@tromey.com>
5293
5294         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5295         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5296         can_highlight.
5297
5298 2019-06-25  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5301         make_visible_with_new_height method.
5302         (tui_win_info::make_visible_with_new_height): New method.
5303         (tui_source_window_base::do_make_visible_with_new_height)
5304         (tui_data_window::do_make_visible_with_new_height)
5305         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5306         (make_visible_with_new_height): Remove.
5307         (tui_resize_all, tui_adjust_win_heights): Use
5308         make_visible_with_new_height method.
5309         * tui/tui-data.h (struct tui_win_info)
5310         <do_make_visible_with_new_height, make_visible_with_new_height>:
5311         New methods.
5312         (struct tui_source_window_base, struct tui_data_window)
5313         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5314         methods.
5315
5316 2019-06-25  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5319         method.
5320         (update_tab_width): Call update_tab_width method.
5321         * tui/tui-data.h (struct tui_win_info)
5322         (struct tui_source_window_base) <update_tab_width>: New methods.
5323
5324 2019-06-25  Tom Tromey  <tom@tromey.com>
5325
5326         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5327         parameter.
5328         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5329         parameter.
5330         (tui_gen_win_info::make_visible): Update.
5331         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5332         parameter.
5333         * tui/tui-data.h (enum tui_box): New enum.
5334         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5339         init_and_make_win for EXEC_INFO_WIN.
5340         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5341         longer inline.
5342         (struct tui_win_info) <~tui_win_info>: Inline.
5343         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5344         Don't declare.
5345         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5346         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5347         Remove.
5348         (tui_initialize_static_data): Update.
5349         (~tui_gen_win_info): Handle more cleanup here.
5350         (~tui_source_window_base): Delete "execution_info".
5351         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-layout.c (make_command_window): Don't set
5356         can_highlight.
5357         (show_source_disasm_command): Call the reset method.
5358         (show_data): Don't set can_highlight.  Call the reset method.
5359         (tui_gen_win_info::reset): Rename from init_gen_win_info
5360         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5361         (show_source_or_disasm_and_command): Call the reset method.
5362         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5363         (struct tui_cmd_window): Set can_highlight.
5364
5365 2019-06-25  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5368         from make_visible.
5369         (tui_make_visible, tui_make_invisible): Rewrite.
5370         (tui_win_info::make_visible): Remove.
5371         (tui_source_window_base::make_visible): Update.
5372         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5373         method.  Moved from...
5374         (struct tui_win_info) <make_visible>: ...here.
5375
5376 2019-06-25  Tom Tromey  <tom@tromey.com>
5377
5378         * tui/tui-winsource.c
5379         (tui_source_window_base::do_scroll_horizontal): Remove direction
5380         parameter.
5381         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5382         direction parameter.
5383         * tui/tui-win.c (tui_win_info::forward_scroll)
5384         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5385         (tui_win_info::right_scroll): Update.
5386         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5387         direction parameter.
5388         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5389         direction parameter.
5390         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5391         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5392         Remove direction parameter.
5393         (struct tui_source_window_base, struct tui_source_window)
5394         (struct tui_disasm_window, struct tui_data_window)
5395         (struct tui_cmd_window): Update.
5396
5397 2019-06-25  Tom Tromey  <tom@tromey.com>
5398
5399         * tui/tui-winsource.h (tui_set_exec_info_content)
5400         (tui_show_exec_info_content, tui_erase_exec_info_content)
5401         (tui_clear_exec_info_content, tui_update_exec_info): Change
5402         argument to tui_source_window_base.
5403         * tui/tui-winsource.c (tui_set_exec_info_content)
5404         (tui_show_exec_info_content, tui_erase_exec_info_content)
5405         (tui_clear_exec_info_content, tui_update_exec_info): Change
5406         argument to tui_source_window_base.
5407
5408 2019-06-25  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5411         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5412
5413 2019-06-25  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5416         check.
5417
5418 2019-06-25  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5421         type to void.
5422         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5423         type to void.
5424         * tui/tui-source.c (tui_set_source_content): Update.
5425         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5426
5427 2019-06-25  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-win.c (window_name_completer, tui_set_focus)
5430         (tui_all_windows_info): Use name method.
5431         * tui/tui-data.h (struct tui_gen_win_info)
5432         (struct tui_source_window, struct tui_disasm_window)
5433         (struct tui_data_window, struct tui_cmd_window) <name>: New
5434         method.
5435         (tui_win_name): Don't declare.
5436         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5437         (tui_win_name): Remove.
5438
5439 2019-06-25  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-winsource.h (tui_update_source_window)
5442         (tui_update_source_window_as_is): Change parameter type.
5443         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5444         to be a tui_source_window_base.
5445         (tui_update_source_window_as_is): Likewise.
5446         * tui/tui-win.c (make_visible_with_new_height): Update.
5447
5448 2019-06-25  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-winsource.c (tui_erase_source_content)
5451         (tui_show_source_content, tui_show_exec_info_content)
5452         (tui_erase_exec_info_content): Use refresh_window method.
5453         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5454         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5455         from tui_refresh_win.
5456         (tui_data_window::refresh_window): New method.
5457         (tui_win_info::refresh, tui_source_window_base::refresh)
5458         (tui_refresh_all): Use refresh_window method.
5459         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5460         method.
5461         * tui/tui-regs.c (tui_display_register): Call refresh_window
5462         method.
5463         * tui/tui-layout.c (show_source_disasm_command)
5464         (show_source_or_disasm_and_command): Call refresh_window method.
5465         * tui/tui-data.h (struct tui_gen_win_info)
5466         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5467         New method.
5468
5469 2019-06-25  Tom Tromey  <tom@tromey.com>
5470
5471         * tui/tui.c (tui_rl_other_window, tui_enable)
5472         (tui_is_window_visible, tui_get_command_dimension): Update.
5473         * tui/tui-winsource.c (tui_update_source_window_as_is)
5474         (tui_clear_source_content, tui_erase_source_content)
5475         (tui_show_source_line, tui_source_window_base::refill)
5476         (tui_source_window_base::do_scroll_horizontal)
5477         (tui_source_window_base::set_is_exec_point_at)
5478         (tui_update_breakpoint_info, tui_set_exec_info_content)
5479         (tui_alloc_source_buffer, tui_line_is_displayed)
5480         (tui_addr_is_displayed): Update.
5481         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5482         (tui_check_and_display_highlight_if_needed)
5483         (tui_win_info::make_visible, tui_win_info::refresh)
5484         (tui_refresh_all): Update.
5485         * tui/tui-windata.c (tui_first_data_item_displayed)
5486         (tui_delete_data_content_windows, tui_erase_data_content)
5487         (tui_display_all_data, tui_data_window::refresh_all)
5488         (tui_check_data_values): Update.
5489         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5490         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5491         (tui_win_info::backward_scroll, tui_refresh_all_win)
5492         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5493         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5494         (tui_source_window_base::set_new_height)
5495         (tui_data_window::set_new_height)
5496         (make_invisible_and_set_new_height)
5497         (make_visible_with_new_height, new_height_ok)
5498         (parse_scrolling_args): Update.
5499         * tui/tui-stack.c (tui_show_frame_info): Update.
5500         * tui/tui-source.c (tui_set_source_content)
5501         (tui_set_source_content_nil, tui_source_is_displayed)
5502         (tui_source_window::do_scroll_vertical): Update.
5503         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5504         (tui_display_registers_from, tui_display_reg_element_at_line)
5505         (tui_check_register_values, tui_reg_command): Update.
5506         * tui/tui-layout.c (tui_default_win_height)
5507         (show_source_disasm_command, show_data, init_and_make_win)
5508         (show_source_or_disasm_and_command): Update.
5509         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5510         (tui_redisplay_readline, tui_mld_flush)
5511         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5512         (tui_getc): Update.
5513         * tui/tui-disasm.c (tui_set_disassem_content)
5514         (tui_disasm_window::do_scroll_vertical): Update.
5515         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5516         Now virtual.
5517         (struct tui_win_info): Derive from tui_gen_win_info.
5518         <~tui_win_info>: Mark as override.
5519         <generic>: Remove member.
5520         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5521         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5522         (~tui_data_window, ~tui_win_info)
5523         (tui_free_all_source_wins_content): Update.
5524         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5525
5526 2019-06-25  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-layout.c (init_and_make_win): Use new.
5529         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5530         destructor, initializers.
5531         (tui_alloc_generic_win_info): Don't declare.
5532         * tui/tui-data.c (_locator): Add argument to constructor.
5533         (source_win, disasm_win): New globals.
5534         (exec_info): Remove.
5535         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5536         Update.
5537         (tui_alloc_generic_win_info): Remove.
5538         (init_content_element): Use new.
5539         (tui_win_info::tui_win_info): Update.
5540         (free_content_elements) <case DATA_WIN>: Use delete.
5541
5542 2019-06-25  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5545         * tui/tui-windata.c (tui_first_data_item_displayed)
5546         (tui_delete_data_content_windows): Update.
5547         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5548         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5549         (tui_display_registers_from, tui_check_register_values): Update.
5550         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5551         pointer.
5552         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5553         window.
5554         (tui_free_data_content): Update.
5555         (free_content_elements) <case DATA_WIN>: Free the window.
5556
5557 2019-06-25  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5560         Update.
5561         * tui/tui-layout.c (make_command_window)
5562         (show_source_disasm_command, show_data, init_and_make_win)
5563         (show_source_or_disasm_and_command): Update.
5564         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5565         method.
5566         <can_highight, is_highlighted>: Now bool.
5567         (tui_set_win_highlight): Don't declare.
5568         * tui/tui-data.c (tui_set_win_highlight): Remove.
5569
5570 2019-06-25  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-wingeneral.c (make_visible): Remove check of window
5573         type.
5574
5575 2019-06-25  Tom Tromey  <tom@tromey.com>
5576
5577         * tui/tui-win.c (tui_win_info::max_height)
5578         (tui_cmd_window::max_height): New methods.
5579         (new_height_ok): Call max_height.
5580         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5581         <max_height>: New method.
5582
5583 2019-06-25  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-win.c (tui_source_window_base::set_new_height)
5586         (tui_data_window::set_new_height): New methods.
5587         (make_invisible_and_set_new_height): Call set_new_height method.
5588         * tui/tui-data.h (struct tui_win_info)
5589         (struct tui_source_window_base, struct tui_data_window)
5590         <set_new_height>: New method.
5591
5592 2019-06-25  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5595         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5596         tui_refresh_data_win.
5597         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5598         method.
5599         (tui_refresh_all_win): Call the refresh_all method.
5600         (tui_set_focus): Likewise.
5601         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5602         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5603         Likewise.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-winsource.h (tui_refill_source_window)
5608         (tui_set_is_exec_point_at): Don't declare.
5609         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5610         (tui_source_window_base::refill): Rename from
5611         tui_refill_source_window.
5612         (tui_source_window_base::do_scroll_horizontal): Update.
5613         (tui_source_window_base::set_is_exec_point_at): Rename from
5614         tui_set_is_exec_point_at.
5615         (tui_update_all_breakpoint_info): Update.
5616         * tui/tui-stack.c (tui_show_frame_info): Update.
5617         * tui/tui-layout.c (show_data): Add cast.
5618         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5619         * tui/tui-data.h (struct tui_source_window_base) <refill,
5620         set_is_exec_point_at>: New methods.
5621         (tui_source_windows, tui_add_to_source_windows): Update types.
5622         (tui_add_to_source_windows): Remove redundant declaration.
5623         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5624         (tui_source_windows): Change return type.
5625         (tui_clear_source_windows_detail): Update.
5626         (tui_add_to_source_windows): Change type of parameter.
5627         (tui_free_all_source_wins_content): Update.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-wingeneral.c (tui_win_info::refresh)
5632         (tui_source_window_base::refresh): New methods.
5633         (tui_refresh_all): Call the refresh method.
5634         * tui/tui-data.h (struct tui_win_info)
5635         (struct tui_source_window_base) <refresh>: New method.
5636
5637 2019-06-25  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui.h (tui_is_window_visible): Return bool.
5640         * tui/tui.c (tui_is_window_visible): Return bool.
5641         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5642         (tui_make_visible, tui_make_invisible)
5643         (tui_win_info::make_visible)
5644         (tui_source_window_base::make_visible, make_all_visible)
5645         (tui_make_all_visible, tui_make_all_invisible): Update.
5646         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5647         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5648         bool.
5649         (struct tui_win_info, struct tui_source_window_base)
5650         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5651         * tui/tui-data.c (tui_init_generic_part): Update.
5652
5653 2019-06-25  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5656         (tui_source_window_base::make_visible): New methods.
5657         (make_all_visible): Make method call.
5658         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5659         (struct tui_source_window_base, struct tui_cmd_window): Override
5660         make_visible.
5661         (tui_win_is_source_type): Don't declare.
5662         * tui/tui-data.c (tui_win_is_source_type): Remove.
5663
5664 2019-06-25  Tom Tromey  <tom@tromey.com>
5665
5666         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5667         NULL check.
5668
5669 2019-06-25  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5672         Inline constructor.  Add initializers for members.
5673         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5674         constructors; now inline in class.
5675
5676 2019-06-25  Tom Tromey  <tom@tromey.com>
5677
5678         * tui/tui-regs.c (tui_show_registers): Update.
5679         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5680         bool.
5681         * tui/tui-data.c (tui_data_window::clear_detail)
5682         (tui_data_window): Update.
5683
5684 2019-06-25  Tom Tromey  <tom@tromey.com>
5685
5686         * tui/tui-windata.c (tui_display_all_data)
5687         (tui_display_data_from_line, tui_display_data_from)
5688         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5689         Update.
5690         * tui/tui-regs.c (tui_last_regs_line_no)
5691         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5692         (tui_show_registers, tui_show_register_group)
5693         (tui_display_registers_from, tui_display_reg_element_at_line)
5694         (tui_display_registers_from_line, tui_check_register_values)
5695         (tui_reg_next, tui_reg_prev): Update.
5696         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5697         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5698         tui_data_window.
5699         (struct tui_win_info) <detail>: Remove.  Add new fields from
5700         tui_data_info.
5701         (TUI_DATA_WIN): Add cast.
5702         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5703         (~tui_data_window): Simplify.
5704
5705 2019-06-25  Tom Tromey  <tom@tromey.com>
5706
5707         * tui/tui-layout.c (show_source_disasm_command)
5708         (show_source_or_disasm_and_command): Update.
5709         * tui/tui-io.c (update_cmdwin_start_line)
5710         (tui_redisplay_readline): Update.
5711         * tui/tui-data.h (struct tui_command_info): Remove.
5712         (struct tui_win_info) <detail>: Remove command_info member.
5713         (struct tui_data_window) <start_line>: New member, from
5714         tui_command_info.
5715         (TUI_CMD_WIN): Add casts.
5716
5717 2019-06-25  Tom Tromey  <tom@tromey.com>
5718
5719         * tui/tui-winsource.c (tui_update_source_window)
5720         (tui_refill_source_window)
5721         (tui_source_window_base::do_scroll_horizontal)
5722         (tui_update_breakpoint_info, tui_set_exec_info_content)
5723         (tui_show_exec_info_content, tui_erase_exec_info_content)
5724         (tui_clear_exec_info_content): Update.
5725         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5726         Update.
5727         * tui/tui-win.c (make_invisible_and_set_new_height)
5728         (make_visible_with_new_height): Update.
5729         * tui/tui-source.c (tui_set_source_content)
5730         (tui_show_symtab_source): Update.
5731         * tui/tui-layout.c (extract_display_start_addr)
5732         (show_source_disasm_command, show_data)
5733         (make_source_or_disasm_window)
5734         (show_source_or_disasm_and_command): Update.
5735         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5736         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5737         "gdbarch".
5738         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5739         to tui_source_window_base.
5740         (struct tui_win_info) <detail>: Remove source_info member.
5741         (struct tui_source_window_base) <has_locator>: Inline.
5742         Move contents from tui_source_info; rename has_locator member to
5743         m_has_locator.
5744         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5745         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5746         header file.
5747         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5748         Simplify.
5749         (tui_free_all_source_wins_content): Cast to
5750         tui_source_window_base.
5751
5752 2019-06-25  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-win.c (make_invisible_and_set_new_height)
5755         (make_visible_with_new_height): Call has_locator method.
5756         * tui/tui-layout.c (show_source_disasm_command, show_data)
5757         (show_source_or_disasm_and_command): Update for bool change.
5758         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5759         (tui_win_info) <has_locator>: New method.
5760         (struct tui_source_window_base) <has_locator>: New method.
5761         (tui_win_has_locator): Don't declare.
5762         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5763         from tui_win_has_locator.
5764         (tui_source_window_base): Use false, not FALSE.
5765
5766 2019-06-25  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5769         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5770         clear_detail method directly.
5771         (tui_clear_win_detail): Remove.
5772
5773 2019-06-25  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5776         "this", not TUI_DISASM_WIN.
5777
5778 2019-06-25  Tom Tromey  <tom@tromey.com>
5779
5780         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5781         declare.
5782         * tui/tui-winsource.c
5783         (tui_source_window_base::do_scroll_horizontal): Rename from
5784         tui_horizontal_source_scroll.
5785         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5786         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5787         from tui_vertical_data_scroll.
5788         * tui/tui-win.h (tui_scroll): Don't declare.
5789         * tui/tui-win.c (tui_win_info::forward_scroll)
5790         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5791         (tui_win_info::right_scroll): Rename and update.
5792         (tui_scroll_forward_command, tui_scroll_backward_command)
5793         (tui_scroll_left_command, tui_scroll_right_command): Update.
5794         (tui_scroll): Remove.
5795         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5796         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5797         from tui_vertical_source_scroll.
5798         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5799         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5800         from tui_vertical_disassem_scroll.
5801         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5802         do_scroll_horizontal>: New methods.
5803         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5804         Likewise.
5805         (struct tui_source_window_base): Add do_scroll_horizontal.
5806         (struct tui_source_window, struct tui_disasm_window): Add
5807         do_scroll_vertical.
5808         (struct tui_data_window, struct tui_cmd_window): Add
5809         do_scroll_horizontal and do_scroll_vertical.
5810         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-data.h (struct tui_source_window_base): New struct.
5815         (struct tui_source_window): Derive from tui_source_window_base.
5816         (struct tui_disasm_window): New struct.
5817         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5818         from tui_source_window::clear_detail.
5819         (tui_source_window_base): Rename from tui_source_window.
5820         (~tui_source_window_base): Rename from ~tui_source_window.
5821         (tui_alloc_win_info): Create a tui_disasm_window.
5822
5823 2019-06-25  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-data.h (struct tui_source_window)
5826         (struct tui_data_window): Declare destructors.
5827         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5828         destructors.
5829         (tui_win_info): Simplify.
5830
5831 2019-06-25  Tom Tromey  <tom@tromey.com>
5832
5833         * tui/tui-winsource.c (tui_display_main)
5834         (tui_update_source_windows_with_addr)
5835         (tui_update_all_breakpoint_info): Update.
5836         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5837         (new_height_ok, parse_scrolling_args): Update.
5838         * tui/tui-stack.c (tui_show_frame_info): Update.
5839         * tui/tui-data.h (struct tui_list): Remove.
5840         (tui_source_windows): Return a reference to a std::vector.
5841         * tui/tui-data.c (source_windows): Now a std::vector.
5842         (tui_source_windows): Change return type.
5843         (tui_clear_source_windows): Rewrite.
5844         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5845         (tui_free_all_source_wins_content): Rewrite.
5846
5847 2019-06-25  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5850         (struct tui_data_window, struct tui_cmd_window): Declare
5851         clear_detail method.
5852         * tui/tui-data.c (tui_source_window::clear_detail)
5853         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5854         methods.
5855         (tui_clear_win_detail): Simplify.
5856
5857 2019-06-25  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-layout.c (make_source_window, make_disasm_window)
5860         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5861         Return the new window.
5862         (show_source_disasm_command, show_data)
5863         (show_source_or_disasm_and_command): Update.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5868         parameter.  Return the new window.
5869         (show_source_disasm_command): Update and remove NULL check.
5870         (show_source_or_disasm_and_command): Update.
5871
5872 2019-06-25  Tom Tromey  <tom@tromey.com>
5873
5874         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5875
5876 2019-06-25  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-data.h (struct tui_win_info): Make constructor
5879         protected.  Make destructor virtual.  Add initializers.
5880         (tui_source_window, tui_data_window, tui_cmd_window): New
5881         classes.
5882         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5883         constructor.  Add "type" parameter.
5884         (tui_source_window, tui_data_window, tui_cmd_window): New
5885         constructors.
5886         (tui_alloc_win_info): Instantiate the appropriate subclass.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-win.c (tui_resize_all): Use delete.
5891         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5892         destructor.
5893         (tui_free_window): Don't declare.
5894         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5895         Update.
5896
5897 2019-06-25  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-data.h (struct tui_win_info): Add constructor.
5900         * tui/tui-data.c (tui_alloc_win_info): Use new.
5901         (tui_free_window): Use delete.
5902
5903 2019-06-22  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5906         declare.
5907         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5908
5909 2019-06-22  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5912         declare.
5913         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5914
5915 2019-06-22  Tom de Vries  <tdevries@suse.de>
5916
5917         * dwarf2read.c (create_addrmap_from_aranges)
5918         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5919         instead of '%zu'.
5920
5921 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5922
5923         * dwarf2read.h (dwarf2_section_info_def): Remove.
5924         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5925         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5926         std::vector<dwarf2_section_info>.
5927         (struct dwo_file) <~dwo_file>: Remove.
5928         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5929         types field.
5930         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5931         (dwarf2_read_debug_names): Likewise.
5932         (create_debug_types_hash_table): Change parameter type to
5933         array_view, adjust code accordingly.
5934         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5935         (partial_die_info::fixup): Likewise.
5936         (determine_prefix): Likewise.
5937         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5938
5939 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5940
5941         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5942         gdb_bfd_ref_ptr.
5943         <~dwo_file>: Remove call to gdb_bfd_unref.
5944         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5945         gdb_bfd_ref_ptr::get.
5946
5947 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5948
5949         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5950         type to htab_up.
5951         * dwarf2read.c (struct dwo_file): Initialize fields.
5952         <~dwo_file>: New.
5953         (free_dwo_file): Remove, move content to ~dwo_file.
5954         (struct dwo_file_deleter): Remove.
5955         (dwo_file_up>: Remove custom deleter.
5956         (free_dwo_files): Remove.
5957         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5958         dwo_files.
5959         (process_skeletonless_type_units): Call unique_ptr::get.
5960         (allocate_dwo_file_hash_table): Add deleter to created hash
5961         table.  Change return type to htab_up.
5962         (lookup_dwo_file_slot): Don't memset dwo_file, call
5963         unique_ptr::get.
5964         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5965         (create_dwo_unit_in_dwp_v2): Likewise.
5966         (open_and_init_dwo_file): Likewise.
5967         (free_dwo_file_from_slot): Remove.
5968
5969 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5970
5971         * dwarf2read.h (struct dwarf2_section_info) <readin,
5972         is_virtual>: Change type to bool.
5973         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5974         true instead of 1.
5975
5976 2019-06-19  Tom Tromey  <tom@tromey.com>
5977
5978         * tui/tui-data.h (tui_init_content_element): Don't declare.
5979
5980 2019-06-19  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-data.h (tui_init_win_info): Don't declare.
5983
5984 2019-06-19  Tom de Vries  <tdevries@suse.de>
5985
5986         * dwarf2read.h (abstract_to_concrete): Change type to
5987         std::unordered_map<sect_offset, std::vector<sect_offset>,
5988         gdb::hash_enum<sect_offset>>.
5989
5990 2019-06-19  Tom Tromey  <tromey@adacore.com>
5991
5992         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5993         EVAL_AVOID_SIDE_EFFECTS specially.
5994
5995 2019-06-19  Tom Tromey  <tromey@adacore.com>
5996
5997         * source-cache.c (highlighter): New global.
5998         (source_cache::get_source_lines): Create a highlighter on demand.
5999
6000 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * defs.h (deprecated_interactive_hook): Delete declaration.
6003         * interps.c (clear_interpreter_hooks): Remove use of
6004         deprecated_interactive_hook.
6005         * top.c (deprecated_interactive_hook): Delete definition.
6006         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6007
6008 2019-06-18  Tom de Vries  <tdevries@suse.de>
6009
6010         PR gdb/24515
6011         * dwarf2read.h (abstract_to_concrete): Change type from
6012         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6013         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6014         * dwarf2read.c (read_variable): Update.
6015         (dwarf2_fetch_die_loc_sect_off): Update.
6016
6017 2019-06-17  Tom de Vries  <tdevries@suse.de>
6018
6019         PR gdb/24617
6020         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6021         accessing parent[parent_len - 1].
6022
6023 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6024
6025         PR gdb/24364
6026         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6027         call dtrace_process_dof with NULL dof.
6028
6029 2019-06-16  Tom de Vries  <tdevries@suse.de>
6030
6031         PR gdb/24445
6032         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6033
6034 2019-06-16  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6037         (make_all_visible): Use address of member.
6038
6039 2019-06-16  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6042         (tui_free_window, free_content, free_content_elements): Remove
6043         unnecessary cast.
6044         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6045         cast.
6046         * tui/tui-regs.c (tui_show_register_group)
6047         (tui_display_registers_from, tui_display_reg_element_at_line):
6048         Remove unnecessary cast.
6049
6050 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * linux-nat.c (normal_mask): Delete.
6053         (_initialize_linux_nat): Don't initialise normal_mask.
6054
6055 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6056
6057         PR gdb/24445
6058         * dwarf-index-write.h (write_psymtabs_to_index): Add
6059         dwz_basename parameter.
6060         * dwarf-index-write.c (write_gdbindex): Move file writing to
6061         write_gdbindex_1.  Change return type void.
6062         (assert_file_size): Move up, remove filename parameter.
6063         (write_gdbindex_1): New function.
6064         (write_debug_names): Change return type to void, call
6065         assert_file_size.
6066         (struct index_wip_file): New struct.
6067         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6068         file logic to index_wip_file.  Write index for dwz file if
6069         needed.
6070         (save_gdb_index_command): Pass basename of dwz file, if present.
6071         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6072         build-id of dwz file, if present.
6073         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6074         (dwarf2_get_dwz_file): Likewise.
6075         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6076         (dwarf2_get_dwz_file): Likewise.
6077
6078 2019-06-16  Tom Tromey  <tom@tromey.com>
6079
6080         * coffread.c (process_coff_symbol): Use xstrdup.
6081         * value.c (create_internalvar): Use xstrdup.
6082
6083 2019-06-16  Tom Tromey  <tom@tromey.com>
6084
6085         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6086         * breakpoint.c (stopin_command, stopat_command)
6087         (until_break_command, decode_location_default): Remove unnecessary
6088         cast.
6089         * utils.c (subset_compare): Remove unnecessary cast.
6090         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6091         cast.
6092         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6093         cast.
6094         * infcmd.c (path_command): Remove unnecessary cast.
6095         * coffread.c (decode_type): Remove unnecessary cast.
6096         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6097         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6098         * tui/tui-stack.c (tui_show_locator_content)
6099         (tui_show_frame_info): Remove unnecessary cast.
6100         * tui/tui-win.c (tui_scroll_forward_command)
6101         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6102         (parse_scrolling_args): Remove unnecessary cast.
6103         * tui/tui-data.c (init_win_info, tui_del_window)
6104         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6105         (free_content_elements): Remove unnecessary cast.
6106         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6107         unnecessary cast.
6108         * tui/tui-source.c (tui_set_source_content)
6109         (tui_vertical_source_scroll): Remove unnecessary cast.
6110         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6111         cast.
6112         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6113         * tui/tui-regs.c (tui_display_registers_from)
6114         (tui_display_register): Remove unnecessary cast.
6115         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6116         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6117         (make_visible): Remove unnecessary cast.
6118         * tui/tui-winsource.c (tui_erase_source_content)
6119         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6120         unnecessary cast.
6121         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6122         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6123         * stabsread.c (read_type, read_array_type, read_range_type):
6124         Remove unnecessary cast.
6125         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6126         (parse_symbol, parse_type, upgrade_type, parse_external)
6127         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6128         unnecessary cast.
6129         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6130
6131 2019-06-16  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-data.c (tui_alloc_generic_win_info)
6134         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6135         checks.
6136
6137 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6138             Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * f-typeprint.c (f_print_type): Don't return early for not
6141         associated or not allocated types.
6142         (f_type_print_varspec_suffix): Add print_rank parameter and print
6143         ranks of array types in case they dangling.
6144         (f_type_print_base): Add print_rank parameter.
6145
6146 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * NEWS: Mention new MI commands.
6149         * break-catch-throw.c (enum exception_event_kind): Move to
6150         breakpoint.h.
6151         (print_mention_exception_catchpoint): Output text as a single
6152         message.
6153         (catch_exception_command_1): Rename to...
6154         (catch_exception_event): ...this, make non-static, update header
6155         command, and change some parameter types.
6156         (catch_catch_command): Update for changes to
6157         catch_exception_command_1.
6158         (catch_throw_command): Likewise.
6159         (catch_rethrow_command): Likewise.
6160         * breakpoint.c (enum exception_event_kind): Delete.
6161         * breakpoint.h (enum exception_event_kind): Moved here from
6162         break-catch-throw.c.
6163         (catch_exception_event): Declare.
6164         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6165         (mi_cmd_catch_throw): New function.
6166         (mi_cmd_catch_rethrow): New function.
6167         (mi_cmd_catch_catch): New function.
6168         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6169         'catch-catch' entries.
6170         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6171         (mi_cmd_catch_rethrow): Declare.
6172         (mi_cmd_catch_catch): Declare.
6173
6174 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * annotate.c (annotate_source_line): Change return type to void,
6177         update implementation to match.
6178         * annotate.h (annotate_source_line): Change return type to void,
6179         update header comment.
6180         * stack.c (print_frame_info): Don't change what frame information
6181         is printed based on whether annotations are on or not.
6182
6183 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6186         (annotate_source): Make static.
6187         (annotate_source_line): Moved from source.c and renamed from
6188         identify_source_line.  Update the return type.
6189         * annotate.h (annotate_source): Delete declaration.
6190         (annotate_source_line): Declaration moved from source.h, and
6191         renamed from identify_source_line.  Return type updated.
6192         * source.c (identify_source_line): Moved to annotate.c and renamed
6193         to annotate_source_line.
6194         (info_line_command): Remove check of annotation_level.
6195         * source.h (identify_source_line): Move declaration to annotate.h
6196         and rename to annotate_source_line.
6197         * stack.c: Add 'annotate.h' include.
6198         (print_frame_info): Remove check of annotation_level before
6199         calling annotate_source_line.
6200
6201 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * source-cache.c (source_cache::get_plain_source_lines): Use
6204         open_source_file_with_line_charpos instead of just
6205         open_source_file, remove call to find_source_lines.
6206         (source_cache::get_source_lines): Likewise.
6207         * source.c (find_source_lines): Make static.
6208         (get_filename_and_charpos): Renamed into...
6209         (open_source_file_with_line_charpos): ..this along with changes to
6210         return a scoped_fd, and some other minor clean ups.
6211         (identify_source_line): Use open_source_file_with_line_charpos.
6212         (search_command_helper): Use open_source_file_with_line_charpos
6213         instead of just open_source_file, remove call to
6214         find_source_lines.
6215         * source.h (open_source_file_with_line_charpos): Declare new
6216         function.
6217         (find_source_lines): Delete declaration.
6218
6219 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * source.c (get_filename_and_charpos): Remove fullname
6222         parameter.
6223         (identify_source_line): Update call to get_filename_and_charpos.
6224
6225 2019-06-14  Tom Tromey  <tromey@adacore.com>
6226
6227         PR gdb/24502:
6228         * ui-style.h (skip_ansi_escape): Update comment.
6229         * ui-file.h (class no_terminal_escape_file): New class.
6230         * ui-file.c (no_terminal_escape_file::write)
6231         (no_terminal_escape_file::puts): New methods.
6232         * cli/cli-logging.c (handle_redirections): Use
6233         no_terminal_escape_file.
6234
6235 2019-06-14  Tom Tromey  <tromey@adacore.com>
6236
6237         * NEWS: Move convenience variable news above Python news.
6238
6239 2019-06-14  Tom Tromey  <tom@tromey.com>
6240
6241         * gnulib: Move directory to top-level.
6242         * configure.ac: Don't configure gnulib.
6243         * configure: Rebuild.
6244         * common/common-defs.h: Use new path to gnulib.
6245         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6246         (GNULIB_H): Remove.
6247         (INCGNU): Look in new gnulib location.
6248         (HFILES_NO_SRCDIR): Remove gnulib files.
6249         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6250         (generated_files): Remove GNULIB_H.
6251         ($(LIBGNU), all-lib): Remove targets.
6252         (distclean): Don't mention GNULIB_BUILDDIR.
6253         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6254
6255 2019-06-14  Tom Tromey  <tromey@adacore.com>
6256
6257         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6258         Warn if symbol file does not provide any symbols.
6259
6260 2019-06-14  Tom Tromey  <tromey@adacore.com>
6261
6262         * source.c (find_and_open_source): Respect basenames_may_differ.
6263
6264 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * annotate.c (annotate_breakpoints_invalid): Make use of
6267         scoped_restore_terminal_state.
6268         (annotate_frames_invalid): Likewise.
6269
6270 2019-06-14  Tom Tromey  <tromey@adacore.com>
6271
6272         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6273         allow assignment to an internalvar.
6274
6275 2019-06-14  Tom Tromey  <tromey@adacore.com>
6276
6277         * ada-lex.l: Allow "_" in attribute names.
6278
6279 2019-06-14  Tom Tromey  <tromey@adacore.com>
6280
6281         PR gdb/24653:
6282         * regcache.c (registers_changed): Don't call alloca.
6283         * top.c (execute_command): Don't call alloca.
6284
6285 2019-06-13  Pedro Alves  <palves@redhat.com>
6286
6287         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6288         'expression'.  When parsing an expression, error out if there's
6289         junk after "unlimited".
6290         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6291         (do_set_command): Adjust calls to is_unlimited_literal.
6292
6293 2019-06-13  Pedro Alves  <palves@redhat.com>
6294
6295         * compile/compile.c (make_compile_options_def_group): Add braces
6296         around array_view initializer.
6297         * thread.c (make_thread_apply_all_options_def_group)
6298         (make_thread_apply_all_options_def_group): Likewise.
6299
6300 2019-06-13  Pedro Alves  <palves@redhat.com>
6301
6302         * NEWS (New commands): Mention "maint test-options
6303         require-delimiter", "maint test-options unknown-is-error", "maint
6304         test-options unknown-is-operand" and "maint show
6305         test-options-completion-result".
6306         (New command options, command completion): New section.
6307         (Completion improvements): New section.
6308         Mention that you can abbreviate "unlimited".
6309
6310 2019-06-13  Pedro Alves  <palves@redhat.com>
6311
6312         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6313         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6314         * unittests/cli-utils-selftests.c (test_parse_flags)
6315         (test_parse_flags_qcs): Delete.
6316         (test_cli_utils): Don't call deleted functions.
6317
6318 2019-06-13  Pedro Alves  <palves@redhat.com>
6319
6320         * thread.c: Include "cli/cli-option.h".
6321         (tp_array_compar_ascending): Global.
6322         (tp_array_compar): Delete function.
6323         (tp_array_compar_ascending, tp_array_compar_descending): New
6324         functions.
6325         (ascending_option_def, qcs_flag_option_def)
6326         (thr_qcs_flags_option_defs)
6327         (make_thread_apply_all_options_def_group)
6328         (make_thread_apply_options_def_group): New.
6329         (thread_apply_all_command): Use gdb::option::process_options.
6330         (thread_apply_command_completer)
6331         (thread_apply_all_command_completer): New.
6332         (thread_apply_command): Use gdb::option::process_options.
6333         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6334         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6335         to generate help text of "thread apply".  Adjust "taas"'s help.
6336         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6337         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6338
6339 2019-06-13  Pedro Alves  <palves@redhat.com>
6340
6341         * thread.c (thread_apply_command): Check for invalid TID with
6342         isdigit instead of !isalpha.
6343
6344 2019-06-13  Pedro Alves  <palves@redhat.com>
6345
6346         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6347         (validate_flags_qcs): New.
6348         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6349         (validate_flags_qcs): Declare.
6350         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6351         (make_frame_apply_options_def_group): New.
6352         (frame_apply_command_count): Process options with
6353         gdb::option::process_options.
6354         (frame_apply_completer): New.
6355         (frame_apply_level_completer, frame_apply_all_completer)
6356         (frame_apply_completer): New.
6357         (_initialize_stack): Update help of "frame apply", "frame apply
6358         level", "frame apply all" and "faas" to mention supported options
6359         and install command completers.
6360         * stack.h (frame_apply_all_completer): Declare.
6361         * thread.c: Include "stack.h".
6362         (tfaas_command): Add "--".
6363         (_initialize_thread): Update help "tfaas" to mention supported
6364         options and install command completer.
6365
6366 2019-06-13  Pedro Alves  <palves@redhat.com>
6367
6368         * completer.c (complete_nested_command_line): New.
6369         (gdb_completion_word_break_characters_throw): Add assertion.
6370         * completer.h (complete_nested_command_line): Declare.
6371
6372 2019-06-13  Pedro Alves  <palves@redhat.com>
6373
6374         * stack.c (parse_backtrace_qualifiers): New.
6375         (backtrace_command): Use it.
6376         (backtrace_command_completer): Complete on qualifiers.
6377
6378 2019-06-13  Pedro Alves  <palves@redhat.com>
6379
6380         * frame.c: Include "cli/cli-option.h.
6381         (user_set_backtrace_options): New.
6382         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6383         Delete.
6384         (get_prev_frame): Adjust.
6385         (boolean_option_def, uinteger_option_def)
6386         (set_backtrace_option_defs): New.
6387         (_initialize_frame): Adjust and use
6388         gdb::option::add_setshow_cmds_for_options to install "set
6389         backtrace past-main" and "set backtrace past-entry".
6390         * frame.h: Include "cli/cli-option.h".
6391         (struct frame_print_options): Forward declare.
6392         (print_frame_arguments_all, print_frame_arguments_scalars)
6393         (print_frame_arguments_none): Declare.
6394         (print_entry_values): Delete declaration.
6395         (struct frame_print_options, user_frame_print_options): New.
6396         (struct set_backtrace_options): New.
6397         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6398         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6399         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6400         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6401         (list_args_or_locals): Add frame_print_options parameter.
6402         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6403         * python/py-framefilter.c (enumerate_args): Pass down
6404         USER_FRAME_PRINT_OPTIONS.
6405         * stack.c: Include "cli/cli-option.h".
6406         (print_frame_arguments_all, print_frame_arguments_scalars)
6407         (print_frame_arguments_none): Declare.
6408         (print_raw_frame_arguments, print_entry_values): Delete.
6409         (user_frame_print_options): New.
6410         (boolean_option_def, enum_option_def, frame_print_option_defs):
6411         New.
6412         (struct backtrace_cmd_options): New.
6413         (bt_flag_option_def): New.
6414         (backtrace_command_option_defs): New.
6415         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6416         (print_frame_arg, read_frame_arg, print_frame_args)
6417         (print_frame_info, print_frame): Add frame_print_options parameter
6418         and use it.
6419         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6420         (backtrace_command_1): Add frame_print_options and
6421         backtrace_cmd_options parameters and use them.
6422         (make_backtrace_options_def_group): New.
6423         (backtrace_command): Process command options with
6424         gdb::option::process_options.
6425         (backtrace_command_completer): New.
6426         (_initialize_stack): Extend "backtrace"'s help to mention
6427         supported options.  Install completer for "backtrace".
6428         Install some settings commands with add_setshow_cmds_for_options.
6429
6430 2019-06-13  Pedro Alves  <palves@redhat.com>
6431
6432         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6433         and that "set/show print raw frame-arguments" are now deprecated.
6434
6435         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6436         command.
6437         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6438         * stack.c (_initialize_stack): Install "set/show print
6439         raw-frame-arguments", and deprecate "set/show print raw
6440         frame-arguments".
6441         * valprint.c (_initialize_valprint): Deprecate "set/show print
6442         raw".
6443
6444 2019-06-13  Pedro Alves  <palves@redhat.com>
6445
6446         * compile/compile.c (struct compile_options): New.
6447         (compile_flag_option_def, compile_command_option_defs)
6448         (make_compile_options_def_group): New.
6449         (compile_file_command): Handle options with
6450         gdb::option::process_options.
6451         (compile_file_command_completer): New function.
6452         (compile_code_command): Handle options with
6453         gdb::option::process_options.
6454         (compile_code_command_completer): New function.
6455         (_initialize_compiler): Install completers for "compile code" and
6456         "compile file".  Mention available options in "compile code" and
6457         "compile code"'s help.
6458         * completer.c (advance_to_completion_word): New, factored out from
6459         ...
6460         (advance_to_expression_complete_word_point): ... this.
6461         (advance_to_filename_complete_word_point): New.
6462         * completer.h (advance_to_filename_complete_word_point): New
6463         declaration.
6464
6465 2019-06-13  Pedro Alves  <palves@redhat.com>
6466
6467         * compile/compile.c: Include "cli/cli-option.h".
6468         (compile_print_value): Scope data pointer is now a
6469         value_print_options pointer; adjust.
6470         (compile_print_command): Process options.  Scope data pointer is
6471         now a value_print_options pointer; adjust.
6472         (_initialize_compile): Update "compile print"'s help to include
6473         supported options.  Install a completer for "compile print".
6474         * cp-valprint.c (show_vtblprint, show_objectprint)
6475         (show_static_field_print): Delete.
6476         (_initialize_cp_valprint): Don't install "set print
6477         static-members", "set print vtbl", "set print object" here.
6478         * printcmd.c: Include "cli/cli-option.h" and
6479         "common/gdb_optional.h".
6480         (print_command_parse_format): Rework to fill in a
6481         value_print_options instead of a format_data.
6482         (print_value): Change parameter type from format_data pointer to
6483         value_print_options reference.  Adjust.
6484         (print_command_1): Process options.  Adjust to pass down a
6485         value_print_options.
6486         (print_command_completer): New.
6487         (_initialize_printcmd): Install print_command_completer as
6488         handle_brkchars completer for the "print" command.  Update
6489         "print"'s help to include supported options.
6490         * valprint.c: Include "cli/cli-option.h".
6491         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6492         here from cp-valprint.c.
6493         (boolean_option_def, uinteger_option_def)
6494         (value_print_option_defs, make_value_print_options_def_group):
6495         New.  Use gdb::option::add_setshow_cmds_for_options to install
6496         "set print elements", "set print null-stop", "set print repeats",
6497         "set print pretty", "set print union", "set print array", "set
6498         print address", "set print symbol", "set print array-indexes".
6499         * valprint.h: Include <string> and "cli/cli-option.h".
6500         (make_value_print_options_def_group): Declare.
6501         (print_value): Change parameter type from format_data pointer to
6502         value_print_options reference.
6503         (print_command_completer): Declare.
6504
6505 2019-06-13  Pedro Alves  <palves@redhat.com>
6506
6507         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6508         (COMMON_SFILES): Add maint-test-settings.c.
6509         * cli/cli-decode.c (boolean_enums): New global, factored out from
6510         ...
6511         (add_setshow_boolean_cmd): ... here.
6512         * cli/cli-decode.h (boolean_enums): Declare.
6513         * cli/cli-option.c: New file.
6514         * cli/cli-option.h: New file.
6515         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6516         factored out from ...
6517         (parse_cli_boolean_value(const char *)): ... this.
6518         (is_unlimited_literal): Change parameter type to pointer to
6519         pointer.  Adjust and advance ARG pointer.
6520         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6521         (parse_cli_var_enum): New, factored out from ...
6522         (do_set_command): ... this.  Adjust.
6523         * cli/cli-setshow.h (parse_cli_boolean_value)
6524         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6525         (parse_cli_var_enum): Declare.
6526         * cli/cli-utils.c: Include "cli/cli-option.h".
6527         (get_ulongest): New.
6528         * cli/cli-utils.h (get_ulongest): Declare.
6529         (check_for_argument): New overloads.
6530         * maint-test-options.c: New file.
6531
6532 2019-06-13  Pedro Alves  <palves@redhat.com>
6533
6534         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6535         parse a range if "-" is at the end of the string.
6536
6537 2019-06-13  Pedro Alves  <palves@redhat.com>
6538
6539         * cli/cli-setshow.c (parse_auto_binary_operation)
6540         (parse_cli_boolean_value): Don't allow "o".
6541
6542 2019-06-13  Pedro Alves  <palves@redhat.com>
6543
6544         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6545         * NEWS: Mention maint test-settings KIND.
6546         * maint-test-settings.c: New file.
6547
6548 2019-06-13  Pedro Alves  <palves@redhat.com>
6549
6550         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6551         completer.
6552         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6553         "set" completers.
6554
6555 2019-06-13  Pedro Alves  <palves@redhat.com>
6556
6557         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6558         after item.
6559
6560 2019-06-13  Pedro Alves  <palves@redhat.com>
6561
6562         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6563
6564 2019-06-13  Pedro Alves <palves@redhat.com>
6565
6566         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6567         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6568         call.
6569         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6570         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6571         calls.
6572         (check_for_argument): Skip spaces after argument.
6573
6574 2019-06-13  Pedro Alves  <palves@redhat.com>
6575
6576         * thread.c (thread_apply_command): Adjust TID parsing.
6577         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6578         detected before end of string.
6579         (tid_is_in_list): Error out if LIST is invalid.
6580
6581 2019-06-13  Pedro Alves  <palves@redhat.com>
6582
6583         * completer.c (complete_line_internal_1): Rewind completion word
6584         point.
6585         (completion_tracker::advance_custom_word_point_by): Change
6586         parameter type to int.
6587         * completer.h (completion_tracker::advance_custom_word_point_by):
6588         Likewise.
6589
6590 2019-06-13  Pedro Alves  <palves@redhat.com>
6591
6592         * completer.c (advance_to_completion_word): Handle delimiters.
6593
6594 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6595
6596         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6597
6598 2019-06-11  Tom Tromey  <tom@tromey.com>
6599
6600         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6601         (xmalloc_failed): Move to alloc.c.
6602         * alloc.c: New file.
6603         * Makefile.in (COMMON_SFILES): Add alloc.c.
6604
6605 2019-06-11  Tom Tromey  <tom@tromey.com>
6606
6607         * nat/linux-waitpid.c: Don't include server.h.
6608         (linux_debug): Remove.
6609         (my_waitpid): Update.
6610
6611 2019-06-11  Tom Tromey  <tromey@adacore.com>
6612
6613         * infcall.c (_initialize_infcall): Remove trailing newline from
6614         help.
6615         * user-regs.c (_initialize_user_regs): Remove trailing newline
6616         from help.
6617         * typeprint.c (_initialize_typeprint): Remove trailing newline
6618         from help.
6619         * reverse.c (_initialize_reverse): Remove trailing newlines from
6620         help.
6621         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6622         from help.
6623         * language.c (add_set_language_command): Remove trailing newline
6624         from help.
6625         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6626         help.
6627         * disasm.c (_initialize_disasm): Remove trailing newline from
6628         help.
6629         * top.c (init_main): Remove trailing newline from help.
6630         * interps.c (_initialize_interpreter): Remove trailing newline
6631         from help.
6632         * btrace.c (_initialize_btrace): Remove trailing newlines from
6633         help.
6634         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6635         from help.
6636         * python/python.c (_initialize_python): Remove trailing newline
6637         from help.
6638         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6639         help.
6640         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6641         from help.  Reformat some text.
6642         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6643         from help.
6644         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6645         newline from help.
6646
6647 2019-06-11  Tom Tromey  <tromey@adacore.com>
6648
6649         * darwin-nat.c (darwin_decode_exception_message)
6650         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6651
6652 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6653
6654         * valops.c (value_slice): Check for not allocated or not
6655         associated values.
6656
6657 2019-06-10  Tom de Vries  <tdevries@suse.de>
6658
6659         PR gdb/24618
6660         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6661         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6662         invalid.
6663
6664 2019-06-10  Tom de Vries  <tdevries@suse.de>
6665
6666         PR gdb/24611
6667         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6668         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6669
6670 2019-06-10  Tom de Vries  <tdevries@suse.de>
6671
6672         PR symtab/24545
6673         * symtab.c (struct demangled_name_entry): Add language field.
6674         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6675         static minimal symbol".  Set and use language field.
6676
6677 2019-06-10  Tom Tromey  <tromey@adacore.com>
6678
6679         * ada-lang.c (_initialize_ada_language): Update help text.
6680
6681 2019-06-10  Tom Tromey  <tromey@adacore.com>
6682
6683         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6684         with a newline.
6685         * guile/guile.c (handle_boot_error): Don't end warning with a
6686         newline.
6687         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6688         warning with a newline.
6689         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6690         newline.
6691         (s12z_frame_cache): Likewise.
6692         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6693         a newline.
6694         * solib-svr4.c (disable_probes_interface): Don't end warning with
6695         a newline.
6696         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6697         newline.
6698         * python/python.c (do_finish_initialization): Don't end warning
6699         with a newline.
6700
6701 2019-06-10  Tom Tromey  <tom@tromey.com>
6702
6703         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6704         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6705         gdbpy_enter.
6706
6707 2019-06-10  Tom Tromey  <tromey@adacore.com>
6708
6709         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6710         data.
6711         (elf_new_init): Don't call stabsread_new_init.
6712         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6713         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6714         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6715
6716 2019-06-10  Tom de Vries  <tdevries@suse.de>
6717
6718         PR symtab/16264
6719         PR symtab/24517
6720         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6721
6722 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6723
6724         * source.c (find_and_open_source): Also rewrite relative file
6725         names.
6726
6727 2019-04-26  Amos Bird  <amosbird@gmail.com>
6728
6729         * annotate.c (annotate_thread_exited): Add "thread-exited"
6730         annotation.
6731
6732 2019-06-06  Tom Tromey  <tromey@adacore.com>
6733
6734         * maint.h (class scoped_command_stats): Use
6735         DISABLE_COPY_AND_ASSIGN.
6736         <print_time>: New method.
6737         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6738         print_time.
6739         (scoped_command_stats::print_time): New method.
6740
6741 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6744         instructions of lengths 6 or 8 bytes.
6745
6746 2019-06-04  Pedro Alves  <palves@redhat.com>
6747
6748         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6749
6750         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6751         * breakpoint.c (condition_completer): Likewise.
6752         * cli/cli-dump.c (scan_expression): Likewise.
6753         * common/filestuff.c (mkdir_recursive): Likewise.
6754         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6755         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6756         (gdb_abspath): Likewise.
6757         * compile/compile-cplus-types.c
6758         (compile_cplus_instance::decl_name): Likewise.
6759         * completer.c (complete_explicit_location):
6760         (signal_completer, reg_or_group_completer_1): Likewise.
6761         * cp-support.c (cp_remove_params_if_any): Likewise.
6762         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6763         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6764         * infcmd.c (strip_bg_char): Likewise.
6765         * linespec.c (copy_token_string): Likewise.
6766         * mi/mi-main.c (output_cores): Likewise.
6767         * psymtab.c (psymtab_search_name):
6768         * symfile.c (test_set_ext_lang_command): Likewise.
6769         * target.c (target_fileio_read_stralloc): Likewise.
6770         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6771         * value.c (complete_internalvar): Likewise.
6772
6773 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6774
6775         Add objfile property to gdb.Type.
6776         * NEWS: Mention Python API addition.
6777         * python/py-type.c (typy_get_objfile): New method.
6778
6779 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6780
6781         * NEWS: Mention the new set|show style [title|highlight].
6782         Mention changes to "show style", "help" and "apropos".
6783
6784 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6785
6786         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6787         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6788         instead of print_help_for_command.
6789         (print_doc_of_command): New function.
6790         (help_list): Add 'apropos -v word' suggestion.
6791         (print_help_for_command): Style the command name using title style.
6792         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6793         (_initialize_cli_cmds): Describe -v in apropos_command help.
6794
6795 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * cli/cli-style.h (cli_style_option): Add name in constructor,
6798         add m_name class member, add constructor with intensity,
6799         add name class function.
6800         (cli_style_option::add_setshow_commands): Remove name argument.
6801         (highlight_style, title_style): New styles.
6802         * cli/cli-style.c (do_show): New function that shows a style
6803         characteristic styling the style name with itself.
6804         (set_style_name): New function.
6805         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6806         Update all callers according to the changes in cli/cli-style.h.
6807         * utils.h (fputs_highlighted): New function.
6808         * utils.c (fputs_highlighted): Likewise.
6809
6810 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6811
6812         * NEWS: Mention new pipe command and new convenience variables.
6813
6814 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6815
6816         * cli/cli-cmds.c (pipe_command): New function.
6817         (_initialize_cli_cmds): Call add_com for pipe_command.
6818         Define | as an alias for pipe.
6819         (exit_status_set_internal_vars): New function.
6820         (shell_escape): Call exit_status_set_internal_vars.
6821         cli/cli-decode.c (find_command_name_length): Recognize | as
6822         a single character command.
6823
6824 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6825
6826         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6827         top.c (execute_command_to_ui_file): New function, mostly a copy
6828         of execute_command_to_string.
6829         (execute_command_to_string): Implement by calling
6830         execute_command_to_ui_file.
6831
6832 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6833
6834         * top.h (saved_command_line): Remove declaration.
6835         * top.c (previous_saved_command_line, previous_repeat_arguments):
6836         New variables.
6837         (saved_command_line): Make static, define together with other
6838         'repeat variables'.
6839         (dont_repeat): Clear repeat_arguments.
6840         (repeat_previous, get_saved_command_line, save_command_line):
6841         New functions.
6842         (gdb_init): Initialize saved_command_line
6843         and previous_saved_command_line.
6844         * main.c (captured_main_1): Remove saved_command_line initialization.
6845         * event-top.c (handle_line_of_input): Update to use
6846         the new 'repeat' related functions instead of direct access to
6847         saved_command_line.
6848         * command.h (repeat_previous, get_saved_command_line,
6849         save_command_line): New declarations.
6850         (dont_repeat): Add comment.
6851
6852 2019-05-30  Tom Tromey  <tromey@adacore.com>
6853
6854         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6855         Fix comment.
6856         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6857
6858 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6859
6860         PR cli/24587
6861         * completer.c (complete): Initialize variable word.
6862
6863 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6864
6865         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6866         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6867         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6868         'body' is NULL to the outter 'if', protecting the '!is_define'
6869         situation as well.
6870
6871 2019-05-29  Tom Tromey  <tromey@adacore.com>
6872
6873         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6874         (dwarf_unknown): New function.
6875         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6876         (dwarf_type_encoding_name): Use dwarf_unknown.
6877
6878 2019-05-29  Tom Tromey  <tromey@adacore.com>
6879
6880         PR c++/20020:
6881         * cp-valprint.c (cp_print_value_fields): Call
6882         cp_print_static_field inside "try".
6883
6884 2019-05-29  Tom Tromey  <tromey@adacore.com>
6885
6886         * inflow.c (struct terminal_info): Add default operator=.
6887         * configure: Rebuild.
6888         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6889         -Wdeprecated-copy-dtor, -Wredundant-move.
6890
6891 2019-05-29  Tom Tromey  <tromey@adacore.com>
6892
6893         * NEWS: Add entry.
6894         * infcmd.c (print_return_value_1): Handle finish_print
6895         option.
6896         (show_print_finish): New function.
6897         (_initialize_infcmd): Add "set/show print finish" commands.
6898         * valprint.c (user_print_options): Initialize new member.
6899         * valprint.h (struct value_print_options) <finish_print>: New
6900         member.
6901
6902 2019-05-28  Tom Tromey  <tromey@adacore.com>
6903
6904         * ada-lang.c (ada_remove_Xbn_suffix)
6905         (find_old_style_renaming_symbol)
6906         (parse_old_style_renaming): Remove.
6907         (ada_find_renaming_symbol): Don't call
6908         find_old_style_renaming_symbol.
6909         (ada_is_renaming_symbol): Rename from
6910         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6911         bool.  Now static.
6912         (ada_read_var_value): Update and simplify.
6913         * ada-exp.y (write_var_or_type): Remove old code.
6914
6915 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6916
6917         PR gdb/25010
6918         * event-top.c: Remove include comment.
6919         * inflow.c (class scoped_ignore_sigttou): Move from here...
6920         * inflow.h (class scoped_ignore_sigttou): ...to here.
6921         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6922         * top.c:  Remove include comment.
6923
6924 2019-05-27  Tom Tromey  <tom@tromey.com>
6925
6926         * NEWS: Fix typo.
6927
6928 2019-05-22  Tom Tromey  <tromey@adacore.com>
6929
6930         * target.c (target_follow_exec): Constify parameter.
6931         * target-delegates.c: Rebuild.
6932         * remote.c (remote_target::follow_exec): Constify parameter.
6933         * infrun.c (follow_exec): Constify parameter.
6934         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6935         (target_follow_exec): Likewise.
6936
6937 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6938
6939         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6940         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6941
6942 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6943
6944         * NEWS: Add debugredirect and testsuite sections.
6945
6946 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6947
6948         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6949         target descriptions using exclusively floating point register name
6950         aliases.
6951
6952 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         PR gdb/18644:
6955         * f-lang.c (build_fortran_types): Handle the case where
6956         gdbarch_floatformat_for_type returns a nullptr.
6957
6958 2019-05-21  Tom de Vries  <tdevries@suse.de>
6959
6960         PR cli/24587
6961         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6962
6963 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6964
6965         PR gdb/18644:
6966         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6967         16-byte floats.
6968         * i386-tdep.c (i386_floatformat_for_type): Use
6969         floatformats_ia64_quad for the 16-byte floating point component
6970         within a fortran 32-byte complex number.
6971
6972 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6975         delete default constructor.
6976         (find_partial_die): Update to return const struct.
6977         (partial_die_parent_scope): Move variable declaration into scope
6978         of its use and change its type to auto.
6979         (guess_partial_die_structure_name): Likewise.
6980         (partial_die_info::fixup): Likewise.
6981
6982 2019-05-17  Tom Tromey  <tromey@adacore.com>
6983
6984         * source.c (find_and_open_source): Remove cast.
6985
6986 2019-05-17  Tom Tromey  <tromey@adacore.com>
6987
6988         * annotate.c (annotate_source): Make "filename" const.
6989         * annotate.h (annotate_source): Use const.
6990
6991 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6992
6993         * disasm.c (set_disassembler_options): Send errors to stderr.
6994
6995 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6996
6997         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6998         (cli_interp_base::set_logging): Check debug_redirect.
6999         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7000         * cli/cli-logging.c (debug_redirect): Add static variable.
7001         (pop_output_files): Add default param.
7002         (handle_redirections): Print debug setting.
7003         (show_logging_command): Likewise.
7004         (_initialize_cli_logging): Add debugredirect command.
7005         * interps.c (current_interp_set_logging): Add debug_redirect
7006         parameter.
7007         * interps.h (set_logging): Add debug_redirect parameter.
7008         (current_interp_set_logging): Likewise.
7009         * mi/mi-common.h: Likewise.
7010         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7011
7012 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7013             Tom Tromey  <tromey@adacore.com>
7014
7015         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7016         directly.
7017         * cli/cli-interp.h (make_logging_output): Remove declaration.
7018         * cli/cli-logging.c (make_logging_output): Remove function.
7019         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7020         directly.
7021         * ui-file.c (tee_file::tee_file): Remove bools.
7022         (tee_file::~tee_file): Remove deletes.
7023         * ui-file.h (tee_file): Remove bools.
7024
7025 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7026
7027         * mi/mi-cmds.h (mi_cmd_complete): New function.
7028         * mi/mi-main.c (mi_cmd_complete): Likewise.
7029         * mi/mi-cmds.c: Define new MI command -complete.
7030         * NEWS: Mention new -complete command.
7031
7032 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7033
7034         * completer.h (complete): New function.
7035         * completer.c (complete): Likewise.
7036         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7037         function defined in completer.h.
7038
7039 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7040
7041         * MAINTAINERS (Write After Approval): Add myself.
7042
7043 2019-05-17  Tom de Vries  <tdevries@suse.de>
7044
7045         PR gdb/24094
7046         * dwarf2read.c (struct cu_partial_die_info): New struct.
7047         (find_partial_die): Return cu_partial_die_info.
7048         (partial_die_parent_scope, guess_partial_die_structure_name)
7049         (partial_die_info::fixup): Handle new return type of find_partial_die.
7050
7051 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7052
7053         PR breakpoints/24541
7054         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7055         "std::string", simplifying the algorithm.
7056
7057 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7058
7059         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7060         (stap_static_probe_ops::get_probes): Likewise.
7061
7062 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7063
7064         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7065         '-')" and "else if".
7066         (stap_parse_single_operand): Join checks for
7067         "gdbarch_stap_parse_special_token_p" and
7068         "gdbarch_stap_parse_special_token" in the same "if" statement.
7069         Invert check when verifying for operation on register
7070         displacement.
7071
7072 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7073
7074         * stap-probe.c (stap_get_opcode): Update comment.
7075         (stap_get_expected_argument_type): Likewise.
7076         (handle_stap_probe): Likewise.
7077
7078 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7079
7080         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7081         return type to 'bool'.  Adjust comment.  Use 'bool' when
7082         appropriate.
7083         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7084         * stap-probe.c (stap_parse_argument_1): Likewise.
7085         (stap_is_operator): Likewise.
7086         (stap_is_generic_prefix): Likewise.
7087         (stap_is_register_prefix): Likewise.
7088         (stap_is_register_indirection_prefix): Likewise.
7089         (stap_is_integer_prefix): Likewise.
7090         (stap_generic_check_suffix): Likewise.
7091         (stap_check_integer_suffix): Likewise.
7092         (stap_check_register_suffix): Likewise.
7093         (stap_check_register_indirection_suffix): Likewise.
7094         (stap_parse_register_operand): Likewise.
7095         (stap_parse_single_operand): Likewise.
7096         (stap_parse_argument_1): Likewise.
7097         (stap_probe::get_argument_count): Likewise.
7098         (stap_is_operator): Likewise.
7099
7100 2019-05-16  Tom Tromey  <tromey@adacore.com>
7101
7102         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7103         keyword to foreach.
7104
7105 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7106
7107         * linux-thread-db.c (try_thread_db_load_1): Change return type
7108         to bool.
7109         (try_thread_db_load): Likewise.
7110         (try_thread_db_load_from_pdir_1): Likewise.
7111         (try_thread_db_load_from_pdir): Likewise.
7112         (try_thread_db_load_from_sdir): Likewise.
7113         (try_thread_db_load_from_dir): Likewise.
7114         (thread_db_load_search): Likewise.
7115         (has_libpthread): Likewise.
7116         (thread_db_load): Likewise.
7117
7118 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7119
7120         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7121         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7122         NULL, and complain/return if that's the case.
7123
7124 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7125
7126         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7127         (advance, posn, abstract_read_memory): New functions.
7128         [struct mem_read_abstraction]: New struct.
7129         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7130
7131 2019-05-14  Tom Tromey  <tromey@adacore.com>
7132
7133         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7134         value is not lval_memory.
7135
7136 2019-05-14  Tom Tromey  <tromey@adacore.com>
7137
7138         * solib.c (info_sharedlibrary_command): Style the file name.
7139
7140 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7141
7142         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7143         (aarch64_vnv_type): Likewise.
7144         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7145         * common/tdesc.c: Likewise.
7146         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7147         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7148         * features/aarch64-fpu.xml: Add ieee half view.
7149         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7150         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7151         * gdbtypes.h (struct builtin_type): Likewise.
7152         (struct objfile_type): Likewise.
7153
7154 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7155
7156         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7157         typo.
7158         * location.h (string_to_event_location): Likewise.
7159
7160 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7161
7162         GDB 8.3 released.
7163
7164 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7165
7166         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7167         New variable declaration.
7168         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7169         New variable.
7170         (print_one_breakpoint): Use ui_out::test_flags and new global
7171         variable to compute use_fixed_output.
7172         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7173         Remove.
7174         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7175         (mi_multi_location_breakpoint_output_fixed): Remove.
7176         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7177         new variable.
7178         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7179         fix_multi_location_breakpoint_output flag if version >= 3.
7180         * ui-out.h (enum ui_out_flag)
7181         <fix_multi_location_breakpoint_output>: New enumerator.
7182
7183 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7184
7185         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7186
7187 2019-05-10  Tom Tromey  <tromey@adacore.com>
7188
7189         * ada-lang.c (catch_ada_completer): New function.
7190         (_initialize_ada_language): Use it.
7191
7192 2019-05-10  Tom Tromey  <tromey@adacore.com>
7193
7194         * thread.c (print_thread_info): Make "requested_threads" const.
7195         * gdbthread.h (print_thread_info): Make "requested_threads"
7196         const.
7197         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7198         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7199
7200 2019-05-08  Tom Tromey  <tom@tromey.com>
7201
7202         * gdbtypes.c (objfile_type_data): Change type.
7203         (objfile_type, _initialize_gdbtypes): Update.
7204
7205 2019-05-08  Tom Tromey  <tom@tromey.com>
7206
7207         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7208         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7209         (_initialize_dwarf2_frame): Update.
7210
7211 2019-05-08  Tom Tromey  <tom@tromey.com>
7212
7213         * objc-lang.c (objc_objfile_data): Change type.
7214         (find_methods): Update.
7215         (_initialize_objc_lang): Remove.
7216
7217 2019-05-08  Tom Tromey  <tom@tromey.com>
7218
7219         * stabsread.c (rs6000_builtin_type_data): Change type.
7220         (rs6000_builtin_type, _initialize_stabsread): Update.
7221
7222 2019-05-08  Tom Tromey  <tom@tromey.com>
7223
7224         * mips-tdep.c (mips_pdr_data): Remove.
7225         (_initialize_mips_tdep): Update.
7226
7227 2019-05-08  Tom Tromey  <tom@tromey.com>
7228
7229         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7230         (hppa_init_objfile_priv_data, read_unwind_info)
7231         (find_unwind_entry, _initialize_hppa_tdep): Update.
7232
7233 2019-05-08  Tom Tromey  <tom@tromey.com>
7234
7235         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7236         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7237         on obstack.
7238         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7239
7240 2019-05-08  Tom Tromey  <tom@tromey.com>
7241
7242         * mdebugread.c (basic_type_data): Change type.
7243         (basic_type, _initialize_mdebugread): Update.
7244
7245 2019-05-08  Tom Tromey  <tom@tromey.com>
7246
7247         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7248
7249 2019-05-08  Tom Tromey  <tom@tromey.com>
7250
7251         * nto-tdep.c (nto_inferior_data_reg): Change type.
7252         (nto_inferior_data): Update.
7253         (nto_inferior_data_cleanup, nto_new_inferior_data)
7254         (_initialize_nto_tdep): Remove.
7255         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7256
7257 2019-05-08  Tom Tromey  <tom@tromey.com>
7258
7259         * ada-lang.c (struct ada_inferior_data): Add initializers.
7260         (ada_inferior_data): Change type.
7261         (ada_inferior_data_cleanup): Remove.
7262         (get_ada_inferior_data, ada_inferior_exit)
7263         (struct ada_pspace_data): Add initializers, destructor.
7264         (ada_pspace_data_handle): Change type.
7265         (get_ada_pspace_data): Update.
7266         (ada_pspace_data_cleanup): Remove.
7267
7268 2019-05-08  Tom Tromey  <tom@tromey.com>
7269
7270         * coffread.c (struct coff_symfile_info): Add initializers.
7271         (coff_objfile_data_key): Move lower.  Change type.
7272         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7273         Update.
7274         (coff_free_info): Remove.
7275
7276 2019-05-08  Tom Tromey  <tom@tromey.com>
7277
7278         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7279         (fbsd_pspace_data_handle): Move lower.  Change type.
7280         (get_fbsd_pspace_data): Update.
7281         (fbsd_pspace_data_cleanup): Remove.
7282         (_initialize_fbsd_tdep): Update.
7283
7284 2019-05-08  Tom Tromey  <tom@tromey.com>
7285
7286         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7287         (get_ada_tasks_pspace_data): Update.
7288         (ada_tasks_pspace_data_cleanup): Remove.
7289         (_initialize_tasks): Update.
7290         (ada_tasks_inferior_data_handle): Change type.
7291         (get_ada_tasks_inferior_data): Update.
7292         (ada_tasks_inferior_data_cleanup): Remove.
7293         (struct ada_tasks_pspace_data): Add initializers.
7294
7295 2019-05-08  Tom Tromey  <tom@tromey.com>
7296
7297         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7298         * symfile-debug.c (debug_sym_get_probes): Change type.
7299         * stap-probe.c (handle_stap_probe):
7300         (stap_static_probe_ops::get_probes): Change type.
7301         * probe.h (class static_probe_ops) <get_probes>: Change type.
7302         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7303         (parse_probes_in_pspace): Update.
7304         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7305         Update.
7306         (any_static_probe_ops::get_probes): Change type.
7307         * elfread.c (elfread_data): New typedef.
7308         (probe_key): Change type.
7309         (elf_get_probes): Likewise.  Update.
7310         (probe_key_free): Remove.
7311         (_initialize_elfread): Update.
7312         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7313         Change type.
7314         (dtrace_process_dof_probe, dtrace_process_dof)
7315         (dtrace_static_probe_ops::get_probe): Change type.
7316
7317 2019-05-08  Tom Tromey  <tom@tromey.com>
7318
7319         * xcoffread.c (struct xcoff_symfile_info): Rename from
7320         coff_symfile_info.  Add initializers.
7321         (xcoff_objfile_data_key): Move lower.  Change type.
7322         (XCOFF_DATA): Rewrite.
7323         (xcoff_free_info): Remove.
7324         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7325         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7326         (xcoff_initial_scan): Update.
7327
7328 2019-05-08  Tom Tromey  <tom@tromey.com>
7329
7330         * solib-svr4.c (struct svr4_info): Add initializers and
7331         destructor.
7332         <probes_table>: Now an htab_up.
7333         (solib_svr4_pspace_data): Change type.
7334         (free_probes_table): Simplify.
7335         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7336         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7337         (probes_table_remove_objfile_probes, register_solib_event_probe)
7338         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7339         (_initialize_svr4_solib): Update.
7340
7341 2019-05-08  Tom Tromey  <tom@tromey.com>
7342
7343         * remote.c (remote_pspace_data): Change type.
7344         (remote_pspace_data_cleanup): Remove.
7345         (get_remote_exec_file, set_pspace_remote_exec_file)
7346         (_initialize_remote): Update.
7347
7348 2019-05-08  Tom Tromey  <tom@tromey.com>
7349
7350         * breakpoint.c (breakpoint_objfile_key): Change type.
7351         (get_breakpoint_objfile_data): Update.
7352         (free_breakpoint_objfile_data): Remove.
7353         (_initialize_breakpoint): Update.
7354
7355 2019-05-08  Tom Tromey  <tom@tromey.com>
7356
7357         * linux-tdep.c (struct linux_info): Add initializers.
7358         (linux_inferior_data): Move.  Change type.
7359         (invalidate_linux_cache_inf): Update.
7360         (linux_inferior_data_cleanup): Remove.
7361         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7362
7363 2019-05-08  Tom Tromey  <tom@tromey.com>
7364
7365         * auxv.c (auxv_inferior_data): Move.  Change type.
7366         (auxv_inferior_data_cleanup): Remove.
7367         (invalidate_auxv_cache_inf): Rewrite.
7368         (get_auxv_inferior_data, _initialize_auxv): Update.
7369
7370 2019-05-08  Tom Tromey  <tom@tromey.com>
7371
7372         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7373         (symfile_debug_objfile_data_key): Change type.
7374         (symfile_debug_installed, debug_qf_has_symbols)
7375         (debug_qf_find_last_source_symtab)
7376         (debug_qf_forget_cached_source_info)
7377         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7378         (debug_qf_print_stats, debug_qf_dump)
7379         (debug_qf_expand_symtabs_for_function)
7380         (debug_qf_expand_all_symtabs)
7381         (debug_qf_expand_symtabs_with_fullname)
7382         (debug_qf_map_matching_symbols)
7383         (debug_qf_expand_symtabs_matching)
7384         (debug_qf_find_pc_sect_compunit_symtab)
7385         (debug_qf_map_symbol_filenames)
7386         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7387         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7388         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7389         (debug_sym_read_linetable, debug_sym_relocate): Update.
7390         (symfile_debug_free_objfile): Remove.
7391         (install_symfile_debug_logging, _initialize_symfile_debug):
7392         Update.
7393
7394 2019-05-08  Tom Tromey  <tom@tromey.com>
7395
7396         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7397         allocate_on_obstack.
7398         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7399         (get_dwarf2_per_objfile): Update.
7400         (set_dwarf2_per_objfile): Remove.
7401         (dwarf2_has_info, dwarf2_get_section_info): Update.
7402         (dwarf2_free_objfile): Remove.
7403         (_initialize_dwarf2_read): Update.
7404
7405 2019-05-08  Tom Tromey  <tom@tromey.com>
7406
7407         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7408         initializers.
7409         <unsupported_script_warning_printed,
7410         script_not_found_warning_printed>: Now bool.
7411         (auto_load_pspace_data): Change type.
7412         (~auto_load_pspace_info): Rename from
7413         auto_load_pspace_data_cleanup.
7414         (get_auto_load_pspace_data, init_loaded_scripts_info)
7415         (clear_section_scripts, maybe_print_unsupported_script_warning)
7416         (maybe_print_script_not_found_warning, _initialize_auto_load):
7417         Update.
7418
7419 2019-05-08  Tom Tromey  <tom@tromey.com>
7420
7421         * objfiles.c (objfile_pspace_info): Add destructor and
7422         initializers.
7423         (objfiles_pspace_data): Change type.
7424         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7425         (get_objfile_pspace_data): Update.
7426         (objfiles_bfd_data): Change type.
7427         (get_objfile_bfd_data): Update.
7428         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7429
7430 2019-05-08  Tom Tromey  <tom@tromey.com>
7431
7432         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7433         Change type.
7434         (get_catch_syscall_inferior_data): Update.
7435         (catch_syscall_inferior_data_cleanup): Remove.
7436         (_initialize_break_catch_syscall): Update.
7437
7438 2019-05-08  Tom Tromey  <tom@tromey.com>
7439
7440         * inflow.c (struct terminal_info): Add destructor and
7441         initializers.
7442         (inflow_inferior_data): Change type.
7443         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7444         (get_inflow_inferior_data, inflow_inferior_exit)
7445         (swap_terminal_info, _initialize_inflow): Update.
7446
7447 2019-05-08  Tom Tromey  <tom@tromey.com>
7448
7449         * target-dcache.c (target_dcache_cleanup): Remove.
7450         (target_dcache_aspace_key): Change type.
7451         (target_dcache_init_p, target_dcache_invalidate)
7452         (target_dcache_get, target_dcache_get_or_init)
7453         (_initialize_target_dcache): Update.
7454         * dcache.h (struct dcache_deleter): New.
7455
7456 2019-05-08  Tom Tromey  <tom@tromey.com>
7457
7458         * symtab.c (struct symbol_cache): Add destructor and
7459         initializers.
7460         (symbol_cache_key): Move.  Change type.
7461         (make_symbol_cache, free_symbol_cache): Remove.
7462         (get_symbol_cache): Update.
7463         (symbol_cache_cleanup): Remove.
7464         (ALL_PSPACES, symbol_cache_flush)
7465         (maintenance_print_symbol_cache)
7466         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7467         Update.
7468
7469 2019-05-08  Tom Tromey  <tom@tromey.com>
7470
7471         * symtab.c (struct main_info): Add destructor and initializers.
7472         (main_progspace_key): Move.  Change type.
7473         (get_main_info): Update.
7474         (main_info_cleanup): Remove.
7475         (_initialize_symtab): Update.
7476
7477 2019-05-08  Tom Tromey  <tom@tromey.com>
7478
7479         * registry.h (DECLARE_REGISTRY): Define the _key class.
7480
7481 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * NEWS: Merge two 'New commands' sections.
7484
7485 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7486
7487         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7488         parameter and use Ada language definition instead.
7489         (ada_val_print_ptr): Remove unused language parameter.
7490         (ada_val_print_num): Remove language parameter and use Ada language
7491         definition instead.
7492         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7493         parameter.
7494         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7495         parameter and use Ada language definition instead.
7496         (ada_val_print_1): Update all ada_val_print_xxx calls.
7497         Remove language parameter.
7498         (ada_val_print): Update ada_val_print_1 call.
7499
7500 2019-05-08  Tom Tromey  <tromey@adacore.com>
7501
7502         * remote.c (remote_hw_watchpoint_limit)
7503         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7504         Now static.
7505
7506 2019-05-08  Tom Tromey  <tromey@adacore.com>
7507
7508         * maint.c (_initialize_maint_cmds): Move initialization code to
7509         remote.c.
7510         (watchdog, show_watchdog): Move to remote.c.
7511         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7512         "watchdog" static.
7513         (_initialize_remote): Move initialization code from maint.c.
7514         * defs.h (watchdog): Don't declare.
7515
7516 2019-05-08  Tom Tromey  <tromey@adacore.com>
7517
7518         * tui/tui-interp.c: Include main.h.
7519         * interps.c: Include main.h.
7520         * main.h (interpreter_p): Declare.
7521         * defs.h (interpreter_p): Don't declare.
7522
7523 2019-05-08  Tom Tromey  <tromey@adacore.com>
7524
7525         * dwarf2loc.c: Include dwarf2read.h.
7526         * defs.h (read_unsigned_leb128): Don't declare.
7527         * dwarf2read.h (read_unsigned_leb128): Declare.
7528
7529 2019-05-08  Tom Tromey  <tromey@adacore.com>
7530
7531         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7532         method.
7533
7534 2019-05-08  Tom Tromey  <tromey@adacore.com>
7535
7536         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7537         when no wrap column is set.
7538
7539 2019-05-08  Tom Tromey  <tromey@adacore.com>
7540
7541         * c-lang.c (c_get_string): Handle non-C-style arrays.
7542
7543 2019-05-08  Tom Tromey  <tromey@adacore.com>
7544
7545         * typeprint.c (print_offset_data::update): Print the bit offset,
7546         not the number of bits remaining.
7547
7548 2019-05-08  Tom Tromey  <tromey@adacore.com>
7549
7550         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7551         padding at end of comment.
7552
7553 2019-05-08  Tom Tromey  <tromey@adacore.com>
7554
7555         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7556         Compare main types.
7557
7558 2019-05-06  Tom Tromey  <tom@tromey.com>
7559
7560         * common/scoped_mmap.c: Include common-defs.h.
7561         * common/scoped_mmap.h: Don't include config.h.
7562
7563 2019-05-04  Tom Tromey  <tom@tromey.com>
7564
7565         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7566         (struct aarch64_call_info): Add initializers.
7567         <si>: Now a std::vector.
7568         (pass_on_stack, aarch64_push_dummy_call): Update.
7569
7570 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7571             Tom Tromey  <tom@tromey.com>
7572
7573         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7574         (ppc_threads): Now a std::vector.  Now static.
7575         (hwdebug_find_thread_points_by_tid)
7576         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7577         Update.
7578
7579 2019-05-04  Tom Tromey  <tom@tromey.com>
7580
7581         * arc-tdep.c (arc_tdesc_init): Return bool.
7582
7583 2019-05-04  Tom Tromey  <tom@tromey.com>
7584
7585         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7586         Use gdb_assert_not_reached.
7587
7588 2019-05-04  Tom Tromey  <tom@tromey.com>
7589
7590         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7591         "false".
7592
7593 2019-05-04  Tom Tromey  <tom@tromey.com>
7594
7595         * arc-tdep.c (arc_tdesc_init): Use bool.
7596
7597 2019-05-04  Tom Tromey  <tom@tromey.com>
7598
7599         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7600
7601 2019-05-04  Tom Tromey  <tom@tromey.com>
7602
7603         * cli/cli-cmds.c (valid_command_p): Return bool.
7604
7605 2019-05-04  Tom Tromey  <tom@tromey.com>
7606
7607         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7608         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7609
7610 2019-05-04  Raul Tambre  <raul@tambre.ee>
7611
7612         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7613         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7614         operator for comparison.
7615
7616 2019-05-04  Tom Tromey  <tom@tromey.com>
7617
7618         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7619         (lookup_partial_symbol, print_partial_symbols)
7620         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7621         (psymbol_compare): Update.
7622         (add_psymbol_to_bcache): Clear the entire psymbol.
7623         (maintenance_check_psymtabs): Update.
7624         * psympriv.h (struct partial_symbol): Don't derive from
7625         general_symbol_info.
7626         <obj_section, unrelocated_address, address,
7627         set_unrelocated_address>: Update.
7628         <ginfo>: New member.
7629         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7630         (debug_names::write_psymbols): Update.
7631
7632 2019-05-04  Tom de Vries  <tdevries@suse.de>
7633
7634         * contrib/cc-with-tweaks.sh: Support -n arg.
7635
7636 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7637
7638         * corelow.c (core_target::detach): Ensure frame cache and
7639         register caches are cleared.
7640         inferior.c (exit_inferior_1): Likewise.
7641
7642 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7643             Tom Tromey  <tom@tromey.com>
7644
7645         * dictionary.c (collate_pending_symbols_by_language): Remove
7646         "struct" from foreach.
7647         * symtab.c (lookup_global_symbol_from_objfile)
7648         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7649         foreach.
7650         * ser-tcp.c (net_open): Remove "struct" from foreach.
7651         * objfiles.c (objfile_relocate, objfile_rebase)
7652         (objfile_has_symbols): Remove "struct" from foreach.
7653         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7654         from foreach.
7655         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7656         foreach.
7657         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7658         "struct" from foreach.
7659         * ada-lang.c (create_excep_cond_exprs)
7660         (ada_exception_catchpoint_cond_string): Remove "struct" from
7661         foreach.
7662
7663 2019-05-03  Tom Tromey  <tromey@adacore.com>
7664
7665         * ada-exp.y (convert_char_literal): Check suffix of each
7666         enumerator.
7667
7668 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7669
7670         PR ada/21406:
7671         * ada-exp.y (yywrap): Don't define.
7672         * ada-lex.l (%option): Add noyywrap
7673         (yywrap): Remove.
7674
7675 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7676
7677         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7678         _WIN32_WINNT to the XP level, unless already defined to a higher
7679         level.
7680
7681         * unittests/parse-connection-spec-selftests.c:
7682         * ser-tcp.c:
7683         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7684         override.
7685
7686         * symfile.c (find_separate_debug_file): Remove colon from the
7687         drive spec of DOS/Windows file names of the target, so that the
7688         file name produced from DEBUGDIR and the target's directory will
7689         be valid on DOS/Windows systems.
7690
7691 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * rust-lang.c (val_print_struct): Handle printing structures
7694         containing strings.
7695
7696 2019-05-02  Tom Tromey  <tromey@adacore.com>
7697
7698         * valarith.c (_initialize_valarith): Remove.
7699
7700 2019-05-01  Tom Tromey  <tromey@adacore.com>
7701
7702         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7703         bitfields.
7704
7705 2019-05-01  Tom Tromey  <tromey@adacore.com>
7706
7707         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7708         for big-endian copies.
7709
7710 2019-04-30  Ali Tamur  <tamur@google.com>
7711         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7712         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7713         (read_3_bytes): New function.
7714
7715 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7716
7717         * windows-nat.c (main_thread_id): Delete.
7718         (handle_output_debug_string): Replace main_thread_id by
7719         current_event.dwThreadId.
7720         (fake_create_process): Likewise.
7721         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7722         Do not set main_thread_id.
7723         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7724         current_event.dwThreadId.
7725         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7726
7727 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7728
7729         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7730         Use current_event.dwThreadId instead of main_thread_id.
7731
7732 2019-04-30  Tom Tromey  <tromey@adacore.com>
7733
7734         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7735         (create_excep_cond_exprs): Iterate over program spaces.
7736         (ada_exception_catchpoint_cond_string): Examine all minimal
7737         symbols for exception types.
7738
7739 2019-04-30  Tom Tromey  <tromey@adacore.com>
7740
7741         PR c++/24470:
7742         * dwarf2read.c (process_structure_scope): Handle case where type
7743         has template parameters but no symbol was created.
7744
7745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7746             Chris January  <chris.january@arm.com>
7747
7748         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7749         qualifier.
7750         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7751
7752 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * f-typeprint.c (f_print_type): Update rules for printing
7755         whitespace.
7756         (f_type_print_varspec_suffix): Likewise.
7757
7758 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7759             Chris January  <chris.january@arm.com>
7760
7761         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7762         function arguments.
7763
7764 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * f-lang.c (build_fortran_types): Change name of void type to
7767         lower case.
7768         * f-typeprint.c (f_type_print_base): Print the name of the void
7769         type, rather than a fixed string.
7770         * f-valprint.c (f_decorations): Use lower case void string.
7771
7772 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7773             Chris January  <chris.january@arm.com>
7774
7775         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7776         types for Fortran.
7777
7778 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7779             Chris January  <chris.january@arm.com>
7780             David Lecomber  <david.lecomber@arm.com>
7781
7782         * f-exp.y (BINOP_INTRINSIC): New token.
7783         (exp): New parser rule handling BINOP_INTRINSIC.
7784         (f77_keywords): Add new builtin procedures.
7785         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7786         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7787         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7788         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7789         (print_unop_subexp_f): New function.
7790         (print_binop_subexp_f): New function.
7791         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7792         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7793         (dump_subexp_body_f): Likewise.
7794         (operator_check_f): Likewise.
7795         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7796         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7797
7798 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7799
7800         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7801         UNOP_KIND.
7802         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7803         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7804         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7805         (operator_length_f): New fuction.
7806         (print_subexp_f): New function.
7807         (op_name_f): New function.
7808         (dump_subexp_body_f): New function.
7809         (operator_check_f): New function.
7810         (exp_descriptor_f): Replace standard expression handling functions
7811         with new functions.
7812         * gdb/fortran-operator.def: New file.
7813         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7814         * gdb/std-operator.def: Remove UNOP_KIND.
7815
7816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7817
7818         * std-operator.def: Remove unbalanced, stray double quote
7819         character.
7820
7821 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7822             Chris January  <chris.january@arm.com>
7823             Daniel Everett  <daniel.everett@arm.com>
7824             Nick Forrington  <nick.forrington@arm.com>
7825             Richard Bunt  <richard.bunt@arm.com>
7826
7827         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7828         of depth when printing anonymous structs or unions.
7829         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7830         Don't print either the top-level value, or the children if the
7831         max-depth is exceeded.
7832         (ppscm_print_children): When printing the key of a map, allow one
7833         extra level of depth.
7834         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7835         print either the top-level value, or the children if the max-depth
7836         is exceeded.
7837         (print_children): When printing the key of a map, allow one extra
7838         level of depth.
7839         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7840         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7841         (user_print_options): Initialise max_depth field.
7842         (val_print_scalar_or_string_type_p): New function.
7843         (val_print): Check to see if the max depth has been reached.
7844         (val_print_check_max_depth): Define new function.
7845         (show_print_max_depth): New function.
7846         (_initialize_valprint): Add 'print max-depth' option.
7847         * valprint.h (struct value_print_options) <max_depth>: New field.
7848         (val_print_check_max_depth): Declare new function.
7849         * NEWS: Document new feature.
7850
7851 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * ada-lang.c (ada_language_defn): Initialise new field.
7854         * c-lang.c (c_is_string_type_p): New function.
7855         (c_language_defn): Initialise new field.
7856         (cplus_language_defn): Initialise new field.
7857         (asm_language_defn): Initialise new field.
7858         (minimal_language_defn): Initialise new field.
7859         * c-lang.h (c_is_string_type_p): Declare new function.
7860         * d-lang.c (d_language_defn): Initialise new field.
7861         * f-lang.c (f_is_string_type_p): New function.
7862         (f_language_defn): Initialise new field.
7863         * go-lang.c (go_is_string_type_p): New function.
7864         (go_language_defn): Initialise new field.
7865         * language.c (default_is_string_type_p): New function.
7866         (unknown_language_defn): Initialise new field.
7867         (auto_language_defn): Initialise new field.
7868         * language.h (struct language_defn) <la_is_string_type_p>: New
7869         member variable.
7870         (default_is_string_type_p): Declare new function.
7871         * m2-lang.c (m2_language_defn): Initialise new field.
7872         * objc-lang.c (objc_language_defn): Initialise new field.
7873         * opencl-lang.c (opencl_language_defn): Initialise new field.
7874         * p-lang.c (pascal_is_string_type_p): New function.
7875         (pascal_language_defn): Initialise new field.
7876         * rust-lang.c (rust_is_string_type_p): New function.
7877         (rust_language_defn): Initialise new field.
7878
7879 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7882         New field.
7883         * ada-lang.c (ada_language_defn): Initialise new field.
7884         * c-lang.c (c_language_defn): Likewise.
7885         (cplus_language_defn): Likewise.
7886         (asm_language_defn): Likewise.
7887         (minimal_language_defn): Likewise.
7888         * d-lang.c (d_language_defn): Likewise.
7889         * f-lang.c (f_language_defn): Likewise.
7890         * go-lang.c (go_language_defn): Likewise.
7891         * language.c (unknown_language_defn): Likewise.
7892         (auto_language_defn): Likewise.
7893         * m2-lang.c (m2_language_defn): Likewise.
7894         * objc-lang.c (objc_language_defn): Likewise.
7895         * opencl-lang.c (opencl_language_defn): Likewise.
7896         * p-lang.c (pascal_language_defn): Likewise.
7897         * rust-lang.c (rust_language_defn): Likewise.
7898
7899 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7900
7901         * ada-lang.c (ada_is_character_type): Change return type to bool.
7902         (ada_is_string_type): Likewise.
7903         * ada-lang.h (ada_is_character_type): Update declaration
7904         (ada_is_string_type): Likewise.
7905
7906 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7907
7908         Support style in 'frame|thread apply'
7909
7910         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7911         * record.c (record_start, record_stop): Update callers of
7912         execute_command_to_string with false.
7913         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7914         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7915         methods.
7916         (class string_file): New constructor with term_out parameter.
7917         Override methods term_out and can_emit_style_escape.  New member
7918         term_out.
7919         (class stdio_file): Override can_emit_style_escape.
7920         (class tee_file): Override term_out and can_emit_style_escape.
7921         * utils.h (can_emit_style_escape): Remove.
7922         * utils.c (can_emit_style_escape): Likewise.
7923         Update all callers of can_emit_style_escape (SOMESTREAM) to
7924         SOMESTREAM->can_emit_style_escape.
7925         * source-cache.c (source_cache::get_source_lines): Likewise.
7926         * stack.c (frame_apply_command_count): Call execute_command_to_string
7927         passing the term_out characteristic of the current gdb_stdout.
7928         * thread.c (thr_try_catch_cmd): Likewise.
7929         * top.c (execute_command_to_string): pass term_out parameter
7930         to construct the string_file for the command output.
7931         * ui-file.c (term_cli_styling): New function (most code moved
7932         from utils.c can_emit_style_escape).
7933         (string_file::string_file, string_file::can_emit_style_escape,
7934         stdio_file::can_emit_style_escape, tee_file::term_out,
7935         tee_file::can_emit_style_escape): New functions.
7936
7937 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7938
7939         * NEWS: Mention the new set|show may-call-functions.
7940         * infcall.c (may_call_functions_p): New variable.
7941         (show_may_call_functions_p): New function.
7942         (call_function_by_hand_dummy): Throws an error if not
7943         may-call-functions.
7944         (_initialize_infcall): Call add_setshow_boolean_cmd for
7945         may-call-functions.
7946
7947 2019-04-25  Keith Seitz  <keiths@redhat.com>
7948
7949         PR c++/24367
7950         * cp-support.c (inspect_type): Don't attempt substitutions
7951         of symbol with the same name.
7952
7953 2019-04-25  Tom Tromey  <tromey@adacore.com>
7954
7955         PR gdb/24475:
7956         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7957         static.
7958
7959 2019-04-25  Tom Tromey  <tromey@adacore.com>
7960
7961         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7962         rvalue reference.
7963         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7964         (gdb_xml_parser::parse): Use std::move.
7965         * python/python-internal.h (gdbpy_convert_exception): Take a const
7966         reference.
7967         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7968         std::move.
7969         * python/py-utils.c (gdbpy_convert_exception): Take a const
7970         reference.
7971         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7972         Use std::move.
7973         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7974         Use std::move.
7975         * mi/mi-main.c (mi_print_exception): Take a const reference.
7976         * main.c (handle_command_errors): Take a const reference.
7977         * linespec.c (parse_linespec): Use std::move.
7978         * infcall.c (run_inferior_call): Use std::move.
7979         (call_function_by_hand_dummy): Use std::move.
7980         * exec.c (try_open_exec_file): Use std::move.
7981         * exceptions.h (exception_print, exception_fprintf)
7982         (exception_print_same): Update.
7983         * exceptions.c (print_exception, exception_print)
7984         (exception_fprintf, exception_print_same): Change parameters to
7985         const reference.
7986         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7987         * common/new-op.c: Use std::move.
7988         * common/common-exceptions.h (struct gdb_exception): Add move
7989         constructor.
7990         (struct gdb_exception_error, struct gdb_exception_quit, struct
7991         gdb_quit_bad_alloc): Change constructor to move constructor.
7992         (throw_exception): Change parameter to rvalue reference.
7993         * common/common-exceptions.c (throw_exception): Take rvalue
7994         reference.
7995         * cli/cli-interp.c (safe_execute_command): Use std::move.
7996         * breakpoint.c (insert_bp_location, location_to_sals): Use
7997         std::move.
7998
7999 2019-04-25  Tom Tromey  <tromey@adacore.com>
8000
8001         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8002         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8003         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8004         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8005         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8006         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8007         guile/scm-value.c: Use unpack.
8008         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8009         gdbscm_gdb_exception.
8010         (gdbscm_throw_gdb_exception): Likewise.
8011         (struct gdbscm_gdb_exception): New.
8012         (unpack): New function.
8013         (gdbscm_wrap): Use unpack.
8014
8015 2019-04-25  Tom Tromey  <tromey@adacore.com>
8016
8017         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8018         (gdb_rl_callback_handler): Use std::move.
8019         * common/common-exceptions.h (struct gdb_exception): Add move
8020         assignment operator.
8021         (throw_exception_sjlj): Change "exception" to const reference.
8022         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8023         (throw_exception_sjlj): Change "exception" to const reference.
8024
8025 2019-04-25  Tom Tromey  <tromey@adacore.com>
8026
8027         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8028         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8029         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8030         Update.
8031         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8032         Update.
8033         * mi/mi-interp.c (mi_interp::exec): Update.
8034         * linespec.c (parse_linespec): Update.
8035         * infcall.c (run_inferior_call): Update.
8036         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8037         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8038         (gdbscm_lookup_global_symbol): Update.
8039         * guile/scm-param.c (gdbscm_parameter_value): Update.
8040         * guile/scm-frame.c (gdbscm_frame_read_register)
8041         (gdbscm_frame_read_var): Update.
8042         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8043         * exec.c (try_open_exec_file): Update.
8044         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8045         (gdb_rl_callback_handler): Update.
8046         * common/common-exceptions.h (exception_none): Don't declare.
8047         * common/common-exceptions.c (exception_none): Don't define.
8048         (struct catcher) <exception>: Update.
8049         * cli/cli-interp.c (safe_execute_command): Update.
8050         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8051
8052 2019-04-25  Ali Tamur  <tamur@google.com>
8053
8054         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8055         (read_attribute_value): Likewise.
8056         (dwarf2_read_addr_index): Update comment.
8057         (read_str_index): Add DW_FORM_strx.
8058         (dwarf2_string_attr): Likewise.
8059         (dwarf2_const_value_attr): Likewise.
8060         (dump_die_shallow): Likewise.
8061         (dwarf2_fetch_constant_bytes): Likewise.
8062         (skip_form_bytes): Likewise.
8063         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8064
8065 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8066
8067         PR corefiles/11608
8068         PR corefiles/18187
8069         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8070         OFFSET.  Verify if current mapping contains an ELF header.
8071         (linux_find_memory_regions_full): Adjust call to
8072         dump_mapping_p.
8073
8074 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8075             Kang Li <kanglictf@gmail.com>
8076
8077         PR gdb/21600
8078
8079         * dwarf2-frame.c (read_initial_length): Be consistent about using
8080         unsigned representation of length.
8081         (decode_frame_entry_1): Likewise.  Check for wraparound of
8082         end pointer as well as buffer overflow.
8083
8084 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8085
8086         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8087         "vq".
8088
8089 2019-04-24  Tom Tromey  <tromey@adacore.com>
8090
8091         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8092
8093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * s12z-tdep.c (s12z_unwind_pc): Delete.
8096         (s12z_unwind_sp): Delete.
8097         (s12z_gdbarch_init): Don't register deleted functions with
8098         gdbarch.
8099
8100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8101
8102         * rl78-tdep.c (rl78_unwind_sp): Delete.
8103         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8104
8105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8108         (xstormy16_unwind_pc): Delete.
8109         (xstormy16_dummy_id): Delete.
8110         (xstormy16_gdbarch_init): Don't register deleted functions with
8111         gdbarch.
8112
8113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * vax-tdep.c (vax_unwind_pc): Delete.
8116         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8117
8118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * v850-tdep.c (v850_unwind_sp): Delete.
8121         (v850_unwind_pc): Delete.
8122         (v850_dummy_id): Delete.
8123         (v850_gdbarch_init): Don't register deleted functions with
8124         gdbarch.
8125
8126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8127
8128         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8129         (tilegx_unwind_pc): Delete.
8130         (tilegx_unwind_dummy_id): Delete.
8131         (tilegx_gdbarch_init): Don't register deleted functions with
8132         gdbarch.
8133
8134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8137         (tic6x_dummy_id): Delete.
8138         (tic6x_gdbarch_init): Don't register deleted functions with
8139         gdbarch.
8140
8141 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * sparc-tdep.c (sparc_unwind_pc): Delete.
8144         (sparc32_gdbarch_init): Don't register deleted function with
8145         gdbarch.
8146
8147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8148
8149         * sh-tdep.c (sh_unwind_sp): Delete.
8150         (sh_unwind_pc): Delete.
8151         (sh_dummy_id): Delete.
8152         (sh_gdbarch_init): Don't register deleted functions with
8153         gdbarch.
8154
8155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * score-tdep.c (score_unwind_sp): Delete.
8158         (score_unwind_pc): Delete.
8159         (score_dummy_id): Delete.
8160         (score_gdbarch_init): Don't register deleted functions with
8161         gdbarch.
8162
8163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8164
8165         * rx-tdep.c (rx_unwind_pc): Delete.
8166         (rx_unwind_sp): Delete.
8167         (rx_dummy_id): Delete.
8168         (rx_gdbarch_init): Don't register deleted functions with
8169         gdbarch.  Update comment.
8170
8171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8174         (rs6000_dummy_id): Delete.
8175         (rs6000_gdbarch_init): Don't register deleted functions with
8176         gdbarch.
8177
8178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8179
8180         * or1k-tdep.c (or1k_dummy_id): Delete.
8181         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8182
8183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8184
8185         * nios2-tdep.c (nios2_dummy_id): Delete.
8186         (nios2_unwind_sp): Delete.
8187         (nios2_gdbarch_init): Don't register deleted functions with
8188         gdbarch.
8189
8190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * nds32-tdep.c (nds32_dummy_id): Delete.
8193         (nds32_unwind_pc): Delete.
8194         (nds32_unwind_sp): Delete.
8195         (nds32_gdbarch_init): Don't register deleted functions with
8196         gdbarch.
8197
8198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8199
8200         * msp430-tdep.c (msp430_unwind_pc): Delete.
8201         (msp430_unwind_sp): Delete.
8202         (msp430_dummy_id): Delete.
8203         (msp430_gdbarch_init): Don't register deleted functions with
8204         gdbarch.
8205
8206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8207
8208         * moxie-tdep.c (moxie_unwind_sp): Delete.
8209         (moxie_unwind_pc): Delete.
8210         (moxie_dummy_id): Delete.
8211         (moxie_gdbarch_init): Don't register deleted functions with
8212         gdbarch.
8213
8214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8215
8216         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8217         (mn10300_unwind_pc): Delete.
8218         (mn10300_unwind_sp): Delete.
8219         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8220         mn10300_unwind_sp.
8221         (mn10300_frame_unwind_init): Don't register deleted functions with
8222         gdbarch.
8223
8224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8225
8226         * mep-tdep.c (mep_unwind_pc): Delete.
8227         (mep_unwind_sp): Delete.
8228         (mep_dummy_id): Delete.
8229         (mep_gdbarch_init): Don't register deleted functions with
8230         gdbarch.
8231
8232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8235         (m68hc11_unwind_sp): Delete.
8236         (m68hc11_gdbarch_init): Don't register deleted functions with
8237         gdbarch.
8238
8239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * m32r-tdep.c (m32r_unwind_sp): Delete.
8242         (m32r_unwind_pc): Delete.
8243         (m32r_dummy_id): Delete.
8244         (m32r_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * m32c-tdep.c (m32c_unwind_pc): Delete.
8250         (m32c_unwind_sp): Delete.
8251         (m32c_dummy_id): Delete.
8252         (m32c_gdbarch_init): Don't register deleted functions with
8253         gdbarch.
8254
8255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8258         (lm32_unwind_pc): Delete.
8259         (lm32_dummy_id): Delete.
8260         (lm32_gdbarch_init): Don't register deleted functions with
8261         gdbarch.
8262
8263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8264
8265         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8266         (iq2000_unwind_pc): Delete.
8267         (iq2000_dummy_id): Delete.
8268         (iq2000_gdbarch_init): Don't register deleted functions with
8269         gdbarch.
8270
8271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8272
8273         * nds32-tdep.c (nds32_type_align): Delete.
8274         (nds32_push_dummy_call): Use type_align instead.
8275
8276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * arm-tdep.c (arm_type_align): Only handle vector override case.
8279         (arm_push_dummy_call): Use type_align.
8280         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8281
8282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8285         case.
8286         (pass_on_stack): Use type_align.
8287         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8288         function.
8289
8290 2019-04-23  Tom Tromey  <tromey@adacore.com>
8291
8292         * dwarf2read.c (line_header::file_name_at): Remove unused
8293         overload.
8294
8295 2019-04-23  Tom de Vries  <tdevries@suse.de>
8296
8297         PR gdb/24438
8298         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8299         invocation.
8300
8301
8302 2019-03-27  Ali Tamur  <tamur@google.com>
8303
8304         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8305         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8306         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8307         (dwarf_expr_context::get_addr_index): Likewise
8308         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8309         (symbol_needs_eval_context::get_addr_index): Likewise
8310         (disassemble_dwarf_expression): Add DW_OP_addrx
8311         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8312         (read_cutu_die_from_dwo): Update comment
8313         (skip_one_die): Add DW_FORM_addrx
8314         (read_attribute_value): Likewise
8315         (var_decode_location): Add DW_OP_addrx
8316         (dwarf2_const_value_attr): Add DW_FORM_addrx
8317         (dump_die_shallow): Likewise
8318         (dwarf2_fetch_constant_bytes): Likewise
8319         (decode_locdesc): Add DW_OP_addrx
8320         (skip_form_bytes): Add DW_FORM_addrx
8321
8322 2019-04-22  Ali Tamur  <tamur@google.com>
8323
8324         * MAINTAINERS (Write After Approval): Add self.
8325
8326 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8327
8328         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8329         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8330         (open_symbol_file_object): Likewise.
8331         (svr4_default_sos): Add info parameter.
8332         (svr4_read_so_list): Likewise.
8333         (svr4_current_sos_direct): Adjust functions calls to pass down
8334         info.
8335         (svr4_current_sos_1): Add info parameter.
8336         (svr4_current_sos): Call get_svr4_info, pass info down to
8337         svr4_current_sos_1.
8338         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8339         get_svr4_info.
8340         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8341         get_svr4_info.
8342         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8343         to get_svr4_info.
8344         (probes_table_remove_objfile_probes): Likewise.
8345         (register_solib_event_probe): Add info parameter.
8346         (solist_update_incremental): Pass info parameter down to
8347         svr4_read_so_list.
8348         (disable_probes_interface): Add info parameter.
8349         (svr4_handle_solib_event): Pass current_program_space to
8350         get_svr4_info.  Adjust disable_probes_interface cleanup.
8351         (svr4_create_probe_breakpoints): Add info parameter, pass it
8352         down to register_solib_event_probe.
8353         (svr4_create_solib_event_breakpoints): Add info parameter,
8354         pass it down to svr4_create_probe_breakpoints.
8355         (enable_break): Pass info down to
8356         svr4_create_solib_event_breakpoints.
8357         (svr4_solib_create_inferior_hook): Pass current_program_space to
8358         get_svr4_info.
8359         (svr4_clear_solib): Likewise.
8360
8361 2019-04-22  Pedro Alves  <palves@redhat.com>
8362
8363         * solib-svr4.c (svr4_free_objfile_observer): New.
8364         (probe_and_action::objfile): New field.
8365         (probes_table_htab_remove_objfile_probes)
8366         (probes_table_remove_objfile_probes): New functions.
8367         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8368         in the new probe_and_action.  Don't store the probe in 'lookup'.
8369         (svr4_create_probe_breakpoints): Pass objfile to
8370         register_solib_event_probe.
8371         (_initialize_svr4_solib): Register a free_objfile observer.
8372
8373 2019-04-19  Tom Tromey  <tom@tromey.com>
8374
8375         * common/queue.h: Remove.
8376
8377 2019-04-19  Tom Tromey  <tom@tromey.com>
8378
8379         * event-loop.c: Don't include "common/queue.h".
8380
8381 2019-04-19  Tom Tromey  <tom@tromey.com>
8382
8383         * remote.c (remote_target): Use delete.
8384         * remote-notif.h: Include <list>, not "common/queue.h".
8385         (notif_client_p): Remove typedef.
8386         (remote_notif_state): Add constructor, destructor, initializer.
8387         <notif_queue>: Now a std::list.
8388         (remote_notif_state_xfree): Don't declare.
8389         * remote-notif.c (remote_notif_process, handle_notification)
8390         (remote_notif_state_allocate): Update.
8391         (~remote_notif_state): Rename from remote_notif_state_xfree.
8392
8393 2019-04-19  Tom Tromey  <tom@tromey.com>
8394
8395         * symfile.c (reread_symbols): Update.
8396         * objfiles.c (objfile_register_static_link)
8397         (objfile_lookup_static_link): Update
8398         (~objfile) Don't delete static_links.
8399         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8400
8401 2019-04-19  Tom Tromey  <tom@tromey.com>
8402
8403         * type-stack.h (struct type_stack) <insert>: Constify string.
8404         * type-stack.c (type_stack::insert): Constify string.
8405         * gdbtypes.h (lookup_template_type): Update.
8406         (address_space_name_to_int): Update.
8407         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8408         const.
8409         (lookup_template_type): Make name const.
8410         * c-exp.y: Update rules.
8411         (lex_one_token, classify_name, classify_inner_name)
8412         (c_print_token): Update.
8413         * p-exp.y: Update rules.
8414         (yylex): Update.
8415         * f-exp.y: Update rules.
8416         (yylex): Update.
8417         * d-exp.y: Update rules.
8418         (lex_one_token, classify_name, classify_inner_name): Update.
8419         * parse.c (write_dollar_variable, copy_name): Return std::string.
8420         * parser-defs.h (copy_name): Change return type.
8421         * m2-exp.y: Update rules.
8422         (yylex): Update.
8423         * go-exp.y (lex_one_token): Update.
8424         Update rules.
8425         (classify_unsafe_function, classify_packaged_name)
8426         (classify_name, yylex): Update.
8427
8428 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8429
8430         * configure.ac: add --enable-source-highlight switch.
8431         * configure: Regenerate.
8432         * top.c (print_gdb_version): plumb --enable-source-highlight
8433         status to "show configuration".
8434
8435 2019-04-19  Tom Tromey  <tromey@adacore.com>
8436
8437         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8438         Check ADA_TYPE_P.
8439         (empty_record, ada_template_to_fixed_record_type_1)
8440         (template_to_static_fixed_type)
8441         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8442         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8443         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8444         macros.
8445
8446 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8447
8448         PR symtab/24423:
8449         * source.c (print_source_lines_base): Advance "iter" when a
8450         control character is seen.
8451
8452 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8453
8454         * inferior.h (struct infcall_suspend_state_deleter):
8455         Catch exception in destructor to avoid crash.
8456
8457 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8458
8459         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8460         close to the add_com "shell".
8461
8462 2019-04-18  Tom Tromey  <tromey@adacore.com>
8463
8464         * process-stratum-target.h (class process_stratum_target)
8465         <stratum>: Add "final".
8466
8467 2019-04-17  Tom Tromey  <tromey@adacore.com>
8468
8469         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8470         against nullptr before use.
8471
8472 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8473
8474         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8475
8476 2019-04-17  Jim Wilson  <jimw@sifive.com>
8477             Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8480         code read might fail, assume 4-byte breakpoint in that case.
8481
8482 2019-04-15  Leszek Swirski  <leszeks@google.com>
8483
8484         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8485         rather than a hand-rolled POD check when checking for forced MEMORY
8486         classification.
8487
8488 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8489
8490         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8491         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8492         function.
8493         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8494         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8495         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8496         declaration.
8497
8498 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8499
8500         * aarch64-linux-nat.c
8501         (aarch64_linux_nat_target::thread_architecture): Add override.
8502         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8503         each VQ.
8504
8505 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8506
8507         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8508
8509 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8512         target types of size 96-bits, add some additional comments, and
8513         check that the builtin type we found was the correct size.
8514
8515 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8516
8517         * utils.c (prompt_for_continue): Don't restore the styling at the
8518         end, as applied_style has the wrong value.  This fixes styling in
8519         long lists of file names that are interrupted by the "Continue?"
8520         prompt.
8521
8522 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8525         * c-lang.c (c_language_defn): Likewise.
8526         (cplus_language_defn): Likewise.
8527         (asm_language_defn): Likewise.
8528         (minimal_language_defn): Likewise.
8529         * d-lang.c (d_language_defn): Likewise.
8530         * f-lang.c (f_language_defn): Likewise.
8531         * go-lang.c (go_language_defn): Likewise.
8532         * language.c (unknown_language_defn): Likewise.
8533         (auto_language_defn): Likewise.
8534         * language.h (struct language_defn): Remove la_magic field.
8535         (LANG_MAGIC): Delete.
8536         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8537         * objc-lang.c (objc_language_defn): Likewise.
8538         * opencl-lang.c (opencl_language_defn): Likewise.
8539         * p-lang.c (pascal_language_defn): Likewise.
8540         * rust-lang.c (rust_language_defn): Likewise.
8541
8542 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8543
8544         * riscv-tdep.c (riscv_type_align): New function.
8545         (riscv_type_alignment): Delete.
8546         (riscv_arg_location): Use 'type_align'.
8547         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8548
8549 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8550
8551         * gdbtypes.c (type_align): A struct with no non-static fields also
8552         has alignment of 1.
8553
8554 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8555
8556         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8557         component to 0.
8558         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8559         member.
8560         (riscv_struct_info::analyse): New implementation using new
8561         analyse_inner member function.
8562         (riscv_struct_info::field_offset): New member function.
8563         (riscv_struct_info::m_offsets): New member variable.
8564         (riscv_struct_info::analyse_inner): New private member function,
8565         takes the old implementation of riscv_struct_info::analyse but
8566         extended to track field offsets.
8567         (riscv_call_arg_struct): Update the struct folding special cases
8568         to handle cases where empty C++ structs, which are non-zero
8569         length, are found.
8570         (riscv_arg_location): Initialise the length of each location, a
8571         non-zero length now indicates the location is in use.
8572         (riscv_push_dummy_call): Allow for the first location having a
8573         non-zero offset when setting up arguments.
8574         (riscv_return_value): Likewise, but for return values.
8575
8576 2019-04-11  Tom Tromey  <tromey@adacore.com>
8577
8578         * utils.c (internal_vproblem): Make "msg" const.
8579
8580 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8581
8582         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8583         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8584         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8585         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8586
8587 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8588
8589         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8590         function.
8591         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8592         of amd64_collect_native_gregset.
8593         (amd64_linux_nat_target::store_registers): Likewise.
8594
8595 2019-04-10  Tom Tromey  <tom@tromey.com>
8596
8597         * symtab.c (lookup_global_symbol_from_objfile)
8598         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8599         * objfiles.h (class separate_debug_iterator): New.
8600         (class separate_debug_range): New.
8601         (struct objfile) <separate_debug_objfiles>: New method.
8602         (objfile_separate_debug_iterate): Don't declare.
8603         * objfiles.c (separate_debug_iterator::operator++): Rename from
8604         objfile_separate_debug_iterate.
8605         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8606         iterator.
8607         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8608         iterator.
8609
8610 2019-04-10  Tom Tromey  <tom@tromey.com>
8611
8612         * symfile.c (reread_symbols): Remove old comment.
8613         * objfiles.c (free_all_objfiles): Fix a typo.
8614
8615 2019-04-10  Tom Tromey  <tom@tromey.com>
8616
8617         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8618         * minsyms.c (lookup_minimal_symbol): Use foreach.
8619         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8620         (lookup_minimal_symbol_solib_trampoline): Likewise.
8621         * symfile.c (reread_symbols): Use foreach.
8622
8623 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8624             Tom Tromey  <tromey@adacore.com>
8625
8626         PR rust/24414:
8627         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8628         (rust_lex_int_test): Change "value" to be LONGEST.
8629         (rust_lex_tests): Add test for long integer literal.
8630
8631 2019-04-09  Tom Tromey  <tromey@adacore.com>
8632
8633         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8634         to bool.
8635         (extended_remote_target::attach): Update.
8636         (remote_target::remote_notice_new_inferior): Update.
8637         (remote_target::add_current_inferior_and_thread): Update.
8638         * inferior.c (exit_inferior_1): Use "false".
8639         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8640
8641 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8642
8643         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8644         the "start" command.
8645
8646 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8647
8648         * python/py-inferior.c (infpy_thread_from_thread_handle):
8649         Adjust comments to reflect renaming of thread_from_thread_handle
8650         to thread_from_handle.  Adjust keywords.  Fix type error message.
8651         (inferior_object_methods): Add thread_from_handle.  Retain
8652         thread_from_thread_handle, but mark it as deprecated.
8653
8654 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8655
8656         * gdbthread.h (find_thread_by_handle): Revise declaration.
8657         * thread.c (find_thread_by_handle): Likewise.  Adjust
8658         implementation too.
8659         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8660         support for buffer objects as handles.
8661
8662 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8663
8664         * python/py-infthread.c (thpy_thread_handle): New function.
8665         (thread_object_methods): Register thpy_thread_handle.
8666
8667 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8668
8669         * gdbthread.h (thread_to_thread_handle): Declare.
8670         * thread.c (gdbtypes.h): Include.
8671         (thread_to_thread_handle): New function.
8672
8673         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8674         (target_thread_info_to_thread_handle): Declare.
8675         * target.c (target_thread_info_to_thread_handle): New function.
8676         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8677         * target-delegates.c: Regenerate.
8678
8679         * linux-thread-db.c (class thread_db_target): Add method
8680         thread_info_to_thread_handle.
8681         (thread_db_target::thread_info_to_thread_handle): Define.
8682         * remote.c (class remote_target): Add new method
8683         thread_info_to_thread_handle.
8684         (remote_target::thread_info_to_thread_handle): Define.
8685
8686 2019-04-08  Pedro Alves  <palves@redhat.com>
8687
8688         * common/common-exceptions.c (throw_exception): Don't create
8689         named object to throw; throw directly.
8690         (throw_it): Likewise.  Don't initialize gdb_exception::message
8691         here, with new; pass FMT and AP to the ctor instead.
8692         * common/common-exceptions.h: Include <string>.
8693         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8694         const char *, va_list)): New ctor.  Use std::make_shared.
8695         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8696         errors)): Delete.
8697         (gdb_exception_error::gdb_exception_error(enum errors, const char
8698         *, va_list)): New.
8699         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8700         Add assertion.
8701         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8702         errors)): Delete.
8703         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8704         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8705         Add assertion.
8706
8707 2019-04-08  Tom Tromey  <tom@tromey.com>
8708
8709         * valops.c (value_rtti_indirect_type): Replace throw_exception
8710         with throw.
8711         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8712         with throw.
8713         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8714         throw.
8715         * target.c (target_translate_tls_address): Replace throw_exception
8716         with throw.
8717         * stack.c (frame_apply_command_count): Replace throw_exception
8718         with throw.
8719         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8720         throw.
8721         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8722         with throw.
8723         * rs6000-tdep.c (rs6000_frame_cache)
8724         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8725         * remote.c: Replace throw_exception with throw.
8726         * record-full.c (record_full_message, record_full_wait_1)
8727         (record_full_restore): Replace throw_exception with throw.
8728         * record-btrace.c:
8729         (get_thread_current_frame_id, record_btrace_start_replaying)
8730         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8731         (cmd_record_btrace_start): Replace throw_exception with throw.
8732         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8733         throw.
8734         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8735         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8736         * linespec.c:
8737         (find_linespec_symbols): Replace throw_exception with throw.
8738         * infrun.c (displaced_step_prepare, resume): Replace
8739         throw_exception with throw.
8740         * infcmd.c (post_create_inferior): Replace throw_exception with
8741         throw.
8742         * inf-loop.c (inferior_event_handler): Replace throw_exception
8743         with throw.
8744         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8745         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8746         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8747         (get_prev_frame_always, get_frame_pc_if_available)
8748         (get_frame_address_in_block_if_available, get_frame_language):
8749         Replace throw_exception with throw.
8750         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8751         throw_exception with throw.
8752         * eval.c (fetch_subexp_value, evaluate_var_value)
8753         (evaluate_funcall, evaluate_subexp_standard): Replace
8754         throw_exception with throw.
8755         * dwarf2loc.c (call_site_find_chain)
8756         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8757         Replace throw_exception with throw.
8758         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8759         with throw.
8760         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8761         throw.
8762         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8763         * completer.c (complete_line_internal): Replace throw_exception
8764         with throw.
8765         * compile/compile-object-run.c (compile_object_run): Replace
8766         throw_exception with throw.
8767         * cli/cli-script.c (process_next_line): Replace throw_exception
8768         with throw.
8769         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8770         (btrace_enable, btrace_maint_update_pt_packets): Replace
8771         throw_exception with throw.
8772         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8773         throw_exception with throw.
8774         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8775         throw_exception with throw.
8776         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8777         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8778         * aarch64-tdep.c (aarch64_make_prologue_cache)
8779         (aarch64_make_stub_cache): Replace throw_exception with throw.
8780
8781 2019-04-08  Tom Tromey  <tom@tromey.com>
8782
8783         * common/common-exceptions.c (throw_exception): Rename from
8784         throw_exception_cxx.  Remove old copy.  Make argument const.
8785         (throw_it): Create and throw exception objects directly.
8786         * common/common-exceptions.h (throw_exception): Make argument
8787         const.
8788         (struct gdb_exception_error): Add constructor.
8789         (struct gdb_exception_quit): Add constructor.
8790
8791 2019-04-08  Tom Tromey  <tom@tromey.com>
8792
8793         * common/common-exceptions.h (exception_rethrow): Don't declare.
8794         (TRY_SJLJ): Update comment.
8795         (TRY, CATCH, END_CATCH): Remove.
8796         * common/common-exceptions.c (exception_rethrow): Remove.
8797
8798 2019-04-08  Tom Tromey  <tom@tromey.com>
8799
8800         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8801         Remove.
8802         (gdb_exception_error): Rename from
8803         gdb_exception_RETURN_MASK_ERROR.
8804         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8805         (gdb_quit_bad_alloc): Update.
8806         * aarch64-tdep.c: Update.
8807         * ada-lang.c: Update.
8808         * ada-typeprint.c: Update.
8809         * ada-valprint.c: Update.
8810         * amd64-tdep.c: Update.
8811         * arch-utils.c: Update.
8812         * break-catch-throw.c: Update.
8813         * breakpoint.c: Update.
8814         * btrace.c: Update.
8815         * c-varobj.c: Update.
8816         * cli/cli-cmds.c: Update.
8817         * cli/cli-interp.c: Update.
8818         * cli/cli-script.c: Update.
8819         * common/common-exceptions.c: Update.
8820         * common/new-op.c: Update.
8821         * common/selftest.c: Update.
8822         * compile/compile-c-symbols.c: Update.
8823         * compile/compile-cplus-symbols.c: Update.
8824         * compile/compile-object-load.c: Update.
8825         * compile/compile-object-run.c: Update.
8826         * completer.c: Update.
8827         * corelow.c: Update.
8828         * cp-abi.c: Update.
8829         * cp-support.c: Update.
8830         * cp-valprint.c: Update.
8831         * darwin-nat.c: Update.
8832         * disasm-selftests.c: Update.
8833         * dtrace-probe.c: Update.
8834         * dwarf-index-cache.c: Update.
8835         * dwarf-index-write.c: Update.
8836         * dwarf2-frame-tailcall.c: Update.
8837         * dwarf2-frame.c: Update.
8838         * dwarf2loc.c: Update.
8839         * dwarf2read.c: Update.
8840         * eval.c: Update.
8841         * event-loop.c: Update.
8842         * event-top.c: Update.
8843         * exec.c: Update.
8844         * f-valprint.c: Update.
8845         * fbsd-tdep.c: Update.
8846         * frame-unwind.c: Update.
8847         * frame.c: Update.
8848         * gdbtypes.c: Update.
8849         * gnu-v3-abi.c: Update.
8850         * guile/guile-internal.h: Update.
8851         * guile/scm-block.c: Update.
8852         * guile/scm-breakpoint.c: Update.
8853         * guile/scm-cmd.c: Update.
8854         * guile/scm-disasm.c: Update.
8855         * guile/scm-frame.c: Update.
8856         * guile/scm-lazy-string.c: Update.
8857         * guile/scm-math.c: Update.
8858         * guile/scm-param.c: Update.
8859         * guile/scm-ports.c: Update.
8860         * guile/scm-pretty-print.c: Update.
8861         * guile/scm-symbol.c: Update.
8862         * guile/scm-symtab.c: Update.
8863         * guile/scm-type.c: Update.
8864         * guile/scm-value.c: Update.
8865         * i386-linux-tdep.c: Update.
8866         * i386-tdep.c: Update.
8867         * inf-loop.c: Update.
8868         * infcall.c: Update.
8869         * infcmd.c: Update.
8870         * infrun.c: Update.
8871         * jit.c: Update.
8872         * language.c: Update.
8873         * linespec.c: Update.
8874         * linux-fork.c: Update.
8875         * linux-nat.c: Update.
8876         * linux-tdep.c: Update.
8877         * linux-thread-db.c: Update.
8878         * main.c: Update.
8879         * mi/mi-cmd-break.c: Update.
8880         * mi/mi-cmd-stack.c: Update.
8881         * mi/mi-interp.c: Update.
8882         * mi/mi-main.c: Update.
8883         * objc-lang.c: Update.
8884         * p-valprint.c: Update.
8885         * parse.c: Update.
8886         * ppc-linux-tdep.c: Update.
8887         * printcmd.c: Update.
8888         * python/py-arch.c: Update.
8889         * python/py-breakpoint.c: Update.
8890         * python/py-cmd.c: Update.
8891         * python/py-finishbreakpoint.c: Update.
8892         * python/py-frame.c: Update.
8893         * python/py-framefilter.c: Update.
8894         * python/py-gdb-readline.c: Update.
8895         * python/py-inferior.c: Update.
8896         * python/py-infthread.c: Update.
8897         * python/py-lazy-string.c: Update.
8898         * python/py-linetable.c: Update.
8899         * python/py-objfile.c: Update.
8900         * python/py-param.c: Update.
8901         * python/py-prettyprint.c: Update.
8902         * python/py-progspace.c: Update.
8903         * python/py-record-btrace.c: Update.
8904         * python/py-record.c: Update.
8905         * python/py-symbol.c: Update.
8906         * python/py-type.c: Update.
8907         * python/py-unwind.c: Update.
8908         * python/py-utils.c: Update.
8909         * python/py-value.c: Update.
8910         * python/python.c: Update.
8911         * record-btrace.c: Update.
8912         * record-full.c: Update.
8913         * remote-fileio.c: Update.
8914         * remote.c: Update.
8915         * riscv-tdep.c: Update.
8916         * rs6000-aix-tdep.c: Update.
8917         * rs6000-tdep.c: Update.
8918         * rust-exp.y: Update.
8919         * rust-lang.c: Update.
8920         * s390-tdep.c: Update.
8921         * selftest-arch.c: Update.
8922         * solib-dsbt.c: Update.
8923         * solib-frv.c: Update.
8924         * solib-spu.c: Update.
8925         * solib-svr4.c: Update.
8926         * solib.c: Update.
8927         * sparc64-linux-tdep.c: Update.
8928         * stack.c: Update.
8929         * symfile-mem.c: Update.
8930         * symmisc.c: Update.
8931         * target.c: Update.
8932         * thread.c: Update.
8933         * top.c: Update.
8934         * tracefile-tfile.c: Update.
8935         * tui/tui.c: Update.
8936         * typeprint.c: Update.
8937         * unittests/cli-utils-selftests.c: Update.
8938         * unittests/parse-connection-spec-selftests.c: Update.
8939         * valops.c: Update.
8940         * valprint.c: Update.
8941         * value.c: Update.
8942         * varobj.c: Update.
8943         * windows-nat.c: Update.
8944         * x86-linux-nat.c: Update.
8945         * xml-support.c: Update.
8946
8947 2019-04-08  Tom Tromey  <tom@tromey.com>
8948
8949         * xml-support.c: Use C++ exception handling.
8950         * x86-linux-nat.c: Use C++ exception handling.
8951         * windows-nat.c: Use C++ exception handling.
8952         * varobj.c: Use C++ exception handling.
8953         * value.c: Use C++ exception handling.
8954         * valprint.c: Use C++ exception handling.
8955         * valops.c: Use C++ exception handling.
8956         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8957         handling.
8958         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8959         * typeprint.c: Use C++ exception handling.
8960         * tui/tui.c: Use C++ exception handling.
8961         * tracefile-tfile.c: Use C++ exception handling.
8962         * top.c: Use C++ exception handling.
8963         * thread.c: Use C++ exception handling.
8964         * target.c: Use C++ exception handling.
8965         * symmisc.c: Use C++ exception handling.
8966         * symfile-mem.c: Use C++ exception handling.
8967         * stack.c: Use C++ exception handling.
8968         * sparc64-linux-tdep.c: Use C++ exception handling.
8969         * solib.c: Use C++ exception handling.
8970         * solib-svr4.c: Use C++ exception handling.
8971         * solib-spu.c: Use C++ exception handling.
8972         * solib-frv.c: Use C++ exception handling.
8973         * solib-dsbt.c: Use C++ exception handling.
8974         * selftest-arch.c: Use C++ exception handling.
8975         * s390-tdep.c: Use C++ exception handling.
8976         * rust-lang.c: Use C++ exception handling.
8977         * rust-exp.y: Use C++ exception handling.
8978         * rs6000-tdep.c: Use C++ exception handling.
8979         * rs6000-aix-tdep.c: Use C++ exception handling.
8980         * riscv-tdep.c: Use C++ exception handling.
8981         * remote.c: Use C++ exception handling.
8982         * remote-fileio.c: Use C++ exception handling.
8983         * record-full.c: Use C++ exception handling.
8984         * record-btrace.c: Use C++ exception handling.
8985         * python/python.c: Use C++ exception handling.
8986         * python/py-value.c: Use C++ exception handling.
8987         * python/py-utils.c: Use C++ exception handling.
8988         * python/py-unwind.c: Use C++ exception handling.
8989         * python/py-type.c: Use C++ exception handling.
8990         * python/py-symbol.c: Use C++ exception handling.
8991         * python/py-record.c: Use C++ exception handling.
8992         * python/py-record-btrace.c: Use C++ exception handling.
8993         * python/py-progspace.c: Use C++ exception handling.
8994         * python/py-prettyprint.c: Use C++ exception handling.
8995         * python/py-param.c: Use C++ exception handling.
8996         * python/py-objfile.c: Use C++ exception handling.
8997         * python/py-linetable.c: Use C++ exception handling.
8998         * python/py-lazy-string.c: Use C++ exception handling.
8999         * python/py-infthread.c: Use C++ exception handling.
9000         * python/py-inferior.c: Use C++ exception handling.
9001         * python/py-gdb-readline.c: Use C++ exception handling.
9002         * python/py-framefilter.c: Use C++ exception handling.
9003         * python/py-frame.c: Use C++ exception handling.
9004         * python/py-finishbreakpoint.c: Use C++ exception handling.
9005         * python/py-cmd.c: Use C++ exception handling.
9006         * python/py-breakpoint.c: Use C++ exception handling.
9007         * python/py-arch.c: Use C++ exception handling.
9008         * printcmd.c: Use C++ exception handling.
9009         * ppc-linux-tdep.c: Use C++ exception handling.
9010         * parse.c: Use C++ exception handling.
9011         * p-valprint.c: Use C++ exception handling.
9012         * objc-lang.c: Use C++ exception handling.
9013         * mi/mi-main.c: Use C++ exception handling.
9014         * mi/mi-interp.c: Use C++ exception handling.
9015         * mi/mi-cmd-stack.c: Use C++ exception handling.
9016         * mi/mi-cmd-break.c: Use C++ exception handling.
9017         * main.c: Use C++ exception handling.
9018         * linux-thread-db.c: Use C++ exception handling.
9019         * linux-tdep.c: Use C++ exception handling.
9020         * linux-nat.c: Use C++ exception handling.
9021         * linux-fork.c: Use C++ exception handling.
9022         * linespec.c: Use C++ exception handling.
9023         * language.c: Use C++ exception handling.
9024         * jit.c: Use C++ exception handling.
9025         * infrun.c: Use C++ exception handling.
9026         * infcmd.c: Use C++ exception handling.
9027         * infcall.c: Use C++ exception handling.
9028         * inf-loop.c: Use C++ exception handling.
9029         * i386-tdep.c: Use C++ exception handling.
9030         * i386-linux-tdep.c: Use C++ exception handling.
9031         * guile/scm-value.c: Use C++ exception handling.
9032         * guile/scm-type.c: Use C++ exception handling.
9033         * guile/scm-symtab.c: Use C++ exception handling.
9034         * guile/scm-symbol.c: Use C++ exception handling.
9035         * guile/scm-pretty-print.c: Use C++ exception handling.
9036         * guile/scm-ports.c: Use C++ exception handling.
9037         * guile/scm-param.c: Use C++ exception handling.
9038         * guile/scm-math.c: Use C++ exception handling.
9039         * guile/scm-lazy-string.c: Use C++ exception handling.
9040         * guile/scm-frame.c: Use C++ exception handling.
9041         * guile/scm-disasm.c: Use C++ exception handling.
9042         * guile/scm-cmd.c: Use C++ exception handling.
9043         * guile/scm-breakpoint.c: Use C++ exception handling.
9044         * guile/scm-block.c: Use C++ exception handling.
9045         * guile/guile-internal.h: Use C++ exception handling.
9046         * gnu-v3-abi.c: Use C++ exception handling.
9047         * gdbtypes.c: Use C++ exception handling.
9048         * frame.c: Use C++ exception handling.
9049         * frame-unwind.c: Use C++ exception handling.
9050         * fbsd-tdep.c: Use C++ exception handling.
9051         * f-valprint.c: Use C++ exception handling.
9052         * exec.c: Use C++ exception handling.
9053         * event-top.c: Use C++ exception handling.
9054         * event-loop.c: Use C++ exception handling.
9055         * eval.c: Use C++ exception handling.
9056         * dwarf2read.c: Use C++ exception handling.
9057         * dwarf2loc.c: Use C++ exception handling.
9058         * dwarf2-frame.c: Use C++ exception handling.
9059         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9060         * dwarf-index-write.c: Use C++ exception handling.
9061         * dwarf-index-cache.c: Use C++ exception handling.
9062         * dtrace-probe.c: Use C++ exception handling.
9063         * disasm-selftests.c: Use C++ exception handling.
9064         * darwin-nat.c: Use C++ exception handling.
9065         * cp-valprint.c: Use C++ exception handling.
9066         * cp-support.c: Use C++ exception handling.
9067         * cp-abi.c: Use C++ exception handling.
9068         * corelow.c: Use C++ exception handling.
9069         * completer.c: Use C++ exception handling.
9070         * compile/compile-object-run.c: Use C++ exception handling.
9071         * compile/compile-object-load.c: Use C++ exception handling.
9072         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9073         * compile/compile-c-symbols.c: Use C++ exception handling.
9074         * common/selftest.c: Use C++ exception handling.
9075         * common/new-op.c: Use C++ exception handling.
9076         * cli/cli-script.c: Use C++ exception handling.
9077         * cli/cli-interp.c: Use C++ exception handling.
9078         * cli/cli-cmds.c: Use C++ exception handling.
9079         * c-varobj.c: Use C++ exception handling.
9080         * btrace.c: Use C++ exception handling.
9081         * breakpoint.c: Use C++ exception handling.
9082         * break-catch-throw.c: Use C++ exception handling.
9083         * arch-utils.c: Use C++ exception handling.
9084         * amd64-tdep.c: Use C++ exception handling.
9085         * ada-valprint.c: Use C++ exception handling.
9086         * ada-typeprint.c: Use C++ exception handling.
9087         * ada-lang.c: Use C++ exception handling.
9088         * aarch64-tdep.c: Use C++ exception handling.
9089
9090 2019-04-08  Tom Tromey  <tom@tromey.com>
9091
9092         * xml-support.c (gdb_xml_parser::parse): Update.
9093         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9094         * value.c (show_convenience): Update.
9095         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9096         (test_parse_flags_qcs): Update.
9097         * thread.c (thr_try_catch_cmd): Update.
9098         * target.c (target_translate_tls_address): Update.
9099         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9100         (info_frame_command_core, frame_apply_command_count): Update.
9101         * rust-exp.y (rust_lex_exception_test): Update.
9102         * riscv-tdep.c (riscv_print_one_register_info): Update.
9103         * remote.c (remote_target::enable_btrace): Update.
9104         * record-btrace.c (record_btrace_enable_warn): Update.
9105         * python/py-utils.c (gdbpy_convert_exception): Update.
9106         * printcmd.c (do_one_display, print_variable_and_value): Update.
9107         * mi/mi-main.c (mi_print_exception): Update.
9108         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9109         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9110         * linux-nat.c (linux_nat_target::attach): Update.
9111         * linux-fork.c (class scoped_switch_fork_info): Update.
9112         * infrun.c (displaced_step_prepare): Update.
9113         * infcall.c (call_function_by_hand_dummy): Update.
9114         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9115         * gnu-v3-abi.c (print_one_vtable): Update.
9116         * frame.c (get_prev_frame_always): Update.
9117         * f-valprint.c (info_common_command_for_block): Update.
9118         * exec.c (try_open_exec_file): Update.
9119         * exceptions.c (print_exception, exception_print)
9120         (exception_fprintf, exception_print_same): Update.
9121         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9122         * dwarf-index-cache.c (index_cache::store)
9123         (index_cache::lookup_gdb_index): Update.
9124         * darwin-nat.c (maybe_cache_shell): Update.
9125         * cp-valprint.c (cp_print_value_fields): Update.
9126         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9127         (gcc_cplus_symbol_address): Update.
9128         * compile/compile-c-symbols.c (gcc_convert_symbol)
9129         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9130         * common/selftest.c: Update.
9131         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9132         a std::string.
9133         (exception_try_scope_entry, exception_try_scope_exit): Don't
9134         declare.
9135         (struct exception_try_scope): Remove.
9136         (TRY): Don't use exception_try_scope.
9137         (struct gdb_exception): Add constructor, operator=.
9138         <what>: New method.
9139         (struct gdb_exception_RETURN_MASK_ALL)
9140         (struct gdb_exception_RETURN_MASK_ERROR)
9141         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9142         (struct gdb_quit_bad_alloc): Update.
9143         * common/common-exceptions.c (exception_none): Change
9144         initializer.
9145         (struct catcher) <state, exception>: Initialize inline.
9146         <prev>: Remove member.
9147         (current_catcher): Remove.
9148         (catchers): New global.
9149         (exceptions_state_mc_init): Simplify.
9150         (catcher_pop): Remove.
9151         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9152         (try_scope_depth, exception_try_scope_entry)
9153         (exception_try_scope_exit): Remove.
9154         (throw_exception_sjlj): Update.
9155         (exception_messages, exception_messages_size): Remove.
9156         (throw_it): Simplify.
9157         (gdb_exception_sliced_copy): Remove.
9158         (throw_exception_cxx): Update.
9159         * cli/cli-script.c (script_from_file): Update.
9160         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9161         Update.
9162         * ada-valprint.c (ada_val_print): Update.
9163         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9164         (create_excep_cond_exprs): Update.
9165
9166 2019-04-08  Tom Tromey  <tom@tromey.com>
9167
9168         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9169         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9170         (TRY, CATCH, END_CATCH): Remove some definitions.
9171         * common/common-exceptions.c: Don't use GDB_XCPT.
9172         (catcher_list_size): Remove.
9173         (throw_exception, throw_it): Simplify.
9174
9175 2019-04-05  Tom Tromey  <tom@tromey.com>
9176
9177         Revert the header-sorting patch.
9178         * ft32-tdep.c: Revert.
9179         * frv-tdep.c: Revert.
9180         * frv-linux-tdep.c: Revert.
9181         * frame.c: Revert.
9182         * frame-unwind.c: Revert.
9183         * frame-base.c: Revert.
9184         * fork-child.c: Revert.
9185         * findvar.c: Revert.
9186         * findcmd.c: Revert.
9187         * filesystem.c: Revert.
9188         * filename-seen-cache.h: Revert.
9189         * filename-seen-cache.c: Revert.
9190         * fbsd-tdep.c: Revert.
9191         * fbsd-nat.h: Revert.
9192         * fbsd-nat.c: Revert.
9193         * f-valprint.c: Revert.
9194         * f-typeprint.c: Revert.
9195         * f-lang.c: Revert.
9196         * extension.h: Revert.
9197         * extension.c: Revert.
9198         * extension-priv.h: Revert.
9199         * expprint.c: Revert.
9200         * exec.h: Revert.
9201         * exec.c: Revert.
9202         * exceptions.c: Revert.
9203         * event-top.c: Revert.
9204         * event-loop.c: Revert.
9205         * eval.c: Revert.
9206         * elfread.c: Revert.
9207         * dwarf2read.h: Revert.
9208         * dwarf2read.c: Revert.
9209         * dwarf2loc.c: Revert.
9210         * dwarf2expr.h: Revert.
9211         * dwarf2expr.c: Revert.
9212         * dwarf2-frame.c: Revert.
9213         * dwarf2-frame-tailcall.c: Revert.
9214         * dwarf-index-write.h: Revert.
9215         * dwarf-index-write.c: Revert.
9216         * dwarf-index-common.c: Revert.
9217         * dwarf-index-cache.h: Revert.
9218         * dwarf-index-cache.c: Revert.
9219         * dummy-frame.c: Revert.
9220         * dtrace-probe.c: Revert.
9221         * disasm.h: Revert.
9222         * disasm.c: Revert.
9223         * disasm-selftests.c: Revert.
9224         * dictionary.c: Revert.
9225         * dicos-tdep.c: Revert.
9226         * demangle.c: Revert.
9227         * dcache.h: Revert.
9228         * dcache.c: Revert.
9229         * darwin-nat.h: Revert.
9230         * darwin-nat.c: Revert.
9231         * darwin-nat-info.c: Revert.
9232         * d-valprint.c: Revert.
9233         * d-namespace.c: Revert.
9234         * d-lang.c: Revert.
9235         * ctf.c: Revert.
9236         * csky-tdep.c: Revert.
9237         * csky-linux-tdep.c: Revert.
9238         * cris-tdep.c: Revert.
9239         * cris-linux-tdep.c: Revert.
9240         * cp-valprint.c: Revert.
9241         * cp-support.c: Revert.
9242         * cp-namespace.c: Revert.
9243         * cp-abi.c: Revert.
9244         * corelow.c: Revert.
9245         * corefile.c: Revert.
9246         * continuations.c: Revert.
9247         * completer.h: Revert.
9248         * completer.c: Revert.
9249         * complaints.c: Revert.
9250         * coffread.c: Revert.
9251         * coff-pe-read.c: Revert.
9252         * cli-out.h: Revert.
9253         * cli-out.c: Revert.
9254         * charset.c: Revert.
9255         * c-varobj.c: Revert.
9256         * c-valprint.c: Revert.
9257         * c-typeprint.c: Revert.
9258         * c-lang.c: Revert.
9259         * buildsym.c: Revert.
9260         * buildsym-legacy.c: Revert.
9261         * build-id.h: Revert.
9262         * build-id.c: Revert.
9263         * btrace.c: Revert.
9264         * bsd-uthread.c: Revert.
9265         * breakpoint.h: Revert.
9266         * breakpoint.c: Revert.
9267         * break-catch-throw.c: Revert.
9268         * break-catch-syscall.c: Revert.
9269         * break-catch-sig.c: Revert.
9270         * blockframe.c: Revert.
9271         * block.c: Revert.
9272         * bfin-tdep.c: Revert.
9273         * bfin-linux-tdep.c: Revert.
9274         * bfd-target.c: Revert.
9275         * bcache.c: Revert.
9276         * ax-general.c: Revert.
9277         * ax-gdb.h: Revert.
9278         * ax-gdb.c: Revert.
9279         * avr-tdep.c: Revert.
9280         * auxv.c: Revert.
9281         * auto-load.c: Revert.
9282         * arm-wince-tdep.c: Revert.
9283         * arm-tdep.c: Revert.
9284         * arm-symbian-tdep.c: Revert.
9285         * arm-pikeos-tdep.c: Revert.
9286         * arm-obsd-tdep.c: Revert.
9287         * arm-nbsd-tdep.c: Revert.
9288         * arm-nbsd-nat.c: Revert.
9289         * arm-linux-tdep.c: Revert.
9290         * arm-linux-nat.c: Revert.
9291         * arm-fbsd-tdep.c: Revert.
9292         * arm-fbsd-nat.c: Revert.
9293         * arm-bsd-tdep.c: Revert.
9294         * arch-utils.c: Revert.
9295         * arc-tdep.c: Revert.
9296         * arc-newlib-tdep.c: Revert.
9297         * annotate.h: Revert.
9298         * annotate.c: Revert.
9299         * amd64-windows-tdep.c: Revert.
9300         * amd64-windows-nat.c: Revert.
9301         * amd64-tdep.c: Revert.
9302         * amd64-sol2-tdep.c: Revert.
9303         * amd64-obsd-tdep.c: Revert.
9304         * amd64-obsd-nat.c: Revert.
9305         * amd64-nbsd-tdep.c: Revert.
9306         * amd64-nbsd-nat.c: Revert.
9307         * amd64-nat.c: Revert.
9308         * amd64-linux-tdep.c: Revert.
9309         * amd64-linux-nat.c: Revert.
9310         * amd64-fbsd-tdep.c: Revert.
9311         * amd64-fbsd-nat.c: Revert.
9312         * amd64-dicos-tdep.c: Revert.
9313         * amd64-darwin-tdep.c: Revert.
9314         * amd64-bsd-nat.c: Revert.
9315         * alpha-tdep.c: Revert.
9316         * alpha-obsd-tdep.c: Revert.
9317         * alpha-nbsd-tdep.c: Revert.
9318         * alpha-mdebug-tdep.c: Revert.
9319         * alpha-linux-tdep.c: Revert.
9320         * alpha-linux-nat.c: Revert.
9321         * alpha-bsd-tdep.c: Revert.
9322         * alpha-bsd-nat.c: Revert.
9323         * aix-thread.c: Revert.
9324         * agent.c: Revert.
9325         * addrmap.c: Revert.
9326         * ada-varobj.c: Revert.
9327         * ada-valprint.c: Revert.
9328         * ada-typeprint.c: Revert.
9329         * ada-tasks.c: Revert.
9330         * ada-lang.c: Revert.
9331         * aarch64-tdep.c: Revert.
9332         * aarch64-ravenscar-thread.c: Revert.
9333         * aarch64-newlib-tdep.c: Revert.
9334         * aarch64-linux-tdep.c: Revert.
9335         * aarch64-linux-nat.c: Revert.
9336         * aarch64-fbsd-tdep.c: Revert.
9337         * aarch64-fbsd-nat.c: Revert.
9338         * aarch32-linux-nat.c: Revert.
9339
9340 2019-04-05  Tom Tromey  <tom@tromey.com>
9341
9342         * ft32-tdep.c: Sort headers.
9343         * frv-tdep.c: Sort headers.
9344         * frv-linux-tdep.c: Sort headers.
9345         * frame.c: Sort headers.
9346         * frame-unwind.c: Sort headers.
9347         * frame-base.c: Sort headers.
9348         * fork-child.c: Sort headers.
9349         * findvar.c: Sort headers.
9350         * findcmd.c: Sort headers.
9351         * filesystem.c: Sort headers.
9352         * filename-seen-cache.h: Sort headers.
9353         * filename-seen-cache.c: Sort headers.
9354         * fbsd-tdep.c: Sort headers.
9355         * fbsd-nat.h: Sort headers.
9356         * fbsd-nat.c: Sort headers.
9357         * f-valprint.c: Sort headers.
9358         * f-typeprint.c: Sort headers.
9359         * f-lang.c: Sort headers.
9360         * extension.h: Sort headers.
9361         * extension.c: Sort headers.
9362         * extension-priv.h: Sort headers.
9363         * expprint.c: Sort headers.
9364         * exec.h: Sort headers.
9365         * exec.c: Sort headers.
9366         * exceptions.c: Sort headers.
9367         * event-top.c: Sort headers.
9368         * event-loop.c: Sort headers.
9369         * eval.c: Sort headers.
9370         * elfread.c: Sort headers.
9371         * dwarf2read.h: Sort headers.
9372         * dwarf2read.c: Sort headers.
9373         * dwarf2loc.c: Sort headers.
9374         * dwarf2expr.h: Sort headers.
9375         * dwarf2expr.c: Sort headers.
9376         * dwarf2-frame.c: Sort headers.
9377         * dwarf2-frame-tailcall.c: Sort headers.
9378         * dwarf-index-write.h: Sort headers.
9379         * dwarf-index-write.c: Sort headers.
9380         * dwarf-index-common.c: Sort headers.
9381         * dwarf-index-cache.h: Sort headers.
9382         * dwarf-index-cache.c: Sort headers.
9383         * dummy-frame.c: Sort headers.
9384         * dtrace-probe.c: Sort headers.
9385         * disasm.h: Sort headers.
9386         * disasm.c: Sort headers.
9387         * disasm-selftests.c: Sort headers.
9388         * dictionary.c: Sort headers.
9389         * dicos-tdep.c: Sort headers.
9390         * demangle.c: Sort headers.
9391         * dcache.h: Sort headers.
9392         * dcache.c: Sort headers.
9393         * darwin-nat.h: Sort headers.
9394         * darwin-nat.c: Sort headers.
9395         * darwin-nat-info.c: Sort headers.
9396         * d-valprint.c: Sort headers.
9397         * d-namespace.c: Sort headers.
9398         * d-lang.c: Sort headers.
9399         * ctf.c: Sort headers.
9400         * csky-tdep.c: Sort headers.
9401         * csky-linux-tdep.c: Sort headers.
9402         * cris-tdep.c: Sort headers.
9403         * cris-linux-tdep.c: Sort headers.
9404         * cp-valprint.c: Sort headers.
9405         * cp-support.c: Sort headers.
9406         * cp-namespace.c: Sort headers.
9407         * cp-abi.c: Sort headers.
9408         * corelow.c: Sort headers.
9409         * corefile.c: Sort headers.
9410         * continuations.c: Sort headers.
9411         * completer.h: Sort headers.
9412         * completer.c: Sort headers.
9413         * complaints.c: Sort headers.
9414         * coffread.c: Sort headers.
9415         * coff-pe-read.c: Sort headers.
9416         * cli-out.h: Sort headers.
9417         * cli-out.c: Sort headers.
9418         * charset.c: Sort headers.
9419         * c-varobj.c: Sort headers.
9420         * c-valprint.c: Sort headers.
9421         * c-typeprint.c: Sort headers.
9422         * c-lang.c: Sort headers.
9423         * buildsym.c: Sort headers.
9424         * buildsym-legacy.c: Sort headers.
9425         * build-id.h: Sort headers.
9426         * build-id.c: Sort headers.
9427         * btrace.c: Sort headers.
9428         * bsd-uthread.c: Sort headers.
9429         * breakpoint.h: Sort headers.
9430         * breakpoint.c: Sort headers.
9431         * break-catch-throw.c: Sort headers.
9432         * break-catch-syscall.c: Sort headers.
9433         * break-catch-sig.c: Sort headers.
9434         * blockframe.c: Sort headers.
9435         * block.c: Sort headers.
9436         * bfin-tdep.c: Sort headers.
9437         * bfin-linux-tdep.c: Sort headers.
9438         * bfd-target.c: Sort headers.
9439         * bcache.c: Sort headers.
9440         * ax-general.c: Sort headers.
9441         * ax-gdb.h: Sort headers.
9442         * ax-gdb.c: Sort headers.
9443         * avr-tdep.c: Sort headers.
9444         * auxv.c: Sort headers.
9445         * auto-load.c: Sort headers.
9446         * arm-wince-tdep.c: Sort headers.
9447         * arm-tdep.c: Sort headers.
9448         * arm-symbian-tdep.c: Sort headers.
9449         * arm-pikeos-tdep.c: Sort headers.
9450         * arm-obsd-tdep.c: Sort headers.
9451         * arm-nbsd-tdep.c: Sort headers.
9452         * arm-nbsd-nat.c: Sort headers.
9453         * arm-linux-tdep.c: Sort headers.
9454         * arm-linux-nat.c: Sort headers.
9455         * arm-fbsd-tdep.c: Sort headers.
9456         * arm-fbsd-nat.c: Sort headers.
9457         * arm-bsd-tdep.c: Sort headers.
9458         * arch-utils.c: Sort headers.
9459         * arc-tdep.c: Sort headers.
9460         * arc-newlib-tdep.c: Sort headers.
9461         * annotate.h: Sort headers.
9462         * annotate.c: Sort headers.
9463         * amd64-windows-tdep.c: Sort headers.
9464         * amd64-windows-nat.c: Sort headers.
9465         * amd64-tdep.c: Sort headers.
9466         * amd64-sol2-tdep.c: Sort headers.
9467         * amd64-obsd-tdep.c: Sort headers.
9468         * amd64-obsd-nat.c: Sort headers.
9469         * amd64-nbsd-tdep.c: Sort headers.
9470         * amd64-nbsd-nat.c: Sort headers.
9471         * amd64-nat.c: Sort headers.
9472         * amd64-linux-tdep.c: Sort headers.
9473         * amd64-linux-nat.c: Sort headers.
9474         * amd64-fbsd-tdep.c: Sort headers.
9475         * amd64-fbsd-nat.c: Sort headers.
9476         * amd64-dicos-tdep.c: Sort headers.
9477         * amd64-darwin-tdep.c: Sort headers.
9478         * amd64-bsd-nat.c: Sort headers.
9479         * alpha-tdep.c: Sort headers.
9480         * alpha-obsd-tdep.c: Sort headers.
9481         * alpha-nbsd-tdep.c: Sort headers.
9482         * alpha-mdebug-tdep.c: Sort headers.
9483         * alpha-linux-tdep.c: Sort headers.
9484         * alpha-linux-nat.c: Sort headers.
9485         * alpha-bsd-tdep.c: Sort headers.
9486         * alpha-bsd-nat.c: Sort headers.
9487         * aix-thread.c: Sort headers.
9488         * agent.c: Sort headers.
9489         * addrmap.c: Sort headers.
9490         * ada-varobj.c: Sort headers.
9491         * ada-valprint.c: Sort headers.
9492         * ada-typeprint.c: Sort headers.
9493         * ada-tasks.c: Sort headers.
9494         * ada-lang.c: Sort headers.
9495         * aarch64-tdep.c: Sort headers.
9496         * aarch64-ravenscar-thread.c: Sort headers.
9497         * aarch64-newlib-tdep.c: Sort headers.
9498         * aarch64-linux-tdep.c: Sort headers.
9499         * aarch64-linux-nat.c: Sort headers.
9500         * aarch64-fbsd-tdep.c: Sort headers.
9501         * aarch64-fbsd-nat.c: Sort headers.
9502         * aarch32-linux-nat.c: Sort headers.
9503
9504 2019-04-04  Tom Tromey  <tom@tromey.com>
9505
9506         * varobj.c (varobj_create): Update.
9507         * rust-exp.y (struct rust_parser) <update_innermost_block,
9508         lookup_symbol>: New methods.
9509         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9510         Rename.
9511         (rust_parser::rust_lookup_type)
9512         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9513         * printcmd.c (display_command, do_one_display): Update.
9514         * parser-defs.h (struct parser_state) <parser_state>: Add
9515         "tracker" parameter.
9516         (block_tracker): New member.
9517         (class innermost_block_tracker) <innermost_block_tracker>: Add
9518         "types" parameter.
9519         <reset>: Remove method.
9520         (innermost_block): Don't declare.
9521         (null_post_parser): Update.
9522         * parse.c (innermost_block): Remove global.
9523         (write_dollar_variable): Update.
9524         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9525         Remove "tracker_types" parameter.
9526         (parse_expression): Add "tracker" parameter.
9527         (parse_expression_for_completion): Update.
9528         (null_post_parser): Add "tracker" parameter.
9529         * p-exp.y: Update rules.
9530         * m2-exp.y: Update rules.
9531         * language.h (struct language_defn) <la_post_parser>: Add
9532         "tracker" parameter.
9533         * go-exp.y: Update rules.
9534         * f-exp.y: Update rules.
9535         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9536         parameter.
9537         * d-exp.y: Update rules.
9538         * c-exp.y: Update rules.
9539         * breakpoint.c (set_breakpoint_condition): Create an
9540         innermost_block_tracker.
9541         (watch_command_1): Likewise.
9542         * ada-lang.c (resolve): Add "tracker" parameter.
9543         (resolve_subexp): Likewise.
9544         * ada-exp.y (write_var_from_sym): Update.
9545
9546 2019-04-04  Tom Tromey  <tom@tromey.com>
9547
9548         * type-stack.h: New file.
9549         * type-stack.c: New file.
9550         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9551         type-stack.h.
9552         (insert_into_type_stack, insert_type, push_type, push_type_int)
9553         (insert_type_address_space, pop_type, pop_type_int)
9554         (pop_typelist, pop_type_stack, append_type_stack)
9555         (push_type_stack, get_type_stack, push_typelist)
9556         (follow_type_instance_flags, follow_types): Don't declare.
9557         * parse.c (type_stack): Remove global.
9558         (parse_exp_in_context): Update.
9559         (insert_into_type_stack, insert_type, push_type, push_type_int)
9560         (insert_type_address_space, pop_type, pop_type_int)
9561         (pop_typelist, pop_type_stack, append_type_stack)
9562         (push_type_stack, get_type_stack, push_typelist)
9563         (follow_type_instance_flags, follow_types): Remove (moved to
9564         type-stack.c).
9565         * f-exp.y (type_stack): New global.
9566         Update rules.
9567         (push_kind_type, f_parse): Update.
9568         * d-exp.y (type_stack): New global.
9569         Update rules.
9570         (d_parse): Update.
9571         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9572         Update rules.
9573         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9574         (HFILES_NO_SRCDIR): Add type-stack.h.
9575
9576 2019-04-04  Tom Tromey  <tom@tromey.com>
9577
9578         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9579         (rust_parser::convert_ast_to_expression, rust_parse)
9580         (rust_lex_test_completion, rust_lex_tests): Update.
9581         * parser-defs.h (struct expr_completion_state): New.
9582         (struct parser_state) <parser_state>: Add completion parameter.
9583         <mark_struct_expression, mark_completion_tag>: New methods.
9584         <parse_completion, m_completion_state>: New members.
9585         (prefixify_expression, null_post_parser): Update.
9586         (mark_struct_expression, mark_completion_tag): Don't declare.
9587         * parse.c (parse_completion, expout_last_struct)
9588         (expout_tag_completion_type, expout_completion_name): Remove
9589         globals.
9590         (parser_state::mark_struct_expression)
9591         (parser_state::mark_completion_tag): Now methods.
9592         (prefixify_expression): Add last_struct parameter.
9593         (prefixify_subexp): Likewise.
9594         (parse_exp_1): Update.
9595         (parse_exp_in_context): Add cstate parameter.  Update.
9596         (parse_expression_for_completion): Create an
9597         expr_completion_state.
9598         (null_post_parser): Add "completion" parameter.
9599         * p-exp.y: Update rules.
9600         (yylex): Update.
9601         * language.h (struct language_defn) <la_post_parser>: Add
9602         "completing" parameter.
9603         * go-exp.y: Update rules.
9604         (lex_one_token): Update.
9605         * expression.h (parse_completion): Don't declare.
9606         * d-exp.y: Update rules.
9607         (lex_one_token): Update rules.
9608         * c-exp.y: Update rules.
9609         (lex_one_token): Update.
9610         * ada-lang.c (resolve): Add "parse_completion" parameter.
9611         (resolve_subexp): Likewise.
9612         (ada_resolve_function): Likewise.
9613
9614 2019-04-04  Tom Tromey  <tom@tromey.com>
9615
9616         * parser-defs.h (struct parser_state) <start_arglist,
9617         end_arglist>: New methods.
9618         <arglist_len, m_funcall_chain>: New members.
9619         (arglist_len, start_arglist, end_arglist): Don't declare.
9620         * parse.c (arglist_len, funcall_chain): Remove global.
9621         (start_arglist, end_arglist): Remove functions.
9622         (parse_exp_in_context): Update.
9623         * p-exp.y: Update rules.
9624         * m2-exp.y: Update rules.
9625         * go-exp.y: Update rules.
9626         * f-exp.y: Update rules.
9627         * d-exp.y: Update rules.
9628         * c-exp.y: Update rules.
9629
9630 2019-04-04  Tom Tromey  <tom@tromey.com>
9631
9632         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9633         lex_operator, push_back>: New methods.
9634         Update all rules.
9635         (rust_parser::lex_hex, lex_escape): Rename and update.
9636         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9637         (rust_parser::lex_operator): Rename and update.
9638         (rust_parser::lex_number, rustyylex, rustyyerror)
9639         (rust_lex_test_init, rust_lex_test_sequence)
9640         (rust_lex_test_push_back, rust_lex_tests): Update.
9641         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9642         parameter.
9643         <lexptr, prev_lexptr>: New members.
9644         (lexptr, prev_lexptr): Don't declare.
9645         * parse.c (lexptr, prev_lexptr): Remove globals.
9646         (parse_exp_in_context): Update.
9647         * p-exp.y (yylex, yyerror): Update.
9648         * m2-exp.y (parse_number, yylex, yyerror): Update.
9649         * go-exp.y (lex_one_token, yyerror): Update.
9650         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9651         * d-exp.y (lex_one_token, yyerror): Update.
9652         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9653         (lex_one_token, yyerror): Update.
9654         * ada-lex.l (YY_INPUT): Update.
9655         (rewind_to_char): Update.
9656         * ada-exp.y (yyerror): Update.
9657
9658 2019-04-04  Tom Tromey  <tom@tromey.com>
9659
9660         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9661         * parser-defs.h (struct parser_state) <parser_state>: Add new
9662         parameter.
9663         <comma_terminates>: New member.
9664         (comma_terminates): Don't declare global.
9665         * parse.c (comma_terminates): Remove global.
9666         (parse_exp_in_context): Update.
9667         * p-exp.y (yylex): Update.
9668         * m2-exp.y (yylex): Update.
9669         * go-exp.y (lex_one_token): Update.
9670         * f-exp.y (yylex): Update.
9671         * d-exp.y (lex_one_token): Update.
9672         * c-exp.y (lex_one_token): Update.
9673         * ada-lex.l: Update.
9674
9675 2019-04-04  Tom Tromey  <tom@tromey.com>
9676
9677         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9678         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9679         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9680         * parser-defs.h (paren_depth): Don't declare.
9681         * parse.c (paren_depth): Remove global.
9682         (parse_exp_in_context): Update.
9683         * p-exp.y (paren_depth): New global.
9684         (pascal_parse): Initialize it.
9685         * m2-exp.y (paren_depth): New global.
9686         (m2_parse): Initialize it.
9687         * go-exp.y (paren_depth): New global.
9688         (go_parse): Initialize it.
9689         * f-exp.y (paren_depth): New global.
9690         (f_parse): Initialize it.
9691         * d-exp.y (paren_depth): New global.
9692         (d_parse): Initialize it.
9693         * c-exp.y (paren_depth): New global.
9694         (c_parse): Initialize it.
9695         * ada-lex.l (paren_depth): New global.
9696         (lexer_init): Initialize it.
9697
9698 2019-04-04  Tom Tromey  <tom@tromey.com>
9699
9700         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9701         (rust_parser::convert_ast_to_type)
9702         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9703         * parser-defs.h (struct parser_state) <parser_state>: Add
9704         parameters.  Initialize new members.
9705         <expression_context_block, expression_context_pc>: New members.
9706         * parse.c (expression_context_block, expression_context_pc):
9707         Remove globals.
9708         (parse_exp_in_context): Update.
9709         * p-exp.y: Update all rules.
9710         (yylex): Update.
9711         * m2-exp.y: Update all rules.
9712         (yylex): Update.
9713         * go-exp.y (yylex): Update.
9714         * f-exp.y (yylex): Update.
9715         * d-exp.y: Update all rules.
9716         (yylex): Update.
9717         * c-exp.y: Update all rules.
9718         (lex_one_token, classify_name, yylex, c_parse): Update.
9719         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9720
9721 2019-04-04  Tom Tromey  <tom@tromey.com>
9722
9723         * gdbarch.h, gdbarch.c: Rebuild.
9724         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9725         * stap-probe.h:
9726         (struct stap_parse_info): Replace "parser_state" with
9727         "expr_builder".
9728         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9729         (parser_state): New class.
9730         * parse.c (expr_builder): Rename.
9731         (expr_builder::release): Rename.
9732         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9733         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9734         (write_exp_elt_longcst, write_exp_elt_floatcst)
9735         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9736         (write_exp_string_vector, write_exp_bitstring)
9737         (write_exp_msymbol, mark_struct_expression)
9738         (write_dollar_variable)
9739         (insert_type_address_space, increase_expout_size): Replace
9740         "parser_state" with "expr_builder".
9741         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9742         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9743         "parser_state" with "expr_builder".
9744
9745 2019-04-04  Tom Tromey  <tom@tromey.com>
9746
9747         * rust-exp.y: Replace "parse_language" with method call.
9748         * p-exp.y:
9749         (yylex): Replace "parse_language" with method call.
9750         * m2-exp.y:
9751         (yylex): Replace "parse_language" with method call.
9752         * go-exp.y (classify_name): Replace "parse_language" with method
9753         call.
9754         * f-exp.y (yylex): Replace "parse_language" with method call.
9755         * d-exp.y (lex_one_token): Replace "parse_language" with method
9756         call.
9757         * c-exp.y:
9758         (lex_one_token, classify_name, yylex): Replace "parse_language"
9759         with method call.
9760         * ada-exp.y (find_primitive_type, type_char)
9761         (type_system_address): Replace "parse_language" with method call.
9762
9763 2019-04-04  Tom Tromey  <tom@tromey.com>
9764
9765         * rust-exp.y: Replace "parse_gdbarch" with method call.
9766         * parse.c (write_dollar_variable, insert_type_address_space):
9767         Replace "parse_gdbarch" with method call.
9768         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9769         call.
9770         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9771         call.
9772         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9773         "parse_gdbarch" with method call.
9774         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9775         with method call.
9776         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9777         "parse_gdbarch" with method call.
9778         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9779         "parse_gdbarch" with method call.
9780         * c-exp.y (parse_type, parse_number, classify_name): Replace
9781         "parse_gdbarch" with method call.
9782         * ada-lex.l: Replace "parse_gdbarch" with method call.
9783         * ada-exp.y (parse_type, find_primitive_type, type_char)
9784         (type_system_address): Replace "parse_gdbarch" with method call.
9785
9786 2019-04-04  Tom Tromey  <tom@tromey.com>
9787
9788         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9789         * stap-probe.c (stap_parse_argument): Update.
9790         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9791         initial_size parameter.
9792         * rust-exp.y (rust_lex_tests): Update.
9793         * parse.c (parser_state): Update.
9794         (parse_exp_in_context): Update.
9795         * parser-defs.h (struct parser_state) <parser_state>: Remove
9796         "initial_size" parameter.
9797
9798 2019-04-04  Tom Tromey  <tom@tromey.com>
9799
9800         * parser-defs.h (increase_expout_size): Don't declare.
9801         * parse.c (increase_expout_size): Now static.
9802
9803 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9804
9805         * gnu-nat.c (gnu_nat_target::wait): Fix
9806         target_waitstatus_to_string call.
9807
9808 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9809
9810         * eval.c (evaluate_subexp_standard): Handle internal functions
9811         during Fortran function call handling.
9812
9813 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9814
9815         * NEWS: Mention new internal functions.
9816         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9817         (read_base_type): Use dwarf2_init_complex_target_type.
9818         * value.c (creal_internal_fn): New function.
9819         (cimag_internal_fn): New function.
9820         (_initialize_values): Register new internal functions.
9821
9822 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9823
9824         * infrun.c (stop_all_threads): If debug_infrun, always
9825         trace the wait status after wait_one, using
9826         target_waitstatus_to_string and target_pid_to_str.
9827         (handle_inferior_event): Replace various trace of
9828         wait status kind by a single trace.
9829         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9830         wait status kind image by target_waitstatus_to_string.
9831         * target/waitstatus.c (target_waitstatus_to_string): Fix
9832         obsolete comment.
9833
9834 2019-04-01  Tom Tromey  <tromey@adacore.com>
9835
9836         PR symtab/23331:
9837         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9838
9839 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9840             Pedro Alves  <palves@redhat.com>
9841
9842         * top.c (quit_force): Call 'finalize_values'.
9843         * value.c (finalize_values): New function.
9844         * value.h (finalize_values): Declare.
9845
9846 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9847
9848         * NEWS: Announce $_gdb_major and $_gdb_minor.
9849
9850         * top.c (init_gdb_version_vars): New function.
9851         (gdb_init): Call init_gdb_version_vars.
9852
9853 2019-03-29  Tom Tromey  <tromey@adacore.com>
9854
9855         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9856         help text.  Remove dead code.
9857
9858 2019-03-29  Keith Seitz  <keiths@redhat.com>
9859
9860         From Siddhesh Poyarekar:
9861         * f-lang.h (f77_get_upperbound): Return LONGEST.
9862         (f77_get_lowerbound): Likewise.
9863         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9864         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9865         print them.
9866         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9867         plongest to format print it.
9868         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9869         (f77_get_upperbound): Likewise.
9870         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9871         LOWER_BOUND to LONGEST.
9872         (f77_create_arrayprint_offset_tbl): Likewise.
9873
9874 2019-03-29  Keith Seitz  <keiths@redhat.com>
9875
9876         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9877         %s/pulongest for TYPE_LENGTH instead of %d in format
9878         strings.
9879         * ada-typerint.c (ada_print_type): Likewise.
9880         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9881         * compile/compile-c-support.c (generate_register_struct): Likewise.
9882         * gdbtypes.c (recursive_dump_type): Likewise.
9883         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9884         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9885         instead of %d in format strings.
9886         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9887         to std::min to ULONGEST.
9888         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9889         instead of %d in format strings.
9890         * tracepoint.c (info_scope_command): Likewise.
9891         * typeprint.c (print_offset_data::update)
9892         (print_offset_data::finish): Likewise.
9893         * xtensa-tdep.c (xtensa_store_return_value)
9894         (xtensa_push_dummy_call): Likewise.
9895
9896 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9897
9898         * windows-nat.c (display_selector): Fixed format specifications
9899         for 64-bit Cygwin.
9900
9901 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902
9903         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9904
9905 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9906
9907         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9908         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9909         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9910         (nios2_linux_init_abi): Install it.
9911
9912 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9913
9914         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9915
9916 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9917
9918         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9919
9920 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9921             Tom Tromey  <tromey@adacore.com>
9922
9923         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9924
9925 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9926
9927         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9928         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9929         method to compute the bounds of range types. Also print "[evaluated]"
9930         if the bounds' values come from a dynamic evaluation.
9931
9932 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9935         whitespace when pretty printing is on.
9936
9937 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9938
9939         * ppc-linux-nat.c: Add include.
9940
9941 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9942
9943         * NEWS: Mention AArch64 Pointer Authentication.
9944
9945 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9946
9947         * arm-linux-nat.c: Add include.
9948
9949 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9950
9951         * source-cache.c (source_cache::get_source_lines): Re-read
9952         fullname after calling open_source_file.
9953
9954 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9955
9956         * NEWS: Mention TLS support for FreeBSD.
9957
9958 2019-03-25  Tom Tromey  <tromey@adacore.com>
9959
9960         * minsyms.c (BUNCH_SIZE): Update comment.
9961         (~minimal_symbol_reader): Remove old comment.
9962         (compact_minimal_symbols): Update comment.
9963         (minimal_symbol_reader::install): Remove old comment.  Update
9964         other comments.
9965
9966 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9967
9968         * s390-linux-nat.c: Add include.
9969
9970 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9971
9972         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9973         Call linux_get_hwcap.
9974         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9975         Likewise.
9976         (aarch64_linux_get_hwcap): Remove function.
9977         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9978         declaration.
9979         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9980         linux_get_hwcap.
9981         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9982         * linux-tdep.c (linux_get_hwcap): Add function.
9983         (linux_get_hwcap2): Likewise.
9984         * linux-tdep.h (linux_get_hwcap): Add declaration.
9985         (linux_get_hwcap2): Likewise.
9986         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9987         (ppc_linux_get_hwcap2): Likewise.
9988         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9989         linux_get_hwcap.
9990         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9991         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9992         (ppc_linux_nat_target::read_description): Likewise.
9993         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9994         * s390-linux-nat.c: Likewise.
9995         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9996
9997 2019-03-24  Tom Tromey  <tom@tromey.com>
9998
9999         * ada-lang.c (standard_lookup): Simplify initialization.
10000         (ada_lookup_symbol_nonlocal): Simplify return.
10001         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10002         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10003         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10004         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10005         initialization.
10006         * solib.c (solib_global_lookup): Simplify.
10007         * symtab.c (null_block_symbol): Remove.
10008         (symbol_cache_lookup): Simplify returns.
10009         (lookup_language_this): Simplify returns.
10010         (lookup_symbol_aux): Simplify return.
10011         (lookup_local_symbol): Simplify returns.
10012         (lookup_global_symbol_from_objfile): Simplify return.
10013         (lookup_symbol_in_objfile_symtabs)
10014         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10015         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10016         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10017         * cp-namespace.c (cp_lookup_bare_symbol)
10018         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10019         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10020         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10021         (cp_lookup_symbol_via_imports): Simplify initialization.
10022         (find_symbol_in_baseclass): Likewise.
10023         * symtab.h (null_block_symbol): Remove.
10024         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10025         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10026         (d_lookup_symbol_module): Likewise.
10027         (find_symbol_in_baseclass): Simplify initialization.
10028
10029 2019-03-24  Tom Tromey  <tom@tromey.com>
10030
10031         * expression.h: Don't include symtab.h.
10032         (struct block): Forward declare.
10033
10034 2019-03-24  Tom Tromey  <tom@tromey.com>
10035
10036         * c-exp.y (typebase): Remove casts.
10037         * gdbtypes.c (lookup_unsigned_typename, )
10038         (lookup_signed_typename): Remove cast.
10039         * eval.c (parse_to_comma_and_eval): Remove cast.
10040         * parse.c (write_dollar_variable): Remove cast.
10041         * block.h (struct block) <superblock>: Now const.
10042         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10043         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10044         (map_block): Make "block" const.
10045         * symfile.h (struct quick_symbol_functions)
10046         <map_matching_symbols>: Constify block argument to "callback".
10047         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10048         const.
10049         (find_pc_sect_compunit_symtab): Make "b" const.
10050         (find_symbol_at_address): Likewise.
10051         (search_symbols): Likewise.
10052         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10053         (dw2_debug_names_lookup_symbol): Likewise.
10054         (dw2_map_matching_symbols): Update.
10055         * p-valprint.c (pascal_val_print): Remove "block".
10056         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10057         (aux_add_nonlocal_symbols): Make "block" const.
10058         (resolve_subexp): Remove cast.
10059         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10060         const.
10061         (iterate_over_file_blocks): Likewise.
10062         * f-exp.y (%union) <bval>: Remove.
10063         * coffread.c (patch_opaque_types): Make "b" const.
10064         * spu-tdep.c (spu_catch_start): Make "block" const.
10065         * c-valprint.c (print_unpacked_pointer): Remove "block".
10066         * symmisc.c (dump_symtab_1): Make "b" const.
10067         (block_depth): Make "block" const.
10068         * d-exp.y (%union) <bval>: Remove.
10069         * cp-support.h (cp_lookup_rtti_type): Update.
10070         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10071         * psymtab.c (psym_lookup_symbol): Make "block" const.
10072         (maintenance_check_psymtabs): Make "b" const.
10073         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10074         (enumerate_locals, enumerate_args): Update.
10075         * python/py-symtab.c (stpy_global_block): Make "block" const.
10076         (stpy_static_block): Likewise.
10077         * inline-frame.c (block_starting_point_at): Make "new_block"
10078         const.
10079         * block.c (find_block_in_blockvector): Make return type const.
10080         (blockvector_for_pc_sect): Make "b" const.
10081         (find_block_in_blockvector): Make "b" const.
10082
10083 2019-03-23  Tom Tromey  <tom@tromey.com>
10084
10085         * varobj.c (varobj_create): Update.
10086         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10087         * printcmd.c (display_command, do_one_display): Don't reset
10088         innermost_block.
10089         * parser-defs.h (enum innermost_block_tracker_type): Move to
10090         expression.h.
10091         (innermost_block): Update comment.
10092         * parse.c (parse_exp_1): Add tracker_types parameter.
10093         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10094         tracker_types parameter.  Reset innermost_block.
10095         (parse_exp_in_context): Remove.
10096         (parse_expression_for_completion): Update.
10097         * objfiles.c (~objfile): Don't reset expression_context_block or
10098         innermost_block.
10099         * expression.h (enum innermost_block_tracker_type): Move from
10100         parser-defs.h.
10101         (parse_exp_1): Add tracker_types parameter.
10102         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10103         reset innermost_block.
10104
10105 2019-03-23  Tom Tromey  <tom@tromey.com>
10106
10107         * objfiles.h: Include bcache.h.
10108
10109 2019-03-23  Tom Tromey  <tom@tromey.com>
10110
10111         * linespec.c (get_current_search_block): Use
10112         scoped_restore_current_language.
10113         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10114
10115 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10116             Jiong Wang  <jiong.wang@arm.com>
10117
10118         * aarch64-linux-tdep.c
10119         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10120         section.
10121         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10122
10123 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10124             Jiong Wang  <jiong.wang@arm.com>
10125
10126         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10127         instructions.
10128         (aarch64_analyze_prologue_test): Add PACIASP test.
10129         (aarch64_prologue_prev_register): Unmask PC value.
10130
10131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10132             Jiong Wang  <jiong.wang@arm.com>
10133
10134         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10135         (aarch64_dwarf2_prev_register): Unmask PC value.
10136         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10137         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10138         DW_CFA_AARCH64_negate_ra_state.
10139         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10140
10141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10142             Jiong Wang  <jiong.wang@arm.com>
10143
10144         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10145         registers.
10146         (aarch64_pseudo_register_name): Likewise.
10147         (aarch64_pseudo_register_type): Likewise.
10148         (aarch64_pseudo_register_reggroup_p): Likewise.
10149         (aarch64_gdbarch_init): Add pauth registers.
10150         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10151         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10152         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10153         (struct gdbarch_tdep): Add regnum for ra_state.
10154
10155 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10156             Jiong Wang  <jiong.wang@arm.com>
10157
10158         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10159
10160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10161             Jiong Wang  <jiong.wang@arm.com>
10162
10163         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10164         function.
10165         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10166         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10167         (aarch64_gdbarch_init): Add puth registers.
10168         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10169         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10170         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10171
10172 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10173             Jiong Wang  <jiong.wang@arm.com>
10174
10175         * aarch64-linux-nat.c
10176         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10177         * aarch64-linux-tdep.c
10178         (aarch64_linux_core_read_description): Likewise.
10179         (aarch64_linux_get_hwcap): New function.
10180         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10181         (aarch64_linux_get_hwcap): New declaration.
10182
10183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10184             Jiong Wang  <jiong.wang@arm.com>
10185
10186         * aarch64-linux-nat.c
10187         (aarch64_linux_nat_target::read_description): Add pauth param.
10188         * aarch64-linux-tdep.c
10189         (aarch64_linux_core_read_description): Likewise.
10190         * aarch64-tdep.c (struct target_desc): Add in pauth.
10191         (aarch64_read_description): Add pauth param.
10192         (aarch64_gdbarch_init): Likewise.
10193         * aarch64-tdep.h (aarch64_read_description): Likewise.
10194         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10195         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10196         * features/Makefile: Add new files.
10197         * features/aarch64-pauth.c: New file.
10198         * features/aarch64-pauth.xml: New file.
10199
10200 2019-03-20  Tom Tromey  <tromey@adacore.com>
10201
10202         * infrun.c (handle_inferior_event): Rename from
10203         handle_inferior_event_1.  Create a scoped_value_mark.
10204         (handle_inferior_event): Remove.
10205
10206 2019-03-19  Tom Tromey  <tromey@adacore.com>
10207
10208         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10209         * infrun.h (print_stop_event): Add "displays" parameter.
10210         * infrun.c (print_stop_event): Add "displays" parameter.
10211
10212 2019-03-19  Pedro Alves  <palves@redhat.com>
10213
10214         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10215         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10216         to -1.  Fix TABs vs spaces.
10217         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10218         * tui/tui-out.h (tui_ui_out) Add intro comments.
10219         <m_line, m_start_of_line>: In-class initialize, and add describing
10220         comment.
10221
10222 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10223
10224         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10225         variable names.
10226         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10227
10228 2019-03-18  Pedro Alves  <palves@redhat.com>
10229             Eli Zaretskii <eliz@gnu.org>
10230
10231         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10232         m_line and m_start_of_line.
10233
10234 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10235
10236         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10237         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10238         it returns a newline.  This fixes a regression in TU mode, whereby
10239         the next line is output on the same screen line as the user input.
10240
10241 2019-03-18  Tom Tromey  <tromey@adacore.com>
10242
10243         * minsyms.c (minimal_symbol_reader::install): Remove call to
10244         obstack_blank.
10245
10246 2019-03-18  Pedro Alves  <palves@redhat.com>
10247
10248         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10249         New globals.
10250         (apply_style): New, factored out from ...
10251         (apply_ansi_escape): ... this.  Handle reverse video mode.
10252         (tui_set_reverse_mode): New function.
10253         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10254         * tui/tui-winsource.c (tui_show_source_line): Use
10255         tui_set_reverse_mode instead of setting A_STANDOUT.
10256         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10257         New setter methods.
10258
10259 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10260
10261         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10262         Handle tabs.
10263
10264 2019-03-18  Tom Tromey  <tromey@adacore.com>
10265
10266         * ada-lang.c (empty_array): Add "high" parameter.
10267         (ada_evaluate_subexp): Update.
10268
10269 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10270
10271         * unittests/string_view-selftests.c: Define
10272         _initialize_string_view_selftests unconditionally.
10273
10274 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10275
10276         PR gdb/24350
10277         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10278
10279 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10280
10281         PR gdb/24351
10282         * windows-nat.c (display_selector): Fix format specifiers.
10283
10284 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10285
10286         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10287         tui_refill_source_window instead of tui_refresh_win, to update the
10288         current execution line.  This fixes redisplay of the current line
10289         when stepping through the code with "next" or "step".
10290
10291 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10292
10293         * source-cache.c (source_cache::get_source_lines): Call
10294         find_source_lines to initialize s->nlines.  This fixes vertical
10295         scrolling of TUI source window when the DOWN arrow is pressed.
10296
10297 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10300         linux-thread-db.c (_initialize_thread_db): Likewise.
10301
10302 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10303
10304         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10305         wclrtoeol in tui_show_source_line".  This reverts changes made in
10306         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10307
10308 2019-03-15  Tom Tromey  <tom@tromey.com>
10309
10310         * symtab.h (struct minimal_symbol): Derive from
10311         general_symbol_info.
10312         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10313         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10314         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10315         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10316         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10317         (MSYMBOL_SEARCH_NAME): Update.
10318         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10319         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10320         * minsyms.c (minimal_symbol_reader::record_full): Update.
10321
10322 2019-03-15  Tom Tromey  <tom@tromey.com>
10323
10324         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10325
10326 2019-03-15  Tom Tromey  <tom@tromey.com>
10327
10328         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10329         unique_xmalloc_ptr.
10330         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10331         Update.
10332         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10333         (build_minimal_symbol_hash_tables)
10334         (minimal_symbol_reader::install): Update.
10335
10336 2019-03-15  Tom Tromey  <tom@tromey.com>
10337
10338         * symtab.c (create_demangled_names_hash): Update.
10339         (symbol_set_names): Update.
10340         * objfiles.h (struct objfile_per_bfd_storage)
10341         <demangled_names_hash>: Now an htab_up.
10342         * objfiles.c (objfile_per_bfd_storage): Simplify.
10343
10344 2019-03-15  Tom Tromey  <tom@tromey.com>
10345
10346         * objfiles.h (struct objfile_per_bfd_storage): Declare
10347         destructor.
10348         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10349         New.
10350         (get_objfile_bfd_data): Use new.  Don't initialize
10351         language_of_main.
10352         (free_objfile_per_bfd_storage): Remove.
10353         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10354
10355 2019-03-15  Tom Tromey  <tom@tromey.com>
10356
10357         * symfile.c (reread_symbols): Update.
10358         * objfiles.c (objfile::objfile): Update.
10359         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10360         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10361         comment.
10362         (minimal_symbol_reader::install): Update.
10363         (terminate_minimal_symbol_table): Remove.
10364         * jit.c (jit_object_close_impl): Update.
10365
10366 2019-03-15  Tom Tromey  <tom@tromey.com>
10367
10368         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10369         initializations.
10370
10371 2019-03-15  Tom Tromey  <tom@tromey.com>
10372
10373         * objfiles.h (struct objfile_per_bfd_storage)
10374         <demangled_hash_languages>: Now a bitset.
10375         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10376         (lookup_minimal_symbol): Update.
10377
10378 2019-03-15  Tom Tromey  <tom@tromey.com>
10379
10380         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10381         Don't return the symbol.
10382         * coffread.c (record_minimal_symbol): Use record_full.
10383
10384 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10385
10386         The MS-Windows port of ncurses fails to switch to a color pair if
10387         one or both of the colors are the implicit default colors.  This
10388         change records the default colors when TUI is initialized, and
10389         then specifies them explicitly when a color pair uses the default
10390         colors.  This allows color styling in TUI mode on MS-Windows.
10391
10392         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10393         ncurses_norm_attr.
10394         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10395         colors in ncurses_norm_attr.
10396         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10397         "none", replace it with the default color recorded in
10398         ncurses_norm_attr.
10399
10400 2019-03-14  Tom Tromey  <tromey@adacore.com>
10401
10402         * source-cache.h (class source_cache) <get_source_lines>: Return
10403         std::string.
10404         * source-cache.c (source_cache::extract_lines): Handle case where
10405         first_pos==npos.  Return std::string.
10406         (source_cache::get_source_lines): Update.
10407
10408 2019-03-14  Tom Tromey  <tromey@adacore.com>
10409
10410         * NEWS: Add item for "style sources" commands.
10411         * source-cache.c (source_cache::get_source_lines): Check
10412         source_styling.
10413         * cli/cli-style.c (source_styling): New global.
10414         (_initialize_cli_style): Add "style sources" commands.
10415         (show_style_sources): New function.
10416         * cli/cli-style.h (source_styling): Declare.
10417
10418 2019-03-14  Pedro Alves  <palves@redhat.com>
10419             Tom Tromey  <tromey@adacore.com>
10420
10421         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10422         * tui/tui-winsource.c (tui_refill_source_window): New function,
10423         from...
10424         (tui_horizontal_source_scroll): ... here.  Move some logic.
10425         * cli/cli-style.c (set_style_enabled): Notify new observable.
10426         * tui/tui-hooks.c (tui_redisplay_source): New function.
10427         (tui_attach_detach_observers): Attach or detach
10428         tui_redisplay_source.
10429         * observable.h (source_styling_changed): New observable.
10430         * observable.c: Define source_styling_changed observable.
10431
10432 2019-03-13  Tom Tromey  <tromey@adacore.com>
10433
10434         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10435         (i386_gnu_nat_target::store_registers): Update.
10436         * target-debug.h (target_debug_print_std_string): New macro.
10437         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10438         * windows-tdep.c (display_one_tib): Update.
10439         * tui/tui-stack.c (tui_make_status_line): Update.
10440         * top.c (print_inferior_quit_action): Update.
10441         * thread.c (thr_try_catch_cmd): Update.
10442         (add_thread_with_info): Update.
10443         (thread_target_id_str): Update.
10444         (thr_try_catch_cmd): Update.
10445         (thread_command): Update.
10446         (thread_find_command): Update.
10447         * record-btrace.c (record_btrace_target::info_record)
10448         (record_btrace_resume_thread, record_btrace_target::resume)
10449         (record_btrace_cancel_resume, record_btrace_step_thread)
10450         (record_btrace_target::wait, record_btrace_target::wait)
10451         (record_btrace_target::wait, record_btrace_target::stop): Update.
10452         * progspace.c (print_program_space): Update.
10453         * process-stratum-target.c
10454         (process_stratum_target::thread_address_space): Update.
10455         * linux-fork.c (linux_fork_mourn_inferior)
10456         (detach_checkpoint_command, info_checkpoints_command)
10457         (linux_fork_context): Update.
10458         (linux_fork_detach): Update.
10459         (class scoped_switch_fork_info): Update.
10460         (delete_checkpoint_command): Update.
10461         * infrun.c (follow_fork_inferior): Update.
10462         (follow_fork_inferior): Update.
10463         (proceed_after_vfork_done): Update.
10464         (handle_vfork_child_exec_or_exit): Update.
10465         (follow_exec): Update.
10466         (displaced_step_prepare_throw): Update.
10467         (displaced_step_restore): Update.
10468         (start_step_over): Update.
10469         (resume_1): Update.
10470         (clear_proceed_status_thread): Update.
10471         (proceed): Update.
10472         (print_target_wait_results): Update.
10473         (do_target_wait): Update.
10474         (context_switch): Update.
10475         (stop_all_threads): Update.
10476         (restart_threads): Update.
10477         (finish_step_over): Update.
10478         (handle_signal_stop): Update.
10479         (switch_back_to_stepped_thread): Update.
10480         (keep_going_pass_signal): Update.
10481         (print_exited_reason): Update.
10482         (normal_stop): Update.
10483         * inferior.c (inferior_pid_to_str): Change return type.
10484         (print_selected_inferior): Update.
10485         (add_inferior): Update.
10486         (detach_inferior): Update.
10487         * dummy-frame.c (fprint_dummy_frames): Update.
10488         * dcache.c (dcache_info_1): Update.
10489         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10490         (btrace_fetch, btrace_clear): Update.
10491         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10492         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10493         type.
10494         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10495         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10496         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10497         * gdbarch.c, gdbarch.h: Rebuild.
10498         * gdbarch.sh (core_pid_to_str): Change return type.
10499         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10500         return type.
10501         (windows_nat_target::pid_to_str): Change return type.
10502         (windows_delete_thread): Update.
10503         (windows_nat_target::attach): Update.
10504         (windows_nat_target::files_info): Update.
10505         * target-delegates.c: Rebuild.
10506         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10507         return type.
10508         (sol_thread_target::pid_to_str): Change return type.
10509         * remote.c (class remote_target) <pid_to_str>: Change return
10510         type.
10511         (remote_target::pid_to_str): Change return type.
10512         (extended_remote_target::attach, remote_target::remote_stop_ns)
10513         (remote_target::remote_notif_remove_queued_reply)
10514         (remote_target::push_stop_reply, remote_target::disable_btrace):
10515         Update.
10516         (extended_remote_target::attach): Update.
10517         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10518         type.
10519         (gdbsim_target::pid_to_str): Change return type.
10520         * ravenscar-thread.c (struct ravenscar_thread_target)
10521         <pid_to_str>: Change return type.
10522         (ravenscar_thread_target::pid_to_str): Change return type.
10523         * procfs.c (class procfs_target) <pid_to_str>: Change return
10524         type.
10525         (procfs_target::pid_to_str): Change return type.
10526         (procfs_target::attach): Update.
10527         (procfs_target::detach): Update.
10528         (procfs_target::fetch_registers): Update.
10529         (procfs_target::store_registers): Update.
10530         (procfs_target::wait): Update.
10531         (procfs_target::files_info): Update.
10532         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10533         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10534         return type.
10535         (nto_procfs_target::pid_to_str): Change return type.
10536         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10537         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10538         return type.
10539         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10540         (exit_lwp): Update.
10541         (attach_proc_task_lwp_callback, get_detach_signal)
10542         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10543         (linux_nat_target::resume, wait_lwp, stop_callback)
10544         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10545         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10546         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10547         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10548         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10549         type.
10550         (inf_ptrace_target::attach): Update.
10551         (inf_ptrace_target::files_info): Update.
10552         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10553         type.
10554         (go32_nat_target::pid_to_str): Change return type.
10555         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10556         (gnu_nat_target::wait): Update.
10557         (gnu_nat_target::wait): Update.
10558         (gnu_nat_target::resume): Update.
10559         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10560         (fbsd_nat_target::wait): Update.
10561         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10562         type.
10563         (darwin_nat_target::attach): Update.
10564         * corelow.c (class core_target) <pid_to_str>: Change return type.
10565         (core_target::pid_to_str): Change return type.
10566         * target.c (normal_pid_to_str): Change return type.
10567         (default_pid_to_str): Likewise.
10568         (target_pid_to_str): Change return type.
10569         (target_translate_tls_address): Update.
10570         (target_announce_detach): Update.
10571         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10572         return type.
10573         (bsd_uthread_target::pid_to_str): Change return type.
10574         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10575         type.
10576         (bsd_kvm_target::pid_to_str): Change return type.
10577         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10578         return type.
10579         (aix_thread_target::pid_to_str): Change return type.
10580         * target.h (struct target_ops) <pid_to_str>: Change return type.
10581         (target_pid_to_str, normal_pid_to_str): Likewise.
10582         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10583         type.
10584         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10585         type.
10586         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10587         return type.
10588         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10589         type.
10590         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10591         type.
10592         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10593         return type.
10594
10595 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10596
10597         * NEWS: Mention that the new default MI version is 3.  Mention
10598         changes to the output of commands and events that deal with
10599         multi-location breakpoints.
10600         * breakpoint.c: Include "mi/mi-out.h".
10601         (print_one_breakpoint): Change output syntax if using MI version
10602         >= 3.
10603         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10604         New.
10605         (mi_multi_location_breakpoint_output_fixed): New.
10606         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10607         (mi_cmd_fix_multi_location_breakpoint_output): New.
10608         (mi_multi_location_breakpoint_output_fixed): New.
10609         * mi/mi-cmds.c (mi_cmds): Register command
10610         -fix-multi-location-breakpoint-output.
10611         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10612         interpreter "mi".
10613
10614 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10615
10616         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10617         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10618         instantiate mi_ui_out based on interpreter name.
10619         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10620         * mi/mi-main.c (mi_load_progress): Likewise.
10621
10622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10623
10624         * NEWS: Combine separate "New targets" sections for 8.3.
10625
10626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10627
10628         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10629         (ppcfbsd_init_abi): Install gdbarch
10630         "fetch_tls_load_module_address" and "get_thread_local_address"
10631         methods.
10632
10633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10634
10635         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10636         (riscv_fbsd_init_abi): Install gdbarch
10637         "fetch_tls_load_module_address" and "get_thread_local_address"
10638         methods.
10639
10640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10641
10642         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10643         (i386fbsd_init_abi): Install gdbarch
10644         "fetch_tls_load_module_address" and "get_thread_local_address"
10645         methods.
10646
10647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10648
10649         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10650         (amd64fbsd_init_abi): Install gdbarch
10651         "fetch_tls_load_module_address" and "get_thread_local_address"
10652         methods.
10653
10654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10655
10656         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10657         (struct fbsd_pspace_data): New type.
10658         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10659         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10660         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10661         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10662         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10663
10664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10665
10666         * gdbtypes.c (lookup_struct_elt): New function.
10667         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10668         * gdbtypes.h (struct struct_elt): New type.
10669         (lookup_struct_elt): New prototype.
10670
10671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10672
10673         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10674         remove disabled code block.
10675
10676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10677
10678         * gdbarch.sh (get_thread_local_address): New method.
10679         * gdbarch.h, gdbarch.c: Regenerate.
10680         * target.c (target_translate_tls_address): Use
10681         gdbarch_get_thread_local_address if present instead of
10682         target::get_thread_local_address.
10683
10684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10685
10686         * target.h (target::get_thread_local_address): Update comment.
10687
10688 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10689
10690         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10691         objfile->separate_debug_objfile_backlink if not NULL.
10692
10693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10694
10695         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10696         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10697         (amd64bsd_store_inferior_registers): Likewise.
10698         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10699         Enable segment base registers.
10700         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10701         PT_GETFSBASE and PT_GETGSBASE.
10702         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10703         PT_SETGSBASE.
10704         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10705         segment base registers.
10706         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10707
10708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10709
10710         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10711         Update calls to i386_target_description to add 'segments'
10712         parameter.
10713         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10714         add segment base registers.
10715         * arch/i386.c (i386_create_target_description): Add 'segments'
10716         parameter to enable segment base registers.
10717         * arch/i386.h (i386_create_target_description): Likewise.
10718         * features/i386/32bit-segments.xml: New file.
10719         * features/i386/32bit-segments.c: Generate.
10720         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10721         call to i386_target_description to add 'segments' parameter.
10722         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10723         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10724         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10725         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10726         if feature is present.
10727         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10728         Add 'segments' parameter to call to i386_target_description.
10729         (i386_target_description): Add 'segments' parameter to enable
10730         segment base registers.
10731         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10732         to call to i386_target_description.
10733         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10734         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10735         Define I386_NUM_REGS.
10736         (i386_target_description): Add 'segments' parameter to enable
10737         segment base registers.
10738
10739 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10740
10741         PR/24325
10742         * source-cache.c: #undef open and close, to avoid unresolved
10743         externals during linking.
10744
10745 2019-03-12  Tom Tromey  <tromey@adacore.com>
10746
10747         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10748         const.  Add initializers.
10749         (_initialize_remote): Don't initialize ptid globals.
10750
10751 2019-03-12  Pedro Alves  <palves@redhat.com>
10752
10753         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10754
10755 2019-03-12  Pedro Alves  <palves@redhat.com>
10756
10757         * cp-name-parser.y (main): Remove unused 'len' variable.
10758
10759 2019-03-12  Tom Tromey  <tromey@adacore.com>
10760
10761         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10762         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10763
10764 2019-03-12  Tom Tromey  <tromey@adacore.com>
10765
10766         * linux-nat.c (iterate_over_lwps): Update.
10767         (stop_callback): Remove parameter.
10768         (stop_wait_callback, detach_callback, resume_set_callback)
10769         (select_singlestep_lwp_callback, set_ignore_sigint)
10770         (status_callback, resumed_callback, resume_clear_callback)
10771         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10772         data parameter.
10773         (linux_nat_target::detach, linux_nat_target::resume)
10774         (linux_stop_and_wait_all_lwps, select_event_lwp)
10775         (linux_nat_filter_event, linux_nat_wait_1)
10776         (linux_nat_target::kill, linux_nat_target::stop)
10777         (linux_nat_target::stop): Update.
10778         (linux_nat_resume_callback): Change type.
10779         (resume_stopped_resumed_lwps, count_events_callback)
10780         (select_event_lwp_callback): Likewise.
10781         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10782         * arm-linux-nat.c (struct update_registers_data): Remove.
10783         (update_registers_callback): Change type.
10784         (arm_linux_insert_hw_breakpoint1): Update.
10785         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10786         parameter.
10787         (x86_linux_dr_set_addr): Update.
10788         (x86_linux_dr_set_control): Update.
10789         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10790         (iterate_over_lwps): Use gdb::function_view.
10791         * nat/aarch64-linux-hw-point.c (struct
10792         aarch64_dr_update_callback_param): Remove.
10793         (debug_reg_change_callback): Change type.
10794         (aarch64_notify_debug_reg_change): Update.
10795         * s390-linux-nat.c (s390_refresh_per_info): Update.
10796
10797 2019-03-11  Tom Tromey  <tromey@adacore.com>
10798
10799         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10800         redundant assignment to "this_cu".
10801
10802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10803
10804         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10805
10806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10807
10808         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10809         from...
10810         (rank_one_type): ... this.
10811
10812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10813
10814         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10815         from...
10816         (rank_one_type): ... this.
10817
10818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10819
10820         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10821         from...
10822         (rank_one_type): ... this.
10823
10824 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10825
10826         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10827         from...
10828         (rank_one_type): ... this.
10829
10830 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10831
10832         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10833         from...
10834         (rank_one_type): ... this.
10835
10836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10837
10838         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10839         from...
10840         (rank_one_type): ... this.
10841
10842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10843
10844         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10845         from...
10846         (rank_one_type): ... this.
10847
10848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10849
10850         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10851         from...
10852         (rank_one_type): ... this.
10853
10854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10855
10856         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10857         from...
10858         (rank_one_type): ... this.
10859
10860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10861
10862         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10863         from...
10864         (rank_one_type): ... this.
10865
10866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10867
10868         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10869         from...
10870         (rank_one_type): ... this.
10871
10872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10873
10874         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10875         from...
10876         (rank_one_type): ... this.
10877
10878 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10879
10880         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10881         inferior-events' shows the example events.
10882
10883 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10884
10885         Support styling on native MS-Windows console
10886
10887         PR/24315
10888         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10889         on MS-Windows if $TERM is not defined.
10890
10891         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10892
10893         * posix-hdep.c (gdb_console_fputs):
10894         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10895         functions.
10896         * ui-file.h (gdb_console_fputs): Add prototype.
10897
10898         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10899         back to fputs only if the former returns zero.
10900
10901 2019-03-07  Tom Tromey  <tom@tromey.com>
10902
10903         * symmisc.c (print_symbol_bcache_statistics): Update.
10904         (print_objfile_statistics): Update.
10905         * symfile.c (allocate_symtab): Update.
10906         * stabsread.c: Don't include bcache.h.
10907         * psymtab.h (struct psymbol_bcache): Don't declare.
10908         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10909         (psymbol_bcache_init, psymbol_bcache_free)
10910         (psymbol_bcache_get_bcache): Don't declare.
10911         * psymtab.c (struct psymbol_bcache): Remove.
10912         (psymtab_storage::psymtab_storage): Update.
10913         (psymtab_storage::~psymtab_storage): Update.
10914         (psymbol_bcache_init, psymbol_bcache_free)
10915         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10916         (add_psymbol_to_bcache): Update.
10917         (allocate_psymtab): Update.
10918         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10919         macro_cache>: No longer pointers.
10920         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10921         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10922         * macrotab.c (macro_bcache): Update.
10923         * macroexp.c: Don't include bcache.h.
10924         * gdbtypes.c (check_types_worklist): Update.
10925         (types_deeply_equal): Remove TRY/CATCH.  Update.
10926         * elfread.c (elf_symtab_read): Update.
10927         * dwarf2read.c: Don't include bcache.h.
10928         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10929         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10930         (print_bcache_statistics, bcache_memory_used): Don't declare.
10931         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10932         methods.  Rename all data members.
10933         * bcache.c (struct bcache): Move to bcache.h.
10934         (bcache::expand_hash_table): Rename from expand_hash_table.
10935         (bcache): Remove.
10936         (bcache::insert): Rename from bcache_full.
10937         (bcache::compare): Rename from bcache_compare.
10938         (bcache_xmalloc): Remove.
10939         (bcache::~bcache): Rename from bcache_xfree.
10940         (bcache::print_statistics): Rename from print_bcache_statistics.
10941         (bcache::memory_used): Rename from bcache_memory_used.
10942
10943 2019-03-07  Pedro Alves  <palves@redhat.com>
10944
10945         * infrun.c (normal_stop): Also check for
10946         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10947
10948 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10949
10950         * f-lang.c (value_from_host_double): Moved to...
10951         * value.c (value_from_host_double): ...here.
10952         * value.h (value_from_host_double): Declare.
10953         * guile/scm-math.c (vlscm_convert_typed_number): Use
10954         value_from_host_double.
10955         (vlscm_convert_number): Likewise.
10956         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10957         * python/py-value.c (convert_value_from_python): Likewise.
10958
10959 2019-03-06  Tom Tromey  <tom@tromey.com>
10960
10961         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10962
10963 2019-03-06  Tom Tromey  <tom@tromey.com>
10964
10965         * utils.h (free_current_contents): Don't declare.
10966         * utils.c (free_current_contents): Remove.
10967
10968 2019-03-06  Tom Tromey  <tom@tromey.com>
10969
10970         * top.c (quit_force): Update.
10971         * main.c (captured_command_loop): Update.
10972         * common/new-op.c (operator new): Update.
10973         * common/common-exceptions.c (struct catcher)
10974         <save_cleanup_chain>: Remove member.
10975         (exceptions_state_mc_init): Update.
10976         (exception_try_scope_entry): Return nullptr.
10977         (exception_try_scope_exit, exception_rethrow)
10978         (throw_exception_sjlj, throw_exception_cxx): Update.
10979         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10980         (all_cleanups, do_cleanups, discard_cleanups)
10981         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10982         (restore_cleanups, restore_final_cleanups): Don't declare.
10983         (do_final_cleanups): Remove parameter.
10984         * common/cleanups.c (cleanup_chain, make_cleanup)
10985         (make_cleanup_dtor, all_cleanups, do_cleanups)
10986         (discard_my_cleanups, discard_cleanups)
10987         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10988         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10989         (null_cleanup): Remove.
10990         (do_final_cleanups): Remove parameter.
10991
10992 2019-03-06  Tom Tromey  <tom@tromey.com>
10993
10994         * remote.c (remote_target::remote_parse_stop_reply): Use
10995         unique_xmalloc_ptr.
10996
10997 2019-03-06  Tom Tromey  <tom@tromey.com>
10998
10999         * stabsread.c (struct stabs_field_info): Rename from field_info.
11000         <list, fnlist>: Add initializers.
11001         <obstack>: New member.
11002         (read_member_functions, read_struct_fields, read_baseclasses):
11003         Allocate on obstack.  Don't use cleanups.
11004         (read_one_struct_field, read_member_functions, read_struct_fields)
11005         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11006         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11007         (read_struct_type): Update.
11008
11009 2019-03-06  Tom Tromey  <tom@tromey.com>
11010
11011         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11012         * common/filestuff.h (make_cleanup_close): Don't declare.
11013         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11014         Remove.
11015
11016 2019-03-06  Tom Tromey  <tom@tromey.com>
11017
11018         * solib-aix.c: Use make_scope_exit.
11019
11020 2019-03-06  Tom Tromey  <tom@tromey.com>
11021
11022         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11023         Use make_scope_exit.
11024
11025 2019-03-06  Tom Tromey  <tom@tromey.com>
11026
11027         * solib-svr4.c (disable_probes_interface): Remove parameter.
11028         (svr4_handle_solib_event): Use make_scope_exit.
11029
11030 2019-03-06  Tom Tromey  <tom@tromey.com>
11031
11032         * remote.c (struct stop_reply_deleter): Remove.
11033         (stop_reply_up): Update.
11034         (struct stop_reply): Derive from notif_event.  Don't typedef.
11035         <regcache>: Now a std::vector.
11036         (stop_reply_xfree): Remove.
11037         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11038         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11039         (remote_target::discard_pending_stop_replies): Use delete.
11040         (remote_target::remote_parse_stop_reply): Update.
11041         (remote_target::process_stop_reply): Update.
11042         * remote-notif.h (struct notif_event): Add virtual destructor.
11043         Remove "dtr" member.
11044         (struct notif_client) <alloc_event>: Return a unique_ptr.
11045         (notif_event_xfree): Don't declare.
11046         (notif_event_up): New typedef.
11047         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11048         (notif_event_xfree, do_notif_event_xfree): Remove.
11049         (remote_notif_state_xfree): Update.
11050
11051 2019-03-06  Tom Tromey  <tom@tromey.com>
11052
11053         * infrun.c (displaced_step_clear_cleanup): Now a
11054         forward_scope_exit type.
11055         (displaced_step_prepare_throw): Update.
11056         (displaced_step_fixup): Update.
11057
11058 2019-03-06  Tom Tromey  <tom@tromey.com>
11059
11060         * inferior.h (class inferior): Update comment.
11061         * gdbthread.h (class thread_info): Update comment.
11062
11063 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11064             Tom Tromey  <tom@tromey.com>
11065
11066         * stabsread.h (struct stab_section_list): Remove.
11067         (coffstab_build_psymtabs): Update.
11068         * dbxread.c (symbuf_sections): Now a std::vector.
11069         (sect_idx): New global.
11070         (fill_symbuf): Update.
11071         (coffstab_build_psymtabs): Change type of stabsects parameter.
11072         Update.
11073         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11074         std::vector.
11075         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11076         (coff_locate_sections): Update.
11077         (coff_symfile_read): Remove cleanups.  Update.
11078         (init_stringtab): Add storage parameter.
11079         (free_stringtab, free_stringtab_cleanup): Remove.
11080         (init_lineno): Add storage parameter.
11081         (free_linetab, free_linetab_cleanup): Remove.
11082
11083 2019-03-06  Pedro Alves  <palves@redhat.com>
11084
11085         * linux-fork.c (fork_info::clobber_regs): Delete.
11086         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11087         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11088         comment.  Adjust.
11089         (scoped_switch_fork_info::scoped_switch_fork_info)
11090         (checkpoint_command, linux_fork_context): Adjust
11091         fork_save_infrun_state calls.
11092
11093 2019-03-06  Pedro Alves  <palves@redhat.com>
11094
11095         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11096         (inf_has_multiple_threads): Return 'bool' and rewrite using
11097         inferior_info::threads().
11098
11099 2019-03-06  Pedro Alves  <palves@redhat.com>
11100
11101         * linux-fork.c: Include <list>.
11102         (fork_list): Now a std::list instance.
11103         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11104         (forks_exist_p, find_last_fork): Adjust.
11105         (new_fork): Delete.
11106         (one_fork_p): New.
11107         (add_fork): Adjust.
11108         (free_fork): Delete, folded into fork_info::~fork_info().
11109         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11110         Adjust.
11111         (init_fork_list): Delete.
11112         (linux_fork_killall, linux_fork_mourn_inferior)
11113         (linux_fork_detach, info_checkpoints_command): Adjust.
11114         (_initialize_linux_fork): No longer call init_fork_list.
11115
11116 2019-03-06  Pedro Alves  <palves@redhat.com>
11117
11118         * linux-fork.c (new_fork): New, split out of ...
11119         (add_fork): ... this.  Return void.  Move "first fork" special
11120         case from here, to ...
11121         (checkpoint_command): ... here.
11122         * linux-linux.h (add_fork): Return void.
11123
11124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11125
11126         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11127
11128 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11129             Chris January  <chris.january@arm.com>
11130             David Lecomber  <david.lecomber@arm.com>
11131
11132         * f-exp.y: New token, UNOP_INTRINSIC.
11133         (exp): New pattern using UNOP_INTRINSIC token.
11134         (f77_keywords): Add 'abs' keyword.
11135         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11136         (value_from_host_double): New function.
11137         (evaluate_subexp_f): Support UNOP_ABS.
11138
11139 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11140
11141         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11142         types.
11143
11144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11145
11146         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11147         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11148         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11149
11150 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11151
11152         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11153
11154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11155             Chris January  <chris.january@arm.com>
11156
11157         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11158         * f-exp.y: Define 'KIND' token.
11159         (exp): New pattern for KIND expressions.
11160         (ptype): Handle types with a kind extension.
11161         (direct_abs_decl): Extend to spot kind extensions.
11162         (f77_keywords): Add 'kind' to the list.
11163         (push_kind_type): New function.
11164         (convert_to_kind_type): New function.
11165         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11166         * parse.c (operator_length_standard): Likewise.
11167         * parser-defs.h (enum type_pieces): Add tp_kind.
11168         * std-operator.def: Add UNOP_KIND.
11169
11170 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * f-exp.y (f_parse): Set yydebug.
11173
11174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11175
11176         * f-lang.c (evaluate_subexp_f): New function.
11177         (exp_descriptor_f): New global.
11178         (f_language_defn): Use exp_descriptor_f instead of
11179         exp_descriptor_standard.
11180
11181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11182
11183         * f-exp.y (struct token): Add comments.
11184         (dot_ops): Remove uppercase versions and the end marker.
11185         (f77_keywords): Likewise.
11186         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11187         entries in the dot_ops array are case insensitive, and use
11188         strncasecmp to compare strings.  Also some whitespace cleanup in
11189         this area.  Similar for the f77_keywords array, except entries in
11190         this list might be case sensitive.
11191
11192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11193
11194         * f-exp.y (struct f77_boolean_val): Add comments.
11195         (boolean_values): Remove uppercase versions, and end marker.
11196         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11197         and use strncasecmp to achieve case insensitivity.  Additionally,
11198         perform whitespace cleanup around this code.
11199
11200 2019-03-06  Tom Tromey  <tromey@adacore.com>
11201
11202         * remote-sim.c (gdbsim_target_open): Use result of
11203         gdb_argv::release.
11204
11205 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11206         Dirk Schubert  <dirk.schubert@arm.com>
11207         Chris January  <chris.january@arm.com>
11208
11209         * eval.c (evaluate_subexp_standard): Call Fortran argument
11210         wrapping logic.
11211         * f-lang.c (struct value): A value which can be passed into a
11212         Fortran function call.
11213         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11214         where appropriate.
11215         (struct type): Value ready for a Fortran function call.
11216         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11217         is needed.
11218         * f-lang.h (fortran_argument_convert): Declaration.
11219         (fortran_preserve_arg_pointer): Declaration.
11220         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11221
11222 2019-03-05  Tom Tromey  <tromey@adacore.com>
11223
11224         * python/py-prettyprint.c (print_string_repr): Remove #if.
11225         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11226
11227 2019-03-05  Tom Tromey  <tromey@adacore.com>
11228
11229         * target.c (the_dummy_target): Move later.  Change type to
11230         "dummy_target".
11231         (initialize_targets): Don't initialize the_dummy_target.
11232
11233 2019-03-05  Tom Tromey  <tromey@adacore.com>
11234
11235         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11236         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11237
11238 2019-03-05  Tom Tromey  <tromey@adacore.com>
11239
11240         * windows-nat.c (windows_nat_target::attach)
11241         (windows_nat_target::detach): Don't call gdb_flush.
11242         * valprint.c (generic_val_print, val_print, val_print_string):
11243         Don't call gdb_flush.
11244         * utils.c (defaulted_query): Don't call gdb_flush.
11245         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11246         * target.c (target_announce_detach): Don't call gdb_flush.
11247         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11248         * remote.c (extended_remote_target::attach): Don't call
11249         gdb_flush.
11250         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11251         * printcmd.c (do_examine): Don't call gdb_flush.
11252         (info_display_command): Don't call gdb_flush.
11253         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11254         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11255         * memattr.c (info_mem_command): Don't call gdb_flush.
11256         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11257         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11258         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11259         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11260         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11261         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11262         (gnu_nat_target::detach): Don't call gdb_flush.
11263         * f-valprint.c (f_val_print): Don't call gdb_flush.
11264         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11265         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11266         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11267         gdb_flush.
11268         * c-valprint.c (c_val_print): Don't call gdb_flush.
11269         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11270
11271 2019-03-05  Tom Tromey  <tromey@adacore.com>
11272
11273         * varobj.c (update_dynamic_varobj_children): Update.
11274         (install_default_visualizer): Use reset, not release.
11275         * value.c (set_internalvar): Update.
11276         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11277         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11278         ATTRIBUTE_UNUSED_RESULT.
11279
11280 2019-03-05  Tom Tromey  <tromey@adacore.com>
11281
11282         * remote.c (class scoped_remote_fd) <release>: Add
11283         ATTRIBUTE_UNUSED_RESULT.
11284
11285 2019-03-05  Tom Tromey  <tromey@adacore.com>
11286
11287         * macroexp.c (struct macro_buffer) <release>: Add
11288         ATTRIBUTE_UNUSED_RESULT.
11289
11290 2019-03-05  Tom Tromey  <tromey@adacore.com>
11291
11292         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11293         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11294         ATTRIBUTE_UNUSED_RESULT.
11295
11296 2019-03-05  Tom Tromey  <tromey@adacore.com>
11297
11298         * common/scoped_fd.h (class scoped_fd) <release>: Add
11299         ATTRIBUTE_UNUSED_RESULT.
11300
11301 2019-03-05  Tom Tromey  <tromey@adacore.com>
11302
11303         * parser-defs.h (struct parser_state) <release>: Add
11304         ATTRIBUTE_UNUSED_RESULT.
11305
11306 2019-03-05  Tom Tromey  <tromey@adacore.com>
11307
11308         * utils.h (class gdb_argv) <release>: Add
11309         ATTRIBUTE_UNUSED_RESULT.
11310         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11311
11312 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11313
11314         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11315         for-loop range, to avoid compiler warnings.
11316
11317         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11318         avoid compiler warnings about unused variables.
11319
11320         * NEWS: Mention end of support for native debugging on MS-Windows
11321         before XP.
11322
11323         PR gdb/24292
11324         * common/netstuff.c:
11325         * gdbserver/gdbreplay.c
11326         * gdbserver/remote-utils.c:
11327         * ser-tcp.c:
11328         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11329         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11330         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11331         'getaddrinfo' and 'freeaddrinfo' were not available before
11332         Windows XP, and mingw.org's MinGW headers by default define
11333         _WIN32_WINNT to 0x500.
11334
11335 2019-03-01  Gary Benson <gbenson@redhat.com>
11336
11337         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11338
11339 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11340             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11341
11342         PR gdb/8527
11343         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11344         set_sigint_trap, clear_sigint_trap.
11345
11346 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11347
11348         * target.c (target_detach): Clear the regcache and the
11349         frame cache.
11350
11351 2019-02-27  Pedro Alves  <palves@redhat.com>
11352
11353         * utils.c (set_screen_size): When we cap the height/width sizes,
11354         tweak the corresponding command variable to show "unlimited":
11355
11356 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11357             Pedro Alves  <palves@redhat.com>
11358
11359         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11360         before calling rl_set_screen_size.
11361
11362 2019-02-27  Tom Tromey  <tromey@adacore.com>
11363
11364         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11365         define.
11366         * python/py-value.c: Remove Python 2.4 workaround.
11367         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11368         workaround.
11369         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11370         Python 2.4 workaround.
11371         * python/python-internal.h: Remove Python 2.4 comment.
11372         (Py_ssize_t): Don't define.
11373         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11374         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11375         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11376         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11377         * python/python.c (do_start_initialization): Remove Python 2.4
11378         workaround.
11379         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11380         (print_children): Remove Python 2.4 workaround.
11381         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11382         workaround.
11383         (CHARBUFFERPROC_NAME): Remove.
11384         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11385         Python 2.4 workaround.
11386
11387 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11388
11389         * NEWS: Note minimum Python version.
11390
11391 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11392
11393         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11394         code from these functions.  Remove corresponding ifdefs.  Use
11395         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11396         Remove gotos and target of gotos.
11397         (infpy_search_memory): Likewise.
11398
11399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11400
11401         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11402         (hppa_gdbarch_init): Don't register deleted functions with
11403         gdbarch.
11404
11405 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11406
11407         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11408         (h8300_unwind_sp): Delete.
11409         (h8300_dummy_id): Delete.
11410         (h8300_gdbarch_init): Don't register deleted functions with
11411         gdbarch.
11412
11413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11416         (ft32_unwind_pc): Delete.
11417         (ft32_unwind_sp): Delete.
11418         (ft32_gdbarch_init): Don't register deleted functions with
11419         gdbarch.
11420
11421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11424         (frv_unwind_pc): Delete.
11425         (frv_unwind_sp): Delete.
11426         (frv_gdbarch_init): Don't register deleted functions with
11427         gdbarch.
11428
11429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11430
11431         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11432         (riscv_unwind_pc): Delete.
11433         (riscv_unwind_sp): Delete.
11434         (riscv_gdbarch_init): Don't register deleted functions with
11435         gdbarch.
11436
11437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11440         (csky_unwind_pc): Delete.
11441         (csky_unwind_sp): Delete.
11442         (csky_gdbarch_init): Don't register deleted functions with
11443         gdbarch.
11444
11445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11448         (cris_unwind_pc): Delete.
11449         (cris_unwind_sp): Delete.
11450         (cris_gdbarch_init): Don't register deleted functions with
11451         gdbarch.
11452
11453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11454
11455         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11456         (bfin_unwind_pc): Delete.
11457         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11458
11459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11460
11461         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11462         (arm_unwind_pc): Delete.
11463         (arm_unwind_sp): Delete.
11464         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11465
11466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11467
11468         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11469         (arc_unwind_pc): Delete.
11470         (arc_unwind_sp): Delete.
11471         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11472
11473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11476         (alpha_unwind_pc): Delete.
11477         (alpha_gdbarch_init): Don't register deleted functions with
11478         gdbarch.
11479
11480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11483         (aarch64_unwind_pc): Delete.
11484         (aarch64_unwind_sp): Delete.
11485         (aarch64_gdbarch_init): Don't register deleted functions with
11486         gdbarch.
11487
11488 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11489
11490         * gdbtypes.c (type_align): Don't consider static members when
11491         computing structure alignment.
11492
11493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11496         return 0 for other types.
11497         * arch-utils.c (default_type_align): Always return 0.
11498         * gdbarch.h: Regenerate.
11499         * gdbarch.sh (type_align): Extend comment.
11500         * gdbtypes.c (type_align): Add additional comments, always call
11501         gdbarch_type_align before applying the default rules.
11502         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11503         generic code will then apply a suitable default.
11504         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11505         types, return 0 for other types.
11506
11507 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11508
11509         * NEWS: Create a new section for the next release branch.
11510         Rename the section of the current branch, now that it has
11511         been cut.
11512
11513 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11514
11515         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11516         * version.in: Bump version to 8.3.50.DATE-git.
11517
11518 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11519
11520         * aix-thread.c (ptid_cmp): Remove unused variable.
11521         (get_signaled_thread): Likewise.
11522         (store_regs_user_thread): Likewise.
11523         (store_regs_kernel_thread): Likewise.
11524         (fetch_regs_kernel_thread): Remove shadowed variable.
11525
11526 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11527
11528         * features/riscv/32bit-cpu.xml: Add register numbers.
11529         * features/riscv/32bit-fpu.c: Regenerate.
11530         * features/riscv/32bit-fpu.xml: Add register numbers.
11531         * features/riscv/64bit-cpu.xml: Add register numbers.
11532         * features/riscv/64bit-fpu.c: Regenerate.
11533         * features/riscv/64bit-fpu.xml: Add register numbers.
11534
11535 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11536
11537         * NEWS: Mention two argument form of gdb.Value constructor.
11538         * python/py-value.c (convert_buffer_and_type_to_value): New
11539         function.
11540         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11541         Add support for handling an optional second argument.  Call
11542         convert_buffer_and_type_to_value as appropriate.
11543         * python/python-internal.h (Py_buffer_deleter): New struct.
11544         (Py_buffer_up): New typedef.
11545
11546 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11547
11548         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11549         instead of releasing ownership.
11550
11551 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11552
11553         * dwarf2read.c (open_and_init_dwp_file): Call
11554         elf_numsections instead of bfd_count_sections to initialize
11555         dwp_file->num_sections.
11556
11557 2019-02-25  Tom Tromey  <tromey@adacore.com>
11558
11559         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11560
11561 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11562
11563         * gcore.in: Add '--readnever' option when invoking GDB.
11564
11565 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11566
11567         * MAINTAINERS: Update my email address.
11568
11569 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11570
11571         * build-id.c (build_id_to_debug_bfd_1): New function.
11572         (build_id_to_debug_bfd): Look for separate debug file in
11573         sysroot.
11574
11575 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11576
11577         * gdbarch.sh: Update the copyright year range that is placed into
11578         generated files.
11579
11580 2019-02-22  Keith Seitz  <keiths@redhat.com>
11581
11582         PR symtab/23853
11583         * linespec.c (create_sals_line_offset): Search for the default
11584         symtab's filename instead of its fullname.
11585
11586 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11587
11588         * NEWS: Update style defaults.
11589
11590 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11591
11592         * main.c (captured_main_1): Disable styling in batch mode.
11593
11594 2019-02-20  Tom Tromey  <tom@tromey.com>
11595
11596         * symtab.c (symtab_symbol_info): Fix typos.
11597
11598 2019-02-20  Tom Tromey  <tromey@adacore.com>
11599
11600         * findcmd.c (_initialize_mem_search): Use upper case for
11601         metasyntactic variables.
11602
11603 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11604
11605         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11606         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11607
11608 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11609
11610         * top.h (source_file_name): Change to std::string.
11611         * top.c (source_file_name): Likewise.
11612         (command_line_input): Adjust.
11613         * cli/cli-script.c (script_from_file): Adjust.
11614
11615 2019-02-19  Tom Tromey  <tromey@adacore.com>
11616
11617         * ravenscar-thread.c
11618         (ravenscar_thread_target::update_thread_list): Don't call
11619         ada_build_task_list.
11620         * ada-lang.h (ada_build_task_list): Don't declare.
11621         * ada-tasks.c (struct ada_tasks_inferior_data)
11622         <task_list_valid_p>: Now bool.
11623         (read_known_tasks, ada_task_list_changed)
11624         (ada_tasks_invalidate_inferior_data): Update.
11625         (read_known_tasks_array): Return bool.
11626         (read_known_tasks_list): Likewise.
11627         (read_known_tasks): Return void.
11628         (ada_build_task_list): Now static.
11629
11630 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11631
11632         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11633         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11634
11635 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11636
11637         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11638         variant for ada_tasks_pspace_data_handle and
11639         ada_tasks_inferior_data_handle.
11640         (ada_tasks_pspace_data_cleanup): New function.
11641         (ada_tasks_inferior_data_cleanup): New function.
11642
11643 2019-02-17  Tom Tromey  <tom@tromey.com>
11644
11645         * macrotab.h (macro_source_fullname): Return a std::string.
11646         * macrotab.c (macro_include, check_for_redefinition)
11647         (macro_undef, macro_lookup_definition, foreach_macro)
11648         (foreach_macro_in_scope): Update.
11649         (macro_source_fullname): Return a std::string.
11650         * macrocmd.c (show_pp_source_pos): Update.
11651
11652 2019-02-17  Tom Tromey  <tom@tromey.com>
11653
11654         * macrocmd.c (show_pp_source_pos): Style the file names.
11655
11656 2019-02-17  Tom Tromey  <tom@tromey.com>
11657
11658         PR tui/24197:
11659         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11660
11661 2019-02-17  Tom Tromey  <tom@tromey.com>
11662
11663         * ada-lang.c (user_select_syms): Use filtered printing.
11664         * utils.c (wrap_style): New global.
11665         (desired_style): Remove.
11666         (emit_style_escape): Add stream parameter.
11667         (set_output_style, reset_terminal_style, prompt_for_continue):
11668         Update.
11669         (flush_wrap_buffer): Only flush gdb_stdout.
11670         (wrap_here): Set wrap_style.
11671         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11672         treat escape sequences as a character.  Change when wrap buffer is
11673         flushed.
11674         (fputs_styled): Do not set the output style when the default is
11675         requested.
11676         * ui-style.h (struct ui_file_style) <is_default>: New method.
11677         * source.c (print_source_lines_base): Emit escape sequences in one
11678         piece.
11679
11680 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11681
11682         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11683         integers and enumeration types.
11684
11685 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11686
11687         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11688         instead of lookup_symbol_in_language
11689         (do_exact_match): New function.
11690         (ada_get_symbol_name_matcher): Return do_exact_match when
11691         doing a verbatim match.
11692
11693 2019-02-15  Tom Tromey  <tromey@adacore.com>
11694
11695         * ravenscar-thread.c (ravenscar_thread_target::resume)
11696         (ravenscar_thread_target::wait): Special case wildcard requests.
11697
11698 2019-02-15  Tom Tromey  <tromey@adacore.com>
11699
11700         * ravenscar-thread.c (base_ptid): Remove.
11701         (struct ravenscar_thread_target) <close>: New method.
11702         <m_base_ptid>: New member.
11703         <update_inferior_ptid, active_task, task_is_currently_active,
11704         runtime_initialized>: Declare methods.
11705         <ravenscar_thread_target>: Add constructor.
11706         (ravenscar_thread_target::task_is_currently_active)
11707         (ravenscar_thread_target::update_inferior_ptid)
11708         (ravenscar_runtime_initialized): Rename.  Now methods.
11709         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11710         (ravenscar_thread_target::update_thread_list): Update.
11711         (ravenscar_thread_target::active_task): Now method.
11712         (ravenscar_thread_target::store_registers)
11713         (ravenscar_thread_target::prepare_to_store)
11714         (ravenscar_thread_target::prepare_to_store)
11715         (ravenscar_thread_target::mourn_inferior): Update.
11716         (ravenscar_inferior_created): Use "new" to create target.
11717         (ravenscar_thread_target::get_ada_task_ptid): Update.
11718         (_initialize_ravenscar): Don't initialize base_ptid.
11719         (ravenscar_ops): Remove global.
11720
11721 2019-02-15  Tom Tromey  <tromey@adacore.com>
11722
11723         * target.h (push_target): Declare new overload.
11724         * target.c (push_target): New overload, taking an rvalue reference.
11725         * remote.c (remote_target::open_1): Use push_target overload.
11726         * corelow.c (core_target_open): Use push_target overload.
11727
11728 2019-02-15  Tom Tromey  <tromey@adacore.com>
11729
11730         * ravenscar-thread.c (is_ravenscar_task)
11731         (ravenscar_task_is_currently_active): Return bool.
11732         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11733         (_initialize_ravenscar): Remove "(void)".
11734         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11735         Return bool.
11736
11737 2019-02-15  Tom Tromey  <tromey@adacore.com>
11738
11739         * ravenscar-thread.c (ravenscar_runtime_initializer)
11740         (has_ravenscar_runtime, get_running_thread_id)
11741         (ravenscar_thread_target::resume): Fix indentation.
11742
11743 2019-02-15  Tom Tromey  <tromey@adacore.com>
11744
11745         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11746         from ravenscar_arch_ops.
11747         (sparc_ravenscar_ops::fetch_registers)
11748         (sparc_ravenscar_ops::store_registers): Now methods.
11749         (sparc_ravenscar_prepare_to_store): Remove.
11750         (sparc_ravenscar_ops): Redefine.
11751         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11752         methods and destructor.  Remove members.
11753         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11754         (ravenscar_thread_target::store_registers)
11755         (ravenscar_thread_target::prepare_to_store): Update.
11756         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11757         Remove.
11758         (struct ppc_ravenscar_powerpc_ops): Derive from
11759         ravenscar_arch_ops.
11760         (ppc_ravenscar_powerpc_ops::fetch_registers)
11761         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11762         (ppc_ravenscar_powerpc_ops): Redefine.
11763         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11764         (ppc_ravenscar_e500_ops::fetch_registers)
11765         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11766         (ppc_ravenscar_e500_ops): Redefine.
11767         * aarch64-ravenscar-thread.c
11768         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11769         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11770         (aarch64_ravenscar_fetch_registers)
11771         (aarch64_ravenscar_store_registers): Now methods.
11772         (aarch64_ravenscar_ops): Redefine.
11773
11774 2019-02-15  Tom Tromey  <tromey@adacore.com>
11775
11776         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11777         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11778         (ravenscar_thread_target::stopped_by_watchpoint)
11779         (ravenscar_thread_target::stopped_data_address)
11780         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11781
11782 2019-02-15  Tom Tromey  <tromey@adacore.com>
11783
11784         * ravenscar-thread.c: Fix some typos.
11785
11786 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11787             Tom Tromey  <tromey@adacore.com>
11788
11789         * ada-lang.c (ada_exception_sal): Change addr_string to a
11790         std::string.
11791         (create_ada_exception_catchpoint): Update.
11792
11793 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11794             Tom Tromey  <tromey@adacore.com>
11795
11796         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11797         (bp_location_ops): Remove.
11798         (base_breakpoint_allocate_location): Update.
11799         (free_bp_location): Update.
11800         * ada-lang.c (class ada_catchpoint_location)
11801         <ada_catchpoint_location>: Remove ops parameter.
11802         (ada_catchpoint_location_dtor): Remove.
11803         (ada_catchpoint_location_ops): Remove.
11804         (allocate_location_exception): Update.
11805         * breakpoint.h (struct bp_location_ops): Remove.
11806         (class bp_location) <bp_location>: Remove bp_location_ops
11807         parameter.
11808         <~bp_location>: Add destructor.
11809         <ops>: Remove.
11810
11811 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11812             Pedro Alves  <palves@redhat.com>
11813
11814         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11815         'PATH_MAX'.
11816
11817 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11818             Samuel Thibault  <samuel.thibault@gnu.org>
11819             Thomas Schwinge  <thomas@codesourcery.com>
11820
11821         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11822         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11823
11824 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11825
11826         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11827         (check_empty): Use "const char *".
11828
11829         * gnu-nat.c (gnu_nat_target::detach): Instead of
11830         'detach_inferior (pid)' call
11831         'detach_inferior (find_inferior_pid (pid))'.
11832
11833         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11834         'nat/fork-inferior.o'.
11835         * gnu-nat.c: #include "nat/fork-inferior.h".
11836
11837         * gnu-nat.c (gnu_nat_target::detach): Instead of
11838         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11839         * gnu-nat.h: #include "inf-child.h".
11840         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11841         'i386_gnu_nat_target::fetch_registers'.
11842         (gnu_store_registers): Rename/move to
11843         'i386_gnu_nat_target::store_registers'.
11844
11845         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11846         * gnu-nat.h (mach_thread_info): New function.
11847         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11848
11849         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11850
11851 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11852
11853         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11854
11855 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11856
11857         * windows-nat.c (windows_add_thread): Add new parameter
11858         "main_thread_p" with default value set to false.  Update
11859         function documentation as well as all callers.
11860         (windows_delete_thread): Likewise.
11861         (fake_create_process): Update call to windows_add_thread.
11862         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11863         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11864         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11865         call to windows_delete_thread.
11866
11867 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11868
11869         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11870
11871 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11872
11873         * symfile.c (find_separate_debug_file): Use canonical path of
11874         sysroot with child_path instead of gdb_sysroot if it is valid.
11875
11876 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11877
11878         * symfile.c (find_separate_debug_file): Use child_path to
11879         determine if an object file is under a sysroot.
11880
11881 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11882
11883         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11884         unittests/child-path-selftests.c.
11885         * common/pathstuff.c (child_path): New function.
11886         * common/pathstuff.h (child_path): New prototype.
11887         * unittests/child-path-selftests.c: New file.
11888
11889 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11890
11891         * symfile.c (find_separate_debug_file): Look for separate debug
11892         files in debug directories under the sysroot.
11893
11894 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11895
11896         * symtab.h (struct minimal_symbol data_p): New const method.
11897         (struct minimal_symbol text_p): Likewise.
11898         * symtab.c (output_source_filename): Use file name style
11899         to print file name.
11900         (print_symbol_info): Likewise.
11901         (print_msymbol_info): Use address style to print addresses.
11902         Use function name style to print executable text symbols.
11903         (expand_symtab_containing_pc): Use data_p.
11904         (find_pc_sect_compunit_symtab): Likewise.
11905
11906 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11907
11908         * breakpoint.c (describe_other_breakpoints): Use address style
11909         to print addresses.
11910         (say_where): Likewise.
11911
11912 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11913
11914         * ada-typeprint.c (print_func_type): Print function name
11915         style to print function name.
11916         * c-typeprint.c (c_print_type_1): Likewise.
11917
11918 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11919
11920         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11921         for execve.
11922
11923 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11924
11925         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11926         type_stack.
11927
11928 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11929
11930         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11931         TYPE_CODE_REF types.
11932
11933 2019-02-08  Jim Wilson  <jimw@sifive.com>
11934
11935         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11936         (riscv_linux_fregset): New.
11937         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11938
11939 2019-02-07  Tom Tromey  <tom@tromey.com>
11940
11941         * thread.c (thread_cancel_execution_command): Update.
11942         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11943         methods.
11944         (struct thread_fsm_ops): Remove.
11945         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11946         (thread_fsm_should_stop, thread_fsm_return_value)
11947         (thread_fsm_set_finished, thread_fsm_finished_p)
11948         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11949         Don't declare.
11950         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11951         * infrun.c (clear_proceed_status_thread)
11952         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11953         (print_stop_event): Update.
11954         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11955         Add constructor.
11956         (step_command_fsm_ops): Remove.
11957         (new_step_command_fsm): Remove.
11958         (step_1): Update.
11959         (step_command_fsm::should_stop): Rename from
11960         step_command_fsm_should_stop.
11961         (step_command_fsm::clean_up): Rename from
11962         step_command_fsm_clean_up.
11963         (step_command_fsm::do_async_reply_reason): Rename from
11964         step_command_fsm_async_reply_reason.
11965         (struct until_next_fsm): Inherit from thread_fsm.  Add
11966         constructor.
11967         (until_next_fsm_ops): Remove.
11968         (new_until_next_fsm): Remove.
11969         (until_next_fsm::should_stop): Rename from
11970         until_next_fsm_should_stop.
11971         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11972         (until_next_fsm::do_async_reply_reason): Rename from
11973         until_next_fsm_async_reply_reason.
11974         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11975         constructor.  Change type of breakpoint.
11976         (finish_command_fsm_ops): Remove.
11977         (new_finish_command_fsm): Remove.
11978         (finish_command_fsm::should_stop): Rename from
11979         finish_command_fsm_should_stop.
11980         (finish_command_fsm::clean_up): Rename from
11981         finish_command_fsm_clean_up.
11982         (finish_command_fsm::return_value): Rename from
11983         finish_command_fsm_return_value.
11984         (finish_command_fsm::do_async_reply_reason): Rename from
11985         finish_command_fsm_async_reply_reason.
11986         (finish_command): Update.
11987         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11988         Add constructor.
11989         (call_thread_fsm_ops): Remove.
11990         (call_thread_fsm::call_thread_fsm): Rename from
11991         new_call_thread_fsm.
11992         (call_thread_fsm::should_stop): Rename from
11993         call_thread_fsm_should_stop.
11994         (call_thread_fsm::should_notify_stop): Rename from
11995         call_thread_fsm_should_notify_stop.
11996         (run_inferior_call, call_function_by_hand_dummy): Update.
11997         * cli/cli-interp.c (should_print_stop_to_console): Update.
11998         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11999         Add constructor.  Change type of location_breakpoint,
12000         caller_breakpoint.
12001         (until_break_fsm_ops): Remove.
12002         (new_until_break_fsm): Remove.
12003         (until_break_fsm::should_stop): Rename from
12004         until_break_fsm_should_stop.
12005         (until_break_fsm::clean_up): Rename from
12006         until_break_fsm_clean_up.
12007         (until_break_fsm::do_async_reply_reason): Rename from
12008         until_break_fsm_async_reply_reason.
12009         (until_break_command): Update.
12010         * thread-fsm.c: Remove.
12011         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12012
12013 2019-02-07  Tom Tromey  <tom@tromey.com>
12014
12015         * yy-remap.h: Add include guard.
12016         * xtensa-tdep.h: Add include guard.
12017         * xcoffread.h: Rename include guard.
12018         * varobj-iter.h: Add include guard.
12019         * tui/tui.h: Rename include guard.
12020         * tui/tui-winsource.h: Rename include guard.
12021         * tui/tui-wingeneral.h: Rename include guard.
12022         * tui/tui-windata.h: Rename include guard.
12023         * tui/tui-win.h: Rename include guard.
12024         * tui/tui-stack.h: Rename include guard.
12025         * tui/tui-source.h: Rename include guard.
12026         * tui/tui-regs.h: Rename include guard.
12027         * tui/tui-out.h: Rename include guard.
12028         * tui/tui-layout.h: Rename include guard.
12029         * tui/tui-io.h: Rename include guard.
12030         * tui/tui-hooks.h: Rename include guard.
12031         * tui/tui-file.h: Rename include guard.
12032         * tui/tui-disasm.h: Rename include guard.
12033         * tui/tui-data.h: Rename include guard.
12034         * tui/tui-command.h: Rename include guard.
12035         * tic6x-tdep.h: Add include guard.
12036         * target/waitstatus.h: Rename include guard.
12037         * target/wait.h: Rename include guard.
12038         * target/target.h: Rename include guard.
12039         * target/resume.h: Rename include guard.
12040         * target-float.h: Rename include guard.
12041         * stabsread.h: Add include guard.
12042         * rs6000-tdep.h: Add include guard.
12043         * riscv-fbsd-tdep.h: Add include guard.
12044         * regformats/regdef.h: Rename include guard.
12045         * record.h: Rename include guard.
12046         * python/python.h: Rename include guard.
12047         * python/python-internal.h: Rename include guard.
12048         * python/py-stopevent.h: Rename include guard.
12049         * python/py-ref.h: Rename include guard.
12050         * python/py-record.h: Rename include guard.
12051         * python/py-record-full.h: Rename include guard.
12052         * python/py-record-btrace.h: Rename include guard.
12053         * python/py-instruction.h: Rename include guard.
12054         * python/py-events.h: Rename include guard.
12055         * python/py-event.h: Rename include guard.
12056         * procfs.h: Add include guard.
12057         * proc-utils.h: Add include guard.
12058         * p-lang.h: Add include guard.
12059         * or1k-tdep.h: Rename include guard.
12060         * observable.h: Rename include guard.
12061         * nto-tdep.h: Rename include guard.
12062         * nat/x86-linux.h: Rename include guard.
12063         * nat/x86-linux-dregs.h: Rename include guard.
12064         * nat/x86-gcc-cpuid.h: Add include guard.
12065         * nat/x86-dregs.h: Rename include guard.
12066         * nat/x86-cpuid.h: Rename include guard.
12067         * nat/ppc-linux.h: Rename include guard.
12068         * nat/mips-linux-watch.h: Rename include guard.
12069         * nat/linux-waitpid.h: Rename include guard.
12070         * nat/linux-ptrace.h: Rename include guard.
12071         * nat/linux-procfs.h: Rename include guard.
12072         * nat/linux-osdata.h: Rename include guard.
12073         * nat/linux-nat.h: Rename include guard.
12074         * nat/linux-namespaces.h: Rename include guard.
12075         * nat/linux-btrace.h: Rename include guard.
12076         * nat/glibc_thread_db.h: Rename include guard.
12077         * nat/gdb_thread_db.h: Rename include guard.
12078         * nat/gdb_ptrace.h: Rename include guard.
12079         * nat/fork-inferior.h: Rename include guard.
12080         * nat/amd64-linux-siginfo.h: Rename include guard.
12081         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12082         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12083         * nat/aarch64-linux.h: Rename include guard.
12084         * nat/aarch64-linux-hw-point.h: Rename include guard.
12085         * mn10300-tdep.h: Add include guard.
12086         * mips-linux-tdep.h: Add include guard.
12087         * mi/mi-parse.h: Rename include guard.
12088         * mi/mi-out.h: Rename include guard.
12089         * mi/mi-main.h: Rename include guard.
12090         * mi/mi-interp.h: Rename include guard.
12091         * mi/mi-getopt.h: Rename include guard.
12092         * mi/mi-console.h: Rename include guard.
12093         * mi/mi-common.h: Rename include guard.
12094         * mi/mi-cmds.h: Rename include guard.
12095         * mi/mi-cmd-break.h: Rename include guard.
12096         * m2-lang.h: Add include guard.
12097         * location.h: Rename include guard.
12098         * linux-record.h: Rename include guard.
12099         * linux-nat.h: Add include guard.
12100         * linux-fork.h: Add include guard.
12101         * i386-darwin-tdep.h: Rename include guard.
12102         * hppa-linux-offsets.h: Add include guard.
12103         * guile/guile.h: Rename include guard.
12104         * guile/guile-internal.h: Rename include guard.
12105         * gnu-nat.h: Rename include guard.
12106         * gdb-stabs.h: Rename include guard.
12107         * frv-tdep.h: Add include guard.
12108         * f-lang.h: Add include guard.
12109         * event-loop.h: Add include guard.
12110         * darwin-nat.h: Rename include guard.
12111         * cp-abi.h: Rename include guard.
12112         * config/sparc/nm-sol2.h: Rename include guard.
12113         * config/nm-nto.h: Rename include guard.
12114         * config/nm-linux.h: Add include guard.
12115         * config/i386/nm-i386gnu.h: Rename include guard.
12116         * config/djgpp/nl_types.h: Rename include guard.
12117         * config/djgpp/langinfo.h: Rename include guard.
12118         * compile/gcc-cp-plugin.h: Add include guard.
12119         * compile/gcc-c-plugin.h: Add include guard.
12120         * compile/compile.h: Rename include guard.
12121         * compile/compile-object-run.h: Rename include guard.
12122         * compile/compile-object-load.h: Rename include guard.
12123         * compile/compile-internal.h: Rename include guard.
12124         * compile/compile-cplus.h: Rename include guard.
12125         * compile/compile-c.h: Rename include guard.
12126         * common/xml-utils.h: Rename include guard.
12127         * common/x86-xstate.h: Rename include guard.
12128         * common/version.h: Rename include guard.
12129         * common/vec.h: Rename include guard.
12130         * common/tdesc.h: Rename include guard.
12131         * common/selftest.h: Rename include guard.
12132         * common/scoped_restore.h: Rename include guard.
12133         * common/scoped_mmap.h: Rename include guard.
12134         * common/scoped_fd.h: Rename include guard.
12135         * common/safe-iterator.h: Rename include guard.
12136         * common/run-time-clock.h: Rename include guard.
12137         * common/refcounted-object.h: Rename include guard.
12138         * common/queue.h: Rename include guard.
12139         * common/ptid.h: Rename include guard.
12140         * common/print-utils.h: Rename include guard.
12141         * common/preprocessor.h: Rename include guard.
12142         * common/pathstuff.h: Rename include guard.
12143         * common/observable.h: Rename include guard.
12144         * common/netstuff.h: Rename include guard.
12145         * common/job-control.h: Rename include guard.
12146         * common/host-defs.h: Rename include guard.
12147         * common/gdb_wait.h: Rename include guard.
12148         * common/gdb_vecs.h: Rename include guard.
12149         * common/gdb_unlinker.h: Rename include guard.
12150         * common/gdb_unique_ptr.h: Rename include guard.
12151         * common/gdb_tilde_expand.h: Rename include guard.
12152         * common/gdb_sys_time.h: Rename include guard.
12153         * common/gdb_string_view.h: Rename include guard.
12154         * common/gdb_splay_tree.h: Rename include guard.
12155         * common/gdb_setjmp.h: Rename include guard.
12156         * common/gdb_ref_ptr.h: Rename include guard.
12157         * common/gdb_optional.h: Rename include guard.
12158         * common/gdb_locale.h: Rename include guard.
12159         * common/gdb_assert.h: Rename include guard.
12160         * common/filtered-iterator.h: Rename include guard.
12161         * common/filestuff.h: Rename include guard.
12162         * common/fileio.h: Rename include guard.
12163         * common/environ.h: Rename include guard.
12164         * common/common-utils.h: Rename include guard.
12165         * common/common-types.h: Rename include guard.
12166         * common/common-regcache.h: Rename include guard.
12167         * common/common-inferior.h: Rename include guard.
12168         * common/common-gdbthread.h: Rename include guard.
12169         * common/common-exceptions.h: Rename include guard.
12170         * common/common-defs.h: Rename include guard.
12171         * common/common-debug.h: Rename include guard.
12172         * common/cleanups.h: Rename include guard.
12173         * common/buffer.h: Rename include guard.
12174         * common/btrace-common.h: Rename include guard.
12175         * common/break-common.h: Rename include guard.
12176         * cli/cli-utils.h: Rename include guard.
12177         * cli/cli-style.h: Rename include guard.
12178         * cli/cli-setshow.h: Rename include guard.
12179         * cli/cli-script.h: Rename include guard.
12180         * cli/cli-interp.h: Rename include guard.
12181         * cli/cli-decode.h: Rename include guard.
12182         * cli/cli-cmds.h: Rename include guard.
12183         * charset-list.h: Add include guard.
12184         * buildsym-legacy.h: Rename include guard.
12185         * bfin-tdep.h: Add include guard.
12186         * ax.h: Rename include guard.
12187         * arm-linux-tdep.h: Add include guard.
12188         * arm-fbsd-tdep.h: Add include guard.
12189         * arch/xtensa.h: Rename include guard.
12190         * arch/tic6x.h: Add include guard.
12191         * arch/i386.h: Add include guard.
12192         * arch/arm.h: Rename include guard.
12193         * arch/arm-linux.h: Rename include guard.
12194         * arch/arm-get-next-pcs.h: Rename include guard.
12195         * arch/amd64.h: Add include guard.
12196         * arch/aarch64-insn.h: Rename include guard.
12197         * arch-utils.h: Rename include guard.
12198         * annotate.h: Add include guard.
12199         * amd64-darwin-tdep.h: Rename include guard.
12200         * aarch64-linux-tdep.h: Add include guard.
12201         * aarch64-fbsd-tdep.h: Add include guard.
12202         * aarch32-linux-nat.h: Add include guard.
12203
12204 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12205
12206         * macrotab.c (macro_define_internal): New function that
12207         factorizes macro_define_object_internal and macro_define_function
12208         code.
12209         (macro_define_object_internal): Use macro_define_internal.
12210         (macro_define_function): Likewise.
12211
12212 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12213
12214         * macrocmd.c (extract_identifier): Return
12215         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12216         callers.
12217
12218 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12219
12220         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12221
12222 2019-02-05  Tom Tromey  <tom@tromey.com>
12223
12224         * target.c (target_stack::unpush): Move assertion earlier.
12225
12226 2019-01-30  Tom Tromey  <tom@tromey.com>
12227
12228         PR python/23615:
12229         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12230         (gdbpy_parse_and_eval): Likewise.
12231         * python/python-internal.h (gdbpy_allow_threads): New class.
12232
12233 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12234
12235         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12236         (aarch64_fbsd_fpregmap): Move earlier.
12237         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12238         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12239         instead of individual calls to trad_frame_set_reg_addr.
12240         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12241         earlier.
12242         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12243         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12244         instead of individual calls to trad_frame_set_reg_addr.
12245
12246 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12247
12248         * CONTRIBUTE: Replace contribution list with wiki link.
12249
12250 2019-01-25  Tom Tromey  <tom@tromey.com>
12251
12252         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12253
12254 2019-01-25  Tom Tromey  <tom@tromey.com>
12255
12256         * xtensa-linux-nat.c: Fix common/ includes.
12257         * xml-support.h: Fix common/ includes.
12258         * xml-support.c: Fix common/ includes.
12259         * x86-linux-nat.c: Fix common/ includes.
12260         * windows-nat.c: Fix common/ includes.
12261         * varobj.h: Fix common/ includes.
12262         * varobj.c: Fix common/ includes.
12263         * value.c: Fix common/ includes.
12264         * valops.c: Fix common/ includes.
12265         * utils.c: Fix common/ includes.
12266         * unittests/xml-utils-selftests.c: Fix common/ includes.
12267         * unittests/utils-selftests.c: Fix common/ includes.
12268         * unittests/unpack-selftests.c: Fix common/ includes.
12269         * unittests/tracepoint-selftests.c: Fix common/ includes.
12270         * unittests/style-selftests.c: Fix common/ includes.
12271         * unittests/string_view-selftests.c: Fix common/ includes.
12272         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12273         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12274         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12275         * unittests/rsp-low-selftests.c: Fix common/ includes.
12276         * unittests/parse-connection-spec-selftests.c: Fix common/
12277         includes.
12278         * unittests/optional-selftests.c: Fix common/ includes.
12279         * unittests/offset-type-selftests.c: Fix common/ includes.
12280         * unittests/observable-selftests.c: Fix common/ includes.
12281         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12282         * unittests/memrange-selftests.c: Fix common/ includes.
12283         * unittests/memory-map-selftests.c: Fix common/ includes.
12284         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12285         * unittests/function-view-selftests.c: Fix common/ includes.
12286         * unittests/environ-selftests.c: Fix common/ includes.
12287         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12288         * unittests/common-utils-selftests.c: Fix common/ includes.
12289         * unittests/cli-utils-selftests.c: Fix common/ includes.
12290         * unittests/array-view-selftests.c: Fix common/ includes.
12291         * ui-file.c: Fix common/ includes.
12292         * tui/tui-io.c: Fix common/ includes.
12293         * tracepoint.h: Fix common/ includes.
12294         * tracepoint.c: Fix common/ includes.
12295         * tracefile-tfile.c: Fix common/ includes.
12296         * top.h: Fix common/ includes.
12297         * top.c: Fix common/ includes.
12298         * thread.c: Fix common/ includes.
12299         * target/waitstatus.h: Fix common/ includes.
12300         * target/waitstatus.c: Fix common/ includes.
12301         * target.h: Fix common/ includes.
12302         * target.c: Fix common/ includes.
12303         * target-memory.c: Fix common/ includes.
12304         * target-descriptions.c: Fix common/ includes.
12305         * symtab.h: Fix common/ includes.
12306         * symfile.c: Fix common/ includes.
12307         * stap-probe.c: Fix common/ includes.
12308         * spu-linux-nat.c: Fix common/ includes.
12309         * sparc-nat.c: Fix common/ includes.
12310         * source.c: Fix common/ includes.
12311         * solib.c: Fix common/ includes.
12312         * solib-target.c: Fix common/ includes.
12313         * ser-unix.c: Fix common/ includes.
12314         * ser-tcp.c: Fix common/ includes.
12315         * ser-pipe.c: Fix common/ includes.
12316         * ser-base.c: Fix common/ includes.
12317         * selftest-arch.c: Fix common/ includes.
12318         * s12z-tdep.c: Fix common/ includes.
12319         * rust-exp.y: Fix common/ includes.
12320         * rs6000-aix-tdep.c: Fix common/ includes.
12321         * riscv-tdep.c: Fix common/ includes.
12322         * remote.c: Fix common/ includes.
12323         * remote-notif.h: Fix common/ includes.
12324         * remote-fileio.h: Fix common/ includes.
12325         * remote-fileio.c: Fix common/ includes.
12326         * regcache.h: Fix common/ includes.
12327         * regcache.c: Fix common/ includes.
12328         * record-btrace.c: Fix common/ includes.
12329         * python/python.c: Fix common/ includes.
12330         * python/py-type.c: Fix common/ includes.
12331         * python/py-inferior.c: Fix common/ includes.
12332         * progspace.h: Fix common/ includes.
12333         * producer.c: Fix common/ includes.
12334         * procfs.c: Fix common/ includes.
12335         * proc-api.c: Fix common/ includes.
12336         * printcmd.c: Fix common/ includes.
12337         * ppc-linux-nat.c: Fix common/ includes.
12338         * parser-defs.h: Fix common/ includes.
12339         * osdata.c: Fix common/ includes.
12340         * obsd-nat.c: Fix common/ includes.
12341         * nat/x86-linux.c: Fix common/ includes.
12342         * nat/x86-linux-dregs.c: Fix common/ includes.
12343         * nat/x86-dregs.h: Fix common/ includes.
12344         * nat/x86-dregs.c: Fix common/ includes.
12345         * nat/ppc-linux.c: Fix common/ includes.
12346         * nat/mips-linux-watch.h: Fix common/ includes.
12347         * nat/mips-linux-watch.c: Fix common/ includes.
12348         * nat/linux-waitpid.c: Fix common/ includes.
12349         * nat/linux-ptrace.h: Fix common/ includes.
12350         * nat/linux-ptrace.c: Fix common/ includes.
12351         * nat/linux-procfs.c: Fix common/ includes.
12352         * nat/linux-personality.c: Fix common/ includes.
12353         * nat/linux-osdata.c: Fix common/ includes.
12354         * nat/linux-namespaces.c: Fix common/ includes.
12355         * nat/linux-btrace.h: Fix common/ includes.
12356         * nat/linux-btrace.c: Fix common/ includes.
12357         * nat/fork-inferior.c: Fix common/ includes.
12358         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12359         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12360         * nat/aarch64-linux.c: Fix common/ includes.
12361         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12362         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12363         * namespace.h: Fix common/ includes.
12364         * mips-linux-tdep.c: Fix common/ includes.
12365         * minsyms.c: Fix common/ includes.
12366         * mi/mi-parse.h: Fix common/ includes.
12367         * mi/mi-main.c: Fix common/ includes.
12368         * mi/mi-cmd-env.c: Fix common/ includes.
12369         * memrange.h: Fix common/ includes.
12370         * memattr.c: Fix common/ includes.
12371         * maint.h: Fix common/ includes.
12372         * maint.c: Fix common/ includes.
12373         * main.c: Fix common/ includes.
12374         * machoread.c: Fix common/ includes.
12375         * location.c: Fix common/ includes.
12376         * linux-thread-db.c: Fix common/ includes.
12377         * linux-nat.c: Fix common/ includes.
12378         * linux-fork.c: Fix common/ includes.
12379         * inline-frame.c: Fix common/ includes.
12380         * infrun.c: Fix common/ includes.
12381         * inflow.c: Fix common/ includes.
12382         * inferior.h: Fix common/ includes.
12383         * inferior.c: Fix common/ includes.
12384         * infcmd.c: Fix common/ includes.
12385         * inf-ptrace.c: Fix common/ includes.
12386         * inf-child.c: Fix common/ includes.
12387         * ia64-linux-nat.c: Fix common/ includes.
12388         * i387-tdep.c: Fix common/ includes.
12389         * i386-tdep.c: Fix common/ includes.
12390         * i386-linux-tdep.c: Fix common/ includes.
12391         * i386-linux-nat.c: Fix common/ includes.
12392         * i386-go32-tdep.c: Fix common/ includes.
12393         * i386-fbsd-tdep.c: Fix common/ includes.
12394         * i386-fbsd-nat.c: Fix common/ includes.
12395         * guile/scm-type.c: Fix common/ includes.
12396         * guile/guile.c: Fix common/ includes.
12397         * go32-nat.c: Fix common/ includes.
12398         * gnu-nat.c: Fix common/ includes.
12399         * gdbthread.h: Fix common/ includes.
12400         * gdbarch-selftests.c: Fix common/ includes.
12401         * gdb_usleep.c: Fix common/ includes.
12402         * gdb_select.h: Fix common/ includes.
12403         * gdb_bfd.c: Fix common/ includes.
12404         * gcore.c: Fix common/ includes.
12405         * fork-child.c: Fix common/ includes.
12406         * findvar.c: Fix common/ includes.
12407         * fbsd-nat.c: Fix common/ includes.
12408         * event-top.c: Fix common/ includes.
12409         * event-loop.c: Fix common/ includes.
12410         * dwarf2read.c: Fix common/ includes.
12411         * dwarf2loc.c: Fix common/ includes.
12412         * dwarf2-frame.c: Fix common/ includes.
12413         * dwarf-index-cache.c: Fix common/ includes.
12414         * dtrace-probe.c: Fix common/ includes.
12415         * disasm-selftests.c: Fix common/ includes.
12416         * defs.h: Fix common/ includes.
12417         * csky-tdep.c: Fix common/ includes.
12418         * cp-valprint.c: Fix common/ includes.
12419         * cp-support.h: Fix common/ includes.
12420         * cp-support.c: Fix common/ includes.
12421         * corelow.c: Fix common/ includes.
12422         * completer.h: Fix common/ includes.
12423         * completer.c: Fix common/ includes.
12424         * compile/compile.c: Fix common/ includes.
12425         * compile/compile-loc2c.c: Fix common/ includes.
12426         * compile/compile-cplus-types.c: Fix common/ includes.
12427         * compile/compile-cplus-symbols.c: Fix common/ includes.
12428         * command.h: Fix common/ includes.
12429         * cli/cli-dump.c: Fix common/ includes.
12430         * cli/cli-cmds.c: Fix common/ includes.
12431         * charset.c: Fix common/ includes.
12432         * build-id.c: Fix common/ includes.
12433         * btrace.h: Fix common/ includes.
12434         * btrace.c: Fix common/ includes.
12435         * breakpoint.h: Fix common/ includes.
12436         * breakpoint.c: Fix common/ includes.
12437         * ax.h:
12438         (enum agent_op): Fix common/ includes.
12439         * ax-general.c (struct aop_map): Fix common/ includes.
12440         * ax-gdb.c: Fix common/ includes.
12441         * auxv.c: Fix common/ includes.
12442         * auto-load.c: Fix common/ includes.
12443         * arm-tdep.c: Fix common/ includes.
12444         * arch/riscv.c: Fix common/ includes.
12445         * arch/ppc-linux-common.c: Fix common/ includes.
12446         * arch/i386.c: Fix common/ includes.
12447         * arch/arm.c: Fix common/ includes.
12448         * arch/arm-linux.c: Fix common/ includes.
12449         * arch/arm-get-next-pcs.c: Fix common/ includes.
12450         * arch/amd64.c: Fix common/ includes.
12451         * arch/aarch64.c: Fix common/ includes.
12452         * arch/aarch64-insn.c: Fix common/ includes.
12453         * arch-utils.c: Fix common/ includes.
12454         * amd64-windows-tdep.c: Fix common/ includes.
12455         * amd64-tdep.c: Fix common/ includes.
12456         * amd64-sol2-tdep.c: Fix common/ includes.
12457         * amd64-obsd-tdep.c: Fix common/ includes.
12458         * amd64-nbsd-tdep.c: Fix common/ includes.
12459         * amd64-linux-tdep.c: Fix common/ includes.
12460         * amd64-linux-nat.c: Fix common/ includes.
12461         * amd64-fbsd-tdep.c: Fix common/ includes.
12462         * amd64-fbsd-nat.c: Fix common/ includes.
12463         * amd64-dicos-tdep.c: Fix common/ includes.
12464         * amd64-darwin-tdep.c: Fix common/ includes.
12465         * agent.c: Fix common/ includes.
12466         * ada-lang.h: Fix common/ includes.
12467         * ada-lang.c: Fix common/ includes.
12468         * aarch64-tdep.c: Fix common/ includes.
12469
12470 2019-01-25  Tom Tromey  <tom@tromey.com>
12471
12472         * common/create-version.sh: Use common/version.h.
12473
12474 2019-01-24  Pedro Alves  <palves@redhat.com>
12475
12476         * infrun.c (signal_stop, signal_print, signal_program)
12477         (signal_catch, signal_pass): Now arrays instead of pointers.
12478         (update_signals_program_target, do_target_resume)
12479         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12480         * linux-nat.c (linux_nat_target::pass_signals)
12481         (linux_nat_target::create_inferior, linux_nat_target::attach):
12482         Adjust.
12483         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12484         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12485         * procfs.c (procfs_target::pass_signals): Adjust.
12486         * record-full.c (record_full_target::resume): Adjust.
12487         * remote.c (remote_target::pass_signals)
12488         (remote_target::program_signals): Adjust.
12489         * target-debug.h (target_debug_print_signals): Now takes a
12490         gdb::array_view as parameter.  Adjust.
12491         * target.h (target_ops) <pass_signals, program_signals>: Replace
12492         pointer and length parameters with gdb::array_view.
12493         (target_pass_signals, target_program_signals): Likewise.
12494         * target-delegates.c: Regenerate.
12495
12496 2019-01-24  Pedro Alves  <palves@redhat.com>
12497
12498         * common/forward-scope-exit.h
12499         (forward_scope_exit::forward_scope_exit): Pass arguments to
12500         m_bind_function directly, instead of creating a std::bind and
12501         copying that.
12502
12503 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12504
12505         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12506         for static members.
12507         (pass_in_v_vfp_candidate): Likewise.
12508
12509 2019-01-23  Tom Tromey  <tom@tromey.com>
12510             Pedro Alves  <palves@redhat.com>
12511
12512         * regcache.c (class regcache_invalidator): Remove.
12513         (regcache::raw_write): Use make_scope_exit.
12514
12515 2019-01-23  Tom Tromey  <tom@tromey.com>
12516
12517         * ui-out.h (class ui_out_emit_type): Update comment.
12518
12519 2019-01-23  Tom Tromey  <tom@tromey.com>
12520
12521         * infrun.c (fetch_inferior_event): Update comment.
12522
12523 2019-01-23  Tom Tromey  <tom@tromey.com>
12524             Pedro Alves  <palves@redhat.com>
12525
12526         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12527         parameter.
12528         (fetch_inferior_event): Use SCOPE_EXIT.
12529
12530
12531 2019-01-23  Tom Tromey  <tom@tromey.com>
12532             Pedro Alves  <palves@redhat.com>
12533
12534         * infrun.c (disable_thread_events): Delete.
12535         (stop_all_threads): Use SCOPE_EXIT.
12536
12537 2019-01-23  Tom Tromey  <tom@tromey.com>
12538             Pedro Alves  <palves@redhat.com>
12539
12540         * symfile.c: Include forward-scope-exit.h.
12541         (clear_symtab_users_cleanup): Replace forward declaration with
12542         a FORWARD_SCOPE_EXIT.
12543         (syms_from_objfile_1): Use the forward_scope_exit and
12544         gdb::optional instead of cleanup_function.
12545         (reread_symbols): Use the forward_scope_exit instead of
12546         cleanup_function.
12547         (clear_symtab_users_cleanup): Remove function.
12548
12549 2019-01-23  Tom Tromey  <tom@tromey.com>
12550             Pedro Alves  <palves@redhat.com>
12551
12552         * linux-nat.c: Include scope-exit.h.
12553         (cleanup_target_stop): Remove.
12554         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12555         SCOPE_EXIT.
12556
12557 2019-01-23  Tom Tromey  <tom@tromey.com>
12558             Pedro Alves  <palves@redhat.com>
12559
12560         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12561         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12562
12563 2019-01-23  Tom Tromey  <tom@tromey.com>
12564             Andrew Burgess  <andrew.burgess@embecosm.com>
12565             Pedro Alves  <palves@redhat.com>
12566
12567         * infrun.c (fetch_inferior_event): Use scope_exit.
12568         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12569         * top.c (execute_command): Use scope_exit.
12570         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12571         * utils.c (do_bpstat_clear_actions_cleanup)
12572         (make_bpstat_clear_actions_cleanup): Remove.
12573
12574 2019-01-23  Tom Tromey  <tom@tromey.com>
12575             Pedro Alves  <palves@redhat.com>
12576
12577         * infrun.c: Include "common/scope-exit.h"
12578         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12579         (wait_for_inferior): Use SCOPE_EXIT.
12580         (fetch_inferior_event): Use scope_exit.
12581
12582 2019-01-23  Tom Tromey  <tom@tromey.com>
12583             Pedro Alves  <palves@redhat.com>
12584
12585         * breakpoint.c (create_breakpoint): Remove cleanup.
12586
12587 2019-01-23  Tom Tromey  <tom@tromey.com>
12588             Andrew Burgess  <andrew.burgess@embecosm.com>
12589             Pedro Alves  <palves@redhat.com>
12590
12591 2019-01-23  Pedro Alves  <palves@redhat.com>
12592
12593         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12594
12595 2019-01-23  Pedro Alves  <palves@redhat.com>
12596             Andrew Burgess  <andrew.burgess@embecosm.com>
12597
12598         * gdbthread.h: Include "common/forward-scope-exit.h".
12599         (scoped_finish_thread_state): Redefine custom class in terms of
12600         forward_scope_exit.
12601
12602 2019-01-23  Pedro Alves  <palves@redhat.com>
12603             Andrew Burgess  <andrew.burgess@embecosm.com>
12604
12605         * common/forward-scope-exit.h: New file.
12606
12607 2019-01-23  Pedro Alves  <palves@redhat.com>
12608             Andrew Burgess  <andrew.burgess@embecosm.com>
12609             Tom Tromey  <tom@tromey.com>
12610
12611         * common/scope-exit.h: New file.
12612
12613 2019-01-23  Pedro Alves  <palves@redhat.com>
12614
12615         * common/preprocessor.h (ESC): Rename to ...
12616         (ESC_PARENS): ... this.
12617         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12618         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12619
12620 2019-01-23  Tom Tromey  <tom@tromey.com>
12621
12622         * language.h (class scoped_switch_to_sym_language_if_auto):
12623         Initialize m_lang in both cases.
12624
12625 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12626
12627         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12628         with XCNEW.
12629
12630 2019-01-22  Tom Tromey  <tom@tromey.com>
12631
12632         * corelow.c: Do not include sys/file.h.
12633
12634 2019-01-22  Tom Tromey  <tom@tromey.com>
12635
12636         * tui/tui-wingeneral.h: Include gdb_curses.h.
12637
12638 2019-01-22  Tom Tromey  <tom@tromey.com>
12639
12640         * source-cache.h (class source_cache) <get_source_lines,
12641         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12642
12643 2019-01-22  Tom Tromey  <tom@tromey.com>
12644
12645         * remote-fileio.h (struct remote_target): Declare.
12646
12647 2019-01-22  Tom Tromey  <tom@tromey.com>
12648
12649         * python/py-arch.c: Do not include py-ref.h.
12650         * python/py-bpevent.c: Do not include py-ref.h.
12651         * python/py-cmd.c: Do not include py-ref.h.
12652         * python/py-continueevent.c: Do not include py-ref.h.
12653         * python/py-event.h: Do not include py-ref.h.
12654         * python/py-evtregistry.c: Do not include py-ref.h.
12655         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12656         * python/py-frame.c: Do not include py-ref.h.
12657         * python/py-framefilter.c: Do not include py-ref.h.
12658         * python/py-function.c: Do not include py-ref.h.
12659         * python/py-infevents.c: Do not include py-ref.h.
12660         * python/py-linetable.c: Do not include py-ref.h.
12661         * python/py-objfile.c: Do not include py-ref.h.
12662         * python/py-param.c: Do not include py-ref.h.
12663         * python/py-prettyprint.c: Do not include py-ref.h.
12664         * python/py-progspace.c: Do not include py-ref.h.
12665         * python/py-symbol.c: Do not include py-ref.h.
12666         * python/py-symtab.c: Do not include py-ref.h.
12667         * python/py-type.c: Do not include py-ref.h.
12668         * python/py-unwind.c: Do not include py-ref.h.
12669         * python/py-utils.c: Do not include py-ref.h.
12670         * python/py-value.c: Do not include py-ref.h.
12671         * python/py-varobj.c: Do not include py-ref.h.
12672         * python/py-xmethods.c: Do not include py-ref.h.
12673         * python/python.c: Do not include py-ref.h.
12674         * varobj.c: Do not include py-ref.h.
12675
12676 2019-01-22  Tom Tromey  <tom@tromey.com>
12677
12678         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12679         keyword for bcache.
12680
12681 2019-01-22  Tom Tromey  <tom@tromey.com>
12682
12683         * compile/compile-cplus-types.c: Remove a comment by #include.
12684
12685 2019-01-22  Tom Tromey  <tom@tromey.com>
12686
12687         * compile/gcc-c-plugin.h: Include compile-internal.h.
12688
12689 2019-01-22  Tom Tromey  <tom@tromey.com>
12690
12691         * stabsread.c (EXTERN): Do not define.
12692         (symnum, next_symbol_text_func, processing_gcc_compilation)
12693         (within_function, global_sym_chain, global_stabs)
12694         (previous_stab_code, this_object_header_files)
12695         (n_this_object_header_files)
12696         (n_allocated_this_object_header_files): Define.
12697         * stabsread.h (EXTERN): Never define.  Use "extern".
12698
12699 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12700
12701         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12702         history_value.
12703
12704 2019-01-21  Tom Tromey  <tom@tromey.com>
12705
12706         * ui-out.c: Fix includes.
12707         * tui/tui-source.c: Fix includes.
12708         * target.c: Fix includes.
12709         * remote.c: Fix includes.
12710         * regcache.c: Fix includes.
12711         * python/py-block.c: Fix includes.
12712         * printcmd.c: Fix includes.
12713         * or1k-tdep.c: Fix includes.
12714         * mi/mi-main.c: Fix includes.
12715         * m32r-tdep.c: Fix includes.
12716         * csky-tdep.c: Fix includes.
12717         * compile/compile-cplus-types.c: Fix includes.
12718         * cli/cli-interp.c: Fix includes.
12719
12720 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12721
12722         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12723         for padding.
12724
12725 2019-01-16  Tom Tromey  <tom@tromey.com>
12726
12727         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12728         earlier.
12729         (struct objfile) <msymbols_range>: Move from top level.
12730         <msymbols>: New method.
12731         (class objfile_msymbols): Remove.
12732         * symtab.c (default_collect_symbol_completion_matches_break_on):
12733         Update.
12734         * symmisc.c (dump_msymbols): Update.
12735         * stabsread.c (scan_file_globals): Update.
12736         * objc-lang.c (info_selectors_command, info_classes_command)
12737         (find_methods): Update.
12738         * minsyms.c (find_solib_trampoline_target): Update.
12739         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12740         * coffread.c (coff_symfile_read): Update.
12741         * ada-lang.c (ada_lookup_simple_minsym)
12742         (ada_collect_symbol_completion_matches): Update.
12743
12744 2019-01-16  Tom Tromey  <tom@tromey.com>
12745
12746         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12747         type.  Remove no-argument constructor.
12748         <iterator::operator++>: Simplify.
12749         <begin>: Update.
12750         <end>: Use minimal_symbol_count.
12751
12752 2019-01-16  Tom Tromey  <tom@tromey.com>
12753
12754         * objfiles.h (struct objfile) <psymtabs>: New method.
12755         (class objfile_psymtabs): Remove.
12756         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12757         typedef.
12758         <range>: New method.
12759         (require_partial_symbols): Change return type.
12760         * psymtab.c (require_partial_symbols)
12761         (psym_expand_symtabs_matching): Update.
12762         * mdebugread.c (parse_partial_symbols): Update.
12763         * dbxread.c (dbx_end_psymtab): Update.
12764
12765 2019-01-15  Tom Tromey  <tom@tromey.com>
12766
12767         * symtab.c (lookup_objfile_from_block)
12768         (lookup_symbol_in_objfile_symtabs)
12769         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12770         (find_line_symtab, info_sources_command)
12771         (default_collect_symbol_completion_matches_break_on)
12772         (make_source_files_completion_list): Update.
12773         * symmisc.c (print_objfile_statistics, dump_objfile)
12774         (maintenance_print_symbols, maintenance_info_symtabs)
12775         (maintenance_check_symtabs, maintenance_info_line_tables):
12776         Update.
12777         * source.c (select_source_symtab)
12778         (forget_cached_source_info_for_objfile): Update.
12779         * objfiles.h (class objfile_compunits): Remove.
12780         (struct objfile) <compunits_range>: New typedef.
12781         (compunits): New method.
12782         * objfiles.c (objfile_relocate1): Update.
12783         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12784         * maint.c (count_symtabs_and_blocks): Update.
12785         * linespec.c (iterate_over_all_matching_symtabs): Update.
12786         * cp-support.c (add_symbol_overload_list_qualified): Update.
12787         * coffread.c (coff_symtab_read): Update.
12788         * ada-lang.c (add_nonlocal_symbols)
12789         (ada_collect_symbol_completion_matches)
12790         (ada_add_global_exceptions): Update.
12791
12792 2019-01-15  Tom Tromey  <tom@tromey.com>
12793
12794         * progspace.h (program_space) <objfiles_safe_range>: New
12795         typedef.
12796         <objfiles_safe>: New method.
12797         * objfiles.h (class all_objfiles_safe): Remove.
12798         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12799         * jit.c (jit_inferior_exit_hook): Update.
12800
12801 2019-01-17  Tom Tromey  <tom@tromey.com>
12802
12803         * progspace.h (program_space) <objfiles_range>: New typedef.
12804         <objfiles>: New method.
12805         <objfiles_head>: Rename from objfiles.
12806         (object_files): Update.
12807         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12808         * guile/scm-pretty-print.c
12809         (ppscm_find_pretty_printer_from_objfiles): Update.
12810         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12811         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12812         Update.
12813         * python/py-progspace.c (pspy_get_objfiles): Update.
12814         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12815         Update.
12816         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12817         (objfpy_lookup_objfile_by_build_id): Update.
12818         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12819         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12820         Update.
12821         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12822         (expand_symtab_containing_pc, lookup_objfile_from_block)
12823         (lookup_static_symbol, basic_lookup_transparent_type)
12824         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12825         (find_line_symtab, info_sources_command)
12826         (default_collect_symbol_completion_matches_break_on)
12827         (make_source_files_completion_list, find_main_name): Update.
12828         * symmisc.c (print_symbol_bcache_statistics)
12829         (print_objfile_statistics, maintenance_print_symbols)
12830         (maintenance_print_msymbols, maintenance_print_objfiles)
12831         (maintenance_info_symtabs, maintenance_check_symtabs)
12832         (maintenance_expand_symtabs, maintenance_info_line_tables):
12833         Update.
12834         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12835         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12836         (map_overlay_command, unmap_overlay_command)
12837         (simple_overlay_update, expand_symtabs_matching)
12838         (map_symbol_filenames): Update.
12839         * symfile-debug.c (set_debug_symfile): Update.
12840         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12841         Update.
12842         * source.c (select_source_symtab, forget_cached_source_info):
12843         Update.
12844         * solib.c (solib_read_symbols): Update.
12845         * solib-spu.c (append_ocl_sos): Update.
12846         * psymtab.c (maintenance_print_psymbols)
12847         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12848         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12849         * printcmd.c (info_symbol_command): Update.
12850         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12851         Update.
12852         * objfiles.h (class all_objfiles): Remove.
12853         * objfiles.c (have_partial_symbols, have_full_symbols)
12854         (have_minimal_symbols, qsort_cmp, update_section_map)
12855         (shared_objfile_contains_address_p)
12856         (default_iterate_over_objfiles_in_search_order): Update.
12857         * objc-lang.c (info_selectors_command, info_classes_command)
12858         (find_methods): Update.
12859         * minsyms.c (find_solib_trampoline_target): Update.
12860         * maint.c (maintenance_info_sections)
12861         (maintenance_translate_address, count_symtabs_and_blocks):
12862         Update.
12863         * main.c (captured_main_1): Update.
12864         * linux-thread-db.c (try_thread_db_load_from_pdir)
12865         (has_libpthread): Update.
12866         * linespec.c (iterate_over_all_matching_symtabs)
12867         (search_minsyms_for_name): Update.
12868         * jit.c (jit_find_objf_with_entry_addr): Update.
12869         * hppa-tdep.c (find_unwind_entry)
12870         (hppa_lookup_stub_minimal_symbol): Update.
12871         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12872         Update.
12873         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12874         (elf_gnu_ifunc_resolve_by_got): Update.
12875         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12876         * dwarf-index-write.c (save_gdb_index_command): Update.
12877         * cp-support.c (add_symbol_overload_list_qualified): Update.
12878         * breakpoint.c (create_overlay_event_breakpoint)
12879         (create_longjmp_master_breakpoint)
12880         (create_std_terminate_master_breakpoint)
12881         (create_exception_master_breakpoint): Update.
12882         * blockframe.c (find_pc_partial_function): Update.
12883         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12884         (ada_collect_symbol_completion_matches)
12885         (ada_add_global_exceptions): Update.
12886
12887 2019-01-17  Tom Tromey  <tom@tromey.com>
12888
12889         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12890         declare VEC.
12891         (solib_target_parse_libraries): Change return type.
12892         (library_list_start_segment, library_list_start_section)
12893         (library_list_end_library, library_list_start_library); Update.
12894         (solib_target_free_library_list): Remove.
12895         (solib_target_parse_libraries): Remove cleanup.  Change return
12896         type.
12897         (solib_target_current_sos): Update.
12898
12899 2019-01-17  Tom Tromey  <tromey@bapiya>
12900
12901         * valprint.c: Replace "the the" with "the".
12902         * symtab.c: Replace "the the" with "the".
12903         * solib.c: Replace "the the" with "the".
12904         * solib-dsbt.c: Replace "the the" with "the".
12905         * linespec.c: Replace "the the" with "the".
12906         * dwarf2loc.h: Replace "the the" with "the".
12907         * amd64-windows-tdep.c: Replace "the the" with "the".
12908         * aarch64-tdep.c: Replace "the the" with "the".
12909
12910 2019-01-16  Keith Seitz  <keiths@redhat.com>
12911
12912         PR gdb/23773
12913         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12914         <builder>: Rename to ..
12915         <m_builder>: ... this and make private.
12916         (dwarf2_cu::get_builder): New method.  Change all users of
12917         `builder' to use this method.
12918         (dwarf2_start_symtab): Move to ...
12919         (dwarf2_cu::start_symtab): ... here.  Update all callers
12920         (setup_type_unit_groups): Move to ...
12921         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12922         callers.
12923         (dwarf2_cu::reset_builder): New method.
12924         (process_full_compunit, process_full_type_unit): Use
12925         dwarf2_cu::reset_builder.
12926         (follow_die_offset): Record the ancestor CU if it is different
12927         from the followed DIE's CU.
12928         (follow_die_sig_1): Likewise.
12929
12930 2019-01-15  Tom Tromey  <tom@tromey.com>
12931
12932         * remote.c (class remote_state) <buf>: Now a char_vector.
12933         <buf_size>: Remove.
12934         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12935         parameter.
12936         (remote_target::getpkt_or_notif_sane_1)
12937         (remote_target::getpkt_sane)
12938         (remote_target::getpkt_or_notif_sane): Likewise.
12939         (class remote_target) <putpkt>: New overload.
12940         (remote_target::read_frame): Change type of "buf_p".  Remove
12941         sizeof_p parameter.
12942         (packet_ok): New overload.
12943         (packet_check_result): New overload.
12944         Update all uses.
12945
12946 2019-01-14  Tom Tromey  <tom@tromey.com>
12947
12948         * remote-notif.c (handle_notification, remote_notif_ack)
12949         (remote_notif_parse): Make "buf" const.
12950         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12951         const.
12952         (remote_notif_parse, remote_notif_ack, handle_notification):
12953         Likewise.
12954         * remote.c (remote_notif_stop_parse): Make "buf" const.
12955         (remote_target::remote_parse_stop_reply): Make "buf" const.
12956         (remote_notif_stop_ack): Make "buf" const.
12957
12958 2019-01-14  Tom Tromey  <tom@tromey.com>
12959
12960         * remote.c (remote_console_output): Make parameter const.
12961
12962 2019-01-14  Tom Tromey  <tom@tromey.com>
12963
12964         * target-debug.h (target_debug_print_signals): Constify.
12965         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12966         * procfs.c (procfs_target::pass_signals): Update.
12967         * linux-nat.c (linux_nat_target::pass_signals): Update.
12968         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12969         * target-delegates.c: Rebuild.
12970         * remote.c (remote_target::program_signals): Update.
12971         (remote_target::pass_signals): Update.
12972         * target.c (target_pass_signals): Constify argument.
12973         (target_program_signals): Likewise.
12974         * target.h (struct target_ops) <pass_signals, program_signals>:
12975         Constify argument.
12976         (target_pass_signals, target_program_signals): Constify argument.
12977
12978 2019-01-14  Tom Tromey  <tom@tromey.com>
12979
12980         PR tui/28819:
12981         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12982
12983 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12984
12985         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12986         field.
12987         * rs6000-tdep.c: Include reggroups.h.
12988         (IS_V_ALIAS_PSEUDOREG): Define.
12989         (rs6000_register_name): Return names for the "vX" aliases.
12990         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12991         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12992         aliases.  Call default_register_reggroup_p for all other
12993         pseudo-registers.
12994         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12995         New functions.
12996         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12997         Handle "vX" aliases.
12998         (v_alias_pseudo_register_collect): New function.
12999         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13000         (rs6000_gdbarch_init): Initialize "vX" aliases as
13001         pseudo-registers.  Restore registration of
13002         rs6000_pseudo_register_reggroup_p with
13003         set_tdesc_pseudo_register_reggroup_p.
13004
13005 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13006
13007         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13008         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13009         set_gdbarch_num_pseudo_regs.
13010
13011 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13012
13013         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13014         Remove arg prefixname, add do_set and do_show.
13015         Add member functions set_list and show_list.
13016         * cli/cli-style.c (class cli_style_option): Update accordingly.
13017         (style_set_list): Move to file scope.
13018         (style_show_list): Likewise.
13019         (set_style): Call help_list.
13020         (show_style): Call cmd_show_list.
13021         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13022         Update to use the new macro.
13023
13024 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13025
13026         * ada-lang.c (_initialize_ada_language): Expand the help text
13027         for the "catch exception" command.
13028
13029 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13030
13031         * symtab.c (matching_obj_sections): Initialize obj,
13032         declare it closer to its usage.
13033
13034 2019-01-10  Tom Tromey  <tom@tromey.com>
13035
13036         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13037         (basic_inf_threads_range): Remove.
13038         (inf_threads_range, inf_non_exited_threads_range)
13039         (safe_inf_threads_range): Use next_adapter.
13040
13041 2019-01-10  Keith Seitz  <keiths@redhat.com>
13042
13043         PR gdb/23712
13044         PR symtab/23010
13045         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13046         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13047
13048 2019-01-10  Keith Seitz  <keiths@redhat.com>
13049
13050         PR gdb/23712
13051         PR symtab/23010
13052         * dictionary.c (pending_to_vector): Remove.
13053         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13054         Remove _1 suffix, replacing functions of the same name.  Update
13055         all callers.
13056         (dict_create_hashed, dict_create_hashed_expandable)
13057         (dict_create_linear, dict_create_linear_expandable, dict_free)
13058         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13059         Make functions static.
13060
13061 2019-01-10  Keith Seitz  <keiths@redhat.com>
13062
13063         PR gdb/23712
13064         PR symtab/23010
13065         * dictionary.h (struct dictionary): Replace declaration with
13066         multidictionary.
13067         (dict_create_hashed, dict_create_hashed_expandable)
13068         (dict_create_linear, dict_create_linear_expandable)
13069         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13070         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13071         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13072         taking multidictionary argument.
13073         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13074         * block.h (struct block) <dict>: Change to multidictionary
13075         and rename `multidict'.
13076         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13077         symmisc.c: Update all dictionary references to multidictionary.
13078
13079 2019-01-10  Keith Seitz  <keiths@redhat.com>
13080
13081         PR gdb/23712
13082         PR symtab/23010
13083         * dictionary.c: Include unordered_map.
13084         (pending_to_vector): New function.
13085         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13086         Rewrite the non-"_1" functions to take vector instead
13087         of linked list.
13088         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13089         "new" _1 versions of the same name.
13090         (multidictionary): Define.
13091         (std::hash<enum language): New definition.
13092         (collate_pending_symbols_by_language, mdict_create_hashed)
13093         (mdict_create_hashed_expandable, mdict_create_linear)
13094         (mdict_create_linear_expandable, mdict_free)
13095         (find_language_dictionary, create_new_language_dictionary)
13096         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13097         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13098         (mdict_size, mdict_empty): New functions.
13099         * dictionary.h (mdict_iterator): Define.
13100
13101 2019-01-10  Pedro Alves  <palves@redhat.com>
13102
13103         * breakpoint.c (read_uploaded_action)
13104         (create_tracepoint_from_upload): Adjust to use
13105         gdb::unique_xmalloc_ptr.
13106         * ctf.c (ctf_write_uploaded_tp):
13107         (SET_ARRAY_FIELD): Use emplace_back.
13108         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13109         * tracefile-tfile.c (tfile_write_uploaded_tp):
13110         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13111         gdb::unique_xmalloc_ptr.
13112         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13113         at_string, cond_string, cmd_strings>: Replace char pointers
13114         with gdb::unique_xmalloc_ptr.
13115
13116 2019-01-10  Pedro Alves  <palves@redhat.com>
13117
13118         * solib-target.c (library_list_start_library): Don't xstrdup name.
13119
13120 2019-01-10  Pedro Alves  <palves@redhat.com>
13121
13122         * mdebugread.c (parse_partial_symbols): Use
13123         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13124
13125 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13126
13127         * linux-fork.c (scoped_switch_fork_info)
13128         <~scoped_switch_fork_info>: Fix incorrect variable name.
13129
13130 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13131
13132         * linux-fork.c (scoped_switch_fork_info)
13133         <scoped_switch_fork_info>: Make explicit.
13134         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13135
13136 2019-01-10  Tom Tromey  <tom@tromey.com>
13137
13138         * objfiles.h (objfile::reset_psymtabs): Update.
13139         * objfiles.c (objfile::objfile): Update.
13140         * psymtab.h (psymtab_storage::obstack): Update.
13141         (psymtab_storage::m_obstack): Use gdb::optional.
13142         (class psymtab_storage): Update comment.  Remove objfile
13143         parameter.
13144         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13145
13146 2019-01-10  Tom Tromey  <tom@tromey.com>
13147
13148         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13149         <free_psymtabs>: Now private.
13150         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13151         (allocate_psymtab): Use new method.
13152
13153 2019-01-10  Tom Tromey  <tom@tromey.com>
13154
13155         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13156         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13157         * mdebugread.c (parse_partial_symbols): Use
13158         allocate_dependencies.
13159         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13160         allocate_dependencies.
13161         (process_psymtab_comp_unit_reader)
13162         (build_type_psymtab_dependencies): Likewise.
13163         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13164
13165 2019-01-10  Tom Tromey  <tom@tromey.com>
13166
13167         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13168         PSYMBOL_SET_LANGUAGE.
13169         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13170
13171 2019-01-10  Tom Tromey  <tom@tromey.com>
13172
13173         * psymtab.h (psymtab_storage::obstack): New method.
13174         <m_obstack>: Rename from obstack; now private.
13175         * psymtab.c (psymtab_storage): Update.
13176         * dwarf2read.c (create_addrmap_from_index)
13177         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13178         Update.
13179
13180 2019-01-10  Tom Tromey  <tom@tromey.com>
13181
13182         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13183         * objfiles.h (objfile::reset_psymtabs): New method.
13184
13185 2019-01-10  Tom Tromey  <tom@tromey.com>
13186
13187         * symmisc.c (print_symbol_bcache_statistics): Update.
13188         (print_objfile_statistics): Update.
13189         * symfile.c (reread_symbols): Update.
13190         * psymtab.h (class psymtab_storage): New.
13191         * psymtab.c (psymtab_storage): New constructor.
13192         (~psymtab_storage): New destructor.
13193         (require_partial_symbols): Update.
13194         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13195         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13196         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13197         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13198         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13199         (start_psymtab_common, end_psymtab_common)
13200         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13201         (allocate_psymtab): Update.
13202         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13203         Update.
13204         (dump_psymtab_addrmap, maintenance_print_psymbols)
13205         (maintenance_check_psymtabs): Update.
13206         (class objfile_psymtabs): Move to objfiles.h.
13207         * psympriv.h (discard_psymtab): Now inline.
13208         (psymtab_discarder::psymtab_discarder): Update.
13209         (psymtab_discarder::~psymtab_discarder): Update.
13210         (ALL_OBJFILE_PSYMTABS): Rewrite.
13211         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13212         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13213         Remove fields.
13214         <partial_symtabs>: New field.
13215         (class objfile_psymtabs): Move from psymtab.h.  Update.
13216         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13217         psymbol_cache.
13218         (objfile::~objfile): Don't destroy psymbol_cache.
13219         * mdebugread.c (parse_partial_symbols): Update.
13220         * dwarf2read.c (create_addrmap_from_index)
13221         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13222         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13223         (add_partial_subprogram, dwarf2_ranges_read): Update.
13224         * dwarf-index-write.c (write_address_map)
13225         (write_one_signatured_type, recursively_write_psymbols)
13226         (class debug_names, class debug_names, write_psymtabs_to_index):
13227         Update.
13228
13229 2019-01-10  Tom Tromey  <tom@tromey.com>
13230
13231         * symtab.h (SYMBOL_SET_NAMES): Update.
13232         (symbol_set_names): Update.
13233         (MSYMBOL_SET_NAMES): Update.
13234         * symtab.c (symbol_set_names): Change argument to be an
13235         objfile_per_bfd_storage.
13236         * psymtab.c (add_psymbol_to_bcache): Update.
13237         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13238
13239 2019-01-10  Tom Tromey  <tom@tromey.com>
13240
13241         * symtab.c (create_demangled_names_hash): Change argument to be an
13242         objfile_per_bfd_storage.
13243         (symbol_set_names): Update.
13244
13245 2019-01-10  Tom Tromey  <tom@tromey.com>
13246
13247         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13248         init_psymbol_list.
13249         * psymtab.c (init_psymbol_list): Do nothing if already called.
13250         * psympriv.h (init_psymbol_list): Add comment.
13251         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13252         init_psymbol_list.
13253         * dbxread.c (dbx_symfile_read): Unconditionally call
13254         init_psymbol_list.
13255
13256 2019-01-10  Tom Tromey  <tom@tromey.com>
13257
13258         * xcoffread.c (scan_xcoff_symtab): Update.
13259         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13260         "where".
13261         * mdebugread.c (parse_partial_symbols)
13262         (handle_psymbol_enumerators): Update.
13263         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13264         * dbxread.c (read_dbx_symtab): Update.
13265         * psympriv.h (psymbol_placement): New enum.
13266         (add_psymbol_to_list): Update.
13267
13268 2019-01-10  Tom Tromey  <tom@tromey.com>
13269
13270         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13271         static_psymbols parameters.
13272         (scan_xcoff_symtab): Update.
13273         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13274         static_psymbols parameters.
13275         * psympriv.h (start_psymtab_common): Update.
13276         * mdebugread.c (parse_partial_symbols): Update.
13277         * dwarf2read.c (create_partial_symtab): Update.
13278         * dbxread.c (read_dbx_symtab): Update.
13279         (start_psymtab): Remove global_psymbols and static_psymbols
13280         parameters.
13281
13282 2019-01-10  Tom Tromey  <tom@tromey.com>
13283
13284         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13285         * psymtab.c (allocate_psymtab): Add comment.
13286         * psympriv.h (allocate_psymtab): Add comment.
13287         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13288         initializations.
13289         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13290
13291 2019-01-10  Tom Tromey  <tom@tromey.com>
13292
13293         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13294         Don't declare.
13295         * mipsread.c: Include mdebugread.h.
13296         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13297         Declare.
13298         * elfread.c: Include mdebugread.h.
13299
13300 2019-01-09  Tom Tromey  <tom@tromey.com>
13301
13302         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13303         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13304         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13305         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13306         (psym_lookup_symbol, psym_find_last_source_symtab)
13307         (psym_forget_cached_source_info, psym_print_stats)
13308         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13309         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13310         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13311         (psym_find_compunit_symtab_by_address)
13312         (maintenance_print_psymbols, maintenance_info_psymtabs)
13313         (maintenance_check_psymtabs): Use ranged for.
13314         * psymtab.h (class objfile_psymtabs): New.
13315         (require_partial_symbols): Return objfile_psymtabs.
13316         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13317
13318 2019-01-09  Tom Tromey  <tom@tromey.com>
13319
13320         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13321         (find_pc_mapped_section, list_overlays_command)
13322         (map_overlay_command, unmap_overlay_command)
13323         (simple_overlay_update): Use all_objfiles.
13324         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13325         * printcmd.c (info_symbol_command): Use all_objfiles.
13326         * objfiles.h (ALL_OBJSECTIONS): Remove.
13327         * maint.c (maintenance_translate_address): Use all_objfiles.
13328         * gcore.c (gcore_create_callback): Use all_objfiles.
13329         (objfile_find_memory_regions): Likewise.
13330
13331 2019-01-09  Tom Tromey  <tom@tromey.com>
13332
13333         * symtab.c (find_line_symtab, info_sources_command)
13334         (make_source_files_completion_list): Use objfile_compunits.
13335         * source.c (select_source_symtab): Use objfile_compunits.
13336         * objfiles.h (struct objfile): Update comment.
13337         (ALL_OBJFILES): Remove.
13338         (ALL_FILETABS): Remove.
13339         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13340         objfile_compunits.
13341
13342 2019-01-09  Tom Tromey  <tom@tromey.com>
13343
13344         * symmisc.c (print_objfile_statistics, dump_objfile)
13345         (maintenance_print_symbols): Use compunit_filetabs.
13346         * source.c (forget_cached_source_info_for_objfile): Use
13347         compunit_filetabs.
13348         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13349         (ALL_FILETABS): Use compunit_filetabs.
13350         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13351         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13352
13353 2019-01-09  Tom Tromey  <tom@tromey.com>
13354
13355         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13356         (compunit_filetabs): New.
13357         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13358         compunit_filetabs.
13359         (info_sources_command, make_source_files_completion_list): Remove
13360         declaration.
13361         * symmisc.c (print_objfile_statistics, dump_objfile)
13362         (maintenance_print_symbols): Remove declaration.
13363         (maintenance_info_symtabs): Use compunit_filetabs.
13364         (maintenance_info_line_tables): Likewise.
13365         * source.c (select_source_symtab): Change local variable name.
13366         (forget_cached_source_info_for_objfile): Remove declaration.
13367         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13368         * objfiles.c (objfile_relocate1): Remove declaration.
13369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13370         declaration.
13371         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13372         * coffread.c (coff_symtab_read): Remove declaration.
13373         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13374         compunit_filetabs.
13375
13376 2019-01-09  Tom Tromey  <tom@tromey.com>
13377
13378         * symtab.c (lookup_objfile_from_block)
13379         (find_pc_sect_compunit_symtab, search_symbols)
13380         (default_collect_symbol_completion_matches_break_on): Use
13381         objfile_compunits.
13382         * objfiles.h (ALL_COMPUNITS): Remove.
13383         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13384         * cp-support.c (add_symbol_overload_list_qualified): Use
13385         objfile_compunits.
13386         * ada-lang.c (ada_collect_symbol_completion_matches)
13387         (ada_add_global_exceptions): Use objfile_compunits.
13388
13389 2019-01-09  Tom Tromey  <tom@tromey.com>
13390
13391         * source.c (select_source_symtab)
13392         (forget_cached_source_info_for_objfile): Remove declaration.
13393         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13394         declaration.
13395         * maint.c (count_symtabs_and_blocks): Remove declaration.
13396         * cp-support.c (add_symbol_overload_list_qualified): Remove
13397         declaration.
13398         * coffread.c (coff_symtab_read): Remove declaration.
13399         * symtab.c (lookup_symbol_in_objfile_symtabs)
13400         (basic_lookup_transparent_type_1): Use objfile_compunits.
13401         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13402         (info_sources_command, search_symbols)
13403         (default_collect_symbol_completion_matches_break_on)
13404         (make_source_files_completion_list): Remove declaration.
13405         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13406         (ada_collect_symbol_completion_matches)
13407         (ada_add_global_exceptions): Remove declaration.
13408         * linespec.c (iterate_over_all_matching_symtabs): Use
13409         objfile_compunits.
13410         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13411         (class objfile_compunits): New.
13412         (ALL_COMPUNITS): Use objfile_compunits.
13413         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13414         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13415         objfile_compunits.
13416         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13417
13418 2019-01-09  Tom Tromey  <tom@tromey.com>
13419
13420         * symtab.c (search_symbols)
13421         (default_collect_symbol_completion_matches_break_on): Use
13422         objfile_msymbols.
13423         * ada-lang.c (ada_lookup_simple_minsym)
13424         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13425         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13426         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13427         objfile_msymbols.
13428         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13429         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13430         * objc-lang.c (find_methods): Use objfile_msymbols.
13431         (info_selectors_command, info_classes_command): Likewise.
13432         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13433         * objfiles.h (class objfile_msymbols): New.
13434         (ALL_OBJFILE_MSYMBOLS): Remove.
13435         (ALL_MSYMBOLS): Remove.
13436
13437 2019-01-09  Tom Tromey  <tom@tromey.com>
13438
13439         * common/next-iterator.h (next_adapter): Add Iterator template
13440         parameter.
13441         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13442         (class all_objfiles_safe): New.
13443         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13444         * objfiles.c (put_objfile_before): Update comment.
13445         (add_separate_debug_objfile): Likewise.
13446         (free_all_objfiles): Use all_objfiles_safe.
13447         (objfile_purge_solibs): Likewise.
13448
13449 2019-01-09  Tom Tromey  <tom@tromey.com>
13450
13451         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13452         (expand_symtab_containing_pc, lookup_static_symbol)
13453         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13454         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13455         all_objfiles.
13456         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13457         * breakpoint.c (create_overlay_event_breakpoint)
13458         (create_longjmp_master_breakpoint)
13459         (create_std_terminate_master_breakpoint)
13460         (create_exception_master_breakpoint): Use all_objfiles.
13461         * linux-thread-db.c (try_thread_db_load_from_pdir)
13462         (has_libpthread): Use all_objfiles.
13463         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13464         * linespec.c (iterate_over_all_matching_symtabs)
13465         (search_minsyms_for_name): Use all_objfiles.
13466         * maint.c (maintenance_info_sections): Use all_objfiles.
13467         * main.c (captured_main_1): Use all_objfiles.
13468         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13469         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13470         * guile/scm-pretty-print.c
13471         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13472         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13473         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13474         (maintenance_print_msymbols): Use all_objfiles.
13475         * source.c (select_source_symtab): Use all_objfiles.
13476         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13477         * symfile.c (remove_symbol_file_command)
13478         (expand_symtabs_matching, map_symbol_filenames): Use
13479         all_objfiles.
13480         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13481         all_objfiles.
13482         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13483         * objc-lang.c (find_methods): Use all_objfiles.
13484         * objfiles.c (have_partial_symbols, have_full_symbols)
13485         (have_minimal_symbols, qsort_cmp)
13486         (default_iterate_over_objfiles_in_search_order): Use
13487         all_objfiles.
13488         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13489         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13490         (maintenance_check_psymtabs): Use all_objfiles.
13491         (ALL_PSYMTABS): Remove.
13492         * compile/compile-object-run.c (do_module_cleanup): Use
13493         all_objfiles.
13494         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13495         * cp-support.c (add_symbol_overload_list_qualified): Use
13496         all_objfiles.
13497         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13498         Use all_objfiles.
13499         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13500         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13501         all_objfiles.
13502         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13503         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13504         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13505         Uses all_objfiles.
13506         * solib.c (solib_read_symbols): Use all_objfiles
13507
13508 2019-01-09  Tom Tromey  <tom@tromey.com>
13509
13510         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13511         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13512         all_objfiles.
13513         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13514         * symmisc.c (print_symbol_bcache_statistics)
13515         (print_objfile_statistics, maintenance_print_objfiles)
13516         (maintenance_info_symtabs, maintenance_check_symtabs)
13517         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13518         all_objfiles.
13519         * source.c (forget_cached_source_info): Use all_objfiles.
13520         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13521         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13522         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13523         * objfiles.c (update_section_map): Use all_objfiles.
13524         (shared_objfile_contains_address_p): Likewise.
13525         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13526         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13527
13528 2019-01-09  Tom Tromey  <tom@tromey.com>
13529
13530         * common/next-iterator.h: New file.
13531         * objfiles.h (class all_objfiles): New.
13532         (struct objfile_iterator): New.
13533
13534 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13535
13536         * NEWS: Move the description of the changed "frame", "select-frame",
13537          and "info frame" commands to the Changed commands section.
13538
13539 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13540
13541         * gdbtypes.c (check_stub_method_group): Remove handling of old
13542         mangling schemes.
13543         * linespec.c (find_methods): Likewise.
13544         * stabsread.c (read_member_functions): Likewise.
13545         * valops.c (search_struct_method): Likewise.
13546         (value_struct_elt_for_reference): Likewise.
13547         * NEWS: Mention this change.
13548
13549 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13550
13551         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13552         print_source_lines.
13553         * source.c (print_source_lines_base): Update line number check.
13554         (print_source_lines): New function.
13555         (source_lines_range::source_lines_range): New function.
13556         * source.h (class source_lines_range): New class.
13557         (print_source_lines): New declaration.
13558
13559 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13560
13561         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13562
13563 2019-01-08  Tom Tromey  <tom@tromey.com>
13564             Simon Marchi  <simon.marchi@ericsson.com>
13565
13566         PR gdb/24060
13567         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13568         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13569         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13570         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13571         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13572         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13573
13574 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13575
13576         * source.c (select_source_symtab): Move header comment to
13577         declaration in source.h.
13578         (forget_cached_source_info_for_objfile): Likewise.
13579         (forget_cached_source_info): Likewise.
13580         (identify_source_line): Likewise.
13581         * source.h (identify_source_line): Move declaration from symtab.h
13582         and add comment from source.c
13583         (print_source_lines): Likewise.
13584         (forget_cached_source_info_for_objfile): Likewise.
13585         (forget_cached_source_info): Likewise.
13586         (select_source_symtab): Likewise.
13587         (enum print_source_lines_flag): Move definition from symtab.h.
13588         * symtab.h (identify_source_line): Move declaration to source.h.
13589         (print_source_lines): Likewise.
13590         (forget_cached_source_info_for_objfile): Likewise.
13591         (forget_cached_source_info): Likewise.
13592         (select_source_symtab): Likewise.
13593         (enum print_source_lines_flag): Move definition to source.h.
13594         * tui/tui-hooks.c: Add 'source.h' include.
13595
13596 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13597
13598         * source.c (print_source_lines_base): Handle requests to print
13599         reverse line number sequences, and guard against empty lines
13600         string.
13601
13602 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13603
13604         * source.c (print_source_lines_base): Fix skip of '\r' if next
13605         character is '\n'.
13606
13607 2019-01-06  Tom Tromey  <tom@tromey.com>
13608
13609         * c-exp.y (struct c_parse_state) <macro_original_text,
13610         expansion_obstack>: New member.
13611         (macro_original_text, expansion_obstack): Remove globals.
13612         (scan_macro_expansion, scanning_macro_expansion)
13613         (finished_macro_expansion): Update.
13614         (scan_macro_cleanup): Remove.
13615         (yylex, c_parse): Update.
13616
13617 2019-01-06  Tom Tromey  <tom@tromey.com>
13618
13619         * c-exp.y (struct c_parse_state) <strings>: New member.
13620         (operator_stoken): Update.
13621
13622 2019-01-06  Tom Tromey  <tom@tromey.com>
13623
13624         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13625         (union type_stack_elt) <typelist_val>: Now a pointer to
13626         std::vector.
13627         (type_stack_cleanup): Don't declare.
13628         (push_typelist): Update.
13629         * parse.c (pop_typelist): Return a std::vector.
13630         (push_typelist): Take a std::vector.
13631         (follow_types): Update.  Do not free args.
13632         (type_stack_cleanup): Remove.
13633         * c-exp.y (struct c_parse_state): New.
13634         (cpstate): New global.
13635         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13636         (nonempty_typelist): Update.
13637         (func_mod): Create a new vector.
13638         (c_parse): Create a c_parse_state.
13639         (check_parameter_typelist): Do not delete params.
13640         (function_method): Update.  Do not delete type_list.
13641
13642 2019-01-06  Tom Tromey  <tom@tromey.com>
13643
13644         PR gdb/28155:
13645         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13646         check_typedef.
13647         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13648         (print_return_value): Likewise.
13649
13650 2019-01-05  Tom Tromey  <tom@tromey.com>
13651
13652         * contrib/cleanup_check.py: Remove.
13653         * contrib/gcc-with-excheck: Remove.
13654         * contrib/exsummary.py: Remove.
13655         * contrib/excheck.py: Remove.
13656
13657 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13658
13659         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13660         NULL. Initialize tpprev to NULL instead of assigning it
13661         to NULL on the next statement.
13662         * windows-nat.c (windows_delete_thread): Remove check for
13663         main_thread_id before printing thread exit notifications.
13664         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13665         Remove thread ID check against main_thread_id.
13666         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13667         windows_delete_thread.
13668         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13669
13670 2019-01-04  Tom Tromey  <tom@tromey.com>
13671
13672         * compile/compile.c (_initialize_compile): Use upper case for
13673         metasyntactic variables.
13674         * symmisc.c (_initialize_symmisc): Use upper case for
13675         metasyntactic variables.
13676         * psymtab.c (_initialize_psymtab): Use upper case for
13677         metasyntactic variables.
13678         * demangle.c (demangle_command): Use upper case for metasyntactic
13679         variables.
13680         (_initialize_demangler): Likewise.
13681         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13682         variables.
13683
13684 2019-01-03  Tom Tromey  <tom@tromey.com>
13685
13686         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13687
13688 2019-01-03  Tom Tromey  <tom@tromey.com>
13689
13690         * python/py-symtab.c (salpy_str): Update.
13691         (struct salpy_sal_object) <symtab>: Now a PyObject.
13692         (salpy_dealloc): Update.
13693         (del_objfile_sal): Use gdbpy_ref.
13694
13695 2019-01-03  Tom Tromey  <tom@tromey.com>
13696
13697         * python/py-type.c (convert_field): Use new_reference.  Return
13698         gdbpy_ref.
13699         (make_fielditem): Return gdbpy_ref.
13700         (typy_fields): Update.
13701         (typy_getitem): Update.
13702         (field_name): Return gdbpy_ref.  Use new_reference.
13703         (typy_iterator_iternext): Update.
13704
13705 2019-01-03  Tom Tromey  <tom@tromey.com>
13706
13707         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13708
13709 2019-01-03  Tom Tromey  <tom@tromey.com>
13710
13711         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13712         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13713         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13714         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13715         (pspy_set_type_printers): Likewise.
13716         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13717         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13718         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13719         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13720         (objfpy_set_type_printers): Likewise.
13721
13722 2019-01-03  Tom Tromey  <tom@tromey.com>
13723
13724         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13725         (gdbpy_print_stack): Use gdbpy_err_fetch.
13726         * python/python-internal.h (class gdbpy_err_fetch): New class.
13727         (class gdbpy_enter) <m_error_type, m_error_value,
13728         m_error_traceback>: Remove.
13729         <m_error>: New member.
13730         (gdbpy_exception_to_string): Don't declare.
13731         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13732         * python/py-value.c (convert_value_from_python): Use
13733         gdbpy_err_fetch.
13734         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13735         gdbpy_exception_to_string.
13736         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13737         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13738         gdbpy_err_fetch.
13739
13740 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13741
13742         * linux-nat.c (delete_lwp_cleanup): Delete.
13743         (struct lwp_deleter): New struct.
13744         (lwp_info_up): New typedef.
13745         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13746         lwp_info_up.
13747
13748 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13749
13750         * linux-fork.c (class scoped_switch_fork_info): New class.
13751         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13752
13753 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13754
13755         * valops.c (find_overload_match): Remove use of null_cleanup, and
13756         calls to do_cleanups.
13757
13758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13759
13760         * compile/compile-cplus-types.c
13761         (compile_cplus_instance::decl_name): Handle changes to
13762         cp_func_name.
13763         * cp-support.c (cp_func_name): Update header comment, update
13764         return type.
13765         * cp-support.h (cp_func_name): Update return type in declaration.
13766         * valops.c (find_overload_match): Move temp_func local to top
13767         level of function and change its type.  Use temp_func to hold and
13768         delete temporary string obtained from cp_func_name.
13769
13770 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13771
13772         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13773         gdb::char_vector, remove cleanup, and update uses of `msg`.
13774
13775 2019-01-03  Jim Wilson  <jimw@sifive.com>
13776
13777         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13778
13779 2019-01-02  Tom Tromey  <tom@tromey.com>
13780
13781         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13782         (tdesc_parse_xml): Remove cleanups.
13783         * target-descriptions.h (make_cleanup_free_target_description):
13784         Don't declare.
13785         (target_desc_deleter): New struct.
13786         (target_desc_up): New typedef.
13787         * target-descriptions.c (target_desc_deleter::operator()): Rename
13788         from free_target_description.
13789         (make_cleanup_free_target_description): Remove.
13790
13791 2019-01-02  Tom Tromey  <tom@tromey.com>
13792
13793         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13794         constructor, destructor.
13795         (linespec_parser): Remove typedef.
13796         (~linespec_parser): Rename from linespec_parser_delete.
13797         (linespec_lex_to_end, linespec_complete_label)
13798         (linespec_complete): Update.
13799         (decode_line_full): Remove cleanups.
13800         (decode_line_1): Update.
13801
13802 2019-01-02  Tom Tromey  <tom@tromey.com>
13803
13804         * python/python-internal.h (inferior_to_inferior_object): Change
13805         return type.
13806         * python/py-exitedevent.c (create_exited_event_object): Update.
13807         * python/py-inferior.c (inferior_to_inferior_object): Return
13808         gdbpy_ref.
13809         (python_new_inferior, python_inferior_deleted)
13810         (thread_to_thread_object, delete_thread_object)
13811         (build_inferior_list, gdbpy_selected_inferior): Update.
13812         * python/py-infthread.c (create_thread_object): Update.  Also fail
13813         if inferior_to_inferior_object fails.
13814
13815 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13816
13817         * inferior.h (class inferior) <displaced_step_state>: New field.
13818         * infrun.h (struct displaced_step_state): Move here from
13819         infrun.c.  Initialize fields, add constructor.
13820         <inf>: Remove field.
13821         <reset>: New method.
13822         * infrun.c (struct displaced_step_inferior_state): Move to
13823         infrun.h.
13824         (displaced_step_inferior_states): Remove.
13825         (get_displaced_stepping_state): Adust.
13826         (displaced_step_in_progress_any_inferior): Adjust.
13827         (displaced_step_in_progress_thread): Adjust.
13828         (displaced_step_in_progress): Adjust.
13829         (add_displaced_stepping_state): Remove.
13830         (get_displaced_step_closure_by_addr): Adjust.
13831         (remove_displaced_stepping_state): Remove.
13832         (infrun_inferior_exit): Call displaced_step_state.reset.
13833         (use_displaced_stepping): Don't check for NULL.
13834         (displaced_step_prepare_throw): Call
13835         get_displaced_stepping_state.
13836         (displaced_step_fixup): Don't check for NULL.
13837         (prepare_for_detach): Don't check for NULL.
13838
13839 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13840
13841         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13842          in case of call that did not complete.
13843
13844 2019-01-02  Andrey Utkin  <autkin@undo.io>
13845
13846         * symfile.c (find_separate_debug_file): Fix search of debug files for
13847         remote debuggee.
13848
13849 2019-01-02  Tom Tromey  <tom@tromey.com>
13850
13851         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13852         indentation.
13853         * python/py-frame.c (frapy_older): Remove cast.
13854         (frapy_newer): Likewise.
13855         * python/py-breakpoint.c (local_setattro): Remove cast.
13856         * python/py-arch.c (archpy_name): Remove local variable.
13857         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13858
13859 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13860
13861         * unittests/basic_string_view/element_access/char/empty.cc:
13862         Fix year range in copyright header.
13863
13864 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13865
13866         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13867         Delete.
13868         <operator==>: Update with for removed field.
13869         <hash>: Likewise.
13870         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13871         <isa_features>: ...this.
13872         <abi_features>: New field.
13873         (riscv_isa_flen): Update comment.
13874         (riscv_abi_xlen): New declaration.
13875         (riscv_abi_flen): New declaration.
13876         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13877         isa_features.
13878         (riscv_abi_xlen): New function.
13879         (riscv_isa_flen): Update to get answer from isa_features.
13880         (riscv_abi_flen): New function.
13881         (riscv_has_fp_abi): Update to get answer from abi_features.
13882         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13883         xlen and flen.
13884         (riscv_call_info) <xlen, flen>: Update comment.
13885         (riscv_call_arg_struct): Remove invalid assertions
13886         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13887         is removed.
13888         (riscv_gdbarch_init): Gather isa features and abi features
13889         separately, ensure both match on the gdbarch when reusing an old
13890         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13891         a target with 64-bit float hardware.
13892
13893 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13894
13895         * source.c (search_command_helper): Stop reverse search
13896         when line 1 has been searched.
13897
13898 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13899
13900         * record-full.c (record_full_base_target::close): Rewrite
13901         record_full_core_buf_list free logic.
13902
13903 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13904
13905         * break-catch-syscall.c (print_one_catch_syscall): xfree
13906         the last text.
13907
13908 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13909
13910         * top.c (print_gdb_version): Update Copyright year in version
13911         message.
13912
13913 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13914
13915         Update copyright year range in all GDB files.
13916
13917 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13918
13919         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13920
13921 For older changes see ChangeLog-2018.
13922 \f
13923 Local Variables:
13924 mode: change-log
13925 left-margin: 8
13926 fill-column: 74
13927 version-control: never
13928 coding: utf-8
13929 End:
13930