gdb/ChangeLog

   1 2019-11-05  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
   4         (tui_disassemble): Set addr_size.
   5         (tui_disasm_window::set_contents): Use addr_size.
   6
   7 2019-11-05  Tom Tromey  <tom@tromey.com>
   8
   9         * rust-lang.c (rust_language_defn): Update.
  10         * python/py-value.c (valpy_string): Call c_get_string.
  11         * p-lang.c (pascal_language_defn): Update.
  12         * opencl-lang.c (opencl_language_defn): Update.
  13         * objc-lang.c (objc_language_defn): Update.
  14         * m2-lang.c (m2_language_defn): Update.
  15         * language.c (unknown_language_defn, auto_language_defn): Update.
  16         (default_get_string): Remove.
  17         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
  18         * go-lang.c (go_language_defn): Update.
  19         * f-lang.c (f_language_defn): Update.
  20         * d-lang.c (d_language_defn): Update.
  21         * c-lang.c (c_language_defn, cplus_language_defn)
  22         (asm_language_defn, minimal_language_defn): Update.
  23         * ada-lang.c (ada_language_defn): Update.
  24         * language.h (struct language_defn) <la_get_string>: Remove.
  25         (LA_GET_STRING): Remove.
  26         (default_get_string): Don't declare.
  27
  28 2019-11-05  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-source.h (struct tui_source_window): Inline
  31         constructor.  Remove destructor.
  32         <style_changed, m_observable>: Move to superclass.
  33         * tui/tui-winsource.h (tui_copy_source_line): Declare.
  34         (struct tui_source_window_base): Move private members to end.
  35         <style_changed, m_observable>: Move from tui_source_window.
  36         * tui/tui-winsource.c (tui_copy_source_line): Move from
  37         tui-source.c.  Rename from copy_source_line.  Add special handling
  38         for negative line number.
  39         (tui_source_window_base::style_changed): Move from
  40         tui_source_window.
  41         (tui_source_window_base): Register observer.
  42         (~tui_source_window_base): New.
  43         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
  44         rename.
  45         (tui_source_window::set_contents): Use tui_copy_source_line.
  46         (tui_source_window::tui_source_window): Move to tui-source.h.
  47         (tui_source_window::~tui_source_window): Remove.
  48         (tui_source_window::style_changed): Move to superclass.
  49         * tui/tui-disasm.c (tui_disassemble): Create string file with
  50         styling, when possible.  Add "addr_size" parameter.
  51         (tui_disasm_window::set_contents): Use tui_copy_source_line.
  52         Don't compute maximum size.
  53         (len_without_escapes): New function
  54
  55 2019-11-05  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
  58         std::string.
  59         * tui/tui-winsource.c (tui_show_source_line): Update.
  60         * tui/tui-source.c (tui_source_window::set_contents): Update.
  61         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  62
  63 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * symtab.h (gdb_static_assert): Put && operator at the beginning
  66         of the line instead of the end.
  67
  68 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
  69
  70         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
  71         and sizeof (symbol).
  72         * symtab.h: Add a static_assert for sizeof (partial_symbol).
  73
  74 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  75
  76         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
  77         * configure.host: Mark *-*-solaris2.10* obsolete.
  78         * configure.tgt: Mark Solaris < 11 obsolete.
  79         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
  80         Update target triplet.
  81
  82 2019-11-01  Tom Tromey  <tromey@adacore.com>
  83
  84         * utils.c (print_sys_errmsg): Simplify.
  85
  86 2019-11-01  Tom Tromey  <tromey@adacore.com>
  87
  88         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
  89
  90 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * configure: Regenerate.
  93         * configure.ac: Remove check for strerror_r.
  94         * gdbsupport/common.m4: Check for strerror_r.
  95
  96 2019-11-01  Luis Machado  <luis.machado@linaro.org>
  97
  98         PR gdb/25124
  99
 100         * arm-tdep.c (arm_per_objfile): Rename to ...
 101         (arm_per_bfd): ... this.
 102         (arm_objfile_data_key): Rename to ...
 103         (arm_bfd_data_key): ... this.
 104         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 105         data.
 106         (arm_record_special_symbol): Likewise.
 107
 108 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 109
 110         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 111         end.
 112         * c-typeprint.c (c_print_typedef): Likewise.
 113         * f-typeprint.c (f_print_typedef): Likewise.
 114         * m2-typeprint.c (m2_print_typedef): Likewise.
 115         * p-typeprint.c (pascal_print_typedef): Likewise.
 116         * rust-lang.c (rust_print_typedef): Likewise.
 117         * symtab.c (print_symbol_info): Print a newline after calling
 118         typedef_print.
 119
 120 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 121
 122         * symtab.c (info_module_cmdlist): New variable.
 123         (info_module_command): New function.
 124         (search_module_symbols): New function.
 125         (info_module_subcommand): New function.
 126         (struct info_modules_var_func_options): New struct.
 127         (info_modules_var_func_options_defs): New variable.
 128         (make_info_modules_var_func_options_def_group): New function.
 129         (info_module_functions_command): New function.
 130         (info_module_variables_command): New function.
 131         (info_module_var_func_command_completer): New function.
 132         (_initialize_symtab): Register new 'info module functions' and
 133         'info module variables' commands.
 134         * symtab.h (typedef symbol_search_in_module): New typedef.
 135         (search_module_symbols): Declare new function.
 136         * NEWS: Mention new commands.
 137
 138 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 141         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 142         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 143         MODULES_DOMAIN.
 144         (scan_partial_symbols): Only create partial module symbols for non
 145         declarations.
 146         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 147         and MODULES_DOMAIN.
 148         * symtab.c (search_domain_name): Likewise.
 149         (search_symbols): Likewise.
 150         (print_symbol_info): Likewise.
 151         (symtab_symbol_info): Likewise.
 152         (info_modules_command): New function.
 153         (_initialize_symtab): Register 'info modules' command.
 154         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 155         * NEWS: Mention new 'info modules' command.
 156
 157 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 158
 159         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 160         and $_gdb_maint_setting_str.
 161
 162 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 163
 164         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 165         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 166         (str_value_from_setting, gdb_setting_str_internal_fn)
 167         (gdb_maint_setting_str_internal_fn): New functions.
 168         (_initialize_cli_cmds): Define the new convenience functions.
 169         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 170         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 171
 172 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 173
 174         * agent.c (set_can_use_agent): When the setting is turned on,
 175         look up agent symbols if we don't have them yet.
 176         (agent_new_objfile): Don't look up agent symbols when the agent
 177         setting is off.
 178
 179 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 180
 181         * config.in: Regenerate.
 182
 183 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * configure: Regenerate.
 186         * configure.ac: Check for strerror_r.
 187         * gdbsupport/common-utils.h (safe_strerror): Change return value
 188         to const char * and document that this function is now threadsafe.
 189         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 190         thread_local and call strerror_r, if available.
 191         * utils.c (perror_string): Update.
 192         (print_sys_errmsg): Update.
 193
 194 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 195
 196         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 197         objfile_key.
 198         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 199         objfile to fetch per-bfd data.
 200         (arm_find_exidx_entry): Likewise.
 201
 202 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 203
 204         * gdbsupport/agent.c (debug_agent): Change type to bool.
 205         (use_agent): Likewise.
 206         (all_agent_symbols_look_up): Likewise.
 207         (agent_loaded_p): Change return value to bool.
 208         (agent_look_up_symbols): Update.
 209         (agent_capability_check): Change return value to bool.
 210         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 211         (debug_agent): Change type to bool.
 212         (use_agent): Likewise.
 213         (agent_capability_check): Change return value to bool.
 214
 215 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 216
 217         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 218         (build_minimal_symbol_hash_tables): Code to clear the table moved
 219         to clear_minimal_symbol_hash_tables.
 220         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 221         when needed.
 222
 223 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 224
 225         * infcmd.c: Remove includes.
 226         * infrun.c: Remove includes.
 227
 228 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 229
 230         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 231         (grow_vect): Remove declaration.
 232         (ada_type_of_array): Remove declaration.
 233         (ada_update_initial_language): Remove declaration.
 234         (ada_fold_name): Remove declaration.
 235         (ada_fill_in_ada_prototype): Remove declaration.
 236         (user_select_syms): Remove declaration.
 237         (get_selections): Remove declaration.
 238         (ada_tag_type): Remove declaration.
 239         (ada_value_tag): Remove declaration.
 240         (ada_is_others_clause): Remove declaration.
 241         (ada_in_variant): Remove declaration.
 242         (ada_value_struct_elt): Remove declaration.
 243         (ada_attribute_name): Remove declaration.
 244         (ada_system_address_type): Remove declaration.
 245         * ada-lang.c (ada_watch_location_expression): Make static.
 246         (GROW_VECT): Move here from ada-lang.h.
 247         (grow_vect): Make static.
 248         (ada_update_initial_language): Make static.
 249         (ada_fold_name): Make static.
 250         (ada_type_of_array): Make static.
 251         (encoded_ordered_before): Move up.
 252         (sort_choices): Move up.
 253         (print_signatures): Move up.
 254         (ada_print_symbol_signature): Move up.
 255         (get_selections): Move up and make static.
 256         (user_select_syms): Move up and make static.
 257         (ada_value_struct_elt): Move up and make static.
 258         (ada_tag_type): Make static.
 259         (ada_value_tag): Make static.
 260         (ada_is_others_clause): Make static.
 261         (ada_in_variant): Make static.
 262         (ada_attribute_name): Make static.
 263
 264 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 265
 266         * ada-lang.c: Remove includes.
 267         * ada-typeprint.c: Remove includes.
 268         * ada-valprint.c: Remove includes.
 269
 270 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 271
 272         * addrmap.c: Add static assertions of type size, moved from
 273         _initialize_addrmap.
 274         (_initialize_addrmap): Remove.
 275
 276 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 277
 278         * coffread.c (record_minimal_symbol): Update.
 279         (process_coff_symbol): Update.
 280         * dbxread.c (read_dbx_symtab): Update.
 281         * dwarf2read.c (add_partial_symbol): Update.
 282         (fixup_go_packaging): Update.
 283         (load_partial_dies): Update.
 284         (new_symbol): Update.
 285         * elfread.c (record_minimal_symbol): Change signature to use
 286         gdb::string_view instead of name+len.
 287         (elf_symtab_read): Update.
 288         (elf_rel_plt_read): Update.
 289         * mdebugread.c (parse_partial_symbols): Update.
 290         (handle_psymbol_enumerators): Update.
 291         (new_symbol): Update.
 292         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 293         to use gdb::string_view instead of name+len.
 294         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 295         * psympriv.h (add_psymbol_to_list): Likewise.
 296         * psymtab.c (add_psymbol_to_bcache): Likewise.
 297         (add_psymbol_to_list): Likewise.
 298         * stabsread.c (define_symbol): Update.
 299         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 300         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 301         (symbol_set_names): Likewise.
 302         * xcoffread.c (scan_xcoff_symtab): Update.
 303
 304 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 305
 306         * symtab.h (symbol_set_names): Document that copy_name must be
 307         set to true for non-nullterminated strings.
 308         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 309         linkage_name if the entry was not found and we need to demangle.
 310
 311 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 314         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 315         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 316         * gdbsupport/gdb_binary_search.h: New file.
 317
 318 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 319
 320         * NEWS: Mention new --with-system-gdbinit-dir option.
 321         * config.in: Regenerate.
 322         * configure: Regenerate.
 323         * configure.ac: Add new option --with-system-gdbinit-dir.
 324         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 325         for a ".gdb" suffix.
 326         * main.c (get_init_files): Change system_gdbinit argument to
 327         a vector and return the files in SYSTEM_GDBINIT_DIR in
 328         addition to SYSTEM_GDBINIT.
 329         (captured_main_1): Update.
 330         (print_gdb_help): Update.
 331         * top.c (print_gdb_configuration): Also print the value of
 332         SYSTEM_GDBINIT_DIR.
 333
 334 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 335
 336         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 337         that takes gdb::string_view arguments.
 338
 339 2019-10-26  Tom de Vries  <tdevries@suse.de>
 340
 341         * aarch64-linux-tdep.c: Fix typos in comments.
 342         * aarch64-tdep.c: Same.
 343         * ada-lang.c: Same.
 344         * amd64-nat.c: Same.
 345         * arc-tdep.c: Same.
 346         * arch/aarch64-insn.c: Same.
 347         * block.c: Same.
 348         * breakpoint.h: Same.
 349         * btrace.h: Same.
 350         * c-varobj.c: Same.
 351         * cli/cli-decode.c: Same.
 352         * cli/cli-script.c: Same.
 353         * cli/cli-utils.h: Same.
 354         * coff-pe-read.c: Same.
 355         * coffread.c: Same.
 356         * compile/compile-cplus-symbols.c: Same.
 357         * compile/compile-object-run.c: Same.
 358         * completer.c: Same.
 359         * corelow.c: Same.
 360         * cp-support.c: Same.
 361         * demangle.c: Same.
 362         * dwarf-index-write.c: Same.
 363         * dwarf2-frame.c: Same.
 364         * dwarf2-frame.h: Same.
 365         * eval.c: Same.
 366         * frame-base.h: Same.
 367         * frame.h: Same.
 368         * gdbcmd.h: Same.
 369         * gdbtypes.h: Same.
 370         * gnu-nat.c: Same.
 371         * guile/scm-objfile.c: Same.
 372         * i386-tdep.c: Same.
 373         * i386-tdep.h: Same.
 374         * infcall.c: Same.
 375         * infcall.h: Same.
 376         * linux-nat.c: Same.
 377         * m68k-tdep.c: Same.
 378         * macroexp.c: Same.
 379         * memattr.c: Same.
 380         * mi/mi-cmd-disas.c: Same.
 381         * mi/mi-getopt.h: Same.
 382         * mi/mi-main.c: Same.
 383         * minsyms.c: Same.
 384         * nat/aarch64-sve-linux-sigcontext.h: Same.
 385         * objfiles.h: Same.
 386         * ppc-linux-nat.c: Same.
 387         * ppc-linux-tdep.c: Same.
 388         * ppc-tdep.h: Same.
 389         * progspace.h: Same.
 390         * prologue-value.h: Same.
 391         * python/py-evtregistry.c: Same.
 392         * python/py-instruction.h: Same.
 393         * record-btrace.c: Same.
 394         * record-full.c: Same.
 395         * remote.c: Same.
 396         * rs6000-tdep.c: Same.
 397         * ser-tcp.c: Same.
 398         * sol-thread.c: Same.
 399         * sparc-sol2-tdep.c: Same.
 400         * sparc64-tdep.c: Same.
 401         * stabsread.c: Same.
 402         * symfile.c: Same.
 403         * symtab.h: Same.
 404         * target.c: Same.
 405         * tracepoint.c: Same.
 406         * tui/tui-data.h: Same.
 407         * tui/tui-io.c: Same.
 408         * tui/tui-win.c: Same.
 409         * tui/tui.c: Same.
 410         * unittests/rsp-low-selftests.c: Same.
 411         * user-regs.h: Same.
 412         * utils.c: Same.
 413         * utils.h: Same.
 414         * valarith.c: Same.
 415         * valops.c: Same.
 416         * valprint.c: Same.
 417         * valprint.h: Same.
 418         * value.c: Same.
 419         * value.h: Same.
 420         * varobj.c: Same.
 421         * x86-nat.h: Same.
 422         * xtensa-tdep.c: Same.
 423
 424 2019-10-25  Ali Tamur <tamur@google.com>
 425
 426         * charset.c (find_charset_names): Reflect API change.
 427
 428 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * symtab.c (struct demangled_name_entry): Change demangled name
 431         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 432         part of the struct anymore.
 433         (symbol_set_names): No longer obstack allocate + copy the demangled
 434         name, just store the allocated name from bfd.
 435
 436 2019-10-25  Tom Tromey  <tromey@adacore.com>
 437
 438         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 439         (bsearch_cie_cmp, add_cie): Remove.
 440         (find_cie): Reimplement.
 441         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 442         (dwarf2_build_frame_info): Update.
 443
 444 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 445
 446         PR gdb/25126
 447         * symfile.c (reread_symbols): Call forget_cached_source_info to
 448         clear the stale source cache.
 449
 450 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 451
 452         * configure: Regenerate.
 453         * configure.ac: Remove code that sets python_has_threads.
 454
 455 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 456
 457         * config.in: Regenerate.
 458         * configure: Regenerate.
 459         * configure.ac: Remove the code that uses sed to get the python
 460         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 461
 462 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 465         error paths.
 466
 467 2019-10-23  Tom Tromey  <tom@tromey.com>
 468
 469         * arc-tdep.c: Remove ".." from include.
 470         * frv-tdep.c: Remove ".." from include.
 471         * lm32-tdep.c: Remove ".." from include.
 472         * microblaze-tdep.c: Remove ".." from include.
 473         * or1k-tdep.h: Remove ".." from include.
 474         * s12z-tdep.c: Remove ".." from include.
 475         * Makefile.in (OPCODES_CFLAGS): Add comment.
 476         (TOP_CFLAGS): New variable.
 477         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 478
 479 2019-10-23  Tom Tromey  <tom@tromey.com>
 480
 481         * Makefile.in (READLINE_DIR): Update.
 482
 483 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 484
 485         * infcall.c (call_function_by_hand_dummy): Fix the function
 486         comment.  And extract out a code section into...
 487         (reserve_stack_space): ...this new function.
 488
 489 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 490
 491         * infcall.c (value_arg_coerce): Remove an unused parameter.
 492         (call_function_by_hand_dummy): Update the call to
 493         'value_arg_coerce'.
 494
 495 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 496
 497         * infcall.c (call_function_by_hand_dummy): Refactor.
 498
 499 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 500
 501         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 502
 503 2019-10-23  Tom Tromey  <tom@tromey.com>
 504
 505         * configure: Rebuild.
 506         * configure.ac: Don't check for sigprocmask.
 507         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 508
 509 2019-10-23  Tom Tromey  <tom@tromey.com>
 510
 511         * configure: Rebuild.
 512         * acinclude.m4: Use m4_include, not sinclude.
 513
 514 2019-10-23  Tom de Vries  <tdevries@suse.de>
 515
 516         PR breakpoints/24687
 517         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 518
 519 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * symtab.c (struct demangled_name_entry) <language>: Change from
 522         bitfield to regular variable.
 523
 524 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 525
 526         * symtab.c (struct demangled_name_entry): Add a constructor.
 527         (free_demangled_name_entry): New function to call the destructor
 528         for demangled_name_entry.
 529         (create_demangled_names_hash): Pass free_demangled_name_entry to
 530         htab_create_alloc.
 531         (symbol_set_names): Call placement new for demangled_name_entry.
 532         * utils.c: No longer include xxhash.h here, now that fast_hash
 533         is inlined in the header.
 534         * utils.h: Instead, include it here.
 535
 536 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 537
 538         * Makefile.in: Link with libxxhash.
 539         * config.in: Regenerate.
 540         * configure: Regenerate.
 541         * configure.ac: Search for libxxhash.
 542         * utils.c (fast_hash): Use xxhash if present.
 543
 544 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 545
 546         * utils.h (fast_hash): New function.
 547         * symtab.c (hash_demangled_name_entry): Call new function
 548         fast_hash.
 549
 550 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 551
 552         * symtab.c (struct demangled_name_entry): Change type of mangled
 553         to gdb::string_view. Also adds a constructor that takes the
 554         mangled name.
 555         (hash_demangled_name_entry): Update.
 556         (eq_demangled_name_entry): Update.
 557         (free_demangled_name_entry): New function to call the destructor
 558         now that this is not a POD anymore.
 559         (create_demangled_names_hash): Pass free_demangled_name_entry to
 560         htab_create_alloc.
 561         (symbol_set_names): Update.
 562
 563 2019-10-21  Ali Tamur  <tamu@google.com>
 564
 565         * dwarf2read.c (dir_index): Change type.
 566         (file_name_index): Likewise.
 567         (line_header::include_dir_at): Change comment and implementation on
 568         whether it is DWARF 5.
 569         (line_header::is_valid_file_index): New function.
 570         (line_header::file_name_at): Change comment and implementation on
 571         whether it is DWARF 5.
 572         (line_header::file_names): Change to private field renamed as
 573         m_file_names and introduce a new accessor method.
 574         (line_header::file_names_size): New method.
 575         (line_header::include_dirs): Change to private field and rename as
 576         m_include_dirs.
 577         (dw2_get_file_names_reader): Define local var at a smaller scope and
 578         reflect API change.
 579         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 580         (process_structure_scope): Likewise.
 581         (line_header::add_include_dir): Change message and reflect renaming.
 582         (line_header::add_file_name): Likewise.
 583         (read_formatted_entries): Handle DW_FORM_data16.
 584         (dwarf_decode_line_header): Fix line header length calculation.
 585         (psymtab_include_file_name): Change comment and API.
 586         (lnp_state_machine::m_file): Update comment and reflect type change.
 587         (lnp_state_machine::record_line): Reflect type change.
 588         (dwarf_decode_lines): Reflect API change.
 589         (file_file_name): Likewise.
 590         (file_full_name): Likewise.
 591
 592 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 595
 596 2019-10-21  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 599
 600 2019-10-21  Tom Tromey  <tom@tromey.com>
 601
 602         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 603         NM_H.   Use AC_CONFIG_LINKS.
 604         * configure: Rebuild.
 605         * Makefile.in (NM_H): New variable.
 606         (generated_files): Add NM_H.  Remove gcore.
 607         (nm.h, stamp-nmh): New targets.
 608
 609 2019-10-20  Tom Tromey  <tom@tromey.com>
 610
 611         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 612         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 613         obsolete comment.
 614         (put_objfile_before): Now static.
 615
 616 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 617
 618         * gdbsupport/common-utils.h (startswith): Change return type to
 619         bool.
 620
 621 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 622
 623         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 624         * breakpoint.c (bp_locations_compare): Rename to...
 625         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 626         (update_global_location_list): Use std::sort instead of qsort.
 627         * buildsym.c (compare_line_numbers): Rename to...
 628         (lte_is_less_than): ...this, and change to std::sort semantics.
 629         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 630         instead of qsort.
 631         * disasm.c (compare_lines): Rename to...
 632         (line_is_less_than): ...this, and change to std::sort semantics.
 633         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 634         of qsort.
 635         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 636         (fde_is_less_than): ...this, and change to std::sort semantics.
 637         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 638         * mdebugread.c (compare_blocks):
 639         (block_is_less_than): ...this, and change to std::sort semantics.
 640         (sort_blocks): Call std::sort instead of qsort.
 641         * objfiles.c (qsort_cmp): Rename to...
 642         (sort_cmp): ...this, and change to std::sort semantics.
 643         (update_section_map): Call std::sort instead of qsort.
 644         * remote.c (compare_pnums): Remove.
 645         (map_regcache_remote_table): Call std::sort instead of qsort.
 646         * utils.c (compare_positive_ints): Remove.
 647         * utils.h (compare_positive_ints): Remove.
 648         * xcoffread.c (compare_lte): Remove.
 649         (arrange_linetable): Call std::sort instead of qsort.
 650
 651 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 652
 653         * symfile.c (init_entry_point_info): Fix typo.
 654         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 655
 656 2019-10-18  Tom de Vries  <tdevries@suse.de>
 657
 658         * aarch64-tdep.c: Fix typos in comments.
 659         * ada-lang.c: Same.
 660         * ada-tasks.c: Same.
 661         * alpha-tdep.c: Same.
 662         * alpha-tdep.h: Same.
 663         * amd64-nat.c: Same.
 664         * amd64-windows-tdep.c: Same.
 665         * arc-tdep.c: Same.
 666         * arc-tdep.h: Same.
 667         * arch-utils.c: Same.
 668         * arm-nbsd-tdep.c: Same.
 669         * arm-tdep.c: Same.
 670         * ax-gdb.c: Same.
 671         * blockframe.c: Same.
 672         * btrace.c: Same.
 673         * c-varobj.c: Same.
 674         * coff-pe-read.c: Same.
 675         * coffread.c: Same.
 676         * cris-tdep.c: Same.
 677         * darwin-nat.c: Same.
 678         * dbxread.c: Same.
 679         * dcache.c: Same.
 680         * disasm.c: Same.
 681         * dtrace-probe.c: Same.
 682         * dwarf-index-write.c: Same.
 683         * dwarf2-frame-tailcall.c: Same.
 684         * dwarf2-frame.c: Same.
 685         * dwarf2read.c: Same.
 686         * eval.c: Same.
 687         * exceptions.c: Same.
 688         * fbsd-tdep.c: Same.
 689         * findvar.c: Same.
 690         * frame.c: Same.
 691         * frv-tdep.c: Same.
 692         * gnu-v3-abi.c: Same.
 693         * go32-nat.c: Same.
 694         * h8300-tdep.c: Same.
 695         * hppa-tdep.c: Same.
 696         * i386-linux-tdep.c: Same.
 697         * i386-tdep.c: Same.
 698         * ia64-libunwind-tdep.c: Same.
 699         * ia64-tdep.c: Same.
 700         * infcmd.c: Same.
 701         * infrun.c: Same.
 702         * linespec.c: Same.
 703         * linux-nat.c: Same.
 704         * linux-thread-db.c: Same.
 705         * machoread.c: Same.
 706         * mdebugread.c: Same.
 707         * mep-tdep.c: Same.
 708         * mn10300-tdep.c: Same.
 709         * namespace.c: Same.
 710         * objfiles.c: Same.
 711         * opencl-lang.c: Same.
 712         * or1k-tdep.c: Same.
 713         * osabi.c: Same.
 714         * ppc-linux-nat.c: Same.
 715         * ppc-linux-tdep.c: Same.
 716         * ppc-sysv-tdep.c: Same.
 717         * printcmd.c: Same.
 718         * procfs.c: Same.
 719         * record-btrace.c: Same.
 720         * record-full.c: Same.
 721         * remote-fileio.c: Same.
 722         * remote.c: Same.
 723         * rs6000-tdep.c: Same.
 724         * s12z-tdep.c: Same.
 725         * score-tdep.c: Same.
 726         * ser-base.c: Same.
 727         * ser-go32.c: Same.
 728         * skip.c: Same.
 729         * sol-thread.c: Same.
 730         * solib-svr4.c: Same.
 731         * solib.c: Same.
 732         * source.c: Same.
 733         * sparc-nat.c: Same.
 734         * sparc-sol2-tdep.c: Same.
 735         * sparc-tdep.c: Same.
 736         * sparc64-tdep.c: Same.
 737         * stabsread.c: Same.
 738         * stack.c: Same.
 739         * symfile.c: Same.
 740         * symtab.c: Same.
 741         * target-descriptions.c: Same.
 742         * target-float.c: Same.
 743         * thread.c: Same.
 744         * utils.c: Same.
 745         * valops.c: Same.
 746         * valprint.c: Same.
 747         * value.c: Same.
 748         * varobj.c: Same.
 749         * windows-nat.c: Same.
 750         * xcoffread.c: Same.
 751         * xstormy16-tdep.c: Same.
 752         * xtensa-tdep.c: Same.
 753
 754 2019-10-17  Tom Tromey  <tromey@adacore.com>
 755
 756         * configure: Rebuild.
 757         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 758         in AC_CONFIG_FILES invocation.
 759         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 760         new-style config.status invocation.
 761
 762 2019-10-17  Tom de Vries  <tdevries@suse.de>
 763
 764         * arm-nbsd-nat.c: Fix typos in comments.
 765         * arm-tdep.c: Same.
 766         * darwin-nat-info.c: Same.
 767         * dwarf2read.c: Same.
 768         * elfread.c: Same.
 769         * event-top.c: Same.
 770         * findvar.c: Same.
 771         * gdbtypes.c: Same.
 772         * hppa-tdep.c: Same.
 773         * i386-tdep.c: Same.
 774         * jit.c: Same.
 775         * main.c: Same.
 776         * mdebugread.c: Same.
 777         * moxie-tdep.c: Same.
 778         * nto-procfs.c: Same.
 779         * osabi.c: Same.
 780         * ppc-linux-tdep.c: Same.
 781         * remote.c: Same.
 782         * riscv-tdep.c: Same.
 783         * s390-tdep.c: Same.
 784         * sh-tdep.c: Same.
 785         * sparc-linux-tdep.c: Same.
 786         * sparc-nat.c: Same.
 787         * stack.c: Same.
 788         * target-descriptions.c: Same.
 789         * top.c: Same.
 790         * varobj.c: Same.
 791
 792 2019-10-16  Tom Tromey  <tom@tromey.com>
 793
 794         * objfiles.h (struct objfile) <original_name>: Now const.
 795
 796 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 799         pass on to sigsetjmp's second argument.
 800         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 801
 802 2019-10-16  Keith Seitz  <keiths@redhat.com>
 803
 804         PR gdb/23567
 805         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 806         sections whose size is greater than the file size.
 807
 808 2019-10-16  Jim Wilson  <jimw@sifive.com>
 809
 810         * riscv-tdep.c (riscv_gcc_target_options): New.
 811         (riscv_gnu_triplet_regexp): New.
 812         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 813         set_gdbarch_gnu_triplet_regexp.
 814
 815 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 816
 817         * Makefile.in: Add xml-builtin.h.
 818         * features/feature_to_c.sh: Add an include for xml-builtin.h
 819         to ensure that the compiler checks that the types match.
 820         * xml-builtin.h: New file.
 821         * xml-support.c (fetch_xml_builtin): Add missing const.
 822         * xml-support.h: Remove declaration of xml_builtins.
 823
 824 2019-10-16  Tom de Vries  <tdevries@suse.de>
 825
 826         PR tdep/25096
 827         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 828         (amd64_classify_aggregate): ... here.
 829         (amd64_classify_aggregate_field): Handled fiels of nested structs
 830         recursively.
 831
 832 2019-10-16  Tom de Vries  <tdevries@suse.de>
 833
 834         PR tdep/24104
 835         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 836         that handles 'theclass'.
 837
 838 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * linespec.c (decode_digits_ordinary): Update comment.
 841         * make-target-delegates: No longer need to handle VEC case.
 842         * memrange.c (normalize_mem_ranges): Update comment.
 843         * namespace.c (add_using_directive): Update comment.
 844         * objc-lang.c (uniquify_strings): Update comment.
 845         * ppc-linux-nat.c (struct thread_points): Update comment.
 846         * probe.h (find_probes_in_objfile): Update comment.
 847         * target.h (enum flash_preserve_mode): Update comment.
 848         * varobj.c (varobj_restrict_range): Update comment.
 849         * varobj.h (varobj_list_children): Update comment.
 850
 851 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * Makefile.in: Remove references to vec.h and vec.c.
 854         * aarch64-tdep.c: No longer include vec.h.
 855         * ada-lang.c: Likewise.
 856         * ada-lang.h: Likewise.
 857         * arm-tdep.c: Likewise.
 858         * ax.h: Likewise.
 859         * breakpoint.h: Likewise.
 860         * charset.c: Likewise.
 861         * cp-support.h: Likewise.
 862         * dtrace-probe.c: Likewise.
 863         * dwarf2read.c: Likewise.
 864         * extension.h: Likewise.
 865         * gdb_bfd.c: Likewise.
 866         * gdbsupport/gdb_vecs.h: Likewise.
 867         * gdbsupport/vec.c: Remove.
 868         * gdbsupport/vec.h: Remove.
 869         * gdbthread.h: Likewise.
 870         * guile/scm-type.c: Likewise.
 871         * inline-frame.c: Likewise.
 872         * machoread.c: Likewise.
 873         * memattr.c: Likewise.
 874         * memrange.h: Likewise.
 875         * namespace.h: Likewise.
 876         * nat/linux-btrace.h: Likewise.
 877         * osdata.c: Likewise.
 878         * parser-defs.h: Likewise.
 879         * progspace.h: Likewise.
 880         * python/py-type.c: Likewise.
 881         * record-btrace.c: Likewise.
 882         * rust-exp.y: Likewise.
 883         * solib-target.c: Likewise.
 884         * stap-probe.c: Likewise.
 885         * target-descriptions.c: Likewise.
 886         * target-memory.c: Likewise.
 887         * target.h: Likewise.
 888         * varobj.c: Likewise.
 889         * varobj.h: Likewise.
 890         * xml-support.h: Likewise.
 891
 892 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 895         Update for new std::vector based implementation.
 896         (process_psymtab_comp_unit_reader): Likewise.
 897         (scan_partial_symbols): Likewise.
 898         (recursively_compute_inclusions): Likewise.
 899         (compute_compunit_symtab_includes): Likewise.
 900         (process_imported_unit_die): Likewise.
 901         (queue_and_load_dwo_tu): Likewise.
 902         (follow_die_sig_1): Likewise.
 903         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 904         (typedef dwarf2_per_cu_ptr): Remove.
 905         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 906         function.
 907         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 908         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 909         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 910         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 911         std::vector.
 912
 913 2019-10-15  Tom Tromey  <tromey@adacore.com>
 914
 915         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 916         TID.
 917
 918 2019-10-15  Tom Tromey  <tromey@adacore.com>
 919
 920         * windows-nat.c (windows_nat_target::fetch_registers)
 921         (windows_nat_target::store_registers): Rename "pid" to "tid".
 922
 923 2019-10-15  Tom Tromey  <tromey@adacore.com>
 924
 925         * gdbarch.h, gdbarch.c: Rebuild.
 926         * gdbarch.sh (gcc_target_options): Change return type to
 927         std::string.
 928         * compile/compile.c (get_args): Update.
 929         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 930         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 931         std::string.
 932         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 933         std::string.
 934         * arch-utils.c (default_gcc_target_options): Return std::string.
 935         * arch-utils.h (default_gcc_target_options): Return std::string.
 936         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 937
 938 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 939
 940         * breakpoint.c (breakpoint_chain): Make static.
 941         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 942         of accessing breakpoint_chain.
 943
 944 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 945
 946         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 947         to a gdb::function_view and return value to bool.
 948         * breakpoint.h (iterate_over_breakpoints): Likewise.
 949         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 950         (pop_dummy_frame): Update.
 951         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 952         (gdbscm_breakpoints): Update.
 953         * python/py-breakpoint.c (build_bp_list): Update.
 954         (gdbpy_breakpoints): Update.
 955         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 956         Update.
 957         (bpfinishpy_handle_stop): Update.
 958         (bpfinishpy_handle_exit): Update.
 959         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 960         (svr4_update_solib_event_breakpoints): Update.
 961
 962 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 963
 964         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 965         when unwrapping single-field structs.
 966
 967 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 968
 969         * dwarf2read.c: Remove includes.
 970
 971 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 972
 973         * ui-out.c (ui_out::call_do_message): Silence
 974         -Wformat-nonliteral warning.
 975
 976 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 977
 978         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 979         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 980         include: readline/tilde.h.
 981
 982 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 983
 984         * remote.c (remote_target::get_trace_status): Remove declaration of
 985         trace_regblock_size.
 986
 987 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 988
 989         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 990         (show_user): Remove declaration of cmdlist.
 991         * cli/cli-cmds.h (max_user_call_depth): Declare.
 992         * cli/cli-script.c (execute_user_command): Remove declaration
 993         of max_user_call_depth.
 994
 995 2019-10-11  Jim Wilson  <jimw@sifive.com>
 996
 997         * gdbsupport/print-utils.h (pulongest): Fix comment.
 998         (plongest): Likewise.
 999         (phex): Add missing comment, mention leading zeros.
1000         (phex_nz): Add mention of no leading zeros to comment.
1001
1002         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1003         plongest instead of unsigned long long cast.
1004
1005 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1008         for external_editor_command and gdbtk_test.
1009
1010 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1011
1012         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1013         * varobj.c (varobjdebug): Move comment to...
1014         * varobj.h (varobjdebug): ...here, and declare.
1015
1016 2019-10-09  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1019         erase_data_content.
1020
1021 2019-10-09  Tom Tromey  <tom@tromey.com>
1022
1023         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1024         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1025         * tui/tui-command.c (tui_cmd_window::resize)
1026         (tui_refresh_cmd_win): Update.
1027         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1028         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1029         * tui/tui-data.c (~tui_gen_win_info): Remove.
1030         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1031         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1032         (tui_redisplay_readline, tui_mld_flush)
1033         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1034         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1035         (tui_data_window::erase_data_content)
1036         (tui_data_item_window::rerender)
1037         (tui_data_item_window::refresh_window): Update.
1038         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1039         (box_win, tui_gen_win_info::make_window)
1040         (tui_gen_win_info::make_visible): Update.
1041         (tui_delete_win): Remove.
1042         * tui/tui-winsource.c
1043         (tui_source_window_base::do_erase_source_content): Update.
1044         (tui_show_source_line, tui_source_window_base::update_tab_width)
1045         (tui_source_window_base::update_exec_info): Update.
1046         * tui/tui-data.h (struct curses_deleter): New.
1047         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1048         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1049
1050 2019-10-09  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1053
1054 2019-10-09  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1057         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1058
1059 2019-10-09  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1062         window height directly.
1063         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1064         declare.
1065         * tui/tui-layout.c (tui_default_win_height): Remove.
1066         (tui_default_win_viewport_height): Remove.
1067
1068 2019-10-09  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui.h: Remove comments.
1071
1072 2019-10-09  Tom de Vries  <tdevries@suse.de>
1073
1074         * python/lib/gdb/printer/bound_registers.py: Use
1075         '^builtin_type_bound128' as regexp argument for
1076         add_builtin_pretty_printer.
1077
1078 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1079
1080         * guile/guile.c (guile_extension_script_ops): Remove forward
1081         declaration and mark as static.
1082         (guile_script_ops): Likewise.
1083         (extension_language_guile): Move further down in the file so
1084         it can reference the definitions for guile_{extension_,}script_ops.
1085
1086 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1087
1088         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1089         except SORTL, DFLTCC, and KDSA.
1090
1091 2019-10-08  Tom Tromey  <tromey@adacore.com>
1092
1093         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1094         (struct safe_symbol_file_add_args): Remove.
1095
1096 2019-10-08  Tom Tromey  <tromey@adacore.com>
1097
1098         * windows-nat.c: Don't include buildsym-legacy.h.
1099
1100 2019-10-08  Tom Tromey  <tromey@adacore.com>
1101
1102         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1103
1104 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1105
1106         * gdbtypes.c (overload_debug): Move comment to header.
1107         * gdbtypes.h (overload_debug): Declare.
1108         * valops.c: Remove declaration of overload_debug, instead
1109         include gdbtypes.h.
1110
1111 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1112
1113         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1114         through _().
1115         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1116         move comment...
1117         * language.h (lang_frame_mismatch_warn): ... here. Also add
1118         declaration.
1119         * top.c (lang_frame_mismatch_warn): Remove declaration.
1120         (check_frame_language_change): Pass lang_frame_mismatch_warn
1121         through _().
1122
1123 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1124
1125         * c-lang.h (vtbl_ptr_name): Declare.
1126         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1127         it from the header.
1128         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1129
1130 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1131
1132         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1133         gdb_static_assert.
1134
1135 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1136
1137         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1138         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1139         * ctfread.c: New file.
1140         * ctfread.h: New file.
1141         * elfread.c: Include ctfread.h.
1142         (struct elfinfo text_p): New member ctfsect.
1143         (elf_locate_sections): Mark CTF section.
1144         (elf_symfile_read): Call elfctf_build_psymtabs.
1145         * Makefile.in (LIBCTF): Add.
1146         (CLIBS): Use it.
1147         (CDEPS): Likewise.
1148         (DIST): Add ctfread.c.
1149
1150 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * ctfread.c (struct nextfield): Renamed to ...
1153         (struct ctf_nextfield): ... this.
1154         (struct field_info): Renamed to ...
1155         (strut ctf_field_info): ... this.
1156         (attach_fields_to_type): Update for renamed structures.
1157         (ctf_add_member_cb): Likewise.
1158         (ctf_add_enum_member_cb): Likewise.
1159         (process_struct_members): Likewise.
1160         (process_enum_type): Likewise.
1161
1162 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1163
1164         * tracectf.h: Rename, was ctf.h.
1165         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1166         * tracefile.c: Likewise.
1167         * tracepoint.c: Remove unused include ctf.h.
1168         * mi/mi-main.c: Likewise.
1169         * Makefile.in Replace ctf.c with tracectf.c.
1170
1171 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1172
1173         * version.in: Change version number to "9.0.50.DATE-git".
1174
1175 2019-10-03  Tom Tromey  <tom@tromey.com>
1176
1177         PR rust/24976:
1178         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1179
1180 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1183         cp_search_name_hash.
1184         * NEWS: Add entry about nested function support.
1185
1186 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1187             Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1190         for nested static variables when searchin VAR_DOMAIN.
1191         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1192         global scope, update comment.
1193         (add_partial_subprogram): Call add_partial_subprogram recursively
1194         for nested subroutines when processinng Fortran.
1195         (load_partial_dies): Process the child entities of a subprogram
1196         when processing Fortran.
1197         (partial_die_parent_scope): Handle building scope
1198         for Fortran nested functions.
1199         (process_die): Record that nested functions have a scope.
1200         (new_symbol): Always record Fortran subprograms on the global
1201         symbol list.
1202         (determine_prefix): How to build the prefix for Fortran
1203         subprograms.
1204
1205 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1208         have just sent the thread a SIGSTOP and are waiting for it to
1209         arrive.
1210
1211 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1212
1213         * btrace.c (btrace_add_pc): Remove whitespace before the template
1214         parameter in 'std::vector <...>'.
1215         (parse_xml_btrace_block): Likewise.
1216         (btrace_maint_decode_pt): Likewise.
1217         (btrace_maint_update_packets): Likewise.
1218         (btrace_maint_print_packets): Likewise.
1219         * btrace.h (struct btrace_maint_info): Likewise.
1220         * dwarf2read.c (struct type_unit_group): Likewise.
1221         (build_type_psymtabs_reader): Likewise.
1222         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1223         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1224         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1225
1226 2019-10-03  Tom de Vries  <tdevries@suse.de>
1227
1228         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1229         the first line of the help text for set/show style metadata.
1230
1231 2019-10-02  Tom Tromey  <tromey@adacore.com>
1232
1233         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1234         * gdbsupport/common-inferior.c: New file.
1235         * infcmd.c (startup_with_shell): Don't define.
1236         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1237         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1238         * inferior.h (startup_with_shell): Don't declare.
1239
1240 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1241
1242         * gdbsupport/gdb_assert.h: Include errors.h.
1243         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1244
1245 2019-10-02  Tom Tromey  <tromey@adacore.com>
1246
1247         * NEWS: Add $_ada_exception entry.
1248         * ada-lang.c (struct ada_catchpoint): Add constructor.
1249         <m_kind>: New member.
1250         (allocate_location_exception, re_set_exception): Remove
1251         "ex" parameter.
1252         (should_stop_exception): Compute $_ada_exception.
1253         (check_status_exception, print_it_exception)
1254         (print_one_exception, print_mention_exception): Remove
1255         "ex" parameter.
1256         (allocate_location_catch_exception, re_set_catch_exception)
1257         (check_status_exception, print_it_catch_exception)
1258         (print_one_catch_exception, print_mention_catch_exception)
1259         (print_recreate_catch_exception)
1260         (allocate_location_catch_exception_unhandled)
1261         (re_set_catch_exception_unhandled)
1262         (check_status_exception, print_it_catch_exception_unhandled)
1263         (print_one_catch_exception_unhandled)
1264         (print_mention_catch_exception_unhandled)
1265         (print_recreate_catch_exception_unhandled)
1266         (allocate_location_catch_assert, re_set_catch_assert)
1267         (check_status_assert, print_it_catch_assert)
1268         (print_one_catch_assert, print_mention_catch_assert)
1269         (print_recreate_catch_assert)
1270         (allocate_location_catch_handlers, re_set_catch_handlers)
1271         (check_status_handlers, print_it_catch_handlers)
1272         (print_one_catch_handlers, print_mention_catch_handlers)
1273         (print_recreate_catch_handlers): Remove.
1274         (create_ada_exception_catchpoint): Update.
1275         (initialize_ada_catchpoint_ops): Update.
1276
1277 2019-10-02  Tom Tromey  <tromey@adacore.com>
1278
1279         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1280         (create_excep_cond_exprs): Simplify exception string computation.
1281         (ada_exception_catchpoint_cond_string): Likewise.
1282
1283 2019-10-02  Tom Tromey  <tromey@adacore.com>
1284
1285         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1286         * ada-lang.c (lesseq_defined_than): Handle
1287         LOC_STATIC.
1288         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1289         parameter.
1290         (dwarf2_has_info): Likewise.
1291         (new_symbol): Set maybe_copied on symbol when
1292         appropriate.
1293         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1294         parameter.
1295         <can_copy>: New member.
1296         * elfread.c (record_minimal_symbol): Set maybe_copied
1297         on symbol when appropriate.
1298         (elf_symfile_read): Update call to dwarf2_has_info.
1299         * minsyms.c (lookup_minimal_symbol_linkage): New
1300         function.
1301         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1302         * symtab.c (get_symbol_address, get_msymbol_address):
1303         New functions.
1304         * symtab.h (get_symbol_address, get_msymbol_address):
1305         Declare.
1306         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1307         maybe_copied.
1308         (struct symbol, struct minimal_symbol) <maybe_copied>:
1309         New member.
1310
1311 2019-10-02  Tom Tromey  <tromey@adacore.com>
1312
1313         * source.c (struct current_source_location): New.
1314         (current_source_key): New global.
1315         (current_source_symtab, current_source_line)
1316         (current_source_pspace): Remove.
1317         (get_source_location): New function.
1318         (get_current_source_symtab_and_line)
1319         (set_default_source_symtab_and_line)
1320         (set_current_source_symtab_and_line)
1321         (clear_current_source_symtab_and_line, select_source_symtab)
1322         (info_source_command, print_source_lines_base)
1323         (info_line_command, search_command_helper, _initialize_source):
1324         Update.
1325
1326 2019-10-02  Tom Tromey  <tromey@adacore.com>
1327
1328         * source.c (select_source_symtab): Don't call
1329         decode_line_with_current_source.
1330
1331 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * symtab.c (lookup_global_symbol): Search global block.
1334
1335 2019-10-02  Tom Tromey  <tromey@adacore.com>
1336
1337         * coffread.c (process_coff_symbol): Update.
1338         * dwarf2read.c (var_decode_location, new_symbol): Update.
1339         * mdebugread.c (parse_symbol): Update.
1340         * objfiles.c (relocate_one_symbol): Update.
1341         * stabsread.c (define_symbol, fix_common_block)
1342         (scan_file_globals): Update.
1343         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1344         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1345         * xcoffread.c (process_xcoff_symbol): Update.
1346
1347 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1348
1349         * MAINTAINERS: Update my email address.
1350
1351 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1354         std::vector.
1355         (build_type_psymtabs_reader): Update for std::vector.
1356         (build_type_psymtab_dependencies): Likewise.
1357         * dwarf2read.h: Remove use of DEF_VEC_P.
1358         (typedef sig_type_ptr): Delete.
1359
1360 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1363         to std::vector.
1364         (btrace_maint_decode_pt): Likewise, and move allocation of the
1365         vector outside of the loop.
1366         (btrace_maint_update_packets): Update to handle change from VEC to
1367         std::vector.
1368         (btrace_maint_print_packets): Likewise.
1369         (maint_info_btrace_cmd): Likewise.
1370         * btrace.h: Remove use of DEF_VEC_O.
1371         (typedef btrace_pt_packet_s): Delete.
1372         (struct btrace_maint_info) <packets>: Change fromm VEC to
1373         std::vector.
1374         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1375
1376 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1379         make accesses into the vector constant references.
1380         (btrace_add_pc): Update for std::vector.
1381         (btrace_stitch_bts): Likewise.
1382         (parse_xml_btrace_block): Likewise.
1383         (btrace_maint_update_packets): Likewise.
1384         (btrace_maint_print_packets): Likewise.
1385         (maint_info_btrace_cmd): Likewise.
1386         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1387         std::vector.
1388         (btrace_data::empty): Likewise.
1389         (btrace_data_append): Likewise.
1390         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1391         (typedef btrace_block_s): Delete.
1392         (struct btrace_block): Add constructor.
1393         (struct btrace_data_bts) <blocks>: Change to std::vector.
1394         * nat/linux-btrace.c (perf_event_read_bts): Update for
1395         std::vector.
1396         (linux_read_bts): Likewise.
1397
1398 2019-10-01  Tom Tromey  <tom@tromey.com>
1399
1400         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1401
1402 2019-10-01  Tom Tromey  <tom@tromey.com>
1403
1404         * stack.c (print_frame, info_frame_command_core): Use
1405         styled_string.
1406         * linux-thread-db.c (try_thread_db_load_1)
1407         (try_thread_db_load_from_pdir_1): Use styled_string.
1408         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1409         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1410         (maybe_print_unsupported_script_warning)
1411         (maybe_print_script_not_found_warning): Use styled_string.
1412         * ada-lang.c (user_select_syms): Use styled_string.
1413
1414 2019-10-01  Tom Tromey  <tom@tromey.com>
1415
1416         * p-lang.c (pascal_printstr): Use metadata style.
1417         * value.c (show_convenience): Use metadata style.
1418         * valprint.c (valprint_check_validity, val_print_optimized_out)
1419         (val_print_not_saved, val_print_unavailable)
1420         (val_print_invalid_address, generic_val_print, val_print)
1421         (value_check_printable, val_print_array_elements): Use metadata
1422         style.
1423         * ui-out.h (class ui_out) <field_fmt>: New overload.
1424         <do_field_fmt>: Add style parameter.
1425         * ui-out.c (ui_out::field_fmt): New overload.
1426         * typeprint.c (type_print_unknown_return_type)
1427         (val_print_not_allocated, val_print_not_associated): Use metadata
1428         style.
1429         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1430         parameter.
1431         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1432         * tracepoint.c (tvariables_info_1): Use metadata style.
1433         * stack.c (print_frame_arg, print_frame_info, print_frame)
1434         (info_frame_command_core): Use metadata style.
1435         * skip.c (info_skip_command): Use metadata style.
1436         * rust-lang.c (rust_print_enum): Use metadata style.
1437         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1438         metadata style.
1439         * python/py-framefilter.c (py_print_single_arg): Use metadata
1440         style.
1441         * printcmd.c (do_one_display, print_variable_and_value): Use
1442         metadata style.
1443         * p-valprint.c (pascal_val_print)
1444         (pascal_object_print_value_fields): Use metadata style.
1445         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1446         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1447         parameter.
1448         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1449         * m2-valprint.c (m2_print_long_set): Use metadata style.
1450         * m2-typeprint.c (m2_print_type): Use metadata style.
1451         * infcmd.c (print_return_value_1): Use metadata style.
1452         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1453         * f-valprint.c (info_common_command_for_block): Use metadata
1454         style.
1455         * f-typeprint.c (f_type_print_base): Use metadata style.
1456         * expprint.c (print_subexp_standard): Use metadata style.
1457         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1458         * cli/cli-style.h (class cli_style_option): Add constructor.
1459         (metadata_style): Declare.
1460         * cli/cli-style.c (metadata_style): New global.
1461         (_initialize_cli_style): Register metadata style.
1462         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1463         parameter.
1464         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1465         * c-typeprint.c (c_type_print_base_struct_union)
1466         (c_type_print_base_1): Use metadata style.
1467         * breakpoint.c (watchpoint_value_print)
1468         (print_one_breakpoint_location): Use metadata style.
1469         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1470         style.
1471         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1472         style.
1473         * ada-valprint.c (val_print_packed_array_elements, printstr)
1474         (print_field_values, ada_val_print_ref, ada_val_print): Use
1475         metadata style.
1476         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1477         style.
1478         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1479         style.
1480         * ada-lang.c (user_select_syms): Use metadata style.
1481
1482 2019-10-01  Tom Tromey  <tom@tromey.com>
1483
1484         * cli/cli-cmds.c (pwd_command): Style output.
1485
1486 2019-10-01  Pedro Alves  <palves@redhat.com>
1487             Tom Tromey  <tom@tromey.com>
1488
1489         * symtab.c (print_symbol_info): Use %ps.
1490         (print_msymbol_info): Use %ps.
1491         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1492         * printcmd.c (print_variable_and_value): Use %ps.
1493         * macrocmd.c (show_pp_source_pos): Use %ps.
1494         * infrun.c (print_exited_reason): Use ui_out::message.
1495         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1496         (describe_other_breakpoints): Use ui_out::message and new
1497         formats.
1498         (say_where): Use new formats.
1499         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1500         and new formats.
1501
1502 2019-10-01  Pedro Alves  <palves@redhat.com>
1503             Tom Tromey  <tom@tromey.com>
1504
1505         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1506         (test_gdb_formats): New function.
1507         (run_tests): Call it.
1508         (test_format_specifier): Update.
1509         * utils.h (fputs_filtered): Update comment.
1510         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1511         (fputs_styled_unfiltered): Declare.
1512         * utils.c (fputs_styled_unfiltered): New function.
1513         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1514         (vfprintf_filtered): Update.
1515         (vfprintf_unfiltered, vprintf_filtered): Update.
1516         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1517         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1518         disallow_ui_out_field>: New constants.
1519         (enum class field_kind): New.
1520         (struct base_field_s, struct signed_field_s): New.
1521         (signed_field): New function.
1522         (struct string_field_s): New.
1523         (string_field): New function.
1524         (struct styled_string_s): New.
1525         (styled_string): New function.
1526         (class ui_out) <message>: Add comment.
1527         <vmessage, call_do_message>: New methods.
1528         <do_message>: Add style parameter.
1529         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1530         methods.
1531         (ui_out::message): Rewrite.
1532         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1533         parameter.
1534         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1535         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1536         gdb_extensions parameter.
1537         (class format_piece): Add parameter to constructor.
1538         (n_int_args): New field.
1539         * gdbsupport/format.c (format_pieces::format_pieces): Add
1540         gdb_extensions parameter.  Handle '*'.
1541         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1542         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1543         vfprintf_styled_no_gdbfmt.
1544         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1545         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1546         unfiltered output.
1547         * ui-style.h (struct ui_file_style) <ptr>: New method.
1548
1549 2019-10-01  Tom Tromey  <tom@tromey.com>
1550
1551         * unittests/format_pieces-selftests.c: Update.  Add final format.
1552         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1553         empty literal pieces.
1554
1555 2019-10-01  Tom Tromey  <tom@tromey.com>
1556
1557         * ui-out.h (enum class ui_out_style_kind): Remove.
1558         (class ui_out) <field_string, field_stsream, do_field_string>:
1559         Change type of "style".
1560         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1561         (ui_out::field_string): Update.
1562         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1563         of "style".
1564         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1565         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1566         * stack.c (print_frame_arg, print_frame_info, print_frame):
1567         Update.
1568         * source.c (print_source_lines_base): Update.
1569         * solib.c (info_sharedlibrary_command): Update.
1570         * skip.c (info_skip_command): Update.
1571         * record-btrace.c (btrace_call_history_src_line)
1572         (btrace_call_history): Update.
1573         * python/py-framefilter.c (py_print_frame): Update.
1574         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1575         "style".
1576         * mi/mi-out.c (mi_ui_out::do_table_header)
1577         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1578         (mi_ui_out::do_field_string): Update.
1579         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1580         Update.
1581         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1582         "style".
1583         * cli-out.c (cli_ui_out::do_table_header)
1584         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1585         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1586         (cli_ui_out::do_field_fmt): Update.
1587         * breakpoint.c (print_breakpoint_location): Update.
1588         (update_static_tracepoint): Update.
1589
1590 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1591
1592         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1593         conversion of gdb_datadir.
1594         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1595         remove not needed c_str ().
1596
1597 2019-09-30  Ali Tamur <tamur@google.com>
1598
1599         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1600         (dwarf2_string_attr): Likewise.
1601
1602 2019-09-30  Ali Tamur <tamur@google.com>
1603
1604         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1605         (process_full_type_unit): Likewise.
1606         (dump_die_shallow): Likewise.
1607         (cu_debug_loc_section): Likewise.
1608
1609 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1610
1611         * minsyms.c (compare_minimal_symbols): Rename to...
1612         (minimal_symbol_is_less_than): ...this, and adjust to STL
1613         conventions (return bool, take arguments as references)
1614         (minimal_symbol_reader::install): Call std::sort instead
1615         of qsort.
1616
1617 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1618
1619         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1620         hash and why.
1621         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1622         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1623
1624 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1625
1626         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1627         * psympriv.h (add_psymbol_to_list): Move comment here and update
1628         it.
1629
1630 2019-09-29  Tom de Vries  <tdevries@suse.de>
1631
1632         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1633         Use $tmpdir/$(basename "$output_file").dwz instead of
1634         "${output_file}.dwz".
1635
1636 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1637
1638         PR gdb/25045
1639         * hppa-linux-nat.c: Include gdbarch.h.
1640
1641 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1642
1643         * blockframe.c (find_pc_partial_function): Change return type to bool.
1644         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1645         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1646         (stub_gnu_ifunc_resolve_name): Likewise.
1647         * symtab.c (compare_filenames_for_search): Likewise.
1648         (compare_glob_filenames_for_search): Likewise.
1649         (matching_obj_sections): Likewise.
1650         (symbol_matches_domain): Likewise.
1651         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1652         (find_line_pc): Change return type to bool.
1653         (find_line_pc_range): Likewise.
1654         (producer_is_realview): Likewise.
1655         * symtab.h (symbol_matches_domain): Likewise.
1656         (find_pc_partial_function): Likewise.
1657         (find_pc_line_pc_range): Likewise.
1658         (in_gnu_ifunc_stub): Likewise.
1659         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1660         (find_line_pc): Likewise.
1661         (find_line_pc_range): Likewise.
1662         (matching_obj_sections): Likewise.
1663         (find_line_symtab): Change out parameter to bool.
1664         (producer_is_realview): Change return type to bool.
1665         (compare_filenames_for_search): Likewise.
1666         (compare_glob_filenames_for_search): Likewise.
1667
1668 2019-09-26  Tom Tromey  <tom@tromey.com>
1669
1670         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1671         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1672         * gdb_usleep.h: Remove.
1673         * gdb_usleep.c: Remove.
1674         * utils.c: Don't include gdb_usleep.h.
1675
1676 2019-09-26  Tom Tromey  <tromey@adacore.com>
1677
1678         * python/py-type.c (type_to_type_object): Call check_typedef
1679         for stub types.
1680
1681 2019-09-26  Tom Tromey  <tom@tromey.com>
1682
1683         * utils.h (initialize_utils): Don't declare.
1684         * top.c (gdb_init): Don't call initialize_utils.
1685         * utils.c (initialize_utils): Remove.  Move contents...
1686         (_initialize_utils): ... here.
1687
1688 2019-09-25  Tom Tromey  <tom@tromey.com>
1689
1690         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1691         * utils.h (make_hex_string): Don't declare.
1692         * utils.c (make_hex_string): Remove.
1693
1694 2019-09-24  Tom de Vries  <tdevries@suse.de>
1695
1696         PR gdb/23815
1697         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1698         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1699
1700 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1701
1702         * NEWS: Mention new simulator port for PRU.
1703
1704 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1705
1706         * ada-exp.y (write_object_remaining): Update.
1707         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1708         and eliminate the static buffer.
1709         (ada_decode_symbol): Update.
1710         (ada_la_decode): Update.
1711         (ada_sniff_from_mangled_name): Update.
1712         (is_valid_name_for_wild_match): Update.
1713         (ada_lookup_name_info::matches): Update and simplify.
1714         (name_matches_regex): Update.
1715         (ada_add_global_exceptions): Update.
1716         * ada-lang.h (ada_decode): Update signature.
1717         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1718         * dwarf-index-write.c (debug_names::insert): Update.
1719
1720 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1721
1722         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1723         formatting.
1724
1725 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1726
1727         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1728         Change "nonzero" to "true" in documentation.
1729
1730 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1731
1732         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1733         (_initialize_darwin_solib): Don't set
1734         darwin_so_ops.lookup_lib_global_symbol.
1735         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1736         set_gdbarch_iterate_over_objfiles_in_search_order.
1737         (elf_lookup_lib_symbol): Rename to...
1738         (svr4_iterate_over_objfiles_in_search_order): this, and update
1739         to iterate semantics.
1740         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1741         * solib.c (solib_global_lookup): Remove.
1742         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1743         (solib_global_lookup): Remove.
1744         * symtab.c (lookup_global_or_static_symbol): Remove call to
1745         solib_global_lookup.
1746
1747 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1748
1749         * NEWS: Move entries about default MI version now being
1750         version 3, and about the GDB/MI fix for multi-location
1751         breakpoints to the "since GDB 8.3" section.
1752
1753 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1754
1755         GDB 8.3.1 released.
1756
1757 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1758
1759         * NEWS: Mention that Cell/B.E. debugging support was removed.
1760         * MAINTAINERS: Remove spu target.
1761
1762         * config/djgpp/fnchange.lst: Remove entries for removed files.
1763
1764         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1765         spu-multiarch.o, and spu-tdep.o.
1766         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1767         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1768         spu-multiarch.c, and spu-tdep.c.
1769         * spu-linux-nat.c: Remove file.
1770         * spu-multiarch.c: Remove file.
1771         * spu-tdep.c: Remove file.
1772         * spu-tdep.h: Remove file.
1773         * solib-spu.c: Remove file.
1774         * solib-spu.h: Remove file.
1775
1776         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1777         * configure.nat (spu-linux): Remove.
1778         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1779         solib-multiarch.o from gdb_target_obs.
1780         (spu*-*-*): Remove.
1781
1782         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1783         feature flag.
1784         (ppc_linux_no_features): Update.
1785         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1786         Cell/B.E. support.
1787         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1788         (tdesc_powerpc_cell64l): Likewise.
1789         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1790         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1791         Cell/B.E. support.
1792         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1793         Do not include "features/rs6000/powerpc-cell32l.c" or
1794         "features/rs6000/powerpc-cell64l.c".
1795         (ppc_linux_spu_section): Remove.
1796         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1797         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1798         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1799         (ppc_linux_spe_context_lookup): Remove.
1800         (ppc_linux_spe_context_inferior_created): Remove.
1801         (ppc_linux_spe_context_solib_loaded): Remove.
1802         (ppc_linux_spe_context_solib_unloaded): Remove.
1803         (ppc_linux_spe_context): Remove.
1804         (struct ppu2spu_cache): Remove.
1805         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1806         (struct ppu2spu_data): Remove.
1807         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1808         ppu2spu_unwind): Remove.
1809         (ppc_linux_init_abi): Remove Cell/B.E. support.
1810         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1811
1812         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1813         (rs6000/powerpc-cell64l-expedite): Likewise
1814         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1815         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1816         rs6000/powerpc-cell64l.xml.
1817         * features/rs6000/powerpc-cell32l.xml: Remove.
1818         * features/rs6000/powerpc-cell64l.xml: Likewise.
1819         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1820         * features/rs6000/powerpc-cell64l.c: Likewise.
1821         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1822         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1823         * regformats/reg-spu.dat: Remove.
1824
1825         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1826         * corelow.c (struct spuid_list): Remove.
1827         (add_to_spuid_list): Remove.
1828         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1829         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1830         (remote_protocol_features): Remove associated entries.
1831         (_initialize_remote): No longer initialize them.
1832         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1833         * linux-nat.c (SPUFS_MAGIC): Remove.
1834         (linux_proc_xfer_spu): Remove.
1835         (spu_enumerate_spu_ids): Remove.
1836         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1837         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1838         (linux_make_corefile_notes): No longer call it.
1839
1840         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1841         (cooked_write_test): Likewise.
1842
1843 2019-09-20  Tom Tromey  <tom@tromey.com>
1844
1845         * NEWS: Mention case-sensitivity of TUI commands.
1846         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1847         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1848         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1849
1850 2019-09-20  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-source.c (tui_source_window::set_contents): Use
1853         make_unique_xstrdup.
1854         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1855         make_unique_xstrdup.
1856
1857 2019-09-20  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-data.c: Remove separator comments.
1860         * tui/tui-layout.c: Remove separator comments.
1861         * tui/tui-win.c: Remove separator comments.
1862         * tui/tui-wingeneral.c: Remove separator comments.
1863
1864 2019-09-20  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui.h (strcat_to_buf): Don't declare.
1867         * tui/tui.c (strcat_to_buf): Remove.
1868
1869 2019-09-20  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1872         from "fullname".
1873         * tui/tui-source.c (tui_source_window::set_contents)
1874         (tui_source_window::location_matches_p)
1875         (tui_source_window::maybe_update): Update.
1876
1877 2019-09-20  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1880         Update.
1881         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1882         prefix.
1883         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1884         (tui_data_window::line_from_reg_element_no)
1885         (tui_data_window::first_reg_element_no_inline)
1886         (tui_data_window::show_registers)
1887         (tui_data_window::show_register_group)
1888         (tui_data_window::display_registers_from)
1889         (tui_data_window::display_registers_from_line)
1890         (tui_data_window::first_data_item_displayed)
1891         (tui_data_window::delete_data_content_windows)
1892         (tui_data_window::erase_data_content)
1893         (tui_data_window::do_scroll_vertical)
1894         (tui_data_window::refresh_window)
1895         (tui_data_window::check_register_values): Update.
1896
1897 2019-09-20  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1900         (struct tui_locator_window) <full_name, proc_name>: Now
1901         std::string.
1902         * tui/tui-stack.c (tui_locator_window::make_status_line)
1903         (tui_locator_window::set_locator_fullname)
1904         (tui_locator_window::set_locator_info): Update.
1905         * tui/tui-source.c (tui_source_window::set_contents)
1906         (tui_source_window::showing_source_p): Update.
1907
1908 2019-09-20  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1911         Don't call tui_locator_win_info_ptr.
1912
1913 2019-09-20  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1916
1917 2019-09-20  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1920         height for locator.
1921         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1922         * tui/tui-layout.c (show_source_disasm_command, show_data)
1923         (show_source_or_disasm_and_command): Use 1 as height for locator.
1924
1925 2019-09-20  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui.c (tui_enable): Update.
1928         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1929         Update.
1930         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1931         Update.
1932         * tui/tui-data.c (win_resized): Now bool.
1933         (tui_win_resized): Return bool.
1934         (tui_set_win_resized_to): Accept a bool.
1935
1936 2019-09-20  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1939         Change type of "refresh_values_only".
1940         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1941         type of "refresh_values_only".
1942
1943 2019-09-20  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1946         std::string.
1947         (tui_disassemble): Add "pos" parameter.
1948         (tui_disasm_window::set_contents): Simplify.
1949
1950 2019-09-20  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-winsource.h (struct tui_source_window_base)
1953         <show_source_content>: Now private.
1954         * tui/tui-winsource.c
1955         (tui_source_window_base::show_source_content): Don't handle empty
1956         content case.
1957
1958 2019-09-20  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-layout.c (show_source_disasm_command)
1961         (show_source_or_disasm_and_command): Don't call
1962         show_source_content.
1963
1964 2019-09-20  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1967         Declare.
1968         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1969         from tui_make_status_line.
1970         (tui_locator_window::rerender): Update.
1971
1972 2019-09-20  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1975         (tui_locator_window::rerender): Update.
1976
1977 2019-09-20  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-winsource.h (struct tui_source_window_base)
1980         <~tui_source_window_base>: Don't declare.
1981         <fullname>: Remove.
1982         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1983         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1984         member.
1985         * tui/tui-source.c (tui_source_window::set_contents): Update.
1986         (tui_source_window::location_matches_p)
1987         (tui_source_window::maybe_update): Update.
1988
1989 2019-09-20  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-winsource.h (~tui_source_element): Remove.
1992         (tui_source_element): Update.
1993         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1994         * tui/tui-winsource.c (tui_show_source_line): Update.
1995         * tui/tui-source.c (tui_source_window::set_contents): Update.
1996         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1997
1998 2019-09-20  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2001         declare.
2002         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2003         tui_clear_source_windows_detail.
2004         * tui/tui-winsource.h (struct tui_source_window_base)
2005         <clear_detail>: Don't declare.
2006         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2007         Remove.
2008         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2009
2010 2019-09-20  Tom Tromey  <tromey@adacore.com>
2011
2012         PR ada/24919:
2013         * block.c (contained_in): Fix final return value.
2014
2015 2019-09-20  Alan Modra  <amodra@gmail.com>
2016
2017         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2018         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2019         (read_indirect_string_from_dwz): Use bfd accessor.
2020         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2021         * machoread.c (macho_symfile_read_all_oso): Likewise.
2022         * solib.c (solib_bfd_open): Likewise.
2023
2024 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2025
2026         * eval.c: Move declaration of overload_resolution to...
2027         * value.h: ...here.
2028
2029 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2030
2031         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2032         * arm-linux-tdep.c: Likewise.
2033         * arm-nbsd-nat.c: Likewise.
2034         * arm-tdep.h: Declare arm_apcs_32.
2035         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2036
2037 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2038
2039         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2040         * dwarf2read.h: Declare dwarf_always_disassemble.
2041
2042 2019-09-19  Tom de Vries  <tdevries@suse.de>
2043
2044         PR gdb/25009
2045         * source-cache.c (source_cache::ensure): Catch exception thrown during
2046         construction of the highlighter.
2047
2048 2019-09-18  Alan Modra  <amodra@gmail.com>
2049
2050         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2051         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2052         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2053         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2054         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2055         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2056         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2057         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2058         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2059         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2060         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2061         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2062         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2063         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2064         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2065         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2066         * mi/mi-interp.c: Update throughout for bfd section macro and
2067         function changes.
2068         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2069         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2070
2071 2019-09-18  Tom Tromey  <tom@tromey.com>
2072
2073         * NEWS: Add entry.
2074         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2075         call rl_initialize.
2076         (tui_enable): Do not call rl_initialize.
2077
2078 2019-09-18  Christian Groessler  <chris@groessler.org>
2079
2080         * alpha-linux-nat.c: Include gdbarch.h.
2081
2082 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2083
2084         * ui-file.c: Include cli/cli-style.h.
2085         (term_cli_styling): Remove cli_styling declaration.
2086
2087 2019-09-18  Alan Modra  <amodra@gmail.com>
2088
2089         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2090         to bfd_asymbol_section.
2091
2092 2019-09-18  Alan Modra  <amodra@gmail.com>
2093
2094         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2095         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2096         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2097
2098 2019-09-18  Alan Modra  <amodra@gmail.com>
2099
2100         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2101         * spu-linux-nat.c (spu_bfd_open): Likewise.
2102
2103 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2104
2105         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2106         to bool to match definition in dwarf2read.c.
2107
2108 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2109
2110         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2111         (print_signatures): Likewise.
2112         (trust_pad_over_xvs): Likewise.
2113         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2114         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2115         * arm-linux-nat.c (arm_apcs_32): Likewise.
2116         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2117         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2118         * arm-tdep.c (arm_debug): Likewise.
2119         (arm_apcs_32): Likewise.
2120         * auto-load.c (debug_auto_load): Likewise.
2121         (auto_load_gdb_scripts): Likewise.
2122         (global_auto_load): Likewise.
2123         (auto_load_local_gdbinit): Likewise.
2124         (auto_load_local_gdbinit_loaded): Likewise.
2125         * auto-load.h (global_auto_load): Likewise.
2126         (auto_load_local_gdbinit): Likewise.
2127         (auto_load_local_gdbinit_loaded): Likewise.
2128         * breakpoint.c (disconnected_dprintf): Likewise.
2129         (breakpoint_proceeded): Likewise.
2130         (automatic_hardware_breakpoints): Likewise.
2131         (always_inserted_mode): Likewise.
2132         (target_exact_watchpoints): Likewise.
2133         (_initialize_breakpoint): Update.
2134         * breakpoint.h (target_exact_watchpoints): Change to bool.
2135         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2136         * cli/cli-cmds.c (trace_commands): Likewise.
2137         * cli/cli-cmds.h (trace_commands): Likewise.
2138         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2139         to bool*.
2140         * cli/cli-logging.c (logging_overwrite): Change to bool.
2141         (logging_redirect): Likewise.
2142         (debug_redirect): Likewise.
2143         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2144         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2145         to bool.
2146         <boolean_option_def>: Update.
2147         (struct flag_option_def): Change default type of Context to bool
2148         from int.
2149         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2150         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2151         (get_setshow_command_value_string): Likewise.
2152         * cli/cli-style.c (cli_styling): Change to bool.
2153         (source_styling): Likewise.
2154         * cli/cli-style.h (source_styling): Likewise.
2155         (cli_styling): Likewise.
2156         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2157         to bool.
2158         * command.h (var_types): Update comment.
2159         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2160         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2161         bool.
2162         (debug_compile_cplus_scopes): Likewise.
2163         * compile/compile-internal.h (compile_debug): Likewise.
2164         * compile/compile.c (compile_debug): Likewise.
2165         (struct compile_options) <raw>: Likewise.
2166         * cp-support.c (catch_demangler_crashes): Likewise.
2167         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2168         (usr_cmd_cris_dwarf2_cfi): Likewise.
2169         * csky-tdep.c (csky_debug): Likewise.
2170         * darwin-nat.c (enable_mach_exceptions): Likewise.
2171         * dcache.c (dcache_enabled_p): Likewise.
2172         * defs.h (info_verbose): Likewise.
2173         * demangle.c (demangle): Likewise.
2174         (asm_demangle): Likewise.
2175         * dwarf-index-cache.c (debug_index_cache): Likewise.
2176         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2177         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2178         * dwarf2read.c (check_physname): Likewise.
2179         (use_deprecated_index_sections): Likewise.
2180         (dwarf_always_disassemble): Likewise.
2181         * eval.c (overload_resolution): Likewise.
2182         * event-top.c (set_editing_cmd_var): Likewise.
2183         (exec_done_display_p): Likewise.
2184         * event-top.h (set_editing_cmd_var): Likewise.
2185         (exec_done_display_p): Likewise.
2186         * exec.c (write_files): Likewise.
2187         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2188         (debug_fbsd_nat): Likewise.
2189         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2190         Likewise.
2191         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2192         <backtrace_past_entry> Likewise.
2193         * gdb-demangle.h (demangle): Likewise.
2194         (asm_demangle): Likewise.
2195         * gdb_bfd.c (bfd_sharing): Likewise.
2196         * gdbcore.h (write_files): Likewise.
2197         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2198         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2199         * gdbthread.h (print_thread_events): Likewise.
2200         * gdbtypes.c (opaque_type_resolution): Likewise.
2201         (strict_type_checking): Likewise.
2202         * gnu-nat.c (gnu_debug_flag): Likewise.
2203         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2204         * guile/scm-param.c (pascm_variable): Add boolval.
2205         (add_setshow_generic): Update.
2206         (pascm_param_value): Update.
2207         (pascm_set_param_value_x): Update.
2208         * hppa-tdep.c (hppa_debug): Change to bool..
2209         * infcall.c (may_call_functions_p): Likewise.
2210         (coerce_float_to_double_p): Likewise.
2211         (unwind_on_signal_p): Likewise.
2212         (unwind_on_terminating_exception_p): Likewise.
2213         * infcmd.c (startup_with_shell): Likewise.
2214         * inferior.c (print_inferior_events): Likewise.
2215         * inferior.h (startup_with_shell): Likewise.
2216         (print_inferior_events): Likewise.
2217         * infrun.c (step_stop_if_no_debug): Likewise.
2218         (detach_fork): Likewise.
2219         (debug_displaced): Likewise.
2220         (disable_randomization): Likewise.
2221         (non_stop): Likewise.
2222         (non_stop_1): Likewise.
2223         (observer_mode): Likewise.
2224         (observer_mode_1): Likewise.
2225         (set_observer_mode): Update.
2226         (sched_multi): Change to bool.
2227         * infrun.h (debug_displaced): Likewise.
2228         (sched_multi): Likewise.
2229         (step_stop_if_no_debug): Likewise.
2230         (non_stop): Likewise.
2231         (disable_randomization): Likewise.
2232         * linux-tdep.c (use_coredump_filter): Likewise.
2233         (dump_excluded_mappings): Likewise.
2234         * linux-thread-db.c (auto_load_thread_db): Likewise.
2235         (check_thread_db_on_load): Likewise.
2236         * main.c (captured_main_1): Update.
2237         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2238         xx2_opt, boolean_opt>: Change to bool.
2239         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2240         * maint.c (maintenance_profile_p): Likewise.
2241         (per_command_time): Likewise.
2242         (per_command_space): Likewise.
2243         (per_command_symtab): Likewise.
2244         * memattr.c (inaccessible_by_default): Likewise.
2245         * mi/mi-main.c (mi_async): Likewise.
2246         (mi_async_1): Likewise.
2247         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2248         * nat/fork-inferior.h (startup_with_shell): Likewise.
2249         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2250         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2251         * nios2-tdep.c (nios2_debug): Likewise.
2252         * or1k-tdep.c (or1k_debug): Likewise.
2253         * parse.c (parser_debug): Likewise.
2254         * parser-defs.h (parser_debug): Likewise.
2255         * printcmd.c (print_symbol_filename): Likewise.
2256         * proc-api.c (procfs_trace): Likewise.
2257         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2258         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2259         (set_parameter_value): Update.
2260         (add_setshow_generic): Update.
2261         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2262         to bool*.
2263         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2264         int*.
2265         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2266         * record-btrace.c (record_btrace_target::store_registers): Update.
2267         * record-full.c (record_full_memory_query): Change to bool.
2268         (record_full_stop_at_limit): Likewise.
2269         * record-full.h (record_full_memory_query): Likewise.
2270         * remote-notif.c (notif_debug): Likewise.
2271         * remote-notif.h (notif_debug): Likewise.
2272         * remote.c (use_range_stepping): Likewise.
2273         (interrupt_on_connect): Likewise.
2274         (remote_break): Likewise.
2275         * ser-tcp.c (tcp_auto_retry): Likewise.
2276         * ser-unix.c (serial_hwflow): Likewise.
2277         * skip.c (debug_skip): Likewise.
2278         * solib-aix.c (solib_aix_debug): Likewise.
2279         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2280         (spu_auto_flush_cache_p): Likewise.
2281         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2282         Likewise.
2283         (struct info_print_options) <quiet>: Likewise.
2284         * symfile-debug.c (debug_symfile): Likewise.
2285         * symfile.c (auto_solib_add): Likewise.
2286         (separate_debug_file_debug): Likewise.
2287         * symfile.h (auto_solib_add): Likewise.
2288         (separate_debug_file_debug): Likewise.
2289         * symtab.c (basenames_may_differ): Likewise.
2290         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2291         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2292         (struct info_types_options) <quiet>: Likewise.
2293         * symtab.h (demangle): Likewise.
2294         (basenames_may_differ): Likewise.
2295         * target-dcache.c (stack_cache_enabled_1): Likewise.
2296         (code_cache_enabled_1): Likewise.
2297         * target.c (trust_readonly): Likewise.
2298         (may_write_registers): Likewise.
2299         (may_write_memory): Likewise.
2300         (may_insert_breakpoints): Likewise.
2301         (may_insert_tracepoints): Likewise.
2302         (may_insert_fast_tracepoints): Likewise.
2303         (may_stop): Likewise.
2304         (auto_connect_native_target): Likewise.
2305         (target_stop_and_wait): Update.
2306         (target_async_permitted): Change to bool.
2307         (target_async_permitted_1): Likewise.
2308         (may_write_registers_1): Likewise.
2309         (may_write_memory_1): Likewise.
2310         (may_insert_breakpoints_1): Likewise.
2311         (may_insert_tracepoints_1): Likewise.
2312         (may_insert_fast_tracepoints_1): Likewise.
2313         (may_stop_1): Likewise.
2314         * target.h (target_async_permitted): Likewise.
2315         (may_write_registers): Likewise.
2316         (may_write_memory): Likewise.
2317         (may_insert_breakpoints): Likewise.
2318         (may_insert_tracepoints): Likewise.
2319         (may_insert_fast_tracepoints): Likewise.
2320         (may_stop): Likewise.
2321         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2322         (make_thread_apply_all_options_def_group): Change argument from int*
2323         to bool*.
2324         (thread_apply_all_command): Update.
2325         (print_thread_events): Change to bool.
2326         * top.c (confirm): Likewise.
2327         (command_editing_p): Likewise.
2328         (history_expansion_p): Likewise.
2329         (write_history_p): Likewise.
2330         (info_verbose): Likewise.
2331         * top.h (confirm): Likewise.
2332         (history_expansion_p): Likewise.
2333         * tracepoint.c (disconnected_tracing): Likewise.
2334         (circular_trace_buffer): Likewise.
2335         * typeprint.c (print_methods): Likewise.
2336         (print_typedefs): Likewise.
2337         * utils.c (debug_timestamp): Likewise.
2338         (sevenbit_strings): Likewise.
2339         (pagination_enabled): Likewise.
2340         * utils.h (sevenbit_strings): Likewise.
2341         (pagination_enabled): Likewise.
2342         * valops.c (overload_resolution): Likewise.
2343         * valprint.h (struct value_print_options) <prettyformat_arrays,
2344         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2345         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2346         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2347         Likewise.
2348         * windows-nat.c (new_console): Likewise.
2349         (cygwin_exceptions): Likewise.
2350         (new_group): Likewise.
2351         (debug_exec): Likewise.
2352         (debug_events): Likewise.
2353         (debug_memory): Likewise.
2354         (debug_exceptions): Likewise.
2355         (useshell): Likewise.
2356         * windows-tdep.c (maint_display_all_tib): Likewise.
2357         * xml-support.c (debug_xml): Likewise.
2358
2359 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2360
2361         * source.c (prepare_path_for_appending): New function.
2362         (openp): Make use of new function.
2363         (find_and_open_source): Search for the compilation directory and
2364         source file as a relative path beneath the directory search path.
2365
2366 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * source-cache.c (source_cache::get_line_charpos): Catch
2369         exceptions and return false, this matches the behaviour documented
2370         in the header file.
2371
2372 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2373
2374         * ada-tasks.c (info_task): Remove quoting of the task's name.
2375
2376 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2377
2378         * symfile.c (auto_solib_add): Replace comment with a reference
2379         to the header file.
2380
2381 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2382
2383         * NEWS: Mention that gdb can now be compiled with Python 3
2384         on Windows.
2385
2386 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * maint.c (maint_print_section_data::maint_print_section_data):
2389         Force use of 'float log10 (float)' by casting the argument to
2390         float.
2391
2392 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2393
2394         * maint.c: Add 'cmath' include.
2395         (struct maint_print_section_data): New structure.
2396         (print_section_index): New function.
2397         (print_bfd_section_info): Add header comment, small whitespace
2398         cleanup, and update to call new print_section_index function.
2399         (print_objfile_section_info): Likewise.
2400         (maint_obj_section_from_bfd_section): New function.
2401         (print_bfd_section_info_maybe_relocated): New function.
2402         (maintenance_info_sections): Add header comment, always use
2403         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2404
2405 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2406
2407         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2408         inner scope, add check that the objfile has psymtabs before
2409         checking psymtabs_addrmap.
2410         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2411
2412 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2413
2414         * NEWS: Announce that Ada task names are now shown at more places,
2415         and between quotes (except in info task output).
2416         * gdb/ada-tasks.c (task_to_str): New function.
2417         (display_current_task_id): Call task_to_str.
2418         (task_command_1): Likewise.
2419         (print_ada_task_info): In non-mi mode, Properly align headers and data
2420         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2421
2422 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2423
2424         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2425         prstatus.pr_lwp.pr_info instead of making it up.
2426
2427 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2428
2429         * auto-load.c (auto_load_expand_dir_vars): Update.
2430         * defs.h (gdb_datadir): Change to std::string.
2431         (python_libdir): Likewise.
2432         (relocate_gdb_directory): Change return type to std::string.
2433         * guile/guile.c (gdbscm_data_directory): Update.
2434         (initialize_scheme_side): Update.
2435         * jit.c (jit_reader_dir): Change to std::string.
2436         (jit_reader_load_command): Update.
2437         * main.c (gdb_datadir): Change to std::string.
2438         (python_libdir): Likewise.
2439         (set_gdb_data_directory): Update.
2440         (relocate_path): Change to return std::string.
2441         (relocate_gdb_directory): Change to return std::string.
2442         (relocate_gdbinit_path_maybe_in_datadir): Update.
2443         (captured_main_1): Update.
2444         * python/python.c (do_start_initialization): Update.
2445         * top.c (show_gdb_datadir): Update.
2446         * xml-syscall.c (xml_init_syscalls_info): Update.
2447         (init_syscalls_info): Update.
2448
2449 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2450
2451         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2452         out of get_init_files.
2453         (get_init_files): Update.
2454
2455 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2456
2457         * main.c (get_init_files): Change to use std::string.
2458         (captured_main_1): Update.
2459         (print_gdb_help): Update.
2460
2461 2019-09-11  Ali Tamur  <tamur@google.com>
2462
2463         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2464         implementation.
2465
2466 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2467
2468         * dbxread.c (read_dbx_symtab): Update.
2469         * dwarf2read.c (load_partial_dies): Update.
2470         * mdebugread.c (parse_partial_symbols): Update.
2471         (handle_psymbol_enumerators): Update.
2472         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2473         * psymtab.c (add_psymbol_to_bcache): Likewise.
2474         (add_psymbol_to_list): Likewise.
2475         * symtab.c (symbol_set_names): Likewise.
2476         * symtab.h (symbol_set_names): Likewise.
2477         * xcoffread.c (scan_xcoff_symtab): Update.
2478
2479 2019-09-11  Tom Tromey  <tom@tromey.com>
2480
2481         * symfile-mem.c (symbol_file_add_from_memory): Use
2482         bfd_set_filename.
2483         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2484         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2485
2486 2019-09-10  Tom Tromey  <tromey@adacore.com>
2487
2488         * dwarf-index-write.c (write_psymbols): Extend error message.
2489         (debug_names::insert): Add Ada code.
2490         (debug_names::write_psymbols): Remove Ada check.
2491         (debug_names) <m_string_obstack>: New member.
2492         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2493         (gdb_index_symbol_name_matcher::matches): Remove.
2494         (mapped_index_base::find_name_components_bounds): Add "lang"
2495         parameter.
2496         (mapped_index_base::build_name_components): Also split names
2497         according to Ada syntax.
2498         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2499         type of "match_callback".
2500         (check_match, check_find_bounds_finds)
2501         (dw2_expand_symtabs_matching): Update.
2502         (dw2_debug_names_iterator): Add new constructor.
2503         (dw2_debug_names_map_matching_symbols): New function.
2504         (dw2_debug_names_expand_symtabs_matching): Update.
2505         (dwarf2_debug_names_functions): Use
2506         dw2_debug_names_map_matching_symbols.
2507
2508 2019-09-10  Tom Tromey  <tromey@adacore.com>
2509
2510         * dwarf2read.c (dw2_get_file_names_reader): Add the
2511         CU's file name to the results.
2512
2513 2019-09-10  Tom Tromey  <tromey@adacore.com>
2514
2515         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2516         map_matching_symbols.  Update.
2517         * dwarf2read.c (dw2_map_matching_symbols): Update.
2518         * psymtab.c (match_partial_symbol): Change type; update.
2519         (psym_map_matching_symbols): Likewise.
2520         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2521         type; update.
2522         * symfile.h (struct quick_symbol_functions)
2523         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2524         Remove "match".
2525
2526 2019-09-10  Tom Tromey  <tromey@adacore.com>
2527
2528         * psymtab.c (map_block): Remove.
2529         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2530         * symtab.c (iterate_over_symbols_terminated): New function.
2531         * symtab.c (iterate_over_symbols_terminated): Declare.
2532
2533 2019-09-10  Tom Tromey  <tromey@adacore.com>
2534
2535         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2536         * language.h (struct language_defn) <la_iterate_over_symbols>:
2537         Return bool.
2538         * symtab.c (iterate_over_symbols): Return bool.
2539         * symtab.h (iterate_over_symbols): Return bool.
2540
2541 2019-09-10  Tom Tromey  <tromey@adacore.com>
2542
2543         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2544         (add_nonlocal_symbols): Update.
2545         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2546         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2547         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2548         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2549         Change type of "callback".  Remove "data".
2550
2551
2552 2019-09-09  Ali Tamur  <tamur@google.com>
2553
2554         * dwarf2read.c (comp_unit_head): Update comment.
2555         (dwarf2_dwo_name): New function declaration.
2556         (dwarf_unit_type_name): New function declaration.
2557         (read_comp_unit_head): Add support for new compilation units,
2558         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2559         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2560         (currently named as "signature") in their header. Also clarify error
2561         messages.
2562         (lookup_dwo_id): New function. Returns the dwo id of the given
2563         compile unit.
2564         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2565         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2566         functions.
2567         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2568         (dwarf2_dwo_name): Get the dwo name if present.
2569         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2570         purposes.
2571
2572 2019-09-09  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2575
2576 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2577
2578         * python/python.c (do_start_initialization): Make progname_copy static,
2579         to avoid a leak report.
2580
2581 2019-09-08  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2584
2585 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2586
2587         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2588         Change type to gdb::optional<block_enum>.
2589         (dw2_symtab_iter_init): Change block_index parameter type
2590         to gdb::optional<block_enum>.
2591         (dw2_lookup_symbol): Change block_index parameter
2592         type to block_enum.c
2593         (dw2_debug_names_lookup_symbol): Likewise.
2594         * psymtab.c (psym_lookup_symbol): Likewise.
2595         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2596         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2597         Likewise.
2598
2599 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2600
2601         * defs.h (relocate_gdb_directory): Change int to bool in
2602         signature and rename flag to relocatable.
2603         * main.c (relocate_path): Likewise.
2604         (relocate_gdb_directory): Likewise.
2605
2606 2019-09-06  Alan Modra  <amodra@gmail.com>
2607
2608         * coffread.c (coff_symfile_read): Constify filename variable.
2609         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2610         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2611         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2612         * solib.c (reload_shared_libraries_1): Likewise.
2613         * symfile.c (reread_symbols): Likewise.
2614         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2615         * solib-darwin.c (darwin_bfd_open): Likewise.
2616         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2617
2618 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2621         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2622
2623 2019-09-03  Tom Tromey  <tromey@adacore.com>
2624
2625         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2626         types.
2627         (has_negatives): Unbias a range type bound.
2628         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2629         * gdbtypes.c (operator==): Handle new field.
2630         (create_range_type): Add "bias" parameter.
2631         (create_static_range_type, resolve_dynamic_range): Update.
2632         * gdbtypes.h (struct range_bounds) <bias>: New member.
2633         (create_range_type): Add bias parameter.
2634         * printcmd.c (print_scalar_formatted): Unbias range types.
2635         * value.c (unpack_long): Unbias range types.
2636         (pack_long): Bias range types.
2637
2638 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2639
2640         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2641         probe arguments.
2642
2643 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2644
2645         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2646         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2647         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2648         (compile_probe_arg): Likewise.
2649         * probe.h (get_argument_count): Likewise.
2650         * solib-svr4.c (solib_event_probe_action): Likewise.
2651         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2652
2653 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2654
2655         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2656         code to here...
2657         (svr4_create_solib_event_breakpoints): ...from here.
2658
2659 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2660
2661         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2662         suffix from warning message.
2663
2664 2019-08-30  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-winsource.h (struct tui_source_window_base)
2667         <refresh_all>: Don't declare.
2668         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2669         Remove.
2670         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2671         tui_show_locator_content.
2672         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2673         declare.
2674         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2675         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2676         declare.
2677
2678 2019-08-30  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2681
2682 2019-08-30  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2685         Remove unnecessary forward declarations.
2686
2687 2019-08-30  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2690         rerender.
2691         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2692         tui_show_locator_content.
2693
2694 2019-08-30  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2697         (tui_locator_window::rerender): Rewrite using body of previous
2698         tui_show_locator_content.
2699
2700 2019-08-30  Tom Tromey  <tom@tromey.com>
2701
2702         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2703         set_locator_fullname>: New methods.
2704         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2705         Rename from tui_set_locator_fullname.
2706         (tui_locator_window::set_locator_info): Rename from
2707         tui_set_locator_info.  Return bool.
2708         (tui_update_locator_fullname, tui_show_frame_info): Update.
2709
2710 2019-08-30  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2713
2714 2019-08-30  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2717         call touchwin.
2718
2719 2019-08-30  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-wingeneral.c (box_win): Assume win_info and
2722         win_info->handle cannot be NULL.
2723
2724 2019-08-30  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2727         refresh_window>: Declare.
2728         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2729         resize.
2730         (tui_data_item_window::rerender): Rename from
2731         tui_display_register.
2732         (tui_data_item_window::refresh_window): New method.
2733         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2734         no-op.
2735
2736 2019-08-30  Tom Tromey  <tom@tromey.com>
2737
2738         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2739         regs_column_count, current_group>: Move later.  Now private.
2740         <get_current_group>: New method.
2741         * tui/tui-regs.c (tui_reg_command): Update.
2742         * tui/tui-layout.c (tui_set_layout): Update.
2743
2744 2019-08-30  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2747         (tui_data_window::rerender): Don't call
2748         check_and_display_highlight_if_needed.
2749         (tui_data_window::refresh_all): Remove call to
2750         erase_data_content.
2751
2752 2019-08-30  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2755         (tui_data_window::display_registers_from)
2756         (tui_data_window::display_reg_element_at_line)
2757         (tui_data_window::display_registers_from_line): Remove checks of
2758         "empty".
2759
2760 2019-08-30  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2763         Don't declare.
2764         * tui/tui-regs.c (tui_data_window::show_registers): Call
2765         rerender.
2766         (tui_data_window::rerender): Rename from display_all_data.
2767         (tui_data_window::rerender): Remove old implementation.
2768
2769 2019-08-30  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2772         text.
2773         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2774
2775 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2776             Sergio Durigan Junior  <sergiodj@redhat.com>
2777
2778         PR win32/24284
2779         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2780
2781 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2784         when searching for types.
2785
2786 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2787
2788         * f-lang.c (f_language_defn): Use f_print_typedef.
2789         * f-lang.h (f_print_typedef): Declare.
2790         * f-typeprint.c (f_print_typedef): Define.
2791
2792 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2793
2794         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2795
2796 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * cli/cli-utils.c (info_print_options_defs): Delete.
2799         (make_info_print_options_def_group): Delete.
2800         (extract_info_print_options): Delete.
2801         (info_print_command_completer): Delete.
2802         (info_print_args_help): Add extra parameter, and optionally
2803         include text about -n flag.
2804         * cli/cli-utils.h (struct info_print_options): Delete.
2805         (extract_info_print_options): Delete declaration.
2806         (info_print_command_completer): Delete declaration.
2807         (info_print_args_help): Add extra parameter, extend header
2808         comment.
2809         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2810         search_symbols.
2811         * stack.c (struct info_print_options): New type.
2812         (info_print_options_defs): New file scoped variable.
2813         (make_info_print_options_def_group): New static function.
2814         (info_print_command_completer): New static function.
2815         (info_locals_command): Update to use new local functions.
2816         (info_args_command): Likewise.
2817         (_initialize_stack): Add extra parameter to calls to
2818         info_print_args_help.
2819         * symtab.c (search_symbols): Add extra parameter, use this to
2820         possibly excluse non-debug symbols.
2821         (symtab_symbol_info): Add extra parameter, which is passed on to
2822         search_symbols.
2823         (struct info_print_options): New type.
2824         (info_print_options_defs): New file scoped variable.
2825         (make_info_print_options_def_group): New static function.
2826         (info_print_command_completer): New static function.
2827         (info_variables_command): Update to use local functions, and pass
2828         extra parameter through to symtab_symbol_info.
2829         (info_functions_command): Likewise.
2830         (info_types_command): Pass additional argument through to
2831         symtab_symbol_info.
2832         (rbreak_command): Pass extra argument to search_symbols.
2833         (_initialize_symtab): Add extra arguments for calls to
2834         info_print_args_help, and update help text for 'info variables',
2835         'whereis', and 'info functions' commands.
2836         * symtab.h (search_symbols): Add extra argument to declaration.
2837         * NEWS: Mention new flags.
2838
2839 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2840
2841         * symtab.c (lookup_static_symbol): Call the new function (and move
2842         it down to be next to lookup_global_symbol).
2843         (struct global_sym_lookup_data): Add block_enum member and rename to...
2844         (struct global_or_static_sym_lookup_data): ...this.
2845         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2846         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2847         (lookup_symbol_global_or_static_iterator_cb): ...this.
2848         (lookup_global_or_static_symbol): New function.
2849         (lookup_global_symbol): Call new function.
2850
2851 2019-08-26  Tom de Vries  <tdevries@suse.de>
2852
2853         PR c++/24852
2854         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2855         when pc_probe.prob == NULL.
2856
2857 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2858
2859         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2860         variable symbol_linkage to symbol_linkage_.
2861
2862 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2863
2864         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2865         represent whether the symbol is static, dynamic, or we don't
2866         know.
2867
2868 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2869
2870         * gdb/rx-tdep.c (rx_register_names): New.
2871         (rx_register_name): Delete.
2872         (rx_psw_type): Delete.
2873         (rx_fpsw_type): Delete.
2874         (rx_register_type): Delete.
2875         (rx_gdbarch_init): Convert target-descriptions.
2876         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2877         * gdb/features/Makefile: Add rx.xml.
2878         * gdb/features/rx.xml: New.
2879         * gdb/features/rx.c: Generated.
2880         * gdb/NEWS: Mention target description support.
2881
2882 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2883
2884         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2885         *slot_ptr.
2886
2887 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2888
2889         * configure.ac: Don't check for 'dlfcn.h' (moved to
2890         gdbsupport/common.m4).
2891         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2892         'gdbsupport/'.
2893         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2894         * compile/compile-c-support.c: Include
2895         'gdbsupport/gdb-dlfcn.h'.
2896         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2897         * gdb-dlfcn.c: Move to...
2898         * gdbsupport/gdb-dlfcn.c: ... here.
2899         * gdb-dlfcn.h: Move to...
2900         * gdbsupport/gdb-dlfcn.h: ... here.
2901
2902 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2903
2904         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2905         the offset field signed.
2906
2907 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2908
2909         * python/lib/gdb/__init__.py (_execute_file): New function.
2910         * python/python.c (python_run_simple_file): Call gdb._execute_file
2911         on Windows.
2912
2913 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2914
2915         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2916         all uses as this was never set to anything but a zero value.
2917
2918 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2919
2920         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2921
2922 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2923
2924         * tui/tui-data.h (tui_gen_win_info): Add an =default
2925         move constructor, required by some GCC versions.
2926
2927 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2928
2929         * go32-nat.c (go32_sysinfo): Add hygon_p.
2930
2931 2019-08-20  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2934         line_from_reg_element_no, first_reg_element_no_inline,
2935         display_all_data, delete_data_content_windows,
2936         erase_data_content>: Now private.
2937
2938 2019-08-20  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2941         (tui_unhighlight_win, tui_highlight_win)
2942         (tui_win_info::make_window): Update.
2943         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2944
2945 2019-08-20  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2948         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2949         (MAX_PID_WIDTH): Move to tui-stack.c.
2950         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2951         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2952         (MAX_PID_WIDTH): Move from tui-data.h.
2953
2954 2019-08-20  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2957         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2958         (box_win): Update.
2959         (tui_gen_win_info::make_window): Rename from tui_make_window.
2960         (tui_win_info::make_window): New method.
2961         (tui_gen_win_info::make_visible): Update.
2962         * tui/tui-source.c (tui_source_window::set_contents): Update.
2963         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2964         (tui_data_window::display_registers_from): Update.
2965         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2966         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2967         Declare.
2968         <can_box>: Remove.
2969         <title>: Remove.
2970         (struct tui_win_info) <make_window>: Declare.
2971         <can_box>: Now virtual.
2972         <title>: New member.
2973         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2974         * tui/tui-command.c (tui_cmd_window::resize): Update.
2975
2976 2019-08-20  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2979         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2980         (tui_data_window::check_register_values): Update.
2981
2982 2019-08-20  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-regs.h (struct tui_data_window): Use
2985         DISABLE_COPY_AND_ASSIGN.
2986         <regs_content>: Change type, removing unique_ptr.
2987         <tui_data_window>: Add move constructor.
2988         * tui/tui-regs.c (tui_data_window::show_registers)
2989         (tui_data_window::show_register_group)
2990         (tui_data_window::display_registers_from)
2991         (tui_data_window::display_registers_from)
2992         (tui_data_window::first_data_item_displayed)
2993         (tui_data_window::delete_data_content_windows)
2994         (tui_data_window::rerender, tui_data_window::refresh_window)
2995         (tui_data_window::check_register_values): Update.
2996
2997 2019-08-20  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3000         show_register_group>: Declare.
3001         (tui_show_register_group): Don't declare.
3002         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3003         tui_show_registers.
3004         (tui_data_window::show_register_group): Rename from
3005         tui_show_register_group.
3006         (tui_data_window::check_register_values, tui_reg_command):
3007         Update.
3008         * tui/tui-layout.c (tui_set_layout): Update.
3009
3010 2019-08-20  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3013         Declare.
3014         (tui_check_register_values): Don't declare.
3015         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3016         from tui_check_register_values.
3017         * tui/tui-hooks.c (tui_register_changed): Update.
3018
3019 2019-08-20  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-regs.c (tui_reg_layout): Move later.
3022         (tui_show_registers): Don't enable TUI mode or change layout.
3023
3024 2019-08-20  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-regs.h (struct tui_data_item_window)
3027         <~tui_data_item_window>: Remove.
3028         <content>: Now a unique_xmalloc_ptr.
3029         * tui/tui-regs.c (tui_register_format): Return a
3030         unique_xmalloc_ptr.
3031         (tui_get_register): Update.
3032         (~tui_data_item_window): Remove.
3033         (tui_data_window::display_registers_from, tui_display_register):
3034         Update.
3035         * tui/tui-io.h (tui_expand_tabs): Update.
3036         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3037         Remove "col" parameter.
3038
3039 2019-08-20  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3042         field.
3043         * tui/tui-regs.c (~tui_data_item_window): Update.
3044
3045 2019-08-20  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3048         earlier.
3049
3050 2019-08-20  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3053
3054 2019-08-20  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-source.h (struct tui_source_window): Update.
3057         * tui/tui-regs.c (tui_show_registers): Update.
3058         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3059         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3060         (NO_REGS_STRING): Remove defines.
3061
3062 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3063
3064         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3065         unnecessary thread walk if remote doesn't support the packet.
3066
3067 2019-08-19  Tom Tromey  <tromey@adacore.com>
3068
3069         * python/py-value.c (value_has_field): Fix indentation.
3070
3071 2019-08-19  Tom Tromey  <tromey@adacore.com>
3072
3073         * printcmd.c (do_one_display, info_display_command): Update.
3074         * block.h (contained_in): Return bool.  Add allow_nested
3075         parameter.
3076         * block.c (contained_in): Return bool.  Add allow_nested
3077         parameter.
3078
3079 2019-08-19  Tom Tromey  <tom@tromey.com>
3080
3081         * configure: Rebuild.
3082         * configure.ac: Disallow the combination of -static-libstdc++ and
3083         source highlight.
3084         * source-cache.c (get_language_name): Handle rust.
3085         (source_cache::get_source_lines): Ignore highlighting exceptions.
3086
3087 2019-08-16  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3090         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3091         (struct tui_source_window_base) <make_visible, refresh_window,
3092         resize>: Remove methods.
3093         <execution_info>: Remove field.
3094         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3095         (tui_show_source_line, tui_source_window_base)
3096         (~tui_source_window_base): Update.
3097         (tui_source_window_base::resize)
3098         (tui_source_window_base::make_visible)
3099         (tui_source_window_base::refresh_window): Remove.
3100         (tui_source_window_base::update_exec_info): Update.
3101         * tui/tui-source.c (tui_source_window::set_contents): Update.
3102         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3103
3104 2019-08-16  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3107         deprecated_query_hook.
3108
3109 2019-08-16  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3112         (tui_update_source_windows_with_line): Update.
3113         * tui/tui-source.h (struct tui_source_window)
3114         <show_symtab_source>: Declare.
3115         (tui_show_symtab_source): Don't declare.
3116         * tui/tui-source.c (tui_show_symtab_source): Rename from
3117         tui_show_symtab_source.
3118
3119 2019-08-16  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-winsource.h (struct tui_source_window_base)
3122         <set_contents>: Declare.
3123         * tui/tui-winsource.c
3124         (tui_source_window_base::update_source_window_as_is): Update.
3125         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3126         Declare.
3127         (tui_set_source_content): Don't declare.
3128         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3129         tui_set_source_content.
3130         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3131         Declare.
3132         (tui_set_disassem_content): Don't declare.
3133         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3134         tui_set_disassem_content.
3135
3136 2019-08-16  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-winsource.h (struct tui_source_window_base)
3139         <update_breakpoint_info>: Declare.
3140         (tui_update_breakpoint_info): Don't declare.
3141         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3142         (tui_update_all_breakpoint_info): Update.
3143         (tui_source_window_base::update_breakpoint_info): Rename from
3144         tui_update_breakpoint_info.
3145         (tui_source_window_base::update_exec_info): Update.
3146
3147 2019-08-16  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-winsource.h (struct tui_source_window_base)
3150         <update_source_window>: Declare.
3151         (tui_update_source_window): Don't declare.
3152         * tui/tui-winsource.c
3153         (tui_source_window_base::update_source_window): Rename from
3154         tui_update_source_window.
3155         (tui_source_window_base::rerender): Update.
3156         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3157         * tui/tui-disasm.c (tui_show_disassem)
3158         (tui_show_disassem_and_update_source)
3159         (tui_disasm_window::maybe_update): Update.
3160
3161 2019-08-16  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-winsource.h (struct tui_source_window_base)
3164         <update_source_window_as_is>: Declare.
3165         (tui_update_source_window_as_is): Don't declare.
3166         * tui/tui-winsource.c (tui_update_source_window): Update
3167         (tui_source_window_base::update_source_window_as_is): Rename from
3168         tui_update_source_window_as_is.
3169         (tui_source_window_base::refill): Update.
3170         * tui/tui-source.c (tui_show_symtab_source): Update.
3171         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3172         Update.
3173
3174 2019-08-16  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-winsource.h (tui_update_source_window)
3177         (tui_update_source_window_as_is): Remove "noerror" parameter.
3178         * tui/tui-winsource.c (tui_update_source_window)
3179         (tui_update_source_window_as_is): Remove "noerror" parameter.
3180         (tui_update_source_windows_with_addr)
3181         (tui_update_source_windows_with_line)
3182         (tui_source_window_base::rerender)
3183         (tui_source_window_base::refill): Update.
3184         * tui/tui-source.h (tui_set_source_content)
3185         (tui_show_symtab_source): Remove "noerror" parameter.
3186         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3187         parameter.
3188         (tui_show_symtab_source): Likewise.
3189         (tui_source_window::maybe_update): Update.
3190         * tui/tui-disasm.c (tui_show_disassem)
3191         (tui_show_disassem_and_update_source)
3192         (tui_disasm_window::do_scroll_vertical)
3193         (tui_disasm_window::maybe_update): Update.
3194
3195 2019-08-16  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui.c (tui_is_window_visible): Update.
3198         * tui/tui-wingeneral.c (tui_make_window)
3199         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3200         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3201         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3202         (tui_set_win_height_command, parse_scrolling_args): Update.
3203         * tui/tui-source.c (tui_source_window::style_changed): Update.
3204         * tui/tui-regs.c (tui_show_registers)
3205         (tui_data_window::first_data_item_displayed)
3206         (tui_data_window::delete_data_content_windows)
3207         (tui_check_register_values, tui_reg_command): Update.
3208         * tui/tui-disasm.c (tui_show_disassem): Update.
3209         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3210         method.
3211         <is_visible>: Remove field.
3212         * tui/tui-data.c (tui_next_win, tui_prev_win)
3213         (tui_delete_invisible_windows): Update.
3214
3215 2019-08-16  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.h (struct tui_source_window_base)
3218         <m_has_locator>: Remove.
3219         * tui/tui-layout.c (show_source_disasm_command, show_data)
3220         (show_source_or_disasm_and_command): Update.
3221
3222 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3223
3224         * NEWS (Other MI changes): New subsection.
3225         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3226         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3227         * arch-utils.c (default_get_pc_address_flags): New function.
3228         * arch-utils.h (default_get_pc_address_flags): New declaration.
3229         * gdbarch.sh: Add get_pc_address_flags.
3230         * gdbarch.c: Regenerate.
3231         * gdbarch.h: Likewise.
3232         * stack.c (print_pc): New function.
3233         (print_frame_info) (print_frame): Call print_pc.
3234
3235 2019-08-16  Tom de Vries  <tdevries@suse.de>
3236
3237         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3238         print_objfile_section_info.
3239
3240 2019-08-15  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3243         calling update_cmdwin_start_line.
3244         * tui/tui-winsource.h (struct tui_source_window_base)
3245         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3246         <rerender>: Declare.
3247         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3248         Call rerender.
3249         (tui_source_window_base::set_new_height): Remove.
3250         (tui_source_window_base::rerender): Rename from
3251         do_make_visible_with_new_height.
3252         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3253         resize method.
3254         (tui_win_info::make_invisible_and_set_new_height)
3255         (tui_win_info::make_visible_with_new_height): Remove.
3256         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3257         Declare.
3258         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3259         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3260         do_make_visible_with_new_height>: Don't declare.
3261         <rerender>: Declare.
3262         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3263         set_new_height.
3264         (tui_data_window::do_make_visible_with_new_height): Remove.
3265         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3266         call tui_show_locator_content.
3267         (tui_gen_win_info::resize): Call rerender.
3268         (show_source_or_disasm_and_command): Don't call
3269         tui_show_locator_content.
3270         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3271         method.
3272         (struct tui_win_info) <rerender>: Declare.
3273         <set_new_height, make_invisible_and_set_new_height,
3274         make_visible_with_new_height>: Don't declare.
3275         * tui/tui-data.c (tui_win_list::rerender): New method.
3276         * tui/tui-command.h (struct tui_cmd_window)
3277         <do_make_visible_with_new_height>: Don't declare.
3278         * tui/tui-command.c
3279         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3280
3281 2019-08-15  Tom Tromey  <tromey@adacore.com>
3282
3283         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3284         * ada-lang.c (ada_enum_name): Likewise.
3285
3286 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3287
3288         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3289         leading underscore.
3290         (GdbOutputErrorFile): Likewise.
3291         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3292         accordingly.
3293         (execute_unwinders): Rename to have a leading underscore.
3294         (auto_load_packages): Likewise.
3295         (global scope): Adjust call to auto_load_packages accordingly.
3296         (GdbSetPythonDirectory): Likewise.
3297         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3298         instead of execute_unwinders.
3299
3300 2019-08-15  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3303         (show_data): Don't change window visibility.
3304         (tui_gen_win_info::resize): Remove special case for command
3305         window.  Use wresize, when available.
3306         (show_source_or_disasm_and_command): Don't change window
3307         visibility.
3308         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3309         <make_visible>: New method.
3310         * tui/tui-command.c (tui_cmd_window::resize): New method.
3311
3312 2019-08-15  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3315         (struct tui_source_windows): New.
3316         * tui/tui-winsource.c (tui_display_main): Update.
3317         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3318         (new_height_ok, parse_scrolling_args): Update.
3319         * tui/tui-layout.c (show_layout, show_data): Update.
3320         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3321         (tui_add_to_source_windows): Don't declare.
3322         * tui/tui-data.c (source_windows, tui_source_windows)
3323         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3324
3325 2019-08-15  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3328         Rename from reset.
3329         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3330         * tui/tui-layout.c (show_source_disasm_command, show_data):
3331         Update.
3332         (tui_gen_win_info::resize): Rename.
3333         (show_source_or_disasm_and_command): Update.
3334         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3335         reset.
3336
3337 2019-08-15  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3340         * tui/tui-interp.c (tui_interp::init): Don't call
3341         tui_initialize_static_data.
3342         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3343
3344 2019-08-15  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3347         examine tui_win_list.
3348
3349 2019-08-15  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3352         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3353         tui_clear_source_content.
3354         (tui_clear_source_content): Remove.
3355         (tui_source_window_base::do_erase_source_content): Hoist call to
3356         content.clear().
3357         * tui/tui-stack.c (tui_show_frame_info): Don't call
3358         tui_clear_source_content.
3359
3360 2019-08-15  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-winsource.h (struct tui_source_window_base)
3363         <do_erase_source_content>: New method.
3364         <erase_source_content>: New method.
3365         (tui_erase_source_content): Don't declare.
3366         * tui/tui-winsource.c (tui_clear_source_content): Update.
3367         (tui_source_window_base::do_erase_source_content): Rename from
3368         tui_erase_source_content.
3369         (tui_source_window_base::show_source_content): Update.
3370         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3371         * tui/tui-source.h (struct tui_source_window)
3372         <erase_source_content>: New method.
3373         * tui/tui-disasm.h (struct tui_disasm_window)
3374         <erase_source_content>: New method.
3375
3376 2019-08-15  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3379         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3380         constructor.
3381         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3382         * tui/tui-source.c (tui_set_source_content): Update.
3383         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3384
3385 2019-08-15  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3388         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3389         tui-source.c.
3390         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3391         Declare.
3392         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3393         method.
3394         (tui_source_window::maybe_update): Update.
3395
3396 2019-08-15  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3399         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3400         tui-disasm.c.
3401         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3402         Declare.
3403         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3404         method.
3405         (tui_disasm_window::maybe_update): Update.
3406
3407 2019-08-15  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-winsource.h (struct tui_source_window_base)
3410         <maybe_update>: Declare.
3411         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3412         method.
3413         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3414         Declare.
3415         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3416         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3417         Declare.
3418         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3419
3420 2019-08-15  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3423
3424 2019-08-15  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-wingeneral.c: Include tui-stack.h.
3427         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3428         (struct tui_locator_window): Move from tui-data.h.
3429         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3430         (tui_initialize_static_data): Move from tui-data.c.
3431         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3432         (struct tui_locator_window): Move to tui-stack.c.
3433         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3434         (tui_initialize_static_data): Move to tui-stack.c.
3435
3436 2019-08-15  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-layout.c (show_source_disasm_command)
3439         (show_source_or_disasm_and_command): Use make_visible method, not
3440         tui_make_window.
3441         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3442         Remove.
3443
3444 2019-08-15  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-wingeneral.h (tui_make_window): Update.
3447         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3448         parameter.
3449         (tui_gen_win_info::make_visible): Update.
3450         * tui/tui-regs.c (tui_data_window::display_registers_from):
3451         Update.
3452         * tui/tui-layout.c (show_source_disasm_command)
3453         (show_source_or_disasm_and_command): Update.
3454         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3455         (enum tui_box): Remove.
3456         (struct tui_win_info) <can_box>: New method.
3457         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3458         method.
3459
3460 2019-08-15  Tom de Vries  <tdevries@suse.de>
3461
3462         * linux-nat-trad.c: Include gdbarch.h.
3463
3464 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3465
3466         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3467         register sizes.
3468
3469 2019-08-14  Tom Tromey  <tromey@adacore.com>
3470
3471         * darwin-nat.c: Include gdbarch.h.
3472         * darwin-nat-info.c: Include gdbarch.h.
3473
3474 2019-08-13  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3477         Remove.
3478         * tui/tui-data.c (tui_initialize_static_data): Update.
3479
3480 2019-08-13  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-winsource.h (struct tui_exec_info_window)
3483         <~tui_exec_info_window, maybe_allocate_content, get_content,
3484         m_content>: Remove.
3485         (struct tui_source_window_base) <set_exec_info_content,
3486         show_exec_info_content>: Don't declare.
3487         * tui/tui-winsource.c
3488         (tui_exec_info_window::maybe_allocate_content): Remove.
3489         (tui_source_window_base::update_exec_info): Rename from
3490         set_exec_info_content.
3491         (tui_source_window_base::show_exec_info_content)
3492         (tui_source_window_base::update_exec_info): Remove.
3493
3494 2019-08-13  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3497         declare.
3498         * tui/tui-winsource.c (tui_update_source_window_as_is)
3499         (tui_update_source_windows_with_addr, tui_erase_source_content):
3500         Update.
3501         (tui_clear_exec_info_content): Remove.
3502
3503 2019-08-13  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3506         declare.
3507         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3508         call tui_erase_exec_info_content.
3509         (tui_clear_exec_info_content): Rename from
3510         tui_erase_exec_info_content.
3511         (tui_clear_exec_info_content): Delete.
3512
3513 2019-08-13  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-winsource.h (struct tui_source_window_base)
3516         <show_exec_info_content>: Declare.
3517         (tui_show_exec_info_content): Don't declare.
3518         * tui/tui-winsource.c
3519         (tui_source_window_base::show_exec_info_content): Rename from
3520         tui_show_exec_info_content.
3521         (tui_source_window_base::update_exec_info): Update.
3522
3523 2019-08-13  Tom Tromey  <tom@tromey.com>
3524
3525         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3526         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3527         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3528         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3529         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3530         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3531         ... here.
3532
3533 2019-08-13  Tom Tromey  <tom@tromey.com>
3534
3535         * tui/tui-winsource.h (struct tui_source_window_base)
3536         <update_exec_info>: Declare.
3537         (tui_update_exec_info): Don't declare.
3538         * tui/tui-winsource.c (tui_update_source_window_as_is)
3539         (tui_source_window_base::refresh_all)
3540         (tui_update_all_breakpoint_info): Update.
3541         (tui_source_window_base::update_exec_info): Rename from
3542         tui_update_exec_info.
3543         * tui/tui-stack.c (tui_show_frame_info): Update.
3544
3545 2019-08-13  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-winsource.h (struct tui_source_window_base)
3548         <set_exec_info_content>: Declare.
3549         (tui_set_exec_info_content): Don't declare.
3550         * tui/tui-winsource.c
3551         (tui_source_window_base::set_exec_info_content): Rename from
3552         tui_set_exec_info_content.
3553         (tui_update_exec_info): Update.
3554
3555 2019-08-13  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-winsource.h (struct tui_source_window_base)
3558         <show_source_content>: Declare.
3559         (tui_show_source_content): Don't declare.
3560         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3561         (tui_source_window_base::show_source_content): Rename from
3562         tui_show_source_content.
3563         (tui_source_window_base::refresh_all): Update.
3564         * tui/tui-layout.c (show_source_disasm_command)
3565         (show_source_or_disasm_and_command): Update.
3566
3567 2019-08-13  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-winsource.c (tui_erase_source_content)
3570         (tui_show_source_content, tui_source_window_base::refresh_all):
3571         Update.
3572         * tui/tui-wingeneral.h
3573         (tui_check_and_display_highlight_if_needed): Don't declare.
3574         * tui/tui-wingeneral.c
3575         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3576         check_and_display_highlight_if_needed.
3577         * tui/tui-win.c (tui_rehighlight_all)
3578         (tui_win_info::make_visible_with_new_height): Update.
3579         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3580         (tui_data_window::erase_data_content)
3581         (tui_data_window::display_all_data): Update.
3582         * tui/tui-data.h (struct tui_win_info)
3583         <check_and_display_highlight_if_needed>: Declare.
3584
3585 2019-08-13  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-win.c (tui_resize_all): Call
3588         tui_delete_invisible_windows.
3589         * tui/tui-layout.c (show_layout): Call
3590         tui_delete_invisible_windows.
3591         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3592         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3593
3594 2019-08-13  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3597         tui_add_win_to_layout.
3598
3599 2019-08-13  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3602         * tui/tui-layout.c (tui_default_win_height): Now static.
3603
3604 2019-08-13  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3607         single switch.
3608         (show_source_disasm_command, show_source_or_disasm_and_command):
3609         Don't check current layout.
3610
3611 2019-08-13  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-wingeneral.c (make_all_visible): Remove.
3614         (tui_make_all_invisible): Simplify.
3615         * tui/tui-layout.c (tui_make_all_invisible): Move from
3616         tui-wingeneral.c; simplify.
3617         (show_layout): Hoist call to tui_make_all_invisible.
3618         (show_data): Don't call tui_make_all_invisible.
3619
3620 2019-08-13  Tom Tromey  <tom@tromey.com>
3621
3622         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3623         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3624
3625 2019-08-13  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3628         tui-data.c.
3629         (show_source_disasm_command, show_data)
3630         (show_source_or_disasm_and_command): Don't use
3631         tui_set_current_layout_to.
3632         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3633         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3634         tui-layout.c.
3635         (tui_set_current_layout_to): Remove.
3636
3637 2019-08-13  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-layout.c (tui_set_layout): Update.
3640         * tui/tui-data.h (struct tui_layout_def): Remove.
3641         (tui_layout_def): Don't declare.
3642         * tui/tui-data.c (layout_def): Remove.
3643         (tui_layout_def): Remove.
3644
3645 2019-08-13  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-winsource.h (struct tui_source_window_base)
3648         <clear_detail>: No longer "override".
3649         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3650         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3651         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3652         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3653         Remove.
3654         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3655
3656 2019-08-13  Tom Tromey  <tromey@adacore.com>
3657
3658         * tracepoint.c: Don't include readline.h or history.h.
3659
3660 2019-08-12  Tom Tromey  <tom@tromey.com>
3661
3662         * configure: Rebuild.
3663         * configure.ac: Check for readline 7.
3664         * NEWS: Mention readline 7 requirement.
3665         * README: Update.
3666
3667 2019-08-12  Tom Tromey  <tom@tromey.com>
3668
3669         * mingw-hdep.c (gdb_select): Remove readline hack.
3670
3671 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3672
3673         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3674         when the function fails.
3675
3676 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3677
3678         * s390-tdep.c (s390_type_align): New function.
3679         (s390_gdbarch_init): Set it as type_align gdbarch method.
3680
3681 2019-08-09  Tom de Vries  <tdevries@suse.de>
3682
3683         PR gdb/24591
3684         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3685         pc_low with relocation offset.
3686
3687 2019-08-07  Tom Tromey  <tromey@adacore.com>
3688
3689         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3690         (print_frame_args): Update.
3691         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3692         Update.
3693         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3694         * frame.h (struct frame_arg): Add initializers.
3695         <error>: Now a unique_xmalloc_ptr.
3696
3697 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3698
3699         * NEWS: Expand the Pointer Authentication entry.
3700         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3701         (aarch64_frame_unmask_lr): ... to this.
3702         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3703         Call aarch64_frame_unmask_lr.
3704         * frame.c (struct frame_info): Add "masked" variable.
3705         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3706         (fprint_frame): Check for masked pc.
3707         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3708         declarations.
3709         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3710         * stack.c (print_frame): Check for masked pc.
3711
3712 2019-08-06  Tom Tromey  <tom@tromey.com>
3713
3714         * stabsread.c (patch_block_stabs, read_one_struct_field)
3715         (read_enum_type): Use obstack_strndup.
3716         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3717         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3718         * dwarf2read.c (guess_full_die_structure_name)
3719         (anonymous_struct_prefix): Use obstack_strndup.
3720         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3721         * c-exp.y (yylex): Use obstack_strndup.
3722         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3723         (write_var_or_type): Use obstack_strndup.
3724
3725 2019-08-06  Tom Tromey  <tom@tromey.com>
3726
3727         * symfile.c (reread_symbols): Use obstack_strdup.
3728         * stabsread.c (read_type): Use obstack_strdup.
3729         * gdb_obstack.h (obstack_strdup): New overload.
3730         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3731         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3732         (dwarf2_canonicalize_name): Use obstack_strdup.
3733         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3734         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3735         Use obstack_strdup.
3736
3737 2019-08-06  Tom Tromey  <tom@tromey.com>
3738
3739         * gdb_obstack.h (obstack_strdup): Define.
3740         * gdb_obstack.c (obstack_strdup): Don't define.
3741
3742 2019-08-06  Tom Tromey  <tom@tromey.com>
3743
3744         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3745         obstack_strdup.
3746         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3747         obstack_strdup.
3748         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3749         * stabsread.c (common_block_start): Use obstack_strdup.
3750         * objfiles.c (set_objfile_main_name, objfile): Use
3751         obstack_strdup.
3752         * namespace.c (add_using_directive): Use obstack_strdup.
3753         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3754         * jit.c (finalize_symtab): Use obstack_strdup.
3755         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3756         (guess_partial_die_structure_name, partial_die_info::fixup)
3757         (dwarf2_name): Use obstack_strdup.
3758         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3759         obstack_strdup.
3760         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3761         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3762         obstack_strdup.
3763         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3764
3765 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3766
3767         * unittests/help-doc-selftests.c: New file.
3768         * Makefile.in: Add the new file.
3769
3770 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3771
3772         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3773         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3774         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3775         the trailing '.' is not output, and the first character is uppercased.
3776         (print_help_for_command): Update call to print_doc_line.
3777         (print_doc_of_command): Likewise.
3778         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3779         * cli/cli-option.c (append_indented_doc): Do not append newline.
3780         (build_help_option): Append newline after first appended_indented_doc
3781         only if a second call is done.
3782         (build_help): Append 2 new lines before each option, except the first
3783         one.
3784         * compile/compile.c (_initialize_compile): Add new lines after
3785         %OPTIONS%, when not at the end of the help.
3786         Change help doc or code
3787         producing the help doc to respect the invariants.
3788         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3789         Also removed the new line after 'Options:', as all other commands
3790         do not put an empty line between 'Options:' and the first option.
3791         * printcmd.c (_initialize_printcmd): Likewise.
3792         * stack.c (_initialize_stack): Likewise.
3793         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3794         incorrectly telling COMMAND is optional.
3795         * ada-lang.c (_initialize_ada_language): Change help doc or code
3796         producing the help doc to respect the invariants.
3797         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3798         * breakpoint.c (_initialize_breakpoint): Likewise.
3799         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3800         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3801         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3802         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3803         _initialize_cli_style): Likewise.
3804         * corelow.c (core_target_info): Likewise.
3805         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3806         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3807         * filesystem.c (_initialize_filesystem): Likewise.
3808         * frame.c (_initialize_frame): Likewise.
3809         * gnu-nat.c (add_task_commands): Likewise.
3810         * infcall.c (_initialize_infcall): Likewise.
3811         * infcmd.c (_initialize_infcmd): Likewise.
3812         * interps.c (_initialize_interpreter): Likewise.
3813         * language.c (_initialize_language): Likewise.
3814         * linux-fork.c (_initialize_linux_fork): Likewise.
3815         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3816         * maint.c (_initialize_maint_cmds): Likewise.
3817         * memattr.c (_initialize_mem): Likewise.
3818         * printcmd.c (_initialize_printcmd): Likewise.
3819         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3820         _RegEx): Likewise.
3821         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3822         * record-btrace.c (_initialize_record_btrace): Likewise.
3823         * record-full.c (_initialize_record_full): Likewise.
3824         * record.c (_initialize_record): Likewise.
3825         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3826         * regcache.c (_initialize_regcache): Likewise.
3827         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3828         _initialize_remote): Likewise.
3829         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3830         * serial.c (_initialize_serial): Likewise.
3831         * skip.c (_initialize_step_skip): Likewise.
3832         * source.c (_initialize_source): Likewise.
3833         * stack.c (_initialize_stack): Likewise.
3834         * symfile.c (_initialize_symfile): Likewise.
3835         * symtab.c (_initialize_symtab): Likewise.
3836         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3837         * top.c (init_main): Likewise.
3838         * tracefile-tfile.c (tfile_target_info): Likewise.
3839         * tracepoint.c (_initialize_tracepoint): Likewise.
3840         * tui/tui-win.c (_initialize_tui_win): Likewise.
3841         * utils.c (add_internal_problem_command): Likewise.
3842         * valprint.c (value_print_option_defs): Likewise.
3843
3844 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3845
3846         PR build/24886
3847         * configure.ac: Drop enable-libmcheck support.
3848         * configure, config.in: Rebuild.
3849         * libmcheck.m4: Remove.
3850         * acinclude.m4: Don't include it.
3851         * Makefile.in: Don't distribute it.
3852         * top.c (print_gdb_configuration): Don't mention it.
3853
3854 2019-08-06  Tom Tromey  <tom@tromey.com>
3855
3856         * utils.c (set_output_style): Sometimes pass stream to
3857         emit_style_escape.
3858         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3859         * record-btrace.c (btrace_insn_history): Update.
3860         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3861         method.
3862         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3863         Update initializers.
3864         <m_uiout>: New field.
3865         <m_di>: Move lower.
3866         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3867         Remove "uiout" parameter.
3868         (dump_insns): Update.
3869         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3870         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3871
3872 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3873
3874         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3875         (error_in_psymtab_expansion): Likewise.
3876         (lookup_symbol_via_quick_fns): Likewise.
3877         (basic_lookup_transparent_type_quick): Likewise.
3878         (basic_lookup_transparent_type_1): Likewise.
3879
3880 2019-08-06  Tom Tromey  <tromey@adacore.com>
3881
3882         * source.c (last_source_error): Now bool.
3883         (print_source_lines_base): Make "noprint" bool.  Only open
3884         source file when last_source_visited changes.
3885
3886 2019-08-06  Tom Tromey  <tromey@adacore.com>
3887
3888         * annotate.c (annotate_source_line): Use g_source_cache.
3889         * source-cache.c (source_cache::get_plain_source_lines): Change
3890         parameters.  Populate m_offset_cache.
3891         (source_cache::ensure): New method.
3892         (source_cache::get_line_charpos): New method.
3893         (extract_lines): Move lower.  Change parameters.
3894         (source_cache::get_source_lines): Move lower.
3895         * source-cache.h (class source_cache): Update comment.
3896         <get_line_charpos>: New method.
3897         <get_source_lines>: Update comment.
3898         <clear>: Clear m_offset_cache.
3899         <get_plain_source_lines>: Change parameters.
3900         <ensure>: New method
3901         <m_offset_cache>: New member.
3902         * source.c (forget_cached_source_info_for_objfile): Update.
3903         (info_source_command): Use g_source_cache.
3904         (find_source_lines, open_source_file_with_line_charpos): Remove.
3905         (print_source_lines_base, search_command_helper): Use g_source_cache.
3906         * source.h (open_source_file_with_line_charpos): Don't declare.
3907         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3908         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3909         Use g_source_cache.
3910
3911 2019-08-06  Tom Tromey  <tromey@adacore.com>
3912
3913         * source-cache.c (source_cache::get_plain_source_lines):
3914         Remove "first_line" and "last_line" parameters.
3915         (source_cache::get_source_lines): Cache plain text.
3916         * source-cache.h (class source_cache)
3917         <get_plain_source_lines>: Update.
3918
3919 2019-08-06  Tom Tromey  <tromey@adacore.com>
3920
3921         * source-cache.c (extract_lines): No longer a method.
3922         Changed type of parameter.  Include final newline.
3923         (selftests::extract_lines_test): New function.
3924         (_initialize_source_cache): Likewise.
3925         * source-cache.h (class source_cache)
3926         <extract_lines>: Don't declare.
3927
3928 2019-08-06  Tom Tromey  <tromey@adacore.com>
3929
3930         * breakpoint.c (init_breakpoint_sal): Update.
3931         (breakpoint): Update.
3932         * breakpoint.h (struct breakpoint) <filter>: Now a
3933         unique_xmalloc_ptr.
3934
3935 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3936
3937         * NEWS: Mention dictionary access on blocks.
3938         * python/py-block.c (blpy_getitem): New function.
3939         (block_object_as_mapping): New struct.
3940         (block_object_type): Use new struct for tp_as_mapping field.
3941
3942 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3943
3944         * objfiles.h (objfile): Add a comment describing partial symbols.
3945
3946 2019-08-05  Tom Tromey  <tromey@adacore.com>
3947
3948         * compile/compile.c (_initialize_compile): Use _(), not N_().
3949         * thread.c (_initialize_thread): Use _(), not N_().
3950         * stack.c (_initialize_stack): Use _(), not N_().
3951         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3952
3953 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3954
3955         * dwarf2read.c (struct dw2_symtab_iterator):
3956         <want_specific_block>: Remove.
3957         <block_index>: Change type to gdb::optional.
3958         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3959         change type of BLOCK_INDEX parameter to gdb::optional.
3960         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3961         (dw2_lookup_symbol): Don't pass argument for
3962         WANT_SPECIFIC_BLOCK.
3963         (dw2_expand_symtabs_for_function): Don't pass argument for
3964         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3965         (class dw2_debug_names_iterator)
3966         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3967         parameter, change BLOCK_INDEX type to gdb::optional.
3968         <m_want_specific_block>: Remove.
3969         <m_block_index>: Change type to gdb::optional.
3970         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3971         gdb::optional.  Re-write in function of gdb::optional.
3972         (dw2_debug_names_lookup_symbol): Don't pass argument for
3973         WANT_SPECIFIC_BLOCK.
3974         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3975         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3976         BLOCK_INDEX.
3977
3978 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * NEWS: Mention changes to "info sources" command.
3981
3982 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3983
3984         * symtab.c (filename_partial_match_opts): New struct type.
3985         (struct output_source_filename_data): New members
3986         regexp, c_regexp, partial_match.
3987         (output_source_filename): Use new members to decide to print file.
3988         (info_sources_option_defs): New variable.
3989         (make_info_sources_options_def_group, print_info_sources_header,
3990         info_sources_command_completer):
3991         New functions.
3992         (info_sources_command): Read new optional arguments.
3993         (_initialize_symtab): Update info sources help.
3994
3995 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3996
3997         * ada-lang.c (exception_support_info_v0): Renamed from...
3998         (default_exception_support_info): ... this.  Create new
3999         definition for v1.
4000         (ada_has_this_exception_support): Look up catch_handlers_sym.
4001         (ada_exception_support_info_sniffer): Try v0 after default.
4002
4003 2019-08-01  Tom Tromey  <tromey@adacore.com>
4004
4005         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4006         gdbarch.h.
4007
4008 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4009
4010         * s12z-tdep.c: Fix include path for s12z-opc.h.
4011
4012 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4013
4014         * NEWS: Require GNU make 3.82.
4015
4016 2019-07-16  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4019         declare.
4020
4021 2019-07-30  Tom Tromey  <tromey@adacore.com>
4022
4023         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4024
4025 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4026
4027         * printcmd.c (print_address_symbolic): Print negative offsets.
4028         (build_address_symbolic): Force signed arithmetic when computing
4029         offset.
4030
4031 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4032
4033         PR/24474: Add a function to lookup static variables.
4034         * NEWS: Mention this new function.
4035         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4036         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4037         * python/python.c (python_GdbMethods): Add new function.
4038
4039 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4040
4041         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4042         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4043         (objfpy_lookup_static_symbol): New function.
4044         (objfile_object_methods): Add new functions.
4045
4046 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4047
4048         * NEWS: Mention 'set|show print frame-info'.  Mention new
4049         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4050         backtrace argument.  Mention that python frame filtering code
4051         is now consistent with what 'backtrace' command prints.
4052
4053 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4054
4055         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4056         comments.
4057         (print_frame_info_auto, print_frame_info_source_line,
4058         print_frame_info_location, print_frame_info_source_and_location,
4059         print_frame_info_location_and_address, print_frame_info_short_location):
4060         New declarations.
4061         (struct frame_print_options): New member print_frame_info.
4062         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4063         * stack.h (get_user_print_what_frame_info): New declaration.
4064         (frame_show_address): New declaration.
4065         * stack.c (print_frame_arguments_choices): New value 'presence'.
4066         (print_frame_info_auto, print_frame_info_source_line,
4067         print_frame_info_location, print_frame_info_source_and_location,
4068         print_frame_info_location_and_address, print_frame_info_short_location,
4069         print_frame_info_choices, print_frame_info_print_what): New definitions.
4070         (print_frame_args): Only print dots for args if print frame-arguments
4071         is 'presence'.
4072         (frame_print_option_defs): New element for "frame-info".
4073         (get_user_print_what_frame_info): New function.
4074         (frame_show_address): Make non static.  Move comment to stack.h.
4075         (print_frame_info_to_print_what): New function.
4076         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4077         to decide what to print.
4078         (backtrace_command_1): Handle the new print_frame_arguments_presence
4079         value.
4080         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4081         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4082         (py_print_frame): In non-mi mode, use LOCATION as default for
4083         print_what, similarly to frame information printed directly by
4084         backtrace command. Handle frame-info user option in non MI mode.
4085
4086 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4087
4088         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4089         Add case for debugging 32-bit target on 64-bit host.  Revise
4090         comment.
4091
4092 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4093
4094         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4095         instead of find_function_entry_range_from_pc.
4096
4097 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4098
4099         * stack.c (find_frame_funname): Remove code which preferred
4100         minsym over symtab sym in "certain pathological cases".
4101
4102         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4103         parameter.  Change type of "do_demangle" to bool.
4104         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4105         Pass suitable "prefer_sym_over_minsym" flag to
4106         build_address_symbolic().  Don't output "+" for negative offsets.
4107         * printcmd.c (print_address_symbolic): Update invocation of
4108         build_address_symbolic to include a "prefer_sym_over_minsym"
4109         flag.
4110         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4111         Restrict cases in which use of minimal symbol is preferred to that
4112         of a found symbol.  Update comments.
4113
4114         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4115         for entry pc when entry pc is out of range for that FDE.
4116
4117 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4118
4119         PR gdb/24839:
4120         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4121         type.
4122
4123 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4124
4125         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4126         this function's Python signature.
4127
4128
4129 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4130
4131         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4132         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4133         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4134         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4135         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4136
4137
4138 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4139
4140         * h8300-tdep.c (h8300_register_name_common): New.
4141         h8300_register_name): Use h8300_register_name_common.
4142         (h8300s_register_name): Likewise.
4143         (h8300sx_register_name): Likewise.
4144         (h8300h_register_nam): New.
4145         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4146
4147
4148 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4149
4150         * arm-tdep.c (arm_skip_cmse_entry): New function.
4151         (arm_is_sgstubs_section): New function.
4152         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4153
4154 2019-07-22  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4157         Don't self-assign.
4158
4159 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4162         type_print.
4163
4164 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4167         so that GDB doesn't match any msymbols when searching in the
4168         TYPES_DOMAIN.
4169         (print_symbol_info): Print using typedef_print or type_print based
4170         on the type of the symbol.  Add updated FIXME comment moved from...
4171         (_initialize_symtab): ... move and update FIXME comment to above.
4172
4173 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * NEWS: Mention adding -q option to "info types".
4176         * symtab.c (struct info_types_options): New struct.
4177         (info_types_options_defs): New variable.
4178         (make_info_types_options_def_group): New function.
4179         (info_types_command): Use gdb::option framework to parse options.
4180         (info_types_command_completer): New function.
4181         (_initialize_symtab): Extend the help text on "info types" and
4182         register command completer.
4183
4184 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4185
4186         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4187         (lookup_symbol_in_objfile): Change int to block_enum and add a
4188         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4189
4190 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4191
4192         * MAINTAINERS (Write After Approval): Add self.
4193
4194 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4197         instruction to the dummy code region.
4198
4199 2019-07-19  Tom Tromey  <tromey@adacore.com>
4200
4201         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4202         (ARGSUSED, PARAMS, __func__): Remove rules.
4203
4204 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4205
4206         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4207         * features/arm/arm-with-iwmmxt.c: Remove.
4208         * features/arm/arm-with-iwmmxt.xml: Remove.
4209         * features/arm/arm-with-m-fpa-layout.c: Remove.
4210         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4211         * features/arm/arm-with-m-vfp-d16.c: Remove.
4212         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4213         * features/arm/arm-with-m.c: Remove.
4214         * features/arm/arm-with-m.xml: Remove.
4215         * features/arm/arm-with-neon.c: Remove.
4216         * features/arm/arm-with-neon.xml: Remove.
4217         * features/arm/arm-with-vfpv2.c: Remove.
4218         * features/arm/arm-with-vfpv2.xml: Remove.
4219         * features/arm/arm-with-vfpv3.c: Remove.
4220         * features/arm/arm-with-vfpv3.xml: Remove.
4221
4222 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4223
4224         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4225
4226 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4227
4228         * arch/aarch32.c (aarch32_create_target_description): Create
4229         target descriptions using features.
4230         * arch/arm.c (arm_create_target_description)
4231         (arm_create_mprofile_target_description): Likewise.
4232         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4233
4234 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4235
4236         * Makefile.in: Add new files.
4237         * aarch32-tdep.c: New file.
4238         * aarch32-tdep.h: New file.
4239         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4240         Call aarch32_read_description.
4241         * arch/aarch32.c: New file.
4242         * arch/aarch32.h: New file.
4243         * arch/arm.c (arm_create_target_description)
4244         (arm_create_mprofile_target_description): New function.
4245         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4246         (arm_create_target_description)
4247         (arm_create_mprofile_target_description): New declaration.
4248         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4249         read_description functions.
4250         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4251         Likewise.
4252         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4253         * arm-tdep.c (tdesc_arm_list): New variable.
4254         (arm_register_g_packet_guesses): Call create description functions.
4255         (arm_read_description) (arm_read_mprofile_description): New
4256         function.
4257         * arm-tdep.h (arm_read_description)
4258         (arm_read_mprofile_description): Add declaration.
4259         * configure.tgt: Add new files.
4260
4261 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4262
4263         * top.c (new_ui_command): Open specified terminal just once.
4264
4265 2019-07-18  Tom Tromey  <tromey@adacore.com>
4266
4267         * symtab.c (main_name): Constify return type.
4268         * symfile.c (set_initial_language): Update.
4269         * symtab.h (main_name): Constify return type.
4270
4271 2019-07-17  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-winsource.c (tui_update_source_window)
4274         (tui_update_source_window_as_is)
4275         (tui_update_source_windows_with_line): Remove return.
4276         * tui/tui-disasm.c (tui_show_disassem)
4277         (tui_show_disassem_and_update_source): Remove return.
4278         * tui/tui.c (tui_reset): Remove return.
4279         * tui/tui-wingeneral.c
4280         (tui_check_and_display_highlight_if_needed): Remove return.
4281
4282 2019-07-17  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4285
4286 2019-07-17  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-winsource.h (struct tui_exec_info_window)
4289         (struct tui_source_window_base): Move from tui-data.h.
4290         * tui/tui-winsource.c: Move many method definitions from
4291         elsewhere.  Remove "structuring" comments.
4292         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4293         (tui_source_window_base::refresh_window): Move to
4294         tui-winsource.c.
4295         * tui/tui-win.c (tui_source_window_base::refresh_all)
4296         (tui_source_window_base::update_tab_width)
4297         (tui_source_window_base::set_new_height)
4298         (tui_source_window_base::do_make_visible_with_new_height): Move to
4299         tui-winsource.c.
4300         * tui/tui-source.h: Update.
4301         * tui/tui-source.c (tui_source_window_base::reset): Move to
4302         tui-winsource.c.
4303         * tui/tui-disasm.h: Update.
4304         * tui/tui-data.h (struct tui_exec_info_window): Move to
4305         tui-winsource.h.
4306         (struct tui_source_window_base): Likewise.
4307         * tui/tui-data.c (tui_source_window_base::clear_detail)
4308         (tui_source_window_base, ~tui_source_window_base): Move to
4309         tui-winsource.c.
4310
4311 2019-07-17  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui-win.c (tui_resize_all)
4314         (tui_source_window_base::update_tab_width)
4315         (tui_adjust_win_heights): Update.
4316         (tui_win_info::make_invisible_and_set_new_height): Rename from
4317         make_invisible_and_set_new_height.
4318         * tui/tui-data.h (struct tui_win_info)
4319         <make_invisible_and_set_new_height>: New method.
4320
4321 2019-07-17  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui.c: Update.
4324         * tui/tui-source.h (struct tui_source_window): Move from
4325         tui-data.h.
4326         * tui/tui-layout.c: Update.
4327         * tui/tui-disasm.c: Update.
4328         * tui/tui-data.h (struct tui_source_window): Move to
4329         tui-source.h.
4330
4331 2019-07-17  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4334         tui-data.h.
4335         * tui/tui-data.h (struct tui_disasm_window): Move to
4336         tui-disasm.h.
4337
4338 2019-07-17  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-regs.h (struct tui_data_item_window): Move from
4341         tui-data.h.
4342         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4343         * tui/tui-data.h (struct tui_data_item_window): Move to
4344         tui-regs.h.
4345         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4346
4347 2019-07-17  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui.c: Update.
4350         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4351         (tui_cmd_window::max_height): Move to tui-command.c.
4352         * tui/tui-layout.c: Update.
4353         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4354         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4355         tui-command.c.
4356         * tui/tui-command.h (struct tui_cmd_window): Move from
4357         tui-data.h.
4358         * tui/tui-command.c: Remove "structuring" comments.
4359         (tui_cmd_window::clear_detail)
4360         (tui_cmd_window::do_make_visible_with_new_height)
4361         (tui_cmd_window::max_height): Move from elsewhere.
4362
4363 2019-07-17  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4366         Now static.
4367         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4368         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4369
4370 2019-07-17  Tom Tromey  <tom@tromey.com>
4371
4372         * tui/tui.c: Update.
4373         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4374         tui-regs.c.
4375         * tui/tui-windata.h: Remove file.
4376         * tui/tui-windata.c: Remove file.
4377         * tui/tui-win.c (tui_data_window::set_new_height)
4378         (tui_data_window::do_make_visible_with_new_height): Move to
4379         tui-regs.c.
4380         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4381         * tui/tui-regs.c: Remove "structuring" comments.
4382         (tui_data_window::first_data_item_displayed)
4383         (tui_data_window::delete_data_content_windows)
4384         (tui_data_window::erase_data_content)
4385         (tui_data_window::display_all_data)
4386         (tui_data_window::refresh_all)
4387         (tui_data_window::do_scroll_vertical)
4388         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4389         (tui_data_window::do_make_visible_with_new_height)
4390         (tui_data_window::refresh_window): Move from elsewhere.
4391         (_initialize_tui_regs): Move to end of file.
4392         * tui/tui-layout.c: Update.
4393         * tui/tui-hooks.c: Update.
4394         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4395         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4396         tui-regs.c.
4397         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4398
4399 2019-07-17  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4402         seen.
4403
4404 2019-07-17  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-win.c (tui_source_window_base::set_new_height)
4407         (tui_source_window_base::do_make_visible_with_new_height): Use
4408         m_has_locator field directly.
4409         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4410         method.
4411         (struct tui_source_window_base) <has_locator>: Likewise.
4412
4413 2019-07-17  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4416         Don't declare.
4417         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4418         Remove.
4419         * tui/tui-win.c (tui_source_window_base::set_new_height)
4420         (tui_source_window_base::set_new_height)
4421         (make_invisible_and_set_new_height)
4422         (tui_source_window_base::do_make_visible_with_new_height)
4423         (tui_source_window_base::do_make_visible_with_new_height):
4424         Update.
4425         * tui/tui-layout.c (show_source_disasm_command, show_data)
4426         (show_source_or_disasm_and_command): Update.
4427         * tui/tui-layout.c (show_layout): Update.
4428
4429 2019-07-17  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-layout.c (make_data_window): Remove.
4432         (show_data): Unify creation and re-initialization cases.
4433
4434 2019-07-17  Tom Tromey  <tom@tromey.com>
4435
4436         * tui/tui-layout.c (make_source_window, make_disasm_window):
4437         Remove.
4438         (show_data): Unify creation and re-initialization cases.
4439
4440 2019-07-17  Tom Tromey  <tom@tromey.com>
4441
4442         * tui/tui-layout.c (make_command_window): Remove.
4443         (show_source_disasm_command, show_source_or_disasm_and_command):
4444         Unify creation and re-initialization cases.
4445
4446 2019-07-17  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4449         creation and re-initialization cases.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-regs.c (tui_get_register): Return void.
4454
4455 2019-07-17  Tom Tromey  <tom@tromey.com>
4456
4457         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4458         Simplify.
4459
4460 2019-07-17  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4463         resetting.
4464
4465 2019-07-17  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4468         * tui/tui-regs.c (tui_reg_layout): New function.
4469         (tui_show_registers, tui_reg_command): Use it.
4470         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4471         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4472         parameters.
4473         (tui_layout_command): Remove.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-layout.h (tui/tui-layout): Return void.
4478         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4479
4480 2019-07-17  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-layout.c (show_source_disasm_command, show_data):
4483         Update.
4484         (reset_locator): Remove.
4485         (show_source_or_disasm_and_command): Update.
4486
4487 2019-07-17  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-source.c (tui_source_window_base::reset): Remove
4490         win_type parameter.
4491         * tui/tui-layout.c (make_command_window, make_source_window)
4492         (make_disasm_window, make_data_window)
4493         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4494         (reset_locator, show_source_or_disasm_and_command): Update.
4495         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4496         win_type parameter.
4497         (struct tui_source_window_base) <reset>: Likewise.
4498
4499 2019-07-17  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-layout.c (show_source_disasm_command): Use
4502         reset_locator.
4503         (reset_locator): New function.
4504         (init_and_make_win): Remove.
4505         (show_source_or_disasm_and_command): Use reset_locator.
4506
4507 2019-07-17  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4510         condition.
4511         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4512         Remove condition.
4513         * tui/tui-source.c (tui_source_window_base::reset): New method.
4514         * tui/tui-layout.c (make_command_window): Don't call
4515         init_and_make_win.
4516         (make_source_window, make_disasm_window): Don't call
4517         make_source_or_disasm_window.
4518         (make_data_window): Don't call init_and_make_win.  Change calling
4519         convention.
4520         (show_source_disasm_command, show_data): Simplify.
4521         (make_source_or_disasm_window): Remove.
4522         (show_source_or_disasm_and_command): Simplify.
4523         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4524         (struct tui_source_window_base) <reset>: Likewise.
4525         <execution_info>: Remove initializer.
4526         * tui/tui-data.c (tui_source_window_base): Initialize
4527         execution_info.
4528
4529 2019-07-17  Tom Tromey  <tom@tromey.com>
4530
4531         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4532         variable.
4533
4534 2019-07-17  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui.c (tui_rl_other_window): Update.
4537         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4538         superclass method first.  Always iterate over regs_content.
4539         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4540         method.
4541         * tui/tui-win.c (tui_set_focus_command): Update.
4542
4543 2019-07-17  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui-win.c (tui_set_focus_command): Rename from
4546         tui_set_focus.  Call tui_enable.
4547         (tui_set_focus_command): Remove.
4548
4549 2019-07-17  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4552         refresh_window.
4553         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4554         touchwin.
4555         (tui_data_window::refresh_window): Call refresh_window on data
4556         items.  Always call superclass refresh_window.
4557         (tui_win_info::refresh): Remove.
4558         (tui_source_window_base::refresh_window): Update.
4559         (tui_refresh_all): Update.
4560         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4561         refresh_window.
4562         (show_source_or_disasm_and_command): Likewise.
4563         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4564         (struct tui_source_window_base) <refresh>: Likewise.
4565
4566 2019-07-17  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-winsource.c (tui_clear_source_content)
4569         (tui_show_source_content): Update.
4570         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4571         whether content is empty.
4572         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4573         Remove.
4574
4575 2019-07-17  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4578         window's contents.
4579         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4580         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4581
4582 2019-07-17  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4585         (struct tui_data_item_window): Update.
4586
4587 2019-07-17  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4590         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4591         defines.
4592
4593 2019-07-17  Tom Tromey  <tom@tromey.com>
4594
4595         * tui/tui-winsource.h (tui_erase_source_content)
4596         (tui_clear_source_content): Remove "display_prompt" parameter.
4597         * tui/tui-winsource.c (tui_update_source_window_as_is)
4598         (tui_update_source_windows_with_addr): Update.
4599         (tui_clear_source_content): Remove "display_prompt" parameter.
4600         (tui_erase_source_content): Likewise.  Simplify.
4601         (tui_show_source_content): Update.
4602         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4603         * tui/tui-stack.c (tui_show_frame_info): Update.
4604         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4605         Remove defines.
4606
4607 2019-07-17  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4610         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4611         parameter.
4612         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4613         parameter.
4614
4615 2019-07-17  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-winsource.c (tui_clear_source_content)
4618         (tui_show_source_content, tui_show_exec_info_content)
4619         (tui_clear_exec_info_content): Update.
4620         * tui/tui-stack.c (tui_show_locator_content): Update.
4621         (tui_show_frame_info): Update.
4622         * tui/tui-source.h (tui_source_window): Don't declare.
4623         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4624         from tui_source_is_displayed.
4625         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4626         Remove field.
4627         (struct tui_source_window_base) <content_in_use>: New field.  Now
4628         bool.
4629         (struct tui_source_window) <showing_source_p>: New method.
4630         (TUI_SRC_WIN): Change cast.
4631         * tui/tui-data.c (tui_initialize_static_data): Update.
4632
4633 2019-07-17  Tom Tromey  <tom@tromey.com>
4634
4635         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4636         location_matches_p.
4637         * tui/tui-source.c (tui_source_window::location_matches_p): New
4638         method.
4639         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4640         method.
4641         * tui/tui-data.h (struct tui_source_window_base)
4642         <location_matches_p>: New method.
4643         (struct tui_source_window, struct tui_disasm_window)
4644         <location_matches_p>: Likewise.
4645
4646 2019-07-17  Tom Tromey  <tom@tromey.com>
4647
4648         * tui/tui-win.c (tui_set_win_height_command): Rename from
4649         tui_set_win_height.
4650         (tui_set_win_height_command): Remove.
4651
4652 2019-07-17  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-source.c (tui_source_window): New constructor.  Add
4655         observer.
4656         (~tui_source_window): New destructor.
4657         (tui_source_window::style_changed): New method.
4658         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4659         (tui_attach_detach_observers): Update.
4660         * tui/tui-data.h (struct tui_source_window): Make constructor not
4661         inline.  Add destructor.
4662         (struct tui_source_window) <style_changed>: New method.
4663         <m_observable>: New member.
4664
4665 2019-07-17  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4668         * tui/tui-win.c (tui_resize_all): Fix typo.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4673         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4674         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4675         * tui/tui-win.c (window_name_completer): Use foreach.
4676         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4677         (update_tab_width): Likewise.
4678         * tui/tui-layout.c (show_layout): Update.
4679         * tui/tui-data.h (class tui_window_iterator): New.
4680         (struct all_tui_windows): New.
4681         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4682
4683 2019-07-17  Tom Tromey  <tom@tromey.com>
4684
4685         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4686         parameter.  Don't reference globals.
4687         (tui_reg_command): Update.
4688
4689 2019-07-17  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-regs.c (tui_show_registers): Simplify.
4692
4693 2019-07-17  Tom Tromey  <tom@tromey.com>
4694
4695         * tui/tui-regs.c (tui_show_registers): Update.
4696         (tui_show_register_group): Add win_info parameter.
4697
4698 2019-07-17  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4701         Rename from tui_display_reg_element_at_line.
4702         (tui_data_window::display_registers_from_line): Update.
4703         * tui/tui-data.h (struct tui_data_window)
4704         <display_reg_element_at_line>: New method.
4705
4706 2019-07-17  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-regs.h (tui_display_registers_from)
4709         (tui_display_registers_from_line): Don't declare.
4710         * tui/tui-windata.c (tui_data_window::display_all_data)
4711         (tui_data_window::refresh_all)
4712         (tui_data_window::do_scroll_vertical): Update.
4713         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4714         from tui_display_registers_from.
4715         (tui_display_reg_element_at_line): Update.
4716         (tui_data_window::display_registers_from_line): Rename from
4717         tui_display_registers_from_line.
4718         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4719         display_registers_from_line>: New methods.
4720
4721 2019-07-17  Tom Tromey  <tom@tromey.com>
4722
4723         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4724         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4725         from tui_erase_data_content.
4726         (tui_data_window::display_all_data)
4727         (tui_data_window::refresh_all)
4728         (tui_data_window::do_scroll_vertical): Update.
4729         * tui/tui-regs.c (tui_show_registers): Update.
4730         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4731         New method.
4732
4733 2019-07-17  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4736         declare.
4737         * tui/tui-windata.c
4738         (tui_data_window::delete_data_content_windows): Rename from
4739         tui_delete_data_content_windows.
4740         (tui_data_window::display_all_data)
4741         (tui_data_window::do_scroll_vertical): Update.
4742         * tui/tui-data.h (struct tui_data_window)
4743         <delete_data_content_windows>: New method.
4744
4745 2019-07-17  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4748         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4749
4750 2019-07-17  Tom Tromey  <tom@tromey.com>
4751
4752         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4753         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4754         from tui_display_all_data.
4755         * tui/tui-win.c
4756         (tui_data_window::do_make_visible_with_new_height): Update.
4757         * tui/tui-regs.c (tui_show_registers): Update.
4758         * tui/tui-layout.c (tui_set_layout): Update.
4759         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4760         method.
4761
4762 2019-07-17  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4765         * tui/tui-windata.c (tui_display_data_from): Remove.
4766         (tui_data_window::refresh_all): Update.
4767
4768 2019-07-17  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4771         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4772         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4773         tui_display_registers_from_line.
4774         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4775         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4776         "force_display" parameter.
4777
4778 2019-07-17  Tom Tromey  <tom@tromey.com>
4779
4780         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4781         declare.
4782         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4783         Rename from tui_first_reg_element_no_inline.
4784         (tui_display_reg_element_at_line)
4785         (tui_display_registers_from_line): Update.
4786         * tui/tui-data.h (struct tui_data_window)
4787         <first_reg_element_no_inline>: New method.
4788
4789 2019-07-17  Tom Tromey  <tom@tromey.com>
4790
4791         * tui/tui-windata.c (tui_display_data_from)
4792         (tui_data_window::do_scroll_vertical): Update.
4793         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4794         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4795         Rename from tui_line_from_reg_element_no.
4796         (tui_display_registers_from_line): Update.
4797         * tui/tui-data.h (struct tui_data_window)
4798         <line_from_reg_element_no>: New method.
4799
4800 2019-07-17  Tom Tromey  <tom@tromey.com>
4801
4802         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4803         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4804         tui_last_regs_line_no.
4805         (tui_display_reg_element_at_line)
4806         (tui_display_registers_from_line): Update.
4807         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4808         method.
4809
4810 2019-07-17  Tom Tromey  <tom@tromey.com>
4811
4812         PR tui/24722:
4813         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4814         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4815         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4816         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4817         (tui_update_breakpoint_info): Likewise.
4818         * tui/tui-hooks.c (tui_event_create_breakpoint)
4819         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4820         Update.
4821
4822 2019-07-17  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4825
4826 2019-07-17  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-winsource.c (tui_update_source_window_as_is)
4829         (tui_update_source_windows_with_addr): Update.
4830         * tui/tui-source.h (tui_set_source_content)
4831         (tui_show_symtab_source): Add "win_info" parameter.
4832         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4833         parameter.
4834         (tui_show_symtab_source): Likewise.
4835
4836 2019-07-17  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-wingeneral.c
4839         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4840
4841 2019-07-17  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4844         (struct tui_cmd_window) <can_scroll>: New method.
4845         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4846         method.
4847
4848 2019-07-17  Tom Tromey  <tromey@adacore.com>
4849
4850         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4851         do_field_signed>: Rename.  Change type of "value".
4852         * ui-out.c (ui_out::field_signed): Rename from field_int.
4853         Change type of "value".
4854         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4855         type of "value".
4856         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4857         do_field_int.  Change type of "value".
4858         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4859         do_field_int.  Change type of "value".
4860         * tracepoint.c (trace_status_mi, tfind_1)
4861         (print_one_static_tracepoint_marker): Update.
4862         * thread.c (print_thread_info_1, print_selected_thread_frame):
4863         Update.
4864         * stack.c (print_frame, print_frame_info): Update.
4865         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4866         Update.
4867         * source.c (print_source_lines_base): Update.
4868         * skip.c (info_skip_command): Update.
4869         * record-btrace.c (btrace_ui_out_decode_error)
4870         (btrace_call_history_src_line): Update.
4871         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4872         Update.
4873         * progspace.c (print_program_space): Update.
4874         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4875         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4876         do_field_int.  Change type of "value".
4877         * mi/mi-out.c (mi_ui_out::do_table_begin)
4878         (mi_ui_out::do_table_header): Update.
4879         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4880         type of "value".
4881         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4882         (mi_cmd_data_list_changed_registers, output_register)
4883         (mi_cmd_data_read_memory, mi_load_progress)
4884         (mi_cmd_trace_frame_collected): Update.
4885         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4886         Update.
4887         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4888         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4889         (mi_cmd_var_list_children, varobj_update_one): Update.
4890         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4891         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4892         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4893         * inferior.c (print_inferior): Update.
4894         * gdb_bfd.c (print_one_bfd): Update.
4895         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4896         Update.
4897         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4898         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4899         do_field_int.  Change type of "value".
4900         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4901         do_field_int.  Change type of "value".
4902         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4903         (print_one_breakpoint_location, print_it_catch_fork)
4904         (print_one_catch_fork, print_it_catch_vfork)
4905         (print_one_catch_vfork, print_it_catch_solib)
4906         (print_it_catch_exec, print_it_ranged_breakpoint)
4907         (print_mention_watchpoint, print_mention_masked_watchpoint)
4908         (bkpt_print_it, update_static_tracepoint): Update.
4909         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4910         * break-catch-syscall.c (print_it_catch_syscall): Update.
4911         * ada-tasks.c (print_ada_task_info): Update.
4912         * ada-lang.c (print_it_exception, print_mention_exception):
4913         Update.
4914
4915 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         PR breakpoints/24541
4918         * gdbarch.c: Regenerate.
4919         * gdbarch.h: Regenerate.
4920         * gdbarch.sh: Adjust return type and parameter types for
4921         'stap_adjust_register'.
4922         (i386_stap_adjust_register): Adjust signature and return new
4923         register name.
4924         * stap-probe.c (stap_parse_register_operand): Adjust use of
4925         'gdbarch_stap_adjust_register'.
4926
4927 2019-07-17  Tom Tromey  <tromey@adacore.com>
4928
4929         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4930         declare VEC.
4931         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4932         std::vector.
4933         (struct s390_process_info): Add initializers.
4934         (s390_add_process): Use new.
4935         (s390_linux_nat_target::low_forget_process): Use delete.
4936         (s390_linux_nat_target::low_new_fork)
4937         (s390_linux_nat_target::stopped_by_watchpoint)
4938         (s390_linux_nat_target::low_prepare_to_resume)
4939         (s390_linux_nat_target::insert_watchpoint)
4940         (s390_linux_nat_target::insert_hw_breakpoint)
4941         (s390_linux_nat_target::remove_watchpoint)
4942         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4943
4944 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4945
4946         * aarch64-fbsd-nat.c: Include regcache.h.
4947         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4948         argument.
4949         (aarch64_fbsd_nat_target::fetch_registers)
4950         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4951         variable.
4952         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4953
4954 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4955
4956         * fbsd-nat.c: Include gdbarch.h.
4957
4958 2019-07-15  Tom Tromey  <tromey@adacore.com>
4959
4960         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4961
4962 2019-07-15  Tom Tromey  <tromey@adacore.com>
4963
4964         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4965         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4966         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4967         * cli-out.c (cli_ui_out::do_field_int): New method.
4968         * ui-out.c (ui_out::field_unsigned): New method.
4969         * symfile.c (generic_load): Use field_unsigned.
4970         (print_transfer_performance): Likewise.
4971         * record-btrace.c (ui_out_field_uint): Remove.
4972         (btrace_call_history_insn_range, btrace_call_history): Use
4973         field_unsigned.
4974         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4975         field_unsigned.
4976         * ui-out.h (class ui_out) <field_unsigned>: New method.
4977         <do_field_unsigned>: Likewise.
4978
4979 2019-07-15  Tom Tromey  <tromey@adacore.com>
4980
4981         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4982         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4983         * target.c (flash_erase_command): Use field_string.
4984         * infrun.c (print_signal_received_reason): Use field_string.
4985         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4986         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4987         field_string.
4988         * ada-tasks.c (print_ada_task_info): Use field_string.
4989
4990 2019-07-15  Tom Tromey  <tromey@adacore.com>
4991
4992         * target.c (flash_erase_command): Use field_core_addr.
4993         * symfile.c (generic_load): Use field_core_addr.
4994         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4995         Use field_core_addr.
4996         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4997         field_core_addr.
4998
4999 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5000
5001         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5002         value if its desired type is smaller than a CORE_ADDR and signed.
5003
5004 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5007         of changes to field names, and use new is_reference field to
5008         decide if a property is a reference or not.
5009         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5010         field.
5011         (struct dwarf2_property_baton): Update header comment, rename
5012         'referenced_type' to 'property_type' and update comments.
5013         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5014         default property type, store in property baton, update to take
5015         accound of renamed field.
5016         (read_func_scope): Update call to attr_to_dynamic_prop.
5017         (read_array_type): Likewise.
5018         (dwarf2_per_cu_addr_sized_int_type): New function.
5019         (read_subrange_index_type): Move type finding code to
5020         dwarf2_per_cu_addr_sized_int_type.
5021         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5022         (dwarf2_per_cu_addr_type): New function.
5023         (set_die_type): Update calls to attr_to_dynamic_prop.
5024
5025 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5026
5027         * dwarf2read.c (read_subrange_index_type): New function.
5028         (read_subrange_type): Move code into new function and call it.
5029         * gdbtypes.c (create_range_type): Add some asserts.
5030
5031 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5034         update return statements.
5035         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5036         declaration, and update comment to match.
5037         * gdbtypes.c (resolve_dynamic_array): Update call to
5038         dwarf2_evaluate_property to match new return type.
5039
5040 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * valarith.c (value_subscripted_rvalue): Change lowerbound
5043         parameter type from int to LONGEST.
5044         * value.h (value_subscripted_rvalue): Likewise in declaration.
5045
5046 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5047
5048         * cli/cli-utils.c (info_print_command_completer): New function.
5049         * cli/cli-utils.h: Add 'completer.h' include, and forward
5050         declaration for 'struct cmd_list_element'.
5051         (info_print_command_completer): Declare.
5052         * stack.c (_initialize_stack): Add completer for 'info locals' and
5053         'info args'.
5054         * symtab.c (_initialize_symtab): Add completer for 'info
5055         variables' and 'info functions'.
5056         * NEWS: Mention completion for additional info commands.
5057
5058 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * cli/cli-utils.c (extract_info_print_args): Delete.
5061         (extract_arg_maybe_quoted): Delete.
5062         (info_print_options_defs): New variable.
5063         (make_info_print_options_def_group): New function.
5064         (extract_info_print_options): Define new function.
5065         * cli/cli-utils.h (extract_info_print_args): Delete.
5066         (struct info_print_options): New structure.
5067         (extract_info_print_options): Declare new function.
5068         * stack.c (info_locals_command): Update to use new
5069         extract_info_print_options, also add a header comment.
5070         (info_args_command): Likewise.
5071         * symtab.c (info_variables_command): Likewise.
5072         (info_functions_command): Likewise.
5073
5074 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5077         to extract string arguments.
5078         * common/common-utils.c (extract_string_maybe_quoted): New function.
5079         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5080
5081 2019-07-11  Tom Tromey  <tromey@adacore.com>
5082
5083         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5084         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5085         * top.h (gdbinit): Don't declare.
5086         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5087         into...
5088         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5089         * top.c (gdb_init): Don't call init_cli_cmds.
5090         (gdbinit): Remove.
5091         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5092
5093 2019-07-11  Tom Tromey  <tromey@adacore.com>
5094
5095         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5096         after it has been moved.
5097
5098 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5099
5100         * valops.c (value_must_coerce_to_target): Change return type to
5101         bool.
5102         * value.h (value_must_coerce_to_target): Likewise.
5103
5104 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5105
5106         * breakpoint.c (is_hardware_watchpoint): Remove
5107         forward-declaration.
5108         (is_masked_watchpoint): Change return type to bool.
5109         (is_tracepoint): Likewise.
5110         (is_breakpoint): Likewise.
5111         (is_hardware_watchpoint): Likewise.
5112         (is_watchpoint): Likewise.
5113         (is_no_memory_software_watchpoint): Likewise.
5114         (is_catchpoint): Likewise.
5115         (breakpoint_1): Make FILTER parameter's return type bool.
5116         is_masked_watchpoint): Change return type to bool.
5117         (save_breakpoints): Make FILTER parameter's return type bool.
5118         * breakpoint.h (is_breakpoint): Change return type to bool.
5119         (is_watchpoint): Likewise.
5120         (is_catchpoint): Likewise.
5121         (is_tracepoint): Likewise.
5122
5123 2019-07-10  Tom Tromey  <tom@tromey.com>
5124
5125         * defs.h: Don't include gdbarch.h.
5126         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5127         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5128         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5129         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5130         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5131         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5132         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5133         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5134         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5135         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5136         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5137         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5138         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5139         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5140         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5141         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5142         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5143         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5144         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5145         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5146         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5147         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5148         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5149         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5150         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5151         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5152         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5153
5154 2019-07-10  Tom Tromey  <tromey@adacore.com>
5155
5156         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5157         * breakpoint.c (init_ada_exception_breakpoint): Register as
5158         bp_catchpoint.
5159         (print_one_breakpoint_location, print_one_breakpoint): Use
5160         is_ada_exception_catchpoint.
5161         * ada-lang.c (class ada_catchpoint_location): Pass
5162         bp_loc_software_breakpoint to bp_location constructor.
5163         (is_ada_exception_catchpoint): New function.
5164
5165 2019-07-10  Tom Tromey  <tromey@adacore.com>
5166
5167         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5168         VEC.
5169         (struct arm_exidx_entry): New method operator<.
5170         (struct arm_exidx_data) <section_maps>: Change type.
5171         (arm_exidx_data_free): Remove.
5172         (arm_exidx_data_key): Change type.  Move lower.
5173         (arm_exidx_new_objfile): Update.
5174         (arm_compare_exidx_entries): Remove.
5175         (arm_find_exidx_entry, _initialize_arm_tdep)
5176
5177 2019-07-10  Tom Tromey  <tromey@adacore.com>
5178
5179         * solib-spu.c (ocl_program_data_key): Change type.
5180         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5181         Update.
5182
5183 2019-07-10  Tom Tromey  <tromey@adacore.com>
5184
5185         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5186         (struct solib_aix_inferior_data) <library_list>: Change type.
5187         (solib_aix_inferior_data_handle): Change type.
5188         (get_solib_aix_inferior_data): Update.
5189         (solib_aix_free_library_list): Remove.
5190         (library_list_start_library): Update.
5191         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5192         return type.
5193         (solib_aix_get_library_list)
5194         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5195         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5196
5197 2019-07-10  Tom Tromey  <tromey@adacore.com>
5198
5199         * solib-dsbt.c (struct dsbt_info): Add initializers.
5200         (solib_dsbt_pspace_data): Change type.
5201         (dsbt_pspace_data_cleanup): Remove.
5202         (get_dsbt_info, _initialize_dsbt_solib): Update.
5203
5204 2019-07-10  Tom Tromey  <tromey@adacore.com>
5205
5206         * spu-tdep.c (spu_overlay_data): Change type.
5207         (spu_get_overlay_table, spu_overlay_new_objfile)
5208         (_initialize_spu_tdep): Update.
5209
5210 2019-07-10  Tom Tromey  <tromey@adacore.com>
5211
5212         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5213         destructor.
5214         (dbx_objfile_data_key): Change type and declare later.
5215         (DBX_SYMFILE_INFO): Rewrite.
5216         * dbxread.c (dbx_objfile_data_key): Change type.
5217         (dbx_symfile_init): Update.
5218         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5219         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5220         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5221
5222 2019-07-10  Tom Tromey  <tromey@adacore.com>
5223
5224         * jit.c (jit_program_space_key): Change type.  Move lower.
5225         (get_jit_program_space_data): Update.
5226         (jit_program_space_data_cleanup): Remove.
5227         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5228         Update.
5229         (struct jit_program_space_data): Add initializers.
5230
5231 2019-07-10  Tom Tromey  <tromey@adacore.com>
5232
5233         * solib-darwin.c (struct darwin_info): Add initializers.
5234         (solib_darwin_pspace_data): Change type.
5235         (darwin_pspace_data_cleanup): Remove.
5236         (get_darwin_info, _initialize_darwin_solib): Update.
5237
5238 2019-07-10  Tom Tromey  <tromey@adacore.com>
5239
5240         * remote-sim.c (struct sim_inferior_data): Add initializers,
5241         constructor, and destructor.
5242         (sim_inferior_data_key): Change type.  Move lower.
5243         (check_for_duplicate_sim_descriptor): Update.
5244         (get_sim_inferior_data): Use new.  Update.
5245         (~sim_inferior_data_cleanup): Rename from
5246         sim_inferior_data_cleanup.  Simplify.
5247         (gdbsim_close_inferior, simulator_command)
5248         (sim_command_completer, _initialize_remote_sim): Update.
5249         (next_pid, INITIAL_PID): Move earlier.
5250
5251 2019-07-10  Tom Tromey  <tromey@adacore.com>
5252
5253         * python/python-internal.h (create_thread_object): Return
5254         gdbpy_ref.
5255         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5256         * python/py-inferior.c (struct threadlist_entry): Add
5257         constructor.
5258         <thread_obj>: Now a gdbpy_ref.
5259         (thread_to_thread_object): Update.
5260         (add_thread_object): Use new.
5261         (delete_thread_object): Use delete.
5262         (infpy_threads): Update.
5263         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5264         GIL.
5265
5266 2019-07-10  Tom Tromey  <tromey@adacore.com>
5267
5268         * valops.c (value_cast): Specialize error message for Ada.
5269
5270 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5271
5272         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5273
5274 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5275
5276         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5277         bpstat_should_step): Return bool, adjust comments.
5278         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5279         bpstat_should_step): Likewise.
5280
5281 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5282
5283         * features/Makefile: Use feature target descriptions for Arm.
5284         * features/arm/arm-core.c: Generate new file.
5285         * features/arm/arm-fpa.c: Likewise.
5286         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5287         * features/arm/arm-m-profile.c: Likewise.
5288         * features/arm/arm-vfpv2.c: Likewise.
5289         * features/arm/arm-vfpv3.c: Likewise.
5290         * features/arm/xscale-iwmmxt.c: Likewise.
5291         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5292
5293 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5294
5295         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5296         ptrace earlier.
5297
5298 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5299
5300         * features/aarch64-pauth.c: Regenerate.
5301
5302 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5303
5304         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5305         bool.
5306         (bpstat_what): Use false instead of 0.
5307
5308 2019-07-09  Pedro Alves  <palves@redhat.com>
5309
5310         * break-catch-throw.c (is_exception_catchpoint): New.
5311         * breakpoint.c (print_one_breakpoint_location): New parameter
5312         'raw_loc'.  Handle it.  Use
5313         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5314         looking at the breakpoint's type.
5315         (print_one_breakpoint): If handling "maint info breakpoints", also
5316         print locations of exception catchpoints.
5317         * breakpoint.h (is_exception_catchpoint): Declare.
5318
5319 2019-07-09  Pedro Alves  <palves@redhat.com>
5320
5321         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5322         "addr" field.
5323         (allocate_location_exception_catchpoint): New.
5324         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5325         (initialize_throw_catchpoint_ops): Install
5326         allocate_location_exception_catchpoint as allocate_location
5327         method.
5328         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5329         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5330         bp_loc_other.
5331         (breakpoint_address_is_meaningful): Delete.
5332         (bl_address_is_meaningful): New.
5333         (breakpoint_locations_match): Adjust comment.
5334         (bp_location_from_bp_type): New, factored out of...
5335         (bp_location::bp_location(breakpoint *)): ... this.
5336         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5337         factored out of...
5338         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5339         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5340         breakpoint_address_is_meaningful.
5341         (bp_locations_compare): Adjust comment.
5342         (update_global_location_list): Use bl_address_is_meaningful
5343         instead of breakpoint_address_is_meaningful.
5344         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5345         explicit.
5346         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5347         * python/py-breakpoint.c (bppy_get_location): No longer check
5348         whether location is null.
5349
5350 2019-07-09  Pedro Alves  <palves@redhat.com>
5351
5352         PR c++/15468
5353         * breakpoint.c (print_one_breakpoint_location): Remove
5354         single-location assert.
5355
5356 2019-07-09  Tom Tromey  <tom@tromey.com>
5357
5358         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5359         * configure: Rebuild.
5360         * configure.ac: Change common to gdbsupport.
5361         * gdbsupport: Rename from common.
5362         * acinclude.m4: Change common to gdbsupport.
5363         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5364         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5365         gdbsupport.
5366         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5367         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5368         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5369         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5370         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5371         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5372         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5373         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5374         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5375         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5376         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5377         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5378         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5379         coff-pe-read.c, command.h, compile/compile-c-support.c,
5380         compile/compile-c.h, compile/compile-cplus-symbols.c,
5381         compile/compile-cplus-types.c, compile/compile-cplus.h,
5382         compile/compile-loc2c.c, compile/compile.c, completer.c,
5383         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5384         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5385         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5386         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5387         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5388         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5389         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5390         features/aarch64-core.c, features/aarch64-fpu.c,
5391         features/aarch64-pauth.c, features/aarch64-sve.c,
5392         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5393         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5394         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5395         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5396         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5397         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5398         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5399         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5400         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5401         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5402         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5403         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5404         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5405         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5406         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5407         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5408         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5409         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5410         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5411         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5412         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5413         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5414         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5415         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5416         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5417         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5418         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5419         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5420         minsyms.c, mips-linux-tdep.c, namespace.h,
5421         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5422         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5423         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5424         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5425         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5426         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5427         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5428         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5429         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5430         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5431         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5432         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5433         procfs.c, producer.c, progspace.h, psymtab.h,
5434         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5435         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5436         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5437         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5438         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5439         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5440         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5441         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5442         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5443         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5444         target-memory.c, target.c, target.h, target/waitstatus.c,
5445         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5446         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5447         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5448         unittests/array-view-selftests.c,
5449         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5450         unittests/common-utils-selftests.c,
5451         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5452         unittests/format_pieces-selftests.c,
5453         unittests/function-view-selftests.c,
5454         unittests/lookup_name_info-selftests.c,
5455         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5456         unittests/mkdir-recursive-selftests.c,
5457         unittests/observable-selftests.c,
5458         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5459         unittests/parse-connection-spec-selftests.c,
5460         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5461         unittests/scoped_fd-selftests.c,
5462         unittests/scoped_mmap-selftests.c,
5463         unittests/scoped_restore-selftests.c,
5464         unittests/string_view-selftests.c, unittests/style-selftests.c,
5465         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5466         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5467         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5468         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5469         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5470         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5471
5472 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5475         bool value.
5476         (decode_digits_ordinary): Set explicit_line field in sal.
5477         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5478         symtab_and_line that was set on an explicit line number in
5479         assembler code.  Do always update the recorded symtab and line if
5480         we do skip the prologue.
5481
5482 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * breakpoint.c (set_breakpoint_location_function): Remove
5485         explicit_loc parameter.
5486         (momentary_breakpoint_from_master): Update call to
5487         set_breakpoint_location_function.
5488         (add_location_to_breakpoint): Likewise.
5489
5490 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5491
5492         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5493         required features based on default bfd type when no specific bfd
5494         is present.
5495
5496 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5497
5498         * NEWS: Mention that GDB printf and eval commands can now print
5499         C-style and Ada-style convenience var strings without
5500         calling the inferior.
5501         * printcmd.c (printf_c_string): Locally print GDB internal var
5502         instead of transiting via the inferior.
5503         (printf_wide_c_string): Likewise.
5504
5505 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5506
5507         PR breakpoints/25011
5508         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5509
5510 2019-07-04  Tom Tromey  <tom@tromey.com>
5511
5512         PR tui/24724:
5513         * tui/tui-winsource.c (tui_clear_source_content): Update.
5514         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5515         (tui_update_breakpoint_info): Update.
5516         (tui_set_exec_info_content): Update.
5517         * tui/tui-source.c (tui_set_source_content_nil): Update.
5518         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5519         has_break.
5520         * tui/tui-data.h (enum tui_bp_flag): New.
5521         (tui_bp_flags): New enum flags type.
5522         (struct tui_source_element) <break_mode>: Change type.  Rename
5523         from has_break.
5524         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5525         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5526         constants.
5527         * tui/tui-winsource.h: Fix comment.
5528
5529 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5530
5531         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5532         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5533         (store_fpregs_to_thread)
5534         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5535         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5536         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5537         (IWMMXT_REGS_SIZE): Add define.
5538         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5539         (fetch_vfp_regs, store_vfp_regs)
5540         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5541         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5542
5543 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5544
5545         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5546         defines.
5547         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5548         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5549         (ARM_INT_REGISTER_SIZE): ...to this.
5550         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5551         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5552         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5553         (arm_linux_collect_gregset, supply_nwfpe_register)
5554         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5555         defines.
5556         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5557         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5558         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5559         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5560         (arm_return_in_memory, arm_store_return_value)
5561         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5562         (arm_record_ld_st_multiple): Likewise.
5563         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5564         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5565
5566 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5567
5568         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5569         AARCH64_DISPLACED_MODIFIED_INSNS.
5570         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5571         (aarch64_displaced_step_copy_insn): Likewise.
5572         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5573         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5574         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5575         ARM_DISPLACED_MODIFIED_INSNS.
5576         * arm-tdep.c (arm_gdbarch_init): Likewise.
5577         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5578         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5579         (struct arm_displaced_step_closure): Use
5580         ARM_DISPLACED_MODIFIED_INSNS.
5581
5582 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5583
5584         * features/Makefile: Remove unused xml files.
5585         * features/aarch64.xml: Remove.
5586         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5587         * features/i386/amd64-avx-avx512.xml: Remove.
5588         * features/i386/amd64-avx-linux.xml: Remove.
5589         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5590         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5591         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5592         * features/i386/amd64-avx-mpx.xml: Remove.
5593         * features/i386/amd64-avx.xml: Remove.
5594         * features/i386/amd64-linux.xml: Remove.
5595         * features/i386/amd64-mpx-linux.xml: Remove.
5596         * features/i386/amd64-mpx.xml: Remove.
5597         * features/i386/amd64.xml: Remove.
5598         * features/i386/i386-avx-avx512-linux.xml: Remove.
5599         * features/i386/i386-avx-avx512.xml: Remove.
5600         * features/i386/i386-avx-linux.xml: Remove.
5601         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5602         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5603         * features/i386/i386-avx-mpx-linux.xml: Remove.
5604         * features/i386/i386-avx-mpx.xml: Remove.
5605         * features/i386/i386-avx.xml: Remove.
5606         * features/i386/i386-linux.xml: Remove.
5607         * features/i386/i386-mmx-linux.xml: Remove.
5608         * features/i386/i386-mmx.xml: Remove.
5609         * features/i386/i386-mpx-linux.xml: Remove.
5610         * features/i386/i386-mpx.xml: Remove.
5611         * features/i386/i386.xml: Remove.
5612         * features/i386/x32-avx-avx512-linux.xml: Remove.
5613         * features/i386/x32-avx-linux.xml: Remove.
5614         * features/i386/x32-linux.xml: Remove.
5615
5616 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5617
5618         * regformats/aarch64.dat: Remove.
5619         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5620         * regformats/i386/amd64-avx-linux.dat: Remove.
5621         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5622         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5623         * regformats/i386/amd64-linux.dat: Remove.
5624         * regformats/i386/amd64-mpx-linux.dat: Remove.
5625         * regformats/i386/amd64.dat: Remove.
5626         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5627         * regformats/i386/i386-avx-linux.dat: Remove.
5628         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5629         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5630         * regformats/i386/i386-linux.dat: Remove.
5631         * regformats/i386/i386-mmx-linux.dat: Remove.
5632         * regformats/i386/i386-mpx-linux.dat: Remove.
5633         * regformats/i386/i386.dat: Remove.
5634         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5635         * regformats/i386/x32-avx-linux.dat: Remove.
5636         * regformats/i386/x32-linux.dat: Remove.
5637
5638 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5639
5640         * aarch64-tdep.c: Remove xml self tests.
5641         * amd64-linux-tdep.c: Likewise.
5642         * amd64-tdep.c: Likewise.
5643         * i386-linux-tdep.c: Likewise.
5644         * i386-tdep.c: Likewise.
5645
5646 2019-07-03  Pedro Alves  <palves@redhat.com>
5647
5648         PR cli/24732
5649         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5650         (pipe_cmd_option_defs): New.
5651         (make_pipe_cmd_options_def_group): New.
5652         (pipe_command): Use gdb::option::process_options.
5653         (pipe_command_completer): New function.
5654         (_initialize_cli_cmds): Install completer for "pipe" command.
5655
5656 2019-07-03  Pedro Alves  <palves@redhat.com>
5657
5658         * cli/cli-option.c (union option_value) <string>: New field.
5659         (struct option_def_and_value): Add ctor, move ctor, dtor and
5660         use DISABLE_COPY_AND_ASSIGN.
5661         (option_def_and_value::clear_value): New.
5662         (parse_option, save_option_value_in_ctx, get_val_type_str)
5663         (add_setshow_cmds_for_options): Handle var_string.
5664         * cli-option.h (union option_def::var_address) <string>: New
5665         field.
5666         (struct string_option_def): New.
5667         * maint-test-options.c (struct test_options_opts): Add default
5668         ctor and use DISABLE_COPY_AND_ASSIGN.
5669         <string_opt>: New field.
5670         (test_options_opts::~test_options_opts): New.
5671         (test_options_opts::dump): Also dump "-string".
5672         (test_options_option_defs): Install "string.
5673
5674 2019-07-03  Pedro Alves  <palves@redhat.com>
5675
5676         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5677         option_value with a null enumeration.
5678         (complete_options): Save the option values in the context.
5679         (save_option_value_in_ctx): New, factored out from ...
5680         (process_options): ... here.
5681         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5682         of the function.
5683         * maint-test-options.c (test_options_opts::dump): New, factored
5684         out from ...
5685         (maintenance_test_options_command_mode): ... here.
5686         (maintenance_test_options_command_completion_result): Delete.
5687         (maintenance_test_options_command_completion_text): Update
5688         comment.
5689         (maintenance_show_test_options_completion_result): Change
5690         prototype.  Just print
5691         maintenance_test_options_command_completion_text.
5692         (save_completion_result): New.
5693         (maintenance_test_options_completer_mode): Pass options context to
5694         complete_options, and then save a dump.
5695         (_initialize_maint_test_options): Use add_cmd to install "maint
5696         show test-options-completion-result".
5697
5698 2019-07-03  Pedro Alves  <palves@redhat.com>
5699
5700         * NEWS (New commands): Mention "with" and "maint with".
5701         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5702         (with_command, with_command_completer): New.
5703         (pipe_command): Adjust to new repeat_previous
5704         interface.
5705         (_initialize_cli_cmds): Install the "with" command and its "w"
5706         alias.
5707         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5708         declarations.
5709         * cli/cli-setshow.c (parse_cli_var_uinteger)
5710         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5711         argument strings for all var_types.
5712         (get_setshow_command_value_string): New, factored out from ...
5713         (do_show_command): ... this.
5714         * cli/cli-setshow.h: Include <string>.
5715         (get_setshow_command_value_string): Declare.
5716         * command.h (repeat_previous): Now returns const char *.  Adjust
5717         comment.
5718         * maint.c: Include "cli/cli-cmds.h".
5719         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5720         (_initialize_maint_cmds): Register the "maintenance with" command.
5721         * top.c (repeat_previous): Move bits from pipe_command here:
5722         Return the saved command line, if any; error out if there's no
5723         command to relaunch.
5724
5725 2019-07-03  Pedro Alves  <palves@redhat.com>
5726
5727         * NEWS (New commands): Mention "maint set/show test-settings"
5728         instead of "maint test-settings".
5729         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5730         (maintenance_test_settings_set_list): Rename to ...
5731         (maintenance_set_test_settings_list): ... this.
5732         (maintenance_test_settings_show_list): Rename to  ...
5733         (maintenance_show_test_settings_list): ... this.
5734         (maintenance_test_settings_cmd): Delete.
5735         (maintenance_test_settings_set_cmd): ...
5736         (maintenance_set_test_settings_cmd): ... this.
5737         (maintenance_test_settings_show_cmd): ...
5738         (maintenance_show_test_settings_cmd): ... this.
5739         (maintenance_test_settings_show_value_cmd):
5740         (maintenance_show_test_settings_value_cmd): ... this.
5741         (_initialize_maint_test_settings): No longer install the "maint
5742         test-settings" prefix command.  Rename "maint test-settings set"
5743         to "maint set test-settings", and "maint test-settings show" to
5744         "maint show test-settings".  Adjust all subcommands.
5745
5746 2019-07-03  Pedro Alves  <palves@redhat.com>
5747
5748         * maint-test-settings.c: Fix file's intro comment.  Replace all
5749         references to "test-options" with references to "test-settings",
5750         in comments.
5751
5752 2019-07-03  Pedro Alves  <palves@redhat.com>
5753
5754         * maint-test-settings.c (maintenance_test_settings_xxx)
5755         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5756         New.
5757         (maintenance_test_settings_enums): Use them.
5758         (maintenance_test_settings_enum): Default to
5759         maintenance_test_settings_xxx.
5760         (_initialize_maint_test_settings): Initialize
5761         MAINTENANCE_TEST_SETTINGS_FILENAME.
5762
5763 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5764
5765         * breakpoint.h (remove_breakpoints_inf): Change return type to
5766         void, move function documentation here.
5767         * breakpoint.c (remove_breakpoints_inf): Change return type to
5768         void, move function documentation to header.
5769
5770 2019-07-02  Pedro Alves  <palves@redhat.com>
5771
5772         * NEWS (Completion improvements): Mention "info threads".
5773         * thread.c (struct info_threads_opts, info_threads_option_defs)
5774         (make_info_threads_options_def_group): New.
5775         (info_threads_command): Use gdb::option::process_options.
5776         (info_threads_command_completer): New.
5777         (_initialize_thread): Use gdb::option::build_help to build the
5778         help text for "info threads".
5779
5780 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5781
5782         * defs.h (generic_load): Move from here...
5783         * symfile.h (generic_load): ... to here.  Rename name parameter
5784         to args.
5785         * symfile.c (generic_load): Add comment.
5786
5787 2019-07-01  Tom Tromey  <tromey@adacore.com>
5788
5789         * dwarf2read.c
5790         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5791         declaration of without_params.  Fix formatting.
5792
5793 2019-07-01  Tom Tromey  <tromey@adacore.com>
5794
5795         * ada-exp.y (find_primitive_type): Update.
5796         * ada-lang.h (ada_lookup_symbol): Update.
5797         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5798         parameter.
5799         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5800
5801 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5802
5803         PR breakpoints/24541
5804         * gdbarch.c: Regenerate.
5805         * gdbarch.h: Regenerate.
5806         * gdbarch.sh: Add 'stap_adjust_register'.
5807         * i386-tdep.c: Include '<unordered_set>'.
5808         (i386_stap_adjust_register): New function.
5809         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5810         * stap-probe.c (stap_parse_register_operand): Call
5811         'gdbarch_stap_adjust_register'.
5812
5813 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5814
5815         PR python/24742
5816         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5817         * python/python.c (do_start_initialization): Use 'xmalloc'
5818         instead of 'PyMem_Malloc'.
5819
5820 2019-06-28  Tom Tromey  <tromey@adacore.com>
5821
5822         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5823         for Ada.
5824
5825 2019-06-27  Tom Tromey  <tromey@adacore.com>
5826
5827         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5828         objfile_key.
5829         (arm_find_mapping_symbol, arm_record_special_symbol)
5830         (_initialize_arm_tdep): Update.
5831         (arm_objfile_data_free): Remove.
5832
5833 2019-06-27  Tom Tromey  <tromey@adacore.com>
5834
5835         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5836         to cp_print_static_field.
5837
5838 2019-06-26  Tom Tromey  <tromey@adacore.com>
5839
5840         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5841         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5842         declare.
5843
5844 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5845
5846         * features/aarch64-core.c (create_feature_aarch64_core):
5847         Regenerate.
5848         * features/aarch64-core.xml: Add cpsr flags.
5849
5850 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5851
5852         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5853         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5854
5855 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5856
5857         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5858         field.
5859         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5860         use.
5861         (arm_record_special_symbol): Don't insert new symbol in sorted
5862         position, push it at the end.
5863
5864 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5865
5866         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5867         (arm_mapping_symbol_s): Remove.
5868         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5869         (arm_mapping_symbol_vec): New typedef.
5870         (struct arm_per_objfile): Add constructor.
5871         <section_maps>: Change type to
5872         std::unique_ptr<arm_mapping_symbol_vec[]>.
5873         (arm_compare_mapping_symbols): Remove.
5874         (arm_find_mapping_symbol): Adjust to section_maps type change.
5875         (arm_objfile_data_free): Call delete on arm_per_objfile.
5876         (arm_record_special_symbol): Adjust to section_maps type change.
5877         Allocate arm_per_objfile with new.
5878
5879 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5880
5881         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5882         with the command prefix.
5883
5884 2019-06-25  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5887         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5888
5889 2019-06-25  Tom Tromey  <tom@tromey.com>
5890
5891         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5892         type.
5893         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5894         protected.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-winsource.c
5899         (tui_source_window_base::set_is_exec_point_at): Add check against
5900         LOA_ADDRESS.
5901
5902 2019-06-25  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-source.c (tui_set_source_content): Don't check before
5905         xfree.
5906         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5907
5908 2019-06-25  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-winsource.h (tui_update_source_window_as_is)
5911         (tui_alloc_source_buffer, tui_line_is_displayed)
5912         (tui_addr_is_displayed): Change type of win_info.
5913         * tui/tui-winsource.c (tui_update_source_window_as_is)
5914         (tui_clear_source_content, tui_show_source_line)
5915         (tui_show_source_content, tui_source_window_base::refill)
5916         (tui_source_window_base::set_is_exec_point_at)
5917         (tui_source_window_base::set_is_exec_point_at)
5918         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5919         (tui_alloc_source_buffer, tui_line_is_displayed)
5920         (tui_addr_is_displayed): Change type of win_info.  Update.
5921         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5922         (tui_source_window_base::do_make_visible_with_new_height):
5923         Update.
5924         * tui/tui-source.c (tui_set_source_content)
5925         (tui_set_source_content_nil)
5926         (tui_source_window::do_scroll_vertical): Update.
5927         * tui/tui-layout.c (show_layout): Update.
5928         * tui/tui-disasm.c (tui_set_disassem_content)
5929         (tui_disasm_window::do_scroll_vertical): Update.
5930         * tui/tui-data.h (tui_win_content): Remove.
5931         (struct tui_gen_win_info) <content, content_size>: Remove.
5932         (struct tui_source_element): Add initializers and destructor.
5933         (union tui_which_element, struct tui_win_element): Remove.
5934         (struct tui_source_window_base) <content>: New field.
5935         (struct tui_data_window): Remove destructor.
5936         (tui_alloc_content, tui_free_win_content)
5937         (tui_free_all_source_wins_content): Don't declare.
5938         * tui/tui-data.c (tui_initialize_static_data): Update.
5939         (init_content_element, tui_alloc_content): Remove.
5940         (~tui_gen_win_info): Update.
5941         (~tui_data_window, tui_free_all_source_wins_content)
5942         (tui_free_win_content, free_content, free_content_elements):
5943         Remove.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-winsource.h (tui_clear_source_content)
5948         (tui_erase_source_content, tui_show_source_content): Change type
5949         of win_info.
5950         * tui/tui-winsource.c (tui_clear_source_content)
5951         (tui_erase_source_content, tui_show_source_content): Change type
5952         of win_info.
5953         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5954         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5955         win_info.
5956         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5957         win_info.
5958         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5959
5960 2019-06-25  Tom Tromey  <tom@tromey.com>
5961
5962         * tui/tui-winsource.c (tui_clear_source_content)
5963         (tui_source_window_base::set_is_exec_point_at): Update.
5964         * tui/tui-source.c (tui_set_source_content_nil): Update.
5965         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5966         a bool.
5967         * tui/tui-data.c (init_content_element): Update.
5968
5969 2019-06-25  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5972         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5973         * tui/tui-layout.c (init_and_make_win): Update.
5974         * tui/tui.h (enum tui_win_type): Update.
5975         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5976         tui_win_is_auxillary.
5977         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5978         tui_win_is_auxillary.
5979
5980 2019-06-25  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5983         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5984         (tui_delete_data_content_windows, tui_display_all_data)
5985         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5986         Update.
5987         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5988         * tui/tui-regs.c (tui_last_regs_line_no)
5989         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5990         (tui_show_registers): Update.
5991         (tui_show_register_group): Return void.  Update.
5992         (tui_display_registers_from, tui_display_reg_element_at_line)
5993         (tui_display_registers_from_line, tui_check_register_values):
5994         Update.
5995         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5996         member.
5997         (struct tui_data_window) <regs_content>: Now a std::vector.
5998         <regs_content_count>: Remove.
5999         (tui_add_content_elements, tui_free_data_content): Don't declare.
6000         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6001         (init_content_element): Remove DATA_WIN case.  Add assert.
6002         (tui_add_content_elements): Remove.
6003         (tui_data_window): Update.
6004         (tui_free_data_content): Remove.
6005         (free_content_elements): Remove DATA_WIN case.
6006
6007 2019-06-25  Tom Tromey  <tom@tromey.com>
6008
6009         * tui/tui-data.c (tui_data_item_window): Update.
6010         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6011         * tui/tui-windata.c (tui_display_all_data)
6012         (tui_display_data_from_line): Update.
6013         (tui_check_data_values): Remove.
6014         * tui/tui-regs.c (tui_show_register_group)
6015         (tui_display_reg_element_at_line): Update.
6016         * tui/tui-hooks.c (tui_register_changed)
6017         (tui_refresh_frame_and_register_information): Call
6018         tui_check_register_values.
6019         * tui/tui-data.h (struct tui_data_window) <data_content,
6020         data_content_count, data_type>: Remove.
6021         (enum tui_data_type): Remove.
6022
6023         * tui/tui-data.c (tui_data_window::clear_detail)
6024         (~tui_data_window): Update.
6025
6026 2019-06-25  Tom Tromey  <tom@tromey.com>
6027
6028         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6029         declare.
6030         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6031         Rename from tui_first_data_item_displayed.  Update.
6032         (tui_data_window::refresh_all)
6033         (tui_data_window::do_scroll_vertical): Update.
6034         * tui/tui-data.h (struct tui_data_window)
6035         <first_data_item_displayed>: Declare new method.
6036
6037 2019-06-25  Tom Tromey  <tom@tromey.com>
6038
6039         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6040         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6041         contents...
6042         (tui_initialize_static_data): ...here.
6043
6044 2019-06-25  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6047         (tui_display_registers_from, tui_check_register_values): Update.
6048         (tui_display_register): Remove win_info parameter; update.
6049         (tui_get_register): Change type of parameters.
6050         * tui/tui-data.h (struct tui_data_element): Remove.
6051         (union tui_which_element) <data>: Remove.
6052         <data_window>: Change type.
6053         (struct tui_data_item_window): New.
6054         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6055         case.  Add assert.
6056         (~tui_data_item_window): New destructor.
6057         (free_content_elements): Remove DATA_ITEM_WIN case.
6058
6059 2019-06-25  Tom Tromey  <tom@tromey.com>
6060
6061         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6062         Remove.
6063
6064 2019-06-25  Tom Tromey  <tom@tromey.com>
6065
6066         * tui/tui-data.h (struct tui_command_element): Remove.
6067         (union tui_which_element) <command>: Remove.
6068         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6069         assert.
6070         (free_content_elements): Remove CMD_WIN case.
6071
6072 2019-06-25  Tom Tromey  <tom@tromey.com>
6073
6074         * tui/tui-layout.c (tui_set_layout): Update.
6075         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6076         * tui/tui-data.c (layout_def): Update.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6081         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6082         (tui_source_window_base::set_new_height): Update.
6083         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6084         Update.
6085         (tui_set_locator_fullname, tui_set_locator_info)
6086         (tui_show_frame_info): Update.
6087         * tui/tui-source.c (tui_set_source_content)
6088         (tui_source_is_displayed): Update.
6089         * tui/tui-layout.c (show_source_disasm_command, show_data)
6090         (show_source_or_disasm_and_command): Update.
6091         * tui/tui-disasm.c (tui_set_disassem_content)
6092         (tui_get_begin_asm_address): Update.
6093         * tui/tui-data.h (struct tui_locator_element): Remove.
6094         (union tui_which_element) <locator>: Remove.
6095         (struct tui_locator_window): New.
6096         (tui_locator_win_info_ptr): Change return type.
6097         * tui/tui-data.c (_locator): Change type.
6098         (tui_locator_win_info_ptr): Change return type.
6099         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6100         (tui_alloc_content): Add assert.
6101
6102 2019-06-25  Tom Tromey  <tom@tromey.com>
6103
6104         * tui/tui-winsource.c
6105         (tui_exec_info_window::maybe_allocate_content): New method.
6106         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6107         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6108         (make_source_or_disasm_window): Add cast.
6109         * tui/tui-data.h (union tui_which_element) <simple_string>:
6110         Remove.
6111         (struct tui_source_info): New.
6112         (struct tui_source_window_base) <execution_info>: Change type.
6113         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6114         case, and add assert.
6115         (tui_alloc_content): Add assert.
6116
6117 2019-06-25  Tom Tromey  <tom@tromey.com>
6118
6119         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6120         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6121         * tui/tui-data.c (tui_alloc_win_info): Remove.
6122
6123 2019-06-25  Tom Tromey  <tom@tromey.com>
6124
6125         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6126         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6127         can_highlight.
6128
6129 2019-06-25  Tom Tromey  <tom@tromey.com>
6130
6131         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6132         make_visible_with_new_height method.
6133         (tui_win_info::make_visible_with_new_height): New method.
6134         (tui_source_window_base::do_make_visible_with_new_height)
6135         (tui_data_window::do_make_visible_with_new_height)
6136         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6137         (make_visible_with_new_height): Remove.
6138         (tui_resize_all, tui_adjust_win_heights): Use
6139         make_visible_with_new_height method.
6140         * tui/tui-data.h (struct tui_win_info)
6141         <do_make_visible_with_new_height, make_visible_with_new_height>:
6142         New methods.
6143         (struct tui_source_window_base, struct tui_data_window)
6144         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6145         methods.
6146
6147 2019-06-25  Tom Tromey  <tom@tromey.com>
6148
6149         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6150         method.
6151         (update_tab_width): Call update_tab_width method.
6152         * tui/tui-data.h (struct tui_win_info)
6153         (struct tui_source_window_base) <update_tab_width>: New methods.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6158         parameter.
6159         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6160         parameter.
6161         (tui_gen_win_info::make_visible): Update.
6162         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6163         parameter.
6164         * tui/tui-data.h (enum tui_box): New enum.
6165         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6166
6167 2019-06-25  Tom Tromey  <tom@tromey.com>
6168
6169         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6170         init_and_make_win for EXEC_INFO_WIN.
6171         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6172         longer inline.
6173         (struct tui_win_info) <~tui_win_info>: Inline.
6174         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6175         Don't declare.
6176         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6177         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6178         Remove.
6179         (tui_initialize_static_data): Update.
6180         (~tui_gen_win_info): Handle more cleanup here.
6181         (~tui_source_window_base): Delete "execution_info".
6182         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6183
6184 2019-06-25  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-layout.c (make_command_window): Don't set
6187         can_highlight.
6188         (show_source_disasm_command): Call the reset method.
6189         (show_data): Don't set can_highlight.  Call the reset method.
6190         (tui_gen_win_info::reset): Rename from init_gen_win_info
6191         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6192         (show_source_or_disasm_and_command): Call the reset method.
6193         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6194         (struct tui_cmd_window): Set can_highlight.
6195
6196 2019-06-25  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6199         from make_visible.
6200         (tui_make_visible, tui_make_invisible): Rewrite.
6201         (tui_win_info::make_visible): Remove.
6202         (tui_source_window_base::make_visible): Update.
6203         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6204         method.  Moved from...
6205         (struct tui_win_info) <make_visible>: ...here.
6206
6207 2019-06-25  Tom Tromey  <tom@tromey.com>
6208
6209         * tui/tui-winsource.c
6210         (tui_source_window_base::do_scroll_horizontal): Remove direction
6211         parameter.
6212         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6213         direction parameter.
6214         * tui/tui-win.c (tui_win_info::forward_scroll)
6215         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6216         (tui_win_info::right_scroll): Update.
6217         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6218         direction parameter.
6219         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6220         direction parameter.
6221         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6222         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6223         Remove direction parameter.
6224         (struct tui_source_window_base, struct tui_source_window)
6225         (struct tui_disasm_window, struct tui_data_window)
6226         (struct tui_cmd_window): Update.
6227
6228 2019-06-25  Tom Tromey  <tom@tromey.com>
6229
6230         * tui/tui-winsource.h (tui_set_exec_info_content)
6231         (tui_show_exec_info_content, tui_erase_exec_info_content)
6232         (tui_clear_exec_info_content, tui_update_exec_info): Change
6233         argument to tui_source_window_base.
6234         * tui/tui-winsource.c (tui_set_exec_info_content)
6235         (tui_show_exec_info_content, tui_erase_exec_info_content)
6236         (tui_clear_exec_info_content, tui_update_exec_info): Change
6237         argument to tui_source_window_base.
6238
6239 2019-06-25  Tom Tromey  <tom@tromey.com>
6240
6241         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6242         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6243
6244 2019-06-25  Tom Tromey  <tom@tromey.com>
6245
6246         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6247         check.
6248
6249 2019-06-25  Tom Tromey  <tom@tromey.com>
6250
6251         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6252         type to void.
6253         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6254         type to void.
6255         * tui/tui-source.c (tui_set_source_content): Update.
6256         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6257
6258 2019-06-25  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-win.c (window_name_completer, tui_set_focus)
6261         (tui_all_windows_info): Use name method.
6262         * tui/tui-data.h (struct tui_gen_win_info)
6263         (struct tui_source_window, struct tui_disasm_window)
6264         (struct tui_data_window, struct tui_cmd_window) <name>: New
6265         method.
6266         (tui_win_name): Don't declare.
6267         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6268         (tui_win_name): Remove.
6269
6270 2019-06-25  Tom Tromey  <tom@tromey.com>
6271
6272         * tui/tui-winsource.h (tui_update_source_window)
6273         (tui_update_source_window_as_is): Change parameter type.
6274         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6275         to be a tui_source_window_base.
6276         (tui_update_source_window_as_is): Likewise.
6277         * tui/tui-win.c (make_visible_with_new_height): Update.
6278
6279 2019-06-25  Tom Tromey  <tom@tromey.com>
6280
6281         * tui/tui-winsource.c (tui_erase_source_content)
6282         (tui_show_source_content, tui_show_exec_info_content)
6283         (tui_erase_exec_info_content): Use refresh_window method.
6284         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6285         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6286         from tui_refresh_win.
6287         (tui_data_window::refresh_window): New method.
6288         (tui_win_info::refresh, tui_source_window_base::refresh)
6289         (tui_refresh_all): Use refresh_window method.
6290         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6291         method.
6292         * tui/tui-regs.c (tui_display_register): Call refresh_window
6293         method.
6294         * tui/tui-layout.c (show_source_disasm_command)
6295         (show_source_or_disasm_and_command): Call refresh_window method.
6296         * tui/tui-data.h (struct tui_gen_win_info)
6297         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6298         New method.
6299
6300 2019-06-25  Tom Tromey  <tom@tromey.com>
6301
6302         * tui/tui.c (tui_rl_other_window, tui_enable)
6303         (tui_is_window_visible, tui_get_command_dimension): Update.
6304         * tui/tui-winsource.c (tui_update_source_window_as_is)
6305         (tui_clear_source_content, tui_erase_source_content)
6306         (tui_show_source_line, tui_source_window_base::refill)
6307         (tui_source_window_base::do_scroll_horizontal)
6308         (tui_source_window_base::set_is_exec_point_at)
6309         (tui_update_breakpoint_info, tui_set_exec_info_content)
6310         (tui_alloc_source_buffer, tui_line_is_displayed)
6311         (tui_addr_is_displayed): Update.
6312         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6313         (tui_check_and_display_highlight_if_needed)
6314         (tui_win_info::make_visible, tui_win_info::refresh)
6315         (tui_refresh_all): Update.
6316         * tui/tui-windata.c (tui_first_data_item_displayed)
6317         (tui_delete_data_content_windows, tui_erase_data_content)
6318         (tui_display_all_data, tui_data_window::refresh_all)
6319         (tui_check_data_values): Update.
6320         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6321         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6322         (tui_win_info::backward_scroll, tui_refresh_all_win)
6323         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6324         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6325         (tui_source_window_base::set_new_height)
6326         (tui_data_window::set_new_height)
6327         (make_invisible_and_set_new_height)
6328         (make_visible_with_new_height, new_height_ok)
6329         (parse_scrolling_args): Update.
6330         * tui/tui-stack.c (tui_show_frame_info): Update.
6331         * tui/tui-source.c (tui_set_source_content)
6332         (tui_set_source_content_nil, tui_source_is_displayed)
6333         (tui_source_window::do_scroll_vertical): Update.
6334         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6335         (tui_display_registers_from, tui_display_reg_element_at_line)
6336         (tui_check_register_values, tui_reg_command): Update.
6337         * tui/tui-layout.c (tui_default_win_height)
6338         (show_source_disasm_command, show_data, init_and_make_win)
6339         (show_source_or_disasm_and_command): Update.
6340         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6341         (tui_redisplay_readline, tui_mld_flush)
6342         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6343         (tui_getc): Update.
6344         * tui/tui-disasm.c (tui_set_disassem_content)
6345         (tui_disasm_window::do_scroll_vertical): Update.
6346         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6347         Now virtual.
6348         (struct tui_win_info): Derive from tui_gen_win_info.
6349         <~tui_win_info>: Mark as override.
6350         <generic>: Remove member.
6351         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6352         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6353         (~tui_data_window, ~tui_win_info)
6354         (tui_free_all_source_wins_content): Update.
6355         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6356
6357 2019-06-25  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-layout.c (init_and_make_win): Use new.
6360         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6361         destructor, initializers.
6362         (tui_alloc_generic_win_info): Don't declare.
6363         * tui/tui-data.c (_locator): Add argument to constructor.
6364         (source_win, disasm_win): New globals.
6365         (exec_info): Remove.
6366         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6367         Update.
6368         (tui_alloc_generic_win_info): Remove.
6369         (init_content_element): Use new.
6370         (tui_win_info::tui_win_info): Update.
6371         (free_content_elements) <case DATA_WIN>: Use delete.
6372
6373 2019-06-25  Tom Tromey  <tom@tromey.com>
6374
6375         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6376         * tui/tui-windata.c (tui_first_data_item_displayed)
6377         (tui_delete_data_content_windows): Update.
6378         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6379         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6380         (tui_display_registers_from, tui_check_register_values): Update.
6381         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6382         pointer.
6383         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6384         window.
6385         (tui_free_data_content): Update.
6386         (free_content_elements) <case DATA_WIN>: Free the window.
6387
6388 2019-06-25  Tom Tromey  <tom@tromey.com>
6389
6390         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6391         Update.
6392         * tui/tui-layout.c (make_command_window)
6393         (show_source_disasm_command, show_data, init_and_make_win)
6394         (show_source_or_disasm_and_command): Update.
6395         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6396         method.
6397         <can_highight, is_highlighted>: Now bool.
6398         (tui_set_win_highlight): Don't declare.
6399         * tui/tui-data.c (tui_set_win_highlight): Remove.
6400
6401 2019-06-25  Tom Tromey  <tom@tromey.com>
6402
6403         * tui/tui-wingeneral.c (make_visible): Remove check of window
6404         type.
6405
6406 2019-06-25  Tom Tromey  <tom@tromey.com>
6407
6408         * tui/tui-win.c (tui_win_info::max_height)
6409         (tui_cmd_window::max_height): New methods.
6410         (new_height_ok): Call max_height.
6411         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6412         <max_height>: New method.
6413
6414 2019-06-25  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-win.c (tui_source_window_base::set_new_height)
6417         (tui_data_window::set_new_height): New methods.
6418         (make_invisible_and_set_new_height): Call set_new_height method.
6419         * tui/tui-data.h (struct tui_win_info)
6420         (struct tui_source_window_base, struct tui_data_window)
6421         <set_new_height>: New method.
6422
6423 2019-06-25  Tom Tromey  <tom@tromey.com>
6424
6425         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6426         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6427         tui_refresh_data_win.
6428         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6429         method.
6430         (tui_refresh_all_win): Call the refresh_all method.
6431         (tui_set_focus): Likewise.
6432         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6433         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6434         Likewise.
6435
6436 2019-06-25  Tom Tromey  <tom@tromey.com>
6437
6438         * tui/tui-winsource.h (tui_refill_source_window)
6439         (tui_set_is_exec_point_at): Don't declare.
6440         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6441         (tui_source_window_base::refill): Rename from
6442         tui_refill_source_window.
6443         (tui_source_window_base::do_scroll_horizontal): Update.
6444         (tui_source_window_base::set_is_exec_point_at): Rename from
6445         tui_set_is_exec_point_at.
6446         (tui_update_all_breakpoint_info): Update.
6447         * tui/tui-stack.c (tui_show_frame_info): Update.
6448         * tui/tui-layout.c (show_data): Add cast.
6449         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6450         * tui/tui-data.h (struct tui_source_window_base) <refill,
6451         set_is_exec_point_at>: New methods.
6452         (tui_source_windows, tui_add_to_source_windows): Update types.
6453         (tui_add_to_source_windows): Remove redundant declaration.
6454         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6455         (tui_source_windows): Change return type.
6456         (tui_clear_source_windows_detail): Update.
6457         (tui_add_to_source_windows): Change type of parameter.
6458         (tui_free_all_source_wins_content): Update.
6459
6460 2019-06-25  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-wingeneral.c (tui_win_info::refresh)
6463         (tui_source_window_base::refresh): New methods.
6464         (tui_refresh_all): Call the refresh method.
6465         * tui/tui-data.h (struct tui_win_info)
6466         (struct tui_source_window_base) <refresh>: New method.
6467
6468 2019-06-25  Tom Tromey  <tom@tromey.com>
6469
6470         * tui/tui.h (tui_is_window_visible): Return bool.
6471         * tui/tui.c (tui_is_window_visible): Return bool.
6472         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6473         (tui_make_visible, tui_make_invisible)
6474         (tui_win_info::make_visible)
6475         (tui_source_window_base::make_visible, make_all_visible)
6476         (tui_make_all_visible, tui_make_all_invisible): Update.
6477         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6478         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6479         bool.
6480         (struct tui_win_info, struct tui_source_window_base)
6481         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6482         * tui/tui-data.c (tui_init_generic_part): Update.
6483
6484 2019-06-25  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6487         (tui_source_window_base::make_visible): New methods.
6488         (make_all_visible): Make method call.
6489         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6490         (struct tui_source_window_base, struct tui_cmd_window): Override
6491         make_visible.
6492         (tui_win_is_source_type): Don't declare.
6493         * tui/tui-data.c (tui_win_is_source_type): Remove.
6494
6495 2019-06-25  Tom Tromey  <tom@tromey.com>
6496
6497         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6498         NULL check.
6499
6500 2019-06-25  Tom Tromey  <tom@tromey.com>
6501
6502         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6503         Inline constructor.  Add initializers for members.
6504         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6505         constructors; now inline in class.
6506
6507 2019-06-25  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-regs.c (tui_show_registers): Update.
6510         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6511         bool.
6512         * tui/tui-data.c (tui_data_window::clear_detail)
6513         (tui_data_window): Update.
6514
6515 2019-06-25  Tom Tromey  <tom@tromey.com>
6516
6517         * tui/tui-windata.c (tui_display_all_data)
6518         (tui_display_data_from_line, tui_display_data_from)
6519         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6520         Update.
6521         * tui/tui-regs.c (tui_last_regs_line_no)
6522         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6523         (tui_show_registers, tui_show_register_group)
6524         (tui_display_registers_from, tui_display_reg_element_at_line)
6525         (tui_display_registers_from_line, tui_check_register_values)
6526         (tui_reg_next, tui_reg_prev): Update.
6527         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6528         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6529         tui_data_window.
6530         (struct tui_win_info) <detail>: Remove.  Add new fields from
6531         tui_data_info.
6532         (TUI_DATA_WIN): Add cast.
6533         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6534         (~tui_data_window): Simplify.
6535
6536 2019-06-25  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-layout.c (show_source_disasm_command)
6539         (show_source_or_disasm_and_command): Update.
6540         * tui/tui-io.c (update_cmdwin_start_line)
6541         (tui_redisplay_readline): Update.
6542         * tui/tui-data.h (struct tui_command_info): Remove.
6543         (struct tui_win_info) <detail>: Remove command_info member.
6544         (struct tui_data_window) <start_line>: New member, from
6545         tui_command_info.
6546         (TUI_CMD_WIN): Add casts.
6547
6548 2019-06-25  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-winsource.c (tui_update_source_window)
6551         (tui_refill_source_window)
6552         (tui_source_window_base::do_scroll_horizontal)
6553         (tui_update_breakpoint_info, tui_set_exec_info_content)
6554         (tui_show_exec_info_content, tui_erase_exec_info_content)
6555         (tui_clear_exec_info_content): Update.
6556         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6557         Update.
6558         * tui/tui-win.c (make_invisible_and_set_new_height)
6559         (make_visible_with_new_height): Update.
6560         * tui/tui-source.c (tui_set_source_content)
6561         (tui_show_symtab_source): Update.
6562         * tui/tui-layout.c (extract_display_start_addr)
6563         (show_source_disasm_command, show_data)
6564         (make_source_or_disasm_window)
6565         (show_source_or_disasm_and_command): Update.
6566         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6567         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6568         "gdbarch".
6569         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6570         to tui_source_window_base.
6571         (struct tui_win_info) <detail>: Remove source_info member.
6572         (struct tui_source_window_base) <has_locator>: Inline.
6573         Move contents from tui_source_info; rename has_locator member to
6574         m_has_locator.
6575         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6576         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6577         header file.
6578         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6579         Simplify.
6580         (tui_free_all_source_wins_content): Cast to
6581         tui_source_window_base.
6582
6583 2019-06-25  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui-win.c (make_invisible_and_set_new_height)
6586         (make_visible_with_new_height): Call has_locator method.
6587         * tui/tui-layout.c (show_source_disasm_command, show_data)
6588         (show_source_or_disasm_and_command): Update for bool change.
6589         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6590         (tui_win_info) <has_locator>: New method.
6591         (struct tui_source_window_base) <has_locator>: New method.
6592         (tui_win_has_locator): Don't declare.
6593         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6594         from tui_win_has_locator.
6595         (tui_source_window_base): Use false, not FALSE.
6596
6597 2019-06-25  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6600         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6601         clear_detail method directly.
6602         (tui_clear_win_detail): Remove.
6603
6604 2019-06-25  Tom Tromey  <tom@tromey.com>
6605
6606         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6607         "this", not TUI_DISASM_WIN.
6608
6609 2019-06-25  Tom Tromey  <tom@tromey.com>
6610
6611         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6612         declare.
6613         * tui/tui-winsource.c
6614         (tui_source_window_base::do_scroll_horizontal): Rename from
6615         tui_horizontal_source_scroll.
6616         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6617         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6618         from tui_vertical_data_scroll.
6619         * tui/tui-win.h (tui_scroll): Don't declare.
6620         * tui/tui-win.c (tui_win_info::forward_scroll)
6621         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6622         (tui_win_info::right_scroll): Rename and update.
6623         (tui_scroll_forward_command, tui_scroll_backward_command)
6624         (tui_scroll_left_command, tui_scroll_right_command): Update.
6625         (tui_scroll): Remove.
6626         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6627         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6628         from tui_vertical_source_scroll.
6629         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6630         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6631         from tui_vertical_disassem_scroll.
6632         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6633         do_scroll_horizontal>: New methods.
6634         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6635         Likewise.
6636         (struct tui_source_window_base): Add do_scroll_horizontal.
6637         (struct tui_source_window, struct tui_disasm_window): Add
6638         do_scroll_vertical.
6639         (struct tui_data_window, struct tui_cmd_window): Add
6640         do_scroll_horizontal and do_scroll_vertical.
6641         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6642
6643 2019-06-25  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-data.h (struct tui_source_window_base): New struct.
6646         (struct tui_source_window): Derive from tui_source_window_base.
6647         (struct tui_disasm_window): New struct.
6648         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6649         from tui_source_window::clear_detail.
6650         (tui_source_window_base): Rename from tui_source_window.
6651         (~tui_source_window_base): Rename from ~tui_source_window.
6652         (tui_alloc_win_info): Create a tui_disasm_window.
6653
6654 2019-06-25  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui-data.h (struct tui_source_window)
6657         (struct tui_data_window): Declare destructors.
6658         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6659         destructors.
6660         (tui_win_info): Simplify.
6661
6662 2019-06-25  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui-winsource.c (tui_display_main)
6665         (tui_update_source_windows_with_addr)
6666         (tui_update_all_breakpoint_info): Update.
6667         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6668         (new_height_ok, parse_scrolling_args): Update.
6669         * tui/tui-stack.c (tui_show_frame_info): Update.
6670         * tui/tui-data.h (struct tui_list): Remove.
6671         (tui_source_windows): Return a reference to a std::vector.
6672         * tui/tui-data.c (source_windows): Now a std::vector.
6673         (tui_source_windows): Change return type.
6674         (tui_clear_source_windows): Rewrite.
6675         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6676         (tui_free_all_source_wins_content): Rewrite.
6677
6678 2019-06-25  Tom Tromey  <tom@tromey.com>
6679
6680         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6681         (struct tui_data_window, struct tui_cmd_window): Declare
6682         clear_detail method.
6683         * tui/tui-data.c (tui_source_window::clear_detail)
6684         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6685         methods.
6686         (tui_clear_win_detail): Simplify.
6687
6688 2019-06-25  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-layout.c (make_source_window, make_disasm_window)
6691         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6692         Return the new window.
6693         (show_source_disasm_command, show_data)
6694         (show_source_or_disasm_and_command): Update.
6695
6696 2019-06-25  Tom Tromey  <tom@tromey.com>
6697
6698         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6699         parameter.  Return the new window.
6700         (show_source_disasm_command): Update and remove NULL check.
6701         (show_source_or_disasm_and_command): Update.
6702
6703 2019-06-25  Tom Tromey  <tom@tromey.com>
6704
6705         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6706
6707 2019-06-25  Tom Tromey  <tom@tromey.com>
6708
6709         * tui/tui-data.h (struct tui_win_info): Make constructor
6710         protected.  Make destructor virtual.  Add initializers.
6711         (tui_source_window, tui_data_window, tui_cmd_window): New
6712         classes.
6713         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6714         constructor.  Add "type" parameter.
6715         (tui_source_window, tui_data_window, tui_cmd_window): New
6716         constructors.
6717         (tui_alloc_win_info): Instantiate the appropriate subclass.
6718
6719 2019-06-25  Tom Tromey  <tom@tromey.com>
6720
6721         * tui/tui-win.c (tui_resize_all): Use delete.
6722         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6723         destructor.
6724         (tui_free_window): Don't declare.
6725         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6726         Update.
6727
6728 2019-06-25  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui-data.h (struct tui_win_info): Add constructor.
6731         * tui/tui-data.c (tui_alloc_win_info): Use new.
6732         (tui_free_window): Use delete.
6733
6734 2019-06-22  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6737         declare.
6738         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6739
6740 2019-06-22  Tom Tromey  <tom@tromey.com>
6741
6742         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6743         declare.
6744         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6745
6746 2019-06-22  Tom de Vries  <tdevries@suse.de>
6747
6748         * dwarf2read.c (create_addrmap_from_aranges)
6749         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6750         instead of '%zu'.
6751
6752 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6753
6754         * dwarf2read.h (dwarf2_section_info_def): Remove.
6755         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6756         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6757         std::vector<dwarf2_section_info>.
6758         (struct dwo_file) <~dwo_file>: Remove.
6759         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6760         types field.
6761         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6762         (dwarf2_read_debug_names): Likewise.
6763         (create_debug_types_hash_table): Change parameter type to
6764         array_view, adjust code accordingly.
6765         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6766         (partial_die_info::fixup): Likewise.
6767         (determine_prefix): Likewise.
6768         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6769
6770 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6771
6772         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6773         gdb_bfd_ref_ptr.
6774         <~dwo_file>: Remove call to gdb_bfd_unref.
6775         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6776         gdb_bfd_ref_ptr::get.
6777
6778 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6779
6780         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6781         type to htab_up.
6782         * dwarf2read.c (struct dwo_file): Initialize fields.
6783         <~dwo_file>: New.
6784         (free_dwo_file): Remove, move content to ~dwo_file.
6785         (struct dwo_file_deleter): Remove.
6786         (dwo_file_up>: Remove custom deleter.
6787         (free_dwo_files): Remove.
6788         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6789         dwo_files.
6790         (process_skeletonless_type_units): Call unique_ptr::get.
6791         (allocate_dwo_file_hash_table): Add deleter to created hash
6792         table.  Change return type to htab_up.
6793         (lookup_dwo_file_slot): Don't memset dwo_file, call
6794         unique_ptr::get.
6795         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6796         (create_dwo_unit_in_dwp_v2): Likewise.
6797         (open_and_init_dwo_file): Likewise.
6798         (free_dwo_file_from_slot): Remove.
6799
6800 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6801
6802         * dwarf2read.h (struct dwarf2_section_info) <readin,
6803         is_virtual>: Change type to bool.
6804         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6805         true instead of 1.
6806
6807 2019-06-19  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-data.h (tui_init_content_element): Don't declare.
6810
6811 2019-06-19  Tom Tromey  <tom@tromey.com>
6812
6813         * tui/tui-data.h (tui_init_win_info): Don't declare.
6814
6815 2019-06-19  Tom de Vries  <tdevries@suse.de>
6816
6817         * dwarf2read.h (abstract_to_concrete): Change type to
6818         std::unordered_map<sect_offset, std::vector<sect_offset>,
6819         gdb::hash_enum<sect_offset>>.
6820
6821 2019-06-19  Tom Tromey  <tromey@adacore.com>
6822
6823         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6824         EVAL_AVOID_SIDE_EFFECTS specially.
6825
6826 2019-06-19  Tom Tromey  <tromey@adacore.com>
6827
6828         * source-cache.c (highlighter): New global.
6829         (source_cache::get_source_lines): Create a highlighter on demand.
6830
6831 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6832
6833         * defs.h (deprecated_interactive_hook): Delete declaration.
6834         * interps.c (clear_interpreter_hooks): Remove use of
6835         deprecated_interactive_hook.
6836         * top.c (deprecated_interactive_hook): Delete definition.
6837         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6838
6839 2019-06-18  Tom de Vries  <tdevries@suse.de>
6840
6841         PR gdb/24515
6842         * dwarf2read.h (abstract_to_concrete): Change type from
6843         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6844         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6845         * dwarf2read.c (read_variable): Update.
6846         (dwarf2_fetch_die_loc_sect_off): Update.
6847
6848 2019-06-17  Tom de Vries  <tdevries@suse.de>
6849
6850         PR gdb/24617
6851         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6852         accessing parent[parent_len - 1].
6853
6854 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6855
6856         PR gdb/24364
6857         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6858         call dtrace_process_dof with NULL dof.
6859
6860 2019-06-16  Tom de Vries  <tdevries@suse.de>
6861
6862         PR gdb/24445
6863         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6864
6865 2019-06-16  Tom Tromey  <tom@tromey.com>
6866
6867         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6868         (make_all_visible): Use address of member.
6869
6870 2019-06-16  Tom Tromey  <tom@tromey.com>
6871
6872         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6873         (tui_free_window, free_content, free_content_elements): Remove
6874         unnecessary cast.
6875         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6876         cast.
6877         * tui/tui-regs.c (tui_show_register_group)
6878         (tui_display_registers_from, tui_display_reg_element_at_line):
6879         Remove unnecessary cast.
6880
6881 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6882
6883         * linux-nat.c (normal_mask): Delete.
6884         (_initialize_linux_nat): Don't initialise normal_mask.
6885
6886 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6887
6888         PR gdb/24445
6889         * dwarf-index-write.h (write_psymtabs_to_index): Add
6890         dwz_basename parameter.
6891         * dwarf-index-write.c (write_gdbindex): Move file writing to
6892         write_gdbindex_1.  Change return type void.
6893         (assert_file_size): Move up, remove filename parameter.
6894         (write_gdbindex_1): New function.
6895         (write_debug_names): Change return type to void, call
6896         assert_file_size.
6897         (struct index_wip_file): New struct.
6898         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6899         file logic to index_wip_file.  Write index for dwz file if
6900         needed.
6901         (save_gdb_index_command): Pass basename of dwz file, if present.
6902         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6903         build-id of dwz file, if present.
6904         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6905         (dwarf2_get_dwz_file): Likewise.
6906         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6907         (dwarf2_get_dwz_file): Likewise.
6908
6909 2019-06-16  Tom Tromey  <tom@tromey.com>
6910
6911         * coffread.c (process_coff_symbol): Use xstrdup.
6912         * value.c (create_internalvar): Use xstrdup.
6913
6914 2019-06-16  Tom Tromey  <tom@tromey.com>
6915
6916         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6917         * breakpoint.c (stopin_command, stopat_command)
6918         (until_break_command, decode_location_default): Remove unnecessary
6919         cast.
6920         * utils.c (subset_compare): Remove unnecessary cast.
6921         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6922         cast.
6923         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6924         cast.
6925         * infcmd.c (path_command): Remove unnecessary cast.
6926         * coffread.c (decode_type): Remove unnecessary cast.
6927         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6928         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6929         * tui/tui-stack.c (tui_show_locator_content)
6930         (tui_show_frame_info): Remove unnecessary cast.
6931         * tui/tui-win.c (tui_scroll_forward_command)
6932         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6933         (parse_scrolling_args): Remove unnecessary cast.
6934         * tui/tui-data.c (init_win_info, tui_del_window)
6935         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6936         (free_content_elements): Remove unnecessary cast.
6937         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6938         unnecessary cast.
6939         * tui/tui-source.c (tui_set_source_content)
6940         (tui_vertical_source_scroll): Remove unnecessary cast.
6941         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6942         cast.
6943         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6944         * tui/tui-regs.c (tui_display_registers_from)
6945         (tui_display_register): Remove unnecessary cast.
6946         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6947         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6948         (make_visible): Remove unnecessary cast.
6949         * tui/tui-winsource.c (tui_erase_source_content)
6950         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6951         unnecessary cast.
6952         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6953         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6954         * stabsread.c (read_type, read_array_type, read_range_type):
6955         Remove unnecessary cast.
6956         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6957         (parse_symbol, parse_type, upgrade_type, parse_external)
6958         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6959         unnecessary cast.
6960         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6961
6962 2019-06-16  Tom Tromey  <tom@tromey.com>
6963
6964         * tui/tui-data.c (tui_alloc_generic_win_info)
6965         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6966         checks.
6967
6968 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6969             Andrew Burgess  <andrew.burgess@embecosm.com>
6970
6971         * f-typeprint.c (f_print_type): Don't return early for not
6972         associated or not allocated types.
6973         (f_type_print_varspec_suffix): Add print_rank parameter and print
6974         ranks of array types in case they dangling.
6975         (f_type_print_base): Add print_rank parameter.
6976
6977 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6978
6979         * NEWS: Mention new MI commands.
6980         * break-catch-throw.c (enum exception_event_kind): Move to
6981         breakpoint.h.
6982         (print_mention_exception_catchpoint): Output text as a single
6983         message.
6984         (catch_exception_command_1): Rename to...
6985         (catch_exception_event): ...this, make non-static, update header
6986         command, and change some parameter types.
6987         (catch_catch_command): Update for changes to
6988         catch_exception_command_1.
6989         (catch_throw_command): Likewise.
6990         (catch_rethrow_command): Likewise.
6991         * breakpoint.c (enum exception_event_kind): Delete.
6992         * breakpoint.h (enum exception_event_kind): Moved here from
6993         break-catch-throw.c.
6994         (catch_exception_event): Declare.
6995         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6996         (mi_cmd_catch_throw): New function.
6997         (mi_cmd_catch_rethrow): New function.
6998         (mi_cmd_catch_catch): New function.
6999         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7000         'catch-catch' entries.
7001         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7002         (mi_cmd_catch_rethrow): Declare.
7003         (mi_cmd_catch_catch): Declare.
7004
7005 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * annotate.c (annotate_source_line): Change return type to void,
7008         update implementation to match.
7009         * annotate.h (annotate_source_line): Change return type to void,
7010         update header comment.
7011         * stack.c (print_frame_info): Don't change what frame information
7012         is printed based on whether annotations are on or not.
7013
7014 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7017         (annotate_source): Make static.
7018         (annotate_source_line): Moved from source.c and renamed from
7019         identify_source_line.  Update the return type.
7020         * annotate.h (annotate_source): Delete declaration.
7021         (annotate_source_line): Declaration moved from source.h, and
7022         renamed from identify_source_line.  Return type updated.
7023         * source.c (identify_source_line): Moved to annotate.c and renamed
7024         to annotate_source_line.
7025         (info_line_command): Remove check of annotation_level.
7026         * source.h (identify_source_line): Move declaration to annotate.h
7027         and rename to annotate_source_line.
7028         * stack.c: Add 'annotate.h' include.
7029         (print_frame_info): Remove check of annotation_level before
7030         calling annotate_source_line.
7031
7032 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * source-cache.c (source_cache::get_plain_source_lines): Use
7035         open_source_file_with_line_charpos instead of just
7036         open_source_file, remove call to find_source_lines.
7037         (source_cache::get_source_lines): Likewise.
7038         * source.c (find_source_lines): Make static.
7039         (get_filename_and_charpos): Renamed into...
7040         (open_source_file_with_line_charpos): ..this along with changes to
7041         return a scoped_fd, and some other minor clean ups.
7042         (identify_source_line): Use open_source_file_with_line_charpos.
7043         (search_command_helper): Use open_source_file_with_line_charpos
7044         instead of just open_source_file, remove call to
7045         find_source_lines.
7046         * source.h (open_source_file_with_line_charpos): Declare new
7047         function.
7048         (find_source_lines): Delete declaration.
7049
7050 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * source.c (get_filename_and_charpos): Remove fullname
7053         parameter.
7054         (identify_source_line): Update call to get_filename_and_charpos.
7055
7056 2019-06-14  Tom Tromey  <tromey@adacore.com>
7057
7058         PR gdb/24502:
7059         * ui-style.h (skip_ansi_escape): Update comment.
7060         * ui-file.h (class no_terminal_escape_file): New class.
7061         * ui-file.c (no_terminal_escape_file::write)
7062         (no_terminal_escape_file::puts): New methods.
7063         * cli/cli-logging.c (handle_redirections): Use
7064         no_terminal_escape_file.
7065
7066 2019-06-14  Tom Tromey  <tromey@adacore.com>
7067
7068         * NEWS: Move convenience variable news above Python news.
7069
7070 2019-06-14  Tom Tromey  <tom@tromey.com>
7071
7072         * gnulib: Move directory to top-level.
7073         * configure.ac: Don't configure gnulib.
7074         * configure: Rebuild.
7075         * common/common-defs.h: Use new path to gnulib.
7076         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7077         (GNULIB_H): Remove.
7078         (INCGNU): Look in new gnulib location.
7079         (HFILES_NO_SRCDIR): Remove gnulib files.
7080         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7081         (generated_files): Remove GNULIB_H.
7082         ($(LIBGNU), all-lib): Remove targets.
7083         (distclean): Don't mention GNULIB_BUILDDIR.
7084         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7085
7086 2019-06-14  Tom Tromey  <tromey@adacore.com>
7087
7088         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7089         Warn if symbol file does not provide any symbols.
7090
7091 2019-06-14  Tom Tromey  <tromey@adacore.com>
7092
7093         * source.c (find_and_open_source): Respect basenames_may_differ.
7094
7095 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7096
7097         * annotate.c (annotate_breakpoints_invalid): Make use of
7098         scoped_restore_terminal_state.
7099         (annotate_frames_invalid): Likewise.
7100
7101 2019-06-14  Tom Tromey  <tromey@adacore.com>
7102
7103         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7104         allow assignment to an internalvar.
7105
7106 2019-06-14  Tom Tromey  <tromey@adacore.com>
7107
7108         * ada-lex.l: Allow "_" in attribute names.
7109
7110 2019-06-14  Tom Tromey  <tromey@adacore.com>
7111
7112         PR gdb/24653:
7113         * regcache.c (registers_changed): Don't call alloca.
7114         * top.c (execute_command): Don't call alloca.
7115
7116 2019-06-13  Pedro Alves  <palves@redhat.com>
7117
7118         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7119         'expression'.  When parsing an expression, error out if there's
7120         junk after "unlimited".
7121         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7122         (do_set_command): Adjust calls to is_unlimited_literal.
7123
7124 2019-06-13  Pedro Alves  <palves@redhat.com>
7125
7126         * compile/compile.c (make_compile_options_def_group): Add braces
7127         around array_view initializer.
7128         * thread.c (make_thread_apply_all_options_def_group)
7129         (make_thread_apply_all_options_def_group): Likewise.
7130
7131 2019-06-13  Pedro Alves  <palves@redhat.com>
7132
7133         * NEWS (New commands): Mention "maint test-options
7134         require-delimiter", "maint test-options unknown-is-error", "maint
7135         test-options unknown-is-operand" and "maint show
7136         test-options-completion-result".
7137         (New command options, command completion): New section.
7138         (Completion improvements): New section.
7139         Mention that you can abbreviate "unlimited".
7140
7141 2019-06-13  Pedro Alves  <palves@redhat.com>
7142
7143         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7144         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7145         * unittests/cli-utils-selftests.c (test_parse_flags)
7146         (test_parse_flags_qcs): Delete.
7147         (test_cli_utils): Don't call deleted functions.
7148
7149 2019-06-13  Pedro Alves  <palves@redhat.com>
7150
7151         * thread.c: Include "cli/cli-option.h".
7152         (tp_array_compar_ascending): Global.
7153         (tp_array_compar): Delete function.
7154         (tp_array_compar_ascending, tp_array_compar_descending): New
7155         functions.
7156         (ascending_option_def, qcs_flag_option_def)
7157         (thr_qcs_flags_option_defs)
7158         (make_thread_apply_all_options_def_group)
7159         (make_thread_apply_options_def_group): New.
7160         (thread_apply_all_command): Use gdb::option::process_options.
7161         (thread_apply_command_completer)
7162         (thread_apply_all_command_completer): New.
7163         (thread_apply_command): Use gdb::option::process_options.
7164         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7165         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7166         to generate help text of "thread apply".  Adjust "taas"'s help.
7167         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7168         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7169
7170 2019-06-13  Pedro Alves  <palves@redhat.com>
7171
7172         * thread.c (thread_apply_command): Check for invalid TID with
7173         isdigit instead of !isalpha.
7174
7175 2019-06-13  Pedro Alves  <palves@redhat.com>
7176
7177         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7178         (validate_flags_qcs): New.
7179         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7180         (validate_flags_qcs): Declare.
7181         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7182         (make_frame_apply_options_def_group): New.
7183         (frame_apply_command_count): Process options with
7184         gdb::option::process_options.
7185         (frame_apply_completer): New.
7186         (frame_apply_level_completer, frame_apply_all_completer)
7187         (frame_apply_completer): New.
7188         (_initialize_stack): Update help of "frame apply", "frame apply
7189         level", "frame apply all" and "faas" to mention supported options
7190         and install command completers.
7191         * stack.h (frame_apply_all_completer): Declare.
7192         * thread.c: Include "stack.h".
7193         (tfaas_command): Add "--".
7194         (_initialize_thread): Update help "tfaas" to mention supported
7195         options and install command completer.
7196
7197 2019-06-13  Pedro Alves  <palves@redhat.com>
7198
7199         * completer.c (complete_nested_command_line): New.
7200         (gdb_completion_word_break_characters_throw): Add assertion.
7201         * completer.h (complete_nested_command_line): Declare.
7202
7203 2019-06-13  Pedro Alves  <palves@redhat.com>
7204
7205         * stack.c (parse_backtrace_qualifiers): New.
7206         (backtrace_command): Use it.
7207         (backtrace_command_completer): Complete on qualifiers.
7208
7209 2019-06-13  Pedro Alves  <palves@redhat.com>
7210
7211         * frame.c: Include "cli/cli-option.h.
7212         (user_set_backtrace_options): New.
7213         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7214         Delete.
7215         (get_prev_frame): Adjust.
7216         (boolean_option_def, uinteger_option_def)
7217         (set_backtrace_option_defs): New.
7218         (_initialize_frame): Adjust and use
7219         gdb::option::add_setshow_cmds_for_options to install "set
7220         backtrace past-main" and "set backtrace past-entry".
7221         * frame.h: Include "cli/cli-option.h".
7222         (struct frame_print_options): Forward declare.
7223         (print_frame_arguments_all, print_frame_arguments_scalars)
7224         (print_frame_arguments_none): Declare.
7225         (print_entry_values): Delete declaration.
7226         (struct frame_print_options, user_frame_print_options): New.
7227         (struct set_backtrace_options): New.
7228         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7229         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7230         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7231         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7232         (list_args_or_locals): Add frame_print_options parameter.
7233         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7234         * python/py-framefilter.c (enumerate_args): Pass down
7235         USER_FRAME_PRINT_OPTIONS.
7236         * stack.c: Include "cli/cli-option.h".
7237         (print_frame_arguments_all, print_frame_arguments_scalars)
7238         (print_frame_arguments_none): Declare.
7239         (print_raw_frame_arguments, print_entry_values): Delete.
7240         (user_frame_print_options): New.
7241         (boolean_option_def, enum_option_def, frame_print_option_defs):
7242         New.
7243         (struct backtrace_cmd_options): New.
7244         (bt_flag_option_def): New.
7245         (backtrace_command_option_defs): New.
7246         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7247         (print_frame_arg, read_frame_arg, print_frame_args)
7248         (print_frame_info, print_frame): Add frame_print_options parameter
7249         and use it.
7250         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7251         (backtrace_command_1): Add frame_print_options and
7252         backtrace_cmd_options parameters and use them.
7253         (make_backtrace_options_def_group): New.
7254         (backtrace_command): Process command options with
7255         gdb::option::process_options.
7256         (backtrace_command_completer): New.
7257         (_initialize_stack): Extend "backtrace"'s help to mention
7258         supported options.  Install completer for "backtrace".
7259         Install some settings commands with add_setshow_cmds_for_options.
7260
7261 2019-06-13  Pedro Alves  <palves@redhat.com>
7262
7263         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7264         and that "set/show print raw frame-arguments" are now deprecated.
7265
7266         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7267         command.
7268         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7269         * stack.c (_initialize_stack): Install "set/show print
7270         raw-frame-arguments", and deprecate "set/show print raw
7271         frame-arguments".
7272         * valprint.c (_initialize_valprint): Deprecate "set/show print
7273         raw".
7274
7275 2019-06-13  Pedro Alves  <palves@redhat.com>
7276
7277         * compile/compile.c (struct compile_options): New.
7278         (compile_flag_option_def, compile_command_option_defs)
7279         (make_compile_options_def_group): New.
7280         (compile_file_command): Handle options with
7281         gdb::option::process_options.
7282         (compile_file_command_completer): New function.
7283         (compile_code_command): Handle options with
7284         gdb::option::process_options.
7285         (compile_code_command_completer): New function.
7286         (_initialize_compiler): Install completers for "compile code" and
7287         "compile file".  Mention available options in "compile code" and
7288         "compile code"'s help.
7289         * completer.c (advance_to_completion_word): New, factored out from
7290         ...
7291         (advance_to_expression_complete_word_point): ... this.
7292         (advance_to_filename_complete_word_point): New.
7293         * completer.h (advance_to_filename_complete_word_point): New
7294         declaration.
7295
7296 2019-06-13  Pedro Alves  <palves@redhat.com>
7297
7298         * compile/compile.c: Include "cli/cli-option.h".
7299         (compile_print_value): Scope data pointer is now a
7300         value_print_options pointer; adjust.
7301         (compile_print_command): Process options.  Scope data pointer is
7302         now a value_print_options pointer; adjust.
7303         (_initialize_compile): Update "compile print"'s help to include
7304         supported options.  Install a completer for "compile print".
7305         * cp-valprint.c (show_vtblprint, show_objectprint)
7306         (show_static_field_print): Delete.
7307         (_initialize_cp_valprint): Don't install "set print
7308         static-members", "set print vtbl", "set print object" here.
7309         * printcmd.c: Include "cli/cli-option.h" and
7310         "common/gdb_optional.h".
7311         (print_command_parse_format): Rework to fill in a
7312         value_print_options instead of a format_data.
7313         (print_value): Change parameter type from format_data pointer to
7314         value_print_options reference.  Adjust.
7315         (print_command_1): Process options.  Adjust to pass down a
7316         value_print_options.
7317         (print_command_completer): New.
7318         (_initialize_printcmd): Install print_command_completer as
7319         handle_brkchars completer for the "print" command.  Update
7320         "print"'s help to include supported options.
7321         * valprint.c: Include "cli/cli-option.h".
7322         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7323         here from cp-valprint.c.
7324         (boolean_option_def, uinteger_option_def)
7325         (value_print_option_defs, make_value_print_options_def_group):
7326         New.  Use gdb::option::add_setshow_cmds_for_options to install
7327         "set print elements", "set print null-stop", "set print repeats",
7328         "set print pretty", "set print union", "set print array", "set
7329         print address", "set print symbol", "set print array-indexes".
7330         * valprint.h: Include <string> and "cli/cli-option.h".
7331         (make_value_print_options_def_group): Declare.
7332         (print_value): Change parameter type from format_data pointer to
7333         value_print_options reference.
7334         (print_command_completer): Declare.
7335
7336 2019-06-13  Pedro Alves  <palves@redhat.com>
7337
7338         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7339         (COMMON_SFILES): Add maint-test-settings.c.
7340         * cli/cli-decode.c (boolean_enums): New global, factored out from
7341         ...
7342         (add_setshow_boolean_cmd): ... here.
7343         * cli/cli-decode.h (boolean_enums): Declare.
7344         * cli/cli-option.c: New file.
7345         * cli/cli-option.h: New file.
7346         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7347         factored out from ...
7348         (parse_cli_boolean_value(const char *)): ... this.
7349         (is_unlimited_literal): Change parameter type to pointer to
7350         pointer.  Adjust and advance ARG pointer.
7351         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7352         (parse_cli_var_enum): New, factored out from ...
7353         (do_set_command): ... this.  Adjust.
7354         * cli/cli-setshow.h (parse_cli_boolean_value)
7355         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7356         (parse_cli_var_enum): Declare.
7357         * cli/cli-utils.c: Include "cli/cli-option.h".
7358         (get_ulongest): New.
7359         * cli/cli-utils.h (get_ulongest): Declare.
7360         (check_for_argument): New overloads.
7361         * maint-test-options.c: New file.
7362
7363 2019-06-13  Pedro Alves  <palves@redhat.com>
7364
7365         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7366         parse a range if "-" is at the end of the string.
7367
7368 2019-06-13  Pedro Alves  <palves@redhat.com>
7369
7370         * cli/cli-setshow.c (parse_auto_binary_operation)
7371         (parse_cli_boolean_value): Don't allow "o".
7372
7373 2019-06-13  Pedro Alves  <palves@redhat.com>
7374
7375         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7376         * NEWS: Mention maint test-settings KIND.
7377         * maint-test-settings.c: New file.
7378
7379 2019-06-13  Pedro Alves  <palves@redhat.com>
7380
7381         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7382         completer.
7383         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7384         "set" completers.
7385
7386 2019-06-13  Pedro Alves  <palves@redhat.com>
7387
7388         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7389         after item.
7390
7391 2019-06-13  Pedro Alves  <palves@redhat.com>
7392
7393         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7394
7395 2019-06-13  Pedro Alves <palves@redhat.com>
7396
7397         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7398         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7399         call.
7400         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7401         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7402         calls.
7403         (check_for_argument): Skip spaces after argument.
7404
7405 2019-06-13  Pedro Alves  <palves@redhat.com>
7406
7407         * thread.c (thread_apply_command): Adjust TID parsing.
7408         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7409         detected before end of string.
7410         (tid_is_in_list): Error out if LIST is invalid.
7411
7412 2019-06-13  Pedro Alves  <palves@redhat.com>
7413
7414         * completer.c (complete_line_internal_1): Rewind completion word
7415         point.
7416         (completion_tracker::advance_custom_word_point_by): Change
7417         parameter type to int.
7418         * completer.h (completion_tracker::advance_custom_word_point_by):
7419         Likewise.
7420
7421 2019-06-13  Pedro Alves  <palves@redhat.com>
7422
7423         * completer.c (advance_to_completion_word): Handle delimiters.
7424
7425 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7426
7427         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7428
7429 2019-06-11  Tom Tromey  <tom@tromey.com>
7430
7431         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7432         (xmalloc_failed): Move to alloc.c.
7433         * alloc.c: New file.
7434         * Makefile.in (COMMON_SFILES): Add alloc.c.
7435
7436 2019-06-11  Tom Tromey  <tom@tromey.com>
7437
7438         * nat/linux-waitpid.c: Don't include server.h.
7439         (linux_debug): Remove.
7440         (my_waitpid): Update.
7441
7442 2019-06-11  Tom Tromey  <tromey@adacore.com>
7443
7444         * infcall.c (_initialize_infcall): Remove trailing newline from
7445         help.
7446         * user-regs.c (_initialize_user_regs): Remove trailing newline
7447         from help.
7448         * typeprint.c (_initialize_typeprint): Remove trailing newline
7449         from help.
7450         * reverse.c (_initialize_reverse): Remove trailing newlines from
7451         help.
7452         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7453         from help.
7454         * language.c (add_set_language_command): Remove trailing newline
7455         from help.
7456         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7457         help.
7458         * disasm.c (_initialize_disasm): Remove trailing newline from
7459         help.
7460         * top.c (init_main): Remove trailing newline from help.
7461         * interps.c (_initialize_interpreter): Remove trailing newline
7462         from help.
7463         * btrace.c (_initialize_btrace): Remove trailing newlines from
7464         help.
7465         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7466         from help.
7467         * python/python.c (_initialize_python): Remove trailing newline
7468         from help.
7469         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7470         help.
7471         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7472         from help.  Reformat some text.
7473         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7474         from help.
7475         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7476         newline from help.
7477
7478 2019-06-11  Tom Tromey  <tromey@adacore.com>
7479
7480         * darwin-nat.c (darwin_decode_exception_message)
7481         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7482
7483 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * valops.c (value_slice): Check for not allocated or not
7486         associated values.
7487
7488 2019-06-10  Tom de Vries  <tdevries@suse.de>
7489
7490         PR gdb/24618
7491         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7492         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7493         invalid.
7494
7495 2019-06-10  Tom de Vries  <tdevries@suse.de>
7496
7497         PR gdb/24611
7498         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7499         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7500
7501 2019-06-10  Tom de Vries  <tdevries@suse.de>
7502
7503         PR symtab/24545
7504         * symtab.c (struct demangled_name_entry): Add language field.
7505         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7506         static minimal symbol".  Set and use language field.
7507
7508 2019-06-10  Tom Tromey  <tromey@adacore.com>
7509
7510         * ada-lang.c (_initialize_ada_language): Update help text.
7511
7512 2019-06-10  Tom Tromey  <tromey@adacore.com>
7513
7514         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7515         with a newline.
7516         * guile/guile.c (handle_boot_error): Don't end warning with a
7517         newline.
7518         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7519         warning with a newline.
7520         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7521         newline.
7522         (s12z_frame_cache): Likewise.
7523         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7524         a newline.
7525         * solib-svr4.c (disable_probes_interface): Don't end warning with
7526         a newline.
7527         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7528         newline.
7529         * python/python.c (do_finish_initialization): Don't end warning
7530         with a newline.
7531
7532 2019-06-10  Tom Tromey  <tom@tromey.com>
7533
7534         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7535         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7536         gdbpy_enter.
7537
7538 2019-06-10  Tom Tromey  <tromey@adacore.com>
7539
7540         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7541         data.
7542         (elf_new_init): Don't call stabsread_new_init.
7543         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7544         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7545         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7546
7547 2019-06-10  Tom de Vries  <tdevries@suse.de>
7548
7549         PR symtab/16264
7550         PR symtab/24517
7551         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7552
7553 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7554
7555         * source.c (find_and_open_source): Also rewrite relative file
7556         names.
7557
7558 2019-04-26  Amos Bird  <amosbird@gmail.com>
7559
7560         * annotate.c (annotate_thread_exited): Add "thread-exited"
7561         annotation.
7562
7563 2019-06-06  Tom Tromey  <tromey@adacore.com>
7564
7565         * maint.h (class scoped_command_stats): Use
7566         DISABLE_COPY_AND_ASSIGN.
7567         <print_time>: New method.
7568         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7569         print_time.
7570         (scoped_command_stats::print_time): New method.
7571
7572 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7575         instructions of lengths 6 or 8 bytes.
7576
7577 2019-06-04  Pedro Alves  <palves@redhat.com>
7578
7579         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7580
7581         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7582         * breakpoint.c (condition_completer): Likewise.
7583         * cli/cli-dump.c (scan_expression): Likewise.
7584         * common/filestuff.c (mkdir_recursive): Likewise.
7585         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7586         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7587         (gdb_abspath): Likewise.
7588         * compile/compile-cplus-types.c
7589         (compile_cplus_instance::decl_name): Likewise.
7590         * completer.c (complete_explicit_location):
7591         (signal_completer, reg_or_group_completer_1): Likewise.
7592         * cp-support.c (cp_remove_params_if_any): Likewise.
7593         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7594         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7595         * infcmd.c (strip_bg_char): Likewise.
7596         * linespec.c (copy_token_string): Likewise.
7597         * mi/mi-main.c (output_cores): Likewise.
7598         * psymtab.c (psymtab_search_name):
7599         * symfile.c (test_set_ext_lang_command): Likewise.
7600         * target.c (target_fileio_read_stralloc): Likewise.
7601         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7602         * value.c (complete_internalvar): Likewise.
7603
7604 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7605
7606         Add objfile property to gdb.Type.
7607         * NEWS: Mention Python API addition.
7608         * python/py-type.c (typy_get_objfile): New method.
7609
7610 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7611
7612         * NEWS: Mention the new set|show style [title|highlight].
7613         Mention changes to "show style", "help" and "apropos".
7614
7615 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7616
7617         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7618         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7619         instead of print_help_for_command.
7620         (print_doc_of_command): New function.
7621         (help_list): Add 'apropos -v word' suggestion.
7622         (print_help_for_command): Style the command name using title style.
7623         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7624         (_initialize_cli_cmds): Describe -v in apropos_command help.
7625
7626 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7627
7628         * cli/cli-style.h (cli_style_option): Add name in constructor,
7629         add m_name class member, add constructor with intensity,
7630         add name class function.
7631         (cli_style_option::add_setshow_commands): Remove name argument.
7632         (highlight_style, title_style): New styles.
7633         * cli/cli-style.c (do_show): New function that shows a style
7634         characteristic styling the style name with itself.
7635         (set_style_name): New function.
7636         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7637         Update all callers according to the changes in cli/cli-style.h.
7638         * utils.h (fputs_highlighted): New function.
7639         * utils.c (fputs_highlighted): Likewise.
7640
7641 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7642
7643         * NEWS: Mention new pipe command and new convenience variables.
7644
7645 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7646
7647         * cli/cli-cmds.c (pipe_command): New function.
7648         (_initialize_cli_cmds): Call add_com for pipe_command.
7649         Define | as an alias for pipe.
7650         (exit_status_set_internal_vars): New function.
7651         (shell_escape): Call exit_status_set_internal_vars.
7652         cli/cli-decode.c (find_command_name_length): Recognize | as
7653         a single character command.
7654
7655 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7656
7657         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7658         top.c (execute_command_to_ui_file): New function, mostly a copy
7659         of execute_command_to_string.
7660         (execute_command_to_string): Implement by calling
7661         execute_command_to_ui_file.
7662
7663 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7664
7665         * top.h (saved_command_line): Remove declaration.
7666         * top.c (previous_saved_command_line, previous_repeat_arguments):
7667         New variables.
7668         (saved_command_line): Make static, define together with other
7669         'repeat variables'.
7670         (dont_repeat): Clear repeat_arguments.
7671         (repeat_previous, get_saved_command_line, save_command_line):
7672         New functions.
7673         (gdb_init): Initialize saved_command_line
7674         and previous_saved_command_line.
7675         * main.c (captured_main_1): Remove saved_command_line initialization.
7676         * event-top.c (handle_line_of_input): Update to use
7677         the new 'repeat' related functions instead of direct access to
7678         saved_command_line.
7679         * command.h (repeat_previous, get_saved_command_line,
7680         save_command_line): New declarations.
7681         (dont_repeat): Add comment.
7682
7683 2019-05-30  Tom Tromey  <tromey@adacore.com>
7684
7685         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7686         Fix comment.
7687         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7688
7689 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7690
7691         PR cli/24587
7692         * completer.c (complete): Initialize variable word.
7693
7694 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7695
7696         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7697         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7698         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7699         'body' is NULL to the outter 'if', protecting the '!is_define'
7700         situation as well.
7701
7702 2019-05-29  Tom Tromey  <tromey@adacore.com>
7703
7704         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7705         (dwarf_unknown): New function.
7706         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7707         (dwarf_type_encoding_name): Use dwarf_unknown.
7708
7709 2019-05-29  Tom Tromey  <tromey@adacore.com>
7710
7711         PR c++/20020:
7712         * cp-valprint.c (cp_print_value_fields): Call
7713         cp_print_static_field inside "try".
7714
7715 2019-05-29  Tom Tromey  <tromey@adacore.com>
7716
7717         * inflow.c (struct terminal_info): Add default operator=.
7718         * configure: Rebuild.
7719         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7720         -Wdeprecated-copy-dtor, -Wredundant-move.
7721
7722 2019-05-29  Tom Tromey  <tromey@adacore.com>
7723
7724         * NEWS: Add entry.
7725         * infcmd.c (print_return_value_1): Handle finish_print
7726         option.
7727         (show_print_finish): New function.
7728         (_initialize_infcmd): Add "set/show print finish" commands.
7729         * valprint.c (user_print_options): Initialize new member.
7730         * valprint.h (struct value_print_options) <finish_print>: New
7731         member.
7732
7733 2019-05-28  Tom Tromey  <tromey@adacore.com>
7734
7735         * ada-lang.c (ada_remove_Xbn_suffix)
7736         (find_old_style_renaming_symbol)
7737         (parse_old_style_renaming): Remove.
7738         (ada_find_renaming_symbol): Don't call
7739         find_old_style_renaming_symbol.
7740         (ada_is_renaming_symbol): Rename from
7741         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7742         bool.  Now static.
7743         (ada_read_var_value): Update and simplify.
7744         * ada-exp.y (write_var_or_type): Remove old code.
7745
7746 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7747
7748         PR gdb/25010
7749         * event-top.c: Remove include comment.
7750         * inflow.c (class scoped_ignore_sigttou): Move from here...
7751         * inflow.h (class scoped_ignore_sigttou): ...to here.
7752         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7753         * top.c:  Remove include comment.
7754
7755 2019-05-27  Tom Tromey  <tom@tromey.com>
7756
7757         * NEWS: Fix typo.
7758
7759 2019-05-22  Tom Tromey  <tromey@adacore.com>
7760
7761         * target.c (target_follow_exec): Constify parameter.
7762         * target-delegates.c: Rebuild.
7763         * remote.c (remote_target::follow_exec): Constify parameter.
7764         * infrun.c (follow_exec): Constify parameter.
7765         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7766         (target_follow_exec): Likewise.
7767
7768 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7769
7770         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7771         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7772
7773 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * NEWS: Add debugredirect and testsuite sections.
7776
7777 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7778
7779         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7780         target descriptions using exclusively floating point register name
7781         aliases.
7782
7783 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         PR gdb/18644:
7786         * f-lang.c (build_fortran_types): Handle the case where
7787         gdbarch_floatformat_for_type returns a nullptr.
7788
7789 2019-05-21  Tom de Vries  <tdevries@suse.de>
7790
7791         PR cli/24587
7792         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7793
7794 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         PR gdb/18644:
7797         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7798         16-byte floats.
7799         * i386-tdep.c (i386_floatformat_for_type): Use
7800         floatformats_ia64_quad for the 16-byte floating point component
7801         within a fortran 32-byte complex number.
7802
7803 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7804
7805         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7806         delete default constructor.
7807         (find_partial_die): Update to return const struct.
7808         (partial_die_parent_scope): Move variable declaration into scope
7809         of its use and change its type to auto.
7810         (guess_partial_die_structure_name): Likewise.
7811         (partial_die_info::fixup): Likewise.
7812
7813 2019-05-17  Tom Tromey  <tromey@adacore.com>
7814
7815         * source.c (find_and_open_source): Remove cast.
7816
7817 2019-05-17  Tom Tromey  <tromey@adacore.com>
7818
7819         * annotate.c (annotate_source): Make "filename" const.
7820         * annotate.h (annotate_source): Use const.
7821
7822 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7823
7824         * disasm.c (set_disassembler_options): Send errors to stderr.
7825
7826 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7827
7828         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7829         (cli_interp_base::set_logging): Check debug_redirect.
7830         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7831         * cli/cli-logging.c (debug_redirect): Add static variable.
7832         (pop_output_files): Add default param.
7833         (handle_redirections): Print debug setting.
7834         (show_logging_command): Likewise.
7835         (_initialize_cli_logging): Add debugredirect command.
7836         * interps.c (current_interp_set_logging): Add debug_redirect
7837         parameter.
7838         * interps.h (set_logging): Add debug_redirect parameter.
7839         (current_interp_set_logging): Likewise.
7840         * mi/mi-common.h: Likewise.
7841         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7842
7843 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7844             Tom Tromey  <tromey@adacore.com>
7845
7846         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7847         directly.
7848         * cli/cli-interp.h (make_logging_output): Remove declaration.
7849         * cli/cli-logging.c (make_logging_output): Remove function.
7850         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7851         directly.
7852         * ui-file.c (tee_file::tee_file): Remove bools.
7853         (tee_file::~tee_file): Remove deletes.
7854         * ui-file.h (tee_file): Remove bools.
7855
7856 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7857
7858         * mi/mi-cmds.h (mi_cmd_complete): New function.
7859         * mi/mi-main.c (mi_cmd_complete): Likewise.
7860         * mi/mi-cmds.c: Define new MI command -complete.
7861         * NEWS: Mention new -complete command.
7862
7863 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7864
7865         * completer.h (complete): New function.
7866         * completer.c (complete): Likewise.
7867         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7868         function defined in completer.h.
7869
7870 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7871
7872         * MAINTAINERS (Write After Approval): Add myself.
7873
7874 2019-05-17  Tom de Vries  <tdevries@suse.de>
7875
7876         PR gdb/24094
7877         * dwarf2read.c (struct cu_partial_die_info): New struct.
7878         (find_partial_die): Return cu_partial_die_info.
7879         (partial_die_parent_scope, guess_partial_die_structure_name)
7880         (partial_die_info::fixup): Handle new return type of find_partial_die.
7881
7882 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7883
7884         PR breakpoints/24541
7885         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7886         "std::string", simplifying the algorithm.
7887
7888 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7889
7890         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7891         (stap_static_probe_ops::get_probes): Likewise.
7892
7893 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7894
7895         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7896         '-')" and "else if".
7897         (stap_parse_single_operand): Join checks for
7898         "gdbarch_stap_parse_special_token_p" and
7899         "gdbarch_stap_parse_special_token" in the same "if" statement.
7900         Invert check when verifying for operation on register
7901         displacement.
7902
7903 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7904
7905         * stap-probe.c (stap_get_opcode): Update comment.
7906         (stap_get_expected_argument_type): Likewise.
7907         (handle_stap_probe): Likewise.
7908
7909 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7910
7911         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7912         return type to 'bool'.  Adjust comment.  Use 'bool' when
7913         appropriate.
7914         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7915         * stap-probe.c (stap_parse_argument_1): Likewise.
7916         (stap_is_operator): Likewise.
7917         (stap_is_generic_prefix): Likewise.
7918         (stap_is_register_prefix): Likewise.
7919         (stap_is_register_indirection_prefix): Likewise.
7920         (stap_is_integer_prefix): Likewise.
7921         (stap_generic_check_suffix): Likewise.
7922         (stap_check_integer_suffix): Likewise.
7923         (stap_check_register_suffix): Likewise.
7924         (stap_check_register_indirection_suffix): Likewise.
7925         (stap_parse_register_operand): Likewise.
7926         (stap_parse_single_operand): Likewise.
7927         (stap_parse_argument_1): Likewise.
7928         (stap_probe::get_argument_count): Likewise.
7929         (stap_is_operator): Likewise.
7930
7931 2019-05-16  Tom Tromey  <tromey@adacore.com>
7932
7933         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7934         keyword to foreach.
7935
7936 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7937
7938         * linux-thread-db.c (try_thread_db_load_1): Change return type
7939         to bool.
7940         (try_thread_db_load): Likewise.
7941         (try_thread_db_load_from_pdir_1): Likewise.
7942         (try_thread_db_load_from_pdir): Likewise.
7943         (try_thread_db_load_from_sdir): Likewise.
7944         (try_thread_db_load_from_dir): Likewise.
7945         (thread_db_load_search): Likewise.
7946         (has_libpthread): Likewise.
7947         (thread_db_load): Likewise.
7948
7949 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7950
7951         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7952         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7953         NULL, and complain/return if that's the case.
7954
7955 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7956
7957         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7958         (advance, posn, abstract_read_memory): New functions.
7959         [struct mem_read_abstraction]: New struct.
7960         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7961
7962 2019-05-14  Tom Tromey  <tromey@adacore.com>
7963
7964         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7965         value is not lval_memory.
7966
7967 2019-05-14  Tom Tromey  <tromey@adacore.com>
7968
7969         * solib.c (info_sharedlibrary_command): Style the file name.
7970
7971 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7972
7973         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7974         (aarch64_vnv_type): Likewise.
7975         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7976         * common/tdesc.c: Likewise.
7977         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7978         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7979         * features/aarch64-fpu.xml: Add ieee half view.
7980         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7981         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7982         * gdbtypes.h (struct builtin_type): Likewise.
7983         (struct objfile_type): Likewise.
7984
7985 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7986
7987         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7988         typo.
7989         * location.h (string_to_event_location): Likewise.
7990
7991 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7992
7993         GDB 8.3 released.
7994
7995 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7996
7997         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7998         New variable declaration.
7999         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8000         New variable.
8001         (print_one_breakpoint): Use ui_out::test_flags and new global
8002         variable to compute use_fixed_output.
8003         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8004         Remove.
8005         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8006         (mi_multi_location_breakpoint_output_fixed): Remove.
8007         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8008         new variable.
8009         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8010         fix_multi_location_breakpoint_output flag if version >= 3.
8011         * ui-out.h (enum ui_out_flag)
8012         <fix_multi_location_breakpoint_output>: New enumerator.
8013
8014 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8015
8016         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8017
8018 2019-05-10  Tom Tromey  <tromey@adacore.com>
8019
8020         * ada-lang.c (catch_ada_completer): New function.
8021         (_initialize_ada_language): Use it.
8022
8023 2019-05-10  Tom Tromey  <tromey@adacore.com>
8024
8025         * thread.c (print_thread_info): Make "requested_threads" const.
8026         * gdbthread.h (print_thread_info): Make "requested_threads"
8027         const.
8028         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8029         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8030
8031 2019-05-08  Tom Tromey  <tom@tromey.com>
8032
8033         * gdbtypes.c (objfile_type_data): Change type.
8034         (objfile_type, _initialize_gdbtypes): Update.
8035
8036 2019-05-08  Tom Tromey  <tom@tromey.com>
8037
8038         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8039         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8040         (_initialize_dwarf2_frame): Update.
8041
8042 2019-05-08  Tom Tromey  <tom@tromey.com>
8043
8044         * objc-lang.c (objc_objfile_data): Change type.
8045         (find_methods): Update.
8046         (_initialize_objc_lang): Remove.
8047
8048 2019-05-08  Tom Tromey  <tom@tromey.com>
8049
8050         * stabsread.c (rs6000_builtin_type_data): Change type.
8051         (rs6000_builtin_type, _initialize_stabsread): Update.
8052
8053 2019-05-08  Tom Tromey  <tom@tromey.com>
8054
8055         * mips-tdep.c (mips_pdr_data): Remove.
8056         (_initialize_mips_tdep): Update.
8057
8058 2019-05-08  Tom Tromey  <tom@tromey.com>
8059
8060         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8061         (hppa_init_objfile_priv_data, read_unwind_info)
8062         (find_unwind_entry, _initialize_hppa_tdep): Update.
8063
8064 2019-05-08  Tom Tromey  <tom@tromey.com>
8065
8066         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8067         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8068         on obstack.
8069         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8070
8071 2019-05-08  Tom Tromey  <tom@tromey.com>
8072
8073         * mdebugread.c (basic_type_data): Change type.
8074         (basic_type, _initialize_mdebugread): Update.
8075
8076 2019-05-08  Tom Tromey  <tom@tromey.com>
8077
8078         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8079
8080 2019-05-08  Tom Tromey  <tom@tromey.com>
8081
8082         * nto-tdep.c (nto_inferior_data_reg): Change type.
8083         (nto_inferior_data): Update.
8084         (nto_inferior_data_cleanup, nto_new_inferior_data)
8085         (_initialize_nto_tdep): Remove.
8086         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8087
8088 2019-05-08  Tom Tromey  <tom@tromey.com>
8089
8090         * ada-lang.c (struct ada_inferior_data): Add initializers.
8091         (ada_inferior_data): Change type.
8092         (ada_inferior_data_cleanup): Remove.
8093         (get_ada_inferior_data, ada_inferior_exit)
8094         (struct ada_pspace_data): Add initializers, destructor.
8095         (ada_pspace_data_handle): Change type.
8096         (get_ada_pspace_data): Update.
8097         (ada_pspace_data_cleanup): Remove.
8098
8099 2019-05-08  Tom Tromey  <tom@tromey.com>
8100
8101         * coffread.c (struct coff_symfile_info): Add initializers.
8102         (coff_objfile_data_key): Move lower.  Change type.
8103         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8104         Update.
8105         (coff_free_info): Remove.
8106
8107 2019-05-08  Tom Tromey  <tom@tromey.com>
8108
8109         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8110         (fbsd_pspace_data_handle): Move lower.  Change type.
8111         (get_fbsd_pspace_data): Update.
8112         (fbsd_pspace_data_cleanup): Remove.
8113         (_initialize_fbsd_tdep): Update.
8114
8115 2019-05-08  Tom Tromey  <tom@tromey.com>
8116
8117         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8118         (get_ada_tasks_pspace_data): Update.
8119         (ada_tasks_pspace_data_cleanup): Remove.
8120         (_initialize_tasks): Update.
8121         (ada_tasks_inferior_data_handle): Change type.
8122         (get_ada_tasks_inferior_data): Update.
8123         (ada_tasks_inferior_data_cleanup): Remove.
8124         (struct ada_tasks_pspace_data): Add initializers.
8125
8126 2019-05-08  Tom Tromey  <tom@tromey.com>
8127
8128         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8129         * symfile-debug.c (debug_sym_get_probes): Change type.
8130         * stap-probe.c (handle_stap_probe):
8131         (stap_static_probe_ops::get_probes): Change type.
8132         * probe.h (class static_probe_ops) <get_probes>: Change type.
8133         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8134         (parse_probes_in_pspace): Update.
8135         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8136         Update.
8137         (any_static_probe_ops::get_probes): Change type.
8138         * elfread.c (elfread_data): New typedef.
8139         (probe_key): Change type.
8140         (elf_get_probes): Likewise.  Update.
8141         (probe_key_free): Remove.
8142         (_initialize_elfread): Update.
8143         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8144         Change type.
8145         (dtrace_process_dof_probe, dtrace_process_dof)
8146         (dtrace_static_probe_ops::get_probe): Change type.
8147
8148 2019-05-08  Tom Tromey  <tom@tromey.com>
8149
8150         * xcoffread.c (struct xcoff_symfile_info): Rename from
8151         coff_symfile_info.  Add initializers.
8152         (xcoff_objfile_data_key): Move lower.  Change type.
8153         (XCOFF_DATA): Rewrite.
8154         (xcoff_free_info): Remove.
8155         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8156         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8157         (xcoff_initial_scan): Update.
8158
8159 2019-05-08  Tom Tromey  <tom@tromey.com>
8160
8161         * solib-svr4.c (struct svr4_info): Add initializers and
8162         destructor.
8163         <probes_table>: Now an htab_up.
8164         (solib_svr4_pspace_data): Change type.
8165         (free_probes_table): Simplify.
8166         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8167         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8168         (probes_table_remove_objfile_probes, register_solib_event_probe)
8169         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8170         (_initialize_svr4_solib): Update.
8171
8172 2019-05-08  Tom Tromey  <tom@tromey.com>
8173
8174         * remote.c (remote_pspace_data): Change type.
8175         (remote_pspace_data_cleanup): Remove.
8176         (get_remote_exec_file, set_pspace_remote_exec_file)
8177         (_initialize_remote): Update.
8178
8179 2019-05-08  Tom Tromey  <tom@tromey.com>
8180
8181         * breakpoint.c (breakpoint_objfile_key): Change type.
8182         (get_breakpoint_objfile_data): Update.
8183         (free_breakpoint_objfile_data): Remove.
8184         (_initialize_breakpoint): Update.
8185
8186 2019-05-08  Tom Tromey  <tom@tromey.com>
8187
8188         * linux-tdep.c (struct linux_info): Add initializers.
8189         (linux_inferior_data): Move.  Change type.
8190         (invalidate_linux_cache_inf): Update.
8191         (linux_inferior_data_cleanup): Remove.
8192         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8193
8194 2019-05-08  Tom Tromey  <tom@tromey.com>
8195
8196         * auxv.c (auxv_inferior_data): Move.  Change type.
8197         (auxv_inferior_data_cleanup): Remove.
8198         (invalidate_auxv_cache_inf): Rewrite.
8199         (get_auxv_inferior_data, _initialize_auxv): Update.
8200
8201 2019-05-08  Tom Tromey  <tom@tromey.com>
8202
8203         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8204         (symfile_debug_objfile_data_key): Change type.
8205         (symfile_debug_installed, debug_qf_has_symbols)
8206         (debug_qf_find_last_source_symtab)
8207         (debug_qf_forget_cached_source_info)
8208         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8209         (debug_qf_print_stats, debug_qf_dump)
8210         (debug_qf_expand_symtabs_for_function)
8211         (debug_qf_expand_all_symtabs)
8212         (debug_qf_expand_symtabs_with_fullname)
8213         (debug_qf_map_matching_symbols)
8214         (debug_qf_expand_symtabs_matching)
8215         (debug_qf_find_pc_sect_compunit_symtab)
8216         (debug_qf_map_symbol_filenames)
8217         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8218         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8219         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8220         (debug_sym_read_linetable, debug_sym_relocate): Update.
8221         (symfile_debug_free_objfile): Remove.
8222         (install_symfile_debug_logging, _initialize_symfile_debug):
8223         Update.
8224
8225 2019-05-08  Tom Tromey  <tom@tromey.com>
8226
8227         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8228         allocate_on_obstack.
8229         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8230         (get_dwarf2_per_objfile): Update.
8231         (set_dwarf2_per_objfile): Remove.
8232         (dwarf2_has_info, dwarf2_get_section_info): Update.
8233         (dwarf2_free_objfile): Remove.
8234         (_initialize_dwarf2_read): Update.
8235
8236 2019-05-08  Tom Tromey  <tom@tromey.com>
8237
8238         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8239         initializers.
8240         <unsupported_script_warning_printed,
8241         script_not_found_warning_printed>: Now bool.
8242         (auto_load_pspace_data): Change type.
8243         (~auto_load_pspace_info): Rename from
8244         auto_load_pspace_data_cleanup.
8245         (get_auto_load_pspace_data, init_loaded_scripts_info)
8246         (clear_section_scripts, maybe_print_unsupported_script_warning)
8247         (maybe_print_script_not_found_warning, _initialize_auto_load):
8248         Update.
8249
8250 2019-05-08  Tom Tromey  <tom@tromey.com>
8251
8252         * objfiles.c (objfile_pspace_info): Add destructor and
8253         initializers.
8254         (objfiles_pspace_data): Change type.
8255         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8256         (get_objfile_pspace_data): Update.
8257         (objfiles_bfd_data): Change type.
8258         (get_objfile_bfd_data): Update.
8259         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8260
8261 2019-05-08  Tom Tromey  <tom@tromey.com>
8262
8263         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8264         Change type.
8265         (get_catch_syscall_inferior_data): Update.
8266         (catch_syscall_inferior_data_cleanup): Remove.
8267         (_initialize_break_catch_syscall): Update.
8268
8269 2019-05-08  Tom Tromey  <tom@tromey.com>
8270
8271         * inflow.c (struct terminal_info): Add destructor and
8272         initializers.
8273         (inflow_inferior_data): Change type.
8274         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8275         (get_inflow_inferior_data, inflow_inferior_exit)
8276         (swap_terminal_info, _initialize_inflow): Update.
8277
8278 2019-05-08  Tom Tromey  <tom@tromey.com>
8279
8280         * target-dcache.c (target_dcache_cleanup): Remove.
8281         (target_dcache_aspace_key): Change type.
8282         (target_dcache_init_p, target_dcache_invalidate)
8283         (target_dcache_get, target_dcache_get_or_init)
8284         (_initialize_target_dcache): Update.
8285         * dcache.h (struct dcache_deleter): New.
8286
8287 2019-05-08  Tom Tromey  <tom@tromey.com>
8288
8289         * symtab.c (struct symbol_cache): Add destructor and
8290         initializers.
8291         (symbol_cache_key): Move.  Change type.
8292         (make_symbol_cache, free_symbol_cache): Remove.
8293         (get_symbol_cache): Update.
8294         (symbol_cache_cleanup): Remove.
8295         (ALL_PSPACES, symbol_cache_flush)
8296         (maintenance_print_symbol_cache)
8297         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8298         Update.
8299
8300 2019-05-08  Tom Tromey  <tom@tromey.com>
8301
8302         * symtab.c (struct main_info): Add destructor and initializers.
8303         (main_progspace_key): Move.  Change type.
8304         (get_main_info): Update.
8305         (main_info_cleanup): Remove.
8306         (_initialize_symtab): Update.
8307
8308 2019-05-08  Tom Tromey  <tom@tromey.com>
8309
8310         * registry.h (DECLARE_REGISTRY): Define the _key class.
8311
8312 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * NEWS: Merge two 'New commands' sections.
8315
8316 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8317
8318         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8319         parameter and use Ada language definition instead.
8320         (ada_val_print_ptr): Remove unused language parameter.
8321         (ada_val_print_num): Remove language parameter and use Ada language
8322         definition instead.
8323         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8324         parameter.
8325         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8326         parameter and use Ada language definition instead.
8327         (ada_val_print_1): Update all ada_val_print_xxx calls.
8328         Remove language parameter.
8329         (ada_val_print): Update ada_val_print_1 call.
8330
8331 2019-05-08  Tom Tromey  <tromey@adacore.com>
8332
8333         * remote.c (remote_hw_watchpoint_limit)
8334         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8335         Now static.
8336
8337 2019-05-08  Tom Tromey  <tromey@adacore.com>
8338
8339         * maint.c (_initialize_maint_cmds): Move initialization code to
8340         remote.c.
8341         (watchdog, show_watchdog): Move to remote.c.
8342         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8343         "watchdog" static.
8344         (_initialize_remote): Move initialization code from maint.c.
8345         * defs.h (watchdog): Don't declare.
8346
8347 2019-05-08  Tom Tromey  <tromey@adacore.com>
8348
8349         * tui/tui-interp.c: Include main.h.
8350         * interps.c: Include main.h.
8351         * main.h (interpreter_p): Declare.
8352         * defs.h (interpreter_p): Don't declare.
8353
8354 2019-05-08  Tom Tromey  <tromey@adacore.com>
8355
8356         * dwarf2loc.c: Include dwarf2read.h.
8357         * defs.h (read_unsigned_leb128): Don't declare.
8358         * dwarf2read.h (read_unsigned_leb128): Declare.
8359
8360 2019-05-08  Tom Tromey  <tromey@adacore.com>
8361
8362         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8363         method.
8364
8365 2019-05-08  Tom Tromey  <tromey@adacore.com>
8366
8367         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8368         when no wrap column is set.
8369
8370 2019-05-08  Tom Tromey  <tromey@adacore.com>
8371
8372         * c-lang.c (c_get_string): Handle non-C-style arrays.
8373
8374 2019-05-08  Tom Tromey  <tromey@adacore.com>
8375
8376         * typeprint.c (print_offset_data::update): Print the bit offset,
8377         not the number of bits remaining.
8378
8379 2019-05-08  Tom Tromey  <tromey@adacore.com>
8380
8381         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8382         padding at end of comment.
8383
8384 2019-05-08  Tom Tromey  <tromey@adacore.com>
8385
8386         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8387         Compare main types.
8388
8389 2019-05-06  Tom Tromey  <tom@tromey.com>
8390
8391         * common/scoped_mmap.c: Include common-defs.h.
8392         * common/scoped_mmap.h: Don't include config.h.
8393
8394 2019-05-04  Tom Tromey  <tom@tromey.com>
8395
8396         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8397         (struct aarch64_call_info): Add initializers.
8398         <si>: Now a std::vector.
8399         (pass_on_stack, aarch64_push_dummy_call): Update.
8400
8401 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8402             Tom Tromey  <tom@tromey.com>
8403
8404         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8405         (ppc_threads): Now a std::vector.  Now static.
8406         (hwdebug_find_thread_points_by_tid)
8407         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8408         Update.
8409
8410 2019-05-04  Tom Tromey  <tom@tromey.com>
8411
8412         * arc-tdep.c (arc_tdesc_init): Return bool.
8413
8414 2019-05-04  Tom Tromey  <tom@tromey.com>
8415
8416         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8417         Use gdb_assert_not_reached.
8418
8419 2019-05-04  Tom Tromey  <tom@tromey.com>
8420
8421         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8422         "false".
8423
8424 2019-05-04  Tom Tromey  <tom@tromey.com>
8425
8426         * arc-tdep.c (arc_tdesc_init): Use bool.
8427
8428 2019-05-04  Tom Tromey  <tom@tromey.com>
8429
8430         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8431
8432 2019-05-04  Tom Tromey  <tom@tromey.com>
8433
8434         * cli/cli-cmds.c (valid_command_p): Return bool.
8435
8436 2019-05-04  Tom Tromey  <tom@tromey.com>
8437
8438         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8439         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8440
8441 2019-05-04  Raul Tambre  <raul@tambre.ee>
8442
8443         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8444         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8445         operator for comparison.
8446
8447 2019-05-04  Tom Tromey  <tom@tromey.com>
8448
8449         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8450         (lookup_partial_symbol, print_partial_symbols)
8451         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8452         (psymbol_compare): Update.
8453         (add_psymbol_to_bcache): Clear the entire psymbol.
8454         (maintenance_check_psymtabs): Update.
8455         * psympriv.h (struct partial_symbol): Don't derive from
8456         general_symbol_info.
8457         <obj_section, unrelocated_address, address,
8458         set_unrelocated_address>: Update.
8459         <ginfo>: New member.
8460         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8461         (debug_names::write_psymbols): Update.
8462
8463 2019-05-04  Tom de Vries  <tdevries@suse.de>
8464
8465         * contrib/cc-with-tweaks.sh: Support -n arg.
8466
8467 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8468
8469         * corelow.c (core_target::detach): Ensure frame cache and
8470         register caches are cleared.
8471         inferior.c (exit_inferior_1): Likewise.
8472
8473 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8474             Tom Tromey  <tom@tromey.com>
8475
8476         * dictionary.c (collate_pending_symbols_by_language): Remove
8477         "struct" from foreach.
8478         * symtab.c (lookup_global_symbol_from_objfile)
8479         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8480         foreach.
8481         * ser-tcp.c (net_open): Remove "struct" from foreach.
8482         * objfiles.c (objfile_relocate, objfile_rebase)
8483         (objfile_has_symbols): Remove "struct" from foreach.
8484         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8485         from foreach.
8486         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8487         foreach.
8488         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8489         "struct" from foreach.
8490         * ada-lang.c (create_excep_cond_exprs)
8491         (ada_exception_catchpoint_cond_string): Remove "struct" from
8492         foreach.
8493
8494 2019-05-03  Tom Tromey  <tromey@adacore.com>
8495
8496         * ada-exp.y (convert_char_literal): Check suffix of each
8497         enumerator.
8498
8499 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8500
8501         PR ada/21406:
8502         * ada-exp.y (yywrap): Don't define.
8503         * ada-lex.l (%option): Add noyywrap
8504         (yywrap): Remove.
8505
8506 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8507
8508         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8509         _WIN32_WINNT to the XP level, unless already defined to a higher
8510         level.
8511
8512         * unittests/parse-connection-spec-selftests.c:
8513         * ser-tcp.c:
8514         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8515         override.
8516
8517         * symfile.c (find_separate_debug_file): Remove colon from the
8518         drive spec of DOS/Windows file names of the target, so that the
8519         file name produced from DEBUGDIR and the target's directory will
8520         be valid on DOS/Windows systems.
8521
8522 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * rust-lang.c (val_print_struct): Handle printing structures
8525         containing strings.
8526
8527 2019-05-02  Tom Tromey  <tromey@adacore.com>
8528
8529         * valarith.c (_initialize_valarith): Remove.
8530
8531 2019-05-01  Tom Tromey  <tromey@adacore.com>
8532
8533         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8534         bitfields.
8535
8536 2019-05-01  Tom Tromey  <tromey@adacore.com>
8537
8538         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8539         for big-endian copies.
8540
8541 2019-04-30  Ali Tamur  <tamur@google.com>
8542         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8543         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8544         (read_3_bytes): New function.
8545
8546 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8547
8548         * windows-nat.c (main_thread_id): Delete.
8549         (handle_output_debug_string): Replace main_thread_id by
8550         current_event.dwThreadId.
8551         (fake_create_process): Likewise.
8552         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8553         Do not set main_thread_id.
8554         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8555         current_event.dwThreadId.
8556         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8557
8558 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8559
8560         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8561         Use current_event.dwThreadId instead of main_thread_id.
8562
8563 2019-04-30  Tom Tromey  <tromey@adacore.com>
8564
8565         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8566         (create_excep_cond_exprs): Iterate over program spaces.
8567         (ada_exception_catchpoint_cond_string): Examine all minimal
8568         symbols for exception types.
8569
8570 2019-04-30  Tom Tromey  <tromey@adacore.com>
8571
8572         PR c++/24470:
8573         * dwarf2read.c (process_structure_scope): Handle case where type
8574         has template parameters but no symbol was created.
8575
8576 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8577             Chris January  <chris.january@arm.com>
8578
8579         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8580         qualifier.
8581         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8582
8583 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * f-typeprint.c (f_print_type): Update rules for printing
8586         whitespace.
8587         (f_type_print_varspec_suffix): Likewise.
8588
8589 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8590             Chris January  <chris.january@arm.com>
8591
8592         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8593         function arguments.
8594
8595 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8596
8597         * f-lang.c (build_fortran_types): Change name of void type to
8598         lower case.
8599         * f-typeprint.c (f_type_print_base): Print the name of the void
8600         type, rather than a fixed string.
8601         * f-valprint.c (f_decorations): Use lower case void string.
8602
8603 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8604             Chris January  <chris.january@arm.com>
8605
8606         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8607         types for Fortran.
8608
8609 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8610             Chris January  <chris.january@arm.com>
8611             David Lecomber  <david.lecomber@arm.com>
8612
8613         * f-exp.y (BINOP_INTRINSIC): New token.
8614         (exp): New parser rule handling BINOP_INTRINSIC.
8615         (f77_keywords): Add new builtin procedures.
8616         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8617         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8618         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8619         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8620         (print_unop_subexp_f): New function.
8621         (print_binop_subexp_f): New function.
8622         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8623         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8624         (dump_subexp_body_f): Likewise.
8625         (operator_check_f): Likewise.
8626         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8627         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8628
8629 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8632         UNOP_KIND.
8633         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8634         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8635         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8636         (operator_length_f): New fuction.
8637         (print_subexp_f): New function.
8638         (op_name_f): New function.
8639         (dump_subexp_body_f): New function.
8640         (operator_check_f): New function.
8641         (exp_descriptor_f): Replace standard expression handling functions
8642         with new functions.
8643         * gdb/fortran-operator.def: New file.
8644         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8645         * gdb/std-operator.def: Remove UNOP_KIND.
8646
8647 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8648
8649         * std-operator.def: Remove unbalanced, stray double quote
8650         character.
8651
8652 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8653             Chris January  <chris.january@arm.com>
8654             Daniel Everett  <daniel.everett@arm.com>
8655             Nick Forrington  <nick.forrington@arm.com>
8656             Richard Bunt  <richard.bunt@arm.com>
8657
8658         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8659         of depth when printing anonymous structs or unions.
8660         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8661         Don't print either the top-level value, or the children if the
8662         max-depth is exceeded.
8663         (ppscm_print_children): When printing the key of a map, allow one
8664         extra level of depth.
8665         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8666         print either the top-level value, or the children if the max-depth
8667         is exceeded.
8668         (print_children): When printing the key of a map, allow one extra
8669         level of depth.
8670         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8671         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8672         (user_print_options): Initialise max_depth field.
8673         (val_print_scalar_or_string_type_p): New function.
8674         (val_print): Check to see if the max depth has been reached.
8675         (val_print_check_max_depth): Define new function.
8676         (show_print_max_depth): New function.
8677         (_initialize_valprint): Add 'print max-depth' option.
8678         * valprint.h (struct value_print_options) <max_depth>: New field.
8679         (val_print_check_max_depth): Declare new function.
8680         * NEWS: Document new feature.
8681
8682 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * ada-lang.c (ada_language_defn): Initialise new field.
8685         * c-lang.c (c_is_string_type_p): New function.
8686         (c_language_defn): Initialise new field.
8687         (cplus_language_defn): Initialise new field.
8688         (asm_language_defn): Initialise new field.
8689         (minimal_language_defn): Initialise new field.
8690         * c-lang.h (c_is_string_type_p): Declare new function.
8691         * d-lang.c (d_language_defn): Initialise new field.
8692         * f-lang.c (f_is_string_type_p): New function.
8693         (f_language_defn): Initialise new field.
8694         * go-lang.c (go_is_string_type_p): New function.
8695         (go_language_defn): Initialise new field.
8696         * language.c (default_is_string_type_p): New function.
8697         (unknown_language_defn): Initialise new field.
8698         (auto_language_defn): Initialise new field.
8699         * language.h (struct language_defn) <la_is_string_type_p>: New
8700         member variable.
8701         (default_is_string_type_p): Declare new function.
8702         * m2-lang.c (m2_language_defn): Initialise new field.
8703         * objc-lang.c (objc_language_defn): Initialise new field.
8704         * opencl-lang.c (opencl_language_defn): Initialise new field.
8705         * p-lang.c (pascal_is_string_type_p): New function.
8706         (pascal_language_defn): Initialise new field.
8707         * rust-lang.c (rust_is_string_type_p): New function.
8708         (rust_language_defn): Initialise new field.
8709
8710 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8711
8712         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8713         New field.
8714         * ada-lang.c (ada_language_defn): Initialise new field.
8715         * c-lang.c (c_language_defn): Likewise.
8716         (cplus_language_defn): Likewise.
8717         (asm_language_defn): Likewise.
8718         (minimal_language_defn): Likewise.
8719         * d-lang.c (d_language_defn): Likewise.
8720         * f-lang.c (f_language_defn): Likewise.
8721         * go-lang.c (go_language_defn): Likewise.
8722         * language.c (unknown_language_defn): Likewise.
8723         (auto_language_defn): Likewise.
8724         * m2-lang.c (m2_language_defn): Likewise.
8725         * objc-lang.c (objc_language_defn): Likewise.
8726         * opencl-lang.c (opencl_language_defn): Likewise.
8727         * p-lang.c (pascal_language_defn): Likewise.
8728         * rust-lang.c (rust_language_defn): Likewise.
8729
8730 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8731
8732         * ada-lang.c (ada_is_character_type): Change return type to bool.
8733         (ada_is_string_type): Likewise.
8734         * ada-lang.h (ada_is_character_type): Update declaration
8735         (ada_is_string_type): Likewise.
8736
8737 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8738
8739         Support style in 'frame|thread apply'
8740
8741         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8742         * record.c (record_start, record_stop): Update callers of
8743         execute_command_to_string with false.
8744         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8745         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8746         methods.
8747         (class string_file): New constructor with term_out parameter.
8748         Override methods term_out and can_emit_style_escape.  New member
8749         term_out.
8750         (class stdio_file): Override can_emit_style_escape.
8751         (class tee_file): Override term_out and can_emit_style_escape.
8752         * utils.h (can_emit_style_escape): Remove.
8753         * utils.c (can_emit_style_escape): Likewise.
8754         Update all callers of can_emit_style_escape (SOMESTREAM) to
8755         SOMESTREAM->can_emit_style_escape.
8756         * source-cache.c (source_cache::get_source_lines): Likewise.
8757         * stack.c (frame_apply_command_count): Call execute_command_to_string
8758         passing the term_out characteristic of the current gdb_stdout.
8759         * thread.c (thr_try_catch_cmd): Likewise.
8760         * top.c (execute_command_to_string): pass term_out parameter
8761         to construct the string_file for the command output.
8762         * ui-file.c (term_cli_styling): New function (most code moved
8763         from utils.c can_emit_style_escape).
8764         (string_file::string_file, string_file::can_emit_style_escape,
8765         stdio_file::can_emit_style_escape, tee_file::term_out,
8766         tee_file::can_emit_style_escape): New functions.
8767
8768 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8769
8770         * NEWS: Mention the new set|show may-call-functions.
8771         * infcall.c (may_call_functions_p): New variable.
8772         (show_may_call_functions_p): New function.
8773         (call_function_by_hand_dummy): Throws an error if not
8774         may-call-functions.
8775         (_initialize_infcall): Call add_setshow_boolean_cmd for
8776         may-call-functions.
8777
8778 2019-04-25  Keith Seitz  <keiths@redhat.com>
8779
8780         PR c++/24367
8781         * cp-support.c (inspect_type): Don't attempt substitutions
8782         of symbol with the same name.
8783
8784 2019-04-25  Tom Tromey  <tromey@adacore.com>
8785
8786         PR gdb/24475:
8787         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8788         static.
8789
8790 2019-04-25  Tom Tromey  <tromey@adacore.com>
8791
8792         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8793         rvalue reference.
8794         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8795         (gdb_xml_parser::parse): Use std::move.
8796         * python/python-internal.h (gdbpy_convert_exception): Take a const
8797         reference.
8798         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8799         std::move.
8800         * python/py-utils.c (gdbpy_convert_exception): Take a const
8801         reference.
8802         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8803         Use std::move.
8804         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8805         Use std::move.
8806         * mi/mi-main.c (mi_print_exception): Take a const reference.
8807         * main.c (handle_command_errors): Take a const reference.
8808         * linespec.c (parse_linespec): Use std::move.
8809         * infcall.c (run_inferior_call): Use std::move.
8810         (call_function_by_hand_dummy): Use std::move.
8811         * exec.c (try_open_exec_file): Use std::move.
8812         * exceptions.h (exception_print, exception_fprintf)
8813         (exception_print_same): Update.
8814         * exceptions.c (print_exception, exception_print)
8815         (exception_fprintf, exception_print_same): Change parameters to
8816         const reference.
8817         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8818         * common/new-op.c: Use std::move.
8819         * common/common-exceptions.h (struct gdb_exception): Add move
8820         constructor.
8821         (struct gdb_exception_error, struct gdb_exception_quit, struct
8822         gdb_quit_bad_alloc): Change constructor to move constructor.
8823         (throw_exception): Change parameter to rvalue reference.
8824         * common/common-exceptions.c (throw_exception): Take rvalue
8825         reference.
8826         * cli/cli-interp.c (safe_execute_command): Use std::move.
8827         * breakpoint.c (insert_bp_location, location_to_sals): Use
8828         std::move.
8829
8830 2019-04-25  Tom Tromey  <tromey@adacore.com>
8831
8832         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8833         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8834         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8835         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8836         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8837         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8838         guile/scm-value.c: Use unpack.
8839         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8840         gdbscm_gdb_exception.
8841         (gdbscm_throw_gdb_exception): Likewise.
8842         (struct gdbscm_gdb_exception): New.
8843         (unpack): New function.
8844         (gdbscm_wrap): Use unpack.
8845
8846 2019-04-25  Tom Tromey  <tromey@adacore.com>
8847
8848         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8849         (gdb_rl_callback_handler): Use std::move.
8850         * common/common-exceptions.h (struct gdb_exception): Add move
8851         assignment operator.
8852         (throw_exception_sjlj): Change "exception" to const reference.
8853         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8854         (throw_exception_sjlj): Change "exception" to const reference.
8855
8856 2019-04-25  Tom Tromey  <tromey@adacore.com>
8857
8858         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8859         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8860         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8861         Update.
8862         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8863         Update.
8864         * mi/mi-interp.c (mi_interp::exec): Update.
8865         * linespec.c (parse_linespec): Update.
8866         * infcall.c (run_inferior_call): Update.
8867         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8868         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8869         (gdbscm_lookup_global_symbol): Update.
8870         * guile/scm-param.c (gdbscm_parameter_value): Update.
8871         * guile/scm-frame.c (gdbscm_frame_read_register)
8872         (gdbscm_frame_read_var): Update.
8873         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8874         * exec.c (try_open_exec_file): Update.
8875         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8876         (gdb_rl_callback_handler): Update.
8877         * common/common-exceptions.h (exception_none): Don't declare.
8878         * common/common-exceptions.c (exception_none): Don't define.
8879         (struct catcher) <exception>: Update.
8880         * cli/cli-interp.c (safe_execute_command): Update.
8881         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8882
8883 2019-04-25  Ali Tamur  <tamur@google.com>
8884
8885         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8886         (read_attribute_value): Likewise.
8887         (dwarf2_read_addr_index): Update comment.
8888         (read_str_index): Add DW_FORM_strx.
8889         (dwarf2_string_attr): Likewise.
8890         (dwarf2_const_value_attr): Likewise.
8891         (dump_die_shallow): Likewise.
8892         (dwarf2_fetch_constant_bytes): Likewise.
8893         (skip_form_bytes): Likewise.
8894         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8895
8896 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8897
8898         PR corefiles/11608
8899         PR corefiles/18187
8900         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8901         OFFSET.  Verify if current mapping contains an ELF header.
8902         (linux_find_memory_regions_full): Adjust call to
8903         dump_mapping_p.
8904
8905 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8906             Kang Li <kanglictf@gmail.com>
8907
8908         PR gdb/21600
8909
8910         * dwarf2-frame.c (read_initial_length): Be consistent about using
8911         unsigned representation of length.
8912         (decode_frame_entry_1): Likewise.  Check for wraparound of
8913         end pointer as well as buffer overflow.
8914
8915 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8916
8917         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8918         "vq".
8919
8920 2019-04-24  Tom Tromey  <tromey@adacore.com>
8921
8922         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8923
8924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * s12z-tdep.c (s12z_unwind_pc): Delete.
8927         (s12z_unwind_sp): Delete.
8928         (s12z_gdbarch_init): Don't register deleted functions with
8929         gdbarch.
8930
8931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * rl78-tdep.c (rl78_unwind_sp): Delete.
8934         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8935
8936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8939         (xstormy16_unwind_pc): Delete.
8940         (xstormy16_dummy_id): Delete.
8941         (xstormy16_gdbarch_init): Don't register deleted functions with
8942         gdbarch.
8943
8944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * vax-tdep.c (vax_unwind_pc): Delete.
8947         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8948
8949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * v850-tdep.c (v850_unwind_sp): Delete.
8952         (v850_unwind_pc): Delete.
8953         (v850_dummy_id): Delete.
8954         (v850_gdbarch_init): Don't register deleted functions with
8955         gdbarch.
8956
8957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8958
8959         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8960         (tilegx_unwind_pc): Delete.
8961         (tilegx_unwind_dummy_id): Delete.
8962         (tilegx_gdbarch_init): Don't register deleted functions with
8963         gdbarch.
8964
8965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8966
8967         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8968         (tic6x_dummy_id): Delete.
8969         (tic6x_gdbarch_init): Don't register deleted functions with
8970         gdbarch.
8971
8972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8973
8974         * sparc-tdep.c (sparc_unwind_pc): Delete.
8975         (sparc32_gdbarch_init): Don't register deleted function with
8976         gdbarch.
8977
8978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8979
8980         * sh-tdep.c (sh_unwind_sp): Delete.
8981         (sh_unwind_pc): Delete.
8982         (sh_dummy_id): Delete.
8983         (sh_gdbarch_init): Don't register deleted functions with
8984         gdbarch.
8985
8986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8987
8988         * score-tdep.c (score_unwind_sp): Delete.
8989         (score_unwind_pc): Delete.
8990         (score_dummy_id): Delete.
8991         (score_gdbarch_init): Don't register deleted functions with
8992         gdbarch.
8993
8994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8995
8996         * rx-tdep.c (rx_unwind_pc): Delete.
8997         (rx_unwind_sp): Delete.
8998         (rx_dummy_id): Delete.
8999         (rx_gdbarch_init): Don't register deleted functions with
9000         gdbarch.  Update comment.
9001
9002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9005         (rs6000_dummy_id): Delete.
9006         (rs6000_gdbarch_init): Don't register deleted functions with
9007         gdbarch.
9008
9009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9010
9011         * or1k-tdep.c (or1k_dummy_id): Delete.
9012         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9013
9014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9015
9016         * nios2-tdep.c (nios2_dummy_id): Delete.
9017         (nios2_unwind_sp): Delete.
9018         (nios2_gdbarch_init): Don't register deleted functions with
9019         gdbarch.
9020
9021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * nds32-tdep.c (nds32_dummy_id): Delete.
9024         (nds32_unwind_pc): Delete.
9025         (nds32_unwind_sp): Delete.
9026         (nds32_gdbarch_init): Don't register deleted functions with
9027         gdbarch.
9028
9029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9030
9031         * msp430-tdep.c (msp430_unwind_pc): Delete.
9032         (msp430_unwind_sp): Delete.
9033         (msp430_dummy_id): Delete.
9034         (msp430_gdbarch_init): Don't register deleted functions with
9035         gdbarch.
9036
9037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9038
9039         * moxie-tdep.c (moxie_unwind_sp): Delete.
9040         (moxie_unwind_pc): Delete.
9041         (moxie_dummy_id): Delete.
9042         (moxie_gdbarch_init): Don't register deleted functions with
9043         gdbarch.
9044
9045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9046
9047         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9048         (mn10300_unwind_pc): Delete.
9049         (mn10300_unwind_sp): Delete.
9050         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9051         mn10300_unwind_sp.
9052         (mn10300_frame_unwind_init): Don't register deleted functions with
9053         gdbarch.
9054
9055 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9056
9057         * mep-tdep.c (mep_unwind_pc): Delete.
9058         (mep_unwind_sp): Delete.
9059         (mep_dummy_id): Delete.
9060         (mep_gdbarch_init): Don't register deleted functions with
9061         gdbarch.
9062
9063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9064
9065         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9066         (m68hc11_unwind_sp): Delete.
9067         (m68hc11_gdbarch_init): Don't register deleted functions with
9068         gdbarch.
9069
9070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9071
9072         * m32r-tdep.c (m32r_unwind_sp): Delete.
9073         (m32r_unwind_pc): Delete.
9074         (m32r_dummy_id): Delete.
9075         (m32r_gdbarch_init): Don't register deleted functions with
9076         gdbarch.
9077
9078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9079
9080         * m32c-tdep.c (m32c_unwind_pc): Delete.
9081         (m32c_unwind_sp): Delete.
9082         (m32c_dummy_id): Delete.
9083         (m32c_gdbarch_init): Don't register deleted functions with
9084         gdbarch.
9085
9086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9089         (lm32_unwind_pc): Delete.
9090         (lm32_dummy_id): Delete.
9091         (lm32_gdbarch_init): Don't register deleted functions with
9092         gdbarch.
9093
9094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9095
9096         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9097         (iq2000_unwind_pc): Delete.
9098         (iq2000_dummy_id): Delete.
9099         (iq2000_gdbarch_init): Don't register deleted functions with
9100         gdbarch.
9101
9102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9103
9104         * nds32-tdep.c (nds32_type_align): Delete.
9105         (nds32_push_dummy_call): Use type_align instead.
9106
9107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9108
9109         * arm-tdep.c (arm_type_align): Only handle vector override case.
9110         (arm_push_dummy_call): Use type_align.
9111         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9112
9113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9116         case.
9117         (pass_on_stack): Use type_align.
9118         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9119         function.
9120
9121 2019-04-23  Tom Tromey  <tromey@adacore.com>
9122
9123         * dwarf2read.c (line_header::file_name_at): Remove unused
9124         overload.
9125
9126 2019-04-23  Tom de Vries  <tdevries@suse.de>
9127
9128         PR gdb/24438
9129         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9130         invocation.
9131
9132
9133 2019-03-27  Ali Tamur  <tamur@google.com>
9134
9135         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9136         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9137         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9138         (dwarf_expr_context::get_addr_index): Likewise
9139         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9140         (symbol_needs_eval_context::get_addr_index): Likewise
9141         (disassemble_dwarf_expression): Add DW_OP_addrx
9142         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9143         (read_cutu_die_from_dwo): Update comment
9144         (skip_one_die): Add DW_FORM_addrx
9145         (read_attribute_value): Likewise
9146         (var_decode_location): Add DW_OP_addrx
9147         (dwarf2_const_value_attr): Add DW_FORM_addrx
9148         (dump_die_shallow): Likewise
9149         (dwarf2_fetch_constant_bytes): Likewise
9150         (decode_locdesc): Add DW_OP_addrx
9151         (skip_form_bytes): Add DW_FORM_addrx
9152
9153 2019-04-22  Ali Tamur  <tamur@google.com>
9154
9155         * MAINTAINERS (Write After Approval): Add self.
9156
9157 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9158
9159         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9160         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9161         (open_symbol_file_object): Likewise.
9162         (svr4_default_sos): Add info parameter.
9163         (svr4_read_so_list): Likewise.
9164         (svr4_current_sos_direct): Adjust functions calls to pass down
9165         info.
9166         (svr4_current_sos_1): Add info parameter.
9167         (svr4_current_sos): Call get_svr4_info, pass info down to
9168         svr4_current_sos_1.
9169         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9170         get_svr4_info.
9171         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9172         get_svr4_info.
9173         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9174         to get_svr4_info.
9175         (probes_table_remove_objfile_probes): Likewise.
9176         (register_solib_event_probe): Add info parameter.
9177         (solist_update_incremental): Pass info parameter down to
9178         svr4_read_so_list.
9179         (disable_probes_interface): Add info parameter.
9180         (svr4_handle_solib_event): Pass current_program_space to
9181         get_svr4_info.  Adjust disable_probes_interface cleanup.
9182         (svr4_create_probe_breakpoints): Add info parameter, pass it
9183         down to register_solib_event_probe.
9184         (svr4_create_solib_event_breakpoints): Add info parameter,
9185         pass it down to svr4_create_probe_breakpoints.
9186         (enable_break): Pass info down to
9187         svr4_create_solib_event_breakpoints.
9188         (svr4_solib_create_inferior_hook): Pass current_program_space to
9189         get_svr4_info.
9190         (svr4_clear_solib): Likewise.
9191
9192 2019-04-22  Pedro Alves  <palves@redhat.com>
9193
9194         * solib-svr4.c (svr4_free_objfile_observer): New.
9195         (probe_and_action::objfile): New field.
9196         (probes_table_htab_remove_objfile_probes)
9197         (probes_table_remove_objfile_probes): New functions.
9198         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9199         in the new probe_and_action.  Don't store the probe in 'lookup'.
9200         (svr4_create_probe_breakpoints): Pass objfile to
9201         register_solib_event_probe.
9202         (_initialize_svr4_solib): Register a free_objfile observer.
9203
9204 2019-04-19  Tom Tromey  <tom@tromey.com>
9205
9206         * common/queue.h: Remove.
9207
9208 2019-04-19  Tom Tromey  <tom@tromey.com>
9209
9210         * event-loop.c: Don't include "common/queue.h".
9211
9212 2019-04-19  Tom Tromey  <tom@tromey.com>
9213
9214         * remote.c (remote_target): Use delete.
9215         * remote-notif.h: Include <list>, not "common/queue.h".
9216         (notif_client_p): Remove typedef.
9217         (remote_notif_state): Add constructor, destructor, initializer.
9218         <notif_queue>: Now a std::list.
9219         (remote_notif_state_xfree): Don't declare.
9220         * remote-notif.c (remote_notif_process, handle_notification)
9221         (remote_notif_state_allocate): Update.
9222         (~remote_notif_state): Rename from remote_notif_state_xfree.
9223
9224 2019-04-19  Tom Tromey  <tom@tromey.com>
9225
9226         * symfile.c (reread_symbols): Update.
9227         * objfiles.c (objfile_register_static_link)
9228         (objfile_lookup_static_link): Update
9229         (~objfile) Don't delete static_links.
9230         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9231
9232 2019-04-19  Tom Tromey  <tom@tromey.com>
9233
9234         * type-stack.h (struct type_stack) <insert>: Constify string.
9235         * type-stack.c (type_stack::insert): Constify string.
9236         * gdbtypes.h (lookup_template_type): Update.
9237         (address_space_name_to_int): Update.
9238         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9239         const.
9240         (lookup_template_type): Make name const.
9241         * c-exp.y: Update rules.
9242         (lex_one_token, classify_name, classify_inner_name)
9243         (c_print_token): Update.
9244         * p-exp.y: Update rules.
9245         (yylex): Update.
9246         * f-exp.y: Update rules.
9247         (yylex): Update.
9248         * d-exp.y: Update rules.
9249         (lex_one_token, classify_name, classify_inner_name): Update.
9250         * parse.c (write_dollar_variable, copy_name): Return std::string.
9251         * parser-defs.h (copy_name): Change return type.
9252         * m2-exp.y: Update rules.
9253         (yylex): Update.
9254         * go-exp.y (lex_one_token): Update.
9255         Update rules.
9256         (classify_unsafe_function, classify_packaged_name)
9257         (classify_name, yylex): Update.
9258
9259 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9260
9261         * configure.ac: add --enable-source-highlight switch.
9262         * configure: Regenerate.
9263         * top.c (print_gdb_version): plumb --enable-source-highlight
9264         status to "show configuration".
9265
9266 2019-04-19  Tom Tromey  <tromey@adacore.com>
9267
9268         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9269         Check ADA_TYPE_P.
9270         (empty_record, ada_template_to_fixed_record_type_1)
9271         (template_to_static_fixed_type)
9272         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9273         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9274         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9275         macros.
9276
9277 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9278
9279         PR symtab/24423:
9280         * source.c (print_source_lines_base): Advance "iter" when a
9281         control character is seen.
9282
9283 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9284
9285         * inferior.h (struct infcall_suspend_state_deleter):
9286         Catch exception in destructor to avoid crash.
9287
9288 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9289
9290         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9291         close to the add_com "shell".
9292
9293 2019-04-18  Tom Tromey  <tromey@adacore.com>
9294
9295         * process-stratum-target.h (class process_stratum_target)
9296         <stratum>: Add "final".
9297
9298 2019-04-17  Tom Tromey  <tromey@adacore.com>
9299
9300         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9301         against nullptr before use.
9302
9303 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9304
9305         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9306
9307 2019-04-17  Jim Wilson  <jimw@sifive.com>
9308             Andrew Burgess  <andrew.burgess@embecosm.com>
9309
9310         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9311         code read might fail, assume 4-byte breakpoint in that case.
9312
9313 2019-04-15  Leszek Swirski  <leszeks@google.com>
9314
9315         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9316         rather than a hand-rolled POD check when checking for forced MEMORY
9317         classification.
9318
9319 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9320
9321         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9322         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9323         function.
9324         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9325         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9326         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9327         declaration.
9328
9329 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9330
9331         * aarch64-linux-nat.c
9332         (aarch64_linux_nat_target::thread_architecture): Add override.
9333         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9334         each VQ.
9335
9336 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9337
9338         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9339
9340 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9343         target types of size 96-bits, add some additional comments, and
9344         check that the builtin type we found was the correct size.
9345
9346 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9347
9348         * utils.c (prompt_for_continue): Don't restore the styling at the
9349         end, as applied_style has the wrong value.  This fixes styling in
9350         long lists of file names that are interrupted by the "Continue?"
9351         prompt.
9352
9353 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9354
9355         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9356         * c-lang.c (c_language_defn): Likewise.
9357         (cplus_language_defn): Likewise.
9358         (asm_language_defn): Likewise.
9359         (minimal_language_defn): Likewise.
9360         * d-lang.c (d_language_defn): Likewise.
9361         * f-lang.c (f_language_defn): Likewise.
9362         * go-lang.c (go_language_defn): Likewise.
9363         * language.c (unknown_language_defn): Likewise.
9364         (auto_language_defn): Likewise.
9365         * language.h (struct language_defn): Remove la_magic field.
9366         (LANG_MAGIC): Delete.
9367         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9368         * objc-lang.c (objc_language_defn): Likewise.
9369         * opencl-lang.c (opencl_language_defn): Likewise.
9370         * p-lang.c (pascal_language_defn): Likewise.
9371         * rust-lang.c (rust_language_defn): Likewise.
9372
9373 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * riscv-tdep.c (riscv_type_align): New function.
9376         (riscv_type_alignment): Delete.
9377         (riscv_arg_location): Use 'type_align'.
9378         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9379
9380 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * gdbtypes.c (type_align): A struct with no non-static fields also
9383         has alignment of 1.
9384
9385 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9388         component to 0.
9389         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9390         member.
9391         (riscv_struct_info::analyse): New implementation using new
9392         analyse_inner member function.
9393         (riscv_struct_info::field_offset): New member function.
9394         (riscv_struct_info::m_offsets): New member variable.
9395         (riscv_struct_info::analyse_inner): New private member function,
9396         takes the old implementation of riscv_struct_info::analyse but
9397         extended to track field offsets.
9398         (riscv_call_arg_struct): Update the struct folding special cases
9399         to handle cases where empty C++ structs, which are non-zero
9400         length, are found.
9401         (riscv_arg_location): Initialise the length of each location, a
9402         non-zero length now indicates the location is in use.
9403         (riscv_push_dummy_call): Allow for the first location having a
9404         non-zero offset when setting up arguments.
9405         (riscv_return_value): Likewise, but for return values.
9406
9407 2019-04-11  Tom Tromey  <tromey@adacore.com>
9408
9409         * utils.c (internal_vproblem): Make "msg" const.
9410
9411 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9412
9413         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9414         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9415         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9416         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9417
9418 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9419
9420         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9421         function.
9422         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9423         of amd64_collect_native_gregset.
9424         (amd64_linux_nat_target::store_registers): Likewise.
9425
9426 2019-04-10  Tom Tromey  <tom@tromey.com>
9427
9428         * symtab.c (lookup_global_symbol_from_objfile)
9429         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9430         * objfiles.h (class separate_debug_iterator): New.
9431         (class separate_debug_range): New.
9432         (struct objfile) <separate_debug_objfiles>: New method.
9433         (objfile_separate_debug_iterate): Don't declare.
9434         * objfiles.c (separate_debug_iterator::operator++): Rename from
9435         objfile_separate_debug_iterate.
9436         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9437         iterator.
9438         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9439         iterator.
9440
9441 2019-04-10  Tom Tromey  <tom@tromey.com>
9442
9443         * symfile.c (reread_symbols): Remove old comment.
9444         * objfiles.c (free_all_objfiles): Fix a typo.
9445
9446 2019-04-10  Tom Tromey  <tom@tromey.com>
9447
9448         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9449         * minsyms.c (lookup_minimal_symbol): Use foreach.
9450         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9451         (lookup_minimal_symbol_solib_trampoline): Likewise.
9452         * symfile.c (reread_symbols): Use foreach.
9453
9454 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9455             Tom Tromey  <tromey@adacore.com>
9456
9457         PR rust/24414:
9458         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9459         (rust_lex_int_test): Change "value" to be LONGEST.
9460         (rust_lex_tests): Add test for long integer literal.
9461
9462 2019-04-09  Tom Tromey  <tromey@adacore.com>
9463
9464         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9465         to bool.
9466         (extended_remote_target::attach): Update.
9467         (remote_target::remote_notice_new_inferior): Update.
9468         (remote_target::add_current_inferior_and_thread): Update.
9469         * inferior.c (exit_inferior_1): Use "false".
9470         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9471
9472 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9473
9474         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9475         the "start" command.
9476
9477 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9478
9479         * python/py-inferior.c (infpy_thread_from_thread_handle):
9480         Adjust comments to reflect renaming of thread_from_thread_handle
9481         to thread_from_handle.  Adjust keywords.  Fix type error message.
9482         (inferior_object_methods): Add thread_from_handle.  Retain
9483         thread_from_thread_handle, but mark it as deprecated.
9484
9485 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9486
9487         * gdbthread.h (find_thread_by_handle): Revise declaration.
9488         * thread.c (find_thread_by_handle): Likewise.  Adjust
9489         implementation too.
9490         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9491         support for buffer objects as handles.
9492
9493 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9494
9495         * python/py-infthread.c (thpy_thread_handle): New function.
9496         (thread_object_methods): Register thpy_thread_handle.
9497
9498 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9499
9500         * gdbthread.h (thread_to_thread_handle): Declare.
9501         * thread.c (gdbtypes.h): Include.
9502         (thread_to_thread_handle): New function.
9503
9504         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9505         (target_thread_info_to_thread_handle): Declare.
9506         * target.c (target_thread_info_to_thread_handle): New function.
9507         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9508         * target-delegates.c: Regenerate.
9509
9510         * linux-thread-db.c (class thread_db_target): Add method
9511         thread_info_to_thread_handle.
9512         (thread_db_target::thread_info_to_thread_handle): Define.
9513         * remote.c (class remote_target): Add new method
9514         thread_info_to_thread_handle.
9515         (remote_target::thread_info_to_thread_handle): Define.
9516
9517 2019-04-08  Pedro Alves  <palves@redhat.com>
9518
9519         * common/common-exceptions.c (throw_exception): Don't create
9520         named object to throw; throw directly.
9521         (throw_it): Likewise.  Don't initialize gdb_exception::message
9522         here, with new; pass FMT and AP to the ctor instead.
9523         * common/common-exceptions.h: Include <string>.
9524         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9525         const char *, va_list)): New ctor.  Use std::make_shared.
9526         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9527         errors)): Delete.
9528         (gdb_exception_error::gdb_exception_error(enum errors, const char
9529         *, va_list)): New.
9530         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9531         Add assertion.
9532         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9533         errors)): Delete.
9534         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9535         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9536         Add assertion.
9537
9538 2019-04-08  Tom Tromey  <tom@tromey.com>
9539
9540         * valops.c (value_rtti_indirect_type): Replace throw_exception
9541         with throw.
9542         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9543         with throw.
9544         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9545         throw.
9546         * target.c (target_translate_tls_address): Replace throw_exception
9547         with throw.
9548         * stack.c (frame_apply_command_count): Replace throw_exception
9549         with throw.
9550         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9551         throw.
9552         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9553         with throw.
9554         * rs6000-tdep.c (rs6000_frame_cache)
9555         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9556         * remote.c: Replace throw_exception with throw.
9557         * record-full.c (record_full_message, record_full_wait_1)
9558         (record_full_restore): Replace throw_exception with throw.
9559         * record-btrace.c:
9560         (get_thread_current_frame_id, record_btrace_start_replaying)
9561         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9562         (cmd_record_btrace_start): Replace throw_exception with throw.
9563         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9564         throw.
9565         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9566         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9567         * linespec.c:
9568         (find_linespec_symbols): Replace throw_exception with throw.
9569         * infrun.c (displaced_step_prepare, resume): Replace
9570         throw_exception with throw.
9571         * infcmd.c (post_create_inferior): Replace throw_exception with
9572         throw.
9573         * inf-loop.c (inferior_event_handler): Replace throw_exception
9574         with throw.
9575         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9576         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9577         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9578         (get_prev_frame_always, get_frame_pc_if_available)
9579         (get_frame_address_in_block_if_available, get_frame_language):
9580         Replace throw_exception with throw.
9581         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9582         throw_exception with throw.
9583         * eval.c (fetch_subexp_value, evaluate_var_value)
9584         (evaluate_funcall, evaluate_subexp_standard): Replace
9585         throw_exception with throw.
9586         * dwarf2loc.c (call_site_find_chain)
9587         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9588         Replace throw_exception with throw.
9589         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9590         with throw.
9591         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9592         throw.
9593         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9594         * completer.c (complete_line_internal): Replace throw_exception
9595         with throw.
9596         * compile/compile-object-run.c (compile_object_run): Replace
9597         throw_exception with throw.
9598         * cli/cli-script.c (process_next_line): Replace throw_exception
9599         with throw.
9600         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9601         (btrace_enable, btrace_maint_update_pt_packets): Replace
9602         throw_exception with throw.
9603         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9604         throw_exception with throw.
9605         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9606         throw_exception with throw.
9607         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9608         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9609         * aarch64-tdep.c (aarch64_make_prologue_cache)
9610         (aarch64_make_stub_cache): Replace throw_exception with throw.
9611
9612 2019-04-08  Tom Tromey  <tom@tromey.com>
9613
9614         * common/common-exceptions.c (throw_exception): Rename from
9615         throw_exception_cxx.  Remove old copy.  Make argument const.
9616         (throw_it): Create and throw exception objects directly.
9617         * common/common-exceptions.h (throw_exception): Make argument
9618         const.
9619         (struct gdb_exception_error): Add constructor.
9620         (struct gdb_exception_quit): Add constructor.
9621
9622 2019-04-08  Tom Tromey  <tom@tromey.com>
9623
9624         * common/common-exceptions.h (exception_rethrow): Don't declare.
9625         (TRY_SJLJ): Update comment.
9626         (TRY, CATCH, END_CATCH): Remove.
9627         * common/common-exceptions.c (exception_rethrow): Remove.
9628
9629 2019-04-08  Tom Tromey  <tom@tromey.com>
9630
9631         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9632         Remove.
9633         (gdb_exception_error): Rename from
9634         gdb_exception_RETURN_MASK_ERROR.
9635         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9636         (gdb_quit_bad_alloc): Update.
9637         * aarch64-tdep.c: Update.
9638         * ada-lang.c: Update.
9639         * ada-typeprint.c: Update.
9640         * ada-valprint.c: Update.
9641         * amd64-tdep.c: Update.
9642         * arch-utils.c: Update.
9643         * break-catch-throw.c: Update.
9644         * breakpoint.c: Update.
9645         * btrace.c: Update.
9646         * c-varobj.c: Update.
9647         * cli/cli-cmds.c: Update.
9648         * cli/cli-interp.c: Update.
9649         * cli/cli-script.c: Update.
9650         * common/common-exceptions.c: Update.
9651         * common/new-op.c: Update.
9652         * common/selftest.c: Update.
9653         * compile/compile-c-symbols.c: Update.
9654         * compile/compile-cplus-symbols.c: Update.
9655         * compile/compile-object-load.c: Update.
9656         * compile/compile-object-run.c: Update.
9657         * completer.c: Update.
9658         * corelow.c: Update.
9659         * cp-abi.c: Update.
9660         * cp-support.c: Update.
9661         * cp-valprint.c: Update.
9662         * darwin-nat.c: Update.
9663         * disasm-selftests.c: Update.
9664         * dtrace-probe.c: Update.
9665         * dwarf-index-cache.c: Update.
9666         * dwarf-index-write.c: Update.
9667         * dwarf2-frame-tailcall.c: Update.
9668         * dwarf2-frame.c: Update.
9669         * dwarf2loc.c: Update.
9670         * dwarf2read.c: Update.
9671         * eval.c: Update.
9672         * event-loop.c: Update.
9673         * event-top.c: Update.
9674         * exec.c: Update.
9675         * f-valprint.c: Update.
9676         * fbsd-tdep.c: Update.
9677         * frame-unwind.c: Update.
9678         * frame.c: Update.
9679         * gdbtypes.c: Update.
9680         * gnu-v3-abi.c: Update.
9681         * guile/guile-internal.h: Update.
9682         * guile/scm-block.c: Update.
9683         * guile/scm-breakpoint.c: Update.
9684         * guile/scm-cmd.c: Update.
9685         * guile/scm-disasm.c: Update.
9686         * guile/scm-frame.c: Update.
9687         * guile/scm-lazy-string.c: Update.
9688         * guile/scm-math.c: Update.
9689         * guile/scm-param.c: Update.
9690         * guile/scm-ports.c: Update.
9691         * guile/scm-pretty-print.c: Update.
9692         * guile/scm-symbol.c: Update.
9693         * guile/scm-symtab.c: Update.
9694         * guile/scm-type.c: Update.
9695         * guile/scm-value.c: Update.
9696         * i386-linux-tdep.c: Update.
9697         * i386-tdep.c: Update.
9698         * inf-loop.c: Update.
9699         * infcall.c: Update.
9700         * infcmd.c: Update.
9701         * infrun.c: Update.
9702         * jit.c: Update.
9703         * language.c: Update.
9704         * linespec.c: Update.
9705         * linux-fork.c: Update.
9706         * linux-nat.c: Update.
9707         * linux-tdep.c: Update.
9708         * linux-thread-db.c: Update.
9709         * main.c: Update.
9710         * mi/mi-cmd-break.c: Update.
9711         * mi/mi-cmd-stack.c: Update.
9712         * mi/mi-interp.c: Update.
9713         * mi/mi-main.c: Update.
9714         * objc-lang.c: Update.
9715         * p-valprint.c: Update.
9716         * parse.c: Update.
9717         * ppc-linux-tdep.c: Update.
9718         * printcmd.c: Update.
9719         * python/py-arch.c: Update.
9720         * python/py-breakpoint.c: Update.
9721         * python/py-cmd.c: Update.
9722         * python/py-finishbreakpoint.c: Update.
9723         * python/py-frame.c: Update.
9724         * python/py-framefilter.c: Update.
9725         * python/py-gdb-readline.c: Update.
9726         * python/py-inferior.c: Update.
9727         * python/py-infthread.c: Update.
9728         * python/py-lazy-string.c: Update.
9729         * python/py-linetable.c: Update.
9730         * python/py-objfile.c: Update.
9731         * python/py-param.c: Update.
9732         * python/py-prettyprint.c: Update.
9733         * python/py-progspace.c: Update.
9734         * python/py-record-btrace.c: Update.
9735         * python/py-record.c: Update.
9736         * python/py-symbol.c: Update.
9737         * python/py-type.c: Update.
9738         * python/py-unwind.c: Update.
9739         * python/py-utils.c: Update.
9740         * python/py-value.c: Update.
9741         * python/python.c: Update.
9742         * record-btrace.c: Update.
9743         * record-full.c: Update.
9744         * remote-fileio.c: Update.
9745         * remote.c: Update.
9746         * riscv-tdep.c: Update.
9747         * rs6000-aix-tdep.c: Update.
9748         * rs6000-tdep.c: Update.
9749         * rust-exp.y: Update.
9750         * rust-lang.c: Update.
9751         * s390-tdep.c: Update.
9752         * selftest-arch.c: Update.
9753         * solib-dsbt.c: Update.
9754         * solib-frv.c: Update.
9755         * solib-spu.c: Update.
9756         * solib-svr4.c: Update.
9757         * solib.c: Update.
9758         * sparc64-linux-tdep.c: Update.
9759         * stack.c: Update.
9760         * symfile-mem.c: Update.
9761         * symmisc.c: Update.
9762         * target.c: Update.
9763         * thread.c: Update.
9764         * top.c: Update.
9765         * tracefile-tfile.c: Update.
9766         * tui/tui.c: Update.
9767         * typeprint.c: Update.
9768         * unittests/cli-utils-selftests.c: Update.
9769         * unittests/parse-connection-spec-selftests.c: Update.
9770         * valops.c: Update.
9771         * valprint.c: Update.
9772         * value.c: Update.
9773         * varobj.c: Update.
9774         * windows-nat.c: Update.
9775         * x86-linux-nat.c: Update.
9776         * xml-support.c: Update.
9777
9778 2019-04-08  Tom Tromey  <tom@tromey.com>
9779
9780         * xml-support.c: Use C++ exception handling.
9781         * x86-linux-nat.c: Use C++ exception handling.
9782         * windows-nat.c: Use C++ exception handling.
9783         * varobj.c: Use C++ exception handling.
9784         * value.c: Use C++ exception handling.
9785         * valprint.c: Use C++ exception handling.
9786         * valops.c: Use C++ exception handling.
9787         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9788         handling.
9789         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9790         * typeprint.c: Use C++ exception handling.
9791         * tui/tui.c: Use C++ exception handling.
9792         * tracefile-tfile.c: Use C++ exception handling.
9793         * top.c: Use C++ exception handling.
9794         * thread.c: Use C++ exception handling.
9795         * target.c: Use C++ exception handling.
9796         * symmisc.c: Use C++ exception handling.
9797         * symfile-mem.c: Use C++ exception handling.
9798         * stack.c: Use C++ exception handling.
9799         * sparc64-linux-tdep.c: Use C++ exception handling.
9800         * solib.c: Use C++ exception handling.
9801         * solib-svr4.c: Use C++ exception handling.
9802         * solib-spu.c: Use C++ exception handling.
9803         * solib-frv.c: Use C++ exception handling.
9804         * solib-dsbt.c: Use C++ exception handling.
9805         * selftest-arch.c: Use C++ exception handling.
9806         * s390-tdep.c: Use C++ exception handling.
9807         * rust-lang.c: Use C++ exception handling.
9808         * rust-exp.y: Use C++ exception handling.
9809         * rs6000-tdep.c: Use C++ exception handling.
9810         * rs6000-aix-tdep.c: Use C++ exception handling.
9811         * riscv-tdep.c: Use C++ exception handling.
9812         * remote.c: Use C++ exception handling.
9813         * remote-fileio.c: Use C++ exception handling.
9814         * record-full.c: Use C++ exception handling.
9815         * record-btrace.c: Use C++ exception handling.
9816         * python/python.c: Use C++ exception handling.
9817         * python/py-value.c: Use C++ exception handling.
9818         * python/py-utils.c: Use C++ exception handling.
9819         * python/py-unwind.c: Use C++ exception handling.
9820         * python/py-type.c: Use C++ exception handling.
9821         * python/py-symbol.c: Use C++ exception handling.
9822         * python/py-record.c: Use C++ exception handling.
9823         * python/py-record-btrace.c: Use C++ exception handling.
9824         * python/py-progspace.c: Use C++ exception handling.
9825         * python/py-prettyprint.c: Use C++ exception handling.
9826         * python/py-param.c: Use C++ exception handling.
9827         * python/py-objfile.c: Use C++ exception handling.
9828         * python/py-linetable.c: Use C++ exception handling.
9829         * python/py-lazy-string.c: Use C++ exception handling.
9830         * python/py-infthread.c: Use C++ exception handling.
9831         * python/py-inferior.c: Use C++ exception handling.
9832         * python/py-gdb-readline.c: Use C++ exception handling.
9833         * python/py-framefilter.c: Use C++ exception handling.
9834         * python/py-frame.c: Use C++ exception handling.
9835         * python/py-finishbreakpoint.c: Use C++ exception handling.
9836         * python/py-cmd.c: Use C++ exception handling.
9837         * python/py-breakpoint.c: Use C++ exception handling.
9838         * python/py-arch.c: Use C++ exception handling.
9839         * printcmd.c: Use C++ exception handling.
9840         * ppc-linux-tdep.c: Use C++ exception handling.
9841         * parse.c: Use C++ exception handling.
9842         * p-valprint.c: Use C++ exception handling.
9843         * objc-lang.c: Use C++ exception handling.
9844         * mi/mi-main.c: Use C++ exception handling.
9845         * mi/mi-interp.c: Use C++ exception handling.
9846         * mi/mi-cmd-stack.c: Use C++ exception handling.
9847         * mi/mi-cmd-break.c: Use C++ exception handling.
9848         * main.c: Use C++ exception handling.
9849         * linux-thread-db.c: Use C++ exception handling.
9850         * linux-tdep.c: Use C++ exception handling.
9851         * linux-nat.c: Use C++ exception handling.
9852         * linux-fork.c: Use C++ exception handling.
9853         * linespec.c: Use C++ exception handling.
9854         * language.c: Use C++ exception handling.
9855         * jit.c: Use C++ exception handling.
9856         * infrun.c: Use C++ exception handling.
9857         * infcmd.c: Use C++ exception handling.
9858         * infcall.c: Use C++ exception handling.
9859         * inf-loop.c: Use C++ exception handling.
9860         * i386-tdep.c: Use C++ exception handling.
9861         * i386-linux-tdep.c: Use C++ exception handling.
9862         * guile/scm-value.c: Use C++ exception handling.
9863         * guile/scm-type.c: Use C++ exception handling.
9864         * guile/scm-symtab.c: Use C++ exception handling.
9865         * guile/scm-symbol.c: Use C++ exception handling.
9866         * guile/scm-pretty-print.c: Use C++ exception handling.
9867         * guile/scm-ports.c: Use C++ exception handling.
9868         * guile/scm-param.c: Use C++ exception handling.
9869         * guile/scm-math.c: Use C++ exception handling.
9870         * guile/scm-lazy-string.c: Use C++ exception handling.
9871         * guile/scm-frame.c: Use C++ exception handling.
9872         * guile/scm-disasm.c: Use C++ exception handling.
9873         * guile/scm-cmd.c: Use C++ exception handling.
9874         * guile/scm-breakpoint.c: Use C++ exception handling.
9875         * guile/scm-block.c: Use C++ exception handling.
9876         * guile/guile-internal.h: Use C++ exception handling.
9877         * gnu-v3-abi.c: Use C++ exception handling.
9878         * gdbtypes.c: Use C++ exception handling.
9879         * frame.c: Use C++ exception handling.
9880         * frame-unwind.c: Use C++ exception handling.
9881         * fbsd-tdep.c: Use C++ exception handling.
9882         * f-valprint.c: Use C++ exception handling.
9883         * exec.c: Use C++ exception handling.
9884         * event-top.c: Use C++ exception handling.
9885         * event-loop.c: Use C++ exception handling.
9886         * eval.c: Use C++ exception handling.
9887         * dwarf2read.c: Use C++ exception handling.
9888         * dwarf2loc.c: Use C++ exception handling.
9889         * dwarf2-frame.c: Use C++ exception handling.
9890         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9891         * dwarf-index-write.c: Use C++ exception handling.
9892         * dwarf-index-cache.c: Use C++ exception handling.
9893         * dtrace-probe.c: Use C++ exception handling.
9894         * disasm-selftests.c: Use C++ exception handling.
9895         * darwin-nat.c: Use C++ exception handling.
9896         * cp-valprint.c: Use C++ exception handling.
9897         * cp-support.c: Use C++ exception handling.
9898         * cp-abi.c: Use C++ exception handling.
9899         * corelow.c: Use C++ exception handling.
9900         * completer.c: Use C++ exception handling.
9901         * compile/compile-object-run.c: Use C++ exception handling.
9902         * compile/compile-object-load.c: Use C++ exception handling.
9903         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9904         * compile/compile-c-symbols.c: Use C++ exception handling.
9905         * common/selftest.c: Use C++ exception handling.
9906         * common/new-op.c: Use C++ exception handling.
9907         * cli/cli-script.c: Use C++ exception handling.
9908         * cli/cli-interp.c: Use C++ exception handling.
9909         * cli/cli-cmds.c: Use C++ exception handling.
9910         * c-varobj.c: Use C++ exception handling.
9911         * btrace.c: Use C++ exception handling.
9912         * breakpoint.c: Use C++ exception handling.
9913         * break-catch-throw.c: Use C++ exception handling.
9914         * arch-utils.c: Use C++ exception handling.
9915         * amd64-tdep.c: Use C++ exception handling.
9916         * ada-valprint.c: Use C++ exception handling.
9917         * ada-typeprint.c: Use C++ exception handling.
9918         * ada-lang.c: Use C++ exception handling.
9919         * aarch64-tdep.c: Use C++ exception handling.
9920
9921 2019-04-08  Tom Tromey  <tom@tromey.com>
9922
9923         * xml-support.c (gdb_xml_parser::parse): Update.
9924         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9925         * value.c (show_convenience): Update.
9926         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9927         (test_parse_flags_qcs): Update.
9928         * thread.c (thr_try_catch_cmd): Update.
9929         * target.c (target_translate_tls_address): Update.
9930         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9931         (info_frame_command_core, frame_apply_command_count): Update.
9932         * rust-exp.y (rust_lex_exception_test): Update.
9933         * riscv-tdep.c (riscv_print_one_register_info): Update.
9934         * remote.c (remote_target::enable_btrace): Update.
9935         * record-btrace.c (record_btrace_enable_warn): Update.
9936         * python/py-utils.c (gdbpy_convert_exception): Update.
9937         * printcmd.c (do_one_display, print_variable_and_value): Update.
9938         * mi/mi-main.c (mi_print_exception): Update.
9939         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9940         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9941         * linux-nat.c (linux_nat_target::attach): Update.
9942         * linux-fork.c (class scoped_switch_fork_info): Update.
9943         * infrun.c (displaced_step_prepare): Update.
9944         * infcall.c (call_function_by_hand_dummy): Update.
9945         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9946         * gnu-v3-abi.c (print_one_vtable): Update.
9947         * frame.c (get_prev_frame_always): Update.
9948         * f-valprint.c (info_common_command_for_block): Update.
9949         * exec.c (try_open_exec_file): Update.
9950         * exceptions.c (print_exception, exception_print)
9951         (exception_fprintf, exception_print_same): Update.
9952         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9953         * dwarf-index-cache.c (index_cache::store)
9954         (index_cache::lookup_gdb_index): Update.
9955         * darwin-nat.c (maybe_cache_shell): Update.
9956         * cp-valprint.c (cp_print_value_fields): Update.
9957         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9958         (gcc_cplus_symbol_address): Update.
9959         * compile/compile-c-symbols.c (gcc_convert_symbol)
9960         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9961         * common/selftest.c: Update.
9962         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9963         a std::string.
9964         (exception_try_scope_entry, exception_try_scope_exit): Don't
9965         declare.
9966         (struct exception_try_scope): Remove.
9967         (TRY): Don't use exception_try_scope.
9968         (struct gdb_exception): Add constructor, operator=.
9969         <what>: New method.
9970         (struct gdb_exception_RETURN_MASK_ALL)
9971         (struct gdb_exception_RETURN_MASK_ERROR)
9972         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9973         (struct gdb_quit_bad_alloc): Update.
9974         * common/common-exceptions.c (exception_none): Change
9975         initializer.
9976         (struct catcher) <state, exception>: Initialize inline.
9977         <prev>: Remove member.
9978         (current_catcher): Remove.
9979         (catchers): New global.
9980         (exceptions_state_mc_init): Simplify.
9981         (catcher_pop): Remove.
9982         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9983         (try_scope_depth, exception_try_scope_entry)
9984         (exception_try_scope_exit): Remove.
9985         (throw_exception_sjlj): Update.
9986         (exception_messages, exception_messages_size): Remove.
9987         (throw_it): Simplify.
9988         (gdb_exception_sliced_copy): Remove.
9989         (throw_exception_cxx): Update.
9990         * cli/cli-script.c (script_from_file): Update.
9991         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9992         Update.
9993         * ada-valprint.c (ada_val_print): Update.
9994         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9995         (create_excep_cond_exprs): Update.
9996
9997 2019-04-08  Tom Tromey  <tom@tromey.com>
9998
9999         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10000         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10001         (TRY, CATCH, END_CATCH): Remove some definitions.
10002         * common/common-exceptions.c: Don't use GDB_XCPT.
10003         (catcher_list_size): Remove.
10004         (throw_exception, throw_it): Simplify.
10005
10006 2019-04-05  Tom Tromey  <tom@tromey.com>
10007
10008         Revert the header-sorting patch.
10009         * ft32-tdep.c: Revert.
10010         * frv-tdep.c: Revert.
10011         * frv-linux-tdep.c: Revert.
10012         * frame.c: Revert.
10013         * frame-unwind.c: Revert.
10014         * frame-base.c: Revert.
10015         * fork-child.c: Revert.
10016         * findvar.c: Revert.
10017         * findcmd.c: Revert.
10018         * filesystem.c: Revert.
10019         * filename-seen-cache.h: Revert.
10020         * filename-seen-cache.c: Revert.
10021         * fbsd-tdep.c: Revert.
10022         * fbsd-nat.h: Revert.
10023         * fbsd-nat.c: Revert.
10024         * f-valprint.c: Revert.
10025         * f-typeprint.c: Revert.
10026         * f-lang.c: Revert.
10027         * extension.h: Revert.
10028         * extension.c: Revert.
10029         * extension-priv.h: Revert.
10030         * expprint.c: Revert.
10031         * exec.h: Revert.
10032         * exec.c: Revert.
10033         * exceptions.c: Revert.
10034         * event-top.c: Revert.
10035         * event-loop.c: Revert.
10036         * eval.c: Revert.
10037         * elfread.c: Revert.
10038         * dwarf2read.h: Revert.
10039         * dwarf2read.c: Revert.
10040         * dwarf2loc.c: Revert.
10041         * dwarf2expr.h: Revert.
10042         * dwarf2expr.c: Revert.
10043         * dwarf2-frame.c: Revert.
10044         * dwarf2-frame-tailcall.c: Revert.
10045         * dwarf-index-write.h: Revert.
10046         * dwarf-index-write.c: Revert.
10047         * dwarf-index-common.c: Revert.
10048         * dwarf-index-cache.h: Revert.
10049         * dwarf-index-cache.c: Revert.
10050         * dummy-frame.c: Revert.
10051         * dtrace-probe.c: Revert.
10052         * disasm.h: Revert.
10053         * disasm.c: Revert.
10054         * disasm-selftests.c: Revert.
10055         * dictionary.c: Revert.
10056         * dicos-tdep.c: Revert.
10057         * demangle.c: Revert.
10058         * dcache.h: Revert.
10059         * dcache.c: Revert.
10060         * darwin-nat.h: Revert.
10061         * darwin-nat.c: Revert.
10062         * darwin-nat-info.c: Revert.
10063         * d-valprint.c: Revert.
10064         * d-namespace.c: Revert.
10065         * d-lang.c: Revert.
10066         * ctf.c: Revert.
10067         * csky-tdep.c: Revert.
10068         * csky-linux-tdep.c: Revert.
10069         * cris-tdep.c: Revert.
10070         * cris-linux-tdep.c: Revert.
10071         * cp-valprint.c: Revert.
10072         * cp-support.c: Revert.
10073         * cp-namespace.c: Revert.
10074         * cp-abi.c: Revert.
10075         * corelow.c: Revert.
10076         * corefile.c: Revert.
10077         * continuations.c: Revert.
10078         * completer.h: Revert.
10079         * completer.c: Revert.
10080         * complaints.c: Revert.
10081         * coffread.c: Revert.
10082         * coff-pe-read.c: Revert.
10083         * cli-out.h: Revert.
10084         * cli-out.c: Revert.
10085         * charset.c: Revert.
10086         * c-varobj.c: Revert.
10087         * c-valprint.c: Revert.
10088         * c-typeprint.c: Revert.
10089         * c-lang.c: Revert.
10090         * buildsym.c: Revert.
10091         * buildsym-legacy.c: Revert.
10092         * build-id.h: Revert.
10093         * build-id.c: Revert.
10094         * btrace.c: Revert.
10095         * bsd-uthread.c: Revert.
10096         * breakpoint.h: Revert.
10097         * breakpoint.c: Revert.
10098         * break-catch-throw.c: Revert.
10099         * break-catch-syscall.c: Revert.
10100         * break-catch-sig.c: Revert.
10101         * blockframe.c: Revert.
10102         * block.c: Revert.
10103         * bfin-tdep.c: Revert.
10104         * bfin-linux-tdep.c: Revert.
10105         * bfd-target.c: Revert.
10106         * bcache.c: Revert.
10107         * ax-general.c: Revert.
10108         * ax-gdb.h: Revert.
10109         * ax-gdb.c: Revert.
10110         * avr-tdep.c: Revert.
10111         * auxv.c: Revert.
10112         * auto-load.c: Revert.
10113         * arm-wince-tdep.c: Revert.
10114         * arm-tdep.c: Revert.
10115         * arm-symbian-tdep.c: Revert.
10116         * arm-pikeos-tdep.c: Revert.
10117         * arm-obsd-tdep.c: Revert.
10118         * arm-nbsd-tdep.c: Revert.
10119         * arm-nbsd-nat.c: Revert.
10120         * arm-linux-tdep.c: Revert.
10121         * arm-linux-nat.c: Revert.
10122         * arm-fbsd-tdep.c: Revert.
10123         * arm-fbsd-nat.c: Revert.
10124         * arm-bsd-tdep.c: Revert.
10125         * arch-utils.c: Revert.
10126         * arc-tdep.c: Revert.
10127         * arc-newlib-tdep.c: Revert.
10128         * annotate.h: Revert.
10129         * annotate.c: Revert.
10130         * amd64-windows-tdep.c: Revert.
10131         * amd64-windows-nat.c: Revert.
10132         * amd64-tdep.c: Revert.
10133         * amd64-sol2-tdep.c: Revert.
10134         * amd64-obsd-tdep.c: Revert.
10135         * amd64-obsd-nat.c: Revert.
10136         * amd64-nbsd-tdep.c: Revert.
10137         * amd64-nbsd-nat.c: Revert.
10138         * amd64-nat.c: Revert.
10139         * amd64-linux-tdep.c: Revert.
10140         * amd64-linux-nat.c: Revert.
10141         * amd64-fbsd-tdep.c: Revert.
10142         * amd64-fbsd-nat.c: Revert.
10143         * amd64-dicos-tdep.c: Revert.
10144         * amd64-darwin-tdep.c: Revert.
10145         * amd64-bsd-nat.c: Revert.
10146         * alpha-tdep.c: Revert.
10147         * alpha-obsd-tdep.c: Revert.
10148         * alpha-nbsd-tdep.c: Revert.
10149         * alpha-mdebug-tdep.c: Revert.
10150         * alpha-linux-tdep.c: Revert.
10151         * alpha-linux-nat.c: Revert.
10152         * alpha-bsd-tdep.c: Revert.
10153         * alpha-bsd-nat.c: Revert.
10154         * aix-thread.c: Revert.
10155         * agent.c: Revert.
10156         * addrmap.c: Revert.
10157         * ada-varobj.c: Revert.
10158         * ada-valprint.c: Revert.
10159         * ada-typeprint.c: Revert.
10160         * ada-tasks.c: Revert.
10161         * ada-lang.c: Revert.
10162         * aarch64-tdep.c: Revert.
10163         * aarch64-ravenscar-thread.c: Revert.
10164         * aarch64-newlib-tdep.c: Revert.
10165         * aarch64-linux-tdep.c: Revert.
10166         * aarch64-linux-nat.c: Revert.
10167         * aarch64-fbsd-tdep.c: Revert.
10168         * aarch64-fbsd-nat.c: Revert.
10169         * aarch32-linux-nat.c: Revert.
10170
10171 2019-04-05  Tom Tromey  <tom@tromey.com>
10172
10173         * ft32-tdep.c: Sort headers.
10174         * frv-tdep.c: Sort headers.
10175         * frv-linux-tdep.c: Sort headers.
10176         * frame.c: Sort headers.
10177         * frame-unwind.c: Sort headers.
10178         * frame-base.c: Sort headers.
10179         * fork-child.c: Sort headers.
10180         * findvar.c: Sort headers.
10181         * findcmd.c: Sort headers.
10182         * filesystem.c: Sort headers.
10183         * filename-seen-cache.h: Sort headers.
10184         * filename-seen-cache.c: Sort headers.
10185         * fbsd-tdep.c: Sort headers.
10186         * fbsd-nat.h: Sort headers.
10187         * fbsd-nat.c: Sort headers.
10188         * f-valprint.c: Sort headers.
10189         * f-typeprint.c: Sort headers.
10190         * f-lang.c: Sort headers.
10191         * extension.h: Sort headers.
10192         * extension.c: Sort headers.
10193         * extension-priv.h: Sort headers.
10194         * expprint.c: Sort headers.
10195         * exec.h: Sort headers.
10196         * exec.c: Sort headers.
10197         * exceptions.c: Sort headers.
10198         * event-top.c: Sort headers.
10199         * event-loop.c: Sort headers.
10200         * eval.c: Sort headers.
10201         * elfread.c: Sort headers.
10202         * dwarf2read.h: Sort headers.
10203         * dwarf2read.c: Sort headers.
10204         * dwarf2loc.c: Sort headers.
10205         * dwarf2expr.h: Sort headers.
10206         * dwarf2expr.c: Sort headers.
10207         * dwarf2-frame.c: Sort headers.
10208         * dwarf2-frame-tailcall.c: Sort headers.
10209         * dwarf-index-write.h: Sort headers.
10210         * dwarf-index-write.c: Sort headers.
10211         * dwarf-index-common.c: Sort headers.
10212         * dwarf-index-cache.h: Sort headers.
10213         * dwarf-index-cache.c: Sort headers.
10214         * dummy-frame.c: Sort headers.
10215         * dtrace-probe.c: Sort headers.
10216         * disasm.h: Sort headers.
10217         * disasm.c: Sort headers.
10218         * disasm-selftests.c: Sort headers.
10219         * dictionary.c: Sort headers.
10220         * dicos-tdep.c: Sort headers.
10221         * demangle.c: Sort headers.
10222         * dcache.h: Sort headers.
10223         * dcache.c: Sort headers.
10224         * darwin-nat.h: Sort headers.
10225         * darwin-nat.c: Sort headers.
10226         * darwin-nat-info.c: Sort headers.
10227         * d-valprint.c: Sort headers.
10228         * d-namespace.c: Sort headers.
10229         * d-lang.c: Sort headers.
10230         * ctf.c: Sort headers.
10231         * csky-tdep.c: Sort headers.
10232         * csky-linux-tdep.c: Sort headers.
10233         * cris-tdep.c: Sort headers.
10234         * cris-linux-tdep.c: Sort headers.
10235         * cp-valprint.c: Sort headers.
10236         * cp-support.c: Sort headers.
10237         * cp-namespace.c: Sort headers.
10238         * cp-abi.c: Sort headers.
10239         * corelow.c: Sort headers.
10240         * corefile.c: Sort headers.
10241         * continuations.c: Sort headers.
10242         * completer.h: Sort headers.
10243         * completer.c: Sort headers.
10244         * complaints.c: Sort headers.
10245         * coffread.c: Sort headers.
10246         * coff-pe-read.c: Sort headers.
10247         * cli-out.h: Sort headers.
10248         * cli-out.c: Sort headers.
10249         * charset.c: Sort headers.
10250         * c-varobj.c: Sort headers.
10251         * c-valprint.c: Sort headers.
10252         * c-typeprint.c: Sort headers.
10253         * c-lang.c: Sort headers.
10254         * buildsym.c: Sort headers.
10255         * buildsym-legacy.c: Sort headers.
10256         * build-id.h: Sort headers.
10257         * build-id.c: Sort headers.
10258         * btrace.c: Sort headers.
10259         * bsd-uthread.c: Sort headers.
10260         * breakpoint.h: Sort headers.
10261         * breakpoint.c: Sort headers.
10262         * break-catch-throw.c: Sort headers.
10263         * break-catch-syscall.c: Sort headers.
10264         * break-catch-sig.c: Sort headers.
10265         * blockframe.c: Sort headers.
10266         * block.c: Sort headers.
10267         * bfin-tdep.c: Sort headers.
10268         * bfin-linux-tdep.c: Sort headers.
10269         * bfd-target.c: Sort headers.
10270         * bcache.c: Sort headers.
10271         * ax-general.c: Sort headers.
10272         * ax-gdb.h: Sort headers.
10273         * ax-gdb.c: Sort headers.
10274         * avr-tdep.c: Sort headers.
10275         * auxv.c: Sort headers.
10276         * auto-load.c: Sort headers.
10277         * arm-wince-tdep.c: Sort headers.
10278         * arm-tdep.c: Sort headers.
10279         * arm-symbian-tdep.c: Sort headers.
10280         * arm-pikeos-tdep.c: Sort headers.
10281         * arm-obsd-tdep.c: Sort headers.
10282         * arm-nbsd-tdep.c: Sort headers.
10283         * arm-nbsd-nat.c: Sort headers.
10284         * arm-linux-tdep.c: Sort headers.
10285         * arm-linux-nat.c: Sort headers.
10286         * arm-fbsd-tdep.c: Sort headers.
10287         * arm-fbsd-nat.c: Sort headers.
10288         * arm-bsd-tdep.c: Sort headers.
10289         * arch-utils.c: Sort headers.
10290         * arc-tdep.c: Sort headers.
10291         * arc-newlib-tdep.c: Sort headers.
10292         * annotate.h: Sort headers.
10293         * annotate.c: Sort headers.
10294         * amd64-windows-tdep.c: Sort headers.
10295         * amd64-windows-nat.c: Sort headers.
10296         * amd64-tdep.c: Sort headers.
10297         * amd64-sol2-tdep.c: Sort headers.
10298         * amd64-obsd-tdep.c: Sort headers.
10299         * amd64-obsd-nat.c: Sort headers.
10300         * amd64-nbsd-tdep.c: Sort headers.
10301         * amd64-nbsd-nat.c: Sort headers.
10302         * amd64-nat.c: Sort headers.
10303         * amd64-linux-tdep.c: Sort headers.
10304         * amd64-linux-nat.c: Sort headers.
10305         * amd64-fbsd-tdep.c: Sort headers.
10306         * amd64-fbsd-nat.c: Sort headers.
10307         * amd64-dicos-tdep.c: Sort headers.
10308         * amd64-darwin-tdep.c: Sort headers.
10309         * amd64-bsd-nat.c: Sort headers.
10310         * alpha-tdep.c: Sort headers.
10311         * alpha-obsd-tdep.c: Sort headers.
10312         * alpha-nbsd-tdep.c: Sort headers.
10313         * alpha-mdebug-tdep.c: Sort headers.
10314         * alpha-linux-tdep.c: Sort headers.
10315         * alpha-linux-nat.c: Sort headers.
10316         * alpha-bsd-tdep.c: Sort headers.
10317         * alpha-bsd-nat.c: Sort headers.
10318         * aix-thread.c: Sort headers.
10319         * agent.c: Sort headers.
10320         * addrmap.c: Sort headers.
10321         * ada-varobj.c: Sort headers.
10322         * ada-valprint.c: Sort headers.
10323         * ada-typeprint.c: Sort headers.
10324         * ada-tasks.c: Sort headers.
10325         * ada-lang.c: Sort headers.
10326         * aarch64-tdep.c: Sort headers.
10327         * aarch64-ravenscar-thread.c: Sort headers.
10328         * aarch64-newlib-tdep.c: Sort headers.
10329         * aarch64-linux-tdep.c: Sort headers.
10330         * aarch64-linux-nat.c: Sort headers.
10331         * aarch64-fbsd-tdep.c: Sort headers.
10332         * aarch64-fbsd-nat.c: Sort headers.
10333         * aarch32-linux-nat.c: Sort headers.
10334
10335 2019-04-04  Tom Tromey  <tom@tromey.com>
10336
10337         * varobj.c (varobj_create): Update.
10338         * rust-exp.y (struct rust_parser) <update_innermost_block,
10339         lookup_symbol>: New methods.
10340         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10341         Rename.
10342         (rust_parser::rust_lookup_type)
10343         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10344         * printcmd.c (display_command, do_one_display): Update.
10345         * parser-defs.h (struct parser_state) <parser_state>: Add
10346         "tracker" parameter.
10347         (block_tracker): New member.
10348         (class innermost_block_tracker) <innermost_block_tracker>: Add
10349         "types" parameter.
10350         <reset>: Remove method.
10351         (innermost_block): Don't declare.
10352         (null_post_parser): Update.
10353         * parse.c (innermost_block): Remove global.
10354         (write_dollar_variable): Update.
10355         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10356         Remove "tracker_types" parameter.
10357         (parse_expression): Add "tracker" parameter.
10358         (parse_expression_for_completion): Update.
10359         (null_post_parser): Add "tracker" parameter.
10360         * p-exp.y: Update rules.
10361         * m2-exp.y: Update rules.
10362         * language.h (struct language_defn) <la_post_parser>: Add
10363         "tracker" parameter.
10364         * go-exp.y: Update rules.
10365         * f-exp.y: Update rules.
10366         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10367         parameter.
10368         * d-exp.y: Update rules.
10369         * c-exp.y: Update rules.
10370         * breakpoint.c (set_breakpoint_condition): Create an
10371         innermost_block_tracker.
10372         (watch_command_1): Likewise.
10373         * ada-lang.c (resolve): Add "tracker" parameter.
10374         (resolve_subexp): Likewise.
10375         * ada-exp.y (write_var_from_sym): Update.
10376
10377 2019-04-04  Tom Tromey  <tom@tromey.com>
10378
10379         * type-stack.h: New file.
10380         * type-stack.c: New file.
10381         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10382         type-stack.h.
10383         (insert_into_type_stack, insert_type, push_type, push_type_int)
10384         (insert_type_address_space, pop_type, pop_type_int)
10385         (pop_typelist, pop_type_stack, append_type_stack)
10386         (push_type_stack, get_type_stack, push_typelist)
10387         (follow_type_instance_flags, follow_types): Don't declare.
10388         * parse.c (type_stack): Remove global.
10389         (parse_exp_in_context): Update.
10390         (insert_into_type_stack, insert_type, push_type, push_type_int)
10391         (insert_type_address_space, pop_type, pop_type_int)
10392         (pop_typelist, pop_type_stack, append_type_stack)
10393         (push_type_stack, get_type_stack, push_typelist)
10394         (follow_type_instance_flags, follow_types): Remove (moved to
10395         type-stack.c).
10396         * f-exp.y (type_stack): New global.
10397         Update rules.
10398         (push_kind_type, f_parse): Update.
10399         * d-exp.y (type_stack): New global.
10400         Update rules.
10401         (d_parse): Update.
10402         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10403         Update rules.
10404         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10405         (HFILES_NO_SRCDIR): Add type-stack.h.
10406
10407 2019-04-04  Tom Tromey  <tom@tromey.com>
10408
10409         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10410         (rust_parser::convert_ast_to_expression, rust_parse)
10411         (rust_lex_test_completion, rust_lex_tests): Update.
10412         * parser-defs.h (struct expr_completion_state): New.
10413         (struct parser_state) <parser_state>: Add completion parameter.
10414         <mark_struct_expression, mark_completion_tag>: New methods.
10415         <parse_completion, m_completion_state>: New members.
10416         (prefixify_expression, null_post_parser): Update.
10417         (mark_struct_expression, mark_completion_tag): Don't declare.
10418         * parse.c (parse_completion, expout_last_struct)
10419         (expout_tag_completion_type, expout_completion_name): Remove
10420         globals.
10421         (parser_state::mark_struct_expression)
10422         (parser_state::mark_completion_tag): Now methods.
10423         (prefixify_expression): Add last_struct parameter.
10424         (prefixify_subexp): Likewise.
10425         (parse_exp_1): Update.
10426         (parse_exp_in_context): Add cstate parameter.  Update.
10427         (parse_expression_for_completion): Create an
10428         expr_completion_state.
10429         (null_post_parser): Add "completion" parameter.
10430         * p-exp.y: Update rules.
10431         (yylex): Update.
10432         * language.h (struct language_defn) <la_post_parser>: Add
10433         "completing" parameter.
10434         * go-exp.y: Update rules.
10435         (lex_one_token): Update.
10436         * expression.h (parse_completion): Don't declare.
10437         * d-exp.y: Update rules.
10438         (lex_one_token): Update rules.
10439         * c-exp.y: Update rules.
10440         (lex_one_token): Update.
10441         * ada-lang.c (resolve): Add "parse_completion" parameter.
10442         (resolve_subexp): Likewise.
10443         (ada_resolve_function): Likewise.
10444
10445 2019-04-04  Tom Tromey  <tom@tromey.com>
10446
10447         * parser-defs.h (struct parser_state) <start_arglist,
10448         end_arglist>: New methods.
10449         <arglist_len, m_funcall_chain>: New members.
10450         (arglist_len, start_arglist, end_arglist): Don't declare.
10451         * parse.c (arglist_len, funcall_chain): Remove global.
10452         (start_arglist, end_arglist): Remove functions.
10453         (parse_exp_in_context): Update.
10454         * p-exp.y: Update rules.
10455         * m2-exp.y: Update rules.
10456         * go-exp.y: Update rules.
10457         * f-exp.y: Update rules.
10458         * d-exp.y: Update rules.
10459         * c-exp.y: Update rules.
10460
10461 2019-04-04  Tom Tromey  <tom@tromey.com>
10462
10463         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10464         lex_operator, push_back>: New methods.
10465         Update all rules.
10466         (rust_parser::lex_hex, lex_escape): Rename and update.
10467         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10468         (rust_parser::lex_operator): Rename and update.
10469         (rust_parser::lex_number, rustyylex, rustyyerror)
10470         (rust_lex_test_init, rust_lex_test_sequence)
10471         (rust_lex_test_push_back, rust_lex_tests): Update.
10472         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10473         parameter.
10474         <lexptr, prev_lexptr>: New members.
10475         (lexptr, prev_lexptr): Don't declare.
10476         * parse.c (lexptr, prev_lexptr): Remove globals.
10477         (parse_exp_in_context): Update.
10478         * p-exp.y (yylex, yyerror): Update.
10479         * m2-exp.y (parse_number, yylex, yyerror): Update.
10480         * go-exp.y (lex_one_token, yyerror): Update.
10481         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10482         * d-exp.y (lex_one_token, yyerror): Update.
10483         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10484         (lex_one_token, yyerror): Update.
10485         * ada-lex.l (YY_INPUT): Update.
10486         (rewind_to_char): Update.
10487         * ada-exp.y (yyerror): Update.
10488
10489 2019-04-04  Tom Tromey  <tom@tromey.com>
10490
10491         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10492         * parser-defs.h (struct parser_state) <parser_state>: Add new
10493         parameter.
10494         <comma_terminates>: New member.
10495         (comma_terminates): Don't declare global.
10496         * parse.c (comma_terminates): Remove global.
10497         (parse_exp_in_context): Update.
10498         * p-exp.y (yylex): Update.
10499         * m2-exp.y (yylex): Update.
10500         * go-exp.y (lex_one_token): Update.
10501         * f-exp.y (yylex): Update.
10502         * d-exp.y (lex_one_token): Update.
10503         * c-exp.y (lex_one_token): Update.
10504         * ada-lex.l: Update.
10505
10506 2019-04-04  Tom Tromey  <tom@tromey.com>
10507
10508         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10509         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10510         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10511         * parser-defs.h (paren_depth): Don't declare.
10512         * parse.c (paren_depth): Remove global.
10513         (parse_exp_in_context): Update.
10514         * p-exp.y (paren_depth): New global.
10515         (pascal_parse): Initialize it.
10516         * m2-exp.y (paren_depth): New global.
10517         (m2_parse): Initialize it.
10518         * go-exp.y (paren_depth): New global.
10519         (go_parse): Initialize it.
10520         * f-exp.y (paren_depth): New global.
10521         (f_parse): Initialize it.
10522         * d-exp.y (paren_depth): New global.
10523         (d_parse): Initialize it.
10524         * c-exp.y (paren_depth): New global.
10525         (c_parse): Initialize it.
10526         * ada-lex.l (paren_depth): New global.
10527         (lexer_init): Initialize it.
10528
10529 2019-04-04  Tom Tromey  <tom@tromey.com>
10530
10531         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10532         (rust_parser::convert_ast_to_type)
10533         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10534         * parser-defs.h (struct parser_state) <parser_state>: Add
10535         parameters.  Initialize new members.
10536         <expression_context_block, expression_context_pc>: New members.
10537         * parse.c (expression_context_block, expression_context_pc):
10538         Remove globals.
10539         (parse_exp_in_context): Update.
10540         * p-exp.y: Update all rules.
10541         (yylex): Update.
10542         * m2-exp.y: Update all rules.
10543         (yylex): Update.
10544         * go-exp.y (yylex): Update.
10545         * f-exp.y (yylex): Update.
10546         * d-exp.y: Update all rules.
10547         (yylex): Update.
10548         * c-exp.y: Update all rules.
10549         (lex_one_token, classify_name, yylex, c_parse): Update.
10550         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10551
10552 2019-04-04  Tom Tromey  <tom@tromey.com>
10553
10554         * gdbarch.h, gdbarch.c: Rebuild.
10555         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10556         * stap-probe.h:
10557         (struct stap_parse_info): Replace "parser_state" with
10558         "expr_builder".
10559         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10560         (parser_state): New class.
10561         * parse.c (expr_builder): Rename.
10562         (expr_builder::release): Rename.
10563         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10564         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10565         (write_exp_elt_longcst, write_exp_elt_floatcst)
10566         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10567         (write_exp_string_vector, write_exp_bitstring)
10568         (write_exp_msymbol, mark_struct_expression)
10569         (write_dollar_variable)
10570         (insert_type_address_space, increase_expout_size): Replace
10571         "parser_state" with "expr_builder".
10572         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10573         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10574         "parser_state" with "expr_builder".
10575
10576 2019-04-04  Tom Tromey  <tom@tromey.com>
10577
10578         * rust-exp.y: Replace "parse_language" with method call.
10579         * p-exp.y:
10580         (yylex): Replace "parse_language" with method call.
10581         * m2-exp.y:
10582         (yylex): Replace "parse_language" with method call.
10583         * go-exp.y (classify_name): Replace "parse_language" with method
10584         call.
10585         * f-exp.y (yylex): Replace "parse_language" with method call.
10586         * d-exp.y (lex_one_token): Replace "parse_language" with method
10587         call.
10588         * c-exp.y:
10589         (lex_one_token, classify_name, yylex): Replace "parse_language"
10590         with method call.
10591         * ada-exp.y (find_primitive_type, type_char)
10592         (type_system_address): Replace "parse_language" with method call.
10593
10594 2019-04-04  Tom Tromey  <tom@tromey.com>
10595
10596         * rust-exp.y: Replace "parse_gdbarch" with method call.
10597         * parse.c (write_dollar_variable, insert_type_address_space):
10598         Replace "parse_gdbarch" with method call.
10599         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10600         call.
10601         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10602         call.
10603         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10604         "parse_gdbarch" with method call.
10605         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10606         with method call.
10607         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10608         "parse_gdbarch" with method call.
10609         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10610         "parse_gdbarch" with method call.
10611         * c-exp.y (parse_type, parse_number, classify_name): Replace
10612         "parse_gdbarch" with method call.
10613         * ada-lex.l: Replace "parse_gdbarch" with method call.
10614         * ada-exp.y (parse_type, find_primitive_type, type_char)
10615         (type_system_address): Replace "parse_gdbarch" with method call.
10616
10617 2019-04-04  Tom Tromey  <tom@tromey.com>
10618
10619         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10620         * stap-probe.c (stap_parse_argument): Update.
10621         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10622         initial_size parameter.
10623         * rust-exp.y (rust_lex_tests): Update.
10624         * parse.c (parser_state): Update.
10625         (parse_exp_in_context): Update.
10626         * parser-defs.h (struct parser_state) <parser_state>: Remove
10627         "initial_size" parameter.
10628
10629 2019-04-04  Tom Tromey  <tom@tromey.com>
10630
10631         * parser-defs.h (increase_expout_size): Don't declare.
10632         * parse.c (increase_expout_size): Now static.
10633
10634 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10635
10636         * gnu-nat.c (gnu_nat_target::wait): Fix
10637         target_waitstatus_to_string call.
10638
10639 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10640
10641         * eval.c (evaluate_subexp_standard): Handle internal functions
10642         during Fortran function call handling.
10643
10644 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10645
10646         * NEWS: Mention new internal functions.
10647         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10648         (read_base_type): Use dwarf2_init_complex_target_type.
10649         * value.c (creal_internal_fn): New function.
10650         (cimag_internal_fn): New function.
10651         (_initialize_values): Register new internal functions.
10652
10653 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10654
10655         * infrun.c (stop_all_threads): If debug_infrun, always
10656         trace the wait status after wait_one, using
10657         target_waitstatus_to_string and target_pid_to_str.
10658         (handle_inferior_event): Replace various trace of
10659         wait status kind by a single trace.
10660         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10661         wait status kind image by target_waitstatus_to_string.
10662         * target/waitstatus.c (target_waitstatus_to_string): Fix
10663         obsolete comment.
10664
10665 2019-04-01  Tom Tromey  <tromey@adacore.com>
10666
10667         PR symtab/23331:
10668         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10669
10670 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10671             Pedro Alves  <palves@redhat.com>
10672
10673         * top.c (quit_force): Call 'finalize_values'.
10674         * value.c (finalize_values): New function.
10675         * value.h (finalize_values): Declare.
10676
10677 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10678
10679         * NEWS: Announce $_gdb_major and $_gdb_minor.
10680
10681         * top.c (init_gdb_version_vars): New function.
10682         (gdb_init): Call init_gdb_version_vars.
10683
10684 2019-03-29  Tom Tromey  <tromey@adacore.com>
10685
10686         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10687         help text.  Remove dead code.
10688
10689 2019-03-29  Keith Seitz  <keiths@redhat.com>
10690
10691         From Siddhesh Poyarekar:
10692         * f-lang.h (f77_get_upperbound): Return LONGEST.
10693         (f77_get_lowerbound): Likewise.
10694         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10695         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10696         print them.
10697         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10698         plongest to format print it.
10699         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10700         (f77_get_upperbound): Likewise.
10701         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10702         LOWER_BOUND to LONGEST.
10703         (f77_create_arrayprint_offset_tbl): Likewise.
10704
10705 2019-03-29  Keith Seitz  <keiths@redhat.com>
10706
10707         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10708         %s/pulongest for TYPE_LENGTH instead of %d in format
10709         strings.
10710         * ada-typerint.c (ada_print_type): Likewise.
10711         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10712         * compile/compile-c-support.c (generate_register_struct): Likewise.
10713         * gdbtypes.c (recursive_dump_type): Likewise.
10714         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10715         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10716         instead of %d in format strings.
10717         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10718         to std::min to ULONGEST.
10719         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10720         instead of %d in format strings.
10721         * tracepoint.c (info_scope_command): Likewise.
10722         * typeprint.c (print_offset_data::update)
10723         (print_offset_data::finish): Likewise.
10724         * xtensa-tdep.c (xtensa_store_return_value)
10725         (xtensa_push_dummy_call): Likewise.
10726
10727 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10728
10729         * windows-nat.c (display_selector): Fixed format specifications
10730         for 64-bit Cygwin.
10731
10732 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10733
10734         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10735
10736 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10737
10738         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10739         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10740         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10741         (nios2_linux_init_abi): Install it.
10742
10743 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10744
10745         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10746
10747 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10748
10749         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10750
10751 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10752             Tom Tromey  <tromey@adacore.com>
10753
10754         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10755
10756 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10757
10758         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10759         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10760         method to compute the bounds of range types. Also print "[evaluated]"
10761         if the bounds' values come from a dynamic evaluation.
10762
10763 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10764
10765         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10766         whitespace when pretty printing is on.
10767
10768 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10769
10770         * ppc-linux-nat.c: Add include.
10771
10772 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10773
10774         * NEWS: Mention AArch64 Pointer Authentication.
10775
10776 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10777
10778         * arm-linux-nat.c: Add include.
10779
10780 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10781
10782         * source-cache.c (source_cache::get_source_lines): Re-read
10783         fullname after calling open_source_file.
10784
10785 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10786
10787         * NEWS: Mention TLS support for FreeBSD.
10788
10789 2019-03-25  Tom Tromey  <tromey@adacore.com>
10790
10791         * minsyms.c (BUNCH_SIZE): Update comment.
10792         (~minimal_symbol_reader): Remove old comment.
10793         (compact_minimal_symbols): Update comment.
10794         (minimal_symbol_reader::install): Remove old comment.  Update
10795         other comments.
10796
10797 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10798
10799         * s390-linux-nat.c: Add include.
10800
10801 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10802
10803         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10804         Call linux_get_hwcap.
10805         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10806         Likewise.
10807         (aarch64_linux_get_hwcap): Remove function.
10808         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10809         declaration.
10810         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10811         linux_get_hwcap.
10812         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10813         * linux-tdep.c (linux_get_hwcap): Add function.
10814         (linux_get_hwcap2): Likewise.
10815         * linux-tdep.h (linux_get_hwcap): Add declaration.
10816         (linux_get_hwcap2): Likewise.
10817         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10818         (ppc_linux_get_hwcap2): Likewise.
10819         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10820         linux_get_hwcap.
10821         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10822         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10823         (ppc_linux_nat_target::read_description): Likewise.
10824         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10825         * s390-linux-nat.c: Likewise.
10826         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10827
10828 2019-03-24  Tom Tromey  <tom@tromey.com>
10829
10830         * ada-lang.c (standard_lookup): Simplify initialization.
10831         (ada_lookup_symbol_nonlocal): Simplify return.
10832         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10833         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10834         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10835         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10836         initialization.
10837         * solib.c (solib_global_lookup): Simplify.
10838         * symtab.c (null_block_symbol): Remove.
10839         (symbol_cache_lookup): Simplify returns.
10840         (lookup_language_this): Simplify returns.
10841         (lookup_symbol_aux): Simplify return.
10842         (lookup_local_symbol): Simplify returns.
10843         (lookup_global_symbol_from_objfile): Simplify return.
10844         (lookup_symbol_in_objfile_symtabs)
10845         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10846         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10847         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10848         * cp-namespace.c (cp_lookup_bare_symbol)
10849         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10850         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10851         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10852         (cp_lookup_symbol_via_imports): Simplify initialization.
10853         (find_symbol_in_baseclass): Likewise.
10854         * symtab.h (null_block_symbol): Remove.
10855         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10856         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10857         (d_lookup_symbol_module): Likewise.
10858         (find_symbol_in_baseclass): Simplify initialization.
10859
10860 2019-03-24  Tom Tromey  <tom@tromey.com>
10861
10862         * expression.h: Don't include symtab.h.
10863         (struct block): Forward declare.
10864
10865 2019-03-24  Tom Tromey  <tom@tromey.com>
10866
10867         * c-exp.y (typebase): Remove casts.
10868         * gdbtypes.c (lookup_unsigned_typename, )
10869         (lookup_signed_typename): Remove cast.
10870         * eval.c (parse_to_comma_and_eval): Remove cast.
10871         * parse.c (write_dollar_variable): Remove cast.
10872         * block.h (struct block) <superblock>: Now const.
10873         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10874         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10875         (map_block): Make "block" const.
10876         * symfile.h (struct quick_symbol_functions)
10877         <map_matching_symbols>: Constify block argument to "callback".
10878         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10879         const.
10880         (find_pc_sect_compunit_symtab): Make "b" const.
10881         (find_symbol_at_address): Likewise.
10882         (search_symbols): Likewise.
10883         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10884         (dw2_debug_names_lookup_symbol): Likewise.
10885         (dw2_map_matching_symbols): Update.
10886         * p-valprint.c (pascal_val_print): Remove "block".
10887         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10888         (aux_add_nonlocal_symbols): Make "block" const.
10889         (resolve_subexp): Remove cast.
10890         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10891         const.
10892         (iterate_over_file_blocks): Likewise.
10893         * f-exp.y (%union) <bval>: Remove.
10894         * coffread.c (patch_opaque_types): Make "b" const.
10895         * spu-tdep.c (spu_catch_start): Make "block" const.
10896         * c-valprint.c (print_unpacked_pointer): Remove "block".
10897         * symmisc.c (dump_symtab_1): Make "b" const.
10898         (block_depth): Make "block" const.
10899         * d-exp.y (%union) <bval>: Remove.
10900         * cp-support.h (cp_lookup_rtti_type): Update.
10901         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10902         * psymtab.c (psym_lookup_symbol): Make "block" const.
10903         (maintenance_check_psymtabs): Make "b" const.
10904         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10905         (enumerate_locals, enumerate_args): Update.
10906         * python/py-symtab.c (stpy_global_block): Make "block" const.
10907         (stpy_static_block): Likewise.
10908         * inline-frame.c (block_starting_point_at): Make "new_block"
10909         const.
10910         * block.c (find_block_in_blockvector): Make return type const.
10911         (blockvector_for_pc_sect): Make "b" const.
10912         (find_block_in_blockvector): Make "b" const.
10913
10914 2019-03-23  Tom Tromey  <tom@tromey.com>
10915
10916         * varobj.c (varobj_create): Update.
10917         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10918         * printcmd.c (display_command, do_one_display): Don't reset
10919         innermost_block.
10920         * parser-defs.h (enum innermost_block_tracker_type): Move to
10921         expression.h.
10922         (innermost_block): Update comment.
10923         * parse.c (parse_exp_1): Add tracker_types parameter.
10924         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10925         tracker_types parameter.  Reset innermost_block.
10926         (parse_exp_in_context): Remove.
10927         (parse_expression_for_completion): Update.
10928         * objfiles.c (~objfile): Don't reset expression_context_block or
10929         innermost_block.
10930         * expression.h (enum innermost_block_tracker_type): Move from
10931         parser-defs.h.
10932         (parse_exp_1): Add tracker_types parameter.
10933         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10934         reset innermost_block.
10935
10936 2019-03-23  Tom Tromey  <tom@tromey.com>
10937
10938         * objfiles.h: Include bcache.h.
10939
10940 2019-03-23  Tom Tromey  <tom@tromey.com>
10941
10942         * linespec.c (get_current_search_block): Use
10943         scoped_restore_current_language.
10944         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10945
10946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10947             Jiong Wang  <jiong.wang@arm.com>
10948
10949         * aarch64-linux-tdep.c
10950         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10951         section.
10952         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10953
10954 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10955             Jiong Wang  <jiong.wang@arm.com>
10956
10957         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10958         instructions.
10959         (aarch64_analyze_prologue_test): Add PACIASP test.
10960         (aarch64_prologue_prev_register): Unmask PC value.
10961
10962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10963             Jiong Wang  <jiong.wang@arm.com>
10964
10965         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10966         (aarch64_dwarf2_prev_register): Unmask PC value.
10967         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10968         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10969         DW_CFA_AARCH64_negate_ra_state.
10970         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10971
10972 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10973             Jiong Wang  <jiong.wang@arm.com>
10974
10975         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10976         registers.
10977         (aarch64_pseudo_register_name): Likewise.
10978         (aarch64_pseudo_register_type): Likewise.
10979         (aarch64_pseudo_register_reggroup_p): Likewise.
10980         (aarch64_gdbarch_init): Add pauth registers.
10981         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10982         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10983         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10984         (struct gdbarch_tdep): Add regnum for ra_state.
10985
10986 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10987             Jiong Wang  <jiong.wang@arm.com>
10988
10989         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10990
10991 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10992             Jiong Wang  <jiong.wang@arm.com>
10993
10994         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10995         function.
10996         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10997         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10998         (aarch64_gdbarch_init): Add puth registers.
10999         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11000         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11001         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11002
11003 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11004             Jiong Wang  <jiong.wang@arm.com>
11005
11006         * aarch64-linux-nat.c
11007         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11008         * aarch64-linux-tdep.c
11009         (aarch64_linux_core_read_description): Likewise.
11010         (aarch64_linux_get_hwcap): New function.
11011         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11012         (aarch64_linux_get_hwcap): New declaration.
11013
11014 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11015             Jiong Wang  <jiong.wang@arm.com>
11016
11017         * aarch64-linux-nat.c
11018         (aarch64_linux_nat_target::read_description): Add pauth param.
11019         * aarch64-linux-tdep.c
11020         (aarch64_linux_core_read_description): Likewise.
11021         * aarch64-tdep.c (struct target_desc): Add in pauth.
11022         (aarch64_read_description): Add pauth param.
11023         (aarch64_gdbarch_init): Likewise.
11024         * aarch64-tdep.h (aarch64_read_description): Likewise.
11025         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11026         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11027         * features/Makefile: Add new files.
11028         * features/aarch64-pauth.c: New file.
11029         * features/aarch64-pauth.xml: New file.
11030
11031 2019-03-20  Tom Tromey  <tromey@adacore.com>
11032
11033         * infrun.c (handle_inferior_event): Rename from
11034         handle_inferior_event_1.  Create a scoped_value_mark.
11035         (handle_inferior_event): Remove.
11036
11037 2019-03-19  Tom Tromey  <tromey@adacore.com>
11038
11039         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11040         * infrun.h (print_stop_event): Add "displays" parameter.
11041         * infrun.c (print_stop_event): Add "displays" parameter.
11042
11043 2019-03-19  Pedro Alves  <palves@redhat.com>
11044
11045         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11046         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11047         to -1.  Fix TABs vs spaces.
11048         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11049         * tui/tui-out.h (tui_ui_out) Add intro comments.
11050         <m_line, m_start_of_line>: In-class initialize, and add describing
11051         comment.
11052
11053 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11054
11055         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11056         variable names.
11057         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11058
11059 2019-03-18  Pedro Alves  <palves@redhat.com>
11060             Eli Zaretskii <eliz@gnu.org>
11061
11062         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11063         m_line and m_start_of_line.
11064
11065 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11066
11067         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11068         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11069         it returns a newline.  This fixes a regression in TU mode, whereby
11070         the next line is output on the same screen line as the user input.
11071
11072 2019-03-18  Tom Tromey  <tromey@adacore.com>
11073
11074         * minsyms.c (minimal_symbol_reader::install): Remove call to
11075         obstack_blank.
11076
11077 2019-03-18  Pedro Alves  <palves@redhat.com>
11078
11079         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11080         New globals.
11081         (apply_style): New, factored out from ...
11082         (apply_ansi_escape): ... this.  Handle reverse video mode.
11083         (tui_set_reverse_mode): New function.
11084         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11085         * tui/tui-winsource.c (tui_show_source_line): Use
11086         tui_set_reverse_mode instead of setting A_STANDOUT.
11087         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11088         New setter methods.
11089
11090 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11091
11092         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11093         Handle tabs.
11094
11095 2019-03-18  Tom Tromey  <tromey@adacore.com>
11096
11097         * ada-lang.c (empty_array): Add "high" parameter.
11098         (ada_evaluate_subexp): Update.
11099
11100 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11101
11102         * unittests/string_view-selftests.c: Define
11103         _initialize_string_view_selftests unconditionally.
11104
11105 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11106
11107         PR gdb/24350
11108         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11109
11110 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11111
11112         PR gdb/24351
11113         * windows-nat.c (display_selector): Fix format specifiers.
11114
11115 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11116
11117         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11118         tui_refill_source_window instead of tui_refresh_win, to update the
11119         current execution line.  This fixes redisplay of the current line
11120         when stepping through the code with "next" or "step".
11121
11122 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11123
11124         * source-cache.c (source_cache::get_source_lines): Call
11125         find_source_lines to initialize s->nlines.  This fixes vertical
11126         scrolling of TUI source window when the DOWN arrow is pressed.
11127
11128 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11129
11130         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11131         linux-thread-db.c (_initialize_thread_db): Likewise.
11132
11133 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11134
11135         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11136         wclrtoeol in tui_show_source_line".  This reverts changes made in
11137         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11138
11139 2019-03-15  Tom Tromey  <tom@tromey.com>
11140
11141         * symtab.h (struct minimal_symbol): Derive from
11142         general_symbol_info.
11143         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11144         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11145         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11146         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11147         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11148         (MSYMBOL_SEARCH_NAME): Update.
11149         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11150         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11151         * minsyms.c (minimal_symbol_reader::record_full): Update.
11152
11153 2019-03-15  Tom Tromey  <tom@tromey.com>
11154
11155         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11156
11157 2019-03-15  Tom Tromey  <tom@tromey.com>
11158
11159         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11160         unique_xmalloc_ptr.
11161         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11162         Update.
11163         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11164         (build_minimal_symbol_hash_tables)
11165         (minimal_symbol_reader::install): Update.
11166
11167 2019-03-15  Tom Tromey  <tom@tromey.com>
11168
11169         * symtab.c (create_demangled_names_hash): Update.
11170         (symbol_set_names): Update.
11171         * objfiles.h (struct objfile_per_bfd_storage)
11172         <demangled_names_hash>: Now an htab_up.
11173         * objfiles.c (objfile_per_bfd_storage): Simplify.
11174
11175 2019-03-15  Tom Tromey  <tom@tromey.com>
11176
11177         * objfiles.h (struct objfile_per_bfd_storage): Declare
11178         destructor.
11179         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11180         New.
11181         (get_objfile_bfd_data): Use new.  Don't initialize
11182         language_of_main.
11183         (free_objfile_per_bfd_storage): Remove.
11184         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11185
11186 2019-03-15  Tom Tromey  <tom@tromey.com>
11187
11188         * symfile.c (reread_symbols): Update.
11189         * objfiles.c (objfile::objfile): Update.
11190         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11191         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11192         comment.
11193         (minimal_symbol_reader::install): Update.
11194         (terminate_minimal_symbol_table): Remove.
11195         * jit.c (jit_object_close_impl): Update.
11196
11197 2019-03-15  Tom Tromey  <tom@tromey.com>
11198
11199         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11200         initializations.
11201
11202 2019-03-15  Tom Tromey  <tom@tromey.com>
11203
11204         * objfiles.h (struct objfile_per_bfd_storage)
11205         <demangled_hash_languages>: Now a bitset.
11206         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11207         (lookup_minimal_symbol): Update.
11208
11209 2019-03-15  Tom Tromey  <tom@tromey.com>
11210
11211         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11212         Don't return the symbol.
11213         * coffread.c (record_minimal_symbol): Use record_full.
11214
11215 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11216
11217         The MS-Windows port of ncurses fails to switch to a color pair if
11218         one or both of the colors are the implicit default colors.  This
11219         change records the default colors when TUI is initialized, and
11220         then specifies them explicitly when a color pair uses the default
11221         colors.  This allows color styling in TUI mode on MS-Windows.
11222
11223         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11224         ncurses_norm_attr.
11225         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11226         colors in ncurses_norm_attr.
11227         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11228         "none", replace it with the default color recorded in
11229         ncurses_norm_attr.
11230
11231 2019-03-14  Tom Tromey  <tromey@adacore.com>
11232
11233         * source-cache.h (class source_cache) <get_source_lines>: Return
11234         std::string.
11235         * source-cache.c (source_cache::extract_lines): Handle case where
11236         first_pos==npos.  Return std::string.
11237         (source_cache::get_source_lines): Update.
11238
11239 2019-03-14  Tom Tromey  <tromey@adacore.com>
11240
11241         * NEWS: Add item for "style sources" commands.
11242         * source-cache.c (source_cache::get_source_lines): Check
11243         source_styling.
11244         * cli/cli-style.c (source_styling): New global.
11245         (_initialize_cli_style): Add "style sources" commands.
11246         (show_style_sources): New function.
11247         * cli/cli-style.h (source_styling): Declare.
11248
11249 2019-03-14  Pedro Alves  <palves@redhat.com>
11250             Tom Tromey  <tromey@adacore.com>
11251
11252         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11253         * tui/tui-winsource.c (tui_refill_source_window): New function,
11254         from...
11255         (tui_horizontal_source_scroll): ... here.  Move some logic.
11256         * cli/cli-style.c (set_style_enabled): Notify new observable.
11257         * tui/tui-hooks.c (tui_redisplay_source): New function.
11258         (tui_attach_detach_observers): Attach or detach
11259         tui_redisplay_source.
11260         * observable.h (source_styling_changed): New observable.
11261         * observable.c: Define source_styling_changed observable.
11262
11263 2019-03-13  Tom Tromey  <tromey@adacore.com>
11264
11265         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11266         (i386_gnu_nat_target::store_registers): Update.
11267         * target-debug.h (target_debug_print_std_string): New macro.
11268         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11269         * windows-tdep.c (display_one_tib): Update.
11270         * tui/tui-stack.c (tui_make_status_line): Update.
11271         * top.c (print_inferior_quit_action): Update.
11272         * thread.c (thr_try_catch_cmd): Update.
11273         (add_thread_with_info): Update.
11274         (thread_target_id_str): Update.
11275         (thr_try_catch_cmd): Update.
11276         (thread_command): Update.
11277         (thread_find_command): Update.
11278         * record-btrace.c (record_btrace_target::info_record)
11279         (record_btrace_resume_thread, record_btrace_target::resume)
11280         (record_btrace_cancel_resume, record_btrace_step_thread)
11281         (record_btrace_target::wait, record_btrace_target::wait)
11282         (record_btrace_target::wait, record_btrace_target::stop): Update.
11283         * progspace.c (print_program_space): Update.
11284         * process-stratum-target.c
11285         (process_stratum_target::thread_address_space): Update.
11286         * linux-fork.c (linux_fork_mourn_inferior)
11287         (detach_checkpoint_command, info_checkpoints_command)
11288         (linux_fork_context): Update.
11289         (linux_fork_detach): Update.
11290         (class scoped_switch_fork_info): Update.
11291         (delete_checkpoint_command): Update.
11292         * infrun.c (follow_fork_inferior): Update.
11293         (follow_fork_inferior): Update.
11294         (proceed_after_vfork_done): Update.
11295         (handle_vfork_child_exec_or_exit): Update.
11296         (follow_exec): Update.
11297         (displaced_step_prepare_throw): Update.
11298         (displaced_step_restore): Update.
11299         (start_step_over): Update.
11300         (resume_1): Update.
11301         (clear_proceed_status_thread): Update.
11302         (proceed): Update.
11303         (print_target_wait_results): Update.
11304         (do_target_wait): Update.
11305         (context_switch): Update.
11306         (stop_all_threads): Update.
11307         (restart_threads): Update.
11308         (finish_step_over): Update.
11309         (handle_signal_stop): Update.
11310         (switch_back_to_stepped_thread): Update.
11311         (keep_going_pass_signal): Update.
11312         (print_exited_reason): Update.
11313         (normal_stop): Update.
11314         * inferior.c (inferior_pid_to_str): Change return type.
11315         (print_selected_inferior): Update.
11316         (add_inferior): Update.
11317         (detach_inferior): Update.
11318         * dummy-frame.c (fprint_dummy_frames): Update.
11319         * dcache.c (dcache_info_1): Update.
11320         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11321         (btrace_fetch, btrace_clear): Update.
11322         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11323         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11324         type.
11325         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11326         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11327         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11328         * gdbarch.c, gdbarch.h: Rebuild.
11329         * gdbarch.sh (core_pid_to_str): Change return type.
11330         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11331         return type.
11332         (windows_nat_target::pid_to_str): Change return type.
11333         (windows_delete_thread): Update.
11334         (windows_nat_target::attach): Update.
11335         (windows_nat_target::files_info): Update.
11336         * target-delegates.c: Rebuild.
11337         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11338         return type.
11339         (sol_thread_target::pid_to_str): Change return type.
11340         * remote.c (class remote_target) <pid_to_str>: Change return
11341         type.
11342         (remote_target::pid_to_str): Change return type.
11343         (extended_remote_target::attach, remote_target::remote_stop_ns)
11344         (remote_target::remote_notif_remove_queued_reply)
11345         (remote_target::push_stop_reply, remote_target::disable_btrace):
11346         Update.
11347         (extended_remote_target::attach): Update.
11348         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11349         type.
11350         (gdbsim_target::pid_to_str): Change return type.
11351         * ravenscar-thread.c (struct ravenscar_thread_target)
11352         <pid_to_str>: Change return type.
11353         (ravenscar_thread_target::pid_to_str): Change return type.
11354         * procfs.c (class procfs_target) <pid_to_str>: Change return
11355         type.
11356         (procfs_target::pid_to_str): Change return type.
11357         (procfs_target::attach): Update.
11358         (procfs_target::detach): Update.
11359         (procfs_target::fetch_registers): Update.
11360         (procfs_target::store_registers): Update.
11361         (procfs_target::wait): Update.
11362         (procfs_target::files_info): Update.
11363         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11364         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11365         return type.
11366         (nto_procfs_target::pid_to_str): Change return type.
11367         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11368         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11369         return type.
11370         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11371         (exit_lwp): Update.
11372         (attach_proc_task_lwp_callback, get_detach_signal)
11373         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11374         (linux_nat_target::resume, wait_lwp, stop_callback)
11375         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11376         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11377         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11378         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11379         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11380         type.
11381         (inf_ptrace_target::attach): Update.
11382         (inf_ptrace_target::files_info): Update.
11383         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11384         type.
11385         (go32_nat_target::pid_to_str): Change return type.
11386         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11387         (gnu_nat_target::wait): Update.
11388         (gnu_nat_target::wait): Update.
11389         (gnu_nat_target::resume): Update.
11390         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11391         (fbsd_nat_target::wait): Update.
11392         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11393         type.
11394         (darwin_nat_target::attach): Update.
11395         * corelow.c (class core_target) <pid_to_str>: Change return type.
11396         (core_target::pid_to_str): Change return type.
11397         * target.c (normal_pid_to_str): Change return type.
11398         (default_pid_to_str): Likewise.
11399         (target_pid_to_str): Change return type.
11400         (target_translate_tls_address): Update.
11401         (target_announce_detach): Update.
11402         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11403         return type.
11404         (bsd_uthread_target::pid_to_str): Change return type.
11405         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11406         type.
11407         (bsd_kvm_target::pid_to_str): Change return type.
11408         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11409         return type.
11410         (aix_thread_target::pid_to_str): Change return type.
11411         * target.h (struct target_ops) <pid_to_str>: Change return type.
11412         (target_pid_to_str, normal_pid_to_str): Likewise.
11413         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11414         type.
11415         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11416         type.
11417         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11418         return type.
11419         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11420         type.
11421         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11422         type.
11423         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11424         return type.
11425
11426 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11427
11428         * NEWS: Mention that the new default MI version is 3.  Mention
11429         changes to the output of commands and events that deal with
11430         multi-location breakpoints.
11431         * breakpoint.c: Include "mi/mi-out.h".
11432         (print_one_breakpoint): Change output syntax if using MI version
11433         >= 3.
11434         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11435         New.
11436         (mi_multi_location_breakpoint_output_fixed): New.
11437         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11438         (mi_cmd_fix_multi_location_breakpoint_output): New.
11439         (mi_multi_location_breakpoint_output_fixed): New.
11440         * mi/mi-cmds.c (mi_cmds): Register command
11441         -fix-multi-location-breakpoint-output.
11442         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11443         interpreter "mi".
11444
11445 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11446
11447         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11448         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11449         instantiate mi_ui_out based on interpreter name.
11450         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11451         * mi/mi-main.c (mi_load_progress): Likewise.
11452
11453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11454
11455         * NEWS: Combine separate "New targets" sections for 8.3.
11456
11457 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11458
11459         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11460         (ppcfbsd_init_abi): Install gdbarch
11461         "fetch_tls_load_module_address" and "get_thread_local_address"
11462         methods.
11463
11464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11465
11466         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11467         (riscv_fbsd_init_abi): Install gdbarch
11468         "fetch_tls_load_module_address" and "get_thread_local_address"
11469         methods.
11470
11471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11472
11473         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11474         (i386fbsd_init_abi): Install gdbarch
11475         "fetch_tls_load_module_address" and "get_thread_local_address"
11476         methods.
11477
11478 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11479
11480         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11481         (amd64fbsd_init_abi): Install gdbarch
11482         "fetch_tls_load_module_address" and "get_thread_local_address"
11483         methods.
11484
11485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11486
11487         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11488         (struct fbsd_pspace_data): New type.
11489         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11490         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11491         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11492         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11493         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11494
11495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11496
11497         * gdbtypes.c (lookup_struct_elt): New function.
11498         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11499         * gdbtypes.h (struct struct_elt): New type.
11500         (lookup_struct_elt): New prototype.
11501
11502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11503
11504         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11505         remove disabled code block.
11506
11507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11508
11509         * gdbarch.sh (get_thread_local_address): New method.
11510         * gdbarch.h, gdbarch.c: Regenerate.
11511         * target.c (target_translate_tls_address): Use
11512         gdbarch_get_thread_local_address if present instead of
11513         target::get_thread_local_address.
11514
11515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11516
11517         * target.h (target::get_thread_local_address): Update comment.
11518
11519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11520
11521         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11522         objfile->separate_debug_objfile_backlink if not NULL.
11523
11524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11525
11526         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11527         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11528         (amd64bsd_store_inferior_registers): Likewise.
11529         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11530         Enable segment base registers.
11531         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11532         PT_GETFSBASE and PT_GETGSBASE.
11533         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11534         PT_SETGSBASE.
11535         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11536         segment base registers.
11537         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11538
11539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11540
11541         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11542         Update calls to i386_target_description to add 'segments'
11543         parameter.
11544         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11545         add segment base registers.
11546         * arch/i386.c (i386_create_target_description): Add 'segments'
11547         parameter to enable segment base registers.
11548         * arch/i386.h (i386_create_target_description): Likewise.
11549         * features/i386/32bit-segments.xml: New file.
11550         * features/i386/32bit-segments.c: Generate.
11551         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11552         call to i386_target_description to add 'segments' parameter.
11553         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11554         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11555         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11556         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11557         if feature is present.
11558         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11559         Add 'segments' parameter to call to i386_target_description.
11560         (i386_target_description): Add 'segments' parameter to enable
11561         segment base registers.
11562         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11563         to call to i386_target_description.
11564         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11565         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11566         Define I386_NUM_REGS.
11567         (i386_target_description): Add 'segments' parameter to enable
11568         segment base registers.
11569
11570 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11571
11572         PR/24325
11573         * source-cache.c: #undef open and close, to avoid unresolved
11574         externals during linking.
11575
11576 2019-03-12  Tom Tromey  <tromey@adacore.com>
11577
11578         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11579         const.  Add initializers.
11580         (_initialize_remote): Don't initialize ptid globals.
11581
11582 2019-03-12  Pedro Alves  <palves@redhat.com>
11583
11584         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11585
11586 2019-03-12  Pedro Alves  <palves@redhat.com>
11587
11588         * cp-name-parser.y (main): Remove unused 'len' variable.
11589
11590 2019-03-12  Tom Tromey  <tromey@adacore.com>
11591
11592         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11593         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11594
11595 2019-03-12  Tom Tromey  <tromey@adacore.com>
11596
11597         * linux-nat.c (iterate_over_lwps): Update.
11598         (stop_callback): Remove parameter.
11599         (stop_wait_callback, detach_callback, resume_set_callback)
11600         (select_singlestep_lwp_callback, set_ignore_sigint)
11601         (status_callback, resumed_callback, resume_clear_callback)
11602         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11603         data parameter.
11604         (linux_nat_target::detach, linux_nat_target::resume)
11605         (linux_stop_and_wait_all_lwps, select_event_lwp)
11606         (linux_nat_filter_event, linux_nat_wait_1)
11607         (linux_nat_target::kill, linux_nat_target::stop)
11608         (linux_nat_target::stop): Update.
11609         (linux_nat_resume_callback): Change type.
11610         (resume_stopped_resumed_lwps, count_events_callback)
11611         (select_event_lwp_callback): Likewise.
11612         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11613         * arm-linux-nat.c (struct update_registers_data): Remove.
11614         (update_registers_callback): Change type.
11615         (arm_linux_insert_hw_breakpoint1): Update.
11616         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11617         parameter.
11618         (x86_linux_dr_set_addr): Update.
11619         (x86_linux_dr_set_control): Update.
11620         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11621         (iterate_over_lwps): Use gdb::function_view.
11622         * nat/aarch64-linux-hw-point.c (struct
11623         aarch64_dr_update_callback_param): Remove.
11624         (debug_reg_change_callback): Change type.
11625         (aarch64_notify_debug_reg_change): Update.
11626         * s390-linux-nat.c (s390_refresh_per_info): Update.
11627
11628 2019-03-11  Tom Tromey  <tromey@adacore.com>
11629
11630         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11631         redundant assignment to "this_cu".
11632
11633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11634
11635         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11636
11637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11638
11639         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11640         from...
11641         (rank_one_type): ... this.
11642
11643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11644
11645         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11646         from...
11647         (rank_one_type): ... this.
11648
11649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11650
11651         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11652         from...
11653         (rank_one_type): ... this.
11654
11655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11656
11657         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11658         from...
11659         (rank_one_type): ... this.
11660
11661 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11662
11663         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11664         from...
11665         (rank_one_type): ... this.
11666
11667 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11668
11669         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11670         from...
11671         (rank_one_type): ... this.
11672
11673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11674
11675         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11676         from...
11677         (rank_one_type): ... this.
11678
11679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11680
11681         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11682         from...
11683         (rank_one_type): ... this.
11684
11685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11686
11687         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11688         from...
11689         (rank_one_type): ... this.
11690
11691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11692
11693         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11694         from...
11695         (rank_one_type): ... this.
11696
11697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11698
11699         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11700         from...
11701         (rank_one_type): ... this.
11702
11703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11704
11705         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11706         from...
11707         (rank_one_type): ... this.
11708
11709 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11710
11711         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11712         inferior-events' shows the example events.
11713
11714 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11715
11716         Support styling on native MS-Windows console
11717
11718         PR/24315
11719         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11720         on MS-Windows if $TERM is not defined.
11721
11722         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11723
11724         * posix-hdep.c (gdb_console_fputs):
11725         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11726         functions.
11727         * ui-file.h (gdb_console_fputs): Add prototype.
11728
11729         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11730         back to fputs only if the former returns zero.
11731
11732 2019-03-07  Tom Tromey  <tom@tromey.com>
11733
11734         * symmisc.c (print_symbol_bcache_statistics): Update.
11735         (print_objfile_statistics): Update.
11736         * symfile.c (allocate_symtab): Update.
11737         * stabsread.c: Don't include bcache.h.
11738         * psymtab.h (struct psymbol_bcache): Don't declare.
11739         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11740         (psymbol_bcache_init, psymbol_bcache_free)
11741         (psymbol_bcache_get_bcache): Don't declare.
11742         * psymtab.c (struct psymbol_bcache): Remove.
11743         (psymtab_storage::psymtab_storage): Update.
11744         (psymtab_storage::~psymtab_storage): Update.
11745         (psymbol_bcache_init, psymbol_bcache_free)
11746         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11747         (add_psymbol_to_bcache): Update.
11748         (allocate_psymtab): Update.
11749         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11750         macro_cache>: No longer pointers.
11751         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11752         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11753         * macrotab.c (macro_bcache): Update.
11754         * macroexp.c: Don't include bcache.h.
11755         * gdbtypes.c (check_types_worklist): Update.
11756         (types_deeply_equal): Remove TRY/CATCH.  Update.
11757         * elfread.c (elf_symtab_read): Update.
11758         * dwarf2read.c: Don't include bcache.h.
11759         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11760         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11761         (print_bcache_statistics, bcache_memory_used): Don't declare.
11762         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11763         methods.  Rename all data members.
11764         * bcache.c (struct bcache): Move to bcache.h.
11765         (bcache::expand_hash_table): Rename from expand_hash_table.
11766         (bcache): Remove.
11767         (bcache::insert): Rename from bcache_full.
11768         (bcache::compare): Rename from bcache_compare.
11769         (bcache_xmalloc): Remove.
11770         (bcache::~bcache): Rename from bcache_xfree.
11771         (bcache::print_statistics): Rename from print_bcache_statistics.
11772         (bcache::memory_used): Rename from bcache_memory_used.
11773
11774 2019-03-07  Pedro Alves  <palves@redhat.com>
11775
11776         * infrun.c (normal_stop): Also check for
11777         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11778
11779 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11780
11781         * f-lang.c (value_from_host_double): Moved to...
11782         * value.c (value_from_host_double): ...here.
11783         * value.h (value_from_host_double): Declare.
11784         * guile/scm-math.c (vlscm_convert_typed_number): Use
11785         value_from_host_double.
11786         (vlscm_convert_number): Likewise.
11787         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11788         * python/py-value.c (convert_value_from_python): Likewise.
11789
11790 2019-03-06  Tom Tromey  <tom@tromey.com>
11791
11792         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11793
11794 2019-03-06  Tom Tromey  <tom@tromey.com>
11795
11796         * utils.h (free_current_contents): Don't declare.
11797         * utils.c (free_current_contents): Remove.
11798
11799 2019-03-06  Tom Tromey  <tom@tromey.com>
11800
11801         * top.c (quit_force): Update.
11802         * main.c (captured_command_loop): Update.
11803         * common/new-op.c (operator new): Update.
11804         * common/common-exceptions.c (struct catcher)
11805         <save_cleanup_chain>: Remove member.
11806         (exceptions_state_mc_init): Update.
11807         (exception_try_scope_entry): Return nullptr.
11808         (exception_try_scope_exit, exception_rethrow)
11809         (throw_exception_sjlj, throw_exception_cxx): Update.
11810         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11811         (all_cleanups, do_cleanups, discard_cleanups)
11812         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11813         (restore_cleanups, restore_final_cleanups): Don't declare.
11814         (do_final_cleanups): Remove parameter.
11815         * common/cleanups.c (cleanup_chain, make_cleanup)
11816         (make_cleanup_dtor, all_cleanups, do_cleanups)
11817         (discard_my_cleanups, discard_cleanups)
11818         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11819         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11820         (null_cleanup): Remove.
11821         (do_final_cleanups): Remove parameter.
11822
11823 2019-03-06  Tom Tromey  <tom@tromey.com>
11824
11825         * remote.c (remote_target::remote_parse_stop_reply): Use
11826         unique_xmalloc_ptr.
11827
11828 2019-03-06  Tom Tromey  <tom@tromey.com>
11829
11830         * stabsread.c (struct stabs_field_info): Rename from field_info.
11831         <list, fnlist>: Add initializers.
11832         <obstack>: New member.
11833         (read_member_functions, read_struct_fields, read_baseclasses):
11834         Allocate on obstack.  Don't use cleanups.
11835         (read_one_struct_field, read_member_functions, read_struct_fields)
11836         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11837         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11838         (read_struct_type): Update.
11839
11840 2019-03-06  Tom Tromey  <tom@tromey.com>
11841
11842         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11843         * common/filestuff.h (make_cleanup_close): Don't declare.
11844         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11845         Remove.
11846
11847 2019-03-06  Tom Tromey  <tom@tromey.com>
11848
11849         * solib-aix.c: Use make_scope_exit.
11850
11851 2019-03-06  Tom Tromey  <tom@tromey.com>
11852
11853         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11854         Use make_scope_exit.
11855
11856 2019-03-06  Tom Tromey  <tom@tromey.com>
11857
11858         * solib-svr4.c (disable_probes_interface): Remove parameter.
11859         (svr4_handle_solib_event): Use make_scope_exit.
11860
11861 2019-03-06  Tom Tromey  <tom@tromey.com>
11862
11863         * remote.c (struct stop_reply_deleter): Remove.
11864         (stop_reply_up): Update.
11865         (struct stop_reply): Derive from notif_event.  Don't typedef.
11866         <regcache>: Now a std::vector.
11867         (stop_reply_xfree): Remove.
11868         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11869         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11870         (remote_target::discard_pending_stop_replies): Use delete.
11871         (remote_target::remote_parse_stop_reply): Update.
11872         (remote_target::process_stop_reply): Update.
11873         * remote-notif.h (struct notif_event): Add virtual destructor.
11874         Remove "dtr" member.
11875         (struct notif_client) <alloc_event>: Return a unique_ptr.
11876         (notif_event_xfree): Don't declare.
11877         (notif_event_up): New typedef.
11878         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11879         (notif_event_xfree, do_notif_event_xfree): Remove.
11880         (remote_notif_state_xfree): Update.
11881
11882 2019-03-06  Tom Tromey  <tom@tromey.com>
11883
11884         * infrun.c (displaced_step_clear_cleanup): Now a
11885         forward_scope_exit type.
11886         (displaced_step_prepare_throw): Update.
11887         (displaced_step_fixup): Update.
11888
11889 2019-03-06  Tom Tromey  <tom@tromey.com>
11890
11891         * inferior.h (class inferior): Update comment.
11892         * gdbthread.h (class thread_info): Update comment.
11893
11894 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11895             Tom Tromey  <tom@tromey.com>
11896
11897         * stabsread.h (struct stab_section_list): Remove.
11898         (coffstab_build_psymtabs): Update.
11899         * dbxread.c (symbuf_sections): Now a std::vector.
11900         (sect_idx): New global.
11901         (fill_symbuf): Update.
11902         (coffstab_build_psymtabs): Change type of stabsects parameter.
11903         Update.
11904         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11905         std::vector.
11906         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11907         (coff_locate_sections): Update.
11908         (coff_symfile_read): Remove cleanups.  Update.
11909         (init_stringtab): Add storage parameter.
11910         (free_stringtab, free_stringtab_cleanup): Remove.
11911         (init_lineno): Add storage parameter.
11912         (free_linetab, free_linetab_cleanup): Remove.
11913
11914 2019-03-06  Pedro Alves  <palves@redhat.com>
11915
11916         * linux-fork.c (fork_info::clobber_regs): Delete.
11917         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11918         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11919         comment.  Adjust.
11920         (scoped_switch_fork_info::scoped_switch_fork_info)
11921         (checkpoint_command, linux_fork_context): Adjust
11922         fork_save_infrun_state calls.
11923
11924 2019-03-06  Pedro Alves  <palves@redhat.com>
11925
11926         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11927         (inf_has_multiple_threads): Return 'bool' and rewrite using
11928         inferior_info::threads().
11929
11930 2019-03-06  Pedro Alves  <palves@redhat.com>
11931
11932         * linux-fork.c: Include <list>.
11933         (fork_list): Now a std::list instance.
11934         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11935         (forks_exist_p, find_last_fork): Adjust.
11936         (new_fork): Delete.
11937         (one_fork_p): New.
11938         (add_fork): Adjust.
11939         (free_fork): Delete, folded into fork_info::~fork_info().
11940         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11941         Adjust.
11942         (init_fork_list): Delete.
11943         (linux_fork_killall, linux_fork_mourn_inferior)
11944         (linux_fork_detach, info_checkpoints_command): Adjust.
11945         (_initialize_linux_fork): No longer call init_fork_list.
11946
11947 2019-03-06  Pedro Alves  <palves@redhat.com>
11948
11949         * linux-fork.c (new_fork): New, split out of ...
11950         (add_fork): ... this.  Return void.  Move "first fork" special
11951         case from here, to ...
11952         (checkpoint_command): ... here.
11953         * linux-linux.h (add_fork): Return void.
11954
11955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11956
11957         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11958
11959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11960             Chris January  <chris.january@arm.com>
11961             David Lecomber  <david.lecomber@arm.com>
11962
11963         * f-exp.y: New token, UNOP_INTRINSIC.
11964         (exp): New pattern using UNOP_INTRINSIC token.
11965         (f77_keywords): Add 'abs' keyword.
11966         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11967         (value_from_host_double): New function.
11968         (evaluate_subexp_f): Support UNOP_ABS.
11969
11970 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11971
11972         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11973         types.
11974
11975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11976
11977         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11978         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11979         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11980
11981 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11982
11983         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11984
11985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11986             Chris January  <chris.january@arm.com>
11987
11988         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11989         * f-exp.y: Define 'KIND' token.
11990         (exp): New pattern for KIND expressions.
11991         (ptype): Handle types with a kind extension.
11992         (direct_abs_decl): Extend to spot kind extensions.
11993         (f77_keywords): Add 'kind' to the list.
11994         (push_kind_type): New function.
11995         (convert_to_kind_type): New function.
11996         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11997         * parse.c (operator_length_standard): Likewise.
11998         * parser-defs.h (enum type_pieces): Add tp_kind.
11999         * std-operator.def: Add UNOP_KIND.
12000
12001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12002
12003         * f-exp.y (f_parse): Set yydebug.
12004
12005 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12006
12007         * f-lang.c (evaluate_subexp_f): New function.
12008         (exp_descriptor_f): New global.
12009         (f_language_defn): Use exp_descriptor_f instead of
12010         exp_descriptor_standard.
12011
12012 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12013
12014         * f-exp.y (struct token): Add comments.
12015         (dot_ops): Remove uppercase versions and the end marker.
12016         (f77_keywords): Likewise.
12017         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12018         entries in the dot_ops array are case insensitive, and use
12019         strncasecmp to compare strings.  Also some whitespace cleanup in
12020         this area.  Similar for the f77_keywords array, except entries in
12021         this list might be case sensitive.
12022
12023 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12024
12025         * f-exp.y (struct f77_boolean_val): Add comments.
12026         (boolean_values): Remove uppercase versions, and end marker.
12027         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12028         and use strncasecmp to achieve case insensitivity.  Additionally,
12029         perform whitespace cleanup around this code.
12030
12031 2019-03-06  Tom Tromey  <tromey@adacore.com>
12032
12033         * remote-sim.c (gdbsim_target_open): Use result of
12034         gdb_argv::release.
12035
12036 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12037         Dirk Schubert  <dirk.schubert@arm.com>
12038         Chris January  <chris.january@arm.com>
12039
12040         * eval.c (evaluate_subexp_standard): Call Fortran argument
12041         wrapping logic.
12042         * f-lang.c (struct value): A value which can be passed into a
12043         Fortran function call.
12044         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12045         where appropriate.
12046         (struct type): Value ready for a Fortran function call.
12047         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12048         is needed.
12049         * f-lang.h (fortran_argument_convert): Declaration.
12050         (fortran_preserve_arg_pointer): Declaration.
12051         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12052
12053 2019-03-05  Tom Tromey  <tromey@adacore.com>
12054
12055         * python/py-prettyprint.c (print_string_repr): Remove #if.
12056         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12057
12058 2019-03-05  Tom Tromey  <tromey@adacore.com>
12059
12060         * target.c (the_dummy_target): Move later.  Change type to
12061         "dummy_target".
12062         (initialize_targets): Don't initialize the_dummy_target.
12063
12064 2019-03-05  Tom Tromey  <tromey@adacore.com>
12065
12066         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12067         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12068
12069 2019-03-05  Tom Tromey  <tromey@adacore.com>
12070
12071         * windows-nat.c (windows_nat_target::attach)
12072         (windows_nat_target::detach): Don't call gdb_flush.
12073         * valprint.c (generic_val_print, val_print, val_print_string):
12074         Don't call gdb_flush.
12075         * utils.c (defaulted_query): Don't call gdb_flush.
12076         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12077         * target.c (target_announce_detach): Don't call gdb_flush.
12078         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12079         * remote.c (extended_remote_target::attach): Don't call
12080         gdb_flush.
12081         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12082         * printcmd.c (do_examine): Don't call gdb_flush.
12083         (info_display_command): Don't call gdb_flush.
12084         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12085         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12086         * memattr.c (info_mem_command): Don't call gdb_flush.
12087         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12088         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12089         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12090         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12091         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12092         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12093         (gnu_nat_target::detach): Don't call gdb_flush.
12094         * f-valprint.c (f_val_print): Don't call gdb_flush.
12095         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12096         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12097         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12098         gdb_flush.
12099         * c-valprint.c (c_val_print): Don't call gdb_flush.
12100         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12101
12102 2019-03-05  Tom Tromey  <tromey@adacore.com>
12103
12104         * varobj.c (update_dynamic_varobj_children): Update.
12105         (install_default_visualizer): Use reset, not release.
12106         * value.c (set_internalvar): Update.
12107         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12108         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12109         ATTRIBUTE_UNUSED_RESULT.
12110
12111 2019-03-05  Tom Tromey  <tromey@adacore.com>
12112
12113         * remote.c (class scoped_remote_fd) <release>: Add
12114         ATTRIBUTE_UNUSED_RESULT.
12115
12116 2019-03-05  Tom Tromey  <tromey@adacore.com>
12117
12118         * macroexp.c (struct macro_buffer) <release>: Add
12119         ATTRIBUTE_UNUSED_RESULT.
12120
12121 2019-03-05  Tom Tromey  <tromey@adacore.com>
12122
12123         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12124         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12125         ATTRIBUTE_UNUSED_RESULT.
12126
12127 2019-03-05  Tom Tromey  <tromey@adacore.com>
12128
12129         * common/scoped_fd.h (class scoped_fd) <release>: Add
12130         ATTRIBUTE_UNUSED_RESULT.
12131
12132 2019-03-05  Tom Tromey  <tromey@adacore.com>
12133
12134         * parser-defs.h (struct parser_state) <release>: Add
12135         ATTRIBUTE_UNUSED_RESULT.
12136
12137 2019-03-05  Tom Tromey  <tromey@adacore.com>
12138
12139         * utils.h (class gdb_argv) <release>: Add
12140         ATTRIBUTE_UNUSED_RESULT.
12141         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12142
12143 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12144
12145         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12146         for-loop range, to avoid compiler warnings.
12147
12148         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12149         avoid compiler warnings about unused variables.
12150
12151         * NEWS: Mention end of support for native debugging on MS-Windows
12152         before XP.
12153
12154         PR gdb/24292
12155         * common/netstuff.c:
12156         * gdbserver/gdbreplay.c
12157         * gdbserver/remote-utils.c:
12158         * ser-tcp.c:
12159         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12160         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12161         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12162         'getaddrinfo' and 'freeaddrinfo' were not available before
12163         Windows XP, and mingw.org's MinGW headers by default define
12164         _WIN32_WINNT to 0x500.
12165
12166 2019-03-01  Gary Benson <gbenson@redhat.com>
12167
12168         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12169
12170 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12171             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12172
12173         PR gdb/8527
12174         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12175         set_sigint_trap, clear_sigint_trap.
12176
12177 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12178
12179         * target.c (target_detach): Clear the regcache and the
12180         frame cache.
12181
12182 2019-02-27  Pedro Alves  <palves@redhat.com>
12183
12184         * utils.c (set_screen_size): When we cap the height/width sizes,
12185         tweak the corresponding command variable to show "unlimited":
12186
12187 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12188             Pedro Alves  <palves@redhat.com>
12189
12190         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12191         before calling rl_set_screen_size.
12192
12193 2019-02-27  Tom Tromey  <tromey@adacore.com>
12194
12195         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12196         define.
12197         * python/py-value.c: Remove Python 2.4 workaround.
12198         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12199         workaround.
12200         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12201         Python 2.4 workaround.
12202         * python/python-internal.h: Remove Python 2.4 comment.
12203         (Py_ssize_t): Don't define.
12204         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12205         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12206         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12207         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12208         * python/python.c (do_start_initialization): Remove Python 2.4
12209         workaround.
12210         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12211         (print_children): Remove Python 2.4 workaround.
12212         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12213         workaround.
12214         (CHARBUFFERPROC_NAME): Remove.
12215         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12216         Python 2.4 workaround.
12217
12218 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12219
12220         * NEWS: Note minimum Python version.
12221
12222 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12223
12224         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12225         code from these functions.  Remove corresponding ifdefs.  Use
12226         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12227         Remove gotos and target of gotos.
12228         (infpy_search_memory): Likewise.
12229
12230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12231
12232         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12233         (hppa_gdbarch_init): Don't register deleted functions with
12234         gdbarch.
12235
12236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12237
12238         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12239         (h8300_unwind_sp): Delete.
12240         (h8300_dummy_id): Delete.
12241         (h8300_gdbarch_init): Don't register deleted functions with
12242         gdbarch.
12243
12244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12245
12246         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12247         (ft32_unwind_pc): Delete.
12248         (ft32_unwind_sp): Delete.
12249         (ft32_gdbarch_init): Don't register deleted functions with
12250         gdbarch.
12251
12252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12253
12254         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12255         (frv_unwind_pc): Delete.
12256         (frv_unwind_sp): Delete.
12257         (frv_gdbarch_init): Don't register deleted functions with
12258         gdbarch.
12259
12260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12261
12262         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12263         (riscv_unwind_pc): Delete.
12264         (riscv_unwind_sp): Delete.
12265         (riscv_gdbarch_init): Don't register deleted functions with
12266         gdbarch.
12267
12268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12269
12270         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12271         (csky_unwind_pc): Delete.
12272         (csky_unwind_sp): Delete.
12273         (csky_gdbarch_init): Don't register deleted functions with
12274         gdbarch.
12275
12276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12277
12278         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12279         (cris_unwind_pc): Delete.
12280         (cris_unwind_sp): Delete.
12281         (cris_gdbarch_init): Don't register deleted functions with
12282         gdbarch.
12283
12284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12285
12286         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12287         (bfin_unwind_pc): Delete.
12288         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12289
12290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12291
12292         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12293         (arm_unwind_pc): Delete.
12294         (arm_unwind_sp): Delete.
12295         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12296
12297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12298
12299         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12300         (arc_unwind_pc): Delete.
12301         (arc_unwind_sp): Delete.
12302         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12303
12304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12305
12306         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12307         (alpha_unwind_pc): Delete.
12308         (alpha_gdbarch_init): Don't register deleted functions with
12309         gdbarch.
12310
12311 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12312
12313         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12314         (aarch64_unwind_pc): Delete.
12315         (aarch64_unwind_sp): Delete.
12316         (aarch64_gdbarch_init): Don't register deleted functions with
12317         gdbarch.
12318
12319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12320
12321         * gdbtypes.c (type_align): Don't consider static members when
12322         computing structure alignment.
12323
12324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12325
12326         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12327         return 0 for other types.
12328         * arch-utils.c (default_type_align): Always return 0.
12329         * gdbarch.h: Regenerate.
12330         * gdbarch.sh (type_align): Extend comment.
12331         * gdbtypes.c (type_align): Add additional comments, always call
12332         gdbarch_type_align before applying the default rules.
12333         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12334         generic code will then apply a suitable default.
12335         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12336         types, return 0 for other types.
12337
12338 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12339
12340         * NEWS: Create a new section for the next release branch.
12341         Rename the section of the current branch, now that it has
12342         been cut.
12343
12344 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12345
12346         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12347         * version.in: Bump version to 8.3.50.DATE-git.
12348
12349 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12350
12351         * aix-thread.c (ptid_cmp): Remove unused variable.
12352         (get_signaled_thread): Likewise.
12353         (store_regs_user_thread): Likewise.
12354         (store_regs_kernel_thread): Likewise.
12355         (fetch_regs_kernel_thread): Remove shadowed variable.
12356
12357 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12358
12359         * features/riscv/32bit-cpu.xml: Add register numbers.
12360         * features/riscv/32bit-fpu.c: Regenerate.
12361         * features/riscv/32bit-fpu.xml: Add register numbers.
12362         * features/riscv/64bit-cpu.xml: Add register numbers.
12363         * features/riscv/64bit-fpu.c: Regenerate.
12364         * features/riscv/64bit-fpu.xml: Add register numbers.
12365
12366 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12367
12368         * NEWS: Mention two argument form of gdb.Value constructor.
12369         * python/py-value.c (convert_buffer_and_type_to_value): New
12370         function.
12371         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12372         Add support for handling an optional second argument.  Call
12373         convert_buffer_and_type_to_value as appropriate.
12374         * python/python-internal.h (Py_buffer_deleter): New struct.
12375         (Py_buffer_up): New typedef.
12376
12377 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12378
12379         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12380         instead of releasing ownership.
12381
12382 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12383
12384         * dwarf2read.c (open_and_init_dwp_file): Call
12385         elf_numsections instead of bfd_count_sections to initialize
12386         dwp_file->num_sections.
12387
12388 2019-02-25  Tom Tromey  <tromey@adacore.com>
12389
12390         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12391
12392 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12393
12394         * gcore.in: Add '--readnever' option when invoking GDB.
12395
12396 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12397
12398         * MAINTAINERS: Update my email address.
12399
12400 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12401
12402         * build-id.c (build_id_to_debug_bfd_1): New function.
12403         (build_id_to_debug_bfd): Look for separate debug file in
12404         sysroot.
12405
12406 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12407
12408         * gdbarch.sh: Update the copyright year range that is placed into
12409         generated files.
12410
12411 2019-02-22  Keith Seitz  <keiths@redhat.com>
12412
12413         PR symtab/23853
12414         * linespec.c (create_sals_line_offset): Search for the default
12415         symtab's filename instead of its fullname.
12416
12417 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12418
12419         * NEWS: Update style defaults.
12420
12421 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12422
12423         * main.c (captured_main_1): Disable styling in batch mode.
12424
12425 2019-02-20  Tom Tromey  <tom@tromey.com>
12426
12427         * symtab.c (symtab_symbol_info): Fix typos.
12428
12429 2019-02-20  Tom Tromey  <tromey@adacore.com>
12430
12431         * findcmd.c (_initialize_mem_search): Use upper case for
12432         metasyntactic variables.
12433
12434 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12435
12436         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12437         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12438
12439 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12440
12441         * top.h (source_file_name): Change to std::string.
12442         * top.c (source_file_name): Likewise.
12443         (command_line_input): Adjust.
12444         * cli/cli-script.c (script_from_file): Adjust.
12445
12446 2019-02-19  Tom Tromey  <tromey@adacore.com>
12447
12448         * ravenscar-thread.c
12449         (ravenscar_thread_target::update_thread_list): Don't call
12450         ada_build_task_list.
12451         * ada-lang.h (ada_build_task_list): Don't declare.
12452         * ada-tasks.c (struct ada_tasks_inferior_data)
12453         <task_list_valid_p>: Now bool.
12454         (read_known_tasks, ada_task_list_changed)
12455         (ada_tasks_invalidate_inferior_data): Update.
12456         (read_known_tasks_array): Return bool.
12457         (read_known_tasks_list): Likewise.
12458         (read_known_tasks): Return void.
12459         (ada_build_task_list): Now static.
12460
12461 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12462
12463         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12464         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12465
12466 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12467
12468         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12469         variant for ada_tasks_pspace_data_handle and
12470         ada_tasks_inferior_data_handle.
12471         (ada_tasks_pspace_data_cleanup): New function.
12472         (ada_tasks_inferior_data_cleanup): New function.
12473
12474 2019-02-17  Tom Tromey  <tom@tromey.com>
12475
12476         * macrotab.h (macro_source_fullname): Return a std::string.
12477         * macrotab.c (macro_include, check_for_redefinition)
12478         (macro_undef, macro_lookup_definition, foreach_macro)
12479         (foreach_macro_in_scope): Update.
12480         (macro_source_fullname): Return a std::string.
12481         * macrocmd.c (show_pp_source_pos): Update.
12482
12483 2019-02-17  Tom Tromey  <tom@tromey.com>
12484
12485         * macrocmd.c (show_pp_source_pos): Style the file names.
12486
12487 2019-02-17  Tom Tromey  <tom@tromey.com>
12488
12489         PR tui/24197:
12490         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12491
12492 2019-02-17  Tom Tromey  <tom@tromey.com>
12493
12494         * ada-lang.c (user_select_syms): Use filtered printing.
12495         * utils.c (wrap_style): New global.
12496         (desired_style): Remove.
12497         (emit_style_escape): Add stream parameter.
12498         (set_output_style, reset_terminal_style, prompt_for_continue):
12499         Update.
12500         (flush_wrap_buffer): Only flush gdb_stdout.
12501         (wrap_here): Set wrap_style.
12502         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12503         treat escape sequences as a character.  Change when wrap buffer is
12504         flushed.
12505         (fputs_styled): Do not set the output style when the default is
12506         requested.
12507         * ui-style.h (struct ui_file_style) <is_default>: New method.
12508         * source.c (print_source_lines_base): Emit escape sequences in one
12509         piece.
12510
12511 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12512
12513         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12514         integers and enumeration types.
12515
12516 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12517
12518         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12519         instead of lookup_symbol_in_language
12520         (do_exact_match): New function.
12521         (ada_get_symbol_name_matcher): Return do_exact_match when
12522         doing a verbatim match.
12523
12524 2019-02-15  Tom Tromey  <tromey@adacore.com>
12525
12526         * ravenscar-thread.c (ravenscar_thread_target::resume)
12527         (ravenscar_thread_target::wait): Special case wildcard requests.
12528
12529 2019-02-15  Tom Tromey  <tromey@adacore.com>
12530
12531         * ravenscar-thread.c (base_ptid): Remove.
12532         (struct ravenscar_thread_target) <close>: New method.
12533         <m_base_ptid>: New member.
12534         <update_inferior_ptid, active_task, task_is_currently_active,
12535         runtime_initialized>: Declare methods.
12536         <ravenscar_thread_target>: Add constructor.
12537         (ravenscar_thread_target::task_is_currently_active)
12538         (ravenscar_thread_target::update_inferior_ptid)
12539         (ravenscar_runtime_initialized): Rename.  Now methods.
12540         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12541         (ravenscar_thread_target::update_thread_list): Update.
12542         (ravenscar_thread_target::active_task): Now method.
12543         (ravenscar_thread_target::store_registers)
12544         (ravenscar_thread_target::prepare_to_store)
12545         (ravenscar_thread_target::prepare_to_store)
12546         (ravenscar_thread_target::mourn_inferior): Update.
12547         (ravenscar_inferior_created): Use "new" to create target.
12548         (ravenscar_thread_target::get_ada_task_ptid): Update.
12549         (_initialize_ravenscar): Don't initialize base_ptid.
12550         (ravenscar_ops): Remove global.
12551
12552 2019-02-15  Tom Tromey  <tromey@adacore.com>
12553
12554         * target.h (push_target): Declare new overload.
12555         * target.c (push_target): New overload, taking an rvalue reference.
12556         * remote.c (remote_target::open_1): Use push_target overload.
12557         * corelow.c (core_target_open): Use push_target overload.
12558
12559 2019-02-15  Tom Tromey  <tromey@adacore.com>
12560
12561         * ravenscar-thread.c (is_ravenscar_task)
12562         (ravenscar_task_is_currently_active): Return bool.
12563         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12564         (_initialize_ravenscar): Remove "(void)".
12565         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12566         Return bool.
12567
12568 2019-02-15  Tom Tromey  <tromey@adacore.com>
12569
12570         * ravenscar-thread.c (ravenscar_runtime_initializer)
12571         (has_ravenscar_runtime, get_running_thread_id)
12572         (ravenscar_thread_target::resume): Fix indentation.
12573
12574 2019-02-15  Tom Tromey  <tromey@adacore.com>
12575
12576         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12577         from ravenscar_arch_ops.
12578         (sparc_ravenscar_ops::fetch_registers)
12579         (sparc_ravenscar_ops::store_registers): Now methods.
12580         (sparc_ravenscar_prepare_to_store): Remove.
12581         (sparc_ravenscar_ops): Redefine.
12582         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12583         methods and destructor.  Remove members.
12584         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12585         (ravenscar_thread_target::store_registers)
12586         (ravenscar_thread_target::prepare_to_store): Update.
12587         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12588         Remove.
12589         (struct ppc_ravenscar_powerpc_ops): Derive from
12590         ravenscar_arch_ops.
12591         (ppc_ravenscar_powerpc_ops::fetch_registers)
12592         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12593         (ppc_ravenscar_powerpc_ops): Redefine.
12594         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12595         (ppc_ravenscar_e500_ops::fetch_registers)
12596         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12597         (ppc_ravenscar_e500_ops): Redefine.
12598         * aarch64-ravenscar-thread.c
12599         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12600         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12601         (aarch64_ravenscar_fetch_registers)
12602         (aarch64_ravenscar_store_registers): Now methods.
12603         (aarch64_ravenscar_ops): Redefine.
12604
12605 2019-02-15  Tom Tromey  <tromey@adacore.com>
12606
12607         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12608         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12609         (ravenscar_thread_target::stopped_by_watchpoint)
12610         (ravenscar_thread_target::stopped_data_address)
12611         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12612
12613 2019-02-15  Tom Tromey  <tromey@adacore.com>
12614
12615         * ravenscar-thread.c: Fix some typos.
12616
12617 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12618             Tom Tromey  <tromey@adacore.com>
12619
12620         * ada-lang.c (ada_exception_sal): Change addr_string to a
12621         std::string.
12622         (create_ada_exception_catchpoint): Update.
12623
12624 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12625             Tom Tromey  <tromey@adacore.com>
12626
12627         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12628         (bp_location_ops): Remove.
12629         (base_breakpoint_allocate_location): Update.
12630         (free_bp_location): Update.
12631         * ada-lang.c (class ada_catchpoint_location)
12632         <ada_catchpoint_location>: Remove ops parameter.
12633         (ada_catchpoint_location_dtor): Remove.
12634         (ada_catchpoint_location_ops): Remove.
12635         (allocate_location_exception): Update.
12636         * breakpoint.h (struct bp_location_ops): Remove.
12637         (class bp_location) <bp_location>: Remove bp_location_ops
12638         parameter.
12639         <~bp_location>: Add destructor.
12640         <ops>: Remove.
12641
12642 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12643             Pedro Alves  <palves@redhat.com>
12644
12645         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12646         'PATH_MAX'.
12647
12648 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12649             Samuel Thibault  <samuel.thibault@gnu.org>
12650             Thomas Schwinge  <thomas@codesourcery.com>
12651
12652         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12653         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12654
12655 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12656
12657         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12658         (check_empty): Use "const char *".
12659
12660         * gnu-nat.c (gnu_nat_target::detach): Instead of
12661         'detach_inferior (pid)' call
12662         'detach_inferior (find_inferior_pid (pid))'.
12663
12664         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12665         'nat/fork-inferior.o'.
12666         * gnu-nat.c: #include "nat/fork-inferior.h".
12667
12668         * gnu-nat.c (gnu_nat_target::detach): Instead of
12669         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12670         * gnu-nat.h: #include "inf-child.h".
12671         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12672         'i386_gnu_nat_target::fetch_registers'.
12673         (gnu_store_registers): Rename/move to
12674         'i386_gnu_nat_target::store_registers'.
12675
12676         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12677         * gnu-nat.h (mach_thread_info): New function.
12678         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12679
12680         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12681
12682 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12683
12684         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12685
12686 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12687
12688         * windows-nat.c (windows_add_thread): Add new parameter
12689         "main_thread_p" with default value set to false.  Update
12690         function documentation as well as all callers.
12691         (windows_delete_thread): Likewise.
12692         (fake_create_process): Update call to windows_add_thread.
12693         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12694         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12695         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12696         call to windows_delete_thread.
12697
12698 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12699
12700         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12701
12702 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12703
12704         * symfile.c (find_separate_debug_file): Use canonical path of
12705         sysroot with child_path instead of gdb_sysroot if it is valid.
12706
12707 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12708
12709         * symfile.c (find_separate_debug_file): Use child_path to
12710         determine if an object file is under a sysroot.
12711
12712 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12713
12714         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12715         unittests/child-path-selftests.c.
12716         * common/pathstuff.c (child_path): New function.
12717         * common/pathstuff.h (child_path): New prototype.
12718         * unittests/child-path-selftests.c: New file.
12719
12720 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12721
12722         * symfile.c (find_separate_debug_file): Look for separate debug
12723         files in debug directories under the sysroot.
12724
12725 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12726
12727         * symtab.h (struct minimal_symbol data_p): New const method.
12728         (struct minimal_symbol text_p): Likewise.
12729         * symtab.c (output_source_filename): Use file name style
12730         to print file name.
12731         (print_symbol_info): Likewise.
12732         (print_msymbol_info): Use address style to print addresses.
12733         Use function name style to print executable text symbols.
12734         (expand_symtab_containing_pc): Use data_p.
12735         (find_pc_sect_compunit_symtab): Likewise.
12736
12737 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12738
12739         * breakpoint.c (describe_other_breakpoints): Use address style
12740         to print addresses.
12741         (say_where): Likewise.
12742
12743 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12744
12745         * ada-typeprint.c (print_func_type): Print function name
12746         style to print function name.
12747         * c-typeprint.c (c_print_type_1): Likewise.
12748
12749 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12750
12751         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12752         for execve.
12753
12754 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12755
12756         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12757         type_stack.
12758
12759 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12760
12761         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12762         TYPE_CODE_REF types.
12763
12764 2019-02-08  Jim Wilson  <jimw@sifive.com>
12765
12766         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12767         (riscv_linux_fregset): New.
12768         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12769
12770 2019-02-07  Tom Tromey  <tom@tromey.com>
12771
12772         * thread.c (thread_cancel_execution_command): Update.
12773         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12774         methods.
12775         (struct thread_fsm_ops): Remove.
12776         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12777         (thread_fsm_should_stop, thread_fsm_return_value)
12778         (thread_fsm_set_finished, thread_fsm_finished_p)
12779         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12780         Don't declare.
12781         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12782         * infrun.c (clear_proceed_status_thread)
12783         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12784         (print_stop_event): Update.
12785         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12786         Add constructor.
12787         (step_command_fsm_ops): Remove.
12788         (new_step_command_fsm): Remove.
12789         (step_1): Update.
12790         (step_command_fsm::should_stop): Rename from
12791         step_command_fsm_should_stop.
12792         (step_command_fsm::clean_up): Rename from
12793         step_command_fsm_clean_up.
12794         (step_command_fsm::do_async_reply_reason): Rename from
12795         step_command_fsm_async_reply_reason.
12796         (struct until_next_fsm): Inherit from thread_fsm.  Add
12797         constructor.
12798         (until_next_fsm_ops): Remove.
12799         (new_until_next_fsm): Remove.
12800         (until_next_fsm::should_stop): Rename from
12801         until_next_fsm_should_stop.
12802         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12803         (until_next_fsm::do_async_reply_reason): Rename from
12804         until_next_fsm_async_reply_reason.
12805         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12806         constructor.  Change type of breakpoint.
12807         (finish_command_fsm_ops): Remove.
12808         (new_finish_command_fsm): Remove.
12809         (finish_command_fsm::should_stop): Rename from
12810         finish_command_fsm_should_stop.
12811         (finish_command_fsm::clean_up): Rename from
12812         finish_command_fsm_clean_up.
12813         (finish_command_fsm::return_value): Rename from
12814         finish_command_fsm_return_value.
12815         (finish_command_fsm::do_async_reply_reason): Rename from
12816         finish_command_fsm_async_reply_reason.
12817         (finish_command): Update.
12818         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12819         Add constructor.
12820         (call_thread_fsm_ops): Remove.
12821         (call_thread_fsm::call_thread_fsm): Rename from
12822         new_call_thread_fsm.
12823         (call_thread_fsm::should_stop): Rename from
12824         call_thread_fsm_should_stop.
12825         (call_thread_fsm::should_notify_stop): Rename from
12826         call_thread_fsm_should_notify_stop.
12827         (run_inferior_call, call_function_by_hand_dummy): Update.
12828         * cli/cli-interp.c (should_print_stop_to_console): Update.
12829         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12830         Add constructor.  Change type of location_breakpoint,
12831         caller_breakpoint.
12832         (until_break_fsm_ops): Remove.
12833         (new_until_break_fsm): Remove.
12834         (until_break_fsm::should_stop): Rename from
12835         until_break_fsm_should_stop.
12836         (until_break_fsm::clean_up): Rename from
12837         until_break_fsm_clean_up.
12838         (until_break_fsm::do_async_reply_reason): Rename from
12839         until_break_fsm_async_reply_reason.
12840         (until_break_command): Update.
12841         * thread-fsm.c: Remove.
12842         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12843
12844 2019-02-07  Tom Tromey  <tom@tromey.com>
12845
12846         * yy-remap.h: Add include guard.
12847         * xtensa-tdep.h: Add include guard.
12848         * xcoffread.h: Rename include guard.
12849         * varobj-iter.h: Add include guard.
12850         * tui/tui.h: Rename include guard.
12851         * tui/tui-winsource.h: Rename include guard.
12852         * tui/tui-wingeneral.h: Rename include guard.
12853         * tui/tui-windata.h: Rename include guard.
12854         * tui/tui-win.h: Rename include guard.
12855         * tui/tui-stack.h: Rename include guard.
12856         * tui/tui-source.h: Rename include guard.
12857         * tui/tui-regs.h: Rename include guard.
12858         * tui/tui-out.h: Rename include guard.
12859         * tui/tui-layout.h: Rename include guard.
12860         * tui/tui-io.h: Rename include guard.
12861         * tui/tui-hooks.h: Rename include guard.
12862         * tui/tui-file.h: Rename include guard.
12863         * tui/tui-disasm.h: Rename include guard.
12864         * tui/tui-data.h: Rename include guard.
12865         * tui/tui-command.h: Rename include guard.
12866         * tic6x-tdep.h: Add include guard.
12867         * target/waitstatus.h: Rename include guard.
12868         * target/wait.h: Rename include guard.
12869         * target/target.h: Rename include guard.
12870         * target/resume.h: Rename include guard.
12871         * target-float.h: Rename include guard.
12872         * stabsread.h: Add include guard.
12873         * rs6000-tdep.h: Add include guard.
12874         * riscv-fbsd-tdep.h: Add include guard.
12875         * regformats/regdef.h: Rename include guard.
12876         * record.h: Rename include guard.
12877         * python/python.h: Rename include guard.
12878         * python/python-internal.h: Rename include guard.
12879         * python/py-stopevent.h: Rename include guard.
12880         * python/py-ref.h: Rename include guard.
12881         * python/py-record.h: Rename include guard.
12882         * python/py-record-full.h: Rename include guard.
12883         * python/py-record-btrace.h: Rename include guard.
12884         * python/py-instruction.h: Rename include guard.
12885         * python/py-events.h: Rename include guard.
12886         * python/py-event.h: Rename include guard.
12887         * procfs.h: Add include guard.
12888         * proc-utils.h: Add include guard.
12889         * p-lang.h: Add include guard.
12890         * or1k-tdep.h: Rename include guard.
12891         * observable.h: Rename include guard.
12892         * nto-tdep.h: Rename include guard.
12893         * nat/x86-linux.h: Rename include guard.
12894         * nat/x86-linux-dregs.h: Rename include guard.
12895         * nat/x86-gcc-cpuid.h: Add include guard.
12896         * nat/x86-dregs.h: Rename include guard.
12897         * nat/x86-cpuid.h: Rename include guard.
12898         * nat/ppc-linux.h: Rename include guard.
12899         * nat/mips-linux-watch.h: Rename include guard.
12900         * nat/linux-waitpid.h: Rename include guard.
12901         * nat/linux-ptrace.h: Rename include guard.
12902         * nat/linux-procfs.h: Rename include guard.
12903         * nat/linux-osdata.h: Rename include guard.
12904         * nat/linux-nat.h: Rename include guard.
12905         * nat/linux-namespaces.h: Rename include guard.
12906         * nat/linux-btrace.h: Rename include guard.
12907         * nat/glibc_thread_db.h: Rename include guard.
12908         * nat/gdb_thread_db.h: Rename include guard.
12909         * nat/gdb_ptrace.h: Rename include guard.
12910         * nat/fork-inferior.h: Rename include guard.
12911         * nat/amd64-linux-siginfo.h: Rename include guard.
12912         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12913         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12914         * nat/aarch64-linux.h: Rename include guard.
12915         * nat/aarch64-linux-hw-point.h: Rename include guard.
12916         * mn10300-tdep.h: Add include guard.
12917         * mips-linux-tdep.h: Add include guard.
12918         * mi/mi-parse.h: Rename include guard.
12919         * mi/mi-out.h: Rename include guard.
12920         * mi/mi-main.h: Rename include guard.
12921         * mi/mi-interp.h: Rename include guard.
12922         * mi/mi-getopt.h: Rename include guard.
12923         * mi/mi-console.h: Rename include guard.
12924         * mi/mi-common.h: Rename include guard.
12925         * mi/mi-cmds.h: Rename include guard.
12926         * mi/mi-cmd-break.h: Rename include guard.
12927         * m2-lang.h: Add include guard.
12928         * location.h: Rename include guard.
12929         * linux-record.h: Rename include guard.
12930         * linux-nat.h: Add include guard.
12931         * linux-fork.h: Add include guard.
12932         * i386-darwin-tdep.h: Rename include guard.
12933         * hppa-linux-offsets.h: Add include guard.
12934         * guile/guile.h: Rename include guard.
12935         * guile/guile-internal.h: Rename include guard.
12936         * gnu-nat.h: Rename include guard.
12937         * gdb-stabs.h: Rename include guard.
12938         * frv-tdep.h: Add include guard.
12939         * f-lang.h: Add include guard.
12940         * event-loop.h: Add include guard.
12941         * darwin-nat.h: Rename include guard.
12942         * cp-abi.h: Rename include guard.
12943         * config/sparc/nm-sol2.h: Rename include guard.
12944         * config/nm-nto.h: Rename include guard.
12945         * config/nm-linux.h: Add include guard.
12946         * config/i386/nm-i386gnu.h: Rename include guard.
12947         * config/djgpp/nl_types.h: Rename include guard.
12948         * config/djgpp/langinfo.h: Rename include guard.
12949         * compile/gcc-cp-plugin.h: Add include guard.
12950         * compile/gcc-c-plugin.h: Add include guard.
12951         * compile/compile.h: Rename include guard.
12952         * compile/compile-object-run.h: Rename include guard.
12953         * compile/compile-object-load.h: Rename include guard.
12954         * compile/compile-internal.h: Rename include guard.
12955         * compile/compile-cplus.h: Rename include guard.
12956         * compile/compile-c.h: Rename include guard.
12957         * common/xml-utils.h: Rename include guard.
12958         * common/x86-xstate.h: Rename include guard.
12959         * common/version.h: Rename include guard.
12960         * common/vec.h: Rename include guard.
12961         * common/tdesc.h: Rename include guard.
12962         * common/selftest.h: Rename include guard.
12963         * common/scoped_restore.h: Rename include guard.
12964         * common/scoped_mmap.h: Rename include guard.
12965         * common/scoped_fd.h: Rename include guard.
12966         * common/safe-iterator.h: Rename include guard.
12967         * common/run-time-clock.h: Rename include guard.
12968         * common/refcounted-object.h: Rename include guard.
12969         * common/queue.h: Rename include guard.
12970         * common/ptid.h: Rename include guard.
12971         * common/print-utils.h: Rename include guard.
12972         * common/preprocessor.h: Rename include guard.
12973         * common/pathstuff.h: Rename include guard.
12974         * common/observable.h: Rename include guard.
12975         * common/netstuff.h: Rename include guard.
12976         * common/job-control.h: Rename include guard.
12977         * common/host-defs.h: Rename include guard.
12978         * common/gdb_wait.h: Rename include guard.
12979         * common/gdb_vecs.h: Rename include guard.
12980         * common/gdb_unlinker.h: Rename include guard.
12981         * common/gdb_unique_ptr.h: Rename include guard.
12982         * common/gdb_tilde_expand.h: Rename include guard.
12983         * common/gdb_sys_time.h: Rename include guard.
12984         * common/gdb_string_view.h: Rename include guard.
12985         * common/gdb_splay_tree.h: Rename include guard.
12986         * common/gdb_setjmp.h: Rename include guard.
12987         * common/gdb_ref_ptr.h: Rename include guard.
12988         * common/gdb_optional.h: Rename include guard.
12989         * common/gdb_locale.h: Rename include guard.
12990         * common/gdb_assert.h: Rename include guard.
12991         * common/filtered-iterator.h: Rename include guard.
12992         * common/filestuff.h: Rename include guard.
12993         * common/fileio.h: Rename include guard.
12994         * common/environ.h: Rename include guard.
12995         * common/common-utils.h: Rename include guard.
12996         * common/common-types.h: Rename include guard.
12997         * common/common-regcache.h: Rename include guard.
12998         * common/common-inferior.h: Rename include guard.
12999         * common/common-gdbthread.h: Rename include guard.
13000         * common/common-exceptions.h: Rename include guard.
13001         * common/common-defs.h: Rename include guard.
13002         * common/common-debug.h: Rename include guard.
13003         * common/cleanups.h: Rename include guard.
13004         * common/buffer.h: Rename include guard.
13005         * common/btrace-common.h: Rename include guard.
13006         * common/break-common.h: Rename include guard.
13007         * cli/cli-utils.h: Rename include guard.
13008         * cli/cli-style.h: Rename include guard.
13009         * cli/cli-setshow.h: Rename include guard.
13010         * cli/cli-script.h: Rename include guard.
13011         * cli/cli-interp.h: Rename include guard.
13012         * cli/cli-decode.h: Rename include guard.
13013         * cli/cli-cmds.h: Rename include guard.
13014         * charset-list.h: Add include guard.
13015         * buildsym-legacy.h: Rename include guard.
13016         * bfin-tdep.h: Add include guard.
13017         * ax.h: Rename include guard.
13018         * arm-linux-tdep.h: Add include guard.
13019         * arm-fbsd-tdep.h: Add include guard.
13020         * arch/xtensa.h: Rename include guard.
13021         * arch/tic6x.h: Add include guard.
13022         * arch/i386.h: Add include guard.
13023         * arch/arm.h: Rename include guard.
13024         * arch/arm-linux.h: Rename include guard.
13025         * arch/arm-get-next-pcs.h: Rename include guard.
13026         * arch/amd64.h: Add include guard.
13027         * arch/aarch64-insn.h: Rename include guard.
13028         * arch-utils.h: Rename include guard.
13029         * annotate.h: Add include guard.
13030         * amd64-darwin-tdep.h: Rename include guard.
13031         * aarch64-linux-tdep.h: Add include guard.
13032         * aarch64-fbsd-tdep.h: Add include guard.
13033         * aarch32-linux-nat.h: Add include guard.
13034
13035 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13036
13037         * macrotab.c (macro_define_internal): New function that
13038         factorizes macro_define_object_internal and macro_define_function
13039         code.
13040         (macro_define_object_internal): Use macro_define_internal.
13041         (macro_define_function): Likewise.
13042
13043 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13044
13045         * macrocmd.c (extract_identifier): Return
13046         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13047         callers.
13048
13049 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13050
13051         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13052
13053 2019-02-05  Tom Tromey  <tom@tromey.com>
13054
13055         * target.c (target_stack::unpush): Move assertion earlier.
13056
13057 2019-01-30  Tom Tromey  <tom@tromey.com>
13058
13059         PR python/23615:
13060         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13061         (gdbpy_parse_and_eval): Likewise.
13062         * python/python-internal.h (gdbpy_allow_threads): New class.
13063
13064 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13065
13066         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13067         (aarch64_fbsd_fpregmap): Move earlier.
13068         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13069         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13070         instead of individual calls to trad_frame_set_reg_addr.
13071         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13072         earlier.
13073         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13074         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13075         instead of individual calls to trad_frame_set_reg_addr.
13076
13077 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13078
13079         * CONTRIBUTE: Replace contribution list with wiki link.
13080
13081 2019-01-25  Tom Tromey  <tom@tromey.com>
13082
13083         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13084
13085 2019-01-25  Tom Tromey  <tom@tromey.com>
13086
13087         * xtensa-linux-nat.c: Fix common/ includes.
13088         * xml-support.h: Fix common/ includes.
13089         * xml-support.c: Fix common/ includes.
13090         * x86-linux-nat.c: Fix common/ includes.
13091         * windows-nat.c: Fix common/ includes.
13092         * varobj.h: Fix common/ includes.
13093         * varobj.c: Fix common/ includes.
13094         * value.c: Fix common/ includes.
13095         * valops.c: Fix common/ includes.
13096         * utils.c: Fix common/ includes.
13097         * unittests/xml-utils-selftests.c: Fix common/ includes.
13098         * unittests/utils-selftests.c: Fix common/ includes.
13099         * unittests/unpack-selftests.c: Fix common/ includes.
13100         * unittests/tracepoint-selftests.c: Fix common/ includes.
13101         * unittests/style-selftests.c: Fix common/ includes.
13102         * unittests/string_view-selftests.c: Fix common/ includes.
13103         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13104         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13105         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13106         * unittests/rsp-low-selftests.c: Fix common/ includes.
13107         * unittests/parse-connection-spec-selftests.c: Fix common/
13108         includes.
13109         * unittests/optional-selftests.c: Fix common/ includes.
13110         * unittests/offset-type-selftests.c: Fix common/ includes.
13111         * unittests/observable-selftests.c: Fix common/ includes.
13112         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13113         * unittests/memrange-selftests.c: Fix common/ includes.
13114         * unittests/memory-map-selftests.c: Fix common/ includes.
13115         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13116         * unittests/function-view-selftests.c: Fix common/ includes.
13117         * unittests/environ-selftests.c: Fix common/ includes.
13118         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13119         * unittests/common-utils-selftests.c: Fix common/ includes.
13120         * unittests/cli-utils-selftests.c: Fix common/ includes.
13121         * unittests/array-view-selftests.c: Fix common/ includes.
13122         * ui-file.c: Fix common/ includes.
13123         * tui/tui-io.c: Fix common/ includes.
13124         * tracepoint.h: Fix common/ includes.
13125         * tracepoint.c: Fix common/ includes.
13126         * tracefile-tfile.c: Fix common/ includes.
13127         * top.h: Fix common/ includes.
13128         * top.c: Fix common/ includes.
13129         * thread.c: Fix common/ includes.
13130         * target/waitstatus.h: Fix common/ includes.
13131         * target/waitstatus.c: Fix common/ includes.
13132         * target.h: Fix common/ includes.
13133         * target.c: Fix common/ includes.
13134         * target-memory.c: Fix common/ includes.
13135         * target-descriptions.c: Fix common/ includes.
13136         * symtab.h: Fix common/ includes.
13137         * symfile.c: Fix common/ includes.
13138         * stap-probe.c: Fix common/ includes.
13139         * spu-linux-nat.c: Fix common/ includes.
13140         * sparc-nat.c: Fix common/ includes.
13141         * source.c: Fix common/ includes.
13142         * solib.c: Fix common/ includes.
13143         * solib-target.c: Fix common/ includes.
13144         * ser-unix.c: Fix common/ includes.
13145         * ser-tcp.c: Fix common/ includes.
13146         * ser-pipe.c: Fix common/ includes.
13147         * ser-base.c: Fix common/ includes.
13148         * selftest-arch.c: Fix common/ includes.
13149         * s12z-tdep.c: Fix common/ includes.
13150         * rust-exp.y: Fix common/ includes.
13151         * rs6000-aix-tdep.c: Fix common/ includes.
13152         * riscv-tdep.c: Fix common/ includes.
13153         * remote.c: Fix common/ includes.
13154         * remote-notif.h: Fix common/ includes.
13155         * remote-fileio.h: Fix common/ includes.
13156         * remote-fileio.c: Fix common/ includes.
13157         * regcache.h: Fix common/ includes.
13158         * regcache.c: Fix common/ includes.
13159         * record-btrace.c: Fix common/ includes.
13160         * python/python.c: Fix common/ includes.
13161         * python/py-type.c: Fix common/ includes.
13162         * python/py-inferior.c: Fix common/ includes.
13163         * progspace.h: Fix common/ includes.
13164         * producer.c: Fix common/ includes.
13165         * procfs.c: Fix common/ includes.
13166         * proc-api.c: Fix common/ includes.
13167         * printcmd.c: Fix common/ includes.
13168         * ppc-linux-nat.c: Fix common/ includes.
13169         * parser-defs.h: Fix common/ includes.
13170         * osdata.c: Fix common/ includes.
13171         * obsd-nat.c: Fix common/ includes.
13172         * nat/x86-linux.c: Fix common/ includes.
13173         * nat/x86-linux-dregs.c: Fix common/ includes.
13174         * nat/x86-dregs.h: Fix common/ includes.
13175         * nat/x86-dregs.c: Fix common/ includes.
13176         * nat/ppc-linux.c: Fix common/ includes.
13177         * nat/mips-linux-watch.h: Fix common/ includes.
13178         * nat/mips-linux-watch.c: Fix common/ includes.
13179         * nat/linux-waitpid.c: Fix common/ includes.
13180         * nat/linux-ptrace.h: Fix common/ includes.
13181         * nat/linux-ptrace.c: Fix common/ includes.
13182         * nat/linux-procfs.c: Fix common/ includes.
13183         * nat/linux-personality.c: Fix common/ includes.
13184         * nat/linux-osdata.c: Fix common/ includes.
13185         * nat/linux-namespaces.c: Fix common/ includes.
13186         * nat/linux-btrace.h: Fix common/ includes.
13187         * nat/linux-btrace.c: Fix common/ includes.
13188         * nat/fork-inferior.c: Fix common/ includes.
13189         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13190         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13191         * nat/aarch64-linux.c: Fix common/ includes.
13192         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13193         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13194         * namespace.h: Fix common/ includes.
13195         * mips-linux-tdep.c: Fix common/ includes.
13196         * minsyms.c: Fix common/ includes.
13197         * mi/mi-parse.h: Fix common/ includes.
13198         * mi/mi-main.c: Fix common/ includes.
13199         * mi/mi-cmd-env.c: Fix common/ includes.
13200         * memrange.h: Fix common/ includes.
13201         * memattr.c: Fix common/ includes.
13202         * maint.h: Fix common/ includes.
13203         * maint.c: Fix common/ includes.
13204         * main.c: Fix common/ includes.
13205         * machoread.c: Fix common/ includes.
13206         * location.c: Fix common/ includes.
13207         * linux-thread-db.c: Fix common/ includes.
13208         * linux-nat.c: Fix common/ includes.
13209         * linux-fork.c: Fix common/ includes.
13210         * inline-frame.c: Fix common/ includes.
13211         * infrun.c: Fix common/ includes.
13212         * inflow.c: Fix common/ includes.
13213         * inferior.h: Fix common/ includes.
13214         * inferior.c: Fix common/ includes.
13215         * infcmd.c: Fix common/ includes.
13216         * inf-ptrace.c: Fix common/ includes.
13217         * inf-child.c: Fix common/ includes.
13218         * ia64-linux-nat.c: Fix common/ includes.
13219         * i387-tdep.c: Fix common/ includes.
13220         * i386-tdep.c: Fix common/ includes.
13221         * i386-linux-tdep.c: Fix common/ includes.
13222         * i386-linux-nat.c: Fix common/ includes.
13223         * i386-go32-tdep.c: Fix common/ includes.
13224         * i386-fbsd-tdep.c: Fix common/ includes.
13225         * i386-fbsd-nat.c: Fix common/ includes.
13226         * guile/scm-type.c: Fix common/ includes.
13227         * guile/guile.c: Fix common/ includes.
13228         * go32-nat.c: Fix common/ includes.
13229         * gnu-nat.c: Fix common/ includes.
13230         * gdbthread.h: Fix common/ includes.
13231         * gdbarch-selftests.c: Fix common/ includes.
13232         * gdb_usleep.c: Fix common/ includes.
13233         * gdb_select.h: Fix common/ includes.
13234         * gdb_bfd.c: Fix common/ includes.
13235         * gcore.c: Fix common/ includes.
13236         * fork-child.c: Fix common/ includes.
13237         * findvar.c: Fix common/ includes.
13238         * fbsd-nat.c: Fix common/ includes.
13239         * event-top.c: Fix common/ includes.
13240         * event-loop.c: Fix common/ includes.
13241         * dwarf2read.c: Fix common/ includes.
13242         * dwarf2loc.c: Fix common/ includes.
13243         * dwarf2-frame.c: Fix common/ includes.
13244         * dwarf-index-cache.c: Fix common/ includes.
13245         * dtrace-probe.c: Fix common/ includes.
13246         * disasm-selftests.c: Fix common/ includes.
13247         * defs.h: Fix common/ includes.
13248         * csky-tdep.c: Fix common/ includes.
13249         * cp-valprint.c: Fix common/ includes.
13250         * cp-support.h: Fix common/ includes.
13251         * cp-support.c: Fix common/ includes.
13252         * corelow.c: Fix common/ includes.
13253         * completer.h: Fix common/ includes.
13254         * completer.c: Fix common/ includes.
13255         * compile/compile.c: Fix common/ includes.
13256         * compile/compile-loc2c.c: Fix common/ includes.
13257         * compile/compile-cplus-types.c: Fix common/ includes.
13258         * compile/compile-cplus-symbols.c: Fix common/ includes.
13259         * command.h: Fix common/ includes.
13260         * cli/cli-dump.c: Fix common/ includes.
13261         * cli/cli-cmds.c: Fix common/ includes.
13262         * charset.c: Fix common/ includes.
13263         * build-id.c: Fix common/ includes.
13264         * btrace.h: Fix common/ includes.
13265         * btrace.c: Fix common/ includes.
13266         * breakpoint.h: Fix common/ includes.
13267         * breakpoint.c: Fix common/ includes.
13268         * ax.h:
13269         (enum agent_op): Fix common/ includes.
13270         * ax-general.c (struct aop_map): Fix common/ includes.
13271         * ax-gdb.c: Fix common/ includes.
13272         * auxv.c: Fix common/ includes.
13273         * auto-load.c: Fix common/ includes.
13274         * arm-tdep.c: Fix common/ includes.
13275         * arch/riscv.c: Fix common/ includes.
13276         * arch/ppc-linux-common.c: Fix common/ includes.
13277         * arch/i386.c: Fix common/ includes.
13278         * arch/arm.c: Fix common/ includes.
13279         * arch/arm-linux.c: Fix common/ includes.
13280         * arch/arm-get-next-pcs.c: Fix common/ includes.
13281         * arch/amd64.c: Fix common/ includes.
13282         * arch/aarch64.c: Fix common/ includes.
13283         * arch/aarch64-insn.c: Fix common/ includes.
13284         * arch-utils.c: Fix common/ includes.
13285         * amd64-windows-tdep.c: Fix common/ includes.
13286         * amd64-tdep.c: Fix common/ includes.
13287         * amd64-sol2-tdep.c: Fix common/ includes.
13288         * amd64-obsd-tdep.c: Fix common/ includes.
13289         * amd64-nbsd-tdep.c: Fix common/ includes.
13290         * amd64-linux-tdep.c: Fix common/ includes.
13291         * amd64-linux-nat.c: Fix common/ includes.
13292         * amd64-fbsd-tdep.c: Fix common/ includes.
13293         * amd64-fbsd-nat.c: Fix common/ includes.
13294         * amd64-dicos-tdep.c: Fix common/ includes.
13295         * amd64-darwin-tdep.c: Fix common/ includes.
13296         * agent.c: Fix common/ includes.
13297         * ada-lang.h: Fix common/ includes.
13298         * ada-lang.c: Fix common/ includes.
13299         * aarch64-tdep.c: Fix common/ includes.
13300
13301 2019-01-25  Tom Tromey  <tom@tromey.com>
13302
13303         * common/create-version.sh: Use common/version.h.
13304
13305 2019-01-24  Pedro Alves  <palves@redhat.com>
13306
13307         * infrun.c (signal_stop, signal_print, signal_program)
13308         (signal_catch, signal_pass): Now arrays instead of pointers.
13309         (update_signals_program_target, do_target_resume)
13310         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13311         * linux-nat.c (linux_nat_target::pass_signals)
13312         (linux_nat_target::create_inferior, linux_nat_target::attach):
13313         Adjust.
13314         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13315         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13316         * procfs.c (procfs_target::pass_signals): Adjust.
13317         * record-full.c (record_full_target::resume): Adjust.
13318         * remote.c (remote_target::pass_signals)
13319         (remote_target::program_signals): Adjust.
13320         * target-debug.h (target_debug_print_signals): Now takes a
13321         gdb::array_view as parameter.  Adjust.
13322         * target.h (target_ops) <pass_signals, program_signals>: Replace
13323         pointer and length parameters with gdb::array_view.
13324         (target_pass_signals, target_program_signals): Likewise.
13325         * target-delegates.c: Regenerate.
13326
13327 2019-01-24  Pedro Alves  <palves@redhat.com>
13328
13329         * common/forward-scope-exit.h
13330         (forward_scope_exit::forward_scope_exit): Pass arguments to
13331         m_bind_function directly, instead of creating a std::bind and
13332         copying that.
13333
13334 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13335
13336         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13337         for static members.
13338         (pass_in_v_vfp_candidate): Likewise.
13339
13340 2019-01-23  Tom Tromey  <tom@tromey.com>
13341             Pedro Alves  <palves@redhat.com>
13342
13343         * regcache.c (class regcache_invalidator): Remove.
13344         (regcache::raw_write): Use make_scope_exit.
13345
13346 2019-01-23  Tom Tromey  <tom@tromey.com>
13347
13348         * ui-out.h (class ui_out_emit_type): Update comment.
13349
13350 2019-01-23  Tom Tromey  <tom@tromey.com>
13351
13352         * infrun.c (fetch_inferior_event): Update comment.
13353
13354 2019-01-23  Tom Tromey  <tom@tromey.com>
13355             Pedro Alves  <palves@redhat.com>
13356
13357         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13358         parameter.
13359         (fetch_inferior_event): Use SCOPE_EXIT.
13360
13361
13362 2019-01-23  Tom Tromey  <tom@tromey.com>
13363             Pedro Alves  <palves@redhat.com>
13364
13365         * infrun.c (disable_thread_events): Delete.
13366         (stop_all_threads): Use SCOPE_EXIT.
13367
13368 2019-01-23  Tom Tromey  <tom@tromey.com>
13369             Pedro Alves  <palves@redhat.com>
13370
13371         * symfile.c: Include forward-scope-exit.h.
13372         (clear_symtab_users_cleanup): Replace forward declaration with
13373         a FORWARD_SCOPE_EXIT.
13374         (syms_from_objfile_1): Use the forward_scope_exit and
13375         gdb::optional instead of cleanup_function.
13376         (reread_symbols): Use the forward_scope_exit instead of
13377         cleanup_function.
13378         (clear_symtab_users_cleanup): Remove function.
13379
13380 2019-01-23  Tom Tromey  <tom@tromey.com>
13381             Pedro Alves  <palves@redhat.com>
13382
13383         * linux-nat.c: Include scope-exit.h.
13384         (cleanup_target_stop): Remove.
13385         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13386         SCOPE_EXIT.
13387
13388 2019-01-23  Tom Tromey  <tom@tromey.com>
13389             Pedro Alves  <palves@redhat.com>
13390
13391         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13392         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13393
13394 2019-01-23  Tom Tromey  <tom@tromey.com>
13395             Andrew Burgess  <andrew.burgess@embecosm.com>
13396             Pedro Alves  <palves@redhat.com>
13397
13398         * infrun.c (fetch_inferior_event): Use scope_exit.
13399         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13400         * top.c (execute_command): Use scope_exit.
13401         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13402         * utils.c (do_bpstat_clear_actions_cleanup)
13403         (make_bpstat_clear_actions_cleanup): Remove.
13404
13405 2019-01-23  Tom Tromey  <tom@tromey.com>
13406             Pedro Alves  <palves@redhat.com>
13407
13408         * infrun.c: Include "common/scope-exit.h"
13409         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13410         (wait_for_inferior): Use SCOPE_EXIT.
13411         (fetch_inferior_event): Use scope_exit.
13412
13413 2019-01-23  Tom Tromey  <tom@tromey.com>
13414             Pedro Alves  <palves@redhat.com>
13415
13416         * breakpoint.c (create_breakpoint): Remove cleanup.
13417
13418 2019-01-23  Tom Tromey  <tom@tromey.com>
13419             Andrew Burgess  <andrew.burgess@embecosm.com>
13420             Pedro Alves  <palves@redhat.com>
13421
13422 2019-01-23  Pedro Alves  <palves@redhat.com>
13423
13424         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13425
13426 2019-01-23  Pedro Alves  <palves@redhat.com>
13427             Andrew Burgess  <andrew.burgess@embecosm.com>
13428
13429         * gdbthread.h: Include "common/forward-scope-exit.h".
13430         (scoped_finish_thread_state): Redefine custom class in terms of
13431         forward_scope_exit.
13432
13433 2019-01-23  Pedro Alves  <palves@redhat.com>
13434             Andrew Burgess  <andrew.burgess@embecosm.com>
13435
13436         * common/forward-scope-exit.h: New file.
13437
13438 2019-01-23  Pedro Alves  <palves@redhat.com>
13439             Andrew Burgess  <andrew.burgess@embecosm.com>
13440             Tom Tromey  <tom@tromey.com>
13441
13442         * common/scope-exit.h: New file.
13443
13444 2019-01-23  Pedro Alves  <palves@redhat.com>
13445
13446         * common/preprocessor.h (ESC): Rename to ...
13447         (ESC_PARENS): ... this.
13448         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13449         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13450
13451 2019-01-23  Tom Tromey  <tom@tromey.com>
13452
13453         * language.h (class scoped_switch_to_sym_language_if_auto):
13454         Initialize m_lang in both cases.
13455
13456 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13457
13458         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13459         with XCNEW.
13460
13461 2019-01-22  Tom Tromey  <tom@tromey.com>
13462
13463         * corelow.c: Do not include sys/file.h.
13464
13465 2019-01-22  Tom Tromey  <tom@tromey.com>
13466
13467         * tui/tui-wingeneral.h: Include gdb_curses.h.
13468
13469 2019-01-22  Tom Tromey  <tom@tromey.com>
13470
13471         * source-cache.h (class source_cache) <get_source_lines,
13472         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13473
13474 2019-01-22  Tom Tromey  <tom@tromey.com>
13475
13476         * remote-fileio.h (struct remote_target): Declare.
13477
13478 2019-01-22  Tom Tromey  <tom@tromey.com>
13479
13480         * python/py-arch.c: Do not include py-ref.h.
13481         * python/py-bpevent.c: Do not include py-ref.h.
13482         * python/py-cmd.c: Do not include py-ref.h.
13483         * python/py-continueevent.c: Do not include py-ref.h.
13484         * python/py-event.h: Do not include py-ref.h.
13485         * python/py-evtregistry.c: Do not include py-ref.h.
13486         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13487         * python/py-frame.c: Do not include py-ref.h.
13488         * python/py-framefilter.c: Do not include py-ref.h.
13489         * python/py-function.c: Do not include py-ref.h.
13490         * python/py-infevents.c: Do not include py-ref.h.
13491         * python/py-linetable.c: Do not include py-ref.h.
13492         * python/py-objfile.c: Do not include py-ref.h.
13493         * python/py-param.c: Do not include py-ref.h.
13494         * python/py-prettyprint.c: Do not include py-ref.h.
13495         * python/py-progspace.c: Do not include py-ref.h.
13496         * python/py-symbol.c: Do not include py-ref.h.
13497         * python/py-symtab.c: Do not include py-ref.h.
13498         * python/py-type.c: Do not include py-ref.h.
13499         * python/py-unwind.c: Do not include py-ref.h.
13500         * python/py-utils.c: Do not include py-ref.h.
13501         * python/py-value.c: Do not include py-ref.h.
13502         * python/py-varobj.c: Do not include py-ref.h.
13503         * python/py-xmethods.c: Do not include py-ref.h.
13504         * python/python.c: Do not include py-ref.h.
13505         * varobj.c: Do not include py-ref.h.
13506
13507 2019-01-22  Tom Tromey  <tom@tromey.com>
13508
13509         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13510         keyword for bcache.
13511
13512 2019-01-22  Tom Tromey  <tom@tromey.com>
13513
13514         * compile/compile-cplus-types.c: Remove a comment by #include.
13515
13516 2019-01-22  Tom Tromey  <tom@tromey.com>
13517
13518         * compile/gcc-c-plugin.h: Include compile-internal.h.
13519
13520 2019-01-22  Tom Tromey  <tom@tromey.com>
13521
13522         * stabsread.c (EXTERN): Do not define.
13523         (symnum, next_symbol_text_func, processing_gcc_compilation)
13524         (within_function, global_sym_chain, global_stabs)
13525         (previous_stab_code, this_object_header_files)
13526         (n_this_object_header_files)
13527         (n_allocated_this_object_header_files): Define.
13528         * stabsread.h (EXTERN): Never define.  Use "extern".
13529
13530 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13531
13532         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13533         history_value.
13534
13535 2019-01-21  Tom Tromey  <tom@tromey.com>
13536
13537         * ui-out.c: Fix includes.
13538         * tui/tui-source.c: Fix includes.
13539         * target.c: Fix includes.
13540         * remote.c: Fix includes.
13541         * regcache.c: Fix includes.
13542         * python/py-block.c: Fix includes.
13543         * printcmd.c: Fix includes.
13544         * or1k-tdep.c: Fix includes.
13545         * mi/mi-main.c: Fix includes.
13546         * m32r-tdep.c: Fix includes.
13547         * csky-tdep.c: Fix includes.
13548         * compile/compile-cplus-types.c: Fix includes.
13549         * cli/cli-interp.c: Fix includes.
13550
13551 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13552
13553         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13554         for padding.
13555
13556 2019-01-16  Tom Tromey  <tom@tromey.com>
13557
13558         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13559         earlier.
13560         (struct objfile) <msymbols_range>: Move from top level.
13561         <msymbols>: New method.
13562         (class objfile_msymbols): Remove.
13563         * symtab.c (default_collect_symbol_completion_matches_break_on):
13564         Update.
13565         * symmisc.c (dump_msymbols): Update.
13566         * stabsread.c (scan_file_globals): Update.
13567         * objc-lang.c (info_selectors_command, info_classes_command)
13568         (find_methods): Update.
13569         * minsyms.c (find_solib_trampoline_target): Update.
13570         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13571         * coffread.c (coff_symfile_read): Update.
13572         * ada-lang.c (ada_lookup_simple_minsym)
13573         (ada_collect_symbol_completion_matches): Update.
13574
13575 2019-01-16  Tom Tromey  <tom@tromey.com>
13576
13577         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13578         type.  Remove no-argument constructor.
13579         <iterator::operator++>: Simplify.
13580         <begin>: Update.
13581         <end>: Use minimal_symbol_count.
13582
13583 2019-01-16  Tom Tromey  <tom@tromey.com>
13584
13585         * objfiles.h (struct objfile) <psymtabs>: New method.
13586         (class objfile_psymtabs): Remove.
13587         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13588         typedef.
13589         <range>: New method.
13590         (require_partial_symbols): Change return type.
13591         * psymtab.c (require_partial_symbols)
13592         (psym_expand_symtabs_matching): Update.
13593         * mdebugread.c (parse_partial_symbols): Update.
13594         * dbxread.c (dbx_end_psymtab): Update.
13595
13596 2019-01-15  Tom Tromey  <tom@tromey.com>
13597
13598         * symtab.c (lookup_objfile_from_block)
13599         (lookup_symbol_in_objfile_symtabs)
13600         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13601         (find_line_symtab, info_sources_command)
13602         (default_collect_symbol_completion_matches_break_on)
13603         (make_source_files_completion_list): Update.
13604         * symmisc.c (print_objfile_statistics, dump_objfile)
13605         (maintenance_print_symbols, maintenance_info_symtabs)
13606         (maintenance_check_symtabs, maintenance_info_line_tables):
13607         Update.
13608         * source.c (select_source_symtab)
13609         (forget_cached_source_info_for_objfile): Update.
13610         * objfiles.h (class objfile_compunits): Remove.
13611         (struct objfile) <compunits_range>: New typedef.
13612         (compunits): New method.
13613         * objfiles.c (objfile_relocate1): Update.
13614         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13615         * maint.c (count_symtabs_and_blocks): Update.
13616         * linespec.c (iterate_over_all_matching_symtabs): Update.
13617         * cp-support.c (add_symbol_overload_list_qualified): Update.
13618         * coffread.c (coff_symtab_read): Update.
13619         * ada-lang.c (add_nonlocal_symbols)
13620         (ada_collect_symbol_completion_matches)
13621         (ada_add_global_exceptions): Update.
13622
13623 2019-01-15  Tom Tromey  <tom@tromey.com>
13624
13625         * progspace.h (program_space) <objfiles_safe_range>: New
13626         typedef.
13627         <objfiles_safe>: New method.
13628         * objfiles.h (class all_objfiles_safe): Remove.
13629         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13630         * jit.c (jit_inferior_exit_hook): Update.
13631
13632 2019-01-17  Tom Tromey  <tom@tromey.com>
13633
13634         * progspace.h (program_space) <objfiles_range>: New typedef.
13635         <objfiles>: New method.
13636         <objfiles_head>: Rename from objfiles.
13637         (object_files): Update.
13638         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13639         * guile/scm-pretty-print.c
13640         (ppscm_find_pretty_printer_from_objfiles): Update.
13641         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13642         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13643         Update.
13644         * python/py-progspace.c (pspy_get_objfiles): Update.
13645         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13646         Update.
13647         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13648         (objfpy_lookup_objfile_by_build_id): Update.
13649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13650         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13651         Update.
13652         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13653         (expand_symtab_containing_pc, lookup_objfile_from_block)
13654         (lookup_static_symbol, basic_lookup_transparent_type)
13655         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13656         (find_line_symtab, info_sources_command)
13657         (default_collect_symbol_completion_matches_break_on)
13658         (make_source_files_completion_list, find_main_name): Update.
13659         * symmisc.c (print_symbol_bcache_statistics)
13660         (print_objfile_statistics, maintenance_print_symbols)
13661         (maintenance_print_msymbols, maintenance_print_objfiles)
13662         (maintenance_info_symtabs, maintenance_check_symtabs)
13663         (maintenance_expand_symtabs, maintenance_info_line_tables):
13664         Update.
13665         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13666         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13667         (map_overlay_command, unmap_overlay_command)
13668         (simple_overlay_update, expand_symtabs_matching)
13669         (map_symbol_filenames): Update.
13670         * symfile-debug.c (set_debug_symfile): Update.
13671         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13672         Update.
13673         * source.c (select_source_symtab, forget_cached_source_info):
13674         Update.
13675         * solib.c (solib_read_symbols): Update.
13676         * solib-spu.c (append_ocl_sos): Update.
13677         * psymtab.c (maintenance_print_psymbols)
13678         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13679         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13680         * printcmd.c (info_symbol_command): Update.
13681         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13682         Update.
13683         * objfiles.h (class all_objfiles): Remove.
13684         * objfiles.c (have_partial_symbols, have_full_symbols)
13685         (have_minimal_symbols, qsort_cmp, update_section_map)
13686         (shared_objfile_contains_address_p)
13687         (default_iterate_over_objfiles_in_search_order): Update.
13688         * objc-lang.c (info_selectors_command, info_classes_command)
13689         (find_methods): Update.
13690         * minsyms.c (find_solib_trampoline_target): Update.
13691         * maint.c (maintenance_info_sections)
13692         (maintenance_translate_address, count_symtabs_and_blocks):
13693         Update.
13694         * main.c (captured_main_1): Update.
13695         * linux-thread-db.c (try_thread_db_load_from_pdir)
13696         (has_libpthread): Update.
13697         * linespec.c (iterate_over_all_matching_symtabs)
13698         (search_minsyms_for_name): Update.
13699         * jit.c (jit_find_objf_with_entry_addr): Update.
13700         * hppa-tdep.c (find_unwind_entry)
13701         (hppa_lookup_stub_minimal_symbol): Update.
13702         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13703         Update.
13704         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13705         (elf_gnu_ifunc_resolve_by_got): Update.
13706         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13707         * dwarf-index-write.c (save_gdb_index_command): Update.
13708         * cp-support.c (add_symbol_overload_list_qualified): Update.
13709         * breakpoint.c (create_overlay_event_breakpoint)
13710         (create_longjmp_master_breakpoint)
13711         (create_std_terminate_master_breakpoint)
13712         (create_exception_master_breakpoint): Update.
13713         * blockframe.c (find_pc_partial_function): Update.
13714         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13715         (ada_collect_symbol_completion_matches)
13716         (ada_add_global_exceptions): Update.
13717
13718 2019-01-17  Tom Tromey  <tom@tromey.com>
13719
13720         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13721         declare VEC.
13722         (solib_target_parse_libraries): Change return type.
13723         (library_list_start_segment, library_list_start_section)
13724         (library_list_end_library, library_list_start_library); Update.
13725         (solib_target_free_library_list): Remove.
13726         (solib_target_parse_libraries): Remove cleanup.  Change return
13727         type.
13728         (solib_target_current_sos): Update.
13729
13730 2019-01-17  Tom Tromey  <tromey@bapiya>
13731
13732         * valprint.c: Replace "the the" with "the".
13733         * symtab.c: Replace "the the" with "the".
13734         * solib.c: Replace "the the" with "the".
13735         * solib-dsbt.c: Replace "the the" with "the".
13736         * linespec.c: Replace "the the" with "the".
13737         * dwarf2loc.h: Replace "the the" with "the".
13738         * amd64-windows-tdep.c: Replace "the the" with "the".
13739         * aarch64-tdep.c: Replace "the the" with "the".
13740
13741 2019-01-16  Keith Seitz  <keiths@redhat.com>
13742
13743         PR gdb/23773
13744         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13745         <builder>: Rename to ..
13746         <m_builder>: ... this and make private.
13747         (dwarf2_cu::get_builder): New method.  Change all users of
13748         `builder' to use this method.
13749         (dwarf2_start_symtab): Move to ...
13750         (dwarf2_cu::start_symtab): ... here.  Update all callers
13751         (setup_type_unit_groups): Move to ...
13752         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13753         callers.
13754         (dwarf2_cu::reset_builder): New method.
13755         (process_full_compunit, process_full_type_unit): Use
13756         dwarf2_cu::reset_builder.
13757         (follow_die_offset): Record the ancestor CU if it is different
13758         from the followed DIE's CU.
13759         (follow_die_sig_1): Likewise.
13760
13761 2019-01-15  Tom Tromey  <tom@tromey.com>
13762
13763         * remote.c (class remote_state) <buf>: Now a char_vector.
13764         <buf_size>: Remove.
13765         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13766         parameter.
13767         (remote_target::getpkt_or_notif_sane_1)
13768         (remote_target::getpkt_sane)
13769         (remote_target::getpkt_or_notif_sane): Likewise.
13770         (class remote_target) <putpkt>: New overload.
13771         (remote_target::read_frame): Change type of "buf_p".  Remove
13772         sizeof_p parameter.
13773         (packet_ok): New overload.
13774         (packet_check_result): New overload.
13775         Update all uses.
13776
13777 2019-01-14  Tom Tromey  <tom@tromey.com>
13778
13779         * remote-notif.c (handle_notification, remote_notif_ack)
13780         (remote_notif_parse): Make "buf" const.
13781         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13782         const.
13783         (remote_notif_parse, remote_notif_ack, handle_notification):
13784         Likewise.
13785         * remote.c (remote_notif_stop_parse): Make "buf" const.
13786         (remote_target::remote_parse_stop_reply): Make "buf" const.
13787         (remote_notif_stop_ack): Make "buf" const.
13788
13789 2019-01-14  Tom Tromey  <tom@tromey.com>
13790
13791         * remote.c (remote_console_output): Make parameter const.
13792
13793 2019-01-14  Tom Tromey  <tom@tromey.com>
13794
13795         * target-debug.h (target_debug_print_signals): Constify.
13796         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13797         * procfs.c (procfs_target::pass_signals): Update.
13798         * linux-nat.c (linux_nat_target::pass_signals): Update.
13799         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13800         * target-delegates.c: Rebuild.
13801         * remote.c (remote_target::program_signals): Update.
13802         (remote_target::pass_signals): Update.
13803         * target.c (target_pass_signals): Constify argument.
13804         (target_program_signals): Likewise.
13805         * target.h (struct target_ops) <pass_signals, program_signals>:
13806         Constify argument.
13807         (target_pass_signals, target_program_signals): Constify argument.
13808
13809 2019-01-14  Tom Tromey  <tom@tromey.com>
13810
13811         PR tui/28819:
13812         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13813
13814 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13815
13816         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13817         field.
13818         * rs6000-tdep.c: Include reggroups.h.
13819         (IS_V_ALIAS_PSEUDOREG): Define.
13820         (rs6000_register_name): Return names for the "vX" aliases.
13821         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13822         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13823         aliases.  Call default_register_reggroup_p for all other
13824         pseudo-registers.
13825         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13826         New functions.
13827         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13828         Handle "vX" aliases.
13829         (v_alias_pseudo_register_collect): New function.
13830         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13831         (rs6000_gdbarch_init): Initialize "vX" aliases as
13832         pseudo-registers.  Restore registration of
13833         rs6000_pseudo_register_reggroup_p with
13834         set_tdesc_pseudo_register_reggroup_p.
13835
13836 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13837
13838         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13839         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13840         set_gdbarch_num_pseudo_regs.
13841
13842 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13843
13844         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13845         Remove arg prefixname, add do_set and do_show.
13846         Add member functions set_list and show_list.
13847         * cli/cli-style.c (class cli_style_option): Update accordingly.
13848         (style_set_list): Move to file scope.
13849         (style_show_list): Likewise.
13850         (set_style): Call help_list.
13851         (show_style): Call cmd_show_list.
13852         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13853         Update to use the new macro.
13854
13855 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13856
13857         * ada-lang.c (_initialize_ada_language): Expand the help text
13858         for the "catch exception" command.
13859
13860 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13861
13862         * symtab.c (matching_obj_sections): Initialize obj,
13863         declare it closer to its usage.
13864
13865 2019-01-10  Tom Tromey  <tom@tromey.com>
13866
13867         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13868         (basic_inf_threads_range): Remove.
13869         (inf_threads_range, inf_non_exited_threads_range)
13870         (safe_inf_threads_range): Use next_adapter.
13871
13872 2019-01-10  Keith Seitz  <keiths@redhat.com>
13873
13874         PR gdb/23712
13875         PR symtab/23010
13876         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13877         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13878
13879 2019-01-10  Keith Seitz  <keiths@redhat.com>
13880
13881         PR gdb/23712
13882         PR symtab/23010
13883         * dictionary.c (pending_to_vector): Remove.
13884         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13885         Remove _1 suffix, replacing functions of the same name.  Update
13886         all callers.
13887         (dict_create_hashed, dict_create_hashed_expandable)
13888         (dict_create_linear, dict_create_linear_expandable, dict_free)
13889         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13890         Make functions static.
13891
13892 2019-01-10  Keith Seitz  <keiths@redhat.com>
13893
13894         PR gdb/23712
13895         PR symtab/23010
13896         * dictionary.h (struct dictionary): Replace declaration with
13897         multidictionary.
13898         (dict_create_hashed, dict_create_hashed_expandable)
13899         (dict_create_linear, dict_create_linear_expandable)
13900         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13901         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13902         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13903         taking multidictionary argument.
13904         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13905         * block.h (struct block) <dict>: Change to multidictionary
13906         and rename `multidict'.
13907         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13908         symmisc.c: Update all dictionary references to multidictionary.
13909
13910 2019-01-10  Keith Seitz  <keiths@redhat.com>
13911
13912         PR gdb/23712
13913         PR symtab/23010
13914         * dictionary.c: Include unordered_map.
13915         (pending_to_vector): New function.
13916         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13917         Rewrite the non-"_1" functions to take vector instead
13918         of linked list.
13919         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13920         "new" _1 versions of the same name.
13921         (multidictionary): Define.
13922         (std::hash<enum language): New definition.
13923         (collate_pending_symbols_by_language, mdict_create_hashed)
13924         (mdict_create_hashed_expandable, mdict_create_linear)
13925         (mdict_create_linear_expandable, mdict_free)
13926         (find_language_dictionary, create_new_language_dictionary)
13927         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13928         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13929         (mdict_size, mdict_empty): New functions.
13930         * dictionary.h (mdict_iterator): Define.
13931
13932 2019-01-10  Pedro Alves  <palves@redhat.com>
13933
13934         * breakpoint.c (read_uploaded_action)
13935         (create_tracepoint_from_upload): Adjust to use
13936         gdb::unique_xmalloc_ptr.
13937         * ctf.c (ctf_write_uploaded_tp):
13938         (SET_ARRAY_FIELD): Use emplace_back.
13939         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13940         * tracefile-tfile.c (tfile_write_uploaded_tp):
13941         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13942         gdb::unique_xmalloc_ptr.
13943         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13944         at_string, cond_string, cmd_strings>: Replace char pointers
13945         with gdb::unique_xmalloc_ptr.
13946
13947 2019-01-10  Pedro Alves  <palves@redhat.com>
13948
13949         * solib-target.c (library_list_start_library): Don't xstrdup name.
13950
13951 2019-01-10  Pedro Alves  <palves@redhat.com>
13952
13953         * mdebugread.c (parse_partial_symbols): Use
13954         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13955
13956 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13957
13958         * linux-fork.c (scoped_switch_fork_info)
13959         <~scoped_switch_fork_info>: Fix incorrect variable name.
13960
13961 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13962
13963         * linux-fork.c (scoped_switch_fork_info)
13964         <scoped_switch_fork_info>: Make explicit.
13965         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13966
13967 2019-01-10  Tom Tromey  <tom@tromey.com>
13968
13969         * objfiles.h (objfile::reset_psymtabs): Update.
13970         * objfiles.c (objfile::objfile): Update.
13971         * psymtab.h (psymtab_storage::obstack): Update.
13972         (psymtab_storage::m_obstack): Use gdb::optional.
13973         (class psymtab_storage): Update comment.  Remove objfile
13974         parameter.
13975         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13976
13977 2019-01-10  Tom Tromey  <tom@tromey.com>
13978
13979         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13980         <free_psymtabs>: Now private.
13981         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13982         (allocate_psymtab): Use new method.
13983
13984 2019-01-10  Tom Tromey  <tom@tromey.com>
13985
13986         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13987         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13988         * mdebugread.c (parse_partial_symbols): Use
13989         allocate_dependencies.
13990         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13991         allocate_dependencies.
13992         (process_psymtab_comp_unit_reader)
13993         (build_type_psymtab_dependencies): Likewise.
13994         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13995
13996 2019-01-10  Tom Tromey  <tom@tromey.com>
13997
13998         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13999         PSYMBOL_SET_LANGUAGE.
14000         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14001
14002 2019-01-10  Tom Tromey  <tom@tromey.com>
14003
14004         * psymtab.h (psymtab_storage::obstack): New method.
14005         <m_obstack>: Rename from obstack; now private.
14006         * psymtab.c (psymtab_storage): Update.
14007         * dwarf2read.c (create_addrmap_from_index)
14008         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14009         Update.
14010
14011 2019-01-10  Tom Tromey  <tom@tromey.com>
14012
14013         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14014         * objfiles.h (objfile::reset_psymtabs): New method.
14015
14016 2019-01-10  Tom Tromey  <tom@tromey.com>
14017
14018         * symmisc.c (print_symbol_bcache_statistics): Update.
14019         (print_objfile_statistics): Update.
14020         * symfile.c (reread_symbols): Update.
14021         * psymtab.h (class psymtab_storage): New.
14022         * psymtab.c (psymtab_storage): New constructor.
14023         (~psymtab_storage): New destructor.
14024         (require_partial_symbols): Update.
14025         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14026         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14027         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14028         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14029         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14030         (start_psymtab_common, end_psymtab_common)
14031         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14032         (allocate_psymtab): Update.
14033         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14034         Update.
14035         (dump_psymtab_addrmap, maintenance_print_psymbols)
14036         (maintenance_check_psymtabs): Update.
14037         (class objfile_psymtabs): Move to objfiles.h.
14038         * psympriv.h (discard_psymtab): Now inline.
14039         (psymtab_discarder::psymtab_discarder): Update.
14040         (psymtab_discarder::~psymtab_discarder): Update.
14041         (ALL_OBJFILE_PSYMTABS): Rewrite.
14042         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14043         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14044         Remove fields.
14045         <partial_symtabs>: New field.
14046         (class objfile_psymtabs): Move from psymtab.h.  Update.
14047         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14048         psymbol_cache.
14049         (objfile::~objfile): Don't destroy psymbol_cache.
14050         * mdebugread.c (parse_partial_symbols): Update.
14051         * dwarf2read.c (create_addrmap_from_index)
14052         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14053         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14054         (add_partial_subprogram, dwarf2_ranges_read): Update.
14055         * dwarf-index-write.c (write_address_map)
14056         (write_one_signatured_type, recursively_write_psymbols)
14057         (class debug_names, class debug_names, write_psymtabs_to_index):
14058         Update.
14059
14060 2019-01-10  Tom Tromey  <tom@tromey.com>
14061
14062         * symtab.h (SYMBOL_SET_NAMES): Update.
14063         (symbol_set_names): Update.
14064         (MSYMBOL_SET_NAMES): Update.
14065         * symtab.c (symbol_set_names): Change argument to be an
14066         objfile_per_bfd_storage.
14067         * psymtab.c (add_psymbol_to_bcache): Update.
14068         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14069
14070 2019-01-10  Tom Tromey  <tom@tromey.com>
14071
14072         * symtab.c (create_demangled_names_hash): Change argument to be an
14073         objfile_per_bfd_storage.
14074         (symbol_set_names): Update.
14075
14076 2019-01-10  Tom Tromey  <tom@tromey.com>
14077
14078         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14079         init_psymbol_list.
14080         * psymtab.c (init_psymbol_list): Do nothing if already called.
14081         * psympriv.h (init_psymbol_list): Add comment.
14082         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14083         init_psymbol_list.
14084         * dbxread.c (dbx_symfile_read): Unconditionally call
14085         init_psymbol_list.
14086
14087 2019-01-10  Tom Tromey  <tom@tromey.com>
14088
14089         * xcoffread.c (scan_xcoff_symtab): Update.
14090         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14091         "where".
14092         * mdebugread.c (parse_partial_symbols)
14093         (handle_psymbol_enumerators): Update.
14094         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14095         * dbxread.c (read_dbx_symtab): Update.
14096         * psympriv.h (psymbol_placement): New enum.
14097         (add_psymbol_to_list): Update.
14098
14099 2019-01-10  Tom Tromey  <tom@tromey.com>
14100
14101         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14102         static_psymbols parameters.
14103         (scan_xcoff_symtab): Update.
14104         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14105         static_psymbols parameters.
14106         * psympriv.h (start_psymtab_common): Update.
14107         * mdebugread.c (parse_partial_symbols): Update.
14108         * dwarf2read.c (create_partial_symtab): Update.
14109         * dbxread.c (read_dbx_symtab): Update.
14110         (start_psymtab): Remove global_psymbols and static_psymbols
14111         parameters.
14112
14113 2019-01-10  Tom Tromey  <tom@tromey.com>
14114
14115         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14116         * psymtab.c (allocate_psymtab): Add comment.
14117         * psympriv.h (allocate_psymtab): Add comment.
14118         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14119         initializations.
14120         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14121
14122 2019-01-10  Tom Tromey  <tom@tromey.com>
14123
14124         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14125         Don't declare.
14126         * mipsread.c: Include mdebugread.h.
14127         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14128         Declare.
14129         * elfread.c: Include mdebugread.h.
14130
14131 2019-01-09  Tom Tromey  <tom@tromey.com>
14132
14133         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14134         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14135         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14136         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14137         (psym_lookup_symbol, psym_find_last_source_symtab)
14138         (psym_forget_cached_source_info, psym_print_stats)
14139         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14140         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14141         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14142         (psym_find_compunit_symtab_by_address)
14143         (maintenance_print_psymbols, maintenance_info_psymtabs)
14144         (maintenance_check_psymtabs): Use ranged for.
14145         * psymtab.h (class objfile_psymtabs): New.
14146         (require_partial_symbols): Return objfile_psymtabs.
14147         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14148
14149 2019-01-09  Tom Tromey  <tom@tromey.com>
14150
14151         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14152         (find_pc_mapped_section, list_overlays_command)
14153         (map_overlay_command, unmap_overlay_command)
14154         (simple_overlay_update): Use all_objfiles.
14155         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14156         * printcmd.c (info_symbol_command): Use all_objfiles.
14157         * objfiles.h (ALL_OBJSECTIONS): Remove.
14158         * maint.c (maintenance_translate_address): Use all_objfiles.
14159         * gcore.c (gcore_create_callback): Use all_objfiles.
14160         (objfile_find_memory_regions): Likewise.
14161
14162 2019-01-09  Tom Tromey  <tom@tromey.com>
14163
14164         * symtab.c (find_line_symtab, info_sources_command)
14165         (make_source_files_completion_list): Use objfile_compunits.
14166         * source.c (select_source_symtab): Use objfile_compunits.
14167         * objfiles.h (struct objfile): Update comment.
14168         (ALL_OBJFILES): Remove.
14169         (ALL_FILETABS): Remove.
14170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14171         objfile_compunits.
14172
14173 2019-01-09  Tom Tromey  <tom@tromey.com>
14174
14175         * symmisc.c (print_objfile_statistics, dump_objfile)
14176         (maintenance_print_symbols): Use compunit_filetabs.
14177         * source.c (forget_cached_source_info_for_objfile): Use
14178         compunit_filetabs.
14179         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14180         (ALL_FILETABS): Use compunit_filetabs.
14181         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14182         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14183
14184 2019-01-09  Tom Tromey  <tom@tromey.com>
14185
14186         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14187         (compunit_filetabs): New.
14188         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14189         compunit_filetabs.
14190         (info_sources_command, make_source_files_completion_list): Remove
14191         declaration.
14192         * symmisc.c (print_objfile_statistics, dump_objfile)
14193         (maintenance_print_symbols): Remove declaration.
14194         (maintenance_info_symtabs): Use compunit_filetabs.
14195         (maintenance_info_line_tables): Likewise.
14196         * source.c (select_source_symtab): Change local variable name.
14197         (forget_cached_source_info_for_objfile): Remove declaration.
14198         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14199         * objfiles.c (objfile_relocate1): Remove declaration.
14200         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14201         declaration.
14202         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14203         * coffread.c (coff_symtab_read): Remove declaration.
14204         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14205         compunit_filetabs.
14206
14207 2019-01-09  Tom Tromey  <tom@tromey.com>
14208
14209         * symtab.c (lookup_objfile_from_block)
14210         (find_pc_sect_compunit_symtab, search_symbols)
14211         (default_collect_symbol_completion_matches_break_on): Use
14212         objfile_compunits.
14213         * objfiles.h (ALL_COMPUNITS): Remove.
14214         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14215         * cp-support.c (add_symbol_overload_list_qualified): Use
14216         objfile_compunits.
14217         * ada-lang.c (ada_collect_symbol_completion_matches)
14218         (ada_add_global_exceptions): Use objfile_compunits.
14219
14220 2019-01-09  Tom Tromey  <tom@tromey.com>
14221
14222         * source.c (select_source_symtab)
14223         (forget_cached_source_info_for_objfile): Remove declaration.
14224         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14225         declaration.
14226         * maint.c (count_symtabs_and_blocks): Remove declaration.
14227         * cp-support.c (add_symbol_overload_list_qualified): Remove
14228         declaration.
14229         * coffread.c (coff_symtab_read): Remove declaration.
14230         * symtab.c (lookup_symbol_in_objfile_symtabs)
14231         (basic_lookup_transparent_type_1): Use objfile_compunits.
14232         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14233         (info_sources_command, search_symbols)
14234         (default_collect_symbol_completion_matches_break_on)
14235         (make_source_files_completion_list): Remove declaration.
14236         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14237         (ada_collect_symbol_completion_matches)
14238         (ada_add_global_exceptions): Remove declaration.
14239         * linespec.c (iterate_over_all_matching_symtabs): Use
14240         objfile_compunits.
14241         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14242         (class objfile_compunits): New.
14243         (ALL_COMPUNITS): Use objfile_compunits.
14244         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14245         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14246         objfile_compunits.
14247         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14248
14249 2019-01-09  Tom Tromey  <tom@tromey.com>
14250
14251         * symtab.c (search_symbols)
14252         (default_collect_symbol_completion_matches_break_on): Use
14253         objfile_msymbols.
14254         * ada-lang.c (ada_lookup_simple_minsym)
14255         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14256         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14257         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14258         objfile_msymbols.
14259         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14260         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14261         * objc-lang.c (find_methods): Use objfile_msymbols.
14262         (info_selectors_command, info_classes_command): Likewise.
14263         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14264         * objfiles.h (class objfile_msymbols): New.
14265         (ALL_OBJFILE_MSYMBOLS): Remove.
14266         (ALL_MSYMBOLS): Remove.
14267
14268 2019-01-09  Tom Tromey  <tom@tromey.com>
14269
14270         * common/next-iterator.h (next_adapter): Add Iterator template
14271         parameter.
14272         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14273         (class all_objfiles_safe): New.
14274         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14275         * objfiles.c (put_objfile_before): Update comment.
14276         (add_separate_debug_objfile): Likewise.
14277         (free_all_objfiles): Use all_objfiles_safe.
14278         (objfile_purge_solibs): Likewise.
14279
14280 2019-01-09  Tom Tromey  <tom@tromey.com>
14281
14282         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14283         (expand_symtab_containing_pc, lookup_static_symbol)
14284         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14285         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14286         all_objfiles.
14287         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14288         * breakpoint.c (create_overlay_event_breakpoint)
14289         (create_longjmp_master_breakpoint)
14290         (create_std_terminate_master_breakpoint)
14291         (create_exception_master_breakpoint): Use all_objfiles.
14292         * linux-thread-db.c (try_thread_db_load_from_pdir)
14293         (has_libpthread): Use all_objfiles.
14294         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14295         * linespec.c (iterate_over_all_matching_symtabs)
14296         (search_minsyms_for_name): Use all_objfiles.
14297         * maint.c (maintenance_info_sections): Use all_objfiles.
14298         * main.c (captured_main_1): Use all_objfiles.
14299         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14300         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14301         * guile/scm-pretty-print.c
14302         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14303         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14304         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14305         (maintenance_print_msymbols): Use all_objfiles.
14306         * source.c (select_source_symtab): Use all_objfiles.
14307         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14308         * symfile.c (remove_symbol_file_command)
14309         (expand_symtabs_matching, map_symbol_filenames): Use
14310         all_objfiles.
14311         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14312         all_objfiles.
14313         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14314         * objc-lang.c (find_methods): Use all_objfiles.
14315         * objfiles.c (have_partial_symbols, have_full_symbols)
14316         (have_minimal_symbols, qsort_cmp)
14317         (default_iterate_over_objfiles_in_search_order): Use
14318         all_objfiles.
14319         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14320         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14321         (maintenance_check_psymtabs): Use all_objfiles.
14322         (ALL_PSYMTABS): Remove.
14323         * compile/compile-object-run.c (do_module_cleanup): Use
14324         all_objfiles.
14325         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14326         * cp-support.c (add_symbol_overload_list_qualified): Use
14327         all_objfiles.
14328         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14329         Use all_objfiles.
14330         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14331         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14332         all_objfiles.
14333         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14334         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14335         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14336         Uses all_objfiles.
14337         * solib.c (solib_read_symbols): Use all_objfiles
14338
14339 2019-01-09  Tom Tromey  <tom@tromey.com>
14340
14341         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14342         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14343         all_objfiles.
14344         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14345         * symmisc.c (print_symbol_bcache_statistics)
14346         (print_objfile_statistics, maintenance_print_objfiles)
14347         (maintenance_info_symtabs, maintenance_check_symtabs)
14348         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14349         all_objfiles.
14350         * source.c (forget_cached_source_info): Use all_objfiles.
14351         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14352         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14353         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14354         * objfiles.c (update_section_map): Use all_objfiles.
14355         (shared_objfile_contains_address_p): Likewise.
14356         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14357         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14358
14359 2019-01-09  Tom Tromey  <tom@tromey.com>
14360
14361         * common/next-iterator.h: New file.
14362         * objfiles.h (class all_objfiles): New.
14363         (struct objfile_iterator): New.
14364
14365 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14366
14367         * NEWS: Move the description of the changed "frame", "select-frame",
14368          and "info frame" commands to the Changed commands section.
14369
14370 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14371
14372         * gdbtypes.c (check_stub_method_group): Remove handling of old
14373         mangling schemes.
14374         * linespec.c (find_methods): Likewise.
14375         * stabsread.c (read_member_functions): Likewise.
14376         * valops.c (search_struct_method): Likewise.
14377         (value_struct_elt_for_reference): Likewise.
14378         * NEWS: Mention this change.
14379
14380 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14381
14382         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14383         print_source_lines.
14384         * source.c (print_source_lines_base): Update line number check.
14385         (print_source_lines): New function.
14386         (source_lines_range::source_lines_range): New function.
14387         * source.h (class source_lines_range): New class.
14388         (print_source_lines): New declaration.
14389
14390 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14391
14392         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14393
14394 2019-01-08  Tom Tromey  <tom@tromey.com>
14395             Simon Marchi  <simon.marchi@ericsson.com>
14396
14397         PR gdb/24060
14398         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14399         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14400         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14401         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14402         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14403         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14404
14405 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14406
14407         * source.c (select_source_symtab): Move header comment to
14408         declaration in source.h.
14409         (forget_cached_source_info_for_objfile): Likewise.
14410         (forget_cached_source_info): Likewise.
14411         (identify_source_line): Likewise.
14412         * source.h (identify_source_line): Move declaration from symtab.h
14413         and add comment from source.c
14414         (print_source_lines): Likewise.
14415         (forget_cached_source_info_for_objfile): Likewise.
14416         (forget_cached_source_info): Likewise.
14417         (select_source_symtab): Likewise.
14418         (enum print_source_lines_flag): Move definition from symtab.h.
14419         * symtab.h (identify_source_line): Move declaration to source.h.
14420         (print_source_lines): Likewise.
14421         (forget_cached_source_info_for_objfile): Likewise.
14422         (forget_cached_source_info): Likewise.
14423         (select_source_symtab): Likewise.
14424         (enum print_source_lines_flag): Move definition to source.h.
14425         * tui/tui-hooks.c: Add 'source.h' include.
14426
14427 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14428
14429         * source.c (print_source_lines_base): Handle requests to print
14430         reverse line number sequences, and guard against empty lines
14431         string.
14432
14433 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14434
14435         * source.c (print_source_lines_base): Fix skip of '\r' if next
14436         character is '\n'.
14437
14438 2019-01-06  Tom Tromey  <tom@tromey.com>
14439
14440         * c-exp.y (struct c_parse_state) <macro_original_text,
14441         expansion_obstack>: New member.
14442         (macro_original_text, expansion_obstack): Remove globals.
14443         (scan_macro_expansion, scanning_macro_expansion)
14444         (finished_macro_expansion): Update.
14445         (scan_macro_cleanup): Remove.
14446         (yylex, c_parse): Update.
14447
14448 2019-01-06  Tom Tromey  <tom@tromey.com>
14449
14450         * c-exp.y (struct c_parse_state) <strings>: New member.
14451         (operator_stoken): Update.
14452
14453 2019-01-06  Tom Tromey  <tom@tromey.com>
14454
14455         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14456         (union type_stack_elt) <typelist_val>: Now a pointer to
14457         std::vector.
14458         (type_stack_cleanup): Don't declare.
14459         (push_typelist): Update.
14460         * parse.c (pop_typelist): Return a std::vector.
14461         (push_typelist): Take a std::vector.
14462         (follow_types): Update.  Do not free args.
14463         (type_stack_cleanup): Remove.
14464         * c-exp.y (struct c_parse_state): New.
14465         (cpstate): New global.
14466         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14467         (nonempty_typelist): Update.
14468         (func_mod): Create a new vector.
14469         (c_parse): Create a c_parse_state.
14470         (check_parameter_typelist): Do not delete params.
14471         (function_method): Update.  Do not delete type_list.
14472
14473 2019-01-06  Tom Tromey  <tom@tromey.com>
14474
14475         PR gdb/28155:
14476         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14477         check_typedef.
14478         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14479         (print_return_value): Likewise.
14480
14481 2019-01-05  Tom Tromey  <tom@tromey.com>
14482
14483         * contrib/cleanup_check.py: Remove.
14484         * contrib/gcc-with-excheck: Remove.
14485         * contrib/exsummary.py: Remove.
14486         * contrib/excheck.py: Remove.
14487
14488 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14489
14490         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14491         NULL. Initialize tpprev to NULL instead of assigning it
14492         to NULL on the next statement.
14493         * windows-nat.c (windows_delete_thread): Remove check for
14494         main_thread_id before printing thread exit notifications.
14495         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14496         Remove thread ID check against main_thread_id.
14497         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14498         windows_delete_thread.
14499         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14500
14501 2019-01-04  Tom Tromey  <tom@tromey.com>
14502
14503         * compile/compile.c (_initialize_compile): Use upper case for
14504         metasyntactic variables.
14505         * symmisc.c (_initialize_symmisc): Use upper case for
14506         metasyntactic variables.
14507         * psymtab.c (_initialize_psymtab): Use upper case for
14508         metasyntactic variables.
14509         * demangle.c (demangle_command): Use upper case for metasyntactic
14510         variables.
14511         (_initialize_demangler): Likewise.
14512         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14513         variables.
14514
14515 2019-01-03  Tom Tromey  <tom@tromey.com>
14516
14517         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14518
14519 2019-01-03  Tom Tromey  <tom@tromey.com>
14520
14521         * python/py-symtab.c (salpy_str): Update.
14522         (struct salpy_sal_object) <symtab>: Now a PyObject.
14523         (salpy_dealloc): Update.
14524         (del_objfile_sal): Use gdbpy_ref.
14525
14526 2019-01-03  Tom Tromey  <tom@tromey.com>
14527
14528         * python/py-type.c (convert_field): Use new_reference.  Return
14529         gdbpy_ref.
14530         (make_fielditem): Return gdbpy_ref.
14531         (typy_fields): Update.
14532         (typy_getitem): Update.
14533         (field_name): Return gdbpy_ref.  Use new_reference.
14534         (typy_iterator_iternext): Update.
14535
14536 2019-01-03  Tom Tromey  <tom@tromey.com>
14537
14538         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14539
14540 2019-01-03  Tom Tromey  <tom@tromey.com>
14541
14542         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14543         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14544         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14545         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14546         (pspy_set_type_printers): Likewise.
14547         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14548         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14549         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14550         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14551         (objfpy_set_type_printers): Likewise.
14552
14553 2019-01-03  Tom Tromey  <tom@tromey.com>
14554
14555         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14556         (gdbpy_print_stack): Use gdbpy_err_fetch.
14557         * python/python-internal.h (class gdbpy_err_fetch): New class.
14558         (class gdbpy_enter) <m_error_type, m_error_value,
14559         m_error_traceback>: Remove.
14560         <m_error>: New member.
14561         (gdbpy_exception_to_string): Don't declare.
14562         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14563         * python/py-value.c (convert_value_from_python): Use
14564         gdbpy_err_fetch.
14565         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14566         gdbpy_exception_to_string.
14567         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14568         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14569         gdbpy_err_fetch.
14570
14571 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14572
14573         * linux-nat.c (delete_lwp_cleanup): Delete.
14574         (struct lwp_deleter): New struct.
14575         (lwp_info_up): New typedef.
14576         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14577         lwp_info_up.
14578
14579 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14580
14581         * linux-fork.c (class scoped_switch_fork_info): New class.
14582         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14583
14584 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14585
14586         * valops.c (find_overload_match): Remove use of null_cleanup, and
14587         calls to do_cleanups.
14588
14589 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14590
14591         * compile/compile-cplus-types.c
14592         (compile_cplus_instance::decl_name): Handle changes to
14593         cp_func_name.
14594         * cp-support.c (cp_func_name): Update header comment, update
14595         return type.
14596         * cp-support.h (cp_func_name): Update return type in declaration.
14597         * valops.c (find_overload_match): Move temp_func local to top
14598         level of function and change its type.  Use temp_func to hold and
14599         delete temporary string obtained from cp_func_name.
14600
14601 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14602
14603         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14604         gdb::char_vector, remove cleanup, and update uses of `msg`.
14605
14606 2019-01-03  Jim Wilson  <jimw@sifive.com>
14607
14608         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14609
14610 2019-01-02  Tom Tromey  <tom@tromey.com>
14611
14612         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14613         (tdesc_parse_xml): Remove cleanups.
14614         * target-descriptions.h (make_cleanup_free_target_description):
14615         Don't declare.
14616         (target_desc_deleter): New struct.
14617         (target_desc_up): New typedef.
14618         * target-descriptions.c (target_desc_deleter::operator()): Rename
14619         from free_target_description.
14620         (make_cleanup_free_target_description): Remove.
14621
14622 2019-01-02  Tom Tromey  <tom@tromey.com>
14623
14624         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14625         constructor, destructor.
14626         (linespec_parser): Remove typedef.
14627         (~linespec_parser): Rename from linespec_parser_delete.
14628         (linespec_lex_to_end, linespec_complete_label)
14629         (linespec_complete): Update.
14630         (decode_line_full): Remove cleanups.
14631         (decode_line_1): Update.
14632
14633 2019-01-02  Tom Tromey  <tom@tromey.com>
14634
14635         * python/python-internal.h (inferior_to_inferior_object): Change
14636         return type.
14637         * python/py-exitedevent.c (create_exited_event_object): Update.
14638         * python/py-inferior.c (inferior_to_inferior_object): Return
14639         gdbpy_ref.
14640         (python_new_inferior, python_inferior_deleted)
14641         (thread_to_thread_object, delete_thread_object)
14642         (build_inferior_list, gdbpy_selected_inferior): Update.
14643         * python/py-infthread.c (create_thread_object): Update.  Also fail
14644         if inferior_to_inferior_object fails.
14645
14646 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14647
14648         * inferior.h (class inferior) <displaced_step_state>: New field.
14649         * infrun.h (struct displaced_step_state): Move here from
14650         infrun.c.  Initialize fields, add constructor.
14651         <inf>: Remove field.
14652         <reset>: New method.
14653         * infrun.c (struct displaced_step_inferior_state): Move to
14654         infrun.h.
14655         (displaced_step_inferior_states): Remove.
14656         (get_displaced_stepping_state): Adust.
14657         (displaced_step_in_progress_any_inferior): Adjust.
14658         (displaced_step_in_progress_thread): Adjust.
14659         (displaced_step_in_progress): Adjust.
14660         (add_displaced_stepping_state): Remove.
14661         (get_displaced_step_closure_by_addr): Adjust.
14662         (remove_displaced_stepping_state): Remove.
14663         (infrun_inferior_exit): Call displaced_step_state.reset.
14664         (use_displaced_stepping): Don't check for NULL.
14665         (displaced_step_prepare_throw): Call
14666         get_displaced_stepping_state.
14667         (displaced_step_fixup): Don't check for NULL.
14668         (prepare_for_detach): Don't check for NULL.
14669
14670 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14671
14672         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14673          in case of call that did not complete.
14674
14675 2019-01-02  Andrey Utkin  <autkin@undo.io>
14676
14677         * symfile.c (find_separate_debug_file): Fix search of debug files for
14678         remote debuggee.
14679
14680 2019-01-02  Tom Tromey  <tom@tromey.com>
14681
14682         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14683         indentation.
14684         * python/py-frame.c (frapy_older): Remove cast.
14685         (frapy_newer): Likewise.
14686         * python/py-breakpoint.c (local_setattro): Remove cast.
14687         * python/py-arch.c (archpy_name): Remove local variable.
14688         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14689
14690 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14691
14692         * unittests/basic_string_view/element_access/char/empty.cc:
14693         Fix year range in copyright header.
14694
14695 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14696
14697         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14698         Delete.
14699         <operator==>: Update with for removed field.
14700         <hash>: Likewise.
14701         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14702         <isa_features>: ...this.
14703         <abi_features>: New field.
14704         (riscv_isa_flen): Update comment.
14705         (riscv_abi_xlen): New declaration.
14706         (riscv_abi_flen): New declaration.
14707         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14708         isa_features.
14709         (riscv_abi_xlen): New function.
14710         (riscv_isa_flen): Update to get answer from isa_features.
14711         (riscv_abi_flen): New function.
14712         (riscv_has_fp_abi): Update to get answer from abi_features.
14713         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14714         xlen and flen.
14715         (riscv_call_info) <xlen, flen>: Update comment.
14716         (riscv_call_arg_struct): Remove invalid assertions
14717         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14718         is removed.
14719         (riscv_gdbarch_init): Gather isa features and abi features
14720         separately, ensure both match on the gdbarch when reusing an old
14721         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14722         a target with 64-bit float hardware.
14723
14724 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14725
14726         * source.c (search_command_helper): Stop reverse search
14727         when line 1 has been searched.
14728
14729 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14730
14731         * record-full.c (record_full_base_target::close): Rewrite
14732         record_full_core_buf_list free logic.
14733
14734 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14735
14736         * break-catch-syscall.c (print_one_catch_syscall): xfree
14737         the last text.
14738
14739 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14740
14741         * top.c (print_gdb_version): Update Copyright year in version
14742         message.
14743
14744 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14745
14746         Update copyright year range in all GDB files.
14747
14748 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14749
14750         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14751
14752 For older changes see ChangeLog-2018.
14753 \f
14754 Local Variables:
14755 mode: change-log
14756 left-margin: 8
14757 fill-column: 74
14758 version-control: never
14759 coding: utf-8
14760 End:
14761