gdb/ChangeLog

   1 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * agent.c (set_can_use_agent): When the setting is turned on,
   4         look up agent symbols if we don't have them yet.
   5         (agent_new_objfile): Don't look up agent symbols when the agent
   6         setting is off.
   7
   8 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * config.in: Regenerate.
  11
  12 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * configure: Regenerate.
  15         * configure.ac: Check for strerror_r.
  16         * gdbsupport/common-utils.h (safe_strerror): Change return value
  17         to const char * and document that this function is now threadsafe.
  18         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  19         thread_local and call strerror_r, if available.
  20         * utils.c (perror_string): Update.
  21         (print_sys_errmsg): Update.
  22
  23 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  24
  25         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  26         objfile_key.
  27         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  28         objfile to fetch per-bfd data.
  29         (arm_find_exidx_entry): Likewise.
  30
  31 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * gdbsupport/agent.c (debug_agent): Change type to bool.
  34         (use_agent): Likewise.
  35         (all_agent_symbols_look_up): Likewise.
  36         (agent_loaded_p): Change return value to bool.
  37         (agent_look_up_symbols): Update.
  38         (agent_capability_check): Change return value to bool.
  39         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  40         (debug_agent): Change type to bool.
  41         (use_agent): Likewise.
  42         (agent_capability_check): Change return value to bool.
  43
  44 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  45
  46         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  47         (build_minimal_symbol_hash_tables): Code to clear the table moved
  48         to clear_minimal_symbol_hash_tables.
  49         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
  50         when needed.
  51
  52 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  53
  54         * infcmd.c: Remove includes.
  55         * infrun.c: Remove includes.
  56
  57 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  58
  59         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
  60         (grow_vect): Remove declaration.
  61         (ada_type_of_array): Remove declaration.
  62         (ada_update_initial_language): Remove declaration.
  63         (ada_fold_name): Remove declaration.
  64         (ada_fill_in_ada_prototype): Remove declaration.
  65         (user_select_syms): Remove declaration.
  66         (get_selections): Remove declaration.
  67         (ada_tag_type): Remove declaration.
  68         (ada_value_tag): Remove declaration.
  69         (ada_is_others_clause): Remove declaration.
  70         (ada_in_variant): Remove declaration.
  71         (ada_value_struct_elt): Remove declaration.
  72         (ada_attribute_name): Remove declaration.
  73         (ada_system_address_type): Remove declaration.
  74         * ada-lang.c (ada_watch_location_expression): Make static.
  75         (GROW_VECT): Move here from ada-lang.h.
  76         (grow_vect): Make static.
  77         (ada_update_initial_language): Make static.
  78         (ada_fold_name): Make static.
  79         (ada_type_of_array): Make static.
  80         (encoded_ordered_before): Move up.
  81         (sort_choices): Move up.
  82         (print_signatures): Move up.
  83         (ada_print_symbol_signature): Move up.
  84         (get_selections): Move up and make static.
  85         (user_select_syms): Move up and make static.
  86         (ada_value_struct_elt): Move up and make static.
  87         (ada_tag_type): Make static.
  88         (ada_value_tag): Make static.
  89         (ada_is_others_clause): Make static.
  90         (ada_in_variant): Make static.
  91         (ada_attribute_name): Make static.
  92
  93 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * ada-lang.c: Remove includes.
  96         * ada-typeprint.c: Remove includes.
  97         * ada-valprint.c: Remove includes.
  98
  99 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 100
 101         * addrmap.c: Add static assertions of type size, moved from
 102         _initialize_addrmap.
 103         (_initialize_addrmap): Remove.
 104
 105 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 106
 107         * coffread.c (record_minimal_symbol): Update.
 108         (process_coff_symbol): Update.
 109         * dbxread.c (read_dbx_symtab): Update.
 110         * dwarf2read.c (add_partial_symbol): Update.
 111         (fixup_go_packaging): Update.
 112         (load_partial_dies): Update.
 113         (new_symbol): Update.
 114         * elfread.c (record_minimal_symbol): Change signature to use
 115         gdb::string_view instead of name+len.
 116         (elf_symtab_read): Update.
 117         (elf_rel_plt_read): Update.
 118         * mdebugread.c (parse_partial_symbols): Update.
 119         (handle_psymbol_enumerators): Update.
 120         (new_symbol): Update.
 121         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 122         to use gdb::string_view instead of name+len.
 123         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 124         * psympriv.h (add_psymbol_to_list): Likewise.
 125         * psymtab.c (add_psymbol_to_bcache): Likewise.
 126         (add_psymbol_to_list): Likewise.
 127         * stabsread.c (define_symbol): Update.
 128         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 129         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 130         (symbol_set_names): Likewise.
 131         * xcoffread.c (scan_xcoff_symtab): Update.
 132
 133 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * symtab.h (symbol_set_names): Document that copy_name must be
 136         set to true for non-nullterminated strings.
 137         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 138         linkage_name if the entry was not found and we need to demangle.
 139
 140 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 143         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 144         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 145         * gdbsupport/gdb_binary_search.h: New file.
 146
 147 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 148
 149         * NEWS: Mention new --with-system-gdbinit-dir option.
 150         * config.in: Regenerate.
 151         * configure: Regenerate.
 152         * configure.ac: Add new option --with-system-gdbinit-dir.
 153         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 154         for a ".gdb" suffix.
 155         * main.c (get_init_files): Change system_gdbinit argument to
 156         a vector and return the files in SYSTEM_GDBINIT_DIR in
 157         addition to SYSTEM_GDBINIT.
 158         (captured_main_1): Update.
 159         (print_gdb_help): Update.
 160         * top.c (print_gdb_configuration): Also print the value of
 161         SYSTEM_GDBINIT_DIR.
 162
 163 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 164
 165         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 166         that takes gdb::string_view arguments.
 167
 168 2019-10-26  Tom de Vries  <tdevries@suse.de>
 169
 170         * aarch64-linux-tdep.c: Fix typos in comments.
 171         * aarch64-tdep.c: Same.
 172         * ada-lang.c: Same.
 173         * amd64-nat.c: Same.
 174         * arc-tdep.c: Same.
 175         * arch/aarch64-insn.c: Same.
 176         * block.c: Same.
 177         * breakpoint.h: Same.
 178         * btrace.h: Same.
 179         * c-varobj.c: Same.
 180         * cli/cli-decode.c: Same.
 181         * cli/cli-script.c: Same.
 182         * cli/cli-utils.h: Same.
 183         * coff-pe-read.c: Same.
 184         * coffread.c: Same.
 185         * compile/compile-cplus-symbols.c: Same.
 186         * compile/compile-object-run.c: Same.
 187         * completer.c: Same.
 188         * corelow.c: Same.
 189         * cp-support.c: Same.
 190         * demangle.c: Same.
 191         * dwarf-index-write.c: Same.
 192         * dwarf2-frame.c: Same.
 193         * dwarf2-frame.h: Same.
 194         * eval.c: Same.
 195         * frame-base.h: Same.
 196         * frame.h: Same.
 197         * gdbcmd.h: Same.
 198         * gdbtypes.h: Same.
 199         * gnu-nat.c: Same.
 200         * guile/scm-objfile.c: Same.
 201         * i386-tdep.c: Same.
 202         * i386-tdep.h: Same.
 203         * infcall.c: Same.
 204         * infcall.h: Same.
 205         * linux-nat.c: Same.
 206         * m68k-tdep.c: Same.
 207         * macroexp.c: Same.
 208         * memattr.c: Same.
 209         * mi/mi-cmd-disas.c: Same.
 210         * mi/mi-getopt.h: Same.
 211         * mi/mi-main.c: Same.
 212         * minsyms.c: Same.
 213         * nat/aarch64-sve-linux-sigcontext.h: Same.
 214         * objfiles.h: Same.
 215         * ppc-linux-nat.c: Same.
 216         * ppc-linux-tdep.c: Same.
 217         * ppc-tdep.h: Same.
 218         * progspace.h: Same.
 219         * prologue-value.h: Same.
 220         * python/py-evtregistry.c: Same.
 221         * python/py-instruction.h: Same.
 222         * record-btrace.c: Same.
 223         * record-full.c: Same.
 224         * remote.c: Same.
 225         * rs6000-tdep.c: Same.
 226         * ser-tcp.c: Same.
 227         * sol-thread.c: Same.
 228         * sparc-sol2-tdep.c: Same.
 229         * sparc64-tdep.c: Same.
 230         * stabsread.c: Same.
 231         * symfile.c: Same.
 232         * symtab.h: Same.
 233         * target.c: Same.
 234         * tracepoint.c: Same.
 235         * tui/tui-data.h: Same.
 236         * tui/tui-io.c: Same.
 237         * tui/tui-win.c: Same.
 238         * tui/tui.c: Same.
 239         * unittests/rsp-low-selftests.c: Same.
 240         * user-regs.h: Same.
 241         * utils.c: Same.
 242         * utils.h: Same.
 243         * valarith.c: Same.
 244         * valops.c: Same.
 245         * valprint.c: Same.
 246         * valprint.h: Same.
 247         * value.c: Same.
 248         * value.h: Same.
 249         * varobj.c: Same.
 250         * x86-nat.h: Same.
 251         * xtensa-tdep.c: Same.
 252
 253 2019-10-25  Ali Tamur <tamur@google.com>
 254
 255         * charset.c (find_charset_names): Reflect API change.
 256
 257 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 258
 259         * symtab.c (struct demangled_name_entry): Change demangled name
 260         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 261         part of the struct anymore.
 262         (symbol_set_names): No longer obstack allocate + copy the demangled
 263         name, just store the allocated name from bfd.
 264
 265 2019-10-25  Tom Tromey  <tromey@adacore.com>
 266
 267         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 268         (bsearch_cie_cmp, add_cie): Remove.
 269         (find_cie): Reimplement.
 270         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 271         (dwarf2_build_frame_info): Update.
 272
 273 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 274
 275         PR gdb/25126
 276         * symfile.c (reread_symbols): Call forget_cached_source_info to
 277         clear the stale source cache.
 278
 279 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 280
 281         * configure: Regenerate.
 282         * configure.ac: Remove code that sets python_has_threads.
 283
 284 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 285
 286         * config.in: Regenerate.
 287         * configure: Regenerate.
 288         * configure.ac: Remove the code that uses sed to get the python
 289         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 290
 291 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 292
 293         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 294         error paths.
 295
 296 2019-10-23  Tom Tromey  <tom@tromey.com>
 297
 298         * arc-tdep.c: Remove ".." from include.
 299         * frv-tdep.c: Remove ".." from include.
 300         * lm32-tdep.c: Remove ".." from include.
 301         * microblaze-tdep.c: Remove ".." from include.
 302         * or1k-tdep.h: Remove ".." from include.
 303         * s12z-tdep.c: Remove ".." from include.
 304         * Makefile.in (OPCODES_CFLAGS): Add comment.
 305         (TOP_CFLAGS): New variable.
 306         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 307
 308 2019-10-23  Tom Tromey  <tom@tromey.com>
 309
 310         * Makefile.in (READLINE_DIR): Update.
 311
 312 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 313
 314         * infcall.c (call_function_by_hand_dummy): Fix the function
 315         comment.  And extract out a code section into...
 316         (reserve_stack_space): ...this new function.
 317
 318 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 319
 320         * infcall.c (value_arg_coerce): Remove an unused parameter.
 321         (call_function_by_hand_dummy): Update the call to
 322         'value_arg_coerce'.
 323
 324 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 325
 326         * infcall.c (call_function_by_hand_dummy): Refactor.
 327
 328 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 329
 330         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 331
 332 2019-10-23  Tom Tromey  <tom@tromey.com>
 333
 334         * configure: Rebuild.
 335         * configure.ac: Don't check for sigprocmask.
 336         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 337
 338 2019-10-23  Tom Tromey  <tom@tromey.com>
 339
 340         * configure: Rebuild.
 341         * acinclude.m4: Use m4_include, not sinclude.
 342
 343 2019-10-23  Tom de Vries  <tdevries@suse.de>
 344
 345         PR breakpoints/24687
 346         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 347
 348 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 349
 350         * symtab.c (struct demangled_name_entry) <language>: Change from
 351         bitfield to regular variable.
 352
 353 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 354
 355         * symtab.c (struct demangled_name_entry): Add a constructor.
 356         (free_demangled_name_entry): New function to call the destructor
 357         for demangled_name_entry.
 358         (create_demangled_names_hash): Pass free_demangled_name_entry to
 359         htab_create_alloc.
 360         (symbol_set_names): Call placement new for demangled_name_entry.
 361         * utils.c: No longer include xxhash.h here, now that fast_hash
 362         is inlined in the header.
 363         * utils.h: Instead, include it here.
 364
 365 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * Makefile.in: Link with libxxhash.
 368         * config.in: Regenerate.
 369         * configure: Regenerate.
 370         * configure.ac: Search for libxxhash.
 371         * utils.c (fast_hash): Use xxhash if present.
 372
 373 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 374
 375         * utils.h (fast_hash): New function.
 376         * symtab.c (hash_demangled_name_entry): Call new function
 377         fast_hash.
 378
 379 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 380
 381         * symtab.c (struct demangled_name_entry): Change type of mangled
 382         to gdb::string_view. Also adds a constructor that takes the
 383         mangled name.
 384         (hash_demangled_name_entry): Update.
 385         (eq_demangled_name_entry): Update.
 386         (free_demangled_name_entry): New function to call the destructor
 387         now that this is not a POD anymore.
 388         (create_demangled_names_hash): Pass free_demangled_name_entry to
 389         htab_create_alloc.
 390         (symbol_set_names): Update.
 391
 392 2019-10-21  Ali Tamur  <tamu@google.com>
 393
 394         * dwarf2read.c (dir_index): Change type.
 395         (file_name_index): Likewise.
 396         (line_header::include_dir_at): Change comment and implementation on
 397         whether it is DWARF 5.
 398         (line_header::is_valid_file_index): New function.
 399         (line_header::file_name_at): Change comment and implementation on
 400         whether it is DWARF 5.
 401         (line_header::file_names): Change to private field renamed as
 402         m_file_names and introduce a new accessor method.
 403         (line_header::file_names_size): New method.
 404         (line_header::include_dirs): Change to private field and rename as
 405         m_include_dirs.
 406         (dw2_get_file_names_reader): Define local var at a smaller scope and
 407         reflect API change.
 408         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 409         (process_structure_scope): Likewise.
 410         (line_header::add_include_dir): Change message and reflect renaming.
 411         (line_header::add_file_name): Likewise.
 412         (read_formatted_entries): Handle DW_FORM_data16.
 413         (dwarf_decode_line_header): Fix line header length calculation.
 414         (psymtab_include_file_name): Change comment and API.
 415         (lnp_state_machine::m_file): Update comment and reflect type change.
 416         (lnp_state_machine::record_line): Reflect type change.
 417         (dwarf_decode_lines): Reflect API change.
 418         (file_file_name): Likewise.
 419         (file_full_name): Likewise.
 420
 421 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 422
 423         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 424
 425 2019-10-21  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 428
 429 2019-10-21  Tom Tromey  <tom@tromey.com>
 430
 431         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 432         NM_H.   Use AC_CONFIG_LINKS.
 433         * configure: Rebuild.
 434         * Makefile.in (NM_H): New variable.
 435         (generated_files): Add NM_H.  Remove gcore.
 436         (nm.h, stamp-nmh): New targets.
 437
 438 2019-10-20  Tom Tromey  <tom@tromey.com>
 439
 440         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 441         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 442         obsolete comment.
 443         (put_objfile_before): Now static.
 444
 445 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 446
 447         * gdbsupport/common-utils.h (startswith): Change return type to
 448         bool.
 449
 450 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 451
 452         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 453         * breakpoint.c (bp_locations_compare): Rename to...
 454         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 455         (update_global_location_list): Use std::sort instead of qsort.
 456         * buildsym.c (compare_line_numbers): Rename to...
 457         (lte_is_less_than): ...this, and change to std::sort semantics.
 458         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 459         instead of qsort.
 460         * disasm.c (compare_lines): Rename to...
 461         (line_is_less_than): ...this, and change to std::sort semantics.
 462         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 463         of qsort.
 464         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 465         (fde_is_less_than): ...this, and change to std::sort semantics.
 466         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 467         * mdebugread.c (compare_blocks):
 468         (block_is_less_than): ...this, and change to std::sort semantics.
 469         (sort_blocks): Call std::sort instead of qsort.
 470         * objfiles.c (qsort_cmp): Rename to...
 471         (sort_cmp): ...this, and change to std::sort semantics.
 472         (update_section_map): Call std::sort instead of qsort.
 473         * remote.c (compare_pnums): Remove.
 474         (map_regcache_remote_table): Call std::sort instead of qsort.
 475         * utils.c (compare_positive_ints): Remove.
 476         * utils.h (compare_positive_ints): Remove.
 477         * xcoffread.c (compare_lte): Remove.
 478         (arrange_linetable): Call std::sort instead of qsort.
 479
 480 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 481
 482         * symfile.c (init_entry_point_info): Fix typo.
 483         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 484
 485 2019-10-18  Tom de Vries  <tdevries@suse.de>
 486
 487         * aarch64-tdep.c: Fix typos in comments.
 488         * ada-lang.c: Same.
 489         * ada-tasks.c: Same.
 490         * alpha-tdep.c: Same.
 491         * alpha-tdep.h: Same.
 492         * amd64-nat.c: Same.
 493         * amd64-windows-tdep.c: Same.
 494         * arc-tdep.c: Same.
 495         * arc-tdep.h: Same.
 496         * arch-utils.c: Same.
 497         * arm-nbsd-tdep.c: Same.
 498         * arm-tdep.c: Same.
 499         * ax-gdb.c: Same.
 500         * blockframe.c: Same.
 501         * btrace.c: Same.
 502         * c-varobj.c: Same.
 503         * coff-pe-read.c: Same.
 504         * coffread.c: Same.
 505         * cris-tdep.c: Same.
 506         * darwin-nat.c: Same.
 507         * dbxread.c: Same.
 508         * dcache.c: Same.
 509         * disasm.c: Same.
 510         * dtrace-probe.c: Same.
 511         * dwarf-index-write.c: Same.
 512         * dwarf2-frame-tailcall.c: Same.
 513         * dwarf2-frame.c: Same.
 514         * dwarf2read.c: Same.
 515         * eval.c: Same.
 516         * exceptions.c: Same.
 517         * fbsd-tdep.c: Same.
 518         * findvar.c: Same.
 519         * frame.c: Same.
 520         * frv-tdep.c: Same.
 521         * gnu-v3-abi.c: Same.
 522         * go32-nat.c: Same.
 523         * h8300-tdep.c: Same.
 524         * hppa-tdep.c: Same.
 525         * i386-linux-tdep.c: Same.
 526         * i386-tdep.c: Same.
 527         * ia64-libunwind-tdep.c: Same.
 528         * ia64-tdep.c: Same.
 529         * infcmd.c: Same.
 530         * infrun.c: Same.
 531         * linespec.c: Same.
 532         * linux-nat.c: Same.
 533         * linux-thread-db.c: Same.
 534         * machoread.c: Same.
 535         * mdebugread.c: Same.
 536         * mep-tdep.c: Same.
 537         * mn10300-tdep.c: Same.
 538         * namespace.c: Same.
 539         * objfiles.c: Same.
 540         * opencl-lang.c: Same.
 541         * or1k-tdep.c: Same.
 542         * osabi.c: Same.
 543         * ppc-linux-nat.c: Same.
 544         * ppc-linux-tdep.c: Same.
 545         * ppc-sysv-tdep.c: Same.
 546         * printcmd.c: Same.
 547         * procfs.c: Same.
 548         * record-btrace.c: Same.
 549         * record-full.c: Same.
 550         * remote-fileio.c: Same.
 551         * remote.c: Same.
 552         * rs6000-tdep.c: Same.
 553         * s12z-tdep.c: Same.
 554         * score-tdep.c: Same.
 555         * ser-base.c: Same.
 556         * ser-go32.c: Same.
 557         * skip.c: Same.
 558         * sol-thread.c: Same.
 559         * solib-svr4.c: Same.
 560         * solib.c: Same.
 561         * source.c: Same.
 562         * sparc-nat.c: Same.
 563         * sparc-sol2-tdep.c: Same.
 564         * sparc-tdep.c: Same.
 565         * sparc64-tdep.c: Same.
 566         * stabsread.c: Same.
 567         * stack.c: Same.
 568         * symfile.c: Same.
 569         * symtab.c: Same.
 570         * target-descriptions.c: Same.
 571         * target-float.c: Same.
 572         * thread.c: Same.
 573         * utils.c: Same.
 574         * valops.c: Same.
 575         * valprint.c: Same.
 576         * value.c: Same.
 577         * varobj.c: Same.
 578         * windows-nat.c: Same.
 579         * xcoffread.c: Same.
 580         * xstormy16-tdep.c: Same.
 581         * xtensa-tdep.c: Same.
 582
 583 2019-10-17  Tom Tromey  <tromey@adacore.com>
 584
 585         * configure: Rebuild.
 586         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 587         in AC_CONFIG_FILES invocation.
 588         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 589         new-style config.status invocation.
 590
 591 2019-10-17  Tom de Vries  <tdevries@suse.de>
 592
 593         * arm-nbsd-nat.c: Fix typos in comments.
 594         * arm-tdep.c: Same.
 595         * darwin-nat-info.c: Same.
 596         * dwarf2read.c: Same.
 597         * elfread.c: Same.
 598         * event-top.c: Same.
 599         * findvar.c: Same.
 600         * gdbtypes.c: Same.
 601         * hppa-tdep.c: Same.
 602         * i386-tdep.c: Same.
 603         * jit.c: Same.
 604         * main.c: Same.
 605         * mdebugread.c: Same.
 606         * moxie-tdep.c: Same.
 607         * nto-procfs.c: Same.
 608         * osabi.c: Same.
 609         * ppc-linux-tdep.c: Same.
 610         * remote.c: Same.
 611         * riscv-tdep.c: Same.
 612         * s390-tdep.c: Same.
 613         * sh-tdep.c: Same.
 614         * sparc-linux-tdep.c: Same.
 615         * sparc-nat.c: Same.
 616         * stack.c: Same.
 617         * target-descriptions.c: Same.
 618         * top.c: Same.
 619         * varobj.c: Same.
 620
 621 2019-10-16  Tom Tromey  <tom@tromey.com>
 622
 623         * objfiles.h (struct objfile) <original_name>: Now const.
 624
 625 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 626
 627         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 628         pass on to sigsetjmp's second argument.
 629         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 630
 631 2019-10-16  Keith Seitz  <keiths@redhat.com>
 632
 633         PR gdb/23567
 634         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 635         sections whose size is greater than the file size.
 636
 637 2019-10-16  Jim Wilson  <jimw@sifive.com>
 638
 639         * riscv-tdep.c (riscv_gcc_target_options): New.
 640         (riscv_gnu_triplet_regexp): New.
 641         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 642         set_gdbarch_gnu_triplet_regexp.
 643
 644 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 645
 646         * Makefile.in: Add xml-builtin.h.
 647         * features/feature_to_c.sh: Add an include for xml-builtin.h
 648         to ensure that the compiler checks that the types match.
 649         * xml-builtin.h: New file.
 650         * xml-support.c (fetch_xml_builtin): Add missing const.
 651         * xml-support.h: Remove declaration of xml_builtins.
 652
 653 2019-10-16  Tom de Vries  <tdevries@suse.de>
 654
 655         PR tdep/25096
 656         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 657         (amd64_classify_aggregate): ... here.
 658         (amd64_classify_aggregate_field): Handled fiels of nested structs
 659         recursively.
 660
 661 2019-10-16  Tom de Vries  <tdevries@suse.de>
 662
 663         PR tdep/24104
 664         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 665         that handles 'theclass'.
 666
 667 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * linespec.c (decode_digits_ordinary): Update comment.
 670         * make-target-delegates: No longer need to handle VEC case.
 671         * memrange.c (normalize_mem_ranges): Update comment.
 672         * namespace.c (add_using_directive): Update comment.
 673         * objc-lang.c (uniquify_strings): Update comment.
 674         * ppc-linux-nat.c (struct thread_points): Update comment.
 675         * probe.h (find_probes_in_objfile): Update comment.
 676         * target.h (enum flash_preserve_mode): Update comment.
 677         * varobj.c (varobj_restrict_range): Update comment.
 678         * varobj.h (varobj_list_children): Update comment.
 679
 680 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 681
 682         * Makefile.in: Remove references to vec.h and vec.c.
 683         * aarch64-tdep.c: No longer include vec.h.
 684         * ada-lang.c: Likewise.
 685         * ada-lang.h: Likewise.
 686         * arm-tdep.c: Likewise.
 687         * ax.h: Likewise.
 688         * breakpoint.h: Likewise.
 689         * charset.c: Likewise.
 690         * cp-support.h: Likewise.
 691         * dtrace-probe.c: Likewise.
 692         * dwarf2read.c: Likewise.
 693         * extension.h: Likewise.
 694         * gdb_bfd.c: Likewise.
 695         * gdbsupport/gdb_vecs.h: Likewise.
 696         * gdbsupport/vec.c: Remove.
 697         * gdbsupport/vec.h: Remove.
 698         * gdbthread.h: Likewise.
 699         * guile/scm-type.c: Likewise.
 700         * inline-frame.c: Likewise.
 701         * machoread.c: Likewise.
 702         * memattr.c: Likewise.
 703         * memrange.h: Likewise.
 704         * namespace.h: Likewise.
 705         * nat/linux-btrace.h: Likewise.
 706         * osdata.c: Likewise.
 707         * parser-defs.h: Likewise.
 708         * progspace.h: Likewise.
 709         * python/py-type.c: Likewise.
 710         * record-btrace.c: Likewise.
 711         * rust-exp.y: Likewise.
 712         * solib-target.c: Likewise.
 713         * stap-probe.c: Likewise.
 714         * target-descriptions.c: Likewise.
 715         * target-memory.c: Likewise.
 716         * target.h: Likewise.
 717         * varobj.c: Likewise.
 718         * varobj.h: Likewise.
 719         * xml-support.h: Likewise.
 720
 721 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 724         Update for new std::vector based implementation.
 725         (process_psymtab_comp_unit_reader): Likewise.
 726         (scan_partial_symbols): Likewise.
 727         (recursively_compute_inclusions): Likewise.
 728         (compute_compunit_symtab_includes): Likewise.
 729         (process_imported_unit_die): Likewise.
 730         (queue_and_load_dwo_tu): Likewise.
 731         (follow_die_sig_1): Likewise.
 732         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 733         (typedef dwarf2_per_cu_ptr): Remove.
 734         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 735         function.
 736         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 737         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 738         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 739         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 740         std::vector.
 741
 742 2019-10-15  Tom Tromey  <tromey@adacore.com>
 743
 744         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 745         TID.
 746
 747 2019-10-15  Tom Tromey  <tromey@adacore.com>
 748
 749         * windows-nat.c (windows_nat_target::fetch_registers)
 750         (windows_nat_target::store_registers): Rename "pid" to "tid".
 751
 752 2019-10-15  Tom Tromey  <tromey@adacore.com>
 753
 754         * gdbarch.h, gdbarch.c: Rebuild.
 755         * gdbarch.sh (gcc_target_options): Change return type to
 756         std::string.
 757         * compile/compile.c (get_args): Update.
 758         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 759         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 760         std::string.
 761         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 762         std::string.
 763         * arch-utils.c (default_gcc_target_options): Return std::string.
 764         * arch-utils.h (default_gcc_target_options): Return std::string.
 765         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 766
 767 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 768
 769         * breakpoint.c (breakpoint_chain): Make static.
 770         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 771         of accessing breakpoint_chain.
 772
 773 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 774
 775         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 776         to a gdb::function_view and return value to bool.
 777         * breakpoint.h (iterate_over_breakpoints): Likewise.
 778         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 779         (pop_dummy_frame): Update.
 780         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 781         (gdbscm_breakpoints): Update.
 782         * python/py-breakpoint.c (build_bp_list): Update.
 783         (gdbpy_breakpoints): Update.
 784         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 785         Update.
 786         (bpfinishpy_handle_stop): Update.
 787         (bpfinishpy_handle_exit): Update.
 788         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 789         (svr4_update_solib_event_breakpoints): Update.
 790
 791 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 792
 793         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 794         when unwrapping single-field structs.
 795
 796 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 797
 798         * dwarf2read.c: Remove includes.
 799
 800 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 801
 802         * ui-out.c (ui_out::call_do_message): Silence
 803         -Wformat-nonliteral warning.
 804
 805 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 806
 807         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 808         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 809         include: readline/tilde.h.
 810
 811 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 812
 813         * remote.c (remote_target::get_trace_status): Remove declaration of
 814         trace_regblock_size.
 815
 816 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 817
 818         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 819         (show_user): Remove declaration of cmdlist.
 820         * cli/cli-cmds.h (max_user_call_depth): Declare.
 821         * cli/cli-script.c (execute_user_command): Remove declaration
 822         of max_user_call_depth.
 823
 824 2019-10-11  Jim Wilson  <jimw@sifive.com>
 825
 826         * gdbsupport/print-utils.h (pulongest): Fix comment.
 827         (plongest): Likewise.
 828         (phex): Add missing comment, mention leading zeros.
 829         (phex_nz): Add mention of no leading zeros to comment.
 830
 831         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 832         plongest instead of unsigned long long cast.
 833
 834 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 835
 836         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 837         for external_editor_command and gdbtk_test.
 838
 839 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 840
 841         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 842         * varobj.c (varobjdebug): Move comment to...
 843         * varobj.h (varobjdebug): ...here, and declare.
 844
 845 2019-10-09  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 848         erase_data_content.
 849
 850 2019-10-09  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 853         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 854         * tui/tui-command.c (tui_cmd_window::resize)
 855         (tui_refresh_cmd_win): Update.
 856         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 857         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 858         * tui/tui-data.c (~tui_gen_win_info): Remove.
 859         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 860         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 861         (tui_redisplay_readline, tui_mld_flush)
 862         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 863         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 864         (tui_data_window::erase_data_content)
 865         (tui_data_item_window::rerender)
 866         (tui_data_item_window::refresh_window): Update.
 867         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 868         (box_win, tui_gen_win_info::make_window)
 869         (tui_gen_win_info::make_visible): Update.
 870         (tui_delete_win): Remove.
 871         * tui/tui-winsource.c
 872         (tui_source_window_base::do_erase_source_content): Update.
 873         (tui_show_source_line, tui_source_window_base::update_tab_width)
 874         (tui_source_window_base::update_exec_info): Update.
 875         * tui/tui-data.h (struct curses_deleter): New.
 876         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 877         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 878
 879 2019-10-09  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 882
 883 2019-10-09  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 886         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 887
 888 2019-10-09  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 891         window height directly.
 892         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 893         declare.
 894         * tui/tui-layout.c (tui_default_win_height): Remove.
 895         (tui_default_win_viewport_height): Remove.
 896
 897 2019-10-09  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui.h: Remove comments.
 900
 901 2019-10-09  Tom de Vries  <tdevries@suse.de>
 902
 903         * python/lib/gdb/printer/bound_registers.py: Use
 904         '^builtin_type_bound128' as regexp argument for
 905         add_builtin_pretty_printer.
 906
 907 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 908
 909         * guile/guile.c (guile_extension_script_ops): Remove forward
 910         declaration and mark as static.
 911         (guile_script_ops): Likewise.
 912         (extension_language_guile): Move further down in the file so
 913         it can reference the definitions for guile_{extension_,}script_ops.
 914
 915 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 916
 917         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 918         except SORTL, DFLTCC, and KDSA.
 919
 920 2019-10-08  Tom Tromey  <tromey@adacore.com>
 921
 922         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 923         (struct safe_symbol_file_add_args): Remove.
 924
 925 2019-10-08  Tom Tromey  <tromey@adacore.com>
 926
 927         * windows-nat.c: Don't include buildsym-legacy.h.
 928
 929 2019-10-08  Tom Tromey  <tromey@adacore.com>
 930
 931         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 932
 933 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 934
 935         * gdbtypes.c (overload_debug): Move comment to header.
 936         * gdbtypes.h (overload_debug): Declare.
 937         * valops.c: Remove declaration of overload_debug, instead
 938         include gdbtypes.h.
 939
 940 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 941
 942         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 943         through _().
 944         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 945         move comment...
 946         * language.h (lang_frame_mismatch_warn): ... here. Also add
 947         declaration.
 948         * top.c (lang_frame_mismatch_warn): Remove declaration.
 949         (check_frame_language_change): Pass lang_frame_mismatch_warn
 950         through _().
 951
 952 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 953
 954         * c-lang.h (vtbl_ptr_name): Declare.
 955         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 956         it from the header.
 957         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 958
 959 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 960
 961         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 962         gdb_static_assert.
 963
 964 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 965
 966         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 967         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 968         * ctfread.c: New file.
 969         * ctfread.h: New file.
 970         * elfread.c: Include ctfread.h.
 971         (struct elfinfo text_p): New member ctfsect.
 972         (elf_locate_sections): Mark CTF section.
 973         (elf_symfile_read): Call elfctf_build_psymtabs.
 974         * Makefile.in (LIBCTF): Add.
 975         (CLIBS): Use it.
 976         (CDEPS): Likewise.
 977         (DIST): Add ctfread.c.
 978
 979 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * ctfread.c (struct nextfield): Renamed to ...
 982         (struct ctf_nextfield): ... this.
 983         (struct field_info): Renamed to ...
 984         (strut ctf_field_info): ... this.
 985         (attach_fields_to_type): Update for renamed structures.
 986         (ctf_add_member_cb): Likewise.
 987         (ctf_add_enum_member_cb): Likewise.
 988         (process_struct_members): Likewise.
 989         (process_enum_type): Likewise.
 990
 991 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 992
 993         * tracectf.h: Rename, was ctf.h.
 994         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 995         * tracefile.c: Likewise.
 996         * tracepoint.c: Remove unused include ctf.h.
 997         * mi/mi-main.c: Likewise.
 998         * Makefile.in Replace ctf.c with tracectf.c.
 999
1000 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1001
1002         * version.in: Change version number to "9.0.50.DATE-git".
1003
1004 2019-10-03  Tom Tromey  <tom@tromey.com>
1005
1006         PR rust/24976:
1007         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1008
1009 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1012         cp_search_name_hash.
1013         * NEWS: Add entry about nested function support.
1014
1015 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1016             Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1019         for nested static variables when searchin VAR_DOMAIN.
1020         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1021         global scope, update comment.
1022         (add_partial_subprogram): Call add_partial_subprogram recursively
1023         for nested subroutines when processinng Fortran.
1024         (load_partial_dies): Process the child entities of a subprogram
1025         when processing Fortran.
1026         (partial_die_parent_scope): Handle building scope
1027         for Fortran nested functions.
1028         (process_die): Record that nested functions have a scope.
1029         (new_symbol): Always record Fortran subprograms on the global
1030         symbol list.
1031         (determine_prefix): How to build the prefix for Fortran
1032         subprograms.
1033
1034 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1037         have just sent the thread a SIGSTOP and are waiting for it to
1038         arrive.
1039
1040 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * btrace.c (btrace_add_pc): Remove whitespace before the template
1043         parameter in 'std::vector <...>'.
1044         (parse_xml_btrace_block): Likewise.
1045         (btrace_maint_decode_pt): Likewise.
1046         (btrace_maint_update_packets): Likewise.
1047         (btrace_maint_print_packets): Likewise.
1048         * btrace.h (struct btrace_maint_info): Likewise.
1049         * dwarf2read.c (struct type_unit_group): Likewise.
1050         (build_type_psymtabs_reader): Likewise.
1051         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1052         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1053         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1054
1055 2019-10-03  Tom de Vries  <tdevries@suse.de>
1056
1057         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1058         the first line of the help text for set/show style metadata.
1059
1060 2019-10-02  Tom Tromey  <tromey@adacore.com>
1061
1062         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1063         * gdbsupport/common-inferior.c: New file.
1064         * infcmd.c (startup_with_shell): Don't define.
1065         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1066         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1067         * inferior.h (startup_with_shell): Don't declare.
1068
1069 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1070
1071         * gdbsupport/gdb_assert.h: Include errors.h.
1072         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1073
1074 2019-10-02  Tom Tromey  <tromey@adacore.com>
1075
1076         * NEWS: Add $_ada_exception entry.
1077         * ada-lang.c (struct ada_catchpoint): Add constructor.
1078         <m_kind>: New member.
1079         (allocate_location_exception, re_set_exception): Remove
1080         "ex" parameter.
1081         (should_stop_exception): Compute $_ada_exception.
1082         (check_status_exception, print_it_exception)
1083         (print_one_exception, print_mention_exception): Remove
1084         "ex" parameter.
1085         (allocate_location_catch_exception, re_set_catch_exception)
1086         (check_status_exception, print_it_catch_exception)
1087         (print_one_catch_exception, print_mention_catch_exception)
1088         (print_recreate_catch_exception)
1089         (allocate_location_catch_exception_unhandled)
1090         (re_set_catch_exception_unhandled)
1091         (check_status_exception, print_it_catch_exception_unhandled)
1092         (print_one_catch_exception_unhandled)
1093         (print_mention_catch_exception_unhandled)
1094         (print_recreate_catch_exception_unhandled)
1095         (allocate_location_catch_assert, re_set_catch_assert)
1096         (check_status_assert, print_it_catch_assert)
1097         (print_one_catch_assert, print_mention_catch_assert)
1098         (print_recreate_catch_assert)
1099         (allocate_location_catch_handlers, re_set_catch_handlers)
1100         (check_status_handlers, print_it_catch_handlers)
1101         (print_one_catch_handlers, print_mention_catch_handlers)
1102         (print_recreate_catch_handlers): Remove.
1103         (create_ada_exception_catchpoint): Update.
1104         (initialize_ada_catchpoint_ops): Update.
1105
1106 2019-10-02  Tom Tromey  <tromey@adacore.com>
1107
1108         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1109         (create_excep_cond_exprs): Simplify exception string computation.
1110         (ada_exception_catchpoint_cond_string): Likewise.
1111
1112 2019-10-02  Tom Tromey  <tromey@adacore.com>
1113
1114         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1115         * ada-lang.c (lesseq_defined_than): Handle
1116         LOC_STATIC.
1117         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1118         parameter.
1119         (dwarf2_has_info): Likewise.
1120         (new_symbol): Set maybe_copied on symbol when
1121         appropriate.
1122         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1123         parameter.
1124         <can_copy>: New member.
1125         * elfread.c (record_minimal_symbol): Set maybe_copied
1126         on symbol when appropriate.
1127         (elf_symfile_read): Update call to dwarf2_has_info.
1128         * minsyms.c (lookup_minimal_symbol_linkage): New
1129         function.
1130         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1131         * symtab.c (get_symbol_address, get_msymbol_address):
1132         New functions.
1133         * symtab.h (get_symbol_address, get_msymbol_address):
1134         Declare.
1135         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1136         maybe_copied.
1137         (struct symbol, struct minimal_symbol) <maybe_copied>:
1138         New member.
1139
1140 2019-10-02  Tom Tromey  <tromey@adacore.com>
1141
1142         * source.c (struct current_source_location): New.
1143         (current_source_key): New global.
1144         (current_source_symtab, current_source_line)
1145         (current_source_pspace): Remove.
1146         (get_source_location): New function.
1147         (get_current_source_symtab_and_line)
1148         (set_default_source_symtab_and_line)
1149         (set_current_source_symtab_and_line)
1150         (clear_current_source_symtab_and_line, select_source_symtab)
1151         (info_source_command, print_source_lines_base)
1152         (info_line_command, search_command_helper, _initialize_source):
1153         Update.
1154
1155 2019-10-02  Tom Tromey  <tromey@adacore.com>
1156
1157         * source.c (select_source_symtab): Don't call
1158         decode_line_with_current_source.
1159
1160 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * symtab.c (lookup_global_symbol): Search global block.
1163
1164 2019-10-02  Tom Tromey  <tromey@adacore.com>
1165
1166         * coffread.c (process_coff_symbol): Update.
1167         * dwarf2read.c (var_decode_location, new_symbol): Update.
1168         * mdebugread.c (parse_symbol): Update.
1169         * objfiles.c (relocate_one_symbol): Update.
1170         * stabsread.c (define_symbol, fix_common_block)
1171         (scan_file_globals): Update.
1172         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1173         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1174         * xcoffread.c (process_xcoff_symbol): Update.
1175
1176 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1177
1178         * MAINTAINERS: Update my email address.
1179
1180 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1183         std::vector.
1184         (build_type_psymtabs_reader): Update for std::vector.
1185         (build_type_psymtab_dependencies): Likewise.
1186         * dwarf2read.h: Remove use of DEF_VEC_P.
1187         (typedef sig_type_ptr): Delete.
1188
1189 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1192         to std::vector.
1193         (btrace_maint_decode_pt): Likewise, and move allocation of the
1194         vector outside of the loop.
1195         (btrace_maint_update_packets): Update to handle change from VEC to
1196         std::vector.
1197         (btrace_maint_print_packets): Likewise.
1198         (maint_info_btrace_cmd): Likewise.
1199         * btrace.h: Remove use of DEF_VEC_O.
1200         (typedef btrace_pt_packet_s): Delete.
1201         (struct btrace_maint_info) <packets>: Change fromm VEC to
1202         std::vector.
1203         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1204
1205 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1208         make accesses into the vector constant references.
1209         (btrace_add_pc): Update for std::vector.
1210         (btrace_stitch_bts): Likewise.
1211         (parse_xml_btrace_block): Likewise.
1212         (btrace_maint_update_packets): Likewise.
1213         (btrace_maint_print_packets): Likewise.
1214         (maint_info_btrace_cmd): Likewise.
1215         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1216         std::vector.
1217         (btrace_data::empty): Likewise.
1218         (btrace_data_append): Likewise.
1219         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1220         (typedef btrace_block_s): Delete.
1221         (struct btrace_block): Add constructor.
1222         (struct btrace_data_bts) <blocks>: Change to std::vector.
1223         * nat/linux-btrace.c (perf_event_read_bts): Update for
1224         std::vector.
1225         (linux_read_bts): Likewise.
1226
1227 2019-10-01  Tom Tromey  <tom@tromey.com>
1228
1229         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1230
1231 2019-10-01  Tom Tromey  <tom@tromey.com>
1232
1233         * stack.c (print_frame, info_frame_command_core): Use
1234         styled_string.
1235         * linux-thread-db.c (try_thread_db_load_1)
1236         (try_thread_db_load_from_pdir_1): Use styled_string.
1237         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1238         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1239         (maybe_print_unsupported_script_warning)
1240         (maybe_print_script_not_found_warning): Use styled_string.
1241         * ada-lang.c (user_select_syms): Use styled_string.
1242
1243 2019-10-01  Tom Tromey  <tom@tromey.com>
1244
1245         * p-lang.c (pascal_printstr): Use metadata style.
1246         * value.c (show_convenience): Use metadata style.
1247         * valprint.c (valprint_check_validity, val_print_optimized_out)
1248         (val_print_not_saved, val_print_unavailable)
1249         (val_print_invalid_address, generic_val_print, val_print)
1250         (value_check_printable, val_print_array_elements): Use metadata
1251         style.
1252         * ui-out.h (class ui_out) <field_fmt>: New overload.
1253         <do_field_fmt>: Add style parameter.
1254         * ui-out.c (ui_out::field_fmt): New overload.
1255         * typeprint.c (type_print_unknown_return_type)
1256         (val_print_not_allocated, val_print_not_associated): Use metadata
1257         style.
1258         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1259         parameter.
1260         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1261         * tracepoint.c (tvariables_info_1): Use metadata style.
1262         * stack.c (print_frame_arg, print_frame_info, print_frame)
1263         (info_frame_command_core): Use metadata style.
1264         * skip.c (info_skip_command): Use metadata style.
1265         * rust-lang.c (rust_print_enum): Use metadata style.
1266         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1267         metadata style.
1268         * python/py-framefilter.c (py_print_single_arg): Use metadata
1269         style.
1270         * printcmd.c (do_one_display, print_variable_and_value): Use
1271         metadata style.
1272         * p-valprint.c (pascal_val_print)
1273         (pascal_object_print_value_fields): Use metadata style.
1274         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1275         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1276         parameter.
1277         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1278         * m2-valprint.c (m2_print_long_set): Use metadata style.
1279         * m2-typeprint.c (m2_print_type): Use metadata style.
1280         * infcmd.c (print_return_value_1): Use metadata style.
1281         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1282         * f-valprint.c (info_common_command_for_block): Use metadata
1283         style.
1284         * f-typeprint.c (f_type_print_base): Use metadata style.
1285         * expprint.c (print_subexp_standard): Use metadata style.
1286         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1287         * cli/cli-style.h (class cli_style_option): Add constructor.
1288         (metadata_style): Declare.
1289         * cli/cli-style.c (metadata_style): New global.
1290         (_initialize_cli_style): Register metadata style.
1291         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1292         parameter.
1293         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1294         * c-typeprint.c (c_type_print_base_struct_union)
1295         (c_type_print_base_1): Use metadata style.
1296         * breakpoint.c (watchpoint_value_print)
1297         (print_one_breakpoint_location): Use metadata style.
1298         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1299         style.
1300         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1301         style.
1302         * ada-valprint.c (val_print_packed_array_elements, printstr)
1303         (print_field_values, ada_val_print_ref, ada_val_print): Use
1304         metadata style.
1305         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1306         style.
1307         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1308         style.
1309         * ada-lang.c (user_select_syms): Use metadata style.
1310
1311 2019-10-01  Tom Tromey  <tom@tromey.com>
1312
1313         * cli/cli-cmds.c (pwd_command): Style output.
1314
1315 2019-10-01  Pedro Alves  <palves@redhat.com>
1316             Tom Tromey  <tom@tromey.com>
1317
1318         * symtab.c (print_symbol_info): Use %ps.
1319         (print_msymbol_info): Use %ps.
1320         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1321         * printcmd.c (print_variable_and_value): Use %ps.
1322         * macrocmd.c (show_pp_source_pos): Use %ps.
1323         * infrun.c (print_exited_reason): Use ui_out::message.
1324         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1325         (describe_other_breakpoints): Use ui_out::message and new
1326         formats.
1327         (say_where): Use new formats.
1328         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1329         and new formats.
1330
1331 2019-10-01  Pedro Alves  <palves@redhat.com>
1332             Tom Tromey  <tom@tromey.com>
1333
1334         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1335         (test_gdb_formats): New function.
1336         (run_tests): Call it.
1337         (test_format_specifier): Update.
1338         * utils.h (fputs_filtered): Update comment.
1339         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1340         (fputs_styled_unfiltered): Declare.
1341         * utils.c (fputs_styled_unfiltered): New function.
1342         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1343         (vfprintf_filtered): Update.
1344         (vfprintf_unfiltered, vprintf_filtered): Update.
1345         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1346         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1347         disallow_ui_out_field>: New constants.
1348         (enum class field_kind): New.
1349         (struct base_field_s, struct signed_field_s): New.
1350         (signed_field): New function.
1351         (struct string_field_s): New.
1352         (string_field): New function.
1353         (struct styled_string_s): New.
1354         (styled_string): New function.
1355         (class ui_out) <message>: Add comment.
1356         <vmessage, call_do_message>: New methods.
1357         <do_message>: Add style parameter.
1358         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1359         methods.
1360         (ui_out::message): Rewrite.
1361         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1362         parameter.
1363         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1364         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1365         gdb_extensions parameter.
1366         (class format_piece): Add parameter to constructor.
1367         (n_int_args): New field.
1368         * gdbsupport/format.c (format_pieces::format_pieces): Add
1369         gdb_extensions parameter.  Handle '*'.
1370         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1371         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1372         vfprintf_styled_no_gdbfmt.
1373         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1374         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1375         unfiltered output.
1376         * ui-style.h (struct ui_file_style) <ptr>: New method.
1377
1378 2019-10-01  Tom Tromey  <tom@tromey.com>
1379
1380         * unittests/format_pieces-selftests.c: Update.  Add final format.
1381         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1382         empty literal pieces.
1383
1384 2019-10-01  Tom Tromey  <tom@tromey.com>
1385
1386         * ui-out.h (enum class ui_out_style_kind): Remove.
1387         (class ui_out) <field_string, field_stsream, do_field_string>:
1388         Change type of "style".
1389         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1390         (ui_out::field_string): Update.
1391         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1392         of "style".
1393         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1394         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1395         * stack.c (print_frame_arg, print_frame_info, print_frame):
1396         Update.
1397         * source.c (print_source_lines_base): Update.
1398         * solib.c (info_sharedlibrary_command): Update.
1399         * skip.c (info_skip_command): Update.
1400         * record-btrace.c (btrace_call_history_src_line)
1401         (btrace_call_history): Update.
1402         * python/py-framefilter.c (py_print_frame): Update.
1403         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1404         "style".
1405         * mi/mi-out.c (mi_ui_out::do_table_header)
1406         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1407         (mi_ui_out::do_field_string): Update.
1408         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1409         Update.
1410         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1411         "style".
1412         * cli-out.c (cli_ui_out::do_table_header)
1413         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1414         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1415         (cli_ui_out::do_field_fmt): Update.
1416         * breakpoint.c (print_breakpoint_location): Update.
1417         (update_static_tracepoint): Update.
1418
1419 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1420
1421         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1422         conversion of gdb_datadir.
1423         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1424         remove not needed c_str ().
1425
1426 2019-09-30  Ali Tamur <tamur@google.com>
1427
1428         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1429         (dwarf2_string_attr): Likewise.
1430
1431 2019-09-30  Ali Tamur <tamur@google.com>
1432
1433         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1434         (process_full_type_unit): Likewise.
1435         (dump_die_shallow): Likewise.
1436         (cu_debug_loc_section): Likewise.
1437
1438 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1439
1440         * minsyms.c (compare_minimal_symbols): Rename to...
1441         (minimal_symbol_is_less_than): ...this, and adjust to STL
1442         conventions (return bool, take arguments as references)
1443         (minimal_symbol_reader::install): Call std::sort instead
1444         of qsort.
1445
1446 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1447
1448         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1449         hash and why.
1450         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1451         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1452
1453 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1454
1455         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1456         * psympriv.h (add_psymbol_to_list): Move comment here and update
1457         it.
1458
1459 2019-09-29  Tom de Vries  <tdevries@suse.de>
1460
1461         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1462         Use $tmpdir/$(basename "$output_file").dwz instead of
1463         "${output_file}.dwz".
1464
1465 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1466
1467         PR gdb/25045
1468         * hppa-linux-nat.c: Include gdbarch.h.
1469
1470 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1471
1472         * blockframe.c (find_pc_partial_function): Change return type to bool.
1473         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1474         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1475         (stub_gnu_ifunc_resolve_name): Likewise.
1476         * symtab.c (compare_filenames_for_search): Likewise.
1477         (compare_glob_filenames_for_search): Likewise.
1478         (matching_obj_sections): Likewise.
1479         (symbol_matches_domain): Likewise.
1480         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1481         (find_line_pc): Change return type to bool.
1482         (find_line_pc_range): Likewise.
1483         (producer_is_realview): Likewise.
1484         * symtab.h (symbol_matches_domain): Likewise.
1485         (find_pc_partial_function): Likewise.
1486         (find_pc_line_pc_range): Likewise.
1487         (in_gnu_ifunc_stub): Likewise.
1488         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1489         (find_line_pc): Likewise.
1490         (find_line_pc_range): Likewise.
1491         (matching_obj_sections): Likewise.
1492         (find_line_symtab): Change out parameter to bool.
1493         (producer_is_realview): Change return type to bool.
1494         (compare_filenames_for_search): Likewise.
1495         (compare_glob_filenames_for_search): Likewise.
1496
1497 2019-09-26  Tom Tromey  <tom@tromey.com>
1498
1499         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1500         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1501         * gdb_usleep.h: Remove.
1502         * gdb_usleep.c: Remove.
1503         * utils.c: Don't include gdb_usleep.h.
1504
1505 2019-09-26  Tom Tromey  <tromey@adacore.com>
1506
1507         * python/py-type.c (type_to_type_object): Call check_typedef
1508         for stub types.
1509
1510 2019-09-26  Tom Tromey  <tom@tromey.com>
1511
1512         * utils.h (initialize_utils): Don't declare.
1513         * top.c (gdb_init): Don't call initialize_utils.
1514         * utils.c (initialize_utils): Remove.  Move contents...
1515         (_initialize_utils): ... here.
1516
1517 2019-09-25  Tom Tromey  <tom@tromey.com>
1518
1519         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1520         * utils.h (make_hex_string): Don't declare.
1521         * utils.c (make_hex_string): Remove.
1522
1523 2019-09-24  Tom de Vries  <tdevries@suse.de>
1524
1525         PR gdb/23815
1526         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1527         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1528
1529 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1530
1531         * NEWS: Mention new simulator port for PRU.
1532
1533 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1534
1535         * ada-exp.y (write_object_remaining): Update.
1536         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1537         and eliminate the static buffer.
1538         (ada_decode_symbol): Update.
1539         (ada_la_decode): Update.
1540         (ada_sniff_from_mangled_name): Update.
1541         (is_valid_name_for_wild_match): Update.
1542         (ada_lookup_name_info::matches): Update and simplify.
1543         (name_matches_regex): Update.
1544         (ada_add_global_exceptions): Update.
1545         * ada-lang.h (ada_decode): Update signature.
1546         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1547         * dwarf-index-write.c (debug_names::insert): Update.
1548
1549 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1550
1551         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1552         formatting.
1553
1554 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1555
1556         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1557         Change "nonzero" to "true" in documentation.
1558
1559 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1560
1561         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1562         (_initialize_darwin_solib): Don't set
1563         darwin_so_ops.lookup_lib_global_symbol.
1564         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1565         set_gdbarch_iterate_over_objfiles_in_search_order.
1566         (elf_lookup_lib_symbol): Rename to...
1567         (svr4_iterate_over_objfiles_in_search_order): this, and update
1568         to iterate semantics.
1569         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1570         * solib.c (solib_global_lookup): Remove.
1571         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1572         (solib_global_lookup): Remove.
1573         * symtab.c (lookup_global_or_static_symbol): Remove call to
1574         solib_global_lookup.
1575
1576 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1577
1578         * NEWS: Move entries about default MI version now being
1579         version 3, and about the GDB/MI fix for multi-location
1580         breakpoints to the "since GDB 8.3" section.
1581
1582 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1583
1584         GDB 8.3.1 released.
1585
1586 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1587
1588         * NEWS: Mention that Cell/B.E. debugging support was removed.
1589         * MAINTAINERS: Remove spu target.
1590
1591         * config/djgpp/fnchange.lst: Remove entries for removed files.
1592
1593         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1594         spu-multiarch.o, and spu-tdep.o.
1595         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1596         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1597         spu-multiarch.c, and spu-tdep.c.
1598         * spu-linux-nat.c: Remove file.
1599         * spu-multiarch.c: Remove file.
1600         * spu-tdep.c: Remove file.
1601         * spu-tdep.h: Remove file.
1602         * solib-spu.c: Remove file.
1603         * solib-spu.h: Remove file.
1604
1605         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1606         * configure.nat (spu-linux): Remove.
1607         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1608         solib-multiarch.o from gdb_target_obs.
1609         (spu*-*-*): Remove.
1610
1611         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1612         feature flag.
1613         (ppc_linux_no_features): Update.
1614         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1615         Cell/B.E. support.
1616         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1617         (tdesc_powerpc_cell64l): Likewise.
1618         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1619         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1620         Cell/B.E. support.
1621         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1622         Do not include "features/rs6000/powerpc-cell32l.c" or
1623         "features/rs6000/powerpc-cell64l.c".
1624         (ppc_linux_spu_section): Remove.
1625         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1626         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1627         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1628         (ppc_linux_spe_context_lookup): Remove.
1629         (ppc_linux_spe_context_inferior_created): Remove.
1630         (ppc_linux_spe_context_solib_loaded): Remove.
1631         (ppc_linux_spe_context_solib_unloaded): Remove.
1632         (ppc_linux_spe_context): Remove.
1633         (struct ppu2spu_cache): Remove.
1634         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1635         (struct ppu2spu_data): Remove.
1636         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1637         ppu2spu_unwind): Remove.
1638         (ppc_linux_init_abi): Remove Cell/B.E. support.
1639         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1640
1641         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1642         (rs6000/powerpc-cell64l-expedite): Likewise
1643         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1644         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1645         rs6000/powerpc-cell64l.xml.
1646         * features/rs6000/powerpc-cell32l.xml: Remove.
1647         * features/rs6000/powerpc-cell64l.xml: Likewise.
1648         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1649         * features/rs6000/powerpc-cell64l.c: Likewise.
1650         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1651         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1652         * regformats/reg-spu.dat: Remove.
1653
1654         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1655         * corelow.c (struct spuid_list): Remove.
1656         (add_to_spuid_list): Remove.
1657         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1658         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1659         (remote_protocol_features): Remove associated entries.
1660         (_initialize_remote): No longer initialize them.
1661         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1662         * linux-nat.c (SPUFS_MAGIC): Remove.
1663         (linux_proc_xfer_spu): Remove.
1664         (spu_enumerate_spu_ids): Remove.
1665         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1666         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1667         (linux_make_corefile_notes): No longer call it.
1668
1669         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1670         (cooked_write_test): Likewise.
1671
1672 2019-09-20  Tom Tromey  <tom@tromey.com>
1673
1674         * NEWS: Mention case-sensitivity of TUI commands.
1675         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1676         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1677         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1678
1679 2019-09-20  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-source.c (tui_source_window::set_contents): Use
1682         make_unique_xstrdup.
1683         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1684         make_unique_xstrdup.
1685
1686 2019-09-20  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-data.c: Remove separator comments.
1689         * tui/tui-layout.c: Remove separator comments.
1690         * tui/tui-win.c: Remove separator comments.
1691         * tui/tui-wingeneral.c: Remove separator comments.
1692
1693 2019-09-20  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui.h (strcat_to_buf): Don't declare.
1696         * tui/tui.c (strcat_to_buf): Remove.
1697
1698 2019-09-20  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1701         from "fullname".
1702         * tui/tui-source.c (tui_source_window::set_contents)
1703         (tui_source_window::location_matches_p)
1704         (tui_source_window::maybe_update): Update.
1705
1706 2019-09-20  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1709         Update.
1710         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1711         prefix.
1712         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1713         (tui_data_window::line_from_reg_element_no)
1714         (tui_data_window::first_reg_element_no_inline)
1715         (tui_data_window::show_registers)
1716         (tui_data_window::show_register_group)
1717         (tui_data_window::display_registers_from)
1718         (tui_data_window::display_registers_from_line)
1719         (tui_data_window::first_data_item_displayed)
1720         (tui_data_window::delete_data_content_windows)
1721         (tui_data_window::erase_data_content)
1722         (tui_data_window::do_scroll_vertical)
1723         (tui_data_window::refresh_window)
1724         (tui_data_window::check_register_values): Update.
1725
1726 2019-09-20  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1729         (struct tui_locator_window) <full_name, proc_name>: Now
1730         std::string.
1731         * tui/tui-stack.c (tui_locator_window::make_status_line)
1732         (tui_locator_window::set_locator_fullname)
1733         (tui_locator_window::set_locator_info): Update.
1734         * tui/tui-source.c (tui_source_window::set_contents)
1735         (tui_source_window::showing_source_p): Update.
1736
1737 2019-09-20  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1740         Don't call tui_locator_win_info_ptr.
1741
1742 2019-09-20  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1745
1746 2019-09-20  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1749         height for locator.
1750         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1751         * tui/tui-layout.c (show_source_disasm_command, show_data)
1752         (show_source_or_disasm_and_command): Use 1 as height for locator.
1753
1754 2019-09-20  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui.c (tui_enable): Update.
1757         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1758         Update.
1759         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1760         Update.
1761         * tui/tui-data.c (win_resized): Now bool.
1762         (tui_win_resized): Return bool.
1763         (tui_set_win_resized_to): Accept a bool.
1764
1765 2019-09-20  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1768         Change type of "refresh_values_only".
1769         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1770         type of "refresh_values_only".
1771
1772 2019-09-20  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1775         std::string.
1776         (tui_disassemble): Add "pos" parameter.
1777         (tui_disasm_window::set_contents): Simplify.
1778
1779 2019-09-20  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-winsource.h (struct tui_source_window_base)
1782         <show_source_content>: Now private.
1783         * tui/tui-winsource.c
1784         (tui_source_window_base::show_source_content): Don't handle empty
1785         content case.
1786
1787 2019-09-20  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-layout.c (show_source_disasm_command)
1790         (show_source_or_disasm_and_command): Don't call
1791         show_source_content.
1792
1793 2019-09-20  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1796         Declare.
1797         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1798         from tui_make_status_line.
1799         (tui_locator_window::rerender): Update.
1800
1801 2019-09-20  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1804         (tui_locator_window::rerender): Update.
1805
1806 2019-09-20  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.h (struct tui_source_window_base)
1809         <~tui_source_window_base>: Don't declare.
1810         <fullname>: Remove.
1811         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1812         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1813         member.
1814         * tui/tui-source.c (tui_source_window::set_contents): Update.
1815         (tui_source_window::location_matches_p)
1816         (tui_source_window::maybe_update): Update.
1817
1818 2019-09-20  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-winsource.h (~tui_source_element): Remove.
1821         (tui_source_element): Update.
1822         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1823         * tui/tui-winsource.c (tui_show_source_line): Update.
1824         * tui/tui-source.c (tui_source_window::set_contents): Update.
1825         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1826
1827 2019-09-20  Tom Tromey  <tom@tromey.com>
1828
1829         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1830         declare.
1831         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1832         tui_clear_source_windows_detail.
1833         * tui/tui-winsource.h (struct tui_source_window_base)
1834         <clear_detail>: Don't declare.
1835         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1836         Remove.
1837         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1838
1839 2019-09-20  Tom Tromey  <tromey@adacore.com>
1840
1841         PR ada/24919:
1842         * block.c (contained_in): Fix final return value.
1843
1844 2019-09-20  Alan Modra  <amodra@gmail.com>
1845
1846         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1847         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1848         (read_indirect_string_from_dwz): Use bfd accessor.
1849         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1850         * machoread.c (macho_symfile_read_all_oso): Likewise.
1851         * solib.c (solib_bfd_open): Likewise.
1852
1853 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1854
1855         * eval.c: Move declaration of overload_resolution to...
1856         * value.h: ...here.
1857
1858 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1859
1860         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1861         * arm-linux-tdep.c: Likewise.
1862         * arm-nbsd-nat.c: Likewise.
1863         * arm-tdep.h: Declare arm_apcs_32.
1864         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1865
1866 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1867
1868         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1869         * dwarf2read.h: Declare dwarf_always_disassemble.
1870
1871 2019-09-19  Tom de Vries  <tdevries@suse.de>
1872
1873         PR gdb/25009
1874         * source-cache.c (source_cache::ensure): Catch exception thrown during
1875         construction of the highlighter.
1876
1877 2019-09-18  Alan Modra  <amodra@gmail.com>
1878
1879         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1880         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1881         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1882         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1883         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1884         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1885         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1886         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1887         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1888         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1889         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1890         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1891         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1892         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1893         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1894         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1895         * mi/mi-interp.c: Update throughout for bfd section macro and
1896         function changes.
1897         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1898         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1899
1900 2019-09-18  Tom Tromey  <tom@tromey.com>
1901
1902         * NEWS: Add entry.
1903         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1904         call rl_initialize.
1905         (tui_enable): Do not call rl_initialize.
1906
1907 2019-09-18  Christian Groessler  <chris@groessler.org>
1908
1909         * alpha-linux-nat.c: Include gdbarch.h.
1910
1911 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1912
1913         * ui-file.c: Include cli/cli-style.h.
1914         (term_cli_styling): Remove cli_styling declaration.
1915
1916 2019-09-18  Alan Modra  <amodra@gmail.com>
1917
1918         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1919         to bfd_asymbol_section.
1920
1921 2019-09-18  Alan Modra  <amodra@gmail.com>
1922
1923         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1924         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1925         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1926
1927 2019-09-18  Alan Modra  <amodra@gmail.com>
1928
1929         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1930         * spu-linux-nat.c (spu_bfd_open): Likewise.
1931
1932 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1933
1934         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1935         to bool to match definition in dwarf2read.c.
1936
1937 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1938
1939         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1940         (print_signatures): Likewise.
1941         (trust_pad_over_xvs): Likewise.
1942         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1943         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1944         * arm-linux-nat.c (arm_apcs_32): Likewise.
1945         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1946         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1947         * arm-tdep.c (arm_debug): Likewise.
1948         (arm_apcs_32): Likewise.
1949         * auto-load.c (debug_auto_load): Likewise.
1950         (auto_load_gdb_scripts): Likewise.
1951         (global_auto_load): Likewise.
1952         (auto_load_local_gdbinit): Likewise.
1953         (auto_load_local_gdbinit_loaded): Likewise.
1954         * auto-load.h (global_auto_load): Likewise.
1955         (auto_load_local_gdbinit): Likewise.
1956         (auto_load_local_gdbinit_loaded): Likewise.
1957         * breakpoint.c (disconnected_dprintf): Likewise.
1958         (breakpoint_proceeded): Likewise.
1959         (automatic_hardware_breakpoints): Likewise.
1960         (always_inserted_mode): Likewise.
1961         (target_exact_watchpoints): Likewise.
1962         (_initialize_breakpoint): Update.
1963         * breakpoint.h (target_exact_watchpoints): Change to bool.
1964         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1965         * cli/cli-cmds.c (trace_commands): Likewise.
1966         * cli/cli-cmds.h (trace_commands): Likewise.
1967         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1968         to bool*.
1969         * cli/cli-logging.c (logging_overwrite): Change to bool.
1970         (logging_redirect): Likewise.
1971         (debug_redirect): Likewise.
1972         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1973         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1974         to bool.
1975         <boolean_option_def>: Update.
1976         (struct flag_option_def): Change default type of Context to bool
1977         from int.
1978         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1979         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1980         (get_setshow_command_value_string): Likewise.
1981         * cli/cli-style.c (cli_styling): Change to bool.
1982         (source_styling): Likewise.
1983         * cli/cli-style.h (source_styling): Likewise.
1984         (cli_styling): Likewise.
1985         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1986         to bool.
1987         * command.h (var_types): Update comment.
1988         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1989         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1990         bool.
1991         (debug_compile_cplus_scopes): Likewise.
1992         * compile/compile-internal.h (compile_debug): Likewise.
1993         * compile/compile.c (compile_debug): Likewise.
1994         (struct compile_options) <raw>: Likewise.
1995         * cp-support.c (catch_demangler_crashes): Likewise.
1996         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1997         (usr_cmd_cris_dwarf2_cfi): Likewise.
1998         * csky-tdep.c (csky_debug): Likewise.
1999         * darwin-nat.c (enable_mach_exceptions): Likewise.
2000         * dcache.c (dcache_enabled_p): Likewise.
2001         * defs.h (info_verbose): Likewise.
2002         * demangle.c (demangle): Likewise.
2003         (asm_demangle): Likewise.
2004         * dwarf-index-cache.c (debug_index_cache): Likewise.
2005         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2006         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2007         * dwarf2read.c (check_physname): Likewise.
2008         (use_deprecated_index_sections): Likewise.
2009         (dwarf_always_disassemble): Likewise.
2010         * eval.c (overload_resolution): Likewise.
2011         * event-top.c (set_editing_cmd_var): Likewise.
2012         (exec_done_display_p): Likewise.
2013         * event-top.h (set_editing_cmd_var): Likewise.
2014         (exec_done_display_p): Likewise.
2015         * exec.c (write_files): Likewise.
2016         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2017         (debug_fbsd_nat): Likewise.
2018         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2019         Likewise.
2020         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2021         <backtrace_past_entry> Likewise.
2022         * gdb-demangle.h (demangle): Likewise.
2023         (asm_demangle): Likewise.
2024         * gdb_bfd.c (bfd_sharing): Likewise.
2025         * gdbcore.h (write_files): Likewise.
2026         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2027         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2028         * gdbthread.h (print_thread_events): Likewise.
2029         * gdbtypes.c (opaque_type_resolution): Likewise.
2030         (strict_type_checking): Likewise.
2031         * gnu-nat.c (gnu_debug_flag): Likewise.
2032         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2033         * guile/scm-param.c (pascm_variable): Add boolval.
2034         (add_setshow_generic): Update.
2035         (pascm_param_value): Update.
2036         (pascm_set_param_value_x): Update.
2037         * hppa-tdep.c (hppa_debug): Change to bool..
2038         * infcall.c (may_call_functions_p): Likewise.
2039         (coerce_float_to_double_p): Likewise.
2040         (unwind_on_signal_p): Likewise.
2041         (unwind_on_terminating_exception_p): Likewise.
2042         * infcmd.c (startup_with_shell): Likewise.
2043         * inferior.c (print_inferior_events): Likewise.
2044         * inferior.h (startup_with_shell): Likewise.
2045         (print_inferior_events): Likewise.
2046         * infrun.c (step_stop_if_no_debug): Likewise.
2047         (detach_fork): Likewise.
2048         (debug_displaced): Likewise.
2049         (disable_randomization): Likewise.
2050         (non_stop): Likewise.
2051         (non_stop_1): Likewise.
2052         (observer_mode): Likewise.
2053         (observer_mode_1): Likewise.
2054         (set_observer_mode): Update.
2055         (sched_multi): Change to bool.
2056         * infrun.h (debug_displaced): Likewise.
2057         (sched_multi): Likewise.
2058         (step_stop_if_no_debug): Likewise.
2059         (non_stop): Likewise.
2060         (disable_randomization): Likewise.
2061         * linux-tdep.c (use_coredump_filter): Likewise.
2062         (dump_excluded_mappings): Likewise.
2063         * linux-thread-db.c (auto_load_thread_db): Likewise.
2064         (check_thread_db_on_load): Likewise.
2065         * main.c (captured_main_1): Update.
2066         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2067         xx2_opt, boolean_opt>: Change to bool.
2068         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2069         * maint.c (maintenance_profile_p): Likewise.
2070         (per_command_time): Likewise.
2071         (per_command_space): Likewise.
2072         (per_command_symtab): Likewise.
2073         * memattr.c (inaccessible_by_default): Likewise.
2074         * mi/mi-main.c (mi_async): Likewise.
2075         (mi_async_1): Likewise.
2076         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2077         * nat/fork-inferior.h (startup_with_shell): Likewise.
2078         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2079         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2080         * nios2-tdep.c (nios2_debug): Likewise.
2081         * or1k-tdep.c (or1k_debug): Likewise.
2082         * parse.c (parser_debug): Likewise.
2083         * parser-defs.h (parser_debug): Likewise.
2084         * printcmd.c (print_symbol_filename): Likewise.
2085         * proc-api.c (procfs_trace): Likewise.
2086         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2087         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2088         (set_parameter_value): Update.
2089         (add_setshow_generic): Update.
2090         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2091         to bool*.
2092         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2093         int*.
2094         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2095         * record-btrace.c (record_btrace_target::store_registers): Update.
2096         * record-full.c (record_full_memory_query): Change to bool.
2097         (record_full_stop_at_limit): Likewise.
2098         * record-full.h (record_full_memory_query): Likewise.
2099         * remote-notif.c (notif_debug): Likewise.
2100         * remote-notif.h (notif_debug): Likewise.
2101         * remote.c (use_range_stepping): Likewise.
2102         (interrupt_on_connect): Likewise.
2103         (remote_break): Likewise.
2104         * ser-tcp.c (tcp_auto_retry): Likewise.
2105         * ser-unix.c (serial_hwflow): Likewise.
2106         * skip.c (debug_skip): Likewise.
2107         * solib-aix.c (solib_aix_debug): Likewise.
2108         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2109         (spu_auto_flush_cache_p): Likewise.
2110         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2111         Likewise.
2112         (struct info_print_options) <quiet>: Likewise.
2113         * symfile-debug.c (debug_symfile): Likewise.
2114         * symfile.c (auto_solib_add): Likewise.
2115         (separate_debug_file_debug): Likewise.
2116         * symfile.h (auto_solib_add): Likewise.
2117         (separate_debug_file_debug): Likewise.
2118         * symtab.c (basenames_may_differ): Likewise.
2119         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2120         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2121         (struct info_types_options) <quiet>: Likewise.
2122         * symtab.h (demangle): Likewise.
2123         (basenames_may_differ): Likewise.
2124         * target-dcache.c (stack_cache_enabled_1): Likewise.
2125         (code_cache_enabled_1): Likewise.
2126         * target.c (trust_readonly): Likewise.
2127         (may_write_registers): Likewise.
2128         (may_write_memory): Likewise.
2129         (may_insert_breakpoints): Likewise.
2130         (may_insert_tracepoints): Likewise.
2131         (may_insert_fast_tracepoints): Likewise.
2132         (may_stop): Likewise.
2133         (auto_connect_native_target): Likewise.
2134         (target_stop_and_wait): Update.
2135         (target_async_permitted): Change to bool.
2136         (target_async_permitted_1): Likewise.
2137         (may_write_registers_1): Likewise.
2138         (may_write_memory_1): Likewise.
2139         (may_insert_breakpoints_1): Likewise.
2140         (may_insert_tracepoints_1): Likewise.
2141         (may_insert_fast_tracepoints_1): Likewise.
2142         (may_stop_1): Likewise.
2143         * target.h (target_async_permitted): Likewise.
2144         (may_write_registers): Likewise.
2145         (may_write_memory): Likewise.
2146         (may_insert_breakpoints): Likewise.
2147         (may_insert_tracepoints): Likewise.
2148         (may_insert_fast_tracepoints): Likewise.
2149         (may_stop): Likewise.
2150         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2151         (make_thread_apply_all_options_def_group): Change argument from int*
2152         to bool*.
2153         (thread_apply_all_command): Update.
2154         (print_thread_events): Change to bool.
2155         * top.c (confirm): Likewise.
2156         (command_editing_p): Likewise.
2157         (history_expansion_p): Likewise.
2158         (write_history_p): Likewise.
2159         (info_verbose): Likewise.
2160         * top.h (confirm): Likewise.
2161         (history_expansion_p): Likewise.
2162         * tracepoint.c (disconnected_tracing): Likewise.
2163         (circular_trace_buffer): Likewise.
2164         * typeprint.c (print_methods): Likewise.
2165         (print_typedefs): Likewise.
2166         * utils.c (debug_timestamp): Likewise.
2167         (sevenbit_strings): Likewise.
2168         (pagination_enabled): Likewise.
2169         * utils.h (sevenbit_strings): Likewise.
2170         (pagination_enabled): Likewise.
2171         * valops.c (overload_resolution): Likewise.
2172         * valprint.h (struct value_print_options) <prettyformat_arrays,
2173         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2174         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2175         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2176         Likewise.
2177         * windows-nat.c (new_console): Likewise.
2178         (cygwin_exceptions): Likewise.
2179         (new_group): Likewise.
2180         (debug_exec): Likewise.
2181         (debug_events): Likewise.
2182         (debug_memory): Likewise.
2183         (debug_exceptions): Likewise.
2184         (useshell): Likewise.
2185         * windows-tdep.c (maint_display_all_tib): Likewise.
2186         * xml-support.c (debug_xml): Likewise.
2187
2188 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2189
2190         * source.c (prepare_path_for_appending): New function.
2191         (openp): Make use of new function.
2192         (find_and_open_source): Search for the compilation directory and
2193         source file as a relative path beneath the directory search path.
2194
2195 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * source-cache.c (source_cache::get_line_charpos): Catch
2198         exceptions and return false, this matches the behaviour documented
2199         in the header file.
2200
2201 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2202
2203         * ada-tasks.c (info_task): Remove quoting of the task's name.
2204
2205 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2206
2207         * symfile.c (auto_solib_add): Replace comment with a reference
2208         to the header file.
2209
2210 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * NEWS: Mention that gdb can now be compiled with Python 3
2213         on Windows.
2214
2215 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * maint.c (maint_print_section_data::maint_print_section_data):
2218         Force use of 'float log10 (float)' by casting the argument to
2219         float.
2220
2221 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2222
2223         * maint.c: Add 'cmath' include.
2224         (struct maint_print_section_data): New structure.
2225         (print_section_index): New function.
2226         (print_bfd_section_info): Add header comment, small whitespace
2227         cleanup, and update to call new print_section_index function.
2228         (print_objfile_section_info): Likewise.
2229         (maint_obj_section_from_bfd_section): New function.
2230         (print_bfd_section_info_maybe_relocated): New function.
2231         (maintenance_info_sections): Add header comment, always use
2232         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2233
2234 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2235
2236         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2237         inner scope, add check that the objfile has psymtabs before
2238         checking psymtabs_addrmap.
2239         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2240
2241 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2242
2243         * NEWS: Announce that Ada task names are now shown at more places,
2244         and between quotes (except in info task output).
2245         * gdb/ada-tasks.c (task_to_str): New function.
2246         (display_current_task_id): Call task_to_str.
2247         (task_command_1): Likewise.
2248         (print_ada_task_info): In non-mi mode, Properly align headers and data
2249         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2250
2251 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2252
2253         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2254         prstatus.pr_lwp.pr_info instead of making it up.
2255
2256 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2257
2258         * auto-load.c (auto_load_expand_dir_vars): Update.
2259         * defs.h (gdb_datadir): Change to std::string.
2260         (python_libdir): Likewise.
2261         (relocate_gdb_directory): Change return type to std::string.
2262         * guile/guile.c (gdbscm_data_directory): Update.
2263         (initialize_scheme_side): Update.
2264         * jit.c (jit_reader_dir): Change to std::string.
2265         (jit_reader_load_command): Update.
2266         * main.c (gdb_datadir): Change to std::string.
2267         (python_libdir): Likewise.
2268         (set_gdb_data_directory): Update.
2269         (relocate_path): Change to return std::string.
2270         (relocate_gdb_directory): Change to return std::string.
2271         (relocate_gdbinit_path_maybe_in_datadir): Update.
2272         (captured_main_1): Update.
2273         * python/python.c (do_start_initialization): Update.
2274         * top.c (show_gdb_datadir): Update.
2275         * xml-syscall.c (xml_init_syscalls_info): Update.
2276         (init_syscalls_info): Update.
2277
2278 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2279
2280         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2281         out of get_init_files.
2282         (get_init_files): Update.
2283
2284 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * main.c (get_init_files): Change to use std::string.
2287         (captured_main_1): Update.
2288         (print_gdb_help): Update.
2289
2290 2019-09-11  Ali Tamur  <tamur@google.com>
2291
2292         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2293         implementation.
2294
2295 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2296
2297         * dbxread.c (read_dbx_symtab): Update.
2298         * dwarf2read.c (load_partial_dies): Update.
2299         * mdebugread.c (parse_partial_symbols): Update.
2300         (handle_psymbol_enumerators): Update.
2301         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2302         * psymtab.c (add_psymbol_to_bcache): Likewise.
2303         (add_psymbol_to_list): Likewise.
2304         * symtab.c (symbol_set_names): Likewise.
2305         * symtab.h (symbol_set_names): Likewise.
2306         * xcoffread.c (scan_xcoff_symtab): Update.
2307
2308 2019-09-11  Tom Tromey  <tom@tromey.com>
2309
2310         * symfile-mem.c (symbol_file_add_from_memory): Use
2311         bfd_set_filename.
2312         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2313         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2314
2315 2019-09-10  Tom Tromey  <tromey@adacore.com>
2316
2317         * dwarf-index-write.c (write_psymbols): Extend error message.
2318         (debug_names::insert): Add Ada code.
2319         (debug_names::write_psymbols): Remove Ada check.
2320         (debug_names) <m_string_obstack>: New member.
2321         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2322         (gdb_index_symbol_name_matcher::matches): Remove.
2323         (mapped_index_base::find_name_components_bounds): Add "lang"
2324         parameter.
2325         (mapped_index_base::build_name_components): Also split names
2326         according to Ada syntax.
2327         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2328         type of "match_callback".
2329         (check_match, check_find_bounds_finds)
2330         (dw2_expand_symtabs_matching): Update.
2331         (dw2_debug_names_iterator): Add new constructor.
2332         (dw2_debug_names_map_matching_symbols): New function.
2333         (dw2_debug_names_expand_symtabs_matching): Update.
2334         (dwarf2_debug_names_functions): Use
2335         dw2_debug_names_map_matching_symbols.
2336
2337 2019-09-10  Tom Tromey  <tromey@adacore.com>
2338
2339         * dwarf2read.c (dw2_get_file_names_reader): Add the
2340         CU's file name to the results.
2341
2342 2019-09-10  Tom Tromey  <tromey@adacore.com>
2343
2344         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2345         map_matching_symbols.  Update.
2346         * dwarf2read.c (dw2_map_matching_symbols): Update.
2347         * psymtab.c (match_partial_symbol): Change type; update.
2348         (psym_map_matching_symbols): Likewise.
2349         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2350         type; update.
2351         * symfile.h (struct quick_symbol_functions)
2352         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2353         Remove "match".
2354
2355 2019-09-10  Tom Tromey  <tromey@adacore.com>
2356
2357         * psymtab.c (map_block): Remove.
2358         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2359         * symtab.c (iterate_over_symbols_terminated): New function.
2360         * symtab.c (iterate_over_symbols_terminated): Declare.
2361
2362 2019-09-10  Tom Tromey  <tromey@adacore.com>
2363
2364         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2365         * language.h (struct language_defn) <la_iterate_over_symbols>:
2366         Return bool.
2367         * symtab.c (iterate_over_symbols): Return bool.
2368         * symtab.h (iterate_over_symbols): Return bool.
2369
2370 2019-09-10  Tom Tromey  <tromey@adacore.com>
2371
2372         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2373         (add_nonlocal_symbols): Update.
2374         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2375         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2376         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2377         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2378         Change type of "callback".  Remove "data".
2379
2380
2381 2019-09-09  Ali Tamur  <tamur@google.com>
2382
2383         * dwarf2read.c (comp_unit_head): Update comment.
2384         (dwarf2_dwo_name): New function declaration.
2385         (dwarf_unit_type_name): New function declaration.
2386         (read_comp_unit_head): Add support for new compilation units,
2387         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2388         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2389         (currently named as "signature") in their header. Also clarify error
2390         messages.
2391         (lookup_dwo_id): New function. Returns the dwo id of the given
2392         compile unit.
2393         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2394         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2395         functions.
2396         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2397         (dwarf2_dwo_name): Get the dwo name if present.
2398         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2399         purposes.
2400
2401 2019-09-09  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2404
2405 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2406
2407         * python/python.c (do_start_initialization): Make progname_copy static,
2408         to avoid a leak report.
2409
2410 2019-09-08  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2413
2414 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2415
2416         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2417         Change type to gdb::optional<block_enum>.
2418         (dw2_symtab_iter_init): Change block_index parameter type
2419         to gdb::optional<block_enum>.
2420         (dw2_lookup_symbol): Change block_index parameter
2421         type to block_enum.c
2422         (dw2_debug_names_lookup_symbol): Likewise.
2423         * psymtab.c (psym_lookup_symbol): Likewise.
2424         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2425         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2426         Likewise.
2427
2428 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * defs.h (relocate_gdb_directory): Change int to bool in
2431         signature and rename flag to relocatable.
2432         * main.c (relocate_path): Likewise.
2433         (relocate_gdb_directory): Likewise.
2434
2435 2019-09-06  Alan Modra  <amodra@gmail.com>
2436
2437         * coffread.c (coff_symfile_read): Constify filename variable.
2438         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2439         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2440         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2441         * solib.c (reload_shared_libraries_1): Likewise.
2442         * symfile.c (reread_symbols): Likewise.
2443         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2444         * solib-darwin.c (darwin_bfd_open): Likewise.
2445         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2446
2447 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2450         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2451
2452 2019-09-03  Tom Tromey  <tromey@adacore.com>
2453
2454         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2455         types.
2456         (has_negatives): Unbias a range type bound.
2457         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2458         * gdbtypes.c (operator==): Handle new field.
2459         (create_range_type): Add "bias" parameter.
2460         (create_static_range_type, resolve_dynamic_range): Update.
2461         * gdbtypes.h (struct range_bounds) <bias>: New member.
2462         (create_range_type): Add bias parameter.
2463         * printcmd.c (print_scalar_formatted): Unbias range types.
2464         * value.c (unpack_long): Unbias range types.
2465         (pack_long): Bias range types.
2466
2467 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2468
2469         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2470         probe arguments.
2471
2472 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2473
2474         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2475         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2476         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2477         (compile_probe_arg): Likewise.
2478         * probe.h (get_argument_count): Likewise.
2479         * solib-svr4.c (solib_event_probe_action): Likewise.
2480         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2481
2482 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2483
2484         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2485         code to here...
2486         (svr4_create_solib_event_breakpoints): ...from here.
2487
2488 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2489
2490         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2491         suffix from warning message.
2492
2493 2019-08-30  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-winsource.h (struct tui_source_window_base)
2496         <refresh_all>: Don't declare.
2497         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2498         Remove.
2499         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2500         tui_show_locator_content.
2501         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2502         declare.
2503         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2504         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2505         declare.
2506
2507 2019-08-30  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2510
2511 2019-08-30  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2514         Remove unnecessary forward declarations.
2515
2516 2019-08-30  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2519         rerender.
2520         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2521         tui_show_locator_content.
2522
2523 2019-08-30  Tom Tromey  <tom@tromey.com>
2524
2525         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2526         (tui_locator_window::rerender): Rewrite using body of previous
2527         tui_show_locator_content.
2528
2529 2019-08-30  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2532         set_locator_fullname>: New methods.
2533         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2534         Rename from tui_set_locator_fullname.
2535         (tui_locator_window::set_locator_info): Rename from
2536         tui_set_locator_info.  Return bool.
2537         (tui_update_locator_fullname, tui_show_frame_info): Update.
2538
2539 2019-08-30  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2542
2543 2019-08-30  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2546         call touchwin.
2547
2548 2019-08-30  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-wingeneral.c (box_win): Assume win_info and
2551         win_info->handle cannot be NULL.
2552
2553 2019-08-30  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2556         refresh_window>: Declare.
2557         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2558         resize.
2559         (tui_data_item_window::rerender): Rename from
2560         tui_display_register.
2561         (tui_data_item_window::refresh_window): New method.
2562         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2563         no-op.
2564
2565 2019-08-30  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2568         regs_column_count, current_group>: Move later.  Now private.
2569         <get_current_group>: New method.
2570         * tui/tui-regs.c (tui_reg_command): Update.
2571         * tui/tui-layout.c (tui_set_layout): Update.
2572
2573 2019-08-30  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2576         (tui_data_window::rerender): Don't call
2577         check_and_display_highlight_if_needed.
2578         (tui_data_window::refresh_all): Remove call to
2579         erase_data_content.
2580
2581 2019-08-30  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2584         (tui_data_window::display_registers_from)
2585         (tui_data_window::display_reg_element_at_line)
2586         (tui_data_window::display_registers_from_line): Remove checks of
2587         "empty".
2588
2589 2019-08-30  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2592         Don't declare.
2593         * tui/tui-regs.c (tui_data_window::show_registers): Call
2594         rerender.
2595         (tui_data_window::rerender): Rename from display_all_data.
2596         (tui_data_window::rerender): Remove old implementation.
2597
2598 2019-08-30  Tom Tromey  <tom@tromey.com>
2599
2600         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2601         text.
2602         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2603
2604 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2605             Sergio Durigan Junior  <sergiodj@redhat.com>
2606
2607         PR win32/24284
2608         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2609
2610 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2613         when searching for types.
2614
2615 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2616
2617         * f-lang.c (f_language_defn): Use f_print_typedef.
2618         * f-lang.h (f_print_typedef): Declare.
2619         * f-typeprint.c (f_print_typedef): Define.
2620
2621 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2622
2623         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2624
2625 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * cli/cli-utils.c (info_print_options_defs): Delete.
2628         (make_info_print_options_def_group): Delete.
2629         (extract_info_print_options): Delete.
2630         (info_print_command_completer): Delete.
2631         (info_print_args_help): Add extra parameter, and optionally
2632         include text about -n flag.
2633         * cli/cli-utils.h (struct info_print_options): Delete.
2634         (extract_info_print_options): Delete declaration.
2635         (info_print_command_completer): Delete declaration.
2636         (info_print_args_help): Add extra parameter, extend header
2637         comment.
2638         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2639         search_symbols.
2640         * stack.c (struct info_print_options): New type.
2641         (info_print_options_defs): New file scoped variable.
2642         (make_info_print_options_def_group): New static function.
2643         (info_print_command_completer): New static function.
2644         (info_locals_command): Update to use new local functions.
2645         (info_args_command): Likewise.
2646         (_initialize_stack): Add extra parameter to calls to
2647         info_print_args_help.
2648         * symtab.c (search_symbols): Add extra parameter, use this to
2649         possibly excluse non-debug symbols.
2650         (symtab_symbol_info): Add extra parameter, which is passed on to
2651         search_symbols.
2652         (struct info_print_options): New type.
2653         (info_print_options_defs): New file scoped variable.
2654         (make_info_print_options_def_group): New static function.
2655         (info_print_command_completer): New static function.
2656         (info_variables_command): Update to use local functions, and pass
2657         extra parameter through to symtab_symbol_info.
2658         (info_functions_command): Likewise.
2659         (info_types_command): Pass additional argument through to
2660         symtab_symbol_info.
2661         (rbreak_command): Pass extra argument to search_symbols.
2662         (_initialize_symtab): Add extra arguments for calls to
2663         info_print_args_help, and update help text for 'info variables',
2664         'whereis', and 'info functions' commands.
2665         * symtab.h (search_symbols): Add extra argument to declaration.
2666         * NEWS: Mention new flags.
2667
2668 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2669
2670         * symtab.c (lookup_static_symbol): Call the new function (and move
2671         it down to be next to lookup_global_symbol).
2672         (struct global_sym_lookup_data): Add block_enum member and rename to...
2673         (struct global_or_static_sym_lookup_data): ...this.
2674         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2675         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2676         (lookup_symbol_global_or_static_iterator_cb): ...this.
2677         (lookup_global_or_static_symbol): New function.
2678         (lookup_global_symbol): Call new function.
2679
2680 2019-08-26  Tom de Vries  <tdevries@suse.de>
2681
2682         PR c++/24852
2683         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2684         when pc_probe.prob == NULL.
2685
2686 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2687
2688         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2689         variable symbol_linkage to symbol_linkage_.
2690
2691 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2692
2693         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2694         represent whether the symbol is static, dynamic, or we don't
2695         know.
2696
2697 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2698
2699         * gdb/rx-tdep.c (rx_register_names): New.
2700         (rx_register_name): Delete.
2701         (rx_psw_type): Delete.
2702         (rx_fpsw_type): Delete.
2703         (rx_register_type): Delete.
2704         (rx_gdbarch_init): Convert target-descriptions.
2705         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2706         * gdb/features/Makefile: Add rx.xml.
2707         * gdb/features/rx.xml: New.
2708         * gdb/features/rx.c: Generated.
2709         * gdb/NEWS: Mention target description support.
2710
2711 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2712
2713         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2714         *slot_ptr.
2715
2716 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2717
2718         * configure.ac: Don't check for 'dlfcn.h' (moved to
2719         gdbsupport/common.m4).
2720         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2721         'gdbsupport/'.
2722         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2723         * compile/compile-c-support.c: Include
2724         'gdbsupport/gdb-dlfcn.h'.
2725         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2726         * gdb-dlfcn.c: Move to...
2727         * gdbsupport/gdb-dlfcn.c: ... here.
2728         * gdb-dlfcn.h: Move to...
2729         * gdbsupport/gdb-dlfcn.h: ... here.
2730
2731 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2732
2733         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2734         the offset field signed.
2735
2736 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2737
2738         * python/lib/gdb/__init__.py (_execute_file): New function.
2739         * python/python.c (python_run_simple_file): Call gdb._execute_file
2740         on Windows.
2741
2742 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2745         all uses as this was never set to anything but a zero value.
2746
2747 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2748
2749         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2750
2751 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2752
2753         * tui/tui-data.h (tui_gen_win_info): Add an =default
2754         move constructor, required by some GCC versions.
2755
2756 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2757
2758         * go32-nat.c (go32_sysinfo): Add hygon_p.
2759
2760 2019-08-20  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2763         line_from_reg_element_no, first_reg_element_no_inline,
2764         display_all_data, delete_data_content_windows,
2765         erase_data_content>: Now private.
2766
2767 2019-08-20  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2770         (tui_unhighlight_win, tui_highlight_win)
2771         (tui_win_info::make_window): Update.
2772         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2773
2774 2019-08-20  Tom Tromey  <tom@tromey.com>
2775
2776         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2777         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2778         (MAX_PID_WIDTH): Move to tui-stack.c.
2779         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2780         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2781         (MAX_PID_WIDTH): Move from tui-data.h.
2782
2783 2019-08-20  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2786         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2787         (box_win): Update.
2788         (tui_gen_win_info::make_window): Rename from tui_make_window.
2789         (tui_win_info::make_window): New method.
2790         (tui_gen_win_info::make_visible): Update.
2791         * tui/tui-source.c (tui_source_window::set_contents): Update.
2792         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2793         (tui_data_window::display_registers_from): Update.
2794         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2795         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2796         Declare.
2797         <can_box>: Remove.
2798         <title>: Remove.
2799         (struct tui_win_info) <make_window>: Declare.
2800         <can_box>: Now virtual.
2801         <title>: New member.
2802         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2803         * tui/tui-command.c (tui_cmd_window::resize): Update.
2804
2805 2019-08-20  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2808         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2809         (tui_data_window::check_register_values): Update.
2810
2811 2019-08-20  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-regs.h (struct tui_data_window): Use
2814         DISABLE_COPY_AND_ASSIGN.
2815         <regs_content>: Change type, removing unique_ptr.
2816         <tui_data_window>: Add move constructor.
2817         * tui/tui-regs.c (tui_data_window::show_registers)
2818         (tui_data_window::show_register_group)
2819         (tui_data_window::display_registers_from)
2820         (tui_data_window::display_registers_from)
2821         (tui_data_window::first_data_item_displayed)
2822         (tui_data_window::delete_data_content_windows)
2823         (tui_data_window::rerender, tui_data_window::refresh_window)
2824         (tui_data_window::check_register_values): Update.
2825
2826 2019-08-20  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2829         show_register_group>: Declare.
2830         (tui_show_register_group): Don't declare.
2831         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2832         tui_show_registers.
2833         (tui_data_window::show_register_group): Rename from
2834         tui_show_register_group.
2835         (tui_data_window::check_register_values, tui_reg_command):
2836         Update.
2837         * tui/tui-layout.c (tui_set_layout): Update.
2838
2839 2019-08-20  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2842         Declare.
2843         (tui_check_register_values): Don't declare.
2844         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2845         from tui_check_register_values.
2846         * tui/tui-hooks.c (tui_register_changed): Update.
2847
2848 2019-08-20  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui-regs.c (tui_reg_layout): Move later.
2851         (tui_show_registers): Don't enable TUI mode or change layout.
2852
2853 2019-08-20  Tom Tromey  <tom@tromey.com>
2854
2855         * tui/tui-regs.h (struct tui_data_item_window)
2856         <~tui_data_item_window>: Remove.
2857         <content>: Now a unique_xmalloc_ptr.
2858         * tui/tui-regs.c (tui_register_format): Return a
2859         unique_xmalloc_ptr.
2860         (tui_get_register): Update.
2861         (~tui_data_item_window): Remove.
2862         (tui_data_window::display_registers_from, tui_display_register):
2863         Update.
2864         * tui/tui-io.h (tui_expand_tabs): Update.
2865         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2866         Remove "col" parameter.
2867
2868 2019-08-20  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2871         field.
2872         * tui/tui-regs.c (~tui_data_item_window): Update.
2873
2874 2019-08-20  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2877         earlier.
2878
2879 2019-08-20  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2882
2883 2019-08-20  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-source.h (struct tui_source_window): Update.
2886         * tui/tui-regs.c (tui_show_registers): Update.
2887         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2888         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2889         (NO_REGS_STRING): Remove defines.
2890
2891 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2892
2893         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2894         unnecessary thread walk if remote doesn't support the packet.
2895
2896 2019-08-19  Tom Tromey  <tromey@adacore.com>
2897
2898         * python/py-value.c (value_has_field): Fix indentation.
2899
2900 2019-08-19  Tom Tromey  <tromey@adacore.com>
2901
2902         * printcmd.c (do_one_display, info_display_command): Update.
2903         * block.h (contained_in): Return bool.  Add allow_nested
2904         parameter.
2905         * block.c (contained_in): Return bool.  Add allow_nested
2906         parameter.
2907
2908 2019-08-19  Tom Tromey  <tom@tromey.com>
2909
2910         * configure: Rebuild.
2911         * configure.ac: Disallow the combination of -static-libstdc++ and
2912         source highlight.
2913         * source-cache.c (get_language_name): Handle rust.
2914         (source_cache::get_source_lines): Ignore highlighting exceptions.
2915
2916 2019-08-16  Tom Tromey  <tom@tromey.com>
2917
2918         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2919         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2920         (struct tui_source_window_base) <make_visible, refresh_window,
2921         resize>: Remove methods.
2922         <execution_info>: Remove field.
2923         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2924         (tui_show_source_line, tui_source_window_base)
2925         (~tui_source_window_base): Update.
2926         (tui_source_window_base::resize)
2927         (tui_source_window_base::make_visible)
2928         (tui_source_window_base::refresh_window): Remove.
2929         (tui_source_window_base::update_exec_info): Update.
2930         * tui/tui-source.c (tui_source_window::set_contents): Update.
2931         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2932
2933 2019-08-16  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2936         deprecated_query_hook.
2937
2938 2019-08-16  Tom Tromey  <tom@tromey.com>
2939
2940         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2941         (tui_update_source_windows_with_line): Update.
2942         * tui/tui-source.h (struct tui_source_window)
2943         <show_symtab_source>: Declare.
2944         (tui_show_symtab_source): Don't declare.
2945         * tui/tui-source.c (tui_show_symtab_source): Rename from
2946         tui_show_symtab_source.
2947
2948 2019-08-16  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-winsource.h (struct tui_source_window_base)
2951         <set_contents>: Declare.
2952         * tui/tui-winsource.c
2953         (tui_source_window_base::update_source_window_as_is): Update.
2954         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2955         Declare.
2956         (tui_set_source_content): Don't declare.
2957         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2958         tui_set_source_content.
2959         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2960         Declare.
2961         (tui_set_disassem_content): Don't declare.
2962         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2963         tui_set_disassem_content.
2964
2965 2019-08-16  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-winsource.h (struct tui_source_window_base)
2968         <update_breakpoint_info>: Declare.
2969         (tui_update_breakpoint_info): Don't declare.
2970         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2971         (tui_update_all_breakpoint_info): Update.
2972         (tui_source_window_base::update_breakpoint_info): Rename from
2973         tui_update_breakpoint_info.
2974         (tui_source_window_base::update_exec_info): Update.
2975
2976 2019-08-16  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-winsource.h (struct tui_source_window_base)
2979         <update_source_window>: Declare.
2980         (tui_update_source_window): Don't declare.
2981         * tui/tui-winsource.c
2982         (tui_source_window_base::update_source_window): Rename from
2983         tui_update_source_window.
2984         (tui_source_window_base::rerender): Update.
2985         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2986         * tui/tui-disasm.c (tui_show_disassem)
2987         (tui_show_disassem_and_update_source)
2988         (tui_disasm_window::maybe_update): Update.
2989
2990 2019-08-16  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-winsource.h (struct tui_source_window_base)
2993         <update_source_window_as_is>: Declare.
2994         (tui_update_source_window_as_is): Don't declare.
2995         * tui/tui-winsource.c (tui_update_source_window): Update
2996         (tui_source_window_base::update_source_window_as_is): Rename from
2997         tui_update_source_window_as_is.
2998         (tui_source_window_base::refill): Update.
2999         * tui/tui-source.c (tui_show_symtab_source): Update.
3000         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3001         Update.
3002
3003 2019-08-16  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-winsource.h (tui_update_source_window)
3006         (tui_update_source_window_as_is): Remove "noerror" parameter.
3007         * tui/tui-winsource.c (tui_update_source_window)
3008         (tui_update_source_window_as_is): Remove "noerror" parameter.
3009         (tui_update_source_windows_with_addr)
3010         (tui_update_source_windows_with_line)
3011         (tui_source_window_base::rerender)
3012         (tui_source_window_base::refill): Update.
3013         * tui/tui-source.h (tui_set_source_content)
3014         (tui_show_symtab_source): Remove "noerror" parameter.
3015         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3016         parameter.
3017         (tui_show_symtab_source): Likewise.
3018         (tui_source_window::maybe_update): Update.
3019         * tui/tui-disasm.c (tui_show_disassem)
3020         (tui_show_disassem_and_update_source)
3021         (tui_disasm_window::do_scroll_vertical)
3022         (tui_disasm_window::maybe_update): Update.
3023
3024 2019-08-16  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui.c (tui_is_window_visible): Update.
3027         * tui/tui-wingeneral.c (tui_make_window)
3028         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3029         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3030         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3031         (tui_set_win_height_command, parse_scrolling_args): Update.
3032         * tui/tui-source.c (tui_source_window::style_changed): Update.
3033         * tui/tui-regs.c (tui_show_registers)
3034         (tui_data_window::first_data_item_displayed)
3035         (tui_data_window::delete_data_content_windows)
3036         (tui_check_register_values, tui_reg_command): Update.
3037         * tui/tui-disasm.c (tui_show_disassem): Update.
3038         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3039         method.
3040         <is_visible>: Remove field.
3041         * tui/tui-data.c (tui_next_win, tui_prev_win)
3042         (tui_delete_invisible_windows): Update.
3043
3044 2019-08-16  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-winsource.h (struct tui_source_window_base)
3047         <m_has_locator>: Remove.
3048         * tui/tui-layout.c (show_source_disasm_command, show_data)
3049         (show_source_or_disasm_and_command): Update.
3050
3051 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3052
3053         * NEWS (Other MI changes): New subsection.
3054         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3055         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3056         * arch-utils.c (default_get_pc_address_flags): New function.
3057         * arch-utils.h (default_get_pc_address_flags): New declaration.
3058         * gdbarch.sh: Add get_pc_address_flags.
3059         * gdbarch.c: Regenerate.
3060         * gdbarch.h: Likewise.
3061         * stack.c (print_pc): New function.
3062         (print_frame_info) (print_frame): Call print_pc.
3063
3064 2019-08-16  Tom de Vries  <tdevries@suse.de>
3065
3066         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3067         print_objfile_section_info.
3068
3069 2019-08-15  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3072         calling update_cmdwin_start_line.
3073         * tui/tui-winsource.h (struct tui_source_window_base)
3074         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3075         <rerender>: Declare.
3076         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3077         Call rerender.
3078         (tui_source_window_base::set_new_height): Remove.
3079         (tui_source_window_base::rerender): Rename from
3080         do_make_visible_with_new_height.
3081         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3082         resize method.
3083         (tui_win_info::make_invisible_and_set_new_height)
3084         (tui_win_info::make_visible_with_new_height): Remove.
3085         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3086         Declare.
3087         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3088         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3089         do_make_visible_with_new_height>: Don't declare.
3090         <rerender>: Declare.
3091         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3092         set_new_height.
3093         (tui_data_window::do_make_visible_with_new_height): Remove.
3094         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3095         call tui_show_locator_content.
3096         (tui_gen_win_info::resize): Call rerender.
3097         (show_source_or_disasm_and_command): Don't call
3098         tui_show_locator_content.
3099         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3100         method.
3101         (struct tui_win_info) <rerender>: Declare.
3102         <set_new_height, make_invisible_and_set_new_height,
3103         make_visible_with_new_height>: Don't declare.
3104         * tui/tui-data.c (tui_win_list::rerender): New method.
3105         * tui/tui-command.h (struct tui_cmd_window)
3106         <do_make_visible_with_new_height>: Don't declare.
3107         * tui/tui-command.c
3108         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3109
3110 2019-08-15  Tom Tromey  <tromey@adacore.com>
3111
3112         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3113         * ada-lang.c (ada_enum_name): Likewise.
3114
3115 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3116
3117         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3118         leading underscore.
3119         (GdbOutputErrorFile): Likewise.
3120         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3121         accordingly.
3122         (execute_unwinders): Rename to have a leading underscore.
3123         (auto_load_packages): Likewise.
3124         (global scope): Adjust call to auto_load_packages accordingly.
3125         (GdbSetPythonDirectory): Likewise.
3126         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3127         instead of execute_unwinders.
3128
3129 2019-08-15  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3132         (show_data): Don't change window visibility.
3133         (tui_gen_win_info::resize): Remove special case for command
3134         window.  Use wresize, when available.
3135         (show_source_or_disasm_and_command): Don't change window
3136         visibility.
3137         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3138         <make_visible>: New method.
3139         * tui/tui-command.c (tui_cmd_window::resize): New method.
3140
3141 2019-08-15  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3144         (struct tui_source_windows): New.
3145         * tui/tui-winsource.c (tui_display_main): Update.
3146         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3147         (new_height_ok, parse_scrolling_args): Update.
3148         * tui/tui-layout.c (show_layout, show_data): Update.
3149         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3150         (tui_add_to_source_windows): Don't declare.
3151         * tui/tui-data.c (source_windows, tui_source_windows)
3152         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3153
3154 2019-08-15  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3157         Rename from reset.
3158         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3159         * tui/tui-layout.c (show_source_disasm_command, show_data):
3160         Update.
3161         (tui_gen_win_info::resize): Rename.
3162         (show_source_or_disasm_and_command): Update.
3163         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3164         reset.
3165
3166 2019-08-15  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3169         * tui/tui-interp.c (tui_interp::init): Don't call
3170         tui_initialize_static_data.
3171         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3172
3173 2019-08-15  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3176         examine tui_win_list.
3177
3178 2019-08-15  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3181         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3182         tui_clear_source_content.
3183         (tui_clear_source_content): Remove.
3184         (tui_source_window_base::do_erase_source_content): Hoist call to
3185         content.clear().
3186         * tui/tui-stack.c (tui_show_frame_info): Don't call
3187         tui_clear_source_content.
3188
3189 2019-08-15  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-winsource.h (struct tui_source_window_base)
3192         <do_erase_source_content>: New method.
3193         <erase_source_content>: New method.
3194         (tui_erase_source_content): Don't declare.
3195         * tui/tui-winsource.c (tui_clear_source_content): Update.
3196         (tui_source_window_base::do_erase_source_content): Rename from
3197         tui_erase_source_content.
3198         (tui_source_window_base::show_source_content): Update.
3199         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3200         * tui/tui-source.h (struct tui_source_window)
3201         <erase_source_content>: New method.
3202         * tui/tui-disasm.h (struct tui_disasm_window)
3203         <erase_source_content>: New method.
3204
3205 2019-08-15  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3208         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3209         constructor.
3210         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3211         * tui/tui-source.c (tui_set_source_content): Update.
3212         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3213
3214 2019-08-15  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3217         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3218         tui-source.c.
3219         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3220         Declare.
3221         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3222         method.
3223         (tui_source_window::maybe_update): Update.
3224
3225 2019-08-15  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3228         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3229         tui-disasm.c.
3230         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3231         Declare.
3232         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3233         method.
3234         (tui_disasm_window::maybe_update): Update.
3235
3236 2019-08-15  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-winsource.h (struct tui_source_window_base)
3239         <maybe_update>: Declare.
3240         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3241         method.
3242         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3243         Declare.
3244         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3245         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3246         Declare.
3247         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3248
3249 2019-08-15  Tom Tromey  <tom@tromey.com>
3250
3251         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3252
3253 2019-08-15  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-wingeneral.c: Include tui-stack.h.
3256         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3257         (struct tui_locator_window): Move from tui-data.h.
3258         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3259         (tui_initialize_static_data): Move from tui-data.c.
3260         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3261         (struct tui_locator_window): Move to tui-stack.c.
3262         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3263         (tui_initialize_static_data): Move to tui-stack.c.
3264
3265 2019-08-15  Tom Tromey  <tom@tromey.com>
3266
3267         * tui/tui-layout.c (show_source_disasm_command)
3268         (show_source_or_disasm_and_command): Use make_visible method, not
3269         tui_make_window.
3270         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3271         Remove.
3272
3273 2019-08-15  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-wingeneral.h (tui_make_window): Update.
3276         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3277         parameter.
3278         (tui_gen_win_info::make_visible): Update.
3279         * tui/tui-regs.c (tui_data_window::display_registers_from):
3280         Update.
3281         * tui/tui-layout.c (show_source_disasm_command)
3282         (show_source_or_disasm_and_command): Update.
3283         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3284         (enum tui_box): Remove.
3285         (struct tui_win_info) <can_box>: New method.
3286         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3287         method.
3288
3289 2019-08-15  Tom de Vries  <tdevries@suse.de>
3290
3291         * linux-nat-trad.c: Include gdbarch.h.
3292
3293 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3294
3295         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3296         register sizes.
3297
3298 2019-08-14  Tom Tromey  <tromey@adacore.com>
3299
3300         * darwin-nat.c: Include gdbarch.h.
3301         * darwin-nat-info.c: Include gdbarch.h.
3302
3303 2019-08-13  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3306         Remove.
3307         * tui/tui-data.c (tui_initialize_static_data): Update.
3308
3309 2019-08-13  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-winsource.h (struct tui_exec_info_window)
3312         <~tui_exec_info_window, maybe_allocate_content, get_content,
3313         m_content>: Remove.
3314         (struct tui_source_window_base) <set_exec_info_content,
3315         show_exec_info_content>: Don't declare.
3316         * tui/tui-winsource.c
3317         (tui_exec_info_window::maybe_allocate_content): Remove.
3318         (tui_source_window_base::update_exec_info): Rename from
3319         set_exec_info_content.
3320         (tui_source_window_base::show_exec_info_content)
3321         (tui_source_window_base::update_exec_info): Remove.
3322
3323 2019-08-13  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3326         declare.
3327         * tui/tui-winsource.c (tui_update_source_window_as_is)
3328         (tui_update_source_windows_with_addr, tui_erase_source_content):
3329         Update.
3330         (tui_clear_exec_info_content): Remove.
3331
3332 2019-08-13  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3335         declare.
3336         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3337         call tui_erase_exec_info_content.
3338         (tui_clear_exec_info_content): Rename from
3339         tui_erase_exec_info_content.
3340         (tui_clear_exec_info_content): Delete.
3341
3342 2019-08-13  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-winsource.h (struct tui_source_window_base)
3345         <show_exec_info_content>: Declare.
3346         (tui_show_exec_info_content): Don't declare.
3347         * tui/tui-winsource.c
3348         (tui_source_window_base::show_exec_info_content): Rename from
3349         tui_show_exec_info_content.
3350         (tui_source_window_base::update_exec_info): Update.
3351
3352 2019-08-13  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3355         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3356         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3357         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3358         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3359         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3360         ... here.
3361
3362 2019-08-13  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-winsource.h (struct tui_source_window_base)
3365         <update_exec_info>: Declare.
3366         (tui_update_exec_info): Don't declare.
3367         * tui/tui-winsource.c (tui_update_source_window_as_is)
3368         (tui_source_window_base::refresh_all)
3369         (tui_update_all_breakpoint_info): Update.
3370         (tui_source_window_base::update_exec_info): Rename from
3371         tui_update_exec_info.
3372         * tui/tui-stack.c (tui_show_frame_info): Update.
3373
3374 2019-08-13  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-winsource.h (struct tui_source_window_base)
3377         <set_exec_info_content>: Declare.
3378         (tui_set_exec_info_content): Don't declare.
3379         * tui/tui-winsource.c
3380         (tui_source_window_base::set_exec_info_content): Rename from
3381         tui_set_exec_info_content.
3382         (tui_update_exec_info): Update.
3383
3384 2019-08-13  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-winsource.h (struct tui_source_window_base)
3387         <show_source_content>: Declare.
3388         (tui_show_source_content): Don't declare.
3389         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3390         (tui_source_window_base::show_source_content): Rename from
3391         tui_show_source_content.
3392         (tui_source_window_base::refresh_all): Update.
3393         * tui/tui-layout.c (show_source_disasm_command)
3394         (show_source_or_disasm_and_command): Update.
3395
3396 2019-08-13  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-winsource.c (tui_erase_source_content)
3399         (tui_show_source_content, tui_source_window_base::refresh_all):
3400         Update.
3401         * tui/tui-wingeneral.h
3402         (tui_check_and_display_highlight_if_needed): Don't declare.
3403         * tui/tui-wingeneral.c
3404         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3405         check_and_display_highlight_if_needed.
3406         * tui/tui-win.c (tui_rehighlight_all)
3407         (tui_win_info::make_visible_with_new_height): Update.
3408         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3409         (tui_data_window::erase_data_content)
3410         (tui_data_window::display_all_data): Update.
3411         * tui/tui-data.h (struct tui_win_info)
3412         <check_and_display_highlight_if_needed>: Declare.
3413
3414 2019-08-13  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-win.c (tui_resize_all): Call
3417         tui_delete_invisible_windows.
3418         * tui/tui-layout.c (show_layout): Call
3419         tui_delete_invisible_windows.
3420         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3421         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3422
3423 2019-08-13  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3426         tui_add_win_to_layout.
3427
3428 2019-08-13  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3431         * tui/tui-layout.c (tui_default_win_height): Now static.
3432
3433 2019-08-13  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3436         single switch.
3437         (show_source_disasm_command, show_source_or_disasm_and_command):
3438         Don't check current layout.
3439
3440 2019-08-13  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-wingeneral.c (make_all_visible): Remove.
3443         (tui_make_all_invisible): Simplify.
3444         * tui/tui-layout.c (tui_make_all_invisible): Move from
3445         tui-wingeneral.c; simplify.
3446         (show_layout): Hoist call to tui_make_all_invisible.
3447         (show_data): Don't call tui_make_all_invisible.
3448
3449 2019-08-13  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3452         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3453
3454 2019-08-13  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3457         tui-data.c.
3458         (show_source_disasm_command, show_data)
3459         (show_source_or_disasm_and_command): Don't use
3460         tui_set_current_layout_to.
3461         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3462         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3463         tui-layout.c.
3464         (tui_set_current_layout_to): Remove.
3465
3466 2019-08-13  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-layout.c (tui_set_layout): Update.
3469         * tui/tui-data.h (struct tui_layout_def): Remove.
3470         (tui_layout_def): Don't declare.
3471         * tui/tui-data.c (layout_def): Remove.
3472         (tui_layout_def): Remove.
3473
3474 2019-08-13  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-winsource.h (struct tui_source_window_base)
3477         <clear_detail>: No longer "override".
3478         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3479         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3480         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3481         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3482         Remove.
3483         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3484
3485 2019-08-13  Tom Tromey  <tromey@adacore.com>
3486
3487         * tracepoint.c: Don't include readline.h or history.h.
3488
3489 2019-08-12  Tom Tromey  <tom@tromey.com>
3490
3491         * configure: Rebuild.
3492         * configure.ac: Check for readline 7.
3493         * NEWS: Mention readline 7 requirement.
3494         * README: Update.
3495
3496 2019-08-12  Tom Tromey  <tom@tromey.com>
3497
3498         * mingw-hdep.c (gdb_select): Remove readline hack.
3499
3500 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3501
3502         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3503         when the function fails.
3504
3505 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3506
3507         * s390-tdep.c (s390_type_align): New function.
3508         (s390_gdbarch_init): Set it as type_align gdbarch method.
3509
3510 2019-08-09  Tom de Vries  <tdevries@suse.de>
3511
3512         PR gdb/24591
3513         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3514         pc_low with relocation offset.
3515
3516 2019-08-07  Tom Tromey  <tromey@adacore.com>
3517
3518         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3519         (print_frame_args): Update.
3520         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3521         Update.
3522         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3523         * frame.h (struct frame_arg): Add initializers.
3524         <error>: Now a unique_xmalloc_ptr.
3525
3526 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3527
3528         * NEWS: Expand the Pointer Authentication entry.
3529         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3530         (aarch64_frame_unmask_lr): ... to this.
3531         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3532         Call aarch64_frame_unmask_lr.
3533         * frame.c (struct frame_info): Add "masked" variable.
3534         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3535         (fprint_frame): Check for masked pc.
3536         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3537         declarations.
3538         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3539         * stack.c (print_frame): Check for masked pc.
3540
3541 2019-08-06  Tom Tromey  <tom@tromey.com>
3542
3543         * stabsread.c (patch_block_stabs, read_one_struct_field)
3544         (read_enum_type): Use obstack_strndup.
3545         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3546         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3547         * dwarf2read.c (guess_full_die_structure_name)
3548         (anonymous_struct_prefix): Use obstack_strndup.
3549         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3550         * c-exp.y (yylex): Use obstack_strndup.
3551         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3552         (write_var_or_type): Use obstack_strndup.
3553
3554 2019-08-06  Tom Tromey  <tom@tromey.com>
3555
3556         * symfile.c (reread_symbols): Use obstack_strdup.
3557         * stabsread.c (read_type): Use obstack_strdup.
3558         * gdb_obstack.h (obstack_strdup): New overload.
3559         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3560         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3561         (dwarf2_canonicalize_name): Use obstack_strdup.
3562         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3563         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3564         Use obstack_strdup.
3565
3566 2019-08-06  Tom Tromey  <tom@tromey.com>
3567
3568         * gdb_obstack.h (obstack_strdup): Define.
3569         * gdb_obstack.c (obstack_strdup): Don't define.
3570
3571 2019-08-06  Tom Tromey  <tom@tromey.com>
3572
3573         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3574         obstack_strdup.
3575         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3576         obstack_strdup.
3577         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3578         * stabsread.c (common_block_start): Use obstack_strdup.
3579         * objfiles.c (set_objfile_main_name, objfile): Use
3580         obstack_strdup.
3581         * namespace.c (add_using_directive): Use obstack_strdup.
3582         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3583         * jit.c (finalize_symtab): Use obstack_strdup.
3584         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3585         (guess_partial_die_structure_name, partial_die_info::fixup)
3586         (dwarf2_name): Use obstack_strdup.
3587         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3588         obstack_strdup.
3589         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3590         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3591         obstack_strdup.
3592         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3593
3594 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * unittests/help-doc-selftests.c: New file.
3597         * Makefile.in: Add the new file.
3598
3599 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3602         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3603         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3604         the trailing '.' is not output, and the first character is uppercased.
3605         (print_help_for_command): Update call to print_doc_line.
3606         (print_doc_of_command): Likewise.
3607         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3608         * cli/cli-option.c (append_indented_doc): Do not append newline.
3609         (build_help_option): Append newline after first appended_indented_doc
3610         only if a second call is done.
3611         (build_help): Append 2 new lines before each option, except the first
3612         one.
3613         * compile/compile.c (_initialize_compile): Add new lines after
3614         %OPTIONS%, when not at the end of the help.
3615         Change help doc or code
3616         producing the help doc to respect the invariants.
3617         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3618         Also removed the new line after 'Options:', as all other commands
3619         do not put an empty line between 'Options:' and the first option.
3620         * printcmd.c (_initialize_printcmd): Likewise.
3621         * stack.c (_initialize_stack): Likewise.
3622         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3623         incorrectly telling COMMAND is optional.
3624         * ada-lang.c (_initialize_ada_language): Change help doc or code
3625         producing the help doc to respect the invariants.
3626         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3627         * breakpoint.c (_initialize_breakpoint): Likewise.
3628         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3629         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3630         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3631         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3632         _initialize_cli_style): Likewise.
3633         * corelow.c (core_target_info): Likewise.
3634         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3635         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3636         * filesystem.c (_initialize_filesystem): Likewise.
3637         * frame.c (_initialize_frame): Likewise.
3638         * gnu-nat.c (add_task_commands): Likewise.
3639         * infcall.c (_initialize_infcall): Likewise.
3640         * infcmd.c (_initialize_infcmd): Likewise.
3641         * interps.c (_initialize_interpreter): Likewise.
3642         * language.c (_initialize_language): Likewise.
3643         * linux-fork.c (_initialize_linux_fork): Likewise.
3644         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3645         * maint.c (_initialize_maint_cmds): Likewise.
3646         * memattr.c (_initialize_mem): Likewise.
3647         * printcmd.c (_initialize_printcmd): Likewise.
3648         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3649         _RegEx): Likewise.
3650         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3651         * record-btrace.c (_initialize_record_btrace): Likewise.
3652         * record-full.c (_initialize_record_full): Likewise.
3653         * record.c (_initialize_record): Likewise.
3654         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3655         * regcache.c (_initialize_regcache): Likewise.
3656         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3657         _initialize_remote): Likewise.
3658         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3659         * serial.c (_initialize_serial): Likewise.
3660         * skip.c (_initialize_step_skip): Likewise.
3661         * source.c (_initialize_source): Likewise.
3662         * stack.c (_initialize_stack): Likewise.
3663         * symfile.c (_initialize_symfile): Likewise.
3664         * symtab.c (_initialize_symtab): Likewise.
3665         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3666         * top.c (init_main): Likewise.
3667         * tracefile-tfile.c (tfile_target_info): Likewise.
3668         * tracepoint.c (_initialize_tracepoint): Likewise.
3669         * tui/tui-win.c (_initialize_tui_win): Likewise.
3670         * utils.c (add_internal_problem_command): Likewise.
3671         * valprint.c (value_print_option_defs): Likewise.
3672
3673 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3674
3675         PR build/24886
3676         * configure.ac: Drop enable-libmcheck support.
3677         * configure, config.in: Rebuild.
3678         * libmcheck.m4: Remove.
3679         * acinclude.m4: Don't include it.
3680         * Makefile.in: Don't distribute it.
3681         * top.c (print_gdb_configuration): Don't mention it.
3682
3683 2019-08-06  Tom Tromey  <tom@tromey.com>
3684
3685         * utils.c (set_output_style): Sometimes pass stream to
3686         emit_style_escape.
3687         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3688         * record-btrace.c (btrace_insn_history): Update.
3689         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3690         method.
3691         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3692         Update initializers.
3693         <m_uiout>: New field.
3694         <m_di>: Move lower.
3695         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3696         Remove "uiout" parameter.
3697         (dump_insns): Update.
3698         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3699         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3700
3701 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3702
3703         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3704         (error_in_psymtab_expansion): Likewise.
3705         (lookup_symbol_via_quick_fns): Likewise.
3706         (basic_lookup_transparent_type_quick): Likewise.
3707         (basic_lookup_transparent_type_1): Likewise.
3708
3709 2019-08-06  Tom Tromey  <tromey@adacore.com>
3710
3711         * source.c (last_source_error): Now bool.
3712         (print_source_lines_base): Make "noprint" bool.  Only open
3713         source file when last_source_visited changes.
3714
3715 2019-08-06  Tom Tromey  <tromey@adacore.com>
3716
3717         * annotate.c (annotate_source_line): Use g_source_cache.
3718         * source-cache.c (source_cache::get_plain_source_lines): Change
3719         parameters.  Populate m_offset_cache.
3720         (source_cache::ensure): New method.
3721         (source_cache::get_line_charpos): New method.
3722         (extract_lines): Move lower.  Change parameters.
3723         (source_cache::get_source_lines): Move lower.
3724         * source-cache.h (class source_cache): Update comment.
3725         <get_line_charpos>: New method.
3726         <get_source_lines>: Update comment.
3727         <clear>: Clear m_offset_cache.
3728         <get_plain_source_lines>: Change parameters.
3729         <ensure>: New method
3730         <m_offset_cache>: New member.
3731         * source.c (forget_cached_source_info_for_objfile): Update.
3732         (info_source_command): Use g_source_cache.
3733         (find_source_lines, open_source_file_with_line_charpos): Remove.
3734         (print_source_lines_base, search_command_helper): Use g_source_cache.
3735         * source.h (open_source_file_with_line_charpos): Don't declare.
3736         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3737         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3738         Use g_source_cache.
3739
3740 2019-08-06  Tom Tromey  <tromey@adacore.com>
3741
3742         * source-cache.c (source_cache::get_plain_source_lines):
3743         Remove "first_line" and "last_line" parameters.
3744         (source_cache::get_source_lines): Cache plain text.
3745         * source-cache.h (class source_cache)
3746         <get_plain_source_lines>: Update.
3747
3748 2019-08-06  Tom Tromey  <tromey@adacore.com>
3749
3750         * source-cache.c (extract_lines): No longer a method.
3751         Changed type of parameter.  Include final newline.
3752         (selftests::extract_lines_test): New function.
3753         (_initialize_source_cache): Likewise.
3754         * source-cache.h (class source_cache)
3755         <extract_lines>: Don't declare.
3756
3757 2019-08-06  Tom Tromey  <tromey@adacore.com>
3758
3759         * breakpoint.c (init_breakpoint_sal): Update.
3760         (breakpoint): Update.
3761         * breakpoint.h (struct breakpoint) <filter>: Now a
3762         unique_xmalloc_ptr.
3763
3764 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3765
3766         * NEWS: Mention dictionary access on blocks.
3767         * python/py-block.c (blpy_getitem): New function.
3768         (block_object_as_mapping): New struct.
3769         (block_object_type): Use new struct for tp_as_mapping field.
3770
3771 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3772
3773         * objfiles.h (objfile): Add a comment describing partial symbols.
3774
3775 2019-08-05  Tom Tromey  <tromey@adacore.com>
3776
3777         * compile/compile.c (_initialize_compile): Use _(), not N_().
3778         * thread.c (_initialize_thread): Use _(), not N_().
3779         * stack.c (_initialize_stack): Use _(), not N_().
3780         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3781
3782 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3783
3784         * dwarf2read.c (struct dw2_symtab_iterator):
3785         <want_specific_block>: Remove.
3786         <block_index>: Change type to gdb::optional.
3787         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3788         change type of BLOCK_INDEX parameter to gdb::optional.
3789         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3790         (dw2_lookup_symbol): Don't pass argument for
3791         WANT_SPECIFIC_BLOCK.
3792         (dw2_expand_symtabs_for_function): Don't pass argument for
3793         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3794         (class dw2_debug_names_iterator)
3795         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3796         parameter, change BLOCK_INDEX type to gdb::optional.
3797         <m_want_specific_block>: Remove.
3798         <m_block_index>: Change type to gdb::optional.
3799         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3800         gdb::optional.  Re-write in function of gdb::optional.
3801         (dw2_debug_names_lookup_symbol): Don't pass argument for
3802         WANT_SPECIFIC_BLOCK.
3803         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3804         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3805         BLOCK_INDEX.
3806
3807 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3808
3809         * NEWS: Mention changes to "info sources" command.
3810
3811 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3812
3813         * symtab.c (filename_partial_match_opts): New struct type.
3814         (struct output_source_filename_data): New members
3815         regexp, c_regexp, partial_match.
3816         (output_source_filename): Use new members to decide to print file.
3817         (info_sources_option_defs): New variable.
3818         (make_info_sources_options_def_group, print_info_sources_header,
3819         info_sources_command_completer):
3820         New functions.
3821         (info_sources_command): Read new optional arguments.
3822         (_initialize_symtab): Update info sources help.
3823
3824 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3825
3826         * ada-lang.c (exception_support_info_v0): Renamed from...
3827         (default_exception_support_info): ... this.  Create new
3828         definition for v1.
3829         (ada_has_this_exception_support): Look up catch_handlers_sym.
3830         (ada_exception_support_info_sniffer): Try v0 after default.
3831
3832 2019-08-01  Tom Tromey  <tromey@adacore.com>
3833
3834         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3835         gdbarch.h.
3836
3837 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3838
3839         * s12z-tdep.c: Fix include path for s12z-opc.h.
3840
3841 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3842
3843         * NEWS: Require GNU make 3.82.
3844
3845 2019-07-16  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3848         declare.
3849
3850 2019-07-30  Tom Tromey  <tromey@adacore.com>
3851
3852         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3853
3854 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3855
3856         * printcmd.c (print_address_symbolic): Print negative offsets.
3857         (build_address_symbolic): Force signed arithmetic when computing
3858         offset.
3859
3860 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3861
3862         PR/24474: Add a function to lookup static variables.
3863         * NEWS: Mention this new function.
3864         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3865         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3866         * python/python.c (python_GdbMethods): Add new function.
3867
3868 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3869
3870         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3871         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3872         (objfpy_lookup_static_symbol): New function.
3873         (objfile_object_methods): Add new functions.
3874
3875 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3876
3877         * NEWS: Mention 'set|show print frame-info'.  Mention new
3878         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3879         backtrace argument.  Mention that python frame filtering code
3880         is now consistent with what 'backtrace' command prints.
3881
3882 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3883
3884         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3885         comments.
3886         (print_frame_info_auto, print_frame_info_source_line,
3887         print_frame_info_location, print_frame_info_source_and_location,
3888         print_frame_info_location_and_address, print_frame_info_short_location):
3889         New declarations.
3890         (struct frame_print_options): New member print_frame_info.
3891         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3892         * stack.h (get_user_print_what_frame_info): New declaration.
3893         (frame_show_address): New declaration.
3894         * stack.c (print_frame_arguments_choices): New value 'presence'.
3895         (print_frame_info_auto, print_frame_info_source_line,
3896         print_frame_info_location, print_frame_info_source_and_location,
3897         print_frame_info_location_and_address, print_frame_info_short_location,
3898         print_frame_info_choices, print_frame_info_print_what): New definitions.
3899         (print_frame_args): Only print dots for args if print frame-arguments
3900         is 'presence'.
3901         (frame_print_option_defs): New element for "frame-info".
3902         (get_user_print_what_frame_info): New function.
3903         (frame_show_address): Make non static.  Move comment to stack.h.
3904         (print_frame_info_to_print_what): New function.
3905         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3906         to decide what to print.
3907         (backtrace_command_1): Handle the new print_frame_arguments_presence
3908         value.
3909         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3910         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3911         (py_print_frame): In non-mi mode, use LOCATION as default for
3912         print_what, similarly to frame information printed directly by
3913         backtrace command. Handle frame-info user option in non MI mode.
3914
3915 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3916
3917         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3918         Add case for debugging 32-bit target on 64-bit host.  Revise
3919         comment.
3920
3921 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3922
3923         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3924         instead of find_function_entry_range_from_pc.
3925
3926 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3927
3928         * stack.c (find_frame_funname): Remove code which preferred
3929         minsym over symtab sym in "certain pathological cases".
3930
3931         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3932         parameter.  Change type of "do_demangle" to bool.
3933         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3934         Pass suitable "prefer_sym_over_minsym" flag to
3935         build_address_symbolic().  Don't output "+" for negative offsets.
3936         * printcmd.c (print_address_symbolic): Update invocation of
3937         build_address_symbolic to include a "prefer_sym_over_minsym"
3938         flag.
3939         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3940         Restrict cases in which use of minimal symbol is preferred to that
3941         of a found symbol.  Update comments.
3942
3943         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3944         for entry pc when entry pc is out of range for that FDE.
3945
3946 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3947
3948         PR gdb/24839:
3949         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3950         type.
3951
3952 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3953
3954         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3955         this function's Python signature.
3956
3957
3958 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3959
3960         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3961         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3962         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3963         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3964         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3965
3966
3967 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3968
3969         * h8300-tdep.c (h8300_register_name_common): New.
3970         h8300_register_name): Use h8300_register_name_common.
3971         (h8300s_register_name): Likewise.
3972         (h8300sx_register_name): Likewise.
3973         (h8300h_register_nam): New.
3974         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3975
3976
3977 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3978
3979         * arm-tdep.c (arm_skip_cmse_entry): New function.
3980         (arm_is_sgstubs_section): New function.
3981         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3982
3983 2019-07-22  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3986         Don't self-assign.
3987
3988 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3991         type_print.
3992
3993 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3996         so that GDB doesn't match any msymbols when searching in the
3997         TYPES_DOMAIN.
3998         (print_symbol_info): Print using typedef_print or type_print based
3999         on the type of the symbol.  Add updated FIXME comment moved from...
4000         (_initialize_symtab): ... move and update FIXME comment to above.
4001
4002 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * NEWS: Mention adding -q option to "info types".
4005         * symtab.c (struct info_types_options): New struct.
4006         (info_types_options_defs): New variable.
4007         (make_info_types_options_def_group): New function.
4008         (info_types_command): Use gdb::option framework to parse options.
4009         (info_types_command_completer): New function.
4010         (_initialize_symtab): Extend the help text on "info types" and
4011         register command completer.
4012
4013 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4014
4015         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4016         (lookup_symbol_in_objfile): Change int to block_enum and add a
4017         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4018
4019 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4020
4021         * MAINTAINERS (Write After Approval): Add self.
4022
4023 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4026         instruction to the dummy code region.
4027
4028 2019-07-19  Tom Tromey  <tromey@adacore.com>
4029
4030         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4031         (ARGSUSED, PARAMS, __func__): Remove rules.
4032
4033 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4034
4035         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4036         * features/arm/arm-with-iwmmxt.c: Remove.
4037         * features/arm/arm-with-iwmmxt.xml: Remove.
4038         * features/arm/arm-with-m-fpa-layout.c: Remove.
4039         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4040         * features/arm/arm-with-m-vfp-d16.c: Remove.
4041         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4042         * features/arm/arm-with-m.c: Remove.
4043         * features/arm/arm-with-m.xml: Remove.
4044         * features/arm/arm-with-neon.c: Remove.
4045         * features/arm/arm-with-neon.xml: Remove.
4046         * features/arm/arm-with-vfpv2.c: Remove.
4047         * features/arm/arm-with-vfpv2.xml: Remove.
4048         * features/arm/arm-with-vfpv3.c: Remove.
4049         * features/arm/arm-with-vfpv3.xml: Remove.
4050
4051 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4052
4053         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4054
4055 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4056
4057         * arch/aarch32.c (aarch32_create_target_description): Create
4058         target descriptions using features.
4059         * arch/arm.c (arm_create_target_description)
4060         (arm_create_mprofile_target_description): Likewise.
4061         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4062
4063 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4064
4065         * Makefile.in: Add new files.
4066         * aarch32-tdep.c: New file.
4067         * aarch32-tdep.h: New file.
4068         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4069         Call aarch32_read_description.
4070         * arch/aarch32.c: New file.
4071         * arch/aarch32.h: New file.
4072         * arch/arm.c (arm_create_target_description)
4073         (arm_create_mprofile_target_description): New function.
4074         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4075         (arm_create_target_description)
4076         (arm_create_mprofile_target_description): New declaration.
4077         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4078         read_description functions.
4079         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4080         Likewise.
4081         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4082         * arm-tdep.c (tdesc_arm_list): New variable.
4083         (arm_register_g_packet_guesses): Call create description functions.
4084         (arm_read_description) (arm_read_mprofile_description): New
4085         function.
4086         * arm-tdep.h (arm_read_description)
4087         (arm_read_mprofile_description): Add declaration.
4088         * configure.tgt: Add new files.
4089
4090 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4091
4092         * top.c (new_ui_command): Open specified terminal just once.
4093
4094 2019-07-18  Tom Tromey  <tromey@adacore.com>
4095
4096         * symtab.c (main_name): Constify return type.
4097         * symfile.c (set_initial_language): Update.
4098         * symtab.h (main_name): Constify return type.
4099
4100 2019-07-17  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-winsource.c (tui_update_source_window)
4103         (tui_update_source_window_as_is)
4104         (tui_update_source_windows_with_line): Remove return.
4105         * tui/tui-disasm.c (tui_show_disassem)
4106         (tui_show_disassem_and_update_source): Remove return.
4107         * tui/tui.c (tui_reset): Remove return.
4108         * tui/tui-wingeneral.c
4109         (tui_check_and_display_highlight_if_needed): Remove return.
4110
4111 2019-07-17  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4114
4115 2019-07-17  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-winsource.h (struct tui_exec_info_window)
4118         (struct tui_source_window_base): Move from tui-data.h.
4119         * tui/tui-winsource.c: Move many method definitions from
4120         elsewhere.  Remove "structuring" comments.
4121         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4122         (tui_source_window_base::refresh_window): Move to
4123         tui-winsource.c.
4124         * tui/tui-win.c (tui_source_window_base::refresh_all)
4125         (tui_source_window_base::update_tab_width)
4126         (tui_source_window_base::set_new_height)
4127         (tui_source_window_base::do_make_visible_with_new_height): Move to
4128         tui-winsource.c.
4129         * tui/tui-source.h: Update.
4130         * tui/tui-source.c (tui_source_window_base::reset): Move to
4131         tui-winsource.c.
4132         * tui/tui-disasm.h: Update.
4133         * tui/tui-data.h (struct tui_exec_info_window): Move to
4134         tui-winsource.h.
4135         (struct tui_source_window_base): Likewise.
4136         * tui/tui-data.c (tui_source_window_base::clear_detail)
4137         (tui_source_window_base, ~tui_source_window_base): Move to
4138         tui-winsource.c.
4139
4140 2019-07-17  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-win.c (tui_resize_all)
4143         (tui_source_window_base::update_tab_width)
4144         (tui_adjust_win_heights): Update.
4145         (tui_win_info::make_invisible_and_set_new_height): Rename from
4146         make_invisible_and_set_new_height.
4147         * tui/tui-data.h (struct tui_win_info)
4148         <make_invisible_and_set_new_height>: New method.
4149
4150 2019-07-17  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui.c: Update.
4153         * tui/tui-source.h (struct tui_source_window): Move from
4154         tui-data.h.
4155         * tui/tui-layout.c: Update.
4156         * tui/tui-disasm.c: Update.
4157         * tui/tui-data.h (struct tui_source_window): Move to
4158         tui-source.h.
4159
4160 2019-07-17  Tom Tromey  <tom@tromey.com>
4161
4162         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4163         tui-data.h.
4164         * tui/tui-data.h (struct tui_disasm_window): Move to
4165         tui-disasm.h.
4166
4167 2019-07-17  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-regs.h (struct tui_data_item_window): Move from
4170         tui-data.h.
4171         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4172         * tui/tui-data.h (struct tui_data_item_window): Move to
4173         tui-regs.h.
4174         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4175
4176 2019-07-17  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui.c: Update.
4179         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4180         (tui_cmd_window::max_height): Move to tui-command.c.
4181         * tui/tui-layout.c: Update.
4182         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4183         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4184         tui-command.c.
4185         * tui/tui-command.h (struct tui_cmd_window): Move from
4186         tui-data.h.
4187         * tui/tui-command.c: Remove "structuring" comments.
4188         (tui_cmd_window::clear_detail)
4189         (tui_cmd_window::do_make_visible_with_new_height)
4190         (tui_cmd_window::max_height): Move from elsewhere.
4191
4192 2019-07-17  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4195         Now static.
4196         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4197         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4198
4199 2019-07-17  Tom Tromey  <tom@tromey.com>
4200
4201         * tui/tui.c: Update.
4202         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4203         tui-regs.c.
4204         * tui/tui-windata.h: Remove file.
4205         * tui/tui-windata.c: Remove file.
4206         * tui/tui-win.c (tui_data_window::set_new_height)
4207         (tui_data_window::do_make_visible_with_new_height): Move to
4208         tui-regs.c.
4209         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4210         * tui/tui-regs.c: Remove "structuring" comments.
4211         (tui_data_window::first_data_item_displayed)
4212         (tui_data_window::delete_data_content_windows)
4213         (tui_data_window::erase_data_content)
4214         (tui_data_window::display_all_data)
4215         (tui_data_window::refresh_all)
4216         (tui_data_window::do_scroll_vertical)
4217         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4218         (tui_data_window::do_make_visible_with_new_height)
4219         (tui_data_window::refresh_window): Move from elsewhere.
4220         (_initialize_tui_regs): Move to end of file.
4221         * tui/tui-layout.c: Update.
4222         * tui/tui-hooks.c: Update.
4223         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4224         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4225         tui-regs.c.
4226         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4231         seen.
4232
4233 2019-07-17  Tom Tromey  <tom@tromey.com>
4234
4235         * tui/tui-win.c (tui_source_window_base::set_new_height)
4236         (tui_source_window_base::do_make_visible_with_new_height): Use
4237         m_has_locator field directly.
4238         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4239         method.
4240         (struct tui_source_window_base) <has_locator>: Likewise.
4241
4242 2019-07-17  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4245         Don't declare.
4246         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4247         Remove.
4248         * tui/tui-win.c (tui_source_window_base::set_new_height)
4249         (tui_source_window_base::set_new_height)
4250         (make_invisible_and_set_new_height)
4251         (tui_source_window_base::do_make_visible_with_new_height)
4252         (tui_source_window_base::do_make_visible_with_new_height):
4253         Update.
4254         * tui/tui-layout.c (show_source_disasm_command, show_data)
4255         (show_source_or_disasm_and_command): Update.
4256         * tui/tui-layout.c (show_layout): Update.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-layout.c (make_data_window): Remove.
4261         (show_data): Unify creation and re-initialization cases.
4262
4263 2019-07-17  Tom Tromey  <tom@tromey.com>
4264
4265         * tui/tui-layout.c (make_source_window, make_disasm_window):
4266         Remove.
4267         (show_data): Unify creation and re-initialization cases.
4268
4269 2019-07-17  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-layout.c (make_command_window): Remove.
4272         (show_source_disasm_command, show_source_or_disasm_and_command):
4273         Unify creation and re-initialization cases.
4274
4275 2019-07-17  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4278         creation and re-initialization cases.
4279
4280 2019-07-17  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-regs.c (tui_get_register): Return void.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4287         Simplify.
4288
4289 2019-07-17  Tom Tromey  <tom@tromey.com>
4290
4291         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4292         resetting.
4293
4294 2019-07-17  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4297         * tui/tui-regs.c (tui_reg_layout): New function.
4298         (tui_show_registers, tui_reg_command): Use it.
4299         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4300         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4301         parameters.
4302         (tui_layout_command): Remove.
4303
4304 2019-07-17  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui-layout.h (tui/tui-layout): Return void.
4307         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4308
4309 2019-07-17  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-layout.c (show_source_disasm_command, show_data):
4312         Update.
4313         (reset_locator): Remove.
4314         (show_source_or_disasm_and_command): Update.
4315
4316 2019-07-17  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-source.c (tui_source_window_base::reset): Remove
4319         win_type parameter.
4320         * tui/tui-layout.c (make_command_window, make_source_window)
4321         (make_disasm_window, make_data_window)
4322         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4323         (reset_locator, show_source_or_disasm_and_command): Update.
4324         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4325         win_type parameter.
4326         (struct tui_source_window_base) <reset>: Likewise.
4327
4328 2019-07-17  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-layout.c (show_source_disasm_command): Use
4331         reset_locator.
4332         (reset_locator): New function.
4333         (init_and_make_win): Remove.
4334         (show_source_or_disasm_and_command): Use reset_locator.
4335
4336 2019-07-17  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4339         condition.
4340         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4341         Remove condition.
4342         * tui/tui-source.c (tui_source_window_base::reset): New method.
4343         * tui/tui-layout.c (make_command_window): Don't call
4344         init_and_make_win.
4345         (make_source_window, make_disasm_window): Don't call
4346         make_source_or_disasm_window.
4347         (make_data_window): Don't call init_and_make_win.  Change calling
4348         convention.
4349         (show_source_disasm_command, show_data): Simplify.
4350         (make_source_or_disasm_window): Remove.
4351         (show_source_or_disasm_and_command): Simplify.
4352         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4353         (struct tui_source_window_base) <reset>: Likewise.
4354         <execution_info>: Remove initializer.
4355         * tui/tui-data.c (tui_source_window_base): Initialize
4356         execution_info.
4357
4358 2019-07-17  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4361         variable.
4362
4363 2019-07-17  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui.c (tui_rl_other_window): Update.
4366         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4367         superclass method first.  Always iterate over regs_content.
4368         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4369         method.
4370         * tui/tui-win.c (tui_set_focus_command): Update.
4371
4372 2019-07-17  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-win.c (tui_set_focus_command): Rename from
4375         tui_set_focus.  Call tui_enable.
4376         (tui_set_focus_command): Remove.
4377
4378 2019-07-17  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4381         refresh_window.
4382         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4383         touchwin.
4384         (tui_data_window::refresh_window): Call refresh_window on data
4385         items.  Always call superclass refresh_window.
4386         (tui_win_info::refresh): Remove.
4387         (tui_source_window_base::refresh_window): Update.
4388         (tui_refresh_all): Update.
4389         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4390         refresh_window.
4391         (show_source_or_disasm_and_command): Likewise.
4392         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4393         (struct tui_source_window_base) <refresh>: Likewise.
4394
4395 2019-07-17  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-winsource.c (tui_clear_source_content)
4398         (tui_show_source_content): Update.
4399         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4400         whether content is empty.
4401         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4402         Remove.
4403
4404 2019-07-17  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4407         window's contents.
4408         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4409         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4410
4411 2019-07-17  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4414         (struct tui_data_item_window): Update.
4415
4416 2019-07-17  Tom Tromey  <tom@tromey.com>
4417
4418         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4419         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4420         defines.
4421
4422 2019-07-17  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-winsource.h (tui_erase_source_content)
4425         (tui_clear_source_content): Remove "display_prompt" parameter.
4426         * tui/tui-winsource.c (tui_update_source_window_as_is)
4427         (tui_update_source_windows_with_addr): Update.
4428         (tui_clear_source_content): Remove "display_prompt" parameter.
4429         (tui_erase_source_content): Likewise.  Simplify.
4430         (tui_show_source_content): Update.
4431         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4432         * tui/tui-stack.c (tui_show_frame_info): Update.
4433         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4434         Remove defines.
4435
4436 2019-07-17  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4439         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4440         parameter.
4441         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4442         parameter.
4443
4444 2019-07-17  Tom Tromey  <tom@tromey.com>
4445
4446         * tui/tui-winsource.c (tui_clear_source_content)
4447         (tui_show_source_content, tui_show_exec_info_content)
4448         (tui_clear_exec_info_content): Update.
4449         * tui/tui-stack.c (tui_show_locator_content): Update.
4450         (tui_show_frame_info): Update.
4451         * tui/tui-source.h (tui_source_window): Don't declare.
4452         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4453         from tui_source_is_displayed.
4454         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4455         Remove field.
4456         (struct tui_source_window_base) <content_in_use>: New field.  Now
4457         bool.
4458         (struct tui_source_window) <showing_source_p>: New method.
4459         (TUI_SRC_WIN): Change cast.
4460         * tui/tui-data.c (tui_initialize_static_data): Update.
4461
4462 2019-07-17  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4465         location_matches_p.
4466         * tui/tui-source.c (tui_source_window::location_matches_p): New
4467         method.
4468         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4469         method.
4470         * tui/tui-data.h (struct tui_source_window_base)
4471         <location_matches_p>: New method.
4472         (struct tui_source_window, struct tui_disasm_window)
4473         <location_matches_p>: Likewise.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-win.c (tui_set_win_height_command): Rename from
4478         tui_set_win_height.
4479         (tui_set_win_height_command): Remove.
4480
4481 2019-07-17  Tom Tromey  <tom@tromey.com>
4482
4483         * tui/tui-source.c (tui_source_window): New constructor.  Add
4484         observer.
4485         (~tui_source_window): New destructor.
4486         (tui_source_window::style_changed): New method.
4487         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4488         (tui_attach_detach_observers): Update.
4489         * tui/tui-data.h (struct tui_source_window): Make constructor not
4490         inline.  Add destructor.
4491         (struct tui_source_window) <style_changed>: New method.
4492         <m_observable>: New member.
4493
4494 2019-07-17  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4497         * tui/tui-win.c (tui_resize_all): Fix typo.
4498
4499 2019-07-17  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4502         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4503         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4504         * tui/tui-win.c (window_name_completer): Use foreach.
4505         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4506         (update_tab_width): Likewise.
4507         * tui/tui-layout.c (show_layout): Update.
4508         * tui/tui-data.h (class tui_window_iterator): New.
4509         (struct all_tui_windows): New.
4510         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4511
4512 2019-07-17  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4515         parameter.  Don't reference globals.
4516         (tui_reg_command): Update.
4517
4518 2019-07-17  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-regs.c (tui_show_registers): Simplify.
4521
4522 2019-07-17  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-regs.c (tui_show_registers): Update.
4525         (tui_show_register_group): Add win_info parameter.
4526
4527 2019-07-17  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4530         Rename from tui_display_reg_element_at_line.
4531         (tui_data_window::display_registers_from_line): Update.
4532         * tui/tui-data.h (struct tui_data_window)
4533         <display_reg_element_at_line>: New method.
4534
4535 2019-07-17  Tom Tromey  <tom@tromey.com>
4536
4537         * tui/tui-regs.h (tui_display_registers_from)
4538         (tui_display_registers_from_line): Don't declare.
4539         * tui/tui-windata.c (tui_data_window::display_all_data)
4540         (tui_data_window::refresh_all)
4541         (tui_data_window::do_scroll_vertical): Update.
4542         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4543         from tui_display_registers_from.
4544         (tui_display_reg_element_at_line): Update.
4545         (tui_data_window::display_registers_from_line): Rename from
4546         tui_display_registers_from_line.
4547         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4548         display_registers_from_line>: New methods.
4549
4550 2019-07-17  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4553         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4554         from tui_erase_data_content.
4555         (tui_data_window::display_all_data)
4556         (tui_data_window::refresh_all)
4557         (tui_data_window::do_scroll_vertical): Update.
4558         * tui/tui-regs.c (tui_show_registers): Update.
4559         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4560         New method.
4561
4562 2019-07-17  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4565         declare.
4566         * tui/tui-windata.c
4567         (tui_data_window::delete_data_content_windows): Rename from
4568         tui_delete_data_content_windows.
4569         (tui_data_window::display_all_data)
4570         (tui_data_window::do_scroll_vertical): Update.
4571         * tui/tui-data.h (struct tui_data_window)
4572         <delete_data_content_windows>: New method.
4573
4574 2019-07-17  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4577         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4578
4579 2019-07-17  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4582         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4583         from tui_display_all_data.
4584         * tui/tui-win.c
4585         (tui_data_window::do_make_visible_with_new_height): Update.
4586         * tui/tui-regs.c (tui_show_registers): Update.
4587         * tui/tui-layout.c (tui_set_layout): Update.
4588         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4589         method.
4590
4591 2019-07-17  Tom Tromey  <tom@tromey.com>
4592
4593         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4594         * tui/tui-windata.c (tui_display_data_from): Remove.
4595         (tui_data_window::refresh_all): Update.
4596
4597 2019-07-17  Tom Tromey  <tom@tromey.com>
4598
4599         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4600         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4601         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4602         tui_display_registers_from_line.
4603         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4604         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4605         "force_display" parameter.
4606
4607 2019-07-17  Tom Tromey  <tom@tromey.com>
4608
4609         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4610         declare.
4611         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4612         Rename from tui_first_reg_element_no_inline.
4613         (tui_display_reg_element_at_line)
4614         (tui_display_registers_from_line): Update.
4615         * tui/tui-data.h (struct tui_data_window)
4616         <first_reg_element_no_inline>: New method.
4617
4618 2019-07-17  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-windata.c (tui_display_data_from)
4621         (tui_data_window::do_scroll_vertical): Update.
4622         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4623         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4624         Rename from tui_line_from_reg_element_no.
4625         (tui_display_registers_from_line): Update.
4626         * tui/tui-data.h (struct tui_data_window)
4627         <line_from_reg_element_no>: New method.
4628
4629 2019-07-17  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4632         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4633         tui_last_regs_line_no.
4634         (tui_display_reg_element_at_line)
4635         (tui_display_registers_from_line): Update.
4636         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4637         method.
4638
4639 2019-07-17  Tom Tromey  <tom@tromey.com>
4640
4641         PR tui/24722:
4642         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4643         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4644         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4645         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4646         (tui_update_breakpoint_info): Likewise.
4647         * tui/tui-hooks.c (tui_event_create_breakpoint)
4648         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4649         Update.
4650
4651 2019-07-17  Tom Tromey  <tom@tromey.com>
4652
4653         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4654
4655 2019-07-17  Tom Tromey  <tom@tromey.com>
4656
4657         * tui/tui-winsource.c (tui_update_source_window_as_is)
4658         (tui_update_source_windows_with_addr): Update.
4659         * tui/tui-source.h (tui_set_source_content)
4660         (tui_show_symtab_source): Add "win_info" parameter.
4661         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4662         parameter.
4663         (tui_show_symtab_source): Likewise.
4664
4665 2019-07-17  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-wingeneral.c
4668         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4673         (struct tui_cmd_window) <can_scroll>: New method.
4674         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4675         method.
4676
4677 2019-07-17  Tom Tromey  <tromey@adacore.com>
4678
4679         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4680         do_field_signed>: Rename.  Change type of "value".
4681         * ui-out.c (ui_out::field_signed): Rename from field_int.
4682         Change type of "value".
4683         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4684         type of "value".
4685         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4686         do_field_int.  Change type of "value".
4687         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4688         do_field_int.  Change type of "value".
4689         * tracepoint.c (trace_status_mi, tfind_1)
4690         (print_one_static_tracepoint_marker): Update.
4691         * thread.c (print_thread_info_1, print_selected_thread_frame):
4692         Update.
4693         * stack.c (print_frame, print_frame_info): Update.
4694         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4695         Update.
4696         * source.c (print_source_lines_base): Update.
4697         * skip.c (info_skip_command): Update.
4698         * record-btrace.c (btrace_ui_out_decode_error)
4699         (btrace_call_history_src_line): Update.
4700         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4701         Update.
4702         * progspace.c (print_program_space): Update.
4703         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4704         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4705         do_field_int.  Change type of "value".
4706         * mi/mi-out.c (mi_ui_out::do_table_begin)
4707         (mi_ui_out::do_table_header): Update.
4708         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4709         type of "value".
4710         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4711         (mi_cmd_data_list_changed_registers, output_register)
4712         (mi_cmd_data_read_memory, mi_load_progress)
4713         (mi_cmd_trace_frame_collected): Update.
4714         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4715         Update.
4716         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4717         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4718         (mi_cmd_var_list_children, varobj_update_one): Update.
4719         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4720         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4721         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4722         * inferior.c (print_inferior): Update.
4723         * gdb_bfd.c (print_one_bfd): Update.
4724         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4725         Update.
4726         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4727         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4728         do_field_int.  Change type of "value".
4729         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4730         do_field_int.  Change type of "value".
4731         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4732         (print_one_breakpoint_location, print_it_catch_fork)
4733         (print_one_catch_fork, print_it_catch_vfork)
4734         (print_one_catch_vfork, print_it_catch_solib)
4735         (print_it_catch_exec, print_it_ranged_breakpoint)
4736         (print_mention_watchpoint, print_mention_masked_watchpoint)
4737         (bkpt_print_it, update_static_tracepoint): Update.
4738         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4739         * break-catch-syscall.c (print_it_catch_syscall): Update.
4740         * ada-tasks.c (print_ada_task_info): Update.
4741         * ada-lang.c (print_it_exception, print_mention_exception):
4742         Update.
4743
4744 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4745
4746         PR breakpoints/24541
4747         * gdbarch.c: Regenerate.
4748         * gdbarch.h: Regenerate.
4749         * gdbarch.sh: Adjust return type and parameter types for
4750         'stap_adjust_register'.
4751         (i386_stap_adjust_register): Adjust signature and return new
4752         register name.
4753         * stap-probe.c (stap_parse_register_operand): Adjust use of
4754         'gdbarch_stap_adjust_register'.
4755
4756 2019-07-17  Tom Tromey  <tromey@adacore.com>
4757
4758         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4759         declare VEC.
4760         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4761         std::vector.
4762         (struct s390_process_info): Add initializers.
4763         (s390_add_process): Use new.
4764         (s390_linux_nat_target::low_forget_process): Use delete.
4765         (s390_linux_nat_target::low_new_fork)
4766         (s390_linux_nat_target::stopped_by_watchpoint)
4767         (s390_linux_nat_target::low_prepare_to_resume)
4768         (s390_linux_nat_target::insert_watchpoint)
4769         (s390_linux_nat_target::insert_hw_breakpoint)
4770         (s390_linux_nat_target::remove_watchpoint)
4771         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4772
4773 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4774
4775         * aarch64-fbsd-nat.c: Include regcache.h.
4776         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4777         argument.
4778         (aarch64_fbsd_nat_target::fetch_registers)
4779         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4780         variable.
4781         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4782
4783 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4784
4785         * fbsd-nat.c: Include gdbarch.h.
4786
4787 2019-07-15  Tom Tromey  <tromey@adacore.com>
4788
4789         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4790
4791 2019-07-15  Tom Tromey  <tromey@adacore.com>
4792
4793         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4794         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4795         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4796         * cli-out.c (cli_ui_out::do_field_int): New method.
4797         * ui-out.c (ui_out::field_unsigned): New method.
4798         * symfile.c (generic_load): Use field_unsigned.
4799         (print_transfer_performance): Likewise.
4800         * record-btrace.c (ui_out_field_uint): Remove.
4801         (btrace_call_history_insn_range, btrace_call_history): Use
4802         field_unsigned.
4803         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4804         field_unsigned.
4805         * ui-out.h (class ui_out) <field_unsigned>: New method.
4806         <do_field_unsigned>: Likewise.
4807
4808 2019-07-15  Tom Tromey  <tromey@adacore.com>
4809
4810         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4811         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4812         * target.c (flash_erase_command): Use field_string.
4813         * infrun.c (print_signal_received_reason): Use field_string.
4814         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4815         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4816         field_string.
4817         * ada-tasks.c (print_ada_task_info): Use field_string.
4818
4819 2019-07-15  Tom Tromey  <tromey@adacore.com>
4820
4821         * target.c (flash_erase_command): Use field_core_addr.
4822         * symfile.c (generic_load): Use field_core_addr.
4823         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4824         Use field_core_addr.
4825         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4826         field_core_addr.
4827
4828 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4831         value if its desired type is smaller than a CORE_ADDR and signed.
4832
4833 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4834
4835         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4836         of changes to field names, and use new is_reference field to
4837         decide if a property is a reference or not.
4838         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4839         field.
4840         (struct dwarf2_property_baton): Update header comment, rename
4841         'referenced_type' to 'property_type' and update comments.
4842         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4843         default property type, store in property baton, update to take
4844         accound of renamed field.
4845         (read_func_scope): Update call to attr_to_dynamic_prop.
4846         (read_array_type): Likewise.
4847         (dwarf2_per_cu_addr_sized_int_type): New function.
4848         (read_subrange_index_type): Move type finding code to
4849         dwarf2_per_cu_addr_sized_int_type.
4850         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4851         (dwarf2_per_cu_addr_type): New function.
4852         (set_die_type): Update calls to attr_to_dynamic_prop.
4853
4854 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * dwarf2read.c (read_subrange_index_type): New function.
4857         (read_subrange_type): Move code into new function and call it.
4858         * gdbtypes.c (create_range_type): Add some asserts.
4859
4860 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4863         update return statements.
4864         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4865         declaration, and update comment to match.
4866         * gdbtypes.c (resolve_dynamic_array): Update call to
4867         dwarf2_evaluate_property to match new return type.
4868
4869 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4870
4871         * valarith.c (value_subscripted_rvalue): Change lowerbound
4872         parameter type from int to LONGEST.
4873         * value.h (value_subscripted_rvalue): Likewise in declaration.
4874
4875 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4876
4877         * cli/cli-utils.c (info_print_command_completer): New function.
4878         * cli/cli-utils.h: Add 'completer.h' include, and forward
4879         declaration for 'struct cmd_list_element'.
4880         (info_print_command_completer): Declare.
4881         * stack.c (_initialize_stack): Add completer for 'info locals' and
4882         'info args'.
4883         * symtab.c (_initialize_symtab): Add completer for 'info
4884         variables' and 'info functions'.
4885         * NEWS: Mention completion for additional info commands.
4886
4887 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * cli/cli-utils.c (extract_info_print_args): Delete.
4890         (extract_arg_maybe_quoted): Delete.
4891         (info_print_options_defs): New variable.
4892         (make_info_print_options_def_group): New function.
4893         (extract_info_print_options): Define new function.
4894         * cli/cli-utils.h (extract_info_print_args): Delete.
4895         (struct info_print_options): New structure.
4896         (extract_info_print_options): Declare new function.
4897         * stack.c (info_locals_command): Update to use new
4898         extract_info_print_options, also add a header comment.
4899         (info_args_command): Likewise.
4900         * symtab.c (info_variables_command): Likewise.
4901         (info_functions_command): Likewise.
4902
4903 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4906         to extract string arguments.
4907         * common/common-utils.c (extract_string_maybe_quoted): New function.
4908         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4909
4910 2019-07-11  Tom Tromey  <tromey@adacore.com>
4911
4912         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4913         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4914         * top.h (gdbinit): Don't declare.
4915         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4916         into...
4917         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4918         * top.c (gdb_init): Don't call init_cli_cmds.
4919         (gdbinit): Remove.
4920         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4921
4922 2019-07-11  Tom Tromey  <tromey@adacore.com>
4923
4924         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4925         after it has been moved.
4926
4927 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4928
4929         * valops.c (value_must_coerce_to_target): Change return type to
4930         bool.
4931         * value.h (value_must_coerce_to_target): Likewise.
4932
4933 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4934
4935         * breakpoint.c (is_hardware_watchpoint): Remove
4936         forward-declaration.
4937         (is_masked_watchpoint): Change return type to bool.
4938         (is_tracepoint): Likewise.
4939         (is_breakpoint): Likewise.
4940         (is_hardware_watchpoint): Likewise.
4941         (is_watchpoint): Likewise.
4942         (is_no_memory_software_watchpoint): Likewise.
4943         (is_catchpoint): Likewise.
4944         (breakpoint_1): Make FILTER parameter's return type bool.
4945         is_masked_watchpoint): Change return type to bool.
4946         (save_breakpoints): Make FILTER parameter's return type bool.
4947         * breakpoint.h (is_breakpoint): Change return type to bool.
4948         (is_watchpoint): Likewise.
4949         (is_catchpoint): Likewise.
4950         (is_tracepoint): Likewise.
4951
4952 2019-07-10  Tom Tromey  <tom@tromey.com>
4953
4954         * defs.h: Don't include gdbarch.h.
4955         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4956         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4957         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4958         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4959         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4960         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4961         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4962         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4963         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4964         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4965         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4966         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4967         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4968         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4969         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4970         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4971         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4972         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4973         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4974         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4975         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4976         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4977         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4978         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4979         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4980         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4981         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4982
4983 2019-07-10  Tom Tromey  <tromey@adacore.com>
4984
4985         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4986         * breakpoint.c (init_ada_exception_breakpoint): Register as
4987         bp_catchpoint.
4988         (print_one_breakpoint_location, print_one_breakpoint): Use
4989         is_ada_exception_catchpoint.
4990         * ada-lang.c (class ada_catchpoint_location): Pass
4991         bp_loc_software_breakpoint to bp_location constructor.
4992         (is_ada_exception_catchpoint): New function.
4993
4994 2019-07-10  Tom Tromey  <tromey@adacore.com>
4995
4996         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4997         VEC.
4998         (struct arm_exidx_entry): New method operator<.
4999         (struct arm_exidx_data) <section_maps>: Change type.
5000         (arm_exidx_data_free): Remove.
5001         (arm_exidx_data_key): Change type.  Move lower.
5002         (arm_exidx_new_objfile): Update.
5003         (arm_compare_exidx_entries): Remove.
5004         (arm_find_exidx_entry, _initialize_arm_tdep)
5005
5006 2019-07-10  Tom Tromey  <tromey@adacore.com>
5007
5008         * solib-spu.c (ocl_program_data_key): Change type.
5009         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5010         Update.
5011
5012 2019-07-10  Tom Tromey  <tromey@adacore.com>
5013
5014         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5015         (struct solib_aix_inferior_data) <library_list>: Change type.
5016         (solib_aix_inferior_data_handle): Change type.
5017         (get_solib_aix_inferior_data): Update.
5018         (solib_aix_free_library_list): Remove.
5019         (library_list_start_library): Update.
5020         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5021         return type.
5022         (solib_aix_get_library_list)
5023         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5024         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5025
5026 2019-07-10  Tom Tromey  <tromey@adacore.com>
5027
5028         * solib-dsbt.c (struct dsbt_info): Add initializers.
5029         (solib_dsbt_pspace_data): Change type.
5030         (dsbt_pspace_data_cleanup): Remove.
5031         (get_dsbt_info, _initialize_dsbt_solib): Update.
5032
5033 2019-07-10  Tom Tromey  <tromey@adacore.com>
5034
5035         * spu-tdep.c (spu_overlay_data): Change type.
5036         (spu_get_overlay_table, spu_overlay_new_objfile)
5037         (_initialize_spu_tdep): Update.
5038
5039 2019-07-10  Tom Tromey  <tromey@adacore.com>
5040
5041         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5042         destructor.
5043         (dbx_objfile_data_key): Change type and declare later.
5044         (DBX_SYMFILE_INFO): Rewrite.
5045         * dbxread.c (dbx_objfile_data_key): Change type.
5046         (dbx_symfile_init): Update.
5047         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5048         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5049         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5050
5051 2019-07-10  Tom Tromey  <tromey@adacore.com>
5052
5053         * jit.c (jit_program_space_key): Change type.  Move lower.
5054         (get_jit_program_space_data): Update.
5055         (jit_program_space_data_cleanup): Remove.
5056         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5057         Update.
5058         (struct jit_program_space_data): Add initializers.
5059
5060 2019-07-10  Tom Tromey  <tromey@adacore.com>
5061
5062         * solib-darwin.c (struct darwin_info): Add initializers.
5063         (solib_darwin_pspace_data): Change type.
5064         (darwin_pspace_data_cleanup): Remove.
5065         (get_darwin_info, _initialize_darwin_solib): Update.
5066
5067 2019-07-10  Tom Tromey  <tromey@adacore.com>
5068
5069         * remote-sim.c (struct sim_inferior_data): Add initializers,
5070         constructor, and destructor.
5071         (sim_inferior_data_key): Change type.  Move lower.
5072         (check_for_duplicate_sim_descriptor): Update.
5073         (get_sim_inferior_data): Use new.  Update.
5074         (~sim_inferior_data_cleanup): Rename from
5075         sim_inferior_data_cleanup.  Simplify.
5076         (gdbsim_close_inferior, simulator_command)
5077         (sim_command_completer, _initialize_remote_sim): Update.
5078         (next_pid, INITIAL_PID): Move earlier.
5079
5080 2019-07-10  Tom Tromey  <tromey@adacore.com>
5081
5082         * python/python-internal.h (create_thread_object): Return
5083         gdbpy_ref.
5084         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5085         * python/py-inferior.c (struct threadlist_entry): Add
5086         constructor.
5087         <thread_obj>: Now a gdbpy_ref.
5088         (thread_to_thread_object): Update.
5089         (add_thread_object): Use new.
5090         (delete_thread_object): Use delete.
5091         (infpy_threads): Update.
5092         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5093         GIL.
5094
5095 2019-07-10  Tom Tromey  <tromey@adacore.com>
5096
5097         * valops.c (value_cast): Specialize error message for Ada.
5098
5099 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5100
5101         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5102
5103 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5104
5105         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5106         bpstat_should_step): Return bool, adjust comments.
5107         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5108         bpstat_should_step): Likewise.
5109
5110 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5111
5112         * features/Makefile: Use feature target descriptions for Arm.
5113         * features/arm/arm-core.c: Generate new file.
5114         * features/arm/arm-fpa.c: Likewise.
5115         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5116         * features/arm/arm-m-profile.c: Likewise.
5117         * features/arm/arm-vfpv2.c: Likewise.
5118         * features/arm/arm-vfpv3.c: Likewise.
5119         * features/arm/xscale-iwmmxt.c: Likewise.
5120         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5121
5122 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5123
5124         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5125         ptrace earlier.
5126
5127 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5128
5129         * features/aarch64-pauth.c: Regenerate.
5130
5131 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5132
5133         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5134         bool.
5135         (bpstat_what): Use false instead of 0.
5136
5137 2019-07-09  Pedro Alves  <palves@redhat.com>
5138
5139         * break-catch-throw.c (is_exception_catchpoint): New.
5140         * breakpoint.c (print_one_breakpoint_location): New parameter
5141         'raw_loc'.  Handle it.  Use
5142         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5143         looking at the breakpoint's type.
5144         (print_one_breakpoint): If handling "maint info breakpoints", also
5145         print locations of exception catchpoints.
5146         * breakpoint.h (is_exception_catchpoint): Declare.
5147
5148 2019-07-09  Pedro Alves  <palves@redhat.com>
5149
5150         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5151         "addr" field.
5152         (allocate_location_exception_catchpoint): New.
5153         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5154         (initialize_throw_catchpoint_ops): Install
5155         allocate_location_exception_catchpoint as allocate_location
5156         method.
5157         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5158         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5159         bp_loc_other.
5160         (breakpoint_address_is_meaningful): Delete.
5161         (bl_address_is_meaningful): New.
5162         (breakpoint_locations_match): Adjust comment.
5163         (bp_location_from_bp_type): New, factored out of...
5164         (bp_location::bp_location(breakpoint *)): ... this.
5165         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5166         factored out of...
5167         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5168         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5169         breakpoint_address_is_meaningful.
5170         (bp_locations_compare): Adjust comment.
5171         (update_global_location_list): Use bl_address_is_meaningful
5172         instead of breakpoint_address_is_meaningful.
5173         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5174         explicit.
5175         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5176         * python/py-breakpoint.c (bppy_get_location): No longer check
5177         whether location is null.
5178
5179 2019-07-09  Pedro Alves  <palves@redhat.com>
5180
5181         PR c++/15468
5182         * breakpoint.c (print_one_breakpoint_location): Remove
5183         single-location assert.
5184
5185 2019-07-09  Tom Tromey  <tom@tromey.com>
5186
5187         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5188         * configure: Rebuild.
5189         * configure.ac: Change common to gdbsupport.
5190         * gdbsupport: Rename from common.
5191         * acinclude.m4: Change common to gdbsupport.
5192         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5193         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5194         gdbsupport.
5195         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5196         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5197         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5198         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5199         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5200         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5201         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5202         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5203         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5204         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5205         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5206         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5207         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5208         coff-pe-read.c, command.h, compile/compile-c-support.c,
5209         compile/compile-c.h, compile/compile-cplus-symbols.c,
5210         compile/compile-cplus-types.c, compile/compile-cplus.h,
5211         compile/compile-loc2c.c, compile/compile.c, completer.c,
5212         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5213         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5214         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5215         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5216         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5217         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5218         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5219         features/aarch64-core.c, features/aarch64-fpu.c,
5220         features/aarch64-pauth.c, features/aarch64-sve.c,
5221         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5222         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5223         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5224         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5225         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5226         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5227         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5228         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5229         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5230         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5231         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5232         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5233         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5234         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5235         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5236         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5237         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5238         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5239         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5240         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5241         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5242         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5243         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5244         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5245         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5246         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5247         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5248         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5249         minsyms.c, mips-linux-tdep.c, namespace.h,
5250         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5251         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5252         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5253         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5254         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5255         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5256         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5257         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5258         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5259         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5260         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5261         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5262         procfs.c, producer.c, progspace.h, psymtab.h,
5263         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5264         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5265         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5266         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5267         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5268         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5269         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5270         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5271         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5272         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5273         target-memory.c, target.c, target.h, target/waitstatus.c,
5274         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5275         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5276         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5277         unittests/array-view-selftests.c,
5278         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5279         unittests/common-utils-selftests.c,
5280         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5281         unittests/format_pieces-selftests.c,
5282         unittests/function-view-selftests.c,
5283         unittests/lookup_name_info-selftests.c,
5284         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5285         unittests/mkdir-recursive-selftests.c,
5286         unittests/observable-selftests.c,
5287         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5288         unittests/parse-connection-spec-selftests.c,
5289         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5290         unittests/scoped_fd-selftests.c,
5291         unittests/scoped_mmap-selftests.c,
5292         unittests/scoped_restore-selftests.c,
5293         unittests/string_view-selftests.c, unittests/style-selftests.c,
5294         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5295         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5296         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5297         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5298         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5299         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5300
5301 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5302
5303         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5304         bool value.
5305         (decode_digits_ordinary): Set explicit_line field in sal.
5306         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5307         symtab_and_line that was set on an explicit line number in
5308         assembler code.  Do always update the recorded symtab and line if
5309         we do skip the prologue.
5310
5311 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * breakpoint.c (set_breakpoint_location_function): Remove
5314         explicit_loc parameter.
5315         (momentary_breakpoint_from_master): Update call to
5316         set_breakpoint_location_function.
5317         (add_location_to_breakpoint): Likewise.
5318
5319 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5320
5321         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5322         required features based on default bfd type when no specific bfd
5323         is present.
5324
5325 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5326
5327         * NEWS: Mention that GDB printf and eval commands can now print
5328         C-style and Ada-style convenience var strings without
5329         calling the inferior.
5330         * printcmd.c (printf_c_string): Locally print GDB internal var
5331         instead of transiting via the inferior.
5332         (printf_wide_c_string): Likewise.
5333
5334 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5335
5336         PR breakpoints/25011
5337         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5338
5339 2019-07-04  Tom Tromey  <tom@tromey.com>
5340
5341         PR tui/24724:
5342         * tui/tui-winsource.c (tui_clear_source_content): Update.
5343         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5344         (tui_update_breakpoint_info): Update.
5345         (tui_set_exec_info_content): Update.
5346         * tui/tui-source.c (tui_set_source_content_nil): Update.
5347         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5348         has_break.
5349         * tui/tui-data.h (enum tui_bp_flag): New.
5350         (tui_bp_flags): New enum flags type.
5351         (struct tui_source_element) <break_mode>: Change type.  Rename
5352         from has_break.
5353         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5354         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5355         constants.
5356         * tui/tui-winsource.h: Fix comment.
5357
5358 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5359
5360         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5361         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5362         (store_fpregs_to_thread)
5363         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5364         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5365         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5366         (IWMMXT_REGS_SIZE): Add define.
5367         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5368         (fetch_vfp_regs, store_vfp_regs)
5369         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5370         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5371
5372 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5373
5374         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5375         defines.
5376         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5377         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5378         (ARM_INT_REGISTER_SIZE): ...to this.
5379         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5380         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5381         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5382         (arm_linux_collect_gregset, supply_nwfpe_register)
5383         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5384         defines.
5385         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5386         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5387         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5388         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5389         (arm_return_in_memory, arm_store_return_value)
5390         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5391         (arm_record_ld_st_multiple): Likewise.
5392         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5393         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5394
5395 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5396
5397         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5398         AARCH64_DISPLACED_MODIFIED_INSNS.
5399         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5400         (aarch64_displaced_step_copy_insn): Likewise.
5401         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5402         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5403         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5404         ARM_DISPLACED_MODIFIED_INSNS.
5405         * arm-tdep.c (arm_gdbarch_init): Likewise.
5406         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5407         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5408         (struct arm_displaced_step_closure): Use
5409         ARM_DISPLACED_MODIFIED_INSNS.
5410
5411 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5412
5413         * features/Makefile: Remove unused xml files.
5414         * features/aarch64.xml: Remove.
5415         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5416         * features/i386/amd64-avx-avx512.xml: Remove.
5417         * features/i386/amd64-avx-linux.xml: Remove.
5418         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5419         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5420         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5421         * features/i386/amd64-avx-mpx.xml: Remove.
5422         * features/i386/amd64-avx.xml: Remove.
5423         * features/i386/amd64-linux.xml: Remove.
5424         * features/i386/amd64-mpx-linux.xml: Remove.
5425         * features/i386/amd64-mpx.xml: Remove.
5426         * features/i386/amd64.xml: Remove.
5427         * features/i386/i386-avx-avx512-linux.xml: Remove.
5428         * features/i386/i386-avx-avx512.xml: Remove.
5429         * features/i386/i386-avx-linux.xml: Remove.
5430         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5431         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5432         * features/i386/i386-avx-mpx-linux.xml: Remove.
5433         * features/i386/i386-avx-mpx.xml: Remove.
5434         * features/i386/i386-avx.xml: Remove.
5435         * features/i386/i386-linux.xml: Remove.
5436         * features/i386/i386-mmx-linux.xml: Remove.
5437         * features/i386/i386-mmx.xml: Remove.
5438         * features/i386/i386-mpx-linux.xml: Remove.
5439         * features/i386/i386-mpx.xml: Remove.
5440         * features/i386/i386.xml: Remove.
5441         * features/i386/x32-avx-avx512-linux.xml: Remove.
5442         * features/i386/x32-avx-linux.xml: Remove.
5443         * features/i386/x32-linux.xml: Remove.
5444
5445 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5446
5447         * regformats/aarch64.dat: Remove.
5448         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5449         * regformats/i386/amd64-avx-linux.dat: Remove.
5450         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5451         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5452         * regformats/i386/amd64-linux.dat: Remove.
5453         * regformats/i386/amd64-mpx-linux.dat: Remove.
5454         * regformats/i386/amd64.dat: Remove.
5455         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5456         * regformats/i386/i386-avx-linux.dat: Remove.
5457         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5458         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5459         * regformats/i386/i386-linux.dat: Remove.
5460         * regformats/i386/i386-mmx-linux.dat: Remove.
5461         * regformats/i386/i386-mpx-linux.dat: Remove.
5462         * regformats/i386/i386.dat: Remove.
5463         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5464         * regformats/i386/x32-avx-linux.dat: Remove.
5465         * regformats/i386/x32-linux.dat: Remove.
5466
5467 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5468
5469         * aarch64-tdep.c: Remove xml self tests.
5470         * amd64-linux-tdep.c: Likewise.
5471         * amd64-tdep.c: Likewise.
5472         * i386-linux-tdep.c: Likewise.
5473         * i386-tdep.c: Likewise.
5474
5475 2019-07-03  Pedro Alves  <palves@redhat.com>
5476
5477         PR cli/24732
5478         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5479         (pipe_cmd_option_defs): New.
5480         (make_pipe_cmd_options_def_group): New.
5481         (pipe_command): Use gdb::option::process_options.
5482         (pipe_command_completer): New function.
5483         (_initialize_cli_cmds): Install completer for "pipe" command.
5484
5485 2019-07-03  Pedro Alves  <palves@redhat.com>
5486
5487         * cli/cli-option.c (union option_value) <string>: New field.
5488         (struct option_def_and_value): Add ctor, move ctor, dtor and
5489         use DISABLE_COPY_AND_ASSIGN.
5490         (option_def_and_value::clear_value): New.
5491         (parse_option, save_option_value_in_ctx, get_val_type_str)
5492         (add_setshow_cmds_for_options): Handle var_string.
5493         * cli-option.h (union option_def::var_address) <string>: New
5494         field.
5495         (struct string_option_def): New.
5496         * maint-test-options.c (struct test_options_opts): Add default
5497         ctor and use DISABLE_COPY_AND_ASSIGN.
5498         <string_opt>: New field.
5499         (test_options_opts::~test_options_opts): New.
5500         (test_options_opts::dump): Also dump "-string".
5501         (test_options_option_defs): Install "string.
5502
5503 2019-07-03  Pedro Alves  <palves@redhat.com>
5504
5505         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5506         option_value with a null enumeration.
5507         (complete_options): Save the option values in the context.
5508         (save_option_value_in_ctx): New, factored out from ...
5509         (process_options): ... here.
5510         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5511         of the function.
5512         * maint-test-options.c (test_options_opts::dump): New, factored
5513         out from ...
5514         (maintenance_test_options_command_mode): ... here.
5515         (maintenance_test_options_command_completion_result): Delete.
5516         (maintenance_test_options_command_completion_text): Update
5517         comment.
5518         (maintenance_show_test_options_completion_result): Change
5519         prototype.  Just print
5520         maintenance_test_options_command_completion_text.
5521         (save_completion_result): New.
5522         (maintenance_test_options_completer_mode): Pass options context to
5523         complete_options, and then save a dump.
5524         (_initialize_maint_test_options): Use add_cmd to install "maint
5525         show test-options-completion-result".
5526
5527 2019-07-03  Pedro Alves  <palves@redhat.com>
5528
5529         * NEWS (New commands): Mention "with" and "maint with".
5530         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5531         (with_command, with_command_completer): New.
5532         (pipe_command): Adjust to new repeat_previous
5533         interface.
5534         (_initialize_cli_cmds): Install the "with" command and its "w"
5535         alias.
5536         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5537         declarations.
5538         * cli/cli-setshow.c (parse_cli_var_uinteger)
5539         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5540         argument strings for all var_types.
5541         (get_setshow_command_value_string): New, factored out from ...
5542         (do_show_command): ... this.
5543         * cli/cli-setshow.h: Include <string>.
5544         (get_setshow_command_value_string): Declare.
5545         * command.h (repeat_previous): Now returns const char *.  Adjust
5546         comment.
5547         * maint.c: Include "cli/cli-cmds.h".
5548         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5549         (_initialize_maint_cmds): Register the "maintenance with" command.
5550         * top.c (repeat_previous): Move bits from pipe_command here:
5551         Return the saved command line, if any; error out if there's no
5552         command to relaunch.
5553
5554 2019-07-03  Pedro Alves  <palves@redhat.com>
5555
5556         * NEWS (New commands): Mention "maint set/show test-settings"
5557         instead of "maint test-settings".
5558         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5559         (maintenance_test_settings_set_list): Rename to ...
5560         (maintenance_set_test_settings_list): ... this.
5561         (maintenance_test_settings_show_list): Rename to  ...
5562         (maintenance_show_test_settings_list): ... this.
5563         (maintenance_test_settings_cmd): Delete.
5564         (maintenance_test_settings_set_cmd): ...
5565         (maintenance_set_test_settings_cmd): ... this.
5566         (maintenance_test_settings_show_cmd): ...
5567         (maintenance_show_test_settings_cmd): ... this.
5568         (maintenance_test_settings_show_value_cmd):
5569         (maintenance_show_test_settings_value_cmd): ... this.
5570         (_initialize_maint_test_settings): No longer install the "maint
5571         test-settings" prefix command.  Rename "maint test-settings set"
5572         to "maint set test-settings", and "maint test-settings show" to
5573         "maint show test-settings".  Adjust all subcommands.
5574
5575 2019-07-03  Pedro Alves  <palves@redhat.com>
5576
5577         * maint-test-settings.c: Fix file's intro comment.  Replace all
5578         references to "test-options" with references to "test-settings",
5579         in comments.
5580
5581 2019-07-03  Pedro Alves  <palves@redhat.com>
5582
5583         * maint-test-settings.c (maintenance_test_settings_xxx)
5584         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5585         New.
5586         (maintenance_test_settings_enums): Use them.
5587         (maintenance_test_settings_enum): Default to
5588         maintenance_test_settings_xxx.
5589         (_initialize_maint_test_settings): Initialize
5590         MAINTENANCE_TEST_SETTINGS_FILENAME.
5591
5592 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5593
5594         * breakpoint.h (remove_breakpoints_inf): Change return type to
5595         void, move function documentation here.
5596         * breakpoint.c (remove_breakpoints_inf): Change return type to
5597         void, move function documentation to header.
5598
5599 2019-07-02  Pedro Alves  <palves@redhat.com>
5600
5601         * NEWS (Completion improvements): Mention "info threads".
5602         * thread.c (struct info_threads_opts, info_threads_option_defs)
5603         (make_info_threads_options_def_group): New.
5604         (info_threads_command): Use gdb::option::process_options.
5605         (info_threads_command_completer): New.
5606         (_initialize_thread): Use gdb::option::build_help to build the
5607         help text for "info threads".
5608
5609 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5610
5611         * defs.h (generic_load): Move from here...
5612         * symfile.h (generic_load): ... to here.  Rename name parameter
5613         to args.
5614         * symfile.c (generic_load): Add comment.
5615
5616 2019-07-01  Tom Tromey  <tromey@adacore.com>
5617
5618         * dwarf2read.c
5619         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5620         declaration of without_params.  Fix formatting.
5621
5622 2019-07-01  Tom Tromey  <tromey@adacore.com>
5623
5624         * ada-exp.y (find_primitive_type): Update.
5625         * ada-lang.h (ada_lookup_symbol): Update.
5626         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5627         parameter.
5628         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5629
5630 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5631
5632         PR breakpoints/24541
5633         * gdbarch.c: Regenerate.
5634         * gdbarch.h: Regenerate.
5635         * gdbarch.sh: Add 'stap_adjust_register'.
5636         * i386-tdep.c: Include '<unordered_set>'.
5637         (i386_stap_adjust_register): New function.
5638         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5639         * stap-probe.c (stap_parse_register_operand): Call
5640         'gdbarch_stap_adjust_register'.
5641
5642 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5643
5644         PR python/24742
5645         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5646         * python/python.c (do_start_initialization): Use 'xmalloc'
5647         instead of 'PyMem_Malloc'.
5648
5649 2019-06-28  Tom Tromey  <tromey@adacore.com>
5650
5651         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5652         for Ada.
5653
5654 2019-06-27  Tom Tromey  <tromey@adacore.com>
5655
5656         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5657         objfile_key.
5658         (arm_find_mapping_symbol, arm_record_special_symbol)
5659         (_initialize_arm_tdep): Update.
5660         (arm_objfile_data_free): Remove.
5661
5662 2019-06-27  Tom Tromey  <tromey@adacore.com>
5663
5664         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5665         to cp_print_static_field.
5666
5667 2019-06-26  Tom Tromey  <tromey@adacore.com>
5668
5669         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5670         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5671         declare.
5672
5673 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5674
5675         * features/aarch64-core.c (create_feature_aarch64_core):
5676         Regenerate.
5677         * features/aarch64-core.xml: Add cpsr flags.
5678
5679 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5680
5681         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5682         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5683
5684 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5685
5686         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5687         field.
5688         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5689         use.
5690         (arm_record_special_symbol): Don't insert new symbol in sorted
5691         position, push it at the end.
5692
5693 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5694
5695         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5696         (arm_mapping_symbol_s): Remove.
5697         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5698         (arm_mapping_symbol_vec): New typedef.
5699         (struct arm_per_objfile): Add constructor.
5700         <section_maps>: Change type to
5701         std::unique_ptr<arm_mapping_symbol_vec[]>.
5702         (arm_compare_mapping_symbols): Remove.
5703         (arm_find_mapping_symbol): Adjust to section_maps type change.
5704         (arm_objfile_data_free): Call delete on arm_per_objfile.
5705         (arm_record_special_symbol): Adjust to section_maps type change.
5706         Allocate arm_per_objfile with new.
5707
5708 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5709
5710         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5711         with the command prefix.
5712
5713 2019-06-25  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5716         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5717
5718 2019-06-25  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5721         type.
5722         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5723         protected.
5724
5725 2019-06-25  Tom Tromey  <tom@tromey.com>
5726
5727         * tui/tui-winsource.c
5728         (tui_source_window_base::set_is_exec_point_at): Add check against
5729         LOA_ADDRESS.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-source.c (tui_set_source_content): Don't check before
5734         xfree.
5735         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5736
5737 2019-06-25  Tom Tromey  <tom@tromey.com>
5738
5739         * tui/tui-winsource.h (tui_update_source_window_as_is)
5740         (tui_alloc_source_buffer, tui_line_is_displayed)
5741         (tui_addr_is_displayed): Change type of win_info.
5742         * tui/tui-winsource.c (tui_update_source_window_as_is)
5743         (tui_clear_source_content, tui_show_source_line)
5744         (tui_show_source_content, tui_source_window_base::refill)
5745         (tui_source_window_base::set_is_exec_point_at)
5746         (tui_source_window_base::set_is_exec_point_at)
5747         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5748         (tui_alloc_source_buffer, tui_line_is_displayed)
5749         (tui_addr_is_displayed): Change type of win_info.  Update.
5750         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5751         (tui_source_window_base::do_make_visible_with_new_height):
5752         Update.
5753         * tui/tui-source.c (tui_set_source_content)
5754         (tui_set_source_content_nil)
5755         (tui_source_window::do_scroll_vertical): Update.
5756         * tui/tui-layout.c (show_layout): Update.
5757         * tui/tui-disasm.c (tui_set_disassem_content)
5758         (tui_disasm_window::do_scroll_vertical): Update.
5759         * tui/tui-data.h (tui_win_content): Remove.
5760         (struct tui_gen_win_info) <content, content_size>: Remove.
5761         (struct tui_source_element): Add initializers and destructor.
5762         (union tui_which_element, struct tui_win_element): Remove.
5763         (struct tui_source_window_base) <content>: New field.
5764         (struct tui_data_window): Remove destructor.
5765         (tui_alloc_content, tui_free_win_content)
5766         (tui_free_all_source_wins_content): Don't declare.
5767         * tui/tui-data.c (tui_initialize_static_data): Update.
5768         (init_content_element, tui_alloc_content): Remove.
5769         (~tui_gen_win_info): Update.
5770         (~tui_data_window, tui_free_all_source_wins_content)
5771         (tui_free_win_content, free_content, free_content_elements):
5772         Remove.
5773
5774 2019-06-25  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-winsource.h (tui_clear_source_content)
5777         (tui_erase_source_content, tui_show_source_content): Change type
5778         of win_info.
5779         * tui/tui-winsource.c (tui_clear_source_content)
5780         (tui_erase_source_content, tui_show_source_content): Change type
5781         of win_info.
5782         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5783         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5784         win_info.
5785         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5786         win_info.
5787         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-winsource.c (tui_clear_source_content)
5792         (tui_source_window_base::set_is_exec_point_at): Update.
5793         * tui/tui-source.c (tui_set_source_content_nil): Update.
5794         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5795         a bool.
5796         * tui/tui-data.c (init_content_element): Update.
5797
5798 2019-06-25  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5801         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5802         * tui/tui-layout.c (init_and_make_win): Update.
5803         * tui/tui.h (enum tui_win_type): Update.
5804         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5805         tui_win_is_auxillary.
5806         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5807         tui_win_is_auxillary.
5808
5809 2019-06-25  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5812         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5813         (tui_delete_data_content_windows, tui_display_all_data)
5814         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5815         Update.
5816         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5817         * tui/tui-regs.c (tui_last_regs_line_no)
5818         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5819         (tui_show_registers): Update.
5820         (tui_show_register_group): Return void.  Update.
5821         (tui_display_registers_from, tui_display_reg_element_at_line)
5822         (tui_display_registers_from_line, tui_check_register_values):
5823         Update.
5824         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5825         member.
5826         (struct tui_data_window) <regs_content>: Now a std::vector.
5827         <regs_content_count>: Remove.
5828         (tui_add_content_elements, tui_free_data_content): Don't declare.
5829         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5830         (init_content_element): Remove DATA_WIN case.  Add assert.
5831         (tui_add_content_elements): Remove.
5832         (tui_data_window): Update.
5833         (tui_free_data_content): Remove.
5834         (free_content_elements): Remove DATA_WIN case.
5835
5836 2019-06-25  Tom Tromey  <tom@tromey.com>
5837
5838         * tui/tui-data.c (tui_data_item_window): Update.
5839         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5840         * tui/tui-windata.c (tui_display_all_data)
5841         (tui_display_data_from_line): Update.
5842         (tui_check_data_values): Remove.
5843         * tui/tui-regs.c (tui_show_register_group)
5844         (tui_display_reg_element_at_line): Update.
5845         * tui/tui-hooks.c (tui_register_changed)
5846         (tui_refresh_frame_and_register_information): Call
5847         tui_check_register_values.
5848         * tui/tui-data.h (struct tui_data_window) <data_content,
5849         data_content_count, data_type>: Remove.
5850         (enum tui_data_type): Remove.
5851
5852         * tui/tui-data.c (tui_data_window::clear_detail)
5853         (~tui_data_window): Update.
5854
5855 2019-06-25  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5858         declare.
5859         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5860         Rename from tui_first_data_item_displayed.  Update.
5861         (tui_data_window::refresh_all)
5862         (tui_data_window::do_scroll_vertical): Update.
5863         * tui/tui-data.h (struct tui_data_window)
5864         <first_data_item_displayed>: Declare new method.
5865
5866 2019-06-25  Tom Tromey  <tom@tromey.com>
5867
5868         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5869         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5870         contents...
5871         (tui_initialize_static_data): ...here.
5872
5873 2019-06-25  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5876         (tui_display_registers_from, tui_check_register_values): Update.
5877         (tui_display_register): Remove win_info parameter; update.
5878         (tui_get_register): Change type of parameters.
5879         * tui/tui-data.h (struct tui_data_element): Remove.
5880         (union tui_which_element) <data>: Remove.
5881         <data_window>: Change type.
5882         (struct tui_data_item_window): New.
5883         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5884         case.  Add assert.
5885         (~tui_data_item_window): New destructor.
5886         (free_content_elements): Remove DATA_ITEM_WIN case.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5891         Remove.
5892
5893 2019-06-25  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-data.h (struct tui_command_element): Remove.
5896         (union tui_which_element) <command>: Remove.
5897         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5898         assert.
5899         (free_content_elements): Remove CMD_WIN case.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-layout.c (tui_set_layout): Update.
5904         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5905         * tui/tui-data.c (layout_def): Update.
5906
5907 2019-06-25  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5910         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5911         (tui_source_window_base::set_new_height): Update.
5912         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5913         Update.
5914         (tui_set_locator_fullname, tui_set_locator_info)
5915         (tui_show_frame_info): Update.
5916         * tui/tui-source.c (tui_set_source_content)
5917         (tui_source_is_displayed): Update.
5918         * tui/tui-layout.c (show_source_disasm_command, show_data)
5919         (show_source_or_disasm_and_command): Update.
5920         * tui/tui-disasm.c (tui_set_disassem_content)
5921         (tui_get_begin_asm_address): Update.
5922         * tui/tui-data.h (struct tui_locator_element): Remove.
5923         (union tui_which_element) <locator>: Remove.
5924         (struct tui_locator_window): New.
5925         (tui_locator_win_info_ptr): Change return type.
5926         * tui/tui-data.c (_locator): Change type.
5927         (tui_locator_win_info_ptr): Change return type.
5928         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5929         (tui_alloc_content): Add assert.
5930
5931 2019-06-25  Tom Tromey  <tom@tromey.com>
5932
5933         * tui/tui-winsource.c
5934         (tui_exec_info_window::maybe_allocate_content): New method.
5935         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5936         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5937         (make_source_or_disasm_window): Add cast.
5938         * tui/tui-data.h (union tui_which_element) <simple_string>:
5939         Remove.
5940         (struct tui_source_info): New.
5941         (struct tui_source_window_base) <execution_info>: Change type.
5942         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5943         case, and add assert.
5944         (tui_alloc_content): Add assert.
5945
5946 2019-06-25  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5949         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5950         * tui/tui-data.c (tui_alloc_win_info): Remove.
5951
5952 2019-06-25  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5955         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5956         can_highlight.
5957
5958 2019-06-25  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5961         make_visible_with_new_height method.
5962         (tui_win_info::make_visible_with_new_height): New method.
5963         (tui_source_window_base::do_make_visible_with_new_height)
5964         (tui_data_window::do_make_visible_with_new_height)
5965         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5966         (make_visible_with_new_height): Remove.
5967         (tui_resize_all, tui_adjust_win_heights): Use
5968         make_visible_with_new_height method.
5969         * tui/tui-data.h (struct tui_win_info)
5970         <do_make_visible_with_new_height, make_visible_with_new_height>:
5971         New methods.
5972         (struct tui_source_window_base, struct tui_data_window)
5973         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5974         methods.
5975
5976 2019-06-25  Tom Tromey  <tom@tromey.com>
5977
5978         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5979         method.
5980         (update_tab_width): Call update_tab_width method.
5981         * tui/tui-data.h (struct tui_win_info)
5982         (struct tui_source_window_base) <update_tab_width>: New methods.
5983
5984 2019-06-25  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5987         parameter.
5988         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5989         parameter.
5990         (tui_gen_win_info::make_visible): Update.
5991         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5992         parameter.
5993         * tui/tui-data.h (enum tui_box): New enum.
5994         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5995
5996 2019-06-25  Tom Tromey  <tom@tromey.com>
5997
5998         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5999         init_and_make_win for EXEC_INFO_WIN.
6000         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6001         longer inline.
6002         (struct tui_win_info) <~tui_win_info>: Inline.
6003         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6004         Don't declare.
6005         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6006         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6007         Remove.
6008         (tui_initialize_static_data): Update.
6009         (~tui_gen_win_info): Handle more cleanup here.
6010         (~tui_source_window_base): Delete "execution_info".
6011         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6012
6013 2019-06-25  Tom Tromey  <tom@tromey.com>
6014
6015         * tui/tui-layout.c (make_command_window): Don't set
6016         can_highlight.
6017         (show_source_disasm_command): Call the reset method.
6018         (show_data): Don't set can_highlight.  Call the reset method.
6019         (tui_gen_win_info::reset): Rename from init_gen_win_info
6020         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6021         (show_source_or_disasm_and_command): Call the reset method.
6022         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6023         (struct tui_cmd_window): Set can_highlight.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6028         from make_visible.
6029         (tui_make_visible, tui_make_invisible): Rewrite.
6030         (tui_win_info::make_visible): Remove.
6031         (tui_source_window_base::make_visible): Update.
6032         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6033         method.  Moved from...
6034         (struct tui_win_info) <make_visible>: ...here.
6035
6036 2019-06-25  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-winsource.c
6039         (tui_source_window_base::do_scroll_horizontal): Remove direction
6040         parameter.
6041         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6042         direction parameter.
6043         * tui/tui-win.c (tui_win_info::forward_scroll)
6044         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6045         (tui_win_info::right_scroll): Update.
6046         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6047         direction parameter.
6048         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6049         direction parameter.
6050         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6051         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6052         Remove direction parameter.
6053         (struct tui_source_window_base, struct tui_source_window)
6054         (struct tui_disasm_window, struct tui_data_window)
6055         (struct tui_cmd_window): Update.
6056
6057 2019-06-25  Tom Tromey  <tom@tromey.com>
6058
6059         * tui/tui-winsource.h (tui_set_exec_info_content)
6060         (tui_show_exec_info_content, tui_erase_exec_info_content)
6061         (tui_clear_exec_info_content, tui_update_exec_info): Change
6062         argument to tui_source_window_base.
6063         * tui/tui-winsource.c (tui_set_exec_info_content)
6064         (tui_show_exec_info_content, tui_erase_exec_info_content)
6065         (tui_clear_exec_info_content, tui_update_exec_info): Change
6066         argument to tui_source_window_base.
6067
6068 2019-06-25  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6071         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6072
6073 2019-06-25  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6076         check.
6077
6078 2019-06-25  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6081         type to void.
6082         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6083         type to void.
6084         * tui/tui-source.c (tui_set_source_content): Update.
6085         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6086
6087 2019-06-25  Tom Tromey  <tom@tromey.com>
6088
6089         * tui/tui-win.c (window_name_completer, tui_set_focus)
6090         (tui_all_windows_info): Use name method.
6091         * tui/tui-data.h (struct tui_gen_win_info)
6092         (struct tui_source_window, struct tui_disasm_window)
6093         (struct tui_data_window, struct tui_cmd_window) <name>: New
6094         method.
6095         (tui_win_name): Don't declare.
6096         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6097         (tui_win_name): Remove.
6098
6099 2019-06-25  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-winsource.h (tui_update_source_window)
6102         (tui_update_source_window_as_is): Change parameter type.
6103         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6104         to be a tui_source_window_base.
6105         (tui_update_source_window_as_is): Likewise.
6106         * tui/tui-win.c (make_visible_with_new_height): Update.
6107
6108 2019-06-25  Tom Tromey  <tom@tromey.com>
6109
6110         * tui/tui-winsource.c (tui_erase_source_content)
6111         (tui_show_source_content, tui_show_exec_info_content)
6112         (tui_erase_exec_info_content): Use refresh_window method.
6113         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6114         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6115         from tui_refresh_win.
6116         (tui_data_window::refresh_window): New method.
6117         (tui_win_info::refresh, tui_source_window_base::refresh)
6118         (tui_refresh_all): Use refresh_window method.
6119         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6120         method.
6121         * tui/tui-regs.c (tui_display_register): Call refresh_window
6122         method.
6123         * tui/tui-layout.c (show_source_disasm_command)
6124         (show_source_or_disasm_and_command): Call refresh_window method.
6125         * tui/tui-data.h (struct tui_gen_win_info)
6126         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6127         New method.
6128
6129 2019-06-25  Tom Tromey  <tom@tromey.com>
6130
6131         * tui/tui.c (tui_rl_other_window, tui_enable)
6132         (tui_is_window_visible, tui_get_command_dimension): Update.
6133         * tui/tui-winsource.c (tui_update_source_window_as_is)
6134         (tui_clear_source_content, tui_erase_source_content)
6135         (tui_show_source_line, tui_source_window_base::refill)
6136         (tui_source_window_base::do_scroll_horizontal)
6137         (tui_source_window_base::set_is_exec_point_at)
6138         (tui_update_breakpoint_info, tui_set_exec_info_content)
6139         (tui_alloc_source_buffer, tui_line_is_displayed)
6140         (tui_addr_is_displayed): Update.
6141         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6142         (tui_check_and_display_highlight_if_needed)
6143         (tui_win_info::make_visible, tui_win_info::refresh)
6144         (tui_refresh_all): Update.
6145         * tui/tui-windata.c (tui_first_data_item_displayed)
6146         (tui_delete_data_content_windows, tui_erase_data_content)
6147         (tui_display_all_data, tui_data_window::refresh_all)
6148         (tui_check_data_values): Update.
6149         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6150         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6151         (tui_win_info::backward_scroll, tui_refresh_all_win)
6152         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6153         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6154         (tui_source_window_base::set_new_height)
6155         (tui_data_window::set_new_height)
6156         (make_invisible_and_set_new_height)
6157         (make_visible_with_new_height, new_height_ok)
6158         (parse_scrolling_args): Update.
6159         * tui/tui-stack.c (tui_show_frame_info): Update.
6160         * tui/tui-source.c (tui_set_source_content)
6161         (tui_set_source_content_nil, tui_source_is_displayed)
6162         (tui_source_window::do_scroll_vertical): Update.
6163         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6164         (tui_display_registers_from, tui_display_reg_element_at_line)
6165         (tui_check_register_values, tui_reg_command): Update.
6166         * tui/tui-layout.c (tui_default_win_height)
6167         (show_source_disasm_command, show_data, init_and_make_win)
6168         (show_source_or_disasm_and_command): Update.
6169         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6170         (tui_redisplay_readline, tui_mld_flush)
6171         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6172         (tui_getc): Update.
6173         * tui/tui-disasm.c (tui_set_disassem_content)
6174         (tui_disasm_window::do_scroll_vertical): Update.
6175         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6176         Now virtual.
6177         (struct tui_win_info): Derive from tui_gen_win_info.
6178         <~tui_win_info>: Mark as override.
6179         <generic>: Remove member.
6180         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6181         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6182         (~tui_data_window, ~tui_win_info)
6183         (tui_free_all_source_wins_content): Update.
6184         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6185
6186 2019-06-25  Tom Tromey  <tom@tromey.com>
6187
6188         * tui/tui-layout.c (init_and_make_win): Use new.
6189         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6190         destructor, initializers.
6191         (tui_alloc_generic_win_info): Don't declare.
6192         * tui/tui-data.c (_locator): Add argument to constructor.
6193         (source_win, disasm_win): New globals.
6194         (exec_info): Remove.
6195         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6196         Update.
6197         (tui_alloc_generic_win_info): Remove.
6198         (init_content_element): Use new.
6199         (tui_win_info::tui_win_info): Update.
6200         (free_content_elements) <case DATA_WIN>: Use delete.
6201
6202 2019-06-25  Tom Tromey  <tom@tromey.com>
6203
6204         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6205         * tui/tui-windata.c (tui_first_data_item_displayed)
6206         (tui_delete_data_content_windows): Update.
6207         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6208         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6209         (tui_display_registers_from, tui_check_register_values): Update.
6210         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6211         pointer.
6212         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6213         window.
6214         (tui_free_data_content): Update.
6215         (free_content_elements) <case DATA_WIN>: Free the window.
6216
6217 2019-06-25  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6220         Update.
6221         * tui/tui-layout.c (make_command_window)
6222         (show_source_disasm_command, show_data, init_and_make_win)
6223         (show_source_or_disasm_and_command): Update.
6224         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6225         method.
6226         <can_highight, is_highlighted>: Now bool.
6227         (tui_set_win_highlight): Don't declare.
6228         * tui/tui-data.c (tui_set_win_highlight): Remove.
6229
6230 2019-06-25  Tom Tromey  <tom@tromey.com>
6231
6232         * tui/tui-wingeneral.c (make_visible): Remove check of window
6233         type.
6234
6235 2019-06-25  Tom Tromey  <tom@tromey.com>
6236
6237         * tui/tui-win.c (tui_win_info::max_height)
6238         (tui_cmd_window::max_height): New methods.
6239         (new_height_ok): Call max_height.
6240         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6241         <max_height>: New method.
6242
6243 2019-06-25  Tom Tromey  <tom@tromey.com>
6244
6245         * tui/tui-win.c (tui_source_window_base::set_new_height)
6246         (tui_data_window::set_new_height): New methods.
6247         (make_invisible_and_set_new_height): Call set_new_height method.
6248         * tui/tui-data.h (struct tui_win_info)
6249         (struct tui_source_window_base, struct tui_data_window)
6250         <set_new_height>: New method.
6251
6252 2019-06-25  Tom Tromey  <tom@tromey.com>
6253
6254         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6255         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6256         tui_refresh_data_win.
6257         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6258         method.
6259         (tui_refresh_all_win): Call the refresh_all method.
6260         (tui_set_focus): Likewise.
6261         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6262         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6263         Likewise.
6264
6265 2019-06-25  Tom Tromey  <tom@tromey.com>
6266
6267         * tui/tui-winsource.h (tui_refill_source_window)
6268         (tui_set_is_exec_point_at): Don't declare.
6269         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6270         (tui_source_window_base::refill): Rename from
6271         tui_refill_source_window.
6272         (tui_source_window_base::do_scroll_horizontal): Update.
6273         (tui_source_window_base::set_is_exec_point_at): Rename from
6274         tui_set_is_exec_point_at.
6275         (tui_update_all_breakpoint_info): Update.
6276         * tui/tui-stack.c (tui_show_frame_info): Update.
6277         * tui/tui-layout.c (show_data): Add cast.
6278         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6279         * tui/tui-data.h (struct tui_source_window_base) <refill,
6280         set_is_exec_point_at>: New methods.
6281         (tui_source_windows, tui_add_to_source_windows): Update types.
6282         (tui_add_to_source_windows): Remove redundant declaration.
6283         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6284         (tui_source_windows): Change return type.
6285         (tui_clear_source_windows_detail): Update.
6286         (tui_add_to_source_windows): Change type of parameter.
6287         (tui_free_all_source_wins_content): Update.
6288
6289 2019-06-25  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-wingeneral.c (tui_win_info::refresh)
6292         (tui_source_window_base::refresh): New methods.
6293         (tui_refresh_all): Call the refresh method.
6294         * tui/tui-data.h (struct tui_win_info)
6295         (struct tui_source_window_base) <refresh>: New method.
6296
6297 2019-06-25  Tom Tromey  <tom@tromey.com>
6298
6299         * tui/tui.h (tui_is_window_visible): Return bool.
6300         * tui/tui.c (tui_is_window_visible): Return bool.
6301         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6302         (tui_make_visible, tui_make_invisible)
6303         (tui_win_info::make_visible)
6304         (tui_source_window_base::make_visible, make_all_visible)
6305         (tui_make_all_visible, tui_make_all_invisible): Update.
6306         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6307         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6308         bool.
6309         (struct tui_win_info, struct tui_source_window_base)
6310         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6311         * tui/tui-data.c (tui_init_generic_part): Update.
6312
6313 2019-06-25  Tom Tromey  <tom@tromey.com>
6314
6315         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6316         (tui_source_window_base::make_visible): New methods.
6317         (make_all_visible): Make method call.
6318         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6319         (struct tui_source_window_base, struct tui_cmd_window): Override
6320         make_visible.
6321         (tui_win_is_source_type): Don't declare.
6322         * tui/tui-data.c (tui_win_is_source_type): Remove.
6323
6324 2019-06-25  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6327         NULL check.
6328
6329 2019-06-25  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6332         Inline constructor.  Add initializers for members.
6333         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6334         constructors; now inline in class.
6335
6336 2019-06-25  Tom Tromey  <tom@tromey.com>
6337
6338         * tui/tui-regs.c (tui_show_registers): Update.
6339         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6340         bool.
6341         * tui/tui-data.c (tui_data_window::clear_detail)
6342         (tui_data_window): Update.
6343
6344 2019-06-25  Tom Tromey  <tom@tromey.com>
6345
6346         * tui/tui-windata.c (tui_display_all_data)
6347         (tui_display_data_from_line, tui_display_data_from)
6348         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6349         Update.
6350         * tui/tui-regs.c (tui_last_regs_line_no)
6351         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6352         (tui_show_registers, tui_show_register_group)
6353         (tui_display_registers_from, tui_display_reg_element_at_line)
6354         (tui_display_registers_from_line, tui_check_register_values)
6355         (tui_reg_next, tui_reg_prev): Update.
6356         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6357         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6358         tui_data_window.
6359         (struct tui_win_info) <detail>: Remove.  Add new fields from
6360         tui_data_info.
6361         (TUI_DATA_WIN): Add cast.
6362         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6363         (~tui_data_window): Simplify.
6364
6365 2019-06-25  Tom Tromey  <tom@tromey.com>
6366
6367         * tui/tui-layout.c (show_source_disasm_command)
6368         (show_source_or_disasm_and_command): Update.
6369         * tui/tui-io.c (update_cmdwin_start_line)
6370         (tui_redisplay_readline): Update.
6371         * tui/tui-data.h (struct tui_command_info): Remove.
6372         (struct tui_win_info) <detail>: Remove command_info member.
6373         (struct tui_data_window) <start_line>: New member, from
6374         tui_command_info.
6375         (TUI_CMD_WIN): Add casts.
6376
6377 2019-06-25  Tom Tromey  <tom@tromey.com>
6378
6379         * tui/tui-winsource.c (tui_update_source_window)
6380         (tui_refill_source_window)
6381         (tui_source_window_base::do_scroll_horizontal)
6382         (tui_update_breakpoint_info, tui_set_exec_info_content)
6383         (tui_show_exec_info_content, tui_erase_exec_info_content)
6384         (tui_clear_exec_info_content): Update.
6385         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6386         Update.
6387         * tui/tui-win.c (make_invisible_and_set_new_height)
6388         (make_visible_with_new_height): Update.
6389         * tui/tui-source.c (tui_set_source_content)
6390         (tui_show_symtab_source): Update.
6391         * tui/tui-layout.c (extract_display_start_addr)
6392         (show_source_disasm_command, show_data)
6393         (make_source_or_disasm_window)
6394         (show_source_or_disasm_and_command): Update.
6395         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6396         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6397         "gdbarch".
6398         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6399         to tui_source_window_base.
6400         (struct tui_win_info) <detail>: Remove source_info member.
6401         (struct tui_source_window_base) <has_locator>: Inline.
6402         Move contents from tui_source_info; rename has_locator member to
6403         m_has_locator.
6404         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6405         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6406         header file.
6407         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6408         Simplify.
6409         (tui_free_all_source_wins_content): Cast to
6410         tui_source_window_base.
6411
6412 2019-06-25  Tom Tromey  <tom@tromey.com>
6413
6414         * tui/tui-win.c (make_invisible_and_set_new_height)
6415         (make_visible_with_new_height): Call has_locator method.
6416         * tui/tui-layout.c (show_source_disasm_command, show_data)
6417         (show_source_or_disasm_and_command): Update for bool change.
6418         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6419         (tui_win_info) <has_locator>: New method.
6420         (struct tui_source_window_base) <has_locator>: New method.
6421         (tui_win_has_locator): Don't declare.
6422         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6423         from tui_win_has_locator.
6424         (tui_source_window_base): Use false, not FALSE.
6425
6426 2019-06-25  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6429         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6430         clear_detail method directly.
6431         (tui_clear_win_detail): Remove.
6432
6433 2019-06-25  Tom Tromey  <tom@tromey.com>
6434
6435         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6436         "this", not TUI_DISASM_WIN.
6437
6438 2019-06-25  Tom Tromey  <tom@tromey.com>
6439
6440         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6441         declare.
6442         * tui/tui-winsource.c
6443         (tui_source_window_base::do_scroll_horizontal): Rename from
6444         tui_horizontal_source_scroll.
6445         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6446         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6447         from tui_vertical_data_scroll.
6448         * tui/tui-win.h (tui_scroll): Don't declare.
6449         * tui/tui-win.c (tui_win_info::forward_scroll)
6450         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6451         (tui_win_info::right_scroll): Rename and update.
6452         (tui_scroll_forward_command, tui_scroll_backward_command)
6453         (tui_scroll_left_command, tui_scroll_right_command): Update.
6454         (tui_scroll): Remove.
6455         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6456         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6457         from tui_vertical_source_scroll.
6458         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6459         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6460         from tui_vertical_disassem_scroll.
6461         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6462         do_scroll_horizontal>: New methods.
6463         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6464         Likewise.
6465         (struct tui_source_window_base): Add do_scroll_horizontal.
6466         (struct tui_source_window, struct tui_disasm_window): Add
6467         do_scroll_vertical.
6468         (struct tui_data_window, struct tui_cmd_window): Add
6469         do_scroll_horizontal and do_scroll_vertical.
6470         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6471
6472 2019-06-25  Tom Tromey  <tom@tromey.com>
6473
6474         * tui/tui-data.h (struct tui_source_window_base): New struct.
6475         (struct tui_source_window): Derive from tui_source_window_base.
6476         (struct tui_disasm_window): New struct.
6477         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6478         from tui_source_window::clear_detail.
6479         (tui_source_window_base): Rename from tui_source_window.
6480         (~tui_source_window_base): Rename from ~tui_source_window.
6481         (tui_alloc_win_info): Create a tui_disasm_window.
6482
6483 2019-06-25  Tom Tromey  <tom@tromey.com>
6484
6485         * tui/tui-data.h (struct tui_source_window)
6486         (struct tui_data_window): Declare destructors.
6487         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6488         destructors.
6489         (tui_win_info): Simplify.
6490
6491 2019-06-25  Tom Tromey  <tom@tromey.com>
6492
6493         * tui/tui-winsource.c (tui_display_main)
6494         (tui_update_source_windows_with_addr)
6495         (tui_update_all_breakpoint_info): Update.
6496         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6497         (new_height_ok, parse_scrolling_args): Update.
6498         * tui/tui-stack.c (tui_show_frame_info): Update.
6499         * tui/tui-data.h (struct tui_list): Remove.
6500         (tui_source_windows): Return a reference to a std::vector.
6501         * tui/tui-data.c (source_windows): Now a std::vector.
6502         (tui_source_windows): Change return type.
6503         (tui_clear_source_windows): Rewrite.
6504         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6505         (tui_free_all_source_wins_content): Rewrite.
6506
6507 2019-06-25  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6510         (struct tui_data_window, struct tui_cmd_window): Declare
6511         clear_detail method.
6512         * tui/tui-data.c (tui_source_window::clear_detail)
6513         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6514         methods.
6515         (tui_clear_win_detail): Simplify.
6516
6517 2019-06-25  Tom Tromey  <tom@tromey.com>
6518
6519         * tui/tui-layout.c (make_source_window, make_disasm_window)
6520         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6521         Return the new window.
6522         (show_source_disasm_command, show_data)
6523         (show_source_or_disasm_and_command): Update.
6524
6525 2019-06-25  Tom Tromey  <tom@tromey.com>
6526
6527         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6528         parameter.  Return the new window.
6529         (show_source_disasm_command): Update and remove NULL check.
6530         (show_source_or_disasm_and_command): Update.
6531
6532 2019-06-25  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6535
6536 2019-06-25  Tom Tromey  <tom@tromey.com>
6537
6538         * tui/tui-data.h (struct tui_win_info): Make constructor
6539         protected.  Make destructor virtual.  Add initializers.
6540         (tui_source_window, tui_data_window, tui_cmd_window): New
6541         classes.
6542         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6543         constructor.  Add "type" parameter.
6544         (tui_source_window, tui_data_window, tui_cmd_window): New
6545         constructors.
6546         (tui_alloc_win_info): Instantiate the appropriate subclass.
6547
6548 2019-06-25  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-win.c (tui_resize_all): Use delete.
6551         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6552         destructor.
6553         (tui_free_window): Don't declare.
6554         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6555         Update.
6556
6557 2019-06-25  Tom Tromey  <tom@tromey.com>
6558
6559         * tui/tui-data.h (struct tui_win_info): Add constructor.
6560         * tui/tui-data.c (tui_alloc_win_info): Use new.
6561         (tui_free_window): Use delete.
6562
6563 2019-06-22  Tom Tromey  <tom@tromey.com>
6564
6565         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6566         declare.
6567         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6568
6569 2019-06-22  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6572         declare.
6573         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6574
6575 2019-06-22  Tom de Vries  <tdevries@suse.de>
6576
6577         * dwarf2read.c (create_addrmap_from_aranges)
6578         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6579         instead of '%zu'.
6580
6581 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6582
6583         * dwarf2read.h (dwarf2_section_info_def): Remove.
6584         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6585         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6586         std::vector<dwarf2_section_info>.
6587         (struct dwo_file) <~dwo_file>: Remove.
6588         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6589         types field.
6590         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6591         (dwarf2_read_debug_names): Likewise.
6592         (create_debug_types_hash_table): Change parameter type to
6593         array_view, adjust code accordingly.
6594         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6595         (partial_die_info::fixup): Likewise.
6596         (determine_prefix): Likewise.
6597         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6598
6599 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6600
6601         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6602         gdb_bfd_ref_ptr.
6603         <~dwo_file>: Remove call to gdb_bfd_unref.
6604         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6605         gdb_bfd_ref_ptr::get.
6606
6607 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6608
6609         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6610         type to htab_up.
6611         * dwarf2read.c (struct dwo_file): Initialize fields.
6612         <~dwo_file>: New.
6613         (free_dwo_file): Remove, move content to ~dwo_file.
6614         (struct dwo_file_deleter): Remove.
6615         (dwo_file_up>: Remove custom deleter.
6616         (free_dwo_files): Remove.
6617         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6618         dwo_files.
6619         (process_skeletonless_type_units): Call unique_ptr::get.
6620         (allocate_dwo_file_hash_table): Add deleter to created hash
6621         table.  Change return type to htab_up.
6622         (lookup_dwo_file_slot): Don't memset dwo_file, call
6623         unique_ptr::get.
6624         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6625         (create_dwo_unit_in_dwp_v2): Likewise.
6626         (open_and_init_dwo_file): Likewise.
6627         (free_dwo_file_from_slot): Remove.
6628
6629 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6630
6631         * dwarf2read.h (struct dwarf2_section_info) <readin,
6632         is_virtual>: Change type to bool.
6633         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6634         true instead of 1.
6635
6636 2019-06-19  Tom Tromey  <tom@tromey.com>
6637
6638         * tui/tui-data.h (tui_init_content_element): Don't declare.
6639
6640 2019-06-19  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-data.h (tui_init_win_info): Don't declare.
6643
6644 2019-06-19  Tom de Vries  <tdevries@suse.de>
6645
6646         * dwarf2read.h (abstract_to_concrete): Change type to
6647         std::unordered_map<sect_offset, std::vector<sect_offset>,
6648         gdb::hash_enum<sect_offset>>.
6649
6650 2019-06-19  Tom Tromey  <tromey@adacore.com>
6651
6652         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6653         EVAL_AVOID_SIDE_EFFECTS specially.
6654
6655 2019-06-19  Tom Tromey  <tromey@adacore.com>
6656
6657         * source-cache.c (highlighter): New global.
6658         (source_cache::get_source_lines): Create a highlighter on demand.
6659
6660 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * defs.h (deprecated_interactive_hook): Delete declaration.
6663         * interps.c (clear_interpreter_hooks): Remove use of
6664         deprecated_interactive_hook.
6665         * top.c (deprecated_interactive_hook): Delete definition.
6666         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6667
6668 2019-06-18  Tom de Vries  <tdevries@suse.de>
6669
6670         PR gdb/24515
6671         * dwarf2read.h (abstract_to_concrete): Change type from
6672         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6673         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6674         * dwarf2read.c (read_variable): Update.
6675         (dwarf2_fetch_die_loc_sect_off): Update.
6676
6677 2019-06-17  Tom de Vries  <tdevries@suse.de>
6678
6679         PR gdb/24617
6680         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6681         accessing parent[parent_len - 1].
6682
6683 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6684
6685         PR gdb/24364
6686         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6687         call dtrace_process_dof with NULL dof.
6688
6689 2019-06-16  Tom de Vries  <tdevries@suse.de>
6690
6691         PR gdb/24445
6692         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6693
6694 2019-06-16  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6697         (make_all_visible): Use address of member.
6698
6699 2019-06-16  Tom Tromey  <tom@tromey.com>
6700
6701         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6702         (tui_free_window, free_content, free_content_elements): Remove
6703         unnecessary cast.
6704         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6705         cast.
6706         * tui/tui-regs.c (tui_show_register_group)
6707         (tui_display_registers_from, tui_display_reg_element_at_line):
6708         Remove unnecessary cast.
6709
6710 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * linux-nat.c (normal_mask): Delete.
6713         (_initialize_linux_nat): Don't initialise normal_mask.
6714
6715 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6716
6717         PR gdb/24445
6718         * dwarf-index-write.h (write_psymtabs_to_index): Add
6719         dwz_basename parameter.
6720         * dwarf-index-write.c (write_gdbindex): Move file writing to
6721         write_gdbindex_1.  Change return type void.
6722         (assert_file_size): Move up, remove filename parameter.
6723         (write_gdbindex_1): New function.
6724         (write_debug_names): Change return type to void, call
6725         assert_file_size.
6726         (struct index_wip_file): New struct.
6727         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6728         file logic to index_wip_file.  Write index for dwz file if
6729         needed.
6730         (save_gdb_index_command): Pass basename of dwz file, if present.
6731         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6732         build-id of dwz file, if present.
6733         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6734         (dwarf2_get_dwz_file): Likewise.
6735         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6736         (dwarf2_get_dwz_file): Likewise.
6737
6738 2019-06-16  Tom Tromey  <tom@tromey.com>
6739
6740         * coffread.c (process_coff_symbol): Use xstrdup.
6741         * value.c (create_internalvar): Use xstrdup.
6742
6743 2019-06-16  Tom Tromey  <tom@tromey.com>
6744
6745         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6746         * breakpoint.c (stopin_command, stopat_command)
6747         (until_break_command, decode_location_default): Remove unnecessary
6748         cast.
6749         * utils.c (subset_compare): Remove unnecessary cast.
6750         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6751         cast.
6752         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6753         cast.
6754         * infcmd.c (path_command): Remove unnecessary cast.
6755         * coffread.c (decode_type): Remove unnecessary cast.
6756         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6757         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6758         * tui/tui-stack.c (tui_show_locator_content)
6759         (tui_show_frame_info): Remove unnecessary cast.
6760         * tui/tui-win.c (tui_scroll_forward_command)
6761         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6762         (parse_scrolling_args): Remove unnecessary cast.
6763         * tui/tui-data.c (init_win_info, tui_del_window)
6764         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6765         (free_content_elements): Remove unnecessary cast.
6766         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6767         unnecessary cast.
6768         * tui/tui-source.c (tui_set_source_content)
6769         (tui_vertical_source_scroll): Remove unnecessary cast.
6770         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6771         cast.
6772         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6773         * tui/tui-regs.c (tui_display_registers_from)
6774         (tui_display_register): Remove unnecessary cast.
6775         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6776         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6777         (make_visible): Remove unnecessary cast.
6778         * tui/tui-winsource.c (tui_erase_source_content)
6779         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6780         unnecessary cast.
6781         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6782         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6783         * stabsread.c (read_type, read_array_type, read_range_type):
6784         Remove unnecessary cast.
6785         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6786         (parse_symbol, parse_type, upgrade_type, parse_external)
6787         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6788         unnecessary cast.
6789         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6790
6791 2019-06-16  Tom Tromey  <tom@tromey.com>
6792
6793         * tui/tui-data.c (tui_alloc_generic_win_info)
6794         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6795         checks.
6796
6797 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6798             Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * f-typeprint.c (f_print_type): Don't return early for not
6801         associated or not allocated types.
6802         (f_type_print_varspec_suffix): Add print_rank parameter and print
6803         ranks of array types in case they dangling.
6804         (f_type_print_base): Add print_rank parameter.
6805
6806 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * NEWS: Mention new MI commands.
6809         * break-catch-throw.c (enum exception_event_kind): Move to
6810         breakpoint.h.
6811         (print_mention_exception_catchpoint): Output text as a single
6812         message.
6813         (catch_exception_command_1): Rename to...
6814         (catch_exception_event): ...this, make non-static, update header
6815         command, and change some parameter types.
6816         (catch_catch_command): Update for changes to
6817         catch_exception_command_1.
6818         (catch_throw_command): Likewise.
6819         (catch_rethrow_command): Likewise.
6820         * breakpoint.c (enum exception_event_kind): Delete.
6821         * breakpoint.h (enum exception_event_kind): Moved here from
6822         break-catch-throw.c.
6823         (catch_exception_event): Declare.
6824         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6825         (mi_cmd_catch_throw): New function.
6826         (mi_cmd_catch_rethrow): New function.
6827         (mi_cmd_catch_catch): New function.
6828         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6829         'catch-catch' entries.
6830         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6831         (mi_cmd_catch_rethrow): Declare.
6832         (mi_cmd_catch_catch): Declare.
6833
6834 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6835
6836         * annotate.c (annotate_source_line): Change return type to void,
6837         update implementation to match.
6838         * annotate.h (annotate_source_line): Change return type to void,
6839         update header comment.
6840         * stack.c (print_frame_info): Don't change what frame information
6841         is printed based on whether annotations are on or not.
6842
6843 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6844
6845         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6846         (annotate_source): Make static.
6847         (annotate_source_line): Moved from source.c and renamed from
6848         identify_source_line.  Update the return type.
6849         * annotate.h (annotate_source): Delete declaration.
6850         (annotate_source_line): Declaration moved from source.h, and
6851         renamed from identify_source_line.  Return type updated.
6852         * source.c (identify_source_line): Moved to annotate.c and renamed
6853         to annotate_source_line.
6854         (info_line_command): Remove check of annotation_level.
6855         * source.h (identify_source_line): Move declaration to annotate.h
6856         and rename to annotate_source_line.
6857         * stack.c: Add 'annotate.h' include.
6858         (print_frame_info): Remove check of annotation_level before
6859         calling annotate_source_line.
6860
6861 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6862
6863         * source-cache.c (source_cache::get_plain_source_lines): Use
6864         open_source_file_with_line_charpos instead of just
6865         open_source_file, remove call to find_source_lines.
6866         (source_cache::get_source_lines): Likewise.
6867         * source.c (find_source_lines): Make static.
6868         (get_filename_and_charpos): Renamed into...
6869         (open_source_file_with_line_charpos): ..this along with changes to
6870         return a scoped_fd, and some other minor clean ups.
6871         (identify_source_line): Use open_source_file_with_line_charpos.
6872         (search_command_helper): Use open_source_file_with_line_charpos
6873         instead of just open_source_file, remove call to
6874         find_source_lines.
6875         * source.h (open_source_file_with_line_charpos): Declare new
6876         function.
6877         (find_source_lines): Delete declaration.
6878
6879 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6880
6881         * source.c (get_filename_and_charpos): Remove fullname
6882         parameter.
6883         (identify_source_line): Update call to get_filename_and_charpos.
6884
6885 2019-06-14  Tom Tromey  <tromey@adacore.com>
6886
6887         PR gdb/24502:
6888         * ui-style.h (skip_ansi_escape): Update comment.
6889         * ui-file.h (class no_terminal_escape_file): New class.
6890         * ui-file.c (no_terminal_escape_file::write)
6891         (no_terminal_escape_file::puts): New methods.
6892         * cli/cli-logging.c (handle_redirections): Use
6893         no_terminal_escape_file.
6894
6895 2019-06-14  Tom Tromey  <tromey@adacore.com>
6896
6897         * NEWS: Move convenience variable news above Python news.
6898
6899 2019-06-14  Tom Tromey  <tom@tromey.com>
6900
6901         * gnulib: Move directory to top-level.
6902         * configure.ac: Don't configure gnulib.
6903         * configure: Rebuild.
6904         * common/common-defs.h: Use new path to gnulib.
6905         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6906         (GNULIB_H): Remove.
6907         (INCGNU): Look in new gnulib location.
6908         (HFILES_NO_SRCDIR): Remove gnulib files.
6909         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6910         (generated_files): Remove GNULIB_H.
6911         ($(LIBGNU), all-lib): Remove targets.
6912         (distclean): Don't mention GNULIB_BUILDDIR.
6913         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6914
6915 2019-06-14  Tom Tromey  <tromey@adacore.com>
6916
6917         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6918         Warn if symbol file does not provide any symbols.
6919
6920 2019-06-14  Tom Tromey  <tromey@adacore.com>
6921
6922         * source.c (find_and_open_source): Respect basenames_may_differ.
6923
6924 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6925
6926         * annotate.c (annotate_breakpoints_invalid): Make use of
6927         scoped_restore_terminal_state.
6928         (annotate_frames_invalid): Likewise.
6929
6930 2019-06-14  Tom Tromey  <tromey@adacore.com>
6931
6932         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6933         allow assignment to an internalvar.
6934
6935 2019-06-14  Tom Tromey  <tromey@adacore.com>
6936
6937         * ada-lex.l: Allow "_" in attribute names.
6938
6939 2019-06-14  Tom Tromey  <tromey@adacore.com>
6940
6941         PR gdb/24653:
6942         * regcache.c (registers_changed): Don't call alloca.
6943         * top.c (execute_command): Don't call alloca.
6944
6945 2019-06-13  Pedro Alves  <palves@redhat.com>
6946
6947         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6948         'expression'.  When parsing an expression, error out if there's
6949         junk after "unlimited".
6950         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6951         (do_set_command): Adjust calls to is_unlimited_literal.
6952
6953 2019-06-13  Pedro Alves  <palves@redhat.com>
6954
6955         * compile/compile.c (make_compile_options_def_group): Add braces
6956         around array_view initializer.
6957         * thread.c (make_thread_apply_all_options_def_group)
6958         (make_thread_apply_all_options_def_group): Likewise.
6959
6960 2019-06-13  Pedro Alves  <palves@redhat.com>
6961
6962         * NEWS (New commands): Mention "maint test-options
6963         require-delimiter", "maint test-options unknown-is-error", "maint
6964         test-options unknown-is-operand" and "maint show
6965         test-options-completion-result".
6966         (New command options, command completion): New section.
6967         (Completion improvements): New section.
6968         Mention that you can abbreviate "unlimited".
6969
6970 2019-06-13  Pedro Alves  <palves@redhat.com>
6971
6972         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6973         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6974         * unittests/cli-utils-selftests.c (test_parse_flags)
6975         (test_parse_flags_qcs): Delete.
6976         (test_cli_utils): Don't call deleted functions.
6977
6978 2019-06-13  Pedro Alves  <palves@redhat.com>
6979
6980         * thread.c: Include "cli/cli-option.h".
6981         (tp_array_compar_ascending): Global.
6982         (tp_array_compar): Delete function.
6983         (tp_array_compar_ascending, tp_array_compar_descending): New
6984         functions.
6985         (ascending_option_def, qcs_flag_option_def)
6986         (thr_qcs_flags_option_defs)
6987         (make_thread_apply_all_options_def_group)
6988         (make_thread_apply_options_def_group): New.
6989         (thread_apply_all_command): Use gdb::option::process_options.
6990         (thread_apply_command_completer)
6991         (thread_apply_all_command_completer): New.
6992         (thread_apply_command): Use gdb::option::process_options.
6993         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6994         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6995         to generate help text of "thread apply".  Adjust "taas"'s help.
6996         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6997         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6998
6999 2019-06-13  Pedro Alves  <palves@redhat.com>
7000
7001         * thread.c (thread_apply_command): Check for invalid TID with
7002         isdigit instead of !isalpha.
7003
7004 2019-06-13  Pedro Alves  <palves@redhat.com>
7005
7006         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7007         (validate_flags_qcs): New.
7008         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7009         (validate_flags_qcs): Declare.
7010         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7011         (make_frame_apply_options_def_group): New.
7012         (frame_apply_command_count): Process options with
7013         gdb::option::process_options.
7014         (frame_apply_completer): New.
7015         (frame_apply_level_completer, frame_apply_all_completer)
7016         (frame_apply_completer): New.
7017         (_initialize_stack): Update help of "frame apply", "frame apply
7018         level", "frame apply all" and "faas" to mention supported options
7019         and install command completers.
7020         * stack.h (frame_apply_all_completer): Declare.
7021         * thread.c: Include "stack.h".
7022         (tfaas_command): Add "--".
7023         (_initialize_thread): Update help "tfaas" to mention supported
7024         options and install command completer.
7025
7026 2019-06-13  Pedro Alves  <palves@redhat.com>
7027
7028         * completer.c (complete_nested_command_line): New.
7029         (gdb_completion_word_break_characters_throw): Add assertion.
7030         * completer.h (complete_nested_command_line): Declare.
7031
7032 2019-06-13  Pedro Alves  <palves@redhat.com>
7033
7034         * stack.c (parse_backtrace_qualifiers): New.
7035         (backtrace_command): Use it.
7036         (backtrace_command_completer): Complete on qualifiers.
7037
7038 2019-06-13  Pedro Alves  <palves@redhat.com>
7039
7040         * frame.c: Include "cli/cli-option.h.
7041         (user_set_backtrace_options): New.
7042         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7043         Delete.
7044         (get_prev_frame): Adjust.
7045         (boolean_option_def, uinteger_option_def)
7046         (set_backtrace_option_defs): New.
7047         (_initialize_frame): Adjust and use
7048         gdb::option::add_setshow_cmds_for_options to install "set
7049         backtrace past-main" and "set backtrace past-entry".
7050         * frame.h: Include "cli/cli-option.h".
7051         (struct frame_print_options): Forward declare.
7052         (print_frame_arguments_all, print_frame_arguments_scalars)
7053         (print_frame_arguments_none): Declare.
7054         (print_entry_values): Delete declaration.
7055         (struct frame_print_options, user_frame_print_options): New.
7056         (struct set_backtrace_options): New.
7057         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7058         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7059         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7060         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7061         (list_args_or_locals): Add frame_print_options parameter.
7062         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7063         * python/py-framefilter.c (enumerate_args): Pass down
7064         USER_FRAME_PRINT_OPTIONS.
7065         * stack.c: Include "cli/cli-option.h".
7066         (print_frame_arguments_all, print_frame_arguments_scalars)
7067         (print_frame_arguments_none): Declare.
7068         (print_raw_frame_arguments, print_entry_values): Delete.
7069         (user_frame_print_options): New.
7070         (boolean_option_def, enum_option_def, frame_print_option_defs):
7071         New.
7072         (struct backtrace_cmd_options): New.
7073         (bt_flag_option_def): New.
7074         (backtrace_command_option_defs): New.
7075         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7076         (print_frame_arg, read_frame_arg, print_frame_args)
7077         (print_frame_info, print_frame): Add frame_print_options parameter
7078         and use it.
7079         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7080         (backtrace_command_1): Add frame_print_options and
7081         backtrace_cmd_options parameters and use them.
7082         (make_backtrace_options_def_group): New.
7083         (backtrace_command): Process command options with
7084         gdb::option::process_options.
7085         (backtrace_command_completer): New.
7086         (_initialize_stack): Extend "backtrace"'s help to mention
7087         supported options.  Install completer for "backtrace".
7088         Install some settings commands with add_setshow_cmds_for_options.
7089
7090 2019-06-13  Pedro Alves  <palves@redhat.com>
7091
7092         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7093         and that "set/show print raw frame-arguments" are now deprecated.
7094
7095         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7096         command.
7097         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7098         * stack.c (_initialize_stack): Install "set/show print
7099         raw-frame-arguments", and deprecate "set/show print raw
7100         frame-arguments".
7101         * valprint.c (_initialize_valprint): Deprecate "set/show print
7102         raw".
7103
7104 2019-06-13  Pedro Alves  <palves@redhat.com>
7105
7106         * compile/compile.c (struct compile_options): New.
7107         (compile_flag_option_def, compile_command_option_defs)
7108         (make_compile_options_def_group): New.
7109         (compile_file_command): Handle options with
7110         gdb::option::process_options.
7111         (compile_file_command_completer): New function.
7112         (compile_code_command): Handle options with
7113         gdb::option::process_options.
7114         (compile_code_command_completer): New function.
7115         (_initialize_compiler): Install completers for "compile code" and
7116         "compile file".  Mention available options in "compile code" and
7117         "compile code"'s help.
7118         * completer.c (advance_to_completion_word): New, factored out from
7119         ...
7120         (advance_to_expression_complete_word_point): ... this.
7121         (advance_to_filename_complete_word_point): New.
7122         * completer.h (advance_to_filename_complete_word_point): New
7123         declaration.
7124
7125 2019-06-13  Pedro Alves  <palves@redhat.com>
7126
7127         * compile/compile.c: Include "cli/cli-option.h".
7128         (compile_print_value): Scope data pointer is now a
7129         value_print_options pointer; adjust.
7130         (compile_print_command): Process options.  Scope data pointer is
7131         now a value_print_options pointer; adjust.
7132         (_initialize_compile): Update "compile print"'s help to include
7133         supported options.  Install a completer for "compile print".
7134         * cp-valprint.c (show_vtblprint, show_objectprint)
7135         (show_static_field_print): Delete.
7136         (_initialize_cp_valprint): Don't install "set print
7137         static-members", "set print vtbl", "set print object" here.
7138         * printcmd.c: Include "cli/cli-option.h" and
7139         "common/gdb_optional.h".
7140         (print_command_parse_format): Rework to fill in a
7141         value_print_options instead of a format_data.
7142         (print_value): Change parameter type from format_data pointer to
7143         value_print_options reference.  Adjust.
7144         (print_command_1): Process options.  Adjust to pass down a
7145         value_print_options.
7146         (print_command_completer): New.
7147         (_initialize_printcmd): Install print_command_completer as
7148         handle_brkchars completer for the "print" command.  Update
7149         "print"'s help to include supported options.
7150         * valprint.c: Include "cli/cli-option.h".
7151         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7152         here from cp-valprint.c.
7153         (boolean_option_def, uinteger_option_def)
7154         (value_print_option_defs, make_value_print_options_def_group):
7155         New.  Use gdb::option::add_setshow_cmds_for_options to install
7156         "set print elements", "set print null-stop", "set print repeats",
7157         "set print pretty", "set print union", "set print array", "set
7158         print address", "set print symbol", "set print array-indexes".
7159         * valprint.h: Include <string> and "cli/cli-option.h".
7160         (make_value_print_options_def_group): Declare.
7161         (print_value): Change parameter type from format_data pointer to
7162         value_print_options reference.
7163         (print_command_completer): Declare.
7164
7165 2019-06-13  Pedro Alves  <palves@redhat.com>
7166
7167         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7168         (COMMON_SFILES): Add maint-test-settings.c.
7169         * cli/cli-decode.c (boolean_enums): New global, factored out from
7170         ...
7171         (add_setshow_boolean_cmd): ... here.
7172         * cli/cli-decode.h (boolean_enums): Declare.
7173         * cli/cli-option.c: New file.
7174         * cli/cli-option.h: New file.
7175         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7176         factored out from ...
7177         (parse_cli_boolean_value(const char *)): ... this.
7178         (is_unlimited_literal): Change parameter type to pointer to
7179         pointer.  Adjust and advance ARG pointer.
7180         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7181         (parse_cli_var_enum): New, factored out from ...
7182         (do_set_command): ... this.  Adjust.
7183         * cli/cli-setshow.h (parse_cli_boolean_value)
7184         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7185         (parse_cli_var_enum): Declare.
7186         * cli/cli-utils.c: Include "cli/cli-option.h".
7187         (get_ulongest): New.
7188         * cli/cli-utils.h (get_ulongest): Declare.
7189         (check_for_argument): New overloads.
7190         * maint-test-options.c: New file.
7191
7192 2019-06-13  Pedro Alves  <palves@redhat.com>
7193
7194         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7195         parse a range if "-" is at the end of the string.
7196
7197 2019-06-13  Pedro Alves  <palves@redhat.com>
7198
7199         * cli/cli-setshow.c (parse_auto_binary_operation)
7200         (parse_cli_boolean_value): Don't allow "o".
7201
7202 2019-06-13  Pedro Alves  <palves@redhat.com>
7203
7204         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7205         * NEWS: Mention maint test-settings KIND.
7206         * maint-test-settings.c: New file.
7207
7208 2019-06-13  Pedro Alves  <palves@redhat.com>
7209
7210         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7211         completer.
7212         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7213         "set" completers.
7214
7215 2019-06-13  Pedro Alves  <palves@redhat.com>
7216
7217         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7218         after item.
7219
7220 2019-06-13  Pedro Alves  <palves@redhat.com>
7221
7222         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7223
7224 2019-06-13  Pedro Alves <palves@redhat.com>
7225
7226         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7227         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7228         call.
7229         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7230         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7231         calls.
7232         (check_for_argument): Skip spaces after argument.
7233
7234 2019-06-13  Pedro Alves  <palves@redhat.com>
7235
7236         * thread.c (thread_apply_command): Adjust TID parsing.
7237         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7238         detected before end of string.
7239         (tid_is_in_list): Error out if LIST is invalid.
7240
7241 2019-06-13  Pedro Alves  <palves@redhat.com>
7242
7243         * completer.c (complete_line_internal_1): Rewind completion word
7244         point.
7245         (completion_tracker::advance_custom_word_point_by): Change
7246         parameter type to int.
7247         * completer.h (completion_tracker::advance_custom_word_point_by):
7248         Likewise.
7249
7250 2019-06-13  Pedro Alves  <palves@redhat.com>
7251
7252         * completer.c (advance_to_completion_word): Handle delimiters.
7253
7254 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7255
7256         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7257
7258 2019-06-11  Tom Tromey  <tom@tromey.com>
7259
7260         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7261         (xmalloc_failed): Move to alloc.c.
7262         * alloc.c: New file.
7263         * Makefile.in (COMMON_SFILES): Add alloc.c.
7264
7265 2019-06-11  Tom Tromey  <tom@tromey.com>
7266
7267         * nat/linux-waitpid.c: Don't include server.h.
7268         (linux_debug): Remove.
7269         (my_waitpid): Update.
7270
7271 2019-06-11  Tom Tromey  <tromey@adacore.com>
7272
7273         * infcall.c (_initialize_infcall): Remove trailing newline from
7274         help.
7275         * user-regs.c (_initialize_user_regs): Remove trailing newline
7276         from help.
7277         * typeprint.c (_initialize_typeprint): Remove trailing newline
7278         from help.
7279         * reverse.c (_initialize_reverse): Remove trailing newlines from
7280         help.
7281         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7282         from help.
7283         * language.c (add_set_language_command): Remove trailing newline
7284         from help.
7285         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7286         help.
7287         * disasm.c (_initialize_disasm): Remove trailing newline from
7288         help.
7289         * top.c (init_main): Remove trailing newline from help.
7290         * interps.c (_initialize_interpreter): Remove trailing newline
7291         from help.
7292         * btrace.c (_initialize_btrace): Remove trailing newlines from
7293         help.
7294         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7295         from help.
7296         * python/python.c (_initialize_python): Remove trailing newline
7297         from help.
7298         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7299         help.
7300         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7301         from help.  Reformat some text.
7302         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7303         from help.
7304         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7305         newline from help.
7306
7307 2019-06-11  Tom Tromey  <tromey@adacore.com>
7308
7309         * darwin-nat.c (darwin_decode_exception_message)
7310         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7311
7312 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * valops.c (value_slice): Check for not allocated or not
7315         associated values.
7316
7317 2019-06-10  Tom de Vries  <tdevries@suse.de>
7318
7319         PR gdb/24618
7320         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7321         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7322         invalid.
7323
7324 2019-06-10  Tom de Vries  <tdevries@suse.de>
7325
7326         PR gdb/24611
7327         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7328         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7329
7330 2019-06-10  Tom de Vries  <tdevries@suse.de>
7331
7332         PR symtab/24545
7333         * symtab.c (struct demangled_name_entry): Add language field.
7334         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7335         static minimal symbol".  Set and use language field.
7336
7337 2019-06-10  Tom Tromey  <tromey@adacore.com>
7338
7339         * ada-lang.c (_initialize_ada_language): Update help text.
7340
7341 2019-06-10  Tom Tromey  <tromey@adacore.com>
7342
7343         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7344         with a newline.
7345         * guile/guile.c (handle_boot_error): Don't end warning with a
7346         newline.
7347         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7348         warning with a newline.
7349         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7350         newline.
7351         (s12z_frame_cache): Likewise.
7352         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7353         a newline.
7354         * solib-svr4.c (disable_probes_interface): Don't end warning with
7355         a newline.
7356         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7357         newline.
7358         * python/python.c (do_finish_initialization): Don't end warning
7359         with a newline.
7360
7361 2019-06-10  Tom Tromey  <tom@tromey.com>
7362
7363         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7364         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7365         gdbpy_enter.
7366
7367 2019-06-10  Tom Tromey  <tromey@adacore.com>
7368
7369         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7370         data.
7371         (elf_new_init): Don't call stabsread_new_init.
7372         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7373         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7374         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7375
7376 2019-06-10  Tom de Vries  <tdevries@suse.de>
7377
7378         PR symtab/16264
7379         PR symtab/24517
7380         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7381
7382 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7383
7384         * source.c (find_and_open_source): Also rewrite relative file
7385         names.
7386
7387 2019-04-26  Amos Bird  <amosbird@gmail.com>
7388
7389         * annotate.c (annotate_thread_exited): Add "thread-exited"
7390         annotation.
7391
7392 2019-06-06  Tom Tromey  <tromey@adacore.com>
7393
7394         * maint.h (class scoped_command_stats): Use
7395         DISABLE_COPY_AND_ASSIGN.
7396         <print_time>: New method.
7397         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7398         print_time.
7399         (scoped_command_stats::print_time): New method.
7400
7401 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7404         instructions of lengths 6 or 8 bytes.
7405
7406 2019-06-04  Pedro Alves  <palves@redhat.com>
7407
7408         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7409
7410         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7411         * breakpoint.c (condition_completer): Likewise.
7412         * cli/cli-dump.c (scan_expression): Likewise.
7413         * common/filestuff.c (mkdir_recursive): Likewise.
7414         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7415         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7416         (gdb_abspath): Likewise.
7417         * compile/compile-cplus-types.c
7418         (compile_cplus_instance::decl_name): Likewise.
7419         * completer.c (complete_explicit_location):
7420         (signal_completer, reg_or_group_completer_1): Likewise.
7421         * cp-support.c (cp_remove_params_if_any): Likewise.
7422         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7423         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7424         * infcmd.c (strip_bg_char): Likewise.
7425         * linespec.c (copy_token_string): Likewise.
7426         * mi/mi-main.c (output_cores): Likewise.
7427         * psymtab.c (psymtab_search_name):
7428         * symfile.c (test_set_ext_lang_command): Likewise.
7429         * target.c (target_fileio_read_stralloc): Likewise.
7430         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7431         * value.c (complete_internalvar): Likewise.
7432
7433 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7434
7435         Add objfile property to gdb.Type.
7436         * NEWS: Mention Python API addition.
7437         * python/py-type.c (typy_get_objfile): New method.
7438
7439 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7440
7441         * NEWS: Mention the new set|show style [title|highlight].
7442         Mention changes to "show style", "help" and "apropos".
7443
7444 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7445
7446         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7447         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7448         instead of print_help_for_command.
7449         (print_doc_of_command): New function.
7450         (help_list): Add 'apropos -v word' suggestion.
7451         (print_help_for_command): Style the command name using title style.
7452         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7453         (_initialize_cli_cmds): Describe -v in apropos_command help.
7454
7455 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7456
7457         * cli/cli-style.h (cli_style_option): Add name in constructor,
7458         add m_name class member, add constructor with intensity,
7459         add name class function.
7460         (cli_style_option::add_setshow_commands): Remove name argument.
7461         (highlight_style, title_style): New styles.
7462         * cli/cli-style.c (do_show): New function that shows a style
7463         characteristic styling the style name with itself.
7464         (set_style_name): New function.
7465         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7466         Update all callers according to the changes in cli/cli-style.h.
7467         * utils.h (fputs_highlighted): New function.
7468         * utils.c (fputs_highlighted): Likewise.
7469
7470 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7471
7472         * NEWS: Mention new pipe command and new convenience variables.
7473
7474 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7475
7476         * cli/cli-cmds.c (pipe_command): New function.
7477         (_initialize_cli_cmds): Call add_com for pipe_command.
7478         Define | as an alias for pipe.
7479         (exit_status_set_internal_vars): New function.
7480         (shell_escape): Call exit_status_set_internal_vars.
7481         cli/cli-decode.c (find_command_name_length): Recognize | as
7482         a single character command.
7483
7484 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7485
7486         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7487         top.c (execute_command_to_ui_file): New function, mostly a copy
7488         of execute_command_to_string.
7489         (execute_command_to_string): Implement by calling
7490         execute_command_to_ui_file.
7491
7492 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7493
7494         * top.h (saved_command_line): Remove declaration.
7495         * top.c (previous_saved_command_line, previous_repeat_arguments):
7496         New variables.
7497         (saved_command_line): Make static, define together with other
7498         'repeat variables'.
7499         (dont_repeat): Clear repeat_arguments.
7500         (repeat_previous, get_saved_command_line, save_command_line):
7501         New functions.
7502         (gdb_init): Initialize saved_command_line
7503         and previous_saved_command_line.
7504         * main.c (captured_main_1): Remove saved_command_line initialization.
7505         * event-top.c (handle_line_of_input): Update to use
7506         the new 'repeat' related functions instead of direct access to
7507         saved_command_line.
7508         * command.h (repeat_previous, get_saved_command_line,
7509         save_command_line): New declarations.
7510         (dont_repeat): Add comment.
7511
7512 2019-05-30  Tom Tromey  <tromey@adacore.com>
7513
7514         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7515         Fix comment.
7516         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7517
7518 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7519
7520         PR cli/24587
7521         * completer.c (complete): Initialize variable word.
7522
7523 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7524
7525         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7526         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7527         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7528         'body' is NULL to the outter 'if', protecting the '!is_define'
7529         situation as well.
7530
7531 2019-05-29  Tom Tromey  <tromey@adacore.com>
7532
7533         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7534         (dwarf_unknown): New function.
7535         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7536         (dwarf_type_encoding_name): Use dwarf_unknown.
7537
7538 2019-05-29  Tom Tromey  <tromey@adacore.com>
7539
7540         PR c++/20020:
7541         * cp-valprint.c (cp_print_value_fields): Call
7542         cp_print_static_field inside "try".
7543
7544 2019-05-29  Tom Tromey  <tromey@adacore.com>
7545
7546         * inflow.c (struct terminal_info): Add default operator=.
7547         * configure: Rebuild.
7548         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7549         -Wdeprecated-copy-dtor, -Wredundant-move.
7550
7551 2019-05-29  Tom Tromey  <tromey@adacore.com>
7552
7553         * NEWS: Add entry.
7554         * infcmd.c (print_return_value_1): Handle finish_print
7555         option.
7556         (show_print_finish): New function.
7557         (_initialize_infcmd): Add "set/show print finish" commands.
7558         * valprint.c (user_print_options): Initialize new member.
7559         * valprint.h (struct value_print_options) <finish_print>: New
7560         member.
7561
7562 2019-05-28  Tom Tromey  <tromey@adacore.com>
7563
7564         * ada-lang.c (ada_remove_Xbn_suffix)
7565         (find_old_style_renaming_symbol)
7566         (parse_old_style_renaming): Remove.
7567         (ada_find_renaming_symbol): Don't call
7568         find_old_style_renaming_symbol.
7569         (ada_is_renaming_symbol): Rename from
7570         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7571         bool.  Now static.
7572         (ada_read_var_value): Update and simplify.
7573         * ada-exp.y (write_var_or_type): Remove old code.
7574
7575 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7576
7577         PR gdb/25010
7578         * event-top.c: Remove include comment.
7579         * inflow.c (class scoped_ignore_sigttou): Move from here...
7580         * inflow.h (class scoped_ignore_sigttou): ...to here.
7581         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7582         * top.c:  Remove include comment.
7583
7584 2019-05-27  Tom Tromey  <tom@tromey.com>
7585
7586         * NEWS: Fix typo.
7587
7588 2019-05-22  Tom Tromey  <tromey@adacore.com>
7589
7590         * target.c (target_follow_exec): Constify parameter.
7591         * target-delegates.c: Rebuild.
7592         * remote.c (remote_target::follow_exec): Constify parameter.
7593         * infrun.c (follow_exec): Constify parameter.
7594         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7595         (target_follow_exec): Likewise.
7596
7597 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7598
7599         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7600         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7601
7602 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7603
7604         * NEWS: Add debugredirect and testsuite sections.
7605
7606 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7607
7608         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7609         target descriptions using exclusively floating point register name
7610         aliases.
7611
7612 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         PR gdb/18644:
7615         * f-lang.c (build_fortran_types): Handle the case where
7616         gdbarch_floatformat_for_type returns a nullptr.
7617
7618 2019-05-21  Tom de Vries  <tdevries@suse.de>
7619
7620         PR cli/24587
7621         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7622
7623 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7624
7625         PR gdb/18644:
7626         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7627         16-byte floats.
7628         * i386-tdep.c (i386_floatformat_for_type): Use
7629         floatformats_ia64_quad for the 16-byte floating point component
7630         within a fortran 32-byte complex number.
7631
7632 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7635         delete default constructor.
7636         (find_partial_die): Update to return const struct.
7637         (partial_die_parent_scope): Move variable declaration into scope
7638         of its use and change its type to auto.
7639         (guess_partial_die_structure_name): Likewise.
7640         (partial_die_info::fixup): Likewise.
7641
7642 2019-05-17  Tom Tromey  <tromey@adacore.com>
7643
7644         * source.c (find_and_open_source): Remove cast.
7645
7646 2019-05-17  Tom Tromey  <tromey@adacore.com>
7647
7648         * annotate.c (annotate_source): Make "filename" const.
7649         * annotate.h (annotate_source): Use const.
7650
7651 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7652
7653         * disasm.c (set_disassembler_options): Send errors to stderr.
7654
7655 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7656
7657         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7658         (cli_interp_base::set_logging): Check debug_redirect.
7659         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7660         * cli/cli-logging.c (debug_redirect): Add static variable.
7661         (pop_output_files): Add default param.
7662         (handle_redirections): Print debug setting.
7663         (show_logging_command): Likewise.
7664         (_initialize_cli_logging): Add debugredirect command.
7665         * interps.c (current_interp_set_logging): Add debug_redirect
7666         parameter.
7667         * interps.h (set_logging): Add debug_redirect parameter.
7668         (current_interp_set_logging): Likewise.
7669         * mi/mi-common.h: Likewise.
7670         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7671
7672 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7673             Tom Tromey  <tromey@adacore.com>
7674
7675         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7676         directly.
7677         * cli/cli-interp.h (make_logging_output): Remove declaration.
7678         * cli/cli-logging.c (make_logging_output): Remove function.
7679         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7680         directly.
7681         * ui-file.c (tee_file::tee_file): Remove bools.
7682         (tee_file::~tee_file): Remove deletes.
7683         * ui-file.h (tee_file): Remove bools.
7684
7685 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7686
7687         * mi/mi-cmds.h (mi_cmd_complete): New function.
7688         * mi/mi-main.c (mi_cmd_complete): Likewise.
7689         * mi/mi-cmds.c: Define new MI command -complete.
7690         * NEWS: Mention new -complete command.
7691
7692 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7693
7694         * completer.h (complete): New function.
7695         * completer.c (complete): Likewise.
7696         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7697         function defined in completer.h.
7698
7699 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7700
7701         * MAINTAINERS (Write After Approval): Add myself.
7702
7703 2019-05-17  Tom de Vries  <tdevries@suse.de>
7704
7705         PR gdb/24094
7706         * dwarf2read.c (struct cu_partial_die_info): New struct.
7707         (find_partial_die): Return cu_partial_die_info.
7708         (partial_die_parent_scope, guess_partial_die_structure_name)
7709         (partial_die_info::fixup): Handle new return type of find_partial_die.
7710
7711 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7712
7713         PR breakpoints/24541
7714         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7715         "std::string", simplifying the algorithm.
7716
7717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7718
7719         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7720         (stap_static_probe_ops::get_probes): Likewise.
7721
7722 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7723
7724         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7725         '-')" and "else if".
7726         (stap_parse_single_operand): Join checks for
7727         "gdbarch_stap_parse_special_token_p" and
7728         "gdbarch_stap_parse_special_token" in the same "if" statement.
7729         Invert check when verifying for operation on register
7730         displacement.
7731
7732 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7733
7734         * stap-probe.c (stap_get_opcode): Update comment.
7735         (stap_get_expected_argument_type): Likewise.
7736         (handle_stap_probe): Likewise.
7737
7738 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7739
7740         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7741         return type to 'bool'.  Adjust comment.  Use 'bool' when
7742         appropriate.
7743         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7744         * stap-probe.c (stap_parse_argument_1): Likewise.
7745         (stap_is_operator): Likewise.
7746         (stap_is_generic_prefix): Likewise.
7747         (stap_is_register_prefix): Likewise.
7748         (stap_is_register_indirection_prefix): Likewise.
7749         (stap_is_integer_prefix): Likewise.
7750         (stap_generic_check_suffix): Likewise.
7751         (stap_check_integer_suffix): Likewise.
7752         (stap_check_register_suffix): Likewise.
7753         (stap_check_register_indirection_suffix): Likewise.
7754         (stap_parse_register_operand): Likewise.
7755         (stap_parse_single_operand): Likewise.
7756         (stap_parse_argument_1): Likewise.
7757         (stap_probe::get_argument_count): Likewise.
7758         (stap_is_operator): Likewise.
7759
7760 2019-05-16  Tom Tromey  <tromey@adacore.com>
7761
7762         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7763         keyword to foreach.
7764
7765 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7766
7767         * linux-thread-db.c (try_thread_db_load_1): Change return type
7768         to bool.
7769         (try_thread_db_load): Likewise.
7770         (try_thread_db_load_from_pdir_1): Likewise.
7771         (try_thread_db_load_from_pdir): Likewise.
7772         (try_thread_db_load_from_sdir): Likewise.
7773         (try_thread_db_load_from_dir): Likewise.
7774         (thread_db_load_search): Likewise.
7775         (has_libpthread): Likewise.
7776         (thread_db_load): Likewise.
7777
7778 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7779
7780         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7781         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7782         NULL, and complain/return if that's the case.
7783
7784 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7785
7786         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7787         (advance, posn, abstract_read_memory): New functions.
7788         [struct mem_read_abstraction]: New struct.
7789         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7790
7791 2019-05-14  Tom Tromey  <tromey@adacore.com>
7792
7793         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7794         value is not lval_memory.
7795
7796 2019-05-14  Tom Tromey  <tromey@adacore.com>
7797
7798         * solib.c (info_sharedlibrary_command): Style the file name.
7799
7800 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7801
7802         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7803         (aarch64_vnv_type): Likewise.
7804         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7805         * common/tdesc.c: Likewise.
7806         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7807         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7808         * features/aarch64-fpu.xml: Add ieee half view.
7809         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7810         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7811         * gdbtypes.h (struct builtin_type): Likewise.
7812         (struct objfile_type): Likewise.
7813
7814 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7815
7816         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7817         typo.
7818         * location.h (string_to_event_location): Likewise.
7819
7820 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7821
7822         GDB 8.3 released.
7823
7824 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7825
7826         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7827         New variable declaration.
7828         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7829         New variable.
7830         (print_one_breakpoint): Use ui_out::test_flags and new global
7831         variable to compute use_fixed_output.
7832         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7833         Remove.
7834         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7835         (mi_multi_location_breakpoint_output_fixed): Remove.
7836         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7837         new variable.
7838         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7839         fix_multi_location_breakpoint_output flag if version >= 3.
7840         * ui-out.h (enum ui_out_flag)
7841         <fix_multi_location_breakpoint_output>: New enumerator.
7842
7843 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7844
7845         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7846
7847 2019-05-10  Tom Tromey  <tromey@adacore.com>
7848
7849         * ada-lang.c (catch_ada_completer): New function.
7850         (_initialize_ada_language): Use it.
7851
7852 2019-05-10  Tom Tromey  <tromey@adacore.com>
7853
7854         * thread.c (print_thread_info): Make "requested_threads" const.
7855         * gdbthread.h (print_thread_info): Make "requested_threads"
7856         const.
7857         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7858         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7859
7860 2019-05-08  Tom Tromey  <tom@tromey.com>
7861
7862         * gdbtypes.c (objfile_type_data): Change type.
7863         (objfile_type, _initialize_gdbtypes): Update.
7864
7865 2019-05-08  Tom Tromey  <tom@tromey.com>
7866
7867         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7868         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7869         (_initialize_dwarf2_frame): Update.
7870
7871 2019-05-08  Tom Tromey  <tom@tromey.com>
7872
7873         * objc-lang.c (objc_objfile_data): Change type.
7874         (find_methods): Update.
7875         (_initialize_objc_lang): Remove.
7876
7877 2019-05-08  Tom Tromey  <tom@tromey.com>
7878
7879         * stabsread.c (rs6000_builtin_type_data): Change type.
7880         (rs6000_builtin_type, _initialize_stabsread): Update.
7881
7882 2019-05-08  Tom Tromey  <tom@tromey.com>
7883
7884         * mips-tdep.c (mips_pdr_data): Remove.
7885         (_initialize_mips_tdep): Update.
7886
7887 2019-05-08  Tom Tromey  <tom@tromey.com>
7888
7889         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7890         (hppa_init_objfile_priv_data, read_unwind_info)
7891         (find_unwind_entry, _initialize_hppa_tdep): Update.
7892
7893 2019-05-08  Tom Tromey  <tom@tromey.com>
7894
7895         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7896         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7897         on obstack.
7898         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7899
7900 2019-05-08  Tom Tromey  <tom@tromey.com>
7901
7902         * mdebugread.c (basic_type_data): Change type.
7903         (basic_type, _initialize_mdebugread): Update.
7904
7905 2019-05-08  Tom Tromey  <tom@tromey.com>
7906
7907         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7908
7909 2019-05-08  Tom Tromey  <tom@tromey.com>
7910
7911         * nto-tdep.c (nto_inferior_data_reg): Change type.
7912         (nto_inferior_data): Update.
7913         (nto_inferior_data_cleanup, nto_new_inferior_data)
7914         (_initialize_nto_tdep): Remove.
7915         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7916
7917 2019-05-08  Tom Tromey  <tom@tromey.com>
7918
7919         * ada-lang.c (struct ada_inferior_data): Add initializers.
7920         (ada_inferior_data): Change type.
7921         (ada_inferior_data_cleanup): Remove.
7922         (get_ada_inferior_data, ada_inferior_exit)
7923         (struct ada_pspace_data): Add initializers, destructor.
7924         (ada_pspace_data_handle): Change type.
7925         (get_ada_pspace_data): Update.
7926         (ada_pspace_data_cleanup): Remove.
7927
7928 2019-05-08  Tom Tromey  <tom@tromey.com>
7929
7930         * coffread.c (struct coff_symfile_info): Add initializers.
7931         (coff_objfile_data_key): Move lower.  Change type.
7932         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7933         Update.
7934         (coff_free_info): Remove.
7935
7936 2019-05-08  Tom Tromey  <tom@tromey.com>
7937
7938         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7939         (fbsd_pspace_data_handle): Move lower.  Change type.
7940         (get_fbsd_pspace_data): Update.
7941         (fbsd_pspace_data_cleanup): Remove.
7942         (_initialize_fbsd_tdep): Update.
7943
7944 2019-05-08  Tom Tromey  <tom@tromey.com>
7945
7946         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7947         (get_ada_tasks_pspace_data): Update.
7948         (ada_tasks_pspace_data_cleanup): Remove.
7949         (_initialize_tasks): Update.
7950         (ada_tasks_inferior_data_handle): Change type.
7951         (get_ada_tasks_inferior_data): Update.
7952         (ada_tasks_inferior_data_cleanup): Remove.
7953         (struct ada_tasks_pspace_data): Add initializers.
7954
7955 2019-05-08  Tom Tromey  <tom@tromey.com>
7956
7957         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7958         * symfile-debug.c (debug_sym_get_probes): Change type.
7959         * stap-probe.c (handle_stap_probe):
7960         (stap_static_probe_ops::get_probes): Change type.
7961         * probe.h (class static_probe_ops) <get_probes>: Change type.
7962         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7963         (parse_probes_in_pspace): Update.
7964         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7965         Update.
7966         (any_static_probe_ops::get_probes): Change type.
7967         * elfread.c (elfread_data): New typedef.
7968         (probe_key): Change type.
7969         (elf_get_probes): Likewise.  Update.
7970         (probe_key_free): Remove.
7971         (_initialize_elfread): Update.
7972         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7973         Change type.
7974         (dtrace_process_dof_probe, dtrace_process_dof)
7975         (dtrace_static_probe_ops::get_probe): Change type.
7976
7977 2019-05-08  Tom Tromey  <tom@tromey.com>
7978
7979         * xcoffread.c (struct xcoff_symfile_info): Rename from
7980         coff_symfile_info.  Add initializers.
7981         (xcoff_objfile_data_key): Move lower.  Change type.
7982         (XCOFF_DATA): Rewrite.
7983         (xcoff_free_info): Remove.
7984         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7985         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7986         (xcoff_initial_scan): Update.
7987
7988 2019-05-08  Tom Tromey  <tom@tromey.com>
7989
7990         * solib-svr4.c (struct svr4_info): Add initializers and
7991         destructor.
7992         <probes_table>: Now an htab_up.
7993         (solib_svr4_pspace_data): Change type.
7994         (free_probes_table): Simplify.
7995         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7996         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7997         (probes_table_remove_objfile_probes, register_solib_event_probe)
7998         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7999         (_initialize_svr4_solib): Update.
8000
8001 2019-05-08  Tom Tromey  <tom@tromey.com>
8002
8003         * remote.c (remote_pspace_data): Change type.
8004         (remote_pspace_data_cleanup): Remove.
8005         (get_remote_exec_file, set_pspace_remote_exec_file)
8006         (_initialize_remote): Update.
8007
8008 2019-05-08  Tom Tromey  <tom@tromey.com>
8009
8010         * breakpoint.c (breakpoint_objfile_key): Change type.
8011         (get_breakpoint_objfile_data): Update.
8012         (free_breakpoint_objfile_data): Remove.
8013         (_initialize_breakpoint): Update.
8014
8015 2019-05-08  Tom Tromey  <tom@tromey.com>
8016
8017         * linux-tdep.c (struct linux_info): Add initializers.
8018         (linux_inferior_data): Move.  Change type.
8019         (invalidate_linux_cache_inf): Update.
8020         (linux_inferior_data_cleanup): Remove.
8021         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8022
8023 2019-05-08  Tom Tromey  <tom@tromey.com>
8024
8025         * auxv.c (auxv_inferior_data): Move.  Change type.
8026         (auxv_inferior_data_cleanup): Remove.
8027         (invalidate_auxv_cache_inf): Rewrite.
8028         (get_auxv_inferior_data, _initialize_auxv): Update.
8029
8030 2019-05-08  Tom Tromey  <tom@tromey.com>
8031
8032         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8033         (symfile_debug_objfile_data_key): Change type.
8034         (symfile_debug_installed, debug_qf_has_symbols)
8035         (debug_qf_find_last_source_symtab)
8036         (debug_qf_forget_cached_source_info)
8037         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8038         (debug_qf_print_stats, debug_qf_dump)
8039         (debug_qf_expand_symtabs_for_function)
8040         (debug_qf_expand_all_symtabs)
8041         (debug_qf_expand_symtabs_with_fullname)
8042         (debug_qf_map_matching_symbols)
8043         (debug_qf_expand_symtabs_matching)
8044         (debug_qf_find_pc_sect_compunit_symtab)
8045         (debug_qf_map_symbol_filenames)
8046         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8047         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8048         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8049         (debug_sym_read_linetable, debug_sym_relocate): Update.
8050         (symfile_debug_free_objfile): Remove.
8051         (install_symfile_debug_logging, _initialize_symfile_debug):
8052         Update.
8053
8054 2019-05-08  Tom Tromey  <tom@tromey.com>
8055
8056         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8057         allocate_on_obstack.
8058         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8059         (get_dwarf2_per_objfile): Update.
8060         (set_dwarf2_per_objfile): Remove.
8061         (dwarf2_has_info, dwarf2_get_section_info): Update.
8062         (dwarf2_free_objfile): Remove.
8063         (_initialize_dwarf2_read): Update.
8064
8065 2019-05-08  Tom Tromey  <tom@tromey.com>
8066
8067         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8068         initializers.
8069         <unsupported_script_warning_printed,
8070         script_not_found_warning_printed>: Now bool.
8071         (auto_load_pspace_data): Change type.
8072         (~auto_load_pspace_info): Rename from
8073         auto_load_pspace_data_cleanup.
8074         (get_auto_load_pspace_data, init_loaded_scripts_info)
8075         (clear_section_scripts, maybe_print_unsupported_script_warning)
8076         (maybe_print_script_not_found_warning, _initialize_auto_load):
8077         Update.
8078
8079 2019-05-08  Tom Tromey  <tom@tromey.com>
8080
8081         * objfiles.c (objfile_pspace_info): Add destructor and
8082         initializers.
8083         (objfiles_pspace_data): Change type.
8084         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8085         (get_objfile_pspace_data): Update.
8086         (objfiles_bfd_data): Change type.
8087         (get_objfile_bfd_data): Update.
8088         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8089
8090 2019-05-08  Tom Tromey  <tom@tromey.com>
8091
8092         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8093         Change type.
8094         (get_catch_syscall_inferior_data): Update.
8095         (catch_syscall_inferior_data_cleanup): Remove.
8096         (_initialize_break_catch_syscall): Update.
8097
8098 2019-05-08  Tom Tromey  <tom@tromey.com>
8099
8100         * inflow.c (struct terminal_info): Add destructor and
8101         initializers.
8102         (inflow_inferior_data): Change type.
8103         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8104         (get_inflow_inferior_data, inflow_inferior_exit)
8105         (swap_terminal_info, _initialize_inflow): Update.
8106
8107 2019-05-08  Tom Tromey  <tom@tromey.com>
8108
8109         * target-dcache.c (target_dcache_cleanup): Remove.
8110         (target_dcache_aspace_key): Change type.
8111         (target_dcache_init_p, target_dcache_invalidate)
8112         (target_dcache_get, target_dcache_get_or_init)
8113         (_initialize_target_dcache): Update.
8114         * dcache.h (struct dcache_deleter): New.
8115
8116 2019-05-08  Tom Tromey  <tom@tromey.com>
8117
8118         * symtab.c (struct symbol_cache): Add destructor and
8119         initializers.
8120         (symbol_cache_key): Move.  Change type.
8121         (make_symbol_cache, free_symbol_cache): Remove.
8122         (get_symbol_cache): Update.
8123         (symbol_cache_cleanup): Remove.
8124         (ALL_PSPACES, symbol_cache_flush)
8125         (maintenance_print_symbol_cache)
8126         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8127         Update.
8128
8129 2019-05-08  Tom Tromey  <tom@tromey.com>
8130
8131         * symtab.c (struct main_info): Add destructor and initializers.
8132         (main_progspace_key): Move.  Change type.
8133         (get_main_info): Update.
8134         (main_info_cleanup): Remove.
8135         (_initialize_symtab): Update.
8136
8137 2019-05-08  Tom Tromey  <tom@tromey.com>
8138
8139         * registry.h (DECLARE_REGISTRY): Define the _key class.
8140
8141 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * NEWS: Merge two 'New commands' sections.
8144
8145 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8146
8147         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8148         parameter and use Ada language definition instead.
8149         (ada_val_print_ptr): Remove unused language parameter.
8150         (ada_val_print_num): Remove language parameter and use Ada language
8151         definition instead.
8152         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8153         parameter.
8154         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8155         parameter and use Ada language definition instead.
8156         (ada_val_print_1): Update all ada_val_print_xxx calls.
8157         Remove language parameter.
8158         (ada_val_print): Update ada_val_print_1 call.
8159
8160 2019-05-08  Tom Tromey  <tromey@adacore.com>
8161
8162         * remote.c (remote_hw_watchpoint_limit)
8163         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8164         Now static.
8165
8166 2019-05-08  Tom Tromey  <tromey@adacore.com>
8167
8168         * maint.c (_initialize_maint_cmds): Move initialization code to
8169         remote.c.
8170         (watchdog, show_watchdog): Move to remote.c.
8171         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8172         "watchdog" static.
8173         (_initialize_remote): Move initialization code from maint.c.
8174         * defs.h (watchdog): Don't declare.
8175
8176 2019-05-08  Tom Tromey  <tromey@adacore.com>
8177
8178         * tui/tui-interp.c: Include main.h.
8179         * interps.c: Include main.h.
8180         * main.h (interpreter_p): Declare.
8181         * defs.h (interpreter_p): Don't declare.
8182
8183 2019-05-08  Tom Tromey  <tromey@adacore.com>
8184
8185         * dwarf2loc.c: Include dwarf2read.h.
8186         * defs.h (read_unsigned_leb128): Don't declare.
8187         * dwarf2read.h (read_unsigned_leb128): Declare.
8188
8189 2019-05-08  Tom Tromey  <tromey@adacore.com>
8190
8191         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8192         method.
8193
8194 2019-05-08  Tom Tromey  <tromey@adacore.com>
8195
8196         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8197         when no wrap column is set.
8198
8199 2019-05-08  Tom Tromey  <tromey@adacore.com>
8200
8201         * c-lang.c (c_get_string): Handle non-C-style arrays.
8202
8203 2019-05-08  Tom Tromey  <tromey@adacore.com>
8204
8205         * typeprint.c (print_offset_data::update): Print the bit offset,
8206         not the number of bits remaining.
8207
8208 2019-05-08  Tom Tromey  <tromey@adacore.com>
8209
8210         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8211         padding at end of comment.
8212
8213 2019-05-08  Tom Tromey  <tromey@adacore.com>
8214
8215         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8216         Compare main types.
8217
8218 2019-05-06  Tom Tromey  <tom@tromey.com>
8219
8220         * common/scoped_mmap.c: Include common-defs.h.
8221         * common/scoped_mmap.h: Don't include config.h.
8222
8223 2019-05-04  Tom Tromey  <tom@tromey.com>
8224
8225         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8226         (struct aarch64_call_info): Add initializers.
8227         <si>: Now a std::vector.
8228         (pass_on_stack, aarch64_push_dummy_call): Update.
8229
8230 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8231             Tom Tromey  <tom@tromey.com>
8232
8233         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8234         (ppc_threads): Now a std::vector.  Now static.
8235         (hwdebug_find_thread_points_by_tid)
8236         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8237         Update.
8238
8239 2019-05-04  Tom Tromey  <tom@tromey.com>
8240
8241         * arc-tdep.c (arc_tdesc_init): Return bool.
8242
8243 2019-05-04  Tom Tromey  <tom@tromey.com>
8244
8245         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8246         Use gdb_assert_not_reached.
8247
8248 2019-05-04  Tom Tromey  <tom@tromey.com>
8249
8250         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8251         "false".
8252
8253 2019-05-04  Tom Tromey  <tom@tromey.com>
8254
8255         * arc-tdep.c (arc_tdesc_init): Use bool.
8256
8257 2019-05-04  Tom Tromey  <tom@tromey.com>
8258
8259         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8260
8261 2019-05-04  Tom Tromey  <tom@tromey.com>
8262
8263         * cli/cli-cmds.c (valid_command_p): Return bool.
8264
8265 2019-05-04  Tom Tromey  <tom@tromey.com>
8266
8267         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8268         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8269
8270 2019-05-04  Raul Tambre  <raul@tambre.ee>
8271
8272         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8273         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8274         operator for comparison.
8275
8276 2019-05-04  Tom Tromey  <tom@tromey.com>
8277
8278         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8279         (lookup_partial_symbol, print_partial_symbols)
8280         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8281         (psymbol_compare): Update.
8282         (add_psymbol_to_bcache): Clear the entire psymbol.
8283         (maintenance_check_psymtabs): Update.
8284         * psympriv.h (struct partial_symbol): Don't derive from
8285         general_symbol_info.
8286         <obj_section, unrelocated_address, address,
8287         set_unrelocated_address>: Update.
8288         <ginfo>: New member.
8289         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8290         (debug_names::write_psymbols): Update.
8291
8292 2019-05-04  Tom de Vries  <tdevries@suse.de>
8293
8294         * contrib/cc-with-tweaks.sh: Support -n arg.
8295
8296 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8297
8298         * corelow.c (core_target::detach): Ensure frame cache and
8299         register caches are cleared.
8300         inferior.c (exit_inferior_1): Likewise.
8301
8302 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8303             Tom Tromey  <tom@tromey.com>
8304
8305         * dictionary.c (collate_pending_symbols_by_language): Remove
8306         "struct" from foreach.
8307         * symtab.c (lookup_global_symbol_from_objfile)
8308         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8309         foreach.
8310         * ser-tcp.c (net_open): Remove "struct" from foreach.
8311         * objfiles.c (objfile_relocate, objfile_rebase)
8312         (objfile_has_symbols): Remove "struct" from foreach.
8313         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8314         from foreach.
8315         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8316         foreach.
8317         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8318         "struct" from foreach.
8319         * ada-lang.c (create_excep_cond_exprs)
8320         (ada_exception_catchpoint_cond_string): Remove "struct" from
8321         foreach.
8322
8323 2019-05-03  Tom Tromey  <tromey@adacore.com>
8324
8325         * ada-exp.y (convert_char_literal): Check suffix of each
8326         enumerator.
8327
8328 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8329
8330         PR ada/21406:
8331         * ada-exp.y (yywrap): Don't define.
8332         * ada-lex.l (%option): Add noyywrap
8333         (yywrap): Remove.
8334
8335 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8336
8337         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8338         _WIN32_WINNT to the XP level, unless already defined to a higher
8339         level.
8340
8341         * unittests/parse-connection-spec-selftests.c:
8342         * ser-tcp.c:
8343         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8344         override.
8345
8346         * symfile.c (find_separate_debug_file): Remove colon from the
8347         drive spec of DOS/Windows file names of the target, so that the
8348         file name produced from DEBUGDIR and the target's directory will
8349         be valid on DOS/Windows systems.
8350
8351 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8352
8353         * rust-lang.c (val_print_struct): Handle printing structures
8354         containing strings.
8355
8356 2019-05-02  Tom Tromey  <tromey@adacore.com>
8357
8358         * valarith.c (_initialize_valarith): Remove.
8359
8360 2019-05-01  Tom Tromey  <tromey@adacore.com>
8361
8362         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8363         bitfields.
8364
8365 2019-05-01  Tom Tromey  <tromey@adacore.com>
8366
8367         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8368         for big-endian copies.
8369
8370 2019-04-30  Ali Tamur  <tamur@google.com>
8371         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8372         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8373         (read_3_bytes): New function.
8374
8375 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8376
8377         * windows-nat.c (main_thread_id): Delete.
8378         (handle_output_debug_string): Replace main_thread_id by
8379         current_event.dwThreadId.
8380         (fake_create_process): Likewise.
8381         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8382         Do not set main_thread_id.
8383         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8384         current_event.dwThreadId.
8385         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8386
8387 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8388
8389         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8390         Use current_event.dwThreadId instead of main_thread_id.
8391
8392 2019-04-30  Tom Tromey  <tromey@adacore.com>
8393
8394         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8395         (create_excep_cond_exprs): Iterate over program spaces.
8396         (ada_exception_catchpoint_cond_string): Examine all minimal
8397         symbols for exception types.
8398
8399 2019-04-30  Tom Tromey  <tromey@adacore.com>
8400
8401         PR c++/24470:
8402         * dwarf2read.c (process_structure_scope): Handle case where type
8403         has template parameters but no symbol was created.
8404
8405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8406             Chris January  <chris.january@arm.com>
8407
8408         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8409         qualifier.
8410         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8411
8412 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8413
8414         * f-typeprint.c (f_print_type): Update rules for printing
8415         whitespace.
8416         (f_type_print_varspec_suffix): Likewise.
8417
8418 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8419             Chris January  <chris.january@arm.com>
8420
8421         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8422         function arguments.
8423
8424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8425
8426         * f-lang.c (build_fortran_types): Change name of void type to
8427         lower case.
8428         * f-typeprint.c (f_type_print_base): Print the name of the void
8429         type, rather than a fixed string.
8430         * f-valprint.c (f_decorations): Use lower case void string.
8431
8432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8433             Chris January  <chris.january@arm.com>
8434
8435         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8436         types for Fortran.
8437
8438 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8439             Chris January  <chris.january@arm.com>
8440             David Lecomber  <david.lecomber@arm.com>
8441
8442         * f-exp.y (BINOP_INTRINSIC): New token.
8443         (exp): New parser rule handling BINOP_INTRINSIC.
8444         (f77_keywords): Add new builtin procedures.
8445         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8446         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8447         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8448         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8449         (print_unop_subexp_f): New function.
8450         (print_binop_subexp_f): New function.
8451         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8452         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8453         (dump_subexp_body_f): Likewise.
8454         (operator_check_f): Likewise.
8455         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8456         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8457
8458 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8461         UNOP_KIND.
8462         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8463         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8464         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8465         (operator_length_f): New fuction.
8466         (print_subexp_f): New function.
8467         (op_name_f): New function.
8468         (dump_subexp_body_f): New function.
8469         (operator_check_f): New function.
8470         (exp_descriptor_f): Replace standard expression handling functions
8471         with new functions.
8472         * gdb/fortran-operator.def: New file.
8473         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8474         * gdb/std-operator.def: Remove UNOP_KIND.
8475
8476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * std-operator.def: Remove unbalanced, stray double quote
8479         character.
8480
8481 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8482             Chris January  <chris.january@arm.com>
8483             Daniel Everett  <daniel.everett@arm.com>
8484             Nick Forrington  <nick.forrington@arm.com>
8485             Richard Bunt  <richard.bunt@arm.com>
8486
8487         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8488         of depth when printing anonymous structs or unions.
8489         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8490         Don't print either the top-level value, or the children if the
8491         max-depth is exceeded.
8492         (ppscm_print_children): When printing the key of a map, allow one
8493         extra level of depth.
8494         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8495         print either the top-level value, or the children if the max-depth
8496         is exceeded.
8497         (print_children): When printing the key of a map, allow one extra
8498         level of depth.
8499         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8500         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8501         (user_print_options): Initialise max_depth field.
8502         (val_print_scalar_or_string_type_p): New function.
8503         (val_print): Check to see if the max depth has been reached.
8504         (val_print_check_max_depth): Define new function.
8505         (show_print_max_depth): New function.
8506         (_initialize_valprint): Add 'print max-depth' option.
8507         * valprint.h (struct value_print_options) <max_depth>: New field.
8508         (val_print_check_max_depth): Declare new function.
8509         * NEWS: Document new feature.
8510
8511 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * ada-lang.c (ada_language_defn): Initialise new field.
8514         * c-lang.c (c_is_string_type_p): New function.
8515         (c_language_defn): Initialise new field.
8516         (cplus_language_defn): Initialise new field.
8517         (asm_language_defn): Initialise new field.
8518         (minimal_language_defn): Initialise new field.
8519         * c-lang.h (c_is_string_type_p): Declare new function.
8520         * d-lang.c (d_language_defn): Initialise new field.
8521         * f-lang.c (f_is_string_type_p): New function.
8522         (f_language_defn): Initialise new field.
8523         * go-lang.c (go_is_string_type_p): New function.
8524         (go_language_defn): Initialise new field.
8525         * language.c (default_is_string_type_p): New function.
8526         (unknown_language_defn): Initialise new field.
8527         (auto_language_defn): Initialise new field.
8528         * language.h (struct language_defn) <la_is_string_type_p>: New
8529         member variable.
8530         (default_is_string_type_p): Declare new function.
8531         * m2-lang.c (m2_language_defn): Initialise new field.
8532         * objc-lang.c (objc_language_defn): Initialise new field.
8533         * opencl-lang.c (opencl_language_defn): Initialise new field.
8534         * p-lang.c (pascal_is_string_type_p): New function.
8535         (pascal_language_defn): Initialise new field.
8536         * rust-lang.c (rust_is_string_type_p): New function.
8537         (rust_language_defn): Initialise new field.
8538
8539 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8542         New field.
8543         * ada-lang.c (ada_language_defn): Initialise new field.
8544         * c-lang.c (c_language_defn): Likewise.
8545         (cplus_language_defn): Likewise.
8546         (asm_language_defn): Likewise.
8547         (minimal_language_defn): Likewise.
8548         * d-lang.c (d_language_defn): Likewise.
8549         * f-lang.c (f_language_defn): Likewise.
8550         * go-lang.c (go_language_defn): Likewise.
8551         * language.c (unknown_language_defn): Likewise.
8552         (auto_language_defn): Likewise.
8553         * m2-lang.c (m2_language_defn): Likewise.
8554         * objc-lang.c (objc_language_defn): Likewise.
8555         * opencl-lang.c (opencl_language_defn): Likewise.
8556         * p-lang.c (pascal_language_defn): Likewise.
8557         * rust-lang.c (rust_language_defn): Likewise.
8558
8559 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * ada-lang.c (ada_is_character_type): Change return type to bool.
8562         (ada_is_string_type): Likewise.
8563         * ada-lang.h (ada_is_character_type): Update declaration
8564         (ada_is_string_type): Likewise.
8565
8566 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567
8568         Support style in 'frame|thread apply'
8569
8570         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8571         * record.c (record_start, record_stop): Update callers of
8572         execute_command_to_string with false.
8573         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8574         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8575         methods.
8576         (class string_file): New constructor with term_out parameter.
8577         Override methods term_out and can_emit_style_escape.  New member
8578         term_out.
8579         (class stdio_file): Override can_emit_style_escape.
8580         (class tee_file): Override term_out and can_emit_style_escape.
8581         * utils.h (can_emit_style_escape): Remove.
8582         * utils.c (can_emit_style_escape): Likewise.
8583         Update all callers of can_emit_style_escape (SOMESTREAM) to
8584         SOMESTREAM->can_emit_style_escape.
8585         * source-cache.c (source_cache::get_source_lines): Likewise.
8586         * stack.c (frame_apply_command_count): Call execute_command_to_string
8587         passing the term_out characteristic of the current gdb_stdout.
8588         * thread.c (thr_try_catch_cmd): Likewise.
8589         * top.c (execute_command_to_string): pass term_out parameter
8590         to construct the string_file for the command output.
8591         * ui-file.c (term_cli_styling): New function (most code moved
8592         from utils.c can_emit_style_escape).
8593         (string_file::string_file, string_file::can_emit_style_escape,
8594         stdio_file::can_emit_style_escape, tee_file::term_out,
8595         tee_file::can_emit_style_escape): New functions.
8596
8597 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8598
8599         * NEWS: Mention the new set|show may-call-functions.
8600         * infcall.c (may_call_functions_p): New variable.
8601         (show_may_call_functions_p): New function.
8602         (call_function_by_hand_dummy): Throws an error if not
8603         may-call-functions.
8604         (_initialize_infcall): Call add_setshow_boolean_cmd for
8605         may-call-functions.
8606
8607 2019-04-25  Keith Seitz  <keiths@redhat.com>
8608
8609         PR c++/24367
8610         * cp-support.c (inspect_type): Don't attempt substitutions
8611         of symbol with the same name.
8612
8613 2019-04-25  Tom Tromey  <tromey@adacore.com>
8614
8615         PR gdb/24475:
8616         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8617         static.
8618
8619 2019-04-25  Tom Tromey  <tromey@adacore.com>
8620
8621         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8622         rvalue reference.
8623         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8624         (gdb_xml_parser::parse): Use std::move.
8625         * python/python-internal.h (gdbpy_convert_exception): Take a const
8626         reference.
8627         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8628         std::move.
8629         * python/py-utils.c (gdbpy_convert_exception): Take a const
8630         reference.
8631         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8632         Use std::move.
8633         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8634         Use std::move.
8635         * mi/mi-main.c (mi_print_exception): Take a const reference.
8636         * main.c (handle_command_errors): Take a const reference.
8637         * linespec.c (parse_linespec): Use std::move.
8638         * infcall.c (run_inferior_call): Use std::move.
8639         (call_function_by_hand_dummy): Use std::move.
8640         * exec.c (try_open_exec_file): Use std::move.
8641         * exceptions.h (exception_print, exception_fprintf)
8642         (exception_print_same): Update.
8643         * exceptions.c (print_exception, exception_print)
8644         (exception_fprintf, exception_print_same): Change parameters to
8645         const reference.
8646         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8647         * common/new-op.c: Use std::move.
8648         * common/common-exceptions.h (struct gdb_exception): Add move
8649         constructor.
8650         (struct gdb_exception_error, struct gdb_exception_quit, struct
8651         gdb_quit_bad_alloc): Change constructor to move constructor.
8652         (throw_exception): Change parameter to rvalue reference.
8653         * common/common-exceptions.c (throw_exception): Take rvalue
8654         reference.
8655         * cli/cli-interp.c (safe_execute_command): Use std::move.
8656         * breakpoint.c (insert_bp_location, location_to_sals): Use
8657         std::move.
8658
8659 2019-04-25  Tom Tromey  <tromey@adacore.com>
8660
8661         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8662         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8663         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8664         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8665         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8666         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8667         guile/scm-value.c: Use unpack.
8668         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8669         gdbscm_gdb_exception.
8670         (gdbscm_throw_gdb_exception): Likewise.
8671         (struct gdbscm_gdb_exception): New.
8672         (unpack): New function.
8673         (gdbscm_wrap): Use unpack.
8674
8675 2019-04-25  Tom Tromey  <tromey@adacore.com>
8676
8677         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8678         (gdb_rl_callback_handler): Use std::move.
8679         * common/common-exceptions.h (struct gdb_exception): Add move
8680         assignment operator.
8681         (throw_exception_sjlj): Change "exception" to const reference.
8682         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8683         (throw_exception_sjlj): Change "exception" to const reference.
8684
8685 2019-04-25  Tom Tromey  <tromey@adacore.com>
8686
8687         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8688         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8689         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8690         Update.
8691         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8692         Update.
8693         * mi/mi-interp.c (mi_interp::exec): Update.
8694         * linespec.c (parse_linespec): Update.
8695         * infcall.c (run_inferior_call): Update.
8696         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8697         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8698         (gdbscm_lookup_global_symbol): Update.
8699         * guile/scm-param.c (gdbscm_parameter_value): Update.
8700         * guile/scm-frame.c (gdbscm_frame_read_register)
8701         (gdbscm_frame_read_var): Update.
8702         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8703         * exec.c (try_open_exec_file): Update.
8704         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8705         (gdb_rl_callback_handler): Update.
8706         * common/common-exceptions.h (exception_none): Don't declare.
8707         * common/common-exceptions.c (exception_none): Don't define.
8708         (struct catcher) <exception>: Update.
8709         * cli/cli-interp.c (safe_execute_command): Update.
8710         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8711
8712 2019-04-25  Ali Tamur  <tamur@google.com>
8713
8714         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8715         (read_attribute_value): Likewise.
8716         (dwarf2_read_addr_index): Update comment.
8717         (read_str_index): Add DW_FORM_strx.
8718         (dwarf2_string_attr): Likewise.
8719         (dwarf2_const_value_attr): Likewise.
8720         (dump_die_shallow): Likewise.
8721         (dwarf2_fetch_constant_bytes): Likewise.
8722         (skip_form_bytes): Likewise.
8723         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8724
8725 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8726
8727         PR corefiles/11608
8728         PR corefiles/18187
8729         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8730         OFFSET.  Verify if current mapping contains an ELF header.
8731         (linux_find_memory_regions_full): Adjust call to
8732         dump_mapping_p.
8733
8734 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8735             Kang Li <kanglictf@gmail.com>
8736
8737         PR gdb/21600
8738
8739         * dwarf2-frame.c (read_initial_length): Be consistent about using
8740         unsigned representation of length.
8741         (decode_frame_entry_1): Likewise.  Check for wraparound of
8742         end pointer as well as buffer overflow.
8743
8744 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8745
8746         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8747         "vq".
8748
8749 2019-04-24  Tom Tromey  <tromey@adacore.com>
8750
8751         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8752
8753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * s12z-tdep.c (s12z_unwind_pc): Delete.
8756         (s12z_unwind_sp): Delete.
8757         (s12z_gdbarch_init): Don't register deleted functions with
8758         gdbarch.
8759
8760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8761
8762         * rl78-tdep.c (rl78_unwind_sp): Delete.
8763         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8764
8765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8766
8767         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8768         (xstormy16_unwind_pc): Delete.
8769         (xstormy16_dummy_id): Delete.
8770         (xstormy16_gdbarch_init): Don't register deleted functions with
8771         gdbarch.
8772
8773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8774
8775         * vax-tdep.c (vax_unwind_pc): Delete.
8776         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8777
8778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8779
8780         * v850-tdep.c (v850_unwind_sp): Delete.
8781         (v850_unwind_pc): Delete.
8782         (v850_dummy_id): Delete.
8783         (v850_gdbarch_init): Don't register deleted functions with
8784         gdbarch.
8785
8786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8789         (tilegx_unwind_pc): Delete.
8790         (tilegx_unwind_dummy_id): Delete.
8791         (tilegx_gdbarch_init): Don't register deleted functions with
8792         gdbarch.
8793
8794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8797         (tic6x_dummy_id): Delete.
8798         (tic6x_gdbarch_init): Don't register deleted functions with
8799         gdbarch.
8800
8801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8802
8803         * sparc-tdep.c (sparc_unwind_pc): Delete.
8804         (sparc32_gdbarch_init): Don't register deleted function with
8805         gdbarch.
8806
8807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * sh-tdep.c (sh_unwind_sp): Delete.
8810         (sh_unwind_pc): Delete.
8811         (sh_dummy_id): Delete.
8812         (sh_gdbarch_init): Don't register deleted functions with
8813         gdbarch.
8814
8815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8816
8817         * score-tdep.c (score_unwind_sp): Delete.
8818         (score_unwind_pc): Delete.
8819         (score_dummy_id): Delete.
8820         (score_gdbarch_init): Don't register deleted functions with
8821         gdbarch.
8822
8823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * rx-tdep.c (rx_unwind_pc): Delete.
8826         (rx_unwind_sp): Delete.
8827         (rx_dummy_id): Delete.
8828         (rx_gdbarch_init): Don't register deleted functions with
8829         gdbarch.  Update comment.
8830
8831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8834         (rs6000_dummy_id): Delete.
8835         (rs6000_gdbarch_init): Don't register deleted functions with
8836         gdbarch.
8837
8838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * or1k-tdep.c (or1k_dummy_id): Delete.
8841         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8842
8843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8844
8845         * nios2-tdep.c (nios2_dummy_id): Delete.
8846         (nios2_unwind_sp): Delete.
8847         (nios2_gdbarch_init): Don't register deleted functions with
8848         gdbarch.
8849
8850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * nds32-tdep.c (nds32_dummy_id): Delete.
8853         (nds32_unwind_pc): Delete.
8854         (nds32_unwind_sp): Delete.
8855         (nds32_gdbarch_init): Don't register deleted functions with
8856         gdbarch.
8857
8858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * msp430-tdep.c (msp430_unwind_pc): Delete.
8861         (msp430_unwind_sp): Delete.
8862         (msp430_dummy_id): Delete.
8863         (msp430_gdbarch_init): Don't register deleted functions with
8864         gdbarch.
8865
8866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * moxie-tdep.c (moxie_unwind_sp): Delete.
8869         (moxie_unwind_pc): Delete.
8870         (moxie_dummy_id): Delete.
8871         (moxie_gdbarch_init): Don't register deleted functions with
8872         gdbarch.
8873
8874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8877         (mn10300_unwind_pc): Delete.
8878         (mn10300_unwind_sp): Delete.
8879         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8880         mn10300_unwind_sp.
8881         (mn10300_frame_unwind_init): Don't register deleted functions with
8882         gdbarch.
8883
8884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * mep-tdep.c (mep_unwind_pc): Delete.
8887         (mep_unwind_sp): Delete.
8888         (mep_dummy_id): Delete.
8889         (mep_gdbarch_init): Don't register deleted functions with
8890         gdbarch.
8891
8892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8893
8894         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8895         (m68hc11_unwind_sp): Delete.
8896         (m68hc11_gdbarch_init): Don't register deleted functions with
8897         gdbarch.
8898
8899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * m32r-tdep.c (m32r_unwind_sp): Delete.
8902         (m32r_unwind_pc): Delete.
8903         (m32r_dummy_id): Delete.
8904         (m32r_gdbarch_init): Don't register deleted functions with
8905         gdbarch.
8906
8907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * m32c-tdep.c (m32c_unwind_pc): Delete.
8910         (m32c_unwind_sp): Delete.
8911         (m32c_dummy_id): Delete.
8912         (m32c_gdbarch_init): Don't register deleted functions with
8913         gdbarch.
8914
8915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8916
8917         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8918         (lm32_unwind_pc): Delete.
8919         (lm32_dummy_id): Delete.
8920         (lm32_gdbarch_init): Don't register deleted functions with
8921         gdbarch.
8922
8923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8924
8925         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8926         (iq2000_unwind_pc): Delete.
8927         (iq2000_dummy_id): Delete.
8928         (iq2000_gdbarch_init): Don't register deleted functions with
8929         gdbarch.
8930
8931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * nds32-tdep.c (nds32_type_align): Delete.
8934         (nds32_push_dummy_call): Use type_align instead.
8935
8936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * arm-tdep.c (arm_type_align): Only handle vector override case.
8939         (arm_push_dummy_call): Use type_align.
8940         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8941
8942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8945         case.
8946         (pass_on_stack): Use type_align.
8947         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8948         function.
8949
8950 2019-04-23  Tom Tromey  <tromey@adacore.com>
8951
8952         * dwarf2read.c (line_header::file_name_at): Remove unused
8953         overload.
8954
8955 2019-04-23  Tom de Vries  <tdevries@suse.de>
8956
8957         PR gdb/24438
8958         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8959         invocation.
8960
8961
8962 2019-03-27  Ali Tamur  <tamur@google.com>
8963
8964         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8965         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8966         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8967         (dwarf_expr_context::get_addr_index): Likewise
8968         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8969         (symbol_needs_eval_context::get_addr_index): Likewise
8970         (disassemble_dwarf_expression): Add DW_OP_addrx
8971         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8972         (read_cutu_die_from_dwo): Update comment
8973         (skip_one_die): Add DW_FORM_addrx
8974         (read_attribute_value): Likewise
8975         (var_decode_location): Add DW_OP_addrx
8976         (dwarf2_const_value_attr): Add DW_FORM_addrx
8977         (dump_die_shallow): Likewise
8978         (dwarf2_fetch_constant_bytes): Likewise
8979         (decode_locdesc): Add DW_OP_addrx
8980         (skip_form_bytes): Add DW_FORM_addrx
8981
8982 2019-04-22  Ali Tamur  <tamur@google.com>
8983
8984         * MAINTAINERS (Write After Approval): Add self.
8985
8986 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8987
8988         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8989         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8990         (open_symbol_file_object): Likewise.
8991         (svr4_default_sos): Add info parameter.
8992         (svr4_read_so_list): Likewise.
8993         (svr4_current_sos_direct): Adjust functions calls to pass down
8994         info.
8995         (svr4_current_sos_1): Add info parameter.
8996         (svr4_current_sos): Call get_svr4_info, pass info down to
8997         svr4_current_sos_1.
8998         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8999         get_svr4_info.
9000         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9001         get_svr4_info.
9002         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9003         to get_svr4_info.
9004         (probes_table_remove_objfile_probes): Likewise.
9005         (register_solib_event_probe): Add info parameter.
9006         (solist_update_incremental): Pass info parameter down to
9007         svr4_read_so_list.
9008         (disable_probes_interface): Add info parameter.
9009         (svr4_handle_solib_event): Pass current_program_space to
9010         get_svr4_info.  Adjust disable_probes_interface cleanup.
9011         (svr4_create_probe_breakpoints): Add info parameter, pass it
9012         down to register_solib_event_probe.
9013         (svr4_create_solib_event_breakpoints): Add info parameter,
9014         pass it down to svr4_create_probe_breakpoints.
9015         (enable_break): Pass info down to
9016         svr4_create_solib_event_breakpoints.
9017         (svr4_solib_create_inferior_hook): Pass current_program_space to
9018         get_svr4_info.
9019         (svr4_clear_solib): Likewise.
9020
9021 2019-04-22  Pedro Alves  <palves@redhat.com>
9022
9023         * solib-svr4.c (svr4_free_objfile_observer): New.
9024         (probe_and_action::objfile): New field.
9025         (probes_table_htab_remove_objfile_probes)
9026         (probes_table_remove_objfile_probes): New functions.
9027         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9028         in the new probe_and_action.  Don't store the probe in 'lookup'.
9029         (svr4_create_probe_breakpoints): Pass objfile to
9030         register_solib_event_probe.
9031         (_initialize_svr4_solib): Register a free_objfile observer.
9032
9033 2019-04-19  Tom Tromey  <tom@tromey.com>
9034
9035         * common/queue.h: Remove.
9036
9037 2019-04-19  Tom Tromey  <tom@tromey.com>
9038
9039         * event-loop.c: Don't include "common/queue.h".
9040
9041 2019-04-19  Tom Tromey  <tom@tromey.com>
9042
9043         * remote.c (remote_target): Use delete.
9044         * remote-notif.h: Include <list>, not "common/queue.h".
9045         (notif_client_p): Remove typedef.
9046         (remote_notif_state): Add constructor, destructor, initializer.
9047         <notif_queue>: Now a std::list.
9048         (remote_notif_state_xfree): Don't declare.
9049         * remote-notif.c (remote_notif_process, handle_notification)
9050         (remote_notif_state_allocate): Update.
9051         (~remote_notif_state): Rename from remote_notif_state_xfree.
9052
9053 2019-04-19  Tom Tromey  <tom@tromey.com>
9054
9055         * symfile.c (reread_symbols): Update.
9056         * objfiles.c (objfile_register_static_link)
9057         (objfile_lookup_static_link): Update
9058         (~objfile) Don't delete static_links.
9059         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9060
9061 2019-04-19  Tom Tromey  <tom@tromey.com>
9062
9063         * type-stack.h (struct type_stack) <insert>: Constify string.
9064         * type-stack.c (type_stack::insert): Constify string.
9065         * gdbtypes.h (lookup_template_type): Update.
9066         (address_space_name_to_int): Update.
9067         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9068         const.
9069         (lookup_template_type): Make name const.
9070         * c-exp.y: Update rules.
9071         (lex_one_token, classify_name, classify_inner_name)
9072         (c_print_token): Update.
9073         * p-exp.y: Update rules.
9074         (yylex): Update.
9075         * f-exp.y: Update rules.
9076         (yylex): Update.
9077         * d-exp.y: Update rules.
9078         (lex_one_token, classify_name, classify_inner_name): Update.
9079         * parse.c (write_dollar_variable, copy_name): Return std::string.
9080         * parser-defs.h (copy_name): Change return type.
9081         * m2-exp.y: Update rules.
9082         (yylex): Update.
9083         * go-exp.y (lex_one_token): Update.
9084         Update rules.
9085         (classify_unsafe_function, classify_packaged_name)
9086         (classify_name, yylex): Update.
9087
9088 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9089
9090         * configure.ac: add --enable-source-highlight switch.
9091         * configure: Regenerate.
9092         * top.c (print_gdb_version): plumb --enable-source-highlight
9093         status to "show configuration".
9094
9095 2019-04-19  Tom Tromey  <tromey@adacore.com>
9096
9097         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9098         Check ADA_TYPE_P.
9099         (empty_record, ada_template_to_fixed_record_type_1)
9100         (template_to_static_fixed_type)
9101         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9102         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9103         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9104         macros.
9105
9106 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9107
9108         PR symtab/24423:
9109         * source.c (print_source_lines_base): Advance "iter" when a
9110         control character is seen.
9111
9112 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9113
9114         * inferior.h (struct infcall_suspend_state_deleter):
9115         Catch exception in destructor to avoid crash.
9116
9117 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9118
9119         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9120         close to the add_com "shell".
9121
9122 2019-04-18  Tom Tromey  <tromey@adacore.com>
9123
9124         * process-stratum-target.h (class process_stratum_target)
9125         <stratum>: Add "final".
9126
9127 2019-04-17  Tom Tromey  <tromey@adacore.com>
9128
9129         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9130         against nullptr before use.
9131
9132 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9133
9134         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9135
9136 2019-04-17  Jim Wilson  <jimw@sifive.com>
9137             Andrew Burgess  <andrew.burgess@embecosm.com>
9138
9139         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9140         code read might fail, assume 4-byte breakpoint in that case.
9141
9142 2019-04-15  Leszek Swirski  <leszeks@google.com>
9143
9144         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9145         rather than a hand-rolled POD check when checking for forced MEMORY
9146         classification.
9147
9148 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9149
9150         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9151         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9152         function.
9153         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9154         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9155         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9156         declaration.
9157
9158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9159
9160         * aarch64-linux-nat.c
9161         (aarch64_linux_nat_target::thread_architecture): Add override.
9162         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9163         each VQ.
9164
9165 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9166
9167         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9168
9169 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9170
9171         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9172         target types of size 96-bits, add some additional comments, and
9173         check that the builtin type we found was the correct size.
9174
9175 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9176
9177         * utils.c (prompt_for_continue): Don't restore the styling at the
9178         end, as applied_style has the wrong value.  This fixes styling in
9179         long lists of file names that are interrupted by the "Continue?"
9180         prompt.
9181
9182 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9183
9184         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9185         * c-lang.c (c_language_defn): Likewise.
9186         (cplus_language_defn): Likewise.
9187         (asm_language_defn): Likewise.
9188         (minimal_language_defn): Likewise.
9189         * d-lang.c (d_language_defn): Likewise.
9190         * f-lang.c (f_language_defn): Likewise.
9191         * go-lang.c (go_language_defn): Likewise.
9192         * language.c (unknown_language_defn): Likewise.
9193         (auto_language_defn): Likewise.
9194         * language.h (struct language_defn): Remove la_magic field.
9195         (LANG_MAGIC): Delete.
9196         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9197         * objc-lang.c (objc_language_defn): Likewise.
9198         * opencl-lang.c (opencl_language_defn): Likewise.
9199         * p-lang.c (pascal_language_defn): Likewise.
9200         * rust-lang.c (rust_language_defn): Likewise.
9201
9202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9203
9204         * riscv-tdep.c (riscv_type_align): New function.
9205         (riscv_type_alignment): Delete.
9206         (riscv_arg_location): Use 'type_align'.
9207         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9208
9209 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * gdbtypes.c (type_align): A struct with no non-static fields also
9212         has alignment of 1.
9213
9214 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9215
9216         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9217         component to 0.
9218         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9219         member.
9220         (riscv_struct_info::analyse): New implementation using new
9221         analyse_inner member function.
9222         (riscv_struct_info::field_offset): New member function.
9223         (riscv_struct_info::m_offsets): New member variable.
9224         (riscv_struct_info::analyse_inner): New private member function,
9225         takes the old implementation of riscv_struct_info::analyse but
9226         extended to track field offsets.
9227         (riscv_call_arg_struct): Update the struct folding special cases
9228         to handle cases where empty C++ structs, which are non-zero
9229         length, are found.
9230         (riscv_arg_location): Initialise the length of each location, a
9231         non-zero length now indicates the location is in use.
9232         (riscv_push_dummy_call): Allow for the first location having a
9233         non-zero offset when setting up arguments.
9234         (riscv_return_value): Likewise, but for return values.
9235
9236 2019-04-11  Tom Tromey  <tromey@adacore.com>
9237
9238         * utils.c (internal_vproblem): Make "msg" const.
9239
9240 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9241
9242         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9243         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9244         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9245         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9246
9247 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9248
9249         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9250         function.
9251         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9252         of amd64_collect_native_gregset.
9253         (amd64_linux_nat_target::store_registers): Likewise.
9254
9255 2019-04-10  Tom Tromey  <tom@tromey.com>
9256
9257         * symtab.c (lookup_global_symbol_from_objfile)
9258         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9259         * objfiles.h (class separate_debug_iterator): New.
9260         (class separate_debug_range): New.
9261         (struct objfile) <separate_debug_objfiles>: New method.
9262         (objfile_separate_debug_iterate): Don't declare.
9263         * objfiles.c (separate_debug_iterator::operator++): Rename from
9264         objfile_separate_debug_iterate.
9265         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9266         iterator.
9267         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9268         iterator.
9269
9270 2019-04-10  Tom Tromey  <tom@tromey.com>
9271
9272         * symfile.c (reread_symbols): Remove old comment.
9273         * objfiles.c (free_all_objfiles): Fix a typo.
9274
9275 2019-04-10  Tom Tromey  <tom@tromey.com>
9276
9277         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9278         * minsyms.c (lookup_minimal_symbol): Use foreach.
9279         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9280         (lookup_minimal_symbol_solib_trampoline): Likewise.
9281         * symfile.c (reread_symbols): Use foreach.
9282
9283 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9284             Tom Tromey  <tromey@adacore.com>
9285
9286         PR rust/24414:
9287         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9288         (rust_lex_int_test): Change "value" to be LONGEST.
9289         (rust_lex_tests): Add test for long integer literal.
9290
9291 2019-04-09  Tom Tromey  <tromey@adacore.com>
9292
9293         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9294         to bool.
9295         (extended_remote_target::attach): Update.
9296         (remote_target::remote_notice_new_inferior): Update.
9297         (remote_target::add_current_inferior_and_thread): Update.
9298         * inferior.c (exit_inferior_1): Use "false".
9299         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9300
9301 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9302
9303         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9304         the "start" command.
9305
9306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9307
9308         * python/py-inferior.c (infpy_thread_from_thread_handle):
9309         Adjust comments to reflect renaming of thread_from_thread_handle
9310         to thread_from_handle.  Adjust keywords.  Fix type error message.
9311         (inferior_object_methods): Add thread_from_handle.  Retain
9312         thread_from_thread_handle, but mark it as deprecated.
9313
9314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9315
9316         * gdbthread.h (find_thread_by_handle): Revise declaration.
9317         * thread.c (find_thread_by_handle): Likewise.  Adjust
9318         implementation too.
9319         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9320         support for buffer objects as handles.
9321
9322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9323
9324         * python/py-infthread.c (thpy_thread_handle): New function.
9325         (thread_object_methods): Register thpy_thread_handle.
9326
9327 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9328
9329         * gdbthread.h (thread_to_thread_handle): Declare.
9330         * thread.c (gdbtypes.h): Include.
9331         (thread_to_thread_handle): New function.
9332
9333         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9334         (target_thread_info_to_thread_handle): Declare.
9335         * target.c (target_thread_info_to_thread_handle): New function.
9336         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9337         * target-delegates.c: Regenerate.
9338
9339         * linux-thread-db.c (class thread_db_target): Add method
9340         thread_info_to_thread_handle.
9341         (thread_db_target::thread_info_to_thread_handle): Define.
9342         * remote.c (class remote_target): Add new method
9343         thread_info_to_thread_handle.
9344         (remote_target::thread_info_to_thread_handle): Define.
9345
9346 2019-04-08  Pedro Alves  <palves@redhat.com>
9347
9348         * common/common-exceptions.c (throw_exception): Don't create
9349         named object to throw; throw directly.
9350         (throw_it): Likewise.  Don't initialize gdb_exception::message
9351         here, with new; pass FMT and AP to the ctor instead.
9352         * common/common-exceptions.h: Include <string>.
9353         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9354         const char *, va_list)): New ctor.  Use std::make_shared.
9355         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9356         errors)): Delete.
9357         (gdb_exception_error::gdb_exception_error(enum errors, const char
9358         *, va_list)): New.
9359         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9360         Add assertion.
9361         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9362         errors)): Delete.
9363         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9364         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9365         Add assertion.
9366
9367 2019-04-08  Tom Tromey  <tom@tromey.com>
9368
9369         * valops.c (value_rtti_indirect_type): Replace throw_exception
9370         with throw.
9371         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9372         with throw.
9373         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9374         throw.
9375         * target.c (target_translate_tls_address): Replace throw_exception
9376         with throw.
9377         * stack.c (frame_apply_command_count): Replace throw_exception
9378         with throw.
9379         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9380         throw.
9381         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9382         with throw.
9383         * rs6000-tdep.c (rs6000_frame_cache)
9384         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9385         * remote.c: Replace throw_exception with throw.
9386         * record-full.c (record_full_message, record_full_wait_1)
9387         (record_full_restore): Replace throw_exception with throw.
9388         * record-btrace.c:
9389         (get_thread_current_frame_id, record_btrace_start_replaying)
9390         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9391         (cmd_record_btrace_start): Replace throw_exception with throw.
9392         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9393         throw.
9394         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9395         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9396         * linespec.c:
9397         (find_linespec_symbols): Replace throw_exception with throw.
9398         * infrun.c (displaced_step_prepare, resume): Replace
9399         throw_exception with throw.
9400         * infcmd.c (post_create_inferior): Replace throw_exception with
9401         throw.
9402         * inf-loop.c (inferior_event_handler): Replace throw_exception
9403         with throw.
9404         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9405         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9406         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9407         (get_prev_frame_always, get_frame_pc_if_available)
9408         (get_frame_address_in_block_if_available, get_frame_language):
9409         Replace throw_exception with throw.
9410         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9411         throw_exception with throw.
9412         * eval.c (fetch_subexp_value, evaluate_var_value)
9413         (evaluate_funcall, evaluate_subexp_standard): Replace
9414         throw_exception with throw.
9415         * dwarf2loc.c (call_site_find_chain)
9416         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9417         Replace throw_exception with throw.
9418         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9419         with throw.
9420         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9421         throw.
9422         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9423         * completer.c (complete_line_internal): Replace throw_exception
9424         with throw.
9425         * compile/compile-object-run.c (compile_object_run): Replace
9426         throw_exception with throw.
9427         * cli/cli-script.c (process_next_line): Replace throw_exception
9428         with throw.
9429         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9430         (btrace_enable, btrace_maint_update_pt_packets): Replace
9431         throw_exception with throw.
9432         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9433         throw_exception with throw.
9434         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9435         throw_exception with throw.
9436         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9437         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9438         * aarch64-tdep.c (aarch64_make_prologue_cache)
9439         (aarch64_make_stub_cache): Replace throw_exception with throw.
9440
9441 2019-04-08  Tom Tromey  <tom@tromey.com>
9442
9443         * common/common-exceptions.c (throw_exception): Rename from
9444         throw_exception_cxx.  Remove old copy.  Make argument const.
9445         (throw_it): Create and throw exception objects directly.
9446         * common/common-exceptions.h (throw_exception): Make argument
9447         const.
9448         (struct gdb_exception_error): Add constructor.
9449         (struct gdb_exception_quit): Add constructor.
9450
9451 2019-04-08  Tom Tromey  <tom@tromey.com>
9452
9453         * common/common-exceptions.h (exception_rethrow): Don't declare.
9454         (TRY_SJLJ): Update comment.
9455         (TRY, CATCH, END_CATCH): Remove.
9456         * common/common-exceptions.c (exception_rethrow): Remove.
9457
9458 2019-04-08  Tom Tromey  <tom@tromey.com>
9459
9460         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9461         Remove.
9462         (gdb_exception_error): Rename from
9463         gdb_exception_RETURN_MASK_ERROR.
9464         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9465         (gdb_quit_bad_alloc): Update.
9466         * aarch64-tdep.c: Update.
9467         * ada-lang.c: Update.
9468         * ada-typeprint.c: Update.
9469         * ada-valprint.c: Update.
9470         * amd64-tdep.c: Update.
9471         * arch-utils.c: Update.
9472         * break-catch-throw.c: Update.
9473         * breakpoint.c: Update.
9474         * btrace.c: Update.
9475         * c-varobj.c: Update.
9476         * cli/cli-cmds.c: Update.
9477         * cli/cli-interp.c: Update.
9478         * cli/cli-script.c: Update.
9479         * common/common-exceptions.c: Update.
9480         * common/new-op.c: Update.
9481         * common/selftest.c: Update.
9482         * compile/compile-c-symbols.c: Update.
9483         * compile/compile-cplus-symbols.c: Update.
9484         * compile/compile-object-load.c: Update.
9485         * compile/compile-object-run.c: Update.
9486         * completer.c: Update.
9487         * corelow.c: Update.
9488         * cp-abi.c: Update.
9489         * cp-support.c: Update.
9490         * cp-valprint.c: Update.
9491         * darwin-nat.c: Update.
9492         * disasm-selftests.c: Update.
9493         * dtrace-probe.c: Update.
9494         * dwarf-index-cache.c: Update.
9495         * dwarf-index-write.c: Update.
9496         * dwarf2-frame-tailcall.c: Update.
9497         * dwarf2-frame.c: Update.
9498         * dwarf2loc.c: Update.
9499         * dwarf2read.c: Update.
9500         * eval.c: Update.
9501         * event-loop.c: Update.
9502         * event-top.c: Update.
9503         * exec.c: Update.
9504         * f-valprint.c: Update.
9505         * fbsd-tdep.c: Update.
9506         * frame-unwind.c: Update.
9507         * frame.c: Update.
9508         * gdbtypes.c: Update.
9509         * gnu-v3-abi.c: Update.
9510         * guile/guile-internal.h: Update.
9511         * guile/scm-block.c: Update.
9512         * guile/scm-breakpoint.c: Update.
9513         * guile/scm-cmd.c: Update.
9514         * guile/scm-disasm.c: Update.
9515         * guile/scm-frame.c: Update.
9516         * guile/scm-lazy-string.c: Update.
9517         * guile/scm-math.c: Update.
9518         * guile/scm-param.c: Update.
9519         * guile/scm-ports.c: Update.
9520         * guile/scm-pretty-print.c: Update.
9521         * guile/scm-symbol.c: Update.
9522         * guile/scm-symtab.c: Update.
9523         * guile/scm-type.c: Update.
9524         * guile/scm-value.c: Update.
9525         * i386-linux-tdep.c: Update.
9526         * i386-tdep.c: Update.
9527         * inf-loop.c: Update.
9528         * infcall.c: Update.
9529         * infcmd.c: Update.
9530         * infrun.c: Update.
9531         * jit.c: Update.
9532         * language.c: Update.
9533         * linespec.c: Update.
9534         * linux-fork.c: Update.
9535         * linux-nat.c: Update.
9536         * linux-tdep.c: Update.
9537         * linux-thread-db.c: Update.
9538         * main.c: Update.
9539         * mi/mi-cmd-break.c: Update.
9540         * mi/mi-cmd-stack.c: Update.
9541         * mi/mi-interp.c: Update.
9542         * mi/mi-main.c: Update.
9543         * objc-lang.c: Update.
9544         * p-valprint.c: Update.
9545         * parse.c: Update.
9546         * ppc-linux-tdep.c: Update.
9547         * printcmd.c: Update.
9548         * python/py-arch.c: Update.
9549         * python/py-breakpoint.c: Update.
9550         * python/py-cmd.c: Update.
9551         * python/py-finishbreakpoint.c: Update.
9552         * python/py-frame.c: Update.
9553         * python/py-framefilter.c: Update.
9554         * python/py-gdb-readline.c: Update.
9555         * python/py-inferior.c: Update.
9556         * python/py-infthread.c: Update.
9557         * python/py-lazy-string.c: Update.
9558         * python/py-linetable.c: Update.
9559         * python/py-objfile.c: Update.
9560         * python/py-param.c: Update.
9561         * python/py-prettyprint.c: Update.
9562         * python/py-progspace.c: Update.
9563         * python/py-record-btrace.c: Update.
9564         * python/py-record.c: Update.
9565         * python/py-symbol.c: Update.
9566         * python/py-type.c: Update.
9567         * python/py-unwind.c: Update.
9568         * python/py-utils.c: Update.
9569         * python/py-value.c: Update.
9570         * python/python.c: Update.
9571         * record-btrace.c: Update.
9572         * record-full.c: Update.
9573         * remote-fileio.c: Update.
9574         * remote.c: Update.
9575         * riscv-tdep.c: Update.
9576         * rs6000-aix-tdep.c: Update.
9577         * rs6000-tdep.c: Update.
9578         * rust-exp.y: Update.
9579         * rust-lang.c: Update.
9580         * s390-tdep.c: Update.
9581         * selftest-arch.c: Update.
9582         * solib-dsbt.c: Update.
9583         * solib-frv.c: Update.
9584         * solib-spu.c: Update.
9585         * solib-svr4.c: Update.
9586         * solib.c: Update.
9587         * sparc64-linux-tdep.c: Update.
9588         * stack.c: Update.
9589         * symfile-mem.c: Update.
9590         * symmisc.c: Update.
9591         * target.c: Update.
9592         * thread.c: Update.
9593         * top.c: Update.
9594         * tracefile-tfile.c: Update.
9595         * tui/tui.c: Update.
9596         * typeprint.c: Update.
9597         * unittests/cli-utils-selftests.c: Update.
9598         * unittests/parse-connection-spec-selftests.c: Update.
9599         * valops.c: Update.
9600         * valprint.c: Update.
9601         * value.c: Update.
9602         * varobj.c: Update.
9603         * windows-nat.c: Update.
9604         * x86-linux-nat.c: Update.
9605         * xml-support.c: Update.
9606
9607 2019-04-08  Tom Tromey  <tom@tromey.com>
9608
9609         * xml-support.c: Use C++ exception handling.
9610         * x86-linux-nat.c: Use C++ exception handling.
9611         * windows-nat.c: Use C++ exception handling.
9612         * varobj.c: Use C++ exception handling.
9613         * value.c: Use C++ exception handling.
9614         * valprint.c: Use C++ exception handling.
9615         * valops.c: Use C++ exception handling.
9616         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9617         handling.
9618         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9619         * typeprint.c: Use C++ exception handling.
9620         * tui/tui.c: Use C++ exception handling.
9621         * tracefile-tfile.c: Use C++ exception handling.
9622         * top.c: Use C++ exception handling.
9623         * thread.c: Use C++ exception handling.
9624         * target.c: Use C++ exception handling.
9625         * symmisc.c: Use C++ exception handling.
9626         * symfile-mem.c: Use C++ exception handling.
9627         * stack.c: Use C++ exception handling.
9628         * sparc64-linux-tdep.c: Use C++ exception handling.
9629         * solib.c: Use C++ exception handling.
9630         * solib-svr4.c: Use C++ exception handling.
9631         * solib-spu.c: Use C++ exception handling.
9632         * solib-frv.c: Use C++ exception handling.
9633         * solib-dsbt.c: Use C++ exception handling.
9634         * selftest-arch.c: Use C++ exception handling.
9635         * s390-tdep.c: Use C++ exception handling.
9636         * rust-lang.c: Use C++ exception handling.
9637         * rust-exp.y: Use C++ exception handling.
9638         * rs6000-tdep.c: Use C++ exception handling.
9639         * rs6000-aix-tdep.c: Use C++ exception handling.
9640         * riscv-tdep.c: Use C++ exception handling.
9641         * remote.c: Use C++ exception handling.
9642         * remote-fileio.c: Use C++ exception handling.
9643         * record-full.c: Use C++ exception handling.
9644         * record-btrace.c: Use C++ exception handling.
9645         * python/python.c: Use C++ exception handling.
9646         * python/py-value.c: Use C++ exception handling.
9647         * python/py-utils.c: Use C++ exception handling.
9648         * python/py-unwind.c: Use C++ exception handling.
9649         * python/py-type.c: Use C++ exception handling.
9650         * python/py-symbol.c: Use C++ exception handling.
9651         * python/py-record.c: Use C++ exception handling.
9652         * python/py-record-btrace.c: Use C++ exception handling.
9653         * python/py-progspace.c: Use C++ exception handling.
9654         * python/py-prettyprint.c: Use C++ exception handling.
9655         * python/py-param.c: Use C++ exception handling.
9656         * python/py-objfile.c: Use C++ exception handling.
9657         * python/py-linetable.c: Use C++ exception handling.
9658         * python/py-lazy-string.c: Use C++ exception handling.
9659         * python/py-infthread.c: Use C++ exception handling.
9660         * python/py-inferior.c: Use C++ exception handling.
9661         * python/py-gdb-readline.c: Use C++ exception handling.
9662         * python/py-framefilter.c: Use C++ exception handling.
9663         * python/py-frame.c: Use C++ exception handling.
9664         * python/py-finishbreakpoint.c: Use C++ exception handling.
9665         * python/py-cmd.c: Use C++ exception handling.
9666         * python/py-breakpoint.c: Use C++ exception handling.
9667         * python/py-arch.c: Use C++ exception handling.
9668         * printcmd.c: Use C++ exception handling.
9669         * ppc-linux-tdep.c: Use C++ exception handling.
9670         * parse.c: Use C++ exception handling.
9671         * p-valprint.c: Use C++ exception handling.
9672         * objc-lang.c: Use C++ exception handling.
9673         * mi/mi-main.c: Use C++ exception handling.
9674         * mi/mi-interp.c: Use C++ exception handling.
9675         * mi/mi-cmd-stack.c: Use C++ exception handling.
9676         * mi/mi-cmd-break.c: Use C++ exception handling.
9677         * main.c: Use C++ exception handling.
9678         * linux-thread-db.c: Use C++ exception handling.
9679         * linux-tdep.c: Use C++ exception handling.
9680         * linux-nat.c: Use C++ exception handling.
9681         * linux-fork.c: Use C++ exception handling.
9682         * linespec.c: Use C++ exception handling.
9683         * language.c: Use C++ exception handling.
9684         * jit.c: Use C++ exception handling.
9685         * infrun.c: Use C++ exception handling.
9686         * infcmd.c: Use C++ exception handling.
9687         * infcall.c: Use C++ exception handling.
9688         * inf-loop.c: Use C++ exception handling.
9689         * i386-tdep.c: Use C++ exception handling.
9690         * i386-linux-tdep.c: Use C++ exception handling.
9691         * guile/scm-value.c: Use C++ exception handling.
9692         * guile/scm-type.c: Use C++ exception handling.
9693         * guile/scm-symtab.c: Use C++ exception handling.
9694         * guile/scm-symbol.c: Use C++ exception handling.
9695         * guile/scm-pretty-print.c: Use C++ exception handling.
9696         * guile/scm-ports.c: Use C++ exception handling.
9697         * guile/scm-param.c: Use C++ exception handling.
9698         * guile/scm-math.c: Use C++ exception handling.
9699         * guile/scm-lazy-string.c: Use C++ exception handling.
9700         * guile/scm-frame.c: Use C++ exception handling.
9701         * guile/scm-disasm.c: Use C++ exception handling.
9702         * guile/scm-cmd.c: Use C++ exception handling.
9703         * guile/scm-breakpoint.c: Use C++ exception handling.
9704         * guile/scm-block.c: Use C++ exception handling.
9705         * guile/guile-internal.h: Use C++ exception handling.
9706         * gnu-v3-abi.c: Use C++ exception handling.
9707         * gdbtypes.c: Use C++ exception handling.
9708         * frame.c: Use C++ exception handling.
9709         * frame-unwind.c: Use C++ exception handling.
9710         * fbsd-tdep.c: Use C++ exception handling.
9711         * f-valprint.c: Use C++ exception handling.
9712         * exec.c: Use C++ exception handling.
9713         * event-top.c: Use C++ exception handling.
9714         * event-loop.c: Use C++ exception handling.
9715         * eval.c: Use C++ exception handling.
9716         * dwarf2read.c: Use C++ exception handling.
9717         * dwarf2loc.c: Use C++ exception handling.
9718         * dwarf2-frame.c: Use C++ exception handling.
9719         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9720         * dwarf-index-write.c: Use C++ exception handling.
9721         * dwarf-index-cache.c: Use C++ exception handling.
9722         * dtrace-probe.c: Use C++ exception handling.
9723         * disasm-selftests.c: Use C++ exception handling.
9724         * darwin-nat.c: Use C++ exception handling.
9725         * cp-valprint.c: Use C++ exception handling.
9726         * cp-support.c: Use C++ exception handling.
9727         * cp-abi.c: Use C++ exception handling.
9728         * corelow.c: Use C++ exception handling.
9729         * completer.c: Use C++ exception handling.
9730         * compile/compile-object-run.c: Use C++ exception handling.
9731         * compile/compile-object-load.c: Use C++ exception handling.
9732         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9733         * compile/compile-c-symbols.c: Use C++ exception handling.
9734         * common/selftest.c: Use C++ exception handling.
9735         * common/new-op.c: Use C++ exception handling.
9736         * cli/cli-script.c: Use C++ exception handling.
9737         * cli/cli-interp.c: Use C++ exception handling.
9738         * cli/cli-cmds.c: Use C++ exception handling.
9739         * c-varobj.c: Use C++ exception handling.
9740         * btrace.c: Use C++ exception handling.
9741         * breakpoint.c: Use C++ exception handling.
9742         * break-catch-throw.c: Use C++ exception handling.
9743         * arch-utils.c: Use C++ exception handling.
9744         * amd64-tdep.c: Use C++ exception handling.
9745         * ada-valprint.c: Use C++ exception handling.
9746         * ada-typeprint.c: Use C++ exception handling.
9747         * ada-lang.c: Use C++ exception handling.
9748         * aarch64-tdep.c: Use C++ exception handling.
9749
9750 2019-04-08  Tom Tromey  <tom@tromey.com>
9751
9752         * xml-support.c (gdb_xml_parser::parse): Update.
9753         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9754         * value.c (show_convenience): Update.
9755         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9756         (test_parse_flags_qcs): Update.
9757         * thread.c (thr_try_catch_cmd): Update.
9758         * target.c (target_translate_tls_address): Update.
9759         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9760         (info_frame_command_core, frame_apply_command_count): Update.
9761         * rust-exp.y (rust_lex_exception_test): Update.
9762         * riscv-tdep.c (riscv_print_one_register_info): Update.
9763         * remote.c (remote_target::enable_btrace): Update.
9764         * record-btrace.c (record_btrace_enable_warn): Update.
9765         * python/py-utils.c (gdbpy_convert_exception): Update.
9766         * printcmd.c (do_one_display, print_variable_and_value): Update.
9767         * mi/mi-main.c (mi_print_exception): Update.
9768         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9769         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9770         * linux-nat.c (linux_nat_target::attach): Update.
9771         * linux-fork.c (class scoped_switch_fork_info): Update.
9772         * infrun.c (displaced_step_prepare): Update.
9773         * infcall.c (call_function_by_hand_dummy): Update.
9774         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9775         * gnu-v3-abi.c (print_one_vtable): Update.
9776         * frame.c (get_prev_frame_always): Update.
9777         * f-valprint.c (info_common_command_for_block): Update.
9778         * exec.c (try_open_exec_file): Update.
9779         * exceptions.c (print_exception, exception_print)
9780         (exception_fprintf, exception_print_same): Update.
9781         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9782         * dwarf-index-cache.c (index_cache::store)
9783         (index_cache::lookup_gdb_index): Update.
9784         * darwin-nat.c (maybe_cache_shell): Update.
9785         * cp-valprint.c (cp_print_value_fields): Update.
9786         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9787         (gcc_cplus_symbol_address): Update.
9788         * compile/compile-c-symbols.c (gcc_convert_symbol)
9789         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9790         * common/selftest.c: Update.
9791         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9792         a std::string.
9793         (exception_try_scope_entry, exception_try_scope_exit): Don't
9794         declare.
9795         (struct exception_try_scope): Remove.
9796         (TRY): Don't use exception_try_scope.
9797         (struct gdb_exception): Add constructor, operator=.
9798         <what>: New method.
9799         (struct gdb_exception_RETURN_MASK_ALL)
9800         (struct gdb_exception_RETURN_MASK_ERROR)
9801         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9802         (struct gdb_quit_bad_alloc): Update.
9803         * common/common-exceptions.c (exception_none): Change
9804         initializer.
9805         (struct catcher) <state, exception>: Initialize inline.
9806         <prev>: Remove member.
9807         (current_catcher): Remove.
9808         (catchers): New global.
9809         (exceptions_state_mc_init): Simplify.
9810         (catcher_pop): Remove.
9811         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9812         (try_scope_depth, exception_try_scope_entry)
9813         (exception_try_scope_exit): Remove.
9814         (throw_exception_sjlj): Update.
9815         (exception_messages, exception_messages_size): Remove.
9816         (throw_it): Simplify.
9817         (gdb_exception_sliced_copy): Remove.
9818         (throw_exception_cxx): Update.
9819         * cli/cli-script.c (script_from_file): Update.
9820         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9821         Update.
9822         * ada-valprint.c (ada_val_print): Update.
9823         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9824         (create_excep_cond_exprs): Update.
9825
9826 2019-04-08  Tom Tromey  <tom@tromey.com>
9827
9828         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9829         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9830         (TRY, CATCH, END_CATCH): Remove some definitions.
9831         * common/common-exceptions.c: Don't use GDB_XCPT.
9832         (catcher_list_size): Remove.
9833         (throw_exception, throw_it): Simplify.
9834
9835 2019-04-05  Tom Tromey  <tom@tromey.com>
9836
9837         Revert the header-sorting patch.
9838         * ft32-tdep.c: Revert.
9839         * frv-tdep.c: Revert.
9840         * frv-linux-tdep.c: Revert.
9841         * frame.c: Revert.
9842         * frame-unwind.c: Revert.
9843         * frame-base.c: Revert.
9844         * fork-child.c: Revert.
9845         * findvar.c: Revert.
9846         * findcmd.c: Revert.
9847         * filesystem.c: Revert.
9848         * filename-seen-cache.h: Revert.
9849         * filename-seen-cache.c: Revert.
9850         * fbsd-tdep.c: Revert.
9851         * fbsd-nat.h: Revert.
9852         * fbsd-nat.c: Revert.
9853         * f-valprint.c: Revert.
9854         * f-typeprint.c: Revert.
9855         * f-lang.c: Revert.
9856         * extension.h: Revert.
9857         * extension.c: Revert.
9858         * extension-priv.h: Revert.
9859         * expprint.c: Revert.
9860         * exec.h: Revert.
9861         * exec.c: Revert.
9862         * exceptions.c: Revert.
9863         * event-top.c: Revert.
9864         * event-loop.c: Revert.
9865         * eval.c: Revert.
9866         * elfread.c: Revert.
9867         * dwarf2read.h: Revert.
9868         * dwarf2read.c: Revert.
9869         * dwarf2loc.c: Revert.
9870         * dwarf2expr.h: Revert.
9871         * dwarf2expr.c: Revert.
9872         * dwarf2-frame.c: Revert.
9873         * dwarf2-frame-tailcall.c: Revert.
9874         * dwarf-index-write.h: Revert.
9875         * dwarf-index-write.c: Revert.
9876         * dwarf-index-common.c: Revert.
9877         * dwarf-index-cache.h: Revert.
9878         * dwarf-index-cache.c: Revert.
9879         * dummy-frame.c: Revert.
9880         * dtrace-probe.c: Revert.
9881         * disasm.h: Revert.
9882         * disasm.c: Revert.
9883         * disasm-selftests.c: Revert.
9884         * dictionary.c: Revert.
9885         * dicos-tdep.c: Revert.
9886         * demangle.c: Revert.
9887         * dcache.h: Revert.
9888         * dcache.c: Revert.
9889         * darwin-nat.h: Revert.
9890         * darwin-nat.c: Revert.
9891         * darwin-nat-info.c: Revert.
9892         * d-valprint.c: Revert.
9893         * d-namespace.c: Revert.
9894         * d-lang.c: Revert.
9895         * ctf.c: Revert.
9896         * csky-tdep.c: Revert.
9897         * csky-linux-tdep.c: Revert.
9898         * cris-tdep.c: Revert.
9899         * cris-linux-tdep.c: Revert.
9900         * cp-valprint.c: Revert.
9901         * cp-support.c: Revert.
9902         * cp-namespace.c: Revert.
9903         * cp-abi.c: Revert.
9904         * corelow.c: Revert.
9905         * corefile.c: Revert.
9906         * continuations.c: Revert.
9907         * completer.h: Revert.
9908         * completer.c: Revert.
9909         * complaints.c: Revert.
9910         * coffread.c: Revert.
9911         * coff-pe-read.c: Revert.
9912         * cli-out.h: Revert.
9913         * cli-out.c: Revert.
9914         * charset.c: Revert.
9915         * c-varobj.c: Revert.
9916         * c-valprint.c: Revert.
9917         * c-typeprint.c: Revert.
9918         * c-lang.c: Revert.
9919         * buildsym.c: Revert.
9920         * buildsym-legacy.c: Revert.
9921         * build-id.h: Revert.
9922         * build-id.c: Revert.
9923         * btrace.c: Revert.
9924         * bsd-uthread.c: Revert.
9925         * breakpoint.h: Revert.
9926         * breakpoint.c: Revert.
9927         * break-catch-throw.c: Revert.
9928         * break-catch-syscall.c: Revert.
9929         * break-catch-sig.c: Revert.
9930         * blockframe.c: Revert.
9931         * block.c: Revert.
9932         * bfin-tdep.c: Revert.
9933         * bfin-linux-tdep.c: Revert.
9934         * bfd-target.c: Revert.
9935         * bcache.c: Revert.
9936         * ax-general.c: Revert.
9937         * ax-gdb.h: Revert.
9938         * ax-gdb.c: Revert.
9939         * avr-tdep.c: Revert.
9940         * auxv.c: Revert.
9941         * auto-load.c: Revert.
9942         * arm-wince-tdep.c: Revert.
9943         * arm-tdep.c: Revert.
9944         * arm-symbian-tdep.c: Revert.
9945         * arm-pikeos-tdep.c: Revert.
9946         * arm-obsd-tdep.c: Revert.
9947         * arm-nbsd-tdep.c: Revert.
9948         * arm-nbsd-nat.c: Revert.
9949         * arm-linux-tdep.c: Revert.
9950         * arm-linux-nat.c: Revert.
9951         * arm-fbsd-tdep.c: Revert.
9952         * arm-fbsd-nat.c: Revert.
9953         * arm-bsd-tdep.c: Revert.
9954         * arch-utils.c: Revert.
9955         * arc-tdep.c: Revert.
9956         * arc-newlib-tdep.c: Revert.
9957         * annotate.h: Revert.
9958         * annotate.c: Revert.
9959         * amd64-windows-tdep.c: Revert.
9960         * amd64-windows-nat.c: Revert.
9961         * amd64-tdep.c: Revert.
9962         * amd64-sol2-tdep.c: Revert.
9963         * amd64-obsd-tdep.c: Revert.
9964         * amd64-obsd-nat.c: Revert.
9965         * amd64-nbsd-tdep.c: Revert.
9966         * amd64-nbsd-nat.c: Revert.
9967         * amd64-nat.c: Revert.
9968         * amd64-linux-tdep.c: Revert.
9969         * amd64-linux-nat.c: Revert.
9970         * amd64-fbsd-tdep.c: Revert.
9971         * amd64-fbsd-nat.c: Revert.
9972         * amd64-dicos-tdep.c: Revert.
9973         * amd64-darwin-tdep.c: Revert.
9974         * amd64-bsd-nat.c: Revert.
9975         * alpha-tdep.c: Revert.
9976         * alpha-obsd-tdep.c: Revert.
9977         * alpha-nbsd-tdep.c: Revert.
9978         * alpha-mdebug-tdep.c: Revert.
9979         * alpha-linux-tdep.c: Revert.
9980         * alpha-linux-nat.c: Revert.
9981         * alpha-bsd-tdep.c: Revert.
9982         * alpha-bsd-nat.c: Revert.
9983         * aix-thread.c: Revert.
9984         * agent.c: Revert.
9985         * addrmap.c: Revert.
9986         * ada-varobj.c: Revert.
9987         * ada-valprint.c: Revert.
9988         * ada-typeprint.c: Revert.
9989         * ada-tasks.c: Revert.
9990         * ada-lang.c: Revert.
9991         * aarch64-tdep.c: Revert.
9992         * aarch64-ravenscar-thread.c: Revert.
9993         * aarch64-newlib-tdep.c: Revert.
9994         * aarch64-linux-tdep.c: Revert.
9995         * aarch64-linux-nat.c: Revert.
9996         * aarch64-fbsd-tdep.c: Revert.
9997         * aarch64-fbsd-nat.c: Revert.
9998         * aarch32-linux-nat.c: Revert.
9999
10000 2019-04-05  Tom Tromey  <tom@tromey.com>
10001
10002         * ft32-tdep.c: Sort headers.
10003         * frv-tdep.c: Sort headers.
10004         * frv-linux-tdep.c: Sort headers.
10005         * frame.c: Sort headers.
10006         * frame-unwind.c: Sort headers.
10007         * frame-base.c: Sort headers.
10008         * fork-child.c: Sort headers.
10009         * findvar.c: Sort headers.
10010         * findcmd.c: Sort headers.
10011         * filesystem.c: Sort headers.
10012         * filename-seen-cache.h: Sort headers.
10013         * filename-seen-cache.c: Sort headers.
10014         * fbsd-tdep.c: Sort headers.
10015         * fbsd-nat.h: Sort headers.
10016         * fbsd-nat.c: Sort headers.
10017         * f-valprint.c: Sort headers.
10018         * f-typeprint.c: Sort headers.
10019         * f-lang.c: Sort headers.
10020         * extension.h: Sort headers.
10021         * extension.c: Sort headers.
10022         * extension-priv.h: Sort headers.
10023         * expprint.c: Sort headers.
10024         * exec.h: Sort headers.
10025         * exec.c: Sort headers.
10026         * exceptions.c: Sort headers.
10027         * event-top.c: Sort headers.
10028         * event-loop.c: Sort headers.
10029         * eval.c: Sort headers.
10030         * elfread.c: Sort headers.
10031         * dwarf2read.h: Sort headers.
10032         * dwarf2read.c: Sort headers.
10033         * dwarf2loc.c: Sort headers.
10034         * dwarf2expr.h: Sort headers.
10035         * dwarf2expr.c: Sort headers.
10036         * dwarf2-frame.c: Sort headers.
10037         * dwarf2-frame-tailcall.c: Sort headers.
10038         * dwarf-index-write.h: Sort headers.
10039         * dwarf-index-write.c: Sort headers.
10040         * dwarf-index-common.c: Sort headers.
10041         * dwarf-index-cache.h: Sort headers.
10042         * dwarf-index-cache.c: Sort headers.
10043         * dummy-frame.c: Sort headers.
10044         * dtrace-probe.c: Sort headers.
10045         * disasm.h: Sort headers.
10046         * disasm.c: Sort headers.
10047         * disasm-selftests.c: Sort headers.
10048         * dictionary.c: Sort headers.
10049         * dicos-tdep.c: Sort headers.
10050         * demangle.c: Sort headers.
10051         * dcache.h: Sort headers.
10052         * dcache.c: Sort headers.
10053         * darwin-nat.h: Sort headers.
10054         * darwin-nat.c: Sort headers.
10055         * darwin-nat-info.c: Sort headers.
10056         * d-valprint.c: Sort headers.
10057         * d-namespace.c: Sort headers.
10058         * d-lang.c: Sort headers.
10059         * ctf.c: Sort headers.
10060         * csky-tdep.c: Sort headers.
10061         * csky-linux-tdep.c: Sort headers.
10062         * cris-tdep.c: Sort headers.
10063         * cris-linux-tdep.c: Sort headers.
10064         * cp-valprint.c: Sort headers.
10065         * cp-support.c: Sort headers.
10066         * cp-namespace.c: Sort headers.
10067         * cp-abi.c: Sort headers.
10068         * corelow.c: Sort headers.
10069         * corefile.c: Sort headers.
10070         * continuations.c: Sort headers.
10071         * completer.h: Sort headers.
10072         * completer.c: Sort headers.
10073         * complaints.c: Sort headers.
10074         * coffread.c: Sort headers.
10075         * coff-pe-read.c: Sort headers.
10076         * cli-out.h: Sort headers.
10077         * cli-out.c: Sort headers.
10078         * charset.c: Sort headers.
10079         * c-varobj.c: Sort headers.
10080         * c-valprint.c: Sort headers.
10081         * c-typeprint.c: Sort headers.
10082         * c-lang.c: Sort headers.
10083         * buildsym.c: Sort headers.
10084         * buildsym-legacy.c: Sort headers.
10085         * build-id.h: Sort headers.
10086         * build-id.c: Sort headers.
10087         * btrace.c: Sort headers.
10088         * bsd-uthread.c: Sort headers.
10089         * breakpoint.h: Sort headers.
10090         * breakpoint.c: Sort headers.
10091         * break-catch-throw.c: Sort headers.
10092         * break-catch-syscall.c: Sort headers.
10093         * break-catch-sig.c: Sort headers.
10094         * blockframe.c: Sort headers.
10095         * block.c: Sort headers.
10096         * bfin-tdep.c: Sort headers.
10097         * bfin-linux-tdep.c: Sort headers.
10098         * bfd-target.c: Sort headers.
10099         * bcache.c: Sort headers.
10100         * ax-general.c: Sort headers.
10101         * ax-gdb.h: Sort headers.
10102         * ax-gdb.c: Sort headers.
10103         * avr-tdep.c: Sort headers.
10104         * auxv.c: Sort headers.
10105         * auto-load.c: Sort headers.
10106         * arm-wince-tdep.c: Sort headers.
10107         * arm-tdep.c: Sort headers.
10108         * arm-symbian-tdep.c: Sort headers.
10109         * arm-pikeos-tdep.c: Sort headers.
10110         * arm-obsd-tdep.c: Sort headers.
10111         * arm-nbsd-tdep.c: Sort headers.
10112         * arm-nbsd-nat.c: Sort headers.
10113         * arm-linux-tdep.c: Sort headers.
10114         * arm-linux-nat.c: Sort headers.
10115         * arm-fbsd-tdep.c: Sort headers.
10116         * arm-fbsd-nat.c: Sort headers.
10117         * arm-bsd-tdep.c: Sort headers.
10118         * arch-utils.c: Sort headers.
10119         * arc-tdep.c: Sort headers.
10120         * arc-newlib-tdep.c: Sort headers.
10121         * annotate.h: Sort headers.
10122         * annotate.c: Sort headers.
10123         * amd64-windows-tdep.c: Sort headers.
10124         * amd64-windows-nat.c: Sort headers.
10125         * amd64-tdep.c: Sort headers.
10126         * amd64-sol2-tdep.c: Sort headers.
10127         * amd64-obsd-tdep.c: Sort headers.
10128         * amd64-obsd-nat.c: Sort headers.
10129         * amd64-nbsd-tdep.c: Sort headers.
10130         * amd64-nbsd-nat.c: Sort headers.
10131         * amd64-nat.c: Sort headers.
10132         * amd64-linux-tdep.c: Sort headers.
10133         * amd64-linux-nat.c: Sort headers.
10134         * amd64-fbsd-tdep.c: Sort headers.
10135         * amd64-fbsd-nat.c: Sort headers.
10136         * amd64-dicos-tdep.c: Sort headers.
10137         * amd64-darwin-tdep.c: Sort headers.
10138         * amd64-bsd-nat.c: Sort headers.
10139         * alpha-tdep.c: Sort headers.
10140         * alpha-obsd-tdep.c: Sort headers.
10141         * alpha-nbsd-tdep.c: Sort headers.
10142         * alpha-mdebug-tdep.c: Sort headers.
10143         * alpha-linux-tdep.c: Sort headers.
10144         * alpha-linux-nat.c: Sort headers.
10145         * alpha-bsd-tdep.c: Sort headers.
10146         * alpha-bsd-nat.c: Sort headers.
10147         * aix-thread.c: Sort headers.
10148         * agent.c: Sort headers.
10149         * addrmap.c: Sort headers.
10150         * ada-varobj.c: Sort headers.
10151         * ada-valprint.c: Sort headers.
10152         * ada-typeprint.c: Sort headers.
10153         * ada-tasks.c: Sort headers.
10154         * ada-lang.c: Sort headers.
10155         * aarch64-tdep.c: Sort headers.
10156         * aarch64-ravenscar-thread.c: Sort headers.
10157         * aarch64-newlib-tdep.c: Sort headers.
10158         * aarch64-linux-tdep.c: Sort headers.
10159         * aarch64-linux-nat.c: Sort headers.
10160         * aarch64-fbsd-tdep.c: Sort headers.
10161         * aarch64-fbsd-nat.c: Sort headers.
10162         * aarch32-linux-nat.c: Sort headers.
10163
10164 2019-04-04  Tom Tromey  <tom@tromey.com>
10165
10166         * varobj.c (varobj_create): Update.
10167         * rust-exp.y (struct rust_parser) <update_innermost_block,
10168         lookup_symbol>: New methods.
10169         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10170         Rename.
10171         (rust_parser::rust_lookup_type)
10172         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10173         * printcmd.c (display_command, do_one_display): Update.
10174         * parser-defs.h (struct parser_state) <parser_state>: Add
10175         "tracker" parameter.
10176         (block_tracker): New member.
10177         (class innermost_block_tracker) <innermost_block_tracker>: Add
10178         "types" parameter.
10179         <reset>: Remove method.
10180         (innermost_block): Don't declare.
10181         (null_post_parser): Update.
10182         * parse.c (innermost_block): Remove global.
10183         (write_dollar_variable): Update.
10184         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10185         Remove "tracker_types" parameter.
10186         (parse_expression): Add "tracker" parameter.
10187         (parse_expression_for_completion): Update.
10188         (null_post_parser): Add "tracker" parameter.
10189         * p-exp.y: Update rules.
10190         * m2-exp.y: Update rules.
10191         * language.h (struct language_defn) <la_post_parser>: Add
10192         "tracker" parameter.
10193         * go-exp.y: Update rules.
10194         * f-exp.y: Update rules.
10195         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10196         parameter.
10197         * d-exp.y: Update rules.
10198         * c-exp.y: Update rules.
10199         * breakpoint.c (set_breakpoint_condition): Create an
10200         innermost_block_tracker.
10201         (watch_command_1): Likewise.
10202         * ada-lang.c (resolve): Add "tracker" parameter.
10203         (resolve_subexp): Likewise.
10204         * ada-exp.y (write_var_from_sym): Update.
10205
10206 2019-04-04  Tom Tromey  <tom@tromey.com>
10207
10208         * type-stack.h: New file.
10209         * type-stack.c: New file.
10210         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10211         type-stack.h.
10212         (insert_into_type_stack, insert_type, push_type, push_type_int)
10213         (insert_type_address_space, pop_type, pop_type_int)
10214         (pop_typelist, pop_type_stack, append_type_stack)
10215         (push_type_stack, get_type_stack, push_typelist)
10216         (follow_type_instance_flags, follow_types): Don't declare.
10217         * parse.c (type_stack): Remove global.
10218         (parse_exp_in_context): Update.
10219         (insert_into_type_stack, insert_type, push_type, push_type_int)
10220         (insert_type_address_space, pop_type, pop_type_int)
10221         (pop_typelist, pop_type_stack, append_type_stack)
10222         (push_type_stack, get_type_stack, push_typelist)
10223         (follow_type_instance_flags, follow_types): Remove (moved to
10224         type-stack.c).
10225         * f-exp.y (type_stack): New global.
10226         Update rules.
10227         (push_kind_type, f_parse): Update.
10228         * d-exp.y (type_stack): New global.
10229         Update rules.
10230         (d_parse): Update.
10231         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10232         Update rules.
10233         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10234         (HFILES_NO_SRCDIR): Add type-stack.h.
10235
10236 2019-04-04  Tom Tromey  <tom@tromey.com>
10237
10238         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10239         (rust_parser::convert_ast_to_expression, rust_parse)
10240         (rust_lex_test_completion, rust_lex_tests): Update.
10241         * parser-defs.h (struct expr_completion_state): New.
10242         (struct parser_state) <parser_state>: Add completion parameter.
10243         <mark_struct_expression, mark_completion_tag>: New methods.
10244         <parse_completion, m_completion_state>: New members.
10245         (prefixify_expression, null_post_parser): Update.
10246         (mark_struct_expression, mark_completion_tag): Don't declare.
10247         * parse.c (parse_completion, expout_last_struct)
10248         (expout_tag_completion_type, expout_completion_name): Remove
10249         globals.
10250         (parser_state::mark_struct_expression)
10251         (parser_state::mark_completion_tag): Now methods.
10252         (prefixify_expression): Add last_struct parameter.
10253         (prefixify_subexp): Likewise.
10254         (parse_exp_1): Update.
10255         (parse_exp_in_context): Add cstate parameter.  Update.
10256         (parse_expression_for_completion): Create an
10257         expr_completion_state.
10258         (null_post_parser): Add "completion" parameter.
10259         * p-exp.y: Update rules.
10260         (yylex): Update.
10261         * language.h (struct language_defn) <la_post_parser>: Add
10262         "completing" parameter.
10263         * go-exp.y: Update rules.
10264         (lex_one_token): Update.
10265         * expression.h (parse_completion): Don't declare.
10266         * d-exp.y: Update rules.
10267         (lex_one_token): Update rules.
10268         * c-exp.y: Update rules.
10269         (lex_one_token): Update.
10270         * ada-lang.c (resolve): Add "parse_completion" parameter.
10271         (resolve_subexp): Likewise.
10272         (ada_resolve_function): Likewise.
10273
10274 2019-04-04  Tom Tromey  <tom@tromey.com>
10275
10276         * parser-defs.h (struct parser_state) <start_arglist,
10277         end_arglist>: New methods.
10278         <arglist_len, m_funcall_chain>: New members.
10279         (arglist_len, start_arglist, end_arglist): Don't declare.
10280         * parse.c (arglist_len, funcall_chain): Remove global.
10281         (start_arglist, end_arglist): Remove functions.
10282         (parse_exp_in_context): Update.
10283         * p-exp.y: Update rules.
10284         * m2-exp.y: Update rules.
10285         * go-exp.y: Update rules.
10286         * f-exp.y: Update rules.
10287         * d-exp.y: Update rules.
10288         * c-exp.y: Update rules.
10289
10290 2019-04-04  Tom Tromey  <tom@tromey.com>
10291
10292         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10293         lex_operator, push_back>: New methods.
10294         Update all rules.
10295         (rust_parser::lex_hex, lex_escape): Rename and update.
10296         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10297         (rust_parser::lex_operator): Rename and update.
10298         (rust_parser::lex_number, rustyylex, rustyyerror)
10299         (rust_lex_test_init, rust_lex_test_sequence)
10300         (rust_lex_test_push_back, rust_lex_tests): Update.
10301         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10302         parameter.
10303         <lexptr, prev_lexptr>: New members.
10304         (lexptr, prev_lexptr): Don't declare.
10305         * parse.c (lexptr, prev_lexptr): Remove globals.
10306         (parse_exp_in_context): Update.
10307         * p-exp.y (yylex, yyerror): Update.
10308         * m2-exp.y (parse_number, yylex, yyerror): Update.
10309         * go-exp.y (lex_one_token, yyerror): Update.
10310         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10311         * d-exp.y (lex_one_token, yyerror): Update.
10312         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10313         (lex_one_token, yyerror): Update.
10314         * ada-lex.l (YY_INPUT): Update.
10315         (rewind_to_char): Update.
10316         * ada-exp.y (yyerror): Update.
10317
10318 2019-04-04  Tom Tromey  <tom@tromey.com>
10319
10320         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10321         * parser-defs.h (struct parser_state) <parser_state>: Add new
10322         parameter.
10323         <comma_terminates>: New member.
10324         (comma_terminates): Don't declare global.
10325         * parse.c (comma_terminates): Remove global.
10326         (parse_exp_in_context): Update.
10327         * p-exp.y (yylex): Update.
10328         * m2-exp.y (yylex): Update.
10329         * go-exp.y (lex_one_token): Update.
10330         * f-exp.y (yylex): Update.
10331         * d-exp.y (lex_one_token): Update.
10332         * c-exp.y (lex_one_token): Update.
10333         * ada-lex.l: Update.
10334
10335 2019-04-04  Tom Tromey  <tom@tromey.com>
10336
10337         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10338         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10339         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10340         * parser-defs.h (paren_depth): Don't declare.
10341         * parse.c (paren_depth): Remove global.
10342         (parse_exp_in_context): Update.
10343         * p-exp.y (paren_depth): New global.
10344         (pascal_parse): Initialize it.
10345         * m2-exp.y (paren_depth): New global.
10346         (m2_parse): Initialize it.
10347         * go-exp.y (paren_depth): New global.
10348         (go_parse): Initialize it.
10349         * f-exp.y (paren_depth): New global.
10350         (f_parse): Initialize it.
10351         * d-exp.y (paren_depth): New global.
10352         (d_parse): Initialize it.
10353         * c-exp.y (paren_depth): New global.
10354         (c_parse): Initialize it.
10355         * ada-lex.l (paren_depth): New global.
10356         (lexer_init): Initialize it.
10357
10358 2019-04-04  Tom Tromey  <tom@tromey.com>
10359
10360         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10361         (rust_parser::convert_ast_to_type)
10362         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10363         * parser-defs.h (struct parser_state) <parser_state>: Add
10364         parameters.  Initialize new members.
10365         <expression_context_block, expression_context_pc>: New members.
10366         * parse.c (expression_context_block, expression_context_pc):
10367         Remove globals.
10368         (parse_exp_in_context): Update.
10369         * p-exp.y: Update all rules.
10370         (yylex): Update.
10371         * m2-exp.y: Update all rules.
10372         (yylex): Update.
10373         * go-exp.y (yylex): Update.
10374         * f-exp.y (yylex): Update.
10375         * d-exp.y: Update all rules.
10376         (yylex): Update.
10377         * c-exp.y: Update all rules.
10378         (lex_one_token, classify_name, yylex, c_parse): Update.
10379         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10380
10381 2019-04-04  Tom Tromey  <tom@tromey.com>
10382
10383         * gdbarch.h, gdbarch.c: Rebuild.
10384         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10385         * stap-probe.h:
10386         (struct stap_parse_info): Replace "parser_state" with
10387         "expr_builder".
10388         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10389         (parser_state): New class.
10390         * parse.c (expr_builder): Rename.
10391         (expr_builder::release): Rename.
10392         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10393         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10394         (write_exp_elt_longcst, write_exp_elt_floatcst)
10395         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10396         (write_exp_string_vector, write_exp_bitstring)
10397         (write_exp_msymbol, mark_struct_expression)
10398         (write_dollar_variable)
10399         (insert_type_address_space, increase_expout_size): Replace
10400         "parser_state" with "expr_builder".
10401         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10402         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10403         "parser_state" with "expr_builder".
10404
10405 2019-04-04  Tom Tromey  <tom@tromey.com>
10406
10407         * rust-exp.y: Replace "parse_language" with method call.
10408         * p-exp.y:
10409         (yylex): Replace "parse_language" with method call.
10410         * m2-exp.y:
10411         (yylex): Replace "parse_language" with method call.
10412         * go-exp.y (classify_name): Replace "parse_language" with method
10413         call.
10414         * f-exp.y (yylex): Replace "parse_language" with method call.
10415         * d-exp.y (lex_one_token): Replace "parse_language" with method
10416         call.
10417         * c-exp.y:
10418         (lex_one_token, classify_name, yylex): Replace "parse_language"
10419         with method call.
10420         * ada-exp.y (find_primitive_type, type_char)
10421         (type_system_address): Replace "parse_language" with method call.
10422
10423 2019-04-04  Tom Tromey  <tom@tromey.com>
10424
10425         * rust-exp.y: Replace "parse_gdbarch" with method call.
10426         * parse.c (write_dollar_variable, insert_type_address_space):
10427         Replace "parse_gdbarch" with method call.
10428         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10429         call.
10430         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10431         call.
10432         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10433         "parse_gdbarch" with method call.
10434         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10435         with method call.
10436         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10437         "parse_gdbarch" with method call.
10438         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10439         "parse_gdbarch" with method call.
10440         * c-exp.y (parse_type, parse_number, classify_name): Replace
10441         "parse_gdbarch" with method call.
10442         * ada-lex.l: Replace "parse_gdbarch" with method call.
10443         * ada-exp.y (parse_type, find_primitive_type, type_char)
10444         (type_system_address): Replace "parse_gdbarch" with method call.
10445
10446 2019-04-04  Tom Tromey  <tom@tromey.com>
10447
10448         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10449         * stap-probe.c (stap_parse_argument): Update.
10450         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10451         initial_size parameter.
10452         * rust-exp.y (rust_lex_tests): Update.
10453         * parse.c (parser_state): Update.
10454         (parse_exp_in_context): Update.
10455         * parser-defs.h (struct parser_state) <parser_state>: Remove
10456         "initial_size" parameter.
10457
10458 2019-04-04  Tom Tromey  <tom@tromey.com>
10459
10460         * parser-defs.h (increase_expout_size): Don't declare.
10461         * parse.c (increase_expout_size): Now static.
10462
10463 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10464
10465         * gnu-nat.c (gnu_nat_target::wait): Fix
10466         target_waitstatus_to_string call.
10467
10468 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10469
10470         * eval.c (evaluate_subexp_standard): Handle internal functions
10471         during Fortran function call handling.
10472
10473 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10474
10475         * NEWS: Mention new internal functions.
10476         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10477         (read_base_type): Use dwarf2_init_complex_target_type.
10478         * value.c (creal_internal_fn): New function.
10479         (cimag_internal_fn): New function.
10480         (_initialize_values): Register new internal functions.
10481
10482 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10483
10484         * infrun.c (stop_all_threads): If debug_infrun, always
10485         trace the wait status after wait_one, using
10486         target_waitstatus_to_string and target_pid_to_str.
10487         (handle_inferior_event): Replace various trace of
10488         wait status kind by a single trace.
10489         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10490         wait status kind image by target_waitstatus_to_string.
10491         * target/waitstatus.c (target_waitstatus_to_string): Fix
10492         obsolete comment.
10493
10494 2019-04-01  Tom Tromey  <tromey@adacore.com>
10495
10496         PR symtab/23331:
10497         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10498
10499 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10500             Pedro Alves  <palves@redhat.com>
10501
10502         * top.c (quit_force): Call 'finalize_values'.
10503         * value.c (finalize_values): New function.
10504         * value.h (finalize_values): Declare.
10505
10506 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10507
10508         * NEWS: Announce $_gdb_major and $_gdb_minor.
10509
10510         * top.c (init_gdb_version_vars): New function.
10511         (gdb_init): Call init_gdb_version_vars.
10512
10513 2019-03-29  Tom Tromey  <tromey@adacore.com>
10514
10515         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10516         help text.  Remove dead code.
10517
10518 2019-03-29  Keith Seitz  <keiths@redhat.com>
10519
10520         From Siddhesh Poyarekar:
10521         * f-lang.h (f77_get_upperbound): Return LONGEST.
10522         (f77_get_lowerbound): Likewise.
10523         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10524         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10525         print them.
10526         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10527         plongest to format print it.
10528         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10529         (f77_get_upperbound): Likewise.
10530         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10531         LOWER_BOUND to LONGEST.
10532         (f77_create_arrayprint_offset_tbl): Likewise.
10533
10534 2019-03-29  Keith Seitz  <keiths@redhat.com>
10535
10536         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10537         %s/pulongest for TYPE_LENGTH instead of %d in format
10538         strings.
10539         * ada-typerint.c (ada_print_type): Likewise.
10540         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10541         * compile/compile-c-support.c (generate_register_struct): Likewise.
10542         * gdbtypes.c (recursive_dump_type): Likewise.
10543         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10544         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10545         instead of %d in format strings.
10546         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10547         to std::min to ULONGEST.
10548         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10549         instead of %d in format strings.
10550         * tracepoint.c (info_scope_command): Likewise.
10551         * typeprint.c (print_offset_data::update)
10552         (print_offset_data::finish): Likewise.
10553         * xtensa-tdep.c (xtensa_store_return_value)
10554         (xtensa_push_dummy_call): Likewise.
10555
10556 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10557
10558         * windows-nat.c (display_selector): Fixed format specifications
10559         for 64-bit Cygwin.
10560
10561 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10562
10563         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10564
10565 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10566
10567         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10568         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10569         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10570         (nios2_linux_init_abi): Install it.
10571
10572 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10573
10574         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10575
10576 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10577
10578         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10579
10580 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10581             Tom Tromey  <tromey@adacore.com>
10582
10583         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10584
10585 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10586
10587         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10588         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10589         method to compute the bounds of range types. Also print "[evaluated]"
10590         if the bounds' values come from a dynamic evaluation.
10591
10592 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10593
10594         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10595         whitespace when pretty printing is on.
10596
10597 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10598
10599         * ppc-linux-nat.c: Add include.
10600
10601 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10602
10603         * NEWS: Mention AArch64 Pointer Authentication.
10604
10605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10606
10607         * arm-linux-nat.c: Add include.
10608
10609 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10610
10611         * source-cache.c (source_cache::get_source_lines): Re-read
10612         fullname after calling open_source_file.
10613
10614 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10615
10616         * NEWS: Mention TLS support for FreeBSD.
10617
10618 2019-03-25  Tom Tromey  <tromey@adacore.com>
10619
10620         * minsyms.c (BUNCH_SIZE): Update comment.
10621         (~minimal_symbol_reader): Remove old comment.
10622         (compact_minimal_symbols): Update comment.
10623         (minimal_symbol_reader::install): Remove old comment.  Update
10624         other comments.
10625
10626 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10627
10628         * s390-linux-nat.c: Add include.
10629
10630 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10631
10632         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10633         Call linux_get_hwcap.
10634         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10635         Likewise.
10636         (aarch64_linux_get_hwcap): Remove function.
10637         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10638         declaration.
10639         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10640         linux_get_hwcap.
10641         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10642         * linux-tdep.c (linux_get_hwcap): Add function.
10643         (linux_get_hwcap2): Likewise.
10644         * linux-tdep.h (linux_get_hwcap): Add declaration.
10645         (linux_get_hwcap2): Likewise.
10646         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10647         (ppc_linux_get_hwcap2): Likewise.
10648         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10649         linux_get_hwcap.
10650         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10651         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10652         (ppc_linux_nat_target::read_description): Likewise.
10653         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10654         * s390-linux-nat.c: Likewise.
10655         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10656
10657 2019-03-24  Tom Tromey  <tom@tromey.com>
10658
10659         * ada-lang.c (standard_lookup): Simplify initialization.
10660         (ada_lookup_symbol_nonlocal): Simplify return.
10661         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10662         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10663         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10664         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10665         initialization.
10666         * solib.c (solib_global_lookup): Simplify.
10667         * symtab.c (null_block_symbol): Remove.
10668         (symbol_cache_lookup): Simplify returns.
10669         (lookup_language_this): Simplify returns.
10670         (lookup_symbol_aux): Simplify return.
10671         (lookup_local_symbol): Simplify returns.
10672         (lookup_global_symbol_from_objfile): Simplify return.
10673         (lookup_symbol_in_objfile_symtabs)
10674         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10675         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10676         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10677         * cp-namespace.c (cp_lookup_bare_symbol)
10678         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10679         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10680         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10681         (cp_lookup_symbol_via_imports): Simplify initialization.
10682         (find_symbol_in_baseclass): Likewise.
10683         * symtab.h (null_block_symbol): Remove.
10684         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10685         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10686         (d_lookup_symbol_module): Likewise.
10687         (find_symbol_in_baseclass): Simplify initialization.
10688
10689 2019-03-24  Tom Tromey  <tom@tromey.com>
10690
10691         * expression.h: Don't include symtab.h.
10692         (struct block): Forward declare.
10693
10694 2019-03-24  Tom Tromey  <tom@tromey.com>
10695
10696         * c-exp.y (typebase): Remove casts.
10697         * gdbtypes.c (lookup_unsigned_typename, )
10698         (lookup_signed_typename): Remove cast.
10699         * eval.c (parse_to_comma_and_eval): Remove cast.
10700         * parse.c (write_dollar_variable): Remove cast.
10701         * block.h (struct block) <superblock>: Now const.
10702         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10703         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10704         (map_block): Make "block" const.
10705         * symfile.h (struct quick_symbol_functions)
10706         <map_matching_symbols>: Constify block argument to "callback".
10707         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10708         const.
10709         (find_pc_sect_compunit_symtab): Make "b" const.
10710         (find_symbol_at_address): Likewise.
10711         (search_symbols): Likewise.
10712         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10713         (dw2_debug_names_lookup_symbol): Likewise.
10714         (dw2_map_matching_symbols): Update.
10715         * p-valprint.c (pascal_val_print): Remove "block".
10716         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10717         (aux_add_nonlocal_symbols): Make "block" const.
10718         (resolve_subexp): Remove cast.
10719         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10720         const.
10721         (iterate_over_file_blocks): Likewise.
10722         * f-exp.y (%union) <bval>: Remove.
10723         * coffread.c (patch_opaque_types): Make "b" const.
10724         * spu-tdep.c (spu_catch_start): Make "block" const.
10725         * c-valprint.c (print_unpacked_pointer): Remove "block".
10726         * symmisc.c (dump_symtab_1): Make "b" const.
10727         (block_depth): Make "block" const.
10728         * d-exp.y (%union) <bval>: Remove.
10729         * cp-support.h (cp_lookup_rtti_type): Update.
10730         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10731         * psymtab.c (psym_lookup_symbol): Make "block" const.
10732         (maintenance_check_psymtabs): Make "b" const.
10733         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10734         (enumerate_locals, enumerate_args): Update.
10735         * python/py-symtab.c (stpy_global_block): Make "block" const.
10736         (stpy_static_block): Likewise.
10737         * inline-frame.c (block_starting_point_at): Make "new_block"
10738         const.
10739         * block.c (find_block_in_blockvector): Make return type const.
10740         (blockvector_for_pc_sect): Make "b" const.
10741         (find_block_in_blockvector): Make "b" const.
10742
10743 2019-03-23  Tom Tromey  <tom@tromey.com>
10744
10745         * varobj.c (varobj_create): Update.
10746         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10747         * printcmd.c (display_command, do_one_display): Don't reset
10748         innermost_block.
10749         * parser-defs.h (enum innermost_block_tracker_type): Move to
10750         expression.h.
10751         (innermost_block): Update comment.
10752         * parse.c (parse_exp_1): Add tracker_types parameter.
10753         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10754         tracker_types parameter.  Reset innermost_block.
10755         (parse_exp_in_context): Remove.
10756         (parse_expression_for_completion): Update.
10757         * objfiles.c (~objfile): Don't reset expression_context_block or
10758         innermost_block.
10759         * expression.h (enum innermost_block_tracker_type): Move from
10760         parser-defs.h.
10761         (parse_exp_1): Add tracker_types parameter.
10762         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10763         reset innermost_block.
10764
10765 2019-03-23  Tom Tromey  <tom@tromey.com>
10766
10767         * objfiles.h: Include bcache.h.
10768
10769 2019-03-23  Tom Tromey  <tom@tromey.com>
10770
10771         * linespec.c (get_current_search_block): Use
10772         scoped_restore_current_language.
10773         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10774
10775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10776             Jiong Wang  <jiong.wang@arm.com>
10777
10778         * aarch64-linux-tdep.c
10779         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10780         section.
10781         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10782
10783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10784             Jiong Wang  <jiong.wang@arm.com>
10785
10786         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10787         instructions.
10788         (aarch64_analyze_prologue_test): Add PACIASP test.
10789         (aarch64_prologue_prev_register): Unmask PC value.
10790
10791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10792             Jiong Wang  <jiong.wang@arm.com>
10793
10794         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10795         (aarch64_dwarf2_prev_register): Unmask PC value.
10796         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10797         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10798         DW_CFA_AARCH64_negate_ra_state.
10799         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10800
10801 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10802             Jiong Wang  <jiong.wang@arm.com>
10803
10804         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10805         registers.
10806         (aarch64_pseudo_register_name): Likewise.
10807         (aarch64_pseudo_register_type): Likewise.
10808         (aarch64_pseudo_register_reggroup_p): Likewise.
10809         (aarch64_gdbarch_init): Add pauth registers.
10810         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10811         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10812         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10813         (struct gdbarch_tdep): Add regnum for ra_state.
10814
10815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10816             Jiong Wang  <jiong.wang@arm.com>
10817
10818         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10819
10820 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10821             Jiong Wang  <jiong.wang@arm.com>
10822
10823         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10824         function.
10825         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10826         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10827         (aarch64_gdbarch_init): Add puth registers.
10828         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10829         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10830         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10831
10832 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10833             Jiong Wang  <jiong.wang@arm.com>
10834
10835         * aarch64-linux-nat.c
10836         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10837         * aarch64-linux-tdep.c
10838         (aarch64_linux_core_read_description): Likewise.
10839         (aarch64_linux_get_hwcap): New function.
10840         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10841         (aarch64_linux_get_hwcap): New declaration.
10842
10843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10844             Jiong Wang  <jiong.wang@arm.com>
10845
10846         * aarch64-linux-nat.c
10847         (aarch64_linux_nat_target::read_description): Add pauth param.
10848         * aarch64-linux-tdep.c
10849         (aarch64_linux_core_read_description): Likewise.
10850         * aarch64-tdep.c (struct target_desc): Add in pauth.
10851         (aarch64_read_description): Add pauth param.
10852         (aarch64_gdbarch_init): Likewise.
10853         * aarch64-tdep.h (aarch64_read_description): Likewise.
10854         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10855         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10856         * features/Makefile: Add new files.
10857         * features/aarch64-pauth.c: New file.
10858         * features/aarch64-pauth.xml: New file.
10859
10860 2019-03-20  Tom Tromey  <tromey@adacore.com>
10861
10862         * infrun.c (handle_inferior_event): Rename from
10863         handle_inferior_event_1.  Create a scoped_value_mark.
10864         (handle_inferior_event): Remove.
10865
10866 2019-03-19  Tom Tromey  <tromey@adacore.com>
10867
10868         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10869         * infrun.h (print_stop_event): Add "displays" parameter.
10870         * infrun.c (print_stop_event): Add "displays" parameter.
10871
10872 2019-03-19  Pedro Alves  <palves@redhat.com>
10873
10874         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10875         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10876         to -1.  Fix TABs vs spaces.
10877         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10878         * tui/tui-out.h (tui_ui_out) Add intro comments.
10879         <m_line, m_start_of_line>: In-class initialize, and add describing
10880         comment.
10881
10882 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10883
10884         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10885         variable names.
10886         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10887
10888 2019-03-18  Pedro Alves  <palves@redhat.com>
10889             Eli Zaretskii <eliz@gnu.org>
10890
10891         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10892         m_line and m_start_of_line.
10893
10894 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10895
10896         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10897         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10898         it returns a newline.  This fixes a regression in TU mode, whereby
10899         the next line is output on the same screen line as the user input.
10900
10901 2019-03-18  Tom Tromey  <tromey@adacore.com>
10902
10903         * minsyms.c (minimal_symbol_reader::install): Remove call to
10904         obstack_blank.
10905
10906 2019-03-18  Pedro Alves  <palves@redhat.com>
10907
10908         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10909         New globals.
10910         (apply_style): New, factored out from ...
10911         (apply_ansi_escape): ... this.  Handle reverse video mode.
10912         (tui_set_reverse_mode): New function.
10913         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10914         * tui/tui-winsource.c (tui_show_source_line): Use
10915         tui_set_reverse_mode instead of setting A_STANDOUT.
10916         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10917         New setter methods.
10918
10919 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10920
10921         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10922         Handle tabs.
10923
10924 2019-03-18  Tom Tromey  <tromey@adacore.com>
10925
10926         * ada-lang.c (empty_array): Add "high" parameter.
10927         (ada_evaluate_subexp): Update.
10928
10929 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10930
10931         * unittests/string_view-selftests.c: Define
10932         _initialize_string_view_selftests unconditionally.
10933
10934 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10935
10936         PR gdb/24350
10937         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10938
10939 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10940
10941         PR gdb/24351
10942         * windows-nat.c (display_selector): Fix format specifiers.
10943
10944 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10945
10946         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10947         tui_refill_source_window instead of tui_refresh_win, to update the
10948         current execution line.  This fixes redisplay of the current line
10949         when stepping through the code with "next" or "step".
10950
10951 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10952
10953         * source-cache.c (source_cache::get_source_lines): Call
10954         find_source_lines to initialize s->nlines.  This fixes vertical
10955         scrolling of TUI source window when the DOWN arrow is pressed.
10956
10957 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10958
10959         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10960         linux-thread-db.c (_initialize_thread_db): Likewise.
10961
10962 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10963
10964         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10965         wclrtoeol in tui_show_source_line".  This reverts changes made in
10966         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10967
10968 2019-03-15  Tom Tromey  <tom@tromey.com>
10969
10970         * symtab.h (struct minimal_symbol): Derive from
10971         general_symbol_info.
10972         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10973         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10974         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10975         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10976         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10977         (MSYMBOL_SEARCH_NAME): Update.
10978         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10979         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10980         * minsyms.c (minimal_symbol_reader::record_full): Update.
10981
10982 2019-03-15  Tom Tromey  <tom@tromey.com>
10983
10984         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10985
10986 2019-03-15  Tom Tromey  <tom@tromey.com>
10987
10988         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10989         unique_xmalloc_ptr.
10990         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10991         Update.
10992         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10993         (build_minimal_symbol_hash_tables)
10994         (minimal_symbol_reader::install): Update.
10995
10996 2019-03-15  Tom Tromey  <tom@tromey.com>
10997
10998         * symtab.c (create_demangled_names_hash): Update.
10999         (symbol_set_names): Update.
11000         * objfiles.h (struct objfile_per_bfd_storage)
11001         <demangled_names_hash>: Now an htab_up.
11002         * objfiles.c (objfile_per_bfd_storage): Simplify.
11003
11004 2019-03-15  Tom Tromey  <tom@tromey.com>
11005
11006         * objfiles.h (struct objfile_per_bfd_storage): Declare
11007         destructor.
11008         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11009         New.
11010         (get_objfile_bfd_data): Use new.  Don't initialize
11011         language_of_main.
11012         (free_objfile_per_bfd_storage): Remove.
11013         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11014
11015 2019-03-15  Tom Tromey  <tom@tromey.com>
11016
11017         * symfile.c (reread_symbols): Update.
11018         * objfiles.c (objfile::objfile): Update.
11019         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11020         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11021         comment.
11022         (minimal_symbol_reader::install): Update.
11023         (terminate_minimal_symbol_table): Remove.
11024         * jit.c (jit_object_close_impl): Update.
11025
11026 2019-03-15  Tom Tromey  <tom@tromey.com>
11027
11028         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11029         initializations.
11030
11031 2019-03-15  Tom Tromey  <tom@tromey.com>
11032
11033         * objfiles.h (struct objfile_per_bfd_storage)
11034         <demangled_hash_languages>: Now a bitset.
11035         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11036         (lookup_minimal_symbol): Update.
11037
11038 2019-03-15  Tom Tromey  <tom@tromey.com>
11039
11040         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11041         Don't return the symbol.
11042         * coffread.c (record_minimal_symbol): Use record_full.
11043
11044 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11045
11046         The MS-Windows port of ncurses fails to switch to a color pair if
11047         one or both of the colors are the implicit default colors.  This
11048         change records the default colors when TUI is initialized, and
11049         then specifies them explicitly when a color pair uses the default
11050         colors.  This allows color styling in TUI mode on MS-Windows.
11051
11052         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11053         ncurses_norm_attr.
11054         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11055         colors in ncurses_norm_attr.
11056         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11057         "none", replace it with the default color recorded in
11058         ncurses_norm_attr.
11059
11060 2019-03-14  Tom Tromey  <tromey@adacore.com>
11061
11062         * source-cache.h (class source_cache) <get_source_lines>: Return
11063         std::string.
11064         * source-cache.c (source_cache::extract_lines): Handle case where
11065         first_pos==npos.  Return std::string.
11066         (source_cache::get_source_lines): Update.
11067
11068 2019-03-14  Tom Tromey  <tromey@adacore.com>
11069
11070         * NEWS: Add item for "style sources" commands.
11071         * source-cache.c (source_cache::get_source_lines): Check
11072         source_styling.
11073         * cli/cli-style.c (source_styling): New global.
11074         (_initialize_cli_style): Add "style sources" commands.
11075         (show_style_sources): New function.
11076         * cli/cli-style.h (source_styling): Declare.
11077
11078 2019-03-14  Pedro Alves  <palves@redhat.com>
11079             Tom Tromey  <tromey@adacore.com>
11080
11081         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11082         * tui/tui-winsource.c (tui_refill_source_window): New function,
11083         from...
11084         (tui_horizontal_source_scroll): ... here.  Move some logic.
11085         * cli/cli-style.c (set_style_enabled): Notify new observable.
11086         * tui/tui-hooks.c (tui_redisplay_source): New function.
11087         (tui_attach_detach_observers): Attach or detach
11088         tui_redisplay_source.
11089         * observable.h (source_styling_changed): New observable.
11090         * observable.c: Define source_styling_changed observable.
11091
11092 2019-03-13  Tom Tromey  <tromey@adacore.com>
11093
11094         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11095         (i386_gnu_nat_target::store_registers): Update.
11096         * target-debug.h (target_debug_print_std_string): New macro.
11097         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11098         * windows-tdep.c (display_one_tib): Update.
11099         * tui/tui-stack.c (tui_make_status_line): Update.
11100         * top.c (print_inferior_quit_action): Update.
11101         * thread.c (thr_try_catch_cmd): Update.
11102         (add_thread_with_info): Update.
11103         (thread_target_id_str): Update.
11104         (thr_try_catch_cmd): Update.
11105         (thread_command): Update.
11106         (thread_find_command): Update.
11107         * record-btrace.c (record_btrace_target::info_record)
11108         (record_btrace_resume_thread, record_btrace_target::resume)
11109         (record_btrace_cancel_resume, record_btrace_step_thread)
11110         (record_btrace_target::wait, record_btrace_target::wait)
11111         (record_btrace_target::wait, record_btrace_target::stop): Update.
11112         * progspace.c (print_program_space): Update.
11113         * process-stratum-target.c
11114         (process_stratum_target::thread_address_space): Update.
11115         * linux-fork.c (linux_fork_mourn_inferior)
11116         (detach_checkpoint_command, info_checkpoints_command)
11117         (linux_fork_context): Update.
11118         (linux_fork_detach): Update.
11119         (class scoped_switch_fork_info): Update.
11120         (delete_checkpoint_command): Update.
11121         * infrun.c (follow_fork_inferior): Update.
11122         (follow_fork_inferior): Update.
11123         (proceed_after_vfork_done): Update.
11124         (handle_vfork_child_exec_or_exit): Update.
11125         (follow_exec): Update.
11126         (displaced_step_prepare_throw): Update.
11127         (displaced_step_restore): Update.
11128         (start_step_over): Update.
11129         (resume_1): Update.
11130         (clear_proceed_status_thread): Update.
11131         (proceed): Update.
11132         (print_target_wait_results): Update.
11133         (do_target_wait): Update.
11134         (context_switch): Update.
11135         (stop_all_threads): Update.
11136         (restart_threads): Update.
11137         (finish_step_over): Update.
11138         (handle_signal_stop): Update.
11139         (switch_back_to_stepped_thread): Update.
11140         (keep_going_pass_signal): Update.
11141         (print_exited_reason): Update.
11142         (normal_stop): Update.
11143         * inferior.c (inferior_pid_to_str): Change return type.
11144         (print_selected_inferior): Update.
11145         (add_inferior): Update.
11146         (detach_inferior): Update.
11147         * dummy-frame.c (fprint_dummy_frames): Update.
11148         * dcache.c (dcache_info_1): Update.
11149         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11150         (btrace_fetch, btrace_clear): Update.
11151         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11152         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11153         type.
11154         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11155         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11156         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11157         * gdbarch.c, gdbarch.h: Rebuild.
11158         * gdbarch.sh (core_pid_to_str): Change return type.
11159         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11160         return type.
11161         (windows_nat_target::pid_to_str): Change return type.
11162         (windows_delete_thread): Update.
11163         (windows_nat_target::attach): Update.
11164         (windows_nat_target::files_info): Update.
11165         * target-delegates.c: Rebuild.
11166         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11167         return type.
11168         (sol_thread_target::pid_to_str): Change return type.
11169         * remote.c (class remote_target) <pid_to_str>: Change return
11170         type.
11171         (remote_target::pid_to_str): Change return type.
11172         (extended_remote_target::attach, remote_target::remote_stop_ns)
11173         (remote_target::remote_notif_remove_queued_reply)
11174         (remote_target::push_stop_reply, remote_target::disable_btrace):
11175         Update.
11176         (extended_remote_target::attach): Update.
11177         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11178         type.
11179         (gdbsim_target::pid_to_str): Change return type.
11180         * ravenscar-thread.c (struct ravenscar_thread_target)
11181         <pid_to_str>: Change return type.
11182         (ravenscar_thread_target::pid_to_str): Change return type.
11183         * procfs.c (class procfs_target) <pid_to_str>: Change return
11184         type.
11185         (procfs_target::pid_to_str): Change return type.
11186         (procfs_target::attach): Update.
11187         (procfs_target::detach): Update.
11188         (procfs_target::fetch_registers): Update.
11189         (procfs_target::store_registers): Update.
11190         (procfs_target::wait): Update.
11191         (procfs_target::files_info): Update.
11192         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11193         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11194         return type.
11195         (nto_procfs_target::pid_to_str): Change return type.
11196         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11197         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11198         return type.
11199         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11200         (exit_lwp): Update.
11201         (attach_proc_task_lwp_callback, get_detach_signal)
11202         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11203         (linux_nat_target::resume, wait_lwp, stop_callback)
11204         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11205         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11206         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11207         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11208         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11209         type.
11210         (inf_ptrace_target::attach): Update.
11211         (inf_ptrace_target::files_info): Update.
11212         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11213         type.
11214         (go32_nat_target::pid_to_str): Change return type.
11215         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11216         (gnu_nat_target::wait): Update.
11217         (gnu_nat_target::wait): Update.
11218         (gnu_nat_target::resume): Update.
11219         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11220         (fbsd_nat_target::wait): Update.
11221         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11222         type.
11223         (darwin_nat_target::attach): Update.
11224         * corelow.c (class core_target) <pid_to_str>: Change return type.
11225         (core_target::pid_to_str): Change return type.
11226         * target.c (normal_pid_to_str): Change return type.
11227         (default_pid_to_str): Likewise.
11228         (target_pid_to_str): Change return type.
11229         (target_translate_tls_address): Update.
11230         (target_announce_detach): Update.
11231         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11232         return type.
11233         (bsd_uthread_target::pid_to_str): Change return type.
11234         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11235         type.
11236         (bsd_kvm_target::pid_to_str): Change return type.
11237         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11238         return type.
11239         (aix_thread_target::pid_to_str): Change return type.
11240         * target.h (struct target_ops) <pid_to_str>: Change return type.
11241         (target_pid_to_str, normal_pid_to_str): Likewise.
11242         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11243         type.
11244         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11245         type.
11246         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11247         return type.
11248         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11249         type.
11250         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11251         type.
11252         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11253         return type.
11254
11255 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11256
11257         * NEWS: Mention that the new default MI version is 3.  Mention
11258         changes to the output of commands and events that deal with
11259         multi-location breakpoints.
11260         * breakpoint.c: Include "mi/mi-out.h".
11261         (print_one_breakpoint): Change output syntax if using MI version
11262         >= 3.
11263         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11264         New.
11265         (mi_multi_location_breakpoint_output_fixed): New.
11266         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11267         (mi_cmd_fix_multi_location_breakpoint_output): New.
11268         (mi_multi_location_breakpoint_output_fixed): New.
11269         * mi/mi-cmds.c (mi_cmds): Register command
11270         -fix-multi-location-breakpoint-output.
11271         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11272         interpreter "mi".
11273
11274 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11275
11276         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11277         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11278         instantiate mi_ui_out based on interpreter name.
11279         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11280         * mi/mi-main.c (mi_load_progress): Likewise.
11281
11282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11283
11284         * NEWS: Combine separate "New targets" sections for 8.3.
11285
11286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11287
11288         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11289         (ppcfbsd_init_abi): Install gdbarch
11290         "fetch_tls_load_module_address" and "get_thread_local_address"
11291         methods.
11292
11293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11294
11295         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11296         (riscv_fbsd_init_abi): Install gdbarch
11297         "fetch_tls_load_module_address" and "get_thread_local_address"
11298         methods.
11299
11300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11301
11302         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11303         (i386fbsd_init_abi): Install gdbarch
11304         "fetch_tls_load_module_address" and "get_thread_local_address"
11305         methods.
11306
11307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11308
11309         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11310         (amd64fbsd_init_abi): Install gdbarch
11311         "fetch_tls_load_module_address" and "get_thread_local_address"
11312         methods.
11313
11314 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11315
11316         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11317         (struct fbsd_pspace_data): New type.
11318         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11319         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11320         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11321         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11322         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11323
11324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11325
11326         * gdbtypes.c (lookup_struct_elt): New function.
11327         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11328         * gdbtypes.h (struct struct_elt): New type.
11329         (lookup_struct_elt): New prototype.
11330
11331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11332
11333         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11334         remove disabled code block.
11335
11336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11337
11338         * gdbarch.sh (get_thread_local_address): New method.
11339         * gdbarch.h, gdbarch.c: Regenerate.
11340         * target.c (target_translate_tls_address): Use
11341         gdbarch_get_thread_local_address if present instead of
11342         target::get_thread_local_address.
11343
11344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11345
11346         * target.h (target::get_thread_local_address): Update comment.
11347
11348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11349
11350         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11351         objfile->separate_debug_objfile_backlink if not NULL.
11352
11353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11354
11355         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11356         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11357         (amd64bsd_store_inferior_registers): Likewise.
11358         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11359         Enable segment base registers.
11360         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11361         PT_GETFSBASE and PT_GETGSBASE.
11362         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11363         PT_SETGSBASE.
11364         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11365         segment base registers.
11366         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11367
11368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11369
11370         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11371         Update calls to i386_target_description to add 'segments'
11372         parameter.
11373         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11374         add segment base registers.
11375         * arch/i386.c (i386_create_target_description): Add 'segments'
11376         parameter to enable segment base registers.
11377         * arch/i386.h (i386_create_target_description): Likewise.
11378         * features/i386/32bit-segments.xml: New file.
11379         * features/i386/32bit-segments.c: Generate.
11380         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11381         call to i386_target_description to add 'segments' parameter.
11382         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11383         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11384         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11385         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11386         if feature is present.
11387         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11388         Add 'segments' parameter to call to i386_target_description.
11389         (i386_target_description): Add 'segments' parameter to enable
11390         segment base registers.
11391         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11392         to call to i386_target_description.
11393         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11394         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11395         Define I386_NUM_REGS.
11396         (i386_target_description): Add 'segments' parameter to enable
11397         segment base registers.
11398
11399 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11400
11401         PR/24325
11402         * source-cache.c: #undef open and close, to avoid unresolved
11403         externals during linking.
11404
11405 2019-03-12  Tom Tromey  <tromey@adacore.com>
11406
11407         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11408         const.  Add initializers.
11409         (_initialize_remote): Don't initialize ptid globals.
11410
11411 2019-03-12  Pedro Alves  <palves@redhat.com>
11412
11413         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11414
11415 2019-03-12  Pedro Alves  <palves@redhat.com>
11416
11417         * cp-name-parser.y (main): Remove unused 'len' variable.
11418
11419 2019-03-12  Tom Tromey  <tromey@adacore.com>
11420
11421         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11422         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11423
11424 2019-03-12  Tom Tromey  <tromey@adacore.com>
11425
11426         * linux-nat.c (iterate_over_lwps): Update.
11427         (stop_callback): Remove parameter.
11428         (stop_wait_callback, detach_callback, resume_set_callback)
11429         (select_singlestep_lwp_callback, set_ignore_sigint)
11430         (status_callback, resumed_callback, resume_clear_callback)
11431         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11432         data parameter.
11433         (linux_nat_target::detach, linux_nat_target::resume)
11434         (linux_stop_and_wait_all_lwps, select_event_lwp)
11435         (linux_nat_filter_event, linux_nat_wait_1)
11436         (linux_nat_target::kill, linux_nat_target::stop)
11437         (linux_nat_target::stop): Update.
11438         (linux_nat_resume_callback): Change type.
11439         (resume_stopped_resumed_lwps, count_events_callback)
11440         (select_event_lwp_callback): Likewise.
11441         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11442         * arm-linux-nat.c (struct update_registers_data): Remove.
11443         (update_registers_callback): Change type.
11444         (arm_linux_insert_hw_breakpoint1): Update.
11445         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11446         parameter.
11447         (x86_linux_dr_set_addr): Update.
11448         (x86_linux_dr_set_control): Update.
11449         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11450         (iterate_over_lwps): Use gdb::function_view.
11451         * nat/aarch64-linux-hw-point.c (struct
11452         aarch64_dr_update_callback_param): Remove.
11453         (debug_reg_change_callback): Change type.
11454         (aarch64_notify_debug_reg_change): Update.
11455         * s390-linux-nat.c (s390_refresh_per_info): Update.
11456
11457 2019-03-11  Tom Tromey  <tromey@adacore.com>
11458
11459         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11460         redundant assignment to "this_cu".
11461
11462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11463
11464         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11465
11466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11467
11468         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11469         from...
11470         (rank_one_type): ... this.
11471
11472 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11473
11474         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11475         from...
11476         (rank_one_type): ... this.
11477
11478 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11479
11480         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11481         from...
11482         (rank_one_type): ... this.
11483
11484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11485
11486         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11487         from...
11488         (rank_one_type): ... this.
11489
11490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11491
11492         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11493         from...
11494         (rank_one_type): ... this.
11495
11496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11497
11498         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11499         from...
11500         (rank_one_type): ... this.
11501
11502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11503
11504         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11505         from...
11506         (rank_one_type): ... this.
11507
11508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11509
11510         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11511         from...
11512         (rank_one_type): ... this.
11513
11514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11515
11516         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11517         from...
11518         (rank_one_type): ... this.
11519
11520 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11521
11522         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11523         from...
11524         (rank_one_type): ... this.
11525
11526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11527
11528         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11529         from...
11530         (rank_one_type): ... this.
11531
11532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11533
11534         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11535         from...
11536         (rank_one_type): ... this.
11537
11538 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11539
11540         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11541         inferior-events' shows the example events.
11542
11543 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11544
11545         Support styling on native MS-Windows console
11546
11547         PR/24315
11548         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11549         on MS-Windows if $TERM is not defined.
11550
11551         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11552
11553         * posix-hdep.c (gdb_console_fputs):
11554         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11555         functions.
11556         * ui-file.h (gdb_console_fputs): Add prototype.
11557
11558         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11559         back to fputs only if the former returns zero.
11560
11561 2019-03-07  Tom Tromey  <tom@tromey.com>
11562
11563         * symmisc.c (print_symbol_bcache_statistics): Update.
11564         (print_objfile_statistics): Update.
11565         * symfile.c (allocate_symtab): Update.
11566         * stabsread.c: Don't include bcache.h.
11567         * psymtab.h (struct psymbol_bcache): Don't declare.
11568         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11569         (psymbol_bcache_init, psymbol_bcache_free)
11570         (psymbol_bcache_get_bcache): Don't declare.
11571         * psymtab.c (struct psymbol_bcache): Remove.
11572         (psymtab_storage::psymtab_storage): Update.
11573         (psymtab_storage::~psymtab_storage): Update.
11574         (psymbol_bcache_init, psymbol_bcache_free)
11575         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11576         (add_psymbol_to_bcache): Update.
11577         (allocate_psymtab): Update.
11578         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11579         macro_cache>: No longer pointers.
11580         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11581         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11582         * macrotab.c (macro_bcache): Update.
11583         * macroexp.c: Don't include bcache.h.
11584         * gdbtypes.c (check_types_worklist): Update.
11585         (types_deeply_equal): Remove TRY/CATCH.  Update.
11586         * elfread.c (elf_symtab_read): Update.
11587         * dwarf2read.c: Don't include bcache.h.
11588         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11589         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11590         (print_bcache_statistics, bcache_memory_used): Don't declare.
11591         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11592         methods.  Rename all data members.
11593         * bcache.c (struct bcache): Move to bcache.h.
11594         (bcache::expand_hash_table): Rename from expand_hash_table.
11595         (bcache): Remove.
11596         (bcache::insert): Rename from bcache_full.
11597         (bcache::compare): Rename from bcache_compare.
11598         (bcache_xmalloc): Remove.
11599         (bcache::~bcache): Rename from bcache_xfree.
11600         (bcache::print_statistics): Rename from print_bcache_statistics.
11601         (bcache::memory_used): Rename from bcache_memory_used.
11602
11603 2019-03-07  Pedro Alves  <palves@redhat.com>
11604
11605         * infrun.c (normal_stop): Also check for
11606         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11607
11608 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11609
11610         * f-lang.c (value_from_host_double): Moved to...
11611         * value.c (value_from_host_double): ...here.
11612         * value.h (value_from_host_double): Declare.
11613         * guile/scm-math.c (vlscm_convert_typed_number): Use
11614         value_from_host_double.
11615         (vlscm_convert_number): Likewise.
11616         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11617         * python/py-value.c (convert_value_from_python): Likewise.
11618
11619 2019-03-06  Tom Tromey  <tom@tromey.com>
11620
11621         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11622
11623 2019-03-06  Tom Tromey  <tom@tromey.com>
11624
11625         * utils.h (free_current_contents): Don't declare.
11626         * utils.c (free_current_contents): Remove.
11627
11628 2019-03-06  Tom Tromey  <tom@tromey.com>
11629
11630         * top.c (quit_force): Update.
11631         * main.c (captured_command_loop): Update.
11632         * common/new-op.c (operator new): Update.
11633         * common/common-exceptions.c (struct catcher)
11634         <save_cleanup_chain>: Remove member.
11635         (exceptions_state_mc_init): Update.
11636         (exception_try_scope_entry): Return nullptr.
11637         (exception_try_scope_exit, exception_rethrow)
11638         (throw_exception_sjlj, throw_exception_cxx): Update.
11639         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11640         (all_cleanups, do_cleanups, discard_cleanups)
11641         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11642         (restore_cleanups, restore_final_cleanups): Don't declare.
11643         (do_final_cleanups): Remove parameter.
11644         * common/cleanups.c (cleanup_chain, make_cleanup)
11645         (make_cleanup_dtor, all_cleanups, do_cleanups)
11646         (discard_my_cleanups, discard_cleanups)
11647         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11648         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11649         (null_cleanup): Remove.
11650         (do_final_cleanups): Remove parameter.
11651
11652 2019-03-06  Tom Tromey  <tom@tromey.com>
11653
11654         * remote.c (remote_target::remote_parse_stop_reply): Use
11655         unique_xmalloc_ptr.
11656
11657 2019-03-06  Tom Tromey  <tom@tromey.com>
11658
11659         * stabsread.c (struct stabs_field_info): Rename from field_info.
11660         <list, fnlist>: Add initializers.
11661         <obstack>: New member.
11662         (read_member_functions, read_struct_fields, read_baseclasses):
11663         Allocate on obstack.  Don't use cleanups.
11664         (read_one_struct_field, read_member_functions, read_struct_fields)
11665         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11666         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11667         (read_struct_type): Update.
11668
11669 2019-03-06  Tom Tromey  <tom@tromey.com>
11670
11671         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11672         * common/filestuff.h (make_cleanup_close): Don't declare.
11673         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11674         Remove.
11675
11676 2019-03-06  Tom Tromey  <tom@tromey.com>
11677
11678         * solib-aix.c: Use make_scope_exit.
11679
11680 2019-03-06  Tom Tromey  <tom@tromey.com>
11681
11682         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11683         Use make_scope_exit.
11684
11685 2019-03-06  Tom Tromey  <tom@tromey.com>
11686
11687         * solib-svr4.c (disable_probes_interface): Remove parameter.
11688         (svr4_handle_solib_event): Use make_scope_exit.
11689
11690 2019-03-06  Tom Tromey  <tom@tromey.com>
11691
11692         * remote.c (struct stop_reply_deleter): Remove.
11693         (stop_reply_up): Update.
11694         (struct stop_reply): Derive from notif_event.  Don't typedef.
11695         <regcache>: Now a std::vector.
11696         (stop_reply_xfree): Remove.
11697         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11698         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11699         (remote_target::discard_pending_stop_replies): Use delete.
11700         (remote_target::remote_parse_stop_reply): Update.
11701         (remote_target::process_stop_reply): Update.
11702         * remote-notif.h (struct notif_event): Add virtual destructor.
11703         Remove "dtr" member.
11704         (struct notif_client) <alloc_event>: Return a unique_ptr.
11705         (notif_event_xfree): Don't declare.
11706         (notif_event_up): New typedef.
11707         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11708         (notif_event_xfree, do_notif_event_xfree): Remove.
11709         (remote_notif_state_xfree): Update.
11710
11711 2019-03-06  Tom Tromey  <tom@tromey.com>
11712
11713         * infrun.c (displaced_step_clear_cleanup): Now a
11714         forward_scope_exit type.
11715         (displaced_step_prepare_throw): Update.
11716         (displaced_step_fixup): Update.
11717
11718 2019-03-06  Tom Tromey  <tom@tromey.com>
11719
11720         * inferior.h (class inferior): Update comment.
11721         * gdbthread.h (class thread_info): Update comment.
11722
11723 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11724             Tom Tromey  <tom@tromey.com>
11725
11726         * stabsread.h (struct stab_section_list): Remove.
11727         (coffstab_build_psymtabs): Update.
11728         * dbxread.c (symbuf_sections): Now a std::vector.
11729         (sect_idx): New global.
11730         (fill_symbuf): Update.
11731         (coffstab_build_psymtabs): Change type of stabsects parameter.
11732         Update.
11733         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11734         std::vector.
11735         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11736         (coff_locate_sections): Update.
11737         (coff_symfile_read): Remove cleanups.  Update.
11738         (init_stringtab): Add storage parameter.
11739         (free_stringtab, free_stringtab_cleanup): Remove.
11740         (init_lineno): Add storage parameter.
11741         (free_linetab, free_linetab_cleanup): Remove.
11742
11743 2019-03-06  Pedro Alves  <palves@redhat.com>
11744
11745         * linux-fork.c (fork_info::clobber_regs): Delete.
11746         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11747         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11748         comment.  Adjust.
11749         (scoped_switch_fork_info::scoped_switch_fork_info)
11750         (checkpoint_command, linux_fork_context): Adjust
11751         fork_save_infrun_state calls.
11752
11753 2019-03-06  Pedro Alves  <palves@redhat.com>
11754
11755         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11756         (inf_has_multiple_threads): Return 'bool' and rewrite using
11757         inferior_info::threads().
11758
11759 2019-03-06  Pedro Alves  <palves@redhat.com>
11760
11761         * linux-fork.c: Include <list>.
11762         (fork_list): Now a std::list instance.
11763         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11764         (forks_exist_p, find_last_fork): Adjust.
11765         (new_fork): Delete.
11766         (one_fork_p): New.
11767         (add_fork): Adjust.
11768         (free_fork): Delete, folded into fork_info::~fork_info().
11769         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11770         Adjust.
11771         (init_fork_list): Delete.
11772         (linux_fork_killall, linux_fork_mourn_inferior)
11773         (linux_fork_detach, info_checkpoints_command): Adjust.
11774         (_initialize_linux_fork): No longer call init_fork_list.
11775
11776 2019-03-06  Pedro Alves  <palves@redhat.com>
11777
11778         * linux-fork.c (new_fork): New, split out of ...
11779         (add_fork): ... this.  Return void.  Move "first fork" special
11780         case from here, to ...
11781         (checkpoint_command): ... here.
11782         * linux-linux.h (add_fork): Return void.
11783
11784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11785
11786         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11787
11788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11789             Chris January  <chris.january@arm.com>
11790             David Lecomber  <david.lecomber@arm.com>
11791
11792         * f-exp.y: New token, UNOP_INTRINSIC.
11793         (exp): New pattern using UNOP_INTRINSIC token.
11794         (f77_keywords): Add 'abs' keyword.
11795         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11796         (value_from_host_double): New function.
11797         (evaluate_subexp_f): Support UNOP_ABS.
11798
11799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11800
11801         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11802         types.
11803
11804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11805
11806         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11807         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11808         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11809
11810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11811
11812         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11813
11814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11815             Chris January  <chris.january@arm.com>
11816
11817         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11818         * f-exp.y: Define 'KIND' token.
11819         (exp): New pattern for KIND expressions.
11820         (ptype): Handle types with a kind extension.
11821         (direct_abs_decl): Extend to spot kind extensions.
11822         (f77_keywords): Add 'kind' to the list.
11823         (push_kind_type): New function.
11824         (convert_to_kind_type): New function.
11825         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11826         * parse.c (operator_length_standard): Likewise.
11827         * parser-defs.h (enum type_pieces): Add tp_kind.
11828         * std-operator.def: Add UNOP_KIND.
11829
11830 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11831
11832         * f-exp.y (f_parse): Set yydebug.
11833
11834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11835
11836         * f-lang.c (evaluate_subexp_f): New function.
11837         (exp_descriptor_f): New global.
11838         (f_language_defn): Use exp_descriptor_f instead of
11839         exp_descriptor_standard.
11840
11841 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * f-exp.y (struct token): Add comments.
11844         (dot_ops): Remove uppercase versions and the end marker.
11845         (f77_keywords): Likewise.
11846         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11847         entries in the dot_ops array are case insensitive, and use
11848         strncasecmp to compare strings.  Also some whitespace cleanup in
11849         this area.  Similar for the f77_keywords array, except entries in
11850         this list might be case sensitive.
11851
11852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11853
11854         * f-exp.y (struct f77_boolean_val): Add comments.
11855         (boolean_values): Remove uppercase versions, and end marker.
11856         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11857         and use strncasecmp to achieve case insensitivity.  Additionally,
11858         perform whitespace cleanup around this code.
11859
11860 2019-03-06  Tom Tromey  <tromey@adacore.com>
11861
11862         * remote-sim.c (gdbsim_target_open): Use result of
11863         gdb_argv::release.
11864
11865 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11866         Dirk Schubert  <dirk.schubert@arm.com>
11867         Chris January  <chris.january@arm.com>
11868
11869         * eval.c (evaluate_subexp_standard): Call Fortran argument
11870         wrapping logic.
11871         * f-lang.c (struct value): A value which can be passed into a
11872         Fortran function call.
11873         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11874         where appropriate.
11875         (struct type): Value ready for a Fortran function call.
11876         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11877         is needed.
11878         * f-lang.h (fortran_argument_convert): Declaration.
11879         (fortran_preserve_arg_pointer): Declaration.
11880         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11881
11882 2019-03-05  Tom Tromey  <tromey@adacore.com>
11883
11884         * python/py-prettyprint.c (print_string_repr): Remove #if.
11885         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11886
11887 2019-03-05  Tom Tromey  <tromey@adacore.com>
11888
11889         * target.c (the_dummy_target): Move later.  Change type to
11890         "dummy_target".
11891         (initialize_targets): Don't initialize the_dummy_target.
11892
11893 2019-03-05  Tom Tromey  <tromey@adacore.com>
11894
11895         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11896         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11897
11898 2019-03-05  Tom Tromey  <tromey@adacore.com>
11899
11900         * windows-nat.c (windows_nat_target::attach)
11901         (windows_nat_target::detach): Don't call gdb_flush.
11902         * valprint.c (generic_val_print, val_print, val_print_string):
11903         Don't call gdb_flush.
11904         * utils.c (defaulted_query): Don't call gdb_flush.
11905         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11906         * target.c (target_announce_detach): Don't call gdb_flush.
11907         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11908         * remote.c (extended_remote_target::attach): Don't call
11909         gdb_flush.
11910         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11911         * printcmd.c (do_examine): Don't call gdb_flush.
11912         (info_display_command): Don't call gdb_flush.
11913         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11914         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11915         * memattr.c (info_mem_command): Don't call gdb_flush.
11916         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11917         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11918         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11919         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11920         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11921         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11922         (gnu_nat_target::detach): Don't call gdb_flush.
11923         * f-valprint.c (f_val_print): Don't call gdb_flush.
11924         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11925         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11926         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11927         gdb_flush.
11928         * c-valprint.c (c_val_print): Don't call gdb_flush.
11929         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11930
11931 2019-03-05  Tom Tromey  <tromey@adacore.com>
11932
11933         * varobj.c (update_dynamic_varobj_children): Update.
11934         (install_default_visualizer): Use reset, not release.
11935         * value.c (set_internalvar): Update.
11936         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11937         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11938         ATTRIBUTE_UNUSED_RESULT.
11939
11940 2019-03-05  Tom Tromey  <tromey@adacore.com>
11941
11942         * remote.c (class scoped_remote_fd) <release>: Add
11943         ATTRIBUTE_UNUSED_RESULT.
11944
11945 2019-03-05  Tom Tromey  <tromey@adacore.com>
11946
11947         * macroexp.c (struct macro_buffer) <release>: Add
11948         ATTRIBUTE_UNUSED_RESULT.
11949
11950 2019-03-05  Tom Tromey  <tromey@adacore.com>
11951
11952         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11953         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11954         ATTRIBUTE_UNUSED_RESULT.
11955
11956 2019-03-05  Tom Tromey  <tromey@adacore.com>
11957
11958         * common/scoped_fd.h (class scoped_fd) <release>: Add
11959         ATTRIBUTE_UNUSED_RESULT.
11960
11961 2019-03-05  Tom Tromey  <tromey@adacore.com>
11962
11963         * parser-defs.h (struct parser_state) <release>: Add
11964         ATTRIBUTE_UNUSED_RESULT.
11965
11966 2019-03-05  Tom Tromey  <tromey@adacore.com>
11967
11968         * utils.h (class gdb_argv) <release>: Add
11969         ATTRIBUTE_UNUSED_RESULT.
11970         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11971
11972 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11973
11974         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11975         for-loop range, to avoid compiler warnings.
11976
11977         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11978         avoid compiler warnings about unused variables.
11979
11980         * NEWS: Mention end of support for native debugging on MS-Windows
11981         before XP.
11982
11983         PR gdb/24292
11984         * common/netstuff.c:
11985         * gdbserver/gdbreplay.c
11986         * gdbserver/remote-utils.c:
11987         * ser-tcp.c:
11988         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11989         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11990         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11991         'getaddrinfo' and 'freeaddrinfo' were not available before
11992         Windows XP, and mingw.org's MinGW headers by default define
11993         _WIN32_WINNT to 0x500.
11994
11995 2019-03-01  Gary Benson <gbenson@redhat.com>
11996
11997         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11998
11999 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12000             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12001
12002         PR gdb/8527
12003         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12004         set_sigint_trap, clear_sigint_trap.
12005
12006 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12007
12008         * target.c (target_detach): Clear the regcache and the
12009         frame cache.
12010
12011 2019-02-27  Pedro Alves  <palves@redhat.com>
12012
12013         * utils.c (set_screen_size): When we cap the height/width sizes,
12014         tweak the corresponding command variable to show "unlimited":
12015
12016 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12017             Pedro Alves  <palves@redhat.com>
12018
12019         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12020         before calling rl_set_screen_size.
12021
12022 2019-02-27  Tom Tromey  <tromey@adacore.com>
12023
12024         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12025         define.
12026         * python/py-value.c: Remove Python 2.4 workaround.
12027         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12028         workaround.
12029         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12030         Python 2.4 workaround.
12031         * python/python-internal.h: Remove Python 2.4 comment.
12032         (Py_ssize_t): Don't define.
12033         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12034         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12035         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12036         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12037         * python/python.c (do_start_initialization): Remove Python 2.4
12038         workaround.
12039         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12040         (print_children): Remove Python 2.4 workaround.
12041         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12042         workaround.
12043         (CHARBUFFERPROC_NAME): Remove.
12044         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12045         Python 2.4 workaround.
12046
12047 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12048
12049         * NEWS: Note minimum Python version.
12050
12051 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12052
12053         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12054         code from these functions.  Remove corresponding ifdefs.  Use
12055         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12056         Remove gotos and target of gotos.
12057         (infpy_search_memory): Likewise.
12058
12059 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12060
12061         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12062         (hppa_gdbarch_init): Don't register deleted functions with
12063         gdbarch.
12064
12065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12066
12067         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12068         (h8300_unwind_sp): Delete.
12069         (h8300_dummy_id): Delete.
12070         (h8300_gdbarch_init): Don't register deleted functions with
12071         gdbarch.
12072
12073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12074
12075         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12076         (ft32_unwind_pc): Delete.
12077         (ft32_unwind_sp): Delete.
12078         (ft32_gdbarch_init): Don't register deleted functions with
12079         gdbarch.
12080
12081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12082
12083         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12084         (frv_unwind_pc): Delete.
12085         (frv_unwind_sp): Delete.
12086         (frv_gdbarch_init): Don't register deleted functions with
12087         gdbarch.
12088
12089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12090
12091         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12092         (riscv_unwind_pc): Delete.
12093         (riscv_unwind_sp): Delete.
12094         (riscv_gdbarch_init): Don't register deleted functions with
12095         gdbarch.
12096
12097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12098
12099         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12100         (csky_unwind_pc): Delete.
12101         (csky_unwind_sp): Delete.
12102         (csky_gdbarch_init): Don't register deleted functions with
12103         gdbarch.
12104
12105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12106
12107         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12108         (cris_unwind_pc): Delete.
12109         (cris_unwind_sp): Delete.
12110         (cris_gdbarch_init): Don't register deleted functions with
12111         gdbarch.
12112
12113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12114
12115         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12116         (bfin_unwind_pc): Delete.
12117         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12118
12119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12120
12121         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12122         (arm_unwind_pc): Delete.
12123         (arm_unwind_sp): Delete.
12124         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12125
12126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12127
12128         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12129         (arc_unwind_pc): Delete.
12130         (arc_unwind_sp): Delete.
12131         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12132
12133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12134
12135         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12136         (alpha_unwind_pc): Delete.
12137         (alpha_gdbarch_init): Don't register deleted functions with
12138         gdbarch.
12139
12140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12141
12142         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12143         (aarch64_unwind_pc): Delete.
12144         (aarch64_unwind_sp): Delete.
12145         (aarch64_gdbarch_init): Don't register deleted functions with
12146         gdbarch.
12147
12148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12149
12150         * gdbtypes.c (type_align): Don't consider static members when
12151         computing structure alignment.
12152
12153 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12154
12155         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12156         return 0 for other types.
12157         * arch-utils.c (default_type_align): Always return 0.
12158         * gdbarch.h: Regenerate.
12159         * gdbarch.sh (type_align): Extend comment.
12160         * gdbtypes.c (type_align): Add additional comments, always call
12161         gdbarch_type_align before applying the default rules.
12162         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12163         generic code will then apply a suitable default.
12164         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12165         types, return 0 for other types.
12166
12167 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12168
12169         * NEWS: Create a new section for the next release branch.
12170         Rename the section of the current branch, now that it has
12171         been cut.
12172
12173 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12174
12175         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12176         * version.in: Bump version to 8.3.50.DATE-git.
12177
12178 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12179
12180         * aix-thread.c (ptid_cmp): Remove unused variable.
12181         (get_signaled_thread): Likewise.
12182         (store_regs_user_thread): Likewise.
12183         (store_regs_kernel_thread): Likewise.
12184         (fetch_regs_kernel_thread): Remove shadowed variable.
12185
12186 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12187
12188         * features/riscv/32bit-cpu.xml: Add register numbers.
12189         * features/riscv/32bit-fpu.c: Regenerate.
12190         * features/riscv/32bit-fpu.xml: Add register numbers.
12191         * features/riscv/64bit-cpu.xml: Add register numbers.
12192         * features/riscv/64bit-fpu.c: Regenerate.
12193         * features/riscv/64bit-fpu.xml: Add register numbers.
12194
12195 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12196
12197         * NEWS: Mention two argument form of gdb.Value constructor.
12198         * python/py-value.c (convert_buffer_and_type_to_value): New
12199         function.
12200         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12201         Add support for handling an optional second argument.  Call
12202         convert_buffer_and_type_to_value as appropriate.
12203         * python/python-internal.h (Py_buffer_deleter): New struct.
12204         (Py_buffer_up): New typedef.
12205
12206 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12207
12208         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12209         instead of releasing ownership.
12210
12211 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12212
12213         * dwarf2read.c (open_and_init_dwp_file): Call
12214         elf_numsections instead of bfd_count_sections to initialize
12215         dwp_file->num_sections.
12216
12217 2019-02-25  Tom Tromey  <tromey@adacore.com>
12218
12219         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12220
12221 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12222
12223         * gcore.in: Add '--readnever' option when invoking GDB.
12224
12225 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12226
12227         * MAINTAINERS: Update my email address.
12228
12229 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12230
12231         * build-id.c (build_id_to_debug_bfd_1): New function.
12232         (build_id_to_debug_bfd): Look for separate debug file in
12233         sysroot.
12234
12235 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12236
12237         * gdbarch.sh: Update the copyright year range that is placed into
12238         generated files.
12239
12240 2019-02-22  Keith Seitz  <keiths@redhat.com>
12241
12242         PR symtab/23853
12243         * linespec.c (create_sals_line_offset): Search for the default
12244         symtab's filename instead of its fullname.
12245
12246 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12247
12248         * NEWS: Update style defaults.
12249
12250 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12251
12252         * main.c (captured_main_1): Disable styling in batch mode.
12253
12254 2019-02-20  Tom Tromey  <tom@tromey.com>
12255
12256         * symtab.c (symtab_symbol_info): Fix typos.
12257
12258 2019-02-20  Tom Tromey  <tromey@adacore.com>
12259
12260         * findcmd.c (_initialize_mem_search): Use upper case for
12261         metasyntactic variables.
12262
12263 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12264
12265         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12266         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12267
12268 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12269
12270         * top.h (source_file_name): Change to std::string.
12271         * top.c (source_file_name): Likewise.
12272         (command_line_input): Adjust.
12273         * cli/cli-script.c (script_from_file): Adjust.
12274
12275 2019-02-19  Tom Tromey  <tromey@adacore.com>
12276
12277         * ravenscar-thread.c
12278         (ravenscar_thread_target::update_thread_list): Don't call
12279         ada_build_task_list.
12280         * ada-lang.h (ada_build_task_list): Don't declare.
12281         * ada-tasks.c (struct ada_tasks_inferior_data)
12282         <task_list_valid_p>: Now bool.
12283         (read_known_tasks, ada_task_list_changed)
12284         (ada_tasks_invalidate_inferior_data): Update.
12285         (read_known_tasks_array): Return bool.
12286         (read_known_tasks_list): Likewise.
12287         (read_known_tasks): Return void.
12288         (ada_build_task_list): Now static.
12289
12290 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12291
12292         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12293         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12294
12295 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12296
12297         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12298         variant for ada_tasks_pspace_data_handle and
12299         ada_tasks_inferior_data_handle.
12300         (ada_tasks_pspace_data_cleanup): New function.
12301         (ada_tasks_inferior_data_cleanup): New function.
12302
12303 2019-02-17  Tom Tromey  <tom@tromey.com>
12304
12305         * macrotab.h (macro_source_fullname): Return a std::string.
12306         * macrotab.c (macro_include, check_for_redefinition)
12307         (macro_undef, macro_lookup_definition, foreach_macro)
12308         (foreach_macro_in_scope): Update.
12309         (macro_source_fullname): Return a std::string.
12310         * macrocmd.c (show_pp_source_pos): Update.
12311
12312 2019-02-17  Tom Tromey  <tom@tromey.com>
12313
12314         * macrocmd.c (show_pp_source_pos): Style the file names.
12315
12316 2019-02-17  Tom Tromey  <tom@tromey.com>
12317
12318         PR tui/24197:
12319         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12320
12321 2019-02-17  Tom Tromey  <tom@tromey.com>
12322
12323         * ada-lang.c (user_select_syms): Use filtered printing.
12324         * utils.c (wrap_style): New global.
12325         (desired_style): Remove.
12326         (emit_style_escape): Add stream parameter.
12327         (set_output_style, reset_terminal_style, prompt_for_continue):
12328         Update.
12329         (flush_wrap_buffer): Only flush gdb_stdout.
12330         (wrap_here): Set wrap_style.
12331         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12332         treat escape sequences as a character.  Change when wrap buffer is
12333         flushed.
12334         (fputs_styled): Do not set the output style when the default is
12335         requested.
12336         * ui-style.h (struct ui_file_style) <is_default>: New method.
12337         * source.c (print_source_lines_base): Emit escape sequences in one
12338         piece.
12339
12340 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12341
12342         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12343         integers and enumeration types.
12344
12345 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12346
12347         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12348         instead of lookup_symbol_in_language
12349         (do_exact_match): New function.
12350         (ada_get_symbol_name_matcher): Return do_exact_match when
12351         doing a verbatim match.
12352
12353 2019-02-15  Tom Tromey  <tromey@adacore.com>
12354
12355         * ravenscar-thread.c (ravenscar_thread_target::resume)
12356         (ravenscar_thread_target::wait): Special case wildcard requests.
12357
12358 2019-02-15  Tom Tromey  <tromey@adacore.com>
12359
12360         * ravenscar-thread.c (base_ptid): Remove.
12361         (struct ravenscar_thread_target) <close>: New method.
12362         <m_base_ptid>: New member.
12363         <update_inferior_ptid, active_task, task_is_currently_active,
12364         runtime_initialized>: Declare methods.
12365         <ravenscar_thread_target>: Add constructor.
12366         (ravenscar_thread_target::task_is_currently_active)
12367         (ravenscar_thread_target::update_inferior_ptid)
12368         (ravenscar_runtime_initialized): Rename.  Now methods.
12369         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12370         (ravenscar_thread_target::update_thread_list): Update.
12371         (ravenscar_thread_target::active_task): Now method.
12372         (ravenscar_thread_target::store_registers)
12373         (ravenscar_thread_target::prepare_to_store)
12374         (ravenscar_thread_target::prepare_to_store)
12375         (ravenscar_thread_target::mourn_inferior): Update.
12376         (ravenscar_inferior_created): Use "new" to create target.
12377         (ravenscar_thread_target::get_ada_task_ptid): Update.
12378         (_initialize_ravenscar): Don't initialize base_ptid.
12379         (ravenscar_ops): Remove global.
12380
12381 2019-02-15  Tom Tromey  <tromey@adacore.com>
12382
12383         * target.h (push_target): Declare new overload.
12384         * target.c (push_target): New overload, taking an rvalue reference.
12385         * remote.c (remote_target::open_1): Use push_target overload.
12386         * corelow.c (core_target_open): Use push_target overload.
12387
12388 2019-02-15  Tom Tromey  <tromey@adacore.com>
12389
12390         * ravenscar-thread.c (is_ravenscar_task)
12391         (ravenscar_task_is_currently_active): Return bool.
12392         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12393         (_initialize_ravenscar): Remove "(void)".
12394         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12395         Return bool.
12396
12397 2019-02-15  Tom Tromey  <tromey@adacore.com>
12398
12399         * ravenscar-thread.c (ravenscar_runtime_initializer)
12400         (has_ravenscar_runtime, get_running_thread_id)
12401         (ravenscar_thread_target::resume): Fix indentation.
12402
12403 2019-02-15  Tom Tromey  <tromey@adacore.com>
12404
12405         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12406         from ravenscar_arch_ops.
12407         (sparc_ravenscar_ops::fetch_registers)
12408         (sparc_ravenscar_ops::store_registers): Now methods.
12409         (sparc_ravenscar_prepare_to_store): Remove.
12410         (sparc_ravenscar_ops): Redefine.
12411         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12412         methods and destructor.  Remove members.
12413         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12414         (ravenscar_thread_target::store_registers)
12415         (ravenscar_thread_target::prepare_to_store): Update.
12416         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12417         Remove.
12418         (struct ppc_ravenscar_powerpc_ops): Derive from
12419         ravenscar_arch_ops.
12420         (ppc_ravenscar_powerpc_ops::fetch_registers)
12421         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12422         (ppc_ravenscar_powerpc_ops): Redefine.
12423         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12424         (ppc_ravenscar_e500_ops::fetch_registers)
12425         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12426         (ppc_ravenscar_e500_ops): Redefine.
12427         * aarch64-ravenscar-thread.c
12428         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12429         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12430         (aarch64_ravenscar_fetch_registers)
12431         (aarch64_ravenscar_store_registers): Now methods.
12432         (aarch64_ravenscar_ops): Redefine.
12433
12434 2019-02-15  Tom Tromey  <tromey@adacore.com>
12435
12436         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12437         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12438         (ravenscar_thread_target::stopped_by_watchpoint)
12439         (ravenscar_thread_target::stopped_data_address)
12440         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12441
12442 2019-02-15  Tom Tromey  <tromey@adacore.com>
12443
12444         * ravenscar-thread.c: Fix some typos.
12445
12446 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12447             Tom Tromey  <tromey@adacore.com>
12448
12449         * ada-lang.c (ada_exception_sal): Change addr_string to a
12450         std::string.
12451         (create_ada_exception_catchpoint): Update.
12452
12453 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12454             Tom Tromey  <tromey@adacore.com>
12455
12456         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12457         (bp_location_ops): Remove.
12458         (base_breakpoint_allocate_location): Update.
12459         (free_bp_location): Update.
12460         * ada-lang.c (class ada_catchpoint_location)
12461         <ada_catchpoint_location>: Remove ops parameter.
12462         (ada_catchpoint_location_dtor): Remove.
12463         (ada_catchpoint_location_ops): Remove.
12464         (allocate_location_exception): Update.
12465         * breakpoint.h (struct bp_location_ops): Remove.
12466         (class bp_location) <bp_location>: Remove bp_location_ops
12467         parameter.
12468         <~bp_location>: Add destructor.
12469         <ops>: Remove.
12470
12471 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12472             Pedro Alves  <palves@redhat.com>
12473
12474         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12475         'PATH_MAX'.
12476
12477 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12478             Samuel Thibault  <samuel.thibault@gnu.org>
12479             Thomas Schwinge  <thomas@codesourcery.com>
12480
12481         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12482         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12483
12484 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12485
12486         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12487         (check_empty): Use "const char *".
12488
12489         * gnu-nat.c (gnu_nat_target::detach): Instead of
12490         'detach_inferior (pid)' call
12491         'detach_inferior (find_inferior_pid (pid))'.
12492
12493         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12494         'nat/fork-inferior.o'.
12495         * gnu-nat.c: #include "nat/fork-inferior.h".
12496
12497         * gnu-nat.c (gnu_nat_target::detach): Instead of
12498         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12499         * gnu-nat.h: #include "inf-child.h".
12500         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12501         'i386_gnu_nat_target::fetch_registers'.
12502         (gnu_store_registers): Rename/move to
12503         'i386_gnu_nat_target::store_registers'.
12504
12505         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12506         * gnu-nat.h (mach_thread_info): New function.
12507         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12508
12509         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12510
12511 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12512
12513         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12514
12515 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12516
12517         * windows-nat.c (windows_add_thread): Add new parameter
12518         "main_thread_p" with default value set to false.  Update
12519         function documentation as well as all callers.
12520         (windows_delete_thread): Likewise.
12521         (fake_create_process): Update call to windows_add_thread.
12522         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12523         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12524         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12525         call to windows_delete_thread.
12526
12527 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12528
12529         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12530
12531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12532
12533         * symfile.c (find_separate_debug_file): Use canonical path of
12534         sysroot with child_path instead of gdb_sysroot if it is valid.
12535
12536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12537
12538         * symfile.c (find_separate_debug_file): Use child_path to
12539         determine if an object file is under a sysroot.
12540
12541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12542
12543         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12544         unittests/child-path-selftests.c.
12545         * common/pathstuff.c (child_path): New function.
12546         * common/pathstuff.h (child_path): New prototype.
12547         * unittests/child-path-selftests.c: New file.
12548
12549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12550
12551         * symfile.c (find_separate_debug_file): Look for separate debug
12552         files in debug directories under the sysroot.
12553
12554 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12555
12556         * symtab.h (struct minimal_symbol data_p): New const method.
12557         (struct minimal_symbol text_p): Likewise.
12558         * symtab.c (output_source_filename): Use file name style
12559         to print file name.
12560         (print_symbol_info): Likewise.
12561         (print_msymbol_info): Use address style to print addresses.
12562         Use function name style to print executable text symbols.
12563         (expand_symtab_containing_pc): Use data_p.
12564         (find_pc_sect_compunit_symtab): Likewise.
12565
12566 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12567
12568         * breakpoint.c (describe_other_breakpoints): Use address style
12569         to print addresses.
12570         (say_where): Likewise.
12571
12572 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12573
12574         * ada-typeprint.c (print_func_type): Print function name
12575         style to print function name.
12576         * c-typeprint.c (c_print_type_1): Likewise.
12577
12578 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12579
12580         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12581         for execve.
12582
12583 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12584
12585         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12586         type_stack.
12587
12588 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12589
12590         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12591         TYPE_CODE_REF types.
12592
12593 2019-02-08  Jim Wilson  <jimw@sifive.com>
12594
12595         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12596         (riscv_linux_fregset): New.
12597         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12598
12599 2019-02-07  Tom Tromey  <tom@tromey.com>
12600
12601         * thread.c (thread_cancel_execution_command): Update.
12602         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12603         methods.
12604         (struct thread_fsm_ops): Remove.
12605         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12606         (thread_fsm_should_stop, thread_fsm_return_value)
12607         (thread_fsm_set_finished, thread_fsm_finished_p)
12608         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12609         Don't declare.
12610         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12611         * infrun.c (clear_proceed_status_thread)
12612         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12613         (print_stop_event): Update.
12614         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12615         Add constructor.
12616         (step_command_fsm_ops): Remove.
12617         (new_step_command_fsm): Remove.
12618         (step_1): Update.
12619         (step_command_fsm::should_stop): Rename from
12620         step_command_fsm_should_stop.
12621         (step_command_fsm::clean_up): Rename from
12622         step_command_fsm_clean_up.
12623         (step_command_fsm::do_async_reply_reason): Rename from
12624         step_command_fsm_async_reply_reason.
12625         (struct until_next_fsm): Inherit from thread_fsm.  Add
12626         constructor.
12627         (until_next_fsm_ops): Remove.
12628         (new_until_next_fsm): Remove.
12629         (until_next_fsm::should_stop): Rename from
12630         until_next_fsm_should_stop.
12631         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12632         (until_next_fsm::do_async_reply_reason): Rename from
12633         until_next_fsm_async_reply_reason.
12634         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12635         constructor.  Change type of breakpoint.
12636         (finish_command_fsm_ops): Remove.
12637         (new_finish_command_fsm): Remove.
12638         (finish_command_fsm::should_stop): Rename from
12639         finish_command_fsm_should_stop.
12640         (finish_command_fsm::clean_up): Rename from
12641         finish_command_fsm_clean_up.
12642         (finish_command_fsm::return_value): Rename from
12643         finish_command_fsm_return_value.
12644         (finish_command_fsm::do_async_reply_reason): Rename from
12645         finish_command_fsm_async_reply_reason.
12646         (finish_command): Update.
12647         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12648         Add constructor.
12649         (call_thread_fsm_ops): Remove.
12650         (call_thread_fsm::call_thread_fsm): Rename from
12651         new_call_thread_fsm.
12652         (call_thread_fsm::should_stop): Rename from
12653         call_thread_fsm_should_stop.
12654         (call_thread_fsm::should_notify_stop): Rename from
12655         call_thread_fsm_should_notify_stop.
12656         (run_inferior_call, call_function_by_hand_dummy): Update.
12657         * cli/cli-interp.c (should_print_stop_to_console): Update.
12658         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12659         Add constructor.  Change type of location_breakpoint,
12660         caller_breakpoint.
12661         (until_break_fsm_ops): Remove.
12662         (new_until_break_fsm): Remove.
12663         (until_break_fsm::should_stop): Rename from
12664         until_break_fsm_should_stop.
12665         (until_break_fsm::clean_up): Rename from
12666         until_break_fsm_clean_up.
12667         (until_break_fsm::do_async_reply_reason): Rename from
12668         until_break_fsm_async_reply_reason.
12669         (until_break_command): Update.
12670         * thread-fsm.c: Remove.
12671         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12672
12673 2019-02-07  Tom Tromey  <tom@tromey.com>
12674
12675         * yy-remap.h: Add include guard.
12676         * xtensa-tdep.h: Add include guard.
12677         * xcoffread.h: Rename include guard.
12678         * varobj-iter.h: Add include guard.
12679         * tui/tui.h: Rename include guard.
12680         * tui/tui-winsource.h: Rename include guard.
12681         * tui/tui-wingeneral.h: Rename include guard.
12682         * tui/tui-windata.h: Rename include guard.
12683         * tui/tui-win.h: Rename include guard.
12684         * tui/tui-stack.h: Rename include guard.
12685         * tui/tui-source.h: Rename include guard.
12686         * tui/tui-regs.h: Rename include guard.
12687         * tui/tui-out.h: Rename include guard.
12688         * tui/tui-layout.h: Rename include guard.
12689         * tui/tui-io.h: Rename include guard.
12690         * tui/tui-hooks.h: Rename include guard.
12691         * tui/tui-file.h: Rename include guard.
12692         * tui/tui-disasm.h: Rename include guard.
12693         * tui/tui-data.h: Rename include guard.
12694         * tui/tui-command.h: Rename include guard.
12695         * tic6x-tdep.h: Add include guard.
12696         * target/waitstatus.h: Rename include guard.
12697         * target/wait.h: Rename include guard.
12698         * target/target.h: Rename include guard.
12699         * target/resume.h: Rename include guard.
12700         * target-float.h: Rename include guard.
12701         * stabsread.h: Add include guard.
12702         * rs6000-tdep.h: Add include guard.
12703         * riscv-fbsd-tdep.h: Add include guard.
12704         * regformats/regdef.h: Rename include guard.
12705         * record.h: Rename include guard.
12706         * python/python.h: Rename include guard.
12707         * python/python-internal.h: Rename include guard.
12708         * python/py-stopevent.h: Rename include guard.
12709         * python/py-ref.h: Rename include guard.
12710         * python/py-record.h: Rename include guard.
12711         * python/py-record-full.h: Rename include guard.
12712         * python/py-record-btrace.h: Rename include guard.
12713         * python/py-instruction.h: Rename include guard.
12714         * python/py-events.h: Rename include guard.
12715         * python/py-event.h: Rename include guard.
12716         * procfs.h: Add include guard.
12717         * proc-utils.h: Add include guard.
12718         * p-lang.h: Add include guard.
12719         * or1k-tdep.h: Rename include guard.
12720         * observable.h: Rename include guard.
12721         * nto-tdep.h: Rename include guard.
12722         * nat/x86-linux.h: Rename include guard.
12723         * nat/x86-linux-dregs.h: Rename include guard.
12724         * nat/x86-gcc-cpuid.h: Add include guard.
12725         * nat/x86-dregs.h: Rename include guard.
12726         * nat/x86-cpuid.h: Rename include guard.
12727         * nat/ppc-linux.h: Rename include guard.
12728         * nat/mips-linux-watch.h: Rename include guard.
12729         * nat/linux-waitpid.h: Rename include guard.
12730         * nat/linux-ptrace.h: Rename include guard.
12731         * nat/linux-procfs.h: Rename include guard.
12732         * nat/linux-osdata.h: Rename include guard.
12733         * nat/linux-nat.h: Rename include guard.
12734         * nat/linux-namespaces.h: Rename include guard.
12735         * nat/linux-btrace.h: Rename include guard.
12736         * nat/glibc_thread_db.h: Rename include guard.
12737         * nat/gdb_thread_db.h: Rename include guard.
12738         * nat/gdb_ptrace.h: Rename include guard.
12739         * nat/fork-inferior.h: Rename include guard.
12740         * nat/amd64-linux-siginfo.h: Rename include guard.
12741         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12742         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12743         * nat/aarch64-linux.h: Rename include guard.
12744         * nat/aarch64-linux-hw-point.h: Rename include guard.
12745         * mn10300-tdep.h: Add include guard.
12746         * mips-linux-tdep.h: Add include guard.
12747         * mi/mi-parse.h: Rename include guard.
12748         * mi/mi-out.h: Rename include guard.
12749         * mi/mi-main.h: Rename include guard.
12750         * mi/mi-interp.h: Rename include guard.
12751         * mi/mi-getopt.h: Rename include guard.
12752         * mi/mi-console.h: Rename include guard.
12753         * mi/mi-common.h: Rename include guard.
12754         * mi/mi-cmds.h: Rename include guard.
12755         * mi/mi-cmd-break.h: Rename include guard.
12756         * m2-lang.h: Add include guard.
12757         * location.h: Rename include guard.
12758         * linux-record.h: Rename include guard.
12759         * linux-nat.h: Add include guard.
12760         * linux-fork.h: Add include guard.
12761         * i386-darwin-tdep.h: Rename include guard.
12762         * hppa-linux-offsets.h: Add include guard.
12763         * guile/guile.h: Rename include guard.
12764         * guile/guile-internal.h: Rename include guard.
12765         * gnu-nat.h: Rename include guard.
12766         * gdb-stabs.h: Rename include guard.
12767         * frv-tdep.h: Add include guard.
12768         * f-lang.h: Add include guard.
12769         * event-loop.h: Add include guard.
12770         * darwin-nat.h: Rename include guard.
12771         * cp-abi.h: Rename include guard.
12772         * config/sparc/nm-sol2.h: Rename include guard.
12773         * config/nm-nto.h: Rename include guard.
12774         * config/nm-linux.h: Add include guard.
12775         * config/i386/nm-i386gnu.h: Rename include guard.
12776         * config/djgpp/nl_types.h: Rename include guard.
12777         * config/djgpp/langinfo.h: Rename include guard.
12778         * compile/gcc-cp-plugin.h: Add include guard.
12779         * compile/gcc-c-plugin.h: Add include guard.
12780         * compile/compile.h: Rename include guard.
12781         * compile/compile-object-run.h: Rename include guard.
12782         * compile/compile-object-load.h: Rename include guard.
12783         * compile/compile-internal.h: Rename include guard.
12784         * compile/compile-cplus.h: Rename include guard.
12785         * compile/compile-c.h: Rename include guard.
12786         * common/xml-utils.h: Rename include guard.
12787         * common/x86-xstate.h: Rename include guard.
12788         * common/version.h: Rename include guard.
12789         * common/vec.h: Rename include guard.
12790         * common/tdesc.h: Rename include guard.
12791         * common/selftest.h: Rename include guard.
12792         * common/scoped_restore.h: Rename include guard.
12793         * common/scoped_mmap.h: Rename include guard.
12794         * common/scoped_fd.h: Rename include guard.
12795         * common/safe-iterator.h: Rename include guard.
12796         * common/run-time-clock.h: Rename include guard.
12797         * common/refcounted-object.h: Rename include guard.
12798         * common/queue.h: Rename include guard.
12799         * common/ptid.h: Rename include guard.
12800         * common/print-utils.h: Rename include guard.
12801         * common/preprocessor.h: Rename include guard.
12802         * common/pathstuff.h: Rename include guard.
12803         * common/observable.h: Rename include guard.
12804         * common/netstuff.h: Rename include guard.
12805         * common/job-control.h: Rename include guard.
12806         * common/host-defs.h: Rename include guard.
12807         * common/gdb_wait.h: Rename include guard.
12808         * common/gdb_vecs.h: Rename include guard.
12809         * common/gdb_unlinker.h: Rename include guard.
12810         * common/gdb_unique_ptr.h: Rename include guard.
12811         * common/gdb_tilde_expand.h: Rename include guard.
12812         * common/gdb_sys_time.h: Rename include guard.
12813         * common/gdb_string_view.h: Rename include guard.
12814         * common/gdb_splay_tree.h: Rename include guard.
12815         * common/gdb_setjmp.h: Rename include guard.
12816         * common/gdb_ref_ptr.h: Rename include guard.
12817         * common/gdb_optional.h: Rename include guard.
12818         * common/gdb_locale.h: Rename include guard.
12819         * common/gdb_assert.h: Rename include guard.
12820         * common/filtered-iterator.h: Rename include guard.
12821         * common/filestuff.h: Rename include guard.
12822         * common/fileio.h: Rename include guard.
12823         * common/environ.h: Rename include guard.
12824         * common/common-utils.h: Rename include guard.
12825         * common/common-types.h: Rename include guard.
12826         * common/common-regcache.h: Rename include guard.
12827         * common/common-inferior.h: Rename include guard.
12828         * common/common-gdbthread.h: Rename include guard.
12829         * common/common-exceptions.h: Rename include guard.
12830         * common/common-defs.h: Rename include guard.
12831         * common/common-debug.h: Rename include guard.
12832         * common/cleanups.h: Rename include guard.
12833         * common/buffer.h: Rename include guard.
12834         * common/btrace-common.h: Rename include guard.
12835         * common/break-common.h: Rename include guard.
12836         * cli/cli-utils.h: Rename include guard.
12837         * cli/cli-style.h: Rename include guard.
12838         * cli/cli-setshow.h: Rename include guard.
12839         * cli/cli-script.h: Rename include guard.
12840         * cli/cli-interp.h: Rename include guard.
12841         * cli/cli-decode.h: Rename include guard.
12842         * cli/cli-cmds.h: Rename include guard.
12843         * charset-list.h: Add include guard.
12844         * buildsym-legacy.h: Rename include guard.
12845         * bfin-tdep.h: Add include guard.
12846         * ax.h: Rename include guard.
12847         * arm-linux-tdep.h: Add include guard.
12848         * arm-fbsd-tdep.h: Add include guard.
12849         * arch/xtensa.h: Rename include guard.
12850         * arch/tic6x.h: Add include guard.
12851         * arch/i386.h: Add include guard.
12852         * arch/arm.h: Rename include guard.
12853         * arch/arm-linux.h: Rename include guard.
12854         * arch/arm-get-next-pcs.h: Rename include guard.
12855         * arch/amd64.h: Add include guard.
12856         * arch/aarch64-insn.h: Rename include guard.
12857         * arch-utils.h: Rename include guard.
12858         * annotate.h: Add include guard.
12859         * amd64-darwin-tdep.h: Rename include guard.
12860         * aarch64-linux-tdep.h: Add include guard.
12861         * aarch64-fbsd-tdep.h: Add include guard.
12862         * aarch32-linux-nat.h: Add include guard.
12863
12864 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12865
12866         * macrotab.c (macro_define_internal): New function that
12867         factorizes macro_define_object_internal and macro_define_function
12868         code.
12869         (macro_define_object_internal): Use macro_define_internal.
12870         (macro_define_function): Likewise.
12871
12872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12873
12874         * macrocmd.c (extract_identifier): Return
12875         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12876         callers.
12877
12878 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12879
12880         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12881
12882 2019-02-05  Tom Tromey  <tom@tromey.com>
12883
12884         * target.c (target_stack::unpush): Move assertion earlier.
12885
12886 2019-01-30  Tom Tromey  <tom@tromey.com>
12887
12888         PR python/23615:
12889         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12890         (gdbpy_parse_and_eval): Likewise.
12891         * python/python-internal.h (gdbpy_allow_threads): New class.
12892
12893 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12894
12895         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12896         (aarch64_fbsd_fpregmap): Move earlier.
12897         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12898         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12899         instead of individual calls to trad_frame_set_reg_addr.
12900         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12901         earlier.
12902         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12903         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12904         instead of individual calls to trad_frame_set_reg_addr.
12905
12906 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12907
12908         * CONTRIBUTE: Replace contribution list with wiki link.
12909
12910 2019-01-25  Tom Tromey  <tom@tromey.com>
12911
12912         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12913
12914 2019-01-25  Tom Tromey  <tom@tromey.com>
12915
12916         * xtensa-linux-nat.c: Fix common/ includes.
12917         * xml-support.h: Fix common/ includes.
12918         * xml-support.c: Fix common/ includes.
12919         * x86-linux-nat.c: Fix common/ includes.
12920         * windows-nat.c: Fix common/ includes.
12921         * varobj.h: Fix common/ includes.
12922         * varobj.c: Fix common/ includes.
12923         * value.c: Fix common/ includes.
12924         * valops.c: Fix common/ includes.
12925         * utils.c: Fix common/ includes.
12926         * unittests/xml-utils-selftests.c: Fix common/ includes.
12927         * unittests/utils-selftests.c: Fix common/ includes.
12928         * unittests/unpack-selftests.c: Fix common/ includes.
12929         * unittests/tracepoint-selftests.c: Fix common/ includes.
12930         * unittests/style-selftests.c: Fix common/ includes.
12931         * unittests/string_view-selftests.c: Fix common/ includes.
12932         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12933         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12934         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12935         * unittests/rsp-low-selftests.c: Fix common/ includes.
12936         * unittests/parse-connection-spec-selftests.c: Fix common/
12937         includes.
12938         * unittests/optional-selftests.c: Fix common/ includes.
12939         * unittests/offset-type-selftests.c: Fix common/ includes.
12940         * unittests/observable-selftests.c: Fix common/ includes.
12941         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12942         * unittests/memrange-selftests.c: Fix common/ includes.
12943         * unittests/memory-map-selftests.c: Fix common/ includes.
12944         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12945         * unittests/function-view-selftests.c: Fix common/ includes.
12946         * unittests/environ-selftests.c: Fix common/ includes.
12947         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12948         * unittests/common-utils-selftests.c: Fix common/ includes.
12949         * unittests/cli-utils-selftests.c: Fix common/ includes.
12950         * unittests/array-view-selftests.c: Fix common/ includes.
12951         * ui-file.c: Fix common/ includes.
12952         * tui/tui-io.c: Fix common/ includes.
12953         * tracepoint.h: Fix common/ includes.
12954         * tracepoint.c: Fix common/ includes.
12955         * tracefile-tfile.c: Fix common/ includes.
12956         * top.h: Fix common/ includes.
12957         * top.c: Fix common/ includes.
12958         * thread.c: Fix common/ includes.
12959         * target/waitstatus.h: Fix common/ includes.
12960         * target/waitstatus.c: Fix common/ includes.
12961         * target.h: Fix common/ includes.
12962         * target.c: Fix common/ includes.
12963         * target-memory.c: Fix common/ includes.
12964         * target-descriptions.c: Fix common/ includes.
12965         * symtab.h: Fix common/ includes.
12966         * symfile.c: Fix common/ includes.
12967         * stap-probe.c: Fix common/ includes.
12968         * spu-linux-nat.c: Fix common/ includes.
12969         * sparc-nat.c: Fix common/ includes.
12970         * source.c: Fix common/ includes.
12971         * solib.c: Fix common/ includes.
12972         * solib-target.c: Fix common/ includes.
12973         * ser-unix.c: Fix common/ includes.
12974         * ser-tcp.c: Fix common/ includes.
12975         * ser-pipe.c: Fix common/ includes.
12976         * ser-base.c: Fix common/ includes.
12977         * selftest-arch.c: Fix common/ includes.
12978         * s12z-tdep.c: Fix common/ includes.
12979         * rust-exp.y: Fix common/ includes.
12980         * rs6000-aix-tdep.c: Fix common/ includes.
12981         * riscv-tdep.c: Fix common/ includes.
12982         * remote.c: Fix common/ includes.
12983         * remote-notif.h: Fix common/ includes.
12984         * remote-fileio.h: Fix common/ includes.
12985         * remote-fileio.c: Fix common/ includes.
12986         * regcache.h: Fix common/ includes.
12987         * regcache.c: Fix common/ includes.
12988         * record-btrace.c: Fix common/ includes.
12989         * python/python.c: Fix common/ includes.
12990         * python/py-type.c: Fix common/ includes.
12991         * python/py-inferior.c: Fix common/ includes.
12992         * progspace.h: Fix common/ includes.
12993         * producer.c: Fix common/ includes.
12994         * procfs.c: Fix common/ includes.
12995         * proc-api.c: Fix common/ includes.
12996         * printcmd.c: Fix common/ includes.
12997         * ppc-linux-nat.c: Fix common/ includes.
12998         * parser-defs.h: Fix common/ includes.
12999         * osdata.c: Fix common/ includes.
13000         * obsd-nat.c: Fix common/ includes.
13001         * nat/x86-linux.c: Fix common/ includes.
13002         * nat/x86-linux-dregs.c: Fix common/ includes.
13003         * nat/x86-dregs.h: Fix common/ includes.
13004         * nat/x86-dregs.c: Fix common/ includes.
13005         * nat/ppc-linux.c: Fix common/ includes.
13006         * nat/mips-linux-watch.h: Fix common/ includes.
13007         * nat/mips-linux-watch.c: Fix common/ includes.
13008         * nat/linux-waitpid.c: Fix common/ includes.
13009         * nat/linux-ptrace.h: Fix common/ includes.
13010         * nat/linux-ptrace.c: Fix common/ includes.
13011         * nat/linux-procfs.c: Fix common/ includes.
13012         * nat/linux-personality.c: Fix common/ includes.
13013         * nat/linux-osdata.c: Fix common/ includes.
13014         * nat/linux-namespaces.c: Fix common/ includes.
13015         * nat/linux-btrace.h: Fix common/ includes.
13016         * nat/linux-btrace.c: Fix common/ includes.
13017         * nat/fork-inferior.c: Fix common/ includes.
13018         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13019         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13020         * nat/aarch64-linux.c: Fix common/ includes.
13021         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13022         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13023         * namespace.h: Fix common/ includes.
13024         * mips-linux-tdep.c: Fix common/ includes.
13025         * minsyms.c: Fix common/ includes.
13026         * mi/mi-parse.h: Fix common/ includes.
13027         * mi/mi-main.c: Fix common/ includes.
13028         * mi/mi-cmd-env.c: Fix common/ includes.
13029         * memrange.h: Fix common/ includes.
13030         * memattr.c: Fix common/ includes.
13031         * maint.h: Fix common/ includes.
13032         * maint.c: Fix common/ includes.
13033         * main.c: Fix common/ includes.
13034         * machoread.c: Fix common/ includes.
13035         * location.c: Fix common/ includes.
13036         * linux-thread-db.c: Fix common/ includes.
13037         * linux-nat.c: Fix common/ includes.
13038         * linux-fork.c: Fix common/ includes.
13039         * inline-frame.c: Fix common/ includes.
13040         * infrun.c: Fix common/ includes.
13041         * inflow.c: Fix common/ includes.
13042         * inferior.h: Fix common/ includes.
13043         * inferior.c: Fix common/ includes.
13044         * infcmd.c: Fix common/ includes.
13045         * inf-ptrace.c: Fix common/ includes.
13046         * inf-child.c: Fix common/ includes.
13047         * ia64-linux-nat.c: Fix common/ includes.
13048         * i387-tdep.c: Fix common/ includes.
13049         * i386-tdep.c: Fix common/ includes.
13050         * i386-linux-tdep.c: Fix common/ includes.
13051         * i386-linux-nat.c: Fix common/ includes.
13052         * i386-go32-tdep.c: Fix common/ includes.
13053         * i386-fbsd-tdep.c: Fix common/ includes.
13054         * i386-fbsd-nat.c: Fix common/ includes.
13055         * guile/scm-type.c: Fix common/ includes.
13056         * guile/guile.c: Fix common/ includes.
13057         * go32-nat.c: Fix common/ includes.
13058         * gnu-nat.c: Fix common/ includes.
13059         * gdbthread.h: Fix common/ includes.
13060         * gdbarch-selftests.c: Fix common/ includes.
13061         * gdb_usleep.c: Fix common/ includes.
13062         * gdb_select.h: Fix common/ includes.
13063         * gdb_bfd.c: Fix common/ includes.
13064         * gcore.c: Fix common/ includes.
13065         * fork-child.c: Fix common/ includes.
13066         * findvar.c: Fix common/ includes.
13067         * fbsd-nat.c: Fix common/ includes.
13068         * event-top.c: Fix common/ includes.
13069         * event-loop.c: Fix common/ includes.
13070         * dwarf2read.c: Fix common/ includes.
13071         * dwarf2loc.c: Fix common/ includes.
13072         * dwarf2-frame.c: Fix common/ includes.
13073         * dwarf-index-cache.c: Fix common/ includes.
13074         * dtrace-probe.c: Fix common/ includes.
13075         * disasm-selftests.c: Fix common/ includes.
13076         * defs.h: Fix common/ includes.
13077         * csky-tdep.c: Fix common/ includes.
13078         * cp-valprint.c: Fix common/ includes.
13079         * cp-support.h: Fix common/ includes.
13080         * cp-support.c: Fix common/ includes.
13081         * corelow.c: Fix common/ includes.
13082         * completer.h: Fix common/ includes.
13083         * completer.c: Fix common/ includes.
13084         * compile/compile.c: Fix common/ includes.
13085         * compile/compile-loc2c.c: Fix common/ includes.
13086         * compile/compile-cplus-types.c: Fix common/ includes.
13087         * compile/compile-cplus-symbols.c: Fix common/ includes.
13088         * command.h: Fix common/ includes.
13089         * cli/cli-dump.c: Fix common/ includes.
13090         * cli/cli-cmds.c: Fix common/ includes.
13091         * charset.c: Fix common/ includes.
13092         * build-id.c: Fix common/ includes.
13093         * btrace.h: Fix common/ includes.
13094         * btrace.c: Fix common/ includes.
13095         * breakpoint.h: Fix common/ includes.
13096         * breakpoint.c: Fix common/ includes.
13097         * ax.h:
13098         (enum agent_op): Fix common/ includes.
13099         * ax-general.c (struct aop_map): Fix common/ includes.
13100         * ax-gdb.c: Fix common/ includes.
13101         * auxv.c: Fix common/ includes.
13102         * auto-load.c: Fix common/ includes.
13103         * arm-tdep.c: Fix common/ includes.
13104         * arch/riscv.c: Fix common/ includes.
13105         * arch/ppc-linux-common.c: Fix common/ includes.
13106         * arch/i386.c: Fix common/ includes.
13107         * arch/arm.c: Fix common/ includes.
13108         * arch/arm-linux.c: Fix common/ includes.
13109         * arch/arm-get-next-pcs.c: Fix common/ includes.
13110         * arch/amd64.c: Fix common/ includes.
13111         * arch/aarch64.c: Fix common/ includes.
13112         * arch/aarch64-insn.c: Fix common/ includes.
13113         * arch-utils.c: Fix common/ includes.
13114         * amd64-windows-tdep.c: Fix common/ includes.
13115         * amd64-tdep.c: Fix common/ includes.
13116         * amd64-sol2-tdep.c: Fix common/ includes.
13117         * amd64-obsd-tdep.c: Fix common/ includes.
13118         * amd64-nbsd-tdep.c: Fix common/ includes.
13119         * amd64-linux-tdep.c: Fix common/ includes.
13120         * amd64-linux-nat.c: Fix common/ includes.
13121         * amd64-fbsd-tdep.c: Fix common/ includes.
13122         * amd64-fbsd-nat.c: Fix common/ includes.
13123         * amd64-dicos-tdep.c: Fix common/ includes.
13124         * amd64-darwin-tdep.c: Fix common/ includes.
13125         * agent.c: Fix common/ includes.
13126         * ada-lang.h: Fix common/ includes.
13127         * ada-lang.c: Fix common/ includes.
13128         * aarch64-tdep.c: Fix common/ includes.
13129
13130 2019-01-25  Tom Tromey  <tom@tromey.com>
13131
13132         * common/create-version.sh: Use common/version.h.
13133
13134 2019-01-24  Pedro Alves  <palves@redhat.com>
13135
13136         * infrun.c (signal_stop, signal_print, signal_program)
13137         (signal_catch, signal_pass): Now arrays instead of pointers.
13138         (update_signals_program_target, do_target_resume)
13139         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13140         * linux-nat.c (linux_nat_target::pass_signals)
13141         (linux_nat_target::create_inferior, linux_nat_target::attach):
13142         Adjust.
13143         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13144         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13145         * procfs.c (procfs_target::pass_signals): Adjust.
13146         * record-full.c (record_full_target::resume): Adjust.
13147         * remote.c (remote_target::pass_signals)
13148         (remote_target::program_signals): Adjust.
13149         * target-debug.h (target_debug_print_signals): Now takes a
13150         gdb::array_view as parameter.  Adjust.
13151         * target.h (target_ops) <pass_signals, program_signals>: Replace
13152         pointer and length parameters with gdb::array_view.
13153         (target_pass_signals, target_program_signals): Likewise.
13154         * target-delegates.c: Regenerate.
13155
13156 2019-01-24  Pedro Alves  <palves@redhat.com>
13157
13158         * common/forward-scope-exit.h
13159         (forward_scope_exit::forward_scope_exit): Pass arguments to
13160         m_bind_function directly, instead of creating a std::bind and
13161         copying that.
13162
13163 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13164
13165         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13166         for static members.
13167         (pass_in_v_vfp_candidate): Likewise.
13168
13169 2019-01-23  Tom Tromey  <tom@tromey.com>
13170             Pedro Alves  <palves@redhat.com>
13171
13172         * regcache.c (class regcache_invalidator): Remove.
13173         (regcache::raw_write): Use make_scope_exit.
13174
13175 2019-01-23  Tom Tromey  <tom@tromey.com>
13176
13177         * ui-out.h (class ui_out_emit_type): Update comment.
13178
13179 2019-01-23  Tom Tromey  <tom@tromey.com>
13180
13181         * infrun.c (fetch_inferior_event): Update comment.
13182
13183 2019-01-23  Tom Tromey  <tom@tromey.com>
13184             Pedro Alves  <palves@redhat.com>
13185
13186         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13187         parameter.
13188         (fetch_inferior_event): Use SCOPE_EXIT.
13189
13190
13191 2019-01-23  Tom Tromey  <tom@tromey.com>
13192             Pedro Alves  <palves@redhat.com>
13193
13194         * infrun.c (disable_thread_events): Delete.
13195         (stop_all_threads): Use SCOPE_EXIT.
13196
13197 2019-01-23  Tom Tromey  <tom@tromey.com>
13198             Pedro Alves  <palves@redhat.com>
13199
13200         * symfile.c: Include forward-scope-exit.h.
13201         (clear_symtab_users_cleanup): Replace forward declaration with
13202         a FORWARD_SCOPE_EXIT.
13203         (syms_from_objfile_1): Use the forward_scope_exit and
13204         gdb::optional instead of cleanup_function.
13205         (reread_symbols): Use the forward_scope_exit instead of
13206         cleanup_function.
13207         (clear_symtab_users_cleanup): Remove function.
13208
13209 2019-01-23  Tom Tromey  <tom@tromey.com>
13210             Pedro Alves  <palves@redhat.com>
13211
13212         * linux-nat.c: Include scope-exit.h.
13213         (cleanup_target_stop): Remove.
13214         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13215         SCOPE_EXIT.
13216
13217 2019-01-23  Tom Tromey  <tom@tromey.com>
13218             Pedro Alves  <palves@redhat.com>
13219
13220         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13221         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13222
13223 2019-01-23  Tom Tromey  <tom@tromey.com>
13224             Andrew Burgess  <andrew.burgess@embecosm.com>
13225             Pedro Alves  <palves@redhat.com>
13226
13227         * infrun.c (fetch_inferior_event): Use scope_exit.
13228         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13229         * top.c (execute_command): Use scope_exit.
13230         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13231         * utils.c (do_bpstat_clear_actions_cleanup)
13232         (make_bpstat_clear_actions_cleanup): Remove.
13233
13234 2019-01-23  Tom Tromey  <tom@tromey.com>
13235             Pedro Alves  <palves@redhat.com>
13236
13237         * infrun.c: Include "common/scope-exit.h"
13238         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13239         (wait_for_inferior): Use SCOPE_EXIT.
13240         (fetch_inferior_event): Use scope_exit.
13241
13242 2019-01-23  Tom Tromey  <tom@tromey.com>
13243             Pedro Alves  <palves@redhat.com>
13244
13245         * breakpoint.c (create_breakpoint): Remove cleanup.
13246
13247 2019-01-23  Tom Tromey  <tom@tromey.com>
13248             Andrew Burgess  <andrew.burgess@embecosm.com>
13249             Pedro Alves  <palves@redhat.com>
13250
13251 2019-01-23  Pedro Alves  <palves@redhat.com>
13252
13253         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13254
13255 2019-01-23  Pedro Alves  <palves@redhat.com>
13256             Andrew Burgess  <andrew.burgess@embecosm.com>
13257
13258         * gdbthread.h: Include "common/forward-scope-exit.h".
13259         (scoped_finish_thread_state): Redefine custom class in terms of
13260         forward_scope_exit.
13261
13262 2019-01-23  Pedro Alves  <palves@redhat.com>
13263             Andrew Burgess  <andrew.burgess@embecosm.com>
13264
13265         * common/forward-scope-exit.h: New file.
13266
13267 2019-01-23  Pedro Alves  <palves@redhat.com>
13268             Andrew Burgess  <andrew.burgess@embecosm.com>
13269             Tom Tromey  <tom@tromey.com>
13270
13271         * common/scope-exit.h: New file.
13272
13273 2019-01-23  Pedro Alves  <palves@redhat.com>
13274
13275         * common/preprocessor.h (ESC): Rename to ...
13276         (ESC_PARENS): ... this.
13277         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13278         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13279
13280 2019-01-23  Tom Tromey  <tom@tromey.com>
13281
13282         * language.h (class scoped_switch_to_sym_language_if_auto):
13283         Initialize m_lang in both cases.
13284
13285 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13286
13287         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13288         with XCNEW.
13289
13290 2019-01-22  Tom Tromey  <tom@tromey.com>
13291
13292         * corelow.c: Do not include sys/file.h.
13293
13294 2019-01-22  Tom Tromey  <tom@tromey.com>
13295
13296         * tui/tui-wingeneral.h: Include gdb_curses.h.
13297
13298 2019-01-22  Tom Tromey  <tom@tromey.com>
13299
13300         * source-cache.h (class source_cache) <get_source_lines,
13301         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13302
13303 2019-01-22  Tom Tromey  <tom@tromey.com>
13304
13305         * remote-fileio.h (struct remote_target): Declare.
13306
13307 2019-01-22  Tom Tromey  <tom@tromey.com>
13308
13309         * python/py-arch.c: Do not include py-ref.h.
13310         * python/py-bpevent.c: Do not include py-ref.h.
13311         * python/py-cmd.c: Do not include py-ref.h.
13312         * python/py-continueevent.c: Do not include py-ref.h.
13313         * python/py-event.h: Do not include py-ref.h.
13314         * python/py-evtregistry.c: Do not include py-ref.h.
13315         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13316         * python/py-frame.c: Do not include py-ref.h.
13317         * python/py-framefilter.c: Do not include py-ref.h.
13318         * python/py-function.c: Do not include py-ref.h.
13319         * python/py-infevents.c: Do not include py-ref.h.
13320         * python/py-linetable.c: Do not include py-ref.h.
13321         * python/py-objfile.c: Do not include py-ref.h.
13322         * python/py-param.c: Do not include py-ref.h.
13323         * python/py-prettyprint.c: Do not include py-ref.h.
13324         * python/py-progspace.c: Do not include py-ref.h.
13325         * python/py-symbol.c: Do not include py-ref.h.
13326         * python/py-symtab.c: Do not include py-ref.h.
13327         * python/py-type.c: Do not include py-ref.h.
13328         * python/py-unwind.c: Do not include py-ref.h.
13329         * python/py-utils.c: Do not include py-ref.h.
13330         * python/py-value.c: Do not include py-ref.h.
13331         * python/py-varobj.c: Do not include py-ref.h.
13332         * python/py-xmethods.c: Do not include py-ref.h.
13333         * python/python.c: Do not include py-ref.h.
13334         * varobj.c: Do not include py-ref.h.
13335
13336 2019-01-22  Tom Tromey  <tom@tromey.com>
13337
13338         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13339         keyword for bcache.
13340
13341 2019-01-22  Tom Tromey  <tom@tromey.com>
13342
13343         * compile/compile-cplus-types.c: Remove a comment by #include.
13344
13345 2019-01-22  Tom Tromey  <tom@tromey.com>
13346
13347         * compile/gcc-c-plugin.h: Include compile-internal.h.
13348
13349 2019-01-22  Tom Tromey  <tom@tromey.com>
13350
13351         * stabsread.c (EXTERN): Do not define.
13352         (symnum, next_symbol_text_func, processing_gcc_compilation)
13353         (within_function, global_sym_chain, global_stabs)
13354         (previous_stab_code, this_object_header_files)
13355         (n_this_object_header_files)
13356         (n_allocated_this_object_header_files): Define.
13357         * stabsread.h (EXTERN): Never define.  Use "extern".
13358
13359 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13360
13361         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13362         history_value.
13363
13364 2019-01-21  Tom Tromey  <tom@tromey.com>
13365
13366         * ui-out.c: Fix includes.
13367         * tui/tui-source.c: Fix includes.
13368         * target.c: Fix includes.
13369         * remote.c: Fix includes.
13370         * regcache.c: Fix includes.
13371         * python/py-block.c: Fix includes.
13372         * printcmd.c: Fix includes.
13373         * or1k-tdep.c: Fix includes.
13374         * mi/mi-main.c: Fix includes.
13375         * m32r-tdep.c: Fix includes.
13376         * csky-tdep.c: Fix includes.
13377         * compile/compile-cplus-types.c: Fix includes.
13378         * cli/cli-interp.c: Fix includes.
13379
13380 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13381
13382         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13383         for padding.
13384
13385 2019-01-16  Tom Tromey  <tom@tromey.com>
13386
13387         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13388         earlier.
13389         (struct objfile) <msymbols_range>: Move from top level.
13390         <msymbols>: New method.
13391         (class objfile_msymbols): Remove.
13392         * symtab.c (default_collect_symbol_completion_matches_break_on):
13393         Update.
13394         * symmisc.c (dump_msymbols): Update.
13395         * stabsread.c (scan_file_globals): Update.
13396         * objc-lang.c (info_selectors_command, info_classes_command)
13397         (find_methods): Update.
13398         * minsyms.c (find_solib_trampoline_target): Update.
13399         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13400         * coffread.c (coff_symfile_read): Update.
13401         * ada-lang.c (ada_lookup_simple_minsym)
13402         (ada_collect_symbol_completion_matches): Update.
13403
13404 2019-01-16  Tom Tromey  <tom@tromey.com>
13405
13406         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13407         type.  Remove no-argument constructor.
13408         <iterator::operator++>: Simplify.
13409         <begin>: Update.
13410         <end>: Use minimal_symbol_count.
13411
13412 2019-01-16  Tom Tromey  <tom@tromey.com>
13413
13414         * objfiles.h (struct objfile) <psymtabs>: New method.
13415         (class objfile_psymtabs): Remove.
13416         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13417         typedef.
13418         <range>: New method.
13419         (require_partial_symbols): Change return type.
13420         * psymtab.c (require_partial_symbols)
13421         (psym_expand_symtabs_matching): Update.
13422         * mdebugread.c (parse_partial_symbols): Update.
13423         * dbxread.c (dbx_end_psymtab): Update.
13424
13425 2019-01-15  Tom Tromey  <tom@tromey.com>
13426
13427         * symtab.c (lookup_objfile_from_block)
13428         (lookup_symbol_in_objfile_symtabs)
13429         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13430         (find_line_symtab, info_sources_command)
13431         (default_collect_symbol_completion_matches_break_on)
13432         (make_source_files_completion_list): Update.
13433         * symmisc.c (print_objfile_statistics, dump_objfile)
13434         (maintenance_print_symbols, maintenance_info_symtabs)
13435         (maintenance_check_symtabs, maintenance_info_line_tables):
13436         Update.
13437         * source.c (select_source_symtab)
13438         (forget_cached_source_info_for_objfile): Update.
13439         * objfiles.h (class objfile_compunits): Remove.
13440         (struct objfile) <compunits_range>: New typedef.
13441         (compunits): New method.
13442         * objfiles.c (objfile_relocate1): Update.
13443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13444         * maint.c (count_symtabs_and_blocks): Update.
13445         * linespec.c (iterate_over_all_matching_symtabs): Update.
13446         * cp-support.c (add_symbol_overload_list_qualified): Update.
13447         * coffread.c (coff_symtab_read): Update.
13448         * ada-lang.c (add_nonlocal_symbols)
13449         (ada_collect_symbol_completion_matches)
13450         (ada_add_global_exceptions): Update.
13451
13452 2019-01-15  Tom Tromey  <tom@tromey.com>
13453
13454         * progspace.h (program_space) <objfiles_safe_range>: New
13455         typedef.
13456         <objfiles_safe>: New method.
13457         * objfiles.h (class all_objfiles_safe): Remove.
13458         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13459         * jit.c (jit_inferior_exit_hook): Update.
13460
13461 2019-01-17  Tom Tromey  <tom@tromey.com>
13462
13463         * progspace.h (program_space) <objfiles_range>: New typedef.
13464         <objfiles>: New method.
13465         <objfiles_head>: Rename from objfiles.
13466         (object_files): Update.
13467         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13468         * guile/scm-pretty-print.c
13469         (ppscm_find_pretty_printer_from_objfiles): Update.
13470         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13471         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13472         Update.
13473         * python/py-progspace.c (pspy_get_objfiles): Update.
13474         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13475         Update.
13476         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13477         (objfpy_lookup_objfile_by_build_id): Update.
13478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13479         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13480         Update.
13481         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13482         (expand_symtab_containing_pc, lookup_objfile_from_block)
13483         (lookup_static_symbol, basic_lookup_transparent_type)
13484         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13485         (find_line_symtab, info_sources_command)
13486         (default_collect_symbol_completion_matches_break_on)
13487         (make_source_files_completion_list, find_main_name): Update.
13488         * symmisc.c (print_symbol_bcache_statistics)
13489         (print_objfile_statistics, maintenance_print_symbols)
13490         (maintenance_print_msymbols, maintenance_print_objfiles)
13491         (maintenance_info_symtabs, maintenance_check_symtabs)
13492         (maintenance_expand_symtabs, maintenance_info_line_tables):
13493         Update.
13494         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13495         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13496         (map_overlay_command, unmap_overlay_command)
13497         (simple_overlay_update, expand_symtabs_matching)
13498         (map_symbol_filenames): Update.
13499         * symfile-debug.c (set_debug_symfile): Update.
13500         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13501         Update.
13502         * source.c (select_source_symtab, forget_cached_source_info):
13503         Update.
13504         * solib.c (solib_read_symbols): Update.
13505         * solib-spu.c (append_ocl_sos): Update.
13506         * psymtab.c (maintenance_print_psymbols)
13507         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13508         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13509         * printcmd.c (info_symbol_command): Update.
13510         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13511         Update.
13512         * objfiles.h (class all_objfiles): Remove.
13513         * objfiles.c (have_partial_symbols, have_full_symbols)
13514         (have_minimal_symbols, qsort_cmp, update_section_map)
13515         (shared_objfile_contains_address_p)
13516         (default_iterate_over_objfiles_in_search_order): Update.
13517         * objc-lang.c (info_selectors_command, info_classes_command)
13518         (find_methods): Update.
13519         * minsyms.c (find_solib_trampoline_target): Update.
13520         * maint.c (maintenance_info_sections)
13521         (maintenance_translate_address, count_symtabs_and_blocks):
13522         Update.
13523         * main.c (captured_main_1): Update.
13524         * linux-thread-db.c (try_thread_db_load_from_pdir)
13525         (has_libpthread): Update.
13526         * linespec.c (iterate_over_all_matching_symtabs)
13527         (search_minsyms_for_name): Update.
13528         * jit.c (jit_find_objf_with_entry_addr): Update.
13529         * hppa-tdep.c (find_unwind_entry)
13530         (hppa_lookup_stub_minimal_symbol): Update.
13531         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13532         Update.
13533         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13534         (elf_gnu_ifunc_resolve_by_got): Update.
13535         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13536         * dwarf-index-write.c (save_gdb_index_command): Update.
13537         * cp-support.c (add_symbol_overload_list_qualified): Update.
13538         * breakpoint.c (create_overlay_event_breakpoint)
13539         (create_longjmp_master_breakpoint)
13540         (create_std_terminate_master_breakpoint)
13541         (create_exception_master_breakpoint): Update.
13542         * blockframe.c (find_pc_partial_function): Update.
13543         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13544         (ada_collect_symbol_completion_matches)
13545         (ada_add_global_exceptions): Update.
13546
13547 2019-01-17  Tom Tromey  <tom@tromey.com>
13548
13549         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13550         declare VEC.
13551         (solib_target_parse_libraries): Change return type.
13552         (library_list_start_segment, library_list_start_section)
13553         (library_list_end_library, library_list_start_library); Update.
13554         (solib_target_free_library_list): Remove.
13555         (solib_target_parse_libraries): Remove cleanup.  Change return
13556         type.
13557         (solib_target_current_sos): Update.
13558
13559 2019-01-17  Tom Tromey  <tromey@bapiya>
13560
13561         * valprint.c: Replace "the the" with "the".
13562         * symtab.c: Replace "the the" with "the".
13563         * solib.c: Replace "the the" with "the".
13564         * solib-dsbt.c: Replace "the the" with "the".
13565         * linespec.c: Replace "the the" with "the".
13566         * dwarf2loc.h: Replace "the the" with "the".
13567         * amd64-windows-tdep.c: Replace "the the" with "the".
13568         * aarch64-tdep.c: Replace "the the" with "the".
13569
13570 2019-01-16  Keith Seitz  <keiths@redhat.com>
13571
13572         PR gdb/23773
13573         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13574         <builder>: Rename to ..
13575         <m_builder>: ... this and make private.
13576         (dwarf2_cu::get_builder): New method.  Change all users of
13577         `builder' to use this method.
13578         (dwarf2_start_symtab): Move to ...
13579         (dwarf2_cu::start_symtab): ... here.  Update all callers
13580         (setup_type_unit_groups): Move to ...
13581         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13582         callers.
13583         (dwarf2_cu::reset_builder): New method.
13584         (process_full_compunit, process_full_type_unit): Use
13585         dwarf2_cu::reset_builder.
13586         (follow_die_offset): Record the ancestor CU if it is different
13587         from the followed DIE's CU.
13588         (follow_die_sig_1): Likewise.
13589
13590 2019-01-15  Tom Tromey  <tom@tromey.com>
13591
13592         * remote.c (class remote_state) <buf>: Now a char_vector.
13593         <buf_size>: Remove.
13594         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13595         parameter.
13596         (remote_target::getpkt_or_notif_sane_1)
13597         (remote_target::getpkt_sane)
13598         (remote_target::getpkt_or_notif_sane): Likewise.
13599         (class remote_target) <putpkt>: New overload.
13600         (remote_target::read_frame): Change type of "buf_p".  Remove
13601         sizeof_p parameter.
13602         (packet_ok): New overload.
13603         (packet_check_result): New overload.
13604         Update all uses.
13605
13606 2019-01-14  Tom Tromey  <tom@tromey.com>
13607
13608         * remote-notif.c (handle_notification, remote_notif_ack)
13609         (remote_notif_parse): Make "buf" const.
13610         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13611         const.
13612         (remote_notif_parse, remote_notif_ack, handle_notification):
13613         Likewise.
13614         * remote.c (remote_notif_stop_parse): Make "buf" const.
13615         (remote_target::remote_parse_stop_reply): Make "buf" const.
13616         (remote_notif_stop_ack): Make "buf" const.
13617
13618 2019-01-14  Tom Tromey  <tom@tromey.com>
13619
13620         * remote.c (remote_console_output): Make parameter const.
13621
13622 2019-01-14  Tom Tromey  <tom@tromey.com>
13623
13624         * target-debug.h (target_debug_print_signals): Constify.
13625         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13626         * procfs.c (procfs_target::pass_signals): Update.
13627         * linux-nat.c (linux_nat_target::pass_signals): Update.
13628         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13629         * target-delegates.c: Rebuild.
13630         * remote.c (remote_target::program_signals): Update.
13631         (remote_target::pass_signals): Update.
13632         * target.c (target_pass_signals): Constify argument.
13633         (target_program_signals): Likewise.
13634         * target.h (struct target_ops) <pass_signals, program_signals>:
13635         Constify argument.
13636         (target_pass_signals, target_program_signals): Constify argument.
13637
13638 2019-01-14  Tom Tromey  <tom@tromey.com>
13639
13640         PR tui/28819:
13641         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13642
13643 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13644
13645         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13646         field.
13647         * rs6000-tdep.c: Include reggroups.h.
13648         (IS_V_ALIAS_PSEUDOREG): Define.
13649         (rs6000_register_name): Return names for the "vX" aliases.
13650         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13651         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13652         aliases.  Call default_register_reggroup_p for all other
13653         pseudo-registers.
13654         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13655         New functions.
13656         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13657         Handle "vX" aliases.
13658         (v_alias_pseudo_register_collect): New function.
13659         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13660         (rs6000_gdbarch_init): Initialize "vX" aliases as
13661         pseudo-registers.  Restore registration of
13662         rs6000_pseudo_register_reggroup_p with
13663         set_tdesc_pseudo_register_reggroup_p.
13664
13665 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13666
13667         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13668         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13669         set_gdbarch_num_pseudo_regs.
13670
13671 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13672
13673         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13674         Remove arg prefixname, add do_set and do_show.
13675         Add member functions set_list and show_list.
13676         * cli/cli-style.c (class cli_style_option): Update accordingly.
13677         (style_set_list): Move to file scope.
13678         (style_show_list): Likewise.
13679         (set_style): Call help_list.
13680         (show_style): Call cmd_show_list.
13681         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13682         Update to use the new macro.
13683
13684 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13685
13686         * ada-lang.c (_initialize_ada_language): Expand the help text
13687         for the "catch exception" command.
13688
13689 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13690
13691         * symtab.c (matching_obj_sections): Initialize obj,
13692         declare it closer to its usage.
13693
13694 2019-01-10  Tom Tromey  <tom@tromey.com>
13695
13696         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13697         (basic_inf_threads_range): Remove.
13698         (inf_threads_range, inf_non_exited_threads_range)
13699         (safe_inf_threads_range): Use next_adapter.
13700
13701 2019-01-10  Keith Seitz  <keiths@redhat.com>
13702
13703         PR gdb/23712
13704         PR symtab/23010
13705         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13706         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13707
13708 2019-01-10  Keith Seitz  <keiths@redhat.com>
13709
13710         PR gdb/23712
13711         PR symtab/23010
13712         * dictionary.c (pending_to_vector): Remove.
13713         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13714         Remove _1 suffix, replacing functions of the same name.  Update
13715         all callers.
13716         (dict_create_hashed, dict_create_hashed_expandable)
13717         (dict_create_linear, dict_create_linear_expandable, dict_free)
13718         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13719         Make functions static.
13720
13721 2019-01-10  Keith Seitz  <keiths@redhat.com>
13722
13723         PR gdb/23712
13724         PR symtab/23010
13725         * dictionary.h (struct dictionary): Replace declaration with
13726         multidictionary.
13727         (dict_create_hashed, dict_create_hashed_expandable)
13728         (dict_create_linear, dict_create_linear_expandable)
13729         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13730         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13731         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13732         taking multidictionary argument.
13733         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13734         * block.h (struct block) <dict>: Change to multidictionary
13735         and rename `multidict'.
13736         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13737         symmisc.c: Update all dictionary references to multidictionary.
13738
13739 2019-01-10  Keith Seitz  <keiths@redhat.com>
13740
13741         PR gdb/23712
13742         PR symtab/23010
13743         * dictionary.c: Include unordered_map.
13744         (pending_to_vector): New function.
13745         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13746         Rewrite the non-"_1" functions to take vector instead
13747         of linked list.
13748         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13749         "new" _1 versions of the same name.
13750         (multidictionary): Define.
13751         (std::hash<enum language): New definition.
13752         (collate_pending_symbols_by_language, mdict_create_hashed)
13753         (mdict_create_hashed_expandable, mdict_create_linear)
13754         (mdict_create_linear_expandable, mdict_free)
13755         (find_language_dictionary, create_new_language_dictionary)
13756         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13757         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13758         (mdict_size, mdict_empty): New functions.
13759         * dictionary.h (mdict_iterator): Define.
13760
13761 2019-01-10  Pedro Alves  <palves@redhat.com>
13762
13763         * breakpoint.c (read_uploaded_action)
13764         (create_tracepoint_from_upload): Adjust to use
13765         gdb::unique_xmalloc_ptr.
13766         * ctf.c (ctf_write_uploaded_tp):
13767         (SET_ARRAY_FIELD): Use emplace_back.
13768         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13769         * tracefile-tfile.c (tfile_write_uploaded_tp):
13770         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13771         gdb::unique_xmalloc_ptr.
13772         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13773         at_string, cond_string, cmd_strings>: Replace char pointers
13774         with gdb::unique_xmalloc_ptr.
13775
13776 2019-01-10  Pedro Alves  <palves@redhat.com>
13777
13778         * solib-target.c (library_list_start_library): Don't xstrdup name.
13779
13780 2019-01-10  Pedro Alves  <palves@redhat.com>
13781
13782         * mdebugread.c (parse_partial_symbols): Use
13783         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13784
13785 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13786
13787         * linux-fork.c (scoped_switch_fork_info)
13788         <~scoped_switch_fork_info>: Fix incorrect variable name.
13789
13790 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13791
13792         * linux-fork.c (scoped_switch_fork_info)
13793         <scoped_switch_fork_info>: Make explicit.
13794         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13795
13796 2019-01-10  Tom Tromey  <tom@tromey.com>
13797
13798         * objfiles.h (objfile::reset_psymtabs): Update.
13799         * objfiles.c (objfile::objfile): Update.
13800         * psymtab.h (psymtab_storage::obstack): Update.
13801         (psymtab_storage::m_obstack): Use gdb::optional.
13802         (class psymtab_storage): Update comment.  Remove objfile
13803         parameter.
13804         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13805
13806 2019-01-10  Tom Tromey  <tom@tromey.com>
13807
13808         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13809         <free_psymtabs>: Now private.
13810         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13811         (allocate_psymtab): Use new method.
13812
13813 2019-01-10  Tom Tromey  <tom@tromey.com>
13814
13815         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13816         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13817         * mdebugread.c (parse_partial_symbols): Use
13818         allocate_dependencies.
13819         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13820         allocate_dependencies.
13821         (process_psymtab_comp_unit_reader)
13822         (build_type_psymtab_dependencies): Likewise.
13823         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13824
13825 2019-01-10  Tom Tromey  <tom@tromey.com>
13826
13827         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13828         PSYMBOL_SET_LANGUAGE.
13829         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13830
13831 2019-01-10  Tom Tromey  <tom@tromey.com>
13832
13833         * psymtab.h (psymtab_storage::obstack): New method.
13834         <m_obstack>: Rename from obstack; now private.
13835         * psymtab.c (psymtab_storage): Update.
13836         * dwarf2read.c (create_addrmap_from_index)
13837         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13838         Update.
13839
13840 2019-01-10  Tom Tromey  <tom@tromey.com>
13841
13842         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13843         * objfiles.h (objfile::reset_psymtabs): New method.
13844
13845 2019-01-10  Tom Tromey  <tom@tromey.com>
13846
13847         * symmisc.c (print_symbol_bcache_statistics): Update.
13848         (print_objfile_statistics): Update.
13849         * symfile.c (reread_symbols): Update.
13850         * psymtab.h (class psymtab_storage): New.
13851         * psymtab.c (psymtab_storage): New constructor.
13852         (~psymtab_storage): New destructor.
13853         (require_partial_symbols): Update.
13854         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13855         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13856         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13857         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13858         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13859         (start_psymtab_common, end_psymtab_common)
13860         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13861         (allocate_psymtab): Update.
13862         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13863         Update.
13864         (dump_psymtab_addrmap, maintenance_print_psymbols)
13865         (maintenance_check_psymtabs): Update.
13866         (class objfile_psymtabs): Move to objfiles.h.
13867         * psympriv.h (discard_psymtab): Now inline.
13868         (psymtab_discarder::psymtab_discarder): Update.
13869         (psymtab_discarder::~psymtab_discarder): Update.
13870         (ALL_OBJFILE_PSYMTABS): Rewrite.
13871         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13872         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13873         Remove fields.
13874         <partial_symtabs>: New field.
13875         (class objfile_psymtabs): Move from psymtab.h.  Update.
13876         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13877         psymbol_cache.
13878         (objfile::~objfile): Don't destroy psymbol_cache.
13879         * mdebugread.c (parse_partial_symbols): Update.
13880         * dwarf2read.c (create_addrmap_from_index)
13881         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13882         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13883         (add_partial_subprogram, dwarf2_ranges_read): Update.
13884         * dwarf-index-write.c (write_address_map)
13885         (write_one_signatured_type, recursively_write_psymbols)
13886         (class debug_names, class debug_names, write_psymtabs_to_index):
13887         Update.
13888
13889 2019-01-10  Tom Tromey  <tom@tromey.com>
13890
13891         * symtab.h (SYMBOL_SET_NAMES): Update.
13892         (symbol_set_names): Update.
13893         (MSYMBOL_SET_NAMES): Update.
13894         * symtab.c (symbol_set_names): Change argument to be an
13895         objfile_per_bfd_storage.
13896         * psymtab.c (add_psymbol_to_bcache): Update.
13897         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13898
13899 2019-01-10  Tom Tromey  <tom@tromey.com>
13900
13901         * symtab.c (create_demangled_names_hash): Change argument to be an
13902         objfile_per_bfd_storage.
13903         (symbol_set_names): Update.
13904
13905 2019-01-10  Tom Tromey  <tom@tromey.com>
13906
13907         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13908         init_psymbol_list.
13909         * psymtab.c (init_psymbol_list): Do nothing if already called.
13910         * psympriv.h (init_psymbol_list): Add comment.
13911         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13912         init_psymbol_list.
13913         * dbxread.c (dbx_symfile_read): Unconditionally call
13914         init_psymbol_list.
13915
13916 2019-01-10  Tom Tromey  <tom@tromey.com>
13917
13918         * xcoffread.c (scan_xcoff_symtab): Update.
13919         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13920         "where".
13921         * mdebugread.c (parse_partial_symbols)
13922         (handle_psymbol_enumerators): Update.
13923         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13924         * dbxread.c (read_dbx_symtab): Update.
13925         * psympriv.h (psymbol_placement): New enum.
13926         (add_psymbol_to_list): Update.
13927
13928 2019-01-10  Tom Tromey  <tom@tromey.com>
13929
13930         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13931         static_psymbols parameters.
13932         (scan_xcoff_symtab): Update.
13933         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13934         static_psymbols parameters.
13935         * psympriv.h (start_psymtab_common): Update.
13936         * mdebugread.c (parse_partial_symbols): Update.
13937         * dwarf2read.c (create_partial_symtab): Update.
13938         * dbxread.c (read_dbx_symtab): Update.
13939         (start_psymtab): Remove global_psymbols and static_psymbols
13940         parameters.
13941
13942 2019-01-10  Tom Tromey  <tom@tromey.com>
13943
13944         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13945         * psymtab.c (allocate_psymtab): Add comment.
13946         * psympriv.h (allocate_psymtab): Add comment.
13947         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13948         initializations.
13949         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13950
13951 2019-01-10  Tom Tromey  <tom@tromey.com>
13952
13953         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13954         Don't declare.
13955         * mipsread.c: Include mdebugread.h.
13956         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13957         Declare.
13958         * elfread.c: Include mdebugread.h.
13959
13960 2019-01-09  Tom Tromey  <tom@tromey.com>
13961
13962         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13963         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13964         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13965         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13966         (psym_lookup_symbol, psym_find_last_source_symtab)
13967         (psym_forget_cached_source_info, psym_print_stats)
13968         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13969         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13970         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13971         (psym_find_compunit_symtab_by_address)
13972         (maintenance_print_psymbols, maintenance_info_psymtabs)
13973         (maintenance_check_psymtabs): Use ranged for.
13974         * psymtab.h (class objfile_psymtabs): New.
13975         (require_partial_symbols): Return objfile_psymtabs.
13976         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13977
13978 2019-01-09  Tom Tromey  <tom@tromey.com>
13979
13980         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13981         (find_pc_mapped_section, list_overlays_command)
13982         (map_overlay_command, unmap_overlay_command)
13983         (simple_overlay_update): Use all_objfiles.
13984         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13985         * printcmd.c (info_symbol_command): Use all_objfiles.
13986         * objfiles.h (ALL_OBJSECTIONS): Remove.
13987         * maint.c (maintenance_translate_address): Use all_objfiles.
13988         * gcore.c (gcore_create_callback): Use all_objfiles.
13989         (objfile_find_memory_regions): Likewise.
13990
13991 2019-01-09  Tom Tromey  <tom@tromey.com>
13992
13993         * symtab.c (find_line_symtab, info_sources_command)
13994         (make_source_files_completion_list): Use objfile_compunits.
13995         * source.c (select_source_symtab): Use objfile_compunits.
13996         * objfiles.h (struct objfile): Update comment.
13997         (ALL_OBJFILES): Remove.
13998         (ALL_FILETABS): Remove.
13999         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14000         objfile_compunits.
14001
14002 2019-01-09  Tom Tromey  <tom@tromey.com>
14003
14004         * symmisc.c (print_objfile_statistics, dump_objfile)
14005         (maintenance_print_symbols): Use compunit_filetabs.
14006         * source.c (forget_cached_source_info_for_objfile): Use
14007         compunit_filetabs.
14008         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14009         (ALL_FILETABS): Use compunit_filetabs.
14010         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14011         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14012
14013 2019-01-09  Tom Tromey  <tom@tromey.com>
14014
14015         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14016         (compunit_filetabs): New.
14017         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14018         compunit_filetabs.
14019         (info_sources_command, make_source_files_completion_list): Remove
14020         declaration.
14021         * symmisc.c (print_objfile_statistics, dump_objfile)
14022         (maintenance_print_symbols): Remove declaration.
14023         (maintenance_info_symtabs): Use compunit_filetabs.
14024         (maintenance_info_line_tables): Likewise.
14025         * source.c (select_source_symtab): Change local variable name.
14026         (forget_cached_source_info_for_objfile): Remove declaration.
14027         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14028         * objfiles.c (objfile_relocate1): Remove declaration.
14029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14030         declaration.
14031         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14032         * coffread.c (coff_symtab_read): Remove declaration.
14033         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14034         compunit_filetabs.
14035
14036 2019-01-09  Tom Tromey  <tom@tromey.com>
14037
14038         * symtab.c (lookup_objfile_from_block)
14039         (find_pc_sect_compunit_symtab, search_symbols)
14040         (default_collect_symbol_completion_matches_break_on): Use
14041         objfile_compunits.
14042         * objfiles.h (ALL_COMPUNITS): Remove.
14043         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14044         * cp-support.c (add_symbol_overload_list_qualified): Use
14045         objfile_compunits.
14046         * ada-lang.c (ada_collect_symbol_completion_matches)
14047         (ada_add_global_exceptions): Use objfile_compunits.
14048
14049 2019-01-09  Tom Tromey  <tom@tromey.com>
14050
14051         * source.c (select_source_symtab)
14052         (forget_cached_source_info_for_objfile): Remove declaration.
14053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14054         declaration.
14055         * maint.c (count_symtabs_and_blocks): Remove declaration.
14056         * cp-support.c (add_symbol_overload_list_qualified): Remove
14057         declaration.
14058         * coffread.c (coff_symtab_read): Remove declaration.
14059         * symtab.c (lookup_symbol_in_objfile_symtabs)
14060         (basic_lookup_transparent_type_1): Use objfile_compunits.
14061         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14062         (info_sources_command, search_symbols)
14063         (default_collect_symbol_completion_matches_break_on)
14064         (make_source_files_completion_list): Remove declaration.
14065         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14066         (ada_collect_symbol_completion_matches)
14067         (ada_add_global_exceptions): Remove declaration.
14068         * linespec.c (iterate_over_all_matching_symtabs): Use
14069         objfile_compunits.
14070         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14071         (class objfile_compunits): New.
14072         (ALL_COMPUNITS): Use objfile_compunits.
14073         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14074         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14075         objfile_compunits.
14076         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14077
14078 2019-01-09  Tom Tromey  <tom@tromey.com>
14079
14080         * symtab.c (search_symbols)
14081         (default_collect_symbol_completion_matches_break_on): Use
14082         objfile_msymbols.
14083         * ada-lang.c (ada_lookup_simple_minsym)
14084         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14085         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14086         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14087         objfile_msymbols.
14088         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14089         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14090         * objc-lang.c (find_methods): Use objfile_msymbols.
14091         (info_selectors_command, info_classes_command): Likewise.
14092         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14093         * objfiles.h (class objfile_msymbols): New.
14094         (ALL_OBJFILE_MSYMBOLS): Remove.
14095         (ALL_MSYMBOLS): Remove.
14096
14097 2019-01-09  Tom Tromey  <tom@tromey.com>
14098
14099         * common/next-iterator.h (next_adapter): Add Iterator template
14100         parameter.
14101         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14102         (class all_objfiles_safe): New.
14103         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14104         * objfiles.c (put_objfile_before): Update comment.
14105         (add_separate_debug_objfile): Likewise.
14106         (free_all_objfiles): Use all_objfiles_safe.
14107         (objfile_purge_solibs): Likewise.
14108
14109 2019-01-09  Tom Tromey  <tom@tromey.com>
14110
14111         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14112         (expand_symtab_containing_pc, lookup_static_symbol)
14113         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14114         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14115         all_objfiles.
14116         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14117         * breakpoint.c (create_overlay_event_breakpoint)
14118         (create_longjmp_master_breakpoint)
14119         (create_std_terminate_master_breakpoint)
14120         (create_exception_master_breakpoint): Use all_objfiles.
14121         * linux-thread-db.c (try_thread_db_load_from_pdir)
14122         (has_libpthread): Use all_objfiles.
14123         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14124         * linespec.c (iterate_over_all_matching_symtabs)
14125         (search_minsyms_for_name): Use all_objfiles.
14126         * maint.c (maintenance_info_sections): Use all_objfiles.
14127         * main.c (captured_main_1): Use all_objfiles.
14128         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14129         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14130         * guile/scm-pretty-print.c
14131         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14132         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14133         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14134         (maintenance_print_msymbols): Use all_objfiles.
14135         * source.c (select_source_symtab): Use all_objfiles.
14136         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14137         * symfile.c (remove_symbol_file_command)
14138         (expand_symtabs_matching, map_symbol_filenames): Use
14139         all_objfiles.
14140         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14141         all_objfiles.
14142         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14143         * objc-lang.c (find_methods): Use all_objfiles.
14144         * objfiles.c (have_partial_symbols, have_full_symbols)
14145         (have_minimal_symbols, qsort_cmp)
14146         (default_iterate_over_objfiles_in_search_order): Use
14147         all_objfiles.
14148         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14149         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14150         (maintenance_check_psymtabs): Use all_objfiles.
14151         (ALL_PSYMTABS): Remove.
14152         * compile/compile-object-run.c (do_module_cleanup): Use
14153         all_objfiles.
14154         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14155         * cp-support.c (add_symbol_overload_list_qualified): Use
14156         all_objfiles.
14157         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14158         Use all_objfiles.
14159         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14161         all_objfiles.
14162         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14163         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14164         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14165         Uses all_objfiles.
14166         * solib.c (solib_read_symbols): Use all_objfiles
14167
14168 2019-01-09  Tom Tromey  <tom@tromey.com>
14169
14170         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14171         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14172         all_objfiles.
14173         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14174         * symmisc.c (print_symbol_bcache_statistics)
14175         (print_objfile_statistics, maintenance_print_objfiles)
14176         (maintenance_info_symtabs, maintenance_check_symtabs)
14177         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14178         all_objfiles.
14179         * source.c (forget_cached_source_info): Use all_objfiles.
14180         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14181         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14182         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14183         * objfiles.c (update_section_map): Use all_objfiles.
14184         (shared_objfile_contains_address_p): Likewise.
14185         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14186         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14187
14188 2019-01-09  Tom Tromey  <tom@tromey.com>
14189
14190         * common/next-iterator.h: New file.
14191         * objfiles.h (class all_objfiles): New.
14192         (struct objfile_iterator): New.
14193
14194 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14195
14196         * NEWS: Move the description of the changed "frame", "select-frame",
14197          and "info frame" commands to the Changed commands section.
14198
14199 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14200
14201         * gdbtypes.c (check_stub_method_group): Remove handling of old
14202         mangling schemes.
14203         * linespec.c (find_methods): Likewise.
14204         * stabsread.c (read_member_functions): Likewise.
14205         * valops.c (search_struct_method): Likewise.
14206         (value_struct_elt_for_reference): Likewise.
14207         * NEWS: Mention this change.
14208
14209 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14210
14211         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14212         print_source_lines.
14213         * source.c (print_source_lines_base): Update line number check.
14214         (print_source_lines): New function.
14215         (source_lines_range::source_lines_range): New function.
14216         * source.h (class source_lines_range): New class.
14217         (print_source_lines): New declaration.
14218
14219 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14220
14221         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14222
14223 2019-01-08  Tom Tromey  <tom@tromey.com>
14224             Simon Marchi  <simon.marchi@ericsson.com>
14225
14226         PR gdb/24060
14227         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14228         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14229         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14230         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14231         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14232         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14233
14234 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14235
14236         * source.c (select_source_symtab): Move header comment to
14237         declaration in source.h.
14238         (forget_cached_source_info_for_objfile): Likewise.
14239         (forget_cached_source_info): Likewise.
14240         (identify_source_line): Likewise.
14241         * source.h (identify_source_line): Move declaration from symtab.h
14242         and add comment from source.c
14243         (print_source_lines): Likewise.
14244         (forget_cached_source_info_for_objfile): Likewise.
14245         (forget_cached_source_info): Likewise.
14246         (select_source_symtab): Likewise.
14247         (enum print_source_lines_flag): Move definition from symtab.h.
14248         * symtab.h (identify_source_line): Move declaration to source.h.
14249         (print_source_lines): Likewise.
14250         (forget_cached_source_info_for_objfile): Likewise.
14251         (forget_cached_source_info): Likewise.
14252         (select_source_symtab): Likewise.
14253         (enum print_source_lines_flag): Move definition to source.h.
14254         * tui/tui-hooks.c: Add 'source.h' include.
14255
14256 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14257
14258         * source.c (print_source_lines_base): Handle requests to print
14259         reverse line number sequences, and guard against empty lines
14260         string.
14261
14262 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14263
14264         * source.c (print_source_lines_base): Fix skip of '\r' if next
14265         character is '\n'.
14266
14267 2019-01-06  Tom Tromey  <tom@tromey.com>
14268
14269         * c-exp.y (struct c_parse_state) <macro_original_text,
14270         expansion_obstack>: New member.
14271         (macro_original_text, expansion_obstack): Remove globals.
14272         (scan_macro_expansion, scanning_macro_expansion)
14273         (finished_macro_expansion): Update.
14274         (scan_macro_cleanup): Remove.
14275         (yylex, c_parse): Update.
14276
14277 2019-01-06  Tom Tromey  <tom@tromey.com>
14278
14279         * c-exp.y (struct c_parse_state) <strings>: New member.
14280         (operator_stoken): Update.
14281
14282 2019-01-06  Tom Tromey  <tom@tromey.com>
14283
14284         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14285         (union type_stack_elt) <typelist_val>: Now a pointer to
14286         std::vector.
14287         (type_stack_cleanup): Don't declare.
14288         (push_typelist): Update.
14289         * parse.c (pop_typelist): Return a std::vector.
14290         (push_typelist): Take a std::vector.
14291         (follow_types): Update.  Do not free args.
14292         (type_stack_cleanup): Remove.
14293         * c-exp.y (struct c_parse_state): New.
14294         (cpstate): New global.
14295         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14296         (nonempty_typelist): Update.
14297         (func_mod): Create a new vector.
14298         (c_parse): Create a c_parse_state.
14299         (check_parameter_typelist): Do not delete params.
14300         (function_method): Update.  Do not delete type_list.
14301
14302 2019-01-06  Tom Tromey  <tom@tromey.com>
14303
14304         PR gdb/28155:
14305         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14306         check_typedef.
14307         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14308         (print_return_value): Likewise.
14309
14310 2019-01-05  Tom Tromey  <tom@tromey.com>
14311
14312         * contrib/cleanup_check.py: Remove.
14313         * contrib/gcc-with-excheck: Remove.
14314         * contrib/exsummary.py: Remove.
14315         * contrib/excheck.py: Remove.
14316
14317 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14318
14319         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14320         NULL. Initialize tpprev to NULL instead of assigning it
14321         to NULL on the next statement.
14322         * windows-nat.c (windows_delete_thread): Remove check for
14323         main_thread_id before printing thread exit notifications.
14324         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14325         Remove thread ID check against main_thread_id.
14326         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14327         windows_delete_thread.
14328         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14329
14330 2019-01-04  Tom Tromey  <tom@tromey.com>
14331
14332         * compile/compile.c (_initialize_compile): Use upper case for
14333         metasyntactic variables.
14334         * symmisc.c (_initialize_symmisc): Use upper case for
14335         metasyntactic variables.
14336         * psymtab.c (_initialize_psymtab): Use upper case for
14337         metasyntactic variables.
14338         * demangle.c (demangle_command): Use upper case for metasyntactic
14339         variables.
14340         (_initialize_demangler): Likewise.
14341         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14342         variables.
14343
14344 2019-01-03  Tom Tromey  <tom@tromey.com>
14345
14346         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14347
14348 2019-01-03  Tom Tromey  <tom@tromey.com>
14349
14350         * python/py-symtab.c (salpy_str): Update.
14351         (struct salpy_sal_object) <symtab>: Now a PyObject.
14352         (salpy_dealloc): Update.
14353         (del_objfile_sal): Use gdbpy_ref.
14354
14355 2019-01-03  Tom Tromey  <tom@tromey.com>
14356
14357         * python/py-type.c (convert_field): Use new_reference.  Return
14358         gdbpy_ref.
14359         (make_fielditem): Return gdbpy_ref.
14360         (typy_fields): Update.
14361         (typy_getitem): Update.
14362         (field_name): Return gdbpy_ref.  Use new_reference.
14363         (typy_iterator_iternext): Update.
14364
14365 2019-01-03  Tom Tromey  <tom@tromey.com>
14366
14367         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14368
14369 2019-01-03  Tom Tromey  <tom@tromey.com>
14370
14371         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14372         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14373         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14374         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14375         (pspy_set_type_printers): Likewise.
14376         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14377         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14378         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14379         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14380         (objfpy_set_type_printers): Likewise.
14381
14382 2019-01-03  Tom Tromey  <tom@tromey.com>
14383
14384         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14385         (gdbpy_print_stack): Use gdbpy_err_fetch.
14386         * python/python-internal.h (class gdbpy_err_fetch): New class.
14387         (class gdbpy_enter) <m_error_type, m_error_value,
14388         m_error_traceback>: Remove.
14389         <m_error>: New member.
14390         (gdbpy_exception_to_string): Don't declare.
14391         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14392         * python/py-value.c (convert_value_from_python): Use
14393         gdbpy_err_fetch.
14394         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14395         gdbpy_exception_to_string.
14396         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14397         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14398         gdbpy_err_fetch.
14399
14400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14401
14402         * linux-nat.c (delete_lwp_cleanup): Delete.
14403         (struct lwp_deleter): New struct.
14404         (lwp_info_up): New typedef.
14405         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14406         lwp_info_up.
14407
14408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14409
14410         * linux-fork.c (class scoped_switch_fork_info): New class.
14411         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14412
14413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14414
14415         * valops.c (find_overload_match): Remove use of null_cleanup, and
14416         calls to do_cleanups.
14417
14418 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14419
14420         * compile/compile-cplus-types.c
14421         (compile_cplus_instance::decl_name): Handle changes to
14422         cp_func_name.
14423         * cp-support.c (cp_func_name): Update header comment, update
14424         return type.
14425         * cp-support.h (cp_func_name): Update return type in declaration.
14426         * valops.c (find_overload_match): Move temp_func local to top
14427         level of function and change its type.  Use temp_func to hold and
14428         delete temporary string obtained from cp_func_name.
14429
14430 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14431
14432         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14433         gdb::char_vector, remove cleanup, and update uses of `msg`.
14434
14435 2019-01-03  Jim Wilson  <jimw@sifive.com>
14436
14437         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14438
14439 2019-01-02  Tom Tromey  <tom@tromey.com>
14440
14441         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14442         (tdesc_parse_xml): Remove cleanups.
14443         * target-descriptions.h (make_cleanup_free_target_description):
14444         Don't declare.
14445         (target_desc_deleter): New struct.
14446         (target_desc_up): New typedef.
14447         * target-descriptions.c (target_desc_deleter::operator()): Rename
14448         from free_target_description.
14449         (make_cleanup_free_target_description): Remove.
14450
14451 2019-01-02  Tom Tromey  <tom@tromey.com>
14452
14453         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14454         constructor, destructor.
14455         (linespec_parser): Remove typedef.
14456         (~linespec_parser): Rename from linespec_parser_delete.
14457         (linespec_lex_to_end, linespec_complete_label)
14458         (linespec_complete): Update.
14459         (decode_line_full): Remove cleanups.
14460         (decode_line_1): Update.
14461
14462 2019-01-02  Tom Tromey  <tom@tromey.com>
14463
14464         * python/python-internal.h (inferior_to_inferior_object): Change
14465         return type.
14466         * python/py-exitedevent.c (create_exited_event_object): Update.
14467         * python/py-inferior.c (inferior_to_inferior_object): Return
14468         gdbpy_ref.
14469         (python_new_inferior, python_inferior_deleted)
14470         (thread_to_thread_object, delete_thread_object)
14471         (build_inferior_list, gdbpy_selected_inferior): Update.
14472         * python/py-infthread.c (create_thread_object): Update.  Also fail
14473         if inferior_to_inferior_object fails.
14474
14475 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14476
14477         * inferior.h (class inferior) <displaced_step_state>: New field.
14478         * infrun.h (struct displaced_step_state): Move here from
14479         infrun.c.  Initialize fields, add constructor.
14480         <inf>: Remove field.
14481         <reset>: New method.
14482         * infrun.c (struct displaced_step_inferior_state): Move to
14483         infrun.h.
14484         (displaced_step_inferior_states): Remove.
14485         (get_displaced_stepping_state): Adust.
14486         (displaced_step_in_progress_any_inferior): Adjust.
14487         (displaced_step_in_progress_thread): Adjust.
14488         (displaced_step_in_progress): Adjust.
14489         (add_displaced_stepping_state): Remove.
14490         (get_displaced_step_closure_by_addr): Adjust.
14491         (remove_displaced_stepping_state): Remove.
14492         (infrun_inferior_exit): Call displaced_step_state.reset.
14493         (use_displaced_stepping): Don't check for NULL.
14494         (displaced_step_prepare_throw): Call
14495         get_displaced_stepping_state.
14496         (displaced_step_fixup): Don't check for NULL.
14497         (prepare_for_detach): Don't check for NULL.
14498
14499 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14500
14501         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14502          in case of call that did not complete.
14503
14504 2019-01-02  Andrey Utkin  <autkin@undo.io>
14505
14506         * symfile.c (find_separate_debug_file): Fix search of debug files for
14507         remote debuggee.
14508
14509 2019-01-02  Tom Tromey  <tom@tromey.com>
14510
14511         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14512         indentation.
14513         * python/py-frame.c (frapy_older): Remove cast.
14514         (frapy_newer): Likewise.
14515         * python/py-breakpoint.c (local_setattro): Remove cast.
14516         * python/py-arch.c (archpy_name): Remove local variable.
14517         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14518
14519 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14520
14521         * unittests/basic_string_view/element_access/char/empty.cc:
14522         Fix year range in copyright header.
14523
14524 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14525
14526         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14527         Delete.
14528         <operator==>: Update with for removed field.
14529         <hash>: Likewise.
14530         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14531         <isa_features>: ...this.
14532         <abi_features>: New field.
14533         (riscv_isa_flen): Update comment.
14534         (riscv_abi_xlen): New declaration.
14535         (riscv_abi_flen): New declaration.
14536         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14537         isa_features.
14538         (riscv_abi_xlen): New function.
14539         (riscv_isa_flen): Update to get answer from isa_features.
14540         (riscv_abi_flen): New function.
14541         (riscv_has_fp_abi): Update to get answer from abi_features.
14542         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14543         xlen and flen.
14544         (riscv_call_info) <xlen, flen>: Update comment.
14545         (riscv_call_arg_struct): Remove invalid assertions
14546         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14547         is removed.
14548         (riscv_gdbarch_init): Gather isa features and abi features
14549         separately, ensure both match on the gdbarch when reusing an old
14550         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14551         a target with 64-bit float hardware.
14552
14553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14554
14555         * source.c (search_command_helper): Stop reverse search
14556         when line 1 has been searched.
14557
14558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14559
14560         * record-full.c (record_full_base_target::close): Rewrite
14561         record_full_core_buf_list free logic.
14562
14563 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14564
14565         * break-catch-syscall.c (print_one_catch_syscall): xfree
14566         the last text.
14567
14568 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14569
14570         * top.c (print_gdb_version): Update Copyright year in version
14571         message.
14572
14573 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14574
14575         Update copyright year range in all GDB files.
14576
14577 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14578
14579         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14580
14581 For older changes see ChangeLog-2018.
14582 \f
14583 Local Variables:
14584 mode: change-log
14585 left-margin: 8
14586 fill-column: 74
14587 version-control: never
14588 coding: utf-8
14589 End:
14590