gdb/ChangeLog

   1 2019-12-26  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * NEWS: Mention that multithreaded symbol loading is now on by
   4         default.
   5
   6 2019-12-26  Ruslan Kabatsayev  <b7.10110111@gmail.com>
   7
   8         * dwarf2read.c (is_valid_DW_AT_defaulted)
   9         (is_valid_DW_AT_calling_convention_for_type)
  10         (is_valid_DW_AT_calling_convention_for_subroutine): Fix printing
  11         ULONGEST variables on x86-32.
  12
  13 2019-12-21  George Barrett  <bob@bob131.so>
  14
  15         * solib-svr4.c (svr4_handle_solib_event): Add fallback link
  16         namespace test for when the debug struct isn't available.
  17
  18 2019-12-21  Eli Zaretskii  <eliz@gnu.org>
  19
  20         * top.c (print_gdb_configuration): Print "--with-xxhash" or
  21         "--without-xxhash" according to HAVE_LIBXXHASH.
  22
  23 2019-12-20  Weimin Pan  <weimin.pan@oracle.com>
  24         * ctfread.c (ctf_file_key): Change type to objfile_key.
  25         (struct ctf_context): Remove typedef.
  26         (get_objfile_text_range): Use ANOFFSET to get text base.
  27
  28 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  29
  30         * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
  31         New function.
  32         (read_subroutine_type): Validate the parsed
  33         DW_AT_calling_convention value before assigning it to a
  34         subroutine's calling_convention attribute.
  35         * gdbtypes.h (struct func_type) <calling_convention>: Use
  36         an enum bitfield as its type, instead of plain unsigned.
  37
  38 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  39
  40         PR gdb/25054
  41         * infcall.c (call_function_by_hand_dummy): Update the argument-
  42         passing section for call-by-value parameters.
  43         (struct destructor_info): New struct.
  44         (call_destructors): New auxiliary function.
  45
  46 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  47
  48         * gnu-v3-abi.c (enum definition_style): New enum type.
  49         (get_def_style): New function.
  50         (is_user_provided_def): New function.
  51         (is_implicit_def): New function.
  52         (is_copy_or_move_constructor_type): New function.
  53         (is_copy_constructor_type): New function.
  54         (is_move_constructor_type): New function.
  55         (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
  56         for a given type.
  57
  58 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  59
  60         * language.h (struct language_pass_by_ref_info): New struct.
  61         (struct language_defn)<la_pass_by_reference>: Change the signature
  62         to return a language_pass_by_ref_info instead of an int.
  63         (language_pass_by_reference): Ditto.
  64         (default_pass_by_reference): Ditto.
  65         Adjust the users listed below.
  66         * arch-utils.c (default_return_in_first_hidden_param_p):
  67         Update.
  68         * cp-abi.c (cp_pass_by_reference): Update.
  69         * cp-abi.h (cp_pass_by_reference): Update declaration.
  70         (struct cp_abi_ops)<pass_by_reference>: Update.
  71         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
  72         * infcall.c (call_function_by_hand_dummy): Update.
  73         * language.c (language_pass_by_reference): Update.
  74         (default_pass_by_reference): Update.
  75         * tic6x-tdep.c (tic6x_return_value): Update.
  76
  77 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  78
  79         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
  80         and DW_AT_deleted attributes of a function.
  81         (read_structure_type): Read the DW_AT_calling_convention attribute
  82         of a type.
  83         (is_valid_DW_AT_defaulted): New function.
  84         (is_valid_DW_AT_calling_convention_for_type): New function.
  85         * gdbtypes.h: Include dwarf2.h.
  86         (struct fn_field)<defaulted>: New field to store the
  87         DW_AT_defaulted attribute.
  88         (struct fn_field)<is_deleted>: New field to store the
  89         DW_AT_deleted attribute.
  90         (struct cplus_struct_type)<calling_convention>: New field to store
  91         the DW_AT_calling_convention attribute.
  92         (TYPE_FN_FIELD_DEFAULTED): New macro.
  93         (TYPE_FN_FIELD_DELETED): New macro.
  94         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
  95         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
  96         to the .h file.
  97         (print_cplus_stuff): Likewise.
  98
  99 2019-12-20  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui.c (tui_show_source): Remove.
 102         * tui/tui.h (tui_show_source): Don't declare.
 103         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
 104         tui_show_source.
 105
 106 2019-12-20  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-stack.h (tui_show_frame_info): Return bool.
 109         * tui/tui-stack.c (tui_show_frame_info): Return bool.
 110         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
 111         Update.
 112
 113 2019-12-20  Tom Tromey  <tom@tromey.com>
 114
 115         PR tui/18932:
 116         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
 117         Rename parameters.  Handle the not-from-stack-frame case.
 118         (from_stack, from_source_symtab): New globals.
 119         (tui_before_prompt, tui_normal_stop): Update.
 120         (tui_context_changed, tui_symtab_changed): New functions.
 121         (tui_attach_detach_observers): Attach new observers.
 122
 123 2019-12-20  Tom Tromey  <tom@tromey.com>
 124
 125         * source.c (struct current_source_location) <set, symtab, line>:
 126         New methods.
 127         <m_symtab, m_line>: Rename.  Now private.
 128         (get_current_source_symtab_and_line)
 129         (set_default_source_symtab_and_line)
 130         (set_current_source_symtab_and_line)
 131         (clear_current_source_symtab_and_line, select_source_symtab)
 132         (info_source_command, print_source_lines_base)
 133         (info_line_command, search_command_helper): Update.
 134         * observable.h (current_source_symtab_and_line_changed): Declare
 135         observable.
 136         * observable.c (current_source_symtab_and_line_changed): Define
 137         observable.
 138
 139 2019-12-20  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
 142         (tui_before_prompt, tui_normal_stop): Update.
 143
 144 2019-12-20  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-winsource.c
 147         (tui_source_window_base::update_source_window_as_is): Don't call
 148         set_current_source_symtab_and_line.
 149
 150 2019-12-20  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
 153         Take a symtab_and_line.
 154         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
 155         symtab_and_line.
 156         (tui_show_frame_info): Update.
 157
 158 2019-12-20  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-stack.c (tui_show_frame_info): Don't call
 161         update_exec_info.
 162
 163 2019-12-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui.c (tui_enable): Call tui_display_main.
 166
 167 2019-12-20  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
 170         get_current_source_symtab_and_line, and main_name.
 171
 172 2019-12-20  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui.c (tui_show_source): Update.
 175         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
 176         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
 177         a symtab_symbol_info, not a separate symtab and line.  Simplify.
 178
 179 2019-12-20  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
 182         Simplify.
 183
 184 2019-12-20  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-winsource.h (struct tui_source_window_base)
 187         <set_contents, update_source_window_as_is, update_source_window>:
 188         Take a sal, not a separate symtab and tui_line_or_address.
 189         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 190         (tui_source_window_base::update_source_window_as_is): Take a sal,
 191         not a separate symtab and tui_line_or_address.
 192         (tui_update_source_windows_with_addr)
 193         (tui_update_source_windows_with_line)
 194         (tui_source_window_base::rerender)
 195         (tui_source_window_base::refill): Update.
 196         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
 197         a sal, not a separate symtab and tui_line_or_address.
 198         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
 199         not a separate symtab and tui_line_or_address.
 200         (tui_source_window::maybe_update): Update.
 201         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
 202         a sal, not a separate symtab and tui_line_or_address.
 203         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
 204         not a separate symtab and tui_line_or_address.
 205         (tui_disasm_window::do_scroll_vertical)
 206         (tui_disasm_window::maybe_update): Update.
 207
 208 2019-12-20  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 211         start_line_or_addr.
 212         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 213         start_line_or_addr.
 214         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 215         start_line_or_addr.
 216
 217 2019-12-20  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.h (struct tui_source_window_base)
 220         <set_contents>: Return bool.
 221         * tui/tui-winsource.c
 222         (tui_source_window_base::update_source_window_as_is): Update.
 223         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 224         Return bool.
 225         * tui/tui-source.c (tui_source_window::set_contents): Return
 226         bool.  Simplify.
 227         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 228         Return bool.
 229         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 230         bool.
 231
 232 2019-12-20  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 235         (tui_update_source_windows_with_line): Call update_source_window.
 236         * tui/tui-source.h (struct tui_source_window)
 237         <show_symtab_source>: Don't declare.
 238         * tui/tui-source.c (tui_source_window::show_symtab_source):
 239         Remove.
 240
 241 2019-12-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 244         update_source_window directly.
 245         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 246         * tui/tui-disasm.c (tui_show_disassem): Remove.
 247
 248 2019-12-20  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-winsource.c
 251         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 252         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 253
 254 2019-12-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-winsource.h (struct tui_source_window_base)
 257         <maybe_update>: Remove line_no and addr parameters.
 258         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 259         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 260         Update.
 261         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 262         line_no and addr parameters.
 263         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 264         Update.
 265         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 266         line_no and addr parameters.
 267
 268 2019-12-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 271         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 272
 273 2019-12-20  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 276         tui_show_disassem.
 277         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 278         declare.
 279         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 280
 281 2019-12-20  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui.h (tui_show_source): Remove parameters.
 284         * tui/tui.c (tui_show_source): Remove parameters.
 285         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 286
 287 2019-12-20  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui.c (tui_show_source): Update.
 290         * tui/tui-winsource.c (tui_display_main): Update.
 291         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 292         to symtab.
 293         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 294         to symtab.
 295         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 296
 297 2019-12-20  Tom Tromey  <tom@tromey.com>
 298
 299         PR tui/23619:
 300         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 301         (tui_redisplay_readline): Use rl_display_prompt.
 302         (tui_prep_terminal): Update.
 303
 304 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 305
 306         * configure: Regenerate.
 307         * configure.ac: Quote variable arguments of test.
 308         * gdbsupport/common.m4: Likewise.
 309
 310 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 311
 312         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 313         2 to pow ().
 314
 315 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 316
 317         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 318         log10 to double to fix Solaris 11 with gcc 5.5.
 319
 320 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 321
 322         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 323         "sun" to "saddr_un".
 324
 325 2019-12-19  Tom Tromey  <tromey@adacore.com>
 326
 327         * ui-out.h (enum class field_kind): Fix comment.
 328
 329 2019-12-11  Tom Tromey  <tromey@adacore.com>
 330
 331         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 332
 333 2019-12-18  Tom Tromey  <tromey@adacore.com>
 334
 335         PR build/25268:
 336         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 337         type on macOS.  Add comment.
 338
 339 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 340
 341         * c-lang.c (c_get_string, asm_language_defn): Remove space
 342         before tab.
 343
 344 2019-12-18  Tom Tromey  <tromey@adacore.com>
 345
 346         PR build/25250:
 347         * ui-out.c (ui_out::vmessage): Update.
 348         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 349         Rename.
 350         (string_field): Update.
 351         (signed_field): Update.
 352
 353 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 354
 355         * top.c (print_gdb_configuration): Adjust indentation.
 356
 357 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 358
 359         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 360
 361 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 362
 363         * tui/tui-layout.h (class tui_layout_base): Add virtual
 364         destructor.
 365
 366 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 367
 368         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 369         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 370         (process_event_stop_test): Keep stepping over skipped inline functions.
 371
 372 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 373
 374         * jit.c (struct gdb_block) <next>: Remove field.
 375         (struct gdb_symtab) <~gdb_symtab>: Remove.
 376         <blocks>: Change type to std::forward_list<gdb_block>.
 377         (compare_block): Remove.
 378         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 379         block at the beginning, don't mind about sorting.
 380         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 381         before using it.
 382
 383 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 384
 385         * jit.c (struct gdb_block): Add constructor, initialize
 386         real_block and next fields.
 387         <name>: Change type to gdb::unique_xmalloc_ptr.
 388         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 389         (jit_block_open_impl): Allocate gdb_block with new.
 390         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 391
 392 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 393
 394         * jit.c: Include forward_list.
 395         (struct gdb_symtab) <next>: Remove field.
 396         (struct gdb_object) <symtabs>: Change type to
 397         std::forward_list<gdb_symtab>.
 398         (jit_object_open_impl): Allocate gdb_object with new.
 399         (jit_symtab_open_impl): Adjust to std::forward_list.
 400         (finalize_symtab): Don't delete symtab.
 401         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 402         gdb_object with delete.
 403
 404 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 405
 406         * jit.c (struct gdb_symtab): Add constructor, destructor,
 407         initialize fields.
 408         <linetable>: Change type to unique_xmalloc_ptr.
 409         <file_name>: Change type to std::string.
 410         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 411         (jit_symtab_line_mapping_add_impl): Adjust.
 412         (finalize_symtab): Adjust, call delete on stab.
 413
 414 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 415
 416         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 417
 418 2019-12-16  Tom Tromey  <tromey@adacore.com>
 419
 420         * windows-nat.c (windows_nat_target::attach): Update.
 421         * remote.c (extended_remote_target::attach): Update.
 422         * procfs.c (procfs_target::attach): Update.
 423         * nto-procfs.c (nto_procfs_target::attach): Update.
 424         (nto_procfs_target::create_inferior): Update.
 425         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 426         * gnu-nat.c (gnu_nat_target::attach): Update.
 427         (gnu_nat_target::detach): Update.
 428         * darwin-nat.c (darwin_nat_target::attach): Update.
 429         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 430         return.
 431         * bsd-kvm.c (bsd_kvm_target_open): Update.
 432         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 433
 434 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 435
 436         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 437         (we no longer need to include time.h before pathmax.h)
 438
 439 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * ada-exp.y (write_ambiguous_var): Update.
 442         * coffread.c (process_coff_symbol): Update.
 443         * ctfread.c (ctf_add_enum_member_cb): Update.
 444         (new_symbol): Update.
 445         * dwarf2read.c (fixup_go_packaging): Update.
 446         (new_symbol): Update.
 447         * language.c (language_alloc_type_symbol): Update.
 448         * mdebugread.c (new_symbol): Update.
 449         * minsyms.c (minimal_symbol_reader::record_full): Update.
 450         * psymtab.c (add_psymbol_to_bcache): Update.
 451         * stabsread.c (define_symbol): Update.
 452         (read_enum_type): Update.
 453         * symtab.c (symbol_set_language): Make this a member function...
 454         (general_symbol_info::set_language): ... here.
 455         * symtab.h (struct general_symbol_info) <set_language>: New function.
 456         (SYMBOL_SET_LANGUAGE): Remove.
 457         (symbol_set_language): Remove.
 458
 459 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 460
 461         * ada-lang.c (ada_add_block_symbols): Update.
 462         (ada_collect_symbol_completion_matches): Update.
 463         * ax-gdb.c (gen_expr): Update.
 464         * block.c (block_lookup_symbol): Update.
 465         (block_lookup_symbol_primary): Update.
 466         (block_find_symbol): Update.
 467         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 468         * dbxread.c (process_one_symbol): Update.
 469         * dictionary.c (insert_symbol_hashed): Update.
 470         (collate_pending_symbols_by_language): Update.
 471         (mdict_add_symbol): Update.
 472         * dwarf-index-write.c (write_psymbols): Update.
 473         * dwarf2read.c (fixup_go_packaging): Update.
 474         * findvar.c (read_var_value): Update.
 475         * ft32-tdep.c (ft32_skip_prologue): Update.
 476         * go-lang.c (go_symbol_package_name): Update.
 477         * language.h (scoped_switch_to_sym_language_if_auto::
 478         scoped_switch_to_sym_language_if_auto): Update.
 479         * linespec.c (find_method): Update.
 480         (find_label_symbols_in_block): Update.
 481         * mdebugread.c (parse_symbol): Update.
 482         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 483         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 484         (minimal_symbol_reader::install): Update.
 485         * moxie-tdep.c (moxie_skip_prologue): Update.
 486         * parse.c (parse_exp_in_context): Update.
 487         * psymtab.c (psymbol_name_matches): Update.
 488         (match_partial_symbol): Update.
 489         (lookup_partial_symbol): Update.
 490         (psymbol_hash): Update.
 491         (psymbol_compare): Update.
 492         * python/py-framefilter.c (extract_sym): Update.
 493         (py_print_single_arg): Update.
 494         * stabsread.c (define_symbol): Update.
 495         * stack.c (print_frame_arg): Update.
 496         (find_frame_funname): Update.
 497         (info_frame_command_core): Update.
 498         * symfile.c (set_initial_language): Update.
 499         * symtab.c (symbol_set_demangled_name): Update.
 500         (symbol_get_demangled_name): Update.
 501         (symbol_set_language): Update.
 502         (symbol_find_demangled_name): Update.
 503         (symbol_set_names): Update.
 504         (general_symbol_info::natural_name): Update.
 505         (general_symbol_info::demangled_name): Update.
 506         (general_symbol_info::search_name): Update.
 507         (symbol_matches_search_name): Update.
 508         (eq_symbol_entry): Update.
 509         (iterate_over_symbols): Update.
 510         (completion_list_add_symbol): Update.
 511         (completion_list_add_msymbol): Update.
 512         (completion_list_add_fields): Update.
 513         * symtab.h (struct general_symbol_info) <language>: New function.
 514         <language>: Rename to...
 515         <m_language>: ...this.
 516         (SYMBOL_LANGUAGE): Remove.
 517         (MSYMBOL_LANGUAGE): Remove.
 518         (struct symbol) <ctor>: Update.
 519         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 520
 521 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 522
 523         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 524         set the language of sym.
 525         * language.c (language_alloc_type_symbol): Likewise.
 526
 527 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 528
 529         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 530         PR gdb/23613
 531         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 532         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 533         (core_target_open): Use 'gdb_abspath'.
 534         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 535         'current_directory == NULL' case.
 536         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 537         explain what happens when 'current_directory' is NULL.
 538         * go32-nat.c (go32_nat_target::wait): Check if
 539         'current_directory' is NULL before call to 'chdir'.
 540         * source.c (add_path): Use 'gdb_abspath'.
 541         * top.c: Include 'gdbsupport/pathstuff.h'.
 542         (init_history): Use 'gdb_abspath'.
 543         (set_history_filename): Likewise.
 544         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 545         (tfile_target_open): Use 'gdb_abspath'.
 546
 547 2019-12-13  Tom Tromey  <tromey@adacore.com>
 548
 549         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 550         warning or error.
 551
 552 2019-12-13  Tom Tromey  <tromey@adacore.com>
 553
 554         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 555
 556 2019-12-13  Tom Tromey  <tromey@adacore.com>
 557
 558         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 559
 560 2019-12-13  Tom Tromey  <tromey@adacore.com>
 561
 562         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 563
 564 2019-12-13  Tom Tromey  <tromey@adacore.com>
 565
 566         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 567         (string_vappendf): Add ARI comment.
 568
 569 2019-12-13  Tom Tromey  <tromey@adacore.com>
 570
 571         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 572         floatformat_to_double.
 573         * target-float.c (host_float_ops<T>::from_target): Add ARI
 574         comment.
 575
 576 2019-12-13  Tom Tromey  <tromey@adacore.com>
 577
 578         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 579         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 580         ARI marker to abort.
 581         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 582
 583 2019-12-13  Tom Tromey  <tromey@adacore.com>
 584
 585         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 586
 587 2019-12-13  Tom Tromey  <tromey@adacore.com>
 588
 589         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 590
 591 2019-12-13  Tom Tromey  <tromey@adacore.com>
 592
 593         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 594         checks.
 595
 596 2019-12-13  Tom Tromey  <tromey@adacore.com>
 597
 598         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 599         end>: No longer "const".
 600
 601 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 602
 603         * jit.c: Fix indentation, replace spaces with tabs where
 604         applicable.
 605
 606 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 607
 608         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 609
 610 2019-12-12  Tom Tromey  <tom@tromey.com>
 611
 612         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 613         unique_ptr.
 614
 615 2019-12-12  Tom Tromey  <tom@tromey.com>
 616
 617         * progspace.h (objfile_list): New typedef.
 618         (class unwrapping_objfile_iterator)
 619         (struct unwrapping_objfile_range): Newl
 620         (struct program_space) <objfiles_range>: Change type.
 621         <objfiles>: Change return type.
 622         <add_objfile>: Change type of "objfile" parameter.
 623         <objfiles_list>: Now a list of shared_ptr.
 624         * progspace.c (program_space::add_objfile): Change type of
 625         "objfile".  Update.
 626         (program_space::remove_objfile): Update.
 627         * objfiles.h (struct objfile) <~objfile>: Make public.
 628         * objfiles.c (objfile::make): Update.
 629         (objfile::unlink): Don't call delete.
 630
 631 2019-12-12  Tom Tromey  <tom@tromey.com>
 632
 633         * symfile.c (symbol_file_clear): Update.
 634         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 635         method.
 636         * progspace.c (program_space::free_all_objfiles): New method.
 637         * objfiles.h (free_all_objfiles): Don't declare.
 638         * objfiles.c (free_all_objfiles): Move to program_space.
 639
 640 2019-12-12  Tom Tromey  <tom@tromey.com>
 641
 642         * progspace.c (program_space::add_objfile)
 643         (program_space::remove_objfile): Update.
 644         (program_space::multi_objfile_p): Remove.
 645         * objfiles.h (struct objfile) <next>: Remove.
 646         * objfiles.c (objfile::objfile): Update.
 647         (put_objfile_before): Update.
 648         (unlink_objfile): Update.
 649         * progspace.h (object_files): Remove.
 650         (struct program_space) <objfiles_head>: Remove.
 651         <objfiles_list>: New member.
 652         <objfiles_range, objfiles_safe_range>: Change type.
 653         (objfiles): Change return type.
 654         (objfiles_safe): Update.
 655         (multi_objfile_p): Rewrite and inline.
 656         (object_files): Remove macro.
 657
 658 2019-12-12  Tom Tromey  <tom@tromey.com>
 659
 660         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 661         second constructor.
 662         (basic_safe_range): New class.
 663
 664 2019-12-12  Tom Tromey  <tom@tromey.com>
 665
 666         * progspace.c (program_space::multi_objfile_p): New method.
 667         * printcmd.c (info_symbol_command): Update.
 668         * maint.c (maintenance_translate_address): Update.
 669         * objfiles.h (MULTI_OBJFILE_P): Remove.
 670         * progspace.h (struct program_space) <multi_objfile_p>: New
 671         method.
 672
 673 2019-12-12  Tom Tromey  <tom@tromey.com>
 674
 675         * progspace.h (struct program_space) <remove_objfile>: Declare.
 676         * progspace.c (program_space::remove_objfile): New method.
 677         * objfiles.c (unlink_objfile): Remove.
 678         (objfile::unlink): Call remove_objfile.
 679         (objfile): Don't call unlink_objfile.
 680
 681 2019-12-12  Tom Tromey  <tom@tromey.com>
 682
 683         * progspace.h (struct program_space) <add_objfile>: Declare
 684         method.
 685         * progspace.c (program_space::add_objfile): New method.
 686         * objfiles.c (~objfile): Don't unlink objfile.
 687         (put_objfile_before): Remove.
 688         (add_separate_debug_objfile): Don't call put_objfile_before.
 689         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 690         the per-program-space data.
 691
 692 2019-12-12  Tom Tromey  <tom@tromey.com>
 693
 694         * symfile.c (syms_from_objfile_1): Use objfile_up.
 695         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 696         method.
 697         (reread_symbols): Use objfile_up.
 698         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 699         unlink method.
 700         * objfiles.h (struct objfile) <~objfile>: Now private.
 701         <unlink>: New method.
 702         (struct objfile_deleter): New.
 703         (objfile_up): New typedef.
 704         * objfiles.c (objfile::unlink): New method.
 705         (free_objfile_separate_debug, free_all_objfiles)
 706         (objfile_purge_solibs): Use it.
 707         * jit.c (jit_unregister_code): Remove.
 708         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 709         objfile.
 710         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 711         objfile.
 712         * compile/compile-object-load.c (compile_object_load): Use
 713         objfile_up.
 714
 715 2019-12-12  Tom Tromey  <tom@tromey.com>
 716
 717         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 718         objfile::make.
 719         * objfiles.h (struct objjfile) <make>: No longer inline.
 720         (add_separate_debug_objfile): Don't declare.
 721         * objfiles.c (add_separate_debug_objfile): Now static.
 722         (objfile::make): Move from objfiles.h.  Call
 723         add_separate_debug_objfile.  Add "parent" parameter.
 724
 725 2019-12-12  Tom Tromey  <tom@tromey.com>
 726
 727         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 728         * objfiles.h (struct objfile): Make constructor private.
 729         <make>: New static method.
 730         * jit.c (jit_object_close_impl): Update.
 731
 732 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 733
 734         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 735         gdb::byte_vector.
 736
 737 2019-12-12  Tom Tromey  <tromey@adacore.com>
 738
 739         * xml-support.c (xml_fetch_content_from_file): Don't call
 740         malloc_failure.
 741         * utils.h (class gdb_argv): Remove malloc_failure comment.
 742         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 743
 744 2019-12-12  Tom Tromey  <tromey@adacore.com>
 745
 746         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 747         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 748         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 749         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 750         * riscv-ravenscar-thread.c: New file.
 751         * riscv-ravenscar-thread.h: New file.
 752         * riscv-tdep.c (riscv_gdbarch_init): Call
 753         register_riscv_ravenscar_ops.
 754
 755 2019-12-12  Tom Tromey  <tromey@adacore.com>
 756
 757         * gdbsupport/thread-pool.c (set_thread_name): Use
 758         ATTRIBUTE_UNUSED.
 759
 760 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 761
 762         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 763         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 764         macros.
 765
 766 2019-12-11  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui-win.c (tui_set_win_height_command): Call
 769         tui_adjust_window_height.
 770         (tui_adjust_win_heights, new_height_ok): Remove.
 771         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 772         * tui/tui-layout.c (tui_adjust_window_height): New function.
 773
 774 2019-12-11  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-win.c (tui_resize_all): Remove code, call
 777         tui_apply_current_layout.
 778
 779 2019-12-11  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 782         * tui/tui-layout.c (standard_layouts, applied_layout): New
 783         globals.
 784         (tui_apply_current_layout): New function.
 785         (show_layout): Set applied_layout.  Call
 786         tui_apply_current_layout.
 787         (show_source_command, show_disasm_command)
 788         (show_source_disasm_command, show_data)
 789         (show_source_or_disasm_and_command): Remove.
 790         (initialize_layouts): New function.
 791         (_initialize_tui_layout): Call initialize_layouts.
 792
 793 2019-12-11  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-layout.h (class tui_layout_base)
 796         (class tui_layout_window, class tui_layout_split): New.
 797         * tui/tui-layout.c (tui_get_window_by_name)
 798         (tui_layout_window::clone, tui_layout_window::apply)
 799         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 800         (tui_layout_split::add_window, tui_layout_split::clone)
 801         (tui_layout_split::get_sizes)
 802         (tui_layout_split::set_weights_from_heights)
 803         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 804         functions.
 805         (tui_layout_split::add_split, tui_layout_split::add_split)
 806         (tui_layout_split::set_weights_from_heights)
 807         (tui_layout_split::set_weights_from_heights): New functions.
 808
 809 2019-12-11  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 812         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 813         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 814         * tui/tui-data.h (struct tui_point): Remove.
 815         (struct tui_gen_win_info) <origin>: Remove.
 816         <x, y>: New fields.
 817         * tui/tui-command.c (tui_cmd_window::resize): Update.
 818
 819 2019-12-11  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 822         Implement.
 823         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 824         Implement.
 825         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 826         method.
 827         (struct tui_win_info) <min_height>: Implement.
 828
 829 2019-12-11  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 832         (struct tui_win_info) <can_box>: Update.
 833
 834 2019-12-11  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 837         method.
 838         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 839         method.
 840         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 841         method.
 842         (struct tui_win_info) <max_height>: Now override.
 843
 844 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 845
 846         * NEWS: Create a new section for the next release branch.
 847         Rename the section of the current branch, now that it has
 848         been cut.
 849
 850 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 851
 852         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 853         * version.in: Bump version to 10.0.50.DATE-git.
 854
 855 2019-12-11  Tom Tromey  <tromey@adacore.com>
 856
 857         PR build/25268:
 858         * gdbsupport/thread-pool.c (set_thread_name): New function.
 859         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 860         (thread_pool::thread_function): Call set_thread_name.
 861
 862 2019-12-11  Tom Tromey  <tromey@adacore.com>
 863
 864         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 865         bfd_get_signed_8.
 866
 867 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 868
 869         * NEWS: Document -raw-values option and the related setting commands.
 870         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 871         only set it on when /r is given.
 872         * valprint.c (value_print_option_defs): New element raw-values.
 873         * Makefile.in: Add the new file.
 874
 875 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 876
 877         * gdbsupport/safe-strerror.c: Supress the unused function warning
 878         for select_strerror_r.
 879
 880 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * config.in: Regenerate.
 883         * configure: Regenerate.
 884         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 885         safe_strerror instead of strerror.
 886         * gdbsupport/common.m4: Don't check for strerror.
 887         * gdbsupport/safe-strerror.c: Support both the glibc version
 888         of strerror_r and the XSI version.
 889
 890 2019-12-10  Tom Tromey  <tromey@adacore.com>
 891
 892         * ada-typeprint.c (print_choices): Use a single "?".
 893         (print_variant_part): Print "?" if the discriminant name
 894         is not known.
 895
 896 2019-12-10  George Barrett  <bob@bob131.so>
 897
 898         Fix scripted probe breakpoints.
 899         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 900         declaration forward.
 901         (breakpoint_ops_for_event_location_type)
 902         (breakpoint_ops_for_event_location): Add function definitions.
 903         (break_command_1, trace_command): Use
 904         breakpoint_ops_for_event_location.
 905         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 906         declarations.
 907         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 908         breakpoint_ops_for_event_location.
 909         * python/py-breakpoint.c (bppy_init): Use
 910         breakpoint_ops_for_event_location.
 911
 912 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 913
 914         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 915         when ranking an lvalue argument for an rvalue parameter.
 916
 917 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 918
 919         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 920         template argument for scoped_restore_tmpl from bool to int.
 921
 922 2019-12-07  Keith Seitz  <keiths@redhat.com>
 923
 924         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 925         (build_id_to_debug_bfd): Make static, rewriting to use
 926         build_id_to_bfd_suffix.
 927         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 928         adding `suffix' parameter. Append SUFFIX to file names
 929         when searching for matching files.
 930         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 931         (build_id_to_exec_bfd): Likewise.
 932         * build-id.h (build_id_to_debug_bfd): Clarify that function
 933         searches for BFD of debug info file.
 934         (build_id_to_exec_bfd): Declare.
 935         * corelow.c: Include build-id.h.
 936         (locate_exec_from_corefile_build_id): New function.
 937         (core_target_open): If no executable BFD is found,
 938         search for a core file BFD using build-id.
 939
 940 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 941
 942         * bcache.c: Put in namespace gdb.
 943         * bcache.h: Likewise.
 944         * gdbtypes.c (check_types_worklist): Update.
 945         (types_deeply_equal): Update.
 946         * macrotab.c (struct macro_table) <bcache>: Update.
 947         (new_macro_table): Update.
 948         * macrotab.h (struct bcache): Put this forward declaration
 949         inside namespace gdb.
 950         (new_macro_table): Update.
 951         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 952         Update.
 953         <macro_cache>: Update.
 954         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 955
 956 2019-12-06  Tom de Vries  <tdevries@suse.de>
 957
 958         PR symtab/24971
 959         * block.c (best_symbol, better_symbol): New function.
 960         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 961         decl.
 962
 963 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 964
 965         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 966         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 967         for ranking see-through reference cases.
 968
 969 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 970         * stack.c (faas_command): Check a command is provided.
 971         * thread.c (taas_command, tfaas_command): Likewise.
 972
 973 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974         * inferior.c (prune_inferiors):  Only call delete_inferior,
 975         Do not modify the inferior list.
 976
 977 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 978
 979         * c-exp.y: Update calls to lookup_typename,
 980         lookup_signed_typename and lookup_unsigned_typename.
 981         * c-lang.c (evaluate_subexp_c): Likewise.
 982         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 983         Likewise.
 984         * eval.c (binop_promote): Likewise.
 985         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 986         (lookup_unsigned_typename): Likewise.
 987         (lookup_signed_typename): Likewise.
 988         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 989         (lookup_signed_typename): Likewise.
 990         (lookup_typename): Likewise.
 991         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 992         lookup_typename, lookup_signed_typename,
 993         lookup_unsigned_typename.
 994         * m2-exp.y: Likewise.
 995         * printcmd.c (printf_wide_c_string): Likewise.
 996         (ui_printf): Likewise.
 997         * python/py-type.c (typy_lookup_typename): Likewise.
 998         * python/py-xmethods.c (python_xmethod_worker::invoke):
 999         Likewise.
1000         * rust-exp.y: Likewise.
1001
1002 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
1003
1004         * configure.nat (obsd64): Add missing files x86-nat.o and
1005         nat/x86-dregs.o.
1006
1007 2019-12-04  Tom Tromey  <tom@tromey.com>
1008
1009         * valprint.c (val_print_string): Use metadata_style.
1010         * go-valprint.c (print_go_string): Use metadata style.
1011         * p-valprint.c (pascal_object_print_static_field): Use metadata
1012         style.
1013         * cp-valprint.c (cp_print_static_field): Use metadata style.
1014
1015 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1016             Chris January  <chris.january@arm.com>
1017
1018         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1019         tokens.
1020         (typebase): New patterns for complex, single/double precision, and
1021         single/double complex.
1022         (f77_keywords): Change token for complex keyword, and add single,
1023         double, and precision keywords.
1024
1025 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1026
1027         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1028         "info io_registers".
1029
1030 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1031
1032         * regcache.c (cooked_read_test): Initialize thread list of
1033         mock_inferior.
1034
1035 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1036
1037         * aarch64-linux-tdep.c: Remove includes.
1038
1039 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1040
1041         * aarch64-tdep.c: Remove includes.
1042
1043 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
1044
1045         * filtered-iterator.h (filtered_iterator) <operator==,
1046         operator!=>: Compare wrapped iterators, not wrapped pointers.
1047         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1048         unittests/filtered_iterator-selftests.c.
1049         * unittests/filtered_iterator-selftests.c: New file.
1050
1051 2019-12-04  Tom Tromey  <tromey@adacore.com>
1052
1053         * gdbtypes.c (create_range_type): Inherit endianity
1054         from base type.
1055
1056 2019-12-04  Tom Tromey  <tromey@adacore.com>
1057
1058         * ada-lang.c (decode_constrained_packed_array)
1059         (ada_value_assign, value_assign_to_component): Update.
1060         * dwarf2loc.c (rw_pieced_value, access_memory)
1061         (dwarf2_compile_expr_to_ax): Update.
1062         * dwarf2read.c (dwarf2_add_field): Update.
1063         * eval.c (evaluate_subexp_standard): Update.
1064         * gdbarch.c, gdbarch.h: Rebuild.
1065         * gdbarch.sh (bits_big_endian): Remove.
1066         * gdbtypes.h (union field_location): Update comment.
1067         * target-descriptions.c (make_gdb_type): Update.
1068         * valarith.c (value_bit_index): Update.
1069         * value.c (struct value) <bitpos>: Update comment.
1070         (unpack_bits_as_long, modify_field): Update.
1071         * value.h (value_bitpos): Update comment.
1072
1073 2019-12-04  Tom Tromey  <tromey@adacore.com>
1074
1075         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1076         endian-ness.
1077
1078 2019-12-04  Tom Tromey  <tromey@adacore.com>
1079
1080         * dwarf2read.c (dwarf2_init_float_type)
1081         (dwarf2_init_complex_target_type): Add byte_order parameter.
1082         (read_base_type): Compute byte order earlier.
1083         * gdbtypes.c (init_float_type): Add byte_order parameter.
1084         * gdbtypes.h (init_float_type): Add byte_order parameter.
1085
1086 2019-12-04  Tom Tromey  <tromey@adacore.com>
1087
1088         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1089
1090 2019-12-04  Tom Tromey  <tromey@adacore.com>
1091
1092         * dwarf2read.c (process_structure_scope): Initialize
1093         "discr_offset".
1094
1095 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1098         add it into the search spec.
1099         (parse_max_results_option): New function.
1100         (mi_info_functions_or_variables): Parse -max-results flag and pass
1101         it to mi_symbol_info.
1102         (mi_cmd_symbol_info_modules): Likewise.
1103         (mi_cmd_symbol_info_types): Likewise.
1104         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1105         return type to bool, change result container into a set, and don't
1106         add new results if we have enough already.
1107         (global_symbol_searcher::add_matching_msymbols): Change return
1108         type to bool, and don't add new results if we have enough already.
1109         (sort_search_symbols_remove_dups): Delete.
1110         (global_symbol_searcher::search): Early exit from search loop when
1111         we have enough results.  Use a std::set to collect the results
1112         from calling add_matching_symbols.
1113         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1114         member function.
1115         (global_symbol_searcher) <m_max_search_results>: New member
1116         variable.
1117         (global_symbol_searcher) <add_matching_symbols>: Update header
1118         comment and change return type to bool.
1119         (global_symbol_searcher) <add_matching_msymbols>: Update header
1120         comment and change return type to bool.
1121
1122 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * symtab.c (symbol_search::compare_search_syms): Update header
1125         comment.
1126         (global_symbol_searcher::is_suitable_msymbol): New function.
1127         (global_symbol_searcher::expand_symtabs): New function.
1128         (global_symbol_searcher::add_matching_symbols): New function.
1129         (global_symbol_searcher::add_matching_msymbols): New function.
1130         (global_symbol_searcher::search): Move most of the content
1131         into the new functions above, and call them as needed.
1132         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1133         function.
1134         (global_symbol_searcher) <add_matching_symbols>: New member
1135         function.
1136         (global_symbol_searcher) <add_matching_msymbols>: New member
1137         function.
1138         (global_symbol_searcher) <is_suitable_msymbol>: New member
1139         function.
1140
1141 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1144         -symbol-info-module-variables entries.
1145         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1146         (mi_cmd_symbol_info_module_variables): Declare.
1147         * mi/mi-symbol-cmds.c
1148         (module_symbol_search_iterator): New typedef.
1149         (output_module_symbols_in_single_module_and_file): New function.
1150         (output_module_symbols_in_single_module): New function.
1151         (mi_info_module_functions_or_variables): New function.
1152         (mi_cmd_symbol_info_module_functions): New function.
1153         (mi_cmd_symbol_info_module_variables): New function.
1154         * NEWS: Mention new MI command.
1155
1156 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1157
1158         * bcache.c (hash): Remove.
1159         (hash_continue): Remove.
1160         * bcache.h (hash): Remove.
1161         (hash_continue): Remove.
1162         (struct bcache) <ctor>: Update.
1163         * psymtab.c (psymbol_hash): Update.
1164         * stabsread.c (hashname): Update.
1165         * utils.h (fast_hash): Add an argument for a start value,
1166         defaulting to zero.
1167
1168 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1169         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1170         (destroy_block_symbol_cache): New function.
1171         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1172         (resize_symbol_cache): Likewise.
1173
1174 2019-12-02  Tom Tromey  <tom@tromey.com>
1175
1176         * unittests/tui-selftests.c (run_tests): Make conditional.
1177         (_initialize_tui_selftest): Make conditional.
1178
1179 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1180
1181         * aix-thread.c (debug_aix_thread): Change type to bool.
1182
1183 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1184
1185         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1186
1187 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * dwarf2read.c (read_tag_string_type): Read the fields required to
1190         make a dynamic string, and possibly create a dynamic range for the
1191         string.
1192         (attr_to_dynamic_prop): Setup is_reference based on the type of
1193         attribute being processed.
1194         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1195         (resolve_dynamic_array): Rename to...
1196         (resolve_dynamic_array_or_string): ...this, update header comment,
1197         and accept TYPE_CODE_STRING.
1198         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1199
1200 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1203         of its implementation from...
1204         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1205         the new function.
1206
1207 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1210         create a range with stride where appropriate.
1211         * f-valprint.c: Include 'gdbarch.h'.
1212         (f77_print_array_1): Take the stride into account when walking the
1213         array.  Also convert the stride into addressable units.
1214         * gdbtypes.c (create_range_type): Initialise the stride to
1215         constant zero.
1216         (create_range_type_with_stride): New function, initialise the
1217         range as normal, and then setup the stride.
1218         (has_static_range): Include the stride here.  Also change the
1219         return type to bool.
1220         (create_array_type_with_stride): Consider the range stride if the
1221         array isn't given its own stride.
1222         (resolve_dynamic_range): Resolve the stride if needed.
1223         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1224         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1225         (TYPE_BIT_STRIDE): Define.
1226         (TYPE_ARRAY_BIT_STRIDE): Define.
1227         (create_range_type_with_stride): Declare.
1228         * valarith.c (value_subscripted_rvalue): Take range stride into
1229         account when walking the array.
1230
1231 2019-12-01  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1234         specially.
1235
1236 2019-12-01  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1239         \0.
1240         * unittests/tui-selftests.c: New file.
1241         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1242
1243 2019-12-01  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1246
1247 2019-12-01  Tom Tromey  <tom@tromey.com>
1248
1249         * NEWS: Document new settings.
1250         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1251         * tui/tui-win.c (_initialize_tui_win): Add border style
1252         observers.
1253         * tui/tui-io.h (tui_apply_style): Declare.
1254         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1255         longer static.
1256         (apply_ansi_escape, tui_set_reverse_mode): Update.
1257         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1258         Add "skip_intensity" parameter.
1259         <changed>: New member.
1260         <do_set_value>: Declare.
1261         (tui_border_style, tui_active_border_style): Declare.
1262         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1263         globals.
1264         (cli_style_option): Initialize "changed".
1265         (cli_style_option::do_set_value): New function.
1266         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1267         parameter.  Update.
1268         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1269         (_initialize_cli_style): Update.  Create TUI border style
1270         commands.
1271
1272 2019-12-01  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1275         parameter.
1276         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1277         parameter.
1278         * tui/tui-win.h (compact_source): Declare.
1279         * tui/tui-win.c (compact_source): New global.
1280         (tui_set_compact_source, tui_show_compact_source): New functions.
1281         (_initialize_tui_win): Add "compact-source" setting.
1282         * tui/tui-source.c (tui_source_window::set_contents): Handle
1283         compact_source setting.
1284         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1285         * NEWS: Document new setting.
1286
1287 2019-11-30  Tom Tromey  <tom@tromey.com>
1288
1289         * dwarf2read.c (dwarf2_add_field): Include field offset when
1290         computing variant part length.
1291
1292 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1293         * NEWS:  Mention define-prefix.  Tell that command names can now
1294         contain a . character.
1295
1296 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1297
1298         * command.h (valid_cmd_char_p): Declare.
1299         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1300         the check of valid command char.
1301         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1302         valid_cmd_char_p.
1303         * cli/cli-script.c (validate_comname): Likewise.
1304         * completer.c (gdb_completer_command_word_break_characters):
1305         Do not remove . from the word break char, update comments.
1306         (complete_line_internal_1): Use valid_cmd_char_p.
1307         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1308         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1309
1310 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1311
1312         * cli/cli-script.c (do_define_command): Ensure a redefined
1313         prefix command is kept as a prefix command.
1314         (define_prefix_command): New function.
1315         (show_user_1): Report user defined prefixes.
1316         (_initialize_cli_script):  Create the new 'define-prefix' command.
1317         Add completers for 'define' and 'document'.
1318         * top.c (execute_command):  If command is a user-defined prefix only
1319         command, report the list of commands for this prefix command.
1320
1321 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1322
1323         * valops.c (find_oload_champ): Improve debug output.
1324
1325 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1326
1327         * valops.c (find_oload_champ): Print part of debug messages
1328         before the badness vector is std::move'd.
1329
1330 2019-11-28  Tom Tromey  <tom@tromey.com>
1331
1332         * value.c (creal_internal_fn): Fix comment.
1333
1334 2019-11-28  Tom Tromey  <tom@tromey.com>
1335
1336         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1337         flag_bound_evaluated>: Now unsigned.
1338
1339 2019-11-28  Tom Tromey  <tom@tromey.com>
1340
1341         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1342         declare.
1343
1344 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1345
1346         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1347         debug output.
1348         * jit.c (jit_unregister_code): Add debug print to match
1349         `jit_register_code`.
1350
1351 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1352
1353         * NEWS: Mention the new multithreaded symbol loading.
1354
1355 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * maint.c (n_worker_threads): Default to 0.
1358         (worker_threads_disabled): New function.
1359         * maint.h (worker_threads_disabled): New function.
1360         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1361         here if worker_threads_disabled () is true.
1362         (minimal_symbol_reader::install): Skip all threading if
1363         worker_threads_disabled () is true.
1364
1365 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1366
1367         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1368         hash code if possible.
1369         (add_minsym_to_demangled_hash_table): Likewise.
1370         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1371         on the background thread.
1372         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1373         Add these fields.
1374
1375 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1376
1377         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1378         of the mangled name on the background thread.
1379         * symtab.c (symbol_set_names): Allow passing in the hash of the
1380         linkage_name.
1381         * symtab.h (symbol_set_names): Likewise.
1382
1383 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1384
1385         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1386         physnames are computed for inherited DIEs.
1387
1388 2019-11-27  Tom Tromey  <tromey@adacore.com>
1389
1390         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1391         backslashes.
1392         * cp-support.c: Remove unnecessary backslashes.
1393
1394 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1395
1396         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1397         with sym->set_linkage_name.
1398         * coffread.c (coff_read_enum_type): Likewise.
1399         * mdebugread.c (parse_symbol): Likewise.
1400         * stabsread.c (patch_block_stabs): Likewise.
1401         (define_symbol): Likewise.
1402         (read_enum_type): Likewise.
1403         (common_block_end): Likewise.
1404         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1405         function.
1406         (SYMBOL_SET_LINKAGE_NAME): Remove.
1407         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1408         with sym->set_linkage_name.
1409
1410 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1411
1412         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1413         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1414         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1415         * NEWS: Mention new MI command.
1416
1417 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1420         '-symbol-info-types', and '-symbol-info-variables'.
1421         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1422         (mi_cmd_symbol_info_types): Declare.
1423         (mi_cmd_symbol_info_variables): Declare.
1424         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1425         (output_debug_symbol): New function.
1426         (output_nondebug_symbol): New function.
1427         (mi_symbol_info): New function.
1428         (mi_info_functions_or_variables): New function.
1429         (mi_cmd_symbol_info_functions): New function.
1430         (mi_cmd_symbol_info_types): New function.
1431         (mi_cmd_symbol_info_variables): New function.
1432         * NEWS: Mention new commands.
1433
1434 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1435
1436         * symtab.c (symbol_to_info_string): New function, most content
1437         moved from print_symbol_info, but updated to return a std::string.
1438         (print_symbol_info): Update to use symbol_to_info_string and print
1439         returned string.
1440         * symtab.h (symbol_to_info_string): Declare new function.
1441
1442 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * python/python.c (gdbpy_rbreak): Convert to using
1445         global_symbol_searcher.
1446         * symtab.c (file_matches): Convert return type to bool, change
1447         file list to std::vector, update header comment.
1448         (search_symbols): Rename to...
1449         (global_symbol_searcher::search): ...this and update now its
1450         a member function of global_symbol_searcher.  Take account of the
1451         changes to file_matches.
1452         (symtab_symbol_info): Convert to using global_symbol_searcher.
1453         (rbreak_command): Likewise.
1454         (search_module_symbols): Likewise.
1455         * symtab.h (enum symbol_search): Update comment.
1456         (search_symbols): Remove declaration.
1457         (class global_symbol_searcher): New class.
1458
1459 2019-11-26  Tom Tromey  <tromey@adacore.com>
1460
1461         * cp-support.c (_initialize_cp_support): Conditionally initialize
1462         gdb_demangle_attempt_core_dump.
1463
1464 2019-11-26  Tom Tromey  <tom@tromey.com>
1465
1466         * python/py-function.c (fnpy_init): Update.
1467         * value.h (add_internal_function): Adjust declaration.
1468         * value.c (function_destroyer): Remove.
1469         (do_add_internal_function): Don't set destroyer or copy name.
1470         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1471         Set name_allocated.
1472         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1473         (cmdpy_init): Set name_allocated.
1474         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1475         member.
1476         (~cmd_list_element): Free "name" if needed.
1477
1478 2019-11-26  Tom Tromey  <tom@tromey.com>
1479
1480         * value.h (add_internal_function): Add new overload.  Move
1481         documentation from value.h.
1482         * value.c (do_add_internal_function): New function.
1483         (add_internal_function): Use it.  Add new overload.
1484         (function_destroyer): Don't free doc.
1485         * python/py-function.c (fnpy_init): Update.
1486
1487 2019-11-26  Tom Tromey  <tom@tromey.com>
1488
1489         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1490         (cmdpy_init): Set "doc_allocated".
1491
1492 2019-11-26  Tom Tromey  <tom@tromey.com>
1493
1494         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1495         name of worker thread.
1496         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1497         pthread_setname_np.
1498         * configure, config.in: Rebuild.
1499
1500 2019-11-26  Tom Tromey  <tom@tromey.com>
1501
1502         * python/python.c (class gdbpy_gil): New.
1503         (struct gdbpy_event): Add constructor, destructor, operator().
1504         (gdbpy_post_event): Use run_on_main_thread.
1505         (gdbpy_initialize_events): Remove.
1506         (do_start_initialization): Update.
1507
1508 2019-11-26  Tom Tromey  <tom@tromey.com>
1509
1510         * NEWS: Add entry.
1511         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1512         commands.  Call update_thread_pool_size.
1513         (update_thread_pool_size, maintenance_set_worker_threads): New
1514         functions.
1515         (n_worker_threads): New global.
1516
1517 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1518             Tom Tromey  <tom@tromey.com>
1519
1520         * minsyms.c (minimal_symbol_reader::install): Use
1521         parallel_for_each.
1522         * gdbsupport/parallel-for.h: New file.
1523         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1524
1525 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1526             Tom Tromey  <tom@tromey.com>
1527
1528         * gdbsupport/thread-pool.h: New file.
1529         * gdbsupport/thread-pool.c: New file.
1530         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1531         (HFILES_NO_SRCDIR): Add thread-pool.h.
1532
1533 2019-11-26  Tom Tromey  <tom@tromey.com>
1534
1535         * event-top.h (thread_local_segv_handler): Declare.
1536         * event-top.c (thread_local_segv_handler): New global.
1537         (install_handle_sigsegv, handle_sigsegv): New functions.
1538         (async_init_signals): Install SIGSEGV handler.
1539         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1540         thread-local.
1541         (report_failed_demangle): New function.
1542         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1543         handler-setting code, instead use segv_handler.  Run warning code
1544         on main thread.
1545
1546 2019-11-26  Tom Tromey  <tom@tromey.com>
1547
1548         * run-on-main-thread.c: New file.
1549         * run-on-main-thread.h: New file.
1550         * unittests/main-thread-selftests.c: New file.
1551         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1552         main-thread-selftests.c.
1553         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1554         (COMMON_SFILES): Add run-on-main-thread.c.
1555
1556 2019-11-26  Tom Tromey  <tom@tromey.com>
1557
1558         * main.c (setup_alternate_signal_stack): Remove.
1559         (captured_main_1): Use gdb::alternate_signal_stack.
1560         * gdbsupport/alt-stack.h: New file.
1561
1562 2019-11-26  Tom Tromey  <tom@tromey.com>
1563
1564         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1565         Remove comment.
1566         (save_original_signals_state, restore_original_signals_state): Use
1567         gdb_sigmask.
1568         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1569         (_initialize_linux_nat): Use gdb_sigmask.
1570         * guile/guile.c (_initialize_guile): Use block_signals.
1571         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1572         * gdbsupport/gdb-sigmask.h: New file.
1573         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1574         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1575         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1576         pthread_sigmask.
1577         * configure, config.in: Rebuild.
1578         * gdbsupport/block-signals.h: New file.
1579
1580 2019-11-26  Tom Tromey  <tom@tromey.com>
1581
1582         * acinclude.m4: Include ax_pthread.m4.
1583         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1584         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1585         (CLIBS): Use PTHREAD_LIBS.
1586         (aclocal_m4_deps): Add ax_pthread.m4.
1587         * config.in, configure: Rebuild.
1588         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1589
1590 2019-11-26  Tom Tromey  <tom@tromey.com>
1591
1592         * symtab.h (struct minimal_symbol) <name_set>: New member.
1593         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1594         Don't call symbol_set_names.
1595         (minimal_symbol_reader::install): Call symbol_set_names.
1596
1597 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1598
1599         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1600         restore_active_ext_lang, as GIL is needed for (indirectly)
1601         called PyOS_InterruptOccurred.
1602
1603 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1604
1605         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1606         definition.
1607
1608 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1609
1610         * remote-sim.c (simulator_command): Make static, remove
1611         declaration.
1612
1613 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1614
1615         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1616         static.
1617         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1618         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1619         (main): Likewise.
1620         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1621         (main): Likewise.
1622         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1623         (main): Likewise.
1624         * unittests/basic_string_view/element_access/char/1.cc (test01):
1625         Likewise.
1626         (main): Likewise.
1627         * unittests/basic_string_view/element_access/char/empty.cc (main):
1628         Likewise.
1629         * unittests/basic_string_view/element_access/char/front_back.cc
1630         (test01): Likewise.
1631         (main): Likewise.
1632         * unittests/basic_string_view/inserters/char/2.cc (test05):
1633         Likewise.
1634         (main): Likewise.
1635         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1636         (test01): Likewise.
1637         (main): Likewise.
1638         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1639         (test01): Likewise.
1640         (main): Likewise.
1641         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1642         Likewise.
1643         * unittests/basic_string_view/operations/compare/char/1.cc
1644         (test01): Likewise.
1645         (main): Likewise.
1646         * unittests/basic_string_view/operations/compare/char/13650.cc
1647         (test01): Likewise.
1648         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1649         Likewise.
1650         (main): Likewise.
1651         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1652         Likewise.
1653         (main): Likewise.
1654         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1655         Likewise.
1656         (main): Likewise.
1657         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1658         Likewise.
1659         (main): Likewise.
1660         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1661         Likewise.
1662         (main): Likewise.
1663         * unittests/basic_string_view/operations/find/char/4.cc (main):
1664         Likewise.
1665         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1666         Likewise.
1667         (main): Likewise.
1668         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1669         Likewise.
1670         (main): Likewise.
1671         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1672         Likewise.
1673         (main): Likewise.
1674         * unittests/basic_string_view/operations/substr/char/1.cc
1675         (test01): Likewise.
1676         (main): Likewise.
1677         * unittests/basic_string_view/operators/char/2.cc (main):
1678         Likewise.
1679         * unittests/optional/assignment/1.cc (test): Likewise.
1680         * unittests/optional/assignment/2.cc (test): Likewise.
1681         * unittests/optional/assignment/3.cc (test): Likewise.
1682         * unittests/optional/assignment/4.cc (test): Likewise.
1683         * unittests/optional/assignment/5.cc (test): Likewise.
1684         * unittests/optional/assignment/6.cc (test): Likewise.
1685         * unittests/optional/assignment/7.cc (test): Likewise.
1686         * unittests/optional/cons/copy.cc (test): Likewise.
1687         * unittests/optional/cons/default.cc (test): Likewise.
1688         * unittests/optional/cons/move.cc (test): Likewise.
1689         * unittests/optional/cons/value.cc (test): Likewise.
1690         * unittests/optional/in_place.cc (test): Likewise.
1691         * unittests/optional/observers/1.cc (test): Likewise.
1692         * unittests/optional/observers/2.cc (test): Likewise.
1693
1694 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1695
1696         * tui-win.h (tui_set_var_cmd): Remove.
1697         * tui-win.c (tui_set_var_cmd): Make static.
1698
1699 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1700
1701         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1702         rbreak_command_wrapper): Remove.
1703         * symtab.c (rbreak_command_wrapper): Remove.
1704
1705 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1706
1707         * inferior.h (info_terminal_command): Remove declaration.
1708         * inflow.c (info_terminal_command): Make static.
1709
1710 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1711
1712         * inferior.c (exit_inferior_silent): Remove.
1713
1714 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1715
1716         * dictionary.c (dict_empty, mdict_empty): Remove.
1717         * dictionary.c (mdict_empty): Remove.
1718
1719 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1720
1721          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1722          (arc_insn_get_memory_offset): Likewise.
1723          (arc_insn_dump): Likewise.
1724          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1725          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1726          * dictionary.c (dict_iterator_next): Likewise.
1727          (dict_iter_match_first): Likewise.
1728          (dict_iter_match_next): Likewise.
1729          * f-lang.c (evaluate_subexp_f): Likewise.
1730          * hppa-tdep.c (hppa_read_pc): Likewise.
1731          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1732          * parse.c (write_exp_elt_msym): Likewise.
1733          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1734          * remote.c (remote_packet_size): Likewise.
1735          (remote_notif_stop_parse): Likewise.
1736          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1737          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1738          * source.c (prepare_path_for_appending): Likewise.
1739          * sparc64-linux-tdep.c
1740          (sparc64_linux_handle_segmentation_fault); Likewise.
1741          * stack.c (frame_selection_by_function_completer): Likewise.
1742
1743 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1744
1745         * completer.c (set_gdb_completion_word_break_characters):
1746         Remove.
1747
1748 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1749
1750         * dwarf-index-write.c: Include dwarf-index-write.h.
1751         * mi/mi-interp.c: Include mi/mi-interp.h.
1752
1753 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1754
1755         * aarch32-tdep.c: Include aarch32-tdep.h.
1756         * aarch32-tdep.h: Forward-declare struct target_desc.
1757
1758 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1759
1760         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1761         strerror.
1762         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1763         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1764
1765 2019-11-25  Tom de Vries  <tdevries@suse.de>
1766
1767         * contrib/words.sh: Add -c option.
1768
1769 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1770
1771         * solib.c (solib_find_1): Change int to bool.
1772         (exec_file_find): Change int to bool.
1773         (solib_find): Change int to bool.
1774         (solib_read_symbols): Change int to bool.
1775         (solib_used): Change int to bool.
1776         (solib_add): Change int to bool.
1777         (info_sharedlibrary_command): Change int to bool.
1778         (solib_contains_address_p): Change int to bool.
1779         (solib_keep_data_in_core): Change int to bool.
1780         (in_solib_dynsym_resolve_code): Change int to bool.
1781         (reload_shared_libraries_1): Change int to bool.
1782         (gdb_sysroot_changed): Change int to bool.
1783         * solib.h (solib_read_symbols): Change int to bool.
1784         (solib_contains_address_p): Change int to bool.
1785         (solib_keep_data_in_core): Change int to bool.
1786         (in_solib_dynsym_resolve_code): Change int to bool.
1787         (libpthread_name_p): Change int to bool.
1788
1789 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1790
1791         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1792         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1793         (remote_packet_max_chars): New static global.
1794         (show_remote_packet_max_chars): New function.
1795         (remote_target::putpkt_binary): Adjust to use new
1796         remote_packet_max_chars option.
1797         (remote_target::getpkt_or_notif_sane_1): Likewise.
1798         (_initialize_remote): Register new remote-packet-max-chars option.
1799
1800 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1801
1802         * m68k-linux-nat.c: Include gdbarch.h.
1803
1804 2019-11-24  Tom Tromey  <tom@tromey.com>
1805
1806         * symfile.c (read_symbols): Update.
1807         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1808         bool.
1809         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1810         (psym_lookup_symbol, psym_find_last_source_symtab)
1811         (psym_forget_cached_source_info, psym_print_stats)
1812         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1813         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1814         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1815         (psym_find_compunit_symtab_by_address)
1816         (maintenance_print_psymbols, maintenance_info_psymtabs)
1817         (maintenance_check_psymtabs): Update.
1818         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1819         bool.
1820
1821 2019-11-22  Tom Tromey  <tom@tromey.com>
1822
1823         * observable.h: Update comments.
1824
1825 2019-11-22  Tom Tromey  <tromey@adacore.com>
1826
1827         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1828         (print_ada_task_info): Don't try to fetch thread id if task is not
1829         alive.
1830
1831 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1832
1833         * ada-exp.y: Update.
1834         * ada-lang.c (sort_choices): Update.
1835         (ada_print_symbol_signature): Update.
1836         (resolve_subexp): Update.
1837         (ada_parse_renaming): Update.
1838         (ada_read_renaming_var_value): Update.
1839         (lesseq_defined_than): Update.
1840         (remove_extra_symbols): Update.
1841         (remove_irrelevant_renamings): Update.
1842         (ada_add_block_symbols): Update.
1843         (ada_collect_symbol_completion_matches): Update.
1844         (ada_is_renaming_symbol): Update.
1845         (aggregate_assign_from_choices): Update.
1846         (ada_evaluate_subexp): Update.
1847         (ada_has_this_exception_support): Update.
1848         (ada_is_non_standard_exception_sym): Update.
1849         (ada_add_exceptions_from_frame): Update.
1850         (ada_add_global_exceptions): Update.
1851         (ada_print_subexp): Update.
1852         * ax-gdb.c (gen_var_ref): Update.
1853         (gen_maybe_namespace_elt): Update.
1854         (gen_expr_for_cast): Update.
1855         (gen_expr): Update.
1856         * block.h: Update.
1857         * blockframe.c (find_pc_partial_function): Update.
1858         * breakpoint.c (print_breakpoint_location): Update.
1859         (update_static_tracepoint): Update.
1860         * btrace.c (ftrace_print_function_name): Update.
1861         (ftrace_function_switched): Update.
1862         * buildsym.c (find_symbol_in_list): Update.
1863         * c-exp.y: Update.
1864         * c-typeprint.c (c_print_typedef): Update.
1865         (c_type_print_template_args): Update.
1866         * cli/cli-cmds.c (edit_command): Update.
1867         (list_command): Update.
1868         (print_sal_location): Update.
1869         * coffread.c (patch_opaque_types): Update.
1870         (process_coff_symbol): Update.
1871         (coff_read_enum_type): Update.
1872         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1873         (convert_one_symbol): Update.
1874         (hash_symname): Update.
1875         (eq_symname): Update.
1876         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1877         * compile/compile-cplus-types.c (debug_print_scope): Update.
1878         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1879         * compile/compile-object-load.c (get_out_value_type): Update.
1880         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1881         (search_symbol_list): Update.
1882         (cp_lookup_symbol_imports_or_template): Update.
1883         * cp-support.c (overload_list_add_symbol): Update.
1884         * ctfread.c (psymtab_to_symtab): Update.
1885         * dbxread.c (cp_set_block_scope): Update.
1886         * dictionary.c (iter_match_first_hashed): Update.
1887         (iter_match_next_hashed): Update.
1888         (insert_symbol_hashed): Update.
1889         (iter_match_next_linear): Update.
1890         * dictionary.h: Update.
1891         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1892         (locexpr_describe_location_piece): Update.
1893         (locexpr_describe_location_1): Update.
1894         (locexpr_generate_c_location): Update.
1895         (loclist_describe_location): Update.
1896         (loclist_generate_c_location): Update.
1897         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1898         (read_func_scope): Update.
1899         (process_enumeration_scope): Update.
1900         (new_symbol): Update.
1901         (dwarf2_const_value): Update.
1902         (dwarf2_symbol_mark_computed): Update.
1903         * eval.c (evaluate_funcall): Update.
1904         (evaluate_subexp_standard): Update.
1905         * expprint.c (print_subexp_standard): Update.
1906         (dump_subexp_body_standard): Update.
1907         * f-valprint.c (info_common_command_for_block): Update.
1908         * findvar.c (get_hosting_frame): Update.
1909         (default_read_var_value): Update.
1910         * go-lang.c (go_symbol_package_name): Update.
1911         * guile/scm-block.c (bkscm_print_block_smob): Update.
1912         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1913         (gdbscm_symbol_name): Update.
1914         (gdbscm_symbol_linkage_name): Update.
1915         (gdbscm_symbol_print_name): Update.
1916         * infcall.c (get_function_name): Update.
1917         * infcmd.c (jump_command): Update.
1918         (finish_command): Update.
1919         * infrun.c (insert_exception_resume_breakpoint): Update.
1920         * linespec.c (canonicalize_linespec): Update.
1921         (create_sals_line_offset): Update.
1922         (convert_linespec_to_sals): Update.
1923         (complete_label): Update.
1924         (find_label_symbols_in_block): Update.
1925         * m2-typeprint.c (m2_print_typedef): Update.
1926         * mdebugread.c (mdebug_reg_to_regnum): Update.
1927         (parse_symbol): Update.
1928         (mylookup_symbol): Update.
1929         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1930         (list_args_or_locals): Update.
1931         * objc-lang.c (compare_selectors): Update.
1932         (info_selectors_command): Update.
1933         (compare_classes): Update.
1934         (info_classes_command): Update.
1935         (find_imps): Update.
1936         * p-typeprint.c (pascal_print_typedef): Update.
1937         * printcmd.c (build_address_symbolic): Update.
1938         (info_address_command): Update.
1939         (print_variable_and_value): Update.
1940         * python/py-framefilter.c (extract_sym): Update.
1941         (py_print_single_arg): Update.
1942         * python/py-symbol.c (sympy_str): Update.
1943         (sympy_get_name): Update.
1944         (sympy_get_linkage_name): Update.
1945         * python/python.c (gdbpy_rbreak): Update.
1946         * record-btrace.c (btrace_get_bfun_name): Update.
1947         (btrace_call_history): Update.
1948         * rust-lang.c (rust_print_typedef): Update.
1949         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1950         * stabsread.c (stab_reg_to_regnum): Update.
1951         (define_symbol): Update.
1952         (read_enum_type): Update.
1953         (common_block_end): Update.
1954         (cleanup_undefined_types_1): Update.
1955         (scan_file_globals): Update.
1956         * stack.c (print_frame_arg): Update.
1957         (print_frame_args): Update.
1958         (find_frame_funname): Update.
1959         (info_frame_command_core): Update.
1960         (iterate_over_block_locals): Update.
1961         (print_block_frame_labels): Update.
1962         (do_print_variable_and_value): Update.
1963         (iterate_over_block_arg_vars): Update.
1964         (return_command): Update.
1965         * symmisc.c (dump_symtab_1): Update.
1966         (print_symbol): Update.
1967         * symtab.c (eq_symbol_entry): Update.
1968         (symbol_cache_dump): Update.
1969         (lookup_language_this): Update.
1970         (find_pc_sect_line): Update.
1971         (skip_prologue_sal): Update.
1972         (symbol_search::compare_search_syms): Update.
1973         (treg_matches_sym_type_name): Update.
1974         (search_symbols): Update.
1975         (print_symbol_info): Update.
1976         (rbreak_command): Update.
1977         (completion_list_add_symbol): Update.
1978         (find_gnu_ifunc): Update.
1979         (get_symbol_address): Update.
1980         (search_module_symbols): Update.
1981         (info_module_subcommand): Update.
1982         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1983         (SYMBOL_LINKAGE_NAME): Remove.
1984         (SYMBOL_DEMANGLED_NAME): Remove.
1985         (SYMBOL_PRINT_NAME): Remove.
1986         (SYMBOL_SEARCH_NAME): Remove.
1987         * tracepoint.c (set_traceframe_context): Update.
1988         (validate_actionline): Update.
1989         (collection_list::collect_symbol): Update.
1990         (encode_actions_1): Update.
1991         (info_scope_command): Update.
1992         (print_one_static_tracepoint_marker): Update.
1993         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1994         * valops.c (address_of_variable): Update.
1995         (find_overload_match): Update.
1996         (find_oload_champ): Update.
1997
1998 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1999
2000         * ada-lang.c (ada_lookup_simple_minsym): Update.
2001         (ada_collect_symbol_completion_matches): Update.
2002         * ada-tasks.c (read_atcb): Update.
2003         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
2004         (amd64_windows_skip_trampoline_code): Update.
2005         * arm-tdep.c (skip_prologue_function): Update.
2006         (arm_skip_stack_protector): Update.
2007         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
2008         (arm_wince_skip_main_prologue): Update.
2009         * ax-gdb.c (gen_expr): Update.
2010         * block.c (call_site_for_pc): Update.
2011         * blockframe.c (find_pc_partial_function): Update.
2012         * breakpoint.c (set_breakpoint_location_function): Update.
2013         * btrace.c (ftrace_print_function_name): Update.
2014         (ftrace_function_switched): Update.
2015         * c-valprint.c (print_unpacked_pointer): Update.
2016         * coffread.c (coff_symfile_read): Update.
2017         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2018         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2019         * dwarf-index-write.c (write_psymbols): Update.
2020         * dwarf2loc.c (call_site_to_target_addr): Update.
2021         (func_verify_no_selftailcall): Update.
2022         (tailcall_dump): Update.
2023         (call_site_find_chain_1): Update.
2024         (dwarf_expr_reg_to_entry_parameter): Update.
2025         * elfread.c (elf_gnu_ifunc_record_cache): Update.
2026         * eval.c (evaluate_funcall): Update.
2027         (evaluate_subexp_standard): Update.
2028         (evaluate_subexp_for_sizeof): Update.
2029         * expprint.c (print_subexp_standard): Update.
2030         (dump_subexp_body_standard): Update.
2031         * frame.c (get_prev_frame_always_1): Update.
2032         * frv-tdep.c (frv_skip_main_prologue): Update.
2033         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2034         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2035         (gnuv3_get_typename_from_type_info): Update.
2036         (gnuv3_skip_trampoline): Update.
2037         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2038         * i386-tdep.c (i386_skip_main_prologue): Update.
2039         (i386_pe_skip_trampoline_code): Update.
2040         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2041         * infcall.c (get_function_name): Update.
2042         * linespec.c (minsym_found): Update.
2043         * linux-fork.c (info_checkpoints_command): Update.
2044         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2045         (m32c_m16c_pointer_to_address): Update.
2046         * maint.c (maintenance_translate_address): Update.
2047         * minsyms.c (add_minsym_to_hash_table): Update.
2048         (add_minsym_to_demangled_hash_table): Update.
2049         (lookup_minimal_symbol_mangled): Update.
2050         (lookup_minimal_symbol_demangled): Update.
2051         (lookup_minimal_symbol_linkage): Update.
2052         (lookup_minimal_symbol_text): Update.
2053         (lookup_minimal_symbol_by_pc_name): Update.
2054         (minimal_symbol_is_less_than): Update.
2055         (compact_minimal_symbols): Update.
2056         (build_minimal_symbol_hash_tables): Update.
2057         (find_solib_trampoline_target): Update.
2058         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2059         (mips_skip_pic_trampoline_code): Update.
2060         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2061         * objc-lang.c (info_selectors_command): Update.
2062         (info_classes_command): Update.
2063         (find_methods): Update.
2064         (find_imps): Update.
2065         * p-valprint.c (pascal_val_print): Update.
2066         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2067         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2068         * printcmd.c (build_address_symbolic): Update.
2069         (info_symbol_command): Update.
2070         * psymtab.c (psymbol_name_matches): Update.
2071         (match_partial_symbol): Update.
2072         (lookup_partial_symbol): Update.
2073         (print_partial_symbols): Update.
2074         (sort_pst_symbols): Update.
2075         (maintenance_check_psymtabs): Update.
2076         * python/py-framefilter.c (py_print_frame): Update.
2077         * python/python.c (gdbpy_rbreak): Update.
2078         * record-btrace.c (btrace_get_bfun_name): Update.
2079         (btrace_call_history): Update.
2080         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2081         (rs6000_skip_trampoline_code): Update.
2082         * sol-thread.c (info_cb): Update.
2083         * stabsread.c (scan_file_globals): Update.
2084         * stack.c (find_frame_funname): Update.
2085         (info_frame_command_core): Update.
2086         * symmisc.c (dump_msymbols): Update.
2087         * symtab.c (symbol_natural_name): Rename to..,
2088         (general_symbol_info::natural_name): ...this.
2089         (symbol_demangled_name): Rename to...
2090         (general_symbol_info::demangled_name): ...this.
2091         (symbol_search_name): Rename to...
2092         (general_symbol_info::search_name): ...this.
2093         (symbol_matches_search_name): Update.
2094         (find_pc_sect_line): Update.
2095         (skip_prologue_sal): Update.
2096         (search_symbols): Update.
2097         (print_msymbol_info): Update.
2098         (rbreak_command): Update.
2099         (completion_list_add_msymbol): Update.
2100         (completion_list_objc_symbol): Update.
2101         (get_msymbol_address): Update.
2102         * symtab.h (struct general_symbol_info): Add member functions
2103         natural_name (), linkage_name (), print_name (), demangled_name (),
2104         and search_name ().
2105         (SYMBOL_NATURAL_NAME): Update.
2106         (symbol_natural_name): Move to a member function on general_symbol_info.
2107         (SYMBOL_DEMANGLED_NAME): Update.
2108         (symbol_demangled_name): Move to a member function on
2109         general_symbol_info.
2110         (SYMBOL_SEARCH_NAME): Update.
2111         (symbol_search_name): Move to a member function on general_symbol_info.
2112         (MSYMBOL_NATURAL_NAME): Remove.
2113         (MSYMBOL_LINKAGE_NAME): Remove.
2114         (MSYMBOL_PRINT_NAME): Remove.
2115         (MSYMBOL_DEMANGLED_NAME): Remove.
2116         (MSYMBOL_SEARCH_NAME): Remove.
2117         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2118
2119 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2120
2121         * symtab.c (create_demangled_names_hash): Use per_bfd->
2122         minimal_symbol_count for computing the initial size, if greater
2123         than our default size.
2124
2125 2019-11-22  Tom de Vries  <tdevries@suse.de>
2126
2127         * contrib/words.sh: Improve words extraction.
2128
2129 2019-11-22  Tom de Vries  <tdevries@suse.de>
2130
2131         * contrib/words.sh: Combine sed invocations.
2132
2133 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2134
2135         * Makefile.in: Update.
2136         * demangle.c: Rename to...
2137         * gdb-demangle.c: ..this.
2138         (is_cplus_marker): Change return type to bool.
2139         (_initialize_demangler): Rename to...
2140         (_initialize_gdb_demangle): ...this.
2141         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2142         * symtab.h (demangle): Remove declaration; instead include
2143         gdb-demangle.h.
2144
2145 2019-11-21  Tom Tromey  <tromey@adacore.com>
2146
2147         * gdbsupport/format.c (format_pieces): Parse %I64d.
2148         * unittests/format_pieces-selftests.c (test_windows_formats): New
2149         function.
2150         (run_tests): Call it.
2151
2152 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2153
2154         Byte reverse display of variables with DW_END_big, DW_END_little
2155         (DW_AT_endianity) dwarf attributes if different than the native
2156         byte order.
2157         * ada-lang.c (ada_value_binop):
2158         Use type_byte_order instead of gdbarch_byte_order.
2159         * ada-valprint.c (printstr):
2160         (ada_val_print_string):
2161         * ada-lang.c (value_pointer):
2162         (ada_value_binop):
2163         Use type_byte_order instead of gdbarch_byte_order.
2164         * c-lang.c (c_get_string):
2165         Use type_byte_order instead of gdbarch_byte_order.
2166         * c-valprint.c (c_val_print_array):
2167         Use type_byte_order instead of gdbarch_byte_order.
2168         * cp-valprint.c (cp_print_class_member):
2169         Use type_byte_order instead of gdbarch_byte_order.
2170         * dwarf2loc.c (rw_pieced_value):
2171         Use type_byte_order instead of gdbarch_byte_order.
2172         * dwarf2read.c (read_base_type): Handle DW_END_big,
2173         DW_END_little
2174         * f-lang.c (f_get_encoding):
2175         Use type_byte_order instead of gdbarch_byte_order.
2176         * findvar.c (default_read_var_value):
2177         Use type_byte_order instead of gdbarch_byte_order.
2178         * gdbtypes.c (check_types_equal):
2179         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2180         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2181         and TYPE_ENDIANITY_LITTLE if set.
2182         (type_byte_order): new function.
2183         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2184         (struct main_type) <flag_endianity_not_default>:
2185         New field.
2186         (type_byte_order): New function.
2187         * infcmd.c (default_print_one_register_info):
2188         Use type_byte_order instead of gdbarch_byte_order.
2189         * p-lang.c (pascal_printstr):
2190         Use type_byte_order instead of gdbarch_byte_order.
2191         * p-valprint.c (pascal_val_print):
2192         Use type_byte_order instead of gdbarch_byte_order.
2193         * printcmd.c (print_scalar_formatted):
2194         Use type_byte_order instead of gdbarch_byte_order.
2195         * solib-darwin.c (darwin_current_sos):
2196         Use type_byte_order instead of gdbarch_byte_order.
2197         * solib-svr4.c (solib_svr4_r_ldsomap):
2198         Use type_byte_order instead of gdbarch_byte_order.
2199         * stap-probe.c (stap_modify_semaphore):
2200         Use type_byte_order instead of gdbarch_byte_order.
2201         * target-float.c (target_float_same_format_p):
2202         Use type_byte_order instead of gdbarch_byte_order.
2203         * valarith.c (scalar_binop):
2204         (value_bit_index):
2205         Use type_byte_order instead of gdbarch_byte_order.
2206         * valops.c (value_cast):
2207         Use type_byte_order instead of gdbarch_byte_order.
2208         * valprint.c (generic_emit_char):
2209         (generic_printstr):
2210         (val_print_string):
2211         Use type_byte_order instead of gdbarch_byte_order.
2212         * value.c (unpack_long):
2213         (unpack_bits_as_long):
2214         (unpack_value_bitfield):
2215         (modify_field):
2216         (pack_long):
2217         (pack_unsigned_long):
2218         Use type_byte_order instead of gdbarch_byte_order.
2219         * findvar.c (unsigned_pointer_to_address):
2220         (signed_pointer_to_address):
2221         (unsigned_address_to_pointer):
2222         (address_to_signed_pointer):
2223         (default_read_var_value):
2224         (default_value_from_register):
2225         Use type_byte_order instead of gdbarch_byte_order.
2226         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2227         Use type_byte_order instead of gdbarch_byte_order.
2228         * riscv-tdep.c (riscv_print_one_register_info):
2229         Use type_byte_order instead of gdbarch_byte_order.
2230
2231 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2232
2233         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2234         (current_ui_gdb_stdin_ptr): Likewise.
2235         (current_ui_gdb_stderr_ptr): Likewise.
2236         (current_ui_gdb_stdlog_ptr): Likewise.
2237         (current_ui_current_uiout_ptr): Likewise.
2238         (gen_ret_current_ui_field_ptr): Remove.
2239
2240 2019-11-21  Tom de Vries  <tdevries@suse.de>
2241
2242         PR gdb/24956
2243         * cli/cli-script.c (execute_control_command): Only switch to
2244         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2245
2246 2019-11-19  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2249         Now static.  Change type of "name".
2250         (tui_set_win_height_command): Don't copy "arg".
2251         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2252         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2253
2254 2019-11-19  Ali Tamur <tamur@google.com>
2255
2256         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2257         "if (attr != nullptr)".
2258         (dwarf2_find_base_address): Likewise.
2259         (dwarf2_build_include_psymtabs): Likewise.
2260         (read_cutu_die_from_dwo): Likewise.
2261         (read_func_scope): Likewise.
2262         (read_call_site_scope): Likewise.
2263         (dwarf2_get_pc_bounds): Likewise.
2264         (dwarf2_record_block_ranges): Likewise.
2265         (dwarf2_add_field): Likewise.
2266         (dwarf2_add_member_fn): Likewise.
2267         (read_structure_type): Likewise.
2268         (read_enumeration_type): Likewise.
2269         (read_array_type): Likewise.
2270         (read_array_order): Likewise.
2271         (read_set_type): Likewise.
2272         (read_common_block): Likewise.
2273         (read_tag_reference_type): Likewise.
2274         (read_tag_string_type): Likewise.
2275         (read_subroutine_type): Likewise.
2276         (read_base_type): Likewise.
2277         (read_subrange_type): Likewise.
2278         (new_symbol): Likewise.
2279         (prepare_one_comp_unit): Likewise.
2280
2281 2019-11-19  Tom Tromey  <tromey@adacore.com>
2282
2283         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2284         result in error when DebugActiveProcess fails.
2285
2286 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2287             Pedro Alves  <palves@redhat.com>
2288
2289         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2290         * target.c (target_stack::push): Call 'unpush' if there's a
2291         target on top of the stack.
2292
2293 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2294
2295         * python/py-block.c (blpy_dealloc): Call tp_free.
2296         (blpy_block_syms_dealloc): Likewise.
2297         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2298         * python/py-inferior.c (infpy_dealloc): Likewise.
2299         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2300         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2301         * python/py-symbol.c (sympy_dealloc): Likewise.
2302         * python/py-symtab.c (stpy_dealloc): Likewise.
2303         * python/py-type.c (typy_iterator_dealloc): Likewise.
2304
2305 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2306
2307         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2308         constructor instead of using a class initializer.
2309
2310 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2311
2312         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2313         * configure: Regenerate.
2314         * configure.ac: Don't source common.host.
2315         * gdbsupport/common.host: Remove.
2316         * gdbsupport/mingw-strerror.c: Remove.
2317         * gdbsupport/posix-strerror.c: Rename to...
2318         * gdbsupport/safe-strerror.c: ...this.
2319
2320 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * maint.c (scoped_command_stats::print_time): Use localtime_r
2323         instead of localtime (provided through gnulib if necessary).
2324         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2325         of ctime.
2326
2327 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2330         avoid compile errors.
2331
2332 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2333
2334         * config.in: Regenerate.
2335         * configure: Regenerate.
2336         * gdbsupport/common.m4: No longer check for strerror_r.
2337         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2338         POSIX version of strerror_r, now that gnulib provides it if
2339         necessary.
2340
2341 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2342
2343         * README (`configure' options): Update.
2344
2345 2019-11-14  Tom Tromey  <tromey@adacore.com>
2346
2347         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2348         expected type for the RHS if the LHS is a convenience variable.
2349
2350 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2351
2352         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2353         Provide explicit default and copy constructor.
2354
2355 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2356
2357         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2358         only call Py_INCREF (newbp) in the bppy_pending_object case.
2359
2360 2019-11-13  Tom Tromey  <tromey@adacore.com>
2361
2362         PR build/25182:
2363         * psympriv.h (partial_symbol): Remove static assert.
2364         * symtab.h (general_symbol_info, symbol): Remove static assert.
2365
2366 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * gdbsupport/format.c (format_pieces::format_pieces): Support
2369         printf 'z' size modifier.
2370         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2371         * printcmd.c (ui_printf):  Handle size_t_arg.
2372         * ui-out.c (ui_out::vmessage): Likewise.
2373         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2374         function.
2375         (run_tests): Call test_format_int_sizes.
2376
2377 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2378
2379         * ada-exp.y (write_ambiguous_var): Update.
2380         * buildsym.c (add_symbol_to_list): Update.
2381         * dwarf2read.c (read_variable): Update.
2382         (new_symbol): Update.
2383         * jit.c (finalize_symtab): Update.
2384         * language.c (language_alloc_type_symbol): Update.
2385         * symtab.c (fixup_symbol_section): Update.
2386         (initialize_objfile_symbol_1): Move code to...
2387         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2388         (allocate_symbol): Update.
2389         (allocate_template_symbol): Update.
2390         (get_symbol_address): Update.
2391         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2392         of having as a field, and add a constructor.
2393         (SYMBOL_VALUE): Update.
2394         (SYMBOL_VALUE_ADDRESS): Update.
2395         (SET_SYMBOL_VALUE_ADDRESS): Update.
2396         (SYMBOL_VALUE_BYTES): Update.
2397         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2398         (SYMBOL_BLOCK_VALUE): Update.
2399         (SYMBOL_VALUE_CHAIN): Update.
2400         (SYMBOL_LANGUAGE): Update.
2401         (SYMBOL_SECTION): Update.
2402         (SYMBOL_OBJ_SECTION): Update.
2403         (SYMBOL_SET_LANGUAGE): Update.
2404         (SYMBOL_SET_LINKAGE_NAME): Update.
2405         (SYMBOL_SET_NAMES): Update.
2406         (SYMBOL_NATURAL_NAME): Update.
2407         (SYMBOL_LINKAGE_NAME): Update.
2408         (SYMBOL_DEMANGLED_NAME): Update.
2409         (SYMBOL_SEARCH_NAME): Update.
2410         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2411         (struct symbol): Update.
2412         (struct template_symbol): Update.
2413         (struct rust_vtable_symbol): Update.
2414         * xcoffread.c (SYMBOL_DUP): Update.
2415
2416 2019-11-12  Tom Tromey  <tom@tromey.com>
2417
2418         * tui/tui-layout.c (show_layout): Set current_layout.
2419         (show_source_disasm_command, show_data)
2420         (show_source_or_disasm_and_command): Don't set current_layout.
2421
2422 2019-11-12  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2425
2426 2019-11-12  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-win.c (resize_message): New global.
2429         (show_tui_resize_message): New function.
2430         (tui_async_resize_screen): Print message if requested.
2431         (_initialize_tui_win): Add tui-resize-message setting.
2432         * NEWS: Add entry for new commands.
2433
2434 2019-11-11  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2437         functions.
2438
2439 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2440
2441         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2442
2443 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2446         function.
2447         * python/python-internal.h (gdbpy_lookup_static_symbols):
2448         Declare new function.
2449         * python/python.c (python_GdbMethods): Add
2450         gdb.lookup_static_symbols method.
2451         * NEWS: Mention gdb.lookup_static_symbols.
2452
2453 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2456         static block of current object file first.  Also fix typo in
2457         header comment.
2458
2459 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * stack.c (set_last_displayed_sal): Delete.
2462         (last_displayed_sal_valid): Delete.
2463         (last_displayed_pspace): Delete.
2464         (last_displayed_addr): Delete.
2465         (last_displayed_symtab): Delete.
2466         (last_displayed_line): Delete.
2467         (class last_displayed_symtab_info_type): New.
2468         (last_displayed_symtab_info): New static global variable.
2469         (print_frame_info): Call methods on last_displayed_symtab_info.
2470         (clear_last_displayed_sal): Update header comment, and make use of
2471         last_displayed_symtab_info.
2472         (last_displayed_sal_is_valid): Likewise.
2473         (get_last_displayed_pspace): Likewise.
2474         (get_last_displayed_addr): Likewise.
2475         (get_last_displayed_symtab): Likewise.
2476         (get_last_displayed_line): Likewise.
2477         (get_last_displayed_sal): Likewise.
2478         * stack.h (clear_last_displayed_sal): Update header comment.
2479         (last_displayed_sal_is_valid): Likewise.
2480         (get_last_displayed_pspace): Likewise.
2481         (get_last_displayed_addr): Likewise.
2482         (get_last_displayed_symtab): Likewise.
2483         (get_last_displayed_line): Likewise.
2484         (get_last_displayed_sal): Likewise.
2485
2486 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * stack.c (frame_show_address): Convert return type to bool.
2489         * stack.h (frame_show_address): Likewise, and update header
2490         comment.
2491
2492 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2495         * unittests/vec-utils-selftests.c: New file.
2496         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2497
2498 2019-11-10  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2501         (tui_highlight_win): Likewise.
2502         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2503         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2504         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2505         Don't set can_highlight.
2506
2507 2019-11-10  Tom Tromey  <tom@tromey.com>
2508
2509         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2510         Remove unused declaration.
2511
2512 2019-11-08  Tom Tromey  <tromey@adacore.com>
2513
2514         * top.c (read_command_file): Update.
2515         (command_line_input): Make return type const.
2516         * python/py-gdb-readline.c: Update.
2517         * linespec.c (decode_line_2): Update.
2518         * defs.h (command_line_input): Make return type const.
2519         * cli/cli-script.c (read_next_line): Make return type const.
2520         * ada-lang.c (get_selections): Update.
2521
2522 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2523
2524         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2525         * mi/mi-main.c (output_cores): Likewise.
2526         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2527         (linux_xfer_osdata_modules): Likewise.
2528         * remote.c (register_remote_support_xml): Likewise.
2529         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2530         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2531
2532 2019-11-06  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-interp.c: Don't include readline.h.
2535         * tui/tui-hooks.c: Don't include readline.h.
2536         * symmisc.c: Include tilde.h, not readline.h.
2537         * symfile.c: Include tilde.h, not readline.h.
2538         * source.c: Include tilde.h, not readline.h.
2539         * solib.c: Include tilde.h, not readline.h.
2540         * psymtab.c: Include tilde.h, not readline.h.
2541         * exec.c: Include tilde.h, not readline.h.
2542         * corelow.c: Include tilde.h, not readline.h.
2543         * cli/cli-dump.c: Include tilde.h, not readline.h.
2544         * cli/cli-cmds.c: Don't include readline.h.
2545
2546 2019-11-05  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2549         (tui_disassemble): Set addr_size.
2550         (tui_disasm_window::set_contents): Use addr_size.
2551
2552 2019-11-05  Tom Tromey  <tom@tromey.com>
2553
2554         * rust-lang.c (rust_language_defn): Update.
2555         * python/py-value.c (valpy_string): Call c_get_string.
2556         * p-lang.c (pascal_language_defn): Update.
2557         * opencl-lang.c (opencl_language_defn): Update.
2558         * objc-lang.c (objc_language_defn): Update.
2559         * m2-lang.c (m2_language_defn): Update.
2560         * language.c (unknown_language_defn, auto_language_defn): Update.
2561         (default_get_string): Remove.
2562         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2563         * go-lang.c (go_language_defn): Update.
2564         * f-lang.c (f_language_defn): Update.
2565         * d-lang.c (d_language_defn): Update.
2566         * c-lang.c (c_language_defn, cplus_language_defn)
2567         (asm_language_defn, minimal_language_defn): Update.
2568         * ada-lang.c (ada_language_defn): Update.
2569         * language.h (struct language_defn) <la_get_string>: Remove.
2570         (LA_GET_STRING): Remove.
2571         (default_get_string): Don't declare.
2572
2573 2019-11-05  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-source.h (struct tui_source_window): Inline
2576         constructor.  Remove destructor.
2577         <style_changed, m_observable>: Move to superclass.
2578         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2579         (struct tui_source_window_base): Move private members to end.
2580         <style_changed, m_observable>: Move from tui_source_window.
2581         * tui/tui-winsource.c (tui_copy_source_line): Move from
2582         tui-source.c.  Rename from copy_source_line.  Add special handling
2583         for negative line number.
2584         (tui_source_window_base::style_changed): Move from
2585         tui_source_window.
2586         (tui_source_window_base): Register observer.
2587         (~tui_source_window_base): New.
2588         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2589         rename.
2590         (tui_source_window::set_contents): Use tui_copy_source_line.
2591         (tui_source_window::tui_source_window): Move to tui-source.h.
2592         (tui_source_window::~tui_source_window): Remove.
2593         (tui_source_window::style_changed): Move to superclass.
2594         * tui/tui-disasm.c (tui_disassemble): Create string file with
2595         styling, when possible.  Add "addr_size" parameter.
2596         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2597         Don't compute maximum size.
2598         (len_without_escapes): New function
2599
2600 2019-11-05  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2603         std::string.
2604         * tui/tui-winsource.c (tui_show_source_line): Update.
2605         * tui/tui-source.c (tui_source_window::set_contents): Update.
2606         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2607
2608 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2609
2610         * symtab.h (gdb_static_assert): Put && operator at the beginning
2611         of the line instead of the end.
2612
2613 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2614
2615         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2616         and sizeof (symbol).
2617         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2618
2619 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2620
2621         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2622         * configure.host: Mark *-*-solaris2.10* obsolete.
2623         * configure.tgt: Mark Solaris < 11 obsolete.
2624         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2625         Update target triplet.
2626
2627 2019-11-01  Tom Tromey  <tromey@adacore.com>
2628
2629         * utils.c (print_sys_errmsg): Simplify.
2630
2631 2019-11-01  Tom Tromey  <tromey@adacore.com>
2632
2633         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2634
2635 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2636
2637         * configure: Regenerate.
2638         * configure.ac: Remove check for strerror_r.
2639         * gdbsupport/common.m4: Check for strerror_r.
2640
2641 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2642
2643         PR gdb/25124
2644
2645         * arm-tdep.c (arm_per_objfile): Rename to ...
2646         (arm_per_bfd): ... this.
2647         (arm_objfile_data_key): Rename to ...
2648         (arm_bfd_data_key): ... this.
2649         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2650         data.
2651         (arm_record_special_symbol): Likewise.
2652
2653 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2654
2655         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2656         end.
2657         * c-typeprint.c (c_print_typedef): Likewise.
2658         * f-typeprint.c (f_print_typedef): Likewise.
2659         * m2-typeprint.c (m2_print_typedef): Likewise.
2660         * p-typeprint.c (pascal_print_typedef): Likewise.
2661         * rust-lang.c (rust_print_typedef): Likewise.
2662         * symtab.c (print_symbol_info): Print a newline after calling
2663         typedef_print.
2664
2665 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * symtab.c (info_module_cmdlist): New variable.
2668         (info_module_command): New function.
2669         (search_module_symbols): New function.
2670         (info_module_subcommand): New function.
2671         (struct info_modules_var_func_options): New struct.
2672         (info_modules_var_func_options_defs): New variable.
2673         (make_info_modules_var_func_options_def_group): New function.
2674         (info_module_functions_command): New function.
2675         (info_module_variables_command): New function.
2676         (info_module_var_func_command_completer): New function.
2677         (_initialize_symtab): Register new 'info module functions' and
2678         'info module variables' commands.
2679         * symtab.h (typedef symbol_search_in_module): New typedef.
2680         (search_module_symbols): Declare new function.
2681         * NEWS: Mention new commands.
2682
2683 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2686         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2687         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2688         MODULES_DOMAIN.
2689         (scan_partial_symbols): Only create partial module symbols for non
2690         declarations.
2691         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2692         and MODULES_DOMAIN.
2693         * symtab.c (search_domain_name): Likewise.
2694         (search_symbols): Likewise.
2695         (print_symbol_info): Likewise.
2696         (symtab_symbol_info): Likewise.
2697         (info_modules_command): New function.
2698         (_initialize_symtab): Register 'info modules' command.
2699         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2700         * NEWS: Mention new 'info modules' command.
2701
2702 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2703
2704         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2705         and $_gdb_maint_setting_str.
2706
2707 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2708
2709         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2710         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2711         (str_value_from_setting, gdb_setting_str_internal_fn)
2712         (gdb_maint_setting_str_internal_fn): New functions.
2713         (_initialize_cli_cmds): Define the new convenience functions.
2714         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2715         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2716
2717 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2718
2719         * agent.c (set_can_use_agent): When the setting is turned on,
2720         look up agent symbols if we don't have them yet.
2721         (agent_new_objfile): Don't look up agent symbols when the agent
2722         setting is off.
2723
2724 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2725
2726         * config.in: Regenerate.
2727
2728 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2729
2730         * configure: Regenerate.
2731         * configure.ac: Check for strerror_r.
2732         * gdbsupport/common-utils.h (safe_strerror): Change return value
2733         to const char * and document that this function is now threadsafe.
2734         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2735         thread_local and call strerror_r, if available.
2736         * utils.c (perror_string): Update.
2737         (print_sys_errmsg): Update.
2738
2739 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2740
2741         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2742         objfile_key.
2743         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2744         objfile to fetch per-bfd data.
2745         (arm_find_exidx_entry): Likewise.
2746
2747 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2748
2749         * gdbsupport/agent.c (debug_agent): Change type to bool.
2750         (use_agent): Likewise.
2751         (all_agent_symbols_look_up): Likewise.
2752         (agent_loaded_p): Change return value to bool.
2753         (agent_look_up_symbols): Update.
2754         (agent_capability_check): Change return value to bool.
2755         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2756         (debug_agent): Change type to bool.
2757         (use_agent): Likewise.
2758         (agent_capability_check): Change return value to bool.
2759
2760 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2761
2762         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2763         (build_minimal_symbol_hash_tables): Code to clear the table moved
2764         to clear_minimal_symbol_hash_tables.
2765         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2766         when needed.
2767
2768 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2769
2770         * infcmd.c: Remove includes.
2771         * infrun.c: Remove includes.
2772
2773 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2774
2775         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2776         (grow_vect): Remove declaration.
2777         (ada_type_of_array): Remove declaration.
2778         (ada_update_initial_language): Remove declaration.
2779         (ada_fold_name): Remove declaration.
2780         (ada_fill_in_ada_prototype): Remove declaration.
2781         (user_select_syms): Remove declaration.
2782         (get_selections): Remove declaration.
2783         (ada_tag_type): Remove declaration.
2784         (ada_value_tag): Remove declaration.
2785         (ada_is_others_clause): Remove declaration.
2786         (ada_in_variant): Remove declaration.
2787         (ada_value_struct_elt): Remove declaration.
2788         (ada_attribute_name): Remove declaration.
2789         (ada_system_address_type): Remove declaration.
2790         * ada-lang.c (ada_watch_location_expression): Make static.
2791         (GROW_VECT): Move here from ada-lang.h.
2792         (grow_vect): Make static.
2793         (ada_update_initial_language): Make static.
2794         (ada_fold_name): Make static.
2795         (ada_type_of_array): Make static.
2796         (encoded_ordered_before): Move up.
2797         (sort_choices): Move up.
2798         (print_signatures): Move up.
2799         (ada_print_symbol_signature): Move up.
2800         (get_selections): Move up and make static.
2801         (user_select_syms): Move up and make static.
2802         (ada_value_struct_elt): Move up and make static.
2803         (ada_tag_type): Make static.
2804         (ada_value_tag): Make static.
2805         (ada_is_others_clause): Make static.
2806         (ada_in_variant): Make static.
2807         (ada_attribute_name): Make static.
2808
2809 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2810
2811         * ada-lang.c: Remove includes.
2812         * ada-typeprint.c: Remove includes.
2813         * ada-valprint.c: Remove includes.
2814
2815 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * addrmap.c: Add static assertions of type size, moved from
2818         _initialize_addrmap.
2819         (_initialize_addrmap): Remove.
2820
2821 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2822
2823         * coffread.c (record_minimal_symbol): Update.
2824         (process_coff_symbol): Update.
2825         * dbxread.c (read_dbx_symtab): Update.
2826         * dwarf2read.c (add_partial_symbol): Update.
2827         (fixup_go_packaging): Update.
2828         (load_partial_dies): Update.
2829         (new_symbol): Update.
2830         * elfread.c (record_minimal_symbol): Change signature to use
2831         gdb::string_view instead of name+len.
2832         (elf_symtab_read): Update.
2833         (elf_rel_plt_read): Update.
2834         * mdebugread.c (parse_partial_symbols): Update.
2835         (handle_psymbol_enumerators): Update.
2836         (new_symbol): Update.
2837         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2838         to use gdb::string_view instead of name+len.
2839         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2840         * psympriv.h (add_psymbol_to_list): Likewise.
2841         * psymtab.c (add_psymbol_to_bcache): Likewise.
2842         (add_psymbol_to_list): Likewise.
2843         * stabsread.c (define_symbol): Update.
2844         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2845         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2846         (symbol_set_names): Likewise.
2847         * xcoffread.c (scan_xcoff_symtab): Update.
2848
2849 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2850
2851         * symtab.h (symbol_set_names): Document that copy_name must be
2852         set to true for non-nullterminated strings.
2853         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2854         linkage_name if the entry was not found and we need to demangle.
2855
2856 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2857
2858         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2859         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2860         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2861         * gdbsupport/gdb_binary_search.h: New file.
2862
2863 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2864
2865         * NEWS: Mention new --with-system-gdbinit-dir option.
2866         * config.in: Regenerate.
2867         * configure: Regenerate.
2868         * configure.ac: Add new option --with-system-gdbinit-dir.
2869         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2870         for a ".gdb" suffix.
2871         * main.c (get_init_files): Change system_gdbinit argument to
2872         a vector and return the files in SYSTEM_GDBINIT_DIR in
2873         addition to SYSTEM_GDBINIT.
2874         (captured_main_1): Update.
2875         (print_gdb_help): Update.
2876         * top.c (print_gdb_configuration): Also print the value of
2877         SYSTEM_GDBINIT_DIR.
2878
2879 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2880
2881         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2882         that takes gdb::string_view arguments.
2883
2884 2019-10-26  Tom de Vries  <tdevries@suse.de>
2885
2886         * aarch64-linux-tdep.c: Fix typos in comments.
2887         * aarch64-tdep.c: Same.
2888         * ada-lang.c: Same.
2889         * amd64-nat.c: Same.
2890         * arc-tdep.c: Same.
2891         * arch/aarch64-insn.c: Same.
2892         * block.c: Same.
2893         * breakpoint.h: Same.
2894         * btrace.h: Same.
2895         * c-varobj.c: Same.
2896         * cli/cli-decode.c: Same.
2897         * cli/cli-script.c: Same.
2898         * cli/cli-utils.h: Same.
2899         * coff-pe-read.c: Same.
2900         * coffread.c: Same.
2901         * compile/compile-cplus-symbols.c: Same.
2902         * compile/compile-object-run.c: Same.
2903         * completer.c: Same.
2904         * corelow.c: Same.
2905         * cp-support.c: Same.
2906         * demangle.c: Same.
2907         * dwarf-index-write.c: Same.
2908         * dwarf2-frame.c: Same.
2909         * dwarf2-frame.h: Same.
2910         * eval.c: Same.
2911         * frame-base.h: Same.
2912         * frame.h: Same.
2913         * gdbcmd.h: Same.
2914         * gdbtypes.h: Same.
2915         * gnu-nat.c: Same.
2916         * guile/scm-objfile.c: Same.
2917         * i386-tdep.c: Same.
2918         * i386-tdep.h: Same.
2919         * infcall.c: Same.
2920         * infcall.h: Same.
2921         * linux-nat.c: Same.
2922         * m68k-tdep.c: Same.
2923         * macroexp.c: Same.
2924         * memattr.c: Same.
2925         * mi/mi-cmd-disas.c: Same.
2926         * mi/mi-getopt.h: Same.
2927         * mi/mi-main.c: Same.
2928         * minsyms.c: Same.
2929         * nat/aarch64-sve-linux-sigcontext.h: Same.
2930         * objfiles.h: Same.
2931         * ppc-linux-nat.c: Same.
2932         * ppc-linux-tdep.c: Same.
2933         * ppc-tdep.h: Same.
2934         * progspace.h: Same.
2935         * prologue-value.h: Same.
2936         * python/py-evtregistry.c: Same.
2937         * python/py-instruction.h: Same.
2938         * record-btrace.c: Same.
2939         * record-full.c: Same.
2940         * remote.c: Same.
2941         * rs6000-tdep.c: Same.
2942         * ser-tcp.c: Same.
2943         * sol-thread.c: Same.
2944         * sparc-sol2-tdep.c: Same.
2945         * sparc64-tdep.c: Same.
2946         * stabsread.c: Same.
2947         * symfile.c: Same.
2948         * symtab.h: Same.
2949         * target.c: Same.
2950         * tracepoint.c: Same.
2951         * tui/tui-data.h: Same.
2952         * tui/tui-io.c: Same.
2953         * tui/tui-win.c: Same.
2954         * tui/tui.c: Same.
2955         * unittests/rsp-low-selftests.c: Same.
2956         * user-regs.h: Same.
2957         * utils.c: Same.
2958         * utils.h: Same.
2959         * valarith.c: Same.
2960         * valops.c: Same.
2961         * valprint.c: Same.
2962         * valprint.h: Same.
2963         * value.c: Same.
2964         * value.h: Same.
2965         * varobj.c: Same.
2966         * x86-nat.h: Same.
2967         * xtensa-tdep.c: Same.
2968
2969 2019-10-25  Ali Tamur <tamur@google.com>
2970
2971         * charset.c (find_charset_names): Reflect API change.
2972
2973 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2974
2975         * symtab.c (struct demangled_name_entry): Change demangled name
2976         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2977         part of the struct anymore.
2978         (symbol_set_names): No longer obstack allocate + copy the demangled
2979         name, just store the allocated name from bfd.
2980
2981 2019-10-25  Tom Tromey  <tromey@adacore.com>
2982
2983         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2984         (bsearch_cie_cmp, add_cie): Remove.
2985         (find_cie): Reimplement.
2986         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2987         (dwarf2_build_frame_info): Update.
2988
2989 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2990
2991         PR gdb/25126
2992         * symfile.c (reread_symbols): Call forget_cached_source_info to
2993         clear the stale source cache.
2994
2995 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2996
2997         * configure: Regenerate.
2998         * configure.ac: Remove code that sets python_has_threads.
2999
3000 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
3001
3002         * config.in: Regenerate.
3003         * configure: Regenerate.
3004         * configure.ac: Remove the code that uses sed to get the python
3005         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
3006
3007 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * python/py-progspace.c (pspy_block_for_pc): Return None for all
3010         error paths.
3011
3012 2019-10-23  Tom Tromey  <tom@tromey.com>
3013
3014         * arc-tdep.c: Remove ".." from include.
3015         * frv-tdep.c: Remove ".." from include.
3016         * lm32-tdep.c: Remove ".." from include.
3017         * microblaze-tdep.c: Remove ".." from include.
3018         * or1k-tdep.h: Remove ".." from include.
3019         * s12z-tdep.c: Remove ".." from include.
3020         * Makefile.in (OPCODES_CFLAGS): Add comment.
3021         (TOP_CFLAGS): New variable.
3022         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3023
3024 2019-10-23  Tom Tromey  <tom@tromey.com>
3025
3026         * Makefile.in (READLINE_DIR): Update.
3027
3028 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3029
3030         * infcall.c (call_function_by_hand_dummy): Fix the function
3031         comment.  And extract out a code section into...
3032         (reserve_stack_space): ...this new function.
3033
3034 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3035
3036         * infcall.c (value_arg_coerce): Remove an unused parameter.
3037         (call_function_by_hand_dummy): Update the call to
3038         'value_arg_coerce'.
3039
3040 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3041
3042         * infcall.c (call_function_by_hand_dummy): Refactor.
3043
3044 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3045
3046         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3047
3048 2019-10-23  Tom Tromey  <tom@tromey.com>
3049
3050         * configure: Rebuild.
3051         * configure.ac: Don't check for sigprocmask.
3052         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3053
3054 2019-10-23  Tom Tromey  <tom@tromey.com>
3055
3056         * configure: Rebuild.
3057         * acinclude.m4: Use m4_include, not sinclude.
3058
3059 2019-10-23  Tom de Vries  <tdevries@suse.de>
3060
3061         PR breakpoints/24687
3062         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3063
3064 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3065
3066         * symtab.c (struct demangled_name_entry) <language>: Change from
3067         bitfield to regular variable.
3068
3069 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3070
3071         * symtab.c (struct demangled_name_entry): Add a constructor.
3072         (free_demangled_name_entry): New function to call the destructor
3073         for demangled_name_entry.
3074         (create_demangled_names_hash): Pass free_demangled_name_entry to
3075         htab_create_alloc.
3076         (symbol_set_names): Call placement new for demangled_name_entry.
3077         * utils.c: No longer include xxhash.h here, now that fast_hash
3078         is inlined in the header.
3079         * utils.h: Instead, include it here.
3080
3081 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3082
3083         * Makefile.in: Link with libxxhash.
3084         * config.in: Regenerate.
3085         * configure: Regenerate.
3086         * configure.ac: Search for libxxhash.
3087         * utils.c (fast_hash): Use xxhash if present.
3088
3089 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3090
3091         * utils.h (fast_hash): New function.
3092         * symtab.c (hash_demangled_name_entry): Call new function
3093         fast_hash.
3094
3095 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3096
3097         * symtab.c (struct demangled_name_entry): Change type of mangled
3098         to gdb::string_view. Also adds a constructor that takes the
3099         mangled name.
3100         (hash_demangled_name_entry): Update.
3101         (eq_demangled_name_entry): Update.
3102         (free_demangled_name_entry): New function to call the destructor
3103         now that this is not a POD anymore.
3104         (create_demangled_names_hash): Pass free_demangled_name_entry to
3105         htab_create_alloc.
3106         (symbol_set_names): Update.
3107
3108 2019-10-21  Ali Tamur  <tamu@google.com>
3109
3110         * dwarf2read.c (dir_index): Change type.
3111         (file_name_index): Likewise.
3112         (line_header::include_dir_at): Change comment and implementation on
3113         whether it is DWARF 5.
3114         (line_header::is_valid_file_index): New function.
3115         (line_header::file_name_at): Change comment and implementation on
3116         whether it is DWARF 5.
3117         (line_header::file_names): Change to private field renamed as
3118         m_file_names and introduce a new accessor method.
3119         (line_header::file_names_size): New method.
3120         (line_header::include_dirs): Change to private field and rename as
3121         m_include_dirs.
3122         (dw2_get_file_names_reader): Define local var at a smaller scope and
3123         reflect API change.
3124         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3125         (process_structure_scope): Likewise.
3126         (line_header::add_include_dir): Change message and reflect renaming.
3127         (line_header::add_file_name): Likewise.
3128         (read_formatted_entries): Handle DW_FORM_data16.
3129         (dwarf_decode_line_header): Fix line header length calculation.
3130         (psymtab_include_file_name): Change comment and API.
3131         (lnp_state_machine::m_file): Update comment and reflect type change.
3132         (lnp_state_machine::record_line): Reflect type change.
3133         (dwarf_decode_lines): Reflect API change.
3134         (file_file_name): Likewise.
3135         (file_full_name): Likewise.
3136
3137 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3140
3141 2019-10-21  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3144
3145 2019-10-21  Tom Tromey  <tom@tromey.com>
3146
3147         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3148         NM_H.   Use AC_CONFIG_LINKS.
3149         * configure: Rebuild.
3150         * Makefile.in (NM_H): New variable.
3151         (generated_files): Add NM_H.  Remove gcore.
3152         (nm.h, stamp-nmh): New targets.
3153
3154 2019-10-20  Tom Tromey  <tom@tromey.com>
3155
3156         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3157         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3158         obsolete comment.
3159         (put_objfile_before): Now static.
3160
3161 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3162
3163         * gdbsupport/common-utils.h (startswith): Change return type to
3164         bool.
3165
3166 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3167
3168         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3169         * breakpoint.c (bp_locations_compare): Rename to...
3170         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3171         (update_global_location_list): Use std::sort instead of qsort.
3172         * buildsym.c (compare_line_numbers): Rename to...
3173         (lte_is_less_than): ...this, and change to std::sort semantics.
3174         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3175         instead of qsort.
3176         * disasm.c (compare_lines): Rename to...
3177         (line_is_less_than): ...this, and change to std::sort semantics.
3178         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3179         of qsort.
3180         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3181         (fde_is_less_than): ...this, and change to std::sort semantics.
3182         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3183         * mdebugread.c (compare_blocks):
3184         (block_is_less_than): ...this, and change to std::sort semantics.
3185         (sort_blocks): Call std::sort instead of qsort.
3186         * objfiles.c (qsort_cmp): Rename to...
3187         (sort_cmp): ...this, and change to std::sort semantics.
3188         (update_section_map): Call std::sort instead of qsort.
3189         * remote.c (compare_pnums): Remove.
3190         (map_regcache_remote_table): Call std::sort instead of qsort.
3191         * utils.c (compare_positive_ints): Remove.
3192         * utils.h (compare_positive_ints): Remove.
3193         * xcoffread.c (compare_lte): Remove.
3194         (arrange_linetable): Call std::sort instead of qsort.
3195
3196 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3197
3198         * symfile.c (init_entry_point_info): Fix typo.
3199         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3200
3201 2019-10-18  Tom de Vries  <tdevries@suse.de>
3202
3203         * aarch64-tdep.c: Fix typos in comments.
3204         * ada-lang.c: Same.
3205         * ada-tasks.c: Same.
3206         * alpha-tdep.c: Same.
3207         * alpha-tdep.h: Same.
3208         * amd64-nat.c: Same.
3209         * amd64-windows-tdep.c: Same.
3210         * arc-tdep.c: Same.
3211         * arc-tdep.h: Same.
3212         * arch-utils.c: Same.
3213         * arm-nbsd-tdep.c: Same.
3214         * arm-tdep.c: Same.
3215         * ax-gdb.c: Same.
3216         * blockframe.c: Same.
3217         * btrace.c: Same.
3218         * c-varobj.c: Same.
3219         * coff-pe-read.c: Same.
3220         * coffread.c: Same.
3221         * cris-tdep.c: Same.
3222         * darwin-nat.c: Same.
3223         * dbxread.c: Same.
3224         * dcache.c: Same.
3225         * disasm.c: Same.
3226         * dtrace-probe.c: Same.
3227         * dwarf-index-write.c: Same.
3228         * dwarf2-frame-tailcall.c: Same.
3229         * dwarf2-frame.c: Same.
3230         * dwarf2read.c: Same.
3231         * eval.c: Same.
3232         * exceptions.c: Same.
3233         * fbsd-tdep.c: Same.
3234         * findvar.c: Same.
3235         * frame.c: Same.
3236         * frv-tdep.c: Same.
3237         * gnu-v3-abi.c: Same.
3238         * go32-nat.c: Same.
3239         * h8300-tdep.c: Same.
3240         * hppa-tdep.c: Same.
3241         * i386-linux-tdep.c: Same.
3242         * i386-tdep.c: Same.
3243         * ia64-libunwind-tdep.c: Same.
3244         * ia64-tdep.c: Same.
3245         * infcmd.c: Same.
3246         * infrun.c: Same.
3247         * linespec.c: Same.
3248         * linux-nat.c: Same.
3249         * linux-thread-db.c: Same.
3250         * machoread.c: Same.
3251         * mdebugread.c: Same.
3252         * mep-tdep.c: Same.
3253         * mn10300-tdep.c: Same.
3254         * namespace.c: Same.
3255         * objfiles.c: Same.
3256         * opencl-lang.c: Same.
3257         * or1k-tdep.c: Same.
3258         * osabi.c: Same.
3259         * ppc-linux-nat.c: Same.
3260         * ppc-linux-tdep.c: Same.
3261         * ppc-sysv-tdep.c: Same.
3262         * printcmd.c: Same.
3263         * procfs.c: Same.
3264         * record-btrace.c: Same.
3265         * record-full.c: Same.
3266         * remote-fileio.c: Same.
3267         * remote.c: Same.
3268         * rs6000-tdep.c: Same.
3269         * s12z-tdep.c: Same.
3270         * score-tdep.c: Same.
3271         * ser-base.c: Same.
3272         * ser-go32.c: Same.
3273         * skip.c: Same.
3274         * sol-thread.c: Same.
3275         * solib-svr4.c: Same.
3276         * solib.c: Same.
3277         * source.c: Same.
3278         * sparc-nat.c: Same.
3279         * sparc-sol2-tdep.c: Same.
3280         * sparc-tdep.c: Same.
3281         * sparc64-tdep.c: Same.
3282         * stabsread.c: Same.
3283         * stack.c: Same.
3284         * symfile.c: Same.
3285         * symtab.c: Same.
3286         * target-descriptions.c: Same.
3287         * target-float.c: Same.
3288         * thread.c: Same.
3289         * utils.c: Same.
3290         * valops.c: Same.
3291         * valprint.c: Same.
3292         * value.c: Same.
3293         * varobj.c: Same.
3294         * windows-nat.c: Same.
3295         * xcoffread.c: Same.
3296         * xstormy16-tdep.c: Same.
3297         * xtensa-tdep.c: Same.
3298
3299 2019-10-17  Tom Tromey  <tromey@adacore.com>
3300
3301         * configure: Rebuild.
3302         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3303         in AC_CONFIG_FILES invocation.
3304         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3305         new-style config.status invocation.
3306
3307 2019-10-17  Tom de Vries  <tdevries@suse.de>
3308
3309         * arm-nbsd-nat.c: Fix typos in comments.
3310         * arm-tdep.c: Same.
3311         * darwin-nat-info.c: Same.
3312         * dwarf2read.c: Same.
3313         * elfread.c: Same.
3314         * event-top.c: Same.
3315         * findvar.c: Same.
3316         * gdbtypes.c: Same.
3317         * hppa-tdep.c: Same.
3318         * i386-tdep.c: Same.
3319         * jit.c: Same.
3320         * main.c: Same.
3321         * mdebugread.c: Same.
3322         * moxie-tdep.c: Same.
3323         * nto-procfs.c: Same.
3324         * osabi.c: Same.
3325         * ppc-linux-tdep.c: Same.
3326         * remote.c: Same.
3327         * riscv-tdep.c: Same.
3328         * s390-tdep.c: Same.
3329         * sh-tdep.c: Same.
3330         * sparc-linux-tdep.c: Same.
3331         * sparc-nat.c: Same.
3332         * stack.c: Same.
3333         * target-descriptions.c: Same.
3334         * top.c: Same.
3335         * varobj.c: Same.
3336
3337 2019-10-16  Tom Tromey  <tom@tromey.com>
3338
3339         * objfiles.h (struct objfile) <original_name>: Now const.
3340
3341 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3342
3343         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3344         pass on to sigsetjmp's second argument.
3345         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3346
3347 2019-10-16  Keith Seitz  <keiths@redhat.com>
3348
3349         PR gdb/23567
3350         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3351         sections whose size is greater than the file size.
3352
3353 2019-10-16  Jim Wilson  <jimw@sifive.com>
3354
3355         * riscv-tdep.c (riscv_gcc_target_options): New.
3356         (riscv_gnu_triplet_regexp): New.
3357         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3358         set_gdbarch_gnu_triplet_regexp.
3359
3360 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3361
3362         * Makefile.in: Add xml-builtin.h.
3363         * features/feature_to_c.sh: Add an include for xml-builtin.h
3364         to ensure that the compiler checks that the types match.
3365         * xml-builtin.h: New file.
3366         * xml-support.c (fetch_xml_builtin): Add missing const.
3367         * xml-support.h: Remove declaration of xml_builtins.
3368
3369 2019-10-16  Tom de Vries  <tdevries@suse.de>
3370
3371         PR tdep/25096
3372         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3373         (amd64_classify_aggregate): ... here.
3374         (amd64_classify_aggregate_field): Handled fiels of nested structs
3375         recursively.
3376
3377 2019-10-16  Tom de Vries  <tdevries@suse.de>
3378
3379         PR tdep/24104
3380         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3381         that handles 'theclass'.
3382
3383 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * linespec.c (decode_digits_ordinary): Update comment.
3386         * make-target-delegates: No longer need to handle VEC case.
3387         * memrange.c (normalize_mem_ranges): Update comment.
3388         * namespace.c (add_using_directive): Update comment.
3389         * objc-lang.c (uniquify_strings): Update comment.
3390         * ppc-linux-nat.c (struct thread_points): Update comment.
3391         * probe.h (find_probes_in_objfile): Update comment.
3392         * target.h (enum flash_preserve_mode): Update comment.
3393         * varobj.c (varobj_restrict_range): Update comment.
3394         * varobj.h (varobj_list_children): Update comment.
3395
3396 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * Makefile.in: Remove references to vec.h and vec.c.
3399         * aarch64-tdep.c: No longer include vec.h.
3400         * ada-lang.c: Likewise.
3401         * ada-lang.h: Likewise.
3402         * arm-tdep.c: Likewise.
3403         * ax.h: Likewise.
3404         * breakpoint.h: Likewise.
3405         * charset.c: Likewise.
3406         * cp-support.h: Likewise.
3407         * dtrace-probe.c: Likewise.
3408         * dwarf2read.c: Likewise.
3409         * extension.h: Likewise.
3410         * gdb_bfd.c: Likewise.
3411         * gdbsupport/gdb_vecs.h: Likewise.
3412         * gdbsupport/vec.c: Remove.
3413         * gdbsupport/vec.h: Remove.
3414         * gdbthread.h: Likewise.
3415         * guile/scm-type.c: Likewise.
3416         * inline-frame.c: Likewise.
3417         * machoread.c: Likewise.
3418         * memattr.c: Likewise.
3419         * memrange.h: Likewise.
3420         * namespace.h: Likewise.
3421         * nat/linux-btrace.h: Likewise.
3422         * osdata.c: Likewise.
3423         * parser-defs.h: Likewise.
3424         * progspace.h: Likewise.
3425         * python/py-type.c: Likewise.
3426         * record-btrace.c: Likewise.
3427         * rust-exp.y: Likewise.
3428         * solib-target.c: Likewise.
3429         * stap-probe.c: Likewise.
3430         * target-descriptions.c: Likewise.
3431         * target-memory.c: Likewise.
3432         * target.h: Likewise.
3433         * varobj.c: Likewise.
3434         * varobj.h: Likewise.
3435         * xml-support.h: Likewise.
3436
3437 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3438
3439         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3440         Update for new std::vector based implementation.
3441         (process_psymtab_comp_unit_reader): Likewise.
3442         (scan_partial_symbols): Likewise.
3443         (recursively_compute_inclusions): Likewise.
3444         (compute_compunit_symtab_includes): Likewise.
3445         (process_imported_unit_die): Likewise.
3446         (queue_and_load_dwo_tu): Likewise.
3447         (follow_die_sig_1): Likewise.
3448         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3449         (typedef dwarf2_per_cu_ptr): Remove.
3450         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3451         function.
3452         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3453         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3454         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3455         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3456         std::vector.
3457
3458 2019-10-15  Tom Tromey  <tromey@adacore.com>
3459
3460         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3461         TID.
3462
3463 2019-10-15  Tom Tromey  <tromey@adacore.com>
3464
3465         * windows-nat.c (windows_nat_target::fetch_registers)
3466         (windows_nat_target::store_registers): Rename "pid" to "tid".
3467
3468 2019-10-15  Tom Tromey  <tromey@adacore.com>
3469
3470         * gdbarch.h, gdbarch.c: Rebuild.
3471         * gdbarch.sh (gcc_target_options): Change return type to
3472         std::string.
3473         * compile/compile.c (get_args): Update.
3474         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3475         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3476         std::string.
3477         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3478         std::string.
3479         * arch-utils.c (default_gcc_target_options): Return std::string.
3480         * arch-utils.h (default_gcc_target_options): Return std::string.
3481         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3482
3483 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3484
3485         * breakpoint.c (breakpoint_chain): Make static.
3486         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3487         of accessing breakpoint_chain.
3488
3489 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3490
3491         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3492         to a gdb::function_view and return value to bool.
3493         * breakpoint.h (iterate_over_breakpoints): Likewise.
3494         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3495         (pop_dummy_frame): Update.
3496         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3497         (gdbscm_breakpoints): Update.
3498         * python/py-breakpoint.c (build_bp_list): Update.
3499         (gdbpy_breakpoints): Update.
3500         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3501         Update.
3502         (bpfinishpy_handle_stop): Update.
3503         (bpfinishpy_handle_exit): Update.
3504         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3505         (svr4_update_solib_event_breakpoints): Update.
3506
3507 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3508
3509         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3510         when unwrapping single-field structs.
3511
3512 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3513
3514         * dwarf2read.c: Remove includes.
3515
3516 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3517
3518         * ui-out.c (ui_out::call_do_message): Silence
3519         -Wformat-nonliteral warning.
3520
3521 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3522
3523         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3524         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3525         include: readline/tilde.h.
3526
3527 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3528
3529         * remote.c (remote_target::get_trace_status): Remove declaration of
3530         trace_regblock_size.
3531
3532 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3533
3534         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3535         (show_user): Remove declaration of cmdlist.
3536         * cli/cli-cmds.h (max_user_call_depth): Declare.
3537         * cli/cli-script.c (execute_user_command): Remove declaration
3538         of max_user_call_depth.
3539
3540 2019-10-11  Jim Wilson  <jimw@sifive.com>
3541
3542         * gdbsupport/print-utils.h (pulongest): Fix comment.
3543         (plongest): Likewise.
3544         (phex): Add missing comment, mention leading zeros.
3545         (phex_nz): Add mention of no leading zeros to comment.
3546
3547         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3548         plongest instead of unsigned long long cast.
3549
3550 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3551
3552         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3553         for external_editor_command and gdbtk_test.
3554
3555 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3556
3557         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3558         * varobj.c (varobjdebug): Move comment to...
3559         * varobj.h (varobjdebug): ...here, and declare.
3560
3561 2019-10-09  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3564         erase_data_content.
3565
3566 2019-10-09  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3569         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3570         * tui/tui-command.c (tui_cmd_window::resize)
3571         (tui_refresh_cmd_win): Update.
3572         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3573         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3574         * tui/tui-data.c (~tui_gen_win_info): Remove.
3575         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3576         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3577         (tui_redisplay_readline, tui_mld_flush)
3578         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3579         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3580         (tui_data_window::erase_data_content)
3581         (tui_data_item_window::rerender)
3582         (tui_data_item_window::refresh_window): Update.
3583         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3584         (box_win, tui_gen_win_info::make_window)
3585         (tui_gen_win_info::make_visible): Update.
3586         (tui_delete_win): Remove.
3587         * tui/tui-winsource.c
3588         (tui_source_window_base::do_erase_source_content): Update.
3589         (tui_show_source_line, tui_source_window_base::update_tab_width)
3590         (tui_source_window_base::update_exec_info): Update.
3591         * tui/tui-data.h (struct curses_deleter): New.
3592         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3593         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3594
3595 2019-10-09  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3598
3599 2019-10-09  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3602         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3603
3604 2019-10-09  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3607         window height directly.
3608         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3609         declare.
3610         * tui/tui-layout.c (tui_default_win_height): Remove.
3611         (tui_default_win_viewport_height): Remove.
3612
3613 2019-10-09  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui.h: Remove comments.
3616
3617 2019-10-09  Tom de Vries  <tdevries@suse.de>
3618
3619         * python/lib/gdb/printer/bound_registers.py: Use
3620         '^builtin_type_bound128' as regexp argument for
3621         add_builtin_pretty_printer.
3622
3623 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3624
3625         * guile/guile.c (guile_extension_script_ops): Remove forward
3626         declaration and mark as static.
3627         (guile_script_ops): Likewise.
3628         (extension_language_guile): Move further down in the file so
3629         it can reference the definitions for guile_{extension_,}script_ops.
3630
3631 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3632
3633         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3634         except SORTL, DFLTCC, and KDSA.
3635
3636 2019-10-08  Tom Tromey  <tromey@adacore.com>
3637
3638         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3639         (struct safe_symbol_file_add_args): Remove.
3640
3641 2019-10-08  Tom Tromey  <tromey@adacore.com>
3642
3643         * windows-nat.c: Don't include buildsym-legacy.h.
3644
3645 2019-10-08  Tom Tromey  <tromey@adacore.com>
3646
3647         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3648
3649 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3650
3651         * gdbtypes.c (overload_debug): Move comment to header.
3652         * gdbtypes.h (overload_debug): Declare.
3653         * valops.c: Remove declaration of overload_debug, instead
3654         include gdbtypes.h.
3655
3656 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3657
3658         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3659         through _().
3660         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3661         move comment...
3662         * language.h (lang_frame_mismatch_warn): ... here. Also add
3663         declaration.
3664         * top.c (lang_frame_mismatch_warn): Remove declaration.
3665         (check_frame_language_change): Pass lang_frame_mismatch_warn
3666         through _().
3667
3668 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3669
3670         * c-lang.h (vtbl_ptr_name): Declare.
3671         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3672         it from the header.
3673         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3674
3675 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3676
3677         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3678         gdb_static_assert.
3679
3680 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3681
3682         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3683         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3684         * ctfread.c: New file.
3685         * ctfread.h: New file.
3686         * elfread.c: Include ctfread.h.
3687         (struct elfinfo text_p): New member ctfsect.
3688         (elf_locate_sections): Mark CTF section.
3689         (elf_symfile_read): Call elfctf_build_psymtabs.
3690         * Makefile.in (LIBCTF): Add.
3691         (CLIBS): Use it.
3692         (CDEPS): Likewise.
3693         (DIST): Add ctfread.c.
3694
3695 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * ctfread.c (struct nextfield): Renamed to ...
3698         (struct ctf_nextfield): ... this.
3699         (struct field_info): Renamed to ...
3700         (strut ctf_field_info): ... this.
3701         (attach_fields_to_type): Update for renamed structures.
3702         (ctf_add_member_cb): Likewise.
3703         (ctf_add_enum_member_cb): Likewise.
3704         (process_struct_members): Likewise.
3705         (process_enum_type): Likewise.
3706
3707 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3708
3709         * tracectf.h: Rename, was ctf.h.
3710         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3711         * tracefile.c: Likewise.
3712         * tracepoint.c: Remove unused include ctf.h.
3713         * mi/mi-main.c: Likewise.
3714         * Makefile.in Replace ctf.c with tracectf.c.
3715
3716 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3717
3718         * version.in: Change version number to "9.0.50.DATE-git".
3719
3720 2019-10-03  Tom Tromey  <tom@tromey.com>
3721
3722         PR rust/24976:
3723         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3724
3725 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3728         cp_search_name_hash.
3729         * NEWS: Add entry about nested function support.
3730
3731 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3732             Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3735         for nested static variables when searchin VAR_DOMAIN.
3736         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3737         global scope, update comment.
3738         (add_partial_subprogram): Call add_partial_subprogram recursively
3739         for nested subroutines when processinng Fortran.
3740         (load_partial_dies): Process the child entities of a subprogram
3741         when processing Fortran.
3742         (partial_die_parent_scope): Handle building scope
3743         for Fortran nested functions.
3744         (process_die): Record that nested functions have a scope.
3745         (new_symbol): Always record Fortran subprograms on the global
3746         symbol list.
3747         (determine_prefix): How to build the prefix for Fortran
3748         subprograms.
3749
3750 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3753         have just sent the thread a SIGSTOP and are waiting for it to
3754         arrive.
3755
3756 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3757
3758         * btrace.c (btrace_add_pc): Remove whitespace before the template
3759         parameter in 'std::vector <...>'.
3760         (parse_xml_btrace_block): Likewise.
3761         (btrace_maint_decode_pt): Likewise.
3762         (btrace_maint_update_packets): Likewise.
3763         (btrace_maint_print_packets): Likewise.
3764         * btrace.h (struct btrace_maint_info): Likewise.
3765         * dwarf2read.c (struct type_unit_group): Likewise.
3766         (build_type_psymtabs_reader): Likewise.
3767         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3768         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3769         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3770
3771 2019-10-03  Tom de Vries  <tdevries@suse.de>
3772
3773         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3774         the first line of the help text for set/show style metadata.
3775
3776 2019-10-02  Tom Tromey  <tromey@adacore.com>
3777
3778         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3779         * gdbsupport/common-inferior.c: New file.
3780         * infcmd.c (startup_with_shell): Don't define.
3781         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3782         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3783         * inferior.h (startup_with_shell): Don't declare.
3784
3785 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3786
3787         * gdbsupport/gdb_assert.h: Include errors.h.
3788         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3789
3790 2019-10-02  Tom Tromey  <tromey@adacore.com>
3791
3792         * NEWS: Add $_ada_exception entry.
3793         * ada-lang.c (struct ada_catchpoint): Add constructor.
3794         <m_kind>: New member.
3795         (allocate_location_exception, re_set_exception): Remove
3796         "ex" parameter.
3797         (should_stop_exception): Compute $_ada_exception.
3798         (check_status_exception, print_it_exception)
3799         (print_one_exception, print_mention_exception): Remove
3800         "ex" parameter.
3801         (allocate_location_catch_exception, re_set_catch_exception)
3802         (check_status_exception, print_it_catch_exception)
3803         (print_one_catch_exception, print_mention_catch_exception)
3804         (print_recreate_catch_exception)
3805         (allocate_location_catch_exception_unhandled)
3806         (re_set_catch_exception_unhandled)
3807         (check_status_exception, print_it_catch_exception_unhandled)
3808         (print_one_catch_exception_unhandled)
3809         (print_mention_catch_exception_unhandled)
3810         (print_recreate_catch_exception_unhandled)
3811         (allocate_location_catch_assert, re_set_catch_assert)
3812         (check_status_assert, print_it_catch_assert)
3813         (print_one_catch_assert, print_mention_catch_assert)
3814         (print_recreate_catch_assert)
3815         (allocate_location_catch_handlers, re_set_catch_handlers)
3816         (check_status_handlers, print_it_catch_handlers)
3817         (print_one_catch_handlers, print_mention_catch_handlers)
3818         (print_recreate_catch_handlers): Remove.
3819         (create_ada_exception_catchpoint): Update.
3820         (initialize_ada_catchpoint_ops): Update.
3821
3822 2019-10-02  Tom Tromey  <tromey@adacore.com>
3823
3824         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3825         (create_excep_cond_exprs): Simplify exception string computation.
3826         (ada_exception_catchpoint_cond_string): Likewise.
3827
3828 2019-10-02  Tom Tromey  <tromey@adacore.com>
3829
3830         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3831         * ada-lang.c (lesseq_defined_than): Handle
3832         LOC_STATIC.
3833         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3834         parameter.
3835         (dwarf2_has_info): Likewise.
3836         (new_symbol): Set maybe_copied on symbol when
3837         appropriate.
3838         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3839         parameter.
3840         <can_copy>: New member.
3841         * elfread.c (record_minimal_symbol): Set maybe_copied
3842         on symbol when appropriate.
3843         (elf_symfile_read): Update call to dwarf2_has_info.
3844         * minsyms.c (lookup_minimal_symbol_linkage): New
3845         function.
3846         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3847         * symtab.c (get_symbol_address, get_msymbol_address):
3848         New functions.
3849         * symtab.h (get_symbol_address, get_msymbol_address):
3850         Declare.
3851         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3852         maybe_copied.
3853         (struct symbol, struct minimal_symbol) <maybe_copied>:
3854         New member.
3855
3856 2019-10-02  Tom Tromey  <tromey@adacore.com>
3857
3858         * source.c (struct current_source_location): New.
3859         (current_source_key): New global.
3860         (current_source_symtab, current_source_line)
3861         (current_source_pspace): Remove.
3862         (get_source_location): New function.
3863         (get_current_source_symtab_and_line)
3864         (set_default_source_symtab_and_line)
3865         (set_current_source_symtab_and_line)
3866         (clear_current_source_symtab_and_line, select_source_symtab)
3867         (info_source_command, print_source_lines_base)
3868         (info_line_command, search_command_helper, _initialize_source):
3869         Update.
3870
3871 2019-10-02  Tom Tromey  <tromey@adacore.com>
3872
3873         * source.c (select_source_symtab): Don't call
3874         decode_line_with_current_source.
3875
3876 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * symtab.c (lookup_global_symbol): Search global block.
3879
3880 2019-10-02  Tom Tromey  <tromey@adacore.com>
3881
3882         * coffread.c (process_coff_symbol): Update.
3883         * dwarf2read.c (var_decode_location, new_symbol): Update.
3884         * mdebugread.c (parse_symbol): Update.
3885         * objfiles.c (relocate_one_symbol): Update.
3886         * stabsread.c (define_symbol, fix_common_block)
3887         (scan_file_globals): Update.
3888         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3889         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3890         * xcoffread.c (process_xcoff_symbol): Update.
3891
3892 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3893
3894         * MAINTAINERS: Update my email address.
3895
3896 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3899         std::vector.
3900         (build_type_psymtabs_reader): Update for std::vector.
3901         (build_type_psymtab_dependencies): Likewise.
3902         * dwarf2read.h: Remove use of DEF_VEC_P.
3903         (typedef sig_type_ptr): Delete.
3904
3905 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3908         to std::vector.
3909         (btrace_maint_decode_pt): Likewise, and move allocation of the
3910         vector outside of the loop.
3911         (btrace_maint_update_packets): Update to handle change from VEC to
3912         std::vector.
3913         (btrace_maint_print_packets): Likewise.
3914         (maint_info_btrace_cmd): Likewise.
3915         * btrace.h: Remove use of DEF_VEC_O.
3916         (typedef btrace_pt_packet_s): Delete.
3917         (struct btrace_maint_info) <packets>: Change fromm VEC to
3918         std::vector.
3919         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3920
3921 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3924         make accesses into the vector constant references.
3925         (btrace_add_pc): Update for std::vector.
3926         (btrace_stitch_bts): Likewise.
3927         (parse_xml_btrace_block): Likewise.
3928         (btrace_maint_update_packets): Likewise.
3929         (btrace_maint_print_packets): Likewise.
3930         (maint_info_btrace_cmd): Likewise.
3931         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3932         std::vector.
3933         (btrace_data::empty): Likewise.
3934         (btrace_data_append): Likewise.
3935         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3936         (typedef btrace_block_s): Delete.
3937         (struct btrace_block): Add constructor.
3938         (struct btrace_data_bts) <blocks>: Change to std::vector.
3939         * nat/linux-btrace.c (perf_event_read_bts): Update for
3940         std::vector.
3941         (linux_read_bts): Likewise.
3942
3943 2019-10-01  Tom Tromey  <tom@tromey.com>
3944
3945         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3946
3947 2019-10-01  Tom Tromey  <tom@tromey.com>
3948
3949         * stack.c (print_frame, info_frame_command_core): Use
3950         styled_string.
3951         * linux-thread-db.c (try_thread_db_load_1)
3952         (try_thread_db_load_from_pdir_1): Use styled_string.
3953         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3954         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3955         (maybe_print_unsupported_script_warning)
3956         (maybe_print_script_not_found_warning): Use styled_string.
3957         * ada-lang.c (user_select_syms): Use styled_string.
3958
3959 2019-10-01  Tom Tromey  <tom@tromey.com>
3960
3961         * p-lang.c (pascal_printstr): Use metadata style.
3962         * value.c (show_convenience): Use metadata style.
3963         * valprint.c (valprint_check_validity, val_print_optimized_out)
3964         (val_print_not_saved, val_print_unavailable)
3965         (val_print_invalid_address, generic_val_print, val_print)
3966         (value_check_printable, val_print_array_elements): Use metadata
3967         style.
3968         * ui-out.h (class ui_out) <field_fmt>: New overload.
3969         <do_field_fmt>: Add style parameter.
3970         * ui-out.c (ui_out::field_fmt): New overload.
3971         * typeprint.c (type_print_unknown_return_type)
3972         (val_print_not_allocated, val_print_not_associated): Use metadata
3973         style.
3974         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3975         parameter.
3976         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3977         * tracepoint.c (tvariables_info_1): Use metadata style.
3978         * stack.c (print_frame_arg, print_frame_info, print_frame)
3979         (info_frame_command_core): Use metadata style.
3980         * skip.c (info_skip_command): Use metadata style.
3981         * rust-lang.c (rust_print_enum): Use metadata style.
3982         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3983         metadata style.
3984         * python/py-framefilter.c (py_print_single_arg): Use metadata
3985         style.
3986         * printcmd.c (do_one_display, print_variable_and_value): Use
3987         metadata style.
3988         * p-valprint.c (pascal_val_print)
3989         (pascal_object_print_value_fields): Use metadata style.
3990         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3991         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3992         parameter.
3993         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3994         * m2-valprint.c (m2_print_long_set): Use metadata style.
3995         * m2-typeprint.c (m2_print_type): Use metadata style.
3996         * infcmd.c (print_return_value_1): Use metadata style.
3997         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3998         * f-valprint.c (info_common_command_for_block): Use metadata
3999         style.
4000         * f-typeprint.c (f_type_print_base): Use metadata style.
4001         * expprint.c (print_subexp_standard): Use metadata style.
4002         * cp-valprint.c (cp_print_value_fields): Use metadata style.
4003         * cli/cli-style.h (class cli_style_option): Add constructor.
4004         (metadata_style): Declare.
4005         * cli/cli-style.c (metadata_style): New global.
4006         (_initialize_cli_style): Register metadata style.
4007         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
4008         parameter.
4009         * cli-out.c (cli_ui_out::do_field_fmt): Update.
4010         * c-typeprint.c (c_type_print_base_struct_union)
4011         (c_type_print_base_1): Use metadata style.
4012         * breakpoint.c (watchpoint_value_print)
4013         (print_one_breakpoint_location): Use metadata style.
4014         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4015         style.
4016         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4017         style.
4018         * ada-valprint.c (val_print_packed_array_elements, printstr)
4019         (print_field_values, ada_val_print_ref, ada_val_print): Use
4020         metadata style.
4021         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4022         style.
4023         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4024         style.
4025         * ada-lang.c (user_select_syms): Use metadata style.
4026
4027 2019-10-01  Tom Tromey  <tom@tromey.com>
4028
4029         * cli/cli-cmds.c (pwd_command): Style output.
4030
4031 2019-10-01  Pedro Alves  <palves@redhat.com>
4032             Tom Tromey  <tom@tromey.com>
4033
4034         * symtab.c (print_symbol_info): Use %ps.
4035         (print_msymbol_info): Use %ps.
4036         * symfile.c (symbol_file_add_with_addrs): Use %ps.
4037         * printcmd.c (print_variable_and_value): Use %ps.
4038         * macrocmd.c (show_pp_source_pos): Use %ps.
4039         * infrun.c (print_exited_reason): Use ui_out::message.
4040         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4041         (describe_other_breakpoints): Use ui_out::message and new
4042         formats.
4043         (say_where): Use new formats.
4044         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4045         and new formats.
4046
4047 2019-10-01  Pedro Alves  <palves@redhat.com>
4048             Tom Tromey  <tom@tromey.com>
4049
4050         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4051         (test_gdb_formats): New function.
4052         (run_tests): Call it.
4053         (test_format_specifier): Update.
4054         * utils.h (fputs_filtered): Update comment.
4055         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4056         (fputs_styled_unfiltered): Declare.
4057         * utils.c (fputs_styled_unfiltered): New function.
4058         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4059         (vfprintf_filtered): Update.
4060         (vfprintf_unfiltered, vprintf_filtered): Update.
4061         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4062         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4063         disallow_ui_out_field>: New constants.
4064         (enum class field_kind): New.
4065         (struct base_field_s, struct signed_field_s): New.
4066         (signed_field): New function.
4067         (struct string_field_s): New.
4068         (string_field): New function.
4069         (struct styled_string_s): New.
4070         (styled_string): New function.
4071         (class ui_out) <message>: Add comment.
4072         <vmessage, call_do_message>: New methods.
4073         <do_message>: Add style parameter.
4074         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4075         methods.
4076         (ui_out::message): Rewrite.
4077         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4078         parameter.
4079         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4080         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4081         gdb_extensions parameter.
4082         (class format_piece): Add parameter to constructor.
4083         (n_int_args): New field.
4084         * gdbsupport/format.c (format_pieces::format_pieces): Add
4085         gdb_extensions parameter.  Handle '*'.
4086         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4087         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4088         vfprintf_styled_no_gdbfmt.
4089         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4090         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4091         unfiltered output.
4092         * ui-style.h (struct ui_file_style) <ptr>: New method.
4093
4094 2019-10-01  Tom Tromey  <tom@tromey.com>
4095
4096         * unittests/format_pieces-selftests.c: Update.  Add final format.
4097         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4098         empty literal pieces.
4099
4100 2019-10-01  Tom Tromey  <tom@tromey.com>
4101
4102         * ui-out.h (enum class ui_out_style_kind): Remove.
4103         (class ui_out) <field_string, field_stsream, do_field_string>:
4104         Change type of "style".
4105         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4106         (ui_out::field_string): Update.
4107         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4108         of "style".
4109         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4110         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4111         * stack.c (print_frame_arg, print_frame_info, print_frame):
4112         Update.
4113         * source.c (print_source_lines_base): Update.
4114         * solib.c (info_sharedlibrary_command): Update.
4115         * skip.c (info_skip_command): Update.
4116         * record-btrace.c (btrace_call_history_src_line)
4117         (btrace_call_history): Update.
4118         * python/py-framefilter.c (py_print_frame): Update.
4119         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4120         "style".
4121         * mi/mi-out.c (mi_ui_out::do_table_header)
4122         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4123         (mi_ui_out::do_field_string): Update.
4124         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4125         Update.
4126         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4127         "style".
4128         * cli-out.c (cli_ui_out::do_table_header)
4129         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4130         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4131         (cli_ui_out::do_field_fmt): Update.
4132         * breakpoint.c (print_breakpoint_location): Update.
4133         (update_static_tracepoint): Update.
4134
4135 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4136
4137         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4138         conversion of gdb_datadir.
4139         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4140         remove not needed c_str ().
4141
4142 2019-09-30  Ali Tamur <tamur@google.com>
4143
4144         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4145         (dwarf2_string_attr): Likewise.
4146
4147 2019-09-30  Ali Tamur <tamur@google.com>
4148
4149         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4150         (process_full_type_unit): Likewise.
4151         (dump_die_shallow): Likewise.
4152         (cu_debug_loc_section): Likewise.
4153
4154 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4155
4156         * minsyms.c (compare_minimal_symbols): Rename to...
4157         (minimal_symbol_is_less_than): ...this, and adjust to STL
4158         conventions (return bool, take arguments as references)
4159         (minimal_symbol_reader::install): Call std::sort instead
4160         of qsort.
4161
4162 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4163
4164         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4165         hash and why.
4166         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4167         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4168
4169 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4170
4171         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4172         * psympriv.h (add_psymbol_to_list): Move comment here and update
4173         it.
4174
4175 2019-09-29  Tom de Vries  <tdevries@suse.de>
4176
4177         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4178         Use $tmpdir/$(basename "$output_file").dwz instead of
4179         "${output_file}.dwz".
4180
4181 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4182
4183         PR gdb/25045
4184         * hppa-linux-nat.c: Include gdbarch.h.
4185
4186 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4187
4188         * blockframe.c (find_pc_partial_function): Change return type to bool.
4189         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4190         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4191         (stub_gnu_ifunc_resolve_name): Likewise.
4192         * symtab.c (compare_filenames_for_search): Likewise.
4193         (compare_glob_filenames_for_search): Likewise.
4194         (matching_obj_sections): Likewise.
4195         (symbol_matches_domain): Likewise.
4196         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4197         (find_line_pc): Change return type to bool.
4198         (find_line_pc_range): Likewise.
4199         (producer_is_realview): Likewise.
4200         * symtab.h (symbol_matches_domain): Likewise.
4201         (find_pc_partial_function): Likewise.
4202         (find_pc_line_pc_range): Likewise.
4203         (in_gnu_ifunc_stub): Likewise.
4204         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4205         (find_line_pc): Likewise.
4206         (find_line_pc_range): Likewise.
4207         (matching_obj_sections): Likewise.
4208         (find_line_symtab): Change out parameter to bool.
4209         (producer_is_realview): Change return type to bool.
4210         (compare_filenames_for_search): Likewise.
4211         (compare_glob_filenames_for_search): Likewise.
4212
4213 2019-09-26  Tom Tromey  <tom@tromey.com>
4214
4215         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4216         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4217         * gdb_usleep.h: Remove.
4218         * gdb_usleep.c: Remove.
4219         * utils.c: Don't include gdb_usleep.h.
4220
4221 2019-09-26  Tom Tromey  <tromey@adacore.com>
4222
4223         * python/py-type.c (type_to_type_object): Call check_typedef
4224         for stub types.
4225
4226 2019-09-26  Tom Tromey  <tom@tromey.com>
4227
4228         * utils.h (initialize_utils): Don't declare.
4229         * top.c (gdb_init): Don't call initialize_utils.
4230         * utils.c (initialize_utils): Remove.  Move contents...
4231         (_initialize_utils): ... here.
4232
4233 2019-09-25  Tom Tromey  <tom@tromey.com>
4234
4235         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4236         * utils.h (make_hex_string): Don't declare.
4237         * utils.c (make_hex_string): Remove.
4238
4239 2019-09-24  Tom de Vries  <tdevries@suse.de>
4240
4241         PR gdb/23815
4242         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4243         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4244
4245 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4246
4247         * NEWS: Mention new simulator port for PRU.
4248
4249 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4250
4251         * ada-exp.y (write_object_remaining): Update.
4252         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4253         and eliminate the static buffer.
4254         (ada_decode_symbol): Update.
4255         (ada_la_decode): Update.
4256         (ada_sniff_from_mangled_name): Update.
4257         (is_valid_name_for_wild_match): Update.
4258         (ada_lookup_name_info::matches): Update and simplify.
4259         (name_matches_regex): Update.
4260         (ada_add_global_exceptions): Update.
4261         * ada-lang.h (ada_decode): Update signature.
4262         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4263         * dwarf-index-write.c (debug_names::insert): Update.
4264
4265 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4266
4267         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4268         formatting.
4269
4270 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4271
4272         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4273         Change "nonzero" to "true" in documentation.
4274
4275 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4276
4277         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4278         (_initialize_darwin_solib): Don't set
4279         darwin_so_ops.lookup_lib_global_symbol.
4280         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4281         set_gdbarch_iterate_over_objfiles_in_search_order.
4282         (elf_lookup_lib_symbol): Rename to...
4283         (svr4_iterate_over_objfiles_in_search_order): this, and update
4284         to iterate semantics.
4285         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4286         * solib.c (solib_global_lookup): Remove.
4287         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4288         (solib_global_lookup): Remove.
4289         * symtab.c (lookup_global_or_static_symbol): Remove call to
4290         solib_global_lookup.
4291
4292 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4293
4294         * NEWS: Move entries about default MI version now being
4295         version 3, and about the GDB/MI fix for multi-location
4296         breakpoints to the "since GDB 8.3" section.
4297
4298 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4299
4300         GDB 8.3.1 released.
4301
4302 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4303
4304         * NEWS: Mention that Cell/B.E. debugging support was removed.
4305         * MAINTAINERS: Remove spu target.
4306
4307         * config/djgpp/fnchange.lst: Remove entries for removed files.
4308
4309         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4310         spu-multiarch.o, and spu-tdep.o.
4311         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4312         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4313         spu-multiarch.c, and spu-tdep.c.
4314         * spu-linux-nat.c: Remove file.
4315         * spu-multiarch.c: Remove file.
4316         * spu-tdep.c: Remove file.
4317         * spu-tdep.h: Remove file.
4318         * solib-spu.c: Remove file.
4319         * solib-spu.h: Remove file.
4320
4321         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4322         * configure.nat (spu-linux): Remove.
4323         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4324         solib-multiarch.o from gdb_target_obs.
4325         (spu*-*-*): Remove.
4326
4327         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4328         feature flag.
4329         (ppc_linux_no_features): Update.
4330         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4331         Cell/B.E. support.
4332         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4333         (tdesc_powerpc_cell64l): Likewise.
4334         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4335         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4336         Cell/B.E. support.
4337         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4338         Do not include "features/rs6000/powerpc-cell32l.c" or
4339         "features/rs6000/powerpc-cell64l.c".
4340         (ppc_linux_spu_section): Remove.
4341         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4342         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4343         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4344         (ppc_linux_spe_context_lookup): Remove.
4345         (ppc_linux_spe_context_inferior_created): Remove.
4346         (ppc_linux_spe_context_solib_loaded): Remove.
4347         (ppc_linux_spe_context_solib_unloaded): Remove.
4348         (ppc_linux_spe_context): Remove.
4349         (struct ppu2spu_cache): Remove.
4350         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4351         (struct ppu2spu_data): Remove.
4352         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4353         ppu2spu_unwind): Remove.
4354         (ppc_linux_init_abi): Remove Cell/B.E. support.
4355         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4356
4357         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4358         (rs6000/powerpc-cell64l-expedite): Likewise
4359         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4360         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4361         rs6000/powerpc-cell64l.xml.
4362         * features/rs6000/powerpc-cell32l.xml: Remove.
4363         * features/rs6000/powerpc-cell64l.xml: Likewise.
4364         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4365         * features/rs6000/powerpc-cell64l.c: Likewise.
4366         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4367         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4368         * regformats/reg-spu.dat: Remove.
4369
4370         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4371         * corelow.c (struct spuid_list): Remove.
4372         (add_to_spuid_list): Remove.
4373         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4374         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4375         (remote_protocol_features): Remove associated entries.
4376         (_initialize_remote): No longer initialize them.
4377         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4378         * linux-nat.c (SPUFS_MAGIC): Remove.
4379         (linux_proc_xfer_spu): Remove.
4380         (spu_enumerate_spu_ids): Remove.
4381         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4382         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4383         (linux_make_corefile_notes): No longer call it.
4384
4385         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4386         (cooked_write_test): Likewise.
4387
4388 2019-09-20  Tom Tromey  <tom@tromey.com>
4389
4390         * NEWS: Mention case-sensitivity of TUI commands.
4391         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4392         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4393         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4394
4395 2019-09-20  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-source.c (tui_source_window::set_contents): Use
4398         make_unique_xstrdup.
4399         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4400         make_unique_xstrdup.
4401
4402 2019-09-20  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-data.c: Remove separator comments.
4405         * tui/tui-layout.c: Remove separator comments.
4406         * tui/tui-win.c: Remove separator comments.
4407         * tui/tui-wingeneral.c: Remove separator comments.
4408
4409 2019-09-20  Tom Tromey  <tom@tromey.com>
4410
4411         * tui/tui.h (strcat_to_buf): Don't declare.
4412         * tui/tui.c (strcat_to_buf): Remove.
4413
4414 2019-09-20  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4417         from "fullname".
4418         * tui/tui-source.c (tui_source_window::set_contents)
4419         (tui_source_window::location_matches_p)
4420         (tui_source_window::maybe_update): Update.
4421
4422 2019-09-20  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4425         Update.
4426         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4427         prefix.
4428         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4429         (tui_data_window::line_from_reg_element_no)
4430         (tui_data_window::first_reg_element_no_inline)
4431         (tui_data_window::show_registers)
4432         (tui_data_window::show_register_group)
4433         (tui_data_window::display_registers_from)
4434         (tui_data_window::display_registers_from_line)
4435         (tui_data_window::first_data_item_displayed)
4436         (tui_data_window::delete_data_content_windows)
4437         (tui_data_window::erase_data_content)
4438         (tui_data_window::do_scroll_vertical)
4439         (tui_data_window::refresh_window)
4440         (tui_data_window::check_register_values): Update.
4441
4442 2019-09-20  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4445         (struct tui_locator_window) <full_name, proc_name>: Now
4446         std::string.
4447         * tui/tui-stack.c (tui_locator_window::make_status_line)
4448         (tui_locator_window::set_locator_fullname)
4449         (tui_locator_window::set_locator_info): Update.
4450         * tui/tui-source.c (tui_source_window::set_contents)
4451         (tui_source_window::showing_source_p): Update.
4452
4453 2019-09-20  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4456         Don't call tui_locator_win_info_ptr.
4457
4458 2019-09-20  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4461
4462 2019-09-20  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4465         height for locator.
4466         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4467         * tui/tui-layout.c (show_source_disasm_command, show_data)
4468         (show_source_or_disasm_and_command): Use 1 as height for locator.
4469
4470 2019-09-20  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui.c (tui_enable): Update.
4473         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4474         Update.
4475         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4476         Update.
4477         * tui/tui-data.c (win_resized): Now bool.
4478         (tui_win_resized): Return bool.
4479         (tui_set_win_resized_to): Accept a bool.
4480
4481 2019-09-20  Tom Tromey  <tom@tromey.com>
4482
4483         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4484         Change type of "refresh_values_only".
4485         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4486         type of "refresh_values_only".
4487
4488 2019-09-20  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4491         std::string.
4492         (tui_disassemble): Add "pos" parameter.
4493         (tui_disasm_window::set_contents): Simplify.
4494
4495 2019-09-20  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-winsource.h (struct tui_source_window_base)
4498         <show_source_content>: Now private.
4499         * tui/tui-winsource.c
4500         (tui_source_window_base::show_source_content): Don't handle empty
4501         content case.
4502
4503 2019-09-20  Tom Tromey  <tom@tromey.com>
4504
4505         * tui/tui-layout.c (show_source_disasm_command)
4506         (show_source_or_disasm_and_command): Don't call
4507         show_source_content.
4508
4509 2019-09-20  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4512         Declare.
4513         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4514         from tui_make_status_line.
4515         (tui_locator_window::rerender): Update.
4516
4517 2019-09-20  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4520         (tui_locator_window::rerender): Update.
4521
4522 2019-09-20  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-winsource.h (struct tui_source_window_base)
4525         <~tui_source_window_base>: Don't declare.
4526         <fullname>: Remove.
4527         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4528         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4529         member.
4530         * tui/tui-source.c (tui_source_window::set_contents): Update.
4531         (tui_source_window::location_matches_p)
4532         (tui_source_window::maybe_update): Update.
4533
4534 2019-09-20  Tom Tromey  <tom@tromey.com>
4535
4536         * tui/tui-winsource.h (~tui_source_element): Remove.
4537         (tui_source_element): Update.
4538         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4539         * tui/tui-winsource.c (tui_show_source_line): Update.
4540         * tui/tui-source.c (tui_source_window::set_contents): Update.
4541         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4542
4543 2019-09-20  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4546         declare.
4547         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4548         tui_clear_source_windows_detail.
4549         * tui/tui-winsource.h (struct tui_source_window_base)
4550         <clear_detail>: Don't declare.
4551         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4552         Remove.
4553         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4554
4555 2019-09-20  Tom Tromey  <tromey@adacore.com>
4556
4557         PR ada/24919:
4558         * block.c (contained_in): Fix final return value.
4559
4560 2019-09-20  Alan Modra  <amodra@gmail.com>
4561
4562         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4563         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4564         (read_indirect_string_from_dwz): Use bfd accessor.
4565         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4566         * machoread.c (macho_symfile_read_all_oso): Likewise.
4567         * solib.c (solib_bfd_open): Likewise.
4568
4569 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4570
4571         * eval.c: Move declaration of overload_resolution to...
4572         * value.h: ...here.
4573
4574 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4575
4576         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4577         * arm-linux-tdep.c: Likewise.
4578         * arm-nbsd-nat.c: Likewise.
4579         * arm-tdep.h: Declare arm_apcs_32.
4580         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4581
4582 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4583
4584         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4585         * dwarf2read.h: Declare dwarf_always_disassemble.
4586
4587 2019-09-19  Tom de Vries  <tdevries@suse.de>
4588
4589         PR gdb/25009
4590         * source-cache.c (source_cache::ensure): Catch exception thrown during
4591         construction of the highlighter.
4592
4593 2019-09-18  Alan Modra  <amodra@gmail.com>
4594
4595         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4596         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4597         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4598         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4599         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4600         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4601         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4602         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4603         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4604         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4605         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4606         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4607         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4608         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4609         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4610         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4611         * mi/mi-interp.c: Update throughout for bfd section macro and
4612         function changes.
4613         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4614         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4615
4616 2019-09-18  Tom Tromey  <tom@tromey.com>
4617
4618         * NEWS: Add entry.
4619         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4620         call rl_initialize.
4621         (tui_enable): Do not call rl_initialize.
4622
4623 2019-09-18  Christian Groessler  <chris@groessler.org>
4624
4625         * alpha-linux-nat.c: Include gdbarch.h.
4626
4627 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4628
4629         * ui-file.c: Include cli/cli-style.h.
4630         (term_cli_styling): Remove cli_styling declaration.
4631
4632 2019-09-18  Alan Modra  <amodra@gmail.com>
4633
4634         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4635         to bfd_asymbol_section.
4636
4637 2019-09-18  Alan Modra  <amodra@gmail.com>
4638
4639         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4640         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4641         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4642
4643 2019-09-18  Alan Modra  <amodra@gmail.com>
4644
4645         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4646         * spu-linux-nat.c (spu_bfd_open): Likewise.
4647
4648 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4649
4650         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4651         to bool to match definition in dwarf2read.c.
4652
4653 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4654
4655         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4656         (print_signatures): Likewise.
4657         (trust_pad_over_xvs): Likewise.
4658         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4659         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4660         * arm-linux-nat.c (arm_apcs_32): Likewise.
4661         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4662         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4663         * arm-tdep.c (arm_debug): Likewise.
4664         (arm_apcs_32): Likewise.
4665         * auto-load.c (debug_auto_load): Likewise.
4666         (auto_load_gdb_scripts): Likewise.
4667         (global_auto_load): Likewise.
4668         (auto_load_local_gdbinit): Likewise.
4669         (auto_load_local_gdbinit_loaded): Likewise.
4670         * auto-load.h (global_auto_load): Likewise.
4671         (auto_load_local_gdbinit): Likewise.
4672         (auto_load_local_gdbinit_loaded): Likewise.
4673         * breakpoint.c (disconnected_dprintf): Likewise.
4674         (breakpoint_proceeded): Likewise.
4675         (automatic_hardware_breakpoints): Likewise.
4676         (always_inserted_mode): Likewise.
4677         (target_exact_watchpoints): Likewise.
4678         (_initialize_breakpoint): Update.
4679         * breakpoint.h (target_exact_watchpoints): Change to bool.
4680         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4681         * cli/cli-cmds.c (trace_commands): Likewise.
4682         * cli/cli-cmds.h (trace_commands): Likewise.
4683         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4684         to bool*.
4685         * cli/cli-logging.c (logging_overwrite): Change to bool.
4686         (logging_redirect): Likewise.
4687         (debug_redirect): Likewise.
4688         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4689         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4690         to bool.
4691         <boolean_option_def>: Update.
4692         (struct flag_option_def): Change default type of Context to bool
4693         from int.
4694         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4695         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4696         (get_setshow_command_value_string): Likewise.
4697         * cli/cli-style.c (cli_styling): Change to bool.
4698         (source_styling): Likewise.
4699         * cli/cli-style.h (source_styling): Likewise.
4700         (cli_styling): Likewise.
4701         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4702         to bool.
4703         * command.h (var_types): Update comment.
4704         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4705         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4706         bool.
4707         (debug_compile_cplus_scopes): Likewise.
4708         * compile/compile-internal.h (compile_debug): Likewise.
4709         * compile/compile.c (compile_debug): Likewise.
4710         (struct compile_options) <raw>: Likewise.
4711         * cp-support.c (catch_demangler_crashes): Likewise.
4712         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4713         (usr_cmd_cris_dwarf2_cfi): Likewise.
4714         * csky-tdep.c (csky_debug): Likewise.
4715         * darwin-nat.c (enable_mach_exceptions): Likewise.
4716         * dcache.c (dcache_enabled_p): Likewise.
4717         * defs.h (info_verbose): Likewise.
4718         * demangle.c (demangle): Likewise.
4719         (asm_demangle): Likewise.
4720         * dwarf-index-cache.c (debug_index_cache): Likewise.
4721         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4722         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4723         * dwarf2read.c (check_physname): Likewise.
4724         (use_deprecated_index_sections): Likewise.
4725         (dwarf_always_disassemble): Likewise.
4726         * eval.c (overload_resolution): Likewise.
4727         * event-top.c (set_editing_cmd_var): Likewise.
4728         (exec_done_display_p): Likewise.
4729         * event-top.h (set_editing_cmd_var): Likewise.
4730         (exec_done_display_p): Likewise.
4731         * exec.c (write_files): Likewise.
4732         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4733         (debug_fbsd_nat): Likewise.
4734         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4735         Likewise.
4736         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4737         <backtrace_past_entry> Likewise.
4738         * gdb-demangle.h (demangle): Likewise.
4739         (asm_demangle): Likewise.
4740         * gdb_bfd.c (bfd_sharing): Likewise.
4741         * gdbcore.h (write_files): Likewise.
4742         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4743         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4744         * gdbthread.h (print_thread_events): Likewise.
4745         * gdbtypes.c (opaque_type_resolution): Likewise.
4746         (strict_type_checking): Likewise.
4747         * gnu-nat.c (gnu_debug_flag): Likewise.
4748         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4749         * guile/scm-param.c (pascm_variable): Add boolval.
4750         (add_setshow_generic): Update.
4751         (pascm_param_value): Update.
4752         (pascm_set_param_value_x): Update.
4753         * hppa-tdep.c (hppa_debug): Change to bool..
4754         * infcall.c (may_call_functions_p): Likewise.
4755         (coerce_float_to_double_p): Likewise.
4756         (unwind_on_signal_p): Likewise.
4757         (unwind_on_terminating_exception_p): Likewise.
4758         * infcmd.c (startup_with_shell): Likewise.
4759         * inferior.c (print_inferior_events): Likewise.
4760         * inferior.h (startup_with_shell): Likewise.
4761         (print_inferior_events): Likewise.
4762         * infrun.c (step_stop_if_no_debug): Likewise.
4763         (detach_fork): Likewise.
4764         (debug_displaced): Likewise.
4765         (disable_randomization): Likewise.
4766         (non_stop): Likewise.
4767         (non_stop_1): Likewise.
4768         (observer_mode): Likewise.
4769         (observer_mode_1): Likewise.
4770         (set_observer_mode): Update.
4771         (sched_multi): Change to bool.
4772         * infrun.h (debug_displaced): Likewise.
4773         (sched_multi): Likewise.
4774         (step_stop_if_no_debug): Likewise.
4775         (non_stop): Likewise.
4776         (disable_randomization): Likewise.
4777         * linux-tdep.c (use_coredump_filter): Likewise.
4778         (dump_excluded_mappings): Likewise.
4779         * linux-thread-db.c (auto_load_thread_db): Likewise.
4780         (check_thread_db_on_load): Likewise.
4781         * main.c (captured_main_1): Update.
4782         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4783         xx2_opt, boolean_opt>: Change to bool.
4784         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4785         * maint.c (maintenance_profile_p): Likewise.
4786         (per_command_time): Likewise.
4787         (per_command_space): Likewise.
4788         (per_command_symtab): Likewise.
4789         * memattr.c (inaccessible_by_default): Likewise.
4790         * mi/mi-main.c (mi_async): Likewise.
4791         (mi_async_1): Likewise.
4792         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4793         * nat/fork-inferior.h (startup_with_shell): Likewise.
4794         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4795         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4796         * nios2-tdep.c (nios2_debug): Likewise.
4797         * or1k-tdep.c (or1k_debug): Likewise.
4798         * parse.c (parser_debug): Likewise.
4799         * parser-defs.h (parser_debug): Likewise.
4800         * printcmd.c (print_symbol_filename): Likewise.
4801         * proc-api.c (procfs_trace): Likewise.
4802         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4803         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4804         (set_parameter_value): Update.
4805         (add_setshow_generic): Update.
4806         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4807         to bool*.
4808         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4809         int*.
4810         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4811         * record-btrace.c (record_btrace_target::store_registers): Update.
4812         * record-full.c (record_full_memory_query): Change to bool.
4813         (record_full_stop_at_limit): Likewise.
4814         * record-full.h (record_full_memory_query): Likewise.
4815         * remote-notif.c (notif_debug): Likewise.
4816         * remote-notif.h (notif_debug): Likewise.
4817         * remote.c (use_range_stepping): Likewise.
4818         (interrupt_on_connect): Likewise.
4819         (remote_break): Likewise.
4820         * ser-tcp.c (tcp_auto_retry): Likewise.
4821         * ser-unix.c (serial_hwflow): Likewise.
4822         * skip.c (debug_skip): Likewise.
4823         * solib-aix.c (solib_aix_debug): Likewise.
4824         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4825         (spu_auto_flush_cache_p): Likewise.
4826         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4827         Likewise.
4828         (struct info_print_options) <quiet>: Likewise.
4829         * symfile-debug.c (debug_symfile): Likewise.
4830         * symfile.c (auto_solib_add): Likewise.
4831         (separate_debug_file_debug): Likewise.
4832         * symfile.h (auto_solib_add): Likewise.
4833         (separate_debug_file_debug): Likewise.
4834         * symtab.c (basenames_may_differ): Likewise.
4835         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4836         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4837         (struct info_types_options) <quiet>: Likewise.
4838         * symtab.h (demangle): Likewise.
4839         (basenames_may_differ): Likewise.
4840         * target-dcache.c (stack_cache_enabled_1): Likewise.
4841         (code_cache_enabled_1): Likewise.
4842         * target.c (trust_readonly): Likewise.
4843         (may_write_registers): Likewise.
4844         (may_write_memory): Likewise.
4845         (may_insert_breakpoints): Likewise.
4846         (may_insert_tracepoints): Likewise.
4847         (may_insert_fast_tracepoints): Likewise.
4848         (may_stop): Likewise.
4849         (auto_connect_native_target): Likewise.
4850         (target_stop_and_wait): Update.
4851         (target_async_permitted): Change to bool.
4852         (target_async_permitted_1): Likewise.
4853         (may_write_registers_1): Likewise.
4854         (may_write_memory_1): Likewise.
4855         (may_insert_breakpoints_1): Likewise.
4856         (may_insert_tracepoints_1): Likewise.
4857         (may_insert_fast_tracepoints_1): Likewise.
4858         (may_stop_1): Likewise.
4859         * target.h (target_async_permitted): Likewise.
4860         (may_write_registers): Likewise.
4861         (may_write_memory): Likewise.
4862         (may_insert_breakpoints): Likewise.
4863         (may_insert_tracepoints): Likewise.
4864         (may_insert_fast_tracepoints): Likewise.
4865         (may_stop): Likewise.
4866         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4867         (make_thread_apply_all_options_def_group): Change argument from int*
4868         to bool*.
4869         (thread_apply_all_command): Update.
4870         (print_thread_events): Change to bool.
4871         * top.c (confirm): Likewise.
4872         (command_editing_p): Likewise.
4873         (history_expansion_p): Likewise.
4874         (write_history_p): Likewise.
4875         (info_verbose): Likewise.
4876         * top.h (confirm): Likewise.
4877         (history_expansion_p): Likewise.
4878         * tracepoint.c (disconnected_tracing): Likewise.
4879         (circular_trace_buffer): Likewise.
4880         * typeprint.c (print_methods): Likewise.
4881         (print_typedefs): Likewise.
4882         * utils.c (debug_timestamp): Likewise.
4883         (sevenbit_strings): Likewise.
4884         (pagination_enabled): Likewise.
4885         * utils.h (sevenbit_strings): Likewise.
4886         (pagination_enabled): Likewise.
4887         * valops.c (overload_resolution): Likewise.
4888         * valprint.h (struct value_print_options) <prettyformat_arrays,
4889         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4890         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4891         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4892         Likewise.
4893         * windows-nat.c (new_console): Likewise.
4894         (cygwin_exceptions): Likewise.
4895         (new_group): Likewise.
4896         (debug_exec): Likewise.
4897         (debug_events): Likewise.
4898         (debug_memory): Likewise.
4899         (debug_exceptions): Likewise.
4900         (useshell): Likewise.
4901         * windows-tdep.c (maint_display_all_tib): Likewise.
4902         * xml-support.c (debug_xml): Likewise.
4903
4904 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4905
4906         * source.c (prepare_path_for_appending): New function.
4907         (openp): Make use of new function.
4908         (find_and_open_source): Search for the compilation directory and
4909         source file as a relative path beneath the directory search path.
4910
4911 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4912
4913         * source-cache.c (source_cache::get_line_charpos): Catch
4914         exceptions and return false, this matches the behaviour documented
4915         in the header file.
4916
4917 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4918
4919         * ada-tasks.c (info_task): Remove quoting of the task's name.
4920
4921 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4922
4923         * symfile.c (auto_solib_add): Replace comment with a reference
4924         to the header file.
4925
4926 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4927
4928         * NEWS: Mention that gdb can now be compiled with Python 3
4929         on Windows.
4930
4931 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4932
4933         * maint.c (maint_print_section_data::maint_print_section_data):
4934         Force use of 'float log10 (float)' by casting the argument to
4935         float.
4936
4937 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * maint.c: Add 'cmath' include.
4940         (struct maint_print_section_data): New structure.
4941         (print_section_index): New function.
4942         (print_bfd_section_info): Add header comment, small whitespace
4943         cleanup, and update to call new print_section_index function.
4944         (print_objfile_section_info): Likewise.
4945         (maint_obj_section_from_bfd_section): New function.
4946         (print_bfd_section_info_maybe_relocated): New function.
4947         (maintenance_info_sections): Add header comment, always use
4948         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4949
4950 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4953         inner scope, add check that the objfile has psymtabs before
4954         checking psymtabs_addrmap.
4955         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4956
4957 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4958
4959         * NEWS: Announce that Ada task names are now shown at more places,
4960         and between quotes (except in info task output).
4961         * gdb/ada-tasks.c (task_to_str): New function.
4962         (display_current_task_id): Call task_to_str.
4963         (task_command_1): Likewise.
4964         (print_ada_task_info): In non-mi mode, Properly align headers and data
4965         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4966
4967 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4968
4969         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4970         prstatus.pr_lwp.pr_info instead of making it up.
4971
4972 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4973
4974         * auto-load.c (auto_load_expand_dir_vars): Update.
4975         * defs.h (gdb_datadir): Change to std::string.
4976         (python_libdir): Likewise.
4977         (relocate_gdb_directory): Change return type to std::string.
4978         * guile/guile.c (gdbscm_data_directory): Update.
4979         (initialize_scheme_side): Update.
4980         * jit.c (jit_reader_dir): Change to std::string.
4981         (jit_reader_load_command): Update.
4982         * main.c (gdb_datadir): Change to std::string.
4983         (python_libdir): Likewise.
4984         (set_gdb_data_directory): Update.
4985         (relocate_path): Change to return std::string.
4986         (relocate_gdb_directory): Change to return std::string.
4987         (relocate_gdbinit_path_maybe_in_datadir): Update.
4988         (captured_main_1): Update.
4989         * python/python.c (do_start_initialization): Update.
4990         * top.c (show_gdb_datadir): Update.
4991         * xml-syscall.c (xml_init_syscalls_info): Update.
4992         (init_syscalls_info): Update.
4993
4994 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4995
4996         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4997         out of get_init_files.
4998         (get_init_files): Update.
4999
5000 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5001
5002         * main.c (get_init_files): Change to use std::string.
5003         (captured_main_1): Update.
5004         (print_gdb_help): Update.
5005
5006 2019-09-11  Ali Tamur  <tamur@google.com>
5007
5008         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
5009         implementation.
5010
5011 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
5012
5013         * dbxread.c (read_dbx_symtab): Update.
5014         * dwarf2read.c (load_partial_dies): Update.
5015         * mdebugread.c (parse_partial_symbols): Update.
5016         (handle_psymbol_enumerators): Update.
5017         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5018         * psymtab.c (add_psymbol_to_bcache): Likewise.
5019         (add_psymbol_to_list): Likewise.
5020         * symtab.c (symbol_set_names): Likewise.
5021         * symtab.h (symbol_set_names): Likewise.
5022         * xcoffread.c (scan_xcoff_symtab): Update.
5023
5024 2019-09-11  Tom Tromey  <tom@tromey.com>
5025
5026         * symfile-mem.c (symbol_file_add_from_memory): Use
5027         bfd_set_filename.
5028         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5029         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5030
5031 2019-09-10  Tom Tromey  <tromey@adacore.com>
5032
5033         * dwarf-index-write.c (write_psymbols): Extend error message.
5034         (debug_names::insert): Add Ada code.
5035         (debug_names::write_psymbols): Remove Ada check.
5036         (debug_names) <m_string_obstack>: New member.
5037         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5038         (gdb_index_symbol_name_matcher::matches): Remove.
5039         (mapped_index_base::find_name_components_bounds): Add "lang"
5040         parameter.
5041         (mapped_index_base::build_name_components): Also split names
5042         according to Ada syntax.
5043         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
5044         type of "match_callback".
5045         (check_match, check_find_bounds_finds)
5046         (dw2_expand_symtabs_matching): Update.
5047         (dw2_debug_names_iterator): Add new constructor.
5048         (dw2_debug_names_map_matching_symbols): New function.
5049         (dw2_debug_names_expand_symtabs_matching): Update.
5050         (dwarf2_debug_names_functions): Use
5051         dw2_debug_names_map_matching_symbols.
5052
5053 2019-09-10  Tom Tromey  <tromey@adacore.com>
5054
5055         * dwarf2read.c (dw2_get_file_names_reader): Add the
5056         CU's file name to the results.
5057
5058 2019-09-10  Tom Tromey  <tromey@adacore.com>
5059
5060         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5061         map_matching_symbols.  Update.
5062         * dwarf2read.c (dw2_map_matching_symbols): Update.
5063         * psymtab.c (match_partial_symbol): Change type; update.
5064         (psym_map_matching_symbols): Likewise.
5065         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5066         type; update.
5067         * symfile.h (struct quick_symbol_functions)
5068         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5069         Remove "match".
5070
5071 2019-09-10  Tom Tromey  <tromey@adacore.com>
5072
5073         * psymtab.c (map_block): Remove.
5074         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5075         * symtab.c (iterate_over_symbols_terminated): New function.
5076         * symtab.c (iterate_over_symbols_terminated): Declare.
5077
5078 2019-09-10  Tom Tromey  <tromey@adacore.com>
5079
5080         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5081         * language.h (struct language_defn) <la_iterate_over_symbols>:
5082         Return bool.
5083         * symtab.c (iterate_over_symbols): Return bool.
5084         * symtab.h (iterate_over_symbols): Return bool.
5085
5086 2019-09-10  Tom Tromey  <tromey@adacore.com>
5087
5088         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5089         (add_nonlocal_symbols): Update.
5090         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5091         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5092         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5093         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5094         Change type of "callback".  Remove "data".
5095
5096
5097 2019-09-09  Ali Tamur  <tamur@google.com>
5098
5099         * dwarf2read.c (comp_unit_head): Update comment.
5100         (dwarf2_dwo_name): New function declaration.
5101         (dwarf_unit_type_name): New function declaration.
5102         (read_comp_unit_head): Add support for new compilation units,
5103         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5104         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5105         (currently named as "signature") in their header. Also clarify error
5106         messages.
5107         (lookup_dwo_id): New function. Returns the dwo id of the given
5108         compile unit.
5109         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5110         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5111         functions.
5112         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5113         (dwarf2_dwo_name): Get the dwo name if present.
5114         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5115         purposes.
5116
5117 2019-09-09  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5120
5121 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5122
5123         * python/python.c (do_start_initialization): Make progname_copy static,
5124         to avoid a leak report.
5125
5126 2019-09-08  Tom Tromey  <tom@tromey.com>
5127
5128         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5129
5130 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5131
5132         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5133         Change type to gdb::optional<block_enum>.
5134         (dw2_symtab_iter_init): Change block_index parameter type
5135         to gdb::optional<block_enum>.
5136         (dw2_lookup_symbol): Change block_index parameter
5137         type to block_enum.c
5138         (dw2_debug_names_lookup_symbol): Likewise.
5139         * psymtab.c (psym_lookup_symbol): Likewise.
5140         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5141         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5142         Likewise.
5143
5144 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5145
5146         * defs.h (relocate_gdb_directory): Change int to bool in
5147         signature and rename flag to relocatable.
5148         * main.c (relocate_path): Likewise.
5149         (relocate_gdb_directory): Likewise.
5150
5151 2019-09-06  Alan Modra  <amodra@gmail.com>
5152
5153         * coffread.c (coff_symfile_read): Constify filename variable.
5154         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5155         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5156         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5157         * solib.c (reload_shared_libraries_1): Likewise.
5158         * symfile.c (reread_symbols): Likewise.
5159         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5160         * solib-darwin.c (darwin_bfd_open): Likewise.
5161         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5162
5163 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5166         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5167
5168 2019-09-03  Tom Tromey  <tromey@adacore.com>
5169
5170         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5171         types.
5172         (has_negatives): Unbias a range type bound.
5173         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5174         * gdbtypes.c (operator==): Handle new field.
5175         (create_range_type): Add "bias" parameter.
5176         (create_static_range_type, resolve_dynamic_range): Update.
5177         * gdbtypes.h (struct range_bounds) <bias>: New member.
5178         (create_range_type): Add bias parameter.
5179         * printcmd.c (print_scalar_formatted): Unbias range types.
5180         * value.c (unpack_long): Unbias range types.
5181         (pack_long): Bias range types.
5182
5183 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5184
5185         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5186         probe arguments.
5187
5188 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5189
5190         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5191         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5192         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5193         (compile_probe_arg): Likewise.
5194         * probe.h (get_argument_count): Likewise.
5195         * solib-svr4.c (solib_event_probe_action): Likewise.
5196         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5197
5198 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5199
5200         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5201         code to here...
5202         (svr4_create_solib_event_breakpoints): ...from here.
5203
5204 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5205
5206         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5207         suffix from warning message.
5208
5209 2019-08-30  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui-winsource.h (struct tui_source_window_base)
5212         <refresh_all>: Don't declare.
5213         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5214         Remove.
5215         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5216         tui_show_locator_content.
5217         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5218         declare.
5219         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5220         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5221         declare.
5222
5223 2019-08-30  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5226
5227 2019-08-30  Tom Tromey  <tom@tromey.com>
5228
5229         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5230         Remove unnecessary forward declarations.
5231
5232 2019-08-30  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5235         rerender.
5236         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5237         tui_show_locator_content.
5238
5239 2019-08-30  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5242         (tui_locator_window::rerender): Rewrite using body of previous
5243         tui_show_locator_content.
5244
5245 2019-08-30  Tom Tromey  <tom@tromey.com>
5246
5247         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5248         set_locator_fullname>: New methods.
5249         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5250         Rename from tui_set_locator_fullname.
5251         (tui_locator_window::set_locator_info): Rename from
5252         tui_set_locator_info.  Return bool.
5253         (tui_update_locator_fullname, tui_show_frame_info): Update.
5254
5255 2019-08-30  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5258
5259 2019-08-30  Tom Tromey  <tom@tromey.com>
5260
5261         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5262         call touchwin.
5263
5264 2019-08-30  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-wingeneral.c (box_win): Assume win_info and
5267         win_info->handle cannot be NULL.
5268
5269 2019-08-30  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5272         refresh_window>: Declare.
5273         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5274         resize.
5275         (tui_data_item_window::rerender): Rename from
5276         tui_display_register.
5277         (tui_data_item_window::refresh_window): New method.
5278         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5279         no-op.
5280
5281 2019-08-30  Tom Tromey  <tom@tromey.com>
5282
5283         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5284         regs_column_count, current_group>: Move later.  Now private.
5285         <get_current_group>: New method.
5286         * tui/tui-regs.c (tui_reg_command): Update.
5287         * tui/tui-layout.c (tui_set_layout): Update.
5288
5289 2019-08-30  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5292         (tui_data_window::rerender): Don't call
5293         check_and_display_highlight_if_needed.
5294         (tui_data_window::refresh_all): Remove call to
5295         erase_data_content.
5296
5297 2019-08-30  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5300         (tui_data_window::display_registers_from)
5301         (tui_data_window::display_reg_element_at_line)
5302         (tui_data_window::display_registers_from_line): Remove checks of
5303         "empty".
5304
5305 2019-08-30  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5308         Don't declare.
5309         * tui/tui-regs.c (tui_data_window::show_registers): Call
5310         rerender.
5311         (tui_data_window::rerender): Rename from display_all_data.
5312         (tui_data_window::rerender): Remove old implementation.
5313
5314 2019-08-30  Tom Tromey  <tom@tromey.com>
5315
5316         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5317         text.
5318         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5319
5320 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5321             Sergio Durigan Junior  <sergiodj@redhat.com>
5322
5323         PR win32/24284
5324         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5325
5326 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5329         when searching for types.
5330
5331 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * f-lang.c (f_language_defn): Use f_print_typedef.
5334         * f-lang.h (f_print_typedef): Declare.
5335         * f-typeprint.c (f_print_typedef): Define.
5336
5337 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5338
5339         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5340
5341 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * cli/cli-utils.c (info_print_options_defs): Delete.
5344         (make_info_print_options_def_group): Delete.
5345         (extract_info_print_options): Delete.
5346         (info_print_command_completer): Delete.
5347         (info_print_args_help): Add extra parameter, and optionally
5348         include text about -n flag.
5349         * cli/cli-utils.h (struct info_print_options): Delete.
5350         (extract_info_print_options): Delete declaration.
5351         (info_print_command_completer): Delete declaration.
5352         (info_print_args_help): Add extra parameter, extend header
5353         comment.
5354         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5355         search_symbols.
5356         * stack.c (struct info_print_options): New type.
5357         (info_print_options_defs): New file scoped variable.
5358         (make_info_print_options_def_group): New static function.
5359         (info_print_command_completer): New static function.
5360         (info_locals_command): Update to use new local functions.
5361         (info_args_command): Likewise.
5362         (_initialize_stack): Add extra parameter to calls to
5363         info_print_args_help.
5364         * symtab.c (search_symbols): Add extra parameter, use this to
5365         possibly excluse non-debug symbols.
5366         (symtab_symbol_info): Add extra parameter, which is passed on to
5367         search_symbols.
5368         (struct info_print_options): New type.
5369         (info_print_options_defs): New file scoped variable.
5370         (make_info_print_options_def_group): New static function.
5371         (info_print_command_completer): New static function.
5372         (info_variables_command): Update to use local functions, and pass
5373         extra parameter through to symtab_symbol_info.
5374         (info_functions_command): Likewise.
5375         (info_types_command): Pass additional argument through to
5376         symtab_symbol_info.
5377         (rbreak_command): Pass extra argument to search_symbols.
5378         (_initialize_symtab): Add extra arguments for calls to
5379         info_print_args_help, and update help text for 'info variables',
5380         'whereis', and 'info functions' commands.
5381         * symtab.h (search_symbols): Add extra argument to declaration.
5382         * NEWS: Mention new flags.
5383
5384 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5385
5386         * symtab.c (lookup_static_symbol): Call the new function (and move
5387         it down to be next to lookup_global_symbol).
5388         (struct global_sym_lookup_data): Add block_enum member and rename to...
5389         (struct global_or_static_sym_lookup_data): ...this.
5390         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5391         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5392         (lookup_symbol_global_or_static_iterator_cb): ...this.
5393         (lookup_global_or_static_symbol): New function.
5394         (lookup_global_symbol): Call new function.
5395
5396 2019-08-26  Tom de Vries  <tdevries@suse.de>
5397
5398         PR c++/24852
5399         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5400         when pc_probe.prob == NULL.
5401
5402 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5403
5404         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5405         variable symbol_linkage to symbol_linkage_.
5406
5407 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5408
5409         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5410         represent whether the symbol is static, dynamic, or we don't
5411         know.
5412
5413 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5414
5415         * gdb/rx-tdep.c (rx_register_names): New.
5416         (rx_register_name): Delete.
5417         (rx_psw_type): Delete.
5418         (rx_fpsw_type): Delete.
5419         (rx_register_type): Delete.
5420         (rx_gdbarch_init): Convert target-descriptions.
5421         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5422         * gdb/features/Makefile: Add rx.xml.
5423         * gdb/features/rx.xml: New.
5424         * gdb/features/rx.c: Generated.
5425         * gdb/NEWS: Mention target description support.
5426
5427 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5428
5429         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5430         *slot_ptr.
5431
5432 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5433
5434         * configure.ac: Don't check for 'dlfcn.h' (moved to
5435         gdbsupport/common.m4).
5436         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5437         'gdbsupport/'.
5438         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5439         * compile/compile-c-support.c: Include
5440         'gdbsupport/gdb-dlfcn.h'.
5441         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5442         * gdb-dlfcn.c: Move to...
5443         * gdbsupport/gdb-dlfcn.c: ... here.
5444         * gdb-dlfcn.h: Move to...
5445         * gdbsupport/gdb-dlfcn.h: ... here.
5446
5447 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5448
5449         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5450         the offset field signed.
5451
5452 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5453
5454         * python/lib/gdb/__init__.py (_execute_file): New function.
5455         * python/python.c (python_run_simple_file): Call gdb._execute_file
5456         on Windows.
5457
5458 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5461         all uses as this was never set to anything but a zero value.
5462
5463 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5464
5465         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5466
5467 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5468
5469         * tui/tui-data.h (tui_gen_win_info): Add an =default
5470         move constructor, required by some GCC versions.
5471
5472 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5473
5474         * go32-nat.c (go32_sysinfo): Add hygon_p.
5475
5476 2019-08-20  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5479         line_from_reg_element_no, first_reg_element_no_inline,
5480         display_all_data, delete_data_content_windows,
5481         erase_data_content>: Now private.
5482
5483 2019-08-20  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5486         (tui_unhighlight_win, tui_highlight_win)
5487         (tui_win_info::make_window): Update.
5488         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5489
5490 2019-08-20  Tom Tromey  <tom@tromey.com>
5491
5492         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5493         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5494         (MAX_PID_WIDTH): Move to tui-stack.c.
5495         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5496         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5497         (MAX_PID_WIDTH): Move from tui-data.h.
5498
5499 2019-08-20  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5502         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5503         (box_win): Update.
5504         (tui_gen_win_info::make_window): Rename from tui_make_window.
5505         (tui_win_info::make_window): New method.
5506         (tui_gen_win_info::make_visible): Update.
5507         * tui/tui-source.c (tui_source_window::set_contents): Update.
5508         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5509         (tui_data_window::display_registers_from): Update.
5510         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5511         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5512         Declare.
5513         <can_box>: Remove.
5514         <title>: Remove.
5515         (struct tui_win_info) <make_window>: Declare.
5516         <can_box>: Now virtual.
5517         <title>: New member.
5518         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5519         * tui/tui-command.c (tui_cmd_window::resize): Update.
5520
5521 2019-08-20  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5524         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5525         (tui_data_window::check_register_values): Update.
5526
5527 2019-08-20  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-regs.h (struct tui_data_window): Use
5530         DISABLE_COPY_AND_ASSIGN.
5531         <regs_content>: Change type, removing unique_ptr.
5532         <tui_data_window>: Add move constructor.
5533         * tui/tui-regs.c (tui_data_window::show_registers)
5534         (tui_data_window::show_register_group)
5535         (tui_data_window::display_registers_from)
5536         (tui_data_window::display_registers_from)
5537         (tui_data_window::first_data_item_displayed)
5538         (tui_data_window::delete_data_content_windows)
5539         (tui_data_window::rerender, tui_data_window::refresh_window)
5540         (tui_data_window::check_register_values): Update.
5541
5542 2019-08-20  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5545         show_register_group>: Declare.
5546         (tui_show_register_group): Don't declare.
5547         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5548         tui_show_registers.
5549         (tui_data_window::show_register_group): Rename from
5550         tui_show_register_group.
5551         (tui_data_window::check_register_values, tui_reg_command):
5552         Update.
5553         * tui/tui-layout.c (tui_set_layout): Update.
5554
5555 2019-08-20  Tom Tromey  <tom@tromey.com>
5556
5557         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5558         Declare.
5559         (tui_check_register_values): Don't declare.
5560         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5561         from tui_check_register_values.
5562         * tui/tui-hooks.c (tui_register_changed): Update.
5563
5564 2019-08-20  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-regs.c (tui_reg_layout): Move later.
5567         (tui_show_registers): Don't enable TUI mode or change layout.
5568
5569 2019-08-20  Tom Tromey  <tom@tromey.com>
5570
5571         * tui/tui-regs.h (struct tui_data_item_window)
5572         <~tui_data_item_window>: Remove.
5573         <content>: Now a unique_xmalloc_ptr.
5574         * tui/tui-regs.c (tui_register_format): Return a
5575         unique_xmalloc_ptr.
5576         (tui_get_register): Update.
5577         (~tui_data_item_window): Remove.
5578         (tui_data_window::display_registers_from, tui_display_register):
5579         Update.
5580         * tui/tui-io.h (tui_expand_tabs): Update.
5581         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5582         Remove "col" parameter.
5583
5584 2019-08-20  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5587         field.
5588         * tui/tui-regs.c (~tui_data_item_window): Update.
5589
5590 2019-08-20  Tom Tromey  <tom@tromey.com>
5591
5592         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5593         earlier.
5594
5595 2019-08-20  Tom Tromey  <tom@tromey.com>
5596
5597         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5598
5599 2019-08-20  Tom Tromey  <tom@tromey.com>
5600
5601         * tui/tui-source.h (struct tui_source_window): Update.
5602         * tui/tui-regs.c (tui_show_registers): Update.
5603         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5604         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5605         (NO_REGS_STRING): Remove defines.
5606
5607 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5608
5609         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5610         unnecessary thread walk if remote doesn't support the packet.
5611
5612 2019-08-19  Tom Tromey  <tromey@adacore.com>
5613
5614         * python/py-value.c (value_has_field): Fix indentation.
5615
5616 2019-08-19  Tom Tromey  <tromey@adacore.com>
5617
5618         * printcmd.c (do_one_display, info_display_command): Update.
5619         * block.h (contained_in): Return bool.  Add allow_nested
5620         parameter.
5621         * block.c (contained_in): Return bool.  Add allow_nested
5622         parameter.
5623
5624 2019-08-19  Tom Tromey  <tom@tromey.com>
5625
5626         * configure: Rebuild.
5627         * configure.ac: Disallow the combination of -static-libstdc++ and
5628         source highlight.
5629         * source-cache.c (get_language_name): Handle rust.
5630         (source_cache::get_source_lines): Ignore highlighting exceptions.
5631
5632 2019-08-16  Tom Tromey  <tom@tromey.com>
5633
5634         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5635         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5636         (struct tui_source_window_base) <make_visible, refresh_window,
5637         resize>: Remove methods.
5638         <execution_info>: Remove field.
5639         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5640         (tui_show_source_line, tui_source_window_base)
5641         (~tui_source_window_base): Update.
5642         (tui_source_window_base::resize)
5643         (tui_source_window_base::make_visible)
5644         (tui_source_window_base::refresh_window): Remove.
5645         (tui_source_window_base::update_exec_info): Update.
5646         * tui/tui-source.c (tui_source_window::set_contents): Update.
5647         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5648
5649 2019-08-16  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5652         deprecated_query_hook.
5653
5654 2019-08-16  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5657         (tui_update_source_windows_with_line): Update.
5658         * tui/tui-source.h (struct tui_source_window)
5659         <show_symtab_source>: Declare.
5660         (tui_show_symtab_source): Don't declare.
5661         * tui/tui-source.c (tui_show_symtab_source): Rename from
5662         tui_show_symtab_source.
5663
5664 2019-08-16  Tom Tromey  <tom@tromey.com>
5665
5666         * tui/tui-winsource.h (struct tui_source_window_base)
5667         <set_contents>: Declare.
5668         * tui/tui-winsource.c
5669         (tui_source_window_base::update_source_window_as_is): Update.
5670         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5671         Declare.
5672         (tui_set_source_content): Don't declare.
5673         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5674         tui_set_source_content.
5675         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5676         Declare.
5677         (tui_set_disassem_content): Don't declare.
5678         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5679         tui_set_disassem_content.
5680
5681 2019-08-16  Tom Tromey  <tom@tromey.com>
5682
5683         * tui/tui-winsource.h (struct tui_source_window_base)
5684         <update_breakpoint_info>: Declare.
5685         (tui_update_breakpoint_info): Don't declare.
5686         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5687         (tui_update_all_breakpoint_info): Update.
5688         (tui_source_window_base::update_breakpoint_info): Rename from
5689         tui_update_breakpoint_info.
5690         (tui_source_window_base::update_exec_info): Update.
5691
5692 2019-08-16  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-winsource.h (struct tui_source_window_base)
5695         <update_source_window>: Declare.
5696         (tui_update_source_window): Don't declare.
5697         * tui/tui-winsource.c
5698         (tui_source_window_base::update_source_window): Rename from
5699         tui_update_source_window.
5700         (tui_source_window_base::rerender): Update.
5701         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5702         * tui/tui-disasm.c (tui_show_disassem)
5703         (tui_show_disassem_and_update_source)
5704         (tui_disasm_window::maybe_update): Update.
5705
5706 2019-08-16  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-winsource.h (struct tui_source_window_base)
5709         <update_source_window_as_is>: Declare.
5710         (tui_update_source_window_as_is): Don't declare.
5711         * tui/tui-winsource.c (tui_update_source_window): Update
5712         (tui_source_window_base::update_source_window_as_is): Rename from
5713         tui_update_source_window_as_is.
5714         (tui_source_window_base::refill): Update.
5715         * tui/tui-source.c (tui_show_symtab_source): Update.
5716         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5717         Update.
5718
5719 2019-08-16  Tom Tromey  <tom@tromey.com>
5720
5721         * tui/tui-winsource.h (tui_update_source_window)
5722         (tui_update_source_window_as_is): Remove "noerror" parameter.
5723         * tui/tui-winsource.c (tui_update_source_window)
5724         (tui_update_source_window_as_is): Remove "noerror" parameter.
5725         (tui_update_source_windows_with_addr)
5726         (tui_update_source_windows_with_line)
5727         (tui_source_window_base::rerender)
5728         (tui_source_window_base::refill): Update.
5729         * tui/tui-source.h (tui_set_source_content)
5730         (tui_show_symtab_source): Remove "noerror" parameter.
5731         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5732         parameter.
5733         (tui_show_symtab_source): Likewise.
5734         (tui_source_window::maybe_update): Update.
5735         * tui/tui-disasm.c (tui_show_disassem)
5736         (tui_show_disassem_and_update_source)
5737         (tui_disasm_window::do_scroll_vertical)
5738         (tui_disasm_window::maybe_update): Update.
5739
5740 2019-08-16  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui.c (tui_is_window_visible): Update.
5743         * tui/tui-wingeneral.c (tui_make_window)
5744         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5745         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5746         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5747         (tui_set_win_height_command, parse_scrolling_args): Update.
5748         * tui/tui-source.c (tui_source_window::style_changed): Update.
5749         * tui/tui-regs.c (tui_show_registers)
5750         (tui_data_window::first_data_item_displayed)
5751         (tui_data_window::delete_data_content_windows)
5752         (tui_check_register_values, tui_reg_command): Update.
5753         * tui/tui-disasm.c (tui_show_disassem): Update.
5754         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5755         method.
5756         <is_visible>: Remove field.
5757         * tui/tui-data.c (tui_next_win, tui_prev_win)
5758         (tui_delete_invisible_windows): Update.
5759
5760 2019-08-16  Tom Tromey  <tom@tromey.com>
5761
5762         * tui/tui-winsource.h (struct tui_source_window_base)
5763         <m_has_locator>: Remove.
5764         * tui/tui-layout.c (show_source_disasm_command, show_data)
5765         (show_source_or_disasm_and_command): Update.
5766
5767 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5768
5769         * NEWS (Other MI changes): New subsection.
5770         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5771         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5772         * arch-utils.c (default_get_pc_address_flags): New function.
5773         * arch-utils.h (default_get_pc_address_flags): New declaration.
5774         * gdbarch.sh: Add get_pc_address_flags.
5775         * gdbarch.c: Regenerate.
5776         * gdbarch.h: Likewise.
5777         * stack.c (print_pc): New function.
5778         (print_frame_info) (print_frame): Call print_pc.
5779
5780 2019-08-16  Tom de Vries  <tdevries@suse.de>
5781
5782         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5783         print_objfile_section_info.
5784
5785 2019-08-15  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5788         calling update_cmdwin_start_line.
5789         * tui/tui-winsource.h (struct tui_source_window_base)
5790         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5791         <rerender>: Declare.
5792         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5793         Call rerender.
5794         (tui_source_window_base::set_new_height): Remove.
5795         (tui_source_window_base::rerender): Rename from
5796         do_make_visible_with_new_height.
5797         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5798         resize method.
5799         (tui_win_info::make_invisible_and_set_new_height)
5800         (tui_win_info::make_visible_with_new_height): Remove.
5801         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5802         Declare.
5803         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5804         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5805         do_make_visible_with_new_height>: Don't declare.
5806         <rerender>: Declare.
5807         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5808         set_new_height.
5809         (tui_data_window::do_make_visible_with_new_height): Remove.
5810         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5811         call tui_show_locator_content.
5812         (tui_gen_win_info::resize): Call rerender.
5813         (show_source_or_disasm_and_command): Don't call
5814         tui_show_locator_content.
5815         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5816         method.
5817         (struct tui_win_info) <rerender>: Declare.
5818         <set_new_height, make_invisible_and_set_new_height,
5819         make_visible_with_new_height>: Don't declare.
5820         * tui/tui-data.c (tui_win_list::rerender): New method.
5821         * tui/tui-command.h (struct tui_cmd_window)
5822         <do_make_visible_with_new_height>: Don't declare.
5823         * tui/tui-command.c
5824         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5825
5826 2019-08-15  Tom Tromey  <tromey@adacore.com>
5827
5828         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5829         * ada-lang.c (ada_enum_name): Likewise.
5830
5831 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5832
5833         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5834         leading underscore.
5835         (GdbOutputErrorFile): Likewise.
5836         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5837         accordingly.
5838         (execute_unwinders): Rename to have a leading underscore.
5839         (auto_load_packages): Likewise.
5840         (global scope): Adjust call to auto_load_packages accordingly.
5841         (GdbSetPythonDirectory): Likewise.
5842         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5843         instead of execute_unwinders.
5844
5845 2019-08-15  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5848         (show_data): Don't change window visibility.
5849         (tui_gen_win_info::resize): Remove special case for command
5850         window.  Use wresize, when available.
5851         (show_source_or_disasm_and_command): Don't change window
5852         visibility.
5853         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5854         <make_visible>: New method.
5855         * tui/tui-command.c (tui_cmd_window::resize): New method.
5856
5857 2019-08-15  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5860         (struct tui_source_windows): New.
5861         * tui/tui-winsource.c (tui_display_main): Update.
5862         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5863         (new_height_ok, parse_scrolling_args): Update.
5864         * tui/tui-layout.c (show_layout, show_data): Update.
5865         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5866         (tui_add_to_source_windows): Don't declare.
5867         * tui/tui-data.c (source_windows, tui_source_windows)
5868         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5869
5870 2019-08-15  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5873         Rename from reset.
5874         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5875         * tui/tui-layout.c (show_source_disasm_command, show_data):
5876         Update.
5877         (tui_gen_win_info::resize): Rename.
5878         (show_source_or_disasm_and_command): Update.
5879         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5880         reset.
5881
5882 2019-08-15  Tom Tromey  <tom@tromey.com>
5883
5884         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5885         * tui/tui-interp.c (tui_interp::init): Don't call
5886         tui_initialize_static_data.
5887         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5888
5889 2019-08-15  Tom Tromey  <tom@tromey.com>
5890
5891         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5892         examine tui_win_list.
5893
5894 2019-08-15  Tom Tromey  <tom@tromey.com>
5895
5896         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5897         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5898         tui_clear_source_content.
5899         (tui_clear_source_content): Remove.
5900         (tui_source_window_base::do_erase_source_content): Hoist call to
5901         content.clear().
5902         * tui/tui-stack.c (tui_show_frame_info): Don't call
5903         tui_clear_source_content.
5904
5905 2019-08-15  Tom Tromey  <tom@tromey.com>
5906
5907         * tui/tui-winsource.h (struct tui_source_window_base)
5908         <do_erase_source_content>: New method.
5909         <erase_source_content>: New method.
5910         (tui_erase_source_content): Don't declare.
5911         * tui/tui-winsource.c (tui_clear_source_content): Update.
5912         (tui_source_window_base::do_erase_source_content): Rename from
5913         tui_erase_source_content.
5914         (tui_source_window_base::show_source_content): Update.
5915         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5916         * tui/tui-source.h (struct tui_source_window)
5917         <erase_source_content>: New method.
5918         * tui/tui-disasm.h (struct tui_disasm_window)
5919         <erase_source_content>: New method.
5920
5921 2019-08-15  Tom Tromey  <tom@tromey.com>
5922
5923         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5924         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5925         constructor.
5926         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5927         * tui/tui-source.c (tui_set_source_content): Update.
5928         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5929
5930 2019-08-15  Tom Tromey  <tom@tromey.com>
5931
5932         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5933         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5934         tui-source.c.
5935         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5936         Declare.
5937         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5938         method.
5939         (tui_source_window::maybe_update): Update.
5940
5941 2019-08-15  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5944         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5945         tui-disasm.c.
5946         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5947         Declare.
5948         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5949         method.
5950         (tui_disasm_window::maybe_update): Update.
5951
5952 2019-08-15  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-winsource.h (struct tui_source_window_base)
5955         <maybe_update>: Declare.
5956         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5957         method.
5958         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5959         Declare.
5960         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5961         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5962         Declare.
5963         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5964
5965 2019-08-15  Tom Tromey  <tom@tromey.com>
5966
5967         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5968
5969 2019-08-15  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui-wingeneral.c: Include tui-stack.h.
5972         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5973         (struct tui_locator_window): Move from tui-data.h.
5974         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5975         (tui_initialize_static_data): Move from tui-data.c.
5976         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5977         (struct tui_locator_window): Move to tui-stack.c.
5978         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5979         (tui_initialize_static_data): Move to tui-stack.c.
5980
5981 2019-08-15  Tom Tromey  <tom@tromey.com>
5982
5983         * tui/tui-layout.c (show_source_disasm_command)
5984         (show_source_or_disasm_and_command): Use make_visible method, not
5985         tui_make_window.
5986         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5987         Remove.
5988
5989 2019-08-15  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-wingeneral.h (tui_make_window): Update.
5992         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5993         parameter.
5994         (tui_gen_win_info::make_visible): Update.
5995         * tui/tui-regs.c (tui_data_window::display_registers_from):
5996         Update.
5997         * tui/tui-layout.c (show_source_disasm_command)
5998         (show_source_or_disasm_and_command): Update.
5999         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
6000         (enum tui_box): Remove.
6001         (struct tui_win_info) <can_box>: New method.
6002         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
6003         method.
6004
6005 2019-08-15  Tom de Vries  <tdevries@suse.de>
6006
6007         * linux-nat-trad.c: Include gdbarch.h.
6008
6009 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
6010
6011         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6012         register sizes.
6013
6014 2019-08-14  Tom Tromey  <tromey@adacore.com>
6015
6016         * darwin-nat.c: Include gdbarch.h.
6017         * darwin-nat-info.c: Include gdbarch.h.
6018
6019 2019-08-13  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6022         Remove.
6023         * tui/tui-data.c (tui_initialize_static_data): Update.
6024
6025 2019-08-13  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-winsource.h (struct tui_exec_info_window)
6028         <~tui_exec_info_window, maybe_allocate_content, get_content,
6029         m_content>: Remove.
6030         (struct tui_source_window_base) <set_exec_info_content,
6031         show_exec_info_content>: Don't declare.
6032         * tui/tui-winsource.c
6033         (tui_exec_info_window::maybe_allocate_content): Remove.
6034         (tui_source_window_base::update_exec_info): Rename from
6035         set_exec_info_content.
6036         (tui_source_window_base::show_exec_info_content)
6037         (tui_source_window_base::update_exec_info): Remove.
6038
6039 2019-08-13  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6042         declare.
6043         * tui/tui-winsource.c (tui_update_source_window_as_is)
6044         (tui_update_source_windows_with_addr, tui_erase_source_content):
6045         Update.
6046         (tui_clear_exec_info_content): Remove.
6047
6048 2019-08-13  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6051         declare.
6052         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6053         call tui_erase_exec_info_content.
6054         (tui_clear_exec_info_content): Rename from
6055         tui_erase_exec_info_content.
6056         (tui_clear_exec_info_content): Delete.
6057
6058 2019-08-13  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-winsource.h (struct tui_source_window_base)
6061         <show_exec_info_content>: Declare.
6062         (tui_show_exec_info_content): Don't declare.
6063         * tui/tui-winsource.c
6064         (tui_source_window_base::show_exec_info_content): Rename from
6065         tui_show_exec_info_content.
6066         (tui_source_window_base::update_exec_info): Update.
6067
6068 2019-08-13  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6071         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6072         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6073         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6074         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6075         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6076         ... here.
6077
6078 2019-08-13  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-winsource.h (struct tui_source_window_base)
6081         <update_exec_info>: Declare.
6082         (tui_update_exec_info): Don't declare.
6083         * tui/tui-winsource.c (tui_update_source_window_as_is)
6084         (tui_source_window_base::refresh_all)
6085         (tui_update_all_breakpoint_info): Update.
6086         (tui_source_window_base::update_exec_info): Rename from
6087         tui_update_exec_info.
6088         * tui/tui-stack.c (tui_show_frame_info): Update.
6089
6090 2019-08-13  Tom Tromey  <tom@tromey.com>
6091
6092         * tui/tui-winsource.h (struct tui_source_window_base)
6093         <set_exec_info_content>: Declare.
6094         (tui_set_exec_info_content): Don't declare.
6095         * tui/tui-winsource.c
6096         (tui_source_window_base::set_exec_info_content): Rename from
6097         tui_set_exec_info_content.
6098         (tui_update_exec_info): Update.
6099
6100 2019-08-13  Tom Tromey  <tom@tromey.com>
6101
6102         * tui/tui-winsource.h (struct tui_source_window_base)
6103         <show_source_content>: Declare.
6104         (tui_show_source_content): Don't declare.
6105         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6106         (tui_source_window_base::show_source_content): Rename from
6107         tui_show_source_content.
6108         (tui_source_window_base::refresh_all): Update.
6109         * tui/tui-layout.c (show_source_disasm_command)
6110         (show_source_or_disasm_and_command): Update.
6111
6112 2019-08-13  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-winsource.c (tui_erase_source_content)
6115         (tui_show_source_content, tui_source_window_base::refresh_all):
6116         Update.
6117         * tui/tui-wingeneral.h
6118         (tui_check_and_display_highlight_if_needed): Don't declare.
6119         * tui/tui-wingeneral.c
6120         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6121         check_and_display_highlight_if_needed.
6122         * tui/tui-win.c (tui_rehighlight_all)
6123         (tui_win_info::make_visible_with_new_height): Update.
6124         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6125         (tui_data_window::erase_data_content)
6126         (tui_data_window::display_all_data): Update.
6127         * tui/tui-data.h (struct tui_win_info)
6128         <check_and_display_highlight_if_needed>: Declare.
6129
6130 2019-08-13  Tom Tromey  <tom@tromey.com>
6131
6132         * tui/tui-win.c (tui_resize_all): Call
6133         tui_delete_invisible_windows.
6134         * tui/tui-layout.c (show_layout): Call
6135         tui_delete_invisible_windows.
6136         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6137         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6138
6139 2019-08-13  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6142         tui_add_win_to_layout.
6143
6144 2019-08-13  Tom Tromey  <tom@tromey.com>
6145
6146         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6147         * tui/tui-layout.c (tui_default_win_height): Now static.
6148
6149 2019-08-13  Tom Tromey  <tom@tromey.com>
6150
6151         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6152         single switch.
6153         (show_source_disasm_command, show_source_or_disasm_and_command):
6154         Don't check current layout.
6155
6156 2019-08-13  Tom Tromey  <tom@tromey.com>
6157
6158         * tui/tui-wingeneral.c (make_all_visible): Remove.
6159         (tui_make_all_invisible): Simplify.
6160         * tui/tui-layout.c (tui_make_all_invisible): Move from
6161         tui-wingeneral.c; simplify.
6162         (show_layout): Hoist call to tui_make_all_invisible.
6163         (show_data): Don't call tui_make_all_invisible.
6164
6165 2019-08-13  Tom Tromey  <tom@tromey.com>
6166
6167         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6168         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6169
6170 2019-08-13  Tom Tromey  <tom@tromey.com>
6171
6172         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6173         tui-data.c.
6174         (show_source_disasm_command, show_data)
6175         (show_source_or_disasm_and_command): Don't use
6176         tui_set_current_layout_to.
6177         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6178         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6179         tui-layout.c.
6180         (tui_set_current_layout_to): Remove.
6181
6182 2019-08-13  Tom Tromey  <tom@tromey.com>
6183
6184         * tui/tui-layout.c (tui_set_layout): Update.
6185         * tui/tui-data.h (struct tui_layout_def): Remove.
6186         (tui_layout_def): Don't declare.
6187         * tui/tui-data.c (layout_def): Remove.
6188         (tui_layout_def): Remove.
6189
6190 2019-08-13  Tom Tromey  <tom@tromey.com>
6191
6192         * tui/tui-winsource.h (struct tui_source_window_base)
6193         <clear_detail>: No longer "override".
6194         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6195         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6196         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6197         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6198         Remove.
6199         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6200
6201 2019-08-13  Tom Tromey  <tromey@adacore.com>
6202
6203         * tracepoint.c: Don't include readline.h or history.h.
6204
6205 2019-08-12  Tom Tromey  <tom@tromey.com>
6206
6207         * configure: Rebuild.
6208         * configure.ac: Check for readline 7.
6209         * NEWS: Mention readline 7 requirement.
6210         * README: Update.
6211
6212 2019-08-12  Tom Tromey  <tom@tromey.com>
6213
6214         * mingw-hdep.c (gdb_select): Remove readline hack.
6215
6216 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6217
6218         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6219         when the function fails.
6220
6221 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6222
6223         * s390-tdep.c (s390_type_align): New function.
6224         (s390_gdbarch_init): Set it as type_align gdbarch method.
6225
6226 2019-08-09  Tom de Vries  <tdevries@suse.de>
6227
6228         PR gdb/24591
6229         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6230         pc_low with relocation offset.
6231
6232 2019-08-07  Tom Tromey  <tromey@adacore.com>
6233
6234         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6235         (print_frame_args): Update.
6236         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6237         Update.
6238         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6239         * frame.h (struct frame_arg): Add initializers.
6240         <error>: Now a unique_xmalloc_ptr.
6241
6242 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6243
6244         * NEWS: Expand the Pointer Authentication entry.
6245         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6246         (aarch64_frame_unmask_lr): ... to this.
6247         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6248         Call aarch64_frame_unmask_lr.
6249         * frame.c (struct frame_info): Add "masked" variable.
6250         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6251         (fprint_frame): Check for masked pc.
6252         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6253         declarations.
6254         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6255         * stack.c (print_frame): Check for masked pc.
6256
6257 2019-08-06  Tom Tromey  <tom@tromey.com>
6258
6259         * stabsread.c (patch_block_stabs, read_one_struct_field)
6260         (read_enum_type): Use obstack_strndup.
6261         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6262         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6263         * dwarf2read.c (guess_full_die_structure_name)
6264         (anonymous_struct_prefix): Use obstack_strndup.
6265         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6266         * c-exp.y (yylex): Use obstack_strndup.
6267         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6268         (write_var_or_type): Use obstack_strndup.
6269
6270 2019-08-06  Tom Tromey  <tom@tromey.com>
6271
6272         * symfile.c (reread_symbols): Use obstack_strdup.
6273         * stabsread.c (read_type): Use obstack_strdup.
6274         * gdb_obstack.h (obstack_strdup): New overload.
6275         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6276         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6277         (dwarf2_canonicalize_name): Use obstack_strdup.
6278         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6279         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6280         Use obstack_strdup.
6281
6282 2019-08-06  Tom Tromey  <tom@tromey.com>
6283
6284         * gdb_obstack.h (obstack_strdup): Define.
6285         * gdb_obstack.c (obstack_strdup): Don't define.
6286
6287 2019-08-06  Tom Tromey  <tom@tromey.com>
6288
6289         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6290         obstack_strdup.
6291         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6292         obstack_strdup.
6293         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6294         * stabsread.c (common_block_start): Use obstack_strdup.
6295         * objfiles.c (set_objfile_main_name, objfile): Use
6296         obstack_strdup.
6297         * namespace.c (add_using_directive): Use obstack_strdup.
6298         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6299         * jit.c (finalize_symtab): Use obstack_strdup.
6300         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6301         (guess_partial_die_structure_name, partial_die_info::fixup)
6302         (dwarf2_name): Use obstack_strdup.
6303         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6304         obstack_strdup.
6305         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6306         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6307         obstack_strdup.
6308         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6309
6310 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6311
6312         * unittests/help-doc-selftests.c: New file.
6313         * Makefile.in: Add the new file.
6314
6315 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6316
6317         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6318         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6319         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6320         the trailing '.' is not output, and the first character is uppercased.
6321         (print_help_for_command): Update call to print_doc_line.
6322         (print_doc_of_command): Likewise.
6323         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6324         * cli/cli-option.c (append_indented_doc): Do not append newline.
6325         (build_help_option): Append newline after first appended_indented_doc
6326         only if a second call is done.
6327         (build_help): Append 2 new lines before each option, except the first
6328         one.
6329         * compile/compile.c (_initialize_compile): Add new lines after
6330         %OPTIONS%, when not at the end of the help.
6331         Change help doc or code
6332         producing the help doc to respect the invariants.
6333         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6334         Also removed the new line after 'Options:', as all other commands
6335         do not put an empty line between 'Options:' and the first option.
6336         * printcmd.c (_initialize_printcmd): Likewise.
6337         * stack.c (_initialize_stack): Likewise.
6338         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6339         incorrectly telling COMMAND is optional.
6340         * ada-lang.c (_initialize_ada_language): Change help doc or code
6341         producing the help doc to respect the invariants.
6342         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6343         * breakpoint.c (_initialize_breakpoint): Likewise.
6344         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6345         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6346         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6347         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6348         _initialize_cli_style): Likewise.
6349         * corelow.c (core_target_info): Likewise.
6350         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6351         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6352         * filesystem.c (_initialize_filesystem): Likewise.
6353         * frame.c (_initialize_frame): Likewise.
6354         * gnu-nat.c (add_task_commands): Likewise.
6355         * infcall.c (_initialize_infcall): Likewise.
6356         * infcmd.c (_initialize_infcmd): Likewise.
6357         * interps.c (_initialize_interpreter): Likewise.
6358         * language.c (_initialize_language): Likewise.
6359         * linux-fork.c (_initialize_linux_fork): Likewise.
6360         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6361         * maint.c (_initialize_maint_cmds): Likewise.
6362         * memattr.c (_initialize_mem): Likewise.
6363         * printcmd.c (_initialize_printcmd): Likewise.
6364         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6365         _RegEx): Likewise.
6366         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6367         * record-btrace.c (_initialize_record_btrace): Likewise.
6368         * record-full.c (_initialize_record_full): Likewise.
6369         * record.c (_initialize_record): Likewise.
6370         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6371         * regcache.c (_initialize_regcache): Likewise.
6372         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6373         _initialize_remote): Likewise.
6374         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6375         * serial.c (_initialize_serial): Likewise.
6376         * skip.c (_initialize_step_skip): Likewise.
6377         * source.c (_initialize_source): Likewise.
6378         * stack.c (_initialize_stack): Likewise.
6379         * symfile.c (_initialize_symfile): Likewise.
6380         * symtab.c (_initialize_symtab): Likewise.
6381         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6382         * top.c (init_main): Likewise.
6383         * tracefile-tfile.c (tfile_target_info): Likewise.
6384         * tracepoint.c (_initialize_tracepoint): Likewise.
6385         * tui/tui-win.c (_initialize_tui_win): Likewise.
6386         * utils.c (add_internal_problem_command): Likewise.
6387         * valprint.c (value_print_option_defs): Likewise.
6388
6389 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6390
6391         PR build/24886
6392         * configure.ac: Drop enable-libmcheck support.
6393         * configure, config.in: Rebuild.
6394         * libmcheck.m4: Remove.
6395         * acinclude.m4: Don't include it.
6396         * Makefile.in: Don't distribute it.
6397         * top.c (print_gdb_configuration): Don't mention it.
6398
6399 2019-08-06  Tom Tromey  <tom@tromey.com>
6400
6401         * utils.c (set_output_style): Sometimes pass stream to
6402         emit_style_escape.
6403         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6404         * record-btrace.c (btrace_insn_history): Update.
6405         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6406         method.
6407         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6408         Update initializers.
6409         <m_uiout>: New field.
6410         <m_di>: Move lower.
6411         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6412         Remove "uiout" parameter.
6413         (dump_insns): Update.
6414         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6415         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6416
6417 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6418
6419         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6420         (error_in_psymtab_expansion): Likewise.
6421         (lookup_symbol_via_quick_fns): Likewise.
6422         (basic_lookup_transparent_type_quick): Likewise.
6423         (basic_lookup_transparent_type_1): Likewise.
6424
6425 2019-08-06  Tom Tromey  <tromey@adacore.com>
6426
6427         * source.c (last_source_error): Now bool.
6428         (print_source_lines_base): Make "noprint" bool.  Only open
6429         source file when last_source_visited changes.
6430
6431 2019-08-06  Tom Tromey  <tromey@adacore.com>
6432
6433         * annotate.c (annotate_source_line): Use g_source_cache.
6434         * source-cache.c (source_cache::get_plain_source_lines): Change
6435         parameters.  Populate m_offset_cache.
6436         (source_cache::ensure): New method.
6437         (source_cache::get_line_charpos): New method.
6438         (extract_lines): Move lower.  Change parameters.
6439         (source_cache::get_source_lines): Move lower.
6440         * source-cache.h (class source_cache): Update comment.
6441         <get_line_charpos>: New method.
6442         <get_source_lines>: Update comment.
6443         <clear>: Clear m_offset_cache.
6444         <get_plain_source_lines>: Change parameters.
6445         <ensure>: New method
6446         <m_offset_cache>: New member.
6447         * source.c (forget_cached_source_info_for_objfile): Update.
6448         (info_source_command): Use g_source_cache.
6449         (find_source_lines, open_source_file_with_line_charpos): Remove.
6450         (print_source_lines_base, search_command_helper): Use g_source_cache.
6451         * source.h (open_source_file_with_line_charpos): Don't declare.
6452         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6453         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6454         Use g_source_cache.
6455
6456 2019-08-06  Tom Tromey  <tromey@adacore.com>
6457
6458         * source-cache.c (source_cache::get_plain_source_lines):
6459         Remove "first_line" and "last_line" parameters.
6460         (source_cache::get_source_lines): Cache plain text.
6461         * source-cache.h (class source_cache)
6462         <get_plain_source_lines>: Update.
6463
6464 2019-08-06  Tom Tromey  <tromey@adacore.com>
6465
6466         * source-cache.c (extract_lines): No longer a method.
6467         Changed type of parameter.  Include final newline.
6468         (selftests::extract_lines_test): New function.
6469         (_initialize_source_cache): Likewise.
6470         * source-cache.h (class source_cache)
6471         <extract_lines>: Don't declare.
6472
6473 2019-08-06  Tom Tromey  <tromey@adacore.com>
6474
6475         * breakpoint.c (init_breakpoint_sal): Update.
6476         (breakpoint): Update.
6477         * breakpoint.h (struct breakpoint) <filter>: Now a
6478         unique_xmalloc_ptr.
6479
6480 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6481
6482         * NEWS: Mention dictionary access on blocks.
6483         * python/py-block.c (blpy_getitem): New function.
6484         (block_object_as_mapping): New struct.
6485         (block_object_type): Use new struct for tp_as_mapping field.
6486
6487 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6488
6489         * objfiles.h (objfile): Add a comment describing partial symbols.
6490
6491 2019-08-05  Tom Tromey  <tromey@adacore.com>
6492
6493         * compile/compile.c (_initialize_compile): Use _(), not N_().
6494         * thread.c (_initialize_thread): Use _(), not N_().
6495         * stack.c (_initialize_stack): Use _(), not N_().
6496         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6497
6498 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6499
6500         * dwarf2read.c (struct dw2_symtab_iterator):
6501         <want_specific_block>: Remove.
6502         <block_index>: Change type to gdb::optional.
6503         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6504         change type of BLOCK_INDEX parameter to gdb::optional.
6505         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6506         (dw2_lookup_symbol): Don't pass argument for
6507         WANT_SPECIFIC_BLOCK.
6508         (dw2_expand_symtabs_for_function): Don't pass argument for
6509         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6510         (class dw2_debug_names_iterator)
6511         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6512         parameter, change BLOCK_INDEX type to gdb::optional.
6513         <m_want_specific_block>: Remove.
6514         <m_block_index>: Change type to gdb::optional.
6515         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6516         gdb::optional.  Re-write in function of gdb::optional.
6517         (dw2_debug_names_lookup_symbol): Don't pass argument for
6518         WANT_SPECIFIC_BLOCK.
6519         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6520         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6521         BLOCK_INDEX.
6522
6523 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6524
6525         * NEWS: Mention changes to "info sources" command.
6526
6527 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6528
6529         * symtab.c (filename_partial_match_opts): New struct type.
6530         (struct output_source_filename_data): New members
6531         regexp, c_regexp, partial_match.
6532         (output_source_filename): Use new members to decide to print file.
6533         (info_sources_option_defs): New variable.
6534         (make_info_sources_options_def_group, print_info_sources_header,
6535         info_sources_command_completer):
6536         New functions.
6537         (info_sources_command): Read new optional arguments.
6538         (_initialize_symtab): Update info sources help.
6539
6540 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6541
6542         * ada-lang.c (exception_support_info_v0): Renamed from...
6543         (default_exception_support_info): ... this.  Create new
6544         definition for v1.
6545         (ada_has_this_exception_support): Look up catch_handlers_sym.
6546         (ada_exception_support_info_sniffer): Try v0 after default.
6547
6548 2019-08-01  Tom Tromey  <tromey@adacore.com>
6549
6550         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6551         gdbarch.h.
6552
6553 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6554
6555         * s12z-tdep.c: Fix include path for s12z-opc.h.
6556
6557 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6558
6559         * NEWS: Require GNU make 3.82.
6560
6561 2019-07-16  Tom Tromey  <tom@tromey.com>
6562
6563         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6564         declare.
6565
6566 2019-07-30  Tom Tromey  <tromey@adacore.com>
6567
6568         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6569
6570 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6571
6572         * printcmd.c (print_address_symbolic): Print negative offsets.
6573         (build_address_symbolic): Force signed arithmetic when computing
6574         offset.
6575
6576 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6577
6578         PR/24474: Add a function to lookup static variables.
6579         * NEWS: Mention this new function.
6580         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6581         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6582         * python/python.c (python_GdbMethods): Add new function.
6583
6584 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6585
6586         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6587         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6588         (objfpy_lookup_static_symbol): New function.
6589         (objfile_object_methods): Add new functions.
6590
6591 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6592
6593         * NEWS: Mention 'set|show print frame-info'.  Mention new
6594         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6595         backtrace argument.  Mention that python frame filtering code
6596         is now consistent with what 'backtrace' command prints.
6597
6598 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6599
6600         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6601         comments.
6602         (print_frame_info_auto, print_frame_info_source_line,
6603         print_frame_info_location, print_frame_info_source_and_location,
6604         print_frame_info_location_and_address, print_frame_info_short_location):
6605         New declarations.
6606         (struct frame_print_options): New member print_frame_info.
6607         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6608         * stack.h (get_user_print_what_frame_info): New declaration.
6609         (frame_show_address): New declaration.
6610         * stack.c (print_frame_arguments_choices): New value 'presence'.
6611         (print_frame_info_auto, print_frame_info_source_line,
6612         print_frame_info_location, print_frame_info_source_and_location,
6613         print_frame_info_location_and_address, print_frame_info_short_location,
6614         print_frame_info_choices, print_frame_info_print_what): New definitions.
6615         (print_frame_args): Only print dots for args if print frame-arguments
6616         is 'presence'.
6617         (frame_print_option_defs): New element for "frame-info".
6618         (get_user_print_what_frame_info): New function.
6619         (frame_show_address): Make non static.  Move comment to stack.h.
6620         (print_frame_info_to_print_what): New function.
6621         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6622         to decide what to print.
6623         (backtrace_command_1): Handle the new print_frame_arguments_presence
6624         value.
6625         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6626         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6627         (py_print_frame): In non-mi mode, use LOCATION as default for
6628         print_what, similarly to frame information printed directly by
6629         backtrace command. Handle frame-info user option in non MI mode.
6630
6631 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6632
6633         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6634         Add case for debugging 32-bit target on 64-bit host.  Revise
6635         comment.
6636
6637 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6638
6639         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6640         instead of find_function_entry_range_from_pc.
6641
6642 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6643
6644         * stack.c (find_frame_funname): Remove code which preferred
6645         minsym over symtab sym in "certain pathological cases".
6646
6647         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6648         parameter.  Change type of "do_demangle" to bool.
6649         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6650         Pass suitable "prefer_sym_over_minsym" flag to
6651         build_address_symbolic().  Don't output "+" for negative offsets.
6652         * printcmd.c (print_address_symbolic): Update invocation of
6653         build_address_symbolic to include a "prefer_sym_over_minsym"
6654         flag.
6655         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6656         Restrict cases in which use of minimal symbol is preferred to that
6657         of a found symbol.  Update comments.
6658
6659         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6660         for entry pc when entry pc is out of range for that FDE.
6661
6662 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6663
6664         PR gdb/24839:
6665         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6666         type.
6667
6668 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6669
6670         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6671         this function's Python signature.
6672
6673
6674 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6675
6676         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6677         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6678         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6679         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6680         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6681
6682
6683 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6684
6685         * h8300-tdep.c (h8300_register_name_common): New.
6686         h8300_register_name): Use h8300_register_name_common.
6687         (h8300s_register_name): Likewise.
6688         (h8300sx_register_name): Likewise.
6689         (h8300h_register_nam): New.
6690         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6691
6692
6693 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6694
6695         * arm-tdep.c (arm_skip_cmse_entry): New function.
6696         (arm_is_sgstubs_section): New function.
6697         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6698
6699 2019-07-22  Tom Tromey  <tom@tromey.com>
6700
6701         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6702         Don't self-assign.
6703
6704 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6705
6706         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6707         type_print.
6708
6709 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6712         so that GDB doesn't match any msymbols when searching in the
6713         TYPES_DOMAIN.
6714         (print_symbol_info): Print using typedef_print or type_print based
6715         on the type of the symbol.  Add updated FIXME comment moved from...
6716         (_initialize_symtab): ... move and update FIXME comment to above.
6717
6718 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6719
6720         * NEWS: Mention adding -q option to "info types".
6721         * symtab.c (struct info_types_options): New struct.
6722         (info_types_options_defs): New variable.
6723         (make_info_types_options_def_group): New function.
6724         (info_types_command): Use gdb::option framework to parse options.
6725         (info_types_command_completer): New function.
6726         (_initialize_symtab): Extend the help text on "info types" and
6727         register command completer.
6728
6729 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6730
6731         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6732         (lookup_symbol_in_objfile): Change int to block_enum and add a
6733         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6734
6735 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6736
6737         * MAINTAINERS (Write After Approval): Add self.
6738
6739 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6740
6741         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6742         instruction to the dummy code region.
6743
6744 2019-07-19  Tom Tromey  <tromey@adacore.com>
6745
6746         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6747         (ARGSUSED, PARAMS, __func__): Remove rules.
6748
6749 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6752         * features/arm/arm-with-iwmmxt.c: Remove.
6753         * features/arm/arm-with-iwmmxt.xml: Remove.
6754         * features/arm/arm-with-m-fpa-layout.c: Remove.
6755         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6756         * features/arm/arm-with-m-vfp-d16.c: Remove.
6757         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6758         * features/arm/arm-with-m.c: Remove.
6759         * features/arm/arm-with-m.xml: Remove.
6760         * features/arm/arm-with-neon.c: Remove.
6761         * features/arm/arm-with-neon.xml: Remove.
6762         * features/arm/arm-with-vfpv2.c: Remove.
6763         * features/arm/arm-with-vfpv2.xml: Remove.
6764         * features/arm/arm-with-vfpv3.c: Remove.
6765         * features/arm/arm-with-vfpv3.xml: Remove.
6766
6767 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6768
6769         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6770
6771 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6772
6773         * arch/aarch32.c (aarch32_create_target_description): Create
6774         target descriptions using features.
6775         * arch/arm.c (arm_create_target_description)
6776         (arm_create_mprofile_target_description): Likewise.
6777         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6778
6779 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6780
6781         * Makefile.in: Add new files.
6782         * aarch32-tdep.c: New file.
6783         * aarch32-tdep.h: New file.
6784         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6785         Call aarch32_read_description.
6786         * arch/aarch32.c: New file.
6787         * arch/aarch32.h: New file.
6788         * arch/arm.c (arm_create_target_description)
6789         (arm_create_mprofile_target_description): New function.
6790         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6791         (arm_create_target_description)
6792         (arm_create_mprofile_target_description): New declaration.
6793         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6794         read_description functions.
6795         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6796         Likewise.
6797         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6798         * arm-tdep.c (tdesc_arm_list): New variable.
6799         (arm_register_g_packet_guesses): Call create description functions.
6800         (arm_read_description) (arm_read_mprofile_description): New
6801         function.
6802         * arm-tdep.h (arm_read_description)
6803         (arm_read_mprofile_description): Add declaration.
6804         * configure.tgt: Add new files.
6805
6806 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6807
6808         * top.c (new_ui_command): Open specified terminal just once.
6809
6810 2019-07-18  Tom Tromey  <tromey@adacore.com>
6811
6812         * symtab.c (main_name): Constify return type.
6813         * symfile.c (set_initial_language): Update.
6814         * symtab.h (main_name): Constify return type.
6815
6816 2019-07-17  Tom Tromey  <tom@tromey.com>
6817
6818         * tui/tui-winsource.c (tui_update_source_window)
6819         (tui_update_source_window_as_is)
6820         (tui_update_source_windows_with_line): Remove return.
6821         * tui/tui-disasm.c (tui_show_disassem)
6822         (tui_show_disassem_and_update_source): Remove return.
6823         * tui/tui.c (tui_reset): Remove return.
6824         * tui/tui-wingeneral.c
6825         (tui_check_and_display_highlight_if_needed): Remove return.
6826
6827 2019-07-17  Tom Tromey  <tom@tromey.com>
6828
6829         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6830
6831 2019-07-17  Tom Tromey  <tom@tromey.com>
6832
6833         * tui/tui-winsource.h (struct tui_exec_info_window)
6834         (struct tui_source_window_base): Move from tui-data.h.
6835         * tui/tui-winsource.c: Move many method definitions from
6836         elsewhere.  Remove "structuring" comments.
6837         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6838         (tui_source_window_base::refresh_window): Move to
6839         tui-winsource.c.
6840         * tui/tui-win.c (tui_source_window_base::refresh_all)
6841         (tui_source_window_base::update_tab_width)
6842         (tui_source_window_base::set_new_height)
6843         (tui_source_window_base::do_make_visible_with_new_height): Move to
6844         tui-winsource.c.
6845         * tui/tui-source.h: Update.
6846         * tui/tui-source.c (tui_source_window_base::reset): Move to
6847         tui-winsource.c.
6848         * tui/tui-disasm.h: Update.
6849         * tui/tui-data.h (struct tui_exec_info_window): Move to
6850         tui-winsource.h.
6851         (struct tui_source_window_base): Likewise.
6852         * tui/tui-data.c (tui_source_window_base::clear_detail)
6853         (tui_source_window_base, ~tui_source_window_base): Move to
6854         tui-winsource.c.
6855
6856 2019-07-17  Tom Tromey  <tom@tromey.com>
6857
6858         * tui/tui-win.c (tui_resize_all)
6859         (tui_source_window_base::update_tab_width)
6860         (tui_adjust_win_heights): Update.
6861         (tui_win_info::make_invisible_and_set_new_height): Rename from
6862         make_invisible_and_set_new_height.
6863         * tui/tui-data.h (struct tui_win_info)
6864         <make_invisible_and_set_new_height>: New method.
6865
6866 2019-07-17  Tom Tromey  <tom@tromey.com>
6867
6868         * tui/tui.c: Update.
6869         * tui/tui-source.h (struct tui_source_window): Move from
6870         tui-data.h.
6871         * tui/tui-layout.c: Update.
6872         * tui/tui-disasm.c: Update.
6873         * tui/tui-data.h (struct tui_source_window): Move to
6874         tui-source.h.
6875
6876 2019-07-17  Tom Tromey  <tom@tromey.com>
6877
6878         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6879         tui-data.h.
6880         * tui/tui-data.h (struct tui_disasm_window): Move to
6881         tui-disasm.h.
6882
6883 2019-07-17  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-regs.h (struct tui_data_item_window): Move from
6886         tui-data.h.
6887         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6888         * tui/tui-data.h (struct tui_data_item_window): Move to
6889         tui-regs.h.
6890         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6891
6892 2019-07-17  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui.c: Update.
6895         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6896         (tui_cmd_window::max_height): Move to tui-command.c.
6897         * tui/tui-layout.c: Update.
6898         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6899         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6900         tui-command.c.
6901         * tui/tui-command.h (struct tui_cmd_window): Move from
6902         tui-data.h.
6903         * tui/tui-command.c: Remove "structuring" comments.
6904         (tui_cmd_window::clear_detail)
6905         (tui_cmd_window::do_make_visible_with_new_height)
6906         (tui_cmd_window::max_height): Move from elsewhere.
6907
6908 2019-07-17  Tom Tromey  <tom@tromey.com>
6909
6910         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6911         Now static.
6912         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6913         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6914
6915 2019-07-17  Tom Tromey  <tom@tromey.com>
6916
6917         * tui/tui.c: Update.
6918         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6919         tui-regs.c.
6920         * tui/tui-windata.h: Remove file.
6921         * tui/tui-windata.c: Remove file.
6922         * tui/tui-win.c (tui_data_window::set_new_height)
6923         (tui_data_window::do_make_visible_with_new_height): Move to
6924         tui-regs.c.
6925         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6926         * tui/tui-regs.c: Remove "structuring" comments.
6927         (tui_data_window::first_data_item_displayed)
6928         (tui_data_window::delete_data_content_windows)
6929         (tui_data_window::erase_data_content)
6930         (tui_data_window::display_all_data)
6931         (tui_data_window::refresh_all)
6932         (tui_data_window::do_scroll_vertical)
6933         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6934         (tui_data_window::do_make_visible_with_new_height)
6935         (tui_data_window::refresh_window): Move from elsewhere.
6936         (_initialize_tui_regs): Move to end of file.
6937         * tui/tui-layout.c: Update.
6938         * tui/tui-hooks.c: Update.
6939         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6940         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6941         tui-regs.c.
6942         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6943
6944 2019-07-17  Tom Tromey  <tom@tromey.com>
6945
6946         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6947         seen.
6948
6949 2019-07-17  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui-win.c (tui_source_window_base::set_new_height)
6952         (tui_source_window_base::do_make_visible_with_new_height): Use
6953         m_has_locator field directly.
6954         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6955         method.
6956         (struct tui_source_window_base) <has_locator>: Likewise.
6957
6958 2019-07-17  Tom Tromey  <tom@tromey.com>
6959
6960         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6961         Don't declare.
6962         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6963         Remove.
6964         * tui/tui-win.c (tui_source_window_base::set_new_height)
6965         (tui_source_window_base::set_new_height)
6966         (make_invisible_and_set_new_height)
6967         (tui_source_window_base::do_make_visible_with_new_height)
6968         (tui_source_window_base::do_make_visible_with_new_height):
6969         Update.
6970         * tui/tui-layout.c (show_source_disasm_command, show_data)
6971         (show_source_or_disasm_and_command): Update.
6972         * tui/tui-layout.c (show_layout): Update.
6973
6974 2019-07-17  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui-layout.c (make_data_window): Remove.
6977         (show_data): Unify creation and re-initialization cases.
6978
6979 2019-07-17  Tom Tromey  <tom@tromey.com>
6980
6981         * tui/tui-layout.c (make_source_window, make_disasm_window):
6982         Remove.
6983         (show_data): Unify creation and re-initialization cases.
6984
6985 2019-07-17  Tom Tromey  <tom@tromey.com>
6986
6987         * tui/tui-layout.c (make_command_window): Remove.
6988         (show_source_disasm_command, show_source_or_disasm_and_command):
6989         Unify creation and re-initialization cases.
6990
6991 2019-07-17  Tom Tromey  <tom@tromey.com>
6992
6993         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6994         creation and re-initialization cases.
6995
6996 2019-07-17  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-regs.c (tui_get_register): Return void.
6999
7000 2019-07-17  Tom Tromey  <tom@tromey.com>
7001
7002         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
7003         Simplify.
7004
7005 2019-07-17  Tom Tromey  <tom@tromey.com>
7006
7007         * tui/tui-layout.c (show_source_disasm_command): Simplify window
7008         resetting.
7009
7010 2019-07-17  Tom Tromey  <tom@tromey.com>
7011
7012         * tui/tui.h (tui_set_layout_by_name): Don't declare.
7013         * tui/tui-regs.c (tui_reg_layout): New function.
7014         (tui_show_registers, tui_reg_command): Use it.
7015         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7016         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
7017         parameters.
7018         (tui_layout_command): Remove.
7019
7020 2019-07-17  Tom Tromey  <tom@tromey.com>
7021
7022         * tui/tui-layout.h (tui/tui-layout): Return void.
7023         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
7024
7025 2019-07-17  Tom Tromey  <tom@tromey.com>
7026
7027         * tui/tui-layout.c (show_source_disasm_command, show_data):
7028         Update.
7029         (reset_locator): Remove.
7030         (show_source_or_disasm_and_command): Update.
7031
7032 2019-07-17  Tom Tromey  <tom@tromey.com>
7033
7034         * tui/tui-source.c (tui_source_window_base::reset): Remove
7035         win_type parameter.
7036         * tui/tui-layout.c (make_command_window, make_source_window)
7037         (make_disasm_window, make_data_window)
7038         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7039         (reset_locator, show_source_or_disasm_and_command): Update.
7040         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7041         win_type parameter.
7042         (struct tui_source_window_base) <reset>: Likewise.
7043
7044 2019-07-17  Tom Tromey  <tom@tromey.com>
7045
7046         * tui/tui-layout.c (show_source_disasm_command): Use
7047         reset_locator.
7048         (reset_locator): New function.
7049         (init_and_make_win): Remove.
7050         (show_source_or_disasm_and_command): Use reset_locator.
7051
7052 2019-07-17  Tom Tromey  <tom@tromey.com>
7053
7054         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7055         condition.
7056         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7057         Remove condition.
7058         * tui/tui-source.c (tui_source_window_base::reset): New method.
7059         * tui/tui-layout.c (make_command_window): Don't call
7060         init_and_make_win.
7061         (make_source_window, make_disasm_window): Don't call
7062         make_source_or_disasm_window.
7063         (make_data_window): Don't call init_and_make_win.  Change calling
7064         convention.
7065         (show_source_disasm_command, show_data): Simplify.
7066         (make_source_or_disasm_window): Remove.
7067         (show_source_or_disasm_and_command): Simplify.
7068         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7069         (struct tui_source_window_base) <reset>: Likewise.
7070         <execution_info>: Remove initializer.
7071         * tui/tui-data.c (tui_source_window_base): Initialize
7072         execution_info.
7073
7074 2019-07-17  Tom Tromey  <tom@tromey.com>
7075
7076         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7077         variable.
7078
7079 2019-07-17  Tom Tromey  <tom@tromey.com>
7080
7081         * tui/tui.c (tui_rl_other_window): Update.
7082         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7083         superclass method first.  Always iterate over regs_content.
7084         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7085         method.
7086         * tui/tui-win.c (tui_set_focus_command): Update.
7087
7088 2019-07-17  Tom Tromey  <tom@tromey.com>
7089
7090         * tui/tui-win.c (tui_set_focus_command): Rename from
7091         tui_set_focus.  Call tui_enable.
7092         (tui_set_focus_command): Remove.
7093
7094 2019-07-17  Tom Tromey  <tom@tromey.com>
7095
7096         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7097         refresh_window.
7098         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7099         touchwin.
7100         (tui_data_window::refresh_window): Call refresh_window on data
7101         items.  Always call superclass refresh_window.
7102         (tui_win_info::refresh): Remove.
7103         (tui_source_window_base::refresh_window): Update.
7104         (tui_refresh_all): Update.
7105         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7106         refresh_window.
7107         (show_source_or_disasm_and_command): Likewise.
7108         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7109         (struct tui_source_window_base) <refresh>: Likewise.
7110
7111 2019-07-17  Tom Tromey  <tom@tromey.com>
7112
7113         * tui/tui-winsource.c (tui_clear_source_content)
7114         (tui_show_source_content): Update.
7115         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7116         whether content is empty.
7117         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7118         Remove.
7119
7120 2019-07-17  Tom Tromey  <tom@tromey.com>
7121
7122         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7123         window's contents.
7124         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7125         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7126
7127 2019-07-17  Tom Tromey  <tom@tromey.com>
7128
7129         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7130         (struct tui_data_item_window): Update.
7131
7132 2019-07-17  Tom Tromey  <tom@tromey.com>
7133
7134         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7135         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7136         defines.
7137
7138 2019-07-17  Tom Tromey  <tom@tromey.com>
7139
7140         * tui/tui-winsource.h (tui_erase_source_content)
7141         (tui_clear_source_content): Remove "display_prompt" parameter.
7142         * tui/tui-winsource.c (tui_update_source_window_as_is)
7143         (tui_update_source_windows_with_addr): Update.
7144         (tui_clear_source_content): Remove "display_prompt" parameter.
7145         (tui_erase_source_content): Likewise.  Simplify.
7146         (tui_show_source_content): Update.
7147         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7148         * tui/tui-stack.c (tui_show_frame_info): Update.
7149         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7150         Remove defines.
7151
7152 2019-07-17  Tom Tromey  <tom@tromey.com>
7153
7154         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7155         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7156         parameter.
7157         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7158         parameter.
7159
7160 2019-07-17  Tom Tromey  <tom@tromey.com>
7161
7162         * tui/tui-winsource.c (tui_clear_source_content)
7163         (tui_show_source_content, tui_show_exec_info_content)
7164         (tui_clear_exec_info_content): Update.
7165         * tui/tui-stack.c (tui_show_locator_content): Update.
7166         (tui_show_frame_info): Update.
7167         * tui/tui-source.h (tui_source_window): Don't declare.
7168         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7169         from tui_source_is_displayed.
7170         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7171         Remove field.
7172         (struct tui_source_window_base) <content_in_use>: New field.  Now
7173         bool.
7174         (struct tui_source_window) <showing_source_p>: New method.
7175         (TUI_SRC_WIN): Change cast.
7176         * tui/tui-data.c (tui_initialize_static_data): Update.
7177
7178 2019-07-17  Tom Tromey  <tom@tromey.com>
7179
7180         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7181         location_matches_p.
7182         * tui/tui-source.c (tui_source_window::location_matches_p): New
7183         method.
7184         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7185         method.
7186         * tui/tui-data.h (struct tui_source_window_base)
7187         <location_matches_p>: New method.
7188         (struct tui_source_window, struct tui_disasm_window)
7189         <location_matches_p>: Likewise.
7190
7191 2019-07-17  Tom Tromey  <tom@tromey.com>
7192
7193         * tui/tui-win.c (tui_set_win_height_command): Rename from
7194         tui_set_win_height.
7195         (tui_set_win_height_command): Remove.
7196
7197 2019-07-17  Tom Tromey  <tom@tromey.com>
7198
7199         * tui/tui-source.c (tui_source_window): New constructor.  Add
7200         observer.
7201         (~tui_source_window): New destructor.
7202         (tui_source_window::style_changed): New method.
7203         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7204         (tui_attach_detach_observers): Update.
7205         * tui/tui-data.h (struct tui_source_window): Make constructor not
7206         inline.  Add destructor.
7207         (struct tui_source_window) <style_changed>: New method.
7208         <m_observable>: New member.
7209
7210 2019-07-17  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7213         * tui/tui-win.c (tui_resize_all): Fix typo.
7214
7215 2019-07-17  Tom Tromey  <tom@tromey.com>
7216
7217         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7218         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7219         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7220         * tui/tui-win.c (window_name_completer): Use foreach.
7221         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7222         (update_tab_width): Likewise.
7223         * tui/tui-layout.c (show_layout): Update.
7224         * tui/tui-data.h (class tui_window_iterator): New.
7225         (struct all_tui_windows): New.
7226         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7227
7228 2019-07-17  Tom Tromey  <tom@tromey.com>
7229
7230         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7231         parameter.  Don't reference globals.
7232         (tui_reg_command): Update.
7233
7234 2019-07-17  Tom Tromey  <tom@tromey.com>
7235
7236         * tui/tui-regs.c (tui_show_registers): Simplify.
7237
7238 2019-07-17  Tom Tromey  <tom@tromey.com>
7239
7240         * tui/tui-regs.c (tui_show_registers): Update.
7241         (tui_show_register_group): Add win_info parameter.
7242
7243 2019-07-17  Tom Tromey  <tom@tromey.com>
7244
7245         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7246         Rename from tui_display_reg_element_at_line.
7247         (tui_data_window::display_registers_from_line): Update.
7248         * tui/tui-data.h (struct tui_data_window)
7249         <display_reg_element_at_line>: New method.
7250
7251 2019-07-17  Tom Tromey  <tom@tromey.com>
7252
7253         * tui/tui-regs.h (tui_display_registers_from)
7254         (tui_display_registers_from_line): Don't declare.
7255         * tui/tui-windata.c (tui_data_window::display_all_data)
7256         (tui_data_window::refresh_all)
7257         (tui_data_window::do_scroll_vertical): Update.
7258         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7259         from tui_display_registers_from.
7260         (tui_display_reg_element_at_line): Update.
7261         (tui_data_window::display_registers_from_line): Rename from
7262         tui_display_registers_from_line.
7263         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7264         display_registers_from_line>: New methods.
7265
7266 2019-07-17  Tom Tromey  <tom@tromey.com>
7267
7268         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7269         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7270         from tui_erase_data_content.
7271         (tui_data_window::display_all_data)
7272         (tui_data_window::refresh_all)
7273         (tui_data_window::do_scroll_vertical): Update.
7274         * tui/tui-regs.c (tui_show_registers): Update.
7275         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7276         New method.
7277
7278 2019-07-17  Tom Tromey  <tom@tromey.com>
7279
7280         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7281         declare.
7282         * tui/tui-windata.c
7283         (tui_data_window::delete_data_content_windows): Rename from
7284         tui_delete_data_content_windows.
7285         (tui_data_window::display_all_data)
7286         (tui_data_window::do_scroll_vertical): Update.
7287         * tui/tui-data.h (struct tui_data_window)
7288         <delete_data_content_windows>: New method.
7289
7290 2019-07-17  Tom Tromey  <tom@tromey.com>
7291
7292         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7293         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7294
7295 2019-07-17  Tom Tromey  <tom@tromey.com>
7296
7297         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7298         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7299         from tui_display_all_data.
7300         * tui/tui-win.c
7301         (tui_data_window::do_make_visible_with_new_height): Update.
7302         * tui/tui-regs.c (tui_show_registers): Update.
7303         * tui/tui-layout.c (tui_set_layout): Update.
7304         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7305         method.
7306
7307 2019-07-17  Tom Tromey  <tom@tromey.com>
7308
7309         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7310         * tui/tui-windata.c (tui_display_data_from): Remove.
7311         (tui_data_window::refresh_all): Update.
7312
7313 2019-07-17  Tom Tromey  <tom@tromey.com>
7314
7315         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7316         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7317         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7318         tui_display_registers_from_line.
7319         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7320         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7321         "force_display" parameter.
7322
7323 2019-07-17  Tom Tromey  <tom@tromey.com>
7324
7325         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7326         declare.
7327         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7328         Rename from tui_first_reg_element_no_inline.
7329         (tui_display_reg_element_at_line)
7330         (tui_display_registers_from_line): Update.
7331         * tui/tui-data.h (struct tui_data_window)
7332         <first_reg_element_no_inline>: New method.
7333
7334 2019-07-17  Tom Tromey  <tom@tromey.com>
7335
7336         * tui/tui-windata.c (tui_display_data_from)
7337         (tui_data_window::do_scroll_vertical): Update.
7338         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7339         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7340         Rename from tui_line_from_reg_element_no.
7341         (tui_display_registers_from_line): Update.
7342         * tui/tui-data.h (struct tui_data_window)
7343         <line_from_reg_element_no>: New method.
7344
7345 2019-07-17  Tom Tromey  <tom@tromey.com>
7346
7347         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7348         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7349         tui_last_regs_line_no.
7350         (tui_display_reg_element_at_line)
7351         (tui_display_registers_from_line): Update.
7352         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7353         method.
7354
7355 2019-07-17  Tom Tromey  <tom@tromey.com>
7356
7357         PR tui/24722:
7358         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7359         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7360         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7361         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7362         (tui_update_breakpoint_info): Likewise.
7363         * tui/tui-hooks.c (tui_event_create_breakpoint)
7364         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7365         Update.
7366
7367 2019-07-17  Tom Tromey  <tom@tromey.com>
7368
7369         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7370
7371 2019-07-17  Tom Tromey  <tom@tromey.com>
7372
7373         * tui/tui-winsource.c (tui_update_source_window_as_is)
7374         (tui_update_source_windows_with_addr): Update.
7375         * tui/tui-source.h (tui_set_source_content)
7376         (tui_show_symtab_source): Add "win_info" parameter.
7377         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7378         parameter.
7379         (tui_show_symtab_source): Likewise.
7380
7381 2019-07-17  Tom Tromey  <tom@tromey.com>
7382
7383         * tui/tui-wingeneral.c
7384         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7385
7386 2019-07-17  Tom Tromey  <tom@tromey.com>
7387
7388         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7389         (struct tui_cmd_window) <can_scroll>: New method.
7390         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7391         method.
7392
7393 2019-07-17  Tom Tromey  <tromey@adacore.com>
7394
7395         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7396         do_field_signed>: Rename.  Change type of "value".
7397         * ui-out.c (ui_out::field_signed): Rename from field_int.
7398         Change type of "value".
7399         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7400         type of "value".
7401         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7402         do_field_int.  Change type of "value".
7403         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7404         do_field_int.  Change type of "value".
7405         * tracepoint.c (trace_status_mi, tfind_1)
7406         (print_one_static_tracepoint_marker): Update.
7407         * thread.c (print_thread_info_1, print_selected_thread_frame):
7408         Update.
7409         * stack.c (print_frame, print_frame_info): Update.
7410         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7411         Update.
7412         * source.c (print_source_lines_base): Update.
7413         * skip.c (info_skip_command): Update.
7414         * record-btrace.c (btrace_ui_out_decode_error)
7415         (btrace_call_history_src_line): Update.
7416         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7417         Update.
7418         * progspace.c (print_program_space): Update.
7419         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7420         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7421         do_field_int.  Change type of "value".
7422         * mi/mi-out.c (mi_ui_out::do_table_begin)
7423         (mi_ui_out::do_table_header): Update.
7424         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7425         type of "value".
7426         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7427         (mi_cmd_data_list_changed_registers, output_register)
7428         (mi_cmd_data_read_memory, mi_load_progress)
7429         (mi_cmd_trace_frame_collected): Update.
7430         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7431         Update.
7432         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7433         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7434         (mi_cmd_var_list_children, varobj_update_one): Update.
7435         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7436         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7437         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7438         * inferior.c (print_inferior): Update.
7439         * gdb_bfd.c (print_one_bfd): Update.
7440         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7441         Update.
7442         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7443         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7444         do_field_int.  Change type of "value".
7445         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7446         do_field_int.  Change type of "value".
7447         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7448         (print_one_breakpoint_location, print_it_catch_fork)
7449         (print_one_catch_fork, print_it_catch_vfork)
7450         (print_one_catch_vfork, print_it_catch_solib)
7451         (print_it_catch_exec, print_it_ranged_breakpoint)
7452         (print_mention_watchpoint, print_mention_masked_watchpoint)
7453         (bkpt_print_it, update_static_tracepoint): Update.
7454         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7455         * break-catch-syscall.c (print_it_catch_syscall): Update.
7456         * ada-tasks.c (print_ada_task_info): Update.
7457         * ada-lang.c (print_it_exception, print_mention_exception):
7458         Update.
7459
7460 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         PR breakpoints/24541
7463         * gdbarch.c: Regenerate.
7464         * gdbarch.h: Regenerate.
7465         * gdbarch.sh: Adjust return type and parameter types for
7466         'stap_adjust_register'.
7467         (i386_stap_adjust_register): Adjust signature and return new
7468         register name.
7469         * stap-probe.c (stap_parse_register_operand): Adjust use of
7470         'gdbarch_stap_adjust_register'.
7471
7472 2019-07-17  Tom Tromey  <tromey@adacore.com>
7473
7474         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7475         declare VEC.
7476         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7477         std::vector.
7478         (struct s390_process_info): Add initializers.
7479         (s390_add_process): Use new.
7480         (s390_linux_nat_target::low_forget_process): Use delete.
7481         (s390_linux_nat_target::low_new_fork)
7482         (s390_linux_nat_target::stopped_by_watchpoint)
7483         (s390_linux_nat_target::low_prepare_to_resume)
7484         (s390_linux_nat_target::insert_watchpoint)
7485         (s390_linux_nat_target::insert_hw_breakpoint)
7486         (s390_linux_nat_target::remove_watchpoint)
7487         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7488
7489 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7490
7491         * aarch64-fbsd-nat.c: Include regcache.h.
7492         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7493         argument.
7494         (aarch64_fbsd_nat_target::fetch_registers)
7495         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7496         variable.
7497         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7498
7499 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7500
7501         * fbsd-nat.c: Include gdbarch.h.
7502
7503 2019-07-15  Tom Tromey  <tromey@adacore.com>
7504
7505         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7506
7507 2019-07-15  Tom Tromey  <tromey@adacore.com>
7508
7509         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7510         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7511         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7512         * cli-out.c (cli_ui_out::do_field_int): New method.
7513         * ui-out.c (ui_out::field_unsigned): New method.
7514         * symfile.c (generic_load): Use field_unsigned.
7515         (print_transfer_performance): Likewise.
7516         * record-btrace.c (ui_out_field_uint): Remove.
7517         (btrace_call_history_insn_range, btrace_call_history): Use
7518         field_unsigned.
7519         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7520         field_unsigned.
7521         * ui-out.h (class ui_out) <field_unsigned>: New method.
7522         <do_field_unsigned>: Likewise.
7523
7524 2019-07-15  Tom Tromey  <tromey@adacore.com>
7525
7526         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7527         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7528         * target.c (flash_erase_command): Use field_string.
7529         * infrun.c (print_signal_received_reason): Use field_string.
7530         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7531         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7532         field_string.
7533         * ada-tasks.c (print_ada_task_info): Use field_string.
7534
7535 2019-07-15  Tom Tromey  <tromey@adacore.com>
7536
7537         * target.c (flash_erase_command): Use field_core_addr.
7538         * symfile.c (generic_load): Use field_core_addr.
7539         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7540         Use field_core_addr.
7541         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7542         field_core_addr.
7543
7544 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7547         value if its desired type is smaller than a CORE_ADDR and signed.
7548
7549 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7552         of changes to field names, and use new is_reference field to
7553         decide if a property is a reference or not.
7554         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7555         field.
7556         (struct dwarf2_property_baton): Update header comment, rename
7557         'referenced_type' to 'property_type' and update comments.
7558         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7559         default property type, store in property baton, update to take
7560         accound of renamed field.
7561         (read_func_scope): Update call to attr_to_dynamic_prop.
7562         (read_array_type): Likewise.
7563         (dwarf2_per_cu_addr_sized_int_type): New function.
7564         (read_subrange_index_type): Move type finding code to
7565         dwarf2_per_cu_addr_sized_int_type.
7566         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7567         (dwarf2_per_cu_addr_type): New function.
7568         (set_die_type): Update calls to attr_to_dynamic_prop.
7569
7570 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * dwarf2read.c (read_subrange_index_type): New function.
7573         (read_subrange_type): Move code into new function and call it.
7574         * gdbtypes.c (create_range_type): Add some asserts.
7575
7576 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7579         update return statements.
7580         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7581         declaration, and update comment to match.
7582         * gdbtypes.c (resolve_dynamic_array): Update call to
7583         dwarf2_evaluate_property to match new return type.
7584
7585 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7586
7587         * valarith.c (value_subscripted_rvalue): Change lowerbound
7588         parameter type from int to LONGEST.
7589         * value.h (value_subscripted_rvalue): Likewise in declaration.
7590
7591 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7592
7593         * cli/cli-utils.c (info_print_command_completer): New function.
7594         * cli/cli-utils.h: Add 'completer.h' include, and forward
7595         declaration for 'struct cmd_list_element'.
7596         (info_print_command_completer): Declare.
7597         * stack.c (_initialize_stack): Add completer for 'info locals' and
7598         'info args'.
7599         * symtab.c (_initialize_symtab): Add completer for 'info
7600         variables' and 'info functions'.
7601         * NEWS: Mention completion for additional info commands.
7602
7603 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * cli/cli-utils.c (extract_info_print_args): Delete.
7606         (extract_arg_maybe_quoted): Delete.
7607         (info_print_options_defs): New variable.
7608         (make_info_print_options_def_group): New function.
7609         (extract_info_print_options): Define new function.
7610         * cli/cli-utils.h (extract_info_print_args): Delete.
7611         (struct info_print_options): New structure.
7612         (extract_info_print_options): Declare new function.
7613         * stack.c (info_locals_command): Update to use new
7614         extract_info_print_options, also add a header comment.
7615         (info_args_command): Likewise.
7616         * symtab.c (info_variables_command): Likewise.
7617         (info_functions_command): Likewise.
7618
7619 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7622         to extract string arguments.
7623         * common/common-utils.c (extract_string_maybe_quoted): New function.
7624         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7625
7626 2019-07-11  Tom Tromey  <tromey@adacore.com>
7627
7628         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7629         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7630         * top.h (gdbinit): Don't declare.
7631         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7632         into...
7633         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7634         * top.c (gdb_init): Don't call init_cli_cmds.
7635         (gdbinit): Remove.
7636         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7637
7638 2019-07-11  Tom Tromey  <tromey@adacore.com>
7639
7640         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7641         after it has been moved.
7642
7643 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7644
7645         * valops.c (value_must_coerce_to_target): Change return type to
7646         bool.
7647         * value.h (value_must_coerce_to_target): Likewise.
7648
7649 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7650
7651         * breakpoint.c (is_hardware_watchpoint): Remove
7652         forward-declaration.
7653         (is_masked_watchpoint): Change return type to bool.
7654         (is_tracepoint): Likewise.
7655         (is_breakpoint): Likewise.
7656         (is_hardware_watchpoint): Likewise.
7657         (is_watchpoint): Likewise.
7658         (is_no_memory_software_watchpoint): Likewise.
7659         (is_catchpoint): Likewise.
7660         (breakpoint_1): Make FILTER parameter's return type bool.
7661         is_masked_watchpoint): Change return type to bool.
7662         (save_breakpoints): Make FILTER parameter's return type bool.
7663         * breakpoint.h (is_breakpoint): Change return type to bool.
7664         (is_watchpoint): Likewise.
7665         (is_catchpoint): Likewise.
7666         (is_tracepoint): Likewise.
7667
7668 2019-07-10  Tom Tromey  <tom@tromey.com>
7669
7670         * defs.h: Don't include gdbarch.h.
7671         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7672         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7673         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7674         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7675         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7676         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7677         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7678         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7679         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7680         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7681         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7682         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7683         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7684         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7685         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7686         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7687         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7688         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7689         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7690         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7691         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7692         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7693         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7694         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7695         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7696         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7697         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7698
7699 2019-07-10  Tom Tromey  <tromey@adacore.com>
7700
7701         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7702         * breakpoint.c (init_ada_exception_breakpoint): Register as
7703         bp_catchpoint.
7704         (print_one_breakpoint_location, print_one_breakpoint): Use
7705         is_ada_exception_catchpoint.
7706         * ada-lang.c (class ada_catchpoint_location): Pass
7707         bp_loc_software_breakpoint to bp_location constructor.
7708         (is_ada_exception_catchpoint): New function.
7709
7710 2019-07-10  Tom Tromey  <tromey@adacore.com>
7711
7712         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7713         VEC.
7714         (struct arm_exidx_entry): New method operator<.
7715         (struct arm_exidx_data) <section_maps>: Change type.
7716         (arm_exidx_data_free): Remove.
7717         (arm_exidx_data_key): Change type.  Move lower.
7718         (arm_exidx_new_objfile): Update.
7719         (arm_compare_exidx_entries): Remove.
7720         (arm_find_exidx_entry, _initialize_arm_tdep)
7721
7722 2019-07-10  Tom Tromey  <tromey@adacore.com>
7723
7724         * solib-spu.c (ocl_program_data_key): Change type.
7725         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7726         Update.
7727
7728 2019-07-10  Tom Tromey  <tromey@adacore.com>
7729
7730         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7731         (struct solib_aix_inferior_data) <library_list>: Change type.
7732         (solib_aix_inferior_data_handle): Change type.
7733         (get_solib_aix_inferior_data): Update.
7734         (solib_aix_free_library_list): Remove.
7735         (library_list_start_library): Update.
7736         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7737         return type.
7738         (solib_aix_get_library_list)
7739         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7740         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7741
7742 2019-07-10  Tom Tromey  <tromey@adacore.com>
7743
7744         * solib-dsbt.c (struct dsbt_info): Add initializers.
7745         (solib_dsbt_pspace_data): Change type.
7746         (dsbt_pspace_data_cleanup): Remove.
7747         (get_dsbt_info, _initialize_dsbt_solib): Update.
7748
7749 2019-07-10  Tom Tromey  <tromey@adacore.com>
7750
7751         * spu-tdep.c (spu_overlay_data): Change type.
7752         (spu_get_overlay_table, spu_overlay_new_objfile)
7753         (_initialize_spu_tdep): Update.
7754
7755 2019-07-10  Tom Tromey  <tromey@adacore.com>
7756
7757         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7758         destructor.
7759         (dbx_objfile_data_key): Change type and declare later.
7760         (DBX_SYMFILE_INFO): Rewrite.
7761         * dbxread.c (dbx_objfile_data_key): Change type.
7762         (dbx_symfile_init): Update.
7763         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7764         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7765         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7766
7767 2019-07-10  Tom Tromey  <tromey@adacore.com>
7768
7769         * jit.c (jit_program_space_key): Change type.  Move lower.
7770         (get_jit_program_space_data): Update.
7771         (jit_program_space_data_cleanup): Remove.
7772         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7773         Update.
7774         (struct jit_program_space_data): Add initializers.
7775
7776 2019-07-10  Tom Tromey  <tromey@adacore.com>
7777
7778         * solib-darwin.c (struct darwin_info): Add initializers.
7779         (solib_darwin_pspace_data): Change type.
7780         (darwin_pspace_data_cleanup): Remove.
7781         (get_darwin_info, _initialize_darwin_solib): Update.
7782
7783 2019-07-10  Tom Tromey  <tromey@adacore.com>
7784
7785         * remote-sim.c (struct sim_inferior_data): Add initializers,
7786         constructor, and destructor.
7787         (sim_inferior_data_key): Change type.  Move lower.
7788         (check_for_duplicate_sim_descriptor): Update.
7789         (get_sim_inferior_data): Use new.  Update.
7790         (~sim_inferior_data_cleanup): Rename from
7791         sim_inferior_data_cleanup.  Simplify.
7792         (gdbsim_close_inferior, simulator_command)
7793         (sim_command_completer, _initialize_remote_sim): Update.
7794         (next_pid, INITIAL_PID): Move earlier.
7795
7796 2019-07-10  Tom Tromey  <tromey@adacore.com>
7797
7798         * python/python-internal.h (create_thread_object): Return
7799         gdbpy_ref.
7800         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7801         * python/py-inferior.c (struct threadlist_entry): Add
7802         constructor.
7803         <thread_obj>: Now a gdbpy_ref.
7804         (thread_to_thread_object): Update.
7805         (add_thread_object): Use new.
7806         (delete_thread_object): Use delete.
7807         (infpy_threads): Update.
7808         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7809         GIL.
7810
7811 2019-07-10  Tom Tromey  <tromey@adacore.com>
7812
7813         * valops.c (value_cast): Specialize error message for Ada.
7814
7815 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7816
7817         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7818
7819 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7820
7821         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7822         bpstat_should_step): Return bool, adjust comments.
7823         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7824         bpstat_should_step): Likewise.
7825
7826 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7827
7828         * features/Makefile: Use feature target descriptions for Arm.
7829         * features/arm/arm-core.c: Generate new file.
7830         * features/arm/arm-fpa.c: Likewise.
7831         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7832         * features/arm/arm-m-profile.c: Likewise.
7833         * features/arm/arm-vfpv2.c: Likewise.
7834         * features/arm/arm-vfpv3.c: Likewise.
7835         * features/arm/xscale-iwmmxt.c: Likewise.
7836         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7837
7838 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7839
7840         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7841         ptrace earlier.
7842
7843 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7844
7845         * features/aarch64-pauth.c: Regenerate.
7846
7847 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7848
7849         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7850         bool.
7851         (bpstat_what): Use false instead of 0.
7852
7853 2019-07-09  Pedro Alves  <palves@redhat.com>
7854
7855         * break-catch-throw.c (is_exception_catchpoint): New.
7856         * breakpoint.c (print_one_breakpoint_location): New parameter
7857         'raw_loc'.  Handle it.  Use
7858         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7859         looking at the breakpoint's type.
7860         (print_one_breakpoint): If handling "maint info breakpoints", also
7861         print locations of exception catchpoints.
7862         * breakpoint.h (is_exception_catchpoint): Declare.
7863
7864 2019-07-09  Pedro Alves  <palves@redhat.com>
7865
7866         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7867         "addr" field.
7868         (allocate_location_exception_catchpoint): New.
7869         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7870         (initialize_throw_catchpoint_ops): Install
7871         allocate_location_exception_catchpoint as allocate_location
7872         method.
7873         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7874         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7875         bp_loc_other.
7876         (breakpoint_address_is_meaningful): Delete.
7877         (bl_address_is_meaningful): New.
7878         (breakpoint_locations_match): Adjust comment.
7879         (bp_location_from_bp_type): New, factored out of...
7880         (bp_location::bp_location(breakpoint *)): ... this.
7881         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7882         factored out of...
7883         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7884         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7885         breakpoint_address_is_meaningful.
7886         (bp_locations_compare): Adjust comment.
7887         (update_global_location_list): Use bl_address_is_meaningful
7888         instead of breakpoint_address_is_meaningful.
7889         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7890         explicit.
7891         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7892         * python/py-breakpoint.c (bppy_get_location): No longer check
7893         whether location is null.
7894
7895 2019-07-09  Pedro Alves  <palves@redhat.com>
7896
7897         PR c++/15468
7898         * breakpoint.c (print_one_breakpoint_location): Remove
7899         single-location assert.
7900
7901 2019-07-09  Tom Tromey  <tom@tromey.com>
7902
7903         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7904         * configure: Rebuild.
7905         * configure.ac: Change common to gdbsupport.
7906         * gdbsupport: Rename from common.
7907         * acinclude.m4: Change common to gdbsupport.
7908         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7909         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7910         gdbsupport.
7911         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7912         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7913         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7914         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7915         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7916         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7917         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7918         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7919         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7920         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7921         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7922         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7923         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7924         coff-pe-read.c, command.h, compile/compile-c-support.c,
7925         compile/compile-c.h, compile/compile-cplus-symbols.c,
7926         compile/compile-cplus-types.c, compile/compile-cplus.h,
7927         compile/compile-loc2c.c, compile/compile.c, completer.c,
7928         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7929         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7930         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7931         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7932         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7933         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7934         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7935         features/aarch64-core.c, features/aarch64-fpu.c,
7936         features/aarch64-pauth.c, features/aarch64-sve.c,
7937         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7938         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7939         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7940         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7941         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7942         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7943         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7944         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7945         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7946         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7947         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7948         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7949         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7950         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7951         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7952         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7953         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7954         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7955         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7956         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7957         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7958         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7959         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7960         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7961         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7962         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7963         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7964         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7965         minsyms.c, mips-linux-tdep.c, namespace.h,
7966         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7967         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7968         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7969         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7970         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7971         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7972         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7973         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7974         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7975         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7976         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7977         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7978         procfs.c, producer.c, progspace.h, psymtab.h,
7979         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7980         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7981         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7982         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7983         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7984         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7985         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7986         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7987         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7988         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7989         target-memory.c, target.c, target.h, target/waitstatus.c,
7990         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7991         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7992         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7993         unittests/array-view-selftests.c,
7994         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7995         unittests/common-utils-selftests.c,
7996         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7997         unittests/format_pieces-selftests.c,
7998         unittests/function-view-selftests.c,
7999         unittests/lookup_name_info-selftests.c,
8000         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
8001         unittests/mkdir-recursive-selftests.c,
8002         unittests/observable-selftests.c,
8003         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
8004         unittests/parse-connection-spec-selftests.c,
8005         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
8006         unittests/scoped_fd-selftests.c,
8007         unittests/scoped_mmap-selftests.c,
8008         unittests/scoped_restore-selftests.c,
8009         unittests/string_view-selftests.c, unittests/style-selftests.c,
8010         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
8011         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8012         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8013         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8014         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8015         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8016
8017 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * linespec.c (decode_digits_list_mode): Set explicit_line to a
8020         bool value.
8021         (decode_digits_ordinary): Set explicit_line field in sal.
8022         * symtab.c (skip_prologue_sal): Don't skip prologue for a
8023         symtab_and_line that was set on an explicit line number in
8024         assembler code.  Do always update the recorded symtab and line if
8025         we do skip the prologue.
8026
8027 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8028
8029         * breakpoint.c (set_breakpoint_location_function): Remove
8030         explicit_loc parameter.
8031         (momentary_breakpoint_from_master): Update call to
8032         set_breakpoint_location_function.
8033         (add_location_to_breakpoint): Likewise.
8034
8035 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8036
8037         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8038         required features based on default bfd type when no specific bfd
8039         is present.
8040
8041 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8042
8043         * NEWS: Mention that GDB printf and eval commands can now print
8044         C-style and Ada-style convenience var strings without
8045         calling the inferior.
8046         * printcmd.c (printf_c_string): Locally print GDB internal var
8047         instead of transiting via the inferior.
8048         (printf_wide_c_string): Likewise.
8049
8050 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8051
8052         PR breakpoints/25011
8053         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8054
8055 2019-07-04  Tom Tromey  <tom@tromey.com>
8056
8057         PR tui/24724:
8058         * tui/tui-winsource.c (tui_clear_source_content): Update.
8059         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8060         (tui_update_breakpoint_info): Update.
8061         (tui_set_exec_info_content): Update.
8062         * tui/tui-source.c (tui_set_source_content_nil): Update.
8063         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8064         has_break.
8065         * tui/tui-data.h (enum tui_bp_flag): New.
8066         (tui_bp_flags): New enum flags type.
8067         (struct tui_source_element) <break_mode>: Change type.  Rename
8068         from has_break.
8069         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8070         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8071         constants.
8072         * tui/tui-winsource.h: Fix comment.
8073
8074 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8075
8076         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8077         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8078         (store_fpregs_to_thread)
8079         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8080         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8081         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8082         (IWMMXT_REGS_SIZE): Add define.
8083         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8084         (fetch_vfp_regs, store_vfp_regs)
8085         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8086         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8087
8088 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8089
8090         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8091         defines.
8092         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8093         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8094         (ARM_INT_REGISTER_SIZE): ...to this.
8095         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8096         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8097         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8098         (arm_linux_collect_gregset, supply_nwfpe_register)
8099         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8100         defines.
8101         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8102         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8103         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8104         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8105         (arm_return_in_memory, arm_store_return_value)
8106         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8107         (arm_record_ld_st_multiple): Likewise.
8108         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8109         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8110
8111 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8112
8113         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8114         AARCH64_DISPLACED_MODIFIED_INSNS.
8115         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8116         (aarch64_displaced_step_copy_insn): Likewise.
8117         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8118         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8119         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8120         ARM_DISPLACED_MODIFIED_INSNS.
8121         * arm-tdep.c (arm_gdbarch_init): Likewise.
8122         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8123         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8124         (struct arm_displaced_step_closure): Use
8125         ARM_DISPLACED_MODIFIED_INSNS.
8126
8127 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8128
8129         * features/Makefile: Remove unused xml files.
8130         * features/aarch64.xml: Remove.
8131         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8132         * features/i386/amd64-avx-avx512.xml: Remove.
8133         * features/i386/amd64-avx-linux.xml: Remove.
8134         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8135         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8136         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8137         * features/i386/amd64-avx-mpx.xml: Remove.
8138         * features/i386/amd64-avx.xml: Remove.
8139         * features/i386/amd64-linux.xml: Remove.
8140         * features/i386/amd64-mpx-linux.xml: Remove.
8141         * features/i386/amd64-mpx.xml: Remove.
8142         * features/i386/amd64.xml: Remove.
8143         * features/i386/i386-avx-avx512-linux.xml: Remove.
8144         * features/i386/i386-avx-avx512.xml: Remove.
8145         * features/i386/i386-avx-linux.xml: Remove.
8146         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8147         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8148         * features/i386/i386-avx-mpx-linux.xml: Remove.
8149         * features/i386/i386-avx-mpx.xml: Remove.
8150         * features/i386/i386-avx.xml: Remove.
8151         * features/i386/i386-linux.xml: Remove.
8152         * features/i386/i386-mmx-linux.xml: Remove.
8153         * features/i386/i386-mmx.xml: Remove.
8154         * features/i386/i386-mpx-linux.xml: Remove.
8155         * features/i386/i386-mpx.xml: Remove.
8156         * features/i386/i386.xml: Remove.
8157         * features/i386/x32-avx-avx512-linux.xml: Remove.
8158         * features/i386/x32-avx-linux.xml: Remove.
8159         * features/i386/x32-linux.xml: Remove.
8160
8161 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8162
8163         * regformats/aarch64.dat: Remove.
8164         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8165         * regformats/i386/amd64-avx-linux.dat: Remove.
8166         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8167         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8168         * regformats/i386/amd64-linux.dat: Remove.
8169         * regformats/i386/amd64-mpx-linux.dat: Remove.
8170         * regformats/i386/amd64.dat: Remove.
8171         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8172         * regformats/i386/i386-avx-linux.dat: Remove.
8173         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8174         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8175         * regformats/i386/i386-linux.dat: Remove.
8176         * regformats/i386/i386-mmx-linux.dat: Remove.
8177         * regformats/i386/i386-mpx-linux.dat: Remove.
8178         * regformats/i386/i386.dat: Remove.
8179         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8180         * regformats/i386/x32-avx-linux.dat: Remove.
8181         * regformats/i386/x32-linux.dat: Remove.
8182
8183 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8184
8185         * aarch64-tdep.c: Remove xml self tests.
8186         * amd64-linux-tdep.c: Likewise.
8187         * amd64-tdep.c: Likewise.
8188         * i386-linux-tdep.c: Likewise.
8189         * i386-tdep.c: Likewise.
8190
8191 2019-07-03  Pedro Alves  <palves@redhat.com>
8192
8193         PR cli/24732
8194         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8195         (pipe_cmd_option_defs): New.
8196         (make_pipe_cmd_options_def_group): New.
8197         (pipe_command): Use gdb::option::process_options.
8198         (pipe_command_completer): New function.
8199         (_initialize_cli_cmds): Install completer for "pipe" command.
8200
8201 2019-07-03  Pedro Alves  <palves@redhat.com>
8202
8203         * cli/cli-option.c (union option_value) <string>: New field.
8204         (struct option_def_and_value): Add ctor, move ctor, dtor and
8205         use DISABLE_COPY_AND_ASSIGN.
8206         (option_def_and_value::clear_value): New.
8207         (parse_option, save_option_value_in_ctx, get_val_type_str)
8208         (add_setshow_cmds_for_options): Handle var_string.
8209         * cli-option.h (union option_def::var_address) <string>: New
8210         field.
8211         (struct string_option_def): New.
8212         * maint-test-options.c (struct test_options_opts): Add default
8213         ctor and use DISABLE_COPY_AND_ASSIGN.
8214         <string_opt>: New field.
8215         (test_options_opts::~test_options_opts): New.
8216         (test_options_opts::dump): Also dump "-string".
8217         (test_options_option_defs): Install "string.
8218
8219 2019-07-03  Pedro Alves  <palves@redhat.com>
8220
8221         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8222         option_value with a null enumeration.
8223         (complete_options): Save the option values in the context.
8224         (save_option_value_in_ctx): New, factored out from ...
8225         (process_options): ... here.
8226         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8227         of the function.
8228         * maint-test-options.c (test_options_opts::dump): New, factored
8229         out from ...
8230         (maintenance_test_options_command_mode): ... here.
8231         (maintenance_test_options_command_completion_result): Delete.
8232         (maintenance_test_options_command_completion_text): Update
8233         comment.
8234         (maintenance_show_test_options_completion_result): Change
8235         prototype.  Just print
8236         maintenance_test_options_command_completion_text.
8237         (save_completion_result): New.
8238         (maintenance_test_options_completer_mode): Pass options context to
8239         complete_options, and then save a dump.
8240         (_initialize_maint_test_options): Use add_cmd to install "maint
8241         show test-options-completion-result".
8242
8243 2019-07-03  Pedro Alves  <palves@redhat.com>
8244
8245         * NEWS (New commands): Mention "with" and "maint with".
8246         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8247         (with_command, with_command_completer): New.
8248         (pipe_command): Adjust to new repeat_previous
8249         interface.
8250         (_initialize_cli_cmds): Install the "with" command and its "w"
8251         alias.
8252         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8253         declarations.
8254         * cli/cli-setshow.c (parse_cli_var_uinteger)
8255         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8256         argument strings for all var_types.
8257         (get_setshow_command_value_string): New, factored out from ...
8258         (do_show_command): ... this.
8259         * cli/cli-setshow.h: Include <string>.
8260         (get_setshow_command_value_string): Declare.
8261         * command.h (repeat_previous): Now returns const char *.  Adjust
8262         comment.
8263         * maint.c: Include "cli/cli-cmds.h".
8264         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8265         (_initialize_maint_cmds): Register the "maintenance with" command.
8266         * top.c (repeat_previous): Move bits from pipe_command here:
8267         Return the saved command line, if any; error out if there's no
8268         command to relaunch.
8269
8270 2019-07-03  Pedro Alves  <palves@redhat.com>
8271
8272         * NEWS (New commands): Mention "maint set/show test-settings"
8273         instead of "maint test-settings".
8274         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8275         (maintenance_test_settings_set_list): Rename to ...
8276         (maintenance_set_test_settings_list): ... this.
8277         (maintenance_test_settings_show_list): Rename to  ...
8278         (maintenance_show_test_settings_list): ... this.
8279         (maintenance_test_settings_cmd): Delete.
8280         (maintenance_test_settings_set_cmd): ...
8281         (maintenance_set_test_settings_cmd): ... this.
8282         (maintenance_test_settings_show_cmd): ...
8283         (maintenance_show_test_settings_cmd): ... this.
8284         (maintenance_test_settings_show_value_cmd):
8285         (maintenance_show_test_settings_value_cmd): ... this.
8286         (_initialize_maint_test_settings): No longer install the "maint
8287         test-settings" prefix command.  Rename "maint test-settings set"
8288         to "maint set test-settings", and "maint test-settings show" to
8289         "maint show test-settings".  Adjust all subcommands.
8290
8291 2019-07-03  Pedro Alves  <palves@redhat.com>
8292
8293         * maint-test-settings.c: Fix file's intro comment.  Replace all
8294         references to "test-options" with references to "test-settings",
8295         in comments.
8296
8297 2019-07-03  Pedro Alves  <palves@redhat.com>
8298
8299         * maint-test-settings.c (maintenance_test_settings_xxx)
8300         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8301         New.
8302         (maintenance_test_settings_enums): Use them.
8303         (maintenance_test_settings_enum): Default to
8304         maintenance_test_settings_xxx.
8305         (_initialize_maint_test_settings): Initialize
8306         MAINTENANCE_TEST_SETTINGS_FILENAME.
8307
8308 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8309
8310         * breakpoint.h (remove_breakpoints_inf): Change return type to
8311         void, move function documentation here.
8312         * breakpoint.c (remove_breakpoints_inf): Change return type to
8313         void, move function documentation to header.
8314
8315 2019-07-02  Pedro Alves  <palves@redhat.com>
8316
8317         * NEWS (Completion improvements): Mention "info threads".
8318         * thread.c (struct info_threads_opts, info_threads_option_defs)
8319         (make_info_threads_options_def_group): New.
8320         (info_threads_command): Use gdb::option::process_options.
8321         (info_threads_command_completer): New.
8322         (_initialize_thread): Use gdb::option::build_help to build the
8323         help text for "info threads".
8324
8325 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8326
8327         * defs.h (generic_load): Move from here...
8328         * symfile.h (generic_load): ... to here.  Rename name parameter
8329         to args.
8330         * symfile.c (generic_load): Add comment.
8331
8332 2019-07-01  Tom Tromey  <tromey@adacore.com>
8333
8334         * dwarf2read.c
8335         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8336         declaration of without_params.  Fix formatting.
8337
8338 2019-07-01  Tom Tromey  <tromey@adacore.com>
8339
8340         * ada-exp.y (find_primitive_type): Update.
8341         * ada-lang.h (ada_lookup_symbol): Update.
8342         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8343         parameter.
8344         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8345
8346 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8347
8348         PR breakpoints/24541
8349         * gdbarch.c: Regenerate.
8350         * gdbarch.h: Regenerate.
8351         * gdbarch.sh: Add 'stap_adjust_register'.
8352         * i386-tdep.c: Include '<unordered_set>'.
8353         (i386_stap_adjust_register): New function.
8354         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8355         * stap-probe.c (stap_parse_register_operand): Call
8356         'gdbarch_stap_adjust_register'.
8357
8358 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8359
8360         PR python/24742
8361         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8362         * python/python.c (do_start_initialization): Use 'xmalloc'
8363         instead of 'PyMem_Malloc'.
8364
8365 2019-06-28  Tom Tromey  <tromey@adacore.com>
8366
8367         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8368         for Ada.
8369
8370 2019-06-27  Tom Tromey  <tromey@adacore.com>
8371
8372         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8373         objfile_key.
8374         (arm_find_mapping_symbol, arm_record_special_symbol)
8375         (_initialize_arm_tdep): Update.
8376         (arm_objfile_data_free): Remove.
8377
8378 2019-06-27  Tom Tromey  <tromey@adacore.com>
8379
8380         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8381         to cp_print_static_field.
8382
8383 2019-06-26  Tom Tromey  <tromey@adacore.com>
8384
8385         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8386         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8387         declare.
8388
8389 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8390
8391         * features/aarch64-core.c (create_feature_aarch64_core):
8392         Regenerate.
8393         * features/aarch64-core.xml: Add cpsr flags.
8394
8395 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8396
8397         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8398         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8399
8400 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8401
8402         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8403         field.
8404         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8405         use.
8406         (arm_record_special_symbol): Don't insert new symbol in sorted
8407         position, push it at the end.
8408
8409 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8410
8411         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8412         (arm_mapping_symbol_s): Remove.
8413         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8414         (arm_mapping_symbol_vec): New typedef.
8415         (struct arm_per_objfile): Add constructor.
8416         <section_maps>: Change type to
8417         std::unique_ptr<arm_mapping_symbol_vec[]>.
8418         (arm_compare_mapping_symbols): Remove.
8419         (arm_find_mapping_symbol): Adjust to section_maps type change.
8420         (arm_objfile_data_free): Call delete on arm_per_objfile.
8421         (arm_record_special_symbol): Adjust to section_maps type change.
8422         Allocate arm_per_objfile with new.
8423
8424 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8425
8426         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8427         with the command prefix.
8428
8429 2019-06-25  Tom Tromey  <tom@tromey.com>
8430
8431         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8432         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8433
8434 2019-06-25  Tom Tromey  <tom@tromey.com>
8435
8436         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8437         type.
8438         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8439         protected.
8440
8441 2019-06-25  Tom Tromey  <tom@tromey.com>
8442
8443         * tui/tui-winsource.c
8444         (tui_source_window_base::set_is_exec_point_at): Add check against
8445         LOA_ADDRESS.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui-source.c (tui_set_source_content): Don't check before
8450         xfree.
8451         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8452
8453 2019-06-25  Tom Tromey  <tom@tromey.com>
8454
8455         * tui/tui-winsource.h (tui_update_source_window_as_is)
8456         (tui_alloc_source_buffer, tui_line_is_displayed)
8457         (tui_addr_is_displayed): Change type of win_info.
8458         * tui/tui-winsource.c (tui_update_source_window_as_is)
8459         (tui_clear_source_content, tui_show_source_line)
8460         (tui_show_source_content, tui_source_window_base::refill)
8461         (tui_source_window_base::set_is_exec_point_at)
8462         (tui_source_window_base::set_is_exec_point_at)
8463         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8464         (tui_alloc_source_buffer, tui_line_is_displayed)
8465         (tui_addr_is_displayed): Change type of win_info.  Update.
8466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8467         (tui_source_window_base::do_make_visible_with_new_height):
8468         Update.
8469         * tui/tui-source.c (tui_set_source_content)
8470         (tui_set_source_content_nil)
8471         (tui_source_window::do_scroll_vertical): Update.
8472         * tui/tui-layout.c (show_layout): Update.
8473         * tui/tui-disasm.c (tui_set_disassem_content)
8474         (tui_disasm_window::do_scroll_vertical): Update.
8475         * tui/tui-data.h (tui_win_content): Remove.
8476         (struct tui_gen_win_info) <content, content_size>: Remove.
8477         (struct tui_source_element): Add initializers and destructor.
8478         (union tui_which_element, struct tui_win_element): Remove.
8479         (struct tui_source_window_base) <content>: New field.
8480         (struct tui_data_window): Remove destructor.
8481         (tui_alloc_content, tui_free_win_content)
8482         (tui_free_all_source_wins_content): Don't declare.
8483         * tui/tui-data.c (tui_initialize_static_data): Update.
8484         (init_content_element, tui_alloc_content): Remove.
8485         (~tui_gen_win_info): Update.
8486         (~tui_data_window, tui_free_all_source_wins_content)
8487         (tui_free_win_content, free_content, free_content_elements):
8488         Remove.
8489
8490 2019-06-25  Tom Tromey  <tom@tromey.com>
8491
8492         * tui/tui-winsource.h (tui_clear_source_content)
8493         (tui_erase_source_content, tui_show_source_content): Change type
8494         of win_info.
8495         * tui/tui-winsource.c (tui_clear_source_content)
8496         (tui_erase_source_content, tui_show_source_content): Change type
8497         of win_info.
8498         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8499         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8500         win_info.
8501         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8502         win_info.
8503         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8504
8505 2019-06-25  Tom Tromey  <tom@tromey.com>
8506
8507         * tui/tui-winsource.c (tui_clear_source_content)
8508         (tui_source_window_base::set_is_exec_point_at): Update.
8509         * tui/tui-source.c (tui_set_source_content_nil): Update.
8510         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8511         a bool.
8512         * tui/tui-data.c (init_content_element): Update.
8513
8514 2019-06-25  Tom Tromey  <tom@tromey.com>
8515
8516         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8517         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8518         * tui/tui-layout.c (init_and_make_win): Update.
8519         * tui/tui.h (enum tui_win_type): Update.
8520         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8521         tui_win_is_auxillary.
8522         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8523         tui_win_is_auxillary.
8524
8525 2019-06-25  Tom Tromey  <tom@tromey.com>
8526
8527         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8528         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8529         (tui_delete_data_content_windows, tui_display_all_data)
8530         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8531         Update.
8532         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8533         * tui/tui-regs.c (tui_last_regs_line_no)
8534         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8535         (tui_show_registers): Update.
8536         (tui_show_register_group): Return void.  Update.
8537         (tui_display_registers_from, tui_display_reg_element_at_line)
8538         (tui_display_registers_from_line, tui_check_register_values):
8539         Update.
8540         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8541         member.
8542         (struct tui_data_window) <regs_content>: Now a std::vector.
8543         <regs_content_count>: Remove.
8544         (tui_add_content_elements, tui_free_data_content): Don't declare.
8545         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8546         (init_content_element): Remove DATA_WIN case.  Add assert.
8547         (tui_add_content_elements): Remove.
8548         (tui_data_window): Update.
8549         (tui_free_data_content): Remove.
8550         (free_content_elements): Remove DATA_WIN case.
8551
8552 2019-06-25  Tom Tromey  <tom@tromey.com>
8553
8554         * tui/tui-data.c (tui_data_item_window): Update.
8555         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8556         * tui/tui-windata.c (tui_display_all_data)
8557         (tui_display_data_from_line): Update.
8558         (tui_check_data_values): Remove.
8559         * tui/tui-regs.c (tui_show_register_group)
8560         (tui_display_reg_element_at_line): Update.
8561         * tui/tui-hooks.c (tui_register_changed)
8562         (tui_refresh_frame_and_register_information): Call
8563         tui_check_register_values.
8564         * tui/tui-data.h (struct tui_data_window) <data_content,
8565         data_content_count, data_type>: Remove.
8566         (enum tui_data_type): Remove.
8567
8568         * tui/tui-data.c (tui_data_window::clear_detail)
8569         (~tui_data_window): Update.
8570
8571 2019-06-25  Tom Tromey  <tom@tromey.com>
8572
8573         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8574         declare.
8575         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8576         Rename from tui_first_data_item_displayed.  Update.
8577         (tui_data_window::refresh_all)
8578         (tui_data_window::do_scroll_vertical): Update.
8579         * tui/tui-data.h (struct tui_data_window)
8580         <first_data_item_displayed>: Declare new method.
8581
8582 2019-06-25  Tom Tromey  <tom@tromey.com>
8583
8584         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8585         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8586         contents...
8587         (tui_initialize_static_data): ...here.
8588
8589 2019-06-25  Tom Tromey  <tom@tromey.com>
8590
8591         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8592         (tui_display_registers_from, tui_check_register_values): Update.
8593         (tui_display_register): Remove win_info parameter; update.
8594         (tui_get_register): Change type of parameters.
8595         * tui/tui-data.h (struct tui_data_element): Remove.
8596         (union tui_which_element) <data>: Remove.
8597         <data_window>: Change type.
8598         (struct tui_data_item_window): New.
8599         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8600         case.  Add assert.
8601         (~tui_data_item_window): New destructor.
8602         (free_content_elements): Remove DATA_ITEM_WIN case.
8603
8604 2019-06-25  Tom Tromey  <tom@tromey.com>
8605
8606         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8607         Remove.
8608
8609 2019-06-25  Tom Tromey  <tom@tromey.com>
8610
8611         * tui/tui-data.h (struct tui_command_element): Remove.
8612         (union tui_which_element) <command>: Remove.
8613         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8614         assert.
8615         (free_content_elements): Remove CMD_WIN case.
8616
8617 2019-06-25  Tom Tromey  <tom@tromey.com>
8618
8619         * tui/tui-layout.c (tui_set_layout): Update.
8620         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8621         * tui/tui-data.c (layout_def): Update.
8622
8623 2019-06-25  Tom Tromey  <tom@tromey.com>
8624
8625         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8626         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8627         (tui_source_window_base::set_new_height): Update.
8628         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8629         Update.
8630         (tui_set_locator_fullname, tui_set_locator_info)
8631         (tui_show_frame_info): Update.
8632         * tui/tui-source.c (tui_set_source_content)
8633         (tui_source_is_displayed): Update.
8634         * tui/tui-layout.c (show_source_disasm_command, show_data)
8635         (show_source_or_disasm_and_command): Update.
8636         * tui/tui-disasm.c (tui_set_disassem_content)
8637         (tui_get_begin_asm_address): Update.
8638         * tui/tui-data.h (struct tui_locator_element): Remove.
8639         (union tui_which_element) <locator>: Remove.
8640         (struct tui_locator_window): New.
8641         (tui_locator_win_info_ptr): Change return type.
8642         * tui/tui-data.c (_locator): Change type.
8643         (tui_locator_win_info_ptr): Change return type.
8644         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8645         (tui_alloc_content): Add assert.
8646
8647 2019-06-25  Tom Tromey  <tom@tromey.com>
8648
8649         * tui/tui-winsource.c
8650         (tui_exec_info_window::maybe_allocate_content): New method.
8651         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8652         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8653         (make_source_or_disasm_window): Add cast.
8654         * tui/tui-data.h (union tui_which_element) <simple_string>:
8655         Remove.
8656         (struct tui_source_info): New.
8657         (struct tui_source_window_base) <execution_info>: Change type.
8658         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8659         case, and add assert.
8660         (tui_alloc_content): Add assert.
8661
8662 2019-06-25  Tom Tromey  <tom@tromey.com>
8663
8664         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8665         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8666         * tui/tui-data.c (tui_alloc_win_info): Remove.
8667
8668 2019-06-25  Tom Tromey  <tom@tromey.com>
8669
8670         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8671         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8672         can_highlight.
8673
8674 2019-06-25  Tom Tromey  <tom@tromey.com>
8675
8676         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8677         make_visible_with_new_height method.
8678         (tui_win_info::make_visible_with_new_height): New method.
8679         (tui_source_window_base::do_make_visible_with_new_height)
8680         (tui_data_window::do_make_visible_with_new_height)
8681         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8682         (make_visible_with_new_height): Remove.
8683         (tui_resize_all, tui_adjust_win_heights): Use
8684         make_visible_with_new_height method.
8685         * tui/tui-data.h (struct tui_win_info)
8686         <do_make_visible_with_new_height, make_visible_with_new_height>:
8687         New methods.
8688         (struct tui_source_window_base, struct tui_data_window)
8689         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8690         methods.
8691
8692 2019-06-25  Tom Tromey  <tom@tromey.com>
8693
8694         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8695         method.
8696         (update_tab_width): Call update_tab_width method.
8697         * tui/tui-data.h (struct tui_win_info)
8698         (struct tui_source_window_base) <update_tab_width>: New methods.
8699
8700 2019-06-25  Tom Tromey  <tom@tromey.com>
8701
8702         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8703         parameter.
8704         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8705         parameter.
8706         (tui_gen_win_info::make_visible): Update.
8707         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8708         parameter.
8709         * tui/tui-data.h (enum tui_box): New enum.
8710         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8711
8712 2019-06-25  Tom Tromey  <tom@tromey.com>
8713
8714         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8715         init_and_make_win for EXEC_INFO_WIN.
8716         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8717         longer inline.
8718         (struct tui_win_info) <~tui_win_info>: Inline.
8719         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8720         Don't declare.
8721         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8722         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8723         Remove.
8724         (tui_initialize_static_data): Update.
8725         (~tui_gen_win_info): Handle more cleanup here.
8726         (~tui_source_window_base): Delete "execution_info".
8727         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8728
8729 2019-06-25  Tom Tromey  <tom@tromey.com>
8730
8731         * tui/tui-layout.c (make_command_window): Don't set
8732         can_highlight.
8733         (show_source_disasm_command): Call the reset method.
8734         (show_data): Don't set can_highlight.  Call the reset method.
8735         (tui_gen_win_info::reset): Rename from init_gen_win_info
8736         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8737         (show_source_or_disasm_and_command): Call the reset method.
8738         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8739         (struct tui_cmd_window): Set can_highlight.
8740
8741 2019-06-25  Tom Tromey  <tom@tromey.com>
8742
8743         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8744         from make_visible.
8745         (tui_make_visible, tui_make_invisible): Rewrite.
8746         (tui_win_info::make_visible): Remove.
8747         (tui_source_window_base::make_visible): Update.
8748         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8749         method.  Moved from...
8750         (struct tui_win_info) <make_visible>: ...here.
8751
8752 2019-06-25  Tom Tromey  <tom@tromey.com>
8753
8754         * tui/tui-winsource.c
8755         (tui_source_window_base::do_scroll_horizontal): Remove direction
8756         parameter.
8757         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8758         direction parameter.
8759         * tui/tui-win.c (tui_win_info::forward_scroll)
8760         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8761         (tui_win_info::right_scroll): Update.
8762         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8763         direction parameter.
8764         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8765         direction parameter.
8766         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8767         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8768         Remove direction parameter.
8769         (struct tui_source_window_base, struct tui_source_window)
8770         (struct tui_disasm_window, struct tui_data_window)
8771         (struct tui_cmd_window): Update.
8772
8773 2019-06-25  Tom Tromey  <tom@tromey.com>
8774
8775         * tui/tui-winsource.h (tui_set_exec_info_content)
8776         (tui_show_exec_info_content, tui_erase_exec_info_content)
8777         (tui_clear_exec_info_content, tui_update_exec_info): Change
8778         argument to tui_source_window_base.
8779         * tui/tui-winsource.c (tui_set_exec_info_content)
8780         (tui_show_exec_info_content, tui_erase_exec_info_content)
8781         (tui_clear_exec_info_content, tui_update_exec_info): Change
8782         argument to tui_source_window_base.
8783
8784 2019-06-25  Tom Tromey  <tom@tromey.com>
8785
8786         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8787         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8788
8789 2019-06-25  Tom Tromey  <tom@tromey.com>
8790
8791         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8792         check.
8793
8794 2019-06-25  Tom Tromey  <tom@tromey.com>
8795
8796         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8797         type to void.
8798         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8799         type to void.
8800         * tui/tui-source.c (tui_set_source_content): Update.
8801         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8802
8803 2019-06-25  Tom Tromey  <tom@tromey.com>
8804
8805         * tui/tui-win.c (window_name_completer, tui_set_focus)
8806         (tui_all_windows_info): Use name method.
8807         * tui/tui-data.h (struct tui_gen_win_info)
8808         (struct tui_source_window, struct tui_disasm_window)
8809         (struct tui_data_window, struct tui_cmd_window) <name>: New
8810         method.
8811         (tui_win_name): Don't declare.
8812         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8813         (tui_win_name): Remove.
8814
8815 2019-06-25  Tom Tromey  <tom@tromey.com>
8816
8817         * tui/tui-winsource.h (tui_update_source_window)
8818         (tui_update_source_window_as_is): Change parameter type.
8819         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8820         to be a tui_source_window_base.
8821         (tui_update_source_window_as_is): Likewise.
8822         * tui/tui-win.c (make_visible_with_new_height): Update.
8823
8824 2019-06-25  Tom Tromey  <tom@tromey.com>
8825
8826         * tui/tui-winsource.c (tui_erase_source_content)
8827         (tui_show_source_content, tui_show_exec_info_content)
8828         (tui_erase_exec_info_content): Use refresh_window method.
8829         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8830         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8831         from tui_refresh_win.
8832         (tui_data_window::refresh_window): New method.
8833         (tui_win_info::refresh, tui_source_window_base::refresh)
8834         (tui_refresh_all): Use refresh_window method.
8835         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8836         method.
8837         * tui/tui-regs.c (tui_display_register): Call refresh_window
8838         method.
8839         * tui/tui-layout.c (show_source_disasm_command)
8840         (show_source_or_disasm_and_command): Call refresh_window method.
8841         * tui/tui-data.h (struct tui_gen_win_info)
8842         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8843         New method.
8844
8845 2019-06-25  Tom Tromey  <tom@tromey.com>
8846
8847         * tui/tui.c (tui_rl_other_window, tui_enable)
8848         (tui_is_window_visible, tui_get_command_dimension): Update.
8849         * tui/tui-winsource.c (tui_update_source_window_as_is)
8850         (tui_clear_source_content, tui_erase_source_content)
8851         (tui_show_source_line, tui_source_window_base::refill)
8852         (tui_source_window_base::do_scroll_horizontal)
8853         (tui_source_window_base::set_is_exec_point_at)
8854         (tui_update_breakpoint_info, tui_set_exec_info_content)
8855         (tui_alloc_source_buffer, tui_line_is_displayed)
8856         (tui_addr_is_displayed): Update.
8857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8858         (tui_check_and_display_highlight_if_needed)
8859         (tui_win_info::make_visible, tui_win_info::refresh)
8860         (tui_refresh_all): Update.
8861         * tui/tui-windata.c (tui_first_data_item_displayed)
8862         (tui_delete_data_content_windows, tui_erase_data_content)
8863         (tui_display_all_data, tui_data_window::refresh_all)
8864         (tui_check_data_values): Update.
8865         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8866         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8867         (tui_win_info::backward_scroll, tui_refresh_all_win)
8868         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8869         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8870         (tui_source_window_base::set_new_height)
8871         (tui_data_window::set_new_height)
8872         (make_invisible_and_set_new_height)
8873         (make_visible_with_new_height, new_height_ok)
8874         (parse_scrolling_args): Update.
8875         * tui/tui-stack.c (tui_show_frame_info): Update.
8876         * tui/tui-source.c (tui_set_source_content)
8877         (tui_set_source_content_nil, tui_source_is_displayed)
8878         (tui_source_window::do_scroll_vertical): Update.
8879         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8880         (tui_display_registers_from, tui_display_reg_element_at_line)
8881         (tui_check_register_values, tui_reg_command): Update.
8882         * tui/tui-layout.c (tui_default_win_height)
8883         (show_source_disasm_command, show_data, init_and_make_win)
8884         (show_source_or_disasm_and_command): Update.
8885         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8886         (tui_redisplay_readline, tui_mld_flush)
8887         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8888         (tui_getc): Update.
8889         * tui/tui-disasm.c (tui_set_disassem_content)
8890         (tui_disasm_window::do_scroll_vertical): Update.
8891         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8892         Now virtual.
8893         (struct tui_win_info): Derive from tui_gen_win_info.
8894         <~tui_win_info>: Mark as override.
8895         <generic>: Remove member.
8896         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8897         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8898         (~tui_data_window, ~tui_win_info)
8899         (tui_free_all_source_wins_content): Update.
8900         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8901
8902 2019-06-25  Tom Tromey  <tom@tromey.com>
8903
8904         * tui/tui-layout.c (init_and_make_win): Use new.
8905         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8906         destructor, initializers.
8907         (tui_alloc_generic_win_info): Don't declare.
8908         * tui/tui-data.c (_locator): Add argument to constructor.
8909         (source_win, disasm_win): New globals.
8910         (exec_info): Remove.
8911         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8912         Update.
8913         (tui_alloc_generic_win_info): Remove.
8914         (init_content_element): Use new.
8915         (tui_win_info::tui_win_info): Update.
8916         (free_content_elements) <case DATA_WIN>: Use delete.
8917
8918 2019-06-25  Tom Tromey  <tom@tromey.com>
8919
8920         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8921         * tui/tui-windata.c (tui_first_data_item_displayed)
8922         (tui_delete_data_content_windows): Update.
8923         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8924         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8925         (tui_display_registers_from, tui_check_register_values): Update.
8926         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8927         pointer.
8928         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8929         window.
8930         (tui_free_data_content): Update.
8931         (free_content_elements) <case DATA_WIN>: Free the window.
8932
8933 2019-06-25  Tom Tromey  <tom@tromey.com>
8934
8935         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8936         Update.
8937         * tui/tui-layout.c (make_command_window)
8938         (show_source_disasm_command, show_data, init_and_make_win)
8939         (show_source_or_disasm_and_command): Update.
8940         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8941         method.
8942         <can_highight, is_highlighted>: Now bool.
8943         (tui_set_win_highlight): Don't declare.
8944         * tui/tui-data.c (tui_set_win_highlight): Remove.
8945
8946 2019-06-25  Tom Tromey  <tom@tromey.com>
8947
8948         * tui/tui-wingeneral.c (make_visible): Remove check of window
8949         type.
8950
8951 2019-06-25  Tom Tromey  <tom@tromey.com>
8952
8953         * tui/tui-win.c (tui_win_info::max_height)
8954         (tui_cmd_window::max_height): New methods.
8955         (new_height_ok): Call max_height.
8956         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8957         <max_height>: New method.
8958
8959 2019-06-25  Tom Tromey  <tom@tromey.com>
8960
8961         * tui/tui-win.c (tui_source_window_base::set_new_height)
8962         (tui_data_window::set_new_height): New methods.
8963         (make_invisible_and_set_new_height): Call set_new_height method.
8964         * tui/tui-data.h (struct tui_win_info)
8965         (struct tui_source_window_base, struct tui_data_window)
8966         <set_new_height>: New method.
8967
8968 2019-06-25  Tom Tromey  <tom@tromey.com>
8969
8970         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8971         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8972         tui_refresh_data_win.
8973         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8974         method.
8975         (tui_refresh_all_win): Call the refresh_all method.
8976         (tui_set_focus): Likewise.
8977         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8978         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8979         Likewise.
8980
8981 2019-06-25  Tom Tromey  <tom@tromey.com>
8982
8983         * tui/tui-winsource.h (tui_refill_source_window)
8984         (tui_set_is_exec_point_at): Don't declare.
8985         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8986         (tui_source_window_base::refill): Rename from
8987         tui_refill_source_window.
8988         (tui_source_window_base::do_scroll_horizontal): Update.
8989         (tui_source_window_base::set_is_exec_point_at): Rename from
8990         tui_set_is_exec_point_at.
8991         (tui_update_all_breakpoint_info): Update.
8992         * tui/tui-stack.c (tui_show_frame_info): Update.
8993         * tui/tui-layout.c (show_data): Add cast.
8994         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8995         * tui/tui-data.h (struct tui_source_window_base) <refill,
8996         set_is_exec_point_at>: New methods.
8997         (tui_source_windows, tui_add_to_source_windows): Update types.
8998         (tui_add_to_source_windows): Remove redundant declaration.
8999         * tui/tui-data.c (source_windows): Store tui_source_window_base.
9000         (tui_source_windows): Change return type.
9001         (tui_clear_source_windows_detail): Update.
9002         (tui_add_to_source_windows): Change type of parameter.
9003         (tui_free_all_source_wins_content): Update.
9004
9005 2019-06-25  Tom Tromey  <tom@tromey.com>
9006
9007         * tui/tui-wingeneral.c (tui_win_info::refresh)
9008         (tui_source_window_base::refresh): New methods.
9009         (tui_refresh_all): Call the refresh method.
9010         * tui/tui-data.h (struct tui_win_info)
9011         (struct tui_source_window_base) <refresh>: New method.
9012
9013 2019-06-25  Tom Tromey  <tom@tromey.com>
9014
9015         * tui/tui.h (tui_is_window_visible): Return bool.
9016         * tui/tui.c (tui_is_window_visible): Return bool.
9017         * tui/tui-wingeneral.c (tui_make_window, make_visible)
9018         (tui_make_visible, tui_make_invisible)
9019         (tui_win_info::make_visible)
9020         (tui_source_window_base::make_visible, make_all_visible)
9021         (tui_make_all_visible, tui_make_all_invisible): Update.
9022         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9023         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9024         bool.
9025         (struct tui_win_info, struct tui_source_window_base)
9026         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9027         * tui/tui-data.c (tui_init_generic_part): Update.
9028
9029 2019-06-25  Tom Tromey  <tom@tromey.com>
9030
9031         * tui/tui-wingeneral.c (tui_win_info::make_visible)
9032         (tui_source_window_base::make_visible): New methods.
9033         (make_all_visible): Make method call.
9034         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9035         (struct tui_source_window_base, struct tui_cmd_window): Override
9036         make_visible.
9037         (tui_win_is_source_type): Don't declare.
9038         * tui/tui-data.c (tui_win_is_source_type): Remove.
9039
9040 2019-06-25  Tom Tromey  <tom@tromey.com>
9041
9042         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9043         NULL check.
9044
9045 2019-06-25  Tom Tromey  <tom@tromey.com>
9046
9047         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9048         Inline constructor.  Add initializers for members.
9049         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9050         constructors; now inline in class.
9051
9052 2019-06-25  Tom Tromey  <tom@tromey.com>
9053
9054         * tui/tui-regs.c (tui_show_registers): Update.
9055         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9056         bool.
9057         * tui/tui-data.c (tui_data_window::clear_detail)
9058         (tui_data_window): Update.
9059
9060 2019-06-25  Tom Tromey  <tom@tromey.com>
9061
9062         * tui/tui-windata.c (tui_display_all_data)
9063         (tui_display_data_from_line, tui_display_data_from)
9064         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9065         Update.
9066         * tui/tui-regs.c (tui_last_regs_line_no)
9067         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9068         (tui_show_registers, tui_show_register_group)
9069         (tui_display_registers_from, tui_display_reg_element_at_line)
9070         (tui_display_registers_from_line, tui_check_register_values)
9071         (tui_reg_next, tui_reg_prev): Update.
9072         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9073         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9074         tui_data_window.
9075         (struct tui_win_info) <detail>: Remove.  Add new fields from
9076         tui_data_info.
9077         (TUI_DATA_WIN): Add cast.
9078         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9079         (~tui_data_window): Simplify.
9080
9081 2019-06-25  Tom Tromey  <tom@tromey.com>
9082
9083         * tui/tui-layout.c (show_source_disasm_command)
9084         (show_source_or_disasm_and_command): Update.
9085         * tui/tui-io.c (update_cmdwin_start_line)
9086         (tui_redisplay_readline): Update.
9087         * tui/tui-data.h (struct tui_command_info): Remove.
9088         (struct tui_win_info) <detail>: Remove command_info member.
9089         (struct tui_data_window) <start_line>: New member, from
9090         tui_command_info.
9091         (TUI_CMD_WIN): Add casts.
9092
9093 2019-06-25  Tom Tromey  <tom@tromey.com>
9094
9095         * tui/tui-winsource.c (tui_update_source_window)
9096         (tui_refill_source_window)
9097         (tui_source_window_base::do_scroll_horizontal)
9098         (tui_update_breakpoint_info, tui_set_exec_info_content)
9099         (tui_show_exec_info_content, tui_erase_exec_info_content)
9100         (tui_clear_exec_info_content): Update.
9101         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9102         Update.
9103         * tui/tui-win.c (make_invisible_and_set_new_height)
9104         (make_visible_with_new_height): Update.
9105         * tui/tui-source.c (tui_set_source_content)
9106         (tui_show_symtab_source): Update.
9107         * tui/tui-layout.c (extract_display_start_addr)
9108         (show_source_disasm_command, show_data)
9109         (make_source_or_disasm_window)
9110         (show_source_or_disasm_and_command): Update.
9111         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9112         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9113         "gdbarch".
9114         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9115         to tui_source_window_base.
9116         (struct tui_win_info) <detail>: Remove source_info member.
9117         (struct tui_source_window_base) <has_locator>: Inline.
9118         Move contents from tui_source_info; rename has_locator member to
9119         m_has_locator.
9120         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9121         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9122         header file.
9123         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9124         Simplify.
9125         (tui_free_all_source_wins_content): Cast to
9126         tui_source_window_base.
9127
9128 2019-06-25  Tom Tromey  <tom@tromey.com>
9129
9130         * tui/tui-win.c (make_invisible_and_set_new_height)
9131         (make_visible_with_new_height): Call has_locator method.
9132         * tui/tui-layout.c (show_source_disasm_command, show_data)
9133         (show_source_or_disasm_and_command): Update for bool change.
9134         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9135         (tui_win_info) <has_locator>: New method.
9136         (struct tui_source_window_base) <has_locator>: New method.
9137         (tui_win_has_locator): Don't declare.
9138         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9139         from tui_win_has_locator.
9140         (tui_source_window_base): Use false, not FALSE.
9141
9142 2019-06-25  Tom Tromey  <tom@tromey.com>
9143
9144         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9145         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9146         clear_detail method directly.
9147         (tui_clear_win_detail): Remove.
9148
9149 2019-06-25  Tom Tromey  <tom@tromey.com>
9150
9151         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9152         "this", not TUI_DISASM_WIN.
9153
9154 2019-06-25  Tom Tromey  <tom@tromey.com>
9155
9156         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9157         declare.
9158         * tui/tui-winsource.c
9159         (tui_source_window_base::do_scroll_horizontal): Rename from
9160         tui_horizontal_source_scroll.
9161         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9162         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9163         from tui_vertical_data_scroll.
9164         * tui/tui-win.h (tui_scroll): Don't declare.
9165         * tui/tui-win.c (tui_win_info::forward_scroll)
9166         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9167         (tui_win_info::right_scroll): Rename and update.
9168         (tui_scroll_forward_command, tui_scroll_backward_command)
9169         (tui_scroll_left_command, tui_scroll_right_command): Update.
9170         (tui_scroll): Remove.
9171         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9172         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9173         from tui_vertical_source_scroll.
9174         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9175         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9176         from tui_vertical_disassem_scroll.
9177         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9178         do_scroll_horizontal>: New methods.
9179         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9180         Likewise.
9181         (struct tui_source_window_base): Add do_scroll_horizontal.
9182         (struct tui_source_window, struct tui_disasm_window): Add
9183         do_scroll_vertical.
9184         (struct tui_data_window, struct tui_cmd_window): Add
9185         do_scroll_horizontal and do_scroll_vertical.
9186         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9187
9188 2019-06-25  Tom Tromey  <tom@tromey.com>
9189
9190         * tui/tui-data.h (struct tui_source_window_base): New struct.
9191         (struct tui_source_window): Derive from tui_source_window_base.
9192         (struct tui_disasm_window): New struct.
9193         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9194         from tui_source_window::clear_detail.
9195         (tui_source_window_base): Rename from tui_source_window.
9196         (~tui_source_window_base): Rename from ~tui_source_window.
9197         (tui_alloc_win_info): Create a tui_disasm_window.
9198
9199 2019-06-25  Tom Tromey  <tom@tromey.com>
9200
9201         * tui/tui-data.h (struct tui_source_window)
9202         (struct tui_data_window): Declare destructors.
9203         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9204         destructors.
9205         (tui_win_info): Simplify.
9206
9207 2019-06-25  Tom Tromey  <tom@tromey.com>
9208
9209         * tui/tui-winsource.c (tui_display_main)
9210         (tui_update_source_windows_with_addr)
9211         (tui_update_all_breakpoint_info): Update.
9212         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9213         (new_height_ok, parse_scrolling_args): Update.
9214         * tui/tui-stack.c (tui_show_frame_info): Update.
9215         * tui/tui-data.h (struct tui_list): Remove.
9216         (tui_source_windows): Return a reference to a std::vector.
9217         * tui/tui-data.c (source_windows): Now a std::vector.
9218         (tui_source_windows): Change return type.
9219         (tui_clear_source_windows): Rewrite.
9220         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9221         (tui_free_all_source_wins_content): Rewrite.
9222
9223 2019-06-25  Tom Tromey  <tom@tromey.com>
9224
9225         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9226         (struct tui_data_window, struct tui_cmd_window): Declare
9227         clear_detail method.
9228         * tui/tui-data.c (tui_source_window::clear_detail)
9229         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9230         methods.
9231         (tui_clear_win_detail): Simplify.
9232
9233 2019-06-25  Tom Tromey  <tom@tromey.com>
9234
9235         * tui/tui-layout.c (make_source_window, make_disasm_window)
9236         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9237         Return the new window.
9238         (show_source_disasm_command, show_data)
9239         (show_source_or_disasm_and_command): Update.
9240
9241 2019-06-25  Tom Tromey  <tom@tromey.com>
9242
9243         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9244         parameter.  Return the new window.
9245         (show_source_disasm_command): Update and remove NULL check.
9246         (show_source_or_disasm_and_command): Update.
9247
9248 2019-06-25  Tom Tromey  <tom@tromey.com>
9249
9250         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9251
9252 2019-06-25  Tom Tromey  <tom@tromey.com>
9253
9254         * tui/tui-data.h (struct tui_win_info): Make constructor
9255         protected.  Make destructor virtual.  Add initializers.
9256         (tui_source_window, tui_data_window, tui_cmd_window): New
9257         classes.
9258         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9259         constructor.  Add "type" parameter.
9260         (tui_source_window, tui_data_window, tui_cmd_window): New
9261         constructors.
9262         (tui_alloc_win_info): Instantiate the appropriate subclass.
9263
9264 2019-06-25  Tom Tromey  <tom@tromey.com>
9265
9266         * tui/tui-win.c (tui_resize_all): Use delete.
9267         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9268         destructor.
9269         (tui_free_window): Don't declare.
9270         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9271         Update.
9272
9273 2019-06-25  Tom Tromey  <tom@tromey.com>
9274
9275         * tui/tui-data.h (struct tui_win_info): Add constructor.
9276         * tui/tui-data.c (tui_alloc_win_info): Use new.
9277         (tui_free_window): Use delete.
9278
9279 2019-06-22  Tom Tromey  <tom@tromey.com>
9280
9281         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9282         declare.
9283         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9284
9285 2019-06-22  Tom Tromey  <tom@tromey.com>
9286
9287         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9288         declare.
9289         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9290
9291 2019-06-22  Tom de Vries  <tdevries@suse.de>
9292
9293         * dwarf2read.c (create_addrmap_from_aranges)
9294         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9295         instead of '%zu'.
9296
9297 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9298
9299         * dwarf2read.h (dwarf2_section_info_def): Remove.
9300         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9301         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9302         std::vector<dwarf2_section_info>.
9303         (struct dwo_file) <~dwo_file>: Remove.
9304         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9305         types field.
9306         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9307         (dwarf2_read_debug_names): Likewise.
9308         (create_debug_types_hash_table): Change parameter type to
9309         array_view, adjust code accordingly.
9310         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9311         (partial_die_info::fixup): Likewise.
9312         (determine_prefix): Likewise.
9313         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9314
9315 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9316
9317         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9318         gdb_bfd_ref_ptr.
9319         <~dwo_file>: Remove call to gdb_bfd_unref.
9320         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9321         gdb_bfd_ref_ptr::get.
9322
9323 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9324
9325         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9326         type to htab_up.
9327         * dwarf2read.c (struct dwo_file): Initialize fields.
9328         <~dwo_file>: New.
9329         (free_dwo_file): Remove, move content to ~dwo_file.
9330         (struct dwo_file_deleter): Remove.
9331         (dwo_file_up>: Remove custom deleter.
9332         (free_dwo_files): Remove.
9333         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9334         dwo_files.
9335         (process_skeletonless_type_units): Call unique_ptr::get.
9336         (allocate_dwo_file_hash_table): Add deleter to created hash
9337         table.  Change return type to htab_up.
9338         (lookup_dwo_file_slot): Don't memset dwo_file, call
9339         unique_ptr::get.
9340         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9341         (create_dwo_unit_in_dwp_v2): Likewise.
9342         (open_and_init_dwo_file): Likewise.
9343         (free_dwo_file_from_slot): Remove.
9344
9345 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9346
9347         * dwarf2read.h (struct dwarf2_section_info) <readin,
9348         is_virtual>: Change type to bool.
9349         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9350         true instead of 1.
9351
9352 2019-06-19  Tom Tromey  <tom@tromey.com>
9353
9354         * tui/tui-data.h (tui_init_content_element): Don't declare.
9355
9356 2019-06-19  Tom Tromey  <tom@tromey.com>
9357
9358         * tui/tui-data.h (tui_init_win_info): Don't declare.
9359
9360 2019-06-19  Tom de Vries  <tdevries@suse.de>
9361
9362         * dwarf2read.h (abstract_to_concrete): Change type to
9363         std::unordered_map<sect_offset, std::vector<sect_offset>,
9364         gdb::hash_enum<sect_offset>>.
9365
9366 2019-06-19  Tom Tromey  <tromey@adacore.com>
9367
9368         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9369         EVAL_AVOID_SIDE_EFFECTS specially.
9370
9371 2019-06-19  Tom Tromey  <tromey@adacore.com>
9372
9373         * source-cache.c (highlighter): New global.
9374         (source_cache::get_source_lines): Create a highlighter on demand.
9375
9376 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9377
9378         * defs.h (deprecated_interactive_hook): Delete declaration.
9379         * interps.c (clear_interpreter_hooks): Remove use of
9380         deprecated_interactive_hook.
9381         * top.c (deprecated_interactive_hook): Delete definition.
9382         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9383
9384 2019-06-18  Tom de Vries  <tdevries@suse.de>
9385
9386         PR gdb/24515
9387         * dwarf2read.h (abstract_to_concrete): Change type from
9388         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9389         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9390         * dwarf2read.c (read_variable): Update.
9391         (dwarf2_fetch_die_loc_sect_off): Update.
9392
9393 2019-06-17  Tom de Vries  <tdevries@suse.de>
9394
9395         PR gdb/24617
9396         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9397         accessing parent[parent_len - 1].
9398
9399 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9400
9401         PR gdb/24364
9402         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9403         call dtrace_process_dof with NULL dof.
9404
9405 2019-06-16  Tom de Vries  <tdevries@suse.de>
9406
9407         PR gdb/24445
9408         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9409
9410 2019-06-16  Tom Tromey  <tom@tromey.com>
9411
9412         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9413         (make_all_visible): Use address of member.
9414
9415 2019-06-16  Tom Tromey  <tom@tromey.com>
9416
9417         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9418         (tui_free_window, free_content, free_content_elements): Remove
9419         unnecessary cast.
9420         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9421         cast.
9422         * tui/tui-regs.c (tui_show_register_group)
9423         (tui_display_registers_from, tui_display_reg_element_at_line):
9424         Remove unnecessary cast.
9425
9426 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9427
9428         * linux-nat.c (normal_mask): Delete.
9429         (_initialize_linux_nat): Don't initialise normal_mask.
9430
9431 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9432
9433         PR gdb/24445
9434         * dwarf-index-write.h (write_psymtabs_to_index): Add
9435         dwz_basename parameter.
9436         * dwarf-index-write.c (write_gdbindex): Move file writing to
9437         write_gdbindex_1.  Change return type void.
9438         (assert_file_size): Move up, remove filename parameter.
9439         (write_gdbindex_1): New function.
9440         (write_debug_names): Change return type to void, call
9441         assert_file_size.
9442         (struct index_wip_file): New struct.
9443         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9444         file logic to index_wip_file.  Write index for dwz file if
9445         needed.
9446         (save_gdb_index_command): Pass basename of dwz file, if present.
9447         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9448         build-id of dwz file, if present.
9449         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9450         (dwarf2_get_dwz_file): Likewise.
9451         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9452         (dwarf2_get_dwz_file): Likewise.
9453
9454 2019-06-16  Tom Tromey  <tom@tromey.com>
9455
9456         * coffread.c (process_coff_symbol): Use xstrdup.
9457         * value.c (create_internalvar): Use xstrdup.
9458
9459 2019-06-16  Tom Tromey  <tom@tromey.com>
9460
9461         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9462         * breakpoint.c (stopin_command, stopat_command)
9463         (until_break_command, decode_location_default): Remove unnecessary
9464         cast.
9465         * utils.c (subset_compare): Remove unnecessary cast.
9466         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9467         cast.
9468         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9469         cast.
9470         * infcmd.c (path_command): Remove unnecessary cast.
9471         * coffread.c (decode_type): Remove unnecessary cast.
9472         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9473         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9474         * tui/tui-stack.c (tui_show_locator_content)
9475         (tui_show_frame_info): Remove unnecessary cast.
9476         * tui/tui-win.c (tui_scroll_forward_command)
9477         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9478         (parse_scrolling_args): Remove unnecessary cast.
9479         * tui/tui-data.c (init_win_info, tui_del_window)
9480         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9481         (free_content_elements): Remove unnecessary cast.
9482         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9483         unnecessary cast.
9484         * tui/tui-source.c (tui_set_source_content)
9485         (tui_vertical_source_scroll): Remove unnecessary cast.
9486         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9487         cast.
9488         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9489         * tui/tui-regs.c (tui_display_registers_from)
9490         (tui_display_register): Remove unnecessary cast.
9491         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9492         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9493         (make_visible): Remove unnecessary cast.
9494         * tui/tui-winsource.c (tui_erase_source_content)
9495         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9496         unnecessary cast.
9497         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9498         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9499         * stabsread.c (read_type, read_array_type, read_range_type):
9500         Remove unnecessary cast.
9501         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9502         (parse_symbol, parse_type, upgrade_type, parse_external)
9503         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9504         unnecessary cast.
9505         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9506
9507 2019-06-16  Tom Tromey  <tom@tromey.com>
9508
9509         * tui/tui-data.c (tui_alloc_generic_win_info)
9510         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9511         checks.
9512
9513 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9514             Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * f-typeprint.c (f_print_type): Don't return early for not
9517         associated or not allocated types.
9518         (f_type_print_varspec_suffix): Add print_rank parameter and print
9519         ranks of array types in case they dangling.
9520         (f_type_print_base): Add print_rank parameter.
9521
9522 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * NEWS: Mention new MI commands.
9525         * break-catch-throw.c (enum exception_event_kind): Move to
9526         breakpoint.h.
9527         (print_mention_exception_catchpoint): Output text as a single
9528         message.
9529         (catch_exception_command_1): Rename to...
9530         (catch_exception_event): ...this, make non-static, update header
9531         command, and change some parameter types.
9532         (catch_catch_command): Update for changes to
9533         catch_exception_command_1.
9534         (catch_throw_command): Likewise.
9535         (catch_rethrow_command): Likewise.
9536         * breakpoint.c (enum exception_event_kind): Delete.
9537         * breakpoint.h (enum exception_event_kind): Moved here from
9538         break-catch-throw.c.
9539         (catch_exception_event): Declare.
9540         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9541         (mi_cmd_catch_throw): New function.
9542         (mi_cmd_catch_rethrow): New function.
9543         (mi_cmd_catch_catch): New function.
9544         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9545         'catch-catch' entries.
9546         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9547         (mi_cmd_catch_rethrow): Declare.
9548         (mi_cmd_catch_catch): Declare.
9549
9550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9551
9552         * annotate.c (annotate_source_line): Change return type to void,
9553         update implementation to match.
9554         * annotate.h (annotate_source_line): Change return type to void,
9555         update header comment.
9556         * stack.c (print_frame_info): Don't change what frame information
9557         is printed based on whether annotations are on or not.
9558
9559 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9560
9561         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9562         (annotate_source): Make static.
9563         (annotate_source_line): Moved from source.c and renamed from
9564         identify_source_line.  Update the return type.
9565         * annotate.h (annotate_source): Delete declaration.
9566         (annotate_source_line): Declaration moved from source.h, and
9567         renamed from identify_source_line.  Return type updated.
9568         * source.c (identify_source_line): Moved to annotate.c and renamed
9569         to annotate_source_line.
9570         (info_line_command): Remove check of annotation_level.
9571         * source.h (identify_source_line): Move declaration to annotate.h
9572         and rename to annotate_source_line.
9573         * stack.c: Add 'annotate.h' include.
9574         (print_frame_info): Remove check of annotation_level before
9575         calling annotate_source_line.
9576
9577 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9578
9579         * source-cache.c (source_cache::get_plain_source_lines): Use
9580         open_source_file_with_line_charpos instead of just
9581         open_source_file, remove call to find_source_lines.
9582         (source_cache::get_source_lines): Likewise.
9583         * source.c (find_source_lines): Make static.
9584         (get_filename_and_charpos): Renamed into...
9585         (open_source_file_with_line_charpos): ..this along with changes to
9586         return a scoped_fd, and some other minor clean ups.
9587         (identify_source_line): Use open_source_file_with_line_charpos.
9588         (search_command_helper): Use open_source_file_with_line_charpos
9589         instead of just open_source_file, remove call to
9590         find_source_lines.
9591         * source.h (open_source_file_with_line_charpos): Declare new
9592         function.
9593         (find_source_lines): Delete declaration.
9594
9595 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * source.c (get_filename_and_charpos): Remove fullname
9598         parameter.
9599         (identify_source_line): Update call to get_filename_and_charpos.
9600
9601 2019-06-14  Tom Tromey  <tromey@adacore.com>
9602
9603         PR gdb/24502:
9604         * ui-style.h (skip_ansi_escape): Update comment.
9605         * ui-file.h (class no_terminal_escape_file): New class.
9606         * ui-file.c (no_terminal_escape_file::write)
9607         (no_terminal_escape_file::puts): New methods.
9608         * cli/cli-logging.c (handle_redirections): Use
9609         no_terminal_escape_file.
9610
9611 2019-06-14  Tom Tromey  <tromey@adacore.com>
9612
9613         * NEWS: Move convenience variable news above Python news.
9614
9615 2019-06-14  Tom Tromey  <tom@tromey.com>
9616
9617         * gnulib: Move directory to top-level.
9618         * configure.ac: Don't configure gnulib.
9619         * configure: Rebuild.
9620         * common/common-defs.h: Use new path to gnulib.
9621         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9622         (GNULIB_H): Remove.
9623         (INCGNU): Look in new gnulib location.
9624         (HFILES_NO_SRCDIR): Remove gnulib files.
9625         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9626         (generated_files): Remove GNULIB_H.
9627         ($(LIBGNU), all-lib): Remove targets.
9628         (distclean): Don't mention GNULIB_BUILDDIR.
9629         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9630
9631 2019-06-14  Tom Tromey  <tromey@adacore.com>
9632
9633         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9634         Warn if symbol file does not provide any symbols.
9635
9636 2019-06-14  Tom Tromey  <tromey@adacore.com>
9637
9638         * source.c (find_and_open_source): Respect basenames_may_differ.
9639
9640 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * annotate.c (annotate_breakpoints_invalid): Make use of
9643         scoped_restore_terminal_state.
9644         (annotate_frames_invalid): Likewise.
9645
9646 2019-06-14  Tom Tromey  <tromey@adacore.com>
9647
9648         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9649         allow assignment to an internalvar.
9650
9651 2019-06-14  Tom Tromey  <tromey@adacore.com>
9652
9653         * ada-lex.l: Allow "_" in attribute names.
9654
9655 2019-06-14  Tom Tromey  <tromey@adacore.com>
9656
9657         PR gdb/24653:
9658         * regcache.c (registers_changed): Don't call alloca.
9659         * top.c (execute_command): Don't call alloca.
9660
9661 2019-06-13  Pedro Alves  <palves@redhat.com>
9662
9663         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9664         'expression'.  When parsing an expression, error out if there's
9665         junk after "unlimited".
9666         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9667         (do_set_command): Adjust calls to is_unlimited_literal.
9668
9669 2019-06-13  Pedro Alves  <palves@redhat.com>
9670
9671         * compile/compile.c (make_compile_options_def_group): Add braces
9672         around array_view initializer.
9673         * thread.c (make_thread_apply_all_options_def_group)
9674         (make_thread_apply_all_options_def_group): Likewise.
9675
9676 2019-06-13  Pedro Alves  <palves@redhat.com>
9677
9678         * NEWS (New commands): Mention "maint test-options
9679         require-delimiter", "maint test-options unknown-is-error", "maint
9680         test-options unknown-is-operand" and "maint show
9681         test-options-completion-result".
9682         (New command options, command completion): New section.
9683         (Completion improvements): New section.
9684         Mention that you can abbreviate "unlimited".
9685
9686 2019-06-13  Pedro Alves  <palves@redhat.com>
9687
9688         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9689         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9690         * unittests/cli-utils-selftests.c (test_parse_flags)
9691         (test_parse_flags_qcs): Delete.
9692         (test_cli_utils): Don't call deleted functions.
9693
9694 2019-06-13  Pedro Alves  <palves@redhat.com>
9695
9696         * thread.c: Include "cli/cli-option.h".
9697         (tp_array_compar_ascending): Global.
9698         (tp_array_compar): Delete function.
9699         (tp_array_compar_ascending, tp_array_compar_descending): New
9700         functions.
9701         (ascending_option_def, qcs_flag_option_def)
9702         (thr_qcs_flags_option_defs)
9703         (make_thread_apply_all_options_def_group)
9704         (make_thread_apply_options_def_group): New.
9705         (thread_apply_all_command): Use gdb::option::process_options.
9706         (thread_apply_command_completer)
9707         (thread_apply_all_command_completer): New.
9708         (thread_apply_command): Use gdb::option::process_options.
9709         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9710         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9711         to generate help text of "thread apply".  Adjust "taas"'s help.
9712         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9713         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9714
9715 2019-06-13  Pedro Alves  <palves@redhat.com>
9716
9717         * thread.c (thread_apply_command): Check for invalid TID with
9718         isdigit instead of !isalpha.
9719
9720 2019-06-13  Pedro Alves  <palves@redhat.com>
9721
9722         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9723         (validate_flags_qcs): New.
9724         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9725         (validate_flags_qcs): Declare.
9726         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9727         (make_frame_apply_options_def_group): New.
9728         (frame_apply_command_count): Process options with
9729         gdb::option::process_options.
9730         (frame_apply_completer): New.
9731         (frame_apply_level_completer, frame_apply_all_completer)
9732         (frame_apply_completer): New.
9733         (_initialize_stack): Update help of "frame apply", "frame apply
9734         level", "frame apply all" and "faas" to mention supported options
9735         and install command completers.
9736         * stack.h (frame_apply_all_completer): Declare.
9737         * thread.c: Include "stack.h".
9738         (tfaas_command): Add "--".
9739         (_initialize_thread): Update help "tfaas" to mention supported
9740         options and install command completer.
9741
9742 2019-06-13  Pedro Alves  <palves@redhat.com>
9743
9744         * completer.c (complete_nested_command_line): New.
9745         (gdb_completion_word_break_characters_throw): Add assertion.
9746         * completer.h (complete_nested_command_line): Declare.
9747
9748 2019-06-13  Pedro Alves  <palves@redhat.com>
9749
9750         * stack.c (parse_backtrace_qualifiers): New.
9751         (backtrace_command): Use it.
9752         (backtrace_command_completer): Complete on qualifiers.
9753
9754 2019-06-13  Pedro Alves  <palves@redhat.com>
9755
9756         * frame.c: Include "cli/cli-option.h.
9757         (user_set_backtrace_options): New.
9758         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9759         Delete.
9760         (get_prev_frame): Adjust.
9761         (boolean_option_def, uinteger_option_def)
9762         (set_backtrace_option_defs): New.
9763         (_initialize_frame): Adjust and use
9764         gdb::option::add_setshow_cmds_for_options to install "set
9765         backtrace past-main" and "set backtrace past-entry".
9766         * frame.h: Include "cli/cli-option.h".
9767         (struct frame_print_options): Forward declare.
9768         (print_frame_arguments_all, print_frame_arguments_scalars)
9769         (print_frame_arguments_none): Declare.
9770         (print_entry_values): Delete declaration.
9771         (struct frame_print_options, user_frame_print_options): New.
9772         (struct set_backtrace_options): New.
9773         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9774         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9775         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9776         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9777         (list_args_or_locals): Add frame_print_options parameter.
9778         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9779         * python/py-framefilter.c (enumerate_args): Pass down
9780         USER_FRAME_PRINT_OPTIONS.
9781         * stack.c: Include "cli/cli-option.h".
9782         (print_frame_arguments_all, print_frame_arguments_scalars)
9783         (print_frame_arguments_none): Declare.
9784         (print_raw_frame_arguments, print_entry_values): Delete.
9785         (user_frame_print_options): New.
9786         (boolean_option_def, enum_option_def, frame_print_option_defs):
9787         New.
9788         (struct backtrace_cmd_options): New.
9789         (bt_flag_option_def): New.
9790         (backtrace_command_option_defs): New.
9791         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9792         (print_frame_arg, read_frame_arg, print_frame_args)
9793         (print_frame_info, print_frame): Add frame_print_options parameter
9794         and use it.
9795         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9796         (backtrace_command_1): Add frame_print_options and
9797         backtrace_cmd_options parameters and use them.
9798         (make_backtrace_options_def_group): New.
9799         (backtrace_command): Process command options with
9800         gdb::option::process_options.
9801         (backtrace_command_completer): New.
9802         (_initialize_stack): Extend "backtrace"'s help to mention
9803         supported options.  Install completer for "backtrace".
9804         Install some settings commands with add_setshow_cmds_for_options.
9805
9806 2019-06-13  Pedro Alves  <palves@redhat.com>
9807
9808         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9809         and that "set/show print raw frame-arguments" are now deprecated.
9810
9811         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9812         command.
9813         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9814         * stack.c (_initialize_stack): Install "set/show print
9815         raw-frame-arguments", and deprecate "set/show print raw
9816         frame-arguments".
9817         * valprint.c (_initialize_valprint): Deprecate "set/show print
9818         raw".
9819
9820 2019-06-13  Pedro Alves  <palves@redhat.com>
9821
9822         * compile/compile.c (struct compile_options): New.
9823         (compile_flag_option_def, compile_command_option_defs)
9824         (make_compile_options_def_group): New.
9825         (compile_file_command): Handle options with
9826         gdb::option::process_options.
9827         (compile_file_command_completer): New function.
9828         (compile_code_command): Handle options with
9829         gdb::option::process_options.
9830         (compile_code_command_completer): New function.
9831         (_initialize_compiler): Install completers for "compile code" and
9832         "compile file".  Mention available options in "compile code" and
9833         "compile code"'s help.
9834         * completer.c (advance_to_completion_word): New, factored out from
9835         ...
9836         (advance_to_expression_complete_word_point): ... this.
9837         (advance_to_filename_complete_word_point): New.
9838         * completer.h (advance_to_filename_complete_word_point): New
9839         declaration.
9840
9841 2019-06-13  Pedro Alves  <palves@redhat.com>
9842
9843         * compile/compile.c: Include "cli/cli-option.h".
9844         (compile_print_value): Scope data pointer is now a
9845         value_print_options pointer; adjust.
9846         (compile_print_command): Process options.  Scope data pointer is
9847         now a value_print_options pointer; adjust.
9848         (_initialize_compile): Update "compile print"'s help to include
9849         supported options.  Install a completer for "compile print".
9850         * cp-valprint.c (show_vtblprint, show_objectprint)
9851         (show_static_field_print): Delete.
9852         (_initialize_cp_valprint): Don't install "set print
9853         static-members", "set print vtbl", "set print object" here.
9854         * printcmd.c: Include "cli/cli-option.h" and
9855         "common/gdb_optional.h".
9856         (print_command_parse_format): Rework to fill in a
9857         value_print_options instead of a format_data.
9858         (print_value): Change parameter type from format_data pointer to
9859         value_print_options reference.  Adjust.
9860         (print_command_1): Process options.  Adjust to pass down a
9861         value_print_options.
9862         (print_command_completer): New.
9863         (_initialize_printcmd): Install print_command_completer as
9864         handle_brkchars completer for the "print" command.  Update
9865         "print"'s help to include supported options.
9866         * valprint.c: Include "cli/cli-option.h".
9867         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9868         here from cp-valprint.c.
9869         (boolean_option_def, uinteger_option_def)
9870         (value_print_option_defs, make_value_print_options_def_group):
9871         New.  Use gdb::option::add_setshow_cmds_for_options to install
9872         "set print elements", "set print null-stop", "set print repeats",
9873         "set print pretty", "set print union", "set print array", "set
9874         print address", "set print symbol", "set print array-indexes".
9875         * valprint.h: Include <string> and "cli/cli-option.h".
9876         (make_value_print_options_def_group): Declare.
9877         (print_value): Change parameter type from format_data pointer to
9878         value_print_options reference.
9879         (print_command_completer): Declare.
9880
9881 2019-06-13  Pedro Alves  <palves@redhat.com>
9882
9883         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9884         (COMMON_SFILES): Add maint-test-settings.c.
9885         * cli/cli-decode.c (boolean_enums): New global, factored out from
9886         ...
9887         (add_setshow_boolean_cmd): ... here.
9888         * cli/cli-decode.h (boolean_enums): Declare.
9889         * cli/cli-option.c: New file.
9890         * cli/cli-option.h: New file.
9891         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9892         factored out from ...
9893         (parse_cli_boolean_value(const char *)): ... this.
9894         (is_unlimited_literal): Change parameter type to pointer to
9895         pointer.  Adjust and advance ARG pointer.
9896         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9897         (parse_cli_var_enum): New, factored out from ...
9898         (do_set_command): ... this.  Adjust.
9899         * cli/cli-setshow.h (parse_cli_boolean_value)
9900         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9901         (parse_cli_var_enum): Declare.
9902         * cli/cli-utils.c: Include "cli/cli-option.h".
9903         (get_ulongest): New.
9904         * cli/cli-utils.h (get_ulongest): Declare.
9905         (check_for_argument): New overloads.
9906         * maint-test-options.c: New file.
9907
9908 2019-06-13  Pedro Alves  <palves@redhat.com>
9909
9910         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9911         parse a range if "-" is at the end of the string.
9912
9913 2019-06-13  Pedro Alves  <palves@redhat.com>
9914
9915         * cli/cli-setshow.c (parse_auto_binary_operation)
9916         (parse_cli_boolean_value): Don't allow "o".
9917
9918 2019-06-13  Pedro Alves  <palves@redhat.com>
9919
9920         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9921         * NEWS: Mention maint test-settings KIND.
9922         * maint-test-settings.c: New file.
9923
9924 2019-06-13  Pedro Alves  <palves@redhat.com>
9925
9926         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9927         completer.
9928         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9929         "set" completers.
9930
9931 2019-06-13  Pedro Alves  <palves@redhat.com>
9932
9933         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9934         after item.
9935
9936 2019-06-13  Pedro Alves  <palves@redhat.com>
9937
9938         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9939
9940 2019-06-13  Pedro Alves <palves@redhat.com>
9941
9942         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9943         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9944         call.
9945         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9946         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9947         calls.
9948         (check_for_argument): Skip spaces after argument.
9949
9950 2019-06-13  Pedro Alves  <palves@redhat.com>
9951
9952         * thread.c (thread_apply_command): Adjust TID parsing.
9953         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9954         detected before end of string.
9955         (tid_is_in_list): Error out if LIST is invalid.
9956
9957 2019-06-13  Pedro Alves  <palves@redhat.com>
9958
9959         * completer.c (complete_line_internal_1): Rewind completion word
9960         point.
9961         (completion_tracker::advance_custom_word_point_by): Change
9962         parameter type to int.
9963         * completer.h (completion_tracker::advance_custom_word_point_by):
9964         Likewise.
9965
9966 2019-06-13  Pedro Alves  <palves@redhat.com>
9967
9968         * completer.c (advance_to_completion_word): Handle delimiters.
9969
9970 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9971
9972         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9973
9974 2019-06-11  Tom Tromey  <tom@tromey.com>
9975
9976         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9977         (xmalloc_failed): Move to alloc.c.
9978         * alloc.c: New file.
9979         * Makefile.in (COMMON_SFILES): Add alloc.c.
9980
9981 2019-06-11  Tom Tromey  <tom@tromey.com>
9982
9983         * nat/linux-waitpid.c: Don't include server.h.
9984         (linux_debug): Remove.
9985         (my_waitpid): Update.
9986
9987 2019-06-11  Tom Tromey  <tromey@adacore.com>
9988
9989         * infcall.c (_initialize_infcall): Remove trailing newline from
9990         help.
9991         * user-regs.c (_initialize_user_regs): Remove trailing newline
9992         from help.
9993         * typeprint.c (_initialize_typeprint): Remove trailing newline
9994         from help.
9995         * reverse.c (_initialize_reverse): Remove trailing newlines from
9996         help.
9997         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9998         from help.
9999         * language.c (add_set_language_command): Remove trailing newline
10000         from help.
10001         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
10002         help.
10003         * disasm.c (_initialize_disasm): Remove trailing newline from
10004         help.
10005         * top.c (init_main): Remove trailing newline from help.
10006         * interps.c (_initialize_interpreter): Remove trailing newline
10007         from help.
10008         * btrace.c (_initialize_btrace): Remove trailing newlines from
10009         help.
10010         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
10011         from help.
10012         * python/python.c (_initialize_python): Remove trailing newline
10013         from help.
10014         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10015         help.
10016         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10017         from help.  Reformat some text.
10018         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10019         from help.
10020         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10021         newline from help.
10022
10023 2019-06-11  Tom Tromey  <tromey@adacore.com>
10024
10025         * darwin-nat.c (darwin_decode_exception_message)
10026         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10027
10028 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10029
10030         * valops.c (value_slice): Check for not allocated or not
10031         associated values.
10032
10033 2019-06-10  Tom de Vries  <tdevries@suse.de>
10034
10035         PR gdb/24618
10036         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10037         sure an empty slot (defined by a 32-bit zero pair) is recognized as
10038         invalid.
10039
10040 2019-06-10  Tom de Vries  <tdevries@suse.de>
10041
10042         PR gdb/24611
10043         * linespec.c (linespec_lexer_lex_string): Remove incorrect
10044         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
10045
10046 2019-06-10  Tom de Vries  <tdevries@suse.de>
10047
10048         PR symtab/24545
10049         * symtab.c (struct demangled_name_entry): Add language field.
10050         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
10051         static minimal symbol".  Set and use language field.
10052
10053 2019-06-10  Tom Tromey  <tromey@adacore.com>
10054
10055         * ada-lang.c (_initialize_ada_language): Update help text.
10056
10057 2019-06-10  Tom Tromey  <tromey@adacore.com>
10058
10059         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10060         with a newline.
10061         * guile/guile.c (handle_boot_error): Don't end warning with a
10062         newline.
10063         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10064         warning with a newline.
10065         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10066         newline.
10067         (s12z_frame_cache): Likewise.
10068         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10069         a newline.
10070         * solib-svr4.c (disable_probes_interface): Don't end warning with
10071         a newline.
10072         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10073         newline.
10074         * python/python.c (do_finish_initialization): Don't end warning
10075         with a newline.
10076
10077 2019-06-10  Tom Tromey  <tom@tromey.com>
10078
10079         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10080         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10081         gdbpy_enter.
10082
10083 2019-06-10  Tom Tromey  <tromey@adacore.com>
10084
10085         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10086         data.
10087         (elf_new_init): Don't call stabsread_new_init.
10088         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10089         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10090         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10091
10092 2019-06-10  Tom de Vries  <tdevries@suse.de>
10093
10094         PR symtab/16264
10095         PR symtab/24517
10096         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10097
10098 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10099
10100         * source.c (find_and_open_source): Also rewrite relative file
10101         names.
10102
10103 2019-04-26  Amos Bird  <amosbird@gmail.com>
10104
10105         * annotate.c (annotate_thread_exited): Add "thread-exited"
10106         annotation.
10107
10108 2019-06-06  Tom Tromey  <tromey@adacore.com>
10109
10110         * maint.h (class scoped_command_stats): Use
10111         DISABLE_COPY_AND_ASSIGN.
10112         <print_time>: New method.
10113         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10114         print_time.
10115         (scoped_command_stats::print_time): New method.
10116
10117 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10118
10119         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10120         instructions of lengths 6 or 8 bytes.
10121
10122 2019-06-04  Pedro Alves  <palves@redhat.com>
10123
10124         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10125
10126         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10127         * breakpoint.c (condition_completer): Likewise.
10128         * cli/cli-dump.c (scan_expression): Likewise.
10129         * common/filestuff.c (mkdir_recursive): Likewise.
10130         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10131         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10132         (gdb_abspath): Likewise.
10133         * compile/compile-cplus-types.c
10134         (compile_cplus_instance::decl_name): Likewise.
10135         * completer.c (complete_explicit_location):
10136         (signal_completer, reg_or_group_completer_1): Likewise.
10137         * cp-support.c (cp_remove_params_if_any): Likewise.
10138         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10139         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10140         * infcmd.c (strip_bg_char): Likewise.
10141         * linespec.c (copy_token_string): Likewise.
10142         * mi/mi-main.c (output_cores): Likewise.
10143         * psymtab.c (psymtab_search_name):
10144         * symfile.c (test_set_ext_lang_command): Likewise.
10145         * target.c (target_fileio_read_stralloc): Likewise.
10146         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10147         * value.c (complete_internalvar): Likewise.
10148
10149 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10150
10151         Add objfile property to gdb.Type.
10152         * NEWS: Mention Python API addition.
10153         * python/py-type.c (typy_get_objfile): New method.
10154
10155 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10156
10157         * NEWS: Mention the new set|show style [title|highlight].
10158         Mention changes to "show style", "help" and "apropos".
10159
10160 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10161
10162         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10163         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10164         instead of print_help_for_command.
10165         (print_doc_of_command): New function.
10166         (help_list): Add 'apropos -v word' suggestion.
10167         (print_help_for_command): Style the command name using title style.
10168         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10169         (_initialize_cli_cmds): Describe -v in apropos_command help.
10170
10171 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10172
10173         * cli/cli-style.h (cli_style_option): Add name in constructor,
10174         add m_name class member, add constructor with intensity,
10175         add name class function.
10176         (cli_style_option::add_setshow_commands): Remove name argument.
10177         (highlight_style, title_style): New styles.
10178         * cli/cli-style.c (do_show): New function that shows a style
10179         characteristic styling the style name with itself.
10180         (set_style_name): New function.
10181         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10182         Update all callers according to the changes in cli/cli-style.h.
10183         * utils.h (fputs_highlighted): New function.
10184         * utils.c (fputs_highlighted): Likewise.
10185
10186 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10187
10188         * NEWS: Mention new pipe command and new convenience variables.
10189
10190 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10191
10192         * cli/cli-cmds.c (pipe_command): New function.
10193         (_initialize_cli_cmds): Call add_com for pipe_command.
10194         Define | as an alias for pipe.
10195         (exit_status_set_internal_vars): New function.
10196         (shell_escape): Call exit_status_set_internal_vars.
10197         cli/cli-decode.c (find_command_name_length): Recognize | as
10198         a single character command.
10199
10200 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10201
10202         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10203         top.c (execute_command_to_ui_file): New function, mostly a copy
10204         of execute_command_to_string.
10205         (execute_command_to_string): Implement by calling
10206         execute_command_to_ui_file.
10207
10208 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10209
10210         * top.h (saved_command_line): Remove declaration.
10211         * top.c (previous_saved_command_line, previous_repeat_arguments):
10212         New variables.
10213         (saved_command_line): Make static, define together with other
10214         'repeat variables'.
10215         (dont_repeat): Clear repeat_arguments.
10216         (repeat_previous, get_saved_command_line, save_command_line):
10217         New functions.
10218         (gdb_init): Initialize saved_command_line
10219         and previous_saved_command_line.
10220         * main.c (captured_main_1): Remove saved_command_line initialization.
10221         * event-top.c (handle_line_of_input): Update to use
10222         the new 'repeat' related functions instead of direct access to
10223         saved_command_line.
10224         * command.h (repeat_previous, get_saved_command_line,
10225         save_command_line): New declarations.
10226         (dont_repeat): Add comment.
10227
10228 2019-05-30  Tom Tromey  <tromey@adacore.com>
10229
10230         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10231         Fix comment.
10232         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10233
10234 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10235
10236         PR cli/24587
10237         * completer.c (complete): Initialize variable word.
10238
10239 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10240
10241         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10242         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10243         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10244         'body' is NULL to the outter 'if', protecting the '!is_define'
10245         situation as well.
10246
10247 2019-05-29  Tom Tromey  <tromey@adacore.com>
10248
10249         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10250         (dwarf_unknown): New function.
10251         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10252         (dwarf_type_encoding_name): Use dwarf_unknown.
10253
10254 2019-05-29  Tom Tromey  <tromey@adacore.com>
10255
10256         PR c++/20020:
10257         * cp-valprint.c (cp_print_value_fields): Call
10258         cp_print_static_field inside "try".
10259
10260 2019-05-29  Tom Tromey  <tromey@adacore.com>
10261
10262         * inflow.c (struct terminal_info): Add default operator=.
10263         * configure: Rebuild.
10264         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10265         -Wdeprecated-copy-dtor, -Wredundant-move.
10266
10267 2019-05-29  Tom Tromey  <tromey@adacore.com>
10268
10269         * NEWS: Add entry.
10270         * infcmd.c (print_return_value_1): Handle finish_print
10271         option.
10272         (show_print_finish): New function.
10273         (_initialize_infcmd): Add "set/show print finish" commands.
10274         * valprint.c (user_print_options): Initialize new member.
10275         * valprint.h (struct value_print_options) <finish_print>: New
10276         member.
10277
10278 2019-05-28  Tom Tromey  <tromey@adacore.com>
10279
10280         * ada-lang.c (ada_remove_Xbn_suffix)
10281         (find_old_style_renaming_symbol)
10282         (parse_old_style_renaming): Remove.
10283         (ada_find_renaming_symbol): Don't call
10284         find_old_style_renaming_symbol.
10285         (ada_is_renaming_symbol): Rename from
10286         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10287         bool.  Now static.
10288         (ada_read_var_value): Update and simplify.
10289         * ada-exp.y (write_var_or_type): Remove old code.
10290
10291 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10292
10293         PR gdb/25010
10294         * event-top.c: Remove include comment.
10295         * inflow.c (class scoped_ignore_sigttou): Move from here...
10296         * inflow.h (class scoped_ignore_sigttou): ...to here.
10297         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10298         * top.c:  Remove include comment.
10299
10300 2019-05-27  Tom Tromey  <tom@tromey.com>
10301
10302         * NEWS: Fix typo.
10303
10304 2019-05-22  Tom Tromey  <tromey@adacore.com>
10305
10306         * target.c (target_follow_exec): Constify parameter.
10307         * target-delegates.c: Rebuild.
10308         * remote.c (remote_target::follow_exec): Constify parameter.
10309         * infrun.c (follow_exec): Constify parameter.
10310         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10311         (target_follow_exec): Likewise.
10312
10313 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10314
10315         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10316         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10317
10318 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10319
10320         * NEWS: Add debugredirect and testsuite sections.
10321
10322 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10323
10324         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10325         target descriptions using exclusively floating point register name
10326         aliases.
10327
10328 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         PR gdb/18644:
10331         * f-lang.c (build_fortran_types): Handle the case where
10332         gdbarch_floatformat_for_type returns a nullptr.
10333
10334 2019-05-21  Tom de Vries  <tdevries@suse.de>
10335
10336         PR cli/24587
10337         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10338
10339 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         PR gdb/18644:
10342         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10343         16-byte floats.
10344         * i386-tdep.c (i386_floatformat_for_type): Use
10345         floatformats_ia64_quad for the 16-byte floating point component
10346         within a fortran 32-byte complex number.
10347
10348 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10349
10350         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10351         delete default constructor.
10352         (find_partial_die): Update to return const struct.
10353         (partial_die_parent_scope): Move variable declaration into scope
10354         of its use and change its type to auto.
10355         (guess_partial_die_structure_name): Likewise.
10356         (partial_die_info::fixup): Likewise.
10357
10358 2019-05-17  Tom Tromey  <tromey@adacore.com>
10359
10360         * source.c (find_and_open_source): Remove cast.
10361
10362 2019-05-17  Tom Tromey  <tromey@adacore.com>
10363
10364         * annotate.c (annotate_source): Make "filename" const.
10365         * annotate.h (annotate_source): Use const.
10366
10367 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10368
10369         * disasm.c (set_disassembler_options): Send errors to stderr.
10370
10371 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10372
10373         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10374         (cli_interp_base::set_logging): Check debug_redirect.
10375         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10376         * cli/cli-logging.c (debug_redirect): Add static variable.
10377         (pop_output_files): Add default param.
10378         (handle_redirections): Print debug setting.
10379         (show_logging_command): Likewise.
10380         (_initialize_cli_logging): Add debugredirect command.
10381         * interps.c (current_interp_set_logging): Add debug_redirect
10382         parameter.
10383         * interps.h (set_logging): Add debug_redirect parameter.
10384         (current_interp_set_logging): Likewise.
10385         * mi/mi-common.h: Likewise.
10386         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10387
10388 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10389             Tom Tromey  <tromey@adacore.com>
10390
10391         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10392         directly.
10393         * cli/cli-interp.h (make_logging_output): Remove declaration.
10394         * cli/cli-logging.c (make_logging_output): Remove function.
10395         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10396         directly.
10397         * ui-file.c (tee_file::tee_file): Remove bools.
10398         (tee_file::~tee_file): Remove deletes.
10399         * ui-file.h (tee_file): Remove bools.
10400
10401 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10402
10403         * mi/mi-cmds.h (mi_cmd_complete): New function.
10404         * mi/mi-main.c (mi_cmd_complete): Likewise.
10405         * mi/mi-cmds.c: Define new MI command -complete.
10406         * NEWS: Mention new -complete command.
10407
10408 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10409
10410         * completer.h (complete): New function.
10411         * completer.c (complete): Likewise.
10412         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10413         function defined in completer.h.
10414
10415 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10416
10417         * MAINTAINERS (Write After Approval): Add myself.
10418
10419 2019-05-17  Tom de Vries  <tdevries@suse.de>
10420
10421         PR gdb/24094
10422         * dwarf2read.c (struct cu_partial_die_info): New struct.
10423         (find_partial_die): Return cu_partial_die_info.
10424         (partial_die_parent_scope, guess_partial_die_structure_name)
10425         (partial_die_info::fixup): Handle new return type of find_partial_die.
10426
10427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10428
10429         PR breakpoints/24541
10430         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10431         "std::string", simplifying the algorithm.
10432
10433 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10434
10435         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10436         (stap_static_probe_ops::get_probes): Likewise.
10437
10438 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10439
10440         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10441         '-')" and "else if".
10442         (stap_parse_single_operand): Join checks for
10443         "gdbarch_stap_parse_special_token_p" and
10444         "gdbarch_stap_parse_special_token" in the same "if" statement.
10445         Invert check when verifying for operation on register
10446         displacement.
10447
10448 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10449
10450         * stap-probe.c (stap_get_opcode): Update comment.
10451         (stap_get_expected_argument_type): Likewise.
10452         (handle_stap_probe): Likewise.
10453
10454 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10455
10456         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10457         return type to 'bool'.  Adjust comment.  Use 'bool' when
10458         appropriate.
10459         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10460         * stap-probe.c (stap_parse_argument_1): Likewise.
10461         (stap_is_operator): Likewise.
10462         (stap_is_generic_prefix): Likewise.
10463         (stap_is_register_prefix): Likewise.
10464         (stap_is_register_indirection_prefix): Likewise.
10465         (stap_is_integer_prefix): Likewise.
10466         (stap_generic_check_suffix): Likewise.
10467         (stap_check_integer_suffix): Likewise.
10468         (stap_check_register_suffix): Likewise.
10469         (stap_check_register_indirection_suffix): Likewise.
10470         (stap_parse_register_operand): Likewise.
10471         (stap_parse_single_operand): Likewise.
10472         (stap_parse_argument_1): Likewise.
10473         (stap_probe::get_argument_count): Likewise.
10474         (stap_is_operator): Likewise.
10475
10476 2019-05-16  Tom Tromey  <tromey@adacore.com>
10477
10478         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10479         keyword to foreach.
10480
10481 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10482
10483         * linux-thread-db.c (try_thread_db_load_1): Change return type
10484         to bool.
10485         (try_thread_db_load): Likewise.
10486         (try_thread_db_load_from_pdir_1): Likewise.
10487         (try_thread_db_load_from_pdir): Likewise.
10488         (try_thread_db_load_from_sdir): Likewise.
10489         (try_thread_db_load_from_dir): Likewise.
10490         (thread_db_load_search): Likewise.
10491         (has_libpthread): Likewise.
10492         (thread_db_load): Likewise.
10493
10494 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10495
10496         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10497         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10498         NULL, and complain/return if that's the case.
10499
10500 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10501
10502         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10503         (advance, posn, abstract_read_memory): New functions.
10504         [struct mem_read_abstraction]: New struct.
10505         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10506
10507 2019-05-14  Tom Tromey  <tromey@adacore.com>
10508
10509         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10510         value is not lval_memory.
10511
10512 2019-05-14  Tom Tromey  <tromey@adacore.com>
10513
10514         * solib.c (info_sharedlibrary_command): Style the file name.
10515
10516 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10517
10518         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10519         (aarch64_vnv_type): Likewise.
10520         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10521         * common/tdesc.c: Likewise.
10522         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10523         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10524         * features/aarch64-fpu.xml: Add ieee half view.
10525         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10526         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10527         * gdbtypes.h (struct builtin_type): Likewise.
10528         (struct objfile_type): Likewise.
10529
10530 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10531
10532         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10533         typo.
10534         * location.h (string_to_event_location): Likewise.
10535
10536 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10537
10538         GDB 8.3 released.
10539
10540 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10541
10542         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10543         New variable declaration.
10544         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10545         New variable.
10546         (print_one_breakpoint): Use ui_out::test_flags and new global
10547         variable to compute use_fixed_output.
10548         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10549         Remove.
10550         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10551         (mi_multi_location_breakpoint_output_fixed): Remove.
10552         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10553         new variable.
10554         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10555         fix_multi_location_breakpoint_output flag if version >= 3.
10556         * ui-out.h (enum ui_out_flag)
10557         <fix_multi_location_breakpoint_output>: New enumerator.
10558
10559 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10560
10561         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10562
10563 2019-05-10  Tom Tromey  <tromey@adacore.com>
10564
10565         * ada-lang.c (catch_ada_completer): New function.
10566         (_initialize_ada_language): Use it.
10567
10568 2019-05-10  Tom Tromey  <tromey@adacore.com>
10569
10570         * thread.c (print_thread_info): Make "requested_threads" const.
10571         * gdbthread.h (print_thread_info): Make "requested_threads"
10572         const.
10573         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10574         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10575
10576 2019-05-08  Tom Tromey  <tom@tromey.com>
10577
10578         * gdbtypes.c (objfile_type_data): Change type.
10579         (objfile_type, _initialize_gdbtypes): Update.
10580
10581 2019-05-08  Tom Tromey  <tom@tromey.com>
10582
10583         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10584         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10585         (_initialize_dwarf2_frame): Update.
10586
10587 2019-05-08  Tom Tromey  <tom@tromey.com>
10588
10589         * objc-lang.c (objc_objfile_data): Change type.
10590         (find_methods): Update.
10591         (_initialize_objc_lang): Remove.
10592
10593 2019-05-08  Tom Tromey  <tom@tromey.com>
10594
10595         * stabsread.c (rs6000_builtin_type_data): Change type.
10596         (rs6000_builtin_type, _initialize_stabsread): Update.
10597
10598 2019-05-08  Tom Tromey  <tom@tromey.com>
10599
10600         * mips-tdep.c (mips_pdr_data): Remove.
10601         (_initialize_mips_tdep): Update.
10602
10603 2019-05-08  Tom Tromey  <tom@tromey.com>
10604
10605         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10606         (hppa_init_objfile_priv_data, read_unwind_info)
10607         (find_unwind_entry, _initialize_hppa_tdep): Update.
10608
10609 2019-05-08  Tom Tromey  <tom@tromey.com>
10610
10611         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10612         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10613         on obstack.
10614         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10615
10616 2019-05-08  Tom Tromey  <tom@tromey.com>
10617
10618         * mdebugread.c (basic_type_data): Change type.
10619         (basic_type, _initialize_mdebugread): Update.
10620
10621 2019-05-08  Tom Tromey  <tom@tromey.com>
10622
10623         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10624
10625 2019-05-08  Tom Tromey  <tom@tromey.com>
10626
10627         * nto-tdep.c (nto_inferior_data_reg): Change type.
10628         (nto_inferior_data): Update.
10629         (nto_inferior_data_cleanup, nto_new_inferior_data)
10630         (_initialize_nto_tdep): Remove.
10631         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10632
10633 2019-05-08  Tom Tromey  <tom@tromey.com>
10634
10635         * ada-lang.c (struct ada_inferior_data): Add initializers.
10636         (ada_inferior_data): Change type.
10637         (ada_inferior_data_cleanup): Remove.
10638         (get_ada_inferior_data, ada_inferior_exit)
10639         (struct ada_pspace_data): Add initializers, destructor.
10640         (ada_pspace_data_handle): Change type.
10641         (get_ada_pspace_data): Update.
10642         (ada_pspace_data_cleanup): Remove.
10643
10644 2019-05-08  Tom Tromey  <tom@tromey.com>
10645
10646         * coffread.c (struct coff_symfile_info): Add initializers.
10647         (coff_objfile_data_key): Move lower.  Change type.
10648         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10649         Update.
10650         (coff_free_info): Remove.
10651
10652 2019-05-08  Tom Tromey  <tom@tromey.com>
10653
10654         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10655         (fbsd_pspace_data_handle): Move lower.  Change type.
10656         (get_fbsd_pspace_data): Update.
10657         (fbsd_pspace_data_cleanup): Remove.
10658         (_initialize_fbsd_tdep): Update.
10659
10660 2019-05-08  Tom Tromey  <tom@tromey.com>
10661
10662         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10663         (get_ada_tasks_pspace_data): Update.
10664         (ada_tasks_pspace_data_cleanup): Remove.
10665         (_initialize_tasks): Update.
10666         (ada_tasks_inferior_data_handle): Change type.
10667         (get_ada_tasks_inferior_data): Update.
10668         (ada_tasks_inferior_data_cleanup): Remove.
10669         (struct ada_tasks_pspace_data): Add initializers.
10670
10671 2019-05-08  Tom Tromey  <tom@tromey.com>
10672
10673         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10674         * symfile-debug.c (debug_sym_get_probes): Change type.
10675         * stap-probe.c (handle_stap_probe):
10676         (stap_static_probe_ops::get_probes): Change type.
10677         * probe.h (class static_probe_ops) <get_probes>: Change type.
10678         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10679         (parse_probes_in_pspace): Update.
10680         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10681         Update.
10682         (any_static_probe_ops::get_probes): Change type.
10683         * elfread.c (elfread_data): New typedef.
10684         (probe_key): Change type.
10685         (elf_get_probes): Likewise.  Update.
10686         (probe_key_free): Remove.
10687         (_initialize_elfread): Update.
10688         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10689         Change type.
10690         (dtrace_process_dof_probe, dtrace_process_dof)
10691         (dtrace_static_probe_ops::get_probe): Change type.
10692
10693 2019-05-08  Tom Tromey  <tom@tromey.com>
10694
10695         * xcoffread.c (struct xcoff_symfile_info): Rename from
10696         coff_symfile_info.  Add initializers.
10697         (xcoff_objfile_data_key): Move lower.  Change type.
10698         (XCOFF_DATA): Rewrite.
10699         (xcoff_free_info): Remove.
10700         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10701         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10702         (xcoff_initial_scan): Update.
10703
10704 2019-05-08  Tom Tromey  <tom@tromey.com>
10705
10706         * solib-svr4.c (struct svr4_info): Add initializers and
10707         destructor.
10708         <probes_table>: Now an htab_up.
10709         (solib_svr4_pspace_data): Change type.
10710         (free_probes_table): Simplify.
10711         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10712         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10713         (probes_table_remove_objfile_probes, register_solib_event_probe)
10714         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10715         (_initialize_svr4_solib): Update.
10716
10717 2019-05-08  Tom Tromey  <tom@tromey.com>
10718
10719         * remote.c (remote_pspace_data): Change type.
10720         (remote_pspace_data_cleanup): Remove.
10721         (get_remote_exec_file, set_pspace_remote_exec_file)
10722         (_initialize_remote): Update.
10723
10724 2019-05-08  Tom Tromey  <tom@tromey.com>
10725
10726         * breakpoint.c (breakpoint_objfile_key): Change type.
10727         (get_breakpoint_objfile_data): Update.
10728         (free_breakpoint_objfile_data): Remove.
10729         (_initialize_breakpoint): Update.
10730
10731 2019-05-08  Tom Tromey  <tom@tromey.com>
10732
10733         * linux-tdep.c (struct linux_info): Add initializers.
10734         (linux_inferior_data): Move.  Change type.
10735         (invalidate_linux_cache_inf): Update.
10736         (linux_inferior_data_cleanup): Remove.
10737         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10738
10739 2019-05-08  Tom Tromey  <tom@tromey.com>
10740
10741         * auxv.c (auxv_inferior_data): Move.  Change type.
10742         (auxv_inferior_data_cleanup): Remove.
10743         (invalidate_auxv_cache_inf): Rewrite.
10744         (get_auxv_inferior_data, _initialize_auxv): Update.
10745
10746 2019-05-08  Tom Tromey  <tom@tromey.com>
10747
10748         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10749         (symfile_debug_objfile_data_key): Change type.
10750         (symfile_debug_installed, debug_qf_has_symbols)
10751         (debug_qf_find_last_source_symtab)
10752         (debug_qf_forget_cached_source_info)
10753         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10754         (debug_qf_print_stats, debug_qf_dump)
10755         (debug_qf_expand_symtabs_for_function)
10756         (debug_qf_expand_all_symtabs)
10757         (debug_qf_expand_symtabs_with_fullname)
10758         (debug_qf_map_matching_symbols)
10759         (debug_qf_expand_symtabs_matching)
10760         (debug_qf_find_pc_sect_compunit_symtab)
10761         (debug_qf_map_symbol_filenames)
10762         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10763         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10764         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10765         (debug_sym_read_linetable, debug_sym_relocate): Update.
10766         (symfile_debug_free_objfile): Remove.
10767         (install_symfile_debug_logging, _initialize_symfile_debug):
10768         Update.
10769
10770 2019-05-08  Tom Tromey  <tom@tromey.com>
10771
10772         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10773         allocate_on_obstack.
10774         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10775         (get_dwarf2_per_objfile): Update.
10776         (set_dwarf2_per_objfile): Remove.
10777         (dwarf2_has_info, dwarf2_get_section_info): Update.
10778         (dwarf2_free_objfile): Remove.
10779         (_initialize_dwarf2_read): Update.
10780
10781 2019-05-08  Tom Tromey  <tom@tromey.com>
10782
10783         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10784         initializers.
10785         <unsupported_script_warning_printed,
10786         script_not_found_warning_printed>: Now bool.
10787         (auto_load_pspace_data): Change type.
10788         (~auto_load_pspace_info): Rename from
10789         auto_load_pspace_data_cleanup.
10790         (get_auto_load_pspace_data, init_loaded_scripts_info)
10791         (clear_section_scripts, maybe_print_unsupported_script_warning)
10792         (maybe_print_script_not_found_warning, _initialize_auto_load):
10793         Update.
10794
10795 2019-05-08  Tom Tromey  <tom@tromey.com>
10796
10797         * objfiles.c (objfile_pspace_info): Add destructor and
10798         initializers.
10799         (objfiles_pspace_data): Change type.
10800         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10801         (get_objfile_pspace_data): Update.
10802         (objfiles_bfd_data): Change type.
10803         (get_objfile_bfd_data): Update.
10804         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10805
10806 2019-05-08  Tom Tromey  <tom@tromey.com>
10807
10808         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10809         Change type.
10810         (get_catch_syscall_inferior_data): Update.
10811         (catch_syscall_inferior_data_cleanup): Remove.
10812         (_initialize_break_catch_syscall): Update.
10813
10814 2019-05-08  Tom Tromey  <tom@tromey.com>
10815
10816         * inflow.c (struct terminal_info): Add destructor and
10817         initializers.
10818         (inflow_inferior_data): Change type.
10819         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10820         (get_inflow_inferior_data, inflow_inferior_exit)
10821         (swap_terminal_info, _initialize_inflow): Update.
10822
10823 2019-05-08  Tom Tromey  <tom@tromey.com>
10824
10825         * target-dcache.c (target_dcache_cleanup): Remove.
10826         (target_dcache_aspace_key): Change type.
10827         (target_dcache_init_p, target_dcache_invalidate)
10828         (target_dcache_get, target_dcache_get_or_init)
10829         (_initialize_target_dcache): Update.
10830         * dcache.h (struct dcache_deleter): New.
10831
10832 2019-05-08  Tom Tromey  <tom@tromey.com>
10833
10834         * symtab.c (struct symbol_cache): Add destructor and
10835         initializers.
10836         (symbol_cache_key): Move.  Change type.
10837         (make_symbol_cache, free_symbol_cache): Remove.
10838         (get_symbol_cache): Update.
10839         (symbol_cache_cleanup): Remove.
10840         (ALL_PSPACES, symbol_cache_flush)
10841         (maintenance_print_symbol_cache)
10842         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10843         Update.
10844
10845 2019-05-08  Tom Tromey  <tom@tromey.com>
10846
10847         * symtab.c (struct main_info): Add destructor and initializers.
10848         (main_progspace_key): Move.  Change type.
10849         (get_main_info): Update.
10850         (main_info_cleanup): Remove.
10851         (_initialize_symtab): Update.
10852
10853 2019-05-08  Tom Tromey  <tom@tromey.com>
10854
10855         * registry.h (DECLARE_REGISTRY): Define the _key class.
10856
10857 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10858
10859         * NEWS: Merge two 'New commands' sections.
10860
10861 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10862
10863         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10864         parameter and use Ada language definition instead.
10865         (ada_val_print_ptr): Remove unused language parameter.
10866         (ada_val_print_num): Remove language parameter and use Ada language
10867         definition instead.
10868         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10869         parameter.
10870         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10871         parameter and use Ada language definition instead.
10872         (ada_val_print_1): Update all ada_val_print_xxx calls.
10873         Remove language parameter.
10874         (ada_val_print): Update ada_val_print_1 call.
10875
10876 2019-05-08  Tom Tromey  <tromey@adacore.com>
10877
10878         * remote.c (remote_hw_watchpoint_limit)
10879         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10880         Now static.
10881
10882 2019-05-08  Tom Tromey  <tromey@adacore.com>
10883
10884         * maint.c (_initialize_maint_cmds): Move initialization code to
10885         remote.c.
10886         (watchdog, show_watchdog): Move to remote.c.
10887         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10888         "watchdog" static.
10889         (_initialize_remote): Move initialization code from maint.c.
10890         * defs.h (watchdog): Don't declare.
10891
10892 2019-05-08  Tom Tromey  <tromey@adacore.com>
10893
10894         * tui/tui-interp.c: Include main.h.
10895         * interps.c: Include main.h.
10896         * main.h (interpreter_p): Declare.
10897         * defs.h (interpreter_p): Don't declare.
10898
10899 2019-05-08  Tom Tromey  <tromey@adacore.com>
10900
10901         * dwarf2loc.c: Include dwarf2read.h.
10902         * defs.h (read_unsigned_leb128): Don't declare.
10903         * dwarf2read.h (read_unsigned_leb128): Declare.
10904
10905 2019-05-08  Tom Tromey  <tromey@adacore.com>
10906
10907         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10908         method.
10909
10910 2019-05-08  Tom Tromey  <tromey@adacore.com>
10911
10912         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10913         when no wrap column is set.
10914
10915 2019-05-08  Tom Tromey  <tromey@adacore.com>
10916
10917         * c-lang.c (c_get_string): Handle non-C-style arrays.
10918
10919 2019-05-08  Tom Tromey  <tromey@adacore.com>
10920
10921         * typeprint.c (print_offset_data::update): Print the bit offset,
10922         not the number of bits remaining.
10923
10924 2019-05-08  Tom Tromey  <tromey@adacore.com>
10925
10926         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10927         padding at end of comment.
10928
10929 2019-05-08  Tom Tromey  <tromey@adacore.com>
10930
10931         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10932         Compare main types.
10933
10934 2019-05-06  Tom Tromey  <tom@tromey.com>
10935
10936         * common/scoped_mmap.c: Include common-defs.h.
10937         * common/scoped_mmap.h: Don't include config.h.
10938
10939 2019-05-04  Tom Tromey  <tom@tromey.com>
10940
10941         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10942         (struct aarch64_call_info): Add initializers.
10943         <si>: Now a std::vector.
10944         (pass_on_stack, aarch64_push_dummy_call): Update.
10945
10946 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10947             Tom Tromey  <tom@tromey.com>
10948
10949         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10950         (ppc_threads): Now a std::vector.  Now static.
10951         (hwdebug_find_thread_points_by_tid)
10952         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10953         Update.
10954
10955 2019-05-04  Tom Tromey  <tom@tromey.com>
10956
10957         * arc-tdep.c (arc_tdesc_init): Return bool.
10958
10959 2019-05-04  Tom Tromey  <tom@tromey.com>
10960
10961         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10962         Use gdb_assert_not_reached.
10963
10964 2019-05-04  Tom Tromey  <tom@tromey.com>
10965
10966         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10967         "false".
10968
10969 2019-05-04  Tom Tromey  <tom@tromey.com>
10970
10971         * arc-tdep.c (arc_tdesc_init): Use bool.
10972
10973 2019-05-04  Tom Tromey  <tom@tromey.com>
10974
10975         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10976
10977 2019-05-04  Tom Tromey  <tom@tromey.com>
10978
10979         * cli/cli-cmds.c (valid_command_p): Return bool.
10980
10981 2019-05-04  Tom Tromey  <tom@tromey.com>
10982
10983         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10984         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10985
10986 2019-05-04  Raul Tambre  <raul@tambre.ee>
10987
10988         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10989         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10990         operator for comparison.
10991
10992 2019-05-04  Tom Tromey  <tom@tromey.com>
10993
10994         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10995         (lookup_partial_symbol, print_partial_symbols)
10996         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10997         (psymbol_compare): Update.
10998         (add_psymbol_to_bcache): Clear the entire psymbol.
10999         (maintenance_check_psymtabs): Update.
11000         * psympriv.h (struct partial_symbol): Don't derive from
11001         general_symbol_info.
11002         <obj_section, unrelocated_address, address,
11003         set_unrelocated_address>: Update.
11004         <ginfo>: New member.
11005         * dwarf-index-write.c (write_psymbols, debug_names::insert)
11006         (debug_names::write_psymbols): Update.
11007
11008 2019-05-04  Tom de Vries  <tdevries@suse.de>
11009
11010         * contrib/cc-with-tweaks.sh: Support -n arg.
11011
11012 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11013
11014         * corelow.c (core_target::detach): Ensure frame cache and
11015         register caches are cleared.
11016         inferior.c (exit_inferior_1): Likewise.
11017
11018 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
11019             Tom Tromey  <tom@tromey.com>
11020
11021         * dictionary.c (collate_pending_symbols_by_language): Remove
11022         "struct" from foreach.
11023         * symtab.c (lookup_global_symbol_from_objfile)
11024         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11025         foreach.
11026         * ser-tcp.c (net_open): Remove "struct" from foreach.
11027         * objfiles.c (objfile_relocate, objfile_rebase)
11028         (objfile_has_symbols): Remove "struct" from foreach.
11029         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11030         from foreach.
11031         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11032         foreach.
11033         * darwin-nat.c (thread_info_from_private_thread_info): Remove
11034         "struct" from foreach.
11035         * ada-lang.c (create_excep_cond_exprs)
11036         (ada_exception_catchpoint_cond_string): Remove "struct" from
11037         foreach.
11038
11039 2019-05-03  Tom Tromey  <tromey@adacore.com>
11040
11041         * ada-exp.y (convert_char_literal): Check suffix of each
11042         enumerator.
11043
11044 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
11045
11046         PR ada/21406:
11047         * ada-exp.y (yywrap): Don't define.
11048         * ada-lex.l (%option): Add noyywrap
11049         (yywrap): Remove.
11050
11051 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
11052
11053         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11054         _WIN32_WINNT to the XP level, unless already defined to a higher
11055         level.
11056
11057         * unittests/parse-connection-spec-selftests.c:
11058         * ser-tcp.c:
11059         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11060         override.
11061
11062         * symfile.c (find_separate_debug_file): Remove colon from the
11063         drive spec of DOS/Windows file names of the target, so that the
11064         file name produced from DEBUGDIR and the target's directory will
11065         be valid on DOS/Windows systems.
11066
11067 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11068
11069         * rust-lang.c (val_print_struct): Handle printing structures
11070         containing strings.
11071
11072 2019-05-02  Tom Tromey  <tromey@adacore.com>
11073
11074         * valarith.c (_initialize_valarith): Remove.
11075
11076 2019-05-01  Tom Tromey  <tromey@adacore.com>
11077
11078         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11079         bitfields.
11080
11081 2019-05-01  Tom Tromey  <tromey@adacore.com>
11082
11083         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11084         for big-endian copies.
11085
11086 2019-04-30  Ali Tamur  <tamur@google.com>
11087         * gdb/dwarf2read.c (read_3_bytes): New declaration.
11088         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11089         (read_3_bytes): New function.
11090
11091 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11092
11093         * windows-nat.c (main_thread_id): Delete.
11094         (handle_output_debug_string): Replace main_thread_id by
11095         current_event.dwThreadId.
11096         (fake_create_process): Likewise.
11097         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11098         Do not set main_thread_id.
11099         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11100         current_event.dwThreadId.
11101         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11102
11103 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11104
11105         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11106         Use current_event.dwThreadId instead of main_thread_id.
11107
11108 2019-04-30  Tom Tromey  <tromey@adacore.com>
11109
11110         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11111         (create_excep_cond_exprs): Iterate over program spaces.
11112         (ada_exception_catchpoint_cond_string): Examine all minimal
11113         symbols for exception types.
11114
11115 2019-04-30  Tom Tromey  <tromey@adacore.com>
11116
11117         PR c++/24470:
11118         * dwarf2read.c (process_structure_scope): Handle case where type
11119         has template parameters but no symbol was created.
11120
11121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11122             Chris January  <chris.january@arm.com>
11123
11124         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11125         qualifier.
11126         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11127
11128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11129
11130         * f-typeprint.c (f_print_type): Update rules for printing
11131         whitespace.
11132         (f_type_print_varspec_suffix): Likewise.
11133
11134 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11135             Chris January  <chris.january@arm.com>
11136
11137         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11138         function arguments.
11139
11140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11141
11142         * f-lang.c (build_fortran_types): Change name of void type to
11143         lower case.
11144         * f-typeprint.c (f_type_print_base): Print the name of the void
11145         type, rather than a fixed string.
11146         * f-valprint.c (f_decorations): Use lower case void string.
11147
11148 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11149             Chris January  <chris.january@arm.com>
11150
11151         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11152         types for Fortran.
11153
11154 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11155             Chris January  <chris.january@arm.com>
11156             David Lecomber  <david.lecomber@arm.com>
11157
11158         * f-exp.y (BINOP_INTRINSIC): New token.
11159         (exp): New parser rule handling BINOP_INTRINSIC.
11160         (f77_keywords): Add new builtin procedures.
11161         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11162         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11163         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11164         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11165         (print_unop_subexp_f): New function.
11166         (print_binop_subexp_f): New function.
11167         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11168         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11169         (dump_subexp_body_f): Likewise.
11170         (operator_check_f): Likewise.
11171         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11172         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11173
11174 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11175
11176         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11177         UNOP_KIND.
11178         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11179         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11180         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11181         (operator_length_f): New fuction.
11182         (print_subexp_f): New function.
11183         (op_name_f): New function.
11184         (dump_subexp_body_f): New function.
11185         (operator_check_f): New function.
11186         (exp_descriptor_f): Replace standard expression handling functions
11187         with new functions.
11188         * gdb/fortran-operator.def: New file.
11189         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11190         * gdb/std-operator.def: Remove UNOP_KIND.
11191
11192 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11193
11194         * std-operator.def: Remove unbalanced, stray double quote
11195         character.
11196
11197 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11198             Chris January  <chris.january@arm.com>
11199             Daniel Everett  <daniel.everett@arm.com>
11200             Nick Forrington  <nick.forrington@arm.com>
11201             Richard Bunt  <richard.bunt@arm.com>
11202
11203         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11204         of depth when printing anonymous structs or unions.
11205         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11206         Don't print either the top-level value, or the children if the
11207         max-depth is exceeded.
11208         (ppscm_print_children): When printing the key of a map, allow one
11209         extra level of depth.
11210         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11211         print either the top-level value, or the children if the max-depth
11212         is exceeded.
11213         (print_children): When printing the key of a map, allow one extra
11214         level of depth.
11215         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11216         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11217         (user_print_options): Initialise max_depth field.
11218         (val_print_scalar_or_string_type_p): New function.
11219         (val_print): Check to see if the max depth has been reached.
11220         (val_print_check_max_depth): Define new function.
11221         (show_print_max_depth): New function.
11222         (_initialize_valprint): Add 'print max-depth' option.
11223         * valprint.h (struct value_print_options) <max_depth>: New field.
11224         (val_print_check_max_depth): Declare new function.
11225         * NEWS: Document new feature.
11226
11227 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11228
11229         * ada-lang.c (ada_language_defn): Initialise new field.
11230         * c-lang.c (c_is_string_type_p): New function.
11231         (c_language_defn): Initialise new field.
11232         (cplus_language_defn): Initialise new field.
11233         (asm_language_defn): Initialise new field.
11234         (minimal_language_defn): Initialise new field.
11235         * c-lang.h (c_is_string_type_p): Declare new function.
11236         * d-lang.c (d_language_defn): Initialise new field.
11237         * f-lang.c (f_is_string_type_p): New function.
11238         (f_language_defn): Initialise new field.
11239         * go-lang.c (go_is_string_type_p): New function.
11240         (go_language_defn): Initialise new field.
11241         * language.c (default_is_string_type_p): New function.
11242         (unknown_language_defn): Initialise new field.
11243         (auto_language_defn): Initialise new field.
11244         * language.h (struct language_defn) <la_is_string_type_p>: New
11245         member variable.
11246         (default_is_string_type_p): Declare new function.
11247         * m2-lang.c (m2_language_defn): Initialise new field.
11248         * objc-lang.c (objc_language_defn): Initialise new field.
11249         * opencl-lang.c (opencl_language_defn): Initialise new field.
11250         * p-lang.c (pascal_is_string_type_p): New function.
11251         (pascal_language_defn): Initialise new field.
11252         * rust-lang.c (rust_is_string_type_p): New function.
11253         (rust_language_defn): Initialise new field.
11254
11255 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11256
11257         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11258         New field.
11259         * ada-lang.c (ada_language_defn): Initialise new field.
11260         * c-lang.c (c_language_defn): Likewise.
11261         (cplus_language_defn): Likewise.
11262         (asm_language_defn): Likewise.
11263         (minimal_language_defn): Likewise.
11264         * d-lang.c (d_language_defn): Likewise.
11265         * f-lang.c (f_language_defn): Likewise.
11266         * go-lang.c (go_language_defn): Likewise.
11267         * language.c (unknown_language_defn): Likewise.
11268         (auto_language_defn): Likewise.
11269         * m2-lang.c (m2_language_defn): Likewise.
11270         * objc-lang.c (objc_language_defn): Likewise.
11271         * opencl-lang.c (opencl_language_defn): Likewise.
11272         * p-lang.c (pascal_language_defn): Likewise.
11273         * rust-lang.c (rust_language_defn): Likewise.
11274
11275 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11276
11277         * ada-lang.c (ada_is_character_type): Change return type to bool.
11278         (ada_is_string_type): Likewise.
11279         * ada-lang.h (ada_is_character_type): Update declaration
11280         (ada_is_string_type): Likewise.
11281
11282 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11283
11284         Support style in 'frame|thread apply'
11285
11286         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11287         * record.c (record_start, record_stop): Update callers of
11288         execute_command_to_string with false.
11289         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11290         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11291         methods.
11292         (class string_file): New constructor with term_out parameter.
11293         Override methods term_out and can_emit_style_escape.  New member
11294         term_out.
11295         (class stdio_file): Override can_emit_style_escape.
11296         (class tee_file): Override term_out and can_emit_style_escape.
11297         * utils.h (can_emit_style_escape): Remove.
11298         * utils.c (can_emit_style_escape): Likewise.
11299         Update all callers of can_emit_style_escape (SOMESTREAM) to
11300         SOMESTREAM->can_emit_style_escape.
11301         * source-cache.c (source_cache::get_source_lines): Likewise.
11302         * stack.c (frame_apply_command_count): Call execute_command_to_string
11303         passing the term_out characteristic of the current gdb_stdout.
11304         * thread.c (thr_try_catch_cmd): Likewise.
11305         * top.c (execute_command_to_string): pass term_out parameter
11306         to construct the string_file for the command output.
11307         * ui-file.c (term_cli_styling): New function (most code moved
11308         from utils.c can_emit_style_escape).
11309         (string_file::string_file, string_file::can_emit_style_escape,
11310         stdio_file::can_emit_style_escape, tee_file::term_out,
11311         tee_file::can_emit_style_escape): New functions.
11312
11313 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11314
11315         * NEWS: Mention the new set|show may-call-functions.
11316         * infcall.c (may_call_functions_p): New variable.
11317         (show_may_call_functions_p): New function.
11318         (call_function_by_hand_dummy): Throws an error if not
11319         may-call-functions.
11320         (_initialize_infcall): Call add_setshow_boolean_cmd for
11321         may-call-functions.
11322
11323 2019-04-25  Keith Seitz  <keiths@redhat.com>
11324
11325         PR c++/24367
11326         * cp-support.c (inspect_type): Don't attempt substitutions
11327         of symbol with the same name.
11328
11329 2019-04-25  Tom Tromey  <tromey@adacore.com>
11330
11331         PR gdb/24475:
11332         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11333         static.
11334
11335 2019-04-25  Tom Tromey  <tromey@adacore.com>
11336
11337         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11338         rvalue reference.
11339         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11340         (gdb_xml_parser::parse): Use std::move.
11341         * python/python-internal.h (gdbpy_convert_exception): Take a const
11342         reference.
11343         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11344         std::move.
11345         * python/py-utils.c (gdbpy_convert_exception): Take a const
11346         reference.
11347         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11348         Use std::move.
11349         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11350         Use std::move.
11351         * mi/mi-main.c (mi_print_exception): Take a const reference.
11352         * main.c (handle_command_errors): Take a const reference.
11353         * linespec.c (parse_linespec): Use std::move.
11354         * infcall.c (run_inferior_call): Use std::move.
11355         (call_function_by_hand_dummy): Use std::move.
11356         * exec.c (try_open_exec_file): Use std::move.
11357         * exceptions.h (exception_print, exception_fprintf)
11358         (exception_print_same): Update.
11359         * exceptions.c (print_exception, exception_print)
11360         (exception_fprintf, exception_print_same): Change parameters to
11361         const reference.
11362         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11363         * common/new-op.c: Use std::move.
11364         * common/common-exceptions.h (struct gdb_exception): Add move
11365         constructor.
11366         (struct gdb_exception_error, struct gdb_exception_quit, struct
11367         gdb_quit_bad_alloc): Change constructor to move constructor.
11368         (throw_exception): Change parameter to rvalue reference.
11369         * common/common-exceptions.c (throw_exception): Take rvalue
11370         reference.
11371         * cli/cli-interp.c (safe_execute_command): Use std::move.
11372         * breakpoint.c (insert_bp_location, location_to_sals): Use
11373         std::move.
11374
11375 2019-04-25  Tom Tromey  <tromey@adacore.com>
11376
11377         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11378         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11379         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11380         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11381         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11382         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11383         guile/scm-value.c: Use unpack.
11384         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11385         gdbscm_gdb_exception.
11386         (gdbscm_throw_gdb_exception): Likewise.
11387         (struct gdbscm_gdb_exception): New.
11388         (unpack): New function.
11389         (gdbscm_wrap): Use unpack.
11390
11391 2019-04-25  Tom Tromey  <tromey@adacore.com>
11392
11393         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11394         (gdb_rl_callback_handler): Use std::move.
11395         * common/common-exceptions.h (struct gdb_exception): Add move
11396         assignment operator.
11397         (throw_exception_sjlj): Change "exception" to const reference.
11398         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11399         (throw_exception_sjlj): Change "exception" to const reference.
11400
11401 2019-04-25  Tom Tromey  <tromey@adacore.com>
11402
11403         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11404         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11405         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11406         Update.
11407         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11408         Update.
11409         * mi/mi-interp.c (mi_interp::exec): Update.
11410         * linespec.c (parse_linespec): Update.
11411         * infcall.c (run_inferior_call): Update.
11412         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11413         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11414         (gdbscm_lookup_global_symbol): Update.
11415         * guile/scm-param.c (gdbscm_parameter_value): Update.
11416         * guile/scm-frame.c (gdbscm_frame_read_register)
11417         (gdbscm_frame_read_var): Update.
11418         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11419         * exec.c (try_open_exec_file): Update.
11420         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11421         (gdb_rl_callback_handler): Update.
11422         * common/common-exceptions.h (exception_none): Don't declare.
11423         * common/common-exceptions.c (exception_none): Don't define.
11424         (struct catcher) <exception>: Update.
11425         * cli/cli-interp.c (safe_execute_command): Update.
11426         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11427
11428 2019-04-25  Ali Tamur  <tamur@google.com>
11429
11430         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11431         (read_attribute_value): Likewise.
11432         (dwarf2_read_addr_index): Update comment.
11433         (read_str_index): Add DW_FORM_strx.
11434         (dwarf2_string_attr): Likewise.
11435         (dwarf2_const_value_attr): Likewise.
11436         (dump_die_shallow): Likewise.
11437         (dwarf2_fetch_constant_bytes): Likewise.
11438         (skip_form_bytes): Likewise.
11439         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11440
11441 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11442
11443         PR corefiles/11608
11444         PR corefiles/18187
11445         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11446         OFFSET.  Verify if current mapping contains an ELF header.
11447         (linux_find_memory_regions_full): Adjust call to
11448         dump_mapping_p.
11449
11450 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11451             Kang Li <kanglictf@gmail.com>
11452
11453         PR gdb/21600
11454
11455         * dwarf2-frame.c (read_initial_length): Be consistent about using
11456         unsigned representation of length.
11457         (decode_frame_entry_1): Likewise.  Check for wraparound of
11458         end pointer as well as buffer overflow.
11459
11460 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11461
11462         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11463         "vq".
11464
11465 2019-04-24  Tom Tromey  <tromey@adacore.com>
11466
11467         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11468
11469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * s12z-tdep.c (s12z_unwind_pc): Delete.
11472         (s12z_unwind_sp): Delete.
11473         (s12z_gdbarch_init): Don't register deleted functions with
11474         gdbarch.
11475
11476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11477
11478         * rl78-tdep.c (rl78_unwind_sp): Delete.
11479         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11480
11481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11482
11483         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11484         (xstormy16_unwind_pc): Delete.
11485         (xstormy16_dummy_id): Delete.
11486         (xstormy16_gdbarch_init): Don't register deleted functions with
11487         gdbarch.
11488
11489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11490
11491         * vax-tdep.c (vax_unwind_pc): Delete.
11492         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11493
11494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * v850-tdep.c (v850_unwind_sp): Delete.
11497         (v850_unwind_pc): Delete.
11498         (v850_dummy_id): Delete.
11499         (v850_gdbarch_init): Don't register deleted functions with
11500         gdbarch.
11501
11502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11503
11504         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11505         (tilegx_unwind_pc): Delete.
11506         (tilegx_unwind_dummy_id): Delete.
11507         (tilegx_gdbarch_init): Don't register deleted functions with
11508         gdbarch.
11509
11510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11513         (tic6x_dummy_id): Delete.
11514         (tic6x_gdbarch_init): Don't register deleted functions with
11515         gdbarch.
11516
11517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11518
11519         * sparc-tdep.c (sparc_unwind_pc): Delete.
11520         (sparc32_gdbarch_init): Don't register deleted function with
11521         gdbarch.
11522
11523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11524
11525         * sh-tdep.c (sh_unwind_sp): Delete.
11526         (sh_unwind_pc): Delete.
11527         (sh_dummy_id): Delete.
11528         (sh_gdbarch_init): Don't register deleted functions with
11529         gdbarch.
11530
11531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11532
11533         * score-tdep.c (score_unwind_sp): Delete.
11534         (score_unwind_pc): Delete.
11535         (score_dummy_id): Delete.
11536         (score_gdbarch_init): Don't register deleted functions with
11537         gdbarch.
11538
11539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11540
11541         * rx-tdep.c (rx_unwind_pc): Delete.
11542         (rx_unwind_sp): Delete.
11543         (rx_dummy_id): Delete.
11544         (rx_gdbarch_init): Don't register deleted functions with
11545         gdbarch.  Update comment.
11546
11547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11550         (rs6000_dummy_id): Delete.
11551         (rs6000_gdbarch_init): Don't register deleted functions with
11552         gdbarch.
11553
11554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11555
11556         * or1k-tdep.c (or1k_dummy_id): Delete.
11557         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11558
11559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11560
11561         * nios2-tdep.c (nios2_dummy_id): Delete.
11562         (nios2_unwind_sp): Delete.
11563         (nios2_gdbarch_init): Don't register deleted functions with
11564         gdbarch.
11565
11566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11567
11568         * nds32-tdep.c (nds32_dummy_id): Delete.
11569         (nds32_unwind_pc): Delete.
11570         (nds32_unwind_sp): Delete.
11571         (nds32_gdbarch_init): Don't register deleted functions with
11572         gdbarch.
11573
11574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * msp430-tdep.c (msp430_unwind_pc): Delete.
11577         (msp430_unwind_sp): Delete.
11578         (msp430_dummy_id): Delete.
11579         (msp430_gdbarch_init): Don't register deleted functions with
11580         gdbarch.
11581
11582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11583
11584         * moxie-tdep.c (moxie_unwind_sp): Delete.
11585         (moxie_unwind_pc): Delete.
11586         (moxie_dummy_id): Delete.
11587         (moxie_gdbarch_init): Don't register deleted functions with
11588         gdbarch.
11589
11590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11591
11592         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11593         (mn10300_unwind_pc): Delete.
11594         (mn10300_unwind_sp): Delete.
11595         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11596         mn10300_unwind_sp.
11597         (mn10300_frame_unwind_init): Don't register deleted functions with
11598         gdbarch.
11599
11600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11601
11602         * mep-tdep.c (mep_unwind_pc): Delete.
11603         (mep_unwind_sp): Delete.
11604         (mep_dummy_id): Delete.
11605         (mep_gdbarch_init): Don't register deleted functions with
11606         gdbarch.
11607
11608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11609
11610         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11611         (m68hc11_unwind_sp): Delete.
11612         (m68hc11_gdbarch_init): Don't register deleted functions with
11613         gdbarch.
11614
11615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11616
11617         * m32r-tdep.c (m32r_unwind_sp): Delete.
11618         (m32r_unwind_pc): Delete.
11619         (m32r_dummy_id): Delete.
11620         (m32r_gdbarch_init): Don't register deleted functions with
11621         gdbarch.
11622
11623 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11624
11625         * m32c-tdep.c (m32c_unwind_pc): Delete.
11626         (m32c_unwind_sp): Delete.
11627         (m32c_dummy_id): Delete.
11628         (m32c_gdbarch_init): Don't register deleted functions with
11629         gdbarch.
11630
11631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11634         (lm32_unwind_pc): Delete.
11635         (lm32_dummy_id): Delete.
11636         (lm32_gdbarch_init): Don't register deleted functions with
11637         gdbarch.
11638
11639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11640
11641         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11642         (iq2000_unwind_pc): Delete.
11643         (iq2000_dummy_id): Delete.
11644         (iq2000_gdbarch_init): Don't register deleted functions with
11645         gdbarch.
11646
11647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11648
11649         * nds32-tdep.c (nds32_type_align): Delete.
11650         (nds32_push_dummy_call): Use type_align instead.
11651
11652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11653
11654         * arm-tdep.c (arm_type_align): Only handle vector override case.
11655         (arm_push_dummy_call): Use type_align.
11656         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11657
11658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11659
11660         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11661         case.
11662         (pass_on_stack): Use type_align.
11663         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11664         function.
11665
11666 2019-04-23  Tom Tromey  <tromey@adacore.com>
11667
11668         * dwarf2read.c (line_header::file_name_at): Remove unused
11669         overload.
11670
11671 2019-04-23  Tom de Vries  <tdevries@suse.de>
11672
11673         PR gdb/24438
11674         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11675         invocation.
11676
11677
11678 2019-03-27  Ali Tamur  <tamur@google.com>
11679
11680         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11681         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11682         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11683         (dwarf_expr_context::get_addr_index): Likewise
11684         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11685         (symbol_needs_eval_context::get_addr_index): Likewise
11686         (disassemble_dwarf_expression): Add DW_OP_addrx
11687         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11688         (read_cutu_die_from_dwo): Update comment
11689         (skip_one_die): Add DW_FORM_addrx
11690         (read_attribute_value): Likewise
11691         (var_decode_location): Add DW_OP_addrx
11692         (dwarf2_const_value_attr): Add DW_FORM_addrx
11693         (dump_die_shallow): Likewise
11694         (dwarf2_fetch_constant_bytes): Likewise
11695         (decode_locdesc): Add DW_OP_addrx
11696         (skip_form_bytes): Add DW_FORM_addrx
11697
11698 2019-04-22  Ali Tamur  <tamur@google.com>
11699
11700         * MAINTAINERS (Write After Approval): Add self.
11701
11702 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11703
11704         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11705         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11706         (open_symbol_file_object): Likewise.
11707         (svr4_default_sos): Add info parameter.
11708         (svr4_read_so_list): Likewise.
11709         (svr4_current_sos_direct): Adjust functions calls to pass down
11710         info.
11711         (svr4_current_sos_1): Add info parameter.
11712         (svr4_current_sos): Call get_svr4_info, pass info down to
11713         svr4_current_sos_1.
11714         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11715         get_svr4_info.
11716         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11717         get_svr4_info.
11718         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11719         to get_svr4_info.
11720         (probes_table_remove_objfile_probes): Likewise.
11721         (register_solib_event_probe): Add info parameter.
11722         (solist_update_incremental): Pass info parameter down to
11723         svr4_read_so_list.
11724         (disable_probes_interface): Add info parameter.
11725         (svr4_handle_solib_event): Pass current_program_space to
11726         get_svr4_info.  Adjust disable_probes_interface cleanup.
11727         (svr4_create_probe_breakpoints): Add info parameter, pass it
11728         down to register_solib_event_probe.
11729         (svr4_create_solib_event_breakpoints): Add info parameter,
11730         pass it down to svr4_create_probe_breakpoints.
11731         (enable_break): Pass info down to
11732         svr4_create_solib_event_breakpoints.
11733         (svr4_solib_create_inferior_hook): Pass current_program_space to
11734         get_svr4_info.
11735         (svr4_clear_solib): Likewise.
11736
11737 2019-04-22  Pedro Alves  <palves@redhat.com>
11738
11739         * solib-svr4.c (svr4_free_objfile_observer): New.
11740         (probe_and_action::objfile): New field.
11741         (probes_table_htab_remove_objfile_probes)
11742         (probes_table_remove_objfile_probes): New functions.
11743         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11744         in the new probe_and_action.  Don't store the probe in 'lookup'.
11745         (svr4_create_probe_breakpoints): Pass objfile to
11746         register_solib_event_probe.
11747         (_initialize_svr4_solib): Register a free_objfile observer.
11748
11749 2019-04-19  Tom Tromey  <tom@tromey.com>
11750
11751         * common/queue.h: Remove.
11752
11753 2019-04-19  Tom Tromey  <tom@tromey.com>
11754
11755         * event-loop.c: Don't include "common/queue.h".
11756
11757 2019-04-19  Tom Tromey  <tom@tromey.com>
11758
11759         * remote.c (remote_target): Use delete.
11760         * remote-notif.h: Include <list>, not "common/queue.h".
11761         (notif_client_p): Remove typedef.
11762         (remote_notif_state): Add constructor, destructor, initializer.
11763         <notif_queue>: Now a std::list.
11764         (remote_notif_state_xfree): Don't declare.
11765         * remote-notif.c (remote_notif_process, handle_notification)
11766         (remote_notif_state_allocate): Update.
11767         (~remote_notif_state): Rename from remote_notif_state_xfree.
11768
11769 2019-04-19  Tom Tromey  <tom@tromey.com>
11770
11771         * symfile.c (reread_symbols): Update.
11772         * objfiles.c (objfile_register_static_link)
11773         (objfile_lookup_static_link): Update
11774         (~objfile) Don't delete static_links.
11775         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11776
11777 2019-04-19  Tom Tromey  <tom@tromey.com>
11778
11779         * type-stack.h (struct type_stack) <insert>: Constify string.
11780         * type-stack.c (type_stack::insert): Constify string.
11781         * gdbtypes.h (lookup_template_type): Update.
11782         (address_space_name_to_int): Update.
11783         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11784         const.
11785         (lookup_template_type): Make name const.
11786         * c-exp.y: Update rules.
11787         (lex_one_token, classify_name, classify_inner_name)
11788         (c_print_token): Update.
11789         * p-exp.y: Update rules.
11790         (yylex): Update.
11791         * f-exp.y: Update rules.
11792         (yylex): Update.
11793         * d-exp.y: Update rules.
11794         (lex_one_token, classify_name, classify_inner_name): Update.
11795         * parse.c (write_dollar_variable, copy_name): Return std::string.
11796         * parser-defs.h (copy_name): Change return type.
11797         * m2-exp.y: Update rules.
11798         (yylex): Update.
11799         * go-exp.y (lex_one_token): Update.
11800         Update rules.
11801         (classify_unsafe_function, classify_packaged_name)
11802         (classify_name, yylex): Update.
11803
11804 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11805
11806         * configure.ac: add --enable-source-highlight switch.
11807         * configure: Regenerate.
11808         * top.c (print_gdb_version): plumb --enable-source-highlight
11809         status to "show configuration".
11810
11811 2019-04-19  Tom Tromey  <tromey@adacore.com>
11812
11813         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11814         Check ADA_TYPE_P.
11815         (empty_record, ada_template_to_fixed_record_type_1)
11816         (template_to_static_fixed_type)
11817         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11818         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11819         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11820         macros.
11821
11822 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11823
11824         PR symtab/24423:
11825         * source.c (print_source_lines_base): Advance "iter" when a
11826         control character is seen.
11827
11828 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11829
11830         * inferior.h (struct infcall_suspend_state_deleter):
11831         Catch exception in destructor to avoid crash.
11832
11833 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11834
11835         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11836         close to the add_com "shell".
11837
11838 2019-04-18  Tom Tromey  <tromey@adacore.com>
11839
11840         * process-stratum-target.h (class process_stratum_target)
11841         <stratum>: Add "final".
11842
11843 2019-04-17  Tom Tromey  <tromey@adacore.com>
11844
11845         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11846         against nullptr before use.
11847
11848 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11849
11850         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11851
11852 2019-04-17  Jim Wilson  <jimw@sifive.com>
11853             Andrew Burgess  <andrew.burgess@embecosm.com>
11854
11855         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11856         code read might fail, assume 4-byte breakpoint in that case.
11857
11858 2019-04-15  Leszek Swirski  <leszeks@google.com>
11859
11860         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11861         rather than a hand-rolled POD check when checking for forced MEMORY
11862         classification.
11863
11864 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11865
11866         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11867         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11868         function.
11869         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11870         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11871         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11872         declaration.
11873
11874 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11875
11876         * aarch64-linux-nat.c
11877         (aarch64_linux_nat_target::thread_architecture): Add override.
11878         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11879         each VQ.
11880
11881 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11882
11883         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11884
11885 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11886
11887         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11888         target types of size 96-bits, add some additional comments, and
11889         check that the builtin type we found was the correct size.
11890
11891 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11892
11893         * utils.c (prompt_for_continue): Don't restore the styling at the
11894         end, as applied_style has the wrong value.  This fixes styling in
11895         long lists of file names that are interrupted by the "Continue?"
11896         prompt.
11897
11898 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11901         * c-lang.c (c_language_defn): Likewise.
11902         (cplus_language_defn): Likewise.
11903         (asm_language_defn): Likewise.
11904         (minimal_language_defn): Likewise.
11905         * d-lang.c (d_language_defn): Likewise.
11906         * f-lang.c (f_language_defn): Likewise.
11907         * go-lang.c (go_language_defn): Likewise.
11908         * language.c (unknown_language_defn): Likewise.
11909         (auto_language_defn): Likewise.
11910         * language.h (struct language_defn): Remove la_magic field.
11911         (LANG_MAGIC): Delete.
11912         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11913         * objc-lang.c (objc_language_defn): Likewise.
11914         * opencl-lang.c (opencl_language_defn): Likewise.
11915         * p-lang.c (pascal_language_defn): Likewise.
11916         * rust-lang.c (rust_language_defn): Likewise.
11917
11918 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * riscv-tdep.c (riscv_type_align): New function.
11921         (riscv_type_alignment): Delete.
11922         (riscv_arg_location): Use 'type_align'.
11923         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11924
11925 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11926
11927         * gdbtypes.c (type_align): A struct with no non-static fields also
11928         has alignment of 1.
11929
11930 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11931
11932         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11933         component to 0.
11934         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11935         member.
11936         (riscv_struct_info::analyse): New implementation using new
11937         analyse_inner member function.
11938         (riscv_struct_info::field_offset): New member function.
11939         (riscv_struct_info::m_offsets): New member variable.
11940         (riscv_struct_info::analyse_inner): New private member function,
11941         takes the old implementation of riscv_struct_info::analyse but
11942         extended to track field offsets.
11943         (riscv_call_arg_struct): Update the struct folding special cases
11944         to handle cases where empty C++ structs, which are non-zero
11945         length, are found.
11946         (riscv_arg_location): Initialise the length of each location, a
11947         non-zero length now indicates the location is in use.
11948         (riscv_push_dummy_call): Allow for the first location having a
11949         non-zero offset when setting up arguments.
11950         (riscv_return_value): Likewise, but for return values.
11951
11952 2019-04-11  Tom Tromey  <tromey@adacore.com>
11953
11954         * utils.c (internal_vproblem): Make "msg" const.
11955
11956 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11957
11958         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11959         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11960         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11961         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11962
11963 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11964
11965         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11966         function.
11967         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11968         of amd64_collect_native_gregset.
11969         (amd64_linux_nat_target::store_registers): Likewise.
11970
11971 2019-04-10  Tom Tromey  <tom@tromey.com>
11972
11973         * symtab.c (lookup_global_symbol_from_objfile)
11974         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11975         * objfiles.h (class separate_debug_iterator): New.
11976         (class separate_debug_range): New.
11977         (struct objfile) <separate_debug_objfiles>: New method.
11978         (objfile_separate_debug_iterate): Don't declare.
11979         * objfiles.c (separate_debug_iterator::operator++): Rename from
11980         objfile_separate_debug_iterate.
11981         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11982         iterator.
11983         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11984         iterator.
11985
11986 2019-04-10  Tom Tromey  <tom@tromey.com>
11987
11988         * symfile.c (reread_symbols): Remove old comment.
11989         * objfiles.c (free_all_objfiles): Fix a typo.
11990
11991 2019-04-10  Tom Tromey  <tom@tromey.com>
11992
11993         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11994         * minsyms.c (lookup_minimal_symbol): Use foreach.
11995         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11996         (lookup_minimal_symbol_solib_trampoline): Likewise.
11997         * symfile.c (reread_symbols): Use foreach.
11998
11999 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
12000             Tom Tromey  <tromey@adacore.com>
12001
12002         PR rust/24414:
12003         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
12004         (rust_lex_int_test): Change "value" to be LONGEST.
12005         (rust_lex_tests): Add test for long integer literal.
12006
12007 2019-04-09  Tom Tromey  <tromey@adacore.com>
12008
12009         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
12010         to bool.
12011         (extended_remote_target::attach): Update.
12012         (remote_target::remote_notice_new_inferior): Update.
12013         (remote_target::add_current_inferior_and_thread): Update.
12014         * inferior.c (exit_inferior_1): Use "false".
12015         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12016
12017 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
12018
12019         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
12020         the "start" command.
12021
12022 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12023
12024         * python/py-inferior.c (infpy_thread_from_thread_handle):
12025         Adjust comments to reflect renaming of thread_from_thread_handle
12026         to thread_from_handle.  Adjust keywords.  Fix type error message.
12027         (inferior_object_methods): Add thread_from_handle.  Retain
12028         thread_from_thread_handle, but mark it as deprecated.
12029
12030 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12031
12032         * gdbthread.h (find_thread_by_handle): Revise declaration.
12033         * thread.c (find_thread_by_handle): Likewise.  Adjust
12034         implementation too.
12035         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12036         support for buffer objects as handles.
12037
12038 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12039
12040         * python/py-infthread.c (thpy_thread_handle): New function.
12041         (thread_object_methods): Register thpy_thread_handle.
12042
12043 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12044
12045         * gdbthread.h (thread_to_thread_handle): Declare.
12046         * thread.c (gdbtypes.h): Include.
12047         (thread_to_thread_handle): New function.
12048
12049         * target.h (struct target_ops): Add thread_info_to_thread_handle.
12050         (target_thread_info_to_thread_handle): Declare.
12051         * target.c (target_thread_info_to_thread_handle): New function.
12052         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12053         * target-delegates.c: Regenerate.
12054
12055         * linux-thread-db.c (class thread_db_target): Add method
12056         thread_info_to_thread_handle.
12057         (thread_db_target::thread_info_to_thread_handle): Define.
12058         * remote.c (class remote_target): Add new method
12059         thread_info_to_thread_handle.
12060         (remote_target::thread_info_to_thread_handle): Define.
12061
12062 2019-04-08  Pedro Alves  <palves@redhat.com>
12063
12064         * common/common-exceptions.c (throw_exception): Don't create
12065         named object to throw; throw directly.
12066         (throw_it): Likewise.  Don't initialize gdb_exception::message
12067         here, with new; pass FMT and AP to the ctor instead.
12068         * common/common-exceptions.h: Include <string>.
12069         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12070         const char *, va_list)): New ctor.  Use std::make_shared.
12071         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12072         errors)): Delete.
12073         (gdb_exception_error::gdb_exception_error(enum errors, const char
12074         *, va_list)): New.
12075         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12076         Add assertion.
12077         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12078         errors)): Delete.
12079         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12080         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12081         Add assertion.
12082
12083 2019-04-08  Tom Tromey  <tom@tromey.com>
12084
12085         * valops.c (value_rtti_indirect_type): Replace throw_exception
12086         with throw.
12087         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12088         with throw.
12089         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12090         throw.
12091         * target.c (target_translate_tls_address): Replace throw_exception
12092         with throw.
12093         * stack.c (frame_apply_command_count): Replace throw_exception
12094         with throw.
12095         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12096         throw.
12097         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12098         with throw.
12099         * rs6000-tdep.c (rs6000_frame_cache)
12100         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12101         * remote.c: Replace throw_exception with throw.
12102         * record-full.c (record_full_message, record_full_wait_1)
12103         (record_full_restore): Replace throw_exception with throw.
12104         * record-btrace.c:
12105         (get_thread_current_frame_id, record_btrace_start_replaying)
12106         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12107         (cmd_record_btrace_start): Replace throw_exception with throw.
12108         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12109         throw.
12110         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12111         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12112         * linespec.c:
12113         (find_linespec_symbols): Replace throw_exception with throw.
12114         * infrun.c (displaced_step_prepare, resume): Replace
12115         throw_exception with throw.
12116         * infcmd.c (post_create_inferior): Replace throw_exception with
12117         throw.
12118         * inf-loop.c (inferior_event_handler): Replace throw_exception
12119         with throw.
12120         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12121         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12122         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12123         (get_prev_frame_always, get_frame_pc_if_available)
12124         (get_frame_address_in_block_if_available, get_frame_language):
12125         Replace throw_exception with throw.
12126         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12127         throw_exception with throw.
12128         * eval.c (fetch_subexp_value, evaluate_var_value)
12129         (evaluate_funcall, evaluate_subexp_standard): Replace
12130         throw_exception with throw.
12131         * dwarf2loc.c (call_site_find_chain)
12132         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12133         Replace throw_exception with throw.
12134         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12135         with throw.
12136         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12137         throw.
12138         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12139         * completer.c (complete_line_internal): Replace throw_exception
12140         with throw.
12141         * compile/compile-object-run.c (compile_object_run): Replace
12142         throw_exception with throw.
12143         * cli/cli-script.c (process_next_line): Replace throw_exception
12144         with throw.
12145         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12146         (btrace_enable, btrace_maint_update_pt_packets): Replace
12147         throw_exception with throw.
12148         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12149         throw_exception with throw.
12150         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12151         throw_exception with throw.
12152         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12153         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12154         * aarch64-tdep.c (aarch64_make_prologue_cache)
12155         (aarch64_make_stub_cache): Replace throw_exception with throw.
12156
12157 2019-04-08  Tom Tromey  <tom@tromey.com>
12158
12159         * common/common-exceptions.c (throw_exception): Rename from
12160         throw_exception_cxx.  Remove old copy.  Make argument const.
12161         (throw_it): Create and throw exception objects directly.
12162         * common/common-exceptions.h (throw_exception): Make argument
12163         const.
12164         (struct gdb_exception_error): Add constructor.
12165         (struct gdb_exception_quit): Add constructor.
12166
12167 2019-04-08  Tom Tromey  <tom@tromey.com>
12168
12169         * common/common-exceptions.h (exception_rethrow): Don't declare.
12170         (TRY_SJLJ): Update comment.
12171         (TRY, CATCH, END_CATCH): Remove.
12172         * common/common-exceptions.c (exception_rethrow): Remove.
12173
12174 2019-04-08  Tom Tromey  <tom@tromey.com>
12175
12176         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12177         Remove.
12178         (gdb_exception_error): Rename from
12179         gdb_exception_RETURN_MASK_ERROR.
12180         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12181         (gdb_quit_bad_alloc): Update.
12182         * aarch64-tdep.c: Update.
12183         * ada-lang.c: Update.
12184         * ada-typeprint.c: Update.
12185         * ada-valprint.c: Update.
12186         * amd64-tdep.c: Update.
12187         * arch-utils.c: Update.
12188         * break-catch-throw.c: Update.
12189         * breakpoint.c: Update.
12190         * btrace.c: Update.
12191         * c-varobj.c: Update.
12192         * cli/cli-cmds.c: Update.
12193         * cli/cli-interp.c: Update.
12194         * cli/cli-script.c: Update.
12195         * common/common-exceptions.c: Update.
12196         * common/new-op.c: Update.
12197         * common/selftest.c: Update.
12198         * compile/compile-c-symbols.c: Update.
12199         * compile/compile-cplus-symbols.c: Update.
12200         * compile/compile-object-load.c: Update.
12201         * compile/compile-object-run.c: Update.
12202         * completer.c: Update.
12203         * corelow.c: Update.
12204         * cp-abi.c: Update.
12205         * cp-support.c: Update.
12206         * cp-valprint.c: Update.
12207         * darwin-nat.c: Update.
12208         * disasm-selftests.c: Update.
12209         * dtrace-probe.c: Update.
12210         * dwarf-index-cache.c: Update.
12211         * dwarf-index-write.c: Update.
12212         * dwarf2-frame-tailcall.c: Update.
12213         * dwarf2-frame.c: Update.
12214         * dwarf2loc.c: Update.
12215         * dwarf2read.c: Update.
12216         * eval.c: Update.
12217         * event-loop.c: Update.
12218         * event-top.c: Update.
12219         * exec.c: Update.
12220         * f-valprint.c: Update.
12221         * fbsd-tdep.c: Update.
12222         * frame-unwind.c: Update.
12223         * frame.c: Update.
12224         * gdbtypes.c: Update.
12225         * gnu-v3-abi.c: Update.
12226         * guile/guile-internal.h: Update.
12227         * guile/scm-block.c: Update.
12228         * guile/scm-breakpoint.c: Update.
12229         * guile/scm-cmd.c: Update.
12230         * guile/scm-disasm.c: Update.
12231         * guile/scm-frame.c: Update.
12232         * guile/scm-lazy-string.c: Update.
12233         * guile/scm-math.c: Update.
12234         * guile/scm-param.c: Update.
12235         * guile/scm-ports.c: Update.
12236         * guile/scm-pretty-print.c: Update.
12237         * guile/scm-symbol.c: Update.
12238         * guile/scm-symtab.c: Update.
12239         * guile/scm-type.c: Update.
12240         * guile/scm-value.c: Update.
12241         * i386-linux-tdep.c: Update.
12242         * i386-tdep.c: Update.
12243         * inf-loop.c: Update.
12244         * infcall.c: Update.
12245         * infcmd.c: Update.
12246         * infrun.c: Update.
12247         * jit.c: Update.
12248         * language.c: Update.
12249         * linespec.c: Update.
12250         * linux-fork.c: Update.
12251         * linux-nat.c: Update.
12252         * linux-tdep.c: Update.
12253         * linux-thread-db.c: Update.
12254         * main.c: Update.
12255         * mi/mi-cmd-break.c: Update.
12256         * mi/mi-cmd-stack.c: Update.
12257         * mi/mi-interp.c: Update.
12258         * mi/mi-main.c: Update.
12259         * objc-lang.c: Update.
12260         * p-valprint.c: Update.
12261         * parse.c: Update.
12262         * ppc-linux-tdep.c: Update.
12263         * printcmd.c: Update.
12264         * python/py-arch.c: Update.
12265         * python/py-breakpoint.c: Update.
12266         * python/py-cmd.c: Update.
12267         * python/py-finishbreakpoint.c: Update.
12268         * python/py-frame.c: Update.
12269         * python/py-framefilter.c: Update.
12270         * python/py-gdb-readline.c: Update.
12271         * python/py-inferior.c: Update.
12272         * python/py-infthread.c: Update.
12273         * python/py-lazy-string.c: Update.
12274         * python/py-linetable.c: Update.
12275         * python/py-objfile.c: Update.
12276         * python/py-param.c: Update.
12277         * python/py-prettyprint.c: Update.
12278         * python/py-progspace.c: Update.
12279         * python/py-record-btrace.c: Update.
12280         * python/py-record.c: Update.
12281         * python/py-symbol.c: Update.
12282         * python/py-type.c: Update.
12283         * python/py-unwind.c: Update.
12284         * python/py-utils.c: Update.
12285         * python/py-value.c: Update.
12286         * python/python.c: Update.
12287         * record-btrace.c: Update.
12288         * record-full.c: Update.
12289         * remote-fileio.c: Update.
12290         * remote.c: Update.
12291         * riscv-tdep.c: Update.
12292         * rs6000-aix-tdep.c: Update.
12293         * rs6000-tdep.c: Update.
12294         * rust-exp.y: Update.
12295         * rust-lang.c: Update.
12296         * s390-tdep.c: Update.
12297         * selftest-arch.c: Update.
12298         * solib-dsbt.c: Update.
12299         * solib-frv.c: Update.
12300         * solib-spu.c: Update.
12301         * solib-svr4.c: Update.
12302         * solib.c: Update.
12303         * sparc64-linux-tdep.c: Update.
12304         * stack.c: Update.
12305         * symfile-mem.c: Update.
12306         * symmisc.c: Update.
12307         * target.c: Update.
12308         * thread.c: Update.
12309         * top.c: Update.
12310         * tracefile-tfile.c: Update.
12311         * tui/tui.c: Update.
12312         * typeprint.c: Update.
12313         * unittests/cli-utils-selftests.c: Update.
12314         * unittests/parse-connection-spec-selftests.c: Update.
12315         * valops.c: Update.
12316         * valprint.c: Update.
12317         * value.c: Update.
12318         * varobj.c: Update.
12319         * windows-nat.c: Update.
12320         * x86-linux-nat.c: Update.
12321         * xml-support.c: Update.
12322
12323 2019-04-08  Tom Tromey  <tom@tromey.com>
12324
12325         * xml-support.c: Use C++ exception handling.
12326         * x86-linux-nat.c: Use C++ exception handling.
12327         * windows-nat.c: Use C++ exception handling.
12328         * varobj.c: Use C++ exception handling.
12329         * value.c: Use C++ exception handling.
12330         * valprint.c: Use C++ exception handling.
12331         * valops.c: Use C++ exception handling.
12332         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12333         handling.
12334         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12335         * typeprint.c: Use C++ exception handling.
12336         * tui/tui.c: Use C++ exception handling.
12337         * tracefile-tfile.c: Use C++ exception handling.
12338         * top.c: Use C++ exception handling.
12339         * thread.c: Use C++ exception handling.
12340         * target.c: Use C++ exception handling.
12341         * symmisc.c: Use C++ exception handling.
12342         * symfile-mem.c: Use C++ exception handling.
12343         * stack.c: Use C++ exception handling.
12344         * sparc64-linux-tdep.c: Use C++ exception handling.
12345         * solib.c: Use C++ exception handling.
12346         * solib-svr4.c: Use C++ exception handling.
12347         * solib-spu.c: Use C++ exception handling.
12348         * solib-frv.c: Use C++ exception handling.
12349         * solib-dsbt.c: Use C++ exception handling.
12350         * selftest-arch.c: Use C++ exception handling.
12351         * s390-tdep.c: Use C++ exception handling.
12352         * rust-lang.c: Use C++ exception handling.
12353         * rust-exp.y: Use C++ exception handling.
12354         * rs6000-tdep.c: Use C++ exception handling.
12355         * rs6000-aix-tdep.c: Use C++ exception handling.
12356         * riscv-tdep.c: Use C++ exception handling.
12357         * remote.c: Use C++ exception handling.
12358         * remote-fileio.c: Use C++ exception handling.
12359         * record-full.c: Use C++ exception handling.
12360         * record-btrace.c: Use C++ exception handling.
12361         * python/python.c: Use C++ exception handling.
12362         * python/py-value.c: Use C++ exception handling.
12363         * python/py-utils.c: Use C++ exception handling.
12364         * python/py-unwind.c: Use C++ exception handling.
12365         * python/py-type.c: Use C++ exception handling.
12366         * python/py-symbol.c: Use C++ exception handling.
12367         * python/py-record.c: Use C++ exception handling.
12368         * python/py-record-btrace.c: Use C++ exception handling.
12369         * python/py-progspace.c: Use C++ exception handling.
12370         * python/py-prettyprint.c: Use C++ exception handling.
12371         * python/py-param.c: Use C++ exception handling.
12372         * python/py-objfile.c: Use C++ exception handling.
12373         * python/py-linetable.c: Use C++ exception handling.
12374         * python/py-lazy-string.c: Use C++ exception handling.
12375         * python/py-infthread.c: Use C++ exception handling.
12376         * python/py-inferior.c: Use C++ exception handling.
12377         * python/py-gdb-readline.c: Use C++ exception handling.
12378         * python/py-framefilter.c: Use C++ exception handling.
12379         * python/py-frame.c: Use C++ exception handling.
12380         * python/py-finishbreakpoint.c: Use C++ exception handling.
12381         * python/py-cmd.c: Use C++ exception handling.
12382         * python/py-breakpoint.c: Use C++ exception handling.
12383         * python/py-arch.c: Use C++ exception handling.
12384         * printcmd.c: Use C++ exception handling.
12385         * ppc-linux-tdep.c: Use C++ exception handling.
12386         * parse.c: Use C++ exception handling.
12387         * p-valprint.c: Use C++ exception handling.
12388         * objc-lang.c: Use C++ exception handling.
12389         * mi/mi-main.c: Use C++ exception handling.
12390         * mi/mi-interp.c: Use C++ exception handling.
12391         * mi/mi-cmd-stack.c: Use C++ exception handling.
12392         * mi/mi-cmd-break.c: Use C++ exception handling.
12393         * main.c: Use C++ exception handling.
12394         * linux-thread-db.c: Use C++ exception handling.
12395         * linux-tdep.c: Use C++ exception handling.
12396         * linux-nat.c: Use C++ exception handling.
12397         * linux-fork.c: Use C++ exception handling.
12398         * linespec.c: Use C++ exception handling.
12399         * language.c: Use C++ exception handling.
12400         * jit.c: Use C++ exception handling.
12401         * infrun.c: Use C++ exception handling.
12402         * infcmd.c: Use C++ exception handling.
12403         * infcall.c: Use C++ exception handling.
12404         * inf-loop.c: Use C++ exception handling.
12405         * i386-tdep.c: Use C++ exception handling.
12406         * i386-linux-tdep.c: Use C++ exception handling.
12407         * guile/scm-value.c: Use C++ exception handling.
12408         * guile/scm-type.c: Use C++ exception handling.
12409         * guile/scm-symtab.c: Use C++ exception handling.
12410         * guile/scm-symbol.c: Use C++ exception handling.
12411         * guile/scm-pretty-print.c: Use C++ exception handling.
12412         * guile/scm-ports.c: Use C++ exception handling.
12413         * guile/scm-param.c: Use C++ exception handling.
12414         * guile/scm-math.c: Use C++ exception handling.
12415         * guile/scm-lazy-string.c: Use C++ exception handling.
12416         * guile/scm-frame.c: Use C++ exception handling.
12417         * guile/scm-disasm.c: Use C++ exception handling.
12418         * guile/scm-cmd.c: Use C++ exception handling.
12419         * guile/scm-breakpoint.c: Use C++ exception handling.
12420         * guile/scm-block.c: Use C++ exception handling.
12421         * guile/guile-internal.h: Use C++ exception handling.
12422         * gnu-v3-abi.c: Use C++ exception handling.
12423         * gdbtypes.c: Use C++ exception handling.
12424         * frame.c: Use C++ exception handling.
12425         * frame-unwind.c: Use C++ exception handling.
12426         * fbsd-tdep.c: Use C++ exception handling.
12427         * f-valprint.c: Use C++ exception handling.
12428         * exec.c: Use C++ exception handling.
12429         * event-top.c: Use C++ exception handling.
12430         * event-loop.c: Use C++ exception handling.
12431         * eval.c: Use C++ exception handling.
12432         * dwarf2read.c: Use C++ exception handling.
12433         * dwarf2loc.c: Use C++ exception handling.
12434         * dwarf2-frame.c: Use C++ exception handling.
12435         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12436         * dwarf-index-write.c: Use C++ exception handling.
12437         * dwarf-index-cache.c: Use C++ exception handling.
12438         * dtrace-probe.c: Use C++ exception handling.
12439         * disasm-selftests.c: Use C++ exception handling.
12440         * darwin-nat.c: Use C++ exception handling.
12441         * cp-valprint.c: Use C++ exception handling.
12442         * cp-support.c: Use C++ exception handling.
12443         * cp-abi.c: Use C++ exception handling.
12444         * corelow.c: Use C++ exception handling.
12445         * completer.c: Use C++ exception handling.
12446         * compile/compile-object-run.c: Use C++ exception handling.
12447         * compile/compile-object-load.c: Use C++ exception handling.
12448         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12449         * compile/compile-c-symbols.c: Use C++ exception handling.
12450         * common/selftest.c: Use C++ exception handling.
12451         * common/new-op.c: Use C++ exception handling.
12452         * cli/cli-script.c: Use C++ exception handling.
12453         * cli/cli-interp.c: Use C++ exception handling.
12454         * cli/cli-cmds.c: Use C++ exception handling.
12455         * c-varobj.c: Use C++ exception handling.
12456         * btrace.c: Use C++ exception handling.
12457         * breakpoint.c: Use C++ exception handling.
12458         * break-catch-throw.c: Use C++ exception handling.
12459         * arch-utils.c: Use C++ exception handling.
12460         * amd64-tdep.c: Use C++ exception handling.
12461         * ada-valprint.c: Use C++ exception handling.
12462         * ada-typeprint.c: Use C++ exception handling.
12463         * ada-lang.c: Use C++ exception handling.
12464         * aarch64-tdep.c: Use C++ exception handling.
12465
12466 2019-04-08  Tom Tromey  <tom@tromey.com>
12467
12468         * xml-support.c (gdb_xml_parser::parse): Update.
12469         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12470         * value.c (show_convenience): Update.
12471         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12472         (test_parse_flags_qcs): Update.
12473         * thread.c (thr_try_catch_cmd): Update.
12474         * target.c (target_translate_tls_address): Update.
12475         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12476         (info_frame_command_core, frame_apply_command_count): Update.
12477         * rust-exp.y (rust_lex_exception_test): Update.
12478         * riscv-tdep.c (riscv_print_one_register_info): Update.
12479         * remote.c (remote_target::enable_btrace): Update.
12480         * record-btrace.c (record_btrace_enable_warn): Update.
12481         * python/py-utils.c (gdbpy_convert_exception): Update.
12482         * printcmd.c (do_one_display, print_variable_and_value): Update.
12483         * mi/mi-main.c (mi_print_exception): Update.
12484         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12485         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12486         * linux-nat.c (linux_nat_target::attach): Update.
12487         * linux-fork.c (class scoped_switch_fork_info): Update.
12488         * infrun.c (displaced_step_prepare): Update.
12489         * infcall.c (call_function_by_hand_dummy): Update.
12490         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12491         * gnu-v3-abi.c (print_one_vtable): Update.
12492         * frame.c (get_prev_frame_always): Update.
12493         * f-valprint.c (info_common_command_for_block): Update.
12494         * exec.c (try_open_exec_file): Update.
12495         * exceptions.c (print_exception, exception_print)
12496         (exception_fprintf, exception_print_same): Update.
12497         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12498         * dwarf-index-cache.c (index_cache::store)
12499         (index_cache::lookup_gdb_index): Update.
12500         * darwin-nat.c (maybe_cache_shell): Update.
12501         * cp-valprint.c (cp_print_value_fields): Update.
12502         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12503         (gcc_cplus_symbol_address): Update.
12504         * compile/compile-c-symbols.c (gcc_convert_symbol)
12505         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12506         * common/selftest.c: Update.
12507         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12508         a std::string.
12509         (exception_try_scope_entry, exception_try_scope_exit): Don't
12510         declare.
12511         (struct exception_try_scope): Remove.
12512         (TRY): Don't use exception_try_scope.
12513         (struct gdb_exception): Add constructor, operator=.
12514         <what>: New method.
12515         (struct gdb_exception_RETURN_MASK_ALL)
12516         (struct gdb_exception_RETURN_MASK_ERROR)
12517         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12518         (struct gdb_quit_bad_alloc): Update.
12519         * common/common-exceptions.c (exception_none): Change
12520         initializer.
12521         (struct catcher) <state, exception>: Initialize inline.
12522         <prev>: Remove member.
12523         (current_catcher): Remove.
12524         (catchers): New global.
12525         (exceptions_state_mc_init): Simplify.
12526         (catcher_pop): Remove.
12527         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12528         (try_scope_depth, exception_try_scope_entry)
12529         (exception_try_scope_exit): Remove.
12530         (throw_exception_sjlj): Update.
12531         (exception_messages, exception_messages_size): Remove.
12532         (throw_it): Simplify.
12533         (gdb_exception_sliced_copy): Remove.
12534         (throw_exception_cxx): Update.
12535         * cli/cli-script.c (script_from_file): Update.
12536         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12537         Update.
12538         * ada-valprint.c (ada_val_print): Update.
12539         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12540         (create_excep_cond_exprs): Update.
12541
12542 2019-04-08  Tom Tromey  <tom@tromey.com>
12543
12544         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12545         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12546         (TRY, CATCH, END_CATCH): Remove some definitions.
12547         * common/common-exceptions.c: Don't use GDB_XCPT.
12548         (catcher_list_size): Remove.
12549         (throw_exception, throw_it): Simplify.
12550
12551 2019-04-05  Tom Tromey  <tom@tromey.com>
12552
12553         Revert the header-sorting patch.
12554         * ft32-tdep.c: Revert.
12555         * frv-tdep.c: Revert.
12556         * frv-linux-tdep.c: Revert.
12557         * frame.c: Revert.
12558         * frame-unwind.c: Revert.
12559         * frame-base.c: Revert.
12560         * fork-child.c: Revert.
12561         * findvar.c: Revert.
12562         * findcmd.c: Revert.
12563         * filesystem.c: Revert.
12564         * filename-seen-cache.h: Revert.
12565         * filename-seen-cache.c: Revert.
12566         * fbsd-tdep.c: Revert.
12567         * fbsd-nat.h: Revert.
12568         * fbsd-nat.c: Revert.
12569         * f-valprint.c: Revert.
12570         * f-typeprint.c: Revert.
12571         * f-lang.c: Revert.
12572         * extension.h: Revert.
12573         * extension.c: Revert.
12574         * extension-priv.h: Revert.
12575         * expprint.c: Revert.
12576         * exec.h: Revert.
12577         * exec.c: Revert.
12578         * exceptions.c: Revert.
12579         * event-top.c: Revert.
12580         * event-loop.c: Revert.
12581         * eval.c: Revert.
12582         * elfread.c: Revert.
12583         * dwarf2read.h: Revert.
12584         * dwarf2read.c: Revert.
12585         * dwarf2loc.c: Revert.
12586         * dwarf2expr.h: Revert.
12587         * dwarf2expr.c: Revert.
12588         * dwarf2-frame.c: Revert.
12589         * dwarf2-frame-tailcall.c: Revert.
12590         * dwarf-index-write.h: Revert.
12591         * dwarf-index-write.c: Revert.
12592         * dwarf-index-common.c: Revert.
12593         * dwarf-index-cache.h: Revert.
12594         * dwarf-index-cache.c: Revert.
12595         * dummy-frame.c: Revert.
12596         * dtrace-probe.c: Revert.
12597         * disasm.h: Revert.
12598         * disasm.c: Revert.
12599         * disasm-selftests.c: Revert.
12600         * dictionary.c: Revert.
12601         * dicos-tdep.c: Revert.
12602         * demangle.c: Revert.
12603         * dcache.h: Revert.
12604         * dcache.c: Revert.
12605         * darwin-nat.h: Revert.
12606         * darwin-nat.c: Revert.
12607         * darwin-nat-info.c: Revert.
12608         * d-valprint.c: Revert.
12609         * d-namespace.c: Revert.
12610         * d-lang.c: Revert.
12611         * ctf.c: Revert.
12612         * csky-tdep.c: Revert.
12613         * csky-linux-tdep.c: Revert.
12614         * cris-tdep.c: Revert.
12615         * cris-linux-tdep.c: Revert.
12616         * cp-valprint.c: Revert.
12617         * cp-support.c: Revert.
12618         * cp-namespace.c: Revert.
12619         * cp-abi.c: Revert.
12620         * corelow.c: Revert.
12621         * corefile.c: Revert.
12622         * continuations.c: Revert.
12623         * completer.h: Revert.
12624         * completer.c: Revert.
12625         * complaints.c: Revert.
12626         * coffread.c: Revert.
12627         * coff-pe-read.c: Revert.
12628         * cli-out.h: Revert.
12629         * cli-out.c: Revert.
12630         * charset.c: Revert.
12631         * c-varobj.c: Revert.
12632         * c-valprint.c: Revert.
12633         * c-typeprint.c: Revert.
12634         * c-lang.c: Revert.
12635         * buildsym.c: Revert.
12636         * buildsym-legacy.c: Revert.
12637         * build-id.h: Revert.
12638         * build-id.c: Revert.
12639         * btrace.c: Revert.
12640         * bsd-uthread.c: Revert.
12641         * breakpoint.h: Revert.
12642         * breakpoint.c: Revert.
12643         * break-catch-throw.c: Revert.
12644         * break-catch-syscall.c: Revert.
12645         * break-catch-sig.c: Revert.
12646         * blockframe.c: Revert.
12647         * block.c: Revert.
12648         * bfin-tdep.c: Revert.
12649         * bfin-linux-tdep.c: Revert.
12650         * bfd-target.c: Revert.
12651         * bcache.c: Revert.
12652         * ax-general.c: Revert.
12653         * ax-gdb.h: Revert.
12654         * ax-gdb.c: Revert.
12655         * avr-tdep.c: Revert.
12656         * auxv.c: Revert.
12657         * auto-load.c: Revert.
12658         * arm-wince-tdep.c: Revert.
12659         * arm-tdep.c: Revert.
12660         * arm-symbian-tdep.c: Revert.
12661         * arm-pikeos-tdep.c: Revert.
12662         * arm-obsd-tdep.c: Revert.
12663         * arm-nbsd-tdep.c: Revert.
12664         * arm-nbsd-nat.c: Revert.
12665         * arm-linux-tdep.c: Revert.
12666         * arm-linux-nat.c: Revert.
12667         * arm-fbsd-tdep.c: Revert.
12668         * arm-fbsd-nat.c: Revert.
12669         * arm-bsd-tdep.c: Revert.
12670         * arch-utils.c: Revert.
12671         * arc-tdep.c: Revert.
12672         * arc-newlib-tdep.c: Revert.
12673         * annotate.h: Revert.
12674         * annotate.c: Revert.
12675         * amd64-windows-tdep.c: Revert.
12676         * amd64-windows-nat.c: Revert.
12677         * amd64-tdep.c: Revert.
12678         * amd64-sol2-tdep.c: Revert.
12679         * amd64-obsd-tdep.c: Revert.
12680         * amd64-obsd-nat.c: Revert.
12681         * amd64-nbsd-tdep.c: Revert.
12682         * amd64-nbsd-nat.c: Revert.
12683         * amd64-nat.c: Revert.
12684         * amd64-linux-tdep.c: Revert.
12685         * amd64-linux-nat.c: Revert.
12686         * amd64-fbsd-tdep.c: Revert.
12687         * amd64-fbsd-nat.c: Revert.
12688         * amd64-dicos-tdep.c: Revert.
12689         * amd64-darwin-tdep.c: Revert.
12690         * amd64-bsd-nat.c: Revert.
12691         * alpha-tdep.c: Revert.
12692         * alpha-obsd-tdep.c: Revert.
12693         * alpha-nbsd-tdep.c: Revert.
12694         * alpha-mdebug-tdep.c: Revert.
12695         * alpha-linux-tdep.c: Revert.
12696         * alpha-linux-nat.c: Revert.
12697         * alpha-bsd-tdep.c: Revert.
12698         * alpha-bsd-nat.c: Revert.
12699         * aix-thread.c: Revert.
12700         * agent.c: Revert.
12701         * addrmap.c: Revert.
12702         * ada-varobj.c: Revert.
12703         * ada-valprint.c: Revert.
12704         * ada-typeprint.c: Revert.
12705         * ada-tasks.c: Revert.
12706         * ada-lang.c: Revert.
12707         * aarch64-tdep.c: Revert.
12708         * aarch64-ravenscar-thread.c: Revert.
12709         * aarch64-newlib-tdep.c: Revert.
12710         * aarch64-linux-tdep.c: Revert.
12711         * aarch64-linux-nat.c: Revert.
12712         * aarch64-fbsd-tdep.c: Revert.
12713         * aarch64-fbsd-nat.c: Revert.
12714         * aarch32-linux-nat.c: Revert.
12715
12716 2019-04-05  Tom Tromey  <tom@tromey.com>
12717
12718         * ft32-tdep.c: Sort headers.
12719         * frv-tdep.c: Sort headers.
12720         * frv-linux-tdep.c: Sort headers.
12721         * frame.c: Sort headers.
12722         * frame-unwind.c: Sort headers.
12723         * frame-base.c: Sort headers.
12724         * fork-child.c: Sort headers.
12725         * findvar.c: Sort headers.
12726         * findcmd.c: Sort headers.
12727         * filesystem.c: Sort headers.
12728         * filename-seen-cache.h: Sort headers.
12729         * filename-seen-cache.c: Sort headers.
12730         * fbsd-tdep.c: Sort headers.
12731         * fbsd-nat.h: Sort headers.
12732         * fbsd-nat.c: Sort headers.
12733         * f-valprint.c: Sort headers.
12734         * f-typeprint.c: Sort headers.
12735         * f-lang.c: Sort headers.
12736         * extension.h: Sort headers.
12737         * extension.c: Sort headers.
12738         * extension-priv.h: Sort headers.
12739         * expprint.c: Sort headers.
12740         * exec.h: Sort headers.
12741         * exec.c: Sort headers.
12742         * exceptions.c: Sort headers.
12743         * event-top.c: Sort headers.
12744         * event-loop.c: Sort headers.
12745         * eval.c: Sort headers.
12746         * elfread.c: Sort headers.
12747         * dwarf2read.h: Sort headers.
12748         * dwarf2read.c: Sort headers.
12749         * dwarf2loc.c: Sort headers.
12750         * dwarf2expr.h: Sort headers.
12751         * dwarf2expr.c: Sort headers.
12752         * dwarf2-frame.c: Sort headers.
12753         * dwarf2-frame-tailcall.c: Sort headers.
12754         * dwarf-index-write.h: Sort headers.
12755         * dwarf-index-write.c: Sort headers.
12756         * dwarf-index-common.c: Sort headers.
12757         * dwarf-index-cache.h: Sort headers.
12758         * dwarf-index-cache.c: Sort headers.
12759         * dummy-frame.c: Sort headers.
12760         * dtrace-probe.c: Sort headers.
12761         * disasm.h: Sort headers.
12762         * disasm.c: Sort headers.
12763         * disasm-selftests.c: Sort headers.
12764         * dictionary.c: Sort headers.
12765         * dicos-tdep.c: Sort headers.
12766         * demangle.c: Sort headers.
12767         * dcache.h: Sort headers.
12768         * dcache.c: Sort headers.
12769         * darwin-nat.h: Sort headers.
12770         * darwin-nat.c: Sort headers.
12771         * darwin-nat-info.c: Sort headers.
12772         * d-valprint.c: Sort headers.
12773         * d-namespace.c: Sort headers.
12774         * d-lang.c: Sort headers.
12775         * ctf.c: Sort headers.
12776         * csky-tdep.c: Sort headers.
12777         * csky-linux-tdep.c: Sort headers.
12778         * cris-tdep.c: Sort headers.
12779         * cris-linux-tdep.c: Sort headers.
12780         * cp-valprint.c: Sort headers.
12781         * cp-support.c: Sort headers.
12782         * cp-namespace.c: Sort headers.
12783         * cp-abi.c: Sort headers.
12784         * corelow.c: Sort headers.
12785         * corefile.c: Sort headers.
12786         * continuations.c: Sort headers.
12787         * completer.h: Sort headers.
12788         * completer.c: Sort headers.
12789         * complaints.c: Sort headers.
12790         * coffread.c: Sort headers.
12791         * coff-pe-read.c: Sort headers.
12792         * cli-out.h: Sort headers.
12793         * cli-out.c: Sort headers.
12794         * charset.c: Sort headers.
12795         * c-varobj.c: Sort headers.
12796         * c-valprint.c: Sort headers.
12797         * c-typeprint.c: Sort headers.
12798         * c-lang.c: Sort headers.
12799         * buildsym.c: Sort headers.
12800         * buildsym-legacy.c: Sort headers.
12801         * build-id.h: Sort headers.
12802         * build-id.c: Sort headers.
12803         * btrace.c: Sort headers.
12804         * bsd-uthread.c: Sort headers.
12805         * breakpoint.h: Sort headers.
12806         * breakpoint.c: Sort headers.
12807         * break-catch-throw.c: Sort headers.
12808         * break-catch-syscall.c: Sort headers.
12809         * break-catch-sig.c: Sort headers.
12810         * blockframe.c: Sort headers.
12811         * block.c: Sort headers.
12812         * bfin-tdep.c: Sort headers.
12813         * bfin-linux-tdep.c: Sort headers.
12814         * bfd-target.c: Sort headers.
12815         * bcache.c: Sort headers.
12816         * ax-general.c: Sort headers.
12817         * ax-gdb.h: Sort headers.
12818         * ax-gdb.c: Sort headers.
12819         * avr-tdep.c: Sort headers.
12820         * auxv.c: Sort headers.
12821         * auto-load.c: Sort headers.
12822         * arm-wince-tdep.c: Sort headers.
12823         * arm-tdep.c: Sort headers.
12824         * arm-symbian-tdep.c: Sort headers.
12825         * arm-pikeos-tdep.c: Sort headers.
12826         * arm-obsd-tdep.c: Sort headers.
12827         * arm-nbsd-tdep.c: Sort headers.
12828         * arm-nbsd-nat.c: Sort headers.
12829         * arm-linux-tdep.c: Sort headers.
12830         * arm-linux-nat.c: Sort headers.
12831         * arm-fbsd-tdep.c: Sort headers.
12832         * arm-fbsd-nat.c: Sort headers.
12833         * arm-bsd-tdep.c: Sort headers.
12834         * arch-utils.c: Sort headers.
12835         * arc-tdep.c: Sort headers.
12836         * arc-newlib-tdep.c: Sort headers.
12837         * annotate.h: Sort headers.
12838         * annotate.c: Sort headers.
12839         * amd64-windows-tdep.c: Sort headers.
12840         * amd64-windows-nat.c: Sort headers.
12841         * amd64-tdep.c: Sort headers.
12842         * amd64-sol2-tdep.c: Sort headers.
12843         * amd64-obsd-tdep.c: Sort headers.
12844         * amd64-obsd-nat.c: Sort headers.
12845         * amd64-nbsd-tdep.c: Sort headers.
12846         * amd64-nbsd-nat.c: Sort headers.
12847         * amd64-nat.c: Sort headers.
12848         * amd64-linux-tdep.c: Sort headers.
12849         * amd64-linux-nat.c: Sort headers.
12850         * amd64-fbsd-tdep.c: Sort headers.
12851         * amd64-fbsd-nat.c: Sort headers.
12852         * amd64-dicos-tdep.c: Sort headers.
12853         * amd64-darwin-tdep.c: Sort headers.
12854         * amd64-bsd-nat.c: Sort headers.
12855         * alpha-tdep.c: Sort headers.
12856         * alpha-obsd-tdep.c: Sort headers.
12857         * alpha-nbsd-tdep.c: Sort headers.
12858         * alpha-mdebug-tdep.c: Sort headers.
12859         * alpha-linux-tdep.c: Sort headers.
12860         * alpha-linux-nat.c: Sort headers.
12861         * alpha-bsd-tdep.c: Sort headers.
12862         * alpha-bsd-nat.c: Sort headers.
12863         * aix-thread.c: Sort headers.
12864         * agent.c: Sort headers.
12865         * addrmap.c: Sort headers.
12866         * ada-varobj.c: Sort headers.
12867         * ada-valprint.c: Sort headers.
12868         * ada-typeprint.c: Sort headers.
12869         * ada-tasks.c: Sort headers.
12870         * ada-lang.c: Sort headers.
12871         * aarch64-tdep.c: Sort headers.
12872         * aarch64-ravenscar-thread.c: Sort headers.
12873         * aarch64-newlib-tdep.c: Sort headers.
12874         * aarch64-linux-tdep.c: Sort headers.
12875         * aarch64-linux-nat.c: Sort headers.
12876         * aarch64-fbsd-tdep.c: Sort headers.
12877         * aarch64-fbsd-nat.c: Sort headers.
12878         * aarch32-linux-nat.c: Sort headers.
12879
12880 2019-04-04  Tom Tromey  <tom@tromey.com>
12881
12882         * varobj.c (varobj_create): Update.
12883         * rust-exp.y (struct rust_parser) <update_innermost_block,
12884         lookup_symbol>: New methods.
12885         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12886         Rename.
12887         (rust_parser::rust_lookup_type)
12888         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12889         * printcmd.c (display_command, do_one_display): Update.
12890         * parser-defs.h (struct parser_state) <parser_state>: Add
12891         "tracker" parameter.
12892         (block_tracker): New member.
12893         (class innermost_block_tracker) <innermost_block_tracker>: Add
12894         "types" parameter.
12895         <reset>: Remove method.
12896         (innermost_block): Don't declare.
12897         (null_post_parser): Update.
12898         * parse.c (innermost_block): Remove global.
12899         (write_dollar_variable): Update.
12900         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12901         Remove "tracker_types" parameter.
12902         (parse_expression): Add "tracker" parameter.
12903         (parse_expression_for_completion): Update.
12904         (null_post_parser): Add "tracker" parameter.
12905         * p-exp.y: Update rules.
12906         * m2-exp.y: Update rules.
12907         * language.h (struct language_defn) <la_post_parser>: Add
12908         "tracker" parameter.
12909         * go-exp.y: Update rules.
12910         * f-exp.y: Update rules.
12911         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12912         parameter.
12913         * d-exp.y: Update rules.
12914         * c-exp.y: Update rules.
12915         * breakpoint.c (set_breakpoint_condition): Create an
12916         innermost_block_tracker.
12917         (watch_command_1): Likewise.
12918         * ada-lang.c (resolve): Add "tracker" parameter.
12919         (resolve_subexp): Likewise.
12920         * ada-exp.y (write_var_from_sym): Update.
12921
12922 2019-04-04  Tom Tromey  <tom@tromey.com>
12923
12924         * type-stack.h: New file.
12925         * type-stack.c: New file.
12926         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12927         type-stack.h.
12928         (insert_into_type_stack, insert_type, push_type, push_type_int)
12929         (insert_type_address_space, pop_type, pop_type_int)
12930         (pop_typelist, pop_type_stack, append_type_stack)
12931         (push_type_stack, get_type_stack, push_typelist)
12932         (follow_type_instance_flags, follow_types): Don't declare.
12933         * parse.c (type_stack): Remove global.
12934         (parse_exp_in_context): Update.
12935         (insert_into_type_stack, insert_type, push_type, push_type_int)
12936         (insert_type_address_space, pop_type, pop_type_int)
12937         (pop_typelist, pop_type_stack, append_type_stack)
12938         (push_type_stack, get_type_stack, push_typelist)
12939         (follow_type_instance_flags, follow_types): Remove (moved to
12940         type-stack.c).
12941         * f-exp.y (type_stack): New global.
12942         Update rules.
12943         (push_kind_type, f_parse): Update.
12944         * d-exp.y (type_stack): New global.
12945         Update rules.
12946         (d_parse): Update.
12947         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12948         Update rules.
12949         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12950         (HFILES_NO_SRCDIR): Add type-stack.h.
12951
12952 2019-04-04  Tom Tromey  <tom@tromey.com>
12953
12954         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12955         (rust_parser::convert_ast_to_expression, rust_parse)
12956         (rust_lex_test_completion, rust_lex_tests): Update.
12957         * parser-defs.h (struct expr_completion_state): New.
12958         (struct parser_state) <parser_state>: Add completion parameter.
12959         <mark_struct_expression, mark_completion_tag>: New methods.
12960         <parse_completion, m_completion_state>: New members.
12961         (prefixify_expression, null_post_parser): Update.
12962         (mark_struct_expression, mark_completion_tag): Don't declare.
12963         * parse.c (parse_completion, expout_last_struct)
12964         (expout_tag_completion_type, expout_completion_name): Remove
12965         globals.
12966         (parser_state::mark_struct_expression)
12967         (parser_state::mark_completion_tag): Now methods.
12968         (prefixify_expression): Add last_struct parameter.
12969         (prefixify_subexp): Likewise.
12970         (parse_exp_1): Update.
12971         (parse_exp_in_context): Add cstate parameter.  Update.
12972         (parse_expression_for_completion): Create an
12973         expr_completion_state.
12974         (null_post_parser): Add "completion" parameter.
12975         * p-exp.y: Update rules.
12976         (yylex): Update.
12977         * language.h (struct language_defn) <la_post_parser>: Add
12978         "completing" parameter.
12979         * go-exp.y: Update rules.
12980         (lex_one_token): Update.
12981         * expression.h (parse_completion): Don't declare.
12982         * d-exp.y: Update rules.
12983         (lex_one_token): Update rules.
12984         * c-exp.y: Update rules.
12985         (lex_one_token): Update.
12986         * ada-lang.c (resolve): Add "parse_completion" parameter.
12987         (resolve_subexp): Likewise.
12988         (ada_resolve_function): Likewise.
12989
12990 2019-04-04  Tom Tromey  <tom@tromey.com>
12991
12992         * parser-defs.h (struct parser_state) <start_arglist,
12993         end_arglist>: New methods.
12994         <arglist_len, m_funcall_chain>: New members.
12995         (arglist_len, start_arglist, end_arglist): Don't declare.
12996         * parse.c (arglist_len, funcall_chain): Remove global.
12997         (start_arglist, end_arglist): Remove functions.
12998         (parse_exp_in_context): Update.
12999         * p-exp.y: Update rules.
13000         * m2-exp.y: Update rules.
13001         * go-exp.y: Update rules.
13002         * f-exp.y: Update rules.
13003         * d-exp.y: Update rules.
13004         * c-exp.y: Update rules.
13005
13006 2019-04-04  Tom Tromey  <tom@tromey.com>
13007
13008         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
13009         lex_operator, push_back>: New methods.
13010         Update all rules.
13011         (rust_parser::lex_hex, lex_escape): Rename and update.
13012         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13013         (rust_parser::lex_operator): Rename and update.
13014         (rust_parser::lex_number, rustyylex, rustyyerror)
13015         (rust_lex_test_init, rust_lex_test_sequence)
13016         (rust_lex_test_push_back, rust_lex_tests): Update.
13017         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13018         parameter.
13019         <lexptr, prev_lexptr>: New members.
13020         (lexptr, prev_lexptr): Don't declare.
13021         * parse.c (lexptr, prev_lexptr): Remove globals.
13022         (parse_exp_in_context): Update.
13023         * p-exp.y (yylex, yyerror): Update.
13024         * m2-exp.y (parse_number, yylex, yyerror): Update.
13025         * go-exp.y (lex_one_token, yyerror): Update.
13026         * f-exp.y (match_string_literal, yylex, yyerror): Update.
13027         * d-exp.y (lex_one_token, yyerror): Update.
13028         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13029         (lex_one_token, yyerror): Update.
13030         * ada-lex.l (YY_INPUT): Update.
13031         (rewind_to_char): Update.
13032         * ada-exp.y (yyerror): Update.
13033
13034 2019-04-04  Tom Tromey  <tom@tromey.com>
13035
13036         * rust-exp.y (rustyylex, rust_lex_tests): Update.
13037         * parser-defs.h (struct parser_state) <parser_state>: Add new
13038         parameter.
13039         <comma_terminates>: New member.
13040         (comma_terminates): Don't declare global.
13041         * parse.c (comma_terminates): Remove global.
13042         (parse_exp_in_context): Update.
13043         * p-exp.y (yylex): Update.
13044         * m2-exp.y (yylex): Update.
13045         * go-exp.y (lex_one_token): Update.
13046         * f-exp.y (yylex): Update.
13047         * d-exp.y (lex_one_token): Update.
13048         * c-exp.y (lex_one_token): Update.
13049         * ada-lex.l: Update.
13050
13051 2019-04-04  Tom Tromey  <tom@tromey.com>
13052
13053         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13054         (rustyylex, rust_lex_test_init, rust_lex_test_one)
13055         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13056         * parser-defs.h (paren_depth): Don't declare.
13057         * parse.c (paren_depth): Remove global.
13058         (parse_exp_in_context): Update.
13059         * p-exp.y (paren_depth): New global.
13060         (pascal_parse): Initialize it.
13061         * m2-exp.y (paren_depth): New global.
13062         (m2_parse): Initialize it.
13063         * go-exp.y (paren_depth): New global.
13064         (go_parse): Initialize it.
13065         * f-exp.y (paren_depth): New global.
13066         (f_parse): Initialize it.
13067         * d-exp.y (paren_depth): New global.
13068         (d_parse): Initialize it.
13069         * c-exp.y (paren_depth): New global.
13070         (c_parse): Initialize it.
13071         * ada-lex.l (paren_depth): New global.
13072         (lexer_init): Initialize it.
13073
13074 2019-04-04  Tom Tromey  <tom@tromey.com>
13075
13076         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13077         (rust_parser::convert_ast_to_type)
13078         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13079         * parser-defs.h (struct parser_state) <parser_state>: Add
13080         parameters.  Initialize new members.
13081         <expression_context_block, expression_context_pc>: New members.
13082         * parse.c (expression_context_block, expression_context_pc):
13083         Remove globals.
13084         (parse_exp_in_context): Update.
13085         * p-exp.y: Update all rules.
13086         (yylex): Update.
13087         * m2-exp.y: Update all rules.
13088         (yylex): Update.
13089         * go-exp.y (yylex): Update.
13090         * f-exp.y (yylex): Update.
13091         * d-exp.y: Update all rules.
13092         (yylex): Update.
13093         * c-exp.y: Update all rules.
13094         (lex_one_token, classify_name, yylex, c_parse): Update.
13095         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13096
13097 2019-04-04  Tom Tromey  <tom@tromey.com>
13098
13099         * gdbarch.h, gdbarch.c: Rebuild.
13100         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13101         * stap-probe.h:
13102         (struct stap_parse_info): Replace "parser_state" with
13103         "expr_builder".
13104         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13105         (parser_state): New class.
13106         * parse.c (expr_builder): Rename.
13107         (expr_builder::release): Rename.
13108         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13109         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13110         (write_exp_elt_longcst, write_exp_elt_floatcst)
13111         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13112         (write_exp_string_vector, write_exp_bitstring)
13113         (write_exp_msymbol, mark_struct_expression)
13114         (write_dollar_variable)
13115         (insert_type_address_space, increase_expout_size): Replace
13116         "parser_state" with "expr_builder".
13117         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13118         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13119         "parser_state" with "expr_builder".
13120
13121 2019-04-04  Tom Tromey  <tom@tromey.com>
13122
13123         * rust-exp.y: Replace "parse_language" with method call.
13124         * p-exp.y:
13125         (yylex): Replace "parse_language" with method call.
13126         * m2-exp.y:
13127         (yylex): Replace "parse_language" with method call.
13128         * go-exp.y (classify_name): Replace "parse_language" with method
13129         call.
13130         * f-exp.y (yylex): Replace "parse_language" with method call.
13131         * d-exp.y (lex_one_token): Replace "parse_language" with method
13132         call.
13133         * c-exp.y:
13134         (lex_one_token, classify_name, yylex): Replace "parse_language"
13135         with method call.
13136         * ada-exp.y (find_primitive_type, type_char)
13137         (type_system_address): Replace "parse_language" with method call.
13138
13139 2019-04-04  Tom Tromey  <tom@tromey.com>
13140
13141         * rust-exp.y: Replace "parse_gdbarch" with method call.
13142         * parse.c (write_dollar_variable, insert_type_address_space):
13143         Replace "parse_gdbarch" with method call.
13144         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13145         call.
13146         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13147         call.
13148         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13149         "parse_gdbarch" with method call.
13150         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13151         with method call.
13152         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13153         "parse_gdbarch" with method call.
13154         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13155         "parse_gdbarch" with method call.
13156         * c-exp.y (parse_type, parse_number, classify_name): Replace
13157         "parse_gdbarch" with method call.
13158         * ada-lex.l: Replace "parse_gdbarch" with method call.
13159         * ada-exp.y (parse_type, find_primitive_type, type_char)
13160         (type_system_address): Replace "parse_gdbarch" with method call.
13161
13162 2019-04-04  Tom Tromey  <tom@tromey.com>
13163
13164         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13165         * stap-probe.c (stap_parse_argument): Update.
13166         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13167         initial_size parameter.
13168         * rust-exp.y (rust_lex_tests): Update.
13169         * parse.c (parser_state): Update.
13170         (parse_exp_in_context): Update.
13171         * parser-defs.h (struct parser_state) <parser_state>: Remove
13172         "initial_size" parameter.
13173
13174 2019-04-04  Tom Tromey  <tom@tromey.com>
13175
13176         * parser-defs.h (increase_expout_size): Don't declare.
13177         * parse.c (increase_expout_size): Now static.
13178
13179 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13180
13181         * gnu-nat.c (gnu_nat_target::wait): Fix
13182         target_waitstatus_to_string call.
13183
13184 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13185
13186         * eval.c (evaluate_subexp_standard): Handle internal functions
13187         during Fortran function call handling.
13188
13189 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13190
13191         * NEWS: Mention new internal functions.
13192         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13193         (read_base_type): Use dwarf2_init_complex_target_type.
13194         * value.c (creal_internal_fn): New function.
13195         (cimag_internal_fn): New function.
13196         (_initialize_values): Register new internal functions.
13197
13198 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13199
13200         * infrun.c (stop_all_threads): If debug_infrun, always
13201         trace the wait status after wait_one, using
13202         target_waitstatus_to_string and target_pid_to_str.
13203         (handle_inferior_event): Replace various trace of
13204         wait status kind by a single trace.
13205         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13206         wait status kind image by target_waitstatus_to_string.
13207         * target/waitstatus.c (target_waitstatus_to_string): Fix
13208         obsolete comment.
13209
13210 2019-04-01  Tom Tromey  <tromey@adacore.com>
13211
13212         PR symtab/23331:
13213         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13214
13215 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13216             Pedro Alves  <palves@redhat.com>
13217
13218         * top.c (quit_force): Call 'finalize_values'.
13219         * value.c (finalize_values): New function.
13220         * value.h (finalize_values): Declare.
13221
13222 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13223
13224         * NEWS: Announce $_gdb_major and $_gdb_minor.
13225
13226         * top.c (init_gdb_version_vars): New function.
13227         (gdb_init): Call init_gdb_version_vars.
13228
13229 2019-03-29  Tom Tromey  <tromey@adacore.com>
13230
13231         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13232         help text.  Remove dead code.
13233
13234 2019-03-29  Keith Seitz  <keiths@redhat.com>
13235
13236         From Siddhesh Poyarekar:
13237         * f-lang.h (f77_get_upperbound): Return LONGEST.
13238         (f77_get_lowerbound): Likewise.
13239         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13240         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13241         print them.
13242         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13243         plongest to format print it.
13244         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13245         (f77_get_upperbound): Likewise.
13246         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13247         LOWER_BOUND to LONGEST.
13248         (f77_create_arrayprint_offset_tbl): Likewise.
13249
13250 2019-03-29  Keith Seitz  <keiths@redhat.com>
13251
13252         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13253         %s/pulongest for TYPE_LENGTH instead of %d in format
13254         strings.
13255         * ada-typerint.c (ada_print_type): Likewise.
13256         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13257         * compile/compile-c-support.c (generate_register_struct): Likewise.
13258         * gdbtypes.c (recursive_dump_type): Likewise.
13259         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13260         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13261         instead of %d in format strings.
13262         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13263         to std::min to ULONGEST.
13264         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13265         instead of %d in format strings.
13266         * tracepoint.c (info_scope_command): Likewise.
13267         * typeprint.c (print_offset_data::update)
13268         (print_offset_data::finish): Likewise.
13269         * xtensa-tdep.c (xtensa_store_return_value)
13270         (xtensa_push_dummy_call): Likewise.
13271
13272 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13273
13274         * windows-nat.c (display_selector): Fixed format specifications
13275         for 64-bit Cygwin.
13276
13277 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13278
13279         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13280
13281 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13282
13283         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13284         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13285         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13286         (nios2_linux_init_abi): Install it.
13287
13288 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13289
13290         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13291
13292 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13293
13294         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13295
13296 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13297             Tom Tromey  <tromey@adacore.com>
13298
13299         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13300
13301 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13302
13303         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13304         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13305         method to compute the bounds of range types. Also print "[evaluated]"
13306         if the bounds' values come from a dynamic evaluation.
13307
13308 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13309
13310         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13311         whitespace when pretty printing is on.
13312
13313 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13314
13315         * ppc-linux-nat.c: Add include.
13316
13317 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13318
13319         * NEWS: Mention AArch64 Pointer Authentication.
13320
13321 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13322
13323         * arm-linux-nat.c: Add include.
13324
13325 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13326
13327         * source-cache.c (source_cache::get_source_lines): Re-read
13328         fullname after calling open_source_file.
13329
13330 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13331
13332         * NEWS: Mention TLS support for FreeBSD.
13333
13334 2019-03-25  Tom Tromey  <tromey@adacore.com>
13335
13336         * minsyms.c (BUNCH_SIZE): Update comment.
13337         (~minimal_symbol_reader): Remove old comment.
13338         (compact_minimal_symbols): Update comment.
13339         (minimal_symbol_reader::install): Remove old comment.  Update
13340         other comments.
13341
13342 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13343
13344         * s390-linux-nat.c: Add include.
13345
13346 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13347
13348         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13349         Call linux_get_hwcap.
13350         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13351         Likewise.
13352         (aarch64_linux_get_hwcap): Remove function.
13353         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13354         declaration.
13355         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13356         linux_get_hwcap.
13357         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13358         * linux-tdep.c (linux_get_hwcap): Add function.
13359         (linux_get_hwcap2): Likewise.
13360         * linux-tdep.h (linux_get_hwcap): Add declaration.
13361         (linux_get_hwcap2): Likewise.
13362         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13363         (ppc_linux_get_hwcap2): Likewise.
13364         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13365         linux_get_hwcap.
13366         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13367         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13368         (ppc_linux_nat_target::read_description): Likewise.
13369         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13370         * s390-linux-nat.c: Likewise.
13371         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13372
13373 2019-03-24  Tom Tromey  <tom@tromey.com>
13374
13375         * ada-lang.c (standard_lookup): Simplify initialization.
13376         (ada_lookup_symbol_nonlocal): Simplify return.
13377         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13378         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13379         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13380         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13381         initialization.
13382         * solib.c (solib_global_lookup): Simplify.
13383         * symtab.c (null_block_symbol): Remove.
13384         (symbol_cache_lookup): Simplify returns.
13385         (lookup_language_this): Simplify returns.
13386         (lookup_symbol_aux): Simplify return.
13387         (lookup_local_symbol): Simplify returns.
13388         (lookup_global_symbol_from_objfile): Simplify return.
13389         (lookup_symbol_in_objfile_symtabs)
13390         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13391         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13392         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13393         * cp-namespace.c (cp_lookup_bare_symbol)
13394         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13395         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13396         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13397         (cp_lookup_symbol_via_imports): Simplify initialization.
13398         (find_symbol_in_baseclass): Likewise.
13399         * symtab.h (null_block_symbol): Remove.
13400         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13401         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13402         (d_lookup_symbol_module): Likewise.
13403         (find_symbol_in_baseclass): Simplify initialization.
13404
13405 2019-03-24  Tom Tromey  <tom@tromey.com>
13406
13407         * expression.h: Don't include symtab.h.
13408         (struct block): Forward declare.
13409
13410 2019-03-24  Tom Tromey  <tom@tromey.com>
13411
13412         * c-exp.y (typebase): Remove casts.
13413         * gdbtypes.c (lookup_unsigned_typename, )
13414         (lookup_signed_typename): Remove cast.
13415         * eval.c (parse_to_comma_and_eval): Remove cast.
13416         * parse.c (write_dollar_variable): Remove cast.
13417         * block.h (struct block) <superblock>: Now const.
13418         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13419         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13420         (map_block): Make "block" const.
13421         * symfile.h (struct quick_symbol_functions)
13422         <map_matching_symbols>: Constify block argument to "callback".
13423         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13424         const.
13425         (find_pc_sect_compunit_symtab): Make "b" const.
13426         (find_symbol_at_address): Likewise.
13427         (search_symbols): Likewise.
13428         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13429         (dw2_debug_names_lookup_symbol): Likewise.
13430         (dw2_map_matching_symbols): Update.
13431         * p-valprint.c (pascal_val_print): Remove "block".
13432         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13433         (aux_add_nonlocal_symbols): Make "block" const.
13434         (resolve_subexp): Remove cast.
13435         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13436         const.
13437         (iterate_over_file_blocks): Likewise.
13438         * f-exp.y (%union) <bval>: Remove.
13439         * coffread.c (patch_opaque_types): Make "b" const.
13440         * spu-tdep.c (spu_catch_start): Make "block" const.
13441         * c-valprint.c (print_unpacked_pointer): Remove "block".
13442         * symmisc.c (dump_symtab_1): Make "b" const.
13443         (block_depth): Make "block" const.
13444         * d-exp.y (%union) <bval>: Remove.
13445         * cp-support.h (cp_lookup_rtti_type): Update.
13446         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13447         * psymtab.c (psym_lookup_symbol): Make "block" const.
13448         (maintenance_check_psymtabs): Make "b" const.
13449         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13450         (enumerate_locals, enumerate_args): Update.
13451         * python/py-symtab.c (stpy_global_block): Make "block" const.
13452         (stpy_static_block): Likewise.
13453         * inline-frame.c (block_starting_point_at): Make "new_block"
13454         const.
13455         * block.c (find_block_in_blockvector): Make return type const.
13456         (blockvector_for_pc_sect): Make "b" const.
13457         (find_block_in_blockvector): Make "b" const.
13458
13459 2019-03-23  Tom Tromey  <tom@tromey.com>
13460
13461         * varobj.c (varobj_create): Update.
13462         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13463         * printcmd.c (display_command, do_one_display): Don't reset
13464         innermost_block.
13465         * parser-defs.h (enum innermost_block_tracker_type): Move to
13466         expression.h.
13467         (innermost_block): Update comment.
13468         * parse.c (parse_exp_1): Add tracker_types parameter.
13469         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13470         tracker_types parameter.  Reset innermost_block.
13471         (parse_exp_in_context): Remove.
13472         (parse_expression_for_completion): Update.
13473         * objfiles.c (~objfile): Don't reset expression_context_block or
13474         innermost_block.
13475         * expression.h (enum innermost_block_tracker_type): Move from
13476         parser-defs.h.
13477         (parse_exp_1): Add tracker_types parameter.
13478         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13479         reset innermost_block.
13480
13481 2019-03-23  Tom Tromey  <tom@tromey.com>
13482
13483         * objfiles.h: Include bcache.h.
13484
13485 2019-03-23  Tom Tromey  <tom@tromey.com>
13486
13487         * linespec.c (get_current_search_block): Use
13488         scoped_restore_current_language.
13489         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13490
13491 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13492             Jiong Wang  <jiong.wang@arm.com>
13493
13494         * aarch64-linux-tdep.c
13495         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13496         section.
13497         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13498
13499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13500             Jiong Wang  <jiong.wang@arm.com>
13501
13502         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13503         instructions.
13504         (aarch64_analyze_prologue_test): Add PACIASP test.
13505         (aarch64_prologue_prev_register): Unmask PC value.
13506
13507 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13508             Jiong Wang  <jiong.wang@arm.com>
13509
13510         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13511         (aarch64_dwarf2_prev_register): Unmask PC value.
13512         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13513         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13514         DW_CFA_AARCH64_negate_ra_state.
13515         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13516
13517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13518             Jiong Wang  <jiong.wang@arm.com>
13519
13520         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13521         registers.
13522         (aarch64_pseudo_register_name): Likewise.
13523         (aarch64_pseudo_register_type): Likewise.
13524         (aarch64_pseudo_register_reggroup_p): Likewise.
13525         (aarch64_gdbarch_init): Add pauth registers.
13526         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13527         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13528         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13529         (struct gdbarch_tdep): Add regnum for ra_state.
13530
13531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13532             Jiong Wang  <jiong.wang@arm.com>
13533
13534         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13535
13536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13537             Jiong Wang  <jiong.wang@arm.com>
13538
13539         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13540         function.
13541         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13542         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13543         (aarch64_gdbarch_init): Add puth registers.
13544         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13545         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13546         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13547
13548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13549             Jiong Wang  <jiong.wang@arm.com>
13550
13551         * aarch64-linux-nat.c
13552         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13553         * aarch64-linux-tdep.c
13554         (aarch64_linux_core_read_description): Likewise.
13555         (aarch64_linux_get_hwcap): New function.
13556         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13557         (aarch64_linux_get_hwcap): New declaration.
13558
13559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13560             Jiong Wang  <jiong.wang@arm.com>
13561
13562         * aarch64-linux-nat.c
13563         (aarch64_linux_nat_target::read_description): Add pauth param.
13564         * aarch64-linux-tdep.c
13565         (aarch64_linux_core_read_description): Likewise.
13566         * aarch64-tdep.c (struct target_desc): Add in pauth.
13567         (aarch64_read_description): Add pauth param.
13568         (aarch64_gdbarch_init): Likewise.
13569         * aarch64-tdep.h (aarch64_read_description): Likewise.
13570         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13571         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13572         * features/Makefile: Add new files.
13573         * features/aarch64-pauth.c: New file.
13574         * features/aarch64-pauth.xml: New file.
13575
13576 2019-03-20  Tom Tromey  <tromey@adacore.com>
13577
13578         * infrun.c (handle_inferior_event): Rename from
13579         handle_inferior_event_1.  Create a scoped_value_mark.
13580         (handle_inferior_event): Remove.
13581
13582 2019-03-19  Tom Tromey  <tromey@adacore.com>
13583
13584         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13585         * infrun.h (print_stop_event): Add "displays" parameter.
13586         * infrun.c (print_stop_event): Add "displays" parameter.
13587
13588 2019-03-19  Pedro Alves  <palves@redhat.com>
13589
13590         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13591         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13592         to -1.  Fix TABs vs spaces.
13593         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13594         * tui/tui-out.h (tui_ui_out) Add intro comments.
13595         <m_line, m_start_of_line>: In-class initialize, and add describing
13596         comment.
13597
13598 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13599
13600         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13601         variable names.
13602         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13603
13604 2019-03-18  Pedro Alves  <palves@redhat.com>
13605             Eli Zaretskii <eliz@gnu.org>
13606
13607         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13608         m_line and m_start_of_line.
13609
13610 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13611
13612         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13613         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13614         it returns a newline.  This fixes a regression in TU mode, whereby
13615         the next line is output on the same screen line as the user input.
13616
13617 2019-03-18  Tom Tromey  <tromey@adacore.com>
13618
13619         * minsyms.c (minimal_symbol_reader::install): Remove call to
13620         obstack_blank.
13621
13622 2019-03-18  Pedro Alves  <palves@redhat.com>
13623
13624         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13625         New globals.
13626         (apply_style): New, factored out from ...
13627         (apply_ansi_escape): ... this.  Handle reverse video mode.
13628         (tui_set_reverse_mode): New function.
13629         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13630         * tui/tui-winsource.c (tui_show_source_line): Use
13631         tui_set_reverse_mode instead of setting A_STANDOUT.
13632         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13633         New setter methods.
13634
13635 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13636
13637         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13638         Handle tabs.
13639
13640 2019-03-18  Tom Tromey  <tromey@adacore.com>
13641
13642         * ada-lang.c (empty_array): Add "high" parameter.
13643         (ada_evaluate_subexp): Update.
13644
13645 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13646
13647         * unittests/string_view-selftests.c: Define
13648         _initialize_string_view_selftests unconditionally.
13649
13650 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13651
13652         PR gdb/24350
13653         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13654
13655 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13656
13657         PR gdb/24351
13658         * windows-nat.c (display_selector): Fix format specifiers.
13659
13660 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13661
13662         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13663         tui_refill_source_window instead of tui_refresh_win, to update the
13664         current execution line.  This fixes redisplay of the current line
13665         when stepping through the code with "next" or "step".
13666
13667 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13668
13669         * source-cache.c (source_cache::get_source_lines): Call
13670         find_source_lines to initialize s->nlines.  This fixes vertical
13671         scrolling of TUI source window when the DOWN arrow is pressed.
13672
13673 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13674
13675         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13676         linux-thread-db.c (_initialize_thread_db): Likewise.
13677
13678 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13679
13680         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13681         wclrtoeol in tui_show_source_line".  This reverts changes made in
13682         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13683
13684 2019-03-15  Tom Tromey  <tom@tromey.com>
13685
13686         * symtab.h (struct minimal_symbol): Derive from
13687         general_symbol_info.
13688         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13689         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13690         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13691         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13692         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13693         (MSYMBOL_SEARCH_NAME): Update.
13694         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13695         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13696         * minsyms.c (minimal_symbol_reader::record_full): Update.
13697
13698 2019-03-15  Tom Tromey  <tom@tromey.com>
13699
13700         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13701
13702 2019-03-15  Tom Tromey  <tom@tromey.com>
13703
13704         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13705         unique_xmalloc_ptr.
13706         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13707         Update.
13708         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13709         (build_minimal_symbol_hash_tables)
13710         (minimal_symbol_reader::install): Update.
13711
13712 2019-03-15  Tom Tromey  <tom@tromey.com>
13713
13714         * symtab.c (create_demangled_names_hash): Update.
13715         (symbol_set_names): Update.
13716         * objfiles.h (struct objfile_per_bfd_storage)
13717         <demangled_names_hash>: Now an htab_up.
13718         * objfiles.c (objfile_per_bfd_storage): Simplify.
13719
13720 2019-03-15  Tom Tromey  <tom@tromey.com>
13721
13722         * objfiles.h (struct objfile_per_bfd_storage): Declare
13723         destructor.
13724         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13725         New.
13726         (get_objfile_bfd_data): Use new.  Don't initialize
13727         language_of_main.
13728         (free_objfile_per_bfd_storage): Remove.
13729         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13730
13731 2019-03-15  Tom Tromey  <tom@tromey.com>
13732
13733         * symfile.c (reread_symbols): Update.
13734         * objfiles.c (objfile::objfile): Update.
13735         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13736         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13737         comment.
13738         (minimal_symbol_reader::install): Update.
13739         (terminate_minimal_symbol_table): Remove.
13740         * jit.c (jit_object_close_impl): Update.
13741
13742 2019-03-15  Tom Tromey  <tom@tromey.com>
13743
13744         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13745         initializations.
13746
13747 2019-03-15  Tom Tromey  <tom@tromey.com>
13748
13749         * objfiles.h (struct objfile_per_bfd_storage)
13750         <demangled_hash_languages>: Now a bitset.
13751         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13752         (lookup_minimal_symbol): Update.
13753
13754 2019-03-15  Tom Tromey  <tom@tromey.com>
13755
13756         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13757         Don't return the symbol.
13758         * coffread.c (record_minimal_symbol): Use record_full.
13759
13760 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13761
13762         The MS-Windows port of ncurses fails to switch to a color pair if
13763         one or both of the colors are the implicit default colors.  This
13764         change records the default colors when TUI is initialized, and
13765         then specifies them explicitly when a color pair uses the default
13766         colors.  This allows color styling in TUI mode on MS-Windows.
13767
13768         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13769         ncurses_norm_attr.
13770         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13771         colors in ncurses_norm_attr.
13772         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13773         "none", replace it with the default color recorded in
13774         ncurses_norm_attr.
13775
13776 2019-03-14  Tom Tromey  <tromey@adacore.com>
13777
13778         * source-cache.h (class source_cache) <get_source_lines>: Return
13779         std::string.
13780         * source-cache.c (source_cache::extract_lines): Handle case where
13781         first_pos==npos.  Return std::string.
13782         (source_cache::get_source_lines): Update.
13783
13784 2019-03-14  Tom Tromey  <tromey@adacore.com>
13785
13786         * NEWS: Add item for "style sources" commands.
13787         * source-cache.c (source_cache::get_source_lines): Check
13788         source_styling.
13789         * cli/cli-style.c (source_styling): New global.
13790         (_initialize_cli_style): Add "style sources" commands.
13791         (show_style_sources): New function.
13792         * cli/cli-style.h (source_styling): Declare.
13793
13794 2019-03-14  Pedro Alves  <palves@redhat.com>
13795             Tom Tromey  <tromey@adacore.com>
13796
13797         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13798         * tui/tui-winsource.c (tui_refill_source_window): New function,
13799         from...
13800         (tui_horizontal_source_scroll): ... here.  Move some logic.
13801         * cli/cli-style.c (set_style_enabled): Notify new observable.
13802         * tui/tui-hooks.c (tui_redisplay_source): New function.
13803         (tui_attach_detach_observers): Attach or detach
13804         tui_redisplay_source.
13805         * observable.h (source_styling_changed): New observable.
13806         * observable.c: Define source_styling_changed observable.
13807
13808 2019-03-13  Tom Tromey  <tromey@adacore.com>
13809
13810         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13811         (i386_gnu_nat_target::store_registers): Update.
13812         * target-debug.h (target_debug_print_std_string): New macro.
13813         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13814         * windows-tdep.c (display_one_tib): Update.
13815         * tui/tui-stack.c (tui_make_status_line): Update.
13816         * top.c (print_inferior_quit_action): Update.
13817         * thread.c (thr_try_catch_cmd): Update.
13818         (add_thread_with_info): Update.
13819         (thread_target_id_str): Update.
13820         (thr_try_catch_cmd): Update.
13821         (thread_command): Update.
13822         (thread_find_command): Update.
13823         * record-btrace.c (record_btrace_target::info_record)
13824         (record_btrace_resume_thread, record_btrace_target::resume)
13825         (record_btrace_cancel_resume, record_btrace_step_thread)
13826         (record_btrace_target::wait, record_btrace_target::wait)
13827         (record_btrace_target::wait, record_btrace_target::stop): Update.
13828         * progspace.c (print_program_space): Update.
13829         * process-stratum-target.c
13830         (process_stratum_target::thread_address_space): Update.
13831         * linux-fork.c (linux_fork_mourn_inferior)
13832         (detach_checkpoint_command, info_checkpoints_command)
13833         (linux_fork_context): Update.
13834         (linux_fork_detach): Update.
13835         (class scoped_switch_fork_info): Update.
13836         (delete_checkpoint_command): Update.
13837         * infrun.c (follow_fork_inferior): Update.
13838         (follow_fork_inferior): Update.
13839         (proceed_after_vfork_done): Update.
13840         (handle_vfork_child_exec_or_exit): Update.
13841         (follow_exec): Update.
13842         (displaced_step_prepare_throw): Update.
13843         (displaced_step_restore): Update.
13844         (start_step_over): Update.
13845         (resume_1): Update.
13846         (clear_proceed_status_thread): Update.
13847         (proceed): Update.
13848         (print_target_wait_results): Update.
13849         (do_target_wait): Update.
13850         (context_switch): Update.
13851         (stop_all_threads): Update.
13852         (restart_threads): Update.
13853         (finish_step_over): Update.
13854         (handle_signal_stop): Update.
13855         (switch_back_to_stepped_thread): Update.
13856         (keep_going_pass_signal): Update.
13857         (print_exited_reason): Update.
13858         (normal_stop): Update.
13859         * inferior.c (inferior_pid_to_str): Change return type.
13860         (print_selected_inferior): Update.
13861         (add_inferior): Update.
13862         (detach_inferior): Update.
13863         * dummy-frame.c (fprint_dummy_frames): Update.
13864         * dcache.c (dcache_info_1): Update.
13865         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13866         (btrace_fetch, btrace_clear): Update.
13867         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13868         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13869         type.
13870         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13871         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13872         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13873         * gdbarch.c, gdbarch.h: Rebuild.
13874         * gdbarch.sh (core_pid_to_str): Change return type.
13875         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13876         return type.
13877         (windows_nat_target::pid_to_str): Change return type.
13878         (windows_delete_thread): Update.
13879         (windows_nat_target::attach): Update.
13880         (windows_nat_target::files_info): Update.
13881         * target-delegates.c: Rebuild.
13882         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13883         return type.
13884         (sol_thread_target::pid_to_str): Change return type.
13885         * remote.c (class remote_target) <pid_to_str>: Change return
13886         type.
13887         (remote_target::pid_to_str): Change return type.
13888         (extended_remote_target::attach, remote_target::remote_stop_ns)
13889         (remote_target::remote_notif_remove_queued_reply)
13890         (remote_target::push_stop_reply, remote_target::disable_btrace):
13891         Update.
13892         (extended_remote_target::attach): Update.
13893         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13894         type.
13895         (gdbsim_target::pid_to_str): Change return type.
13896         * ravenscar-thread.c (struct ravenscar_thread_target)
13897         <pid_to_str>: Change return type.
13898         (ravenscar_thread_target::pid_to_str): Change return type.
13899         * procfs.c (class procfs_target) <pid_to_str>: Change return
13900         type.
13901         (procfs_target::pid_to_str): Change return type.
13902         (procfs_target::attach): Update.
13903         (procfs_target::detach): Update.
13904         (procfs_target::fetch_registers): Update.
13905         (procfs_target::store_registers): Update.
13906         (procfs_target::wait): Update.
13907         (procfs_target::files_info): Update.
13908         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13909         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13910         return type.
13911         (nto_procfs_target::pid_to_str): Change return type.
13912         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13913         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13914         return type.
13915         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13916         (exit_lwp): Update.
13917         (attach_proc_task_lwp_callback, get_detach_signal)
13918         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13919         (linux_nat_target::resume, wait_lwp, stop_callback)
13920         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13921         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13922         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13923         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13924         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13925         type.
13926         (inf_ptrace_target::attach): Update.
13927         (inf_ptrace_target::files_info): Update.
13928         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13929         type.
13930         (go32_nat_target::pid_to_str): Change return type.
13931         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13932         (gnu_nat_target::wait): Update.
13933         (gnu_nat_target::wait): Update.
13934         (gnu_nat_target::resume): Update.
13935         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13936         (fbsd_nat_target::wait): Update.
13937         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13938         type.
13939         (darwin_nat_target::attach): Update.
13940         * corelow.c (class core_target) <pid_to_str>: Change return type.
13941         (core_target::pid_to_str): Change return type.
13942         * target.c (normal_pid_to_str): Change return type.
13943         (default_pid_to_str): Likewise.
13944         (target_pid_to_str): Change return type.
13945         (target_translate_tls_address): Update.
13946         (target_announce_detach): Update.
13947         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13948         return type.
13949         (bsd_uthread_target::pid_to_str): Change return type.
13950         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13951         type.
13952         (bsd_kvm_target::pid_to_str): Change return type.
13953         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13954         return type.
13955         (aix_thread_target::pid_to_str): Change return type.
13956         * target.h (struct target_ops) <pid_to_str>: Change return type.
13957         (target_pid_to_str, normal_pid_to_str): Likewise.
13958         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13959         type.
13960         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13961         type.
13962         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13963         return type.
13964         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13965         type.
13966         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13967         type.
13968         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13969         return type.
13970
13971 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13972
13973         * NEWS: Mention that the new default MI version is 3.  Mention
13974         changes to the output of commands and events that deal with
13975         multi-location breakpoints.
13976         * breakpoint.c: Include "mi/mi-out.h".
13977         (print_one_breakpoint): Change output syntax if using MI version
13978         >= 3.
13979         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13980         New.
13981         (mi_multi_location_breakpoint_output_fixed): New.
13982         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13983         (mi_cmd_fix_multi_location_breakpoint_output): New.
13984         (mi_multi_location_breakpoint_output_fixed): New.
13985         * mi/mi-cmds.c (mi_cmds): Register command
13986         -fix-multi-location-breakpoint-output.
13987         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13988         interpreter "mi".
13989
13990 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13991
13992         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13993         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13994         instantiate mi_ui_out based on interpreter name.
13995         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13996         * mi/mi-main.c (mi_load_progress): Likewise.
13997
13998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13999
14000         * NEWS: Combine separate "New targets" sections for 8.3.
14001
14002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14003
14004         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
14005         (ppcfbsd_init_abi): Install gdbarch
14006         "fetch_tls_load_module_address" and "get_thread_local_address"
14007         methods.
14008
14009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14010
14011         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14012         (riscv_fbsd_init_abi): Install gdbarch
14013         "fetch_tls_load_module_address" and "get_thread_local_address"
14014         methods.
14015
14016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14017
14018         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14019         (i386fbsd_init_abi): Install gdbarch
14020         "fetch_tls_load_module_address" and "get_thread_local_address"
14021         methods.
14022
14023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14024
14025         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14026         (amd64fbsd_init_abi): Install gdbarch
14027         "fetch_tls_load_module_address" and "get_thread_local_address"
14028         methods.
14029
14030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14031
14032         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14033         (struct fbsd_pspace_data): New type.
14034         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14035         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14036         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14037         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14038         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14039
14040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14041
14042         * gdbtypes.c (lookup_struct_elt): New function.
14043         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14044         * gdbtypes.h (struct struct_elt): New type.
14045         (lookup_struct_elt): New prototype.
14046
14047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14048
14049         * gdbtypes.c (lookup_struct_elt_type): Update comment and
14050         remove disabled code block.
14051
14052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14053
14054         * gdbarch.sh (get_thread_local_address): New method.
14055         * gdbarch.h, gdbarch.c: Regenerate.
14056         * target.c (target_translate_tls_address): Use
14057         gdbarch_get_thread_local_address if present instead of
14058         target::get_thread_local_address.
14059
14060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14061
14062         * target.h (target::get_thread_local_address): Update comment.
14063
14064 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14065
14066         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14067         objfile->separate_debug_objfile_backlink if not NULL.
14068
14069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14070
14071         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14072         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14073         (amd64bsd_store_inferior_registers): Likewise.
14074         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14075         Enable segment base registers.
14076         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14077         PT_GETFSBASE and PT_GETGSBASE.
14078         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14079         PT_SETGSBASE.
14080         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14081         segment base registers.
14082         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14083
14084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14085
14086         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14087         Update calls to i386_target_description to add 'segments'
14088         parameter.
14089         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14090         add segment base registers.
14091         * arch/i386.c (i386_create_target_description): Add 'segments'
14092         parameter to enable segment base registers.
14093         * arch/i386.h (i386_create_target_description): Likewise.
14094         * features/i386/32bit-segments.xml: New file.
14095         * features/i386/32bit-segments.c: Generate.
14096         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14097         call to i386_target_description to add 'segments' parameter.
14098         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14099         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14100         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14101         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14102         if feature is present.
14103         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14104         Add 'segments' parameter to call to i386_target_description.
14105         (i386_target_description): Add 'segments' parameter to enable
14106         segment base registers.
14107         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14108         to call to i386_target_description.
14109         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14110         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14111         Define I386_NUM_REGS.
14112         (i386_target_description): Add 'segments' parameter to enable
14113         segment base registers.
14114
14115 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14116
14117         PR/24325
14118         * source-cache.c: #undef open and close, to avoid unresolved
14119         externals during linking.
14120
14121 2019-03-12  Tom Tromey  <tromey@adacore.com>
14122
14123         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14124         const.  Add initializers.
14125         (_initialize_remote): Don't initialize ptid globals.
14126
14127 2019-03-12  Pedro Alves  <palves@redhat.com>
14128
14129         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14130
14131 2019-03-12  Pedro Alves  <palves@redhat.com>
14132
14133         * cp-name-parser.y (main): Remove unused 'len' variable.
14134
14135 2019-03-12  Tom Tromey  <tromey@adacore.com>
14136
14137         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14138         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14139
14140 2019-03-12  Tom Tromey  <tromey@adacore.com>
14141
14142         * linux-nat.c (iterate_over_lwps): Update.
14143         (stop_callback): Remove parameter.
14144         (stop_wait_callback, detach_callback, resume_set_callback)
14145         (select_singlestep_lwp_callback, set_ignore_sigint)
14146         (status_callback, resumed_callback, resume_clear_callback)
14147         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14148         data parameter.
14149         (linux_nat_target::detach, linux_nat_target::resume)
14150         (linux_stop_and_wait_all_lwps, select_event_lwp)
14151         (linux_nat_filter_event, linux_nat_wait_1)
14152         (linux_nat_target::kill, linux_nat_target::stop)
14153         (linux_nat_target::stop): Update.
14154         (linux_nat_resume_callback): Change type.
14155         (resume_stopped_resumed_lwps, count_events_callback)
14156         (select_event_lwp_callback): Likewise.
14157         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14158         * arm-linux-nat.c (struct update_registers_data): Remove.
14159         (update_registers_callback): Change type.
14160         (arm_linux_insert_hw_breakpoint1): Update.
14161         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14162         parameter.
14163         (x86_linux_dr_set_addr): Update.
14164         (x86_linux_dr_set_control): Update.
14165         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14166         (iterate_over_lwps): Use gdb::function_view.
14167         * nat/aarch64-linux-hw-point.c (struct
14168         aarch64_dr_update_callback_param): Remove.
14169         (debug_reg_change_callback): Change type.
14170         (aarch64_notify_debug_reg_change): Update.
14171         * s390-linux-nat.c (s390_refresh_per_info): Update.
14172
14173 2019-03-11  Tom Tromey  <tromey@adacore.com>
14174
14175         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14176         redundant assignment to "this_cu".
14177
14178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14179
14180         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14181
14182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14183
14184         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14185         from...
14186         (rank_one_type): ... this.
14187
14188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14189
14190         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14191         from...
14192         (rank_one_type): ... this.
14193
14194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14195
14196         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14197         from...
14198         (rank_one_type): ... this.
14199
14200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14201
14202         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14203         from...
14204         (rank_one_type): ... this.
14205
14206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14207
14208         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14209         from...
14210         (rank_one_type): ... this.
14211
14212 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14213
14214         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14215         from...
14216         (rank_one_type): ... this.
14217
14218 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14219
14220         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14221         from...
14222         (rank_one_type): ... this.
14223
14224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14225
14226         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14227         from...
14228         (rank_one_type): ... this.
14229
14230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14231
14232         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14233         from...
14234         (rank_one_type): ... this.
14235
14236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14237
14238         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14239         from...
14240         (rank_one_type): ... this.
14241
14242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14243
14244         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14245         from...
14246         (rank_one_type): ... this.
14247
14248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14249
14250         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14251         from...
14252         (rank_one_type): ... this.
14253
14254 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14255
14256         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14257         inferior-events' shows the example events.
14258
14259 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14260
14261         Support styling on native MS-Windows console
14262
14263         PR/24315
14264         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14265         on MS-Windows if $TERM is not defined.
14266
14267         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14268
14269         * posix-hdep.c (gdb_console_fputs):
14270         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14271         functions.
14272         * ui-file.h (gdb_console_fputs): Add prototype.
14273
14274         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14275         back to fputs only if the former returns zero.
14276
14277 2019-03-07  Tom Tromey  <tom@tromey.com>
14278
14279         * symmisc.c (print_symbol_bcache_statistics): Update.
14280         (print_objfile_statistics): Update.
14281         * symfile.c (allocate_symtab): Update.
14282         * stabsread.c: Don't include bcache.h.
14283         * psymtab.h (struct psymbol_bcache): Don't declare.
14284         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14285         (psymbol_bcache_init, psymbol_bcache_free)
14286         (psymbol_bcache_get_bcache): Don't declare.
14287         * psymtab.c (struct psymbol_bcache): Remove.
14288         (psymtab_storage::psymtab_storage): Update.
14289         (psymtab_storage::~psymtab_storage): Update.
14290         (psymbol_bcache_init, psymbol_bcache_free)
14291         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14292         (add_psymbol_to_bcache): Update.
14293         (allocate_psymtab): Update.
14294         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14295         macro_cache>: No longer pointers.
14296         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14297         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14298         * macrotab.c (macro_bcache): Update.
14299         * macroexp.c: Don't include bcache.h.
14300         * gdbtypes.c (check_types_worklist): Update.
14301         (types_deeply_equal): Remove TRY/CATCH.  Update.
14302         * elfread.c (elf_symtab_read): Update.
14303         * dwarf2read.c: Don't include bcache.h.
14304         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14305         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14306         (print_bcache_statistics, bcache_memory_used): Don't declare.
14307         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14308         methods.  Rename all data members.
14309         * bcache.c (struct bcache): Move to bcache.h.
14310         (bcache::expand_hash_table): Rename from expand_hash_table.
14311         (bcache): Remove.
14312         (bcache::insert): Rename from bcache_full.
14313         (bcache::compare): Rename from bcache_compare.
14314         (bcache_xmalloc): Remove.
14315         (bcache::~bcache): Rename from bcache_xfree.
14316         (bcache::print_statistics): Rename from print_bcache_statistics.
14317         (bcache::memory_used): Rename from bcache_memory_used.
14318
14319 2019-03-07  Pedro Alves  <palves@redhat.com>
14320
14321         * infrun.c (normal_stop): Also check for
14322         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14323
14324 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14325
14326         * f-lang.c (value_from_host_double): Moved to...
14327         * value.c (value_from_host_double): ...here.
14328         * value.h (value_from_host_double): Declare.
14329         * guile/scm-math.c (vlscm_convert_typed_number): Use
14330         value_from_host_double.
14331         (vlscm_convert_number): Likewise.
14332         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14333         * python/py-value.c (convert_value_from_python): Likewise.
14334
14335 2019-03-06  Tom Tromey  <tom@tromey.com>
14336
14337         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14338
14339 2019-03-06  Tom Tromey  <tom@tromey.com>
14340
14341         * utils.h (free_current_contents): Don't declare.
14342         * utils.c (free_current_contents): Remove.
14343
14344 2019-03-06  Tom Tromey  <tom@tromey.com>
14345
14346         * top.c (quit_force): Update.
14347         * main.c (captured_command_loop): Update.
14348         * common/new-op.c (operator new): Update.
14349         * common/common-exceptions.c (struct catcher)
14350         <save_cleanup_chain>: Remove member.
14351         (exceptions_state_mc_init): Update.
14352         (exception_try_scope_entry): Return nullptr.
14353         (exception_try_scope_exit, exception_rethrow)
14354         (throw_exception_sjlj, throw_exception_cxx): Update.
14355         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14356         (all_cleanups, do_cleanups, discard_cleanups)
14357         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14358         (restore_cleanups, restore_final_cleanups): Don't declare.
14359         (do_final_cleanups): Remove parameter.
14360         * common/cleanups.c (cleanup_chain, make_cleanup)
14361         (make_cleanup_dtor, all_cleanups, do_cleanups)
14362         (discard_my_cleanups, discard_cleanups)
14363         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14364         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14365         (null_cleanup): Remove.
14366         (do_final_cleanups): Remove parameter.
14367
14368 2019-03-06  Tom Tromey  <tom@tromey.com>
14369
14370         * remote.c (remote_target::remote_parse_stop_reply): Use
14371         unique_xmalloc_ptr.
14372
14373 2019-03-06  Tom Tromey  <tom@tromey.com>
14374
14375         * stabsread.c (struct stabs_field_info): Rename from field_info.
14376         <list, fnlist>: Add initializers.
14377         <obstack>: New member.
14378         (read_member_functions, read_struct_fields, read_baseclasses):
14379         Allocate on obstack.  Don't use cleanups.
14380         (read_one_struct_field, read_member_functions, read_struct_fields)
14381         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14382         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14383         (read_struct_type): Update.
14384
14385 2019-03-06  Tom Tromey  <tom@tromey.com>
14386
14387         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14388         * common/filestuff.h (make_cleanup_close): Don't declare.
14389         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14390         Remove.
14391
14392 2019-03-06  Tom Tromey  <tom@tromey.com>
14393
14394         * solib-aix.c: Use make_scope_exit.
14395
14396 2019-03-06  Tom Tromey  <tom@tromey.com>
14397
14398         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14399         Use make_scope_exit.
14400
14401 2019-03-06  Tom Tromey  <tom@tromey.com>
14402
14403         * solib-svr4.c (disable_probes_interface): Remove parameter.
14404         (svr4_handle_solib_event): Use make_scope_exit.
14405
14406 2019-03-06  Tom Tromey  <tom@tromey.com>
14407
14408         * remote.c (struct stop_reply_deleter): Remove.
14409         (stop_reply_up): Update.
14410         (struct stop_reply): Derive from notif_event.  Don't typedef.
14411         <regcache>: Now a std::vector.
14412         (stop_reply_xfree): Remove.
14413         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14414         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14415         (remote_target::discard_pending_stop_replies): Use delete.
14416         (remote_target::remote_parse_stop_reply): Update.
14417         (remote_target::process_stop_reply): Update.
14418         * remote-notif.h (struct notif_event): Add virtual destructor.
14419         Remove "dtr" member.
14420         (struct notif_client) <alloc_event>: Return a unique_ptr.
14421         (notif_event_xfree): Don't declare.
14422         (notif_event_up): New typedef.
14423         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14424         (notif_event_xfree, do_notif_event_xfree): Remove.
14425         (remote_notif_state_xfree): Update.
14426
14427 2019-03-06  Tom Tromey  <tom@tromey.com>
14428
14429         * infrun.c (displaced_step_clear_cleanup): Now a
14430         forward_scope_exit type.
14431         (displaced_step_prepare_throw): Update.
14432         (displaced_step_fixup): Update.
14433
14434 2019-03-06  Tom Tromey  <tom@tromey.com>
14435
14436         * inferior.h (class inferior): Update comment.
14437         * gdbthread.h (class thread_info): Update comment.
14438
14439 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14440             Tom Tromey  <tom@tromey.com>
14441
14442         * stabsread.h (struct stab_section_list): Remove.
14443         (coffstab_build_psymtabs): Update.
14444         * dbxread.c (symbuf_sections): Now a std::vector.
14445         (sect_idx): New global.
14446         (fill_symbuf): Update.
14447         (coffstab_build_psymtabs): Change type of stabsects parameter.
14448         Update.
14449         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14450         std::vector.
14451         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14452         (coff_locate_sections): Update.
14453         (coff_symfile_read): Remove cleanups.  Update.
14454         (init_stringtab): Add storage parameter.
14455         (free_stringtab, free_stringtab_cleanup): Remove.
14456         (init_lineno): Add storage parameter.
14457         (free_linetab, free_linetab_cleanup): Remove.
14458
14459 2019-03-06  Pedro Alves  <palves@redhat.com>
14460
14461         * linux-fork.c (fork_info::clobber_regs): Delete.
14462         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14463         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14464         comment.  Adjust.
14465         (scoped_switch_fork_info::scoped_switch_fork_info)
14466         (checkpoint_command, linux_fork_context): Adjust
14467         fork_save_infrun_state calls.
14468
14469 2019-03-06  Pedro Alves  <palves@redhat.com>
14470
14471         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14472         (inf_has_multiple_threads): Return 'bool' and rewrite using
14473         inferior_info::threads().
14474
14475 2019-03-06  Pedro Alves  <palves@redhat.com>
14476
14477         * linux-fork.c: Include <list>.
14478         (fork_list): Now a std::list instance.
14479         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14480         (forks_exist_p, find_last_fork): Adjust.
14481         (new_fork): Delete.
14482         (one_fork_p): New.
14483         (add_fork): Adjust.
14484         (free_fork): Delete, folded into fork_info::~fork_info().
14485         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14486         Adjust.
14487         (init_fork_list): Delete.
14488         (linux_fork_killall, linux_fork_mourn_inferior)
14489         (linux_fork_detach, info_checkpoints_command): Adjust.
14490         (_initialize_linux_fork): No longer call init_fork_list.
14491
14492 2019-03-06  Pedro Alves  <palves@redhat.com>
14493
14494         * linux-fork.c (new_fork): New, split out of ...
14495         (add_fork): ... this.  Return void.  Move "first fork" special
14496         case from here, to ...
14497         (checkpoint_command): ... here.
14498         * linux-linux.h (add_fork): Return void.
14499
14500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14501
14502         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14503
14504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14505             Chris January  <chris.january@arm.com>
14506             David Lecomber  <david.lecomber@arm.com>
14507
14508         * f-exp.y: New token, UNOP_INTRINSIC.
14509         (exp): New pattern using UNOP_INTRINSIC token.
14510         (f77_keywords): Add 'abs' keyword.
14511         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14512         (value_from_host_double): New function.
14513         (evaluate_subexp_f): Support UNOP_ABS.
14514
14515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14516
14517         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14518         types.
14519
14520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14521
14522         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14523         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14524         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14525
14526 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14527
14528         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14529
14530 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14531             Chris January  <chris.january@arm.com>
14532
14533         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14534         * f-exp.y: Define 'KIND' token.
14535         (exp): New pattern for KIND expressions.
14536         (ptype): Handle types with a kind extension.
14537         (direct_abs_decl): Extend to spot kind extensions.
14538         (f77_keywords): Add 'kind' to the list.
14539         (push_kind_type): New function.
14540         (convert_to_kind_type): New function.
14541         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14542         * parse.c (operator_length_standard): Likewise.
14543         * parser-defs.h (enum type_pieces): Add tp_kind.
14544         * std-operator.def: Add UNOP_KIND.
14545
14546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14547
14548         * f-exp.y (f_parse): Set yydebug.
14549
14550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14551
14552         * f-lang.c (evaluate_subexp_f): New function.
14553         (exp_descriptor_f): New global.
14554         (f_language_defn): Use exp_descriptor_f instead of
14555         exp_descriptor_standard.
14556
14557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14558
14559         * f-exp.y (struct token): Add comments.
14560         (dot_ops): Remove uppercase versions and the end marker.
14561         (f77_keywords): Likewise.
14562         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14563         entries in the dot_ops array are case insensitive, and use
14564         strncasecmp to compare strings.  Also some whitespace cleanup in
14565         this area.  Similar for the f77_keywords array, except entries in
14566         this list might be case sensitive.
14567
14568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14569
14570         * f-exp.y (struct f77_boolean_val): Add comments.
14571         (boolean_values): Remove uppercase versions, and end marker.
14572         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14573         and use strncasecmp to achieve case insensitivity.  Additionally,
14574         perform whitespace cleanup around this code.
14575
14576 2019-03-06  Tom Tromey  <tromey@adacore.com>
14577
14578         * remote-sim.c (gdbsim_target_open): Use result of
14579         gdb_argv::release.
14580
14581 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14582         Dirk Schubert  <dirk.schubert@arm.com>
14583         Chris January  <chris.january@arm.com>
14584
14585         * eval.c (evaluate_subexp_standard): Call Fortran argument
14586         wrapping logic.
14587         * f-lang.c (struct value): A value which can be passed into a
14588         Fortran function call.
14589         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14590         where appropriate.
14591         (struct type): Value ready for a Fortran function call.
14592         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14593         is needed.
14594         * f-lang.h (fortran_argument_convert): Declaration.
14595         (fortran_preserve_arg_pointer): Declaration.
14596         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14597
14598 2019-03-05  Tom Tromey  <tromey@adacore.com>
14599
14600         * python/py-prettyprint.c (print_string_repr): Remove #if.
14601         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14602
14603 2019-03-05  Tom Tromey  <tromey@adacore.com>
14604
14605         * target.c (the_dummy_target): Move later.  Change type to
14606         "dummy_target".
14607         (initialize_targets): Don't initialize the_dummy_target.
14608
14609 2019-03-05  Tom Tromey  <tromey@adacore.com>
14610
14611         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14612         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14613
14614 2019-03-05  Tom Tromey  <tromey@adacore.com>
14615
14616         * windows-nat.c (windows_nat_target::attach)
14617         (windows_nat_target::detach): Don't call gdb_flush.
14618         * valprint.c (generic_val_print, val_print, val_print_string):
14619         Don't call gdb_flush.
14620         * utils.c (defaulted_query): Don't call gdb_flush.
14621         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14622         * target.c (target_announce_detach): Don't call gdb_flush.
14623         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14624         * remote.c (extended_remote_target::attach): Don't call
14625         gdb_flush.
14626         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14627         * printcmd.c (do_examine): Don't call gdb_flush.
14628         (info_display_command): Don't call gdb_flush.
14629         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14630         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14631         * memattr.c (info_mem_command): Don't call gdb_flush.
14632         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14633         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14634         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14635         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14636         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14637         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14638         (gnu_nat_target::detach): Don't call gdb_flush.
14639         * f-valprint.c (f_val_print): Don't call gdb_flush.
14640         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14641         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14642         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14643         gdb_flush.
14644         * c-valprint.c (c_val_print): Don't call gdb_flush.
14645         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14646
14647 2019-03-05  Tom Tromey  <tromey@adacore.com>
14648
14649         * varobj.c (update_dynamic_varobj_children): Update.
14650         (install_default_visualizer): Use reset, not release.
14651         * value.c (set_internalvar): Update.
14652         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14653         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14654         ATTRIBUTE_UNUSED_RESULT.
14655
14656 2019-03-05  Tom Tromey  <tromey@adacore.com>
14657
14658         * remote.c (class scoped_remote_fd) <release>: Add
14659         ATTRIBUTE_UNUSED_RESULT.
14660
14661 2019-03-05  Tom Tromey  <tromey@adacore.com>
14662
14663         * macroexp.c (struct macro_buffer) <release>: Add
14664         ATTRIBUTE_UNUSED_RESULT.
14665
14666 2019-03-05  Tom Tromey  <tromey@adacore.com>
14667
14668         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14669         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14670         ATTRIBUTE_UNUSED_RESULT.
14671
14672 2019-03-05  Tom Tromey  <tromey@adacore.com>
14673
14674         * common/scoped_fd.h (class scoped_fd) <release>: Add
14675         ATTRIBUTE_UNUSED_RESULT.
14676
14677 2019-03-05  Tom Tromey  <tromey@adacore.com>
14678
14679         * parser-defs.h (struct parser_state) <release>: Add
14680         ATTRIBUTE_UNUSED_RESULT.
14681
14682 2019-03-05  Tom Tromey  <tromey@adacore.com>
14683
14684         * utils.h (class gdb_argv) <release>: Add
14685         ATTRIBUTE_UNUSED_RESULT.
14686         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14687
14688 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14689
14690         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14691         for-loop range, to avoid compiler warnings.
14692
14693         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14694         avoid compiler warnings about unused variables.
14695
14696         * NEWS: Mention end of support for native debugging on MS-Windows
14697         before XP.
14698
14699         PR gdb/24292
14700         * common/netstuff.c:
14701         * gdbserver/gdbreplay.c
14702         * gdbserver/remote-utils.c:
14703         * ser-tcp.c:
14704         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14705         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14706         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14707         'getaddrinfo' and 'freeaddrinfo' were not available before
14708         Windows XP, and mingw.org's MinGW headers by default define
14709         _WIN32_WINNT to 0x500.
14710
14711 2019-03-01  Gary Benson <gbenson@redhat.com>
14712
14713         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14714
14715 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14716             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14717
14718         PR gdb/8527
14719         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14720         set_sigint_trap, clear_sigint_trap.
14721
14722 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14723
14724         * target.c (target_detach): Clear the regcache and the
14725         frame cache.
14726
14727 2019-02-27  Pedro Alves  <palves@redhat.com>
14728
14729         * utils.c (set_screen_size): When we cap the height/width sizes,
14730         tweak the corresponding command variable to show "unlimited":
14731
14732 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14733             Pedro Alves  <palves@redhat.com>
14734
14735         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14736         before calling rl_set_screen_size.
14737
14738 2019-02-27  Tom Tromey  <tromey@adacore.com>
14739
14740         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14741         define.
14742         * python/py-value.c: Remove Python 2.4 workaround.
14743         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14744         workaround.
14745         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14746         Python 2.4 workaround.
14747         * python/python-internal.h: Remove Python 2.4 comment.
14748         (Py_ssize_t): Don't define.
14749         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14750         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14751         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14752         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14753         * python/python.c (do_start_initialization): Remove Python 2.4
14754         workaround.
14755         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14756         (print_children): Remove Python 2.4 workaround.
14757         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14758         workaround.
14759         (CHARBUFFERPROC_NAME): Remove.
14760         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14761         Python 2.4 workaround.
14762
14763 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14764
14765         * NEWS: Note minimum Python version.
14766
14767 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14768
14769         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14770         code from these functions.  Remove corresponding ifdefs.  Use
14771         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14772         Remove gotos and target of gotos.
14773         (infpy_search_memory): Likewise.
14774
14775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14776
14777         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14778         (hppa_gdbarch_init): Don't register deleted functions with
14779         gdbarch.
14780
14781 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14782
14783         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14784         (h8300_unwind_sp): Delete.
14785         (h8300_dummy_id): Delete.
14786         (h8300_gdbarch_init): Don't register deleted functions with
14787         gdbarch.
14788
14789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14790
14791         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14792         (ft32_unwind_pc): Delete.
14793         (ft32_unwind_sp): Delete.
14794         (ft32_gdbarch_init): Don't register deleted functions with
14795         gdbarch.
14796
14797 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14798
14799         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14800         (frv_unwind_pc): Delete.
14801         (frv_unwind_sp): Delete.
14802         (frv_gdbarch_init): Don't register deleted functions with
14803         gdbarch.
14804
14805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14806
14807         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14808         (riscv_unwind_pc): Delete.
14809         (riscv_unwind_sp): Delete.
14810         (riscv_gdbarch_init): Don't register deleted functions with
14811         gdbarch.
14812
14813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14814
14815         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14816         (csky_unwind_pc): Delete.
14817         (csky_unwind_sp): Delete.
14818         (csky_gdbarch_init): Don't register deleted functions with
14819         gdbarch.
14820
14821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14822
14823         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14824         (cris_unwind_pc): Delete.
14825         (cris_unwind_sp): Delete.
14826         (cris_gdbarch_init): Don't register deleted functions with
14827         gdbarch.
14828
14829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14830
14831         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14832         (bfin_unwind_pc): Delete.
14833         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14834
14835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14836
14837         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14838         (arm_unwind_pc): Delete.
14839         (arm_unwind_sp): Delete.
14840         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14841
14842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14843
14844         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14845         (arc_unwind_pc): Delete.
14846         (arc_unwind_sp): Delete.
14847         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14848
14849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14850
14851         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14852         (alpha_unwind_pc): Delete.
14853         (alpha_gdbarch_init): Don't register deleted functions with
14854         gdbarch.
14855
14856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14857
14858         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14859         (aarch64_unwind_pc): Delete.
14860         (aarch64_unwind_sp): Delete.
14861         (aarch64_gdbarch_init): Don't register deleted functions with
14862         gdbarch.
14863
14864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14865
14866         * gdbtypes.c (type_align): Don't consider static members when
14867         computing structure alignment.
14868
14869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14870
14871         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14872         return 0 for other types.
14873         * arch-utils.c (default_type_align): Always return 0.
14874         * gdbarch.h: Regenerate.
14875         * gdbarch.sh (type_align): Extend comment.
14876         * gdbtypes.c (type_align): Add additional comments, always call
14877         gdbarch_type_align before applying the default rules.
14878         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14879         generic code will then apply a suitable default.
14880         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14881         types, return 0 for other types.
14882
14883 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14884
14885         * NEWS: Create a new section for the next release branch.
14886         Rename the section of the current branch, now that it has
14887         been cut.
14888
14889 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14890
14891         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14892         * version.in: Bump version to 8.3.50.DATE-git.
14893
14894 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14895
14896         * aix-thread.c (ptid_cmp): Remove unused variable.
14897         (get_signaled_thread): Likewise.
14898         (store_regs_user_thread): Likewise.
14899         (store_regs_kernel_thread): Likewise.
14900         (fetch_regs_kernel_thread): Remove shadowed variable.
14901
14902 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14903
14904         * features/riscv/32bit-cpu.xml: Add register numbers.
14905         * features/riscv/32bit-fpu.c: Regenerate.
14906         * features/riscv/32bit-fpu.xml: Add register numbers.
14907         * features/riscv/64bit-cpu.xml: Add register numbers.
14908         * features/riscv/64bit-fpu.c: Regenerate.
14909         * features/riscv/64bit-fpu.xml: Add register numbers.
14910
14911 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14912
14913         * NEWS: Mention two argument form of gdb.Value constructor.
14914         * python/py-value.c (convert_buffer_and_type_to_value): New
14915         function.
14916         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14917         Add support for handling an optional second argument.  Call
14918         convert_buffer_and_type_to_value as appropriate.
14919         * python/python-internal.h (Py_buffer_deleter): New struct.
14920         (Py_buffer_up): New typedef.
14921
14922 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14923
14924         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14925         instead of releasing ownership.
14926
14927 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14928
14929         * dwarf2read.c (open_and_init_dwp_file): Call
14930         elf_numsections instead of bfd_count_sections to initialize
14931         dwp_file->num_sections.
14932
14933 2019-02-25  Tom Tromey  <tromey@adacore.com>
14934
14935         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14936
14937 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14938
14939         * gcore.in: Add '--readnever' option when invoking GDB.
14940
14941 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14942
14943         * MAINTAINERS: Update my email address.
14944
14945 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14946
14947         * build-id.c (build_id_to_debug_bfd_1): New function.
14948         (build_id_to_debug_bfd): Look for separate debug file in
14949         sysroot.
14950
14951 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14952
14953         * gdbarch.sh: Update the copyright year range that is placed into
14954         generated files.
14955
14956 2019-02-22  Keith Seitz  <keiths@redhat.com>
14957
14958         PR symtab/23853
14959         * linespec.c (create_sals_line_offset): Search for the default
14960         symtab's filename instead of its fullname.
14961
14962 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14963
14964         * NEWS: Update style defaults.
14965
14966 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14967
14968         * main.c (captured_main_1): Disable styling in batch mode.
14969
14970 2019-02-20  Tom Tromey  <tom@tromey.com>
14971
14972         * symtab.c (symtab_symbol_info): Fix typos.
14973
14974 2019-02-20  Tom Tromey  <tromey@adacore.com>
14975
14976         * findcmd.c (_initialize_mem_search): Use upper case for
14977         metasyntactic variables.
14978
14979 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14980
14981         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14982         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14983
14984 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14985
14986         * top.h (source_file_name): Change to std::string.
14987         * top.c (source_file_name): Likewise.
14988         (command_line_input): Adjust.
14989         * cli/cli-script.c (script_from_file): Adjust.
14990
14991 2019-02-19  Tom Tromey  <tromey@adacore.com>
14992
14993         * ravenscar-thread.c
14994         (ravenscar_thread_target::update_thread_list): Don't call
14995         ada_build_task_list.
14996         * ada-lang.h (ada_build_task_list): Don't declare.
14997         * ada-tasks.c (struct ada_tasks_inferior_data)
14998         <task_list_valid_p>: Now bool.
14999         (read_known_tasks, ada_task_list_changed)
15000         (ada_tasks_invalidate_inferior_data): Update.
15001         (read_known_tasks_array): Return bool.
15002         (read_known_tasks_list): Likewise.
15003         (read_known_tasks): Return void.
15004         (ada_build_task_list): Now static.
15005
15006 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
15007
15008         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
15009         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
15010
15011 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15012
15013         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15014         variant for ada_tasks_pspace_data_handle and
15015         ada_tasks_inferior_data_handle.
15016         (ada_tasks_pspace_data_cleanup): New function.
15017         (ada_tasks_inferior_data_cleanup): New function.
15018
15019 2019-02-17  Tom Tromey  <tom@tromey.com>
15020
15021         * macrotab.h (macro_source_fullname): Return a std::string.
15022         * macrotab.c (macro_include, check_for_redefinition)
15023         (macro_undef, macro_lookup_definition, foreach_macro)
15024         (foreach_macro_in_scope): Update.
15025         (macro_source_fullname): Return a std::string.
15026         * macrocmd.c (show_pp_source_pos): Update.
15027
15028 2019-02-17  Tom Tromey  <tom@tromey.com>
15029
15030         * macrocmd.c (show_pp_source_pos): Style the file names.
15031
15032 2019-02-17  Tom Tromey  <tom@tromey.com>
15033
15034         PR tui/24197:
15035         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15036
15037 2019-02-17  Tom Tromey  <tom@tromey.com>
15038
15039         * ada-lang.c (user_select_syms): Use filtered printing.
15040         * utils.c (wrap_style): New global.
15041         (desired_style): Remove.
15042         (emit_style_escape): Add stream parameter.
15043         (set_output_style, reset_terminal_style, prompt_for_continue):
15044         Update.
15045         (flush_wrap_buffer): Only flush gdb_stdout.
15046         (wrap_here): Set wrap_style.
15047         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
15048         treat escape sequences as a character.  Change when wrap buffer is
15049         flushed.
15050         (fputs_styled): Do not set the output style when the default is
15051         requested.
15052         * ui-style.h (struct ui_file_style) <is_default>: New method.
15053         * source.c (print_source_lines_base): Emit escape sequences in one
15054         piece.
15055
15056 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15057
15058         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15059         integers and enumeration types.
15060
15061 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15062
15063         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15064         instead of lookup_symbol_in_language
15065         (do_exact_match): New function.
15066         (ada_get_symbol_name_matcher): Return do_exact_match when
15067         doing a verbatim match.
15068
15069 2019-02-15  Tom Tromey  <tromey@adacore.com>
15070
15071         * ravenscar-thread.c (ravenscar_thread_target::resume)
15072         (ravenscar_thread_target::wait): Special case wildcard requests.
15073
15074 2019-02-15  Tom Tromey  <tromey@adacore.com>
15075
15076         * ravenscar-thread.c (base_ptid): Remove.
15077         (struct ravenscar_thread_target) <close>: New method.
15078         <m_base_ptid>: New member.
15079         <update_inferior_ptid, active_task, task_is_currently_active,
15080         runtime_initialized>: Declare methods.
15081         <ravenscar_thread_target>: Add constructor.
15082         (ravenscar_thread_target::task_is_currently_active)
15083         (ravenscar_thread_target::update_inferior_ptid)
15084         (ravenscar_runtime_initialized): Rename.  Now methods.
15085         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15086         (ravenscar_thread_target::update_thread_list): Update.
15087         (ravenscar_thread_target::active_task): Now method.
15088         (ravenscar_thread_target::store_registers)
15089         (ravenscar_thread_target::prepare_to_store)
15090         (ravenscar_thread_target::prepare_to_store)
15091         (ravenscar_thread_target::mourn_inferior): Update.
15092         (ravenscar_inferior_created): Use "new" to create target.
15093         (ravenscar_thread_target::get_ada_task_ptid): Update.
15094         (_initialize_ravenscar): Don't initialize base_ptid.
15095         (ravenscar_ops): Remove global.
15096
15097 2019-02-15  Tom Tromey  <tromey@adacore.com>
15098
15099         * target.h (push_target): Declare new overload.
15100         * target.c (push_target): New overload, taking an rvalue reference.
15101         * remote.c (remote_target::open_1): Use push_target overload.
15102         * corelow.c (core_target_open): Use push_target overload.
15103
15104 2019-02-15  Tom Tromey  <tromey@adacore.com>
15105
15106         * ravenscar-thread.c (is_ravenscar_task)
15107         (ravenscar_task_is_currently_active): Return bool.
15108         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15109         (_initialize_ravenscar): Remove "(void)".
15110         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15111         Return bool.
15112
15113 2019-02-15  Tom Tromey  <tromey@adacore.com>
15114
15115         * ravenscar-thread.c (ravenscar_runtime_initializer)
15116         (has_ravenscar_runtime, get_running_thread_id)
15117         (ravenscar_thread_target::resume): Fix indentation.
15118
15119 2019-02-15  Tom Tromey  <tromey@adacore.com>
15120
15121         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15122         from ravenscar_arch_ops.
15123         (sparc_ravenscar_ops::fetch_registers)
15124         (sparc_ravenscar_ops::store_registers): Now methods.
15125         (sparc_ravenscar_prepare_to_store): Remove.
15126         (sparc_ravenscar_ops): Redefine.
15127         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15128         methods and destructor.  Remove members.
15129         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15130         (ravenscar_thread_target::store_registers)
15131         (ravenscar_thread_target::prepare_to_store): Update.
15132         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15133         Remove.
15134         (struct ppc_ravenscar_powerpc_ops): Derive from
15135         ravenscar_arch_ops.
15136         (ppc_ravenscar_powerpc_ops::fetch_registers)
15137         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15138         (ppc_ravenscar_powerpc_ops): Redefine.
15139         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15140         (ppc_ravenscar_e500_ops::fetch_registers)
15141         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15142         (ppc_ravenscar_e500_ops): Redefine.
15143         * aarch64-ravenscar-thread.c
15144         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15145         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15146         (aarch64_ravenscar_fetch_registers)
15147         (aarch64_ravenscar_store_registers): Now methods.
15148         (aarch64_ravenscar_ops): Redefine.
15149
15150 2019-02-15  Tom Tromey  <tromey@adacore.com>
15151
15152         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15153         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15154         (ravenscar_thread_target::stopped_by_watchpoint)
15155         (ravenscar_thread_target::stopped_data_address)
15156         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15157
15158 2019-02-15  Tom Tromey  <tromey@adacore.com>
15159
15160         * ravenscar-thread.c: Fix some typos.
15161
15162 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15163             Tom Tromey  <tromey@adacore.com>
15164
15165         * ada-lang.c (ada_exception_sal): Change addr_string to a
15166         std::string.
15167         (create_ada_exception_catchpoint): Update.
15168
15169 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15170             Tom Tromey  <tromey@adacore.com>
15171
15172         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15173         (bp_location_ops): Remove.
15174         (base_breakpoint_allocate_location): Update.
15175         (free_bp_location): Update.
15176         * ada-lang.c (class ada_catchpoint_location)
15177         <ada_catchpoint_location>: Remove ops parameter.
15178         (ada_catchpoint_location_dtor): Remove.
15179         (ada_catchpoint_location_ops): Remove.
15180         (allocate_location_exception): Update.
15181         * breakpoint.h (struct bp_location_ops): Remove.
15182         (class bp_location) <bp_location>: Remove bp_location_ops
15183         parameter.
15184         <~bp_location>: Add destructor.
15185         <ops>: Remove.
15186
15187 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15188             Pedro Alves  <palves@redhat.com>
15189
15190         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15191         'PATH_MAX'.
15192
15193 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15194             Samuel Thibault  <samuel.thibault@gnu.org>
15195             Thomas Schwinge  <thomas@codesourcery.com>
15196
15197         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15198         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15199
15200 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15201
15202         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15203         (check_empty): Use "const char *".
15204
15205         * gnu-nat.c (gnu_nat_target::detach): Instead of
15206         'detach_inferior (pid)' call
15207         'detach_inferior (find_inferior_pid (pid))'.
15208
15209         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15210         'nat/fork-inferior.o'.
15211         * gnu-nat.c: #include "nat/fork-inferior.h".
15212
15213         * gnu-nat.c (gnu_nat_target::detach): Instead of
15214         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15215         * gnu-nat.h: #include "inf-child.h".
15216         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15217         'i386_gnu_nat_target::fetch_registers'.
15218         (gnu_store_registers): Rename/move to
15219         'i386_gnu_nat_target::store_registers'.
15220
15221         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15222         * gnu-nat.h (mach_thread_info): New function.
15223         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15224
15225         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15226
15227 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15228
15229         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15230
15231 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15232
15233         * windows-nat.c (windows_add_thread): Add new parameter
15234         "main_thread_p" with default value set to false.  Update
15235         function documentation as well as all callers.
15236         (windows_delete_thread): Likewise.
15237         (fake_create_process): Update call to windows_add_thread.
15238         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15239         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15240         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15241         call to windows_delete_thread.
15242
15243 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15244
15245         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15246
15247 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15248
15249         * symfile.c (find_separate_debug_file): Use canonical path of
15250         sysroot with child_path instead of gdb_sysroot if it is valid.
15251
15252 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15253
15254         * symfile.c (find_separate_debug_file): Use child_path to
15255         determine if an object file is under a sysroot.
15256
15257 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15258
15259         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15260         unittests/child-path-selftests.c.
15261         * common/pathstuff.c (child_path): New function.
15262         * common/pathstuff.h (child_path): New prototype.
15263         * unittests/child-path-selftests.c: New file.
15264
15265 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15266
15267         * symfile.c (find_separate_debug_file): Look for separate debug
15268         files in debug directories under the sysroot.
15269
15270 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15271
15272         * symtab.h (struct minimal_symbol data_p): New const method.
15273         (struct minimal_symbol text_p): Likewise.
15274         * symtab.c (output_source_filename): Use file name style
15275         to print file name.
15276         (print_symbol_info): Likewise.
15277         (print_msymbol_info): Use address style to print addresses.
15278         Use function name style to print executable text symbols.
15279         (expand_symtab_containing_pc): Use data_p.
15280         (find_pc_sect_compunit_symtab): Likewise.
15281
15282 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15283
15284         * breakpoint.c (describe_other_breakpoints): Use address style
15285         to print addresses.
15286         (say_where): Likewise.
15287
15288 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15289
15290         * ada-typeprint.c (print_func_type): Print function name
15291         style to print function name.
15292         * c-typeprint.c (c_print_type_1): Likewise.
15293
15294 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15295
15296         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15297         for execve.
15298
15299 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15300
15301         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15302         type_stack.
15303
15304 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15305
15306         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15307         TYPE_CODE_REF types.
15308
15309 2019-02-08  Jim Wilson  <jimw@sifive.com>
15310
15311         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15312         (riscv_linux_fregset): New.
15313         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15314
15315 2019-02-07  Tom Tromey  <tom@tromey.com>
15316
15317         * thread.c (thread_cancel_execution_command): Update.
15318         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15319         methods.
15320         (struct thread_fsm_ops): Remove.
15321         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15322         (thread_fsm_should_stop, thread_fsm_return_value)
15323         (thread_fsm_set_finished, thread_fsm_finished_p)
15324         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15325         Don't declare.
15326         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15327         * infrun.c (clear_proceed_status_thread)
15328         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15329         (print_stop_event): Update.
15330         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15331         Add constructor.
15332         (step_command_fsm_ops): Remove.
15333         (new_step_command_fsm): Remove.
15334         (step_1): Update.
15335         (step_command_fsm::should_stop): Rename from
15336         step_command_fsm_should_stop.
15337         (step_command_fsm::clean_up): Rename from
15338         step_command_fsm_clean_up.
15339         (step_command_fsm::do_async_reply_reason): Rename from
15340         step_command_fsm_async_reply_reason.
15341         (struct until_next_fsm): Inherit from thread_fsm.  Add
15342         constructor.
15343         (until_next_fsm_ops): Remove.
15344         (new_until_next_fsm): Remove.
15345         (until_next_fsm::should_stop): Rename from
15346         until_next_fsm_should_stop.
15347         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15348         (until_next_fsm::do_async_reply_reason): Rename from
15349         until_next_fsm_async_reply_reason.
15350         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15351         constructor.  Change type of breakpoint.
15352         (finish_command_fsm_ops): Remove.
15353         (new_finish_command_fsm): Remove.
15354         (finish_command_fsm::should_stop): Rename from
15355         finish_command_fsm_should_stop.
15356         (finish_command_fsm::clean_up): Rename from
15357         finish_command_fsm_clean_up.
15358         (finish_command_fsm::return_value): Rename from
15359         finish_command_fsm_return_value.
15360         (finish_command_fsm::do_async_reply_reason): Rename from
15361         finish_command_fsm_async_reply_reason.
15362         (finish_command): Update.
15363         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15364         Add constructor.
15365         (call_thread_fsm_ops): Remove.
15366         (call_thread_fsm::call_thread_fsm): Rename from
15367         new_call_thread_fsm.
15368         (call_thread_fsm::should_stop): Rename from
15369         call_thread_fsm_should_stop.
15370         (call_thread_fsm::should_notify_stop): Rename from
15371         call_thread_fsm_should_notify_stop.
15372         (run_inferior_call, call_function_by_hand_dummy): Update.
15373         * cli/cli-interp.c (should_print_stop_to_console): Update.
15374         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15375         Add constructor.  Change type of location_breakpoint,
15376         caller_breakpoint.
15377         (until_break_fsm_ops): Remove.
15378         (new_until_break_fsm): Remove.
15379         (until_break_fsm::should_stop): Rename from
15380         until_break_fsm_should_stop.
15381         (until_break_fsm::clean_up): Rename from
15382         until_break_fsm_clean_up.
15383         (until_break_fsm::do_async_reply_reason): Rename from
15384         until_break_fsm_async_reply_reason.
15385         (until_break_command): Update.
15386         * thread-fsm.c: Remove.
15387         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15388
15389 2019-02-07  Tom Tromey  <tom@tromey.com>
15390
15391         * yy-remap.h: Add include guard.
15392         * xtensa-tdep.h: Add include guard.
15393         * xcoffread.h: Rename include guard.
15394         * varobj-iter.h: Add include guard.
15395         * tui/tui.h: Rename include guard.
15396         * tui/tui-winsource.h: Rename include guard.
15397         * tui/tui-wingeneral.h: Rename include guard.
15398         * tui/tui-windata.h: Rename include guard.
15399         * tui/tui-win.h: Rename include guard.
15400         * tui/tui-stack.h: Rename include guard.
15401         * tui/tui-source.h: Rename include guard.
15402         * tui/tui-regs.h: Rename include guard.
15403         * tui/tui-out.h: Rename include guard.
15404         * tui/tui-layout.h: Rename include guard.
15405         * tui/tui-io.h: Rename include guard.
15406         * tui/tui-hooks.h: Rename include guard.
15407         * tui/tui-file.h: Rename include guard.
15408         * tui/tui-disasm.h: Rename include guard.
15409         * tui/tui-data.h: Rename include guard.
15410         * tui/tui-command.h: Rename include guard.
15411         * tic6x-tdep.h: Add include guard.
15412         * target/waitstatus.h: Rename include guard.
15413         * target/wait.h: Rename include guard.
15414         * target/target.h: Rename include guard.
15415         * target/resume.h: Rename include guard.
15416         * target-float.h: Rename include guard.
15417         * stabsread.h: Add include guard.
15418         * rs6000-tdep.h: Add include guard.
15419         * riscv-fbsd-tdep.h: Add include guard.
15420         * regformats/regdef.h: Rename include guard.
15421         * record.h: Rename include guard.
15422         * python/python.h: Rename include guard.
15423         * python/python-internal.h: Rename include guard.
15424         * python/py-stopevent.h: Rename include guard.
15425         * python/py-ref.h: Rename include guard.
15426         * python/py-record.h: Rename include guard.
15427         * python/py-record-full.h: Rename include guard.
15428         * python/py-record-btrace.h: Rename include guard.
15429         * python/py-instruction.h: Rename include guard.
15430         * python/py-events.h: Rename include guard.
15431         * python/py-event.h: Rename include guard.
15432         * procfs.h: Add include guard.
15433         * proc-utils.h: Add include guard.
15434         * p-lang.h: Add include guard.
15435         * or1k-tdep.h: Rename include guard.
15436         * observable.h: Rename include guard.
15437         * nto-tdep.h: Rename include guard.
15438         * nat/x86-linux.h: Rename include guard.
15439         * nat/x86-linux-dregs.h: Rename include guard.
15440         * nat/x86-gcc-cpuid.h: Add include guard.
15441         * nat/x86-dregs.h: Rename include guard.
15442         * nat/x86-cpuid.h: Rename include guard.
15443         * nat/ppc-linux.h: Rename include guard.
15444         * nat/mips-linux-watch.h: Rename include guard.
15445         * nat/linux-waitpid.h: Rename include guard.
15446         * nat/linux-ptrace.h: Rename include guard.
15447         * nat/linux-procfs.h: Rename include guard.
15448         * nat/linux-osdata.h: Rename include guard.
15449         * nat/linux-nat.h: Rename include guard.
15450         * nat/linux-namespaces.h: Rename include guard.
15451         * nat/linux-btrace.h: Rename include guard.
15452         * nat/glibc_thread_db.h: Rename include guard.
15453         * nat/gdb_thread_db.h: Rename include guard.
15454         * nat/gdb_ptrace.h: Rename include guard.
15455         * nat/fork-inferior.h: Rename include guard.
15456         * nat/amd64-linux-siginfo.h: Rename include guard.
15457         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15458         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15459         * nat/aarch64-linux.h: Rename include guard.
15460         * nat/aarch64-linux-hw-point.h: Rename include guard.
15461         * mn10300-tdep.h: Add include guard.
15462         * mips-linux-tdep.h: Add include guard.
15463         * mi/mi-parse.h: Rename include guard.
15464         * mi/mi-out.h: Rename include guard.
15465         * mi/mi-main.h: Rename include guard.
15466         * mi/mi-interp.h: Rename include guard.
15467         * mi/mi-getopt.h: Rename include guard.
15468         * mi/mi-console.h: Rename include guard.
15469         * mi/mi-common.h: Rename include guard.
15470         * mi/mi-cmds.h: Rename include guard.
15471         * mi/mi-cmd-break.h: Rename include guard.
15472         * m2-lang.h: Add include guard.
15473         * location.h: Rename include guard.
15474         * linux-record.h: Rename include guard.
15475         * linux-nat.h: Add include guard.
15476         * linux-fork.h: Add include guard.
15477         * i386-darwin-tdep.h: Rename include guard.
15478         * hppa-linux-offsets.h: Add include guard.
15479         * guile/guile.h: Rename include guard.
15480         * guile/guile-internal.h: Rename include guard.
15481         * gnu-nat.h: Rename include guard.
15482         * gdb-stabs.h: Rename include guard.
15483         * frv-tdep.h: Add include guard.
15484         * f-lang.h: Add include guard.
15485         * event-loop.h: Add include guard.
15486         * darwin-nat.h: Rename include guard.
15487         * cp-abi.h: Rename include guard.
15488         * config/sparc/nm-sol2.h: Rename include guard.
15489         * config/nm-nto.h: Rename include guard.
15490         * config/nm-linux.h: Add include guard.
15491         * config/i386/nm-i386gnu.h: Rename include guard.
15492         * config/djgpp/nl_types.h: Rename include guard.
15493         * config/djgpp/langinfo.h: Rename include guard.
15494         * compile/gcc-cp-plugin.h: Add include guard.
15495         * compile/gcc-c-plugin.h: Add include guard.
15496         * compile/compile.h: Rename include guard.
15497         * compile/compile-object-run.h: Rename include guard.
15498         * compile/compile-object-load.h: Rename include guard.
15499         * compile/compile-internal.h: Rename include guard.
15500         * compile/compile-cplus.h: Rename include guard.
15501         * compile/compile-c.h: Rename include guard.
15502         * common/xml-utils.h: Rename include guard.
15503         * common/x86-xstate.h: Rename include guard.
15504         * common/version.h: Rename include guard.
15505         * common/vec.h: Rename include guard.
15506         * common/tdesc.h: Rename include guard.
15507         * common/selftest.h: Rename include guard.
15508         * common/scoped_restore.h: Rename include guard.
15509         * common/scoped_mmap.h: Rename include guard.
15510         * common/scoped_fd.h: Rename include guard.
15511         * common/safe-iterator.h: Rename include guard.
15512         * common/run-time-clock.h: Rename include guard.
15513         * common/refcounted-object.h: Rename include guard.
15514         * common/queue.h: Rename include guard.
15515         * common/ptid.h: Rename include guard.
15516         * common/print-utils.h: Rename include guard.
15517         * common/preprocessor.h: Rename include guard.
15518         * common/pathstuff.h: Rename include guard.
15519         * common/observable.h: Rename include guard.
15520         * common/netstuff.h: Rename include guard.
15521         * common/job-control.h: Rename include guard.
15522         * common/host-defs.h: Rename include guard.
15523         * common/gdb_wait.h: Rename include guard.
15524         * common/gdb_vecs.h: Rename include guard.
15525         * common/gdb_unlinker.h: Rename include guard.
15526         * common/gdb_unique_ptr.h: Rename include guard.
15527         * common/gdb_tilde_expand.h: Rename include guard.
15528         * common/gdb_sys_time.h: Rename include guard.
15529         * common/gdb_string_view.h: Rename include guard.
15530         * common/gdb_splay_tree.h: Rename include guard.
15531         * common/gdb_setjmp.h: Rename include guard.
15532         * common/gdb_ref_ptr.h: Rename include guard.
15533         * common/gdb_optional.h: Rename include guard.
15534         * common/gdb_locale.h: Rename include guard.
15535         * common/gdb_assert.h: Rename include guard.
15536         * common/filtered-iterator.h: Rename include guard.
15537         * common/filestuff.h: Rename include guard.
15538         * common/fileio.h: Rename include guard.
15539         * common/environ.h: Rename include guard.
15540         * common/common-utils.h: Rename include guard.
15541         * common/common-types.h: Rename include guard.
15542         * common/common-regcache.h: Rename include guard.
15543         * common/common-inferior.h: Rename include guard.
15544         * common/common-gdbthread.h: Rename include guard.
15545         * common/common-exceptions.h: Rename include guard.
15546         * common/common-defs.h: Rename include guard.
15547         * common/common-debug.h: Rename include guard.
15548         * common/cleanups.h: Rename include guard.
15549         * common/buffer.h: Rename include guard.
15550         * common/btrace-common.h: Rename include guard.
15551         * common/break-common.h: Rename include guard.
15552         * cli/cli-utils.h: Rename include guard.
15553         * cli/cli-style.h: Rename include guard.
15554         * cli/cli-setshow.h: Rename include guard.
15555         * cli/cli-script.h: Rename include guard.
15556         * cli/cli-interp.h: Rename include guard.
15557         * cli/cli-decode.h: Rename include guard.
15558         * cli/cli-cmds.h: Rename include guard.
15559         * charset-list.h: Add include guard.
15560         * buildsym-legacy.h: Rename include guard.
15561         * bfin-tdep.h: Add include guard.
15562         * ax.h: Rename include guard.
15563         * arm-linux-tdep.h: Add include guard.
15564         * arm-fbsd-tdep.h: Add include guard.
15565         * arch/xtensa.h: Rename include guard.
15566         * arch/tic6x.h: Add include guard.
15567         * arch/i386.h: Add include guard.
15568         * arch/arm.h: Rename include guard.
15569         * arch/arm-linux.h: Rename include guard.
15570         * arch/arm-get-next-pcs.h: Rename include guard.
15571         * arch/amd64.h: Add include guard.
15572         * arch/aarch64-insn.h: Rename include guard.
15573         * arch-utils.h: Rename include guard.
15574         * annotate.h: Add include guard.
15575         * amd64-darwin-tdep.h: Rename include guard.
15576         * aarch64-linux-tdep.h: Add include guard.
15577         * aarch64-fbsd-tdep.h: Add include guard.
15578         * aarch32-linux-nat.h: Add include guard.
15579
15580 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15581
15582         * macrotab.c (macro_define_internal): New function that
15583         factorizes macro_define_object_internal and macro_define_function
15584         code.
15585         (macro_define_object_internal): Use macro_define_internal.
15586         (macro_define_function): Likewise.
15587
15588 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15589
15590         * macrocmd.c (extract_identifier): Return
15591         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15592         callers.
15593
15594 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15595
15596         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15597
15598 2019-02-05  Tom Tromey  <tom@tromey.com>
15599
15600         * target.c (target_stack::unpush): Move assertion earlier.
15601
15602 2019-01-30  Tom Tromey  <tom@tromey.com>
15603
15604         PR python/23615:
15605         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15606         (gdbpy_parse_and_eval): Likewise.
15607         * python/python-internal.h (gdbpy_allow_threads): New class.
15608
15609 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15610
15611         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15612         (aarch64_fbsd_fpregmap): Move earlier.
15613         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15614         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15615         instead of individual calls to trad_frame_set_reg_addr.
15616         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15617         earlier.
15618         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15619         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15620         instead of individual calls to trad_frame_set_reg_addr.
15621
15622 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15623
15624         * CONTRIBUTE: Replace contribution list with wiki link.
15625
15626 2019-01-25  Tom Tromey  <tom@tromey.com>
15627
15628         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15629
15630 2019-01-25  Tom Tromey  <tom@tromey.com>
15631
15632         * xtensa-linux-nat.c: Fix common/ includes.
15633         * xml-support.h: Fix common/ includes.
15634         * xml-support.c: Fix common/ includes.
15635         * x86-linux-nat.c: Fix common/ includes.
15636         * windows-nat.c: Fix common/ includes.
15637         * varobj.h: Fix common/ includes.
15638         * varobj.c: Fix common/ includes.
15639         * value.c: Fix common/ includes.
15640         * valops.c: Fix common/ includes.
15641         * utils.c: Fix common/ includes.
15642         * unittests/xml-utils-selftests.c: Fix common/ includes.
15643         * unittests/utils-selftests.c: Fix common/ includes.
15644         * unittests/unpack-selftests.c: Fix common/ includes.
15645         * unittests/tracepoint-selftests.c: Fix common/ includes.
15646         * unittests/style-selftests.c: Fix common/ includes.
15647         * unittests/string_view-selftests.c: Fix common/ includes.
15648         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15649         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15650         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15651         * unittests/rsp-low-selftests.c: Fix common/ includes.
15652         * unittests/parse-connection-spec-selftests.c: Fix common/
15653         includes.
15654         * unittests/optional-selftests.c: Fix common/ includes.
15655         * unittests/offset-type-selftests.c: Fix common/ includes.
15656         * unittests/observable-selftests.c: Fix common/ includes.
15657         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15658         * unittests/memrange-selftests.c: Fix common/ includes.
15659         * unittests/memory-map-selftests.c: Fix common/ includes.
15660         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15661         * unittests/function-view-selftests.c: Fix common/ includes.
15662         * unittests/environ-selftests.c: Fix common/ includes.
15663         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15664         * unittests/common-utils-selftests.c: Fix common/ includes.
15665         * unittests/cli-utils-selftests.c: Fix common/ includes.
15666         * unittests/array-view-selftests.c: Fix common/ includes.
15667         * ui-file.c: Fix common/ includes.
15668         * tui/tui-io.c: Fix common/ includes.
15669         * tracepoint.h: Fix common/ includes.
15670         * tracepoint.c: Fix common/ includes.
15671         * tracefile-tfile.c: Fix common/ includes.
15672         * top.h: Fix common/ includes.
15673         * top.c: Fix common/ includes.
15674         * thread.c: Fix common/ includes.
15675         * target/waitstatus.h: Fix common/ includes.
15676         * target/waitstatus.c: Fix common/ includes.
15677         * target.h: Fix common/ includes.
15678         * target.c: Fix common/ includes.
15679         * target-memory.c: Fix common/ includes.
15680         * target-descriptions.c: Fix common/ includes.
15681         * symtab.h: Fix common/ includes.
15682         * symfile.c: Fix common/ includes.
15683         * stap-probe.c: Fix common/ includes.
15684         * spu-linux-nat.c: Fix common/ includes.
15685         * sparc-nat.c: Fix common/ includes.
15686         * source.c: Fix common/ includes.
15687         * solib.c: Fix common/ includes.
15688         * solib-target.c: Fix common/ includes.
15689         * ser-unix.c: Fix common/ includes.
15690         * ser-tcp.c: Fix common/ includes.
15691         * ser-pipe.c: Fix common/ includes.
15692         * ser-base.c: Fix common/ includes.
15693         * selftest-arch.c: Fix common/ includes.
15694         * s12z-tdep.c: Fix common/ includes.
15695         * rust-exp.y: Fix common/ includes.
15696         * rs6000-aix-tdep.c: Fix common/ includes.
15697         * riscv-tdep.c: Fix common/ includes.
15698         * remote.c: Fix common/ includes.
15699         * remote-notif.h: Fix common/ includes.
15700         * remote-fileio.h: Fix common/ includes.
15701         * remote-fileio.c: Fix common/ includes.
15702         * regcache.h: Fix common/ includes.
15703         * regcache.c: Fix common/ includes.
15704         * record-btrace.c: Fix common/ includes.
15705         * python/python.c: Fix common/ includes.
15706         * python/py-type.c: Fix common/ includes.
15707         * python/py-inferior.c: Fix common/ includes.
15708         * progspace.h: Fix common/ includes.
15709         * producer.c: Fix common/ includes.
15710         * procfs.c: Fix common/ includes.
15711         * proc-api.c: Fix common/ includes.
15712         * printcmd.c: Fix common/ includes.
15713         * ppc-linux-nat.c: Fix common/ includes.
15714         * parser-defs.h: Fix common/ includes.
15715         * osdata.c: Fix common/ includes.
15716         * obsd-nat.c: Fix common/ includes.
15717         * nat/x86-linux.c: Fix common/ includes.
15718         * nat/x86-linux-dregs.c: Fix common/ includes.
15719         * nat/x86-dregs.h: Fix common/ includes.
15720         * nat/x86-dregs.c: Fix common/ includes.
15721         * nat/ppc-linux.c: Fix common/ includes.
15722         * nat/mips-linux-watch.h: Fix common/ includes.
15723         * nat/mips-linux-watch.c: Fix common/ includes.
15724         * nat/linux-waitpid.c: Fix common/ includes.
15725         * nat/linux-ptrace.h: Fix common/ includes.
15726         * nat/linux-ptrace.c: Fix common/ includes.
15727         * nat/linux-procfs.c: Fix common/ includes.
15728         * nat/linux-personality.c: Fix common/ includes.
15729         * nat/linux-osdata.c: Fix common/ includes.
15730         * nat/linux-namespaces.c: Fix common/ includes.
15731         * nat/linux-btrace.h: Fix common/ includes.
15732         * nat/linux-btrace.c: Fix common/ includes.
15733         * nat/fork-inferior.c: Fix common/ includes.
15734         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15735         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15736         * nat/aarch64-linux.c: Fix common/ includes.
15737         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15738         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15739         * namespace.h: Fix common/ includes.
15740         * mips-linux-tdep.c: Fix common/ includes.
15741         * minsyms.c: Fix common/ includes.
15742         * mi/mi-parse.h: Fix common/ includes.
15743         * mi/mi-main.c: Fix common/ includes.
15744         * mi/mi-cmd-env.c: Fix common/ includes.
15745         * memrange.h: Fix common/ includes.
15746         * memattr.c: Fix common/ includes.
15747         * maint.h: Fix common/ includes.
15748         * maint.c: Fix common/ includes.
15749         * main.c: Fix common/ includes.
15750         * machoread.c: Fix common/ includes.
15751         * location.c: Fix common/ includes.
15752         * linux-thread-db.c: Fix common/ includes.
15753         * linux-nat.c: Fix common/ includes.
15754         * linux-fork.c: Fix common/ includes.
15755         * inline-frame.c: Fix common/ includes.
15756         * infrun.c: Fix common/ includes.
15757         * inflow.c: Fix common/ includes.
15758         * inferior.h: Fix common/ includes.
15759         * inferior.c: Fix common/ includes.
15760         * infcmd.c: Fix common/ includes.
15761         * inf-ptrace.c: Fix common/ includes.
15762         * inf-child.c: Fix common/ includes.
15763         * ia64-linux-nat.c: Fix common/ includes.
15764         * i387-tdep.c: Fix common/ includes.
15765         * i386-tdep.c: Fix common/ includes.
15766         * i386-linux-tdep.c: Fix common/ includes.
15767         * i386-linux-nat.c: Fix common/ includes.
15768         * i386-go32-tdep.c: Fix common/ includes.
15769         * i386-fbsd-tdep.c: Fix common/ includes.
15770         * i386-fbsd-nat.c: Fix common/ includes.
15771         * guile/scm-type.c: Fix common/ includes.
15772         * guile/guile.c: Fix common/ includes.
15773         * go32-nat.c: Fix common/ includes.
15774         * gnu-nat.c: Fix common/ includes.
15775         * gdbthread.h: Fix common/ includes.
15776         * gdbarch-selftests.c: Fix common/ includes.
15777         * gdb_usleep.c: Fix common/ includes.
15778         * gdb_select.h: Fix common/ includes.
15779         * gdb_bfd.c: Fix common/ includes.
15780         * gcore.c: Fix common/ includes.
15781         * fork-child.c: Fix common/ includes.
15782         * findvar.c: Fix common/ includes.
15783         * fbsd-nat.c: Fix common/ includes.
15784         * event-top.c: Fix common/ includes.
15785         * event-loop.c: Fix common/ includes.
15786         * dwarf2read.c: Fix common/ includes.
15787         * dwarf2loc.c: Fix common/ includes.
15788         * dwarf2-frame.c: Fix common/ includes.
15789         * dwarf-index-cache.c: Fix common/ includes.
15790         * dtrace-probe.c: Fix common/ includes.
15791         * disasm-selftests.c: Fix common/ includes.
15792         * defs.h: Fix common/ includes.
15793         * csky-tdep.c: Fix common/ includes.
15794         * cp-valprint.c: Fix common/ includes.
15795         * cp-support.h: Fix common/ includes.
15796         * cp-support.c: Fix common/ includes.
15797         * corelow.c: Fix common/ includes.
15798         * completer.h: Fix common/ includes.
15799         * completer.c: Fix common/ includes.
15800         * compile/compile.c: Fix common/ includes.
15801         * compile/compile-loc2c.c: Fix common/ includes.
15802         * compile/compile-cplus-types.c: Fix common/ includes.
15803         * compile/compile-cplus-symbols.c: Fix common/ includes.
15804         * command.h: Fix common/ includes.
15805         * cli/cli-dump.c: Fix common/ includes.
15806         * cli/cli-cmds.c: Fix common/ includes.
15807         * charset.c: Fix common/ includes.
15808         * build-id.c: Fix common/ includes.
15809         * btrace.h: Fix common/ includes.
15810         * btrace.c: Fix common/ includes.
15811         * breakpoint.h: Fix common/ includes.
15812         * breakpoint.c: Fix common/ includes.
15813         * ax.h:
15814         (enum agent_op): Fix common/ includes.
15815         * ax-general.c (struct aop_map): Fix common/ includes.
15816         * ax-gdb.c: Fix common/ includes.
15817         * auxv.c: Fix common/ includes.
15818         * auto-load.c: Fix common/ includes.
15819         * arm-tdep.c: Fix common/ includes.
15820         * arch/riscv.c: Fix common/ includes.
15821         * arch/ppc-linux-common.c: Fix common/ includes.
15822         * arch/i386.c: Fix common/ includes.
15823         * arch/arm.c: Fix common/ includes.
15824         * arch/arm-linux.c: Fix common/ includes.
15825         * arch/arm-get-next-pcs.c: Fix common/ includes.
15826         * arch/amd64.c: Fix common/ includes.
15827         * arch/aarch64.c: Fix common/ includes.
15828         * arch/aarch64-insn.c: Fix common/ includes.
15829         * arch-utils.c: Fix common/ includes.
15830         * amd64-windows-tdep.c: Fix common/ includes.
15831         * amd64-tdep.c: Fix common/ includes.
15832         * amd64-sol2-tdep.c: Fix common/ includes.
15833         * amd64-obsd-tdep.c: Fix common/ includes.
15834         * amd64-nbsd-tdep.c: Fix common/ includes.
15835         * amd64-linux-tdep.c: Fix common/ includes.
15836         * amd64-linux-nat.c: Fix common/ includes.
15837         * amd64-fbsd-tdep.c: Fix common/ includes.
15838         * amd64-fbsd-nat.c: Fix common/ includes.
15839         * amd64-dicos-tdep.c: Fix common/ includes.
15840         * amd64-darwin-tdep.c: Fix common/ includes.
15841         * agent.c: Fix common/ includes.
15842         * ada-lang.h: Fix common/ includes.
15843         * ada-lang.c: Fix common/ includes.
15844         * aarch64-tdep.c: Fix common/ includes.
15845
15846 2019-01-25  Tom Tromey  <tom@tromey.com>
15847
15848         * common/create-version.sh: Use common/version.h.
15849
15850 2019-01-24  Pedro Alves  <palves@redhat.com>
15851
15852         * infrun.c (signal_stop, signal_print, signal_program)
15853         (signal_catch, signal_pass): Now arrays instead of pointers.
15854         (update_signals_program_target, do_target_resume)
15855         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15856         * linux-nat.c (linux_nat_target::pass_signals)
15857         (linux_nat_target::create_inferior, linux_nat_target::attach):
15858         Adjust.
15859         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15860         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15861         * procfs.c (procfs_target::pass_signals): Adjust.
15862         * record-full.c (record_full_target::resume): Adjust.
15863         * remote.c (remote_target::pass_signals)
15864         (remote_target::program_signals): Adjust.
15865         * target-debug.h (target_debug_print_signals): Now takes a
15866         gdb::array_view as parameter.  Adjust.
15867         * target.h (target_ops) <pass_signals, program_signals>: Replace
15868         pointer and length parameters with gdb::array_view.
15869         (target_pass_signals, target_program_signals): Likewise.
15870         * target-delegates.c: Regenerate.
15871
15872 2019-01-24  Pedro Alves  <palves@redhat.com>
15873
15874         * common/forward-scope-exit.h
15875         (forward_scope_exit::forward_scope_exit): Pass arguments to
15876         m_bind_function directly, instead of creating a std::bind and
15877         copying that.
15878
15879 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15880
15881         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15882         for static members.
15883         (pass_in_v_vfp_candidate): Likewise.
15884
15885 2019-01-23  Tom Tromey  <tom@tromey.com>
15886             Pedro Alves  <palves@redhat.com>
15887
15888         * regcache.c (class regcache_invalidator): Remove.
15889         (regcache::raw_write): Use make_scope_exit.
15890
15891 2019-01-23  Tom Tromey  <tom@tromey.com>
15892
15893         * ui-out.h (class ui_out_emit_type): Update comment.
15894
15895 2019-01-23  Tom Tromey  <tom@tromey.com>
15896
15897         * infrun.c (fetch_inferior_event): Update comment.
15898
15899 2019-01-23  Tom Tromey  <tom@tromey.com>
15900             Pedro Alves  <palves@redhat.com>
15901
15902         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15903         parameter.
15904         (fetch_inferior_event): Use SCOPE_EXIT.
15905
15906
15907 2019-01-23  Tom Tromey  <tom@tromey.com>
15908             Pedro Alves  <palves@redhat.com>
15909
15910         * infrun.c (disable_thread_events): Delete.
15911         (stop_all_threads): Use SCOPE_EXIT.
15912
15913 2019-01-23  Tom Tromey  <tom@tromey.com>
15914             Pedro Alves  <palves@redhat.com>
15915
15916         * symfile.c: Include forward-scope-exit.h.
15917         (clear_symtab_users_cleanup): Replace forward declaration with
15918         a FORWARD_SCOPE_EXIT.
15919         (syms_from_objfile_1): Use the forward_scope_exit and
15920         gdb::optional instead of cleanup_function.
15921         (reread_symbols): Use the forward_scope_exit instead of
15922         cleanup_function.
15923         (clear_symtab_users_cleanup): Remove function.
15924
15925 2019-01-23  Tom Tromey  <tom@tromey.com>
15926             Pedro Alves  <palves@redhat.com>
15927
15928         * linux-nat.c: Include scope-exit.h.
15929         (cleanup_target_stop): Remove.
15930         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15931         SCOPE_EXIT.
15932
15933 2019-01-23  Tom Tromey  <tom@tromey.com>
15934             Pedro Alves  <palves@redhat.com>
15935
15936         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15937         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15938
15939 2019-01-23  Tom Tromey  <tom@tromey.com>
15940             Andrew Burgess  <andrew.burgess@embecosm.com>
15941             Pedro Alves  <palves@redhat.com>
15942
15943         * infrun.c (fetch_inferior_event): Use scope_exit.
15944         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15945         * top.c (execute_command): Use scope_exit.
15946         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15947         * utils.c (do_bpstat_clear_actions_cleanup)
15948         (make_bpstat_clear_actions_cleanup): Remove.
15949
15950 2019-01-23  Tom Tromey  <tom@tromey.com>
15951             Pedro Alves  <palves@redhat.com>
15952
15953         * infrun.c: Include "common/scope-exit.h"
15954         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15955         (wait_for_inferior): Use SCOPE_EXIT.
15956         (fetch_inferior_event): Use scope_exit.
15957
15958 2019-01-23  Tom Tromey  <tom@tromey.com>
15959             Pedro Alves  <palves@redhat.com>
15960
15961         * breakpoint.c (create_breakpoint): Remove cleanup.
15962
15963 2019-01-23  Tom Tromey  <tom@tromey.com>
15964             Andrew Burgess  <andrew.burgess@embecosm.com>
15965             Pedro Alves  <palves@redhat.com>
15966
15967 2019-01-23  Pedro Alves  <palves@redhat.com>
15968
15969         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15970
15971 2019-01-23  Pedro Alves  <palves@redhat.com>
15972             Andrew Burgess  <andrew.burgess@embecosm.com>
15973
15974         * gdbthread.h: Include "common/forward-scope-exit.h".
15975         (scoped_finish_thread_state): Redefine custom class in terms of
15976         forward_scope_exit.
15977
15978 2019-01-23  Pedro Alves  <palves@redhat.com>
15979             Andrew Burgess  <andrew.burgess@embecosm.com>
15980
15981         * common/forward-scope-exit.h: New file.
15982
15983 2019-01-23  Pedro Alves  <palves@redhat.com>
15984             Andrew Burgess  <andrew.burgess@embecosm.com>
15985             Tom Tromey  <tom@tromey.com>
15986
15987         * common/scope-exit.h: New file.
15988
15989 2019-01-23  Pedro Alves  <palves@redhat.com>
15990
15991         * common/preprocessor.h (ESC): Rename to ...
15992         (ESC_PARENS): ... this.
15993         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15994         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15995
15996 2019-01-23  Tom Tromey  <tom@tromey.com>
15997
15998         * language.h (class scoped_switch_to_sym_language_if_auto):
15999         Initialize m_lang in both cases.
16000
16001 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
16002
16003         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
16004         with XCNEW.
16005
16006 2019-01-22  Tom Tromey  <tom@tromey.com>
16007
16008         * corelow.c: Do not include sys/file.h.
16009
16010 2019-01-22  Tom Tromey  <tom@tromey.com>
16011
16012         * tui/tui-wingeneral.h: Include gdb_curses.h.
16013
16014 2019-01-22  Tom Tromey  <tom@tromey.com>
16015
16016         * source-cache.h (class source_cache) <get_source_lines,
16017         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16018
16019 2019-01-22  Tom Tromey  <tom@tromey.com>
16020
16021         * remote-fileio.h (struct remote_target): Declare.
16022
16023 2019-01-22  Tom Tromey  <tom@tromey.com>
16024
16025         * python/py-arch.c: Do not include py-ref.h.
16026         * python/py-bpevent.c: Do not include py-ref.h.
16027         * python/py-cmd.c: Do not include py-ref.h.
16028         * python/py-continueevent.c: Do not include py-ref.h.
16029         * python/py-event.h: Do not include py-ref.h.
16030         * python/py-evtregistry.c: Do not include py-ref.h.
16031         * python/py-finishbreakpoint.c: Do not include py-ref.h.
16032         * python/py-frame.c: Do not include py-ref.h.
16033         * python/py-framefilter.c: Do not include py-ref.h.
16034         * python/py-function.c: Do not include py-ref.h.
16035         * python/py-infevents.c: Do not include py-ref.h.
16036         * python/py-linetable.c: Do not include py-ref.h.
16037         * python/py-objfile.c: Do not include py-ref.h.
16038         * python/py-param.c: Do not include py-ref.h.
16039         * python/py-prettyprint.c: Do not include py-ref.h.
16040         * python/py-progspace.c: Do not include py-ref.h.
16041         * python/py-symbol.c: Do not include py-ref.h.
16042         * python/py-symtab.c: Do not include py-ref.h.
16043         * python/py-type.c: Do not include py-ref.h.
16044         * python/py-unwind.c: Do not include py-ref.h.
16045         * python/py-utils.c: Do not include py-ref.h.
16046         * python/py-value.c: Do not include py-ref.h.
16047         * python/py-varobj.c: Do not include py-ref.h.
16048         * python/py-xmethods.c: Do not include py-ref.h.
16049         * python/python.c: Do not include py-ref.h.
16050         * varobj.c: Do not include py-ref.h.
16051
16052 2019-01-22  Tom Tromey  <tom@tromey.com>
16053
16054         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16055         keyword for bcache.
16056
16057 2019-01-22  Tom Tromey  <tom@tromey.com>
16058
16059         * compile/compile-cplus-types.c: Remove a comment by #include.
16060
16061 2019-01-22  Tom Tromey  <tom@tromey.com>
16062
16063         * compile/gcc-c-plugin.h: Include compile-internal.h.
16064
16065 2019-01-22  Tom Tromey  <tom@tromey.com>
16066
16067         * stabsread.c (EXTERN): Do not define.
16068         (symnum, next_symbol_text_func, processing_gcc_compilation)
16069         (within_function, global_sym_chain, global_stabs)
16070         (previous_stab_code, this_object_header_files)
16071         (n_this_object_header_files)
16072         (n_allocated_this_object_header_files): Define.
16073         * stabsread.h (EXTERN): Never define.  Use "extern".
16074
16075 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16076
16077         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16078         history_value.
16079
16080 2019-01-21  Tom Tromey  <tom@tromey.com>
16081
16082         * ui-out.c: Fix includes.
16083         * tui/tui-source.c: Fix includes.
16084         * target.c: Fix includes.
16085         * remote.c: Fix includes.
16086         * regcache.c: Fix includes.
16087         * python/py-block.c: Fix includes.
16088         * printcmd.c: Fix includes.
16089         * or1k-tdep.c: Fix includes.
16090         * mi/mi-main.c: Fix includes.
16091         * m32r-tdep.c: Fix includes.
16092         * csky-tdep.c: Fix includes.
16093         * compile/compile-cplus-types.c: Fix includes.
16094         * cli/cli-interp.c: Fix includes.
16095
16096 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16097
16098         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16099         for padding.
16100
16101 2019-01-16  Tom Tromey  <tom@tromey.com>
16102
16103         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16104         earlier.
16105         (struct objfile) <msymbols_range>: Move from top level.
16106         <msymbols>: New method.
16107         (class objfile_msymbols): Remove.
16108         * symtab.c (default_collect_symbol_completion_matches_break_on):
16109         Update.
16110         * symmisc.c (dump_msymbols): Update.
16111         * stabsread.c (scan_file_globals): Update.
16112         * objc-lang.c (info_selectors_command, info_classes_command)
16113         (find_methods): Update.
16114         * minsyms.c (find_solib_trampoline_target): Update.
16115         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16116         * coffread.c (coff_symfile_read): Update.
16117         * ada-lang.c (ada_lookup_simple_minsym)
16118         (ada_collect_symbol_completion_matches): Update.
16119
16120 2019-01-16  Tom Tromey  <tom@tromey.com>
16121
16122         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16123         type.  Remove no-argument constructor.
16124         <iterator::operator++>: Simplify.
16125         <begin>: Update.
16126         <end>: Use minimal_symbol_count.
16127
16128 2019-01-16  Tom Tromey  <tom@tromey.com>
16129
16130         * objfiles.h (struct objfile) <psymtabs>: New method.
16131         (class objfile_psymtabs): Remove.
16132         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16133         typedef.
16134         <range>: New method.
16135         (require_partial_symbols): Change return type.
16136         * psymtab.c (require_partial_symbols)
16137         (psym_expand_symtabs_matching): Update.
16138         * mdebugread.c (parse_partial_symbols): Update.
16139         * dbxread.c (dbx_end_psymtab): Update.
16140
16141 2019-01-15  Tom Tromey  <tom@tromey.com>
16142
16143         * symtab.c (lookup_objfile_from_block)
16144         (lookup_symbol_in_objfile_symtabs)
16145         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16146         (find_line_symtab, info_sources_command)
16147         (default_collect_symbol_completion_matches_break_on)
16148         (make_source_files_completion_list): Update.
16149         * symmisc.c (print_objfile_statistics, dump_objfile)
16150         (maintenance_print_symbols, maintenance_info_symtabs)
16151         (maintenance_check_symtabs, maintenance_info_line_tables):
16152         Update.
16153         * source.c (select_source_symtab)
16154         (forget_cached_source_info_for_objfile): Update.
16155         * objfiles.h (class objfile_compunits): Remove.
16156         (struct objfile) <compunits_range>: New typedef.
16157         (compunits): New method.
16158         * objfiles.c (objfile_relocate1): Update.
16159         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16160         * maint.c (count_symtabs_and_blocks): Update.
16161         * linespec.c (iterate_over_all_matching_symtabs): Update.
16162         * cp-support.c (add_symbol_overload_list_qualified): Update.
16163         * coffread.c (coff_symtab_read): Update.
16164         * ada-lang.c (add_nonlocal_symbols)
16165         (ada_collect_symbol_completion_matches)
16166         (ada_add_global_exceptions): Update.
16167
16168 2019-01-15  Tom Tromey  <tom@tromey.com>
16169
16170         * progspace.h (program_space) <objfiles_safe_range>: New
16171         typedef.
16172         <objfiles_safe>: New method.
16173         * objfiles.h (class all_objfiles_safe): Remove.
16174         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16175         * jit.c (jit_inferior_exit_hook): Update.
16176
16177 2019-01-17  Tom Tromey  <tom@tromey.com>
16178
16179         * progspace.h (program_space) <objfiles_range>: New typedef.
16180         <objfiles>: New method.
16181         <objfiles_head>: Rename from objfiles.
16182         (object_files): Update.
16183         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16184         * guile/scm-pretty-print.c
16185         (ppscm_find_pretty_printer_from_objfiles): Update.
16186         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16187         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16188         Update.
16189         * python/py-progspace.c (pspy_get_objfiles): Update.
16190         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16191         Update.
16192         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16193         (objfpy_lookup_objfile_by_build_id): Update.
16194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16195         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16196         Update.
16197         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16198         (expand_symtab_containing_pc, lookup_objfile_from_block)
16199         (lookup_static_symbol, basic_lookup_transparent_type)
16200         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16201         (find_line_symtab, info_sources_command)
16202         (default_collect_symbol_completion_matches_break_on)
16203         (make_source_files_completion_list, find_main_name): Update.
16204         * symmisc.c (print_symbol_bcache_statistics)
16205         (print_objfile_statistics, maintenance_print_symbols)
16206         (maintenance_print_msymbols, maintenance_print_objfiles)
16207         (maintenance_info_symtabs, maintenance_check_symtabs)
16208         (maintenance_expand_symtabs, maintenance_info_line_tables):
16209         Update.
16210         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16211         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16212         (map_overlay_command, unmap_overlay_command)
16213         (simple_overlay_update, expand_symtabs_matching)
16214         (map_symbol_filenames): Update.
16215         * symfile-debug.c (set_debug_symfile): Update.
16216         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16217         Update.
16218         * source.c (select_source_symtab, forget_cached_source_info):
16219         Update.
16220         * solib.c (solib_read_symbols): Update.
16221         * solib-spu.c (append_ocl_sos): Update.
16222         * psymtab.c (maintenance_print_psymbols)
16223         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16224         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16225         * printcmd.c (info_symbol_command): Update.
16226         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16227         Update.
16228         * objfiles.h (class all_objfiles): Remove.
16229         * objfiles.c (have_partial_symbols, have_full_symbols)
16230         (have_minimal_symbols, qsort_cmp, update_section_map)
16231         (shared_objfile_contains_address_p)
16232         (default_iterate_over_objfiles_in_search_order): Update.
16233         * objc-lang.c (info_selectors_command, info_classes_command)
16234         (find_methods): Update.
16235         * minsyms.c (find_solib_trampoline_target): Update.
16236         * maint.c (maintenance_info_sections)
16237         (maintenance_translate_address, count_symtabs_and_blocks):
16238         Update.
16239         * main.c (captured_main_1): Update.
16240         * linux-thread-db.c (try_thread_db_load_from_pdir)
16241         (has_libpthread): Update.
16242         * linespec.c (iterate_over_all_matching_symtabs)
16243         (search_minsyms_for_name): Update.
16244         * jit.c (jit_find_objf_with_entry_addr): Update.
16245         * hppa-tdep.c (find_unwind_entry)
16246         (hppa_lookup_stub_minimal_symbol): Update.
16247         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16248         Update.
16249         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16250         (elf_gnu_ifunc_resolve_by_got): Update.
16251         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16252         * dwarf-index-write.c (save_gdb_index_command): Update.
16253         * cp-support.c (add_symbol_overload_list_qualified): Update.
16254         * breakpoint.c (create_overlay_event_breakpoint)
16255         (create_longjmp_master_breakpoint)
16256         (create_std_terminate_master_breakpoint)
16257         (create_exception_master_breakpoint): Update.
16258         * blockframe.c (find_pc_partial_function): Update.
16259         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16260         (ada_collect_symbol_completion_matches)
16261         (ada_add_global_exceptions): Update.
16262
16263 2019-01-17  Tom Tromey  <tom@tromey.com>
16264
16265         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16266         declare VEC.
16267         (solib_target_parse_libraries): Change return type.
16268         (library_list_start_segment, library_list_start_section)
16269         (library_list_end_library, library_list_start_library); Update.
16270         (solib_target_free_library_list): Remove.
16271         (solib_target_parse_libraries): Remove cleanup.  Change return
16272         type.
16273         (solib_target_current_sos): Update.
16274
16275 2019-01-17  Tom Tromey  <tromey@bapiya>
16276
16277         * valprint.c: Replace "the the" with "the".
16278         * symtab.c: Replace "the the" with "the".
16279         * solib.c: Replace "the the" with "the".
16280         * solib-dsbt.c: Replace "the the" with "the".
16281         * linespec.c: Replace "the the" with "the".
16282         * dwarf2loc.h: Replace "the the" with "the".
16283         * amd64-windows-tdep.c: Replace "the the" with "the".
16284         * aarch64-tdep.c: Replace "the the" with "the".
16285
16286 2019-01-16  Keith Seitz  <keiths@redhat.com>
16287
16288         PR gdb/23773
16289         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16290         <builder>: Rename to ..
16291         <m_builder>: ... this and make private.
16292         (dwarf2_cu::get_builder): New method.  Change all users of
16293         `builder' to use this method.
16294         (dwarf2_start_symtab): Move to ...
16295         (dwarf2_cu::start_symtab): ... here.  Update all callers
16296         (setup_type_unit_groups): Move to ...
16297         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16298         callers.
16299         (dwarf2_cu::reset_builder): New method.
16300         (process_full_compunit, process_full_type_unit): Use
16301         dwarf2_cu::reset_builder.
16302         (follow_die_offset): Record the ancestor CU if it is different
16303         from the followed DIE's CU.
16304         (follow_die_sig_1): Likewise.
16305
16306 2019-01-15  Tom Tromey  <tom@tromey.com>
16307
16308         * remote.c (class remote_state) <buf>: Now a char_vector.
16309         <buf_size>: Remove.
16310         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16311         parameter.
16312         (remote_target::getpkt_or_notif_sane_1)
16313         (remote_target::getpkt_sane)
16314         (remote_target::getpkt_or_notif_sane): Likewise.
16315         (class remote_target) <putpkt>: New overload.
16316         (remote_target::read_frame): Change type of "buf_p".  Remove
16317         sizeof_p parameter.
16318         (packet_ok): New overload.
16319         (packet_check_result): New overload.
16320         Update all uses.
16321
16322 2019-01-14  Tom Tromey  <tom@tromey.com>
16323
16324         * remote-notif.c (handle_notification, remote_notif_ack)
16325         (remote_notif_parse): Make "buf" const.
16326         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16327         const.
16328         (remote_notif_parse, remote_notif_ack, handle_notification):
16329         Likewise.
16330         * remote.c (remote_notif_stop_parse): Make "buf" const.
16331         (remote_target::remote_parse_stop_reply): Make "buf" const.
16332         (remote_notif_stop_ack): Make "buf" const.
16333
16334 2019-01-14  Tom Tromey  <tom@tromey.com>
16335
16336         * remote.c (remote_console_output): Make parameter const.
16337
16338 2019-01-14  Tom Tromey  <tom@tromey.com>
16339
16340         * target-debug.h (target_debug_print_signals): Constify.
16341         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16342         * procfs.c (procfs_target::pass_signals): Update.
16343         * linux-nat.c (linux_nat_target::pass_signals): Update.
16344         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16345         * target-delegates.c: Rebuild.
16346         * remote.c (remote_target::program_signals): Update.
16347         (remote_target::pass_signals): Update.
16348         * target.c (target_pass_signals): Constify argument.
16349         (target_program_signals): Likewise.
16350         * target.h (struct target_ops) <pass_signals, program_signals>:
16351         Constify argument.
16352         (target_pass_signals, target_program_signals): Constify argument.
16353
16354 2019-01-14  Tom Tromey  <tom@tromey.com>
16355
16356         PR tui/28819:
16357         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16358
16359 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16360
16361         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16362         field.
16363         * rs6000-tdep.c: Include reggroups.h.
16364         (IS_V_ALIAS_PSEUDOREG): Define.
16365         (rs6000_register_name): Return names for the "vX" aliases.
16366         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16367         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16368         aliases.  Call default_register_reggroup_p for all other
16369         pseudo-registers.
16370         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16371         New functions.
16372         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16373         Handle "vX" aliases.
16374         (v_alias_pseudo_register_collect): New function.
16375         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16376         (rs6000_gdbarch_init): Initialize "vX" aliases as
16377         pseudo-registers.  Restore registration of
16378         rs6000_pseudo_register_reggroup_p with
16379         set_tdesc_pseudo_register_reggroup_p.
16380
16381 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16382
16383         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16384         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16385         set_gdbarch_num_pseudo_regs.
16386
16387 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16388
16389         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16390         Remove arg prefixname, add do_set and do_show.
16391         Add member functions set_list and show_list.
16392         * cli/cli-style.c (class cli_style_option): Update accordingly.
16393         (style_set_list): Move to file scope.
16394         (style_show_list): Likewise.
16395         (set_style): Call help_list.
16396         (show_style): Call cmd_show_list.
16397         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16398         Update to use the new macro.
16399
16400 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16401
16402         * ada-lang.c (_initialize_ada_language): Expand the help text
16403         for the "catch exception" command.
16404
16405 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16406
16407         * symtab.c (matching_obj_sections): Initialize obj,
16408         declare it closer to its usage.
16409
16410 2019-01-10  Tom Tromey  <tom@tromey.com>
16411
16412         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16413         (basic_inf_threads_range): Remove.
16414         (inf_threads_range, inf_non_exited_threads_range)
16415         (safe_inf_threads_range): Use next_adapter.
16416
16417 2019-01-10  Keith Seitz  <keiths@redhat.com>
16418
16419         PR gdb/23712
16420         PR symtab/23010
16421         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16422         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16423
16424 2019-01-10  Keith Seitz  <keiths@redhat.com>
16425
16426         PR gdb/23712
16427         PR symtab/23010
16428         * dictionary.c (pending_to_vector): Remove.
16429         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16430         Remove _1 suffix, replacing functions of the same name.  Update
16431         all callers.
16432         (dict_create_hashed, dict_create_hashed_expandable)
16433         (dict_create_linear, dict_create_linear_expandable, dict_free)
16434         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16435         Make functions static.
16436
16437 2019-01-10  Keith Seitz  <keiths@redhat.com>
16438
16439         PR gdb/23712
16440         PR symtab/23010
16441         * dictionary.h (struct dictionary): Replace declaration with
16442         multidictionary.
16443         (dict_create_hashed, dict_create_hashed_expandable)
16444         (dict_create_linear, dict_create_linear_expandable)
16445         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16446         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16447         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16448         taking multidictionary argument.
16449         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16450         * block.h (struct block) <dict>: Change to multidictionary
16451         and rename `multidict'.
16452         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16453         symmisc.c: Update all dictionary references to multidictionary.
16454
16455 2019-01-10  Keith Seitz  <keiths@redhat.com>
16456
16457         PR gdb/23712
16458         PR symtab/23010
16459         * dictionary.c: Include unordered_map.
16460         (pending_to_vector): New function.
16461         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16462         Rewrite the non-"_1" functions to take vector instead
16463         of linked list.
16464         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16465         "new" _1 versions of the same name.
16466         (multidictionary): Define.
16467         (std::hash<enum language): New definition.
16468         (collate_pending_symbols_by_language, mdict_create_hashed)
16469         (mdict_create_hashed_expandable, mdict_create_linear)
16470         (mdict_create_linear_expandable, mdict_free)
16471         (find_language_dictionary, create_new_language_dictionary)
16472         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16473         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16474         (mdict_size, mdict_empty): New functions.
16475         * dictionary.h (mdict_iterator): Define.
16476
16477 2019-01-10  Pedro Alves  <palves@redhat.com>
16478
16479         * breakpoint.c (read_uploaded_action)
16480         (create_tracepoint_from_upload): Adjust to use
16481         gdb::unique_xmalloc_ptr.
16482         * ctf.c (ctf_write_uploaded_tp):
16483         (SET_ARRAY_FIELD): Use emplace_back.
16484         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16485         * tracefile-tfile.c (tfile_write_uploaded_tp):
16486         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16487         gdb::unique_xmalloc_ptr.
16488         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16489         at_string, cond_string, cmd_strings>: Replace char pointers
16490         with gdb::unique_xmalloc_ptr.
16491
16492 2019-01-10  Pedro Alves  <palves@redhat.com>
16493
16494         * solib-target.c (library_list_start_library): Don't xstrdup name.
16495
16496 2019-01-10  Pedro Alves  <palves@redhat.com>
16497
16498         * mdebugread.c (parse_partial_symbols): Use
16499         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16500
16501 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16502
16503         * linux-fork.c (scoped_switch_fork_info)
16504         <~scoped_switch_fork_info>: Fix incorrect variable name.
16505
16506 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16507
16508         * linux-fork.c (scoped_switch_fork_info)
16509         <scoped_switch_fork_info>: Make explicit.
16510         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16511
16512 2019-01-10  Tom Tromey  <tom@tromey.com>
16513
16514         * objfiles.h (objfile::reset_psymtabs): Update.
16515         * objfiles.c (objfile::objfile): Update.
16516         * psymtab.h (psymtab_storage::obstack): Update.
16517         (psymtab_storage::m_obstack): Use gdb::optional.
16518         (class psymtab_storage): Update comment.  Remove objfile
16519         parameter.
16520         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16521
16522 2019-01-10  Tom Tromey  <tom@tromey.com>
16523
16524         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16525         <free_psymtabs>: Now private.
16526         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16527         (allocate_psymtab): Use new method.
16528
16529 2019-01-10  Tom Tromey  <tom@tromey.com>
16530
16531         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16532         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16533         * mdebugread.c (parse_partial_symbols): Use
16534         allocate_dependencies.
16535         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16536         allocate_dependencies.
16537         (process_psymtab_comp_unit_reader)
16538         (build_type_psymtab_dependencies): Likewise.
16539         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16540
16541 2019-01-10  Tom Tromey  <tom@tromey.com>
16542
16543         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16544         PSYMBOL_SET_LANGUAGE.
16545         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16546
16547 2019-01-10  Tom Tromey  <tom@tromey.com>
16548
16549         * psymtab.h (psymtab_storage::obstack): New method.
16550         <m_obstack>: Rename from obstack; now private.
16551         * psymtab.c (psymtab_storage): Update.
16552         * dwarf2read.c (create_addrmap_from_index)
16553         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16554         Update.
16555
16556 2019-01-10  Tom Tromey  <tom@tromey.com>
16557
16558         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16559         * objfiles.h (objfile::reset_psymtabs): New method.
16560
16561 2019-01-10  Tom Tromey  <tom@tromey.com>
16562
16563         * symmisc.c (print_symbol_bcache_statistics): Update.
16564         (print_objfile_statistics): Update.
16565         * symfile.c (reread_symbols): Update.
16566         * psymtab.h (class psymtab_storage): New.
16567         * psymtab.c (psymtab_storage): New constructor.
16568         (~psymtab_storage): New destructor.
16569         (require_partial_symbols): Update.
16570         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16571         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16572         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16573         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16574         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16575         (start_psymtab_common, end_psymtab_common)
16576         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16577         (allocate_psymtab): Update.
16578         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16579         Update.
16580         (dump_psymtab_addrmap, maintenance_print_psymbols)
16581         (maintenance_check_psymtabs): Update.
16582         (class objfile_psymtabs): Move to objfiles.h.
16583         * psympriv.h (discard_psymtab): Now inline.
16584         (psymtab_discarder::psymtab_discarder): Update.
16585         (psymtab_discarder::~psymtab_discarder): Update.
16586         (ALL_OBJFILE_PSYMTABS): Rewrite.
16587         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16588         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16589         Remove fields.
16590         <partial_symtabs>: New field.
16591         (class objfile_psymtabs): Move from psymtab.h.  Update.
16592         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16593         psymbol_cache.
16594         (objfile::~objfile): Don't destroy psymbol_cache.
16595         * mdebugread.c (parse_partial_symbols): Update.
16596         * dwarf2read.c (create_addrmap_from_index)
16597         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16598         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16599         (add_partial_subprogram, dwarf2_ranges_read): Update.
16600         * dwarf-index-write.c (write_address_map)
16601         (write_one_signatured_type, recursively_write_psymbols)
16602         (class debug_names, class debug_names, write_psymtabs_to_index):
16603         Update.
16604
16605 2019-01-10  Tom Tromey  <tom@tromey.com>
16606
16607         * symtab.h (SYMBOL_SET_NAMES): Update.
16608         (symbol_set_names): Update.
16609         (MSYMBOL_SET_NAMES): Update.
16610         * symtab.c (symbol_set_names): Change argument to be an
16611         objfile_per_bfd_storage.
16612         * psymtab.c (add_psymbol_to_bcache): Update.
16613         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16614
16615 2019-01-10  Tom Tromey  <tom@tromey.com>
16616
16617         * symtab.c (create_demangled_names_hash): Change argument to be an
16618         objfile_per_bfd_storage.
16619         (symbol_set_names): Update.
16620
16621 2019-01-10  Tom Tromey  <tom@tromey.com>
16622
16623         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16624         init_psymbol_list.
16625         * psymtab.c (init_psymbol_list): Do nothing if already called.
16626         * psympriv.h (init_psymbol_list): Add comment.
16627         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16628         init_psymbol_list.
16629         * dbxread.c (dbx_symfile_read): Unconditionally call
16630         init_psymbol_list.
16631
16632 2019-01-10  Tom Tromey  <tom@tromey.com>
16633
16634         * xcoffread.c (scan_xcoff_symtab): Update.
16635         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16636         "where".
16637         * mdebugread.c (parse_partial_symbols)
16638         (handle_psymbol_enumerators): Update.
16639         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16640         * dbxread.c (read_dbx_symtab): Update.
16641         * psympriv.h (psymbol_placement): New enum.
16642         (add_psymbol_to_list): Update.
16643
16644 2019-01-10  Tom Tromey  <tom@tromey.com>
16645
16646         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16647         static_psymbols parameters.
16648         (scan_xcoff_symtab): Update.
16649         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16650         static_psymbols parameters.
16651         * psympriv.h (start_psymtab_common): Update.
16652         * mdebugread.c (parse_partial_symbols): Update.
16653         * dwarf2read.c (create_partial_symtab): Update.
16654         * dbxread.c (read_dbx_symtab): Update.
16655         (start_psymtab): Remove global_psymbols and static_psymbols
16656         parameters.
16657
16658 2019-01-10  Tom Tromey  <tom@tromey.com>
16659
16660         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16661         * psymtab.c (allocate_psymtab): Add comment.
16662         * psympriv.h (allocate_psymtab): Add comment.
16663         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16664         initializations.
16665         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16666
16667 2019-01-10  Tom Tromey  <tom@tromey.com>
16668
16669         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16670         Don't declare.
16671         * mipsread.c: Include mdebugread.h.
16672         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16673         Declare.
16674         * elfread.c: Include mdebugread.h.
16675
16676 2019-01-09  Tom Tromey  <tom@tromey.com>
16677
16678         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16679         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16680         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16681         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16682         (psym_lookup_symbol, psym_find_last_source_symtab)
16683         (psym_forget_cached_source_info, psym_print_stats)
16684         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16685         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16686         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16687         (psym_find_compunit_symtab_by_address)
16688         (maintenance_print_psymbols, maintenance_info_psymtabs)
16689         (maintenance_check_psymtabs): Use ranged for.
16690         * psymtab.h (class objfile_psymtabs): New.
16691         (require_partial_symbols): Return objfile_psymtabs.
16692         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16693
16694 2019-01-09  Tom Tromey  <tom@tromey.com>
16695
16696         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16697         (find_pc_mapped_section, list_overlays_command)
16698         (map_overlay_command, unmap_overlay_command)
16699         (simple_overlay_update): Use all_objfiles.
16700         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16701         * printcmd.c (info_symbol_command): Use all_objfiles.
16702         * objfiles.h (ALL_OBJSECTIONS): Remove.
16703         * maint.c (maintenance_translate_address): Use all_objfiles.
16704         * gcore.c (gcore_create_callback): Use all_objfiles.
16705         (objfile_find_memory_regions): Likewise.
16706
16707 2019-01-09  Tom Tromey  <tom@tromey.com>
16708
16709         * symtab.c (find_line_symtab, info_sources_command)
16710         (make_source_files_completion_list): Use objfile_compunits.
16711         * source.c (select_source_symtab): Use objfile_compunits.
16712         * objfiles.h (struct objfile): Update comment.
16713         (ALL_OBJFILES): Remove.
16714         (ALL_FILETABS): Remove.
16715         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16716         objfile_compunits.
16717
16718 2019-01-09  Tom Tromey  <tom@tromey.com>
16719
16720         * symmisc.c (print_objfile_statistics, dump_objfile)
16721         (maintenance_print_symbols): Use compunit_filetabs.
16722         * source.c (forget_cached_source_info_for_objfile): Use
16723         compunit_filetabs.
16724         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16725         (ALL_FILETABS): Use compunit_filetabs.
16726         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16727         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16728
16729 2019-01-09  Tom Tromey  <tom@tromey.com>
16730
16731         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16732         (compunit_filetabs): New.
16733         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16734         compunit_filetabs.
16735         (info_sources_command, make_source_files_completion_list): Remove
16736         declaration.
16737         * symmisc.c (print_objfile_statistics, dump_objfile)
16738         (maintenance_print_symbols): Remove declaration.
16739         (maintenance_info_symtabs): Use compunit_filetabs.
16740         (maintenance_info_line_tables): Likewise.
16741         * source.c (select_source_symtab): Change local variable name.
16742         (forget_cached_source_info_for_objfile): Remove declaration.
16743         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16744         * objfiles.c (objfile_relocate1): Remove declaration.
16745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16746         declaration.
16747         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16748         * coffread.c (coff_symtab_read): Remove declaration.
16749         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16750         compunit_filetabs.
16751
16752 2019-01-09  Tom Tromey  <tom@tromey.com>
16753
16754         * symtab.c (lookup_objfile_from_block)
16755         (find_pc_sect_compunit_symtab, search_symbols)
16756         (default_collect_symbol_completion_matches_break_on): Use
16757         objfile_compunits.
16758         * objfiles.h (ALL_COMPUNITS): Remove.
16759         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16760         * cp-support.c (add_symbol_overload_list_qualified): Use
16761         objfile_compunits.
16762         * ada-lang.c (ada_collect_symbol_completion_matches)
16763         (ada_add_global_exceptions): Use objfile_compunits.
16764
16765 2019-01-09  Tom Tromey  <tom@tromey.com>
16766
16767         * source.c (select_source_symtab)
16768         (forget_cached_source_info_for_objfile): Remove declaration.
16769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16770         declaration.
16771         * maint.c (count_symtabs_and_blocks): Remove declaration.
16772         * cp-support.c (add_symbol_overload_list_qualified): Remove
16773         declaration.
16774         * coffread.c (coff_symtab_read): Remove declaration.
16775         * symtab.c (lookup_symbol_in_objfile_symtabs)
16776         (basic_lookup_transparent_type_1): Use objfile_compunits.
16777         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16778         (info_sources_command, search_symbols)
16779         (default_collect_symbol_completion_matches_break_on)
16780         (make_source_files_completion_list): Remove declaration.
16781         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16782         (ada_collect_symbol_completion_matches)
16783         (ada_add_global_exceptions): Remove declaration.
16784         * linespec.c (iterate_over_all_matching_symtabs): Use
16785         objfile_compunits.
16786         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16787         (class objfile_compunits): New.
16788         (ALL_COMPUNITS): Use objfile_compunits.
16789         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16790         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16791         objfile_compunits.
16792         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16793
16794 2019-01-09  Tom Tromey  <tom@tromey.com>
16795
16796         * symtab.c (search_symbols)
16797         (default_collect_symbol_completion_matches_break_on): Use
16798         objfile_msymbols.
16799         * ada-lang.c (ada_lookup_simple_minsym)
16800         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16801         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16802         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16803         objfile_msymbols.
16804         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16805         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16806         * objc-lang.c (find_methods): Use objfile_msymbols.
16807         (info_selectors_command, info_classes_command): Likewise.
16808         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16809         * objfiles.h (class objfile_msymbols): New.
16810         (ALL_OBJFILE_MSYMBOLS): Remove.
16811         (ALL_MSYMBOLS): Remove.
16812
16813 2019-01-09  Tom Tromey  <tom@tromey.com>
16814
16815         * common/next-iterator.h (next_adapter): Add Iterator template
16816         parameter.
16817         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16818         (class all_objfiles_safe): New.
16819         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16820         * objfiles.c (put_objfile_before): Update comment.
16821         (add_separate_debug_objfile): Likewise.
16822         (free_all_objfiles): Use all_objfiles_safe.
16823         (objfile_purge_solibs): Likewise.
16824
16825 2019-01-09  Tom Tromey  <tom@tromey.com>
16826
16827         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16828         (expand_symtab_containing_pc, lookup_static_symbol)
16829         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16830         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16831         all_objfiles.
16832         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16833         * breakpoint.c (create_overlay_event_breakpoint)
16834         (create_longjmp_master_breakpoint)
16835         (create_std_terminate_master_breakpoint)
16836         (create_exception_master_breakpoint): Use all_objfiles.
16837         * linux-thread-db.c (try_thread_db_load_from_pdir)
16838         (has_libpthread): Use all_objfiles.
16839         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16840         * linespec.c (iterate_over_all_matching_symtabs)
16841         (search_minsyms_for_name): Use all_objfiles.
16842         * maint.c (maintenance_info_sections): Use all_objfiles.
16843         * main.c (captured_main_1): Use all_objfiles.
16844         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16845         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16846         * guile/scm-pretty-print.c
16847         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16848         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16849         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16850         (maintenance_print_msymbols): Use all_objfiles.
16851         * source.c (select_source_symtab): Use all_objfiles.
16852         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16853         * symfile.c (remove_symbol_file_command)
16854         (expand_symtabs_matching, map_symbol_filenames): Use
16855         all_objfiles.
16856         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16857         all_objfiles.
16858         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16859         * objc-lang.c (find_methods): Use all_objfiles.
16860         * objfiles.c (have_partial_symbols, have_full_symbols)
16861         (have_minimal_symbols, qsort_cmp)
16862         (default_iterate_over_objfiles_in_search_order): Use
16863         all_objfiles.
16864         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16865         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16866         (maintenance_check_psymtabs): Use all_objfiles.
16867         (ALL_PSYMTABS): Remove.
16868         * compile/compile-object-run.c (do_module_cleanup): Use
16869         all_objfiles.
16870         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16871         * cp-support.c (add_symbol_overload_list_qualified): Use
16872         all_objfiles.
16873         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16874         Use all_objfiles.
16875         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16876         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16877         all_objfiles.
16878         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16879         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16880         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16881         Uses all_objfiles.
16882         * solib.c (solib_read_symbols): Use all_objfiles
16883
16884 2019-01-09  Tom Tromey  <tom@tromey.com>
16885
16886         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16887         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16888         all_objfiles.
16889         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16890         * symmisc.c (print_symbol_bcache_statistics)
16891         (print_objfile_statistics, maintenance_print_objfiles)
16892         (maintenance_info_symtabs, maintenance_check_symtabs)
16893         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16894         all_objfiles.
16895         * source.c (forget_cached_source_info): Use all_objfiles.
16896         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16897         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16898         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16899         * objfiles.c (update_section_map): Use all_objfiles.
16900         (shared_objfile_contains_address_p): Likewise.
16901         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16902         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16903
16904 2019-01-09  Tom Tromey  <tom@tromey.com>
16905
16906         * common/next-iterator.h: New file.
16907         * objfiles.h (class all_objfiles): New.
16908         (struct objfile_iterator): New.
16909
16910 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16911
16912         * NEWS: Move the description of the changed "frame", "select-frame",
16913          and "info frame" commands to the Changed commands section.
16914
16915 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16916
16917         * gdbtypes.c (check_stub_method_group): Remove handling of old
16918         mangling schemes.
16919         * linespec.c (find_methods): Likewise.
16920         * stabsread.c (read_member_functions): Likewise.
16921         * valops.c (search_struct_method): Likewise.
16922         (value_struct_elt_for_reference): Likewise.
16923         * NEWS: Mention this change.
16924
16925 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16926
16927         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16928         print_source_lines.
16929         * source.c (print_source_lines_base): Update line number check.
16930         (print_source_lines): New function.
16931         (source_lines_range::source_lines_range): New function.
16932         * source.h (class source_lines_range): New class.
16933         (print_source_lines): New declaration.
16934
16935 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16936
16937         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16938
16939 2019-01-08  Tom Tromey  <tom@tromey.com>
16940             Simon Marchi  <simon.marchi@ericsson.com>
16941
16942         PR gdb/24060
16943         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16944         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16945         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16946         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16947         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16948         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16949
16950 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16951
16952         * source.c (select_source_symtab): Move header comment to
16953         declaration in source.h.
16954         (forget_cached_source_info_for_objfile): Likewise.
16955         (forget_cached_source_info): Likewise.
16956         (identify_source_line): Likewise.
16957         * source.h (identify_source_line): Move declaration from symtab.h
16958         and add comment from source.c
16959         (print_source_lines): Likewise.
16960         (forget_cached_source_info_for_objfile): Likewise.
16961         (forget_cached_source_info): Likewise.
16962         (select_source_symtab): Likewise.
16963         (enum print_source_lines_flag): Move definition from symtab.h.
16964         * symtab.h (identify_source_line): Move declaration to source.h.
16965         (print_source_lines): Likewise.
16966         (forget_cached_source_info_for_objfile): Likewise.
16967         (forget_cached_source_info): Likewise.
16968         (select_source_symtab): Likewise.
16969         (enum print_source_lines_flag): Move definition to source.h.
16970         * tui/tui-hooks.c: Add 'source.h' include.
16971
16972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16973
16974         * source.c (print_source_lines_base): Handle requests to print
16975         reverse line number sequences, and guard against empty lines
16976         string.
16977
16978 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16979
16980         * source.c (print_source_lines_base): Fix skip of '\r' if next
16981         character is '\n'.
16982
16983 2019-01-06  Tom Tromey  <tom@tromey.com>
16984
16985         * c-exp.y (struct c_parse_state) <macro_original_text,
16986         expansion_obstack>: New member.
16987         (macro_original_text, expansion_obstack): Remove globals.
16988         (scan_macro_expansion, scanning_macro_expansion)
16989         (finished_macro_expansion): Update.
16990         (scan_macro_cleanup): Remove.
16991         (yylex, c_parse): Update.
16992
16993 2019-01-06  Tom Tromey  <tom@tromey.com>
16994
16995         * c-exp.y (struct c_parse_state) <strings>: New member.
16996         (operator_stoken): Update.
16997
16998 2019-01-06  Tom Tromey  <tom@tromey.com>
16999
17000         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
17001         (union type_stack_elt) <typelist_val>: Now a pointer to
17002         std::vector.
17003         (type_stack_cleanup): Don't declare.
17004         (push_typelist): Update.
17005         * parse.c (pop_typelist): Return a std::vector.
17006         (push_typelist): Take a std::vector.
17007         (follow_types): Update.  Do not free args.
17008         (type_stack_cleanup): Remove.
17009         * c-exp.y (struct c_parse_state): New.
17010         (cpstate): New global.
17011         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17012         (nonempty_typelist): Update.
17013         (func_mod): Create a new vector.
17014         (c_parse): Create a c_parse_state.
17015         (check_parameter_typelist): Do not delete params.
17016         (function_method): Update.  Do not delete type_list.
17017
17018 2019-01-06  Tom Tromey  <tom@tromey.com>
17019
17020         PR gdb/28155:
17021         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17022         check_typedef.
17023         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17024         (print_return_value): Likewise.
17025
17026 2019-01-05  Tom Tromey  <tom@tromey.com>
17027
17028         * contrib/cleanup_check.py: Remove.
17029         * contrib/gcc-with-excheck: Remove.
17030         * contrib/exsummary.py: Remove.
17031         * contrib/excheck.py: Remove.
17032
17033 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
17034
17035         * thread.c (delete_thread_1): Add gdb_assert that THR is not
17036         NULL. Initialize tpprev to NULL instead of assigning it
17037         to NULL on the next statement.
17038         * windows-nat.c (windows_delete_thread): Remove check for
17039         main_thread_id before printing thread exit notifications.
17040         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17041         Remove thread ID check against main_thread_id.
17042         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17043         windows_delete_thread.
17044         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17045
17046 2019-01-04  Tom Tromey  <tom@tromey.com>
17047
17048         * compile/compile.c (_initialize_compile): Use upper case for
17049         metasyntactic variables.
17050         * symmisc.c (_initialize_symmisc): Use upper case for
17051         metasyntactic variables.
17052         * psymtab.c (_initialize_psymtab): Use upper case for
17053         metasyntactic variables.
17054         * demangle.c (demangle_command): Use upper case for metasyntactic
17055         variables.
17056         (_initialize_demangler): Likewise.
17057         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17058         variables.
17059
17060 2019-01-03  Tom Tromey  <tom@tromey.com>
17061
17062         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17063
17064 2019-01-03  Tom Tromey  <tom@tromey.com>
17065
17066         * python/py-symtab.c (salpy_str): Update.
17067         (struct salpy_sal_object) <symtab>: Now a PyObject.
17068         (salpy_dealloc): Update.
17069         (del_objfile_sal): Use gdbpy_ref.
17070
17071 2019-01-03  Tom Tromey  <tom@tromey.com>
17072
17073         * python/py-type.c (convert_field): Use new_reference.  Return
17074         gdbpy_ref.
17075         (make_fielditem): Return gdbpy_ref.
17076         (typy_fields): Update.
17077         (typy_getitem): Update.
17078         (field_name): Return gdbpy_ref.  Use new_reference.
17079         (typy_iterator_iternext): Update.
17080
17081 2019-01-03  Tom Tromey  <tom@tromey.com>
17082
17083         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17084
17085 2019-01-03  Tom Tromey  <tom@tromey.com>
17086
17087         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17088         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17089         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17090         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17091         (pspy_set_type_printers): Likewise.
17092         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17093         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17094         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17095         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17096         (objfpy_set_type_printers): Likewise.
17097
17098 2019-01-03  Tom Tromey  <tom@tromey.com>
17099
17100         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17101         (gdbpy_print_stack): Use gdbpy_err_fetch.
17102         * python/python-internal.h (class gdbpy_err_fetch): New class.
17103         (class gdbpy_enter) <m_error_type, m_error_value,
17104         m_error_traceback>: Remove.
17105         <m_error>: New member.
17106         (gdbpy_exception_to_string): Don't declare.
17107         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17108         * python/py-value.c (convert_value_from_python): Use
17109         gdbpy_err_fetch.
17110         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17111         gdbpy_exception_to_string.
17112         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17113         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17114         gdbpy_err_fetch.
17115
17116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17117
17118         * linux-nat.c (delete_lwp_cleanup): Delete.
17119         (struct lwp_deleter): New struct.
17120         (lwp_info_up): New typedef.
17121         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17122         lwp_info_up.
17123
17124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17125
17126         * linux-fork.c (class scoped_switch_fork_info): New class.
17127         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17128
17129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17130
17131         * valops.c (find_overload_match): Remove use of null_cleanup, and
17132         calls to do_cleanups.
17133
17134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17135
17136         * compile/compile-cplus-types.c
17137         (compile_cplus_instance::decl_name): Handle changes to
17138         cp_func_name.
17139         * cp-support.c (cp_func_name): Update header comment, update
17140         return type.
17141         * cp-support.h (cp_func_name): Update return type in declaration.
17142         * valops.c (find_overload_match): Move temp_func local to top
17143         level of function and change its type.  Use temp_func to hold and
17144         delete temporary string obtained from cp_func_name.
17145
17146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17147
17148         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17149         gdb::char_vector, remove cleanup, and update uses of `msg`.
17150
17151 2019-01-03  Jim Wilson  <jimw@sifive.com>
17152
17153         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17154
17155 2019-01-02  Tom Tromey  <tom@tromey.com>
17156
17157         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17158         (tdesc_parse_xml): Remove cleanups.
17159         * target-descriptions.h (make_cleanup_free_target_description):
17160         Don't declare.
17161         (target_desc_deleter): New struct.
17162         (target_desc_up): New typedef.
17163         * target-descriptions.c (target_desc_deleter::operator()): Rename
17164         from free_target_description.
17165         (make_cleanup_free_target_description): Remove.
17166
17167 2019-01-02  Tom Tromey  <tom@tromey.com>
17168
17169         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17170         constructor, destructor.
17171         (linespec_parser): Remove typedef.
17172         (~linespec_parser): Rename from linespec_parser_delete.
17173         (linespec_lex_to_end, linespec_complete_label)
17174         (linespec_complete): Update.
17175         (decode_line_full): Remove cleanups.
17176         (decode_line_1): Update.
17177
17178 2019-01-02  Tom Tromey  <tom@tromey.com>
17179
17180         * python/python-internal.h (inferior_to_inferior_object): Change
17181         return type.
17182         * python/py-exitedevent.c (create_exited_event_object): Update.
17183         * python/py-inferior.c (inferior_to_inferior_object): Return
17184         gdbpy_ref.
17185         (python_new_inferior, python_inferior_deleted)
17186         (thread_to_thread_object, delete_thread_object)
17187         (build_inferior_list, gdbpy_selected_inferior): Update.
17188         * python/py-infthread.c (create_thread_object): Update.  Also fail
17189         if inferior_to_inferior_object fails.
17190
17191 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17192
17193         * inferior.h (class inferior) <displaced_step_state>: New field.
17194         * infrun.h (struct displaced_step_state): Move here from
17195         infrun.c.  Initialize fields, add constructor.
17196         <inf>: Remove field.
17197         <reset>: New method.
17198         * infrun.c (struct displaced_step_inferior_state): Move to
17199         infrun.h.
17200         (displaced_step_inferior_states): Remove.
17201         (get_displaced_stepping_state): Adust.
17202         (displaced_step_in_progress_any_inferior): Adjust.
17203         (displaced_step_in_progress_thread): Adjust.
17204         (displaced_step_in_progress): Adjust.
17205         (add_displaced_stepping_state): Remove.
17206         (get_displaced_step_closure_by_addr): Adjust.
17207         (remove_displaced_stepping_state): Remove.
17208         (infrun_inferior_exit): Call displaced_step_state.reset.
17209         (use_displaced_stepping): Don't check for NULL.
17210         (displaced_step_prepare_throw): Call
17211         get_displaced_stepping_state.
17212         (displaced_step_fixup): Don't check for NULL.
17213         (prepare_for_detach): Don't check for NULL.
17214
17215 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17216
17217         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17218          in case of call that did not complete.
17219
17220 2019-01-02  Andrey Utkin  <autkin@undo.io>
17221
17222         * symfile.c (find_separate_debug_file): Fix search of debug files for
17223         remote debuggee.
17224
17225 2019-01-02  Tom Tromey  <tom@tromey.com>
17226
17227         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17228         indentation.
17229         * python/py-frame.c (frapy_older): Remove cast.
17230         (frapy_newer): Likewise.
17231         * python/py-breakpoint.c (local_setattro): Remove cast.
17232         * python/py-arch.c (archpy_name): Remove local variable.
17233         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17234
17235 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17236
17237         * unittests/basic_string_view/element_access/char/empty.cc:
17238         Fix year range in copyright header.
17239
17240 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17241
17242         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17243         Delete.
17244         <operator==>: Update with for removed field.
17245         <hash>: Likewise.
17246         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17247         <isa_features>: ...this.
17248         <abi_features>: New field.
17249         (riscv_isa_flen): Update comment.
17250         (riscv_abi_xlen): New declaration.
17251         (riscv_abi_flen): New declaration.
17252         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17253         isa_features.
17254         (riscv_abi_xlen): New function.
17255         (riscv_isa_flen): Update to get answer from isa_features.
17256         (riscv_abi_flen): New function.
17257         (riscv_has_fp_abi): Update to get answer from abi_features.
17258         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17259         xlen and flen.
17260         (riscv_call_info) <xlen, flen>: Update comment.
17261         (riscv_call_arg_struct): Remove invalid assertions
17262         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17263         is removed.
17264         (riscv_gdbarch_init): Gather isa features and abi features
17265         separately, ensure both match on the gdbarch when reusing an old
17266         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17267         a target with 64-bit float hardware.
17268
17269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17270
17271         * source.c (search_command_helper): Stop reverse search
17272         when line 1 has been searched.
17273
17274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17275
17276         * record-full.c (record_full_base_target::close): Rewrite
17277         record_full_core_buf_list free logic.
17278
17279 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17280
17281         * break-catch-syscall.c (print_one_catch_syscall): xfree
17282         the last text.
17283
17284 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17285
17286         * top.c (print_gdb_version): Update Copyright year in version
17287         message.
17288
17289 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17290
17291         Update copyright year range in all GDB files.
17292
17293 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17294
17295         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17296
17297 For older changes see ChangeLog-2018.
17298 \f
17299 Local Variables:
17300 mode: change-log
17301 left-margin: 8
17302 fill-column: 74
17303 version-control: never
17304 coding: utf-8
17305 End:
17306