gdb/ChangeLog

   1 2019-10-25  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
   4         (bsearch_cie_cmp, add_cie): Remove.
   5         (find_cie): Reimplement.
   6         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
   7         (dwarf2_build_frame_info): Update.
   8
   9 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
  10
  11         PR gdb/25126
  12         * symfile.c (reread_symbols): Call forget_cached_source_info to
  13         clear the stale source cache.
  14
  15 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
  16
  17         * configure: Regenerate.
  18         * configure.ac: Remove code that sets python_has_threads.
  19
  20 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
  21
  22         * config.in: Regenerate.
  23         * configure: Regenerate.
  24         * configure.ac: Remove the code that uses sed to get the python
  25         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
  26
  27 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
  28
  29         * python/py-progspace.c (pspy_block_for_pc): Return None for all
  30         error paths.
  31
  32 2019-10-23  Tom Tromey  <tom@tromey.com>
  33
  34         * arc-tdep.c: Remove ".." from include.
  35         * frv-tdep.c: Remove ".." from include.
  36         * lm32-tdep.c: Remove ".." from include.
  37         * microblaze-tdep.c: Remove ".." from include.
  38         * or1k-tdep.h: Remove ".." from include.
  39         * s12z-tdep.c: Remove ".." from include.
  40         * Makefile.in (OPCODES_CFLAGS): Add comment.
  41         (TOP_CFLAGS): New variable.
  42         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
  43
  44 2019-10-23  Tom Tromey  <tom@tromey.com>
  45
  46         * Makefile.in (READLINE_DIR): Update.
  47
  48 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  49
  50         * infcall.c (call_function_by_hand_dummy): Fix the function
  51         comment.  And extract out a code section into...
  52         (reserve_stack_space): ...this new function.
  53
  54 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  55
  56         * infcall.c (value_arg_coerce): Remove an unused parameter.
  57         (call_function_by_hand_dummy): Update the call to
  58         'value_arg_coerce'.
  59
  60 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  61
  62         * infcall.c (call_function_by_hand_dummy): Refactor.
  63
  64 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  65
  66         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
  67
  68 2019-10-23  Tom Tromey  <tom@tromey.com>
  69
  70         * configure: Rebuild.
  71         * configure.ac: Don't check for sigprocmask.
  72         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
  73
  74 2019-10-23  Tom Tromey  <tom@tromey.com>
  75
  76         * configure: Rebuild.
  77         * acinclude.m4: Use m4_include, not sinclude.
  78
  79 2019-10-23  Tom de Vries  <tdevries@suse.de>
  80
  81         PR breakpoints/24687
  82         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  83
  84 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  85
  86         * symtab.c (struct demangled_name_entry) <language>: Change from
  87         bitfield to regular variable.
  88
  89 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  90
  91         * symtab.c (struct demangled_name_entry): Add a constructor.
  92         (free_demangled_name_entry): New function to call the destructor
  93         for demangled_name_entry.
  94         (create_demangled_names_hash): Pass free_demangled_name_entry to
  95         htab_create_alloc.
  96         (symbol_set_names): Call placement new for demangled_name_entry.
  97         * utils.c: No longer include xxhash.h here, now that fast_hash
  98         is inlined in the header.
  99         * utils.h: Instead, include it here.
 100
 101 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 102
 103         * Makefile.in: Link with libxxhash.
 104         * config.in: Regenerate.
 105         * configure: Regenerate.
 106         * configure.ac: Search for libxxhash.
 107         * utils.c (fast_hash): Use xxhash if present.
 108
 109 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 110
 111         * utils.h (fast_hash): New function.
 112         * symtab.c (hash_demangled_name_entry): Call new function
 113         fast_hash.
 114
 115 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * symtab.c (struct demangled_name_entry): Change type of mangled
 118         to gdb::string_view. Also adds a constructor that takes the
 119         mangled name.
 120         (hash_demangled_name_entry): Update.
 121         (eq_demangled_name_entry): Update.
 122         (free_demangled_name_entry): New function to call the destructor
 123         now that this is not a POD anymore.
 124         (create_demangled_names_hash): Pass free_demangled_name_entry to
 125         htab_create_alloc.
 126         (symbol_set_names): Update.
 127
 128 2019-10-21  Ali Tamur  <tamu@google.com>
 129
 130         * dwarf2read.c (dir_index): Change type.
 131         (file_name_index): Likewise.
 132         (line_header::include_dir_at): Change comment and implementation on
 133         whether it is DWARF 5.
 134         (line_header::is_valid_file_index): New function.
 135         (line_header::file_name_at): Change comment and implementation on
 136         whether it is DWARF 5.
 137         (line_header::file_names): Change to private field renamed as
 138         m_file_names and introduce a new accessor method.
 139         (line_header::file_names_size): New method.
 140         (line_header::include_dirs): Change to private field and rename as
 141         m_include_dirs.
 142         (dw2_get_file_names_reader): Define local var at a smaller scope and
 143         reflect API change.
 144         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 145         (process_structure_scope): Likewise.
 146         (line_header::add_include_dir): Change message and reflect renaming.
 147         (line_header::add_file_name): Likewise.
 148         (read_formatted_entries): Handle DW_FORM_data16.
 149         (dwarf_decode_line_header): Fix line header length calculation.
 150         (psymtab_include_file_name): Change comment and API.
 151         (lnp_state_machine::m_file): Update comment and reflect type change.
 152         (lnp_state_machine::record_line): Reflect type change.
 153         (dwarf_decode_lines): Reflect API change.
 154         (file_file_name): Likewise.
 155         (file_full_name): Likewise.
 156
 157 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 158
 159         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 160
 161 2019-10-21  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 164
 165 2019-10-21  Tom Tromey  <tom@tromey.com>
 166
 167         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 168         NM_H.   Use AC_CONFIG_LINKS.
 169         * configure: Rebuild.
 170         * Makefile.in (NM_H): New variable.
 171         (generated_files): Add NM_H.  Remove gcore.
 172         (nm.h, stamp-nmh): New targets.
 173
 174 2019-10-20  Tom Tromey  <tom@tromey.com>
 175
 176         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 177         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 178         obsolete comment.
 179         (put_objfile_before): Now static.
 180
 181 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 182
 183         * gdbsupport/common-utils.h (startswith): Change return type to
 184         bool.
 185
 186 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 189         * breakpoint.c (bp_locations_compare): Rename to...
 190         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 191         (update_global_location_list): Use std::sort instead of qsort.
 192         * buildsym.c (compare_line_numbers): Rename to...
 193         (lte_is_less_than): ...this, and change to std::sort semantics.
 194         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 195         instead of qsort.
 196         * disasm.c (compare_lines): Rename to...
 197         (line_is_less_than): ...this, and change to std::sort semantics.
 198         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 199         of qsort.
 200         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 201         (fde_is_less_than): ...this, and change to std::sort semantics.
 202         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 203         * mdebugread.c (compare_blocks):
 204         (block_is_less_than): ...this, and change to std::sort semantics.
 205         (sort_blocks): Call std::sort instead of qsort.
 206         * objfiles.c (qsort_cmp): Rename to...
 207         (sort_cmp): ...this, and change to std::sort semantics.
 208         (update_section_map): Call std::sort instead of qsort.
 209         * remote.c (compare_pnums): Remove.
 210         (map_regcache_remote_table): Call std::sort instead of qsort.
 211         * utils.c (compare_positive_ints): Remove.
 212         * utils.h (compare_positive_ints): Remove.
 213         * xcoffread.c (compare_lte): Remove.
 214         (arrange_linetable): Call std::sort instead of qsort.
 215
 216 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 217
 218         * symfile.c (init_entry_point_info): Fix typo.
 219         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 220
 221 2019-10-18  Tom de Vries  <tdevries@suse.de>
 222
 223         * aarch64-tdep.c: Fix typos in comments.
 224         * ada-lang.c: Same.
 225         * ada-tasks.c: Same.
 226         * alpha-tdep.c: Same.
 227         * alpha-tdep.h: Same.
 228         * amd64-nat.c: Same.
 229         * amd64-windows-tdep.c: Same.
 230         * arc-tdep.c: Same.
 231         * arc-tdep.h: Same.
 232         * arch-utils.c: Same.
 233         * arm-nbsd-tdep.c: Same.
 234         * arm-tdep.c: Same.
 235         * ax-gdb.c: Same.
 236         * blockframe.c: Same.
 237         * btrace.c: Same.
 238         * c-varobj.c: Same.
 239         * coff-pe-read.c: Same.
 240         * coffread.c: Same.
 241         * cris-tdep.c: Same.
 242         * darwin-nat.c: Same.
 243         * dbxread.c: Same.
 244         * dcache.c: Same.
 245         * disasm.c: Same.
 246         * dtrace-probe.c: Same.
 247         * dwarf-index-write.c: Same.
 248         * dwarf2-frame-tailcall.c: Same.
 249         * dwarf2-frame.c: Same.
 250         * dwarf2read.c: Same.
 251         * eval.c: Same.
 252         * exceptions.c: Same.
 253         * fbsd-tdep.c: Same.
 254         * findvar.c: Same.
 255         * frame.c: Same.
 256         * frv-tdep.c: Same.
 257         * gnu-v3-abi.c: Same.
 258         * go32-nat.c: Same.
 259         * h8300-tdep.c: Same.
 260         * hppa-tdep.c: Same.
 261         * i386-linux-tdep.c: Same.
 262         * i386-tdep.c: Same.
 263         * ia64-libunwind-tdep.c: Same.
 264         * ia64-tdep.c: Same.
 265         * infcmd.c: Same.
 266         * infrun.c: Same.
 267         * linespec.c: Same.
 268         * linux-nat.c: Same.
 269         * linux-thread-db.c: Same.
 270         * machoread.c: Same.
 271         * mdebugread.c: Same.
 272         * mep-tdep.c: Same.
 273         * mn10300-tdep.c: Same.
 274         * namespace.c: Same.
 275         * objfiles.c: Same.
 276         * opencl-lang.c: Same.
 277         * or1k-tdep.c: Same.
 278         * osabi.c: Same.
 279         * ppc-linux-nat.c: Same.
 280         * ppc-linux-tdep.c: Same.
 281         * ppc-sysv-tdep.c: Same.
 282         * printcmd.c: Same.
 283         * procfs.c: Same.
 284         * record-btrace.c: Same.
 285         * record-full.c: Same.
 286         * remote-fileio.c: Same.
 287         * remote.c: Same.
 288         * rs6000-tdep.c: Same.
 289         * s12z-tdep.c: Same.
 290         * score-tdep.c: Same.
 291         * ser-base.c: Same.
 292         * ser-go32.c: Same.
 293         * skip.c: Same.
 294         * sol-thread.c: Same.
 295         * solib-svr4.c: Same.
 296         * solib.c: Same.
 297         * source.c: Same.
 298         * sparc-nat.c: Same.
 299         * sparc-sol2-tdep.c: Same.
 300         * sparc-tdep.c: Same.
 301         * sparc64-tdep.c: Same.
 302         * stabsread.c: Same.
 303         * stack.c: Same.
 304         * symfile.c: Same.
 305         * symtab.c: Same.
 306         * target-descriptions.c: Same.
 307         * target-float.c: Same.
 308         * thread.c: Same.
 309         * utils.c: Same.
 310         * valops.c: Same.
 311         * valprint.c: Same.
 312         * value.c: Same.
 313         * varobj.c: Same.
 314         * windows-nat.c: Same.
 315         * xcoffread.c: Same.
 316         * xstormy16-tdep.c: Same.
 317         * xtensa-tdep.c: Same.
 318
 319 2019-10-17  Tom Tromey  <tromey@adacore.com>
 320
 321         * configure: Rebuild.
 322         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 323         in AC_CONFIG_FILES invocation.
 324         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 325         new-style config.status invocation.
 326
 327 2019-10-17  Tom de Vries  <tdevries@suse.de>
 328
 329         * arm-nbsd-nat.c: Fix typos in comments.
 330         * arm-tdep.c: Same.
 331         * darwin-nat-info.c: Same.
 332         * dwarf2read.c: Same.
 333         * elfread.c: Same.
 334         * event-top.c: Same.
 335         * findvar.c: Same.
 336         * gdbtypes.c: Same.
 337         * hppa-tdep.c: Same.
 338         * i386-tdep.c: Same.
 339         * jit.c: Same.
 340         * main.c: Same.
 341         * mdebugread.c: Same.
 342         * moxie-tdep.c: Same.
 343         * nto-procfs.c: Same.
 344         * osabi.c: Same.
 345         * ppc-linux-tdep.c: Same.
 346         * remote.c: Same.
 347         * riscv-tdep.c: Same.
 348         * s390-tdep.c: Same.
 349         * sh-tdep.c: Same.
 350         * sparc-linux-tdep.c: Same.
 351         * sparc-nat.c: Same.
 352         * stack.c: Same.
 353         * target-descriptions.c: Same.
 354         * top.c: Same.
 355         * varobj.c: Same.
 356
 357 2019-10-16  Tom Tromey  <tom@tromey.com>
 358
 359         * objfiles.h (struct objfile) <original_name>: Now const.
 360
 361 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 362
 363         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 364         pass on to sigsetjmp's second argument.
 365         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 366
 367 2019-10-16  Keith Seitz  <keiths@redhat.com>
 368
 369         PR gdb/23567
 370         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 371         sections whose size is greater than the file size.
 372
 373 2019-10-16  Jim Wilson  <jimw@sifive.com>
 374
 375         * riscv-tdep.c (riscv_gcc_target_options): New.
 376         (riscv_gnu_triplet_regexp): New.
 377         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 378         set_gdbarch_gnu_triplet_regexp.
 379
 380 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 381
 382         * Makefile.in: Add xml-builtin.h.
 383         * features/feature_to_c.sh: Add an include for xml-builtin.h
 384         to ensure that the compiler checks that the types match.
 385         * xml-builtin.h: New file.
 386         * xml-support.c (fetch_xml_builtin): Add missing const.
 387         * xml-support.h: Remove declaration of xml_builtins.
 388
 389 2019-10-16  Tom de Vries  <tdevries@suse.de>
 390
 391         PR tdep/25096
 392         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 393         (amd64_classify_aggregate): ... here.
 394         (amd64_classify_aggregate_field): Handled fiels of nested structs
 395         recursively.
 396
 397 2019-10-16  Tom de Vries  <tdevries@suse.de>
 398
 399         PR tdep/24104
 400         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 401         that handles 'theclass'.
 402
 403 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * linespec.c (decode_digits_ordinary): Update comment.
 406         * make-target-delegates: No longer need to handle VEC case.
 407         * memrange.c (normalize_mem_ranges): Update comment.
 408         * namespace.c (add_using_directive): Update comment.
 409         * objc-lang.c (uniquify_strings): Update comment.
 410         * ppc-linux-nat.c (struct thread_points): Update comment.
 411         * probe.h (find_probes_in_objfile): Update comment.
 412         * target.h (enum flash_preserve_mode): Update comment.
 413         * varobj.c (varobj_restrict_range): Update comment.
 414         * varobj.h (varobj_list_children): Update comment.
 415
 416 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 417
 418         * Makefile.in: Remove references to vec.h and vec.c.
 419         * aarch64-tdep.c: No longer include vec.h.
 420         * ada-lang.c: Likewise.
 421         * ada-lang.h: Likewise.
 422         * arm-tdep.c: Likewise.
 423         * ax.h: Likewise.
 424         * breakpoint.h: Likewise.
 425         * charset.c: Likewise.
 426         * cp-support.h: Likewise.
 427         * dtrace-probe.c: Likewise.
 428         * dwarf2read.c: Likewise.
 429         * extension.h: Likewise.
 430         * gdb_bfd.c: Likewise.
 431         * gdbsupport/gdb_vecs.h: Likewise.
 432         * gdbsupport/vec.c: Remove.
 433         * gdbsupport/vec.h: Remove.
 434         * gdbthread.h: Likewise.
 435         * guile/scm-type.c: Likewise.
 436         * inline-frame.c: Likewise.
 437         * machoread.c: Likewise.
 438         * memattr.c: Likewise.
 439         * memrange.h: Likewise.
 440         * namespace.h: Likewise.
 441         * nat/linux-btrace.h: Likewise.
 442         * osdata.c: Likewise.
 443         * parser-defs.h: Likewise.
 444         * progspace.h: Likewise.
 445         * python/py-type.c: Likewise.
 446         * record-btrace.c: Likewise.
 447         * rust-exp.y: Likewise.
 448         * solib-target.c: Likewise.
 449         * stap-probe.c: Likewise.
 450         * target-descriptions.c: Likewise.
 451         * target-memory.c: Likewise.
 452         * target.h: Likewise.
 453         * varobj.c: Likewise.
 454         * varobj.h: Likewise.
 455         * xml-support.h: Likewise.
 456
 457 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 458
 459         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 460         Update for new std::vector based implementation.
 461         (process_psymtab_comp_unit_reader): Likewise.
 462         (scan_partial_symbols): Likewise.
 463         (recursively_compute_inclusions): Likewise.
 464         (compute_compunit_symtab_includes): Likewise.
 465         (process_imported_unit_die): Likewise.
 466         (queue_and_load_dwo_tu): Likewise.
 467         (follow_die_sig_1): Likewise.
 468         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 469         (typedef dwarf2_per_cu_ptr): Remove.
 470         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 471         function.
 472         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 473         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 474         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 475         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 476         std::vector.
 477
 478 2019-10-15  Tom Tromey  <tromey@adacore.com>
 479
 480         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 481         TID.
 482
 483 2019-10-15  Tom Tromey  <tromey@adacore.com>
 484
 485         * windows-nat.c (windows_nat_target::fetch_registers)
 486         (windows_nat_target::store_registers): Rename "pid" to "tid".
 487
 488 2019-10-15  Tom Tromey  <tromey@adacore.com>
 489
 490         * gdbarch.h, gdbarch.c: Rebuild.
 491         * gdbarch.sh (gcc_target_options): Change return type to
 492         std::string.
 493         * compile/compile.c (get_args): Update.
 494         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 495         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 496         std::string.
 497         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 498         std::string.
 499         * arch-utils.c (default_gcc_target_options): Return std::string.
 500         * arch-utils.h (default_gcc_target_options): Return std::string.
 501         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 502
 503 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 504
 505         * breakpoint.c (breakpoint_chain): Make static.
 506         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 507         of accessing breakpoint_chain.
 508
 509 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 510
 511         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 512         to a gdb::function_view and return value to bool.
 513         * breakpoint.h (iterate_over_breakpoints): Likewise.
 514         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 515         (pop_dummy_frame): Update.
 516         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 517         (gdbscm_breakpoints): Update.
 518         * python/py-breakpoint.c (build_bp_list): Update.
 519         (gdbpy_breakpoints): Update.
 520         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 521         Update.
 522         (bpfinishpy_handle_stop): Update.
 523         (bpfinishpy_handle_exit): Update.
 524         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 525         (svr4_update_solib_event_breakpoints): Update.
 526
 527 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 528
 529         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 530         when unwrapping single-field structs.
 531
 532 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 533
 534         * dwarf2read.c: Remove includes.
 535
 536 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 537
 538         * ui-out.c (ui_out::call_do_message): Silence
 539         -Wformat-nonliteral warning.
 540
 541 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 542
 543         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 544         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 545         include: readline/tilde.h.
 546
 547 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 548
 549         * remote.c (remote_target::get_trace_status): Remove declaration of
 550         trace_regblock_size.
 551
 552 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 553
 554         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 555         (show_user): Remove declaration of cmdlist.
 556         * cli/cli-cmds.h (max_user_call_depth): Declare.
 557         * cli/cli-script.c (execute_user_command): Remove declaration
 558         of max_user_call_depth.
 559
 560 2019-10-11  Jim Wilson  <jimw@sifive.com>
 561
 562         * gdbsupport/print-utils.h (pulongest): Fix comment.
 563         (plongest): Likewise.
 564         (phex): Add missing comment, mention leading zeros.
 565         (phex_nz): Add mention of no leading zeros to comment.
 566
 567         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 568         plongest instead of unsigned long long cast.
 569
 570 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 573         for external_editor_command and gdbtk_test.
 574
 575 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 576
 577         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 578         * varobj.c (varobjdebug): Move comment to...
 579         * varobj.h (varobjdebug): ...here, and declare.
 580
 581 2019-10-09  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 584         erase_data_content.
 585
 586 2019-10-09  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 589         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 590         * tui/tui-command.c (tui_cmd_window::resize)
 591         (tui_refresh_cmd_win): Update.
 592         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 593         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 594         * tui/tui-data.c (~tui_gen_win_info): Remove.
 595         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 596         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 597         (tui_redisplay_readline, tui_mld_flush)
 598         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 599         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 600         (tui_data_window::erase_data_content)
 601         (tui_data_item_window::rerender)
 602         (tui_data_item_window::refresh_window): Update.
 603         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 604         (box_win, tui_gen_win_info::make_window)
 605         (tui_gen_win_info::make_visible): Update.
 606         (tui_delete_win): Remove.
 607         * tui/tui-winsource.c
 608         (tui_source_window_base::do_erase_source_content): Update.
 609         (tui_show_source_line, tui_source_window_base::update_tab_width)
 610         (tui_source_window_base::update_exec_info): Update.
 611         * tui/tui-data.h (struct curses_deleter): New.
 612         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 613         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 614
 615 2019-10-09  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 618
 619 2019-10-09  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 622         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 623
 624 2019-10-09  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 627         window height directly.
 628         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 629         declare.
 630         * tui/tui-layout.c (tui_default_win_height): Remove.
 631         (tui_default_win_viewport_height): Remove.
 632
 633 2019-10-09  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui.h: Remove comments.
 636
 637 2019-10-09  Tom de Vries  <tdevries@suse.de>
 638
 639         * python/lib/gdb/printer/bound_registers.py: Use
 640         '^builtin_type_bound128' as regexp argument for
 641         add_builtin_pretty_printer.
 642
 643 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 644
 645         * guile/guile.c (guile_extension_script_ops): Remove forward
 646         declaration and mark as static.
 647         (guile_script_ops): Likewise.
 648         (extension_language_guile): Move further down in the file so
 649         it can reference the definitions for guile_{extension_,}script_ops.
 650
 651 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 652
 653         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 654         except SORTL, DFLTCC, and KDSA.
 655
 656 2019-10-08  Tom Tromey  <tromey@adacore.com>
 657
 658         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 659         (struct safe_symbol_file_add_args): Remove.
 660
 661 2019-10-08  Tom Tromey  <tromey@adacore.com>
 662
 663         * windows-nat.c: Don't include buildsym-legacy.h.
 664
 665 2019-10-08  Tom Tromey  <tromey@adacore.com>
 666
 667         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 668
 669 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * gdbtypes.c (overload_debug): Move comment to header.
 672         * gdbtypes.h (overload_debug): Declare.
 673         * valops.c: Remove declaration of overload_debug, instead
 674         include gdbtypes.h.
 675
 676 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 677
 678         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 679         through _().
 680         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 681         move comment...
 682         * language.h (lang_frame_mismatch_warn): ... here. Also add
 683         declaration.
 684         * top.c (lang_frame_mismatch_warn): Remove declaration.
 685         (check_frame_language_change): Pass lang_frame_mismatch_warn
 686         through _().
 687
 688 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 689
 690         * c-lang.h (vtbl_ptr_name): Declare.
 691         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 692         it from the header.
 693         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 694
 695 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 696
 697         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 698         gdb_static_assert.
 699
 700 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 701
 702         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 703         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 704         * ctfread.c: New file.
 705         * ctfread.h: New file.
 706         * elfread.c: Include ctfread.h.
 707         (struct elfinfo text_p): New member ctfsect.
 708         (elf_locate_sections): Mark CTF section.
 709         (elf_symfile_read): Call elfctf_build_psymtabs.
 710         * Makefile.in (LIBCTF): Add.
 711         (CLIBS): Use it.
 712         (CDEPS): Likewise.
 713         (DIST): Add ctfread.c.
 714
 715 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * ctfread.c (struct nextfield): Renamed to ...
 718         (struct ctf_nextfield): ... this.
 719         (struct field_info): Renamed to ...
 720         (strut ctf_field_info): ... this.
 721         (attach_fields_to_type): Update for renamed structures.
 722         (ctf_add_member_cb): Likewise.
 723         (ctf_add_enum_member_cb): Likewise.
 724         (process_struct_members): Likewise.
 725         (process_enum_type): Likewise.
 726
 727 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 728
 729         * tracectf.h: Rename, was ctf.h.
 730         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 731         * tracefile.c: Likewise.
 732         * tracepoint.c: Remove unused include ctf.h.
 733         * mi/mi-main.c: Likewise.
 734         * Makefile.in Replace ctf.c with tracectf.c.
 735
 736 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 737
 738         * version.in: Change version number to "9.0.50.DATE-git".
 739
 740 2019-10-03  Tom Tromey  <tom@tromey.com>
 741
 742         PR rust/24976:
 743         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 744
 745 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 748         cp_search_name_hash.
 749         * NEWS: Add entry about nested function support.
 750
 751 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 752             Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 755         for nested static variables when searchin VAR_DOMAIN.
 756         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 757         global scope, update comment.
 758         (add_partial_subprogram): Call add_partial_subprogram recursively
 759         for nested subroutines when processinng Fortran.
 760         (load_partial_dies): Process the child entities of a subprogram
 761         when processing Fortran.
 762         (partial_die_parent_scope): Handle building scope
 763         for Fortran nested functions.
 764         (process_die): Record that nested functions have a scope.
 765         (new_symbol): Always record Fortran subprograms on the global
 766         symbol list.
 767         (determine_prefix): How to build the prefix for Fortran
 768         subprograms.
 769
 770 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 773         have just sent the thread a SIGSTOP and are waiting for it to
 774         arrive.
 775
 776 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * btrace.c (btrace_add_pc): Remove whitespace before the template
 779         parameter in 'std::vector <...>'.
 780         (parse_xml_btrace_block): Likewise.
 781         (btrace_maint_decode_pt): Likewise.
 782         (btrace_maint_update_packets): Likewise.
 783         (btrace_maint_print_packets): Likewise.
 784         * btrace.h (struct btrace_maint_info): Likewise.
 785         * dwarf2read.c (struct type_unit_group): Likewise.
 786         (build_type_psymtabs_reader): Likewise.
 787         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 788         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 789         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 790
 791 2019-10-03  Tom de Vries  <tdevries@suse.de>
 792
 793         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 794         the first line of the help text for set/show style metadata.
 795
 796 2019-10-02  Tom Tromey  <tromey@adacore.com>
 797
 798         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 799         * gdbsupport/common-inferior.c: New file.
 800         * infcmd.c (startup_with_shell): Don't define.
 801         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 802         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 803         * inferior.h (startup_with_shell): Don't declare.
 804
 805 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 806
 807         * gdbsupport/gdb_assert.h: Include errors.h.
 808         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 809
 810 2019-10-02  Tom Tromey  <tromey@adacore.com>
 811
 812         * NEWS: Add $_ada_exception entry.
 813         * ada-lang.c (struct ada_catchpoint): Add constructor.
 814         <m_kind>: New member.
 815         (allocate_location_exception, re_set_exception): Remove
 816         "ex" parameter.
 817         (should_stop_exception): Compute $_ada_exception.
 818         (check_status_exception, print_it_exception)
 819         (print_one_exception, print_mention_exception): Remove
 820         "ex" parameter.
 821         (allocate_location_catch_exception, re_set_catch_exception)
 822         (check_status_exception, print_it_catch_exception)
 823         (print_one_catch_exception, print_mention_catch_exception)
 824         (print_recreate_catch_exception)
 825         (allocate_location_catch_exception_unhandled)
 826         (re_set_catch_exception_unhandled)
 827         (check_status_exception, print_it_catch_exception_unhandled)
 828         (print_one_catch_exception_unhandled)
 829         (print_mention_catch_exception_unhandled)
 830         (print_recreate_catch_exception_unhandled)
 831         (allocate_location_catch_assert, re_set_catch_assert)
 832         (check_status_assert, print_it_catch_assert)
 833         (print_one_catch_assert, print_mention_catch_assert)
 834         (print_recreate_catch_assert)
 835         (allocate_location_catch_handlers, re_set_catch_handlers)
 836         (check_status_handlers, print_it_catch_handlers)
 837         (print_one_catch_handlers, print_mention_catch_handlers)
 838         (print_recreate_catch_handlers): Remove.
 839         (create_ada_exception_catchpoint): Update.
 840         (initialize_ada_catchpoint_ops): Update.
 841
 842 2019-10-02  Tom Tromey  <tromey@adacore.com>
 843
 844         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 845         (create_excep_cond_exprs): Simplify exception string computation.
 846         (ada_exception_catchpoint_cond_string): Likewise.
 847
 848 2019-10-02  Tom Tromey  <tromey@adacore.com>
 849
 850         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 851         * ada-lang.c (lesseq_defined_than): Handle
 852         LOC_STATIC.
 853         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 854         parameter.
 855         (dwarf2_has_info): Likewise.
 856         (new_symbol): Set maybe_copied on symbol when
 857         appropriate.
 858         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 859         parameter.
 860         <can_copy>: New member.
 861         * elfread.c (record_minimal_symbol): Set maybe_copied
 862         on symbol when appropriate.
 863         (elf_symfile_read): Update call to dwarf2_has_info.
 864         * minsyms.c (lookup_minimal_symbol_linkage): New
 865         function.
 866         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 867         * symtab.c (get_symbol_address, get_msymbol_address):
 868         New functions.
 869         * symtab.h (get_symbol_address, get_msymbol_address):
 870         Declare.
 871         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 872         maybe_copied.
 873         (struct symbol, struct minimal_symbol) <maybe_copied>:
 874         New member.
 875
 876 2019-10-02  Tom Tromey  <tromey@adacore.com>
 877
 878         * source.c (struct current_source_location): New.
 879         (current_source_key): New global.
 880         (current_source_symtab, current_source_line)
 881         (current_source_pspace): Remove.
 882         (get_source_location): New function.
 883         (get_current_source_symtab_and_line)
 884         (set_default_source_symtab_and_line)
 885         (set_current_source_symtab_and_line)
 886         (clear_current_source_symtab_and_line, select_source_symtab)
 887         (info_source_command, print_source_lines_base)
 888         (info_line_command, search_command_helper, _initialize_source):
 889         Update.
 890
 891 2019-10-02  Tom Tromey  <tromey@adacore.com>
 892
 893         * source.c (select_source_symtab): Don't call
 894         decode_line_with_current_source.
 895
 896 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * symtab.c (lookup_global_symbol): Search global block.
 899
 900 2019-10-02  Tom Tromey  <tromey@adacore.com>
 901
 902         * coffread.c (process_coff_symbol): Update.
 903         * dwarf2read.c (var_decode_location, new_symbol): Update.
 904         * mdebugread.c (parse_symbol): Update.
 905         * objfiles.c (relocate_one_symbol): Update.
 906         * stabsread.c (define_symbol, fix_common_block)
 907         (scan_file_globals): Update.
 908         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 909         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 910         * xcoffread.c (process_xcoff_symbol): Update.
 911
 912 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 913
 914         * MAINTAINERS: Update my email address.
 915
 916 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 919         std::vector.
 920         (build_type_psymtabs_reader): Update for std::vector.
 921         (build_type_psymtab_dependencies): Likewise.
 922         * dwarf2read.h: Remove use of DEF_VEC_P.
 923         (typedef sig_type_ptr): Delete.
 924
 925 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 928         to std::vector.
 929         (btrace_maint_decode_pt): Likewise, and move allocation of the
 930         vector outside of the loop.
 931         (btrace_maint_update_packets): Update to handle change from VEC to
 932         std::vector.
 933         (btrace_maint_print_packets): Likewise.
 934         (maint_info_btrace_cmd): Likewise.
 935         * btrace.h: Remove use of DEF_VEC_O.
 936         (typedef btrace_pt_packet_s): Delete.
 937         (struct btrace_maint_info) <packets>: Change fromm VEC to
 938         std::vector.
 939         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 940
 941 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 942
 943         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 944         make accesses into the vector constant references.
 945         (btrace_add_pc): Update for std::vector.
 946         (btrace_stitch_bts): Likewise.
 947         (parse_xml_btrace_block): Likewise.
 948         (btrace_maint_update_packets): Likewise.
 949         (btrace_maint_print_packets): Likewise.
 950         (maint_info_btrace_cmd): Likewise.
 951         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 952         std::vector.
 953         (btrace_data::empty): Likewise.
 954         (btrace_data_append): Likewise.
 955         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 956         (typedef btrace_block_s): Delete.
 957         (struct btrace_block): Add constructor.
 958         (struct btrace_data_bts) <blocks>: Change to std::vector.
 959         * nat/linux-btrace.c (perf_event_read_bts): Update for
 960         std::vector.
 961         (linux_read_bts): Likewise.
 962
 963 2019-10-01  Tom Tromey  <tom@tromey.com>
 964
 965         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 966
 967 2019-10-01  Tom Tromey  <tom@tromey.com>
 968
 969         * stack.c (print_frame, info_frame_command_core): Use
 970         styled_string.
 971         * linux-thread-db.c (try_thread_db_load_1)
 972         (try_thread_db_load_from_pdir_1): Use styled_string.
 973         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 974         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 975         (maybe_print_unsupported_script_warning)
 976         (maybe_print_script_not_found_warning): Use styled_string.
 977         * ada-lang.c (user_select_syms): Use styled_string.
 978
 979 2019-10-01  Tom Tromey  <tom@tromey.com>
 980
 981         * p-lang.c (pascal_printstr): Use metadata style.
 982         * value.c (show_convenience): Use metadata style.
 983         * valprint.c (valprint_check_validity, val_print_optimized_out)
 984         (val_print_not_saved, val_print_unavailable)
 985         (val_print_invalid_address, generic_val_print, val_print)
 986         (value_check_printable, val_print_array_elements): Use metadata
 987         style.
 988         * ui-out.h (class ui_out) <field_fmt>: New overload.
 989         <do_field_fmt>: Add style parameter.
 990         * ui-out.c (ui_out::field_fmt): New overload.
 991         * typeprint.c (type_print_unknown_return_type)
 992         (val_print_not_allocated, val_print_not_associated): Use metadata
 993         style.
 994         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 995         parameter.
 996         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 997         * tracepoint.c (tvariables_info_1): Use metadata style.
 998         * stack.c (print_frame_arg, print_frame_info, print_frame)
 999         (info_frame_command_core): Use metadata style.
1000         * skip.c (info_skip_command): Use metadata style.
1001         * rust-lang.c (rust_print_enum): Use metadata style.
1002         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1003         metadata style.
1004         * python/py-framefilter.c (py_print_single_arg): Use metadata
1005         style.
1006         * printcmd.c (do_one_display, print_variable_and_value): Use
1007         metadata style.
1008         * p-valprint.c (pascal_val_print)
1009         (pascal_object_print_value_fields): Use metadata style.
1010         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1011         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1012         parameter.
1013         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1014         * m2-valprint.c (m2_print_long_set): Use metadata style.
1015         * m2-typeprint.c (m2_print_type): Use metadata style.
1016         * infcmd.c (print_return_value_1): Use metadata style.
1017         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1018         * f-valprint.c (info_common_command_for_block): Use metadata
1019         style.
1020         * f-typeprint.c (f_type_print_base): Use metadata style.
1021         * expprint.c (print_subexp_standard): Use metadata style.
1022         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1023         * cli/cli-style.h (class cli_style_option): Add constructor.
1024         (metadata_style): Declare.
1025         * cli/cli-style.c (metadata_style): New global.
1026         (_initialize_cli_style): Register metadata style.
1027         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1028         parameter.
1029         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1030         * c-typeprint.c (c_type_print_base_struct_union)
1031         (c_type_print_base_1): Use metadata style.
1032         * breakpoint.c (watchpoint_value_print)
1033         (print_one_breakpoint_location): Use metadata style.
1034         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1035         style.
1036         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1037         style.
1038         * ada-valprint.c (val_print_packed_array_elements, printstr)
1039         (print_field_values, ada_val_print_ref, ada_val_print): Use
1040         metadata style.
1041         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1042         style.
1043         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1044         style.
1045         * ada-lang.c (user_select_syms): Use metadata style.
1046
1047 2019-10-01  Tom Tromey  <tom@tromey.com>
1048
1049         * cli/cli-cmds.c (pwd_command): Style output.
1050
1051 2019-10-01  Pedro Alves  <palves@redhat.com>
1052             Tom Tromey  <tom@tromey.com>
1053
1054         * symtab.c (print_symbol_info): Use %ps.
1055         (print_msymbol_info): Use %ps.
1056         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1057         * printcmd.c (print_variable_and_value): Use %ps.
1058         * macrocmd.c (show_pp_source_pos): Use %ps.
1059         * infrun.c (print_exited_reason): Use ui_out::message.
1060         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1061         (describe_other_breakpoints): Use ui_out::message and new
1062         formats.
1063         (say_where): Use new formats.
1064         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1065         and new formats.
1066
1067 2019-10-01  Pedro Alves  <palves@redhat.com>
1068             Tom Tromey  <tom@tromey.com>
1069
1070         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1071         (test_gdb_formats): New function.
1072         (run_tests): Call it.
1073         (test_format_specifier): Update.
1074         * utils.h (fputs_filtered): Update comment.
1075         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1076         (fputs_styled_unfiltered): Declare.
1077         * utils.c (fputs_styled_unfiltered): New function.
1078         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1079         (vfprintf_filtered): Update.
1080         (vfprintf_unfiltered, vprintf_filtered): Update.
1081         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1082         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1083         disallow_ui_out_field>: New constants.
1084         (enum class field_kind): New.
1085         (struct base_field_s, struct signed_field_s): New.
1086         (signed_field): New function.
1087         (struct string_field_s): New.
1088         (string_field): New function.
1089         (struct styled_string_s): New.
1090         (styled_string): New function.
1091         (class ui_out) <message>: Add comment.
1092         <vmessage, call_do_message>: New methods.
1093         <do_message>: Add style parameter.
1094         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1095         methods.
1096         (ui_out::message): Rewrite.
1097         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1098         parameter.
1099         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1100         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1101         gdb_extensions parameter.
1102         (class format_piece): Add parameter to constructor.
1103         (n_int_args): New field.
1104         * gdbsupport/format.c (format_pieces::format_pieces): Add
1105         gdb_extensions parameter.  Handle '*'.
1106         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1107         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1108         vfprintf_styled_no_gdbfmt.
1109         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1110         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1111         unfiltered output.
1112         * ui-style.h (struct ui_file_style) <ptr>: New method.
1113
1114 2019-10-01  Tom Tromey  <tom@tromey.com>
1115
1116         * unittests/format_pieces-selftests.c: Update.  Add final format.
1117         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1118         empty literal pieces.
1119
1120 2019-10-01  Tom Tromey  <tom@tromey.com>
1121
1122         * ui-out.h (enum class ui_out_style_kind): Remove.
1123         (class ui_out) <field_string, field_stsream, do_field_string>:
1124         Change type of "style".
1125         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1126         (ui_out::field_string): Update.
1127         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1128         of "style".
1129         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1130         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1131         * stack.c (print_frame_arg, print_frame_info, print_frame):
1132         Update.
1133         * source.c (print_source_lines_base): Update.
1134         * solib.c (info_sharedlibrary_command): Update.
1135         * skip.c (info_skip_command): Update.
1136         * record-btrace.c (btrace_call_history_src_line)
1137         (btrace_call_history): Update.
1138         * python/py-framefilter.c (py_print_frame): Update.
1139         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1140         "style".
1141         * mi/mi-out.c (mi_ui_out::do_table_header)
1142         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1143         (mi_ui_out::do_field_string): Update.
1144         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1145         Update.
1146         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1147         "style".
1148         * cli-out.c (cli_ui_out::do_table_header)
1149         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1150         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1151         (cli_ui_out::do_field_fmt): Update.
1152         * breakpoint.c (print_breakpoint_location): Update.
1153         (update_static_tracepoint): Update.
1154
1155 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1156
1157         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1158         conversion of gdb_datadir.
1159         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1160         remove not needed c_str ().
1161
1162 2019-09-30  Ali Tamur <tamur@google.com>
1163
1164         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1165         (dwarf2_string_attr): Likewise.
1166
1167 2019-09-30  Ali Tamur <tamur@google.com>
1168
1169         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1170         (process_full_type_unit): Likewise.
1171         (dump_die_shallow): Likewise.
1172         (cu_debug_loc_section): Likewise.
1173
1174 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1175
1176         * minsyms.c (compare_minimal_symbols): Rename to...
1177         (minimal_symbol_is_less_than): ...this, and adjust to STL
1178         conventions (return bool, take arguments as references)
1179         (minimal_symbol_reader::install): Call std::sort instead
1180         of qsort.
1181
1182 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1183
1184         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1185         hash and why.
1186         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1187         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1188
1189 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1190
1191         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1192         * psympriv.h (add_psymbol_to_list): Move comment here and update
1193         it.
1194
1195 2019-09-29  Tom de Vries  <tdevries@suse.de>
1196
1197         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1198         Use $tmpdir/$(basename "$output_file").dwz instead of
1199         "${output_file}.dwz".
1200
1201 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1202
1203         PR gdb/25045
1204         * hppa-linux-nat.c: Include gdbarch.h.
1205
1206 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1207
1208         * blockframe.c (find_pc_partial_function): Change return type to bool.
1209         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1210         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1211         (stub_gnu_ifunc_resolve_name): Likewise.
1212         * symtab.c (compare_filenames_for_search): Likewise.
1213         (compare_glob_filenames_for_search): Likewise.
1214         (matching_obj_sections): Likewise.
1215         (symbol_matches_domain): Likewise.
1216         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1217         (find_line_pc): Change return type to bool.
1218         (find_line_pc_range): Likewise.
1219         (producer_is_realview): Likewise.
1220         * symtab.h (symbol_matches_domain): Likewise.
1221         (find_pc_partial_function): Likewise.
1222         (find_pc_line_pc_range): Likewise.
1223         (in_gnu_ifunc_stub): Likewise.
1224         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1225         (find_line_pc): Likewise.
1226         (find_line_pc_range): Likewise.
1227         (matching_obj_sections): Likewise.
1228         (find_line_symtab): Change out parameter to bool.
1229         (producer_is_realview): Change return type to bool.
1230         (compare_filenames_for_search): Likewise.
1231         (compare_glob_filenames_for_search): Likewise.
1232
1233 2019-09-26  Tom Tromey  <tom@tromey.com>
1234
1235         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1236         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1237         * gdb_usleep.h: Remove.
1238         * gdb_usleep.c: Remove.
1239         * utils.c: Don't include gdb_usleep.h.
1240
1241 2019-09-26  Tom Tromey  <tromey@adacore.com>
1242
1243         * python/py-type.c (type_to_type_object): Call check_typedef
1244         for stub types.
1245
1246 2019-09-26  Tom Tromey  <tom@tromey.com>
1247
1248         * utils.h (initialize_utils): Don't declare.
1249         * top.c (gdb_init): Don't call initialize_utils.
1250         * utils.c (initialize_utils): Remove.  Move contents...
1251         (_initialize_utils): ... here.
1252
1253 2019-09-25  Tom Tromey  <tom@tromey.com>
1254
1255         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1256         * utils.h (make_hex_string): Don't declare.
1257         * utils.c (make_hex_string): Remove.
1258
1259 2019-09-24  Tom de Vries  <tdevries@suse.de>
1260
1261         PR gdb/23815
1262         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1263         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1264
1265 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1266
1267         * NEWS: Mention new simulator port for PRU.
1268
1269 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1270
1271         * ada-exp.y (write_object_remaining): Update.
1272         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1273         and eliminate the static buffer.
1274         (ada_decode_symbol): Update.
1275         (ada_la_decode): Update.
1276         (ada_sniff_from_mangled_name): Update.
1277         (is_valid_name_for_wild_match): Update.
1278         (ada_lookup_name_info::matches): Update and simplify.
1279         (name_matches_regex): Update.
1280         (ada_add_global_exceptions): Update.
1281         * ada-lang.h (ada_decode): Update signature.
1282         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1283         * dwarf-index-write.c (debug_names::insert): Update.
1284
1285 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1286
1287         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1288         formatting.
1289
1290 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1291
1292         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1293         Change "nonzero" to "true" in documentation.
1294
1295 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1296
1297         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1298         (_initialize_darwin_solib): Don't set
1299         darwin_so_ops.lookup_lib_global_symbol.
1300         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1301         set_gdbarch_iterate_over_objfiles_in_search_order.
1302         (elf_lookup_lib_symbol): Rename to...
1303         (svr4_iterate_over_objfiles_in_search_order): this, and update
1304         to iterate semantics.
1305         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1306         * solib.c (solib_global_lookup): Remove.
1307         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1308         (solib_global_lookup): Remove.
1309         * symtab.c (lookup_global_or_static_symbol): Remove call to
1310         solib_global_lookup.
1311
1312 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1313
1314         * NEWS: Move entries about default MI version now being
1315         version 3, and about the GDB/MI fix for multi-location
1316         breakpoints to the "since GDB 8.3" section.
1317
1318 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1319
1320         GDB 8.3.1 released.
1321
1322 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1323
1324         * NEWS: Mention that Cell/B.E. debugging support was removed.
1325         * MAINTAINERS: Remove spu target.
1326
1327         * config/djgpp/fnchange.lst: Remove entries for removed files.
1328
1329         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1330         spu-multiarch.o, and spu-tdep.o.
1331         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1332         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1333         spu-multiarch.c, and spu-tdep.c.
1334         * spu-linux-nat.c: Remove file.
1335         * spu-multiarch.c: Remove file.
1336         * spu-tdep.c: Remove file.
1337         * spu-tdep.h: Remove file.
1338         * solib-spu.c: Remove file.
1339         * solib-spu.h: Remove file.
1340
1341         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1342         * configure.nat (spu-linux): Remove.
1343         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1344         solib-multiarch.o from gdb_target_obs.
1345         (spu*-*-*): Remove.
1346
1347         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1348         feature flag.
1349         (ppc_linux_no_features): Update.
1350         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1351         Cell/B.E. support.
1352         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1353         (tdesc_powerpc_cell64l): Likewise.
1354         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1355         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1356         Cell/B.E. support.
1357         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1358         Do not include "features/rs6000/powerpc-cell32l.c" or
1359         "features/rs6000/powerpc-cell64l.c".
1360         (ppc_linux_spu_section): Remove.
1361         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1362         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1363         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1364         (ppc_linux_spe_context_lookup): Remove.
1365         (ppc_linux_spe_context_inferior_created): Remove.
1366         (ppc_linux_spe_context_solib_loaded): Remove.
1367         (ppc_linux_spe_context_solib_unloaded): Remove.
1368         (ppc_linux_spe_context): Remove.
1369         (struct ppu2spu_cache): Remove.
1370         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1371         (struct ppu2spu_data): Remove.
1372         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1373         ppu2spu_unwind): Remove.
1374         (ppc_linux_init_abi): Remove Cell/B.E. support.
1375         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1376
1377         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1378         (rs6000/powerpc-cell64l-expedite): Likewise
1379         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1380         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1381         rs6000/powerpc-cell64l.xml.
1382         * features/rs6000/powerpc-cell32l.xml: Remove.
1383         * features/rs6000/powerpc-cell64l.xml: Likewise.
1384         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1385         * features/rs6000/powerpc-cell64l.c: Likewise.
1386         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1387         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1388         * regformats/reg-spu.dat: Remove.
1389
1390         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1391         * corelow.c (struct spuid_list): Remove.
1392         (add_to_spuid_list): Remove.
1393         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1394         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1395         (remote_protocol_features): Remove associated entries.
1396         (_initialize_remote): No longer initialize them.
1397         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1398         * linux-nat.c (SPUFS_MAGIC): Remove.
1399         (linux_proc_xfer_spu): Remove.
1400         (spu_enumerate_spu_ids): Remove.
1401         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1402         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1403         (linux_make_corefile_notes): No longer call it.
1404
1405         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1406         (cooked_write_test): Likewise.
1407
1408 2019-09-20  Tom Tromey  <tom@tromey.com>
1409
1410         * NEWS: Mention case-sensitivity of TUI commands.
1411         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1412         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1413         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1414
1415 2019-09-20  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-source.c (tui_source_window::set_contents): Use
1418         make_unique_xstrdup.
1419         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1420         make_unique_xstrdup.
1421
1422 2019-09-20  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-data.c: Remove separator comments.
1425         * tui/tui-layout.c: Remove separator comments.
1426         * tui/tui-win.c: Remove separator comments.
1427         * tui/tui-wingeneral.c: Remove separator comments.
1428
1429 2019-09-20  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui.h (strcat_to_buf): Don't declare.
1432         * tui/tui.c (strcat_to_buf): Remove.
1433
1434 2019-09-20  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1437         from "fullname".
1438         * tui/tui-source.c (tui_source_window::set_contents)
1439         (tui_source_window::location_matches_p)
1440         (tui_source_window::maybe_update): Update.
1441
1442 2019-09-20  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1445         Update.
1446         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1447         prefix.
1448         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1449         (tui_data_window::line_from_reg_element_no)
1450         (tui_data_window::first_reg_element_no_inline)
1451         (tui_data_window::show_registers)
1452         (tui_data_window::show_register_group)
1453         (tui_data_window::display_registers_from)
1454         (tui_data_window::display_registers_from_line)
1455         (tui_data_window::first_data_item_displayed)
1456         (tui_data_window::delete_data_content_windows)
1457         (tui_data_window::erase_data_content)
1458         (tui_data_window::do_scroll_vertical)
1459         (tui_data_window::refresh_window)
1460         (tui_data_window::check_register_values): Update.
1461
1462 2019-09-20  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1465         (struct tui_locator_window) <full_name, proc_name>: Now
1466         std::string.
1467         * tui/tui-stack.c (tui_locator_window::make_status_line)
1468         (tui_locator_window::set_locator_fullname)
1469         (tui_locator_window::set_locator_info): Update.
1470         * tui/tui-source.c (tui_source_window::set_contents)
1471         (tui_source_window::showing_source_p): Update.
1472
1473 2019-09-20  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1476         Don't call tui_locator_win_info_ptr.
1477
1478 2019-09-20  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1481
1482 2019-09-20  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1485         height for locator.
1486         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1487         * tui/tui-layout.c (show_source_disasm_command, show_data)
1488         (show_source_or_disasm_and_command): Use 1 as height for locator.
1489
1490 2019-09-20  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui.c (tui_enable): Update.
1493         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1494         Update.
1495         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1496         Update.
1497         * tui/tui-data.c (win_resized): Now bool.
1498         (tui_win_resized): Return bool.
1499         (tui_set_win_resized_to): Accept a bool.
1500
1501 2019-09-20  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1504         Change type of "refresh_values_only".
1505         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1506         type of "refresh_values_only".
1507
1508 2019-09-20  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1511         std::string.
1512         (tui_disassemble): Add "pos" parameter.
1513         (tui_disasm_window::set_contents): Simplify.
1514
1515 2019-09-20  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-winsource.h (struct tui_source_window_base)
1518         <show_source_content>: Now private.
1519         * tui/tui-winsource.c
1520         (tui_source_window_base::show_source_content): Don't handle empty
1521         content case.
1522
1523 2019-09-20  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-layout.c (show_source_disasm_command)
1526         (show_source_or_disasm_and_command): Don't call
1527         show_source_content.
1528
1529 2019-09-20  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1532         Declare.
1533         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1534         from tui_make_status_line.
1535         (tui_locator_window::rerender): Update.
1536
1537 2019-09-20  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1540         (tui_locator_window::rerender): Update.
1541
1542 2019-09-20  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-winsource.h (struct tui_source_window_base)
1545         <~tui_source_window_base>: Don't declare.
1546         <fullname>: Remove.
1547         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1548         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1549         member.
1550         * tui/tui-source.c (tui_source_window::set_contents): Update.
1551         (tui_source_window::location_matches_p)
1552         (tui_source_window::maybe_update): Update.
1553
1554 2019-09-20  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-winsource.h (~tui_source_element): Remove.
1557         (tui_source_element): Update.
1558         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1559         * tui/tui-winsource.c (tui_show_source_line): Update.
1560         * tui/tui-source.c (tui_source_window::set_contents): Update.
1561         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1562
1563 2019-09-20  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1566         declare.
1567         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1568         tui_clear_source_windows_detail.
1569         * tui/tui-winsource.h (struct tui_source_window_base)
1570         <clear_detail>: Don't declare.
1571         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1572         Remove.
1573         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1574
1575 2019-09-20  Tom Tromey  <tromey@adacore.com>
1576
1577         PR ada/24919:
1578         * block.c (contained_in): Fix final return value.
1579
1580 2019-09-20  Alan Modra  <amodra@gmail.com>
1581
1582         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1583         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1584         (read_indirect_string_from_dwz): Use bfd accessor.
1585         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1586         * machoread.c (macho_symfile_read_all_oso): Likewise.
1587         * solib.c (solib_bfd_open): Likewise.
1588
1589 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1590
1591         * eval.c: Move declaration of overload_resolution to...
1592         * value.h: ...here.
1593
1594 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1595
1596         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1597         * arm-linux-tdep.c: Likewise.
1598         * arm-nbsd-nat.c: Likewise.
1599         * arm-tdep.h: Declare arm_apcs_32.
1600         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1601
1602 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1603
1604         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1605         * dwarf2read.h: Declare dwarf_always_disassemble.
1606
1607 2019-09-19  Tom de Vries  <tdevries@suse.de>
1608
1609         PR gdb/25009
1610         * source-cache.c (source_cache::ensure): Catch exception thrown during
1611         construction of the highlighter.
1612
1613 2019-09-18  Alan Modra  <amodra@gmail.com>
1614
1615         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1616         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1617         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1618         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1619         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1620         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1621         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1622         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1623         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1624         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1625         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1626         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1627         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1628         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1629         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1630         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1631         * mi/mi-interp.c: Update throughout for bfd section macro and
1632         function changes.
1633         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1634         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1635
1636 2019-09-18  Tom Tromey  <tom@tromey.com>
1637
1638         * NEWS: Add entry.
1639         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1640         call rl_initialize.
1641         (tui_enable): Do not call rl_initialize.
1642
1643 2019-09-18  Christian Groessler  <chris@groessler.org>
1644
1645         * alpha-linux-nat.c: Include gdbarch.h.
1646
1647 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1648
1649         * ui-file.c: Include cli/cli-style.h.
1650         (term_cli_styling): Remove cli_styling declaration.
1651
1652 2019-09-18  Alan Modra  <amodra@gmail.com>
1653
1654         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1655         to bfd_asymbol_section.
1656
1657 2019-09-18  Alan Modra  <amodra@gmail.com>
1658
1659         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1660         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1661         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1662
1663 2019-09-18  Alan Modra  <amodra@gmail.com>
1664
1665         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1666         * spu-linux-nat.c (spu_bfd_open): Likewise.
1667
1668 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1669
1670         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1671         to bool to match definition in dwarf2read.c.
1672
1673 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1674
1675         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1676         (print_signatures): Likewise.
1677         (trust_pad_over_xvs): Likewise.
1678         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1679         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1680         * arm-linux-nat.c (arm_apcs_32): Likewise.
1681         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1682         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1683         * arm-tdep.c (arm_debug): Likewise.
1684         (arm_apcs_32): Likewise.
1685         * auto-load.c (debug_auto_load): Likewise.
1686         (auto_load_gdb_scripts): Likewise.
1687         (global_auto_load): Likewise.
1688         (auto_load_local_gdbinit): Likewise.
1689         (auto_load_local_gdbinit_loaded): Likewise.
1690         * auto-load.h (global_auto_load): Likewise.
1691         (auto_load_local_gdbinit): Likewise.
1692         (auto_load_local_gdbinit_loaded): Likewise.
1693         * breakpoint.c (disconnected_dprintf): Likewise.
1694         (breakpoint_proceeded): Likewise.
1695         (automatic_hardware_breakpoints): Likewise.
1696         (always_inserted_mode): Likewise.
1697         (target_exact_watchpoints): Likewise.
1698         (_initialize_breakpoint): Update.
1699         * breakpoint.h (target_exact_watchpoints): Change to bool.
1700         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1701         * cli/cli-cmds.c (trace_commands): Likewise.
1702         * cli/cli-cmds.h (trace_commands): Likewise.
1703         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1704         to bool*.
1705         * cli/cli-logging.c (logging_overwrite): Change to bool.
1706         (logging_redirect): Likewise.
1707         (debug_redirect): Likewise.
1708         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1709         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1710         to bool.
1711         <boolean_option_def>: Update.
1712         (struct flag_option_def): Change default type of Context to bool
1713         from int.
1714         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1715         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1716         (get_setshow_command_value_string): Likewise.
1717         * cli/cli-style.c (cli_styling): Change to bool.
1718         (source_styling): Likewise.
1719         * cli/cli-style.h (source_styling): Likewise.
1720         (cli_styling): Likewise.
1721         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1722         to bool.
1723         * command.h (var_types): Update comment.
1724         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1725         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1726         bool.
1727         (debug_compile_cplus_scopes): Likewise.
1728         * compile/compile-internal.h (compile_debug): Likewise.
1729         * compile/compile.c (compile_debug): Likewise.
1730         (struct compile_options) <raw>: Likewise.
1731         * cp-support.c (catch_demangler_crashes): Likewise.
1732         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1733         (usr_cmd_cris_dwarf2_cfi): Likewise.
1734         * csky-tdep.c (csky_debug): Likewise.
1735         * darwin-nat.c (enable_mach_exceptions): Likewise.
1736         * dcache.c (dcache_enabled_p): Likewise.
1737         * defs.h (info_verbose): Likewise.
1738         * demangle.c (demangle): Likewise.
1739         (asm_demangle): Likewise.
1740         * dwarf-index-cache.c (debug_index_cache): Likewise.
1741         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1742         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1743         * dwarf2read.c (check_physname): Likewise.
1744         (use_deprecated_index_sections): Likewise.
1745         (dwarf_always_disassemble): Likewise.
1746         * eval.c (overload_resolution): Likewise.
1747         * event-top.c (set_editing_cmd_var): Likewise.
1748         (exec_done_display_p): Likewise.
1749         * event-top.h (set_editing_cmd_var): Likewise.
1750         (exec_done_display_p): Likewise.
1751         * exec.c (write_files): Likewise.
1752         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1753         (debug_fbsd_nat): Likewise.
1754         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1755         Likewise.
1756         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1757         <backtrace_past_entry> Likewise.
1758         * gdb-demangle.h (demangle): Likewise.
1759         (asm_demangle): Likewise.
1760         * gdb_bfd.c (bfd_sharing): Likewise.
1761         * gdbcore.h (write_files): Likewise.
1762         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1763         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1764         * gdbthread.h (print_thread_events): Likewise.
1765         * gdbtypes.c (opaque_type_resolution): Likewise.
1766         (strict_type_checking): Likewise.
1767         * gnu-nat.c (gnu_debug_flag): Likewise.
1768         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1769         * guile/scm-param.c (pascm_variable): Add boolval.
1770         (add_setshow_generic): Update.
1771         (pascm_param_value): Update.
1772         (pascm_set_param_value_x): Update.
1773         * hppa-tdep.c (hppa_debug): Change to bool..
1774         * infcall.c (may_call_functions_p): Likewise.
1775         (coerce_float_to_double_p): Likewise.
1776         (unwind_on_signal_p): Likewise.
1777         (unwind_on_terminating_exception_p): Likewise.
1778         * infcmd.c (startup_with_shell): Likewise.
1779         * inferior.c (print_inferior_events): Likewise.
1780         * inferior.h (startup_with_shell): Likewise.
1781         (print_inferior_events): Likewise.
1782         * infrun.c (step_stop_if_no_debug): Likewise.
1783         (detach_fork): Likewise.
1784         (debug_displaced): Likewise.
1785         (disable_randomization): Likewise.
1786         (non_stop): Likewise.
1787         (non_stop_1): Likewise.
1788         (observer_mode): Likewise.
1789         (observer_mode_1): Likewise.
1790         (set_observer_mode): Update.
1791         (sched_multi): Change to bool.
1792         * infrun.h (debug_displaced): Likewise.
1793         (sched_multi): Likewise.
1794         (step_stop_if_no_debug): Likewise.
1795         (non_stop): Likewise.
1796         (disable_randomization): Likewise.
1797         * linux-tdep.c (use_coredump_filter): Likewise.
1798         (dump_excluded_mappings): Likewise.
1799         * linux-thread-db.c (auto_load_thread_db): Likewise.
1800         (check_thread_db_on_load): Likewise.
1801         * main.c (captured_main_1): Update.
1802         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1803         xx2_opt, boolean_opt>: Change to bool.
1804         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1805         * maint.c (maintenance_profile_p): Likewise.
1806         (per_command_time): Likewise.
1807         (per_command_space): Likewise.
1808         (per_command_symtab): Likewise.
1809         * memattr.c (inaccessible_by_default): Likewise.
1810         * mi/mi-main.c (mi_async): Likewise.
1811         (mi_async_1): Likewise.
1812         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1813         * nat/fork-inferior.h (startup_with_shell): Likewise.
1814         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1815         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1816         * nios2-tdep.c (nios2_debug): Likewise.
1817         * or1k-tdep.c (or1k_debug): Likewise.
1818         * parse.c (parser_debug): Likewise.
1819         * parser-defs.h (parser_debug): Likewise.
1820         * printcmd.c (print_symbol_filename): Likewise.
1821         * proc-api.c (procfs_trace): Likewise.
1822         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1823         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1824         (set_parameter_value): Update.
1825         (add_setshow_generic): Update.
1826         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1827         to bool*.
1828         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1829         int*.
1830         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1831         * record-btrace.c (record_btrace_target::store_registers): Update.
1832         * record-full.c (record_full_memory_query): Change to bool.
1833         (record_full_stop_at_limit): Likewise.
1834         * record-full.h (record_full_memory_query): Likewise.
1835         * remote-notif.c (notif_debug): Likewise.
1836         * remote-notif.h (notif_debug): Likewise.
1837         * remote.c (use_range_stepping): Likewise.
1838         (interrupt_on_connect): Likewise.
1839         (remote_break): Likewise.
1840         * ser-tcp.c (tcp_auto_retry): Likewise.
1841         * ser-unix.c (serial_hwflow): Likewise.
1842         * skip.c (debug_skip): Likewise.
1843         * solib-aix.c (solib_aix_debug): Likewise.
1844         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1845         (spu_auto_flush_cache_p): Likewise.
1846         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1847         Likewise.
1848         (struct info_print_options) <quiet>: Likewise.
1849         * symfile-debug.c (debug_symfile): Likewise.
1850         * symfile.c (auto_solib_add): Likewise.
1851         (separate_debug_file_debug): Likewise.
1852         * symfile.h (auto_solib_add): Likewise.
1853         (separate_debug_file_debug): Likewise.
1854         * symtab.c (basenames_may_differ): Likewise.
1855         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1856         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1857         (struct info_types_options) <quiet>: Likewise.
1858         * symtab.h (demangle): Likewise.
1859         (basenames_may_differ): Likewise.
1860         * target-dcache.c (stack_cache_enabled_1): Likewise.
1861         (code_cache_enabled_1): Likewise.
1862         * target.c (trust_readonly): Likewise.
1863         (may_write_registers): Likewise.
1864         (may_write_memory): Likewise.
1865         (may_insert_breakpoints): Likewise.
1866         (may_insert_tracepoints): Likewise.
1867         (may_insert_fast_tracepoints): Likewise.
1868         (may_stop): Likewise.
1869         (auto_connect_native_target): Likewise.
1870         (target_stop_and_wait): Update.
1871         (target_async_permitted): Change to bool.
1872         (target_async_permitted_1): Likewise.
1873         (may_write_registers_1): Likewise.
1874         (may_write_memory_1): Likewise.
1875         (may_insert_breakpoints_1): Likewise.
1876         (may_insert_tracepoints_1): Likewise.
1877         (may_insert_fast_tracepoints_1): Likewise.
1878         (may_stop_1): Likewise.
1879         * target.h (target_async_permitted): Likewise.
1880         (may_write_registers): Likewise.
1881         (may_write_memory): Likewise.
1882         (may_insert_breakpoints): Likewise.
1883         (may_insert_tracepoints): Likewise.
1884         (may_insert_fast_tracepoints): Likewise.
1885         (may_stop): Likewise.
1886         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1887         (make_thread_apply_all_options_def_group): Change argument from int*
1888         to bool*.
1889         (thread_apply_all_command): Update.
1890         (print_thread_events): Change to bool.
1891         * top.c (confirm): Likewise.
1892         (command_editing_p): Likewise.
1893         (history_expansion_p): Likewise.
1894         (write_history_p): Likewise.
1895         (info_verbose): Likewise.
1896         * top.h (confirm): Likewise.
1897         (history_expansion_p): Likewise.
1898         * tracepoint.c (disconnected_tracing): Likewise.
1899         (circular_trace_buffer): Likewise.
1900         * typeprint.c (print_methods): Likewise.
1901         (print_typedefs): Likewise.
1902         * utils.c (debug_timestamp): Likewise.
1903         (sevenbit_strings): Likewise.
1904         (pagination_enabled): Likewise.
1905         * utils.h (sevenbit_strings): Likewise.
1906         (pagination_enabled): Likewise.
1907         * valops.c (overload_resolution): Likewise.
1908         * valprint.h (struct value_print_options) <prettyformat_arrays,
1909         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1910         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1911         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1912         Likewise.
1913         * windows-nat.c (new_console): Likewise.
1914         (cygwin_exceptions): Likewise.
1915         (new_group): Likewise.
1916         (debug_exec): Likewise.
1917         (debug_events): Likewise.
1918         (debug_memory): Likewise.
1919         (debug_exceptions): Likewise.
1920         (useshell): Likewise.
1921         * windows-tdep.c (maint_display_all_tib): Likewise.
1922         * xml-support.c (debug_xml): Likewise.
1923
1924 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1925
1926         * source.c (prepare_path_for_appending): New function.
1927         (openp): Make use of new function.
1928         (find_and_open_source): Search for the compilation directory and
1929         source file as a relative path beneath the directory search path.
1930
1931 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * source-cache.c (source_cache::get_line_charpos): Catch
1934         exceptions and return false, this matches the behaviour documented
1935         in the header file.
1936
1937 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1938
1939         * ada-tasks.c (info_task): Remove quoting of the task's name.
1940
1941 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1942
1943         * symfile.c (auto_solib_add): Replace comment with a reference
1944         to the header file.
1945
1946 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1947
1948         * NEWS: Mention that gdb can now be compiled with Python 3
1949         on Windows.
1950
1951 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * maint.c (maint_print_section_data::maint_print_section_data):
1954         Force use of 'float log10 (float)' by casting the argument to
1955         float.
1956
1957 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * maint.c: Add 'cmath' include.
1960         (struct maint_print_section_data): New structure.
1961         (print_section_index): New function.
1962         (print_bfd_section_info): Add header comment, small whitespace
1963         cleanup, and update to call new print_section_index function.
1964         (print_objfile_section_info): Likewise.
1965         (maint_obj_section_from_bfd_section): New function.
1966         (print_bfd_section_info_maybe_relocated): New function.
1967         (maintenance_info_sections): Add header comment, always use
1968         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1969
1970 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1973         inner scope, add check that the objfile has psymtabs before
1974         checking psymtabs_addrmap.
1975         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1976
1977 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1978
1979         * NEWS: Announce that Ada task names are now shown at more places,
1980         and between quotes (except in info task output).
1981         * gdb/ada-tasks.c (task_to_str): New function.
1982         (display_current_task_id): Call task_to_str.
1983         (task_command_1): Likewise.
1984         (print_ada_task_info): In non-mi mode, Properly align headers and data
1985         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1986
1987 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1988
1989         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1990         prstatus.pr_lwp.pr_info instead of making it up.
1991
1992 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1993
1994         * auto-load.c (auto_load_expand_dir_vars): Update.
1995         * defs.h (gdb_datadir): Change to std::string.
1996         (python_libdir): Likewise.
1997         (relocate_gdb_directory): Change return type to std::string.
1998         * guile/guile.c (gdbscm_data_directory): Update.
1999         (initialize_scheme_side): Update.
2000         * jit.c (jit_reader_dir): Change to std::string.
2001         (jit_reader_load_command): Update.
2002         * main.c (gdb_datadir): Change to std::string.
2003         (python_libdir): Likewise.
2004         (set_gdb_data_directory): Update.
2005         (relocate_path): Change to return std::string.
2006         (relocate_gdb_directory): Change to return std::string.
2007         (relocate_gdbinit_path_maybe_in_datadir): Update.
2008         (captured_main_1): Update.
2009         * python/python.c (do_start_initialization): Update.
2010         * top.c (show_gdb_datadir): Update.
2011         * xml-syscall.c (xml_init_syscalls_info): Update.
2012         (init_syscalls_info): Update.
2013
2014 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2015
2016         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2017         out of get_init_files.
2018         (get_init_files): Update.
2019
2020 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2021
2022         * main.c (get_init_files): Change to use std::string.
2023         (captured_main_1): Update.
2024         (print_gdb_help): Update.
2025
2026 2019-09-11  Ali Tamur  <tamur@google.com>
2027
2028         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2029         implementation.
2030
2031 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * dbxread.c (read_dbx_symtab): Update.
2034         * dwarf2read.c (load_partial_dies): Update.
2035         * mdebugread.c (parse_partial_symbols): Update.
2036         (handle_psymbol_enumerators): Update.
2037         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2038         * psymtab.c (add_psymbol_to_bcache): Likewise.
2039         (add_psymbol_to_list): Likewise.
2040         * symtab.c (symbol_set_names): Likewise.
2041         * symtab.h (symbol_set_names): Likewise.
2042         * xcoffread.c (scan_xcoff_symtab): Update.
2043
2044 2019-09-11  Tom Tromey  <tom@tromey.com>
2045
2046         * symfile-mem.c (symbol_file_add_from_memory): Use
2047         bfd_set_filename.
2048         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2049         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2050
2051 2019-09-10  Tom Tromey  <tromey@adacore.com>
2052
2053         * dwarf-index-write.c (write_psymbols): Extend error message.
2054         (debug_names::insert): Add Ada code.
2055         (debug_names::write_psymbols): Remove Ada check.
2056         (debug_names) <m_string_obstack>: New member.
2057         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2058         (gdb_index_symbol_name_matcher::matches): Remove.
2059         (mapped_index_base::find_name_components_bounds): Add "lang"
2060         parameter.
2061         (mapped_index_base::build_name_components): Also split names
2062         according to Ada syntax.
2063         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2064         type of "match_callback".
2065         (check_match, check_find_bounds_finds)
2066         (dw2_expand_symtabs_matching): Update.
2067         (dw2_debug_names_iterator): Add new constructor.
2068         (dw2_debug_names_map_matching_symbols): New function.
2069         (dw2_debug_names_expand_symtabs_matching): Update.
2070         (dwarf2_debug_names_functions): Use
2071         dw2_debug_names_map_matching_symbols.
2072
2073 2019-09-10  Tom Tromey  <tromey@adacore.com>
2074
2075         * dwarf2read.c (dw2_get_file_names_reader): Add the
2076         CU's file name to the results.
2077
2078 2019-09-10  Tom Tromey  <tromey@adacore.com>
2079
2080         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2081         map_matching_symbols.  Update.
2082         * dwarf2read.c (dw2_map_matching_symbols): Update.
2083         * psymtab.c (match_partial_symbol): Change type; update.
2084         (psym_map_matching_symbols): Likewise.
2085         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2086         type; update.
2087         * symfile.h (struct quick_symbol_functions)
2088         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2089         Remove "match".
2090
2091 2019-09-10  Tom Tromey  <tromey@adacore.com>
2092
2093         * psymtab.c (map_block): Remove.
2094         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2095         * symtab.c (iterate_over_symbols_terminated): New function.
2096         * symtab.c (iterate_over_symbols_terminated): Declare.
2097
2098 2019-09-10  Tom Tromey  <tromey@adacore.com>
2099
2100         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2101         * language.h (struct language_defn) <la_iterate_over_symbols>:
2102         Return bool.
2103         * symtab.c (iterate_over_symbols): Return bool.
2104         * symtab.h (iterate_over_symbols): Return bool.
2105
2106 2019-09-10  Tom Tromey  <tromey@adacore.com>
2107
2108         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2109         (add_nonlocal_symbols): Update.
2110         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2111         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2112         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2113         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2114         Change type of "callback".  Remove "data".
2115
2116
2117 2019-09-09  Ali Tamur  <tamur@google.com>
2118
2119         * dwarf2read.c (comp_unit_head): Update comment.
2120         (dwarf2_dwo_name): New function declaration.
2121         (dwarf_unit_type_name): New function declaration.
2122         (read_comp_unit_head): Add support for new compilation units,
2123         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2124         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2125         (currently named as "signature") in their header. Also clarify error
2126         messages.
2127         (lookup_dwo_id): New function. Returns the dwo id of the given
2128         compile unit.
2129         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2130         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2131         functions.
2132         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2133         (dwarf2_dwo_name): Get the dwo name if present.
2134         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2135         purposes.
2136
2137 2019-09-09  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2140
2141 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2142
2143         * python/python.c (do_start_initialization): Make progname_copy static,
2144         to avoid a leak report.
2145
2146 2019-09-08  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2149
2150 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2151
2152         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2153         Change type to gdb::optional<block_enum>.
2154         (dw2_symtab_iter_init): Change block_index parameter type
2155         to gdb::optional<block_enum>.
2156         (dw2_lookup_symbol): Change block_index parameter
2157         type to block_enum.c
2158         (dw2_debug_names_lookup_symbol): Likewise.
2159         * psymtab.c (psym_lookup_symbol): Likewise.
2160         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2161         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2162         Likewise.
2163
2164 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2165
2166         * defs.h (relocate_gdb_directory): Change int to bool in
2167         signature and rename flag to relocatable.
2168         * main.c (relocate_path): Likewise.
2169         (relocate_gdb_directory): Likewise.
2170
2171 2019-09-06  Alan Modra  <amodra@gmail.com>
2172
2173         * coffread.c (coff_symfile_read): Constify filename variable.
2174         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2175         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2176         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2177         * solib.c (reload_shared_libraries_1): Likewise.
2178         * symfile.c (reread_symbols): Likewise.
2179         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2180         * solib-darwin.c (darwin_bfd_open): Likewise.
2181         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2182
2183 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2186         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2187
2188 2019-09-03  Tom Tromey  <tromey@adacore.com>
2189
2190         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2191         types.
2192         (has_negatives): Unbias a range type bound.
2193         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2194         * gdbtypes.c (operator==): Handle new field.
2195         (create_range_type): Add "bias" parameter.
2196         (create_static_range_type, resolve_dynamic_range): Update.
2197         * gdbtypes.h (struct range_bounds) <bias>: New member.
2198         (create_range_type): Add bias parameter.
2199         * printcmd.c (print_scalar_formatted): Unbias range types.
2200         * value.c (unpack_long): Unbias range types.
2201         (pack_long): Bias range types.
2202
2203 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2204
2205         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2206         probe arguments.
2207
2208 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2209
2210         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2211         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2212         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2213         (compile_probe_arg): Likewise.
2214         * probe.h (get_argument_count): Likewise.
2215         * solib-svr4.c (solib_event_probe_action): Likewise.
2216         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2217
2218 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2219
2220         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2221         code to here...
2222         (svr4_create_solib_event_breakpoints): ...from here.
2223
2224 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2225
2226         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2227         suffix from warning message.
2228
2229 2019-08-30  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-winsource.h (struct tui_source_window_base)
2232         <refresh_all>: Don't declare.
2233         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2234         Remove.
2235         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2236         tui_show_locator_content.
2237         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2238         declare.
2239         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2240         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2241         declare.
2242
2243 2019-08-30  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2246
2247 2019-08-30  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2250         Remove unnecessary forward declarations.
2251
2252 2019-08-30  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2255         rerender.
2256         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2257         tui_show_locator_content.
2258
2259 2019-08-30  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2262         (tui_locator_window::rerender): Rewrite using body of previous
2263         tui_show_locator_content.
2264
2265 2019-08-30  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2268         set_locator_fullname>: New methods.
2269         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2270         Rename from tui_set_locator_fullname.
2271         (tui_locator_window::set_locator_info): Rename from
2272         tui_set_locator_info.  Return bool.
2273         (tui_update_locator_fullname, tui_show_frame_info): Update.
2274
2275 2019-08-30  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2278
2279 2019-08-30  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2282         call touchwin.
2283
2284 2019-08-30  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui-wingeneral.c (box_win): Assume win_info and
2287         win_info->handle cannot be NULL.
2288
2289 2019-08-30  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2292         refresh_window>: Declare.
2293         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2294         resize.
2295         (tui_data_item_window::rerender): Rename from
2296         tui_display_register.
2297         (tui_data_item_window::refresh_window): New method.
2298         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2299         no-op.
2300
2301 2019-08-30  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2304         regs_column_count, current_group>: Move later.  Now private.
2305         <get_current_group>: New method.
2306         * tui/tui-regs.c (tui_reg_command): Update.
2307         * tui/tui-layout.c (tui_set_layout): Update.
2308
2309 2019-08-30  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2312         (tui_data_window::rerender): Don't call
2313         check_and_display_highlight_if_needed.
2314         (tui_data_window::refresh_all): Remove call to
2315         erase_data_content.
2316
2317 2019-08-30  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2320         (tui_data_window::display_registers_from)
2321         (tui_data_window::display_reg_element_at_line)
2322         (tui_data_window::display_registers_from_line): Remove checks of
2323         "empty".
2324
2325 2019-08-30  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2328         Don't declare.
2329         * tui/tui-regs.c (tui_data_window::show_registers): Call
2330         rerender.
2331         (tui_data_window::rerender): Rename from display_all_data.
2332         (tui_data_window::rerender): Remove old implementation.
2333
2334 2019-08-30  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2337         text.
2338         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2339
2340 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2341             Sergio Durigan Junior  <sergiodj@redhat.com>
2342
2343         PR win32/24284
2344         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2345
2346 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2349         when searching for types.
2350
2351 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * f-lang.c (f_language_defn): Use f_print_typedef.
2354         * f-lang.h (f_print_typedef): Declare.
2355         * f-typeprint.c (f_print_typedef): Define.
2356
2357 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2358
2359         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2360
2361 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2362
2363         * cli/cli-utils.c (info_print_options_defs): Delete.
2364         (make_info_print_options_def_group): Delete.
2365         (extract_info_print_options): Delete.
2366         (info_print_command_completer): Delete.
2367         (info_print_args_help): Add extra parameter, and optionally
2368         include text about -n flag.
2369         * cli/cli-utils.h (struct info_print_options): Delete.
2370         (extract_info_print_options): Delete declaration.
2371         (info_print_command_completer): Delete declaration.
2372         (info_print_args_help): Add extra parameter, extend header
2373         comment.
2374         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2375         search_symbols.
2376         * stack.c (struct info_print_options): New type.
2377         (info_print_options_defs): New file scoped variable.
2378         (make_info_print_options_def_group): New static function.
2379         (info_print_command_completer): New static function.
2380         (info_locals_command): Update to use new local functions.
2381         (info_args_command): Likewise.
2382         (_initialize_stack): Add extra parameter to calls to
2383         info_print_args_help.
2384         * symtab.c (search_symbols): Add extra parameter, use this to
2385         possibly excluse non-debug symbols.
2386         (symtab_symbol_info): Add extra parameter, which is passed on to
2387         search_symbols.
2388         (struct info_print_options): New type.
2389         (info_print_options_defs): New file scoped variable.
2390         (make_info_print_options_def_group): New static function.
2391         (info_print_command_completer): New static function.
2392         (info_variables_command): Update to use local functions, and pass
2393         extra parameter through to symtab_symbol_info.
2394         (info_functions_command): Likewise.
2395         (info_types_command): Pass additional argument through to
2396         symtab_symbol_info.
2397         (rbreak_command): Pass extra argument to search_symbols.
2398         (_initialize_symtab): Add extra arguments for calls to
2399         info_print_args_help, and update help text for 'info variables',
2400         'whereis', and 'info functions' commands.
2401         * symtab.h (search_symbols): Add extra argument to declaration.
2402         * NEWS: Mention new flags.
2403
2404 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * symtab.c (lookup_static_symbol): Call the new function (and move
2407         it down to be next to lookup_global_symbol).
2408         (struct global_sym_lookup_data): Add block_enum member and rename to...
2409         (struct global_or_static_sym_lookup_data): ...this.
2410         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2411         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2412         (lookup_symbol_global_or_static_iterator_cb): ...this.
2413         (lookup_global_or_static_symbol): New function.
2414         (lookup_global_symbol): Call new function.
2415
2416 2019-08-26  Tom de Vries  <tdevries@suse.de>
2417
2418         PR c++/24852
2419         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2420         when pc_probe.prob == NULL.
2421
2422 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2425         variable symbol_linkage to symbol_linkage_.
2426
2427 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2430         represent whether the symbol is static, dynamic, or we don't
2431         know.
2432
2433 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2434
2435         * gdb/rx-tdep.c (rx_register_names): New.
2436         (rx_register_name): Delete.
2437         (rx_psw_type): Delete.
2438         (rx_fpsw_type): Delete.
2439         (rx_register_type): Delete.
2440         (rx_gdbarch_init): Convert target-descriptions.
2441         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2442         * gdb/features/Makefile: Add rx.xml.
2443         * gdb/features/rx.xml: New.
2444         * gdb/features/rx.c: Generated.
2445         * gdb/NEWS: Mention target description support.
2446
2447 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2448
2449         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2450         *slot_ptr.
2451
2452 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2453
2454         * configure.ac: Don't check for 'dlfcn.h' (moved to
2455         gdbsupport/common.m4).
2456         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2457         'gdbsupport/'.
2458         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2459         * compile/compile-c-support.c: Include
2460         'gdbsupport/gdb-dlfcn.h'.
2461         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2462         * gdb-dlfcn.c: Move to...
2463         * gdbsupport/gdb-dlfcn.c: ... here.
2464         * gdb-dlfcn.h: Move to...
2465         * gdbsupport/gdb-dlfcn.h: ... here.
2466
2467 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2468
2469         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2470         the offset field signed.
2471
2472 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2473
2474         * python/lib/gdb/__init__.py (_execute_file): New function.
2475         * python/python.c (python_run_simple_file): Call gdb._execute_file
2476         on Windows.
2477
2478 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2481         all uses as this was never set to anything but a zero value.
2482
2483 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2484
2485         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2486
2487 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2488
2489         * tui/tui-data.h (tui_gen_win_info): Add an =default
2490         move constructor, required by some GCC versions.
2491
2492 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2493
2494         * go32-nat.c (go32_sysinfo): Add hygon_p.
2495
2496 2019-08-20  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2499         line_from_reg_element_no, first_reg_element_no_inline,
2500         display_all_data, delete_data_content_windows,
2501         erase_data_content>: Now private.
2502
2503 2019-08-20  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2506         (tui_unhighlight_win, tui_highlight_win)
2507         (tui_win_info::make_window): Update.
2508         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2509
2510 2019-08-20  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2513         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2514         (MAX_PID_WIDTH): Move to tui-stack.c.
2515         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2516         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2517         (MAX_PID_WIDTH): Move from tui-data.h.
2518
2519 2019-08-20  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2522         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2523         (box_win): Update.
2524         (tui_gen_win_info::make_window): Rename from tui_make_window.
2525         (tui_win_info::make_window): New method.
2526         (tui_gen_win_info::make_visible): Update.
2527         * tui/tui-source.c (tui_source_window::set_contents): Update.
2528         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2529         (tui_data_window::display_registers_from): Update.
2530         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2531         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2532         Declare.
2533         <can_box>: Remove.
2534         <title>: Remove.
2535         (struct tui_win_info) <make_window>: Declare.
2536         <can_box>: Now virtual.
2537         <title>: New member.
2538         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2539         * tui/tui-command.c (tui_cmd_window::resize): Update.
2540
2541 2019-08-20  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2544         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2545         (tui_data_window::check_register_values): Update.
2546
2547 2019-08-20  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-regs.h (struct tui_data_window): Use
2550         DISABLE_COPY_AND_ASSIGN.
2551         <regs_content>: Change type, removing unique_ptr.
2552         <tui_data_window>: Add move constructor.
2553         * tui/tui-regs.c (tui_data_window::show_registers)
2554         (tui_data_window::show_register_group)
2555         (tui_data_window::display_registers_from)
2556         (tui_data_window::display_registers_from)
2557         (tui_data_window::first_data_item_displayed)
2558         (tui_data_window::delete_data_content_windows)
2559         (tui_data_window::rerender, tui_data_window::refresh_window)
2560         (tui_data_window::check_register_values): Update.
2561
2562 2019-08-20  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2565         show_register_group>: Declare.
2566         (tui_show_register_group): Don't declare.
2567         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2568         tui_show_registers.
2569         (tui_data_window::show_register_group): Rename from
2570         tui_show_register_group.
2571         (tui_data_window::check_register_values, tui_reg_command):
2572         Update.
2573         * tui/tui-layout.c (tui_set_layout): Update.
2574
2575 2019-08-20  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2578         Declare.
2579         (tui_check_register_values): Don't declare.
2580         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2581         from tui_check_register_values.
2582         * tui/tui-hooks.c (tui_register_changed): Update.
2583
2584 2019-08-20  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-regs.c (tui_reg_layout): Move later.
2587         (tui_show_registers): Don't enable TUI mode or change layout.
2588
2589 2019-08-20  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-regs.h (struct tui_data_item_window)
2592         <~tui_data_item_window>: Remove.
2593         <content>: Now a unique_xmalloc_ptr.
2594         * tui/tui-regs.c (tui_register_format): Return a
2595         unique_xmalloc_ptr.
2596         (tui_get_register): Update.
2597         (~tui_data_item_window): Remove.
2598         (tui_data_window::display_registers_from, tui_display_register):
2599         Update.
2600         * tui/tui-io.h (tui_expand_tabs): Update.
2601         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2602         Remove "col" parameter.
2603
2604 2019-08-20  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2607         field.
2608         * tui/tui-regs.c (~tui_data_item_window): Update.
2609
2610 2019-08-20  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2613         earlier.
2614
2615 2019-08-20  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2618
2619 2019-08-20  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-source.h (struct tui_source_window): Update.
2622         * tui/tui-regs.c (tui_show_registers): Update.
2623         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2624         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2625         (NO_REGS_STRING): Remove defines.
2626
2627 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2628
2629         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2630         unnecessary thread walk if remote doesn't support the packet.
2631
2632 2019-08-19  Tom Tromey  <tromey@adacore.com>
2633
2634         * python/py-value.c (value_has_field): Fix indentation.
2635
2636 2019-08-19  Tom Tromey  <tromey@adacore.com>
2637
2638         * printcmd.c (do_one_display, info_display_command): Update.
2639         * block.h (contained_in): Return bool.  Add allow_nested
2640         parameter.
2641         * block.c (contained_in): Return bool.  Add allow_nested
2642         parameter.
2643
2644 2019-08-19  Tom Tromey  <tom@tromey.com>
2645
2646         * configure: Rebuild.
2647         * configure.ac: Disallow the combination of -static-libstdc++ and
2648         source highlight.
2649         * source-cache.c (get_language_name): Handle rust.
2650         (source_cache::get_source_lines): Ignore highlighting exceptions.
2651
2652 2019-08-16  Tom Tromey  <tom@tromey.com>
2653
2654         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2655         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2656         (struct tui_source_window_base) <make_visible, refresh_window,
2657         resize>: Remove methods.
2658         <execution_info>: Remove field.
2659         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2660         (tui_show_source_line, tui_source_window_base)
2661         (~tui_source_window_base): Update.
2662         (tui_source_window_base::resize)
2663         (tui_source_window_base::make_visible)
2664         (tui_source_window_base::refresh_window): Remove.
2665         (tui_source_window_base::update_exec_info): Update.
2666         * tui/tui-source.c (tui_source_window::set_contents): Update.
2667         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2668
2669 2019-08-16  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2672         deprecated_query_hook.
2673
2674 2019-08-16  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2677         (tui_update_source_windows_with_line): Update.
2678         * tui/tui-source.h (struct tui_source_window)
2679         <show_symtab_source>: Declare.
2680         (tui_show_symtab_source): Don't declare.
2681         * tui/tui-source.c (tui_show_symtab_source): Rename from
2682         tui_show_symtab_source.
2683
2684 2019-08-16  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-winsource.h (struct tui_source_window_base)
2687         <set_contents>: Declare.
2688         * tui/tui-winsource.c
2689         (tui_source_window_base::update_source_window_as_is): Update.
2690         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2691         Declare.
2692         (tui_set_source_content): Don't declare.
2693         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2694         tui_set_source_content.
2695         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2696         Declare.
2697         (tui_set_disassem_content): Don't declare.
2698         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2699         tui_set_disassem_content.
2700
2701 2019-08-16  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-winsource.h (struct tui_source_window_base)
2704         <update_breakpoint_info>: Declare.
2705         (tui_update_breakpoint_info): Don't declare.
2706         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2707         (tui_update_all_breakpoint_info): Update.
2708         (tui_source_window_base::update_breakpoint_info): Rename from
2709         tui_update_breakpoint_info.
2710         (tui_source_window_base::update_exec_info): Update.
2711
2712 2019-08-16  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-winsource.h (struct tui_source_window_base)
2715         <update_source_window>: Declare.
2716         (tui_update_source_window): Don't declare.
2717         * tui/tui-winsource.c
2718         (tui_source_window_base::update_source_window): Rename from
2719         tui_update_source_window.
2720         (tui_source_window_base::rerender): Update.
2721         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2722         * tui/tui-disasm.c (tui_show_disassem)
2723         (tui_show_disassem_and_update_source)
2724         (tui_disasm_window::maybe_update): Update.
2725
2726 2019-08-16  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.h (struct tui_source_window_base)
2729         <update_source_window_as_is>: Declare.
2730         (tui_update_source_window_as_is): Don't declare.
2731         * tui/tui-winsource.c (tui_update_source_window): Update
2732         (tui_source_window_base::update_source_window_as_is): Rename from
2733         tui_update_source_window_as_is.
2734         (tui_source_window_base::refill): Update.
2735         * tui/tui-source.c (tui_show_symtab_source): Update.
2736         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2737         Update.
2738
2739 2019-08-16  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-winsource.h (tui_update_source_window)
2742         (tui_update_source_window_as_is): Remove "noerror" parameter.
2743         * tui/tui-winsource.c (tui_update_source_window)
2744         (tui_update_source_window_as_is): Remove "noerror" parameter.
2745         (tui_update_source_windows_with_addr)
2746         (tui_update_source_windows_with_line)
2747         (tui_source_window_base::rerender)
2748         (tui_source_window_base::refill): Update.
2749         * tui/tui-source.h (tui_set_source_content)
2750         (tui_show_symtab_source): Remove "noerror" parameter.
2751         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2752         parameter.
2753         (tui_show_symtab_source): Likewise.
2754         (tui_source_window::maybe_update): Update.
2755         * tui/tui-disasm.c (tui_show_disassem)
2756         (tui_show_disassem_and_update_source)
2757         (tui_disasm_window::do_scroll_vertical)
2758         (tui_disasm_window::maybe_update): Update.
2759
2760 2019-08-16  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui.c (tui_is_window_visible): Update.
2763         * tui/tui-wingeneral.c (tui_make_window)
2764         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2765         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2766         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2767         (tui_set_win_height_command, parse_scrolling_args): Update.
2768         * tui/tui-source.c (tui_source_window::style_changed): Update.
2769         * tui/tui-regs.c (tui_show_registers)
2770         (tui_data_window::first_data_item_displayed)
2771         (tui_data_window::delete_data_content_windows)
2772         (tui_check_register_values, tui_reg_command): Update.
2773         * tui/tui-disasm.c (tui_show_disassem): Update.
2774         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2775         method.
2776         <is_visible>: Remove field.
2777         * tui/tui-data.c (tui_next_win, tui_prev_win)
2778         (tui_delete_invisible_windows): Update.
2779
2780 2019-08-16  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-winsource.h (struct tui_source_window_base)
2783         <m_has_locator>: Remove.
2784         * tui/tui-layout.c (show_source_disasm_command, show_data)
2785         (show_source_or_disasm_and_command): Update.
2786
2787 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2788
2789         * NEWS (Other MI changes): New subsection.
2790         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2791         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2792         * arch-utils.c (default_get_pc_address_flags): New function.
2793         * arch-utils.h (default_get_pc_address_flags): New declaration.
2794         * gdbarch.sh: Add get_pc_address_flags.
2795         * gdbarch.c: Regenerate.
2796         * gdbarch.h: Likewise.
2797         * stack.c (print_pc): New function.
2798         (print_frame_info) (print_frame): Call print_pc.
2799
2800 2019-08-16  Tom de Vries  <tdevries@suse.de>
2801
2802         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2803         print_objfile_section_info.
2804
2805 2019-08-15  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2808         calling update_cmdwin_start_line.
2809         * tui/tui-winsource.h (struct tui_source_window_base)
2810         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2811         <rerender>: Declare.
2812         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2813         Call rerender.
2814         (tui_source_window_base::set_new_height): Remove.
2815         (tui_source_window_base::rerender): Rename from
2816         do_make_visible_with_new_height.
2817         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2818         resize method.
2819         (tui_win_info::make_invisible_and_set_new_height)
2820         (tui_win_info::make_visible_with_new_height): Remove.
2821         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2822         Declare.
2823         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2824         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2825         do_make_visible_with_new_height>: Don't declare.
2826         <rerender>: Declare.
2827         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2828         set_new_height.
2829         (tui_data_window::do_make_visible_with_new_height): Remove.
2830         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2831         call tui_show_locator_content.
2832         (tui_gen_win_info::resize): Call rerender.
2833         (show_source_or_disasm_and_command): Don't call
2834         tui_show_locator_content.
2835         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2836         method.
2837         (struct tui_win_info) <rerender>: Declare.
2838         <set_new_height, make_invisible_and_set_new_height,
2839         make_visible_with_new_height>: Don't declare.
2840         * tui/tui-data.c (tui_win_list::rerender): New method.
2841         * tui/tui-command.h (struct tui_cmd_window)
2842         <do_make_visible_with_new_height>: Don't declare.
2843         * tui/tui-command.c
2844         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2845
2846 2019-08-15  Tom Tromey  <tromey@adacore.com>
2847
2848         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2849         * ada-lang.c (ada_enum_name): Likewise.
2850
2851 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2852
2853         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2854         leading underscore.
2855         (GdbOutputErrorFile): Likewise.
2856         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2857         accordingly.
2858         (execute_unwinders): Rename to have a leading underscore.
2859         (auto_load_packages): Likewise.
2860         (global scope): Adjust call to auto_load_packages accordingly.
2861         (GdbSetPythonDirectory): Likewise.
2862         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2863         instead of execute_unwinders.
2864
2865 2019-08-15  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2868         (show_data): Don't change window visibility.
2869         (tui_gen_win_info::resize): Remove special case for command
2870         window.  Use wresize, when available.
2871         (show_source_or_disasm_and_command): Don't change window
2872         visibility.
2873         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2874         <make_visible>: New method.
2875         * tui/tui-command.c (tui_cmd_window::resize): New method.
2876
2877 2019-08-15  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2880         (struct tui_source_windows): New.
2881         * tui/tui-winsource.c (tui_display_main): Update.
2882         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2883         (new_height_ok, parse_scrolling_args): Update.
2884         * tui/tui-layout.c (show_layout, show_data): Update.
2885         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2886         (tui_add_to_source_windows): Don't declare.
2887         * tui/tui-data.c (source_windows, tui_source_windows)
2888         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2889
2890 2019-08-15  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2893         Rename from reset.
2894         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2895         * tui/tui-layout.c (show_source_disasm_command, show_data):
2896         Update.
2897         (tui_gen_win_info::resize): Rename.
2898         (show_source_or_disasm_and_command): Update.
2899         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2900         reset.
2901
2902 2019-08-15  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2905         * tui/tui-interp.c (tui_interp::init): Don't call
2906         tui_initialize_static_data.
2907         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2908
2909 2019-08-15  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2912         examine tui_win_list.
2913
2914 2019-08-15  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2917         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2918         tui_clear_source_content.
2919         (tui_clear_source_content): Remove.
2920         (tui_source_window_base::do_erase_source_content): Hoist call to
2921         content.clear().
2922         * tui/tui-stack.c (tui_show_frame_info): Don't call
2923         tui_clear_source_content.
2924
2925 2019-08-15  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-winsource.h (struct tui_source_window_base)
2928         <do_erase_source_content>: New method.
2929         <erase_source_content>: New method.
2930         (tui_erase_source_content): Don't declare.
2931         * tui/tui-winsource.c (tui_clear_source_content): Update.
2932         (tui_source_window_base::do_erase_source_content): Rename from
2933         tui_erase_source_content.
2934         (tui_source_window_base::show_source_content): Update.
2935         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2936         * tui/tui-source.h (struct tui_source_window)
2937         <erase_source_content>: New method.
2938         * tui/tui-disasm.h (struct tui_disasm_window)
2939         <erase_source_content>: New method.
2940
2941 2019-08-15  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2944         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2945         constructor.
2946         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2947         * tui/tui-source.c (tui_set_source_content): Update.
2948         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2949
2950 2019-08-15  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2953         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2954         tui-source.c.
2955         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2956         Declare.
2957         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2958         method.
2959         (tui_source_window::maybe_update): Update.
2960
2961 2019-08-15  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2964         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2965         tui-disasm.c.
2966         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2967         Declare.
2968         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2969         method.
2970         (tui_disasm_window::maybe_update): Update.
2971
2972 2019-08-15  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-winsource.h (struct tui_source_window_base)
2975         <maybe_update>: Declare.
2976         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2977         method.
2978         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2979         Declare.
2980         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2981         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2982         Declare.
2983         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2984
2985 2019-08-15  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2988
2989 2019-08-15  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-wingeneral.c: Include tui-stack.h.
2992         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2993         (struct tui_locator_window): Move from tui-data.h.
2994         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2995         (tui_initialize_static_data): Move from tui-data.c.
2996         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2997         (struct tui_locator_window): Move to tui-stack.c.
2998         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2999         (tui_initialize_static_data): Move to tui-stack.c.
3000
3001 2019-08-15  Tom Tromey  <tom@tromey.com>
3002
3003         * tui/tui-layout.c (show_source_disasm_command)
3004         (show_source_or_disasm_and_command): Use make_visible method, not
3005         tui_make_window.
3006         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3007         Remove.
3008
3009 2019-08-15  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-wingeneral.h (tui_make_window): Update.
3012         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3013         parameter.
3014         (tui_gen_win_info::make_visible): Update.
3015         * tui/tui-regs.c (tui_data_window::display_registers_from):
3016         Update.
3017         * tui/tui-layout.c (show_source_disasm_command)
3018         (show_source_or_disasm_and_command): Update.
3019         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3020         (enum tui_box): Remove.
3021         (struct tui_win_info) <can_box>: New method.
3022         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3023         method.
3024
3025 2019-08-15  Tom de Vries  <tdevries@suse.de>
3026
3027         * linux-nat-trad.c: Include gdbarch.h.
3028
3029 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3030
3031         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3032         register sizes.
3033
3034 2019-08-14  Tom Tromey  <tromey@adacore.com>
3035
3036         * darwin-nat.c: Include gdbarch.h.
3037         * darwin-nat-info.c: Include gdbarch.h.
3038
3039 2019-08-13  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3042         Remove.
3043         * tui/tui-data.c (tui_initialize_static_data): Update.
3044
3045 2019-08-13  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-winsource.h (struct tui_exec_info_window)
3048         <~tui_exec_info_window, maybe_allocate_content, get_content,
3049         m_content>: Remove.
3050         (struct tui_source_window_base) <set_exec_info_content,
3051         show_exec_info_content>: Don't declare.
3052         * tui/tui-winsource.c
3053         (tui_exec_info_window::maybe_allocate_content): Remove.
3054         (tui_source_window_base::update_exec_info): Rename from
3055         set_exec_info_content.
3056         (tui_source_window_base::show_exec_info_content)
3057         (tui_source_window_base::update_exec_info): Remove.
3058
3059 2019-08-13  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3062         declare.
3063         * tui/tui-winsource.c (tui_update_source_window_as_is)
3064         (tui_update_source_windows_with_addr, tui_erase_source_content):
3065         Update.
3066         (tui_clear_exec_info_content): Remove.
3067
3068 2019-08-13  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3071         declare.
3072         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3073         call tui_erase_exec_info_content.
3074         (tui_clear_exec_info_content): Rename from
3075         tui_erase_exec_info_content.
3076         (tui_clear_exec_info_content): Delete.
3077
3078 2019-08-13  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-winsource.h (struct tui_source_window_base)
3081         <show_exec_info_content>: Declare.
3082         (tui_show_exec_info_content): Don't declare.
3083         * tui/tui-winsource.c
3084         (tui_source_window_base::show_exec_info_content): Rename from
3085         tui_show_exec_info_content.
3086         (tui_source_window_base::update_exec_info): Update.
3087
3088 2019-08-13  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3091         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3092         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3093         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3094         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3095         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3096         ... here.
3097
3098 2019-08-13  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-winsource.h (struct tui_source_window_base)
3101         <update_exec_info>: Declare.
3102         (tui_update_exec_info): Don't declare.
3103         * tui/tui-winsource.c (tui_update_source_window_as_is)
3104         (tui_source_window_base::refresh_all)
3105         (tui_update_all_breakpoint_info): Update.
3106         (tui_source_window_base::update_exec_info): Rename from
3107         tui_update_exec_info.
3108         * tui/tui-stack.c (tui_show_frame_info): Update.
3109
3110 2019-08-13  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-winsource.h (struct tui_source_window_base)
3113         <set_exec_info_content>: Declare.
3114         (tui_set_exec_info_content): Don't declare.
3115         * tui/tui-winsource.c
3116         (tui_source_window_base::set_exec_info_content): Rename from
3117         tui_set_exec_info_content.
3118         (tui_update_exec_info): Update.
3119
3120 2019-08-13  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.h (struct tui_source_window_base)
3123         <show_source_content>: Declare.
3124         (tui_show_source_content): Don't declare.
3125         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3126         (tui_source_window_base::show_source_content): Rename from
3127         tui_show_source_content.
3128         (tui_source_window_base::refresh_all): Update.
3129         * tui/tui-layout.c (show_source_disasm_command)
3130         (show_source_or_disasm_and_command): Update.
3131
3132 2019-08-13  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-winsource.c (tui_erase_source_content)
3135         (tui_show_source_content, tui_source_window_base::refresh_all):
3136         Update.
3137         * tui/tui-wingeneral.h
3138         (tui_check_and_display_highlight_if_needed): Don't declare.
3139         * tui/tui-wingeneral.c
3140         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3141         check_and_display_highlight_if_needed.
3142         * tui/tui-win.c (tui_rehighlight_all)
3143         (tui_win_info::make_visible_with_new_height): Update.
3144         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3145         (tui_data_window::erase_data_content)
3146         (tui_data_window::display_all_data): Update.
3147         * tui/tui-data.h (struct tui_win_info)
3148         <check_and_display_highlight_if_needed>: Declare.
3149
3150 2019-08-13  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-win.c (tui_resize_all): Call
3153         tui_delete_invisible_windows.
3154         * tui/tui-layout.c (show_layout): Call
3155         tui_delete_invisible_windows.
3156         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3157         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3158
3159 2019-08-13  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3162         tui_add_win_to_layout.
3163
3164 2019-08-13  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3167         * tui/tui-layout.c (tui_default_win_height): Now static.
3168
3169 2019-08-13  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3172         single switch.
3173         (show_source_disasm_command, show_source_or_disasm_and_command):
3174         Don't check current layout.
3175
3176 2019-08-13  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-wingeneral.c (make_all_visible): Remove.
3179         (tui_make_all_invisible): Simplify.
3180         * tui/tui-layout.c (tui_make_all_invisible): Move from
3181         tui-wingeneral.c; simplify.
3182         (show_layout): Hoist call to tui_make_all_invisible.
3183         (show_data): Don't call tui_make_all_invisible.
3184
3185 2019-08-13  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3188         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3189
3190 2019-08-13  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3193         tui-data.c.
3194         (show_source_disasm_command, show_data)
3195         (show_source_or_disasm_and_command): Don't use
3196         tui_set_current_layout_to.
3197         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3198         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3199         tui-layout.c.
3200         (tui_set_current_layout_to): Remove.
3201
3202 2019-08-13  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-layout.c (tui_set_layout): Update.
3205         * tui/tui-data.h (struct tui_layout_def): Remove.
3206         (tui_layout_def): Don't declare.
3207         * tui/tui-data.c (layout_def): Remove.
3208         (tui_layout_def): Remove.
3209
3210 2019-08-13  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-winsource.h (struct tui_source_window_base)
3213         <clear_detail>: No longer "override".
3214         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3215         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3216         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3217         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3218         Remove.
3219         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3220
3221 2019-08-13  Tom Tromey  <tromey@adacore.com>
3222
3223         * tracepoint.c: Don't include readline.h or history.h.
3224
3225 2019-08-12  Tom Tromey  <tom@tromey.com>
3226
3227         * configure: Rebuild.
3228         * configure.ac: Check for readline 7.
3229         * NEWS: Mention readline 7 requirement.
3230         * README: Update.
3231
3232 2019-08-12  Tom Tromey  <tom@tromey.com>
3233
3234         * mingw-hdep.c (gdb_select): Remove readline hack.
3235
3236 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3237
3238         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3239         when the function fails.
3240
3241 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3242
3243         * s390-tdep.c (s390_type_align): New function.
3244         (s390_gdbarch_init): Set it as type_align gdbarch method.
3245
3246 2019-08-09  Tom de Vries  <tdevries@suse.de>
3247
3248         PR gdb/24591
3249         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3250         pc_low with relocation offset.
3251
3252 2019-08-07  Tom Tromey  <tromey@adacore.com>
3253
3254         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3255         (print_frame_args): Update.
3256         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3257         Update.
3258         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3259         * frame.h (struct frame_arg): Add initializers.
3260         <error>: Now a unique_xmalloc_ptr.
3261
3262 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3263
3264         * NEWS: Expand the Pointer Authentication entry.
3265         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3266         (aarch64_frame_unmask_lr): ... to this.
3267         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3268         Call aarch64_frame_unmask_lr.
3269         * frame.c (struct frame_info): Add "masked" variable.
3270         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3271         (fprint_frame): Check for masked pc.
3272         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3273         declarations.
3274         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3275         * stack.c (print_frame): Check for masked pc.
3276
3277 2019-08-06  Tom Tromey  <tom@tromey.com>
3278
3279         * stabsread.c (patch_block_stabs, read_one_struct_field)
3280         (read_enum_type): Use obstack_strndup.
3281         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3282         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3283         * dwarf2read.c (guess_full_die_structure_name)
3284         (anonymous_struct_prefix): Use obstack_strndup.
3285         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3286         * c-exp.y (yylex): Use obstack_strndup.
3287         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3288         (write_var_or_type): Use obstack_strndup.
3289
3290 2019-08-06  Tom Tromey  <tom@tromey.com>
3291
3292         * symfile.c (reread_symbols): Use obstack_strdup.
3293         * stabsread.c (read_type): Use obstack_strdup.
3294         * gdb_obstack.h (obstack_strdup): New overload.
3295         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3296         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3297         (dwarf2_canonicalize_name): Use obstack_strdup.
3298         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3299         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3300         Use obstack_strdup.
3301
3302 2019-08-06  Tom Tromey  <tom@tromey.com>
3303
3304         * gdb_obstack.h (obstack_strdup): Define.
3305         * gdb_obstack.c (obstack_strdup): Don't define.
3306
3307 2019-08-06  Tom Tromey  <tom@tromey.com>
3308
3309         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3310         obstack_strdup.
3311         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3312         obstack_strdup.
3313         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3314         * stabsread.c (common_block_start): Use obstack_strdup.
3315         * objfiles.c (set_objfile_main_name, objfile): Use
3316         obstack_strdup.
3317         * namespace.c (add_using_directive): Use obstack_strdup.
3318         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3319         * jit.c (finalize_symtab): Use obstack_strdup.
3320         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3321         (guess_partial_die_structure_name, partial_die_info::fixup)
3322         (dwarf2_name): Use obstack_strdup.
3323         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3324         obstack_strdup.
3325         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3326         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3327         obstack_strdup.
3328         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3329
3330 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3331
3332         * unittests/help-doc-selftests.c: New file.
3333         * Makefile.in: Add the new file.
3334
3335 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3336
3337         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3338         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3339         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3340         the trailing '.' is not output, and the first character is uppercased.
3341         (print_help_for_command): Update call to print_doc_line.
3342         (print_doc_of_command): Likewise.
3343         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3344         * cli/cli-option.c (append_indented_doc): Do not append newline.
3345         (build_help_option): Append newline after first appended_indented_doc
3346         only if a second call is done.
3347         (build_help): Append 2 new lines before each option, except the first
3348         one.
3349         * compile/compile.c (_initialize_compile): Add new lines after
3350         %OPTIONS%, when not at the end of the help.
3351         Change help doc or code
3352         producing the help doc to respect the invariants.
3353         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3354         Also removed the new line after 'Options:', as all other commands
3355         do not put an empty line between 'Options:' and the first option.
3356         * printcmd.c (_initialize_printcmd): Likewise.
3357         * stack.c (_initialize_stack): Likewise.
3358         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3359         incorrectly telling COMMAND is optional.
3360         * ada-lang.c (_initialize_ada_language): Change help doc or code
3361         producing the help doc to respect the invariants.
3362         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3363         * breakpoint.c (_initialize_breakpoint): Likewise.
3364         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3365         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3366         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3367         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3368         _initialize_cli_style): Likewise.
3369         * corelow.c (core_target_info): Likewise.
3370         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3371         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3372         * filesystem.c (_initialize_filesystem): Likewise.
3373         * frame.c (_initialize_frame): Likewise.
3374         * gnu-nat.c (add_task_commands): Likewise.
3375         * infcall.c (_initialize_infcall): Likewise.
3376         * infcmd.c (_initialize_infcmd): Likewise.
3377         * interps.c (_initialize_interpreter): Likewise.
3378         * language.c (_initialize_language): Likewise.
3379         * linux-fork.c (_initialize_linux_fork): Likewise.
3380         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3381         * maint.c (_initialize_maint_cmds): Likewise.
3382         * memattr.c (_initialize_mem): Likewise.
3383         * printcmd.c (_initialize_printcmd): Likewise.
3384         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3385         _RegEx): Likewise.
3386         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3387         * record-btrace.c (_initialize_record_btrace): Likewise.
3388         * record-full.c (_initialize_record_full): Likewise.
3389         * record.c (_initialize_record): Likewise.
3390         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3391         * regcache.c (_initialize_regcache): Likewise.
3392         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3393         _initialize_remote): Likewise.
3394         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3395         * serial.c (_initialize_serial): Likewise.
3396         * skip.c (_initialize_step_skip): Likewise.
3397         * source.c (_initialize_source): Likewise.
3398         * stack.c (_initialize_stack): Likewise.
3399         * symfile.c (_initialize_symfile): Likewise.
3400         * symtab.c (_initialize_symtab): Likewise.
3401         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3402         * top.c (init_main): Likewise.
3403         * tracefile-tfile.c (tfile_target_info): Likewise.
3404         * tracepoint.c (_initialize_tracepoint): Likewise.
3405         * tui/tui-win.c (_initialize_tui_win): Likewise.
3406         * utils.c (add_internal_problem_command): Likewise.
3407         * valprint.c (value_print_option_defs): Likewise.
3408
3409 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3410
3411         PR build/24886
3412         * configure.ac: Drop enable-libmcheck support.
3413         * configure, config.in: Rebuild.
3414         * libmcheck.m4: Remove.
3415         * acinclude.m4: Don't include it.
3416         * Makefile.in: Don't distribute it.
3417         * top.c (print_gdb_configuration): Don't mention it.
3418
3419 2019-08-06  Tom Tromey  <tom@tromey.com>
3420
3421         * utils.c (set_output_style): Sometimes pass stream to
3422         emit_style_escape.
3423         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3424         * record-btrace.c (btrace_insn_history): Update.
3425         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3426         method.
3427         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3428         Update initializers.
3429         <m_uiout>: New field.
3430         <m_di>: Move lower.
3431         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3432         Remove "uiout" parameter.
3433         (dump_insns): Update.
3434         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3435         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3436
3437 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3438
3439         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3440         (error_in_psymtab_expansion): Likewise.
3441         (lookup_symbol_via_quick_fns): Likewise.
3442         (basic_lookup_transparent_type_quick): Likewise.
3443         (basic_lookup_transparent_type_1): Likewise.
3444
3445 2019-08-06  Tom Tromey  <tromey@adacore.com>
3446
3447         * source.c (last_source_error): Now bool.
3448         (print_source_lines_base): Make "noprint" bool.  Only open
3449         source file when last_source_visited changes.
3450
3451 2019-08-06  Tom Tromey  <tromey@adacore.com>
3452
3453         * annotate.c (annotate_source_line): Use g_source_cache.
3454         * source-cache.c (source_cache::get_plain_source_lines): Change
3455         parameters.  Populate m_offset_cache.
3456         (source_cache::ensure): New method.
3457         (source_cache::get_line_charpos): New method.
3458         (extract_lines): Move lower.  Change parameters.
3459         (source_cache::get_source_lines): Move lower.
3460         * source-cache.h (class source_cache): Update comment.
3461         <get_line_charpos>: New method.
3462         <get_source_lines>: Update comment.
3463         <clear>: Clear m_offset_cache.
3464         <get_plain_source_lines>: Change parameters.
3465         <ensure>: New method
3466         <m_offset_cache>: New member.
3467         * source.c (forget_cached_source_info_for_objfile): Update.
3468         (info_source_command): Use g_source_cache.
3469         (find_source_lines, open_source_file_with_line_charpos): Remove.
3470         (print_source_lines_base, search_command_helper): Use g_source_cache.
3471         * source.h (open_source_file_with_line_charpos): Don't declare.
3472         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3473         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3474         Use g_source_cache.
3475
3476 2019-08-06  Tom Tromey  <tromey@adacore.com>
3477
3478         * source-cache.c (source_cache::get_plain_source_lines):
3479         Remove "first_line" and "last_line" parameters.
3480         (source_cache::get_source_lines): Cache plain text.
3481         * source-cache.h (class source_cache)
3482         <get_plain_source_lines>: Update.
3483
3484 2019-08-06  Tom Tromey  <tromey@adacore.com>
3485
3486         * source-cache.c (extract_lines): No longer a method.
3487         Changed type of parameter.  Include final newline.
3488         (selftests::extract_lines_test): New function.
3489         (_initialize_source_cache): Likewise.
3490         * source-cache.h (class source_cache)
3491         <extract_lines>: Don't declare.
3492
3493 2019-08-06  Tom Tromey  <tromey@adacore.com>
3494
3495         * breakpoint.c (init_breakpoint_sal): Update.
3496         (breakpoint): Update.
3497         * breakpoint.h (struct breakpoint) <filter>: Now a
3498         unique_xmalloc_ptr.
3499
3500 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3501
3502         * NEWS: Mention dictionary access on blocks.
3503         * python/py-block.c (blpy_getitem): New function.
3504         (block_object_as_mapping): New struct.
3505         (block_object_type): Use new struct for tp_as_mapping field.
3506
3507 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3508
3509         * objfiles.h (objfile): Add a comment describing partial symbols.
3510
3511 2019-08-05  Tom Tromey  <tromey@adacore.com>
3512
3513         * compile/compile.c (_initialize_compile): Use _(), not N_().
3514         * thread.c (_initialize_thread): Use _(), not N_().
3515         * stack.c (_initialize_stack): Use _(), not N_().
3516         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3517
3518 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3519
3520         * dwarf2read.c (struct dw2_symtab_iterator):
3521         <want_specific_block>: Remove.
3522         <block_index>: Change type to gdb::optional.
3523         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3524         change type of BLOCK_INDEX parameter to gdb::optional.
3525         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3526         (dw2_lookup_symbol): Don't pass argument for
3527         WANT_SPECIFIC_BLOCK.
3528         (dw2_expand_symtabs_for_function): Don't pass argument for
3529         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3530         (class dw2_debug_names_iterator)
3531         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3532         parameter, change BLOCK_INDEX type to gdb::optional.
3533         <m_want_specific_block>: Remove.
3534         <m_block_index>: Change type to gdb::optional.
3535         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3536         gdb::optional.  Re-write in function of gdb::optional.
3537         (dw2_debug_names_lookup_symbol): Don't pass argument for
3538         WANT_SPECIFIC_BLOCK.
3539         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3540         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3541         BLOCK_INDEX.
3542
3543 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * NEWS: Mention changes to "info sources" command.
3546
3547 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3548
3549         * symtab.c (filename_partial_match_opts): New struct type.
3550         (struct output_source_filename_data): New members
3551         regexp, c_regexp, partial_match.
3552         (output_source_filename): Use new members to decide to print file.
3553         (info_sources_option_defs): New variable.
3554         (make_info_sources_options_def_group, print_info_sources_header,
3555         info_sources_command_completer):
3556         New functions.
3557         (info_sources_command): Read new optional arguments.
3558         (_initialize_symtab): Update info sources help.
3559
3560 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3561
3562         * ada-lang.c (exception_support_info_v0): Renamed from...
3563         (default_exception_support_info): ... this.  Create new
3564         definition for v1.
3565         (ada_has_this_exception_support): Look up catch_handlers_sym.
3566         (ada_exception_support_info_sniffer): Try v0 after default.
3567
3568 2019-08-01  Tom Tromey  <tromey@adacore.com>
3569
3570         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3571         gdbarch.h.
3572
3573 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3574
3575         * s12z-tdep.c: Fix include path for s12z-opc.h.
3576
3577 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3578
3579         * NEWS: Require GNU make 3.82.
3580
3581 2019-07-16  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3584         declare.
3585
3586 2019-07-30  Tom Tromey  <tromey@adacore.com>
3587
3588         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3589
3590 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3591
3592         * printcmd.c (print_address_symbolic): Print negative offsets.
3593         (build_address_symbolic): Force signed arithmetic when computing
3594         offset.
3595
3596 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3597
3598         PR/24474: Add a function to lookup static variables.
3599         * NEWS: Mention this new function.
3600         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3601         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3602         * python/python.c (python_GdbMethods): Add new function.
3603
3604 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3605
3606         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3607         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3608         (objfpy_lookup_static_symbol): New function.
3609         (objfile_object_methods): Add new functions.
3610
3611 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3612
3613         * NEWS: Mention 'set|show print frame-info'.  Mention new
3614         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3615         backtrace argument.  Mention that python frame filtering code
3616         is now consistent with what 'backtrace' command prints.
3617
3618 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3619
3620         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3621         comments.
3622         (print_frame_info_auto, print_frame_info_source_line,
3623         print_frame_info_location, print_frame_info_source_and_location,
3624         print_frame_info_location_and_address, print_frame_info_short_location):
3625         New declarations.
3626         (struct frame_print_options): New member print_frame_info.
3627         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3628         * stack.h (get_user_print_what_frame_info): New declaration.
3629         (frame_show_address): New declaration.
3630         * stack.c (print_frame_arguments_choices): New value 'presence'.
3631         (print_frame_info_auto, print_frame_info_source_line,
3632         print_frame_info_location, print_frame_info_source_and_location,
3633         print_frame_info_location_and_address, print_frame_info_short_location,
3634         print_frame_info_choices, print_frame_info_print_what): New definitions.
3635         (print_frame_args): Only print dots for args if print frame-arguments
3636         is 'presence'.
3637         (frame_print_option_defs): New element for "frame-info".
3638         (get_user_print_what_frame_info): New function.
3639         (frame_show_address): Make non static.  Move comment to stack.h.
3640         (print_frame_info_to_print_what): New function.
3641         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3642         to decide what to print.
3643         (backtrace_command_1): Handle the new print_frame_arguments_presence
3644         value.
3645         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3646         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3647         (py_print_frame): In non-mi mode, use LOCATION as default for
3648         print_what, similarly to frame information printed directly by
3649         backtrace command. Handle frame-info user option in non MI mode.
3650
3651 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3652
3653         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3654         Add case for debugging 32-bit target on 64-bit host.  Revise
3655         comment.
3656
3657 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3658
3659         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3660         instead of find_function_entry_range_from_pc.
3661
3662 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3663
3664         * stack.c (find_frame_funname): Remove code which preferred
3665         minsym over symtab sym in "certain pathological cases".
3666
3667         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3668         parameter.  Change type of "do_demangle" to bool.
3669         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3670         Pass suitable "prefer_sym_over_minsym" flag to
3671         build_address_symbolic().  Don't output "+" for negative offsets.
3672         * printcmd.c (print_address_symbolic): Update invocation of
3673         build_address_symbolic to include a "prefer_sym_over_minsym"
3674         flag.
3675         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3676         Restrict cases in which use of minimal symbol is preferred to that
3677         of a found symbol.  Update comments.
3678
3679         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3680         for entry pc when entry pc is out of range for that FDE.
3681
3682 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3683
3684         PR gdb/24839:
3685         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3686         type.
3687
3688 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3689
3690         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3691         this function's Python signature.
3692
3693
3694 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3695
3696         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3697         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3698         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3699         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3700         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3701
3702
3703 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3704
3705         * h8300-tdep.c (h8300_register_name_common): New.
3706         h8300_register_name): Use h8300_register_name_common.
3707         (h8300s_register_name): Likewise.
3708         (h8300sx_register_name): Likewise.
3709         (h8300h_register_nam): New.
3710         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3711
3712
3713 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3714
3715         * arm-tdep.c (arm_skip_cmse_entry): New function.
3716         (arm_is_sgstubs_section): New function.
3717         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3718
3719 2019-07-22  Tom Tromey  <tom@tromey.com>
3720
3721         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3722         Don't self-assign.
3723
3724 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3727         type_print.
3728
3729 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3732         so that GDB doesn't match any msymbols when searching in the
3733         TYPES_DOMAIN.
3734         (print_symbol_info): Print using typedef_print or type_print based
3735         on the type of the symbol.  Add updated FIXME comment moved from...
3736         (_initialize_symtab): ... move and update FIXME comment to above.
3737
3738 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * NEWS: Mention adding -q option to "info types".
3741         * symtab.c (struct info_types_options): New struct.
3742         (info_types_options_defs): New variable.
3743         (make_info_types_options_def_group): New function.
3744         (info_types_command): Use gdb::option framework to parse options.
3745         (info_types_command_completer): New function.
3746         (_initialize_symtab): Extend the help text on "info types" and
3747         register command completer.
3748
3749 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3750
3751         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3752         (lookup_symbol_in_objfile): Change int to block_enum and add a
3753         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3754
3755 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3756
3757         * MAINTAINERS (Write After Approval): Add self.
3758
3759 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3760
3761         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3762         instruction to the dummy code region.
3763
3764 2019-07-19  Tom Tromey  <tromey@adacore.com>
3765
3766         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3767         (ARGSUSED, PARAMS, __func__): Remove rules.
3768
3769 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3770
3771         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3772         * features/arm/arm-with-iwmmxt.c: Remove.
3773         * features/arm/arm-with-iwmmxt.xml: Remove.
3774         * features/arm/arm-with-m-fpa-layout.c: Remove.
3775         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3776         * features/arm/arm-with-m-vfp-d16.c: Remove.
3777         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3778         * features/arm/arm-with-m.c: Remove.
3779         * features/arm/arm-with-m.xml: Remove.
3780         * features/arm/arm-with-neon.c: Remove.
3781         * features/arm/arm-with-neon.xml: Remove.
3782         * features/arm/arm-with-vfpv2.c: Remove.
3783         * features/arm/arm-with-vfpv2.xml: Remove.
3784         * features/arm/arm-with-vfpv3.c: Remove.
3785         * features/arm/arm-with-vfpv3.xml: Remove.
3786
3787 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3788
3789         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3790
3791 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3792
3793         * arch/aarch32.c (aarch32_create_target_description): Create
3794         target descriptions using features.
3795         * arch/arm.c (arm_create_target_description)
3796         (arm_create_mprofile_target_description): Likewise.
3797         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3798
3799 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3800
3801         * Makefile.in: Add new files.
3802         * aarch32-tdep.c: New file.
3803         * aarch32-tdep.h: New file.
3804         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3805         Call aarch32_read_description.
3806         * arch/aarch32.c: New file.
3807         * arch/aarch32.h: New file.
3808         * arch/arm.c (arm_create_target_description)
3809         (arm_create_mprofile_target_description): New function.
3810         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3811         (arm_create_target_description)
3812         (arm_create_mprofile_target_description): New declaration.
3813         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3814         read_description functions.
3815         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3816         Likewise.
3817         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3818         * arm-tdep.c (tdesc_arm_list): New variable.
3819         (arm_register_g_packet_guesses): Call create description functions.
3820         (arm_read_description) (arm_read_mprofile_description): New
3821         function.
3822         * arm-tdep.h (arm_read_description)
3823         (arm_read_mprofile_description): Add declaration.
3824         * configure.tgt: Add new files.
3825
3826 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3827
3828         * top.c (new_ui_command): Open specified terminal just once.
3829
3830 2019-07-18  Tom Tromey  <tromey@adacore.com>
3831
3832         * symtab.c (main_name): Constify return type.
3833         * symfile.c (set_initial_language): Update.
3834         * symtab.h (main_name): Constify return type.
3835
3836 2019-07-17  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-winsource.c (tui_update_source_window)
3839         (tui_update_source_window_as_is)
3840         (tui_update_source_windows_with_line): Remove return.
3841         * tui/tui-disasm.c (tui_show_disassem)
3842         (tui_show_disassem_and_update_source): Remove return.
3843         * tui/tui.c (tui_reset): Remove return.
3844         * tui/tui-wingeneral.c
3845         (tui_check_and_display_highlight_if_needed): Remove return.
3846
3847 2019-07-17  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3850
3851 2019-07-17  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-winsource.h (struct tui_exec_info_window)
3854         (struct tui_source_window_base): Move from tui-data.h.
3855         * tui/tui-winsource.c: Move many method definitions from
3856         elsewhere.  Remove "structuring" comments.
3857         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3858         (tui_source_window_base::refresh_window): Move to
3859         tui-winsource.c.
3860         * tui/tui-win.c (tui_source_window_base::refresh_all)
3861         (tui_source_window_base::update_tab_width)
3862         (tui_source_window_base::set_new_height)
3863         (tui_source_window_base::do_make_visible_with_new_height): Move to
3864         tui-winsource.c.
3865         * tui/tui-source.h: Update.
3866         * tui/tui-source.c (tui_source_window_base::reset): Move to
3867         tui-winsource.c.
3868         * tui/tui-disasm.h: Update.
3869         * tui/tui-data.h (struct tui_exec_info_window): Move to
3870         tui-winsource.h.
3871         (struct tui_source_window_base): Likewise.
3872         * tui/tui-data.c (tui_source_window_base::clear_detail)
3873         (tui_source_window_base, ~tui_source_window_base): Move to
3874         tui-winsource.c.
3875
3876 2019-07-17  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-win.c (tui_resize_all)
3879         (tui_source_window_base::update_tab_width)
3880         (tui_adjust_win_heights): Update.
3881         (tui_win_info::make_invisible_and_set_new_height): Rename from
3882         make_invisible_and_set_new_height.
3883         * tui/tui-data.h (struct tui_win_info)
3884         <make_invisible_and_set_new_height>: New method.
3885
3886 2019-07-17  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui.c: Update.
3889         * tui/tui-source.h (struct tui_source_window): Move from
3890         tui-data.h.
3891         * tui/tui-layout.c: Update.
3892         * tui/tui-disasm.c: Update.
3893         * tui/tui-data.h (struct tui_source_window): Move to
3894         tui-source.h.
3895
3896 2019-07-17  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3899         tui-data.h.
3900         * tui/tui-data.h (struct tui_disasm_window): Move to
3901         tui-disasm.h.
3902
3903 2019-07-17  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-regs.h (struct tui_data_item_window): Move from
3906         tui-data.h.
3907         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3908         * tui/tui-data.h (struct tui_data_item_window): Move to
3909         tui-regs.h.
3910         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3911
3912 2019-07-17  Tom Tromey  <tom@tromey.com>
3913
3914         * tui/tui.c: Update.
3915         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3916         (tui_cmd_window::max_height): Move to tui-command.c.
3917         * tui/tui-layout.c: Update.
3918         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3919         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3920         tui-command.c.
3921         * tui/tui-command.h (struct tui_cmd_window): Move from
3922         tui-data.h.
3923         * tui/tui-command.c: Remove "structuring" comments.
3924         (tui_cmd_window::clear_detail)
3925         (tui_cmd_window::do_make_visible_with_new_height)
3926         (tui_cmd_window::max_height): Move from elsewhere.
3927
3928 2019-07-17  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3931         Now static.
3932         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3933         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3934
3935 2019-07-17  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui.c: Update.
3938         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3939         tui-regs.c.
3940         * tui/tui-windata.h: Remove file.
3941         * tui/tui-windata.c: Remove file.
3942         * tui/tui-win.c (tui_data_window::set_new_height)
3943         (tui_data_window::do_make_visible_with_new_height): Move to
3944         tui-regs.c.
3945         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3946         * tui/tui-regs.c: Remove "structuring" comments.
3947         (tui_data_window::first_data_item_displayed)
3948         (tui_data_window::delete_data_content_windows)
3949         (tui_data_window::erase_data_content)
3950         (tui_data_window::display_all_data)
3951         (tui_data_window::refresh_all)
3952         (tui_data_window::do_scroll_vertical)
3953         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3954         (tui_data_window::do_make_visible_with_new_height)
3955         (tui_data_window::refresh_window): Move from elsewhere.
3956         (_initialize_tui_regs): Move to end of file.
3957         * tui/tui-layout.c: Update.
3958         * tui/tui-hooks.c: Update.
3959         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3960         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3961         tui-regs.c.
3962         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3963
3964 2019-07-17  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3967         seen.
3968
3969 2019-07-17  Tom Tromey  <tom@tromey.com>
3970
3971         * tui/tui-win.c (tui_source_window_base::set_new_height)
3972         (tui_source_window_base::do_make_visible_with_new_height): Use
3973         m_has_locator field directly.
3974         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3975         method.
3976         (struct tui_source_window_base) <has_locator>: Likewise.
3977
3978 2019-07-17  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3981         Don't declare.
3982         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3983         Remove.
3984         * tui/tui-win.c (tui_source_window_base::set_new_height)
3985         (tui_source_window_base::set_new_height)
3986         (make_invisible_and_set_new_height)
3987         (tui_source_window_base::do_make_visible_with_new_height)
3988         (tui_source_window_base::do_make_visible_with_new_height):
3989         Update.
3990         * tui/tui-layout.c (show_source_disasm_command, show_data)
3991         (show_source_or_disasm_and_command): Update.
3992         * tui/tui-layout.c (show_layout): Update.
3993
3994 2019-07-17  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-layout.c (make_data_window): Remove.
3997         (show_data): Unify creation and re-initialization cases.
3998
3999 2019-07-17  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-layout.c (make_source_window, make_disasm_window):
4002         Remove.
4003         (show_data): Unify creation and re-initialization cases.
4004
4005 2019-07-17  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-layout.c (make_command_window): Remove.
4008         (show_source_disasm_command, show_source_or_disasm_and_command):
4009         Unify creation and re-initialization cases.
4010
4011 2019-07-17  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4014         creation and re-initialization cases.
4015
4016 2019-07-17  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-regs.c (tui_get_register): Return void.
4019
4020 2019-07-17  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4023         Simplify.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4028         resetting.
4029
4030 2019-07-17  Tom Tromey  <tom@tromey.com>
4031
4032         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4033         * tui/tui-regs.c (tui_reg_layout): New function.
4034         (tui_show_registers, tui_reg_command): Use it.
4035         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4036         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4037         parameters.
4038         (tui_layout_command): Remove.
4039
4040 2019-07-17  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-layout.h (tui/tui-layout): Return void.
4043         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4044
4045 2019-07-17  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-layout.c (show_source_disasm_command, show_data):
4048         Update.
4049         (reset_locator): Remove.
4050         (show_source_or_disasm_and_command): Update.
4051
4052 2019-07-17  Tom Tromey  <tom@tromey.com>
4053
4054         * tui/tui-source.c (tui_source_window_base::reset): Remove
4055         win_type parameter.
4056         * tui/tui-layout.c (make_command_window, make_source_window)
4057         (make_disasm_window, make_data_window)
4058         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4059         (reset_locator, show_source_or_disasm_and_command): Update.
4060         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4061         win_type parameter.
4062         (struct tui_source_window_base) <reset>: Likewise.
4063
4064 2019-07-17  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-layout.c (show_source_disasm_command): Use
4067         reset_locator.
4068         (reset_locator): New function.
4069         (init_and_make_win): Remove.
4070         (show_source_or_disasm_and_command): Use reset_locator.
4071
4072 2019-07-17  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4075         condition.
4076         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4077         Remove condition.
4078         * tui/tui-source.c (tui_source_window_base::reset): New method.
4079         * tui/tui-layout.c (make_command_window): Don't call
4080         init_and_make_win.
4081         (make_source_window, make_disasm_window): Don't call
4082         make_source_or_disasm_window.
4083         (make_data_window): Don't call init_and_make_win.  Change calling
4084         convention.
4085         (show_source_disasm_command, show_data): Simplify.
4086         (make_source_or_disasm_window): Remove.
4087         (show_source_or_disasm_and_command): Simplify.
4088         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4089         (struct tui_source_window_base) <reset>: Likewise.
4090         <execution_info>: Remove initializer.
4091         * tui/tui-data.c (tui_source_window_base): Initialize
4092         execution_info.
4093
4094 2019-07-17  Tom Tromey  <tom@tromey.com>
4095
4096         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4097         variable.
4098
4099 2019-07-17  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui.c (tui_rl_other_window): Update.
4102         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4103         superclass method first.  Always iterate over regs_content.
4104         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4105         method.
4106         * tui/tui-win.c (tui_set_focus_command): Update.
4107
4108 2019-07-17  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-win.c (tui_set_focus_command): Rename from
4111         tui_set_focus.  Call tui_enable.
4112         (tui_set_focus_command): Remove.
4113
4114 2019-07-17  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4117         refresh_window.
4118         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4119         touchwin.
4120         (tui_data_window::refresh_window): Call refresh_window on data
4121         items.  Always call superclass refresh_window.
4122         (tui_win_info::refresh): Remove.
4123         (tui_source_window_base::refresh_window): Update.
4124         (tui_refresh_all): Update.
4125         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4126         refresh_window.
4127         (show_source_or_disasm_and_command): Likewise.
4128         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4129         (struct tui_source_window_base) <refresh>: Likewise.
4130
4131 2019-07-17  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-winsource.c (tui_clear_source_content)
4134         (tui_show_source_content): Update.
4135         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4136         whether content is empty.
4137         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4138         Remove.
4139
4140 2019-07-17  Tom Tromey  <tom@tromey.com>
4141
4142         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4143         window's contents.
4144         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4145         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4146
4147 2019-07-17  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4150         (struct tui_data_item_window): Update.
4151
4152 2019-07-17  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4155         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4156         defines.
4157
4158 2019-07-17  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-winsource.h (tui_erase_source_content)
4161         (tui_clear_source_content): Remove "display_prompt" parameter.
4162         * tui/tui-winsource.c (tui_update_source_window_as_is)
4163         (tui_update_source_windows_with_addr): Update.
4164         (tui_clear_source_content): Remove "display_prompt" parameter.
4165         (tui_erase_source_content): Likewise.  Simplify.
4166         (tui_show_source_content): Update.
4167         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4168         * tui/tui-stack.c (tui_show_frame_info): Update.
4169         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4170         Remove defines.
4171
4172 2019-07-17  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4175         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4176         parameter.
4177         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4178         parameter.
4179
4180 2019-07-17  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-winsource.c (tui_clear_source_content)
4183         (tui_show_source_content, tui_show_exec_info_content)
4184         (tui_clear_exec_info_content): Update.
4185         * tui/tui-stack.c (tui_show_locator_content): Update.
4186         (tui_show_frame_info): Update.
4187         * tui/tui-source.h (tui_source_window): Don't declare.
4188         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4189         from tui_source_is_displayed.
4190         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4191         Remove field.
4192         (struct tui_source_window_base) <content_in_use>: New field.  Now
4193         bool.
4194         (struct tui_source_window) <showing_source_p>: New method.
4195         (TUI_SRC_WIN): Change cast.
4196         * tui/tui-data.c (tui_initialize_static_data): Update.
4197
4198 2019-07-17  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4201         location_matches_p.
4202         * tui/tui-source.c (tui_source_window::location_matches_p): New
4203         method.
4204         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4205         method.
4206         * tui/tui-data.h (struct tui_source_window_base)
4207         <location_matches_p>: New method.
4208         (struct tui_source_window, struct tui_disasm_window)
4209         <location_matches_p>: Likewise.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-win.c (tui_set_win_height_command): Rename from
4214         tui_set_win_height.
4215         (tui_set_win_height_command): Remove.
4216
4217 2019-07-17  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-source.c (tui_source_window): New constructor.  Add
4220         observer.
4221         (~tui_source_window): New destructor.
4222         (tui_source_window::style_changed): New method.
4223         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4224         (tui_attach_detach_observers): Update.
4225         * tui/tui-data.h (struct tui_source_window): Make constructor not
4226         inline.  Add destructor.
4227         (struct tui_source_window) <style_changed>: New method.
4228         <m_observable>: New member.
4229
4230 2019-07-17  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4233         * tui/tui-win.c (tui_resize_all): Fix typo.
4234
4235 2019-07-17  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4238         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4239         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4240         * tui/tui-win.c (window_name_completer): Use foreach.
4241         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4242         (update_tab_width): Likewise.
4243         * tui/tui-layout.c (show_layout): Update.
4244         * tui/tui-data.h (class tui_window_iterator): New.
4245         (struct all_tui_windows): New.
4246         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4247
4248 2019-07-17  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4251         parameter.  Don't reference globals.
4252         (tui_reg_command): Update.
4253
4254 2019-07-17  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-regs.c (tui_show_registers): Simplify.
4257
4258 2019-07-17  Tom Tromey  <tom@tromey.com>
4259
4260         * tui/tui-regs.c (tui_show_registers): Update.
4261         (tui_show_register_group): Add win_info parameter.
4262
4263 2019-07-17  Tom Tromey  <tom@tromey.com>
4264
4265         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4266         Rename from tui_display_reg_element_at_line.
4267         (tui_data_window::display_registers_from_line): Update.
4268         * tui/tui-data.h (struct tui_data_window)
4269         <display_reg_element_at_line>: New method.
4270
4271 2019-07-17  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-regs.h (tui_display_registers_from)
4274         (tui_display_registers_from_line): Don't declare.
4275         * tui/tui-windata.c (tui_data_window::display_all_data)
4276         (tui_data_window::refresh_all)
4277         (tui_data_window::do_scroll_vertical): Update.
4278         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4279         from tui_display_registers_from.
4280         (tui_display_reg_element_at_line): Update.
4281         (tui_data_window::display_registers_from_line): Rename from
4282         tui_display_registers_from_line.
4283         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4284         display_registers_from_line>: New methods.
4285
4286 2019-07-17  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4289         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4290         from tui_erase_data_content.
4291         (tui_data_window::display_all_data)
4292         (tui_data_window::refresh_all)
4293         (tui_data_window::do_scroll_vertical): Update.
4294         * tui/tui-regs.c (tui_show_registers): Update.
4295         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4296         New method.
4297
4298 2019-07-17  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4301         declare.
4302         * tui/tui-windata.c
4303         (tui_data_window::delete_data_content_windows): Rename from
4304         tui_delete_data_content_windows.
4305         (tui_data_window::display_all_data)
4306         (tui_data_window::do_scroll_vertical): Update.
4307         * tui/tui-data.h (struct tui_data_window)
4308         <delete_data_content_windows>: New method.
4309
4310 2019-07-17  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4313         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4314
4315 2019-07-17  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4318         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4319         from tui_display_all_data.
4320         * tui/tui-win.c
4321         (tui_data_window::do_make_visible_with_new_height): Update.
4322         * tui/tui-regs.c (tui_show_registers): Update.
4323         * tui/tui-layout.c (tui_set_layout): Update.
4324         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4325         method.
4326
4327 2019-07-17  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4330         * tui/tui-windata.c (tui_display_data_from): Remove.
4331         (tui_data_window::refresh_all): Update.
4332
4333 2019-07-17  Tom Tromey  <tom@tromey.com>
4334
4335         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4336         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4337         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4338         tui_display_registers_from_line.
4339         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4340         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4341         "force_display" parameter.
4342
4343 2019-07-17  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4346         declare.
4347         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4348         Rename from tui_first_reg_element_no_inline.
4349         (tui_display_reg_element_at_line)
4350         (tui_display_registers_from_line): Update.
4351         * tui/tui-data.h (struct tui_data_window)
4352         <first_reg_element_no_inline>: New method.
4353
4354 2019-07-17  Tom Tromey  <tom@tromey.com>
4355
4356         * tui/tui-windata.c (tui_display_data_from)
4357         (tui_data_window::do_scroll_vertical): Update.
4358         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4359         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4360         Rename from tui_line_from_reg_element_no.
4361         (tui_display_registers_from_line): Update.
4362         * tui/tui-data.h (struct tui_data_window)
4363         <line_from_reg_element_no>: New method.
4364
4365 2019-07-17  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4368         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4369         tui_last_regs_line_no.
4370         (tui_display_reg_element_at_line)
4371         (tui_display_registers_from_line): Update.
4372         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4373         method.
4374
4375 2019-07-17  Tom Tromey  <tom@tromey.com>
4376
4377         PR tui/24722:
4378         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4379         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4380         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4381         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4382         (tui_update_breakpoint_info): Likewise.
4383         * tui/tui-hooks.c (tui_event_create_breakpoint)
4384         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4385         Update.
4386
4387 2019-07-17  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4390
4391 2019-07-17  Tom Tromey  <tom@tromey.com>
4392
4393         * tui/tui-winsource.c (tui_update_source_window_as_is)
4394         (tui_update_source_windows_with_addr): Update.
4395         * tui/tui-source.h (tui_set_source_content)
4396         (tui_show_symtab_source): Add "win_info" parameter.
4397         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4398         parameter.
4399         (tui_show_symtab_source): Likewise.
4400
4401 2019-07-17  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-wingeneral.c
4404         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4405
4406 2019-07-17  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4409         (struct tui_cmd_window) <can_scroll>: New method.
4410         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4411         method.
4412
4413 2019-07-17  Tom Tromey  <tromey@adacore.com>
4414
4415         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4416         do_field_signed>: Rename.  Change type of "value".
4417         * ui-out.c (ui_out::field_signed): Rename from field_int.
4418         Change type of "value".
4419         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4420         type of "value".
4421         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4422         do_field_int.  Change type of "value".
4423         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4424         do_field_int.  Change type of "value".
4425         * tracepoint.c (trace_status_mi, tfind_1)
4426         (print_one_static_tracepoint_marker): Update.
4427         * thread.c (print_thread_info_1, print_selected_thread_frame):
4428         Update.
4429         * stack.c (print_frame, print_frame_info): Update.
4430         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4431         Update.
4432         * source.c (print_source_lines_base): Update.
4433         * skip.c (info_skip_command): Update.
4434         * record-btrace.c (btrace_ui_out_decode_error)
4435         (btrace_call_history_src_line): Update.
4436         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4437         Update.
4438         * progspace.c (print_program_space): Update.
4439         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4440         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4441         do_field_int.  Change type of "value".
4442         * mi/mi-out.c (mi_ui_out::do_table_begin)
4443         (mi_ui_out::do_table_header): Update.
4444         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4445         type of "value".
4446         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4447         (mi_cmd_data_list_changed_registers, output_register)
4448         (mi_cmd_data_read_memory, mi_load_progress)
4449         (mi_cmd_trace_frame_collected): Update.
4450         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4451         Update.
4452         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4453         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4454         (mi_cmd_var_list_children, varobj_update_one): Update.
4455         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4456         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4457         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4458         * inferior.c (print_inferior): Update.
4459         * gdb_bfd.c (print_one_bfd): Update.
4460         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4461         Update.
4462         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4463         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4464         do_field_int.  Change type of "value".
4465         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4466         do_field_int.  Change type of "value".
4467         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4468         (print_one_breakpoint_location, print_it_catch_fork)
4469         (print_one_catch_fork, print_it_catch_vfork)
4470         (print_one_catch_vfork, print_it_catch_solib)
4471         (print_it_catch_exec, print_it_ranged_breakpoint)
4472         (print_mention_watchpoint, print_mention_masked_watchpoint)
4473         (bkpt_print_it, update_static_tracepoint): Update.
4474         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4475         * break-catch-syscall.c (print_it_catch_syscall): Update.
4476         * ada-tasks.c (print_ada_task_info): Update.
4477         * ada-lang.c (print_it_exception, print_mention_exception):
4478         Update.
4479
4480 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4481
4482         PR breakpoints/24541
4483         * gdbarch.c: Regenerate.
4484         * gdbarch.h: Regenerate.
4485         * gdbarch.sh: Adjust return type and parameter types for
4486         'stap_adjust_register'.
4487         (i386_stap_adjust_register): Adjust signature and return new
4488         register name.
4489         * stap-probe.c (stap_parse_register_operand): Adjust use of
4490         'gdbarch_stap_adjust_register'.
4491
4492 2019-07-17  Tom Tromey  <tromey@adacore.com>
4493
4494         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4495         declare VEC.
4496         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4497         std::vector.
4498         (struct s390_process_info): Add initializers.
4499         (s390_add_process): Use new.
4500         (s390_linux_nat_target::low_forget_process): Use delete.
4501         (s390_linux_nat_target::low_new_fork)
4502         (s390_linux_nat_target::stopped_by_watchpoint)
4503         (s390_linux_nat_target::low_prepare_to_resume)
4504         (s390_linux_nat_target::insert_watchpoint)
4505         (s390_linux_nat_target::insert_hw_breakpoint)
4506         (s390_linux_nat_target::remove_watchpoint)
4507         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4508
4509 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4510
4511         * aarch64-fbsd-nat.c: Include regcache.h.
4512         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4513         argument.
4514         (aarch64_fbsd_nat_target::fetch_registers)
4515         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4516         variable.
4517         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4518
4519 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4520
4521         * fbsd-nat.c: Include gdbarch.h.
4522
4523 2019-07-15  Tom Tromey  <tromey@adacore.com>
4524
4525         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4526
4527 2019-07-15  Tom Tromey  <tromey@adacore.com>
4528
4529         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4530         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4531         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4532         * cli-out.c (cli_ui_out::do_field_int): New method.
4533         * ui-out.c (ui_out::field_unsigned): New method.
4534         * symfile.c (generic_load): Use field_unsigned.
4535         (print_transfer_performance): Likewise.
4536         * record-btrace.c (ui_out_field_uint): Remove.
4537         (btrace_call_history_insn_range, btrace_call_history): Use
4538         field_unsigned.
4539         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4540         field_unsigned.
4541         * ui-out.h (class ui_out) <field_unsigned>: New method.
4542         <do_field_unsigned>: Likewise.
4543
4544 2019-07-15  Tom Tromey  <tromey@adacore.com>
4545
4546         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4547         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4548         * target.c (flash_erase_command): Use field_string.
4549         * infrun.c (print_signal_received_reason): Use field_string.
4550         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4551         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4552         field_string.
4553         * ada-tasks.c (print_ada_task_info): Use field_string.
4554
4555 2019-07-15  Tom Tromey  <tromey@adacore.com>
4556
4557         * target.c (flash_erase_command): Use field_core_addr.
4558         * symfile.c (generic_load): Use field_core_addr.
4559         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4560         Use field_core_addr.
4561         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4562         field_core_addr.
4563
4564 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4567         value if its desired type is smaller than a CORE_ADDR and signed.
4568
4569 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4572         of changes to field names, and use new is_reference field to
4573         decide if a property is a reference or not.
4574         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4575         field.
4576         (struct dwarf2_property_baton): Update header comment, rename
4577         'referenced_type' to 'property_type' and update comments.
4578         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4579         default property type, store in property baton, update to take
4580         accound of renamed field.
4581         (read_func_scope): Update call to attr_to_dynamic_prop.
4582         (read_array_type): Likewise.
4583         (dwarf2_per_cu_addr_sized_int_type): New function.
4584         (read_subrange_index_type): Move type finding code to
4585         dwarf2_per_cu_addr_sized_int_type.
4586         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4587         (dwarf2_per_cu_addr_type): New function.
4588         (set_die_type): Update calls to attr_to_dynamic_prop.
4589
4590 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * dwarf2read.c (read_subrange_index_type): New function.
4593         (read_subrange_type): Move code into new function and call it.
4594         * gdbtypes.c (create_range_type): Add some asserts.
4595
4596 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4599         update return statements.
4600         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4601         declaration, and update comment to match.
4602         * gdbtypes.c (resolve_dynamic_array): Update call to
4603         dwarf2_evaluate_property to match new return type.
4604
4605 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * valarith.c (value_subscripted_rvalue): Change lowerbound
4608         parameter type from int to LONGEST.
4609         * value.h (value_subscripted_rvalue): Likewise in declaration.
4610
4611 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * cli/cli-utils.c (info_print_command_completer): New function.
4614         * cli/cli-utils.h: Add 'completer.h' include, and forward
4615         declaration for 'struct cmd_list_element'.
4616         (info_print_command_completer): Declare.
4617         * stack.c (_initialize_stack): Add completer for 'info locals' and
4618         'info args'.
4619         * symtab.c (_initialize_symtab): Add completer for 'info
4620         variables' and 'info functions'.
4621         * NEWS: Mention completion for additional info commands.
4622
4623 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4624
4625         * cli/cli-utils.c (extract_info_print_args): Delete.
4626         (extract_arg_maybe_quoted): Delete.
4627         (info_print_options_defs): New variable.
4628         (make_info_print_options_def_group): New function.
4629         (extract_info_print_options): Define new function.
4630         * cli/cli-utils.h (extract_info_print_args): Delete.
4631         (struct info_print_options): New structure.
4632         (extract_info_print_options): Declare new function.
4633         * stack.c (info_locals_command): Update to use new
4634         extract_info_print_options, also add a header comment.
4635         (info_args_command): Likewise.
4636         * symtab.c (info_variables_command): Likewise.
4637         (info_functions_command): Likewise.
4638
4639 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4640
4641         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4642         to extract string arguments.
4643         * common/common-utils.c (extract_string_maybe_quoted): New function.
4644         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4645
4646 2019-07-11  Tom Tromey  <tromey@adacore.com>
4647
4648         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4649         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4650         * top.h (gdbinit): Don't declare.
4651         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4652         into...
4653         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4654         * top.c (gdb_init): Don't call init_cli_cmds.
4655         (gdbinit): Remove.
4656         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4657
4658 2019-07-11  Tom Tromey  <tromey@adacore.com>
4659
4660         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4661         after it has been moved.
4662
4663 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4664
4665         * valops.c (value_must_coerce_to_target): Change return type to
4666         bool.
4667         * value.h (value_must_coerce_to_target): Likewise.
4668
4669 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4670
4671         * breakpoint.c (is_hardware_watchpoint): Remove
4672         forward-declaration.
4673         (is_masked_watchpoint): Change return type to bool.
4674         (is_tracepoint): Likewise.
4675         (is_breakpoint): Likewise.
4676         (is_hardware_watchpoint): Likewise.
4677         (is_watchpoint): Likewise.
4678         (is_no_memory_software_watchpoint): Likewise.
4679         (is_catchpoint): Likewise.
4680         (breakpoint_1): Make FILTER parameter's return type bool.
4681         is_masked_watchpoint): Change return type to bool.
4682         (save_breakpoints): Make FILTER parameter's return type bool.
4683         * breakpoint.h (is_breakpoint): Change return type to bool.
4684         (is_watchpoint): Likewise.
4685         (is_catchpoint): Likewise.
4686         (is_tracepoint): Likewise.
4687
4688 2019-07-10  Tom Tromey  <tom@tromey.com>
4689
4690         * defs.h: Don't include gdbarch.h.
4691         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4692         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4693         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4694         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4695         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4696         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4697         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4698         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4699         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4700         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4701         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4702         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4703         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4704         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4705         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4706         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4707         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4708         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4709         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4710         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4711         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4712         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4713         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4714         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4715         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4716         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4717         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4718
4719 2019-07-10  Tom Tromey  <tromey@adacore.com>
4720
4721         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4722         * breakpoint.c (init_ada_exception_breakpoint): Register as
4723         bp_catchpoint.
4724         (print_one_breakpoint_location, print_one_breakpoint): Use
4725         is_ada_exception_catchpoint.
4726         * ada-lang.c (class ada_catchpoint_location): Pass
4727         bp_loc_software_breakpoint to bp_location constructor.
4728         (is_ada_exception_catchpoint): New function.
4729
4730 2019-07-10  Tom Tromey  <tromey@adacore.com>
4731
4732         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4733         VEC.
4734         (struct arm_exidx_entry): New method operator<.
4735         (struct arm_exidx_data) <section_maps>: Change type.
4736         (arm_exidx_data_free): Remove.
4737         (arm_exidx_data_key): Change type.  Move lower.
4738         (arm_exidx_new_objfile): Update.
4739         (arm_compare_exidx_entries): Remove.
4740         (arm_find_exidx_entry, _initialize_arm_tdep)
4741
4742 2019-07-10  Tom Tromey  <tromey@adacore.com>
4743
4744         * solib-spu.c (ocl_program_data_key): Change type.
4745         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4746         Update.
4747
4748 2019-07-10  Tom Tromey  <tromey@adacore.com>
4749
4750         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4751         (struct solib_aix_inferior_data) <library_list>: Change type.
4752         (solib_aix_inferior_data_handle): Change type.
4753         (get_solib_aix_inferior_data): Update.
4754         (solib_aix_free_library_list): Remove.
4755         (library_list_start_library): Update.
4756         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4757         return type.
4758         (solib_aix_get_library_list)
4759         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4760         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4761
4762 2019-07-10  Tom Tromey  <tromey@adacore.com>
4763
4764         * solib-dsbt.c (struct dsbt_info): Add initializers.
4765         (solib_dsbt_pspace_data): Change type.
4766         (dsbt_pspace_data_cleanup): Remove.
4767         (get_dsbt_info, _initialize_dsbt_solib): Update.
4768
4769 2019-07-10  Tom Tromey  <tromey@adacore.com>
4770
4771         * spu-tdep.c (spu_overlay_data): Change type.
4772         (spu_get_overlay_table, spu_overlay_new_objfile)
4773         (_initialize_spu_tdep): Update.
4774
4775 2019-07-10  Tom Tromey  <tromey@adacore.com>
4776
4777         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4778         destructor.
4779         (dbx_objfile_data_key): Change type and declare later.
4780         (DBX_SYMFILE_INFO): Rewrite.
4781         * dbxread.c (dbx_objfile_data_key): Change type.
4782         (dbx_symfile_init): Update.
4783         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4784         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4785         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4786
4787 2019-07-10  Tom Tromey  <tromey@adacore.com>
4788
4789         * jit.c (jit_program_space_key): Change type.  Move lower.
4790         (get_jit_program_space_data): Update.
4791         (jit_program_space_data_cleanup): Remove.
4792         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4793         Update.
4794         (struct jit_program_space_data): Add initializers.
4795
4796 2019-07-10  Tom Tromey  <tromey@adacore.com>
4797
4798         * solib-darwin.c (struct darwin_info): Add initializers.
4799         (solib_darwin_pspace_data): Change type.
4800         (darwin_pspace_data_cleanup): Remove.
4801         (get_darwin_info, _initialize_darwin_solib): Update.
4802
4803 2019-07-10  Tom Tromey  <tromey@adacore.com>
4804
4805         * remote-sim.c (struct sim_inferior_data): Add initializers,
4806         constructor, and destructor.
4807         (sim_inferior_data_key): Change type.  Move lower.
4808         (check_for_duplicate_sim_descriptor): Update.
4809         (get_sim_inferior_data): Use new.  Update.
4810         (~sim_inferior_data_cleanup): Rename from
4811         sim_inferior_data_cleanup.  Simplify.
4812         (gdbsim_close_inferior, simulator_command)
4813         (sim_command_completer, _initialize_remote_sim): Update.
4814         (next_pid, INITIAL_PID): Move earlier.
4815
4816 2019-07-10  Tom Tromey  <tromey@adacore.com>
4817
4818         * python/python-internal.h (create_thread_object): Return
4819         gdbpy_ref.
4820         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4821         * python/py-inferior.c (struct threadlist_entry): Add
4822         constructor.
4823         <thread_obj>: Now a gdbpy_ref.
4824         (thread_to_thread_object): Update.
4825         (add_thread_object): Use new.
4826         (delete_thread_object): Use delete.
4827         (infpy_threads): Update.
4828         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4829         GIL.
4830
4831 2019-07-10  Tom Tromey  <tromey@adacore.com>
4832
4833         * valops.c (value_cast): Specialize error message for Ada.
4834
4835 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4836
4837         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4838
4839 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4840
4841         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4842         bpstat_should_step): Return bool, adjust comments.
4843         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4844         bpstat_should_step): Likewise.
4845
4846 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4847
4848         * features/Makefile: Use feature target descriptions for Arm.
4849         * features/arm/arm-core.c: Generate new file.
4850         * features/arm/arm-fpa.c: Likewise.
4851         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4852         * features/arm/arm-m-profile.c: Likewise.
4853         * features/arm/arm-vfpv2.c: Likewise.
4854         * features/arm/arm-vfpv3.c: Likewise.
4855         * features/arm/xscale-iwmmxt.c: Likewise.
4856         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4857
4858 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4859
4860         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4861         ptrace earlier.
4862
4863 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4864
4865         * features/aarch64-pauth.c: Regenerate.
4866
4867 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4868
4869         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4870         bool.
4871         (bpstat_what): Use false instead of 0.
4872
4873 2019-07-09  Pedro Alves  <palves@redhat.com>
4874
4875         * break-catch-throw.c (is_exception_catchpoint): New.
4876         * breakpoint.c (print_one_breakpoint_location): New parameter
4877         'raw_loc'.  Handle it.  Use
4878         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4879         looking at the breakpoint's type.
4880         (print_one_breakpoint): If handling "maint info breakpoints", also
4881         print locations of exception catchpoints.
4882         * breakpoint.h (is_exception_catchpoint): Declare.
4883
4884 2019-07-09  Pedro Alves  <palves@redhat.com>
4885
4886         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4887         "addr" field.
4888         (allocate_location_exception_catchpoint): New.
4889         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4890         (initialize_throw_catchpoint_ops): Install
4891         allocate_location_exception_catchpoint as allocate_location
4892         method.
4893         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4894         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4895         bp_loc_other.
4896         (breakpoint_address_is_meaningful): Delete.
4897         (bl_address_is_meaningful): New.
4898         (breakpoint_locations_match): Adjust comment.
4899         (bp_location_from_bp_type): New, factored out of...
4900         (bp_location::bp_location(breakpoint *)): ... this.
4901         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4902         factored out of...
4903         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4904         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4905         breakpoint_address_is_meaningful.
4906         (bp_locations_compare): Adjust comment.
4907         (update_global_location_list): Use bl_address_is_meaningful
4908         instead of breakpoint_address_is_meaningful.
4909         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4910         explicit.
4911         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4912         * python/py-breakpoint.c (bppy_get_location): No longer check
4913         whether location is null.
4914
4915 2019-07-09  Pedro Alves  <palves@redhat.com>
4916
4917         PR c++/15468
4918         * breakpoint.c (print_one_breakpoint_location): Remove
4919         single-location assert.
4920
4921 2019-07-09  Tom Tromey  <tom@tromey.com>
4922
4923         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4924         * configure: Rebuild.
4925         * configure.ac: Change common to gdbsupport.
4926         * gdbsupport: Rename from common.
4927         * acinclude.m4: Change common to gdbsupport.
4928         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4929         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4930         gdbsupport.
4931         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4932         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4933         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4934         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4935         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4936         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4937         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4938         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4939         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4940         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4941         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4942         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4943         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4944         coff-pe-read.c, command.h, compile/compile-c-support.c,
4945         compile/compile-c.h, compile/compile-cplus-symbols.c,
4946         compile/compile-cplus-types.c, compile/compile-cplus.h,
4947         compile/compile-loc2c.c, compile/compile.c, completer.c,
4948         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4949         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4950         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4951         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4952         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4953         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4954         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4955         features/aarch64-core.c, features/aarch64-fpu.c,
4956         features/aarch64-pauth.c, features/aarch64-sve.c,
4957         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4958         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4959         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4960         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4961         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4962         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4963         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4964         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4965         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4966         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4967         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4968         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4969         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4970         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4971         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4972         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4973         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4974         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4975         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4976         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4977         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4978         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4979         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4980         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4981         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4982         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4983         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4984         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4985         minsyms.c, mips-linux-tdep.c, namespace.h,
4986         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4987         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4988         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4989         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4990         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4991         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4992         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4993         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4994         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4995         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4996         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4997         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4998         procfs.c, producer.c, progspace.h, psymtab.h,
4999         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5000         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5001         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5002         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5003         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5004         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5005         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5006         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5007         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5008         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5009         target-memory.c, target.c, target.h, target/waitstatus.c,
5010         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5011         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5012         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5013         unittests/array-view-selftests.c,
5014         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5015         unittests/common-utils-selftests.c,
5016         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5017         unittests/format_pieces-selftests.c,
5018         unittests/function-view-selftests.c,
5019         unittests/lookup_name_info-selftests.c,
5020         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5021         unittests/mkdir-recursive-selftests.c,
5022         unittests/observable-selftests.c,
5023         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5024         unittests/parse-connection-spec-selftests.c,
5025         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5026         unittests/scoped_fd-selftests.c,
5027         unittests/scoped_mmap-selftests.c,
5028         unittests/scoped_restore-selftests.c,
5029         unittests/string_view-selftests.c, unittests/style-selftests.c,
5030         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5031         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5032         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5033         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5034         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5035         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5036
5037 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5038
5039         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5040         bool value.
5041         (decode_digits_ordinary): Set explicit_line field in sal.
5042         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5043         symtab_and_line that was set on an explicit line number in
5044         assembler code.  Do always update the recorded symtab and line if
5045         we do skip the prologue.
5046
5047 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * breakpoint.c (set_breakpoint_location_function): Remove
5050         explicit_loc parameter.
5051         (momentary_breakpoint_from_master): Update call to
5052         set_breakpoint_location_function.
5053         (add_location_to_breakpoint): Likewise.
5054
5055 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5058         required features based on default bfd type when no specific bfd
5059         is present.
5060
5061 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5062
5063         * NEWS: Mention that GDB printf and eval commands can now print
5064         C-style and Ada-style convenience var strings without
5065         calling the inferior.
5066         * printcmd.c (printf_c_string): Locally print GDB internal var
5067         instead of transiting via the inferior.
5068         (printf_wide_c_string): Likewise.
5069
5070 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5071
5072         PR breakpoints/25011
5073         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5074
5075 2019-07-04  Tom Tromey  <tom@tromey.com>
5076
5077         PR tui/24724:
5078         * tui/tui-winsource.c (tui_clear_source_content): Update.
5079         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5080         (tui_update_breakpoint_info): Update.
5081         (tui_set_exec_info_content): Update.
5082         * tui/tui-source.c (tui_set_source_content_nil): Update.
5083         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5084         has_break.
5085         * tui/tui-data.h (enum tui_bp_flag): New.
5086         (tui_bp_flags): New enum flags type.
5087         (struct tui_source_element) <break_mode>: Change type.  Rename
5088         from has_break.
5089         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5090         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5091         constants.
5092         * tui/tui-winsource.h: Fix comment.
5093
5094 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5095
5096         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5097         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5098         (store_fpregs_to_thread)
5099         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5100         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5101         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5102         (IWMMXT_REGS_SIZE): Add define.
5103         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5104         (fetch_vfp_regs, store_vfp_regs)
5105         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5106         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5107
5108 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5111         defines.
5112         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5113         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5114         (ARM_INT_REGISTER_SIZE): ...to this.
5115         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5116         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5117         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5118         (arm_linux_collect_gregset, supply_nwfpe_register)
5119         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5120         defines.
5121         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5122         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5123         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5124         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5125         (arm_return_in_memory, arm_store_return_value)
5126         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5127         (arm_record_ld_st_multiple): Likewise.
5128         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5129         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5130
5131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5132
5133         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5134         AARCH64_DISPLACED_MODIFIED_INSNS.
5135         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5136         (aarch64_displaced_step_copy_insn): Likewise.
5137         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5138         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5139         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5140         ARM_DISPLACED_MODIFIED_INSNS.
5141         * arm-tdep.c (arm_gdbarch_init): Likewise.
5142         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5143         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5144         (struct arm_displaced_step_closure): Use
5145         ARM_DISPLACED_MODIFIED_INSNS.
5146
5147 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5148
5149         * features/Makefile: Remove unused xml files.
5150         * features/aarch64.xml: Remove.
5151         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5152         * features/i386/amd64-avx-avx512.xml: Remove.
5153         * features/i386/amd64-avx-linux.xml: Remove.
5154         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5155         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5156         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5157         * features/i386/amd64-avx-mpx.xml: Remove.
5158         * features/i386/amd64-avx.xml: Remove.
5159         * features/i386/amd64-linux.xml: Remove.
5160         * features/i386/amd64-mpx-linux.xml: Remove.
5161         * features/i386/amd64-mpx.xml: Remove.
5162         * features/i386/amd64.xml: Remove.
5163         * features/i386/i386-avx-avx512-linux.xml: Remove.
5164         * features/i386/i386-avx-avx512.xml: Remove.
5165         * features/i386/i386-avx-linux.xml: Remove.
5166         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5167         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5168         * features/i386/i386-avx-mpx-linux.xml: Remove.
5169         * features/i386/i386-avx-mpx.xml: Remove.
5170         * features/i386/i386-avx.xml: Remove.
5171         * features/i386/i386-linux.xml: Remove.
5172         * features/i386/i386-mmx-linux.xml: Remove.
5173         * features/i386/i386-mmx.xml: Remove.
5174         * features/i386/i386-mpx-linux.xml: Remove.
5175         * features/i386/i386-mpx.xml: Remove.
5176         * features/i386/i386.xml: Remove.
5177         * features/i386/x32-avx-avx512-linux.xml: Remove.
5178         * features/i386/x32-avx-linux.xml: Remove.
5179         * features/i386/x32-linux.xml: Remove.
5180
5181 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5182
5183         * regformats/aarch64.dat: Remove.
5184         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5185         * regformats/i386/amd64-avx-linux.dat: Remove.
5186         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5187         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5188         * regformats/i386/amd64-linux.dat: Remove.
5189         * regformats/i386/amd64-mpx-linux.dat: Remove.
5190         * regformats/i386/amd64.dat: Remove.
5191         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5192         * regformats/i386/i386-avx-linux.dat: Remove.
5193         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5194         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5195         * regformats/i386/i386-linux.dat: Remove.
5196         * regformats/i386/i386-mmx-linux.dat: Remove.
5197         * regformats/i386/i386-mpx-linux.dat: Remove.
5198         * regformats/i386/i386.dat: Remove.
5199         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5200         * regformats/i386/x32-avx-linux.dat: Remove.
5201         * regformats/i386/x32-linux.dat: Remove.
5202
5203 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5204
5205         * aarch64-tdep.c: Remove xml self tests.
5206         * amd64-linux-tdep.c: Likewise.
5207         * amd64-tdep.c: Likewise.
5208         * i386-linux-tdep.c: Likewise.
5209         * i386-tdep.c: Likewise.
5210
5211 2019-07-03  Pedro Alves  <palves@redhat.com>
5212
5213         PR cli/24732
5214         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5215         (pipe_cmd_option_defs): New.
5216         (make_pipe_cmd_options_def_group): New.
5217         (pipe_command): Use gdb::option::process_options.
5218         (pipe_command_completer): New function.
5219         (_initialize_cli_cmds): Install completer for "pipe" command.
5220
5221 2019-07-03  Pedro Alves  <palves@redhat.com>
5222
5223         * cli/cli-option.c (union option_value) <string>: New field.
5224         (struct option_def_and_value): Add ctor, move ctor, dtor and
5225         use DISABLE_COPY_AND_ASSIGN.
5226         (option_def_and_value::clear_value): New.
5227         (parse_option, save_option_value_in_ctx, get_val_type_str)
5228         (add_setshow_cmds_for_options): Handle var_string.
5229         * cli-option.h (union option_def::var_address) <string>: New
5230         field.
5231         (struct string_option_def): New.
5232         * maint-test-options.c (struct test_options_opts): Add default
5233         ctor and use DISABLE_COPY_AND_ASSIGN.
5234         <string_opt>: New field.
5235         (test_options_opts::~test_options_opts): New.
5236         (test_options_opts::dump): Also dump "-string".
5237         (test_options_option_defs): Install "string.
5238
5239 2019-07-03  Pedro Alves  <palves@redhat.com>
5240
5241         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5242         option_value with a null enumeration.
5243         (complete_options): Save the option values in the context.
5244         (save_option_value_in_ctx): New, factored out from ...
5245         (process_options): ... here.
5246         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5247         of the function.
5248         * maint-test-options.c (test_options_opts::dump): New, factored
5249         out from ...
5250         (maintenance_test_options_command_mode): ... here.
5251         (maintenance_test_options_command_completion_result): Delete.
5252         (maintenance_test_options_command_completion_text): Update
5253         comment.
5254         (maintenance_show_test_options_completion_result): Change
5255         prototype.  Just print
5256         maintenance_test_options_command_completion_text.
5257         (save_completion_result): New.
5258         (maintenance_test_options_completer_mode): Pass options context to
5259         complete_options, and then save a dump.
5260         (_initialize_maint_test_options): Use add_cmd to install "maint
5261         show test-options-completion-result".
5262
5263 2019-07-03  Pedro Alves  <palves@redhat.com>
5264
5265         * NEWS (New commands): Mention "with" and "maint with".
5266         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5267         (with_command, with_command_completer): New.
5268         (pipe_command): Adjust to new repeat_previous
5269         interface.
5270         (_initialize_cli_cmds): Install the "with" command and its "w"
5271         alias.
5272         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5273         declarations.
5274         * cli/cli-setshow.c (parse_cli_var_uinteger)
5275         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5276         argument strings for all var_types.
5277         (get_setshow_command_value_string): New, factored out from ...
5278         (do_show_command): ... this.
5279         * cli/cli-setshow.h: Include <string>.
5280         (get_setshow_command_value_string): Declare.
5281         * command.h (repeat_previous): Now returns const char *.  Adjust
5282         comment.
5283         * maint.c: Include "cli/cli-cmds.h".
5284         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5285         (_initialize_maint_cmds): Register the "maintenance with" command.
5286         * top.c (repeat_previous): Move bits from pipe_command here:
5287         Return the saved command line, if any; error out if there's no
5288         command to relaunch.
5289
5290 2019-07-03  Pedro Alves  <palves@redhat.com>
5291
5292         * NEWS (New commands): Mention "maint set/show test-settings"
5293         instead of "maint test-settings".
5294         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5295         (maintenance_test_settings_set_list): Rename to ...
5296         (maintenance_set_test_settings_list): ... this.
5297         (maintenance_test_settings_show_list): Rename to  ...
5298         (maintenance_show_test_settings_list): ... this.
5299         (maintenance_test_settings_cmd): Delete.
5300         (maintenance_test_settings_set_cmd): ...
5301         (maintenance_set_test_settings_cmd): ... this.
5302         (maintenance_test_settings_show_cmd): ...
5303         (maintenance_show_test_settings_cmd): ... this.
5304         (maintenance_test_settings_show_value_cmd):
5305         (maintenance_show_test_settings_value_cmd): ... this.
5306         (_initialize_maint_test_settings): No longer install the "maint
5307         test-settings" prefix command.  Rename "maint test-settings set"
5308         to "maint set test-settings", and "maint test-settings show" to
5309         "maint show test-settings".  Adjust all subcommands.
5310
5311 2019-07-03  Pedro Alves  <palves@redhat.com>
5312
5313         * maint-test-settings.c: Fix file's intro comment.  Replace all
5314         references to "test-options" with references to "test-settings",
5315         in comments.
5316
5317 2019-07-03  Pedro Alves  <palves@redhat.com>
5318
5319         * maint-test-settings.c (maintenance_test_settings_xxx)
5320         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5321         New.
5322         (maintenance_test_settings_enums): Use them.
5323         (maintenance_test_settings_enum): Default to
5324         maintenance_test_settings_xxx.
5325         (_initialize_maint_test_settings): Initialize
5326         MAINTENANCE_TEST_SETTINGS_FILENAME.
5327
5328 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5329
5330         * breakpoint.h (remove_breakpoints_inf): Change return type to
5331         void, move function documentation here.
5332         * breakpoint.c (remove_breakpoints_inf): Change return type to
5333         void, move function documentation to header.
5334
5335 2019-07-02  Pedro Alves  <palves@redhat.com>
5336
5337         * NEWS (Completion improvements): Mention "info threads".
5338         * thread.c (struct info_threads_opts, info_threads_option_defs)
5339         (make_info_threads_options_def_group): New.
5340         (info_threads_command): Use gdb::option::process_options.
5341         (info_threads_command_completer): New.
5342         (_initialize_thread): Use gdb::option::build_help to build the
5343         help text for "info threads".
5344
5345 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5346
5347         * defs.h (generic_load): Move from here...
5348         * symfile.h (generic_load): ... to here.  Rename name parameter
5349         to args.
5350         * symfile.c (generic_load): Add comment.
5351
5352 2019-07-01  Tom Tromey  <tromey@adacore.com>
5353
5354         * dwarf2read.c
5355         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5356         declaration of without_params.  Fix formatting.
5357
5358 2019-07-01  Tom Tromey  <tromey@adacore.com>
5359
5360         * ada-exp.y (find_primitive_type): Update.
5361         * ada-lang.h (ada_lookup_symbol): Update.
5362         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5363         parameter.
5364         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5365
5366 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5367
5368         PR breakpoints/24541
5369         * gdbarch.c: Regenerate.
5370         * gdbarch.h: Regenerate.
5371         * gdbarch.sh: Add 'stap_adjust_register'.
5372         * i386-tdep.c: Include '<unordered_set>'.
5373         (i386_stap_adjust_register): New function.
5374         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5375         * stap-probe.c (stap_parse_register_operand): Call
5376         'gdbarch_stap_adjust_register'.
5377
5378 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5379
5380         PR python/24742
5381         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5382         * python/python.c (do_start_initialization): Use 'xmalloc'
5383         instead of 'PyMem_Malloc'.
5384
5385 2019-06-28  Tom Tromey  <tromey@adacore.com>
5386
5387         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5388         for Ada.
5389
5390 2019-06-27  Tom Tromey  <tromey@adacore.com>
5391
5392         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5393         objfile_key.
5394         (arm_find_mapping_symbol, arm_record_special_symbol)
5395         (_initialize_arm_tdep): Update.
5396         (arm_objfile_data_free): Remove.
5397
5398 2019-06-27  Tom Tromey  <tromey@adacore.com>
5399
5400         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5401         to cp_print_static_field.
5402
5403 2019-06-26  Tom Tromey  <tromey@adacore.com>
5404
5405         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5406         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5407         declare.
5408
5409 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5410
5411         * features/aarch64-core.c (create_feature_aarch64_core):
5412         Regenerate.
5413         * features/aarch64-core.xml: Add cpsr flags.
5414
5415 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5416
5417         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5418         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5419
5420 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5421
5422         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5423         field.
5424         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5425         use.
5426         (arm_record_special_symbol): Don't insert new symbol in sorted
5427         position, push it at the end.
5428
5429 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5430
5431         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5432         (arm_mapping_symbol_s): Remove.
5433         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5434         (arm_mapping_symbol_vec): New typedef.
5435         (struct arm_per_objfile): Add constructor.
5436         <section_maps>: Change type to
5437         std::unique_ptr<arm_mapping_symbol_vec[]>.
5438         (arm_compare_mapping_symbols): Remove.
5439         (arm_find_mapping_symbol): Adjust to section_maps type change.
5440         (arm_objfile_data_free): Call delete on arm_per_objfile.
5441         (arm_record_special_symbol): Adjust to section_maps type change.
5442         Allocate arm_per_objfile with new.
5443
5444 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5445
5446         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5447         with the command prefix.
5448
5449 2019-06-25  Tom Tromey  <tom@tromey.com>
5450
5451         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5452         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5453
5454 2019-06-25  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5457         type.
5458         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5459         protected.
5460
5461 2019-06-25  Tom Tromey  <tom@tromey.com>
5462
5463         * tui/tui-winsource.c
5464         (tui_source_window_base::set_is_exec_point_at): Add check against
5465         LOA_ADDRESS.
5466
5467 2019-06-25  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-source.c (tui_set_source_content): Don't check before
5470         xfree.
5471         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5472
5473 2019-06-25  Tom Tromey  <tom@tromey.com>
5474
5475         * tui/tui-winsource.h (tui_update_source_window_as_is)
5476         (tui_alloc_source_buffer, tui_line_is_displayed)
5477         (tui_addr_is_displayed): Change type of win_info.
5478         * tui/tui-winsource.c (tui_update_source_window_as_is)
5479         (tui_clear_source_content, tui_show_source_line)
5480         (tui_show_source_content, tui_source_window_base::refill)
5481         (tui_source_window_base::set_is_exec_point_at)
5482         (tui_source_window_base::set_is_exec_point_at)
5483         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5484         (tui_alloc_source_buffer, tui_line_is_displayed)
5485         (tui_addr_is_displayed): Change type of win_info.  Update.
5486         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5487         (tui_source_window_base::do_make_visible_with_new_height):
5488         Update.
5489         * tui/tui-source.c (tui_set_source_content)
5490         (tui_set_source_content_nil)
5491         (tui_source_window::do_scroll_vertical): Update.
5492         * tui/tui-layout.c (show_layout): Update.
5493         * tui/tui-disasm.c (tui_set_disassem_content)
5494         (tui_disasm_window::do_scroll_vertical): Update.
5495         * tui/tui-data.h (tui_win_content): Remove.
5496         (struct tui_gen_win_info) <content, content_size>: Remove.
5497         (struct tui_source_element): Add initializers and destructor.
5498         (union tui_which_element, struct tui_win_element): Remove.
5499         (struct tui_source_window_base) <content>: New field.
5500         (struct tui_data_window): Remove destructor.
5501         (tui_alloc_content, tui_free_win_content)
5502         (tui_free_all_source_wins_content): Don't declare.
5503         * tui/tui-data.c (tui_initialize_static_data): Update.
5504         (init_content_element, tui_alloc_content): Remove.
5505         (~tui_gen_win_info): Update.
5506         (~tui_data_window, tui_free_all_source_wins_content)
5507         (tui_free_win_content, free_content, free_content_elements):
5508         Remove.
5509
5510 2019-06-25  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-winsource.h (tui_clear_source_content)
5513         (tui_erase_source_content, tui_show_source_content): Change type
5514         of win_info.
5515         * tui/tui-winsource.c (tui_clear_source_content)
5516         (tui_erase_source_content, tui_show_source_content): Change type
5517         of win_info.
5518         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5519         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5520         win_info.
5521         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5522         win_info.
5523         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5524
5525 2019-06-25  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-winsource.c (tui_clear_source_content)
5528         (tui_source_window_base::set_is_exec_point_at): Update.
5529         * tui/tui-source.c (tui_set_source_content_nil): Update.
5530         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5531         a bool.
5532         * tui/tui-data.c (init_content_element): Update.
5533
5534 2019-06-25  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5537         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5538         * tui/tui-layout.c (init_and_make_win): Update.
5539         * tui/tui.h (enum tui_win_type): Update.
5540         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5541         tui_win_is_auxillary.
5542         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5543         tui_win_is_auxillary.
5544
5545 2019-06-25  Tom Tromey  <tom@tromey.com>
5546
5547         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5548         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5549         (tui_delete_data_content_windows, tui_display_all_data)
5550         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5551         Update.
5552         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5553         * tui/tui-regs.c (tui_last_regs_line_no)
5554         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5555         (tui_show_registers): Update.
5556         (tui_show_register_group): Return void.  Update.
5557         (tui_display_registers_from, tui_display_reg_element_at_line)
5558         (tui_display_registers_from_line, tui_check_register_values):
5559         Update.
5560         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5561         member.
5562         (struct tui_data_window) <regs_content>: Now a std::vector.
5563         <regs_content_count>: Remove.
5564         (tui_add_content_elements, tui_free_data_content): Don't declare.
5565         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5566         (init_content_element): Remove DATA_WIN case.  Add assert.
5567         (tui_add_content_elements): Remove.
5568         (tui_data_window): Update.
5569         (tui_free_data_content): Remove.
5570         (free_content_elements): Remove DATA_WIN case.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-data.c (tui_data_item_window): Update.
5575         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5576         * tui/tui-windata.c (tui_display_all_data)
5577         (tui_display_data_from_line): Update.
5578         (tui_check_data_values): Remove.
5579         * tui/tui-regs.c (tui_show_register_group)
5580         (tui_display_reg_element_at_line): Update.
5581         * tui/tui-hooks.c (tui_register_changed)
5582         (tui_refresh_frame_and_register_information): Call
5583         tui_check_register_values.
5584         * tui/tui-data.h (struct tui_data_window) <data_content,
5585         data_content_count, data_type>: Remove.
5586         (enum tui_data_type): Remove.
5587
5588         * tui/tui-data.c (tui_data_window::clear_detail)
5589         (~tui_data_window): Update.
5590
5591 2019-06-25  Tom Tromey  <tom@tromey.com>
5592
5593         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5594         declare.
5595         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5596         Rename from tui_first_data_item_displayed.  Update.
5597         (tui_data_window::refresh_all)
5598         (tui_data_window::do_scroll_vertical): Update.
5599         * tui/tui-data.h (struct tui_data_window)
5600         <first_data_item_displayed>: Declare new method.
5601
5602 2019-06-25  Tom Tromey  <tom@tromey.com>
5603
5604         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5605         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5606         contents...
5607         (tui_initialize_static_data): ...here.
5608
5609 2019-06-25  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5612         (tui_display_registers_from, tui_check_register_values): Update.
5613         (tui_display_register): Remove win_info parameter; update.
5614         (tui_get_register): Change type of parameters.
5615         * tui/tui-data.h (struct tui_data_element): Remove.
5616         (union tui_which_element) <data>: Remove.
5617         <data_window>: Change type.
5618         (struct tui_data_item_window): New.
5619         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5620         case.  Add assert.
5621         (~tui_data_item_window): New destructor.
5622         (free_content_elements): Remove DATA_ITEM_WIN case.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5627         Remove.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-data.h (struct tui_command_element): Remove.
5632         (union tui_which_element) <command>: Remove.
5633         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5634         assert.
5635         (free_content_elements): Remove CMD_WIN case.
5636
5637 2019-06-25  Tom Tromey  <tom@tromey.com>
5638
5639         * tui/tui-layout.c (tui_set_layout): Update.
5640         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5641         * tui/tui-data.c (layout_def): Update.
5642
5643 2019-06-25  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5646         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5647         (tui_source_window_base::set_new_height): Update.
5648         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5649         Update.
5650         (tui_set_locator_fullname, tui_set_locator_info)
5651         (tui_show_frame_info): Update.
5652         * tui/tui-source.c (tui_set_source_content)
5653         (tui_source_is_displayed): Update.
5654         * tui/tui-layout.c (show_source_disasm_command, show_data)
5655         (show_source_or_disasm_and_command): Update.
5656         * tui/tui-disasm.c (tui_set_disassem_content)
5657         (tui_get_begin_asm_address): Update.
5658         * tui/tui-data.h (struct tui_locator_element): Remove.
5659         (union tui_which_element) <locator>: Remove.
5660         (struct tui_locator_window): New.
5661         (tui_locator_win_info_ptr): Change return type.
5662         * tui/tui-data.c (_locator): Change type.
5663         (tui_locator_win_info_ptr): Change return type.
5664         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5665         (tui_alloc_content): Add assert.
5666
5667 2019-06-25  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-winsource.c
5670         (tui_exec_info_window::maybe_allocate_content): New method.
5671         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5672         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5673         (make_source_or_disasm_window): Add cast.
5674         * tui/tui-data.h (union tui_which_element) <simple_string>:
5675         Remove.
5676         (struct tui_source_info): New.
5677         (struct tui_source_window_base) <execution_info>: Change type.
5678         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5679         case, and add assert.
5680         (tui_alloc_content): Add assert.
5681
5682 2019-06-25  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5685         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5686         * tui/tui-data.c (tui_alloc_win_info): Remove.
5687
5688 2019-06-25  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5691         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5692         can_highlight.
5693
5694 2019-06-25  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5697         make_visible_with_new_height method.
5698         (tui_win_info::make_visible_with_new_height): New method.
5699         (tui_source_window_base::do_make_visible_with_new_height)
5700         (tui_data_window::do_make_visible_with_new_height)
5701         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5702         (make_visible_with_new_height): Remove.
5703         (tui_resize_all, tui_adjust_win_heights): Use
5704         make_visible_with_new_height method.
5705         * tui/tui-data.h (struct tui_win_info)
5706         <do_make_visible_with_new_height, make_visible_with_new_height>:
5707         New methods.
5708         (struct tui_source_window_base, struct tui_data_window)
5709         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5710         methods.
5711
5712 2019-06-25  Tom Tromey  <tom@tromey.com>
5713
5714         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5715         method.
5716         (update_tab_width): Call update_tab_width method.
5717         * tui/tui-data.h (struct tui_win_info)
5718         (struct tui_source_window_base) <update_tab_width>: New methods.
5719
5720 2019-06-25  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5723         parameter.
5724         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5725         parameter.
5726         (tui_gen_win_info::make_visible): Update.
5727         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5728         parameter.
5729         * tui/tui-data.h (enum tui_box): New enum.
5730         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5731
5732 2019-06-25  Tom Tromey  <tom@tromey.com>
5733
5734         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5735         init_and_make_win for EXEC_INFO_WIN.
5736         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5737         longer inline.
5738         (struct tui_win_info) <~tui_win_info>: Inline.
5739         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5740         Don't declare.
5741         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5742         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5743         Remove.
5744         (tui_initialize_static_data): Update.
5745         (~tui_gen_win_info): Handle more cleanup here.
5746         (~tui_source_window_base): Delete "execution_info".
5747         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5748
5749 2019-06-25  Tom Tromey  <tom@tromey.com>
5750
5751         * tui/tui-layout.c (make_command_window): Don't set
5752         can_highlight.
5753         (show_source_disasm_command): Call the reset method.
5754         (show_data): Don't set can_highlight.  Call the reset method.
5755         (tui_gen_win_info::reset): Rename from init_gen_win_info
5756         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5757         (show_source_or_disasm_and_command): Call the reset method.
5758         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5759         (struct tui_cmd_window): Set can_highlight.
5760
5761 2019-06-25  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5764         from make_visible.
5765         (tui_make_visible, tui_make_invisible): Rewrite.
5766         (tui_win_info::make_visible): Remove.
5767         (tui_source_window_base::make_visible): Update.
5768         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5769         method.  Moved from...
5770         (struct tui_win_info) <make_visible>: ...here.
5771
5772 2019-06-25  Tom Tromey  <tom@tromey.com>
5773
5774         * tui/tui-winsource.c
5775         (tui_source_window_base::do_scroll_horizontal): Remove direction
5776         parameter.
5777         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5778         direction parameter.
5779         * tui/tui-win.c (tui_win_info::forward_scroll)
5780         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5781         (tui_win_info::right_scroll): Update.
5782         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5783         direction parameter.
5784         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5785         direction parameter.
5786         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5787         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5788         Remove direction parameter.
5789         (struct tui_source_window_base, struct tui_source_window)
5790         (struct tui_disasm_window, struct tui_data_window)
5791         (struct tui_cmd_window): Update.
5792
5793 2019-06-25  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-winsource.h (tui_set_exec_info_content)
5796         (tui_show_exec_info_content, tui_erase_exec_info_content)
5797         (tui_clear_exec_info_content, tui_update_exec_info): Change
5798         argument to tui_source_window_base.
5799         * tui/tui-winsource.c (tui_set_exec_info_content)
5800         (tui_show_exec_info_content, tui_erase_exec_info_content)
5801         (tui_clear_exec_info_content, tui_update_exec_info): Change
5802         argument to tui_source_window_base.
5803
5804 2019-06-25  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5807         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5808
5809 2019-06-25  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5812         check.
5813
5814 2019-06-25  Tom Tromey  <tom@tromey.com>
5815
5816         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5817         type to void.
5818         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5819         type to void.
5820         * tui/tui-source.c (tui_set_source_content): Update.
5821         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5822
5823 2019-06-25  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-win.c (window_name_completer, tui_set_focus)
5826         (tui_all_windows_info): Use name method.
5827         * tui/tui-data.h (struct tui_gen_win_info)
5828         (struct tui_source_window, struct tui_disasm_window)
5829         (struct tui_data_window, struct tui_cmd_window) <name>: New
5830         method.
5831         (tui_win_name): Don't declare.
5832         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5833         (tui_win_name): Remove.
5834
5835 2019-06-25  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-winsource.h (tui_update_source_window)
5838         (tui_update_source_window_as_is): Change parameter type.
5839         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5840         to be a tui_source_window_base.
5841         (tui_update_source_window_as_is): Likewise.
5842         * tui/tui-win.c (make_visible_with_new_height): Update.
5843
5844 2019-06-25  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-winsource.c (tui_erase_source_content)
5847         (tui_show_source_content, tui_show_exec_info_content)
5848         (tui_erase_exec_info_content): Use refresh_window method.
5849         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5850         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5851         from tui_refresh_win.
5852         (tui_data_window::refresh_window): New method.
5853         (tui_win_info::refresh, tui_source_window_base::refresh)
5854         (tui_refresh_all): Use refresh_window method.
5855         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5856         method.
5857         * tui/tui-regs.c (tui_display_register): Call refresh_window
5858         method.
5859         * tui/tui-layout.c (show_source_disasm_command)
5860         (show_source_or_disasm_and_command): Call refresh_window method.
5861         * tui/tui-data.h (struct tui_gen_win_info)
5862         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5863         New method.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui.c (tui_rl_other_window, tui_enable)
5868         (tui_is_window_visible, tui_get_command_dimension): Update.
5869         * tui/tui-winsource.c (tui_update_source_window_as_is)
5870         (tui_clear_source_content, tui_erase_source_content)
5871         (tui_show_source_line, tui_source_window_base::refill)
5872         (tui_source_window_base::do_scroll_horizontal)
5873         (tui_source_window_base::set_is_exec_point_at)
5874         (tui_update_breakpoint_info, tui_set_exec_info_content)
5875         (tui_alloc_source_buffer, tui_line_is_displayed)
5876         (tui_addr_is_displayed): Update.
5877         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5878         (tui_check_and_display_highlight_if_needed)
5879         (tui_win_info::make_visible, tui_win_info::refresh)
5880         (tui_refresh_all): Update.
5881         * tui/tui-windata.c (tui_first_data_item_displayed)
5882         (tui_delete_data_content_windows, tui_erase_data_content)
5883         (tui_display_all_data, tui_data_window::refresh_all)
5884         (tui_check_data_values): Update.
5885         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5886         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5887         (tui_win_info::backward_scroll, tui_refresh_all_win)
5888         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5889         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5890         (tui_source_window_base::set_new_height)
5891         (tui_data_window::set_new_height)
5892         (make_invisible_and_set_new_height)
5893         (make_visible_with_new_height, new_height_ok)
5894         (parse_scrolling_args): Update.
5895         * tui/tui-stack.c (tui_show_frame_info): Update.
5896         * tui/tui-source.c (tui_set_source_content)
5897         (tui_set_source_content_nil, tui_source_is_displayed)
5898         (tui_source_window::do_scroll_vertical): Update.
5899         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5900         (tui_display_registers_from, tui_display_reg_element_at_line)
5901         (tui_check_register_values, tui_reg_command): Update.
5902         * tui/tui-layout.c (tui_default_win_height)
5903         (show_source_disasm_command, show_data, init_and_make_win)
5904         (show_source_or_disasm_and_command): Update.
5905         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5906         (tui_redisplay_readline, tui_mld_flush)
5907         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5908         (tui_getc): Update.
5909         * tui/tui-disasm.c (tui_set_disassem_content)
5910         (tui_disasm_window::do_scroll_vertical): Update.
5911         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5912         Now virtual.
5913         (struct tui_win_info): Derive from tui_gen_win_info.
5914         <~tui_win_info>: Mark as override.
5915         <generic>: Remove member.
5916         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5917         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5918         (~tui_data_window, ~tui_win_info)
5919         (tui_free_all_source_wins_content): Update.
5920         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5921
5922 2019-06-25  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-layout.c (init_and_make_win): Use new.
5925         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5926         destructor, initializers.
5927         (tui_alloc_generic_win_info): Don't declare.
5928         * tui/tui-data.c (_locator): Add argument to constructor.
5929         (source_win, disasm_win): New globals.
5930         (exec_info): Remove.
5931         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5932         Update.
5933         (tui_alloc_generic_win_info): Remove.
5934         (init_content_element): Use new.
5935         (tui_win_info::tui_win_info): Update.
5936         (free_content_elements) <case DATA_WIN>: Use delete.
5937
5938 2019-06-25  Tom Tromey  <tom@tromey.com>
5939
5940         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5941         * tui/tui-windata.c (tui_first_data_item_displayed)
5942         (tui_delete_data_content_windows): Update.
5943         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5944         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5945         (tui_display_registers_from, tui_check_register_values): Update.
5946         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5947         pointer.
5948         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5949         window.
5950         (tui_free_data_content): Update.
5951         (free_content_elements) <case DATA_WIN>: Free the window.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5956         Update.
5957         * tui/tui-layout.c (make_command_window)
5958         (show_source_disasm_command, show_data, init_and_make_win)
5959         (show_source_or_disasm_and_command): Update.
5960         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5961         method.
5962         <can_highight, is_highlighted>: Now bool.
5963         (tui_set_win_highlight): Don't declare.
5964         * tui/tui-data.c (tui_set_win_highlight): Remove.
5965
5966 2019-06-25  Tom Tromey  <tom@tromey.com>
5967
5968         * tui/tui-wingeneral.c (make_visible): Remove check of window
5969         type.
5970
5971 2019-06-25  Tom Tromey  <tom@tromey.com>
5972
5973         * tui/tui-win.c (tui_win_info::max_height)
5974         (tui_cmd_window::max_height): New methods.
5975         (new_height_ok): Call max_height.
5976         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5977         <max_height>: New method.
5978
5979 2019-06-25  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-win.c (tui_source_window_base::set_new_height)
5982         (tui_data_window::set_new_height): New methods.
5983         (make_invisible_and_set_new_height): Call set_new_height method.
5984         * tui/tui-data.h (struct tui_win_info)
5985         (struct tui_source_window_base, struct tui_data_window)
5986         <set_new_height>: New method.
5987
5988 2019-06-25  Tom Tromey  <tom@tromey.com>
5989
5990         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5991         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5992         tui_refresh_data_win.
5993         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5994         method.
5995         (tui_refresh_all_win): Call the refresh_all method.
5996         (tui_set_focus): Likewise.
5997         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5998         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5999         Likewise.
6000
6001 2019-06-25  Tom Tromey  <tom@tromey.com>
6002
6003         * tui/tui-winsource.h (tui_refill_source_window)
6004         (tui_set_is_exec_point_at): Don't declare.
6005         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6006         (tui_source_window_base::refill): Rename from
6007         tui_refill_source_window.
6008         (tui_source_window_base::do_scroll_horizontal): Update.
6009         (tui_source_window_base::set_is_exec_point_at): Rename from
6010         tui_set_is_exec_point_at.
6011         (tui_update_all_breakpoint_info): Update.
6012         * tui/tui-stack.c (tui_show_frame_info): Update.
6013         * tui/tui-layout.c (show_data): Add cast.
6014         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6015         * tui/tui-data.h (struct tui_source_window_base) <refill,
6016         set_is_exec_point_at>: New methods.
6017         (tui_source_windows, tui_add_to_source_windows): Update types.
6018         (tui_add_to_source_windows): Remove redundant declaration.
6019         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6020         (tui_source_windows): Change return type.
6021         (tui_clear_source_windows_detail): Update.
6022         (tui_add_to_source_windows): Change type of parameter.
6023         (tui_free_all_source_wins_content): Update.
6024
6025 2019-06-25  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-wingeneral.c (tui_win_info::refresh)
6028         (tui_source_window_base::refresh): New methods.
6029         (tui_refresh_all): Call the refresh method.
6030         * tui/tui-data.h (struct tui_win_info)
6031         (struct tui_source_window_base) <refresh>: New method.
6032
6033 2019-06-25  Tom Tromey  <tom@tromey.com>
6034
6035         * tui/tui.h (tui_is_window_visible): Return bool.
6036         * tui/tui.c (tui_is_window_visible): Return bool.
6037         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6038         (tui_make_visible, tui_make_invisible)
6039         (tui_win_info::make_visible)
6040         (tui_source_window_base::make_visible, make_all_visible)
6041         (tui_make_all_visible, tui_make_all_invisible): Update.
6042         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6043         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6044         bool.
6045         (struct tui_win_info, struct tui_source_window_base)
6046         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6047         * tui/tui-data.c (tui_init_generic_part): Update.
6048
6049 2019-06-25  Tom Tromey  <tom@tromey.com>
6050
6051         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6052         (tui_source_window_base::make_visible): New methods.
6053         (make_all_visible): Make method call.
6054         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6055         (struct tui_source_window_base, struct tui_cmd_window): Override
6056         make_visible.
6057         (tui_win_is_source_type): Don't declare.
6058         * tui/tui-data.c (tui_win_is_source_type): Remove.
6059
6060 2019-06-25  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6063         NULL check.
6064
6065 2019-06-25  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6068         Inline constructor.  Add initializers for members.
6069         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6070         constructors; now inline in class.
6071
6072 2019-06-25  Tom Tromey  <tom@tromey.com>
6073
6074         * tui/tui-regs.c (tui_show_registers): Update.
6075         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6076         bool.
6077         * tui/tui-data.c (tui_data_window::clear_detail)
6078         (tui_data_window): Update.
6079
6080 2019-06-25  Tom Tromey  <tom@tromey.com>
6081
6082         * tui/tui-windata.c (tui_display_all_data)
6083         (tui_display_data_from_line, tui_display_data_from)
6084         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6085         Update.
6086         * tui/tui-regs.c (tui_last_regs_line_no)
6087         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6088         (tui_show_registers, tui_show_register_group)
6089         (tui_display_registers_from, tui_display_reg_element_at_line)
6090         (tui_display_registers_from_line, tui_check_register_values)
6091         (tui_reg_next, tui_reg_prev): Update.
6092         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6093         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6094         tui_data_window.
6095         (struct tui_win_info) <detail>: Remove.  Add new fields from
6096         tui_data_info.
6097         (TUI_DATA_WIN): Add cast.
6098         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6099         (~tui_data_window): Simplify.
6100
6101 2019-06-25  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-layout.c (show_source_disasm_command)
6104         (show_source_or_disasm_and_command): Update.
6105         * tui/tui-io.c (update_cmdwin_start_line)
6106         (tui_redisplay_readline): Update.
6107         * tui/tui-data.h (struct tui_command_info): Remove.
6108         (struct tui_win_info) <detail>: Remove command_info member.
6109         (struct tui_data_window) <start_line>: New member, from
6110         tui_command_info.
6111         (TUI_CMD_WIN): Add casts.
6112
6113 2019-06-25  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui-winsource.c (tui_update_source_window)
6116         (tui_refill_source_window)
6117         (tui_source_window_base::do_scroll_horizontal)
6118         (tui_update_breakpoint_info, tui_set_exec_info_content)
6119         (tui_show_exec_info_content, tui_erase_exec_info_content)
6120         (tui_clear_exec_info_content): Update.
6121         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6122         Update.
6123         * tui/tui-win.c (make_invisible_and_set_new_height)
6124         (make_visible_with_new_height): Update.
6125         * tui/tui-source.c (tui_set_source_content)
6126         (tui_show_symtab_source): Update.
6127         * tui/tui-layout.c (extract_display_start_addr)
6128         (show_source_disasm_command, show_data)
6129         (make_source_or_disasm_window)
6130         (show_source_or_disasm_and_command): Update.
6131         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6132         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6133         "gdbarch".
6134         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6135         to tui_source_window_base.
6136         (struct tui_win_info) <detail>: Remove source_info member.
6137         (struct tui_source_window_base) <has_locator>: Inline.
6138         Move contents from tui_source_info; rename has_locator member to
6139         m_has_locator.
6140         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6141         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6142         header file.
6143         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6144         Simplify.
6145         (tui_free_all_source_wins_content): Cast to
6146         tui_source_window_base.
6147
6148 2019-06-25  Tom Tromey  <tom@tromey.com>
6149
6150         * tui/tui-win.c (make_invisible_and_set_new_height)
6151         (make_visible_with_new_height): Call has_locator method.
6152         * tui/tui-layout.c (show_source_disasm_command, show_data)
6153         (show_source_or_disasm_and_command): Update for bool change.
6154         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6155         (tui_win_info) <has_locator>: New method.
6156         (struct tui_source_window_base) <has_locator>: New method.
6157         (tui_win_has_locator): Don't declare.
6158         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6159         from tui_win_has_locator.
6160         (tui_source_window_base): Use false, not FALSE.
6161
6162 2019-06-25  Tom Tromey  <tom@tromey.com>
6163
6164         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6165         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6166         clear_detail method directly.
6167         (tui_clear_win_detail): Remove.
6168
6169 2019-06-25  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6172         "this", not TUI_DISASM_WIN.
6173
6174 2019-06-25  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6177         declare.
6178         * tui/tui-winsource.c
6179         (tui_source_window_base::do_scroll_horizontal): Rename from
6180         tui_horizontal_source_scroll.
6181         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6182         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6183         from tui_vertical_data_scroll.
6184         * tui/tui-win.h (tui_scroll): Don't declare.
6185         * tui/tui-win.c (tui_win_info::forward_scroll)
6186         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6187         (tui_win_info::right_scroll): Rename and update.
6188         (tui_scroll_forward_command, tui_scroll_backward_command)
6189         (tui_scroll_left_command, tui_scroll_right_command): Update.
6190         (tui_scroll): Remove.
6191         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6192         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6193         from tui_vertical_source_scroll.
6194         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6195         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6196         from tui_vertical_disassem_scroll.
6197         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6198         do_scroll_horizontal>: New methods.
6199         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6200         Likewise.
6201         (struct tui_source_window_base): Add do_scroll_horizontal.
6202         (struct tui_source_window, struct tui_disasm_window): Add
6203         do_scroll_vertical.
6204         (struct tui_data_window, struct tui_cmd_window): Add
6205         do_scroll_horizontal and do_scroll_vertical.
6206         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6207
6208 2019-06-25  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui-data.h (struct tui_source_window_base): New struct.
6211         (struct tui_source_window): Derive from tui_source_window_base.
6212         (struct tui_disasm_window): New struct.
6213         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6214         from tui_source_window::clear_detail.
6215         (tui_source_window_base): Rename from tui_source_window.
6216         (~tui_source_window_base): Rename from ~tui_source_window.
6217         (tui_alloc_win_info): Create a tui_disasm_window.
6218
6219 2019-06-25  Tom Tromey  <tom@tromey.com>
6220
6221         * tui/tui-data.h (struct tui_source_window)
6222         (struct tui_data_window): Declare destructors.
6223         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6224         destructors.
6225         (tui_win_info): Simplify.
6226
6227 2019-06-25  Tom Tromey  <tom@tromey.com>
6228
6229         * tui/tui-winsource.c (tui_display_main)
6230         (tui_update_source_windows_with_addr)
6231         (tui_update_all_breakpoint_info): Update.
6232         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6233         (new_height_ok, parse_scrolling_args): Update.
6234         * tui/tui-stack.c (tui_show_frame_info): Update.
6235         * tui/tui-data.h (struct tui_list): Remove.
6236         (tui_source_windows): Return a reference to a std::vector.
6237         * tui/tui-data.c (source_windows): Now a std::vector.
6238         (tui_source_windows): Change return type.
6239         (tui_clear_source_windows): Rewrite.
6240         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6241         (tui_free_all_source_wins_content): Rewrite.
6242
6243 2019-06-25  Tom Tromey  <tom@tromey.com>
6244
6245         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6246         (struct tui_data_window, struct tui_cmd_window): Declare
6247         clear_detail method.
6248         * tui/tui-data.c (tui_source_window::clear_detail)
6249         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6250         methods.
6251         (tui_clear_win_detail): Simplify.
6252
6253 2019-06-25  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui-layout.c (make_source_window, make_disasm_window)
6256         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6257         Return the new window.
6258         (show_source_disasm_command, show_data)
6259         (show_source_or_disasm_and_command): Update.
6260
6261 2019-06-25  Tom Tromey  <tom@tromey.com>
6262
6263         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6264         parameter.  Return the new window.
6265         (show_source_disasm_command): Update and remove NULL check.
6266         (show_source_or_disasm_and_command): Update.
6267
6268 2019-06-25  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6271
6272 2019-06-25  Tom Tromey  <tom@tromey.com>
6273
6274         * tui/tui-data.h (struct tui_win_info): Make constructor
6275         protected.  Make destructor virtual.  Add initializers.
6276         (tui_source_window, tui_data_window, tui_cmd_window): New
6277         classes.
6278         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6279         constructor.  Add "type" parameter.
6280         (tui_source_window, tui_data_window, tui_cmd_window): New
6281         constructors.
6282         (tui_alloc_win_info): Instantiate the appropriate subclass.
6283
6284 2019-06-25  Tom Tromey  <tom@tromey.com>
6285
6286         * tui/tui-win.c (tui_resize_all): Use delete.
6287         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6288         destructor.
6289         (tui_free_window): Don't declare.
6290         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6291         Update.
6292
6293 2019-06-25  Tom Tromey  <tom@tromey.com>
6294
6295         * tui/tui-data.h (struct tui_win_info): Add constructor.
6296         * tui/tui-data.c (tui_alloc_win_info): Use new.
6297         (tui_free_window): Use delete.
6298
6299 2019-06-22  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6302         declare.
6303         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6304
6305 2019-06-22  Tom Tromey  <tom@tromey.com>
6306
6307         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6308         declare.
6309         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6310
6311 2019-06-22  Tom de Vries  <tdevries@suse.de>
6312
6313         * dwarf2read.c (create_addrmap_from_aranges)
6314         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6315         instead of '%zu'.
6316
6317 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6318
6319         * dwarf2read.h (dwarf2_section_info_def): Remove.
6320         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6321         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6322         std::vector<dwarf2_section_info>.
6323         (struct dwo_file) <~dwo_file>: Remove.
6324         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6325         types field.
6326         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6327         (dwarf2_read_debug_names): Likewise.
6328         (create_debug_types_hash_table): Change parameter type to
6329         array_view, adjust code accordingly.
6330         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6331         (partial_die_info::fixup): Likewise.
6332         (determine_prefix): Likewise.
6333         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6334
6335 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6336
6337         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6338         gdb_bfd_ref_ptr.
6339         <~dwo_file>: Remove call to gdb_bfd_unref.
6340         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6341         gdb_bfd_ref_ptr::get.
6342
6343 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6344
6345         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6346         type to htab_up.
6347         * dwarf2read.c (struct dwo_file): Initialize fields.
6348         <~dwo_file>: New.
6349         (free_dwo_file): Remove, move content to ~dwo_file.
6350         (struct dwo_file_deleter): Remove.
6351         (dwo_file_up>: Remove custom deleter.
6352         (free_dwo_files): Remove.
6353         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6354         dwo_files.
6355         (process_skeletonless_type_units): Call unique_ptr::get.
6356         (allocate_dwo_file_hash_table): Add deleter to created hash
6357         table.  Change return type to htab_up.
6358         (lookup_dwo_file_slot): Don't memset dwo_file, call
6359         unique_ptr::get.
6360         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6361         (create_dwo_unit_in_dwp_v2): Likewise.
6362         (open_and_init_dwo_file): Likewise.
6363         (free_dwo_file_from_slot): Remove.
6364
6365 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6366
6367         * dwarf2read.h (struct dwarf2_section_info) <readin,
6368         is_virtual>: Change type to bool.
6369         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6370         true instead of 1.
6371
6372 2019-06-19  Tom Tromey  <tom@tromey.com>
6373
6374         * tui/tui-data.h (tui_init_content_element): Don't declare.
6375
6376 2019-06-19  Tom Tromey  <tom@tromey.com>
6377
6378         * tui/tui-data.h (tui_init_win_info): Don't declare.
6379
6380 2019-06-19  Tom de Vries  <tdevries@suse.de>
6381
6382         * dwarf2read.h (abstract_to_concrete): Change type to
6383         std::unordered_map<sect_offset, std::vector<sect_offset>,
6384         gdb::hash_enum<sect_offset>>.
6385
6386 2019-06-19  Tom Tromey  <tromey@adacore.com>
6387
6388         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6389         EVAL_AVOID_SIDE_EFFECTS specially.
6390
6391 2019-06-19  Tom Tromey  <tromey@adacore.com>
6392
6393         * source-cache.c (highlighter): New global.
6394         (source_cache::get_source_lines): Create a highlighter on demand.
6395
6396 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * defs.h (deprecated_interactive_hook): Delete declaration.
6399         * interps.c (clear_interpreter_hooks): Remove use of
6400         deprecated_interactive_hook.
6401         * top.c (deprecated_interactive_hook): Delete definition.
6402         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6403
6404 2019-06-18  Tom de Vries  <tdevries@suse.de>
6405
6406         PR gdb/24515
6407         * dwarf2read.h (abstract_to_concrete): Change type from
6408         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6409         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6410         * dwarf2read.c (read_variable): Update.
6411         (dwarf2_fetch_die_loc_sect_off): Update.
6412
6413 2019-06-17  Tom de Vries  <tdevries@suse.de>
6414
6415         PR gdb/24617
6416         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6417         accessing parent[parent_len - 1].
6418
6419 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6420
6421         PR gdb/24364
6422         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6423         call dtrace_process_dof with NULL dof.
6424
6425 2019-06-16  Tom de Vries  <tdevries@suse.de>
6426
6427         PR gdb/24445
6428         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6429
6430 2019-06-16  Tom Tromey  <tom@tromey.com>
6431
6432         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6433         (make_all_visible): Use address of member.
6434
6435 2019-06-16  Tom Tromey  <tom@tromey.com>
6436
6437         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6438         (tui_free_window, free_content, free_content_elements): Remove
6439         unnecessary cast.
6440         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6441         cast.
6442         * tui/tui-regs.c (tui_show_register_group)
6443         (tui_display_registers_from, tui_display_reg_element_at_line):
6444         Remove unnecessary cast.
6445
6446 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * linux-nat.c (normal_mask): Delete.
6449         (_initialize_linux_nat): Don't initialise normal_mask.
6450
6451 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6452
6453         PR gdb/24445
6454         * dwarf-index-write.h (write_psymtabs_to_index): Add
6455         dwz_basename parameter.
6456         * dwarf-index-write.c (write_gdbindex): Move file writing to
6457         write_gdbindex_1.  Change return type void.
6458         (assert_file_size): Move up, remove filename parameter.
6459         (write_gdbindex_1): New function.
6460         (write_debug_names): Change return type to void, call
6461         assert_file_size.
6462         (struct index_wip_file): New struct.
6463         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6464         file logic to index_wip_file.  Write index for dwz file if
6465         needed.
6466         (save_gdb_index_command): Pass basename of dwz file, if present.
6467         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6468         build-id of dwz file, if present.
6469         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6470         (dwarf2_get_dwz_file): Likewise.
6471         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6472         (dwarf2_get_dwz_file): Likewise.
6473
6474 2019-06-16  Tom Tromey  <tom@tromey.com>
6475
6476         * coffread.c (process_coff_symbol): Use xstrdup.
6477         * value.c (create_internalvar): Use xstrdup.
6478
6479 2019-06-16  Tom Tromey  <tom@tromey.com>
6480
6481         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6482         * breakpoint.c (stopin_command, stopat_command)
6483         (until_break_command, decode_location_default): Remove unnecessary
6484         cast.
6485         * utils.c (subset_compare): Remove unnecessary cast.
6486         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6487         cast.
6488         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6489         cast.
6490         * infcmd.c (path_command): Remove unnecessary cast.
6491         * coffread.c (decode_type): Remove unnecessary cast.
6492         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6493         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6494         * tui/tui-stack.c (tui_show_locator_content)
6495         (tui_show_frame_info): Remove unnecessary cast.
6496         * tui/tui-win.c (tui_scroll_forward_command)
6497         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6498         (parse_scrolling_args): Remove unnecessary cast.
6499         * tui/tui-data.c (init_win_info, tui_del_window)
6500         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6501         (free_content_elements): Remove unnecessary cast.
6502         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6503         unnecessary cast.
6504         * tui/tui-source.c (tui_set_source_content)
6505         (tui_vertical_source_scroll): Remove unnecessary cast.
6506         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6507         cast.
6508         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6509         * tui/tui-regs.c (tui_display_registers_from)
6510         (tui_display_register): Remove unnecessary cast.
6511         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6512         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6513         (make_visible): Remove unnecessary cast.
6514         * tui/tui-winsource.c (tui_erase_source_content)
6515         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6516         unnecessary cast.
6517         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6518         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6519         * stabsread.c (read_type, read_array_type, read_range_type):
6520         Remove unnecessary cast.
6521         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6522         (parse_symbol, parse_type, upgrade_type, parse_external)
6523         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6524         unnecessary cast.
6525         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6526
6527 2019-06-16  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-data.c (tui_alloc_generic_win_info)
6530         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6531         checks.
6532
6533 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6534             Andrew Burgess  <andrew.burgess@embecosm.com>
6535
6536         * f-typeprint.c (f_print_type): Don't return early for not
6537         associated or not allocated types.
6538         (f_type_print_varspec_suffix): Add print_rank parameter and print
6539         ranks of array types in case they dangling.
6540         (f_type_print_base): Add print_rank parameter.
6541
6542 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * NEWS: Mention new MI commands.
6545         * break-catch-throw.c (enum exception_event_kind): Move to
6546         breakpoint.h.
6547         (print_mention_exception_catchpoint): Output text as a single
6548         message.
6549         (catch_exception_command_1): Rename to...
6550         (catch_exception_event): ...this, make non-static, update header
6551         command, and change some parameter types.
6552         (catch_catch_command): Update for changes to
6553         catch_exception_command_1.
6554         (catch_throw_command): Likewise.
6555         (catch_rethrow_command): Likewise.
6556         * breakpoint.c (enum exception_event_kind): Delete.
6557         * breakpoint.h (enum exception_event_kind): Moved here from
6558         break-catch-throw.c.
6559         (catch_exception_event): Declare.
6560         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6561         (mi_cmd_catch_throw): New function.
6562         (mi_cmd_catch_rethrow): New function.
6563         (mi_cmd_catch_catch): New function.
6564         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6565         'catch-catch' entries.
6566         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6567         (mi_cmd_catch_rethrow): Declare.
6568         (mi_cmd_catch_catch): Declare.
6569
6570 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * annotate.c (annotate_source_line): Change return type to void,
6573         update implementation to match.
6574         * annotate.h (annotate_source_line): Change return type to void,
6575         update header comment.
6576         * stack.c (print_frame_info): Don't change what frame information
6577         is printed based on whether annotations are on or not.
6578
6579 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6582         (annotate_source): Make static.
6583         (annotate_source_line): Moved from source.c and renamed from
6584         identify_source_line.  Update the return type.
6585         * annotate.h (annotate_source): Delete declaration.
6586         (annotate_source_line): Declaration moved from source.h, and
6587         renamed from identify_source_line.  Return type updated.
6588         * source.c (identify_source_line): Moved to annotate.c and renamed
6589         to annotate_source_line.
6590         (info_line_command): Remove check of annotation_level.
6591         * source.h (identify_source_line): Move declaration to annotate.h
6592         and rename to annotate_source_line.
6593         * stack.c: Add 'annotate.h' include.
6594         (print_frame_info): Remove check of annotation_level before
6595         calling annotate_source_line.
6596
6597 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * source-cache.c (source_cache::get_plain_source_lines): Use
6600         open_source_file_with_line_charpos instead of just
6601         open_source_file, remove call to find_source_lines.
6602         (source_cache::get_source_lines): Likewise.
6603         * source.c (find_source_lines): Make static.
6604         (get_filename_and_charpos): Renamed into...
6605         (open_source_file_with_line_charpos): ..this along with changes to
6606         return a scoped_fd, and some other minor clean ups.
6607         (identify_source_line): Use open_source_file_with_line_charpos.
6608         (search_command_helper): Use open_source_file_with_line_charpos
6609         instead of just open_source_file, remove call to
6610         find_source_lines.
6611         * source.h (open_source_file_with_line_charpos): Declare new
6612         function.
6613         (find_source_lines): Delete declaration.
6614
6615 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * source.c (get_filename_and_charpos): Remove fullname
6618         parameter.
6619         (identify_source_line): Update call to get_filename_and_charpos.
6620
6621 2019-06-14  Tom Tromey  <tromey@adacore.com>
6622
6623         PR gdb/24502:
6624         * ui-style.h (skip_ansi_escape): Update comment.
6625         * ui-file.h (class no_terminal_escape_file): New class.
6626         * ui-file.c (no_terminal_escape_file::write)
6627         (no_terminal_escape_file::puts): New methods.
6628         * cli/cli-logging.c (handle_redirections): Use
6629         no_terminal_escape_file.
6630
6631 2019-06-14  Tom Tromey  <tromey@adacore.com>
6632
6633         * NEWS: Move convenience variable news above Python news.
6634
6635 2019-06-14  Tom Tromey  <tom@tromey.com>
6636
6637         * gnulib: Move directory to top-level.
6638         * configure.ac: Don't configure gnulib.
6639         * configure: Rebuild.
6640         * common/common-defs.h: Use new path to gnulib.
6641         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6642         (GNULIB_H): Remove.
6643         (INCGNU): Look in new gnulib location.
6644         (HFILES_NO_SRCDIR): Remove gnulib files.
6645         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6646         (generated_files): Remove GNULIB_H.
6647         ($(LIBGNU), all-lib): Remove targets.
6648         (distclean): Don't mention GNULIB_BUILDDIR.
6649         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6650
6651 2019-06-14  Tom Tromey  <tromey@adacore.com>
6652
6653         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6654         Warn if symbol file does not provide any symbols.
6655
6656 2019-06-14  Tom Tromey  <tromey@adacore.com>
6657
6658         * source.c (find_and_open_source): Respect basenames_may_differ.
6659
6660 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * annotate.c (annotate_breakpoints_invalid): Make use of
6663         scoped_restore_terminal_state.
6664         (annotate_frames_invalid): Likewise.
6665
6666 2019-06-14  Tom Tromey  <tromey@adacore.com>
6667
6668         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6669         allow assignment to an internalvar.
6670
6671 2019-06-14  Tom Tromey  <tromey@adacore.com>
6672
6673         * ada-lex.l: Allow "_" in attribute names.
6674
6675 2019-06-14  Tom Tromey  <tromey@adacore.com>
6676
6677         PR gdb/24653:
6678         * regcache.c (registers_changed): Don't call alloca.
6679         * top.c (execute_command): Don't call alloca.
6680
6681 2019-06-13  Pedro Alves  <palves@redhat.com>
6682
6683         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6684         'expression'.  When parsing an expression, error out if there's
6685         junk after "unlimited".
6686         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6687         (do_set_command): Adjust calls to is_unlimited_literal.
6688
6689 2019-06-13  Pedro Alves  <palves@redhat.com>
6690
6691         * compile/compile.c (make_compile_options_def_group): Add braces
6692         around array_view initializer.
6693         * thread.c (make_thread_apply_all_options_def_group)
6694         (make_thread_apply_all_options_def_group): Likewise.
6695
6696 2019-06-13  Pedro Alves  <palves@redhat.com>
6697
6698         * NEWS (New commands): Mention "maint test-options
6699         require-delimiter", "maint test-options unknown-is-error", "maint
6700         test-options unknown-is-operand" and "maint show
6701         test-options-completion-result".
6702         (New command options, command completion): New section.
6703         (Completion improvements): New section.
6704         Mention that you can abbreviate "unlimited".
6705
6706 2019-06-13  Pedro Alves  <palves@redhat.com>
6707
6708         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6709         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6710         * unittests/cli-utils-selftests.c (test_parse_flags)
6711         (test_parse_flags_qcs): Delete.
6712         (test_cli_utils): Don't call deleted functions.
6713
6714 2019-06-13  Pedro Alves  <palves@redhat.com>
6715
6716         * thread.c: Include "cli/cli-option.h".
6717         (tp_array_compar_ascending): Global.
6718         (tp_array_compar): Delete function.
6719         (tp_array_compar_ascending, tp_array_compar_descending): New
6720         functions.
6721         (ascending_option_def, qcs_flag_option_def)
6722         (thr_qcs_flags_option_defs)
6723         (make_thread_apply_all_options_def_group)
6724         (make_thread_apply_options_def_group): New.
6725         (thread_apply_all_command): Use gdb::option::process_options.
6726         (thread_apply_command_completer)
6727         (thread_apply_all_command_completer): New.
6728         (thread_apply_command): Use gdb::option::process_options.
6729         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6730         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6731         to generate help text of "thread apply".  Adjust "taas"'s help.
6732         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6733         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6734
6735 2019-06-13  Pedro Alves  <palves@redhat.com>
6736
6737         * thread.c (thread_apply_command): Check for invalid TID with
6738         isdigit instead of !isalpha.
6739
6740 2019-06-13  Pedro Alves  <palves@redhat.com>
6741
6742         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6743         (validate_flags_qcs): New.
6744         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6745         (validate_flags_qcs): Declare.
6746         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6747         (make_frame_apply_options_def_group): New.
6748         (frame_apply_command_count): Process options with
6749         gdb::option::process_options.
6750         (frame_apply_completer): New.
6751         (frame_apply_level_completer, frame_apply_all_completer)
6752         (frame_apply_completer): New.
6753         (_initialize_stack): Update help of "frame apply", "frame apply
6754         level", "frame apply all" and "faas" to mention supported options
6755         and install command completers.
6756         * stack.h (frame_apply_all_completer): Declare.
6757         * thread.c: Include "stack.h".
6758         (tfaas_command): Add "--".
6759         (_initialize_thread): Update help "tfaas" to mention supported
6760         options and install command completer.
6761
6762 2019-06-13  Pedro Alves  <palves@redhat.com>
6763
6764         * completer.c (complete_nested_command_line): New.
6765         (gdb_completion_word_break_characters_throw): Add assertion.
6766         * completer.h (complete_nested_command_line): Declare.
6767
6768 2019-06-13  Pedro Alves  <palves@redhat.com>
6769
6770         * stack.c (parse_backtrace_qualifiers): New.
6771         (backtrace_command): Use it.
6772         (backtrace_command_completer): Complete on qualifiers.
6773
6774 2019-06-13  Pedro Alves  <palves@redhat.com>
6775
6776         * frame.c: Include "cli/cli-option.h.
6777         (user_set_backtrace_options): New.
6778         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6779         Delete.
6780         (get_prev_frame): Adjust.
6781         (boolean_option_def, uinteger_option_def)
6782         (set_backtrace_option_defs): New.
6783         (_initialize_frame): Adjust and use
6784         gdb::option::add_setshow_cmds_for_options to install "set
6785         backtrace past-main" and "set backtrace past-entry".
6786         * frame.h: Include "cli/cli-option.h".
6787         (struct frame_print_options): Forward declare.
6788         (print_frame_arguments_all, print_frame_arguments_scalars)
6789         (print_frame_arguments_none): Declare.
6790         (print_entry_values): Delete declaration.
6791         (struct frame_print_options, user_frame_print_options): New.
6792         (struct set_backtrace_options): New.
6793         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6794         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6795         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6796         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6797         (list_args_or_locals): Add frame_print_options parameter.
6798         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6799         * python/py-framefilter.c (enumerate_args): Pass down
6800         USER_FRAME_PRINT_OPTIONS.
6801         * stack.c: Include "cli/cli-option.h".
6802         (print_frame_arguments_all, print_frame_arguments_scalars)
6803         (print_frame_arguments_none): Declare.
6804         (print_raw_frame_arguments, print_entry_values): Delete.
6805         (user_frame_print_options): New.
6806         (boolean_option_def, enum_option_def, frame_print_option_defs):
6807         New.
6808         (struct backtrace_cmd_options): New.
6809         (bt_flag_option_def): New.
6810         (backtrace_command_option_defs): New.
6811         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6812         (print_frame_arg, read_frame_arg, print_frame_args)
6813         (print_frame_info, print_frame): Add frame_print_options parameter
6814         and use it.
6815         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6816         (backtrace_command_1): Add frame_print_options and
6817         backtrace_cmd_options parameters and use them.
6818         (make_backtrace_options_def_group): New.
6819         (backtrace_command): Process command options with
6820         gdb::option::process_options.
6821         (backtrace_command_completer): New.
6822         (_initialize_stack): Extend "backtrace"'s help to mention
6823         supported options.  Install completer for "backtrace".
6824         Install some settings commands with add_setshow_cmds_for_options.
6825
6826 2019-06-13  Pedro Alves  <palves@redhat.com>
6827
6828         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6829         and that "set/show print raw frame-arguments" are now deprecated.
6830
6831         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6832         command.
6833         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6834         * stack.c (_initialize_stack): Install "set/show print
6835         raw-frame-arguments", and deprecate "set/show print raw
6836         frame-arguments".
6837         * valprint.c (_initialize_valprint): Deprecate "set/show print
6838         raw".
6839
6840 2019-06-13  Pedro Alves  <palves@redhat.com>
6841
6842         * compile/compile.c (struct compile_options): New.
6843         (compile_flag_option_def, compile_command_option_defs)
6844         (make_compile_options_def_group): New.
6845         (compile_file_command): Handle options with
6846         gdb::option::process_options.
6847         (compile_file_command_completer): New function.
6848         (compile_code_command): Handle options with
6849         gdb::option::process_options.
6850         (compile_code_command_completer): New function.
6851         (_initialize_compiler): Install completers for "compile code" and
6852         "compile file".  Mention available options in "compile code" and
6853         "compile code"'s help.
6854         * completer.c (advance_to_completion_word): New, factored out from
6855         ...
6856         (advance_to_expression_complete_word_point): ... this.
6857         (advance_to_filename_complete_word_point): New.
6858         * completer.h (advance_to_filename_complete_word_point): New
6859         declaration.
6860
6861 2019-06-13  Pedro Alves  <palves@redhat.com>
6862
6863         * compile/compile.c: Include "cli/cli-option.h".
6864         (compile_print_value): Scope data pointer is now a
6865         value_print_options pointer; adjust.
6866         (compile_print_command): Process options.  Scope data pointer is
6867         now a value_print_options pointer; adjust.
6868         (_initialize_compile): Update "compile print"'s help to include
6869         supported options.  Install a completer for "compile print".
6870         * cp-valprint.c (show_vtblprint, show_objectprint)
6871         (show_static_field_print): Delete.
6872         (_initialize_cp_valprint): Don't install "set print
6873         static-members", "set print vtbl", "set print object" here.
6874         * printcmd.c: Include "cli/cli-option.h" and
6875         "common/gdb_optional.h".
6876         (print_command_parse_format): Rework to fill in a
6877         value_print_options instead of a format_data.
6878         (print_value): Change parameter type from format_data pointer to
6879         value_print_options reference.  Adjust.
6880         (print_command_1): Process options.  Adjust to pass down a
6881         value_print_options.
6882         (print_command_completer): New.
6883         (_initialize_printcmd): Install print_command_completer as
6884         handle_brkchars completer for the "print" command.  Update
6885         "print"'s help to include supported options.
6886         * valprint.c: Include "cli/cli-option.h".
6887         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6888         here from cp-valprint.c.
6889         (boolean_option_def, uinteger_option_def)
6890         (value_print_option_defs, make_value_print_options_def_group):
6891         New.  Use gdb::option::add_setshow_cmds_for_options to install
6892         "set print elements", "set print null-stop", "set print repeats",
6893         "set print pretty", "set print union", "set print array", "set
6894         print address", "set print symbol", "set print array-indexes".
6895         * valprint.h: Include <string> and "cli/cli-option.h".
6896         (make_value_print_options_def_group): Declare.
6897         (print_value): Change parameter type from format_data pointer to
6898         value_print_options reference.
6899         (print_command_completer): Declare.
6900
6901 2019-06-13  Pedro Alves  <palves@redhat.com>
6902
6903         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6904         (COMMON_SFILES): Add maint-test-settings.c.
6905         * cli/cli-decode.c (boolean_enums): New global, factored out from
6906         ...
6907         (add_setshow_boolean_cmd): ... here.
6908         * cli/cli-decode.h (boolean_enums): Declare.
6909         * cli/cli-option.c: New file.
6910         * cli/cli-option.h: New file.
6911         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6912         factored out from ...
6913         (parse_cli_boolean_value(const char *)): ... this.
6914         (is_unlimited_literal): Change parameter type to pointer to
6915         pointer.  Adjust and advance ARG pointer.
6916         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6917         (parse_cli_var_enum): New, factored out from ...
6918         (do_set_command): ... this.  Adjust.
6919         * cli/cli-setshow.h (parse_cli_boolean_value)
6920         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6921         (parse_cli_var_enum): Declare.
6922         * cli/cli-utils.c: Include "cli/cli-option.h".
6923         (get_ulongest): New.
6924         * cli/cli-utils.h (get_ulongest): Declare.
6925         (check_for_argument): New overloads.
6926         * maint-test-options.c: New file.
6927
6928 2019-06-13  Pedro Alves  <palves@redhat.com>
6929
6930         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6931         parse a range if "-" is at the end of the string.
6932
6933 2019-06-13  Pedro Alves  <palves@redhat.com>
6934
6935         * cli/cli-setshow.c (parse_auto_binary_operation)
6936         (parse_cli_boolean_value): Don't allow "o".
6937
6938 2019-06-13  Pedro Alves  <palves@redhat.com>
6939
6940         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6941         * NEWS: Mention maint test-settings KIND.
6942         * maint-test-settings.c: New file.
6943
6944 2019-06-13  Pedro Alves  <palves@redhat.com>
6945
6946         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6947         completer.
6948         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6949         "set" completers.
6950
6951 2019-06-13  Pedro Alves  <palves@redhat.com>
6952
6953         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6954         after item.
6955
6956 2019-06-13  Pedro Alves  <palves@redhat.com>
6957
6958         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6959
6960 2019-06-13  Pedro Alves <palves@redhat.com>
6961
6962         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6963         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6964         call.
6965         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6966         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6967         calls.
6968         (check_for_argument): Skip spaces after argument.
6969
6970 2019-06-13  Pedro Alves  <palves@redhat.com>
6971
6972         * thread.c (thread_apply_command): Adjust TID parsing.
6973         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6974         detected before end of string.
6975         (tid_is_in_list): Error out if LIST is invalid.
6976
6977 2019-06-13  Pedro Alves  <palves@redhat.com>
6978
6979         * completer.c (complete_line_internal_1): Rewind completion word
6980         point.
6981         (completion_tracker::advance_custom_word_point_by): Change
6982         parameter type to int.
6983         * completer.h (completion_tracker::advance_custom_word_point_by):
6984         Likewise.
6985
6986 2019-06-13  Pedro Alves  <palves@redhat.com>
6987
6988         * completer.c (advance_to_completion_word): Handle delimiters.
6989
6990 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6991
6992         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6993
6994 2019-06-11  Tom Tromey  <tom@tromey.com>
6995
6996         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6997         (xmalloc_failed): Move to alloc.c.
6998         * alloc.c: New file.
6999         * Makefile.in (COMMON_SFILES): Add alloc.c.
7000
7001 2019-06-11  Tom Tromey  <tom@tromey.com>
7002
7003         * nat/linux-waitpid.c: Don't include server.h.
7004         (linux_debug): Remove.
7005         (my_waitpid): Update.
7006
7007 2019-06-11  Tom Tromey  <tromey@adacore.com>
7008
7009         * infcall.c (_initialize_infcall): Remove trailing newline from
7010         help.
7011         * user-regs.c (_initialize_user_regs): Remove trailing newline
7012         from help.
7013         * typeprint.c (_initialize_typeprint): Remove trailing newline
7014         from help.
7015         * reverse.c (_initialize_reverse): Remove trailing newlines from
7016         help.
7017         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7018         from help.
7019         * language.c (add_set_language_command): Remove trailing newline
7020         from help.
7021         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7022         help.
7023         * disasm.c (_initialize_disasm): Remove trailing newline from
7024         help.
7025         * top.c (init_main): Remove trailing newline from help.
7026         * interps.c (_initialize_interpreter): Remove trailing newline
7027         from help.
7028         * btrace.c (_initialize_btrace): Remove trailing newlines from
7029         help.
7030         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7031         from help.
7032         * python/python.c (_initialize_python): Remove trailing newline
7033         from help.
7034         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7035         help.
7036         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7037         from help.  Reformat some text.
7038         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7039         from help.
7040         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7041         newline from help.
7042
7043 2019-06-11  Tom Tromey  <tromey@adacore.com>
7044
7045         * darwin-nat.c (darwin_decode_exception_message)
7046         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7047
7048 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * valops.c (value_slice): Check for not allocated or not
7051         associated values.
7052
7053 2019-06-10  Tom de Vries  <tdevries@suse.de>
7054
7055         PR gdb/24618
7056         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7057         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7058         invalid.
7059
7060 2019-06-10  Tom de Vries  <tdevries@suse.de>
7061
7062         PR gdb/24611
7063         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7064         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7065
7066 2019-06-10  Tom de Vries  <tdevries@suse.de>
7067
7068         PR symtab/24545
7069         * symtab.c (struct demangled_name_entry): Add language field.
7070         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7071         static minimal symbol".  Set and use language field.
7072
7073 2019-06-10  Tom Tromey  <tromey@adacore.com>
7074
7075         * ada-lang.c (_initialize_ada_language): Update help text.
7076
7077 2019-06-10  Tom Tromey  <tromey@adacore.com>
7078
7079         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7080         with a newline.
7081         * guile/guile.c (handle_boot_error): Don't end warning with a
7082         newline.
7083         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7084         warning with a newline.
7085         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7086         newline.
7087         (s12z_frame_cache): Likewise.
7088         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7089         a newline.
7090         * solib-svr4.c (disable_probes_interface): Don't end warning with
7091         a newline.
7092         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7093         newline.
7094         * python/python.c (do_finish_initialization): Don't end warning
7095         with a newline.
7096
7097 2019-06-10  Tom Tromey  <tom@tromey.com>
7098
7099         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7100         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7101         gdbpy_enter.
7102
7103 2019-06-10  Tom Tromey  <tromey@adacore.com>
7104
7105         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7106         data.
7107         (elf_new_init): Don't call stabsread_new_init.
7108         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7109         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7110         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7111
7112 2019-06-10  Tom de Vries  <tdevries@suse.de>
7113
7114         PR symtab/16264
7115         PR symtab/24517
7116         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7117
7118 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7119
7120         * source.c (find_and_open_source): Also rewrite relative file
7121         names.
7122
7123 2019-04-26  Amos Bird  <amosbird@gmail.com>
7124
7125         * annotate.c (annotate_thread_exited): Add "thread-exited"
7126         annotation.
7127
7128 2019-06-06  Tom Tromey  <tromey@adacore.com>
7129
7130         * maint.h (class scoped_command_stats): Use
7131         DISABLE_COPY_AND_ASSIGN.
7132         <print_time>: New method.
7133         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7134         print_time.
7135         (scoped_command_stats::print_time): New method.
7136
7137 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7138
7139         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7140         instructions of lengths 6 or 8 bytes.
7141
7142 2019-06-04  Pedro Alves  <palves@redhat.com>
7143
7144         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7145
7146         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7147         * breakpoint.c (condition_completer): Likewise.
7148         * cli/cli-dump.c (scan_expression): Likewise.
7149         * common/filestuff.c (mkdir_recursive): Likewise.
7150         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7151         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7152         (gdb_abspath): Likewise.
7153         * compile/compile-cplus-types.c
7154         (compile_cplus_instance::decl_name): Likewise.
7155         * completer.c (complete_explicit_location):
7156         (signal_completer, reg_or_group_completer_1): Likewise.
7157         * cp-support.c (cp_remove_params_if_any): Likewise.
7158         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7159         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7160         * infcmd.c (strip_bg_char): Likewise.
7161         * linespec.c (copy_token_string): Likewise.
7162         * mi/mi-main.c (output_cores): Likewise.
7163         * psymtab.c (psymtab_search_name):
7164         * symfile.c (test_set_ext_lang_command): Likewise.
7165         * target.c (target_fileio_read_stralloc): Likewise.
7166         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7167         * value.c (complete_internalvar): Likewise.
7168
7169 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7170
7171         Add objfile property to gdb.Type.
7172         * NEWS: Mention Python API addition.
7173         * python/py-type.c (typy_get_objfile): New method.
7174
7175 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7176
7177         * NEWS: Mention the new set|show style [title|highlight].
7178         Mention changes to "show style", "help" and "apropos".
7179
7180 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7181
7182         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7183         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7184         instead of print_help_for_command.
7185         (print_doc_of_command): New function.
7186         (help_list): Add 'apropos -v word' suggestion.
7187         (print_help_for_command): Style the command name using title style.
7188         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7189         (_initialize_cli_cmds): Describe -v in apropos_command help.
7190
7191 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7192
7193         * cli/cli-style.h (cli_style_option): Add name in constructor,
7194         add m_name class member, add constructor with intensity,
7195         add name class function.
7196         (cli_style_option::add_setshow_commands): Remove name argument.
7197         (highlight_style, title_style): New styles.
7198         * cli/cli-style.c (do_show): New function that shows a style
7199         characteristic styling the style name with itself.
7200         (set_style_name): New function.
7201         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7202         Update all callers according to the changes in cli/cli-style.h.
7203         * utils.h (fputs_highlighted): New function.
7204         * utils.c (fputs_highlighted): Likewise.
7205
7206 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7207
7208         * NEWS: Mention new pipe command and new convenience variables.
7209
7210 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7211
7212         * cli/cli-cmds.c (pipe_command): New function.
7213         (_initialize_cli_cmds): Call add_com for pipe_command.
7214         Define | as an alias for pipe.
7215         (exit_status_set_internal_vars): New function.
7216         (shell_escape): Call exit_status_set_internal_vars.
7217         cli/cli-decode.c (find_command_name_length): Recognize | as
7218         a single character command.
7219
7220 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7221
7222         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7223         top.c (execute_command_to_ui_file): New function, mostly a copy
7224         of execute_command_to_string.
7225         (execute_command_to_string): Implement by calling
7226         execute_command_to_ui_file.
7227
7228 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7229
7230         * top.h (saved_command_line): Remove declaration.
7231         * top.c (previous_saved_command_line, previous_repeat_arguments):
7232         New variables.
7233         (saved_command_line): Make static, define together with other
7234         'repeat variables'.
7235         (dont_repeat): Clear repeat_arguments.
7236         (repeat_previous, get_saved_command_line, save_command_line):
7237         New functions.
7238         (gdb_init): Initialize saved_command_line
7239         and previous_saved_command_line.
7240         * main.c (captured_main_1): Remove saved_command_line initialization.
7241         * event-top.c (handle_line_of_input): Update to use
7242         the new 'repeat' related functions instead of direct access to
7243         saved_command_line.
7244         * command.h (repeat_previous, get_saved_command_line,
7245         save_command_line): New declarations.
7246         (dont_repeat): Add comment.
7247
7248 2019-05-30  Tom Tromey  <tromey@adacore.com>
7249
7250         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7251         Fix comment.
7252         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7253
7254 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7255
7256         PR cli/24587
7257         * completer.c (complete): Initialize variable word.
7258
7259 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7260
7261         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7263         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7264         'body' is NULL to the outter 'if', protecting the '!is_define'
7265         situation as well.
7266
7267 2019-05-29  Tom Tromey  <tromey@adacore.com>
7268
7269         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7270         (dwarf_unknown): New function.
7271         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7272         (dwarf_type_encoding_name): Use dwarf_unknown.
7273
7274 2019-05-29  Tom Tromey  <tromey@adacore.com>
7275
7276         PR c++/20020:
7277         * cp-valprint.c (cp_print_value_fields): Call
7278         cp_print_static_field inside "try".
7279
7280 2019-05-29  Tom Tromey  <tromey@adacore.com>
7281
7282         * inflow.c (struct terminal_info): Add default operator=.
7283         * configure: Rebuild.
7284         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7285         -Wdeprecated-copy-dtor, -Wredundant-move.
7286
7287 2019-05-29  Tom Tromey  <tromey@adacore.com>
7288
7289         * NEWS: Add entry.
7290         * infcmd.c (print_return_value_1): Handle finish_print
7291         option.
7292         (show_print_finish): New function.
7293         (_initialize_infcmd): Add "set/show print finish" commands.
7294         * valprint.c (user_print_options): Initialize new member.
7295         * valprint.h (struct value_print_options) <finish_print>: New
7296         member.
7297
7298 2019-05-28  Tom Tromey  <tromey@adacore.com>
7299
7300         * ada-lang.c (ada_remove_Xbn_suffix)
7301         (find_old_style_renaming_symbol)
7302         (parse_old_style_renaming): Remove.
7303         (ada_find_renaming_symbol): Don't call
7304         find_old_style_renaming_symbol.
7305         (ada_is_renaming_symbol): Rename from
7306         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7307         bool.  Now static.
7308         (ada_read_var_value): Update and simplify.
7309         * ada-exp.y (write_var_or_type): Remove old code.
7310
7311 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7312
7313         PR gdb/25010
7314         * event-top.c: Remove include comment.
7315         * inflow.c (class scoped_ignore_sigttou): Move from here...
7316         * inflow.h (class scoped_ignore_sigttou): ...to here.
7317         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7318         * top.c:  Remove include comment.
7319
7320 2019-05-27  Tom Tromey  <tom@tromey.com>
7321
7322         * NEWS: Fix typo.
7323
7324 2019-05-22  Tom Tromey  <tromey@adacore.com>
7325
7326         * target.c (target_follow_exec): Constify parameter.
7327         * target-delegates.c: Rebuild.
7328         * remote.c (remote_target::follow_exec): Constify parameter.
7329         * infrun.c (follow_exec): Constify parameter.
7330         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7331         (target_follow_exec): Likewise.
7332
7333 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7334
7335         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7336         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7337
7338 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7339
7340         * NEWS: Add debugredirect and testsuite sections.
7341
7342 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7343
7344         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7345         target descriptions using exclusively floating point register name
7346         aliases.
7347
7348 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         PR gdb/18644:
7351         * f-lang.c (build_fortran_types): Handle the case where
7352         gdbarch_floatformat_for_type returns a nullptr.
7353
7354 2019-05-21  Tom de Vries  <tdevries@suse.de>
7355
7356         PR cli/24587
7357         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7358
7359 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7360
7361         PR gdb/18644:
7362         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7363         16-byte floats.
7364         * i386-tdep.c (i386_floatformat_for_type): Use
7365         floatformats_ia64_quad for the 16-byte floating point component
7366         within a fortran 32-byte complex number.
7367
7368 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7371         delete default constructor.
7372         (find_partial_die): Update to return const struct.
7373         (partial_die_parent_scope): Move variable declaration into scope
7374         of its use and change its type to auto.
7375         (guess_partial_die_structure_name): Likewise.
7376         (partial_die_info::fixup): Likewise.
7377
7378 2019-05-17  Tom Tromey  <tromey@adacore.com>
7379
7380         * source.c (find_and_open_source): Remove cast.
7381
7382 2019-05-17  Tom Tromey  <tromey@adacore.com>
7383
7384         * annotate.c (annotate_source): Make "filename" const.
7385         * annotate.h (annotate_source): Use const.
7386
7387 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7388
7389         * disasm.c (set_disassembler_options): Send errors to stderr.
7390
7391 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7392
7393         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7394         (cli_interp_base::set_logging): Check debug_redirect.
7395         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7396         * cli/cli-logging.c (debug_redirect): Add static variable.
7397         (pop_output_files): Add default param.
7398         (handle_redirections): Print debug setting.
7399         (show_logging_command): Likewise.
7400         (_initialize_cli_logging): Add debugredirect command.
7401         * interps.c (current_interp_set_logging): Add debug_redirect
7402         parameter.
7403         * interps.h (set_logging): Add debug_redirect parameter.
7404         (current_interp_set_logging): Likewise.
7405         * mi/mi-common.h: Likewise.
7406         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7407
7408 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7409             Tom Tromey  <tromey@adacore.com>
7410
7411         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7412         directly.
7413         * cli/cli-interp.h (make_logging_output): Remove declaration.
7414         * cli/cli-logging.c (make_logging_output): Remove function.
7415         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7416         directly.
7417         * ui-file.c (tee_file::tee_file): Remove bools.
7418         (tee_file::~tee_file): Remove deletes.
7419         * ui-file.h (tee_file): Remove bools.
7420
7421 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7422
7423         * mi/mi-cmds.h (mi_cmd_complete): New function.
7424         * mi/mi-main.c (mi_cmd_complete): Likewise.
7425         * mi/mi-cmds.c: Define new MI command -complete.
7426         * NEWS: Mention new -complete command.
7427
7428 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7429
7430         * completer.h (complete): New function.
7431         * completer.c (complete): Likewise.
7432         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7433         function defined in completer.h.
7434
7435 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7436
7437         * MAINTAINERS (Write After Approval): Add myself.
7438
7439 2019-05-17  Tom de Vries  <tdevries@suse.de>
7440
7441         PR gdb/24094
7442         * dwarf2read.c (struct cu_partial_die_info): New struct.
7443         (find_partial_die): Return cu_partial_die_info.
7444         (partial_die_parent_scope, guess_partial_die_structure_name)
7445         (partial_die_info::fixup): Handle new return type of find_partial_die.
7446
7447 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7448
7449         PR breakpoints/24541
7450         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7451         "std::string", simplifying the algorithm.
7452
7453 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7454
7455         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7456         (stap_static_probe_ops::get_probes): Likewise.
7457
7458 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7459
7460         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7461         '-')" and "else if".
7462         (stap_parse_single_operand): Join checks for
7463         "gdbarch_stap_parse_special_token_p" and
7464         "gdbarch_stap_parse_special_token" in the same "if" statement.
7465         Invert check when verifying for operation on register
7466         displacement.
7467
7468 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7469
7470         * stap-probe.c (stap_get_opcode): Update comment.
7471         (stap_get_expected_argument_type): Likewise.
7472         (handle_stap_probe): Likewise.
7473
7474 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7475
7476         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7477         return type to 'bool'.  Adjust comment.  Use 'bool' when
7478         appropriate.
7479         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7480         * stap-probe.c (stap_parse_argument_1): Likewise.
7481         (stap_is_operator): Likewise.
7482         (stap_is_generic_prefix): Likewise.
7483         (stap_is_register_prefix): Likewise.
7484         (stap_is_register_indirection_prefix): Likewise.
7485         (stap_is_integer_prefix): Likewise.
7486         (stap_generic_check_suffix): Likewise.
7487         (stap_check_integer_suffix): Likewise.
7488         (stap_check_register_suffix): Likewise.
7489         (stap_check_register_indirection_suffix): Likewise.
7490         (stap_parse_register_operand): Likewise.
7491         (stap_parse_single_operand): Likewise.
7492         (stap_parse_argument_1): Likewise.
7493         (stap_probe::get_argument_count): Likewise.
7494         (stap_is_operator): Likewise.
7495
7496 2019-05-16  Tom Tromey  <tromey@adacore.com>
7497
7498         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7499         keyword to foreach.
7500
7501 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7502
7503         * linux-thread-db.c (try_thread_db_load_1): Change return type
7504         to bool.
7505         (try_thread_db_load): Likewise.
7506         (try_thread_db_load_from_pdir_1): Likewise.
7507         (try_thread_db_load_from_pdir): Likewise.
7508         (try_thread_db_load_from_sdir): Likewise.
7509         (try_thread_db_load_from_dir): Likewise.
7510         (thread_db_load_search): Likewise.
7511         (has_libpthread): Likewise.
7512         (thread_db_load): Likewise.
7513
7514 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7515
7516         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7517         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7518         NULL, and complain/return if that's the case.
7519
7520 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7521
7522         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7523         (advance, posn, abstract_read_memory): New functions.
7524         [struct mem_read_abstraction]: New struct.
7525         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7526
7527 2019-05-14  Tom Tromey  <tromey@adacore.com>
7528
7529         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7530         value is not lval_memory.
7531
7532 2019-05-14  Tom Tromey  <tromey@adacore.com>
7533
7534         * solib.c (info_sharedlibrary_command): Style the file name.
7535
7536 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7537
7538         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7539         (aarch64_vnv_type): Likewise.
7540         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7541         * common/tdesc.c: Likewise.
7542         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7543         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7544         * features/aarch64-fpu.xml: Add ieee half view.
7545         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7546         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7547         * gdbtypes.h (struct builtin_type): Likewise.
7548         (struct objfile_type): Likewise.
7549
7550 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7551
7552         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7553         typo.
7554         * location.h (string_to_event_location): Likewise.
7555
7556 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7557
7558         GDB 8.3 released.
7559
7560 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7561
7562         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7563         New variable declaration.
7564         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7565         New variable.
7566         (print_one_breakpoint): Use ui_out::test_flags and new global
7567         variable to compute use_fixed_output.
7568         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7569         Remove.
7570         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7571         (mi_multi_location_breakpoint_output_fixed): Remove.
7572         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7573         new variable.
7574         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7575         fix_multi_location_breakpoint_output flag if version >= 3.
7576         * ui-out.h (enum ui_out_flag)
7577         <fix_multi_location_breakpoint_output>: New enumerator.
7578
7579 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7580
7581         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7582
7583 2019-05-10  Tom Tromey  <tromey@adacore.com>
7584
7585         * ada-lang.c (catch_ada_completer): New function.
7586         (_initialize_ada_language): Use it.
7587
7588 2019-05-10  Tom Tromey  <tromey@adacore.com>
7589
7590         * thread.c (print_thread_info): Make "requested_threads" const.
7591         * gdbthread.h (print_thread_info): Make "requested_threads"
7592         const.
7593         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7594         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7595
7596 2019-05-08  Tom Tromey  <tom@tromey.com>
7597
7598         * gdbtypes.c (objfile_type_data): Change type.
7599         (objfile_type, _initialize_gdbtypes): Update.
7600
7601 2019-05-08  Tom Tromey  <tom@tromey.com>
7602
7603         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7604         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7605         (_initialize_dwarf2_frame): Update.
7606
7607 2019-05-08  Tom Tromey  <tom@tromey.com>
7608
7609         * objc-lang.c (objc_objfile_data): Change type.
7610         (find_methods): Update.
7611         (_initialize_objc_lang): Remove.
7612
7613 2019-05-08  Tom Tromey  <tom@tromey.com>
7614
7615         * stabsread.c (rs6000_builtin_type_data): Change type.
7616         (rs6000_builtin_type, _initialize_stabsread): Update.
7617
7618 2019-05-08  Tom Tromey  <tom@tromey.com>
7619
7620         * mips-tdep.c (mips_pdr_data): Remove.
7621         (_initialize_mips_tdep): Update.
7622
7623 2019-05-08  Tom Tromey  <tom@tromey.com>
7624
7625         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7626         (hppa_init_objfile_priv_data, read_unwind_info)
7627         (find_unwind_entry, _initialize_hppa_tdep): Update.
7628
7629 2019-05-08  Tom Tromey  <tom@tromey.com>
7630
7631         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7632         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7633         on obstack.
7634         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7635
7636 2019-05-08  Tom Tromey  <tom@tromey.com>
7637
7638         * mdebugread.c (basic_type_data): Change type.
7639         (basic_type, _initialize_mdebugread): Update.
7640
7641 2019-05-08  Tom Tromey  <tom@tromey.com>
7642
7643         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7644
7645 2019-05-08  Tom Tromey  <tom@tromey.com>
7646
7647         * nto-tdep.c (nto_inferior_data_reg): Change type.
7648         (nto_inferior_data): Update.
7649         (nto_inferior_data_cleanup, nto_new_inferior_data)
7650         (_initialize_nto_tdep): Remove.
7651         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7652
7653 2019-05-08  Tom Tromey  <tom@tromey.com>
7654
7655         * ada-lang.c (struct ada_inferior_data): Add initializers.
7656         (ada_inferior_data): Change type.
7657         (ada_inferior_data_cleanup): Remove.
7658         (get_ada_inferior_data, ada_inferior_exit)
7659         (struct ada_pspace_data): Add initializers, destructor.
7660         (ada_pspace_data_handle): Change type.
7661         (get_ada_pspace_data): Update.
7662         (ada_pspace_data_cleanup): Remove.
7663
7664 2019-05-08  Tom Tromey  <tom@tromey.com>
7665
7666         * coffread.c (struct coff_symfile_info): Add initializers.
7667         (coff_objfile_data_key): Move lower.  Change type.
7668         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7669         Update.
7670         (coff_free_info): Remove.
7671
7672 2019-05-08  Tom Tromey  <tom@tromey.com>
7673
7674         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7675         (fbsd_pspace_data_handle): Move lower.  Change type.
7676         (get_fbsd_pspace_data): Update.
7677         (fbsd_pspace_data_cleanup): Remove.
7678         (_initialize_fbsd_tdep): Update.
7679
7680 2019-05-08  Tom Tromey  <tom@tromey.com>
7681
7682         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7683         (get_ada_tasks_pspace_data): Update.
7684         (ada_tasks_pspace_data_cleanup): Remove.
7685         (_initialize_tasks): Update.
7686         (ada_tasks_inferior_data_handle): Change type.
7687         (get_ada_tasks_inferior_data): Update.
7688         (ada_tasks_inferior_data_cleanup): Remove.
7689         (struct ada_tasks_pspace_data): Add initializers.
7690
7691 2019-05-08  Tom Tromey  <tom@tromey.com>
7692
7693         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7694         * symfile-debug.c (debug_sym_get_probes): Change type.
7695         * stap-probe.c (handle_stap_probe):
7696         (stap_static_probe_ops::get_probes): Change type.
7697         * probe.h (class static_probe_ops) <get_probes>: Change type.
7698         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7699         (parse_probes_in_pspace): Update.
7700         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7701         Update.
7702         (any_static_probe_ops::get_probes): Change type.
7703         * elfread.c (elfread_data): New typedef.
7704         (probe_key): Change type.
7705         (elf_get_probes): Likewise.  Update.
7706         (probe_key_free): Remove.
7707         (_initialize_elfread): Update.
7708         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7709         Change type.
7710         (dtrace_process_dof_probe, dtrace_process_dof)
7711         (dtrace_static_probe_ops::get_probe): Change type.
7712
7713 2019-05-08  Tom Tromey  <tom@tromey.com>
7714
7715         * xcoffread.c (struct xcoff_symfile_info): Rename from
7716         coff_symfile_info.  Add initializers.
7717         (xcoff_objfile_data_key): Move lower.  Change type.
7718         (XCOFF_DATA): Rewrite.
7719         (xcoff_free_info): Remove.
7720         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7721         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7722         (xcoff_initial_scan): Update.
7723
7724 2019-05-08  Tom Tromey  <tom@tromey.com>
7725
7726         * solib-svr4.c (struct svr4_info): Add initializers and
7727         destructor.
7728         <probes_table>: Now an htab_up.
7729         (solib_svr4_pspace_data): Change type.
7730         (free_probes_table): Simplify.
7731         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7732         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7733         (probes_table_remove_objfile_probes, register_solib_event_probe)
7734         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7735         (_initialize_svr4_solib): Update.
7736
7737 2019-05-08  Tom Tromey  <tom@tromey.com>
7738
7739         * remote.c (remote_pspace_data): Change type.
7740         (remote_pspace_data_cleanup): Remove.
7741         (get_remote_exec_file, set_pspace_remote_exec_file)
7742         (_initialize_remote): Update.
7743
7744 2019-05-08  Tom Tromey  <tom@tromey.com>
7745
7746         * breakpoint.c (breakpoint_objfile_key): Change type.
7747         (get_breakpoint_objfile_data): Update.
7748         (free_breakpoint_objfile_data): Remove.
7749         (_initialize_breakpoint): Update.
7750
7751 2019-05-08  Tom Tromey  <tom@tromey.com>
7752
7753         * linux-tdep.c (struct linux_info): Add initializers.
7754         (linux_inferior_data): Move.  Change type.
7755         (invalidate_linux_cache_inf): Update.
7756         (linux_inferior_data_cleanup): Remove.
7757         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7758
7759 2019-05-08  Tom Tromey  <tom@tromey.com>
7760
7761         * auxv.c (auxv_inferior_data): Move.  Change type.
7762         (auxv_inferior_data_cleanup): Remove.
7763         (invalidate_auxv_cache_inf): Rewrite.
7764         (get_auxv_inferior_data, _initialize_auxv): Update.
7765
7766 2019-05-08  Tom Tromey  <tom@tromey.com>
7767
7768         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7769         (symfile_debug_objfile_data_key): Change type.
7770         (symfile_debug_installed, debug_qf_has_symbols)
7771         (debug_qf_find_last_source_symtab)
7772         (debug_qf_forget_cached_source_info)
7773         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7774         (debug_qf_print_stats, debug_qf_dump)
7775         (debug_qf_expand_symtabs_for_function)
7776         (debug_qf_expand_all_symtabs)
7777         (debug_qf_expand_symtabs_with_fullname)
7778         (debug_qf_map_matching_symbols)
7779         (debug_qf_expand_symtabs_matching)
7780         (debug_qf_find_pc_sect_compunit_symtab)
7781         (debug_qf_map_symbol_filenames)
7782         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7783         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7784         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7785         (debug_sym_read_linetable, debug_sym_relocate): Update.
7786         (symfile_debug_free_objfile): Remove.
7787         (install_symfile_debug_logging, _initialize_symfile_debug):
7788         Update.
7789
7790 2019-05-08  Tom Tromey  <tom@tromey.com>
7791
7792         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7793         allocate_on_obstack.
7794         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7795         (get_dwarf2_per_objfile): Update.
7796         (set_dwarf2_per_objfile): Remove.
7797         (dwarf2_has_info, dwarf2_get_section_info): Update.
7798         (dwarf2_free_objfile): Remove.
7799         (_initialize_dwarf2_read): Update.
7800
7801 2019-05-08  Tom Tromey  <tom@tromey.com>
7802
7803         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7804         initializers.
7805         <unsupported_script_warning_printed,
7806         script_not_found_warning_printed>: Now bool.
7807         (auto_load_pspace_data): Change type.
7808         (~auto_load_pspace_info): Rename from
7809         auto_load_pspace_data_cleanup.
7810         (get_auto_load_pspace_data, init_loaded_scripts_info)
7811         (clear_section_scripts, maybe_print_unsupported_script_warning)
7812         (maybe_print_script_not_found_warning, _initialize_auto_load):
7813         Update.
7814
7815 2019-05-08  Tom Tromey  <tom@tromey.com>
7816
7817         * objfiles.c (objfile_pspace_info): Add destructor and
7818         initializers.
7819         (objfiles_pspace_data): Change type.
7820         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7821         (get_objfile_pspace_data): Update.
7822         (objfiles_bfd_data): Change type.
7823         (get_objfile_bfd_data): Update.
7824         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7825
7826 2019-05-08  Tom Tromey  <tom@tromey.com>
7827
7828         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7829         Change type.
7830         (get_catch_syscall_inferior_data): Update.
7831         (catch_syscall_inferior_data_cleanup): Remove.
7832         (_initialize_break_catch_syscall): Update.
7833
7834 2019-05-08  Tom Tromey  <tom@tromey.com>
7835
7836         * inflow.c (struct terminal_info): Add destructor and
7837         initializers.
7838         (inflow_inferior_data): Change type.
7839         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7840         (get_inflow_inferior_data, inflow_inferior_exit)
7841         (swap_terminal_info, _initialize_inflow): Update.
7842
7843 2019-05-08  Tom Tromey  <tom@tromey.com>
7844
7845         * target-dcache.c (target_dcache_cleanup): Remove.
7846         (target_dcache_aspace_key): Change type.
7847         (target_dcache_init_p, target_dcache_invalidate)
7848         (target_dcache_get, target_dcache_get_or_init)
7849         (_initialize_target_dcache): Update.
7850         * dcache.h (struct dcache_deleter): New.
7851
7852 2019-05-08  Tom Tromey  <tom@tromey.com>
7853
7854         * symtab.c (struct symbol_cache): Add destructor and
7855         initializers.
7856         (symbol_cache_key): Move.  Change type.
7857         (make_symbol_cache, free_symbol_cache): Remove.
7858         (get_symbol_cache): Update.
7859         (symbol_cache_cleanup): Remove.
7860         (ALL_PSPACES, symbol_cache_flush)
7861         (maintenance_print_symbol_cache)
7862         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7863         Update.
7864
7865 2019-05-08  Tom Tromey  <tom@tromey.com>
7866
7867         * symtab.c (struct main_info): Add destructor and initializers.
7868         (main_progspace_key): Move.  Change type.
7869         (get_main_info): Update.
7870         (main_info_cleanup): Remove.
7871         (_initialize_symtab): Update.
7872
7873 2019-05-08  Tom Tromey  <tom@tromey.com>
7874
7875         * registry.h (DECLARE_REGISTRY): Define the _key class.
7876
7877 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7878
7879         * NEWS: Merge two 'New commands' sections.
7880
7881 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7882
7883         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7884         parameter and use Ada language definition instead.
7885         (ada_val_print_ptr): Remove unused language parameter.
7886         (ada_val_print_num): Remove language parameter and use Ada language
7887         definition instead.
7888         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7889         parameter.
7890         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7891         parameter and use Ada language definition instead.
7892         (ada_val_print_1): Update all ada_val_print_xxx calls.
7893         Remove language parameter.
7894         (ada_val_print): Update ada_val_print_1 call.
7895
7896 2019-05-08  Tom Tromey  <tromey@adacore.com>
7897
7898         * remote.c (remote_hw_watchpoint_limit)
7899         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7900         Now static.
7901
7902 2019-05-08  Tom Tromey  <tromey@adacore.com>
7903
7904         * maint.c (_initialize_maint_cmds): Move initialization code to
7905         remote.c.
7906         (watchdog, show_watchdog): Move to remote.c.
7907         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7908         "watchdog" static.
7909         (_initialize_remote): Move initialization code from maint.c.
7910         * defs.h (watchdog): Don't declare.
7911
7912 2019-05-08  Tom Tromey  <tromey@adacore.com>
7913
7914         * tui/tui-interp.c: Include main.h.
7915         * interps.c: Include main.h.
7916         * main.h (interpreter_p): Declare.
7917         * defs.h (interpreter_p): Don't declare.
7918
7919 2019-05-08  Tom Tromey  <tromey@adacore.com>
7920
7921         * dwarf2loc.c: Include dwarf2read.h.
7922         * defs.h (read_unsigned_leb128): Don't declare.
7923         * dwarf2read.h (read_unsigned_leb128): Declare.
7924
7925 2019-05-08  Tom Tromey  <tromey@adacore.com>
7926
7927         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7928         method.
7929
7930 2019-05-08  Tom Tromey  <tromey@adacore.com>
7931
7932         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7933         when no wrap column is set.
7934
7935 2019-05-08  Tom Tromey  <tromey@adacore.com>
7936
7937         * c-lang.c (c_get_string): Handle non-C-style arrays.
7938
7939 2019-05-08  Tom Tromey  <tromey@adacore.com>
7940
7941         * typeprint.c (print_offset_data::update): Print the bit offset,
7942         not the number of bits remaining.
7943
7944 2019-05-08  Tom Tromey  <tromey@adacore.com>
7945
7946         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7947         padding at end of comment.
7948
7949 2019-05-08  Tom Tromey  <tromey@adacore.com>
7950
7951         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7952         Compare main types.
7953
7954 2019-05-06  Tom Tromey  <tom@tromey.com>
7955
7956         * common/scoped_mmap.c: Include common-defs.h.
7957         * common/scoped_mmap.h: Don't include config.h.
7958
7959 2019-05-04  Tom Tromey  <tom@tromey.com>
7960
7961         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7962         (struct aarch64_call_info): Add initializers.
7963         <si>: Now a std::vector.
7964         (pass_on_stack, aarch64_push_dummy_call): Update.
7965
7966 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7967             Tom Tromey  <tom@tromey.com>
7968
7969         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7970         (ppc_threads): Now a std::vector.  Now static.
7971         (hwdebug_find_thread_points_by_tid)
7972         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7973         Update.
7974
7975 2019-05-04  Tom Tromey  <tom@tromey.com>
7976
7977         * arc-tdep.c (arc_tdesc_init): Return bool.
7978
7979 2019-05-04  Tom Tromey  <tom@tromey.com>
7980
7981         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7982         Use gdb_assert_not_reached.
7983
7984 2019-05-04  Tom Tromey  <tom@tromey.com>
7985
7986         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7987         "false".
7988
7989 2019-05-04  Tom Tromey  <tom@tromey.com>
7990
7991         * arc-tdep.c (arc_tdesc_init): Use bool.
7992
7993 2019-05-04  Tom Tromey  <tom@tromey.com>
7994
7995         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7996
7997 2019-05-04  Tom Tromey  <tom@tromey.com>
7998
7999         * cli/cli-cmds.c (valid_command_p): Return bool.
8000
8001 2019-05-04  Tom Tromey  <tom@tromey.com>
8002
8003         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8004         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8005
8006 2019-05-04  Raul Tambre  <raul@tambre.ee>
8007
8008         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8009         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8010         operator for comparison.
8011
8012 2019-05-04  Tom Tromey  <tom@tromey.com>
8013
8014         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8015         (lookup_partial_symbol, print_partial_symbols)
8016         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8017         (psymbol_compare): Update.
8018         (add_psymbol_to_bcache): Clear the entire psymbol.
8019         (maintenance_check_psymtabs): Update.
8020         * psympriv.h (struct partial_symbol): Don't derive from
8021         general_symbol_info.
8022         <obj_section, unrelocated_address, address,
8023         set_unrelocated_address>: Update.
8024         <ginfo>: New member.
8025         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8026         (debug_names::write_psymbols): Update.
8027
8028 2019-05-04  Tom de Vries  <tdevries@suse.de>
8029
8030         * contrib/cc-with-tweaks.sh: Support -n arg.
8031
8032 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8033
8034         * corelow.c (core_target::detach): Ensure frame cache and
8035         register caches are cleared.
8036         inferior.c (exit_inferior_1): Likewise.
8037
8038 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8039             Tom Tromey  <tom@tromey.com>
8040
8041         * dictionary.c (collate_pending_symbols_by_language): Remove
8042         "struct" from foreach.
8043         * symtab.c (lookup_global_symbol_from_objfile)
8044         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8045         foreach.
8046         * ser-tcp.c (net_open): Remove "struct" from foreach.
8047         * objfiles.c (objfile_relocate, objfile_rebase)
8048         (objfile_has_symbols): Remove "struct" from foreach.
8049         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8050         from foreach.
8051         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8052         foreach.
8053         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8054         "struct" from foreach.
8055         * ada-lang.c (create_excep_cond_exprs)
8056         (ada_exception_catchpoint_cond_string): Remove "struct" from
8057         foreach.
8058
8059 2019-05-03  Tom Tromey  <tromey@adacore.com>
8060
8061         * ada-exp.y (convert_char_literal): Check suffix of each
8062         enumerator.
8063
8064 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8065
8066         PR ada/21406:
8067         * ada-exp.y (yywrap): Don't define.
8068         * ada-lex.l (%option): Add noyywrap
8069         (yywrap): Remove.
8070
8071 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8072
8073         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8074         _WIN32_WINNT to the XP level, unless already defined to a higher
8075         level.
8076
8077         * unittests/parse-connection-spec-selftests.c:
8078         * ser-tcp.c:
8079         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8080         override.
8081
8082         * symfile.c (find_separate_debug_file): Remove colon from the
8083         drive spec of DOS/Windows file names of the target, so that the
8084         file name produced from DEBUGDIR and the target's directory will
8085         be valid on DOS/Windows systems.
8086
8087 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8088
8089         * rust-lang.c (val_print_struct): Handle printing structures
8090         containing strings.
8091
8092 2019-05-02  Tom Tromey  <tromey@adacore.com>
8093
8094         * valarith.c (_initialize_valarith): Remove.
8095
8096 2019-05-01  Tom Tromey  <tromey@adacore.com>
8097
8098         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8099         bitfields.
8100
8101 2019-05-01  Tom Tromey  <tromey@adacore.com>
8102
8103         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8104         for big-endian copies.
8105
8106 2019-04-30  Ali Tamur  <tamur@google.com>
8107         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8108         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8109         (read_3_bytes): New function.
8110
8111 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8112
8113         * windows-nat.c (main_thread_id): Delete.
8114         (handle_output_debug_string): Replace main_thread_id by
8115         current_event.dwThreadId.
8116         (fake_create_process): Likewise.
8117         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8118         Do not set main_thread_id.
8119         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8120         current_event.dwThreadId.
8121         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8122
8123 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8124
8125         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8126         Use current_event.dwThreadId instead of main_thread_id.
8127
8128 2019-04-30  Tom Tromey  <tromey@adacore.com>
8129
8130         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8131         (create_excep_cond_exprs): Iterate over program spaces.
8132         (ada_exception_catchpoint_cond_string): Examine all minimal
8133         symbols for exception types.
8134
8135 2019-04-30  Tom Tromey  <tromey@adacore.com>
8136
8137         PR c++/24470:
8138         * dwarf2read.c (process_structure_scope): Handle case where type
8139         has template parameters but no symbol was created.
8140
8141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8142             Chris January  <chris.january@arm.com>
8143
8144         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8145         qualifier.
8146         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8147
8148 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8149
8150         * f-typeprint.c (f_print_type): Update rules for printing
8151         whitespace.
8152         (f_type_print_varspec_suffix): Likewise.
8153
8154 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8155             Chris January  <chris.january@arm.com>
8156
8157         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8158         function arguments.
8159
8160 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8161
8162         * f-lang.c (build_fortran_types): Change name of void type to
8163         lower case.
8164         * f-typeprint.c (f_type_print_base): Print the name of the void
8165         type, rather than a fixed string.
8166         * f-valprint.c (f_decorations): Use lower case void string.
8167
8168 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8169             Chris January  <chris.january@arm.com>
8170
8171         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8172         types for Fortran.
8173
8174 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8175             Chris January  <chris.january@arm.com>
8176             David Lecomber  <david.lecomber@arm.com>
8177
8178         * f-exp.y (BINOP_INTRINSIC): New token.
8179         (exp): New parser rule handling BINOP_INTRINSIC.
8180         (f77_keywords): Add new builtin procedures.
8181         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8182         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8183         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8184         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8185         (print_unop_subexp_f): New function.
8186         (print_binop_subexp_f): New function.
8187         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8188         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8189         (dump_subexp_body_f): Likewise.
8190         (operator_check_f): Likewise.
8191         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8192         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8193
8194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8197         UNOP_KIND.
8198         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8199         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8200         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8201         (operator_length_f): New fuction.
8202         (print_subexp_f): New function.
8203         (op_name_f): New function.
8204         (dump_subexp_body_f): New function.
8205         (operator_check_f): New function.
8206         (exp_descriptor_f): Replace standard expression handling functions
8207         with new functions.
8208         * gdb/fortran-operator.def: New file.
8209         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8210         * gdb/std-operator.def: Remove UNOP_KIND.
8211
8212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8213
8214         * std-operator.def: Remove unbalanced, stray double quote
8215         character.
8216
8217 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8218             Chris January  <chris.january@arm.com>
8219             Daniel Everett  <daniel.everett@arm.com>
8220             Nick Forrington  <nick.forrington@arm.com>
8221             Richard Bunt  <richard.bunt@arm.com>
8222
8223         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8224         of depth when printing anonymous structs or unions.
8225         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8226         Don't print either the top-level value, or the children if the
8227         max-depth is exceeded.
8228         (ppscm_print_children): When printing the key of a map, allow one
8229         extra level of depth.
8230         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8231         print either the top-level value, or the children if the max-depth
8232         is exceeded.
8233         (print_children): When printing the key of a map, allow one extra
8234         level of depth.
8235         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8236         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8237         (user_print_options): Initialise max_depth field.
8238         (val_print_scalar_or_string_type_p): New function.
8239         (val_print): Check to see if the max depth has been reached.
8240         (val_print_check_max_depth): Define new function.
8241         (show_print_max_depth): New function.
8242         (_initialize_valprint): Add 'print max-depth' option.
8243         * valprint.h (struct value_print_options) <max_depth>: New field.
8244         (val_print_check_max_depth): Declare new function.
8245         * NEWS: Document new feature.
8246
8247 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * ada-lang.c (ada_language_defn): Initialise new field.
8250         * c-lang.c (c_is_string_type_p): New function.
8251         (c_language_defn): Initialise new field.
8252         (cplus_language_defn): Initialise new field.
8253         (asm_language_defn): Initialise new field.
8254         (minimal_language_defn): Initialise new field.
8255         * c-lang.h (c_is_string_type_p): Declare new function.
8256         * d-lang.c (d_language_defn): Initialise new field.
8257         * f-lang.c (f_is_string_type_p): New function.
8258         (f_language_defn): Initialise new field.
8259         * go-lang.c (go_is_string_type_p): New function.
8260         (go_language_defn): Initialise new field.
8261         * language.c (default_is_string_type_p): New function.
8262         (unknown_language_defn): Initialise new field.
8263         (auto_language_defn): Initialise new field.
8264         * language.h (struct language_defn) <la_is_string_type_p>: New
8265         member variable.
8266         (default_is_string_type_p): Declare new function.
8267         * m2-lang.c (m2_language_defn): Initialise new field.
8268         * objc-lang.c (objc_language_defn): Initialise new field.
8269         * opencl-lang.c (opencl_language_defn): Initialise new field.
8270         * p-lang.c (pascal_is_string_type_p): New function.
8271         (pascal_language_defn): Initialise new field.
8272         * rust-lang.c (rust_is_string_type_p): New function.
8273         (rust_language_defn): Initialise new field.
8274
8275 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8278         New field.
8279         * ada-lang.c (ada_language_defn): Initialise new field.
8280         * c-lang.c (c_language_defn): Likewise.
8281         (cplus_language_defn): Likewise.
8282         (asm_language_defn): Likewise.
8283         (minimal_language_defn): Likewise.
8284         * d-lang.c (d_language_defn): Likewise.
8285         * f-lang.c (f_language_defn): Likewise.
8286         * go-lang.c (go_language_defn): Likewise.
8287         * language.c (unknown_language_defn): Likewise.
8288         (auto_language_defn): Likewise.
8289         * m2-lang.c (m2_language_defn): Likewise.
8290         * objc-lang.c (objc_language_defn): Likewise.
8291         * opencl-lang.c (opencl_language_defn): Likewise.
8292         * p-lang.c (pascal_language_defn): Likewise.
8293         * rust-lang.c (rust_language_defn): Likewise.
8294
8295 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8296
8297         * ada-lang.c (ada_is_character_type): Change return type to bool.
8298         (ada_is_string_type): Likewise.
8299         * ada-lang.h (ada_is_character_type): Update declaration
8300         (ada_is_string_type): Likewise.
8301
8302 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8303
8304         Support style in 'frame|thread apply'
8305
8306         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8307         * record.c (record_start, record_stop): Update callers of
8308         execute_command_to_string with false.
8309         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8310         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8311         methods.
8312         (class string_file): New constructor with term_out parameter.
8313         Override methods term_out and can_emit_style_escape.  New member
8314         term_out.
8315         (class stdio_file): Override can_emit_style_escape.
8316         (class tee_file): Override term_out and can_emit_style_escape.
8317         * utils.h (can_emit_style_escape): Remove.
8318         * utils.c (can_emit_style_escape): Likewise.
8319         Update all callers of can_emit_style_escape (SOMESTREAM) to
8320         SOMESTREAM->can_emit_style_escape.
8321         * source-cache.c (source_cache::get_source_lines): Likewise.
8322         * stack.c (frame_apply_command_count): Call execute_command_to_string
8323         passing the term_out characteristic of the current gdb_stdout.
8324         * thread.c (thr_try_catch_cmd): Likewise.
8325         * top.c (execute_command_to_string): pass term_out parameter
8326         to construct the string_file for the command output.
8327         * ui-file.c (term_cli_styling): New function (most code moved
8328         from utils.c can_emit_style_escape).
8329         (string_file::string_file, string_file::can_emit_style_escape,
8330         stdio_file::can_emit_style_escape, tee_file::term_out,
8331         tee_file::can_emit_style_escape): New functions.
8332
8333 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8334
8335         * NEWS: Mention the new set|show may-call-functions.
8336         * infcall.c (may_call_functions_p): New variable.
8337         (show_may_call_functions_p): New function.
8338         (call_function_by_hand_dummy): Throws an error if not
8339         may-call-functions.
8340         (_initialize_infcall): Call add_setshow_boolean_cmd for
8341         may-call-functions.
8342
8343 2019-04-25  Keith Seitz  <keiths@redhat.com>
8344
8345         PR c++/24367
8346         * cp-support.c (inspect_type): Don't attempt substitutions
8347         of symbol with the same name.
8348
8349 2019-04-25  Tom Tromey  <tromey@adacore.com>
8350
8351         PR gdb/24475:
8352         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8353         static.
8354
8355 2019-04-25  Tom Tromey  <tromey@adacore.com>
8356
8357         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8358         rvalue reference.
8359         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8360         (gdb_xml_parser::parse): Use std::move.
8361         * python/python-internal.h (gdbpy_convert_exception): Take a const
8362         reference.
8363         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8364         std::move.
8365         * python/py-utils.c (gdbpy_convert_exception): Take a const
8366         reference.
8367         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8368         Use std::move.
8369         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8370         Use std::move.
8371         * mi/mi-main.c (mi_print_exception): Take a const reference.
8372         * main.c (handle_command_errors): Take a const reference.
8373         * linespec.c (parse_linespec): Use std::move.
8374         * infcall.c (run_inferior_call): Use std::move.
8375         (call_function_by_hand_dummy): Use std::move.
8376         * exec.c (try_open_exec_file): Use std::move.
8377         * exceptions.h (exception_print, exception_fprintf)
8378         (exception_print_same): Update.
8379         * exceptions.c (print_exception, exception_print)
8380         (exception_fprintf, exception_print_same): Change parameters to
8381         const reference.
8382         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8383         * common/new-op.c: Use std::move.
8384         * common/common-exceptions.h (struct gdb_exception): Add move
8385         constructor.
8386         (struct gdb_exception_error, struct gdb_exception_quit, struct
8387         gdb_quit_bad_alloc): Change constructor to move constructor.
8388         (throw_exception): Change parameter to rvalue reference.
8389         * common/common-exceptions.c (throw_exception): Take rvalue
8390         reference.
8391         * cli/cli-interp.c (safe_execute_command): Use std::move.
8392         * breakpoint.c (insert_bp_location, location_to_sals): Use
8393         std::move.
8394
8395 2019-04-25  Tom Tromey  <tromey@adacore.com>
8396
8397         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8398         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8399         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8400         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8401         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8402         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8403         guile/scm-value.c: Use unpack.
8404         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8405         gdbscm_gdb_exception.
8406         (gdbscm_throw_gdb_exception): Likewise.
8407         (struct gdbscm_gdb_exception): New.
8408         (unpack): New function.
8409         (gdbscm_wrap): Use unpack.
8410
8411 2019-04-25  Tom Tromey  <tromey@adacore.com>
8412
8413         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8414         (gdb_rl_callback_handler): Use std::move.
8415         * common/common-exceptions.h (struct gdb_exception): Add move
8416         assignment operator.
8417         (throw_exception_sjlj): Change "exception" to const reference.
8418         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8419         (throw_exception_sjlj): Change "exception" to const reference.
8420
8421 2019-04-25  Tom Tromey  <tromey@adacore.com>
8422
8423         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8424         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8425         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8426         Update.
8427         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8428         Update.
8429         * mi/mi-interp.c (mi_interp::exec): Update.
8430         * linespec.c (parse_linespec): Update.
8431         * infcall.c (run_inferior_call): Update.
8432         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8433         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8434         (gdbscm_lookup_global_symbol): Update.
8435         * guile/scm-param.c (gdbscm_parameter_value): Update.
8436         * guile/scm-frame.c (gdbscm_frame_read_register)
8437         (gdbscm_frame_read_var): Update.
8438         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8439         * exec.c (try_open_exec_file): Update.
8440         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8441         (gdb_rl_callback_handler): Update.
8442         * common/common-exceptions.h (exception_none): Don't declare.
8443         * common/common-exceptions.c (exception_none): Don't define.
8444         (struct catcher) <exception>: Update.
8445         * cli/cli-interp.c (safe_execute_command): Update.
8446         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8447
8448 2019-04-25  Ali Tamur  <tamur@google.com>
8449
8450         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8451         (read_attribute_value): Likewise.
8452         (dwarf2_read_addr_index): Update comment.
8453         (read_str_index): Add DW_FORM_strx.
8454         (dwarf2_string_attr): Likewise.
8455         (dwarf2_const_value_attr): Likewise.
8456         (dump_die_shallow): Likewise.
8457         (dwarf2_fetch_constant_bytes): Likewise.
8458         (skip_form_bytes): Likewise.
8459         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8460
8461 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8462
8463         PR corefiles/11608
8464         PR corefiles/18187
8465         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8466         OFFSET.  Verify if current mapping contains an ELF header.
8467         (linux_find_memory_regions_full): Adjust call to
8468         dump_mapping_p.
8469
8470 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8471             Kang Li <kanglictf@gmail.com>
8472
8473         PR gdb/21600
8474
8475         * dwarf2-frame.c (read_initial_length): Be consistent about using
8476         unsigned representation of length.
8477         (decode_frame_entry_1): Likewise.  Check for wraparound of
8478         end pointer as well as buffer overflow.
8479
8480 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8481
8482         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8483         "vq".
8484
8485 2019-04-24  Tom Tromey  <tromey@adacore.com>
8486
8487         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8488
8489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8490
8491         * s12z-tdep.c (s12z_unwind_pc): Delete.
8492         (s12z_unwind_sp): Delete.
8493         (s12z_gdbarch_init): Don't register deleted functions with
8494         gdbarch.
8495
8496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * rl78-tdep.c (rl78_unwind_sp): Delete.
8499         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8500
8501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8502
8503         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8504         (xstormy16_unwind_pc): Delete.
8505         (xstormy16_dummy_id): Delete.
8506         (xstormy16_gdbarch_init): Don't register deleted functions with
8507         gdbarch.
8508
8509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * vax-tdep.c (vax_unwind_pc): Delete.
8512         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8513
8514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8515
8516         * v850-tdep.c (v850_unwind_sp): Delete.
8517         (v850_unwind_pc): Delete.
8518         (v850_dummy_id): Delete.
8519         (v850_gdbarch_init): Don't register deleted functions with
8520         gdbarch.
8521
8522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8523
8524         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8525         (tilegx_unwind_pc): Delete.
8526         (tilegx_unwind_dummy_id): Delete.
8527         (tilegx_gdbarch_init): Don't register deleted functions with
8528         gdbarch.
8529
8530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8531
8532         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8533         (tic6x_dummy_id): Delete.
8534         (tic6x_gdbarch_init): Don't register deleted functions with
8535         gdbarch.
8536
8537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * sparc-tdep.c (sparc_unwind_pc): Delete.
8540         (sparc32_gdbarch_init): Don't register deleted function with
8541         gdbarch.
8542
8543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8544
8545         * sh-tdep.c (sh_unwind_sp): Delete.
8546         (sh_unwind_pc): Delete.
8547         (sh_dummy_id): Delete.
8548         (sh_gdbarch_init): Don't register deleted functions with
8549         gdbarch.
8550
8551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8552
8553         * score-tdep.c (score_unwind_sp): Delete.
8554         (score_unwind_pc): Delete.
8555         (score_dummy_id): Delete.
8556         (score_gdbarch_init): Don't register deleted functions with
8557         gdbarch.
8558
8559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * rx-tdep.c (rx_unwind_pc): Delete.
8562         (rx_unwind_sp): Delete.
8563         (rx_dummy_id): Delete.
8564         (rx_gdbarch_init): Don't register deleted functions with
8565         gdbarch.  Update comment.
8566
8567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8570         (rs6000_dummy_id): Delete.
8571         (rs6000_gdbarch_init): Don't register deleted functions with
8572         gdbarch.
8573
8574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8575
8576         * or1k-tdep.c (or1k_dummy_id): Delete.
8577         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8578
8579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * nios2-tdep.c (nios2_dummy_id): Delete.
8582         (nios2_unwind_sp): Delete.
8583         (nios2_gdbarch_init): Don't register deleted functions with
8584         gdbarch.
8585
8586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * nds32-tdep.c (nds32_dummy_id): Delete.
8589         (nds32_unwind_pc): Delete.
8590         (nds32_unwind_sp): Delete.
8591         (nds32_gdbarch_init): Don't register deleted functions with
8592         gdbarch.
8593
8594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * msp430-tdep.c (msp430_unwind_pc): Delete.
8597         (msp430_unwind_sp): Delete.
8598         (msp430_dummy_id): Delete.
8599         (msp430_gdbarch_init): Don't register deleted functions with
8600         gdbarch.
8601
8602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8603
8604         * moxie-tdep.c (moxie_unwind_sp): Delete.
8605         (moxie_unwind_pc): Delete.
8606         (moxie_dummy_id): Delete.
8607         (moxie_gdbarch_init): Don't register deleted functions with
8608         gdbarch.
8609
8610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8611
8612         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8613         (mn10300_unwind_pc): Delete.
8614         (mn10300_unwind_sp): Delete.
8615         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8616         mn10300_unwind_sp.
8617         (mn10300_frame_unwind_init): Don't register deleted functions with
8618         gdbarch.
8619
8620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8621
8622         * mep-tdep.c (mep_unwind_pc): Delete.
8623         (mep_unwind_sp): Delete.
8624         (mep_dummy_id): Delete.
8625         (mep_gdbarch_init): Don't register deleted functions with
8626         gdbarch.
8627
8628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8629
8630         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8631         (m68hc11_unwind_sp): Delete.
8632         (m68hc11_gdbarch_init): Don't register deleted functions with
8633         gdbarch.
8634
8635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * m32r-tdep.c (m32r_unwind_sp): Delete.
8638         (m32r_unwind_pc): Delete.
8639         (m32r_dummy_id): Delete.
8640         (m32r_gdbarch_init): Don't register deleted functions with
8641         gdbarch.
8642
8643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8644
8645         * m32c-tdep.c (m32c_unwind_pc): Delete.
8646         (m32c_unwind_sp): Delete.
8647         (m32c_dummy_id): Delete.
8648         (m32c_gdbarch_init): Don't register deleted functions with
8649         gdbarch.
8650
8651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8652
8653         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8654         (lm32_unwind_pc): Delete.
8655         (lm32_dummy_id): Delete.
8656         (lm32_gdbarch_init): Don't register deleted functions with
8657         gdbarch.
8658
8659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8660
8661         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8662         (iq2000_unwind_pc): Delete.
8663         (iq2000_dummy_id): Delete.
8664         (iq2000_gdbarch_init): Don't register deleted functions with
8665         gdbarch.
8666
8667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8668
8669         * nds32-tdep.c (nds32_type_align): Delete.
8670         (nds32_push_dummy_call): Use type_align instead.
8671
8672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8673
8674         * arm-tdep.c (arm_type_align): Only handle vector override case.
8675         (arm_push_dummy_call): Use type_align.
8676         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8677
8678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8679
8680         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8681         case.
8682         (pass_on_stack): Use type_align.
8683         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8684         function.
8685
8686 2019-04-23  Tom Tromey  <tromey@adacore.com>
8687
8688         * dwarf2read.c (line_header::file_name_at): Remove unused
8689         overload.
8690
8691 2019-04-23  Tom de Vries  <tdevries@suse.de>
8692
8693         PR gdb/24438
8694         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8695         invocation.
8696
8697
8698 2019-03-27  Ali Tamur  <tamur@google.com>
8699
8700         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8701         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8702         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8703         (dwarf_expr_context::get_addr_index): Likewise
8704         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8705         (symbol_needs_eval_context::get_addr_index): Likewise
8706         (disassemble_dwarf_expression): Add DW_OP_addrx
8707         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8708         (read_cutu_die_from_dwo): Update comment
8709         (skip_one_die): Add DW_FORM_addrx
8710         (read_attribute_value): Likewise
8711         (var_decode_location): Add DW_OP_addrx
8712         (dwarf2_const_value_attr): Add DW_FORM_addrx
8713         (dump_die_shallow): Likewise
8714         (dwarf2_fetch_constant_bytes): Likewise
8715         (decode_locdesc): Add DW_OP_addrx
8716         (skip_form_bytes): Add DW_FORM_addrx
8717
8718 2019-04-22  Ali Tamur  <tamur@google.com>
8719
8720         * MAINTAINERS (Write After Approval): Add self.
8721
8722 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8723
8724         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8725         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8726         (open_symbol_file_object): Likewise.
8727         (svr4_default_sos): Add info parameter.
8728         (svr4_read_so_list): Likewise.
8729         (svr4_current_sos_direct): Adjust functions calls to pass down
8730         info.
8731         (svr4_current_sos_1): Add info parameter.
8732         (svr4_current_sos): Call get_svr4_info, pass info down to
8733         svr4_current_sos_1.
8734         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8735         get_svr4_info.
8736         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8737         get_svr4_info.
8738         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8739         to get_svr4_info.
8740         (probes_table_remove_objfile_probes): Likewise.
8741         (register_solib_event_probe): Add info parameter.
8742         (solist_update_incremental): Pass info parameter down to
8743         svr4_read_so_list.
8744         (disable_probes_interface): Add info parameter.
8745         (svr4_handle_solib_event): Pass current_program_space to
8746         get_svr4_info.  Adjust disable_probes_interface cleanup.
8747         (svr4_create_probe_breakpoints): Add info parameter, pass it
8748         down to register_solib_event_probe.
8749         (svr4_create_solib_event_breakpoints): Add info parameter,
8750         pass it down to svr4_create_probe_breakpoints.
8751         (enable_break): Pass info down to
8752         svr4_create_solib_event_breakpoints.
8753         (svr4_solib_create_inferior_hook): Pass current_program_space to
8754         get_svr4_info.
8755         (svr4_clear_solib): Likewise.
8756
8757 2019-04-22  Pedro Alves  <palves@redhat.com>
8758
8759         * solib-svr4.c (svr4_free_objfile_observer): New.
8760         (probe_and_action::objfile): New field.
8761         (probes_table_htab_remove_objfile_probes)
8762         (probes_table_remove_objfile_probes): New functions.
8763         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8764         in the new probe_and_action.  Don't store the probe in 'lookup'.
8765         (svr4_create_probe_breakpoints): Pass objfile to
8766         register_solib_event_probe.
8767         (_initialize_svr4_solib): Register a free_objfile observer.
8768
8769 2019-04-19  Tom Tromey  <tom@tromey.com>
8770
8771         * common/queue.h: Remove.
8772
8773 2019-04-19  Tom Tromey  <tom@tromey.com>
8774
8775         * event-loop.c: Don't include "common/queue.h".
8776
8777 2019-04-19  Tom Tromey  <tom@tromey.com>
8778
8779         * remote.c (remote_target): Use delete.
8780         * remote-notif.h: Include <list>, not "common/queue.h".
8781         (notif_client_p): Remove typedef.
8782         (remote_notif_state): Add constructor, destructor, initializer.
8783         <notif_queue>: Now a std::list.
8784         (remote_notif_state_xfree): Don't declare.
8785         * remote-notif.c (remote_notif_process, handle_notification)
8786         (remote_notif_state_allocate): Update.
8787         (~remote_notif_state): Rename from remote_notif_state_xfree.
8788
8789 2019-04-19  Tom Tromey  <tom@tromey.com>
8790
8791         * symfile.c (reread_symbols): Update.
8792         * objfiles.c (objfile_register_static_link)
8793         (objfile_lookup_static_link): Update
8794         (~objfile) Don't delete static_links.
8795         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8796
8797 2019-04-19  Tom Tromey  <tom@tromey.com>
8798
8799         * type-stack.h (struct type_stack) <insert>: Constify string.
8800         * type-stack.c (type_stack::insert): Constify string.
8801         * gdbtypes.h (lookup_template_type): Update.
8802         (address_space_name_to_int): Update.
8803         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8804         const.
8805         (lookup_template_type): Make name const.
8806         * c-exp.y: Update rules.
8807         (lex_one_token, classify_name, classify_inner_name)
8808         (c_print_token): Update.
8809         * p-exp.y: Update rules.
8810         (yylex): Update.
8811         * f-exp.y: Update rules.
8812         (yylex): Update.
8813         * d-exp.y: Update rules.
8814         (lex_one_token, classify_name, classify_inner_name): Update.
8815         * parse.c (write_dollar_variable, copy_name): Return std::string.
8816         * parser-defs.h (copy_name): Change return type.
8817         * m2-exp.y: Update rules.
8818         (yylex): Update.
8819         * go-exp.y (lex_one_token): Update.
8820         Update rules.
8821         (classify_unsafe_function, classify_packaged_name)
8822         (classify_name, yylex): Update.
8823
8824 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8825
8826         * configure.ac: add --enable-source-highlight switch.
8827         * configure: Regenerate.
8828         * top.c (print_gdb_version): plumb --enable-source-highlight
8829         status to "show configuration".
8830
8831 2019-04-19  Tom Tromey  <tromey@adacore.com>
8832
8833         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8834         Check ADA_TYPE_P.
8835         (empty_record, ada_template_to_fixed_record_type_1)
8836         (template_to_static_fixed_type)
8837         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8838         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8839         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8840         macros.
8841
8842 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8843
8844         PR symtab/24423:
8845         * source.c (print_source_lines_base): Advance "iter" when a
8846         control character is seen.
8847
8848 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8849
8850         * inferior.h (struct infcall_suspend_state_deleter):
8851         Catch exception in destructor to avoid crash.
8852
8853 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8854
8855         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8856         close to the add_com "shell".
8857
8858 2019-04-18  Tom Tromey  <tromey@adacore.com>
8859
8860         * process-stratum-target.h (class process_stratum_target)
8861         <stratum>: Add "final".
8862
8863 2019-04-17  Tom Tromey  <tromey@adacore.com>
8864
8865         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8866         against nullptr before use.
8867
8868 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8869
8870         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8871
8872 2019-04-17  Jim Wilson  <jimw@sifive.com>
8873             Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8876         code read might fail, assume 4-byte breakpoint in that case.
8877
8878 2019-04-15  Leszek Swirski  <leszeks@google.com>
8879
8880         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8881         rather than a hand-rolled POD check when checking for forced MEMORY
8882         classification.
8883
8884 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8885
8886         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8887         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8888         function.
8889         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8890         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8891         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8892         declaration.
8893
8894 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8895
8896         * aarch64-linux-nat.c
8897         (aarch64_linux_nat_target::thread_architecture): Add override.
8898         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8899         each VQ.
8900
8901 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8902
8903         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8904
8905 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8906
8907         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8908         target types of size 96-bits, add some additional comments, and
8909         check that the builtin type we found was the correct size.
8910
8911 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8912
8913         * utils.c (prompt_for_continue): Don't restore the styling at the
8914         end, as applied_style has the wrong value.  This fixes styling in
8915         long lists of file names that are interrupted by the "Continue?"
8916         prompt.
8917
8918 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8919
8920         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8921         * c-lang.c (c_language_defn): Likewise.
8922         (cplus_language_defn): Likewise.
8923         (asm_language_defn): Likewise.
8924         (minimal_language_defn): Likewise.
8925         * d-lang.c (d_language_defn): Likewise.
8926         * f-lang.c (f_language_defn): Likewise.
8927         * go-lang.c (go_language_defn): Likewise.
8928         * language.c (unknown_language_defn): Likewise.
8929         (auto_language_defn): Likewise.
8930         * language.h (struct language_defn): Remove la_magic field.
8931         (LANG_MAGIC): Delete.
8932         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8933         * objc-lang.c (objc_language_defn): Likewise.
8934         * opencl-lang.c (opencl_language_defn): Likewise.
8935         * p-lang.c (pascal_language_defn): Likewise.
8936         * rust-lang.c (rust_language_defn): Likewise.
8937
8938 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * riscv-tdep.c (riscv_type_align): New function.
8941         (riscv_type_alignment): Delete.
8942         (riscv_arg_location): Use 'type_align'.
8943         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8944
8945 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * gdbtypes.c (type_align): A struct with no non-static fields also
8948         has alignment of 1.
8949
8950 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8951
8952         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8953         component to 0.
8954         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8955         member.
8956         (riscv_struct_info::analyse): New implementation using new
8957         analyse_inner member function.
8958         (riscv_struct_info::field_offset): New member function.
8959         (riscv_struct_info::m_offsets): New member variable.
8960         (riscv_struct_info::analyse_inner): New private member function,
8961         takes the old implementation of riscv_struct_info::analyse but
8962         extended to track field offsets.
8963         (riscv_call_arg_struct): Update the struct folding special cases
8964         to handle cases where empty C++ structs, which are non-zero
8965         length, are found.
8966         (riscv_arg_location): Initialise the length of each location, a
8967         non-zero length now indicates the location is in use.
8968         (riscv_push_dummy_call): Allow for the first location having a
8969         non-zero offset when setting up arguments.
8970         (riscv_return_value): Likewise, but for return values.
8971
8972 2019-04-11  Tom Tromey  <tromey@adacore.com>
8973
8974         * utils.c (internal_vproblem): Make "msg" const.
8975
8976 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8977
8978         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8979         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8980         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8981         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8982
8983 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8984
8985         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8986         function.
8987         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8988         of amd64_collect_native_gregset.
8989         (amd64_linux_nat_target::store_registers): Likewise.
8990
8991 2019-04-10  Tom Tromey  <tom@tromey.com>
8992
8993         * symtab.c (lookup_global_symbol_from_objfile)
8994         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8995         * objfiles.h (class separate_debug_iterator): New.
8996         (class separate_debug_range): New.
8997         (struct objfile) <separate_debug_objfiles>: New method.
8998         (objfile_separate_debug_iterate): Don't declare.
8999         * objfiles.c (separate_debug_iterator::operator++): Rename from
9000         objfile_separate_debug_iterate.
9001         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9002         iterator.
9003         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9004         iterator.
9005
9006 2019-04-10  Tom Tromey  <tom@tromey.com>
9007
9008         * symfile.c (reread_symbols): Remove old comment.
9009         * objfiles.c (free_all_objfiles): Fix a typo.
9010
9011 2019-04-10  Tom Tromey  <tom@tromey.com>
9012
9013         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9014         * minsyms.c (lookup_minimal_symbol): Use foreach.
9015         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9016         (lookup_minimal_symbol_solib_trampoline): Likewise.
9017         * symfile.c (reread_symbols): Use foreach.
9018
9019 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9020             Tom Tromey  <tromey@adacore.com>
9021
9022         PR rust/24414:
9023         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9024         (rust_lex_int_test): Change "value" to be LONGEST.
9025         (rust_lex_tests): Add test for long integer literal.
9026
9027 2019-04-09  Tom Tromey  <tromey@adacore.com>
9028
9029         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9030         to bool.
9031         (extended_remote_target::attach): Update.
9032         (remote_target::remote_notice_new_inferior): Update.
9033         (remote_target::add_current_inferior_and_thread): Update.
9034         * inferior.c (exit_inferior_1): Use "false".
9035         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9036
9037 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9038
9039         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9040         the "start" command.
9041
9042 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9043
9044         * python/py-inferior.c (infpy_thread_from_thread_handle):
9045         Adjust comments to reflect renaming of thread_from_thread_handle
9046         to thread_from_handle.  Adjust keywords.  Fix type error message.
9047         (inferior_object_methods): Add thread_from_handle.  Retain
9048         thread_from_thread_handle, but mark it as deprecated.
9049
9050 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9051
9052         * gdbthread.h (find_thread_by_handle): Revise declaration.
9053         * thread.c (find_thread_by_handle): Likewise.  Adjust
9054         implementation too.
9055         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9056         support for buffer objects as handles.
9057
9058 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9059
9060         * python/py-infthread.c (thpy_thread_handle): New function.
9061         (thread_object_methods): Register thpy_thread_handle.
9062
9063 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9064
9065         * gdbthread.h (thread_to_thread_handle): Declare.
9066         * thread.c (gdbtypes.h): Include.
9067         (thread_to_thread_handle): New function.
9068
9069         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9070         (target_thread_info_to_thread_handle): Declare.
9071         * target.c (target_thread_info_to_thread_handle): New function.
9072         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9073         * target-delegates.c: Regenerate.
9074
9075         * linux-thread-db.c (class thread_db_target): Add method
9076         thread_info_to_thread_handle.
9077         (thread_db_target::thread_info_to_thread_handle): Define.
9078         * remote.c (class remote_target): Add new method
9079         thread_info_to_thread_handle.
9080         (remote_target::thread_info_to_thread_handle): Define.
9081
9082 2019-04-08  Pedro Alves  <palves@redhat.com>
9083
9084         * common/common-exceptions.c (throw_exception): Don't create
9085         named object to throw; throw directly.
9086         (throw_it): Likewise.  Don't initialize gdb_exception::message
9087         here, with new; pass FMT and AP to the ctor instead.
9088         * common/common-exceptions.h: Include <string>.
9089         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9090         const char *, va_list)): New ctor.  Use std::make_shared.
9091         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9092         errors)): Delete.
9093         (gdb_exception_error::gdb_exception_error(enum errors, const char
9094         *, va_list)): New.
9095         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9096         Add assertion.
9097         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9098         errors)): Delete.
9099         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9100         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9101         Add assertion.
9102
9103 2019-04-08  Tom Tromey  <tom@tromey.com>
9104
9105         * valops.c (value_rtti_indirect_type): Replace throw_exception
9106         with throw.
9107         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9108         with throw.
9109         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9110         throw.
9111         * target.c (target_translate_tls_address): Replace throw_exception
9112         with throw.
9113         * stack.c (frame_apply_command_count): Replace throw_exception
9114         with throw.
9115         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9116         throw.
9117         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9118         with throw.
9119         * rs6000-tdep.c (rs6000_frame_cache)
9120         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9121         * remote.c: Replace throw_exception with throw.
9122         * record-full.c (record_full_message, record_full_wait_1)
9123         (record_full_restore): Replace throw_exception with throw.
9124         * record-btrace.c:
9125         (get_thread_current_frame_id, record_btrace_start_replaying)
9126         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9127         (cmd_record_btrace_start): Replace throw_exception with throw.
9128         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9129         throw.
9130         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9131         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9132         * linespec.c:
9133         (find_linespec_symbols): Replace throw_exception with throw.
9134         * infrun.c (displaced_step_prepare, resume): Replace
9135         throw_exception with throw.
9136         * infcmd.c (post_create_inferior): Replace throw_exception with
9137         throw.
9138         * inf-loop.c (inferior_event_handler): Replace throw_exception
9139         with throw.
9140         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9141         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9142         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9143         (get_prev_frame_always, get_frame_pc_if_available)
9144         (get_frame_address_in_block_if_available, get_frame_language):
9145         Replace throw_exception with throw.
9146         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9147         throw_exception with throw.
9148         * eval.c (fetch_subexp_value, evaluate_var_value)
9149         (evaluate_funcall, evaluate_subexp_standard): Replace
9150         throw_exception with throw.
9151         * dwarf2loc.c (call_site_find_chain)
9152         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9153         Replace throw_exception with throw.
9154         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9155         with throw.
9156         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9157         throw.
9158         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9159         * completer.c (complete_line_internal): Replace throw_exception
9160         with throw.
9161         * compile/compile-object-run.c (compile_object_run): Replace
9162         throw_exception with throw.
9163         * cli/cli-script.c (process_next_line): Replace throw_exception
9164         with throw.
9165         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9166         (btrace_enable, btrace_maint_update_pt_packets): Replace
9167         throw_exception with throw.
9168         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9169         throw_exception with throw.
9170         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9171         throw_exception with throw.
9172         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9173         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9174         * aarch64-tdep.c (aarch64_make_prologue_cache)
9175         (aarch64_make_stub_cache): Replace throw_exception with throw.
9176
9177 2019-04-08  Tom Tromey  <tom@tromey.com>
9178
9179         * common/common-exceptions.c (throw_exception): Rename from
9180         throw_exception_cxx.  Remove old copy.  Make argument const.
9181         (throw_it): Create and throw exception objects directly.
9182         * common/common-exceptions.h (throw_exception): Make argument
9183         const.
9184         (struct gdb_exception_error): Add constructor.
9185         (struct gdb_exception_quit): Add constructor.
9186
9187 2019-04-08  Tom Tromey  <tom@tromey.com>
9188
9189         * common/common-exceptions.h (exception_rethrow): Don't declare.
9190         (TRY_SJLJ): Update comment.
9191         (TRY, CATCH, END_CATCH): Remove.
9192         * common/common-exceptions.c (exception_rethrow): Remove.
9193
9194 2019-04-08  Tom Tromey  <tom@tromey.com>
9195
9196         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9197         Remove.
9198         (gdb_exception_error): Rename from
9199         gdb_exception_RETURN_MASK_ERROR.
9200         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9201         (gdb_quit_bad_alloc): Update.
9202         * aarch64-tdep.c: Update.
9203         * ada-lang.c: Update.
9204         * ada-typeprint.c: Update.
9205         * ada-valprint.c: Update.
9206         * amd64-tdep.c: Update.
9207         * arch-utils.c: Update.
9208         * break-catch-throw.c: Update.
9209         * breakpoint.c: Update.
9210         * btrace.c: Update.
9211         * c-varobj.c: Update.
9212         * cli/cli-cmds.c: Update.
9213         * cli/cli-interp.c: Update.
9214         * cli/cli-script.c: Update.
9215         * common/common-exceptions.c: Update.
9216         * common/new-op.c: Update.
9217         * common/selftest.c: Update.
9218         * compile/compile-c-symbols.c: Update.
9219         * compile/compile-cplus-symbols.c: Update.
9220         * compile/compile-object-load.c: Update.
9221         * compile/compile-object-run.c: Update.
9222         * completer.c: Update.
9223         * corelow.c: Update.
9224         * cp-abi.c: Update.
9225         * cp-support.c: Update.
9226         * cp-valprint.c: Update.
9227         * darwin-nat.c: Update.
9228         * disasm-selftests.c: Update.
9229         * dtrace-probe.c: Update.
9230         * dwarf-index-cache.c: Update.
9231         * dwarf-index-write.c: Update.
9232         * dwarf2-frame-tailcall.c: Update.
9233         * dwarf2-frame.c: Update.
9234         * dwarf2loc.c: Update.
9235         * dwarf2read.c: Update.
9236         * eval.c: Update.
9237         * event-loop.c: Update.
9238         * event-top.c: Update.
9239         * exec.c: Update.
9240         * f-valprint.c: Update.
9241         * fbsd-tdep.c: Update.
9242         * frame-unwind.c: Update.
9243         * frame.c: Update.
9244         * gdbtypes.c: Update.
9245         * gnu-v3-abi.c: Update.
9246         * guile/guile-internal.h: Update.
9247         * guile/scm-block.c: Update.
9248         * guile/scm-breakpoint.c: Update.
9249         * guile/scm-cmd.c: Update.
9250         * guile/scm-disasm.c: Update.
9251         * guile/scm-frame.c: Update.
9252         * guile/scm-lazy-string.c: Update.
9253         * guile/scm-math.c: Update.
9254         * guile/scm-param.c: Update.
9255         * guile/scm-ports.c: Update.
9256         * guile/scm-pretty-print.c: Update.
9257         * guile/scm-symbol.c: Update.
9258         * guile/scm-symtab.c: Update.
9259         * guile/scm-type.c: Update.
9260         * guile/scm-value.c: Update.
9261         * i386-linux-tdep.c: Update.
9262         * i386-tdep.c: Update.
9263         * inf-loop.c: Update.
9264         * infcall.c: Update.
9265         * infcmd.c: Update.
9266         * infrun.c: Update.
9267         * jit.c: Update.
9268         * language.c: Update.
9269         * linespec.c: Update.
9270         * linux-fork.c: Update.
9271         * linux-nat.c: Update.
9272         * linux-tdep.c: Update.
9273         * linux-thread-db.c: Update.
9274         * main.c: Update.
9275         * mi/mi-cmd-break.c: Update.
9276         * mi/mi-cmd-stack.c: Update.
9277         * mi/mi-interp.c: Update.
9278         * mi/mi-main.c: Update.
9279         * objc-lang.c: Update.
9280         * p-valprint.c: Update.
9281         * parse.c: Update.
9282         * ppc-linux-tdep.c: Update.
9283         * printcmd.c: Update.
9284         * python/py-arch.c: Update.
9285         * python/py-breakpoint.c: Update.
9286         * python/py-cmd.c: Update.
9287         * python/py-finishbreakpoint.c: Update.
9288         * python/py-frame.c: Update.
9289         * python/py-framefilter.c: Update.
9290         * python/py-gdb-readline.c: Update.
9291         * python/py-inferior.c: Update.
9292         * python/py-infthread.c: Update.
9293         * python/py-lazy-string.c: Update.
9294         * python/py-linetable.c: Update.
9295         * python/py-objfile.c: Update.
9296         * python/py-param.c: Update.
9297         * python/py-prettyprint.c: Update.
9298         * python/py-progspace.c: Update.
9299         * python/py-record-btrace.c: Update.
9300         * python/py-record.c: Update.
9301         * python/py-symbol.c: Update.
9302         * python/py-type.c: Update.
9303         * python/py-unwind.c: Update.
9304         * python/py-utils.c: Update.
9305         * python/py-value.c: Update.
9306         * python/python.c: Update.
9307         * record-btrace.c: Update.
9308         * record-full.c: Update.
9309         * remote-fileio.c: Update.
9310         * remote.c: Update.
9311         * riscv-tdep.c: Update.
9312         * rs6000-aix-tdep.c: Update.
9313         * rs6000-tdep.c: Update.
9314         * rust-exp.y: Update.
9315         * rust-lang.c: Update.
9316         * s390-tdep.c: Update.
9317         * selftest-arch.c: Update.
9318         * solib-dsbt.c: Update.
9319         * solib-frv.c: Update.
9320         * solib-spu.c: Update.
9321         * solib-svr4.c: Update.
9322         * solib.c: Update.
9323         * sparc64-linux-tdep.c: Update.
9324         * stack.c: Update.
9325         * symfile-mem.c: Update.
9326         * symmisc.c: Update.
9327         * target.c: Update.
9328         * thread.c: Update.
9329         * top.c: Update.
9330         * tracefile-tfile.c: Update.
9331         * tui/tui.c: Update.
9332         * typeprint.c: Update.
9333         * unittests/cli-utils-selftests.c: Update.
9334         * unittests/parse-connection-spec-selftests.c: Update.
9335         * valops.c: Update.
9336         * valprint.c: Update.
9337         * value.c: Update.
9338         * varobj.c: Update.
9339         * windows-nat.c: Update.
9340         * x86-linux-nat.c: Update.
9341         * xml-support.c: Update.
9342
9343 2019-04-08  Tom Tromey  <tom@tromey.com>
9344
9345         * xml-support.c: Use C++ exception handling.
9346         * x86-linux-nat.c: Use C++ exception handling.
9347         * windows-nat.c: Use C++ exception handling.
9348         * varobj.c: Use C++ exception handling.
9349         * value.c: Use C++ exception handling.
9350         * valprint.c: Use C++ exception handling.
9351         * valops.c: Use C++ exception handling.
9352         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9353         handling.
9354         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9355         * typeprint.c: Use C++ exception handling.
9356         * tui/tui.c: Use C++ exception handling.
9357         * tracefile-tfile.c: Use C++ exception handling.
9358         * top.c: Use C++ exception handling.
9359         * thread.c: Use C++ exception handling.
9360         * target.c: Use C++ exception handling.
9361         * symmisc.c: Use C++ exception handling.
9362         * symfile-mem.c: Use C++ exception handling.
9363         * stack.c: Use C++ exception handling.
9364         * sparc64-linux-tdep.c: Use C++ exception handling.
9365         * solib.c: Use C++ exception handling.
9366         * solib-svr4.c: Use C++ exception handling.
9367         * solib-spu.c: Use C++ exception handling.
9368         * solib-frv.c: Use C++ exception handling.
9369         * solib-dsbt.c: Use C++ exception handling.
9370         * selftest-arch.c: Use C++ exception handling.
9371         * s390-tdep.c: Use C++ exception handling.
9372         * rust-lang.c: Use C++ exception handling.
9373         * rust-exp.y: Use C++ exception handling.
9374         * rs6000-tdep.c: Use C++ exception handling.
9375         * rs6000-aix-tdep.c: Use C++ exception handling.
9376         * riscv-tdep.c: Use C++ exception handling.
9377         * remote.c: Use C++ exception handling.
9378         * remote-fileio.c: Use C++ exception handling.
9379         * record-full.c: Use C++ exception handling.
9380         * record-btrace.c: Use C++ exception handling.
9381         * python/python.c: Use C++ exception handling.
9382         * python/py-value.c: Use C++ exception handling.
9383         * python/py-utils.c: Use C++ exception handling.
9384         * python/py-unwind.c: Use C++ exception handling.
9385         * python/py-type.c: Use C++ exception handling.
9386         * python/py-symbol.c: Use C++ exception handling.
9387         * python/py-record.c: Use C++ exception handling.
9388         * python/py-record-btrace.c: Use C++ exception handling.
9389         * python/py-progspace.c: Use C++ exception handling.
9390         * python/py-prettyprint.c: Use C++ exception handling.
9391         * python/py-param.c: Use C++ exception handling.
9392         * python/py-objfile.c: Use C++ exception handling.
9393         * python/py-linetable.c: Use C++ exception handling.
9394         * python/py-lazy-string.c: Use C++ exception handling.
9395         * python/py-infthread.c: Use C++ exception handling.
9396         * python/py-inferior.c: Use C++ exception handling.
9397         * python/py-gdb-readline.c: Use C++ exception handling.
9398         * python/py-framefilter.c: Use C++ exception handling.
9399         * python/py-frame.c: Use C++ exception handling.
9400         * python/py-finishbreakpoint.c: Use C++ exception handling.
9401         * python/py-cmd.c: Use C++ exception handling.
9402         * python/py-breakpoint.c: Use C++ exception handling.
9403         * python/py-arch.c: Use C++ exception handling.
9404         * printcmd.c: Use C++ exception handling.
9405         * ppc-linux-tdep.c: Use C++ exception handling.
9406         * parse.c: Use C++ exception handling.
9407         * p-valprint.c: Use C++ exception handling.
9408         * objc-lang.c: Use C++ exception handling.
9409         * mi/mi-main.c: Use C++ exception handling.
9410         * mi/mi-interp.c: Use C++ exception handling.
9411         * mi/mi-cmd-stack.c: Use C++ exception handling.
9412         * mi/mi-cmd-break.c: Use C++ exception handling.
9413         * main.c: Use C++ exception handling.
9414         * linux-thread-db.c: Use C++ exception handling.
9415         * linux-tdep.c: Use C++ exception handling.
9416         * linux-nat.c: Use C++ exception handling.
9417         * linux-fork.c: Use C++ exception handling.
9418         * linespec.c: Use C++ exception handling.
9419         * language.c: Use C++ exception handling.
9420         * jit.c: Use C++ exception handling.
9421         * infrun.c: Use C++ exception handling.
9422         * infcmd.c: Use C++ exception handling.
9423         * infcall.c: Use C++ exception handling.
9424         * inf-loop.c: Use C++ exception handling.
9425         * i386-tdep.c: Use C++ exception handling.
9426         * i386-linux-tdep.c: Use C++ exception handling.
9427         * guile/scm-value.c: Use C++ exception handling.
9428         * guile/scm-type.c: Use C++ exception handling.
9429         * guile/scm-symtab.c: Use C++ exception handling.
9430         * guile/scm-symbol.c: Use C++ exception handling.
9431         * guile/scm-pretty-print.c: Use C++ exception handling.
9432         * guile/scm-ports.c: Use C++ exception handling.
9433         * guile/scm-param.c: Use C++ exception handling.
9434         * guile/scm-math.c: Use C++ exception handling.
9435         * guile/scm-lazy-string.c: Use C++ exception handling.
9436         * guile/scm-frame.c: Use C++ exception handling.
9437         * guile/scm-disasm.c: Use C++ exception handling.
9438         * guile/scm-cmd.c: Use C++ exception handling.
9439         * guile/scm-breakpoint.c: Use C++ exception handling.
9440         * guile/scm-block.c: Use C++ exception handling.
9441         * guile/guile-internal.h: Use C++ exception handling.
9442         * gnu-v3-abi.c: Use C++ exception handling.
9443         * gdbtypes.c: Use C++ exception handling.
9444         * frame.c: Use C++ exception handling.
9445         * frame-unwind.c: Use C++ exception handling.
9446         * fbsd-tdep.c: Use C++ exception handling.
9447         * f-valprint.c: Use C++ exception handling.
9448         * exec.c: Use C++ exception handling.
9449         * event-top.c: Use C++ exception handling.
9450         * event-loop.c: Use C++ exception handling.
9451         * eval.c: Use C++ exception handling.
9452         * dwarf2read.c: Use C++ exception handling.
9453         * dwarf2loc.c: Use C++ exception handling.
9454         * dwarf2-frame.c: Use C++ exception handling.
9455         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9456         * dwarf-index-write.c: Use C++ exception handling.
9457         * dwarf-index-cache.c: Use C++ exception handling.
9458         * dtrace-probe.c: Use C++ exception handling.
9459         * disasm-selftests.c: Use C++ exception handling.
9460         * darwin-nat.c: Use C++ exception handling.
9461         * cp-valprint.c: Use C++ exception handling.
9462         * cp-support.c: Use C++ exception handling.
9463         * cp-abi.c: Use C++ exception handling.
9464         * corelow.c: Use C++ exception handling.
9465         * completer.c: Use C++ exception handling.
9466         * compile/compile-object-run.c: Use C++ exception handling.
9467         * compile/compile-object-load.c: Use C++ exception handling.
9468         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9469         * compile/compile-c-symbols.c: Use C++ exception handling.
9470         * common/selftest.c: Use C++ exception handling.
9471         * common/new-op.c: Use C++ exception handling.
9472         * cli/cli-script.c: Use C++ exception handling.
9473         * cli/cli-interp.c: Use C++ exception handling.
9474         * cli/cli-cmds.c: Use C++ exception handling.
9475         * c-varobj.c: Use C++ exception handling.
9476         * btrace.c: Use C++ exception handling.
9477         * breakpoint.c: Use C++ exception handling.
9478         * break-catch-throw.c: Use C++ exception handling.
9479         * arch-utils.c: Use C++ exception handling.
9480         * amd64-tdep.c: Use C++ exception handling.
9481         * ada-valprint.c: Use C++ exception handling.
9482         * ada-typeprint.c: Use C++ exception handling.
9483         * ada-lang.c: Use C++ exception handling.
9484         * aarch64-tdep.c: Use C++ exception handling.
9485
9486 2019-04-08  Tom Tromey  <tom@tromey.com>
9487
9488         * xml-support.c (gdb_xml_parser::parse): Update.
9489         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9490         * value.c (show_convenience): Update.
9491         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9492         (test_parse_flags_qcs): Update.
9493         * thread.c (thr_try_catch_cmd): Update.
9494         * target.c (target_translate_tls_address): Update.
9495         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9496         (info_frame_command_core, frame_apply_command_count): Update.
9497         * rust-exp.y (rust_lex_exception_test): Update.
9498         * riscv-tdep.c (riscv_print_one_register_info): Update.
9499         * remote.c (remote_target::enable_btrace): Update.
9500         * record-btrace.c (record_btrace_enable_warn): Update.
9501         * python/py-utils.c (gdbpy_convert_exception): Update.
9502         * printcmd.c (do_one_display, print_variable_and_value): Update.
9503         * mi/mi-main.c (mi_print_exception): Update.
9504         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9505         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9506         * linux-nat.c (linux_nat_target::attach): Update.
9507         * linux-fork.c (class scoped_switch_fork_info): Update.
9508         * infrun.c (displaced_step_prepare): Update.
9509         * infcall.c (call_function_by_hand_dummy): Update.
9510         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9511         * gnu-v3-abi.c (print_one_vtable): Update.
9512         * frame.c (get_prev_frame_always): Update.
9513         * f-valprint.c (info_common_command_for_block): Update.
9514         * exec.c (try_open_exec_file): Update.
9515         * exceptions.c (print_exception, exception_print)
9516         (exception_fprintf, exception_print_same): Update.
9517         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9518         * dwarf-index-cache.c (index_cache::store)
9519         (index_cache::lookup_gdb_index): Update.
9520         * darwin-nat.c (maybe_cache_shell): Update.
9521         * cp-valprint.c (cp_print_value_fields): Update.
9522         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9523         (gcc_cplus_symbol_address): Update.
9524         * compile/compile-c-symbols.c (gcc_convert_symbol)
9525         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9526         * common/selftest.c: Update.
9527         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9528         a std::string.
9529         (exception_try_scope_entry, exception_try_scope_exit): Don't
9530         declare.
9531         (struct exception_try_scope): Remove.
9532         (TRY): Don't use exception_try_scope.
9533         (struct gdb_exception): Add constructor, operator=.
9534         <what>: New method.
9535         (struct gdb_exception_RETURN_MASK_ALL)
9536         (struct gdb_exception_RETURN_MASK_ERROR)
9537         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9538         (struct gdb_quit_bad_alloc): Update.
9539         * common/common-exceptions.c (exception_none): Change
9540         initializer.
9541         (struct catcher) <state, exception>: Initialize inline.
9542         <prev>: Remove member.
9543         (current_catcher): Remove.
9544         (catchers): New global.
9545         (exceptions_state_mc_init): Simplify.
9546         (catcher_pop): Remove.
9547         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9548         (try_scope_depth, exception_try_scope_entry)
9549         (exception_try_scope_exit): Remove.
9550         (throw_exception_sjlj): Update.
9551         (exception_messages, exception_messages_size): Remove.
9552         (throw_it): Simplify.
9553         (gdb_exception_sliced_copy): Remove.
9554         (throw_exception_cxx): Update.
9555         * cli/cli-script.c (script_from_file): Update.
9556         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9557         Update.
9558         * ada-valprint.c (ada_val_print): Update.
9559         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9560         (create_excep_cond_exprs): Update.
9561
9562 2019-04-08  Tom Tromey  <tom@tromey.com>
9563
9564         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9565         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9566         (TRY, CATCH, END_CATCH): Remove some definitions.
9567         * common/common-exceptions.c: Don't use GDB_XCPT.
9568         (catcher_list_size): Remove.
9569         (throw_exception, throw_it): Simplify.
9570
9571 2019-04-05  Tom Tromey  <tom@tromey.com>
9572
9573         Revert the header-sorting patch.
9574         * ft32-tdep.c: Revert.
9575         * frv-tdep.c: Revert.
9576         * frv-linux-tdep.c: Revert.
9577         * frame.c: Revert.
9578         * frame-unwind.c: Revert.
9579         * frame-base.c: Revert.
9580         * fork-child.c: Revert.
9581         * findvar.c: Revert.
9582         * findcmd.c: Revert.
9583         * filesystem.c: Revert.
9584         * filename-seen-cache.h: Revert.
9585         * filename-seen-cache.c: Revert.
9586         * fbsd-tdep.c: Revert.
9587         * fbsd-nat.h: Revert.
9588         * fbsd-nat.c: Revert.
9589         * f-valprint.c: Revert.
9590         * f-typeprint.c: Revert.
9591         * f-lang.c: Revert.
9592         * extension.h: Revert.
9593         * extension.c: Revert.
9594         * extension-priv.h: Revert.
9595         * expprint.c: Revert.
9596         * exec.h: Revert.
9597         * exec.c: Revert.
9598         * exceptions.c: Revert.
9599         * event-top.c: Revert.
9600         * event-loop.c: Revert.
9601         * eval.c: Revert.
9602         * elfread.c: Revert.
9603         * dwarf2read.h: Revert.
9604         * dwarf2read.c: Revert.
9605         * dwarf2loc.c: Revert.
9606         * dwarf2expr.h: Revert.
9607         * dwarf2expr.c: Revert.
9608         * dwarf2-frame.c: Revert.
9609         * dwarf2-frame-tailcall.c: Revert.
9610         * dwarf-index-write.h: Revert.
9611         * dwarf-index-write.c: Revert.
9612         * dwarf-index-common.c: Revert.
9613         * dwarf-index-cache.h: Revert.
9614         * dwarf-index-cache.c: Revert.
9615         * dummy-frame.c: Revert.
9616         * dtrace-probe.c: Revert.
9617         * disasm.h: Revert.
9618         * disasm.c: Revert.
9619         * disasm-selftests.c: Revert.
9620         * dictionary.c: Revert.
9621         * dicos-tdep.c: Revert.
9622         * demangle.c: Revert.
9623         * dcache.h: Revert.
9624         * dcache.c: Revert.
9625         * darwin-nat.h: Revert.
9626         * darwin-nat.c: Revert.
9627         * darwin-nat-info.c: Revert.
9628         * d-valprint.c: Revert.
9629         * d-namespace.c: Revert.
9630         * d-lang.c: Revert.
9631         * ctf.c: Revert.
9632         * csky-tdep.c: Revert.
9633         * csky-linux-tdep.c: Revert.
9634         * cris-tdep.c: Revert.
9635         * cris-linux-tdep.c: Revert.
9636         * cp-valprint.c: Revert.
9637         * cp-support.c: Revert.
9638         * cp-namespace.c: Revert.
9639         * cp-abi.c: Revert.
9640         * corelow.c: Revert.
9641         * corefile.c: Revert.
9642         * continuations.c: Revert.
9643         * completer.h: Revert.
9644         * completer.c: Revert.
9645         * complaints.c: Revert.
9646         * coffread.c: Revert.
9647         * coff-pe-read.c: Revert.
9648         * cli-out.h: Revert.
9649         * cli-out.c: Revert.
9650         * charset.c: Revert.
9651         * c-varobj.c: Revert.
9652         * c-valprint.c: Revert.
9653         * c-typeprint.c: Revert.
9654         * c-lang.c: Revert.
9655         * buildsym.c: Revert.
9656         * buildsym-legacy.c: Revert.
9657         * build-id.h: Revert.
9658         * build-id.c: Revert.
9659         * btrace.c: Revert.
9660         * bsd-uthread.c: Revert.
9661         * breakpoint.h: Revert.
9662         * breakpoint.c: Revert.
9663         * break-catch-throw.c: Revert.
9664         * break-catch-syscall.c: Revert.
9665         * break-catch-sig.c: Revert.
9666         * blockframe.c: Revert.
9667         * block.c: Revert.
9668         * bfin-tdep.c: Revert.
9669         * bfin-linux-tdep.c: Revert.
9670         * bfd-target.c: Revert.
9671         * bcache.c: Revert.
9672         * ax-general.c: Revert.
9673         * ax-gdb.h: Revert.
9674         * ax-gdb.c: Revert.
9675         * avr-tdep.c: Revert.
9676         * auxv.c: Revert.
9677         * auto-load.c: Revert.
9678         * arm-wince-tdep.c: Revert.
9679         * arm-tdep.c: Revert.
9680         * arm-symbian-tdep.c: Revert.
9681         * arm-pikeos-tdep.c: Revert.
9682         * arm-obsd-tdep.c: Revert.
9683         * arm-nbsd-tdep.c: Revert.
9684         * arm-nbsd-nat.c: Revert.
9685         * arm-linux-tdep.c: Revert.
9686         * arm-linux-nat.c: Revert.
9687         * arm-fbsd-tdep.c: Revert.
9688         * arm-fbsd-nat.c: Revert.
9689         * arm-bsd-tdep.c: Revert.
9690         * arch-utils.c: Revert.
9691         * arc-tdep.c: Revert.
9692         * arc-newlib-tdep.c: Revert.
9693         * annotate.h: Revert.
9694         * annotate.c: Revert.
9695         * amd64-windows-tdep.c: Revert.
9696         * amd64-windows-nat.c: Revert.
9697         * amd64-tdep.c: Revert.
9698         * amd64-sol2-tdep.c: Revert.
9699         * amd64-obsd-tdep.c: Revert.
9700         * amd64-obsd-nat.c: Revert.
9701         * amd64-nbsd-tdep.c: Revert.
9702         * amd64-nbsd-nat.c: Revert.
9703         * amd64-nat.c: Revert.
9704         * amd64-linux-tdep.c: Revert.
9705         * amd64-linux-nat.c: Revert.
9706         * amd64-fbsd-tdep.c: Revert.
9707         * amd64-fbsd-nat.c: Revert.
9708         * amd64-dicos-tdep.c: Revert.
9709         * amd64-darwin-tdep.c: Revert.
9710         * amd64-bsd-nat.c: Revert.
9711         * alpha-tdep.c: Revert.
9712         * alpha-obsd-tdep.c: Revert.
9713         * alpha-nbsd-tdep.c: Revert.
9714         * alpha-mdebug-tdep.c: Revert.
9715         * alpha-linux-tdep.c: Revert.
9716         * alpha-linux-nat.c: Revert.
9717         * alpha-bsd-tdep.c: Revert.
9718         * alpha-bsd-nat.c: Revert.
9719         * aix-thread.c: Revert.
9720         * agent.c: Revert.
9721         * addrmap.c: Revert.
9722         * ada-varobj.c: Revert.
9723         * ada-valprint.c: Revert.
9724         * ada-typeprint.c: Revert.
9725         * ada-tasks.c: Revert.
9726         * ada-lang.c: Revert.
9727         * aarch64-tdep.c: Revert.
9728         * aarch64-ravenscar-thread.c: Revert.
9729         * aarch64-newlib-tdep.c: Revert.
9730         * aarch64-linux-tdep.c: Revert.
9731         * aarch64-linux-nat.c: Revert.
9732         * aarch64-fbsd-tdep.c: Revert.
9733         * aarch64-fbsd-nat.c: Revert.
9734         * aarch32-linux-nat.c: Revert.
9735
9736 2019-04-05  Tom Tromey  <tom@tromey.com>
9737
9738         * ft32-tdep.c: Sort headers.
9739         * frv-tdep.c: Sort headers.
9740         * frv-linux-tdep.c: Sort headers.
9741         * frame.c: Sort headers.
9742         * frame-unwind.c: Sort headers.
9743         * frame-base.c: Sort headers.
9744         * fork-child.c: Sort headers.
9745         * findvar.c: Sort headers.
9746         * findcmd.c: Sort headers.
9747         * filesystem.c: Sort headers.
9748         * filename-seen-cache.h: Sort headers.
9749         * filename-seen-cache.c: Sort headers.
9750         * fbsd-tdep.c: Sort headers.
9751         * fbsd-nat.h: Sort headers.
9752         * fbsd-nat.c: Sort headers.
9753         * f-valprint.c: Sort headers.
9754         * f-typeprint.c: Sort headers.
9755         * f-lang.c: Sort headers.
9756         * extension.h: Sort headers.
9757         * extension.c: Sort headers.
9758         * extension-priv.h: Sort headers.
9759         * expprint.c: Sort headers.
9760         * exec.h: Sort headers.
9761         * exec.c: Sort headers.
9762         * exceptions.c: Sort headers.
9763         * event-top.c: Sort headers.
9764         * event-loop.c: Sort headers.
9765         * eval.c: Sort headers.
9766         * elfread.c: Sort headers.
9767         * dwarf2read.h: Sort headers.
9768         * dwarf2read.c: Sort headers.
9769         * dwarf2loc.c: Sort headers.
9770         * dwarf2expr.h: Sort headers.
9771         * dwarf2expr.c: Sort headers.
9772         * dwarf2-frame.c: Sort headers.
9773         * dwarf2-frame-tailcall.c: Sort headers.
9774         * dwarf-index-write.h: Sort headers.
9775         * dwarf-index-write.c: Sort headers.
9776         * dwarf-index-common.c: Sort headers.
9777         * dwarf-index-cache.h: Sort headers.
9778         * dwarf-index-cache.c: Sort headers.
9779         * dummy-frame.c: Sort headers.
9780         * dtrace-probe.c: Sort headers.
9781         * disasm.h: Sort headers.
9782         * disasm.c: Sort headers.
9783         * disasm-selftests.c: Sort headers.
9784         * dictionary.c: Sort headers.
9785         * dicos-tdep.c: Sort headers.
9786         * demangle.c: Sort headers.
9787         * dcache.h: Sort headers.
9788         * dcache.c: Sort headers.
9789         * darwin-nat.h: Sort headers.
9790         * darwin-nat.c: Sort headers.
9791         * darwin-nat-info.c: Sort headers.
9792         * d-valprint.c: Sort headers.
9793         * d-namespace.c: Sort headers.
9794         * d-lang.c: Sort headers.
9795         * ctf.c: Sort headers.
9796         * csky-tdep.c: Sort headers.
9797         * csky-linux-tdep.c: Sort headers.
9798         * cris-tdep.c: Sort headers.
9799         * cris-linux-tdep.c: Sort headers.
9800         * cp-valprint.c: Sort headers.
9801         * cp-support.c: Sort headers.
9802         * cp-namespace.c: Sort headers.
9803         * cp-abi.c: Sort headers.
9804         * corelow.c: Sort headers.
9805         * corefile.c: Sort headers.
9806         * continuations.c: Sort headers.
9807         * completer.h: Sort headers.
9808         * completer.c: Sort headers.
9809         * complaints.c: Sort headers.
9810         * coffread.c: Sort headers.
9811         * coff-pe-read.c: Sort headers.
9812         * cli-out.h: Sort headers.
9813         * cli-out.c: Sort headers.
9814         * charset.c: Sort headers.
9815         * c-varobj.c: Sort headers.
9816         * c-valprint.c: Sort headers.
9817         * c-typeprint.c: Sort headers.
9818         * c-lang.c: Sort headers.
9819         * buildsym.c: Sort headers.
9820         * buildsym-legacy.c: Sort headers.
9821         * build-id.h: Sort headers.
9822         * build-id.c: Sort headers.
9823         * btrace.c: Sort headers.
9824         * bsd-uthread.c: Sort headers.
9825         * breakpoint.h: Sort headers.
9826         * breakpoint.c: Sort headers.
9827         * break-catch-throw.c: Sort headers.
9828         * break-catch-syscall.c: Sort headers.
9829         * break-catch-sig.c: Sort headers.
9830         * blockframe.c: Sort headers.
9831         * block.c: Sort headers.
9832         * bfin-tdep.c: Sort headers.
9833         * bfin-linux-tdep.c: Sort headers.
9834         * bfd-target.c: Sort headers.
9835         * bcache.c: Sort headers.
9836         * ax-general.c: Sort headers.
9837         * ax-gdb.h: Sort headers.
9838         * ax-gdb.c: Sort headers.
9839         * avr-tdep.c: Sort headers.
9840         * auxv.c: Sort headers.
9841         * auto-load.c: Sort headers.
9842         * arm-wince-tdep.c: Sort headers.
9843         * arm-tdep.c: Sort headers.
9844         * arm-symbian-tdep.c: Sort headers.
9845         * arm-pikeos-tdep.c: Sort headers.
9846         * arm-obsd-tdep.c: Sort headers.
9847         * arm-nbsd-tdep.c: Sort headers.
9848         * arm-nbsd-nat.c: Sort headers.
9849         * arm-linux-tdep.c: Sort headers.
9850         * arm-linux-nat.c: Sort headers.
9851         * arm-fbsd-tdep.c: Sort headers.
9852         * arm-fbsd-nat.c: Sort headers.
9853         * arm-bsd-tdep.c: Sort headers.
9854         * arch-utils.c: Sort headers.
9855         * arc-tdep.c: Sort headers.
9856         * arc-newlib-tdep.c: Sort headers.
9857         * annotate.h: Sort headers.
9858         * annotate.c: Sort headers.
9859         * amd64-windows-tdep.c: Sort headers.
9860         * amd64-windows-nat.c: Sort headers.
9861         * amd64-tdep.c: Sort headers.
9862         * amd64-sol2-tdep.c: Sort headers.
9863         * amd64-obsd-tdep.c: Sort headers.
9864         * amd64-obsd-nat.c: Sort headers.
9865         * amd64-nbsd-tdep.c: Sort headers.
9866         * amd64-nbsd-nat.c: Sort headers.
9867         * amd64-nat.c: Sort headers.
9868         * amd64-linux-tdep.c: Sort headers.
9869         * amd64-linux-nat.c: Sort headers.
9870         * amd64-fbsd-tdep.c: Sort headers.
9871         * amd64-fbsd-nat.c: Sort headers.
9872         * amd64-dicos-tdep.c: Sort headers.
9873         * amd64-darwin-tdep.c: Sort headers.
9874         * amd64-bsd-nat.c: Sort headers.
9875         * alpha-tdep.c: Sort headers.
9876         * alpha-obsd-tdep.c: Sort headers.
9877         * alpha-nbsd-tdep.c: Sort headers.
9878         * alpha-mdebug-tdep.c: Sort headers.
9879         * alpha-linux-tdep.c: Sort headers.
9880         * alpha-linux-nat.c: Sort headers.
9881         * alpha-bsd-tdep.c: Sort headers.
9882         * alpha-bsd-nat.c: Sort headers.
9883         * aix-thread.c: Sort headers.
9884         * agent.c: Sort headers.
9885         * addrmap.c: Sort headers.
9886         * ada-varobj.c: Sort headers.
9887         * ada-valprint.c: Sort headers.
9888         * ada-typeprint.c: Sort headers.
9889         * ada-tasks.c: Sort headers.
9890         * ada-lang.c: Sort headers.
9891         * aarch64-tdep.c: Sort headers.
9892         * aarch64-ravenscar-thread.c: Sort headers.
9893         * aarch64-newlib-tdep.c: Sort headers.
9894         * aarch64-linux-tdep.c: Sort headers.
9895         * aarch64-linux-nat.c: Sort headers.
9896         * aarch64-fbsd-tdep.c: Sort headers.
9897         * aarch64-fbsd-nat.c: Sort headers.
9898         * aarch32-linux-nat.c: Sort headers.
9899
9900 2019-04-04  Tom Tromey  <tom@tromey.com>
9901
9902         * varobj.c (varobj_create): Update.
9903         * rust-exp.y (struct rust_parser) <update_innermost_block,
9904         lookup_symbol>: New methods.
9905         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9906         Rename.
9907         (rust_parser::rust_lookup_type)
9908         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9909         * printcmd.c (display_command, do_one_display): Update.
9910         * parser-defs.h (struct parser_state) <parser_state>: Add
9911         "tracker" parameter.
9912         (block_tracker): New member.
9913         (class innermost_block_tracker) <innermost_block_tracker>: Add
9914         "types" parameter.
9915         <reset>: Remove method.
9916         (innermost_block): Don't declare.
9917         (null_post_parser): Update.
9918         * parse.c (innermost_block): Remove global.
9919         (write_dollar_variable): Update.
9920         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9921         Remove "tracker_types" parameter.
9922         (parse_expression): Add "tracker" parameter.
9923         (parse_expression_for_completion): Update.
9924         (null_post_parser): Add "tracker" parameter.
9925         * p-exp.y: Update rules.
9926         * m2-exp.y: Update rules.
9927         * language.h (struct language_defn) <la_post_parser>: Add
9928         "tracker" parameter.
9929         * go-exp.y: Update rules.
9930         * f-exp.y: Update rules.
9931         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9932         parameter.
9933         * d-exp.y: Update rules.
9934         * c-exp.y: Update rules.
9935         * breakpoint.c (set_breakpoint_condition): Create an
9936         innermost_block_tracker.
9937         (watch_command_1): Likewise.
9938         * ada-lang.c (resolve): Add "tracker" parameter.
9939         (resolve_subexp): Likewise.
9940         * ada-exp.y (write_var_from_sym): Update.
9941
9942 2019-04-04  Tom Tromey  <tom@tromey.com>
9943
9944         * type-stack.h: New file.
9945         * type-stack.c: New file.
9946         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9947         type-stack.h.
9948         (insert_into_type_stack, insert_type, push_type, push_type_int)
9949         (insert_type_address_space, pop_type, pop_type_int)
9950         (pop_typelist, pop_type_stack, append_type_stack)
9951         (push_type_stack, get_type_stack, push_typelist)
9952         (follow_type_instance_flags, follow_types): Don't declare.
9953         * parse.c (type_stack): Remove global.
9954         (parse_exp_in_context): Update.
9955         (insert_into_type_stack, insert_type, push_type, push_type_int)
9956         (insert_type_address_space, pop_type, pop_type_int)
9957         (pop_typelist, pop_type_stack, append_type_stack)
9958         (push_type_stack, get_type_stack, push_typelist)
9959         (follow_type_instance_flags, follow_types): Remove (moved to
9960         type-stack.c).
9961         * f-exp.y (type_stack): New global.
9962         Update rules.
9963         (push_kind_type, f_parse): Update.
9964         * d-exp.y (type_stack): New global.
9965         Update rules.
9966         (d_parse): Update.
9967         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9968         Update rules.
9969         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9970         (HFILES_NO_SRCDIR): Add type-stack.h.
9971
9972 2019-04-04  Tom Tromey  <tom@tromey.com>
9973
9974         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9975         (rust_parser::convert_ast_to_expression, rust_parse)
9976         (rust_lex_test_completion, rust_lex_tests): Update.
9977         * parser-defs.h (struct expr_completion_state): New.
9978         (struct parser_state) <parser_state>: Add completion parameter.
9979         <mark_struct_expression, mark_completion_tag>: New methods.
9980         <parse_completion, m_completion_state>: New members.
9981         (prefixify_expression, null_post_parser): Update.
9982         (mark_struct_expression, mark_completion_tag): Don't declare.
9983         * parse.c (parse_completion, expout_last_struct)
9984         (expout_tag_completion_type, expout_completion_name): Remove
9985         globals.
9986         (parser_state::mark_struct_expression)
9987         (parser_state::mark_completion_tag): Now methods.
9988         (prefixify_expression): Add last_struct parameter.
9989         (prefixify_subexp): Likewise.
9990         (parse_exp_1): Update.
9991         (parse_exp_in_context): Add cstate parameter.  Update.
9992         (parse_expression_for_completion): Create an
9993         expr_completion_state.
9994         (null_post_parser): Add "completion" parameter.
9995         * p-exp.y: Update rules.
9996         (yylex): Update.
9997         * language.h (struct language_defn) <la_post_parser>: Add
9998         "completing" parameter.
9999         * go-exp.y: Update rules.
10000         (lex_one_token): Update.
10001         * expression.h (parse_completion): Don't declare.
10002         * d-exp.y: Update rules.
10003         (lex_one_token): Update rules.
10004         * c-exp.y: Update rules.
10005         (lex_one_token): Update.
10006         * ada-lang.c (resolve): Add "parse_completion" parameter.
10007         (resolve_subexp): Likewise.
10008         (ada_resolve_function): Likewise.
10009
10010 2019-04-04  Tom Tromey  <tom@tromey.com>
10011
10012         * parser-defs.h (struct parser_state) <start_arglist,
10013         end_arglist>: New methods.
10014         <arglist_len, m_funcall_chain>: New members.
10015         (arglist_len, start_arglist, end_arglist): Don't declare.
10016         * parse.c (arglist_len, funcall_chain): Remove global.
10017         (start_arglist, end_arglist): Remove functions.
10018         (parse_exp_in_context): Update.
10019         * p-exp.y: Update rules.
10020         * m2-exp.y: Update rules.
10021         * go-exp.y: Update rules.
10022         * f-exp.y: Update rules.
10023         * d-exp.y: Update rules.
10024         * c-exp.y: Update rules.
10025
10026 2019-04-04  Tom Tromey  <tom@tromey.com>
10027
10028         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10029         lex_operator, push_back>: New methods.
10030         Update all rules.
10031         (rust_parser::lex_hex, lex_escape): Rename and update.
10032         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10033         (rust_parser::lex_operator): Rename and update.
10034         (rust_parser::lex_number, rustyylex, rustyyerror)
10035         (rust_lex_test_init, rust_lex_test_sequence)
10036         (rust_lex_test_push_back, rust_lex_tests): Update.
10037         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10038         parameter.
10039         <lexptr, prev_lexptr>: New members.
10040         (lexptr, prev_lexptr): Don't declare.
10041         * parse.c (lexptr, prev_lexptr): Remove globals.
10042         (parse_exp_in_context): Update.
10043         * p-exp.y (yylex, yyerror): Update.
10044         * m2-exp.y (parse_number, yylex, yyerror): Update.
10045         * go-exp.y (lex_one_token, yyerror): Update.
10046         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10047         * d-exp.y (lex_one_token, yyerror): Update.
10048         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10049         (lex_one_token, yyerror): Update.
10050         * ada-lex.l (YY_INPUT): Update.
10051         (rewind_to_char): Update.
10052         * ada-exp.y (yyerror): Update.
10053
10054 2019-04-04  Tom Tromey  <tom@tromey.com>
10055
10056         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10057         * parser-defs.h (struct parser_state) <parser_state>: Add new
10058         parameter.
10059         <comma_terminates>: New member.
10060         (comma_terminates): Don't declare global.
10061         * parse.c (comma_terminates): Remove global.
10062         (parse_exp_in_context): Update.
10063         * p-exp.y (yylex): Update.
10064         * m2-exp.y (yylex): Update.
10065         * go-exp.y (lex_one_token): Update.
10066         * f-exp.y (yylex): Update.
10067         * d-exp.y (lex_one_token): Update.
10068         * c-exp.y (lex_one_token): Update.
10069         * ada-lex.l: Update.
10070
10071 2019-04-04  Tom Tromey  <tom@tromey.com>
10072
10073         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10074         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10075         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10076         * parser-defs.h (paren_depth): Don't declare.
10077         * parse.c (paren_depth): Remove global.
10078         (parse_exp_in_context): Update.
10079         * p-exp.y (paren_depth): New global.
10080         (pascal_parse): Initialize it.
10081         * m2-exp.y (paren_depth): New global.
10082         (m2_parse): Initialize it.
10083         * go-exp.y (paren_depth): New global.
10084         (go_parse): Initialize it.
10085         * f-exp.y (paren_depth): New global.
10086         (f_parse): Initialize it.
10087         * d-exp.y (paren_depth): New global.
10088         (d_parse): Initialize it.
10089         * c-exp.y (paren_depth): New global.
10090         (c_parse): Initialize it.
10091         * ada-lex.l (paren_depth): New global.
10092         (lexer_init): Initialize it.
10093
10094 2019-04-04  Tom Tromey  <tom@tromey.com>
10095
10096         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10097         (rust_parser::convert_ast_to_type)
10098         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10099         * parser-defs.h (struct parser_state) <parser_state>: Add
10100         parameters.  Initialize new members.
10101         <expression_context_block, expression_context_pc>: New members.
10102         * parse.c (expression_context_block, expression_context_pc):
10103         Remove globals.
10104         (parse_exp_in_context): Update.
10105         * p-exp.y: Update all rules.
10106         (yylex): Update.
10107         * m2-exp.y: Update all rules.
10108         (yylex): Update.
10109         * go-exp.y (yylex): Update.
10110         * f-exp.y (yylex): Update.
10111         * d-exp.y: Update all rules.
10112         (yylex): Update.
10113         * c-exp.y: Update all rules.
10114         (lex_one_token, classify_name, yylex, c_parse): Update.
10115         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10116
10117 2019-04-04  Tom Tromey  <tom@tromey.com>
10118
10119         * gdbarch.h, gdbarch.c: Rebuild.
10120         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10121         * stap-probe.h:
10122         (struct stap_parse_info): Replace "parser_state" with
10123         "expr_builder".
10124         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10125         (parser_state): New class.
10126         * parse.c (expr_builder): Rename.
10127         (expr_builder::release): Rename.
10128         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10129         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10130         (write_exp_elt_longcst, write_exp_elt_floatcst)
10131         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10132         (write_exp_string_vector, write_exp_bitstring)
10133         (write_exp_msymbol, mark_struct_expression)
10134         (write_dollar_variable)
10135         (insert_type_address_space, increase_expout_size): Replace
10136         "parser_state" with "expr_builder".
10137         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10138         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10139         "parser_state" with "expr_builder".
10140
10141 2019-04-04  Tom Tromey  <tom@tromey.com>
10142
10143         * rust-exp.y: Replace "parse_language" with method call.
10144         * p-exp.y:
10145         (yylex): Replace "parse_language" with method call.
10146         * m2-exp.y:
10147         (yylex): Replace "parse_language" with method call.
10148         * go-exp.y (classify_name): Replace "parse_language" with method
10149         call.
10150         * f-exp.y (yylex): Replace "parse_language" with method call.
10151         * d-exp.y (lex_one_token): Replace "parse_language" with method
10152         call.
10153         * c-exp.y:
10154         (lex_one_token, classify_name, yylex): Replace "parse_language"
10155         with method call.
10156         * ada-exp.y (find_primitive_type, type_char)
10157         (type_system_address): Replace "parse_language" with method call.
10158
10159 2019-04-04  Tom Tromey  <tom@tromey.com>
10160
10161         * rust-exp.y: Replace "parse_gdbarch" with method call.
10162         * parse.c (write_dollar_variable, insert_type_address_space):
10163         Replace "parse_gdbarch" with method call.
10164         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10165         call.
10166         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10167         call.
10168         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10169         "parse_gdbarch" with method call.
10170         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10171         with method call.
10172         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10173         "parse_gdbarch" with method call.
10174         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10175         "parse_gdbarch" with method call.
10176         * c-exp.y (parse_type, parse_number, classify_name): Replace
10177         "parse_gdbarch" with method call.
10178         * ada-lex.l: Replace "parse_gdbarch" with method call.
10179         * ada-exp.y (parse_type, find_primitive_type, type_char)
10180         (type_system_address): Replace "parse_gdbarch" with method call.
10181
10182 2019-04-04  Tom Tromey  <tom@tromey.com>
10183
10184         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10185         * stap-probe.c (stap_parse_argument): Update.
10186         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10187         initial_size parameter.
10188         * rust-exp.y (rust_lex_tests): Update.
10189         * parse.c (parser_state): Update.
10190         (parse_exp_in_context): Update.
10191         * parser-defs.h (struct parser_state) <parser_state>: Remove
10192         "initial_size" parameter.
10193
10194 2019-04-04  Tom Tromey  <tom@tromey.com>
10195
10196         * parser-defs.h (increase_expout_size): Don't declare.
10197         * parse.c (increase_expout_size): Now static.
10198
10199 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10200
10201         * gnu-nat.c (gnu_nat_target::wait): Fix
10202         target_waitstatus_to_string call.
10203
10204 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10205
10206         * eval.c (evaluate_subexp_standard): Handle internal functions
10207         during Fortran function call handling.
10208
10209 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10210
10211         * NEWS: Mention new internal functions.
10212         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10213         (read_base_type): Use dwarf2_init_complex_target_type.
10214         * value.c (creal_internal_fn): New function.
10215         (cimag_internal_fn): New function.
10216         (_initialize_values): Register new internal functions.
10217
10218 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10219
10220         * infrun.c (stop_all_threads): If debug_infrun, always
10221         trace the wait status after wait_one, using
10222         target_waitstatus_to_string and target_pid_to_str.
10223         (handle_inferior_event): Replace various trace of
10224         wait status kind by a single trace.
10225         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10226         wait status kind image by target_waitstatus_to_string.
10227         * target/waitstatus.c (target_waitstatus_to_string): Fix
10228         obsolete comment.
10229
10230 2019-04-01  Tom Tromey  <tromey@adacore.com>
10231
10232         PR symtab/23331:
10233         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10234
10235 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10236             Pedro Alves  <palves@redhat.com>
10237
10238         * top.c (quit_force): Call 'finalize_values'.
10239         * value.c (finalize_values): New function.
10240         * value.h (finalize_values): Declare.
10241
10242 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10243
10244         * NEWS: Announce $_gdb_major and $_gdb_minor.
10245
10246         * top.c (init_gdb_version_vars): New function.
10247         (gdb_init): Call init_gdb_version_vars.
10248
10249 2019-03-29  Tom Tromey  <tromey@adacore.com>
10250
10251         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10252         help text.  Remove dead code.
10253
10254 2019-03-29  Keith Seitz  <keiths@redhat.com>
10255
10256         From Siddhesh Poyarekar:
10257         * f-lang.h (f77_get_upperbound): Return LONGEST.
10258         (f77_get_lowerbound): Likewise.
10259         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10260         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10261         print them.
10262         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10263         plongest to format print it.
10264         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10265         (f77_get_upperbound): Likewise.
10266         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10267         LOWER_BOUND to LONGEST.
10268         (f77_create_arrayprint_offset_tbl): Likewise.
10269
10270 2019-03-29  Keith Seitz  <keiths@redhat.com>
10271
10272         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10273         %s/pulongest for TYPE_LENGTH instead of %d in format
10274         strings.
10275         * ada-typerint.c (ada_print_type): Likewise.
10276         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10277         * compile/compile-c-support.c (generate_register_struct): Likewise.
10278         * gdbtypes.c (recursive_dump_type): Likewise.
10279         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10280         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10281         instead of %d in format strings.
10282         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10283         to std::min to ULONGEST.
10284         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10285         instead of %d in format strings.
10286         * tracepoint.c (info_scope_command): Likewise.
10287         * typeprint.c (print_offset_data::update)
10288         (print_offset_data::finish): Likewise.
10289         * xtensa-tdep.c (xtensa_store_return_value)
10290         (xtensa_push_dummy_call): Likewise.
10291
10292 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10293
10294         * windows-nat.c (display_selector): Fixed format specifications
10295         for 64-bit Cygwin.
10296
10297 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10300
10301 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10302
10303         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10304         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10305         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10306         (nios2_linux_init_abi): Install it.
10307
10308 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10309
10310         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10311
10312 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10313
10314         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10315
10316 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10317             Tom Tromey  <tromey@adacore.com>
10318
10319         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10320
10321 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10322
10323         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10324         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10325         method to compute the bounds of range types. Also print "[evaluated]"
10326         if the bounds' values come from a dynamic evaluation.
10327
10328 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10329
10330         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10331         whitespace when pretty printing is on.
10332
10333 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10334
10335         * ppc-linux-nat.c: Add include.
10336
10337 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10338
10339         * NEWS: Mention AArch64 Pointer Authentication.
10340
10341 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10342
10343         * arm-linux-nat.c: Add include.
10344
10345 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10346
10347         * source-cache.c (source_cache::get_source_lines): Re-read
10348         fullname after calling open_source_file.
10349
10350 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10351
10352         * NEWS: Mention TLS support for FreeBSD.
10353
10354 2019-03-25  Tom Tromey  <tromey@adacore.com>
10355
10356         * minsyms.c (BUNCH_SIZE): Update comment.
10357         (~minimal_symbol_reader): Remove old comment.
10358         (compact_minimal_symbols): Update comment.
10359         (minimal_symbol_reader::install): Remove old comment.  Update
10360         other comments.
10361
10362 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10363
10364         * s390-linux-nat.c: Add include.
10365
10366 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10367
10368         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10369         Call linux_get_hwcap.
10370         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10371         Likewise.
10372         (aarch64_linux_get_hwcap): Remove function.
10373         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10374         declaration.
10375         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10376         linux_get_hwcap.
10377         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10378         * linux-tdep.c (linux_get_hwcap): Add function.
10379         (linux_get_hwcap2): Likewise.
10380         * linux-tdep.h (linux_get_hwcap): Add declaration.
10381         (linux_get_hwcap2): Likewise.
10382         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10383         (ppc_linux_get_hwcap2): Likewise.
10384         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10385         linux_get_hwcap.
10386         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10387         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10388         (ppc_linux_nat_target::read_description): Likewise.
10389         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10390         * s390-linux-nat.c: Likewise.
10391         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10392
10393 2019-03-24  Tom Tromey  <tom@tromey.com>
10394
10395         * ada-lang.c (standard_lookup): Simplify initialization.
10396         (ada_lookup_symbol_nonlocal): Simplify return.
10397         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10398         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10399         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10400         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10401         initialization.
10402         * solib.c (solib_global_lookup): Simplify.
10403         * symtab.c (null_block_symbol): Remove.
10404         (symbol_cache_lookup): Simplify returns.
10405         (lookup_language_this): Simplify returns.
10406         (lookup_symbol_aux): Simplify return.
10407         (lookup_local_symbol): Simplify returns.
10408         (lookup_global_symbol_from_objfile): Simplify return.
10409         (lookup_symbol_in_objfile_symtabs)
10410         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10411         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10412         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10413         * cp-namespace.c (cp_lookup_bare_symbol)
10414         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10415         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10416         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10417         (cp_lookup_symbol_via_imports): Simplify initialization.
10418         (find_symbol_in_baseclass): Likewise.
10419         * symtab.h (null_block_symbol): Remove.
10420         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10421         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10422         (d_lookup_symbol_module): Likewise.
10423         (find_symbol_in_baseclass): Simplify initialization.
10424
10425 2019-03-24  Tom Tromey  <tom@tromey.com>
10426
10427         * expression.h: Don't include symtab.h.
10428         (struct block): Forward declare.
10429
10430 2019-03-24  Tom Tromey  <tom@tromey.com>
10431
10432         * c-exp.y (typebase): Remove casts.
10433         * gdbtypes.c (lookup_unsigned_typename, )
10434         (lookup_signed_typename): Remove cast.
10435         * eval.c (parse_to_comma_and_eval): Remove cast.
10436         * parse.c (write_dollar_variable): Remove cast.
10437         * block.h (struct block) <superblock>: Now const.
10438         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10439         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10440         (map_block): Make "block" const.
10441         * symfile.h (struct quick_symbol_functions)
10442         <map_matching_symbols>: Constify block argument to "callback".
10443         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10444         const.
10445         (find_pc_sect_compunit_symtab): Make "b" const.
10446         (find_symbol_at_address): Likewise.
10447         (search_symbols): Likewise.
10448         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10449         (dw2_debug_names_lookup_symbol): Likewise.
10450         (dw2_map_matching_symbols): Update.
10451         * p-valprint.c (pascal_val_print): Remove "block".
10452         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10453         (aux_add_nonlocal_symbols): Make "block" const.
10454         (resolve_subexp): Remove cast.
10455         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10456         const.
10457         (iterate_over_file_blocks): Likewise.
10458         * f-exp.y (%union) <bval>: Remove.
10459         * coffread.c (patch_opaque_types): Make "b" const.
10460         * spu-tdep.c (spu_catch_start): Make "block" const.
10461         * c-valprint.c (print_unpacked_pointer): Remove "block".
10462         * symmisc.c (dump_symtab_1): Make "b" const.
10463         (block_depth): Make "block" const.
10464         * d-exp.y (%union) <bval>: Remove.
10465         * cp-support.h (cp_lookup_rtti_type): Update.
10466         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10467         * psymtab.c (psym_lookup_symbol): Make "block" const.
10468         (maintenance_check_psymtabs): Make "b" const.
10469         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10470         (enumerate_locals, enumerate_args): Update.
10471         * python/py-symtab.c (stpy_global_block): Make "block" const.
10472         (stpy_static_block): Likewise.
10473         * inline-frame.c (block_starting_point_at): Make "new_block"
10474         const.
10475         * block.c (find_block_in_blockvector): Make return type const.
10476         (blockvector_for_pc_sect): Make "b" const.
10477         (find_block_in_blockvector): Make "b" const.
10478
10479 2019-03-23  Tom Tromey  <tom@tromey.com>
10480
10481         * varobj.c (varobj_create): Update.
10482         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10483         * printcmd.c (display_command, do_one_display): Don't reset
10484         innermost_block.
10485         * parser-defs.h (enum innermost_block_tracker_type): Move to
10486         expression.h.
10487         (innermost_block): Update comment.
10488         * parse.c (parse_exp_1): Add tracker_types parameter.
10489         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10490         tracker_types parameter.  Reset innermost_block.
10491         (parse_exp_in_context): Remove.
10492         (parse_expression_for_completion): Update.
10493         * objfiles.c (~objfile): Don't reset expression_context_block or
10494         innermost_block.
10495         * expression.h (enum innermost_block_tracker_type): Move from
10496         parser-defs.h.
10497         (parse_exp_1): Add tracker_types parameter.
10498         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10499         reset innermost_block.
10500
10501 2019-03-23  Tom Tromey  <tom@tromey.com>
10502
10503         * objfiles.h: Include bcache.h.
10504
10505 2019-03-23  Tom Tromey  <tom@tromey.com>
10506
10507         * linespec.c (get_current_search_block): Use
10508         scoped_restore_current_language.
10509         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10510
10511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10512             Jiong Wang  <jiong.wang@arm.com>
10513
10514         * aarch64-linux-tdep.c
10515         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10516         section.
10517         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10518
10519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10520             Jiong Wang  <jiong.wang@arm.com>
10521
10522         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10523         instructions.
10524         (aarch64_analyze_prologue_test): Add PACIASP test.
10525         (aarch64_prologue_prev_register): Unmask PC value.
10526
10527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10528             Jiong Wang  <jiong.wang@arm.com>
10529
10530         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10531         (aarch64_dwarf2_prev_register): Unmask PC value.
10532         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10533         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10534         DW_CFA_AARCH64_negate_ra_state.
10535         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10536
10537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10538             Jiong Wang  <jiong.wang@arm.com>
10539
10540         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10541         registers.
10542         (aarch64_pseudo_register_name): Likewise.
10543         (aarch64_pseudo_register_type): Likewise.
10544         (aarch64_pseudo_register_reggroup_p): Likewise.
10545         (aarch64_gdbarch_init): Add pauth registers.
10546         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10547         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10548         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10549         (struct gdbarch_tdep): Add regnum for ra_state.
10550
10551 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10552             Jiong Wang  <jiong.wang@arm.com>
10553
10554         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10555
10556 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10557             Jiong Wang  <jiong.wang@arm.com>
10558
10559         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10560         function.
10561         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10562         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10563         (aarch64_gdbarch_init): Add puth registers.
10564         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10565         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10566         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10567
10568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10569             Jiong Wang  <jiong.wang@arm.com>
10570
10571         * aarch64-linux-nat.c
10572         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10573         * aarch64-linux-tdep.c
10574         (aarch64_linux_core_read_description): Likewise.
10575         (aarch64_linux_get_hwcap): New function.
10576         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10577         (aarch64_linux_get_hwcap): New declaration.
10578
10579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10580             Jiong Wang  <jiong.wang@arm.com>
10581
10582         * aarch64-linux-nat.c
10583         (aarch64_linux_nat_target::read_description): Add pauth param.
10584         * aarch64-linux-tdep.c
10585         (aarch64_linux_core_read_description): Likewise.
10586         * aarch64-tdep.c (struct target_desc): Add in pauth.
10587         (aarch64_read_description): Add pauth param.
10588         (aarch64_gdbarch_init): Likewise.
10589         * aarch64-tdep.h (aarch64_read_description): Likewise.
10590         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10591         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10592         * features/Makefile: Add new files.
10593         * features/aarch64-pauth.c: New file.
10594         * features/aarch64-pauth.xml: New file.
10595
10596 2019-03-20  Tom Tromey  <tromey@adacore.com>
10597
10598         * infrun.c (handle_inferior_event): Rename from
10599         handle_inferior_event_1.  Create a scoped_value_mark.
10600         (handle_inferior_event): Remove.
10601
10602 2019-03-19  Tom Tromey  <tromey@adacore.com>
10603
10604         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10605         * infrun.h (print_stop_event): Add "displays" parameter.
10606         * infrun.c (print_stop_event): Add "displays" parameter.
10607
10608 2019-03-19  Pedro Alves  <palves@redhat.com>
10609
10610         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10611         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10612         to -1.  Fix TABs vs spaces.
10613         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10614         * tui/tui-out.h (tui_ui_out) Add intro comments.
10615         <m_line, m_start_of_line>: In-class initialize, and add describing
10616         comment.
10617
10618 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10619
10620         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10621         variable names.
10622         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10623
10624 2019-03-18  Pedro Alves  <palves@redhat.com>
10625             Eli Zaretskii <eliz@gnu.org>
10626
10627         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10628         m_line and m_start_of_line.
10629
10630 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10631
10632         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10633         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10634         it returns a newline.  This fixes a regression in TU mode, whereby
10635         the next line is output on the same screen line as the user input.
10636
10637 2019-03-18  Tom Tromey  <tromey@adacore.com>
10638
10639         * minsyms.c (minimal_symbol_reader::install): Remove call to
10640         obstack_blank.
10641
10642 2019-03-18  Pedro Alves  <palves@redhat.com>
10643
10644         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10645         New globals.
10646         (apply_style): New, factored out from ...
10647         (apply_ansi_escape): ... this.  Handle reverse video mode.
10648         (tui_set_reverse_mode): New function.
10649         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10650         * tui/tui-winsource.c (tui_show_source_line): Use
10651         tui_set_reverse_mode instead of setting A_STANDOUT.
10652         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10653         New setter methods.
10654
10655 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10656
10657         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10658         Handle tabs.
10659
10660 2019-03-18  Tom Tromey  <tromey@adacore.com>
10661
10662         * ada-lang.c (empty_array): Add "high" parameter.
10663         (ada_evaluate_subexp): Update.
10664
10665 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10666
10667         * unittests/string_view-selftests.c: Define
10668         _initialize_string_view_selftests unconditionally.
10669
10670 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10671
10672         PR gdb/24350
10673         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10674
10675 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10676
10677         PR gdb/24351
10678         * windows-nat.c (display_selector): Fix format specifiers.
10679
10680 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10681
10682         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10683         tui_refill_source_window instead of tui_refresh_win, to update the
10684         current execution line.  This fixes redisplay of the current line
10685         when stepping through the code with "next" or "step".
10686
10687 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10688
10689         * source-cache.c (source_cache::get_source_lines): Call
10690         find_source_lines to initialize s->nlines.  This fixes vertical
10691         scrolling of TUI source window when the DOWN arrow is pressed.
10692
10693 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10694
10695         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10696         linux-thread-db.c (_initialize_thread_db): Likewise.
10697
10698 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10699
10700         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10701         wclrtoeol in tui_show_source_line".  This reverts changes made in
10702         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10703
10704 2019-03-15  Tom Tromey  <tom@tromey.com>
10705
10706         * symtab.h (struct minimal_symbol): Derive from
10707         general_symbol_info.
10708         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10709         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10710         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10711         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10712         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10713         (MSYMBOL_SEARCH_NAME): Update.
10714         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10715         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10716         * minsyms.c (minimal_symbol_reader::record_full): Update.
10717
10718 2019-03-15  Tom Tromey  <tom@tromey.com>
10719
10720         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10721
10722 2019-03-15  Tom Tromey  <tom@tromey.com>
10723
10724         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10725         unique_xmalloc_ptr.
10726         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10727         Update.
10728         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10729         (build_minimal_symbol_hash_tables)
10730         (minimal_symbol_reader::install): Update.
10731
10732 2019-03-15  Tom Tromey  <tom@tromey.com>
10733
10734         * symtab.c (create_demangled_names_hash): Update.
10735         (symbol_set_names): Update.
10736         * objfiles.h (struct objfile_per_bfd_storage)
10737         <demangled_names_hash>: Now an htab_up.
10738         * objfiles.c (objfile_per_bfd_storage): Simplify.
10739
10740 2019-03-15  Tom Tromey  <tom@tromey.com>
10741
10742         * objfiles.h (struct objfile_per_bfd_storage): Declare
10743         destructor.
10744         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10745         New.
10746         (get_objfile_bfd_data): Use new.  Don't initialize
10747         language_of_main.
10748         (free_objfile_per_bfd_storage): Remove.
10749         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10750
10751 2019-03-15  Tom Tromey  <tom@tromey.com>
10752
10753         * symfile.c (reread_symbols): Update.
10754         * objfiles.c (objfile::objfile): Update.
10755         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10756         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10757         comment.
10758         (minimal_symbol_reader::install): Update.
10759         (terminate_minimal_symbol_table): Remove.
10760         * jit.c (jit_object_close_impl): Update.
10761
10762 2019-03-15  Tom Tromey  <tom@tromey.com>
10763
10764         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10765         initializations.
10766
10767 2019-03-15  Tom Tromey  <tom@tromey.com>
10768
10769         * objfiles.h (struct objfile_per_bfd_storage)
10770         <demangled_hash_languages>: Now a bitset.
10771         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10772         (lookup_minimal_symbol): Update.
10773
10774 2019-03-15  Tom Tromey  <tom@tromey.com>
10775
10776         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10777         Don't return the symbol.
10778         * coffread.c (record_minimal_symbol): Use record_full.
10779
10780 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10781
10782         The MS-Windows port of ncurses fails to switch to a color pair if
10783         one or both of the colors are the implicit default colors.  This
10784         change records the default colors when TUI is initialized, and
10785         then specifies them explicitly when a color pair uses the default
10786         colors.  This allows color styling in TUI mode on MS-Windows.
10787
10788         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10789         ncurses_norm_attr.
10790         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10791         colors in ncurses_norm_attr.
10792         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10793         "none", replace it with the default color recorded in
10794         ncurses_norm_attr.
10795
10796 2019-03-14  Tom Tromey  <tromey@adacore.com>
10797
10798         * source-cache.h (class source_cache) <get_source_lines>: Return
10799         std::string.
10800         * source-cache.c (source_cache::extract_lines): Handle case where
10801         first_pos==npos.  Return std::string.
10802         (source_cache::get_source_lines): Update.
10803
10804 2019-03-14  Tom Tromey  <tromey@adacore.com>
10805
10806         * NEWS: Add item for "style sources" commands.
10807         * source-cache.c (source_cache::get_source_lines): Check
10808         source_styling.
10809         * cli/cli-style.c (source_styling): New global.
10810         (_initialize_cli_style): Add "style sources" commands.
10811         (show_style_sources): New function.
10812         * cli/cli-style.h (source_styling): Declare.
10813
10814 2019-03-14  Pedro Alves  <palves@redhat.com>
10815             Tom Tromey  <tromey@adacore.com>
10816
10817         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10818         * tui/tui-winsource.c (tui_refill_source_window): New function,
10819         from...
10820         (tui_horizontal_source_scroll): ... here.  Move some logic.
10821         * cli/cli-style.c (set_style_enabled): Notify new observable.
10822         * tui/tui-hooks.c (tui_redisplay_source): New function.
10823         (tui_attach_detach_observers): Attach or detach
10824         tui_redisplay_source.
10825         * observable.h (source_styling_changed): New observable.
10826         * observable.c: Define source_styling_changed observable.
10827
10828 2019-03-13  Tom Tromey  <tromey@adacore.com>
10829
10830         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10831         (i386_gnu_nat_target::store_registers): Update.
10832         * target-debug.h (target_debug_print_std_string): New macro.
10833         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10834         * windows-tdep.c (display_one_tib): Update.
10835         * tui/tui-stack.c (tui_make_status_line): Update.
10836         * top.c (print_inferior_quit_action): Update.
10837         * thread.c (thr_try_catch_cmd): Update.
10838         (add_thread_with_info): Update.
10839         (thread_target_id_str): Update.
10840         (thr_try_catch_cmd): Update.
10841         (thread_command): Update.
10842         (thread_find_command): Update.
10843         * record-btrace.c (record_btrace_target::info_record)
10844         (record_btrace_resume_thread, record_btrace_target::resume)
10845         (record_btrace_cancel_resume, record_btrace_step_thread)
10846         (record_btrace_target::wait, record_btrace_target::wait)
10847         (record_btrace_target::wait, record_btrace_target::stop): Update.
10848         * progspace.c (print_program_space): Update.
10849         * process-stratum-target.c
10850         (process_stratum_target::thread_address_space): Update.
10851         * linux-fork.c (linux_fork_mourn_inferior)
10852         (detach_checkpoint_command, info_checkpoints_command)
10853         (linux_fork_context): Update.
10854         (linux_fork_detach): Update.
10855         (class scoped_switch_fork_info): Update.
10856         (delete_checkpoint_command): Update.
10857         * infrun.c (follow_fork_inferior): Update.
10858         (follow_fork_inferior): Update.
10859         (proceed_after_vfork_done): Update.
10860         (handle_vfork_child_exec_or_exit): Update.
10861         (follow_exec): Update.
10862         (displaced_step_prepare_throw): Update.
10863         (displaced_step_restore): Update.
10864         (start_step_over): Update.
10865         (resume_1): Update.
10866         (clear_proceed_status_thread): Update.
10867         (proceed): Update.
10868         (print_target_wait_results): Update.
10869         (do_target_wait): Update.
10870         (context_switch): Update.
10871         (stop_all_threads): Update.
10872         (restart_threads): Update.
10873         (finish_step_over): Update.
10874         (handle_signal_stop): Update.
10875         (switch_back_to_stepped_thread): Update.
10876         (keep_going_pass_signal): Update.
10877         (print_exited_reason): Update.
10878         (normal_stop): Update.
10879         * inferior.c (inferior_pid_to_str): Change return type.
10880         (print_selected_inferior): Update.
10881         (add_inferior): Update.
10882         (detach_inferior): Update.
10883         * dummy-frame.c (fprint_dummy_frames): Update.
10884         * dcache.c (dcache_info_1): Update.
10885         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10886         (btrace_fetch, btrace_clear): Update.
10887         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10888         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10889         type.
10890         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10891         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10892         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10893         * gdbarch.c, gdbarch.h: Rebuild.
10894         * gdbarch.sh (core_pid_to_str): Change return type.
10895         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10896         return type.
10897         (windows_nat_target::pid_to_str): Change return type.
10898         (windows_delete_thread): Update.
10899         (windows_nat_target::attach): Update.
10900         (windows_nat_target::files_info): Update.
10901         * target-delegates.c: Rebuild.
10902         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10903         return type.
10904         (sol_thread_target::pid_to_str): Change return type.
10905         * remote.c (class remote_target) <pid_to_str>: Change return
10906         type.
10907         (remote_target::pid_to_str): Change return type.
10908         (extended_remote_target::attach, remote_target::remote_stop_ns)
10909         (remote_target::remote_notif_remove_queued_reply)
10910         (remote_target::push_stop_reply, remote_target::disable_btrace):
10911         Update.
10912         (extended_remote_target::attach): Update.
10913         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10914         type.
10915         (gdbsim_target::pid_to_str): Change return type.
10916         * ravenscar-thread.c (struct ravenscar_thread_target)
10917         <pid_to_str>: Change return type.
10918         (ravenscar_thread_target::pid_to_str): Change return type.
10919         * procfs.c (class procfs_target) <pid_to_str>: Change return
10920         type.
10921         (procfs_target::pid_to_str): Change return type.
10922         (procfs_target::attach): Update.
10923         (procfs_target::detach): Update.
10924         (procfs_target::fetch_registers): Update.
10925         (procfs_target::store_registers): Update.
10926         (procfs_target::wait): Update.
10927         (procfs_target::files_info): Update.
10928         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10929         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10930         return type.
10931         (nto_procfs_target::pid_to_str): Change return type.
10932         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10933         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10934         return type.
10935         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10936         (exit_lwp): Update.
10937         (attach_proc_task_lwp_callback, get_detach_signal)
10938         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10939         (linux_nat_target::resume, wait_lwp, stop_callback)
10940         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10941         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10942         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10943         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10944         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10945         type.
10946         (inf_ptrace_target::attach): Update.
10947         (inf_ptrace_target::files_info): Update.
10948         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10949         type.
10950         (go32_nat_target::pid_to_str): Change return type.
10951         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10952         (gnu_nat_target::wait): Update.
10953         (gnu_nat_target::wait): Update.
10954         (gnu_nat_target::resume): Update.
10955         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10956         (fbsd_nat_target::wait): Update.
10957         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10958         type.
10959         (darwin_nat_target::attach): Update.
10960         * corelow.c (class core_target) <pid_to_str>: Change return type.
10961         (core_target::pid_to_str): Change return type.
10962         * target.c (normal_pid_to_str): Change return type.
10963         (default_pid_to_str): Likewise.
10964         (target_pid_to_str): Change return type.
10965         (target_translate_tls_address): Update.
10966         (target_announce_detach): Update.
10967         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10968         return type.
10969         (bsd_uthread_target::pid_to_str): Change return type.
10970         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10971         type.
10972         (bsd_kvm_target::pid_to_str): Change return type.
10973         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10974         return type.
10975         (aix_thread_target::pid_to_str): Change return type.
10976         * target.h (struct target_ops) <pid_to_str>: Change return type.
10977         (target_pid_to_str, normal_pid_to_str): Likewise.
10978         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10979         type.
10980         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10981         type.
10982         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10983         return type.
10984         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10985         type.
10986         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10987         type.
10988         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10989         return type.
10990
10991 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10992
10993         * NEWS: Mention that the new default MI version is 3.  Mention
10994         changes to the output of commands and events that deal with
10995         multi-location breakpoints.
10996         * breakpoint.c: Include "mi/mi-out.h".
10997         (print_one_breakpoint): Change output syntax if using MI version
10998         >= 3.
10999         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11000         New.
11001         (mi_multi_location_breakpoint_output_fixed): New.
11002         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11003         (mi_cmd_fix_multi_location_breakpoint_output): New.
11004         (mi_multi_location_breakpoint_output_fixed): New.
11005         * mi/mi-cmds.c (mi_cmds): Register command
11006         -fix-multi-location-breakpoint-output.
11007         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11008         interpreter "mi".
11009
11010 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11011
11012         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11013         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11014         instantiate mi_ui_out based on interpreter name.
11015         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11016         * mi/mi-main.c (mi_load_progress): Likewise.
11017
11018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11019
11020         * NEWS: Combine separate "New targets" sections for 8.3.
11021
11022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11023
11024         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11025         (ppcfbsd_init_abi): Install gdbarch
11026         "fetch_tls_load_module_address" and "get_thread_local_address"
11027         methods.
11028
11029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11030
11031         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11032         (riscv_fbsd_init_abi): Install gdbarch
11033         "fetch_tls_load_module_address" and "get_thread_local_address"
11034         methods.
11035
11036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11037
11038         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11039         (i386fbsd_init_abi): Install gdbarch
11040         "fetch_tls_load_module_address" and "get_thread_local_address"
11041         methods.
11042
11043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11044
11045         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11046         (amd64fbsd_init_abi): Install gdbarch
11047         "fetch_tls_load_module_address" and "get_thread_local_address"
11048         methods.
11049
11050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11051
11052         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11053         (struct fbsd_pspace_data): New type.
11054         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11055         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11056         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11057         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11058         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11059
11060 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11061
11062         * gdbtypes.c (lookup_struct_elt): New function.
11063         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11064         * gdbtypes.h (struct struct_elt): New type.
11065         (lookup_struct_elt): New prototype.
11066
11067 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11068
11069         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11070         remove disabled code block.
11071
11072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11073
11074         * gdbarch.sh (get_thread_local_address): New method.
11075         * gdbarch.h, gdbarch.c: Regenerate.
11076         * target.c (target_translate_tls_address): Use
11077         gdbarch_get_thread_local_address if present instead of
11078         target::get_thread_local_address.
11079
11080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11081
11082         * target.h (target::get_thread_local_address): Update comment.
11083
11084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11085
11086         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11087         objfile->separate_debug_objfile_backlink if not NULL.
11088
11089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11090
11091         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11092         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11093         (amd64bsd_store_inferior_registers): Likewise.
11094         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11095         Enable segment base registers.
11096         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11097         PT_GETFSBASE and PT_GETGSBASE.
11098         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11099         PT_SETGSBASE.
11100         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11101         segment base registers.
11102         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11103
11104 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11105
11106         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11107         Update calls to i386_target_description to add 'segments'
11108         parameter.
11109         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11110         add segment base registers.
11111         * arch/i386.c (i386_create_target_description): Add 'segments'
11112         parameter to enable segment base registers.
11113         * arch/i386.h (i386_create_target_description): Likewise.
11114         * features/i386/32bit-segments.xml: New file.
11115         * features/i386/32bit-segments.c: Generate.
11116         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11117         call to i386_target_description to add 'segments' parameter.
11118         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11119         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11120         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11121         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11122         if feature is present.
11123         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11124         Add 'segments' parameter to call to i386_target_description.
11125         (i386_target_description): Add 'segments' parameter to enable
11126         segment base registers.
11127         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11128         to call to i386_target_description.
11129         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11130         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11131         Define I386_NUM_REGS.
11132         (i386_target_description): Add 'segments' parameter to enable
11133         segment base registers.
11134
11135 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11136
11137         PR/24325
11138         * source-cache.c: #undef open and close, to avoid unresolved
11139         externals during linking.
11140
11141 2019-03-12  Tom Tromey  <tromey@adacore.com>
11142
11143         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11144         const.  Add initializers.
11145         (_initialize_remote): Don't initialize ptid globals.
11146
11147 2019-03-12  Pedro Alves  <palves@redhat.com>
11148
11149         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11150
11151 2019-03-12  Pedro Alves  <palves@redhat.com>
11152
11153         * cp-name-parser.y (main): Remove unused 'len' variable.
11154
11155 2019-03-12  Tom Tromey  <tromey@adacore.com>
11156
11157         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11158         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11159
11160 2019-03-12  Tom Tromey  <tromey@adacore.com>
11161
11162         * linux-nat.c (iterate_over_lwps): Update.
11163         (stop_callback): Remove parameter.
11164         (stop_wait_callback, detach_callback, resume_set_callback)
11165         (select_singlestep_lwp_callback, set_ignore_sigint)
11166         (status_callback, resumed_callback, resume_clear_callback)
11167         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11168         data parameter.
11169         (linux_nat_target::detach, linux_nat_target::resume)
11170         (linux_stop_and_wait_all_lwps, select_event_lwp)
11171         (linux_nat_filter_event, linux_nat_wait_1)
11172         (linux_nat_target::kill, linux_nat_target::stop)
11173         (linux_nat_target::stop): Update.
11174         (linux_nat_resume_callback): Change type.
11175         (resume_stopped_resumed_lwps, count_events_callback)
11176         (select_event_lwp_callback): Likewise.
11177         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11178         * arm-linux-nat.c (struct update_registers_data): Remove.
11179         (update_registers_callback): Change type.
11180         (arm_linux_insert_hw_breakpoint1): Update.
11181         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11182         parameter.
11183         (x86_linux_dr_set_addr): Update.
11184         (x86_linux_dr_set_control): Update.
11185         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11186         (iterate_over_lwps): Use gdb::function_view.
11187         * nat/aarch64-linux-hw-point.c (struct
11188         aarch64_dr_update_callback_param): Remove.
11189         (debug_reg_change_callback): Change type.
11190         (aarch64_notify_debug_reg_change): Update.
11191         * s390-linux-nat.c (s390_refresh_per_info): Update.
11192
11193 2019-03-11  Tom Tromey  <tromey@adacore.com>
11194
11195         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11196         redundant assignment to "this_cu".
11197
11198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11199
11200         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11201
11202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11203
11204         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11205         from...
11206         (rank_one_type): ... this.
11207
11208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11209
11210         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11211         from...
11212         (rank_one_type): ... this.
11213
11214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11215
11216         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11217         from...
11218         (rank_one_type): ... this.
11219
11220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11221
11222         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11223         from...
11224         (rank_one_type): ... this.
11225
11226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11227
11228         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11229         from...
11230         (rank_one_type): ... this.
11231
11232 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11233
11234         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11235         from...
11236         (rank_one_type): ... this.
11237
11238 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11239
11240         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11241         from...
11242         (rank_one_type): ... this.
11243
11244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11245
11246         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11247         from...
11248         (rank_one_type): ... this.
11249
11250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11251
11252         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11253         from...
11254         (rank_one_type): ... this.
11255
11256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11257
11258         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11259         from...
11260         (rank_one_type): ... this.
11261
11262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11263
11264         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11265         from...
11266         (rank_one_type): ... this.
11267
11268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11269
11270         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11271         from...
11272         (rank_one_type): ... this.
11273
11274 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11275
11276         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11277         inferior-events' shows the example events.
11278
11279 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11280
11281         Support styling on native MS-Windows console
11282
11283         PR/24315
11284         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11285         on MS-Windows if $TERM is not defined.
11286
11287         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11288
11289         * posix-hdep.c (gdb_console_fputs):
11290         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11291         functions.
11292         * ui-file.h (gdb_console_fputs): Add prototype.
11293
11294         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11295         back to fputs only if the former returns zero.
11296
11297 2019-03-07  Tom Tromey  <tom@tromey.com>
11298
11299         * symmisc.c (print_symbol_bcache_statistics): Update.
11300         (print_objfile_statistics): Update.
11301         * symfile.c (allocate_symtab): Update.
11302         * stabsread.c: Don't include bcache.h.
11303         * psymtab.h (struct psymbol_bcache): Don't declare.
11304         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11305         (psymbol_bcache_init, psymbol_bcache_free)
11306         (psymbol_bcache_get_bcache): Don't declare.
11307         * psymtab.c (struct psymbol_bcache): Remove.
11308         (psymtab_storage::psymtab_storage): Update.
11309         (psymtab_storage::~psymtab_storage): Update.
11310         (psymbol_bcache_init, psymbol_bcache_free)
11311         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11312         (add_psymbol_to_bcache): Update.
11313         (allocate_psymtab): Update.
11314         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11315         macro_cache>: No longer pointers.
11316         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11317         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11318         * macrotab.c (macro_bcache): Update.
11319         * macroexp.c: Don't include bcache.h.
11320         * gdbtypes.c (check_types_worklist): Update.
11321         (types_deeply_equal): Remove TRY/CATCH.  Update.
11322         * elfread.c (elf_symtab_read): Update.
11323         * dwarf2read.c: Don't include bcache.h.
11324         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11325         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11326         (print_bcache_statistics, bcache_memory_used): Don't declare.
11327         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11328         methods.  Rename all data members.
11329         * bcache.c (struct bcache): Move to bcache.h.
11330         (bcache::expand_hash_table): Rename from expand_hash_table.
11331         (bcache): Remove.
11332         (bcache::insert): Rename from bcache_full.
11333         (bcache::compare): Rename from bcache_compare.
11334         (bcache_xmalloc): Remove.
11335         (bcache::~bcache): Rename from bcache_xfree.
11336         (bcache::print_statistics): Rename from print_bcache_statistics.
11337         (bcache::memory_used): Rename from bcache_memory_used.
11338
11339 2019-03-07  Pedro Alves  <palves@redhat.com>
11340
11341         * infrun.c (normal_stop): Also check for
11342         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11343
11344 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11345
11346         * f-lang.c (value_from_host_double): Moved to...
11347         * value.c (value_from_host_double): ...here.
11348         * value.h (value_from_host_double): Declare.
11349         * guile/scm-math.c (vlscm_convert_typed_number): Use
11350         value_from_host_double.
11351         (vlscm_convert_number): Likewise.
11352         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11353         * python/py-value.c (convert_value_from_python): Likewise.
11354
11355 2019-03-06  Tom Tromey  <tom@tromey.com>
11356
11357         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11358
11359 2019-03-06  Tom Tromey  <tom@tromey.com>
11360
11361         * utils.h (free_current_contents): Don't declare.
11362         * utils.c (free_current_contents): Remove.
11363
11364 2019-03-06  Tom Tromey  <tom@tromey.com>
11365
11366         * top.c (quit_force): Update.
11367         * main.c (captured_command_loop): Update.
11368         * common/new-op.c (operator new): Update.
11369         * common/common-exceptions.c (struct catcher)
11370         <save_cleanup_chain>: Remove member.
11371         (exceptions_state_mc_init): Update.
11372         (exception_try_scope_entry): Return nullptr.
11373         (exception_try_scope_exit, exception_rethrow)
11374         (throw_exception_sjlj, throw_exception_cxx): Update.
11375         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11376         (all_cleanups, do_cleanups, discard_cleanups)
11377         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11378         (restore_cleanups, restore_final_cleanups): Don't declare.
11379         (do_final_cleanups): Remove parameter.
11380         * common/cleanups.c (cleanup_chain, make_cleanup)
11381         (make_cleanup_dtor, all_cleanups, do_cleanups)
11382         (discard_my_cleanups, discard_cleanups)
11383         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11384         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11385         (null_cleanup): Remove.
11386         (do_final_cleanups): Remove parameter.
11387
11388 2019-03-06  Tom Tromey  <tom@tromey.com>
11389
11390         * remote.c (remote_target::remote_parse_stop_reply): Use
11391         unique_xmalloc_ptr.
11392
11393 2019-03-06  Tom Tromey  <tom@tromey.com>
11394
11395         * stabsread.c (struct stabs_field_info): Rename from field_info.
11396         <list, fnlist>: Add initializers.
11397         <obstack>: New member.
11398         (read_member_functions, read_struct_fields, read_baseclasses):
11399         Allocate on obstack.  Don't use cleanups.
11400         (read_one_struct_field, read_member_functions, read_struct_fields)
11401         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11402         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11403         (read_struct_type): Update.
11404
11405 2019-03-06  Tom Tromey  <tom@tromey.com>
11406
11407         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11408         * common/filestuff.h (make_cleanup_close): Don't declare.
11409         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11410         Remove.
11411
11412 2019-03-06  Tom Tromey  <tom@tromey.com>
11413
11414         * solib-aix.c: Use make_scope_exit.
11415
11416 2019-03-06  Tom Tromey  <tom@tromey.com>
11417
11418         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11419         Use make_scope_exit.
11420
11421 2019-03-06  Tom Tromey  <tom@tromey.com>
11422
11423         * solib-svr4.c (disable_probes_interface): Remove parameter.
11424         (svr4_handle_solib_event): Use make_scope_exit.
11425
11426 2019-03-06  Tom Tromey  <tom@tromey.com>
11427
11428         * remote.c (struct stop_reply_deleter): Remove.
11429         (stop_reply_up): Update.
11430         (struct stop_reply): Derive from notif_event.  Don't typedef.
11431         <regcache>: Now a std::vector.
11432         (stop_reply_xfree): Remove.
11433         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11434         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11435         (remote_target::discard_pending_stop_replies): Use delete.
11436         (remote_target::remote_parse_stop_reply): Update.
11437         (remote_target::process_stop_reply): Update.
11438         * remote-notif.h (struct notif_event): Add virtual destructor.
11439         Remove "dtr" member.
11440         (struct notif_client) <alloc_event>: Return a unique_ptr.
11441         (notif_event_xfree): Don't declare.
11442         (notif_event_up): New typedef.
11443         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11444         (notif_event_xfree, do_notif_event_xfree): Remove.
11445         (remote_notif_state_xfree): Update.
11446
11447 2019-03-06  Tom Tromey  <tom@tromey.com>
11448
11449         * infrun.c (displaced_step_clear_cleanup): Now a
11450         forward_scope_exit type.
11451         (displaced_step_prepare_throw): Update.
11452         (displaced_step_fixup): Update.
11453
11454 2019-03-06  Tom Tromey  <tom@tromey.com>
11455
11456         * inferior.h (class inferior): Update comment.
11457         * gdbthread.h (class thread_info): Update comment.
11458
11459 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11460             Tom Tromey  <tom@tromey.com>
11461
11462         * stabsread.h (struct stab_section_list): Remove.
11463         (coffstab_build_psymtabs): Update.
11464         * dbxread.c (symbuf_sections): Now a std::vector.
11465         (sect_idx): New global.
11466         (fill_symbuf): Update.
11467         (coffstab_build_psymtabs): Change type of stabsects parameter.
11468         Update.
11469         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11470         std::vector.
11471         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11472         (coff_locate_sections): Update.
11473         (coff_symfile_read): Remove cleanups.  Update.
11474         (init_stringtab): Add storage parameter.
11475         (free_stringtab, free_stringtab_cleanup): Remove.
11476         (init_lineno): Add storage parameter.
11477         (free_linetab, free_linetab_cleanup): Remove.
11478
11479 2019-03-06  Pedro Alves  <palves@redhat.com>
11480
11481         * linux-fork.c (fork_info::clobber_regs): Delete.
11482         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11483         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11484         comment.  Adjust.
11485         (scoped_switch_fork_info::scoped_switch_fork_info)
11486         (checkpoint_command, linux_fork_context): Adjust
11487         fork_save_infrun_state calls.
11488
11489 2019-03-06  Pedro Alves  <palves@redhat.com>
11490
11491         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11492         (inf_has_multiple_threads): Return 'bool' and rewrite using
11493         inferior_info::threads().
11494
11495 2019-03-06  Pedro Alves  <palves@redhat.com>
11496
11497         * linux-fork.c: Include <list>.
11498         (fork_list): Now a std::list instance.
11499         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11500         (forks_exist_p, find_last_fork): Adjust.
11501         (new_fork): Delete.
11502         (one_fork_p): New.
11503         (add_fork): Adjust.
11504         (free_fork): Delete, folded into fork_info::~fork_info().
11505         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11506         Adjust.
11507         (init_fork_list): Delete.
11508         (linux_fork_killall, linux_fork_mourn_inferior)
11509         (linux_fork_detach, info_checkpoints_command): Adjust.
11510         (_initialize_linux_fork): No longer call init_fork_list.
11511
11512 2019-03-06  Pedro Alves  <palves@redhat.com>
11513
11514         * linux-fork.c (new_fork): New, split out of ...
11515         (add_fork): ... this.  Return void.  Move "first fork" special
11516         case from here, to ...
11517         (checkpoint_command): ... here.
11518         * linux-linux.h (add_fork): Return void.
11519
11520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11523
11524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11525             Chris January  <chris.january@arm.com>
11526             David Lecomber  <david.lecomber@arm.com>
11527
11528         * f-exp.y: New token, UNOP_INTRINSIC.
11529         (exp): New pattern using UNOP_INTRINSIC token.
11530         (f77_keywords): Add 'abs' keyword.
11531         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11532         (value_from_host_double): New function.
11533         (evaluate_subexp_f): Support UNOP_ABS.
11534
11535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11536
11537         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11538         types.
11539
11540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11541
11542         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11543         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11544         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11545
11546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11547
11548         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11549
11550 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11551             Chris January  <chris.january@arm.com>
11552
11553         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11554         * f-exp.y: Define 'KIND' token.
11555         (exp): New pattern for KIND expressions.
11556         (ptype): Handle types with a kind extension.
11557         (direct_abs_decl): Extend to spot kind extensions.
11558         (f77_keywords): Add 'kind' to the list.
11559         (push_kind_type): New function.
11560         (convert_to_kind_type): New function.
11561         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11562         * parse.c (operator_length_standard): Likewise.
11563         * parser-defs.h (enum type_pieces): Add tp_kind.
11564         * std-operator.def: Add UNOP_KIND.
11565
11566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11567
11568         * f-exp.y (f_parse): Set yydebug.
11569
11570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11571
11572         * f-lang.c (evaluate_subexp_f): New function.
11573         (exp_descriptor_f): New global.
11574         (f_language_defn): Use exp_descriptor_f instead of
11575         exp_descriptor_standard.
11576
11577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11578
11579         * f-exp.y (struct token): Add comments.
11580         (dot_ops): Remove uppercase versions and the end marker.
11581         (f77_keywords): Likewise.
11582         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11583         entries in the dot_ops array are case insensitive, and use
11584         strncasecmp to compare strings.  Also some whitespace cleanup in
11585         this area.  Similar for the f77_keywords array, except entries in
11586         this list might be case sensitive.
11587
11588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11589
11590         * f-exp.y (struct f77_boolean_val): Add comments.
11591         (boolean_values): Remove uppercase versions, and end marker.
11592         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11593         and use strncasecmp to achieve case insensitivity.  Additionally,
11594         perform whitespace cleanup around this code.
11595
11596 2019-03-06  Tom Tromey  <tromey@adacore.com>
11597
11598         * remote-sim.c (gdbsim_target_open): Use result of
11599         gdb_argv::release.
11600
11601 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11602         Dirk Schubert  <dirk.schubert@arm.com>
11603         Chris January  <chris.january@arm.com>
11604
11605         * eval.c (evaluate_subexp_standard): Call Fortran argument
11606         wrapping logic.
11607         * f-lang.c (struct value): A value which can be passed into a
11608         Fortran function call.
11609         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11610         where appropriate.
11611         (struct type): Value ready for a Fortran function call.
11612         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11613         is needed.
11614         * f-lang.h (fortran_argument_convert): Declaration.
11615         (fortran_preserve_arg_pointer): Declaration.
11616         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11617
11618 2019-03-05  Tom Tromey  <tromey@adacore.com>
11619
11620         * python/py-prettyprint.c (print_string_repr): Remove #if.
11621         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11622
11623 2019-03-05  Tom Tromey  <tromey@adacore.com>
11624
11625         * target.c (the_dummy_target): Move later.  Change type to
11626         "dummy_target".
11627         (initialize_targets): Don't initialize the_dummy_target.
11628
11629 2019-03-05  Tom Tromey  <tromey@adacore.com>
11630
11631         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11632         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11633
11634 2019-03-05  Tom Tromey  <tromey@adacore.com>
11635
11636         * windows-nat.c (windows_nat_target::attach)
11637         (windows_nat_target::detach): Don't call gdb_flush.
11638         * valprint.c (generic_val_print, val_print, val_print_string):
11639         Don't call gdb_flush.
11640         * utils.c (defaulted_query): Don't call gdb_flush.
11641         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11642         * target.c (target_announce_detach): Don't call gdb_flush.
11643         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11644         * remote.c (extended_remote_target::attach): Don't call
11645         gdb_flush.
11646         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11647         * printcmd.c (do_examine): Don't call gdb_flush.
11648         (info_display_command): Don't call gdb_flush.
11649         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11650         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11651         * memattr.c (info_mem_command): Don't call gdb_flush.
11652         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11653         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11654         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11655         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11656         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11657         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11658         (gnu_nat_target::detach): Don't call gdb_flush.
11659         * f-valprint.c (f_val_print): Don't call gdb_flush.
11660         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11661         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11662         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11663         gdb_flush.
11664         * c-valprint.c (c_val_print): Don't call gdb_flush.
11665         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11666
11667 2019-03-05  Tom Tromey  <tromey@adacore.com>
11668
11669         * varobj.c (update_dynamic_varobj_children): Update.
11670         (install_default_visualizer): Use reset, not release.
11671         * value.c (set_internalvar): Update.
11672         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11673         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11674         ATTRIBUTE_UNUSED_RESULT.
11675
11676 2019-03-05  Tom Tromey  <tromey@adacore.com>
11677
11678         * remote.c (class scoped_remote_fd) <release>: Add
11679         ATTRIBUTE_UNUSED_RESULT.
11680
11681 2019-03-05  Tom Tromey  <tromey@adacore.com>
11682
11683         * macroexp.c (struct macro_buffer) <release>: Add
11684         ATTRIBUTE_UNUSED_RESULT.
11685
11686 2019-03-05  Tom Tromey  <tromey@adacore.com>
11687
11688         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11689         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11690         ATTRIBUTE_UNUSED_RESULT.
11691
11692 2019-03-05  Tom Tromey  <tromey@adacore.com>
11693
11694         * common/scoped_fd.h (class scoped_fd) <release>: Add
11695         ATTRIBUTE_UNUSED_RESULT.
11696
11697 2019-03-05  Tom Tromey  <tromey@adacore.com>
11698
11699         * parser-defs.h (struct parser_state) <release>: Add
11700         ATTRIBUTE_UNUSED_RESULT.
11701
11702 2019-03-05  Tom Tromey  <tromey@adacore.com>
11703
11704         * utils.h (class gdb_argv) <release>: Add
11705         ATTRIBUTE_UNUSED_RESULT.
11706         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11707
11708 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11709
11710         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11711         for-loop range, to avoid compiler warnings.
11712
11713         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11714         avoid compiler warnings about unused variables.
11715
11716         * NEWS: Mention end of support for native debugging on MS-Windows
11717         before XP.
11718
11719         PR gdb/24292
11720         * common/netstuff.c:
11721         * gdbserver/gdbreplay.c
11722         * gdbserver/remote-utils.c:
11723         * ser-tcp.c:
11724         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11725         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11726         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11727         'getaddrinfo' and 'freeaddrinfo' were not available before
11728         Windows XP, and mingw.org's MinGW headers by default define
11729         _WIN32_WINNT to 0x500.
11730
11731 2019-03-01  Gary Benson <gbenson@redhat.com>
11732
11733         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11734
11735 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11736             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11737
11738         PR gdb/8527
11739         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11740         set_sigint_trap, clear_sigint_trap.
11741
11742 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11743
11744         * target.c (target_detach): Clear the regcache and the
11745         frame cache.
11746
11747 2019-02-27  Pedro Alves  <palves@redhat.com>
11748
11749         * utils.c (set_screen_size): When we cap the height/width sizes,
11750         tweak the corresponding command variable to show "unlimited":
11751
11752 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11753             Pedro Alves  <palves@redhat.com>
11754
11755         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11756         before calling rl_set_screen_size.
11757
11758 2019-02-27  Tom Tromey  <tromey@adacore.com>
11759
11760         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11761         define.
11762         * python/py-value.c: Remove Python 2.4 workaround.
11763         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11764         workaround.
11765         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11766         Python 2.4 workaround.
11767         * python/python-internal.h: Remove Python 2.4 comment.
11768         (Py_ssize_t): Don't define.
11769         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11770         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11771         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11772         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11773         * python/python.c (do_start_initialization): Remove Python 2.4
11774         workaround.
11775         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11776         (print_children): Remove Python 2.4 workaround.
11777         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11778         workaround.
11779         (CHARBUFFERPROC_NAME): Remove.
11780         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11781         Python 2.4 workaround.
11782
11783 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11784
11785         * NEWS: Note minimum Python version.
11786
11787 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11788
11789         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11790         code from these functions.  Remove corresponding ifdefs.  Use
11791         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11792         Remove gotos and target of gotos.
11793         (infpy_search_memory): Likewise.
11794
11795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11796
11797         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11798         (hppa_gdbarch_init): Don't register deleted functions with
11799         gdbarch.
11800
11801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11802
11803         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11804         (h8300_unwind_sp): Delete.
11805         (h8300_dummy_id): Delete.
11806         (h8300_gdbarch_init): Don't register deleted functions with
11807         gdbarch.
11808
11809 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11810
11811         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11812         (ft32_unwind_pc): Delete.
11813         (ft32_unwind_sp): Delete.
11814         (ft32_gdbarch_init): Don't register deleted functions with
11815         gdbarch.
11816
11817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11818
11819         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11820         (frv_unwind_pc): Delete.
11821         (frv_unwind_sp): Delete.
11822         (frv_gdbarch_init): Don't register deleted functions with
11823         gdbarch.
11824
11825 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11828         (riscv_unwind_pc): Delete.
11829         (riscv_unwind_sp): Delete.
11830         (riscv_gdbarch_init): Don't register deleted functions with
11831         gdbarch.
11832
11833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11836         (csky_unwind_pc): Delete.
11837         (csky_unwind_sp): Delete.
11838         (csky_gdbarch_init): Don't register deleted functions with
11839         gdbarch.
11840
11841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11844         (cris_unwind_pc): Delete.
11845         (cris_unwind_sp): Delete.
11846         (cris_gdbarch_init): Don't register deleted functions with
11847         gdbarch.
11848
11849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11850
11851         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11852         (bfin_unwind_pc): Delete.
11853         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11854
11855 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11856
11857         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11858         (arm_unwind_pc): Delete.
11859         (arm_unwind_sp): Delete.
11860         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11861
11862 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11865         (arc_unwind_pc): Delete.
11866         (arc_unwind_sp): Delete.
11867         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11868
11869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11870
11871         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11872         (alpha_unwind_pc): Delete.
11873         (alpha_gdbarch_init): Don't register deleted functions with
11874         gdbarch.
11875
11876 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11877
11878         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11879         (aarch64_unwind_pc): Delete.
11880         (aarch64_unwind_sp): Delete.
11881         (aarch64_gdbarch_init): Don't register deleted functions with
11882         gdbarch.
11883
11884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11885
11886         * gdbtypes.c (type_align): Don't consider static members when
11887         computing structure alignment.
11888
11889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11890
11891         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11892         return 0 for other types.
11893         * arch-utils.c (default_type_align): Always return 0.
11894         * gdbarch.h: Regenerate.
11895         * gdbarch.sh (type_align): Extend comment.
11896         * gdbtypes.c (type_align): Add additional comments, always call
11897         gdbarch_type_align before applying the default rules.
11898         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11899         generic code will then apply a suitable default.
11900         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11901         types, return 0 for other types.
11902
11903 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11904
11905         * NEWS: Create a new section for the next release branch.
11906         Rename the section of the current branch, now that it has
11907         been cut.
11908
11909 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11910
11911         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11912         * version.in: Bump version to 8.3.50.DATE-git.
11913
11914 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11915
11916         * aix-thread.c (ptid_cmp): Remove unused variable.
11917         (get_signaled_thread): Likewise.
11918         (store_regs_user_thread): Likewise.
11919         (store_regs_kernel_thread): Likewise.
11920         (fetch_regs_kernel_thread): Remove shadowed variable.
11921
11922 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11923
11924         * features/riscv/32bit-cpu.xml: Add register numbers.
11925         * features/riscv/32bit-fpu.c: Regenerate.
11926         * features/riscv/32bit-fpu.xml: Add register numbers.
11927         * features/riscv/64bit-cpu.xml: Add register numbers.
11928         * features/riscv/64bit-fpu.c: Regenerate.
11929         * features/riscv/64bit-fpu.xml: Add register numbers.
11930
11931 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11932
11933         * NEWS: Mention two argument form of gdb.Value constructor.
11934         * python/py-value.c (convert_buffer_and_type_to_value): New
11935         function.
11936         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11937         Add support for handling an optional second argument.  Call
11938         convert_buffer_and_type_to_value as appropriate.
11939         * python/python-internal.h (Py_buffer_deleter): New struct.
11940         (Py_buffer_up): New typedef.
11941
11942 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11943
11944         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11945         instead of releasing ownership.
11946
11947 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11948
11949         * dwarf2read.c (open_and_init_dwp_file): Call
11950         elf_numsections instead of bfd_count_sections to initialize
11951         dwp_file->num_sections.
11952
11953 2019-02-25  Tom Tromey  <tromey@adacore.com>
11954
11955         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11956
11957 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11958
11959         * gcore.in: Add '--readnever' option when invoking GDB.
11960
11961 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11962
11963         * MAINTAINERS: Update my email address.
11964
11965 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11966
11967         * build-id.c (build_id_to_debug_bfd_1): New function.
11968         (build_id_to_debug_bfd): Look for separate debug file in
11969         sysroot.
11970
11971 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11972
11973         * gdbarch.sh: Update the copyright year range that is placed into
11974         generated files.
11975
11976 2019-02-22  Keith Seitz  <keiths@redhat.com>
11977
11978         PR symtab/23853
11979         * linespec.c (create_sals_line_offset): Search for the default
11980         symtab's filename instead of its fullname.
11981
11982 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11983
11984         * NEWS: Update style defaults.
11985
11986 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11987
11988         * main.c (captured_main_1): Disable styling in batch mode.
11989
11990 2019-02-20  Tom Tromey  <tom@tromey.com>
11991
11992         * symtab.c (symtab_symbol_info): Fix typos.
11993
11994 2019-02-20  Tom Tromey  <tromey@adacore.com>
11995
11996         * findcmd.c (_initialize_mem_search): Use upper case for
11997         metasyntactic variables.
11998
11999 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12000
12001         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12002         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12003
12004 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12005
12006         * top.h (source_file_name): Change to std::string.
12007         * top.c (source_file_name): Likewise.
12008         (command_line_input): Adjust.
12009         * cli/cli-script.c (script_from_file): Adjust.
12010
12011 2019-02-19  Tom Tromey  <tromey@adacore.com>
12012
12013         * ravenscar-thread.c
12014         (ravenscar_thread_target::update_thread_list): Don't call
12015         ada_build_task_list.
12016         * ada-lang.h (ada_build_task_list): Don't declare.
12017         * ada-tasks.c (struct ada_tasks_inferior_data)
12018         <task_list_valid_p>: Now bool.
12019         (read_known_tasks, ada_task_list_changed)
12020         (ada_tasks_invalidate_inferior_data): Update.
12021         (read_known_tasks_array): Return bool.
12022         (read_known_tasks_list): Likewise.
12023         (read_known_tasks): Return void.
12024         (ada_build_task_list): Now static.
12025
12026 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12027
12028         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12029         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12030
12031 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12032
12033         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12034         variant for ada_tasks_pspace_data_handle and
12035         ada_tasks_inferior_data_handle.
12036         (ada_tasks_pspace_data_cleanup): New function.
12037         (ada_tasks_inferior_data_cleanup): New function.
12038
12039 2019-02-17  Tom Tromey  <tom@tromey.com>
12040
12041         * macrotab.h (macro_source_fullname): Return a std::string.
12042         * macrotab.c (macro_include, check_for_redefinition)
12043         (macro_undef, macro_lookup_definition, foreach_macro)
12044         (foreach_macro_in_scope): Update.
12045         (macro_source_fullname): Return a std::string.
12046         * macrocmd.c (show_pp_source_pos): Update.
12047
12048 2019-02-17  Tom Tromey  <tom@tromey.com>
12049
12050         * macrocmd.c (show_pp_source_pos): Style the file names.
12051
12052 2019-02-17  Tom Tromey  <tom@tromey.com>
12053
12054         PR tui/24197:
12055         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12056
12057 2019-02-17  Tom Tromey  <tom@tromey.com>
12058
12059         * ada-lang.c (user_select_syms): Use filtered printing.
12060         * utils.c (wrap_style): New global.
12061         (desired_style): Remove.
12062         (emit_style_escape): Add stream parameter.
12063         (set_output_style, reset_terminal_style, prompt_for_continue):
12064         Update.
12065         (flush_wrap_buffer): Only flush gdb_stdout.
12066         (wrap_here): Set wrap_style.
12067         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12068         treat escape sequences as a character.  Change when wrap buffer is
12069         flushed.
12070         (fputs_styled): Do not set the output style when the default is
12071         requested.
12072         * ui-style.h (struct ui_file_style) <is_default>: New method.
12073         * source.c (print_source_lines_base): Emit escape sequences in one
12074         piece.
12075
12076 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12077
12078         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12079         integers and enumeration types.
12080
12081 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12082
12083         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12084         instead of lookup_symbol_in_language
12085         (do_exact_match): New function.
12086         (ada_get_symbol_name_matcher): Return do_exact_match when
12087         doing a verbatim match.
12088
12089 2019-02-15  Tom Tromey  <tromey@adacore.com>
12090
12091         * ravenscar-thread.c (ravenscar_thread_target::resume)
12092         (ravenscar_thread_target::wait): Special case wildcard requests.
12093
12094 2019-02-15  Tom Tromey  <tromey@adacore.com>
12095
12096         * ravenscar-thread.c (base_ptid): Remove.
12097         (struct ravenscar_thread_target) <close>: New method.
12098         <m_base_ptid>: New member.
12099         <update_inferior_ptid, active_task, task_is_currently_active,
12100         runtime_initialized>: Declare methods.
12101         <ravenscar_thread_target>: Add constructor.
12102         (ravenscar_thread_target::task_is_currently_active)
12103         (ravenscar_thread_target::update_inferior_ptid)
12104         (ravenscar_runtime_initialized): Rename.  Now methods.
12105         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12106         (ravenscar_thread_target::update_thread_list): Update.
12107         (ravenscar_thread_target::active_task): Now method.
12108         (ravenscar_thread_target::store_registers)
12109         (ravenscar_thread_target::prepare_to_store)
12110         (ravenscar_thread_target::prepare_to_store)
12111         (ravenscar_thread_target::mourn_inferior): Update.
12112         (ravenscar_inferior_created): Use "new" to create target.
12113         (ravenscar_thread_target::get_ada_task_ptid): Update.
12114         (_initialize_ravenscar): Don't initialize base_ptid.
12115         (ravenscar_ops): Remove global.
12116
12117 2019-02-15  Tom Tromey  <tromey@adacore.com>
12118
12119         * target.h (push_target): Declare new overload.
12120         * target.c (push_target): New overload, taking an rvalue reference.
12121         * remote.c (remote_target::open_1): Use push_target overload.
12122         * corelow.c (core_target_open): Use push_target overload.
12123
12124 2019-02-15  Tom Tromey  <tromey@adacore.com>
12125
12126         * ravenscar-thread.c (is_ravenscar_task)
12127         (ravenscar_task_is_currently_active): Return bool.
12128         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12129         (_initialize_ravenscar): Remove "(void)".
12130         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12131         Return bool.
12132
12133 2019-02-15  Tom Tromey  <tromey@adacore.com>
12134
12135         * ravenscar-thread.c (ravenscar_runtime_initializer)
12136         (has_ravenscar_runtime, get_running_thread_id)
12137         (ravenscar_thread_target::resume): Fix indentation.
12138
12139 2019-02-15  Tom Tromey  <tromey@adacore.com>
12140
12141         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12142         from ravenscar_arch_ops.
12143         (sparc_ravenscar_ops::fetch_registers)
12144         (sparc_ravenscar_ops::store_registers): Now methods.
12145         (sparc_ravenscar_prepare_to_store): Remove.
12146         (sparc_ravenscar_ops): Redefine.
12147         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12148         methods and destructor.  Remove members.
12149         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12150         (ravenscar_thread_target::store_registers)
12151         (ravenscar_thread_target::prepare_to_store): Update.
12152         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12153         Remove.
12154         (struct ppc_ravenscar_powerpc_ops): Derive from
12155         ravenscar_arch_ops.
12156         (ppc_ravenscar_powerpc_ops::fetch_registers)
12157         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12158         (ppc_ravenscar_powerpc_ops): Redefine.
12159         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12160         (ppc_ravenscar_e500_ops::fetch_registers)
12161         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12162         (ppc_ravenscar_e500_ops): Redefine.
12163         * aarch64-ravenscar-thread.c
12164         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12165         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12166         (aarch64_ravenscar_fetch_registers)
12167         (aarch64_ravenscar_store_registers): Now methods.
12168         (aarch64_ravenscar_ops): Redefine.
12169
12170 2019-02-15  Tom Tromey  <tromey@adacore.com>
12171
12172         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12173         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12174         (ravenscar_thread_target::stopped_by_watchpoint)
12175         (ravenscar_thread_target::stopped_data_address)
12176         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12177
12178 2019-02-15  Tom Tromey  <tromey@adacore.com>
12179
12180         * ravenscar-thread.c: Fix some typos.
12181
12182 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12183             Tom Tromey  <tromey@adacore.com>
12184
12185         * ada-lang.c (ada_exception_sal): Change addr_string to a
12186         std::string.
12187         (create_ada_exception_catchpoint): Update.
12188
12189 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12190             Tom Tromey  <tromey@adacore.com>
12191
12192         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12193         (bp_location_ops): Remove.
12194         (base_breakpoint_allocate_location): Update.
12195         (free_bp_location): Update.
12196         * ada-lang.c (class ada_catchpoint_location)
12197         <ada_catchpoint_location>: Remove ops parameter.
12198         (ada_catchpoint_location_dtor): Remove.
12199         (ada_catchpoint_location_ops): Remove.
12200         (allocate_location_exception): Update.
12201         * breakpoint.h (struct bp_location_ops): Remove.
12202         (class bp_location) <bp_location>: Remove bp_location_ops
12203         parameter.
12204         <~bp_location>: Add destructor.
12205         <ops>: Remove.
12206
12207 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12208             Pedro Alves  <palves@redhat.com>
12209
12210         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12211         'PATH_MAX'.
12212
12213 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12214             Samuel Thibault  <samuel.thibault@gnu.org>
12215             Thomas Schwinge  <thomas@codesourcery.com>
12216
12217         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12218         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12219
12220 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12221
12222         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12223         (check_empty): Use "const char *".
12224
12225         * gnu-nat.c (gnu_nat_target::detach): Instead of
12226         'detach_inferior (pid)' call
12227         'detach_inferior (find_inferior_pid (pid))'.
12228
12229         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12230         'nat/fork-inferior.o'.
12231         * gnu-nat.c: #include "nat/fork-inferior.h".
12232
12233         * gnu-nat.c (gnu_nat_target::detach): Instead of
12234         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12235         * gnu-nat.h: #include "inf-child.h".
12236         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12237         'i386_gnu_nat_target::fetch_registers'.
12238         (gnu_store_registers): Rename/move to
12239         'i386_gnu_nat_target::store_registers'.
12240
12241         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12242         * gnu-nat.h (mach_thread_info): New function.
12243         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12244
12245         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12246
12247 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12248
12249         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12250
12251 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12252
12253         * windows-nat.c (windows_add_thread): Add new parameter
12254         "main_thread_p" with default value set to false.  Update
12255         function documentation as well as all callers.
12256         (windows_delete_thread): Likewise.
12257         (fake_create_process): Update call to windows_add_thread.
12258         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12259         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12260         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12261         call to windows_delete_thread.
12262
12263 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12264
12265         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12266
12267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12268
12269         * symfile.c (find_separate_debug_file): Use canonical path of
12270         sysroot with child_path instead of gdb_sysroot if it is valid.
12271
12272 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12273
12274         * symfile.c (find_separate_debug_file): Use child_path to
12275         determine if an object file is under a sysroot.
12276
12277 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12278
12279         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12280         unittests/child-path-selftests.c.
12281         * common/pathstuff.c (child_path): New function.
12282         * common/pathstuff.h (child_path): New prototype.
12283         * unittests/child-path-selftests.c: New file.
12284
12285 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12286
12287         * symfile.c (find_separate_debug_file): Look for separate debug
12288         files in debug directories under the sysroot.
12289
12290 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12291
12292         * symtab.h (struct minimal_symbol data_p): New const method.
12293         (struct minimal_symbol text_p): Likewise.
12294         * symtab.c (output_source_filename): Use file name style
12295         to print file name.
12296         (print_symbol_info): Likewise.
12297         (print_msymbol_info): Use address style to print addresses.
12298         Use function name style to print executable text symbols.
12299         (expand_symtab_containing_pc): Use data_p.
12300         (find_pc_sect_compunit_symtab): Likewise.
12301
12302 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12303
12304         * breakpoint.c (describe_other_breakpoints): Use address style
12305         to print addresses.
12306         (say_where): Likewise.
12307
12308 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12309
12310         * ada-typeprint.c (print_func_type): Print function name
12311         style to print function name.
12312         * c-typeprint.c (c_print_type_1): Likewise.
12313
12314 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12315
12316         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12317         for execve.
12318
12319 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12320
12321         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12322         type_stack.
12323
12324 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12325
12326         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12327         TYPE_CODE_REF types.
12328
12329 2019-02-08  Jim Wilson  <jimw@sifive.com>
12330
12331         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12332         (riscv_linux_fregset): New.
12333         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12334
12335 2019-02-07  Tom Tromey  <tom@tromey.com>
12336
12337         * thread.c (thread_cancel_execution_command): Update.
12338         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12339         methods.
12340         (struct thread_fsm_ops): Remove.
12341         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12342         (thread_fsm_should_stop, thread_fsm_return_value)
12343         (thread_fsm_set_finished, thread_fsm_finished_p)
12344         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12345         Don't declare.
12346         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12347         * infrun.c (clear_proceed_status_thread)
12348         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12349         (print_stop_event): Update.
12350         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12351         Add constructor.
12352         (step_command_fsm_ops): Remove.
12353         (new_step_command_fsm): Remove.
12354         (step_1): Update.
12355         (step_command_fsm::should_stop): Rename from
12356         step_command_fsm_should_stop.
12357         (step_command_fsm::clean_up): Rename from
12358         step_command_fsm_clean_up.
12359         (step_command_fsm::do_async_reply_reason): Rename from
12360         step_command_fsm_async_reply_reason.
12361         (struct until_next_fsm): Inherit from thread_fsm.  Add
12362         constructor.
12363         (until_next_fsm_ops): Remove.
12364         (new_until_next_fsm): Remove.
12365         (until_next_fsm::should_stop): Rename from
12366         until_next_fsm_should_stop.
12367         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12368         (until_next_fsm::do_async_reply_reason): Rename from
12369         until_next_fsm_async_reply_reason.
12370         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12371         constructor.  Change type of breakpoint.
12372         (finish_command_fsm_ops): Remove.
12373         (new_finish_command_fsm): Remove.
12374         (finish_command_fsm::should_stop): Rename from
12375         finish_command_fsm_should_stop.
12376         (finish_command_fsm::clean_up): Rename from
12377         finish_command_fsm_clean_up.
12378         (finish_command_fsm::return_value): Rename from
12379         finish_command_fsm_return_value.
12380         (finish_command_fsm::do_async_reply_reason): Rename from
12381         finish_command_fsm_async_reply_reason.
12382         (finish_command): Update.
12383         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12384         Add constructor.
12385         (call_thread_fsm_ops): Remove.
12386         (call_thread_fsm::call_thread_fsm): Rename from
12387         new_call_thread_fsm.
12388         (call_thread_fsm::should_stop): Rename from
12389         call_thread_fsm_should_stop.
12390         (call_thread_fsm::should_notify_stop): Rename from
12391         call_thread_fsm_should_notify_stop.
12392         (run_inferior_call, call_function_by_hand_dummy): Update.
12393         * cli/cli-interp.c (should_print_stop_to_console): Update.
12394         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12395         Add constructor.  Change type of location_breakpoint,
12396         caller_breakpoint.
12397         (until_break_fsm_ops): Remove.
12398         (new_until_break_fsm): Remove.
12399         (until_break_fsm::should_stop): Rename from
12400         until_break_fsm_should_stop.
12401         (until_break_fsm::clean_up): Rename from
12402         until_break_fsm_clean_up.
12403         (until_break_fsm::do_async_reply_reason): Rename from
12404         until_break_fsm_async_reply_reason.
12405         (until_break_command): Update.
12406         * thread-fsm.c: Remove.
12407         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12408
12409 2019-02-07  Tom Tromey  <tom@tromey.com>
12410
12411         * yy-remap.h: Add include guard.
12412         * xtensa-tdep.h: Add include guard.
12413         * xcoffread.h: Rename include guard.
12414         * varobj-iter.h: Add include guard.
12415         * tui/tui.h: Rename include guard.
12416         * tui/tui-winsource.h: Rename include guard.
12417         * tui/tui-wingeneral.h: Rename include guard.
12418         * tui/tui-windata.h: Rename include guard.
12419         * tui/tui-win.h: Rename include guard.
12420         * tui/tui-stack.h: Rename include guard.
12421         * tui/tui-source.h: Rename include guard.
12422         * tui/tui-regs.h: Rename include guard.
12423         * tui/tui-out.h: Rename include guard.
12424         * tui/tui-layout.h: Rename include guard.
12425         * tui/tui-io.h: Rename include guard.
12426         * tui/tui-hooks.h: Rename include guard.
12427         * tui/tui-file.h: Rename include guard.
12428         * tui/tui-disasm.h: Rename include guard.
12429         * tui/tui-data.h: Rename include guard.
12430         * tui/tui-command.h: Rename include guard.
12431         * tic6x-tdep.h: Add include guard.
12432         * target/waitstatus.h: Rename include guard.
12433         * target/wait.h: Rename include guard.
12434         * target/target.h: Rename include guard.
12435         * target/resume.h: Rename include guard.
12436         * target-float.h: Rename include guard.
12437         * stabsread.h: Add include guard.
12438         * rs6000-tdep.h: Add include guard.
12439         * riscv-fbsd-tdep.h: Add include guard.
12440         * regformats/regdef.h: Rename include guard.
12441         * record.h: Rename include guard.
12442         * python/python.h: Rename include guard.
12443         * python/python-internal.h: Rename include guard.
12444         * python/py-stopevent.h: Rename include guard.
12445         * python/py-ref.h: Rename include guard.
12446         * python/py-record.h: Rename include guard.
12447         * python/py-record-full.h: Rename include guard.
12448         * python/py-record-btrace.h: Rename include guard.
12449         * python/py-instruction.h: Rename include guard.
12450         * python/py-events.h: Rename include guard.
12451         * python/py-event.h: Rename include guard.
12452         * procfs.h: Add include guard.
12453         * proc-utils.h: Add include guard.
12454         * p-lang.h: Add include guard.
12455         * or1k-tdep.h: Rename include guard.
12456         * observable.h: Rename include guard.
12457         * nto-tdep.h: Rename include guard.
12458         * nat/x86-linux.h: Rename include guard.
12459         * nat/x86-linux-dregs.h: Rename include guard.
12460         * nat/x86-gcc-cpuid.h: Add include guard.
12461         * nat/x86-dregs.h: Rename include guard.
12462         * nat/x86-cpuid.h: Rename include guard.
12463         * nat/ppc-linux.h: Rename include guard.
12464         * nat/mips-linux-watch.h: Rename include guard.
12465         * nat/linux-waitpid.h: Rename include guard.
12466         * nat/linux-ptrace.h: Rename include guard.
12467         * nat/linux-procfs.h: Rename include guard.
12468         * nat/linux-osdata.h: Rename include guard.
12469         * nat/linux-nat.h: Rename include guard.
12470         * nat/linux-namespaces.h: Rename include guard.
12471         * nat/linux-btrace.h: Rename include guard.
12472         * nat/glibc_thread_db.h: Rename include guard.
12473         * nat/gdb_thread_db.h: Rename include guard.
12474         * nat/gdb_ptrace.h: Rename include guard.
12475         * nat/fork-inferior.h: Rename include guard.
12476         * nat/amd64-linux-siginfo.h: Rename include guard.
12477         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12478         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12479         * nat/aarch64-linux.h: Rename include guard.
12480         * nat/aarch64-linux-hw-point.h: Rename include guard.
12481         * mn10300-tdep.h: Add include guard.
12482         * mips-linux-tdep.h: Add include guard.
12483         * mi/mi-parse.h: Rename include guard.
12484         * mi/mi-out.h: Rename include guard.
12485         * mi/mi-main.h: Rename include guard.
12486         * mi/mi-interp.h: Rename include guard.
12487         * mi/mi-getopt.h: Rename include guard.
12488         * mi/mi-console.h: Rename include guard.
12489         * mi/mi-common.h: Rename include guard.
12490         * mi/mi-cmds.h: Rename include guard.
12491         * mi/mi-cmd-break.h: Rename include guard.
12492         * m2-lang.h: Add include guard.
12493         * location.h: Rename include guard.
12494         * linux-record.h: Rename include guard.
12495         * linux-nat.h: Add include guard.
12496         * linux-fork.h: Add include guard.
12497         * i386-darwin-tdep.h: Rename include guard.
12498         * hppa-linux-offsets.h: Add include guard.
12499         * guile/guile.h: Rename include guard.
12500         * guile/guile-internal.h: Rename include guard.
12501         * gnu-nat.h: Rename include guard.
12502         * gdb-stabs.h: Rename include guard.
12503         * frv-tdep.h: Add include guard.
12504         * f-lang.h: Add include guard.
12505         * event-loop.h: Add include guard.
12506         * darwin-nat.h: Rename include guard.
12507         * cp-abi.h: Rename include guard.
12508         * config/sparc/nm-sol2.h: Rename include guard.
12509         * config/nm-nto.h: Rename include guard.
12510         * config/nm-linux.h: Add include guard.
12511         * config/i386/nm-i386gnu.h: Rename include guard.
12512         * config/djgpp/nl_types.h: Rename include guard.
12513         * config/djgpp/langinfo.h: Rename include guard.
12514         * compile/gcc-cp-plugin.h: Add include guard.
12515         * compile/gcc-c-plugin.h: Add include guard.
12516         * compile/compile.h: Rename include guard.
12517         * compile/compile-object-run.h: Rename include guard.
12518         * compile/compile-object-load.h: Rename include guard.
12519         * compile/compile-internal.h: Rename include guard.
12520         * compile/compile-cplus.h: Rename include guard.
12521         * compile/compile-c.h: Rename include guard.
12522         * common/xml-utils.h: Rename include guard.
12523         * common/x86-xstate.h: Rename include guard.
12524         * common/version.h: Rename include guard.
12525         * common/vec.h: Rename include guard.
12526         * common/tdesc.h: Rename include guard.
12527         * common/selftest.h: Rename include guard.
12528         * common/scoped_restore.h: Rename include guard.
12529         * common/scoped_mmap.h: Rename include guard.
12530         * common/scoped_fd.h: Rename include guard.
12531         * common/safe-iterator.h: Rename include guard.
12532         * common/run-time-clock.h: Rename include guard.
12533         * common/refcounted-object.h: Rename include guard.
12534         * common/queue.h: Rename include guard.
12535         * common/ptid.h: Rename include guard.
12536         * common/print-utils.h: Rename include guard.
12537         * common/preprocessor.h: Rename include guard.
12538         * common/pathstuff.h: Rename include guard.
12539         * common/observable.h: Rename include guard.
12540         * common/netstuff.h: Rename include guard.
12541         * common/job-control.h: Rename include guard.
12542         * common/host-defs.h: Rename include guard.
12543         * common/gdb_wait.h: Rename include guard.
12544         * common/gdb_vecs.h: Rename include guard.
12545         * common/gdb_unlinker.h: Rename include guard.
12546         * common/gdb_unique_ptr.h: Rename include guard.
12547         * common/gdb_tilde_expand.h: Rename include guard.
12548         * common/gdb_sys_time.h: Rename include guard.
12549         * common/gdb_string_view.h: Rename include guard.
12550         * common/gdb_splay_tree.h: Rename include guard.
12551         * common/gdb_setjmp.h: Rename include guard.
12552         * common/gdb_ref_ptr.h: Rename include guard.
12553         * common/gdb_optional.h: Rename include guard.
12554         * common/gdb_locale.h: Rename include guard.
12555         * common/gdb_assert.h: Rename include guard.
12556         * common/filtered-iterator.h: Rename include guard.
12557         * common/filestuff.h: Rename include guard.
12558         * common/fileio.h: Rename include guard.
12559         * common/environ.h: Rename include guard.
12560         * common/common-utils.h: Rename include guard.
12561         * common/common-types.h: Rename include guard.
12562         * common/common-regcache.h: Rename include guard.
12563         * common/common-inferior.h: Rename include guard.
12564         * common/common-gdbthread.h: Rename include guard.
12565         * common/common-exceptions.h: Rename include guard.
12566         * common/common-defs.h: Rename include guard.
12567         * common/common-debug.h: Rename include guard.
12568         * common/cleanups.h: Rename include guard.
12569         * common/buffer.h: Rename include guard.
12570         * common/btrace-common.h: Rename include guard.
12571         * common/break-common.h: Rename include guard.
12572         * cli/cli-utils.h: Rename include guard.
12573         * cli/cli-style.h: Rename include guard.
12574         * cli/cli-setshow.h: Rename include guard.
12575         * cli/cli-script.h: Rename include guard.
12576         * cli/cli-interp.h: Rename include guard.
12577         * cli/cli-decode.h: Rename include guard.
12578         * cli/cli-cmds.h: Rename include guard.
12579         * charset-list.h: Add include guard.
12580         * buildsym-legacy.h: Rename include guard.
12581         * bfin-tdep.h: Add include guard.
12582         * ax.h: Rename include guard.
12583         * arm-linux-tdep.h: Add include guard.
12584         * arm-fbsd-tdep.h: Add include guard.
12585         * arch/xtensa.h: Rename include guard.
12586         * arch/tic6x.h: Add include guard.
12587         * arch/i386.h: Add include guard.
12588         * arch/arm.h: Rename include guard.
12589         * arch/arm-linux.h: Rename include guard.
12590         * arch/arm-get-next-pcs.h: Rename include guard.
12591         * arch/amd64.h: Add include guard.
12592         * arch/aarch64-insn.h: Rename include guard.
12593         * arch-utils.h: Rename include guard.
12594         * annotate.h: Add include guard.
12595         * amd64-darwin-tdep.h: Rename include guard.
12596         * aarch64-linux-tdep.h: Add include guard.
12597         * aarch64-fbsd-tdep.h: Add include guard.
12598         * aarch32-linux-nat.h: Add include guard.
12599
12600 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12601
12602         * macrotab.c (macro_define_internal): New function that
12603         factorizes macro_define_object_internal and macro_define_function
12604         code.
12605         (macro_define_object_internal): Use macro_define_internal.
12606         (macro_define_function): Likewise.
12607
12608 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12609
12610         * macrocmd.c (extract_identifier): Return
12611         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12612         callers.
12613
12614 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12615
12616         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12617
12618 2019-02-05  Tom Tromey  <tom@tromey.com>
12619
12620         * target.c (target_stack::unpush): Move assertion earlier.
12621
12622 2019-01-30  Tom Tromey  <tom@tromey.com>
12623
12624         PR python/23615:
12625         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12626         (gdbpy_parse_and_eval): Likewise.
12627         * python/python-internal.h (gdbpy_allow_threads): New class.
12628
12629 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12630
12631         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12632         (aarch64_fbsd_fpregmap): Move earlier.
12633         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12634         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12635         instead of individual calls to trad_frame_set_reg_addr.
12636         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12637         earlier.
12638         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12639         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12640         instead of individual calls to trad_frame_set_reg_addr.
12641
12642 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12643
12644         * CONTRIBUTE: Replace contribution list with wiki link.
12645
12646 2019-01-25  Tom Tromey  <tom@tromey.com>
12647
12648         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12649
12650 2019-01-25  Tom Tromey  <tom@tromey.com>
12651
12652         * xtensa-linux-nat.c: Fix common/ includes.
12653         * xml-support.h: Fix common/ includes.
12654         * xml-support.c: Fix common/ includes.
12655         * x86-linux-nat.c: Fix common/ includes.
12656         * windows-nat.c: Fix common/ includes.
12657         * varobj.h: Fix common/ includes.
12658         * varobj.c: Fix common/ includes.
12659         * value.c: Fix common/ includes.
12660         * valops.c: Fix common/ includes.
12661         * utils.c: Fix common/ includes.
12662         * unittests/xml-utils-selftests.c: Fix common/ includes.
12663         * unittests/utils-selftests.c: Fix common/ includes.
12664         * unittests/unpack-selftests.c: Fix common/ includes.
12665         * unittests/tracepoint-selftests.c: Fix common/ includes.
12666         * unittests/style-selftests.c: Fix common/ includes.
12667         * unittests/string_view-selftests.c: Fix common/ includes.
12668         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12669         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12670         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12671         * unittests/rsp-low-selftests.c: Fix common/ includes.
12672         * unittests/parse-connection-spec-selftests.c: Fix common/
12673         includes.
12674         * unittests/optional-selftests.c: Fix common/ includes.
12675         * unittests/offset-type-selftests.c: Fix common/ includes.
12676         * unittests/observable-selftests.c: Fix common/ includes.
12677         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12678         * unittests/memrange-selftests.c: Fix common/ includes.
12679         * unittests/memory-map-selftests.c: Fix common/ includes.
12680         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12681         * unittests/function-view-selftests.c: Fix common/ includes.
12682         * unittests/environ-selftests.c: Fix common/ includes.
12683         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12684         * unittests/common-utils-selftests.c: Fix common/ includes.
12685         * unittests/cli-utils-selftests.c: Fix common/ includes.
12686         * unittests/array-view-selftests.c: Fix common/ includes.
12687         * ui-file.c: Fix common/ includes.
12688         * tui/tui-io.c: Fix common/ includes.
12689         * tracepoint.h: Fix common/ includes.
12690         * tracepoint.c: Fix common/ includes.
12691         * tracefile-tfile.c: Fix common/ includes.
12692         * top.h: Fix common/ includes.
12693         * top.c: Fix common/ includes.
12694         * thread.c: Fix common/ includes.
12695         * target/waitstatus.h: Fix common/ includes.
12696         * target/waitstatus.c: Fix common/ includes.
12697         * target.h: Fix common/ includes.
12698         * target.c: Fix common/ includes.
12699         * target-memory.c: Fix common/ includes.
12700         * target-descriptions.c: Fix common/ includes.
12701         * symtab.h: Fix common/ includes.
12702         * symfile.c: Fix common/ includes.
12703         * stap-probe.c: Fix common/ includes.
12704         * spu-linux-nat.c: Fix common/ includes.
12705         * sparc-nat.c: Fix common/ includes.
12706         * source.c: Fix common/ includes.
12707         * solib.c: Fix common/ includes.
12708         * solib-target.c: Fix common/ includes.
12709         * ser-unix.c: Fix common/ includes.
12710         * ser-tcp.c: Fix common/ includes.
12711         * ser-pipe.c: Fix common/ includes.
12712         * ser-base.c: Fix common/ includes.
12713         * selftest-arch.c: Fix common/ includes.
12714         * s12z-tdep.c: Fix common/ includes.
12715         * rust-exp.y: Fix common/ includes.
12716         * rs6000-aix-tdep.c: Fix common/ includes.
12717         * riscv-tdep.c: Fix common/ includes.
12718         * remote.c: Fix common/ includes.
12719         * remote-notif.h: Fix common/ includes.
12720         * remote-fileio.h: Fix common/ includes.
12721         * remote-fileio.c: Fix common/ includes.
12722         * regcache.h: Fix common/ includes.
12723         * regcache.c: Fix common/ includes.
12724         * record-btrace.c: Fix common/ includes.
12725         * python/python.c: Fix common/ includes.
12726         * python/py-type.c: Fix common/ includes.
12727         * python/py-inferior.c: Fix common/ includes.
12728         * progspace.h: Fix common/ includes.
12729         * producer.c: Fix common/ includes.
12730         * procfs.c: Fix common/ includes.
12731         * proc-api.c: Fix common/ includes.
12732         * printcmd.c: Fix common/ includes.
12733         * ppc-linux-nat.c: Fix common/ includes.
12734         * parser-defs.h: Fix common/ includes.
12735         * osdata.c: Fix common/ includes.
12736         * obsd-nat.c: Fix common/ includes.
12737         * nat/x86-linux.c: Fix common/ includes.
12738         * nat/x86-linux-dregs.c: Fix common/ includes.
12739         * nat/x86-dregs.h: Fix common/ includes.
12740         * nat/x86-dregs.c: Fix common/ includes.
12741         * nat/ppc-linux.c: Fix common/ includes.
12742         * nat/mips-linux-watch.h: Fix common/ includes.
12743         * nat/mips-linux-watch.c: Fix common/ includes.
12744         * nat/linux-waitpid.c: Fix common/ includes.
12745         * nat/linux-ptrace.h: Fix common/ includes.
12746         * nat/linux-ptrace.c: Fix common/ includes.
12747         * nat/linux-procfs.c: Fix common/ includes.
12748         * nat/linux-personality.c: Fix common/ includes.
12749         * nat/linux-osdata.c: Fix common/ includes.
12750         * nat/linux-namespaces.c: Fix common/ includes.
12751         * nat/linux-btrace.h: Fix common/ includes.
12752         * nat/linux-btrace.c: Fix common/ includes.
12753         * nat/fork-inferior.c: Fix common/ includes.
12754         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12755         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12756         * nat/aarch64-linux.c: Fix common/ includes.
12757         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12758         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12759         * namespace.h: Fix common/ includes.
12760         * mips-linux-tdep.c: Fix common/ includes.
12761         * minsyms.c: Fix common/ includes.
12762         * mi/mi-parse.h: Fix common/ includes.
12763         * mi/mi-main.c: Fix common/ includes.
12764         * mi/mi-cmd-env.c: Fix common/ includes.
12765         * memrange.h: Fix common/ includes.
12766         * memattr.c: Fix common/ includes.
12767         * maint.h: Fix common/ includes.
12768         * maint.c: Fix common/ includes.
12769         * main.c: Fix common/ includes.
12770         * machoread.c: Fix common/ includes.
12771         * location.c: Fix common/ includes.
12772         * linux-thread-db.c: Fix common/ includes.
12773         * linux-nat.c: Fix common/ includes.
12774         * linux-fork.c: Fix common/ includes.
12775         * inline-frame.c: Fix common/ includes.
12776         * infrun.c: Fix common/ includes.
12777         * inflow.c: Fix common/ includes.
12778         * inferior.h: Fix common/ includes.
12779         * inferior.c: Fix common/ includes.
12780         * infcmd.c: Fix common/ includes.
12781         * inf-ptrace.c: Fix common/ includes.
12782         * inf-child.c: Fix common/ includes.
12783         * ia64-linux-nat.c: Fix common/ includes.
12784         * i387-tdep.c: Fix common/ includes.
12785         * i386-tdep.c: Fix common/ includes.
12786         * i386-linux-tdep.c: Fix common/ includes.
12787         * i386-linux-nat.c: Fix common/ includes.
12788         * i386-go32-tdep.c: Fix common/ includes.
12789         * i386-fbsd-tdep.c: Fix common/ includes.
12790         * i386-fbsd-nat.c: Fix common/ includes.
12791         * guile/scm-type.c: Fix common/ includes.
12792         * guile/guile.c: Fix common/ includes.
12793         * go32-nat.c: Fix common/ includes.
12794         * gnu-nat.c: Fix common/ includes.
12795         * gdbthread.h: Fix common/ includes.
12796         * gdbarch-selftests.c: Fix common/ includes.
12797         * gdb_usleep.c: Fix common/ includes.
12798         * gdb_select.h: Fix common/ includes.
12799         * gdb_bfd.c: Fix common/ includes.
12800         * gcore.c: Fix common/ includes.
12801         * fork-child.c: Fix common/ includes.
12802         * findvar.c: Fix common/ includes.
12803         * fbsd-nat.c: Fix common/ includes.
12804         * event-top.c: Fix common/ includes.
12805         * event-loop.c: Fix common/ includes.
12806         * dwarf2read.c: Fix common/ includes.
12807         * dwarf2loc.c: Fix common/ includes.
12808         * dwarf2-frame.c: Fix common/ includes.
12809         * dwarf-index-cache.c: Fix common/ includes.
12810         * dtrace-probe.c: Fix common/ includes.
12811         * disasm-selftests.c: Fix common/ includes.
12812         * defs.h: Fix common/ includes.
12813         * csky-tdep.c: Fix common/ includes.
12814         * cp-valprint.c: Fix common/ includes.
12815         * cp-support.h: Fix common/ includes.
12816         * cp-support.c: Fix common/ includes.
12817         * corelow.c: Fix common/ includes.
12818         * completer.h: Fix common/ includes.
12819         * completer.c: Fix common/ includes.
12820         * compile/compile.c: Fix common/ includes.
12821         * compile/compile-loc2c.c: Fix common/ includes.
12822         * compile/compile-cplus-types.c: Fix common/ includes.
12823         * compile/compile-cplus-symbols.c: Fix common/ includes.
12824         * command.h: Fix common/ includes.
12825         * cli/cli-dump.c: Fix common/ includes.
12826         * cli/cli-cmds.c: Fix common/ includes.
12827         * charset.c: Fix common/ includes.
12828         * build-id.c: Fix common/ includes.
12829         * btrace.h: Fix common/ includes.
12830         * btrace.c: Fix common/ includes.
12831         * breakpoint.h: Fix common/ includes.
12832         * breakpoint.c: Fix common/ includes.
12833         * ax.h:
12834         (enum agent_op): Fix common/ includes.
12835         * ax-general.c (struct aop_map): Fix common/ includes.
12836         * ax-gdb.c: Fix common/ includes.
12837         * auxv.c: Fix common/ includes.
12838         * auto-load.c: Fix common/ includes.
12839         * arm-tdep.c: Fix common/ includes.
12840         * arch/riscv.c: Fix common/ includes.
12841         * arch/ppc-linux-common.c: Fix common/ includes.
12842         * arch/i386.c: Fix common/ includes.
12843         * arch/arm.c: Fix common/ includes.
12844         * arch/arm-linux.c: Fix common/ includes.
12845         * arch/arm-get-next-pcs.c: Fix common/ includes.
12846         * arch/amd64.c: Fix common/ includes.
12847         * arch/aarch64.c: Fix common/ includes.
12848         * arch/aarch64-insn.c: Fix common/ includes.
12849         * arch-utils.c: Fix common/ includes.
12850         * amd64-windows-tdep.c: Fix common/ includes.
12851         * amd64-tdep.c: Fix common/ includes.
12852         * amd64-sol2-tdep.c: Fix common/ includes.
12853         * amd64-obsd-tdep.c: Fix common/ includes.
12854         * amd64-nbsd-tdep.c: Fix common/ includes.
12855         * amd64-linux-tdep.c: Fix common/ includes.
12856         * amd64-linux-nat.c: Fix common/ includes.
12857         * amd64-fbsd-tdep.c: Fix common/ includes.
12858         * amd64-fbsd-nat.c: Fix common/ includes.
12859         * amd64-dicos-tdep.c: Fix common/ includes.
12860         * amd64-darwin-tdep.c: Fix common/ includes.
12861         * agent.c: Fix common/ includes.
12862         * ada-lang.h: Fix common/ includes.
12863         * ada-lang.c: Fix common/ includes.
12864         * aarch64-tdep.c: Fix common/ includes.
12865
12866 2019-01-25  Tom Tromey  <tom@tromey.com>
12867
12868         * common/create-version.sh: Use common/version.h.
12869
12870 2019-01-24  Pedro Alves  <palves@redhat.com>
12871
12872         * infrun.c (signal_stop, signal_print, signal_program)
12873         (signal_catch, signal_pass): Now arrays instead of pointers.
12874         (update_signals_program_target, do_target_resume)
12875         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12876         * linux-nat.c (linux_nat_target::pass_signals)
12877         (linux_nat_target::create_inferior, linux_nat_target::attach):
12878         Adjust.
12879         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12880         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12881         * procfs.c (procfs_target::pass_signals): Adjust.
12882         * record-full.c (record_full_target::resume): Adjust.
12883         * remote.c (remote_target::pass_signals)
12884         (remote_target::program_signals): Adjust.
12885         * target-debug.h (target_debug_print_signals): Now takes a
12886         gdb::array_view as parameter.  Adjust.
12887         * target.h (target_ops) <pass_signals, program_signals>: Replace
12888         pointer and length parameters with gdb::array_view.
12889         (target_pass_signals, target_program_signals): Likewise.
12890         * target-delegates.c: Regenerate.
12891
12892 2019-01-24  Pedro Alves  <palves@redhat.com>
12893
12894         * common/forward-scope-exit.h
12895         (forward_scope_exit::forward_scope_exit): Pass arguments to
12896         m_bind_function directly, instead of creating a std::bind and
12897         copying that.
12898
12899 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12900
12901         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12902         for static members.
12903         (pass_in_v_vfp_candidate): Likewise.
12904
12905 2019-01-23  Tom Tromey  <tom@tromey.com>
12906             Pedro Alves  <palves@redhat.com>
12907
12908         * regcache.c (class regcache_invalidator): Remove.
12909         (regcache::raw_write): Use make_scope_exit.
12910
12911 2019-01-23  Tom Tromey  <tom@tromey.com>
12912
12913         * ui-out.h (class ui_out_emit_type): Update comment.
12914
12915 2019-01-23  Tom Tromey  <tom@tromey.com>
12916
12917         * infrun.c (fetch_inferior_event): Update comment.
12918
12919 2019-01-23  Tom Tromey  <tom@tromey.com>
12920             Pedro Alves  <palves@redhat.com>
12921
12922         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12923         parameter.
12924         (fetch_inferior_event): Use SCOPE_EXIT.
12925
12926
12927 2019-01-23  Tom Tromey  <tom@tromey.com>
12928             Pedro Alves  <palves@redhat.com>
12929
12930         * infrun.c (disable_thread_events): Delete.
12931         (stop_all_threads): Use SCOPE_EXIT.
12932
12933 2019-01-23  Tom Tromey  <tom@tromey.com>
12934             Pedro Alves  <palves@redhat.com>
12935
12936         * symfile.c: Include forward-scope-exit.h.
12937         (clear_symtab_users_cleanup): Replace forward declaration with
12938         a FORWARD_SCOPE_EXIT.
12939         (syms_from_objfile_1): Use the forward_scope_exit and
12940         gdb::optional instead of cleanup_function.
12941         (reread_symbols): Use the forward_scope_exit instead of
12942         cleanup_function.
12943         (clear_symtab_users_cleanup): Remove function.
12944
12945 2019-01-23  Tom Tromey  <tom@tromey.com>
12946             Pedro Alves  <palves@redhat.com>
12947
12948         * linux-nat.c: Include scope-exit.h.
12949         (cleanup_target_stop): Remove.
12950         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12951         SCOPE_EXIT.
12952
12953 2019-01-23  Tom Tromey  <tom@tromey.com>
12954             Pedro Alves  <palves@redhat.com>
12955
12956         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12957         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12958
12959 2019-01-23  Tom Tromey  <tom@tromey.com>
12960             Andrew Burgess  <andrew.burgess@embecosm.com>
12961             Pedro Alves  <palves@redhat.com>
12962
12963         * infrun.c (fetch_inferior_event): Use scope_exit.
12964         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12965         * top.c (execute_command): Use scope_exit.
12966         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12967         * utils.c (do_bpstat_clear_actions_cleanup)
12968         (make_bpstat_clear_actions_cleanup): Remove.
12969
12970 2019-01-23  Tom Tromey  <tom@tromey.com>
12971             Pedro Alves  <palves@redhat.com>
12972
12973         * infrun.c: Include "common/scope-exit.h"
12974         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12975         (wait_for_inferior): Use SCOPE_EXIT.
12976         (fetch_inferior_event): Use scope_exit.
12977
12978 2019-01-23  Tom Tromey  <tom@tromey.com>
12979             Pedro Alves  <palves@redhat.com>
12980
12981         * breakpoint.c (create_breakpoint): Remove cleanup.
12982
12983 2019-01-23  Tom Tromey  <tom@tromey.com>
12984             Andrew Burgess  <andrew.burgess@embecosm.com>
12985             Pedro Alves  <palves@redhat.com>
12986
12987 2019-01-23  Pedro Alves  <palves@redhat.com>
12988
12989         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12990
12991 2019-01-23  Pedro Alves  <palves@redhat.com>
12992             Andrew Burgess  <andrew.burgess@embecosm.com>
12993
12994         * gdbthread.h: Include "common/forward-scope-exit.h".
12995         (scoped_finish_thread_state): Redefine custom class in terms of
12996         forward_scope_exit.
12997
12998 2019-01-23  Pedro Alves  <palves@redhat.com>
12999             Andrew Burgess  <andrew.burgess@embecosm.com>
13000
13001         * common/forward-scope-exit.h: New file.
13002
13003 2019-01-23  Pedro Alves  <palves@redhat.com>
13004             Andrew Burgess  <andrew.burgess@embecosm.com>
13005             Tom Tromey  <tom@tromey.com>
13006
13007         * common/scope-exit.h: New file.
13008
13009 2019-01-23  Pedro Alves  <palves@redhat.com>
13010
13011         * common/preprocessor.h (ESC): Rename to ...
13012         (ESC_PARENS): ... this.
13013         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13014         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13015
13016 2019-01-23  Tom Tromey  <tom@tromey.com>
13017
13018         * language.h (class scoped_switch_to_sym_language_if_auto):
13019         Initialize m_lang in both cases.
13020
13021 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13022
13023         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13024         with XCNEW.
13025
13026 2019-01-22  Tom Tromey  <tom@tromey.com>
13027
13028         * corelow.c: Do not include sys/file.h.
13029
13030 2019-01-22  Tom Tromey  <tom@tromey.com>
13031
13032         * tui/tui-wingeneral.h: Include gdb_curses.h.
13033
13034 2019-01-22  Tom Tromey  <tom@tromey.com>
13035
13036         * source-cache.h (class source_cache) <get_source_lines,
13037         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13038
13039 2019-01-22  Tom Tromey  <tom@tromey.com>
13040
13041         * remote-fileio.h (struct remote_target): Declare.
13042
13043 2019-01-22  Tom Tromey  <tom@tromey.com>
13044
13045         * python/py-arch.c: Do not include py-ref.h.
13046         * python/py-bpevent.c: Do not include py-ref.h.
13047         * python/py-cmd.c: Do not include py-ref.h.
13048         * python/py-continueevent.c: Do not include py-ref.h.
13049         * python/py-event.h: Do not include py-ref.h.
13050         * python/py-evtregistry.c: Do not include py-ref.h.
13051         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13052         * python/py-frame.c: Do not include py-ref.h.
13053         * python/py-framefilter.c: Do not include py-ref.h.
13054         * python/py-function.c: Do not include py-ref.h.
13055         * python/py-infevents.c: Do not include py-ref.h.
13056         * python/py-linetable.c: Do not include py-ref.h.
13057         * python/py-objfile.c: Do not include py-ref.h.
13058         * python/py-param.c: Do not include py-ref.h.
13059         * python/py-prettyprint.c: Do not include py-ref.h.
13060         * python/py-progspace.c: Do not include py-ref.h.
13061         * python/py-symbol.c: Do not include py-ref.h.
13062         * python/py-symtab.c: Do not include py-ref.h.
13063         * python/py-type.c: Do not include py-ref.h.
13064         * python/py-unwind.c: Do not include py-ref.h.
13065         * python/py-utils.c: Do not include py-ref.h.
13066         * python/py-value.c: Do not include py-ref.h.
13067         * python/py-varobj.c: Do not include py-ref.h.
13068         * python/py-xmethods.c: Do not include py-ref.h.
13069         * python/python.c: Do not include py-ref.h.
13070         * varobj.c: Do not include py-ref.h.
13071
13072 2019-01-22  Tom Tromey  <tom@tromey.com>
13073
13074         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13075         keyword for bcache.
13076
13077 2019-01-22  Tom Tromey  <tom@tromey.com>
13078
13079         * compile/compile-cplus-types.c: Remove a comment by #include.
13080
13081 2019-01-22  Tom Tromey  <tom@tromey.com>
13082
13083         * compile/gcc-c-plugin.h: Include compile-internal.h.
13084
13085 2019-01-22  Tom Tromey  <tom@tromey.com>
13086
13087         * stabsread.c (EXTERN): Do not define.
13088         (symnum, next_symbol_text_func, processing_gcc_compilation)
13089         (within_function, global_sym_chain, global_stabs)
13090         (previous_stab_code, this_object_header_files)
13091         (n_this_object_header_files)
13092         (n_allocated_this_object_header_files): Define.
13093         * stabsread.h (EXTERN): Never define.  Use "extern".
13094
13095 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13096
13097         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13098         history_value.
13099
13100 2019-01-21  Tom Tromey  <tom@tromey.com>
13101
13102         * ui-out.c: Fix includes.
13103         * tui/tui-source.c: Fix includes.
13104         * target.c: Fix includes.
13105         * remote.c: Fix includes.
13106         * regcache.c: Fix includes.
13107         * python/py-block.c: Fix includes.
13108         * printcmd.c: Fix includes.
13109         * or1k-tdep.c: Fix includes.
13110         * mi/mi-main.c: Fix includes.
13111         * m32r-tdep.c: Fix includes.
13112         * csky-tdep.c: Fix includes.
13113         * compile/compile-cplus-types.c: Fix includes.
13114         * cli/cli-interp.c: Fix includes.
13115
13116 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13117
13118         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13119         for padding.
13120
13121 2019-01-16  Tom Tromey  <tom@tromey.com>
13122
13123         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13124         earlier.
13125         (struct objfile) <msymbols_range>: Move from top level.
13126         <msymbols>: New method.
13127         (class objfile_msymbols): Remove.
13128         * symtab.c (default_collect_symbol_completion_matches_break_on):
13129         Update.
13130         * symmisc.c (dump_msymbols): Update.
13131         * stabsread.c (scan_file_globals): Update.
13132         * objc-lang.c (info_selectors_command, info_classes_command)
13133         (find_methods): Update.
13134         * minsyms.c (find_solib_trampoline_target): Update.
13135         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13136         * coffread.c (coff_symfile_read): Update.
13137         * ada-lang.c (ada_lookup_simple_minsym)
13138         (ada_collect_symbol_completion_matches): Update.
13139
13140 2019-01-16  Tom Tromey  <tom@tromey.com>
13141
13142         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13143         type.  Remove no-argument constructor.
13144         <iterator::operator++>: Simplify.
13145         <begin>: Update.
13146         <end>: Use minimal_symbol_count.
13147
13148 2019-01-16  Tom Tromey  <tom@tromey.com>
13149
13150         * objfiles.h (struct objfile) <psymtabs>: New method.
13151         (class objfile_psymtabs): Remove.
13152         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13153         typedef.
13154         <range>: New method.
13155         (require_partial_symbols): Change return type.
13156         * psymtab.c (require_partial_symbols)
13157         (psym_expand_symtabs_matching): Update.
13158         * mdebugread.c (parse_partial_symbols): Update.
13159         * dbxread.c (dbx_end_psymtab): Update.
13160
13161 2019-01-15  Tom Tromey  <tom@tromey.com>
13162
13163         * symtab.c (lookup_objfile_from_block)
13164         (lookup_symbol_in_objfile_symtabs)
13165         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13166         (find_line_symtab, info_sources_command)
13167         (default_collect_symbol_completion_matches_break_on)
13168         (make_source_files_completion_list): Update.
13169         * symmisc.c (print_objfile_statistics, dump_objfile)
13170         (maintenance_print_symbols, maintenance_info_symtabs)
13171         (maintenance_check_symtabs, maintenance_info_line_tables):
13172         Update.
13173         * source.c (select_source_symtab)
13174         (forget_cached_source_info_for_objfile): Update.
13175         * objfiles.h (class objfile_compunits): Remove.
13176         (struct objfile) <compunits_range>: New typedef.
13177         (compunits): New method.
13178         * objfiles.c (objfile_relocate1): Update.
13179         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13180         * maint.c (count_symtabs_and_blocks): Update.
13181         * linespec.c (iterate_over_all_matching_symtabs): Update.
13182         * cp-support.c (add_symbol_overload_list_qualified): Update.
13183         * coffread.c (coff_symtab_read): Update.
13184         * ada-lang.c (add_nonlocal_symbols)
13185         (ada_collect_symbol_completion_matches)
13186         (ada_add_global_exceptions): Update.
13187
13188 2019-01-15  Tom Tromey  <tom@tromey.com>
13189
13190         * progspace.h (program_space) <objfiles_safe_range>: New
13191         typedef.
13192         <objfiles_safe>: New method.
13193         * objfiles.h (class all_objfiles_safe): Remove.
13194         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13195         * jit.c (jit_inferior_exit_hook): Update.
13196
13197 2019-01-17  Tom Tromey  <tom@tromey.com>
13198
13199         * progspace.h (program_space) <objfiles_range>: New typedef.
13200         <objfiles>: New method.
13201         <objfiles_head>: Rename from objfiles.
13202         (object_files): Update.
13203         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13204         * guile/scm-pretty-print.c
13205         (ppscm_find_pretty_printer_from_objfiles): Update.
13206         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13207         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13208         Update.
13209         * python/py-progspace.c (pspy_get_objfiles): Update.
13210         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13211         Update.
13212         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13213         (objfpy_lookup_objfile_by_build_id): Update.
13214         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13215         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13216         Update.
13217         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13218         (expand_symtab_containing_pc, lookup_objfile_from_block)
13219         (lookup_static_symbol, basic_lookup_transparent_type)
13220         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13221         (find_line_symtab, info_sources_command)
13222         (default_collect_symbol_completion_matches_break_on)
13223         (make_source_files_completion_list, find_main_name): Update.
13224         * symmisc.c (print_symbol_bcache_statistics)
13225         (print_objfile_statistics, maintenance_print_symbols)
13226         (maintenance_print_msymbols, maintenance_print_objfiles)
13227         (maintenance_info_symtabs, maintenance_check_symtabs)
13228         (maintenance_expand_symtabs, maintenance_info_line_tables):
13229         Update.
13230         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13231         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13232         (map_overlay_command, unmap_overlay_command)
13233         (simple_overlay_update, expand_symtabs_matching)
13234         (map_symbol_filenames): Update.
13235         * symfile-debug.c (set_debug_symfile): Update.
13236         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13237         Update.
13238         * source.c (select_source_symtab, forget_cached_source_info):
13239         Update.
13240         * solib.c (solib_read_symbols): Update.
13241         * solib-spu.c (append_ocl_sos): Update.
13242         * psymtab.c (maintenance_print_psymbols)
13243         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13244         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13245         * printcmd.c (info_symbol_command): Update.
13246         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13247         Update.
13248         * objfiles.h (class all_objfiles): Remove.
13249         * objfiles.c (have_partial_symbols, have_full_symbols)
13250         (have_minimal_symbols, qsort_cmp, update_section_map)
13251         (shared_objfile_contains_address_p)
13252         (default_iterate_over_objfiles_in_search_order): Update.
13253         * objc-lang.c (info_selectors_command, info_classes_command)
13254         (find_methods): Update.
13255         * minsyms.c (find_solib_trampoline_target): Update.
13256         * maint.c (maintenance_info_sections)
13257         (maintenance_translate_address, count_symtabs_and_blocks):
13258         Update.
13259         * main.c (captured_main_1): Update.
13260         * linux-thread-db.c (try_thread_db_load_from_pdir)
13261         (has_libpthread): Update.
13262         * linespec.c (iterate_over_all_matching_symtabs)
13263         (search_minsyms_for_name): Update.
13264         * jit.c (jit_find_objf_with_entry_addr): Update.
13265         * hppa-tdep.c (find_unwind_entry)
13266         (hppa_lookup_stub_minimal_symbol): Update.
13267         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13268         Update.
13269         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13270         (elf_gnu_ifunc_resolve_by_got): Update.
13271         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13272         * dwarf-index-write.c (save_gdb_index_command): Update.
13273         * cp-support.c (add_symbol_overload_list_qualified): Update.
13274         * breakpoint.c (create_overlay_event_breakpoint)
13275         (create_longjmp_master_breakpoint)
13276         (create_std_terminate_master_breakpoint)
13277         (create_exception_master_breakpoint): Update.
13278         * blockframe.c (find_pc_partial_function): Update.
13279         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13280         (ada_collect_symbol_completion_matches)
13281         (ada_add_global_exceptions): Update.
13282
13283 2019-01-17  Tom Tromey  <tom@tromey.com>
13284
13285         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13286         declare VEC.
13287         (solib_target_parse_libraries): Change return type.
13288         (library_list_start_segment, library_list_start_section)
13289         (library_list_end_library, library_list_start_library); Update.
13290         (solib_target_free_library_list): Remove.
13291         (solib_target_parse_libraries): Remove cleanup.  Change return
13292         type.
13293         (solib_target_current_sos): Update.
13294
13295 2019-01-17  Tom Tromey  <tromey@bapiya>
13296
13297         * valprint.c: Replace "the the" with "the".
13298         * symtab.c: Replace "the the" with "the".
13299         * solib.c: Replace "the the" with "the".
13300         * solib-dsbt.c: Replace "the the" with "the".
13301         * linespec.c: Replace "the the" with "the".
13302         * dwarf2loc.h: Replace "the the" with "the".
13303         * amd64-windows-tdep.c: Replace "the the" with "the".
13304         * aarch64-tdep.c: Replace "the the" with "the".
13305
13306 2019-01-16  Keith Seitz  <keiths@redhat.com>
13307
13308         PR gdb/23773
13309         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13310         <builder>: Rename to ..
13311         <m_builder>: ... this and make private.
13312         (dwarf2_cu::get_builder): New method.  Change all users of
13313         `builder' to use this method.
13314         (dwarf2_start_symtab): Move to ...
13315         (dwarf2_cu::start_symtab): ... here.  Update all callers
13316         (setup_type_unit_groups): Move to ...
13317         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13318         callers.
13319         (dwarf2_cu::reset_builder): New method.
13320         (process_full_compunit, process_full_type_unit): Use
13321         dwarf2_cu::reset_builder.
13322         (follow_die_offset): Record the ancestor CU if it is different
13323         from the followed DIE's CU.
13324         (follow_die_sig_1): Likewise.
13325
13326 2019-01-15  Tom Tromey  <tom@tromey.com>
13327
13328         * remote.c (class remote_state) <buf>: Now a char_vector.
13329         <buf_size>: Remove.
13330         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13331         parameter.
13332         (remote_target::getpkt_or_notif_sane_1)
13333         (remote_target::getpkt_sane)
13334         (remote_target::getpkt_or_notif_sane): Likewise.
13335         (class remote_target) <putpkt>: New overload.
13336         (remote_target::read_frame): Change type of "buf_p".  Remove
13337         sizeof_p parameter.
13338         (packet_ok): New overload.
13339         (packet_check_result): New overload.
13340         Update all uses.
13341
13342 2019-01-14  Tom Tromey  <tom@tromey.com>
13343
13344         * remote-notif.c (handle_notification, remote_notif_ack)
13345         (remote_notif_parse): Make "buf" const.
13346         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13347         const.
13348         (remote_notif_parse, remote_notif_ack, handle_notification):
13349         Likewise.
13350         * remote.c (remote_notif_stop_parse): Make "buf" const.
13351         (remote_target::remote_parse_stop_reply): Make "buf" const.
13352         (remote_notif_stop_ack): Make "buf" const.
13353
13354 2019-01-14  Tom Tromey  <tom@tromey.com>
13355
13356         * remote.c (remote_console_output): Make parameter const.
13357
13358 2019-01-14  Tom Tromey  <tom@tromey.com>
13359
13360         * target-debug.h (target_debug_print_signals): Constify.
13361         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13362         * procfs.c (procfs_target::pass_signals): Update.
13363         * linux-nat.c (linux_nat_target::pass_signals): Update.
13364         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13365         * target-delegates.c: Rebuild.
13366         * remote.c (remote_target::program_signals): Update.
13367         (remote_target::pass_signals): Update.
13368         * target.c (target_pass_signals): Constify argument.
13369         (target_program_signals): Likewise.
13370         * target.h (struct target_ops) <pass_signals, program_signals>:
13371         Constify argument.
13372         (target_pass_signals, target_program_signals): Constify argument.
13373
13374 2019-01-14  Tom Tromey  <tom@tromey.com>
13375
13376         PR tui/28819:
13377         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13378
13379 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13380
13381         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13382         field.
13383         * rs6000-tdep.c: Include reggroups.h.
13384         (IS_V_ALIAS_PSEUDOREG): Define.
13385         (rs6000_register_name): Return names for the "vX" aliases.
13386         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13387         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13388         aliases.  Call default_register_reggroup_p for all other
13389         pseudo-registers.
13390         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13391         New functions.
13392         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13393         Handle "vX" aliases.
13394         (v_alias_pseudo_register_collect): New function.
13395         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13396         (rs6000_gdbarch_init): Initialize "vX" aliases as
13397         pseudo-registers.  Restore registration of
13398         rs6000_pseudo_register_reggroup_p with
13399         set_tdesc_pseudo_register_reggroup_p.
13400
13401 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13402
13403         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13404         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13405         set_gdbarch_num_pseudo_regs.
13406
13407 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13408
13409         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13410         Remove arg prefixname, add do_set and do_show.
13411         Add member functions set_list and show_list.
13412         * cli/cli-style.c (class cli_style_option): Update accordingly.
13413         (style_set_list): Move to file scope.
13414         (style_show_list): Likewise.
13415         (set_style): Call help_list.
13416         (show_style): Call cmd_show_list.
13417         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13418         Update to use the new macro.
13419
13420 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13421
13422         * ada-lang.c (_initialize_ada_language): Expand the help text
13423         for the "catch exception" command.
13424
13425 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13426
13427         * symtab.c (matching_obj_sections): Initialize obj,
13428         declare it closer to its usage.
13429
13430 2019-01-10  Tom Tromey  <tom@tromey.com>
13431
13432         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13433         (basic_inf_threads_range): Remove.
13434         (inf_threads_range, inf_non_exited_threads_range)
13435         (safe_inf_threads_range): Use next_adapter.
13436
13437 2019-01-10  Keith Seitz  <keiths@redhat.com>
13438
13439         PR gdb/23712
13440         PR symtab/23010
13441         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13442         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13443
13444 2019-01-10  Keith Seitz  <keiths@redhat.com>
13445
13446         PR gdb/23712
13447         PR symtab/23010
13448         * dictionary.c (pending_to_vector): Remove.
13449         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13450         Remove _1 suffix, replacing functions of the same name.  Update
13451         all callers.
13452         (dict_create_hashed, dict_create_hashed_expandable)
13453         (dict_create_linear, dict_create_linear_expandable, dict_free)
13454         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13455         Make functions static.
13456
13457 2019-01-10  Keith Seitz  <keiths@redhat.com>
13458
13459         PR gdb/23712
13460         PR symtab/23010
13461         * dictionary.h (struct dictionary): Replace declaration with
13462         multidictionary.
13463         (dict_create_hashed, dict_create_hashed_expandable)
13464         (dict_create_linear, dict_create_linear_expandable)
13465         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13466         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13467         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13468         taking multidictionary argument.
13469         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13470         * block.h (struct block) <dict>: Change to multidictionary
13471         and rename `multidict'.
13472         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13473         symmisc.c: Update all dictionary references to multidictionary.
13474
13475 2019-01-10  Keith Seitz  <keiths@redhat.com>
13476
13477         PR gdb/23712
13478         PR symtab/23010
13479         * dictionary.c: Include unordered_map.
13480         (pending_to_vector): New function.
13481         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13482         Rewrite the non-"_1" functions to take vector instead
13483         of linked list.
13484         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13485         "new" _1 versions of the same name.
13486         (multidictionary): Define.
13487         (std::hash<enum language): New definition.
13488         (collate_pending_symbols_by_language, mdict_create_hashed)
13489         (mdict_create_hashed_expandable, mdict_create_linear)
13490         (mdict_create_linear_expandable, mdict_free)
13491         (find_language_dictionary, create_new_language_dictionary)
13492         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13493         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13494         (mdict_size, mdict_empty): New functions.
13495         * dictionary.h (mdict_iterator): Define.
13496
13497 2019-01-10  Pedro Alves  <palves@redhat.com>
13498
13499         * breakpoint.c (read_uploaded_action)
13500         (create_tracepoint_from_upload): Adjust to use
13501         gdb::unique_xmalloc_ptr.
13502         * ctf.c (ctf_write_uploaded_tp):
13503         (SET_ARRAY_FIELD): Use emplace_back.
13504         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13505         * tracefile-tfile.c (tfile_write_uploaded_tp):
13506         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13507         gdb::unique_xmalloc_ptr.
13508         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13509         at_string, cond_string, cmd_strings>: Replace char pointers
13510         with gdb::unique_xmalloc_ptr.
13511
13512 2019-01-10  Pedro Alves  <palves@redhat.com>
13513
13514         * solib-target.c (library_list_start_library): Don't xstrdup name.
13515
13516 2019-01-10  Pedro Alves  <palves@redhat.com>
13517
13518         * mdebugread.c (parse_partial_symbols): Use
13519         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13520
13521 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13522
13523         * linux-fork.c (scoped_switch_fork_info)
13524         <~scoped_switch_fork_info>: Fix incorrect variable name.
13525
13526 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13527
13528         * linux-fork.c (scoped_switch_fork_info)
13529         <scoped_switch_fork_info>: Make explicit.
13530         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13531
13532 2019-01-10  Tom Tromey  <tom@tromey.com>
13533
13534         * objfiles.h (objfile::reset_psymtabs): Update.
13535         * objfiles.c (objfile::objfile): Update.
13536         * psymtab.h (psymtab_storage::obstack): Update.
13537         (psymtab_storage::m_obstack): Use gdb::optional.
13538         (class psymtab_storage): Update comment.  Remove objfile
13539         parameter.
13540         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13541
13542 2019-01-10  Tom Tromey  <tom@tromey.com>
13543
13544         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13545         <free_psymtabs>: Now private.
13546         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13547         (allocate_psymtab): Use new method.
13548
13549 2019-01-10  Tom Tromey  <tom@tromey.com>
13550
13551         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13552         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13553         * mdebugread.c (parse_partial_symbols): Use
13554         allocate_dependencies.
13555         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13556         allocate_dependencies.
13557         (process_psymtab_comp_unit_reader)
13558         (build_type_psymtab_dependencies): Likewise.
13559         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13560
13561 2019-01-10  Tom Tromey  <tom@tromey.com>
13562
13563         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13564         PSYMBOL_SET_LANGUAGE.
13565         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13566
13567 2019-01-10  Tom Tromey  <tom@tromey.com>
13568
13569         * psymtab.h (psymtab_storage::obstack): New method.
13570         <m_obstack>: Rename from obstack; now private.
13571         * psymtab.c (psymtab_storage): Update.
13572         * dwarf2read.c (create_addrmap_from_index)
13573         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13574         Update.
13575
13576 2019-01-10  Tom Tromey  <tom@tromey.com>
13577
13578         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13579         * objfiles.h (objfile::reset_psymtabs): New method.
13580
13581 2019-01-10  Tom Tromey  <tom@tromey.com>
13582
13583         * symmisc.c (print_symbol_bcache_statistics): Update.
13584         (print_objfile_statistics): Update.
13585         * symfile.c (reread_symbols): Update.
13586         * psymtab.h (class psymtab_storage): New.
13587         * psymtab.c (psymtab_storage): New constructor.
13588         (~psymtab_storage): New destructor.
13589         (require_partial_symbols): Update.
13590         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13591         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13592         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13593         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13594         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13595         (start_psymtab_common, end_psymtab_common)
13596         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13597         (allocate_psymtab): Update.
13598         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13599         Update.
13600         (dump_psymtab_addrmap, maintenance_print_psymbols)
13601         (maintenance_check_psymtabs): Update.
13602         (class objfile_psymtabs): Move to objfiles.h.
13603         * psympriv.h (discard_psymtab): Now inline.
13604         (psymtab_discarder::psymtab_discarder): Update.
13605         (psymtab_discarder::~psymtab_discarder): Update.
13606         (ALL_OBJFILE_PSYMTABS): Rewrite.
13607         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13608         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13609         Remove fields.
13610         <partial_symtabs>: New field.
13611         (class objfile_psymtabs): Move from psymtab.h.  Update.
13612         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13613         psymbol_cache.
13614         (objfile::~objfile): Don't destroy psymbol_cache.
13615         * mdebugread.c (parse_partial_symbols): Update.
13616         * dwarf2read.c (create_addrmap_from_index)
13617         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13618         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13619         (add_partial_subprogram, dwarf2_ranges_read): Update.
13620         * dwarf-index-write.c (write_address_map)
13621         (write_one_signatured_type, recursively_write_psymbols)
13622         (class debug_names, class debug_names, write_psymtabs_to_index):
13623         Update.
13624
13625 2019-01-10  Tom Tromey  <tom@tromey.com>
13626
13627         * symtab.h (SYMBOL_SET_NAMES): Update.
13628         (symbol_set_names): Update.
13629         (MSYMBOL_SET_NAMES): Update.
13630         * symtab.c (symbol_set_names): Change argument to be an
13631         objfile_per_bfd_storage.
13632         * psymtab.c (add_psymbol_to_bcache): Update.
13633         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13634
13635 2019-01-10  Tom Tromey  <tom@tromey.com>
13636
13637         * symtab.c (create_demangled_names_hash): Change argument to be an
13638         objfile_per_bfd_storage.
13639         (symbol_set_names): Update.
13640
13641 2019-01-10  Tom Tromey  <tom@tromey.com>
13642
13643         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13644         init_psymbol_list.
13645         * psymtab.c (init_psymbol_list): Do nothing if already called.
13646         * psympriv.h (init_psymbol_list): Add comment.
13647         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13648         init_psymbol_list.
13649         * dbxread.c (dbx_symfile_read): Unconditionally call
13650         init_psymbol_list.
13651
13652 2019-01-10  Tom Tromey  <tom@tromey.com>
13653
13654         * xcoffread.c (scan_xcoff_symtab): Update.
13655         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13656         "where".
13657         * mdebugread.c (parse_partial_symbols)
13658         (handle_psymbol_enumerators): Update.
13659         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13660         * dbxread.c (read_dbx_symtab): Update.
13661         * psympriv.h (psymbol_placement): New enum.
13662         (add_psymbol_to_list): Update.
13663
13664 2019-01-10  Tom Tromey  <tom@tromey.com>
13665
13666         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13667         static_psymbols parameters.
13668         (scan_xcoff_symtab): Update.
13669         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13670         static_psymbols parameters.
13671         * psympriv.h (start_psymtab_common): Update.
13672         * mdebugread.c (parse_partial_symbols): Update.
13673         * dwarf2read.c (create_partial_symtab): Update.
13674         * dbxread.c (read_dbx_symtab): Update.
13675         (start_psymtab): Remove global_psymbols and static_psymbols
13676         parameters.
13677
13678 2019-01-10  Tom Tromey  <tom@tromey.com>
13679
13680         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13681         * psymtab.c (allocate_psymtab): Add comment.
13682         * psympriv.h (allocate_psymtab): Add comment.
13683         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13684         initializations.
13685         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13686
13687 2019-01-10  Tom Tromey  <tom@tromey.com>
13688
13689         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13690         Don't declare.
13691         * mipsread.c: Include mdebugread.h.
13692         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13693         Declare.
13694         * elfread.c: Include mdebugread.h.
13695
13696 2019-01-09  Tom Tromey  <tom@tromey.com>
13697
13698         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13699         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13700         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13701         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13702         (psym_lookup_symbol, psym_find_last_source_symtab)
13703         (psym_forget_cached_source_info, psym_print_stats)
13704         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13705         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13706         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13707         (psym_find_compunit_symtab_by_address)
13708         (maintenance_print_psymbols, maintenance_info_psymtabs)
13709         (maintenance_check_psymtabs): Use ranged for.
13710         * psymtab.h (class objfile_psymtabs): New.
13711         (require_partial_symbols): Return objfile_psymtabs.
13712         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13713
13714 2019-01-09  Tom Tromey  <tom@tromey.com>
13715
13716         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13717         (find_pc_mapped_section, list_overlays_command)
13718         (map_overlay_command, unmap_overlay_command)
13719         (simple_overlay_update): Use all_objfiles.
13720         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13721         * printcmd.c (info_symbol_command): Use all_objfiles.
13722         * objfiles.h (ALL_OBJSECTIONS): Remove.
13723         * maint.c (maintenance_translate_address): Use all_objfiles.
13724         * gcore.c (gcore_create_callback): Use all_objfiles.
13725         (objfile_find_memory_regions): Likewise.
13726
13727 2019-01-09  Tom Tromey  <tom@tromey.com>
13728
13729         * symtab.c (find_line_symtab, info_sources_command)
13730         (make_source_files_completion_list): Use objfile_compunits.
13731         * source.c (select_source_symtab): Use objfile_compunits.
13732         * objfiles.h (struct objfile): Update comment.
13733         (ALL_OBJFILES): Remove.
13734         (ALL_FILETABS): Remove.
13735         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13736         objfile_compunits.
13737
13738 2019-01-09  Tom Tromey  <tom@tromey.com>
13739
13740         * symmisc.c (print_objfile_statistics, dump_objfile)
13741         (maintenance_print_symbols): Use compunit_filetabs.
13742         * source.c (forget_cached_source_info_for_objfile): Use
13743         compunit_filetabs.
13744         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13745         (ALL_FILETABS): Use compunit_filetabs.
13746         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13747         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13748
13749 2019-01-09  Tom Tromey  <tom@tromey.com>
13750
13751         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13752         (compunit_filetabs): New.
13753         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13754         compunit_filetabs.
13755         (info_sources_command, make_source_files_completion_list): Remove
13756         declaration.
13757         * symmisc.c (print_objfile_statistics, dump_objfile)
13758         (maintenance_print_symbols): Remove declaration.
13759         (maintenance_info_symtabs): Use compunit_filetabs.
13760         (maintenance_info_line_tables): Likewise.
13761         * source.c (select_source_symtab): Change local variable name.
13762         (forget_cached_source_info_for_objfile): Remove declaration.
13763         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13764         * objfiles.c (objfile_relocate1): Remove declaration.
13765         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13766         declaration.
13767         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13768         * coffread.c (coff_symtab_read): Remove declaration.
13769         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13770         compunit_filetabs.
13771
13772 2019-01-09  Tom Tromey  <tom@tromey.com>
13773
13774         * symtab.c (lookup_objfile_from_block)
13775         (find_pc_sect_compunit_symtab, search_symbols)
13776         (default_collect_symbol_completion_matches_break_on): Use
13777         objfile_compunits.
13778         * objfiles.h (ALL_COMPUNITS): Remove.
13779         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13780         * cp-support.c (add_symbol_overload_list_qualified): Use
13781         objfile_compunits.
13782         * ada-lang.c (ada_collect_symbol_completion_matches)
13783         (ada_add_global_exceptions): Use objfile_compunits.
13784
13785 2019-01-09  Tom Tromey  <tom@tromey.com>
13786
13787         * source.c (select_source_symtab)
13788         (forget_cached_source_info_for_objfile): Remove declaration.
13789         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13790         declaration.
13791         * maint.c (count_symtabs_and_blocks): Remove declaration.
13792         * cp-support.c (add_symbol_overload_list_qualified): Remove
13793         declaration.
13794         * coffread.c (coff_symtab_read): Remove declaration.
13795         * symtab.c (lookup_symbol_in_objfile_symtabs)
13796         (basic_lookup_transparent_type_1): Use objfile_compunits.
13797         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13798         (info_sources_command, search_symbols)
13799         (default_collect_symbol_completion_matches_break_on)
13800         (make_source_files_completion_list): Remove declaration.
13801         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13802         (ada_collect_symbol_completion_matches)
13803         (ada_add_global_exceptions): Remove declaration.
13804         * linespec.c (iterate_over_all_matching_symtabs): Use
13805         objfile_compunits.
13806         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13807         (class objfile_compunits): New.
13808         (ALL_COMPUNITS): Use objfile_compunits.
13809         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13810         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13811         objfile_compunits.
13812         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13813
13814 2019-01-09  Tom Tromey  <tom@tromey.com>
13815
13816         * symtab.c (search_symbols)
13817         (default_collect_symbol_completion_matches_break_on): Use
13818         objfile_msymbols.
13819         * ada-lang.c (ada_lookup_simple_minsym)
13820         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13821         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13822         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13823         objfile_msymbols.
13824         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13825         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13826         * objc-lang.c (find_methods): Use objfile_msymbols.
13827         (info_selectors_command, info_classes_command): Likewise.
13828         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13829         * objfiles.h (class objfile_msymbols): New.
13830         (ALL_OBJFILE_MSYMBOLS): Remove.
13831         (ALL_MSYMBOLS): Remove.
13832
13833 2019-01-09  Tom Tromey  <tom@tromey.com>
13834
13835         * common/next-iterator.h (next_adapter): Add Iterator template
13836         parameter.
13837         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13838         (class all_objfiles_safe): New.
13839         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13840         * objfiles.c (put_objfile_before): Update comment.
13841         (add_separate_debug_objfile): Likewise.
13842         (free_all_objfiles): Use all_objfiles_safe.
13843         (objfile_purge_solibs): Likewise.
13844
13845 2019-01-09  Tom Tromey  <tom@tromey.com>
13846
13847         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13848         (expand_symtab_containing_pc, lookup_static_symbol)
13849         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13850         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13851         all_objfiles.
13852         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13853         * breakpoint.c (create_overlay_event_breakpoint)
13854         (create_longjmp_master_breakpoint)
13855         (create_std_terminate_master_breakpoint)
13856         (create_exception_master_breakpoint): Use all_objfiles.
13857         * linux-thread-db.c (try_thread_db_load_from_pdir)
13858         (has_libpthread): Use all_objfiles.
13859         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13860         * linespec.c (iterate_over_all_matching_symtabs)
13861         (search_minsyms_for_name): Use all_objfiles.
13862         * maint.c (maintenance_info_sections): Use all_objfiles.
13863         * main.c (captured_main_1): Use all_objfiles.
13864         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13865         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13866         * guile/scm-pretty-print.c
13867         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13868         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13869         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13870         (maintenance_print_msymbols): Use all_objfiles.
13871         * source.c (select_source_symtab): Use all_objfiles.
13872         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13873         * symfile.c (remove_symbol_file_command)
13874         (expand_symtabs_matching, map_symbol_filenames): Use
13875         all_objfiles.
13876         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13877         all_objfiles.
13878         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13879         * objc-lang.c (find_methods): Use all_objfiles.
13880         * objfiles.c (have_partial_symbols, have_full_symbols)
13881         (have_minimal_symbols, qsort_cmp)
13882         (default_iterate_over_objfiles_in_search_order): Use
13883         all_objfiles.
13884         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13885         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13886         (maintenance_check_psymtabs): Use all_objfiles.
13887         (ALL_PSYMTABS): Remove.
13888         * compile/compile-object-run.c (do_module_cleanup): Use
13889         all_objfiles.
13890         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13891         * cp-support.c (add_symbol_overload_list_qualified): Use
13892         all_objfiles.
13893         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13894         Use all_objfiles.
13895         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13896         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13897         all_objfiles.
13898         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13899         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13900         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13901         Uses all_objfiles.
13902         * solib.c (solib_read_symbols): Use all_objfiles
13903
13904 2019-01-09  Tom Tromey  <tom@tromey.com>
13905
13906         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13907         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13908         all_objfiles.
13909         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13910         * symmisc.c (print_symbol_bcache_statistics)
13911         (print_objfile_statistics, maintenance_print_objfiles)
13912         (maintenance_info_symtabs, maintenance_check_symtabs)
13913         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13914         all_objfiles.
13915         * source.c (forget_cached_source_info): Use all_objfiles.
13916         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13917         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13918         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13919         * objfiles.c (update_section_map): Use all_objfiles.
13920         (shared_objfile_contains_address_p): Likewise.
13921         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13922         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13923
13924 2019-01-09  Tom Tromey  <tom@tromey.com>
13925
13926         * common/next-iterator.h: New file.
13927         * objfiles.h (class all_objfiles): New.
13928         (struct objfile_iterator): New.
13929
13930 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13931
13932         * NEWS: Move the description of the changed "frame", "select-frame",
13933          and "info frame" commands to the Changed commands section.
13934
13935 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13936
13937         * gdbtypes.c (check_stub_method_group): Remove handling of old
13938         mangling schemes.
13939         * linespec.c (find_methods): Likewise.
13940         * stabsread.c (read_member_functions): Likewise.
13941         * valops.c (search_struct_method): Likewise.
13942         (value_struct_elt_for_reference): Likewise.
13943         * NEWS: Mention this change.
13944
13945 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13946
13947         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13948         print_source_lines.
13949         * source.c (print_source_lines_base): Update line number check.
13950         (print_source_lines): New function.
13951         (source_lines_range::source_lines_range): New function.
13952         * source.h (class source_lines_range): New class.
13953         (print_source_lines): New declaration.
13954
13955 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13956
13957         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13958
13959 2019-01-08  Tom Tromey  <tom@tromey.com>
13960             Simon Marchi  <simon.marchi@ericsson.com>
13961
13962         PR gdb/24060
13963         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13964         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13965         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13966         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13967         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13968         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13969
13970 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13971
13972         * source.c (select_source_symtab): Move header comment to
13973         declaration in source.h.
13974         (forget_cached_source_info_for_objfile): Likewise.
13975         (forget_cached_source_info): Likewise.
13976         (identify_source_line): Likewise.
13977         * source.h (identify_source_line): Move declaration from symtab.h
13978         and add comment from source.c
13979         (print_source_lines): Likewise.
13980         (forget_cached_source_info_for_objfile): Likewise.
13981         (forget_cached_source_info): Likewise.
13982         (select_source_symtab): Likewise.
13983         (enum print_source_lines_flag): Move definition from symtab.h.
13984         * symtab.h (identify_source_line): Move declaration to source.h.
13985         (print_source_lines): Likewise.
13986         (forget_cached_source_info_for_objfile): Likewise.
13987         (forget_cached_source_info): Likewise.
13988         (select_source_symtab): Likewise.
13989         (enum print_source_lines_flag): Move definition to source.h.
13990         * tui/tui-hooks.c: Add 'source.h' include.
13991
13992 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13993
13994         * source.c (print_source_lines_base): Handle requests to print
13995         reverse line number sequences, and guard against empty lines
13996         string.
13997
13998 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13999
14000         * source.c (print_source_lines_base): Fix skip of '\r' if next
14001         character is '\n'.
14002
14003 2019-01-06  Tom Tromey  <tom@tromey.com>
14004
14005         * c-exp.y (struct c_parse_state) <macro_original_text,
14006         expansion_obstack>: New member.
14007         (macro_original_text, expansion_obstack): Remove globals.
14008         (scan_macro_expansion, scanning_macro_expansion)
14009         (finished_macro_expansion): Update.
14010         (scan_macro_cleanup): Remove.
14011         (yylex, c_parse): Update.
14012
14013 2019-01-06  Tom Tromey  <tom@tromey.com>
14014
14015         * c-exp.y (struct c_parse_state) <strings>: New member.
14016         (operator_stoken): Update.
14017
14018 2019-01-06  Tom Tromey  <tom@tromey.com>
14019
14020         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14021         (union type_stack_elt) <typelist_val>: Now a pointer to
14022         std::vector.
14023         (type_stack_cleanup): Don't declare.
14024         (push_typelist): Update.
14025         * parse.c (pop_typelist): Return a std::vector.
14026         (push_typelist): Take a std::vector.
14027         (follow_types): Update.  Do not free args.
14028         (type_stack_cleanup): Remove.
14029         * c-exp.y (struct c_parse_state): New.
14030         (cpstate): New global.
14031         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14032         (nonempty_typelist): Update.
14033         (func_mod): Create a new vector.
14034         (c_parse): Create a c_parse_state.
14035         (check_parameter_typelist): Do not delete params.
14036         (function_method): Update.  Do not delete type_list.
14037
14038 2019-01-06  Tom Tromey  <tom@tromey.com>
14039
14040         PR gdb/28155:
14041         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14042         check_typedef.
14043         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14044         (print_return_value): Likewise.
14045
14046 2019-01-05  Tom Tromey  <tom@tromey.com>
14047
14048         * contrib/cleanup_check.py: Remove.
14049         * contrib/gcc-with-excheck: Remove.
14050         * contrib/exsummary.py: Remove.
14051         * contrib/excheck.py: Remove.
14052
14053 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14054
14055         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14056         NULL. Initialize tpprev to NULL instead of assigning it
14057         to NULL on the next statement.
14058         * windows-nat.c (windows_delete_thread): Remove check for
14059         main_thread_id before printing thread exit notifications.
14060         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14061         Remove thread ID check against main_thread_id.
14062         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14063         windows_delete_thread.
14064         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14065
14066 2019-01-04  Tom Tromey  <tom@tromey.com>
14067
14068         * compile/compile.c (_initialize_compile): Use upper case for
14069         metasyntactic variables.
14070         * symmisc.c (_initialize_symmisc): Use upper case for
14071         metasyntactic variables.
14072         * psymtab.c (_initialize_psymtab): Use upper case for
14073         metasyntactic variables.
14074         * demangle.c (demangle_command): Use upper case for metasyntactic
14075         variables.
14076         (_initialize_demangler): Likewise.
14077         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14078         variables.
14079
14080 2019-01-03  Tom Tromey  <tom@tromey.com>
14081
14082         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14083
14084 2019-01-03  Tom Tromey  <tom@tromey.com>
14085
14086         * python/py-symtab.c (salpy_str): Update.
14087         (struct salpy_sal_object) <symtab>: Now a PyObject.
14088         (salpy_dealloc): Update.
14089         (del_objfile_sal): Use gdbpy_ref.
14090
14091 2019-01-03  Tom Tromey  <tom@tromey.com>
14092
14093         * python/py-type.c (convert_field): Use new_reference.  Return
14094         gdbpy_ref.
14095         (make_fielditem): Return gdbpy_ref.
14096         (typy_fields): Update.
14097         (typy_getitem): Update.
14098         (field_name): Return gdbpy_ref.  Use new_reference.
14099         (typy_iterator_iternext): Update.
14100
14101 2019-01-03  Tom Tromey  <tom@tromey.com>
14102
14103         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14104
14105 2019-01-03  Tom Tromey  <tom@tromey.com>
14106
14107         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14108         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14109         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14110         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14111         (pspy_set_type_printers): Likewise.
14112         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14113         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14114         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14115         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14116         (objfpy_set_type_printers): Likewise.
14117
14118 2019-01-03  Tom Tromey  <tom@tromey.com>
14119
14120         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14121         (gdbpy_print_stack): Use gdbpy_err_fetch.
14122         * python/python-internal.h (class gdbpy_err_fetch): New class.
14123         (class gdbpy_enter) <m_error_type, m_error_value,
14124         m_error_traceback>: Remove.
14125         <m_error>: New member.
14126         (gdbpy_exception_to_string): Don't declare.
14127         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14128         * python/py-value.c (convert_value_from_python): Use
14129         gdbpy_err_fetch.
14130         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14131         gdbpy_exception_to_string.
14132         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14133         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14134         gdbpy_err_fetch.
14135
14136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14137
14138         * linux-nat.c (delete_lwp_cleanup): Delete.
14139         (struct lwp_deleter): New struct.
14140         (lwp_info_up): New typedef.
14141         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14142         lwp_info_up.
14143
14144 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14145
14146         * linux-fork.c (class scoped_switch_fork_info): New class.
14147         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14148
14149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14150
14151         * valops.c (find_overload_match): Remove use of null_cleanup, and
14152         calls to do_cleanups.
14153
14154 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14155
14156         * compile/compile-cplus-types.c
14157         (compile_cplus_instance::decl_name): Handle changes to
14158         cp_func_name.
14159         * cp-support.c (cp_func_name): Update header comment, update
14160         return type.
14161         * cp-support.h (cp_func_name): Update return type in declaration.
14162         * valops.c (find_overload_match): Move temp_func local to top
14163         level of function and change its type.  Use temp_func to hold and
14164         delete temporary string obtained from cp_func_name.
14165
14166 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14167
14168         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14169         gdb::char_vector, remove cleanup, and update uses of `msg`.
14170
14171 2019-01-03  Jim Wilson  <jimw@sifive.com>
14172
14173         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14174
14175 2019-01-02  Tom Tromey  <tom@tromey.com>
14176
14177         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14178         (tdesc_parse_xml): Remove cleanups.
14179         * target-descriptions.h (make_cleanup_free_target_description):
14180         Don't declare.
14181         (target_desc_deleter): New struct.
14182         (target_desc_up): New typedef.
14183         * target-descriptions.c (target_desc_deleter::operator()): Rename
14184         from free_target_description.
14185         (make_cleanup_free_target_description): Remove.
14186
14187 2019-01-02  Tom Tromey  <tom@tromey.com>
14188
14189         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14190         constructor, destructor.
14191         (linespec_parser): Remove typedef.
14192         (~linespec_parser): Rename from linespec_parser_delete.
14193         (linespec_lex_to_end, linespec_complete_label)
14194         (linespec_complete): Update.
14195         (decode_line_full): Remove cleanups.
14196         (decode_line_1): Update.
14197
14198 2019-01-02  Tom Tromey  <tom@tromey.com>
14199
14200         * python/python-internal.h (inferior_to_inferior_object): Change
14201         return type.
14202         * python/py-exitedevent.c (create_exited_event_object): Update.
14203         * python/py-inferior.c (inferior_to_inferior_object): Return
14204         gdbpy_ref.
14205         (python_new_inferior, python_inferior_deleted)
14206         (thread_to_thread_object, delete_thread_object)
14207         (build_inferior_list, gdbpy_selected_inferior): Update.
14208         * python/py-infthread.c (create_thread_object): Update.  Also fail
14209         if inferior_to_inferior_object fails.
14210
14211 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14212
14213         * inferior.h (class inferior) <displaced_step_state>: New field.
14214         * infrun.h (struct displaced_step_state): Move here from
14215         infrun.c.  Initialize fields, add constructor.
14216         <inf>: Remove field.
14217         <reset>: New method.
14218         * infrun.c (struct displaced_step_inferior_state): Move to
14219         infrun.h.
14220         (displaced_step_inferior_states): Remove.
14221         (get_displaced_stepping_state): Adust.
14222         (displaced_step_in_progress_any_inferior): Adjust.
14223         (displaced_step_in_progress_thread): Adjust.
14224         (displaced_step_in_progress): Adjust.
14225         (add_displaced_stepping_state): Remove.
14226         (get_displaced_step_closure_by_addr): Adjust.
14227         (remove_displaced_stepping_state): Remove.
14228         (infrun_inferior_exit): Call displaced_step_state.reset.
14229         (use_displaced_stepping): Don't check for NULL.
14230         (displaced_step_prepare_throw): Call
14231         get_displaced_stepping_state.
14232         (displaced_step_fixup): Don't check for NULL.
14233         (prepare_for_detach): Don't check for NULL.
14234
14235 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14236
14237         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14238          in case of call that did not complete.
14239
14240 2019-01-02  Andrey Utkin  <autkin@undo.io>
14241
14242         * symfile.c (find_separate_debug_file): Fix search of debug files for
14243         remote debuggee.
14244
14245 2019-01-02  Tom Tromey  <tom@tromey.com>
14246
14247         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14248         indentation.
14249         * python/py-frame.c (frapy_older): Remove cast.
14250         (frapy_newer): Likewise.
14251         * python/py-breakpoint.c (local_setattro): Remove cast.
14252         * python/py-arch.c (archpy_name): Remove local variable.
14253         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14254
14255 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14256
14257         * unittests/basic_string_view/element_access/char/empty.cc:
14258         Fix year range in copyright header.
14259
14260 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14261
14262         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14263         Delete.
14264         <operator==>: Update with for removed field.
14265         <hash>: Likewise.
14266         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14267         <isa_features>: ...this.
14268         <abi_features>: New field.
14269         (riscv_isa_flen): Update comment.
14270         (riscv_abi_xlen): New declaration.
14271         (riscv_abi_flen): New declaration.
14272         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14273         isa_features.
14274         (riscv_abi_xlen): New function.
14275         (riscv_isa_flen): Update to get answer from isa_features.
14276         (riscv_abi_flen): New function.
14277         (riscv_has_fp_abi): Update to get answer from abi_features.
14278         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14279         xlen and flen.
14280         (riscv_call_info) <xlen, flen>: Update comment.
14281         (riscv_call_arg_struct): Remove invalid assertions
14282         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14283         is removed.
14284         (riscv_gdbarch_init): Gather isa features and abi features
14285         separately, ensure both match on the gdbarch when reusing an old
14286         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14287         a target with 64-bit float hardware.
14288
14289 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14290
14291         * source.c (search_command_helper): Stop reverse search
14292         when line 1 has been searched.
14293
14294 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14295
14296         * record-full.c (record_full_base_target::close): Rewrite
14297         record_full_core_buf_list free logic.
14298
14299 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14300
14301         * break-catch-syscall.c (print_one_catch_syscall): xfree
14302         the last text.
14303
14304 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14305
14306         * top.c (print_gdb_version): Update Copyright year in version
14307         message.
14308
14309 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14310
14311         Update copyright year range in all GDB files.
14312
14313 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14314
14315         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14316
14317 For older changes see ChangeLog-2018.
14318 \f
14319 Local Variables:
14320 mode: change-log
14321 left-margin: 8
14322 fill-column: 74
14323 version-control: never
14324 coding: utf-8
14325 End:
14326