gdb/ChangeLog

   1 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
   4         access thistype->main_type->dyn_prop_list directly.
   5
   6 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
   9         (remove_dyn_prop): Remove.  Update all users to use
  10         type::remove_dyn_prop.
  11         * gdbtypes.c (remove_dyn_prop): Rename to...
  12         (type::remove_dyn_prop): ... this.
  13
  14 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
  15
  16         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
  17         (add_dyn_prop): Remove.  Update all users to use
  18         type::add_dyn_prop.
  19         * gdbtypes.c (add_dyn_prop): Rename to...
  20         (type::add_dyn_prop): ... this.
  21
  22 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
  23
  24         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
  25         (get_dyn_prop): Remove.  Update all users to use
  26         type::dyn_prop.
  27         * gdbtypes.c (get_dyn_prop): Rename to...
  28         (type::dyn_prop): ... this.
  29
  30 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  31
  32         * gdbtypes.h (struct main_type) <flag_static>: Remove.
  33
  34 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  35
  36         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
  37         instruction, skip it if it's there.
  38
  39 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
  40
  41         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
  42
  43 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
  44
  45         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
  46         * gdbtypes.c (recursive_dump_type): Remove use of
  47         TYPE_INCOMPLETE.
  48
  49 2020-05-03  Tom Tromey  <tom@tromey.com>
  50
  51         * breakpoint.c (catch_command, tcatch_command): Remove.
  52         (_initialize_breakpoint): Use add_basic_prefix_cmd,
  53         add_show_prefix_cmd.
  54         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
  55         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
  56         Remove.
  57         (add_internal_problem_command): Use add_basic_prefix_cmd,
  58         add_show_prefix_cmd.
  59         * mips-tdep.c (set_mipsfpu_command): Remove.
  60         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
  61         * dwarf2/index-cache.c (set_index_cache_command): Remove.
  62         (_initialize_index_cache): Use add_basic_prefix_cmd.
  63         * memattr.c (dummy_cmd): Remove.
  64         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
  65         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
  66         (_initialize_tui_win): Use add_basic_prefix_cmd,
  67         add_show_prefix_cmd.
  68         * cli/cli-logging.c (set_logging_command): Remove.
  69         (_initialize_cli_logging): Use add_basic_prefix_cmd,
  70         add_show_prefix_cmd.
  71         (show_logging_command): Remove.
  72         * target.c (target_command): Remove.
  73         (add_target): Use add_basic_prefix_cmd.
  74
  75 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
  76
  77         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
  78
  79 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  80
  81         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
  82         info_command.
  83
  84 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
  85
  86         * nbsd-nat.c (nbsd_enable_proc_events)
  87         (nbsd_nat_target::post_startup_inferior): Add.
  88         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
  89         (nbsd_nat_target::update_thread_list): Rewrite.
  90         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
  91         "PTRACE_LWP_CREATE".
  92         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
  93
  94 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  95
  96         * stack.c (_initialize_stack): Remove duplicated creation
  97         of "frame" command and "f" alias.
  98
  99 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 100
 101         PR gdb/18706
 102         * gdbtypes.c (check_typedef): Calculate size of array of
 103         stubbed type.
 104
 105 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 106
 107         PR gdb/15559
 108         * i386-tdep.c (i386_push_dummy_call): Call
 109         i386_thiscall_push_dummy_call.
 110         (i386_thiscall_push_dummy_call): New function.
 111         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 112         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 113         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 114
 115 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 116
 117         * gdbarch.sh (do_read): Add shellcheck disable directive for
 118         warning SC2162.
 119
 120 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 121
 122         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 123         "referenced but not assigned" warning.
 124
 125 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 126
 127         * gdbarch.sh: Remove code that sets fallbackdefault.
 128
 129 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 130
 131         * gdbarch.sh: Use shell operators && and || instead of
 132         -a and -o.
 133
 134 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 135
 136         * gdbarch.sh: Use $(...) instead of `...`.
 137
 138 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 139
 140         * gdbarch.sh: Use double quotes around variables.
 141
 142 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 143
 144         * gdbarch.sh: Use %s with printf, instead of variables in the
 145         format string.
 146
 147 2020-04-29  Tom Tromey  <tromey@adacore.com>
 148
 149         PR ada/25875:
 150         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 151         type fields here.
 152         (read_enumeration_type): Call
 153         update_enumeration_type_from_children later.  Update comments.
 154         (process_enumeration_scope): Don't create type fields.
 155
 156 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 157
 158         * nbsd-tdep.c: Include "xml-syscall.h".
 159         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 160
 161 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 162
 163         * nbsd-nat.c: Include "sys/wait.h".
 164         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 165         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 166         (nbsd_nat_target::remove_exec_catchpoint)
 167         (nbsd_nat_target::set_syscall_catchpoint): Add.
 168         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 169         (nbsd_nat_target::insert_exec_catchpoint)
 170         (nbsd_nat_target::remove_exec_catchpoint)
 171         (nbsd_nat_target::set_syscall_catchpoint): Add.
 172         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 173         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 174         `nbsd_get_syscall_number'.
 175
 176 2020-04-29  Tom Tromey  <tom@tromey.com>
 177
 178         * stack.c (print_block_frame_labels): Remove.
 179
 180 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 181
 182         PR gdb/17320
 183         * ada-valprint.c (val_print_packed_array_elements): Move array
 184         end bracket to new line.
 185         (ada_val_print_string): Remove extra spaces before first array
 186         element.
 187         * c-valprint.c (c_value_print_array): Likewise.
 188         * m2-valprint.c (m2_print_array_contents): Likewise.
 189         (m2_value_print_inner): Likewise.
 190         * p-valprint.c (pascal_value_print_inner): Likewise.
 191         * valprint.c (generic_val_print_array): Likewise.
 192         (value_print_array_elements): Move first array element and array
 193         end bracket to new line.
 194
 195 2020-04-29  Tom de Vries  <tdevries@suse.de>
 196
 197         PR symtab/25889
 198         * linespec.c (find_method): Fix ix calculation.
 199
 200 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 201
 202         * syscalls/update-netbsd.sh: New file.
 203         * syscalls/netbsd.xml: Regenerate.
 204         * data-directory/Makefile.in: Register `netbsd.xml' in
 205         `SYSCALLS_FILES'.
 206
 207 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 208
 209         * syscalls/update-freebsd.sh: Add double quotes.
 210
 211 2020-04-28  Tom Tromey  <tom@tromey.com>
 212
 213         * NEWS: Update.
 214         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 215         (cmdpy_init): Allow class_tui.
 216
 217 2020-04-28 Mark Williams <mark@myosotissp.com>
 218
 219         PR gdb/24480
 220         * dwarf2read.c: Add missing assingments to list_in_scope when
 221         start_symtab was already called.
 222
 223 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 224
 225         PR gdb/25881
 226         * dwarf2/read.c (offset_map_type): Use
 227         gdb:hash_enum<sect_offset> as hash function.
 228
 229 2020-04-28  Tom de Vries  <tdevries@suse.de>
 230
 231         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 232         with DW_AT_signature.
 233
 234 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 235
 236         * configure.ac: Remove check for fs_base/gs_base in
 237         user_regs_struct.
 238         * configure: Re-generate.
 239         * config.in: Re-generate.
 240         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 241         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 242         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 243
 244 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 245
 246         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 247         problematic inline frame unwinding situation.
 248         * frame.c (frame_id_computed_p): New function.
 249         * frame.h (frame_id_computed_p): New prototype.
 250
 251 2020-04-26  Tom Tromey  <tom@tromey.com>
 252
 253         * command.h (enum command_class) <class_pseudo>: Remove.
 254
 255 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 256
 257         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 258         and whitespace.
 259
 260 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 261
 262        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 263        `PT_GET_PROCESS_STATE' block.
 264
 265 2020-04-24  Tom Tromey  <tom@tromey.com>
 266
 267         * symtab.h (symbol_get_demangled_name): Don't declare.
 268         * symtab.c (symbol_get_demangled_name): Remove.
 269         (general_symbol_info::natural_name)
 270         (general_symbol_info::demangled_name): Update.
 271
 272 2020-04-24  Tom Tromey  <tom@tromey.com>
 273
 274         PR rust/25025:
 275         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 276
 277 2020-04-24  Tom Tromey  <tom@tromey.com>
 278
 279         PR symtab/12707:
 280         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 281         exists.
 282         (new_symbol): Likewise.
 283         * compile/compile-object-load.c (get_out_value_type): Use
 284         symbol_matches_search_name.
 285
 286 2020-04-24  Tom Tromey  <tom@tromey.com>
 287
 288         * dwarf2/read.c (add_partial_symbol): Do not call
 289         compute_and_set_names.
 290
 291 2020-04-24  Tom Tromey  <tom@tromey.com>
 292
 293         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 294         overload.
 295
 296 2020-04-24  Tom Tromey  <tom@tromey.com>
 297
 298         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 299         (add_psymbol_to_list): New overload.  Make old overload call new
 300         one.
 301         * psympriv.h (add_psymbol_to_list): New overload.
 302
 303 2020-04-24  Tom Tromey  <tom@tromey.com>
 304
 305         * dwarf2/read.c (partial_die_info::read) <case
 306         DW_AT_linkage_name>: Use value_as_string.
 307         (dwarf2_string_attr): Use value_as_string.
 308         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 309         method.
 310         * dwarf2/attribute.c (attribute::value_as_string): New method.
 311
 312 2020-04-24  Tom Tromey  <tom@tromey.com>
 313
 314         * symtab.c (general_symbol_info::natural_name)
 315         (general_symbol_info::demangled_name): Check for language_rust.
 316
 317 2020-04-24  Tom Tromey  <tom@tromey.com>
 318
 319         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 320         (dwarf2_physname): ... from here.
 321         (partial_die_info::read): Add Rust "{" hack.
 322
 323 2020-04-24  Tom Tromey  <tom@tromey.com>
 324
 325         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 326         method.
 327         (symbol_set_demangled_name): Don't declare.
 328         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 329         symbol_set_demangled_name.
 330         (general_symbol_info::set_language)
 331         (general_symbol_info::compute_and_set_names): Update.
 332         * minsyms.c (minimal_symbol_reader::install): Update.
 333         * dwarf2/read.c (new_symbol): Update.
 334
 335 2020-04-24  Tom Tromey  <tromey@adacore.com>
 336
 337         PR python/23662:
 338         * python/py-type.c (convert_field): Handle
 339         FIELD_LOC_KIND_DWARF_BLOCK.
 340         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 341         (typy_get_dynamic): Nw function.
 342         (type_object_getset): Add "dynamic".
 343         * NEWS: Add entry.
 344
 345 2020-04-24  Tom Tromey  <tromey@adacore.com>
 346
 347         * ada-typeprint.c (print_choices, print_variant_part)
 348         (print_record_field_types_dynamic): New functions.
 349         (print_record_field_types): Use print_record_field_types_dynamic.
 350
 351 2020-04-24  Tom Tromey  <tromey@adacore.com>
 352
 353         * dwarf2/read.c (handle_data_member_location): New overload.
 354         (dwarf2_add_field): Use it.
 355         (decode_locdesc): Add "computed" parameter.  Update comment.
 356         * gdbtypes.c (is_dynamic_type_internal): Also look for
 357         FIELD_LOC_KIND_DWARF_BLOCK.
 358         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 359         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 360         virtual base classes.
 361         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 362         FIELD_LOC_KIND_DWARF_BLOCK.
 363
 364 2020-04-24  Tom Tromey  <tromey@adacore.com>
 365
 366         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 367         * gdbtypes.c (is_dynamic_type_internal): Check
 368         TYPE_HAS_DYNAMIC_LENGTH.
 369         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 370         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 371         New macros.
 372         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 373         constant.
 374
 375 2020-04-24  Tom Tromey  <tromey@adacore.com>
 376
 377         * dwarf2/read.c (struct variant_field): Rewrite.
 378         (struct variant_part_builder): New.
 379         (struct nextfield): Remove "variant" field.  Add "offset".
 380         (struct field_info): Add "current_variant_part" and
 381         "variant_parts".
 382         (alloc_discriminant_info): Remove.
 383         (alloc_rust_variant): New function.
 384         (quirk_rust_enum): Update.
 385         (dwarf2_add_field): Set "offset" member.  Don't handle
 386         DW_TAG_variant_part.
 387         (offset_map_type): New typedef.
 388         (convert_variant_range, create_one_variant)
 389         (create_one_variant_part, create_variant_parts)
 390         (add_variant_property): New functions.
 391         (dwarf2_attach_fields_to_type): Call add_variant_property.
 392         (read_structure_type): Don't handle DW_TAG_variant_part.
 393         (handle_variant_part, handle_variant): New functions.
 394         (handle_struct_member_die): Use them.
 395         (process_structure_scope): Don't handle variant parts.
 396         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 397         (struct discriminant_info): Remove.
 398         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 399         (struct main_type) <flag_discriminated_union>: Remove.
 400         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 401         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 402         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 403         Update.
 404         * valops.c (value_union_variant): Remove.
 405         * value.h (value_union_variant): Don't declare.
 406
 407 2020-04-24  Tom Tromey  <tromey@adacore.com>
 408
 409         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 410         (ada_value_primitive_packed_val): Update.
 411         * ada-valprint.c (ada_value_print_1): Update.
 412         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 413         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 414         just an address.  Use evaluate_for_locexpr_baton.
 415         (dwarf2_evaluate_property): Update.
 416         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 417         array_view.
 418         * findvar.c (default_read_var_value): Update.
 419         * gdbtypes.c (compute_variant_fields_inner)
 420         (resolve_dynamic_type_internal): Update.
 421         (resolve_dynamic_type): Change type of valaddr parameter.
 422         * gdbtypes.h (resolve_dynamic_type): Update.
 423         * valarith.c (value_subscripted_rvalue): Update.
 424         * value.c (value_from_contents_and_address): Update.
 425
 426 2020-04-24  Tom Tromey  <tromey@adacore.com>
 427
 428         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 429         "push_initial_value" parameter.
 430         (dwarf2_evaluate_property): Likewise.
 431         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 432
 433 2020-04-24  Tom Tromey  <tromey@adacore.com>
 434
 435         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 436         (variant::matches, compute_variant_fields_recurse)
 437         (compute_variant_fields_inner, compute_variant_fields): New
 438         functions.
 439         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 440         Use resolved_type after type is made.
 441         (operator==): Add new cases.
 442         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 443         (struct discriminant_range, struct variant, struct variant_part):
 444         New.
 445         (union dynamic_prop_data) <variant_parts, original_type>: New
 446         members.
 447         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 448         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 449         constants.
 450         * value.c (unpack_bits_as_long): Now public.
 451         * value.h (unpack_bits_as_long): Declare.
 452
 453 2020-04-24  Tom Tromey  <tromey@adacore.com>
 454
 455         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 456         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 457
 458 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 459
 460         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 461
 462 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 463
 464         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 465         (remove_fork_catchpoint, post_startup_inferior)
 466         (post_attach): Move...
 467         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 468         (remove_fork_catchpoint, post_startup_inferior)
 469         (post_attach): ...here.
 470         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 471         (remove_fork_catchpoint, post_startup_inferior)
 472         (post_attach): Move...
 473         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 474         (remove_fork_catchpoint, post_startup_inferior)
 475         (post_attach): ...here.
 476
 477 2020-04-24  Tom Tromey  <tromey@adacore.com>
 478
 479         * nat/windows-nat.h (struct windows_thread_info)
 480         <pc_adjusted>: New member.
 481         * windows-nat.c (windows_fetch_one_register): Check
 482         pc_adjusted.
 483         (windows_nat_target::get_windows_debug_event)
 484         (windows_nat_target::wait): Set pc_adjusted.
 485
 486 2020-04-24  Tom de Vries  <tdevries@suse.de>
 487
 488         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 489         Run gdb-add-index inside temp dir.
 490
 491 2020-04-23  Tom Tromey  <tromey@adacore.com>
 492
 493         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 494         in loop.
 495
 496 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 497
 498         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 499         get_frame_register instead of gdbarch_unwind_pc.
 500
 501 2020-04-23  Tom de Vries  <tdevries@suse.de>
 502
 503         * symtab.c (lookup_global_symbol): Prefer def over decl.
 504
 505 2020-04-23  Tom de Vries  <tdevries@suse.de>
 506
 507         PR symtab/25807
 508         * block.c (best_symbol, better_symbol): Promote to external.
 509         * block.h (best_symbol, better_symbol): Declare.
 510         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 511         decl.
 512
 513 2020-04-23  Tom Tromey  <tromey@adacore.com>
 514
 515         PR ada/25837:
 516         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 517         "const char *", not a "const std::string &".
 518         <name_and_matcher::operator==>: Update.
 519         * unittests/lookup_name_info-selftests.c: Change type of
 520         "result".
 521
 522 2020-04-23  Tom Tromey  <tom@tromey.com>
 523
 524         * inferior.h (iterate_over_inferiors): Don't declare.
 525         * inferior.c (iterate_over_inferiors): Remove.
 526         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 527         Remove.
 528         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 529         use iterate_over_inferiors.
 530         (darwin_resume_inferior_it)
 531         (struct resume_inferior_threads_param)
 532         (darwin_resume_inferior_threads_it): Remove.
 533         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 534
 535 2020-04-23  Tom de Vries  <tdevries@suse.de>
 536
 537         * blockframe.c (find_pc_partial_function): Use
 538         find_pc_sect_compunit_symtab rather than
 539         objfile->sf->qf->find_pc_sect_compunit_symtab.
 540
 541 2020-04-22  Tom de Vries  <tdevries@suse.de>
 542
 543         PR symtab/25764
 544         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 545         in psymtabs.
 546
 547 2020-04-22  Tom de Vries  <tdevries@suse.de>
 548
 549         PR symtab/25801
 550         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 551         symtabs.
 552
 553 2020-04-22  Tom de Vries  <tdevries@suse.de>
 554
 555         PR symtab/25700
 556         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 557         CU if already created.
 558
 559 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 560
 561         * infrun.c (displaced_step_fixup): Switch to the event_thread
 562         before calling displaced_step_restore, not after.
 563
 564 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 565
 566         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 567         its inferior is not recorded by us.
 568         (record_btrace_target_open): Replace call to
 569         all_non_exited_threads () with call to current_inferior
 570         ()->non_exited_threads ().
 571         (record_btrace_target::stop_recording): Likewise.
 572         (record_btrace_target::close): Likewise.
 573         (record_btrace_target::wait): Likewise.
 574         (record_btrace_target::record_stop_replaying): Likewise.
 575
 576 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 577
 578         * btrace.c (btrace_enable): Throw an error on double enables and
 579         when enabling recording fails.
 580         (btrace_disable): Throw an error if the thread is not recorded.
 581
 582 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 583
 584         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 585         request if we do not have a thread_info.
 586
 587 2020-04-21  Tom de Vries  <tdevries@suse.de>
 588
 589         PR gdb/25471
 590         * thread.c
 591         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 592         exception in get_frame_id.
 593
 594 2020-04-20  Tom Tromey  <tromey@adacore.com>
 595
 596         * python/python.c (struct gdbpy_event): Mark move constructor as
 597         noexcept.
 598         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 599         constructor as noexcept.
 600         * completer.h (struct completion_result): Mark move constructor as
 601         noexcept.
 602         * completer.c (completion_result::completion_result): Use
 603         initialization style.  Don't call reset_match_list.
 604
 605 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 606
 607         * MAINTAINERS (Write After Approval): Add myself.
 608
 609 2020-04-18  Tom Tromey  <tom@tromey.com>
 610
 611         * windows-tdep.c (init_w32_command_list)
 612         (w32_prefix_command_valid): Restore.
 613         (_initialize_windows_tdep): Call init_w32_command_list.
 614
 615 2020-04-18  Tom Tromey  <tom@tromey.com>
 616
 617         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 618         * value.c (value_fn_field): Update.
 619         * valops.c (find_function_in_inferior)
 620         (value_allocate_space_in_inferior): Update.
 621         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 622         Update.
 623         * tui/tui-source.c (tui_source_window::set_contents): Update.
 624         * symtab.c (lookup_global_or_static_symbol)
 625         (find_function_start_sal_1, skip_prologue_sal)
 626         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 627         * symmisc.c (dump_msymbols, dump_symtab_1)
 628         (maintenance_print_one_line_table): Update.
 629         * symfile.c (init_entry_point_info, section_is_mapped)
 630         (list_overlays_command, simple_read_overlay_table)
 631         (simple_overlay_update_1): Update.
 632         * stap-probe.c (handle_stap_probe): Update.
 633         * stabsread.c (dbx_init_float_type, define_symbol)
 634         (read_one_struct_field, read_enum_type, read_range_type): Update.
 635         * source.c (info_line_command): Update.
 636         * python/python.c (gdbpy_source_objfile_script)
 637         (gdbpy_execute_objfile_script): Update.
 638         * python/py-type.c (save_objfile_types): Update.
 639         * python/py-objfile.c (py_free_objfile): Update.
 640         * python/py-inferior.c (python_new_objfile): Update.
 641         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 642         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 643         (maintenance_check_psymtabs): Update.
 644         * printcmd.c (info_address_command): Update.
 645         * objfiles.h (struct objfile) <arch>: New method, from
 646         get_objfile_arch.
 647         (get_objfile_arch): Don't declare.
 648         * objfiles.c (get_objfile_arch): Remove.
 649         (filter_overlapping_sections): Update.
 650         * minsyms.c (msymbol_is_function): Update.
 651         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 652         (output_nondebug_symbol): Update.
 653         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 654         (mdebug_expand_psymtab): Update.
 655         * machoread.c (macho_add_oso_symfile): Update.
 656         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 657         Update.
 658         * linux-fork.c (checkpoint_command): Update.
 659         * linespec.c (convert_linespec_to_sals): Update.
 660         * jit.c (finalize_symtab): Update.
 661         * infrun.c (insert_exception_resume_from_probe): Update.
 662         * ia64-tdep.c (ia64_find_unwind_table): Update.
 663         * hppa-tdep.c (internalize_unwinds): Update.
 664         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 665         Update.
 666         * gcore.c (call_target_sbrk): Update.
 667         * elfread.c (record_minimal_symbol, elf_symtab_read)
 668         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 669         (elf_gnu_ifunc_resolve_by_got): Update.
 670         * dwarf2/read.c (create_addrmap_from_index)
 671         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 672         (read_debug_names_from_section)
 673         (process_psymtab_comp_unit_reader, add_partial_symbol)
 674         (add_partial_subprogram, process_full_comp_unit)
 675         (read_file_scope, read_func_scope, read_lexical_block_scope)
 676         (read_call_site_scope, dwarf2_ranges_read)
 677         (dwarf2_record_block_ranges, dwarf2_add_field)
 678         (mark_common_block_symbol_computed, read_tag_pointer_type)
 679         (read_tag_string_type, dwarf2_init_float_type)
 680         (dwarf2_init_complex_target_type, read_base_type)
 681         (partial_die_info::read, partial_die_info::read)
 682         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 683         (dwarf2_fetch_die_loc_sect_off): Update.
 684         * dwarf2/loc.c (dwarf2_find_location_expression)
 685         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 686         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 687         (dwarf2_loc_desc_get_symbol_read_needs)
 688         (locexpr_describe_location_piece, locexpr_describe_location_1)
 689         (loclist_describe_location): Update.
 690         * dwarf2/index-write.c (write_debug_names): Update.
 691         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 692         * dtrace-probe.c (dtrace_process_dof): Update.
 693         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 694         (process_one_symbol): Update.
 695         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 696         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 697         (coff_read_enum_type): Update.
 698         * cli/cli-cmds.c (edit_command, list_command): Update.
 699         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 700         * breakpoint.c (create_overlay_event_breakpoint)
 701         (create_longjmp_master_breakpoint)
 702         (create_std_terminate_master_breakpoint)
 703         (create_exception_master_breakpoint, get_sal_arch): Update.
 704         * block.c (block_gdbarch): Update.
 705         * annotate.c (annotate_source_line): Update.
 706
 707 2020-04-17  Tom Tromey  <tromey@adacore.com>
 708
 709         * auto-load.c (show_auto_load_cmd): Remove.
 710         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 711         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 712         (maintenance_print_arc_command): Remove.
 713         * tui/tui-win.c (tui_command): Remove.
 714         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 715         * tui/tui-layout.c (tui_layout_command): Remove.
 716         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 717         * python/python.c (user_set_python, user_show_python): Remove.
 718         (_initialize_python): Use add_basic_prefix_cmd,
 719         add_show_prefix_cmd.
 720         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 721         (install_gdb_commands): Use add_basic_prefix_cmd,
 722         add_show_prefix_cmd.
 723         (info_guile_command): Remove.
 724         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 725         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 726         add_show_prefix_cmd.
 727         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 728         Remove do_set and do_show parameters.
 729         * cli/cli-style.c (set_style, show_style): Remove.
 730         (_initialize_cli_style): Use add_basic_prefix_cmd,
 731         add_show_prefix_cmd.
 732         (cli_style_option::add_setshow_commands): Remove do_set and
 733         do_show parameters.
 734         (cli_style_option::add_setshow_commands): Use
 735         add_basic_prefix_cmd, add_show_prefix_cmd.
 736         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 737         (set_style_name): Remove.
 738         * cli/cli-dump.c (dump_command, append_command): Remove.
 739         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 740         (tekhex_dump_command, binary_dump_command)
 741         (binary_append_command): Remove.
 742         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 743         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 744         (init_w32_command_list): Remove; move into ...
 745         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 746         * valprint.c (set_print, show_print, set_print_raw)
 747         (show_print_raw): Remove.
 748         (_initialize_valprint): Use add_basic_prefix_cmd,
 749         add_show_prefix_cmd.
 750         * typeprint.c (set_print_type, show_print_type): Remove.
 751         (_initialize_typeprint): Use add_basic_prefix_cmd,
 752         add_show_prefix_cmd.
 753         * record.c (set_record_command, show_record_command): Remove.
 754         (_initialize_record): Use add_basic_prefix_cmd,
 755         add_show_prefix_cmd.
 756         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 757         add_show_prefix_cmd.
 758         (info_command, show_command, set_debug, show_debug): Remove.
 759         * top.h (set_history, show_history): Don't declare.
 760         * top.c (set_history, show_history): Remove.
 761         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 762         (unset_tdesc_cmd): Remove.
 763         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 764         add_show_prefix_cmd.
 765         * symtab.c (info_module_command): Remove.
 766         (_initialize_symtab): Use add_basic_prefix_cmd.
 767         * symfile.c (overlay_command): Remove.
 768         (_initialize_symfile): Use add_basic_prefix_cmd.
 769         * sparc64-tdep.c (info_adi_command): Remove.
 770         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 771         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 772         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 773         add_show_prefix_cmd.
 774         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 775         (_initialize_serial): Use add_basic_prefix_cmd,
 776         add_show_prefix_cmd.
 777         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 778         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 779         add_show_prefix_cmd.
 780         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 781         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 782         add_show_prefix_cmd.
 783         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 784         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 785         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 786         add_show_prefix_cmd.
 787         * remote.c (remote_command, set_remote_cmd): Remove.
 788         (_initialize_remote): Use add_basic_prefix_cmd.
 789         * record-full.c (set_record_full_command)
 790         (show_record_full_command): Remove.
 791         (_initialize_record_full): Use add_basic_prefix_cmd,
 792         add_show_prefix_cmd.
 793         * record-btrace.c (cmd_set_record_btrace)
 794         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 795         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 796         (cmd_show_record_btrace_pt): Remove.
 797         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 798         add_show_prefix_cmd.
 799         * ravenscar-thread.c (set_ravenscar_command)
 800         (show_ravenscar_command): Remove.
 801         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 802         add_show_prefix_cmd.
 803         * mips-tdep.c (show_mips_command, set_mips_command)
 804         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 805         add_show_prefix_cmd.
 806         * maint.c (maintenance_command, maintenance_info_command)
 807         (maintenance_check_command, maintenance_print_command)
 808         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 809         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 810         add_show_prefix_cmd.
 811         (show_per_command_cmd): Remove.
 812         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 813         Remove.
 814         (maintenance_show_test_settings_cmd): Remove.
 815         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 816         add_show_prefix_cmd.
 817         * maint-test-options.c (maintenance_test_options_command):
 818         Remove.
 819         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 820         * macrocmd.c (macro_command): Remove
 821         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 822         * language.c (set_check, show_check): Remove.
 823         (_initialize_language): Use add_basic_prefix_cmd,
 824         add_show_prefix_cmd.
 825         * infcmd.c (unset_command): Remove.
 826         (_initialize_infcmd): Use add_basic_prefix_cmd.
 827         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 828         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 829         add_show_prefix_cmd.
 830         * go32-nat.c (go32_info_dos_command): Remove.
 831         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 832         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 833         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 834         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 835         (_initialize_frame): Use add_basic_prefix_cmd,
 836         add_show_prefix_cmd.
 837         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 838         (_initialize_dcache): Use add_basic_prefix_cmd,
 839         add_show_prefix_cmd.
 840         * cp-support.c (maint_cplus_command): Remove.
 841         (_initialize_cp_support): Use add_basic_prefix_cmd.
 842         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 843         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 844         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 845         add_basic_prefix_cmd, add_show_prefix_cmd.
 846         * breakpoint.c (save_command): Remove.
 847         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 848         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 849         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 850         add_show_prefix_cmd.
 851         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 852         (set_ada_command, show_ada_command): Remove.
 853         (_initialize_ada_language): Use add_basic_prefix_cmd,
 854         add_show_prefix_cmd.
 855         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 856
 857 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 858
 859         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 860         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 861
 862 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 863
 864         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 865         warning messages.
 866
 867 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 868
 869         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 870         import table is not at beginning of .idata section.
 871
 872 2020-04-16  Pedro Alves  <palves@redhat.com>
 873
 874         * inferior.c (delete_inferior): Use delete operator directly
 875         instead of delete_program_space.
 876         * progspace.c (add_program_space): New, factored out from
 877         program_space::program_space.
 878         (remove_program_space): New, factored out from
 879         delete_program_space.
 880         (program_space::program_space): Remove intro comment.  Rewrite.
 881         (program_space::~program_space): Remove intro comment.  Call
 882         remove_program_space.
 883         (delete_program_space): Delete.
 884         * progspace.h (program_space::program_space): Make explicit.  Move
 885         intro comment here, adjusted.
 886         (program_space::~program_space): Move intro comment here,
 887         adjusted.
 888         (delete_program_space): Remove.
 889
 890 2020-04-16  Tom Tromey  <tromey@adacore.com>
 891
 892         * windows-nat.c (windows_nat::handle_access_violation): New
 893         function.
 894         * nat/windows-nat.h (handle_access_violation): Declare.
 895         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 896         windows-nat.c.  Call handle_access_violation.
 897
 898 2020-04-16  Tom de Vries  <tdevries@suse.de>
 899
 900         PR symtab/25791
 901         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 902         CUs without psymtab.
 903
 904 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 905
 906         * python/python.c (do_start_initialization): Don't call
 907         PyEval_InitThreads for Python 3.9 and beyond.
 908
 909 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 910
 911         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 912         thread functions.
 913         (obsd_nat_target::wait): Likewise.
 914
 915 2020-04-15  Tom Tromey  <tromey@adacore.com>
 916
 917         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 918         (DEBUG_EXCEPT): Use debug_printf.
 919
 920 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * completer.c (class completion_tracker::completion_hash_entry)
 923         <hash_name>: New member function.
 924         (completion_tracker::discard_completions): New callback to hash a
 925         completion_hash_entry, pass this to htab_create_alloc.
 926
 927 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 928
 929         * windows-nat.c (windows_make_so): Warn rather than stopping with
 930         an error if realpath() fails.
 931
 932 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 933
 934         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 935         (nbsd_nat_target::info_proc): Add do_status.
 936
 937 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 938             Tom de Vries  <tdevries@suse.de>
 939
 940         PR symtab/25718
 941         * psympriv.h (struct partial_symtab::read_symtab)
 942         (struct partial_symtab::expand_psymtab)
 943         (struct partial_symtab::read_dependencies): Update comments.
 944         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 945         read_symtab for includer.
 946         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 947         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 948         (struct dwarf2_include_psymtab::m_readin): Remove.
 949         (struct dwarf2_include_psymtab::includer): New member function.
 950         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 951
 952 2020-04-14  Tom de Vries  <tdevries@suse.de>
 953
 954         PR symtab/25720
 955         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 956         with NULL symbol_matcher and lookup_name.
 957         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 958         and lookup_name.
 959         * dwarf2/read.c (dw2_expand_symtabs_matching)
 960         (dw2_debug_names_expand_symtabs_matching): Same.
 961         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 962         Make lookup_name a pointer.  Update comment.
 963         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 964         lookup_name being a pointer.
 965         * symfile.c (expand_symtabs_matching): Same.
 966         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 967         * linespec.c (iterate_over_all_matching_symtabs): Same.
 968
 969 2020-04-13  Tom Tromey  <tom@tromey.com>
 970
 971         * run-on-main-thread.c: Update include.
 972         * unittests/main-thread-selftests.c: Update include.
 973         * tui/tui-win.c: Update include.
 974         * tui/tui-io.c: Update include.
 975         * tui/tui-interp.c: Update include.
 976         * tui/tui-hooks.c: Update include.
 977         * top.h: Update include.
 978         * top.c: Update include.
 979         * ser-base.c: Update include.
 980         * remote.c: Update include.
 981         * remote-notif.c: Update include.
 982         * remote-fileio.c: Update include.
 983         * record-full.c: Update include.
 984         * record-btrace.c: Update include.
 985         * python/python.c: Update include.
 986         * posix-hdep.c: Update include.
 987         * mingw-hdep.c: Update include.
 988         * mi/mi-main.c: Update include.
 989         * mi/mi-interp.c: Update include.
 990         * main.c: Update include.
 991         * linux-nat.c: Update include.
 992         * interps.c: Update include.
 993         * infrun.c: Update include.
 994         * inf-loop.c: Update include.
 995         * event-top.c: Update include.
 996         * event-loop.c: Move to ../gdbsupport/.
 997         * event-loop.h: Move to ../gdbsupport/.
 998         * async-event.h: Update include.
 999         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1000
1001 2020-04-13  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-win.c: Include async-event.h.
1004         * remote.c: Include async-event.h.
1005         * remote-notif.c: Include async-event.h.
1006         * record-full.c: Include async-event.h.
1007         * record-btrace.c: Include async-event.h.
1008         * infrun.c: Include async-event.h.
1009         * event-top.c: Include async-event.h.
1010         * event-loop.h: Move some declarations to async-event.h.
1011         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1012         code to async-event.c.
1013         * async-event.h: New file.
1014         * async-event.c: New file.
1015         * Makefile.in (COMMON_SFILES): Add async-event.c.
1016         (HFILES_NO_SRCDIR): Add async-event.h.
1017
1018 2020-04-13  Tom Tromey  <tom@tromey.com>
1019
1020         * utils.c (flush_streams): New function.
1021         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1022
1023 2020-04-13  Tom Tromey  <tom@tromey.com>
1024
1025         * event-loop.c (handle_file_event): Use warning, not
1026         printf_unfiltered.
1027
1028 2020-04-13  Tom Tromey  <tom@tromey.com>
1029
1030         * event-loop.c: Include <chrono>.
1031
1032 2020-04-13  Tom Tromey  <tom@tromey.com>
1033
1034         * gdb_select.h: Move to ../gdbsupport/.
1035         * event-loop.c: Update include path.
1036         * top.c: Update include path.
1037         * ser-base.c: Update include path.
1038         * ui-file.c: Update include path.
1039         * ser-tcp.c: Update include path.
1040         * guile/scm-ports.c: Update include path.
1041         * posix-hdep.c: Update include path.
1042         * ser-unix.c: Update include path.
1043         * gdb_usleep.c: Update include path.
1044         * mingw-hdep.c: Update include path.
1045         * inflow.c: Update include path.
1046         * infrun.c: Update include path.
1047         * event-top.c: Update include path.
1048
1049 2020-04-13  Tom Tromey  <tom@tromey.com>
1050
1051         * configure: Rebuild.
1052         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1053
1054 2020-04-13  Tom Tromey  <tom@tromey.com>
1055
1056         * event-loop.h (start_event_loop): Don't declare.
1057         * event-loop.c (start_event_loop): Move...
1058         * main.c (start_event_loop): ...here.  Now static.
1059
1060 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1061
1062         * MAINTAINERS: Update my email address.
1063
1064 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1065
1066         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1067         IP_ALL.
1068
1069 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1070
1071         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1072         (nbsd_nat_target::info_proc): Add do_cmdline.
1073
1074 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1075
1076         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1077         (nbsd_nat_target::info_proc): Add do_cwd.
1078
1079 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1080
1081         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1082
1083 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1084
1085         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1086         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1087         (nbsd_nat_target::info_proc): New functions.
1088         * nbsd-nat.c (kinfo_get_vmmap): New function.
1089         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1090         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1091         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1092         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1093         functions.
1094         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1095         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1096         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1097         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1098         (KINFO_VME_FLAG_GROWS_DOWN): New.
1099
1100 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1101
1102         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1103         bit shift.
1104
1105 2020-04-10  Tom Tromey  <tromey@adacore.com>
1106
1107         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1108
1109 2020-04-10  Tom Tromey  <tromey@adacore.com>
1110
1111         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1112         separate debug files.
1113
1114 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1115
1116         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1117         Move to...
1118         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1119         ... here.
1120         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1121         Check for STATUS_WX86_BREAKPOINT.
1122         (windows_nat_target::wait): Same.
1123
1124 2020-04-10  Tom de Vries  <tdevries@suse.de>
1125
1126         PR cli/25808
1127         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1128
1129 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1130
1131         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1132         (Write After Approval): Remove Tom de Vries.
1133
1134 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1135
1136         revert partially:
1137         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1138
1139         * buildsym.c (record_line): Fix undefined behavior and preserve
1140         lines at eof.
1141
1142 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1143
1144         * auxv.h (svr4_auxv_parse): New.
1145         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1146         and generic_auxv_parse.
1147         (svr4_auxv_parse): Add.
1148         * obsd-tdep.c: Include "auxv.h".
1149         (obsd_auxv_parse): Remove.
1150         (obsd_init_abi): Remove comment.
1151         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1152         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1153         * nbsd-tdep.c: Include "auxv.h".
1154         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1155
1156 2020-04-08  Tom Tromey  <tromey@adacore.com>
1157
1158         * nat/windows-nat.h (last_wait_event): Don't declare.
1159         (wait_for_debug_event): Update comment.
1160         * nat/windows-nat.c (last_wait_event): Now static.
1161
1162 2020-04-08  Tom Tromey  <tromey@adacore.com>
1163
1164         * windows-nat.c (wait_for_debug_event): Move to
1165         nat/windows-nat.c.
1166         * nat/windows-nat.h (wait_for_debug_event): Declare.
1167         * nat/windows-nat.c (wait_for_debug_event): Move from
1168         windows-nat.c.  No longer static.
1169
1170 2020-04-08  Tom Tromey  <tromey@adacore.com>
1171
1172         * windows-nat.c (get_windows_debug_event): Use
1173         fetch_pending_stop.
1174         * nat/windows-nat.h (fetch_pending_stop): Declare.
1175         * nat/windows-nat.c (fetch_pending_stop): New function.
1176
1177 2020-04-08  Tom Tromey  <tromey@adacore.com>
1178
1179         * windows-nat.c (windows_continue): Use matching_pending_stop and
1180         continue_last_debug_event.
1181         * nat/windows-nat.h (matching_pending_stop)
1182         (continue_last_debug_event): Declare.
1183         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1184         (matching_pending_stop, continue_last_debug_event): New
1185         functions.
1186
1187 2020-04-08  Tom Tromey  <tromey@adacore.com>
1188
1189         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1190         (handle_exception_result): Move to nat/windows-nat.h.
1191         (DEBUG_EXCEPTION_SIMPLE): Remove.
1192         (windows_nat::handle_ms_vc_exception): New function.
1193         (handle_exception): Move to nat/windows-nat.c.
1194         (get_windows_debug_event): Update.
1195         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1196         nat/windows-nat.c.
1197         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1198         (handle_exception_result): Move from windows-nat.c.
1199         (handle_exception): Declare.
1200         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1201         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1202         windows-nat.c.
1203
1204 2020-04-08  Tom Tromey  <tromey@adacore.com>
1205
1206         * windows-nat.c (exception_count, event_count): Remove.
1207         (handle_exception, get_windows_debug_event)
1208         (do_initial_windows_stuff): Update.
1209
1210 2020-04-08  Tom Tromey  <tromey@adacore.com>
1211
1212         * windows-nat.c (windows_nat::handle_load_dll)
1213         (windows_nat::handle_unload_dll): Rename.  No longer static.
1214         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1215         Declare.
1216
1217 2020-04-08  Tom Tromey  <tromey@adacore.com>
1218
1219         * complaints.h (stop_whining): Declare at top-level.
1220         (complaint): Don't declare stop_whining.
1221
1222 2020-04-08  Tom Tromey  <tromey@adacore.com>
1223
1224         * windows-nat.c (windows_nat::handle_output_debug_string):
1225         Rename.  No longer static.
1226         * nat/windows-nat.h (handle_output_debug_string): Declare.
1227
1228 2020-04-08  Tom Tromey  <tromey@adacore.com>
1229
1230         * windows-nat.c (current_process_handle, current_process_id)
1231         (main_thread_id, last_sig, current_event, last_wait_event)
1232         (current_windows_thread, desired_stop_thread_id, pending_stops)
1233         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1234         (display_selectors, fake_create_process)
1235         (get_windows_debug_event): Update.
1236         * nat/windows-nat.h (current_process_handle, current_process_id)
1237         (main_thread_id, last_sig, current_event, last_wait_event)
1238         (current_windows_thread, desired_stop_thread_id, pending_stops)
1239         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1240         * nat/windows-nat.c (current_process_handle, current_process_id)
1241         (main_thread_id, last_sig, current_event, last_wait_event)
1242         (current_windows_thread, desired_stop_thread_id, pending_stops)
1243         (siginfo_er): New globals.  Move from windows-nat.c.
1244
1245 2020-04-08  Tom Tromey  <tromey@adacore.com>
1246
1247         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1248         (handle_load_dll): Update.
1249         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1250
1251 2020-04-08  Tom Tromey  <tromey@adacore.com>
1252
1253         * windows-nat.c (enum thread_disposition_type): Move to
1254         nat/windows-nat.h.
1255         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1256         static.
1257         (windows_add_thread, windows_nat_target::fetch_registers)
1258         (windows_nat_target::store_registers, handle_exception)
1259         (windows_nat_target::resume, get_windows_debug_event)
1260         (windows_nat_target::get_tib_address)
1261         (windows_nat_target::thread_name)
1262         (windows_nat_target::thread_alive): Update.
1263         * nat/windows-nat.h (enum thread_disposition_type): Move from
1264         windows-nat.c.
1265         (thread_rec): Declare.
1266
1267 2020-04-08  Tom Tromey  <tromey@adacore.com>
1268
1269         * windows-nat.c: Add "using namespace".
1270         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1271         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1272
1273 2020-04-08  Tom Tromey  <tromey@adacore.com>
1274
1275         * nat/windows-nat.h (struct windows_thread_info): Declare
1276         destructor.
1277         * nat/windows-nat.c (~windows_thread_info): New.
1278
1279 2020-04-08  Tom Tromey  <tromey@adacore.com>
1280
1281         PR gdb/22992
1282         * windows-nat.c (current_event): Update comment.
1283         (last_wait_event, desired_stop_thread_id): New globals.
1284         (struct pending_stop): New.
1285         (pending_stops): New global.
1286         (windows_nat_target) <stopped_by_sw_breakpoint>
1287         <supports_stopped_by_sw_breakpoint>: New methods.
1288         (windows_fetch_one_register): Add assertions.  Adjust PC.
1289         (windows_continue): Handle pending stops.  Suspend other threads
1290         when stepping.  Use last_wait_event
1291         (wait_for_debug_event): New function.
1292         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1293         pending stops.  Queue spurious stops.
1294         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1295         (windows_nat_target::kill): Use wait_for_debug_event.
1296         * nat/windows-nat.h (struct windows_thread_info)
1297         <stopped_at_software_breakpoint>: New field.
1298         * nat/windows-nat.c (windows_thread_info::resume): Clear
1299         stopped_at_software_breakpoint.
1300
1301 2020-04-08  Tom Tromey  <tromey@adacore.com>
1302
1303         * windows-nat.c (enum thread_disposition_type): New.
1304         (thread_rec): Replace "get_context" parameter with "disposition";
1305         change type.
1306         (windows_add_thread, windows_nat_target::fetch_registers)
1307         (windows_nat_target::store_registers, handle_exception)
1308         (windows_nat_target::resume, get_windows_debug_event)
1309         (windows_nat_target::get_tib_address)
1310         (windows_nat_target::thread_name)
1311         (windows_nat_target::thread_alive): Update.
1312
1313 2020-04-08  Tom Tromey  <tromey@adacore.com>
1314
1315         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1316         (windows_continue): Use windows_continue::resume.
1317         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1318         resume>: Declare new methods.
1319         * nat/windows-nat.c: New file.
1320         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1321
1322 2020-04-08  Tom Tromey  <tromey@adacore.com>
1323
1324         * windows-nat.c (windows_add_thread, windows_delete_thread)
1325         (windows_nat_target::fetch_registers)
1326         (windows_nat_target::store_registers, fake_create_process)
1327         (windows_nat_target::resume, windows_nat_target::resume)
1328         (get_windows_debug_event, windows_nat_target::wait)
1329         (windows_nat_target::pid_to_str)
1330         (windows_nat_target::get_tib_address)
1331         (windows_nat_target::get_ada_task_ptid)
1332         (windows_nat_target::thread_name)
1333         (windows_nat_target::thread_alive): Use lwp, not tid.
1334
1335 2020-04-08  Tom Tromey  <tromey@adacore.com>
1336
1337         * windows-nat.c (handle_exception)
1338         (windows_nat_target::thread_name): Update.
1339         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1340         <name>: Now unique_xmalloc_ptr.
1341
1342 2020-04-08  Tom Tromey  <tromey@adacore.com>
1343
1344         * windows-nat.c (thread_rec)
1345         (windows_nat_target::fetch_registers): Update.
1346         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1347         Update comment.
1348         <debug_registers_changed, reload_context>: Now bool.
1349
1350 2020-04-08  Tom Tromey  <tromey@adacore.com>
1351
1352         * windows-nat.c (windows_add_thread): Use new.
1353         (windows_init_thread_list, windows_delete_thread): Use delete.
1354         (get_windows_debug_event): Update.
1355         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1356         destructor, and initializers.
1357
1358 2020-04-08  Tom Tromey  <tromey@adacore.com>
1359
1360         * windows-nat.c (struct windows_thread_info): Remove.
1361         * nat/windows-nat.h: New file.
1362
1363 2020-04-08  Tom Tromey  <tromey@adacore.com>
1364
1365         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1366         (thread_rec, windows_add_thread, windows_delete_thread)
1367         (windows_continue): Update.
1368
1369 2020-04-08  Tom Tromey  <tromey@adacore.com>
1370
1371         * windows-nat.c (struct windows_thread_info): Remove typedef.
1372         (thread_head): Remove.
1373         (thread_list): New global.
1374         (thread_rec, windows_add_thread, windows_init_thread_list)
1375         (windows_delete_thread, windows_continue): Update.
1376
1377 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1378
1379         * windows-tdep.h (windows_init_abi): Add comment.
1380         (cygwin_init_abi): New declaration.
1381         * windows-tdep.c: Split signal enumeration in two, one for
1382         Windows and one for Cygwin.
1383         (windows_gdb_signal_to_target): Only deal with signal of the
1384         Windows OS ABI.
1385         (cygwin_gdb_signal_to_target): New function.
1386         (windows_init_abi): Rename to windows_init_abi_common, don't set
1387         gdb_signal_to_target gdbarch method.  Add new new function with
1388         this name.
1389         (cygwin_init_abi): New function.
1390         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1391         comment.  Don't call windows_init_abi.
1392         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1393         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1394         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1395         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1396         a new function of this name.
1397         (i386_cygwin_init_abi): New function.
1398         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1399         OS ABI Cygwin.
1400
1401 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1402
1403         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1404         parameter.c.
1405         (dwarf2_read_gdb_index): Update.
1406
1407 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1408
1409         * nbsd-tdep.c: Include "objfiles.h".
1410         (nbsd_skip_solib_resolver): New.
1411         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1412
1413 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1414
1415         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1416         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1417         with DW_LLE_base_addressx are being emitted in DWARFv5.
1418         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1419         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1420         unsigned integer.
1421
1422 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1423
1424         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1425         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1426         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1427         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1428         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1429         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1430         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1431
1432
1433 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1434
1435         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1436         (read_loclist_index): New function definition.
1437         (lookup_loclist_base): New function definition.
1438         (read_loclist_header): New function definition.
1439         (dwarf2_cu): Add loclist_base and loclist_header field.
1440         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1441         (read_full_die_1): Read the value of DW_AT_loclists_base.
1442         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1443         (read_attribute_value): Handle DW_FORM_loclistx.
1444         (skip_one_die): Handle DW_FORM_loclistx.
1445         (loclist_header): New structure declaration.
1446         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1447
1448 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1449
1450         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1451         constructor.  Remove `addr` parameter from other constructor and
1452         add `per_cu` parameter.
1453         * dwarf2/read.c (create_partial_symtab): Update.
1454
1455 2020-04-07  Tom de Vries  <tdevries@suse.de>
1456
1457         PR symtab/25796
1458         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1459         (partial_die_info::fixup): Inherit has_const_value.
1460
1461 2020-04-07  Tom de Vries  <tdevries@suse.de>
1462
1463         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1464         symbols without address.
1465
1466 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1467
1468         * nbsd-nat.h (struct thread_info): Add forward declaration.
1469         (nbsd_nat_target::thread_alive): Add.
1470         (nbsd_nat_target::thread_name): Likewise.
1471         (nbsd_nat_target::update_thread_list): Likewise.
1472         (update_thread_list::post_attach): Likewise.
1473         (post_attach::pid_to_str): Likewise.
1474         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1475         (nbsd_thread_lister): Add.
1476         (nbsd_nat_target::thread_alive): Likewise.
1477         (nbsd_nat_target::thread_name): Likewise.
1478         (nbsd_add_threads): Likewise.
1479         (update_thread_list::post_attach): Likewise.
1480         (nbsd_nat_target::update_thread_list): Likewise.
1481         (post_attach::pid_to_str): Likewise.
1482
1483 2020-04-06  Tom Tromey  <tromey@adacore.com>
1484
1485         * ada-valprint.c (print_variant_part): Extract the variant field.
1486         (print_field_values): Use the field as the outer value when
1487         recursing.
1488
1489 2020-04-06  Tom Tromey  <tromey@adacore.com>
1490
1491         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1492         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1493         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1494         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1495         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1496
1497 2020-04-06  Tom Tromey  <tromey@adacore.com>
1498
1499         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1500         TYPE_CODE_ERROR.
1501
1502 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1503
1504         * nbsd-tdep.c: Include "gdbarch.h".
1505         Define enum with NetBSD signal numbers.
1506         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1507         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1508         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1509         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1510         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1511         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1512         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1513         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1514         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1515         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1516         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1517         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1518
1519 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1520
1521         PR gdb/25325
1522         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1523
1524 2020-04-03  Tom Tromey  <tromey@adacore.com>
1525
1526         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1527         Read constant block.
1528
1529 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1530
1531         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1532         (gdb_bfd_get_full_section_contents): New declaration.
1533         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1534         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1535         gdb_bfd_get_full_section_contents.
1536
1537 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1538
1539         * exec.c (build_section_table): Replace internal_error with
1540         gdb_assert.
1541         (section_table_xfer_memory_partial): Likewise.
1542         * mdebugread.c (parse_partial_symbols): Likewise.
1543         * psymtab.c (lookup_partial_symbol): Likewise.
1544         * utils.c (wrap_here): Likewise.
1545
1546 2020-04-02  Tom Tromey  <tromey@adacore.com>
1547
1548         * f-lang.c (build_fortran_types): Use arch_type to initialize
1549         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1550
1551 2020-04-02  Tom Tromey  <tromey@adacore.com>
1552
1553         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1554         of attributes.
1555
1556 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1557             Bernd Edlinger <bernd.edlinger@hotmail.de>
1558             Tom Tromey  <tromey@adacore.com>
1559
1560         * buildsym.c (buildsym_compunit::record_line): Remove
1561         deduplication code.
1562
1563 2020-04-02  Tom de Vries  <tdevries@suse.de>
1564
1565         PR ada/24671
1566         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1567
1568 2020-04-02  Tom de Vries  <tdevries@suse.de>
1569
1570         * dwarf2/read.c (dwarf2_gdb_index_functions,
1571         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1572         NULL.
1573         * psymtab.c (psym_lookup_global_symbol_language): New function.
1574         (psym_functions): Init psym_lookup_global_symbol_language with
1575         psym_lookup_global_symbol_language.
1576         * symfile-debug.c (debug_sym_quick_functions): Init
1577         lookup_global_symbol_language with NULL.
1578         * symfile.c (set_initial_language): Remove fixme comment.
1579         * symfile.h (struct quick_symbol_functions): Add
1580         lookup_global_symbol_language.
1581         * symtab.c (find_quick_global_symbol_language): New function.
1582         (find_main_name): Use find_quick_global_symbol_language.
1583
1584 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1585
1586         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1587
1588 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1589
1590         * buildsym.c (record_line): Fix undefined behavior and preserve
1591         lines at eof.
1592
1593 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1594
1595         * buildsym.c (record_line): Fix the resizing condition.
1596
1597 2020-04-01  Tom Tromey  <tom@tromey.com>
1598
1599         * value.h (value_literal_complex): Add comment.
1600         * valops.c (value_literal_complex): Refer to value.h.
1601
1602 2020-04-01  Tom Tromey  <tom@tromey.com>
1603
1604         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1605         (scalar_type): New rule, from typebase.
1606         (typebase): Use scalar_type.  Recognize complex types.
1607         (field_name): Handle FLOAT_KEYWORD.
1608         (ident_tokens): Add _Complex and __complex__.
1609
1610 2020-04-01  Tom Tromey  <tom@tromey.com>
1611
1612         PR exp/25299:
1613         * valarith.c (promotion_type, complex_binop): New functions.
1614         (scalar_binop): Handle complex numbers.  Use promotion_type.
1615         (value_pos, value_neg, value_complement): Handle complex numbers.
1616
1617 2020-04-01  Tom Tromey  <tom@tromey.com>
1618
1619         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1620         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1621         (parse_number): Handle complex numbers.
1622
1623 2020-04-01  Tom Tromey  <tom@tromey.com>
1624
1625         * c-valprint.c (c_decorations): Change complex suffix to "i".
1626
1627 2020-04-01  Tom Tromey  <tom@tromey.com>
1628
1629         * valprint.c (generic_value_print_complex): Use accessors.
1630         * value.h (value_real_part, value_imaginary_part): Declare.
1631         * valops.c (value_real_part, value_imaginary_part): New
1632         functions.
1633         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1634
1635 2020-04-01  Tom Tromey  <tom@tromey.com>
1636
1637         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1638         (read_range_type): Update.
1639         * mdebugread.c (basic_type): Update.
1640         * go-lang.c (build_go_types): Use init_complex_type.
1641         * gdbtypes.h (struct main_type) <complex_type>: New member.
1642         (init_complex_type): Update.
1643         (arch_complex_type): Don't declare.
1644         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1645         Make name if none given.  Use alloc_type_copy.  Look for cached
1646         complex type.
1647         (arch_complex_type): Remove.
1648         (gdbtypes_post_init): Use init_complex_type.
1649         * f-lang.c (build_fortran_types): Use init_complex_type.
1650         * dwarf2/read.c (read_base_type): Update.
1651         * d-lang.c (build_d_types): Use init_complex_type.
1652         * ctfread.c (read_base_type): Update.
1653
1654 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1655
1656         * infrun.c (stop_all_threads): Update assertion, plus when
1657         stopping threads, take into account that we might be trying
1658         to stop an all-stop target.
1659         (stop_waiting): Call 'stop_all_threads' if there exists a
1660         non-stop target.
1661
1662 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1663
1664         * target.h (exists_non_stop_target): New function declaration.
1665         * target.c (exists_non_stop_target): New function.
1666
1667 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1668
1669         PR gdb/24789
1670         * eval.c (is_integral_or_integral_reference): New function.
1671         (evaluate_subexp_standard): Allow integer references in
1672         pointer arithmetic.
1673
1674 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1675
1676         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1677         check for no ptid in the stop reply when the target is non-stop.
1678
1679 2020-04-01  Tom Tromey  <tromey@adacore.com>
1680
1681         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1682         "name" parameter to rvalue reference.  Initialize m_name_holder.
1683         <lookup_name_info>: New overloads.
1684         <name>: Return gdb::string_view.
1685         <c_str>: New method.
1686         <make_ignore_params>: Update.
1687         <search_name_hash>: Update.
1688         <language_lookup_name>: Return const char *.
1689         <m_name>: Change type.
1690         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1691         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1692         (lookup_name_info::match_any): Update.
1693         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1694         Update.
1695         * minsyms.c (linkage_name_str): Update.
1696         * language.c (default_symbol_name_matcher): Update.
1697         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1698         Update.
1699         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1700         (ada_lookup_name_info::ada_lookup_name_info): Update.
1701         (literal_symbol_name_matcher): Update.
1702
1703 2020-04-01  Tom Tromey  <tromey@adacore.com>
1704
1705         * psymtab.c (psymtab_search_name): Remove function.
1706         (psym_lookup_symbol): Create search name and lookup name here.
1707         (lookup_partial_symbol): Remove "name" parameter; add
1708         lookup_name.
1709         (psym_expand_symtabs_for_function): Update.
1710
1711 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1712
1713         PR tui/25597:
1714         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1715
1716 2020-03-31  Tom Tromey  <tromey@adacore.com>
1717
1718         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1719         memcpy.
1720
1721 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1722
1723         * features/riscv/32bit-csr.xml: Regenerated.
1724         * features/riscv/64bit-csr.xml: Regenerated.
1725
1726 2020-03-30  Tom Tromey  <tromey@adacore.com>
1727
1728         * ada-valprint.c (print_variant_part): Update.
1729         * ada-lang.h (ada_which_variant_applies): Update.
1730         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1731         outer_valaddr parameters; replace with "outer" value parameter.
1732         (to_fixed_variant_branch_type): Update.
1733
1734 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1735
1736         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1737         <list>.  Remove inclusion of observable.h.
1738         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1739         (struct arch_lwp_info): New struct.
1740         (class ppc_linux_dreg_interface): New class.
1741         (struct ppc_linux_process_info): New struct.
1742         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1743         <low_new_clone, low_forget_process, low_prepare_to_resume>
1744         <copy_thread_dreg_state, mark_thread_stale>
1745         <mark_debug_registers_changed, register_hw_breakpoint>
1746         <clear_hw_breakpoint, register_wp, clear_wp>
1747         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1748         <num_memory_accesses, get_trigger_type>
1749         <create_watchpoint_request, hwdebug_point_cmp>
1750         <init_arch_lwp_info, get_arch_lwp_info>
1751         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1752         methods.
1753         <struct ptid_hash>: New inner struct.
1754         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1755         members.
1756         (saved_dabr_value, hwdebug_info, max_slots_number)
1757         (struct hw_break_tuple, struct thread_points, ppc_threads)
1758         (have_ptrace_hwdebug_interface)
1759         (hwdebug_find_thread_points_by_tid)
1760         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1761         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1762         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1763         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1764         use m_dreg_interface.
1765         (hwdebug_point_cmp): Change to...
1766         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1767         reference arguments instead of pointers.
1768         (ppc_linux_nat_target::ranged_break_num_registers): Use
1769         m_dreg_interface.
1770         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1771         m_dreg_interface.  Call register_hw_breakpoint.
1772         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1773         m_dreg_interface.  Call clear_hw_breakpoint.
1774         (get_trigger_type): Change to...
1775         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1776         comment.
1777         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1778         use m_dreg_interface.  Call register_hw_breakpoint.
1779         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1780         use m_dreg_interface.  Call clear_hw_breakpoint.
1781         (can_use_watchpoint_cond_accel): Change to...
1782         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1783         method.  Update comment, use m_dreg_interface and
1784         m_process_info.
1785         (calculate_dvc): Change to...
1786         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1787         m_dreg_interface.
1788         (num_memory_accesses): Change to...
1789         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1790         (check_condition): Change to...
1791         (ppc_linux_nat_target::check_condition): ...this method.
1792         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1793         comment, use m_dreg_interface.
1794         (create_watchpoint_request): Change to...
1795         (ppc_linux_nat_target::create_watchpoint_request): ...this
1796         method.  Use m_dreg_interface.
1797         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1798         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1799         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1800         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1801         (ppc_linux_nat_target::low_forget_process)
1802         (ppc_linux_nat_target::low_new_fork)
1803         (ppc_linux_nat_target::low_new_clone)
1804         (ppc_linux_nat_target::low_delete_thread)
1805         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1806         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1807         only call mark_thread_stale.
1808         (ppc_linux_thread_exit): Remove.
1809         (ppc_linux_nat_target::stopped_data_address): Change to...
1810         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1811         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1812         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1813         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1814         comment.  Call low_stopped_data_address.
1815         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1816         m_dreg_interface.
1817         (ppc_linux_nat_target::masked_watch_num_registers): Use
1818         m_dreg_interface.
1819         (ppc_linux_nat_target::copy_thread_dreg_state)
1820         (ppc_linux_nat_target::mark_thread_stale)
1821         (ppc_linux_nat_target::mark_debug_registers_changed)
1822         (ppc_linux_nat_target::register_hw_breakpoint)
1823         (ppc_linux_nat_target::clear_hw_breakpoint)
1824         (ppc_linux_nat_target::register_wp)
1825         (ppc_linux_nat_target::clear_wp)
1826         (ppc_linux_nat_target::init_arch_lwp_info)
1827         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1828         (_initialize_ppc_linux_nat): Remove observer callback.
1829
1830 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1831
1832         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1833         (ppc_linux_nat_target::auxv_parse)
1834         (ppc_linux_nat_target::read_description)
1835         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1836         Move up.
1837
1838 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1839
1840         * linux-nat.h (low_new_clone): New method.
1841         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1842
1843 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1844
1845         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1846         (dbx_expand_psymtab): ... this.
1847         (start_psymtab): Update.
1848         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1849         (mdebug_expand_psymtab): ... this.
1850         (parse_partial_symbols): Update.
1851         (new_psymtab): Update.
1852         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1853         (xcoff_expand_psymtab): ... this.
1854         (xcoff_start_psymtab): Update.
1855
1856 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1857
1858         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1859         <expand_dependencies>: ... this.
1860         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1861         (partial_symtab::expand_dependencies): ... this.
1862         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1863         Update.
1864         (dwarf2_psymtab::expand_psymtab): Update.
1865         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1866         * mdebugread.c (psymtab_to_symtab_1): Update.
1867         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1868
1869 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1870
1871         * psympriv.h (discard_psymtab): Remove.
1872         * dbxread.c (dbx_end_psymtab): Update.
1873         * xcoffread.c (xcoff_end_psymtab): Update.
1874
1875 2020-03-28  Tom Tromey  <tom@tromey.com>
1876
1877         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1878         comment.
1879
1880 2020-03-28  Tom Tromey  <tom@tromey.com>
1881
1882         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1883
1884 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1885
1886         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1887
1888 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1889
1890         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1891
1892 2020-03-26  Tom Tromey  <tom@tromey.com>
1893
1894         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1895         (mark_common_block_symbol_computed, read_tag_string_type)
1896         (attr_to_dynamic_prop, read_subrange_type): Update.
1897         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1898         to be methods on struct attribute.
1899         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1900         (read_call_site_scope, partial_die_info::read)
1901         (partial_die_info::read, lookup_die_type, follow_die_ref):
1902         Update.
1903         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1904         from dwarf2_get_ref_die_offset.
1905         (attribute::constant_value): New method, from
1906         dwarf2_get_attr_constant_value.
1907         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1908         Declare method.
1909         <constant_value>: New method.
1910
1911 2020-03-26  Tom Tromey  <tom@tromey.com>
1912
1913         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1914         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1915         (dwarf_type_encoding_name): Move to stringify.c.
1916         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1917         * dwarf2/stringify.c: New file.
1918         * dwarf2/stringify.h: New file.
1919
1920 2020-03-26  Tom Tromey  <tom@tromey.com>
1921
1922         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1923         Rewrite.
1924
1925 2020-03-26  Tom Tromey  <tom@tromey.com>
1926
1927         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1928         methods.
1929         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1930         (lookup_ranges_base): Likewise.
1931         (read_cutu_die_from_dwo, read_full_die_1): Update.
1932
1933 2020-03-26  Tom Tromey  <tom@tromey.com>
1934
1935         * dwarf2/read.c (read_import_statement, read_file_scope)
1936         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1937         (read_lexical_block_scope, read_call_site_scope)
1938         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1939         (handle_struct_member_die, process_structure_scope)
1940         (update_enumeration_type_from_children)
1941         (process_enumeration_scope, read_array_type, read_common_block)
1942         (read_namespace, read_module, read_subroutine_type): Update.
1943         (sibling_die): Remove.
1944
1945 2020-03-26  Tom Tromey  <tom@tromey.com>
1946
1947         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1948         (build_type_psymtabs_reader, read_structure_type)
1949         (read_enumeration_type, read_full_die_1): Update.
1950         (dwarf2_attr_no_follow): Move to die.h.
1951         * dwarf2/die.h (struct die_info) <attr>: New method.
1952
1953 2020-03-26  Tom Tromey  <tom@tromey.com>
1954
1955         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1956         <base_address>: Now an optional.
1957         (dwarf2_find_base_address, dwarf2_rnglists_process)
1958         (dwarf2_ranges_process, fill_in_loclist_baton)
1959         (dwarf2_symbol_mark_computed): Update.
1960
1961 2020-03-26  Tom Tromey  <tom@tromey.com>
1962
1963         * dwarf2/read.c (struct die_info): Move to die.h.
1964         * dwarf2/die.h: New file.
1965
1966 2020-03-26  Tom Tromey  <tom@tromey.com>
1967
1968         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1969         * dwarf2/read.c
1970         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1971         Move to line-header.c.
1972         (read_checked_initial_length_and_offset, read_formatted_entries):
1973         Likewise.
1974         (dwarf_decode_line_header): Split into two.
1975         * dwarf2/line-header.c
1976         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1977         Move from read.c.
1978         (read_checked_initial_length_and_offset, read_formatted_entries):
1979         Likewise.
1980         (dwarf_decode_line_header): New function, split from read.c.
1981
1982 2020-03-26  Tom Tromey  <tom@tromey.com>
1983
1984         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1985         Declare method.
1986         * dwarf2/read.c (read_attribute_value): Update.
1987         (dwarf2_per_objfile::read_line_string): Rename from
1988         read_indirect_line_string.
1989         (read_formatted_entries): Update.
1990
1991 2020-03-26  Tom Tromey  <tom@tromey.com>
1992
1993         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1994         variable.
1995
1996 2020-03-26  Tom Tromey  <tom@tromey.com>
1997
1998         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1999         const.
2000         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2001         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2002         parameter const.
2003
2004 2020-03-26  Tom Tromey  <tom@tromey.com>
2005
2006         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2007         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2008         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2009         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2010
2011 2020-03-26  Tom Tromey  <tom@tromey.com>
2012
2013         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2014         file_names_size, file_full_name, file_file_name>: Use const.
2015         <file_name_at, file_names>: Add const overload.
2016         * dwarf2/line-header.c (line_header::file_file_name)
2017         (line_header::file_full_name): Update.
2018
2019 2020-03-26  Tom Tromey  <tom@tromey.com>
2020
2021         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2022         (macro_start_file, consume_improper_spaces)
2023         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2024         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2025         (dwarf_decode_macros): Move to macro.c.
2026         * dwarf2/macro.c: New file.
2027         * dwarf2/macro.h: New file.
2028         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2029
2030 2020-03-26  Tom Tromey  <tom@tromey.com>
2031
2032         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2033         method.
2034         * dwarf2/section.c: New method.  From
2035         read_indirect_string_at_offset_from.
2036         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2037         (read_indirect_string_at_offset_from): Move to section.c.
2038         (read_indirect_string_at_offset): Rewrite.
2039         (read_indirect_line_string_at_offset): Remove.
2040         (read_indirect_string, read_indirect_line_string)
2041         (dwarf_decode_macro_bytes): Update.
2042
2043 2020-03-26  Tom Tromey  <tom@tromey.com>
2044
2045         * dwarf2/section.h (struct dwarf2_section_info)
2046         <overload_complaint>: Declare.
2047         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2048         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2049         Rename from dwarf2_section_buffer_overflow_complaint.
2050         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2051         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2052
2053 2020-03-26  Tom Tromey  <tom@tromey.com>
2054
2055         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2056         Declare.
2057         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2058         Move from read.c.
2059         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2060         to section.c.
2061
2062 2020-03-26  Tom Tromey  <tom@tromey.com>
2063
2064         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2065
2066 2020-03-26  Tom Tromey  <tom@tromey.com>
2067
2068         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2069         "builder".
2070         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2071         parameter.
2072         (dwarf_decode_macros): Update.
2073
2074 2020-03-26  Tom Tromey  <tom@tromey.com>
2075
2076         * dwarf2/read.c (read_attribute_value): Update.
2077         (read_indirect_string_from_dwz): Move to dwz.c; change into
2078         method.
2079         (dwarf_decode_macro_bytes): Update.
2080         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2081         * dwarf2/dwz.c: New file.
2082         * Makefile.in (COMMON_SFILES): Add dwz.c.
2083
2084 2020-03-26  Tom Tromey  <tom@tromey.com>
2085
2086         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2087         * dwarf2/read.c: Add include.
2088         * dwarf2/index-write.c: Add include.
2089         * dwarf2/index-cache.c: Add include.
2090         * dwarf2/dwz.h: New file.
2091
2092 2020-03-25  Tom Tromey  <tom@tromey.com>
2093
2094         * compile/compile-object-load.c (get_out_value_type): Mention
2095         correct symbol name in error message.
2096
2097 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2098
2099         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2100
2101 2020-03-25  Tom de Vries  <tdevries@suse.de>
2102
2103         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2104         * symmisc.c (dump_symtab_1): Print user and includes fields.
2105         (maintenance_info_symtabs): Same.
2106
2107 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         PR gdb/25534
2110         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2111         (riscv_regcache_cooked_write): New function.
2112         (riscv_push_dummy_call): Use new function.
2113         (riscv_return_value): Likewise.
2114
2115 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2116
2117         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2118         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2119         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2120         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2121         * infrun.c (follow_fork): Likewise.
2122         (follow_fork_inferior): Likewise.
2123         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2124         * linux-nat.h (class linux_nat_target): Likewise.
2125         * remote.c (class remote_target) <follow_fork>: Likewise.
2126         (remote_target::follow_fork): Likewise.
2127         * target-delegates.c: Re-generate.
2128         * target.c (default_follow_fork): Likewise.
2129         (target_follow_fork): Likewise.
2130         * target.h (struct target_ops) <follow_fork>: Likewise.
2131         (target_follow_fork): Likewise.
2132
2133 2020-03-24  Tom de Vries  <tdevries@suse.de>
2134
2135         * psymtab.c (maintenance_info_psymtabs): Print user field.
2136
2137 2020-03-20  Tom Tromey  <tromey@adacore.com>
2138
2139         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2140         const.
2141         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2142         const.
2143
2144 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2145
2146         * ptrace.m4: Don't check for ptrace declaration.
2147         * config.in: Re-generate.
2148         * configure: Re-generate.
2149         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2150         not defined.
2151
2152 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2153
2154         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2155         `PTRACE_TYPE_RET'.
2156         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2157         * sparc-nat.c (gdb_ptrace): Likewise.
2158         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2159
2160 2020-03-20  Tom Tromey  <tromey@adacore.com>
2161
2162         * c-exp.y (lex_one_token): Fix assert.
2163
2164 2020-03-20  Tom Tromey  <tromey@adacore.com>
2165
2166         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2167         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2168         strncpy call.
2169
2170 2020-03-20  Tom Tromey  <tromey@adacore.com>
2171
2172         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2173
2174 2020-03-20  Tom Tromey  <tromey@adacore.com>
2175
2176         * ada-valprint.c (print_variant_part): Remove parameters; switch
2177         to value-based API.
2178         (print_field_values): Likewise.
2179         (ada_val_print_struct_union): Likewise.
2180         (ada_value_print_1): Update.
2181
2182 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2183
2184         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2185         nbsd_nat_target instead of inf_ptrace_target.
2186         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2187         nbsd_nat_target.
2188
2189 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2190
2191         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2192         it to the ptrace call.
2193         * (store_registers): Likewise.
2194
2195 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2196
2197         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2198         it to the ptrace call.
2199         * (store_registers): Likewise.
2200
2201 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2202
2203         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2204         valid, fetch vg value from ptrace.
2205
2206 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2207         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2208         * inf-ptrace.c: Likewise.
2209         * (gdb_ptrace): Add.
2210         * (inf_ptrace_target::resume): Update.
2211         * (inf_ptrace_target::xfer_partial): Likewise.
2212         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2213         * (inf_ptrace_peek_poke): Update.
2214
2215 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2216
2217         * x86-bsd-nat.c (gdb_ptrace): New.
2218         * (x86bsd_dr_set): Add new argument `ptid'.
2219         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2220         x86bsd_dr_set_addr): Update.
2221
2222 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * remote.c (remote_target::process_stop_reply): Handle events for
2225         all threads differently.
2226
2227 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2228
2229         * completer.c (completion_tracker::remove_completion): Define new
2230         function.
2231         * completer.h (completion_tracker::remove_completion): Declare new
2232         function.
2233         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2234         when adding a C++ function symbol.
2235
2236 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * completer.c (completion_tracker::completion_hash_entry): Define
2239         new class.
2240         (advance_to_filename_complete_word_point): Call
2241         recompute_lowest_common_denominator.
2242         (completion_tracker::completion_tracker): Call discard_completions
2243         to setup the hash table.
2244         (completion_tracker::discard_completions): Allow for being called
2245         from the constructor, pass new equal function, and element deleter
2246         when constructing the hash table.  Initialise new class member
2247         variables.
2248         (completion_tracker::maybe_add_completion): Remove use of
2249         m_entries_vec, and store more information into m_entries_hash.
2250         (completion_tracker::recompute_lcd_visitor): New function, most
2251         content taken from...
2252         (completion_tracker::recompute_lowest_common_denominator):
2253         ...here, this now just visits each item in the hash calling the
2254         above visitor.
2255         (completion_tracker::build_completion_result): Remove use of
2256         m_entries_vec, call recompute_lowest_common_denominator.
2257         * completer.h (completion_tracker::have_completions): Remove use
2258         of m_entries_vec.
2259         (completion_tracker::completion_hash_entry): Declare new class.
2260         (completion_tracker::recompute_lowest_common_denominator): Change
2261         function signature.
2262         (completion_tracker::recompute_lcd_visitor): Declare new function.
2263         (completion_tracker::m_entries_vec): Delete.
2264         (completion_tracker::m_entries_hash): Initialize to NULL.
2265         (completion_tracker::m_lowest_common_denominator_valid): New
2266         member variable.
2267         (completion_tracker::m_lowest_common_denominator_max_length): New
2268         member variable.
2269
2270 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2271
2272         * regformats/regdef.h: Put reg in gdb namespace.
2273
2274 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2275
2276         * i386-bsd-nat.c (gdb_ptrace): New.
2277         * (i386bsd_fetch_inferior_registers,
2278         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2279         * (i386bsd_fetch_inferior_registers,
2280         i386bsd_store_inferior_registers) Use gdb_ptrace.
2281
2282 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2283
2284         * amd64-bsd-nat.c (gdb_ptrace): New.
2285         * (amd64bsd_fetch_inferior_registers,
2286         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2287         * (amd64bsd_fetch_inferior_registers,
2288         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2289
2290 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2291
2292         * user-regs.c (user_reg::read): Rename to...
2293         (user_reg::xread): ...this.
2294         * (append_user_reg): Rename argument `read' to `xread'.
2295         * (user_reg_add_builtin): Likewise.
2296         * (user_reg_add): Likewise.
2297         * (value_of_user_reg): Likewise.
2298
2299 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2300
2301         * sparc-nat.c (gdb_ptrace): New.
2302         * sparc-nat.c (sparc_fetch_inferior_registers)
2303         (sparc_store_inferior_registers) Remove obsolete comment.
2304         * sparc-nat.c (sparc_fetch_inferior_registers)
2305         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2306         * sparc-nat.c (sparc_fetch_inferior_registers)
2307         (sparc_store_inferior_registers) Use gdb_ptrace.
2308
2309 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2310
2311         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2312         it to the ptrace call.
2313         * sh-nbsd-nat.c (store_registers): Likewise.
2314
2315 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2316
2317         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2318         nbsd_nat_target instead of inf_ptrace_target.
2319         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2320         nbsd_nat_target.
2321
2322 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2323
2324         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2325
2326 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2327
2328         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2329         <sys/sysctl.h>.
2330         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2331
2332 2020-03-17  Tom de Vries  <tdevries@suse.de>
2333
2334         PR gdb/23710
2335         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2336         fields.
2337         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2338         fields.
2339         (process_imported_unit_die): Skip import of c++ CUs.
2340
2341 2020-03-16  Tom Tromey  <tom@tromey.com>
2342
2343         * p-valprint.c (pascal_object_print_value): Initialize
2344         base_value.
2345
2346 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2347             Shahab Vahedi  <shahab@synopsys.com>
2348
2349         * Makefile.in: Add arch/arc.o
2350         * configure.tgt: Likewise.
2351         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2352         (_initialize_arc_tdep): Don't initialize old target descriptions.
2353         (arc_read_description): New function to cache target descriptions.
2354         * arc-tdep.h (arc_read_description): Add proto type.
2355         * arch/arc.c: New file.
2356         * arch/arc.h: Likewise.
2357         * features/Makefile: Replace old target descriptions with new.
2358         * features/arc-arcompact.c: Remove.
2359         * features/arc-arcompact.xml: Likewise.
2360         * features/arc-v2.c: Likewise
2361         * features/arc-v2.xml: Likewise
2362         * features/arc/aux-arcompact.xml: New file.
2363         * features/arc/aux-v2.xml: Likewise.
2364         * features/arc/core-arcompact.xml: Likewise.
2365         * features/arc/core-v2.xml: Likewise.
2366         * features/arc/aux-arcompact.c: Generate.
2367         * features/arc/aux-v2.c: Likewise.
2368         * features/arc/core-arcompact.c: Likewise.
2369         * features/arc/core-v2.c: Likewise.
2370         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2371
2372 2020-03-16  Tom Tromey  <tromey@adacore.com>
2373
2374         PR gdb/25663:
2375         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2376         putting value into bcache.
2377
2378 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2379
2380         PR gdb/21500
2381         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2382         to...
2383         (amd64_windows_init_abi_common): ... this.  Don't set size of
2384         long type.
2385         (amd64_windows_init_abi): New function.
2386         (amd64_cygwin_init_abi): New function.
2387         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2388         the Cygwin OS ABI.
2389         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2390         comment.
2391
2392 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2393
2394         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2395         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2396         (pe_import_directory_entry): New struct type.
2397         (is_linked_with_cygwin_dll): New function.
2398         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2399         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2400         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2401
2402 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2403
2404         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2405         i386_cygwin_core_osabi_sniffer.
2406
2407 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2408
2409         * i386-cygwin-tdep.c: Rename to...
2410         * i386-windows-tdep.c: ... this.
2411         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2412         i386-windows-tdep.c.
2413         * configure.tgt: Likewise.
2414
2415 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2418         * osabi.c (gdb_osabi_names): Add "Windows".
2419         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2420         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2421         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2422         i386_cygwin_osabi_sniffer.
2423         (_initialize_i386_cygwin_tdep): Register OS ABI
2424         GDB_OSABI_WINDOWS for i386.
2425         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2426         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2427         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2428         for x86-64.
2429         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2430         when the target matches '*-*-mingw*'.
2431
2432 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2433
2434         * defs.h (enum gdb_osabi): Move to...
2435         * osabi.h (enum gdb_osabi): ... here.
2436         * gdbarch.sh: Include osabi.h in gdbarch.h.
2437         * gdbarch.h: Re-generate.
2438
2439 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2440
2441         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2442         function.
2443         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2444
2445 2020-03-14  Tom Tromey  <tom@tromey.com>
2446
2447         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2448         for C++.
2449         (c_type_print_modifier): Likewise.  Add "language" parameter.
2450         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2451         (c_type_print_base_1): Update.
2452         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2453         constants.
2454         * type-stack.c (type_stack::insert): Handle tp_atomic and
2455         tp_restrict.
2456         (type_stack::follow_type_instance_flags): Likewise.
2457         (type_stack::follow_types): Likewise.  Merge type-following code.
2458         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2459         (space_identifier, cv_with_space_id)
2460         (const_or_volatile_or_space_identifier_noopt)
2461         (const_or_volatile_or_space_identifier): Remove.
2462         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2463         rules.
2464         (ptr_operator, typebase): Update.
2465         (enum token_flag) <FLAG_C>: New constant.
2466         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2467         "_Atomic".
2468         (lex_one_token): Handle FLAG_C.
2469
2470 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2471
2472         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2473         it to the ptrace call.
2474         * m68k-bsd-nat.c (store_registers): Likewise.
2475
2476 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2477
2478         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2479         gdb_byte *.
2480         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2481         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2482         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2483
2484 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2485
2486         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2487         nbsd_nat_target instead of inf_ptrace_target.
2488         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2489         nbsd_nat_target.
2490
2491 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2492
2493         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2494         register_t.
2495
2496 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2497
2498         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2499         it to the ptrace call.
2500         * alpha-bsd-nat.c (store_registers): Likewise.
2501
2502 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2503
2504         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2505         includes.
2506         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2507         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2508         fill_fpregset): Likewise.
2509
2510 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2511
2512         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2513         nbsd_nat_target instead of inf_ptrace_target.
2514         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2515         nbsd_nat_target.
2516
2517 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2518
2519         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2520         register_t.
2521
2522 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2523
2524         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2525         it to the ptrace call.
2526         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2527         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2528         * arm-nbsd-nat.c (store_register): Likewise.
2529         * arm-nbsd-nat.c (store_regs): Likewise.
2530         * arm-nbsd-nat.c (store_fp_register): Likewise.
2531         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2532
2533 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2534
2535         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2536         nbsd_nat_target instead of inf_ptrace_target.
2537         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2538         nbsd_nat_target.
2539
2540 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2541
2542         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2543         it to the ptrace call.
2544         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2545
2546 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2547
2548         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2549         it to the ptrace call.
2550         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2551
2552 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2553
2554         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2555         gdb_byte *.
2556         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2557
2558 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2559
2560         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2561         instead of inf_ptrace_target.
2562         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2563         nbsd_nat_target.
2564
2565 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2566
2567         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2568         register_t.
2569
2570 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2571
2572         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2573         register_t.
2574
2575 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2576
2577         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2578         register_t.
2579
2580 2020-03-13  Tom Tromey  <tom@tromey.com>
2581
2582         * value.h (val_print): Don't declare.
2583         * valprint.h (val_print_array_elements)
2584         (val_print_scalar_formatted, generic_val_print): Don't declare.
2585         * valprint.c (generic_val_print_array): Take a struct value.
2586         (generic_val_print_ptr, generic_val_print_memberptr)
2587         (generic_val_print_bool, generic_val_print_int)
2588         (generic_val_print_char, generic_val_print_complex)
2589         (generic_val_print): Remove.
2590         (generic_value_print): Update.
2591         (do_val_print): Remove unused parameters.  Don't call
2592         la_val_print.
2593         (val_print): Remove.
2594         (common_val_print): Update.  Don't call value_check_printable.
2595         (val_print_scalar_formatted, val_print_array_elements): Remove.
2596         * rust-lang.c (rust_val_print): Remove.
2597         (rust_language_defn): Update.
2598         * p-valprint.c (pascal_val_print): Remove.
2599         (pascal_value_print_inner): Update.
2600         (pascal_object_print_val_fields, pascal_object_print_val):
2601         Remove.
2602         (pascal_object_print_static_field): Update.
2603         * p-lang.h (pascal_val_print): Don't declare.
2604         * p-lang.c (pascal_language_defn): Update.
2605         * opencl-lang.c (opencl_language_defn): Update.
2606         * objc-lang.c (objc_language_defn): Update.
2607         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2608         * m2-lang.h (m2_val_print): Don't declare.
2609         * m2-lang.c (m2_language_defn): Update.
2610         * language.h (struct language_defn) <la_val_print>: Remove.
2611         * language.c (unk_lang_value_print_inner): Rename.  Change
2612         argument types.
2613         (unknown_language_defn, auto_language_defn): Update.
2614         * go-valprint.c (go_val_print): Remove.
2615         * go-lang.h (go_val_print): Don't declare.
2616         * go-lang.c (go_language_defn): Update.
2617         * f-valprint.c (f_val_print): Remove.
2618         * f-lang.h (f_value_print): Don't declare.
2619         * f-lang.c (f_language_defn): Update.
2620         * d-valprint.c (d_val_print): Remove.
2621         * d-lang.h (d_value_print): Don't declare.
2622         * d-lang.c (d_language_defn): Update.
2623         * cp-valprint.c (cp_print_value_fields)
2624         (cp_print_value_fields_rtti, cp_print_value): Remove.
2625         (cp_print_static_field): Update.
2626         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2627         (c_val_print_struct, c_val_print_union, c_val_print_int)
2628         (c_val_print_memberptr, c_val_print): Remove.
2629         * c-lang.h (c_val_print_array, cp_print_value_fields)
2630         (cp_print_value_fields_rtti): Don't declare.
2631         * c-lang.c (c_language_defn, cplus_language_defn)
2632         (asm_language_defn, minimal_language_defn): Update.
2633         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2634         (ada_val_print_enum): Take a struct value.
2635         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2636         (ada_val_print): Remove.
2637         (ada_value_print_1): Update.
2638         (printable_val_type): Remove.
2639         * ada-lang.h (ada_val_print): Don't declare.
2640         * ada-lang.c (ada_language_defn): Update.
2641
2642 2020-03-13  Tom Tromey  <tom@tromey.com>
2643
2644         * valprint.c (do_val_print): Update.
2645         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2646         a struct value.
2647         (value_to_value_object_no_release): Declare.
2648         * python/py-value.c (value_to_value_object_no_release): New
2649         function.
2650         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2651         struct value.
2652         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2653         function.
2654         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2655         a struct value.
2656         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2657         Declare.
2658         (gdbscm_apply_val_pretty_printer): Take a struct value.
2659         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2660         value.
2661         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2662         value.
2663         * extension-priv.h (struct extension_language_ops)
2664         <apply_val_pretty_printer>: Take a struct value.
2665         * cp-valprint.c (cp_print_value): Create a struct value.
2666         (cp_print_value): Update.
2667
2668 2020-03-13  Tom Tromey  <tom@tromey.com>
2669
2670         * ada-valprint.c (print_field_values): Call common_val_print.
2671
2672 2020-03-13  Tom Tromey  <tom@tromey.com>
2673
2674         * ada-valprint.c (val_print_packed_array_elements): Remove
2675         bitoffset and val parameters.  Call common_val_print.
2676         (ada_val_print_string): Remove offset, address, and original_value
2677         parameters.
2678         (ada_val_print_array): Update.
2679         (ada_value_print_array): New function.
2680         (ada_value_print_1): Call it.
2681
2682 2020-03-13  Tom Tromey  <tom@tromey.com>
2683
2684         * ada-valprint.c (ada_value_print): Use common_val_print.
2685
2686 2020-03-13  Tom Tromey  <tom@tromey.com>
2687
2688         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2689
2690 2020-03-13  Tom Tromey  <tom@tromey.com>
2691
2692         * ada-valprint.c (ada_value_print_num): New function.
2693         (ada_value_print_1): Use it.
2694
2695 2020-03-13  Tom Tromey  <tom@tromey.com>
2696
2697         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2698
2699 2020-03-13  Tom Tromey  <tom@tromey.com>
2700
2701         * ada-valprint.c (ada_value_print_ptr): New function.
2702         (ada_value_print_1): Use it.
2703
2704 2020-03-13  Tom Tromey  <tom@tromey.com>
2705
2706         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2707         call common_val_print.
2708         (ada_val_print_1): Update.
2709         (ada_value_print_1): New function.
2710         (ada_value_print_inner): Rewrite.
2711
2712 2020-03-13  Tom Tromey  <tom@tromey.com>
2713
2714         * cp-valprint.c (cp_print_value_fields): Update.
2715         (cp_print_value): New function.
2716
2717 2020-03-13  Tom Tromey  <tom@tromey.com>
2718
2719         * m2-valprint.c (m2_value_print_inner): Use
2720         cp_print_value_fields.
2721         * cp-valprint.c (cp_print_value_fields): New function.
2722         * c-valprint.c (c_value_print_struct): New function.
2723         (c_value_print_inner): Use c_value_print_struct.
2724         * c-lang.h (cp_print_value_fields): Declare.
2725
2726 2020-03-13  Tom Tromey  <tom@tromey.com>
2727
2728         * c-valprint.c (c_value_print_array): New function.
2729         (c_value_print_inner): Use it.
2730
2731 2020-03-13  Tom Tromey  <tom@tromey.com>
2732
2733         * c-valprint.c (c_value_print_memberptr): New function.
2734         (c_value_print_inner): Use it.
2735
2736 2020-03-13  Tom Tromey  <tom@tromey.com>
2737
2738         * c-valprint.c (c_value_print_int): New function.
2739         (c_value_print_inner): Use it.
2740
2741 2020-03-13  Tom Tromey  <tom@tromey.com>
2742
2743         * c-valprint.c (c_value_print_ptr): New function.
2744         (c_value_print_inner): Use it.
2745
2746 2020-03-13  Tom Tromey  <tom@tromey.com>
2747
2748         * c-valprint.c (c_value_print_inner): Rewrite.
2749
2750 2020-03-13  Tom Tromey  <tom@tromey.com>
2751
2752         * valprint.c (generic_value_print_complex): New function.
2753         (generic_value_print): Use it.
2754
2755 2020-03-13  Tom Tromey  <tom@tromey.com>
2756
2757         * valprint.c (generic_val_print_float): Don't call
2758         val_print_scalar_formatted.
2759         (generic_val_print, generic_value_print): Update.
2760
2761 2020-03-13  Tom Tromey  <tom@tromey.com>
2762
2763         * valprint.c (generic_value_print_char): New function
2764         (generic_value_print): Use it.
2765
2766 2020-03-13  Tom Tromey  <tom@tromey.com>
2767
2768         * valprint.c (generic_value_print_int): New function.
2769         (generic_value_print): Use it.
2770
2771 2020-03-13  Tom Tromey  <tom@tromey.com>
2772
2773         * valprint.c (generic_value_print_bool): New function.
2774         (generic_value_print): Use it.
2775
2776 2020-03-13  Tom Tromey  <tom@tromey.com>
2777
2778         * valprint.c (generic_val_print_func): Simplify.
2779         (generic_val_print, generic_value_print): Update.
2780
2781 2020-03-13  Tom Tromey  <tom@tromey.com>
2782
2783         * valprint.c (generic_val_print_flags): Remove.
2784         (generic_val_print, generic_value_print): Update.
2785         (val_print_type_code_flags): Add original_value parameter.
2786
2787 2020-03-13  Tom Tromey  <tom@tromey.com>
2788
2789         * valprint.c (generic_val_print): Update.
2790         (generic_value_print): Update.
2791         * valprint.c (generic_val_print_enum): Don't call
2792         val_print_scalar_formatted.
2793
2794 2020-03-13  Tom Tromey  <tom@tromey.com>
2795
2796         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2797         * valprint.c (generic_value_print_ptr): New function.
2798
2799 2020-03-13  Tom Tromey  <tom@tromey.com>
2800
2801         * valprint.c (generic_value_print): Rewrite.
2802
2803 2020-03-13  Tom Tromey  <tom@tromey.com>
2804
2805         * p-valprint.c (pascal_object_print_value_fields)
2806         (pascal_object_print_value): New functions.
2807
2808 2020-03-13  Tom Tromey  <tom@tromey.com>
2809
2810         * p-valprint.c (pascal_value_print_inner): Rewrite.
2811
2812 2020-03-13  Tom Tromey  <tom@tromey.com>
2813
2814         * f-valprint.c (f_value_print_innner): Rewrite.
2815
2816 2020-03-13  Tom Tromey  <tom@tromey.com>
2817
2818         * m2-valprint.c (m2_print_unbounded_array): New overload.
2819         (m2_print_unbounded_array): Update.
2820         (m2_print_array_contents): Take a struct value.
2821         (m2_value_print_inner): Rewrite.
2822
2823 2020-03-13  Tom Tromey  <tom@tromey.com>
2824
2825         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2826         (d_value_print_inner): New function.
2827         * d-lang.h (d_value_print_inner): Declare.
2828         * d-lang.c (d_language_defn): Use d_value_print_inner.
2829
2830 2020-03-13  Tom Tromey  <tom@tromey.com>
2831
2832         * go-valprint.c (go_value_print_inner): New function.
2833         * go-lang.h (go_value_print_inner): Declare.
2834         * go-lang.c (go_language_defn): Use go_value_print_inner.
2835
2836 2020-03-13  Tom Tromey  <tom@tromey.com>
2837
2838         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2839         API.
2840         (rust_val_print): Rewrite.
2841         (rust_value_print_inner): New function, from rust_val_print.
2842         (rust_language_defn): Use rust_value_print_inner.
2843
2844 2020-03-13  Tom Tromey  <tom@tromey.com>
2845
2846         * ada-valprint.c (ada_value_print_inner): New function.
2847         * ada-lang.h (ada_value_print_inner): Declare.
2848         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2849
2850 2020-03-13  Tom Tromey  <tom@tromey.com>
2851
2852         * f-valprint.c (f_value_print_innner): New function.
2853         * f-lang.h (f_value_print_innner): Declare.
2854         * f-lang.c (f_language_defn): Use f_value_print_innner.
2855
2856 2020-03-13  Tom Tromey  <tom@tromey.com>
2857
2858         * p-valprint.c (pascal_value_print_inner): New function.
2859         * p-lang.h (pascal_value_print_inner): Declare.
2860         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2861
2862 2020-03-13  Tom Tromey  <tom@tromey.com>
2863
2864         * m2-valprint.c (m2_value_print_inner): New function.
2865         * m2-lang.h (m2_value_print_inner): Declare.
2866         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2867
2868 2020-03-13  Tom Tromey  <tom@tromey.com>
2869
2870         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2871         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2872         * c-valprint.c (c_value_print_inner): New function.
2873         * c-lang.h (c_value_print_inner): Declare.
2874         * c-lang.c (c_language_defn, cplus_language_defn)
2875         (asm_language_defn, minimal_language_defn): Use
2876         c_value_print_inner.
2877
2878 2020-03-13  Tom Tromey  <tom@tromey.com>
2879
2880         * p-valprint.c (pascal_object_print_value_fields): Now static.
2881         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2882
2883 2020-03-13  Tom Tromey  <tom@tromey.com>
2884
2885         * c-valprint.c (c_val_print_array): Simplify.
2886
2887 2020-03-13  Tom Tromey  <tom@tromey.com>
2888
2889         * valprint.c (value_print_array_elements): New function.
2890         * valprint.h (value_print_array_elements): Declare.
2891
2892 2020-03-13  Tom Tromey  <tom@tromey.com>
2893
2894         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2895         * mips-tdep.c (mips_print_register): Use
2896         value_print_scalar_formatted.
2897
2898 2020-03-13  Tom Tromey  <tom@tromey.com>
2899
2900         * valprint.h (value_print_scalar_formatted): Declare.
2901         * valprint.c (value_print_scalar_formatted): New function.
2902
2903 2020-03-13  Tom Tromey  <tom@tromey.com>
2904
2905         * valprint.h (generic_value_print): Declare.
2906         * valprint.c (generic_value_print): New function.
2907
2908 2020-03-13  Tom Tromey  <tom@tromey.com>
2909
2910         * valprint.c (do_val_print): Call la_value_print_inner, if
2911         available.
2912         * rust-lang.c (rust_language_defn): Update.
2913         * p-lang.c (pascal_language_defn): Update.
2914         * opencl-lang.c (opencl_language_defn): Update.
2915         * objc-lang.c (objc_language_defn): Update.
2916         * m2-lang.c (m2_language_defn): Update.
2917         * language.h (struct language_defn) <la_value_print_inner>: New
2918         member.
2919         * language.c (unknown_language_defn, auto_language_defn): Update.
2920         * go-lang.c (go_language_defn): Update.
2921         * f-lang.c (f_language_defn): Update.
2922         * d-lang.c (d_language_defn): Update.
2923         * c-lang.c (c_language_defn, cplus_language_defn)
2924         (asm_language_defn, minimal_language_defn): Update.
2925         * ada-lang.c (ada_language_defn): Update.
2926
2927 2020-03-13  Tom Tromey  <tom@tromey.com>
2928
2929         * c-valprint.c (c_value_print): Use common_val_print.
2930
2931 2020-03-13  Tom Tromey  <tom@tromey.com>
2932
2933         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2934
2935 2020-03-13  Tom Tromey  <tom@tromey.com>
2936
2937         * f-valprint.c (f77_print_array_1, f_val_print): Use
2938         common_val_print.
2939
2940 2020-03-13  Tom Tromey  <tom@tromey.com>
2941
2942         * riscv-tdep.c (riscv_print_one_register_info): Use
2943         common_val_print.
2944
2945 2020-03-13  Tom Tromey  <tom@tromey.com>
2946
2947         * mi/mi-main.c (output_register): Use common_val_print.
2948
2949 2020-03-13  Tom Tromey  <tom@tromey.com>
2950
2951         * infcmd.c (default_print_one_register_info): Use
2952         common_val_print.
2953
2954 2020-03-13  Tom Tromey  <tom@tromey.com>
2955
2956         * valprint.h (common_val_print_checked): Declare.
2957         * valprint.c (common_val_print_checked): New function.
2958         * stack.c (print_frame_arg): Use common_val_print_checked.
2959
2960 2020-03-13  Tom Tromey  <tom@tromey.com>
2961
2962         * valprint.c (do_val_print): New function, from val_print.
2963         (val_print): Use do_val_print.
2964         (common_val_print): Use do_val_print.
2965
2966 2020-03-13  Tom Tromey  <tom@tromey.com>
2967
2968         * valprint.c (value_print): Use scoped_value_mark.
2969
2970 2020-03-13  Tom de Vries  <tdevries@suse.de>
2971
2972         PR symtab/25646
2973         * psymtab.c (partial_symtab::partial_symtab): Don't set
2974         globals_offset and statics_offset.  Push element onto
2975         current_global_psymbols and current_static_psymbols stacks.
2976         (concat): New function.
2977         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2978         element from current_global_psymbols and current_static_psymbols
2979         stacks.  Concat popped elements to global_psymbols and
2980         static_symbols.
2981         (add_psymbol_to_list): Use current_global_psymbols and
2982         current_static_psymbols stacks.
2983         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2984         current_static_psymbols fields.
2985
2986 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2987
2988         * corelow.c (sniff_core_bfd): Remove.
2989         (class core_target) <m_core_vec>: Remove.
2990         (core_target::core_target): Update.
2991         (core_file_fns): Remove.
2992         (deprecated_add_core_fns): Remove.
2993         (default_core_sniffer): Remove.
2994         (sniff_core_bfd): Remove.
2995         (default_check_format): Remove.
2996         (gdb_check_format): Remove.
2997         (core_target_open): Update.
2998         (core_target::get_core_register_section): Update.
2999         (get_core_registers_cb): Update.
3000         (core_target::fetch_registers): Update.
3001         * gdbcore.h (struct core_fns): Remove.
3002         (deprecated_add_core_fns): Remove.
3003         (default_core_sniffer): Remove.
3004         (default_check_format): Remove.
3005
3006 2020-03-12  Tom Tromey  <tom@tromey.com>
3007
3008         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3009         CORE_ADDR.
3010         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3011
3012 2020-03-12  Tom Tromey  <tom@tromey.com>
3013
3014         * remote.c (remote_target::download_tracepoint)
3015         (remote_target::enable_tracepoint)
3016         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3017         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3018         sprintf_vma.
3019
3020 2020-03-12  Tom Tromey  <tom@tromey.com>
3021
3022         * symfile-mem.c: Update CORE_ADDR size assert.
3023
3024 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3025
3026         * selftest.m4: Move to gdbsupport/.
3027         * acinclude.m4: Update path to selftest.m4.
3028
3029 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3030
3031         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3032         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3033         gdbarch-selfselftests.c and selftest-arch.c.
3034         (SUBDIR_UNITTESTS_OBS): Rename to...
3035         (SELFTESTS_OBS): ... this.
3036         (COMMON_SFILES): Remove disasm-selftests.c and
3037         gdbarch-selftests.c.
3038         * configure.ac: Don't add selftest-arch.{c,o} to
3039         CONFIG_{SRCS,OBS}.
3040         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3041         preprocessor conditions.
3042
3043 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3044
3045         * configure.ac: Don't source bfd/development.sh.
3046         * selftest.m4: Modify comment.
3047         * configure: Re-generate.
3048
3049 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3050
3051         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3052         not "true" or "false".
3053         * configure: Re-generate.
3054
3055 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3056
3057         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3058         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3059         renamed to arm_nbsd_supply_gregset.
3060         (fetch_register): Update to call arm_nbsd_supply_gregset.
3061         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3062         (arm_netbsd_nat_target::fetch_registers): Update.
3063         (fetch_elfcore_registers): Removed.
3064         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3065         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3066         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3067         not require NetBSD system headers.
3068         (arm_nbsd_regset): New struct.
3069         (arm_nbsd_iterate_over_regset_sections): New function.
3070         (arm_netbsd_init_abi_common): Updated to call
3071         set_gdbarch_iterate_over_regset_sections.
3072         * arm-nbsd-tdep.h: New file.
3073
3074 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3075
3076         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3077         recursion.
3078
3079 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3080
3081         * configure: Re-generate.
3082
3083 2020-03-11  Tom Tromey  <tromey@adacore.com>
3084
3085         * ada-typeprint.c (print_choices): Fix comment.
3086
3087 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3088
3089         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3090         previous item in the list, when the list has no items.
3091
3092 2020-03-11  Tom de Vries  <tdevries@suse.de>
3093
3094         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3095         PROP_LOCLIST handling code.
3096
3097 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * buildsym-legacy.c (record_line): Pass extra parameter to
3100         record_line.
3101         * buildsym.c (buildsym_compunit::record_line): Take an extra
3102         parameter, reduce duplication in the line table, and record the
3103         is_stmt flag in the line table.
3104         * buildsym.h (buildsym_compunit::record_line): Add extra
3105         parameter.
3106         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3107         non-statement lines.
3108         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3109         this to the symtab builder.
3110         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3111         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3112         through to dwarf_record_line_1.
3113         * infrun.c (process_event_stop_test): When stepping, don't stop at
3114         a non-statement instruction, and only refresh the step info when
3115         we land in the middle of a line's range.  Also add an extra
3116         comment.
3117         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3118         field.
3119         * record-btrace.c (btrace_find_line_range): Only record lines
3120         marked as is-statement.
3121         * stack.c (frame_show_address): Show the frame address if we are
3122         in a non-statement sal.
3123         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3124         (maintenance_print_one_line_table): Print a header for the is_stmt
3125         column, and include is_stmt information in the output.
3126         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3127         preference to non-statements.
3128         (find_pcs_for_symtab_line): Prefer is-statement entries.
3129         (find_line_common): Likewise.
3130         * symtab.h (struct linetable_entry): Add is_stmt field.
3131         (struct symtab_and_line): Likewise.
3132         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3133         arranging the line table.
3134
3135 2020-03-07  Tom de Vries  <tdevries@suse.de>
3136
3137         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3138         DIE.
3139
3140 2020-03-07  Tom Tromey  <tom@tromey.com>
3141
3142         * valops.c (value_literal_complex): Remove obsolete comment.
3143         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3144         comment.
3145
3146 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3147
3148         * infrun.h: Forward-declare thread_info.
3149         (set_step_info): Add thread_info parameter, add doc.
3150         * infrun.c (set_step_info): Add thread_info parameter, move doc
3151         to header.
3152         * infrun.c (process_event_stop_test): Pass thread to
3153         set_step_info call.
3154         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3155         set_step_info.
3156         (prepare_one_step): Add thread_info parameter, pass it to
3157         set_step_frame and prepare_one_step (recursive) call.
3158         (step_1): Pass thread to prepare_one_step call.
3159         (step_command_fsm::should_stop): Pass thread to
3160         prepare_one_step.
3161         (until_next_fsm): Pass thread to set_step_frame call.
3162         (finish_command): Pass thread to set_step_info call.
3163
3164 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3165
3166         * windows-tdep.c (windows_solib_create_inferior_hook):
3167         Check if inferior is running.
3168
3169 2020-03-06  Tom de Vries  <tdevries@suse.de>
3170
3171         * NEWS: Fix "the the".
3172         * ctfread.c: Same.
3173
3174 2020-03-06  Tom de Vries  <tdevries@suse.de>
3175
3176         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3177
3178 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * .dir-locals.el: Add a comment referencing the other copies of
3181         this file.
3182
3183 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3184
3185         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3186         psargs.
3187
3188 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3189
3190         * .gitattributes: New file.
3191
3192 2020-03-04  Tom Tromey  <tom@tromey.com>
3193
3194         * symmisc.c (print_symbol_bcache_statistics)
3195         (print_objfile_statistics): Update.
3196         * symfile.c (allocate_symtab): Use intern.
3197         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3198         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3199         macro_cache>: Remove.
3200         <string_cache>: New member.
3201         (struct objfile) <intern>: New methods.
3202         * elfread.c (elf_symtab_read): Use intern.
3203         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3204         (dwarf2_compute_name, dwarf2_physname)
3205         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3206         names.
3207         (guess_partial_die_structure_name): Update.
3208         (partial_die_info::fixup): Intern name.
3209         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3210         name.
3211         (dwarf2_name): Intern name.  Update.
3212         * buildsym.c (buildsym_compunit::get_macro_table): Use
3213         string_cache.
3214
3215 2020-03-04  Tom Tromey  <tom@tromey.com>
3216
3217         * jit.c (bfd_open_from_target_memory): Make "target" const.
3218         * corefile.c (gnutarget): Now const.
3219         * gdbcore.h (gnutarget): Now const.
3220
3221 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3222
3223         * NEWS: Mention support for WOW64 processes.
3224         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3225         (amd64_windows_segment_register_p): Remove static.
3226         (_initialize_amd64_windows_nat): Update.
3227         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3228         * i386-windows-nat.c (context_offset): Update.
3229         (i386_mappings): Rename and remove static.
3230         (i386_windows_segment_register_p): Remove static.
3231         (_initialize_i386_windows_nat): Update.
3232         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3233         (STATUS_WX86_SINGLE_STEP): New macro.
3234         (EnumProcessModulesEx): New macro.
3235         (Wow64SuspendThread): New macro.
3236         (Wow64GetThreadContext): New macro.
3237         (Wow64SetThreadContext): New macro.
3238         (Wow64GetThreadSelectorEntry): New macro.
3239         (windows_set_context_register_offsets): Add static.
3240         (windows_set_segment_register_p): Likewise.
3241         (windows_add_thread): Adapt for WOW64 processes.
3242         (windows_fetch_one_register): Likewise.
3243         (windows_nat_target::fetch_registers): Likewise.
3244         (windows_store_one_register): Likewise.
3245         (display_selector): Likewise.
3246         (display_selectors): Likewise.
3247         (handle_exception): Likewise.
3248         (windows_continue): Likewise.
3249         (windows_nat_target::resume): Likewise.
3250         (windows_add_all_dlls): Likewise.
3251         (do_initial_windows_stuff): Likewise.
3252         (windows_nat_target::attach): Likewise.
3253         (windows_get_exec_module_filename): Likewise.
3254         (windows_nat_target::create_inferior): Likewise.
3255         (windows_xfer_siginfo): Likewise.
3256         (_initialize_loadable): Initialize Wow64SuspendThread,
3257         Wow64GetThreadContext, Wow64SetThreadContext,
3258         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3259         * windows-nat.h (windows_set_context_register_offsets):
3260         Remove declaration.
3261         (windows_set_segment_register_p): Likewise.
3262         (i386_windows_segment_register_p): Add declaration.
3263         (amd64_windows_segment_register_p): Likewise.
3264
3265 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3266
3267         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3268         in "info registers" for AArch64/ARM.
3269
3270         The change caused "info registers" to not print GPR's.
3271
3272         gdb/ChangeLog:
3273
3274         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3275
3276         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3277         when reg->group is empty and reggroup is not.
3278
3279 2020-03-03  Tom Tromey  <tromey@adacore.com>
3280
3281         * dwarf2/frame.c (struct dwarf2_frame_cache)
3282         <checked_tailcall_bottom, entry_cfa_sp_offset,
3283         entry_cfa_sp_offset_p>: Remove members.
3284         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3285         (dwarf2_frame_prev_register): Don't call
3286         dwarf2_tailcall_sniffer_first.
3287         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3288         * frame-unwind.c (add_unwinder): New fuction.
3289         (frame_unwind_init): Use it.  Add tailcall unwinder.
3290
3291 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3292             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3293
3294         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3295         value should be printed as true.
3296
3297 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3298
3299         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3300         (windows_init_abi): Set and use windows_so_ops.
3301
3302 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3303
3304         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3305         when verifying if dealing with a convenience variable.
3306
3307 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3308
3309         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3310
3311 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3312
3313         * infrun.c (gdbarch_supports_displaced_stepping): New.
3314         (use_displaced_stepping): Break up conditions in smaller pieces.
3315         Use gdbarch_supports_displaced_stepping.
3316         (displaced_step_prepare_throw): Use
3317         gdbarch_supports_displaced_stepping.
3318
3319 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * NEWS: Mention new behaviour of the history filename.
3322         * top.c (write_history_p): Add comment.
3323         (show_write_history_p): Add header comment, give a different
3324         message when history writing is on, but the history filename is
3325         empty.
3326         (history_filename): Add comment.
3327         (history_filename_empty): New function.
3328         (show_history_filename): Add header comment, give a different
3329         message when the filename is empty.
3330         (init_history): Compare history_filename against nullptr, and only
3331         read history if the filename is not empty.
3332         (set_history_filename): Add header comment, and only make
3333         non-empty filenames absolute.
3334         (init_main): Make the filename argument to 'set history filename'
3335         optional.
3336
3337 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3338
3339         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3340         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3341         (fetch_fp_register): Update.
3342         (fetch_fp_regs): Update.
3343         (store_fp_register): Update.
3344         (store_fp_regs): Update.
3345         (arm_netbsd_nat_target::read_description): New function.
3346         (fetch_elfcore_registers): Update.
3347
3348 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3351         general_thread if the stop reply is missing a thread-id.
3352         (remote_target::process_stop_reply): Use the first non-exited
3353         thread if the target didn't pass a thread-id.
3354         * infrun.c (do_target_wait): Move call to
3355         switch_to_inferior_no_thread to ....
3356         (do_target_wait_1): ... here.
3357
3358 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3359
3360         * debuginfod-support.c: Include defs.h first.
3361
3362 2020-02-28  Tom de Vries  <tdevries@suse.de>
3363
3364         * symfile.c (set_initial_language): Use default language for lookup.
3365
3366 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3367
3368         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3369         reader variable, pass `this` to read_cutu_die_from_dwo.
3370
3371 2020-02-27  Aaron Merey  <amerey@redhat.com>
3372
3373         * source.c (open_source_file): Check for nullptr when computing
3374         srcpath.
3375
3376 2020-02-27  Tom Tromey  <tromey@adacore.com>
3377
3378         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3379         member.
3380         (dwarf2_add_field): Don't update nfields.
3381         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3382
3383 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3386         abs.
3387
3388 2020-02-26  Tom Tromey  <tom@tromey.com>
3389
3390         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3391         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3392         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3393         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3394         per_cu_data.
3395
3396 2020-02-26  Tom Tromey  <tom@tromey.com>
3397
3398         * dwarf2/index-write.c (psym_index_map): Change type.
3399         (add_address_entry_worker, write_one_signatured_type)
3400         (recursively_count_psymbols, recursively_write_psymbols)
3401         (class debug_names, psyms_seen_size, write_gdbindex)
3402         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3403
3404 2020-02-26  Aaron Merey  <amerey@redhat.com>
3405
3406         * Makefile.in: Handle optional debuginfod support.
3407         * NEWS: Update.
3408         * README: Add --with-debuginfod summary.
3409         * config.in: Regenerate.
3410         * configure: Regenerate.
3411         * configure.ac: Handle optional debuginfod support.
3412         * debuginfod-support.c: debuginfod helper functions.
3413         * debuginfod-support.h: Ditto.
3414         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3415         summary.
3416         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3417         when a dwz file cannot be found.
3418         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3419         debuginfo file cannot be found.
3420         * source.c (open_source_file): Query debuginfod servers when a
3421         source file cannot be found.
3422         * top.c (print_gdb_configuration): Include
3423         --{with,without}-debuginfod in the output.
3424
3425 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3426
3427         * thread.c (thr_try_catch_cmd): Print thread name.
3428
3429 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3430
3431         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3432         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3433         dwarf2_fetch_die_type_sect_off): Move to...
3434         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3435         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3436         dwarf2_fetch_die_type_sect_off): ... here.
3437         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3438         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3439         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3440
3441 2020-02-26  Tom de Vries  <tdevries@suse.de>
3442
3443         PR gdb/25603
3444         * symfile.c (set_initial_language): Exit-early if
3445         language_mode == language_mode_manual.
3446
3447 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3448
3449         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3450         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3451         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3452
3453 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3454
3455         * gdbtypes.c (create_array_type_with_stride): Handle negative
3456         array strides.
3457         * valarith.c (value_subscripted_rvalue): Likewise.
3458
3459 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3460
3461         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3462
3463 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3464
3465         * loc.h (dwarf2_get_die_type): Move to...
3466         * read.h (dwarf2_get_die_type): ... here.
3467         * read.c (dwarf2_get_die_type): Move doc to header.
3468
3469 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3470
3471         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3472         'gnulib/Makefile.in' to the list.
3473
3474 2020-02-24  Tom Tromey  <tom@tromey.com>
3475
3476         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3477         Remove.
3478         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3479         XOBNEWVEC.
3480
3481 2020-02-24  Tom Tromey  <tom@tromey.com>
3482
3483         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3484         New method.
3485         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3486         (dw2_do_instantiate_symtab, dw2_get_file_names)
3487         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3488
3489 2020-02-24  Tom Tromey  <tom@tromey.com>
3490
3491         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3492         make_scoped_restore.
3493         (dwarf2_psymtab::read_symtab): Don't clear
3494         reading_partial_symbols.
3495
3496 2020-02-24  Tom de Vries  <tdevries@suse.de>
3497
3498         PR gdb/25592
3499         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3500
3501 2020-02-24  Tom de Vries  <tdevries@suse.de>
3502
3503         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3504         commands layout next/prev/regs.
3505
3506 2020-02-22  Tom Tromey  <tom@tromey.com>
3507
3508         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3509         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3510
3511 2020-02-22  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3514
3515 2020-02-22  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3518         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3519         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3520         * tui/tui.c (_initialize_tui): Add usage text.
3521
3522 2020-02-22  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-win.c (tui_set_focus_command)
3525         (tui_set_win_height_command): Use error_no_arg.
3526         (_initialize_tui_win): Update help text.
3527         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3528
3529 2020-02-22  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3532         * tui/tui-disasm.h (struct tui_disasm_window)
3533         <display_start_addr>: Declare.
3534         * tui/tui-source.h (struct tui_source_window)
3535         <display_start_addr>: Declare.
3536         * tui/tui-winsource.h (struct tui_source_window_base)
3537         <show_source_line, display_start_addr>: New methods.
3538         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3539         Rename and move to protected section.
3540         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3541         (tui_source_window_base::do_erase_source_content): Update.
3542         (tui_source_window_base::show_source_line): Now a method.
3543         (tui_source_window_base::show_source_content)
3544         (tui_source_window_base::tui_source_window_base)
3545         (tui_source_window_base::rerender)
3546         (tui_source_window_base::refill)
3547         (tui_source_window_base::do_scroll_horizontal)
3548         (tui_source_window_base::set_is_exec_point_at)
3549         (tui_source_window_base::update_breakpoint_info)
3550         (tui_source_window_base::update_exec_info): Update.
3551         * tui/tui-source.c (tui_source_window::set_contents)
3552         (tui_source_window::showing_source_p)
3553         (tui_source_window::do_scroll_vertical)
3554         (tui_source_window::location_matches_p)
3555         (tui_source_window::line_is_displayed): Update.
3556         (tui_source_window::display_start_addr): New method.
3557         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3558         (tui_disasm_window::do_scroll_vertical)
3559         (tui_disasm_window::location_matches_p): Update.
3560         (tui_disasm_window::display_start_addr): New method.
3561
3562 2020-02-22  Tom Tromey  <tom@tromey.com>
3563
3564         * NEWS: Add entry for gdb.register_window_type.
3565         * tui/tui-layout.h (window_factory): New typedef.
3566         (tui_register_window): Declare.
3567         * tui/tui-layout.c (saved_tui_windows): New global.
3568         (tui_apply_current_layout): Use it.
3569         (tui_register_window): New function.
3570         * python/python.c (do_start_initialization): Call
3571         gdbpy_initialize_tui.
3572         (python_GdbMethods): Add "register_window_type" function.
3573         * python/python-internal.h (gdbpy_register_tui_window)
3574         (gdbpy_initialize_tui): Declare.
3575         * python/py-tui.c: New file.
3576         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3577
3578 2020-02-22  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3581
3582 2020-02-22  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3585         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3586         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3587         (tui_set_win_focus_to): Move from tui-win.c.
3588
3589 2020-02-22  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3592         functions.
3593         (known_window_types): New global.
3594         (tui_get_window_by_name): Reimplement.
3595         (initialize_known_windows): New function.
3596         (validate_window_name): Rewrite.
3597         (_initialize_tui_layout): Call initialize_known_windows.
3598
3599 2020-02-22  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3602         Remove constants.
3603         * tui/tui-winsource.h (struct tui_source_window_base)
3604         <tui_source_window_base>: Remove parameter.
3605         * tui/tui-winsource.c
3606         (tui_source_window_base::tui_source_window_base): Remove
3607         parameter.
3608         (tui_source_window_base::refill): Update.
3609         * tui/tui-stack.h (struct tui_locator_window)
3610         <tui_locator_window>: Update.
3611         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3612         Default the constructor.
3613         * tui/tui-regs.h (struct tui_data_item_window)
3614         <tui_data_item_window>: Default the constructor.
3615         (struct tui_data_window) <tui_data_window>: Likewise.
3616         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3617         Default the constructor.
3618         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3619         Default the constructor.
3620         <type>: Remove.
3621         (struct tui_win_info) <tui_win_info>: Default the constructor.
3622         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3623         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3624         Default the constructor.
3625
3626 2020-02-22  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3629         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3630         * tui/tui-win.c (tui_resize_all): Don't call
3631         tui_delete_invisible_windows.
3632         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3633         done.
3634         (tui_set_layout): Update.
3635         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3636         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3637         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3638
3639 2020-02-22  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3642         correctly.
3643
3644 2020-02-22  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3647
3648 2020-02-22  Tom Tromey  <tom@tromey.com>
3649
3650         * tui/tui-winsource.h (struct tui_source_window_iterator)
3651         <inner_iterator>: New etytypedef.
3652         <tui_source_window_iterator>: Take "end" parameter.
3653         <tui_source_window_iterator>: Take iterator.
3654         <operator*, advance>: Update.
3655         <m_iter>: Change type.
3656         <m_end>: New field.
3657         (struct tui_source_windows) <begin, end>: Update.
3658         * tui/tui-layout.c (tui_windows): New global.
3659         (tui_apply_current_layout): Clear tui_windows.
3660         (tui_layout_window::apply): Update tui_windows.
3661         * tui/tui-data.h (tui_windows): Declare.
3662         (all_tui_windows): Now inline function.
3663         (class tui_window_iterator, struct all_tui_windows): Remove.
3664
3665 2020-02-22  Tom Tromey  <tom@tromey.com>
3666
3667         PR tui/17850:
3668         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3669         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3670         "height" argument.
3671         (class tui_layout_window) <get_sizes>: Likewise.
3672         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3673         argument.
3674         <get_sizes>: Add "height" argument.
3675         <m_vertical>: New field.
3676         * tui/tui-layout.c (tui_layout_split::clone): Update.
3677         (tui_layout_split::get_sizes): Add "height" argument.
3678         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3679         (tui_new_layout_command): Parse "-horizontal".
3680         (_initialize_tui_layout): Update help string.
3681         (tui_layout_split::specification): Add "-horizontal" when needed.
3682         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3683         argument.
3684         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3685         New methods.
3686
3687 2020-02-22  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-layout.h (enum tui_adjust_result): New.
3690         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3691         (class tui_layout_window) <adjust_size>: Return
3692         tui_adjust_result.  Rewrite.
3693         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3694         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3695
3696 2020-02-22  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3699         parameter and return types.
3700         (class tui_layout_base) <specification>: Add "depth".
3701         (class tui_layout_window) <specification>: Add "depth".
3702         (class tui_layout_split) <specification>: Add "depth".
3703         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3704         and return types.
3705         (tui_new_layout_command): Parse sub-layouts.
3706         (_initialize_tui_layout): Update help string.
3707         (tui_layout_window::specification): Add "depth".
3708         (add_layout_command): Update.
3709
3710 2020-02-22  Tom Tromey  <tom@tromey.com>
3711
3712         * NEWS: Add "tui new-layout" item.
3713         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3714         Add new-layout command to help text.
3715         (validate_window_name): New function.
3716         (tui_new_layout_command): New function.
3717         (_initialize_tui_layout): Register "new-layout".
3718         (tui_layout_window::specification): New method.
3719         (tui_layout_window::specification): New method.
3720         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3721         method.
3722         (class tui_layout_window) <specification>: New method.
3723         (class tui_layout_split) <specification>: New method.
3724
3725 2020-02-22  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3728         * tui/tui-win.c (window_name_completer): Update comment.
3729         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3730         Declare method.
3731         (class tui_layout_window) <replace_window>: Likewise.
3732         (class tui_layout_split) <replace_window>: Likewise.
3733         (tui_set_layout): Don't declare.
3734         (tui_set_initial_layout): Declare function.
3735         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3736         (asm_regs_layout): New globals.
3737         (tui_current_layout, show_layout): Remove.
3738         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3739         (find_layout, tui_apply_layout): New function.
3740         (layout_completer): Remove.
3741         (tui_next_layout): Reimplement.
3742         (tui_next_layout_command): New function.
3743         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3744         (tui_regs_layout): Reimplement.
3745         (tui_regs_layout_command): New function.
3746         (extract_display_start_addr): Rewrite.
3747         (next_layout, prev_layout): Remove.
3748         (tui_layout_window::replace_window): New method.
3749         (tui_layout_split::replace_window): New method.
3750         (destroy_layout): New function.
3751         (layout_list): New global.
3752         (add_layout_command): New function.
3753         (initialize_layouts): Update.
3754         (tui_layout_command): New function.
3755         (_initialize_tui_layout): Install "layout" commands.
3756         * tui/tui-data.h (enum tui_layout_type): Remove.
3757         (tui_current_layout): Don't declare.
3758
3759 2020-02-22  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui-regs.c (tui_reg_layout): Remove.
3762         (tui_reg_command): Use tui_regs_layout.
3763         * tui/tui-layout.h (tui_reg_command): Declare.
3764         * tui/tui-layout.c (tui_reg_command): New function.
3765
3766 2020-02-22  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui.c (tui_rl_delete_other_windows): Call
3769         tui_remove_some_windows.
3770         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3771         Declare method.
3772         (class tui_layout_window) <remove_windows>: New method.
3773         (class tui_layout_split) <remove_windows>: Declare.
3774         (tui_remove_some_windows): Declare.
3775         * tui/tui-layout.c (tui_remove_some_windows): New function.
3776         (tui_layout_split::remove_windows): New method.
3777
3778 2020-02-22  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3781         * tui/tui-layout.h (tui_next_layout): Declare.
3782         * tui/tui-layout.c (tui_next_layout): New function.
3783
3784 2020-02-22  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3787         correct coordinates.
3788
3789 2020-02-22  Tom Tromey  <tom@tromey.com>
3790
3791         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3792         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3793         DATA_WIN case.
3794
3795 2020-02-22  Tom Tromey  <tom@tromey.com>
3796
3797         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3798         TUI_DISASM_WIN, not tui_win_list.
3799
3800 2020-02-22  Tom Tromey  <tom@tromey.com>
3801
3802         * valprint.c (generic_val_print_enum_1)
3803         (val_print_type_code_flags): Style member names.
3804         * rust-lang.c (val_print_struct, rust_print_enum)
3805         (rust_print_struct_def, rust_internal_print_type): Style member
3806         names.
3807         * p-valprint.c (pascal_object_print_value_fields): Style member
3808         names.  Only call fprintf_symbol_filtered for static members.
3809         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3810         * f-valprint.c (f_val_print): Style member names.
3811         * f-typeprint.c (f_type_print_base): Style member names.
3812         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3813         call fprintf_symbol_filtered for static members.
3814         (cp_print_class_member): Style member names.
3815         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3816         member names.
3817         * ada-valprint.c (ada_print_scalar): Style enum names.
3818         (ada_val_print_enum): Likewise.
3819         * ada-typeprint.c (print_enum_type): Style enum names.
3820
3821 2020-02-21  Tom Tromey  <tom@tromey.com>
3822
3823         * psympriv.h (struct partial_symtab): Update comment.
3824
3825 2020-02-21  Tom Tromey  <tromey@adacore.com>
3826
3827         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3828         type is CORE_ADDR.
3829
3830 2020-02-21  Tom de Vries  <tdevries@suse.de>
3831
3832         PR gdb/25534
3833         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3834         if dependencies[i]->user != NULL.
3835
3836 2020-02-21  Ali Tamur  <tamur@google.com>
3837
3838         * dwarf2/read.c (dwarf2_name): Add null check.
3839
3840 2020-02-20  Tom Tromey  <tom@tromey.com>
3841
3842         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3843         ">=", in binary search.
3844         (dwarf2_find_containing_comp_unit): New overload.
3845         (run_test): New self-test.
3846         (_initialize_dwarf2_read): Register new test.
3847
3848 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3849
3850         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3851         * riscv-tdep.h: Likewise.
3852         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3853         rv32-only CSR.
3854         * features/riscv/64bit-csr.xml: Regenerated.
3855
3856 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3857             Tom Tromey  <tom@tromey.com>
3858
3859         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3860         of 'fputc_unfiltered'.
3861         (putchar_unfiltered): Call 'fputc_unfiltered'.
3862         (fputc_unfiltered): Call 'fputs_unfiltered'.
3863
3864 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * config.in: Regenerate.
3867         * configure: Regenerate.
3868         * configure.ac: Add --with-python-libdir option.
3869         * main.c: Use WITH_PYTHON_LIBDIR.
3870
3871 2020-02-19  Tom Tromey  <tom@tromey.com>
3872
3873         * symtab.c (general_symbol_info::compute_and_set_names): Use
3874         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3875
3876 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3877
3878         * dwarf2/read.c (allocate_signatured_type_table,
3879         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3880         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3881         Remove objfile parameter, update all callers.
3882
3883 2020-02-19  Doug Evans  <dje@google.com>
3884
3885         PR rust/25535
3886         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3887         rust_enum_variant calculation.
3888
3889 2020-02-19  Tom Tromey  <tromey@adacore.com>
3890
3891         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3892
3893 2020-02-19  Tom Tromey  <tromey@adacore.com>
3894
3895         * ada-lang.c (cache_symbol): Use obstack_strdup.
3896
3897 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * configure: Regenerate.
3900
3901 2020-02-19  Tom Tromey  <tromey@adacore.com>
3902
3903         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3904         NULL check.
3905
3906 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3907
3908         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3909
3910 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3913         if GDBSERVER is not defined.
3914         (riscv_tdesc_cache): Likewise, also store const target_desc.
3915         (STATIC_IN_GDB): Define.
3916         (riscv_create_target_description): Update declaration with
3917         STATIC_IN_GDB.
3918         (riscv_lookup_target_description): New function, only define if
3919         GDBSERVER is not defined.
3920         * arch/riscv.h (riscv_create_target_description): Declare only
3921         when GDBSERVER is defined.
3922         (riscv_lookup_target_description): New declaration when GDBSERVER
3923         is not defined.
3924         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3925         (riscv_linux_read_features): ...this, and return
3926         riscv_gdbarch_features instead of target_desc.
3927         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3928         (riscv_linux_read_description): Rename to...
3929         (riscv_linux_read_features): ...this.
3930         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3931         Update to use riscv_gdbarch_features and
3932         riscv_lookup_target_description.
3933         * riscv-tdep.c (riscv_find_default_target_description): Use
3934         riscv_lookup_target_description instead of
3935         riscv_create_target_description.
3936
3937 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3938
3939         * valprint.c (generic_val_print_enum_1): When printing a flag
3940         enum with value 0 and there is no enumerator with value 0, print
3941         just "0" instead of "(unknown: 0x0)".
3942
3943 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3944
3945         * valprint.c (generic_val_print_enum_1): Print unknown part of
3946         flag enum in hex.
3947
3948 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3949
3950         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3951         flag enums to contain duplicate enumerators.
3952         * valprint.c (generic_val_print_enum_1): Update comment.
3953
3954 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3955
3956         * dwarf2/read.c: Include "count-one-bits.h".
3957         (update_enumeration_type_from_children): If an enumerator has
3958         multiple bits set, don't treat the enumeration as a "flag enum".
3959         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3960         of flag enums have 0 or 1 bit set.
3961
3962 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3963
3964         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3965         conversion.
3966         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3967         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3968         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3969         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3970         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3971
3972 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3973
3974         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3975
3976 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3977
3978         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3979         displaced_step_closure_up.
3980         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3981         (struct displaced_step_closure_up):
3982         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3983         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3984         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3985         Likewise.
3986         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3987         * gdbarch.c, gdbarch.h: Re-generate.
3988         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3989         displaced_step_closure_up.
3990         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3991         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3992         * infrun.h (displaced_step_closure_up): New type alias.
3993         (struct displaced_step_inferior_state) <step_closure>: Change
3994         type to displaced_step_closure_up.
3995         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3996         displaced_step_closure_up.
3997         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3998
3999 2020-02-14  Tom Tromey  <tom@tromey.com>
4000
4001         * minidebug.c (gnu_debug_key): New global.
4002         (find_separate_debug_file_in_section): Use it.
4003
4004 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4005
4006         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4007         std::unique_ptr.
4008         * gdbarch.c: Re-generate.
4009         * gdbarch.h: Re-generate.
4010         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4011         change.
4012         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4013         type to std::unique_ptr.
4014         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4015         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4016         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4017         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4018         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4019         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4020         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4021         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4022         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4023
4024 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4025
4026         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4027         std::unique_ptr.
4028         (displaced_step_clear): Rename to...
4029         (displaced_step_reset): ... this.  Just call displaced->reset ().
4030         (displaced_step_clear_cleanup): Rename to...
4031         (displaced_step_reset_cleanup): ... this.
4032         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4033         (displaced_step_fixup): Likewise.
4034         (resume_1): Likewise.
4035         (handle_inferior_event): Restore child's memory before calling
4036         displaced_step_fixup on the parent.
4037         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4038         to std::unique_ptr.
4039         <step_closure>: Change type to std::unique_ptr.
4040
4041 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4042
4043         * arm-tdep.c: Include count-one-bits.h.
4044         (cleanup_block_store_pc): Use count_one_bits.
4045         (cleanup_block_load_pc): Use count_one_bits.
4046         (arm_copy_block_xfer): Use count_one_bits.
4047         (thumb2_copy_block_xfer): Use count_one_bits.
4048         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4049         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4050         (thumb_get_next_pcs_raw): Use count_one_bits.
4051         (arm_get_next_pcs_raw): Use count_one_bits_l.
4052         * arch/arm.c (bitcount): Remove.
4053         * arch/arm.h (bitcount): Remove.
4054
4055 2020-02-14  Tom Tromey  <tromey@adacore.com>
4056
4057         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4058         Update.
4059         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4060         * dwarf2/loc.c (call_site_find_chain_1): Return
4061         unique_xmalloc_ptr.
4062         (call_site_find_chain): Likewise.
4063
4064 2020-02-14  Richard Biener  <rguenther@suse.de>
4065
4066         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4067         on expression with division operators.
4068
4069 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4070
4071         * MAINTAINERS (Write After Approval): Adding myself.
4072
4073 2020-02-12  Tom Tromey  <tom@tromey.com>
4074
4075         * event-loop.c (event_data, gdb_event, event_handler_func):
4076         Remove.
4077
4078 2020-02-12  Tom Tromey  <tom@tromey.com>
4079
4080         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4081         (dwarf2_frame_objfile_data): Add comment.
4082         (find_comp_unit, set_comp_unit): New functions.
4083         (dwarf2_frame_find_fde): Use find_comp_unit.
4084         (dwarf2_build_frame_info): Use set_comp_unit.
4085
4086 2020-02-12  Tom Tromey  <tom@tromey.com>
4087
4088         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4089         (comp_unit): Don't initialize objfile.
4090         (execute_cfa_program): Add text_offset parameter.
4091         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4092         (dwarf2_frame_cache): Update.
4093         (dwarf2_build_frame_info): Don't set "objfile" member.
4094
4095 2020-02-12  Tom Tromey  <tom@tromey.com>
4096
4097         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4098         (decode_frame_entry): Likewise.
4099         (dwarf2_build_frame_info): Update.
4100
4101 2020-02-12  Tom Tromey  <tom@tromey.com>
4102
4103         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4104         (decode_frame_entry_1): Use the comp_unit obstack.
4105
4106 2020-02-12  Tom Tromey  <tom@tromey.com>
4107
4108         * dwarf2/frame.c (struct comp_unit): Add initializers and
4109         constructor.
4110         (dwarf2_frame_objfile_data): Store a comp_unit.
4111         (dwarf2_frame_find_fde): Update.
4112         (dwarf2_build_frame_info): Use "new".
4113
4114 2020-02-12  Tom Tromey  <tom@tromey.com>
4115
4116         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4117         (dwarf2_fde_table): Typedef for std::vector.
4118         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4119         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4120         (decode_frame_entry): Update.
4121         (dwarf2_build_frame_info): Use "new".
4122
4123 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4124
4125         * arm-tdep.c (arm_gdbarch_init): Update.
4126         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4127         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4128         have_neon, is_m>: Change to bool.
4129
4130 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4131
4132         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4133
4134 2020-02-12  Tom Tromey  <tom@tromey.com>
4135
4136         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4137
4138 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4139
4140         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4141         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4142
4143 2020-02-11  Tom Tromey  <tom@tromey.com>
4144
4145         * psymtab.h: Update comment.
4146
4147 2020-02-11  Tom Tromey  <tom@tromey.com>
4148
4149         * gdb_obstack.h (struct auto_obstack): Use
4150         DISABLE_COPY_AND_ASSIGN.
4151
4152 2020-02-11  Tom Tromey  <tom@tromey.com>
4153
4154         * dwarf2/frame.h (struct objfile): Don't forward declare.
4155
4156 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4157
4158         * cris-tdep.c (cris_supply_gregset): Change signature to match
4159         what struct regset expects.
4160         (cris_regset): New struct.
4161         (fetch_core_registers): Remove.
4162         (cris_iterate_over_regset_sections): New function.
4163         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4164         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4165
4166 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4167
4168         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4169         registers.
4170
4171 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4172
4173         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4174
4175 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4176
4177         * configure: Re-generate.
4178
4179 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4180
4181         * configure: Re-generate.
4182
4183 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4184
4185         * acinclude: Update warning.m4 path.
4186         * warning.m4: Move to gdbsupport.
4187
4188 2020-02-11  Tom Tromey  <tromey@adacore.com>
4189
4190         * remote.c (remote_console_output): Update.
4191         * printcmd.c (printf_command): Update.
4192         * event-loop.c (gdb_wait_for_event): Update.
4193         * linux-nat.c (sigchld_handler): Update.
4194         * remote-sim.c (gdb_os_write_stdout): Update.
4195         (gdb_os_flush_stdout): Update.
4196         (gdb_os_flush_stderr): Update.
4197         (gdb_os_write_stderr): Update.
4198         * exceptions.c (print_exception): Update.
4199         * remote-fileio.c (remote_fileio_func_read): Update.
4200         (remote_fileio_func_write): Update.
4201         * tui/tui.c (tui_enable): Update.
4202         * tui/tui-interp.c (tui_interp::init): Update.
4203         * utils.c (init_page_info): Update.
4204         (putchar_unfiltered, fputc_unfiltered): Update.
4205         (gdb_flush): Update.
4206         (emit_style_escape): Update.
4207         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4208         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4209         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4210         (stderr_file::write): Update.
4211         (stderr_file::puts): Update.
4212         * ui-file.h (ui_file_isatty, ui_file_write)
4213         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4214         (ui_file_puts): Don't declare.
4215
4216 2020-02-10  Tom de Vries  <tdevries@suse.de>
4217
4218         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4219         sentinel to char *.
4220
4221 2020-02-09  Tom de Vries  <tdevries@suse.de>
4222
4223         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4224         filename if it matches "<artificial>".
4225
4226 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4227
4228         * windows-tdep.c (struct enum_value_name): New struct.
4229         (create_enum): New function.
4230         (windows_get_siginfo_type): Create and use enum types.
4231
4232 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4233
4234         * NEWS: Mention $_siginfo support for Windows.
4235         * windows-nat.c (handle_exception): Set siginfo_er.
4236         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4237         (windows_xfer_siginfo): New function.
4238         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4239         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4240         (init_windows_gdbarch_data): New function.
4241         (get_windows_gdbarch_data): New function.
4242         (windows_get_siginfo_type): New function.
4243         (windows_init_abi): Register windows_get_siginfo_type.
4244         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4245
4246 2020-02-08  Tom Tromey  <tom@tromey.com>
4247
4248         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4249         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4250         <keep>: Declare method.
4251         <m_keep>: Remove member.
4252         <~cutu_reader>: Remove.
4253         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4254         (cutu_reader::cutu_reader): Update.
4255         (cutu_reader::keep): Rename from ~cutu_reader.
4256         (process_psymtab_comp_unit, build_type_psymtabs_1)
4257         (process_skeletonless_type_unit, load_partial_comp_unit)
4258         (load_full_comp_unit, dwarf2_read_addr_index)
4259         (read_signatured_type): Update.
4260
4261 2020-02-08  Tom Tromey  <tom@tromey.com>
4262
4263         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4264         "want_partial_unit" parameter.
4265         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4266         Inline check for DW_TAG_partial_unit.
4267         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4268
4269 2020-02-08  Tom Tromey  <tom@tromey.com>
4270
4271         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4272         read.c.
4273         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4274         read.c.
4275
4276 2020-02-08  Tom Tromey  <tom@tromey.com>
4277
4278         * dwarf2/read.c (read_address): Move to comp-unit.c.
4279         (dwarf2_rnglists_process, dwarf2_ranges_process)
4280         (read_attribute_value, dwarf_decode_lines_1)
4281         (var_decode_location, decode_locdesc): Update.
4282         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4283         read.c.  Remove "cu" parameter.
4284         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4285         method.
4286
4287 2020-02-08  Tom Tromey  <tom@tromey.com>
4288
4289         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4290         (read_indirect_line_string): Update.
4291         * dwarf2/comp-unit.c (read_offset): Remove.
4292         (read_comp_unit_head): Update.
4293         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4294         method.
4295         (read_offset): Don't declare.
4296
4297 2020-02-08  Tom Tromey  <tom@tromey.com>
4298
4299         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4300         * dwarf2/read.c (struct comp_unit_head): Move to
4301         dwarf2/comp-unit.h.
4302         (enum class rcuh_kind): Move to comp-unit.h.
4303         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4304         (read_comp_unit_head, error_check_comp_unit_head)
4305         (read_and_check_comp_unit_head): Move to comp-unit.c.
4306         (read_offset, dwarf_unit_type_name): Likewise.
4307         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4308         (cutu_reader::cutu_reader, read_call_site_scope)
4309         (find_partial_die, follow_die_offset): Update.
4310         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4311
4312 2020-02-08  Tom Tromey  <tom@tromey.com>
4313
4314         * dwarf2/read.c (read_offset_1): Move to leb.c.
4315         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4316         (dwarf_decode_macro_bytes): Update.
4317         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4318         * dwarf2/leb.h (read_offset): Declare.
4319
4320 2020-02-08  Tom Tromey  <tom@tromey.com>
4321
4322         * dwarf2/read.c (dwarf2_section_size): Remove.
4323         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4324         Update.
4325         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4326
4327 2020-02-08  Tom Tromey  <tom@tromey.com>
4328
4329         * dwarf2/read.c (read_initial_length): Move to leb.c.
4330         * dwarf2/leb.h (read_initial_length): Declare.
4331         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4332         handle_nonstd parameter.
4333         * dwarf2/frame.c (read_initial_length): Remove.
4334         (decode_frame_entry_1): Update.
4335
4336 2020-02-08  Tom Tromey  <tom@tromey.com>
4337
4338         * dwarf2/loc.c (dwarf2_find_location_expression)
4339         (dwarf_evaluate_loc_desc::get_tls_address)
4340         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4341         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4342         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4343         (dwarf2_compile_property_to_c)
4344         (dwarf2_loc_desc_get_symbol_read_needs)
4345         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4346         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4347         (loclist_describe_location, loclist_tracepoint_var_ref)
4348         (loclist_generate_c_location): Update.
4349         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4350         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4351         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4352         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4353         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4354         (dwarf2_per_cu_data::addr_size)
4355         (dwarf2_per_cu_data::ref_addr_size)
4356         (dwarf2_per_cu_data::text_offset)
4357         (dwarf2_per_cu_data::addr_type): Now methods.
4358         (per_cu_header_read_in): Make per_cu "const".
4359         (dwarf2_version): Remove.
4360         (dwarf2_per_cu_data::int_type): Now a method.
4361         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4362         (set_die_type, read_array_type, read_subrange_index_type)
4363         (read_tag_string_type, read_subrange_type): Update.
4364         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4365         offset_size, ref_addr_size, text_offset, addr_type, version,
4366         objfile, int_type, addr_sized_int_type>: Declare methods.
4367
4368 2020-02-08  Tom Tromey  <tom@tromey.com>
4369
4370         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4371         Move earlier.
4372
4373 2020-02-08  Tom Tromey  <tom@tromey.com>
4374
4375         * dwarf2/read.h (dwarf_line_debug): Declare.
4376         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4377         * dwarf2/read.c: Move line_header code to new files.
4378         (dwarf_line_debug): No longer static.
4379         * dwarf2/line-header.c: New file.
4380         * dwarf2/line-header.h: New file.
4381
4382 2020-02-08  Tom Tromey  <tom@tromey.com>
4383
4384         * dwarf2/read.c (struct line_header) <file_full_name,
4385         file_file_name>: Return unique_xmalloc_ptr.
4386         (line_header::file_file_name): Update.
4387         (line_header::file_full_name): Update.
4388         (dw2_get_file_names_reader): Update.
4389         (macro_start_file): Update.
4390
4391 2020-02-08  Tom Tromey  <tom@tromey.com>
4392
4393         * dwarf2/read.c (struct line_header) <file_full_name,
4394         file_file_name>: Declare methods.
4395         (dw2_get_file_names_reader): Update.
4396         (file_file_name): Now a method.
4397         (file_full_name): Likewise.
4398         (macro_start_file): Update.
4399
4400 2020-02-08  Tom Tromey  <tom@tromey.com>
4401
4402         * dwarf2/read.c (dwarf_always_disassemble)
4403         (show_dwarf_always_disassemble): Move to loc.c.
4404         (_initialize_dwarf2_read): Move "always-disassemble" registration
4405         to loc.c.
4406         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4407         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4408         static.
4409         (show_dwarf_always_disassemble): Move from read.c.
4410         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4411
4412 2020-02-08  Tom Tromey  <tom@tromey.com>
4413
4414         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4415         (create_quick_file_names_table): Return htab_up.
4416         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4417         Update.
4418         * dwarf2/read.h (struct dwarf2_per_objfile)
4419         <quick_file_names_table>: Now htab_up.
4420
4421 2020-02-08  Tom Tromey  <tom@tromey.com>
4422
4423         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4424
4425 2020-02-08  Tom Tromey  <tom@tromey.com>
4426
4427         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4428         Rewrite.
4429         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4430         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4431         (abbrev_table::abbrev_table): No longer inline.
4432         (ABBREV_HASH_SIZE): Remove.
4433         (abbrev_table::m_abbrevs): Now an htab_up.
4434
4435 2020-02-08  Tom Tromey  <tom@tromey.com>
4436
4437         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4438         (cutu_reader): Update.
4439         (build_type_psymtabs_1): Update.
4440         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4441         (abbrev_table::alloc_abbrev): Update.
4442         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4443         (abbrev_table::read): New static method, renamed from
4444         abbrev_table_read_table.
4445         (abbrev_table::alloc_abbrev)
4446         (abbrev_table::add_abbrev): Now private.
4447         (abbrev_table::abbrev_table): Now private.
4448         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4449
4450 2020-02-08  Tom Tromey  <tom@tromey.com>
4451
4452         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4453         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4454         htab_up.
4455
4456 2020-02-08  Tom Tromey  <tom@tromey.com>
4457
4458         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4459         htab_up.
4460         (lookup_dwo_unit_in_dwp): Update.
4461         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4462         on obstack.
4463
4464 2020-02-08  Tom Tromey  <tom@tromey.com>
4465
4466         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4467         obstack.
4468
4469 2020-02-08  Tom Tromey  <tom@tromey.com>
4470
4471         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4472         line_header_hash.
4473         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4474         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4475         Change type to htab_up.
4476
4477 2020-02-08  Tom Tromey  <tom@tromey.com>
4478
4479         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4480         htab_up.  Don't allocate on obstack.
4481         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4482         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4483         Change type to htab_up.
4484
4485 2020-02-08  Tom Tromey  <tom@tromey.com>
4486
4487         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4488         Change type to htab_up.
4489         * dwarf2/read.c (create_signatured_type_table_from_index)
4490         (create_signatured_type_table_from_debug_names)
4491         (create_all_type_units, add_type_unit)
4492         (lookup_dwo_signatured_type, lookup_signatured_type)
4493         (process_skeletonless_type_unit): Update.
4494         (create_debug_type_hash_table, create_debug_types_hash_table):
4495         Change type of types_htab.
4496         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4497         htab_up.  Don't allocate on obstack.
4498         (create_cus_hash_table): Change type of cus_htab parameter.
4499         (struct dwo_file) <cus, tus>: Now htab_up.
4500         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4501         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4502         (queue_and_load_all_dwo_tus): Update.
4503         * dwarf2/index-write.c (write_gdbindex): Update.
4504         (write_debug_names): Update.
4505
4506 2020-02-08  Tom Tromey  <tom@tromey.com>
4507
4508         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4509         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4510         destructor.
4511         (struct dwarf2_per_objfile) <queue>: New member.
4512         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4513         dwarf2/read.h.
4514         (dwarf2_queue, dwarf2_queue_tail): Remove.
4515         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4516         DISABLE_COPY_AND_ASSIGN.
4517         <m_per_objfile>: New member.
4518         <~dwarf2_queue_guard>: Rewrite.
4519         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4520         Update.
4521         (~dwarf2_queue_item): New.
4522
4523 2020-02-08  Tom Tromey  <tom@tromey.com>
4524
4525         * dwarf2/read.c (struct die_info) <has_children>: New member.
4526         (dw2_get_file_names_reader): Remove has_children.
4527         (dw2_get_file_names): Update.
4528         (read_cutu_die_from_dwo): Remove has_children.
4529         (cutu_reader::init_tu_and_read_dwo_dies)
4530         (cutu_reader::cutu_reader): Update.
4531         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4532         Remove has_children.
4533         (build_type_psymtabs_1, process_skeletonless_type_unit)
4534         (load_partial_comp_unit, load_full_comp_unit): Update.
4535         (create_dwo_cu_reader): Remove has_children.
4536         (create_cus_hash_table, read_die_and_children): Update.
4537         (read_full_die_1,read_full_die): Remove has_children.
4538         (read_signatured_type): Update.
4539         (class cutu_reader) <has_children>: Remove.
4540
4541 2020-02-08  Tom Tromey  <tom@tromey.com>
4542
4543         * dwarf2/expr.c: Rename from dwarf2expr.c.
4544         * dwarf2/expr.h: Rename from dwarf2expr.h.
4545         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4546         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4547         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4548         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4549         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4550         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4551         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4552         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4553         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4554         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4555         * dwarf2/loc.c: Rename from dwarf2loc.c.
4556         * dwarf2/loc.h: Rename from dwarf2loc.h.
4557         * dwarf2/read.c: Rename from dwarf2read.c.
4558         * dwarf2/read.h: Rename from dwarf2read.h.
4559         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4560         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4561         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4562         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4563         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4564         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4565         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4566         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4567         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4568         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4569         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4570         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4571         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4572         Update.
4573         * Makefile.in (COMMON_SFILES): Update.
4574         (HFILES_NO_SRCDIR): Update.
4575
4576 2020-02-08  Tom Tromey  <tom@tromey.com>
4577
4578         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4579         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4580
4581 2020-02-08  Tom Tromey  <tom@tromey.com>
4582
4583         * dwarf2read.h (struct die_info): Don't declare.
4584
4585 2020-02-08  Tom Tromey  <tom@tromey.com>
4586
4587         * dwarf2read.h (die_info_ptr): Remove typedef.
4588
4589 2020-02-08  Tom Tromey  <tom@tromey.com>
4590
4591         * dwarf2read.c (read_call_site_scope)
4592         (handle_data_member_location, dwarf2_add_member_fn)
4593         (mark_common_block_symbol_computed, read_common_block)
4594         (attr_to_dynamic_prop, partial_die_info::read)
4595         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4596         (dwarf2_symbol_mark_computed, set_die_type): Update.
4597         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4598         method.
4599         (attr_form_is_block): Don't declare.
4600         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4601
4602 2020-02-08  Tom Tromey  <tom@tromey.com>
4603
4604         * dwarf2read.c (dwarf2_find_base_address, )
4605         (read_call_site_scope, rust_containing_type)
4606         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4607         (handle_data_member_location, dwarf2_add_member_fn)
4608         (get_alignment, read_structure_type, process_structure_scope)
4609         (mark_common_block_symbol_computed, read_common_block)
4610         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4611         (partial_die_info::read, read_attribute_value, new_symbol)
4612         (lookup_die_type, dwarf2_get_ref_die_offset)
4613         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4614         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4615         (dwarf2_symbol_mark_computed): Update.
4616         * dwarf2/attribute.h (struct attribute) <value_as_address,
4617         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4618         methods.
4619         (value_as_address, attr_form_is_section_offset)
4620         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4621         * dwarf2/attribute.c (attribute::value_as_address)
4622         (attribute::form_is_section_offset, attribute::form_is_constant)
4623         (attribute::form_is_ref): Now methods.
4624
4625 2020-02-08  Tom Tromey  <tom@tromey.com>
4626
4627         * dwarf2read.c (struct attribute, DW_STRING)
4628         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4629         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4630         (attr_form_is_block, attr_form_is_section_offset)
4631         (attr_form_is_constant, attr_form_is_ref): Move.
4632         * dwarf2/attribute.h: New file.
4633         * dwarf2/attribute.c: New file, from dwarf2read.c.
4634         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4635
4636 2020-02-08  Tom Tromey  <tom@tromey.com>
4637
4638         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4639         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4640         Move.
4641         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4642         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4643         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4644         abbrev.c.
4645         * dwarf2/abbrev.h: New file.
4646         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4647         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4648
4649 2020-02-08  Tom Tromey  <tom@tromey.com>
4650
4651         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4652         (dwarf2_section_size, dwarf2_get_section_info)
4653         (create_signatured_type_table_from_debug_names)
4654         (create_addrmap_from_aranges, read_debug_names_from_section)
4655         (get_gdb_index_contents_from_section, read_comp_unit_head)
4656         (error_check_comp_unit_head, read_abbrev_offset)
4657         (create_debug_type_hash_table, init_cu_die_reader)
4658         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4659         (read_comp_units_from_section, create_cus_hash_table)
4660         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4661         (create_dwp_v2_section, dwarf2_rnglists_process)
4662         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4663         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4664         (read_indirect_string_from_dwz, read_addr_index_1)
4665         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4666         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4667         (fill_in_loclist_baton): Update.
4668         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4669         get_containing_section, get_bfd_owner, get_bfd_section,
4670         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4671         (dwarf2_read_section, get_section_name, get_section_file_name)
4672         (get_containing_section, get_section_bfd_owner)
4673         (get_section_bfd_section, get_section_name, get_section_file_name)
4674         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4675         declare.
4676         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4677         (dwarf2_section_info::get_bfd_owner)
4678         (dwarf2_section_info::get_bfd_section)
4679         (dwarf2_section_info::get_name)
4680         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4681         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4682         (dwarf2_section_info::read): Now methods.
4683         * dwarf-index-write.c (class debug_names): Update.
4684
4685 2020-02-08  Tom Tromey  <tom@tromey.com>
4686
4687         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4688         Move to dwarf2/section.h.
4689         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4690         (get_section_bfd_section, get_section_name)
4691         (get_section_file_name, get_section_id, get_section_flags)
4692         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4693         dwarf2/section.c.
4694         * dwarf2/section.h: New file.
4695         * dwarf2/section.c: New file, from dwarf2read.c.
4696         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4697
4698 2020-02-08  Tom Tromey  <tom@tromey.com>
4699
4700         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4701         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4702         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4703         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4704         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4705         * dwarf2/leb.h: New file, from dwarf2read.c.
4706         * dwarf2/leb.c: New file, from dwarf2read.c.
4707         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4708         Remove.
4709         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4710         (COMMON_SFILES): Add dwarf2/leb.c.
4711
4712 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4713
4714         GDB 9.1 released.
4715
4716 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4717
4718         PR gdb/25190:
4719         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4720         * gdb/remote.c (remote_console_output): Update.
4721         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4722         (ui_file_puts): ...this.
4723         * gdb/ui-file.h (ui_file_puts): Add declaration.
4724         * gdb/utils.c (emit_style_escape): Update.
4725         (flush_wrap_buffer): Update.
4726         (fputs_maybe_filtered): Update.
4727         (fputs_unfiltered): Add function.
4728
4729 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4730
4731         * gdb/event-loop.c (gdb_wait_for_event): Update.
4732         * gdb/printcmd.c (printf_command): Update.
4733         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4734         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4735         (gdb_os_flush_stderr): Update.
4736         * gdb/remote.c (remote_console_output): Update.
4737         * gdb/ui-file.c (gdb_flush): Rename to...
4738         (ui_file_flush): ...this.
4739         (stderr_file::write): Update.
4740         (stderr_file::puts): Update.
4741         * gdb/ui-file.h (gdb_flush): Rename to...
4742         (ui_file_flush): ...this.
4743         * gdb/utils.c (gdb_flush): Add function.
4744         * gdb/utils.h (gdb_flush): Add declaration.
4745
4746 2020-02-07  Tom Tromey  <tromey@adacore.com>
4747
4748         PR breakpoints/24915:
4749         * source.c (find_and_open_source): Do not check basenames_may_differ.
4750
4751 2020-02-07  Tom Tromey  <tom@tromey.com>
4752
4753         * README: Update gdbserver documentation.
4754         * gdbserver: Move to top level.
4755         * configure.tgt (build_gdbserver): Remove.
4756         * configure.ac: Remove --enable-gdbserver.
4757         * configure: Rebuild.
4758         * Makefile.in (distclean): Don't mention gdbserver.
4759
4760 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4761
4762         * source-cache.c (source_cache::ensure): Surround
4763         get_plain_source_lines with a try/catch.
4764         (source_cache::get_line_charpos): Get rid of try/catch
4765         and only check for the return value of "ensure".
4766         * tui/tui-source.c (tui_source_window::set_contents):
4767         Simplify "nlines" calculation.
4768
4769 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4770
4771         * MAINTAINERS (Write After Approval): Add myself.
4772
4773 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4774
4775         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4776         function call.
4777
4778 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4779
4780         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4781
4782 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4783
4784         * nat/riscv-linux-tdesc.h: New file.
4785         * nat/riscv-linux-tdesc.c: New file, taking code from...
4786         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4787         ... here.
4788         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4789         NATDEPFILES.
4790
4791 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4792
4793         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4794         we don't set the fake simulator ptid to the null_ptid.
4795
4796 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4797
4798         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4799         * gdbthread.h (class thread_info) <resumed>: Likewise.
4800         * infrun.c (resume_1): Likewise.
4801         (proceed): Likewise.
4802         (infrun_thread_stop_requested): Likewise.
4803         (stop_all_threads): Likewise.
4804         (handle_inferior_event): Likewise.
4805         (restart_threads): Likewise.
4806         (finish_step_over): Likewise.
4807         (keep_going_stepped_thread): Likewise.
4808         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4809         (linux_handle_extended_wait): Likewise.
4810         * record-btrace.c (get_thread_current_frame_id): Likewise.
4811         * record-full.c (record_full_wait_1): Likewise.
4812         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4813         * target.c (target_resume): Likewise.
4814         * thread.c (set_running_thread): Likewise.
4815
4816 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4817
4818         * f-valprint.c (f77_print_array_1): Changed datatype of index
4819         variable to LONGEST from int to enable it to contain bound
4820         values correctly.
4821
4822 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4823
4824         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4825         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4826         offsets according to FLEN determined.
4827         (riscv_linux_nat_target::read_description): Determine FLEN
4828         dynamically.
4829         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4830         according to FLEN determined.
4831         (riscv_linux_nat_target::store_registers): Likewise.
4832
4833 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4834
4835         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4836         when reg->group is empty and reggroup is not.
4837
4838 2020-01-31  Tom Tromey  <tromey@adacore.com>
4839
4840         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4841         Call beneath target's mourn_inferior after unpushing.
4842
4843 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         PR tui/9765
4846         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4847         have enough lines to fill the screen, still return the lowest
4848         address we found.
4849
4850 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4853         '-', '<', and '>' commands.
4854
4855 2020-01-29  Pedro Alves  <palves@redhat.com>
4856             Sergio Durigan Junior  <sergiodj@redhat.com>
4857
4858         * infcmd.c (construct_inferior_arguments): Assert that
4859         'argc' is greater than 0.
4860
4861 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4862
4863         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4864         (BRK_INSN_MASK): Define to 0xd4200000.
4865         (aarch64_program_breakpoint_here_p): New function.
4866         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4867         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4868         breakpoint.c.
4869         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4870         breakpoint.h
4871         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4872         call gdbarch_program_breakpoint_here_p.
4873         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4874         default_program_breakpoint_here_p, changed return type to bool and
4875         simplified.
4876         * breakpoint.h (program_breakpoint_here): Moved prototype to
4877         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4878         return type to bool.
4879         * gdbarch.c: Regenerate.
4880         * gdbarch.h: Regenerate.
4881         * gdbarch.sh (program_breakpoint_here_p): New method.
4882         * infrun.c (handle_signal_stop): Call
4883         gdbarch_program_breakpoint_here_p.
4884
4885 2020-01-26  Tom Tromey  <tom@tromey.com>
4886
4887         * ctfread.c (struct ctf_fp_info): Reindent.
4888         (_initialize_ctfread): Remove.
4889
4890 2020-01-26  Tom Tromey  <tom@tromey.com>
4891
4892         * psymtab.c (partial_map_expand_apply)
4893         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4894         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4895         (psym_print_stats, psym_expand_symtabs_for_function)
4896         (psym_map_symbol_filenames, psym_map_matching_symbols)
4897         (psym_expand_symtabs_matching)
4898         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4899         (maintenance_check_psymtabs): Use new methods.
4900         * psympriv.h (struct partial_symtab) <readin_p,
4901         get_compunit_symtab>: New methods.
4902         <readin, compunit_symtab>: Remove members.
4903         (struct standard_psymtab): New.
4904         (struct legacy_psymtab): Derive from standard_psymtab.
4905         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4906         standard_psymtab.
4907         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4908
4909 2020-01-26  Tom Tromey  <tom@tromey.com>
4910
4911         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4912         read_dependencies.  Add assert.
4913         * psymtab.c (partial_symtab::read_dependencies): New method.
4914         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4915         method.
4916         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4917         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4918         read_dependencies.
4919         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4920         Add assert.
4921
4922 2020-01-26  Tom Tromey  <tom@tromey.com>
4923
4924         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4925         Call expand_psymtab.
4926         (xcoff_read_symtab): Call expand_psymtab.
4927         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4928         legacy_expand_psymtab.
4929         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4930         method.
4931         (struct legacy_psymtab) <expand_psymtab>: Implement.
4932         <legacy_expand_psymtab>: New member.
4933         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4934         (parse_partial_symbols): Set legacy_expand_psymtab.
4935         (psymtab_to_symtab_1): Change argument order.  Call
4936         expand_psymtab.
4937         (new_psymtab): Set legacy_expand_psymtab.
4938         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4939         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4940         expand_psymtab.
4941         (dwarf2_psymtab::expand_psymtab): Rename from
4942         psymtab_to_symtab_1.  Call expand_psymtab.
4943         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4944         (dbx_end_psymtab): Likewise.
4945         (dbx_psymtab_to_symtab_1): Change argument order. Call
4946         expand_psymtab.
4947         (dbx_read_symtab): Call expand_psymtab.
4948         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4949         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4950         (ctf_psymtab::read_symtab): Call expand_psymtab.
4951
4952 2020-01-26  Tom Tromey  <tom@tromey.com>
4953
4954         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4955         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4956         messages.
4957         * mdebugread.c (mdebug_read_symtab): Remove prints.
4958         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4959         assert.
4960         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4961
4962 2020-01-26  Tom Tromey  <tom@tromey.com>
4963
4964         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4965         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4966         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4967         legacy_symtab.
4968         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4969         * psymtab.c (psymtab_to_symtab): Call method.
4970         (dump_psymtab): Update.
4971         * psympriv.h (struct partial_symtab): Add virtual destructor.
4972         <read_symtab>: New method.
4973         (struct legacy_symtab): New.
4974         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4975         (struct pst_map) <pst>: Now a legacy_psymtab.
4976         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4977         (new_psymtab): Use legacy_psymtab.
4978         * dwarf2read.h (struct dwarf2_psymtab): New.
4979         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4980         * dwarf2read.c (dwarf2_create_include_psymtab)
4981         (dwarf2_build_include_psymtabs, create_type_unit_group)
4982         (create_partial_symtab, process_psymtab_comp_unit_reader)
4983         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4984         (set_partial_user): Use dwarf2_psymtab.
4985         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4986         (psymtab_to_symtab_1, process_full_comp_unit)
4987         (process_full_type_unit, dwarf2_ranges_read)
4988         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4989         (dwarf_decode_lines): Use dwarf2_psymtab.
4990         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4991         (add_address_entry_worker, write_one_signatured_type)
4992         (recursively_count_psymbols, recursively_write_psymbols)
4993         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4994         (write_debug_names): Likewise.
4995         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4996         <pst>: Now a legacy_psymtab.
4997         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4998         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4999         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5000         * ctfread.c (struct ctf_psymtab): New.
5001         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5002         ctf_psymtab.
5003         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5004         (create_partial_symtab): Return a ctf_psymtab.
5005         (scan_partial_symbols): Update.
5006
5007 2020-01-26  Tom Tromey  <tom@tromey.com>
5008
5009         * xcoffread.c (xcoff_start_psymtab): Use new.
5010         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5011         renamed from start_psymtab_common.
5012         * psympriv.h (struct partial_symtab): Add new constructor.
5013         (start_psymtab_common): Don't declare.
5014         * mdebugread.c (parse_partial_symbols): Use new.
5015         * dwarf2read.c (create_partial_symtab): Use new.
5016         * dbxread.c (start_psymtab): Use new.
5017         * ctfread.c (create_partial_symtab): Use new.
5018
5019 2020-01-26  Tom Tromey  <tom@tromey.com>
5020
5021         * xcoffread.c (xcoff_end_psymtab): Use new.
5022         * psymtab.c (start_psymtab_common): Use new.
5023         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5024         Update.
5025         * psympriv.h (struct partial_symtab): Add parameters to
5026         constructor.  Don't inline.
5027         (allocate_psymtab): Don't declare.
5028         * mdebugread.c (new_psymtab): Use new.
5029         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5030         * dbxread.c (dbx_end_psymtab): Use new.
5031
5032 2020-01-26  Tom Tromey  <tom@tromey.com>
5033
5034         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5035         allocate_psymtab.  Update documentation.
5036         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5037         allocate_psymtab.  Do not use new.
5038         (allocate_psymtab): Use new.  Update.
5039
5040 2020-01-26  Tom Tromey  <tom@tromey.com>
5041
5042         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5043         * psymtab.c (psym_print_stats): Update.
5044         * psympriv.h (struct partial_symtab) <readin,
5045         psymtabs_addrmap_supported, anonymous>: Now bool.
5046         * mdebugread.c (psymtab_to_symtab_1): Update.
5047         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5048         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5049         (process_full_comp_unit, process_full_type_unit): Update.
5050         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5051         * ctfread.c (psymtab_to_symtab): Update.
5052
5053 2020-01-26  Tom Tromey  <tom@tromey.com>
5054
5055         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5056         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5057         * psymtab.c (psymtab_storage): Delete psymtabs.
5058         (psymtab_storage::allocate_psymtab): Use new.
5059         (psymtab_storage::discard_psymtab): Use delete.
5060         * psympriv.h (struct partial_symtab): Add constructor and
5061         initializers.
5062
5063 2020-01-26  Tom Tromey  <tom@tromey.com>
5064
5065         * machoread.c: Do not include psympriv.h.
5066
5067 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5068
5069         * NEWS: Mention the new option and the set/show commands.
5070
5071 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5072
5073         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5074         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5075         (validate_exec_file): New variables, enums, functions.
5076         (exec_file_locate_attach, print_section_info): Style the filenames.
5077         (_initialize_exec): Install show_exec_file_mismatch_command and
5078          set_exec_file_mismatch_command.
5079         * gdbcore.h (validate_exec_file): Declare.
5080         * infcmd.c (attach_command): Call validate_exec_file.
5081         * remote.c ( remote_target::remote_add_inferior): Likewise.
5082
5083 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         * frame.c (find_frame_sal): Move call to get_next_frame into more
5086         inner scope.
5087         * inline-frame.c (inilne_state) <inline_state>: Update argument
5088         types.
5089         (inilne_state) <skipped_symbol>: Rename to...
5090         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5091         (skip_inline_frames): Build vector of skipped symbols and use this
5092         to reate the inline_state.
5093         (inline_skipped_symbol): Add a comment and some assertions, fetch
5094         skipped symbol from the list.
5095
5096 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * buildsym.c (lte_is_less_than): Delete.
5099         (buildsym_compunit::end_symtab_with_blockvector): Create local
5100         lambda function to sort line table entries, and use
5101         std::stable_sort instead of std::sort.
5102         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5103         markers when looking for a previous line.
5104
5105 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5106
5107         * dwarf2read.c (lnp_state_machine::record_line): Include
5108         end_sequence parameter in debug print out.  Record the line if we
5109         are at an end_sequence marker even if it's not the start of a
5110         statement.
5111         * symmisc.c (maintenance_print_one_line_table): Print end of
5112         sequence markers with 'END' not '0'.
5113
5114 2020-01-24  Pedro Alves  <palves@redhat.com>
5115
5116         PR gdb/25410
5117         * thread.c (scoped_restore_current_thread::restore): Use
5118         switch_to_inferior_no_thread.
5119         * exec.c: Include "progspace-and-thread.h".
5120         (add_target_sections, remove_target_sections):
5121         scoped_restore_current_pspace_and_thread instead of
5122         scoped_restore_current_thread.
5123         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5124         and aspace to the inferior before calling clone_program_space.
5125         Remove stale comment.
5126
5127 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5128
5129         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5130         (arm_netbsd_nat_target::fetch_registers): ...this.
5131         (arm_nbsd_nat_target::store_registers): Rename to...
5132         (arm_netbsd_nat_target::store_registers): ...this.
5133
5134 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5135
5136         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5137         register_t.
5138
5139 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5140
5141         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5142         Update comment.
5143         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5144         Likewise.
5145         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5146         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5147         the correct replacement (iterate_over_regset_sections).
5148         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5149         Update comment.
5150
5151 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5152
5153         PR gdb/23718
5154         * gdb/python/python.c (execute_gdb_command): Call
5155         async_enable_stdin in catch block.
5156
5157 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5160         SWITCH_THRU_ALL_UIS.
5161
5162 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5163
5164         PR tui/9765
5165         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5166         comment, add extra parameter, and update to store previous symbol
5167         when appropriate.
5168         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5169         add extra parameter.
5170         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5171         remove unneeded parameter, add try/catch around gdb_print_insn,
5172         rewrite to add items to asm_lines vector.
5173         (tui_find_backward_disassembly_start_address): New function.
5174         (tui_find_disassembly_address): Updated throughout.
5175         (tui_disasm_window::set_contents): Update for changes to
5176         tui_disassemble.
5177         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5178         number of lines to scroll.
5179
5180 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5181
5182         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5183         (SECT_OFF_DATA): Likewise.
5184         (SECT_OFF_RODATA): Likewise.
5185         (SECT_OFF_TEXT): Likewise.
5186         (SECT_OFF_BSS): Likewise.
5187         (struct objfile) <text_section_offset, data_section_offset>: New
5188         methods.
5189         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5190         objfile::text_section_offset.
5191         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5192         * coffread.c (coff_symtab_read): Likewise.
5193         (enter_linenos): Likewise.
5194         (process_coff_symbol): Likewise.
5195         * ctfread.c (get_objfile_text_range): Likewise.
5196         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5197         Use objfile::data_section_offset.
5198         * dwarf2-frame.c (execute_cfa_program): Use
5199         objfile::text_section_offset.
5200         (dwarf2_frame_find_fde): Likewise.
5201         * dwarf2read.c (create_addrmap_from_index): Likewise.
5202         (create_addrmap_from_aranges): Likewise.
5203         (dw2_find_pc_sect_compunit_symtab): Likewise.
5204         (process_psymtab_comp_unit_reader): Likewise.
5205         (add_partial_symbol): Likewise.
5206         (add_partial_subprogram): Likewise.
5207         (process_full_comp_unit): Likewise.
5208         (read_file_scope): Likewise.
5209         (read_func_scope): Likewise.
5210         (read_lexical_block_scope): Likewise.
5211         (read_call_site_scope): Likewise.
5212         (dwarf2_rnglists_process): Likewise.
5213         (dwarf2_ranges_process): Likewise.
5214         (dwarf2_ranges_read): Likewise.
5215         (dwarf_decode_lines_1): Likewise.
5216         (new_symbol): Likewise.
5217         (dwarf2_fetch_die_loc_sect_off): Likewise.
5218         (dwarf2_per_cu_text_offset): Likewise.
5219         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5220         * hppa-tdep.c (read_unwind_info): Likewise.
5221         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5222         * psympriv.h (struct partial_symtab): Likewise.
5223         * psymtab.c (find_pc_sect_psymtab): Likewise.
5224         * solib-svr4.c (enable_break): Likewise.
5225         * stap-probe.c (relocate_address): Use
5226         objfile::data_section_offset.
5227         * xcoffread.c (enter_line_range): Use
5228         objfile::text_section_offset.
5229         (read_xcoff_symtab): Likewise.
5230
5231 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5232
5233         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5234         declaration to narrower scopes.
5235
5236 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * darwin-nat.h (struct darwin_exception_msg, enum
5239         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5240         Move up.
5241         (class darwin_nat_target) <wait_1, check_new_threads,
5242         decode_exception_message, decode_message, stop_inferior,
5243         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5244         * darwin-nat.c (darwin_check_new_threads): Rename to...
5245         (darwin_nat_target::check_new_threads): ... this.
5246         (darwin_suspend_inferior_it): Remove.
5247         (darwin_decode_exception_message): Rename to...
5248         (darwin_nat_target::decode_exception_message): ... this.
5249         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5250         (darwin_decode_message): Rename to...
5251         (darwin_nat_target::decode_message): ... this.
5252         (cancel_breakpoint): Rename to...
5253         (darwin_nat_target::cancel_breakpoint): ... this.
5254         (darwin_wait): Rename to...
5255         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5256         instead of iterate_over_inferiors.
5257         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5258         (darwin_stop_inferior): Rename to...
5259         (darwin_nat_target::stop_inferior): ... this.
5260         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5261         (darwin_init_thread_list): Rename to...
5262         (darwin_nat_target::init_thread_list): ... this.
5263         (darwin_ptrace_him): Rename to...
5264         (darwin_nat_target::ptrace_him): ... this.
5265         (darwin_nat_target::create_inferior): Pass lambda function to
5266         fork_inferior.
5267         (darwin_nat_target::detach): Call stop_inferior instead of
5268         darwin_stop_inferior.
5269         * fork-inferior.h (fork_inferior): Change init_trace_fun
5270         parameter to gdb::function_view.
5271         * fork-inferior.c (fork_inferior): Likewise.
5272
5273 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5274
5275         * i386-cygwin-tdep.c (core_process_module_section): Update.
5276         * windows-nat.c (struct lm_info_windows): Add text_offset.
5277         (windows_xfer_shared_libraries): Update.
5278         * windows-tdep.c (windows_xfer_shared_library):
5279         Add text_offset_cached argument.
5280         * windows-tdep.h (windows_xfer_shared_library): Update.
5281
5282 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5283
5284         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5285
5286 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5287
5288         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5289         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5290         replace with range-based for.
5291         (gdbsim_interrupt_inferior): Remove.
5292         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5293         with a range-based for.  Inline code from
5294         gdbsim_interrupt_inferior.
5295
5296 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5297
5298         * infrun.c (proceed): Fix indentation.
5299
5300 2020-01-21  Tom Tromey  <tromey@adacore.com>
5301
5302         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5303         * python/python.c (python_extension_ops): Update.
5304         (gdbpy_colorize): New function.
5305         * python/lib/gdb/__init__.py (colorize): New function.
5306         * extension.h (ext_lang_colorize): Declare.
5307         * extension.c (ext_lang_colorize): New function.
5308         * extension-priv.h (struct extension_language_ops) <colorize>: New
5309         member.
5310         * cli/cli-style.c (_initialize_cli_style): Update help text.
5311
5312 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5313
5314         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5315         <cond>: Change type to bool.
5316         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5317         (aarch64_displaced_step_cb): Likewise.
5318         (aarch64_displaced_step_tb): Likewise.
5319
5320 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5321
5322         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5323         output.
5324
5325 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5326
5327         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5328         <pc_adjust>: Adjust the documentation.
5329         (aarch64_displaced_step_fixup): Check if PC really moved before
5330         adjusting it.
5331
5332 2020-01-19  Tom Tromey  <tom@tromey.com>
5333
5334         * disasm.c (~gdb_disassembler): New destructor.
5335         (gdb_buffered_insn_length): Call disassemble_free_target.
5336         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5337         DISABLE_COPY_AND_ASSIGN.
5338
5339 2020-01-19  Tom Tromey  <tom@tromey.com>
5340
5341         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5342         (die_reader_func_ftype): Remove.
5343         (cutu_reader): New class.
5344         (dw2_get_file_names_reader): Remove "data" parameter.
5345         (dw2_get_file_names): Use cutu_reader.
5346         (create_debug_type_hash_table): Update.
5347         (read_cutu_die_from_dwo): Update comment.
5348         (lookup_dwo_unit): Add dwo_name parameter.
5349         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5350         die_reader_func_ftype and data parameters.
5351         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5352         Remove die_reader_func_ftype and data parameters.
5353         (~cutu_reader): New; from init_cutu_and_read_dies.
5354         (cutu_reader::cutu_reader): Rename from
5355         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5356         and data parameters.
5357         (init_cutu_and_read_dies_simple): Remove.
5358         (struct process_psymtab_comp_unit_data): Remove.
5359         (process_psymtab_comp_unit_reader): Remove data parameter; add
5360         want_partial_unit and pretend_language parameters.
5361         (process_psymtab_comp_unit): Use cutu_reader.
5362         (build_type_psymtabs_reader): Remove data parameter.
5363         (build_type_psymtabs_1): Use cutu_reader.
5364         (process_skeletonless_type_unit): Likewise.
5365         (load_partial_comp_unit_reader): Remove.
5366         (load_partial_comp_unit): Use cutu_reader.
5367         (load_full_comp_unit_reader): Remove.
5368         (load_full_comp_unit): Use cutu_reader.
5369         (struct create_dwo_cu_data): Remove.
5370         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5371         dwo_unit parameters.
5372         (create_cus_hash_table): Use cutu_reader.
5373         (struct dwarf2_read_addr_index_data): Remove.
5374         (dwarf2_read_addr_index_reader): Remove.
5375         (dwarf2_read_addr_index): Use cutu_reader.
5376         (read_signatured_type_reader): Remove.
5377         (read_signatured_type): Use cutu_reader.
5378
5379 2020-01-19  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5382         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5383         (tui_wrefresh): Declare.
5384         * tui/tui-wingeneral.c (suppress_output): New global.
5385         (tui_suppress_output, ~tui_suppress_output): New constructor and
5386         destructor.
5387         (tui_wrefresh): New function.
5388         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5389         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5390         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5391         method.
5392         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5393         tui_wrefresh.
5394         (tui_data_window::no_refresh): New method.
5395         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5396         (tui_reg_command): Use tui_suppress_output
5397         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5398         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5399         method.
5400         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5401
5402 2020-01-19  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5405         Handle case where symtab is null.
5406
5407 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5408
5409         * linux-fork.c (one_fork_p): Simplify.
5410
5411 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5412
5413         * top.c (struct qt_args): Remove.
5414         (kill_or_detach): Change return type to void, replace `void *`
5415         parameter with a proper one.
5416         (print_inferior_quit_action):  Likewise.
5417         (quit_confirm): Use range-based for loop to iterate over inferiors.
5418         (quit_force): Likewise.
5419
5420 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5421
5422         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5423         `void *` parameter with proper parameters.
5424         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5425         (print_one_inferior): Change return type to void, replace `void *`
5426         parameter with proper parameters.
5427         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5428         inferiors.
5429         (get_other_inferior): Remove.
5430         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5431         inferiors.
5432
5433 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5434
5435         * mi/mi-interp.c (report_initial_inferior): Remove.
5436         (mi_interp::init): Use range-based for to iterate over inferiors.
5437
5438 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5439
5440         * python/py-inferior.c (build_inferior_list): Remove.
5441         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5442
5443 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5444
5445         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5446         (btrace_stitch_trace): Likewise.
5447         * charset.c (intermediate_encoding): Likewise (vaild).
5448         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5449         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5450         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5451
5452 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5453
5454         * windows-tdep.c (windows_get_tlb_type):
5455         Add rtl_user_process_parameters type.
5456
5457 2020-01-16  Pedro Alves  <palves@redhat.com>
5458             Norbert Lange  <nolange79@gmail.com>
5459
5460         PR build/24805
5461         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5462         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5463         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5464         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5465         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5466         (ps_plog): Redeclare exported functions with default visibility.
5467
5468 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5469
5470         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5471         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5472
5473 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5474
5475         * infcmd.c (post_create_inferior): Use get_thread_regcache
5476         instead of get_current_regcache.
5477
5478 2020-01-14  Tom Tromey  <tom@tromey.com>
5479
5480         PR symtab/12535:
5481         * python/python.c (gdbpy_decode_line): Treat empty string the same
5482         as no argument.
5483
5484 2020-01-14  Tom Tromey  <tom@tromey.com>
5485
5486         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5487
5488 2020-01-14  Tom Tromey  <tom@tromey.com>
5489
5490         * nat/linux-btrace.c: Don't include <config.h>.
5491         * nat/linux-ptrace.c: Don't include <config.h>.
5492         * nat/x86-linux-dregs.c: Don't include <config.h>.
5493
5494 2020-01-14  Tom Tromey  <tom@tromey.com>
5495
5496         * configure: Rebuild.
5497         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5498
5499 2020-01-14  Tom Tromey  <tom@tromey.com>
5500
5501         * nat/x86-linux-dregs.c: Include configh.h.
5502         * nat/linux-ptrace.c: Include configh.h.
5503         * nat/linux-btrace.c: Include configh.h.
5504         * defs.h: Include config.h, bfd.h.
5505         * configure.ac: Don't source common.host.
5506         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5507         * configure: Rebuild.
5508         * acinclude.m4: Update path.
5509         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5510         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5511         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5512         (CLIBS): Add LIBSUPPORT.
5513         (CDEPS): Likewise.
5514         (COMMON_SFILES): Remove gdbsupport files.
5515         (HFILES_NO_SRCDIR): Likewise.
5516         (stamp-version): Update path to create-version.sh.
5517         (ALLDEPFILES): Remove gdbsupport files.
5518
5519 2020-01-14  Tom Tromey  <tom@tromey.com>
5520
5521         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5522         USE_WIN32API when needed.
5523         * configure.ac (USE_WIN32API): Don't define.
5524         (WIN32LIBS): Use WIN32APILIBS.
5525         * configure: Rebuild.
5526
5527 2020-01-14  Tom Tromey  <tom@tromey.com>
5528
5529         * configure: Rebuild.
5530         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5531
5532 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5533
5534         * skip.c (skip_function_command): Make skip w/o arguments use the
5535         name of the inlined function if pc is inside any inlined function.
5536
5537 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5538
5539         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5540         * infrun.c (resume_1): Likewise.
5541         (handle_inferior_event): Remove stale comment.
5542         * linux-nat.c (linux_nat_target::resume): Update comments.
5543         (save_stop_reason): Likewise.
5544         (linux_nat_filter_event): Likewise.
5545         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5546
5547 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * elfread.c (record_minimal_symbol): Set section index to 0 for
5550         non-allocatable sections.
5551
5552
5553 2020-01-13  Ali Tamur <tamur@google.com>
5554
5555         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5556         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5557         to gdb::optional.  Update comments.
5558         (dwo_file): Update comments.
5559         (read_attribute): Update API to take an additional out parameter,
5560         need_reprocess.  This is used to mark attributes that need other
5561         attributes (e.g. str_offsets_base) for correct computation which may not
5562         have been read yet.
5563         (read_attribute_reprocess): New function declaration.
5564         (read_addr_index): Likewise.
5565         (read_dwo_str_index): Likewise.
5566         (read_stub_str_index): Likewise.
5567         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5568         (lookup_addr_base): New function definition.
5569         (lookup_ranges_base): Likewise.
5570         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5571         lookup_ranges_base.
5572         (init_cutu_and_read_dies): Update comments.
5573         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5574         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5575         Update comments.
5576         (init_cutu_and_read_dies_simple): Reflect API changes.
5577         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5578         (create_cus_hash_table): Change API to take parent compile unit.
5579         Reflect API changes.
5580         (open_and_init_dwo_file): Reflect API changes.
5581         (dwarf2_get_pc_bounds): Update comments.
5582         (dwarf2_record_block_ranges): Likewise.
5583         (read_full_die_1): Change implementation to reprocess attributes that
5584         need str_offsets_base and addr_base.
5585         (partial_die_info::read): Likewise.
5586         (read_attribute_reprocess): New function definition.
5587         (read_attribute_value): Change API to take an additional out parameter,
5588         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5589         when a non-dwo compile unit has index based attributes.
5590         (read_attribute): Reflect API changes.
5591         (read_addr_index_1): Reflect API changes.  Update comments.
5592         (dwarf2_read_addr_index_data): Reflect API changes.
5593         (dwarf2_read_addr_index): Likewise.
5594         (read_str_index): Change API and implementation.  This becomes a helper
5595         to be used by the new string index related methods.  Update error
5596         message and comments.
5597         (read_dwo_str_index): New function definition.
5598         (read_stub_str_index): Likewise.
5599         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5600         * symfile.h (dwarf2_debug_sections): Likewise.
5601         * xcoffread.c (dwarf2_debug_sections): Likewise.
5602
5603 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5604
5605         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5606         core_reg_sect type to gdb_byte *.
5607         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5608         * cris-tdep.c (fetch_core_registers): Likewise.
5609         * corelow.c (core_target::get_core_register_section): Change
5610         type of `contents` to gdb::byte_vector.
5611
5612 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5613
5614         * tui/tui-wingeneral.c (box_win): Position the title in the center
5615         of the border.
5616
5617 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5618
5619         * corelow.c (core_target::get_core_register_section): Use
5620           std::vector instead of alloca.
5621
5622 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5623
5624         * warning.m4: Add -Wmissing-declarations to build_warnings.
5625         * configure: Re-generate.
5626
5627 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5628
5629         * python/python.c (init__gdb_module): Add declaration.
5630
5631 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5632
5633         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5634         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5635         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5636         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5637         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5638         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5639         * ada-exp.y (_initialize_ada_exp): Add declaration.
5640         * ada-lang.c (_initialize_ada_language): Add declaration.
5641         * ada-tasks.c (_initialize_tasks): Add declaration.
5642         * agent.c (_initialize_agent): Add declaration.
5643         * aix-thread.c (_initialize_aix_thread): Add declaration.
5644         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5645         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5646         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5647         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5648         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5649         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5650         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5651         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5652         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5653         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5654         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5655         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5656         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5657         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5658         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5659         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5660         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5661         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5662         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5663         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5664         * annotate.c (_initialize_annotate): Add declaration.
5665         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5666         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5667         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5668         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5669         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5670         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5671         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5672         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5673         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5674         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5675         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5676         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5677         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5678         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5679         * auto-load.c (_initialize_auto_load): Add declaration.
5680         * auxv.c (_initialize_auxv): Add declaration.
5681         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5682         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5683         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5684         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5685         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5686         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5687         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5688         * breakpoint.c (_initialize_breakpoint): Add declaration.
5689         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5690         * btrace.c (_initialize_btrace): Add declaration.
5691         * charset.c (_initialize_charset): Add declaration.
5692         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5693         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5694         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5695         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5696         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5697         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5698         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5699         * coffread.c (_initialize_coffread): Add declaration.
5700         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5701         * compile/compile.c (_initialize_compile): Add declaration.
5702         * complaints.c (_initialize_complaints): Add declaration.
5703         * completer.c (_initialize_completer): Add declaration.
5704         * copying.c (_initialize_copying): Add declaration.
5705         * corefile.c (_initialize_core): Add declaration.
5706         * corelow.c (_initialize_corelow): Add declaration.
5707         * cp-abi.c (_initialize_cp_abi): Add declaration.
5708         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5709         * cp-support.c (_initialize_cp_support): Add declaration.
5710         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5711         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5712         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5713         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5714         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5715         * ctfread.c (_initialize_ctfread): Add declaration.
5716         * d-lang.c (_initialize_d_language): Add declaration.
5717         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5718         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5719         * dbxread.c (_initialize_dbxread): Add declaration.
5720         * dcache.c (_initialize_dcache): Add declaration.
5721         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5722         * disasm.c (_initialize_disasm): Add declaration.
5723         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5724         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5725         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5726         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5727         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5728         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5729         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5730         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5731         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5732         * elfread.c (_initialize_elfread): Add declaration.
5733         * exec.c (_initialize_exec): Add declaration.
5734         * extension.c (_initialize_extension): Add declaration.
5735         * f-lang.c (_initialize_f_language): Add declaration.
5736         * f-valprint.c (_initialize_f_valprint): Add declaration.
5737         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5738         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5739         * filesystem.c (_initialize_filesystem): Add declaration.
5740         * findcmd.c (_initialize_mem_search): Add declaration.
5741         * findvar.c (_initialize_findvar): Add declaration.
5742         * fork-child.c (_initialize_fork_child): Add declaration.
5743         * frame-base.c (_initialize_frame_base): Add declaration.
5744         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5745         * frame.c (_initialize_frame): Add declaration.
5746         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5747         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5748         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5749         * gcore.c (_initialize_gcore): Add declaration.
5750         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5751         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5752         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5753         * gdbarch.c (_initialize_gdbarch): Add declaration.
5754         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5755         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5756         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5757         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5758         * go-lang.c (_initialize_go_language): Add declaration.
5759         * go32-nat.c (_initialize_go32_nat): Add declaration.
5760         * guile/guile.c (_initialize_guile): Add declaration.
5761         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5762         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5763         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5764         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5765         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5766         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5767         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5768         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5769         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5770         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5771         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5772         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5773         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5774         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5775         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5776         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5777         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5778         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5779         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5780         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5781         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5782         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5783         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5784         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5785         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5786         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5787         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5788         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5789         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5790         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5791         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5792         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5793         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5794         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5795         * infcall.c (_initialize_infcall): Add declaration.
5796         * infcmd.c (_initialize_infcmd): Add declaration.
5797         * inflow.c (_initialize_inflow): Add declaration.
5798         * infrun.c (_initialize_infrun): Add declaration.
5799         * interps.c (_initialize_interpreter): Add declaration.
5800         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5801         * jit.c (_initialize_jit): Add declaration.
5802         * language.c (_initialize_language): Add declaration.
5803         * linux-fork.c (_initialize_linux_fork): Add declaration.
5804         * linux-nat.c (_initialize_linux_nat): Add declaration.
5805         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5806         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5807         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5808         * m2-lang.c (_initialize_m2_language): Add declaration.
5809         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5810         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5811         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5812         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5813         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5814         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5815         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5816         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5817         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5818         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5819         * machoread.c (_initialize_machoread): Add declaration.
5820         * macrocmd.c (_initialize_macrocmd): Add declaration.
5821         * macroscope.c (_initialize_macroscope): Add declaration.
5822         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5823         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5824         * maint.c (_initialize_maint_cmds): Add declaration.
5825         * mdebugread.c (_initialize_mdebugread): Add declaration.
5826         * memattr.c (_initialize_mem): Add declaration.
5827         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5828         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5829         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5830         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5831         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5832         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5833         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5834         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5835         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5836         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5837         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5838         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5839         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5840         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5841         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5842         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5843         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5844         * mipsread.c (_initialize_mipsread): Add declaration.
5845         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5846         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5847         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5848         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5849         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5850         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5851         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5852         * nto-procfs.c (_initialize_procfs): Add declaration.
5853         * objc-lang.c (_initialize_objc_language): Add declaration.
5854         * observable.c (_initialize_observer): Add declaration.
5855         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5856         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5857         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5858         * osabi.c (_initialize_gdb_osabi): Add declaration.
5859         * osdata.c (_initialize_osdata): Add declaration.
5860         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5861         * parse.c (_initialize_parse): Add declaration.
5862         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5863         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5864         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5865         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5866         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5867         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5868         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5869         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5870         * printcmd.c (_initialize_printcmd): Add declaration.
5871         * probe.c (_initialize_probe): Add declaration.
5872         * proc-api.c (_initialize_proc_api): Add declaration.
5873         * proc-events.c (_initialize_proc_events): Add declaration.
5874         * proc-service.c (_initialize_proc_service): Add declaration.
5875         * procfs.c (_initialize_procfs): Add declaration.
5876         * producer.c (_initialize_producer): Add declaration.
5877         * psymtab.c (_initialize_psymtab): Add declaration.
5878         * python/python.c (_initialize_python): Add declaration.
5879         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5880         * record-btrace.c (_initialize_record_btrace): Add declaration.
5881         * record-full.c (_initialize_record_full): Add declaration.
5882         * record.c (_initialize_record): Add declaration.
5883         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5884         * regcache.c (_initialize_regcache): Add declaration.
5885         * reggroups.c (_initialize_reggroup): Add declaration.
5886         * remote-notif.c (_initialize_notif): Add declaration.
5887         * remote-sim.c (_initialize_remote_sim): Add declaration.
5888         * remote.c (_initialize_remote): Add declaration.
5889         * reverse.c (_initialize_reverse): Add declaration.
5890         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5891         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5892         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5893         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5894         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5895         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5896         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5897         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5898         Add declaration.
5899         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5900         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5901         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5902         * rust-exp.y (_initialize_rust_exp): Add declaration.
5903         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5904         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5905         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5906         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5907         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5908         * score-tdep.c (_initialize_score_tdep): Add declaration.
5909         * ser-go32.c (_initialize_ser_dos): Add declaration.
5910         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5911         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5912         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5913         * ser-uds.c (_initialize_ser_socket): Add declaration.
5914         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5915         * serial.c (_initialize_serial): Add declaration.
5916         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5917         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5918         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5919         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5920         * skip.c (_initialize_step_skip): Add declaration.
5921         * sol-thread.c (_initialize_sol_thread): Add declaration.
5922         * solib-aix.c (_initialize_solib_aix): Add declaration.
5923         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5924         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5925         * solib-frv.c (_initialize_frv_solib): Add declaration.
5926         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5927         * solib-target.c (_initialize_solib_target): Add declaration.
5928         * solib.c (_initialize_solib): Add declaration.
5929         * source-cache.c (_initialize_source_cache): Add declaration.
5930         * source.c (_initialize_source): Add declaration.
5931         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5932         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5933         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5934         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5935         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5936         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5937         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5938         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5939         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5940         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5941         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5942         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5943         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5944         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5945         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5946         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5947         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5948         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5949         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5950         * stabsread.c (_initialize_stabsread): Add declaration.
5951         * stack.c (_initialize_stack): Add declaration.
5952         * stap-probe.c (_initialize_stap_probe): Add declaration.
5953         * std-regs.c (_initialize_frame_reg): Add declaration.
5954         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5955         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5956         * symfile.c (_initialize_symfile): Add declaration.
5957         * symmisc.c (_initialize_symmisc): Add declaration.
5958         * symtab.c (_initialize_symtab): Add declaration.
5959         * target.c (_initialize_target): Add declaration.
5960         * target-connection.c (_initialize_target_connection): Add
5961         declaration.
5962         * target-dcache.c (_initialize_target_dcache): Add declaration.
5963         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5964         * thread.c (_initialize_thread): Add declaration.
5965         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5966         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5967         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5968         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5969         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5970         * tracectf.c (_initialize_ctf): Add declaration.
5971         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5972         * tracefile.c (_initialize_tracefile): Add declaration.
5973         * tracepoint.c (_initialize_tracepoint): Add declaration.
5974         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5975         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5976         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5977         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5978         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5979         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5980         * tui/tui.c (_initialize_tui): Add declaration.
5981         * typeprint.c (_initialize_typeprint): Add declaration.
5982         * ui-style.c (_initialize_ui_style): Add declaration.
5983         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5984         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5985         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5986         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5987         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5988         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5989         * unittests/filtered_iterator-selftests.c
5990         (_initialize_filtered_iterator_selftests): Add declaration.
5991         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5992         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5993         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5994         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5995         * unittests/main-thread-selftests.c
5996         (_initialize_main_thread_selftests): Add declaration.
5997         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5998         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5999         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6000         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6001         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6002         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6003         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6004         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6005         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6006         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6007         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6008         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6009         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6010         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6011         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6012         declaration.
6013         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6014         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6015         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6016         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6017         * user-regs.c (_initialize_user_regs): Add declaration.
6018         * utils.c (_initialize_utils): Add declaration.
6019         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6020         * valops.c (_initialize_valops): Add declaration.
6021         * valprint.c (_initialize_valprint): Add declaration.
6022         * value.c (_initialize_values): Add declaration.
6023         * varobj.c (_initialize_varobj): Add declaration.
6024         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6025         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6026         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6027         * windows-nat.c (_initialize_windows_nat): Add declaration.
6028         (_initialize_check_for_gdb_ini): Add declaration.
6029         (_initialize_loadable): Add declaration.
6030         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6031         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6032         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6033         * xcoffread.c (_initialize_xcoffread): Add declaration.
6034         * xml-support.c (_initialize_xml_support): Add declaration.
6035         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6036         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6037         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6038         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6039
6040 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6041
6042         * regformats/regdat.sh: Generate declaration for init function.
6043
6044 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6045
6046         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6047         up.
6048         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6049         close_one_inferior>: New methods.
6050         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6051         pass down target to find_inferior_pid.
6052         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6053         Pass down target to find_inferior_ptid.
6054         (gdbsim_target::create_inferior): Pass down target to
6055         add_thread_silent.
6056         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6057         target down to find_inferior_ptid and switch_to_thread.
6058         (gdbsim_target::close): Update to call close_one_inferior.
6059         (struct resume_data): Remove.
6060         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6061         directly, rather than through a void pointer.
6062         (gdbsim_target::resume): Update to call resume_one_inferior.
6063
6064 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6065
6066         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6067
6068 2020-01-12  Pedro Alves  <palves@redhat.com>
6069
6070         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6071         directly for the current inferior instead of
6072         discard_all_inferiors.
6073         (discard_all_inferiors): Delete.
6074
6075 2020-01-11  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6078         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6079         deprecated_safe_get_selected_frame.
6080
6081 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6082
6083         * inferior.c (print_inferior): Switch inferior before printing it.
6084
6085 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6086             Pedro Alves  <palves@redhat.com>
6087
6088         * progspace-and-thread.c (switch_to_program_space_and_thread):
6089         Assert there's an inferior for PSPACE.  Use
6090         switch_to_inferior_no_thread to switch the inferior too.
6091         * progspace.c (program_space::~program_space): Call
6092         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6093         (program_space::free_all_objfiles): Don't call clear_symtab_users
6094         here.
6095         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6096
6097 2020-01-10  Pedro Alves  <palves@redhat.com>
6098
6099         * NEWS: Mention multi-target debugging, "info connections", and
6100         "add-inferior -no-connection".
6101
6102 2020-01-10  Pedro Alves  <palves@redhat.com>
6103
6104         * infrun.c: Include "target-connection.h".
6105         (check_multi_target_resumption): New.
6106         (proceed): Call it.
6107         * target-connection.c (make_target_connection_string): Make
6108         extern.
6109         * target-connection.h (make_target_connection_string): Declare.
6110
6111 2020-01-10  Pedro Alves  <palves@redhat.com>
6112
6113         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6114         * inferior.c (uiout_field_connection): New function.
6115         (print_inferior): Add new "connection-id" column.
6116         (add_inferior_command): Show connection number/string of added
6117         inferior.
6118         * process-stratum-target.h
6119         (process_stratum_target::connection_string): New virtual method.
6120         (process_stratum_target::connection_number): New field.
6121         * remote.c (remote_target::connection_string): New override.
6122         * target-connection.c: New file.
6123         * target-connection.h: New file.
6124         * target.c (decref_target): Remove process_stratum targets from
6125         the connection list.
6126         (target_stack::push): Add process_stratum targets to the
6127         connection list.
6128
6129 2020-01-10  Pedro Alves  <palves@redhat.com>
6130
6131         Revert:
6132         2016-04-12  Pedro Alves  <palves@redhat.com>
6133         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6134         Remove references to name.
6135         * serial.h (struct serial) <name>: Delete.
6136
6137 2020-01-10  Pedro Alves  <palves@redhat.com>
6138
6139         * gdbarch-selftests.c (register_to_value_test): Remove "target
6140         already pushed" check.
6141
6142 2020-01-10  Pedro Alves  <palves@redhat.com>
6143             John Baldwin  <jhb@FreeBSD.org>
6144
6145         * aarch64-linux-nat.c
6146         (aarch64_linux_nat_target::thread_architecture): Adjust.
6147         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6148         (task_command_1): Likewise.
6149         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6150         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6151         (aix_thread_target::store_registers)
6152         (aix_thread_target::thread_alive): Adjust.
6153         * amd64-fbsd-tdep.c: Include "inferior.h".
6154         (amd64fbsd_get_thread_local_address): Pass down target.
6155         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6156         thread's gdbarch instead of target_gdbarch.
6157         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6158         get_last_target_status.
6159         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6160         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6161         inferiors.
6162         (update_inserted_breakpoint_locations): Skip if inferiors with no
6163         execution.
6164         (update_global_location_list): When handling moribund locations,
6165         find representative inferior for location's pspace, and use thread
6166         count of its process_stratum target.
6167         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6168         * bsd-uthread.c (bsd_uthread_target::wait): Use
6169         as_process_stratum_target and adjust thread_change_ptid and
6170         add_thread calls.
6171         (bsd_uthread_target::update_thread_list): Use
6172         as_process_stratum_target and adjust find_thread_ptid,
6173         thread_change_ptid and add_thread calls.
6174         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6175         find_thread_ptid call.
6176         * corelow.c (add_to_thread_list): Adjust add_thread call.
6177         (core_target_open): Adjust add_thread_silent and thread_count
6178         calls.
6179         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6180         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6181         * event-top.c (async_disconnect): Pop targets from all inferiors.
6182         * exec.c (add_target_sections): Push exec target on all inferiors
6183         sharing the program space.
6184         (remove_target_sections): Remove the exec target from all
6185         inferiors sharing the program space.
6186         (exec_on_vfork): New.
6187         * exec.h (exec_on_vfork): Declare.
6188         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6189         Pass it down.
6190         (fbsd_nat_target::update_thread_list): Adjust.
6191         (fbsd_nat_target::resume): Adjust.
6192         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6193         down.
6194         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6195         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6196         get_thread_arch_regcache call.
6197         * fork-child.c (gdb_startup_inferior): Pass target down to
6198         startup_inferior and set_executing.
6199         * gdbthread.h (struct process_stratum_target): Forward declare.
6200         (add_thread, add_thread_silent, add_thread_with_info)
6201         (in_thread_list): Add process_stratum_target parameter.
6202         (find_thread_ptid(inferior*, ptid_t)): New overload.
6203         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6204         parameter.
6205         (all_threads()): Delete overload.
6206         (all_threads, all_non_exited_threads): Add process_stratum_target
6207         parameter.
6208         (all_threads_safe): Use brace initialization.
6209         (thread_count): Add process_stratum_target parameter.
6210         (set_resumed, set_running, set_stop_requested, set_executing)
6211         (threads_are_executing, finish_thread_state): Add
6212         process_stratum_target parameter.
6213         (switch_to_thread): Use is_current_thread.
6214         * i386-fbsd-tdep.c: Include "inferior.h".
6215         (i386fbsd_get_thread_local_address): Pass down target.
6216         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6217         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6218         have_inferiors check.
6219         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6220         (inf_ptrace_target::attach): Adjust.
6221         * infcall.c (run_inferior_call): Adjust.
6222         * infcmd.c (run_command_1): Pass target to
6223         scoped_finish_thread_state.
6224         (proceed_thread_callback): Skip inferiors with no execution.
6225         (continue_command): Rename 'all_threads' local to avoid hiding
6226         'all_threads' function.  Adjust get_last_target_status call.
6227         (prepare_one_step): Adjust set_running call.
6228         (signal_command): Use user_visible_resume_target.  Compare thread
6229         pointers instead of inferior_ptid.
6230         (info_program_command): Adjust to pass down target.
6231         (attach_command): Mark target's 'thread_executing' flag.
6232         (stop_current_target_threads_ns): New, factored out from ...
6233         (interrupt_target_1): ... this.  Switch inferior before making
6234         target calls.
6235         * inferior-iter.h
6236         (struct all_inferiors_iterator, struct all_inferiors_range)
6237         (struct all_inferiors_safe_range)
6238         (struct all_non_exited_inferiors_range): Filter on
6239         process_stratum_target too.  Remove explicit.
6240         * inferior.c (inferior::inferior): Push dummy target on target
6241         stack.
6242         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6243         Add process_stratum_target parameter, and pass it down.
6244         (have_live_inferiors): Adjust.
6245         (switch_to_inferior_and_push_target): New.
6246         (add_inferior_command, clone_inferior_command): Handle
6247         "-no-connection" parameter.  Use
6248         switch_to_inferior_and_push_target.
6249         (_initialize_inferior): Mention "-no-connection" option in
6250         the help of "add-inferior" and "clone-inferior" commands.
6251         * inferior.h: Include "process-stratum-target.h".
6252         (interrupt_target_1): Use bool.
6253         (struct inferior) <push_target, unpush_target, target_is_pushed,
6254         find_target_beneath, top_target, process_target, target_at,
6255         m_stack>: New.
6256         (discard_all_inferiors): Delete.
6257         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6258         (all_inferiors, all_non_exited_inferiors): Add
6259         process_stratum_target parameter.
6260         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6261         (target_last_proc_target): New global.
6262         (follow_fork_inferior): Push target on new inferior.  Pass target
6263         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6264         reference count.
6265         (follow_fork): Adjust get_last_target_status call.  Also consider
6266         target.
6267         (follow_exec): Push target on new inferior.
6268         (struct execution_control_state) <target>: New field.
6269         (user_visible_resume_target): New.
6270         (do_target_resume): Call target_async.
6271         (resume_1): Set target's threads_executing flag.  Consider resume
6272         target.
6273         (commit_resume_all_targets): New.
6274         (proceed): Also consider resume target.  Skip threads of inferiors
6275         with no execution.  Commit resumtion in all targets.
6276         (start_remote): Pass current inferior to wait_for_inferior.
6277         (infrun_thread_stop_requested): Consider target as well.  Pass
6278         thread_info pointer to clear_inline_frame_state instead of ptid.
6279         (infrun_thread_thread_exit): Consider target as well.
6280         (random_pending_event_thread): New inferior parameter.  Use it.
6281         (do_target_wait): Rename to ...
6282         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6283         down.
6284         (threads_are_resumed_pending_p, do_target_wait): New.
6285         (prepare_for_detach): Adjust calls.
6286         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6287         do_target_wait_1 instead of do_target_wait.
6288         (fetch_inferior_event): Adjust.  Switch to representative
6289         inferior.  Pass target down.
6290         (set_last_target_status): Add process_stratum_target parameter.
6291         Save target in global.
6292         (get_last_target_status): Add process_stratum_target parameter and
6293         handle it.
6294         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6295         (context_switch): Check inferior_ptid == null_ptid before calling
6296         inferior_thread().
6297         (get_inferior_stop_soon): Pass down target.
6298         (wait_one): Rename to ...
6299         (poll_one_curr_target): ... this.
6300         (struct wait_one_event): New.
6301         (wait_one): New.
6302         (stop_all_threads): Adjust.
6303         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6304         event's target.
6305         (switch_back_to_stepped_thread): Also consider target.
6306         (print_stop_event): Update.
6307         (normal_stop): Update.  Also consider the resume target.
6308         * infrun.h (wait_for_inferior): Remove declaration.
6309         (user_visible_resume_target): New declaration.
6310         (get_last_target_status, set_last_target_status): New
6311         process_stratum_target parameter.
6312         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6313         process_stratum_target parameter, and use it.
6314         (clear_inline_frame_state (thread_info*)): New.
6315         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6316         process_stratum_target parameter.
6317         (clear_inline_frame_state (thread_info*)): Declare.
6318         * linux-fork.c (delete_checkpoint_command): Pass target down to
6319         find_thread_ptid.
6320         (checkpoint_command): Adjust.
6321         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6322         instead of just tweaking inferior_ptid.
6323         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6324         (exit_lwp): Pass target down to find_thread_ptid.
6325         (attach_proc_task_lwp_callback): Pass target down to
6326         add_thread/set_running/set_executing.
6327         (linux_nat_target::attach): Pass target down to
6328         thread_change_ptid.
6329         (get_detach_signal): Pass target down to find_thread_ptid.
6330         Consider last target status's target.
6331         (linux_resume_one_lwp_throw, resume_lwp)
6332         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6333         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6334         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6335         (linux_nat_target::async_wait_fd): New.
6336         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6337         target down.
6338         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6339         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6340         * linux-thread-db.c (struct thread_db_info::process_target): New
6341         field.
6342         (add_thread_db_info): Save target.
6343         (get_thread_db_info): New process_stratum_target parameter.  Also
6344         match target.
6345         (delete_thread_db_info): New process_stratum_target parameter.
6346         Also match target.
6347         (thread_from_lwp): Adjust to pass down target.
6348         (thread_db_notice_clone): Pass down target.
6349         (check_thread_db_callback): Pass down target.
6350         (try_thread_db_load_1): Always push the thread_db target.
6351         (try_thread_db_load, record_thread): Pass target down.
6352         (thread_db_target::detach): Pass target down.  Always unpush the
6353         thread_db target.
6354         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6355         target down.  Always unpush the thread_db target.
6356         (find_new_threads_callback, thread_db_find_new_threads_2)
6357         (thread_db_target::update_thread_list): Pass target down.
6358         (thread_db_target::pid_to_str): Pass current inferior down.
6359         (thread_db_target::get_thread_local_address): Pass target down.
6360         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6361         target down.
6362         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6363         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6364         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6365         (procfs_init_inferior): Rename to ...
6366         (procfs_target::procfs_init_inferior): ... this and adjust.
6367         (procfs_target::create_inferior, procfs_notice_thread)
6368         (procfs_do_thread_registers): Adjust.
6369         * ppc-fbsd-tdep.c: Include "inferior.h".
6370         (ppcfbsd_get_thread_local_address): Pass down target.
6371         * proc-service.c (ps_xfer_memory): Switch current inferior and
6372         program space as well.
6373         (get_ps_regcache): Pass target down.
6374         * process-stratum-target.c
6375         (process_stratum_target::thread_address_space)
6376         (process_stratum_target::thread_architecture): Pass target down.
6377         * process-stratum-target.h
6378         (process_stratum_target::threads_executing): New field.
6379         (as_process_stratum_target): New.
6380         * ravenscar-thread.c
6381         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6382         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6383         down.
6384         * record-btrace.c (record_btrace_target::info_record): Adjust.
6385         (record_btrace_target::record_method)
6386         (record_btrace_target::record_is_replaying)
6387         (record_btrace_target::fetch_registers)
6388         (get_thread_current_frame_id, record_btrace_target::resume)
6389         (record_btrace_target::wait, record_btrace_target::stop): Pass
6390         target down.
6391         * record-full.c (record_full_wait_1): Switch to event thread.
6392         Pass target down.
6393         * regcache.c (regcache::regcache)
6394         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6395         process_stratum_target parameter and handle it.
6396         (current_thread_target): New global.
6397         (get_thread_regcache): Add process_stratum_target parameter and
6398         handle it.  Switch inferior before calling target method.
6399         (get_thread_regcache): Pass target down.
6400         (get_thread_regcache_for_ptid): Pass target down.
6401         (registers_changed_ptid): Add process_stratum_target parameter and
6402         handle it.
6403         (registers_changed_thread, registers_changed): Pass target down.
6404         (test_get_thread_arch_aspace_regcache): New.
6405         (current_regcache_test): Define a couple local test_target_ops
6406         instances and use them for testing.
6407         (readwrite_regcache): Pass process_stratum_target parameter.
6408         (cooked_read_test, cooked_write_test): Pass mock_target down.
6409         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6410         (get_thread_arch_aspace_regcache): Add process_stratum_target
6411         parameter.
6412         (regcache::target): New method.
6413         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6414         (regcache::registers_changed_ptid): Add process_stratum_target
6415         parameter.
6416         (regcache::m_target): New field.
6417         (registers_changed_ptid): Add process_stratum_target parameter.
6418         * remote.c (remote_state::supports_vCont_probed): New field.
6419         (remote_target::async_wait_fd): New method.
6420         (remote_unpush_and_throw): Add remote_target parameter.
6421         (get_current_remote_target): Adjust.
6422         (remote_target::remote_add_inferior): Push target.
6423         (remote_target::remote_add_thread)
6424         (remote_target::remote_notice_new_inferior)
6425         (get_remote_thread_info): Pass target down.
6426         (remote_target::update_thread_list): Skip threads of inferiors
6427         bound to other targets.  (remote_target::close): Don't discard
6428         inferiors.  (remote_target::add_current_inferior_and_thread)
6429         (remote_target::process_initial_stop_replies)
6430         (remote_target::start_remote)
6431         (remote_target::remote_serial_quit_handler): Pass down target.
6432         (remote_target::remote_unpush_target): New remote_target
6433         parameter.  Unpush the target from all inferiors.
6434         (remote_target::remote_unpush_and_throw): New remote_target
6435         parameter.  Pass it down.
6436         (remote_target::open_1): Check whether the current inferior has
6437         execution instead of checking whether any inferior is live.  Pass
6438         target down.
6439         (remote_target::remote_detach_1): Pass down target.  Use
6440         remote_unpush_target.
6441         (extended_remote_target::attach): Pass down target.
6442         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6443         (remote_target::append_resumption): Pass down target.
6444         (remote_target::append_pending_thread_resumptions)
6445         (remote_target::remote_resume_with_hc, remote_target::resume)
6446         (remote_target::commit_resume): Pass down target.
6447         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6448         (remote_target::interrupt_query)
6449         (remote_target::remove_new_fork_children)
6450         (remote_target::check_pending_events_prevent_wildcard_vcont)
6451         (remote_target::remote_parse_stop_reply)
6452         (remote_target::process_stop_reply): Pass down target.
6453         (first_remote_resumed_thread): New remote_target parameter.  Pass
6454         it down.
6455         (remote_target::wait_as): Pass down target.
6456         (unpush_and_perror): New remote_target parameter.  Pass it down.
6457         (remote_target::readchar, remote_target::remote_serial_write)
6458         (remote_target::getpkt_or_notif_sane_1)
6459         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6460         down target.
6461         (remote_target::mourn_inferior): Pass down target.  Use
6462         remote_unpush_target.
6463         (remote_target::core_of_thread)
6464         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6465         (remote_target::pid_to_exec_file)
6466         (remote_target::thread_handle_to_thread_info): Pass down target.
6467         (remote_target::async_wait_fd): New.
6468         * riscv-fbsd-tdep.c: Include "inferior.h".
6469         (riscv_fbsd_get_thread_local_address): Pass down target.
6470         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6471         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6472         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6473         Adjust.
6474         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6475         * solib-svr4.c (enable_break): Pass down target.
6476         * spu-multiarch.c (parse_spufs_run): Pass down target.
6477         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6478         * target-delegates.c: Regenerate.
6479         * target.c (g_target_stack): Delete.
6480         (current_top_target): Return the current inferior's top target.
6481         (target_has_execution_1): Refer to the passed-in inferior's top
6482         target.
6483         (target_supports_terminal_ours): Check whether the initial
6484         inferior was already created.
6485         (decref_target): New.
6486         (target_stack::push): Incref/decref the target.
6487         (push_target, push_target, unpush_target): Adjust.
6488         (target_stack::unpush): Defref target.
6489         (target_is_pushed): Return bool.  Adjust to refer to the current
6490         inferior's target stack.
6491         (dispose_inferior): Delete, and inline parts ...
6492         (target_preopen): ... here.  Only dispose of the current inferior.
6493         (target_detach): Hold strong target reference while detaching.
6494         Pass target down.
6495         (target_thread_name): Add assertion.
6496         (target_resume): Pass down target.
6497         (target_ops::beneath, find_target_at): Adjust to refer to the
6498         current inferior's target stack.
6499         (get_dummy_target): New.
6500         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6501         has a thread running.
6502         (initialize_targets): Rename to ...
6503         (_initialize_target): ... this.
6504         * target.h: Include "gdbsupport/refcounted-object.h".
6505         (struct target_ops): Inherit refcounted_object.
6506         (target_ops::shortname, target_ops::longname): Make const.
6507         (target_ops::async_wait_fd): New method.
6508         (decref_target): Declare.
6509         (struct target_ops_ref_policy): New.
6510         (target_ops_ref): New typedef.
6511         (get_dummy_target): Declare function.
6512         (target_is_pushed): Return bool.
6513         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6514         (all_matching_threads_iterator::all_matching_threads_iterator):
6515         Handle filter target.
6516         * thread-iter.h (struct all_matching_threads_iterator, struct
6517         all_matching_threads_range, class all_non_exited_threads_range):
6518         Filter by target too.  Remove explicit.
6519         * thread.c (threads_executing): Delete.
6520         (inferior_thread): Pass down current inferior.
6521         (clear_thread_inferior_resources): Pass down thread pointer
6522         instead of ptid_t.
6523         (add_thread_silent, add_thread_with_info, add_thread): Add
6524         process_stratum_target parameter.  Use it for thread and inferior
6525         searches.
6526         (is_current_thread): New.
6527         (thread_info::deletable): Use it.
6528         (find_thread_ptid, thread_count, in_thread_list)
6529         (thread_change_ptid, set_resumed, set_running): New
6530         process_stratum_target parameter.  Pass it down.
6531         (set_executing): New process_stratum_target parameter.  Pass it
6532         down.  Adjust reference to 'threads_executing'.
6533         (threads_are_executing): New process_stratum_target parameter.
6534         Adjust reference to 'threads_executing'.
6535         (set_stop_requested, finish_thread_state): New
6536         process_stratum_target parameter.  Pass it down.
6537         (switch_to_thread): Also match inferior.
6538         (switch_to_thread): New process_stratum_target parameter.  Pass it
6539         down.
6540         (update_threads_executing): Reimplement.
6541         * top.c (quit_force): Pop targets from all inferior.
6542         (gdb_init): Don't call initialize_targets.
6543         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6544         Declare.
6545         (windows_add_thread, windows_delete_thread): Adjust.
6546         (get_windows_debug_event): Rename to ...
6547         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6548         * tracefile-tfile.c (tfile_target_open): Pass down target.
6549         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6550         Forward declare.
6551         (switch_to_thread): Add process_stratum_target parameter.
6552         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6553         parameter.  Use it.
6554         (mi_on_resume): Pass target down.
6555         * nat/fork-inferior.c (startup_inferior): Add
6556         process_stratum_target parameter.  Pass it down.
6557         * nat/fork-inferior.h (startup_inferior): Add
6558         process_stratum_target parameter.
6559         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6560
6561 2020-01-10  Pedro Alves  <palves@redhat.com>
6562
6563         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6564         directly.  Instead find the first thread in the thread list and
6565         use switch_to_thread.
6566
6567 2020-01-10  Pedro Alves  <palves@redhat.com>
6568
6569         * remote.c (remote_target::remote_add_inferior): Don't bind a
6570         process to the current inferior if the current inferior is already
6571         bound to a process.
6572
6573 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6574             Pedro Alves  <palves@redhat.com>
6575
6576         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6577         If no process is specified, return null_ptid instead of
6578         inferior_ptid.
6579         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6580         TARGET_WAITKIND_SIGNALLED with no pid.
6581
6582 2020-01-10  Pedro Alves  <palves@redhat.com>
6583
6584         * remote.c (first_remote_resumed_thread): New.
6585         (remote_target::wait_as): Use it as default event_ptid instead of
6586         inferior_ptid.
6587
6588 2020-01-10  Pedro Alves  <palves@redhat.com>
6589
6590         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6591
6592 2020-01-10  Pedro Alves  <palves@redhat.com>
6593
6594         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6595         not -1.
6596
6597 2020-01-10  Pedro Alves  <palves@redhat.com>
6598
6599         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6600         ptid to get_last_target_status.
6601         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6602         ptid to get_last_target_status.
6603         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6604         get_last_target_status.
6605         (info_program_command): Don't pass a target_waitstatus to
6606         get_last_target_status.
6607         * infrun.c (init_wait_for_inferior): Use
6608         nullify_last_target_wait_ptid.
6609         (get_last_target_status): Handle nullptr arguments.
6610         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6611         (print_stop_event): Don't pass a ptid to get_last_target_status.
6612         (normal_stop): Don't pass a ptid to get_last_target_status.
6613         * infrun.h (get_last_target_status, set_last_target_status): Move
6614         comments here and update.
6615         (nullify_last_target_wait_ptid): Declare.
6616         * linux-fork.c (fork_load_infrun_state): Remove local extern
6617         declaration of nullify_last_target_wait_ptid.
6618         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6619         to get_last_target_status.
6620
6621 2020-01-10  Pedro Alves  <palves@redhat.com>
6622
6623         * gdbthread.h (scoped_restore_current_thread)
6624         <dont_restore, restore, m_dont_restore>: Declare.
6625         * thread.c (thread_alive): Add assertion.  Return bool.
6626         (switch_to_thread_if_alive): New.
6627         (prune_threads): Switch inferior/thread.
6628         (print_thread_info_1): Switch thread before calling target methods.
6629         (scoped_restore_current_thread::restore): New, factored out from
6630         ...
6631         (scoped_restore_current_thread::~scoped_restore_current_thread):
6632         ... this.
6633         (scoped_restore_current_thread::scoped_restore_current_thread):
6634         Add assertion.
6635         (thread_apply_all_command, thread_select): Use
6636         switch_to_thread_if_alive.
6637         * infrun.c (proceed, restart_threads, handle_signal_stop)
6638         (switch_back_to_stepped_thread): Switch current thread before
6639         calling target methods.
6640
6641 2020-01-10  Pedro Alves <palves@redhat.com>
6642
6643         * inferior.c (switch_to_inferior_no_thread): New function,
6644         factored out from ...
6645         (inferior_command): ... here.
6646         * inferior.h (switch_to_inferior_no_thread): Declare.
6647         * mi/mi-main.c (run_one_inferior): Use
6648         switch_to_inferior_no_thread.
6649
6650 2020-01-10  Pedro Alves  <palves@redhat.com>
6651
6652         * infcmd.c (kill_command): Remove dead code.
6653
6654 2020-01-10  Pedro Alves  <palves@redhat.com>
6655
6656         * remote.c (remote_target::mourn_inferior): No longer check
6657         whether the target is running.
6658
6659 2020-01-10  Pedro Alves  <palves@redhat.com>
6660
6661         * corelow.c (core_target::has_execution): Change parameter type to
6662         inferior pointer.
6663         * inferior.c (number_of_live_inferiors): Use
6664         inferior::has_execution instead of target_has_execution_1.
6665         * inferior.h (inferior::has_execution): New.
6666         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6667         inferior::has_execution instead of target_has_execution_1.
6668         * process-stratum-target.c
6669         (process_stratum_target::has_execution): Change parameter type to
6670         inferior pointer.  Check the inferior's PID instead of
6671         inferior_ptid.
6672         * process-stratum-target.h
6673         (process_stratum_target::has_execution): Change parameter type to
6674         inferior pointer.
6675         * record-full.c (record_full_core_target::has_execution): Change
6676         parameter type to inferior pointer.
6677         * target.c (target_has_execution_1): Change parameter type to
6678         inferior pointer.
6679         (target_has_execution_current): Adjust.
6680         * target.h (target_ops::has_execution): Change parameter type to
6681         inferior pointer.
6682         (target_has_execution_1): Change parameter type to inferior
6683         pointer.  Change return type to bool.
6684         * tracefile.h (tracefile_target::has_execution): Change parameter
6685         type to inferior pointer.
6686
6687 2020-01-10  Pedro Alves  <palves@redhat.com>
6688
6689         * exceptions.c (print_flush): Remove current_top_target() check.
6690
6691 2020-01-10  Pedro Alves  <palves@redhat.com>
6692
6693         * remote.c (show_remote_exec_file): Show the current inferior's
6694         exec-file instead of the command variable's value.
6695
6696 2020-01-10  Pedro Alves  <palves@redhat.com>
6697
6698         * record-full.c (record_full_resume_ptid): New global.
6699         (record_full_target::resume): Set it.
6700         (record_full_wait_1): Use record_full_resume_ptid instead of
6701         inferior_ptid.
6702
6703 2020-01-10  Pedro Alves  <palves@redhat.com>
6704
6705         * gdbthread.h (scoped_restore_current_thread)
6706         <dont_restore, restore, m_dont_restore>: Declare.
6707         * thread.c (thread_alive): Add assertion.  Return bool.
6708         (switch_to_thread_if_alive): New.
6709         (prune_threads): Switch inferior/thread.
6710         (print_thread_info_1): Switch thread before calling target methods.
6711         (scoped_restore_current_thread::restore): New, factored out from
6712         ...
6713         (scoped_restore_current_thread::~scoped_restore_current_thread):
6714         ... this.
6715         (scoped_restore_current_thread::scoped_restore_current_thread):
6716         Add assertion.
6717         (thread_apply_all_command, thread_select): Use
6718         switch_to_thread_if_alive.
6719
6720 2020-01-10  George Barrett  <bob@bob131.so>
6721
6722         * stap-probe.c (stap_modify_semaphore): Don't check for null
6723         semaphores.
6724         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6725         for null semaphores.
6726
6727 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6728
6729         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6730         all source windows, and maintain horizontal scroll status while
6731         doing so.
6732
6733 2020-01-09  Tom Tromey  <tom@tromey.com>
6734
6735         PR tui/18932:
6736         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6737         update_source_window, not print_source_lines.
6738
6739 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6740
6741         * tui/tui.c (tui_enable): Register tui hooks after calling
6742         tui_display_main.
6743
6744 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6745
6746         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6747
6748 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6749
6750         * thread.c (print_thread_info_1): Fix indentation.
6751
6752 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6753
6754         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6755         unique_xmalloc_ptr outside the if to always free the demangled name.
6756
6757 2020-01-08  Tom Tromey  <tromey@adacore.com>
6758
6759         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6760         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6761         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6762         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6763         Remove.
6764         (section_offsets): New typedef.
6765         * symtab.c (fixup_section, get_msymbol_address): Update.
6766         * symmisc.c (dump_msymbols): Update.
6767         * symfile.h (relative_addr_info_to_section_offsets)
6768         (symfile_map_offsets_to_segments): Update.
6769         * symfile.c (build_section_addr_info_from_objfile)
6770         (init_objfile_sect_indices): Update.
6771         (struct place_section_arg): Change type of "offsets".
6772         (place_section): Update.
6773         (relative_addr_info_to_section_offsets): Change type of
6774         "section_offsets".  Remove "num_sections" parameter.
6775         (default_symfile_offsets, syms_from_objfile_1)
6776         (set_objfile_default_section_offset): Update.
6777         (reread_symbols): No need to preserve section offsets by hand.
6778         (symfile_map_offsets_to_segments): Change type of "offsets".
6779         * stap-probe.c (relocate_address): Update.
6780         * stabsread.h (process_one_symbol): Update.
6781         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6782         (solib_target_relocate_section_addresses): Update.
6783         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6784         Update.
6785         * solib-frv.c (frv_relocate_main_executable): Update.
6786         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6787         * solib-aix.c (solib_aix_get_section_offsets): Change return
6788         type.
6789         (solib_aix_solib_create_inferior_hook): Update.
6790         * remote.c (remote_target::get_offsets): Update.
6791         * psymtab.c (find_pc_sect_psymtab): Update.
6792         * psympriv.h (struct partial_symbol) <address, text_low,
6793         text_high>: Update.
6794         * objfiles.h (obj_section_offset): Update.
6795         (struct objfile) <section_offsets>: Change type.
6796         <num_sections>: Remove.
6797         (objfile_relocate): Update.
6798         * objfiles.c (entry_point_address_query): Update
6799         (relocate_one_symbol): Change type of "section_offsets".
6800         (objfile_relocate1, objfile_relocate1): Change type of
6801         "new_offsets".
6802         (objfile_rebase1): Update.
6803         * mipsread.c (mipscoff_symfile_read): Update.
6804         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6805         parameter.
6806         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6807         (parse_external, psymtab_to_symtab_1): Update.
6808         * machoread.c (macho_symfile_offsets): Update.
6809         * ia64-tdep.c (ia64_find_unwind_table): Update.
6810         * hppa-tdep.c (read_unwind_info): Update.
6811         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6812         * dwarf2read.c (create_addrmap_from_index)
6813         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6814         (process_psymtab_comp_unit_reader, add_partial_symbol)
6815         (add_partial_subprogram, process_full_comp_unit)
6816         (read_file_scope, read_func_scope, read_lexical_block_scope)
6817         (read_call_site_scope, dwarf2_rnglists_process)
6818         (dwarf2_ranges_process, dwarf2_ranges_read)
6819         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6820         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6821         Update.
6822         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6823         Update.
6824         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6825         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6826         (process_one_symbol): Change type of "section_offsets".
6827         * ctfread.c (get_objfile_text_range): Update.
6828         * coffread.c (coff_symtab_read, enter_linenos)
6829         (process_coff_symbol): Update.
6830         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6831         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6832
6833 2020-01-08  Tom Tromey  <tromey@adacore.com>
6834
6835         * dwarf2read.c (parse_macro_definition): Use std::string.
6836         (parse_macro_definition): Likewise.
6837
6838 2020-01-08  Tom Tromey  <tromey@adacore.com>
6839
6840         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6841         (ATTR_ALLOC_CHUNK): Remove.
6842
6843 2020-01-08  Tom Tromey  <tromey@adacore.com>
6844
6845         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6846
6847 2020-01-08  Tom Tromey  <tromey@adacore.com>
6848
6849         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6850         (dwarf2_compute_name, open_dwo_file): Likewise.
6851         (process_enumeration_scope): Use std::vector.
6852         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6853         (partial_die_info::fixup, dwarf2_start_subfile)
6854         (guess_full_die_structure_name, dwarf2_name): Likewise.
6855         (determine_prefix): Update.
6856         (guess_full_die_structure_name): Make return type const.
6857         (partial_die_full_name): Return unique_xmalloc_ptr.
6858         (DW_FIELD_ALLOC_CHUNK): Remove.
6859
6860 2020-01-07  Tom Tromey  <tromey@adacore.com>
6861
6862         PR build/24937:
6863         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6864
6865 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6866
6867         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6868
6869 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * stack.c (print_frame_info): Move disassemble_next_line code
6872         inside source_print block.
6873
6874 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6875
6876         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6877         gdb/signals.h, as we are now using native signal symbols.
6878
6879 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6880
6881         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6882         overflow by an early check of content vs threshold.
6883         * tui/tui-source.c (tui_source_window::line_is_displayed):
6884         Likewise.
6885
6886 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6887
6888         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6889
6890 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6891
6892         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6893         export table if no section contains it's RVA.
6894
6895 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6896
6897         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6898
6899 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6900
6901         * source.c (print_source_lines_base): Set last_line_listed.
6902
6903 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6904
6905         * tui/tui-disasm.c: Remove trailing spaces.
6906
6907 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6908             Pedro Alves  <palves@redhat.com>
6909
6910         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6911         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6912         (windows_gdb_signal_to_target): New function, uses the above
6913         enumeration to convert GDB internal signal codes to equivalent
6914         Windows codes.
6915         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6916         * windows-nat.c: Include "gdb_wait.h".
6917         (get_windows_debug_event): Extract the fatal exception from the
6918         exit status and convert to the equivalent Posix signal number.
6919         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6920         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6921         * gdbsupport/gdb_wait.c: New file, implements
6922         windows_status_to_termsig.
6923         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6924         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6925
6926 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6927
6928         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6929         show_layout.
6930
6931 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6932
6933         * aarch64-linux-nat.c
6934         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6935         and bfd_mach_aarch64.
6936
6937 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6938
6939         * ui-file.c (stdio_file::can_emit_style_escape)
6940         (tee_file::can_emit_style_escape): Ensure style is used also on
6941         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6942         to gdb_stdout.
6943         * main.c (set_gdb_data_directory): Use file style to output the
6944         warning that the given pathname is not a directory.
6945         * top.c (show_history_filename, gdb_safe_append_history)
6946         (show_gdb_datadir): Use file style.
6947
6948 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6949
6950         * solib-target.c (struct lm_info_target):
6951         Change offsets to be a unique_xmalloc_ptr.
6952         (solib_target_relocate_section_addresses): Update.
6953
6954 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6955
6956         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6957
6958 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6959
6960         * MAINTAINERS (Write After Approval): Add myself.
6961
6962 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6963
6964         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6965         Cell BE architecture.
6966         * target.h (struct target_ops) <thread_architecture>: Likewise.
6967
6968 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6969
6970         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6971
6972 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6973
6974         * MAINTAINERS (Write After Approval): Add myself.
6975
6976 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6977
6978         * gdbarch.sh: Update copyright year range of generated files.
6979
6980 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6981
6982         Update copyright year range in all GDB files.
6983
6984 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6985
6986         * copyright.py: Convert to Python 3.
6987
6988 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6989
6990         * copyright.py: Adapt after move of gnulib directory from gdb
6991         directory to toplevel directory.
6992
6993 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6994
6995         * copyright.py (main): Exit if run from the wrong directory.
6996
6997 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6998
6999         * top.c (print_gdb_version): Change copyright year to 2020.
7000
7001 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7002
7003         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7004
7005 For older changes see ChangeLog-2019.
7006 \f
7007 Local Variables:
7008 mode: change-log
7009 left-margin: 8
7010 fill-column: 74
7011 version-control: never
7012 coding: utf-8
7013 End: