gdb/ChangeLog

   1 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   2
   3         * language.h (struct language_pass_by_ref_info): New struct.
   4         (struct language_defn)<la_pass_by_reference>: Change the signature
   5         to return a language_pass_by_ref_info instead of an int.
   6         (language_pass_by_reference): Ditto.
   7         (default_pass_by_reference): Ditto.
   8         Adjust the users listed below.
   9         * arch-utils.c (default_return_in_first_hidden_param_p):
  10         Update.
  11         * cp-abi.c (cp_pass_by_reference): Update.
  12         * cp-abi.h (cp_pass_by_reference): Update declaration.
  13         (struct cp_abi_ops)<pass_by_reference>: Update.
  14         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
  15         * infcall.c (call_function_by_hand_dummy): Update.
  16         * language.c (language_pass_by_reference): Update.
  17         (default_pass_by_reference): Update.
  18         * tic6x-tdep.c (tic6x_return_value): Update.
  19
  20 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  21
  22         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
  23         and DW_AT_deleted attributes of a function.
  24         (read_structure_type): Read the DW_AT_calling_convention attribute
  25         of a type.
  26         (is_valid_DW_AT_defaulted): New function.
  27         (is_valid_DW_AT_calling_convention_for_type): New function.
  28         * gdbtypes.h: Include dwarf2.h.
  29         (struct fn_field)<defaulted>: New field to store the
  30         DW_AT_defaulted attribute.
  31         (struct fn_field)<is_deleted>: New field to store the
  32         DW_AT_deleted attribute.
  33         (struct cplus_struct_type)<calling_convention>: New field to store
  34         the DW_AT_calling_convention attribute.
  35         (TYPE_FN_FIELD_DEFAULTED): New macro.
  36         (TYPE_FN_FIELD_DELETED): New macro.
  37         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
  38         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
  39         to the .h file.
  40         (print_cplus_stuff): Likewise.
  41
  42 2019-12-20  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui.c (tui_show_source): Remove.
  45         * tui/tui.h (tui_show_source): Don't declare.
  46         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
  47         tui_show_source.
  48
  49 2019-12-20  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-stack.h (tui_show_frame_info): Return bool.
  52         * tui/tui-stack.c (tui_show_frame_info): Return bool.
  53         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  54         Update.
  55
  56 2019-12-20  Tom Tromey  <tom@tromey.com>
  57
  58         PR tui/18932:
  59         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  60         Rename parameters.  Handle the not-from-stack-frame case.
  61         (from_stack, from_source_symtab): New globals.
  62         (tui_before_prompt, tui_normal_stop): Update.
  63         (tui_context_changed, tui_symtab_changed): New functions.
  64         (tui_attach_detach_observers): Attach new observers.
  65
  66 2019-12-20  Tom Tromey  <tom@tromey.com>
  67
  68         * source.c (struct current_source_location) <set, symtab, line>:
  69         New methods.
  70         <m_symtab, m_line>: Rename.  Now private.
  71         (get_current_source_symtab_and_line)
  72         (set_default_source_symtab_and_line)
  73         (set_current_source_symtab_and_line)
  74         (clear_current_source_symtab_and_line, select_source_symtab)
  75         (info_source_command, print_source_lines_base)
  76         (info_line_command, search_command_helper): Update.
  77         * observable.h (current_source_symtab_and_line_changed): Declare
  78         observable.
  79         * observable.c (current_source_symtab_and_line_changed): Define
  80         observable.
  81
  82 2019-12-20  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
  85         (tui_before_prompt, tui_normal_stop): Update.
  86
  87 2019-12-20  Tom Tromey  <tom@tromey.com>
  88
  89         * tui/tui-winsource.c
  90         (tui_source_window_base::update_source_window_as_is): Don't call
  91         set_current_source_symtab_and_line.
  92
  93 2019-12-20  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
  96         Take a symtab_and_line.
  97         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
  98         symtab_and_line.
  99         (tui_show_frame_info): Update.
 100
 101 2019-12-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-stack.c (tui_show_frame_info): Don't call
 104         update_exec_info.
 105
 106 2019-12-20  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui.c (tui_enable): Call tui_display_main.
 109
 110 2019-12-20  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
 113         get_current_source_symtab_and_line, and main_name.
 114
 115 2019-12-20  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui.c (tui_show_source): Update.
 118         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
 119         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
 120         a symtab_symbol_info, not a separate symtab and line.  Simplify.
 121
 122 2019-12-20  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
 125         Simplify.
 126
 127 2019-12-20  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.h (struct tui_source_window_base)
 130         <set_contents, update_source_window_as_is, update_source_window>:
 131         Take a sal, not a separate symtab and tui_line_or_address.
 132         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 133         (tui_source_window_base::update_source_window_as_is): Take a sal,
 134         not a separate symtab and tui_line_or_address.
 135         (tui_update_source_windows_with_addr)
 136         (tui_update_source_windows_with_line)
 137         (tui_source_window_base::rerender)
 138         (tui_source_window_base::refill): Update.
 139         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
 140         a sal, not a separate symtab and tui_line_or_address.
 141         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
 142         not a separate symtab and tui_line_or_address.
 143         (tui_source_window::maybe_update): Update.
 144         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
 145         a sal, not a separate symtab and tui_line_or_address.
 146         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
 147         not a separate symtab and tui_line_or_address.
 148         (tui_disasm_window::do_scroll_vertical)
 149         (tui_disasm_window::maybe_update): Update.
 150
 151 2019-12-20  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 154         start_line_or_addr.
 155         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 156         start_line_or_addr.
 157         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 158         start_line_or_addr.
 159
 160 2019-12-20  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-winsource.h (struct tui_source_window_base)
 163         <set_contents>: Return bool.
 164         * tui/tui-winsource.c
 165         (tui_source_window_base::update_source_window_as_is): Update.
 166         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 167         Return bool.
 168         * tui/tui-source.c (tui_source_window::set_contents): Return
 169         bool.  Simplify.
 170         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 171         Return bool.
 172         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 173         bool.
 174
 175 2019-12-20  Tom Tromey  <tom@tromey.com>
 176
 177         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 178         (tui_update_source_windows_with_line): Call update_source_window.
 179         * tui/tui-source.h (struct tui_source_window)
 180         <show_symtab_source>: Don't declare.
 181         * tui/tui-source.c (tui_source_window::show_symtab_source):
 182         Remove.
 183
 184 2019-12-20  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 187         update_source_window directly.
 188         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 189         * tui/tui-disasm.c (tui_show_disassem): Remove.
 190
 191 2019-12-20  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-winsource.c
 194         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 195         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 196
 197 2019-12-20  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-winsource.h (struct tui_source_window_base)
 200         <maybe_update>: Remove line_no and addr parameters.
 201         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 202         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 203         Update.
 204         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 205         line_no and addr parameters.
 206         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 207         Update.
 208         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 209         line_no and addr parameters.
 210
 211 2019-12-20  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 214         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 215
 216 2019-12-20  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 219         tui_show_disassem.
 220         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 221         declare.
 222         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 223
 224 2019-12-20  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui.h (tui_show_source): Remove parameters.
 227         * tui/tui.c (tui_show_source): Remove parameters.
 228         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 229
 230 2019-12-20  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui.c (tui_show_source): Update.
 233         * tui/tui-winsource.c (tui_display_main): Update.
 234         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 235         to symtab.
 236         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 237         to symtab.
 238         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 239
 240 2019-12-20  Tom Tromey  <tom@tromey.com>
 241
 242         PR tui/23619:
 243         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 244         (tui_redisplay_readline): Use rl_display_prompt.
 245         (tui_prep_terminal): Update.
 246
 247 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 248
 249         * configure: Regenerate.
 250         * configure.ac: Quote variable arguments of test.
 251         * gdbsupport/common.m4: Likewise.
 252
 253 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 254
 255         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 256         2 to pow ().
 257
 258 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 259
 260         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 261         log10 to double to fix Solaris 11 with gcc 5.5.
 262
 263 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 264
 265         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 266         "sun" to "saddr_un".
 267
 268 2019-12-19  Tom Tromey  <tromey@adacore.com>
 269
 270         * ui-out.h (enum class field_kind): Fix comment.
 271
 272 2019-12-11  Tom Tromey  <tromey@adacore.com>
 273
 274         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 275
 276 2019-12-18  Tom Tromey  <tromey@adacore.com>
 277
 278         PR build/25268:
 279         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 280         type on macOS.  Add comment.
 281
 282 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 283
 284         * c-lang.c (c_get_string, asm_language_defn): Remove space
 285         before tab.
 286
 287 2019-12-18  Tom Tromey  <tromey@adacore.com>
 288
 289         PR build/25250:
 290         * ui-out.c (ui_out::vmessage): Update.
 291         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 292         Rename.
 293         (string_field): Update.
 294         (signed_field): Update.
 295
 296 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 297
 298         * top.c (print_gdb_configuration): Adjust indentation.
 299
 300 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 301
 302         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 303
 304 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 305
 306         * tui/tui-layout.h (class tui_layout_base): Add virtual
 307         destructor.
 308
 309 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 310
 311         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 312         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 313         (process_event_stop_test): Keep stepping over skipped inline functions.
 314
 315 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 316
 317         * jit.c (struct gdb_block) <next>: Remove field.
 318         (struct gdb_symtab) <~gdb_symtab>: Remove.
 319         <blocks>: Change type to std::forward_list<gdb_block>.
 320         (compare_block): Remove.
 321         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 322         block at the beginning, don't mind about sorting.
 323         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 324         before using it.
 325
 326 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 327
 328         * jit.c (struct gdb_block): Add constructor, initialize
 329         real_block and next fields.
 330         <name>: Change type to gdb::unique_xmalloc_ptr.
 331         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 332         (jit_block_open_impl): Allocate gdb_block with new.
 333         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 334
 335 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 336
 337         * jit.c: Include forward_list.
 338         (struct gdb_symtab) <next>: Remove field.
 339         (struct gdb_object) <symtabs>: Change type to
 340         std::forward_list<gdb_symtab>.
 341         (jit_object_open_impl): Allocate gdb_object with new.
 342         (jit_symtab_open_impl): Adjust to std::forward_list.
 343         (finalize_symtab): Don't delete symtab.
 344         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 345         gdb_object with delete.
 346
 347 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 348
 349         * jit.c (struct gdb_symtab): Add constructor, destructor,
 350         initialize fields.
 351         <linetable>: Change type to unique_xmalloc_ptr.
 352         <file_name>: Change type to std::string.
 353         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 354         (jit_symtab_line_mapping_add_impl): Adjust.
 355         (finalize_symtab): Adjust, call delete on stab.
 356
 357 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 358
 359         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 360
 361 2019-12-16  Tom Tromey  <tromey@adacore.com>
 362
 363         * windows-nat.c (windows_nat_target::attach): Update.
 364         * remote.c (extended_remote_target::attach): Update.
 365         * procfs.c (procfs_target::attach): Update.
 366         * nto-procfs.c (nto_procfs_target::attach): Update.
 367         (nto_procfs_target::create_inferior): Update.
 368         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 369         * gnu-nat.c (gnu_nat_target::attach): Update.
 370         (gnu_nat_target::detach): Update.
 371         * darwin-nat.c (darwin_nat_target::attach): Update.
 372         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 373         return.
 374         * bsd-kvm.c (bsd_kvm_target_open): Update.
 375         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 376
 377 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 378
 379         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 380         (we no longer need to include time.h before pathmax.h)
 381
 382 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 383
 384         * ada-exp.y (write_ambiguous_var): Update.
 385         * coffread.c (process_coff_symbol): Update.
 386         * ctfread.c (ctf_add_enum_member_cb): Update.
 387         (new_symbol): Update.
 388         * dwarf2read.c (fixup_go_packaging): Update.
 389         (new_symbol): Update.
 390         * language.c (language_alloc_type_symbol): Update.
 391         * mdebugread.c (new_symbol): Update.
 392         * minsyms.c (minimal_symbol_reader::record_full): Update.
 393         * psymtab.c (add_psymbol_to_bcache): Update.
 394         * stabsread.c (define_symbol): Update.
 395         (read_enum_type): Update.
 396         * symtab.c (symbol_set_language): Make this a member function...
 397         (general_symbol_info::set_language): ... here.
 398         * symtab.h (struct general_symbol_info) <set_language>: New function.
 399         (SYMBOL_SET_LANGUAGE): Remove.
 400         (symbol_set_language): Remove.
 401
 402 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 403
 404         * ada-lang.c (ada_add_block_symbols): Update.
 405         (ada_collect_symbol_completion_matches): Update.
 406         * ax-gdb.c (gen_expr): Update.
 407         * block.c (block_lookup_symbol): Update.
 408         (block_lookup_symbol_primary): Update.
 409         (block_find_symbol): Update.
 410         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 411         * dbxread.c (process_one_symbol): Update.
 412         * dictionary.c (insert_symbol_hashed): Update.
 413         (collate_pending_symbols_by_language): Update.
 414         (mdict_add_symbol): Update.
 415         * dwarf-index-write.c (write_psymbols): Update.
 416         * dwarf2read.c (fixup_go_packaging): Update.
 417         * findvar.c (read_var_value): Update.
 418         * ft32-tdep.c (ft32_skip_prologue): Update.
 419         * go-lang.c (go_symbol_package_name): Update.
 420         * language.h (scoped_switch_to_sym_language_if_auto::
 421         scoped_switch_to_sym_language_if_auto): Update.
 422         * linespec.c (find_method): Update.
 423         (find_label_symbols_in_block): Update.
 424         * mdebugread.c (parse_symbol): Update.
 425         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 426         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 427         (minimal_symbol_reader::install): Update.
 428         * moxie-tdep.c (moxie_skip_prologue): Update.
 429         * parse.c (parse_exp_in_context): Update.
 430         * psymtab.c (psymbol_name_matches): Update.
 431         (match_partial_symbol): Update.
 432         (lookup_partial_symbol): Update.
 433         (psymbol_hash): Update.
 434         (psymbol_compare): Update.
 435         * python/py-framefilter.c (extract_sym): Update.
 436         (py_print_single_arg): Update.
 437         * stabsread.c (define_symbol): Update.
 438         * stack.c (print_frame_arg): Update.
 439         (find_frame_funname): Update.
 440         (info_frame_command_core): Update.
 441         * symfile.c (set_initial_language): Update.
 442         * symtab.c (symbol_set_demangled_name): Update.
 443         (symbol_get_demangled_name): Update.
 444         (symbol_set_language): Update.
 445         (symbol_find_demangled_name): Update.
 446         (symbol_set_names): Update.
 447         (general_symbol_info::natural_name): Update.
 448         (general_symbol_info::demangled_name): Update.
 449         (general_symbol_info::search_name): Update.
 450         (symbol_matches_search_name): Update.
 451         (eq_symbol_entry): Update.
 452         (iterate_over_symbols): Update.
 453         (completion_list_add_symbol): Update.
 454         (completion_list_add_msymbol): Update.
 455         (completion_list_add_fields): Update.
 456         * symtab.h (struct general_symbol_info) <language>: New function.
 457         <language>: Rename to...
 458         <m_language>: ...this.
 459         (SYMBOL_LANGUAGE): Remove.
 460         (MSYMBOL_LANGUAGE): Remove.
 461         (struct symbol) <ctor>: Update.
 462         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 463
 464 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 465
 466         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 467         set the language of sym.
 468         * language.c (language_alloc_type_symbol): Likewise.
 469
 470 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 471
 472         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 473         PR gdb/23613
 474         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 475         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 476         (core_target_open): Use 'gdb_abspath'.
 477         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 478         'current_directory == NULL' case.
 479         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 480         explain what happens when 'current_directory' is NULL.
 481         * go32-nat.c (go32_nat_target::wait): Check if
 482         'current_directory' is NULL before call to 'chdir'.
 483         * source.c (add_path): Use 'gdb_abspath'.
 484         * top.c: Include 'gdbsupport/pathstuff.h'.
 485         (init_history): Use 'gdb_abspath'.
 486         (set_history_filename): Likewise.
 487         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 488         (tfile_target_open): Use 'gdb_abspath'.
 489
 490 2019-12-13  Tom Tromey  <tromey@adacore.com>
 491
 492         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 493         warning or error.
 494
 495 2019-12-13  Tom Tromey  <tromey@adacore.com>
 496
 497         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 498
 499 2019-12-13  Tom Tromey  <tromey@adacore.com>
 500
 501         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 502
 503 2019-12-13  Tom Tromey  <tromey@adacore.com>
 504
 505         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 506
 507 2019-12-13  Tom Tromey  <tromey@adacore.com>
 508
 509         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 510         (string_vappendf): Add ARI comment.
 511
 512 2019-12-13  Tom Tromey  <tromey@adacore.com>
 513
 514         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 515         floatformat_to_double.
 516         * target-float.c (host_float_ops<T>::from_target): Add ARI
 517         comment.
 518
 519 2019-12-13  Tom Tromey  <tromey@adacore.com>
 520
 521         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 522         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 523         ARI marker to abort.
 524         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 525
 526 2019-12-13  Tom Tromey  <tromey@adacore.com>
 527
 528         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 529
 530 2019-12-13  Tom Tromey  <tromey@adacore.com>
 531
 532         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 533
 534 2019-12-13  Tom Tromey  <tromey@adacore.com>
 535
 536         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 537         checks.
 538
 539 2019-12-13  Tom Tromey  <tromey@adacore.com>
 540
 541         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 542         end>: No longer "const".
 543
 544 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 545
 546         * jit.c: Fix indentation, replace spaces with tabs where
 547         applicable.
 548
 549 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 550
 551         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 552
 553 2019-12-12  Tom Tromey  <tom@tromey.com>
 554
 555         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 556         unique_ptr.
 557
 558 2019-12-12  Tom Tromey  <tom@tromey.com>
 559
 560         * progspace.h (objfile_list): New typedef.
 561         (class unwrapping_objfile_iterator)
 562         (struct unwrapping_objfile_range): Newl
 563         (struct program_space) <objfiles_range>: Change type.
 564         <objfiles>: Change return type.
 565         <add_objfile>: Change type of "objfile" parameter.
 566         <objfiles_list>: Now a list of shared_ptr.
 567         * progspace.c (program_space::add_objfile): Change type of
 568         "objfile".  Update.
 569         (program_space::remove_objfile): Update.
 570         * objfiles.h (struct objfile) <~objfile>: Make public.
 571         * objfiles.c (objfile::make): Update.
 572         (objfile::unlink): Don't call delete.
 573
 574 2019-12-12  Tom Tromey  <tom@tromey.com>
 575
 576         * symfile.c (symbol_file_clear): Update.
 577         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 578         method.
 579         * progspace.c (program_space::free_all_objfiles): New method.
 580         * objfiles.h (free_all_objfiles): Don't declare.
 581         * objfiles.c (free_all_objfiles): Move to program_space.
 582
 583 2019-12-12  Tom Tromey  <tom@tromey.com>
 584
 585         * progspace.c (program_space::add_objfile)
 586         (program_space::remove_objfile): Update.
 587         (program_space::multi_objfile_p): Remove.
 588         * objfiles.h (struct objfile) <next>: Remove.
 589         * objfiles.c (objfile::objfile): Update.
 590         (put_objfile_before): Update.
 591         (unlink_objfile): Update.
 592         * progspace.h (object_files): Remove.
 593         (struct program_space) <objfiles_head>: Remove.
 594         <objfiles_list>: New member.
 595         <objfiles_range, objfiles_safe_range>: Change type.
 596         (objfiles): Change return type.
 597         (objfiles_safe): Update.
 598         (multi_objfile_p): Rewrite and inline.
 599         (object_files): Remove macro.
 600
 601 2019-12-12  Tom Tromey  <tom@tromey.com>
 602
 603         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 604         second constructor.
 605         (basic_safe_range): New class.
 606
 607 2019-12-12  Tom Tromey  <tom@tromey.com>
 608
 609         * progspace.c (program_space::multi_objfile_p): New method.
 610         * printcmd.c (info_symbol_command): Update.
 611         * maint.c (maintenance_translate_address): Update.
 612         * objfiles.h (MULTI_OBJFILE_P): Remove.
 613         * progspace.h (struct program_space) <multi_objfile_p>: New
 614         method.
 615
 616 2019-12-12  Tom Tromey  <tom@tromey.com>
 617
 618         * progspace.h (struct program_space) <remove_objfile>: Declare.
 619         * progspace.c (program_space::remove_objfile): New method.
 620         * objfiles.c (unlink_objfile): Remove.
 621         (objfile::unlink): Call remove_objfile.
 622         (objfile): Don't call unlink_objfile.
 623
 624 2019-12-12  Tom Tromey  <tom@tromey.com>
 625
 626         * progspace.h (struct program_space) <add_objfile>: Declare
 627         method.
 628         * progspace.c (program_space::add_objfile): New method.
 629         * objfiles.c (~objfile): Don't unlink objfile.
 630         (put_objfile_before): Remove.
 631         (add_separate_debug_objfile): Don't call put_objfile_before.
 632         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 633         the per-program-space data.
 634
 635 2019-12-12  Tom Tromey  <tom@tromey.com>
 636
 637         * symfile.c (syms_from_objfile_1): Use objfile_up.
 638         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 639         method.
 640         (reread_symbols): Use objfile_up.
 641         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 642         unlink method.
 643         * objfiles.h (struct objfile) <~objfile>: Now private.
 644         <unlink>: New method.
 645         (struct objfile_deleter): New.
 646         (objfile_up): New typedef.
 647         * objfiles.c (objfile::unlink): New method.
 648         (free_objfile_separate_debug, free_all_objfiles)
 649         (objfile_purge_solibs): Use it.
 650         * jit.c (jit_unregister_code): Remove.
 651         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 652         objfile.
 653         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 654         objfile.
 655         * compile/compile-object-load.c (compile_object_load): Use
 656         objfile_up.
 657
 658 2019-12-12  Tom Tromey  <tom@tromey.com>
 659
 660         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 661         objfile::make.
 662         * objfiles.h (struct objjfile) <make>: No longer inline.
 663         (add_separate_debug_objfile): Don't declare.
 664         * objfiles.c (add_separate_debug_objfile): Now static.
 665         (objfile::make): Move from objfiles.h.  Call
 666         add_separate_debug_objfile.  Add "parent" parameter.
 667
 668 2019-12-12  Tom Tromey  <tom@tromey.com>
 669
 670         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 671         * objfiles.h (struct objfile): Make constructor private.
 672         <make>: New static method.
 673         * jit.c (jit_object_close_impl): Update.
 674
 675 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 676
 677         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 678         gdb::byte_vector.
 679
 680 2019-12-12  Tom Tromey  <tromey@adacore.com>
 681
 682         * xml-support.c (xml_fetch_content_from_file): Don't call
 683         malloc_failure.
 684         * utils.h (class gdb_argv): Remove malloc_failure comment.
 685         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 686
 687 2019-12-12  Tom Tromey  <tromey@adacore.com>
 688
 689         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 690         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 691         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 692         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 693         * riscv-ravenscar-thread.c: New file.
 694         * riscv-ravenscar-thread.h: New file.
 695         * riscv-tdep.c (riscv_gdbarch_init): Call
 696         register_riscv_ravenscar_ops.
 697
 698 2019-12-12  Tom Tromey  <tromey@adacore.com>
 699
 700         * gdbsupport/thread-pool.c (set_thread_name): Use
 701         ATTRIBUTE_UNUSED.
 702
 703 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 704
 705         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 706         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 707         macros.
 708
 709 2019-12-11  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-win.c (tui_set_win_height_command): Call
 712         tui_adjust_window_height.
 713         (tui_adjust_win_heights, new_height_ok): Remove.
 714         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 715         * tui/tui-layout.c (tui_adjust_window_height): New function.
 716
 717 2019-12-11  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-win.c (tui_resize_all): Remove code, call
 720         tui_apply_current_layout.
 721
 722 2019-12-11  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 725         * tui/tui-layout.c (standard_layouts, applied_layout): New
 726         globals.
 727         (tui_apply_current_layout): New function.
 728         (show_layout): Set applied_layout.  Call
 729         tui_apply_current_layout.
 730         (show_source_command, show_disasm_command)
 731         (show_source_disasm_command, show_data)
 732         (show_source_or_disasm_and_command): Remove.
 733         (initialize_layouts): New function.
 734         (_initialize_tui_layout): Call initialize_layouts.
 735
 736 2019-12-11  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-layout.h (class tui_layout_base)
 739         (class tui_layout_window, class tui_layout_split): New.
 740         * tui/tui-layout.c (tui_get_window_by_name)
 741         (tui_layout_window::clone, tui_layout_window::apply)
 742         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 743         (tui_layout_split::add_window, tui_layout_split::clone)
 744         (tui_layout_split::get_sizes)
 745         (tui_layout_split::set_weights_from_heights)
 746         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 747         functions.
 748         (tui_layout_split::add_split, tui_layout_split::add_split)
 749         (tui_layout_split::set_weights_from_heights)
 750         (tui_layout_split::set_weights_from_heights): New functions.
 751
 752 2019-12-11  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 755         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 756         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 757         * tui/tui-data.h (struct tui_point): Remove.
 758         (struct tui_gen_win_info) <origin>: Remove.
 759         <x, y>: New fields.
 760         * tui/tui-command.c (tui_cmd_window::resize): Update.
 761
 762 2019-12-11  Tom Tromey  <tom@tromey.com>
 763
 764         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 765         Implement.
 766         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 767         Implement.
 768         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 769         method.
 770         (struct tui_win_info) <min_height>: Implement.
 771
 772 2019-12-11  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 775         (struct tui_win_info) <can_box>: Update.
 776
 777 2019-12-11  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 780         method.
 781         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 782         method.
 783         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 784         method.
 785         (struct tui_win_info) <max_height>: Now override.
 786
 787 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 788
 789         * NEWS: Create a new section for the next release branch.
 790         Rename the section of the current branch, now that it has
 791         been cut.
 792
 793 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 794
 795         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 796         * version.in: Bump version to 10.0.50.DATE-git.
 797
 798 2019-12-11  Tom Tromey  <tromey@adacore.com>
 799
 800         PR build/25268:
 801         * gdbsupport/thread-pool.c (set_thread_name): New function.
 802         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 803         (thread_pool::thread_function): Call set_thread_name.
 804
 805 2019-12-11  Tom Tromey  <tromey@adacore.com>
 806
 807         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 808         bfd_get_signed_8.
 809
 810 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 811
 812         * NEWS: Document -raw-values option and the related setting commands.
 813         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 814         only set it on when /r is given.
 815         * valprint.c (value_print_option_defs): New element raw-values.
 816         * Makefile.in: Add the new file.
 817
 818 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 819
 820         * gdbsupport/safe-strerror.c: Supress the unused function warning
 821         for select_strerror_r.
 822
 823 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 824
 825         * config.in: Regenerate.
 826         * configure: Regenerate.
 827         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 828         safe_strerror instead of strerror.
 829         * gdbsupport/common.m4: Don't check for strerror.
 830         * gdbsupport/safe-strerror.c: Support both the glibc version
 831         of strerror_r and the XSI version.
 832
 833 2019-12-10  Tom Tromey  <tromey@adacore.com>
 834
 835         * ada-typeprint.c (print_choices): Use a single "?".
 836         (print_variant_part): Print "?" if the discriminant name
 837         is not known.
 838
 839 2019-12-10  George Barrett  <bob@bob131.so>
 840
 841         Fix scripted probe breakpoints.
 842         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 843         declaration forward.
 844         (breakpoint_ops_for_event_location_type)
 845         (breakpoint_ops_for_event_location): Add function definitions.
 846         (break_command_1, trace_command): Use
 847         breakpoint_ops_for_event_location.
 848         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 849         declarations.
 850         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 851         breakpoint_ops_for_event_location.
 852         * python/py-breakpoint.c (bppy_init): Use
 853         breakpoint_ops_for_event_location.
 854
 855 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 856
 857         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 858         when ranking an lvalue argument for an rvalue parameter.
 859
 860 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 861
 862         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 863         template argument for scoped_restore_tmpl from bool to int.
 864
 865 2019-12-07  Keith Seitz  <keiths@redhat.com>
 866
 867         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 868         (build_id_to_debug_bfd): Make static, rewriting to use
 869         build_id_to_bfd_suffix.
 870         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 871         adding `suffix' parameter. Append SUFFIX to file names
 872         when searching for matching files.
 873         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 874         (build_id_to_exec_bfd): Likewise.
 875         * build-id.h (build_id_to_debug_bfd): Clarify that function
 876         searches for BFD of debug info file.
 877         (build_id_to_exec_bfd): Declare.
 878         * corelow.c: Include build-id.h.
 879         (locate_exec_from_corefile_build_id): New function.
 880         (core_target_open): If no executable BFD is found,
 881         search for a core file BFD using build-id.
 882
 883 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 884
 885         * bcache.c: Put in namespace gdb.
 886         * bcache.h: Likewise.
 887         * gdbtypes.c (check_types_worklist): Update.
 888         (types_deeply_equal): Update.
 889         * macrotab.c (struct macro_table) <bcache>: Update.
 890         (new_macro_table): Update.
 891         * macrotab.h (struct bcache): Put this forward declaration
 892         inside namespace gdb.
 893         (new_macro_table): Update.
 894         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 895         Update.
 896         <macro_cache>: Update.
 897         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 898
 899 2019-12-06  Tom de Vries  <tdevries@suse.de>
 900
 901         PR symtab/24971
 902         * block.c (best_symbol, better_symbol): New function.
 903         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 904         decl.
 905
 906 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 907
 908         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 909         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 910         for ranking see-through reference cases.
 911
 912 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 913         * stack.c (faas_command): Check a command is provided.
 914         * thread.c (taas_command, tfaas_command): Likewise.
 915
 916 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917         * inferior.c (prune_inferiors):  Only call delete_inferior,
 918         Do not modify the inferior list.
 919
 920 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 921
 922         * c-exp.y: Update calls to lookup_typename,
 923         lookup_signed_typename and lookup_unsigned_typename.
 924         * c-lang.c (evaluate_subexp_c): Likewise.
 925         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 926         Likewise.
 927         * eval.c (binop_promote): Likewise.
 928         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 929         (lookup_unsigned_typename): Likewise.
 930         (lookup_signed_typename): Likewise.
 931         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 932         (lookup_signed_typename): Likewise.
 933         (lookup_typename): Likewise.
 934         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 935         lookup_typename, lookup_signed_typename,
 936         lookup_unsigned_typename.
 937         * m2-exp.y: Likewise.
 938         * printcmd.c (printf_wide_c_string): Likewise.
 939         (ui_printf): Likewise.
 940         * python/py-type.c (typy_lookup_typename): Likewise.
 941         * python/py-xmethods.c (python_xmethod_worker::invoke):
 942         Likewise.
 943         * rust-exp.y: Likewise.
 944
 945 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 946
 947         * configure.nat (obsd64): Add missing files x86-nat.o and
 948         nat/x86-dregs.o.
 949
 950 2019-12-04  Tom Tromey  <tom@tromey.com>
 951
 952         * valprint.c (val_print_string): Use metadata_style.
 953         * go-valprint.c (print_go_string): Use metadata style.
 954         * p-valprint.c (pascal_object_print_static_field): Use metadata
 955         style.
 956         * cp-valprint.c (cp_print_static_field): Use metadata style.
 957
 958 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 959             Chris January  <chris.january@arm.com>
 960
 961         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 962         tokens.
 963         (typebase): New patterns for complex, single/double precision, and
 964         single/double complex.
 965         (f77_keywords): Change token for complex keyword, and add single,
 966         double, and precision keywords.
 967
 968 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 969
 970         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 971         "info io_registers".
 972
 973 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 974
 975         * regcache.c (cooked_read_test): Initialize thread list of
 976         mock_inferior.
 977
 978 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 979
 980         * aarch64-linux-tdep.c: Remove includes.
 981
 982 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 983
 984         * aarch64-tdep.c: Remove includes.
 985
 986 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 987
 988         * filtered-iterator.h (filtered_iterator) <operator==,
 989         operator!=>: Compare wrapped iterators, not wrapped pointers.
 990         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 991         unittests/filtered_iterator-selftests.c.
 992         * unittests/filtered_iterator-selftests.c: New file.
 993
 994 2019-12-04  Tom Tromey  <tromey@adacore.com>
 995
 996         * gdbtypes.c (create_range_type): Inherit endianity
 997         from base type.
 998
 999 2019-12-04  Tom Tromey  <tromey@adacore.com>
1000
1001         * ada-lang.c (decode_constrained_packed_array)
1002         (ada_value_assign, value_assign_to_component): Update.
1003         * dwarf2loc.c (rw_pieced_value, access_memory)
1004         (dwarf2_compile_expr_to_ax): Update.
1005         * dwarf2read.c (dwarf2_add_field): Update.
1006         * eval.c (evaluate_subexp_standard): Update.
1007         * gdbarch.c, gdbarch.h: Rebuild.
1008         * gdbarch.sh (bits_big_endian): Remove.
1009         * gdbtypes.h (union field_location): Update comment.
1010         * target-descriptions.c (make_gdb_type): Update.
1011         * valarith.c (value_bit_index): Update.
1012         * value.c (struct value) <bitpos>: Update comment.
1013         (unpack_bits_as_long, modify_field): Update.
1014         * value.h (value_bitpos): Update comment.
1015
1016 2019-12-04  Tom Tromey  <tromey@adacore.com>
1017
1018         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1019         endian-ness.
1020
1021 2019-12-04  Tom Tromey  <tromey@adacore.com>
1022
1023         * dwarf2read.c (dwarf2_init_float_type)
1024         (dwarf2_init_complex_target_type): Add byte_order parameter.
1025         (read_base_type): Compute byte order earlier.
1026         * gdbtypes.c (init_float_type): Add byte_order parameter.
1027         * gdbtypes.h (init_float_type): Add byte_order parameter.
1028
1029 2019-12-04  Tom Tromey  <tromey@adacore.com>
1030
1031         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1032
1033 2019-12-04  Tom Tromey  <tromey@adacore.com>
1034
1035         * dwarf2read.c (process_structure_scope): Initialize
1036         "discr_offset".
1037
1038 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1041         add it into the search spec.
1042         (parse_max_results_option): New function.
1043         (mi_info_functions_or_variables): Parse -max-results flag and pass
1044         it to mi_symbol_info.
1045         (mi_cmd_symbol_info_modules): Likewise.
1046         (mi_cmd_symbol_info_types): Likewise.
1047         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1048         return type to bool, change result container into a set, and don't
1049         add new results if we have enough already.
1050         (global_symbol_searcher::add_matching_msymbols): Change return
1051         type to bool, and don't add new results if we have enough already.
1052         (sort_search_symbols_remove_dups): Delete.
1053         (global_symbol_searcher::search): Early exit from search loop when
1054         we have enough results.  Use a std::set to collect the results
1055         from calling add_matching_symbols.
1056         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1057         member function.
1058         (global_symbol_searcher) <m_max_search_results>: New member
1059         variable.
1060         (global_symbol_searcher) <add_matching_symbols>: Update header
1061         comment and change return type to bool.
1062         (global_symbol_searcher) <add_matching_msymbols>: Update header
1063         comment and change return type to bool.
1064
1065 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * symtab.c (symbol_search::compare_search_syms): Update header
1068         comment.
1069         (global_symbol_searcher::is_suitable_msymbol): New function.
1070         (global_symbol_searcher::expand_symtabs): New function.
1071         (global_symbol_searcher::add_matching_symbols): New function.
1072         (global_symbol_searcher::add_matching_msymbols): New function.
1073         (global_symbol_searcher::search): Move most of the content
1074         into the new functions above, and call them as needed.
1075         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1076         function.
1077         (global_symbol_searcher) <add_matching_symbols>: New member
1078         function.
1079         (global_symbol_searcher) <add_matching_msymbols>: New member
1080         function.
1081         (global_symbol_searcher) <is_suitable_msymbol>: New member
1082         function.
1083
1084 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1087         -symbol-info-module-variables entries.
1088         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1089         (mi_cmd_symbol_info_module_variables): Declare.
1090         * mi/mi-symbol-cmds.c
1091         (module_symbol_search_iterator): New typedef.
1092         (output_module_symbols_in_single_module_and_file): New function.
1093         (output_module_symbols_in_single_module): New function.
1094         (mi_info_module_functions_or_variables): New function.
1095         (mi_cmd_symbol_info_module_functions): New function.
1096         (mi_cmd_symbol_info_module_variables): New function.
1097         * NEWS: Mention new MI command.
1098
1099 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1100
1101         * bcache.c (hash): Remove.
1102         (hash_continue): Remove.
1103         * bcache.h (hash): Remove.
1104         (hash_continue): Remove.
1105         (struct bcache) <ctor>: Update.
1106         * psymtab.c (psymbol_hash): Update.
1107         * stabsread.c (hashname): Update.
1108         * utils.h (fast_hash): Add an argument for a start value,
1109         defaulting to zero.
1110
1111 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1113         (destroy_block_symbol_cache): New function.
1114         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1115         (resize_symbol_cache): Likewise.
1116
1117 2019-12-02  Tom Tromey  <tom@tromey.com>
1118
1119         * unittests/tui-selftests.c (run_tests): Make conditional.
1120         (_initialize_tui_selftest): Make conditional.
1121
1122 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1123
1124         * aix-thread.c (debug_aix_thread): Change type to bool.
1125
1126 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1127
1128         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1129
1130 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * dwarf2read.c (read_tag_string_type): Read the fields required to
1133         make a dynamic string, and possibly create a dynamic range for the
1134         string.
1135         (attr_to_dynamic_prop): Setup is_reference based on the type of
1136         attribute being processed.
1137         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1138         (resolve_dynamic_array): Rename to...
1139         (resolve_dynamic_array_or_string): ...this, update header comment,
1140         and accept TYPE_CODE_STRING.
1141         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1142
1143 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1146         of its implementation from...
1147         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1148         the new function.
1149
1150 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1153         create a range with stride where appropriate.
1154         * f-valprint.c: Include 'gdbarch.h'.
1155         (f77_print_array_1): Take the stride into account when walking the
1156         array.  Also convert the stride into addressable units.
1157         * gdbtypes.c (create_range_type): Initialise the stride to
1158         constant zero.
1159         (create_range_type_with_stride): New function, initialise the
1160         range as normal, and then setup the stride.
1161         (has_static_range): Include the stride here.  Also change the
1162         return type to bool.
1163         (create_array_type_with_stride): Consider the range stride if the
1164         array isn't given its own stride.
1165         (resolve_dynamic_range): Resolve the stride if needed.
1166         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1167         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1168         (TYPE_BIT_STRIDE): Define.
1169         (TYPE_ARRAY_BIT_STRIDE): Define.
1170         (create_range_type_with_stride): Declare.
1171         * valarith.c (value_subscripted_rvalue): Take range stride into
1172         account when walking the array.
1173
1174 2019-12-01  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1177         specially.
1178
1179 2019-12-01  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1182         \0.
1183         * unittests/tui-selftests.c: New file.
1184         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1185
1186 2019-12-01  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1189
1190 2019-12-01  Tom Tromey  <tom@tromey.com>
1191
1192         * NEWS: Document new settings.
1193         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1194         * tui/tui-win.c (_initialize_tui_win): Add border style
1195         observers.
1196         * tui/tui-io.h (tui_apply_style): Declare.
1197         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1198         longer static.
1199         (apply_ansi_escape, tui_set_reverse_mode): Update.
1200         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1201         Add "skip_intensity" parameter.
1202         <changed>: New member.
1203         <do_set_value>: Declare.
1204         (tui_border_style, tui_active_border_style): Declare.
1205         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1206         globals.
1207         (cli_style_option): Initialize "changed".
1208         (cli_style_option::do_set_value): New function.
1209         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1210         parameter.  Update.
1211         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1212         (_initialize_cli_style): Update.  Create TUI border style
1213         commands.
1214
1215 2019-12-01  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1218         parameter.
1219         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1220         parameter.
1221         * tui/tui-win.h (compact_source): Declare.
1222         * tui/tui-win.c (compact_source): New global.
1223         (tui_set_compact_source, tui_show_compact_source): New functions.
1224         (_initialize_tui_win): Add "compact-source" setting.
1225         * tui/tui-source.c (tui_source_window::set_contents): Handle
1226         compact_source setting.
1227         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1228         * NEWS: Document new setting.
1229
1230 2019-11-30  Tom Tromey  <tom@tromey.com>
1231
1232         * dwarf2read.c (dwarf2_add_field): Include field offset when
1233         computing variant part length.
1234
1235 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1236         * NEWS:  Mention define-prefix.  Tell that command names can now
1237         contain a . character.
1238
1239 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1240
1241         * command.h (valid_cmd_char_p): Declare.
1242         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1243         the check of valid command char.
1244         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1245         valid_cmd_char_p.
1246         * cli/cli-script.c (validate_comname): Likewise.
1247         * completer.c (gdb_completer_command_word_break_characters):
1248         Do not remove . from the word break char, update comments.
1249         (complete_line_internal_1): Use valid_cmd_char_p.
1250         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1251         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1252
1253 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * cli/cli-script.c (do_define_command): Ensure a redefined
1256         prefix command is kept as a prefix command.
1257         (define_prefix_command): New function.
1258         (show_user_1): Report user defined prefixes.
1259         (_initialize_cli_script):  Create the new 'define-prefix' command.
1260         Add completers for 'define' and 'document'.
1261         * top.c (execute_command):  If command is a user-defined prefix only
1262         command, report the list of commands for this prefix command.
1263
1264 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1265
1266         * valops.c (find_oload_champ): Improve debug output.
1267
1268 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1269
1270         * valops.c (find_oload_champ): Print part of debug messages
1271         before the badness vector is std::move'd.
1272
1273 2019-11-28  Tom Tromey  <tom@tromey.com>
1274
1275         * value.c (creal_internal_fn): Fix comment.
1276
1277 2019-11-28  Tom Tromey  <tom@tromey.com>
1278
1279         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1280         flag_bound_evaluated>: Now unsigned.
1281
1282 2019-11-28  Tom Tromey  <tom@tromey.com>
1283
1284         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1285         declare.
1286
1287 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1288
1289         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1290         debug output.
1291         * jit.c (jit_unregister_code): Add debug print to match
1292         `jit_register_code`.
1293
1294 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1295
1296         * NEWS: Mention the new multithreaded symbol loading.
1297
1298 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1299
1300         * maint.c (n_worker_threads): Default to 0.
1301         (worker_threads_disabled): New function.
1302         * maint.h (worker_threads_disabled): New function.
1303         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1304         here if worker_threads_disabled () is true.
1305         (minimal_symbol_reader::install): Skip all threading if
1306         worker_threads_disabled () is true.
1307
1308 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1309
1310         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1311         hash code if possible.
1312         (add_minsym_to_demangled_hash_table): Likewise.
1313         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1314         on the background thread.
1315         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1316         Add these fields.
1317
1318 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1321         of the mangled name on the background thread.
1322         * symtab.c (symbol_set_names): Allow passing in the hash of the
1323         linkage_name.
1324         * symtab.h (symbol_set_names): Likewise.
1325
1326 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1327
1328         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1329         physnames are computed for inherited DIEs.
1330
1331 2019-11-27  Tom Tromey  <tromey@adacore.com>
1332
1333         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1334         backslashes.
1335         * cp-support.c: Remove unnecessary backslashes.
1336
1337 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1338
1339         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1340         with sym->set_linkage_name.
1341         * coffread.c (coff_read_enum_type): Likewise.
1342         * mdebugread.c (parse_symbol): Likewise.
1343         * stabsread.c (patch_block_stabs): Likewise.
1344         (define_symbol): Likewise.
1345         (read_enum_type): Likewise.
1346         (common_block_end): Likewise.
1347         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1348         function.
1349         (SYMBOL_SET_LINKAGE_NAME): Remove.
1350         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1351         with sym->set_linkage_name.
1352
1353 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1356         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1357         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1358         * NEWS: Mention new MI command.
1359
1360 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1363         '-symbol-info-types', and '-symbol-info-variables'.
1364         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1365         (mi_cmd_symbol_info_types): Declare.
1366         (mi_cmd_symbol_info_variables): Declare.
1367         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1368         (output_debug_symbol): New function.
1369         (output_nondebug_symbol): New function.
1370         (mi_symbol_info): New function.
1371         (mi_info_functions_or_variables): New function.
1372         (mi_cmd_symbol_info_functions): New function.
1373         (mi_cmd_symbol_info_types): New function.
1374         (mi_cmd_symbol_info_variables): New function.
1375         * NEWS: Mention new commands.
1376
1377 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * symtab.c (symbol_to_info_string): New function, most content
1380         moved from print_symbol_info, but updated to return a std::string.
1381         (print_symbol_info): Update to use symbol_to_info_string and print
1382         returned string.
1383         * symtab.h (symbol_to_info_string): Declare new function.
1384
1385 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * python/python.c (gdbpy_rbreak): Convert to using
1388         global_symbol_searcher.
1389         * symtab.c (file_matches): Convert return type to bool, change
1390         file list to std::vector, update header comment.
1391         (search_symbols): Rename to...
1392         (global_symbol_searcher::search): ...this and update now its
1393         a member function of global_symbol_searcher.  Take account of the
1394         changes to file_matches.
1395         (symtab_symbol_info): Convert to using global_symbol_searcher.
1396         (rbreak_command): Likewise.
1397         (search_module_symbols): Likewise.
1398         * symtab.h (enum symbol_search): Update comment.
1399         (search_symbols): Remove declaration.
1400         (class global_symbol_searcher): New class.
1401
1402 2019-11-26  Tom Tromey  <tromey@adacore.com>
1403
1404         * cp-support.c (_initialize_cp_support): Conditionally initialize
1405         gdb_demangle_attempt_core_dump.
1406
1407 2019-11-26  Tom Tromey  <tom@tromey.com>
1408
1409         * python/py-function.c (fnpy_init): Update.
1410         * value.h (add_internal_function): Adjust declaration.
1411         * value.c (function_destroyer): Remove.
1412         (do_add_internal_function): Don't set destroyer or copy name.
1413         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1414         Set name_allocated.
1415         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1416         (cmdpy_init): Set name_allocated.
1417         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1418         member.
1419         (~cmd_list_element): Free "name" if needed.
1420
1421 2019-11-26  Tom Tromey  <tom@tromey.com>
1422
1423         * value.h (add_internal_function): Add new overload.  Move
1424         documentation from value.h.
1425         * value.c (do_add_internal_function): New function.
1426         (add_internal_function): Use it.  Add new overload.
1427         (function_destroyer): Don't free doc.
1428         * python/py-function.c (fnpy_init): Update.
1429
1430 2019-11-26  Tom Tromey  <tom@tromey.com>
1431
1432         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1433         (cmdpy_init): Set "doc_allocated".
1434
1435 2019-11-26  Tom Tromey  <tom@tromey.com>
1436
1437         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1438         name of worker thread.
1439         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1440         pthread_setname_np.
1441         * configure, config.in: Rebuild.
1442
1443 2019-11-26  Tom Tromey  <tom@tromey.com>
1444
1445         * python/python.c (class gdbpy_gil): New.
1446         (struct gdbpy_event): Add constructor, destructor, operator().
1447         (gdbpy_post_event): Use run_on_main_thread.
1448         (gdbpy_initialize_events): Remove.
1449         (do_start_initialization): Update.
1450
1451 2019-11-26  Tom Tromey  <tom@tromey.com>
1452
1453         * NEWS: Add entry.
1454         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1455         commands.  Call update_thread_pool_size.
1456         (update_thread_pool_size, maintenance_set_worker_threads): New
1457         functions.
1458         (n_worker_threads): New global.
1459
1460 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1461             Tom Tromey  <tom@tromey.com>
1462
1463         * minsyms.c (minimal_symbol_reader::install): Use
1464         parallel_for_each.
1465         * gdbsupport/parallel-for.h: New file.
1466         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1467
1468 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1469             Tom Tromey  <tom@tromey.com>
1470
1471         * gdbsupport/thread-pool.h: New file.
1472         * gdbsupport/thread-pool.c: New file.
1473         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1474         (HFILES_NO_SRCDIR): Add thread-pool.h.
1475
1476 2019-11-26  Tom Tromey  <tom@tromey.com>
1477
1478         * event-top.h (thread_local_segv_handler): Declare.
1479         * event-top.c (thread_local_segv_handler): New global.
1480         (install_handle_sigsegv, handle_sigsegv): New functions.
1481         (async_init_signals): Install SIGSEGV handler.
1482         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1483         thread-local.
1484         (report_failed_demangle): New function.
1485         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1486         handler-setting code, instead use segv_handler.  Run warning code
1487         on main thread.
1488
1489 2019-11-26  Tom Tromey  <tom@tromey.com>
1490
1491         * run-on-main-thread.c: New file.
1492         * run-on-main-thread.h: New file.
1493         * unittests/main-thread-selftests.c: New file.
1494         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1495         main-thread-selftests.c.
1496         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1497         (COMMON_SFILES): Add run-on-main-thread.c.
1498
1499 2019-11-26  Tom Tromey  <tom@tromey.com>
1500
1501         * main.c (setup_alternate_signal_stack): Remove.
1502         (captured_main_1): Use gdb::alternate_signal_stack.
1503         * gdbsupport/alt-stack.h: New file.
1504
1505 2019-11-26  Tom Tromey  <tom@tromey.com>
1506
1507         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1508         Remove comment.
1509         (save_original_signals_state, restore_original_signals_state): Use
1510         gdb_sigmask.
1511         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1512         (_initialize_linux_nat): Use gdb_sigmask.
1513         * guile/guile.c (_initialize_guile): Use block_signals.
1514         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1515         * gdbsupport/gdb-sigmask.h: New file.
1516         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1517         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1518         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1519         pthread_sigmask.
1520         * configure, config.in: Rebuild.
1521         * gdbsupport/block-signals.h: New file.
1522
1523 2019-11-26  Tom Tromey  <tom@tromey.com>
1524
1525         * acinclude.m4: Include ax_pthread.m4.
1526         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1527         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1528         (CLIBS): Use PTHREAD_LIBS.
1529         (aclocal_m4_deps): Add ax_pthread.m4.
1530         * config.in, configure: Rebuild.
1531         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1532
1533 2019-11-26  Tom Tromey  <tom@tromey.com>
1534
1535         * symtab.h (struct minimal_symbol) <name_set>: New member.
1536         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1537         Don't call symbol_set_names.
1538         (minimal_symbol_reader::install): Call symbol_set_names.
1539
1540 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1541
1542         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1543         restore_active_ext_lang, as GIL is needed for (indirectly)
1544         called PyOS_InterruptOccurred.
1545
1546 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1547
1548         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1549         definition.
1550
1551 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1552
1553         * remote-sim.c (simulator_command): Make static, remove
1554         declaration.
1555
1556 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1557
1558         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1559         static.
1560         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1561         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1562         (main): Likewise.
1563         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1564         (main): Likewise.
1565         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1566         (main): Likewise.
1567         * unittests/basic_string_view/element_access/char/1.cc (test01):
1568         Likewise.
1569         (main): Likewise.
1570         * unittests/basic_string_view/element_access/char/empty.cc (main):
1571         Likewise.
1572         * unittests/basic_string_view/element_access/char/front_back.cc
1573         (test01): Likewise.
1574         (main): Likewise.
1575         * unittests/basic_string_view/inserters/char/2.cc (test05):
1576         Likewise.
1577         (main): Likewise.
1578         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1579         (test01): Likewise.
1580         (main): Likewise.
1581         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1582         (test01): Likewise.
1583         (main): Likewise.
1584         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1585         Likewise.
1586         * unittests/basic_string_view/operations/compare/char/1.cc
1587         (test01): Likewise.
1588         (main): Likewise.
1589         * unittests/basic_string_view/operations/compare/char/13650.cc
1590         (test01): Likewise.
1591         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1592         Likewise.
1593         (main): Likewise.
1594         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1595         Likewise.
1596         (main): Likewise.
1597         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1598         Likewise.
1599         (main): Likewise.
1600         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1601         Likewise.
1602         (main): Likewise.
1603         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1604         Likewise.
1605         (main): Likewise.
1606         * unittests/basic_string_view/operations/find/char/4.cc (main):
1607         Likewise.
1608         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1609         Likewise.
1610         (main): Likewise.
1611         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1612         Likewise.
1613         (main): Likewise.
1614         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1615         Likewise.
1616         (main): Likewise.
1617         * unittests/basic_string_view/operations/substr/char/1.cc
1618         (test01): Likewise.
1619         (main): Likewise.
1620         * unittests/basic_string_view/operators/char/2.cc (main):
1621         Likewise.
1622         * unittests/optional/assignment/1.cc (test): Likewise.
1623         * unittests/optional/assignment/2.cc (test): Likewise.
1624         * unittests/optional/assignment/3.cc (test): Likewise.
1625         * unittests/optional/assignment/4.cc (test): Likewise.
1626         * unittests/optional/assignment/5.cc (test): Likewise.
1627         * unittests/optional/assignment/6.cc (test): Likewise.
1628         * unittests/optional/assignment/7.cc (test): Likewise.
1629         * unittests/optional/cons/copy.cc (test): Likewise.
1630         * unittests/optional/cons/default.cc (test): Likewise.
1631         * unittests/optional/cons/move.cc (test): Likewise.
1632         * unittests/optional/cons/value.cc (test): Likewise.
1633         * unittests/optional/in_place.cc (test): Likewise.
1634         * unittests/optional/observers/1.cc (test): Likewise.
1635         * unittests/optional/observers/2.cc (test): Likewise.
1636
1637 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1638
1639         * tui-win.h (tui_set_var_cmd): Remove.
1640         * tui-win.c (tui_set_var_cmd): Make static.
1641
1642 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1643
1644         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1645         rbreak_command_wrapper): Remove.
1646         * symtab.c (rbreak_command_wrapper): Remove.
1647
1648 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1649
1650         * inferior.h (info_terminal_command): Remove declaration.
1651         * inflow.c (info_terminal_command): Make static.
1652
1653 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1654
1655         * inferior.c (exit_inferior_silent): Remove.
1656
1657 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1658
1659         * dictionary.c (dict_empty, mdict_empty): Remove.
1660         * dictionary.c (mdict_empty): Remove.
1661
1662 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1663
1664          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1665          (arc_insn_get_memory_offset): Likewise.
1666          (arc_insn_dump): Likewise.
1667          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1668          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1669          * dictionary.c (dict_iterator_next): Likewise.
1670          (dict_iter_match_first): Likewise.
1671          (dict_iter_match_next): Likewise.
1672          * f-lang.c (evaluate_subexp_f): Likewise.
1673          * hppa-tdep.c (hppa_read_pc): Likewise.
1674          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1675          * parse.c (write_exp_elt_msym): Likewise.
1676          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1677          * remote.c (remote_packet_size): Likewise.
1678          (remote_notif_stop_parse): Likewise.
1679          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1680          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1681          * source.c (prepare_path_for_appending): Likewise.
1682          * sparc64-linux-tdep.c
1683          (sparc64_linux_handle_segmentation_fault); Likewise.
1684          * stack.c (frame_selection_by_function_completer): Likewise.
1685
1686 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1687
1688         * completer.c (set_gdb_completion_word_break_characters):
1689         Remove.
1690
1691 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1692
1693         * dwarf-index-write.c: Include dwarf-index-write.h.
1694         * mi/mi-interp.c: Include mi/mi-interp.h.
1695
1696 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1697
1698         * aarch32-tdep.c: Include aarch32-tdep.h.
1699         * aarch32-tdep.h: Forward-declare struct target_desc.
1700
1701 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1702
1703         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1704         strerror.
1705         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1706         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1707
1708 2019-11-25  Tom de Vries  <tdevries@suse.de>
1709
1710         * contrib/words.sh: Add -c option.
1711
1712 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * solib.c (solib_find_1): Change int to bool.
1715         (exec_file_find): Change int to bool.
1716         (solib_find): Change int to bool.
1717         (solib_read_symbols): Change int to bool.
1718         (solib_used): Change int to bool.
1719         (solib_add): Change int to bool.
1720         (info_sharedlibrary_command): Change int to bool.
1721         (solib_contains_address_p): Change int to bool.
1722         (solib_keep_data_in_core): Change int to bool.
1723         (in_solib_dynsym_resolve_code): Change int to bool.
1724         (reload_shared_libraries_1): Change int to bool.
1725         (gdb_sysroot_changed): Change int to bool.
1726         * solib.h (solib_read_symbols): Change int to bool.
1727         (solib_contains_address_p): Change int to bool.
1728         (solib_keep_data_in_core): Change int to bool.
1729         (in_solib_dynsym_resolve_code): Change int to bool.
1730         (libpthread_name_p): Change int to bool.
1731
1732 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1733
1734         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1735         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1736         (remote_packet_max_chars): New static global.
1737         (show_remote_packet_max_chars): New function.
1738         (remote_target::putpkt_binary): Adjust to use new
1739         remote_packet_max_chars option.
1740         (remote_target::getpkt_or_notif_sane_1): Likewise.
1741         (_initialize_remote): Register new remote-packet-max-chars option.
1742
1743 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1744
1745         * m68k-linux-nat.c: Include gdbarch.h.
1746
1747 2019-11-24  Tom Tromey  <tom@tromey.com>
1748
1749         * symfile.c (read_symbols): Update.
1750         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1751         bool.
1752         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1753         (psym_lookup_symbol, psym_find_last_source_symtab)
1754         (psym_forget_cached_source_info, psym_print_stats)
1755         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1756         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1757         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1758         (psym_find_compunit_symtab_by_address)
1759         (maintenance_print_psymbols, maintenance_info_psymtabs)
1760         (maintenance_check_psymtabs): Update.
1761         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1762         bool.
1763
1764 2019-11-22  Tom Tromey  <tom@tromey.com>
1765
1766         * observable.h: Update comments.
1767
1768 2019-11-22  Tom Tromey  <tromey@adacore.com>
1769
1770         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1771         (print_ada_task_info): Don't try to fetch thread id if task is not
1772         alive.
1773
1774 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1775
1776         * ada-exp.y: Update.
1777         * ada-lang.c (sort_choices): Update.
1778         (ada_print_symbol_signature): Update.
1779         (resolve_subexp): Update.
1780         (ada_parse_renaming): Update.
1781         (ada_read_renaming_var_value): Update.
1782         (lesseq_defined_than): Update.
1783         (remove_extra_symbols): Update.
1784         (remove_irrelevant_renamings): Update.
1785         (ada_add_block_symbols): Update.
1786         (ada_collect_symbol_completion_matches): Update.
1787         (ada_is_renaming_symbol): Update.
1788         (aggregate_assign_from_choices): Update.
1789         (ada_evaluate_subexp): Update.
1790         (ada_has_this_exception_support): Update.
1791         (ada_is_non_standard_exception_sym): Update.
1792         (ada_add_exceptions_from_frame): Update.
1793         (ada_add_global_exceptions): Update.
1794         (ada_print_subexp): Update.
1795         * ax-gdb.c (gen_var_ref): Update.
1796         (gen_maybe_namespace_elt): Update.
1797         (gen_expr_for_cast): Update.
1798         (gen_expr): Update.
1799         * block.h: Update.
1800         * blockframe.c (find_pc_partial_function): Update.
1801         * breakpoint.c (print_breakpoint_location): Update.
1802         (update_static_tracepoint): Update.
1803         * btrace.c (ftrace_print_function_name): Update.
1804         (ftrace_function_switched): Update.
1805         * buildsym.c (find_symbol_in_list): Update.
1806         * c-exp.y: Update.
1807         * c-typeprint.c (c_print_typedef): Update.
1808         (c_type_print_template_args): Update.
1809         * cli/cli-cmds.c (edit_command): Update.
1810         (list_command): Update.
1811         (print_sal_location): Update.
1812         * coffread.c (patch_opaque_types): Update.
1813         (process_coff_symbol): Update.
1814         (coff_read_enum_type): Update.
1815         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1816         (convert_one_symbol): Update.
1817         (hash_symname): Update.
1818         (eq_symname): Update.
1819         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1820         * compile/compile-cplus-types.c (debug_print_scope): Update.
1821         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1822         * compile/compile-object-load.c (get_out_value_type): Update.
1823         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1824         (search_symbol_list): Update.
1825         (cp_lookup_symbol_imports_or_template): Update.
1826         * cp-support.c (overload_list_add_symbol): Update.
1827         * ctfread.c (psymtab_to_symtab): Update.
1828         * dbxread.c (cp_set_block_scope): Update.
1829         * dictionary.c (iter_match_first_hashed): Update.
1830         (iter_match_next_hashed): Update.
1831         (insert_symbol_hashed): Update.
1832         (iter_match_next_linear): Update.
1833         * dictionary.h: Update.
1834         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1835         (locexpr_describe_location_piece): Update.
1836         (locexpr_describe_location_1): Update.
1837         (locexpr_generate_c_location): Update.
1838         (loclist_describe_location): Update.
1839         (loclist_generate_c_location): Update.
1840         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1841         (read_func_scope): Update.
1842         (process_enumeration_scope): Update.
1843         (new_symbol): Update.
1844         (dwarf2_const_value): Update.
1845         (dwarf2_symbol_mark_computed): Update.
1846         * eval.c (evaluate_funcall): Update.
1847         (evaluate_subexp_standard): Update.
1848         * expprint.c (print_subexp_standard): Update.
1849         (dump_subexp_body_standard): Update.
1850         * f-valprint.c (info_common_command_for_block): Update.
1851         * findvar.c (get_hosting_frame): Update.
1852         (default_read_var_value): Update.
1853         * go-lang.c (go_symbol_package_name): Update.
1854         * guile/scm-block.c (bkscm_print_block_smob): Update.
1855         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1856         (gdbscm_symbol_name): Update.
1857         (gdbscm_symbol_linkage_name): Update.
1858         (gdbscm_symbol_print_name): Update.
1859         * infcall.c (get_function_name): Update.
1860         * infcmd.c (jump_command): Update.
1861         (finish_command): Update.
1862         * infrun.c (insert_exception_resume_breakpoint): Update.
1863         * linespec.c (canonicalize_linespec): Update.
1864         (create_sals_line_offset): Update.
1865         (convert_linespec_to_sals): Update.
1866         (complete_label): Update.
1867         (find_label_symbols_in_block): Update.
1868         * m2-typeprint.c (m2_print_typedef): Update.
1869         * mdebugread.c (mdebug_reg_to_regnum): Update.
1870         (parse_symbol): Update.
1871         (mylookup_symbol): Update.
1872         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1873         (list_args_or_locals): Update.
1874         * objc-lang.c (compare_selectors): Update.
1875         (info_selectors_command): Update.
1876         (compare_classes): Update.
1877         (info_classes_command): Update.
1878         (find_imps): Update.
1879         * p-typeprint.c (pascal_print_typedef): Update.
1880         * printcmd.c (build_address_symbolic): Update.
1881         (info_address_command): Update.
1882         (print_variable_and_value): Update.
1883         * python/py-framefilter.c (extract_sym): Update.
1884         (py_print_single_arg): Update.
1885         * python/py-symbol.c (sympy_str): Update.
1886         (sympy_get_name): Update.
1887         (sympy_get_linkage_name): Update.
1888         * python/python.c (gdbpy_rbreak): Update.
1889         * record-btrace.c (btrace_get_bfun_name): Update.
1890         (btrace_call_history): Update.
1891         * rust-lang.c (rust_print_typedef): Update.
1892         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1893         * stabsread.c (stab_reg_to_regnum): Update.
1894         (define_symbol): Update.
1895         (read_enum_type): Update.
1896         (common_block_end): Update.
1897         (cleanup_undefined_types_1): Update.
1898         (scan_file_globals): Update.
1899         * stack.c (print_frame_arg): Update.
1900         (print_frame_args): Update.
1901         (find_frame_funname): Update.
1902         (info_frame_command_core): Update.
1903         (iterate_over_block_locals): Update.
1904         (print_block_frame_labels): Update.
1905         (do_print_variable_and_value): Update.
1906         (iterate_over_block_arg_vars): Update.
1907         (return_command): Update.
1908         * symmisc.c (dump_symtab_1): Update.
1909         (print_symbol): Update.
1910         * symtab.c (eq_symbol_entry): Update.
1911         (symbol_cache_dump): Update.
1912         (lookup_language_this): Update.
1913         (find_pc_sect_line): Update.
1914         (skip_prologue_sal): Update.
1915         (symbol_search::compare_search_syms): Update.
1916         (treg_matches_sym_type_name): Update.
1917         (search_symbols): Update.
1918         (print_symbol_info): Update.
1919         (rbreak_command): Update.
1920         (completion_list_add_symbol): Update.
1921         (find_gnu_ifunc): Update.
1922         (get_symbol_address): Update.
1923         (search_module_symbols): Update.
1924         (info_module_subcommand): Update.
1925         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1926         (SYMBOL_LINKAGE_NAME): Remove.
1927         (SYMBOL_DEMANGLED_NAME): Remove.
1928         (SYMBOL_PRINT_NAME): Remove.
1929         (SYMBOL_SEARCH_NAME): Remove.
1930         * tracepoint.c (set_traceframe_context): Update.
1931         (validate_actionline): Update.
1932         (collection_list::collect_symbol): Update.
1933         (encode_actions_1): Update.
1934         (info_scope_command): Update.
1935         (print_one_static_tracepoint_marker): Update.
1936         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1937         * valops.c (address_of_variable): Update.
1938         (find_overload_match): Update.
1939         (find_oload_champ): Update.
1940
1941 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1942
1943         * ada-lang.c (ada_lookup_simple_minsym): Update.
1944         (ada_collect_symbol_completion_matches): Update.
1945         * ada-tasks.c (read_atcb): Update.
1946         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1947         (amd64_windows_skip_trampoline_code): Update.
1948         * arm-tdep.c (skip_prologue_function): Update.
1949         (arm_skip_stack_protector): Update.
1950         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1951         (arm_wince_skip_main_prologue): Update.
1952         * ax-gdb.c (gen_expr): Update.
1953         * block.c (call_site_for_pc): Update.
1954         * blockframe.c (find_pc_partial_function): Update.
1955         * breakpoint.c (set_breakpoint_location_function): Update.
1956         * btrace.c (ftrace_print_function_name): Update.
1957         (ftrace_function_switched): Update.
1958         * c-valprint.c (print_unpacked_pointer): Update.
1959         * coffread.c (coff_symfile_read): Update.
1960         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1961         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1962         * dwarf-index-write.c (write_psymbols): Update.
1963         * dwarf2loc.c (call_site_to_target_addr): Update.
1964         (func_verify_no_selftailcall): Update.
1965         (tailcall_dump): Update.
1966         (call_site_find_chain_1): Update.
1967         (dwarf_expr_reg_to_entry_parameter): Update.
1968         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1969         * eval.c (evaluate_funcall): Update.
1970         (evaluate_subexp_standard): Update.
1971         (evaluate_subexp_for_sizeof): Update.
1972         * expprint.c (print_subexp_standard): Update.
1973         (dump_subexp_body_standard): Update.
1974         * frame.c (get_prev_frame_always_1): Update.
1975         * frv-tdep.c (frv_skip_main_prologue): Update.
1976         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1977         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1978         (gnuv3_get_typename_from_type_info): Update.
1979         (gnuv3_skip_trampoline): Update.
1980         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1981         * i386-tdep.c (i386_skip_main_prologue): Update.
1982         (i386_pe_skip_trampoline_code): Update.
1983         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1984         * infcall.c (get_function_name): Update.
1985         * linespec.c (minsym_found): Update.
1986         * linux-fork.c (info_checkpoints_command): Update.
1987         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1988         (m32c_m16c_pointer_to_address): Update.
1989         * maint.c (maintenance_translate_address): Update.
1990         * minsyms.c (add_minsym_to_hash_table): Update.
1991         (add_minsym_to_demangled_hash_table): Update.
1992         (lookup_minimal_symbol_mangled): Update.
1993         (lookup_minimal_symbol_demangled): Update.
1994         (lookup_minimal_symbol_linkage): Update.
1995         (lookup_minimal_symbol_text): Update.
1996         (lookup_minimal_symbol_by_pc_name): Update.
1997         (minimal_symbol_is_less_than): Update.
1998         (compact_minimal_symbols): Update.
1999         (build_minimal_symbol_hash_tables): Update.
2000         (find_solib_trampoline_target): Update.
2001         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2002         (mips_skip_pic_trampoline_code): Update.
2003         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2004         * objc-lang.c (info_selectors_command): Update.
2005         (info_classes_command): Update.
2006         (find_methods): Update.
2007         (find_imps): Update.
2008         * p-valprint.c (pascal_val_print): Update.
2009         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2010         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2011         * printcmd.c (build_address_symbolic): Update.
2012         (info_symbol_command): Update.
2013         * psymtab.c (psymbol_name_matches): Update.
2014         (match_partial_symbol): Update.
2015         (lookup_partial_symbol): Update.
2016         (print_partial_symbols): Update.
2017         (sort_pst_symbols): Update.
2018         (maintenance_check_psymtabs): Update.
2019         * python/py-framefilter.c (py_print_frame): Update.
2020         * python/python.c (gdbpy_rbreak): Update.
2021         * record-btrace.c (btrace_get_bfun_name): Update.
2022         (btrace_call_history): Update.
2023         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2024         (rs6000_skip_trampoline_code): Update.
2025         * sol-thread.c (info_cb): Update.
2026         * stabsread.c (scan_file_globals): Update.
2027         * stack.c (find_frame_funname): Update.
2028         (info_frame_command_core): Update.
2029         * symmisc.c (dump_msymbols): Update.
2030         * symtab.c (symbol_natural_name): Rename to..,
2031         (general_symbol_info::natural_name): ...this.
2032         (symbol_demangled_name): Rename to...
2033         (general_symbol_info::demangled_name): ...this.
2034         (symbol_search_name): Rename to...
2035         (general_symbol_info::search_name): ...this.
2036         (symbol_matches_search_name): Update.
2037         (find_pc_sect_line): Update.
2038         (skip_prologue_sal): Update.
2039         (search_symbols): Update.
2040         (print_msymbol_info): Update.
2041         (rbreak_command): Update.
2042         (completion_list_add_msymbol): Update.
2043         (completion_list_objc_symbol): Update.
2044         (get_msymbol_address): Update.
2045         * symtab.h (struct general_symbol_info): Add member functions
2046         natural_name (), linkage_name (), print_name (), demangled_name (),
2047         and search_name ().
2048         (SYMBOL_NATURAL_NAME): Update.
2049         (symbol_natural_name): Move to a member function on general_symbol_info.
2050         (SYMBOL_DEMANGLED_NAME): Update.
2051         (symbol_demangled_name): Move to a member function on
2052         general_symbol_info.
2053         (SYMBOL_SEARCH_NAME): Update.
2054         (symbol_search_name): Move to a member function on general_symbol_info.
2055         (MSYMBOL_NATURAL_NAME): Remove.
2056         (MSYMBOL_LINKAGE_NAME): Remove.
2057         (MSYMBOL_PRINT_NAME): Remove.
2058         (MSYMBOL_DEMANGLED_NAME): Remove.
2059         (MSYMBOL_SEARCH_NAME): Remove.
2060         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2061
2062 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2063
2064         * symtab.c (create_demangled_names_hash): Use per_bfd->
2065         minimal_symbol_count for computing the initial size, if greater
2066         than our default size.
2067
2068 2019-11-22  Tom de Vries  <tdevries@suse.de>
2069
2070         * contrib/words.sh: Improve words extraction.
2071
2072 2019-11-22  Tom de Vries  <tdevries@suse.de>
2073
2074         * contrib/words.sh: Combine sed invocations.
2075
2076 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2077
2078         * Makefile.in: Update.
2079         * demangle.c: Rename to...
2080         * gdb-demangle.c: ..this.
2081         (is_cplus_marker): Change return type to bool.
2082         (_initialize_demangler): Rename to...
2083         (_initialize_gdb_demangle): ...this.
2084         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2085         * symtab.h (demangle): Remove declaration; instead include
2086         gdb-demangle.h.
2087
2088 2019-11-21  Tom Tromey  <tromey@adacore.com>
2089
2090         * gdbsupport/format.c (format_pieces): Parse %I64d.
2091         * unittests/format_pieces-selftests.c (test_windows_formats): New
2092         function.
2093         (run_tests): Call it.
2094
2095 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2096
2097         Byte reverse display of variables with DW_END_big, DW_END_little
2098         (DW_AT_endianity) dwarf attributes if different than the native
2099         byte order.
2100         * ada-lang.c (ada_value_binop):
2101         Use type_byte_order instead of gdbarch_byte_order.
2102         * ada-valprint.c (printstr):
2103         (ada_val_print_string):
2104         * ada-lang.c (value_pointer):
2105         (ada_value_binop):
2106         Use type_byte_order instead of gdbarch_byte_order.
2107         * c-lang.c (c_get_string):
2108         Use type_byte_order instead of gdbarch_byte_order.
2109         * c-valprint.c (c_val_print_array):
2110         Use type_byte_order instead of gdbarch_byte_order.
2111         * cp-valprint.c (cp_print_class_member):
2112         Use type_byte_order instead of gdbarch_byte_order.
2113         * dwarf2loc.c (rw_pieced_value):
2114         Use type_byte_order instead of gdbarch_byte_order.
2115         * dwarf2read.c (read_base_type): Handle DW_END_big,
2116         DW_END_little
2117         * f-lang.c (f_get_encoding):
2118         Use type_byte_order instead of gdbarch_byte_order.
2119         * findvar.c (default_read_var_value):
2120         Use type_byte_order instead of gdbarch_byte_order.
2121         * gdbtypes.c (check_types_equal):
2122         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2123         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2124         and TYPE_ENDIANITY_LITTLE if set.
2125         (type_byte_order): new function.
2126         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2127         (struct main_type) <flag_endianity_not_default>:
2128         New field.
2129         (type_byte_order): New function.
2130         * infcmd.c (default_print_one_register_info):
2131         Use type_byte_order instead of gdbarch_byte_order.
2132         * p-lang.c (pascal_printstr):
2133         Use type_byte_order instead of gdbarch_byte_order.
2134         * p-valprint.c (pascal_val_print):
2135         Use type_byte_order instead of gdbarch_byte_order.
2136         * printcmd.c (print_scalar_formatted):
2137         Use type_byte_order instead of gdbarch_byte_order.
2138         * solib-darwin.c (darwin_current_sos):
2139         Use type_byte_order instead of gdbarch_byte_order.
2140         * solib-svr4.c (solib_svr4_r_ldsomap):
2141         Use type_byte_order instead of gdbarch_byte_order.
2142         * stap-probe.c (stap_modify_semaphore):
2143         Use type_byte_order instead of gdbarch_byte_order.
2144         * target-float.c (target_float_same_format_p):
2145         Use type_byte_order instead of gdbarch_byte_order.
2146         * valarith.c (scalar_binop):
2147         (value_bit_index):
2148         Use type_byte_order instead of gdbarch_byte_order.
2149         * valops.c (value_cast):
2150         Use type_byte_order instead of gdbarch_byte_order.
2151         * valprint.c (generic_emit_char):
2152         (generic_printstr):
2153         (val_print_string):
2154         Use type_byte_order instead of gdbarch_byte_order.
2155         * value.c (unpack_long):
2156         (unpack_bits_as_long):
2157         (unpack_value_bitfield):
2158         (modify_field):
2159         (pack_long):
2160         (pack_unsigned_long):
2161         Use type_byte_order instead of gdbarch_byte_order.
2162         * findvar.c (unsigned_pointer_to_address):
2163         (signed_pointer_to_address):
2164         (unsigned_address_to_pointer):
2165         (address_to_signed_pointer):
2166         (default_read_var_value):
2167         (default_value_from_register):
2168         Use type_byte_order instead of gdbarch_byte_order.
2169         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2170         Use type_byte_order instead of gdbarch_byte_order.
2171         * riscv-tdep.c (riscv_print_one_register_info):
2172         Use type_byte_order instead of gdbarch_byte_order.
2173
2174 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2175
2176         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2177         (current_ui_gdb_stdin_ptr): Likewise.
2178         (current_ui_gdb_stderr_ptr): Likewise.
2179         (current_ui_gdb_stdlog_ptr): Likewise.
2180         (current_ui_current_uiout_ptr): Likewise.
2181         (gen_ret_current_ui_field_ptr): Remove.
2182
2183 2019-11-21  Tom de Vries  <tdevries@suse.de>
2184
2185         PR gdb/24956
2186         * cli/cli-script.c (execute_control_command): Only switch to
2187         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2188
2189 2019-11-19  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2192         Now static.  Change type of "name".
2193         (tui_set_win_height_command): Don't copy "arg".
2194         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2195         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2196
2197 2019-11-19  Ali Tamur <tamur@google.com>
2198
2199         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2200         "if (attr != nullptr)".
2201         (dwarf2_find_base_address): Likewise.
2202         (dwarf2_build_include_psymtabs): Likewise.
2203         (read_cutu_die_from_dwo): Likewise.
2204         (read_func_scope): Likewise.
2205         (read_call_site_scope): Likewise.
2206         (dwarf2_get_pc_bounds): Likewise.
2207         (dwarf2_record_block_ranges): Likewise.
2208         (dwarf2_add_field): Likewise.
2209         (dwarf2_add_member_fn): Likewise.
2210         (read_structure_type): Likewise.
2211         (read_enumeration_type): Likewise.
2212         (read_array_type): Likewise.
2213         (read_array_order): Likewise.
2214         (read_set_type): Likewise.
2215         (read_common_block): Likewise.
2216         (read_tag_reference_type): Likewise.
2217         (read_tag_string_type): Likewise.
2218         (read_subroutine_type): Likewise.
2219         (read_base_type): Likewise.
2220         (read_subrange_type): Likewise.
2221         (new_symbol): Likewise.
2222         (prepare_one_comp_unit): Likewise.
2223
2224 2019-11-19  Tom Tromey  <tromey@adacore.com>
2225
2226         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2227         result in error when DebugActiveProcess fails.
2228
2229 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2230             Pedro Alves  <palves@redhat.com>
2231
2232         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2233         * target.c (target_stack::push): Call 'unpush' if there's a
2234         target on top of the stack.
2235
2236 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2237
2238         * python/py-block.c (blpy_dealloc): Call tp_free.
2239         (blpy_block_syms_dealloc): Likewise.
2240         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2241         * python/py-inferior.c (infpy_dealloc): Likewise.
2242         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2243         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2244         * python/py-symbol.c (sympy_dealloc): Likewise.
2245         * python/py-symtab.c (stpy_dealloc): Likewise.
2246         * python/py-type.c (typy_iterator_dealloc): Likewise.
2247
2248 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2251         constructor instead of using a class initializer.
2252
2253 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2254
2255         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2256         * configure: Regenerate.
2257         * configure.ac: Don't source common.host.
2258         * gdbsupport/common.host: Remove.
2259         * gdbsupport/mingw-strerror.c: Remove.
2260         * gdbsupport/posix-strerror.c: Rename to...
2261         * gdbsupport/safe-strerror.c: ...this.
2262
2263 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2264
2265         * maint.c (scoped_command_stats::print_time): Use localtime_r
2266         instead of localtime (provided through gnulib if necessary).
2267         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2268         of ctime.
2269
2270 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2271
2272         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2273         avoid compile errors.
2274
2275 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2276
2277         * config.in: Regenerate.
2278         * configure: Regenerate.
2279         * gdbsupport/common.m4: No longer check for strerror_r.
2280         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2281         POSIX version of strerror_r, now that gnulib provides it if
2282         necessary.
2283
2284 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * README (`configure' options): Update.
2287
2288 2019-11-14  Tom Tromey  <tromey@adacore.com>
2289
2290         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2291         expected type for the RHS if the LHS is a convenience variable.
2292
2293 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2294
2295         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2296         Provide explicit default and copy constructor.
2297
2298 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2299
2300         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2301         only call Py_INCREF (newbp) in the bppy_pending_object case.
2302
2303 2019-11-13  Tom Tromey  <tromey@adacore.com>
2304
2305         PR build/25182:
2306         * psympriv.h (partial_symbol): Remove static assert.
2307         * symtab.h (general_symbol_info, symbol): Remove static assert.
2308
2309 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * gdbsupport/format.c (format_pieces::format_pieces): Support
2312         printf 'z' size modifier.
2313         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2314         * printcmd.c (ui_printf):  Handle size_t_arg.
2315         * ui-out.c (ui_out::vmessage): Likewise.
2316         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2317         function.
2318         (run_tests): Call test_format_int_sizes.
2319
2320 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * ada-exp.y (write_ambiguous_var): Update.
2323         * buildsym.c (add_symbol_to_list): Update.
2324         * dwarf2read.c (read_variable): Update.
2325         (new_symbol): Update.
2326         * jit.c (finalize_symtab): Update.
2327         * language.c (language_alloc_type_symbol): Update.
2328         * symtab.c (fixup_symbol_section): Update.
2329         (initialize_objfile_symbol_1): Move code to...
2330         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2331         (allocate_symbol): Update.
2332         (allocate_template_symbol): Update.
2333         (get_symbol_address): Update.
2334         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2335         of having as a field, and add a constructor.
2336         (SYMBOL_VALUE): Update.
2337         (SYMBOL_VALUE_ADDRESS): Update.
2338         (SET_SYMBOL_VALUE_ADDRESS): Update.
2339         (SYMBOL_VALUE_BYTES): Update.
2340         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2341         (SYMBOL_BLOCK_VALUE): Update.
2342         (SYMBOL_VALUE_CHAIN): Update.
2343         (SYMBOL_LANGUAGE): Update.
2344         (SYMBOL_SECTION): Update.
2345         (SYMBOL_OBJ_SECTION): Update.
2346         (SYMBOL_SET_LANGUAGE): Update.
2347         (SYMBOL_SET_LINKAGE_NAME): Update.
2348         (SYMBOL_SET_NAMES): Update.
2349         (SYMBOL_NATURAL_NAME): Update.
2350         (SYMBOL_LINKAGE_NAME): Update.
2351         (SYMBOL_DEMANGLED_NAME): Update.
2352         (SYMBOL_SEARCH_NAME): Update.
2353         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2354         (struct symbol): Update.
2355         (struct template_symbol): Update.
2356         (struct rust_vtable_symbol): Update.
2357         * xcoffread.c (SYMBOL_DUP): Update.
2358
2359 2019-11-12  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-layout.c (show_layout): Set current_layout.
2362         (show_source_disasm_command, show_data)
2363         (show_source_or_disasm_and_command): Don't set current_layout.
2364
2365 2019-11-12  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2368
2369 2019-11-12  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-win.c (resize_message): New global.
2372         (show_tui_resize_message): New function.
2373         (tui_async_resize_screen): Print message if requested.
2374         (_initialize_tui_win): Add tui-resize-message setting.
2375         * NEWS: Add entry for new commands.
2376
2377 2019-11-11  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2380         functions.
2381
2382 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2383
2384         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2385
2386 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2389         function.
2390         * python/python-internal.h (gdbpy_lookup_static_symbols):
2391         Declare new function.
2392         * python/python.c (python_GdbMethods): Add
2393         gdb.lookup_static_symbols method.
2394         * NEWS: Mention gdb.lookup_static_symbols.
2395
2396 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2399         static block of current object file first.  Also fix typo in
2400         header comment.
2401
2402 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * stack.c (set_last_displayed_sal): Delete.
2405         (last_displayed_sal_valid): Delete.
2406         (last_displayed_pspace): Delete.
2407         (last_displayed_addr): Delete.
2408         (last_displayed_symtab): Delete.
2409         (last_displayed_line): Delete.
2410         (class last_displayed_symtab_info_type): New.
2411         (last_displayed_symtab_info): New static global variable.
2412         (print_frame_info): Call methods on last_displayed_symtab_info.
2413         (clear_last_displayed_sal): Update header comment, and make use of
2414         last_displayed_symtab_info.
2415         (last_displayed_sal_is_valid): Likewise.
2416         (get_last_displayed_pspace): Likewise.
2417         (get_last_displayed_addr): Likewise.
2418         (get_last_displayed_symtab): Likewise.
2419         (get_last_displayed_line): Likewise.
2420         (get_last_displayed_sal): Likewise.
2421         * stack.h (clear_last_displayed_sal): Update header comment.
2422         (last_displayed_sal_is_valid): Likewise.
2423         (get_last_displayed_pspace): Likewise.
2424         (get_last_displayed_addr): Likewise.
2425         (get_last_displayed_symtab): Likewise.
2426         (get_last_displayed_line): Likewise.
2427         (get_last_displayed_sal): Likewise.
2428
2429 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * stack.c (frame_show_address): Convert return type to bool.
2432         * stack.h (frame_show_address): Likewise, and update header
2433         comment.
2434
2435 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2438         * unittests/vec-utils-selftests.c: New file.
2439         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2440
2441 2019-11-10  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2444         (tui_highlight_win): Likewise.
2445         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2446         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2447         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2448         Don't set can_highlight.
2449
2450 2019-11-10  Tom Tromey  <tom@tromey.com>
2451
2452         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2453         Remove unused declaration.
2454
2455 2019-11-08  Tom Tromey  <tromey@adacore.com>
2456
2457         * top.c (read_command_file): Update.
2458         (command_line_input): Make return type const.
2459         * python/py-gdb-readline.c: Update.
2460         * linespec.c (decode_line_2): Update.
2461         * defs.h (command_line_input): Make return type const.
2462         * cli/cli-script.c (read_next_line): Make return type const.
2463         * ada-lang.c (get_selections): Update.
2464
2465 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2466
2467         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2468         * mi/mi-main.c (output_cores): Likewise.
2469         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2470         (linux_xfer_osdata_modules): Likewise.
2471         * remote.c (register_remote_support_xml): Likewise.
2472         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2473         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2474
2475 2019-11-06  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-interp.c: Don't include readline.h.
2478         * tui/tui-hooks.c: Don't include readline.h.
2479         * symmisc.c: Include tilde.h, not readline.h.
2480         * symfile.c: Include tilde.h, not readline.h.
2481         * source.c: Include tilde.h, not readline.h.
2482         * solib.c: Include tilde.h, not readline.h.
2483         * psymtab.c: Include tilde.h, not readline.h.
2484         * exec.c: Include tilde.h, not readline.h.
2485         * corelow.c: Include tilde.h, not readline.h.
2486         * cli/cli-dump.c: Include tilde.h, not readline.h.
2487         * cli/cli-cmds.c: Don't include readline.h.
2488
2489 2019-11-05  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2492         (tui_disassemble): Set addr_size.
2493         (tui_disasm_window::set_contents): Use addr_size.
2494
2495 2019-11-05  Tom Tromey  <tom@tromey.com>
2496
2497         * rust-lang.c (rust_language_defn): Update.
2498         * python/py-value.c (valpy_string): Call c_get_string.
2499         * p-lang.c (pascal_language_defn): Update.
2500         * opencl-lang.c (opencl_language_defn): Update.
2501         * objc-lang.c (objc_language_defn): Update.
2502         * m2-lang.c (m2_language_defn): Update.
2503         * language.c (unknown_language_defn, auto_language_defn): Update.
2504         (default_get_string): Remove.
2505         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2506         * go-lang.c (go_language_defn): Update.
2507         * f-lang.c (f_language_defn): Update.
2508         * d-lang.c (d_language_defn): Update.
2509         * c-lang.c (c_language_defn, cplus_language_defn)
2510         (asm_language_defn, minimal_language_defn): Update.
2511         * ada-lang.c (ada_language_defn): Update.
2512         * language.h (struct language_defn) <la_get_string>: Remove.
2513         (LA_GET_STRING): Remove.
2514         (default_get_string): Don't declare.
2515
2516 2019-11-05  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-source.h (struct tui_source_window): Inline
2519         constructor.  Remove destructor.
2520         <style_changed, m_observable>: Move to superclass.
2521         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2522         (struct tui_source_window_base): Move private members to end.
2523         <style_changed, m_observable>: Move from tui_source_window.
2524         * tui/tui-winsource.c (tui_copy_source_line): Move from
2525         tui-source.c.  Rename from copy_source_line.  Add special handling
2526         for negative line number.
2527         (tui_source_window_base::style_changed): Move from
2528         tui_source_window.
2529         (tui_source_window_base): Register observer.
2530         (~tui_source_window_base): New.
2531         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2532         rename.
2533         (tui_source_window::set_contents): Use tui_copy_source_line.
2534         (tui_source_window::tui_source_window): Move to tui-source.h.
2535         (tui_source_window::~tui_source_window): Remove.
2536         (tui_source_window::style_changed): Move to superclass.
2537         * tui/tui-disasm.c (tui_disassemble): Create string file with
2538         styling, when possible.  Add "addr_size" parameter.
2539         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2540         Don't compute maximum size.
2541         (len_without_escapes): New function
2542
2543 2019-11-05  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2546         std::string.
2547         * tui/tui-winsource.c (tui_show_source_line): Update.
2548         * tui/tui-source.c (tui_source_window::set_contents): Update.
2549         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2550
2551 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2552
2553         * symtab.h (gdb_static_assert): Put && operator at the beginning
2554         of the line instead of the end.
2555
2556 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2557
2558         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2559         and sizeof (symbol).
2560         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2561
2562 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2563
2564         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2565         * configure.host: Mark *-*-solaris2.10* obsolete.
2566         * configure.tgt: Mark Solaris < 11 obsolete.
2567         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2568         Update target triplet.
2569
2570 2019-11-01  Tom Tromey  <tromey@adacore.com>
2571
2572         * utils.c (print_sys_errmsg): Simplify.
2573
2574 2019-11-01  Tom Tromey  <tromey@adacore.com>
2575
2576         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2577
2578 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2579
2580         * configure: Regenerate.
2581         * configure.ac: Remove check for strerror_r.
2582         * gdbsupport/common.m4: Check for strerror_r.
2583
2584 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2585
2586         PR gdb/25124
2587
2588         * arm-tdep.c (arm_per_objfile): Rename to ...
2589         (arm_per_bfd): ... this.
2590         (arm_objfile_data_key): Rename to ...
2591         (arm_bfd_data_key): ... this.
2592         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2593         data.
2594         (arm_record_special_symbol): Likewise.
2595
2596 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2597
2598         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2599         end.
2600         * c-typeprint.c (c_print_typedef): Likewise.
2601         * f-typeprint.c (f_print_typedef): Likewise.
2602         * m2-typeprint.c (m2_print_typedef): Likewise.
2603         * p-typeprint.c (pascal_print_typedef): Likewise.
2604         * rust-lang.c (rust_print_typedef): Likewise.
2605         * symtab.c (print_symbol_info): Print a newline after calling
2606         typedef_print.
2607
2608 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * symtab.c (info_module_cmdlist): New variable.
2611         (info_module_command): New function.
2612         (search_module_symbols): New function.
2613         (info_module_subcommand): New function.
2614         (struct info_modules_var_func_options): New struct.
2615         (info_modules_var_func_options_defs): New variable.
2616         (make_info_modules_var_func_options_def_group): New function.
2617         (info_module_functions_command): New function.
2618         (info_module_variables_command): New function.
2619         (info_module_var_func_command_completer): New function.
2620         (_initialize_symtab): Register new 'info module functions' and
2621         'info module variables' commands.
2622         * symtab.h (typedef symbol_search_in_module): New typedef.
2623         (search_module_symbols): Declare new function.
2624         * NEWS: Mention new commands.
2625
2626 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2627
2628         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2629         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2630         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2631         MODULES_DOMAIN.
2632         (scan_partial_symbols): Only create partial module symbols for non
2633         declarations.
2634         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2635         and MODULES_DOMAIN.
2636         * symtab.c (search_domain_name): Likewise.
2637         (search_symbols): Likewise.
2638         (print_symbol_info): Likewise.
2639         (symtab_symbol_info): Likewise.
2640         (info_modules_command): New function.
2641         (_initialize_symtab): Register 'info modules' command.
2642         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2643         * NEWS: Mention new 'info modules' command.
2644
2645 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2646
2647         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2648         and $_gdb_maint_setting_str.
2649
2650 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2651
2652         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2653         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2654         (str_value_from_setting, gdb_setting_str_internal_fn)
2655         (gdb_maint_setting_str_internal_fn): New functions.
2656         (_initialize_cli_cmds): Define the new convenience functions.
2657         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2658         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2659
2660 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2661
2662         * agent.c (set_can_use_agent): When the setting is turned on,
2663         look up agent symbols if we don't have them yet.
2664         (agent_new_objfile): Don't look up agent symbols when the agent
2665         setting is off.
2666
2667 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2668
2669         * config.in: Regenerate.
2670
2671 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2672
2673         * configure: Regenerate.
2674         * configure.ac: Check for strerror_r.
2675         * gdbsupport/common-utils.h (safe_strerror): Change return value
2676         to const char * and document that this function is now threadsafe.
2677         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2678         thread_local and call strerror_r, if available.
2679         * utils.c (perror_string): Update.
2680         (print_sys_errmsg): Update.
2681
2682 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2683
2684         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2685         objfile_key.
2686         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2687         objfile to fetch per-bfd data.
2688         (arm_find_exidx_entry): Likewise.
2689
2690 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2691
2692         * gdbsupport/agent.c (debug_agent): Change type to bool.
2693         (use_agent): Likewise.
2694         (all_agent_symbols_look_up): Likewise.
2695         (agent_loaded_p): Change return value to bool.
2696         (agent_look_up_symbols): Update.
2697         (agent_capability_check): Change return value to bool.
2698         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2699         (debug_agent): Change type to bool.
2700         (use_agent): Likewise.
2701         (agent_capability_check): Change return value to bool.
2702
2703 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2704
2705         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2706         (build_minimal_symbol_hash_tables): Code to clear the table moved
2707         to clear_minimal_symbol_hash_tables.
2708         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2709         when needed.
2710
2711 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2712
2713         * infcmd.c: Remove includes.
2714         * infrun.c: Remove includes.
2715
2716 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2717
2718         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2719         (grow_vect): Remove declaration.
2720         (ada_type_of_array): Remove declaration.
2721         (ada_update_initial_language): Remove declaration.
2722         (ada_fold_name): Remove declaration.
2723         (ada_fill_in_ada_prototype): Remove declaration.
2724         (user_select_syms): Remove declaration.
2725         (get_selections): Remove declaration.
2726         (ada_tag_type): Remove declaration.
2727         (ada_value_tag): Remove declaration.
2728         (ada_is_others_clause): Remove declaration.
2729         (ada_in_variant): Remove declaration.
2730         (ada_value_struct_elt): Remove declaration.
2731         (ada_attribute_name): Remove declaration.
2732         (ada_system_address_type): Remove declaration.
2733         * ada-lang.c (ada_watch_location_expression): Make static.
2734         (GROW_VECT): Move here from ada-lang.h.
2735         (grow_vect): Make static.
2736         (ada_update_initial_language): Make static.
2737         (ada_fold_name): Make static.
2738         (ada_type_of_array): Make static.
2739         (encoded_ordered_before): Move up.
2740         (sort_choices): Move up.
2741         (print_signatures): Move up.
2742         (ada_print_symbol_signature): Move up.
2743         (get_selections): Move up and make static.
2744         (user_select_syms): Move up and make static.
2745         (ada_value_struct_elt): Move up and make static.
2746         (ada_tag_type): Make static.
2747         (ada_value_tag): Make static.
2748         (ada_is_others_clause): Make static.
2749         (ada_in_variant): Make static.
2750         (ada_attribute_name): Make static.
2751
2752 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2753
2754         * ada-lang.c: Remove includes.
2755         * ada-typeprint.c: Remove includes.
2756         * ada-valprint.c: Remove includes.
2757
2758 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2759
2760         * addrmap.c: Add static assertions of type size, moved from
2761         _initialize_addrmap.
2762         (_initialize_addrmap): Remove.
2763
2764 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2765
2766         * coffread.c (record_minimal_symbol): Update.
2767         (process_coff_symbol): Update.
2768         * dbxread.c (read_dbx_symtab): Update.
2769         * dwarf2read.c (add_partial_symbol): Update.
2770         (fixup_go_packaging): Update.
2771         (load_partial_dies): Update.
2772         (new_symbol): Update.
2773         * elfread.c (record_minimal_symbol): Change signature to use
2774         gdb::string_view instead of name+len.
2775         (elf_symtab_read): Update.
2776         (elf_rel_plt_read): Update.
2777         * mdebugread.c (parse_partial_symbols): Update.
2778         (handle_psymbol_enumerators): Update.
2779         (new_symbol): Update.
2780         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2781         to use gdb::string_view instead of name+len.
2782         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2783         * psympriv.h (add_psymbol_to_list): Likewise.
2784         * psymtab.c (add_psymbol_to_bcache): Likewise.
2785         (add_psymbol_to_list): Likewise.
2786         * stabsread.c (define_symbol): Update.
2787         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2788         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2789         (symbol_set_names): Likewise.
2790         * xcoffread.c (scan_xcoff_symtab): Update.
2791
2792 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2793
2794         * symtab.h (symbol_set_names): Document that copy_name must be
2795         set to true for non-nullterminated strings.
2796         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2797         linkage_name if the entry was not found and we need to demangle.
2798
2799 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2800
2801         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2802         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2803         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2804         * gdbsupport/gdb_binary_search.h: New file.
2805
2806 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2807
2808         * NEWS: Mention new --with-system-gdbinit-dir option.
2809         * config.in: Regenerate.
2810         * configure: Regenerate.
2811         * configure.ac: Add new option --with-system-gdbinit-dir.
2812         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2813         for a ".gdb" suffix.
2814         * main.c (get_init_files): Change system_gdbinit argument to
2815         a vector and return the files in SYSTEM_GDBINIT_DIR in
2816         addition to SYSTEM_GDBINIT.
2817         (captured_main_1): Update.
2818         (print_gdb_help): Update.
2819         * top.c (print_gdb_configuration): Also print the value of
2820         SYSTEM_GDBINIT_DIR.
2821
2822 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2823
2824         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2825         that takes gdb::string_view arguments.
2826
2827 2019-10-26  Tom de Vries  <tdevries@suse.de>
2828
2829         * aarch64-linux-tdep.c: Fix typos in comments.
2830         * aarch64-tdep.c: Same.
2831         * ada-lang.c: Same.
2832         * amd64-nat.c: Same.
2833         * arc-tdep.c: Same.
2834         * arch/aarch64-insn.c: Same.
2835         * block.c: Same.
2836         * breakpoint.h: Same.
2837         * btrace.h: Same.
2838         * c-varobj.c: Same.
2839         * cli/cli-decode.c: Same.
2840         * cli/cli-script.c: Same.
2841         * cli/cli-utils.h: Same.
2842         * coff-pe-read.c: Same.
2843         * coffread.c: Same.
2844         * compile/compile-cplus-symbols.c: Same.
2845         * compile/compile-object-run.c: Same.
2846         * completer.c: Same.
2847         * corelow.c: Same.
2848         * cp-support.c: Same.
2849         * demangle.c: Same.
2850         * dwarf-index-write.c: Same.
2851         * dwarf2-frame.c: Same.
2852         * dwarf2-frame.h: Same.
2853         * eval.c: Same.
2854         * frame-base.h: Same.
2855         * frame.h: Same.
2856         * gdbcmd.h: Same.
2857         * gdbtypes.h: Same.
2858         * gnu-nat.c: Same.
2859         * guile/scm-objfile.c: Same.
2860         * i386-tdep.c: Same.
2861         * i386-tdep.h: Same.
2862         * infcall.c: Same.
2863         * infcall.h: Same.
2864         * linux-nat.c: Same.
2865         * m68k-tdep.c: Same.
2866         * macroexp.c: Same.
2867         * memattr.c: Same.
2868         * mi/mi-cmd-disas.c: Same.
2869         * mi/mi-getopt.h: Same.
2870         * mi/mi-main.c: Same.
2871         * minsyms.c: Same.
2872         * nat/aarch64-sve-linux-sigcontext.h: Same.
2873         * objfiles.h: Same.
2874         * ppc-linux-nat.c: Same.
2875         * ppc-linux-tdep.c: Same.
2876         * ppc-tdep.h: Same.
2877         * progspace.h: Same.
2878         * prologue-value.h: Same.
2879         * python/py-evtregistry.c: Same.
2880         * python/py-instruction.h: Same.
2881         * record-btrace.c: Same.
2882         * record-full.c: Same.
2883         * remote.c: Same.
2884         * rs6000-tdep.c: Same.
2885         * ser-tcp.c: Same.
2886         * sol-thread.c: Same.
2887         * sparc-sol2-tdep.c: Same.
2888         * sparc64-tdep.c: Same.
2889         * stabsread.c: Same.
2890         * symfile.c: Same.
2891         * symtab.h: Same.
2892         * target.c: Same.
2893         * tracepoint.c: Same.
2894         * tui/tui-data.h: Same.
2895         * tui/tui-io.c: Same.
2896         * tui/tui-win.c: Same.
2897         * tui/tui.c: Same.
2898         * unittests/rsp-low-selftests.c: Same.
2899         * user-regs.h: Same.
2900         * utils.c: Same.
2901         * utils.h: Same.
2902         * valarith.c: Same.
2903         * valops.c: Same.
2904         * valprint.c: Same.
2905         * valprint.h: Same.
2906         * value.c: Same.
2907         * value.h: Same.
2908         * varobj.c: Same.
2909         * x86-nat.h: Same.
2910         * xtensa-tdep.c: Same.
2911
2912 2019-10-25  Ali Tamur <tamur@google.com>
2913
2914         * charset.c (find_charset_names): Reflect API change.
2915
2916 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2917
2918         * symtab.c (struct demangled_name_entry): Change demangled name
2919         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2920         part of the struct anymore.
2921         (symbol_set_names): No longer obstack allocate + copy the demangled
2922         name, just store the allocated name from bfd.
2923
2924 2019-10-25  Tom Tromey  <tromey@adacore.com>
2925
2926         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2927         (bsearch_cie_cmp, add_cie): Remove.
2928         (find_cie): Reimplement.
2929         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2930         (dwarf2_build_frame_info): Update.
2931
2932 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2933
2934         PR gdb/25126
2935         * symfile.c (reread_symbols): Call forget_cached_source_info to
2936         clear the stale source cache.
2937
2938 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2939
2940         * configure: Regenerate.
2941         * configure.ac: Remove code that sets python_has_threads.
2942
2943 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2944
2945         * config.in: Regenerate.
2946         * configure: Regenerate.
2947         * configure.ac: Remove the code that uses sed to get the python
2948         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2949
2950 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2953         error paths.
2954
2955 2019-10-23  Tom Tromey  <tom@tromey.com>
2956
2957         * arc-tdep.c: Remove ".." from include.
2958         * frv-tdep.c: Remove ".." from include.
2959         * lm32-tdep.c: Remove ".." from include.
2960         * microblaze-tdep.c: Remove ".." from include.
2961         * or1k-tdep.h: Remove ".." from include.
2962         * s12z-tdep.c: Remove ".." from include.
2963         * Makefile.in (OPCODES_CFLAGS): Add comment.
2964         (TOP_CFLAGS): New variable.
2965         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2966
2967 2019-10-23  Tom Tromey  <tom@tromey.com>
2968
2969         * Makefile.in (READLINE_DIR): Update.
2970
2971 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2972
2973         * infcall.c (call_function_by_hand_dummy): Fix the function
2974         comment.  And extract out a code section into...
2975         (reserve_stack_space): ...this new function.
2976
2977 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2978
2979         * infcall.c (value_arg_coerce): Remove an unused parameter.
2980         (call_function_by_hand_dummy): Update the call to
2981         'value_arg_coerce'.
2982
2983 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2984
2985         * infcall.c (call_function_by_hand_dummy): Refactor.
2986
2987 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2988
2989         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2990
2991 2019-10-23  Tom Tromey  <tom@tromey.com>
2992
2993         * configure: Rebuild.
2994         * configure.ac: Don't check for sigprocmask.
2995         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2996
2997 2019-10-23  Tom Tromey  <tom@tromey.com>
2998
2999         * configure: Rebuild.
3000         * acinclude.m4: Use m4_include, not sinclude.
3001
3002 2019-10-23  Tom de Vries  <tdevries@suse.de>
3003
3004         PR breakpoints/24687
3005         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3006
3007 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3008
3009         * symtab.c (struct demangled_name_entry) <language>: Change from
3010         bitfield to regular variable.
3011
3012 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3013
3014         * symtab.c (struct demangled_name_entry): Add a constructor.
3015         (free_demangled_name_entry): New function to call the destructor
3016         for demangled_name_entry.
3017         (create_demangled_names_hash): Pass free_demangled_name_entry to
3018         htab_create_alloc.
3019         (symbol_set_names): Call placement new for demangled_name_entry.
3020         * utils.c: No longer include xxhash.h here, now that fast_hash
3021         is inlined in the header.
3022         * utils.h: Instead, include it here.
3023
3024 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3025
3026         * Makefile.in: Link with libxxhash.
3027         * config.in: Regenerate.
3028         * configure: Regenerate.
3029         * configure.ac: Search for libxxhash.
3030         * utils.c (fast_hash): Use xxhash if present.
3031
3032 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3033
3034         * utils.h (fast_hash): New function.
3035         * symtab.c (hash_demangled_name_entry): Call new function
3036         fast_hash.
3037
3038 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3039
3040         * symtab.c (struct demangled_name_entry): Change type of mangled
3041         to gdb::string_view. Also adds a constructor that takes the
3042         mangled name.
3043         (hash_demangled_name_entry): Update.
3044         (eq_demangled_name_entry): Update.
3045         (free_demangled_name_entry): New function to call the destructor
3046         now that this is not a POD anymore.
3047         (create_demangled_names_hash): Pass free_demangled_name_entry to
3048         htab_create_alloc.
3049         (symbol_set_names): Update.
3050
3051 2019-10-21  Ali Tamur  <tamu@google.com>
3052
3053         * dwarf2read.c (dir_index): Change type.
3054         (file_name_index): Likewise.
3055         (line_header::include_dir_at): Change comment and implementation on
3056         whether it is DWARF 5.
3057         (line_header::is_valid_file_index): New function.
3058         (line_header::file_name_at): Change comment and implementation on
3059         whether it is DWARF 5.
3060         (line_header::file_names): Change to private field renamed as
3061         m_file_names and introduce a new accessor method.
3062         (line_header::file_names_size): New method.
3063         (line_header::include_dirs): Change to private field and rename as
3064         m_include_dirs.
3065         (dw2_get_file_names_reader): Define local var at a smaller scope and
3066         reflect API change.
3067         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3068         (process_structure_scope): Likewise.
3069         (line_header::add_include_dir): Change message and reflect renaming.
3070         (line_header::add_file_name): Likewise.
3071         (read_formatted_entries): Handle DW_FORM_data16.
3072         (dwarf_decode_line_header): Fix line header length calculation.
3073         (psymtab_include_file_name): Change comment and API.
3074         (lnp_state_machine::m_file): Update comment and reflect type change.
3075         (lnp_state_machine::record_line): Reflect type change.
3076         (dwarf_decode_lines): Reflect API change.
3077         (file_file_name): Likewise.
3078         (file_full_name): Likewise.
3079
3080 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3081
3082         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3083
3084 2019-10-21  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3087
3088 2019-10-21  Tom Tromey  <tom@tromey.com>
3089
3090         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3091         NM_H.   Use AC_CONFIG_LINKS.
3092         * configure: Rebuild.
3093         * Makefile.in (NM_H): New variable.
3094         (generated_files): Add NM_H.  Remove gcore.
3095         (nm.h, stamp-nmh): New targets.
3096
3097 2019-10-20  Tom Tromey  <tom@tromey.com>
3098
3099         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3100         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3101         obsolete comment.
3102         (put_objfile_before): Now static.
3103
3104 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * gdbsupport/common-utils.h (startswith): Change return type to
3107         bool.
3108
3109 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3110
3111         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3112         * breakpoint.c (bp_locations_compare): Rename to...
3113         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3114         (update_global_location_list): Use std::sort instead of qsort.
3115         * buildsym.c (compare_line_numbers): Rename to...
3116         (lte_is_less_than): ...this, and change to std::sort semantics.
3117         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3118         instead of qsort.
3119         * disasm.c (compare_lines): Rename to...
3120         (line_is_less_than): ...this, and change to std::sort semantics.
3121         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3122         of qsort.
3123         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3124         (fde_is_less_than): ...this, and change to std::sort semantics.
3125         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3126         * mdebugread.c (compare_blocks):
3127         (block_is_less_than): ...this, and change to std::sort semantics.
3128         (sort_blocks): Call std::sort instead of qsort.
3129         * objfiles.c (qsort_cmp): Rename to...
3130         (sort_cmp): ...this, and change to std::sort semantics.
3131         (update_section_map): Call std::sort instead of qsort.
3132         * remote.c (compare_pnums): Remove.
3133         (map_regcache_remote_table): Call std::sort instead of qsort.
3134         * utils.c (compare_positive_ints): Remove.
3135         * utils.h (compare_positive_ints): Remove.
3136         * xcoffread.c (compare_lte): Remove.
3137         (arrange_linetable): Call std::sort instead of qsort.
3138
3139 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3140
3141         * symfile.c (init_entry_point_info): Fix typo.
3142         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3143
3144 2019-10-18  Tom de Vries  <tdevries@suse.de>
3145
3146         * aarch64-tdep.c: Fix typos in comments.
3147         * ada-lang.c: Same.
3148         * ada-tasks.c: Same.
3149         * alpha-tdep.c: Same.
3150         * alpha-tdep.h: Same.
3151         * amd64-nat.c: Same.
3152         * amd64-windows-tdep.c: Same.
3153         * arc-tdep.c: Same.
3154         * arc-tdep.h: Same.
3155         * arch-utils.c: Same.
3156         * arm-nbsd-tdep.c: Same.
3157         * arm-tdep.c: Same.
3158         * ax-gdb.c: Same.
3159         * blockframe.c: Same.
3160         * btrace.c: Same.
3161         * c-varobj.c: Same.
3162         * coff-pe-read.c: Same.
3163         * coffread.c: Same.
3164         * cris-tdep.c: Same.
3165         * darwin-nat.c: Same.
3166         * dbxread.c: Same.
3167         * dcache.c: Same.
3168         * disasm.c: Same.
3169         * dtrace-probe.c: Same.
3170         * dwarf-index-write.c: Same.
3171         * dwarf2-frame-tailcall.c: Same.
3172         * dwarf2-frame.c: Same.
3173         * dwarf2read.c: Same.
3174         * eval.c: Same.
3175         * exceptions.c: Same.
3176         * fbsd-tdep.c: Same.
3177         * findvar.c: Same.
3178         * frame.c: Same.
3179         * frv-tdep.c: Same.
3180         * gnu-v3-abi.c: Same.
3181         * go32-nat.c: Same.
3182         * h8300-tdep.c: Same.
3183         * hppa-tdep.c: Same.
3184         * i386-linux-tdep.c: Same.
3185         * i386-tdep.c: Same.
3186         * ia64-libunwind-tdep.c: Same.
3187         * ia64-tdep.c: Same.
3188         * infcmd.c: Same.
3189         * infrun.c: Same.
3190         * linespec.c: Same.
3191         * linux-nat.c: Same.
3192         * linux-thread-db.c: Same.
3193         * machoread.c: Same.
3194         * mdebugread.c: Same.
3195         * mep-tdep.c: Same.
3196         * mn10300-tdep.c: Same.
3197         * namespace.c: Same.
3198         * objfiles.c: Same.
3199         * opencl-lang.c: Same.
3200         * or1k-tdep.c: Same.
3201         * osabi.c: Same.
3202         * ppc-linux-nat.c: Same.
3203         * ppc-linux-tdep.c: Same.
3204         * ppc-sysv-tdep.c: Same.
3205         * printcmd.c: Same.
3206         * procfs.c: Same.
3207         * record-btrace.c: Same.
3208         * record-full.c: Same.
3209         * remote-fileio.c: Same.
3210         * remote.c: Same.
3211         * rs6000-tdep.c: Same.
3212         * s12z-tdep.c: Same.
3213         * score-tdep.c: Same.
3214         * ser-base.c: Same.
3215         * ser-go32.c: Same.
3216         * skip.c: Same.
3217         * sol-thread.c: Same.
3218         * solib-svr4.c: Same.
3219         * solib.c: Same.
3220         * source.c: Same.
3221         * sparc-nat.c: Same.
3222         * sparc-sol2-tdep.c: Same.
3223         * sparc-tdep.c: Same.
3224         * sparc64-tdep.c: Same.
3225         * stabsread.c: Same.
3226         * stack.c: Same.
3227         * symfile.c: Same.
3228         * symtab.c: Same.
3229         * target-descriptions.c: Same.
3230         * target-float.c: Same.
3231         * thread.c: Same.
3232         * utils.c: Same.
3233         * valops.c: Same.
3234         * valprint.c: Same.
3235         * value.c: Same.
3236         * varobj.c: Same.
3237         * windows-nat.c: Same.
3238         * xcoffread.c: Same.
3239         * xstormy16-tdep.c: Same.
3240         * xtensa-tdep.c: Same.
3241
3242 2019-10-17  Tom Tromey  <tromey@adacore.com>
3243
3244         * configure: Rebuild.
3245         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3246         in AC_CONFIG_FILES invocation.
3247         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3248         new-style config.status invocation.
3249
3250 2019-10-17  Tom de Vries  <tdevries@suse.de>
3251
3252         * arm-nbsd-nat.c: Fix typos in comments.
3253         * arm-tdep.c: Same.
3254         * darwin-nat-info.c: Same.
3255         * dwarf2read.c: Same.
3256         * elfread.c: Same.
3257         * event-top.c: Same.
3258         * findvar.c: Same.
3259         * gdbtypes.c: Same.
3260         * hppa-tdep.c: Same.
3261         * i386-tdep.c: Same.
3262         * jit.c: Same.
3263         * main.c: Same.
3264         * mdebugread.c: Same.
3265         * moxie-tdep.c: Same.
3266         * nto-procfs.c: Same.
3267         * osabi.c: Same.
3268         * ppc-linux-tdep.c: Same.
3269         * remote.c: Same.
3270         * riscv-tdep.c: Same.
3271         * s390-tdep.c: Same.
3272         * sh-tdep.c: Same.
3273         * sparc-linux-tdep.c: Same.
3274         * sparc-nat.c: Same.
3275         * stack.c: Same.
3276         * target-descriptions.c: Same.
3277         * top.c: Same.
3278         * varobj.c: Same.
3279
3280 2019-10-16  Tom Tromey  <tom@tromey.com>
3281
3282         * objfiles.h (struct objfile) <original_name>: Now const.
3283
3284 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3285
3286         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3287         pass on to sigsetjmp's second argument.
3288         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3289
3290 2019-10-16  Keith Seitz  <keiths@redhat.com>
3291
3292         PR gdb/23567
3293         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3294         sections whose size is greater than the file size.
3295
3296 2019-10-16  Jim Wilson  <jimw@sifive.com>
3297
3298         * riscv-tdep.c (riscv_gcc_target_options): New.
3299         (riscv_gnu_triplet_regexp): New.
3300         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3301         set_gdbarch_gnu_triplet_regexp.
3302
3303 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3304
3305         * Makefile.in: Add xml-builtin.h.
3306         * features/feature_to_c.sh: Add an include for xml-builtin.h
3307         to ensure that the compiler checks that the types match.
3308         * xml-builtin.h: New file.
3309         * xml-support.c (fetch_xml_builtin): Add missing const.
3310         * xml-support.h: Remove declaration of xml_builtins.
3311
3312 2019-10-16  Tom de Vries  <tdevries@suse.de>
3313
3314         PR tdep/25096
3315         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3316         (amd64_classify_aggregate): ... here.
3317         (amd64_classify_aggregate_field): Handled fiels of nested structs
3318         recursively.
3319
3320 2019-10-16  Tom de Vries  <tdevries@suse.de>
3321
3322         PR tdep/24104
3323         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3324         that handles 'theclass'.
3325
3326 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3327
3328         * linespec.c (decode_digits_ordinary): Update comment.
3329         * make-target-delegates: No longer need to handle VEC case.
3330         * memrange.c (normalize_mem_ranges): Update comment.
3331         * namespace.c (add_using_directive): Update comment.
3332         * objc-lang.c (uniquify_strings): Update comment.
3333         * ppc-linux-nat.c (struct thread_points): Update comment.
3334         * probe.h (find_probes_in_objfile): Update comment.
3335         * target.h (enum flash_preserve_mode): Update comment.
3336         * varobj.c (varobj_restrict_range): Update comment.
3337         * varobj.h (varobj_list_children): Update comment.
3338
3339 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * Makefile.in: Remove references to vec.h and vec.c.
3342         * aarch64-tdep.c: No longer include vec.h.
3343         * ada-lang.c: Likewise.
3344         * ada-lang.h: Likewise.
3345         * arm-tdep.c: Likewise.
3346         * ax.h: Likewise.
3347         * breakpoint.h: Likewise.
3348         * charset.c: Likewise.
3349         * cp-support.h: Likewise.
3350         * dtrace-probe.c: Likewise.
3351         * dwarf2read.c: Likewise.
3352         * extension.h: Likewise.
3353         * gdb_bfd.c: Likewise.
3354         * gdbsupport/gdb_vecs.h: Likewise.
3355         * gdbsupport/vec.c: Remove.
3356         * gdbsupport/vec.h: Remove.
3357         * gdbthread.h: Likewise.
3358         * guile/scm-type.c: Likewise.
3359         * inline-frame.c: Likewise.
3360         * machoread.c: Likewise.
3361         * memattr.c: Likewise.
3362         * memrange.h: Likewise.
3363         * namespace.h: Likewise.
3364         * nat/linux-btrace.h: Likewise.
3365         * osdata.c: Likewise.
3366         * parser-defs.h: Likewise.
3367         * progspace.h: Likewise.
3368         * python/py-type.c: Likewise.
3369         * record-btrace.c: Likewise.
3370         * rust-exp.y: Likewise.
3371         * solib-target.c: Likewise.
3372         * stap-probe.c: Likewise.
3373         * target-descriptions.c: Likewise.
3374         * target-memory.c: Likewise.
3375         * target.h: Likewise.
3376         * varobj.c: Likewise.
3377         * varobj.h: Likewise.
3378         * xml-support.h: Likewise.
3379
3380 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3381
3382         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3383         Update for new std::vector based implementation.
3384         (process_psymtab_comp_unit_reader): Likewise.
3385         (scan_partial_symbols): Likewise.
3386         (recursively_compute_inclusions): Likewise.
3387         (compute_compunit_symtab_includes): Likewise.
3388         (process_imported_unit_die): Likewise.
3389         (queue_and_load_dwo_tu): Likewise.
3390         (follow_die_sig_1): Likewise.
3391         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3392         (typedef dwarf2_per_cu_ptr): Remove.
3393         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3394         function.
3395         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3396         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3397         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3398         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3399         std::vector.
3400
3401 2019-10-15  Tom Tromey  <tromey@adacore.com>
3402
3403         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3404         TID.
3405
3406 2019-10-15  Tom Tromey  <tromey@adacore.com>
3407
3408         * windows-nat.c (windows_nat_target::fetch_registers)
3409         (windows_nat_target::store_registers): Rename "pid" to "tid".
3410
3411 2019-10-15  Tom Tromey  <tromey@adacore.com>
3412
3413         * gdbarch.h, gdbarch.c: Rebuild.
3414         * gdbarch.sh (gcc_target_options): Change return type to
3415         std::string.
3416         * compile/compile.c (get_args): Update.
3417         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3418         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3419         std::string.
3420         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3421         std::string.
3422         * arch-utils.c (default_gcc_target_options): Return std::string.
3423         * arch-utils.h (default_gcc_target_options): Return std::string.
3424         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3425
3426 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3427
3428         * breakpoint.c (breakpoint_chain): Make static.
3429         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3430         of accessing breakpoint_chain.
3431
3432 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3433
3434         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3435         to a gdb::function_view and return value to bool.
3436         * breakpoint.h (iterate_over_breakpoints): Likewise.
3437         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3438         (pop_dummy_frame): Update.
3439         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3440         (gdbscm_breakpoints): Update.
3441         * python/py-breakpoint.c (build_bp_list): Update.
3442         (gdbpy_breakpoints): Update.
3443         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3444         Update.
3445         (bpfinishpy_handle_stop): Update.
3446         (bpfinishpy_handle_exit): Update.
3447         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3448         (svr4_update_solib_event_breakpoints): Update.
3449
3450 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3451
3452         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3453         when unwrapping single-field structs.
3454
3455 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3456
3457         * dwarf2read.c: Remove includes.
3458
3459 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3460
3461         * ui-out.c (ui_out::call_do_message): Silence
3462         -Wformat-nonliteral warning.
3463
3464 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3465
3466         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3467         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3468         include: readline/tilde.h.
3469
3470 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3471
3472         * remote.c (remote_target::get_trace_status): Remove declaration of
3473         trace_regblock_size.
3474
3475 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3476
3477         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3478         (show_user): Remove declaration of cmdlist.
3479         * cli/cli-cmds.h (max_user_call_depth): Declare.
3480         * cli/cli-script.c (execute_user_command): Remove declaration
3481         of max_user_call_depth.
3482
3483 2019-10-11  Jim Wilson  <jimw@sifive.com>
3484
3485         * gdbsupport/print-utils.h (pulongest): Fix comment.
3486         (plongest): Likewise.
3487         (phex): Add missing comment, mention leading zeros.
3488         (phex_nz): Add mention of no leading zeros to comment.
3489
3490         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3491         plongest instead of unsigned long long cast.
3492
3493 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3494
3495         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3496         for external_editor_command and gdbtk_test.
3497
3498 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3499
3500         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3501         * varobj.c (varobjdebug): Move comment to...
3502         * varobj.h (varobjdebug): ...here, and declare.
3503
3504 2019-10-09  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3507         erase_data_content.
3508
3509 2019-10-09  Tom Tromey  <tom@tromey.com>
3510
3511         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3512         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3513         * tui/tui-command.c (tui_cmd_window::resize)
3514         (tui_refresh_cmd_win): Update.
3515         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3516         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3517         * tui/tui-data.c (~tui_gen_win_info): Remove.
3518         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3519         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3520         (tui_redisplay_readline, tui_mld_flush)
3521         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3522         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3523         (tui_data_window::erase_data_content)
3524         (tui_data_item_window::rerender)
3525         (tui_data_item_window::refresh_window): Update.
3526         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3527         (box_win, tui_gen_win_info::make_window)
3528         (tui_gen_win_info::make_visible): Update.
3529         (tui_delete_win): Remove.
3530         * tui/tui-winsource.c
3531         (tui_source_window_base::do_erase_source_content): Update.
3532         (tui_show_source_line, tui_source_window_base::update_tab_width)
3533         (tui_source_window_base::update_exec_info): Update.
3534         * tui/tui-data.h (struct curses_deleter): New.
3535         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3536         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3537
3538 2019-10-09  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3541
3542 2019-10-09  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3545         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3546
3547 2019-10-09  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3550         window height directly.
3551         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3552         declare.
3553         * tui/tui-layout.c (tui_default_win_height): Remove.
3554         (tui_default_win_viewport_height): Remove.
3555
3556 2019-10-09  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui.h: Remove comments.
3559
3560 2019-10-09  Tom de Vries  <tdevries@suse.de>
3561
3562         * python/lib/gdb/printer/bound_registers.py: Use
3563         '^builtin_type_bound128' as regexp argument for
3564         add_builtin_pretty_printer.
3565
3566 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3567
3568         * guile/guile.c (guile_extension_script_ops): Remove forward
3569         declaration and mark as static.
3570         (guile_script_ops): Likewise.
3571         (extension_language_guile): Move further down in the file so
3572         it can reference the definitions for guile_{extension_,}script_ops.
3573
3574 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3575
3576         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3577         except SORTL, DFLTCC, and KDSA.
3578
3579 2019-10-08  Tom Tromey  <tromey@adacore.com>
3580
3581         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3582         (struct safe_symbol_file_add_args): Remove.
3583
3584 2019-10-08  Tom Tromey  <tromey@adacore.com>
3585
3586         * windows-nat.c: Don't include buildsym-legacy.h.
3587
3588 2019-10-08  Tom Tromey  <tromey@adacore.com>
3589
3590         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3591
3592 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3593
3594         * gdbtypes.c (overload_debug): Move comment to header.
3595         * gdbtypes.h (overload_debug): Declare.
3596         * valops.c: Remove declaration of overload_debug, instead
3597         include gdbtypes.h.
3598
3599 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3600
3601         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3602         through _().
3603         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3604         move comment...
3605         * language.h (lang_frame_mismatch_warn): ... here. Also add
3606         declaration.
3607         * top.c (lang_frame_mismatch_warn): Remove declaration.
3608         (check_frame_language_change): Pass lang_frame_mismatch_warn
3609         through _().
3610
3611 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3612
3613         * c-lang.h (vtbl_ptr_name): Declare.
3614         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3615         it from the header.
3616         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3617
3618 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3619
3620         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3621         gdb_static_assert.
3622
3623 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3624
3625         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3626         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3627         * ctfread.c: New file.
3628         * ctfread.h: New file.
3629         * elfread.c: Include ctfread.h.
3630         (struct elfinfo text_p): New member ctfsect.
3631         (elf_locate_sections): Mark CTF section.
3632         (elf_symfile_read): Call elfctf_build_psymtabs.
3633         * Makefile.in (LIBCTF): Add.
3634         (CLIBS): Use it.
3635         (CDEPS): Likewise.
3636         (DIST): Add ctfread.c.
3637
3638 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * ctfread.c (struct nextfield): Renamed to ...
3641         (struct ctf_nextfield): ... this.
3642         (struct field_info): Renamed to ...
3643         (strut ctf_field_info): ... this.
3644         (attach_fields_to_type): Update for renamed structures.
3645         (ctf_add_member_cb): Likewise.
3646         (ctf_add_enum_member_cb): Likewise.
3647         (process_struct_members): Likewise.
3648         (process_enum_type): Likewise.
3649
3650 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3651
3652         * tracectf.h: Rename, was ctf.h.
3653         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3654         * tracefile.c: Likewise.
3655         * tracepoint.c: Remove unused include ctf.h.
3656         * mi/mi-main.c: Likewise.
3657         * Makefile.in Replace ctf.c with tracectf.c.
3658
3659 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3660
3661         * version.in: Change version number to "9.0.50.DATE-git".
3662
3663 2019-10-03  Tom Tromey  <tom@tromey.com>
3664
3665         PR rust/24976:
3666         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3667
3668 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3671         cp_search_name_hash.
3672         * NEWS: Add entry about nested function support.
3673
3674 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3675             Andrew Burgess  <andrew.burgess@embecosm.com>
3676
3677         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3678         for nested static variables when searchin VAR_DOMAIN.
3679         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3680         global scope, update comment.
3681         (add_partial_subprogram): Call add_partial_subprogram recursively
3682         for nested subroutines when processinng Fortran.
3683         (load_partial_dies): Process the child entities of a subprogram
3684         when processing Fortran.
3685         (partial_die_parent_scope): Handle building scope
3686         for Fortran nested functions.
3687         (process_die): Record that nested functions have a scope.
3688         (new_symbol): Always record Fortran subprograms on the global
3689         symbol list.
3690         (determine_prefix): How to build the prefix for Fortran
3691         subprograms.
3692
3693 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3696         have just sent the thread a SIGSTOP and are waiting for it to
3697         arrive.
3698
3699 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * btrace.c (btrace_add_pc): Remove whitespace before the template
3702         parameter in 'std::vector <...>'.
3703         (parse_xml_btrace_block): Likewise.
3704         (btrace_maint_decode_pt): Likewise.
3705         (btrace_maint_update_packets): Likewise.
3706         (btrace_maint_print_packets): Likewise.
3707         * btrace.h (struct btrace_maint_info): Likewise.
3708         * dwarf2read.c (struct type_unit_group): Likewise.
3709         (build_type_psymtabs_reader): Likewise.
3710         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3711         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3712         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3713
3714 2019-10-03  Tom de Vries  <tdevries@suse.de>
3715
3716         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3717         the first line of the help text for set/show style metadata.
3718
3719 2019-10-02  Tom Tromey  <tromey@adacore.com>
3720
3721         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3722         * gdbsupport/common-inferior.c: New file.
3723         * infcmd.c (startup_with_shell): Don't define.
3724         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3725         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3726         * inferior.h (startup_with_shell): Don't declare.
3727
3728 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3729
3730         * gdbsupport/gdb_assert.h: Include errors.h.
3731         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3732
3733 2019-10-02  Tom Tromey  <tromey@adacore.com>
3734
3735         * NEWS: Add $_ada_exception entry.
3736         * ada-lang.c (struct ada_catchpoint): Add constructor.
3737         <m_kind>: New member.
3738         (allocate_location_exception, re_set_exception): Remove
3739         "ex" parameter.
3740         (should_stop_exception): Compute $_ada_exception.
3741         (check_status_exception, print_it_exception)
3742         (print_one_exception, print_mention_exception): Remove
3743         "ex" parameter.
3744         (allocate_location_catch_exception, re_set_catch_exception)
3745         (check_status_exception, print_it_catch_exception)
3746         (print_one_catch_exception, print_mention_catch_exception)
3747         (print_recreate_catch_exception)
3748         (allocate_location_catch_exception_unhandled)
3749         (re_set_catch_exception_unhandled)
3750         (check_status_exception, print_it_catch_exception_unhandled)
3751         (print_one_catch_exception_unhandled)
3752         (print_mention_catch_exception_unhandled)
3753         (print_recreate_catch_exception_unhandled)
3754         (allocate_location_catch_assert, re_set_catch_assert)
3755         (check_status_assert, print_it_catch_assert)
3756         (print_one_catch_assert, print_mention_catch_assert)
3757         (print_recreate_catch_assert)
3758         (allocate_location_catch_handlers, re_set_catch_handlers)
3759         (check_status_handlers, print_it_catch_handlers)
3760         (print_one_catch_handlers, print_mention_catch_handlers)
3761         (print_recreate_catch_handlers): Remove.
3762         (create_ada_exception_catchpoint): Update.
3763         (initialize_ada_catchpoint_ops): Update.
3764
3765 2019-10-02  Tom Tromey  <tromey@adacore.com>
3766
3767         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3768         (create_excep_cond_exprs): Simplify exception string computation.
3769         (ada_exception_catchpoint_cond_string): Likewise.
3770
3771 2019-10-02  Tom Tromey  <tromey@adacore.com>
3772
3773         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3774         * ada-lang.c (lesseq_defined_than): Handle
3775         LOC_STATIC.
3776         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3777         parameter.
3778         (dwarf2_has_info): Likewise.
3779         (new_symbol): Set maybe_copied on symbol when
3780         appropriate.
3781         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3782         parameter.
3783         <can_copy>: New member.
3784         * elfread.c (record_minimal_symbol): Set maybe_copied
3785         on symbol when appropriate.
3786         (elf_symfile_read): Update call to dwarf2_has_info.
3787         * minsyms.c (lookup_minimal_symbol_linkage): New
3788         function.
3789         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3790         * symtab.c (get_symbol_address, get_msymbol_address):
3791         New functions.
3792         * symtab.h (get_symbol_address, get_msymbol_address):
3793         Declare.
3794         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3795         maybe_copied.
3796         (struct symbol, struct minimal_symbol) <maybe_copied>:
3797         New member.
3798
3799 2019-10-02  Tom Tromey  <tromey@adacore.com>
3800
3801         * source.c (struct current_source_location): New.
3802         (current_source_key): New global.
3803         (current_source_symtab, current_source_line)
3804         (current_source_pspace): Remove.
3805         (get_source_location): New function.
3806         (get_current_source_symtab_and_line)
3807         (set_default_source_symtab_and_line)
3808         (set_current_source_symtab_and_line)
3809         (clear_current_source_symtab_and_line, select_source_symtab)
3810         (info_source_command, print_source_lines_base)
3811         (info_line_command, search_command_helper, _initialize_source):
3812         Update.
3813
3814 2019-10-02  Tom Tromey  <tromey@adacore.com>
3815
3816         * source.c (select_source_symtab): Don't call
3817         decode_line_with_current_source.
3818
3819 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * symtab.c (lookup_global_symbol): Search global block.
3822
3823 2019-10-02  Tom Tromey  <tromey@adacore.com>
3824
3825         * coffread.c (process_coff_symbol): Update.
3826         * dwarf2read.c (var_decode_location, new_symbol): Update.
3827         * mdebugread.c (parse_symbol): Update.
3828         * objfiles.c (relocate_one_symbol): Update.
3829         * stabsread.c (define_symbol, fix_common_block)
3830         (scan_file_globals): Update.
3831         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3832         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3833         * xcoffread.c (process_xcoff_symbol): Update.
3834
3835 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3836
3837         * MAINTAINERS: Update my email address.
3838
3839 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3842         std::vector.
3843         (build_type_psymtabs_reader): Update for std::vector.
3844         (build_type_psymtab_dependencies): Likewise.
3845         * dwarf2read.h: Remove use of DEF_VEC_P.
3846         (typedef sig_type_ptr): Delete.
3847
3848 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3851         to std::vector.
3852         (btrace_maint_decode_pt): Likewise, and move allocation of the
3853         vector outside of the loop.
3854         (btrace_maint_update_packets): Update to handle change from VEC to
3855         std::vector.
3856         (btrace_maint_print_packets): Likewise.
3857         (maint_info_btrace_cmd): Likewise.
3858         * btrace.h: Remove use of DEF_VEC_O.
3859         (typedef btrace_pt_packet_s): Delete.
3860         (struct btrace_maint_info) <packets>: Change fromm VEC to
3861         std::vector.
3862         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3863
3864 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3867         make accesses into the vector constant references.
3868         (btrace_add_pc): Update for std::vector.
3869         (btrace_stitch_bts): Likewise.
3870         (parse_xml_btrace_block): Likewise.
3871         (btrace_maint_update_packets): Likewise.
3872         (btrace_maint_print_packets): Likewise.
3873         (maint_info_btrace_cmd): Likewise.
3874         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3875         std::vector.
3876         (btrace_data::empty): Likewise.
3877         (btrace_data_append): Likewise.
3878         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3879         (typedef btrace_block_s): Delete.
3880         (struct btrace_block): Add constructor.
3881         (struct btrace_data_bts) <blocks>: Change to std::vector.
3882         * nat/linux-btrace.c (perf_event_read_bts): Update for
3883         std::vector.
3884         (linux_read_bts): Likewise.
3885
3886 2019-10-01  Tom Tromey  <tom@tromey.com>
3887
3888         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3889
3890 2019-10-01  Tom Tromey  <tom@tromey.com>
3891
3892         * stack.c (print_frame, info_frame_command_core): Use
3893         styled_string.
3894         * linux-thread-db.c (try_thread_db_load_1)
3895         (try_thread_db_load_from_pdir_1): Use styled_string.
3896         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3897         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3898         (maybe_print_unsupported_script_warning)
3899         (maybe_print_script_not_found_warning): Use styled_string.
3900         * ada-lang.c (user_select_syms): Use styled_string.
3901
3902 2019-10-01  Tom Tromey  <tom@tromey.com>
3903
3904         * p-lang.c (pascal_printstr): Use metadata style.
3905         * value.c (show_convenience): Use metadata style.
3906         * valprint.c (valprint_check_validity, val_print_optimized_out)
3907         (val_print_not_saved, val_print_unavailable)
3908         (val_print_invalid_address, generic_val_print, val_print)
3909         (value_check_printable, val_print_array_elements): Use metadata
3910         style.
3911         * ui-out.h (class ui_out) <field_fmt>: New overload.
3912         <do_field_fmt>: Add style parameter.
3913         * ui-out.c (ui_out::field_fmt): New overload.
3914         * typeprint.c (type_print_unknown_return_type)
3915         (val_print_not_allocated, val_print_not_associated): Use metadata
3916         style.
3917         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3918         parameter.
3919         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3920         * tracepoint.c (tvariables_info_1): Use metadata style.
3921         * stack.c (print_frame_arg, print_frame_info, print_frame)
3922         (info_frame_command_core): Use metadata style.
3923         * skip.c (info_skip_command): Use metadata style.
3924         * rust-lang.c (rust_print_enum): Use metadata style.
3925         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3926         metadata style.
3927         * python/py-framefilter.c (py_print_single_arg): Use metadata
3928         style.
3929         * printcmd.c (do_one_display, print_variable_and_value): Use
3930         metadata style.
3931         * p-valprint.c (pascal_val_print)
3932         (pascal_object_print_value_fields): Use metadata style.
3933         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3934         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3935         parameter.
3936         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3937         * m2-valprint.c (m2_print_long_set): Use metadata style.
3938         * m2-typeprint.c (m2_print_type): Use metadata style.
3939         * infcmd.c (print_return_value_1): Use metadata style.
3940         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3941         * f-valprint.c (info_common_command_for_block): Use metadata
3942         style.
3943         * f-typeprint.c (f_type_print_base): Use metadata style.
3944         * expprint.c (print_subexp_standard): Use metadata style.
3945         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3946         * cli/cli-style.h (class cli_style_option): Add constructor.
3947         (metadata_style): Declare.
3948         * cli/cli-style.c (metadata_style): New global.
3949         (_initialize_cli_style): Register metadata style.
3950         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3951         parameter.
3952         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3953         * c-typeprint.c (c_type_print_base_struct_union)
3954         (c_type_print_base_1): Use metadata style.
3955         * breakpoint.c (watchpoint_value_print)
3956         (print_one_breakpoint_location): Use metadata style.
3957         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3958         style.
3959         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3960         style.
3961         * ada-valprint.c (val_print_packed_array_elements, printstr)
3962         (print_field_values, ada_val_print_ref, ada_val_print): Use
3963         metadata style.
3964         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3965         style.
3966         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3967         style.
3968         * ada-lang.c (user_select_syms): Use metadata style.
3969
3970 2019-10-01  Tom Tromey  <tom@tromey.com>
3971
3972         * cli/cli-cmds.c (pwd_command): Style output.
3973
3974 2019-10-01  Pedro Alves  <palves@redhat.com>
3975             Tom Tromey  <tom@tromey.com>
3976
3977         * symtab.c (print_symbol_info): Use %ps.
3978         (print_msymbol_info): Use %ps.
3979         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3980         * printcmd.c (print_variable_and_value): Use %ps.
3981         * macrocmd.c (show_pp_source_pos): Use %ps.
3982         * infrun.c (print_exited_reason): Use ui_out::message.
3983         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3984         (describe_other_breakpoints): Use ui_out::message and new
3985         formats.
3986         (say_where): Use new formats.
3987         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3988         and new formats.
3989
3990 2019-10-01  Pedro Alves  <palves@redhat.com>
3991             Tom Tromey  <tom@tromey.com>
3992
3993         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3994         (test_gdb_formats): New function.
3995         (run_tests): Call it.
3996         (test_format_specifier): Update.
3997         * utils.h (fputs_filtered): Update comment.
3998         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3999         (fputs_styled_unfiltered): Declare.
4000         * utils.c (fputs_styled_unfiltered): New function.
4001         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4002         (vfprintf_filtered): Update.
4003         (vfprintf_unfiltered, vprintf_filtered): Update.
4004         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4005         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4006         disallow_ui_out_field>: New constants.
4007         (enum class field_kind): New.
4008         (struct base_field_s, struct signed_field_s): New.
4009         (signed_field): New function.
4010         (struct string_field_s): New.
4011         (string_field): New function.
4012         (struct styled_string_s): New.
4013         (styled_string): New function.
4014         (class ui_out) <message>: Add comment.
4015         <vmessage, call_do_message>: New methods.
4016         <do_message>: Add style parameter.
4017         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4018         methods.
4019         (ui_out::message): Rewrite.
4020         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4021         parameter.
4022         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4023         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4024         gdb_extensions parameter.
4025         (class format_piece): Add parameter to constructor.
4026         (n_int_args): New field.
4027         * gdbsupport/format.c (format_pieces::format_pieces): Add
4028         gdb_extensions parameter.  Handle '*'.
4029         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4030         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4031         vfprintf_styled_no_gdbfmt.
4032         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4033         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4034         unfiltered output.
4035         * ui-style.h (struct ui_file_style) <ptr>: New method.
4036
4037 2019-10-01  Tom Tromey  <tom@tromey.com>
4038
4039         * unittests/format_pieces-selftests.c: Update.  Add final format.
4040         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4041         empty literal pieces.
4042
4043 2019-10-01  Tom Tromey  <tom@tromey.com>
4044
4045         * ui-out.h (enum class ui_out_style_kind): Remove.
4046         (class ui_out) <field_string, field_stsream, do_field_string>:
4047         Change type of "style".
4048         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4049         (ui_out::field_string): Update.
4050         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4051         of "style".
4052         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4053         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4054         * stack.c (print_frame_arg, print_frame_info, print_frame):
4055         Update.
4056         * source.c (print_source_lines_base): Update.
4057         * solib.c (info_sharedlibrary_command): Update.
4058         * skip.c (info_skip_command): Update.
4059         * record-btrace.c (btrace_call_history_src_line)
4060         (btrace_call_history): Update.
4061         * python/py-framefilter.c (py_print_frame): Update.
4062         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4063         "style".
4064         * mi/mi-out.c (mi_ui_out::do_table_header)
4065         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4066         (mi_ui_out::do_field_string): Update.
4067         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4068         Update.
4069         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4070         "style".
4071         * cli-out.c (cli_ui_out::do_table_header)
4072         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4073         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4074         (cli_ui_out::do_field_fmt): Update.
4075         * breakpoint.c (print_breakpoint_location): Update.
4076         (update_static_tracepoint): Update.
4077
4078 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4079
4080         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4081         conversion of gdb_datadir.
4082         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4083         remove not needed c_str ().
4084
4085 2019-09-30  Ali Tamur <tamur@google.com>
4086
4087         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4088         (dwarf2_string_attr): Likewise.
4089
4090 2019-09-30  Ali Tamur <tamur@google.com>
4091
4092         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4093         (process_full_type_unit): Likewise.
4094         (dump_die_shallow): Likewise.
4095         (cu_debug_loc_section): Likewise.
4096
4097 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4098
4099         * minsyms.c (compare_minimal_symbols): Rename to...
4100         (minimal_symbol_is_less_than): ...this, and adjust to STL
4101         conventions (return bool, take arguments as references)
4102         (minimal_symbol_reader::install): Call std::sort instead
4103         of qsort.
4104
4105 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4106
4107         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4108         hash and why.
4109         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4110         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4111
4112 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4113
4114         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4115         * psympriv.h (add_psymbol_to_list): Move comment here and update
4116         it.
4117
4118 2019-09-29  Tom de Vries  <tdevries@suse.de>
4119
4120         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4121         Use $tmpdir/$(basename "$output_file").dwz instead of
4122         "${output_file}.dwz".
4123
4124 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4125
4126         PR gdb/25045
4127         * hppa-linux-nat.c: Include gdbarch.h.
4128
4129 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4130
4131         * blockframe.c (find_pc_partial_function): Change return type to bool.
4132         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4133         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4134         (stub_gnu_ifunc_resolve_name): Likewise.
4135         * symtab.c (compare_filenames_for_search): Likewise.
4136         (compare_glob_filenames_for_search): Likewise.
4137         (matching_obj_sections): Likewise.
4138         (symbol_matches_domain): Likewise.
4139         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4140         (find_line_pc): Change return type to bool.
4141         (find_line_pc_range): Likewise.
4142         (producer_is_realview): Likewise.
4143         * symtab.h (symbol_matches_domain): Likewise.
4144         (find_pc_partial_function): Likewise.
4145         (find_pc_line_pc_range): Likewise.
4146         (in_gnu_ifunc_stub): Likewise.
4147         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4148         (find_line_pc): Likewise.
4149         (find_line_pc_range): Likewise.
4150         (matching_obj_sections): Likewise.
4151         (find_line_symtab): Change out parameter to bool.
4152         (producer_is_realview): Change return type to bool.
4153         (compare_filenames_for_search): Likewise.
4154         (compare_glob_filenames_for_search): Likewise.
4155
4156 2019-09-26  Tom Tromey  <tom@tromey.com>
4157
4158         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4159         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4160         * gdb_usleep.h: Remove.
4161         * gdb_usleep.c: Remove.
4162         * utils.c: Don't include gdb_usleep.h.
4163
4164 2019-09-26  Tom Tromey  <tromey@adacore.com>
4165
4166         * python/py-type.c (type_to_type_object): Call check_typedef
4167         for stub types.
4168
4169 2019-09-26  Tom Tromey  <tom@tromey.com>
4170
4171         * utils.h (initialize_utils): Don't declare.
4172         * top.c (gdb_init): Don't call initialize_utils.
4173         * utils.c (initialize_utils): Remove.  Move contents...
4174         (_initialize_utils): ... here.
4175
4176 2019-09-25  Tom Tromey  <tom@tromey.com>
4177
4178         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4179         * utils.h (make_hex_string): Don't declare.
4180         * utils.c (make_hex_string): Remove.
4181
4182 2019-09-24  Tom de Vries  <tdevries@suse.de>
4183
4184         PR gdb/23815
4185         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4186         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4187
4188 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4189
4190         * NEWS: Mention new simulator port for PRU.
4191
4192 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4193
4194         * ada-exp.y (write_object_remaining): Update.
4195         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4196         and eliminate the static buffer.
4197         (ada_decode_symbol): Update.
4198         (ada_la_decode): Update.
4199         (ada_sniff_from_mangled_name): Update.
4200         (is_valid_name_for_wild_match): Update.
4201         (ada_lookup_name_info::matches): Update and simplify.
4202         (name_matches_regex): Update.
4203         (ada_add_global_exceptions): Update.
4204         * ada-lang.h (ada_decode): Update signature.
4205         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4206         * dwarf-index-write.c (debug_names::insert): Update.
4207
4208 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4209
4210         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4211         formatting.
4212
4213 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4214
4215         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4216         Change "nonzero" to "true" in documentation.
4217
4218 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4219
4220         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4221         (_initialize_darwin_solib): Don't set
4222         darwin_so_ops.lookup_lib_global_symbol.
4223         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4224         set_gdbarch_iterate_over_objfiles_in_search_order.
4225         (elf_lookup_lib_symbol): Rename to...
4226         (svr4_iterate_over_objfiles_in_search_order): this, and update
4227         to iterate semantics.
4228         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4229         * solib.c (solib_global_lookup): Remove.
4230         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4231         (solib_global_lookup): Remove.
4232         * symtab.c (lookup_global_or_static_symbol): Remove call to
4233         solib_global_lookup.
4234
4235 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4236
4237         * NEWS: Move entries about default MI version now being
4238         version 3, and about the GDB/MI fix for multi-location
4239         breakpoints to the "since GDB 8.3" section.
4240
4241 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4242
4243         GDB 8.3.1 released.
4244
4245 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4246
4247         * NEWS: Mention that Cell/B.E. debugging support was removed.
4248         * MAINTAINERS: Remove spu target.
4249
4250         * config/djgpp/fnchange.lst: Remove entries for removed files.
4251
4252         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4253         spu-multiarch.o, and spu-tdep.o.
4254         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4255         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4256         spu-multiarch.c, and spu-tdep.c.
4257         * spu-linux-nat.c: Remove file.
4258         * spu-multiarch.c: Remove file.
4259         * spu-tdep.c: Remove file.
4260         * spu-tdep.h: Remove file.
4261         * solib-spu.c: Remove file.
4262         * solib-spu.h: Remove file.
4263
4264         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4265         * configure.nat (spu-linux): Remove.
4266         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4267         solib-multiarch.o from gdb_target_obs.
4268         (spu*-*-*): Remove.
4269
4270         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4271         feature flag.
4272         (ppc_linux_no_features): Update.
4273         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4274         Cell/B.E. support.
4275         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4276         (tdesc_powerpc_cell64l): Likewise.
4277         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4278         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4279         Cell/B.E. support.
4280         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4281         Do not include "features/rs6000/powerpc-cell32l.c" or
4282         "features/rs6000/powerpc-cell64l.c".
4283         (ppc_linux_spu_section): Remove.
4284         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4285         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4286         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4287         (ppc_linux_spe_context_lookup): Remove.
4288         (ppc_linux_spe_context_inferior_created): Remove.
4289         (ppc_linux_spe_context_solib_loaded): Remove.
4290         (ppc_linux_spe_context_solib_unloaded): Remove.
4291         (ppc_linux_spe_context): Remove.
4292         (struct ppu2spu_cache): Remove.
4293         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4294         (struct ppu2spu_data): Remove.
4295         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4296         ppu2spu_unwind): Remove.
4297         (ppc_linux_init_abi): Remove Cell/B.E. support.
4298         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4299
4300         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4301         (rs6000/powerpc-cell64l-expedite): Likewise
4302         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4303         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4304         rs6000/powerpc-cell64l.xml.
4305         * features/rs6000/powerpc-cell32l.xml: Remove.
4306         * features/rs6000/powerpc-cell64l.xml: Likewise.
4307         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4308         * features/rs6000/powerpc-cell64l.c: Likewise.
4309         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4310         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4311         * regformats/reg-spu.dat: Remove.
4312
4313         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4314         * corelow.c (struct spuid_list): Remove.
4315         (add_to_spuid_list): Remove.
4316         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4317         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4318         (remote_protocol_features): Remove associated entries.
4319         (_initialize_remote): No longer initialize them.
4320         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4321         * linux-nat.c (SPUFS_MAGIC): Remove.
4322         (linux_proc_xfer_spu): Remove.
4323         (spu_enumerate_spu_ids): Remove.
4324         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4325         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4326         (linux_make_corefile_notes): No longer call it.
4327
4328         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4329         (cooked_write_test): Likewise.
4330
4331 2019-09-20  Tom Tromey  <tom@tromey.com>
4332
4333         * NEWS: Mention case-sensitivity of TUI commands.
4334         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4335         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4336         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4337
4338 2019-09-20  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-source.c (tui_source_window::set_contents): Use
4341         make_unique_xstrdup.
4342         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4343         make_unique_xstrdup.
4344
4345 2019-09-20  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-data.c: Remove separator comments.
4348         * tui/tui-layout.c: Remove separator comments.
4349         * tui/tui-win.c: Remove separator comments.
4350         * tui/tui-wingeneral.c: Remove separator comments.
4351
4352 2019-09-20  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui.h (strcat_to_buf): Don't declare.
4355         * tui/tui.c (strcat_to_buf): Remove.
4356
4357 2019-09-20  Tom Tromey  <tom@tromey.com>
4358
4359         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4360         from "fullname".
4361         * tui/tui-source.c (tui_source_window::set_contents)
4362         (tui_source_window::location_matches_p)
4363         (tui_source_window::maybe_update): Update.
4364
4365 2019-09-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4368         Update.
4369         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4370         prefix.
4371         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4372         (tui_data_window::line_from_reg_element_no)
4373         (tui_data_window::first_reg_element_no_inline)
4374         (tui_data_window::show_registers)
4375         (tui_data_window::show_register_group)
4376         (tui_data_window::display_registers_from)
4377         (tui_data_window::display_registers_from_line)
4378         (tui_data_window::first_data_item_displayed)
4379         (tui_data_window::delete_data_content_windows)
4380         (tui_data_window::erase_data_content)
4381         (tui_data_window::do_scroll_vertical)
4382         (tui_data_window::refresh_window)
4383         (tui_data_window::check_register_values): Update.
4384
4385 2019-09-20  Tom Tromey  <tom@tromey.com>
4386
4387         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4388         (struct tui_locator_window) <full_name, proc_name>: Now
4389         std::string.
4390         * tui/tui-stack.c (tui_locator_window::make_status_line)
4391         (tui_locator_window::set_locator_fullname)
4392         (tui_locator_window::set_locator_info): Update.
4393         * tui/tui-source.c (tui_source_window::set_contents)
4394         (tui_source_window::showing_source_p): Update.
4395
4396 2019-09-20  Tom Tromey  <tom@tromey.com>
4397
4398         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4399         Don't call tui_locator_win_info_ptr.
4400
4401 2019-09-20  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4404
4405 2019-09-20  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4408         height for locator.
4409         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4410         * tui/tui-layout.c (show_source_disasm_command, show_data)
4411         (show_source_or_disasm_and_command): Use 1 as height for locator.
4412
4413 2019-09-20  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui.c (tui_enable): Update.
4416         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4417         Update.
4418         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4419         Update.
4420         * tui/tui-data.c (win_resized): Now bool.
4421         (tui_win_resized): Return bool.
4422         (tui_set_win_resized_to): Accept a bool.
4423
4424 2019-09-20  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4427         Change type of "refresh_values_only".
4428         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4429         type of "refresh_values_only".
4430
4431 2019-09-20  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4434         std::string.
4435         (tui_disassemble): Add "pos" parameter.
4436         (tui_disasm_window::set_contents): Simplify.
4437
4438 2019-09-20  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui-winsource.h (struct tui_source_window_base)
4441         <show_source_content>: Now private.
4442         * tui/tui-winsource.c
4443         (tui_source_window_base::show_source_content): Don't handle empty
4444         content case.
4445
4446 2019-09-20  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-layout.c (show_source_disasm_command)
4449         (show_source_or_disasm_and_command): Don't call
4450         show_source_content.
4451
4452 2019-09-20  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4455         Declare.
4456         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4457         from tui_make_status_line.
4458         (tui_locator_window::rerender): Update.
4459
4460 2019-09-20  Tom Tromey  <tom@tromey.com>
4461
4462         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4463         (tui_locator_window::rerender): Update.
4464
4465 2019-09-20  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui-winsource.h (struct tui_source_window_base)
4468         <~tui_source_window_base>: Don't declare.
4469         <fullname>: Remove.
4470         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4471         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4472         member.
4473         * tui/tui-source.c (tui_source_window::set_contents): Update.
4474         (tui_source_window::location_matches_p)
4475         (tui_source_window::maybe_update): Update.
4476
4477 2019-09-20  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-winsource.h (~tui_source_element): Remove.
4480         (tui_source_element): Update.
4481         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4482         * tui/tui-winsource.c (tui_show_source_line): Update.
4483         * tui/tui-source.c (tui_source_window::set_contents): Update.
4484         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4485
4486 2019-09-20  Tom Tromey  <tom@tromey.com>
4487
4488         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4489         declare.
4490         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4491         tui_clear_source_windows_detail.
4492         * tui/tui-winsource.h (struct tui_source_window_base)
4493         <clear_detail>: Don't declare.
4494         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4495         Remove.
4496         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4497
4498 2019-09-20  Tom Tromey  <tromey@adacore.com>
4499
4500         PR ada/24919:
4501         * block.c (contained_in): Fix final return value.
4502
4503 2019-09-20  Alan Modra  <amodra@gmail.com>
4504
4505         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4506         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4507         (read_indirect_string_from_dwz): Use bfd accessor.
4508         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4509         * machoread.c (macho_symfile_read_all_oso): Likewise.
4510         * solib.c (solib_bfd_open): Likewise.
4511
4512 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4513
4514         * eval.c: Move declaration of overload_resolution to...
4515         * value.h: ...here.
4516
4517 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4518
4519         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4520         * arm-linux-tdep.c: Likewise.
4521         * arm-nbsd-nat.c: Likewise.
4522         * arm-tdep.h: Declare arm_apcs_32.
4523         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4524
4525 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4526
4527         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4528         * dwarf2read.h: Declare dwarf_always_disassemble.
4529
4530 2019-09-19  Tom de Vries  <tdevries@suse.de>
4531
4532         PR gdb/25009
4533         * source-cache.c (source_cache::ensure): Catch exception thrown during
4534         construction of the highlighter.
4535
4536 2019-09-18  Alan Modra  <amodra@gmail.com>
4537
4538         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4539         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4540         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4541         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4542         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4543         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4544         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4545         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4546         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4547         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4548         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4549         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4550         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4551         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4552         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4553         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4554         * mi/mi-interp.c: Update throughout for bfd section macro and
4555         function changes.
4556         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4557         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4558
4559 2019-09-18  Tom Tromey  <tom@tromey.com>
4560
4561         * NEWS: Add entry.
4562         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4563         call rl_initialize.
4564         (tui_enable): Do not call rl_initialize.
4565
4566 2019-09-18  Christian Groessler  <chris@groessler.org>
4567
4568         * alpha-linux-nat.c: Include gdbarch.h.
4569
4570 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4571
4572         * ui-file.c: Include cli/cli-style.h.
4573         (term_cli_styling): Remove cli_styling declaration.
4574
4575 2019-09-18  Alan Modra  <amodra@gmail.com>
4576
4577         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4578         to bfd_asymbol_section.
4579
4580 2019-09-18  Alan Modra  <amodra@gmail.com>
4581
4582         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4583         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4584         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4585
4586 2019-09-18  Alan Modra  <amodra@gmail.com>
4587
4588         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4589         * spu-linux-nat.c (spu_bfd_open): Likewise.
4590
4591 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4592
4593         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4594         to bool to match definition in dwarf2read.c.
4595
4596 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4597
4598         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4599         (print_signatures): Likewise.
4600         (trust_pad_over_xvs): Likewise.
4601         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4602         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4603         * arm-linux-nat.c (arm_apcs_32): Likewise.
4604         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4605         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4606         * arm-tdep.c (arm_debug): Likewise.
4607         (arm_apcs_32): Likewise.
4608         * auto-load.c (debug_auto_load): Likewise.
4609         (auto_load_gdb_scripts): Likewise.
4610         (global_auto_load): Likewise.
4611         (auto_load_local_gdbinit): Likewise.
4612         (auto_load_local_gdbinit_loaded): Likewise.
4613         * auto-load.h (global_auto_load): Likewise.
4614         (auto_load_local_gdbinit): Likewise.
4615         (auto_load_local_gdbinit_loaded): Likewise.
4616         * breakpoint.c (disconnected_dprintf): Likewise.
4617         (breakpoint_proceeded): Likewise.
4618         (automatic_hardware_breakpoints): Likewise.
4619         (always_inserted_mode): Likewise.
4620         (target_exact_watchpoints): Likewise.
4621         (_initialize_breakpoint): Update.
4622         * breakpoint.h (target_exact_watchpoints): Change to bool.
4623         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4624         * cli/cli-cmds.c (trace_commands): Likewise.
4625         * cli/cli-cmds.h (trace_commands): Likewise.
4626         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4627         to bool*.
4628         * cli/cli-logging.c (logging_overwrite): Change to bool.
4629         (logging_redirect): Likewise.
4630         (debug_redirect): Likewise.
4631         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4632         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4633         to bool.
4634         <boolean_option_def>: Update.
4635         (struct flag_option_def): Change default type of Context to bool
4636         from int.
4637         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4638         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4639         (get_setshow_command_value_string): Likewise.
4640         * cli/cli-style.c (cli_styling): Change to bool.
4641         (source_styling): Likewise.
4642         * cli/cli-style.h (source_styling): Likewise.
4643         (cli_styling): Likewise.
4644         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4645         to bool.
4646         * command.h (var_types): Update comment.
4647         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4648         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4649         bool.
4650         (debug_compile_cplus_scopes): Likewise.
4651         * compile/compile-internal.h (compile_debug): Likewise.
4652         * compile/compile.c (compile_debug): Likewise.
4653         (struct compile_options) <raw>: Likewise.
4654         * cp-support.c (catch_demangler_crashes): Likewise.
4655         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4656         (usr_cmd_cris_dwarf2_cfi): Likewise.
4657         * csky-tdep.c (csky_debug): Likewise.
4658         * darwin-nat.c (enable_mach_exceptions): Likewise.
4659         * dcache.c (dcache_enabled_p): Likewise.
4660         * defs.h (info_verbose): Likewise.
4661         * demangle.c (demangle): Likewise.
4662         (asm_demangle): Likewise.
4663         * dwarf-index-cache.c (debug_index_cache): Likewise.
4664         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4665         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4666         * dwarf2read.c (check_physname): Likewise.
4667         (use_deprecated_index_sections): Likewise.
4668         (dwarf_always_disassemble): Likewise.
4669         * eval.c (overload_resolution): Likewise.
4670         * event-top.c (set_editing_cmd_var): Likewise.
4671         (exec_done_display_p): Likewise.
4672         * event-top.h (set_editing_cmd_var): Likewise.
4673         (exec_done_display_p): Likewise.
4674         * exec.c (write_files): Likewise.
4675         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4676         (debug_fbsd_nat): Likewise.
4677         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4678         Likewise.
4679         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4680         <backtrace_past_entry> Likewise.
4681         * gdb-demangle.h (demangle): Likewise.
4682         (asm_demangle): Likewise.
4683         * gdb_bfd.c (bfd_sharing): Likewise.
4684         * gdbcore.h (write_files): Likewise.
4685         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4686         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4687         * gdbthread.h (print_thread_events): Likewise.
4688         * gdbtypes.c (opaque_type_resolution): Likewise.
4689         (strict_type_checking): Likewise.
4690         * gnu-nat.c (gnu_debug_flag): Likewise.
4691         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4692         * guile/scm-param.c (pascm_variable): Add boolval.
4693         (add_setshow_generic): Update.
4694         (pascm_param_value): Update.
4695         (pascm_set_param_value_x): Update.
4696         * hppa-tdep.c (hppa_debug): Change to bool..
4697         * infcall.c (may_call_functions_p): Likewise.
4698         (coerce_float_to_double_p): Likewise.
4699         (unwind_on_signal_p): Likewise.
4700         (unwind_on_terminating_exception_p): Likewise.
4701         * infcmd.c (startup_with_shell): Likewise.
4702         * inferior.c (print_inferior_events): Likewise.
4703         * inferior.h (startup_with_shell): Likewise.
4704         (print_inferior_events): Likewise.
4705         * infrun.c (step_stop_if_no_debug): Likewise.
4706         (detach_fork): Likewise.
4707         (debug_displaced): Likewise.
4708         (disable_randomization): Likewise.
4709         (non_stop): Likewise.
4710         (non_stop_1): Likewise.
4711         (observer_mode): Likewise.
4712         (observer_mode_1): Likewise.
4713         (set_observer_mode): Update.
4714         (sched_multi): Change to bool.
4715         * infrun.h (debug_displaced): Likewise.
4716         (sched_multi): Likewise.
4717         (step_stop_if_no_debug): Likewise.
4718         (non_stop): Likewise.
4719         (disable_randomization): Likewise.
4720         * linux-tdep.c (use_coredump_filter): Likewise.
4721         (dump_excluded_mappings): Likewise.
4722         * linux-thread-db.c (auto_load_thread_db): Likewise.
4723         (check_thread_db_on_load): Likewise.
4724         * main.c (captured_main_1): Update.
4725         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4726         xx2_opt, boolean_opt>: Change to bool.
4727         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4728         * maint.c (maintenance_profile_p): Likewise.
4729         (per_command_time): Likewise.
4730         (per_command_space): Likewise.
4731         (per_command_symtab): Likewise.
4732         * memattr.c (inaccessible_by_default): Likewise.
4733         * mi/mi-main.c (mi_async): Likewise.
4734         (mi_async_1): Likewise.
4735         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4736         * nat/fork-inferior.h (startup_with_shell): Likewise.
4737         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4738         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4739         * nios2-tdep.c (nios2_debug): Likewise.
4740         * or1k-tdep.c (or1k_debug): Likewise.
4741         * parse.c (parser_debug): Likewise.
4742         * parser-defs.h (parser_debug): Likewise.
4743         * printcmd.c (print_symbol_filename): Likewise.
4744         * proc-api.c (procfs_trace): Likewise.
4745         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4746         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4747         (set_parameter_value): Update.
4748         (add_setshow_generic): Update.
4749         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4750         to bool*.
4751         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4752         int*.
4753         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4754         * record-btrace.c (record_btrace_target::store_registers): Update.
4755         * record-full.c (record_full_memory_query): Change to bool.
4756         (record_full_stop_at_limit): Likewise.
4757         * record-full.h (record_full_memory_query): Likewise.
4758         * remote-notif.c (notif_debug): Likewise.
4759         * remote-notif.h (notif_debug): Likewise.
4760         * remote.c (use_range_stepping): Likewise.
4761         (interrupt_on_connect): Likewise.
4762         (remote_break): Likewise.
4763         * ser-tcp.c (tcp_auto_retry): Likewise.
4764         * ser-unix.c (serial_hwflow): Likewise.
4765         * skip.c (debug_skip): Likewise.
4766         * solib-aix.c (solib_aix_debug): Likewise.
4767         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4768         (spu_auto_flush_cache_p): Likewise.
4769         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4770         Likewise.
4771         (struct info_print_options) <quiet>: Likewise.
4772         * symfile-debug.c (debug_symfile): Likewise.
4773         * symfile.c (auto_solib_add): Likewise.
4774         (separate_debug_file_debug): Likewise.
4775         * symfile.h (auto_solib_add): Likewise.
4776         (separate_debug_file_debug): Likewise.
4777         * symtab.c (basenames_may_differ): Likewise.
4778         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4779         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4780         (struct info_types_options) <quiet>: Likewise.
4781         * symtab.h (demangle): Likewise.
4782         (basenames_may_differ): Likewise.
4783         * target-dcache.c (stack_cache_enabled_1): Likewise.
4784         (code_cache_enabled_1): Likewise.
4785         * target.c (trust_readonly): Likewise.
4786         (may_write_registers): Likewise.
4787         (may_write_memory): Likewise.
4788         (may_insert_breakpoints): Likewise.
4789         (may_insert_tracepoints): Likewise.
4790         (may_insert_fast_tracepoints): Likewise.
4791         (may_stop): Likewise.
4792         (auto_connect_native_target): Likewise.
4793         (target_stop_and_wait): Update.
4794         (target_async_permitted): Change to bool.
4795         (target_async_permitted_1): Likewise.
4796         (may_write_registers_1): Likewise.
4797         (may_write_memory_1): Likewise.
4798         (may_insert_breakpoints_1): Likewise.
4799         (may_insert_tracepoints_1): Likewise.
4800         (may_insert_fast_tracepoints_1): Likewise.
4801         (may_stop_1): Likewise.
4802         * target.h (target_async_permitted): Likewise.
4803         (may_write_registers): Likewise.
4804         (may_write_memory): Likewise.
4805         (may_insert_breakpoints): Likewise.
4806         (may_insert_tracepoints): Likewise.
4807         (may_insert_fast_tracepoints): Likewise.
4808         (may_stop): Likewise.
4809         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4810         (make_thread_apply_all_options_def_group): Change argument from int*
4811         to bool*.
4812         (thread_apply_all_command): Update.
4813         (print_thread_events): Change to bool.
4814         * top.c (confirm): Likewise.
4815         (command_editing_p): Likewise.
4816         (history_expansion_p): Likewise.
4817         (write_history_p): Likewise.
4818         (info_verbose): Likewise.
4819         * top.h (confirm): Likewise.
4820         (history_expansion_p): Likewise.
4821         * tracepoint.c (disconnected_tracing): Likewise.
4822         (circular_trace_buffer): Likewise.
4823         * typeprint.c (print_methods): Likewise.
4824         (print_typedefs): Likewise.
4825         * utils.c (debug_timestamp): Likewise.
4826         (sevenbit_strings): Likewise.
4827         (pagination_enabled): Likewise.
4828         * utils.h (sevenbit_strings): Likewise.
4829         (pagination_enabled): Likewise.
4830         * valops.c (overload_resolution): Likewise.
4831         * valprint.h (struct value_print_options) <prettyformat_arrays,
4832         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4833         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4834         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4835         Likewise.
4836         * windows-nat.c (new_console): Likewise.
4837         (cygwin_exceptions): Likewise.
4838         (new_group): Likewise.
4839         (debug_exec): Likewise.
4840         (debug_events): Likewise.
4841         (debug_memory): Likewise.
4842         (debug_exceptions): Likewise.
4843         (useshell): Likewise.
4844         * windows-tdep.c (maint_display_all_tib): Likewise.
4845         * xml-support.c (debug_xml): Likewise.
4846
4847 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4848
4849         * source.c (prepare_path_for_appending): New function.
4850         (openp): Make use of new function.
4851         (find_and_open_source): Search for the compilation directory and
4852         source file as a relative path beneath the directory search path.
4853
4854 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4855
4856         * source-cache.c (source_cache::get_line_charpos): Catch
4857         exceptions and return false, this matches the behaviour documented
4858         in the header file.
4859
4860 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4861
4862         * ada-tasks.c (info_task): Remove quoting of the task's name.
4863
4864 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4865
4866         * symfile.c (auto_solib_add): Replace comment with a reference
4867         to the header file.
4868
4869 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4870
4871         * NEWS: Mention that gdb can now be compiled with Python 3
4872         on Windows.
4873
4874 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * maint.c (maint_print_section_data::maint_print_section_data):
4877         Force use of 'float log10 (float)' by casting the argument to
4878         float.
4879
4880 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * maint.c: Add 'cmath' include.
4883         (struct maint_print_section_data): New structure.
4884         (print_section_index): New function.
4885         (print_bfd_section_info): Add header comment, small whitespace
4886         cleanup, and update to call new print_section_index function.
4887         (print_objfile_section_info): Likewise.
4888         (maint_obj_section_from_bfd_section): New function.
4889         (print_bfd_section_info_maybe_relocated): New function.
4890         (maintenance_info_sections): Add header comment, always use
4891         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4892
4893 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4894
4895         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4896         inner scope, add check that the objfile has psymtabs before
4897         checking psymtabs_addrmap.
4898         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4899
4900 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4901
4902         * NEWS: Announce that Ada task names are now shown at more places,
4903         and between quotes (except in info task output).
4904         * gdb/ada-tasks.c (task_to_str): New function.
4905         (display_current_task_id): Call task_to_str.
4906         (task_command_1): Likewise.
4907         (print_ada_task_info): In non-mi mode, Properly align headers and data
4908         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4909
4910 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4911
4912         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4913         prstatus.pr_lwp.pr_info instead of making it up.
4914
4915 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4916
4917         * auto-load.c (auto_load_expand_dir_vars): Update.
4918         * defs.h (gdb_datadir): Change to std::string.
4919         (python_libdir): Likewise.
4920         (relocate_gdb_directory): Change return type to std::string.
4921         * guile/guile.c (gdbscm_data_directory): Update.
4922         (initialize_scheme_side): Update.
4923         * jit.c (jit_reader_dir): Change to std::string.
4924         (jit_reader_load_command): Update.
4925         * main.c (gdb_datadir): Change to std::string.
4926         (python_libdir): Likewise.
4927         (set_gdb_data_directory): Update.
4928         (relocate_path): Change to return std::string.
4929         (relocate_gdb_directory): Change to return std::string.
4930         (relocate_gdbinit_path_maybe_in_datadir): Update.
4931         (captured_main_1): Update.
4932         * python/python.c (do_start_initialization): Update.
4933         * top.c (show_gdb_datadir): Update.
4934         * xml-syscall.c (xml_init_syscalls_info): Update.
4935         (init_syscalls_info): Update.
4936
4937 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4938
4939         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4940         out of get_init_files.
4941         (get_init_files): Update.
4942
4943 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4944
4945         * main.c (get_init_files): Change to use std::string.
4946         (captured_main_1): Update.
4947         (print_gdb_help): Update.
4948
4949 2019-09-11  Ali Tamur  <tamur@google.com>
4950
4951         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4952         implementation.
4953
4954 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4955
4956         * dbxread.c (read_dbx_symtab): Update.
4957         * dwarf2read.c (load_partial_dies): Update.
4958         * mdebugread.c (parse_partial_symbols): Update.
4959         (handle_psymbol_enumerators): Update.
4960         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4961         * psymtab.c (add_psymbol_to_bcache): Likewise.
4962         (add_psymbol_to_list): Likewise.
4963         * symtab.c (symbol_set_names): Likewise.
4964         * symtab.h (symbol_set_names): Likewise.
4965         * xcoffread.c (scan_xcoff_symtab): Update.
4966
4967 2019-09-11  Tom Tromey  <tom@tromey.com>
4968
4969         * symfile-mem.c (symbol_file_add_from_memory): Use
4970         bfd_set_filename.
4971         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4972         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4973
4974 2019-09-10  Tom Tromey  <tromey@adacore.com>
4975
4976         * dwarf-index-write.c (write_psymbols): Extend error message.
4977         (debug_names::insert): Add Ada code.
4978         (debug_names::write_psymbols): Remove Ada check.
4979         (debug_names) <m_string_obstack>: New member.
4980         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4981         (gdb_index_symbol_name_matcher::matches): Remove.
4982         (mapped_index_base::find_name_components_bounds): Add "lang"
4983         parameter.
4984         (mapped_index_base::build_name_components): Also split names
4985         according to Ada syntax.
4986         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4987         type of "match_callback".
4988         (check_match, check_find_bounds_finds)
4989         (dw2_expand_symtabs_matching): Update.
4990         (dw2_debug_names_iterator): Add new constructor.
4991         (dw2_debug_names_map_matching_symbols): New function.
4992         (dw2_debug_names_expand_symtabs_matching): Update.
4993         (dwarf2_debug_names_functions): Use
4994         dw2_debug_names_map_matching_symbols.
4995
4996 2019-09-10  Tom Tromey  <tromey@adacore.com>
4997
4998         * dwarf2read.c (dw2_get_file_names_reader): Add the
4999         CU's file name to the results.
5000
5001 2019-09-10  Tom Tromey  <tromey@adacore.com>
5002
5003         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5004         map_matching_symbols.  Update.
5005         * dwarf2read.c (dw2_map_matching_symbols): Update.
5006         * psymtab.c (match_partial_symbol): Change type; update.
5007         (psym_map_matching_symbols): Likewise.
5008         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5009         type; update.
5010         * symfile.h (struct quick_symbol_functions)
5011         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5012         Remove "match".
5013
5014 2019-09-10  Tom Tromey  <tromey@adacore.com>
5015
5016         * psymtab.c (map_block): Remove.
5017         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5018         * symtab.c (iterate_over_symbols_terminated): New function.
5019         * symtab.c (iterate_over_symbols_terminated): Declare.
5020
5021 2019-09-10  Tom Tromey  <tromey@adacore.com>
5022
5023         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5024         * language.h (struct language_defn) <la_iterate_over_symbols>:
5025         Return bool.
5026         * symtab.c (iterate_over_symbols): Return bool.
5027         * symtab.h (iterate_over_symbols): Return bool.
5028
5029 2019-09-10  Tom Tromey  <tromey@adacore.com>
5030
5031         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5032         (add_nonlocal_symbols): Update.
5033         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5034         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5035         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5036         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5037         Change type of "callback".  Remove "data".
5038
5039
5040 2019-09-09  Ali Tamur  <tamur@google.com>
5041
5042         * dwarf2read.c (comp_unit_head): Update comment.
5043         (dwarf2_dwo_name): New function declaration.
5044         (dwarf_unit_type_name): New function declaration.
5045         (read_comp_unit_head): Add support for new compilation units,
5046         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5047         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5048         (currently named as "signature") in their header. Also clarify error
5049         messages.
5050         (lookup_dwo_id): New function. Returns the dwo id of the given
5051         compile unit.
5052         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5053         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5054         functions.
5055         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5056         (dwarf2_dwo_name): Get the dwo name if present.
5057         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5058         purposes.
5059
5060 2019-09-09  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5063
5064 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5065
5066         * python/python.c (do_start_initialization): Make progname_copy static,
5067         to avoid a leak report.
5068
5069 2019-09-08  Tom Tromey  <tom@tromey.com>
5070
5071         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5072
5073 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5076         Change type to gdb::optional<block_enum>.
5077         (dw2_symtab_iter_init): Change block_index parameter type
5078         to gdb::optional<block_enum>.
5079         (dw2_lookup_symbol): Change block_index parameter
5080         type to block_enum.c
5081         (dw2_debug_names_lookup_symbol): Likewise.
5082         * psymtab.c (psym_lookup_symbol): Likewise.
5083         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5084         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5085         Likewise.
5086
5087 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5088
5089         * defs.h (relocate_gdb_directory): Change int to bool in
5090         signature and rename flag to relocatable.
5091         * main.c (relocate_path): Likewise.
5092         (relocate_gdb_directory): Likewise.
5093
5094 2019-09-06  Alan Modra  <amodra@gmail.com>
5095
5096         * coffread.c (coff_symfile_read): Constify filename variable.
5097         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5098         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5099         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5100         * solib.c (reload_shared_libraries_1): Likewise.
5101         * symfile.c (reread_symbols): Likewise.
5102         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5103         * solib-darwin.c (darwin_bfd_open): Likewise.
5104         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5105
5106 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5109         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5110
5111 2019-09-03  Tom Tromey  <tromey@adacore.com>
5112
5113         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5114         types.
5115         (has_negatives): Unbias a range type bound.
5116         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5117         * gdbtypes.c (operator==): Handle new field.
5118         (create_range_type): Add "bias" parameter.
5119         (create_static_range_type, resolve_dynamic_range): Update.
5120         * gdbtypes.h (struct range_bounds) <bias>: New member.
5121         (create_range_type): Add bias parameter.
5122         * printcmd.c (print_scalar_formatted): Unbias range types.
5123         * value.c (unpack_long): Unbias range types.
5124         (pack_long): Bias range types.
5125
5126 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5127
5128         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5129         probe arguments.
5130
5131 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5132
5133         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5134         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5135         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5136         (compile_probe_arg): Likewise.
5137         * probe.h (get_argument_count): Likewise.
5138         * solib-svr4.c (solib_event_probe_action): Likewise.
5139         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5140
5141 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5142
5143         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5144         code to here...
5145         (svr4_create_solib_event_breakpoints): ...from here.
5146
5147 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5148
5149         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5150         suffix from warning message.
5151
5152 2019-08-30  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-winsource.h (struct tui_source_window_base)
5155         <refresh_all>: Don't declare.
5156         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5157         Remove.
5158         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5159         tui_show_locator_content.
5160         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5161         declare.
5162         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5163         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5164         declare.
5165
5166 2019-08-30  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5169
5170 2019-08-30  Tom Tromey  <tom@tromey.com>
5171
5172         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5173         Remove unnecessary forward declarations.
5174
5175 2019-08-30  Tom Tromey  <tom@tromey.com>
5176
5177         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5178         rerender.
5179         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5180         tui_show_locator_content.
5181
5182 2019-08-30  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5185         (tui_locator_window::rerender): Rewrite using body of previous
5186         tui_show_locator_content.
5187
5188 2019-08-30  Tom Tromey  <tom@tromey.com>
5189
5190         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5191         set_locator_fullname>: New methods.
5192         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5193         Rename from tui_set_locator_fullname.
5194         (tui_locator_window::set_locator_info): Rename from
5195         tui_set_locator_info.  Return bool.
5196         (tui_update_locator_fullname, tui_show_frame_info): Update.
5197
5198 2019-08-30  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5201
5202 2019-08-30  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5205         call touchwin.
5206
5207 2019-08-30  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-wingeneral.c (box_win): Assume win_info and
5210         win_info->handle cannot be NULL.
5211
5212 2019-08-30  Tom Tromey  <tom@tromey.com>
5213
5214         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5215         refresh_window>: Declare.
5216         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5217         resize.
5218         (tui_data_item_window::rerender): Rename from
5219         tui_display_register.
5220         (tui_data_item_window::refresh_window): New method.
5221         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5222         no-op.
5223
5224 2019-08-30  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5227         regs_column_count, current_group>: Move later.  Now private.
5228         <get_current_group>: New method.
5229         * tui/tui-regs.c (tui_reg_command): Update.
5230         * tui/tui-layout.c (tui_set_layout): Update.
5231
5232 2019-08-30  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5235         (tui_data_window::rerender): Don't call
5236         check_and_display_highlight_if_needed.
5237         (tui_data_window::refresh_all): Remove call to
5238         erase_data_content.
5239
5240 2019-08-30  Tom Tromey  <tom@tromey.com>
5241
5242         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5243         (tui_data_window::display_registers_from)
5244         (tui_data_window::display_reg_element_at_line)
5245         (tui_data_window::display_registers_from_line): Remove checks of
5246         "empty".
5247
5248 2019-08-30  Tom Tromey  <tom@tromey.com>
5249
5250         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5251         Don't declare.
5252         * tui/tui-regs.c (tui_data_window::show_registers): Call
5253         rerender.
5254         (tui_data_window::rerender): Rename from display_all_data.
5255         (tui_data_window::rerender): Remove old implementation.
5256
5257 2019-08-30  Tom Tromey  <tom@tromey.com>
5258
5259         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5260         text.
5261         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5262
5263 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5264             Sergio Durigan Junior  <sergiodj@redhat.com>
5265
5266         PR win32/24284
5267         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5268
5269 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5272         when searching for types.
5273
5274 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5275
5276         * f-lang.c (f_language_defn): Use f_print_typedef.
5277         * f-lang.h (f_print_typedef): Declare.
5278         * f-typeprint.c (f_print_typedef): Define.
5279
5280 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5281
5282         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5283
5284 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * cli/cli-utils.c (info_print_options_defs): Delete.
5287         (make_info_print_options_def_group): Delete.
5288         (extract_info_print_options): Delete.
5289         (info_print_command_completer): Delete.
5290         (info_print_args_help): Add extra parameter, and optionally
5291         include text about -n flag.
5292         * cli/cli-utils.h (struct info_print_options): Delete.
5293         (extract_info_print_options): Delete declaration.
5294         (info_print_command_completer): Delete declaration.
5295         (info_print_args_help): Add extra parameter, extend header
5296         comment.
5297         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5298         search_symbols.
5299         * stack.c (struct info_print_options): New type.
5300         (info_print_options_defs): New file scoped variable.
5301         (make_info_print_options_def_group): New static function.
5302         (info_print_command_completer): New static function.
5303         (info_locals_command): Update to use new local functions.
5304         (info_args_command): Likewise.
5305         (_initialize_stack): Add extra parameter to calls to
5306         info_print_args_help.
5307         * symtab.c (search_symbols): Add extra parameter, use this to
5308         possibly excluse non-debug symbols.
5309         (symtab_symbol_info): Add extra parameter, which is passed on to
5310         search_symbols.
5311         (struct info_print_options): New type.
5312         (info_print_options_defs): New file scoped variable.
5313         (make_info_print_options_def_group): New static function.
5314         (info_print_command_completer): New static function.
5315         (info_variables_command): Update to use local functions, and pass
5316         extra parameter through to symtab_symbol_info.
5317         (info_functions_command): Likewise.
5318         (info_types_command): Pass additional argument through to
5319         symtab_symbol_info.
5320         (rbreak_command): Pass extra argument to search_symbols.
5321         (_initialize_symtab): Add extra arguments for calls to
5322         info_print_args_help, and update help text for 'info variables',
5323         'whereis', and 'info functions' commands.
5324         * symtab.h (search_symbols): Add extra argument to declaration.
5325         * NEWS: Mention new flags.
5326
5327 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5328
5329         * symtab.c (lookup_static_symbol): Call the new function (and move
5330         it down to be next to lookup_global_symbol).
5331         (struct global_sym_lookup_data): Add block_enum member and rename to...
5332         (struct global_or_static_sym_lookup_data): ...this.
5333         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5334         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5335         (lookup_symbol_global_or_static_iterator_cb): ...this.
5336         (lookup_global_or_static_symbol): New function.
5337         (lookup_global_symbol): Call new function.
5338
5339 2019-08-26  Tom de Vries  <tdevries@suse.de>
5340
5341         PR c++/24852
5342         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5343         when pc_probe.prob == NULL.
5344
5345 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5346
5347         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5348         variable symbol_linkage to symbol_linkage_.
5349
5350 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5351
5352         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5353         represent whether the symbol is static, dynamic, or we don't
5354         know.
5355
5356 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5357
5358         * gdb/rx-tdep.c (rx_register_names): New.
5359         (rx_register_name): Delete.
5360         (rx_psw_type): Delete.
5361         (rx_fpsw_type): Delete.
5362         (rx_register_type): Delete.
5363         (rx_gdbarch_init): Convert target-descriptions.
5364         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5365         * gdb/features/Makefile: Add rx.xml.
5366         * gdb/features/rx.xml: New.
5367         * gdb/features/rx.c: Generated.
5368         * gdb/NEWS: Mention target description support.
5369
5370 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5371
5372         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5373         *slot_ptr.
5374
5375 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5376
5377         * configure.ac: Don't check for 'dlfcn.h' (moved to
5378         gdbsupport/common.m4).
5379         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5380         'gdbsupport/'.
5381         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5382         * compile/compile-c-support.c: Include
5383         'gdbsupport/gdb-dlfcn.h'.
5384         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5385         * gdb-dlfcn.c: Move to...
5386         * gdbsupport/gdb-dlfcn.c: ... here.
5387         * gdb-dlfcn.h: Move to...
5388         * gdbsupport/gdb-dlfcn.h: ... here.
5389
5390 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5391
5392         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5393         the offset field signed.
5394
5395 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5396
5397         * python/lib/gdb/__init__.py (_execute_file): New function.
5398         * python/python.c (python_run_simple_file): Call gdb._execute_file
5399         on Windows.
5400
5401 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5404         all uses as this was never set to anything but a zero value.
5405
5406 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5407
5408         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5409
5410 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5411
5412         * tui/tui-data.h (tui_gen_win_info): Add an =default
5413         move constructor, required by some GCC versions.
5414
5415 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5416
5417         * go32-nat.c (go32_sysinfo): Add hygon_p.
5418
5419 2019-08-20  Tom Tromey  <tom@tromey.com>
5420
5421         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5422         line_from_reg_element_no, first_reg_element_no_inline,
5423         display_all_data, delete_data_content_windows,
5424         erase_data_content>: Now private.
5425
5426 2019-08-20  Tom Tromey  <tom@tromey.com>
5427
5428         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5429         (tui_unhighlight_win, tui_highlight_win)
5430         (tui_win_info::make_window): Update.
5431         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5432
5433 2019-08-20  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5436         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5437         (MAX_PID_WIDTH): Move to tui-stack.c.
5438         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5439         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5440         (MAX_PID_WIDTH): Move from tui-data.h.
5441
5442 2019-08-20  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5445         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5446         (box_win): Update.
5447         (tui_gen_win_info::make_window): Rename from tui_make_window.
5448         (tui_win_info::make_window): New method.
5449         (tui_gen_win_info::make_visible): Update.
5450         * tui/tui-source.c (tui_source_window::set_contents): Update.
5451         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5452         (tui_data_window::display_registers_from): Update.
5453         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5454         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5455         Declare.
5456         <can_box>: Remove.
5457         <title>: Remove.
5458         (struct tui_win_info) <make_window>: Declare.
5459         <can_box>: Now virtual.
5460         <title>: New member.
5461         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5462         * tui/tui-command.c (tui_cmd_window::resize): Update.
5463
5464 2019-08-20  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5467         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5468         (tui_data_window::check_register_values): Update.
5469
5470 2019-08-20  Tom Tromey  <tom@tromey.com>
5471
5472         * tui/tui-regs.h (struct tui_data_window): Use
5473         DISABLE_COPY_AND_ASSIGN.
5474         <regs_content>: Change type, removing unique_ptr.
5475         <tui_data_window>: Add move constructor.
5476         * tui/tui-regs.c (tui_data_window::show_registers)
5477         (tui_data_window::show_register_group)
5478         (tui_data_window::display_registers_from)
5479         (tui_data_window::display_registers_from)
5480         (tui_data_window::first_data_item_displayed)
5481         (tui_data_window::delete_data_content_windows)
5482         (tui_data_window::rerender, tui_data_window::refresh_window)
5483         (tui_data_window::check_register_values): Update.
5484
5485 2019-08-20  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5488         show_register_group>: Declare.
5489         (tui_show_register_group): Don't declare.
5490         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5491         tui_show_registers.
5492         (tui_data_window::show_register_group): Rename from
5493         tui_show_register_group.
5494         (tui_data_window::check_register_values, tui_reg_command):
5495         Update.
5496         * tui/tui-layout.c (tui_set_layout): Update.
5497
5498 2019-08-20  Tom Tromey  <tom@tromey.com>
5499
5500         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5501         Declare.
5502         (tui_check_register_values): Don't declare.
5503         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5504         from tui_check_register_values.
5505         * tui/tui-hooks.c (tui_register_changed): Update.
5506
5507 2019-08-20  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-regs.c (tui_reg_layout): Move later.
5510         (tui_show_registers): Don't enable TUI mode or change layout.
5511
5512 2019-08-20  Tom Tromey  <tom@tromey.com>
5513
5514         * tui/tui-regs.h (struct tui_data_item_window)
5515         <~tui_data_item_window>: Remove.
5516         <content>: Now a unique_xmalloc_ptr.
5517         * tui/tui-regs.c (tui_register_format): Return a
5518         unique_xmalloc_ptr.
5519         (tui_get_register): Update.
5520         (~tui_data_item_window): Remove.
5521         (tui_data_window::display_registers_from, tui_display_register):
5522         Update.
5523         * tui/tui-io.h (tui_expand_tabs): Update.
5524         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5525         Remove "col" parameter.
5526
5527 2019-08-20  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5530         field.
5531         * tui/tui-regs.c (~tui_data_item_window): Update.
5532
5533 2019-08-20  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5536         earlier.
5537
5538 2019-08-20  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5541
5542 2019-08-20  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-source.h (struct tui_source_window): Update.
5545         * tui/tui-regs.c (tui_show_registers): Update.
5546         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5547         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5548         (NO_REGS_STRING): Remove defines.
5549
5550 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5551
5552         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5553         unnecessary thread walk if remote doesn't support the packet.
5554
5555 2019-08-19  Tom Tromey  <tromey@adacore.com>
5556
5557         * python/py-value.c (value_has_field): Fix indentation.
5558
5559 2019-08-19  Tom Tromey  <tromey@adacore.com>
5560
5561         * printcmd.c (do_one_display, info_display_command): Update.
5562         * block.h (contained_in): Return bool.  Add allow_nested
5563         parameter.
5564         * block.c (contained_in): Return bool.  Add allow_nested
5565         parameter.
5566
5567 2019-08-19  Tom Tromey  <tom@tromey.com>
5568
5569         * configure: Rebuild.
5570         * configure.ac: Disallow the combination of -static-libstdc++ and
5571         source highlight.
5572         * source-cache.c (get_language_name): Handle rust.
5573         (source_cache::get_source_lines): Ignore highlighting exceptions.
5574
5575 2019-08-16  Tom Tromey  <tom@tromey.com>
5576
5577         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5578         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5579         (struct tui_source_window_base) <make_visible, refresh_window,
5580         resize>: Remove methods.
5581         <execution_info>: Remove field.
5582         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5583         (tui_show_source_line, tui_source_window_base)
5584         (~tui_source_window_base): Update.
5585         (tui_source_window_base::resize)
5586         (tui_source_window_base::make_visible)
5587         (tui_source_window_base::refresh_window): Remove.
5588         (tui_source_window_base::update_exec_info): Update.
5589         * tui/tui-source.c (tui_source_window::set_contents): Update.
5590         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5591
5592 2019-08-16  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5595         deprecated_query_hook.
5596
5597 2019-08-16  Tom Tromey  <tom@tromey.com>
5598
5599         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5600         (tui_update_source_windows_with_line): Update.
5601         * tui/tui-source.h (struct tui_source_window)
5602         <show_symtab_source>: Declare.
5603         (tui_show_symtab_source): Don't declare.
5604         * tui/tui-source.c (tui_show_symtab_source): Rename from
5605         tui_show_symtab_source.
5606
5607 2019-08-16  Tom Tromey  <tom@tromey.com>
5608
5609         * tui/tui-winsource.h (struct tui_source_window_base)
5610         <set_contents>: Declare.
5611         * tui/tui-winsource.c
5612         (tui_source_window_base::update_source_window_as_is): Update.
5613         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5614         Declare.
5615         (tui_set_source_content): Don't declare.
5616         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5617         tui_set_source_content.
5618         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5619         Declare.
5620         (tui_set_disassem_content): Don't declare.
5621         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5622         tui_set_disassem_content.
5623
5624 2019-08-16  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-winsource.h (struct tui_source_window_base)
5627         <update_breakpoint_info>: Declare.
5628         (tui_update_breakpoint_info): Don't declare.
5629         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5630         (tui_update_all_breakpoint_info): Update.
5631         (tui_source_window_base::update_breakpoint_info): Rename from
5632         tui_update_breakpoint_info.
5633         (tui_source_window_base::update_exec_info): Update.
5634
5635 2019-08-16  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui-winsource.h (struct tui_source_window_base)
5638         <update_source_window>: Declare.
5639         (tui_update_source_window): Don't declare.
5640         * tui/tui-winsource.c
5641         (tui_source_window_base::update_source_window): Rename from
5642         tui_update_source_window.
5643         (tui_source_window_base::rerender): Update.
5644         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5645         * tui/tui-disasm.c (tui_show_disassem)
5646         (tui_show_disassem_and_update_source)
5647         (tui_disasm_window::maybe_update): Update.
5648
5649 2019-08-16  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-winsource.h (struct tui_source_window_base)
5652         <update_source_window_as_is>: Declare.
5653         (tui_update_source_window_as_is): Don't declare.
5654         * tui/tui-winsource.c (tui_update_source_window): Update
5655         (tui_source_window_base::update_source_window_as_is): Rename from
5656         tui_update_source_window_as_is.
5657         (tui_source_window_base::refill): Update.
5658         * tui/tui-source.c (tui_show_symtab_source): Update.
5659         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5660         Update.
5661
5662 2019-08-16  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-winsource.h (tui_update_source_window)
5665         (tui_update_source_window_as_is): Remove "noerror" parameter.
5666         * tui/tui-winsource.c (tui_update_source_window)
5667         (tui_update_source_window_as_is): Remove "noerror" parameter.
5668         (tui_update_source_windows_with_addr)
5669         (tui_update_source_windows_with_line)
5670         (tui_source_window_base::rerender)
5671         (tui_source_window_base::refill): Update.
5672         * tui/tui-source.h (tui_set_source_content)
5673         (tui_show_symtab_source): Remove "noerror" parameter.
5674         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5675         parameter.
5676         (tui_show_symtab_source): Likewise.
5677         (tui_source_window::maybe_update): Update.
5678         * tui/tui-disasm.c (tui_show_disassem)
5679         (tui_show_disassem_and_update_source)
5680         (tui_disasm_window::do_scroll_vertical)
5681         (tui_disasm_window::maybe_update): Update.
5682
5683 2019-08-16  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui.c (tui_is_window_visible): Update.
5686         * tui/tui-wingeneral.c (tui_make_window)
5687         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5688         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5689         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5690         (tui_set_win_height_command, parse_scrolling_args): Update.
5691         * tui/tui-source.c (tui_source_window::style_changed): Update.
5692         * tui/tui-regs.c (tui_show_registers)
5693         (tui_data_window::first_data_item_displayed)
5694         (tui_data_window::delete_data_content_windows)
5695         (tui_check_register_values, tui_reg_command): Update.
5696         * tui/tui-disasm.c (tui_show_disassem): Update.
5697         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5698         method.
5699         <is_visible>: Remove field.
5700         * tui/tui-data.c (tui_next_win, tui_prev_win)
5701         (tui_delete_invisible_windows): Update.
5702
5703 2019-08-16  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-winsource.h (struct tui_source_window_base)
5706         <m_has_locator>: Remove.
5707         * tui/tui-layout.c (show_source_disasm_command, show_data)
5708         (show_source_or_disasm_and_command): Update.
5709
5710 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5711
5712         * NEWS (Other MI changes): New subsection.
5713         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5714         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5715         * arch-utils.c (default_get_pc_address_flags): New function.
5716         * arch-utils.h (default_get_pc_address_flags): New declaration.
5717         * gdbarch.sh: Add get_pc_address_flags.
5718         * gdbarch.c: Regenerate.
5719         * gdbarch.h: Likewise.
5720         * stack.c (print_pc): New function.
5721         (print_frame_info) (print_frame): Call print_pc.
5722
5723 2019-08-16  Tom de Vries  <tdevries@suse.de>
5724
5725         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5726         print_objfile_section_info.
5727
5728 2019-08-15  Tom Tromey  <tom@tromey.com>
5729
5730         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5731         calling update_cmdwin_start_line.
5732         * tui/tui-winsource.h (struct tui_source_window_base)
5733         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5734         <rerender>: Declare.
5735         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5736         Call rerender.
5737         (tui_source_window_base::set_new_height): Remove.
5738         (tui_source_window_base::rerender): Rename from
5739         do_make_visible_with_new_height.
5740         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5741         resize method.
5742         (tui_win_info::make_invisible_and_set_new_height)
5743         (tui_win_info::make_visible_with_new_height): Remove.
5744         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5745         Declare.
5746         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5747         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5748         do_make_visible_with_new_height>: Don't declare.
5749         <rerender>: Declare.
5750         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5751         set_new_height.
5752         (tui_data_window::do_make_visible_with_new_height): Remove.
5753         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5754         call tui_show_locator_content.
5755         (tui_gen_win_info::resize): Call rerender.
5756         (show_source_or_disasm_and_command): Don't call
5757         tui_show_locator_content.
5758         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5759         method.
5760         (struct tui_win_info) <rerender>: Declare.
5761         <set_new_height, make_invisible_and_set_new_height,
5762         make_visible_with_new_height>: Don't declare.
5763         * tui/tui-data.c (tui_win_list::rerender): New method.
5764         * tui/tui-command.h (struct tui_cmd_window)
5765         <do_make_visible_with_new_height>: Don't declare.
5766         * tui/tui-command.c
5767         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5768
5769 2019-08-15  Tom Tromey  <tromey@adacore.com>
5770
5771         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5772         * ada-lang.c (ada_enum_name): Likewise.
5773
5774 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5775
5776         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5777         leading underscore.
5778         (GdbOutputErrorFile): Likewise.
5779         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5780         accordingly.
5781         (execute_unwinders): Rename to have a leading underscore.
5782         (auto_load_packages): Likewise.
5783         (global scope): Adjust call to auto_load_packages accordingly.
5784         (GdbSetPythonDirectory): Likewise.
5785         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5786         instead of execute_unwinders.
5787
5788 2019-08-15  Tom Tromey  <tom@tromey.com>
5789
5790         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5791         (show_data): Don't change window visibility.
5792         (tui_gen_win_info::resize): Remove special case for command
5793         window.  Use wresize, when available.
5794         (show_source_or_disasm_and_command): Don't change window
5795         visibility.
5796         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5797         <make_visible>: New method.
5798         * tui/tui-command.c (tui_cmd_window::resize): New method.
5799
5800 2019-08-15  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5803         (struct tui_source_windows): New.
5804         * tui/tui-winsource.c (tui_display_main): Update.
5805         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5806         (new_height_ok, parse_scrolling_args): Update.
5807         * tui/tui-layout.c (show_layout, show_data): Update.
5808         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5809         (tui_add_to_source_windows): Don't declare.
5810         * tui/tui-data.c (source_windows, tui_source_windows)
5811         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5812
5813 2019-08-15  Tom Tromey  <tom@tromey.com>
5814
5815         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5816         Rename from reset.
5817         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5818         * tui/tui-layout.c (show_source_disasm_command, show_data):
5819         Update.
5820         (tui_gen_win_info::resize): Rename.
5821         (show_source_or_disasm_and_command): Update.
5822         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5823         reset.
5824
5825 2019-08-15  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5828         * tui/tui-interp.c (tui_interp::init): Don't call
5829         tui_initialize_static_data.
5830         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5831
5832 2019-08-15  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5835         examine tui_win_list.
5836
5837 2019-08-15  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5840         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5841         tui_clear_source_content.
5842         (tui_clear_source_content): Remove.
5843         (tui_source_window_base::do_erase_source_content): Hoist call to
5844         content.clear().
5845         * tui/tui-stack.c (tui_show_frame_info): Don't call
5846         tui_clear_source_content.
5847
5848 2019-08-15  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-winsource.h (struct tui_source_window_base)
5851         <do_erase_source_content>: New method.
5852         <erase_source_content>: New method.
5853         (tui_erase_source_content): Don't declare.
5854         * tui/tui-winsource.c (tui_clear_source_content): Update.
5855         (tui_source_window_base::do_erase_source_content): Rename from
5856         tui_erase_source_content.
5857         (tui_source_window_base::show_source_content): Update.
5858         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5859         * tui/tui-source.h (struct tui_source_window)
5860         <erase_source_content>: New method.
5861         * tui/tui-disasm.h (struct tui_disasm_window)
5862         <erase_source_content>: New method.
5863
5864 2019-08-15  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5867         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5868         constructor.
5869         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5870         * tui/tui-source.c (tui_set_source_content): Update.
5871         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5872
5873 2019-08-15  Tom Tromey  <tom@tromey.com>
5874
5875         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5876         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5877         tui-source.c.
5878         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5879         Declare.
5880         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5881         method.
5882         (tui_source_window::maybe_update): Update.
5883
5884 2019-08-15  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5887         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5888         tui-disasm.c.
5889         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5890         Declare.
5891         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5892         method.
5893         (tui_disasm_window::maybe_update): Update.
5894
5895 2019-08-15  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-winsource.h (struct tui_source_window_base)
5898         <maybe_update>: Declare.
5899         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5900         method.
5901         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5902         Declare.
5903         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5904         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5905         Declare.
5906         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5907
5908 2019-08-15  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5911
5912 2019-08-15  Tom Tromey  <tom@tromey.com>
5913
5914         * tui/tui-wingeneral.c: Include tui-stack.h.
5915         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5916         (struct tui_locator_window): Move from tui-data.h.
5917         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5918         (tui_initialize_static_data): Move from tui-data.c.
5919         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5920         (struct tui_locator_window): Move to tui-stack.c.
5921         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5922         (tui_initialize_static_data): Move to tui-stack.c.
5923
5924 2019-08-15  Tom Tromey  <tom@tromey.com>
5925
5926         * tui/tui-layout.c (show_source_disasm_command)
5927         (show_source_or_disasm_and_command): Use make_visible method, not
5928         tui_make_window.
5929         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5930         Remove.
5931
5932 2019-08-15  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-wingeneral.h (tui_make_window): Update.
5935         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5936         parameter.
5937         (tui_gen_win_info::make_visible): Update.
5938         * tui/tui-regs.c (tui_data_window::display_registers_from):
5939         Update.
5940         * tui/tui-layout.c (show_source_disasm_command)
5941         (show_source_or_disasm_and_command): Update.
5942         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5943         (enum tui_box): Remove.
5944         (struct tui_win_info) <can_box>: New method.
5945         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5946         method.
5947
5948 2019-08-15  Tom de Vries  <tdevries@suse.de>
5949
5950         * linux-nat-trad.c: Include gdbarch.h.
5951
5952 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5953
5954         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5955         register sizes.
5956
5957 2019-08-14  Tom Tromey  <tromey@adacore.com>
5958
5959         * darwin-nat.c: Include gdbarch.h.
5960         * darwin-nat-info.c: Include gdbarch.h.
5961
5962 2019-08-13  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5965         Remove.
5966         * tui/tui-data.c (tui_initialize_static_data): Update.
5967
5968 2019-08-13  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-winsource.h (struct tui_exec_info_window)
5971         <~tui_exec_info_window, maybe_allocate_content, get_content,
5972         m_content>: Remove.
5973         (struct tui_source_window_base) <set_exec_info_content,
5974         show_exec_info_content>: Don't declare.
5975         * tui/tui-winsource.c
5976         (tui_exec_info_window::maybe_allocate_content): Remove.
5977         (tui_source_window_base::update_exec_info): Rename from
5978         set_exec_info_content.
5979         (tui_source_window_base::show_exec_info_content)
5980         (tui_source_window_base::update_exec_info): Remove.
5981
5982 2019-08-13  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5985         declare.
5986         * tui/tui-winsource.c (tui_update_source_window_as_is)
5987         (tui_update_source_windows_with_addr, tui_erase_source_content):
5988         Update.
5989         (tui_clear_exec_info_content): Remove.
5990
5991 2019-08-13  Tom Tromey  <tom@tromey.com>
5992
5993         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5994         declare.
5995         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5996         call tui_erase_exec_info_content.
5997         (tui_clear_exec_info_content): Rename from
5998         tui_erase_exec_info_content.
5999         (tui_clear_exec_info_content): Delete.
6000
6001 2019-08-13  Tom Tromey  <tom@tromey.com>
6002
6003         * tui/tui-winsource.h (struct tui_source_window_base)
6004         <show_exec_info_content>: Declare.
6005         (tui_show_exec_info_content): Don't declare.
6006         * tui/tui-winsource.c
6007         (tui_source_window_base::show_exec_info_content): Rename from
6008         tui_show_exec_info_content.
6009         (tui_source_window_base::update_exec_info): Update.
6010
6011 2019-08-13  Tom Tromey  <tom@tromey.com>
6012
6013         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6014         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6015         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6016         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6017         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6018         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6019         ... here.
6020
6021 2019-08-13  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-winsource.h (struct tui_source_window_base)
6024         <update_exec_info>: Declare.
6025         (tui_update_exec_info): Don't declare.
6026         * tui/tui-winsource.c (tui_update_source_window_as_is)
6027         (tui_source_window_base::refresh_all)
6028         (tui_update_all_breakpoint_info): Update.
6029         (tui_source_window_base::update_exec_info): Rename from
6030         tui_update_exec_info.
6031         * tui/tui-stack.c (tui_show_frame_info): Update.
6032
6033 2019-08-13  Tom Tromey  <tom@tromey.com>
6034
6035         * tui/tui-winsource.h (struct tui_source_window_base)
6036         <set_exec_info_content>: Declare.
6037         (tui_set_exec_info_content): Don't declare.
6038         * tui/tui-winsource.c
6039         (tui_source_window_base::set_exec_info_content): Rename from
6040         tui_set_exec_info_content.
6041         (tui_update_exec_info): Update.
6042
6043 2019-08-13  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-winsource.h (struct tui_source_window_base)
6046         <show_source_content>: Declare.
6047         (tui_show_source_content): Don't declare.
6048         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6049         (tui_source_window_base::show_source_content): Rename from
6050         tui_show_source_content.
6051         (tui_source_window_base::refresh_all): Update.
6052         * tui/tui-layout.c (show_source_disasm_command)
6053         (show_source_or_disasm_and_command): Update.
6054
6055 2019-08-13  Tom Tromey  <tom@tromey.com>
6056
6057         * tui/tui-winsource.c (tui_erase_source_content)
6058         (tui_show_source_content, tui_source_window_base::refresh_all):
6059         Update.
6060         * tui/tui-wingeneral.h
6061         (tui_check_and_display_highlight_if_needed): Don't declare.
6062         * tui/tui-wingeneral.c
6063         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6064         check_and_display_highlight_if_needed.
6065         * tui/tui-win.c (tui_rehighlight_all)
6066         (tui_win_info::make_visible_with_new_height): Update.
6067         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6068         (tui_data_window::erase_data_content)
6069         (tui_data_window::display_all_data): Update.
6070         * tui/tui-data.h (struct tui_win_info)
6071         <check_and_display_highlight_if_needed>: Declare.
6072
6073 2019-08-13  Tom Tromey  <tom@tromey.com>
6074
6075         * tui/tui-win.c (tui_resize_all): Call
6076         tui_delete_invisible_windows.
6077         * tui/tui-layout.c (show_layout): Call
6078         tui_delete_invisible_windows.
6079         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6080         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6081
6082 2019-08-13  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6085         tui_add_win_to_layout.
6086
6087 2019-08-13  Tom Tromey  <tom@tromey.com>
6088
6089         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6090         * tui/tui-layout.c (tui_default_win_height): Now static.
6091
6092 2019-08-13  Tom Tromey  <tom@tromey.com>
6093
6094         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6095         single switch.
6096         (show_source_disasm_command, show_source_or_disasm_and_command):
6097         Don't check current layout.
6098
6099 2019-08-13  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-wingeneral.c (make_all_visible): Remove.
6102         (tui_make_all_invisible): Simplify.
6103         * tui/tui-layout.c (tui_make_all_invisible): Move from
6104         tui-wingeneral.c; simplify.
6105         (show_layout): Hoist call to tui_make_all_invisible.
6106         (show_data): Don't call tui_make_all_invisible.
6107
6108 2019-08-13  Tom Tromey  <tom@tromey.com>
6109
6110         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6111         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6112
6113 2019-08-13  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6116         tui-data.c.
6117         (show_source_disasm_command, show_data)
6118         (show_source_or_disasm_and_command): Don't use
6119         tui_set_current_layout_to.
6120         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6121         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6122         tui-layout.c.
6123         (tui_set_current_layout_to): Remove.
6124
6125 2019-08-13  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-layout.c (tui_set_layout): Update.
6128         * tui/tui-data.h (struct tui_layout_def): Remove.
6129         (tui_layout_def): Don't declare.
6130         * tui/tui-data.c (layout_def): Remove.
6131         (tui_layout_def): Remove.
6132
6133 2019-08-13  Tom Tromey  <tom@tromey.com>
6134
6135         * tui/tui-winsource.h (struct tui_source_window_base)
6136         <clear_detail>: No longer "override".
6137         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6138         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6139         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6140         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6141         Remove.
6142         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6143
6144 2019-08-13  Tom Tromey  <tromey@adacore.com>
6145
6146         * tracepoint.c: Don't include readline.h or history.h.
6147
6148 2019-08-12  Tom Tromey  <tom@tromey.com>
6149
6150         * configure: Rebuild.
6151         * configure.ac: Check for readline 7.
6152         * NEWS: Mention readline 7 requirement.
6153         * README: Update.
6154
6155 2019-08-12  Tom Tromey  <tom@tromey.com>
6156
6157         * mingw-hdep.c (gdb_select): Remove readline hack.
6158
6159 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6160
6161         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6162         when the function fails.
6163
6164 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6165
6166         * s390-tdep.c (s390_type_align): New function.
6167         (s390_gdbarch_init): Set it as type_align gdbarch method.
6168
6169 2019-08-09  Tom de Vries  <tdevries@suse.de>
6170
6171         PR gdb/24591
6172         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6173         pc_low with relocation offset.
6174
6175 2019-08-07  Tom Tromey  <tromey@adacore.com>
6176
6177         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6178         (print_frame_args): Update.
6179         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6180         Update.
6181         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6182         * frame.h (struct frame_arg): Add initializers.
6183         <error>: Now a unique_xmalloc_ptr.
6184
6185 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6186
6187         * NEWS: Expand the Pointer Authentication entry.
6188         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6189         (aarch64_frame_unmask_lr): ... to this.
6190         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6191         Call aarch64_frame_unmask_lr.
6192         * frame.c (struct frame_info): Add "masked" variable.
6193         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6194         (fprint_frame): Check for masked pc.
6195         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6196         declarations.
6197         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6198         * stack.c (print_frame): Check for masked pc.
6199
6200 2019-08-06  Tom Tromey  <tom@tromey.com>
6201
6202         * stabsread.c (patch_block_stabs, read_one_struct_field)
6203         (read_enum_type): Use obstack_strndup.
6204         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6205         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6206         * dwarf2read.c (guess_full_die_structure_name)
6207         (anonymous_struct_prefix): Use obstack_strndup.
6208         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6209         * c-exp.y (yylex): Use obstack_strndup.
6210         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6211         (write_var_or_type): Use obstack_strndup.
6212
6213 2019-08-06  Tom Tromey  <tom@tromey.com>
6214
6215         * symfile.c (reread_symbols): Use obstack_strdup.
6216         * stabsread.c (read_type): Use obstack_strdup.
6217         * gdb_obstack.h (obstack_strdup): New overload.
6218         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6219         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6220         (dwarf2_canonicalize_name): Use obstack_strdup.
6221         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6222         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6223         Use obstack_strdup.
6224
6225 2019-08-06  Tom Tromey  <tom@tromey.com>
6226
6227         * gdb_obstack.h (obstack_strdup): Define.
6228         * gdb_obstack.c (obstack_strdup): Don't define.
6229
6230 2019-08-06  Tom Tromey  <tom@tromey.com>
6231
6232         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6233         obstack_strdup.
6234         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6235         obstack_strdup.
6236         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6237         * stabsread.c (common_block_start): Use obstack_strdup.
6238         * objfiles.c (set_objfile_main_name, objfile): Use
6239         obstack_strdup.
6240         * namespace.c (add_using_directive): Use obstack_strdup.
6241         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6242         * jit.c (finalize_symtab): Use obstack_strdup.
6243         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6244         (guess_partial_die_structure_name, partial_die_info::fixup)
6245         (dwarf2_name): Use obstack_strdup.
6246         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6247         obstack_strdup.
6248         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6249         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6250         obstack_strdup.
6251         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6252
6253 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6254
6255         * unittests/help-doc-selftests.c: New file.
6256         * Makefile.in: Add the new file.
6257
6258 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6259
6260         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6261         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6262         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6263         the trailing '.' is not output, and the first character is uppercased.
6264         (print_help_for_command): Update call to print_doc_line.
6265         (print_doc_of_command): Likewise.
6266         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6267         * cli/cli-option.c (append_indented_doc): Do not append newline.
6268         (build_help_option): Append newline after first appended_indented_doc
6269         only if a second call is done.
6270         (build_help): Append 2 new lines before each option, except the first
6271         one.
6272         * compile/compile.c (_initialize_compile): Add new lines after
6273         %OPTIONS%, when not at the end of the help.
6274         Change help doc or code
6275         producing the help doc to respect the invariants.
6276         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6277         Also removed the new line after 'Options:', as all other commands
6278         do not put an empty line between 'Options:' and the first option.
6279         * printcmd.c (_initialize_printcmd): Likewise.
6280         * stack.c (_initialize_stack): Likewise.
6281         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6282         incorrectly telling COMMAND is optional.
6283         * ada-lang.c (_initialize_ada_language): Change help doc or code
6284         producing the help doc to respect the invariants.
6285         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6286         * breakpoint.c (_initialize_breakpoint): Likewise.
6287         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6288         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6289         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6290         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6291         _initialize_cli_style): Likewise.
6292         * corelow.c (core_target_info): Likewise.
6293         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6294         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6295         * filesystem.c (_initialize_filesystem): Likewise.
6296         * frame.c (_initialize_frame): Likewise.
6297         * gnu-nat.c (add_task_commands): Likewise.
6298         * infcall.c (_initialize_infcall): Likewise.
6299         * infcmd.c (_initialize_infcmd): Likewise.
6300         * interps.c (_initialize_interpreter): Likewise.
6301         * language.c (_initialize_language): Likewise.
6302         * linux-fork.c (_initialize_linux_fork): Likewise.
6303         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6304         * maint.c (_initialize_maint_cmds): Likewise.
6305         * memattr.c (_initialize_mem): Likewise.
6306         * printcmd.c (_initialize_printcmd): Likewise.
6307         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6308         _RegEx): Likewise.
6309         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6310         * record-btrace.c (_initialize_record_btrace): Likewise.
6311         * record-full.c (_initialize_record_full): Likewise.
6312         * record.c (_initialize_record): Likewise.
6313         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6314         * regcache.c (_initialize_regcache): Likewise.
6315         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6316         _initialize_remote): Likewise.
6317         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6318         * serial.c (_initialize_serial): Likewise.
6319         * skip.c (_initialize_step_skip): Likewise.
6320         * source.c (_initialize_source): Likewise.
6321         * stack.c (_initialize_stack): Likewise.
6322         * symfile.c (_initialize_symfile): Likewise.
6323         * symtab.c (_initialize_symtab): Likewise.
6324         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6325         * top.c (init_main): Likewise.
6326         * tracefile-tfile.c (tfile_target_info): Likewise.
6327         * tracepoint.c (_initialize_tracepoint): Likewise.
6328         * tui/tui-win.c (_initialize_tui_win): Likewise.
6329         * utils.c (add_internal_problem_command): Likewise.
6330         * valprint.c (value_print_option_defs): Likewise.
6331
6332 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6333
6334         PR build/24886
6335         * configure.ac: Drop enable-libmcheck support.
6336         * configure, config.in: Rebuild.
6337         * libmcheck.m4: Remove.
6338         * acinclude.m4: Don't include it.
6339         * Makefile.in: Don't distribute it.
6340         * top.c (print_gdb_configuration): Don't mention it.
6341
6342 2019-08-06  Tom Tromey  <tom@tromey.com>
6343
6344         * utils.c (set_output_style): Sometimes pass stream to
6345         emit_style_escape.
6346         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6347         * record-btrace.c (btrace_insn_history): Update.
6348         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6349         method.
6350         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6351         Update initializers.
6352         <m_uiout>: New field.
6353         <m_di>: Move lower.
6354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6355         Remove "uiout" parameter.
6356         (dump_insns): Update.
6357         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6358         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6359
6360 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6361
6362         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6363         (error_in_psymtab_expansion): Likewise.
6364         (lookup_symbol_via_quick_fns): Likewise.
6365         (basic_lookup_transparent_type_quick): Likewise.
6366         (basic_lookup_transparent_type_1): Likewise.
6367
6368 2019-08-06  Tom Tromey  <tromey@adacore.com>
6369
6370         * source.c (last_source_error): Now bool.
6371         (print_source_lines_base): Make "noprint" bool.  Only open
6372         source file when last_source_visited changes.
6373
6374 2019-08-06  Tom Tromey  <tromey@adacore.com>
6375
6376         * annotate.c (annotate_source_line): Use g_source_cache.
6377         * source-cache.c (source_cache::get_plain_source_lines): Change
6378         parameters.  Populate m_offset_cache.
6379         (source_cache::ensure): New method.
6380         (source_cache::get_line_charpos): New method.
6381         (extract_lines): Move lower.  Change parameters.
6382         (source_cache::get_source_lines): Move lower.
6383         * source-cache.h (class source_cache): Update comment.
6384         <get_line_charpos>: New method.
6385         <get_source_lines>: Update comment.
6386         <clear>: Clear m_offset_cache.
6387         <get_plain_source_lines>: Change parameters.
6388         <ensure>: New method
6389         <m_offset_cache>: New member.
6390         * source.c (forget_cached_source_info_for_objfile): Update.
6391         (info_source_command): Use g_source_cache.
6392         (find_source_lines, open_source_file_with_line_charpos): Remove.
6393         (print_source_lines_base, search_command_helper): Use g_source_cache.
6394         * source.h (open_source_file_with_line_charpos): Don't declare.
6395         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6396         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6397         Use g_source_cache.
6398
6399 2019-08-06  Tom Tromey  <tromey@adacore.com>
6400
6401         * source-cache.c (source_cache::get_plain_source_lines):
6402         Remove "first_line" and "last_line" parameters.
6403         (source_cache::get_source_lines): Cache plain text.
6404         * source-cache.h (class source_cache)
6405         <get_plain_source_lines>: Update.
6406
6407 2019-08-06  Tom Tromey  <tromey@adacore.com>
6408
6409         * source-cache.c (extract_lines): No longer a method.
6410         Changed type of parameter.  Include final newline.
6411         (selftests::extract_lines_test): New function.
6412         (_initialize_source_cache): Likewise.
6413         * source-cache.h (class source_cache)
6414         <extract_lines>: Don't declare.
6415
6416 2019-08-06  Tom Tromey  <tromey@adacore.com>
6417
6418         * breakpoint.c (init_breakpoint_sal): Update.
6419         (breakpoint): Update.
6420         * breakpoint.h (struct breakpoint) <filter>: Now a
6421         unique_xmalloc_ptr.
6422
6423 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6424
6425         * NEWS: Mention dictionary access on blocks.
6426         * python/py-block.c (blpy_getitem): New function.
6427         (block_object_as_mapping): New struct.
6428         (block_object_type): Use new struct for tp_as_mapping field.
6429
6430 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6431
6432         * objfiles.h (objfile): Add a comment describing partial symbols.
6433
6434 2019-08-05  Tom Tromey  <tromey@adacore.com>
6435
6436         * compile/compile.c (_initialize_compile): Use _(), not N_().
6437         * thread.c (_initialize_thread): Use _(), not N_().
6438         * stack.c (_initialize_stack): Use _(), not N_().
6439         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6440
6441 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6442
6443         * dwarf2read.c (struct dw2_symtab_iterator):
6444         <want_specific_block>: Remove.
6445         <block_index>: Change type to gdb::optional.
6446         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6447         change type of BLOCK_INDEX parameter to gdb::optional.
6448         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6449         (dw2_lookup_symbol): Don't pass argument for
6450         WANT_SPECIFIC_BLOCK.
6451         (dw2_expand_symtabs_for_function): Don't pass argument for
6452         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6453         (class dw2_debug_names_iterator)
6454         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6455         parameter, change BLOCK_INDEX type to gdb::optional.
6456         <m_want_specific_block>: Remove.
6457         <m_block_index>: Change type to gdb::optional.
6458         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6459         gdb::optional.  Re-write in function of gdb::optional.
6460         (dw2_debug_names_lookup_symbol): Don't pass argument for
6461         WANT_SPECIFIC_BLOCK.
6462         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6463         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6464         BLOCK_INDEX.
6465
6466 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6467
6468         * NEWS: Mention changes to "info sources" command.
6469
6470 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6471
6472         * symtab.c (filename_partial_match_opts): New struct type.
6473         (struct output_source_filename_data): New members
6474         regexp, c_regexp, partial_match.
6475         (output_source_filename): Use new members to decide to print file.
6476         (info_sources_option_defs): New variable.
6477         (make_info_sources_options_def_group, print_info_sources_header,
6478         info_sources_command_completer):
6479         New functions.
6480         (info_sources_command): Read new optional arguments.
6481         (_initialize_symtab): Update info sources help.
6482
6483 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6484
6485         * ada-lang.c (exception_support_info_v0): Renamed from...
6486         (default_exception_support_info): ... this.  Create new
6487         definition for v1.
6488         (ada_has_this_exception_support): Look up catch_handlers_sym.
6489         (ada_exception_support_info_sniffer): Try v0 after default.
6490
6491 2019-08-01  Tom Tromey  <tromey@adacore.com>
6492
6493         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6494         gdbarch.h.
6495
6496 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6497
6498         * s12z-tdep.c: Fix include path for s12z-opc.h.
6499
6500 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6501
6502         * NEWS: Require GNU make 3.82.
6503
6504 2019-07-16  Tom Tromey  <tom@tromey.com>
6505
6506         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6507         declare.
6508
6509 2019-07-30  Tom Tromey  <tromey@adacore.com>
6510
6511         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6512
6513 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6514
6515         * printcmd.c (print_address_symbolic): Print negative offsets.
6516         (build_address_symbolic): Force signed arithmetic when computing
6517         offset.
6518
6519 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6520
6521         PR/24474: Add a function to lookup static variables.
6522         * NEWS: Mention this new function.
6523         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6524         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6525         * python/python.c (python_GdbMethods): Add new function.
6526
6527 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6528
6529         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6530         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6531         (objfpy_lookup_static_symbol): New function.
6532         (objfile_object_methods): Add new functions.
6533
6534 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6535
6536         * NEWS: Mention 'set|show print frame-info'.  Mention new
6537         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6538         backtrace argument.  Mention that python frame filtering code
6539         is now consistent with what 'backtrace' command prints.
6540
6541 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6542
6543         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6544         comments.
6545         (print_frame_info_auto, print_frame_info_source_line,
6546         print_frame_info_location, print_frame_info_source_and_location,
6547         print_frame_info_location_and_address, print_frame_info_short_location):
6548         New declarations.
6549         (struct frame_print_options): New member print_frame_info.
6550         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6551         * stack.h (get_user_print_what_frame_info): New declaration.
6552         (frame_show_address): New declaration.
6553         * stack.c (print_frame_arguments_choices): New value 'presence'.
6554         (print_frame_info_auto, print_frame_info_source_line,
6555         print_frame_info_location, print_frame_info_source_and_location,
6556         print_frame_info_location_and_address, print_frame_info_short_location,
6557         print_frame_info_choices, print_frame_info_print_what): New definitions.
6558         (print_frame_args): Only print dots for args if print frame-arguments
6559         is 'presence'.
6560         (frame_print_option_defs): New element for "frame-info".
6561         (get_user_print_what_frame_info): New function.
6562         (frame_show_address): Make non static.  Move comment to stack.h.
6563         (print_frame_info_to_print_what): New function.
6564         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6565         to decide what to print.
6566         (backtrace_command_1): Handle the new print_frame_arguments_presence
6567         value.
6568         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6569         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6570         (py_print_frame): In non-mi mode, use LOCATION as default for
6571         print_what, similarly to frame information printed directly by
6572         backtrace command. Handle frame-info user option in non MI mode.
6573
6574 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6575
6576         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6577         Add case for debugging 32-bit target on 64-bit host.  Revise
6578         comment.
6579
6580 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6581
6582         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6583         instead of find_function_entry_range_from_pc.
6584
6585 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6586
6587         * stack.c (find_frame_funname): Remove code which preferred
6588         minsym over symtab sym in "certain pathological cases".
6589
6590         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6591         parameter.  Change type of "do_demangle" to bool.
6592         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6593         Pass suitable "prefer_sym_over_minsym" flag to
6594         build_address_symbolic().  Don't output "+" for negative offsets.
6595         * printcmd.c (print_address_symbolic): Update invocation of
6596         build_address_symbolic to include a "prefer_sym_over_minsym"
6597         flag.
6598         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6599         Restrict cases in which use of minimal symbol is preferred to that
6600         of a found symbol.  Update comments.
6601
6602         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6603         for entry pc when entry pc is out of range for that FDE.
6604
6605 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6606
6607         PR gdb/24839:
6608         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6609         type.
6610
6611 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6612
6613         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6614         this function's Python signature.
6615
6616
6617 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6618
6619         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6620         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6621         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6622         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6623         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6624
6625
6626 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6627
6628         * h8300-tdep.c (h8300_register_name_common): New.
6629         h8300_register_name): Use h8300_register_name_common.
6630         (h8300s_register_name): Likewise.
6631         (h8300sx_register_name): Likewise.
6632         (h8300h_register_nam): New.
6633         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6634
6635
6636 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6637
6638         * arm-tdep.c (arm_skip_cmse_entry): New function.
6639         (arm_is_sgstubs_section): New function.
6640         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6641
6642 2019-07-22  Tom Tromey  <tom@tromey.com>
6643
6644         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6645         Don't self-assign.
6646
6647 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6650         type_print.
6651
6652 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6653
6654         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6655         so that GDB doesn't match any msymbols when searching in the
6656         TYPES_DOMAIN.
6657         (print_symbol_info): Print using typedef_print or type_print based
6658         on the type of the symbol.  Add updated FIXME comment moved from...
6659         (_initialize_symtab): ... move and update FIXME comment to above.
6660
6661 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6662
6663         * NEWS: Mention adding -q option to "info types".
6664         * symtab.c (struct info_types_options): New struct.
6665         (info_types_options_defs): New variable.
6666         (make_info_types_options_def_group): New function.
6667         (info_types_command): Use gdb::option framework to parse options.
6668         (info_types_command_completer): New function.
6669         (_initialize_symtab): Extend the help text on "info types" and
6670         register command completer.
6671
6672 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6673
6674         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6675         (lookup_symbol_in_objfile): Change int to block_enum and add a
6676         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6677
6678 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6679
6680         * MAINTAINERS (Write After Approval): Add self.
6681
6682 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6685         instruction to the dummy code region.
6686
6687 2019-07-19  Tom Tromey  <tromey@adacore.com>
6688
6689         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6690         (ARGSUSED, PARAMS, __func__): Remove rules.
6691
6692 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6693
6694         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6695         * features/arm/arm-with-iwmmxt.c: Remove.
6696         * features/arm/arm-with-iwmmxt.xml: Remove.
6697         * features/arm/arm-with-m-fpa-layout.c: Remove.
6698         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6699         * features/arm/arm-with-m-vfp-d16.c: Remove.
6700         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6701         * features/arm/arm-with-m.c: Remove.
6702         * features/arm/arm-with-m.xml: Remove.
6703         * features/arm/arm-with-neon.c: Remove.
6704         * features/arm/arm-with-neon.xml: Remove.
6705         * features/arm/arm-with-vfpv2.c: Remove.
6706         * features/arm/arm-with-vfpv2.xml: Remove.
6707         * features/arm/arm-with-vfpv3.c: Remove.
6708         * features/arm/arm-with-vfpv3.xml: Remove.
6709
6710 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6711
6712         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6713
6714 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6715
6716         * arch/aarch32.c (aarch32_create_target_description): Create
6717         target descriptions using features.
6718         * arch/arm.c (arm_create_target_description)
6719         (arm_create_mprofile_target_description): Likewise.
6720         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6721
6722 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6723
6724         * Makefile.in: Add new files.
6725         * aarch32-tdep.c: New file.
6726         * aarch32-tdep.h: New file.
6727         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6728         Call aarch32_read_description.
6729         * arch/aarch32.c: New file.
6730         * arch/aarch32.h: New file.
6731         * arch/arm.c (arm_create_target_description)
6732         (arm_create_mprofile_target_description): New function.
6733         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6734         (arm_create_target_description)
6735         (arm_create_mprofile_target_description): New declaration.
6736         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6737         read_description functions.
6738         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6739         Likewise.
6740         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6741         * arm-tdep.c (tdesc_arm_list): New variable.
6742         (arm_register_g_packet_guesses): Call create description functions.
6743         (arm_read_description) (arm_read_mprofile_description): New
6744         function.
6745         * arm-tdep.h (arm_read_description)
6746         (arm_read_mprofile_description): Add declaration.
6747         * configure.tgt: Add new files.
6748
6749 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6750
6751         * top.c (new_ui_command): Open specified terminal just once.
6752
6753 2019-07-18  Tom Tromey  <tromey@adacore.com>
6754
6755         * symtab.c (main_name): Constify return type.
6756         * symfile.c (set_initial_language): Update.
6757         * symtab.h (main_name): Constify return type.
6758
6759 2019-07-17  Tom Tromey  <tom@tromey.com>
6760
6761         * tui/tui-winsource.c (tui_update_source_window)
6762         (tui_update_source_window_as_is)
6763         (tui_update_source_windows_with_line): Remove return.
6764         * tui/tui-disasm.c (tui_show_disassem)
6765         (tui_show_disassem_and_update_source): Remove return.
6766         * tui/tui.c (tui_reset): Remove return.
6767         * tui/tui-wingeneral.c
6768         (tui_check_and_display_highlight_if_needed): Remove return.
6769
6770 2019-07-17  Tom Tromey  <tom@tromey.com>
6771
6772         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6773
6774 2019-07-17  Tom Tromey  <tom@tromey.com>
6775
6776         * tui/tui-winsource.h (struct tui_exec_info_window)
6777         (struct tui_source_window_base): Move from tui-data.h.
6778         * tui/tui-winsource.c: Move many method definitions from
6779         elsewhere.  Remove "structuring" comments.
6780         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6781         (tui_source_window_base::refresh_window): Move to
6782         tui-winsource.c.
6783         * tui/tui-win.c (tui_source_window_base::refresh_all)
6784         (tui_source_window_base::update_tab_width)
6785         (tui_source_window_base::set_new_height)
6786         (tui_source_window_base::do_make_visible_with_new_height): Move to
6787         tui-winsource.c.
6788         * tui/tui-source.h: Update.
6789         * tui/tui-source.c (tui_source_window_base::reset): Move to
6790         tui-winsource.c.
6791         * tui/tui-disasm.h: Update.
6792         * tui/tui-data.h (struct tui_exec_info_window): Move to
6793         tui-winsource.h.
6794         (struct tui_source_window_base): Likewise.
6795         * tui/tui-data.c (tui_source_window_base::clear_detail)
6796         (tui_source_window_base, ~tui_source_window_base): Move to
6797         tui-winsource.c.
6798
6799 2019-07-17  Tom Tromey  <tom@tromey.com>
6800
6801         * tui/tui-win.c (tui_resize_all)
6802         (tui_source_window_base::update_tab_width)
6803         (tui_adjust_win_heights): Update.
6804         (tui_win_info::make_invisible_and_set_new_height): Rename from
6805         make_invisible_and_set_new_height.
6806         * tui/tui-data.h (struct tui_win_info)
6807         <make_invisible_and_set_new_height>: New method.
6808
6809 2019-07-17  Tom Tromey  <tom@tromey.com>
6810
6811         * tui/tui.c: Update.
6812         * tui/tui-source.h (struct tui_source_window): Move from
6813         tui-data.h.
6814         * tui/tui-layout.c: Update.
6815         * tui/tui-disasm.c: Update.
6816         * tui/tui-data.h (struct tui_source_window): Move to
6817         tui-source.h.
6818
6819 2019-07-17  Tom Tromey  <tom@tromey.com>
6820
6821         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6822         tui-data.h.
6823         * tui/tui-data.h (struct tui_disasm_window): Move to
6824         tui-disasm.h.
6825
6826 2019-07-17  Tom Tromey  <tom@tromey.com>
6827
6828         * tui/tui-regs.h (struct tui_data_item_window): Move from
6829         tui-data.h.
6830         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6831         * tui/tui-data.h (struct tui_data_item_window): Move to
6832         tui-regs.h.
6833         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6834
6835 2019-07-17  Tom Tromey  <tom@tromey.com>
6836
6837         * tui/tui.c: Update.
6838         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6839         (tui_cmd_window::max_height): Move to tui-command.c.
6840         * tui/tui-layout.c: Update.
6841         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6842         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6843         tui-command.c.
6844         * tui/tui-command.h (struct tui_cmd_window): Move from
6845         tui-data.h.
6846         * tui/tui-command.c: Remove "structuring" comments.
6847         (tui_cmd_window::clear_detail)
6848         (tui_cmd_window::do_make_visible_with_new_height)
6849         (tui_cmd_window::max_height): Move from elsewhere.
6850
6851 2019-07-17  Tom Tromey  <tom@tromey.com>
6852
6853         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6854         Now static.
6855         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6856         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6857
6858 2019-07-17  Tom Tromey  <tom@tromey.com>
6859
6860         * tui/tui.c: Update.
6861         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6862         tui-regs.c.
6863         * tui/tui-windata.h: Remove file.
6864         * tui/tui-windata.c: Remove file.
6865         * tui/tui-win.c (tui_data_window::set_new_height)
6866         (tui_data_window::do_make_visible_with_new_height): Move to
6867         tui-regs.c.
6868         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6869         * tui/tui-regs.c: Remove "structuring" comments.
6870         (tui_data_window::first_data_item_displayed)
6871         (tui_data_window::delete_data_content_windows)
6872         (tui_data_window::erase_data_content)
6873         (tui_data_window::display_all_data)
6874         (tui_data_window::refresh_all)
6875         (tui_data_window::do_scroll_vertical)
6876         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6877         (tui_data_window::do_make_visible_with_new_height)
6878         (tui_data_window::refresh_window): Move from elsewhere.
6879         (_initialize_tui_regs): Move to end of file.
6880         * tui/tui-layout.c: Update.
6881         * tui/tui-hooks.c: Update.
6882         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6883         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6884         tui-regs.c.
6885         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6886
6887 2019-07-17  Tom Tromey  <tom@tromey.com>
6888
6889         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6890         seen.
6891
6892 2019-07-17  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-win.c (tui_source_window_base::set_new_height)
6895         (tui_source_window_base::do_make_visible_with_new_height): Use
6896         m_has_locator field directly.
6897         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6898         method.
6899         (struct tui_source_window_base) <has_locator>: Likewise.
6900
6901 2019-07-17  Tom Tromey  <tom@tromey.com>
6902
6903         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6904         Don't declare.
6905         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6906         Remove.
6907         * tui/tui-win.c (tui_source_window_base::set_new_height)
6908         (tui_source_window_base::set_new_height)
6909         (make_invisible_and_set_new_height)
6910         (tui_source_window_base::do_make_visible_with_new_height)
6911         (tui_source_window_base::do_make_visible_with_new_height):
6912         Update.
6913         * tui/tui-layout.c (show_source_disasm_command, show_data)
6914         (show_source_or_disasm_and_command): Update.
6915         * tui/tui-layout.c (show_layout): Update.
6916
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-layout.c (make_data_window): Remove.
6920         (show_data): Unify creation and re-initialization cases.
6921
6922 2019-07-17  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-layout.c (make_source_window, make_disasm_window):
6925         Remove.
6926         (show_data): Unify creation and re-initialization cases.
6927
6928 2019-07-17  Tom Tromey  <tom@tromey.com>
6929
6930         * tui/tui-layout.c (make_command_window): Remove.
6931         (show_source_disasm_command, show_source_or_disasm_and_command):
6932         Unify creation and re-initialization cases.
6933
6934 2019-07-17  Tom Tromey  <tom@tromey.com>
6935
6936         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6937         creation and re-initialization cases.
6938
6939 2019-07-17  Tom Tromey  <tom@tromey.com>
6940
6941         * tui/tui-regs.c (tui_get_register): Return void.
6942
6943 2019-07-17  Tom Tromey  <tom@tromey.com>
6944
6945         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6946         Simplify.
6947
6948 2019-07-17  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6951         resetting.
6952
6953 2019-07-17  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6956         * tui/tui-regs.c (tui_reg_layout): New function.
6957         (tui_show_registers, tui_reg_command): Use it.
6958         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6959         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6960         parameters.
6961         (tui_layout_command): Remove.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-layout.h (tui/tui-layout): Return void.
6966         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6967
6968 2019-07-17  Tom Tromey  <tom@tromey.com>
6969
6970         * tui/tui-layout.c (show_source_disasm_command, show_data):
6971         Update.
6972         (reset_locator): Remove.
6973         (show_source_or_disasm_and_command): Update.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-source.c (tui_source_window_base::reset): Remove
6978         win_type parameter.
6979         * tui/tui-layout.c (make_command_window, make_source_window)
6980         (make_disasm_window, make_data_window)
6981         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6982         (reset_locator, show_source_or_disasm_and_command): Update.
6983         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6984         win_type parameter.
6985         (struct tui_source_window_base) <reset>: Likewise.
6986
6987 2019-07-17  Tom Tromey  <tom@tromey.com>
6988
6989         * tui/tui-layout.c (show_source_disasm_command): Use
6990         reset_locator.
6991         (reset_locator): New function.
6992         (init_and_make_win): Remove.
6993         (show_source_or_disasm_and_command): Use reset_locator.
6994
6995 2019-07-17  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6998         condition.
6999         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7000         Remove condition.
7001         * tui/tui-source.c (tui_source_window_base::reset): New method.
7002         * tui/tui-layout.c (make_command_window): Don't call
7003         init_and_make_win.
7004         (make_source_window, make_disasm_window): Don't call
7005         make_source_or_disasm_window.
7006         (make_data_window): Don't call init_and_make_win.  Change calling
7007         convention.
7008         (show_source_disasm_command, show_data): Simplify.
7009         (make_source_or_disasm_window): Remove.
7010         (show_source_or_disasm_and_command): Simplify.
7011         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7012         (struct tui_source_window_base) <reset>: Likewise.
7013         <execution_info>: Remove initializer.
7014         * tui/tui-data.c (tui_source_window_base): Initialize
7015         execution_info.
7016
7017 2019-07-17  Tom Tromey  <tom@tromey.com>
7018
7019         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7020         variable.
7021
7022 2019-07-17  Tom Tromey  <tom@tromey.com>
7023
7024         * tui/tui.c (tui_rl_other_window): Update.
7025         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7026         superclass method first.  Always iterate over regs_content.
7027         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7028         method.
7029         * tui/tui-win.c (tui_set_focus_command): Update.
7030
7031 2019-07-17  Tom Tromey  <tom@tromey.com>
7032
7033         * tui/tui-win.c (tui_set_focus_command): Rename from
7034         tui_set_focus.  Call tui_enable.
7035         (tui_set_focus_command): Remove.
7036
7037 2019-07-17  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7040         refresh_window.
7041         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7042         touchwin.
7043         (tui_data_window::refresh_window): Call refresh_window on data
7044         items.  Always call superclass refresh_window.
7045         (tui_win_info::refresh): Remove.
7046         (tui_source_window_base::refresh_window): Update.
7047         (tui_refresh_all): Update.
7048         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7049         refresh_window.
7050         (show_source_or_disasm_and_command): Likewise.
7051         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7052         (struct tui_source_window_base) <refresh>: Likewise.
7053
7054 2019-07-17  Tom Tromey  <tom@tromey.com>
7055
7056         * tui/tui-winsource.c (tui_clear_source_content)
7057         (tui_show_source_content): Update.
7058         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7059         whether content is empty.
7060         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7061         Remove.
7062
7063 2019-07-17  Tom Tromey  <tom@tromey.com>
7064
7065         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7066         window's contents.
7067         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7068         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7069
7070 2019-07-17  Tom Tromey  <tom@tromey.com>
7071
7072         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7073         (struct tui_data_item_window): Update.
7074
7075 2019-07-17  Tom Tromey  <tom@tromey.com>
7076
7077         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7078         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7079         defines.
7080
7081 2019-07-17  Tom Tromey  <tom@tromey.com>
7082
7083         * tui/tui-winsource.h (tui_erase_source_content)
7084         (tui_clear_source_content): Remove "display_prompt" parameter.
7085         * tui/tui-winsource.c (tui_update_source_window_as_is)
7086         (tui_update_source_windows_with_addr): Update.
7087         (tui_clear_source_content): Remove "display_prompt" parameter.
7088         (tui_erase_source_content): Likewise.  Simplify.
7089         (tui_show_source_content): Update.
7090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7091         * tui/tui-stack.c (tui_show_frame_info): Update.
7092         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7093         Remove defines.
7094
7095 2019-07-17  Tom Tromey  <tom@tromey.com>
7096
7097         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7098         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7099         parameter.
7100         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7101         parameter.
7102
7103 2019-07-17  Tom Tromey  <tom@tromey.com>
7104
7105         * tui/tui-winsource.c (tui_clear_source_content)
7106         (tui_show_source_content, tui_show_exec_info_content)
7107         (tui_clear_exec_info_content): Update.
7108         * tui/tui-stack.c (tui_show_locator_content): Update.
7109         (tui_show_frame_info): Update.
7110         * tui/tui-source.h (tui_source_window): Don't declare.
7111         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7112         from tui_source_is_displayed.
7113         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7114         Remove field.
7115         (struct tui_source_window_base) <content_in_use>: New field.  Now
7116         bool.
7117         (struct tui_source_window) <showing_source_p>: New method.
7118         (TUI_SRC_WIN): Change cast.
7119         * tui/tui-data.c (tui_initialize_static_data): Update.
7120
7121 2019-07-17  Tom Tromey  <tom@tromey.com>
7122
7123         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7124         location_matches_p.
7125         * tui/tui-source.c (tui_source_window::location_matches_p): New
7126         method.
7127         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7128         method.
7129         * tui/tui-data.h (struct tui_source_window_base)
7130         <location_matches_p>: New method.
7131         (struct tui_source_window, struct tui_disasm_window)
7132         <location_matches_p>: Likewise.
7133
7134 2019-07-17  Tom Tromey  <tom@tromey.com>
7135
7136         * tui/tui-win.c (tui_set_win_height_command): Rename from
7137         tui_set_win_height.
7138         (tui_set_win_height_command): Remove.
7139
7140 2019-07-17  Tom Tromey  <tom@tromey.com>
7141
7142         * tui/tui-source.c (tui_source_window): New constructor.  Add
7143         observer.
7144         (~tui_source_window): New destructor.
7145         (tui_source_window::style_changed): New method.
7146         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7147         (tui_attach_detach_observers): Update.
7148         * tui/tui-data.h (struct tui_source_window): Make constructor not
7149         inline.  Add destructor.
7150         (struct tui_source_window) <style_changed>: New method.
7151         <m_observable>: New member.
7152
7153 2019-07-17  Tom Tromey  <tom@tromey.com>
7154
7155         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7156         * tui/tui-win.c (tui_resize_all): Fix typo.
7157
7158 2019-07-17  Tom Tromey  <tom@tromey.com>
7159
7160         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7161         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7162         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7163         * tui/tui-win.c (window_name_completer): Use foreach.
7164         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7165         (update_tab_width): Likewise.
7166         * tui/tui-layout.c (show_layout): Update.
7167         * tui/tui-data.h (class tui_window_iterator): New.
7168         (struct all_tui_windows): New.
7169         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7170
7171 2019-07-17  Tom Tromey  <tom@tromey.com>
7172
7173         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7174         parameter.  Don't reference globals.
7175         (tui_reg_command): Update.
7176
7177 2019-07-17  Tom Tromey  <tom@tromey.com>
7178
7179         * tui/tui-regs.c (tui_show_registers): Simplify.
7180
7181 2019-07-17  Tom Tromey  <tom@tromey.com>
7182
7183         * tui/tui-regs.c (tui_show_registers): Update.
7184         (tui_show_register_group): Add win_info parameter.
7185
7186 2019-07-17  Tom Tromey  <tom@tromey.com>
7187
7188         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7189         Rename from tui_display_reg_element_at_line.
7190         (tui_data_window::display_registers_from_line): Update.
7191         * tui/tui-data.h (struct tui_data_window)
7192         <display_reg_element_at_line>: New method.
7193
7194 2019-07-17  Tom Tromey  <tom@tromey.com>
7195
7196         * tui/tui-regs.h (tui_display_registers_from)
7197         (tui_display_registers_from_line): Don't declare.
7198         * tui/tui-windata.c (tui_data_window::display_all_data)
7199         (tui_data_window::refresh_all)
7200         (tui_data_window::do_scroll_vertical): Update.
7201         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7202         from tui_display_registers_from.
7203         (tui_display_reg_element_at_line): Update.
7204         (tui_data_window::display_registers_from_line): Rename from
7205         tui_display_registers_from_line.
7206         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7207         display_registers_from_line>: New methods.
7208
7209 2019-07-17  Tom Tromey  <tom@tromey.com>
7210
7211         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7212         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7213         from tui_erase_data_content.
7214         (tui_data_window::display_all_data)
7215         (tui_data_window::refresh_all)
7216         (tui_data_window::do_scroll_vertical): Update.
7217         * tui/tui-regs.c (tui_show_registers): Update.
7218         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7219         New method.
7220
7221 2019-07-17  Tom Tromey  <tom@tromey.com>
7222
7223         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7224         declare.
7225         * tui/tui-windata.c
7226         (tui_data_window::delete_data_content_windows): Rename from
7227         tui_delete_data_content_windows.
7228         (tui_data_window::display_all_data)
7229         (tui_data_window::do_scroll_vertical): Update.
7230         * tui/tui-data.h (struct tui_data_window)
7231         <delete_data_content_windows>: New method.
7232
7233 2019-07-17  Tom Tromey  <tom@tromey.com>
7234
7235         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7236         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7237
7238 2019-07-17  Tom Tromey  <tom@tromey.com>
7239
7240         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7241         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7242         from tui_display_all_data.
7243         * tui/tui-win.c
7244         (tui_data_window::do_make_visible_with_new_height): Update.
7245         * tui/tui-regs.c (tui_show_registers): Update.
7246         * tui/tui-layout.c (tui_set_layout): Update.
7247         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7248         method.
7249
7250 2019-07-17  Tom Tromey  <tom@tromey.com>
7251
7252         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7253         * tui/tui-windata.c (tui_display_data_from): Remove.
7254         (tui_data_window::refresh_all): Update.
7255
7256 2019-07-17  Tom Tromey  <tom@tromey.com>
7257
7258         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7259         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7260         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7261         tui_display_registers_from_line.
7262         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7263         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7264         "force_display" parameter.
7265
7266 2019-07-17  Tom Tromey  <tom@tromey.com>
7267
7268         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7269         declare.
7270         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7271         Rename from tui_first_reg_element_no_inline.
7272         (tui_display_reg_element_at_line)
7273         (tui_display_registers_from_line): Update.
7274         * tui/tui-data.h (struct tui_data_window)
7275         <first_reg_element_no_inline>: New method.
7276
7277 2019-07-17  Tom Tromey  <tom@tromey.com>
7278
7279         * tui/tui-windata.c (tui_display_data_from)
7280         (tui_data_window::do_scroll_vertical): Update.
7281         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7282         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7283         Rename from tui_line_from_reg_element_no.
7284         (tui_display_registers_from_line): Update.
7285         * tui/tui-data.h (struct tui_data_window)
7286         <line_from_reg_element_no>: New method.
7287
7288 2019-07-17  Tom Tromey  <tom@tromey.com>
7289
7290         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7291         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7292         tui_last_regs_line_no.
7293         (tui_display_reg_element_at_line)
7294         (tui_display_registers_from_line): Update.
7295         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7296         method.
7297
7298 2019-07-17  Tom Tromey  <tom@tromey.com>
7299
7300         PR tui/24722:
7301         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7302         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7303         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7304         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7305         (tui_update_breakpoint_info): Likewise.
7306         * tui/tui-hooks.c (tui_event_create_breakpoint)
7307         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7308         Update.
7309
7310 2019-07-17  Tom Tromey  <tom@tromey.com>
7311
7312         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7313
7314 2019-07-17  Tom Tromey  <tom@tromey.com>
7315
7316         * tui/tui-winsource.c (tui_update_source_window_as_is)
7317         (tui_update_source_windows_with_addr): Update.
7318         * tui/tui-source.h (tui_set_source_content)
7319         (tui_show_symtab_source): Add "win_info" parameter.
7320         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7321         parameter.
7322         (tui_show_symtab_source): Likewise.
7323
7324 2019-07-17  Tom Tromey  <tom@tromey.com>
7325
7326         * tui/tui-wingeneral.c
7327         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7328
7329 2019-07-17  Tom Tromey  <tom@tromey.com>
7330
7331         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7332         (struct tui_cmd_window) <can_scroll>: New method.
7333         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7334         method.
7335
7336 2019-07-17  Tom Tromey  <tromey@adacore.com>
7337
7338         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7339         do_field_signed>: Rename.  Change type of "value".
7340         * ui-out.c (ui_out::field_signed): Rename from field_int.
7341         Change type of "value".
7342         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7343         type of "value".
7344         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7345         do_field_int.  Change type of "value".
7346         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7347         do_field_int.  Change type of "value".
7348         * tracepoint.c (trace_status_mi, tfind_1)
7349         (print_one_static_tracepoint_marker): Update.
7350         * thread.c (print_thread_info_1, print_selected_thread_frame):
7351         Update.
7352         * stack.c (print_frame, print_frame_info): Update.
7353         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7354         Update.
7355         * source.c (print_source_lines_base): Update.
7356         * skip.c (info_skip_command): Update.
7357         * record-btrace.c (btrace_ui_out_decode_error)
7358         (btrace_call_history_src_line): Update.
7359         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7360         Update.
7361         * progspace.c (print_program_space): Update.
7362         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7363         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7364         do_field_int.  Change type of "value".
7365         * mi/mi-out.c (mi_ui_out::do_table_begin)
7366         (mi_ui_out::do_table_header): Update.
7367         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7368         type of "value".
7369         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7370         (mi_cmd_data_list_changed_registers, output_register)
7371         (mi_cmd_data_read_memory, mi_load_progress)
7372         (mi_cmd_trace_frame_collected): Update.
7373         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7374         Update.
7375         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7376         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7377         (mi_cmd_var_list_children, varobj_update_one): Update.
7378         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7379         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7380         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7381         * inferior.c (print_inferior): Update.
7382         * gdb_bfd.c (print_one_bfd): Update.
7383         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7384         Update.
7385         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7386         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7387         do_field_int.  Change type of "value".
7388         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7389         do_field_int.  Change type of "value".
7390         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7391         (print_one_breakpoint_location, print_it_catch_fork)
7392         (print_one_catch_fork, print_it_catch_vfork)
7393         (print_one_catch_vfork, print_it_catch_solib)
7394         (print_it_catch_exec, print_it_ranged_breakpoint)
7395         (print_mention_watchpoint, print_mention_masked_watchpoint)
7396         (bkpt_print_it, update_static_tracepoint): Update.
7397         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7398         * break-catch-syscall.c (print_it_catch_syscall): Update.
7399         * ada-tasks.c (print_ada_task_info): Update.
7400         * ada-lang.c (print_it_exception, print_mention_exception):
7401         Update.
7402
7403 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         PR breakpoints/24541
7406         * gdbarch.c: Regenerate.
7407         * gdbarch.h: Regenerate.
7408         * gdbarch.sh: Adjust return type and parameter types for
7409         'stap_adjust_register'.
7410         (i386_stap_adjust_register): Adjust signature and return new
7411         register name.
7412         * stap-probe.c (stap_parse_register_operand): Adjust use of
7413         'gdbarch_stap_adjust_register'.
7414
7415 2019-07-17  Tom Tromey  <tromey@adacore.com>
7416
7417         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7418         declare VEC.
7419         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7420         std::vector.
7421         (struct s390_process_info): Add initializers.
7422         (s390_add_process): Use new.
7423         (s390_linux_nat_target::low_forget_process): Use delete.
7424         (s390_linux_nat_target::low_new_fork)
7425         (s390_linux_nat_target::stopped_by_watchpoint)
7426         (s390_linux_nat_target::low_prepare_to_resume)
7427         (s390_linux_nat_target::insert_watchpoint)
7428         (s390_linux_nat_target::insert_hw_breakpoint)
7429         (s390_linux_nat_target::remove_watchpoint)
7430         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7431
7432 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7433
7434         * aarch64-fbsd-nat.c: Include regcache.h.
7435         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7436         argument.
7437         (aarch64_fbsd_nat_target::fetch_registers)
7438         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7439         variable.
7440         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7441
7442 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7443
7444         * fbsd-nat.c: Include gdbarch.h.
7445
7446 2019-07-15  Tom Tromey  <tromey@adacore.com>
7447
7448         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7449
7450 2019-07-15  Tom Tromey  <tromey@adacore.com>
7451
7452         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7453         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7454         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7455         * cli-out.c (cli_ui_out::do_field_int): New method.
7456         * ui-out.c (ui_out::field_unsigned): New method.
7457         * symfile.c (generic_load): Use field_unsigned.
7458         (print_transfer_performance): Likewise.
7459         * record-btrace.c (ui_out_field_uint): Remove.
7460         (btrace_call_history_insn_range, btrace_call_history): Use
7461         field_unsigned.
7462         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7463         field_unsigned.
7464         * ui-out.h (class ui_out) <field_unsigned>: New method.
7465         <do_field_unsigned>: Likewise.
7466
7467 2019-07-15  Tom Tromey  <tromey@adacore.com>
7468
7469         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7470         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7471         * target.c (flash_erase_command): Use field_string.
7472         * infrun.c (print_signal_received_reason): Use field_string.
7473         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7474         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7475         field_string.
7476         * ada-tasks.c (print_ada_task_info): Use field_string.
7477
7478 2019-07-15  Tom Tromey  <tromey@adacore.com>
7479
7480         * target.c (flash_erase_command): Use field_core_addr.
7481         * symfile.c (generic_load): Use field_core_addr.
7482         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7483         Use field_core_addr.
7484         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7485         field_core_addr.
7486
7487 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7488
7489         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7490         value if its desired type is smaller than a CORE_ADDR and signed.
7491
7492 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7495         of changes to field names, and use new is_reference field to
7496         decide if a property is a reference or not.
7497         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7498         field.
7499         (struct dwarf2_property_baton): Update header comment, rename
7500         'referenced_type' to 'property_type' and update comments.
7501         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7502         default property type, store in property baton, update to take
7503         accound of renamed field.
7504         (read_func_scope): Update call to attr_to_dynamic_prop.
7505         (read_array_type): Likewise.
7506         (dwarf2_per_cu_addr_sized_int_type): New function.
7507         (read_subrange_index_type): Move type finding code to
7508         dwarf2_per_cu_addr_sized_int_type.
7509         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7510         (dwarf2_per_cu_addr_type): New function.
7511         (set_die_type): Update calls to attr_to_dynamic_prop.
7512
7513 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7514
7515         * dwarf2read.c (read_subrange_index_type): New function.
7516         (read_subrange_type): Move code into new function and call it.
7517         * gdbtypes.c (create_range_type): Add some asserts.
7518
7519 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7522         update return statements.
7523         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7524         declaration, and update comment to match.
7525         * gdbtypes.c (resolve_dynamic_array): Update call to
7526         dwarf2_evaluate_property to match new return type.
7527
7528 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * valarith.c (value_subscripted_rvalue): Change lowerbound
7531         parameter type from int to LONGEST.
7532         * value.h (value_subscripted_rvalue): Likewise in declaration.
7533
7534 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * cli/cli-utils.c (info_print_command_completer): New function.
7537         * cli/cli-utils.h: Add 'completer.h' include, and forward
7538         declaration for 'struct cmd_list_element'.
7539         (info_print_command_completer): Declare.
7540         * stack.c (_initialize_stack): Add completer for 'info locals' and
7541         'info args'.
7542         * symtab.c (_initialize_symtab): Add completer for 'info
7543         variables' and 'info functions'.
7544         * NEWS: Mention completion for additional info commands.
7545
7546 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * cli/cli-utils.c (extract_info_print_args): Delete.
7549         (extract_arg_maybe_quoted): Delete.
7550         (info_print_options_defs): New variable.
7551         (make_info_print_options_def_group): New function.
7552         (extract_info_print_options): Define new function.
7553         * cli/cli-utils.h (extract_info_print_args): Delete.
7554         (struct info_print_options): New structure.
7555         (extract_info_print_options): Declare new function.
7556         * stack.c (info_locals_command): Update to use new
7557         extract_info_print_options, also add a header comment.
7558         (info_args_command): Likewise.
7559         * symtab.c (info_variables_command): Likewise.
7560         (info_functions_command): Likewise.
7561
7562 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7565         to extract string arguments.
7566         * common/common-utils.c (extract_string_maybe_quoted): New function.
7567         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7568
7569 2019-07-11  Tom Tromey  <tromey@adacore.com>
7570
7571         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7572         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7573         * top.h (gdbinit): Don't declare.
7574         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7575         into...
7576         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7577         * top.c (gdb_init): Don't call init_cli_cmds.
7578         (gdbinit): Remove.
7579         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7580
7581 2019-07-11  Tom Tromey  <tromey@adacore.com>
7582
7583         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7584         after it has been moved.
7585
7586 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7587
7588         * valops.c (value_must_coerce_to_target): Change return type to
7589         bool.
7590         * value.h (value_must_coerce_to_target): Likewise.
7591
7592 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7593
7594         * breakpoint.c (is_hardware_watchpoint): Remove
7595         forward-declaration.
7596         (is_masked_watchpoint): Change return type to bool.
7597         (is_tracepoint): Likewise.
7598         (is_breakpoint): Likewise.
7599         (is_hardware_watchpoint): Likewise.
7600         (is_watchpoint): Likewise.
7601         (is_no_memory_software_watchpoint): Likewise.
7602         (is_catchpoint): Likewise.
7603         (breakpoint_1): Make FILTER parameter's return type bool.
7604         is_masked_watchpoint): Change return type to bool.
7605         (save_breakpoints): Make FILTER parameter's return type bool.
7606         * breakpoint.h (is_breakpoint): Change return type to bool.
7607         (is_watchpoint): Likewise.
7608         (is_catchpoint): Likewise.
7609         (is_tracepoint): Likewise.
7610
7611 2019-07-10  Tom Tromey  <tom@tromey.com>
7612
7613         * defs.h: Don't include gdbarch.h.
7614         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7615         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7616         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7617         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7618         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7619         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7620         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7621         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7622         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7623         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7624         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7625         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7626         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7627         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7628         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7629         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7630         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7631         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7632         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7633         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7634         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7635         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7636         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7637         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7638         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7639         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7640         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7641
7642 2019-07-10  Tom Tromey  <tromey@adacore.com>
7643
7644         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7645         * breakpoint.c (init_ada_exception_breakpoint): Register as
7646         bp_catchpoint.
7647         (print_one_breakpoint_location, print_one_breakpoint): Use
7648         is_ada_exception_catchpoint.
7649         * ada-lang.c (class ada_catchpoint_location): Pass
7650         bp_loc_software_breakpoint to bp_location constructor.
7651         (is_ada_exception_catchpoint): New function.
7652
7653 2019-07-10  Tom Tromey  <tromey@adacore.com>
7654
7655         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7656         VEC.
7657         (struct arm_exidx_entry): New method operator<.
7658         (struct arm_exidx_data) <section_maps>: Change type.
7659         (arm_exidx_data_free): Remove.
7660         (arm_exidx_data_key): Change type.  Move lower.
7661         (arm_exidx_new_objfile): Update.
7662         (arm_compare_exidx_entries): Remove.
7663         (arm_find_exidx_entry, _initialize_arm_tdep)
7664
7665 2019-07-10  Tom Tromey  <tromey@adacore.com>
7666
7667         * solib-spu.c (ocl_program_data_key): Change type.
7668         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7669         Update.
7670
7671 2019-07-10  Tom Tromey  <tromey@adacore.com>
7672
7673         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7674         (struct solib_aix_inferior_data) <library_list>: Change type.
7675         (solib_aix_inferior_data_handle): Change type.
7676         (get_solib_aix_inferior_data): Update.
7677         (solib_aix_free_library_list): Remove.
7678         (library_list_start_library): Update.
7679         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7680         return type.
7681         (solib_aix_get_library_list)
7682         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7683         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7684
7685 2019-07-10  Tom Tromey  <tromey@adacore.com>
7686
7687         * solib-dsbt.c (struct dsbt_info): Add initializers.
7688         (solib_dsbt_pspace_data): Change type.
7689         (dsbt_pspace_data_cleanup): Remove.
7690         (get_dsbt_info, _initialize_dsbt_solib): Update.
7691
7692 2019-07-10  Tom Tromey  <tromey@adacore.com>
7693
7694         * spu-tdep.c (spu_overlay_data): Change type.
7695         (spu_get_overlay_table, spu_overlay_new_objfile)
7696         (_initialize_spu_tdep): Update.
7697
7698 2019-07-10  Tom Tromey  <tromey@adacore.com>
7699
7700         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7701         destructor.
7702         (dbx_objfile_data_key): Change type and declare later.
7703         (DBX_SYMFILE_INFO): Rewrite.
7704         * dbxread.c (dbx_objfile_data_key): Change type.
7705         (dbx_symfile_init): Update.
7706         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7707         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7708         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7709
7710 2019-07-10  Tom Tromey  <tromey@adacore.com>
7711
7712         * jit.c (jit_program_space_key): Change type.  Move lower.
7713         (get_jit_program_space_data): Update.
7714         (jit_program_space_data_cleanup): Remove.
7715         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7716         Update.
7717         (struct jit_program_space_data): Add initializers.
7718
7719 2019-07-10  Tom Tromey  <tromey@adacore.com>
7720
7721         * solib-darwin.c (struct darwin_info): Add initializers.
7722         (solib_darwin_pspace_data): Change type.
7723         (darwin_pspace_data_cleanup): Remove.
7724         (get_darwin_info, _initialize_darwin_solib): Update.
7725
7726 2019-07-10  Tom Tromey  <tromey@adacore.com>
7727
7728         * remote-sim.c (struct sim_inferior_data): Add initializers,
7729         constructor, and destructor.
7730         (sim_inferior_data_key): Change type.  Move lower.
7731         (check_for_duplicate_sim_descriptor): Update.
7732         (get_sim_inferior_data): Use new.  Update.
7733         (~sim_inferior_data_cleanup): Rename from
7734         sim_inferior_data_cleanup.  Simplify.
7735         (gdbsim_close_inferior, simulator_command)
7736         (sim_command_completer, _initialize_remote_sim): Update.
7737         (next_pid, INITIAL_PID): Move earlier.
7738
7739 2019-07-10  Tom Tromey  <tromey@adacore.com>
7740
7741         * python/python-internal.h (create_thread_object): Return
7742         gdbpy_ref.
7743         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7744         * python/py-inferior.c (struct threadlist_entry): Add
7745         constructor.
7746         <thread_obj>: Now a gdbpy_ref.
7747         (thread_to_thread_object): Update.
7748         (add_thread_object): Use new.
7749         (delete_thread_object): Use delete.
7750         (infpy_threads): Update.
7751         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7752         GIL.
7753
7754 2019-07-10  Tom Tromey  <tromey@adacore.com>
7755
7756         * valops.c (value_cast): Specialize error message for Ada.
7757
7758 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7759
7760         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7761
7762 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7763
7764         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7765         bpstat_should_step): Return bool, adjust comments.
7766         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7767         bpstat_should_step): Likewise.
7768
7769 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7770
7771         * features/Makefile: Use feature target descriptions for Arm.
7772         * features/arm/arm-core.c: Generate new file.
7773         * features/arm/arm-fpa.c: Likewise.
7774         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7775         * features/arm/arm-m-profile.c: Likewise.
7776         * features/arm/arm-vfpv2.c: Likewise.
7777         * features/arm/arm-vfpv3.c: Likewise.
7778         * features/arm/xscale-iwmmxt.c: Likewise.
7779         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7780
7781 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7782
7783         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7784         ptrace earlier.
7785
7786 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7787
7788         * features/aarch64-pauth.c: Regenerate.
7789
7790 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7791
7792         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7793         bool.
7794         (bpstat_what): Use false instead of 0.
7795
7796 2019-07-09  Pedro Alves  <palves@redhat.com>
7797
7798         * break-catch-throw.c (is_exception_catchpoint): New.
7799         * breakpoint.c (print_one_breakpoint_location): New parameter
7800         'raw_loc'.  Handle it.  Use
7801         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7802         looking at the breakpoint's type.
7803         (print_one_breakpoint): If handling "maint info breakpoints", also
7804         print locations of exception catchpoints.
7805         * breakpoint.h (is_exception_catchpoint): Declare.
7806
7807 2019-07-09  Pedro Alves  <palves@redhat.com>
7808
7809         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7810         "addr" field.
7811         (allocate_location_exception_catchpoint): New.
7812         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7813         (initialize_throw_catchpoint_ops): Install
7814         allocate_location_exception_catchpoint as allocate_location
7815         method.
7816         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7817         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7818         bp_loc_other.
7819         (breakpoint_address_is_meaningful): Delete.
7820         (bl_address_is_meaningful): New.
7821         (breakpoint_locations_match): Adjust comment.
7822         (bp_location_from_bp_type): New, factored out of...
7823         (bp_location::bp_location(breakpoint *)): ... this.
7824         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7825         factored out of...
7826         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7827         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7828         breakpoint_address_is_meaningful.
7829         (bp_locations_compare): Adjust comment.
7830         (update_global_location_list): Use bl_address_is_meaningful
7831         instead of breakpoint_address_is_meaningful.
7832         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7833         explicit.
7834         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7835         * python/py-breakpoint.c (bppy_get_location): No longer check
7836         whether location is null.
7837
7838 2019-07-09  Pedro Alves  <palves@redhat.com>
7839
7840         PR c++/15468
7841         * breakpoint.c (print_one_breakpoint_location): Remove
7842         single-location assert.
7843
7844 2019-07-09  Tom Tromey  <tom@tromey.com>
7845
7846         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7847         * configure: Rebuild.
7848         * configure.ac: Change common to gdbsupport.
7849         * gdbsupport: Rename from common.
7850         * acinclude.m4: Change common to gdbsupport.
7851         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7852         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7853         gdbsupport.
7854         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7855         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7856         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7857         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7858         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7859         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7860         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7861         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7862         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7863         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7864         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7865         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7866         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7867         coff-pe-read.c, command.h, compile/compile-c-support.c,
7868         compile/compile-c.h, compile/compile-cplus-symbols.c,
7869         compile/compile-cplus-types.c, compile/compile-cplus.h,
7870         compile/compile-loc2c.c, compile/compile.c, completer.c,
7871         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7872         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7873         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7874         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7875         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7876         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7877         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7878         features/aarch64-core.c, features/aarch64-fpu.c,
7879         features/aarch64-pauth.c, features/aarch64-sve.c,
7880         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7881         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7882         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7883         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7884         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7885         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7886         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7887         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7888         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7889         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7890         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7891         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7892         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7893         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7894         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7895         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7896         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7897         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7898         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7899         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7900         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7901         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7902         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7903         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7904         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7905         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7906         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7907         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7908         minsyms.c, mips-linux-tdep.c, namespace.h,
7909         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7910         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7911         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7912         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7913         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7914         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7915         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7916         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7917         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7918         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7919         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7920         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7921         procfs.c, producer.c, progspace.h, psymtab.h,
7922         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7923         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7924         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7925         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7926         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7927         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7928         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7929         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7930         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7931         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7932         target-memory.c, target.c, target.h, target/waitstatus.c,
7933         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7934         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7935         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7936         unittests/array-view-selftests.c,
7937         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7938         unittests/common-utils-selftests.c,
7939         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7940         unittests/format_pieces-selftests.c,
7941         unittests/function-view-selftests.c,
7942         unittests/lookup_name_info-selftests.c,
7943         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7944         unittests/mkdir-recursive-selftests.c,
7945         unittests/observable-selftests.c,
7946         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7947         unittests/parse-connection-spec-selftests.c,
7948         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7949         unittests/scoped_fd-selftests.c,
7950         unittests/scoped_mmap-selftests.c,
7951         unittests/scoped_restore-selftests.c,
7952         unittests/string_view-selftests.c, unittests/style-selftests.c,
7953         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7954         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7955         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7956         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7957         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7958         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7959
7960 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7963         bool value.
7964         (decode_digits_ordinary): Set explicit_line field in sal.
7965         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7966         symtab_and_line that was set on an explicit line number in
7967         assembler code.  Do always update the recorded symtab and line if
7968         we do skip the prologue.
7969
7970 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * breakpoint.c (set_breakpoint_location_function): Remove
7973         explicit_loc parameter.
7974         (momentary_breakpoint_from_master): Update call to
7975         set_breakpoint_location_function.
7976         (add_location_to_breakpoint): Likewise.
7977
7978 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7981         required features based on default bfd type when no specific bfd
7982         is present.
7983
7984 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7985
7986         * NEWS: Mention that GDB printf and eval commands can now print
7987         C-style and Ada-style convenience var strings without
7988         calling the inferior.
7989         * printcmd.c (printf_c_string): Locally print GDB internal var
7990         instead of transiting via the inferior.
7991         (printf_wide_c_string): Likewise.
7992
7993 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7994
7995         PR breakpoints/25011
7996         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7997
7998 2019-07-04  Tom Tromey  <tom@tromey.com>
7999
8000         PR tui/24724:
8001         * tui/tui-winsource.c (tui_clear_source_content): Update.
8002         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8003         (tui_update_breakpoint_info): Update.
8004         (tui_set_exec_info_content): Update.
8005         * tui/tui-source.c (tui_set_source_content_nil): Update.
8006         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8007         has_break.
8008         * tui/tui-data.h (enum tui_bp_flag): New.
8009         (tui_bp_flags): New enum flags type.
8010         (struct tui_source_element) <break_mode>: Change type.  Rename
8011         from has_break.
8012         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8013         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8014         constants.
8015         * tui/tui-winsource.h: Fix comment.
8016
8017 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8018
8019         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8020         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8021         (store_fpregs_to_thread)
8022         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8023         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8024         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8025         (IWMMXT_REGS_SIZE): Add define.
8026         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8027         (fetch_vfp_regs, store_vfp_regs)
8028         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8029         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8030
8031 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8032
8033         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8034         defines.
8035         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8036         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8037         (ARM_INT_REGISTER_SIZE): ...to this.
8038         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8039         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8040         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8041         (arm_linux_collect_gregset, supply_nwfpe_register)
8042         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8043         defines.
8044         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8045         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8046         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8047         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8048         (arm_return_in_memory, arm_store_return_value)
8049         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8050         (arm_record_ld_st_multiple): Likewise.
8051         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8052         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8053
8054 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8055
8056         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8057         AARCH64_DISPLACED_MODIFIED_INSNS.
8058         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8059         (aarch64_displaced_step_copy_insn): Likewise.
8060         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8061         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8062         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8063         ARM_DISPLACED_MODIFIED_INSNS.
8064         * arm-tdep.c (arm_gdbarch_init): Likewise.
8065         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8066         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8067         (struct arm_displaced_step_closure): Use
8068         ARM_DISPLACED_MODIFIED_INSNS.
8069
8070 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8071
8072         * features/Makefile: Remove unused xml files.
8073         * features/aarch64.xml: Remove.
8074         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8075         * features/i386/amd64-avx-avx512.xml: Remove.
8076         * features/i386/amd64-avx-linux.xml: Remove.
8077         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8078         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8079         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8080         * features/i386/amd64-avx-mpx.xml: Remove.
8081         * features/i386/amd64-avx.xml: Remove.
8082         * features/i386/amd64-linux.xml: Remove.
8083         * features/i386/amd64-mpx-linux.xml: Remove.
8084         * features/i386/amd64-mpx.xml: Remove.
8085         * features/i386/amd64.xml: Remove.
8086         * features/i386/i386-avx-avx512-linux.xml: Remove.
8087         * features/i386/i386-avx-avx512.xml: Remove.
8088         * features/i386/i386-avx-linux.xml: Remove.
8089         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8090         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8091         * features/i386/i386-avx-mpx-linux.xml: Remove.
8092         * features/i386/i386-avx-mpx.xml: Remove.
8093         * features/i386/i386-avx.xml: Remove.
8094         * features/i386/i386-linux.xml: Remove.
8095         * features/i386/i386-mmx-linux.xml: Remove.
8096         * features/i386/i386-mmx.xml: Remove.
8097         * features/i386/i386-mpx-linux.xml: Remove.
8098         * features/i386/i386-mpx.xml: Remove.
8099         * features/i386/i386.xml: Remove.
8100         * features/i386/x32-avx-avx512-linux.xml: Remove.
8101         * features/i386/x32-avx-linux.xml: Remove.
8102         * features/i386/x32-linux.xml: Remove.
8103
8104 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8105
8106         * regformats/aarch64.dat: Remove.
8107         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8108         * regformats/i386/amd64-avx-linux.dat: Remove.
8109         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8110         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8111         * regformats/i386/amd64-linux.dat: Remove.
8112         * regformats/i386/amd64-mpx-linux.dat: Remove.
8113         * regformats/i386/amd64.dat: Remove.
8114         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8115         * regformats/i386/i386-avx-linux.dat: Remove.
8116         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8117         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8118         * regformats/i386/i386-linux.dat: Remove.
8119         * regformats/i386/i386-mmx-linux.dat: Remove.
8120         * regformats/i386/i386-mpx-linux.dat: Remove.
8121         * regformats/i386/i386.dat: Remove.
8122         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8123         * regformats/i386/x32-avx-linux.dat: Remove.
8124         * regformats/i386/x32-linux.dat: Remove.
8125
8126 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8127
8128         * aarch64-tdep.c: Remove xml self tests.
8129         * amd64-linux-tdep.c: Likewise.
8130         * amd64-tdep.c: Likewise.
8131         * i386-linux-tdep.c: Likewise.
8132         * i386-tdep.c: Likewise.
8133
8134 2019-07-03  Pedro Alves  <palves@redhat.com>
8135
8136         PR cli/24732
8137         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8138         (pipe_cmd_option_defs): New.
8139         (make_pipe_cmd_options_def_group): New.
8140         (pipe_command): Use gdb::option::process_options.
8141         (pipe_command_completer): New function.
8142         (_initialize_cli_cmds): Install completer for "pipe" command.
8143
8144 2019-07-03  Pedro Alves  <palves@redhat.com>
8145
8146         * cli/cli-option.c (union option_value) <string>: New field.
8147         (struct option_def_and_value): Add ctor, move ctor, dtor and
8148         use DISABLE_COPY_AND_ASSIGN.
8149         (option_def_and_value::clear_value): New.
8150         (parse_option, save_option_value_in_ctx, get_val_type_str)
8151         (add_setshow_cmds_for_options): Handle var_string.
8152         * cli-option.h (union option_def::var_address) <string>: New
8153         field.
8154         (struct string_option_def): New.
8155         * maint-test-options.c (struct test_options_opts): Add default
8156         ctor and use DISABLE_COPY_AND_ASSIGN.
8157         <string_opt>: New field.
8158         (test_options_opts::~test_options_opts): New.
8159         (test_options_opts::dump): Also dump "-string".
8160         (test_options_option_defs): Install "string.
8161
8162 2019-07-03  Pedro Alves  <palves@redhat.com>
8163
8164         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8165         option_value with a null enumeration.
8166         (complete_options): Save the option values in the context.
8167         (save_option_value_in_ctx): New, factored out from ...
8168         (process_options): ... here.
8169         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8170         of the function.
8171         * maint-test-options.c (test_options_opts::dump): New, factored
8172         out from ...
8173         (maintenance_test_options_command_mode): ... here.
8174         (maintenance_test_options_command_completion_result): Delete.
8175         (maintenance_test_options_command_completion_text): Update
8176         comment.
8177         (maintenance_show_test_options_completion_result): Change
8178         prototype.  Just print
8179         maintenance_test_options_command_completion_text.
8180         (save_completion_result): New.
8181         (maintenance_test_options_completer_mode): Pass options context to
8182         complete_options, and then save a dump.
8183         (_initialize_maint_test_options): Use add_cmd to install "maint
8184         show test-options-completion-result".
8185
8186 2019-07-03  Pedro Alves  <palves@redhat.com>
8187
8188         * NEWS (New commands): Mention "with" and "maint with".
8189         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8190         (with_command, with_command_completer): New.
8191         (pipe_command): Adjust to new repeat_previous
8192         interface.
8193         (_initialize_cli_cmds): Install the "with" command and its "w"
8194         alias.
8195         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8196         declarations.
8197         * cli/cli-setshow.c (parse_cli_var_uinteger)
8198         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8199         argument strings for all var_types.
8200         (get_setshow_command_value_string): New, factored out from ...
8201         (do_show_command): ... this.
8202         * cli/cli-setshow.h: Include <string>.
8203         (get_setshow_command_value_string): Declare.
8204         * command.h (repeat_previous): Now returns const char *.  Adjust
8205         comment.
8206         * maint.c: Include "cli/cli-cmds.h".
8207         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8208         (_initialize_maint_cmds): Register the "maintenance with" command.
8209         * top.c (repeat_previous): Move bits from pipe_command here:
8210         Return the saved command line, if any; error out if there's no
8211         command to relaunch.
8212
8213 2019-07-03  Pedro Alves  <palves@redhat.com>
8214
8215         * NEWS (New commands): Mention "maint set/show test-settings"
8216         instead of "maint test-settings".
8217         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8218         (maintenance_test_settings_set_list): Rename to ...
8219         (maintenance_set_test_settings_list): ... this.
8220         (maintenance_test_settings_show_list): Rename to  ...
8221         (maintenance_show_test_settings_list): ... this.
8222         (maintenance_test_settings_cmd): Delete.
8223         (maintenance_test_settings_set_cmd): ...
8224         (maintenance_set_test_settings_cmd): ... this.
8225         (maintenance_test_settings_show_cmd): ...
8226         (maintenance_show_test_settings_cmd): ... this.
8227         (maintenance_test_settings_show_value_cmd):
8228         (maintenance_show_test_settings_value_cmd): ... this.
8229         (_initialize_maint_test_settings): No longer install the "maint
8230         test-settings" prefix command.  Rename "maint test-settings set"
8231         to "maint set test-settings", and "maint test-settings show" to
8232         "maint show test-settings".  Adjust all subcommands.
8233
8234 2019-07-03  Pedro Alves  <palves@redhat.com>
8235
8236         * maint-test-settings.c: Fix file's intro comment.  Replace all
8237         references to "test-options" with references to "test-settings",
8238         in comments.
8239
8240 2019-07-03  Pedro Alves  <palves@redhat.com>
8241
8242         * maint-test-settings.c (maintenance_test_settings_xxx)
8243         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8244         New.
8245         (maintenance_test_settings_enums): Use them.
8246         (maintenance_test_settings_enum): Default to
8247         maintenance_test_settings_xxx.
8248         (_initialize_maint_test_settings): Initialize
8249         MAINTENANCE_TEST_SETTINGS_FILENAME.
8250
8251 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8252
8253         * breakpoint.h (remove_breakpoints_inf): Change return type to
8254         void, move function documentation here.
8255         * breakpoint.c (remove_breakpoints_inf): Change return type to
8256         void, move function documentation to header.
8257
8258 2019-07-02  Pedro Alves  <palves@redhat.com>
8259
8260         * NEWS (Completion improvements): Mention "info threads".
8261         * thread.c (struct info_threads_opts, info_threads_option_defs)
8262         (make_info_threads_options_def_group): New.
8263         (info_threads_command): Use gdb::option::process_options.
8264         (info_threads_command_completer): New.
8265         (_initialize_thread): Use gdb::option::build_help to build the
8266         help text for "info threads".
8267
8268 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8269
8270         * defs.h (generic_load): Move from here...
8271         * symfile.h (generic_load): ... to here.  Rename name parameter
8272         to args.
8273         * symfile.c (generic_load): Add comment.
8274
8275 2019-07-01  Tom Tromey  <tromey@adacore.com>
8276
8277         * dwarf2read.c
8278         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8279         declaration of without_params.  Fix formatting.
8280
8281 2019-07-01  Tom Tromey  <tromey@adacore.com>
8282
8283         * ada-exp.y (find_primitive_type): Update.
8284         * ada-lang.h (ada_lookup_symbol): Update.
8285         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8286         parameter.
8287         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8288
8289 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8290
8291         PR breakpoints/24541
8292         * gdbarch.c: Regenerate.
8293         * gdbarch.h: Regenerate.
8294         * gdbarch.sh: Add 'stap_adjust_register'.
8295         * i386-tdep.c: Include '<unordered_set>'.
8296         (i386_stap_adjust_register): New function.
8297         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8298         * stap-probe.c (stap_parse_register_operand): Call
8299         'gdbarch_stap_adjust_register'.
8300
8301 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8302
8303         PR python/24742
8304         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8305         * python/python.c (do_start_initialization): Use 'xmalloc'
8306         instead of 'PyMem_Malloc'.
8307
8308 2019-06-28  Tom Tromey  <tromey@adacore.com>
8309
8310         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8311         for Ada.
8312
8313 2019-06-27  Tom Tromey  <tromey@adacore.com>
8314
8315         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8316         objfile_key.
8317         (arm_find_mapping_symbol, arm_record_special_symbol)
8318         (_initialize_arm_tdep): Update.
8319         (arm_objfile_data_free): Remove.
8320
8321 2019-06-27  Tom Tromey  <tromey@adacore.com>
8322
8323         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8324         to cp_print_static_field.
8325
8326 2019-06-26  Tom Tromey  <tromey@adacore.com>
8327
8328         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8329         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8330         declare.
8331
8332 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8333
8334         * features/aarch64-core.c (create_feature_aarch64_core):
8335         Regenerate.
8336         * features/aarch64-core.xml: Add cpsr flags.
8337
8338 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8339
8340         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8341         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8342
8343 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8344
8345         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8346         field.
8347         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8348         use.
8349         (arm_record_special_symbol): Don't insert new symbol in sorted
8350         position, push it at the end.
8351
8352 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8353
8354         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8355         (arm_mapping_symbol_s): Remove.
8356         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8357         (arm_mapping_symbol_vec): New typedef.
8358         (struct arm_per_objfile): Add constructor.
8359         <section_maps>: Change type to
8360         std::unique_ptr<arm_mapping_symbol_vec[]>.
8361         (arm_compare_mapping_symbols): Remove.
8362         (arm_find_mapping_symbol): Adjust to section_maps type change.
8363         (arm_objfile_data_free): Call delete on arm_per_objfile.
8364         (arm_record_special_symbol): Adjust to section_maps type change.
8365         Allocate arm_per_objfile with new.
8366
8367 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8368
8369         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8370         with the command prefix.
8371
8372 2019-06-25  Tom Tromey  <tom@tromey.com>
8373
8374         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8375         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8376
8377 2019-06-25  Tom Tromey  <tom@tromey.com>
8378
8379         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8380         type.
8381         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8382         protected.
8383
8384 2019-06-25  Tom Tromey  <tom@tromey.com>
8385
8386         * tui/tui-winsource.c
8387         (tui_source_window_base::set_is_exec_point_at): Add check against
8388         LOA_ADDRESS.
8389
8390 2019-06-25  Tom Tromey  <tom@tromey.com>
8391
8392         * tui/tui-source.c (tui_set_source_content): Don't check before
8393         xfree.
8394         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8395
8396 2019-06-25  Tom Tromey  <tom@tromey.com>
8397
8398         * tui/tui-winsource.h (tui_update_source_window_as_is)
8399         (tui_alloc_source_buffer, tui_line_is_displayed)
8400         (tui_addr_is_displayed): Change type of win_info.
8401         * tui/tui-winsource.c (tui_update_source_window_as_is)
8402         (tui_clear_source_content, tui_show_source_line)
8403         (tui_show_source_content, tui_source_window_base::refill)
8404         (tui_source_window_base::set_is_exec_point_at)
8405         (tui_source_window_base::set_is_exec_point_at)
8406         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8407         (tui_alloc_source_buffer, tui_line_is_displayed)
8408         (tui_addr_is_displayed): Change type of win_info.  Update.
8409         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8410         (tui_source_window_base::do_make_visible_with_new_height):
8411         Update.
8412         * tui/tui-source.c (tui_set_source_content)
8413         (tui_set_source_content_nil)
8414         (tui_source_window::do_scroll_vertical): Update.
8415         * tui/tui-layout.c (show_layout): Update.
8416         * tui/tui-disasm.c (tui_set_disassem_content)
8417         (tui_disasm_window::do_scroll_vertical): Update.
8418         * tui/tui-data.h (tui_win_content): Remove.
8419         (struct tui_gen_win_info) <content, content_size>: Remove.
8420         (struct tui_source_element): Add initializers and destructor.
8421         (union tui_which_element, struct tui_win_element): Remove.
8422         (struct tui_source_window_base) <content>: New field.
8423         (struct tui_data_window): Remove destructor.
8424         (tui_alloc_content, tui_free_win_content)
8425         (tui_free_all_source_wins_content): Don't declare.
8426         * tui/tui-data.c (tui_initialize_static_data): Update.
8427         (init_content_element, tui_alloc_content): Remove.
8428         (~tui_gen_win_info): Update.
8429         (~tui_data_window, tui_free_all_source_wins_content)
8430         (tui_free_win_content, free_content, free_content_elements):
8431         Remove.
8432
8433 2019-06-25  Tom Tromey  <tom@tromey.com>
8434
8435         * tui/tui-winsource.h (tui_clear_source_content)
8436         (tui_erase_source_content, tui_show_source_content): Change type
8437         of win_info.
8438         * tui/tui-winsource.c (tui_clear_source_content)
8439         (tui_erase_source_content, tui_show_source_content): Change type
8440         of win_info.
8441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8442         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8443         win_info.
8444         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8445         win_info.
8446         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8447
8448 2019-06-25  Tom Tromey  <tom@tromey.com>
8449
8450         * tui/tui-winsource.c (tui_clear_source_content)
8451         (tui_source_window_base::set_is_exec_point_at): Update.
8452         * tui/tui-source.c (tui_set_source_content_nil): Update.
8453         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8454         a bool.
8455         * tui/tui-data.c (init_content_element): Update.
8456
8457 2019-06-25  Tom Tromey  <tom@tromey.com>
8458
8459         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8460         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8461         * tui/tui-layout.c (init_and_make_win): Update.
8462         * tui/tui.h (enum tui_win_type): Update.
8463         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8464         tui_win_is_auxillary.
8465         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8466         tui_win_is_auxillary.
8467
8468 2019-06-25  Tom Tromey  <tom@tromey.com>
8469
8470         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8471         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8472         (tui_delete_data_content_windows, tui_display_all_data)
8473         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8474         Update.
8475         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8476         * tui/tui-regs.c (tui_last_regs_line_no)
8477         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8478         (tui_show_registers): Update.
8479         (tui_show_register_group): Return void.  Update.
8480         (tui_display_registers_from, tui_display_reg_element_at_line)
8481         (tui_display_registers_from_line, tui_check_register_values):
8482         Update.
8483         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8484         member.
8485         (struct tui_data_window) <regs_content>: Now a std::vector.
8486         <regs_content_count>: Remove.
8487         (tui_add_content_elements, tui_free_data_content): Don't declare.
8488         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8489         (init_content_element): Remove DATA_WIN case.  Add assert.
8490         (tui_add_content_elements): Remove.
8491         (tui_data_window): Update.
8492         (tui_free_data_content): Remove.
8493         (free_content_elements): Remove DATA_WIN case.
8494
8495 2019-06-25  Tom Tromey  <tom@tromey.com>
8496
8497         * tui/tui-data.c (tui_data_item_window): Update.
8498         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8499         * tui/tui-windata.c (tui_display_all_data)
8500         (tui_display_data_from_line): Update.
8501         (tui_check_data_values): Remove.
8502         * tui/tui-regs.c (tui_show_register_group)
8503         (tui_display_reg_element_at_line): Update.
8504         * tui/tui-hooks.c (tui_register_changed)
8505         (tui_refresh_frame_and_register_information): Call
8506         tui_check_register_values.
8507         * tui/tui-data.h (struct tui_data_window) <data_content,
8508         data_content_count, data_type>: Remove.
8509         (enum tui_data_type): Remove.
8510
8511         * tui/tui-data.c (tui_data_window::clear_detail)
8512         (~tui_data_window): Update.
8513
8514 2019-06-25  Tom Tromey  <tom@tromey.com>
8515
8516         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8517         declare.
8518         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8519         Rename from tui_first_data_item_displayed.  Update.
8520         (tui_data_window::refresh_all)
8521         (tui_data_window::do_scroll_vertical): Update.
8522         * tui/tui-data.h (struct tui_data_window)
8523         <first_data_item_displayed>: Declare new method.
8524
8525 2019-06-25  Tom Tromey  <tom@tromey.com>
8526
8527         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8528         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8529         contents...
8530         (tui_initialize_static_data): ...here.
8531
8532 2019-06-25  Tom Tromey  <tom@tromey.com>
8533
8534         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8535         (tui_display_registers_from, tui_check_register_values): Update.
8536         (tui_display_register): Remove win_info parameter; update.
8537         (tui_get_register): Change type of parameters.
8538         * tui/tui-data.h (struct tui_data_element): Remove.
8539         (union tui_which_element) <data>: Remove.
8540         <data_window>: Change type.
8541         (struct tui_data_item_window): New.
8542         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8543         case.  Add assert.
8544         (~tui_data_item_window): New destructor.
8545         (free_content_elements): Remove DATA_ITEM_WIN case.
8546
8547 2019-06-25  Tom Tromey  <tom@tromey.com>
8548
8549         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8550         Remove.
8551
8552 2019-06-25  Tom Tromey  <tom@tromey.com>
8553
8554         * tui/tui-data.h (struct tui_command_element): Remove.
8555         (union tui_which_element) <command>: Remove.
8556         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8557         assert.
8558         (free_content_elements): Remove CMD_WIN case.
8559
8560 2019-06-25  Tom Tromey  <tom@tromey.com>
8561
8562         * tui/tui-layout.c (tui_set_layout): Update.
8563         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8564         * tui/tui-data.c (layout_def): Update.
8565
8566 2019-06-25  Tom Tromey  <tom@tromey.com>
8567
8568         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8569         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8570         (tui_source_window_base::set_new_height): Update.
8571         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8572         Update.
8573         (tui_set_locator_fullname, tui_set_locator_info)
8574         (tui_show_frame_info): Update.
8575         * tui/tui-source.c (tui_set_source_content)
8576         (tui_source_is_displayed): Update.
8577         * tui/tui-layout.c (show_source_disasm_command, show_data)
8578         (show_source_or_disasm_and_command): Update.
8579         * tui/tui-disasm.c (tui_set_disassem_content)
8580         (tui_get_begin_asm_address): Update.
8581         * tui/tui-data.h (struct tui_locator_element): Remove.
8582         (union tui_which_element) <locator>: Remove.
8583         (struct tui_locator_window): New.
8584         (tui_locator_win_info_ptr): Change return type.
8585         * tui/tui-data.c (_locator): Change type.
8586         (tui_locator_win_info_ptr): Change return type.
8587         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8588         (tui_alloc_content): Add assert.
8589
8590 2019-06-25  Tom Tromey  <tom@tromey.com>
8591
8592         * tui/tui-winsource.c
8593         (tui_exec_info_window::maybe_allocate_content): New method.
8594         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8595         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8596         (make_source_or_disasm_window): Add cast.
8597         * tui/tui-data.h (union tui_which_element) <simple_string>:
8598         Remove.
8599         (struct tui_source_info): New.
8600         (struct tui_source_window_base) <execution_info>: Change type.
8601         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8602         case, and add assert.
8603         (tui_alloc_content): Add assert.
8604
8605 2019-06-25  Tom Tromey  <tom@tromey.com>
8606
8607         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8608         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8609         * tui/tui-data.c (tui_alloc_win_info): Remove.
8610
8611 2019-06-25  Tom Tromey  <tom@tromey.com>
8612
8613         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8614         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8615         can_highlight.
8616
8617 2019-06-25  Tom Tromey  <tom@tromey.com>
8618
8619         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8620         make_visible_with_new_height method.
8621         (tui_win_info::make_visible_with_new_height): New method.
8622         (tui_source_window_base::do_make_visible_with_new_height)
8623         (tui_data_window::do_make_visible_with_new_height)
8624         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8625         (make_visible_with_new_height): Remove.
8626         (tui_resize_all, tui_adjust_win_heights): Use
8627         make_visible_with_new_height method.
8628         * tui/tui-data.h (struct tui_win_info)
8629         <do_make_visible_with_new_height, make_visible_with_new_height>:
8630         New methods.
8631         (struct tui_source_window_base, struct tui_data_window)
8632         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8633         methods.
8634
8635 2019-06-25  Tom Tromey  <tom@tromey.com>
8636
8637         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8638         method.
8639         (update_tab_width): Call update_tab_width method.
8640         * tui/tui-data.h (struct tui_win_info)
8641         (struct tui_source_window_base) <update_tab_width>: New methods.
8642
8643 2019-06-25  Tom Tromey  <tom@tromey.com>
8644
8645         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8646         parameter.
8647         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8648         parameter.
8649         (tui_gen_win_info::make_visible): Update.
8650         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8651         parameter.
8652         * tui/tui-data.h (enum tui_box): New enum.
8653         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8654
8655 2019-06-25  Tom Tromey  <tom@tromey.com>
8656
8657         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8658         init_and_make_win for EXEC_INFO_WIN.
8659         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8660         longer inline.
8661         (struct tui_win_info) <~tui_win_info>: Inline.
8662         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8663         Don't declare.
8664         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8665         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8666         Remove.
8667         (tui_initialize_static_data): Update.
8668         (~tui_gen_win_info): Handle more cleanup here.
8669         (~tui_source_window_base): Delete "execution_info".
8670         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8671
8672 2019-06-25  Tom Tromey  <tom@tromey.com>
8673
8674         * tui/tui-layout.c (make_command_window): Don't set
8675         can_highlight.
8676         (show_source_disasm_command): Call the reset method.
8677         (show_data): Don't set can_highlight.  Call the reset method.
8678         (tui_gen_win_info::reset): Rename from init_gen_win_info
8679         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8680         (show_source_or_disasm_and_command): Call the reset method.
8681         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8682         (struct tui_cmd_window): Set can_highlight.
8683
8684 2019-06-25  Tom Tromey  <tom@tromey.com>
8685
8686         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8687         from make_visible.
8688         (tui_make_visible, tui_make_invisible): Rewrite.
8689         (tui_win_info::make_visible): Remove.
8690         (tui_source_window_base::make_visible): Update.
8691         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8692         method.  Moved from...
8693         (struct tui_win_info) <make_visible>: ...here.
8694
8695 2019-06-25  Tom Tromey  <tom@tromey.com>
8696
8697         * tui/tui-winsource.c
8698         (tui_source_window_base::do_scroll_horizontal): Remove direction
8699         parameter.
8700         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8701         direction parameter.
8702         * tui/tui-win.c (tui_win_info::forward_scroll)
8703         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8704         (tui_win_info::right_scroll): Update.
8705         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8706         direction parameter.
8707         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8708         direction parameter.
8709         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8710         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8711         Remove direction parameter.
8712         (struct tui_source_window_base, struct tui_source_window)
8713         (struct tui_disasm_window, struct tui_data_window)
8714         (struct tui_cmd_window): Update.
8715
8716 2019-06-25  Tom Tromey  <tom@tromey.com>
8717
8718         * tui/tui-winsource.h (tui_set_exec_info_content)
8719         (tui_show_exec_info_content, tui_erase_exec_info_content)
8720         (tui_clear_exec_info_content, tui_update_exec_info): Change
8721         argument to tui_source_window_base.
8722         * tui/tui-winsource.c (tui_set_exec_info_content)
8723         (tui_show_exec_info_content, tui_erase_exec_info_content)
8724         (tui_clear_exec_info_content, tui_update_exec_info): Change
8725         argument to tui_source_window_base.
8726
8727 2019-06-25  Tom Tromey  <tom@tromey.com>
8728
8729         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8730         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8731
8732 2019-06-25  Tom Tromey  <tom@tromey.com>
8733
8734         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8735         check.
8736
8737 2019-06-25  Tom Tromey  <tom@tromey.com>
8738
8739         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8740         type to void.
8741         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8742         type to void.
8743         * tui/tui-source.c (tui_set_source_content): Update.
8744         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8745
8746 2019-06-25  Tom Tromey  <tom@tromey.com>
8747
8748         * tui/tui-win.c (window_name_completer, tui_set_focus)
8749         (tui_all_windows_info): Use name method.
8750         * tui/tui-data.h (struct tui_gen_win_info)
8751         (struct tui_source_window, struct tui_disasm_window)
8752         (struct tui_data_window, struct tui_cmd_window) <name>: New
8753         method.
8754         (tui_win_name): Don't declare.
8755         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8756         (tui_win_name): Remove.
8757
8758 2019-06-25  Tom Tromey  <tom@tromey.com>
8759
8760         * tui/tui-winsource.h (tui_update_source_window)
8761         (tui_update_source_window_as_is): Change parameter type.
8762         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8763         to be a tui_source_window_base.
8764         (tui_update_source_window_as_is): Likewise.
8765         * tui/tui-win.c (make_visible_with_new_height): Update.
8766
8767 2019-06-25  Tom Tromey  <tom@tromey.com>
8768
8769         * tui/tui-winsource.c (tui_erase_source_content)
8770         (tui_show_source_content, tui_show_exec_info_content)
8771         (tui_erase_exec_info_content): Use refresh_window method.
8772         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8773         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8774         from tui_refresh_win.
8775         (tui_data_window::refresh_window): New method.
8776         (tui_win_info::refresh, tui_source_window_base::refresh)
8777         (tui_refresh_all): Use refresh_window method.
8778         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8779         method.
8780         * tui/tui-regs.c (tui_display_register): Call refresh_window
8781         method.
8782         * tui/tui-layout.c (show_source_disasm_command)
8783         (show_source_or_disasm_and_command): Call refresh_window method.
8784         * tui/tui-data.h (struct tui_gen_win_info)
8785         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8786         New method.
8787
8788 2019-06-25  Tom Tromey  <tom@tromey.com>
8789
8790         * tui/tui.c (tui_rl_other_window, tui_enable)
8791         (tui_is_window_visible, tui_get_command_dimension): Update.
8792         * tui/tui-winsource.c (tui_update_source_window_as_is)
8793         (tui_clear_source_content, tui_erase_source_content)
8794         (tui_show_source_line, tui_source_window_base::refill)
8795         (tui_source_window_base::do_scroll_horizontal)
8796         (tui_source_window_base::set_is_exec_point_at)
8797         (tui_update_breakpoint_info, tui_set_exec_info_content)
8798         (tui_alloc_source_buffer, tui_line_is_displayed)
8799         (tui_addr_is_displayed): Update.
8800         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8801         (tui_check_and_display_highlight_if_needed)
8802         (tui_win_info::make_visible, tui_win_info::refresh)
8803         (tui_refresh_all): Update.
8804         * tui/tui-windata.c (tui_first_data_item_displayed)
8805         (tui_delete_data_content_windows, tui_erase_data_content)
8806         (tui_display_all_data, tui_data_window::refresh_all)
8807         (tui_check_data_values): Update.
8808         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8809         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8810         (tui_win_info::backward_scroll, tui_refresh_all_win)
8811         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8812         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8813         (tui_source_window_base::set_new_height)
8814         (tui_data_window::set_new_height)
8815         (make_invisible_and_set_new_height)
8816         (make_visible_with_new_height, new_height_ok)
8817         (parse_scrolling_args): Update.
8818         * tui/tui-stack.c (tui_show_frame_info): Update.
8819         * tui/tui-source.c (tui_set_source_content)
8820         (tui_set_source_content_nil, tui_source_is_displayed)
8821         (tui_source_window::do_scroll_vertical): Update.
8822         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8823         (tui_display_registers_from, tui_display_reg_element_at_line)
8824         (tui_check_register_values, tui_reg_command): Update.
8825         * tui/tui-layout.c (tui_default_win_height)
8826         (show_source_disasm_command, show_data, init_and_make_win)
8827         (show_source_or_disasm_and_command): Update.
8828         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8829         (tui_redisplay_readline, tui_mld_flush)
8830         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8831         (tui_getc): Update.
8832         * tui/tui-disasm.c (tui_set_disassem_content)
8833         (tui_disasm_window::do_scroll_vertical): Update.
8834         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8835         Now virtual.
8836         (struct tui_win_info): Derive from tui_gen_win_info.
8837         <~tui_win_info>: Mark as override.
8838         <generic>: Remove member.
8839         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8840         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8841         (~tui_data_window, ~tui_win_info)
8842         (tui_free_all_source_wins_content): Update.
8843         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8844
8845 2019-06-25  Tom Tromey  <tom@tromey.com>
8846
8847         * tui/tui-layout.c (init_and_make_win): Use new.
8848         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8849         destructor, initializers.
8850         (tui_alloc_generic_win_info): Don't declare.
8851         * tui/tui-data.c (_locator): Add argument to constructor.
8852         (source_win, disasm_win): New globals.
8853         (exec_info): Remove.
8854         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8855         Update.
8856         (tui_alloc_generic_win_info): Remove.
8857         (init_content_element): Use new.
8858         (tui_win_info::tui_win_info): Update.
8859         (free_content_elements) <case DATA_WIN>: Use delete.
8860
8861 2019-06-25  Tom Tromey  <tom@tromey.com>
8862
8863         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8864         * tui/tui-windata.c (tui_first_data_item_displayed)
8865         (tui_delete_data_content_windows): Update.
8866         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8867         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8868         (tui_display_registers_from, tui_check_register_values): Update.
8869         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8870         pointer.
8871         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8872         window.
8873         (tui_free_data_content): Update.
8874         (free_content_elements) <case DATA_WIN>: Free the window.
8875
8876 2019-06-25  Tom Tromey  <tom@tromey.com>
8877
8878         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8879         Update.
8880         * tui/tui-layout.c (make_command_window)
8881         (show_source_disasm_command, show_data, init_and_make_win)
8882         (show_source_or_disasm_and_command): Update.
8883         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8884         method.
8885         <can_highight, is_highlighted>: Now bool.
8886         (tui_set_win_highlight): Don't declare.
8887         * tui/tui-data.c (tui_set_win_highlight): Remove.
8888
8889 2019-06-25  Tom Tromey  <tom@tromey.com>
8890
8891         * tui/tui-wingeneral.c (make_visible): Remove check of window
8892         type.
8893
8894 2019-06-25  Tom Tromey  <tom@tromey.com>
8895
8896         * tui/tui-win.c (tui_win_info::max_height)
8897         (tui_cmd_window::max_height): New methods.
8898         (new_height_ok): Call max_height.
8899         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8900         <max_height>: New method.
8901
8902 2019-06-25  Tom Tromey  <tom@tromey.com>
8903
8904         * tui/tui-win.c (tui_source_window_base::set_new_height)
8905         (tui_data_window::set_new_height): New methods.
8906         (make_invisible_and_set_new_height): Call set_new_height method.
8907         * tui/tui-data.h (struct tui_win_info)
8908         (struct tui_source_window_base, struct tui_data_window)
8909         <set_new_height>: New method.
8910
8911 2019-06-25  Tom Tromey  <tom@tromey.com>
8912
8913         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8914         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8915         tui_refresh_data_win.
8916         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8917         method.
8918         (tui_refresh_all_win): Call the refresh_all method.
8919         (tui_set_focus): Likewise.
8920         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8921         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8922         Likewise.
8923
8924 2019-06-25  Tom Tromey  <tom@tromey.com>
8925
8926         * tui/tui-winsource.h (tui_refill_source_window)
8927         (tui_set_is_exec_point_at): Don't declare.
8928         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8929         (tui_source_window_base::refill): Rename from
8930         tui_refill_source_window.
8931         (tui_source_window_base::do_scroll_horizontal): Update.
8932         (tui_source_window_base::set_is_exec_point_at): Rename from
8933         tui_set_is_exec_point_at.
8934         (tui_update_all_breakpoint_info): Update.
8935         * tui/tui-stack.c (tui_show_frame_info): Update.
8936         * tui/tui-layout.c (show_data): Add cast.
8937         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8938         * tui/tui-data.h (struct tui_source_window_base) <refill,
8939         set_is_exec_point_at>: New methods.
8940         (tui_source_windows, tui_add_to_source_windows): Update types.
8941         (tui_add_to_source_windows): Remove redundant declaration.
8942         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8943         (tui_source_windows): Change return type.
8944         (tui_clear_source_windows_detail): Update.
8945         (tui_add_to_source_windows): Change type of parameter.
8946         (tui_free_all_source_wins_content): Update.
8947
8948 2019-06-25  Tom Tromey  <tom@tromey.com>
8949
8950         * tui/tui-wingeneral.c (tui_win_info::refresh)
8951         (tui_source_window_base::refresh): New methods.
8952         (tui_refresh_all): Call the refresh method.
8953         * tui/tui-data.h (struct tui_win_info)
8954         (struct tui_source_window_base) <refresh>: New method.
8955
8956 2019-06-25  Tom Tromey  <tom@tromey.com>
8957
8958         * tui/tui.h (tui_is_window_visible): Return bool.
8959         * tui/tui.c (tui_is_window_visible): Return bool.
8960         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8961         (tui_make_visible, tui_make_invisible)
8962         (tui_win_info::make_visible)
8963         (tui_source_window_base::make_visible, make_all_visible)
8964         (tui_make_all_visible, tui_make_all_invisible): Update.
8965         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8966         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8967         bool.
8968         (struct tui_win_info, struct tui_source_window_base)
8969         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8970         * tui/tui-data.c (tui_init_generic_part): Update.
8971
8972 2019-06-25  Tom Tromey  <tom@tromey.com>
8973
8974         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8975         (tui_source_window_base::make_visible): New methods.
8976         (make_all_visible): Make method call.
8977         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8978         (struct tui_source_window_base, struct tui_cmd_window): Override
8979         make_visible.
8980         (tui_win_is_source_type): Don't declare.
8981         * tui/tui-data.c (tui_win_is_source_type): Remove.
8982
8983 2019-06-25  Tom Tromey  <tom@tromey.com>
8984
8985         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8986         NULL check.
8987
8988 2019-06-25  Tom Tromey  <tom@tromey.com>
8989
8990         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8991         Inline constructor.  Add initializers for members.
8992         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8993         constructors; now inline in class.
8994
8995 2019-06-25  Tom Tromey  <tom@tromey.com>
8996
8997         * tui/tui-regs.c (tui_show_registers): Update.
8998         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8999         bool.
9000         * tui/tui-data.c (tui_data_window::clear_detail)
9001         (tui_data_window): Update.
9002
9003 2019-06-25  Tom Tromey  <tom@tromey.com>
9004
9005         * tui/tui-windata.c (tui_display_all_data)
9006         (tui_display_data_from_line, tui_display_data_from)
9007         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9008         Update.
9009         * tui/tui-regs.c (tui_last_regs_line_no)
9010         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9011         (tui_show_registers, tui_show_register_group)
9012         (tui_display_registers_from, tui_display_reg_element_at_line)
9013         (tui_display_registers_from_line, tui_check_register_values)
9014         (tui_reg_next, tui_reg_prev): Update.
9015         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9016         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9017         tui_data_window.
9018         (struct tui_win_info) <detail>: Remove.  Add new fields from
9019         tui_data_info.
9020         (TUI_DATA_WIN): Add cast.
9021         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9022         (~tui_data_window): Simplify.
9023
9024 2019-06-25  Tom Tromey  <tom@tromey.com>
9025
9026         * tui/tui-layout.c (show_source_disasm_command)
9027         (show_source_or_disasm_and_command): Update.
9028         * tui/tui-io.c (update_cmdwin_start_line)
9029         (tui_redisplay_readline): Update.
9030         * tui/tui-data.h (struct tui_command_info): Remove.
9031         (struct tui_win_info) <detail>: Remove command_info member.
9032         (struct tui_data_window) <start_line>: New member, from
9033         tui_command_info.
9034         (TUI_CMD_WIN): Add casts.
9035
9036 2019-06-25  Tom Tromey  <tom@tromey.com>
9037
9038         * tui/tui-winsource.c (tui_update_source_window)
9039         (tui_refill_source_window)
9040         (tui_source_window_base::do_scroll_horizontal)
9041         (tui_update_breakpoint_info, tui_set_exec_info_content)
9042         (tui_show_exec_info_content, tui_erase_exec_info_content)
9043         (tui_clear_exec_info_content): Update.
9044         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9045         Update.
9046         * tui/tui-win.c (make_invisible_and_set_new_height)
9047         (make_visible_with_new_height): Update.
9048         * tui/tui-source.c (tui_set_source_content)
9049         (tui_show_symtab_source): Update.
9050         * tui/tui-layout.c (extract_display_start_addr)
9051         (show_source_disasm_command, show_data)
9052         (make_source_or_disasm_window)
9053         (show_source_or_disasm_and_command): Update.
9054         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9055         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9056         "gdbarch".
9057         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9058         to tui_source_window_base.
9059         (struct tui_win_info) <detail>: Remove source_info member.
9060         (struct tui_source_window_base) <has_locator>: Inline.
9061         Move contents from tui_source_info; rename has_locator member to
9062         m_has_locator.
9063         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9064         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9065         header file.
9066         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9067         Simplify.
9068         (tui_free_all_source_wins_content): Cast to
9069         tui_source_window_base.
9070
9071 2019-06-25  Tom Tromey  <tom@tromey.com>
9072
9073         * tui/tui-win.c (make_invisible_and_set_new_height)
9074         (make_visible_with_new_height): Call has_locator method.
9075         * tui/tui-layout.c (show_source_disasm_command, show_data)
9076         (show_source_or_disasm_and_command): Update for bool change.
9077         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9078         (tui_win_info) <has_locator>: New method.
9079         (struct tui_source_window_base) <has_locator>: New method.
9080         (tui_win_has_locator): Don't declare.
9081         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9082         from tui_win_has_locator.
9083         (tui_source_window_base): Use false, not FALSE.
9084
9085 2019-06-25  Tom Tromey  <tom@tromey.com>
9086
9087         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9088         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9089         clear_detail method directly.
9090         (tui_clear_win_detail): Remove.
9091
9092 2019-06-25  Tom Tromey  <tom@tromey.com>
9093
9094         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9095         "this", not TUI_DISASM_WIN.
9096
9097 2019-06-25  Tom Tromey  <tom@tromey.com>
9098
9099         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9100         declare.
9101         * tui/tui-winsource.c
9102         (tui_source_window_base::do_scroll_horizontal): Rename from
9103         tui_horizontal_source_scroll.
9104         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9105         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9106         from tui_vertical_data_scroll.
9107         * tui/tui-win.h (tui_scroll): Don't declare.
9108         * tui/tui-win.c (tui_win_info::forward_scroll)
9109         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9110         (tui_win_info::right_scroll): Rename and update.
9111         (tui_scroll_forward_command, tui_scroll_backward_command)
9112         (tui_scroll_left_command, tui_scroll_right_command): Update.
9113         (tui_scroll): Remove.
9114         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9115         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9116         from tui_vertical_source_scroll.
9117         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9118         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9119         from tui_vertical_disassem_scroll.
9120         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9121         do_scroll_horizontal>: New methods.
9122         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9123         Likewise.
9124         (struct tui_source_window_base): Add do_scroll_horizontal.
9125         (struct tui_source_window, struct tui_disasm_window): Add
9126         do_scroll_vertical.
9127         (struct tui_data_window, struct tui_cmd_window): Add
9128         do_scroll_horizontal and do_scroll_vertical.
9129         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9130
9131 2019-06-25  Tom Tromey  <tom@tromey.com>
9132
9133         * tui/tui-data.h (struct tui_source_window_base): New struct.
9134         (struct tui_source_window): Derive from tui_source_window_base.
9135         (struct tui_disasm_window): New struct.
9136         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9137         from tui_source_window::clear_detail.
9138         (tui_source_window_base): Rename from tui_source_window.
9139         (~tui_source_window_base): Rename from ~tui_source_window.
9140         (tui_alloc_win_info): Create a tui_disasm_window.
9141
9142 2019-06-25  Tom Tromey  <tom@tromey.com>
9143
9144         * tui/tui-data.h (struct tui_source_window)
9145         (struct tui_data_window): Declare destructors.
9146         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9147         destructors.
9148         (tui_win_info): Simplify.
9149
9150 2019-06-25  Tom Tromey  <tom@tromey.com>
9151
9152         * tui/tui-winsource.c (tui_display_main)
9153         (tui_update_source_windows_with_addr)
9154         (tui_update_all_breakpoint_info): Update.
9155         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9156         (new_height_ok, parse_scrolling_args): Update.
9157         * tui/tui-stack.c (tui_show_frame_info): Update.
9158         * tui/tui-data.h (struct tui_list): Remove.
9159         (tui_source_windows): Return a reference to a std::vector.
9160         * tui/tui-data.c (source_windows): Now a std::vector.
9161         (tui_source_windows): Change return type.
9162         (tui_clear_source_windows): Rewrite.
9163         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9164         (tui_free_all_source_wins_content): Rewrite.
9165
9166 2019-06-25  Tom Tromey  <tom@tromey.com>
9167
9168         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9169         (struct tui_data_window, struct tui_cmd_window): Declare
9170         clear_detail method.
9171         * tui/tui-data.c (tui_source_window::clear_detail)
9172         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9173         methods.
9174         (tui_clear_win_detail): Simplify.
9175
9176 2019-06-25  Tom Tromey  <tom@tromey.com>
9177
9178         * tui/tui-layout.c (make_source_window, make_disasm_window)
9179         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9180         Return the new window.
9181         (show_source_disasm_command, show_data)
9182         (show_source_or_disasm_and_command): Update.
9183
9184 2019-06-25  Tom Tromey  <tom@tromey.com>
9185
9186         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9187         parameter.  Return the new window.
9188         (show_source_disasm_command): Update and remove NULL check.
9189         (show_source_or_disasm_and_command): Update.
9190
9191 2019-06-25  Tom Tromey  <tom@tromey.com>
9192
9193         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9194
9195 2019-06-25  Tom Tromey  <tom@tromey.com>
9196
9197         * tui/tui-data.h (struct tui_win_info): Make constructor
9198         protected.  Make destructor virtual.  Add initializers.
9199         (tui_source_window, tui_data_window, tui_cmd_window): New
9200         classes.
9201         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9202         constructor.  Add "type" parameter.
9203         (tui_source_window, tui_data_window, tui_cmd_window): New
9204         constructors.
9205         (tui_alloc_win_info): Instantiate the appropriate subclass.
9206
9207 2019-06-25  Tom Tromey  <tom@tromey.com>
9208
9209         * tui/tui-win.c (tui_resize_all): Use delete.
9210         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9211         destructor.
9212         (tui_free_window): Don't declare.
9213         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9214         Update.
9215
9216 2019-06-25  Tom Tromey  <tom@tromey.com>
9217
9218         * tui/tui-data.h (struct tui_win_info): Add constructor.
9219         * tui/tui-data.c (tui_alloc_win_info): Use new.
9220         (tui_free_window): Use delete.
9221
9222 2019-06-22  Tom Tromey  <tom@tromey.com>
9223
9224         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9225         declare.
9226         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9227
9228 2019-06-22  Tom Tromey  <tom@tromey.com>
9229
9230         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9231         declare.
9232         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9233
9234 2019-06-22  Tom de Vries  <tdevries@suse.de>
9235
9236         * dwarf2read.c (create_addrmap_from_aranges)
9237         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9238         instead of '%zu'.
9239
9240 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9241
9242         * dwarf2read.h (dwarf2_section_info_def): Remove.
9243         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9244         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9245         std::vector<dwarf2_section_info>.
9246         (struct dwo_file) <~dwo_file>: Remove.
9247         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9248         types field.
9249         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9250         (dwarf2_read_debug_names): Likewise.
9251         (create_debug_types_hash_table): Change parameter type to
9252         array_view, adjust code accordingly.
9253         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9254         (partial_die_info::fixup): Likewise.
9255         (determine_prefix): Likewise.
9256         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9257
9258 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9259
9260         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9261         gdb_bfd_ref_ptr.
9262         <~dwo_file>: Remove call to gdb_bfd_unref.
9263         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9264         gdb_bfd_ref_ptr::get.
9265
9266 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9267
9268         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9269         type to htab_up.
9270         * dwarf2read.c (struct dwo_file): Initialize fields.
9271         <~dwo_file>: New.
9272         (free_dwo_file): Remove, move content to ~dwo_file.
9273         (struct dwo_file_deleter): Remove.
9274         (dwo_file_up>: Remove custom deleter.
9275         (free_dwo_files): Remove.
9276         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9277         dwo_files.
9278         (process_skeletonless_type_units): Call unique_ptr::get.
9279         (allocate_dwo_file_hash_table): Add deleter to created hash
9280         table.  Change return type to htab_up.
9281         (lookup_dwo_file_slot): Don't memset dwo_file, call
9282         unique_ptr::get.
9283         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9284         (create_dwo_unit_in_dwp_v2): Likewise.
9285         (open_and_init_dwo_file): Likewise.
9286         (free_dwo_file_from_slot): Remove.
9287
9288 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9289
9290         * dwarf2read.h (struct dwarf2_section_info) <readin,
9291         is_virtual>: Change type to bool.
9292         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9293         true instead of 1.
9294
9295 2019-06-19  Tom Tromey  <tom@tromey.com>
9296
9297         * tui/tui-data.h (tui_init_content_element): Don't declare.
9298
9299 2019-06-19  Tom Tromey  <tom@tromey.com>
9300
9301         * tui/tui-data.h (tui_init_win_info): Don't declare.
9302
9303 2019-06-19  Tom de Vries  <tdevries@suse.de>
9304
9305         * dwarf2read.h (abstract_to_concrete): Change type to
9306         std::unordered_map<sect_offset, std::vector<sect_offset>,
9307         gdb::hash_enum<sect_offset>>.
9308
9309 2019-06-19  Tom Tromey  <tromey@adacore.com>
9310
9311         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9312         EVAL_AVOID_SIDE_EFFECTS specially.
9313
9314 2019-06-19  Tom Tromey  <tromey@adacore.com>
9315
9316         * source-cache.c (highlighter): New global.
9317         (source_cache::get_source_lines): Create a highlighter on demand.
9318
9319 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9320
9321         * defs.h (deprecated_interactive_hook): Delete declaration.
9322         * interps.c (clear_interpreter_hooks): Remove use of
9323         deprecated_interactive_hook.
9324         * top.c (deprecated_interactive_hook): Delete definition.
9325         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9326
9327 2019-06-18  Tom de Vries  <tdevries@suse.de>
9328
9329         PR gdb/24515
9330         * dwarf2read.h (abstract_to_concrete): Change type from
9331         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9332         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9333         * dwarf2read.c (read_variable): Update.
9334         (dwarf2_fetch_die_loc_sect_off): Update.
9335
9336 2019-06-17  Tom de Vries  <tdevries@suse.de>
9337
9338         PR gdb/24617
9339         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9340         accessing parent[parent_len - 1].
9341
9342 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9343
9344         PR gdb/24364
9345         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9346         call dtrace_process_dof with NULL dof.
9347
9348 2019-06-16  Tom de Vries  <tdevries@suse.de>
9349
9350         PR gdb/24445
9351         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9352
9353 2019-06-16  Tom Tromey  <tom@tromey.com>
9354
9355         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9356         (make_all_visible): Use address of member.
9357
9358 2019-06-16  Tom Tromey  <tom@tromey.com>
9359
9360         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9361         (tui_free_window, free_content, free_content_elements): Remove
9362         unnecessary cast.
9363         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9364         cast.
9365         * tui/tui-regs.c (tui_show_register_group)
9366         (tui_display_registers_from, tui_display_reg_element_at_line):
9367         Remove unnecessary cast.
9368
9369 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9370
9371         * linux-nat.c (normal_mask): Delete.
9372         (_initialize_linux_nat): Don't initialise normal_mask.
9373
9374 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9375
9376         PR gdb/24445
9377         * dwarf-index-write.h (write_psymtabs_to_index): Add
9378         dwz_basename parameter.
9379         * dwarf-index-write.c (write_gdbindex): Move file writing to
9380         write_gdbindex_1.  Change return type void.
9381         (assert_file_size): Move up, remove filename parameter.
9382         (write_gdbindex_1): New function.
9383         (write_debug_names): Change return type to void, call
9384         assert_file_size.
9385         (struct index_wip_file): New struct.
9386         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9387         file logic to index_wip_file.  Write index for dwz file if
9388         needed.
9389         (save_gdb_index_command): Pass basename of dwz file, if present.
9390         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9391         build-id of dwz file, if present.
9392         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9393         (dwarf2_get_dwz_file): Likewise.
9394         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9395         (dwarf2_get_dwz_file): Likewise.
9396
9397 2019-06-16  Tom Tromey  <tom@tromey.com>
9398
9399         * coffread.c (process_coff_symbol): Use xstrdup.
9400         * value.c (create_internalvar): Use xstrdup.
9401
9402 2019-06-16  Tom Tromey  <tom@tromey.com>
9403
9404         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9405         * breakpoint.c (stopin_command, stopat_command)
9406         (until_break_command, decode_location_default): Remove unnecessary
9407         cast.
9408         * utils.c (subset_compare): Remove unnecessary cast.
9409         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9410         cast.
9411         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9412         cast.
9413         * infcmd.c (path_command): Remove unnecessary cast.
9414         * coffread.c (decode_type): Remove unnecessary cast.
9415         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9416         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9417         * tui/tui-stack.c (tui_show_locator_content)
9418         (tui_show_frame_info): Remove unnecessary cast.
9419         * tui/tui-win.c (tui_scroll_forward_command)
9420         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9421         (parse_scrolling_args): Remove unnecessary cast.
9422         * tui/tui-data.c (init_win_info, tui_del_window)
9423         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9424         (free_content_elements): Remove unnecessary cast.
9425         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9426         unnecessary cast.
9427         * tui/tui-source.c (tui_set_source_content)
9428         (tui_vertical_source_scroll): Remove unnecessary cast.
9429         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9430         cast.
9431         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9432         * tui/tui-regs.c (tui_display_registers_from)
9433         (tui_display_register): Remove unnecessary cast.
9434         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9435         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9436         (make_visible): Remove unnecessary cast.
9437         * tui/tui-winsource.c (tui_erase_source_content)
9438         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9439         unnecessary cast.
9440         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9441         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9442         * stabsread.c (read_type, read_array_type, read_range_type):
9443         Remove unnecessary cast.
9444         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9445         (parse_symbol, parse_type, upgrade_type, parse_external)
9446         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9447         unnecessary cast.
9448         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9449
9450 2019-06-16  Tom Tromey  <tom@tromey.com>
9451
9452         * tui/tui-data.c (tui_alloc_generic_win_info)
9453         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9454         checks.
9455
9456 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9457             Andrew Burgess  <andrew.burgess@embecosm.com>
9458
9459         * f-typeprint.c (f_print_type): Don't return early for not
9460         associated or not allocated types.
9461         (f_type_print_varspec_suffix): Add print_rank parameter and print
9462         ranks of array types in case they dangling.
9463         (f_type_print_base): Add print_rank parameter.
9464
9465 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9466
9467         * NEWS: Mention new MI commands.
9468         * break-catch-throw.c (enum exception_event_kind): Move to
9469         breakpoint.h.
9470         (print_mention_exception_catchpoint): Output text as a single
9471         message.
9472         (catch_exception_command_1): Rename to...
9473         (catch_exception_event): ...this, make non-static, update header
9474         command, and change some parameter types.
9475         (catch_catch_command): Update for changes to
9476         catch_exception_command_1.
9477         (catch_throw_command): Likewise.
9478         (catch_rethrow_command): Likewise.
9479         * breakpoint.c (enum exception_event_kind): Delete.
9480         * breakpoint.h (enum exception_event_kind): Moved here from
9481         break-catch-throw.c.
9482         (catch_exception_event): Declare.
9483         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9484         (mi_cmd_catch_throw): New function.
9485         (mi_cmd_catch_rethrow): New function.
9486         (mi_cmd_catch_catch): New function.
9487         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9488         'catch-catch' entries.
9489         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9490         (mi_cmd_catch_rethrow): Declare.
9491         (mi_cmd_catch_catch): Declare.
9492
9493 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9494
9495         * annotate.c (annotate_source_line): Change return type to void,
9496         update implementation to match.
9497         * annotate.h (annotate_source_line): Change return type to void,
9498         update header comment.
9499         * stack.c (print_frame_info): Don't change what frame information
9500         is printed based on whether annotations are on or not.
9501
9502 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9503
9504         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9505         (annotate_source): Make static.
9506         (annotate_source_line): Moved from source.c and renamed from
9507         identify_source_line.  Update the return type.
9508         * annotate.h (annotate_source): Delete declaration.
9509         (annotate_source_line): Declaration moved from source.h, and
9510         renamed from identify_source_line.  Return type updated.
9511         * source.c (identify_source_line): Moved to annotate.c and renamed
9512         to annotate_source_line.
9513         (info_line_command): Remove check of annotation_level.
9514         * source.h (identify_source_line): Move declaration to annotate.h
9515         and rename to annotate_source_line.
9516         * stack.c: Add 'annotate.h' include.
9517         (print_frame_info): Remove check of annotation_level before
9518         calling annotate_source_line.
9519
9520 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9521
9522         * source-cache.c (source_cache::get_plain_source_lines): Use
9523         open_source_file_with_line_charpos instead of just
9524         open_source_file, remove call to find_source_lines.
9525         (source_cache::get_source_lines): Likewise.
9526         * source.c (find_source_lines): Make static.
9527         (get_filename_and_charpos): Renamed into...
9528         (open_source_file_with_line_charpos): ..this along with changes to
9529         return a scoped_fd, and some other minor clean ups.
9530         (identify_source_line): Use open_source_file_with_line_charpos.
9531         (search_command_helper): Use open_source_file_with_line_charpos
9532         instead of just open_source_file, remove call to
9533         find_source_lines.
9534         * source.h (open_source_file_with_line_charpos): Declare new
9535         function.
9536         (find_source_lines): Delete declaration.
9537
9538 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * source.c (get_filename_and_charpos): Remove fullname
9541         parameter.
9542         (identify_source_line): Update call to get_filename_and_charpos.
9543
9544 2019-06-14  Tom Tromey  <tromey@adacore.com>
9545
9546         PR gdb/24502:
9547         * ui-style.h (skip_ansi_escape): Update comment.
9548         * ui-file.h (class no_terminal_escape_file): New class.
9549         * ui-file.c (no_terminal_escape_file::write)
9550         (no_terminal_escape_file::puts): New methods.
9551         * cli/cli-logging.c (handle_redirections): Use
9552         no_terminal_escape_file.
9553
9554 2019-06-14  Tom Tromey  <tromey@adacore.com>
9555
9556         * NEWS: Move convenience variable news above Python news.
9557
9558 2019-06-14  Tom Tromey  <tom@tromey.com>
9559
9560         * gnulib: Move directory to top-level.
9561         * configure.ac: Don't configure gnulib.
9562         * configure: Rebuild.
9563         * common/common-defs.h: Use new path to gnulib.
9564         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9565         (GNULIB_H): Remove.
9566         (INCGNU): Look in new gnulib location.
9567         (HFILES_NO_SRCDIR): Remove gnulib files.
9568         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9569         (generated_files): Remove GNULIB_H.
9570         ($(LIBGNU), all-lib): Remove targets.
9571         (distclean): Don't mention GNULIB_BUILDDIR.
9572         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9573
9574 2019-06-14  Tom Tromey  <tromey@adacore.com>
9575
9576         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9577         Warn if symbol file does not provide any symbols.
9578
9579 2019-06-14  Tom Tromey  <tromey@adacore.com>
9580
9581         * source.c (find_and_open_source): Respect basenames_may_differ.
9582
9583 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9584
9585         * annotate.c (annotate_breakpoints_invalid): Make use of
9586         scoped_restore_terminal_state.
9587         (annotate_frames_invalid): Likewise.
9588
9589 2019-06-14  Tom Tromey  <tromey@adacore.com>
9590
9591         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9592         allow assignment to an internalvar.
9593
9594 2019-06-14  Tom Tromey  <tromey@adacore.com>
9595
9596         * ada-lex.l: Allow "_" in attribute names.
9597
9598 2019-06-14  Tom Tromey  <tromey@adacore.com>
9599
9600         PR gdb/24653:
9601         * regcache.c (registers_changed): Don't call alloca.
9602         * top.c (execute_command): Don't call alloca.
9603
9604 2019-06-13  Pedro Alves  <palves@redhat.com>
9605
9606         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9607         'expression'.  When parsing an expression, error out if there's
9608         junk after "unlimited".
9609         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9610         (do_set_command): Adjust calls to is_unlimited_literal.
9611
9612 2019-06-13  Pedro Alves  <palves@redhat.com>
9613
9614         * compile/compile.c (make_compile_options_def_group): Add braces
9615         around array_view initializer.
9616         * thread.c (make_thread_apply_all_options_def_group)
9617         (make_thread_apply_all_options_def_group): Likewise.
9618
9619 2019-06-13  Pedro Alves  <palves@redhat.com>
9620
9621         * NEWS (New commands): Mention "maint test-options
9622         require-delimiter", "maint test-options unknown-is-error", "maint
9623         test-options unknown-is-operand" and "maint show
9624         test-options-completion-result".
9625         (New command options, command completion): New section.
9626         (Completion improvements): New section.
9627         Mention that you can abbreviate "unlimited".
9628
9629 2019-06-13  Pedro Alves  <palves@redhat.com>
9630
9631         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9632         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9633         * unittests/cli-utils-selftests.c (test_parse_flags)
9634         (test_parse_flags_qcs): Delete.
9635         (test_cli_utils): Don't call deleted functions.
9636
9637 2019-06-13  Pedro Alves  <palves@redhat.com>
9638
9639         * thread.c: Include "cli/cli-option.h".
9640         (tp_array_compar_ascending): Global.
9641         (tp_array_compar): Delete function.
9642         (tp_array_compar_ascending, tp_array_compar_descending): New
9643         functions.
9644         (ascending_option_def, qcs_flag_option_def)
9645         (thr_qcs_flags_option_defs)
9646         (make_thread_apply_all_options_def_group)
9647         (make_thread_apply_options_def_group): New.
9648         (thread_apply_all_command): Use gdb::option::process_options.
9649         (thread_apply_command_completer)
9650         (thread_apply_all_command_completer): New.
9651         (thread_apply_command): Use gdb::option::process_options.
9652         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9653         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9654         to generate help text of "thread apply".  Adjust "taas"'s help.
9655         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9656         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9657
9658 2019-06-13  Pedro Alves  <palves@redhat.com>
9659
9660         * thread.c (thread_apply_command): Check for invalid TID with
9661         isdigit instead of !isalpha.
9662
9663 2019-06-13  Pedro Alves  <palves@redhat.com>
9664
9665         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9666         (validate_flags_qcs): New.
9667         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9668         (validate_flags_qcs): Declare.
9669         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9670         (make_frame_apply_options_def_group): New.
9671         (frame_apply_command_count): Process options with
9672         gdb::option::process_options.
9673         (frame_apply_completer): New.
9674         (frame_apply_level_completer, frame_apply_all_completer)
9675         (frame_apply_completer): New.
9676         (_initialize_stack): Update help of "frame apply", "frame apply
9677         level", "frame apply all" and "faas" to mention supported options
9678         and install command completers.
9679         * stack.h (frame_apply_all_completer): Declare.
9680         * thread.c: Include "stack.h".
9681         (tfaas_command): Add "--".
9682         (_initialize_thread): Update help "tfaas" to mention supported
9683         options and install command completer.
9684
9685 2019-06-13  Pedro Alves  <palves@redhat.com>
9686
9687         * completer.c (complete_nested_command_line): New.
9688         (gdb_completion_word_break_characters_throw): Add assertion.
9689         * completer.h (complete_nested_command_line): Declare.
9690
9691 2019-06-13  Pedro Alves  <palves@redhat.com>
9692
9693         * stack.c (parse_backtrace_qualifiers): New.
9694         (backtrace_command): Use it.
9695         (backtrace_command_completer): Complete on qualifiers.
9696
9697 2019-06-13  Pedro Alves  <palves@redhat.com>
9698
9699         * frame.c: Include "cli/cli-option.h.
9700         (user_set_backtrace_options): New.
9701         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9702         Delete.
9703         (get_prev_frame): Adjust.
9704         (boolean_option_def, uinteger_option_def)
9705         (set_backtrace_option_defs): New.
9706         (_initialize_frame): Adjust and use
9707         gdb::option::add_setshow_cmds_for_options to install "set
9708         backtrace past-main" and "set backtrace past-entry".
9709         * frame.h: Include "cli/cli-option.h".
9710         (struct frame_print_options): Forward declare.
9711         (print_frame_arguments_all, print_frame_arguments_scalars)
9712         (print_frame_arguments_none): Declare.
9713         (print_entry_values): Delete declaration.
9714         (struct frame_print_options, user_frame_print_options): New.
9715         (struct set_backtrace_options): New.
9716         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9717         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9718         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9719         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9720         (list_args_or_locals): Add frame_print_options parameter.
9721         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9722         * python/py-framefilter.c (enumerate_args): Pass down
9723         USER_FRAME_PRINT_OPTIONS.
9724         * stack.c: Include "cli/cli-option.h".
9725         (print_frame_arguments_all, print_frame_arguments_scalars)
9726         (print_frame_arguments_none): Declare.
9727         (print_raw_frame_arguments, print_entry_values): Delete.
9728         (user_frame_print_options): New.
9729         (boolean_option_def, enum_option_def, frame_print_option_defs):
9730         New.
9731         (struct backtrace_cmd_options): New.
9732         (bt_flag_option_def): New.
9733         (backtrace_command_option_defs): New.
9734         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9735         (print_frame_arg, read_frame_arg, print_frame_args)
9736         (print_frame_info, print_frame): Add frame_print_options parameter
9737         and use it.
9738         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9739         (backtrace_command_1): Add frame_print_options and
9740         backtrace_cmd_options parameters and use them.
9741         (make_backtrace_options_def_group): New.
9742         (backtrace_command): Process command options with
9743         gdb::option::process_options.
9744         (backtrace_command_completer): New.
9745         (_initialize_stack): Extend "backtrace"'s help to mention
9746         supported options.  Install completer for "backtrace".
9747         Install some settings commands with add_setshow_cmds_for_options.
9748
9749 2019-06-13  Pedro Alves  <palves@redhat.com>
9750
9751         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9752         and that "set/show print raw frame-arguments" are now deprecated.
9753
9754         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9755         command.
9756         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9757         * stack.c (_initialize_stack): Install "set/show print
9758         raw-frame-arguments", and deprecate "set/show print raw
9759         frame-arguments".
9760         * valprint.c (_initialize_valprint): Deprecate "set/show print
9761         raw".
9762
9763 2019-06-13  Pedro Alves  <palves@redhat.com>
9764
9765         * compile/compile.c (struct compile_options): New.
9766         (compile_flag_option_def, compile_command_option_defs)
9767         (make_compile_options_def_group): New.
9768         (compile_file_command): Handle options with
9769         gdb::option::process_options.
9770         (compile_file_command_completer): New function.
9771         (compile_code_command): Handle options with
9772         gdb::option::process_options.
9773         (compile_code_command_completer): New function.
9774         (_initialize_compiler): Install completers for "compile code" and
9775         "compile file".  Mention available options in "compile code" and
9776         "compile code"'s help.
9777         * completer.c (advance_to_completion_word): New, factored out from
9778         ...
9779         (advance_to_expression_complete_word_point): ... this.
9780         (advance_to_filename_complete_word_point): New.
9781         * completer.h (advance_to_filename_complete_word_point): New
9782         declaration.
9783
9784 2019-06-13  Pedro Alves  <palves@redhat.com>
9785
9786         * compile/compile.c: Include "cli/cli-option.h".
9787         (compile_print_value): Scope data pointer is now a
9788         value_print_options pointer; adjust.
9789         (compile_print_command): Process options.  Scope data pointer is
9790         now a value_print_options pointer; adjust.
9791         (_initialize_compile): Update "compile print"'s help to include
9792         supported options.  Install a completer for "compile print".
9793         * cp-valprint.c (show_vtblprint, show_objectprint)
9794         (show_static_field_print): Delete.
9795         (_initialize_cp_valprint): Don't install "set print
9796         static-members", "set print vtbl", "set print object" here.
9797         * printcmd.c: Include "cli/cli-option.h" and
9798         "common/gdb_optional.h".
9799         (print_command_parse_format): Rework to fill in a
9800         value_print_options instead of a format_data.
9801         (print_value): Change parameter type from format_data pointer to
9802         value_print_options reference.  Adjust.
9803         (print_command_1): Process options.  Adjust to pass down a
9804         value_print_options.
9805         (print_command_completer): New.
9806         (_initialize_printcmd): Install print_command_completer as
9807         handle_brkchars completer for the "print" command.  Update
9808         "print"'s help to include supported options.
9809         * valprint.c: Include "cli/cli-option.h".
9810         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9811         here from cp-valprint.c.
9812         (boolean_option_def, uinteger_option_def)
9813         (value_print_option_defs, make_value_print_options_def_group):
9814         New.  Use gdb::option::add_setshow_cmds_for_options to install
9815         "set print elements", "set print null-stop", "set print repeats",
9816         "set print pretty", "set print union", "set print array", "set
9817         print address", "set print symbol", "set print array-indexes".
9818         * valprint.h: Include <string> and "cli/cli-option.h".
9819         (make_value_print_options_def_group): Declare.
9820         (print_value): Change parameter type from format_data pointer to
9821         value_print_options reference.
9822         (print_command_completer): Declare.
9823
9824 2019-06-13  Pedro Alves  <palves@redhat.com>
9825
9826         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9827         (COMMON_SFILES): Add maint-test-settings.c.
9828         * cli/cli-decode.c (boolean_enums): New global, factored out from
9829         ...
9830         (add_setshow_boolean_cmd): ... here.
9831         * cli/cli-decode.h (boolean_enums): Declare.
9832         * cli/cli-option.c: New file.
9833         * cli/cli-option.h: New file.
9834         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9835         factored out from ...
9836         (parse_cli_boolean_value(const char *)): ... this.
9837         (is_unlimited_literal): Change parameter type to pointer to
9838         pointer.  Adjust and advance ARG pointer.
9839         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9840         (parse_cli_var_enum): New, factored out from ...
9841         (do_set_command): ... this.  Adjust.
9842         * cli/cli-setshow.h (parse_cli_boolean_value)
9843         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9844         (parse_cli_var_enum): Declare.
9845         * cli/cli-utils.c: Include "cli/cli-option.h".
9846         (get_ulongest): New.
9847         * cli/cli-utils.h (get_ulongest): Declare.
9848         (check_for_argument): New overloads.
9849         * maint-test-options.c: New file.
9850
9851 2019-06-13  Pedro Alves  <palves@redhat.com>
9852
9853         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9854         parse a range if "-" is at the end of the string.
9855
9856 2019-06-13  Pedro Alves  <palves@redhat.com>
9857
9858         * cli/cli-setshow.c (parse_auto_binary_operation)
9859         (parse_cli_boolean_value): Don't allow "o".
9860
9861 2019-06-13  Pedro Alves  <palves@redhat.com>
9862
9863         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9864         * NEWS: Mention maint test-settings KIND.
9865         * maint-test-settings.c: New file.
9866
9867 2019-06-13  Pedro Alves  <palves@redhat.com>
9868
9869         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9870         completer.
9871         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9872         "set" completers.
9873
9874 2019-06-13  Pedro Alves  <palves@redhat.com>
9875
9876         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9877         after item.
9878
9879 2019-06-13  Pedro Alves  <palves@redhat.com>
9880
9881         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9882
9883 2019-06-13  Pedro Alves <palves@redhat.com>
9884
9885         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9886         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9887         call.
9888         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9889         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9890         calls.
9891         (check_for_argument): Skip spaces after argument.
9892
9893 2019-06-13  Pedro Alves  <palves@redhat.com>
9894
9895         * thread.c (thread_apply_command): Adjust TID parsing.
9896         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9897         detected before end of string.
9898         (tid_is_in_list): Error out if LIST is invalid.
9899
9900 2019-06-13  Pedro Alves  <palves@redhat.com>
9901
9902         * completer.c (complete_line_internal_1): Rewind completion word
9903         point.
9904         (completion_tracker::advance_custom_word_point_by): Change
9905         parameter type to int.
9906         * completer.h (completion_tracker::advance_custom_word_point_by):
9907         Likewise.
9908
9909 2019-06-13  Pedro Alves  <palves@redhat.com>
9910
9911         * completer.c (advance_to_completion_word): Handle delimiters.
9912
9913 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9914
9915         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9916
9917 2019-06-11  Tom Tromey  <tom@tromey.com>
9918
9919         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9920         (xmalloc_failed): Move to alloc.c.
9921         * alloc.c: New file.
9922         * Makefile.in (COMMON_SFILES): Add alloc.c.
9923
9924 2019-06-11  Tom Tromey  <tom@tromey.com>
9925
9926         * nat/linux-waitpid.c: Don't include server.h.
9927         (linux_debug): Remove.
9928         (my_waitpid): Update.
9929
9930 2019-06-11  Tom Tromey  <tromey@adacore.com>
9931
9932         * infcall.c (_initialize_infcall): Remove trailing newline from
9933         help.
9934         * user-regs.c (_initialize_user_regs): Remove trailing newline
9935         from help.
9936         * typeprint.c (_initialize_typeprint): Remove trailing newline
9937         from help.
9938         * reverse.c (_initialize_reverse): Remove trailing newlines from
9939         help.
9940         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9941         from help.
9942         * language.c (add_set_language_command): Remove trailing newline
9943         from help.
9944         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9945         help.
9946         * disasm.c (_initialize_disasm): Remove trailing newline from
9947         help.
9948         * top.c (init_main): Remove trailing newline from help.
9949         * interps.c (_initialize_interpreter): Remove trailing newline
9950         from help.
9951         * btrace.c (_initialize_btrace): Remove trailing newlines from
9952         help.
9953         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9954         from help.
9955         * python/python.c (_initialize_python): Remove trailing newline
9956         from help.
9957         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9958         help.
9959         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9960         from help.  Reformat some text.
9961         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9962         from help.
9963         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9964         newline from help.
9965
9966 2019-06-11  Tom Tromey  <tromey@adacore.com>
9967
9968         * darwin-nat.c (darwin_decode_exception_message)
9969         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9970
9971 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9972
9973         * valops.c (value_slice): Check for not allocated or not
9974         associated values.
9975
9976 2019-06-10  Tom de Vries  <tdevries@suse.de>
9977
9978         PR gdb/24618
9979         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9980         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9981         invalid.
9982
9983 2019-06-10  Tom de Vries  <tdevries@suse.de>
9984
9985         PR gdb/24611
9986         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9987         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9988
9989 2019-06-10  Tom de Vries  <tdevries@suse.de>
9990
9991         PR symtab/24545
9992         * symtab.c (struct demangled_name_entry): Add language field.
9993         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9994         static minimal symbol".  Set and use language field.
9995
9996 2019-06-10  Tom Tromey  <tromey@adacore.com>
9997
9998         * ada-lang.c (_initialize_ada_language): Update help text.
9999
10000 2019-06-10  Tom Tromey  <tromey@adacore.com>
10001
10002         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10003         with a newline.
10004         * guile/guile.c (handle_boot_error): Don't end warning with a
10005         newline.
10006         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10007         warning with a newline.
10008         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10009         newline.
10010         (s12z_frame_cache): Likewise.
10011         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10012         a newline.
10013         * solib-svr4.c (disable_probes_interface): Don't end warning with
10014         a newline.
10015         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10016         newline.
10017         * python/python.c (do_finish_initialization): Don't end warning
10018         with a newline.
10019
10020 2019-06-10  Tom Tromey  <tom@tromey.com>
10021
10022         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10023         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10024         gdbpy_enter.
10025
10026 2019-06-10  Tom Tromey  <tromey@adacore.com>
10027
10028         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10029         data.
10030         (elf_new_init): Don't call stabsread_new_init.
10031         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10032         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10033         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10034
10035 2019-06-10  Tom de Vries  <tdevries@suse.de>
10036
10037         PR symtab/16264
10038         PR symtab/24517
10039         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10040
10041 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10042
10043         * source.c (find_and_open_source): Also rewrite relative file
10044         names.
10045
10046 2019-04-26  Amos Bird  <amosbird@gmail.com>
10047
10048         * annotate.c (annotate_thread_exited): Add "thread-exited"
10049         annotation.
10050
10051 2019-06-06  Tom Tromey  <tromey@adacore.com>
10052
10053         * maint.h (class scoped_command_stats): Use
10054         DISABLE_COPY_AND_ASSIGN.
10055         <print_time>: New method.
10056         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10057         print_time.
10058         (scoped_command_stats::print_time): New method.
10059
10060 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10061
10062         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10063         instructions of lengths 6 or 8 bytes.
10064
10065 2019-06-04  Pedro Alves  <palves@redhat.com>
10066
10067         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10068
10069         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10070         * breakpoint.c (condition_completer): Likewise.
10071         * cli/cli-dump.c (scan_expression): Likewise.
10072         * common/filestuff.c (mkdir_recursive): Likewise.
10073         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10074         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10075         (gdb_abspath): Likewise.
10076         * compile/compile-cplus-types.c
10077         (compile_cplus_instance::decl_name): Likewise.
10078         * completer.c (complete_explicit_location):
10079         (signal_completer, reg_or_group_completer_1): Likewise.
10080         * cp-support.c (cp_remove_params_if_any): Likewise.
10081         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10082         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10083         * infcmd.c (strip_bg_char): Likewise.
10084         * linespec.c (copy_token_string): Likewise.
10085         * mi/mi-main.c (output_cores): Likewise.
10086         * psymtab.c (psymtab_search_name):
10087         * symfile.c (test_set_ext_lang_command): Likewise.
10088         * target.c (target_fileio_read_stralloc): Likewise.
10089         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10090         * value.c (complete_internalvar): Likewise.
10091
10092 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10093
10094         Add objfile property to gdb.Type.
10095         * NEWS: Mention Python API addition.
10096         * python/py-type.c (typy_get_objfile): New method.
10097
10098 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10099
10100         * NEWS: Mention the new set|show style [title|highlight].
10101         Mention changes to "show style", "help" and "apropos".
10102
10103 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10104
10105         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10106         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10107         instead of print_help_for_command.
10108         (print_doc_of_command): New function.
10109         (help_list): Add 'apropos -v word' suggestion.
10110         (print_help_for_command): Style the command name using title style.
10111         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10112         (_initialize_cli_cmds): Describe -v in apropos_command help.
10113
10114 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10115
10116         * cli/cli-style.h (cli_style_option): Add name in constructor,
10117         add m_name class member, add constructor with intensity,
10118         add name class function.
10119         (cli_style_option::add_setshow_commands): Remove name argument.
10120         (highlight_style, title_style): New styles.
10121         * cli/cli-style.c (do_show): New function that shows a style
10122         characteristic styling the style name with itself.
10123         (set_style_name): New function.
10124         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10125         Update all callers according to the changes in cli/cli-style.h.
10126         * utils.h (fputs_highlighted): New function.
10127         * utils.c (fputs_highlighted): Likewise.
10128
10129 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10130
10131         * NEWS: Mention new pipe command and new convenience variables.
10132
10133 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10134
10135         * cli/cli-cmds.c (pipe_command): New function.
10136         (_initialize_cli_cmds): Call add_com for pipe_command.
10137         Define | as an alias for pipe.
10138         (exit_status_set_internal_vars): New function.
10139         (shell_escape): Call exit_status_set_internal_vars.
10140         cli/cli-decode.c (find_command_name_length): Recognize | as
10141         a single character command.
10142
10143 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10144
10145         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10146         top.c (execute_command_to_ui_file): New function, mostly a copy
10147         of execute_command_to_string.
10148         (execute_command_to_string): Implement by calling
10149         execute_command_to_ui_file.
10150
10151 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10152
10153         * top.h (saved_command_line): Remove declaration.
10154         * top.c (previous_saved_command_line, previous_repeat_arguments):
10155         New variables.
10156         (saved_command_line): Make static, define together with other
10157         'repeat variables'.
10158         (dont_repeat): Clear repeat_arguments.
10159         (repeat_previous, get_saved_command_line, save_command_line):
10160         New functions.
10161         (gdb_init): Initialize saved_command_line
10162         and previous_saved_command_line.
10163         * main.c (captured_main_1): Remove saved_command_line initialization.
10164         * event-top.c (handle_line_of_input): Update to use
10165         the new 'repeat' related functions instead of direct access to
10166         saved_command_line.
10167         * command.h (repeat_previous, get_saved_command_line,
10168         save_command_line): New declarations.
10169         (dont_repeat): Add comment.
10170
10171 2019-05-30  Tom Tromey  <tromey@adacore.com>
10172
10173         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10174         Fix comment.
10175         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10176
10177 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10178
10179         PR cli/24587
10180         * completer.c (complete): Initialize variable word.
10181
10182 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10183
10184         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10185         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10186         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10187         'body' is NULL to the outter 'if', protecting the '!is_define'
10188         situation as well.
10189
10190 2019-05-29  Tom Tromey  <tromey@adacore.com>
10191
10192         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10193         (dwarf_unknown): New function.
10194         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10195         (dwarf_type_encoding_name): Use dwarf_unknown.
10196
10197 2019-05-29  Tom Tromey  <tromey@adacore.com>
10198
10199         PR c++/20020:
10200         * cp-valprint.c (cp_print_value_fields): Call
10201         cp_print_static_field inside "try".
10202
10203 2019-05-29  Tom Tromey  <tromey@adacore.com>
10204
10205         * inflow.c (struct terminal_info): Add default operator=.
10206         * configure: Rebuild.
10207         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10208         -Wdeprecated-copy-dtor, -Wredundant-move.
10209
10210 2019-05-29  Tom Tromey  <tromey@adacore.com>
10211
10212         * NEWS: Add entry.
10213         * infcmd.c (print_return_value_1): Handle finish_print
10214         option.
10215         (show_print_finish): New function.
10216         (_initialize_infcmd): Add "set/show print finish" commands.
10217         * valprint.c (user_print_options): Initialize new member.
10218         * valprint.h (struct value_print_options) <finish_print>: New
10219         member.
10220
10221 2019-05-28  Tom Tromey  <tromey@adacore.com>
10222
10223         * ada-lang.c (ada_remove_Xbn_suffix)
10224         (find_old_style_renaming_symbol)
10225         (parse_old_style_renaming): Remove.
10226         (ada_find_renaming_symbol): Don't call
10227         find_old_style_renaming_symbol.
10228         (ada_is_renaming_symbol): Rename from
10229         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10230         bool.  Now static.
10231         (ada_read_var_value): Update and simplify.
10232         * ada-exp.y (write_var_or_type): Remove old code.
10233
10234 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10235
10236         PR gdb/25010
10237         * event-top.c: Remove include comment.
10238         * inflow.c (class scoped_ignore_sigttou): Move from here...
10239         * inflow.h (class scoped_ignore_sigttou): ...to here.
10240         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10241         * top.c:  Remove include comment.
10242
10243 2019-05-27  Tom Tromey  <tom@tromey.com>
10244
10245         * NEWS: Fix typo.
10246
10247 2019-05-22  Tom Tromey  <tromey@adacore.com>
10248
10249         * target.c (target_follow_exec): Constify parameter.
10250         * target-delegates.c: Rebuild.
10251         * remote.c (remote_target::follow_exec): Constify parameter.
10252         * infrun.c (follow_exec): Constify parameter.
10253         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10254         (target_follow_exec): Likewise.
10255
10256 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10257
10258         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10259         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10260
10261 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10262
10263         * NEWS: Add debugredirect and testsuite sections.
10264
10265 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10266
10267         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10268         target descriptions using exclusively floating point register name
10269         aliases.
10270
10271 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         PR gdb/18644:
10274         * f-lang.c (build_fortran_types): Handle the case where
10275         gdbarch_floatformat_for_type returns a nullptr.
10276
10277 2019-05-21  Tom de Vries  <tdevries@suse.de>
10278
10279         PR cli/24587
10280         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10281
10282 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10283
10284         PR gdb/18644:
10285         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10286         16-byte floats.
10287         * i386-tdep.c (i386_floatformat_for_type): Use
10288         floatformats_ia64_quad for the 16-byte floating point component
10289         within a fortran 32-byte complex number.
10290
10291 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10292
10293         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10294         delete default constructor.
10295         (find_partial_die): Update to return const struct.
10296         (partial_die_parent_scope): Move variable declaration into scope
10297         of its use and change its type to auto.
10298         (guess_partial_die_structure_name): Likewise.
10299         (partial_die_info::fixup): Likewise.
10300
10301 2019-05-17  Tom Tromey  <tromey@adacore.com>
10302
10303         * source.c (find_and_open_source): Remove cast.
10304
10305 2019-05-17  Tom Tromey  <tromey@adacore.com>
10306
10307         * annotate.c (annotate_source): Make "filename" const.
10308         * annotate.h (annotate_source): Use const.
10309
10310 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10311
10312         * disasm.c (set_disassembler_options): Send errors to stderr.
10313
10314 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10315
10316         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10317         (cli_interp_base::set_logging): Check debug_redirect.
10318         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10319         * cli/cli-logging.c (debug_redirect): Add static variable.
10320         (pop_output_files): Add default param.
10321         (handle_redirections): Print debug setting.
10322         (show_logging_command): Likewise.
10323         (_initialize_cli_logging): Add debugredirect command.
10324         * interps.c (current_interp_set_logging): Add debug_redirect
10325         parameter.
10326         * interps.h (set_logging): Add debug_redirect parameter.
10327         (current_interp_set_logging): Likewise.
10328         * mi/mi-common.h: Likewise.
10329         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10330
10331 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10332             Tom Tromey  <tromey@adacore.com>
10333
10334         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10335         directly.
10336         * cli/cli-interp.h (make_logging_output): Remove declaration.
10337         * cli/cli-logging.c (make_logging_output): Remove function.
10338         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10339         directly.
10340         * ui-file.c (tee_file::tee_file): Remove bools.
10341         (tee_file::~tee_file): Remove deletes.
10342         * ui-file.h (tee_file): Remove bools.
10343
10344 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10345
10346         * mi/mi-cmds.h (mi_cmd_complete): New function.
10347         * mi/mi-main.c (mi_cmd_complete): Likewise.
10348         * mi/mi-cmds.c: Define new MI command -complete.
10349         * NEWS: Mention new -complete command.
10350
10351 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10352
10353         * completer.h (complete): New function.
10354         * completer.c (complete): Likewise.
10355         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10356         function defined in completer.h.
10357
10358 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10359
10360         * MAINTAINERS (Write After Approval): Add myself.
10361
10362 2019-05-17  Tom de Vries  <tdevries@suse.de>
10363
10364         PR gdb/24094
10365         * dwarf2read.c (struct cu_partial_die_info): New struct.
10366         (find_partial_die): Return cu_partial_die_info.
10367         (partial_die_parent_scope, guess_partial_die_structure_name)
10368         (partial_die_info::fixup): Handle new return type of find_partial_die.
10369
10370 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10371
10372         PR breakpoints/24541
10373         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10374         "std::string", simplifying the algorithm.
10375
10376 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10377
10378         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10379         (stap_static_probe_ops::get_probes): Likewise.
10380
10381 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10382
10383         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10384         '-')" and "else if".
10385         (stap_parse_single_operand): Join checks for
10386         "gdbarch_stap_parse_special_token_p" and
10387         "gdbarch_stap_parse_special_token" in the same "if" statement.
10388         Invert check when verifying for operation on register
10389         displacement.
10390
10391 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10392
10393         * stap-probe.c (stap_get_opcode): Update comment.
10394         (stap_get_expected_argument_type): Likewise.
10395         (handle_stap_probe): Likewise.
10396
10397 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10398
10399         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10400         return type to 'bool'.  Adjust comment.  Use 'bool' when
10401         appropriate.
10402         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10403         * stap-probe.c (stap_parse_argument_1): Likewise.
10404         (stap_is_operator): Likewise.
10405         (stap_is_generic_prefix): Likewise.
10406         (stap_is_register_prefix): Likewise.
10407         (stap_is_register_indirection_prefix): Likewise.
10408         (stap_is_integer_prefix): Likewise.
10409         (stap_generic_check_suffix): Likewise.
10410         (stap_check_integer_suffix): Likewise.
10411         (stap_check_register_suffix): Likewise.
10412         (stap_check_register_indirection_suffix): Likewise.
10413         (stap_parse_register_operand): Likewise.
10414         (stap_parse_single_operand): Likewise.
10415         (stap_parse_argument_1): Likewise.
10416         (stap_probe::get_argument_count): Likewise.
10417         (stap_is_operator): Likewise.
10418
10419 2019-05-16  Tom Tromey  <tromey@adacore.com>
10420
10421         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10422         keyword to foreach.
10423
10424 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10425
10426         * linux-thread-db.c (try_thread_db_load_1): Change return type
10427         to bool.
10428         (try_thread_db_load): Likewise.
10429         (try_thread_db_load_from_pdir_1): Likewise.
10430         (try_thread_db_load_from_pdir): Likewise.
10431         (try_thread_db_load_from_sdir): Likewise.
10432         (try_thread_db_load_from_dir): Likewise.
10433         (thread_db_load_search): Likewise.
10434         (has_libpthread): Likewise.
10435         (thread_db_load): Likewise.
10436
10437 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10438
10439         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10440         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10441         NULL, and complain/return if that's the case.
10442
10443 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10444
10445         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10446         (advance, posn, abstract_read_memory): New functions.
10447         [struct mem_read_abstraction]: New struct.
10448         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10449
10450 2019-05-14  Tom Tromey  <tromey@adacore.com>
10451
10452         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10453         value is not lval_memory.
10454
10455 2019-05-14  Tom Tromey  <tromey@adacore.com>
10456
10457         * solib.c (info_sharedlibrary_command): Style the file name.
10458
10459 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10460
10461         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10462         (aarch64_vnv_type): Likewise.
10463         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10464         * common/tdesc.c: Likewise.
10465         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10466         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10467         * features/aarch64-fpu.xml: Add ieee half view.
10468         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10469         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10470         * gdbtypes.h (struct builtin_type): Likewise.
10471         (struct objfile_type): Likewise.
10472
10473 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10474
10475         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10476         typo.
10477         * location.h (string_to_event_location): Likewise.
10478
10479 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10480
10481         GDB 8.3 released.
10482
10483 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10484
10485         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10486         New variable declaration.
10487         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10488         New variable.
10489         (print_one_breakpoint): Use ui_out::test_flags and new global
10490         variable to compute use_fixed_output.
10491         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10492         Remove.
10493         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10494         (mi_multi_location_breakpoint_output_fixed): Remove.
10495         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10496         new variable.
10497         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10498         fix_multi_location_breakpoint_output flag if version >= 3.
10499         * ui-out.h (enum ui_out_flag)
10500         <fix_multi_location_breakpoint_output>: New enumerator.
10501
10502 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10503
10504         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10505
10506 2019-05-10  Tom Tromey  <tromey@adacore.com>
10507
10508         * ada-lang.c (catch_ada_completer): New function.
10509         (_initialize_ada_language): Use it.
10510
10511 2019-05-10  Tom Tromey  <tromey@adacore.com>
10512
10513         * thread.c (print_thread_info): Make "requested_threads" const.
10514         * gdbthread.h (print_thread_info): Make "requested_threads"
10515         const.
10516         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10517         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10518
10519 2019-05-08  Tom Tromey  <tom@tromey.com>
10520
10521         * gdbtypes.c (objfile_type_data): Change type.
10522         (objfile_type, _initialize_gdbtypes): Update.
10523
10524 2019-05-08  Tom Tromey  <tom@tromey.com>
10525
10526         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10527         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10528         (_initialize_dwarf2_frame): Update.
10529
10530 2019-05-08  Tom Tromey  <tom@tromey.com>
10531
10532         * objc-lang.c (objc_objfile_data): Change type.
10533         (find_methods): Update.
10534         (_initialize_objc_lang): Remove.
10535
10536 2019-05-08  Tom Tromey  <tom@tromey.com>
10537
10538         * stabsread.c (rs6000_builtin_type_data): Change type.
10539         (rs6000_builtin_type, _initialize_stabsread): Update.
10540
10541 2019-05-08  Tom Tromey  <tom@tromey.com>
10542
10543         * mips-tdep.c (mips_pdr_data): Remove.
10544         (_initialize_mips_tdep): Update.
10545
10546 2019-05-08  Tom Tromey  <tom@tromey.com>
10547
10548         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10549         (hppa_init_objfile_priv_data, read_unwind_info)
10550         (find_unwind_entry, _initialize_hppa_tdep): Update.
10551
10552 2019-05-08  Tom Tromey  <tom@tromey.com>
10553
10554         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10555         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10556         on obstack.
10557         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10558
10559 2019-05-08  Tom Tromey  <tom@tromey.com>
10560
10561         * mdebugread.c (basic_type_data): Change type.
10562         (basic_type, _initialize_mdebugread): Update.
10563
10564 2019-05-08  Tom Tromey  <tom@tromey.com>
10565
10566         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10567
10568 2019-05-08  Tom Tromey  <tom@tromey.com>
10569
10570         * nto-tdep.c (nto_inferior_data_reg): Change type.
10571         (nto_inferior_data): Update.
10572         (nto_inferior_data_cleanup, nto_new_inferior_data)
10573         (_initialize_nto_tdep): Remove.
10574         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10575
10576 2019-05-08  Tom Tromey  <tom@tromey.com>
10577
10578         * ada-lang.c (struct ada_inferior_data): Add initializers.
10579         (ada_inferior_data): Change type.
10580         (ada_inferior_data_cleanup): Remove.
10581         (get_ada_inferior_data, ada_inferior_exit)
10582         (struct ada_pspace_data): Add initializers, destructor.
10583         (ada_pspace_data_handle): Change type.
10584         (get_ada_pspace_data): Update.
10585         (ada_pspace_data_cleanup): Remove.
10586
10587 2019-05-08  Tom Tromey  <tom@tromey.com>
10588
10589         * coffread.c (struct coff_symfile_info): Add initializers.
10590         (coff_objfile_data_key): Move lower.  Change type.
10591         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10592         Update.
10593         (coff_free_info): Remove.
10594
10595 2019-05-08  Tom Tromey  <tom@tromey.com>
10596
10597         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10598         (fbsd_pspace_data_handle): Move lower.  Change type.
10599         (get_fbsd_pspace_data): Update.
10600         (fbsd_pspace_data_cleanup): Remove.
10601         (_initialize_fbsd_tdep): Update.
10602
10603 2019-05-08  Tom Tromey  <tom@tromey.com>
10604
10605         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10606         (get_ada_tasks_pspace_data): Update.
10607         (ada_tasks_pspace_data_cleanup): Remove.
10608         (_initialize_tasks): Update.
10609         (ada_tasks_inferior_data_handle): Change type.
10610         (get_ada_tasks_inferior_data): Update.
10611         (ada_tasks_inferior_data_cleanup): Remove.
10612         (struct ada_tasks_pspace_data): Add initializers.
10613
10614 2019-05-08  Tom Tromey  <tom@tromey.com>
10615
10616         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10617         * symfile-debug.c (debug_sym_get_probes): Change type.
10618         * stap-probe.c (handle_stap_probe):
10619         (stap_static_probe_ops::get_probes): Change type.
10620         * probe.h (class static_probe_ops) <get_probes>: Change type.
10621         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10622         (parse_probes_in_pspace): Update.
10623         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10624         Update.
10625         (any_static_probe_ops::get_probes): Change type.
10626         * elfread.c (elfread_data): New typedef.
10627         (probe_key): Change type.
10628         (elf_get_probes): Likewise.  Update.
10629         (probe_key_free): Remove.
10630         (_initialize_elfread): Update.
10631         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10632         Change type.
10633         (dtrace_process_dof_probe, dtrace_process_dof)
10634         (dtrace_static_probe_ops::get_probe): Change type.
10635
10636 2019-05-08  Tom Tromey  <tom@tromey.com>
10637
10638         * xcoffread.c (struct xcoff_symfile_info): Rename from
10639         coff_symfile_info.  Add initializers.
10640         (xcoff_objfile_data_key): Move lower.  Change type.
10641         (XCOFF_DATA): Rewrite.
10642         (xcoff_free_info): Remove.
10643         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10644         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10645         (xcoff_initial_scan): Update.
10646
10647 2019-05-08  Tom Tromey  <tom@tromey.com>
10648
10649         * solib-svr4.c (struct svr4_info): Add initializers and
10650         destructor.
10651         <probes_table>: Now an htab_up.
10652         (solib_svr4_pspace_data): Change type.
10653         (free_probes_table): Simplify.
10654         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10655         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10656         (probes_table_remove_objfile_probes, register_solib_event_probe)
10657         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10658         (_initialize_svr4_solib): Update.
10659
10660 2019-05-08  Tom Tromey  <tom@tromey.com>
10661
10662         * remote.c (remote_pspace_data): Change type.
10663         (remote_pspace_data_cleanup): Remove.
10664         (get_remote_exec_file, set_pspace_remote_exec_file)
10665         (_initialize_remote): Update.
10666
10667 2019-05-08  Tom Tromey  <tom@tromey.com>
10668
10669         * breakpoint.c (breakpoint_objfile_key): Change type.
10670         (get_breakpoint_objfile_data): Update.
10671         (free_breakpoint_objfile_data): Remove.
10672         (_initialize_breakpoint): Update.
10673
10674 2019-05-08  Tom Tromey  <tom@tromey.com>
10675
10676         * linux-tdep.c (struct linux_info): Add initializers.
10677         (linux_inferior_data): Move.  Change type.
10678         (invalidate_linux_cache_inf): Update.
10679         (linux_inferior_data_cleanup): Remove.
10680         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10681
10682 2019-05-08  Tom Tromey  <tom@tromey.com>
10683
10684         * auxv.c (auxv_inferior_data): Move.  Change type.
10685         (auxv_inferior_data_cleanup): Remove.
10686         (invalidate_auxv_cache_inf): Rewrite.
10687         (get_auxv_inferior_data, _initialize_auxv): Update.
10688
10689 2019-05-08  Tom Tromey  <tom@tromey.com>
10690
10691         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10692         (symfile_debug_objfile_data_key): Change type.
10693         (symfile_debug_installed, debug_qf_has_symbols)
10694         (debug_qf_find_last_source_symtab)
10695         (debug_qf_forget_cached_source_info)
10696         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10697         (debug_qf_print_stats, debug_qf_dump)
10698         (debug_qf_expand_symtabs_for_function)
10699         (debug_qf_expand_all_symtabs)
10700         (debug_qf_expand_symtabs_with_fullname)
10701         (debug_qf_map_matching_symbols)
10702         (debug_qf_expand_symtabs_matching)
10703         (debug_qf_find_pc_sect_compunit_symtab)
10704         (debug_qf_map_symbol_filenames)
10705         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10706         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10707         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10708         (debug_sym_read_linetable, debug_sym_relocate): Update.
10709         (symfile_debug_free_objfile): Remove.
10710         (install_symfile_debug_logging, _initialize_symfile_debug):
10711         Update.
10712
10713 2019-05-08  Tom Tromey  <tom@tromey.com>
10714
10715         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10716         allocate_on_obstack.
10717         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10718         (get_dwarf2_per_objfile): Update.
10719         (set_dwarf2_per_objfile): Remove.
10720         (dwarf2_has_info, dwarf2_get_section_info): Update.
10721         (dwarf2_free_objfile): Remove.
10722         (_initialize_dwarf2_read): Update.
10723
10724 2019-05-08  Tom Tromey  <tom@tromey.com>
10725
10726         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10727         initializers.
10728         <unsupported_script_warning_printed,
10729         script_not_found_warning_printed>: Now bool.
10730         (auto_load_pspace_data): Change type.
10731         (~auto_load_pspace_info): Rename from
10732         auto_load_pspace_data_cleanup.
10733         (get_auto_load_pspace_data, init_loaded_scripts_info)
10734         (clear_section_scripts, maybe_print_unsupported_script_warning)
10735         (maybe_print_script_not_found_warning, _initialize_auto_load):
10736         Update.
10737
10738 2019-05-08  Tom Tromey  <tom@tromey.com>
10739
10740         * objfiles.c (objfile_pspace_info): Add destructor and
10741         initializers.
10742         (objfiles_pspace_data): Change type.
10743         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10744         (get_objfile_pspace_data): Update.
10745         (objfiles_bfd_data): Change type.
10746         (get_objfile_bfd_data): Update.
10747         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10748
10749 2019-05-08  Tom Tromey  <tom@tromey.com>
10750
10751         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10752         Change type.
10753         (get_catch_syscall_inferior_data): Update.
10754         (catch_syscall_inferior_data_cleanup): Remove.
10755         (_initialize_break_catch_syscall): Update.
10756
10757 2019-05-08  Tom Tromey  <tom@tromey.com>
10758
10759         * inflow.c (struct terminal_info): Add destructor and
10760         initializers.
10761         (inflow_inferior_data): Change type.
10762         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10763         (get_inflow_inferior_data, inflow_inferior_exit)
10764         (swap_terminal_info, _initialize_inflow): Update.
10765
10766 2019-05-08  Tom Tromey  <tom@tromey.com>
10767
10768         * target-dcache.c (target_dcache_cleanup): Remove.
10769         (target_dcache_aspace_key): Change type.
10770         (target_dcache_init_p, target_dcache_invalidate)
10771         (target_dcache_get, target_dcache_get_or_init)
10772         (_initialize_target_dcache): Update.
10773         * dcache.h (struct dcache_deleter): New.
10774
10775 2019-05-08  Tom Tromey  <tom@tromey.com>
10776
10777         * symtab.c (struct symbol_cache): Add destructor and
10778         initializers.
10779         (symbol_cache_key): Move.  Change type.
10780         (make_symbol_cache, free_symbol_cache): Remove.
10781         (get_symbol_cache): Update.
10782         (symbol_cache_cleanup): Remove.
10783         (ALL_PSPACES, symbol_cache_flush)
10784         (maintenance_print_symbol_cache)
10785         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10786         Update.
10787
10788 2019-05-08  Tom Tromey  <tom@tromey.com>
10789
10790         * symtab.c (struct main_info): Add destructor and initializers.
10791         (main_progspace_key): Move.  Change type.
10792         (get_main_info): Update.
10793         (main_info_cleanup): Remove.
10794         (_initialize_symtab): Update.
10795
10796 2019-05-08  Tom Tromey  <tom@tromey.com>
10797
10798         * registry.h (DECLARE_REGISTRY): Define the _key class.
10799
10800 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10801
10802         * NEWS: Merge two 'New commands' sections.
10803
10804 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10805
10806         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10807         parameter and use Ada language definition instead.
10808         (ada_val_print_ptr): Remove unused language parameter.
10809         (ada_val_print_num): Remove language parameter and use Ada language
10810         definition instead.
10811         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10812         parameter.
10813         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10814         parameter and use Ada language definition instead.
10815         (ada_val_print_1): Update all ada_val_print_xxx calls.
10816         Remove language parameter.
10817         (ada_val_print): Update ada_val_print_1 call.
10818
10819 2019-05-08  Tom Tromey  <tromey@adacore.com>
10820
10821         * remote.c (remote_hw_watchpoint_limit)
10822         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10823         Now static.
10824
10825 2019-05-08  Tom Tromey  <tromey@adacore.com>
10826
10827         * maint.c (_initialize_maint_cmds): Move initialization code to
10828         remote.c.
10829         (watchdog, show_watchdog): Move to remote.c.
10830         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10831         "watchdog" static.
10832         (_initialize_remote): Move initialization code from maint.c.
10833         * defs.h (watchdog): Don't declare.
10834
10835 2019-05-08  Tom Tromey  <tromey@adacore.com>
10836
10837         * tui/tui-interp.c: Include main.h.
10838         * interps.c: Include main.h.
10839         * main.h (interpreter_p): Declare.
10840         * defs.h (interpreter_p): Don't declare.
10841
10842 2019-05-08  Tom Tromey  <tromey@adacore.com>
10843
10844         * dwarf2loc.c: Include dwarf2read.h.
10845         * defs.h (read_unsigned_leb128): Don't declare.
10846         * dwarf2read.h (read_unsigned_leb128): Declare.
10847
10848 2019-05-08  Tom Tromey  <tromey@adacore.com>
10849
10850         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10851         method.
10852
10853 2019-05-08  Tom Tromey  <tromey@adacore.com>
10854
10855         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10856         when no wrap column is set.
10857
10858 2019-05-08  Tom Tromey  <tromey@adacore.com>
10859
10860         * c-lang.c (c_get_string): Handle non-C-style arrays.
10861
10862 2019-05-08  Tom Tromey  <tromey@adacore.com>
10863
10864         * typeprint.c (print_offset_data::update): Print the bit offset,
10865         not the number of bits remaining.
10866
10867 2019-05-08  Tom Tromey  <tromey@adacore.com>
10868
10869         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10870         padding at end of comment.
10871
10872 2019-05-08  Tom Tromey  <tromey@adacore.com>
10873
10874         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10875         Compare main types.
10876
10877 2019-05-06  Tom Tromey  <tom@tromey.com>
10878
10879         * common/scoped_mmap.c: Include common-defs.h.
10880         * common/scoped_mmap.h: Don't include config.h.
10881
10882 2019-05-04  Tom Tromey  <tom@tromey.com>
10883
10884         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10885         (struct aarch64_call_info): Add initializers.
10886         <si>: Now a std::vector.
10887         (pass_on_stack, aarch64_push_dummy_call): Update.
10888
10889 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10890             Tom Tromey  <tom@tromey.com>
10891
10892         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10893         (ppc_threads): Now a std::vector.  Now static.
10894         (hwdebug_find_thread_points_by_tid)
10895         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10896         Update.
10897
10898 2019-05-04  Tom Tromey  <tom@tromey.com>
10899
10900         * arc-tdep.c (arc_tdesc_init): Return bool.
10901
10902 2019-05-04  Tom Tromey  <tom@tromey.com>
10903
10904         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10905         Use gdb_assert_not_reached.
10906
10907 2019-05-04  Tom Tromey  <tom@tromey.com>
10908
10909         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10910         "false".
10911
10912 2019-05-04  Tom Tromey  <tom@tromey.com>
10913
10914         * arc-tdep.c (arc_tdesc_init): Use bool.
10915
10916 2019-05-04  Tom Tromey  <tom@tromey.com>
10917
10918         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10919
10920 2019-05-04  Tom Tromey  <tom@tromey.com>
10921
10922         * cli/cli-cmds.c (valid_command_p): Return bool.
10923
10924 2019-05-04  Tom Tromey  <tom@tromey.com>
10925
10926         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10927         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10928
10929 2019-05-04  Raul Tambre  <raul@tambre.ee>
10930
10931         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10932         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10933         operator for comparison.
10934
10935 2019-05-04  Tom Tromey  <tom@tromey.com>
10936
10937         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10938         (lookup_partial_symbol, print_partial_symbols)
10939         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10940         (psymbol_compare): Update.
10941         (add_psymbol_to_bcache): Clear the entire psymbol.
10942         (maintenance_check_psymtabs): Update.
10943         * psympriv.h (struct partial_symbol): Don't derive from
10944         general_symbol_info.
10945         <obj_section, unrelocated_address, address,
10946         set_unrelocated_address>: Update.
10947         <ginfo>: New member.
10948         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10949         (debug_names::write_psymbols): Update.
10950
10951 2019-05-04  Tom de Vries  <tdevries@suse.de>
10952
10953         * contrib/cc-with-tweaks.sh: Support -n arg.
10954
10955 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10956
10957         * corelow.c (core_target::detach): Ensure frame cache and
10958         register caches are cleared.
10959         inferior.c (exit_inferior_1): Likewise.
10960
10961 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10962             Tom Tromey  <tom@tromey.com>
10963
10964         * dictionary.c (collate_pending_symbols_by_language): Remove
10965         "struct" from foreach.
10966         * symtab.c (lookup_global_symbol_from_objfile)
10967         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10968         foreach.
10969         * ser-tcp.c (net_open): Remove "struct" from foreach.
10970         * objfiles.c (objfile_relocate, objfile_rebase)
10971         (objfile_has_symbols): Remove "struct" from foreach.
10972         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10973         from foreach.
10974         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10975         foreach.
10976         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10977         "struct" from foreach.
10978         * ada-lang.c (create_excep_cond_exprs)
10979         (ada_exception_catchpoint_cond_string): Remove "struct" from
10980         foreach.
10981
10982 2019-05-03  Tom Tromey  <tromey@adacore.com>
10983
10984         * ada-exp.y (convert_char_literal): Check suffix of each
10985         enumerator.
10986
10987 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10988
10989         PR ada/21406:
10990         * ada-exp.y (yywrap): Don't define.
10991         * ada-lex.l (%option): Add noyywrap
10992         (yywrap): Remove.
10993
10994 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10995
10996         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10997         _WIN32_WINNT to the XP level, unless already defined to a higher
10998         level.
10999
11000         * unittests/parse-connection-spec-selftests.c:
11001         * ser-tcp.c:
11002         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11003         override.
11004
11005         * symfile.c (find_separate_debug_file): Remove colon from the
11006         drive spec of DOS/Windows file names of the target, so that the
11007         file name produced from DEBUGDIR and the target's directory will
11008         be valid on DOS/Windows systems.
11009
11010 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11011
11012         * rust-lang.c (val_print_struct): Handle printing structures
11013         containing strings.
11014
11015 2019-05-02  Tom Tromey  <tromey@adacore.com>
11016
11017         * valarith.c (_initialize_valarith): Remove.
11018
11019 2019-05-01  Tom Tromey  <tromey@adacore.com>
11020
11021         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11022         bitfields.
11023
11024 2019-05-01  Tom Tromey  <tromey@adacore.com>
11025
11026         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11027         for big-endian copies.
11028
11029 2019-04-30  Ali Tamur  <tamur@google.com>
11030         * gdb/dwarf2read.c (read_3_bytes): New declaration.
11031         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11032         (read_3_bytes): New function.
11033
11034 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11035
11036         * windows-nat.c (main_thread_id): Delete.
11037         (handle_output_debug_string): Replace main_thread_id by
11038         current_event.dwThreadId.
11039         (fake_create_process): Likewise.
11040         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11041         Do not set main_thread_id.
11042         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11043         current_event.dwThreadId.
11044         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11045
11046 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11047
11048         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11049         Use current_event.dwThreadId instead of main_thread_id.
11050
11051 2019-04-30  Tom Tromey  <tromey@adacore.com>
11052
11053         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11054         (create_excep_cond_exprs): Iterate over program spaces.
11055         (ada_exception_catchpoint_cond_string): Examine all minimal
11056         symbols for exception types.
11057
11058 2019-04-30  Tom Tromey  <tromey@adacore.com>
11059
11060         PR c++/24470:
11061         * dwarf2read.c (process_structure_scope): Handle case where type
11062         has template parameters but no symbol was created.
11063
11064 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11065             Chris January  <chris.january@arm.com>
11066
11067         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11068         qualifier.
11069         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11070
11071 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11072
11073         * f-typeprint.c (f_print_type): Update rules for printing
11074         whitespace.
11075         (f_type_print_varspec_suffix): Likewise.
11076
11077 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11078             Chris January  <chris.january@arm.com>
11079
11080         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11081         function arguments.
11082
11083 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11084
11085         * f-lang.c (build_fortran_types): Change name of void type to
11086         lower case.
11087         * f-typeprint.c (f_type_print_base): Print the name of the void
11088         type, rather than a fixed string.
11089         * f-valprint.c (f_decorations): Use lower case void string.
11090
11091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11092             Chris January  <chris.january@arm.com>
11093
11094         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11095         types for Fortran.
11096
11097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11098             Chris January  <chris.january@arm.com>
11099             David Lecomber  <david.lecomber@arm.com>
11100
11101         * f-exp.y (BINOP_INTRINSIC): New token.
11102         (exp): New parser rule handling BINOP_INTRINSIC.
11103         (f77_keywords): Add new builtin procedures.
11104         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11105         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11106         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11107         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11108         (print_unop_subexp_f): New function.
11109         (print_binop_subexp_f): New function.
11110         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11111         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11112         (dump_subexp_body_f): Likewise.
11113         (operator_check_f): Likewise.
11114         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11115         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11116
11117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11118
11119         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11120         UNOP_KIND.
11121         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11122         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11123         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11124         (operator_length_f): New fuction.
11125         (print_subexp_f): New function.
11126         (op_name_f): New function.
11127         (dump_subexp_body_f): New function.
11128         (operator_check_f): New function.
11129         (exp_descriptor_f): Replace standard expression handling functions
11130         with new functions.
11131         * gdb/fortran-operator.def: New file.
11132         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11133         * gdb/std-operator.def: Remove UNOP_KIND.
11134
11135 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11136
11137         * std-operator.def: Remove unbalanced, stray double quote
11138         character.
11139
11140 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11141             Chris January  <chris.january@arm.com>
11142             Daniel Everett  <daniel.everett@arm.com>
11143             Nick Forrington  <nick.forrington@arm.com>
11144             Richard Bunt  <richard.bunt@arm.com>
11145
11146         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11147         of depth when printing anonymous structs or unions.
11148         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11149         Don't print either the top-level value, or the children if the
11150         max-depth is exceeded.
11151         (ppscm_print_children): When printing the key of a map, allow one
11152         extra level of depth.
11153         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11154         print either the top-level value, or the children if the max-depth
11155         is exceeded.
11156         (print_children): When printing the key of a map, allow one extra
11157         level of depth.
11158         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11159         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11160         (user_print_options): Initialise max_depth field.
11161         (val_print_scalar_or_string_type_p): New function.
11162         (val_print): Check to see if the max depth has been reached.
11163         (val_print_check_max_depth): Define new function.
11164         (show_print_max_depth): New function.
11165         (_initialize_valprint): Add 'print max-depth' option.
11166         * valprint.h (struct value_print_options) <max_depth>: New field.
11167         (val_print_check_max_depth): Declare new function.
11168         * NEWS: Document new feature.
11169
11170 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * ada-lang.c (ada_language_defn): Initialise new field.
11173         * c-lang.c (c_is_string_type_p): New function.
11174         (c_language_defn): Initialise new field.
11175         (cplus_language_defn): Initialise new field.
11176         (asm_language_defn): Initialise new field.
11177         (minimal_language_defn): Initialise new field.
11178         * c-lang.h (c_is_string_type_p): Declare new function.
11179         * d-lang.c (d_language_defn): Initialise new field.
11180         * f-lang.c (f_is_string_type_p): New function.
11181         (f_language_defn): Initialise new field.
11182         * go-lang.c (go_is_string_type_p): New function.
11183         (go_language_defn): Initialise new field.
11184         * language.c (default_is_string_type_p): New function.
11185         (unknown_language_defn): Initialise new field.
11186         (auto_language_defn): Initialise new field.
11187         * language.h (struct language_defn) <la_is_string_type_p>: New
11188         member variable.
11189         (default_is_string_type_p): Declare new function.
11190         * m2-lang.c (m2_language_defn): Initialise new field.
11191         * objc-lang.c (objc_language_defn): Initialise new field.
11192         * opencl-lang.c (opencl_language_defn): Initialise new field.
11193         * p-lang.c (pascal_is_string_type_p): New function.
11194         (pascal_language_defn): Initialise new field.
11195         * rust-lang.c (rust_is_string_type_p): New function.
11196         (rust_language_defn): Initialise new field.
11197
11198 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11199
11200         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11201         New field.
11202         * ada-lang.c (ada_language_defn): Initialise new field.
11203         * c-lang.c (c_language_defn): Likewise.
11204         (cplus_language_defn): Likewise.
11205         (asm_language_defn): Likewise.
11206         (minimal_language_defn): Likewise.
11207         * d-lang.c (d_language_defn): Likewise.
11208         * f-lang.c (f_language_defn): Likewise.
11209         * go-lang.c (go_language_defn): Likewise.
11210         * language.c (unknown_language_defn): Likewise.
11211         (auto_language_defn): Likewise.
11212         * m2-lang.c (m2_language_defn): Likewise.
11213         * objc-lang.c (objc_language_defn): Likewise.
11214         * opencl-lang.c (opencl_language_defn): Likewise.
11215         * p-lang.c (pascal_language_defn): Likewise.
11216         * rust-lang.c (rust_language_defn): Likewise.
11217
11218 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * ada-lang.c (ada_is_character_type): Change return type to bool.
11221         (ada_is_string_type): Likewise.
11222         * ada-lang.h (ada_is_character_type): Update declaration
11223         (ada_is_string_type): Likewise.
11224
11225 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11226
11227         Support style in 'frame|thread apply'
11228
11229         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11230         * record.c (record_start, record_stop): Update callers of
11231         execute_command_to_string with false.
11232         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11233         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11234         methods.
11235         (class string_file): New constructor with term_out parameter.
11236         Override methods term_out and can_emit_style_escape.  New member
11237         term_out.
11238         (class stdio_file): Override can_emit_style_escape.
11239         (class tee_file): Override term_out and can_emit_style_escape.
11240         * utils.h (can_emit_style_escape): Remove.
11241         * utils.c (can_emit_style_escape): Likewise.
11242         Update all callers of can_emit_style_escape (SOMESTREAM) to
11243         SOMESTREAM->can_emit_style_escape.
11244         * source-cache.c (source_cache::get_source_lines): Likewise.
11245         * stack.c (frame_apply_command_count): Call execute_command_to_string
11246         passing the term_out characteristic of the current gdb_stdout.
11247         * thread.c (thr_try_catch_cmd): Likewise.
11248         * top.c (execute_command_to_string): pass term_out parameter
11249         to construct the string_file for the command output.
11250         * ui-file.c (term_cli_styling): New function (most code moved
11251         from utils.c can_emit_style_escape).
11252         (string_file::string_file, string_file::can_emit_style_escape,
11253         stdio_file::can_emit_style_escape, tee_file::term_out,
11254         tee_file::can_emit_style_escape): New functions.
11255
11256 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11257
11258         * NEWS: Mention the new set|show may-call-functions.
11259         * infcall.c (may_call_functions_p): New variable.
11260         (show_may_call_functions_p): New function.
11261         (call_function_by_hand_dummy): Throws an error if not
11262         may-call-functions.
11263         (_initialize_infcall): Call add_setshow_boolean_cmd for
11264         may-call-functions.
11265
11266 2019-04-25  Keith Seitz  <keiths@redhat.com>
11267
11268         PR c++/24367
11269         * cp-support.c (inspect_type): Don't attempt substitutions
11270         of symbol with the same name.
11271
11272 2019-04-25  Tom Tromey  <tromey@adacore.com>
11273
11274         PR gdb/24475:
11275         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11276         static.
11277
11278 2019-04-25  Tom Tromey  <tromey@adacore.com>
11279
11280         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11281         rvalue reference.
11282         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11283         (gdb_xml_parser::parse): Use std::move.
11284         * python/python-internal.h (gdbpy_convert_exception): Take a const
11285         reference.
11286         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11287         std::move.
11288         * python/py-utils.c (gdbpy_convert_exception): Take a const
11289         reference.
11290         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11291         Use std::move.
11292         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11293         Use std::move.
11294         * mi/mi-main.c (mi_print_exception): Take a const reference.
11295         * main.c (handle_command_errors): Take a const reference.
11296         * linespec.c (parse_linespec): Use std::move.
11297         * infcall.c (run_inferior_call): Use std::move.
11298         (call_function_by_hand_dummy): Use std::move.
11299         * exec.c (try_open_exec_file): Use std::move.
11300         * exceptions.h (exception_print, exception_fprintf)
11301         (exception_print_same): Update.
11302         * exceptions.c (print_exception, exception_print)
11303         (exception_fprintf, exception_print_same): Change parameters to
11304         const reference.
11305         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11306         * common/new-op.c: Use std::move.
11307         * common/common-exceptions.h (struct gdb_exception): Add move
11308         constructor.
11309         (struct gdb_exception_error, struct gdb_exception_quit, struct
11310         gdb_quit_bad_alloc): Change constructor to move constructor.
11311         (throw_exception): Change parameter to rvalue reference.
11312         * common/common-exceptions.c (throw_exception): Take rvalue
11313         reference.
11314         * cli/cli-interp.c (safe_execute_command): Use std::move.
11315         * breakpoint.c (insert_bp_location, location_to_sals): Use
11316         std::move.
11317
11318 2019-04-25  Tom Tromey  <tromey@adacore.com>
11319
11320         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11321         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11322         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11323         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11324         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11325         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11326         guile/scm-value.c: Use unpack.
11327         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11328         gdbscm_gdb_exception.
11329         (gdbscm_throw_gdb_exception): Likewise.
11330         (struct gdbscm_gdb_exception): New.
11331         (unpack): New function.
11332         (gdbscm_wrap): Use unpack.
11333
11334 2019-04-25  Tom Tromey  <tromey@adacore.com>
11335
11336         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11337         (gdb_rl_callback_handler): Use std::move.
11338         * common/common-exceptions.h (struct gdb_exception): Add move
11339         assignment operator.
11340         (throw_exception_sjlj): Change "exception" to const reference.
11341         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11342         (throw_exception_sjlj): Change "exception" to const reference.
11343
11344 2019-04-25  Tom Tromey  <tromey@adacore.com>
11345
11346         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11347         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11348         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11349         Update.
11350         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11351         Update.
11352         * mi/mi-interp.c (mi_interp::exec): Update.
11353         * linespec.c (parse_linespec): Update.
11354         * infcall.c (run_inferior_call): Update.
11355         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11356         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11357         (gdbscm_lookup_global_symbol): Update.
11358         * guile/scm-param.c (gdbscm_parameter_value): Update.
11359         * guile/scm-frame.c (gdbscm_frame_read_register)
11360         (gdbscm_frame_read_var): Update.
11361         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11362         * exec.c (try_open_exec_file): Update.
11363         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11364         (gdb_rl_callback_handler): Update.
11365         * common/common-exceptions.h (exception_none): Don't declare.
11366         * common/common-exceptions.c (exception_none): Don't define.
11367         (struct catcher) <exception>: Update.
11368         * cli/cli-interp.c (safe_execute_command): Update.
11369         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11370
11371 2019-04-25  Ali Tamur  <tamur@google.com>
11372
11373         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11374         (read_attribute_value): Likewise.
11375         (dwarf2_read_addr_index): Update comment.
11376         (read_str_index): Add DW_FORM_strx.
11377         (dwarf2_string_attr): Likewise.
11378         (dwarf2_const_value_attr): Likewise.
11379         (dump_die_shallow): Likewise.
11380         (dwarf2_fetch_constant_bytes): Likewise.
11381         (skip_form_bytes): Likewise.
11382         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11383
11384 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11385
11386         PR corefiles/11608
11387         PR corefiles/18187
11388         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11389         OFFSET.  Verify if current mapping contains an ELF header.
11390         (linux_find_memory_regions_full): Adjust call to
11391         dump_mapping_p.
11392
11393 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11394             Kang Li <kanglictf@gmail.com>
11395
11396         PR gdb/21600
11397
11398         * dwarf2-frame.c (read_initial_length): Be consistent about using
11399         unsigned representation of length.
11400         (decode_frame_entry_1): Likewise.  Check for wraparound of
11401         end pointer as well as buffer overflow.
11402
11403 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11404
11405         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11406         "vq".
11407
11408 2019-04-24  Tom Tromey  <tromey@adacore.com>
11409
11410         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11411
11412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * s12z-tdep.c (s12z_unwind_pc): Delete.
11415         (s12z_unwind_sp): Delete.
11416         (s12z_gdbarch_init): Don't register deleted functions with
11417         gdbarch.
11418
11419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11420
11421         * rl78-tdep.c (rl78_unwind_sp): Delete.
11422         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11423
11424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11425
11426         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11427         (xstormy16_unwind_pc): Delete.
11428         (xstormy16_dummy_id): Delete.
11429         (xstormy16_gdbarch_init): Don't register deleted functions with
11430         gdbarch.
11431
11432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * vax-tdep.c (vax_unwind_pc): Delete.
11435         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11436
11437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * v850-tdep.c (v850_unwind_sp): Delete.
11440         (v850_unwind_pc): Delete.
11441         (v850_dummy_id): Delete.
11442         (v850_gdbarch_init): Don't register deleted functions with
11443         gdbarch.
11444
11445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11448         (tilegx_unwind_pc): Delete.
11449         (tilegx_unwind_dummy_id): Delete.
11450         (tilegx_gdbarch_init): Don't register deleted functions with
11451         gdbarch.
11452
11453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11454
11455         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11456         (tic6x_dummy_id): Delete.
11457         (tic6x_gdbarch_init): Don't register deleted functions with
11458         gdbarch.
11459
11460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11461
11462         * sparc-tdep.c (sparc_unwind_pc): Delete.
11463         (sparc32_gdbarch_init): Don't register deleted function with
11464         gdbarch.
11465
11466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11467
11468         * sh-tdep.c (sh_unwind_sp): Delete.
11469         (sh_unwind_pc): Delete.
11470         (sh_dummy_id): Delete.
11471         (sh_gdbarch_init): Don't register deleted functions with
11472         gdbarch.
11473
11474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11475
11476         * score-tdep.c (score_unwind_sp): Delete.
11477         (score_unwind_pc): Delete.
11478         (score_dummy_id): Delete.
11479         (score_gdbarch_init): Don't register deleted functions with
11480         gdbarch.
11481
11482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * rx-tdep.c (rx_unwind_pc): Delete.
11485         (rx_unwind_sp): Delete.
11486         (rx_dummy_id): Delete.
11487         (rx_gdbarch_init): Don't register deleted functions with
11488         gdbarch.  Update comment.
11489
11490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11491
11492         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11493         (rs6000_dummy_id): Delete.
11494         (rs6000_gdbarch_init): Don't register deleted functions with
11495         gdbarch.
11496
11497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11498
11499         * or1k-tdep.c (or1k_dummy_id): Delete.
11500         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11501
11502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11503
11504         * nios2-tdep.c (nios2_dummy_id): Delete.
11505         (nios2_unwind_sp): Delete.
11506         (nios2_gdbarch_init): Don't register deleted functions with
11507         gdbarch.
11508
11509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11510
11511         * nds32-tdep.c (nds32_dummy_id): Delete.
11512         (nds32_unwind_pc): Delete.
11513         (nds32_unwind_sp): Delete.
11514         (nds32_gdbarch_init): Don't register deleted functions with
11515         gdbarch.
11516
11517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11518
11519         * msp430-tdep.c (msp430_unwind_pc): Delete.
11520         (msp430_unwind_sp): Delete.
11521         (msp430_dummy_id): Delete.
11522         (msp430_gdbarch_init): Don't register deleted functions with
11523         gdbarch.
11524
11525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11526
11527         * moxie-tdep.c (moxie_unwind_sp): Delete.
11528         (moxie_unwind_pc): Delete.
11529         (moxie_dummy_id): Delete.
11530         (moxie_gdbarch_init): Don't register deleted functions with
11531         gdbarch.
11532
11533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11534
11535         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11536         (mn10300_unwind_pc): Delete.
11537         (mn10300_unwind_sp): Delete.
11538         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11539         mn10300_unwind_sp.
11540         (mn10300_frame_unwind_init): Don't register deleted functions with
11541         gdbarch.
11542
11543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11544
11545         * mep-tdep.c (mep_unwind_pc): Delete.
11546         (mep_unwind_sp): Delete.
11547         (mep_dummy_id): Delete.
11548         (mep_gdbarch_init): Don't register deleted functions with
11549         gdbarch.
11550
11551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11552
11553         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11554         (m68hc11_unwind_sp): Delete.
11555         (m68hc11_gdbarch_init): Don't register deleted functions with
11556         gdbarch.
11557
11558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * m32r-tdep.c (m32r_unwind_sp): Delete.
11561         (m32r_unwind_pc): Delete.
11562         (m32r_dummy_id): Delete.
11563         (m32r_gdbarch_init): Don't register deleted functions with
11564         gdbarch.
11565
11566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11567
11568         * m32c-tdep.c (m32c_unwind_pc): Delete.
11569         (m32c_unwind_sp): Delete.
11570         (m32c_dummy_id): Delete.
11571         (m32c_gdbarch_init): Don't register deleted functions with
11572         gdbarch.
11573
11574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11577         (lm32_unwind_pc): Delete.
11578         (lm32_dummy_id): Delete.
11579         (lm32_gdbarch_init): Don't register deleted functions with
11580         gdbarch.
11581
11582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11583
11584         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11585         (iq2000_unwind_pc): Delete.
11586         (iq2000_dummy_id): Delete.
11587         (iq2000_gdbarch_init): Don't register deleted functions with
11588         gdbarch.
11589
11590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11591
11592         * nds32-tdep.c (nds32_type_align): Delete.
11593         (nds32_push_dummy_call): Use type_align instead.
11594
11595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11596
11597         * arm-tdep.c (arm_type_align): Only handle vector override case.
11598         (arm_push_dummy_call): Use type_align.
11599         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11600
11601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11602
11603         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11604         case.
11605         (pass_on_stack): Use type_align.
11606         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11607         function.
11608
11609 2019-04-23  Tom Tromey  <tromey@adacore.com>
11610
11611         * dwarf2read.c (line_header::file_name_at): Remove unused
11612         overload.
11613
11614 2019-04-23  Tom de Vries  <tdevries@suse.de>
11615
11616         PR gdb/24438
11617         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11618         invocation.
11619
11620
11621 2019-03-27  Ali Tamur  <tamur@google.com>
11622
11623         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11624         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11625         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11626         (dwarf_expr_context::get_addr_index): Likewise
11627         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11628         (symbol_needs_eval_context::get_addr_index): Likewise
11629         (disassemble_dwarf_expression): Add DW_OP_addrx
11630         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11631         (read_cutu_die_from_dwo): Update comment
11632         (skip_one_die): Add DW_FORM_addrx
11633         (read_attribute_value): Likewise
11634         (var_decode_location): Add DW_OP_addrx
11635         (dwarf2_const_value_attr): Add DW_FORM_addrx
11636         (dump_die_shallow): Likewise
11637         (dwarf2_fetch_constant_bytes): Likewise
11638         (decode_locdesc): Add DW_OP_addrx
11639         (skip_form_bytes): Add DW_FORM_addrx
11640
11641 2019-04-22  Ali Tamur  <tamur@google.com>
11642
11643         * MAINTAINERS (Write After Approval): Add self.
11644
11645 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11646
11647         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11648         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11649         (open_symbol_file_object): Likewise.
11650         (svr4_default_sos): Add info parameter.
11651         (svr4_read_so_list): Likewise.
11652         (svr4_current_sos_direct): Adjust functions calls to pass down
11653         info.
11654         (svr4_current_sos_1): Add info parameter.
11655         (svr4_current_sos): Call get_svr4_info, pass info down to
11656         svr4_current_sos_1.
11657         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11658         get_svr4_info.
11659         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11660         get_svr4_info.
11661         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11662         to get_svr4_info.
11663         (probes_table_remove_objfile_probes): Likewise.
11664         (register_solib_event_probe): Add info parameter.
11665         (solist_update_incremental): Pass info parameter down to
11666         svr4_read_so_list.
11667         (disable_probes_interface): Add info parameter.
11668         (svr4_handle_solib_event): Pass current_program_space to
11669         get_svr4_info.  Adjust disable_probes_interface cleanup.
11670         (svr4_create_probe_breakpoints): Add info parameter, pass it
11671         down to register_solib_event_probe.
11672         (svr4_create_solib_event_breakpoints): Add info parameter,
11673         pass it down to svr4_create_probe_breakpoints.
11674         (enable_break): Pass info down to
11675         svr4_create_solib_event_breakpoints.
11676         (svr4_solib_create_inferior_hook): Pass current_program_space to
11677         get_svr4_info.
11678         (svr4_clear_solib): Likewise.
11679
11680 2019-04-22  Pedro Alves  <palves@redhat.com>
11681
11682         * solib-svr4.c (svr4_free_objfile_observer): New.
11683         (probe_and_action::objfile): New field.
11684         (probes_table_htab_remove_objfile_probes)
11685         (probes_table_remove_objfile_probes): New functions.
11686         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11687         in the new probe_and_action.  Don't store the probe in 'lookup'.
11688         (svr4_create_probe_breakpoints): Pass objfile to
11689         register_solib_event_probe.
11690         (_initialize_svr4_solib): Register a free_objfile observer.
11691
11692 2019-04-19  Tom Tromey  <tom@tromey.com>
11693
11694         * common/queue.h: Remove.
11695
11696 2019-04-19  Tom Tromey  <tom@tromey.com>
11697
11698         * event-loop.c: Don't include "common/queue.h".
11699
11700 2019-04-19  Tom Tromey  <tom@tromey.com>
11701
11702         * remote.c (remote_target): Use delete.
11703         * remote-notif.h: Include <list>, not "common/queue.h".
11704         (notif_client_p): Remove typedef.
11705         (remote_notif_state): Add constructor, destructor, initializer.
11706         <notif_queue>: Now a std::list.
11707         (remote_notif_state_xfree): Don't declare.
11708         * remote-notif.c (remote_notif_process, handle_notification)
11709         (remote_notif_state_allocate): Update.
11710         (~remote_notif_state): Rename from remote_notif_state_xfree.
11711
11712 2019-04-19  Tom Tromey  <tom@tromey.com>
11713
11714         * symfile.c (reread_symbols): Update.
11715         * objfiles.c (objfile_register_static_link)
11716         (objfile_lookup_static_link): Update
11717         (~objfile) Don't delete static_links.
11718         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11719
11720 2019-04-19  Tom Tromey  <tom@tromey.com>
11721
11722         * type-stack.h (struct type_stack) <insert>: Constify string.
11723         * type-stack.c (type_stack::insert): Constify string.
11724         * gdbtypes.h (lookup_template_type): Update.
11725         (address_space_name_to_int): Update.
11726         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11727         const.
11728         (lookup_template_type): Make name const.
11729         * c-exp.y: Update rules.
11730         (lex_one_token, classify_name, classify_inner_name)
11731         (c_print_token): Update.
11732         * p-exp.y: Update rules.
11733         (yylex): Update.
11734         * f-exp.y: Update rules.
11735         (yylex): Update.
11736         * d-exp.y: Update rules.
11737         (lex_one_token, classify_name, classify_inner_name): Update.
11738         * parse.c (write_dollar_variable, copy_name): Return std::string.
11739         * parser-defs.h (copy_name): Change return type.
11740         * m2-exp.y: Update rules.
11741         (yylex): Update.
11742         * go-exp.y (lex_one_token): Update.
11743         Update rules.
11744         (classify_unsafe_function, classify_packaged_name)
11745         (classify_name, yylex): Update.
11746
11747 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11748
11749         * configure.ac: add --enable-source-highlight switch.
11750         * configure: Regenerate.
11751         * top.c (print_gdb_version): plumb --enable-source-highlight
11752         status to "show configuration".
11753
11754 2019-04-19  Tom Tromey  <tromey@adacore.com>
11755
11756         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11757         Check ADA_TYPE_P.
11758         (empty_record, ada_template_to_fixed_record_type_1)
11759         (template_to_static_fixed_type)
11760         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11761         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11762         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11763         macros.
11764
11765 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11766
11767         PR symtab/24423:
11768         * source.c (print_source_lines_base): Advance "iter" when a
11769         control character is seen.
11770
11771 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11772
11773         * inferior.h (struct infcall_suspend_state_deleter):
11774         Catch exception in destructor to avoid crash.
11775
11776 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11777
11778         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11779         close to the add_com "shell".
11780
11781 2019-04-18  Tom Tromey  <tromey@adacore.com>
11782
11783         * process-stratum-target.h (class process_stratum_target)
11784         <stratum>: Add "final".
11785
11786 2019-04-17  Tom Tromey  <tromey@adacore.com>
11787
11788         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11789         against nullptr before use.
11790
11791 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11792
11793         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11794
11795 2019-04-17  Jim Wilson  <jimw@sifive.com>
11796             Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11799         code read might fail, assume 4-byte breakpoint in that case.
11800
11801 2019-04-15  Leszek Swirski  <leszeks@google.com>
11802
11803         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11804         rather than a hand-rolled POD check when checking for forced MEMORY
11805         classification.
11806
11807 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11808
11809         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11810         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11811         function.
11812         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11813         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11814         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11815         declaration.
11816
11817 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11818
11819         * aarch64-linux-nat.c
11820         (aarch64_linux_nat_target::thread_architecture): Add override.
11821         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11822         each VQ.
11823
11824 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11825
11826         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11827
11828 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11829
11830         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11831         target types of size 96-bits, add some additional comments, and
11832         check that the builtin type we found was the correct size.
11833
11834 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11835
11836         * utils.c (prompt_for_continue): Don't restore the styling at the
11837         end, as applied_style has the wrong value.  This fixes styling in
11838         long lists of file names that are interrupted by the "Continue?"
11839         prompt.
11840
11841 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11844         * c-lang.c (c_language_defn): Likewise.
11845         (cplus_language_defn): Likewise.
11846         (asm_language_defn): Likewise.
11847         (minimal_language_defn): Likewise.
11848         * d-lang.c (d_language_defn): Likewise.
11849         * f-lang.c (f_language_defn): Likewise.
11850         * go-lang.c (go_language_defn): Likewise.
11851         * language.c (unknown_language_defn): Likewise.
11852         (auto_language_defn): Likewise.
11853         * language.h (struct language_defn): Remove la_magic field.
11854         (LANG_MAGIC): Delete.
11855         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11856         * objc-lang.c (objc_language_defn): Likewise.
11857         * opencl-lang.c (opencl_language_defn): Likewise.
11858         * p-lang.c (pascal_language_defn): Likewise.
11859         * rust-lang.c (rust_language_defn): Likewise.
11860
11861 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11862
11863         * riscv-tdep.c (riscv_type_align): New function.
11864         (riscv_type_alignment): Delete.
11865         (riscv_arg_location): Use 'type_align'.
11866         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11867
11868 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11869
11870         * gdbtypes.c (type_align): A struct with no non-static fields also
11871         has alignment of 1.
11872
11873 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11874
11875         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11876         component to 0.
11877         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11878         member.
11879         (riscv_struct_info::analyse): New implementation using new
11880         analyse_inner member function.
11881         (riscv_struct_info::field_offset): New member function.
11882         (riscv_struct_info::m_offsets): New member variable.
11883         (riscv_struct_info::analyse_inner): New private member function,
11884         takes the old implementation of riscv_struct_info::analyse but
11885         extended to track field offsets.
11886         (riscv_call_arg_struct): Update the struct folding special cases
11887         to handle cases where empty C++ structs, which are non-zero
11888         length, are found.
11889         (riscv_arg_location): Initialise the length of each location, a
11890         non-zero length now indicates the location is in use.
11891         (riscv_push_dummy_call): Allow for the first location having a
11892         non-zero offset when setting up arguments.
11893         (riscv_return_value): Likewise, but for return values.
11894
11895 2019-04-11  Tom Tromey  <tromey@adacore.com>
11896
11897         * utils.c (internal_vproblem): Make "msg" const.
11898
11899 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11900
11901         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11902         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11903         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11904         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11905
11906 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11907
11908         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11909         function.
11910         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11911         of amd64_collect_native_gregset.
11912         (amd64_linux_nat_target::store_registers): Likewise.
11913
11914 2019-04-10  Tom Tromey  <tom@tromey.com>
11915
11916         * symtab.c (lookup_global_symbol_from_objfile)
11917         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11918         * objfiles.h (class separate_debug_iterator): New.
11919         (class separate_debug_range): New.
11920         (struct objfile) <separate_debug_objfiles>: New method.
11921         (objfile_separate_debug_iterate): Don't declare.
11922         * objfiles.c (separate_debug_iterator::operator++): Rename from
11923         objfile_separate_debug_iterate.
11924         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11925         iterator.
11926         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11927         iterator.
11928
11929 2019-04-10  Tom Tromey  <tom@tromey.com>
11930
11931         * symfile.c (reread_symbols): Remove old comment.
11932         * objfiles.c (free_all_objfiles): Fix a typo.
11933
11934 2019-04-10  Tom Tromey  <tom@tromey.com>
11935
11936         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11937         * minsyms.c (lookup_minimal_symbol): Use foreach.
11938         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11939         (lookup_minimal_symbol_solib_trampoline): Likewise.
11940         * symfile.c (reread_symbols): Use foreach.
11941
11942 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11943             Tom Tromey  <tromey@adacore.com>
11944
11945         PR rust/24414:
11946         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11947         (rust_lex_int_test): Change "value" to be LONGEST.
11948         (rust_lex_tests): Add test for long integer literal.
11949
11950 2019-04-09  Tom Tromey  <tromey@adacore.com>
11951
11952         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11953         to bool.
11954         (extended_remote_target::attach): Update.
11955         (remote_target::remote_notice_new_inferior): Update.
11956         (remote_target::add_current_inferior_and_thread): Update.
11957         * inferior.c (exit_inferior_1): Use "false".
11958         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11959
11960 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11961
11962         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11963         the "start" command.
11964
11965 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11966
11967         * python/py-inferior.c (infpy_thread_from_thread_handle):
11968         Adjust comments to reflect renaming of thread_from_thread_handle
11969         to thread_from_handle.  Adjust keywords.  Fix type error message.
11970         (inferior_object_methods): Add thread_from_handle.  Retain
11971         thread_from_thread_handle, but mark it as deprecated.
11972
11973 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11974
11975         * gdbthread.h (find_thread_by_handle): Revise declaration.
11976         * thread.c (find_thread_by_handle): Likewise.  Adjust
11977         implementation too.
11978         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11979         support for buffer objects as handles.
11980
11981 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11982
11983         * python/py-infthread.c (thpy_thread_handle): New function.
11984         (thread_object_methods): Register thpy_thread_handle.
11985
11986 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11987
11988         * gdbthread.h (thread_to_thread_handle): Declare.
11989         * thread.c (gdbtypes.h): Include.
11990         (thread_to_thread_handle): New function.
11991
11992         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11993         (target_thread_info_to_thread_handle): Declare.
11994         * target.c (target_thread_info_to_thread_handle): New function.
11995         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11996         * target-delegates.c: Regenerate.
11997
11998         * linux-thread-db.c (class thread_db_target): Add method
11999         thread_info_to_thread_handle.
12000         (thread_db_target::thread_info_to_thread_handle): Define.
12001         * remote.c (class remote_target): Add new method
12002         thread_info_to_thread_handle.
12003         (remote_target::thread_info_to_thread_handle): Define.
12004
12005 2019-04-08  Pedro Alves  <palves@redhat.com>
12006
12007         * common/common-exceptions.c (throw_exception): Don't create
12008         named object to throw; throw directly.
12009         (throw_it): Likewise.  Don't initialize gdb_exception::message
12010         here, with new; pass FMT and AP to the ctor instead.
12011         * common/common-exceptions.h: Include <string>.
12012         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12013         const char *, va_list)): New ctor.  Use std::make_shared.
12014         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12015         errors)): Delete.
12016         (gdb_exception_error::gdb_exception_error(enum errors, const char
12017         *, va_list)): New.
12018         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12019         Add assertion.
12020         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12021         errors)): Delete.
12022         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12023         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12024         Add assertion.
12025
12026 2019-04-08  Tom Tromey  <tom@tromey.com>
12027
12028         * valops.c (value_rtti_indirect_type): Replace throw_exception
12029         with throw.
12030         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12031         with throw.
12032         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12033         throw.
12034         * target.c (target_translate_tls_address): Replace throw_exception
12035         with throw.
12036         * stack.c (frame_apply_command_count): Replace throw_exception
12037         with throw.
12038         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12039         throw.
12040         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12041         with throw.
12042         * rs6000-tdep.c (rs6000_frame_cache)
12043         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12044         * remote.c: Replace throw_exception with throw.
12045         * record-full.c (record_full_message, record_full_wait_1)
12046         (record_full_restore): Replace throw_exception with throw.
12047         * record-btrace.c:
12048         (get_thread_current_frame_id, record_btrace_start_replaying)
12049         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12050         (cmd_record_btrace_start): Replace throw_exception with throw.
12051         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12052         throw.
12053         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12054         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12055         * linespec.c:
12056         (find_linespec_symbols): Replace throw_exception with throw.
12057         * infrun.c (displaced_step_prepare, resume): Replace
12058         throw_exception with throw.
12059         * infcmd.c (post_create_inferior): Replace throw_exception with
12060         throw.
12061         * inf-loop.c (inferior_event_handler): Replace throw_exception
12062         with throw.
12063         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12064         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12065         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12066         (get_prev_frame_always, get_frame_pc_if_available)
12067         (get_frame_address_in_block_if_available, get_frame_language):
12068         Replace throw_exception with throw.
12069         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12070         throw_exception with throw.
12071         * eval.c (fetch_subexp_value, evaluate_var_value)
12072         (evaluate_funcall, evaluate_subexp_standard): Replace
12073         throw_exception with throw.
12074         * dwarf2loc.c (call_site_find_chain)
12075         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12076         Replace throw_exception with throw.
12077         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12078         with throw.
12079         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12080         throw.
12081         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12082         * completer.c (complete_line_internal): Replace throw_exception
12083         with throw.
12084         * compile/compile-object-run.c (compile_object_run): Replace
12085         throw_exception with throw.
12086         * cli/cli-script.c (process_next_line): Replace throw_exception
12087         with throw.
12088         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12089         (btrace_enable, btrace_maint_update_pt_packets): Replace
12090         throw_exception with throw.
12091         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12092         throw_exception with throw.
12093         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12094         throw_exception with throw.
12095         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12096         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12097         * aarch64-tdep.c (aarch64_make_prologue_cache)
12098         (aarch64_make_stub_cache): Replace throw_exception with throw.
12099
12100 2019-04-08  Tom Tromey  <tom@tromey.com>
12101
12102         * common/common-exceptions.c (throw_exception): Rename from
12103         throw_exception_cxx.  Remove old copy.  Make argument const.
12104         (throw_it): Create and throw exception objects directly.
12105         * common/common-exceptions.h (throw_exception): Make argument
12106         const.
12107         (struct gdb_exception_error): Add constructor.
12108         (struct gdb_exception_quit): Add constructor.
12109
12110 2019-04-08  Tom Tromey  <tom@tromey.com>
12111
12112         * common/common-exceptions.h (exception_rethrow): Don't declare.
12113         (TRY_SJLJ): Update comment.
12114         (TRY, CATCH, END_CATCH): Remove.
12115         * common/common-exceptions.c (exception_rethrow): Remove.
12116
12117 2019-04-08  Tom Tromey  <tom@tromey.com>
12118
12119         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12120         Remove.
12121         (gdb_exception_error): Rename from
12122         gdb_exception_RETURN_MASK_ERROR.
12123         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12124         (gdb_quit_bad_alloc): Update.
12125         * aarch64-tdep.c: Update.
12126         * ada-lang.c: Update.
12127         * ada-typeprint.c: Update.
12128         * ada-valprint.c: Update.
12129         * amd64-tdep.c: Update.
12130         * arch-utils.c: Update.
12131         * break-catch-throw.c: Update.
12132         * breakpoint.c: Update.
12133         * btrace.c: Update.
12134         * c-varobj.c: Update.
12135         * cli/cli-cmds.c: Update.
12136         * cli/cli-interp.c: Update.
12137         * cli/cli-script.c: Update.
12138         * common/common-exceptions.c: Update.
12139         * common/new-op.c: Update.
12140         * common/selftest.c: Update.
12141         * compile/compile-c-symbols.c: Update.
12142         * compile/compile-cplus-symbols.c: Update.
12143         * compile/compile-object-load.c: Update.
12144         * compile/compile-object-run.c: Update.
12145         * completer.c: Update.
12146         * corelow.c: Update.
12147         * cp-abi.c: Update.
12148         * cp-support.c: Update.
12149         * cp-valprint.c: Update.
12150         * darwin-nat.c: Update.
12151         * disasm-selftests.c: Update.
12152         * dtrace-probe.c: Update.
12153         * dwarf-index-cache.c: Update.
12154         * dwarf-index-write.c: Update.
12155         * dwarf2-frame-tailcall.c: Update.
12156         * dwarf2-frame.c: Update.
12157         * dwarf2loc.c: Update.
12158         * dwarf2read.c: Update.
12159         * eval.c: Update.
12160         * event-loop.c: Update.
12161         * event-top.c: Update.
12162         * exec.c: Update.
12163         * f-valprint.c: Update.
12164         * fbsd-tdep.c: Update.
12165         * frame-unwind.c: Update.
12166         * frame.c: Update.
12167         * gdbtypes.c: Update.
12168         * gnu-v3-abi.c: Update.
12169         * guile/guile-internal.h: Update.
12170         * guile/scm-block.c: Update.
12171         * guile/scm-breakpoint.c: Update.
12172         * guile/scm-cmd.c: Update.
12173         * guile/scm-disasm.c: Update.
12174         * guile/scm-frame.c: Update.
12175         * guile/scm-lazy-string.c: Update.
12176         * guile/scm-math.c: Update.
12177         * guile/scm-param.c: Update.
12178         * guile/scm-ports.c: Update.
12179         * guile/scm-pretty-print.c: Update.
12180         * guile/scm-symbol.c: Update.
12181         * guile/scm-symtab.c: Update.
12182         * guile/scm-type.c: Update.
12183         * guile/scm-value.c: Update.
12184         * i386-linux-tdep.c: Update.
12185         * i386-tdep.c: Update.
12186         * inf-loop.c: Update.
12187         * infcall.c: Update.
12188         * infcmd.c: Update.
12189         * infrun.c: Update.
12190         * jit.c: Update.
12191         * language.c: Update.
12192         * linespec.c: Update.
12193         * linux-fork.c: Update.
12194         * linux-nat.c: Update.
12195         * linux-tdep.c: Update.
12196         * linux-thread-db.c: Update.
12197         * main.c: Update.
12198         * mi/mi-cmd-break.c: Update.
12199         * mi/mi-cmd-stack.c: Update.
12200         * mi/mi-interp.c: Update.
12201         * mi/mi-main.c: Update.
12202         * objc-lang.c: Update.
12203         * p-valprint.c: Update.
12204         * parse.c: Update.
12205         * ppc-linux-tdep.c: Update.
12206         * printcmd.c: Update.
12207         * python/py-arch.c: Update.
12208         * python/py-breakpoint.c: Update.
12209         * python/py-cmd.c: Update.
12210         * python/py-finishbreakpoint.c: Update.
12211         * python/py-frame.c: Update.
12212         * python/py-framefilter.c: Update.
12213         * python/py-gdb-readline.c: Update.
12214         * python/py-inferior.c: Update.
12215         * python/py-infthread.c: Update.
12216         * python/py-lazy-string.c: Update.
12217         * python/py-linetable.c: Update.
12218         * python/py-objfile.c: Update.
12219         * python/py-param.c: Update.
12220         * python/py-prettyprint.c: Update.
12221         * python/py-progspace.c: Update.
12222         * python/py-record-btrace.c: Update.
12223         * python/py-record.c: Update.
12224         * python/py-symbol.c: Update.
12225         * python/py-type.c: Update.
12226         * python/py-unwind.c: Update.
12227         * python/py-utils.c: Update.
12228         * python/py-value.c: Update.
12229         * python/python.c: Update.
12230         * record-btrace.c: Update.
12231         * record-full.c: Update.
12232         * remote-fileio.c: Update.
12233         * remote.c: Update.
12234         * riscv-tdep.c: Update.
12235         * rs6000-aix-tdep.c: Update.
12236         * rs6000-tdep.c: Update.
12237         * rust-exp.y: Update.
12238         * rust-lang.c: Update.
12239         * s390-tdep.c: Update.
12240         * selftest-arch.c: Update.
12241         * solib-dsbt.c: Update.
12242         * solib-frv.c: Update.
12243         * solib-spu.c: Update.
12244         * solib-svr4.c: Update.
12245         * solib.c: Update.
12246         * sparc64-linux-tdep.c: Update.
12247         * stack.c: Update.
12248         * symfile-mem.c: Update.
12249         * symmisc.c: Update.
12250         * target.c: Update.
12251         * thread.c: Update.
12252         * top.c: Update.
12253         * tracefile-tfile.c: Update.
12254         * tui/tui.c: Update.
12255         * typeprint.c: Update.
12256         * unittests/cli-utils-selftests.c: Update.
12257         * unittests/parse-connection-spec-selftests.c: Update.
12258         * valops.c: Update.
12259         * valprint.c: Update.
12260         * value.c: Update.
12261         * varobj.c: Update.
12262         * windows-nat.c: Update.
12263         * x86-linux-nat.c: Update.
12264         * xml-support.c: Update.
12265
12266 2019-04-08  Tom Tromey  <tom@tromey.com>
12267
12268         * xml-support.c: Use C++ exception handling.
12269         * x86-linux-nat.c: Use C++ exception handling.
12270         * windows-nat.c: Use C++ exception handling.
12271         * varobj.c: Use C++ exception handling.
12272         * value.c: Use C++ exception handling.
12273         * valprint.c: Use C++ exception handling.
12274         * valops.c: Use C++ exception handling.
12275         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12276         handling.
12277         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12278         * typeprint.c: Use C++ exception handling.
12279         * tui/tui.c: Use C++ exception handling.
12280         * tracefile-tfile.c: Use C++ exception handling.
12281         * top.c: Use C++ exception handling.
12282         * thread.c: Use C++ exception handling.
12283         * target.c: Use C++ exception handling.
12284         * symmisc.c: Use C++ exception handling.
12285         * symfile-mem.c: Use C++ exception handling.
12286         * stack.c: Use C++ exception handling.
12287         * sparc64-linux-tdep.c: Use C++ exception handling.
12288         * solib.c: Use C++ exception handling.
12289         * solib-svr4.c: Use C++ exception handling.
12290         * solib-spu.c: Use C++ exception handling.
12291         * solib-frv.c: Use C++ exception handling.
12292         * solib-dsbt.c: Use C++ exception handling.
12293         * selftest-arch.c: Use C++ exception handling.
12294         * s390-tdep.c: Use C++ exception handling.
12295         * rust-lang.c: Use C++ exception handling.
12296         * rust-exp.y: Use C++ exception handling.
12297         * rs6000-tdep.c: Use C++ exception handling.
12298         * rs6000-aix-tdep.c: Use C++ exception handling.
12299         * riscv-tdep.c: Use C++ exception handling.
12300         * remote.c: Use C++ exception handling.
12301         * remote-fileio.c: Use C++ exception handling.
12302         * record-full.c: Use C++ exception handling.
12303         * record-btrace.c: Use C++ exception handling.
12304         * python/python.c: Use C++ exception handling.
12305         * python/py-value.c: Use C++ exception handling.
12306         * python/py-utils.c: Use C++ exception handling.
12307         * python/py-unwind.c: Use C++ exception handling.
12308         * python/py-type.c: Use C++ exception handling.
12309         * python/py-symbol.c: Use C++ exception handling.
12310         * python/py-record.c: Use C++ exception handling.
12311         * python/py-record-btrace.c: Use C++ exception handling.
12312         * python/py-progspace.c: Use C++ exception handling.
12313         * python/py-prettyprint.c: Use C++ exception handling.
12314         * python/py-param.c: Use C++ exception handling.
12315         * python/py-objfile.c: Use C++ exception handling.
12316         * python/py-linetable.c: Use C++ exception handling.
12317         * python/py-lazy-string.c: Use C++ exception handling.
12318         * python/py-infthread.c: Use C++ exception handling.
12319         * python/py-inferior.c: Use C++ exception handling.
12320         * python/py-gdb-readline.c: Use C++ exception handling.
12321         * python/py-framefilter.c: Use C++ exception handling.
12322         * python/py-frame.c: Use C++ exception handling.
12323         * python/py-finishbreakpoint.c: Use C++ exception handling.
12324         * python/py-cmd.c: Use C++ exception handling.
12325         * python/py-breakpoint.c: Use C++ exception handling.
12326         * python/py-arch.c: Use C++ exception handling.
12327         * printcmd.c: Use C++ exception handling.
12328         * ppc-linux-tdep.c: Use C++ exception handling.
12329         * parse.c: Use C++ exception handling.
12330         * p-valprint.c: Use C++ exception handling.
12331         * objc-lang.c: Use C++ exception handling.
12332         * mi/mi-main.c: Use C++ exception handling.
12333         * mi/mi-interp.c: Use C++ exception handling.
12334         * mi/mi-cmd-stack.c: Use C++ exception handling.
12335         * mi/mi-cmd-break.c: Use C++ exception handling.
12336         * main.c: Use C++ exception handling.
12337         * linux-thread-db.c: Use C++ exception handling.
12338         * linux-tdep.c: Use C++ exception handling.
12339         * linux-nat.c: Use C++ exception handling.
12340         * linux-fork.c: Use C++ exception handling.
12341         * linespec.c: Use C++ exception handling.
12342         * language.c: Use C++ exception handling.
12343         * jit.c: Use C++ exception handling.
12344         * infrun.c: Use C++ exception handling.
12345         * infcmd.c: Use C++ exception handling.
12346         * infcall.c: Use C++ exception handling.
12347         * inf-loop.c: Use C++ exception handling.
12348         * i386-tdep.c: Use C++ exception handling.
12349         * i386-linux-tdep.c: Use C++ exception handling.
12350         * guile/scm-value.c: Use C++ exception handling.
12351         * guile/scm-type.c: Use C++ exception handling.
12352         * guile/scm-symtab.c: Use C++ exception handling.
12353         * guile/scm-symbol.c: Use C++ exception handling.
12354         * guile/scm-pretty-print.c: Use C++ exception handling.
12355         * guile/scm-ports.c: Use C++ exception handling.
12356         * guile/scm-param.c: Use C++ exception handling.
12357         * guile/scm-math.c: Use C++ exception handling.
12358         * guile/scm-lazy-string.c: Use C++ exception handling.
12359         * guile/scm-frame.c: Use C++ exception handling.
12360         * guile/scm-disasm.c: Use C++ exception handling.
12361         * guile/scm-cmd.c: Use C++ exception handling.
12362         * guile/scm-breakpoint.c: Use C++ exception handling.
12363         * guile/scm-block.c: Use C++ exception handling.
12364         * guile/guile-internal.h: Use C++ exception handling.
12365         * gnu-v3-abi.c: Use C++ exception handling.
12366         * gdbtypes.c: Use C++ exception handling.
12367         * frame.c: Use C++ exception handling.
12368         * frame-unwind.c: Use C++ exception handling.
12369         * fbsd-tdep.c: Use C++ exception handling.
12370         * f-valprint.c: Use C++ exception handling.
12371         * exec.c: Use C++ exception handling.
12372         * event-top.c: Use C++ exception handling.
12373         * event-loop.c: Use C++ exception handling.
12374         * eval.c: Use C++ exception handling.
12375         * dwarf2read.c: Use C++ exception handling.
12376         * dwarf2loc.c: Use C++ exception handling.
12377         * dwarf2-frame.c: Use C++ exception handling.
12378         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12379         * dwarf-index-write.c: Use C++ exception handling.
12380         * dwarf-index-cache.c: Use C++ exception handling.
12381         * dtrace-probe.c: Use C++ exception handling.
12382         * disasm-selftests.c: Use C++ exception handling.
12383         * darwin-nat.c: Use C++ exception handling.
12384         * cp-valprint.c: Use C++ exception handling.
12385         * cp-support.c: Use C++ exception handling.
12386         * cp-abi.c: Use C++ exception handling.
12387         * corelow.c: Use C++ exception handling.
12388         * completer.c: Use C++ exception handling.
12389         * compile/compile-object-run.c: Use C++ exception handling.
12390         * compile/compile-object-load.c: Use C++ exception handling.
12391         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12392         * compile/compile-c-symbols.c: Use C++ exception handling.
12393         * common/selftest.c: Use C++ exception handling.
12394         * common/new-op.c: Use C++ exception handling.
12395         * cli/cli-script.c: Use C++ exception handling.
12396         * cli/cli-interp.c: Use C++ exception handling.
12397         * cli/cli-cmds.c: Use C++ exception handling.
12398         * c-varobj.c: Use C++ exception handling.
12399         * btrace.c: Use C++ exception handling.
12400         * breakpoint.c: Use C++ exception handling.
12401         * break-catch-throw.c: Use C++ exception handling.
12402         * arch-utils.c: Use C++ exception handling.
12403         * amd64-tdep.c: Use C++ exception handling.
12404         * ada-valprint.c: Use C++ exception handling.
12405         * ada-typeprint.c: Use C++ exception handling.
12406         * ada-lang.c: Use C++ exception handling.
12407         * aarch64-tdep.c: Use C++ exception handling.
12408
12409 2019-04-08  Tom Tromey  <tom@tromey.com>
12410
12411         * xml-support.c (gdb_xml_parser::parse): Update.
12412         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12413         * value.c (show_convenience): Update.
12414         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12415         (test_parse_flags_qcs): Update.
12416         * thread.c (thr_try_catch_cmd): Update.
12417         * target.c (target_translate_tls_address): Update.
12418         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12419         (info_frame_command_core, frame_apply_command_count): Update.
12420         * rust-exp.y (rust_lex_exception_test): Update.
12421         * riscv-tdep.c (riscv_print_one_register_info): Update.
12422         * remote.c (remote_target::enable_btrace): Update.
12423         * record-btrace.c (record_btrace_enable_warn): Update.
12424         * python/py-utils.c (gdbpy_convert_exception): Update.
12425         * printcmd.c (do_one_display, print_variable_and_value): Update.
12426         * mi/mi-main.c (mi_print_exception): Update.
12427         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12428         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12429         * linux-nat.c (linux_nat_target::attach): Update.
12430         * linux-fork.c (class scoped_switch_fork_info): Update.
12431         * infrun.c (displaced_step_prepare): Update.
12432         * infcall.c (call_function_by_hand_dummy): Update.
12433         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12434         * gnu-v3-abi.c (print_one_vtable): Update.
12435         * frame.c (get_prev_frame_always): Update.
12436         * f-valprint.c (info_common_command_for_block): Update.
12437         * exec.c (try_open_exec_file): Update.
12438         * exceptions.c (print_exception, exception_print)
12439         (exception_fprintf, exception_print_same): Update.
12440         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12441         * dwarf-index-cache.c (index_cache::store)
12442         (index_cache::lookup_gdb_index): Update.
12443         * darwin-nat.c (maybe_cache_shell): Update.
12444         * cp-valprint.c (cp_print_value_fields): Update.
12445         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12446         (gcc_cplus_symbol_address): Update.
12447         * compile/compile-c-symbols.c (gcc_convert_symbol)
12448         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12449         * common/selftest.c: Update.
12450         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12451         a std::string.
12452         (exception_try_scope_entry, exception_try_scope_exit): Don't
12453         declare.
12454         (struct exception_try_scope): Remove.
12455         (TRY): Don't use exception_try_scope.
12456         (struct gdb_exception): Add constructor, operator=.
12457         <what>: New method.
12458         (struct gdb_exception_RETURN_MASK_ALL)
12459         (struct gdb_exception_RETURN_MASK_ERROR)
12460         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12461         (struct gdb_quit_bad_alloc): Update.
12462         * common/common-exceptions.c (exception_none): Change
12463         initializer.
12464         (struct catcher) <state, exception>: Initialize inline.
12465         <prev>: Remove member.
12466         (current_catcher): Remove.
12467         (catchers): New global.
12468         (exceptions_state_mc_init): Simplify.
12469         (catcher_pop): Remove.
12470         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12471         (try_scope_depth, exception_try_scope_entry)
12472         (exception_try_scope_exit): Remove.
12473         (throw_exception_sjlj): Update.
12474         (exception_messages, exception_messages_size): Remove.
12475         (throw_it): Simplify.
12476         (gdb_exception_sliced_copy): Remove.
12477         (throw_exception_cxx): Update.
12478         * cli/cli-script.c (script_from_file): Update.
12479         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12480         Update.
12481         * ada-valprint.c (ada_val_print): Update.
12482         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12483         (create_excep_cond_exprs): Update.
12484
12485 2019-04-08  Tom Tromey  <tom@tromey.com>
12486
12487         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12488         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12489         (TRY, CATCH, END_CATCH): Remove some definitions.
12490         * common/common-exceptions.c: Don't use GDB_XCPT.
12491         (catcher_list_size): Remove.
12492         (throw_exception, throw_it): Simplify.
12493
12494 2019-04-05  Tom Tromey  <tom@tromey.com>
12495
12496         Revert the header-sorting patch.
12497         * ft32-tdep.c: Revert.
12498         * frv-tdep.c: Revert.
12499         * frv-linux-tdep.c: Revert.
12500         * frame.c: Revert.
12501         * frame-unwind.c: Revert.
12502         * frame-base.c: Revert.
12503         * fork-child.c: Revert.
12504         * findvar.c: Revert.
12505         * findcmd.c: Revert.
12506         * filesystem.c: Revert.
12507         * filename-seen-cache.h: Revert.
12508         * filename-seen-cache.c: Revert.
12509         * fbsd-tdep.c: Revert.
12510         * fbsd-nat.h: Revert.
12511         * fbsd-nat.c: Revert.
12512         * f-valprint.c: Revert.
12513         * f-typeprint.c: Revert.
12514         * f-lang.c: Revert.
12515         * extension.h: Revert.
12516         * extension.c: Revert.
12517         * extension-priv.h: Revert.
12518         * expprint.c: Revert.
12519         * exec.h: Revert.
12520         * exec.c: Revert.
12521         * exceptions.c: Revert.
12522         * event-top.c: Revert.
12523         * event-loop.c: Revert.
12524         * eval.c: Revert.
12525         * elfread.c: Revert.
12526         * dwarf2read.h: Revert.
12527         * dwarf2read.c: Revert.
12528         * dwarf2loc.c: Revert.
12529         * dwarf2expr.h: Revert.
12530         * dwarf2expr.c: Revert.
12531         * dwarf2-frame.c: Revert.
12532         * dwarf2-frame-tailcall.c: Revert.
12533         * dwarf-index-write.h: Revert.
12534         * dwarf-index-write.c: Revert.
12535         * dwarf-index-common.c: Revert.
12536         * dwarf-index-cache.h: Revert.
12537         * dwarf-index-cache.c: Revert.
12538         * dummy-frame.c: Revert.
12539         * dtrace-probe.c: Revert.
12540         * disasm.h: Revert.
12541         * disasm.c: Revert.
12542         * disasm-selftests.c: Revert.
12543         * dictionary.c: Revert.
12544         * dicos-tdep.c: Revert.
12545         * demangle.c: Revert.
12546         * dcache.h: Revert.
12547         * dcache.c: Revert.
12548         * darwin-nat.h: Revert.
12549         * darwin-nat.c: Revert.
12550         * darwin-nat-info.c: Revert.
12551         * d-valprint.c: Revert.
12552         * d-namespace.c: Revert.
12553         * d-lang.c: Revert.
12554         * ctf.c: Revert.
12555         * csky-tdep.c: Revert.
12556         * csky-linux-tdep.c: Revert.
12557         * cris-tdep.c: Revert.
12558         * cris-linux-tdep.c: Revert.
12559         * cp-valprint.c: Revert.
12560         * cp-support.c: Revert.
12561         * cp-namespace.c: Revert.
12562         * cp-abi.c: Revert.
12563         * corelow.c: Revert.
12564         * corefile.c: Revert.
12565         * continuations.c: Revert.
12566         * completer.h: Revert.
12567         * completer.c: Revert.
12568         * complaints.c: Revert.
12569         * coffread.c: Revert.
12570         * coff-pe-read.c: Revert.
12571         * cli-out.h: Revert.
12572         * cli-out.c: Revert.
12573         * charset.c: Revert.
12574         * c-varobj.c: Revert.
12575         * c-valprint.c: Revert.
12576         * c-typeprint.c: Revert.
12577         * c-lang.c: Revert.
12578         * buildsym.c: Revert.
12579         * buildsym-legacy.c: Revert.
12580         * build-id.h: Revert.
12581         * build-id.c: Revert.
12582         * btrace.c: Revert.
12583         * bsd-uthread.c: Revert.
12584         * breakpoint.h: Revert.
12585         * breakpoint.c: Revert.
12586         * break-catch-throw.c: Revert.
12587         * break-catch-syscall.c: Revert.
12588         * break-catch-sig.c: Revert.
12589         * blockframe.c: Revert.
12590         * block.c: Revert.
12591         * bfin-tdep.c: Revert.
12592         * bfin-linux-tdep.c: Revert.
12593         * bfd-target.c: Revert.
12594         * bcache.c: Revert.
12595         * ax-general.c: Revert.
12596         * ax-gdb.h: Revert.
12597         * ax-gdb.c: Revert.
12598         * avr-tdep.c: Revert.
12599         * auxv.c: Revert.
12600         * auto-load.c: Revert.
12601         * arm-wince-tdep.c: Revert.
12602         * arm-tdep.c: Revert.
12603         * arm-symbian-tdep.c: Revert.
12604         * arm-pikeos-tdep.c: Revert.
12605         * arm-obsd-tdep.c: Revert.
12606         * arm-nbsd-tdep.c: Revert.
12607         * arm-nbsd-nat.c: Revert.
12608         * arm-linux-tdep.c: Revert.
12609         * arm-linux-nat.c: Revert.
12610         * arm-fbsd-tdep.c: Revert.
12611         * arm-fbsd-nat.c: Revert.
12612         * arm-bsd-tdep.c: Revert.
12613         * arch-utils.c: Revert.
12614         * arc-tdep.c: Revert.
12615         * arc-newlib-tdep.c: Revert.
12616         * annotate.h: Revert.
12617         * annotate.c: Revert.
12618         * amd64-windows-tdep.c: Revert.
12619         * amd64-windows-nat.c: Revert.
12620         * amd64-tdep.c: Revert.
12621         * amd64-sol2-tdep.c: Revert.
12622         * amd64-obsd-tdep.c: Revert.
12623         * amd64-obsd-nat.c: Revert.
12624         * amd64-nbsd-tdep.c: Revert.
12625         * amd64-nbsd-nat.c: Revert.
12626         * amd64-nat.c: Revert.
12627         * amd64-linux-tdep.c: Revert.
12628         * amd64-linux-nat.c: Revert.
12629         * amd64-fbsd-tdep.c: Revert.
12630         * amd64-fbsd-nat.c: Revert.
12631         * amd64-dicos-tdep.c: Revert.
12632         * amd64-darwin-tdep.c: Revert.
12633         * amd64-bsd-nat.c: Revert.
12634         * alpha-tdep.c: Revert.
12635         * alpha-obsd-tdep.c: Revert.
12636         * alpha-nbsd-tdep.c: Revert.
12637         * alpha-mdebug-tdep.c: Revert.
12638         * alpha-linux-tdep.c: Revert.
12639         * alpha-linux-nat.c: Revert.
12640         * alpha-bsd-tdep.c: Revert.
12641         * alpha-bsd-nat.c: Revert.
12642         * aix-thread.c: Revert.
12643         * agent.c: Revert.
12644         * addrmap.c: Revert.
12645         * ada-varobj.c: Revert.
12646         * ada-valprint.c: Revert.
12647         * ada-typeprint.c: Revert.
12648         * ada-tasks.c: Revert.
12649         * ada-lang.c: Revert.
12650         * aarch64-tdep.c: Revert.
12651         * aarch64-ravenscar-thread.c: Revert.
12652         * aarch64-newlib-tdep.c: Revert.
12653         * aarch64-linux-tdep.c: Revert.
12654         * aarch64-linux-nat.c: Revert.
12655         * aarch64-fbsd-tdep.c: Revert.
12656         * aarch64-fbsd-nat.c: Revert.
12657         * aarch32-linux-nat.c: Revert.
12658
12659 2019-04-05  Tom Tromey  <tom@tromey.com>
12660
12661         * ft32-tdep.c: Sort headers.
12662         * frv-tdep.c: Sort headers.
12663         * frv-linux-tdep.c: Sort headers.
12664         * frame.c: Sort headers.
12665         * frame-unwind.c: Sort headers.
12666         * frame-base.c: Sort headers.
12667         * fork-child.c: Sort headers.
12668         * findvar.c: Sort headers.
12669         * findcmd.c: Sort headers.
12670         * filesystem.c: Sort headers.
12671         * filename-seen-cache.h: Sort headers.
12672         * filename-seen-cache.c: Sort headers.
12673         * fbsd-tdep.c: Sort headers.
12674         * fbsd-nat.h: Sort headers.
12675         * fbsd-nat.c: Sort headers.
12676         * f-valprint.c: Sort headers.
12677         * f-typeprint.c: Sort headers.
12678         * f-lang.c: Sort headers.
12679         * extension.h: Sort headers.
12680         * extension.c: Sort headers.
12681         * extension-priv.h: Sort headers.
12682         * expprint.c: Sort headers.
12683         * exec.h: Sort headers.
12684         * exec.c: Sort headers.
12685         * exceptions.c: Sort headers.
12686         * event-top.c: Sort headers.
12687         * event-loop.c: Sort headers.
12688         * eval.c: Sort headers.
12689         * elfread.c: Sort headers.
12690         * dwarf2read.h: Sort headers.
12691         * dwarf2read.c: Sort headers.
12692         * dwarf2loc.c: Sort headers.
12693         * dwarf2expr.h: Sort headers.
12694         * dwarf2expr.c: Sort headers.
12695         * dwarf2-frame.c: Sort headers.
12696         * dwarf2-frame-tailcall.c: Sort headers.
12697         * dwarf-index-write.h: Sort headers.
12698         * dwarf-index-write.c: Sort headers.
12699         * dwarf-index-common.c: Sort headers.
12700         * dwarf-index-cache.h: Sort headers.
12701         * dwarf-index-cache.c: Sort headers.
12702         * dummy-frame.c: Sort headers.
12703         * dtrace-probe.c: Sort headers.
12704         * disasm.h: Sort headers.
12705         * disasm.c: Sort headers.
12706         * disasm-selftests.c: Sort headers.
12707         * dictionary.c: Sort headers.
12708         * dicos-tdep.c: Sort headers.
12709         * demangle.c: Sort headers.
12710         * dcache.h: Sort headers.
12711         * dcache.c: Sort headers.
12712         * darwin-nat.h: Sort headers.
12713         * darwin-nat.c: Sort headers.
12714         * darwin-nat-info.c: Sort headers.
12715         * d-valprint.c: Sort headers.
12716         * d-namespace.c: Sort headers.
12717         * d-lang.c: Sort headers.
12718         * ctf.c: Sort headers.
12719         * csky-tdep.c: Sort headers.
12720         * csky-linux-tdep.c: Sort headers.
12721         * cris-tdep.c: Sort headers.
12722         * cris-linux-tdep.c: Sort headers.
12723         * cp-valprint.c: Sort headers.
12724         * cp-support.c: Sort headers.
12725         * cp-namespace.c: Sort headers.
12726         * cp-abi.c: Sort headers.
12727         * corelow.c: Sort headers.
12728         * corefile.c: Sort headers.
12729         * continuations.c: Sort headers.
12730         * completer.h: Sort headers.
12731         * completer.c: Sort headers.
12732         * complaints.c: Sort headers.
12733         * coffread.c: Sort headers.
12734         * coff-pe-read.c: Sort headers.
12735         * cli-out.h: Sort headers.
12736         * cli-out.c: Sort headers.
12737         * charset.c: Sort headers.
12738         * c-varobj.c: Sort headers.
12739         * c-valprint.c: Sort headers.
12740         * c-typeprint.c: Sort headers.
12741         * c-lang.c: Sort headers.
12742         * buildsym.c: Sort headers.
12743         * buildsym-legacy.c: Sort headers.
12744         * build-id.h: Sort headers.
12745         * build-id.c: Sort headers.
12746         * btrace.c: Sort headers.
12747         * bsd-uthread.c: Sort headers.
12748         * breakpoint.h: Sort headers.
12749         * breakpoint.c: Sort headers.
12750         * break-catch-throw.c: Sort headers.
12751         * break-catch-syscall.c: Sort headers.
12752         * break-catch-sig.c: Sort headers.
12753         * blockframe.c: Sort headers.
12754         * block.c: Sort headers.
12755         * bfin-tdep.c: Sort headers.
12756         * bfin-linux-tdep.c: Sort headers.
12757         * bfd-target.c: Sort headers.
12758         * bcache.c: Sort headers.
12759         * ax-general.c: Sort headers.
12760         * ax-gdb.h: Sort headers.
12761         * ax-gdb.c: Sort headers.
12762         * avr-tdep.c: Sort headers.
12763         * auxv.c: Sort headers.
12764         * auto-load.c: Sort headers.
12765         * arm-wince-tdep.c: Sort headers.
12766         * arm-tdep.c: Sort headers.
12767         * arm-symbian-tdep.c: Sort headers.
12768         * arm-pikeos-tdep.c: Sort headers.
12769         * arm-obsd-tdep.c: Sort headers.
12770         * arm-nbsd-tdep.c: Sort headers.
12771         * arm-nbsd-nat.c: Sort headers.
12772         * arm-linux-tdep.c: Sort headers.
12773         * arm-linux-nat.c: Sort headers.
12774         * arm-fbsd-tdep.c: Sort headers.
12775         * arm-fbsd-nat.c: Sort headers.
12776         * arm-bsd-tdep.c: Sort headers.
12777         * arch-utils.c: Sort headers.
12778         * arc-tdep.c: Sort headers.
12779         * arc-newlib-tdep.c: Sort headers.
12780         * annotate.h: Sort headers.
12781         * annotate.c: Sort headers.
12782         * amd64-windows-tdep.c: Sort headers.
12783         * amd64-windows-nat.c: Sort headers.
12784         * amd64-tdep.c: Sort headers.
12785         * amd64-sol2-tdep.c: Sort headers.
12786         * amd64-obsd-tdep.c: Sort headers.
12787         * amd64-obsd-nat.c: Sort headers.
12788         * amd64-nbsd-tdep.c: Sort headers.
12789         * amd64-nbsd-nat.c: Sort headers.
12790         * amd64-nat.c: Sort headers.
12791         * amd64-linux-tdep.c: Sort headers.
12792         * amd64-linux-nat.c: Sort headers.
12793         * amd64-fbsd-tdep.c: Sort headers.
12794         * amd64-fbsd-nat.c: Sort headers.
12795         * amd64-dicos-tdep.c: Sort headers.
12796         * amd64-darwin-tdep.c: Sort headers.
12797         * amd64-bsd-nat.c: Sort headers.
12798         * alpha-tdep.c: Sort headers.
12799         * alpha-obsd-tdep.c: Sort headers.
12800         * alpha-nbsd-tdep.c: Sort headers.
12801         * alpha-mdebug-tdep.c: Sort headers.
12802         * alpha-linux-tdep.c: Sort headers.
12803         * alpha-linux-nat.c: Sort headers.
12804         * alpha-bsd-tdep.c: Sort headers.
12805         * alpha-bsd-nat.c: Sort headers.
12806         * aix-thread.c: Sort headers.
12807         * agent.c: Sort headers.
12808         * addrmap.c: Sort headers.
12809         * ada-varobj.c: Sort headers.
12810         * ada-valprint.c: Sort headers.
12811         * ada-typeprint.c: Sort headers.
12812         * ada-tasks.c: Sort headers.
12813         * ada-lang.c: Sort headers.
12814         * aarch64-tdep.c: Sort headers.
12815         * aarch64-ravenscar-thread.c: Sort headers.
12816         * aarch64-newlib-tdep.c: Sort headers.
12817         * aarch64-linux-tdep.c: Sort headers.
12818         * aarch64-linux-nat.c: Sort headers.
12819         * aarch64-fbsd-tdep.c: Sort headers.
12820         * aarch64-fbsd-nat.c: Sort headers.
12821         * aarch32-linux-nat.c: Sort headers.
12822
12823 2019-04-04  Tom Tromey  <tom@tromey.com>
12824
12825         * varobj.c (varobj_create): Update.
12826         * rust-exp.y (struct rust_parser) <update_innermost_block,
12827         lookup_symbol>: New methods.
12828         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12829         Rename.
12830         (rust_parser::rust_lookup_type)
12831         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12832         * printcmd.c (display_command, do_one_display): Update.
12833         * parser-defs.h (struct parser_state) <parser_state>: Add
12834         "tracker" parameter.
12835         (block_tracker): New member.
12836         (class innermost_block_tracker) <innermost_block_tracker>: Add
12837         "types" parameter.
12838         <reset>: Remove method.
12839         (innermost_block): Don't declare.
12840         (null_post_parser): Update.
12841         * parse.c (innermost_block): Remove global.
12842         (write_dollar_variable): Update.
12843         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12844         Remove "tracker_types" parameter.
12845         (parse_expression): Add "tracker" parameter.
12846         (parse_expression_for_completion): Update.
12847         (null_post_parser): Add "tracker" parameter.
12848         * p-exp.y: Update rules.
12849         * m2-exp.y: Update rules.
12850         * language.h (struct language_defn) <la_post_parser>: Add
12851         "tracker" parameter.
12852         * go-exp.y: Update rules.
12853         * f-exp.y: Update rules.
12854         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12855         parameter.
12856         * d-exp.y: Update rules.
12857         * c-exp.y: Update rules.
12858         * breakpoint.c (set_breakpoint_condition): Create an
12859         innermost_block_tracker.
12860         (watch_command_1): Likewise.
12861         * ada-lang.c (resolve): Add "tracker" parameter.
12862         (resolve_subexp): Likewise.
12863         * ada-exp.y (write_var_from_sym): Update.
12864
12865 2019-04-04  Tom Tromey  <tom@tromey.com>
12866
12867         * type-stack.h: New file.
12868         * type-stack.c: New file.
12869         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12870         type-stack.h.
12871         (insert_into_type_stack, insert_type, push_type, push_type_int)
12872         (insert_type_address_space, pop_type, pop_type_int)
12873         (pop_typelist, pop_type_stack, append_type_stack)
12874         (push_type_stack, get_type_stack, push_typelist)
12875         (follow_type_instance_flags, follow_types): Don't declare.
12876         * parse.c (type_stack): Remove global.
12877         (parse_exp_in_context): Update.
12878         (insert_into_type_stack, insert_type, push_type, push_type_int)
12879         (insert_type_address_space, pop_type, pop_type_int)
12880         (pop_typelist, pop_type_stack, append_type_stack)
12881         (push_type_stack, get_type_stack, push_typelist)
12882         (follow_type_instance_flags, follow_types): Remove (moved to
12883         type-stack.c).
12884         * f-exp.y (type_stack): New global.
12885         Update rules.
12886         (push_kind_type, f_parse): Update.
12887         * d-exp.y (type_stack): New global.
12888         Update rules.
12889         (d_parse): Update.
12890         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12891         Update rules.
12892         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12893         (HFILES_NO_SRCDIR): Add type-stack.h.
12894
12895 2019-04-04  Tom Tromey  <tom@tromey.com>
12896
12897         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12898         (rust_parser::convert_ast_to_expression, rust_parse)
12899         (rust_lex_test_completion, rust_lex_tests): Update.
12900         * parser-defs.h (struct expr_completion_state): New.
12901         (struct parser_state) <parser_state>: Add completion parameter.
12902         <mark_struct_expression, mark_completion_tag>: New methods.
12903         <parse_completion, m_completion_state>: New members.
12904         (prefixify_expression, null_post_parser): Update.
12905         (mark_struct_expression, mark_completion_tag): Don't declare.
12906         * parse.c (parse_completion, expout_last_struct)
12907         (expout_tag_completion_type, expout_completion_name): Remove
12908         globals.
12909         (parser_state::mark_struct_expression)
12910         (parser_state::mark_completion_tag): Now methods.
12911         (prefixify_expression): Add last_struct parameter.
12912         (prefixify_subexp): Likewise.
12913         (parse_exp_1): Update.
12914         (parse_exp_in_context): Add cstate parameter.  Update.
12915         (parse_expression_for_completion): Create an
12916         expr_completion_state.
12917         (null_post_parser): Add "completion" parameter.
12918         * p-exp.y: Update rules.
12919         (yylex): Update.
12920         * language.h (struct language_defn) <la_post_parser>: Add
12921         "completing" parameter.
12922         * go-exp.y: Update rules.
12923         (lex_one_token): Update.
12924         * expression.h (parse_completion): Don't declare.
12925         * d-exp.y: Update rules.
12926         (lex_one_token): Update rules.
12927         * c-exp.y: Update rules.
12928         (lex_one_token): Update.
12929         * ada-lang.c (resolve): Add "parse_completion" parameter.
12930         (resolve_subexp): Likewise.
12931         (ada_resolve_function): Likewise.
12932
12933 2019-04-04  Tom Tromey  <tom@tromey.com>
12934
12935         * parser-defs.h (struct parser_state) <start_arglist,
12936         end_arglist>: New methods.
12937         <arglist_len, m_funcall_chain>: New members.
12938         (arglist_len, start_arglist, end_arglist): Don't declare.
12939         * parse.c (arglist_len, funcall_chain): Remove global.
12940         (start_arglist, end_arglist): Remove functions.
12941         (parse_exp_in_context): Update.
12942         * p-exp.y: Update rules.
12943         * m2-exp.y: Update rules.
12944         * go-exp.y: Update rules.
12945         * f-exp.y: Update rules.
12946         * d-exp.y: Update rules.
12947         * c-exp.y: Update rules.
12948
12949 2019-04-04  Tom Tromey  <tom@tromey.com>
12950
12951         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12952         lex_operator, push_back>: New methods.
12953         Update all rules.
12954         (rust_parser::lex_hex, lex_escape): Rename and update.
12955         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12956         (rust_parser::lex_operator): Rename and update.
12957         (rust_parser::lex_number, rustyylex, rustyyerror)
12958         (rust_lex_test_init, rust_lex_test_sequence)
12959         (rust_lex_test_push_back, rust_lex_tests): Update.
12960         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12961         parameter.
12962         <lexptr, prev_lexptr>: New members.
12963         (lexptr, prev_lexptr): Don't declare.
12964         * parse.c (lexptr, prev_lexptr): Remove globals.
12965         (parse_exp_in_context): Update.
12966         * p-exp.y (yylex, yyerror): Update.
12967         * m2-exp.y (parse_number, yylex, yyerror): Update.
12968         * go-exp.y (lex_one_token, yyerror): Update.
12969         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12970         * d-exp.y (lex_one_token, yyerror): Update.
12971         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12972         (lex_one_token, yyerror): Update.
12973         * ada-lex.l (YY_INPUT): Update.
12974         (rewind_to_char): Update.
12975         * ada-exp.y (yyerror): Update.
12976
12977 2019-04-04  Tom Tromey  <tom@tromey.com>
12978
12979         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12980         * parser-defs.h (struct parser_state) <parser_state>: Add new
12981         parameter.
12982         <comma_terminates>: New member.
12983         (comma_terminates): Don't declare global.
12984         * parse.c (comma_terminates): Remove global.
12985         (parse_exp_in_context): Update.
12986         * p-exp.y (yylex): Update.
12987         * m2-exp.y (yylex): Update.
12988         * go-exp.y (lex_one_token): Update.
12989         * f-exp.y (yylex): Update.
12990         * d-exp.y (lex_one_token): Update.
12991         * c-exp.y (lex_one_token): Update.
12992         * ada-lex.l: Update.
12993
12994 2019-04-04  Tom Tromey  <tom@tromey.com>
12995
12996         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12997         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12998         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12999         * parser-defs.h (paren_depth): Don't declare.
13000         * parse.c (paren_depth): Remove global.
13001         (parse_exp_in_context): Update.
13002         * p-exp.y (paren_depth): New global.
13003         (pascal_parse): Initialize it.
13004         * m2-exp.y (paren_depth): New global.
13005         (m2_parse): Initialize it.
13006         * go-exp.y (paren_depth): New global.
13007         (go_parse): Initialize it.
13008         * f-exp.y (paren_depth): New global.
13009         (f_parse): Initialize it.
13010         * d-exp.y (paren_depth): New global.
13011         (d_parse): Initialize it.
13012         * c-exp.y (paren_depth): New global.
13013         (c_parse): Initialize it.
13014         * ada-lex.l (paren_depth): New global.
13015         (lexer_init): Initialize it.
13016
13017 2019-04-04  Tom Tromey  <tom@tromey.com>
13018
13019         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13020         (rust_parser::convert_ast_to_type)
13021         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13022         * parser-defs.h (struct parser_state) <parser_state>: Add
13023         parameters.  Initialize new members.
13024         <expression_context_block, expression_context_pc>: New members.
13025         * parse.c (expression_context_block, expression_context_pc):
13026         Remove globals.
13027         (parse_exp_in_context): Update.
13028         * p-exp.y: Update all rules.
13029         (yylex): Update.
13030         * m2-exp.y: Update all rules.
13031         (yylex): Update.
13032         * go-exp.y (yylex): Update.
13033         * f-exp.y (yylex): Update.
13034         * d-exp.y: Update all rules.
13035         (yylex): Update.
13036         * c-exp.y: Update all rules.
13037         (lex_one_token, classify_name, yylex, c_parse): Update.
13038         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13039
13040 2019-04-04  Tom Tromey  <tom@tromey.com>
13041
13042         * gdbarch.h, gdbarch.c: Rebuild.
13043         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13044         * stap-probe.h:
13045         (struct stap_parse_info): Replace "parser_state" with
13046         "expr_builder".
13047         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13048         (parser_state): New class.
13049         * parse.c (expr_builder): Rename.
13050         (expr_builder::release): Rename.
13051         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13052         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13053         (write_exp_elt_longcst, write_exp_elt_floatcst)
13054         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13055         (write_exp_string_vector, write_exp_bitstring)
13056         (write_exp_msymbol, mark_struct_expression)
13057         (write_dollar_variable)
13058         (insert_type_address_space, increase_expout_size): Replace
13059         "parser_state" with "expr_builder".
13060         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13061         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13062         "parser_state" with "expr_builder".
13063
13064 2019-04-04  Tom Tromey  <tom@tromey.com>
13065
13066         * rust-exp.y: Replace "parse_language" with method call.
13067         * p-exp.y:
13068         (yylex): Replace "parse_language" with method call.
13069         * m2-exp.y:
13070         (yylex): Replace "parse_language" with method call.
13071         * go-exp.y (classify_name): Replace "parse_language" with method
13072         call.
13073         * f-exp.y (yylex): Replace "parse_language" with method call.
13074         * d-exp.y (lex_one_token): Replace "parse_language" with method
13075         call.
13076         * c-exp.y:
13077         (lex_one_token, classify_name, yylex): Replace "parse_language"
13078         with method call.
13079         * ada-exp.y (find_primitive_type, type_char)
13080         (type_system_address): Replace "parse_language" with method call.
13081
13082 2019-04-04  Tom Tromey  <tom@tromey.com>
13083
13084         * rust-exp.y: Replace "parse_gdbarch" with method call.
13085         * parse.c (write_dollar_variable, insert_type_address_space):
13086         Replace "parse_gdbarch" with method call.
13087         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13088         call.
13089         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13090         call.
13091         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13092         "parse_gdbarch" with method call.
13093         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13094         with method call.
13095         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13096         "parse_gdbarch" with method call.
13097         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13098         "parse_gdbarch" with method call.
13099         * c-exp.y (parse_type, parse_number, classify_name): Replace
13100         "parse_gdbarch" with method call.
13101         * ada-lex.l: Replace "parse_gdbarch" with method call.
13102         * ada-exp.y (parse_type, find_primitive_type, type_char)
13103         (type_system_address): Replace "parse_gdbarch" with method call.
13104
13105 2019-04-04  Tom Tromey  <tom@tromey.com>
13106
13107         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13108         * stap-probe.c (stap_parse_argument): Update.
13109         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13110         initial_size parameter.
13111         * rust-exp.y (rust_lex_tests): Update.
13112         * parse.c (parser_state): Update.
13113         (parse_exp_in_context): Update.
13114         * parser-defs.h (struct parser_state) <parser_state>: Remove
13115         "initial_size" parameter.
13116
13117 2019-04-04  Tom Tromey  <tom@tromey.com>
13118
13119         * parser-defs.h (increase_expout_size): Don't declare.
13120         * parse.c (increase_expout_size): Now static.
13121
13122 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13123
13124         * gnu-nat.c (gnu_nat_target::wait): Fix
13125         target_waitstatus_to_string call.
13126
13127 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13128
13129         * eval.c (evaluate_subexp_standard): Handle internal functions
13130         during Fortran function call handling.
13131
13132 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13133
13134         * NEWS: Mention new internal functions.
13135         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13136         (read_base_type): Use dwarf2_init_complex_target_type.
13137         * value.c (creal_internal_fn): New function.
13138         (cimag_internal_fn): New function.
13139         (_initialize_values): Register new internal functions.
13140
13141 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13142
13143         * infrun.c (stop_all_threads): If debug_infrun, always
13144         trace the wait status after wait_one, using
13145         target_waitstatus_to_string and target_pid_to_str.
13146         (handle_inferior_event): Replace various trace of
13147         wait status kind by a single trace.
13148         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13149         wait status kind image by target_waitstatus_to_string.
13150         * target/waitstatus.c (target_waitstatus_to_string): Fix
13151         obsolete comment.
13152
13153 2019-04-01  Tom Tromey  <tromey@adacore.com>
13154
13155         PR symtab/23331:
13156         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13157
13158 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13159             Pedro Alves  <palves@redhat.com>
13160
13161         * top.c (quit_force): Call 'finalize_values'.
13162         * value.c (finalize_values): New function.
13163         * value.h (finalize_values): Declare.
13164
13165 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13166
13167         * NEWS: Announce $_gdb_major and $_gdb_minor.
13168
13169         * top.c (init_gdb_version_vars): New function.
13170         (gdb_init): Call init_gdb_version_vars.
13171
13172 2019-03-29  Tom Tromey  <tromey@adacore.com>
13173
13174         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13175         help text.  Remove dead code.
13176
13177 2019-03-29  Keith Seitz  <keiths@redhat.com>
13178
13179         From Siddhesh Poyarekar:
13180         * f-lang.h (f77_get_upperbound): Return LONGEST.
13181         (f77_get_lowerbound): Likewise.
13182         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13183         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13184         print them.
13185         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13186         plongest to format print it.
13187         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13188         (f77_get_upperbound): Likewise.
13189         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13190         LOWER_BOUND to LONGEST.
13191         (f77_create_arrayprint_offset_tbl): Likewise.
13192
13193 2019-03-29  Keith Seitz  <keiths@redhat.com>
13194
13195         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13196         %s/pulongest for TYPE_LENGTH instead of %d in format
13197         strings.
13198         * ada-typerint.c (ada_print_type): Likewise.
13199         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13200         * compile/compile-c-support.c (generate_register_struct): Likewise.
13201         * gdbtypes.c (recursive_dump_type): Likewise.
13202         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13203         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13204         instead of %d in format strings.
13205         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13206         to std::min to ULONGEST.
13207         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13208         instead of %d in format strings.
13209         * tracepoint.c (info_scope_command): Likewise.
13210         * typeprint.c (print_offset_data::update)
13211         (print_offset_data::finish): Likewise.
13212         * xtensa-tdep.c (xtensa_store_return_value)
13213         (xtensa_push_dummy_call): Likewise.
13214
13215 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13216
13217         * windows-nat.c (display_selector): Fixed format specifications
13218         for 64-bit Cygwin.
13219
13220 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13221
13222         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13223
13224 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13225
13226         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13227         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13228         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13229         (nios2_linux_init_abi): Install it.
13230
13231 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13232
13233         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13234
13235 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13236
13237         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13238
13239 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13240             Tom Tromey  <tromey@adacore.com>
13241
13242         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13243
13244 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13245
13246         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13247         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13248         method to compute the bounds of range types. Also print "[evaluated]"
13249         if the bounds' values come from a dynamic evaluation.
13250
13251 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13252
13253         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13254         whitespace when pretty printing is on.
13255
13256 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13257
13258         * ppc-linux-nat.c: Add include.
13259
13260 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13261
13262         * NEWS: Mention AArch64 Pointer Authentication.
13263
13264 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13265
13266         * arm-linux-nat.c: Add include.
13267
13268 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13269
13270         * source-cache.c (source_cache::get_source_lines): Re-read
13271         fullname after calling open_source_file.
13272
13273 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13274
13275         * NEWS: Mention TLS support for FreeBSD.
13276
13277 2019-03-25  Tom Tromey  <tromey@adacore.com>
13278
13279         * minsyms.c (BUNCH_SIZE): Update comment.
13280         (~minimal_symbol_reader): Remove old comment.
13281         (compact_minimal_symbols): Update comment.
13282         (minimal_symbol_reader::install): Remove old comment.  Update
13283         other comments.
13284
13285 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13286
13287         * s390-linux-nat.c: Add include.
13288
13289 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13290
13291         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13292         Call linux_get_hwcap.
13293         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13294         Likewise.
13295         (aarch64_linux_get_hwcap): Remove function.
13296         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13297         declaration.
13298         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13299         linux_get_hwcap.
13300         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13301         * linux-tdep.c (linux_get_hwcap): Add function.
13302         (linux_get_hwcap2): Likewise.
13303         * linux-tdep.h (linux_get_hwcap): Add declaration.
13304         (linux_get_hwcap2): Likewise.
13305         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13306         (ppc_linux_get_hwcap2): Likewise.
13307         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13308         linux_get_hwcap.
13309         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13310         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13311         (ppc_linux_nat_target::read_description): Likewise.
13312         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13313         * s390-linux-nat.c: Likewise.
13314         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13315
13316 2019-03-24  Tom Tromey  <tom@tromey.com>
13317
13318         * ada-lang.c (standard_lookup): Simplify initialization.
13319         (ada_lookup_symbol_nonlocal): Simplify return.
13320         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13321         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13322         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13323         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13324         initialization.
13325         * solib.c (solib_global_lookup): Simplify.
13326         * symtab.c (null_block_symbol): Remove.
13327         (symbol_cache_lookup): Simplify returns.
13328         (lookup_language_this): Simplify returns.
13329         (lookup_symbol_aux): Simplify return.
13330         (lookup_local_symbol): Simplify returns.
13331         (lookup_global_symbol_from_objfile): Simplify return.
13332         (lookup_symbol_in_objfile_symtabs)
13333         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13334         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13335         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13336         * cp-namespace.c (cp_lookup_bare_symbol)
13337         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13338         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13339         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13340         (cp_lookup_symbol_via_imports): Simplify initialization.
13341         (find_symbol_in_baseclass): Likewise.
13342         * symtab.h (null_block_symbol): Remove.
13343         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13344         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13345         (d_lookup_symbol_module): Likewise.
13346         (find_symbol_in_baseclass): Simplify initialization.
13347
13348 2019-03-24  Tom Tromey  <tom@tromey.com>
13349
13350         * expression.h: Don't include symtab.h.
13351         (struct block): Forward declare.
13352
13353 2019-03-24  Tom Tromey  <tom@tromey.com>
13354
13355         * c-exp.y (typebase): Remove casts.
13356         * gdbtypes.c (lookup_unsigned_typename, )
13357         (lookup_signed_typename): Remove cast.
13358         * eval.c (parse_to_comma_and_eval): Remove cast.
13359         * parse.c (write_dollar_variable): Remove cast.
13360         * block.h (struct block) <superblock>: Now const.
13361         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13362         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13363         (map_block): Make "block" const.
13364         * symfile.h (struct quick_symbol_functions)
13365         <map_matching_symbols>: Constify block argument to "callback".
13366         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13367         const.
13368         (find_pc_sect_compunit_symtab): Make "b" const.
13369         (find_symbol_at_address): Likewise.
13370         (search_symbols): Likewise.
13371         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13372         (dw2_debug_names_lookup_symbol): Likewise.
13373         (dw2_map_matching_symbols): Update.
13374         * p-valprint.c (pascal_val_print): Remove "block".
13375         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13376         (aux_add_nonlocal_symbols): Make "block" const.
13377         (resolve_subexp): Remove cast.
13378         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13379         const.
13380         (iterate_over_file_blocks): Likewise.
13381         * f-exp.y (%union) <bval>: Remove.
13382         * coffread.c (patch_opaque_types): Make "b" const.
13383         * spu-tdep.c (spu_catch_start): Make "block" const.
13384         * c-valprint.c (print_unpacked_pointer): Remove "block".
13385         * symmisc.c (dump_symtab_1): Make "b" const.
13386         (block_depth): Make "block" const.
13387         * d-exp.y (%union) <bval>: Remove.
13388         * cp-support.h (cp_lookup_rtti_type): Update.
13389         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13390         * psymtab.c (psym_lookup_symbol): Make "block" const.
13391         (maintenance_check_psymtabs): Make "b" const.
13392         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13393         (enumerate_locals, enumerate_args): Update.
13394         * python/py-symtab.c (stpy_global_block): Make "block" const.
13395         (stpy_static_block): Likewise.
13396         * inline-frame.c (block_starting_point_at): Make "new_block"
13397         const.
13398         * block.c (find_block_in_blockvector): Make return type const.
13399         (blockvector_for_pc_sect): Make "b" const.
13400         (find_block_in_blockvector): Make "b" const.
13401
13402 2019-03-23  Tom Tromey  <tom@tromey.com>
13403
13404         * varobj.c (varobj_create): Update.
13405         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13406         * printcmd.c (display_command, do_one_display): Don't reset
13407         innermost_block.
13408         * parser-defs.h (enum innermost_block_tracker_type): Move to
13409         expression.h.
13410         (innermost_block): Update comment.
13411         * parse.c (parse_exp_1): Add tracker_types parameter.
13412         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13413         tracker_types parameter.  Reset innermost_block.
13414         (parse_exp_in_context): Remove.
13415         (parse_expression_for_completion): Update.
13416         * objfiles.c (~objfile): Don't reset expression_context_block or
13417         innermost_block.
13418         * expression.h (enum innermost_block_tracker_type): Move from
13419         parser-defs.h.
13420         (parse_exp_1): Add tracker_types parameter.
13421         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13422         reset innermost_block.
13423
13424 2019-03-23  Tom Tromey  <tom@tromey.com>
13425
13426         * objfiles.h: Include bcache.h.
13427
13428 2019-03-23  Tom Tromey  <tom@tromey.com>
13429
13430         * linespec.c (get_current_search_block): Use
13431         scoped_restore_current_language.
13432         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13433
13434 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13435             Jiong Wang  <jiong.wang@arm.com>
13436
13437         * aarch64-linux-tdep.c
13438         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13439         section.
13440         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13441
13442 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13443             Jiong Wang  <jiong.wang@arm.com>
13444
13445         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13446         instructions.
13447         (aarch64_analyze_prologue_test): Add PACIASP test.
13448         (aarch64_prologue_prev_register): Unmask PC value.
13449
13450 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13451             Jiong Wang  <jiong.wang@arm.com>
13452
13453         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13454         (aarch64_dwarf2_prev_register): Unmask PC value.
13455         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13456         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13457         DW_CFA_AARCH64_negate_ra_state.
13458         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13459
13460 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13461             Jiong Wang  <jiong.wang@arm.com>
13462
13463         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13464         registers.
13465         (aarch64_pseudo_register_name): Likewise.
13466         (aarch64_pseudo_register_type): Likewise.
13467         (aarch64_pseudo_register_reggroup_p): Likewise.
13468         (aarch64_gdbarch_init): Add pauth registers.
13469         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13470         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13471         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13472         (struct gdbarch_tdep): Add regnum for ra_state.
13473
13474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13475             Jiong Wang  <jiong.wang@arm.com>
13476
13477         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13478
13479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13480             Jiong Wang  <jiong.wang@arm.com>
13481
13482         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13483         function.
13484         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13485         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13486         (aarch64_gdbarch_init): Add puth registers.
13487         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13488         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13489         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13490
13491 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13492             Jiong Wang  <jiong.wang@arm.com>
13493
13494         * aarch64-linux-nat.c
13495         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13496         * aarch64-linux-tdep.c
13497         (aarch64_linux_core_read_description): Likewise.
13498         (aarch64_linux_get_hwcap): New function.
13499         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13500         (aarch64_linux_get_hwcap): New declaration.
13501
13502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13503             Jiong Wang  <jiong.wang@arm.com>
13504
13505         * aarch64-linux-nat.c
13506         (aarch64_linux_nat_target::read_description): Add pauth param.
13507         * aarch64-linux-tdep.c
13508         (aarch64_linux_core_read_description): Likewise.
13509         * aarch64-tdep.c (struct target_desc): Add in pauth.
13510         (aarch64_read_description): Add pauth param.
13511         (aarch64_gdbarch_init): Likewise.
13512         * aarch64-tdep.h (aarch64_read_description): Likewise.
13513         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13514         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13515         * features/Makefile: Add new files.
13516         * features/aarch64-pauth.c: New file.
13517         * features/aarch64-pauth.xml: New file.
13518
13519 2019-03-20  Tom Tromey  <tromey@adacore.com>
13520
13521         * infrun.c (handle_inferior_event): Rename from
13522         handle_inferior_event_1.  Create a scoped_value_mark.
13523         (handle_inferior_event): Remove.
13524
13525 2019-03-19  Tom Tromey  <tromey@adacore.com>
13526
13527         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13528         * infrun.h (print_stop_event): Add "displays" parameter.
13529         * infrun.c (print_stop_event): Add "displays" parameter.
13530
13531 2019-03-19  Pedro Alves  <palves@redhat.com>
13532
13533         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13534         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13535         to -1.  Fix TABs vs spaces.
13536         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13537         * tui/tui-out.h (tui_ui_out) Add intro comments.
13538         <m_line, m_start_of_line>: In-class initialize, and add describing
13539         comment.
13540
13541 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13542
13543         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13544         variable names.
13545         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13546
13547 2019-03-18  Pedro Alves  <palves@redhat.com>
13548             Eli Zaretskii <eliz@gnu.org>
13549
13550         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13551         m_line and m_start_of_line.
13552
13553 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13554
13555         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13556         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13557         it returns a newline.  This fixes a regression in TU mode, whereby
13558         the next line is output on the same screen line as the user input.
13559
13560 2019-03-18  Tom Tromey  <tromey@adacore.com>
13561
13562         * minsyms.c (minimal_symbol_reader::install): Remove call to
13563         obstack_blank.
13564
13565 2019-03-18  Pedro Alves  <palves@redhat.com>
13566
13567         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13568         New globals.
13569         (apply_style): New, factored out from ...
13570         (apply_ansi_escape): ... this.  Handle reverse video mode.
13571         (tui_set_reverse_mode): New function.
13572         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13573         * tui/tui-winsource.c (tui_show_source_line): Use
13574         tui_set_reverse_mode instead of setting A_STANDOUT.
13575         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13576         New setter methods.
13577
13578 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13579
13580         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13581         Handle tabs.
13582
13583 2019-03-18  Tom Tromey  <tromey@adacore.com>
13584
13585         * ada-lang.c (empty_array): Add "high" parameter.
13586         (ada_evaluate_subexp): Update.
13587
13588 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13589
13590         * unittests/string_view-selftests.c: Define
13591         _initialize_string_view_selftests unconditionally.
13592
13593 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13594
13595         PR gdb/24350
13596         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13597
13598 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13599
13600         PR gdb/24351
13601         * windows-nat.c (display_selector): Fix format specifiers.
13602
13603 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13604
13605         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13606         tui_refill_source_window instead of tui_refresh_win, to update the
13607         current execution line.  This fixes redisplay of the current line
13608         when stepping through the code with "next" or "step".
13609
13610 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13611
13612         * source-cache.c (source_cache::get_source_lines): Call
13613         find_source_lines to initialize s->nlines.  This fixes vertical
13614         scrolling of TUI source window when the DOWN arrow is pressed.
13615
13616 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13617
13618         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13619         linux-thread-db.c (_initialize_thread_db): Likewise.
13620
13621 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13622
13623         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13624         wclrtoeol in tui_show_source_line".  This reverts changes made in
13625         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13626
13627 2019-03-15  Tom Tromey  <tom@tromey.com>
13628
13629         * symtab.h (struct minimal_symbol): Derive from
13630         general_symbol_info.
13631         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13632         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13633         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13634         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13635         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13636         (MSYMBOL_SEARCH_NAME): Update.
13637         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13638         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13639         * minsyms.c (minimal_symbol_reader::record_full): Update.
13640
13641 2019-03-15  Tom Tromey  <tom@tromey.com>
13642
13643         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13644
13645 2019-03-15  Tom Tromey  <tom@tromey.com>
13646
13647         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13648         unique_xmalloc_ptr.
13649         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13650         Update.
13651         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13652         (build_minimal_symbol_hash_tables)
13653         (minimal_symbol_reader::install): Update.
13654
13655 2019-03-15  Tom Tromey  <tom@tromey.com>
13656
13657         * symtab.c (create_demangled_names_hash): Update.
13658         (symbol_set_names): Update.
13659         * objfiles.h (struct objfile_per_bfd_storage)
13660         <demangled_names_hash>: Now an htab_up.
13661         * objfiles.c (objfile_per_bfd_storage): Simplify.
13662
13663 2019-03-15  Tom Tromey  <tom@tromey.com>
13664
13665         * objfiles.h (struct objfile_per_bfd_storage): Declare
13666         destructor.
13667         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13668         New.
13669         (get_objfile_bfd_data): Use new.  Don't initialize
13670         language_of_main.
13671         (free_objfile_per_bfd_storage): Remove.
13672         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13673
13674 2019-03-15  Tom Tromey  <tom@tromey.com>
13675
13676         * symfile.c (reread_symbols): Update.
13677         * objfiles.c (objfile::objfile): Update.
13678         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13679         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13680         comment.
13681         (minimal_symbol_reader::install): Update.
13682         (terminate_minimal_symbol_table): Remove.
13683         * jit.c (jit_object_close_impl): Update.
13684
13685 2019-03-15  Tom Tromey  <tom@tromey.com>
13686
13687         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13688         initializations.
13689
13690 2019-03-15  Tom Tromey  <tom@tromey.com>
13691
13692         * objfiles.h (struct objfile_per_bfd_storage)
13693         <demangled_hash_languages>: Now a bitset.
13694         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13695         (lookup_minimal_symbol): Update.
13696
13697 2019-03-15  Tom Tromey  <tom@tromey.com>
13698
13699         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13700         Don't return the symbol.
13701         * coffread.c (record_minimal_symbol): Use record_full.
13702
13703 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13704
13705         The MS-Windows port of ncurses fails to switch to a color pair if
13706         one or both of the colors are the implicit default colors.  This
13707         change records the default colors when TUI is initialized, and
13708         then specifies them explicitly when a color pair uses the default
13709         colors.  This allows color styling in TUI mode on MS-Windows.
13710
13711         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13712         ncurses_norm_attr.
13713         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13714         colors in ncurses_norm_attr.
13715         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13716         "none", replace it with the default color recorded in
13717         ncurses_norm_attr.
13718
13719 2019-03-14  Tom Tromey  <tromey@adacore.com>
13720
13721         * source-cache.h (class source_cache) <get_source_lines>: Return
13722         std::string.
13723         * source-cache.c (source_cache::extract_lines): Handle case where
13724         first_pos==npos.  Return std::string.
13725         (source_cache::get_source_lines): Update.
13726
13727 2019-03-14  Tom Tromey  <tromey@adacore.com>
13728
13729         * NEWS: Add item for "style sources" commands.
13730         * source-cache.c (source_cache::get_source_lines): Check
13731         source_styling.
13732         * cli/cli-style.c (source_styling): New global.
13733         (_initialize_cli_style): Add "style sources" commands.
13734         (show_style_sources): New function.
13735         * cli/cli-style.h (source_styling): Declare.
13736
13737 2019-03-14  Pedro Alves  <palves@redhat.com>
13738             Tom Tromey  <tromey@adacore.com>
13739
13740         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13741         * tui/tui-winsource.c (tui_refill_source_window): New function,
13742         from...
13743         (tui_horizontal_source_scroll): ... here.  Move some logic.
13744         * cli/cli-style.c (set_style_enabled): Notify new observable.
13745         * tui/tui-hooks.c (tui_redisplay_source): New function.
13746         (tui_attach_detach_observers): Attach or detach
13747         tui_redisplay_source.
13748         * observable.h (source_styling_changed): New observable.
13749         * observable.c: Define source_styling_changed observable.
13750
13751 2019-03-13  Tom Tromey  <tromey@adacore.com>
13752
13753         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13754         (i386_gnu_nat_target::store_registers): Update.
13755         * target-debug.h (target_debug_print_std_string): New macro.
13756         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13757         * windows-tdep.c (display_one_tib): Update.
13758         * tui/tui-stack.c (tui_make_status_line): Update.
13759         * top.c (print_inferior_quit_action): Update.
13760         * thread.c (thr_try_catch_cmd): Update.
13761         (add_thread_with_info): Update.
13762         (thread_target_id_str): Update.
13763         (thr_try_catch_cmd): Update.
13764         (thread_command): Update.
13765         (thread_find_command): Update.
13766         * record-btrace.c (record_btrace_target::info_record)
13767         (record_btrace_resume_thread, record_btrace_target::resume)
13768         (record_btrace_cancel_resume, record_btrace_step_thread)
13769         (record_btrace_target::wait, record_btrace_target::wait)
13770         (record_btrace_target::wait, record_btrace_target::stop): Update.
13771         * progspace.c (print_program_space): Update.
13772         * process-stratum-target.c
13773         (process_stratum_target::thread_address_space): Update.
13774         * linux-fork.c (linux_fork_mourn_inferior)
13775         (detach_checkpoint_command, info_checkpoints_command)
13776         (linux_fork_context): Update.
13777         (linux_fork_detach): Update.
13778         (class scoped_switch_fork_info): Update.
13779         (delete_checkpoint_command): Update.
13780         * infrun.c (follow_fork_inferior): Update.
13781         (follow_fork_inferior): Update.
13782         (proceed_after_vfork_done): Update.
13783         (handle_vfork_child_exec_or_exit): Update.
13784         (follow_exec): Update.
13785         (displaced_step_prepare_throw): Update.
13786         (displaced_step_restore): Update.
13787         (start_step_over): Update.
13788         (resume_1): Update.
13789         (clear_proceed_status_thread): Update.
13790         (proceed): Update.
13791         (print_target_wait_results): Update.
13792         (do_target_wait): Update.
13793         (context_switch): Update.
13794         (stop_all_threads): Update.
13795         (restart_threads): Update.
13796         (finish_step_over): Update.
13797         (handle_signal_stop): Update.
13798         (switch_back_to_stepped_thread): Update.
13799         (keep_going_pass_signal): Update.
13800         (print_exited_reason): Update.
13801         (normal_stop): Update.
13802         * inferior.c (inferior_pid_to_str): Change return type.
13803         (print_selected_inferior): Update.
13804         (add_inferior): Update.
13805         (detach_inferior): Update.
13806         * dummy-frame.c (fprint_dummy_frames): Update.
13807         * dcache.c (dcache_info_1): Update.
13808         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13809         (btrace_fetch, btrace_clear): Update.
13810         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13811         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13812         type.
13813         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13814         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13815         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13816         * gdbarch.c, gdbarch.h: Rebuild.
13817         * gdbarch.sh (core_pid_to_str): Change return type.
13818         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13819         return type.
13820         (windows_nat_target::pid_to_str): Change return type.
13821         (windows_delete_thread): Update.
13822         (windows_nat_target::attach): Update.
13823         (windows_nat_target::files_info): Update.
13824         * target-delegates.c: Rebuild.
13825         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13826         return type.
13827         (sol_thread_target::pid_to_str): Change return type.
13828         * remote.c (class remote_target) <pid_to_str>: Change return
13829         type.
13830         (remote_target::pid_to_str): Change return type.
13831         (extended_remote_target::attach, remote_target::remote_stop_ns)
13832         (remote_target::remote_notif_remove_queued_reply)
13833         (remote_target::push_stop_reply, remote_target::disable_btrace):
13834         Update.
13835         (extended_remote_target::attach): Update.
13836         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13837         type.
13838         (gdbsim_target::pid_to_str): Change return type.
13839         * ravenscar-thread.c (struct ravenscar_thread_target)
13840         <pid_to_str>: Change return type.
13841         (ravenscar_thread_target::pid_to_str): Change return type.
13842         * procfs.c (class procfs_target) <pid_to_str>: Change return
13843         type.
13844         (procfs_target::pid_to_str): Change return type.
13845         (procfs_target::attach): Update.
13846         (procfs_target::detach): Update.
13847         (procfs_target::fetch_registers): Update.
13848         (procfs_target::store_registers): Update.
13849         (procfs_target::wait): Update.
13850         (procfs_target::files_info): Update.
13851         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13852         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13853         return type.
13854         (nto_procfs_target::pid_to_str): Change return type.
13855         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13856         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13857         return type.
13858         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13859         (exit_lwp): Update.
13860         (attach_proc_task_lwp_callback, get_detach_signal)
13861         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13862         (linux_nat_target::resume, wait_lwp, stop_callback)
13863         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13864         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13865         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13866         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13867         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13868         type.
13869         (inf_ptrace_target::attach): Update.
13870         (inf_ptrace_target::files_info): Update.
13871         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13872         type.
13873         (go32_nat_target::pid_to_str): Change return type.
13874         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13875         (gnu_nat_target::wait): Update.
13876         (gnu_nat_target::wait): Update.
13877         (gnu_nat_target::resume): Update.
13878         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13879         (fbsd_nat_target::wait): Update.
13880         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13881         type.
13882         (darwin_nat_target::attach): Update.
13883         * corelow.c (class core_target) <pid_to_str>: Change return type.
13884         (core_target::pid_to_str): Change return type.
13885         * target.c (normal_pid_to_str): Change return type.
13886         (default_pid_to_str): Likewise.
13887         (target_pid_to_str): Change return type.
13888         (target_translate_tls_address): Update.
13889         (target_announce_detach): Update.
13890         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13891         return type.
13892         (bsd_uthread_target::pid_to_str): Change return type.
13893         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13894         type.
13895         (bsd_kvm_target::pid_to_str): Change return type.
13896         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13897         return type.
13898         (aix_thread_target::pid_to_str): Change return type.
13899         * target.h (struct target_ops) <pid_to_str>: Change return type.
13900         (target_pid_to_str, normal_pid_to_str): Likewise.
13901         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13902         type.
13903         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13904         type.
13905         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13906         return type.
13907         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13908         type.
13909         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13910         type.
13911         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13912         return type.
13913
13914 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13915
13916         * NEWS: Mention that the new default MI version is 3.  Mention
13917         changes to the output of commands and events that deal with
13918         multi-location breakpoints.
13919         * breakpoint.c: Include "mi/mi-out.h".
13920         (print_one_breakpoint): Change output syntax if using MI version
13921         >= 3.
13922         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13923         New.
13924         (mi_multi_location_breakpoint_output_fixed): New.
13925         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13926         (mi_cmd_fix_multi_location_breakpoint_output): New.
13927         (mi_multi_location_breakpoint_output_fixed): New.
13928         * mi/mi-cmds.c (mi_cmds): Register command
13929         -fix-multi-location-breakpoint-output.
13930         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13931         interpreter "mi".
13932
13933 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13934
13935         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13936         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13937         instantiate mi_ui_out based on interpreter name.
13938         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13939         * mi/mi-main.c (mi_load_progress): Likewise.
13940
13941 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13942
13943         * NEWS: Combine separate "New targets" sections for 8.3.
13944
13945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13946
13947         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13948         (ppcfbsd_init_abi): Install gdbarch
13949         "fetch_tls_load_module_address" and "get_thread_local_address"
13950         methods.
13951
13952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13953
13954         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13955         (riscv_fbsd_init_abi): Install gdbarch
13956         "fetch_tls_load_module_address" and "get_thread_local_address"
13957         methods.
13958
13959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13960
13961         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13962         (i386fbsd_init_abi): Install gdbarch
13963         "fetch_tls_load_module_address" and "get_thread_local_address"
13964         methods.
13965
13966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13967
13968         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13969         (amd64fbsd_init_abi): Install gdbarch
13970         "fetch_tls_load_module_address" and "get_thread_local_address"
13971         methods.
13972
13973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13974
13975         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13976         (struct fbsd_pspace_data): New type.
13977         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13978         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13979         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13980         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13981         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13982
13983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13984
13985         * gdbtypes.c (lookup_struct_elt): New function.
13986         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13987         * gdbtypes.h (struct struct_elt): New type.
13988         (lookup_struct_elt): New prototype.
13989
13990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13991
13992         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13993         remove disabled code block.
13994
13995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13996
13997         * gdbarch.sh (get_thread_local_address): New method.
13998         * gdbarch.h, gdbarch.c: Regenerate.
13999         * target.c (target_translate_tls_address): Use
14000         gdbarch_get_thread_local_address if present instead of
14001         target::get_thread_local_address.
14002
14003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14004
14005         * target.h (target::get_thread_local_address): Update comment.
14006
14007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14008
14009         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14010         objfile->separate_debug_objfile_backlink if not NULL.
14011
14012 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14013
14014         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14015         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14016         (amd64bsd_store_inferior_registers): Likewise.
14017         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14018         Enable segment base registers.
14019         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14020         PT_GETFSBASE and PT_GETGSBASE.
14021         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14022         PT_SETGSBASE.
14023         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14024         segment base registers.
14025         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14026
14027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14028
14029         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14030         Update calls to i386_target_description to add 'segments'
14031         parameter.
14032         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14033         add segment base registers.
14034         * arch/i386.c (i386_create_target_description): Add 'segments'
14035         parameter to enable segment base registers.
14036         * arch/i386.h (i386_create_target_description): Likewise.
14037         * features/i386/32bit-segments.xml: New file.
14038         * features/i386/32bit-segments.c: Generate.
14039         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14040         call to i386_target_description to add 'segments' parameter.
14041         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14042         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14043         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14044         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14045         if feature is present.
14046         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14047         Add 'segments' parameter to call to i386_target_description.
14048         (i386_target_description): Add 'segments' parameter to enable
14049         segment base registers.
14050         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14051         to call to i386_target_description.
14052         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14053         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14054         Define I386_NUM_REGS.
14055         (i386_target_description): Add 'segments' parameter to enable
14056         segment base registers.
14057
14058 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14059
14060         PR/24325
14061         * source-cache.c: #undef open and close, to avoid unresolved
14062         externals during linking.
14063
14064 2019-03-12  Tom Tromey  <tromey@adacore.com>
14065
14066         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14067         const.  Add initializers.
14068         (_initialize_remote): Don't initialize ptid globals.
14069
14070 2019-03-12  Pedro Alves  <palves@redhat.com>
14071
14072         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14073
14074 2019-03-12  Pedro Alves  <palves@redhat.com>
14075
14076         * cp-name-parser.y (main): Remove unused 'len' variable.
14077
14078 2019-03-12  Tom Tromey  <tromey@adacore.com>
14079
14080         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14081         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14082
14083 2019-03-12  Tom Tromey  <tromey@adacore.com>
14084
14085         * linux-nat.c (iterate_over_lwps): Update.
14086         (stop_callback): Remove parameter.
14087         (stop_wait_callback, detach_callback, resume_set_callback)
14088         (select_singlestep_lwp_callback, set_ignore_sigint)
14089         (status_callback, resumed_callback, resume_clear_callback)
14090         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14091         data parameter.
14092         (linux_nat_target::detach, linux_nat_target::resume)
14093         (linux_stop_and_wait_all_lwps, select_event_lwp)
14094         (linux_nat_filter_event, linux_nat_wait_1)
14095         (linux_nat_target::kill, linux_nat_target::stop)
14096         (linux_nat_target::stop): Update.
14097         (linux_nat_resume_callback): Change type.
14098         (resume_stopped_resumed_lwps, count_events_callback)
14099         (select_event_lwp_callback): Likewise.
14100         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14101         * arm-linux-nat.c (struct update_registers_data): Remove.
14102         (update_registers_callback): Change type.
14103         (arm_linux_insert_hw_breakpoint1): Update.
14104         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14105         parameter.
14106         (x86_linux_dr_set_addr): Update.
14107         (x86_linux_dr_set_control): Update.
14108         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14109         (iterate_over_lwps): Use gdb::function_view.
14110         * nat/aarch64-linux-hw-point.c (struct
14111         aarch64_dr_update_callback_param): Remove.
14112         (debug_reg_change_callback): Change type.
14113         (aarch64_notify_debug_reg_change): Update.
14114         * s390-linux-nat.c (s390_refresh_per_info): Update.
14115
14116 2019-03-11  Tom Tromey  <tromey@adacore.com>
14117
14118         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14119         redundant assignment to "this_cu".
14120
14121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14122
14123         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14124
14125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14126
14127         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14128         from...
14129         (rank_one_type): ... this.
14130
14131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14132
14133         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14134         from...
14135         (rank_one_type): ... this.
14136
14137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14138
14139         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14140         from...
14141         (rank_one_type): ... this.
14142
14143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14144
14145         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14146         from...
14147         (rank_one_type): ... this.
14148
14149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14150
14151         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14152         from...
14153         (rank_one_type): ... this.
14154
14155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14156
14157         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14158         from...
14159         (rank_one_type): ... this.
14160
14161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14162
14163         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14164         from...
14165         (rank_one_type): ... this.
14166
14167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14168
14169         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14170         from...
14171         (rank_one_type): ... this.
14172
14173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14174
14175         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14176         from...
14177         (rank_one_type): ... this.
14178
14179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14180
14181         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14182         from...
14183         (rank_one_type): ... this.
14184
14185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14186
14187         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14188         from...
14189         (rank_one_type): ... this.
14190
14191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14192
14193         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14194         from...
14195         (rank_one_type): ... this.
14196
14197 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14198
14199         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14200         inferior-events' shows the example events.
14201
14202 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14203
14204         Support styling on native MS-Windows console
14205
14206         PR/24315
14207         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14208         on MS-Windows if $TERM is not defined.
14209
14210         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14211
14212         * posix-hdep.c (gdb_console_fputs):
14213         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14214         functions.
14215         * ui-file.h (gdb_console_fputs): Add prototype.
14216
14217         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14218         back to fputs only if the former returns zero.
14219
14220 2019-03-07  Tom Tromey  <tom@tromey.com>
14221
14222         * symmisc.c (print_symbol_bcache_statistics): Update.
14223         (print_objfile_statistics): Update.
14224         * symfile.c (allocate_symtab): Update.
14225         * stabsread.c: Don't include bcache.h.
14226         * psymtab.h (struct psymbol_bcache): Don't declare.
14227         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14228         (psymbol_bcache_init, psymbol_bcache_free)
14229         (psymbol_bcache_get_bcache): Don't declare.
14230         * psymtab.c (struct psymbol_bcache): Remove.
14231         (psymtab_storage::psymtab_storage): Update.
14232         (psymtab_storage::~psymtab_storage): Update.
14233         (psymbol_bcache_init, psymbol_bcache_free)
14234         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14235         (add_psymbol_to_bcache): Update.
14236         (allocate_psymtab): Update.
14237         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14238         macro_cache>: No longer pointers.
14239         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14240         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14241         * macrotab.c (macro_bcache): Update.
14242         * macroexp.c: Don't include bcache.h.
14243         * gdbtypes.c (check_types_worklist): Update.
14244         (types_deeply_equal): Remove TRY/CATCH.  Update.
14245         * elfread.c (elf_symtab_read): Update.
14246         * dwarf2read.c: Don't include bcache.h.
14247         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14248         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14249         (print_bcache_statistics, bcache_memory_used): Don't declare.
14250         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14251         methods.  Rename all data members.
14252         * bcache.c (struct bcache): Move to bcache.h.
14253         (bcache::expand_hash_table): Rename from expand_hash_table.
14254         (bcache): Remove.
14255         (bcache::insert): Rename from bcache_full.
14256         (bcache::compare): Rename from bcache_compare.
14257         (bcache_xmalloc): Remove.
14258         (bcache::~bcache): Rename from bcache_xfree.
14259         (bcache::print_statistics): Rename from print_bcache_statistics.
14260         (bcache::memory_used): Rename from bcache_memory_used.
14261
14262 2019-03-07  Pedro Alves  <palves@redhat.com>
14263
14264         * infrun.c (normal_stop): Also check for
14265         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14266
14267 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14268
14269         * f-lang.c (value_from_host_double): Moved to...
14270         * value.c (value_from_host_double): ...here.
14271         * value.h (value_from_host_double): Declare.
14272         * guile/scm-math.c (vlscm_convert_typed_number): Use
14273         value_from_host_double.
14274         (vlscm_convert_number): Likewise.
14275         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14276         * python/py-value.c (convert_value_from_python): Likewise.
14277
14278 2019-03-06  Tom Tromey  <tom@tromey.com>
14279
14280         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14281
14282 2019-03-06  Tom Tromey  <tom@tromey.com>
14283
14284         * utils.h (free_current_contents): Don't declare.
14285         * utils.c (free_current_contents): Remove.
14286
14287 2019-03-06  Tom Tromey  <tom@tromey.com>
14288
14289         * top.c (quit_force): Update.
14290         * main.c (captured_command_loop): Update.
14291         * common/new-op.c (operator new): Update.
14292         * common/common-exceptions.c (struct catcher)
14293         <save_cleanup_chain>: Remove member.
14294         (exceptions_state_mc_init): Update.
14295         (exception_try_scope_entry): Return nullptr.
14296         (exception_try_scope_exit, exception_rethrow)
14297         (throw_exception_sjlj, throw_exception_cxx): Update.
14298         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14299         (all_cleanups, do_cleanups, discard_cleanups)
14300         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14301         (restore_cleanups, restore_final_cleanups): Don't declare.
14302         (do_final_cleanups): Remove parameter.
14303         * common/cleanups.c (cleanup_chain, make_cleanup)
14304         (make_cleanup_dtor, all_cleanups, do_cleanups)
14305         (discard_my_cleanups, discard_cleanups)
14306         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14307         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14308         (null_cleanup): Remove.
14309         (do_final_cleanups): Remove parameter.
14310
14311 2019-03-06  Tom Tromey  <tom@tromey.com>
14312
14313         * remote.c (remote_target::remote_parse_stop_reply): Use
14314         unique_xmalloc_ptr.
14315
14316 2019-03-06  Tom Tromey  <tom@tromey.com>
14317
14318         * stabsread.c (struct stabs_field_info): Rename from field_info.
14319         <list, fnlist>: Add initializers.
14320         <obstack>: New member.
14321         (read_member_functions, read_struct_fields, read_baseclasses):
14322         Allocate on obstack.  Don't use cleanups.
14323         (read_one_struct_field, read_member_functions, read_struct_fields)
14324         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14325         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14326         (read_struct_type): Update.
14327
14328 2019-03-06  Tom Tromey  <tom@tromey.com>
14329
14330         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14331         * common/filestuff.h (make_cleanup_close): Don't declare.
14332         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14333         Remove.
14334
14335 2019-03-06  Tom Tromey  <tom@tromey.com>
14336
14337         * solib-aix.c: Use make_scope_exit.
14338
14339 2019-03-06  Tom Tromey  <tom@tromey.com>
14340
14341         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14342         Use make_scope_exit.
14343
14344 2019-03-06  Tom Tromey  <tom@tromey.com>
14345
14346         * solib-svr4.c (disable_probes_interface): Remove parameter.
14347         (svr4_handle_solib_event): Use make_scope_exit.
14348
14349 2019-03-06  Tom Tromey  <tom@tromey.com>
14350
14351         * remote.c (struct stop_reply_deleter): Remove.
14352         (stop_reply_up): Update.
14353         (struct stop_reply): Derive from notif_event.  Don't typedef.
14354         <regcache>: Now a std::vector.
14355         (stop_reply_xfree): Remove.
14356         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14357         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14358         (remote_target::discard_pending_stop_replies): Use delete.
14359         (remote_target::remote_parse_stop_reply): Update.
14360         (remote_target::process_stop_reply): Update.
14361         * remote-notif.h (struct notif_event): Add virtual destructor.
14362         Remove "dtr" member.
14363         (struct notif_client) <alloc_event>: Return a unique_ptr.
14364         (notif_event_xfree): Don't declare.
14365         (notif_event_up): New typedef.
14366         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14367         (notif_event_xfree, do_notif_event_xfree): Remove.
14368         (remote_notif_state_xfree): Update.
14369
14370 2019-03-06  Tom Tromey  <tom@tromey.com>
14371
14372         * infrun.c (displaced_step_clear_cleanup): Now a
14373         forward_scope_exit type.
14374         (displaced_step_prepare_throw): Update.
14375         (displaced_step_fixup): Update.
14376
14377 2019-03-06  Tom Tromey  <tom@tromey.com>
14378
14379         * inferior.h (class inferior): Update comment.
14380         * gdbthread.h (class thread_info): Update comment.
14381
14382 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14383             Tom Tromey  <tom@tromey.com>
14384
14385         * stabsread.h (struct stab_section_list): Remove.
14386         (coffstab_build_psymtabs): Update.
14387         * dbxread.c (symbuf_sections): Now a std::vector.
14388         (sect_idx): New global.
14389         (fill_symbuf): Update.
14390         (coffstab_build_psymtabs): Change type of stabsects parameter.
14391         Update.
14392         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14393         std::vector.
14394         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14395         (coff_locate_sections): Update.
14396         (coff_symfile_read): Remove cleanups.  Update.
14397         (init_stringtab): Add storage parameter.
14398         (free_stringtab, free_stringtab_cleanup): Remove.
14399         (init_lineno): Add storage parameter.
14400         (free_linetab, free_linetab_cleanup): Remove.
14401
14402 2019-03-06  Pedro Alves  <palves@redhat.com>
14403
14404         * linux-fork.c (fork_info::clobber_regs): Delete.
14405         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14406         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14407         comment.  Adjust.
14408         (scoped_switch_fork_info::scoped_switch_fork_info)
14409         (checkpoint_command, linux_fork_context): Adjust
14410         fork_save_infrun_state calls.
14411
14412 2019-03-06  Pedro Alves  <palves@redhat.com>
14413
14414         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14415         (inf_has_multiple_threads): Return 'bool' and rewrite using
14416         inferior_info::threads().
14417
14418 2019-03-06  Pedro Alves  <palves@redhat.com>
14419
14420         * linux-fork.c: Include <list>.
14421         (fork_list): Now a std::list instance.
14422         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14423         (forks_exist_p, find_last_fork): Adjust.
14424         (new_fork): Delete.
14425         (one_fork_p): New.
14426         (add_fork): Adjust.
14427         (free_fork): Delete, folded into fork_info::~fork_info().
14428         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14429         Adjust.
14430         (init_fork_list): Delete.
14431         (linux_fork_killall, linux_fork_mourn_inferior)
14432         (linux_fork_detach, info_checkpoints_command): Adjust.
14433         (_initialize_linux_fork): No longer call init_fork_list.
14434
14435 2019-03-06  Pedro Alves  <palves@redhat.com>
14436
14437         * linux-fork.c (new_fork): New, split out of ...
14438         (add_fork): ... this.  Return void.  Move "first fork" special
14439         case from here, to ...
14440         (checkpoint_command): ... here.
14441         * linux-linux.h (add_fork): Return void.
14442
14443 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14444
14445         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14446
14447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14448             Chris January  <chris.january@arm.com>
14449             David Lecomber  <david.lecomber@arm.com>
14450
14451         * f-exp.y: New token, UNOP_INTRINSIC.
14452         (exp): New pattern using UNOP_INTRINSIC token.
14453         (f77_keywords): Add 'abs' keyword.
14454         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14455         (value_from_host_double): New function.
14456         (evaluate_subexp_f): Support UNOP_ABS.
14457
14458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14459
14460         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14461         types.
14462
14463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14464
14465         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14466         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14467         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14468
14469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14470
14471         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14472
14473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14474             Chris January  <chris.january@arm.com>
14475
14476         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14477         * f-exp.y: Define 'KIND' token.
14478         (exp): New pattern for KIND expressions.
14479         (ptype): Handle types with a kind extension.
14480         (direct_abs_decl): Extend to spot kind extensions.
14481         (f77_keywords): Add 'kind' to the list.
14482         (push_kind_type): New function.
14483         (convert_to_kind_type): New function.
14484         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14485         * parse.c (operator_length_standard): Likewise.
14486         * parser-defs.h (enum type_pieces): Add tp_kind.
14487         * std-operator.def: Add UNOP_KIND.
14488
14489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14490
14491         * f-exp.y (f_parse): Set yydebug.
14492
14493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14494
14495         * f-lang.c (evaluate_subexp_f): New function.
14496         (exp_descriptor_f): New global.
14497         (f_language_defn): Use exp_descriptor_f instead of
14498         exp_descriptor_standard.
14499
14500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14501
14502         * f-exp.y (struct token): Add comments.
14503         (dot_ops): Remove uppercase versions and the end marker.
14504         (f77_keywords): Likewise.
14505         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14506         entries in the dot_ops array are case insensitive, and use
14507         strncasecmp to compare strings.  Also some whitespace cleanup in
14508         this area.  Similar for the f77_keywords array, except entries in
14509         this list might be case sensitive.
14510
14511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14512
14513         * f-exp.y (struct f77_boolean_val): Add comments.
14514         (boolean_values): Remove uppercase versions, and end marker.
14515         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14516         and use strncasecmp to achieve case insensitivity.  Additionally,
14517         perform whitespace cleanup around this code.
14518
14519 2019-03-06  Tom Tromey  <tromey@adacore.com>
14520
14521         * remote-sim.c (gdbsim_target_open): Use result of
14522         gdb_argv::release.
14523
14524 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14525         Dirk Schubert  <dirk.schubert@arm.com>
14526         Chris January  <chris.january@arm.com>
14527
14528         * eval.c (evaluate_subexp_standard): Call Fortran argument
14529         wrapping logic.
14530         * f-lang.c (struct value): A value which can be passed into a
14531         Fortran function call.
14532         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14533         where appropriate.
14534         (struct type): Value ready for a Fortran function call.
14535         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14536         is needed.
14537         * f-lang.h (fortran_argument_convert): Declaration.
14538         (fortran_preserve_arg_pointer): Declaration.
14539         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14540
14541 2019-03-05  Tom Tromey  <tromey@adacore.com>
14542
14543         * python/py-prettyprint.c (print_string_repr): Remove #if.
14544         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14545
14546 2019-03-05  Tom Tromey  <tromey@adacore.com>
14547
14548         * target.c (the_dummy_target): Move later.  Change type to
14549         "dummy_target".
14550         (initialize_targets): Don't initialize the_dummy_target.
14551
14552 2019-03-05  Tom Tromey  <tromey@adacore.com>
14553
14554         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14555         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14556
14557 2019-03-05  Tom Tromey  <tromey@adacore.com>
14558
14559         * windows-nat.c (windows_nat_target::attach)
14560         (windows_nat_target::detach): Don't call gdb_flush.
14561         * valprint.c (generic_val_print, val_print, val_print_string):
14562         Don't call gdb_flush.
14563         * utils.c (defaulted_query): Don't call gdb_flush.
14564         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14565         * target.c (target_announce_detach): Don't call gdb_flush.
14566         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14567         * remote.c (extended_remote_target::attach): Don't call
14568         gdb_flush.
14569         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14570         * printcmd.c (do_examine): Don't call gdb_flush.
14571         (info_display_command): Don't call gdb_flush.
14572         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14573         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14574         * memattr.c (info_mem_command): Don't call gdb_flush.
14575         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14576         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14577         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14578         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14579         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14580         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14581         (gnu_nat_target::detach): Don't call gdb_flush.
14582         * f-valprint.c (f_val_print): Don't call gdb_flush.
14583         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14584         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14585         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14586         gdb_flush.
14587         * c-valprint.c (c_val_print): Don't call gdb_flush.
14588         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14589
14590 2019-03-05  Tom Tromey  <tromey@adacore.com>
14591
14592         * varobj.c (update_dynamic_varobj_children): Update.
14593         (install_default_visualizer): Use reset, not release.
14594         * value.c (set_internalvar): Update.
14595         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14596         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14597         ATTRIBUTE_UNUSED_RESULT.
14598
14599 2019-03-05  Tom Tromey  <tromey@adacore.com>
14600
14601         * remote.c (class scoped_remote_fd) <release>: Add
14602         ATTRIBUTE_UNUSED_RESULT.
14603
14604 2019-03-05  Tom Tromey  <tromey@adacore.com>
14605
14606         * macroexp.c (struct macro_buffer) <release>: Add
14607         ATTRIBUTE_UNUSED_RESULT.
14608
14609 2019-03-05  Tom Tromey  <tromey@adacore.com>
14610
14611         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14612         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14613         ATTRIBUTE_UNUSED_RESULT.
14614
14615 2019-03-05  Tom Tromey  <tromey@adacore.com>
14616
14617         * common/scoped_fd.h (class scoped_fd) <release>: Add
14618         ATTRIBUTE_UNUSED_RESULT.
14619
14620 2019-03-05  Tom Tromey  <tromey@adacore.com>
14621
14622         * parser-defs.h (struct parser_state) <release>: Add
14623         ATTRIBUTE_UNUSED_RESULT.
14624
14625 2019-03-05  Tom Tromey  <tromey@adacore.com>
14626
14627         * utils.h (class gdb_argv) <release>: Add
14628         ATTRIBUTE_UNUSED_RESULT.
14629         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14630
14631 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14632
14633         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14634         for-loop range, to avoid compiler warnings.
14635
14636         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14637         avoid compiler warnings about unused variables.
14638
14639         * NEWS: Mention end of support for native debugging on MS-Windows
14640         before XP.
14641
14642         PR gdb/24292
14643         * common/netstuff.c:
14644         * gdbserver/gdbreplay.c
14645         * gdbserver/remote-utils.c:
14646         * ser-tcp.c:
14647         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14648         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14649         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14650         'getaddrinfo' and 'freeaddrinfo' were not available before
14651         Windows XP, and mingw.org's MinGW headers by default define
14652         _WIN32_WINNT to 0x500.
14653
14654 2019-03-01  Gary Benson <gbenson@redhat.com>
14655
14656         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14657
14658 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14659             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14660
14661         PR gdb/8527
14662         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14663         set_sigint_trap, clear_sigint_trap.
14664
14665 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14666
14667         * target.c (target_detach): Clear the regcache and the
14668         frame cache.
14669
14670 2019-02-27  Pedro Alves  <palves@redhat.com>
14671
14672         * utils.c (set_screen_size): When we cap the height/width sizes,
14673         tweak the corresponding command variable to show "unlimited":
14674
14675 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14676             Pedro Alves  <palves@redhat.com>
14677
14678         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14679         before calling rl_set_screen_size.
14680
14681 2019-02-27  Tom Tromey  <tromey@adacore.com>
14682
14683         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14684         define.
14685         * python/py-value.c: Remove Python 2.4 workaround.
14686         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14687         workaround.
14688         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14689         Python 2.4 workaround.
14690         * python/python-internal.h: Remove Python 2.4 comment.
14691         (Py_ssize_t): Don't define.
14692         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14693         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14694         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14695         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14696         * python/python.c (do_start_initialization): Remove Python 2.4
14697         workaround.
14698         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14699         (print_children): Remove Python 2.4 workaround.
14700         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14701         workaround.
14702         (CHARBUFFERPROC_NAME): Remove.
14703         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14704         Python 2.4 workaround.
14705
14706 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14707
14708         * NEWS: Note minimum Python version.
14709
14710 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14711
14712         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14713         code from these functions.  Remove corresponding ifdefs.  Use
14714         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14715         Remove gotos and target of gotos.
14716         (infpy_search_memory): Likewise.
14717
14718 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14719
14720         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14721         (hppa_gdbarch_init): Don't register deleted functions with
14722         gdbarch.
14723
14724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14725
14726         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14727         (h8300_unwind_sp): Delete.
14728         (h8300_dummy_id): Delete.
14729         (h8300_gdbarch_init): Don't register deleted functions with
14730         gdbarch.
14731
14732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14733
14734         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14735         (ft32_unwind_pc): Delete.
14736         (ft32_unwind_sp): Delete.
14737         (ft32_gdbarch_init): Don't register deleted functions with
14738         gdbarch.
14739
14740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14741
14742         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14743         (frv_unwind_pc): Delete.
14744         (frv_unwind_sp): Delete.
14745         (frv_gdbarch_init): Don't register deleted functions with
14746         gdbarch.
14747
14748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14749
14750         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14751         (riscv_unwind_pc): Delete.
14752         (riscv_unwind_sp): Delete.
14753         (riscv_gdbarch_init): Don't register deleted functions with
14754         gdbarch.
14755
14756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14757
14758         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14759         (csky_unwind_pc): Delete.
14760         (csky_unwind_sp): Delete.
14761         (csky_gdbarch_init): Don't register deleted functions with
14762         gdbarch.
14763
14764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14765
14766         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14767         (cris_unwind_pc): Delete.
14768         (cris_unwind_sp): Delete.
14769         (cris_gdbarch_init): Don't register deleted functions with
14770         gdbarch.
14771
14772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14773
14774         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14775         (bfin_unwind_pc): Delete.
14776         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14777
14778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14779
14780         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14781         (arm_unwind_pc): Delete.
14782         (arm_unwind_sp): Delete.
14783         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14784
14785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14786
14787         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14788         (arc_unwind_pc): Delete.
14789         (arc_unwind_sp): Delete.
14790         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14791
14792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14793
14794         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14795         (alpha_unwind_pc): Delete.
14796         (alpha_gdbarch_init): Don't register deleted functions with
14797         gdbarch.
14798
14799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14800
14801         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14802         (aarch64_unwind_pc): Delete.
14803         (aarch64_unwind_sp): Delete.
14804         (aarch64_gdbarch_init): Don't register deleted functions with
14805         gdbarch.
14806
14807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14808
14809         * gdbtypes.c (type_align): Don't consider static members when
14810         computing structure alignment.
14811
14812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14813
14814         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14815         return 0 for other types.
14816         * arch-utils.c (default_type_align): Always return 0.
14817         * gdbarch.h: Regenerate.
14818         * gdbarch.sh (type_align): Extend comment.
14819         * gdbtypes.c (type_align): Add additional comments, always call
14820         gdbarch_type_align before applying the default rules.
14821         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14822         generic code will then apply a suitable default.
14823         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14824         types, return 0 for other types.
14825
14826 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14827
14828         * NEWS: Create a new section for the next release branch.
14829         Rename the section of the current branch, now that it has
14830         been cut.
14831
14832 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14833
14834         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14835         * version.in: Bump version to 8.3.50.DATE-git.
14836
14837 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14838
14839         * aix-thread.c (ptid_cmp): Remove unused variable.
14840         (get_signaled_thread): Likewise.
14841         (store_regs_user_thread): Likewise.
14842         (store_regs_kernel_thread): Likewise.
14843         (fetch_regs_kernel_thread): Remove shadowed variable.
14844
14845 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14846
14847         * features/riscv/32bit-cpu.xml: Add register numbers.
14848         * features/riscv/32bit-fpu.c: Regenerate.
14849         * features/riscv/32bit-fpu.xml: Add register numbers.
14850         * features/riscv/64bit-cpu.xml: Add register numbers.
14851         * features/riscv/64bit-fpu.c: Regenerate.
14852         * features/riscv/64bit-fpu.xml: Add register numbers.
14853
14854 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14855
14856         * NEWS: Mention two argument form of gdb.Value constructor.
14857         * python/py-value.c (convert_buffer_and_type_to_value): New
14858         function.
14859         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14860         Add support for handling an optional second argument.  Call
14861         convert_buffer_and_type_to_value as appropriate.
14862         * python/python-internal.h (Py_buffer_deleter): New struct.
14863         (Py_buffer_up): New typedef.
14864
14865 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14866
14867         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14868         instead of releasing ownership.
14869
14870 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14871
14872         * dwarf2read.c (open_and_init_dwp_file): Call
14873         elf_numsections instead of bfd_count_sections to initialize
14874         dwp_file->num_sections.
14875
14876 2019-02-25  Tom Tromey  <tromey@adacore.com>
14877
14878         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14879
14880 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14881
14882         * gcore.in: Add '--readnever' option when invoking GDB.
14883
14884 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14885
14886         * MAINTAINERS: Update my email address.
14887
14888 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14889
14890         * build-id.c (build_id_to_debug_bfd_1): New function.
14891         (build_id_to_debug_bfd): Look for separate debug file in
14892         sysroot.
14893
14894 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14895
14896         * gdbarch.sh: Update the copyright year range that is placed into
14897         generated files.
14898
14899 2019-02-22  Keith Seitz  <keiths@redhat.com>
14900
14901         PR symtab/23853
14902         * linespec.c (create_sals_line_offset): Search for the default
14903         symtab's filename instead of its fullname.
14904
14905 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14906
14907         * NEWS: Update style defaults.
14908
14909 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14910
14911         * main.c (captured_main_1): Disable styling in batch mode.
14912
14913 2019-02-20  Tom Tromey  <tom@tromey.com>
14914
14915         * symtab.c (symtab_symbol_info): Fix typos.
14916
14917 2019-02-20  Tom Tromey  <tromey@adacore.com>
14918
14919         * findcmd.c (_initialize_mem_search): Use upper case for
14920         metasyntactic variables.
14921
14922 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14923
14924         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14925         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14926
14927 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14928
14929         * top.h (source_file_name): Change to std::string.
14930         * top.c (source_file_name): Likewise.
14931         (command_line_input): Adjust.
14932         * cli/cli-script.c (script_from_file): Adjust.
14933
14934 2019-02-19  Tom Tromey  <tromey@adacore.com>
14935
14936         * ravenscar-thread.c
14937         (ravenscar_thread_target::update_thread_list): Don't call
14938         ada_build_task_list.
14939         * ada-lang.h (ada_build_task_list): Don't declare.
14940         * ada-tasks.c (struct ada_tasks_inferior_data)
14941         <task_list_valid_p>: Now bool.
14942         (read_known_tasks, ada_task_list_changed)
14943         (ada_tasks_invalidate_inferior_data): Update.
14944         (read_known_tasks_array): Return bool.
14945         (read_known_tasks_list): Likewise.
14946         (read_known_tasks): Return void.
14947         (ada_build_task_list): Now static.
14948
14949 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14950
14951         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14952         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14953
14954 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14955
14956         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14957         variant for ada_tasks_pspace_data_handle and
14958         ada_tasks_inferior_data_handle.
14959         (ada_tasks_pspace_data_cleanup): New function.
14960         (ada_tasks_inferior_data_cleanup): New function.
14961
14962 2019-02-17  Tom Tromey  <tom@tromey.com>
14963
14964         * macrotab.h (macro_source_fullname): Return a std::string.
14965         * macrotab.c (macro_include, check_for_redefinition)
14966         (macro_undef, macro_lookup_definition, foreach_macro)
14967         (foreach_macro_in_scope): Update.
14968         (macro_source_fullname): Return a std::string.
14969         * macrocmd.c (show_pp_source_pos): Update.
14970
14971 2019-02-17  Tom Tromey  <tom@tromey.com>
14972
14973         * macrocmd.c (show_pp_source_pos): Style the file names.
14974
14975 2019-02-17  Tom Tromey  <tom@tromey.com>
14976
14977         PR tui/24197:
14978         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14979
14980 2019-02-17  Tom Tromey  <tom@tromey.com>
14981
14982         * ada-lang.c (user_select_syms): Use filtered printing.
14983         * utils.c (wrap_style): New global.
14984         (desired_style): Remove.
14985         (emit_style_escape): Add stream parameter.
14986         (set_output_style, reset_terminal_style, prompt_for_continue):
14987         Update.
14988         (flush_wrap_buffer): Only flush gdb_stdout.
14989         (wrap_here): Set wrap_style.
14990         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14991         treat escape sequences as a character.  Change when wrap buffer is
14992         flushed.
14993         (fputs_styled): Do not set the output style when the default is
14994         requested.
14995         * ui-style.h (struct ui_file_style) <is_default>: New method.
14996         * source.c (print_source_lines_base): Emit escape sequences in one
14997         piece.
14998
14999 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15000
15001         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15002         integers and enumeration types.
15003
15004 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15005
15006         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15007         instead of lookup_symbol_in_language
15008         (do_exact_match): New function.
15009         (ada_get_symbol_name_matcher): Return do_exact_match when
15010         doing a verbatim match.
15011
15012 2019-02-15  Tom Tromey  <tromey@adacore.com>
15013
15014         * ravenscar-thread.c (ravenscar_thread_target::resume)
15015         (ravenscar_thread_target::wait): Special case wildcard requests.
15016
15017 2019-02-15  Tom Tromey  <tromey@adacore.com>
15018
15019         * ravenscar-thread.c (base_ptid): Remove.
15020         (struct ravenscar_thread_target) <close>: New method.
15021         <m_base_ptid>: New member.
15022         <update_inferior_ptid, active_task, task_is_currently_active,
15023         runtime_initialized>: Declare methods.
15024         <ravenscar_thread_target>: Add constructor.
15025         (ravenscar_thread_target::task_is_currently_active)
15026         (ravenscar_thread_target::update_inferior_ptid)
15027         (ravenscar_runtime_initialized): Rename.  Now methods.
15028         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15029         (ravenscar_thread_target::update_thread_list): Update.
15030         (ravenscar_thread_target::active_task): Now method.
15031         (ravenscar_thread_target::store_registers)
15032         (ravenscar_thread_target::prepare_to_store)
15033         (ravenscar_thread_target::prepare_to_store)
15034         (ravenscar_thread_target::mourn_inferior): Update.
15035         (ravenscar_inferior_created): Use "new" to create target.
15036         (ravenscar_thread_target::get_ada_task_ptid): Update.
15037         (_initialize_ravenscar): Don't initialize base_ptid.
15038         (ravenscar_ops): Remove global.
15039
15040 2019-02-15  Tom Tromey  <tromey@adacore.com>
15041
15042         * target.h (push_target): Declare new overload.
15043         * target.c (push_target): New overload, taking an rvalue reference.
15044         * remote.c (remote_target::open_1): Use push_target overload.
15045         * corelow.c (core_target_open): Use push_target overload.
15046
15047 2019-02-15  Tom Tromey  <tromey@adacore.com>
15048
15049         * ravenscar-thread.c (is_ravenscar_task)
15050         (ravenscar_task_is_currently_active): Return bool.
15051         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15052         (_initialize_ravenscar): Remove "(void)".
15053         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15054         Return bool.
15055
15056 2019-02-15  Tom Tromey  <tromey@adacore.com>
15057
15058         * ravenscar-thread.c (ravenscar_runtime_initializer)
15059         (has_ravenscar_runtime, get_running_thread_id)
15060         (ravenscar_thread_target::resume): Fix indentation.
15061
15062 2019-02-15  Tom Tromey  <tromey@adacore.com>
15063
15064         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15065         from ravenscar_arch_ops.
15066         (sparc_ravenscar_ops::fetch_registers)
15067         (sparc_ravenscar_ops::store_registers): Now methods.
15068         (sparc_ravenscar_prepare_to_store): Remove.
15069         (sparc_ravenscar_ops): Redefine.
15070         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15071         methods and destructor.  Remove members.
15072         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15073         (ravenscar_thread_target::store_registers)
15074         (ravenscar_thread_target::prepare_to_store): Update.
15075         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15076         Remove.
15077         (struct ppc_ravenscar_powerpc_ops): Derive from
15078         ravenscar_arch_ops.
15079         (ppc_ravenscar_powerpc_ops::fetch_registers)
15080         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15081         (ppc_ravenscar_powerpc_ops): Redefine.
15082         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15083         (ppc_ravenscar_e500_ops::fetch_registers)
15084         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15085         (ppc_ravenscar_e500_ops): Redefine.
15086         * aarch64-ravenscar-thread.c
15087         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15088         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15089         (aarch64_ravenscar_fetch_registers)
15090         (aarch64_ravenscar_store_registers): Now methods.
15091         (aarch64_ravenscar_ops): Redefine.
15092
15093 2019-02-15  Tom Tromey  <tromey@adacore.com>
15094
15095         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15096         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15097         (ravenscar_thread_target::stopped_by_watchpoint)
15098         (ravenscar_thread_target::stopped_data_address)
15099         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15100
15101 2019-02-15  Tom Tromey  <tromey@adacore.com>
15102
15103         * ravenscar-thread.c: Fix some typos.
15104
15105 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15106             Tom Tromey  <tromey@adacore.com>
15107
15108         * ada-lang.c (ada_exception_sal): Change addr_string to a
15109         std::string.
15110         (create_ada_exception_catchpoint): Update.
15111
15112 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15113             Tom Tromey  <tromey@adacore.com>
15114
15115         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15116         (bp_location_ops): Remove.
15117         (base_breakpoint_allocate_location): Update.
15118         (free_bp_location): Update.
15119         * ada-lang.c (class ada_catchpoint_location)
15120         <ada_catchpoint_location>: Remove ops parameter.
15121         (ada_catchpoint_location_dtor): Remove.
15122         (ada_catchpoint_location_ops): Remove.
15123         (allocate_location_exception): Update.
15124         * breakpoint.h (struct bp_location_ops): Remove.
15125         (class bp_location) <bp_location>: Remove bp_location_ops
15126         parameter.
15127         <~bp_location>: Add destructor.
15128         <ops>: Remove.
15129
15130 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15131             Pedro Alves  <palves@redhat.com>
15132
15133         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15134         'PATH_MAX'.
15135
15136 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15137             Samuel Thibault  <samuel.thibault@gnu.org>
15138             Thomas Schwinge  <thomas@codesourcery.com>
15139
15140         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15141         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15142
15143 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15144
15145         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15146         (check_empty): Use "const char *".
15147
15148         * gnu-nat.c (gnu_nat_target::detach): Instead of
15149         'detach_inferior (pid)' call
15150         'detach_inferior (find_inferior_pid (pid))'.
15151
15152         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15153         'nat/fork-inferior.o'.
15154         * gnu-nat.c: #include "nat/fork-inferior.h".
15155
15156         * gnu-nat.c (gnu_nat_target::detach): Instead of
15157         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15158         * gnu-nat.h: #include "inf-child.h".
15159         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15160         'i386_gnu_nat_target::fetch_registers'.
15161         (gnu_store_registers): Rename/move to
15162         'i386_gnu_nat_target::store_registers'.
15163
15164         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15165         * gnu-nat.h (mach_thread_info): New function.
15166         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15167
15168         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15169
15170 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15171
15172         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15173
15174 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15175
15176         * windows-nat.c (windows_add_thread): Add new parameter
15177         "main_thread_p" with default value set to false.  Update
15178         function documentation as well as all callers.
15179         (windows_delete_thread): Likewise.
15180         (fake_create_process): Update call to windows_add_thread.
15181         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15182         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15183         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15184         call to windows_delete_thread.
15185
15186 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15187
15188         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15189
15190 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15191
15192         * symfile.c (find_separate_debug_file): Use canonical path of
15193         sysroot with child_path instead of gdb_sysroot if it is valid.
15194
15195 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15196
15197         * symfile.c (find_separate_debug_file): Use child_path to
15198         determine if an object file is under a sysroot.
15199
15200 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15201
15202         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15203         unittests/child-path-selftests.c.
15204         * common/pathstuff.c (child_path): New function.
15205         * common/pathstuff.h (child_path): New prototype.
15206         * unittests/child-path-selftests.c: New file.
15207
15208 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15209
15210         * symfile.c (find_separate_debug_file): Look for separate debug
15211         files in debug directories under the sysroot.
15212
15213 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15214
15215         * symtab.h (struct minimal_symbol data_p): New const method.
15216         (struct minimal_symbol text_p): Likewise.
15217         * symtab.c (output_source_filename): Use file name style
15218         to print file name.
15219         (print_symbol_info): Likewise.
15220         (print_msymbol_info): Use address style to print addresses.
15221         Use function name style to print executable text symbols.
15222         (expand_symtab_containing_pc): Use data_p.
15223         (find_pc_sect_compunit_symtab): Likewise.
15224
15225 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15226
15227         * breakpoint.c (describe_other_breakpoints): Use address style
15228         to print addresses.
15229         (say_where): Likewise.
15230
15231 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15232
15233         * ada-typeprint.c (print_func_type): Print function name
15234         style to print function name.
15235         * c-typeprint.c (c_print_type_1): Likewise.
15236
15237 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15238
15239         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15240         for execve.
15241
15242 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15243
15244         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15245         type_stack.
15246
15247 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15248
15249         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15250         TYPE_CODE_REF types.
15251
15252 2019-02-08  Jim Wilson  <jimw@sifive.com>
15253
15254         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15255         (riscv_linux_fregset): New.
15256         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15257
15258 2019-02-07  Tom Tromey  <tom@tromey.com>
15259
15260         * thread.c (thread_cancel_execution_command): Update.
15261         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15262         methods.
15263         (struct thread_fsm_ops): Remove.
15264         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15265         (thread_fsm_should_stop, thread_fsm_return_value)
15266         (thread_fsm_set_finished, thread_fsm_finished_p)
15267         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15268         Don't declare.
15269         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15270         * infrun.c (clear_proceed_status_thread)
15271         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15272         (print_stop_event): Update.
15273         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15274         Add constructor.
15275         (step_command_fsm_ops): Remove.
15276         (new_step_command_fsm): Remove.
15277         (step_1): Update.
15278         (step_command_fsm::should_stop): Rename from
15279         step_command_fsm_should_stop.
15280         (step_command_fsm::clean_up): Rename from
15281         step_command_fsm_clean_up.
15282         (step_command_fsm::do_async_reply_reason): Rename from
15283         step_command_fsm_async_reply_reason.
15284         (struct until_next_fsm): Inherit from thread_fsm.  Add
15285         constructor.
15286         (until_next_fsm_ops): Remove.
15287         (new_until_next_fsm): Remove.
15288         (until_next_fsm::should_stop): Rename from
15289         until_next_fsm_should_stop.
15290         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15291         (until_next_fsm::do_async_reply_reason): Rename from
15292         until_next_fsm_async_reply_reason.
15293         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15294         constructor.  Change type of breakpoint.
15295         (finish_command_fsm_ops): Remove.
15296         (new_finish_command_fsm): Remove.
15297         (finish_command_fsm::should_stop): Rename from
15298         finish_command_fsm_should_stop.
15299         (finish_command_fsm::clean_up): Rename from
15300         finish_command_fsm_clean_up.
15301         (finish_command_fsm::return_value): Rename from
15302         finish_command_fsm_return_value.
15303         (finish_command_fsm::do_async_reply_reason): Rename from
15304         finish_command_fsm_async_reply_reason.
15305         (finish_command): Update.
15306         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15307         Add constructor.
15308         (call_thread_fsm_ops): Remove.
15309         (call_thread_fsm::call_thread_fsm): Rename from
15310         new_call_thread_fsm.
15311         (call_thread_fsm::should_stop): Rename from
15312         call_thread_fsm_should_stop.
15313         (call_thread_fsm::should_notify_stop): Rename from
15314         call_thread_fsm_should_notify_stop.
15315         (run_inferior_call, call_function_by_hand_dummy): Update.
15316         * cli/cli-interp.c (should_print_stop_to_console): Update.
15317         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15318         Add constructor.  Change type of location_breakpoint,
15319         caller_breakpoint.
15320         (until_break_fsm_ops): Remove.
15321         (new_until_break_fsm): Remove.
15322         (until_break_fsm::should_stop): Rename from
15323         until_break_fsm_should_stop.
15324         (until_break_fsm::clean_up): Rename from
15325         until_break_fsm_clean_up.
15326         (until_break_fsm::do_async_reply_reason): Rename from
15327         until_break_fsm_async_reply_reason.
15328         (until_break_command): Update.
15329         * thread-fsm.c: Remove.
15330         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15331
15332 2019-02-07  Tom Tromey  <tom@tromey.com>
15333
15334         * yy-remap.h: Add include guard.
15335         * xtensa-tdep.h: Add include guard.
15336         * xcoffread.h: Rename include guard.
15337         * varobj-iter.h: Add include guard.
15338         * tui/tui.h: Rename include guard.
15339         * tui/tui-winsource.h: Rename include guard.
15340         * tui/tui-wingeneral.h: Rename include guard.
15341         * tui/tui-windata.h: Rename include guard.
15342         * tui/tui-win.h: Rename include guard.
15343         * tui/tui-stack.h: Rename include guard.
15344         * tui/tui-source.h: Rename include guard.
15345         * tui/tui-regs.h: Rename include guard.
15346         * tui/tui-out.h: Rename include guard.
15347         * tui/tui-layout.h: Rename include guard.
15348         * tui/tui-io.h: Rename include guard.
15349         * tui/tui-hooks.h: Rename include guard.
15350         * tui/tui-file.h: Rename include guard.
15351         * tui/tui-disasm.h: Rename include guard.
15352         * tui/tui-data.h: Rename include guard.
15353         * tui/tui-command.h: Rename include guard.
15354         * tic6x-tdep.h: Add include guard.
15355         * target/waitstatus.h: Rename include guard.
15356         * target/wait.h: Rename include guard.
15357         * target/target.h: Rename include guard.
15358         * target/resume.h: Rename include guard.
15359         * target-float.h: Rename include guard.
15360         * stabsread.h: Add include guard.
15361         * rs6000-tdep.h: Add include guard.
15362         * riscv-fbsd-tdep.h: Add include guard.
15363         * regformats/regdef.h: Rename include guard.
15364         * record.h: Rename include guard.
15365         * python/python.h: Rename include guard.
15366         * python/python-internal.h: Rename include guard.
15367         * python/py-stopevent.h: Rename include guard.
15368         * python/py-ref.h: Rename include guard.
15369         * python/py-record.h: Rename include guard.
15370         * python/py-record-full.h: Rename include guard.
15371         * python/py-record-btrace.h: Rename include guard.
15372         * python/py-instruction.h: Rename include guard.
15373         * python/py-events.h: Rename include guard.
15374         * python/py-event.h: Rename include guard.
15375         * procfs.h: Add include guard.
15376         * proc-utils.h: Add include guard.
15377         * p-lang.h: Add include guard.
15378         * or1k-tdep.h: Rename include guard.
15379         * observable.h: Rename include guard.
15380         * nto-tdep.h: Rename include guard.
15381         * nat/x86-linux.h: Rename include guard.
15382         * nat/x86-linux-dregs.h: Rename include guard.
15383         * nat/x86-gcc-cpuid.h: Add include guard.
15384         * nat/x86-dregs.h: Rename include guard.
15385         * nat/x86-cpuid.h: Rename include guard.
15386         * nat/ppc-linux.h: Rename include guard.
15387         * nat/mips-linux-watch.h: Rename include guard.
15388         * nat/linux-waitpid.h: Rename include guard.
15389         * nat/linux-ptrace.h: Rename include guard.
15390         * nat/linux-procfs.h: Rename include guard.
15391         * nat/linux-osdata.h: Rename include guard.
15392         * nat/linux-nat.h: Rename include guard.
15393         * nat/linux-namespaces.h: Rename include guard.
15394         * nat/linux-btrace.h: Rename include guard.
15395         * nat/glibc_thread_db.h: Rename include guard.
15396         * nat/gdb_thread_db.h: Rename include guard.
15397         * nat/gdb_ptrace.h: Rename include guard.
15398         * nat/fork-inferior.h: Rename include guard.
15399         * nat/amd64-linux-siginfo.h: Rename include guard.
15400         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15401         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15402         * nat/aarch64-linux.h: Rename include guard.
15403         * nat/aarch64-linux-hw-point.h: Rename include guard.
15404         * mn10300-tdep.h: Add include guard.
15405         * mips-linux-tdep.h: Add include guard.
15406         * mi/mi-parse.h: Rename include guard.
15407         * mi/mi-out.h: Rename include guard.
15408         * mi/mi-main.h: Rename include guard.
15409         * mi/mi-interp.h: Rename include guard.
15410         * mi/mi-getopt.h: Rename include guard.
15411         * mi/mi-console.h: Rename include guard.
15412         * mi/mi-common.h: Rename include guard.
15413         * mi/mi-cmds.h: Rename include guard.
15414         * mi/mi-cmd-break.h: Rename include guard.
15415         * m2-lang.h: Add include guard.
15416         * location.h: Rename include guard.
15417         * linux-record.h: Rename include guard.
15418         * linux-nat.h: Add include guard.
15419         * linux-fork.h: Add include guard.
15420         * i386-darwin-tdep.h: Rename include guard.
15421         * hppa-linux-offsets.h: Add include guard.
15422         * guile/guile.h: Rename include guard.
15423         * guile/guile-internal.h: Rename include guard.
15424         * gnu-nat.h: Rename include guard.
15425         * gdb-stabs.h: Rename include guard.
15426         * frv-tdep.h: Add include guard.
15427         * f-lang.h: Add include guard.
15428         * event-loop.h: Add include guard.
15429         * darwin-nat.h: Rename include guard.
15430         * cp-abi.h: Rename include guard.
15431         * config/sparc/nm-sol2.h: Rename include guard.
15432         * config/nm-nto.h: Rename include guard.
15433         * config/nm-linux.h: Add include guard.
15434         * config/i386/nm-i386gnu.h: Rename include guard.
15435         * config/djgpp/nl_types.h: Rename include guard.
15436         * config/djgpp/langinfo.h: Rename include guard.
15437         * compile/gcc-cp-plugin.h: Add include guard.
15438         * compile/gcc-c-plugin.h: Add include guard.
15439         * compile/compile.h: Rename include guard.
15440         * compile/compile-object-run.h: Rename include guard.
15441         * compile/compile-object-load.h: Rename include guard.
15442         * compile/compile-internal.h: Rename include guard.
15443         * compile/compile-cplus.h: Rename include guard.
15444         * compile/compile-c.h: Rename include guard.
15445         * common/xml-utils.h: Rename include guard.
15446         * common/x86-xstate.h: Rename include guard.
15447         * common/version.h: Rename include guard.
15448         * common/vec.h: Rename include guard.
15449         * common/tdesc.h: Rename include guard.
15450         * common/selftest.h: Rename include guard.
15451         * common/scoped_restore.h: Rename include guard.
15452         * common/scoped_mmap.h: Rename include guard.
15453         * common/scoped_fd.h: Rename include guard.
15454         * common/safe-iterator.h: Rename include guard.
15455         * common/run-time-clock.h: Rename include guard.
15456         * common/refcounted-object.h: Rename include guard.
15457         * common/queue.h: Rename include guard.
15458         * common/ptid.h: Rename include guard.
15459         * common/print-utils.h: Rename include guard.
15460         * common/preprocessor.h: Rename include guard.
15461         * common/pathstuff.h: Rename include guard.
15462         * common/observable.h: Rename include guard.
15463         * common/netstuff.h: Rename include guard.
15464         * common/job-control.h: Rename include guard.
15465         * common/host-defs.h: Rename include guard.
15466         * common/gdb_wait.h: Rename include guard.
15467         * common/gdb_vecs.h: Rename include guard.
15468         * common/gdb_unlinker.h: Rename include guard.
15469         * common/gdb_unique_ptr.h: Rename include guard.
15470         * common/gdb_tilde_expand.h: Rename include guard.
15471         * common/gdb_sys_time.h: Rename include guard.
15472         * common/gdb_string_view.h: Rename include guard.
15473         * common/gdb_splay_tree.h: Rename include guard.
15474         * common/gdb_setjmp.h: Rename include guard.
15475         * common/gdb_ref_ptr.h: Rename include guard.
15476         * common/gdb_optional.h: Rename include guard.
15477         * common/gdb_locale.h: Rename include guard.
15478         * common/gdb_assert.h: Rename include guard.
15479         * common/filtered-iterator.h: Rename include guard.
15480         * common/filestuff.h: Rename include guard.
15481         * common/fileio.h: Rename include guard.
15482         * common/environ.h: Rename include guard.
15483         * common/common-utils.h: Rename include guard.
15484         * common/common-types.h: Rename include guard.
15485         * common/common-regcache.h: Rename include guard.
15486         * common/common-inferior.h: Rename include guard.
15487         * common/common-gdbthread.h: Rename include guard.
15488         * common/common-exceptions.h: Rename include guard.
15489         * common/common-defs.h: Rename include guard.
15490         * common/common-debug.h: Rename include guard.
15491         * common/cleanups.h: Rename include guard.
15492         * common/buffer.h: Rename include guard.
15493         * common/btrace-common.h: Rename include guard.
15494         * common/break-common.h: Rename include guard.
15495         * cli/cli-utils.h: Rename include guard.
15496         * cli/cli-style.h: Rename include guard.
15497         * cli/cli-setshow.h: Rename include guard.
15498         * cli/cli-script.h: Rename include guard.
15499         * cli/cli-interp.h: Rename include guard.
15500         * cli/cli-decode.h: Rename include guard.
15501         * cli/cli-cmds.h: Rename include guard.
15502         * charset-list.h: Add include guard.
15503         * buildsym-legacy.h: Rename include guard.
15504         * bfin-tdep.h: Add include guard.
15505         * ax.h: Rename include guard.
15506         * arm-linux-tdep.h: Add include guard.
15507         * arm-fbsd-tdep.h: Add include guard.
15508         * arch/xtensa.h: Rename include guard.
15509         * arch/tic6x.h: Add include guard.
15510         * arch/i386.h: Add include guard.
15511         * arch/arm.h: Rename include guard.
15512         * arch/arm-linux.h: Rename include guard.
15513         * arch/arm-get-next-pcs.h: Rename include guard.
15514         * arch/amd64.h: Add include guard.
15515         * arch/aarch64-insn.h: Rename include guard.
15516         * arch-utils.h: Rename include guard.
15517         * annotate.h: Add include guard.
15518         * amd64-darwin-tdep.h: Rename include guard.
15519         * aarch64-linux-tdep.h: Add include guard.
15520         * aarch64-fbsd-tdep.h: Add include guard.
15521         * aarch32-linux-nat.h: Add include guard.
15522
15523 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15524
15525         * macrotab.c (macro_define_internal): New function that
15526         factorizes macro_define_object_internal and macro_define_function
15527         code.
15528         (macro_define_object_internal): Use macro_define_internal.
15529         (macro_define_function): Likewise.
15530
15531 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15532
15533         * macrocmd.c (extract_identifier): Return
15534         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15535         callers.
15536
15537 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15538
15539         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15540
15541 2019-02-05  Tom Tromey  <tom@tromey.com>
15542
15543         * target.c (target_stack::unpush): Move assertion earlier.
15544
15545 2019-01-30  Tom Tromey  <tom@tromey.com>
15546
15547         PR python/23615:
15548         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15549         (gdbpy_parse_and_eval): Likewise.
15550         * python/python-internal.h (gdbpy_allow_threads): New class.
15551
15552 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15553
15554         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15555         (aarch64_fbsd_fpregmap): Move earlier.
15556         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15557         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15558         instead of individual calls to trad_frame_set_reg_addr.
15559         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15560         earlier.
15561         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15562         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15563         instead of individual calls to trad_frame_set_reg_addr.
15564
15565 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15566
15567         * CONTRIBUTE: Replace contribution list with wiki link.
15568
15569 2019-01-25  Tom Tromey  <tom@tromey.com>
15570
15571         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15572
15573 2019-01-25  Tom Tromey  <tom@tromey.com>
15574
15575         * xtensa-linux-nat.c: Fix common/ includes.
15576         * xml-support.h: Fix common/ includes.
15577         * xml-support.c: Fix common/ includes.
15578         * x86-linux-nat.c: Fix common/ includes.
15579         * windows-nat.c: Fix common/ includes.
15580         * varobj.h: Fix common/ includes.
15581         * varobj.c: Fix common/ includes.
15582         * value.c: Fix common/ includes.
15583         * valops.c: Fix common/ includes.
15584         * utils.c: Fix common/ includes.
15585         * unittests/xml-utils-selftests.c: Fix common/ includes.
15586         * unittests/utils-selftests.c: Fix common/ includes.
15587         * unittests/unpack-selftests.c: Fix common/ includes.
15588         * unittests/tracepoint-selftests.c: Fix common/ includes.
15589         * unittests/style-selftests.c: Fix common/ includes.
15590         * unittests/string_view-selftests.c: Fix common/ includes.
15591         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15592         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15593         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15594         * unittests/rsp-low-selftests.c: Fix common/ includes.
15595         * unittests/parse-connection-spec-selftests.c: Fix common/
15596         includes.
15597         * unittests/optional-selftests.c: Fix common/ includes.
15598         * unittests/offset-type-selftests.c: Fix common/ includes.
15599         * unittests/observable-selftests.c: Fix common/ includes.
15600         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15601         * unittests/memrange-selftests.c: Fix common/ includes.
15602         * unittests/memory-map-selftests.c: Fix common/ includes.
15603         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15604         * unittests/function-view-selftests.c: Fix common/ includes.
15605         * unittests/environ-selftests.c: Fix common/ includes.
15606         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15607         * unittests/common-utils-selftests.c: Fix common/ includes.
15608         * unittests/cli-utils-selftests.c: Fix common/ includes.
15609         * unittests/array-view-selftests.c: Fix common/ includes.
15610         * ui-file.c: Fix common/ includes.
15611         * tui/tui-io.c: Fix common/ includes.
15612         * tracepoint.h: Fix common/ includes.
15613         * tracepoint.c: Fix common/ includes.
15614         * tracefile-tfile.c: Fix common/ includes.
15615         * top.h: Fix common/ includes.
15616         * top.c: Fix common/ includes.
15617         * thread.c: Fix common/ includes.
15618         * target/waitstatus.h: Fix common/ includes.
15619         * target/waitstatus.c: Fix common/ includes.
15620         * target.h: Fix common/ includes.
15621         * target.c: Fix common/ includes.
15622         * target-memory.c: Fix common/ includes.
15623         * target-descriptions.c: Fix common/ includes.
15624         * symtab.h: Fix common/ includes.
15625         * symfile.c: Fix common/ includes.
15626         * stap-probe.c: Fix common/ includes.
15627         * spu-linux-nat.c: Fix common/ includes.
15628         * sparc-nat.c: Fix common/ includes.
15629         * source.c: Fix common/ includes.
15630         * solib.c: Fix common/ includes.
15631         * solib-target.c: Fix common/ includes.
15632         * ser-unix.c: Fix common/ includes.
15633         * ser-tcp.c: Fix common/ includes.
15634         * ser-pipe.c: Fix common/ includes.
15635         * ser-base.c: Fix common/ includes.
15636         * selftest-arch.c: Fix common/ includes.
15637         * s12z-tdep.c: Fix common/ includes.
15638         * rust-exp.y: Fix common/ includes.
15639         * rs6000-aix-tdep.c: Fix common/ includes.
15640         * riscv-tdep.c: Fix common/ includes.
15641         * remote.c: Fix common/ includes.
15642         * remote-notif.h: Fix common/ includes.
15643         * remote-fileio.h: Fix common/ includes.
15644         * remote-fileio.c: Fix common/ includes.
15645         * regcache.h: Fix common/ includes.
15646         * regcache.c: Fix common/ includes.
15647         * record-btrace.c: Fix common/ includes.
15648         * python/python.c: Fix common/ includes.
15649         * python/py-type.c: Fix common/ includes.
15650         * python/py-inferior.c: Fix common/ includes.
15651         * progspace.h: Fix common/ includes.
15652         * producer.c: Fix common/ includes.
15653         * procfs.c: Fix common/ includes.
15654         * proc-api.c: Fix common/ includes.
15655         * printcmd.c: Fix common/ includes.
15656         * ppc-linux-nat.c: Fix common/ includes.
15657         * parser-defs.h: Fix common/ includes.
15658         * osdata.c: Fix common/ includes.
15659         * obsd-nat.c: Fix common/ includes.
15660         * nat/x86-linux.c: Fix common/ includes.
15661         * nat/x86-linux-dregs.c: Fix common/ includes.
15662         * nat/x86-dregs.h: Fix common/ includes.
15663         * nat/x86-dregs.c: Fix common/ includes.
15664         * nat/ppc-linux.c: Fix common/ includes.
15665         * nat/mips-linux-watch.h: Fix common/ includes.
15666         * nat/mips-linux-watch.c: Fix common/ includes.
15667         * nat/linux-waitpid.c: Fix common/ includes.
15668         * nat/linux-ptrace.h: Fix common/ includes.
15669         * nat/linux-ptrace.c: Fix common/ includes.
15670         * nat/linux-procfs.c: Fix common/ includes.
15671         * nat/linux-personality.c: Fix common/ includes.
15672         * nat/linux-osdata.c: Fix common/ includes.
15673         * nat/linux-namespaces.c: Fix common/ includes.
15674         * nat/linux-btrace.h: Fix common/ includes.
15675         * nat/linux-btrace.c: Fix common/ includes.
15676         * nat/fork-inferior.c: Fix common/ includes.
15677         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15678         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15679         * nat/aarch64-linux.c: Fix common/ includes.
15680         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15681         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15682         * namespace.h: Fix common/ includes.
15683         * mips-linux-tdep.c: Fix common/ includes.
15684         * minsyms.c: Fix common/ includes.
15685         * mi/mi-parse.h: Fix common/ includes.
15686         * mi/mi-main.c: Fix common/ includes.
15687         * mi/mi-cmd-env.c: Fix common/ includes.
15688         * memrange.h: Fix common/ includes.
15689         * memattr.c: Fix common/ includes.
15690         * maint.h: Fix common/ includes.
15691         * maint.c: Fix common/ includes.
15692         * main.c: Fix common/ includes.
15693         * machoread.c: Fix common/ includes.
15694         * location.c: Fix common/ includes.
15695         * linux-thread-db.c: Fix common/ includes.
15696         * linux-nat.c: Fix common/ includes.
15697         * linux-fork.c: Fix common/ includes.
15698         * inline-frame.c: Fix common/ includes.
15699         * infrun.c: Fix common/ includes.
15700         * inflow.c: Fix common/ includes.
15701         * inferior.h: Fix common/ includes.
15702         * inferior.c: Fix common/ includes.
15703         * infcmd.c: Fix common/ includes.
15704         * inf-ptrace.c: Fix common/ includes.
15705         * inf-child.c: Fix common/ includes.
15706         * ia64-linux-nat.c: Fix common/ includes.
15707         * i387-tdep.c: Fix common/ includes.
15708         * i386-tdep.c: Fix common/ includes.
15709         * i386-linux-tdep.c: Fix common/ includes.
15710         * i386-linux-nat.c: Fix common/ includes.
15711         * i386-go32-tdep.c: Fix common/ includes.
15712         * i386-fbsd-tdep.c: Fix common/ includes.
15713         * i386-fbsd-nat.c: Fix common/ includes.
15714         * guile/scm-type.c: Fix common/ includes.
15715         * guile/guile.c: Fix common/ includes.
15716         * go32-nat.c: Fix common/ includes.
15717         * gnu-nat.c: Fix common/ includes.
15718         * gdbthread.h: Fix common/ includes.
15719         * gdbarch-selftests.c: Fix common/ includes.
15720         * gdb_usleep.c: Fix common/ includes.
15721         * gdb_select.h: Fix common/ includes.
15722         * gdb_bfd.c: Fix common/ includes.
15723         * gcore.c: Fix common/ includes.
15724         * fork-child.c: Fix common/ includes.
15725         * findvar.c: Fix common/ includes.
15726         * fbsd-nat.c: Fix common/ includes.
15727         * event-top.c: Fix common/ includes.
15728         * event-loop.c: Fix common/ includes.
15729         * dwarf2read.c: Fix common/ includes.
15730         * dwarf2loc.c: Fix common/ includes.
15731         * dwarf2-frame.c: Fix common/ includes.
15732         * dwarf-index-cache.c: Fix common/ includes.
15733         * dtrace-probe.c: Fix common/ includes.
15734         * disasm-selftests.c: Fix common/ includes.
15735         * defs.h: Fix common/ includes.
15736         * csky-tdep.c: Fix common/ includes.
15737         * cp-valprint.c: Fix common/ includes.
15738         * cp-support.h: Fix common/ includes.
15739         * cp-support.c: Fix common/ includes.
15740         * corelow.c: Fix common/ includes.
15741         * completer.h: Fix common/ includes.
15742         * completer.c: Fix common/ includes.
15743         * compile/compile.c: Fix common/ includes.
15744         * compile/compile-loc2c.c: Fix common/ includes.
15745         * compile/compile-cplus-types.c: Fix common/ includes.
15746         * compile/compile-cplus-symbols.c: Fix common/ includes.
15747         * command.h: Fix common/ includes.
15748         * cli/cli-dump.c: Fix common/ includes.
15749         * cli/cli-cmds.c: Fix common/ includes.
15750         * charset.c: Fix common/ includes.
15751         * build-id.c: Fix common/ includes.
15752         * btrace.h: Fix common/ includes.
15753         * btrace.c: Fix common/ includes.
15754         * breakpoint.h: Fix common/ includes.
15755         * breakpoint.c: Fix common/ includes.
15756         * ax.h:
15757         (enum agent_op): Fix common/ includes.
15758         * ax-general.c (struct aop_map): Fix common/ includes.
15759         * ax-gdb.c: Fix common/ includes.
15760         * auxv.c: Fix common/ includes.
15761         * auto-load.c: Fix common/ includes.
15762         * arm-tdep.c: Fix common/ includes.
15763         * arch/riscv.c: Fix common/ includes.
15764         * arch/ppc-linux-common.c: Fix common/ includes.
15765         * arch/i386.c: Fix common/ includes.
15766         * arch/arm.c: Fix common/ includes.
15767         * arch/arm-linux.c: Fix common/ includes.
15768         * arch/arm-get-next-pcs.c: Fix common/ includes.
15769         * arch/amd64.c: Fix common/ includes.
15770         * arch/aarch64.c: Fix common/ includes.
15771         * arch/aarch64-insn.c: Fix common/ includes.
15772         * arch-utils.c: Fix common/ includes.
15773         * amd64-windows-tdep.c: Fix common/ includes.
15774         * amd64-tdep.c: Fix common/ includes.
15775         * amd64-sol2-tdep.c: Fix common/ includes.
15776         * amd64-obsd-tdep.c: Fix common/ includes.
15777         * amd64-nbsd-tdep.c: Fix common/ includes.
15778         * amd64-linux-tdep.c: Fix common/ includes.
15779         * amd64-linux-nat.c: Fix common/ includes.
15780         * amd64-fbsd-tdep.c: Fix common/ includes.
15781         * amd64-fbsd-nat.c: Fix common/ includes.
15782         * amd64-dicos-tdep.c: Fix common/ includes.
15783         * amd64-darwin-tdep.c: Fix common/ includes.
15784         * agent.c: Fix common/ includes.
15785         * ada-lang.h: Fix common/ includes.
15786         * ada-lang.c: Fix common/ includes.
15787         * aarch64-tdep.c: Fix common/ includes.
15788
15789 2019-01-25  Tom Tromey  <tom@tromey.com>
15790
15791         * common/create-version.sh: Use common/version.h.
15792
15793 2019-01-24  Pedro Alves  <palves@redhat.com>
15794
15795         * infrun.c (signal_stop, signal_print, signal_program)
15796         (signal_catch, signal_pass): Now arrays instead of pointers.
15797         (update_signals_program_target, do_target_resume)
15798         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15799         * linux-nat.c (linux_nat_target::pass_signals)
15800         (linux_nat_target::create_inferior, linux_nat_target::attach):
15801         Adjust.
15802         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15803         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15804         * procfs.c (procfs_target::pass_signals): Adjust.
15805         * record-full.c (record_full_target::resume): Adjust.
15806         * remote.c (remote_target::pass_signals)
15807         (remote_target::program_signals): Adjust.
15808         * target-debug.h (target_debug_print_signals): Now takes a
15809         gdb::array_view as parameter.  Adjust.
15810         * target.h (target_ops) <pass_signals, program_signals>: Replace
15811         pointer and length parameters with gdb::array_view.
15812         (target_pass_signals, target_program_signals): Likewise.
15813         * target-delegates.c: Regenerate.
15814
15815 2019-01-24  Pedro Alves  <palves@redhat.com>
15816
15817         * common/forward-scope-exit.h
15818         (forward_scope_exit::forward_scope_exit): Pass arguments to
15819         m_bind_function directly, instead of creating a std::bind and
15820         copying that.
15821
15822 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15823
15824         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15825         for static members.
15826         (pass_in_v_vfp_candidate): Likewise.
15827
15828 2019-01-23  Tom Tromey  <tom@tromey.com>
15829             Pedro Alves  <palves@redhat.com>
15830
15831         * regcache.c (class regcache_invalidator): Remove.
15832         (regcache::raw_write): Use make_scope_exit.
15833
15834 2019-01-23  Tom Tromey  <tom@tromey.com>
15835
15836         * ui-out.h (class ui_out_emit_type): Update comment.
15837
15838 2019-01-23  Tom Tromey  <tom@tromey.com>
15839
15840         * infrun.c (fetch_inferior_event): Update comment.
15841
15842 2019-01-23  Tom Tromey  <tom@tromey.com>
15843             Pedro Alves  <palves@redhat.com>
15844
15845         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15846         parameter.
15847         (fetch_inferior_event): Use SCOPE_EXIT.
15848
15849
15850 2019-01-23  Tom Tromey  <tom@tromey.com>
15851             Pedro Alves  <palves@redhat.com>
15852
15853         * infrun.c (disable_thread_events): Delete.
15854         (stop_all_threads): Use SCOPE_EXIT.
15855
15856 2019-01-23  Tom Tromey  <tom@tromey.com>
15857             Pedro Alves  <palves@redhat.com>
15858
15859         * symfile.c: Include forward-scope-exit.h.
15860         (clear_symtab_users_cleanup): Replace forward declaration with
15861         a FORWARD_SCOPE_EXIT.
15862         (syms_from_objfile_1): Use the forward_scope_exit and
15863         gdb::optional instead of cleanup_function.
15864         (reread_symbols): Use the forward_scope_exit instead of
15865         cleanup_function.
15866         (clear_symtab_users_cleanup): Remove function.
15867
15868 2019-01-23  Tom Tromey  <tom@tromey.com>
15869             Pedro Alves  <palves@redhat.com>
15870
15871         * linux-nat.c: Include scope-exit.h.
15872         (cleanup_target_stop): Remove.
15873         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15874         SCOPE_EXIT.
15875
15876 2019-01-23  Tom Tromey  <tom@tromey.com>
15877             Pedro Alves  <palves@redhat.com>
15878
15879         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15880         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15881
15882 2019-01-23  Tom Tromey  <tom@tromey.com>
15883             Andrew Burgess  <andrew.burgess@embecosm.com>
15884             Pedro Alves  <palves@redhat.com>
15885
15886         * infrun.c (fetch_inferior_event): Use scope_exit.
15887         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15888         * top.c (execute_command): Use scope_exit.
15889         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15890         * utils.c (do_bpstat_clear_actions_cleanup)
15891         (make_bpstat_clear_actions_cleanup): Remove.
15892
15893 2019-01-23  Tom Tromey  <tom@tromey.com>
15894             Pedro Alves  <palves@redhat.com>
15895
15896         * infrun.c: Include "common/scope-exit.h"
15897         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15898         (wait_for_inferior): Use SCOPE_EXIT.
15899         (fetch_inferior_event): Use scope_exit.
15900
15901 2019-01-23  Tom Tromey  <tom@tromey.com>
15902             Pedro Alves  <palves@redhat.com>
15903
15904         * breakpoint.c (create_breakpoint): Remove cleanup.
15905
15906 2019-01-23  Tom Tromey  <tom@tromey.com>
15907             Andrew Burgess  <andrew.burgess@embecosm.com>
15908             Pedro Alves  <palves@redhat.com>
15909
15910 2019-01-23  Pedro Alves  <palves@redhat.com>
15911
15912         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15913
15914 2019-01-23  Pedro Alves  <palves@redhat.com>
15915             Andrew Burgess  <andrew.burgess@embecosm.com>
15916
15917         * gdbthread.h: Include "common/forward-scope-exit.h".
15918         (scoped_finish_thread_state): Redefine custom class in terms of
15919         forward_scope_exit.
15920
15921 2019-01-23  Pedro Alves  <palves@redhat.com>
15922             Andrew Burgess  <andrew.burgess@embecosm.com>
15923
15924         * common/forward-scope-exit.h: New file.
15925
15926 2019-01-23  Pedro Alves  <palves@redhat.com>
15927             Andrew Burgess  <andrew.burgess@embecosm.com>
15928             Tom Tromey  <tom@tromey.com>
15929
15930         * common/scope-exit.h: New file.
15931
15932 2019-01-23  Pedro Alves  <palves@redhat.com>
15933
15934         * common/preprocessor.h (ESC): Rename to ...
15935         (ESC_PARENS): ... this.
15936         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15937         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15938
15939 2019-01-23  Tom Tromey  <tom@tromey.com>
15940
15941         * language.h (class scoped_switch_to_sym_language_if_auto):
15942         Initialize m_lang in both cases.
15943
15944 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15945
15946         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15947         with XCNEW.
15948
15949 2019-01-22  Tom Tromey  <tom@tromey.com>
15950
15951         * corelow.c: Do not include sys/file.h.
15952
15953 2019-01-22  Tom Tromey  <tom@tromey.com>
15954
15955         * tui/tui-wingeneral.h: Include gdb_curses.h.
15956
15957 2019-01-22  Tom Tromey  <tom@tromey.com>
15958
15959         * source-cache.h (class source_cache) <get_source_lines,
15960         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15961
15962 2019-01-22  Tom Tromey  <tom@tromey.com>
15963
15964         * remote-fileio.h (struct remote_target): Declare.
15965
15966 2019-01-22  Tom Tromey  <tom@tromey.com>
15967
15968         * python/py-arch.c: Do not include py-ref.h.
15969         * python/py-bpevent.c: Do not include py-ref.h.
15970         * python/py-cmd.c: Do not include py-ref.h.
15971         * python/py-continueevent.c: Do not include py-ref.h.
15972         * python/py-event.h: Do not include py-ref.h.
15973         * python/py-evtregistry.c: Do not include py-ref.h.
15974         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15975         * python/py-frame.c: Do not include py-ref.h.
15976         * python/py-framefilter.c: Do not include py-ref.h.
15977         * python/py-function.c: Do not include py-ref.h.
15978         * python/py-infevents.c: Do not include py-ref.h.
15979         * python/py-linetable.c: Do not include py-ref.h.
15980         * python/py-objfile.c: Do not include py-ref.h.
15981         * python/py-param.c: Do not include py-ref.h.
15982         * python/py-prettyprint.c: Do not include py-ref.h.
15983         * python/py-progspace.c: Do not include py-ref.h.
15984         * python/py-symbol.c: Do not include py-ref.h.
15985         * python/py-symtab.c: Do not include py-ref.h.
15986         * python/py-type.c: Do not include py-ref.h.
15987         * python/py-unwind.c: Do not include py-ref.h.
15988         * python/py-utils.c: Do not include py-ref.h.
15989         * python/py-value.c: Do not include py-ref.h.
15990         * python/py-varobj.c: Do not include py-ref.h.
15991         * python/py-xmethods.c: Do not include py-ref.h.
15992         * python/python.c: Do not include py-ref.h.
15993         * varobj.c: Do not include py-ref.h.
15994
15995 2019-01-22  Tom Tromey  <tom@tromey.com>
15996
15997         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15998         keyword for bcache.
15999
16000 2019-01-22  Tom Tromey  <tom@tromey.com>
16001
16002         * compile/compile-cplus-types.c: Remove a comment by #include.
16003
16004 2019-01-22  Tom Tromey  <tom@tromey.com>
16005
16006         * compile/gcc-c-plugin.h: Include compile-internal.h.
16007
16008 2019-01-22  Tom Tromey  <tom@tromey.com>
16009
16010         * stabsread.c (EXTERN): Do not define.
16011         (symnum, next_symbol_text_func, processing_gcc_compilation)
16012         (within_function, global_sym_chain, global_stabs)
16013         (previous_stab_code, this_object_header_files)
16014         (n_this_object_header_files)
16015         (n_allocated_this_object_header_files): Define.
16016         * stabsread.h (EXTERN): Never define.  Use "extern".
16017
16018 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16019
16020         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16021         history_value.
16022
16023 2019-01-21  Tom Tromey  <tom@tromey.com>
16024
16025         * ui-out.c: Fix includes.
16026         * tui/tui-source.c: Fix includes.
16027         * target.c: Fix includes.
16028         * remote.c: Fix includes.
16029         * regcache.c: Fix includes.
16030         * python/py-block.c: Fix includes.
16031         * printcmd.c: Fix includes.
16032         * or1k-tdep.c: Fix includes.
16033         * mi/mi-main.c: Fix includes.
16034         * m32r-tdep.c: Fix includes.
16035         * csky-tdep.c: Fix includes.
16036         * compile/compile-cplus-types.c: Fix includes.
16037         * cli/cli-interp.c: Fix includes.
16038
16039 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16040
16041         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16042         for padding.
16043
16044 2019-01-16  Tom Tromey  <tom@tromey.com>
16045
16046         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16047         earlier.
16048         (struct objfile) <msymbols_range>: Move from top level.
16049         <msymbols>: New method.
16050         (class objfile_msymbols): Remove.
16051         * symtab.c (default_collect_symbol_completion_matches_break_on):
16052         Update.
16053         * symmisc.c (dump_msymbols): Update.
16054         * stabsread.c (scan_file_globals): Update.
16055         * objc-lang.c (info_selectors_command, info_classes_command)
16056         (find_methods): Update.
16057         * minsyms.c (find_solib_trampoline_target): Update.
16058         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16059         * coffread.c (coff_symfile_read): Update.
16060         * ada-lang.c (ada_lookup_simple_minsym)
16061         (ada_collect_symbol_completion_matches): Update.
16062
16063 2019-01-16  Tom Tromey  <tom@tromey.com>
16064
16065         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16066         type.  Remove no-argument constructor.
16067         <iterator::operator++>: Simplify.
16068         <begin>: Update.
16069         <end>: Use minimal_symbol_count.
16070
16071 2019-01-16  Tom Tromey  <tom@tromey.com>
16072
16073         * objfiles.h (struct objfile) <psymtabs>: New method.
16074         (class objfile_psymtabs): Remove.
16075         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16076         typedef.
16077         <range>: New method.
16078         (require_partial_symbols): Change return type.
16079         * psymtab.c (require_partial_symbols)
16080         (psym_expand_symtabs_matching): Update.
16081         * mdebugread.c (parse_partial_symbols): Update.
16082         * dbxread.c (dbx_end_psymtab): Update.
16083
16084 2019-01-15  Tom Tromey  <tom@tromey.com>
16085
16086         * symtab.c (lookup_objfile_from_block)
16087         (lookup_symbol_in_objfile_symtabs)
16088         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16089         (find_line_symtab, info_sources_command)
16090         (default_collect_symbol_completion_matches_break_on)
16091         (make_source_files_completion_list): Update.
16092         * symmisc.c (print_objfile_statistics, dump_objfile)
16093         (maintenance_print_symbols, maintenance_info_symtabs)
16094         (maintenance_check_symtabs, maintenance_info_line_tables):
16095         Update.
16096         * source.c (select_source_symtab)
16097         (forget_cached_source_info_for_objfile): Update.
16098         * objfiles.h (class objfile_compunits): Remove.
16099         (struct objfile) <compunits_range>: New typedef.
16100         (compunits): New method.
16101         * objfiles.c (objfile_relocate1): Update.
16102         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16103         * maint.c (count_symtabs_and_blocks): Update.
16104         * linespec.c (iterate_over_all_matching_symtabs): Update.
16105         * cp-support.c (add_symbol_overload_list_qualified): Update.
16106         * coffread.c (coff_symtab_read): Update.
16107         * ada-lang.c (add_nonlocal_symbols)
16108         (ada_collect_symbol_completion_matches)
16109         (ada_add_global_exceptions): Update.
16110
16111 2019-01-15  Tom Tromey  <tom@tromey.com>
16112
16113         * progspace.h (program_space) <objfiles_safe_range>: New
16114         typedef.
16115         <objfiles_safe>: New method.
16116         * objfiles.h (class all_objfiles_safe): Remove.
16117         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16118         * jit.c (jit_inferior_exit_hook): Update.
16119
16120 2019-01-17  Tom Tromey  <tom@tromey.com>
16121
16122         * progspace.h (program_space) <objfiles_range>: New typedef.
16123         <objfiles>: New method.
16124         <objfiles_head>: Rename from objfiles.
16125         (object_files): Update.
16126         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16127         * guile/scm-pretty-print.c
16128         (ppscm_find_pretty_printer_from_objfiles): Update.
16129         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16130         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16131         Update.
16132         * python/py-progspace.c (pspy_get_objfiles): Update.
16133         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16134         Update.
16135         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16136         (objfpy_lookup_objfile_by_build_id): Update.
16137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16138         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16139         Update.
16140         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16141         (expand_symtab_containing_pc, lookup_objfile_from_block)
16142         (lookup_static_symbol, basic_lookup_transparent_type)
16143         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16144         (find_line_symtab, info_sources_command)
16145         (default_collect_symbol_completion_matches_break_on)
16146         (make_source_files_completion_list, find_main_name): Update.
16147         * symmisc.c (print_symbol_bcache_statistics)
16148         (print_objfile_statistics, maintenance_print_symbols)
16149         (maintenance_print_msymbols, maintenance_print_objfiles)
16150         (maintenance_info_symtabs, maintenance_check_symtabs)
16151         (maintenance_expand_symtabs, maintenance_info_line_tables):
16152         Update.
16153         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16154         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16155         (map_overlay_command, unmap_overlay_command)
16156         (simple_overlay_update, expand_symtabs_matching)
16157         (map_symbol_filenames): Update.
16158         * symfile-debug.c (set_debug_symfile): Update.
16159         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16160         Update.
16161         * source.c (select_source_symtab, forget_cached_source_info):
16162         Update.
16163         * solib.c (solib_read_symbols): Update.
16164         * solib-spu.c (append_ocl_sos): Update.
16165         * psymtab.c (maintenance_print_psymbols)
16166         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16167         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16168         * printcmd.c (info_symbol_command): Update.
16169         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16170         Update.
16171         * objfiles.h (class all_objfiles): Remove.
16172         * objfiles.c (have_partial_symbols, have_full_symbols)
16173         (have_minimal_symbols, qsort_cmp, update_section_map)
16174         (shared_objfile_contains_address_p)
16175         (default_iterate_over_objfiles_in_search_order): Update.
16176         * objc-lang.c (info_selectors_command, info_classes_command)
16177         (find_methods): Update.
16178         * minsyms.c (find_solib_trampoline_target): Update.
16179         * maint.c (maintenance_info_sections)
16180         (maintenance_translate_address, count_symtabs_and_blocks):
16181         Update.
16182         * main.c (captured_main_1): Update.
16183         * linux-thread-db.c (try_thread_db_load_from_pdir)
16184         (has_libpthread): Update.
16185         * linespec.c (iterate_over_all_matching_symtabs)
16186         (search_minsyms_for_name): Update.
16187         * jit.c (jit_find_objf_with_entry_addr): Update.
16188         * hppa-tdep.c (find_unwind_entry)
16189         (hppa_lookup_stub_minimal_symbol): Update.
16190         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16191         Update.
16192         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16193         (elf_gnu_ifunc_resolve_by_got): Update.
16194         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16195         * dwarf-index-write.c (save_gdb_index_command): Update.
16196         * cp-support.c (add_symbol_overload_list_qualified): Update.
16197         * breakpoint.c (create_overlay_event_breakpoint)
16198         (create_longjmp_master_breakpoint)
16199         (create_std_terminate_master_breakpoint)
16200         (create_exception_master_breakpoint): Update.
16201         * blockframe.c (find_pc_partial_function): Update.
16202         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16203         (ada_collect_symbol_completion_matches)
16204         (ada_add_global_exceptions): Update.
16205
16206 2019-01-17  Tom Tromey  <tom@tromey.com>
16207
16208         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16209         declare VEC.
16210         (solib_target_parse_libraries): Change return type.
16211         (library_list_start_segment, library_list_start_section)
16212         (library_list_end_library, library_list_start_library); Update.
16213         (solib_target_free_library_list): Remove.
16214         (solib_target_parse_libraries): Remove cleanup.  Change return
16215         type.
16216         (solib_target_current_sos): Update.
16217
16218 2019-01-17  Tom Tromey  <tromey@bapiya>
16219
16220         * valprint.c: Replace "the the" with "the".
16221         * symtab.c: Replace "the the" with "the".
16222         * solib.c: Replace "the the" with "the".
16223         * solib-dsbt.c: Replace "the the" with "the".
16224         * linespec.c: Replace "the the" with "the".
16225         * dwarf2loc.h: Replace "the the" with "the".
16226         * amd64-windows-tdep.c: Replace "the the" with "the".
16227         * aarch64-tdep.c: Replace "the the" with "the".
16228
16229 2019-01-16  Keith Seitz  <keiths@redhat.com>
16230
16231         PR gdb/23773
16232         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16233         <builder>: Rename to ..
16234         <m_builder>: ... this and make private.
16235         (dwarf2_cu::get_builder): New method.  Change all users of
16236         `builder' to use this method.
16237         (dwarf2_start_symtab): Move to ...
16238         (dwarf2_cu::start_symtab): ... here.  Update all callers
16239         (setup_type_unit_groups): Move to ...
16240         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16241         callers.
16242         (dwarf2_cu::reset_builder): New method.
16243         (process_full_compunit, process_full_type_unit): Use
16244         dwarf2_cu::reset_builder.
16245         (follow_die_offset): Record the ancestor CU if it is different
16246         from the followed DIE's CU.
16247         (follow_die_sig_1): Likewise.
16248
16249 2019-01-15  Tom Tromey  <tom@tromey.com>
16250
16251         * remote.c (class remote_state) <buf>: Now a char_vector.
16252         <buf_size>: Remove.
16253         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16254         parameter.
16255         (remote_target::getpkt_or_notif_sane_1)
16256         (remote_target::getpkt_sane)
16257         (remote_target::getpkt_or_notif_sane): Likewise.
16258         (class remote_target) <putpkt>: New overload.
16259         (remote_target::read_frame): Change type of "buf_p".  Remove
16260         sizeof_p parameter.
16261         (packet_ok): New overload.
16262         (packet_check_result): New overload.
16263         Update all uses.
16264
16265 2019-01-14  Tom Tromey  <tom@tromey.com>
16266
16267         * remote-notif.c (handle_notification, remote_notif_ack)
16268         (remote_notif_parse): Make "buf" const.
16269         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16270         const.
16271         (remote_notif_parse, remote_notif_ack, handle_notification):
16272         Likewise.
16273         * remote.c (remote_notif_stop_parse): Make "buf" const.
16274         (remote_target::remote_parse_stop_reply): Make "buf" const.
16275         (remote_notif_stop_ack): Make "buf" const.
16276
16277 2019-01-14  Tom Tromey  <tom@tromey.com>
16278
16279         * remote.c (remote_console_output): Make parameter const.
16280
16281 2019-01-14  Tom Tromey  <tom@tromey.com>
16282
16283         * target-debug.h (target_debug_print_signals): Constify.
16284         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16285         * procfs.c (procfs_target::pass_signals): Update.
16286         * linux-nat.c (linux_nat_target::pass_signals): Update.
16287         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16288         * target-delegates.c: Rebuild.
16289         * remote.c (remote_target::program_signals): Update.
16290         (remote_target::pass_signals): Update.
16291         * target.c (target_pass_signals): Constify argument.
16292         (target_program_signals): Likewise.
16293         * target.h (struct target_ops) <pass_signals, program_signals>:
16294         Constify argument.
16295         (target_pass_signals, target_program_signals): Constify argument.
16296
16297 2019-01-14  Tom Tromey  <tom@tromey.com>
16298
16299         PR tui/28819:
16300         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16301
16302 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16303
16304         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16305         field.
16306         * rs6000-tdep.c: Include reggroups.h.
16307         (IS_V_ALIAS_PSEUDOREG): Define.
16308         (rs6000_register_name): Return names for the "vX" aliases.
16309         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16310         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16311         aliases.  Call default_register_reggroup_p for all other
16312         pseudo-registers.
16313         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16314         New functions.
16315         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16316         Handle "vX" aliases.
16317         (v_alias_pseudo_register_collect): New function.
16318         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16319         (rs6000_gdbarch_init): Initialize "vX" aliases as
16320         pseudo-registers.  Restore registration of
16321         rs6000_pseudo_register_reggroup_p with
16322         set_tdesc_pseudo_register_reggroup_p.
16323
16324 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16325
16326         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16327         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16328         set_gdbarch_num_pseudo_regs.
16329
16330 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16331
16332         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16333         Remove arg prefixname, add do_set and do_show.
16334         Add member functions set_list and show_list.
16335         * cli/cli-style.c (class cli_style_option): Update accordingly.
16336         (style_set_list): Move to file scope.
16337         (style_show_list): Likewise.
16338         (set_style): Call help_list.
16339         (show_style): Call cmd_show_list.
16340         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16341         Update to use the new macro.
16342
16343 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16344
16345         * ada-lang.c (_initialize_ada_language): Expand the help text
16346         for the "catch exception" command.
16347
16348 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16349
16350         * symtab.c (matching_obj_sections): Initialize obj,
16351         declare it closer to its usage.
16352
16353 2019-01-10  Tom Tromey  <tom@tromey.com>
16354
16355         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16356         (basic_inf_threads_range): Remove.
16357         (inf_threads_range, inf_non_exited_threads_range)
16358         (safe_inf_threads_range): Use next_adapter.
16359
16360 2019-01-10  Keith Seitz  <keiths@redhat.com>
16361
16362         PR gdb/23712
16363         PR symtab/23010
16364         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16365         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16366
16367 2019-01-10  Keith Seitz  <keiths@redhat.com>
16368
16369         PR gdb/23712
16370         PR symtab/23010
16371         * dictionary.c (pending_to_vector): Remove.
16372         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16373         Remove _1 suffix, replacing functions of the same name.  Update
16374         all callers.
16375         (dict_create_hashed, dict_create_hashed_expandable)
16376         (dict_create_linear, dict_create_linear_expandable, dict_free)
16377         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16378         Make functions static.
16379
16380 2019-01-10  Keith Seitz  <keiths@redhat.com>
16381
16382         PR gdb/23712
16383         PR symtab/23010
16384         * dictionary.h (struct dictionary): Replace declaration with
16385         multidictionary.
16386         (dict_create_hashed, dict_create_hashed_expandable)
16387         (dict_create_linear, dict_create_linear_expandable)
16388         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16389         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16390         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16391         taking multidictionary argument.
16392         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16393         * block.h (struct block) <dict>: Change to multidictionary
16394         and rename `multidict'.
16395         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16396         symmisc.c: Update all dictionary references to multidictionary.
16397
16398 2019-01-10  Keith Seitz  <keiths@redhat.com>
16399
16400         PR gdb/23712
16401         PR symtab/23010
16402         * dictionary.c: Include unordered_map.
16403         (pending_to_vector): New function.
16404         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16405         Rewrite the non-"_1" functions to take vector instead
16406         of linked list.
16407         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16408         "new" _1 versions of the same name.
16409         (multidictionary): Define.
16410         (std::hash<enum language): New definition.
16411         (collate_pending_symbols_by_language, mdict_create_hashed)
16412         (mdict_create_hashed_expandable, mdict_create_linear)
16413         (mdict_create_linear_expandable, mdict_free)
16414         (find_language_dictionary, create_new_language_dictionary)
16415         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16416         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16417         (mdict_size, mdict_empty): New functions.
16418         * dictionary.h (mdict_iterator): Define.
16419
16420 2019-01-10  Pedro Alves  <palves@redhat.com>
16421
16422         * breakpoint.c (read_uploaded_action)
16423         (create_tracepoint_from_upload): Adjust to use
16424         gdb::unique_xmalloc_ptr.
16425         * ctf.c (ctf_write_uploaded_tp):
16426         (SET_ARRAY_FIELD): Use emplace_back.
16427         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16428         * tracefile-tfile.c (tfile_write_uploaded_tp):
16429         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16430         gdb::unique_xmalloc_ptr.
16431         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16432         at_string, cond_string, cmd_strings>: Replace char pointers
16433         with gdb::unique_xmalloc_ptr.
16434
16435 2019-01-10  Pedro Alves  <palves@redhat.com>
16436
16437         * solib-target.c (library_list_start_library): Don't xstrdup name.
16438
16439 2019-01-10  Pedro Alves  <palves@redhat.com>
16440
16441         * mdebugread.c (parse_partial_symbols): Use
16442         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16443
16444 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16445
16446         * linux-fork.c (scoped_switch_fork_info)
16447         <~scoped_switch_fork_info>: Fix incorrect variable name.
16448
16449 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16450
16451         * linux-fork.c (scoped_switch_fork_info)
16452         <scoped_switch_fork_info>: Make explicit.
16453         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16454
16455 2019-01-10  Tom Tromey  <tom@tromey.com>
16456
16457         * objfiles.h (objfile::reset_psymtabs): Update.
16458         * objfiles.c (objfile::objfile): Update.
16459         * psymtab.h (psymtab_storage::obstack): Update.
16460         (psymtab_storage::m_obstack): Use gdb::optional.
16461         (class psymtab_storage): Update comment.  Remove objfile
16462         parameter.
16463         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16464
16465 2019-01-10  Tom Tromey  <tom@tromey.com>
16466
16467         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16468         <free_psymtabs>: Now private.
16469         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16470         (allocate_psymtab): Use new method.
16471
16472 2019-01-10  Tom Tromey  <tom@tromey.com>
16473
16474         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16475         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16476         * mdebugread.c (parse_partial_symbols): Use
16477         allocate_dependencies.
16478         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16479         allocate_dependencies.
16480         (process_psymtab_comp_unit_reader)
16481         (build_type_psymtab_dependencies): Likewise.
16482         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16483
16484 2019-01-10  Tom Tromey  <tom@tromey.com>
16485
16486         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16487         PSYMBOL_SET_LANGUAGE.
16488         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16489
16490 2019-01-10  Tom Tromey  <tom@tromey.com>
16491
16492         * psymtab.h (psymtab_storage::obstack): New method.
16493         <m_obstack>: Rename from obstack; now private.
16494         * psymtab.c (psymtab_storage): Update.
16495         * dwarf2read.c (create_addrmap_from_index)
16496         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16497         Update.
16498
16499 2019-01-10  Tom Tromey  <tom@tromey.com>
16500
16501         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16502         * objfiles.h (objfile::reset_psymtabs): New method.
16503
16504 2019-01-10  Tom Tromey  <tom@tromey.com>
16505
16506         * symmisc.c (print_symbol_bcache_statistics): Update.
16507         (print_objfile_statistics): Update.
16508         * symfile.c (reread_symbols): Update.
16509         * psymtab.h (class psymtab_storage): New.
16510         * psymtab.c (psymtab_storage): New constructor.
16511         (~psymtab_storage): New destructor.
16512         (require_partial_symbols): Update.
16513         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16514         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16515         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16516         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16517         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16518         (start_psymtab_common, end_psymtab_common)
16519         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16520         (allocate_psymtab): Update.
16521         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16522         Update.
16523         (dump_psymtab_addrmap, maintenance_print_psymbols)
16524         (maintenance_check_psymtabs): Update.
16525         (class objfile_psymtabs): Move to objfiles.h.
16526         * psympriv.h (discard_psymtab): Now inline.
16527         (psymtab_discarder::psymtab_discarder): Update.
16528         (psymtab_discarder::~psymtab_discarder): Update.
16529         (ALL_OBJFILE_PSYMTABS): Rewrite.
16530         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16531         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16532         Remove fields.
16533         <partial_symtabs>: New field.
16534         (class objfile_psymtabs): Move from psymtab.h.  Update.
16535         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16536         psymbol_cache.
16537         (objfile::~objfile): Don't destroy psymbol_cache.
16538         * mdebugread.c (parse_partial_symbols): Update.
16539         * dwarf2read.c (create_addrmap_from_index)
16540         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16541         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16542         (add_partial_subprogram, dwarf2_ranges_read): Update.
16543         * dwarf-index-write.c (write_address_map)
16544         (write_one_signatured_type, recursively_write_psymbols)
16545         (class debug_names, class debug_names, write_psymtabs_to_index):
16546         Update.
16547
16548 2019-01-10  Tom Tromey  <tom@tromey.com>
16549
16550         * symtab.h (SYMBOL_SET_NAMES): Update.
16551         (symbol_set_names): Update.
16552         (MSYMBOL_SET_NAMES): Update.
16553         * symtab.c (symbol_set_names): Change argument to be an
16554         objfile_per_bfd_storage.
16555         * psymtab.c (add_psymbol_to_bcache): Update.
16556         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16557
16558 2019-01-10  Tom Tromey  <tom@tromey.com>
16559
16560         * symtab.c (create_demangled_names_hash): Change argument to be an
16561         objfile_per_bfd_storage.
16562         (symbol_set_names): Update.
16563
16564 2019-01-10  Tom Tromey  <tom@tromey.com>
16565
16566         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16567         init_psymbol_list.
16568         * psymtab.c (init_psymbol_list): Do nothing if already called.
16569         * psympriv.h (init_psymbol_list): Add comment.
16570         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16571         init_psymbol_list.
16572         * dbxread.c (dbx_symfile_read): Unconditionally call
16573         init_psymbol_list.
16574
16575 2019-01-10  Tom Tromey  <tom@tromey.com>
16576
16577         * xcoffread.c (scan_xcoff_symtab): Update.
16578         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16579         "where".
16580         * mdebugread.c (parse_partial_symbols)
16581         (handle_psymbol_enumerators): Update.
16582         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16583         * dbxread.c (read_dbx_symtab): Update.
16584         * psympriv.h (psymbol_placement): New enum.
16585         (add_psymbol_to_list): Update.
16586
16587 2019-01-10  Tom Tromey  <tom@tromey.com>
16588
16589         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16590         static_psymbols parameters.
16591         (scan_xcoff_symtab): Update.
16592         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16593         static_psymbols parameters.
16594         * psympriv.h (start_psymtab_common): Update.
16595         * mdebugread.c (parse_partial_symbols): Update.
16596         * dwarf2read.c (create_partial_symtab): Update.
16597         * dbxread.c (read_dbx_symtab): Update.
16598         (start_psymtab): Remove global_psymbols and static_psymbols
16599         parameters.
16600
16601 2019-01-10  Tom Tromey  <tom@tromey.com>
16602
16603         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16604         * psymtab.c (allocate_psymtab): Add comment.
16605         * psympriv.h (allocate_psymtab): Add comment.
16606         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16607         initializations.
16608         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16609
16610 2019-01-10  Tom Tromey  <tom@tromey.com>
16611
16612         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16613         Don't declare.
16614         * mipsread.c: Include mdebugread.h.
16615         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16616         Declare.
16617         * elfread.c: Include mdebugread.h.
16618
16619 2019-01-09  Tom Tromey  <tom@tromey.com>
16620
16621         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16622         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16623         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16624         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16625         (psym_lookup_symbol, psym_find_last_source_symtab)
16626         (psym_forget_cached_source_info, psym_print_stats)
16627         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16628         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16629         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16630         (psym_find_compunit_symtab_by_address)
16631         (maintenance_print_psymbols, maintenance_info_psymtabs)
16632         (maintenance_check_psymtabs): Use ranged for.
16633         * psymtab.h (class objfile_psymtabs): New.
16634         (require_partial_symbols): Return objfile_psymtabs.
16635         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16636
16637 2019-01-09  Tom Tromey  <tom@tromey.com>
16638
16639         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16640         (find_pc_mapped_section, list_overlays_command)
16641         (map_overlay_command, unmap_overlay_command)
16642         (simple_overlay_update): Use all_objfiles.
16643         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16644         * printcmd.c (info_symbol_command): Use all_objfiles.
16645         * objfiles.h (ALL_OBJSECTIONS): Remove.
16646         * maint.c (maintenance_translate_address): Use all_objfiles.
16647         * gcore.c (gcore_create_callback): Use all_objfiles.
16648         (objfile_find_memory_regions): Likewise.
16649
16650 2019-01-09  Tom Tromey  <tom@tromey.com>
16651
16652         * symtab.c (find_line_symtab, info_sources_command)
16653         (make_source_files_completion_list): Use objfile_compunits.
16654         * source.c (select_source_symtab): Use objfile_compunits.
16655         * objfiles.h (struct objfile): Update comment.
16656         (ALL_OBJFILES): Remove.
16657         (ALL_FILETABS): Remove.
16658         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16659         objfile_compunits.
16660
16661 2019-01-09  Tom Tromey  <tom@tromey.com>
16662
16663         * symmisc.c (print_objfile_statistics, dump_objfile)
16664         (maintenance_print_symbols): Use compunit_filetabs.
16665         * source.c (forget_cached_source_info_for_objfile): Use
16666         compunit_filetabs.
16667         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16668         (ALL_FILETABS): Use compunit_filetabs.
16669         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16670         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16671
16672 2019-01-09  Tom Tromey  <tom@tromey.com>
16673
16674         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16675         (compunit_filetabs): New.
16676         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16677         compunit_filetabs.
16678         (info_sources_command, make_source_files_completion_list): Remove
16679         declaration.
16680         * symmisc.c (print_objfile_statistics, dump_objfile)
16681         (maintenance_print_symbols): Remove declaration.
16682         (maintenance_info_symtabs): Use compunit_filetabs.
16683         (maintenance_info_line_tables): Likewise.
16684         * source.c (select_source_symtab): Change local variable name.
16685         (forget_cached_source_info_for_objfile): Remove declaration.
16686         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16687         * objfiles.c (objfile_relocate1): Remove declaration.
16688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16689         declaration.
16690         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16691         * coffread.c (coff_symtab_read): Remove declaration.
16692         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16693         compunit_filetabs.
16694
16695 2019-01-09  Tom Tromey  <tom@tromey.com>
16696
16697         * symtab.c (lookup_objfile_from_block)
16698         (find_pc_sect_compunit_symtab, search_symbols)
16699         (default_collect_symbol_completion_matches_break_on): Use
16700         objfile_compunits.
16701         * objfiles.h (ALL_COMPUNITS): Remove.
16702         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16703         * cp-support.c (add_symbol_overload_list_qualified): Use
16704         objfile_compunits.
16705         * ada-lang.c (ada_collect_symbol_completion_matches)
16706         (ada_add_global_exceptions): Use objfile_compunits.
16707
16708 2019-01-09  Tom Tromey  <tom@tromey.com>
16709
16710         * source.c (select_source_symtab)
16711         (forget_cached_source_info_for_objfile): Remove declaration.
16712         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16713         declaration.
16714         * maint.c (count_symtabs_and_blocks): Remove declaration.
16715         * cp-support.c (add_symbol_overload_list_qualified): Remove
16716         declaration.
16717         * coffread.c (coff_symtab_read): Remove declaration.
16718         * symtab.c (lookup_symbol_in_objfile_symtabs)
16719         (basic_lookup_transparent_type_1): Use objfile_compunits.
16720         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16721         (info_sources_command, search_symbols)
16722         (default_collect_symbol_completion_matches_break_on)
16723         (make_source_files_completion_list): Remove declaration.
16724         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16725         (ada_collect_symbol_completion_matches)
16726         (ada_add_global_exceptions): Remove declaration.
16727         * linespec.c (iterate_over_all_matching_symtabs): Use
16728         objfile_compunits.
16729         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16730         (class objfile_compunits): New.
16731         (ALL_COMPUNITS): Use objfile_compunits.
16732         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16733         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16734         objfile_compunits.
16735         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16736
16737 2019-01-09  Tom Tromey  <tom@tromey.com>
16738
16739         * symtab.c (search_symbols)
16740         (default_collect_symbol_completion_matches_break_on): Use
16741         objfile_msymbols.
16742         * ada-lang.c (ada_lookup_simple_minsym)
16743         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16744         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16745         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16746         objfile_msymbols.
16747         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16748         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16749         * objc-lang.c (find_methods): Use objfile_msymbols.
16750         (info_selectors_command, info_classes_command): Likewise.
16751         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16752         * objfiles.h (class objfile_msymbols): New.
16753         (ALL_OBJFILE_MSYMBOLS): Remove.
16754         (ALL_MSYMBOLS): Remove.
16755
16756 2019-01-09  Tom Tromey  <tom@tromey.com>
16757
16758         * common/next-iterator.h (next_adapter): Add Iterator template
16759         parameter.
16760         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16761         (class all_objfiles_safe): New.
16762         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16763         * objfiles.c (put_objfile_before): Update comment.
16764         (add_separate_debug_objfile): Likewise.
16765         (free_all_objfiles): Use all_objfiles_safe.
16766         (objfile_purge_solibs): Likewise.
16767
16768 2019-01-09  Tom Tromey  <tom@tromey.com>
16769
16770         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16771         (expand_symtab_containing_pc, lookup_static_symbol)
16772         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16773         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16774         all_objfiles.
16775         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16776         * breakpoint.c (create_overlay_event_breakpoint)
16777         (create_longjmp_master_breakpoint)
16778         (create_std_terminate_master_breakpoint)
16779         (create_exception_master_breakpoint): Use all_objfiles.
16780         * linux-thread-db.c (try_thread_db_load_from_pdir)
16781         (has_libpthread): Use all_objfiles.
16782         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16783         * linespec.c (iterate_over_all_matching_symtabs)
16784         (search_minsyms_for_name): Use all_objfiles.
16785         * maint.c (maintenance_info_sections): Use all_objfiles.
16786         * main.c (captured_main_1): Use all_objfiles.
16787         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16788         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16789         * guile/scm-pretty-print.c
16790         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16791         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16792         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16793         (maintenance_print_msymbols): Use all_objfiles.
16794         * source.c (select_source_symtab): Use all_objfiles.
16795         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16796         * symfile.c (remove_symbol_file_command)
16797         (expand_symtabs_matching, map_symbol_filenames): Use
16798         all_objfiles.
16799         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16800         all_objfiles.
16801         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16802         * objc-lang.c (find_methods): Use all_objfiles.
16803         * objfiles.c (have_partial_symbols, have_full_symbols)
16804         (have_minimal_symbols, qsort_cmp)
16805         (default_iterate_over_objfiles_in_search_order): Use
16806         all_objfiles.
16807         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16808         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16809         (maintenance_check_psymtabs): Use all_objfiles.
16810         (ALL_PSYMTABS): Remove.
16811         * compile/compile-object-run.c (do_module_cleanup): Use
16812         all_objfiles.
16813         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16814         * cp-support.c (add_symbol_overload_list_qualified): Use
16815         all_objfiles.
16816         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16817         Use all_objfiles.
16818         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16819         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16820         all_objfiles.
16821         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16822         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16823         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16824         Uses all_objfiles.
16825         * solib.c (solib_read_symbols): Use all_objfiles
16826
16827 2019-01-09  Tom Tromey  <tom@tromey.com>
16828
16829         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16830         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16831         all_objfiles.
16832         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16833         * symmisc.c (print_symbol_bcache_statistics)
16834         (print_objfile_statistics, maintenance_print_objfiles)
16835         (maintenance_info_symtabs, maintenance_check_symtabs)
16836         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16837         all_objfiles.
16838         * source.c (forget_cached_source_info): Use all_objfiles.
16839         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16840         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16841         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16842         * objfiles.c (update_section_map): Use all_objfiles.
16843         (shared_objfile_contains_address_p): Likewise.
16844         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16845         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16846
16847 2019-01-09  Tom Tromey  <tom@tromey.com>
16848
16849         * common/next-iterator.h: New file.
16850         * objfiles.h (class all_objfiles): New.
16851         (struct objfile_iterator): New.
16852
16853 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16854
16855         * NEWS: Move the description of the changed "frame", "select-frame",
16856          and "info frame" commands to the Changed commands section.
16857
16858 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16859
16860         * gdbtypes.c (check_stub_method_group): Remove handling of old
16861         mangling schemes.
16862         * linespec.c (find_methods): Likewise.
16863         * stabsread.c (read_member_functions): Likewise.
16864         * valops.c (search_struct_method): Likewise.
16865         (value_struct_elt_for_reference): Likewise.
16866         * NEWS: Mention this change.
16867
16868 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16869
16870         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16871         print_source_lines.
16872         * source.c (print_source_lines_base): Update line number check.
16873         (print_source_lines): New function.
16874         (source_lines_range::source_lines_range): New function.
16875         * source.h (class source_lines_range): New class.
16876         (print_source_lines): New declaration.
16877
16878 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16879
16880         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16881
16882 2019-01-08  Tom Tromey  <tom@tromey.com>
16883             Simon Marchi  <simon.marchi@ericsson.com>
16884
16885         PR gdb/24060
16886         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16887         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16888         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16889         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16890         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16891         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16892
16893 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16894
16895         * source.c (select_source_symtab): Move header comment to
16896         declaration in source.h.
16897         (forget_cached_source_info_for_objfile): Likewise.
16898         (forget_cached_source_info): Likewise.
16899         (identify_source_line): Likewise.
16900         * source.h (identify_source_line): Move declaration from symtab.h
16901         and add comment from source.c
16902         (print_source_lines): Likewise.
16903         (forget_cached_source_info_for_objfile): Likewise.
16904         (forget_cached_source_info): Likewise.
16905         (select_source_symtab): Likewise.
16906         (enum print_source_lines_flag): Move definition from symtab.h.
16907         * symtab.h (identify_source_line): Move declaration to source.h.
16908         (print_source_lines): Likewise.
16909         (forget_cached_source_info_for_objfile): Likewise.
16910         (forget_cached_source_info): Likewise.
16911         (select_source_symtab): Likewise.
16912         (enum print_source_lines_flag): Move definition to source.h.
16913         * tui/tui-hooks.c: Add 'source.h' include.
16914
16915 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16916
16917         * source.c (print_source_lines_base): Handle requests to print
16918         reverse line number sequences, and guard against empty lines
16919         string.
16920
16921 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16922
16923         * source.c (print_source_lines_base): Fix skip of '\r' if next
16924         character is '\n'.
16925
16926 2019-01-06  Tom Tromey  <tom@tromey.com>
16927
16928         * c-exp.y (struct c_parse_state) <macro_original_text,
16929         expansion_obstack>: New member.
16930         (macro_original_text, expansion_obstack): Remove globals.
16931         (scan_macro_expansion, scanning_macro_expansion)
16932         (finished_macro_expansion): Update.
16933         (scan_macro_cleanup): Remove.
16934         (yylex, c_parse): Update.
16935
16936 2019-01-06  Tom Tromey  <tom@tromey.com>
16937
16938         * c-exp.y (struct c_parse_state) <strings>: New member.
16939         (operator_stoken): Update.
16940
16941 2019-01-06  Tom Tromey  <tom@tromey.com>
16942
16943         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16944         (union type_stack_elt) <typelist_val>: Now a pointer to
16945         std::vector.
16946         (type_stack_cleanup): Don't declare.
16947         (push_typelist): Update.
16948         * parse.c (pop_typelist): Return a std::vector.
16949         (push_typelist): Take a std::vector.
16950         (follow_types): Update.  Do not free args.
16951         (type_stack_cleanup): Remove.
16952         * c-exp.y (struct c_parse_state): New.
16953         (cpstate): New global.
16954         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16955         (nonempty_typelist): Update.
16956         (func_mod): Create a new vector.
16957         (c_parse): Create a c_parse_state.
16958         (check_parameter_typelist): Do not delete params.
16959         (function_method): Update.  Do not delete type_list.
16960
16961 2019-01-06  Tom Tromey  <tom@tromey.com>
16962
16963         PR gdb/28155:
16964         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16965         check_typedef.
16966         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16967         (print_return_value): Likewise.
16968
16969 2019-01-05  Tom Tromey  <tom@tromey.com>
16970
16971         * contrib/cleanup_check.py: Remove.
16972         * contrib/gcc-with-excheck: Remove.
16973         * contrib/exsummary.py: Remove.
16974         * contrib/excheck.py: Remove.
16975
16976 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16977
16978         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16979         NULL. Initialize tpprev to NULL instead of assigning it
16980         to NULL on the next statement.
16981         * windows-nat.c (windows_delete_thread): Remove check for
16982         main_thread_id before printing thread exit notifications.
16983         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16984         Remove thread ID check against main_thread_id.
16985         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16986         windows_delete_thread.
16987         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16988
16989 2019-01-04  Tom Tromey  <tom@tromey.com>
16990
16991         * compile/compile.c (_initialize_compile): Use upper case for
16992         metasyntactic variables.
16993         * symmisc.c (_initialize_symmisc): Use upper case for
16994         metasyntactic variables.
16995         * psymtab.c (_initialize_psymtab): Use upper case for
16996         metasyntactic variables.
16997         * demangle.c (demangle_command): Use upper case for metasyntactic
16998         variables.
16999         (_initialize_demangler): Likewise.
17000         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17001         variables.
17002
17003 2019-01-03  Tom Tromey  <tom@tromey.com>
17004
17005         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17006
17007 2019-01-03  Tom Tromey  <tom@tromey.com>
17008
17009         * python/py-symtab.c (salpy_str): Update.
17010         (struct salpy_sal_object) <symtab>: Now a PyObject.
17011         (salpy_dealloc): Update.
17012         (del_objfile_sal): Use gdbpy_ref.
17013
17014 2019-01-03  Tom Tromey  <tom@tromey.com>
17015
17016         * python/py-type.c (convert_field): Use new_reference.  Return
17017         gdbpy_ref.
17018         (make_fielditem): Return gdbpy_ref.
17019         (typy_fields): Update.
17020         (typy_getitem): Update.
17021         (field_name): Return gdbpy_ref.  Use new_reference.
17022         (typy_iterator_iternext): Update.
17023
17024 2019-01-03  Tom Tromey  <tom@tromey.com>
17025
17026         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17027
17028 2019-01-03  Tom Tromey  <tom@tromey.com>
17029
17030         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17031         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17032         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17033         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17034         (pspy_set_type_printers): Likewise.
17035         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17036         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17037         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17038         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17039         (objfpy_set_type_printers): Likewise.
17040
17041 2019-01-03  Tom Tromey  <tom@tromey.com>
17042
17043         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17044         (gdbpy_print_stack): Use gdbpy_err_fetch.
17045         * python/python-internal.h (class gdbpy_err_fetch): New class.
17046         (class gdbpy_enter) <m_error_type, m_error_value,
17047         m_error_traceback>: Remove.
17048         <m_error>: New member.
17049         (gdbpy_exception_to_string): Don't declare.
17050         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17051         * python/py-value.c (convert_value_from_python): Use
17052         gdbpy_err_fetch.
17053         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17054         gdbpy_exception_to_string.
17055         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17056         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17057         gdbpy_err_fetch.
17058
17059 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17060
17061         * linux-nat.c (delete_lwp_cleanup): Delete.
17062         (struct lwp_deleter): New struct.
17063         (lwp_info_up): New typedef.
17064         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17065         lwp_info_up.
17066
17067 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17068
17069         * linux-fork.c (class scoped_switch_fork_info): New class.
17070         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17071
17072 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17073
17074         * valops.c (find_overload_match): Remove use of null_cleanup, and
17075         calls to do_cleanups.
17076
17077 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17078
17079         * compile/compile-cplus-types.c
17080         (compile_cplus_instance::decl_name): Handle changes to
17081         cp_func_name.
17082         * cp-support.c (cp_func_name): Update header comment, update
17083         return type.
17084         * cp-support.h (cp_func_name): Update return type in declaration.
17085         * valops.c (find_overload_match): Move temp_func local to top
17086         level of function and change its type.  Use temp_func to hold and
17087         delete temporary string obtained from cp_func_name.
17088
17089 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17090
17091         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17092         gdb::char_vector, remove cleanup, and update uses of `msg`.
17093
17094 2019-01-03  Jim Wilson  <jimw@sifive.com>
17095
17096         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17097
17098 2019-01-02  Tom Tromey  <tom@tromey.com>
17099
17100         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17101         (tdesc_parse_xml): Remove cleanups.
17102         * target-descriptions.h (make_cleanup_free_target_description):
17103         Don't declare.
17104         (target_desc_deleter): New struct.
17105         (target_desc_up): New typedef.
17106         * target-descriptions.c (target_desc_deleter::operator()): Rename
17107         from free_target_description.
17108         (make_cleanup_free_target_description): Remove.
17109
17110 2019-01-02  Tom Tromey  <tom@tromey.com>
17111
17112         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17113         constructor, destructor.
17114         (linespec_parser): Remove typedef.
17115         (~linespec_parser): Rename from linespec_parser_delete.
17116         (linespec_lex_to_end, linespec_complete_label)
17117         (linespec_complete): Update.
17118         (decode_line_full): Remove cleanups.
17119         (decode_line_1): Update.
17120
17121 2019-01-02  Tom Tromey  <tom@tromey.com>
17122
17123         * python/python-internal.h (inferior_to_inferior_object): Change
17124         return type.
17125         * python/py-exitedevent.c (create_exited_event_object): Update.
17126         * python/py-inferior.c (inferior_to_inferior_object): Return
17127         gdbpy_ref.
17128         (python_new_inferior, python_inferior_deleted)
17129         (thread_to_thread_object, delete_thread_object)
17130         (build_inferior_list, gdbpy_selected_inferior): Update.
17131         * python/py-infthread.c (create_thread_object): Update.  Also fail
17132         if inferior_to_inferior_object fails.
17133
17134 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17135
17136         * inferior.h (class inferior) <displaced_step_state>: New field.
17137         * infrun.h (struct displaced_step_state): Move here from
17138         infrun.c.  Initialize fields, add constructor.
17139         <inf>: Remove field.
17140         <reset>: New method.
17141         * infrun.c (struct displaced_step_inferior_state): Move to
17142         infrun.h.
17143         (displaced_step_inferior_states): Remove.
17144         (get_displaced_stepping_state): Adust.
17145         (displaced_step_in_progress_any_inferior): Adjust.
17146         (displaced_step_in_progress_thread): Adjust.
17147         (displaced_step_in_progress): Adjust.
17148         (add_displaced_stepping_state): Remove.
17149         (get_displaced_step_closure_by_addr): Adjust.
17150         (remove_displaced_stepping_state): Remove.
17151         (infrun_inferior_exit): Call displaced_step_state.reset.
17152         (use_displaced_stepping): Don't check for NULL.
17153         (displaced_step_prepare_throw): Call
17154         get_displaced_stepping_state.
17155         (displaced_step_fixup): Don't check for NULL.
17156         (prepare_for_detach): Don't check for NULL.
17157
17158 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17159
17160         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17161          in case of call that did not complete.
17162
17163 2019-01-02  Andrey Utkin  <autkin@undo.io>
17164
17165         * symfile.c (find_separate_debug_file): Fix search of debug files for
17166         remote debuggee.
17167
17168 2019-01-02  Tom Tromey  <tom@tromey.com>
17169
17170         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17171         indentation.
17172         * python/py-frame.c (frapy_older): Remove cast.
17173         (frapy_newer): Likewise.
17174         * python/py-breakpoint.c (local_setattro): Remove cast.
17175         * python/py-arch.c (archpy_name): Remove local variable.
17176         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17177
17178 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17179
17180         * unittests/basic_string_view/element_access/char/empty.cc:
17181         Fix year range in copyright header.
17182
17183 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17184
17185         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17186         Delete.
17187         <operator==>: Update with for removed field.
17188         <hash>: Likewise.
17189         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17190         <isa_features>: ...this.
17191         <abi_features>: New field.
17192         (riscv_isa_flen): Update comment.
17193         (riscv_abi_xlen): New declaration.
17194         (riscv_abi_flen): New declaration.
17195         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17196         isa_features.
17197         (riscv_abi_xlen): New function.
17198         (riscv_isa_flen): Update to get answer from isa_features.
17199         (riscv_abi_flen): New function.
17200         (riscv_has_fp_abi): Update to get answer from abi_features.
17201         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17202         xlen and flen.
17203         (riscv_call_info) <xlen, flen>: Update comment.
17204         (riscv_call_arg_struct): Remove invalid assertions
17205         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17206         is removed.
17207         (riscv_gdbarch_init): Gather isa features and abi features
17208         separately, ensure both match on the gdbarch when reusing an old
17209         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17210         a target with 64-bit float hardware.
17211
17212 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17213
17214         * source.c (search_command_helper): Stop reverse search
17215         when line 1 has been searched.
17216
17217 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17218
17219         * record-full.c (record_full_base_target::close): Rewrite
17220         record_full_core_buf_list free logic.
17221
17222 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17223
17224         * break-catch-syscall.c (print_one_catch_syscall): xfree
17225         the last text.
17226
17227 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17228
17229         * top.c (print_gdb_version): Update Copyright year in version
17230         message.
17231
17232 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17233
17234         Update copyright year range in all GDB files.
17235
17236 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17237
17238         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17239
17240 For older changes see ChangeLog-2018.
17241 \f
17242 Local Variables:
17243 mode: change-log
17244 left-margin: 8
17245 fill-column: 74
17246 version-control: never
17247 coding: utf-8
17248 End:
17249