gdb/ChangeLog

   1 2019-11-19  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
   4         Now static.  Change type of "name".
   5         (tui_set_win_height_command): Don't copy "arg".
   6         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
   7         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
   8
   9 2019-11-19  Ali Tamur <tamur@google.com>
  10
  11         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
  12         "if (attr != nullptr)".
  13         (dwarf2_find_base_address): Likewise.
  14         (dwarf2_build_include_psymtabs): Likewise.
  15         (read_cutu_die_from_dwo): Likewise.
  16         (read_func_scope): Likewise.
  17         (read_call_site_scope): Likewise.
  18         (dwarf2_get_pc_bounds): Likewise.
  19         (dwarf2_record_block_ranges): Likewise.
  20         (dwarf2_add_field): Likewise.
  21         (dwarf2_add_member_fn): Likewise.
  22         (read_structure_type): Likewise.
  23         (read_enumeration_type): Likewise.
  24         (read_array_type): Likewise.
  25         (read_array_order): Likewise.
  26         (read_set_type): Likewise.
  27         (read_common_block): Likewise.
  28         (read_tag_reference_type): Likewise.
  29         (read_tag_string_type): Likewise.
  30         (read_subroutine_type): Likewise.
  31         (read_base_type): Likewise.
  32         (read_subrange_type): Likewise.
  33         (new_symbol): Likewise.
  34         (prepare_one_comp_unit): Likewise.
  35
  36 2019-11-19  Tom Tromey  <tromey@adacore.com>
  37
  38         * windows-nat.c (windows_nat_target::attach): Include GetLastError
  39         result in error when DebugActiveProcess fails.
  40
  41 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
  42             Pedro Alves  <palves@redhat.com>
  43
  44         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
  45         * target.c (target_stack::push): Call 'unpush' if there's a
  46         target on top of the stack.
  47
  48 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  49
  50         * python/py-block.c (blpy_dealloc): Call tp_free.
  51         (blpy_block_syms_dealloc): Likewise.
  52         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
  53         * python/py-inferior.c (infpy_dealloc): Likewise.
  54         * python/py-lazy-string.c (stpy_dealloc): Likewise.
  55         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
  56         * python/py-symbol.c (sympy_dealloc): Likewise.
  57         * python/py-symtab.c (stpy_dealloc): Likewise.
  58         * python/py-type.c (typy_iterator_dealloc): Likewise.
  59
  60 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
  61
  62         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
  63         constructor instead of using a class initializer.
  64
  65 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  66
  67         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
  68         * configure: Regenerate.
  69         * configure.ac: Don't source common.host.
  70         * gdbsupport/common.host: Remove.
  71         * gdbsupport/mingw-strerror.c: Remove.
  72         * gdbsupport/posix-strerror.c: Rename to...
  73         * gdbsupport/safe-strerror.c: ...this.
  74
  75 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * maint.c (scoped_command_stats::print_time): Use localtime_r
  78         instead of localtime (provided through gnulib if necessary).
  79         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
  80         of ctime.
  81
  82 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  83
  84         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
  85         avoid compile errors.
  86
  87 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
  88
  89         * config.in: Regenerate.
  90         * configure: Regenerate.
  91         * gdbsupport/common.m4: No longer check for strerror_r.
  92         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
  93         POSIX version of strerror_r, now that gnulib provides it if
  94         necessary.
  95
  96 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * README (`configure' options): Update.
  99
 100 2019-11-14  Tom Tromey  <tromey@adacore.com>
 101
 102         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
 103         expected type for the RHS if the LHS is a convenience variable.
 104
 105 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
 106
 107         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
 108         Provide explicit default and copy constructor.
 109
 110 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 111
 112         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
 113         only call Py_INCREF (newbp) in the bppy_pending_object case.
 114
 115 2019-11-13  Tom Tromey  <tromey@adacore.com>
 116
 117         PR build/25182:
 118         * psympriv.h (partial_symbol): Remove static assert.
 119         * symtab.h (general_symbol_info, symbol): Remove static assert.
 120
 121 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 122
 123         * gdbsupport/format.c (format_pieces::format_pieces): Support
 124         printf 'z' size modifier.
 125         * gdbsupport/format.h (enum argclass): Add size_t_arg.
 126         * printcmd.c (ui_printf):  Handle size_t_arg.
 127         * ui-out.c (ui_out::vmessage): Likewise.
 128         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
 129         function.
 130         (run_tests): Call test_format_int_sizes.
 131
 132 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
 133
 134         * ada-exp.y (write_ambiguous_var): Update.
 135         * buildsym.c (add_symbol_to_list): Update.
 136         * dwarf2read.c (read_variable): Update.
 137         (new_symbol): Update.
 138         * jit.c (finalize_symtab): Update.
 139         * language.c (language_alloc_type_symbol): Update.
 140         * symtab.c (fixup_symbol_section): Update.
 141         (initialize_objfile_symbol_1): Move code to...
 142         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 143         (allocate_symbol): Update.
 144         (allocate_template_symbol): Update.
 145         (get_symbol_address): Update.
 146         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 147         of having as a field, and add a constructor.
 148         (SYMBOL_VALUE): Update.
 149         (SYMBOL_VALUE_ADDRESS): Update.
 150         (SET_SYMBOL_VALUE_ADDRESS): Update.
 151         (SYMBOL_VALUE_BYTES): Update.
 152         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 153         (SYMBOL_BLOCK_VALUE): Update.
 154         (SYMBOL_VALUE_CHAIN): Update.
 155         (SYMBOL_LANGUAGE): Update.
 156         (SYMBOL_SECTION): Update.
 157         (SYMBOL_OBJ_SECTION): Update.
 158         (SYMBOL_SET_LANGUAGE): Update.
 159         (SYMBOL_SET_LINKAGE_NAME): Update.
 160         (SYMBOL_SET_NAMES): Update.
 161         (SYMBOL_NATURAL_NAME): Update.
 162         (SYMBOL_LINKAGE_NAME): Update.
 163         (SYMBOL_DEMANGLED_NAME): Update.
 164         (SYMBOL_SEARCH_NAME): Update.
 165         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 166         (struct symbol): Update.
 167         (struct template_symbol): Update.
 168         (struct rust_vtable_symbol): Update.
 169         * xcoffread.c (SYMBOL_DUP): Update.
 170
 171 2019-11-12  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-layout.c (show_layout): Set current_layout.
 174         (show_source_disasm_command, show_data)
 175         (show_source_or_disasm_and_command): Don't set current_layout.
 176
 177 2019-11-12  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 180
 181 2019-11-12  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-win.c (resize_message): New global.
 184         (show_tui_resize_message): New function.
 185         (tui_async_resize_screen): Print message if requested.
 186         (_initialize_tui_win): Add tui-resize-message setting.
 187         * NEWS: Add entry for new commands.
 188
 189 2019-11-11  Tom Tromey  <tom@tromey.com>
 190
 191         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 192         functions.
 193
 194 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 195
 196         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 197
 198 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 199
 200         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 201         function.
 202         * python/python-internal.h (gdbpy_lookup_static_symbols):
 203         Declare new function.
 204         * python/python.c (python_GdbMethods): Add
 205         gdb.lookup_static_symbols method.
 206         * NEWS: Mention gdb.lookup_static_symbols.
 207
 208 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 209
 210         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 211         static block of current object file first.  Also fix typo in
 212         header comment.
 213
 214 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 215
 216         * stack.c (set_last_displayed_sal): Delete.
 217         (last_displayed_sal_valid): Delete.
 218         (last_displayed_pspace): Delete.
 219         (last_displayed_addr): Delete.
 220         (last_displayed_symtab): Delete.
 221         (last_displayed_line): Delete.
 222         (class last_displayed_symtab_info_type): New.
 223         (last_displayed_symtab_info): New static global variable.
 224         (print_frame_info): Call methods on last_displayed_symtab_info.
 225         (clear_last_displayed_sal): Update header comment, and make use of
 226         last_displayed_symtab_info.
 227         (last_displayed_sal_is_valid): Likewise.
 228         (get_last_displayed_pspace): Likewise.
 229         (get_last_displayed_addr): Likewise.
 230         (get_last_displayed_symtab): Likewise.
 231         (get_last_displayed_line): Likewise.
 232         (get_last_displayed_sal): Likewise.
 233         * stack.h (clear_last_displayed_sal): Update header comment.
 234         (last_displayed_sal_is_valid): Likewise.
 235         (get_last_displayed_pspace): Likewise.
 236         (get_last_displayed_addr): Likewise.
 237         (get_last_displayed_symtab): Likewise.
 238         (get_last_displayed_line): Likewise.
 239         (get_last_displayed_sal): Likewise.
 240
 241 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * stack.c (frame_show_address): Convert return type to bool.
 244         * stack.h (frame_show_address): Likewise, and update header
 245         comment.
 246
 247 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 248
 249         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 250         * unittests/vec-utils-selftests.c: New file.
 251         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 252
 253 2019-11-10  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 256         (tui_highlight_win): Likewise.
 257         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 258         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 259         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 260         Don't set can_highlight.
 261
 262 2019-11-10  Tom Tromey  <tom@tromey.com>
 263
 264         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 265         Remove unused declaration.
 266
 267 2019-11-08  Tom Tromey  <tromey@adacore.com>
 268
 269         * top.c (read_command_file): Update.
 270         (command_line_input): Make return type const.
 271         * python/py-gdb-readline.c: Update.
 272         * linespec.c (decode_line_2): Update.
 273         * defs.h (command_line_input): Make return type const.
 274         * cli/cli-script.c (read_next_line): Make return type const.
 275         * ada-lang.c (get_selections): Update.
 276
 277 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 280         * mi/mi-main.c (output_cores): Likewise.
 281         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 282         (linux_xfer_osdata_modules): Likewise.
 283         * remote.c (register_remote_support_xml): Likewise.
 284         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 285         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 286
 287 2019-11-06  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-interp.c: Don't include readline.h.
 290         * tui/tui-hooks.c: Don't include readline.h.
 291         * symmisc.c: Include tilde.h, not readline.h.
 292         * symfile.c: Include tilde.h, not readline.h.
 293         * source.c: Include tilde.h, not readline.h.
 294         * solib.c: Include tilde.h, not readline.h.
 295         * psymtab.c: Include tilde.h, not readline.h.
 296         * exec.c: Include tilde.h, not readline.h.
 297         * corelow.c: Include tilde.h, not readline.h.
 298         * cli/cli-dump.c: Include tilde.h, not readline.h.
 299         * cli/cli-cmds.c: Don't include readline.h.
 300
 301 2019-11-05  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 304         (tui_disassemble): Set addr_size.
 305         (tui_disasm_window::set_contents): Use addr_size.
 306
 307 2019-11-05  Tom Tromey  <tom@tromey.com>
 308
 309         * rust-lang.c (rust_language_defn): Update.
 310         * python/py-value.c (valpy_string): Call c_get_string.
 311         * p-lang.c (pascal_language_defn): Update.
 312         * opencl-lang.c (opencl_language_defn): Update.
 313         * objc-lang.c (objc_language_defn): Update.
 314         * m2-lang.c (m2_language_defn): Update.
 315         * language.c (unknown_language_defn, auto_language_defn): Update.
 316         (default_get_string): Remove.
 317         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 318         * go-lang.c (go_language_defn): Update.
 319         * f-lang.c (f_language_defn): Update.
 320         * d-lang.c (d_language_defn): Update.
 321         * c-lang.c (c_language_defn, cplus_language_defn)
 322         (asm_language_defn, minimal_language_defn): Update.
 323         * ada-lang.c (ada_language_defn): Update.
 324         * language.h (struct language_defn) <la_get_string>: Remove.
 325         (LA_GET_STRING): Remove.
 326         (default_get_string): Don't declare.
 327
 328 2019-11-05  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-source.h (struct tui_source_window): Inline
 331         constructor.  Remove destructor.
 332         <style_changed, m_observable>: Move to superclass.
 333         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 334         (struct tui_source_window_base): Move private members to end.
 335         <style_changed, m_observable>: Move from tui_source_window.
 336         * tui/tui-winsource.c (tui_copy_source_line): Move from
 337         tui-source.c.  Rename from copy_source_line.  Add special handling
 338         for negative line number.
 339         (tui_source_window_base::style_changed): Move from
 340         tui_source_window.
 341         (tui_source_window_base): Register observer.
 342         (~tui_source_window_base): New.
 343         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 344         rename.
 345         (tui_source_window::set_contents): Use tui_copy_source_line.
 346         (tui_source_window::tui_source_window): Move to tui-source.h.
 347         (tui_source_window::~tui_source_window): Remove.
 348         (tui_source_window::style_changed): Move to superclass.
 349         * tui/tui-disasm.c (tui_disassemble): Create string file with
 350         styling, when possible.  Add "addr_size" parameter.
 351         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 352         Don't compute maximum size.
 353         (len_without_escapes): New function
 354
 355 2019-11-05  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 358         std::string.
 359         * tui/tui-winsource.c (tui_show_source_line): Update.
 360         * tui/tui-source.c (tui_source_window::set_contents): Update.
 361         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 362
 363 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 364
 365         * symtab.h (gdb_static_assert): Put && operator at the beginning
 366         of the line instead of the end.
 367
 368 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 369
 370         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 371         and sizeof (symbol).
 372         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 373
 374 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 375
 376         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 377         * configure.host: Mark *-*-solaris2.10* obsolete.
 378         * configure.tgt: Mark Solaris < 11 obsolete.
 379         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 380         Update target triplet.
 381
 382 2019-11-01  Tom Tromey  <tromey@adacore.com>
 383
 384         * utils.c (print_sys_errmsg): Simplify.
 385
 386 2019-11-01  Tom Tromey  <tromey@adacore.com>
 387
 388         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 389
 390 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 391
 392         * configure: Regenerate.
 393         * configure.ac: Remove check for strerror_r.
 394         * gdbsupport/common.m4: Check for strerror_r.
 395
 396 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 397
 398         PR gdb/25124
 399
 400         * arm-tdep.c (arm_per_objfile): Rename to ...
 401         (arm_per_bfd): ... this.
 402         (arm_objfile_data_key): Rename to ...
 403         (arm_bfd_data_key): ... this.
 404         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 405         data.
 406         (arm_record_special_symbol): Likewise.
 407
 408 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 411         end.
 412         * c-typeprint.c (c_print_typedef): Likewise.
 413         * f-typeprint.c (f_print_typedef): Likewise.
 414         * m2-typeprint.c (m2_print_typedef): Likewise.
 415         * p-typeprint.c (pascal_print_typedef): Likewise.
 416         * rust-lang.c (rust_print_typedef): Likewise.
 417         * symtab.c (print_symbol_info): Print a newline after calling
 418         typedef_print.
 419
 420 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         * symtab.c (info_module_cmdlist): New variable.
 423         (info_module_command): New function.
 424         (search_module_symbols): New function.
 425         (info_module_subcommand): New function.
 426         (struct info_modules_var_func_options): New struct.
 427         (info_modules_var_func_options_defs): New variable.
 428         (make_info_modules_var_func_options_def_group): New function.
 429         (info_module_functions_command): New function.
 430         (info_module_variables_command): New function.
 431         (info_module_var_func_command_completer): New function.
 432         (_initialize_symtab): Register new 'info module functions' and
 433         'info module variables' commands.
 434         * symtab.h (typedef symbol_search_in_module): New typedef.
 435         (search_module_symbols): Declare new function.
 436         * NEWS: Mention new commands.
 437
 438 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 441         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 442         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 443         MODULES_DOMAIN.
 444         (scan_partial_symbols): Only create partial module symbols for non
 445         declarations.
 446         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 447         and MODULES_DOMAIN.
 448         * symtab.c (search_domain_name): Likewise.
 449         (search_symbols): Likewise.
 450         (print_symbol_info): Likewise.
 451         (symtab_symbol_info): Likewise.
 452         (info_modules_command): New function.
 453         (_initialize_symtab): Register 'info modules' command.
 454         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 455         * NEWS: Mention new 'info modules' command.
 456
 457 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 458
 459         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 460         and $_gdb_maint_setting_str.
 461
 462 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 463
 464         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 465         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 466         (str_value_from_setting, gdb_setting_str_internal_fn)
 467         (gdb_maint_setting_str_internal_fn): New functions.
 468         (_initialize_cli_cmds): Define the new convenience functions.
 469         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 470         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 471
 472 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 473
 474         * agent.c (set_can_use_agent): When the setting is turned on,
 475         look up agent symbols if we don't have them yet.
 476         (agent_new_objfile): Don't look up agent symbols when the agent
 477         setting is off.
 478
 479 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * config.in: Regenerate.
 482
 483 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 484
 485         * configure: Regenerate.
 486         * configure.ac: Check for strerror_r.
 487         * gdbsupport/common-utils.h (safe_strerror): Change return value
 488         to const char * and document that this function is now threadsafe.
 489         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 490         thread_local and call strerror_r, if available.
 491         * utils.c (perror_string): Update.
 492         (print_sys_errmsg): Update.
 493
 494 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 495
 496         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 497         objfile_key.
 498         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 499         objfile to fetch per-bfd data.
 500         (arm_find_exidx_entry): Likewise.
 501
 502 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * gdbsupport/agent.c (debug_agent): Change type to bool.
 505         (use_agent): Likewise.
 506         (all_agent_symbols_look_up): Likewise.
 507         (agent_loaded_p): Change return value to bool.
 508         (agent_look_up_symbols): Update.
 509         (agent_capability_check): Change return value to bool.
 510         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 511         (debug_agent): Change type to bool.
 512         (use_agent): Likewise.
 513         (agent_capability_check): Change return value to bool.
 514
 515 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 516
 517         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 518         (build_minimal_symbol_hash_tables): Code to clear the table moved
 519         to clear_minimal_symbol_hash_tables.
 520         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 521         when needed.
 522
 523 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 524
 525         * infcmd.c: Remove includes.
 526         * infrun.c: Remove includes.
 527
 528 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 529
 530         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 531         (grow_vect): Remove declaration.
 532         (ada_type_of_array): Remove declaration.
 533         (ada_update_initial_language): Remove declaration.
 534         (ada_fold_name): Remove declaration.
 535         (ada_fill_in_ada_prototype): Remove declaration.
 536         (user_select_syms): Remove declaration.
 537         (get_selections): Remove declaration.
 538         (ada_tag_type): Remove declaration.
 539         (ada_value_tag): Remove declaration.
 540         (ada_is_others_clause): Remove declaration.
 541         (ada_in_variant): Remove declaration.
 542         (ada_value_struct_elt): Remove declaration.
 543         (ada_attribute_name): Remove declaration.
 544         (ada_system_address_type): Remove declaration.
 545         * ada-lang.c (ada_watch_location_expression): Make static.
 546         (GROW_VECT): Move here from ada-lang.h.
 547         (grow_vect): Make static.
 548         (ada_update_initial_language): Make static.
 549         (ada_fold_name): Make static.
 550         (ada_type_of_array): Make static.
 551         (encoded_ordered_before): Move up.
 552         (sort_choices): Move up.
 553         (print_signatures): Move up.
 554         (ada_print_symbol_signature): Move up.
 555         (get_selections): Move up and make static.
 556         (user_select_syms): Move up and make static.
 557         (ada_value_struct_elt): Move up and make static.
 558         (ada_tag_type): Make static.
 559         (ada_value_tag): Make static.
 560         (ada_is_others_clause): Make static.
 561         (ada_in_variant): Make static.
 562         (ada_attribute_name): Make static.
 563
 564 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 565
 566         * ada-lang.c: Remove includes.
 567         * ada-typeprint.c: Remove includes.
 568         * ada-valprint.c: Remove includes.
 569
 570 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 571
 572         * addrmap.c: Add static assertions of type size, moved from
 573         _initialize_addrmap.
 574         (_initialize_addrmap): Remove.
 575
 576 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 577
 578         * coffread.c (record_minimal_symbol): Update.
 579         (process_coff_symbol): Update.
 580         * dbxread.c (read_dbx_symtab): Update.
 581         * dwarf2read.c (add_partial_symbol): Update.
 582         (fixup_go_packaging): Update.
 583         (load_partial_dies): Update.
 584         (new_symbol): Update.
 585         * elfread.c (record_minimal_symbol): Change signature to use
 586         gdb::string_view instead of name+len.
 587         (elf_symtab_read): Update.
 588         (elf_rel_plt_read): Update.
 589         * mdebugread.c (parse_partial_symbols): Update.
 590         (handle_psymbol_enumerators): Update.
 591         (new_symbol): Update.
 592         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 593         to use gdb::string_view instead of name+len.
 594         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 595         * psympriv.h (add_psymbol_to_list): Likewise.
 596         * psymtab.c (add_psymbol_to_bcache): Likewise.
 597         (add_psymbol_to_list): Likewise.
 598         * stabsread.c (define_symbol): Update.
 599         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 600         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 601         (symbol_set_names): Likewise.
 602         * xcoffread.c (scan_xcoff_symtab): Update.
 603
 604 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 605
 606         * symtab.h (symbol_set_names): Document that copy_name must be
 607         set to true for non-nullterminated strings.
 608         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 609         linkage_name if the entry was not found and we need to demangle.
 610
 611 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 612
 613         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 614         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 615         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 616         * gdbsupport/gdb_binary_search.h: New file.
 617
 618 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 619
 620         * NEWS: Mention new --with-system-gdbinit-dir option.
 621         * config.in: Regenerate.
 622         * configure: Regenerate.
 623         * configure.ac: Add new option --with-system-gdbinit-dir.
 624         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 625         for a ".gdb" suffix.
 626         * main.c (get_init_files): Change system_gdbinit argument to
 627         a vector and return the files in SYSTEM_GDBINIT_DIR in
 628         addition to SYSTEM_GDBINIT.
 629         (captured_main_1): Update.
 630         (print_gdb_help): Update.
 631         * top.c (print_gdb_configuration): Also print the value of
 632         SYSTEM_GDBINIT_DIR.
 633
 634 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 635
 636         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 637         that takes gdb::string_view arguments.
 638
 639 2019-10-26  Tom de Vries  <tdevries@suse.de>
 640
 641         * aarch64-linux-tdep.c: Fix typos in comments.
 642         * aarch64-tdep.c: Same.
 643         * ada-lang.c: Same.
 644         * amd64-nat.c: Same.
 645         * arc-tdep.c: Same.
 646         * arch/aarch64-insn.c: Same.
 647         * block.c: Same.
 648         * breakpoint.h: Same.
 649         * btrace.h: Same.
 650         * c-varobj.c: Same.
 651         * cli/cli-decode.c: Same.
 652         * cli/cli-script.c: Same.
 653         * cli/cli-utils.h: Same.
 654         * coff-pe-read.c: Same.
 655         * coffread.c: Same.
 656         * compile/compile-cplus-symbols.c: Same.
 657         * compile/compile-object-run.c: Same.
 658         * completer.c: Same.
 659         * corelow.c: Same.
 660         * cp-support.c: Same.
 661         * demangle.c: Same.
 662         * dwarf-index-write.c: Same.
 663         * dwarf2-frame.c: Same.
 664         * dwarf2-frame.h: Same.
 665         * eval.c: Same.
 666         * frame-base.h: Same.
 667         * frame.h: Same.
 668         * gdbcmd.h: Same.
 669         * gdbtypes.h: Same.
 670         * gnu-nat.c: Same.
 671         * guile/scm-objfile.c: Same.
 672         * i386-tdep.c: Same.
 673         * i386-tdep.h: Same.
 674         * infcall.c: Same.
 675         * infcall.h: Same.
 676         * linux-nat.c: Same.
 677         * m68k-tdep.c: Same.
 678         * macroexp.c: Same.
 679         * memattr.c: Same.
 680         * mi/mi-cmd-disas.c: Same.
 681         * mi/mi-getopt.h: Same.
 682         * mi/mi-main.c: Same.
 683         * minsyms.c: Same.
 684         * nat/aarch64-sve-linux-sigcontext.h: Same.
 685         * objfiles.h: Same.
 686         * ppc-linux-nat.c: Same.
 687         * ppc-linux-tdep.c: Same.
 688         * ppc-tdep.h: Same.
 689         * progspace.h: Same.
 690         * prologue-value.h: Same.
 691         * python/py-evtregistry.c: Same.
 692         * python/py-instruction.h: Same.
 693         * record-btrace.c: Same.
 694         * record-full.c: Same.
 695         * remote.c: Same.
 696         * rs6000-tdep.c: Same.
 697         * ser-tcp.c: Same.
 698         * sol-thread.c: Same.
 699         * sparc-sol2-tdep.c: Same.
 700         * sparc64-tdep.c: Same.
 701         * stabsread.c: Same.
 702         * symfile.c: Same.
 703         * symtab.h: Same.
 704         * target.c: Same.
 705         * tracepoint.c: Same.
 706         * tui/tui-data.h: Same.
 707         * tui/tui-io.c: Same.
 708         * tui/tui-win.c: Same.
 709         * tui/tui.c: Same.
 710         * unittests/rsp-low-selftests.c: Same.
 711         * user-regs.h: Same.
 712         * utils.c: Same.
 713         * utils.h: Same.
 714         * valarith.c: Same.
 715         * valops.c: Same.
 716         * valprint.c: Same.
 717         * valprint.h: Same.
 718         * value.c: Same.
 719         * value.h: Same.
 720         * varobj.c: Same.
 721         * x86-nat.h: Same.
 722         * xtensa-tdep.c: Same.
 723
 724 2019-10-25  Ali Tamur <tamur@google.com>
 725
 726         * charset.c (find_charset_names): Reflect API change.
 727
 728 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 729
 730         * symtab.c (struct demangled_name_entry): Change demangled name
 731         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 732         part of the struct anymore.
 733         (symbol_set_names): No longer obstack allocate + copy the demangled
 734         name, just store the allocated name from bfd.
 735
 736 2019-10-25  Tom Tromey  <tromey@adacore.com>
 737
 738         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 739         (bsearch_cie_cmp, add_cie): Remove.
 740         (find_cie): Reimplement.
 741         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 742         (dwarf2_build_frame_info): Update.
 743
 744 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 745
 746         PR gdb/25126
 747         * symfile.c (reread_symbols): Call forget_cached_source_info to
 748         clear the stale source cache.
 749
 750 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 751
 752         * configure: Regenerate.
 753         * configure.ac: Remove code that sets python_has_threads.
 754
 755 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 756
 757         * config.in: Regenerate.
 758         * configure: Regenerate.
 759         * configure.ac: Remove the code that uses sed to get the python
 760         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 761
 762 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 765         error paths.
 766
 767 2019-10-23  Tom Tromey  <tom@tromey.com>
 768
 769         * arc-tdep.c: Remove ".." from include.
 770         * frv-tdep.c: Remove ".." from include.
 771         * lm32-tdep.c: Remove ".." from include.
 772         * microblaze-tdep.c: Remove ".." from include.
 773         * or1k-tdep.h: Remove ".." from include.
 774         * s12z-tdep.c: Remove ".." from include.
 775         * Makefile.in (OPCODES_CFLAGS): Add comment.
 776         (TOP_CFLAGS): New variable.
 777         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 778
 779 2019-10-23  Tom Tromey  <tom@tromey.com>
 780
 781         * Makefile.in (READLINE_DIR): Update.
 782
 783 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 784
 785         * infcall.c (call_function_by_hand_dummy): Fix the function
 786         comment.  And extract out a code section into...
 787         (reserve_stack_space): ...this new function.
 788
 789 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 790
 791         * infcall.c (value_arg_coerce): Remove an unused parameter.
 792         (call_function_by_hand_dummy): Update the call to
 793         'value_arg_coerce'.
 794
 795 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 796
 797         * infcall.c (call_function_by_hand_dummy): Refactor.
 798
 799 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 800
 801         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 802
 803 2019-10-23  Tom Tromey  <tom@tromey.com>
 804
 805         * configure: Rebuild.
 806         * configure.ac: Don't check for sigprocmask.
 807         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 808
 809 2019-10-23  Tom Tromey  <tom@tromey.com>
 810
 811         * configure: Rebuild.
 812         * acinclude.m4: Use m4_include, not sinclude.
 813
 814 2019-10-23  Tom de Vries  <tdevries@suse.de>
 815
 816         PR breakpoints/24687
 817         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 818
 819 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 820
 821         * symtab.c (struct demangled_name_entry) <language>: Change from
 822         bitfield to regular variable.
 823
 824 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 825
 826         * symtab.c (struct demangled_name_entry): Add a constructor.
 827         (free_demangled_name_entry): New function to call the destructor
 828         for demangled_name_entry.
 829         (create_demangled_names_hash): Pass free_demangled_name_entry to
 830         htab_create_alloc.
 831         (symbol_set_names): Call placement new for demangled_name_entry.
 832         * utils.c: No longer include xxhash.h here, now that fast_hash
 833         is inlined in the header.
 834         * utils.h: Instead, include it here.
 835
 836 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 837
 838         * Makefile.in: Link with libxxhash.
 839         * config.in: Regenerate.
 840         * configure: Regenerate.
 841         * configure.ac: Search for libxxhash.
 842         * utils.c (fast_hash): Use xxhash if present.
 843
 844 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 845
 846         * utils.h (fast_hash): New function.
 847         * symtab.c (hash_demangled_name_entry): Call new function
 848         fast_hash.
 849
 850 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 851
 852         * symtab.c (struct demangled_name_entry): Change type of mangled
 853         to gdb::string_view. Also adds a constructor that takes the
 854         mangled name.
 855         (hash_demangled_name_entry): Update.
 856         (eq_demangled_name_entry): Update.
 857         (free_demangled_name_entry): New function to call the destructor
 858         now that this is not a POD anymore.
 859         (create_demangled_names_hash): Pass free_demangled_name_entry to
 860         htab_create_alloc.
 861         (symbol_set_names): Update.
 862
 863 2019-10-21  Ali Tamur  <tamu@google.com>
 864
 865         * dwarf2read.c (dir_index): Change type.
 866         (file_name_index): Likewise.
 867         (line_header::include_dir_at): Change comment and implementation on
 868         whether it is DWARF 5.
 869         (line_header::is_valid_file_index): New function.
 870         (line_header::file_name_at): Change comment and implementation on
 871         whether it is DWARF 5.
 872         (line_header::file_names): Change to private field renamed as
 873         m_file_names and introduce a new accessor method.
 874         (line_header::file_names_size): New method.
 875         (line_header::include_dirs): Change to private field and rename as
 876         m_include_dirs.
 877         (dw2_get_file_names_reader): Define local var at a smaller scope and
 878         reflect API change.
 879         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 880         (process_structure_scope): Likewise.
 881         (line_header::add_include_dir): Change message and reflect renaming.
 882         (line_header::add_file_name): Likewise.
 883         (read_formatted_entries): Handle DW_FORM_data16.
 884         (dwarf_decode_line_header): Fix line header length calculation.
 885         (psymtab_include_file_name): Change comment and API.
 886         (lnp_state_machine::m_file): Update comment and reflect type change.
 887         (lnp_state_machine::record_line): Reflect type change.
 888         (dwarf_decode_lines): Reflect API change.
 889         (file_file_name): Likewise.
 890         (file_full_name): Likewise.
 891
 892 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 895
 896 2019-10-21  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 899
 900 2019-10-21  Tom Tromey  <tom@tromey.com>
 901
 902         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 903         NM_H.   Use AC_CONFIG_LINKS.
 904         * configure: Rebuild.
 905         * Makefile.in (NM_H): New variable.
 906         (generated_files): Add NM_H.  Remove gcore.
 907         (nm.h, stamp-nmh): New targets.
 908
 909 2019-10-20  Tom Tromey  <tom@tromey.com>
 910
 911         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 912         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 913         obsolete comment.
 914         (put_objfile_before): Now static.
 915
 916 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 917
 918         * gdbsupport/common-utils.h (startswith): Change return type to
 919         bool.
 920
 921 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 922
 923         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 924         * breakpoint.c (bp_locations_compare): Rename to...
 925         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 926         (update_global_location_list): Use std::sort instead of qsort.
 927         * buildsym.c (compare_line_numbers): Rename to...
 928         (lte_is_less_than): ...this, and change to std::sort semantics.
 929         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 930         instead of qsort.
 931         * disasm.c (compare_lines): Rename to...
 932         (line_is_less_than): ...this, and change to std::sort semantics.
 933         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 934         of qsort.
 935         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 936         (fde_is_less_than): ...this, and change to std::sort semantics.
 937         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 938         * mdebugread.c (compare_blocks):
 939         (block_is_less_than): ...this, and change to std::sort semantics.
 940         (sort_blocks): Call std::sort instead of qsort.
 941         * objfiles.c (qsort_cmp): Rename to...
 942         (sort_cmp): ...this, and change to std::sort semantics.
 943         (update_section_map): Call std::sort instead of qsort.
 944         * remote.c (compare_pnums): Remove.
 945         (map_regcache_remote_table): Call std::sort instead of qsort.
 946         * utils.c (compare_positive_ints): Remove.
 947         * utils.h (compare_positive_ints): Remove.
 948         * xcoffread.c (compare_lte): Remove.
 949         (arrange_linetable): Call std::sort instead of qsort.
 950
 951 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 952
 953         * symfile.c (init_entry_point_info): Fix typo.
 954         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 955
 956 2019-10-18  Tom de Vries  <tdevries@suse.de>
 957
 958         * aarch64-tdep.c: Fix typos in comments.
 959         * ada-lang.c: Same.
 960         * ada-tasks.c: Same.
 961         * alpha-tdep.c: Same.
 962         * alpha-tdep.h: Same.
 963         * amd64-nat.c: Same.
 964         * amd64-windows-tdep.c: Same.
 965         * arc-tdep.c: Same.
 966         * arc-tdep.h: Same.
 967         * arch-utils.c: Same.
 968         * arm-nbsd-tdep.c: Same.
 969         * arm-tdep.c: Same.
 970         * ax-gdb.c: Same.
 971         * blockframe.c: Same.
 972         * btrace.c: Same.
 973         * c-varobj.c: Same.
 974         * coff-pe-read.c: Same.
 975         * coffread.c: Same.
 976         * cris-tdep.c: Same.
 977         * darwin-nat.c: Same.
 978         * dbxread.c: Same.
 979         * dcache.c: Same.
 980         * disasm.c: Same.
 981         * dtrace-probe.c: Same.
 982         * dwarf-index-write.c: Same.
 983         * dwarf2-frame-tailcall.c: Same.
 984         * dwarf2-frame.c: Same.
 985         * dwarf2read.c: Same.
 986         * eval.c: Same.
 987         * exceptions.c: Same.
 988         * fbsd-tdep.c: Same.
 989         * findvar.c: Same.
 990         * frame.c: Same.
 991         * frv-tdep.c: Same.
 992         * gnu-v3-abi.c: Same.
 993         * go32-nat.c: Same.
 994         * h8300-tdep.c: Same.
 995         * hppa-tdep.c: Same.
 996         * i386-linux-tdep.c: Same.
 997         * i386-tdep.c: Same.
 998         * ia64-libunwind-tdep.c: Same.
 999         * ia64-tdep.c: Same.
1000         * infcmd.c: Same.
1001         * infrun.c: Same.
1002         * linespec.c: Same.
1003         * linux-nat.c: Same.
1004         * linux-thread-db.c: Same.
1005         * machoread.c: Same.
1006         * mdebugread.c: Same.
1007         * mep-tdep.c: Same.
1008         * mn10300-tdep.c: Same.
1009         * namespace.c: Same.
1010         * objfiles.c: Same.
1011         * opencl-lang.c: Same.
1012         * or1k-tdep.c: Same.
1013         * osabi.c: Same.
1014         * ppc-linux-nat.c: Same.
1015         * ppc-linux-tdep.c: Same.
1016         * ppc-sysv-tdep.c: Same.
1017         * printcmd.c: Same.
1018         * procfs.c: Same.
1019         * record-btrace.c: Same.
1020         * record-full.c: Same.
1021         * remote-fileio.c: Same.
1022         * remote.c: Same.
1023         * rs6000-tdep.c: Same.
1024         * s12z-tdep.c: Same.
1025         * score-tdep.c: Same.
1026         * ser-base.c: Same.
1027         * ser-go32.c: Same.
1028         * skip.c: Same.
1029         * sol-thread.c: Same.
1030         * solib-svr4.c: Same.
1031         * solib.c: Same.
1032         * source.c: Same.
1033         * sparc-nat.c: Same.
1034         * sparc-sol2-tdep.c: Same.
1035         * sparc-tdep.c: Same.
1036         * sparc64-tdep.c: Same.
1037         * stabsread.c: Same.
1038         * stack.c: Same.
1039         * symfile.c: Same.
1040         * symtab.c: Same.
1041         * target-descriptions.c: Same.
1042         * target-float.c: Same.
1043         * thread.c: Same.
1044         * utils.c: Same.
1045         * valops.c: Same.
1046         * valprint.c: Same.
1047         * value.c: Same.
1048         * varobj.c: Same.
1049         * windows-nat.c: Same.
1050         * xcoffread.c: Same.
1051         * xstormy16-tdep.c: Same.
1052         * xtensa-tdep.c: Same.
1053
1054 2019-10-17  Tom Tromey  <tromey@adacore.com>
1055
1056         * configure: Rebuild.
1057         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1058         in AC_CONFIG_FILES invocation.
1059         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1060         new-style config.status invocation.
1061
1062 2019-10-17  Tom de Vries  <tdevries@suse.de>
1063
1064         * arm-nbsd-nat.c: Fix typos in comments.
1065         * arm-tdep.c: Same.
1066         * darwin-nat-info.c: Same.
1067         * dwarf2read.c: Same.
1068         * elfread.c: Same.
1069         * event-top.c: Same.
1070         * findvar.c: Same.
1071         * gdbtypes.c: Same.
1072         * hppa-tdep.c: Same.
1073         * i386-tdep.c: Same.
1074         * jit.c: Same.
1075         * main.c: Same.
1076         * mdebugread.c: Same.
1077         * moxie-tdep.c: Same.
1078         * nto-procfs.c: Same.
1079         * osabi.c: Same.
1080         * ppc-linux-tdep.c: Same.
1081         * remote.c: Same.
1082         * riscv-tdep.c: Same.
1083         * s390-tdep.c: Same.
1084         * sh-tdep.c: Same.
1085         * sparc-linux-tdep.c: Same.
1086         * sparc-nat.c: Same.
1087         * stack.c: Same.
1088         * target-descriptions.c: Same.
1089         * top.c: Same.
1090         * varobj.c: Same.
1091
1092 2019-10-16  Tom Tromey  <tom@tromey.com>
1093
1094         * objfiles.h (struct objfile) <original_name>: Now const.
1095
1096 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1097
1098         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1099         pass on to sigsetjmp's second argument.
1100         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1101
1102 2019-10-16  Keith Seitz  <keiths@redhat.com>
1103
1104         PR gdb/23567
1105         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1106         sections whose size is greater than the file size.
1107
1108 2019-10-16  Jim Wilson  <jimw@sifive.com>
1109
1110         * riscv-tdep.c (riscv_gcc_target_options): New.
1111         (riscv_gnu_triplet_regexp): New.
1112         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1113         set_gdbarch_gnu_triplet_regexp.
1114
1115 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1116
1117         * Makefile.in: Add xml-builtin.h.
1118         * features/feature_to_c.sh: Add an include for xml-builtin.h
1119         to ensure that the compiler checks that the types match.
1120         * xml-builtin.h: New file.
1121         * xml-support.c (fetch_xml_builtin): Add missing const.
1122         * xml-support.h: Remove declaration of xml_builtins.
1123
1124 2019-10-16  Tom de Vries  <tdevries@suse.de>
1125
1126         PR tdep/25096
1127         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1128         (amd64_classify_aggregate): ... here.
1129         (amd64_classify_aggregate_field): Handled fiels of nested structs
1130         recursively.
1131
1132 2019-10-16  Tom de Vries  <tdevries@suse.de>
1133
1134         PR tdep/24104
1135         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1136         that handles 'theclass'.
1137
1138 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * linespec.c (decode_digits_ordinary): Update comment.
1141         * make-target-delegates: No longer need to handle VEC case.
1142         * memrange.c (normalize_mem_ranges): Update comment.
1143         * namespace.c (add_using_directive): Update comment.
1144         * objc-lang.c (uniquify_strings): Update comment.
1145         * ppc-linux-nat.c (struct thread_points): Update comment.
1146         * probe.h (find_probes_in_objfile): Update comment.
1147         * target.h (enum flash_preserve_mode): Update comment.
1148         * varobj.c (varobj_restrict_range): Update comment.
1149         * varobj.h (varobj_list_children): Update comment.
1150
1151 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * Makefile.in: Remove references to vec.h and vec.c.
1154         * aarch64-tdep.c: No longer include vec.h.
1155         * ada-lang.c: Likewise.
1156         * ada-lang.h: Likewise.
1157         * arm-tdep.c: Likewise.
1158         * ax.h: Likewise.
1159         * breakpoint.h: Likewise.
1160         * charset.c: Likewise.
1161         * cp-support.h: Likewise.
1162         * dtrace-probe.c: Likewise.
1163         * dwarf2read.c: Likewise.
1164         * extension.h: Likewise.
1165         * gdb_bfd.c: Likewise.
1166         * gdbsupport/gdb_vecs.h: Likewise.
1167         * gdbsupport/vec.c: Remove.
1168         * gdbsupport/vec.h: Remove.
1169         * gdbthread.h: Likewise.
1170         * guile/scm-type.c: Likewise.
1171         * inline-frame.c: Likewise.
1172         * machoread.c: Likewise.
1173         * memattr.c: Likewise.
1174         * memrange.h: Likewise.
1175         * namespace.h: Likewise.
1176         * nat/linux-btrace.h: Likewise.
1177         * osdata.c: Likewise.
1178         * parser-defs.h: Likewise.
1179         * progspace.h: Likewise.
1180         * python/py-type.c: Likewise.
1181         * record-btrace.c: Likewise.
1182         * rust-exp.y: Likewise.
1183         * solib-target.c: Likewise.
1184         * stap-probe.c: Likewise.
1185         * target-descriptions.c: Likewise.
1186         * target-memory.c: Likewise.
1187         * target.h: Likewise.
1188         * varobj.c: Likewise.
1189         * varobj.h: Likewise.
1190         * xml-support.h: Likewise.
1191
1192 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1195         Update for new std::vector based implementation.
1196         (process_psymtab_comp_unit_reader): Likewise.
1197         (scan_partial_symbols): Likewise.
1198         (recursively_compute_inclusions): Likewise.
1199         (compute_compunit_symtab_includes): Likewise.
1200         (process_imported_unit_die): Likewise.
1201         (queue_and_load_dwo_tu): Likewise.
1202         (follow_die_sig_1): Likewise.
1203         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1204         (typedef dwarf2_per_cu_ptr): Remove.
1205         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1206         function.
1207         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1208         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1209         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1210         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1211         std::vector.
1212
1213 2019-10-15  Tom Tromey  <tromey@adacore.com>
1214
1215         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1216         TID.
1217
1218 2019-10-15  Tom Tromey  <tromey@adacore.com>
1219
1220         * windows-nat.c (windows_nat_target::fetch_registers)
1221         (windows_nat_target::store_registers): Rename "pid" to "tid".
1222
1223 2019-10-15  Tom Tromey  <tromey@adacore.com>
1224
1225         * gdbarch.h, gdbarch.c: Rebuild.
1226         * gdbarch.sh (gcc_target_options): Change return type to
1227         std::string.
1228         * compile/compile.c (get_args): Update.
1229         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1230         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1231         std::string.
1232         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1233         std::string.
1234         * arch-utils.c (default_gcc_target_options): Return std::string.
1235         * arch-utils.h (default_gcc_target_options): Return std::string.
1236         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1237
1238 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1239
1240         * breakpoint.c (breakpoint_chain): Make static.
1241         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1242         of accessing breakpoint_chain.
1243
1244 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1245
1246         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1247         to a gdb::function_view and return value to bool.
1248         * breakpoint.h (iterate_over_breakpoints): Likewise.
1249         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1250         (pop_dummy_frame): Update.
1251         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1252         (gdbscm_breakpoints): Update.
1253         * python/py-breakpoint.c (build_bp_list): Update.
1254         (gdbpy_breakpoints): Update.
1255         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1256         Update.
1257         (bpfinishpy_handle_stop): Update.
1258         (bpfinishpy_handle_exit): Update.
1259         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1260         (svr4_update_solib_event_breakpoints): Update.
1261
1262 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1263
1264         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1265         when unwrapping single-field structs.
1266
1267 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1268
1269         * dwarf2read.c: Remove includes.
1270
1271 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1272
1273         * ui-out.c (ui_out::call_do_message): Silence
1274         -Wformat-nonliteral warning.
1275
1276 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1277
1278         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1279         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1280         include: readline/tilde.h.
1281
1282 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1283
1284         * remote.c (remote_target::get_trace_status): Remove declaration of
1285         trace_regblock_size.
1286
1287 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1288
1289         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1290         (show_user): Remove declaration of cmdlist.
1291         * cli/cli-cmds.h (max_user_call_depth): Declare.
1292         * cli/cli-script.c (execute_user_command): Remove declaration
1293         of max_user_call_depth.
1294
1295 2019-10-11  Jim Wilson  <jimw@sifive.com>
1296
1297         * gdbsupport/print-utils.h (pulongest): Fix comment.
1298         (plongest): Likewise.
1299         (phex): Add missing comment, mention leading zeros.
1300         (phex_nz): Add mention of no leading zeros to comment.
1301
1302         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1303         plongest instead of unsigned long long cast.
1304
1305 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1306
1307         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1308         for external_editor_command and gdbtk_test.
1309
1310 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1311
1312         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1313         * varobj.c (varobjdebug): Move comment to...
1314         * varobj.h (varobjdebug): ...here, and declare.
1315
1316 2019-10-09  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1319         erase_data_content.
1320
1321 2019-10-09  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1324         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1325         * tui/tui-command.c (tui_cmd_window::resize)
1326         (tui_refresh_cmd_win): Update.
1327         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1328         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1329         * tui/tui-data.c (~tui_gen_win_info): Remove.
1330         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1331         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1332         (tui_redisplay_readline, tui_mld_flush)
1333         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1334         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1335         (tui_data_window::erase_data_content)
1336         (tui_data_item_window::rerender)
1337         (tui_data_item_window::refresh_window): Update.
1338         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1339         (box_win, tui_gen_win_info::make_window)
1340         (tui_gen_win_info::make_visible): Update.
1341         (tui_delete_win): Remove.
1342         * tui/tui-winsource.c
1343         (tui_source_window_base::do_erase_source_content): Update.
1344         (tui_show_source_line, tui_source_window_base::update_tab_width)
1345         (tui_source_window_base::update_exec_info): Update.
1346         * tui/tui-data.h (struct curses_deleter): New.
1347         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1348         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1349
1350 2019-10-09  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1353
1354 2019-10-09  Tom Tromey  <tom@tromey.com>
1355
1356         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1357         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1358
1359 2019-10-09  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1362         window height directly.
1363         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1364         declare.
1365         * tui/tui-layout.c (tui_default_win_height): Remove.
1366         (tui_default_win_viewport_height): Remove.
1367
1368 2019-10-09  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui.h: Remove comments.
1371
1372 2019-10-09  Tom de Vries  <tdevries@suse.de>
1373
1374         * python/lib/gdb/printer/bound_registers.py: Use
1375         '^builtin_type_bound128' as regexp argument for
1376         add_builtin_pretty_printer.
1377
1378 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1379
1380         * guile/guile.c (guile_extension_script_ops): Remove forward
1381         declaration and mark as static.
1382         (guile_script_ops): Likewise.
1383         (extension_language_guile): Move further down in the file so
1384         it can reference the definitions for guile_{extension_,}script_ops.
1385
1386 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1387
1388         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1389         except SORTL, DFLTCC, and KDSA.
1390
1391 2019-10-08  Tom Tromey  <tromey@adacore.com>
1392
1393         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1394         (struct safe_symbol_file_add_args): Remove.
1395
1396 2019-10-08  Tom Tromey  <tromey@adacore.com>
1397
1398         * windows-nat.c: Don't include buildsym-legacy.h.
1399
1400 2019-10-08  Tom Tromey  <tromey@adacore.com>
1401
1402         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1403
1404 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1405
1406         * gdbtypes.c (overload_debug): Move comment to header.
1407         * gdbtypes.h (overload_debug): Declare.
1408         * valops.c: Remove declaration of overload_debug, instead
1409         include gdbtypes.h.
1410
1411 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1412
1413         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1414         through _().
1415         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1416         move comment...
1417         * language.h (lang_frame_mismatch_warn): ... here. Also add
1418         declaration.
1419         * top.c (lang_frame_mismatch_warn): Remove declaration.
1420         (check_frame_language_change): Pass lang_frame_mismatch_warn
1421         through _().
1422
1423 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1424
1425         * c-lang.h (vtbl_ptr_name): Declare.
1426         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1427         it from the header.
1428         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1429
1430 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1433         gdb_static_assert.
1434
1435 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1436
1437         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1438         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1439         * ctfread.c: New file.
1440         * ctfread.h: New file.
1441         * elfread.c: Include ctfread.h.
1442         (struct elfinfo text_p): New member ctfsect.
1443         (elf_locate_sections): Mark CTF section.
1444         (elf_symfile_read): Call elfctf_build_psymtabs.
1445         * Makefile.in (LIBCTF): Add.
1446         (CLIBS): Use it.
1447         (CDEPS): Likewise.
1448         (DIST): Add ctfread.c.
1449
1450 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * ctfread.c (struct nextfield): Renamed to ...
1453         (struct ctf_nextfield): ... this.
1454         (struct field_info): Renamed to ...
1455         (strut ctf_field_info): ... this.
1456         (attach_fields_to_type): Update for renamed structures.
1457         (ctf_add_member_cb): Likewise.
1458         (ctf_add_enum_member_cb): Likewise.
1459         (process_struct_members): Likewise.
1460         (process_enum_type): Likewise.
1461
1462 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1463
1464         * tracectf.h: Rename, was ctf.h.
1465         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1466         * tracefile.c: Likewise.
1467         * tracepoint.c: Remove unused include ctf.h.
1468         * mi/mi-main.c: Likewise.
1469         * Makefile.in Replace ctf.c with tracectf.c.
1470
1471 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1472
1473         * version.in: Change version number to "9.0.50.DATE-git".
1474
1475 2019-10-03  Tom Tromey  <tom@tromey.com>
1476
1477         PR rust/24976:
1478         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1479
1480 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1483         cp_search_name_hash.
1484         * NEWS: Add entry about nested function support.
1485
1486 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1487             Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1490         for nested static variables when searchin VAR_DOMAIN.
1491         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1492         global scope, update comment.
1493         (add_partial_subprogram): Call add_partial_subprogram recursively
1494         for nested subroutines when processinng Fortran.
1495         (load_partial_dies): Process the child entities of a subprogram
1496         when processing Fortran.
1497         (partial_die_parent_scope): Handle building scope
1498         for Fortran nested functions.
1499         (process_die): Record that nested functions have a scope.
1500         (new_symbol): Always record Fortran subprograms on the global
1501         symbol list.
1502         (determine_prefix): How to build the prefix for Fortran
1503         subprograms.
1504
1505 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1508         have just sent the thread a SIGSTOP and are waiting for it to
1509         arrive.
1510
1511 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1512
1513         * btrace.c (btrace_add_pc): Remove whitespace before the template
1514         parameter in 'std::vector <...>'.
1515         (parse_xml_btrace_block): Likewise.
1516         (btrace_maint_decode_pt): Likewise.
1517         (btrace_maint_update_packets): Likewise.
1518         (btrace_maint_print_packets): Likewise.
1519         * btrace.h (struct btrace_maint_info): Likewise.
1520         * dwarf2read.c (struct type_unit_group): Likewise.
1521         (build_type_psymtabs_reader): Likewise.
1522         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1523         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1524         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1525
1526 2019-10-03  Tom de Vries  <tdevries@suse.de>
1527
1528         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1529         the first line of the help text for set/show style metadata.
1530
1531 2019-10-02  Tom Tromey  <tromey@adacore.com>
1532
1533         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1534         * gdbsupport/common-inferior.c: New file.
1535         * infcmd.c (startup_with_shell): Don't define.
1536         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1537         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1538         * inferior.h (startup_with_shell): Don't declare.
1539
1540 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1541
1542         * gdbsupport/gdb_assert.h: Include errors.h.
1543         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1544
1545 2019-10-02  Tom Tromey  <tromey@adacore.com>
1546
1547         * NEWS: Add $_ada_exception entry.
1548         * ada-lang.c (struct ada_catchpoint): Add constructor.
1549         <m_kind>: New member.
1550         (allocate_location_exception, re_set_exception): Remove
1551         "ex" parameter.
1552         (should_stop_exception): Compute $_ada_exception.
1553         (check_status_exception, print_it_exception)
1554         (print_one_exception, print_mention_exception): Remove
1555         "ex" parameter.
1556         (allocate_location_catch_exception, re_set_catch_exception)
1557         (check_status_exception, print_it_catch_exception)
1558         (print_one_catch_exception, print_mention_catch_exception)
1559         (print_recreate_catch_exception)
1560         (allocate_location_catch_exception_unhandled)
1561         (re_set_catch_exception_unhandled)
1562         (check_status_exception, print_it_catch_exception_unhandled)
1563         (print_one_catch_exception_unhandled)
1564         (print_mention_catch_exception_unhandled)
1565         (print_recreate_catch_exception_unhandled)
1566         (allocate_location_catch_assert, re_set_catch_assert)
1567         (check_status_assert, print_it_catch_assert)
1568         (print_one_catch_assert, print_mention_catch_assert)
1569         (print_recreate_catch_assert)
1570         (allocate_location_catch_handlers, re_set_catch_handlers)
1571         (check_status_handlers, print_it_catch_handlers)
1572         (print_one_catch_handlers, print_mention_catch_handlers)
1573         (print_recreate_catch_handlers): Remove.
1574         (create_ada_exception_catchpoint): Update.
1575         (initialize_ada_catchpoint_ops): Update.
1576
1577 2019-10-02  Tom Tromey  <tromey@adacore.com>
1578
1579         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1580         (create_excep_cond_exprs): Simplify exception string computation.
1581         (ada_exception_catchpoint_cond_string): Likewise.
1582
1583 2019-10-02  Tom Tromey  <tromey@adacore.com>
1584
1585         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1586         * ada-lang.c (lesseq_defined_than): Handle
1587         LOC_STATIC.
1588         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1589         parameter.
1590         (dwarf2_has_info): Likewise.
1591         (new_symbol): Set maybe_copied on symbol when
1592         appropriate.
1593         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1594         parameter.
1595         <can_copy>: New member.
1596         * elfread.c (record_minimal_symbol): Set maybe_copied
1597         on symbol when appropriate.
1598         (elf_symfile_read): Update call to dwarf2_has_info.
1599         * minsyms.c (lookup_minimal_symbol_linkage): New
1600         function.
1601         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1602         * symtab.c (get_symbol_address, get_msymbol_address):
1603         New functions.
1604         * symtab.h (get_symbol_address, get_msymbol_address):
1605         Declare.
1606         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1607         maybe_copied.
1608         (struct symbol, struct minimal_symbol) <maybe_copied>:
1609         New member.
1610
1611 2019-10-02  Tom Tromey  <tromey@adacore.com>
1612
1613         * source.c (struct current_source_location): New.
1614         (current_source_key): New global.
1615         (current_source_symtab, current_source_line)
1616         (current_source_pspace): Remove.
1617         (get_source_location): New function.
1618         (get_current_source_symtab_and_line)
1619         (set_default_source_symtab_and_line)
1620         (set_current_source_symtab_and_line)
1621         (clear_current_source_symtab_and_line, select_source_symtab)
1622         (info_source_command, print_source_lines_base)
1623         (info_line_command, search_command_helper, _initialize_source):
1624         Update.
1625
1626 2019-10-02  Tom Tromey  <tromey@adacore.com>
1627
1628         * source.c (select_source_symtab): Don't call
1629         decode_line_with_current_source.
1630
1631 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * symtab.c (lookup_global_symbol): Search global block.
1634
1635 2019-10-02  Tom Tromey  <tromey@adacore.com>
1636
1637         * coffread.c (process_coff_symbol): Update.
1638         * dwarf2read.c (var_decode_location, new_symbol): Update.
1639         * mdebugread.c (parse_symbol): Update.
1640         * objfiles.c (relocate_one_symbol): Update.
1641         * stabsread.c (define_symbol, fix_common_block)
1642         (scan_file_globals): Update.
1643         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1644         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1645         * xcoffread.c (process_xcoff_symbol): Update.
1646
1647 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1648
1649         * MAINTAINERS: Update my email address.
1650
1651 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1654         std::vector.
1655         (build_type_psymtabs_reader): Update for std::vector.
1656         (build_type_psymtab_dependencies): Likewise.
1657         * dwarf2read.h: Remove use of DEF_VEC_P.
1658         (typedef sig_type_ptr): Delete.
1659
1660 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1663         to std::vector.
1664         (btrace_maint_decode_pt): Likewise, and move allocation of the
1665         vector outside of the loop.
1666         (btrace_maint_update_packets): Update to handle change from VEC to
1667         std::vector.
1668         (btrace_maint_print_packets): Likewise.
1669         (maint_info_btrace_cmd): Likewise.
1670         * btrace.h: Remove use of DEF_VEC_O.
1671         (typedef btrace_pt_packet_s): Delete.
1672         (struct btrace_maint_info) <packets>: Change fromm VEC to
1673         std::vector.
1674         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1675
1676 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1679         make accesses into the vector constant references.
1680         (btrace_add_pc): Update for std::vector.
1681         (btrace_stitch_bts): Likewise.
1682         (parse_xml_btrace_block): Likewise.
1683         (btrace_maint_update_packets): Likewise.
1684         (btrace_maint_print_packets): Likewise.
1685         (maint_info_btrace_cmd): Likewise.
1686         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1687         std::vector.
1688         (btrace_data::empty): Likewise.
1689         (btrace_data_append): Likewise.
1690         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1691         (typedef btrace_block_s): Delete.
1692         (struct btrace_block): Add constructor.
1693         (struct btrace_data_bts) <blocks>: Change to std::vector.
1694         * nat/linux-btrace.c (perf_event_read_bts): Update for
1695         std::vector.
1696         (linux_read_bts): Likewise.
1697
1698 2019-10-01  Tom Tromey  <tom@tromey.com>
1699
1700         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1701
1702 2019-10-01  Tom Tromey  <tom@tromey.com>
1703
1704         * stack.c (print_frame, info_frame_command_core): Use
1705         styled_string.
1706         * linux-thread-db.c (try_thread_db_load_1)
1707         (try_thread_db_load_from_pdir_1): Use styled_string.
1708         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1709         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1710         (maybe_print_unsupported_script_warning)
1711         (maybe_print_script_not_found_warning): Use styled_string.
1712         * ada-lang.c (user_select_syms): Use styled_string.
1713
1714 2019-10-01  Tom Tromey  <tom@tromey.com>
1715
1716         * p-lang.c (pascal_printstr): Use metadata style.
1717         * value.c (show_convenience): Use metadata style.
1718         * valprint.c (valprint_check_validity, val_print_optimized_out)
1719         (val_print_not_saved, val_print_unavailable)
1720         (val_print_invalid_address, generic_val_print, val_print)
1721         (value_check_printable, val_print_array_elements): Use metadata
1722         style.
1723         * ui-out.h (class ui_out) <field_fmt>: New overload.
1724         <do_field_fmt>: Add style parameter.
1725         * ui-out.c (ui_out::field_fmt): New overload.
1726         * typeprint.c (type_print_unknown_return_type)
1727         (val_print_not_allocated, val_print_not_associated): Use metadata
1728         style.
1729         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1730         parameter.
1731         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1732         * tracepoint.c (tvariables_info_1): Use metadata style.
1733         * stack.c (print_frame_arg, print_frame_info, print_frame)
1734         (info_frame_command_core): Use metadata style.
1735         * skip.c (info_skip_command): Use metadata style.
1736         * rust-lang.c (rust_print_enum): Use metadata style.
1737         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1738         metadata style.
1739         * python/py-framefilter.c (py_print_single_arg): Use metadata
1740         style.
1741         * printcmd.c (do_one_display, print_variable_and_value): Use
1742         metadata style.
1743         * p-valprint.c (pascal_val_print)
1744         (pascal_object_print_value_fields): Use metadata style.
1745         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1746         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1747         parameter.
1748         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1749         * m2-valprint.c (m2_print_long_set): Use metadata style.
1750         * m2-typeprint.c (m2_print_type): Use metadata style.
1751         * infcmd.c (print_return_value_1): Use metadata style.
1752         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1753         * f-valprint.c (info_common_command_for_block): Use metadata
1754         style.
1755         * f-typeprint.c (f_type_print_base): Use metadata style.
1756         * expprint.c (print_subexp_standard): Use metadata style.
1757         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1758         * cli/cli-style.h (class cli_style_option): Add constructor.
1759         (metadata_style): Declare.
1760         * cli/cli-style.c (metadata_style): New global.
1761         (_initialize_cli_style): Register metadata style.
1762         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1763         parameter.
1764         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1765         * c-typeprint.c (c_type_print_base_struct_union)
1766         (c_type_print_base_1): Use metadata style.
1767         * breakpoint.c (watchpoint_value_print)
1768         (print_one_breakpoint_location): Use metadata style.
1769         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1770         style.
1771         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1772         style.
1773         * ada-valprint.c (val_print_packed_array_elements, printstr)
1774         (print_field_values, ada_val_print_ref, ada_val_print): Use
1775         metadata style.
1776         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1777         style.
1778         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1779         style.
1780         * ada-lang.c (user_select_syms): Use metadata style.
1781
1782 2019-10-01  Tom Tromey  <tom@tromey.com>
1783
1784         * cli/cli-cmds.c (pwd_command): Style output.
1785
1786 2019-10-01  Pedro Alves  <palves@redhat.com>
1787             Tom Tromey  <tom@tromey.com>
1788
1789         * symtab.c (print_symbol_info): Use %ps.
1790         (print_msymbol_info): Use %ps.
1791         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1792         * printcmd.c (print_variable_and_value): Use %ps.
1793         * macrocmd.c (show_pp_source_pos): Use %ps.
1794         * infrun.c (print_exited_reason): Use ui_out::message.
1795         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1796         (describe_other_breakpoints): Use ui_out::message and new
1797         formats.
1798         (say_where): Use new formats.
1799         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1800         and new formats.
1801
1802 2019-10-01  Pedro Alves  <palves@redhat.com>
1803             Tom Tromey  <tom@tromey.com>
1804
1805         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1806         (test_gdb_formats): New function.
1807         (run_tests): Call it.
1808         (test_format_specifier): Update.
1809         * utils.h (fputs_filtered): Update comment.
1810         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1811         (fputs_styled_unfiltered): Declare.
1812         * utils.c (fputs_styled_unfiltered): New function.
1813         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1814         (vfprintf_filtered): Update.
1815         (vfprintf_unfiltered, vprintf_filtered): Update.
1816         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1817         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1818         disallow_ui_out_field>: New constants.
1819         (enum class field_kind): New.
1820         (struct base_field_s, struct signed_field_s): New.
1821         (signed_field): New function.
1822         (struct string_field_s): New.
1823         (string_field): New function.
1824         (struct styled_string_s): New.
1825         (styled_string): New function.
1826         (class ui_out) <message>: Add comment.
1827         <vmessage, call_do_message>: New methods.
1828         <do_message>: Add style parameter.
1829         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1830         methods.
1831         (ui_out::message): Rewrite.
1832         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1833         parameter.
1834         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1835         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1836         gdb_extensions parameter.
1837         (class format_piece): Add parameter to constructor.
1838         (n_int_args): New field.
1839         * gdbsupport/format.c (format_pieces::format_pieces): Add
1840         gdb_extensions parameter.  Handle '*'.
1841         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1842         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1843         vfprintf_styled_no_gdbfmt.
1844         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1845         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1846         unfiltered output.
1847         * ui-style.h (struct ui_file_style) <ptr>: New method.
1848
1849 2019-10-01  Tom Tromey  <tom@tromey.com>
1850
1851         * unittests/format_pieces-selftests.c: Update.  Add final format.
1852         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1853         empty literal pieces.
1854
1855 2019-10-01  Tom Tromey  <tom@tromey.com>
1856
1857         * ui-out.h (enum class ui_out_style_kind): Remove.
1858         (class ui_out) <field_string, field_stsream, do_field_string>:
1859         Change type of "style".
1860         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1861         (ui_out::field_string): Update.
1862         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1863         of "style".
1864         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1865         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1866         * stack.c (print_frame_arg, print_frame_info, print_frame):
1867         Update.
1868         * source.c (print_source_lines_base): Update.
1869         * solib.c (info_sharedlibrary_command): Update.
1870         * skip.c (info_skip_command): Update.
1871         * record-btrace.c (btrace_call_history_src_line)
1872         (btrace_call_history): Update.
1873         * python/py-framefilter.c (py_print_frame): Update.
1874         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1875         "style".
1876         * mi/mi-out.c (mi_ui_out::do_table_header)
1877         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1878         (mi_ui_out::do_field_string): Update.
1879         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1880         Update.
1881         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1882         "style".
1883         * cli-out.c (cli_ui_out::do_table_header)
1884         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1885         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1886         (cli_ui_out::do_field_fmt): Update.
1887         * breakpoint.c (print_breakpoint_location): Update.
1888         (update_static_tracepoint): Update.
1889
1890 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1891
1892         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1893         conversion of gdb_datadir.
1894         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1895         remove not needed c_str ().
1896
1897 2019-09-30  Ali Tamur <tamur@google.com>
1898
1899         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1900         (dwarf2_string_attr): Likewise.
1901
1902 2019-09-30  Ali Tamur <tamur@google.com>
1903
1904         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1905         (process_full_type_unit): Likewise.
1906         (dump_die_shallow): Likewise.
1907         (cu_debug_loc_section): Likewise.
1908
1909 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1910
1911         * minsyms.c (compare_minimal_symbols): Rename to...
1912         (minimal_symbol_is_less_than): ...this, and adjust to STL
1913         conventions (return bool, take arguments as references)
1914         (minimal_symbol_reader::install): Call std::sort instead
1915         of qsort.
1916
1917 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1918
1919         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1920         hash and why.
1921         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1922         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1923
1924 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1925
1926         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1927         * psympriv.h (add_psymbol_to_list): Move comment here and update
1928         it.
1929
1930 2019-09-29  Tom de Vries  <tdevries@suse.de>
1931
1932         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1933         Use $tmpdir/$(basename "$output_file").dwz instead of
1934         "${output_file}.dwz".
1935
1936 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1937
1938         PR gdb/25045
1939         * hppa-linux-nat.c: Include gdbarch.h.
1940
1941 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1942
1943         * blockframe.c (find_pc_partial_function): Change return type to bool.
1944         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1945         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1946         (stub_gnu_ifunc_resolve_name): Likewise.
1947         * symtab.c (compare_filenames_for_search): Likewise.
1948         (compare_glob_filenames_for_search): Likewise.
1949         (matching_obj_sections): Likewise.
1950         (symbol_matches_domain): Likewise.
1951         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1952         (find_line_pc): Change return type to bool.
1953         (find_line_pc_range): Likewise.
1954         (producer_is_realview): Likewise.
1955         * symtab.h (symbol_matches_domain): Likewise.
1956         (find_pc_partial_function): Likewise.
1957         (find_pc_line_pc_range): Likewise.
1958         (in_gnu_ifunc_stub): Likewise.
1959         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1960         (find_line_pc): Likewise.
1961         (find_line_pc_range): Likewise.
1962         (matching_obj_sections): Likewise.
1963         (find_line_symtab): Change out parameter to bool.
1964         (producer_is_realview): Change return type to bool.
1965         (compare_filenames_for_search): Likewise.
1966         (compare_glob_filenames_for_search): Likewise.
1967
1968 2019-09-26  Tom Tromey  <tom@tromey.com>
1969
1970         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1971         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1972         * gdb_usleep.h: Remove.
1973         * gdb_usleep.c: Remove.
1974         * utils.c: Don't include gdb_usleep.h.
1975
1976 2019-09-26  Tom Tromey  <tromey@adacore.com>
1977
1978         * python/py-type.c (type_to_type_object): Call check_typedef
1979         for stub types.
1980
1981 2019-09-26  Tom Tromey  <tom@tromey.com>
1982
1983         * utils.h (initialize_utils): Don't declare.
1984         * top.c (gdb_init): Don't call initialize_utils.
1985         * utils.c (initialize_utils): Remove.  Move contents...
1986         (_initialize_utils): ... here.
1987
1988 2019-09-25  Tom Tromey  <tom@tromey.com>
1989
1990         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1991         * utils.h (make_hex_string): Don't declare.
1992         * utils.c (make_hex_string): Remove.
1993
1994 2019-09-24  Tom de Vries  <tdevries@suse.de>
1995
1996         PR gdb/23815
1997         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1998         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1999
2000 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2001
2002         * NEWS: Mention new simulator port for PRU.
2003
2004 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2005
2006         * ada-exp.y (write_object_remaining): Update.
2007         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2008         and eliminate the static buffer.
2009         (ada_decode_symbol): Update.
2010         (ada_la_decode): Update.
2011         (ada_sniff_from_mangled_name): Update.
2012         (is_valid_name_for_wild_match): Update.
2013         (ada_lookup_name_info::matches): Update and simplify.
2014         (name_matches_regex): Update.
2015         (ada_add_global_exceptions): Update.
2016         * ada-lang.h (ada_decode): Update signature.
2017         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2018         * dwarf-index-write.c (debug_names::insert): Update.
2019
2020 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2023         formatting.
2024
2025 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2026
2027         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2028         Change "nonzero" to "true" in documentation.
2029
2030 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2031
2032         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2033         (_initialize_darwin_solib): Don't set
2034         darwin_so_ops.lookup_lib_global_symbol.
2035         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2036         set_gdbarch_iterate_over_objfiles_in_search_order.
2037         (elf_lookup_lib_symbol): Rename to...
2038         (svr4_iterate_over_objfiles_in_search_order): this, and update
2039         to iterate semantics.
2040         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2041         * solib.c (solib_global_lookup): Remove.
2042         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2043         (solib_global_lookup): Remove.
2044         * symtab.c (lookup_global_or_static_symbol): Remove call to
2045         solib_global_lookup.
2046
2047 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2048
2049         * NEWS: Move entries about default MI version now being
2050         version 3, and about the GDB/MI fix for multi-location
2051         breakpoints to the "since GDB 8.3" section.
2052
2053 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2054
2055         GDB 8.3.1 released.
2056
2057 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2058
2059         * NEWS: Mention that Cell/B.E. debugging support was removed.
2060         * MAINTAINERS: Remove spu target.
2061
2062         * config/djgpp/fnchange.lst: Remove entries for removed files.
2063
2064         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2065         spu-multiarch.o, and spu-tdep.o.
2066         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2067         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2068         spu-multiarch.c, and spu-tdep.c.
2069         * spu-linux-nat.c: Remove file.
2070         * spu-multiarch.c: Remove file.
2071         * spu-tdep.c: Remove file.
2072         * spu-tdep.h: Remove file.
2073         * solib-spu.c: Remove file.
2074         * solib-spu.h: Remove file.
2075
2076         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2077         * configure.nat (spu-linux): Remove.
2078         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2079         solib-multiarch.o from gdb_target_obs.
2080         (spu*-*-*): Remove.
2081
2082         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2083         feature flag.
2084         (ppc_linux_no_features): Update.
2085         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2086         Cell/B.E. support.
2087         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2088         (tdesc_powerpc_cell64l): Likewise.
2089         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2090         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2091         Cell/B.E. support.
2092         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2093         Do not include "features/rs6000/powerpc-cell32l.c" or
2094         "features/rs6000/powerpc-cell64l.c".
2095         (ppc_linux_spu_section): Remove.
2096         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2097         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2098         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2099         (ppc_linux_spe_context_lookup): Remove.
2100         (ppc_linux_spe_context_inferior_created): Remove.
2101         (ppc_linux_spe_context_solib_loaded): Remove.
2102         (ppc_linux_spe_context_solib_unloaded): Remove.
2103         (ppc_linux_spe_context): Remove.
2104         (struct ppu2spu_cache): Remove.
2105         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2106         (struct ppu2spu_data): Remove.
2107         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2108         ppu2spu_unwind): Remove.
2109         (ppc_linux_init_abi): Remove Cell/B.E. support.
2110         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2111
2112         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2113         (rs6000/powerpc-cell64l-expedite): Likewise
2114         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2115         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2116         rs6000/powerpc-cell64l.xml.
2117         * features/rs6000/powerpc-cell32l.xml: Remove.
2118         * features/rs6000/powerpc-cell64l.xml: Likewise.
2119         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2120         * features/rs6000/powerpc-cell64l.c: Likewise.
2121         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2122         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2123         * regformats/reg-spu.dat: Remove.
2124
2125         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2126         * corelow.c (struct spuid_list): Remove.
2127         (add_to_spuid_list): Remove.
2128         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2129         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2130         (remote_protocol_features): Remove associated entries.
2131         (_initialize_remote): No longer initialize them.
2132         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2133         * linux-nat.c (SPUFS_MAGIC): Remove.
2134         (linux_proc_xfer_spu): Remove.
2135         (spu_enumerate_spu_ids): Remove.
2136         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2137         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2138         (linux_make_corefile_notes): No longer call it.
2139
2140         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2141         (cooked_write_test): Likewise.
2142
2143 2019-09-20  Tom Tromey  <tom@tromey.com>
2144
2145         * NEWS: Mention case-sensitivity of TUI commands.
2146         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2147         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2148         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2149
2150 2019-09-20  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-source.c (tui_source_window::set_contents): Use
2153         make_unique_xstrdup.
2154         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2155         make_unique_xstrdup.
2156
2157 2019-09-20  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-data.c: Remove separator comments.
2160         * tui/tui-layout.c: Remove separator comments.
2161         * tui/tui-win.c: Remove separator comments.
2162         * tui/tui-wingeneral.c: Remove separator comments.
2163
2164 2019-09-20  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui.h (strcat_to_buf): Don't declare.
2167         * tui/tui.c (strcat_to_buf): Remove.
2168
2169 2019-09-20  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2172         from "fullname".
2173         * tui/tui-source.c (tui_source_window::set_contents)
2174         (tui_source_window::location_matches_p)
2175         (tui_source_window::maybe_update): Update.
2176
2177 2019-09-20  Tom Tromey  <tom@tromey.com>
2178
2179         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2180         Update.
2181         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2182         prefix.
2183         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2184         (tui_data_window::line_from_reg_element_no)
2185         (tui_data_window::first_reg_element_no_inline)
2186         (tui_data_window::show_registers)
2187         (tui_data_window::show_register_group)
2188         (tui_data_window::display_registers_from)
2189         (tui_data_window::display_registers_from_line)
2190         (tui_data_window::first_data_item_displayed)
2191         (tui_data_window::delete_data_content_windows)
2192         (tui_data_window::erase_data_content)
2193         (tui_data_window::do_scroll_vertical)
2194         (tui_data_window::refresh_window)
2195         (tui_data_window::check_register_values): Update.
2196
2197 2019-09-20  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2200         (struct tui_locator_window) <full_name, proc_name>: Now
2201         std::string.
2202         * tui/tui-stack.c (tui_locator_window::make_status_line)
2203         (tui_locator_window::set_locator_fullname)
2204         (tui_locator_window::set_locator_info): Update.
2205         * tui/tui-source.c (tui_source_window::set_contents)
2206         (tui_source_window::showing_source_p): Update.
2207
2208 2019-09-20  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2211         Don't call tui_locator_win_info_ptr.
2212
2213 2019-09-20  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2216
2217 2019-09-20  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2220         height for locator.
2221         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2222         * tui/tui-layout.c (show_source_disasm_command, show_data)
2223         (show_source_or_disasm_and_command): Use 1 as height for locator.
2224
2225 2019-09-20  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui.c (tui_enable): Update.
2228         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2229         Update.
2230         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2231         Update.
2232         * tui/tui-data.c (win_resized): Now bool.
2233         (tui_win_resized): Return bool.
2234         (tui_set_win_resized_to): Accept a bool.
2235
2236 2019-09-20  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2239         Change type of "refresh_values_only".
2240         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2241         type of "refresh_values_only".
2242
2243 2019-09-20  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2246         std::string.
2247         (tui_disassemble): Add "pos" parameter.
2248         (tui_disasm_window::set_contents): Simplify.
2249
2250 2019-09-20  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-winsource.h (struct tui_source_window_base)
2253         <show_source_content>: Now private.
2254         * tui/tui-winsource.c
2255         (tui_source_window_base::show_source_content): Don't handle empty
2256         content case.
2257
2258 2019-09-20  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-layout.c (show_source_disasm_command)
2261         (show_source_or_disasm_and_command): Don't call
2262         show_source_content.
2263
2264 2019-09-20  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2267         Declare.
2268         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2269         from tui_make_status_line.
2270         (tui_locator_window::rerender): Update.
2271
2272 2019-09-20  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2275         (tui_locator_window::rerender): Update.
2276
2277 2019-09-20  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-winsource.h (struct tui_source_window_base)
2280         <~tui_source_window_base>: Don't declare.
2281         <fullname>: Remove.
2282         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2283         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2284         member.
2285         * tui/tui-source.c (tui_source_window::set_contents): Update.
2286         (tui_source_window::location_matches_p)
2287         (tui_source_window::maybe_update): Update.
2288
2289 2019-09-20  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-winsource.h (~tui_source_element): Remove.
2292         (tui_source_element): Update.
2293         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2294         * tui/tui-winsource.c (tui_show_source_line): Update.
2295         * tui/tui-source.c (tui_source_window::set_contents): Update.
2296         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2297
2298 2019-09-20  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2301         declare.
2302         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2303         tui_clear_source_windows_detail.
2304         * tui/tui-winsource.h (struct tui_source_window_base)
2305         <clear_detail>: Don't declare.
2306         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2307         Remove.
2308         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2309
2310 2019-09-20  Tom Tromey  <tromey@adacore.com>
2311
2312         PR ada/24919:
2313         * block.c (contained_in): Fix final return value.
2314
2315 2019-09-20  Alan Modra  <amodra@gmail.com>
2316
2317         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2318         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2319         (read_indirect_string_from_dwz): Use bfd accessor.
2320         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2321         * machoread.c (macho_symfile_read_all_oso): Likewise.
2322         * solib.c (solib_bfd_open): Likewise.
2323
2324 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2325
2326         * eval.c: Move declaration of overload_resolution to...
2327         * value.h: ...here.
2328
2329 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2330
2331         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2332         * arm-linux-tdep.c: Likewise.
2333         * arm-nbsd-nat.c: Likewise.
2334         * arm-tdep.h: Declare arm_apcs_32.
2335         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2336
2337 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2338
2339         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2340         * dwarf2read.h: Declare dwarf_always_disassemble.
2341
2342 2019-09-19  Tom de Vries  <tdevries@suse.de>
2343
2344         PR gdb/25009
2345         * source-cache.c (source_cache::ensure): Catch exception thrown during
2346         construction of the highlighter.
2347
2348 2019-09-18  Alan Modra  <amodra@gmail.com>
2349
2350         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2351         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2352         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2353         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2354         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2355         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2356         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2357         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2358         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2359         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2360         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2361         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2362         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2363         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2364         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2365         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2366         * mi/mi-interp.c: Update throughout for bfd section macro and
2367         function changes.
2368         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2369         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2370
2371 2019-09-18  Tom Tromey  <tom@tromey.com>
2372
2373         * NEWS: Add entry.
2374         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2375         call rl_initialize.
2376         (tui_enable): Do not call rl_initialize.
2377
2378 2019-09-18  Christian Groessler  <chris@groessler.org>
2379
2380         * alpha-linux-nat.c: Include gdbarch.h.
2381
2382 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2383
2384         * ui-file.c: Include cli/cli-style.h.
2385         (term_cli_styling): Remove cli_styling declaration.
2386
2387 2019-09-18  Alan Modra  <amodra@gmail.com>
2388
2389         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2390         to bfd_asymbol_section.
2391
2392 2019-09-18  Alan Modra  <amodra@gmail.com>
2393
2394         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2395         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2396         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2397
2398 2019-09-18  Alan Modra  <amodra@gmail.com>
2399
2400         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2401         * spu-linux-nat.c (spu_bfd_open): Likewise.
2402
2403 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2404
2405         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2406         to bool to match definition in dwarf2read.c.
2407
2408 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2409
2410         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2411         (print_signatures): Likewise.
2412         (trust_pad_over_xvs): Likewise.
2413         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2414         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2415         * arm-linux-nat.c (arm_apcs_32): Likewise.
2416         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2417         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2418         * arm-tdep.c (arm_debug): Likewise.
2419         (arm_apcs_32): Likewise.
2420         * auto-load.c (debug_auto_load): Likewise.
2421         (auto_load_gdb_scripts): Likewise.
2422         (global_auto_load): Likewise.
2423         (auto_load_local_gdbinit): Likewise.
2424         (auto_load_local_gdbinit_loaded): Likewise.
2425         * auto-load.h (global_auto_load): Likewise.
2426         (auto_load_local_gdbinit): Likewise.
2427         (auto_load_local_gdbinit_loaded): Likewise.
2428         * breakpoint.c (disconnected_dprintf): Likewise.
2429         (breakpoint_proceeded): Likewise.
2430         (automatic_hardware_breakpoints): Likewise.
2431         (always_inserted_mode): Likewise.
2432         (target_exact_watchpoints): Likewise.
2433         (_initialize_breakpoint): Update.
2434         * breakpoint.h (target_exact_watchpoints): Change to bool.
2435         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2436         * cli/cli-cmds.c (trace_commands): Likewise.
2437         * cli/cli-cmds.h (trace_commands): Likewise.
2438         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2439         to bool*.
2440         * cli/cli-logging.c (logging_overwrite): Change to bool.
2441         (logging_redirect): Likewise.
2442         (debug_redirect): Likewise.
2443         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2444         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2445         to bool.
2446         <boolean_option_def>: Update.
2447         (struct flag_option_def): Change default type of Context to bool
2448         from int.
2449         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2450         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2451         (get_setshow_command_value_string): Likewise.
2452         * cli/cli-style.c (cli_styling): Change to bool.
2453         (source_styling): Likewise.
2454         * cli/cli-style.h (source_styling): Likewise.
2455         (cli_styling): Likewise.
2456         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2457         to bool.
2458         * command.h (var_types): Update comment.
2459         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2460         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2461         bool.
2462         (debug_compile_cplus_scopes): Likewise.
2463         * compile/compile-internal.h (compile_debug): Likewise.
2464         * compile/compile.c (compile_debug): Likewise.
2465         (struct compile_options) <raw>: Likewise.
2466         * cp-support.c (catch_demangler_crashes): Likewise.
2467         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2468         (usr_cmd_cris_dwarf2_cfi): Likewise.
2469         * csky-tdep.c (csky_debug): Likewise.
2470         * darwin-nat.c (enable_mach_exceptions): Likewise.
2471         * dcache.c (dcache_enabled_p): Likewise.
2472         * defs.h (info_verbose): Likewise.
2473         * demangle.c (demangle): Likewise.
2474         (asm_demangle): Likewise.
2475         * dwarf-index-cache.c (debug_index_cache): Likewise.
2476         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2477         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2478         * dwarf2read.c (check_physname): Likewise.
2479         (use_deprecated_index_sections): Likewise.
2480         (dwarf_always_disassemble): Likewise.
2481         * eval.c (overload_resolution): Likewise.
2482         * event-top.c (set_editing_cmd_var): Likewise.
2483         (exec_done_display_p): Likewise.
2484         * event-top.h (set_editing_cmd_var): Likewise.
2485         (exec_done_display_p): Likewise.
2486         * exec.c (write_files): Likewise.
2487         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2488         (debug_fbsd_nat): Likewise.
2489         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2490         Likewise.
2491         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2492         <backtrace_past_entry> Likewise.
2493         * gdb-demangle.h (demangle): Likewise.
2494         (asm_demangle): Likewise.
2495         * gdb_bfd.c (bfd_sharing): Likewise.
2496         * gdbcore.h (write_files): Likewise.
2497         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2498         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2499         * gdbthread.h (print_thread_events): Likewise.
2500         * gdbtypes.c (opaque_type_resolution): Likewise.
2501         (strict_type_checking): Likewise.
2502         * gnu-nat.c (gnu_debug_flag): Likewise.
2503         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2504         * guile/scm-param.c (pascm_variable): Add boolval.
2505         (add_setshow_generic): Update.
2506         (pascm_param_value): Update.
2507         (pascm_set_param_value_x): Update.
2508         * hppa-tdep.c (hppa_debug): Change to bool..
2509         * infcall.c (may_call_functions_p): Likewise.
2510         (coerce_float_to_double_p): Likewise.
2511         (unwind_on_signal_p): Likewise.
2512         (unwind_on_terminating_exception_p): Likewise.
2513         * infcmd.c (startup_with_shell): Likewise.
2514         * inferior.c (print_inferior_events): Likewise.
2515         * inferior.h (startup_with_shell): Likewise.
2516         (print_inferior_events): Likewise.
2517         * infrun.c (step_stop_if_no_debug): Likewise.
2518         (detach_fork): Likewise.
2519         (debug_displaced): Likewise.
2520         (disable_randomization): Likewise.
2521         (non_stop): Likewise.
2522         (non_stop_1): Likewise.
2523         (observer_mode): Likewise.
2524         (observer_mode_1): Likewise.
2525         (set_observer_mode): Update.
2526         (sched_multi): Change to bool.
2527         * infrun.h (debug_displaced): Likewise.
2528         (sched_multi): Likewise.
2529         (step_stop_if_no_debug): Likewise.
2530         (non_stop): Likewise.
2531         (disable_randomization): Likewise.
2532         * linux-tdep.c (use_coredump_filter): Likewise.
2533         (dump_excluded_mappings): Likewise.
2534         * linux-thread-db.c (auto_load_thread_db): Likewise.
2535         (check_thread_db_on_load): Likewise.
2536         * main.c (captured_main_1): Update.
2537         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2538         xx2_opt, boolean_opt>: Change to bool.
2539         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2540         * maint.c (maintenance_profile_p): Likewise.
2541         (per_command_time): Likewise.
2542         (per_command_space): Likewise.
2543         (per_command_symtab): Likewise.
2544         * memattr.c (inaccessible_by_default): Likewise.
2545         * mi/mi-main.c (mi_async): Likewise.
2546         (mi_async_1): Likewise.
2547         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2548         * nat/fork-inferior.h (startup_with_shell): Likewise.
2549         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2550         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2551         * nios2-tdep.c (nios2_debug): Likewise.
2552         * or1k-tdep.c (or1k_debug): Likewise.
2553         * parse.c (parser_debug): Likewise.
2554         * parser-defs.h (parser_debug): Likewise.
2555         * printcmd.c (print_symbol_filename): Likewise.
2556         * proc-api.c (procfs_trace): Likewise.
2557         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2558         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2559         (set_parameter_value): Update.
2560         (add_setshow_generic): Update.
2561         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2562         to bool*.
2563         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2564         int*.
2565         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2566         * record-btrace.c (record_btrace_target::store_registers): Update.
2567         * record-full.c (record_full_memory_query): Change to bool.
2568         (record_full_stop_at_limit): Likewise.
2569         * record-full.h (record_full_memory_query): Likewise.
2570         * remote-notif.c (notif_debug): Likewise.
2571         * remote-notif.h (notif_debug): Likewise.
2572         * remote.c (use_range_stepping): Likewise.
2573         (interrupt_on_connect): Likewise.
2574         (remote_break): Likewise.
2575         * ser-tcp.c (tcp_auto_retry): Likewise.
2576         * ser-unix.c (serial_hwflow): Likewise.
2577         * skip.c (debug_skip): Likewise.
2578         * solib-aix.c (solib_aix_debug): Likewise.
2579         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2580         (spu_auto_flush_cache_p): Likewise.
2581         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2582         Likewise.
2583         (struct info_print_options) <quiet>: Likewise.
2584         * symfile-debug.c (debug_symfile): Likewise.
2585         * symfile.c (auto_solib_add): Likewise.
2586         (separate_debug_file_debug): Likewise.
2587         * symfile.h (auto_solib_add): Likewise.
2588         (separate_debug_file_debug): Likewise.
2589         * symtab.c (basenames_may_differ): Likewise.
2590         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2591         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2592         (struct info_types_options) <quiet>: Likewise.
2593         * symtab.h (demangle): Likewise.
2594         (basenames_may_differ): Likewise.
2595         * target-dcache.c (stack_cache_enabled_1): Likewise.
2596         (code_cache_enabled_1): Likewise.
2597         * target.c (trust_readonly): Likewise.
2598         (may_write_registers): Likewise.
2599         (may_write_memory): Likewise.
2600         (may_insert_breakpoints): Likewise.
2601         (may_insert_tracepoints): Likewise.
2602         (may_insert_fast_tracepoints): Likewise.
2603         (may_stop): Likewise.
2604         (auto_connect_native_target): Likewise.
2605         (target_stop_and_wait): Update.
2606         (target_async_permitted): Change to bool.
2607         (target_async_permitted_1): Likewise.
2608         (may_write_registers_1): Likewise.
2609         (may_write_memory_1): Likewise.
2610         (may_insert_breakpoints_1): Likewise.
2611         (may_insert_tracepoints_1): Likewise.
2612         (may_insert_fast_tracepoints_1): Likewise.
2613         (may_stop_1): Likewise.
2614         * target.h (target_async_permitted): Likewise.
2615         (may_write_registers): Likewise.
2616         (may_write_memory): Likewise.
2617         (may_insert_breakpoints): Likewise.
2618         (may_insert_tracepoints): Likewise.
2619         (may_insert_fast_tracepoints): Likewise.
2620         (may_stop): Likewise.
2621         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2622         (make_thread_apply_all_options_def_group): Change argument from int*
2623         to bool*.
2624         (thread_apply_all_command): Update.
2625         (print_thread_events): Change to bool.
2626         * top.c (confirm): Likewise.
2627         (command_editing_p): Likewise.
2628         (history_expansion_p): Likewise.
2629         (write_history_p): Likewise.
2630         (info_verbose): Likewise.
2631         * top.h (confirm): Likewise.
2632         (history_expansion_p): Likewise.
2633         * tracepoint.c (disconnected_tracing): Likewise.
2634         (circular_trace_buffer): Likewise.
2635         * typeprint.c (print_methods): Likewise.
2636         (print_typedefs): Likewise.
2637         * utils.c (debug_timestamp): Likewise.
2638         (sevenbit_strings): Likewise.
2639         (pagination_enabled): Likewise.
2640         * utils.h (sevenbit_strings): Likewise.
2641         (pagination_enabled): Likewise.
2642         * valops.c (overload_resolution): Likewise.
2643         * valprint.h (struct value_print_options) <prettyformat_arrays,
2644         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2645         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2646         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2647         Likewise.
2648         * windows-nat.c (new_console): Likewise.
2649         (cygwin_exceptions): Likewise.
2650         (new_group): Likewise.
2651         (debug_exec): Likewise.
2652         (debug_events): Likewise.
2653         (debug_memory): Likewise.
2654         (debug_exceptions): Likewise.
2655         (useshell): Likewise.
2656         * windows-tdep.c (maint_display_all_tib): Likewise.
2657         * xml-support.c (debug_xml): Likewise.
2658
2659 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2660
2661         * source.c (prepare_path_for_appending): New function.
2662         (openp): Make use of new function.
2663         (find_and_open_source): Search for the compilation directory and
2664         source file as a relative path beneath the directory search path.
2665
2666 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * source-cache.c (source_cache::get_line_charpos): Catch
2669         exceptions and return false, this matches the behaviour documented
2670         in the header file.
2671
2672 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2673
2674         * ada-tasks.c (info_task): Remove quoting of the task's name.
2675
2676 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2677
2678         * symfile.c (auto_solib_add): Replace comment with a reference
2679         to the header file.
2680
2681 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2682
2683         * NEWS: Mention that gdb can now be compiled with Python 3
2684         on Windows.
2685
2686 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * maint.c (maint_print_section_data::maint_print_section_data):
2689         Force use of 'float log10 (float)' by casting the argument to
2690         float.
2691
2692 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * maint.c: Add 'cmath' include.
2695         (struct maint_print_section_data): New structure.
2696         (print_section_index): New function.
2697         (print_bfd_section_info): Add header comment, small whitespace
2698         cleanup, and update to call new print_section_index function.
2699         (print_objfile_section_info): Likewise.
2700         (maint_obj_section_from_bfd_section): New function.
2701         (print_bfd_section_info_maybe_relocated): New function.
2702         (maintenance_info_sections): Add header comment, always use
2703         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2704
2705 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2708         inner scope, add check that the objfile has psymtabs before
2709         checking psymtabs_addrmap.
2710         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2711
2712 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2713
2714         * NEWS: Announce that Ada task names are now shown at more places,
2715         and between quotes (except in info task output).
2716         * gdb/ada-tasks.c (task_to_str): New function.
2717         (display_current_task_id): Call task_to_str.
2718         (task_command_1): Likewise.
2719         (print_ada_task_info): In non-mi mode, Properly align headers and data
2720         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2721
2722 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2723
2724         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2725         prstatus.pr_lwp.pr_info instead of making it up.
2726
2727 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2728
2729         * auto-load.c (auto_load_expand_dir_vars): Update.
2730         * defs.h (gdb_datadir): Change to std::string.
2731         (python_libdir): Likewise.
2732         (relocate_gdb_directory): Change return type to std::string.
2733         * guile/guile.c (gdbscm_data_directory): Update.
2734         (initialize_scheme_side): Update.
2735         * jit.c (jit_reader_dir): Change to std::string.
2736         (jit_reader_load_command): Update.
2737         * main.c (gdb_datadir): Change to std::string.
2738         (python_libdir): Likewise.
2739         (set_gdb_data_directory): Update.
2740         (relocate_path): Change to return std::string.
2741         (relocate_gdb_directory): Change to return std::string.
2742         (relocate_gdbinit_path_maybe_in_datadir): Update.
2743         (captured_main_1): Update.
2744         * python/python.c (do_start_initialization): Update.
2745         * top.c (show_gdb_datadir): Update.
2746         * xml-syscall.c (xml_init_syscalls_info): Update.
2747         (init_syscalls_info): Update.
2748
2749 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2750
2751         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2752         out of get_init_files.
2753         (get_init_files): Update.
2754
2755 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2756
2757         * main.c (get_init_files): Change to use std::string.
2758         (captured_main_1): Update.
2759         (print_gdb_help): Update.
2760
2761 2019-09-11  Ali Tamur  <tamur@google.com>
2762
2763         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2764         implementation.
2765
2766 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2767
2768         * dbxread.c (read_dbx_symtab): Update.
2769         * dwarf2read.c (load_partial_dies): Update.
2770         * mdebugread.c (parse_partial_symbols): Update.
2771         (handle_psymbol_enumerators): Update.
2772         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2773         * psymtab.c (add_psymbol_to_bcache): Likewise.
2774         (add_psymbol_to_list): Likewise.
2775         * symtab.c (symbol_set_names): Likewise.
2776         * symtab.h (symbol_set_names): Likewise.
2777         * xcoffread.c (scan_xcoff_symtab): Update.
2778
2779 2019-09-11  Tom Tromey  <tom@tromey.com>
2780
2781         * symfile-mem.c (symbol_file_add_from_memory): Use
2782         bfd_set_filename.
2783         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2784         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2785
2786 2019-09-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * dwarf-index-write.c (write_psymbols): Extend error message.
2789         (debug_names::insert): Add Ada code.
2790         (debug_names::write_psymbols): Remove Ada check.
2791         (debug_names) <m_string_obstack>: New member.
2792         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2793         (gdb_index_symbol_name_matcher::matches): Remove.
2794         (mapped_index_base::find_name_components_bounds): Add "lang"
2795         parameter.
2796         (mapped_index_base::build_name_components): Also split names
2797         according to Ada syntax.
2798         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2799         type of "match_callback".
2800         (check_match, check_find_bounds_finds)
2801         (dw2_expand_symtabs_matching): Update.
2802         (dw2_debug_names_iterator): Add new constructor.
2803         (dw2_debug_names_map_matching_symbols): New function.
2804         (dw2_debug_names_expand_symtabs_matching): Update.
2805         (dwarf2_debug_names_functions): Use
2806         dw2_debug_names_map_matching_symbols.
2807
2808 2019-09-10  Tom Tromey  <tromey@adacore.com>
2809
2810         * dwarf2read.c (dw2_get_file_names_reader): Add the
2811         CU's file name to the results.
2812
2813 2019-09-10  Tom Tromey  <tromey@adacore.com>
2814
2815         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2816         map_matching_symbols.  Update.
2817         * dwarf2read.c (dw2_map_matching_symbols): Update.
2818         * psymtab.c (match_partial_symbol): Change type; update.
2819         (psym_map_matching_symbols): Likewise.
2820         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2821         type; update.
2822         * symfile.h (struct quick_symbol_functions)
2823         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2824         Remove "match".
2825
2826 2019-09-10  Tom Tromey  <tromey@adacore.com>
2827
2828         * psymtab.c (map_block): Remove.
2829         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2830         * symtab.c (iterate_over_symbols_terminated): New function.
2831         * symtab.c (iterate_over_symbols_terminated): Declare.
2832
2833 2019-09-10  Tom Tromey  <tromey@adacore.com>
2834
2835         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2836         * language.h (struct language_defn) <la_iterate_over_symbols>:
2837         Return bool.
2838         * symtab.c (iterate_over_symbols): Return bool.
2839         * symtab.h (iterate_over_symbols): Return bool.
2840
2841 2019-09-10  Tom Tromey  <tromey@adacore.com>
2842
2843         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2844         (add_nonlocal_symbols): Update.
2845         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2846         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2847         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2848         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2849         Change type of "callback".  Remove "data".
2850
2851
2852 2019-09-09  Ali Tamur  <tamur@google.com>
2853
2854         * dwarf2read.c (comp_unit_head): Update comment.
2855         (dwarf2_dwo_name): New function declaration.
2856         (dwarf_unit_type_name): New function declaration.
2857         (read_comp_unit_head): Add support for new compilation units,
2858         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2859         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2860         (currently named as "signature") in their header. Also clarify error
2861         messages.
2862         (lookup_dwo_id): New function. Returns the dwo id of the given
2863         compile unit.
2864         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2865         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2866         functions.
2867         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2868         (dwarf2_dwo_name): Get the dwo name if present.
2869         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2870         purposes.
2871
2872 2019-09-09  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2875
2876 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2877
2878         * python/python.c (do_start_initialization): Make progname_copy static,
2879         to avoid a leak report.
2880
2881 2019-09-08  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2884
2885 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2886
2887         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2888         Change type to gdb::optional<block_enum>.
2889         (dw2_symtab_iter_init): Change block_index parameter type
2890         to gdb::optional<block_enum>.
2891         (dw2_lookup_symbol): Change block_index parameter
2892         type to block_enum.c
2893         (dw2_debug_names_lookup_symbol): Likewise.
2894         * psymtab.c (psym_lookup_symbol): Likewise.
2895         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2896         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2897         Likewise.
2898
2899 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2900
2901         * defs.h (relocate_gdb_directory): Change int to bool in
2902         signature and rename flag to relocatable.
2903         * main.c (relocate_path): Likewise.
2904         (relocate_gdb_directory): Likewise.
2905
2906 2019-09-06  Alan Modra  <amodra@gmail.com>
2907
2908         * coffread.c (coff_symfile_read): Constify filename variable.
2909         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2910         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2911         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2912         * solib.c (reload_shared_libraries_1): Likewise.
2913         * symfile.c (reread_symbols): Likewise.
2914         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2915         * solib-darwin.c (darwin_bfd_open): Likewise.
2916         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2917
2918 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2919
2920         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2921         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2922
2923 2019-09-03  Tom Tromey  <tromey@adacore.com>
2924
2925         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2926         types.
2927         (has_negatives): Unbias a range type bound.
2928         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2929         * gdbtypes.c (operator==): Handle new field.
2930         (create_range_type): Add "bias" parameter.
2931         (create_static_range_type, resolve_dynamic_range): Update.
2932         * gdbtypes.h (struct range_bounds) <bias>: New member.
2933         (create_range_type): Add bias parameter.
2934         * printcmd.c (print_scalar_formatted): Unbias range types.
2935         * value.c (unpack_long): Unbias range types.
2936         (pack_long): Bias range types.
2937
2938 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2939
2940         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2941         probe arguments.
2942
2943 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2944
2945         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2946         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2947         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2948         (compile_probe_arg): Likewise.
2949         * probe.h (get_argument_count): Likewise.
2950         * solib-svr4.c (solib_event_probe_action): Likewise.
2951         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2952
2953 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2954
2955         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2956         code to here...
2957         (svr4_create_solib_event_breakpoints): ...from here.
2958
2959 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2960
2961         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2962         suffix from warning message.
2963
2964 2019-08-30  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-winsource.h (struct tui_source_window_base)
2967         <refresh_all>: Don't declare.
2968         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2969         Remove.
2970         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2971         tui_show_locator_content.
2972         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2973         declare.
2974         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2975         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2976         declare.
2977
2978 2019-08-30  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2981
2982 2019-08-30  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2985         Remove unnecessary forward declarations.
2986
2987 2019-08-30  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2990         rerender.
2991         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2992         tui_show_locator_content.
2993
2994 2019-08-30  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2997         (tui_locator_window::rerender): Rewrite using body of previous
2998         tui_show_locator_content.
2999
3000 2019-08-30  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3003         set_locator_fullname>: New methods.
3004         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3005         Rename from tui_set_locator_fullname.
3006         (tui_locator_window::set_locator_info): Rename from
3007         tui_set_locator_info.  Return bool.
3008         (tui_update_locator_fullname, tui_show_frame_info): Update.
3009
3010 2019-08-30  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3013
3014 2019-08-30  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3017         call touchwin.
3018
3019 2019-08-30  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-wingeneral.c (box_win): Assume win_info and
3022         win_info->handle cannot be NULL.
3023
3024 2019-08-30  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3027         refresh_window>: Declare.
3028         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3029         resize.
3030         (tui_data_item_window::rerender): Rename from
3031         tui_display_register.
3032         (tui_data_item_window::refresh_window): New method.
3033         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3034         no-op.
3035
3036 2019-08-30  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3039         regs_column_count, current_group>: Move later.  Now private.
3040         <get_current_group>: New method.
3041         * tui/tui-regs.c (tui_reg_command): Update.
3042         * tui/tui-layout.c (tui_set_layout): Update.
3043
3044 2019-08-30  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3047         (tui_data_window::rerender): Don't call
3048         check_and_display_highlight_if_needed.
3049         (tui_data_window::refresh_all): Remove call to
3050         erase_data_content.
3051
3052 2019-08-30  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3055         (tui_data_window::display_registers_from)
3056         (tui_data_window::display_reg_element_at_line)
3057         (tui_data_window::display_registers_from_line): Remove checks of
3058         "empty".
3059
3060 2019-08-30  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3063         Don't declare.
3064         * tui/tui-regs.c (tui_data_window::show_registers): Call
3065         rerender.
3066         (tui_data_window::rerender): Rename from display_all_data.
3067         (tui_data_window::rerender): Remove old implementation.
3068
3069 2019-08-30  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3072         text.
3073         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3074
3075 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3076             Sergio Durigan Junior  <sergiodj@redhat.com>
3077
3078         PR win32/24284
3079         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3080
3081 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3082
3083         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3084         when searching for types.
3085
3086 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * f-lang.c (f_language_defn): Use f_print_typedef.
3089         * f-lang.h (f_print_typedef): Declare.
3090         * f-typeprint.c (f_print_typedef): Define.
3091
3092 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3093
3094         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3095
3096 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3097
3098         * cli/cli-utils.c (info_print_options_defs): Delete.
3099         (make_info_print_options_def_group): Delete.
3100         (extract_info_print_options): Delete.
3101         (info_print_command_completer): Delete.
3102         (info_print_args_help): Add extra parameter, and optionally
3103         include text about -n flag.
3104         * cli/cli-utils.h (struct info_print_options): Delete.
3105         (extract_info_print_options): Delete declaration.
3106         (info_print_command_completer): Delete declaration.
3107         (info_print_args_help): Add extra parameter, extend header
3108         comment.
3109         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3110         search_symbols.
3111         * stack.c (struct info_print_options): New type.
3112         (info_print_options_defs): New file scoped variable.
3113         (make_info_print_options_def_group): New static function.
3114         (info_print_command_completer): New static function.
3115         (info_locals_command): Update to use new local functions.
3116         (info_args_command): Likewise.
3117         (_initialize_stack): Add extra parameter to calls to
3118         info_print_args_help.
3119         * symtab.c (search_symbols): Add extra parameter, use this to
3120         possibly excluse non-debug symbols.
3121         (symtab_symbol_info): Add extra parameter, which is passed on to
3122         search_symbols.
3123         (struct info_print_options): New type.
3124         (info_print_options_defs): New file scoped variable.
3125         (make_info_print_options_def_group): New static function.
3126         (info_print_command_completer): New static function.
3127         (info_variables_command): Update to use local functions, and pass
3128         extra parameter through to symtab_symbol_info.
3129         (info_functions_command): Likewise.
3130         (info_types_command): Pass additional argument through to
3131         symtab_symbol_info.
3132         (rbreak_command): Pass extra argument to search_symbols.
3133         (_initialize_symtab): Add extra arguments for calls to
3134         info_print_args_help, and update help text for 'info variables',
3135         'whereis', and 'info functions' commands.
3136         * symtab.h (search_symbols): Add extra argument to declaration.
3137         * NEWS: Mention new flags.
3138
3139 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3140
3141         * symtab.c (lookup_static_symbol): Call the new function (and move
3142         it down to be next to lookup_global_symbol).
3143         (struct global_sym_lookup_data): Add block_enum member and rename to...
3144         (struct global_or_static_sym_lookup_data): ...this.
3145         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3146         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3147         (lookup_symbol_global_or_static_iterator_cb): ...this.
3148         (lookup_global_or_static_symbol): New function.
3149         (lookup_global_symbol): Call new function.
3150
3151 2019-08-26  Tom de Vries  <tdevries@suse.de>
3152
3153         PR c++/24852
3154         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3155         when pc_probe.prob == NULL.
3156
3157 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3158
3159         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3160         variable symbol_linkage to symbol_linkage_.
3161
3162 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3163
3164         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3165         represent whether the symbol is static, dynamic, or we don't
3166         know.
3167
3168 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3169
3170         * gdb/rx-tdep.c (rx_register_names): New.
3171         (rx_register_name): Delete.
3172         (rx_psw_type): Delete.
3173         (rx_fpsw_type): Delete.
3174         (rx_register_type): Delete.
3175         (rx_gdbarch_init): Convert target-descriptions.
3176         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3177         * gdb/features/Makefile: Add rx.xml.
3178         * gdb/features/rx.xml: New.
3179         * gdb/features/rx.c: Generated.
3180         * gdb/NEWS: Mention target description support.
3181
3182 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3183
3184         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3185         *slot_ptr.
3186
3187 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3188
3189         * configure.ac: Don't check for 'dlfcn.h' (moved to
3190         gdbsupport/common.m4).
3191         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3192         'gdbsupport/'.
3193         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3194         * compile/compile-c-support.c: Include
3195         'gdbsupport/gdb-dlfcn.h'.
3196         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3197         * gdb-dlfcn.c: Move to...
3198         * gdbsupport/gdb-dlfcn.c: ... here.
3199         * gdb-dlfcn.h: Move to...
3200         * gdbsupport/gdb-dlfcn.h: ... here.
3201
3202 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3203
3204         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3205         the offset field signed.
3206
3207 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3208
3209         * python/lib/gdb/__init__.py (_execute_file): New function.
3210         * python/python.c (python_run_simple_file): Call gdb._execute_file
3211         on Windows.
3212
3213 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3214
3215         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3216         all uses as this was never set to anything but a zero value.
3217
3218 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3219
3220         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3221
3222 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3223
3224         * tui/tui-data.h (tui_gen_win_info): Add an =default
3225         move constructor, required by some GCC versions.
3226
3227 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3228
3229         * go32-nat.c (go32_sysinfo): Add hygon_p.
3230
3231 2019-08-20  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3234         line_from_reg_element_no, first_reg_element_no_inline,
3235         display_all_data, delete_data_content_windows,
3236         erase_data_content>: Now private.
3237
3238 2019-08-20  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3241         (tui_unhighlight_win, tui_highlight_win)
3242         (tui_win_info::make_window): Update.
3243         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3244
3245 2019-08-20  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3248         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3249         (MAX_PID_WIDTH): Move to tui-stack.c.
3250         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3251         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3252         (MAX_PID_WIDTH): Move from tui-data.h.
3253
3254 2019-08-20  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3257         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3258         (box_win): Update.
3259         (tui_gen_win_info::make_window): Rename from tui_make_window.
3260         (tui_win_info::make_window): New method.
3261         (tui_gen_win_info::make_visible): Update.
3262         * tui/tui-source.c (tui_source_window::set_contents): Update.
3263         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3264         (tui_data_window::display_registers_from): Update.
3265         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3266         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3267         Declare.
3268         <can_box>: Remove.
3269         <title>: Remove.
3270         (struct tui_win_info) <make_window>: Declare.
3271         <can_box>: Now virtual.
3272         <title>: New member.
3273         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3274         * tui/tui-command.c (tui_cmd_window::resize): Update.
3275
3276 2019-08-20  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3279         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3280         (tui_data_window::check_register_values): Update.
3281
3282 2019-08-20  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-regs.h (struct tui_data_window): Use
3285         DISABLE_COPY_AND_ASSIGN.
3286         <regs_content>: Change type, removing unique_ptr.
3287         <tui_data_window>: Add move constructor.
3288         * tui/tui-regs.c (tui_data_window::show_registers)
3289         (tui_data_window::show_register_group)
3290         (tui_data_window::display_registers_from)
3291         (tui_data_window::display_registers_from)
3292         (tui_data_window::first_data_item_displayed)
3293         (tui_data_window::delete_data_content_windows)
3294         (tui_data_window::rerender, tui_data_window::refresh_window)
3295         (tui_data_window::check_register_values): Update.
3296
3297 2019-08-20  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3300         show_register_group>: Declare.
3301         (tui_show_register_group): Don't declare.
3302         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3303         tui_show_registers.
3304         (tui_data_window::show_register_group): Rename from
3305         tui_show_register_group.
3306         (tui_data_window::check_register_values, tui_reg_command):
3307         Update.
3308         * tui/tui-layout.c (tui_set_layout): Update.
3309
3310 2019-08-20  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3313         Declare.
3314         (tui_check_register_values): Don't declare.
3315         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3316         from tui_check_register_values.
3317         * tui/tui-hooks.c (tui_register_changed): Update.
3318
3319 2019-08-20  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-regs.c (tui_reg_layout): Move later.
3322         (tui_show_registers): Don't enable TUI mode or change layout.
3323
3324 2019-08-20  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui-regs.h (struct tui_data_item_window)
3327         <~tui_data_item_window>: Remove.
3328         <content>: Now a unique_xmalloc_ptr.
3329         * tui/tui-regs.c (tui_register_format): Return a
3330         unique_xmalloc_ptr.
3331         (tui_get_register): Update.
3332         (~tui_data_item_window): Remove.
3333         (tui_data_window::display_registers_from, tui_display_register):
3334         Update.
3335         * tui/tui-io.h (tui_expand_tabs): Update.
3336         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3337         Remove "col" parameter.
3338
3339 2019-08-20  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3342         field.
3343         * tui/tui-regs.c (~tui_data_item_window): Update.
3344
3345 2019-08-20  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3348         earlier.
3349
3350 2019-08-20  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3353
3354 2019-08-20  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-source.h (struct tui_source_window): Update.
3357         * tui/tui-regs.c (tui_show_registers): Update.
3358         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3359         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3360         (NO_REGS_STRING): Remove defines.
3361
3362 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3363
3364         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3365         unnecessary thread walk if remote doesn't support the packet.
3366
3367 2019-08-19  Tom Tromey  <tromey@adacore.com>
3368
3369         * python/py-value.c (value_has_field): Fix indentation.
3370
3371 2019-08-19  Tom Tromey  <tromey@adacore.com>
3372
3373         * printcmd.c (do_one_display, info_display_command): Update.
3374         * block.h (contained_in): Return bool.  Add allow_nested
3375         parameter.
3376         * block.c (contained_in): Return bool.  Add allow_nested
3377         parameter.
3378
3379 2019-08-19  Tom Tromey  <tom@tromey.com>
3380
3381         * configure: Rebuild.
3382         * configure.ac: Disallow the combination of -static-libstdc++ and
3383         source highlight.
3384         * source-cache.c (get_language_name): Handle rust.
3385         (source_cache::get_source_lines): Ignore highlighting exceptions.
3386
3387 2019-08-16  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3390         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3391         (struct tui_source_window_base) <make_visible, refresh_window,
3392         resize>: Remove methods.
3393         <execution_info>: Remove field.
3394         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3395         (tui_show_source_line, tui_source_window_base)
3396         (~tui_source_window_base): Update.
3397         (tui_source_window_base::resize)
3398         (tui_source_window_base::make_visible)
3399         (tui_source_window_base::refresh_window): Remove.
3400         (tui_source_window_base::update_exec_info): Update.
3401         * tui/tui-source.c (tui_source_window::set_contents): Update.
3402         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3403
3404 2019-08-16  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3407         deprecated_query_hook.
3408
3409 2019-08-16  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3412         (tui_update_source_windows_with_line): Update.
3413         * tui/tui-source.h (struct tui_source_window)
3414         <show_symtab_source>: Declare.
3415         (tui_show_symtab_source): Don't declare.
3416         * tui/tui-source.c (tui_show_symtab_source): Rename from
3417         tui_show_symtab_source.
3418
3419 2019-08-16  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-winsource.h (struct tui_source_window_base)
3422         <set_contents>: Declare.
3423         * tui/tui-winsource.c
3424         (tui_source_window_base::update_source_window_as_is): Update.
3425         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3426         Declare.
3427         (tui_set_source_content): Don't declare.
3428         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3429         tui_set_source_content.
3430         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3431         Declare.
3432         (tui_set_disassem_content): Don't declare.
3433         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3434         tui_set_disassem_content.
3435
3436 2019-08-16  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-winsource.h (struct tui_source_window_base)
3439         <update_breakpoint_info>: Declare.
3440         (tui_update_breakpoint_info): Don't declare.
3441         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3442         (tui_update_all_breakpoint_info): Update.
3443         (tui_source_window_base::update_breakpoint_info): Rename from
3444         tui_update_breakpoint_info.
3445         (tui_source_window_base::update_exec_info): Update.
3446
3447 2019-08-16  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-winsource.h (struct tui_source_window_base)
3450         <update_source_window>: Declare.
3451         (tui_update_source_window): Don't declare.
3452         * tui/tui-winsource.c
3453         (tui_source_window_base::update_source_window): Rename from
3454         tui_update_source_window.
3455         (tui_source_window_base::rerender): Update.
3456         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3457         * tui/tui-disasm.c (tui_show_disassem)
3458         (tui_show_disassem_and_update_source)
3459         (tui_disasm_window::maybe_update): Update.
3460
3461 2019-08-16  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-winsource.h (struct tui_source_window_base)
3464         <update_source_window_as_is>: Declare.
3465         (tui_update_source_window_as_is): Don't declare.
3466         * tui/tui-winsource.c (tui_update_source_window): Update
3467         (tui_source_window_base::update_source_window_as_is): Rename from
3468         tui_update_source_window_as_is.
3469         (tui_source_window_base::refill): Update.
3470         * tui/tui-source.c (tui_show_symtab_source): Update.
3471         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3472         Update.
3473
3474 2019-08-16  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-winsource.h (tui_update_source_window)
3477         (tui_update_source_window_as_is): Remove "noerror" parameter.
3478         * tui/tui-winsource.c (tui_update_source_window)
3479         (tui_update_source_window_as_is): Remove "noerror" parameter.
3480         (tui_update_source_windows_with_addr)
3481         (tui_update_source_windows_with_line)
3482         (tui_source_window_base::rerender)
3483         (tui_source_window_base::refill): Update.
3484         * tui/tui-source.h (tui_set_source_content)
3485         (tui_show_symtab_source): Remove "noerror" parameter.
3486         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3487         parameter.
3488         (tui_show_symtab_source): Likewise.
3489         (tui_source_window::maybe_update): Update.
3490         * tui/tui-disasm.c (tui_show_disassem)
3491         (tui_show_disassem_and_update_source)
3492         (tui_disasm_window::do_scroll_vertical)
3493         (tui_disasm_window::maybe_update): Update.
3494
3495 2019-08-16  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui.c (tui_is_window_visible): Update.
3498         * tui/tui-wingeneral.c (tui_make_window)
3499         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3500         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3501         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3502         (tui_set_win_height_command, parse_scrolling_args): Update.
3503         * tui/tui-source.c (tui_source_window::style_changed): Update.
3504         * tui/tui-regs.c (tui_show_registers)
3505         (tui_data_window::first_data_item_displayed)
3506         (tui_data_window::delete_data_content_windows)
3507         (tui_check_register_values, tui_reg_command): Update.
3508         * tui/tui-disasm.c (tui_show_disassem): Update.
3509         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3510         method.
3511         <is_visible>: Remove field.
3512         * tui/tui-data.c (tui_next_win, tui_prev_win)
3513         (tui_delete_invisible_windows): Update.
3514
3515 2019-08-16  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-winsource.h (struct tui_source_window_base)
3518         <m_has_locator>: Remove.
3519         * tui/tui-layout.c (show_source_disasm_command, show_data)
3520         (show_source_or_disasm_and_command): Update.
3521
3522 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3523
3524         * NEWS (Other MI changes): New subsection.
3525         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3526         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3527         * arch-utils.c (default_get_pc_address_flags): New function.
3528         * arch-utils.h (default_get_pc_address_flags): New declaration.
3529         * gdbarch.sh: Add get_pc_address_flags.
3530         * gdbarch.c: Regenerate.
3531         * gdbarch.h: Likewise.
3532         * stack.c (print_pc): New function.
3533         (print_frame_info) (print_frame): Call print_pc.
3534
3535 2019-08-16  Tom de Vries  <tdevries@suse.de>
3536
3537         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3538         print_objfile_section_info.
3539
3540 2019-08-15  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3543         calling update_cmdwin_start_line.
3544         * tui/tui-winsource.h (struct tui_source_window_base)
3545         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3546         <rerender>: Declare.
3547         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3548         Call rerender.
3549         (tui_source_window_base::set_new_height): Remove.
3550         (tui_source_window_base::rerender): Rename from
3551         do_make_visible_with_new_height.
3552         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3553         resize method.
3554         (tui_win_info::make_invisible_and_set_new_height)
3555         (tui_win_info::make_visible_with_new_height): Remove.
3556         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3557         Declare.
3558         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3559         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3560         do_make_visible_with_new_height>: Don't declare.
3561         <rerender>: Declare.
3562         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3563         set_new_height.
3564         (tui_data_window::do_make_visible_with_new_height): Remove.
3565         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3566         call tui_show_locator_content.
3567         (tui_gen_win_info::resize): Call rerender.
3568         (show_source_or_disasm_and_command): Don't call
3569         tui_show_locator_content.
3570         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3571         method.
3572         (struct tui_win_info) <rerender>: Declare.
3573         <set_new_height, make_invisible_and_set_new_height,
3574         make_visible_with_new_height>: Don't declare.
3575         * tui/tui-data.c (tui_win_list::rerender): New method.
3576         * tui/tui-command.h (struct tui_cmd_window)
3577         <do_make_visible_with_new_height>: Don't declare.
3578         * tui/tui-command.c
3579         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3580
3581 2019-08-15  Tom Tromey  <tromey@adacore.com>
3582
3583         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3584         * ada-lang.c (ada_enum_name): Likewise.
3585
3586 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3587
3588         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3589         leading underscore.
3590         (GdbOutputErrorFile): Likewise.
3591         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3592         accordingly.
3593         (execute_unwinders): Rename to have a leading underscore.
3594         (auto_load_packages): Likewise.
3595         (global scope): Adjust call to auto_load_packages accordingly.
3596         (GdbSetPythonDirectory): Likewise.
3597         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3598         instead of execute_unwinders.
3599
3600 2019-08-15  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3603         (show_data): Don't change window visibility.
3604         (tui_gen_win_info::resize): Remove special case for command
3605         window.  Use wresize, when available.
3606         (show_source_or_disasm_and_command): Don't change window
3607         visibility.
3608         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3609         <make_visible>: New method.
3610         * tui/tui-command.c (tui_cmd_window::resize): New method.
3611
3612 2019-08-15  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3615         (struct tui_source_windows): New.
3616         * tui/tui-winsource.c (tui_display_main): Update.
3617         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3618         (new_height_ok, parse_scrolling_args): Update.
3619         * tui/tui-layout.c (show_layout, show_data): Update.
3620         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3621         (tui_add_to_source_windows): Don't declare.
3622         * tui/tui-data.c (source_windows, tui_source_windows)
3623         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3624
3625 2019-08-15  Tom Tromey  <tom@tromey.com>
3626
3627         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3628         Rename from reset.
3629         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3630         * tui/tui-layout.c (show_source_disasm_command, show_data):
3631         Update.
3632         (tui_gen_win_info::resize): Rename.
3633         (show_source_or_disasm_and_command): Update.
3634         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3635         reset.
3636
3637 2019-08-15  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3640         * tui/tui-interp.c (tui_interp::init): Don't call
3641         tui_initialize_static_data.
3642         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3643
3644 2019-08-15  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3647         examine tui_win_list.
3648
3649 2019-08-15  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3652         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3653         tui_clear_source_content.
3654         (tui_clear_source_content): Remove.
3655         (tui_source_window_base::do_erase_source_content): Hoist call to
3656         content.clear().
3657         * tui/tui-stack.c (tui_show_frame_info): Don't call
3658         tui_clear_source_content.
3659
3660 2019-08-15  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-winsource.h (struct tui_source_window_base)
3663         <do_erase_source_content>: New method.
3664         <erase_source_content>: New method.
3665         (tui_erase_source_content): Don't declare.
3666         * tui/tui-winsource.c (tui_clear_source_content): Update.
3667         (tui_source_window_base::do_erase_source_content): Rename from
3668         tui_erase_source_content.
3669         (tui_source_window_base::show_source_content): Update.
3670         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3671         * tui/tui-source.h (struct tui_source_window)
3672         <erase_source_content>: New method.
3673         * tui/tui-disasm.h (struct tui_disasm_window)
3674         <erase_source_content>: New method.
3675
3676 2019-08-15  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3679         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3680         constructor.
3681         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3682         * tui/tui-source.c (tui_set_source_content): Update.
3683         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3684
3685 2019-08-15  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3688         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3689         tui-source.c.
3690         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3691         Declare.
3692         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3693         method.
3694         (tui_source_window::maybe_update): Update.
3695
3696 2019-08-15  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3699         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3700         tui-disasm.c.
3701         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3702         Declare.
3703         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3704         method.
3705         (tui_disasm_window::maybe_update): Update.
3706
3707 2019-08-15  Tom Tromey  <tom@tromey.com>
3708
3709         * tui/tui-winsource.h (struct tui_source_window_base)
3710         <maybe_update>: Declare.
3711         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3712         method.
3713         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3714         Declare.
3715         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3716         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3717         Declare.
3718         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3719
3720 2019-08-15  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3723
3724 2019-08-15  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-wingeneral.c: Include tui-stack.h.
3727         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3728         (struct tui_locator_window): Move from tui-data.h.
3729         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3730         (tui_initialize_static_data): Move from tui-data.c.
3731         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3732         (struct tui_locator_window): Move to tui-stack.c.
3733         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3734         (tui_initialize_static_data): Move to tui-stack.c.
3735
3736 2019-08-15  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-layout.c (show_source_disasm_command)
3739         (show_source_or_disasm_and_command): Use make_visible method, not
3740         tui_make_window.
3741         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3742         Remove.
3743
3744 2019-08-15  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-wingeneral.h (tui_make_window): Update.
3747         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3748         parameter.
3749         (tui_gen_win_info::make_visible): Update.
3750         * tui/tui-regs.c (tui_data_window::display_registers_from):
3751         Update.
3752         * tui/tui-layout.c (show_source_disasm_command)
3753         (show_source_or_disasm_and_command): Update.
3754         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3755         (enum tui_box): Remove.
3756         (struct tui_win_info) <can_box>: New method.
3757         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3758         method.
3759
3760 2019-08-15  Tom de Vries  <tdevries@suse.de>
3761
3762         * linux-nat-trad.c: Include gdbarch.h.
3763
3764 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3765
3766         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3767         register sizes.
3768
3769 2019-08-14  Tom Tromey  <tromey@adacore.com>
3770
3771         * darwin-nat.c: Include gdbarch.h.
3772         * darwin-nat-info.c: Include gdbarch.h.
3773
3774 2019-08-13  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3777         Remove.
3778         * tui/tui-data.c (tui_initialize_static_data): Update.
3779
3780 2019-08-13  Tom Tromey  <tom@tromey.com>
3781
3782         * tui/tui-winsource.h (struct tui_exec_info_window)
3783         <~tui_exec_info_window, maybe_allocate_content, get_content,
3784         m_content>: Remove.
3785         (struct tui_source_window_base) <set_exec_info_content,
3786         show_exec_info_content>: Don't declare.
3787         * tui/tui-winsource.c
3788         (tui_exec_info_window::maybe_allocate_content): Remove.
3789         (tui_source_window_base::update_exec_info): Rename from
3790         set_exec_info_content.
3791         (tui_source_window_base::show_exec_info_content)
3792         (tui_source_window_base::update_exec_info): Remove.
3793
3794 2019-08-13  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3797         declare.
3798         * tui/tui-winsource.c (tui_update_source_window_as_is)
3799         (tui_update_source_windows_with_addr, tui_erase_source_content):
3800         Update.
3801         (tui_clear_exec_info_content): Remove.
3802
3803 2019-08-13  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3806         declare.
3807         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3808         call tui_erase_exec_info_content.
3809         (tui_clear_exec_info_content): Rename from
3810         tui_erase_exec_info_content.
3811         (tui_clear_exec_info_content): Delete.
3812
3813 2019-08-13  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-winsource.h (struct tui_source_window_base)
3816         <show_exec_info_content>: Declare.
3817         (tui_show_exec_info_content): Don't declare.
3818         * tui/tui-winsource.c
3819         (tui_source_window_base::show_exec_info_content): Rename from
3820         tui_show_exec_info_content.
3821         (tui_source_window_base::update_exec_info): Update.
3822
3823 2019-08-13  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3826         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3827         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3828         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3829         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3830         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3831         ... here.
3832
3833 2019-08-13  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-winsource.h (struct tui_source_window_base)
3836         <update_exec_info>: Declare.
3837         (tui_update_exec_info): Don't declare.
3838         * tui/tui-winsource.c (tui_update_source_window_as_is)
3839         (tui_source_window_base::refresh_all)
3840         (tui_update_all_breakpoint_info): Update.
3841         (tui_source_window_base::update_exec_info): Rename from
3842         tui_update_exec_info.
3843         * tui/tui-stack.c (tui_show_frame_info): Update.
3844
3845 2019-08-13  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-winsource.h (struct tui_source_window_base)
3848         <set_exec_info_content>: Declare.
3849         (tui_set_exec_info_content): Don't declare.
3850         * tui/tui-winsource.c
3851         (tui_source_window_base::set_exec_info_content): Rename from
3852         tui_set_exec_info_content.
3853         (tui_update_exec_info): Update.
3854
3855 2019-08-13  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-winsource.h (struct tui_source_window_base)
3858         <show_source_content>: Declare.
3859         (tui_show_source_content): Don't declare.
3860         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3861         (tui_source_window_base::show_source_content): Rename from
3862         tui_show_source_content.
3863         (tui_source_window_base::refresh_all): Update.
3864         * tui/tui-layout.c (show_source_disasm_command)
3865         (show_source_or_disasm_and_command): Update.
3866
3867 2019-08-13  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-winsource.c (tui_erase_source_content)
3870         (tui_show_source_content, tui_source_window_base::refresh_all):
3871         Update.
3872         * tui/tui-wingeneral.h
3873         (tui_check_and_display_highlight_if_needed): Don't declare.
3874         * tui/tui-wingeneral.c
3875         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3876         check_and_display_highlight_if_needed.
3877         * tui/tui-win.c (tui_rehighlight_all)
3878         (tui_win_info::make_visible_with_new_height): Update.
3879         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3880         (tui_data_window::erase_data_content)
3881         (tui_data_window::display_all_data): Update.
3882         * tui/tui-data.h (struct tui_win_info)
3883         <check_and_display_highlight_if_needed>: Declare.
3884
3885 2019-08-13  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-win.c (tui_resize_all): Call
3888         tui_delete_invisible_windows.
3889         * tui/tui-layout.c (show_layout): Call
3890         tui_delete_invisible_windows.
3891         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3892         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3893
3894 2019-08-13  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3897         tui_add_win_to_layout.
3898
3899 2019-08-13  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3902         * tui/tui-layout.c (tui_default_win_height): Now static.
3903
3904 2019-08-13  Tom Tromey  <tom@tromey.com>
3905
3906         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3907         single switch.
3908         (show_source_disasm_command, show_source_or_disasm_and_command):
3909         Don't check current layout.
3910
3911 2019-08-13  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-wingeneral.c (make_all_visible): Remove.
3914         (tui_make_all_invisible): Simplify.
3915         * tui/tui-layout.c (tui_make_all_invisible): Move from
3916         tui-wingeneral.c; simplify.
3917         (show_layout): Hoist call to tui_make_all_invisible.
3918         (show_data): Don't call tui_make_all_invisible.
3919
3920 2019-08-13  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3923         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3924
3925 2019-08-13  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3928         tui-data.c.
3929         (show_source_disasm_command, show_data)
3930         (show_source_or_disasm_and_command): Don't use
3931         tui_set_current_layout_to.
3932         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3933         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3934         tui-layout.c.
3935         (tui_set_current_layout_to): Remove.
3936
3937 2019-08-13  Tom Tromey  <tom@tromey.com>
3938
3939         * tui/tui-layout.c (tui_set_layout): Update.
3940         * tui/tui-data.h (struct tui_layout_def): Remove.
3941         (tui_layout_def): Don't declare.
3942         * tui/tui-data.c (layout_def): Remove.
3943         (tui_layout_def): Remove.
3944
3945 2019-08-13  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-winsource.h (struct tui_source_window_base)
3948         <clear_detail>: No longer "override".
3949         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3950         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3951         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3952         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3953         Remove.
3954         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3955
3956 2019-08-13  Tom Tromey  <tromey@adacore.com>
3957
3958         * tracepoint.c: Don't include readline.h or history.h.
3959
3960 2019-08-12  Tom Tromey  <tom@tromey.com>
3961
3962         * configure: Rebuild.
3963         * configure.ac: Check for readline 7.
3964         * NEWS: Mention readline 7 requirement.
3965         * README: Update.
3966
3967 2019-08-12  Tom Tromey  <tom@tromey.com>
3968
3969         * mingw-hdep.c (gdb_select): Remove readline hack.
3970
3971 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3972
3973         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3974         when the function fails.
3975
3976 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3977
3978         * s390-tdep.c (s390_type_align): New function.
3979         (s390_gdbarch_init): Set it as type_align gdbarch method.
3980
3981 2019-08-09  Tom de Vries  <tdevries@suse.de>
3982
3983         PR gdb/24591
3984         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3985         pc_low with relocation offset.
3986
3987 2019-08-07  Tom Tromey  <tromey@adacore.com>
3988
3989         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3990         (print_frame_args): Update.
3991         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3992         Update.
3993         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3994         * frame.h (struct frame_arg): Add initializers.
3995         <error>: Now a unique_xmalloc_ptr.
3996
3997 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3998
3999         * NEWS: Expand the Pointer Authentication entry.
4000         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4001         (aarch64_frame_unmask_lr): ... to this.
4002         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4003         Call aarch64_frame_unmask_lr.
4004         * frame.c (struct frame_info): Add "masked" variable.
4005         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4006         (fprint_frame): Check for masked pc.
4007         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4008         declarations.
4009         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4010         * stack.c (print_frame): Check for masked pc.
4011
4012 2019-08-06  Tom Tromey  <tom@tromey.com>
4013
4014         * stabsread.c (patch_block_stabs, read_one_struct_field)
4015         (read_enum_type): Use obstack_strndup.
4016         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4017         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4018         * dwarf2read.c (guess_full_die_structure_name)
4019         (anonymous_struct_prefix): Use obstack_strndup.
4020         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4021         * c-exp.y (yylex): Use obstack_strndup.
4022         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4023         (write_var_or_type): Use obstack_strndup.
4024
4025 2019-08-06  Tom Tromey  <tom@tromey.com>
4026
4027         * symfile.c (reread_symbols): Use obstack_strdup.
4028         * stabsread.c (read_type): Use obstack_strdup.
4029         * gdb_obstack.h (obstack_strdup): New overload.
4030         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4031         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4032         (dwarf2_canonicalize_name): Use obstack_strdup.
4033         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4034         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4035         Use obstack_strdup.
4036
4037 2019-08-06  Tom Tromey  <tom@tromey.com>
4038
4039         * gdb_obstack.h (obstack_strdup): Define.
4040         * gdb_obstack.c (obstack_strdup): Don't define.
4041
4042 2019-08-06  Tom Tromey  <tom@tromey.com>
4043
4044         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4045         obstack_strdup.
4046         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4047         obstack_strdup.
4048         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4049         * stabsread.c (common_block_start): Use obstack_strdup.
4050         * objfiles.c (set_objfile_main_name, objfile): Use
4051         obstack_strdup.
4052         * namespace.c (add_using_directive): Use obstack_strdup.
4053         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4054         * jit.c (finalize_symtab): Use obstack_strdup.
4055         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4056         (guess_partial_die_structure_name, partial_die_info::fixup)
4057         (dwarf2_name): Use obstack_strdup.
4058         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4059         obstack_strdup.
4060         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4061         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4062         obstack_strdup.
4063         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4064
4065 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         * unittests/help-doc-selftests.c: New file.
4068         * Makefile.in: Add the new file.
4069
4070 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4071
4072         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4073         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4074         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4075         the trailing '.' is not output, and the first character is uppercased.
4076         (print_help_for_command): Update call to print_doc_line.
4077         (print_doc_of_command): Likewise.
4078         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4079         * cli/cli-option.c (append_indented_doc): Do not append newline.
4080         (build_help_option): Append newline after first appended_indented_doc
4081         only if a second call is done.
4082         (build_help): Append 2 new lines before each option, except the first
4083         one.
4084         * compile/compile.c (_initialize_compile): Add new lines after
4085         %OPTIONS%, when not at the end of the help.
4086         Change help doc or code
4087         producing the help doc to respect the invariants.
4088         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4089         Also removed the new line after 'Options:', as all other commands
4090         do not put an empty line between 'Options:' and the first option.
4091         * printcmd.c (_initialize_printcmd): Likewise.
4092         * stack.c (_initialize_stack): Likewise.
4093         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4094         incorrectly telling COMMAND is optional.
4095         * ada-lang.c (_initialize_ada_language): Change help doc or code
4096         producing the help doc to respect the invariants.
4097         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4098         * breakpoint.c (_initialize_breakpoint): Likewise.
4099         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4100         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4101         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4102         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4103         _initialize_cli_style): Likewise.
4104         * corelow.c (core_target_info): Likewise.
4105         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4106         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4107         * filesystem.c (_initialize_filesystem): Likewise.
4108         * frame.c (_initialize_frame): Likewise.
4109         * gnu-nat.c (add_task_commands): Likewise.
4110         * infcall.c (_initialize_infcall): Likewise.
4111         * infcmd.c (_initialize_infcmd): Likewise.
4112         * interps.c (_initialize_interpreter): Likewise.
4113         * language.c (_initialize_language): Likewise.
4114         * linux-fork.c (_initialize_linux_fork): Likewise.
4115         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4116         * maint.c (_initialize_maint_cmds): Likewise.
4117         * memattr.c (_initialize_mem): Likewise.
4118         * printcmd.c (_initialize_printcmd): Likewise.
4119         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4120         _RegEx): Likewise.
4121         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4122         * record-btrace.c (_initialize_record_btrace): Likewise.
4123         * record-full.c (_initialize_record_full): Likewise.
4124         * record.c (_initialize_record): Likewise.
4125         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4126         * regcache.c (_initialize_regcache): Likewise.
4127         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4128         _initialize_remote): Likewise.
4129         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4130         * serial.c (_initialize_serial): Likewise.
4131         * skip.c (_initialize_step_skip): Likewise.
4132         * source.c (_initialize_source): Likewise.
4133         * stack.c (_initialize_stack): Likewise.
4134         * symfile.c (_initialize_symfile): Likewise.
4135         * symtab.c (_initialize_symtab): Likewise.
4136         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4137         * top.c (init_main): Likewise.
4138         * tracefile-tfile.c (tfile_target_info): Likewise.
4139         * tracepoint.c (_initialize_tracepoint): Likewise.
4140         * tui/tui-win.c (_initialize_tui_win): Likewise.
4141         * utils.c (add_internal_problem_command): Likewise.
4142         * valprint.c (value_print_option_defs): Likewise.
4143
4144 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4145
4146         PR build/24886
4147         * configure.ac: Drop enable-libmcheck support.
4148         * configure, config.in: Rebuild.
4149         * libmcheck.m4: Remove.
4150         * acinclude.m4: Don't include it.
4151         * Makefile.in: Don't distribute it.
4152         * top.c (print_gdb_configuration): Don't mention it.
4153
4154 2019-08-06  Tom Tromey  <tom@tromey.com>
4155
4156         * utils.c (set_output_style): Sometimes pass stream to
4157         emit_style_escape.
4158         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4159         * record-btrace.c (btrace_insn_history): Update.
4160         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4161         method.
4162         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4163         Update initializers.
4164         <m_uiout>: New field.
4165         <m_di>: Move lower.
4166         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4167         Remove "uiout" parameter.
4168         (dump_insns): Update.
4169         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4170         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4171
4172 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4173
4174         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4175         (error_in_psymtab_expansion): Likewise.
4176         (lookup_symbol_via_quick_fns): Likewise.
4177         (basic_lookup_transparent_type_quick): Likewise.
4178         (basic_lookup_transparent_type_1): Likewise.
4179
4180 2019-08-06  Tom Tromey  <tromey@adacore.com>
4181
4182         * source.c (last_source_error): Now bool.
4183         (print_source_lines_base): Make "noprint" bool.  Only open
4184         source file when last_source_visited changes.
4185
4186 2019-08-06  Tom Tromey  <tromey@adacore.com>
4187
4188         * annotate.c (annotate_source_line): Use g_source_cache.
4189         * source-cache.c (source_cache::get_plain_source_lines): Change
4190         parameters.  Populate m_offset_cache.
4191         (source_cache::ensure): New method.
4192         (source_cache::get_line_charpos): New method.
4193         (extract_lines): Move lower.  Change parameters.
4194         (source_cache::get_source_lines): Move lower.
4195         * source-cache.h (class source_cache): Update comment.
4196         <get_line_charpos>: New method.
4197         <get_source_lines>: Update comment.
4198         <clear>: Clear m_offset_cache.
4199         <get_plain_source_lines>: Change parameters.
4200         <ensure>: New method
4201         <m_offset_cache>: New member.
4202         * source.c (forget_cached_source_info_for_objfile): Update.
4203         (info_source_command): Use g_source_cache.
4204         (find_source_lines, open_source_file_with_line_charpos): Remove.
4205         (print_source_lines_base, search_command_helper): Use g_source_cache.
4206         * source.h (open_source_file_with_line_charpos): Don't declare.
4207         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4208         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4209         Use g_source_cache.
4210
4211 2019-08-06  Tom Tromey  <tromey@adacore.com>
4212
4213         * source-cache.c (source_cache::get_plain_source_lines):
4214         Remove "first_line" and "last_line" parameters.
4215         (source_cache::get_source_lines): Cache plain text.
4216         * source-cache.h (class source_cache)
4217         <get_plain_source_lines>: Update.
4218
4219 2019-08-06  Tom Tromey  <tromey@adacore.com>
4220
4221         * source-cache.c (extract_lines): No longer a method.
4222         Changed type of parameter.  Include final newline.
4223         (selftests::extract_lines_test): New function.
4224         (_initialize_source_cache): Likewise.
4225         * source-cache.h (class source_cache)
4226         <extract_lines>: Don't declare.
4227
4228 2019-08-06  Tom Tromey  <tromey@adacore.com>
4229
4230         * breakpoint.c (init_breakpoint_sal): Update.
4231         (breakpoint): Update.
4232         * breakpoint.h (struct breakpoint) <filter>: Now a
4233         unique_xmalloc_ptr.
4234
4235 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4236
4237         * NEWS: Mention dictionary access on blocks.
4238         * python/py-block.c (blpy_getitem): New function.
4239         (block_object_as_mapping): New struct.
4240         (block_object_type): Use new struct for tp_as_mapping field.
4241
4242 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4243
4244         * objfiles.h (objfile): Add a comment describing partial symbols.
4245
4246 2019-08-05  Tom Tromey  <tromey@adacore.com>
4247
4248         * compile/compile.c (_initialize_compile): Use _(), not N_().
4249         * thread.c (_initialize_thread): Use _(), not N_().
4250         * stack.c (_initialize_stack): Use _(), not N_().
4251         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4252
4253 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4254
4255         * dwarf2read.c (struct dw2_symtab_iterator):
4256         <want_specific_block>: Remove.
4257         <block_index>: Change type to gdb::optional.
4258         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4259         change type of BLOCK_INDEX parameter to gdb::optional.
4260         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4261         (dw2_lookup_symbol): Don't pass argument for
4262         WANT_SPECIFIC_BLOCK.
4263         (dw2_expand_symtabs_for_function): Don't pass argument for
4264         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4265         (class dw2_debug_names_iterator)
4266         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4267         parameter, change BLOCK_INDEX type to gdb::optional.
4268         <m_want_specific_block>: Remove.
4269         <m_block_index>: Change type to gdb::optional.
4270         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4271         gdb::optional.  Re-write in function of gdb::optional.
4272         (dw2_debug_names_lookup_symbol): Don't pass argument for
4273         WANT_SPECIFIC_BLOCK.
4274         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4275         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4276         BLOCK_INDEX.
4277
4278 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4279
4280         * NEWS: Mention changes to "info sources" command.
4281
4282 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4283
4284         * symtab.c (filename_partial_match_opts): New struct type.
4285         (struct output_source_filename_data): New members
4286         regexp, c_regexp, partial_match.
4287         (output_source_filename): Use new members to decide to print file.
4288         (info_sources_option_defs): New variable.
4289         (make_info_sources_options_def_group, print_info_sources_header,
4290         info_sources_command_completer):
4291         New functions.
4292         (info_sources_command): Read new optional arguments.
4293         (_initialize_symtab): Update info sources help.
4294
4295 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4296
4297         * ada-lang.c (exception_support_info_v0): Renamed from...
4298         (default_exception_support_info): ... this.  Create new
4299         definition for v1.
4300         (ada_has_this_exception_support): Look up catch_handlers_sym.
4301         (ada_exception_support_info_sniffer): Try v0 after default.
4302
4303 2019-08-01  Tom Tromey  <tromey@adacore.com>
4304
4305         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4306         gdbarch.h.
4307
4308 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4309
4310         * s12z-tdep.c: Fix include path for s12z-opc.h.
4311
4312 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4313
4314         * NEWS: Require GNU make 3.82.
4315
4316 2019-07-16  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4319         declare.
4320
4321 2019-07-30  Tom Tromey  <tromey@adacore.com>
4322
4323         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4324
4325 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4326
4327         * printcmd.c (print_address_symbolic): Print negative offsets.
4328         (build_address_symbolic): Force signed arithmetic when computing
4329         offset.
4330
4331 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4332
4333         PR/24474: Add a function to lookup static variables.
4334         * NEWS: Mention this new function.
4335         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4336         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4337         * python/python.c (python_GdbMethods): Add new function.
4338
4339 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4340
4341         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4342         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4343         (objfpy_lookup_static_symbol): New function.
4344         (objfile_object_methods): Add new functions.
4345
4346 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4347
4348         * NEWS: Mention 'set|show print frame-info'.  Mention new
4349         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4350         backtrace argument.  Mention that python frame filtering code
4351         is now consistent with what 'backtrace' command prints.
4352
4353 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4354
4355         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4356         comments.
4357         (print_frame_info_auto, print_frame_info_source_line,
4358         print_frame_info_location, print_frame_info_source_and_location,
4359         print_frame_info_location_and_address, print_frame_info_short_location):
4360         New declarations.
4361         (struct frame_print_options): New member print_frame_info.
4362         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4363         * stack.h (get_user_print_what_frame_info): New declaration.
4364         (frame_show_address): New declaration.
4365         * stack.c (print_frame_arguments_choices): New value 'presence'.
4366         (print_frame_info_auto, print_frame_info_source_line,
4367         print_frame_info_location, print_frame_info_source_and_location,
4368         print_frame_info_location_and_address, print_frame_info_short_location,
4369         print_frame_info_choices, print_frame_info_print_what): New definitions.
4370         (print_frame_args): Only print dots for args if print frame-arguments
4371         is 'presence'.
4372         (frame_print_option_defs): New element for "frame-info".
4373         (get_user_print_what_frame_info): New function.
4374         (frame_show_address): Make non static.  Move comment to stack.h.
4375         (print_frame_info_to_print_what): New function.
4376         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4377         to decide what to print.
4378         (backtrace_command_1): Handle the new print_frame_arguments_presence
4379         value.
4380         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4381         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4382         (py_print_frame): In non-mi mode, use LOCATION as default for
4383         print_what, similarly to frame information printed directly by
4384         backtrace command. Handle frame-info user option in non MI mode.
4385
4386 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4387
4388         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4389         Add case for debugging 32-bit target on 64-bit host.  Revise
4390         comment.
4391
4392 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4393
4394         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4395         instead of find_function_entry_range_from_pc.
4396
4397 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4398
4399         * stack.c (find_frame_funname): Remove code which preferred
4400         minsym over symtab sym in "certain pathological cases".
4401
4402         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4403         parameter.  Change type of "do_demangle" to bool.
4404         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4405         Pass suitable "prefer_sym_over_minsym" flag to
4406         build_address_symbolic().  Don't output "+" for negative offsets.
4407         * printcmd.c (print_address_symbolic): Update invocation of
4408         build_address_symbolic to include a "prefer_sym_over_minsym"
4409         flag.
4410         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4411         Restrict cases in which use of minimal symbol is preferred to that
4412         of a found symbol.  Update comments.
4413
4414         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4415         for entry pc when entry pc is out of range for that FDE.
4416
4417 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4418
4419         PR gdb/24839:
4420         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4421         type.
4422
4423 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4424
4425         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4426         this function's Python signature.
4427
4428
4429 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4430
4431         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4432         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4433         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4434         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4435         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4436
4437
4438 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4439
4440         * h8300-tdep.c (h8300_register_name_common): New.
4441         h8300_register_name): Use h8300_register_name_common.
4442         (h8300s_register_name): Likewise.
4443         (h8300sx_register_name): Likewise.
4444         (h8300h_register_nam): New.
4445         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4446
4447
4448 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4449
4450         * arm-tdep.c (arm_skip_cmse_entry): New function.
4451         (arm_is_sgstubs_section): New function.
4452         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4453
4454 2019-07-22  Tom Tromey  <tom@tromey.com>
4455
4456         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4457         Don't self-assign.
4458
4459 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4462         type_print.
4463
4464 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4467         so that GDB doesn't match any msymbols when searching in the
4468         TYPES_DOMAIN.
4469         (print_symbol_info): Print using typedef_print or type_print based
4470         on the type of the symbol.  Add updated FIXME comment moved from...
4471         (_initialize_symtab): ... move and update FIXME comment to above.
4472
4473 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * NEWS: Mention adding -q option to "info types".
4476         * symtab.c (struct info_types_options): New struct.
4477         (info_types_options_defs): New variable.
4478         (make_info_types_options_def_group): New function.
4479         (info_types_command): Use gdb::option framework to parse options.
4480         (info_types_command_completer): New function.
4481         (_initialize_symtab): Extend the help text on "info types" and
4482         register command completer.
4483
4484 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4485
4486         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4487         (lookup_symbol_in_objfile): Change int to block_enum and add a
4488         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4489
4490 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4491
4492         * MAINTAINERS (Write After Approval): Add self.
4493
4494 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4497         instruction to the dummy code region.
4498
4499 2019-07-19  Tom Tromey  <tromey@adacore.com>
4500
4501         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4502         (ARGSUSED, PARAMS, __func__): Remove rules.
4503
4504 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4505
4506         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4507         * features/arm/arm-with-iwmmxt.c: Remove.
4508         * features/arm/arm-with-iwmmxt.xml: Remove.
4509         * features/arm/arm-with-m-fpa-layout.c: Remove.
4510         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4511         * features/arm/arm-with-m-vfp-d16.c: Remove.
4512         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4513         * features/arm/arm-with-m.c: Remove.
4514         * features/arm/arm-with-m.xml: Remove.
4515         * features/arm/arm-with-neon.c: Remove.
4516         * features/arm/arm-with-neon.xml: Remove.
4517         * features/arm/arm-with-vfpv2.c: Remove.
4518         * features/arm/arm-with-vfpv2.xml: Remove.
4519         * features/arm/arm-with-vfpv3.c: Remove.
4520         * features/arm/arm-with-vfpv3.xml: Remove.
4521
4522 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4523
4524         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4525
4526 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4527
4528         * arch/aarch32.c (aarch32_create_target_description): Create
4529         target descriptions using features.
4530         * arch/arm.c (arm_create_target_description)
4531         (arm_create_mprofile_target_description): Likewise.
4532         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4533
4534 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4535
4536         * Makefile.in: Add new files.
4537         * aarch32-tdep.c: New file.
4538         * aarch32-tdep.h: New file.
4539         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4540         Call aarch32_read_description.
4541         * arch/aarch32.c: New file.
4542         * arch/aarch32.h: New file.
4543         * arch/arm.c (arm_create_target_description)
4544         (arm_create_mprofile_target_description): New function.
4545         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4546         (arm_create_target_description)
4547         (arm_create_mprofile_target_description): New declaration.
4548         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4549         read_description functions.
4550         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4551         Likewise.
4552         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4553         * arm-tdep.c (tdesc_arm_list): New variable.
4554         (arm_register_g_packet_guesses): Call create description functions.
4555         (arm_read_description) (arm_read_mprofile_description): New
4556         function.
4557         * arm-tdep.h (arm_read_description)
4558         (arm_read_mprofile_description): Add declaration.
4559         * configure.tgt: Add new files.
4560
4561 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4562
4563         * top.c (new_ui_command): Open specified terminal just once.
4564
4565 2019-07-18  Tom Tromey  <tromey@adacore.com>
4566
4567         * symtab.c (main_name): Constify return type.
4568         * symfile.c (set_initial_language): Update.
4569         * symtab.h (main_name): Constify return type.
4570
4571 2019-07-17  Tom Tromey  <tom@tromey.com>
4572
4573         * tui/tui-winsource.c (tui_update_source_window)
4574         (tui_update_source_window_as_is)
4575         (tui_update_source_windows_with_line): Remove return.
4576         * tui/tui-disasm.c (tui_show_disassem)
4577         (tui_show_disassem_and_update_source): Remove return.
4578         * tui/tui.c (tui_reset): Remove return.
4579         * tui/tui-wingeneral.c
4580         (tui_check_and_display_highlight_if_needed): Remove return.
4581
4582 2019-07-17  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4585
4586 2019-07-17  Tom Tromey  <tom@tromey.com>
4587
4588         * tui/tui-winsource.h (struct tui_exec_info_window)
4589         (struct tui_source_window_base): Move from tui-data.h.
4590         * tui/tui-winsource.c: Move many method definitions from
4591         elsewhere.  Remove "structuring" comments.
4592         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4593         (tui_source_window_base::refresh_window): Move to
4594         tui-winsource.c.
4595         * tui/tui-win.c (tui_source_window_base::refresh_all)
4596         (tui_source_window_base::update_tab_width)
4597         (tui_source_window_base::set_new_height)
4598         (tui_source_window_base::do_make_visible_with_new_height): Move to
4599         tui-winsource.c.
4600         * tui/tui-source.h: Update.
4601         * tui/tui-source.c (tui_source_window_base::reset): Move to
4602         tui-winsource.c.
4603         * tui/tui-disasm.h: Update.
4604         * tui/tui-data.h (struct tui_exec_info_window): Move to
4605         tui-winsource.h.
4606         (struct tui_source_window_base): Likewise.
4607         * tui/tui-data.c (tui_source_window_base::clear_detail)
4608         (tui_source_window_base, ~tui_source_window_base): Move to
4609         tui-winsource.c.
4610
4611 2019-07-17  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-win.c (tui_resize_all)
4614         (tui_source_window_base::update_tab_width)
4615         (tui_adjust_win_heights): Update.
4616         (tui_win_info::make_invisible_and_set_new_height): Rename from
4617         make_invisible_and_set_new_height.
4618         * tui/tui-data.h (struct tui_win_info)
4619         <make_invisible_and_set_new_height>: New method.
4620
4621 2019-07-17  Tom Tromey  <tom@tromey.com>
4622
4623         * tui/tui.c: Update.
4624         * tui/tui-source.h (struct tui_source_window): Move from
4625         tui-data.h.
4626         * tui/tui-layout.c: Update.
4627         * tui/tui-disasm.c: Update.
4628         * tui/tui-data.h (struct tui_source_window): Move to
4629         tui-source.h.
4630
4631 2019-07-17  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4634         tui-data.h.
4635         * tui/tui-data.h (struct tui_disasm_window): Move to
4636         tui-disasm.h.
4637
4638 2019-07-17  Tom Tromey  <tom@tromey.com>
4639
4640         * tui/tui-regs.h (struct tui_data_item_window): Move from
4641         tui-data.h.
4642         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4643         * tui/tui-data.h (struct tui_data_item_window): Move to
4644         tui-regs.h.
4645         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4646
4647 2019-07-17  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui.c: Update.
4650         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4651         (tui_cmd_window::max_height): Move to tui-command.c.
4652         * tui/tui-layout.c: Update.
4653         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4654         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4655         tui-command.c.
4656         * tui/tui-command.h (struct tui_cmd_window): Move from
4657         tui-data.h.
4658         * tui/tui-command.c: Remove "structuring" comments.
4659         (tui_cmd_window::clear_detail)
4660         (tui_cmd_window::do_make_visible_with_new_height)
4661         (tui_cmd_window::max_height): Move from elsewhere.
4662
4663 2019-07-17  Tom Tromey  <tom@tromey.com>
4664
4665         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4666         Now static.
4667         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4668         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui.c: Update.
4673         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4674         tui-regs.c.
4675         * tui/tui-windata.h: Remove file.
4676         * tui/tui-windata.c: Remove file.
4677         * tui/tui-win.c (tui_data_window::set_new_height)
4678         (tui_data_window::do_make_visible_with_new_height): Move to
4679         tui-regs.c.
4680         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4681         * tui/tui-regs.c: Remove "structuring" comments.
4682         (tui_data_window::first_data_item_displayed)
4683         (tui_data_window::delete_data_content_windows)
4684         (tui_data_window::erase_data_content)
4685         (tui_data_window::display_all_data)
4686         (tui_data_window::refresh_all)
4687         (tui_data_window::do_scroll_vertical)
4688         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4689         (tui_data_window::do_make_visible_with_new_height)
4690         (tui_data_window::refresh_window): Move from elsewhere.
4691         (_initialize_tui_regs): Move to end of file.
4692         * tui/tui-layout.c: Update.
4693         * tui/tui-hooks.c: Update.
4694         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4695         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4696         tui-regs.c.
4697         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4698
4699 2019-07-17  Tom Tromey  <tom@tromey.com>
4700
4701         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4702         seen.
4703
4704 2019-07-17  Tom Tromey  <tom@tromey.com>
4705
4706         * tui/tui-win.c (tui_source_window_base::set_new_height)
4707         (tui_source_window_base::do_make_visible_with_new_height): Use
4708         m_has_locator field directly.
4709         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4710         method.
4711         (struct tui_source_window_base) <has_locator>: Likewise.
4712
4713 2019-07-17  Tom Tromey  <tom@tromey.com>
4714
4715         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4716         Don't declare.
4717         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4718         Remove.
4719         * tui/tui-win.c (tui_source_window_base::set_new_height)
4720         (tui_source_window_base::set_new_height)
4721         (make_invisible_and_set_new_height)
4722         (tui_source_window_base::do_make_visible_with_new_height)
4723         (tui_source_window_base::do_make_visible_with_new_height):
4724         Update.
4725         * tui/tui-layout.c (show_source_disasm_command, show_data)
4726         (show_source_or_disasm_and_command): Update.
4727         * tui/tui-layout.c (show_layout): Update.
4728
4729 2019-07-17  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-layout.c (make_data_window): Remove.
4732         (show_data): Unify creation and re-initialization cases.
4733
4734 2019-07-17  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-layout.c (make_source_window, make_disasm_window):
4737         Remove.
4738         (show_data): Unify creation and re-initialization cases.
4739
4740 2019-07-17  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-layout.c (make_command_window): Remove.
4743         (show_source_disasm_command, show_source_or_disasm_and_command):
4744         Unify creation and re-initialization cases.
4745
4746 2019-07-17  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4749         creation and re-initialization cases.
4750
4751 2019-07-17  Tom Tromey  <tom@tromey.com>
4752
4753         * tui/tui-regs.c (tui_get_register): Return void.
4754
4755 2019-07-17  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4758         Simplify.
4759
4760 2019-07-17  Tom Tromey  <tom@tromey.com>
4761
4762         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4763         resetting.
4764
4765 2019-07-17  Tom Tromey  <tom@tromey.com>
4766
4767         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4768         * tui/tui-regs.c (tui_reg_layout): New function.
4769         (tui_show_registers, tui_reg_command): Use it.
4770         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4771         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4772         parameters.
4773         (tui_layout_command): Remove.
4774
4775 2019-07-17  Tom Tromey  <tom@tromey.com>
4776
4777         * tui/tui-layout.h (tui/tui-layout): Return void.
4778         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4779
4780 2019-07-17  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui-layout.c (show_source_disasm_command, show_data):
4783         Update.
4784         (reset_locator): Remove.
4785         (show_source_or_disasm_and_command): Update.
4786
4787 2019-07-17  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-source.c (tui_source_window_base::reset): Remove
4790         win_type parameter.
4791         * tui/tui-layout.c (make_command_window, make_source_window)
4792         (make_disasm_window, make_data_window)
4793         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4794         (reset_locator, show_source_or_disasm_and_command): Update.
4795         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4796         win_type parameter.
4797         (struct tui_source_window_base) <reset>: Likewise.
4798
4799 2019-07-17  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-layout.c (show_source_disasm_command): Use
4802         reset_locator.
4803         (reset_locator): New function.
4804         (init_and_make_win): Remove.
4805         (show_source_or_disasm_and_command): Use reset_locator.
4806
4807 2019-07-17  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4810         condition.
4811         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4812         Remove condition.
4813         * tui/tui-source.c (tui_source_window_base::reset): New method.
4814         * tui/tui-layout.c (make_command_window): Don't call
4815         init_and_make_win.
4816         (make_source_window, make_disasm_window): Don't call
4817         make_source_or_disasm_window.
4818         (make_data_window): Don't call init_and_make_win.  Change calling
4819         convention.
4820         (show_source_disasm_command, show_data): Simplify.
4821         (make_source_or_disasm_window): Remove.
4822         (show_source_or_disasm_and_command): Simplify.
4823         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4824         (struct tui_source_window_base) <reset>: Likewise.
4825         <execution_info>: Remove initializer.
4826         * tui/tui-data.c (tui_source_window_base): Initialize
4827         execution_info.
4828
4829 2019-07-17  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4832         variable.
4833
4834 2019-07-17  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui.c (tui_rl_other_window): Update.
4837         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4838         superclass method first.  Always iterate over regs_content.
4839         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4840         method.
4841         * tui/tui-win.c (tui_set_focus_command): Update.
4842
4843 2019-07-17  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-win.c (tui_set_focus_command): Rename from
4846         tui_set_focus.  Call tui_enable.
4847         (tui_set_focus_command): Remove.
4848
4849 2019-07-17  Tom Tromey  <tom@tromey.com>
4850
4851         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4852         refresh_window.
4853         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4854         touchwin.
4855         (tui_data_window::refresh_window): Call refresh_window on data
4856         items.  Always call superclass refresh_window.
4857         (tui_win_info::refresh): Remove.
4858         (tui_source_window_base::refresh_window): Update.
4859         (tui_refresh_all): Update.
4860         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4861         refresh_window.
4862         (show_source_or_disasm_and_command): Likewise.
4863         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4864         (struct tui_source_window_base) <refresh>: Likewise.
4865
4866 2019-07-17  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui-winsource.c (tui_clear_source_content)
4869         (tui_show_source_content): Update.
4870         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4871         whether content is empty.
4872         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4873         Remove.
4874
4875 2019-07-17  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4878         window's contents.
4879         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4880         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4881
4882 2019-07-17  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4885         (struct tui_data_item_window): Update.
4886
4887 2019-07-17  Tom Tromey  <tom@tromey.com>
4888
4889         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4890         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4891         defines.
4892
4893 2019-07-17  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-winsource.h (tui_erase_source_content)
4896         (tui_clear_source_content): Remove "display_prompt" parameter.
4897         * tui/tui-winsource.c (tui_update_source_window_as_is)
4898         (tui_update_source_windows_with_addr): Update.
4899         (tui_clear_source_content): Remove "display_prompt" parameter.
4900         (tui_erase_source_content): Likewise.  Simplify.
4901         (tui_show_source_content): Update.
4902         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4903         * tui/tui-stack.c (tui_show_frame_info): Update.
4904         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4905         Remove defines.
4906
4907 2019-07-17  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4910         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4911         parameter.
4912         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4913         parameter.
4914
4915 2019-07-17  Tom Tromey  <tom@tromey.com>
4916
4917         * tui/tui-winsource.c (tui_clear_source_content)
4918         (tui_show_source_content, tui_show_exec_info_content)
4919         (tui_clear_exec_info_content): Update.
4920         * tui/tui-stack.c (tui_show_locator_content): Update.
4921         (tui_show_frame_info): Update.
4922         * tui/tui-source.h (tui_source_window): Don't declare.
4923         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4924         from tui_source_is_displayed.
4925         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4926         Remove field.
4927         (struct tui_source_window_base) <content_in_use>: New field.  Now
4928         bool.
4929         (struct tui_source_window) <showing_source_p>: New method.
4930         (TUI_SRC_WIN): Change cast.
4931         * tui/tui-data.c (tui_initialize_static_data): Update.
4932
4933 2019-07-17  Tom Tromey  <tom@tromey.com>
4934
4935         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4936         location_matches_p.
4937         * tui/tui-source.c (tui_source_window::location_matches_p): New
4938         method.
4939         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4940         method.
4941         * tui/tui-data.h (struct tui_source_window_base)
4942         <location_matches_p>: New method.
4943         (struct tui_source_window, struct tui_disasm_window)
4944         <location_matches_p>: Likewise.
4945
4946 2019-07-17  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-win.c (tui_set_win_height_command): Rename from
4949         tui_set_win_height.
4950         (tui_set_win_height_command): Remove.
4951
4952 2019-07-17  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-source.c (tui_source_window): New constructor.  Add
4955         observer.
4956         (~tui_source_window): New destructor.
4957         (tui_source_window::style_changed): New method.
4958         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4959         (tui_attach_detach_observers): Update.
4960         * tui/tui-data.h (struct tui_source_window): Make constructor not
4961         inline.  Add destructor.
4962         (struct tui_source_window) <style_changed>: New method.
4963         <m_observable>: New member.
4964
4965 2019-07-17  Tom Tromey  <tom@tromey.com>
4966
4967         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4968         * tui/tui-win.c (tui_resize_all): Fix typo.
4969
4970 2019-07-17  Tom Tromey  <tom@tromey.com>
4971
4972         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4973         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4974         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4975         * tui/tui-win.c (window_name_completer): Use foreach.
4976         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4977         (update_tab_width): Likewise.
4978         * tui/tui-layout.c (show_layout): Update.
4979         * tui/tui-data.h (class tui_window_iterator): New.
4980         (struct all_tui_windows): New.
4981         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4982
4983 2019-07-17  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4986         parameter.  Don't reference globals.
4987         (tui_reg_command): Update.
4988
4989 2019-07-17  Tom Tromey  <tom@tromey.com>
4990
4991         * tui/tui-regs.c (tui_show_registers): Simplify.
4992
4993 2019-07-17  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-regs.c (tui_show_registers): Update.
4996         (tui_show_register_group): Add win_info parameter.
4997
4998 2019-07-17  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5001         Rename from tui_display_reg_element_at_line.
5002         (tui_data_window::display_registers_from_line): Update.
5003         * tui/tui-data.h (struct tui_data_window)
5004         <display_reg_element_at_line>: New method.
5005
5006 2019-07-17  Tom Tromey  <tom@tromey.com>
5007
5008         * tui/tui-regs.h (tui_display_registers_from)
5009         (tui_display_registers_from_line): Don't declare.
5010         * tui/tui-windata.c (tui_data_window::display_all_data)
5011         (tui_data_window::refresh_all)
5012         (tui_data_window::do_scroll_vertical): Update.
5013         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5014         from tui_display_registers_from.
5015         (tui_display_reg_element_at_line): Update.
5016         (tui_data_window::display_registers_from_line): Rename from
5017         tui_display_registers_from_line.
5018         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5019         display_registers_from_line>: New methods.
5020
5021 2019-07-17  Tom Tromey  <tom@tromey.com>
5022
5023         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5024         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5025         from tui_erase_data_content.
5026         (tui_data_window::display_all_data)
5027         (tui_data_window::refresh_all)
5028         (tui_data_window::do_scroll_vertical): Update.
5029         * tui/tui-regs.c (tui_show_registers): Update.
5030         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5031         New method.
5032
5033 2019-07-17  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5036         declare.
5037         * tui/tui-windata.c
5038         (tui_data_window::delete_data_content_windows): Rename from
5039         tui_delete_data_content_windows.
5040         (tui_data_window::display_all_data)
5041         (tui_data_window::do_scroll_vertical): Update.
5042         * tui/tui-data.h (struct tui_data_window)
5043         <delete_data_content_windows>: New method.
5044
5045 2019-07-17  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5048         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5049
5050 2019-07-17  Tom Tromey  <tom@tromey.com>
5051
5052         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5053         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5054         from tui_display_all_data.
5055         * tui/tui-win.c
5056         (tui_data_window::do_make_visible_with_new_height): Update.
5057         * tui/tui-regs.c (tui_show_registers): Update.
5058         * tui/tui-layout.c (tui_set_layout): Update.
5059         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5060         method.
5061
5062 2019-07-17  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5065         * tui/tui-windata.c (tui_display_data_from): Remove.
5066         (tui_data_window::refresh_all): Update.
5067
5068 2019-07-17  Tom Tromey  <tom@tromey.com>
5069
5070         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5071         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5072         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5073         tui_display_registers_from_line.
5074         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5075         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5076         "force_display" parameter.
5077
5078 2019-07-17  Tom Tromey  <tom@tromey.com>
5079
5080         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5081         declare.
5082         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5083         Rename from tui_first_reg_element_no_inline.
5084         (tui_display_reg_element_at_line)
5085         (tui_display_registers_from_line): Update.
5086         * tui/tui-data.h (struct tui_data_window)
5087         <first_reg_element_no_inline>: New method.
5088
5089 2019-07-17  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui-windata.c (tui_display_data_from)
5092         (tui_data_window::do_scroll_vertical): Update.
5093         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5094         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5095         Rename from tui_line_from_reg_element_no.
5096         (tui_display_registers_from_line): Update.
5097         * tui/tui-data.h (struct tui_data_window)
5098         <line_from_reg_element_no>: New method.
5099
5100 2019-07-17  Tom Tromey  <tom@tromey.com>
5101
5102         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5103         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5104         tui_last_regs_line_no.
5105         (tui_display_reg_element_at_line)
5106         (tui_display_registers_from_line): Update.
5107         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5108         method.
5109
5110 2019-07-17  Tom Tromey  <tom@tromey.com>
5111
5112         PR tui/24722:
5113         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5114         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5115         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5116         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5117         (tui_update_breakpoint_info): Likewise.
5118         * tui/tui-hooks.c (tui_event_create_breakpoint)
5119         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5120         Update.
5121
5122 2019-07-17  Tom Tromey  <tom@tromey.com>
5123
5124         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5125
5126 2019-07-17  Tom Tromey  <tom@tromey.com>
5127
5128         * tui/tui-winsource.c (tui_update_source_window_as_is)
5129         (tui_update_source_windows_with_addr): Update.
5130         * tui/tui-source.h (tui_set_source_content)
5131         (tui_show_symtab_source): Add "win_info" parameter.
5132         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5133         parameter.
5134         (tui_show_symtab_source): Likewise.
5135
5136 2019-07-17  Tom Tromey  <tom@tromey.com>
5137
5138         * tui/tui-wingeneral.c
5139         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5140
5141 2019-07-17  Tom Tromey  <tom@tromey.com>
5142
5143         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5144         (struct tui_cmd_window) <can_scroll>: New method.
5145         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5146         method.
5147
5148 2019-07-17  Tom Tromey  <tromey@adacore.com>
5149
5150         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5151         do_field_signed>: Rename.  Change type of "value".
5152         * ui-out.c (ui_out::field_signed): Rename from field_int.
5153         Change type of "value".
5154         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5155         type of "value".
5156         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5157         do_field_int.  Change type of "value".
5158         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5159         do_field_int.  Change type of "value".
5160         * tracepoint.c (trace_status_mi, tfind_1)
5161         (print_one_static_tracepoint_marker): Update.
5162         * thread.c (print_thread_info_1, print_selected_thread_frame):
5163         Update.
5164         * stack.c (print_frame, print_frame_info): Update.
5165         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5166         Update.
5167         * source.c (print_source_lines_base): Update.
5168         * skip.c (info_skip_command): Update.
5169         * record-btrace.c (btrace_ui_out_decode_error)
5170         (btrace_call_history_src_line): Update.
5171         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5172         Update.
5173         * progspace.c (print_program_space): Update.
5174         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5175         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5176         do_field_int.  Change type of "value".
5177         * mi/mi-out.c (mi_ui_out::do_table_begin)
5178         (mi_ui_out::do_table_header): Update.
5179         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5180         type of "value".
5181         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5182         (mi_cmd_data_list_changed_registers, output_register)
5183         (mi_cmd_data_read_memory, mi_load_progress)
5184         (mi_cmd_trace_frame_collected): Update.
5185         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5186         Update.
5187         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5188         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5189         (mi_cmd_var_list_children, varobj_update_one): Update.
5190         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5191         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5193         * inferior.c (print_inferior): Update.
5194         * gdb_bfd.c (print_one_bfd): Update.
5195         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5196         Update.
5197         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5198         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5199         do_field_int.  Change type of "value".
5200         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5201         do_field_int.  Change type of "value".
5202         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5203         (print_one_breakpoint_location, print_it_catch_fork)
5204         (print_one_catch_fork, print_it_catch_vfork)
5205         (print_one_catch_vfork, print_it_catch_solib)
5206         (print_it_catch_exec, print_it_ranged_breakpoint)
5207         (print_mention_watchpoint, print_mention_masked_watchpoint)
5208         (bkpt_print_it, update_static_tracepoint): Update.
5209         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5210         * break-catch-syscall.c (print_it_catch_syscall): Update.
5211         * ada-tasks.c (print_ada_task_info): Update.
5212         * ada-lang.c (print_it_exception, print_mention_exception):
5213         Update.
5214
5215 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5216
5217         PR breakpoints/24541
5218         * gdbarch.c: Regenerate.
5219         * gdbarch.h: Regenerate.
5220         * gdbarch.sh: Adjust return type and parameter types for
5221         'stap_adjust_register'.
5222         (i386_stap_adjust_register): Adjust signature and return new
5223         register name.
5224         * stap-probe.c (stap_parse_register_operand): Adjust use of
5225         'gdbarch_stap_adjust_register'.
5226
5227 2019-07-17  Tom Tromey  <tromey@adacore.com>
5228
5229         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5230         declare VEC.
5231         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5232         std::vector.
5233         (struct s390_process_info): Add initializers.
5234         (s390_add_process): Use new.
5235         (s390_linux_nat_target::low_forget_process): Use delete.
5236         (s390_linux_nat_target::low_new_fork)
5237         (s390_linux_nat_target::stopped_by_watchpoint)
5238         (s390_linux_nat_target::low_prepare_to_resume)
5239         (s390_linux_nat_target::insert_watchpoint)
5240         (s390_linux_nat_target::insert_hw_breakpoint)
5241         (s390_linux_nat_target::remove_watchpoint)
5242         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5243
5244 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5245
5246         * aarch64-fbsd-nat.c: Include regcache.h.
5247         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5248         argument.
5249         (aarch64_fbsd_nat_target::fetch_registers)
5250         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5251         variable.
5252         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5253
5254 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5255
5256         * fbsd-nat.c: Include gdbarch.h.
5257
5258 2019-07-15  Tom Tromey  <tromey@adacore.com>
5259
5260         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5261
5262 2019-07-15  Tom Tromey  <tromey@adacore.com>
5263
5264         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5265         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5266         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5267         * cli-out.c (cli_ui_out::do_field_int): New method.
5268         * ui-out.c (ui_out::field_unsigned): New method.
5269         * symfile.c (generic_load): Use field_unsigned.
5270         (print_transfer_performance): Likewise.
5271         * record-btrace.c (ui_out_field_uint): Remove.
5272         (btrace_call_history_insn_range, btrace_call_history): Use
5273         field_unsigned.
5274         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5275         field_unsigned.
5276         * ui-out.h (class ui_out) <field_unsigned>: New method.
5277         <do_field_unsigned>: Likewise.
5278
5279 2019-07-15  Tom Tromey  <tromey@adacore.com>
5280
5281         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5282         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5283         * target.c (flash_erase_command): Use field_string.
5284         * infrun.c (print_signal_received_reason): Use field_string.
5285         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5286         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5287         field_string.
5288         * ada-tasks.c (print_ada_task_info): Use field_string.
5289
5290 2019-07-15  Tom Tromey  <tromey@adacore.com>
5291
5292         * target.c (flash_erase_command): Use field_core_addr.
5293         * symfile.c (generic_load): Use field_core_addr.
5294         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5295         Use field_core_addr.
5296         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5297         field_core_addr.
5298
5299 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5302         value if its desired type is smaller than a CORE_ADDR and signed.
5303
5304 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5307         of changes to field names, and use new is_reference field to
5308         decide if a property is a reference or not.
5309         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5310         field.
5311         (struct dwarf2_property_baton): Update header comment, rename
5312         'referenced_type' to 'property_type' and update comments.
5313         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5314         default property type, store in property baton, update to take
5315         accound of renamed field.
5316         (read_func_scope): Update call to attr_to_dynamic_prop.
5317         (read_array_type): Likewise.
5318         (dwarf2_per_cu_addr_sized_int_type): New function.
5319         (read_subrange_index_type): Move type finding code to
5320         dwarf2_per_cu_addr_sized_int_type.
5321         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5322         (dwarf2_per_cu_addr_type): New function.
5323         (set_die_type): Update calls to attr_to_dynamic_prop.
5324
5325 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5326
5327         * dwarf2read.c (read_subrange_index_type): New function.
5328         (read_subrange_type): Move code into new function and call it.
5329         * gdbtypes.c (create_range_type): Add some asserts.
5330
5331 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5334         update return statements.
5335         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5336         declaration, and update comment to match.
5337         * gdbtypes.c (resolve_dynamic_array): Update call to
5338         dwarf2_evaluate_property to match new return type.
5339
5340 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * valarith.c (value_subscripted_rvalue): Change lowerbound
5343         parameter type from int to LONGEST.
5344         * value.h (value_subscripted_rvalue): Likewise in declaration.
5345
5346 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * cli/cli-utils.c (info_print_command_completer): New function.
5349         * cli/cli-utils.h: Add 'completer.h' include, and forward
5350         declaration for 'struct cmd_list_element'.
5351         (info_print_command_completer): Declare.
5352         * stack.c (_initialize_stack): Add completer for 'info locals' and
5353         'info args'.
5354         * symtab.c (_initialize_symtab): Add completer for 'info
5355         variables' and 'info functions'.
5356         * NEWS: Mention completion for additional info commands.
5357
5358 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5359
5360         * cli/cli-utils.c (extract_info_print_args): Delete.
5361         (extract_arg_maybe_quoted): Delete.
5362         (info_print_options_defs): New variable.
5363         (make_info_print_options_def_group): New function.
5364         (extract_info_print_options): Define new function.
5365         * cli/cli-utils.h (extract_info_print_args): Delete.
5366         (struct info_print_options): New structure.
5367         (extract_info_print_options): Declare new function.
5368         * stack.c (info_locals_command): Update to use new
5369         extract_info_print_options, also add a header comment.
5370         (info_args_command): Likewise.
5371         * symtab.c (info_variables_command): Likewise.
5372         (info_functions_command): Likewise.
5373
5374 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5375
5376         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5377         to extract string arguments.
5378         * common/common-utils.c (extract_string_maybe_quoted): New function.
5379         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5380
5381 2019-07-11  Tom Tromey  <tromey@adacore.com>
5382
5383         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5384         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5385         * top.h (gdbinit): Don't declare.
5386         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5387         into...
5388         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5389         * top.c (gdb_init): Don't call init_cli_cmds.
5390         (gdbinit): Remove.
5391         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5392
5393 2019-07-11  Tom Tromey  <tromey@adacore.com>
5394
5395         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5396         after it has been moved.
5397
5398 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5399
5400         * valops.c (value_must_coerce_to_target): Change return type to
5401         bool.
5402         * value.h (value_must_coerce_to_target): Likewise.
5403
5404 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5405
5406         * breakpoint.c (is_hardware_watchpoint): Remove
5407         forward-declaration.
5408         (is_masked_watchpoint): Change return type to bool.
5409         (is_tracepoint): Likewise.
5410         (is_breakpoint): Likewise.
5411         (is_hardware_watchpoint): Likewise.
5412         (is_watchpoint): Likewise.
5413         (is_no_memory_software_watchpoint): Likewise.
5414         (is_catchpoint): Likewise.
5415         (breakpoint_1): Make FILTER parameter's return type bool.
5416         is_masked_watchpoint): Change return type to bool.
5417         (save_breakpoints): Make FILTER parameter's return type bool.
5418         * breakpoint.h (is_breakpoint): Change return type to bool.
5419         (is_watchpoint): Likewise.
5420         (is_catchpoint): Likewise.
5421         (is_tracepoint): Likewise.
5422
5423 2019-07-10  Tom Tromey  <tom@tromey.com>
5424
5425         * defs.h: Don't include gdbarch.h.
5426         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5427         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5428         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5429         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5430         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5431         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5432         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5433         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5434         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5435         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5436         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5437         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5438         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5439         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5440         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5441         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5442         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5443         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5444         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5445         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5446         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5447         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5448         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5449         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5450         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5451         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5452         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5453
5454 2019-07-10  Tom Tromey  <tromey@adacore.com>
5455
5456         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5457         * breakpoint.c (init_ada_exception_breakpoint): Register as
5458         bp_catchpoint.
5459         (print_one_breakpoint_location, print_one_breakpoint): Use
5460         is_ada_exception_catchpoint.
5461         * ada-lang.c (class ada_catchpoint_location): Pass
5462         bp_loc_software_breakpoint to bp_location constructor.
5463         (is_ada_exception_catchpoint): New function.
5464
5465 2019-07-10  Tom Tromey  <tromey@adacore.com>
5466
5467         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5468         VEC.
5469         (struct arm_exidx_entry): New method operator<.
5470         (struct arm_exidx_data) <section_maps>: Change type.
5471         (arm_exidx_data_free): Remove.
5472         (arm_exidx_data_key): Change type.  Move lower.
5473         (arm_exidx_new_objfile): Update.
5474         (arm_compare_exidx_entries): Remove.
5475         (arm_find_exidx_entry, _initialize_arm_tdep)
5476
5477 2019-07-10  Tom Tromey  <tromey@adacore.com>
5478
5479         * solib-spu.c (ocl_program_data_key): Change type.
5480         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5481         Update.
5482
5483 2019-07-10  Tom Tromey  <tromey@adacore.com>
5484
5485         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5486         (struct solib_aix_inferior_data) <library_list>: Change type.
5487         (solib_aix_inferior_data_handle): Change type.
5488         (get_solib_aix_inferior_data): Update.
5489         (solib_aix_free_library_list): Remove.
5490         (library_list_start_library): Update.
5491         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5492         return type.
5493         (solib_aix_get_library_list)
5494         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5495         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5496
5497 2019-07-10  Tom Tromey  <tromey@adacore.com>
5498
5499         * solib-dsbt.c (struct dsbt_info): Add initializers.
5500         (solib_dsbt_pspace_data): Change type.
5501         (dsbt_pspace_data_cleanup): Remove.
5502         (get_dsbt_info, _initialize_dsbt_solib): Update.
5503
5504 2019-07-10  Tom Tromey  <tromey@adacore.com>
5505
5506         * spu-tdep.c (spu_overlay_data): Change type.
5507         (spu_get_overlay_table, spu_overlay_new_objfile)
5508         (_initialize_spu_tdep): Update.
5509
5510 2019-07-10  Tom Tromey  <tromey@adacore.com>
5511
5512         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5513         destructor.
5514         (dbx_objfile_data_key): Change type and declare later.
5515         (DBX_SYMFILE_INFO): Rewrite.
5516         * dbxread.c (dbx_objfile_data_key): Change type.
5517         (dbx_symfile_init): Update.
5518         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5519         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5520         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5521
5522 2019-07-10  Tom Tromey  <tromey@adacore.com>
5523
5524         * jit.c (jit_program_space_key): Change type.  Move lower.
5525         (get_jit_program_space_data): Update.
5526         (jit_program_space_data_cleanup): Remove.
5527         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5528         Update.
5529         (struct jit_program_space_data): Add initializers.
5530
5531 2019-07-10  Tom Tromey  <tromey@adacore.com>
5532
5533         * solib-darwin.c (struct darwin_info): Add initializers.
5534         (solib_darwin_pspace_data): Change type.
5535         (darwin_pspace_data_cleanup): Remove.
5536         (get_darwin_info, _initialize_darwin_solib): Update.
5537
5538 2019-07-10  Tom Tromey  <tromey@adacore.com>
5539
5540         * remote-sim.c (struct sim_inferior_data): Add initializers,
5541         constructor, and destructor.
5542         (sim_inferior_data_key): Change type.  Move lower.
5543         (check_for_duplicate_sim_descriptor): Update.
5544         (get_sim_inferior_data): Use new.  Update.
5545         (~sim_inferior_data_cleanup): Rename from
5546         sim_inferior_data_cleanup.  Simplify.
5547         (gdbsim_close_inferior, simulator_command)
5548         (sim_command_completer, _initialize_remote_sim): Update.
5549         (next_pid, INITIAL_PID): Move earlier.
5550
5551 2019-07-10  Tom Tromey  <tromey@adacore.com>
5552
5553         * python/python-internal.h (create_thread_object): Return
5554         gdbpy_ref.
5555         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5556         * python/py-inferior.c (struct threadlist_entry): Add
5557         constructor.
5558         <thread_obj>: Now a gdbpy_ref.
5559         (thread_to_thread_object): Update.
5560         (add_thread_object): Use new.
5561         (delete_thread_object): Use delete.
5562         (infpy_threads): Update.
5563         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5564         GIL.
5565
5566 2019-07-10  Tom Tromey  <tromey@adacore.com>
5567
5568         * valops.c (value_cast): Specialize error message for Ada.
5569
5570 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5571
5572         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5573
5574 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5575
5576         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5577         bpstat_should_step): Return bool, adjust comments.
5578         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5579         bpstat_should_step): Likewise.
5580
5581 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5582
5583         * features/Makefile: Use feature target descriptions for Arm.
5584         * features/arm/arm-core.c: Generate new file.
5585         * features/arm/arm-fpa.c: Likewise.
5586         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5587         * features/arm/arm-m-profile.c: Likewise.
5588         * features/arm/arm-vfpv2.c: Likewise.
5589         * features/arm/arm-vfpv3.c: Likewise.
5590         * features/arm/xscale-iwmmxt.c: Likewise.
5591         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5592
5593 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5594
5595         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5596         ptrace earlier.
5597
5598 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5599
5600         * features/aarch64-pauth.c: Regenerate.
5601
5602 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5603
5604         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5605         bool.
5606         (bpstat_what): Use false instead of 0.
5607
5608 2019-07-09  Pedro Alves  <palves@redhat.com>
5609
5610         * break-catch-throw.c (is_exception_catchpoint): New.
5611         * breakpoint.c (print_one_breakpoint_location): New parameter
5612         'raw_loc'.  Handle it.  Use
5613         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5614         looking at the breakpoint's type.
5615         (print_one_breakpoint): If handling "maint info breakpoints", also
5616         print locations of exception catchpoints.
5617         * breakpoint.h (is_exception_catchpoint): Declare.
5618
5619 2019-07-09  Pedro Alves  <palves@redhat.com>
5620
5621         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5622         "addr" field.
5623         (allocate_location_exception_catchpoint): New.
5624         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5625         (initialize_throw_catchpoint_ops): Install
5626         allocate_location_exception_catchpoint as allocate_location
5627         method.
5628         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5629         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5630         bp_loc_other.
5631         (breakpoint_address_is_meaningful): Delete.
5632         (bl_address_is_meaningful): New.
5633         (breakpoint_locations_match): Adjust comment.
5634         (bp_location_from_bp_type): New, factored out of...
5635         (bp_location::bp_location(breakpoint *)): ... this.
5636         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5637         factored out of...
5638         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5639         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5640         breakpoint_address_is_meaningful.
5641         (bp_locations_compare): Adjust comment.
5642         (update_global_location_list): Use bl_address_is_meaningful
5643         instead of breakpoint_address_is_meaningful.
5644         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5645         explicit.
5646         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5647         * python/py-breakpoint.c (bppy_get_location): No longer check
5648         whether location is null.
5649
5650 2019-07-09  Pedro Alves  <palves@redhat.com>
5651
5652         PR c++/15468
5653         * breakpoint.c (print_one_breakpoint_location): Remove
5654         single-location assert.
5655
5656 2019-07-09  Tom Tromey  <tom@tromey.com>
5657
5658         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5659         * configure: Rebuild.
5660         * configure.ac: Change common to gdbsupport.
5661         * gdbsupport: Rename from common.
5662         * acinclude.m4: Change common to gdbsupport.
5663         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5664         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5665         gdbsupport.
5666         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5667         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5668         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5669         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5670         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5671         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5672         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5673         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5674         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5675         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5676         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5677         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5678         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5679         coff-pe-read.c, command.h, compile/compile-c-support.c,
5680         compile/compile-c.h, compile/compile-cplus-symbols.c,
5681         compile/compile-cplus-types.c, compile/compile-cplus.h,
5682         compile/compile-loc2c.c, compile/compile.c, completer.c,
5683         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5684         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5685         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5686         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5687         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5688         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5689         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5690         features/aarch64-core.c, features/aarch64-fpu.c,
5691         features/aarch64-pauth.c, features/aarch64-sve.c,
5692         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5693         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5694         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5695         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5696         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5697         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5698         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5699         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5700         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5701         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5702         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5703         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5704         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5705         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5706         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5707         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5708         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5709         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5710         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5711         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5712         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5713         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5714         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5715         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5716         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5717         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5718         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5719         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5720         minsyms.c, mips-linux-tdep.c, namespace.h,
5721         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5722         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5723         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5724         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5725         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5726         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5727         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5728         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5729         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5730         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5731         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5732         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5733         procfs.c, producer.c, progspace.h, psymtab.h,
5734         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5735         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5736         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5737         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5738         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5739         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5740         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5741         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5742         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5743         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5744         target-memory.c, target.c, target.h, target/waitstatus.c,
5745         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5746         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5747         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5748         unittests/array-view-selftests.c,
5749         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5750         unittests/common-utils-selftests.c,
5751         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5752         unittests/format_pieces-selftests.c,
5753         unittests/function-view-selftests.c,
5754         unittests/lookup_name_info-selftests.c,
5755         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5756         unittests/mkdir-recursive-selftests.c,
5757         unittests/observable-selftests.c,
5758         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5759         unittests/parse-connection-spec-selftests.c,
5760         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5761         unittests/scoped_fd-selftests.c,
5762         unittests/scoped_mmap-selftests.c,
5763         unittests/scoped_restore-selftests.c,
5764         unittests/string_view-selftests.c, unittests/style-selftests.c,
5765         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5766         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5767         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5768         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5769         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5770         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5771
5772 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5775         bool value.
5776         (decode_digits_ordinary): Set explicit_line field in sal.
5777         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5778         symtab_and_line that was set on an explicit line number in
5779         assembler code.  Do always update the recorded symtab and line if
5780         we do skip the prologue.
5781
5782 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * breakpoint.c (set_breakpoint_location_function): Remove
5785         explicit_loc parameter.
5786         (momentary_breakpoint_from_master): Update call to
5787         set_breakpoint_location_function.
5788         (add_location_to_breakpoint): Likewise.
5789
5790 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5791
5792         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5793         required features based on default bfd type when no specific bfd
5794         is present.
5795
5796 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5797
5798         * NEWS: Mention that GDB printf and eval commands can now print
5799         C-style and Ada-style convenience var strings without
5800         calling the inferior.
5801         * printcmd.c (printf_c_string): Locally print GDB internal var
5802         instead of transiting via the inferior.
5803         (printf_wide_c_string): Likewise.
5804
5805 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5806
5807         PR breakpoints/25011
5808         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5809
5810 2019-07-04  Tom Tromey  <tom@tromey.com>
5811
5812         PR tui/24724:
5813         * tui/tui-winsource.c (tui_clear_source_content): Update.
5814         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5815         (tui_update_breakpoint_info): Update.
5816         (tui_set_exec_info_content): Update.
5817         * tui/tui-source.c (tui_set_source_content_nil): Update.
5818         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5819         has_break.
5820         * tui/tui-data.h (enum tui_bp_flag): New.
5821         (tui_bp_flags): New enum flags type.
5822         (struct tui_source_element) <break_mode>: Change type.  Rename
5823         from has_break.
5824         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5825         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5826         constants.
5827         * tui/tui-winsource.h: Fix comment.
5828
5829 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5830
5831         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5832         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5833         (store_fpregs_to_thread)
5834         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5835         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5836         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5837         (IWMMXT_REGS_SIZE): Add define.
5838         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5839         (fetch_vfp_regs, store_vfp_regs)
5840         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5841         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5842
5843 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5844
5845         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5846         defines.
5847         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5848         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5849         (ARM_INT_REGISTER_SIZE): ...to this.
5850         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5851         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5852         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5853         (arm_linux_collect_gregset, supply_nwfpe_register)
5854         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5855         defines.
5856         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5857         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5858         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5859         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5860         (arm_return_in_memory, arm_store_return_value)
5861         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5862         (arm_record_ld_st_multiple): Likewise.
5863         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5864         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5865
5866 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5867
5868         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5869         AARCH64_DISPLACED_MODIFIED_INSNS.
5870         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5871         (aarch64_displaced_step_copy_insn): Likewise.
5872         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5873         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5874         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5875         ARM_DISPLACED_MODIFIED_INSNS.
5876         * arm-tdep.c (arm_gdbarch_init): Likewise.
5877         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5878         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5879         (struct arm_displaced_step_closure): Use
5880         ARM_DISPLACED_MODIFIED_INSNS.
5881
5882 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5883
5884         * features/Makefile: Remove unused xml files.
5885         * features/aarch64.xml: Remove.
5886         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5887         * features/i386/amd64-avx-avx512.xml: Remove.
5888         * features/i386/amd64-avx-linux.xml: Remove.
5889         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5890         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5891         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5892         * features/i386/amd64-avx-mpx.xml: Remove.
5893         * features/i386/amd64-avx.xml: Remove.
5894         * features/i386/amd64-linux.xml: Remove.
5895         * features/i386/amd64-mpx-linux.xml: Remove.
5896         * features/i386/amd64-mpx.xml: Remove.
5897         * features/i386/amd64.xml: Remove.
5898         * features/i386/i386-avx-avx512-linux.xml: Remove.
5899         * features/i386/i386-avx-avx512.xml: Remove.
5900         * features/i386/i386-avx-linux.xml: Remove.
5901         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5902         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5903         * features/i386/i386-avx-mpx-linux.xml: Remove.
5904         * features/i386/i386-avx-mpx.xml: Remove.
5905         * features/i386/i386-avx.xml: Remove.
5906         * features/i386/i386-linux.xml: Remove.
5907         * features/i386/i386-mmx-linux.xml: Remove.
5908         * features/i386/i386-mmx.xml: Remove.
5909         * features/i386/i386-mpx-linux.xml: Remove.
5910         * features/i386/i386-mpx.xml: Remove.
5911         * features/i386/i386.xml: Remove.
5912         * features/i386/x32-avx-avx512-linux.xml: Remove.
5913         * features/i386/x32-avx-linux.xml: Remove.
5914         * features/i386/x32-linux.xml: Remove.
5915
5916 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5917
5918         * regformats/aarch64.dat: Remove.
5919         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5920         * regformats/i386/amd64-avx-linux.dat: Remove.
5921         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5922         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5923         * regformats/i386/amd64-linux.dat: Remove.
5924         * regformats/i386/amd64-mpx-linux.dat: Remove.
5925         * regformats/i386/amd64.dat: Remove.
5926         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5927         * regformats/i386/i386-avx-linux.dat: Remove.
5928         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5929         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5930         * regformats/i386/i386-linux.dat: Remove.
5931         * regformats/i386/i386-mmx-linux.dat: Remove.
5932         * regformats/i386/i386-mpx-linux.dat: Remove.
5933         * regformats/i386/i386.dat: Remove.
5934         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5935         * regformats/i386/x32-avx-linux.dat: Remove.
5936         * regformats/i386/x32-linux.dat: Remove.
5937
5938 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5939
5940         * aarch64-tdep.c: Remove xml self tests.
5941         * amd64-linux-tdep.c: Likewise.
5942         * amd64-tdep.c: Likewise.
5943         * i386-linux-tdep.c: Likewise.
5944         * i386-tdep.c: Likewise.
5945
5946 2019-07-03  Pedro Alves  <palves@redhat.com>
5947
5948         PR cli/24732
5949         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5950         (pipe_cmd_option_defs): New.
5951         (make_pipe_cmd_options_def_group): New.
5952         (pipe_command): Use gdb::option::process_options.
5953         (pipe_command_completer): New function.
5954         (_initialize_cli_cmds): Install completer for "pipe" command.
5955
5956 2019-07-03  Pedro Alves  <palves@redhat.com>
5957
5958         * cli/cli-option.c (union option_value) <string>: New field.
5959         (struct option_def_and_value): Add ctor, move ctor, dtor and
5960         use DISABLE_COPY_AND_ASSIGN.
5961         (option_def_and_value::clear_value): New.
5962         (parse_option, save_option_value_in_ctx, get_val_type_str)
5963         (add_setshow_cmds_for_options): Handle var_string.
5964         * cli-option.h (union option_def::var_address) <string>: New
5965         field.
5966         (struct string_option_def): New.
5967         * maint-test-options.c (struct test_options_opts): Add default
5968         ctor and use DISABLE_COPY_AND_ASSIGN.
5969         <string_opt>: New field.
5970         (test_options_opts::~test_options_opts): New.
5971         (test_options_opts::dump): Also dump "-string".
5972         (test_options_option_defs): Install "string.
5973
5974 2019-07-03  Pedro Alves  <palves@redhat.com>
5975
5976         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5977         option_value with a null enumeration.
5978         (complete_options): Save the option values in the context.
5979         (save_option_value_in_ctx): New, factored out from ...
5980         (process_options): ... here.
5981         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5982         of the function.
5983         * maint-test-options.c (test_options_opts::dump): New, factored
5984         out from ...
5985         (maintenance_test_options_command_mode): ... here.
5986         (maintenance_test_options_command_completion_result): Delete.
5987         (maintenance_test_options_command_completion_text): Update
5988         comment.
5989         (maintenance_show_test_options_completion_result): Change
5990         prototype.  Just print
5991         maintenance_test_options_command_completion_text.
5992         (save_completion_result): New.
5993         (maintenance_test_options_completer_mode): Pass options context to
5994         complete_options, and then save a dump.
5995         (_initialize_maint_test_options): Use add_cmd to install "maint
5996         show test-options-completion-result".
5997
5998 2019-07-03  Pedro Alves  <palves@redhat.com>
5999
6000         * NEWS (New commands): Mention "with" and "maint with".
6001         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6002         (with_command, with_command_completer): New.
6003         (pipe_command): Adjust to new repeat_previous
6004         interface.
6005         (_initialize_cli_cmds): Install the "with" command and its "w"
6006         alias.
6007         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6008         declarations.
6009         * cli/cli-setshow.c (parse_cli_var_uinteger)
6010         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6011         argument strings for all var_types.
6012         (get_setshow_command_value_string): New, factored out from ...
6013         (do_show_command): ... this.
6014         * cli/cli-setshow.h: Include <string>.
6015         (get_setshow_command_value_string): Declare.
6016         * command.h (repeat_previous): Now returns const char *.  Adjust
6017         comment.
6018         * maint.c: Include "cli/cli-cmds.h".
6019         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6020         (_initialize_maint_cmds): Register the "maintenance with" command.
6021         * top.c (repeat_previous): Move bits from pipe_command here:
6022         Return the saved command line, if any; error out if there's no
6023         command to relaunch.
6024
6025 2019-07-03  Pedro Alves  <palves@redhat.com>
6026
6027         * NEWS (New commands): Mention "maint set/show test-settings"
6028         instead of "maint test-settings".
6029         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6030         (maintenance_test_settings_set_list): Rename to ...
6031         (maintenance_set_test_settings_list): ... this.
6032         (maintenance_test_settings_show_list): Rename to  ...
6033         (maintenance_show_test_settings_list): ... this.
6034         (maintenance_test_settings_cmd): Delete.
6035         (maintenance_test_settings_set_cmd): ...
6036         (maintenance_set_test_settings_cmd): ... this.
6037         (maintenance_test_settings_show_cmd): ...
6038         (maintenance_show_test_settings_cmd): ... this.
6039         (maintenance_test_settings_show_value_cmd):
6040         (maintenance_show_test_settings_value_cmd): ... this.
6041         (_initialize_maint_test_settings): No longer install the "maint
6042         test-settings" prefix command.  Rename "maint test-settings set"
6043         to "maint set test-settings", and "maint test-settings show" to
6044         "maint show test-settings".  Adjust all subcommands.
6045
6046 2019-07-03  Pedro Alves  <palves@redhat.com>
6047
6048         * maint-test-settings.c: Fix file's intro comment.  Replace all
6049         references to "test-options" with references to "test-settings",
6050         in comments.
6051
6052 2019-07-03  Pedro Alves  <palves@redhat.com>
6053
6054         * maint-test-settings.c (maintenance_test_settings_xxx)
6055         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6056         New.
6057         (maintenance_test_settings_enums): Use them.
6058         (maintenance_test_settings_enum): Default to
6059         maintenance_test_settings_xxx.
6060         (_initialize_maint_test_settings): Initialize
6061         MAINTENANCE_TEST_SETTINGS_FILENAME.
6062
6063 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6064
6065         * breakpoint.h (remove_breakpoints_inf): Change return type to
6066         void, move function documentation here.
6067         * breakpoint.c (remove_breakpoints_inf): Change return type to
6068         void, move function documentation to header.
6069
6070 2019-07-02  Pedro Alves  <palves@redhat.com>
6071
6072         * NEWS (Completion improvements): Mention "info threads".
6073         * thread.c (struct info_threads_opts, info_threads_option_defs)
6074         (make_info_threads_options_def_group): New.
6075         (info_threads_command): Use gdb::option::process_options.
6076         (info_threads_command_completer): New.
6077         (_initialize_thread): Use gdb::option::build_help to build the
6078         help text for "info threads".
6079
6080 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6081
6082         * defs.h (generic_load): Move from here...
6083         * symfile.h (generic_load): ... to here.  Rename name parameter
6084         to args.
6085         * symfile.c (generic_load): Add comment.
6086
6087 2019-07-01  Tom Tromey  <tromey@adacore.com>
6088
6089         * dwarf2read.c
6090         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6091         declaration of without_params.  Fix formatting.
6092
6093 2019-07-01  Tom Tromey  <tromey@adacore.com>
6094
6095         * ada-exp.y (find_primitive_type): Update.
6096         * ada-lang.h (ada_lookup_symbol): Update.
6097         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6098         parameter.
6099         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6100
6101 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6102
6103         PR breakpoints/24541
6104         * gdbarch.c: Regenerate.
6105         * gdbarch.h: Regenerate.
6106         * gdbarch.sh: Add 'stap_adjust_register'.
6107         * i386-tdep.c: Include '<unordered_set>'.
6108         (i386_stap_adjust_register): New function.
6109         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6110         * stap-probe.c (stap_parse_register_operand): Call
6111         'gdbarch_stap_adjust_register'.
6112
6113 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6114
6115         PR python/24742
6116         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6117         * python/python.c (do_start_initialization): Use 'xmalloc'
6118         instead of 'PyMem_Malloc'.
6119
6120 2019-06-28  Tom Tromey  <tromey@adacore.com>
6121
6122         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6123         for Ada.
6124
6125 2019-06-27  Tom Tromey  <tromey@adacore.com>
6126
6127         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6128         objfile_key.
6129         (arm_find_mapping_symbol, arm_record_special_symbol)
6130         (_initialize_arm_tdep): Update.
6131         (arm_objfile_data_free): Remove.
6132
6133 2019-06-27  Tom Tromey  <tromey@adacore.com>
6134
6135         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6136         to cp_print_static_field.
6137
6138 2019-06-26  Tom Tromey  <tromey@adacore.com>
6139
6140         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6141         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6142         declare.
6143
6144 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6145
6146         * features/aarch64-core.c (create_feature_aarch64_core):
6147         Regenerate.
6148         * features/aarch64-core.xml: Add cpsr flags.
6149
6150 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6151
6152         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6153         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6154
6155 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6156
6157         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6158         field.
6159         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6160         use.
6161         (arm_record_special_symbol): Don't insert new symbol in sorted
6162         position, push it at the end.
6163
6164 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6165
6166         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6167         (arm_mapping_symbol_s): Remove.
6168         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6169         (arm_mapping_symbol_vec): New typedef.
6170         (struct arm_per_objfile): Add constructor.
6171         <section_maps>: Change type to
6172         std::unique_ptr<arm_mapping_symbol_vec[]>.
6173         (arm_compare_mapping_symbols): Remove.
6174         (arm_find_mapping_symbol): Adjust to section_maps type change.
6175         (arm_objfile_data_free): Call delete on arm_per_objfile.
6176         (arm_record_special_symbol): Adjust to section_maps type change.
6177         Allocate arm_per_objfile with new.
6178
6179 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6180
6181         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6182         with the command prefix.
6183
6184 2019-06-25  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6187         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6188
6189 2019-06-25  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6192         type.
6193         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6194         protected.
6195
6196 2019-06-25  Tom Tromey  <tom@tromey.com>
6197
6198         * tui/tui-winsource.c
6199         (tui_source_window_base::set_is_exec_point_at): Add check against
6200         LOA_ADDRESS.
6201
6202 2019-06-25  Tom Tromey  <tom@tromey.com>
6203
6204         * tui/tui-source.c (tui_set_source_content): Don't check before
6205         xfree.
6206         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6207
6208 2019-06-25  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui-winsource.h (tui_update_source_window_as_is)
6211         (tui_alloc_source_buffer, tui_line_is_displayed)
6212         (tui_addr_is_displayed): Change type of win_info.
6213         * tui/tui-winsource.c (tui_update_source_window_as_is)
6214         (tui_clear_source_content, tui_show_source_line)
6215         (tui_show_source_content, tui_source_window_base::refill)
6216         (tui_source_window_base::set_is_exec_point_at)
6217         (tui_source_window_base::set_is_exec_point_at)
6218         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6219         (tui_alloc_source_buffer, tui_line_is_displayed)
6220         (tui_addr_is_displayed): Change type of win_info.  Update.
6221         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6222         (tui_source_window_base::do_make_visible_with_new_height):
6223         Update.
6224         * tui/tui-source.c (tui_set_source_content)
6225         (tui_set_source_content_nil)
6226         (tui_source_window::do_scroll_vertical): Update.
6227         * tui/tui-layout.c (show_layout): Update.
6228         * tui/tui-disasm.c (tui_set_disassem_content)
6229         (tui_disasm_window::do_scroll_vertical): Update.
6230         * tui/tui-data.h (tui_win_content): Remove.
6231         (struct tui_gen_win_info) <content, content_size>: Remove.
6232         (struct tui_source_element): Add initializers and destructor.
6233         (union tui_which_element, struct tui_win_element): Remove.
6234         (struct tui_source_window_base) <content>: New field.
6235         (struct tui_data_window): Remove destructor.
6236         (tui_alloc_content, tui_free_win_content)
6237         (tui_free_all_source_wins_content): Don't declare.
6238         * tui/tui-data.c (tui_initialize_static_data): Update.
6239         (init_content_element, tui_alloc_content): Remove.
6240         (~tui_gen_win_info): Update.
6241         (~tui_data_window, tui_free_all_source_wins_content)
6242         (tui_free_win_content, free_content, free_content_elements):
6243         Remove.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-winsource.h (tui_clear_source_content)
6248         (tui_erase_source_content, tui_show_source_content): Change type
6249         of win_info.
6250         * tui/tui-winsource.c (tui_clear_source_content)
6251         (tui_erase_source_content, tui_show_source_content): Change type
6252         of win_info.
6253         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6254         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6255         win_info.
6256         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6257         win_info.
6258         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6259
6260 2019-06-25  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-winsource.c (tui_clear_source_content)
6263         (tui_source_window_base::set_is_exec_point_at): Update.
6264         * tui/tui-source.c (tui_set_source_content_nil): Update.
6265         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6266         a bool.
6267         * tui/tui-data.c (init_content_element): Update.
6268
6269 2019-06-25  Tom Tromey  <tom@tromey.com>
6270
6271         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6272         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6273         * tui/tui-layout.c (init_and_make_win): Update.
6274         * tui/tui.h (enum tui_win_type): Update.
6275         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6276         tui_win_is_auxillary.
6277         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6278         tui_win_is_auxillary.
6279
6280 2019-06-25  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6283         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6284         (tui_delete_data_content_windows, tui_display_all_data)
6285         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6286         Update.
6287         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6288         * tui/tui-regs.c (tui_last_regs_line_no)
6289         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6290         (tui_show_registers): Update.
6291         (tui_show_register_group): Return void.  Update.
6292         (tui_display_registers_from, tui_display_reg_element_at_line)
6293         (tui_display_registers_from_line, tui_check_register_values):
6294         Update.
6295         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6296         member.
6297         (struct tui_data_window) <regs_content>: Now a std::vector.
6298         <regs_content_count>: Remove.
6299         (tui_add_content_elements, tui_free_data_content): Don't declare.
6300         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6301         (init_content_element): Remove DATA_WIN case.  Add assert.
6302         (tui_add_content_elements): Remove.
6303         (tui_data_window): Update.
6304         (tui_free_data_content): Remove.
6305         (free_content_elements): Remove DATA_WIN case.
6306
6307 2019-06-25  Tom Tromey  <tom@tromey.com>
6308
6309         * tui/tui-data.c (tui_data_item_window): Update.
6310         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6311         * tui/tui-windata.c (tui_display_all_data)
6312         (tui_display_data_from_line): Update.
6313         (tui_check_data_values): Remove.
6314         * tui/tui-regs.c (tui_show_register_group)
6315         (tui_display_reg_element_at_line): Update.
6316         * tui/tui-hooks.c (tui_register_changed)
6317         (tui_refresh_frame_and_register_information): Call
6318         tui_check_register_values.
6319         * tui/tui-data.h (struct tui_data_window) <data_content,
6320         data_content_count, data_type>: Remove.
6321         (enum tui_data_type): Remove.
6322
6323         * tui/tui-data.c (tui_data_window::clear_detail)
6324         (~tui_data_window): Update.
6325
6326 2019-06-25  Tom Tromey  <tom@tromey.com>
6327
6328         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6329         declare.
6330         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6331         Rename from tui_first_data_item_displayed.  Update.
6332         (tui_data_window::refresh_all)
6333         (tui_data_window::do_scroll_vertical): Update.
6334         * tui/tui-data.h (struct tui_data_window)
6335         <first_data_item_displayed>: Declare new method.
6336
6337 2019-06-25  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6340         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6341         contents...
6342         (tui_initialize_static_data): ...here.
6343
6344 2019-06-25  Tom Tromey  <tom@tromey.com>
6345
6346         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6347         (tui_display_registers_from, tui_check_register_values): Update.
6348         (tui_display_register): Remove win_info parameter; update.
6349         (tui_get_register): Change type of parameters.
6350         * tui/tui-data.h (struct tui_data_element): Remove.
6351         (union tui_which_element) <data>: Remove.
6352         <data_window>: Change type.
6353         (struct tui_data_item_window): New.
6354         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6355         case.  Add assert.
6356         (~tui_data_item_window): New destructor.
6357         (free_content_elements): Remove DATA_ITEM_WIN case.
6358
6359 2019-06-25  Tom Tromey  <tom@tromey.com>
6360
6361         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6362         Remove.
6363
6364 2019-06-25  Tom Tromey  <tom@tromey.com>
6365
6366         * tui/tui-data.h (struct tui_command_element): Remove.
6367         (union tui_which_element) <command>: Remove.
6368         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6369         assert.
6370         (free_content_elements): Remove CMD_WIN case.
6371
6372 2019-06-25  Tom Tromey  <tom@tromey.com>
6373
6374         * tui/tui-layout.c (tui_set_layout): Update.
6375         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6376         * tui/tui-data.c (layout_def): Update.
6377
6378 2019-06-25  Tom Tromey  <tom@tromey.com>
6379
6380         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6381         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6382         (tui_source_window_base::set_new_height): Update.
6383         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6384         Update.
6385         (tui_set_locator_fullname, tui_set_locator_info)
6386         (tui_show_frame_info): Update.
6387         * tui/tui-source.c (tui_set_source_content)
6388         (tui_source_is_displayed): Update.
6389         * tui/tui-layout.c (show_source_disasm_command, show_data)
6390         (show_source_or_disasm_and_command): Update.
6391         * tui/tui-disasm.c (tui_set_disassem_content)
6392         (tui_get_begin_asm_address): Update.
6393         * tui/tui-data.h (struct tui_locator_element): Remove.
6394         (union tui_which_element) <locator>: Remove.
6395         (struct tui_locator_window): New.
6396         (tui_locator_win_info_ptr): Change return type.
6397         * tui/tui-data.c (_locator): Change type.
6398         (tui_locator_win_info_ptr): Change return type.
6399         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6400         (tui_alloc_content): Add assert.
6401
6402 2019-06-25  Tom Tromey  <tom@tromey.com>
6403
6404         * tui/tui-winsource.c
6405         (tui_exec_info_window::maybe_allocate_content): New method.
6406         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6407         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6408         (make_source_or_disasm_window): Add cast.
6409         * tui/tui-data.h (union tui_which_element) <simple_string>:
6410         Remove.
6411         (struct tui_source_info): New.
6412         (struct tui_source_window_base) <execution_info>: Change type.
6413         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6414         case, and add assert.
6415         (tui_alloc_content): Add assert.
6416
6417 2019-06-25  Tom Tromey  <tom@tromey.com>
6418
6419         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6420         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6421         * tui/tui-data.c (tui_alloc_win_info): Remove.
6422
6423 2019-06-25  Tom Tromey  <tom@tromey.com>
6424
6425         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6426         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6427         can_highlight.
6428
6429 2019-06-25  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6432         make_visible_with_new_height method.
6433         (tui_win_info::make_visible_with_new_height): New method.
6434         (tui_source_window_base::do_make_visible_with_new_height)
6435         (tui_data_window::do_make_visible_with_new_height)
6436         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6437         (make_visible_with_new_height): Remove.
6438         (tui_resize_all, tui_adjust_win_heights): Use
6439         make_visible_with_new_height method.
6440         * tui/tui-data.h (struct tui_win_info)
6441         <do_make_visible_with_new_height, make_visible_with_new_height>:
6442         New methods.
6443         (struct tui_source_window_base, struct tui_data_window)
6444         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6445         methods.
6446
6447 2019-06-25  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6450         method.
6451         (update_tab_width): Call update_tab_width method.
6452         * tui/tui-data.h (struct tui_win_info)
6453         (struct tui_source_window_base) <update_tab_width>: New methods.
6454
6455 2019-06-25  Tom Tromey  <tom@tromey.com>
6456
6457         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6458         parameter.
6459         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6460         parameter.
6461         (tui_gen_win_info::make_visible): Update.
6462         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6463         parameter.
6464         * tui/tui-data.h (enum tui_box): New enum.
6465         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6466
6467 2019-06-25  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6470         init_and_make_win for EXEC_INFO_WIN.
6471         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6472         longer inline.
6473         (struct tui_win_info) <~tui_win_info>: Inline.
6474         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6475         Don't declare.
6476         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6477         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6478         Remove.
6479         (tui_initialize_static_data): Update.
6480         (~tui_gen_win_info): Handle more cleanup here.
6481         (~tui_source_window_base): Delete "execution_info".
6482         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6483
6484 2019-06-25  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-layout.c (make_command_window): Don't set
6487         can_highlight.
6488         (show_source_disasm_command): Call the reset method.
6489         (show_data): Don't set can_highlight.  Call the reset method.
6490         (tui_gen_win_info::reset): Rename from init_gen_win_info
6491         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6492         (show_source_or_disasm_and_command): Call the reset method.
6493         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6494         (struct tui_cmd_window): Set can_highlight.
6495
6496 2019-06-25  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6499         from make_visible.
6500         (tui_make_visible, tui_make_invisible): Rewrite.
6501         (tui_win_info::make_visible): Remove.
6502         (tui_source_window_base::make_visible): Update.
6503         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6504         method.  Moved from...
6505         (struct tui_win_info) <make_visible>: ...here.
6506
6507 2019-06-25  Tom Tromey  <tom@tromey.com>
6508
6509         * tui/tui-winsource.c
6510         (tui_source_window_base::do_scroll_horizontal): Remove direction
6511         parameter.
6512         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6513         direction parameter.
6514         * tui/tui-win.c (tui_win_info::forward_scroll)
6515         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6516         (tui_win_info::right_scroll): Update.
6517         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6518         direction parameter.
6519         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6520         direction parameter.
6521         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6522         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6523         Remove direction parameter.
6524         (struct tui_source_window_base, struct tui_source_window)
6525         (struct tui_disasm_window, struct tui_data_window)
6526         (struct tui_cmd_window): Update.
6527
6528 2019-06-25  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui-winsource.h (tui_set_exec_info_content)
6531         (tui_show_exec_info_content, tui_erase_exec_info_content)
6532         (tui_clear_exec_info_content, tui_update_exec_info): Change
6533         argument to tui_source_window_base.
6534         * tui/tui-winsource.c (tui_set_exec_info_content)
6535         (tui_show_exec_info_content, tui_erase_exec_info_content)
6536         (tui_clear_exec_info_content, tui_update_exec_info): Change
6537         argument to tui_source_window_base.
6538
6539 2019-06-25  Tom Tromey  <tom@tromey.com>
6540
6541         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6542         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6543
6544 2019-06-25  Tom Tromey  <tom@tromey.com>
6545
6546         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6547         check.
6548
6549 2019-06-25  Tom Tromey  <tom@tromey.com>
6550
6551         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6552         type to void.
6553         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6554         type to void.
6555         * tui/tui-source.c (tui_set_source_content): Update.
6556         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6557
6558 2019-06-25  Tom Tromey  <tom@tromey.com>
6559
6560         * tui/tui-win.c (window_name_completer, tui_set_focus)
6561         (tui_all_windows_info): Use name method.
6562         * tui/tui-data.h (struct tui_gen_win_info)
6563         (struct tui_source_window, struct tui_disasm_window)
6564         (struct tui_data_window, struct tui_cmd_window) <name>: New
6565         method.
6566         (tui_win_name): Don't declare.
6567         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6568         (tui_win_name): Remove.
6569
6570 2019-06-25  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-winsource.h (tui_update_source_window)
6573         (tui_update_source_window_as_is): Change parameter type.
6574         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6575         to be a tui_source_window_base.
6576         (tui_update_source_window_as_is): Likewise.
6577         * tui/tui-win.c (make_visible_with_new_height): Update.
6578
6579 2019-06-25  Tom Tromey  <tom@tromey.com>
6580
6581         * tui/tui-winsource.c (tui_erase_source_content)
6582         (tui_show_source_content, tui_show_exec_info_content)
6583         (tui_erase_exec_info_content): Use refresh_window method.
6584         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6585         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6586         from tui_refresh_win.
6587         (tui_data_window::refresh_window): New method.
6588         (tui_win_info::refresh, tui_source_window_base::refresh)
6589         (tui_refresh_all): Use refresh_window method.
6590         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6591         method.
6592         * tui/tui-regs.c (tui_display_register): Call refresh_window
6593         method.
6594         * tui/tui-layout.c (show_source_disasm_command)
6595         (show_source_or_disasm_and_command): Call refresh_window method.
6596         * tui/tui-data.h (struct tui_gen_win_info)
6597         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6598         New method.
6599
6600 2019-06-25  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui.c (tui_rl_other_window, tui_enable)
6603         (tui_is_window_visible, tui_get_command_dimension): Update.
6604         * tui/tui-winsource.c (tui_update_source_window_as_is)
6605         (tui_clear_source_content, tui_erase_source_content)
6606         (tui_show_source_line, tui_source_window_base::refill)
6607         (tui_source_window_base::do_scroll_horizontal)
6608         (tui_source_window_base::set_is_exec_point_at)
6609         (tui_update_breakpoint_info, tui_set_exec_info_content)
6610         (tui_alloc_source_buffer, tui_line_is_displayed)
6611         (tui_addr_is_displayed): Update.
6612         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6613         (tui_check_and_display_highlight_if_needed)
6614         (tui_win_info::make_visible, tui_win_info::refresh)
6615         (tui_refresh_all): Update.
6616         * tui/tui-windata.c (tui_first_data_item_displayed)
6617         (tui_delete_data_content_windows, tui_erase_data_content)
6618         (tui_display_all_data, tui_data_window::refresh_all)
6619         (tui_check_data_values): Update.
6620         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6621         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6622         (tui_win_info::backward_scroll, tui_refresh_all_win)
6623         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6624         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6625         (tui_source_window_base::set_new_height)
6626         (tui_data_window::set_new_height)
6627         (make_invisible_and_set_new_height)
6628         (make_visible_with_new_height, new_height_ok)
6629         (parse_scrolling_args): Update.
6630         * tui/tui-stack.c (tui_show_frame_info): Update.
6631         * tui/tui-source.c (tui_set_source_content)
6632         (tui_set_source_content_nil, tui_source_is_displayed)
6633         (tui_source_window::do_scroll_vertical): Update.
6634         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6635         (tui_display_registers_from, tui_display_reg_element_at_line)
6636         (tui_check_register_values, tui_reg_command): Update.
6637         * tui/tui-layout.c (tui_default_win_height)
6638         (show_source_disasm_command, show_data, init_and_make_win)
6639         (show_source_or_disasm_and_command): Update.
6640         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6641         (tui_redisplay_readline, tui_mld_flush)
6642         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6643         (tui_getc): Update.
6644         * tui/tui-disasm.c (tui_set_disassem_content)
6645         (tui_disasm_window::do_scroll_vertical): Update.
6646         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6647         Now virtual.
6648         (struct tui_win_info): Derive from tui_gen_win_info.
6649         <~tui_win_info>: Mark as override.
6650         <generic>: Remove member.
6651         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6652         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6653         (~tui_data_window, ~tui_win_info)
6654         (tui_free_all_source_wins_content): Update.
6655         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6656
6657 2019-06-25  Tom Tromey  <tom@tromey.com>
6658
6659         * tui/tui-layout.c (init_and_make_win): Use new.
6660         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6661         destructor, initializers.
6662         (tui_alloc_generic_win_info): Don't declare.
6663         * tui/tui-data.c (_locator): Add argument to constructor.
6664         (source_win, disasm_win): New globals.
6665         (exec_info): Remove.
6666         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6667         Update.
6668         (tui_alloc_generic_win_info): Remove.
6669         (init_content_element): Use new.
6670         (tui_win_info::tui_win_info): Update.
6671         (free_content_elements) <case DATA_WIN>: Use delete.
6672
6673 2019-06-25  Tom Tromey  <tom@tromey.com>
6674
6675         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6676         * tui/tui-windata.c (tui_first_data_item_displayed)
6677         (tui_delete_data_content_windows): Update.
6678         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6679         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6680         (tui_display_registers_from, tui_check_register_values): Update.
6681         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6682         pointer.
6683         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6684         window.
6685         (tui_free_data_content): Update.
6686         (free_content_elements) <case DATA_WIN>: Free the window.
6687
6688 2019-06-25  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6691         Update.
6692         * tui/tui-layout.c (make_command_window)
6693         (show_source_disasm_command, show_data, init_and_make_win)
6694         (show_source_or_disasm_and_command): Update.
6695         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6696         method.
6697         <can_highight, is_highlighted>: Now bool.
6698         (tui_set_win_highlight): Don't declare.
6699         * tui/tui-data.c (tui_set_win_highlight): Remove.
6700
6701 2019-06-25  Tom Tromey  <tom@tromey.com>
6702
6703         * tui/tui-wingeneral.c (make_visible): Remove check of window
6704         type.
6705
6706 2019-06-25  Tom Tromey  <tom@tromey.com>
6707
6708         * tui/tui-win.c (tui_win_info::max_height)
6709         (tui_cmd_window::max_height): New methods.
6710         (new_height_ok): Call max_height.
6711         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6712         <max_height>: New method.
6713
6714 2019-06-25  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-win.c (tui_source_window_base::set_new_height)
6717         (tui_data_window::set_new_height): New methods.
6718         (make_invisible_and_set_new_height): Call set_new_height method.
6719         * tui/tui-data.h (struct tui_win_info)
6720         (struct tui_source_window_base, struct tui_data_window)
6721         <set_new_height>: New method.
6722
6723 2019-06-25  Tom Tromey  <tom@tromey.com>
6724
6725         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6726         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6727         tui_refresh_data_win.
6728         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6729         method.
6730         (tui_refresh_all_win): Call the refresh_all method.
6731         (tui_set_focus): Likewise.
6732         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6733         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6734         Likewise.
6735
6736 2019-06-25  Tom Tromey  <tom@tromey.com>
6737
6738         * tui/tui-winsource.h (tui_refill_source_window)
6739         (tui_set_is_exec_point_at): Don't declare.
6740         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6741         (tui_source_window_base::refill): Rename from
6742         tui_refill_source_window.
6743         (tui_source_window_base::do_scroll_horizontal): Update.
6744         (tui_source_window_base::set_is_exec_point_at): Rename from
6745         tui_set_is_exec_point_at.
6746         (tui_update_all_breakpoint_info): Update.
6747         * tui/tui-stack.c (tui_show_frame_info): Update.
6748         * tui/tui-layout.c (show_data): Add cast.
6749         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6750         * tui/tui-data.h (struct tui_source_window_base) <refill,
6751         set_is_exec_point_at>: New methods.
6752         (tui_source_windows, tui_add_to_source_windows): Update types.
6753         (tui_add_to_source_windows): Remove redundant declaration.
6754         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6755         (tui_source_windows): Change return type.
6756         (tui_clear_source_windows_detail): Update.
6757         (tui_add_to_source_windows): Change type of parameter.
6758         (tui_free_all_source_wins_content): Update.
6759
6760 2019-06-25  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-wingeneral.c (tui_win_info::refresh)
6763         (tui_source_window_base::refresh): New methods.
6764         (tui_refresh_all): Call the refresh method.
6765         * tui/tui-data.h (struct tui_win_info)
6766         (struct tui_source_window_base) <refresh>: New method.
6767
6768 2019-06-25  Tom Tromey  <tom@tromey.com>
6769
6770         * tui/tui.h (tui_is_window_visible): Return bool.
6771         * tui/tui.c (tui_is_window_visible): Return bool.
6772         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6773         (tui_make_visible, tui_make_invisible)
6774         (tui_win_info::make_visible)
6775         (tui_source_window_base::make_visible, make_all_visible)
6776         (tui_make_all_visible, tui_make_all_invisible): Update.
6777         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6778         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6779         bool.
6780         (struct tui_win_info, struct tui_source_window_base)
6781         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6782         * tui/tui-data.c (tui_init_generic_part): Update.
6783
6784 2019-06-25  Tom Tromey  <tom@tromey.com>
6785
6786         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6787         (tui_source_window_base::make_visible): New methods.
6788         (make_all_visible): Make method call.
6789         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6790         (struct tui_source_window_base, struct tui_cmd_window): Override
6791         make_visible.
6792         (tui_win_is_source_type): Don't declare.
6793         * tui/tui-data.c (tui_win_is_source_type): Remove.
6794
6795 2019-06-25  Tom Tromey  <tom@tromey.com>
6796
6797         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6798         NULL check.
6799
6800 2019-06-25  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6803         Inline constructor.  Add initializers for members.
6804         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6805         constructors; now inline in class.
6806
6807 2019-06-25  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-regs.c (tui_show_registers): Update.
6810         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6811         bool.
6812         * tui/tui-data.c (tui_data_window::clear_detail)
6813         (tui_data_window): Update.
6814
6815 2019-06-25  Tom Tromey  <tom@tromey.com>
6816
6817         * tui/tui-windata.c (tui_display_all_data)
6818         (tui_display_data_from_line, tui_display_data_from)
6819         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6820         Update.
6821         * tui/tui-regs.c (tui_last_regs_line_no)
6822         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6823         (tui_show_registers, tui_show_register_group)
6824         (tui_display_registers_from, tui_display_reg_element_at_line)
6825         (tui_display_registers_from_line, tui_check_register_values)
6826         (tui_reg_next, tui_reg_prev): Update.
6827         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6828         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6829         tui_data_window.
6830         (struct tui_win_info) <detail>: Remove.  Add new fields from
6831         tui_data_info.
6832         (TUI_DATA_WIN): Add cast.
6833         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6834         (~tui_data_window): Simplify.
6835
6836 2019-06-25  Tom Tromey  <tom@tromey.com>
6837
6838         * tui/tui-layout.c (show_source_disasm_command)
6839         (show_source_or_disasm_and_command): Update.
6840         * tui/tui-io.c (update_cmdwin_start_line)
6841         (tui_redisplay_readline): Update.
6842         * tui/tui-data.h (struct tui_command_info): Remove.
6843         (struct tui_win_info) <detail>: Remove command_info member.
6844         (struct tui_data_window) <start_line>: New member, from
6845         tui_command_info.
6846         (TUI_CMD_WIN): Add casts.
6847
6848 2019-06-25  Tom Tromey  <tom@tromey.com>
6849
6850         * tui/tui-winsource.c (tui_update_source_window)
6851         (tui_refill_source_window)
6852         (tui_source_window_base::do_scroll_horizontal)
6853         (tui_update_breakpoint_info, tui_set_exec_info_content)
6854         (tui_show_exec_info_content, tui_erase_exec_info_content)
6855         (tui_clear_exec_info_content): Update.
6856         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6857         Update.
6858         * tui/tui-win.c (make_invisible_and_set_new_height)
6859         (make_visible_with_new_height): Update.
6860         * tui/tui-source.c (tui_set_source_content)
6861         (tui_show_symtab_source): Update.
6862         * tui/tui-layout.c (extract_display_start_addr)
6863         (show_source_disasm_command, show_data)
6864         (make_source_or_disasm_window)
6865         (show_source_or_disasm_and_command): Update.
6866         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6867         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6868         "gdbarch".
6869         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6870         to tui_source_window_base.
6871         (struct tui_win_info) <detail>: Remove source_info member.
6872         (struct tui_source_window_base) <has_locator>: Inline.
6873         Move contents from tui_source_info; rename has_locator member to
6874         m_has_locator.
6875         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6876         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6877         header file.
6878         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6879         Simplify.
6880         (tui_free_all_source_wins_content): Cast to
6881         tui_source_window_base.
6882
6883 2019-06-25  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-win.c (make_invisible_and_set_new_height)
6886         (make_visible_with_new_height): Call has_locator method.
6887         * tui/tui-layout.c (show_source_disasm_command, show_data)
6888         (show_source_or_disasm_and_command): Update for bool change.
6889         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6890         (tui_win_info) <has_locator>: New method.
6891         (struct tui_source_window_base) <has_locator>: New method.
6892         (tui_win_has_locator): Don't declare.
6893         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6894         from tui_win_has_locator.
6895         (tui_source_window_base): Use false, not FALSE.
6896
6897 2019-06-25  Tom Tromey  <tom@tromey.com>
6898
6899         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6900         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6901         clear_detail method directly.
6902         (tui_clear_win_detail): Remove.
6903
6904 2019-06-25  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6907         "this", not TUI_DISASM_WIN.
6908
6909 2019-06-25  Tom Tromey  <tom@tromey.com>
6910
6911         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6912         declare.
6913         * tui/tui-winsource.c
6914         (tui_source_window_base::do_scroll_horizontal): Rename from
6915         tui_horizontal_source_scroll.
6916         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6917         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6918         from tui_vertical_data_scroll.
6919         * tui/tui-win.h (tui_scroll): Don't declare.
6920         * tui/tui-win.c (tui_win_info::forward_scroll)
6921         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6922         (tui_win_info::right_scroll): Rename and update.
6923         (tui_scroll_forward_command, tui_scroll_backward_command)
6924         (tui_scroll_left_command, tui_scroll_right_command): Update.
6925         (tui_scroll): Remove.
6926         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6927         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6928         from tui_vertical_source_scroll.
6929         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6930         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6931         from tui_vertical_disassem_scroll.
6932         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6933         do_scroll_horizontal>: New methods.
6934         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6935         Likewise.
6936         (struct tui_source_window_base): Add do_scroll_horizontal.
6937         (struct tui_source_window, struct tui_disasm_window): Add
6938         do_scroll_vertical.
6939         (struct tui_data_window, struct tui_cmd_window): Add
6940         do_scroll_horizontal and do_scroll_vertical.
6941         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6942
6943 2019-06-25  Tom Tromey  <tom@tromey.com>
6944
6945         * tui/tui-data.h (struct tui_source_window_base): New struct.
6946         (struct tui_source_window): Derive from tui_source_window_base.
6947         (struct tui_disasm_window): New struct.
6948         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6949         from tui_source_window::clear_detail.
6950         (tui_source_window_base): Rename from tui_source_window.
6951         (~tui_source_window_base): Rename from ~tui_source_window.
6952         (tui_alloc_win_info): Create a tui_disasm_window.
6953
6954 2019-06-25  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-data.h (struct tui_source_window)
6957         (struct tui_data_window): Declare destructors.
6958         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6959         destructors.
6960         (tui_win_info): Simplify.
6961
6962 2019-06-25  Tom Tromey  <tom@tromey.com>
6963
6964         * tui/tui-winsource.c (tui_display_main)
6965         (tui_update_source_windows_with_addr)
6966         (tui_update_all_breakpoint_info): Update.
6967         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6968         (new_height_ok, parse_scrolling_args): Update.
6969         * tui/tui-stack.c (tui_show_frame_info): Update.
6970         * tui/tui-data.h (struct tui_list): Remove.
6971         (tui_source_windows): Return a reference to a std::vector.
6972         * tui/tui-data.c (source_windows): Now a std::vector.
6973         (tui_source_windows): Change return type.
6974         (tui_clear_source_windows): Rewrite.
6975         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6976         (tui_free_all_source_wins_content): Rewrite.
6977
6978 2019-06-25  Tom Tromey  <tom@tromey.com>
6979
6980         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6981         (struct tui_data_window, struct tui_cmd_window): Declare
6982         clear_detail method.
6983         * tui/tui-data.c (tui_source_window::clear_detail)
6984         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6985         methods.
6986         (tui_clear_win_detail): Simplify.
6987
6988 2019-06-25  Tom Tromey  <tom@tromey.com>
6989
6990         * tui/tui-layout.c (make_source_window, make_disasm_window)
6991         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6992         Return the new window.
6993         (show_source_disasm_command, show_data)
6994         (show_source_or_disasm_and_command): Update.
6995
6996 2019-06-25  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6999         parameter.  Return the new window.
7000         (show_source_disasm_command): Update and remove NULL check.
7001         (show_source_or_disasm_and_command): Update.
7002
7003 2019-06-25  Tom Tromey  <tom@tromey.com>
7004
7005         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7006
7007 2019-06-25  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-data.h (struct tui_win_info): Make constructor
7010         protected.  Make destructor virtual.  Add initializers.
7011         (tui_source_window, tui_data_window, tui_cmd_window): New
7012         classes.
7013         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7014         constructor.  Add "type" parameter.
7015         (tui_source_window, tui_data_window, tui_cmd_window): New
7016         constructors.
7017         (tui_alloc_win_info): Instantiate the appropriate subclass.
7018
7019 2019-06-25  Tom Tromey  <tom@tromey.com>
7020
7021         * tui/tui-win.c (tui_resize_all): Use delete.
7022         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7023         destructor.
7024         (tui_free_window): Don't declare.
7025         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7026         Update.
7027
7028 2019-06-25  Tom Tromey  <tom@tromey.com>
7029
7030         * tui/tui-data.h (struct tui_win_info): Add constructor.
7031         * tui/tui-data.c (tui_alloc_win_info): Use new.
7032         (tui_free_window): Use delete.
7033
7034 2019-06-22  Tom Tromey  <tom@tromey.com>
7035
7036         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7037         declare.
7038         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7039
7040 2019-06-22  Tom Tromey  <tom@tromey.com>
7041
7042         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7043         declare.
7044         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7045
7046 2019-06-22  Tom de Vries  <tdevries@suse.de>
7047
7048         * dwarf2read.c (create_addrmap_from_aranges)
7049         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7050         instead of '%zu'.
7051
7052 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7053
7054         * dwarf2read.h (dwarf2_section_info_def): Remove.
7055         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7056         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7057         std::vector<dwarf2_section_info>.
7058         (struct dwo_file) <~dwo_file>: Remove.
7059         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7060         types field.
7061         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7062         (dwarf2_read_debug_names): Likewise.
7063         (create_debug_types_hash_table): Change parameter type to
7064         array_view, adjust code accordingly.
7065         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7066         (partial_die_info::fixup): Likewise.
7067         (determine_prefix): Likewise.
7068         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7069
7070 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7071
7072         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7073         gdb_bfd_ref_ptr.
7074         <~dwo_file>: Remove call to gdb_bfd_unref.
7075         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7076         gdb_bfd_ref_ptr::get.
7077
7078 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7079
7080         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7081         type to htab_up.
7082         * dwarf2read.c (struct dwo_file): Initialize fields.
7083         <~dwo_file>: New.
7084         (free_dwo_file): Remove, move content to ~dwo_file.
7085         (struct dwo_file_deleter): Remove.
7086         (dwo_file_up>: Remove custom deleter.
7087         (free_dwo_files): Remove.
7088         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7089         dwo_files.
7090         (process_skeletonless_type_units): Call unique_ptr::get.
7091         (allocate_dwo_file_hash_table): Add deleter to created hash
7092         table.  Change return type to htab_up.
7093         (lookup_dwo_file_slot): Don't memset dwo_file, call
7094         unique_ptr::get.
7095         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7096         (create_dwo_unit_in_dwp_v2): Likewise.
7097         (open_and_init_dwo_file): Likewise.
7098         (free_dwo_file_from_slot): Remove.
7099
7100 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7101
7102         * dwarf2read.h (struct dwarf2_section_info) <readin,
7103         is_virtual>: Change type to bool.
7104         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7105         true instead of 1.
7106
7107 2019-06-19  Tom Tromey  <tom@tromey.com>
7108
7109         * tui/tui-data.h (tui_init_content_element): Don't declare.
7110
7111 2019-06-19  Tom Tromey  <tom@tromey.com>
7112
7113         * tui/tui-data.h (tui_init_win_info): Don't declare.
7114
7115 2019-06-19  Tom de Vries  <tdevries@suse.de>
7116
7117         * dwarf2read.h (abstract_to_concrete): Change type to
7118         std::unordered_map<sect_offset, std::vector<sect_offset>,
7119         gdb::hash_enum<sect_offset>>.
7120
7121 2019-06-19  Tom Tromey  <tromey@adacore.com>
7122
7123         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7124         EVAL_AVOID_SIDE_EFFECTS specially.
7125
7126 2019-06-19  Tom Tromey  <tromey@adacore.com>
7127
7128         * source-cache.c (highlighter): New global.
7129         (source_cache::get_source_lines): Create a highlighter on demand.
7130
7131 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7132
7133         * defs.h (deprecated_interactive_hook): Delete declaration.
7134         * interps.c (clear_interpreter_hooks): Remove use of
7135         deprecated_interactive_hook.
7136         * top.c (deprecated_interactive_hook): Delete definition.
7137         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7138
7139 2019-06-18  Tom de Vries  <tdevries@suse.de>
7140
7141         PR gdb/24515
7142         * dwarf2read.h (abstract_to_concrete): Change type from
7143         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7144         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7145         * dwarf2read.c (read_variable): Update.
7146         (dwarf2_fetch_die_loc_sect_off): Update.
7147
7148 2019-06-17  Tom de Vries  <tdevries@suse.de>
7149
7150         PR gdb/24617
7151         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7152         accessing parent[parent_len - 1].
7153
7154 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7155
7156         PR gdb/24364
7157         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7158         call dtrace_process_dof with NULL dof.
7159
7160 2019-06-16  Tom de Vries  <tdevries@suse.de>
7161
7162         PR gdb/24445
7163         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7164
7165 2019-06-16  Tom Tromey  <tom@tromey.com>
7166
7167         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7168         (make_all_visible): Use address of member.
7169
7170 2019-06-16  Tom Tromey  <tom@tromey.com>
7171
7172         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7173         (tui_free_window, free_content, free_content_elements): Remove
7174         unnecessary cast.
7175         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7176         cast.
7177         * tui/tui-regs.c (tui_show_register_group)
7178         (tui_display_registers_from, tui_display_reg_element_at_line):
7179         Remove unnecessary cast.
7180
7181 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7182
7183         * linux-nat.c (normal_mask): Delete.
7184         (_initialize_linux_nat): Don't initialise normal_mask.
7185
7186 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7187
7188         PR gdb/24445
7189         * dwarf-index-write.h (write_psymtabs_to_index): Add
7190         dwz_basename parameter.
7191         * dwarf-index-write.c (write_gdbindex): Move file writing to
7192         write_gdbindex_1.  Change return type void.
7193         (assert_file_size): Move up, remove filename parameter.
7194         (write_gdbindex_1): New function.
7195         (write_debug_names): Change return type to void, call
7196         assert_file_size.
7197         (struct index_wip_file): New struct.
7198         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7199         file logic to index_wip_file.  Write index for dwz file if
7200         needed.
7201         (save_gdb_index_command): Pass basename of dwz file, if present.
7202         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7203         build-id of dwz file, if present.
7204         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7205         (dwarf2_get_dwz_file): Likewise.
7206         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7207         (dwarf2_get_dwz_file): Likewise.
7208
7209 2019-06-16  Tom Tromey  <tom@tromey.com>
7210
7211         * coffread.c (process_coff_symbol): Use xstrdup.
7212         * value.c (create_internalvar): Use xstrdup.
7213
7214 2019-06-16  Tom Tromey  <tom@tromey.com>
7215
7216         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7217         * breakpoint.c (stopin_command, stopat_command)
7218         (until_break_command, decode_location_default): Remove unnecessary
7219         cast.
7220         * utils.c (subset_compare): Remove unnecessary cast.
7221         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7222         cast.
7223         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7224         cast.
7225         * infcmd.c (path_command): Remove unnecessary cast.
7226         * coffread.c (decode_type): Remove unnecessary cast.
7227         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7228         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7229         * tui/tui-stack.c (tui_show_locator_content)
7230         (tui_show_frame_info): Remove unnecessary cast.
7231         * tui/tui-win.c (tui_scroll_forward_command)
7232         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7233         (parse_scrolling_args): Remove unnecessary cast.
7234         * tui/tui-data.c (init_win_info, tui_del_window)
7235         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7236         (free_content_elements): Remove unnecessary cast.
7237         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7238         unnecessary cast.
7239         * tui/tui-source.c (tui_set_source_content)
7240         (tui_vertical_source_scroll): Remove unnecessary cast.
7241         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7242         cast.
7243         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7244         * tui/tui-regs.c (tui_display_registers_from)
7245         (tui_display_register): Remove unnecessary cast.
7246         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7247         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7248         (make_visible): Remove unnecessary cast.
7249         * tui/tui-winsource.c (tui_erase_source_content)
7250         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7251         unnecessary cast.
7252         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7253         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7254         * stabsread.c (read_type, read_array_type, read_range_type):
7255         Remove unnecessary cast.
7256         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7257         (parse_symbol, parse_type, upgrade_type, parse_external)
7258         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7259         unnecessary cast.
7260         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7261
7262 2019-06-16  Tom Tromey  <tom@tromey.com>
7263
7264         * tui/tui-data.c (tui_alloc_generic_win_info)
7265         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7266         checks.
7267
7268 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7269             Andrew Burgess  <andrew.burgess@embecosm.com>
7270
7271         * f-typeprint.c (f_print_type): Don't return early for not
7272         associated or not allocated types.
7273         (f_type_print_varspec_suffix): Add print_rank parameter and print
7274         ranks of array types in case they dangling.
7275         (f_type_print_base): Add print_rank parameter.
7276
7277 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7278
7279         * NEWS: Mention new MI commands.
7280         * break-catch-throw.c (enum exception_event_kind): Move to
7281         breakpoint.h.
7282         (print_mention_exception_catchpoint): Output text as a single
7283         message.
7284         (catch_exception_command_1): Rename to...
7285         (catch_exception_event): ...this, make non-static, update header
7286         command, and change some parameter types.
7287         (catch_catch_command): Update for changes to
7288         catch_exception_command_1.
7289         (catch_throw_command): Likewise.
7290         (catch_rethrow_command): Likewise.
7291         * breakpoint.c (enum exception_event_kind): Delete.
7292         * breakpoint.h (enum exception_event_kind): Moved here from
7293         break-catch-throw.c.
7294         (catch_exception_event): Declare.
7295         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7296         (mi_cmd_catch_throw): New function.
7297         (mi_cmd_catch_rethrow): New function.
7298         (mi_cmd_catch_catch): New function.
7299         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7300         'catch-catch' entries.
7301         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7302         (mi_cmd_catch_rethrow): Declare.
7303         (mi_cmd_catch_catch): Declare.
7304
7305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * annotate.c (annotate_source_line): Change return type to void,
7308         update implementation to match.
7309         * annotate.h (annotate_source_line): Change return type to void,
7310         update header comment.
7311         * stack.c (print_frame_info): Don't change what frame information
7312         is printed based on whether annotations are on or not.
7313
7314 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7317         (annotate_source): Make static.
7318         (annotate_source_line): Moved from source.c and renamed from
7319         identify_source_line.  Update the return type.
7320         * annotate.h (annotate_source): Delete declaration.
7321         (annotate_source_line): Declaration moved from source.h, and
7322         renamed from identify_source_line.  Return type updated.
7323         * source.c (identify_source_line): Moved to annotate.c and renamed
7324         to annotate_source_line.
7325         (info_line_command): Remove check of annotation_level.
7326         * source.h (identify_source_line): Move declaration to annotate.h
7327         and rename to annotate_source_line.
7328         * stack.c: Add 'annotate.h' include.
7329         (print_frame_info): Remove check of annotation_level before
7330         calling annotate_source_line.
7331
7332 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7333
7334         * source-cache.c (source_cache::get_plain_source_lines): Use
7335         open_source_file_with_line_charpos instead of just
7336         open_source_file, remove call to find_source_lines.
7337         (source_cache::get_source_lines): Likewise.
7338         * source.c (find_source_lines): Make static.
7339         (get_filename_and_charpos): Renamed into...
7340         (open_source_file_with_line_charpos): ..this along with changes to
7341         return a scoped_fd, and some other minor clean ups.
7342         (identify_source_line): Use open_source_file_with_line_charpos.
7343         (search_command_helper): Use open_source_file_with_line_charpos
7344         instead of just open_source_file, remove call to
7345         find_source_lines.
7346         * source.h (open_source_file_with_line_charpos): Declare new
7347         function.
7348         (find_source_lines): Delete declaration.
7349
7350 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7351
7352         * source.c (get_filename_and_charpos): Remove fullname
7353         parameter.
7354         (identify_source_line): Update call to get_filename_and_charpos.
7355
7356 2019-06-14  Tom Tromey  <tromey@adacore.com>
7357
7358         PR gdb/24502:
7359         * ui-style.h (skip_ansi_escape): Update comment.
7360         * ui-file.h (class no_terminal_escape_file): New class.
7361         * ui-file.c (no_terminal_escape_file::write)
7362         (no_terminal_escape_file::puts): New methods.
7363         * cli/cli-logging.c (handle_redirections): Use
7364         no_terminal_escape_file.
7365
7366 2019-06-14  Tom Tromey  <tromey@adacore.com>
7367
7368         * NEWS: Move convenience variable news above Python news.
7369
7370 2019-06-14  Tom Tromey  <tom@tromey.com>
7371
7372         * gnulib: Move directory to top-level.
7373         * configure.ac: Don't configure gnulib.
7374         * configure: Rebuild.
7375         * common/common-defs.h: Use new path to gnulib.
7376         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7377         (GNULIB_H): Remove.
7378         (INCGNU): Look in new gnulib location.
7379         (HFILES_NO_SRCDIR): Remove gnulib files.
7380         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7381         (generated_files): Remove GNULIB_H.
7382         ($(LIBGNU), all-lib): Remove targets.
7383         (distclean): Don't mention GNULIB_BUILDDIR.
7384         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7385
7386 2019-06-14  Tom Tromey  <tromey@adacore.com>
7387
7388         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7389         Warn if symbol file does not provide any symbols.
7390
7391 2019-06-14  Tom Tromey  <tromey@adacore.com>
7392
7393         * source.c (find_and_open_source): Respect basenames_may_differ.
7394
7395 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7396
7397         * annotate.c (annotate_breakpoints_invalid): Make use of
7398         scoped_restore_terminal_state.
7399         (annotate_frames_invalid): Likewise.
7400
7401 2019-06-14  Tom Tromey  <tromey@adacore.com>
7402
7403         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7404         allow assignment to an internalvar.
7405
7406 2019-06-14  Tom Tromey  <tromey@adacore.com>
7407
7408         * ada-lex.l: Allow "_" in attribute names.
7409
7410 2019-06-14  Tom Tromey  <tromey@adacore.com>
7411
7412         PR gdb/24653:
7413         * regcache.c (registers_changed): Don't call alloca.
7414         * top.c (execute_command): Don't call alloca.
7415
7416 2019-06-13  Pedro Alves  <palves@redhat.com>
7417
7418         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7419         'expression'.  When parsing an expression, error out if there's
7420         junk after "unlimited".
7421         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7422         (do_set_command): Adjust calls to is_unlimited_literal.
7423
7424 2019-06-13  Pedro Alves  <palves@redhat.com>
7425
7426         * compile/compile.c (make_compile_options_def_group): Add braces
7427         around array_view initializer.
7428         * thread.c (make_thread_apply_all_options_def_group)
7429         (make_thread_apply_all_options_def_group): Likewise.
7430
7431 2019-06-13  Pedro Alves  <palves@redhat.com>
7432
7433         * NEWS (New commands): Mention "maint test-options
7434         require-delimiter", "maint test-options unknown-is-error", "maint
7435         test-options unknown-is-operand" and "maint show
7436         test-options-completion-result".
7437         (New command options, command completion): New section.
7438         (Completion improvements): New section.
7439         Mention that you can abbreviate "unlimited".
7440
7441 2019-06-13  Pedro Alves  <palves@redhat.com>
7442
7443         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7444         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7445         * unittests/cli-utils-selftests.c (test_parse_flags)
7446         (test_parse_flags_qcs): Delete.
7447         (test_cli_utils): Don't call deleted functions.
7448
7449 2019-06-13  Pedro Alves  <palves@redhat.com>
7450
7451         * thread.c: Include "cli/cli-option.h".
7452         (tp_array_compar_ascending): Global.
7453         (tp_array_compar): Delete function.
7454         (tp_array_compar_ascending, tp_array_compar_descending): New
7455         functions.
7456         (ascending_option_def, qcs_flag_option_def)
7457         (thr_qcs_flags_option_defs)
7458         (make_thread_apply_all_options_def_group)
7459         (make_thread_apply_options_def_group): New.
7460         (thread_apply_all_command): Use gdb::option::process_options.
7461         (thread_apply_command_completer)
7462         (thread_apply_all_command_completer): New.
7463         (thread_apply_command): Use gdb::option::process_options.
7464         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7465         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7466         to generate help text of "thread apply".  Adjust "taas"'s help.
7467         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7468         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7469
7470 2019-06-13  Pedro Alves  <palves@redhat.com>
7471
7472         * thread.c (thread_apply_command): Check for invalid TID with
7473         isdigit instead of !isalpha.
7474
7475 2019-06-13  Pedro Alves  <palves@redhat.com>
7476
7477         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7478         (validate_flags_qcs): New.
7479         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7480         (validate_flags_qcs): Declare.
7481         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7482         (make_frame_apply_options_def_group): New.
7483         (frame_apply_command_count): Process options with
7484         gdb::option::process_options.
7485         (frame_apply_completer): New.
7486         (frame_apply_level_completer, frame_apply_all_completer)
7487         (frame_apply_completer): New.
7488         (_initialize_stack): Update help of "frame apply", "frame apply
7489         level", "frame apply all" and "faas" to mention supported options
7490         and install command completers.
7491         * stack.h (frame_apply_all_completer): Declare.
7492         * thread.c: Include "stack.h".
7493         (tfaas_command): Add "--".
7494         (_initialize_thread): Update help "tfaas" to mention supported
7495         options and install command completer.
7496
7497 2019-06-13  Pedro Alves  <palves@redhat.com>
7498
7499         * completer.c (complete_nested_command_line): New.
7500         (gdb_completion_word_break_characters_throw): Add assertion.
7501         * completer.h (complete_nested_command_line): Declare.
7502
7503 2019-06-13  Pedro Alves  <palves@redhat.com>
7504
7505         * stack.c (parse_backtrace_qualifiers): New.
7506         (backtrace_command): Use it.
7507         (backtrace_command_completer): Complete on qualifiers.
7508
7509 2019-06-13  Pedro Alves  <palves@redhat.com>
7510
7511         * frame.c: Include "cli/cli-option.h.
7512         (user_set_backtrace_options): New.
7513         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7514         Delete.
7515         (get_prev_frame): Adjust.
7516         (boolean_option_def, uinteger_option_def)
7517         (set_backtrace_option_defs): New.
7518         (_initialize_frame): Adjust and use
7519         gdb::option::add_setshow_cmds_for_options to install "set
7520         backtrace past-main" and "set backtrace past-entry".
7521         * frame.h: Include "cli/cli-option.h".
7522         (struct frame_print_options): Forward declare.
7523         (print_frame_arguments_all, print_frame_arguments_scalars)
7524         (print_frame_arguments_none): Declare.
7525         (print_entry_values): Delete declaration.
7526         (struct frame_print_options, user_frame_print_options): New.
7527         (struct set_backtrace_options): New.
7528         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7529         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7530         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7531         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7532         (list_args_or_locals): Add frame_print_options parameter.
7533         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7534         * python/py-framefilter.c (enumerate_args): Pass down
7535         USER_FRAME_PRINT_OPTIONS.
7536         * stack.c: Include "cli/cli-option.h".
7537         (print_frame_arguments_all, print_frame_arguments_scalars)
7538         (print_frame_arguments_none): Declare.
7539         (print_raw_frame_arguments, print_entry_values): Delete.
7540         (user_frame_print_options): New.
7541         (boolean_option_def, enum_option_def, frame_print_option_defs):
7542         New.
7543         (struct backtrace_cmd_options): New.
7544         (bt_flag_option_def): New.
7545         (backtrace_command_option_defs): New.
7546         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7547         (print_frame_arg, read_frame_arg, print_frame_args)
7548         (print_frame_info, print_frame): Add frame_print_options parameter
7549         and use it.
7550         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7551         (backtrace_command_1): Add frame_print_options and
7552         backtrace_cmd_options parameters and use them.
7553         (make_backtrace_options_def_group): New.
7554         (backtrace_command): Process command options with
7555         gdb::option::process_options.
7556         (backtrace_command_completer): New.
7557         (_initialize_stack): Extend "backtrace"'s help to mention
7558         supported options.  Install completer for "backtrace".
7559         Install some settings commands with add_setshow_cmds_for_options.
7560
7561 2019-06-13  Pedro Alves  <palves@redhat.com>
7562
7563         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7564         and that "set/show print raw frame-arguments" are now deprecated.
7565
7566         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7567         command.
7568         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7569         * stack.c (_initialize_stack): Install "set/show print
7570         raw-frame-arguments", and deprecate "set/show print raw
7571         frame-arguments".
7572         * valprint.c (_initialize_valprint): Deprecate "set/show print
7573         raw".
7574
7575 2019-06-13  Pedro Alves  <palves@redhat.com>
7576
7577         * compile/compile.c (struct compile_options): New.
7578         (compile_flag_option_def, compile_command_option_defs)
7579         (make_compile_options_def_group): New.
7580         (compile_file_command): Handle options with
7581         gdb::option::process_options.
7582         (compile_file_command_completer): New function.
7583         (compile_code_command): Handle options with
7584         gdb::option::process_options.
7585         (compile_code_command_completer): New function.
7586         (_initialize_compiler): Install completers for "compile code" and
7587         "compile file".  Mention available options in "compile code" and
7588         "compile code"'s help.
7589         * completer.c (advance_to_completion_word): New, factored out from
7590         ...
7591         (advance_to_expression_complete_word_point): ... this.
7592         (advance_to_filename_complete_word_point): New.
7593         * completer.h (advance_to_filename_complete_word_point): New
7594         declaration.
7595
7596 2019-06-13  Pedro Alves  <palves@redhat.com>
7597
7598         * compile/compile.c: Include "cli/cli-option.h".
7599         (compile_print_value): Scope data pointer is now a
7600         value_print_options pointer; adjust.
7601         (compile_print_command): Process options.  Scope data pointer is
7602         now a value_print_options pointer; adjust.
7603         (_initialize_compile): Update "compile print"'s help to include
7604         supported options.  Install a completer for "compile print".
7605         * cp-valprint.c (show_vtblprint, show_objectprint)
7606         (show_static_field_print): Delete.
7607         (_initialize_cp_valprint): Don't install "set print
7608         static-members", "set print vtbl", "set print object" here.
7609         * printcmd.c: Include "cli/cli-option.h" and
7610         "common/gdb_optional.h".
7611         (print_command_parse_format): Rework to fill in a
7612         value_print_options instead of a format_data.
7613         (print_value): Change parameter type from format_data pointer to
7614         value_print_options reference.  Adjust.
7615         (print_command_1): Process options.  Adjust to pass down a
7616         value_print_options.
7617         (print_command_completer): New.
7618         (_initialize_printcmd): Install print_command_completer as
7619         handle_brkchars completer for the "print" command.  Update
7620         "print"'s help to include supported options.
7621         * valprint.c: Include "cli/cli-option.h".
7622         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7623         here from cp-valprint.c.
7624         (boolean_option_def, uinteger_option_def)
7625         (value_print_option_defs, make_value_print_options_def_group):
7626         New.  Use gdb::option::add_setshow_cmds_for_options to install
7627         "set print elements", "set print null-stop", "set print repeats",
7628         "set print pretty", "set print union", "set print array", "set
7629         print address", "set print symbol", "set print array-indexes".
7630         * valprint.h: Include <string> and "cli/cli-option.h".
7631         (make_value_print_options_def_group): Declare.
7632         (print_value): Change parameter type from format_data pointer to
7633         value_print_options reference.
7634         (print_command_completer): Declare.
7635
7636 2019-06-13  Pedro Alves  <palves@redhat.com>
7637
7638         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7639         (COMMON_SFILES): Add maint-test-settings.c.
7640         * cli/cli-decode.c (boolean_enums): New global, factored out from
7641         ...
7642         (add_setshow_boolean_cmd): ... here.
7643         * cli/cli-decode.h (boolean_enums): Declare.
7644         * cli/cli-option.c: New file.
7645         * cli/cli-option.h: New file.
7646         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7647         factored out from ...
7648         (parse_cli_boolean_value(const char *)): ... this.
7649         (is_unlimited_literal): Change parameter type to pointer to
7650         pointer.  Adjust and advance ARG pointer.
7651         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7652         (parse_cli_var_enum): New, factored out from ...
7653         (do_set_command): ... this.  Adjust.
7654         * cli/cli-setshow.h (parse_cli_boolean_value)
7655         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7656         (parse_cli_var_enum): Declare.
7657         * cli/cli-utils.c: Include "cli/cli-option.h".
7658         (get_ulongest): New.
7659         * cli/cli-utils.h (get_ulongest): Declare.
7660         (check_for_argument): New overloads.
7661         * maint-test-options.c: New file.
7662
7663 2019-06-13  Pedro Alves  <palves@redhat.com>
7664
7665         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7666         parse a range if "-" is at the end of the string.
7667
7668 2019-06-13  Pedro Alves  <palves@redhat.com>
7669
7670         * cli/cli-setshow.c (parse_auto_binary_operation)
7671         (parse_cli_boolean_value): Don't allow "o".
7672
7673 2019-06-13  Pedro Alves  <palves@redhat.com>
7674
7675         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7676         * NEWS: Mention maint test-settings KIND.
7677         * maint-test-settings.c: New file.
7678
7679 2019-06-13  Pedro Alves  <palves@redhat.com>
7680
7681         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7682         completer.
7683         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7684         "set" completers.
7685
7686 2019-06-13  Pedro Alves  <palves@redhat.com>
7687
7688         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7689         after item.
7690
7691 2019-06-13  Pedro Alves  <palves@redhat.com>
7692
7693         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7694
7695 2019-06-13  Pedro Alves <palves@redhat.com>
7696
7697         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7698         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7699         call.
7700         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7701         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7702         calls.
7703         (check_for_argument): Skip spaces after argument.
7704
7705 2019-06-13  Pedro Alves  <palves@redhat.com>
7706
7707         * thread.c (thread_apply_command): Adjust TID parsing.
7708         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7709         detected before end of string.
7710         (tid_is_in_list): Error out if LIST is invalid.
7711
7712 2019-06-13  Pedro Alves  <palves@redhat.com>
7713
7714         * completer.c (complete_line_internal_1): Rewind completion word
7715         point.
7716         (completion_tracker::advance_custom_word_point_by): Change
7717         parameter type to int.
7718         * completer.h (completion_tracker::advance_custom_word_point_by):
7719         Likewise.
7720
7721 2019-06-13  Pedro Alves  <palves@redhat.com>
7722
7723         * completer.c (advance_to_completion_word): Handle delimiters.
7724
7725 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7726
7727         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7728
7729 2019-06-11  Tom Tromey  <tom@tromey.com>
7730
7731         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7732         (xmalloc_failed): Move to alloc.c.
7733         * alloc.c: New file.
7734         * Makefile.in (COMMON_SFILES): Add alloc.c.
7735
7736 2019-06-11  Tom Tromey  <tom@tromey.com>
7737
7738         * nat/linux-waitpid.c: Don't include server.h.
7739         (linux_debug): Remove.
7740         (my_waitpid): Update.
7741
7742 2019-06-11  Tom Tromey  <tromey@adacore.com>
7743
7744         * infcall.c (_initialize_infcall): Remove trailing newline from
7745         help.
7746         * user-regs.c (_initialize_user_regs): Remove trailing newline
7747         from help.
7748         * typeprint.c (_initialize_typeprint): Remove trailing newline
7749         from help.
7750         * reverse.c (_initialize_reverse): Remove trailing newlines from
7751         help.
7752         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7753         from help.
7754         * language.c (add_set_language_command): Remove trailing newline
7755         from help.
7756         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7757         help.
7758         * disasm.c (_initialize_disasm): Remove trailing newline from
7759         help.
7760         * top.c (init_main): Remove trailing newline from help.
7761         * interps.c (_initialize_interpreter): Remove trailing newline
7762         from help.
7763         * btrace.c (_initialize_btrace): Remove trailing newlines from
7764         help.
7765         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7766         from help.
7767         * python/python.c (_initialize_python): Remove trailing newline
7768         from help.
7769         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7770         help.
7771         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7772         from help.  Reformat some text.
7773         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7774         from help.
7775         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7776         newline from help.
7777
7778 2019-06-11  Tom Tromey  <tromey@adacore.com>
7779
7780         * darwin-nat.c (darwin_decode_exception_message)
7781         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7782
7783 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * valops.c (value_slice): Check for not allocated or not
7786         associated values.
7787
7788 2019-06-10  Tom de Vries  <tdevries@suse.de>
7789
7790         PR gdb/24618
7791         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7792         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7793         invalid.
7794
7795 2019-06-10  Tom de Vries  <tdevries@suse.de>
7796
7797         PR gdb/24611
7798         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7799         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7800
7801 2019-06-10  Tom de Vries  <tdevries@suse.de>
7802
7803         PR symtab/24545
7804         * symtab.c (struct demangled_name_entry): Add language field.
7805         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7806         static minimal symbol".  Set and use language field.
7807
7808 2019-06-10  Tom Tromey  <tromey@adacore.com>
7809
7810         * ada-lang.c (_initialize_ada_language): Update help text.
7811
7812 2019-06-10  Tom Tromey  <tromey@adacore.com>
7813
7814         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7815         with a newline.
7816         * guile/guile.c (handle_boot_error): Don't end warning with a
7817         newline.
7818         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7819         warning with a newline.
7820         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7821         newline.
7822         (s12z_frame_cache): Likewise.
7823         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7824         a newline.
7825         * solib-svr4.c (disable_probes_interface): Don't end warning with
7826         a newline.
7827         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7828         newline.
7829         * python/python.c (do_finish_initialization): Don't end warning
7830         with a newline.
7831
7832 2019-06-10  Tom Tromey  <tom@tromey.com>
7833
7834         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7835         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7836         gdbpy_enter.
7837
7838 2019-06-10  Tom Tromey  <tromey@adacore.com>
7839
7840         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7841         data.
7842         (elf_new_init): Don't call stabsread_new_init.
7843         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7844         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7845         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7846
7847 2019-06-10  Tom de Vries  <tdevries@suse.de>
7848
7849         PR symtab/16264
7850         PR symtab/24517
7851         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7852
7853 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7854
7855         * source.c (find_and_open_source): Also rewrite relative file
7856         names.
7857
7858 2019-04-26  Amos Bird  <amosbird@gmail.com>
7859
7860         * annotate.c (annotate_thread_exited): Add "thread-exited"
7861         annotation.
7862
7863 2019-06-06  Tom Tromey  <tromey@adacore.com>
7864
7865         * maint.h (class scoped_command_stats): Use
7866         DISABLE_COPY_AND_ASSIGN.
7867         <print_time>: New method.
7868         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7869         print_time.
7870         (scoped_command_stats::print_time): New method.
7871
7872 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7875         instructions of lengths 6 or 8 bytes.
7876
7877 2019-06-04  Pedro Alves  <palves@redhat.com>
7878
7879         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7880
7881         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7882         * breakpoint.c (condition_completer): Likewise.
7883         * cli/cli-dump.c (scan_expression): Likewise.
7884         * common/filestuff.c (mkdir_recursive): Likewise.
7885         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7886         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7887         (gdb_abspath): Likewise.
7888         * compile/compile-cplus-types.c
7889         (compile_cplus_instance::decl_name): Likewise.
7890         * completer.c (complete_explicit_location):
7891         (signal_completer, reg_or_group_completer_1): Likewise.
7892         * cp-support.c (cp_remove_params_if_any): Likewise.
7893         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7894         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7895         * infcmd.c (strip_bg_char): Likewise.
7896         * linespec.c (copy_token_string): Likewise.
7897         * mi/mi-main.c (output_cores): Likewise.
7898         * psymtab.c (psymtab_search_name):
7899         * symfile.c (test_set_ext_lang_command): Likewise.
7900         * target.c (target_fileio_read_stralloc): Likewise.
7901         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7902         * value.c (complete_internalvar): Likewise.
7903
7904 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7905
7906         Add objfile property to gdb.Type.
7907         * NEWS: Mention Python API addition.
7908         * python/py-type.c (typy_get_objfile): New method.
7909
7910 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7911
7912         * NEWS: Mention the new set|show style [title|highlight].
7913         Mention changes to "show style", "help" and "apropos".
7914
7915 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7916
7917         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7918         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7919         instead of print_help_for_command.
7920         (print_doc_of_command): New function.
7921         (help_list): Add 'apropos -v word' suggestion.
7922         (print_help_for_command): Style the command name using title style.
7923         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7924         (_initialize_cli_cmds): Describe -v in apropos_command help.
7925
7926 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7927
7928         * cli/cli-style.h (cli_style_option): Add name in constructor,
7929         add m_name class member, add constructor with intensity,
7930         add name class function.
7931         (cli_style_option::add_setshow_commands): Remove name argument.
7932         (highlight_style, title_style): New styles.
7933         * cli/cli-style.c (do_show): New function that shows a style
7934         characteristic styling the style name with itself.
7935         (set_style_name): New function.
7936         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7937         Update all callers according to the changes in cli/cli-style.h.
7938         * utils.h (fputs_highlighted): New function.
7939         * utils.c (fputs_highlighted): Likewise.
7940
7941 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7942
7943         * NEWS: Mention new pipe command and new convenience variables.
7944
7945 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946
7947         * cli/cli-cmds.c (pipe_command): New function.
7948         (_initialize_cli_cmds): Call add_com for pipe_command.
7949         Define | as an alias for pipe.
7950         (exit_status_set_internal_vars): New function.
7951         (shell_escape): Call exit_status_set_internal_vars.
7952         cli/cli-decode.c (find_command_name_length): Recognize | as
7953         a single character command.
7954
7955 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7956
7957         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7958         top.c (execute_command_to_ui_file): New function, mostly a copy
7959         of execute_command_to_string.
7960         (execute_command_to_string): Implement by calling
7961         execute_command_to_ui_file.
7962
7963 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7964
7965         * top.h (saved_command_line): Remove declaration.
7966         * top.c (previous_saved_command_line, previous_repeat_arguments):
7967         New variables.
7968         (saved_command_line): Make static, define together with other
7969         'repeat variables'.
7970         (dont_repeat): Clear repeat_arguments.
7971         (repeat_previous, get_saved_command_line, save_command_line):
7972         New functions.
7973         (gdb_init): Initialize saved_command_line
7974         and previous_saved_command_line.
7975         * main.c (captured_main_1): Remove saved_command_line initialization.
7976         * event-top.c (handle_line_of_input): Update to use
7977         the new 'repeat' related functions instead of direct access to
7978         saved_command_line.
7979         * command.h (repeat_previous, get_saved_command_line,
7980         save_command_line): New declarations.
7981         (dont_repeat): Add comment.
7982
7983 2019-05-30  Tom Tromey  <tromey@adacore.com>
7984
7985         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7986         Fix comment.
7987         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7988
7989 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7990
7991         PR cli/24587
7992         * completer.c (complete): Initialize variable word.
7993
7994 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7995
7996         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7997         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7998         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7999         'body' is NULL to the outter 'if', protecting the '!is_define'
8000         situation as well.
8001
8002 2019-05-29  Tom Tromey  <tromey@adacore.com>
8003
8004         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8005         (dwarf_unknown): New function.
8006         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8007         (dwarf_type_encoding_name): Use dwarf_unknown.
8008
8009 2019-05-29  Tom Tromey  <tromey@adacore.com>
8010
8011         PR c++/20020:
8012         * cp-valprint.c (cp_print_value_fields): Call
8013         cp_print_static_field inside "try".
8014
8015 2019-05-29  Tom Tromey  <tromey@adacore.com>
8016
8017         * inflow.c (struct terminal_info): Add default operator=.
8018         * configure: Rebuild.
8019         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8020         -Wdeprecated-copy-dtor, -Wredundant-move.
8021
8022 2019-05-29  Tom Tromey  <tromey@adacore.com>
8023
8024         * NEWS: Add entry.
8025         * infcmd.c (print_return_value_1): Handle finish_print
8026         option.
8027         (show_print_finish): New function.
8028         (_initialize_infcmd): Add "set/show print finish" commands.
8029         * valprint.c (user_print_options): Initialize new member.
8030         * valprint.h (struct value_print_options) <finish_print>: New
8031         member.
8032
8033 2019-05-28  Tom Tromey  <tromey@adacore.com>
8034
8035         * ada-lang.c (ada_remove_Xbn_suffix)
8036         (find_old_style_renaming_symbol)
8037         (parse_old_style_renaming): Remove.
8038         (ada_find_renaming_symbol): Don't call
8039         find_old_style_renaming_symbol.
8040         (ada_is_renaming_symbol): Rename from
8041         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8042         bool.  Now static.
8043         (ada_read_var_value): Update and simplify.
8044         * ada-exp.y (write_var_or_type): Remove old code.
8045
8046 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8047
8048         PR gdb/25010
8049         * event-top.c: Remove include comment.
8050         * inflow.c (class scoped_ignore_sigttou): Move from here...
8051         * inflow.h (class scoped_ignore_sigttou): ...to here.
8052         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8053         * top.c:  Remove include comment.
8054
8055 2019-05-27  Tom Tromey  <tom@tromey.com>
8056
8057         * NEWS: Fix typo.
8058
8059 2019-05-22  Tom Tromey  <tromey@adacore.com>
8060
8061         * target.c (target_follow_exec): Constify parameter.
8062         * target-delegates.c: Rebuild.
8063         * remote.c (remote_target::follow_exec): Constify parameter.
8064         * infrun.c (follow_exec): Constify parameter.
8065         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8066         (target_follow_exec): Likewise.
8067
8068 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8069
8070         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8071         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8072
8073 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8074
8075         * NEWS: Add debugredirect and testsuite sections.
8076
8077 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8078
8079         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8080         target descriptions using exclusively floating point register name
8081         aliases.
8082
8083 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         PR gdb/18644:
8086         * f-lang.c (build_fortran_types): Handle the case where
8087         gdbarch_floatformat_for_type returns a nullptr.
8088
8089 2019-05-21  Tom de Vries  <tdevries@suse.de>
8090
8091         PR cli/24587
8092         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8093
8094 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         PR gdb/18644:
8097         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8098         16-byte floats.
8099         * i386-tdep.c (i386_floatformat_for_type): Use
8100         floatformats_ia64_quad for the 16-byte floating point component
8101         within a fortran 32-byte complex number.
8102
8103 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8104
8105         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8106         delete default constructor.
8107         (find_partial_die): Update to return const struct.
8108         (partial_die_parent_scope): Move variable declaration into scope
8109         of its use and change its type to auto.
8110         (guess_partial_die_structure_name): Likewise.
8111         (partial_die_info::fixup): Likewise.
8112
8113 2019-05-17  Tom Tromey  <tromey@adacore.com>
8114
8115         * source.c (find_and_open_source): Remove cast.
8116
8117 2019-05-17  Tom Tromey  <tromey@adacore.com>
8118
8119         * annotate.c (annotate_source): Make "filename" const.
8120         * annotate.h (annotate_source): Use const.
8121
8122 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8123
8124         * disasm.c (set_disassembler_options): Send errors to stderr.
8125
8126 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8127
8128         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8129         (cli_interp_base::set_logging): Check debug_redirect.
8130         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8131         * cli/cli-logging.c (debug_redirect): Add static variable.
8132         (pop_output_files): Add default param.
8133         (handle_redirections): Print debug setting.
8134         (show_logging_command): Likewise.
8135         (_initialize_cli_logging): Add debugredirect command.
8136         * interps.c (current_interp_set_logging): Add debug_redirect
8137         parameter.
8138         * interps.h (set_logging): Add debug_redirect parameter.
8139         (current_interp_set_logging): Likewise.
8140         * mi/mi-common.h: Likewise.
8141         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8142
8143 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8144             Tom Tromey  <tromey@adacore.com>
8145
8146         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8147         directly.
8148         * cli/cli-interp.h (make_logging_output): Remove declaration.
8149         * cli/cli-logging.c (make_logging_output): Remove function.
8150         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8151         directly.
8152         * ui-file.c (tee_file::tee_file): Remove bools.
8153         (tee_file::~tee_file): Remove deletes.
8154         * ui-file.h (tee_file): Remove bools.
8155
8156 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8157
8158         * mi/mi-cmds.h (mi_cmd_complete): New function.
8159         * mi/mi-main.c (mi_cmd_complete): Likewise.
8160         * mi/mi-cmds.c: Define new MI command -complete.
8161         * NEWS: Mention new -complete command.
8162
8163 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8164
8165         * completer.h (complete): New function.
8166         * completer.c (complete): Likewise.
8167         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8168         function defined in completer.h.
8169
8170 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8171
8172         * MAINTAINERS (Write After Approval): Add myself.
8173
8174 2019-05-17  Tom de Vries  <tdevries@suse.de>
8175
8176         PR gdb/24094
8177         * dwarf2read.c (struct cu_partial_die_info): New struct.
8178         (find_partial_die): Return cu_partial_die_info.
8179         (partial_die_parent_scope, guess_partial_die_structure_name)
8180         (partial_die_info::fixup): Handle new return type of find_partial_die.
8181
8182 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8183
8184         PR breakpoints/24541
8185         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8186         "std::string", simplifying the algorithm.
8187
8188 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8189
8190         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8191         (stap_static_probe_ops::get_probes): Likewise.
8192
8193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8194
8195         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8196         '-')" and "else if".
8197         (stap_parse_single_operand): Join checks for
8198         "gdbarch_stap_parse_special_token_p" and
8199         "gdbarch_stap_parse_special_token" in the same "if" statement.
8200         Invert check when verifying for operation on register
8201         displacement.
8202
8203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8204
8205         * stap-probe.c (stap_get_opcode): Update comment.
8206         (stap_get_expected_argument_type): Likewise.
8207         (handle_stap_probe): Likewise.
8208
8209 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8210
8211         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8212         return type to 'bool'.  Adjust comment.  Use 'bool' when
8213         appropriate.
8214         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8215         * stap-probe.c (stap_parse_argument_1): Likewise.
8216         (stap_is_operator): Likewise.
8217         (stap_is_generic_prefix): Likewise.
8218         (stap_is_register_prefix): Likewise.
8219         (stap_is_register_indirection_prefix): Likewise.
8220         (stap_is_integer_prefix): Likewise.
8221         (stap_generic_check_suffix): Likewise.
8222         (stap_check_integer_suffix): Likewise.
8223         (stap_check_register_suffix): Likewise.
8224         (stap_check_register_indirection_suffix): Likewise.
8225         (stap_parse_register_operand): Likewise.
8226         (stap_parse_single_operand): Likewise.
8227         (stap_parse_argument_1): Likewise.
8228         (stap_probe::get_argument_count): Likewise.
8229         (stap_is_operator): Likewise.
8230
8231 2019-05-16  Tom Tromey  <tromey@adacore.com>
8232
8233         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8234         keyword to foreach.
8235
8236 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8237
8238         * linux-thread-db.c (try_thread_db_load_1): Change return type
8239         to bool.
8240         (try_thread_db_load): Likewise.
8241         (try_thread_db_load_from_pdir_1): Likewise.
8242         (try_thread_db_load_from_pdir): Likewise.
8243         (try_thread_db_load_from_sdir): Likewise.
8244         (try_thread_db_load_from_dir): Likewise.
8245         (thread_db_load_search): Likewise.
8246         (has_libpthread): Likewise.
8247         (thread_db_load): Likewise.
8248
8249 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8250
8251         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8252         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8253         NULL, and complain/return if that's the case.
8254
8255 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8256
8257         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8258         (advance, posn, abstract_read_memory): New functions.
8259         [struct mem_read_abstraction]: New struct.
8260         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8261
8262 2019-05-14  Tom Tromey  <tromey@adacore.com>
8263
8264         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8265         value is not lval_memory.
8266
8267 2019-05-14  Tom Tromey  <tromey@adacore.com>
8268
8269         * solib.c (info_sharedlibrary_command): Style the file name.
8270
8271 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8272
8273         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8274         (aarch64_vnv_type): Likewise.
8275         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8276         * common/tdesc.c: Likewise.
8277         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8278         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8279         * features/aarch64-fpu.xml: Add ieee half view.
8280         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8281         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8282         * gdbtypes.h (struct builtin_type): Likewise.
8283         (struct objfile_type): Likewise.
8284
8285 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8286
8287         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8288         typo.
8289         * location.h (string_to_event_location): Likewise.
8290
8291 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8292
8293         GDB 8.3 released.
8294
8295 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8296
8297         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8298         New variable declaration.
8299         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8300         New variable.
8301         (print_one_breakpoint): Use ui_out::test_flags and new global
8302         variable to compute use_fixed_output.
8303         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8304         Remove.
8305         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8306         (mi_multi_location_breakpoint_output_fixed): Remove.
8307         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8308         new variable.
8309         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8310         fix_multi_location_breakpoint_output flag if version >= 3.
8311         * ui-out.h (enum ui_out_flag)
8312         <fix_multi_location_breakpoint_output>: New enumerator.
8313
8314 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8315
8316         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8317
8318 2019-05-10  Tom Tromey  <tromey@adacore.com>
8319
8320         * ada-lang.c (catch_ada_completer): New function.
8321         (_initialize_ada_language): Use it.
8322
8323 2019-05-10  Tom Tromey  <tromey@adacore.com>
8324
8325         * thread.c (print_thread_info): Make "requested_threads" const.
8326         * gdbthread.h (print_thread_info): Make "requested_threads"
8327         const.
8328         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8329         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8330
8331 2019-05-08  Tom Tromey  <tom@tromey.com>
8332
8333         * gdbtypes.c (objfile_type_data): Change type.
8334         (objfile_type, _initialize_gdbtypes): Update.
8335
8336 2019-05-08  Tom Tromey  <tom@tromey.com>
8337
8338         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8339         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8340         (_initialize_dwarf2_frame): Update.
8341
8342 2019-05-08  Tom Tromey  <tom@tromey.com>
8343
8344         * objc-lang.c (objc_objfile_data): Change type.
8345         (find_methods): Update.
8346         (_initialize_objc_lang): Remove.
8347
8348 2019-05-08  Tom Tromey  <tom@tromey.com>
8349
8350         * stabsread.c (rs6000_builtin_type_data): Change type.
8351         (rs6000_builtin_type, _initialize_stabsread): Update.
8352
8353 2019-05-08  Tom Tromey  <tom@tromey.com>
8354
8355         * mips-tdep.c (mips_pdr_data): Remove.
8356         (_initialize_mips_tdep): Update.
8357
8358 2019-05-08  Tom Tromey  <tom@tromey.com>
8359
8360         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8361         (hppa_init_objfile_priv_data, read_unwind_info)
8362         (find_unwind_entry, _initialize_hppa_tdep): Update.
8363
8364 2019-05-08  Tom Tromey  <tom@tromey.com>
8365
8366         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8367         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8368         on obstack.
8369         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8370
8371 2019-05-08  Tom Tromey  <tom@tromey.com>
8372
8373         * mdebugread.c (basic_type_data): Change type.
8374         (basic_type, _initialize_mdebugread): Update.
8375
8376 2019-05-08  Tom Tromey  <tom@tromey.com>
8377
8378         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8379
8380 2019-05-08  Tom Tromey  <tom@tromey.com>
8381
8382         * nto-tdep.c (nto_inferior_data_reg): Change type.
8383         (nto_inferior_data): Update.
8384         (nto_inferior_data_cleanup, nto_new_inferior_data)
8385         (_initialize_nto_tdep): Remove.
8386         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8387
8388 2019-05-08  Tom Tromey  <tom@tromey.com>
8389
8390         * ada-lang.c (struct ada_inferior_data): Add initializers.
8391         (ada_inferior_data): Change type.
8392         (ada_inferior_data_cleanup): Remove.
8393         (get_ada_inferior_data, ada_inferior_exit)
8394         (struct ada_pspace_data): Add initializers, destructor.
8395         (ada_pspace_data_handle): Change type.
8396         (get_ada_pspace_data): Update.
8397         (ada_pspace_data_cleanup): Remove.
8398
8399 2019-05-08  Tom Tromey  <tom@tromey.com>
8400
8401         * coffread.c (struct coff_symfile_info): Add initializers.
8402         (coff_objfile_data_key): Move lower.  Change type.
8403         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8404         Update.
8405         (coff_free_info): Remove.
8406
8407 2019-05-08  Tom Tromey  <tom@tromey.com>
8408
8409         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8410         (fbsd_pspace_data_handle): Move lower.  Change type.
8411         (get_fbsd_pspace_data): Update.
8412         (fbsd_pspace_data_cleanup): Remove.
8413         (_initialize_fbsd_tdep): Update.
8414
8415 2019-05-08  Tom Tromey  <tom@tromey.com>
8416
8417         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8418         (get_ada_tasks_pspace_data): Update.
8419         (ada_tasks_pspace_data_cleanup): Remove.
8420         (_initialize_tasks): Update.
8421         (ada_tasks_inferior_data_handle): Change type.
8422         (get_ada_tasks_inferior_data): Update.
8423         (ada_tasks_inferior_data_cleanup): Remove.
8424         (struct ada_tasks_pspace_data): Add initializers.
8425
8426 2019-05-08  Tom Tromey  <tom@tromey.com>
8427
8428         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8429         * symfile-debug.c (debug_sym_get_probes): Change type.
8430         * stap-probe.c (handle_stap_probe):
8431         (stap_static_probe_ops::get_probes): Change type.
8432         * probe.h (class static_probe_ops) <get_probes>: Change type.
8433         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8434         (parse_probes_in_pspace): Update.
8435         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8436         Update.
8437         (any_static_probe_ops::get_probes): Change type.
8438         * elfread.c (elfread_data): New typedef.
8439         (probe_key): Change type.
8440         (elf_get_probes): Likewise.  Update.
8441         (probe_key_free): Remove.
8442         (_initialize_elfread): Update.
8443         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8444         Change type.
8445         (dtrace_process_dof_probe, dtrace_process_dof)
8446         (dtrace_static_probe_ops::get_probe): Change type.
8447
8448 2019-05-08  Tom Tromey  <tom@tromey.com>
8449
8450         * xcoffread.c (struct xcoff_symfile_info): Rename from
8451         coff_symfile_info.  Add initializers.
8452         (xcoff_objfile_data_key): Move lower.  Change type.
8453         (XCOFF_DATA): Rewrite.
8454         (xcoff_free_info): Remove.
8455         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8456         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8457         (xcoff_initial_scan): Update.
8458
8459 2019-05-08  Tom Tromey  <tom@tromey.com>
8460
8461         * solib-svr4.c (struct svr4_info): Add initializers and
8462         destructor.
8463         <probes_table>: Now an htab_up.
8464         (solib_svr4_pspace_data): Change type.
8465         (free_probes_table): Simplify.
8466         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8467         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8468         (probes_table_remove_objfile_probes, register_solib_event_probe)
8469         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8470         (_initialize_svr4_solib): Update.
8471
8472 2019-05-08  Tom Tromey  <tom@tromey.com>
8473
8474         * remote.c (remote_pspace_data): Change type.
8475         (remote_pspace_data_cleanup): Remove.
8476         (get_remote_exec_file, set_pspace_remote_exec_file)
8477         (_initialize_remote): Update.
8478
8479 2019-05-08  Tom Tromey  <tom@tromey.com>
8480
8481         * breakpoint.c (breakpoint_objfile_key): Change type.
8482         (get_breakpoint_objfile_data): Update.
8483         (free_breakpoint_objfile_data): Remove.
8484         (_initialize_breakpoint): Update.
8485
8486 2019-05-08  Tom Tromey  <tom@tromey.com>
8487
8488         * linux-tdep.c (struct linux_info): Add initializers.
8489         (linux_inferior_data): Move.  Change type.
8490         (invalidate_linux_cache_inf): Update.
8491         (linux_inferior_data_cleanup): Remove.
8492         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8493
8494 2019-05-08  Tom Tromey  <tom@tromey.com>
8495
8496         * auxv.c (auxv_inferior_data): Move.  Change type.
8497         (auxv_inferior_data_cleanup): Remove.
8498         (invalidate_auxv_cache_inf): Rewrite.
8499         (get_auxv_inferior_data, _initialize_auxv): Update.
8500
8501 2019-05-08  Tom Tromey  <tom@tromey.com>
8502
8503         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8504         (symfile_debug_objfile_data_key): Change type.
8505         (symfile_debug_installed, debug_qf_has_symbols)
8506         (debug_qf_find_last_source_symtab)
8507         (debug_qf_forget_cached_source_info)
8508         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8509         (debug_qf_print_stats, debug_qf_dump)
8510         (debug_qf_expand_symtabs_for_function)
8511         (debug_qf_expand_all_symtabs)
8512         (debug_qf_expand_symtabs_with_fullname)
8513         (debug_qf_map_matching_symbols)
8514         (debug_qf_expand_symtabs_matching)
8515         (debug_qf_find_pc_sect_compunit_symtab)
8516         (debug_qf_map_symbol_filenames)
8517         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8518         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8519         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8520         (debug_sym_read_linetable, debug_sym_relocate): Update.
8521         (symfile_debug_free_objfile): Remove.
8522         (install_symfile_debug_logging, _initialize_symfile_debug):
8523         Update.
8524
8525 2019-05-08  Tom Tromey  <tom@tromey.com>
8526
8527         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8528         allocate_on_obstack.
8529         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8530         (get_dwarf2_per_objfile): Update.
8531         (set_dwarf2_per_objfile): Remove.
8532         (dwarf2_has_info, dwarf2_get_section_info): Update.
8533         (dwarf2_free_objfile): Remove.
8534         (_initialize_dwarf2_read): Update.
8535
8536 2019-05-08  Tom Tromey  <tom@tromey.com>
8537
8538         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8539         initializers.
8540         <unsupported_script_warning_printed,
8541         script_not_found_warning_printed>: Now bool.
8542         (auto_load_pspace_data): Change type.
8543         (~auto_load_pspace_info): Rename from
8544         auto_load_pspace_data_cleanup.
8545         (get_auto_load_pspace_data, init_loaded_scripts_info)
8546         (clear_section_scripts, maybe_print_unsupported_script_warning)
8547         (maybe_print_script_not_found_warning, _initialize_auto_load):
8548         Update.
8549
8550 2019-05-08  Tom Tromey  <tom@tromey.com>
8551
8552         * objfiles.c (objfile_pspace_info): Add destructor and
8553         initializers.
8554         (objfiles_pspace_data): Change type.
8555         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8556         (get_objfile_pspace_data): Update.
8557         (objfiles_bfd_data): Change type.
8558         (get_objfile_bfd_data): Update.
8559         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8560
8561 2019-05-08  Tom Tromey  <tom@tromey.com>
8562
8563         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8564         Change type.
8565         (get_catch_syscall_inferior_data): Update.
8566         (catch_syscall_inferior_data_cleanup): Remove.
8567         (_initialize_break_catch_syscall): Update.
8568
8569 2019-05-08  Tom Tromey  <tom@tromey.com>
8570
8571         * inflow.c (struct terminal_info): Add destructor and
8572         initializers.
8573         (inflow_inferior_data): Change type.
8574         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8575         (get_inflow_inferior_data, inflow_inferior_exit)
8576         (swap_terminal_info, _initialize_inflow): Update.
8577
8578 2019-05-08  Tom Tromey  <tom@tromey.com>
8579
8580         * target-dcache.c (target_dcache_cleanup): Remove.
8581         (target_dcache_aspace_key): Change type.
8582         (target_dcache_init_p, target_dcache_invalidate)
8583         (target_dcache_get, target_dcache_get_or_init)
8584         (_initialize_target_dcache): Update.
8585         * dcache.h (struct dcache_deleter): New.
8586
8587 2019-05-08  Tom Tromey  <tom@tromey.com>
8588
8589         * symtab.c (struct symbol_cache): Add destructor and
8590         initializers.
8591         (symbol_cache_key): Move.  Change type.
8592         (make_symbol_cache, free_symbol_cache): Remove.
8593         (get_symbol_cache): Update.
8594         (symbol_cache_cleanup): Remove.
8595         (ALL_PSPACES, symbol_cache_flush)
8596         (maintenance_print_symbol_cache)
8597         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8598         Update.
8599
8600 2019-05-08  Tom Tromey  <tom@tromey.com>
8601
8602         * symtab.c (struct main_info): Add destructor and initializers.
8603         (main_progspace_key): Move.  Change type.
8604         (get_main_info): Update.
8605         (main_info_cleanup): Remove.
8606         (_initialize_symtab): Update.
8607
8608 2019-05-08  Tom Tromey  <tom@tromey.com>
8609
8610         * registry.h (DECLARE_REGISTRY): Define the _key class.
8611
8612 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8613
8614         * NEWS: Merge two 'New commands' sections.
8615
8616 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8617
8618         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8619         parameter and use Ada language definition instead.
8620         (ada_val_print_ptr): Remove unused language parameter.
8621         (ada_val_print_num): Remove language parameter and use Ada language
8622         definition instead.
8623         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8624         parameter.
8625         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8626         parameter and use Ada language definition instead.
8627         (ada_val_print_1): Update all ada_val_print_xxx calls.
8628         Remove language parameter.
8629         (ada_val_print): Update ada_val_print_1 call.
8630
8631 2019-05-08  Tom Tromey  <tromey@adacore.com>
8632
8633         * remote.c (remote_hw_watchpoint_limit)
8634         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8635         Now static.
8636
8637 2019-05-08  Tom Tromey  <tromey@adacore.com>
8638
8639         * maint.c (_initialize_maint_cmds): Move initialization code to
8640         remote.c.
8641         (watchdog, show_watchdog): Move to remote.c.
8642         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8643         "watchdog" static.
8644         (_initialize_remote): Move initialization code from maint.c.
8645         * defs.h (watchdog): Don't declare.
8646
8647 2019-05-08  Tom Tromey  <tromey@adacore.com>
8648
8649         * tui/tui-interp.c: Include main.h.
8650         * interps.c: Include main.h.
8651         * main.h (interpreter_p): Declare.
8652         * defs.h (interpreter_p): Don't declare.
8653
8654 2019-05-08  Tom Tromey  <tromey@adacore.com>
8655
8656         * dwarf2loc.c: Include dwarf2read.h.
8657         * defs.h (read_unsigned_leb128): Don't declare.
8658         * dwarf2read.h (read_unsigned_leb128): Declare.
8659
8660 2019-05-08  Tom Tromey  <tromey@adacore.com>
8661
8662         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8663         method.
8664
8665 2019-05-08  Tom Tromey  <tromey@adacore.com>
8666
8667         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8668         when no wrap column is set.
8669
8670 2019-05-08  Tom Tromey  <tromey@adacore.com>
8671
8672         * c-lang.c (c_get_string): Handle non-C-style arrays.
8673
8674 2019-05-08  Tom Tromey  <tromey@adacore.com>
8675
8676         * typeprint.c (print_offset_data::update): Print the bit offset,
8677         not the number of bits remaining.
8678
8679 2019-05-08  Tom Tromey  <tromey@adacore.com>
8680
8681         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8682         padding at end of comment.
8683
8684 2019-05-08  Tom Tromey  <tromey@adacore.com>
8685
8686         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8687         Compare main types.
8688
8689 2019-05-06  Tom Tromey  <tom@tromey.com>
8690
8691         * common/scoped_mmap.c: Include common-defs.h.
8692         * common/scoped_mmap.h: Don't include config.h.
8693
8694 2019-05-04  Tom Tromey  <tom@tromey.com>
8695
8696         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8697         (struct aarch64_call_info): Add initializers.
8698         <si>: Now a std::vector.
8699         (pass_on_stack, aarch64_push_dummy_call): Update.
8700
8701 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8702             Tom Tromey  <tom@tromey.com>
8703
8704         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8705         (ppc_threads): Now a std::vector.  Now static.
8706         (hwdebug_find_thread_points_by_tid)
8707         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8708         Update.
8709
8710 2019-05-04  Tom Tromey  <tom@tromey.com>
8711
8712         * arc-tdep.c (arc_tdesc_init): Return bool.
8713
8714 2019-05-04  Tom Tromey  <tom@tromey.com>
8715
8716         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8717         Use gdb_assert_not_reached.
8718
8719 2019-05-04  Tom Tromey  <tom@tromey.com>
8720
8721         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8722         "false".
8723
8724 2019-05-04  Tom Tromey  <tom@tromey.com>
8725
8726         * arc-tdep.c (arc_tdesc_init): Use bool.
8727
8728 2019-05-04  Tom Tromey  <tom@tromey.com>
8729
8730         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8731
8732 2019-05-04  Tom Tromey  <tom@tromey.com>
8733
8734         * cli/cli-cmds.c (valid_command_p): Return bool.
8735
8736 2019-05-04  Tom Tromey  <tom@tromey.com>
8737
8738         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8739         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8740
8741 2019-05-04  Raul Tambre  <raul@tambre.ee>
8742
8743         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8744         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8745         operator for comparison.
8746
8747 2019-05-04  Tom Tromey  <tom@tromey.com>
8748
8749         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8750         (lookup_partial_symbol, print_partial_symbols)
8751         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8752         (psymbol_compare): Update.
8753         (add_psymbol_to_bcache): Clear the entire psymbol.
8754         (maintenance_check_psymtabs): Update.
8755         * psympriv.h (struct partial_symbol): Don't derive from
8756         general_symbol_info.
8757         <obj_section, unrelocated_address, address,
8758         set_unrelocated_address>: Update.
8759         <ginfo>: New member.
8760         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8761         (debug_names::write_psymbols): Update.
8762
8763 2019-05-04  Tom de Vries  <tdevries@suse.de>
8764
8765         * contrib/cc-with-tweaks.sh: Support -n arg.
8766
8767 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8768
8769         * corelow.c (core_target::detach): Ensure frame cache and
8770         register caches are cleared.
8771         inferior.c (exit_inferior_1): Likewise.
8772
8773 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8774             Tom Tromey  <tom@tromey.com>
8775
8776         * dictionary.c (collate_pending_symbols_by_language): Remove
8777         "struct" from foreach.
8778         * symtab.c (lookup_global_symbol_from_objfile)
8779         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8780         foreach.
8781         * ser-tcp.c (net_open): Remove "struct" from foreach.
8782         * objfiles.c (objfile_relocate, objfile_rebase)
8783         (objfile_has_symbols): Remove "struct" from foreach.
8784         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8785         from foreach.
8786         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8787         foreach.
8788         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8789         "struct" from foreach.
8790         * ada-lang.c (create_excep_cond_exprs)
8791         (ada_exception_catchpoint_cond_string): Remove "struct" from
8792         foreach.
8793
8794 2019-05-03  Tom Tromey  <tromey@adacore.com>
8795
8796         * ada-exp.y (convert_char_literal): Check suffix of each
8797         enumerator.
8798
8799 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8800
8801         PR ada/21406:
8802         * ada-exp.y (yywrap): Don't define.
8803         * ada-lex.l (%option): Add noyywrap
8804         (yywrap): Remove.
8805
8806 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8807
8808         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8809         _WIN32_WINNT to the XP level, unless already defined to a higher
8810         level.
8811
8812         * unittests/parse-connection-spec-selftests.c:
8813         * ser-tcp.c:
8814         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8815         override.
8816
8817         * symfile.c (find_separate_debug_file): Remove colon from the
8818         drive spec of DOS/Windows file names of the target, so that the
8819         file name produced from DEBUGDIR and the target's directory will
8820         be valid on DOS/Windows systems.
8821
8822 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * rust-lang.c (val_print_struct): Handle printing structures
8825         containing strings.
8826
8827 2019-05-02  Tom Tromey  <tromey@adacore.com>
8828
8829         * valarith.c (_initialize_valarith): Remove.
8830
8831 2019-05-01  Tom Tromey  <tromey@adacore.com>
8832
8833         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8834         bitfields.
8835
8836 2019-05-01  Tom Tromey  <tromey@adacore.com>
8837
8838         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8839         for big-endian copies.
8840
8841 2019-04-30  Ali Tamur  <tamur@google.com>
8842         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8843         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8844         (read_3_bytes): New function.
8845
8846 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8847
8848         * windows-nat.c (main_thread_id): Delete.
8849         (handle_output_debug_string): Replace main_thread_id by
8850         current_event.dwThreadId.
8851         (fake_create_process): Likewise.
8852         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8853         Do not set main_thread_id.
8854         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8855         current_event.dwThreadId.
8856         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8857
8858 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8859
8860         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8861         Use current_event.dwThreadId instead of main_thread_id.
8862
8863 2019-04-30  Tom Tromey  <tromey@adacore.com>
8864
8865         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8866         (create_excep_cond_exprs): Iterate over program spaces.
8867         (ada_exception_catchpoint_cond_string): Examine all minimal
8868         symbols for exception types.
8869
8870 2019-04-30  Tom Tromey  <tromey@adacore.com>
8871
8872         PR c++/24470:
8873         * dwarf2read.c (process_structure_scope): Handle case where type
8874         has template parameters but no symbol was created.
8875
8876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8877             Chris January  <chris.january@arm.com>
8878
8879         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8880         qualifier.
8881         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8882
8883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8884
8885         * f-typeprint.c (f_print_type): Update rules for printing
8886         whitespace.
8887         (f_type_print_varspec_suffix): Likewise.
8888
8889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8890             Chris January  <chris.january@arm.com>
8891
8892         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8893         function arguments.
8894
8895 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * f-lang.c (build_fortran_types): Change name of void type to
8898         lower case.
8899         * f-typeprint.c (f_type_print_base): Print the name of the void
8900         type, rather than a fixed string.
8901         * f-valprint.c (f_decorations): Use lower case void string.
8902
8903 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8904             Chris January  <chris.january@arm.com>
8905
8906         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8907         types for Fortran.
8908
8909 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8910             Chris January  <chris.january@arm.com>
8911             David Lecomber  <david.lecomber@arm.com>
8912
8913         * f-exp.y (BINOP_INTRINSIC): New token.
8914         (exp): New parser rule handling BINOP_INTRINSIC.
8915         (f77_keywords): Add new builtin procedures.
8916         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8917         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8918         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8919         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8920         (print_unop_subexp_f): New function.
8921         (print_binop_subexp_f): New function.
8922         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8923         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8924         (dump_subexp_body_f): Likewise.
8925         (operator_check_f): Likewise.
8926         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8927         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8928
8929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8932         UNOP_KIND.
8933         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8934         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8935         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8936         (operator_length_f): New fuction.
8937         (print_subexp_f): New function.
8938         (op_name_f): New function.
8939         (dump_subexp_body_f): New function.
8940         (operator_check_f): New function.
8941         (exp_descriptor_f): Replace standard expression handling functions
8942         with new functions.
8943         * gdb/fortran-operator.def: New file.
8944         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8945         * gdb/std-operator.def: Remove UNOP_KIND.
8946
8947 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8948
8949         * std-operator.def: Remove unbalanced, stray double quote
8950         character.
8951
8952 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8953             Chris January  <chris.january@arm.com>
8954             Daniel Everett  <daniel.everett@arm.com>
8955             Nick Forrington  <nick.forrington@arm.com>
8956             Richard Bunt  <richard.bunt@arm.com>
8957
8958         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8959         of depth when printing anonymous structs or unions.
8960         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8961         Don't print either the top-level value, or the children if the
8962         max-depth is exceeded.
8963         (ppscm_print_children): When printing the key of a map, allow one
8964         extra level of depth.
8965         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8966         print either the top-level value, or the children if the max-depth
8967         is exceeded.
8968         (print_children): When printing the key of a map, allow one extra
8969         level of depth.
8970         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8971         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8972         (user_print_options): Initialise max_depth field.
8973         (val_print_scalar_or_string_type_p): New function.
8974         (val_print): Check to see if the max depth has been reached.
8975         (val_print_check_max_depth): Define new function.
8976         (show_print_max_depth): New function.
8977         (_initialize_valprint): Add 'print max-depth' option.
8978         * valprint.h (struct value_print_options) <max_depth>: New field.
8979         (val_print_check_max_depth): Declare new function.
8980         * NEWS: Document new feature.
8981
8982 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8983
8984         * ada-lang.c (ada_language_defn): Initialise new field.
8985         * c-lang.c (c_is_string_type_p): New function.
8986         (c_language_defn): Initialise new field.
8987         (cplus_language_defn): Initialise new field.
8988         (asm_language_defn): Initialise new field.
8989         (minimal_language_defn): Initialise new field.
8990         * c-lang.h (c_is_string_type_p): Declare new function.
8991         * d-lang.c (d_language_defn): Initialise new field.
8992         * f-lang.c (f_is_string_type_p): New function.
8993         (f_language_defn): Initialise new field.
8994         * go-lang.c (go_is_string_type_p): New function.
8995         (go_language_defn): Initialise new field.
8996         * language.c (default_is_string_type_p): New function.
8997         (unknown_language_defn): Initialise new field.
8998         (auto_language_defn): Initialise new field.
8999         * language.h (struct language_defn) <la_is_string_type_p>: New
9000         member variable.
9001         (default_is_string_type_p): Declare new function.
9002         * m2-lang.c (m2_language_defn): Initialise new field.
9003         * objc-lang.c (objc_language_defn): Initialise new field.
9004         * opencl-lang.c (opencl_language_defn): Initialise new field.
9005         * p-lang.c (pascal_is_string_type_p): New function.
9006         (pascal_language_defn): Initialise new field.
9007         * rust-lang.c (rust_is_string_type_p): New function.
9008         (rust_language_defn): Initialise new field.
9009
9010 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9011
9012         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9013         New field.
9014         * ada-lang.c (ada_language_defn): Initialise new field.
9015         * c-lang.c (c_language_defn): Likewise.
9016         (cplus_language_defn): Likewise.
9017         (asm_language_defn): Likewise.
9018         (minimal_language_defn): Likewise.
9019         * d-lang.c (d_language_defn): Likewise.
9020         * f-lang.c (f_language_defn): Likewise.
9021         * go-lang.c (go_language_defn): Likewise.
9022         * language.c (unknown_language_defn): Likewise.
9023         (auto_language_defn): Likewise.
9024         * m2-lang.c (m2_language_defn): Likewise.
9025         * objc-lang.c (objc_language_defn): Likewise.
9026         * opencl-lang.c (opencl_language_defn): Likewise.
9027         * p-lang.c (pascal_language_defn): Likewise.
9028         * rust-lang.c (rust_language_defn): Likewise.
9029
9030 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9031
9032         * ada-lang.c (ada_is_character_type): Change return type to bool.
9033         (ada_is_string_type): Likewise.
9034         * ada-lang.h (ada_is_character_type): Update declaration
9035         (ada_is_string_type): Likewise.
9036
9037 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9038
9039         Support style in 'frame|thread apply'
9040
9041         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9042         * record.c (record_start, record_stop): Update callers of
9043         execute_command_to_string with false.
9044         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9045         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9046         methods.
9047         (class string_file): New constructor with term_out parameter.
9048         Override methods term_out and can_emit_style_escape.  New member
9049         term_out.
9050         (class stdio_file): Override can_emit_style_escape.
9051         (class tee_file): Override term_out and can_emit_style_escape.
9052         * utils.h (can_emit_style_escape): Remove.
9053         * utils.c (can_emit_style_escape): Likewise.
9054         Update all callers of can_emit_style_escape (SOMESTREAM) to
9055         SOMESTREAM->can_emit_style_escape.
9056         * source-cache.c (source_cache::get_source_lines): Likewise.
9057         * stack.c (frame_apply_command_count): Call execute_command_to_string
9058         passing the term_out characteristic of the current gdb_stdout.
9059         * thread.c (thr_try_catch_cmd): Likewise.
9060         * top.c (execute_command_to_string): pass term_out parameter
9061         to construct the string_file for the command output.
9062         * ui-file.c (term_cli_styling): New function (most code moved
9063         from utils.c can_emit_style_escape).
9064         (string_file::string_file, string_file::can_emit_style_escape,
9065         stdio_file::can_emit_style_escape, tee_file::term_out,
9066         tee_file::can_emit_style_escape): New functions.
9067
9068 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9069
9070         * NEWS: Mention the new set|show may-call-functions.
9071         * infcall.c (may_call_functions_p): New variable.
9072         (show_may_call_functions_p): New function.
9073         (call_function_by_hand_dummy): Throws an error if not
9074         may-call-functions.
9075         (_initialize_infcall): Call add_setshow_boolean_cmd for
9076         may-call-functions.
9077
9078 2019-04-25  Keith Seitz  <keiths@redhat.com>
9079
9080         PR c++/24367
9081         * cp-support.c (inspect_type): Don't attempt substitutions
9082         of symbol with the same name.
9083
9084 2019-04-25  Tom Tromey  <tromey@adacore.com>
9085
9086         PR gdb/24475:
9087         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9088         static.
9089
9090 2019-04-25  Tom Tromey  <tromey@adacore.com>
9091
9092         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9093         rvalue reference.
9094         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9095         (gdb_xml_parser::parse): Use std::move.
9096         * python/python-internal.h (gdbpy_convert_exception): Take a const
9097         reference.
9098         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9099         std::move.
9100         * python/py-utils.c (gdbpy_convert_exception): Take a const
9101         reference.
9102         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9103         Use std::move.
9104         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9105         Use std::move.
9106         * mi/mi-main.c (mi_print_exception): Take a const reference.
9107         * main.c (handle_command_errors): Take a const reference.
9108         * linespec.c (parse_linespec): Use std::move.
9109         * infcall.c (run_inferior_call): Use std::move.
9110         (call_function_by_hand_dummy): Use std::move.
9111         * exec.c (try_open_exec_file): Use std::move.
9112         * exceptions.h (exception_print, exception_fprintf)
9113         (exception_print_same): Update.
9114         * exceptions.c (print_exception, exception_print)
9115         (exception_fprintf, exception_print_same): Change parameters to
9116         const reference.
9117         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9118         * common/new-op.c: Use std::move.
9119         * common/common-exceptions.h (struct gdb_exception): Add move
9120         constructor.
9121         (struct gdb_exception_error, struct gdb_exception_quit, struct
9122         gdb_quit_bad_alloc): Change constructor to move constructor.
9123         (throw_exception): Change parameter to rvalue reference.
9124         * common/common-exceptions.c (throw_exception): Take rvalue
9125         reference.
9126         * cli/cli-interp.c (safe_execute_command): Use std::move.
9127         * breakpoint.c (insert_bp_location, location_to_sals): Use
9128         std::move.
9129
9130 2019-04-25  Tom Tromey  <tromey@adacore.com>
9131
9132         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9133         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9134         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9135         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9136         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9137         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9138         guile/scm-value.c: Use unpack.
9139         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9140         gdbscm_gdb_exception.
9141         (gdbscm_throw_gdb_exception): Likewise.
9142         (struct gdbscm_gdb_exception): New.
9143         (unpack): New function.
9144         (gdbscm_wrap): Use unpack.
9145
9146 2019-04-25  Tom Tromey  <tromey@adacore.com>
9147
9148         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9149         (gdb_rl_callback_handler): Use std::move.
9150         * common/common-exceptions.h (struct gdb_exception): Add move
9151         assignment operator.
9152         (throw_exception_sjlj): Change "exception" to const reference.
9153         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9154         (throw_exception_sjlj): Change "exception" to const reference.
9155
9156 2019-04-25  Tom Tromey  <tromey@adacore.com>
9157
9158         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9159         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9160         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9161         Update.
9162         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9163         Update.
9164         * mi/mi-interp.c (mi_interp::exec): Update.
9165         * linespec.c (parse_linespec): Update.
9166         * infcall.c (run_inferior_call): Update.
9167         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9168         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9169         (gdbscm_lookup_global_symbol): Update.
9170         * guile/scm-param.c (gdbscm_parameter_value): Update.
9171         * guile/scm-frame.c (gdbscm_frame_read_register)
9172         (gdbscm_frame_read_var): Update.
9173         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9174         * exec.c (try_open_exec_file): Update.
9175         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9176         (gdb_rl_callback_handler): Update.
9177         * common/common-exceptions.h (exception_none): Don't declare.
9178         * common/common-exceptions.c (exception_none): Don't define.
9179         (struct catcher) <exception>: Update.
9180         * cli/cli-interp.c (safe_execute_command): Update.
9181         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9182
9183 2019-04-25  Ali Tamur  <tamur@google.com>
9184
9185         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9186         (read_attribute_value): Likewise.
9187         (dwarf2_read_addr_index): Update comment.
9188         (read_str_index): Add DW_FORM_strx.
9189         (dwarf2_string_attr): Likewise.
9190         (dwarf2_const_value_attr): Likewise.
9191         (dump_die_shallow): Likewise.
9192         (dwarf2_fetch_constant_bytes): Likewise.
9193         (skip_form_bytes): Likewise.
9194         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9195
9196 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9197
9198         PR corefiles/11608
9199         PR corefiles/18187
9200         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9201         OFFSET.  Verify if current mapping contains an ELF header.
9202         (linux_find_memory_regions_full): Adjust call to
9203         dump_mapping_p.
9204
9205 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9206             Kang Li <kanglictf@gmail.com>
9207
9208         PR gdb/21600
9209
9210         * dwarf2-frame.c (read_initial_length): Be consistent about using
9211         unsigned representation of length.
9212         (decode_frame_entry_1): Likewise.  Check for wraparound of
9213         end pointer as well as buffer overflow.
9214
9215 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9216
9217         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9218         "vq".
9219
9220 2019-04-24  Tom Tromey  <tromey@adacore.com>
9221
9222         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9223
9224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * s12z-tdep.c (s12z_unwind_pc): Delete.
9227         (s12z_unwind_sp): Delete.
9228         (s12z_gdbarch_init): Don't register deleted functions with
9229         gdbarch.
9230
9231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9232
9233         * rl78-tdep.c (rl78_unwind_sp): Delete.
9234         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9235
9236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9239         (xstormy16_unwind_pc): Delete.
9240         (xstormy16_dummy_id): Delete.
9241         (xstormy16_gdbarch_init): Don't register deleted functions with
9242         gdbarch.
9243
9244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9245
9246         * vax-tdep.c (vax_unwind_pc): Delete.
9247         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9248
9249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9250
9251         * v850-tdep.c (v850_unwind_sp): Delete.
9252         (v850_unwind_pc): Delete.
9253         (v850_dummy_id): Delete.
9254         (v850_gdbarch_init): Don't register deleted functions with
9255         gdbarch.
9256
9257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9258
9259         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9260         (tilegx_unwind_pc): Delete.
9261         (tilegx_unwind_dummy_id): Delete.
9262         (tilegx_gdbarch_init): Don't register deleted functions with
9263         gdbarch.
9264
9265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9266
9267         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9268         (tic6x_dummy_id): Delete.
9269         (tic6x_gdbarch_init): Don't register deleted functions with
9270         gdbarch.
9271
9272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9273
9274         * sparc-tdep.c (sparc_unwind_pc): Delete.
9275         (sparc32_gdbarch_init): Don't register deleted function with
9276         gdbarch.
9277
9278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * sh-tdep.c (sh_unwind_sp): Delete.
9281         (sh_unwind_pc): Delete.
9282         (sh_dummy_id): Delete.
9283         (sh_gdbarch_init): Don't register deleted functions with
9284         gdbarch.
9285
9286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * score-tdep.c (score_unwind_sp): Delete.
9289         (score_unwind_pc): Delete.
9290         (score_dummy_id): Delete.
9291         (score_gdbarch_init): Don't register deleted functions with
9292         gdbarch.
9293
9294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * rx-tdep.c (rx_unwind_pc): Delete.
9297         (rx_unwind_sp): Delete.
9298         (rx_dummy_id): Delete.
9299         (rx_gdbarch_init): Don't register deleted functions with
9300         gdbarch.  Update comment.
9301
9302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9303
9304         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9305         (rs6000_dummy_id): Delete.
9306         (rs6000_gdbarch_init): Don't register deleted functions with
9307         gdbarch.
9308
9309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * or1k-tdep.c (or1k_dummy_id): Delete.
9312         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9313
9314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9315
9316         * nios2-tdep.c (nios2_dummy_id): Delete.
9317         (nios2_unwind_sp): Delete.
9318         (nios2_gdbarch_init): Don't register deleted functions with
9319         gdbarch.
9320
9321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * nds32-tdep.c (nds32_dummy_id): Delete.
9324         (nds32_unwind_pc): Delete.
9325         (nds32_unwind_sp): Delete.
9326         (nds32_gdbarch_init): Don't register deleted functions with
9327         gdbarch.
9328
9329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9330
9331         * msp430-tdep.c (msp430_unwind_pc): Delete.
9332         (msp430_unwind_sp): Delete.
9333         (msp430_dummy_id): Delete.
9334         (msp430_gdbarch_init): Don't register deleted functions with
9335         gdbarch.
9336
9337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * moxie-tdep.c (moxie_unwind_sp): Delete.
9340         (moxie_unwind_pc): Delete.
9341         (moxie_dummy_id): Delete.
9342         (moxie_gdbarch_init): Don't register deleted functions with
9343         gdbarch.
9344
9345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9346
9347         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9348         (mn10300_unwind_pc): Delete.
9349         (mn10300_unwind_sp): Delete.
9350         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9351         mn10300_unwind_sp.
9352         (mn10300_frame_unwind_init): Don't register deleted functions with
9353         gdbarch.
9354
9355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * mep-tdep.c (mep_unwind_pc): Delete.
9358         (mep_unwind_sp): Delete.
9359         (mep_dummy_id): Delete.
9360         (mep_gdbarch_init): Don't register deleted functions with
9361         gdbarch.
9362
9363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9364
9365         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9366         (m68hc11_unwind_sp): Delete.
9367         (m68hc11_gdbarch_init): Don't register deleted functions with
9368         gdbarch.
9369
9370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9371
9372         * m32r-tdep.c (m32r_unwind_sp): Delete.
9373         (m32r_unwind_pc): Delete.
9374         (m32r_dummy_id): Delete.
9375         (m32r_gdbarch_init): Don't register deleted functions with
9376         gdbarch.
9377
9378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9379
9380         * m32c-tdep.c (m32c_unwind_pc): Delete.
9381         (m32c_unwind_sp): Delete.
9382         (m32c_dummy_id): Delete.
9383         (m32c_gdbarch_init): Don't register deleted functions with
9384         gdbarch.
9385
9386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9389         (lm32_unwind_pc): Delete.
9390         (lm32_dummy_id): Delete.
9391         (lm32_gdbarch_init): Don't register deleted functions with
9392         gdbarch.
9393
9394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9395
9396         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9397         (iq2000_unwind_pc): Delete.
9398         (iq2000_dummy_id): Delete.
9399         (iq2000_gdbarch_init): Don't register deleted functions with
9400         gdbarch.
9401
9402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9403
9404         * nds32-tdep.c (nds32_type_align): Delete.
9405         (nds32_push_dummy_call): Use type_align instead.
9406
9407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9408
9409         * arm-tdep.c (arm_type_align): Only handle vector override case.
9410         (arm_push_dummy_call): Use type_align.
9411         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9412
9413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9414
9415         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9416         case.
9417         (pass_on_stack): Use type_align.
9418         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9419         function.
9420
9421 2019-04-23  Tom Tromey  <tromey@adacore.com>
9422
9423         * dwarf2read.c (line_header::file_name_at): Remove unused
9424         overload.
9425
9426 2019-04-23  Tom de Vries  <tdevries@suse.de>
9427
9428         PR gdb/24438
9429         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9430         invocation.
9431
9432
9433 2019-03-27  Ali Tamur  <tamur@google.com>
9434
9435         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9436         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9437         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9438         (dwarf_expr_context::get_addr_index): Likewise
9439         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9440         (symbol_needs_eval_context::get_addr_index): Likewise
9441         (disassemble_dwarf_expression): Add DW_OP_addrx
9442         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9443         (read_cutu_die_from_dwo): Update comment
9444         (skip_one_die): Add DW_FORM_addrx
9445         (read_attribute_value): Likewise
9446         (var_decode_location): Add DW_OP_addrx
9447         (dwarf2_const_value_attr): Add DW_FORM_addrx
9448         (dump_die_shallow): Likewise
9449         (dwarf2_fetch_constant_bytes): Likewise
9450         (decode_locdesc): Add DW_OP_addrx
9451         (skip_form_bytes): Add DW_FORM_addrx
9452
9453 2019-04-22  Ali Tamur  <tamur@google.com>
9454
9455         * MAINTAINERS (Write After Approval): Add self.
9456
9457 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9458
9459         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9460         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9461         (open_symbol_file_object): Likewise.
9462         (svr4_default_sos): Add info parameter.
9463         (svr4_read_so_list): Likewise.
9464         (svr4_current_sos_direct): Adjust functions calls to pass down
9465         info.
9466         (svr4_current_sos_1): Add info parameter.
9467         (svr4_current_sos): Call get_svr4_info, pass info down to
9468         svr4_current_sos_1.
9469         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9470         get_svr4_info.
9471         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9472         get_svr4_info.
9473         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9474         to get_svr4_info.
9475         (probes_table_remove_objfile_probes): Likewise.
9476         (register_solib_event_probe): Add info parameter.
9477         (solist_update_incremental): Pass info parameter down to
9478         svr4_read_so_list.
9479         (disable_probes_interface): Add info parameter.
9480         (svr4_handle_solib_event): Pass current_program_space to
9481         get_svr4_info.  Adjust disable_probes_interface cleanup.
9482         (svr4_create_probe_breakpoints): Add info parameter, pass it
9483         down to register_solib_event_probe.
9484         (svr4_create_solib_event_breakpoints): Add info parameter,
9485         pass it down to svr4_create_probe_breakpoints.
9486         (enable_break): Pass info down to
9487         svr4_create_solib_event_breakpoints.
9488         (svr4_solib_create_inferior_hook): Pass current_program_space to
9489         get_svr4_info.
9490         (svr4_clear_solib): Likewise.
9491
9492 2019-04-22  Pedro Alves  <palves@redhat.com>
9493
9494         * solib-svr4.c (svr4_free_objfile_observer): New.
9495         (probe_and_action::objfile): New field.
9496         (probes_table_htab_remove_objfile_probes)
9497         (probes_table_remove_objfile_probes): New functions.
9498         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9499         in the new probe_and_action.  Don't store the probe in 'lookup'.
9500         (svr4_create_probe_breakpoints): Pass objfile to
9501         register_solib_event_probe.
9502         (_initialize_svr4_solib): Register a free_objfile observer.
9503
9504 2019-04-19  Tom Tromey  <tom@tromey.com>
9505
9506         * common/queue.h: Remove.
9507
9508 2019-04-19  Tom Tromey  <tom@tromey.com>
9509
9510         * event-loop.c: Don't include "common/queue.h".
9511
9512 2019-04-19  Tom Tromey  <tom@tromey.com>
9513
9514         * remote.c (remote_target): Use delete.
9515         * remote-notif.h: Include <list>, not "common/queue.h".
9516         (notif_client_p): Remove typedef.
9517         (remote_notif_state): Add constructor, destructor, initializer.
9518         <notif_queue>: Now a std::list.
9519         (remote_notif_state_xfree): Don't declare.
9520         * remote-notif.c (remote_notif_process, handle_notification)
9521         (remote_notif_state_allocate): Update.
9522         (~remote_notif_state): Rename from remote_notif_state_xfree.
9523
9524 2019-04-19  Tom Tromey  <tom@tromey.com>
9525
9526         * symfile.c (reread_symbols): Update.
9527         * objfiles.c (objfile_register_static_link)
9528         (objfile_lookup_static_link): Update
9529         (~objfile) Don't delete static_links.
9530         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9531
9532 2019-04-19  Tom Tromey  <tom@tromey.com>
9533
9534         * type-stack.h (struct type_stack) <insert>: Constify string.
9535         * type-stack.c (type_stack::insert): Constify string.
9536         * gdbtypes.h (lookup_template_type): Update.
9537         (address_space_name_to_int): Update.
9538         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9539         const.
9540         (lookup_template_type): Make name const.
9541         * c-exp.y: Update rules.
9542         (lex_one_token, classify_name, classify_inner_name)
9543         (c_print_token): Update.
9544         * p-exp.y: Update rules.
9545         (yylex): Update.
9546         * f-exp.y: Update rules.
9547         (yylex): Update.
9548         * d-exp.y: Update rules.
9549         (lex_one_token, classify_name, classify_inner_name): Update.
9550         * parse.c (write_dollar_variable, copy_name): Return std::string.
9551         * parser-defs.h (copy_name): Change return type.
9552         * m2-exp.y: Update rules.
9553         (yylex): Update.
9554         * go-exp.y (lex_one_token): Update.
9555         Update rules.
9556         (classify_unsafe_function, classify_packaged_name)
9557         (classify_name, yylex): Update.
9558
9559 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9560
9561         * configure.ac: add --enable-source-highlight switch.
9562         * configure: Regenerate.
9563         * top.c (print_gdb_version): plumb --enable-source-highlight
9564         status to "show configuration".
9565
9566 2019-04-19  Tom Tromey  <tromey@adacore.com>
9567
9568         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9569         Check ADA_TYPE_P.
9570         (empty_record, ada_template_to_fixed_record_type_1)
9571         (template_to_static_fixed_type)
9572         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9573         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9574         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9575         macros.
9576
9577 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9578
9579         PR symtab/24423:
9580         * source.c (print_source_lines_base): Advance "iter" when a
9581         control character is seen.
9582
9583 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9584
9585         * inferior.h (struct infcall_suspend_state_deleter):
9586         Catch exception in destructor to avoid crash.
9587
9588 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9589
9590         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9591         close to the add_com "shell".
9592
9593 2019-04-18  Tom Tromey  <tromey@adacore.com>
9594
9595         * process-stratum-target.h (class process_stratum_target)
9596         <stratum>: Add "final".
9597
9598 2019-04-17  Tom Tromey  <tromey@adacore.com>
9599
9600         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9601         against nullptr before use.
9602
9603 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9604
9605         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9606
9607 2019-04-17  Jim Wilson  <jimw@sifive.com>
9608             Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9611         code read might fail, assume 4-byte breakpoint in that case.
9612
9613 2019-04-15  Leszek Swirski  <leszeks@google.com>
9614
9615         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9616         rather than a hand-rolled POD check when checking for forced MEMORY
9617         classification.
9618
9619 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9620
9621         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9622         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9623         function.
9624         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9625         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9626         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9627         declaration.
9628
9629 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9630
9631         * aarch64-linux-nat.c
9632         (aarch64_linux_nat_target::thread_architecture): Add override.
9633         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9634         each VQ.
9635
9636 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9637
9638         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9639
9640 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9643         target types of size 96-bits, add some additional comments, and
9644         check that the builtin type we found was the correct size.
9645
9646 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9647
9648         * utils.c (prompt_for_continue): Don't restore the styling at the
9649         end, as applied_style has the wrong value.  This fixes styling in
9650         long lists of file names that are interrupted by the "Continue?"
9651         prompt.
9652
9653 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9654
9655         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9656         * c-lang.c (c_language_defn): Likewise.
9657         (cplus_language_defn): Likewise.
9658         (asm_language_defn): Likewise.
9659         (minimal_language_defn): Likewise.
9660         * d-lang.c (d_language_defn): Likewise.
9661         * f-lang.c (f_language_defn): Likewise.
9662         * go-lang.c (go_language_defn): Likewise.
9663         * language.c (unknown_language_defn): Likewise.
9664         (auto_language_defn): Likewise.
9665         * language.h (struct language_defn): Remove la_magic field.
9666         (LANG_MAGIC): Delete.
9667         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9668         * objc-lang.c (objc_language_defn): Likewise.
9669         * opencl-lang.c (opencl_language_defn): Likewise.
9670         * p-lang.c (pascal_language_defn): Likewise.
9671         * rust-lang.c (rust_language_defn): Likewise.
9672
9673 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9674
9675         * riscv-tdep.c (riscv_type_align): New function.
9676         (riscv_type_alignment): Delete.
9677         (riscv_arg_location): Use 'type_align'.
9678         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9679
9680 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9681
9682         * gdbtypes.c (type_align): A struct with no non-static fields also
9683         has alignment of 1.
9684
9685 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9686
9687         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9688         component to 0.
9689         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9690         member.
9691         (riscv_struct_info::analyse): New implementation using new
9692         analyse_inner member function.
9693         (riscv_struct_info::field_offset): New member function.
9694         (riscv_struct_info::m_offsets): New member variable.
9695         (riscv_struct_info::analyse_inner): New private member function,
9696         takes the old implementation of riscv_struct_info::analyse but
9697         extended to track field offsets.
9698         (riscv_call_arg_struct): Update the struct folding special cases
9699         to handle cases where empty C++ structs, which are non-zero
9700         length, are found.
9701         (riscv_arg_location): Initialise the length of each location, a
9702         non-zero length now indicates the location is in use.
9703         (riscv_push_dummy_call): Allow for the first location having a
9704         non-zero offset when setting up arguments.
9705         (riscv_return_value): Likewise, but for return values.
9706
9707 2019-04-11  Tom Tromey  <tromey@adacore.com>
9708
9709         * utils.c (internal_vproblem): Make "msg" const.
9710
9711 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9712
9713         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9714         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9715         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9716         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9717
9718 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9719
9720         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9721         function.
9722         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9723         of amd64_collect_native_gregset.
9724         (amd64_linux_nat_target::store_registers): Likewise.
9725
9726 2019-04-10  Tom Tromey  <tom@tromey.com>
9727
9728         * symtab.c (lookup_global_symbol_from_objfile)
9729         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9730         * objfiles.h (class separate_debug_iterator): New.
9731         (class separate_debug_range): New.
9732         (struct objfile) <separate_debug_objfiles>: New method.
9733         (objfile_separate_debug_iterate): Don't declare.
9734         * objfiles.c (separate_debug_iterator::operator++): Rename from
9735         objfile_separate_debug_iterate.
9736         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9737         iterator.
9738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9739         iterator.
9740
9741 2019-04-10  Tom Tromey  <tom@tromey.com>
9742
9743         * symfile.c (reread_symbols): Remove old comment.
9744         * objfiles.c (free_all_objfiles): Fix a typo.
9745
9746 2019-04-10  Tom Tromey  <tom@tromey.com>
9747
9748         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9749         * minsyms.c (lookup_minimal_symbol): Use foreach.
9750         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9751         (lookup_minimal_symbol_solib_trampoline): Likewise.
9752         * symfile.c (reread_symbols): Use foreach.
9753
9754 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9755             Tom Tromey  <tromey@adacore.com>
9756
9757         PR rust/24414:
9758         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9759         (rust_lex_int_test): Change "value" to be LONGEST.
9760         (rust_lex_tests): Add test for long integer literal.
9761
9762 2019-04-09  Tom Tromey  <tromey@adacore.com>
9763
9764         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9765         to bool.
9766         (extended_remote_target::attach): Update.
9767         (remote_target::remote_notice_new_inferior): Update.
9768         (remote_target::add_current_inferior_and_thread): Update.
9769         * inferior.c (exit_inferior_1): Use "false".
9770         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9771
9772 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9773
9774         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9775         the "start" command.
9776
9777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9778
9779         * python/py-inferior.c (infpy_thread_from_thread_handle):
9780         Adjust comments to reflect renaming of thread_from_thread_handle
9781         to thread_from_handle.  Adjust keywords.  Fix type error message.
9782         (inferior_object_methods): Add thread_from_handle.  Retain
9783         thread_from_thread_handle, but mark it as deprecated.
9784
9785 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9786
9787         * gdbthread.h (find_thread_by_handle): Revise declaration.
9788         * thread.c (find_thread_by_handle): Likewise.  Adjust
9789         implementation too.
9790         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9791         support for buffer objects as handles.
9792
9793 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9794
9795         * python/py-infthread.c (thpy_thread_handle): New function.
9796         (thread_object_methods): Register thpy_thread_handle.
9797
9798 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9799
9800         * gdbthread.h (thread_to_thread_handle): Declare.
9801         * thread.c (gdbtypes.h): Include.
9802         (thread_to_thread_handle): New function.
9803
9804         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9805         (target_thread_info_to_thread_handle): Declare.
9806         * target.c (target_thread_info_to_thread_handle): New function.
9807         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9808         * target-delegates.c: Regenerate.
9809
9810         * linux-thread-db.c (class thread_db_target): Add method
9811         thread_info_to_thread_handle.
9812         (thread_db_target::thread_info_to_thread_handle): Define.
9813         * remote.c (class remote_target): Add new method
9814         thread_info_to_thread_handle.
9815         (remote_target::thread_info_to_thread_handle): Define.
9816
9817 2019-04-08  Pedro Alves  <palves@redhat.com>
9818
9819         * common/common-exceptions.c (throw_exception): Don't create
9820         named object to throw; throw directly.
9821         (throw_it): Likewise.  Don't initialize gdb_exception::message
9822         here, with new; pass FMT and AP to the ctor instead.
9823         * common/common-exceptions.h: Include <string>.
9824         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9825         const char *, va_list)): New ctor.  Use std::make_shared.
9826         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9827         errors)): Delete.
9828         (gdb_exception_error::gdb_exception_error(enum errors, const char
9829         *, va_list)): New.
9830         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9831         Add assertion.
9832         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9833         errors)): Delete.
9834         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9835         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9836         Add assertion.
9837
9838 2019-04-08  Tom Tromey  <tom@tromey.com>
9839
9840         * valops.c (value_rtti_indirect_type): Replace throw_exception
9841         with throw.
9842         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9843         with throw.
9844         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9845         throw.
9846         * target.c (target_translate_tls_address): Replace throw_exception
9847         with throw.
9848         * stack.c (frame_apply_command_count): Replace throw_exception
9849         with throw.
9850         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9851         throw.
9852         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9853         with throw.
9854         * rs6000-tdep.c (rs6000_frame_cache)
9855         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9856         * remote.c: Replace throw_exception with throw.
9857         * record-full.c (record_full_message, record_full_wait_1)
9858         (record_full_restore): Replace throw_exception with throw.
9859         * record-btrace.c:
9860         (get_thread_current_frame_id, record_btrace_start_replaying)
9861         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9862         (cmd_record_btrace_start): Replace throw_exception with throw.
9863         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9864         throw.
9865         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9866         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9867         * linespec.c:
9868         (find_linespec_symbols): Replace throw_exception with throw.
9869         * infrun.c (displaced_step_prepare, resume): Replace
9870         throw_exception with throw.
9871         * infcmd.c (post_create_inferior): Replace throw_exception with
9872         throw.
9873         * inf-loop.c (inferior_event_handler): Replace throw_exception
9874         with throw.
9875         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9876         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9877         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9878         (get_prev_frame_always, get_frame_pc_if_available)
9879         (get_frame_address_in_block_if_available, get_frame_language):
9880         Replace throw_exception with throw.
9881         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9882         throw_exception with throw.
9883         * eval.c (fetch_subexp_value, evaluate_var_value)
9884         (evaluate_funcall, evaluate_subexp_standard): Replace
9885         throw_exception with throw.
9886         * dwarf2loc.c (call_site_find_chain)
9887         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9888         Replace throw_exception with throw.
9889         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9890         with throw.
9891         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9892         throw.
9893         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9894         * completer.c (complete_line_internal): Replace throw_exception
9895         with throw.
9896         * compile/compile-object-run.c (compile_object_run): Replace
9897         throw_exception with throw.
9898         * cli/cli-script.c (process_next_line): Replace throw_exception
9899         with throw.
9900         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9901         (btrace_enable, btrace_maint_update_pt_packets): Replace
9902         throw_exception with throw.
9903         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9904         throw_exception with throw.
9905         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9906         throw_exception with throw.
9907         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9908         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9909         * aarch64-tdep.c (aarch64_make_prologue_cache)
9910         (aarch64_make_stub_cache): Replace throw_exception with throw.
9911
9912 2019-04-08  Tom Tromey  <tom@tromey.com>
9913
9914         * common/common-exceptions.c (throw_exception): Rename from
9915         throw_exception_cxx.  Remove old copy.  Make argument const.
9916         (throw_it): Create and throw exception objects directly.
9917         * common/common-exceptions.h (throw_exception): Make argument
9918         const.
9919         (struct gdb_exception_error): Add constructor.
9920         (struct gdb_exception_quit): Add constructor.
9921
9922 2019-04-08  Tom Tromey  <tom@tromey.com>
9923
9924         * common/common-exceptions.h (exception_rethrow): Don't declare.
9925         (TRY_SJLJ): Update comment.
9926         (TRY, CATCH, END_CATCH): Remove.
9927         * common/common-exceptions.c (exception_rethrow): Remove.
9928
9929 2019-04-08  Tom Tromey  <tom@tromey.com>
9930
9931         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9932         Remove.
9933         (gdb_exception_error): Rename from
9934         gdb_exception_RETURN_MASK_ERROR.
9935         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9936         (gdb_quit_bad_alloc): Update.
9937         * aarch64-tdep.c: Update.
9938         * ada-lang.c: Update.
9939         * ada-typeprint.c: Update.
9940         * ada-valprint.c: Update.
9941         * amd64-tdep.c: Update.
9942         * arch-utils.c: Update.
9943         * break-catch-throw.c: Update.
9944         * breakpoint.c: Update.
9945         * btrace.c: Update.
9946         * c-varobj.c: Update.
9947         * cli/cli-cmds.c: Update.
9948         * cli/cli-interp.c: Update.
9949         * cli/cli-script.c: Update.
9950         * common/common-exceptions.c: Update.
9951         * common/new-op.c: Update.
9952         * common/selftest.c: Update.
9953         * compile/compile-c-symbols.c: Update.
9954         * compile/compile-cplus-symbols.c: Update.
9955         * compile/compile-object-load.c: Update.
9956         * compile/compile-object-run.c: Update.
9957         * completer.c: Update.
9958         * corelow.c: Update.
9959         * cp-abi.c: Update.
9960         * cp-support.c: Update.
9961         * cp-valprint.c: Update.
9962         * darwin-nat.c: Update.
9963         * disasm-selftests.c: Update.
9964         * dtrace-probe.c: Update.
9965         * dwarf-index-cache.c: Update.
9966         * dwarf-index-write.c: Update.
9967         * dwarf2-frame-tailcall.c: Update.
9968         * dwarf2-frame.c: Update.
9969         * dwarf2loc.c: Update.
9970         * dwarf2read.c: Update.
9971         * eval.c: Update.
9972         * event-loop.c: Update.
9973         * event-top.c: Update.
9974         * exec.c: Update.
9975         * f-valprint.c: Update.
9976         * fbsd-tdep.c: Update.
9977         * frame-unwind.c: Update.
9978         * frame.c: Update.
9979         * gdbtypes.c: Update.
9980         * gnu-v3-abi.c: Update.
9981         * guile/guile-internal.h: Update.
9982         * guile/scm-block.c: Update.
9983         * guile/scm-breakpoint.c: Update.
9984         * guile/scm-cmd.c: Update.
9985         * guile/scm-disasm.c: Update.
9986         * guile/scm-frame.c: Update.
9987         * guile/scm-lazy-string.c: Update.
9988         * guile/scm-math.c: Update.
9989         * guile/scm-param.c: Update.
9990         * guile/scm-ports.c: Update.
9991         * guile/scm-pretty-print.c: Update.
9992         * guile/scm-symbol.c: Update.
9993         * guile/scm-symtab.c: Update.
9994         * guile/scm-type.c: Update.
9995         * guile/scm-value.c: Update.
9996         * i386-linux-tdep.c: Update.
9997         * i386-tdep.c: Update.
9998         * inf-loop.c: Update.
9999         * infcall.c: Update.
10000         * infcmd.c: Update.
10001         * infrun.c: Update.
10002         * jit.c: Update.
10003         * language.c: Update.
10004         * linespec.c: Update.
10005         * linux-fork.c: Update.
10006         * linux-nat.c: Update.
10007         * linux-tdep.c: Update.
10008         * linux-thread-db.c: Update.
10009         * main.c: Update.
10010         * mi/mi-cmd-break.c: Update.
10011         * mi/mi-cmd-stack.c: Update.
10012         * mi/mi-interp.c: Update.
10013         * mi/mi-main.c: Update.
10014         * objc-lang.c: Update.
10015         * p-valprint.c: Update.
10016         * parse.c: Update.
10017         * ppc-linux-tdep.c: Update.
10018         * printcmd.c: Update.
10019         * python/py-arch.c: Update.
10020         * python/py-breakpoint.c: Update.
10021         * python/py-cmd.c: Update.
10022         * python/py-finishbreakpoint.c: Update.
10023         * python/py-frame.c: Update.
10024         * python/py-framefilter.c: Update.
10025         * python/py-gdb-readline.c: Update.
10026         * python/py-inferior.c: Update.
10027         * python/py-infthread.c: Update.
10028         * python/py-lazy-string.c: Update.
10029         * python/py-linetable.c: Update.
10030         * python/py-objfile.c: Update.
10031         * python/py-param.c: Update.
10032         * python/py-prettyprint.c: Update.
10033         * python/py-progspace.c: Update.
10034         * python/py-record-btrace.c: Update.
10035         * python/py-record.c: Update.
10036         * python/py-symbol.c: Update.
10037         * python/py-type.c: Update.
10038         * python/py-unwind.c: Update.
10039         * python/py-utils.c: Update.
10040         * python/py-value.c: Update.
10041         * python/python.c: Update.
10042         * record-btrace.c: Update.
10043         * record-full.c: Update.
10044         * remote-fileio.c: Update.
10045         * remote.c: Update.
10046         * riscv-tdep.c: Update.
10047         * rs6000-aix-tdep.c: Update.
10048         * rs6000-tdep.c: Update.
10049         * rust-exp.y: Update.
10050         * rust-lang.c: Update.
10051         * s390-tdep.c: Update.
10052         * selftest-arch.c: Update.
10053         * solib-dsbt.c: Update.
10054         * solib-frv.c: Update.
10055         * solib-spu.c: Update.
10056         * solib-svr4.c: Update.
10057         * solib.c: Update.
10058         * sparc64-linux-tdep.c: Update.
10059         * stack.c: Update.
10060         * symfile-mem.c: Update.
10061         * symmisc.c: Update.
10062         * target.c: Update.
10063         * thread.c: Update.
10064         * top.c: Update.
10065         * tracefile-tfile.c: Update.
10066         * tui/tui.c: Update.
10067         * typeprint.c: Update.
10068         * unittests/cli-utils-selftests.c: Update.
10069         * unittests/parse-connection-spec-selftests.c: Update.
10070         * valops.c: Update.
10071         * valprint.c: Update.
10072         * value.c: Update.
10073         * varobj.c: Update.
10074         * windows-nat.c: Update.
10075         * x86-linux-nat.c: Update.
10076         * xml-support.c: Update.
10077
10078 2019-04-08  Tom Tromey  <tom@tromey.com>
10079
10080         * xml-support.c: Use C++ exception handling.
10081         * x86-linux-nat.c: Use C++ exception handling.
10082         * windows-nat.c: Use C++ exception handling.
10083         * varobj.c: Use C++ exception handling.
10084         * value.c: Use C++ exception handling.
10085         * valprint.c: Use C++ exception handling.
10086         * valops.c: Use C++ exception handling.
10087         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10088         handling.
10089         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10090         * typeprint.c: Use C++ exception handling.
10091         * tui/tui.c: Use C++ exception handling.
10092         * tracefile-tfile.c: Use C++ exception handling.
10093         * top.c: Use C++ exception handling.
10094         * thread.c: Use C++ exception handling.
10095         * target.c: Use C++ exception handling.
10096         * symmisc.c: Use C++ exception handling.
10097         * symfile-mem.c: Use C++ exception handling.
10098         * stack.c: Use C++ exception handling.
10099         * sparc64-linux-tdep.c: Use C++ exception handling.
10100         * solib.c: Use C++ exception handling.
10101         * solib-svr4.c: Use C++ exception handling.
10102         * solib-spu.c: Use C++ exception handling.
10103         * solib-frv.c: Use C++ exception handling.
10104         * solib-dsbt.c: Use C++ exception handling.
10105         * selftest-arch.c: Use C++ exception handling.
10106         * s390-tdep.c: Use C++ exception handling.
10107         * rust-lang.c: Use C++ exception handling.
10108         * rust-exp.y: Use C++ exception handling.
10109         * rs6000-tdep.c: Use C++ exception handling.
10110         * rs6000-aix-tdep.c: Use C++ exception handling.
10111         * riscv-tdep.c: Use C++ exception handling.
10112         * remote.c: Use C++ exception handling.
10113         * remote-fileio.c: Use C++ exception handling.
10114         * record-full.c: Use C++ exception handling.
10115         * record-btrace.c: Use C++ exception handling.
10116         * python/python.c: Use C++ exception handling.
10117         * python/py-value.c: Use C++ exception handling.
10118         * python/py-utils.c: Use C++ exception handling.
10119         * python/py-unwind.c: Use C++ exception handling.
10120         * python/py-type.c: Use C++ exception handling.
10121         * python/py-symbol.c: Use C++ exception handling.
10122         * python/py-record.c: Use C++ exception handling.
10123         * python/py-record-btrace.c: Use C++ exception handling.
10124         * python/py-progspace.c: Use C++ exception handling.
10125         * python/py-prettyprint.c: Use C++ exception handling.
10126         * python/py-param.c: Use C++ exception handling.
10127         * python/py-objfile.c: Use C++ exception handling.
10128         * python/py-linetable.c: Use C++ exception handling.
10129         * python/py-lazy-string.c: Use C++ exception handling.
10130         * python/py-infthread.c: Use C++ exception handling.
10131         * python/py-inferior.c: Use C++ exception handling.
10132         * python/py-gdb-readline.c: Use C++ exception handling.
10133         * python/py-framefilter.c: Use C++ exception handling.
10134         * python/py-frame.c: Use C++ exception handling.
10135         * python/py-finishbreakpoint.c: Use C++ exception handling.
10136         * python/py-cmd.c: Use C++ exception handling.
10137         * python/py-breakpoint.c: Use C++ exception handling.
10138         * python/py-arch.c: Use C++ exception handling.
10139         * printcmd.c: Use C++ exception handling.
10140         * ppc-linux-tdep.c: Use C++ exception handling.
10141         * parse.c: Use C++ exception handling.
10142         * p-valprint.c: Use C++ exception handling.
10143         * objc-lang.c: Use C++ exception handling.
10144         * mi/mi-main.c: Use C++ exception handling.
10145         * mi/mi-interp.c: Use C++ exception handling.
10146         * mi/mi-cmd-stack.c: Use C++ exception handling.
10147         * mi/mi-cmd-break.c: Use C++ exception handling.
10148         * main.c: Use C++ exception handling.
10149         * linux-thread-db.c: Use C++ exception handling.
10150         * linux-tdep.c: Use C++ exception handling.
10151         * linux-nat.c: Use C++ exception handling.
10152         * linux-fork.c: Use C++ exception handling.
10153         * linespec.c: Use C++ exception handling.
10154         * language.c: Use C++ exception handling.
10155         * jit.c: Use C++ exception handling.
10156         * infrun.c: Use C++ exception handling.
10157         * infcmd.c: Use C++ exception handling.
10158         * infcall.c: Use C++ exception handling.
10159         * inf-loop.c: Use C++ exception handling.
10160         * i386-tdep.c: Use C++ exception handling.
10161         * i386-linux-tdep.c: Use C++ exception handling.
10162         * guile/scm-value.c: Use C++ exception handling.
10163         * guile/scm-type.c: Use C++ exception handling.
10164         * guile/scm-symtab.c: Use C++ exception handling.
10165         * guile/scm-symbol.c: Use C++ exception handling.
10166         * guile/scm-pretty-print.c: Use C++ exception handling.
10167         * guile/scm-ports.c: Use C++ exception handling.
10168         * guile/scm-param.c: Use C++ exception handling.
10169         * guile/scm-math.c: Use C++ exception handling.
10170         * guile/scm-lazy-string.c: Use C++ exception handling.
10171         * guile/scm-frame.c: Use C++ exception handling.
10172         * guile/scm-disasm.c: Use C++ exception handling.
10173         * guile/scm-cmd.c: Use C++ exception handling.
10174         * guile/scm-breakpoint.c: Use C++ exception handling.
10175         * guile/scm-block.c: Use C++ exception handling.
10176         * guile/guile-internal.h: Use C++ exception handling.
10177         * gnu-v3-abi.c: Use C++ exception handling.
10178         * gdbtypes.c: Use C++ exception handling.
10179         * frame.c: Use C++ exception handling.
10180         * frame-unwind.c: Use C++ exception handling.
10181         * fbsd-tdep.c: Use C++ exception handling.
10182         * f-valprint.c: Use C++ exception handling.
10183         * exec.c: Use C++ exception handling.
10184         * event-top.c: Use C++ exception handling.
10185         * event-loop.c: Use C++ exception handling.
10186         * eval.c: Use C++ exception handling.
10187         * dwarf2read.c: Use C++ exception handling.
10188         * dwarf2loc.c: Use C++ exception handling.
10189         * dwarf2-frame.c: Use C++ exception handling.
10190         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10191         * dwarf-index-write.c: Use C++ exception handling.
10192         * dwarf-index-cache.c: Use C++ exception handling.
10193         * dtrace-probe.c: Use C++ exception handling.
10194         * disasm-selftests.c: Use C++ exception handling.
10195         * darwin-nat.c: Use C++ exception handling.
10196         * cp-valprint.c: Use C++ exception handling.
10197         * cp-support.c: Use C++ exception handling.
10198         * cp-abi.c: Use C++ exception handling.
10199         * corelow.c: Use C++ exception handling.
10200         * completer.c: Use C++ exception handling.
10201         * compile/compile-object-run.c: Use C++ exception handling.
10202         * compile/compile-object-load.c: Use C++ exception handling.
10203         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10204         * compile/compile-c-symbols.c: Use C++ exception handling.
10205         * common/selftest.c: Use C++ exception handling.
10206         * common/new-op.c: Use C++ exception handling.
10207         * cli/cli-script.c: Use C++ exception handling.
10208         * cli/cli-interp.c: Use C++ exception handling.
10209         * cli/cli-cmds.c: Use C++ exception handling.
10210         * c-varobj.c: Use C++ exception handling.
10211         * btrace.c: Use C++ exception handling.
10212         * breakpoint.c: Use C++ exception handling.
10213         * break-catch-throw.c: Use C++ exception handling.
10214         * arch-utils.c: Use C++ exception handling.
10215         * amd64-tdep.c: Use C++ exception handling.
10216         * ada-valprint.c: Use C++ exception handling.
10217         * ada-typeprint.c: Use C++ exception handling.
10218         * ada-lang.c: Use C++ exception handling.
10219         * aarch64-tdep.c: Use C++ exception handling.
10220
10221 2019-04-08  Tom Tromey  <tom@tromey.com>
10222
10223         * xml-support.c (gdb_xml_parser::parse): Update.
10224         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10225         * value.c (show_convenience): Update.
10226         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10227         (test_parse_flags_qcs): Update.
10228         * thread.c (thr_try_catch_cmd): Update.
10229         * target.c (target_translate_tls_address): Update.
10230         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10231         (info_frame_command_core, frame_apply_command_count): Update.
10232         * rust-exp.y (rust_lex_exception_test): Update.
10233         * riscv-tdep.c (riscv_print_one_register_info): Update.
10234         * remote.c (remote_target::enable_btrace): Update.
10235         * record-btrace.c (record_btrace_enable_warn): Update.
10236         * python/py-utils.c (gdbpy_convert_exception): Update.
10237         * printcmd.c (do_one_display, print_variable_and_value): Update.
10238         * mi/mi-main.c (mi_print_exception): Update.
10239         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10240         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10241         * linux-nat.c (linux_nat_target::attach): Update.
10242         * linux-fork.c (class scoped_switch_fork_info): Update.
10243         * infrun.c (displaced_step_prepare): Update.
10244         * infcall.c (call_function_by_hand_dummy): Update.
10245         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10246         * gnu-v3-abi.c (print_one_vtable): Update.
10247         * frame.c (get_prev_frame_always): Update.
10248         * f-valprint.c (info_common_command_for_block): Update.
10249         * exec.c (try_open_exec_file): Update.
10250         * exceptions.c (print_exception, exception_print)
10251         (exception_fprintf, exception_print_same): Update.
10252         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10253         * dwarf-index-cache.c (index_cache::store)
10254         (index_cache::lookup_gdb_index): Update.
10255         * darwin-nat.c (maybe_cache_shell): Update.
10256         * cp-valprint.c (cp_print_value_fields): Update.
10257         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10258         (gcc_cplus_symbol_address): Update.
10259         * compile/compile-c-symbols.c (gcc_convert_symbol)
10260         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10261         * common/selftest.c: Update.
10262         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10263         a std::string.
10264         (exception_try_scope_entry, exception_try_scope_exit): Don't
10265         declare.
10266         (struct exception_try_scope): Remove.
10267         (TRY): Don't use exception_try_scope.
10268         (struct gdb_exception): Add constructor, operator=.
10269         <what>: New method.
10270         (struct gdb_exception_RETURN_MASK_ALL)
10271         (struct gdb_exception_RETURN_MASK_ERROR)
10272         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10273         (struct gdb_quit_bad_alloc): Update.
10274         * common/common-exceptions.c (exception_none): Change
10275         initializer.
10276         (struct catcher) <state, exception>: Initialize inline.
10277         <prev>: Remove member.
10278         (current_catcher): Remove.
10279         (catchers): New global.
10280         (exceptions_state_mc_init): Simplify.
10281         (catcher_pop): Remove.
10282         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10283         (try_scope_depth, exception_try_scope_entry)
10284         (exception_try_scope_exit): Remove.
10285         (throw_exception_sjlj): Update.
10286         (exception_messages, exception_messages_size): Remove.
10287         (throw_it): Simplify.
10288         (gdb_exception_sliced_copy): Remove.
10289         (throw_exception_cxx): Update.
10290         * cli/cli-script.c (script_from_file): Update.
10291         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10292         Update.
10293         * ada-valprint.c (ada_val_print): Update.
10294         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10295         (create_excep_cond_exprs): Update.
10296
10297 2019-04-08  Tom Tromey  <tom@tromey.com>
10298
10299         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10300         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10301         (TRY, CATCH, END_CATCH): Remove some definitions.
10302         * common/common-exceptions.c: Don't use GDB_XCPT.
10303         (catcher_list_size): Remove.
10304         (throw_exception, throw_it): Simplify.
10305
10306 2019-04-05  Tom Tromey  <tom@tromey.com>
10307
10308         Revert the header-sorting patch.
10309         * ft32-tdep.c: Revert.
10310         * frv-tdep.c: Revert.
10311         * frv-linux-tdep.c: Revert.
10312         * frame.c: Revert.
10313         * frame-unwind.c: Revert.
10314         * frame-base.c: Revert.
10315         * fork-child.c: Revert.
10316         * findvar.c: Revert.
10317         * findcmd.c: Revert.
10318         * filesystem.c: Revert.
10319         * filename-seen-cache.h: Revert.
10320         * filename-seen-cache.c: Revert.
10321         * fbsd-tdep.c: Revert.
10322         * fbsd-nat.h: Revert.
10323         * fbsd-nat.c: Revert.
10324         * f-valprint.c: Revert.
10325         * f-typeprint.c: Revert.
10326         * f-lang.c: Revert.
10327         * extension.h: Revert.
10328         * extension.c: Revert.
10329         * extension-priv.h: Revert.
10330         * expprint.c: Revert.
10331         * exec.h: Revert.
10332         * exec.c: Revert.
10333         * exceptions.c: Revert.
10334         * event-top.c: Revert.
10335         * event-loop.c: Revert.
10336         * eval.c: Revert.
10337         * elfread.c: Revert.
10338         * dwarf2read.h: Revert.
10339         * dwarf2read.c: Revert.
10340         * dwarf2loc.c: Revert.
10341         * dwarf2expr.h: Revert.
10342         * dwarf2expr.c: Revert.
10343         * dwarf2-frame.c: Revert.
10344         * dwarf2-frame-tailcall.c: Revert.
10345         * dwarf-index-write.h: Revert.
10346         * dwarf-index-write.c: Revert.
10347         * dwarf-index-common.c: Revert.
10348         * dwarf-index-cache.h: Revert.
10349         * dwarf-index-cache.c: Revert.
10350         * dummy-frame.c: Revert.
10351         * dtrace-probe.c: Revert.
10352         * disasm.h: Revert.
10353         * disasm.c: Revert.
10354         * disasm-selftests.c: Revert.
10355         * dictionary.c: Revert.
10356         * dicos-tdep.c: Revert.
10357         * demangle.c: Revert.
10358         * dcache.h: Revert.
10359         * dcache.c: Revert.
10360         * darwin-nat.h: Revert.
10361         * darwin-nat.c: Revert.
10362         * darwin-nat-info.c: Revert.
10363         * d-valprint.c: Revert.
10364         * d-namespace.c: Revert.
10365         * d-lang.c: Revert.
10366         * ctf.c: Revert.
10367         * csky-tdep.c: Revert.
10368         * csky-linux-tdep.c: Revert.
10369         * cris-tdep.c: Revert.
10370         * cris-linux-tdep.c: Revert.
10371         * cp-valprint.c: Revert.
10372         * cp-support.c: Revert.
10373         * cp-namespace.c: Revert.
10374         * cp-abi.c: Revert.
10375         * corelow.c: Revert.
10376         * corefile.c: Revert.
10377         * continuations.c: Revert.
10378         * completer.h: Revert.
10379         * completer.c: Revert.
10380         * complaints.c: Revert.
10381         * coffread.c: Revert.
10382         * coff-pe-read.c: Revert.
10383         * cli-out.h: Revert.
10384         * cli-out.c: Revert.
10385         * charset.c: Revert.
10386         * c-varobj.c: Revert.
10387         * c-valprint.c: Revert.
10388         * c-typeprint.c: Revert.
10389         * c-lang.c: Revert.
10390         * buildsym.c: Revert.
10391         * buildsym-legacy.c: Revert.
10392         * build-id.h: Revert.
10393         * build-id.c: Revert.
10394         * btrace.c: Revert.
10395         * bsd-uthread.c: Revert.
10396         * breakpoint.h: Revert.
10397         * breakpoint.c: Revert.
10398         * break-catch-throw.c: Revert.
10399         * break-catch-syscall.c: Revert.
10400         * break-catch-sig.c: Revert.
10401         * blockframe.c: Revert.
10402         * block.c: Revert.
10403         * bfin-tdep.c: Revert.
10404         * bfin-linux-tdep.c: Revert.
10405         * bfd-target.c: Revert.
10406         * bcache.c: Revert.
10407         * ax-general.c: Revert.
10408         * ax-gdb.h: Revert.
10409         * ax-gdb.c: Revert.
10410         * avr-tdep.c: Revert.
10411         * auxv.c: Revert.
10412         * auto-load.c: Revert.
10413         * arm-wince-tdep.c: Revert.
10414         * arm-tdep.c: Revert.
10415         * arm-symbian-tdep.c: Revert.
10416         * arm-pikeos-tdep.c: Revert.
10417         * arm-obsd-tdep.c: Revert.
10418         * arm-nbsd-tdep.c: Revert.
10419         * arm-nbsd-nat.c: Revert.
10420         * arm-linux-tdep.c: Revert.
10421         * arm-linux-nat.c: Revert.
10422         * arm-fbsd-tdep.c: Revert.
10423         * arm-fbsd-nat.c: Revert.
10424         * arm-bsd-tdep.c: Revert.
10425         * arch-utils.c: Revert.
10426         * arc-tdep.c: Revert.
10427         * arc-newlib-tdep.c: Revert.
10428         * annotate.h: Revert.
10429         * annotate.c: Revert.
10430         * amd64-windows-tdep.c: Revert.
10431         * amd64-windows-nat.c: Revert.
10432         * amd64-tdep.c: Revert.
10433         * amd64-sol2-tdep.c: Revert.
10434         * amd64-obsd-tdep.c: Revert.
10435         * amd64-obsd-nat.c: Revert.
10436         * amd64-nbsd-tdep.c: Revert.
10437         * amd64-nbsd-nat.c: Revert.
10438         * amd64-nat.c: Revert.
10439         * amd64-linux-tdep.c: Revert.
10440         * amd64-linux-nat.c: Revert.
10441         * amd64-fbsd-tdep.c: Revert.
10442         * amd64-fbsd-nat.c: Revert.
10443         * amd64-dicos-tdep.c: Revert.
10444         * amd64-darwin-tdep.c: Revert.
10445         * amd64-bsd-nat.c: Revert.
10446         * alpha-tdep.c: Revert.
10447         * alpha-obsd-tdep.c: Revert.
10448         * alpha-nbsd-tdep.c: Revert.
10449         * alpha-mdebug-tdep.c: Revert.
10450         * alpha-linux-tdep.c: Revert.
10451         * alpha-linux-nat.c: Revert.
10452         * alpha-bsd-tdep.c: Revert.
10453         * alpha-bsd-nat.c: Revert.
10454         * aix-thread.c: Revert.
10455         * agent.c: Revert.
10456         * addrmap.c: Revert.
10457         * ada-varobj.c: Revert.
10458         * ada-valprint.c: Revert.
10459         * ada-typeprint.c: Revert.
10460         * ada-tasks.c: Revert.
10461         * ada-lang.c: Revert.
10462         * aarch64-tdep.c: Revert.
10463         * aarch64-ravenscar-thread.c: Revert.
10464         * aarch64-newlib-tdep.c: Revert.
10465         * aarch64-linux-tdep.c: Revert.
10466         * aarch64-linux-nat.c: Revert.
10467         * aarch64-fbsd-tdep.c: Revert.
10468         * aarch64-fbsd-nat.c: Revert.
10469         * aarch32-linux-nat.c: Revert.
10470
10471 2019-04-05  Tom Tromey  <tom@tromey.com>
10472
10473         * ft32-tdep.c: Sort headers.
10474         * frv-tdep.c: Sort headers.
10475         * frv-linux-tdep.c: Sort headers.
10476         * frame.c: Sort headers.
10477         * frame-unwind.c: Sort headers.
10478         * frame-base.c: Sort headers.
10479         * fork-child.c: Sort headers.
10480         * findvar.c: Sort headers.
10481         * findcmd.c: Sort headers.
10482         * filesystem.c: Sort headers.
10483         * filename-seen-cache.h: Sort headers.
10484         * filename-seen-cache.c: Sort headers.
10485         * fbsd-tdep.c: Sort headers.
10486         * fbsd-nat.h: Sort headers.
10487         * fbsd-nat.c: Sort headers.
10488         * f-valprint.c: Sort headers.
10489         * f-typeprint.c: Sort headers.
10490         * f-lang.c: Sort headers.
10491         * extension.h: Sort headers.
10492         * extension.c: Sort headers.
10493         * extension-priv.h: Sort headers.
10494         * expprint.c: Sort headers.
10495         * exec.h: Sort headers.
10496         * exec.c: Sort headers.
10497         * exceptions.c: Sort headers.
10498         * event-top.c: Sort headers.
10499         * event-loop.c: Sort headers.
10500         * eval.c: Sort headers.
10501         * elfread.c: Sort headers.
10502         * dwarf2read.h: Sort headers.
10503         * dwarf2read.c: Sort headers.
10504         * dwarf2loc.c: Sort headers.
10505         * dwarf2expr.h: Sort headers.
10506         * dwarf2expr.c: Sort headers.
10507         * dwarf2-frame.c: Sort headers.
10508         * dwarf2-frame-tailcall.c: Sort headers.
10509         * dwarf-index-write.h: Sort headers.
10510         * dwarf-index-write.c: Sort headers.
10511         * dwarf-index-common.c: Sort headers.
10512         * dwarf-index-cache.h: Sort headers.
10513         * dwarf-index-cache.c: Sort headers.
10514         * dummy-frame.c: Sort headers.
10515         * dtrace-probe.c: Sort headers.
10516         * disasm.h: Sort headers.
10517         * disasm.c: Sort headers.
10518         * disasm-selftests.c: Sort headers.
10519         * dictionary.c: Sort headers.
10520         * dicos-tdep.c: Sort headers.
10521         * demangle.c: Sort headers.
10522         * dcache.h: Sort headers.
10523         * dcache.c: Sort headers.
10524         * darwin-nat.h: Sort headers.
10525         * darwin-nat.c: Sort headers.
10526         * darwin-nat-info.c: Sort headers.
10527         * d-valprint.c: Sort headers.
10528         * d-namespace.c: Sort headers.
10529         * d-lang.c: Sort headers.
10530         * ctf.c: Sort headers.
10531         * csky-tdep.c: Sort headers.
10532         * csky-linux-tdep.c: Sort headers.
10533         * cris-tdep.c: Sort headers.
10534         * cris-linux-tdep.c: Sort headers.
10535         * cp-valprint.c: Sort headers.
10536         * cp-support.c: Sort headers.
10537         * cp-namespace.c: Sort headers.
10538         * cp-abi.c: Sort headers.
10539         * corelow.c: Sort headers.
10540         * corefile.c: Sort headers.
10541         * continuations.c: Sort headers.
10542         * completer.h: Sort headers.
10543         * completer.c: Sort headers.
10544         * complaints.c: Sort headers.
10545         * coffread.c: Sort headers.
10546         * coff-pe-read.c: Sort headers.
10547         * cli-out.h: Sort headers.
10548         * cli-out.c: Sort headers.
10549         * charset.c: Sort headers.
10550         * c-varobj.c: Sort headers.
10551         * c-valprint.c: Sort headers.
10552         * c-typeprint.c: Sort headers.
10553         * c-lang.c: Sort headers.
10554         * buildsym.c: Sort headers.
10555         * buildsym-legacy.c: Sort headers.
10556         * build-id.h: Sort headers.
10557         * build-id.c: Sort headers.
10558         * btrace.c: Sort headers.
10559         * bsd-uthread.c: Sort headers.
10560         * breakpoint.h: Sort headers.
10561         * breakpoint.c: Sort headers.
10562         * break-catch-throw.c: Sort headers.
10563         * break-catch-syscall.c: Sort headers.
10564         * break-catch-sig.c: Sort headers.
10565         * blockframe.c: Sort headers.
10566         * block.c: Sort headers.
10567         * bfin-tdep.c: Sort headers.
10568         * bfin-linux-tdep.c: Sort headers.
10569         * bfd-target.c: Sort headers.
10570         * bcache.c: Sort headers.
10571         * ax-general.c: Sort headers.
10572         * ax-gdb.h: Sort headers.
10573         * ax-gdb.c: Sort headers.
10574         * avr-tdep.c: Sort headers.
10575         * auxv.c: Sort headers.
10576         * auto-load.c: Sort headers.
10577         * arm-wince-tdep.c: Sort headers.
10578         * arm-tdep.c: Sort headers.
10579         * arm-symbian-tdep.c: Sort headers.
10580         * arm-pikeos-tdep.c: Sort headers.
10581         * arm-obsd-tdep.c: Sort headers.
10582         * arm-nbsd-tdep.c: Sort headers.
10583         * arm-nbsd-nat.c: Sort headers.
10584         * arm-linux-tdep.c: Sort headers.
10585         * arm-linux-nat.c: Sort headers.
10586         * arm-fbsd-tdep.c: Sort headers.
10587         * arm-fbsd-nat.c: Sort headers.
10588         * arm-bsd-tdep.c: Sort headers.
10589         * arch-utils.c: Sort headers.
10590         * arc-tdep.c: Sort headers.
10591         * arc-newlib-tdep.c: Sort headers.
10592         * annotate.h: Sort headers.
10593         * annotate.c: Sort headers.
10594         * amd64-windows-tdep.c: Sort headers.
10595         * amd64-windows-nat.c: Sort headers.
10596         * amd64-tdep.c: Sort headers.
10597         * amd64-sol2-tdep.c: Sort headers.
10598         * amd64-obsd-tdep.c: Sort headers.
10599         * amd64-obsd-nat.c: Sort headers.
10600         * amd64-nbsd-tdep.c: Sort headers.
10601         * amd64-nbsd-nat.c: Sort headers.
10602         * amd64-nat.c: Sort headers.
10603         * amd64-linux-tdep.c: Sort headers.
10604         * amd64-linux-nat.c: Sort headers.
10605         * amd64-fbsd-tdep.c: Sort headers.
10606         * amd64-fbsd-nat.c: Sort headers.
10607         * amd64-dicos-tdep.c: Sort headers.
10608         * amd64-darwin-tdep.c: Sort headers.
10609         * amd64-bsd-nat.c: Sort headers.
10610         * alpha-tdep.c: Sort headers.
10611         * alpha-obsd-tdep.c: Sort headers.
10612         * alpha-nbsd-tdep.c: Sort headers.
10613         * alpha-mdebug-tdep.c: Sort headers.
10614         * alpha-linux-tdep.c: Sort headers.
10615         * alpha-linux-nat.c: Sort headers.
10616         * alpha-bsd-tdep.c: Sort headers.
10617         * alpha-bsd-nat.c: Sort headers.
10618         * aix-thread.c: Sort headers.
10619         * agent.c: Sort headers.
10620         * addrmap.c: Sort headers.
10621         * ada-varobj.c: Sort headers.
10622         * ada-valprint.c: Sort headers.
10623         * ada-typeprint.c: Sort headers.
10624         * ada-tasks.c: Sort headers.
10625         * ada-lang.c: Sort headers.
10626         * aarch64-tdep.c: Sort headers.
10627         * aarch64-ravenscar-thread.c: Sort headers.
10628         * aarch64-newlib-tdep.c: Sort headers.
10629         * aarch64-linux-tdep.c: Sort headers.
10630         * aarch64-linux-nat.c: Sort headers.
10631         * aarch64-fbsd-tdep.c: Sort headers.
10632         * aarch64-fbsd-nat.c: Sort headers.
10633         * aarch32-linux-nat.c: Sort headers.
10634
10635 2019-04-04  Tom Tromey  <tom@tromey.com>
10636
10637         * varobj.c (varobj_create): Update.
10638         * rust-exp.y (struct rust_parser) <update_innermost_block,
10639         lookup_symbol>: New methods.
10640         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10641         Rename.
10642         (rust_parser::rust_lookup_type)
10643         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10644         * printcmd.c (display_command, do_one_display): Update.
10645         * parser-defs.h (struct parser_state) <parser_state>: Add
10646         "tracker" parameter.
10647         (block_tracker): New member.
10648         (class innermost_block_tracker) <innermost_block_tracker>: Add
10649         "types" parameter.
10650         <reset>: Remove method.
10651         (innermost_block): Don't declare.
10652         (null_post_parser): Update.
10653         * parse.c (innermost_block): Remove global.
10654         (write_dollar_variable): Update.
10655         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10656         Remove "tracker_types" parameter.
10657         (parse_expression): Add "tracker" parameter.
10658         (parse_expression_for_completion): Update.
10659         (null_post_parser): Add "tracker" parameter.
10660         * p-exp.y: Update rules.
10661         * m2-exp.y: Update rules.
10662         * language.h (struct language_defn) <la_post_parser>: Add
10663         "tracker" parameter.
10664         * go-exp.y: Update rules.
10665         * f-exp.y: Update rules.
10666         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10667         parameter.
10668         * d-exp.y: Update rules.
10669         * c-exp.y: Update rules.
10670         * breakpoint.c (set_breakpoint_condition): Create an
10671         innermost_block_tracker.
10672         (watch_command_1): Likewise.
10673         * ada-lang.c (resolve): Add "tracker" parameter.
10674         (resolve_subexp): Likewise.
10675         * ada-exp.y (write_var_from_sym): Update.
10676
10677 2019-04-04  Tom Tromey  <tom@tromey.com>
10678
10679         * type-stack.h: New file.
10680         * type-stack.c: New file.
10681         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10682         type-stack.h.
10683         (insert_into_type_stack, insert_type, push_type, push_type_int)
10684         (insert_type_address_space, pop_type, pop_type_int)
10685         (pop_typelist, pop_type_stack, append_type_stack)
10686         (push_type_stack, get_type_stack, push_typelist)
10687         (follow_type_instance_flags, follow_types): Don't declare.
10688         * parse.c (type_stack): Remove global.
10689         (parse_exp_in_context): Update.
10690         (insert_into_type_stack, insert_type, push_type, push_type_int)
10691         (insert_type_address_space, pop_type, pop_type_int)
10692         (pop_typelist, pop_type_stack, append_type_stack)
10693         (push_type_stack, get_type_stack, push_typelist)
10694         (follow_type_instance_flags, follow_types): Remove (moved to
10695         type-stack.c).
10696         * f-exp.y (type_stack): New global.
10697         Update rules.
10698         (push_kind_type, f_parse): Update.
10699         * d-exp.y (type_stack): New global.
10700         Update rules.
10701         (d_parse): Update.
10702         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10703         Update rules.
10704         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10705         (HFILES_NO_SRCDIR): Add type-stack.h.
10706
10707 2019-04-04  Tom Tromey  <tom@tromey.com>
10708
10709         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10710         (rust_parser::convert_ast_to_expression, rust_parse)
10711         (rust_lex_test_completion, rust_lex_tests): Update.
10712         * parser-defs.h (struct expr_completion_state): New.
10713         (struct parser_state) <parser_state>: Add completion parameter.
10714         <mark_struct_expression, mark_completion_tag>: New methods.
10715         <parse_completion, m_completion_state>: New members.
10716         (prefixify_expression, null_post_parser): Update.
10717         (mark_struct_expression, mark_completion_tag): Don't declare.
10718         * parse.c (parse_completion, expout_last_struct)
10719         (expout_tag_completion_type, expout_completion_name): Remove
10720         globals.
10721         (parser_state::mark_struct_expression)
10722         (parser_state::mark_completion_tag): Now methods.
10723         (prefixify_expression): Add last_struct parameter.
10724         (prefixify_subexp): Likewise.
10725         (parse_exp_1): Update.
10726         (parse_exp_in_context): Add cstate parameter.  Update.
10727         (parse_expression_for_completion): Create an
10728         expr_completion_state.
10729         (null_post_parser): Add "completion" parameter.
10730         * p-exp.y: Update rules.
10731         (yylex): Update.
10732         * language.h (struct language_defn) <la_post_parser>: Add
10733         "completing" parameter.
10734         * go-exp.y: Update rules.
10735         (lex_one_token): Update.
10736         * expression.h (parse_completion): Don't declare.
10737         * d-exp.y: Update rules.
10738         (lex_one_token): Update rules.
10739         * c-exp.y: Update rules.
10740         (lex_one_token): Update.
10741         * ada-lang.c (resolve): Add "parse_completion" parameter.
10742         (resolve_subexp): Likewise.
10743         (ada_resolve_function): Likewise.
10744
10745 2019-04-04  Tom Tromey  <tom@tromey.com>
10746
10747         * parser-defs.h (struct parser_state) <start_arglist,
10748         end_arglist>: New methods.
10749         <arglist_len, m_funcall_chain>: New members.
10750         (arglist_len, start_arglist, end_arglist): Don't declare.
10751         * parse.c (arglist_len, funcall_chain): Remove global.
10752         (start_arglist, end_arglist): Remove functions.
10753         (parse_exp_in_context): Update.
10754         * p-exp.y: Update rules.
10755         * m2-exp.y: Update rules.
10756         * go-exp.y: Update rules.
10757         * f-exp.y: Update rules.
10758         * d-exp.y: Update rules.
10759         * c-exp.y: Update rules.
10760
10761 2019-04-04  Tom Tromey  <tom@tromey.com>
10762
10763         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10764         lex_operator, push_back>: New methods.
10765         Update all rules.
10766         (rust_parser::lex_hex, lex_escape): Rename and update.
10767         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10768         (rust_parser::lex_operator): Rename and update.
10769         (rust_parser::lex_number, rustyylex, rustyyerror)
10770         (rust_lex_test_init, rust_lex_test_sequence)
10771         (rust_lex_test_push_back, rust_lex_tests): Update.
10772         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10773         parameter.
10774         <lexptr, prev_lexptr>: New members.
10775         (lexptr, prev_lexptr): Don't declare.
10776         * parse.c (lexptr, prev_lexptr): Remove globals.
10777         (parse_exp_in_context): Update.
10778         * p-exp.y (yylex, yyerror): Update.
10779         * m2-exp.y (parse_number, yylex, yyerror): Update.
10780         * go-exp.y (lex_one_token, yyerror): Update.
10781         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10782         * d-exp.y (lex_one_token, yyerror): Update.
10783         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10784         (lex_one_token, yyerror): Update.
10785         * ada-lex.l (YY_INPUT): Update.
10786         (rewind_to_char): Update.
10787         * ada-exp.y (yyerror): Update.
10788
10789 2019-04-04  Tom Tromey  <tom@tromey.com>
10790
10791         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10792         * parser-defs.h (struct parser_state) <parser_state>: Add new
10793         parameter.
10794         <comma_terminates>: New member.
10795         (comma_terminates): Don't declare global.
10796         * parse.c (comma_terminates): Remove global.
10797         (parse_exp_in_context): Update.
10798         * p-exp.y (yylex): Update.
10799         * m2-exp.y (yylex): Update.
10800         * go-exp.y (lex_one_token): Update.
10801         * f-exp.y (yylex): Update.
10802         * d-exp.y (lex_one_token): Update.
10803         * c-exp.y (lex_one_token): Update.
10804         * ada-lex.l: Update.
10805
10806 2019-04-04  Tom Tromey  <tom@tromey.com>
10807
10808         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10809         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10810         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10811         * parser-defs.h (paren_depth): Don't declare.
10812         * parse.c (paren_depth): Remove global.
10813         (parse_exp_in_context): Update.
10814         * p-exp.y (paren_depth): New global.
10815         (pascal_parse): Initialize it.
10816         * m2-exp.y (paren_depth): New global.
10817         (m2_parse): Initialize it.
10818         * go-exp.y (paren_depth): New global.
10819         (go_parse): Initialize it.
10820         * f-exp.y (paren_depth): New global.
10821         (f_parse): Initialize it.
10822         * d-exp.y (paren_depth): New global.
10823         (d_parse): Initialize it.
10824         * c-exp.y (paren_depth): New global.
10825         (c_parse): Initialize it.
10826         * ada-lex.l (paren_depth): New global.
10827         (lexer_init): Initialize it.
10828
10829 2019-04-04  Tom Tromey  <tom@tromey.com>
10830
10831         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10832         (rust_parser::convert_ast_to_type)
10833         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10834         * parser-defs.h (struct parser_state) <parser_state>: Add
10835         parameters.  Initialize new members.
10836         <expression_context_block, expression_context_pc>: New members.
10837         * parse.c (expression_context_block, expression_context_pc):
10838         Remove globals.
10839         (parse_exp_in_context): Update.
10840         * p-exp.y: Update all rules.
10841         (yylex): Update.
10842         * m2-exp.y: Update all rules.
10843         (yylex): Update.
10844         * go-exp.y (yylex): Update.
10845         * f-exp.y (yylex): Update.
10846         * d-exp.y: Update all rules.
10847         (yylex): Update.
10848         * c-exp.y: Update all rules.
10849         (lex_one_token, classify_name, yylex, c_parse): Update.
10850         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10851
10852 2019-04-04  Tom Tromey  <tom@tromey.com>
10853
10854         * gdbarch.h, gdbarch.c: Rebuild.
10855         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10856         * stap-probe.h:
10857         (struct stap_parse_info): Replace "parser_state" with
10858         "expr_builder".
10859         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10860         (parser_state): New class.
10861         * parse.c (expr_builder): Rename.
10862         (expr_builder::release): Rename.
10863         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10864         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10865         (write_exp_elt_longcst, write_exp_elt_floatcst)
10866         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10867         (write_exp_string_vector, write_exp_bitstring)
10868         (write_exp_msymbol, mark_struct_expression)
10869         (write_dollar_variable)
10870         (insert_type_address_space, increase_expout_size): Replace
10871         "parser_state" with "expr_builder".
10872         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10873         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10874         "parser_state" with "expr_builder".
10875
10876 2019-04-04  Tom Tromey  <tom@tromey.com>
10877
10878         * rust-exp.y: Replace "parse_language" with method call.
10879         * p-exp.y:
10880         (yylex): Replace "parse_language" with method call.
10881         * m2-exp.y:
10882         (yylex): Replace "parse_language" with method call.
10883         * go-exp.y (classify_name): Replace "parse_language" with method
10884         call.
10885         * f-exp.y (yylex): Replace "parse_language" with method call.
10886         * d-exp.y (lex_one_token): Replace "parse_language" with method
10887         call.
10888         * c-exp.y:
10889         (lex_one_token, classify_name, yylex): Replace "parse_language"
10890         with method call.
10891         * ada-exp.y (find_primitive_type, type_char)
10892         (type_system_address): Replace "parse_language" with method call.
10893
10894 2019-04-04  Tom Tromey  <tom@tromey.com>
10895
10896         * rust-exp.y: Replace "parse_gdbarch" with method call.
10897         * parse.c (write_dollar_variable, insert_type_address_space):
10898         Replace "parse_gdbarch" with method call.
10899         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10900         call.
10901         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10902         call.
10903         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10904         "parse_gdbarch" with method call.
10905         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10906         with method call.
10907         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10908         "parse_gdbarch" with method call.
10909         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10910         "parse_gdbarch" with method call.
10911         * c-exp.y (parse_type, parse_number, classify_name): Replace
10912         "parse_gdbarch" with method call.
10913         * ada-lex.l: Replace "parse_gdbarch" with method call.
10914         * ada-exp.y (parse_type, find_primitive_type, type_char)
10915         (type_system_address): Replace "parse_gdbarch" with method call.
10916
10917 2019-04-04  Tom Tromey  <tom@tromey.com>
10918
10919         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10920         * stap-probe.c (stap_parse_argument): Update.
10921         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10922         initial_size parameter.
10923         * rust-exp.y (rust_lex_tests): Update.
10924         * parse.c (parser_state): Update.
10925         (parse_exp_in_context): Update.
10926         * parser-defs.h (struct parser_state) <parser_state>: Remove
10927         "initial_size" parameter.
10928
10929 2019-04-04  Tom Tromey  <tom@tromey.com>
10930
10931         * parser-defs.h (increase_expout_size): Don't declare.
10932         * parse.c (increase_expout_size): Now static.
10933
10934 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10935
10936         * gnu-nat.c (gnu_nat_target::wait): Fix
10937         target_waitstatus_to_string call.
10938
10939 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10940
10941         * eval.c (evaluate_subexp_standard): Handle internal functions
10942         during Fortran function call handling.
10943
10944 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10945
10946         * NEWS: Mention new internal functions.
10947         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10948         (read_base_type): Use dwarf2_init_complex_target_type.
10949         * value.c (creal_internal_fn): New function.
10950         (cimag_internal_fn): New function.
10951         (_initialize_values): Register new internal functions.
10952
10953 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10954
10955         * infrun.c (stop_all_threads): If debug_infrun, always
10956         trace the wait status after wait_one, using
10957         target_waitstatus_to_string and target_pid_to_str.
10958         (handle_inferior_event): Replace various trace of
10959         wait status kind by a single trace.
10960         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10961         wait status kind image by target_waitstatus_to_string.
10962         * target/waitstatus.c (target_waitstatus_to_string): Fix
10963         obsolete comment.
10964
10965 2019-04-01  Tom Tromey  <tromey@adacore.com>
10966
10967         PR symtab/23331:
10968         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10969
10970 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10971             Pedro Alves  <palves@redhat.com>
10972
10973         * top.c (quit_force): Call 'finalize_values'.
10974         * value.c (finalize_values): New function.
10975         * value.h (finalize_values): Declare.
10976
10977 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10978
10979         * NEWS: Announce $_gdb_major and $_gdb_minor.
10980
10981         * top.c (init_gdb_version_vars): New function.
10982         (gdb_init): Call init_gdb_version_vars.
10983
10984 2019-03-29  Tom Tromey  <tromey@adacore.com>
10985
10986         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10987         help text.  Remove dead code.
10988
10989 2019-03-29  Keith Seitz  <keiths@redhat.com>
10990
10991         From Siddhesh Poyarekar:
10992         * f-lang.h (f77_get_upperbound): Return LONGEST.
10993         (f77_get_lowerbound): Likewise.
10994         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10995         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10996         print them.
10997         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10998         plongest to format print it.
10999         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11000         (f77_get_upperbound): Likewise.
11001         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11002         LOWER_BOUND to LONGEST.
11003         (f77_create_arrayprint_offset_tbl): Likewise.
11004
11005 2019-03-29  Keith Seitz  <keiths@redhat.com>
11006
11007         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11008         %s/pulongest for TYPE_LENGTH instead of %d in format
11009         strings.
11010         * ada-typerint.c (ada_print_type): Likewise.
11011         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11012         * compile/compile-c-support.c (generate_register_struct): Likewise.
11013         * gdbtypes.c (recursive_dump_type): Likewise.
11014         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11015         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11016         instead of %d in format strings.
11017         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11018         to std::min to ULONGEST.
11019         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11020         instead of %d in format strings.
11021         * tracepoint.c (info_scope_command): Likewise.
11022         * typeprint.c (print_offset_data::update)
11023         (print_offset_data::finish): Likewise.
11024         * xtensa-tdep.c (xtensa_store_return_value)
11025         (xtensa_push_dummy_call): Likewise.
11026
11027 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11028
11029         * windows-nat.c (display_selector): Fixed format specifications
11030         for 64-bit Cygwin.
11031
11032 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11033
11034         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11035
11036 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11037
11038         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11039         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11040         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11041         (nios2_linux_init_abi): Install it.
11042
11043 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11044
11045         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11046
11047 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11048
11049         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11050
11051 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11052             Tom Tromey  <tromey@adacore.com>
11053
11054         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11055
11056 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11057
11058         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11059         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11060         method to compute the bounds of range types. Also print "[evaluated]"
11061         if the bounds' values come from a dynamic evaluation.
11062
11063 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11064
11065         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11066         whitespace when pretty printing is on.
11067
11068 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11069
11070         * ppc-linux-nat.c: Add include.
11071
11072 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11073
11074         * NEWS: Mention AArch64 Pointer Authentication.
11075
11076 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11077
11078         * arm-linux-nat.c: Add include.
11079
11080 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11081
11082         * source-cache.c (source_cache::get_source_lines): Re-read
11083         fullname after calling open_source_file.
11084
11085 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11086
11087         * NEWS: Mention TLS support for FreeBSD.
11088
11089 2019-03-25  Tom Tromey  <tromey@adacore.com>
11090
11091         * minsyms.c (BUNCH_SIZE): Update comment.
11092         (~minimal_symbol_reader): Remove old comment.
11093         (compact_minimal_symbols): Update comment.
11094         (minimal_symbol_reader::install): Remove old comment.  Update
11095         other comments.
11096
11097 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11098
11099         * s390-linux-nat.c: Add include.
11100
11101 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11102
11103         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11104         Call linux_get_hwcap.
11105         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11106         Likewise.
11107         (aarch64_linux_get_hwcap): Remove function.
11108         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11109         declaration.
11110         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11111         linux_get_hwcap.
11112         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11113         * linux-tdep.c (linux_get_hwcap): Add function.
11114         (linux_get_hwcap2): Likewise.
11115         * linux-tdep.h (linux_get_hwcap): Add declaration.
11116         (linux_get_hwcap2): Likewise.
11117         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11118         (ppc_linux_get_hwcap2): Likewise.
11119         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11120         linux_get_hwcap.
11121         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11122         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11123         (ppc_linux_nat_target::read_description): Likewise.
11124         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11125         * s390-linux-nat.c: Likewise.
11126         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11127
11128 2019-03-24  Tom Tromey  <tom@tromey.com>
11129
11130         * ada-lang.c (standard_lookup): Simplify initialization.
11131         (ada_lookup_symbol_nonlocal): Simplify return.
11132         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11133         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11134         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11135         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11136         initialization.
11137         * solib.c (solib_global_lookup): Simplify.
11138         * symtab.c (null_block_symbol): Remove.
11139         (symbol_cache_lookup): Simplify returns.
11140         (lookup_language_this): Simplify returns.
11141         (lookup_symbol_aux): Simplify return.
11142         (lookup_local_symbol): Simplify returns.
11143         (lookup_global_symbol_from_objfile): Simplify return.
11144         (lookup_symbol_in_objfile_symtabs)
11145         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11146         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11147         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11148         * cp-namespace.c (cp_lookup_bare_symbol)
11149         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11150         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11151         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11152         (cp_lookup_symbol_via_imports): Simplify initialization.
11153         (find_symbol_in_baseclass): Likewise.
11154         * symtab.h (null_block_symbol): Remove.
11155         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11156         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11157         (d_lookup_symbol_module): Likewise.
11158         (find_symbol_in_baseclass): Simplify initialization.
11159
11160 2019-03-24  Tom Tromey  <tom@tromey.com>
11161
11162         * expression.h: Don't include symtab.h.
11163         (struct block): Forward declare.
11164
11165 2019-03-24  Tom Tromey  <tom@tromey.com>
11166
11167         * c-exp.y (typebase): Remove casts.
11168         * gdbtypes.c (lookup_unsigned_typename, )
11169         (lookup_signed_typename): Remove cast.
11170         * eval.c (parse_to_comma_and_eval): Remove cast.
11171         * parse.c (write_dollar_variable): Remove cast.
11172         * block.h (struct block) <superblock>: Now const.
11173         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11174         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11175         (map_block): Make "block" const.
11176         * symfile.h (struct quick_symbol_functions)
11177         <map_matching_symbols>: Constify block argument to "callback".
11178         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11179         const.
11180         (find_pc_sect_compunit_symtab): Make "b" const.
11181         (find_symbol_at_address): Likewise.
11182         (search_symbols): Likewise.
11183         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11184         (dw2_debug_names_lookup_symbol): Likewise.
11185         (dw2_map_matching_symbols): Update.
11186         * p-valprint.c (pascal_val_print): Remove "block".
11187         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11188         (aux_add_nonlocal_symbols): Make "block" const.
11189         (resolve_subexp): Remove cast.
11190         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11191         const.
11192         (iterate_over_file_blocks): Likewise.
11193         * f-exp.y (%union) <bval>: Remove.
11194         * coffread.c (patch_opaque_types): Make "b" const.
11195         * spu-tdep.c (spu_catch_start): Make "block" const.
11196         * c-valprint.c (print_unpacked_pointer): Remove "block".
11197         * symmisc.c (dump_symtab_1): Make "b" const.
11198         (block_depth): Make "block" const.
11199         * d-exp.y (%union) <bval>: Remove.
11200         * cp-support.h (cp_lookup_rtti_type): Update.
11201         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11202         * psymtab.c (psym_lookup_symbol): Make "block" const.
11203         (maintenance_check_psymtabs): Make "b" const.
11204         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11205         (enumerate_locals, enumerate_args): Update.
11206         * python/py-symtab.c (stpy_global_block): Make "block" const.
11207         (stpy_static_block): Likewise.
11208         * inline-frame.c (block_starting_point_at): Make "new_block"
11209         const.
11210         * block.c (find_block_in_blockvector): Make return type const.
11211         (blockvector_for_pc_sect): Make "b" const.
11212         (find_block_in_blockvector): Make "b" const.
11213
11214 2019-03-23  Tom Tromey  <tom@tromey.com>
11215
11216         * varobj.c (varobj_create): Update.
11217         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11218         * printcmd.c (display_command, do_one_display): Don't reset
11219         innermost_block.
11220         * parser-defs.h (enum innermost_block_tracker_type): Move to
11221         expression.h.
11222         (innermost_block): Update comment.
11223         * parse.c (parse_exp_1): Add tracker_types parameter.
11224         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11225         tracker_types parameter.  Reset innermost_block.
11226         (parse_exp_in_context): Remove.
11227         (parse_expression_for_completion): Update.
11228         * objfiles.c (~objfile): Don't reset expression_context_block or
11229         innermost_block.
11230         * expression.h (enum innermost_block_tracker_type): Move from
11231         parser-defs.h.
11232         (parse_exp_1): Add tracker_types parameter.
11233         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11234         reset innermost_block.
11235
11236 2019-03-23  Tom Tromey  <tom@tromey.com>
11237
11238         * objfiles.h: Include bcache.h.
11239
11240 2019-03-23  Tom Tromey  <tom@tromey.com>
11241
11242         * linespec.c (get_current_search_block): Use
11243         scoped_restore_current_language.
11244         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11245
11246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11247             Jiong Wang  <jiong.wang@arm.com>
11248
11249         * aarch64-linux-tdep.c
11250         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11251         section.
11252         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11253
11254 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11255             Jiong Wang  <jiong.wang@arm.com>
11256
11257         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11258         instructions.
11259         (aarch64_analyze_prologue_test): Add PACIASP test.
11260         (aarch64_prologue_prev_register): Unmask PC value.
11261
11262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11263             Jiong Wang  <jiong.wang@arm.com>
11264
11265         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11266         (aarch64_dwarf2_prev_register): Unmask PC value.
11267         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11268         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11269         DW_CFA_AARCH64_negate_ra_state.
11270         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11271
11272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11273             Jiong Wang  <jiong.wang@arm.com>
11274
11275         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11276         registers.
11277         (aarch64_pseudo_register_name): Likewise.
11278         (aarch64_pseudo_register_type): Likewise.
11279         (aarch64_pseudo_register_reggroup_p): Likewise.
11280         (aarch64_gdbarch_init): Add pauth registers.
11281         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11282         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11283         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11284         (struct gdbarch_tdep): Add regnum for ra_state.
11285
11286 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11287             Jiong Wang  <jiong.wang@arm.com>
11288
11289         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11290
11291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11292             Jiong Wang  <jiong.wang@arm.com>
11293
11294         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11295         function.
11296         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11297         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11298         (aarch64_gdbarch_init): Add puth registers.
11299         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11300         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11301         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11302
11303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11304             Jiong Wang  <jiong.wang@arm.com>
11305
11306         * aarch64-linux-nat.c
11307         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11308         * aarch64-linux-tdep.c
11309         (aarch64_linux_core_read_description): Likewise.
11310         (aarch64_linux_get_hwcap): New function.
11311         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11312         (aarch64_linux_get_hwcap): New declaration.
11313
11314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11315             Jiong Wang  <jiong.wang@arm.com>
11316
11317         * aarch64-linux-nat.c
11318         (aarch64_linux_nat_target::read_description): Add pauth param.
11319         * aarch64-linux-tdep.c
11320         (aarch64_linux_core_read_description): Likewise.
11321         * aarch64-tdep.c (struct target_desc): Add in pauth.
11322         (aarch64_read_description): Add pauth param.
11323         (aarch64_gdbarch_init): Likewise.
11324         * aarch64-tdep.h (aarch64_read_description): Likewise.
11325         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11326         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11327         * features/Makefile: Add new files.
11328         * features/aarch64-pauth.c: New file.
11329         * features/aarch64-pauth.xml: New file.
11330
11331 2019-03-20  Tom Tromey  <tromey@adacore.com>
11332
11333         * infrun.c (handle_inferior_event): Rename from
11334         handle_inferior_event_1.  Create a scoped_value_mark.
11335         (handle_inferior_event): Remove.
11336
11337 2019-03-19  Tom Tromey  <tromey@adacore.com>
11338
11339         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11340         * infrun.h (print_stop_event): Add "displays" parameter.
11341         * infrun.c (print_stop_event): Add "displays" parameter.
11342
11343 2019-03-19  Pedro Alves  <palves@redhat.com>
11344
11345         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11346         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11347         to -1.  Fix TABs vs spaces.
11348         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11349         * tui/tui-out.h (tui_ui_out) Add intro comments.
11350         <m_line, m_start_of_line>: In-class initialize, and add describing
11351         comment.
11352
11353 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11354
11355         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11356         variable names.
11357         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11358
11359 2019-03-18  Pedro Alves  <palves@redhat.com>
11360             Eli Zaretskii <eliz@gnu.org>
11361
11362         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11363         m_line and m_start_of_line.
11364
11365 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11366
11367         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11368         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11369         it returns a newline.  This fixes a regression in TU mode, whereby
11370         the next line is output on the same screen line as the user input.
11371
11372 2019-03-18  Tom Tromey  <tromey@adacore.com>
11373
11374         * minsyms.c (minimal_symbol_reader::install): Remove call to
11375         obstack_blank.
11376
11377 2019-03-18  Pedro Alves  <palves@redhat.com>
11378
11379         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11380         New globals.
11381         (apply_style): New, factored out from ...
11382         (apply_ansi_escape): ... this.  Handle reverse video mode.
11383         (tui_set_reverse_mode): New function.
11384         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11385         * tui/tui-winsource.c (tui_show_source_line): Use
11386         tui_set_reverse_mode instead of setting A_STANDOUT.
11387         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11388         New setter methods.
11389
11390 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11391
11392         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11393         Handle tabs.
11394
11395 2019-03-18  Tom Tromey  <tromey@adacore.com>
11396
11397         * ada-lang.c (empty_array): Add "high" parameter.
11398         (ada_evaluate_subexp): Update.
11399
11400 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11401
11402         * unittests/string_view-selftests.c: Define
11403         _initialize_string_view_selftests unconditionally.
11404
11405 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11406
11407         PR gdb/24350
11408         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11409
11410 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11411
11412         PR gdb/24351
11413         * windows-nat.c (display_selector): Fix format specifiers.
11414
11415 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11416
11417         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11418         tui_refill_source_window instead of tui_refresh_win, to update the
11419         current execution line.  This fixes redisplay of the current line
11420         when stepping through the code with "next" or "step".
11421
11422 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11423
11424         * source-cache.c (source_cache::get_source_lines): Call
11425         find_source_lines to initialize s->nlines.  This fixes vertical
11426         scrolling of TUI source window when the DOWN arrow is pressed.
11427
11428 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11429
11430         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11431         linux-thread-db.c (_initialize_thread_db): Likewise.
11432
11433 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11434
11435         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11436         wclrtoeol in tui_show_source_line".  This reverts changes made in
11437         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11438
11439 2019-03-15  Tom Tromey  <tom@tromey.com>
11440
11441         * symtab.h (struct minimal_symbol): Derive from
11442         general_symbol_info.
11443         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11444         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11445         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11446         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11447         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11448         (MSYMBOL_SEARCH_NAME): Update.
11449         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11450         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11451         * minsyms.c (minimal_symbol_reader::record_full): Update.
11452
11453 2019-03-15  Tom Tromey  <tom@tromey.com>
11454
11455         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11456
11457 2019-03-15  Tom Tromey  <tom@tromey.com>
11458
11459         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11460         unique_xmalloc_ptr.
11461         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11462         Update.
11463         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11464         (build_minimal_symbol_hash_tables)
11465         (minimal_symbol_reader::install): Update.
11466
11467 2019-03-15  Tom Tromey  <tom@tromey.com>
11468
11469         * symtab.c (create_demangled_names_hash): Update.
11470         (symbol_set_names): Update.
11471         * objfiles.h (struct objfile_per_bfd_storage)
11472         <demangled_names_hash>: Now an htab_up.
11473         * objfiles.c (objfile_per_bfd_storage): Simplify.
11474
11475 2019-03-15  Tom Tromey  <tom@tromey.com>
11476
11477         * objfiles.h (struct objfile_per_bfd_storage): Declare
11478         destructor.
11479         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11480         New.
11481         (get_objfile_bfd_data): Use new.  Don't initialize
11482         language_of_main.
11483         (free_objfile_per_bfd_storage): Remove.
11484         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11485
11486 2019-03-15  Tom Tromey  <tom@tromey.com>
11487
11488         * symfile.c (reread_symbols): Update.
11489         * objfiles.c (objfile::objfile): Update.
11490         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11491         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11492         comment.
11493         (minimal_symbol_reader::install): Update.
11494         (terminate_minimal_symbol_table): Remove.
11495         * jit.c (jit_object_close_impl): Update.
11496
11497 2019-03-15  Tom Tromey  <tom@tromey.com>
11498
11499         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11500         initializations.
11501
11502 2019-03-15  Tom Tromey  <tom@tromey.com>
11503
11504         * objfiles.h (struct objfile_per_bfd_storage)
11505         <demangled_hash_languages>: Now a bitset.
11506         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11507         (lookup_minimal_symbol): Update.
11508
11509 2019-03-15  Tom Tromey  <tom@tromey.com>
11510
11511         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11512         Don't return the symbol.
11513         * coffread.c (record_minimal_symbol): Use record_full.
11514
11515 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11516
11517         The MS-Windows port of ncurses fails to switch to a color pair if
11518         one or both of the colors are the implicit default colors.  This
11519         change records the default colors when TUI is initialized, and
11520         then specifies them explicitly when a color pair uses the default
11521         colors.  This allows color styling in TUI mode on MS-Windows.
11522
11523         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11524         ncurses_norm_attr.
11525         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11526         colors in ncurses_norm_attr.
11527         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11528         "none", replace it with the default color recorded in
11529         ncurses_norm_attr.
11530
11531 2019-03-14  Tom Tromey  <tromey@adacore.com>
11532
11533         * source-cache.h (class source_cache) <get_source_lines>: Return
11534         std::string.
11535         * source-cache.c (source_cache::extract_lines): Handle case where
11536         first_pos==npos.  Return std::string.
11537         (source_cache::get_source_lines): Update.
11538
11539 2019-03-14  Tom Tromey  <tromey@adacore.com>
11540
11541         * NEWS: Add item for "style sources" commands.
11542         * source-cache.c (source_cache::get_source_lines): Check
11543         source_styling.
11544         * cli/cli-style.c (source_styling): New global.
11545         (_initialize_cli_style): Add "style sources" commands.
11546         (show_style_sources): New function.
11547         * cli/cli-style.h (source_styling): Declare.
11548
11549 2019-03-14  Pedro Alves  <palves@redhat.com>
11550             Tom Tromey  <tromey@adacore.com>
11551
11552         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11553         * tui/tui-winsource.c (tui_refill_source_window): New function,
11554         from...
11555         (tui_horizontal_source_scroll): ... here.  Move some logic.
11556         * cli/cli-style.c (set_style_enabled): Notify new observable.
11557         * tui/tui-hooks.c (tui_redisplay_source): New function.
11558         (tui_attach_detach_observers): Attach or detach
11559         tui_redisplay_source.
11560         * observable.h (source_styling_changed): New observable.
11561         * observable.c: Define source_styling_changed observable.
11562
11563 2019-03-13  Tom Tromey  <tromey@adacore.com>
11564
11565         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11566         (i386_gnu_nat_target::store_registers): Update.
11567         * target-debug.h (target_debug_print_std_string): New macro.
11568         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11569         * windows-tdep.c (display_one_tib): Update.
11570         * tui/tui-stack.c (tui_make_status_line): Update.
11571         * top.c (print_inferior_quit_action): Update.
11572         * thread.c (thr_try_catch_cmd): Update.
11573         (add_thread_with_info): Update.
11574         (thread_target_id_str): Update.
11575         (thr_try_catch_cmd): Update.
11576         (thread_command): Update.
11577         (thread_find_command): Update.
11578         * record-btrace.c (record_btrace_target::info_record)
11579         (record_btrace_resume_thread, record_btrace_target::resume)
11580         (record_btrace_cancel_resume, record_btrace_step_thread)
11581         (record_btrace_target::wait, record_btrace_target::wait)
11582         (record_btrace_target::wait, record_btrace_target::stop): Update.
11583         * progspace.c (print_program_space): Update.
11584         * process-stratum-target.c
11585         (process_stratum_target::thread_address_space): Update.
11586         * linux-fork.c (linux_fork_mourn_inferior)
11587         (detach_checkpoint_command, info_checkpoints_command)
11588         (linux_fork_context): Update.
11589         (linux_fork_detach): Update.
11590         (class scoped_switch_fork_info): Update.
11591         (delete_checkpoint_command): Update.
11592         * infrun.c (follow_fork_inferior): Update.
11593         (follow_fork_inferior): Update.
11594         (proceed_after_vfork_done): Update.
11595         (handle_vfork_child_exec_or_exit): Update.
11596         (follow_exec): Update.
11597         (displaced_step_prepare_throw): Update.
11598         (displaced_step_restore): Update.
11599         (start_step_over): Update.
11600         (resume_1): Update.
11601         (clear_proceed_status_thread): Update.
11602         (proceed): Update.
11603         (print_target_wait_results): Update.
11604         (do_target_wait): Update.
11605         (context_switch): Update.
11606         (stop_all_threads): Update.
11607         (restart_threads): Update.
11608         (finish_step_over): Update.
11609         (handle_signal_stop): Update.
11610         (switch_back_to_stepped_thread): Update.
11611         (keep_going_pass_signal): Update.
11612         (print_exited_reason): Update.
11613         (normal_stop): Update.
11614         * inferior.c (inferior_pid_to_str): Change return type.
11615         (print_selected_inferior): Update.
11616         (add_inferior): Update.
11617         (detach_inferior): Update.
11618         * dummy-frame.c (fprint_dummy_frames): Update.
11619         * dcache.c (dcache_info_1): Update.
11620         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11621         (btrace_fetch, btrace_clear): Update.
11622         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11623         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11624         type.
11625         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11626         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11627         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11628         * gdbarch.c, gdbarch.h: Rebuild.
11629         * gdbarch.sh (core_pid_to_str): Change return type.
11630         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11631         return type.
11632         (windows_nat_target::pid_to_str): Change return type.
11633         (windows_delete_thread): Update.
11634         (windows_nat_target::attach): Update.
11635         (windows_nat_target::files_info): Update.
11636         * target-delegates.c: Rebuild.
11637         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11638         return type.
11639         (sol_thread_target::pid_to_str): Change return type.
11640         * remote.c (class remote_target) <pid_to_str>: Change return
11641         type.
11642         (remote_target::pid_to_str): Change return type.
11643         (extended_remote_target::attach, remote_target::remote_stop_ns)
11644         (remote_target::remote_notif_remove_queued_reply)
11645         (remote_target::push_stop_reply, remote_target::disable_btrace):
11646         Update.
11647         (extended_remote_target::attach): Update.
11648         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11649         type.
11650         (gdbsim_target::pid_to_str): Change return type.
11651         * ravenscar-thread.c (struct ravenscar_thread_target)
11652         <pid_to_str>: Change return type.
11653         (ravenscar_thread_target::pid_to_str): Change return type.
11654         * procfs.c (class procfs_target) <pid_to_str>: Change return
11655         type.
11656         (procfs_target::pid_to_str): Change return type.
11657         (procfs_target::attach): Update.
11658         (procfs_target::detach): Update.
11659         (procfs_target::fetch_registers): Update.
11660         (procfs_target::store_registers): Update.
11661         (procfs_target::wait): Update.
11662         (procfs_target::files_info): Update.
11663         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11664         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11665         return type.
11666         (nto_procfs_target::pid_to_str): Change return type.
11667         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11668         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11669         return type.
11670         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11671         (exit_lwp): Update.
11672         (attach_proc_task_lwp_callback, get_detach_signal)
11673         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11674         (linux_nat_target::resume, wait_lwp, stop_callback)
11675         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11676         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11677         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11678         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11679         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11680         type.
11681         (inf_ptrace_target::attach): Update.
11682         (inf_ptrace_target::files_info): Update.
11683         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11684         type.
11685         (go32_nat_target::pid_to_str): Change return type.
11686         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11687         (gnu_nat_target::wait): Update.
11688         (gnu_nat_target::wait): Update.
11689         (gnu_nat_target::resume): Update.
11690         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11691         (fbsd_nat_target::wait): Update.
11692         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11693         type.
11694         (darwin_nat_target::attach): Update.
11695         * corelow.c (class core_target) <pid_to_str>: Change return type.
11696         (core_target::pid_to_str): Change return type.
11697         * target.c (normal_pid_to_str): Change return type.
11698         (default_pid_to_str): Likewise.
11699         (target_pid_to_str): Change return type.
11700         (target_translate_tls_address): Update.
11701         (target_announce_detach): Update.
11702         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11703         return type.
11704         (bsd_uthread_target::pid_to_str): Change return type.
11705         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11706         type.
11707         (bsd_kvm_target::pid_to_str): Change return type.
11708         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11709         return type.
11710         (aix_thread_target::pid_to_str): Change return type.
11711         * target.h (struct target_ops) <pid_to_str>: Change return type.
11712         (target_pid_to_str, normal_pid_to_str): Likewise.
11713         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11714         type.
11715         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11716         type.
11717         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11718         return type.
11719         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11720         type.
11721         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11722         type.
11723         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11724         return type.
11725
11726 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11727
11728         * NEWS: Mention that the new default MI version is 3.  Mention
11729         changes to the output of commands and events that deal with
11730         multi-location breakpoints.
11731         * breakpoint.c: Include "mi/mi-out.h".
11732         (print_one_breakpoint): Change output syntax if using MI version
11733         >= 3.
11734         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11735         New.
11736         (mi_multi_location_breakpoint_output_fixed): New.
11737         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11738         (mi_cmd_fix_multi_location_breakpoint_output): New.
11739         (mi_multi_location_breakpoint_output_fixed): New.
11740         * mi/mi-cmds.c (mi_cmds): Register command
11741         -fix-multi-location-breakpoint-output.
11742         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11743         interpreter "mi".
11744
11745 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11746
11747         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11748         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11749         instantiate mi_ui_out based on interpreter name.
11750         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11751         * mi/mi-main.c (mi_load_progress): Likewise.
11752
11753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11754
11755         * NEWS: Combine separate "New targets" sections for 8.3.
11756
11757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11758
11759         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11760         (ppcfbsd_init_abi): Install gdbarch
11761         "fetch_tls_load_module_address" and "get_thread_local_address"
11762         methods.
11763
11764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11765
11766         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11767         (riscv_fbsd_init_abi): Install gdbarch
11768         "fetch_tls_load_module_address" and "get_thread_local_address"
11769         methods.
11770
11771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11772
11773         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11774         (i386fbsd_init_abi): Install gdbarch
11775         "fetch_tls_load_module_address" and "get_thread_local_address"
11776         methods.
11777
11778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11779
11780         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11781         (amd64fbsd_init_abi): Install gdbarch
11782         "fetch_tls_load_module_address" and "get_thread_local_address"
11783         methods.
11784
11785 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11786
11787         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11788         (struct fbsd_pspace_data): New type.
11789         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11790         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11791         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11792         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11793         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11794
11795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11796
11797         * gdbtypes.c (lookup_struct_elt): New function.
11798         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11799         * gdbtypes.h (struct struct_elt): New type.
11800         (lookup_struct_elt): New prototype.
11801
11802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11803
11804         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11805         remove disabled code block.
11806
11807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11808
11809         * gdbarch.sh (get_thread_local_address): New method.
11810         * gdbarch.h, gdbarch.c: Regenerate.
11811         * target.c (target_translate_tls_address): Use
11812         gdbarch_get_thread_local_address if present instead of
11813         target::get_thread_local_address.
11814
11815 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11816
11817         * target.h (target::get_thread_local_address): Update comment.
11818
11819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11820
11821         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11822         objfile->separate_debug_objfile_backlink if not NULL.
11823
11824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11825
11826         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11827         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11828         (amd64bsd_store_inferior_registers): Likewise.
11829         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11830         Enable segment base registers.
11831         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11832         PT_GETFSBASE and PT_GETGSBASE.
11833         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11834         PT_SETGSBASE.
11835         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11836         segment base registers.
11837         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11838
11839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11840
11841         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11842         Update calls to i386_target_description to add 'segments'
11843         parameter.
11844         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11845         add segment base registers.
11846         * arch/i386.c (i386_create_target_description): Add 'segments'
11847         parameter to enable segment base registers.
11848         * arch/i386.h (i386_create_target_description): Likewise.
11849         * features/i386/32bit-segments.xml: New file.
11850         * features/i386/32bit-segments.c: Generate.
11851         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11852         call to i386_target_description to add 'segments' parameter.
11853         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11854         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11855         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11856         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11857         if feature is present.
11858         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11859         Add 'segments' parameter to call to i386_target_description.
11860         (i386_target_description): Add 'segments' parameter to enable
11861         segment base registers.
11862         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11863         to call to i386_target_description.
11864         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11865         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11866         Define I386_NUM_REGS.
11867         (i386_target_description): Add 'segments' parameter to enable
11868         segment base registers.
11869
11870 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11871
11872         PR/24325
11873         * source-cache.c: #undef open and close, to avoid unresolved
11874         externals during linking.
11875
11876 2019-03-12  Tom Tromey  <tromey@adacore.com>
11877
11878         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11879         const.  Add initializers.
11880         (_initialize_remote): Don't initialize ptid globals.
11881
11882 2019-03-12  Pedro Alves  <palves@redhat.com>
11883
11884         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11885
11886 2019-03-12  Pedro Alves  <palves@redhat.com>
11887
11888         * cp-name-parser.y (main): Remove unused 'len' variable.
11889
11890 2019-03-12  Tom Tromey  <tromey@adacore.com>
11891
11892         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11893         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11894
11895 2019-03-12  Tom Tromey  <tromey@adacore.com>
11896
11897         * linux-nat.c (iterate_over_lwps): Update.
11898         (stop_callback): Remove parameter.
11899         (stop_wait_callback, detach_callback, resume_set_callback)
11900         (select_singlestep_lwp_callback, set_ignore_sigint)
11901         (status_callback, resumed_callback, resume_clear_callback)
11902         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11903         data parameter.
11904         (linux_nat_target::detach, linux_nat_target::resume)
11905         (linux_stop_and_wait_all_lwps, select_event_lwp)
11906         (linux_nat_filter_event, linux_nat_wait_1)
11907         (linux_nat_target::kill, linux_nat_target::stop)
11908         (linux_nat_target::stop): Update.
11909         (linux_nat_resume_callback): Change type.
11910         (resume_stopped_resumed_lwps, count_events_callback)
11911         (select_event_lwp_callback): Likewise.
11912         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11913         * arm-linux-nat.c (struct update_registers_data): Remove.
11914         (update_registers_callback): Change type.
11915         (arm_linux_insert_hw_breakpoint1): Update.
11916         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11917         parameter.
11918         (x86_linux_dr_set_addr): Update.
11919         (x86_linux_dr_set_control): Update.
11920         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11921         (iterate_over_lwps): Use gdb::function_view.
11922         * nat/aarch64-linux-hw-point.c (struct
11923         aarch64_dr_update_callback_param): Remove.
11924         (debug_reg_change_callback): Change type.
11925         (aarch64_notify_debug_reg_change): Update.
11926         * s390-linux-nat.c (s390_refresh_per_info): Update.
11927
11928 2019-03-11  Tom Tromey  <tromey@adacore.com>
11929
11930         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11931         redundant assignment to "this_cu".
11932
11933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11934
11935         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11936
11937 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11938
11939         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11940         from...
11941         (rank_one_type): ... this.
11942
11943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11944
11945         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11946         from...
11947         (rank_one_type): ... this.
11948
11949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11950
11951         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11952         from...
11953         (rank_one_type): ... this.
11954
11955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11956
11957         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11958         from...
11959         (rank_one_type): ... this.
11960
11961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11962
11963         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11964         from...
11965         (rank_one_type): ... this.
11966
11967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11968
11969         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11970         from...
11971         (rank_one_type): ... this.
11972
11973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11974
11975         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11976         from...
11977         (rank_one_type): ... this.
11978
11979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11980
11981         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11982         from...
11983         (rank_one_type): ... this.
11984
11985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11986
11987         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11988         from...
11989         (rank_one_type): ... this.
11990
11991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11992
11993         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11994         from...
11995         (rank_one_type): ... this.
11996
11997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11998
11999         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12000         from...
12001         (rank_one_type): ... this.
12002
12003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12004
12005         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12006         from...
12007         (rank_one_type): ... this.
12008
12009 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12010
12011         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12012         inferior-events' shows the example events.
12013
12014 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12015
12016         Support styling on native MS-Windows console
12017
12018         PR/24315
12019         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12020         on MS-Windows if $TERM is not defined.
12021
12022         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12023
12024         * posix-hdep.c (gdb_console_fputs):
12025         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12026         functions.
12027         * ui-file.h (gdb_console_fputs): Add prototype.
12028
12029         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12030         back to fputs only if the former returns zero.
12031
12032 2019-03-07  Tom Tromey  <tom@tromey.com>
12033
12034         * symmisc.c (print_symbol_bcache_statistics): Update.
12035         (print_objfile_statistics): Update.
12036         * symfile.c (allocate_symtab): Update.
12037         * stabsread.c: Don't include bcache.h.
12038         * psymtab.h (struct psymbol_bcache): Don't declare.
12039         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12040         (psymbol_bcache_init, psymbol_bcache_free)
12041         (psymbol_bcache_get_bcache): Don't declare.
12042         * psymtab.c (struct psymbol_bcache): Remove.
12043         (psymtab_storage::psymtab_storage): Update.
12044         (psymtab_storage::~psymtab_storage): Update.
12045         (psymbol_bcache_init, psymbol_bcache_free)
12046         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12047         (add_psymbol_to_bcache): Update.
12048         (allocate_psymtab): Update.
12049         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12050         macro_cache>: No longer pointers.
12051         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12052         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12053         * macrotab.c (macro_bcache): Update.
12054         * macroexp.c: Don't include bcache.h.
12055         * gdbtypes.c (check_types_worklist): Update.
12056         (types_deeply_equal): Remove TRY/CATCH.  Update.
12057         * elfread.c (elf_symtab_read): Update.
12058         * dwarf2read.c: Don't include bcache.h.
12059         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12060         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12061         (print_bcache_statistics, bcache_memory_used): Don't declare.
12062         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12063         methods.  Rename all data members.
12064         * bcache.c (struct bcache): Move to bcache.h.
12065         (bcache::expand_hash_table): Rename from expand_hash_table.
12066         (bcache): Remove.
12067         (bcache::insert): Rename from bcache_full.
12068         (bcache::compare): Rename from bcache_compare.
12069         (bcache_xmalloc): Remove.
12070         (bcache::~bcache): Rename from bcache_xfree.
12071         (bcache::print_statistics): Rename from print_bcache_statistics.
12072         (bcache::memory_used): Rename from bcache_memory_used.
12073
12074 2019-03-07  Pedro Alves  <palves@redhat.com>
12075
12076         * infrun.c (normal_stop): Also check for
12077         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12078
12079 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12080
12081         * f-lang.c (value_from_host_double): Moved to...
12082         * value.c (value_from_host_double): ...here.
12083         * value.h (value_from_host_double): Declare.
12084         * guile/scm-math.c (vlscm_convert_typed_number): Use
12085         value_from_host_double.
12086         (vlscm_convert_number): Likewise.
12087         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12088         * python/py-value.c (convert_value_from_python): Likewise.
12089
12090 2019-03-06  Tom Tromey  <tom@tromey.com>
12091
12092         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12093
12094 2019-03-06  Tom Tromey  <tom@tromey.com>
12095
12096         * utils.h (free_current_contents): Don't declare.
12097         * utils.c (free_current_contents): Remove.
12098
12099 2019-03-06  Tom Tromey  <tom@tromey.com>
12100
12101         * top.c (quit_force): Update.
12102         * main.c (captured_command_loop): Update.
12103         * common/new-op.c (operator new): Update.
12104         * common/common-exceptions.c (struct catcher)
12105         <save_cleanup_chain>: Remove member.
12106         (exceptions_state_mc_init): Update.
12107         (exception_try_scope_entry): Return nullptr.
12108         (exception_try_scope_exit, exception_rethrow)
12109         (throw_exception_sjlj, throw_exception_cxx): Update.
12110         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12111         (all_cleanups, do_cleanups, discard_cleanups)
12112         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12113         (restore_cleanups, restore_final_cleanups): Don't declare.
12114         (do_final_cleanups): Remove parameter.
12115         * common/cleanups.c (cleanup_chain, make_cleanup)
12116         (make_cleanup_dtor, all_cleanups, do_cleanups)
12117         (discard_my_cleanups, discard_cleanups)
12118         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12119         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12120         (null_cleanup): Remove.
12121         (do_final_cleanups): Remove parameter.
12122
12123 2019-03-06  Tom Tromey  <tom@tromey.com>
12124
12125         * remote.c (remote_target::remote_parse_stop_reply): Use
12126         unique_xmalloc_ptr.
12127
12128 2019-03-06  Tom Tromey  <tom@tromey.com>
12129
12130         * stabsread.c (struct stabs_field_info): Rename from field_info.
12131         <list, fnlist>: Add initializers.
12132         <obstack>: New member.
12133         (read_member_functions, read_struct_fields, read_baseclasses):
12134         Allocate on obstack.  Don't use cleanups.
12135         (read_one_struct_field, read_member_functions, read_struct_fields)
12136         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12137         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12138         (read_struct_type): Update.
12139
12140 2019-03-06  Tom Tromey  <tom@tromey.com>
12141
12142         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12143         * common/filestuff.h (make_cleanup_close): Don't declare.
12144         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12145         Remove.
12146
12147 2019-03-06  Tom Tromey  <tom@tromey.com>
12148
12149         * solib-aix.c: Use make_scope_exit.
12150
12151 2019-03-06  Tom Tromey  <tom@tromey.com>
12152
12153         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12154         Use make_scope_exit.
12155
12156 2019-03-06  Tom Tromey  <tom@tromey.com>
12157
12158         * solib-svr4.c (disable_probes_interface): Remove parameter.
12159         (svr4_handle_solib_event): Use make_scope_exit.
12160
12161 2019-03-06  Tom Tromey  <tom@tromey.com>
12162
12163         * remote.c (struct stop_reply_deleter): Remove.
12164         (stop_reply_up): Update.
12165         (struct stop_reply): Derive from notif_event.  Don't typedef.
12166         <regcache>: Now a std::vector.
12167         (stop_reply_xfree): Remove.
12168         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12169         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12170         (remote_target::discard_pending_stop_replies): Use delete.
12171         (remote_target::remote_parse_stop_reply): Update.
12172         (remote_target::process_stop_reply): Update.
12173         * remote-notif.h (struct notif_event): Add virtual destructor.
12174         Remove "dtr" member.
12175         (struct notif_client) <alloc_event>: Return a unique_ptr.
12176         (notif_event_xfree): Don't declare.
12177         (notif_event_up): New typedef.
12178         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12179         (notif_event_xfree, do_notif_event_xfree): Remove.
12180         (remote_notif_state_xfree): Update.
12181
12182 2019-03-06  Tom Tromey  <tom@tromey.com>
12183
12184         * infrun.c (displaced_step_clear_cleanup): Now a
12185         forward_scope_exit type.
12186         (displaced_step_prepare_throw): Update.
12187         (displaced_step_fixup): Update.
12188
12189 2019-03-06  Tom Tromey  <tom@tromey.com>
12190
12191         * inferior.h (class inferior): Update comment.
12192         * gdbthread.h (class thread_info): Update comment.
12193
12194 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12195             Tom Tromey  <tom@tromey.com>
12196
12197         * stabsread.h (struct stab_section_list): Remove.
12198         (coffstab_build_psymtabs): Update.
12199         * dbxread.c (symbuf_sections): Now a std::vector.
12200         (sect_idx): New global.
12201         (fill_symbuf): Update.
12202         (coffstab_build_psymtabs): Change type of stabsects parameter.
12203         Update.
12204         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12205         std::vector.
12206         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12207         (coff_locate_sections): Update.
12208         (coff_symfile_read): Remove cleanups.  Update.
12209         (init_stringtab): Add storage parameter.
12210         (free_stringtab, free_stringtab_cleanup): Remove.
12211         (init_lineno): Add storage parameter.
12212         (free_linetab, free_linetab_cleanup): Remove.
12213
12214 2019-03-06  Pedro Alves  <palves@redhat.com>
12215
12216         * linux-fork.c (fork_info::clobber_regs): Delete.
12217         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12218         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12219         comment.  Adjust.
12220         (scoped_switch_fork_info::scoped_switch_fork_info)
12221         (checkpoint_command, linux_fork_context): Adjust
12222         fork_save_infrun_state calls.
12223
12224 2019-03-06  Pedro Alves  <palves@redhat.com>
12225
12226         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12227         (inf_has_multiple_threads): Return 'bool' and rewrite using
12228         inferior_info::threads().
12229
12230 2019-03-06  Pedro Alves  <palves@redhat.com>
12231
12232         * linux-fork.c: Include <list>.
12233         (fork_list): Now a std::list instance.
12234         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12235         (forks_exist_p, find_last_fork): Adjust.
12236         (new_fork): Delete.
12237         (one_fork_p): New.
12238         (add_fork): Adjust.
12239         (free_fork): Delete, folded into fork_info::~fork_info().
12240         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12241         Adjust.
12242         (init_fork_list): Delete.
12243         (linux_fork_killall, linux_fork_mourn_inferior)
12244         (linux_fork_detach, info_checkpoints_command): Adjust.
12245         (_initialize_linux_fork): No longer call init_fork_list.
12246
12247 2019-03-06  Pedro Alves  <palves@redhat.com>
12248
12249         * linux-fork.c (new_fork): New, split out of ...
12250         (add_fork): ... this.  Return void.  Move "first fork" special
12251         case from here, to ...
12252         (checkpoint_command): ... here.
12253         * linux-linux.h (add_fork): Return void.
12254
12255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12256
12257         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12258
12259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12260             Chris January  <chris.january@arm.com>
12261             David Lecomber  <david.lecomber@arm.com>
12262
12263         * f-exp.y: New token, UNOP_INTRINSIC.
12264         (exp): New pattern using UNOP_INTRINSIC token.
12265         (f77_keywords): Add 'abs' keyword.
12266         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12267         (value_from_host_double): New function.
12268         (evaluate_subexp_f): Support UNOP_ABS.
12269
12270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12273         types.
12274
12275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12276
12277         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12278         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12279         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12280
12281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12282
12283         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12284
12285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12286             Chris January  <chris.january@arm.com>
12287
12288         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12289         * f-exp.y: Define 'KIND' token.
12290         (exp): New pattern for KIND expressions.
12291         (ptype): Handle types with a kind extension.
12292         (direct_abs_decl): Extend to spot kind extensions.
12293         (f77_keywords): Add 'kind' to the list.
12294         (push_kind_type): New function.
12295         (convert_to_kind_type): New function.
12296         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12297         * parse.c (operator_length_standard): Likewise.
12298         * parser-defs.h (enum type_pieces): Add tp_kind.
12299         * std-operator.def: Add UNOP_KIND.
12300
12301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12302
12303         * f-exp.y (f_parse): Set yydebug.
12304
12305 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12306
12307         * f-lang.c (evaluate_subexp_f): New function.
12308         (exp_descriptor_f): New global.
12309         (f_language_defn): Use exp_descriptor_f instead of
12310         exp_descriptor_standard.
12311
12312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12313
12314         * f-exp.y (struct token): Add comments.
12315         (dot_ops): Remove uppercase versions and the end marker.
12316         (f77_keywords): Likewise.
12317         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12318         entries in the dot_ops array are case insensitive, and use
12319         strncasecmp to compare strings.  Also some whitespace cleanup in
12320         this area.  Similar for the f77_keywords array, except entries in
12321         this list might be case sensitive.
12322
12323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12324
12325         * f-exp.y (struct f77_boolean_val): Add comments.
12326         (boolean_values): Remove uppercase versions, and end marker.
12327         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12328         and use strncasecmp to achieve case insensitivity.  Additionally,
12329         perform whitespace cleanup around this code.
12330
12331 2019-03-06  Tom Tromey  <tromey@adacore.com>
12332
12333         * remote-sim.c (gdbsim_target_open): Use result of
12334         gdb_argv::release.
12335
12336 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12337         Dirk Schubert  <dirk.schubert@arm.com>
12338         Chris January  <chris.january@arm.com>
12339
12340         * eval.c (evaluate_subexp_standard): Call Fortran argument
12341         wrapping logic.
12342         * f-lang.c (struct value): A value which can be passed into a
12343         Fortran function call.
12344         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12345         where appropriate.
12346         (struct type): Value ready for a Fortran function call.
12347         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12348         is needed.
12349         * f-lang.h (fortran_argument_convert): Declaration.
12350         (fortran_preserve_arg_pointer): Declaration.
12351         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12352
12353 2019-03-05  Tom Tromey  <tromey@adacore.com>
12354
12355         * python/py-prettyprint.c (print_string_repr): Remove #if.
12356         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12357
12358 2019-03-05  Tom Tromey  <tromey@adacore.com>
12359
12360         * target.c (the_dummy_target): Move later.  Change type to
12361         "dummy_target".
12362         (initialize_targets): Don't initialize the_dummy_target.
12363
12364 2019-03-05  Tom Tromey  <tromey@adacore.com>
12365
12366         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12367         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12368
12369 2019-03-05  Tom Tromey  <tromey@adacore.com>
12370
12371         * windows-nat.c (windows_nat_target::attach)
12372         (windows_nat_target::detach): Don't call gdb_flush.
12373         * valprint.c (generic_val_print, val_print, val_print_string):
12374         Don't call gdb_flush.
12375         * utils.c (defaulted_query): Don't call gdb_flush.
12376         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12377         * target.c (target_announce_detach): Don't call gdb_flush.
12378         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12379         * remote.c (extended_remote_target::attach): Don't call
12380         gdb_flush.
12381         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12382         * printcmd.c (do_examine): Don't call gdb_flush.
12383         (info_display_command): Don't call gdb_flush.
12384         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12385         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12386         * memattr.c (info_mem_command): Don't call gdb_flush.
12387         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12388         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12389         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12390         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12391         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12392         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12393         (gnu_nat_target::detach): Don't call gdb_flush.
12394         * f-valprint.c (f_val_print): Don't call gdb_flush.
12395         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12396         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12397         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12398         gdb_flush.
12399         * c-valprint.c (c_val_print): Don't call gdb_flush.
12400         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12401
12402 2019-03-05  Tom Tromey  <tromey@adacore.com>
12403
12404         * varobj.c (update_dynamic_varobj_children): Update.
12405         (install_default_visualizer): Use reset, not release.
12406         * value.c (set_internalvar): Update.
12407         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12408         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12409         ATTRIBUTE_UNUSED_RESULT.
12410
12411 2019-03-05  Tom Tromey  <tromey@adacore.com>
12412
12413         * remote.c (class scoped_remote_fd) <release>: Add
12414         ATTRIBUTE_UNUSED_RESULT.
12415
12416 2019-03-05  Tom Tromey  <tromey@adacore.com>
12417
12418         * macroexp.c (struct macro_buffer) <release>: Add
12419         ATTRIBUTE_UNUSED_RESULT.
12420
12421 2019-03-05  Tom Tromey  <tromey@adacore.com>
12422
12423         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12424         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12425         ATTRIBUTE_UNUSED_RESULT.
12426
12427 2019-03-05  Tom Tromey  <tromey@adacore.com>
12428
12429         * common/scoped_fd.h (class scoped_fd) <release>: Add
12430         ATTRIBUTE_UNUSED_RESULT.
12431
12432 2019-03-05  Tom Tromey  <tromey@adacore.com>
12433
12434         * parser-defs.h (struct parser_state) <release>: Add
12435         ATTRIBUTE_UNUSED_RESULT.
12436
12437 2019-03-05  Tom Tromey  <tromey@adacore.com>
12438
12439         * utils.h (class gdb_argv) <release>: Add
12440         ATTRIBUTE_UNUSED_RESULT.
12441         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12442
12443 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12444
12445         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12446         for-loop range, to avoid compiler warnings.
12447
12448         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12449         avoid compiler warnings about unused variables.
12450
12451         * NEWS: Mention end of support for native debugging on MS-Windows
12452         before XP.
12453
12454         PR gdb/24292
12455         * common/netstuff.c:
12456         * gdbserver/gdbreplay.c
12457         * gdbserver/remote-utils.c:
12458         * ser-tcp.c:
12459         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12460         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12461         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12462         'getaddrinfo' and 'freeaddrinfo' were not available before
12463         Windows XP, and mingw.org's MinGW headers by default define
12464         _WIN32_WINNT to 0x500.
12465
12466 2019-03-01  Gary Benson <gbenson@redhat.com>
12467
12468         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12469
12470 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12471             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12472
12473         PR gdb/8527
12474         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12475         set_sigint_trap, clear_sigint_trap.
12476
12477 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12478
12479         * target.c (target_detach): Clear the regcache and the
12480         frame cache.
12481
12482 2019-02-27  Pedro Alves  <palves@redhat.com>
12483
12484         * utils.c (set_screen_size): When we cap the height/width sizes,
12485         tweak the corresponding command variable to show "unlimited":
12486
12487 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12488             Pedro Alves  <palves@redhat.com>
12489
12490         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12491         before calling rl_set_screen_size.
12492
12493 2019-02-27  Tom Tromey  <tromey@adacore.com>
12494
12495         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12496         define.
12497         * python/py-value.c: Remove Python 2.4 workaround.
12498         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12499         workaround.
12500         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12501         Python 2.4 workaround.
12502         * python/python-internal.h: Remove Python 2.4 comment.
12503         (Py_ssize_t): Don't define.
12504         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12505         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12506         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12507         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12508         * python/python.c (do_start_initialization): Remove Python 2.4
12509         workaround.
12510         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12511         (print_children): Remove Python 2.4 workaround.
12512         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12513         workaround.
12514         (CHARBUFFERPROC_NAME): Remove.
12515         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12516         Python 2.4 workaround.
12517
12518 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12519
12520         * NEWS: Note minimum Python version.
12521
12522 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12523
12524         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12525         code from these functions.  Remove corresponding ifdefs.  Use
12526         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12527         Remove gotos and target of gotos.
12528         (infpy_search_memory): Likewise.
12529
12530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12531
12532         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12533         (hppa_gdbarch_init): Don't register deleted functions with
12534         gdbarch.
12535
12536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12537
12538         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12539         (h8300_unwind_sp): Delete.
12540         (h8300_dummy_id): Delete.
12541         (h8300_gdbarch_init): Don't register deleted functions with
12542         gdbarch.
12543
12544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12545
12546         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12547         (ft32_unwind_pc): Delete.
12548         (ft32_unwind_sp): Delete.
12549         (ft32_gdbarch_init): Don't register deleted functions with
12550         gdbarch.
12551
12552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12553
12554         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12555         (frv_unwind_pc): Delete.
12556         (frv_unwind_sp): Delete.
12557         (frv_gdbarch_init): Don't register deleted functions with
12558         gdbarch.
12559
12560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12561
12562         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12563         (riscv_unwind_pc): Delete.
12564         (riscv_unwind_sp): Delete.
12565         (riscv_gdbarch_init): Don't register deleted functions with
12566         gdbarch.
12567
12568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12569
12570         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12571         (csky_unwind_pc): Delete.
12572         (csky_unwind_sp): Delete.
12573         (csky_gdbarch_init): Don't register deleted functions with
12574         gdbarch.
12575
12576 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12577
12578         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12579         (cris_unwind_pc): Delete.
12580         (cris_unwind_sp): Delete.
12581         (cris_gdbarch_init): Don't register deleted functions with
12582         gdbarch.
12583
12584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12585
12586         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12587         (bfin_unwind_pc): Delete.
12588         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12589
12590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12591
12592         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12593         (arm_unwind_pc): Delete.
12594         (arm_unwind_sp): Delete.
12595         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12596
12597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12598
12599         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12600         (arc_unwind_pc): Delete.
12601         (arc_unwind_sp): Delete.
12602         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12603
12604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12605
12606         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12607         (alpha_unwind_pc): Delete.
12608         (alpha_gdbarch_init): Don't register deleted functions with
12609         gdbarch.
12610
12611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12612
12613         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12614         (aarch64_unwind_pc): Delete.
12615         (aarch64_unwind_sp): Delete.
12616         (aarch64_gdbarch_init): Don't register deleted functions with
12617         gdbarch.
12618
12619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12620
12621         * gdbtypes.c (type_align): Don't consider static members when
12622         computing structure alignment.
12623
12624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12625
12626         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12627         return 0 for other types.
12628         * arch-utils.c (default_type_align): Always return 0.
12629         * gdbarch.h: Regenerate.
12630         * gdbarch.sh (type_align): Extend comment.
12631         * gdbtypes.c (type_align): Add additional comments, always call
12632         gdbarch_type_align before applying the default rules.
12633         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12634         generic code will then apply a suitable default.
12635         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12636         types, return 0 for other types.
12637
12638 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12639
12640         * NEWS: Create a new section for the next release branch.
12641         Rename the section of the current branch, now that it has
12642         been cut.
12643
12644 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12645
12646         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12647         * version.in: Bump version to 8.3.50.DATE-git.
12648
12649 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12650
12651         * aix-thread.c (ptid_cmp): Remove unused variable.
12652         (get_signaled_thread): Likewise.
12653         (store_regs_user_thread): Likewise.
12654         (store_regs_kernel_thread): Likewise.
12655         (fetch_regs_kernel_thread): Remove shadowed variable.
12656
12657 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12658
12659         * features/riscv/32bit-cpu.xml: Add register numbers.
12660         * features/riscv/32bit-fpu.c: Regenerate.
12661         * features/riscv/32bit-fpu.xml: Add register numbers.
12662         * features/riscv/64bit-cpu.xml: Add register numbers.
12663         * features/riscv/64bit-fpu.c: Regenerate.
12664         * features/riscv/64bit-fpu.xml: Add register numbers.
12665
12666 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12667
12668         * NEWS: Mention two argument form of gdb.Value constructor.
12669         * python/py-value.c (convert_buffer_and_type_to_value): New
12670         function.
12671         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12672         Add support for handling an optional second argument.  Call
12673         convert_buffer_and_type_to_value as appropriate.
12674         * python/python-internal.h (Py_buffer_deleter): New struct.
12675         (Py_buffer_up): New typedef.
12676
12677 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12678
12679         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12680         instead of releasing ownership.
12681
12682 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12683
12684         * dwarf2read.c (open_and_init_dwp_file): Call
12685         elf_numsections instead of bfd_count_sections to initialize
12686         dwp_file->num_sections.
12687
12688 2019-02-25  Tom Tromey  <tromey@adacore.com>
12689
12690         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12691
12692 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12693
12694         * gcore.in: Add '--readnever' option when invoking GDB.
12695
12696 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12697
12698         * MAINTAINERS: Update my email address.
12699
12700 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12701
12702         * build-id.c (build_id_to_debug_bfd_1): New function.
12703         (build_id_to_debug_bfd): Look for separate debug file in
12704         sysroot.
12705
12706 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12707
12708         * gdbarch.sh: Update the copyright year range that is placed into
12709         generated files.
12710
12711 2019-02-22  Keith Seitz  <keiths@redhat.com>
12712
12713         PR symtab/23853
12714         * linespec.c (create_sals_line_offset): Search for the default
12715         symtab's filename instead of its fullname.
12716
12717 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12718
12719         * NEWS: Update style defaults.
12720
12721 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12722
12723         * main.c (captured_main_1): Disable styling in batch mode.
12724
12725 2019-02-20  Tom Tromey  <tom@tromey.com>
12726
12727         * symtab.c (symtab_symbol_info): Fix typos.
12728
12729 2019-02-20  Tom Tromey  <tromey@adacore.com>
12730
12731         * findcmd.c (_initialize_mem_search): Use upper case for
12732         metasyntactic variables.
12733
12734 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12735
12736         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12737         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12738
12739 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12740
12741         * top.h (source_file_name): Change to std::string.
12742         * top.c (source_file_name): Likewise.
12743         (command_line_input): Adjust.
12744         * cli/cli-script.c (script_from_file): Adjust.
12745
12746 2019-02-19  Tom Tromey  <tromey@adacore.com>
12747
12748         * ravenscar-thread.c
12749         (ravenscar_thread_target::update_thread_list): Don't call
12750         ada_build_task_list.
12751         * ada-lang.h (ada_build_task_list): Don't declare.
12752         * ada-tasks.c (struct ada_tasks_inferior_data)
12753         <task_list_valid_p>: Now bool.
12754         (read_known_tasks, ada_task_list_changed)
12755         (ada_tasks_invalidate_inferior_data): Update.
12756         (read_known_tasks_array): Return bool.
12757         (read_known_tasks_list): Likewise.
12758         (read_known_tasks): Return void.
12759         (ada_build_task_list): Now static.
12760
12761 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12762
12763         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12764         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12765
12766 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12767
12768         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12769         variant for ada_tasks_pspace_data_handle and
12770         ada_tasks_inferior_data_handle.
12771         (ada_tasks_pspace_data_cleanup): New function.
12772         (ada_tasks_inferior_data_cleanup): New function.
12773
12774 2019-02-17  Tom Tromey  <tom@tromey.com>
12775
12776         * macrotab.h (macro_source_fullname): Return a std::string.
12777         * macrotab.c (macro_include, check_for_redefinition)
12778         (macro_undef, macro_lookup_definition, foreach_macro)
12779         (foreach_macro_in_scope): Update.
12780         (macro_source_fullname): Return a std::string.
12781         * macrocmd.c (show_pp_source_pos): Update.
12782
12783 2019-02-17  Tom Tromey  <tom@tromey.com>
12784
12785         * macrocmd.c (show_pp_source_pos): Style the file names.
12786
12787 2019-02-17  Tom Tromey  <tom@tromey.com>
12788
12789         PR tui/24197:
12790         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12791
12792 2019-02-17  Tom Tromey  <tom@tromey.com>
12793
12794         * ada-lang.c (user_select_syms): Use filtered printing.
12795         * utils.c (wrap_style): New global.
12796         (desired_style): Remove.
12797         (emit_style_escape): Add stream parameter.
12798         (set_output_style, reset_terminal_style, prompt_for_continue):
12799         Update.
12800         (flush_wrap_buffer): Only flush gdb_stdout.
12801         (wrap_here): Set wrap_style.
12802         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12803         treat escape sequences as a character.  Change when wrap buffer is
12804         flushed.
12805         (fputs_styled): Do not set the output style when the default is
12806         requested.
12807         * ui-style.h (struct ui_file_style) <is_default>: New method.
12808         * source.c (print_source_lines_base): Emit escape sequences in one
12809         piece.
12810
12811 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12812
12813         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12814         integers and enumeration types.
12815
12816 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12817
12818         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12819         instead of lookup_symbol_in_language
12820         (do_exact_match): New function.
12821         (ada_get_symbol_name_matcher): Return do_exact_match when
12822         doing a verbatim match.
12823
12824 2019-02-15  Tom Tromey  <tromey@adacore.com>
12825
12826         * ravenscar-thread.c (ravenscar_thread_target::resume)
12827         (ravenscar_thread_target::wait): Special case wildcard requests.
12828
12829 2019-02-15  Tom Tromey  <tromey@adacore.com>
12830
12831         * ravenscar-thread.c (base_ptid): Remove.
12832         (struct ravenscar_thread_target) <close>: New method.
12833         <m_base_ptid>: New member.
12834         <update_inferior_ptid, active_task, task_is_currently_active,
12835         runtime_initialized>: Declare methods.
12836         <ravenscar_thread_target>: Add constructor.
12837         (ravenscar_thread_target::task_is_currently_active)
12838         (ravenscar_thread_target::update_inferior_ptid)
12839         (ravenscar_runtime_initialized): Rename.  Now methods.
12840         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12841         (ravenscar_thread_target::update_thread_list): Update.
12842         (ravenscar_thread_target::active_task): Now method.
12843         (ravenscar_thread_target::store_registers)
12844         (ravenscar_thread_target::prepare_to_store)
12845         (ravenscar_thread_target::prepare_to_store)
12846         (ravenscar_thread_target::mourn_inferior): Update.
12847         (ravenscar_inferior_created): Use "new" to create target.
12848         (ravenscar_thread_target::get_ada_task_ptid): Update.
12849         (_initialize_ravenscar): Don't initialize base_ptid.
12850         (ravenscar_ops): Remove global.
12851
12852 2019-02-15  Tom Tromey  <tromey@adacore.com>
12853
12854         * target.h (push_target): Declare new overload.
12855         * target.c (push_target): New overload, taking an rvalue reference.
12856         * remote.c (remote_target::open_1): Use push_target overload.
12857         * corelow.c (core_target_open): Use push_target overload.
12858
12859 2019-02-15  Tom Tromey  <tromey@adacore.com>
12860
12861         * ravenscar-thread.c (is_ravenscar_task)
12862         (ravenscar_task_is_currently_active): Return bool.
12863         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12864         (_initialize_ravenscar): Remove "(void)".
12865         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12866         Return bool.
12867
12868 2019-02-15  Tom Tromey  <tromey@adacore.com>
12869
12870         * ravenscar-thread.c (ravenscar_runtime_initializer)
12871         (has_ravenscar_runtime, get_running_thread_id)
12872         (ravenscar_thread_target::resume): Fix indentation.
12873
12874 2019-02-15  Tom Tromey  <tromey@adacore.com>
12875
12876         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12877         from ravenscar_arch_ops.
12878         (sparc_ravenscar_ops::fetch_registers)
12879         (sparc_ravenscar_ops::store_registers): Now methods.
12880         (sparc_ravenscar_prepare_to_store): Remove.
12881         (sparc_ravenscar_ops): Redefine.
12882         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12883         methods and destructor.  Remove members.
12884         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12885         (ravenscar_thread_target::store_registers)
12886         (ravenscar_thread_target::prepare_to_store): Update.
12887         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12888         Remove.
12889         (struct ppc_ravenscar_powerpc_ops): Derive from
12890         ravenscar_arch_ops.
12891         (ppc_ravenscar_powerpc_ops::fetch_registers)
12892         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12893         (ppc_ravenscar_powerpc_ops): Redefine.
12894         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12895         (ppc_ravenscar_e500_ops::fetch_registers)
12896         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12897         (ppc_ravenscar_e500_ops): Redefine.
12898         * aarch64-ravenscar-thread.c
12899         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12900         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12901         (aarch64_ravenscar_fetch_registers)
12902         (aarch64_ravenscar_store_registers): Now methods.
12903         (aarch64_ravenscar_ops): Redefine.
12904
12905 2019-02-15  Tom Tromey  <tromey@adacore.com>
12906
12907         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12908         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12909         (ravenscar_thread_target::stopped_by_watchpoint)
12910         (ravenscar_thread_target::stopped_data_address)
12911         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12912
12913 2019-02-15  Tom Tromey  <tromey@adacore.com>
12914
12915         * ravenscar-thread.c: Fix some typos.
12916
12917 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12918             Tom Tromey  <tromey@adacore.com>
12919
12920         * ada-lang.c (ada_exception_sal): Change addr_string to a
12921         std::string.
12922         (create_ada_exception_catchpoint): Update.
12923
12924 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12925             Tom Tromey  <tromey@adacore.com>
12926
12927         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12928         (bp_location_ops): Remove.
12929         (base_breakpoint_allocate_location): Update.
12930         (free_bp_location): Update.
12931         * ada-lang.c (class ada_catchpoint_location)
12932         <ada_catchpoint_location>: Remove ops parameter.
12933         (ada_catchpoint_location_dtor): Remove.
12934         (ada_catchpoint_location_ops): Remove.
12935         (allocate_location_exception): Update.
12936         * breakpoint.h (struct bp_location_ops): Remove.
12937         (class bp_location) <bp_location>: Remove bp_location_ops
12938         parameter.
12939         <~bp_location>: Add destructor.
12940         <ops>: Remove.
12941
12942 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12943             Pedro Alves  <palves@redhat.com>
12944
12945         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12946         'PATH_MAX'.
12947
12948 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12949             Samuel Thibault  <samuel.thibault@gnu.org>
12950             Thomas Schwinge  <thomas@codesourcery.com>
12951
12952         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12953         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12954
12955 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12956
12957         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12958         (check_empty): Use "const char *".
12959
12960         * gnu-nat.c (gnu_nat_target::detach): Instead of
12961         'detach_inferior (pid)' call
12962         'detach_inferior (find_inferior_pid (pid))'.
12963
12964         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12965         'nat/fork-inferior.o'.
12966         * gnu-nat.c: #include "nat/fork-inferior.h".
12967
12968         * gnu-nat.c (gnu_nat_target::detach): Instead of
12969         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12970         * gnu-nat.h: #include "inf-child.h".
12971         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12972         'i386_gnu_nat_target::fetch_registers'.
12973         (gnu_store_registers): Rename/move to
12974         'i386_gnu_nat_target::store_registers'.
12975
12976         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12977         * gnu-nat.h (mach_thread_info): New function.
12978         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12979
12980         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12981
12982 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12983
12984         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12985
12986 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12987
12988         * windows-nat.c (windows_add_thread): Add new parameter
12989         "main_thread_p" with default value set to false.  Update
12990         function documentation as well as all callers.
12991         (windows_delete_thread): Likewise.
12992         (fake_create_process): Update call to windows_add_thread.
12993         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12994         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12995         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12996         call to windows_delete_thread.
12997
12998 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12999
13000         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13001
13002 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13003
13004         * symfile.c (find_separate_debug_file): Use canonical path of
13005         sysroot with child_path instead of gdb_sysroot if it is valid.
13006
13007 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13008
13009         * symfile.c (find_separate_debug_file): Use child_path to
13010         determine if an object file is under a sysroot.
13011
13012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13013
13014         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13015         unittests/child-path-selftests.c.
13016         * common/pathstuff.c (child_path): New function.
13017         * common/pathstuff.h (child_path): New prototype.
13018         * unittests/child-path-selftests.c: New file.
13019
13020 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13021
13022         * symfile.c (find_separate_debug_file): Look for separate debug
13023         files in debug directories under the sysroot.
13024
13025 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13026
13027         * symtab.h (struct minimal_symbol data_p): New const method.
13028         (struct minimal_symbol text_p): Likewise.
13029         * symtab.c (output_source_filename): Use file name style
13030         to print file name.
13031         (print_symbol_info): Likewise.
13032         (print_msymbol_info): Use address style to print addresses.
13033         Use function name style to print executable text symbols.
13034         (expand_symtab_containing_pc): Use data_p.
13035         (find_pc_sect_compunit_symtab): Likewise.
13036
13037 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13038
13039         * breakpoint.c (describe_other_breakpoints): Use address style
13040         to print addresses.
13041         (say_where): Likewise.
13042
13043 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13044
13045         * ada-typeprint.c (print_func_type): Print function name
13046         style to print function name.
13047         * c-typeprint.c (c_print_type_1): Likewise.
13048
13049 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13050
13051         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13052         for execve.
13053
13054 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13055
13056         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13057         type_stack.
13058
13059 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13060
13061         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13062         TYPE_CODE_REF types.
13063
13064 2019-02-08  Jim Wilson  <jimw@sifive.com>
13065
13066         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13067         (riscv_linux_fregset): New.
13068         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13069
13070 2019-02-07  Tom Tromey  <tom@tromey.com>
13071
13072         * thread.c (thread_cancel_execution_command): Update.
13073         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13074         methods.
13075         (struct thread_fsm_ops): Remove.
13076         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13077         (thread_fsm_should_stop, thread_fsm_return_value)
13078         (thread_fsm_set_finished, thread_fsm_finished_p)
13079         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13080         Don't declare.
13081         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13082         * infrun.c (clear_proceed_status_thread)
13083         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13084         (print_stop_event): Update.
13085         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13086         Add constructor.
13087         (step_command_fsm_ops): Remove.
13088         (new_step_command_fsm): Remove.
13089         (step_1): Update.
13090         (step_command_fsm::should_stop): Rename from
13091         step_command_fsm_should_stop.
13092         (step_command_fsm::clean_up): Rename from
13093         step_command_fsm_clean_up.
13094         (step_command_fsm::do_async_reply_reason): Rename from
13095         step_command_fsm_async_reply_reason.
13096         (struct until_next_fsm): Inherit from thread_fsm.  Add
13097         constructor.
13098         (until_next_fsm_ops): Remove.
13099         (new_until_next_fsm): Remove.
13100         (until_next_fsm::should_stop): Rename from
13101         until_next_fsm_should_stop.
13102         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13103         (until_next_fsm::do_async_reply_reason): Rename from
13104         until_next_fsm_async_reply_reason.
13105         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13106         constructor.  Change type of breakpoint.
13107         (finish_command_fsm_ops): Remove.
13108         (new_finish_command_fsm): Remove.
13109         (finish_command_fsm::should_stop): Rename from
13110         finish_command_fsm_should_stop.
13111         (finish_command_fsm::clean_up): Rename from
13112         finish_command_fsm_clean_up.
13113         (finish_command_fsm::return_value): Rename from
13114         finish_command_fsm_return_value.
13115         (finish_command_fsm::do_async_reply_reason): Rename from
13116         finish_command_fsm_async_reply_reason.
13117         (finish_command): Update.
13118         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13119         Add constructor.
13120         (call_thread_fsm_ops): Remove.
13121         (call_thread_fsm::call_thread_fsm): Rename from
13122         new_call_thread_fsm.
13123         (call_thread_fsm::should_stop): Rename from
13124         call_thread_fsm_should_stop.
13125         (call_thread_fsm::should_notify_stop): Rename from
13126         call_thread_fsm_should_notify_stop.
13127         (run_inferior_call, call_function_by_hand_dummy): Update.
13128         * cli/cli-interp.c (should_print_stop_to_console): Update.
13129         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13130         Add constructor.  Change type of location_breakpoint,
13131         caller_breakpoint.
13132         (until_break_fsm_ops): Remove.
13133         (new_until_break_fsm): Remove.
13134         (until_break_fsm::should_stop): Rename from
13135         until_break_fsm_should_stop.
13136         (until_break_fsm::clean_up): Rename from
13137         until_break_fsm_clean_up.
13138         (until_break_fsm::do_async_reply_reason): Rename from
13139         until_break_fsm_async_reply_reason.
13140         (until_break_command): Update.
13141         * thread-fsm.c: Remove.
13142         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13143
13144 2019-02-07  Tom Tromey  <tom@tromey.com>
13145
13146         * yy-remap.h: Add include guard.
13147         * xtensa-tdep.h: Add include guard.
13148         * xcoffread.h: Rename include guard.
13149         * varobj-iter.h: Add include guard.
13150         * tui/tui.h: Rename include guard.
13151         * tui/tui-winsource.h: Rename include guard.
13152         * tui/tui-wingeneral.h: Rename include guard.
13153         * tui/tui-windata.h: Rename include guard.
13154         * tui/tui-win.h: Rename include guard.
13155         * tui/tui-stack.h: Rename include guard.
13156         * tui/tui-source.h: Rename include guard.
13157         * tui/tui-regs.h: Rename include guard.
13158         * tui/tui-out.h: Rename include guard.
13159         * tui/tui-layout.h: Rename include guard.
13160         * tui/tui-io.h: Rename include guard.
13161         * tui/tui-hooks.h: Rename include guard.
13162         * tui/tui-file.h: Rename include guard.
13163         * tui/tui-disasm.h: Rename include guard.
13164         * tui/tui-data.h: Rename include guard.
13165         * tui/tui-command.h: Rename include guard.
13166         * tic6x-tdep.h: Add include guard.
13167         * target/waitstatus.h: Rename include guard.
13168         * target/wait.h: Rename include guard.
13169         * target/target.h: Rename include guard.
13170         * target/resume.h: Rename include guard.
13171         * target-float.h: Rename include guard.
13172         * stabsread.h: Add include guard.
13173         * rs6000-tdep.h: Add include guard.
13174         * riscv-fbsd-tdep.h: Add include guard.
13175         * regformats/regdef.h: Rename include guard.
13176         * record.h: Rename include guard.
13177         * python/python.h: Rename include guard.
13178         * python/python-internal.h: Rename include guard.
13179         * python/py-stopevent.h: Rename include guard.
13180         * python/py-ref.h: Rename include guard.
13181         * python/py-record.h: Rename include guard.
13182         * python/py-record-full.h: Rename include guard.
13183         * python/py-record-btrace.h: Rename include guard.
13184         * python/py-instruction.h: Rename include guard.
13185         * python/py-events.h: Rename include guard.
13186         * python/py-event.h: Rename include guard.
13187         * procfs.h: Add include guard.
13188         * proc-utils.h: Add include guard.
13189         * p-lang.h: Add include guard.
13190         * or1k-tdep.h: Rename include guard.
13191         * observable.h: Rename include guard.
13192         * nto-tdep.h: Rename include guard.
13193         * nat/x86-linux.h: Rename include guard.
13194         * nat/x86-linux-dregs.h: Rename include guard.
13195         * nat/x86-gcc-cpuid.h: Add include guard.
13196         * nat/x86-dregs.h: Rename include guard.
13197         * nat/x86-cpuid.h: Rename include guard.
13198         * nat/ppc-linux.h: Rename include guard.
13199         * nat/mips-linux-watch.h: Rename include guard.
13200         * nat/linux-waitpid.h: Rename include guard.
13201         * nat/linux-ptrace.h: Rename include guard.
13202         * nat/linux-procfs.h: Rename include guard.
13203         * nat/linux-osdata.h: Rename include guard.
13204         * nat/linux-nat.h: Rename include guard.
13205         * nat/linux-namespaces.h: Rename include guard.
13206         * nat/linux-btrace.h: Rename include guard.
13207         * nat/glibc_thread_db.h: Rename include guard.
13208         * nat/gdb_thread_db.h: Rename include guard.
13209         * nat/gdb_ptrace.h: Rename include guard.
13210         * nat/fork-inferior.h: Rename include guard.
13211         * nat/amd64-linux-siginfo.h: Rename include guard.
13212         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13213         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13214         * nat/aarch64-linux.h: Rename include guard.
13215         * nat/aarch64-linux-hw-point.h: Rename include guard.
13216         * mn10300-tdep.h: Add include guard.
13217         * mips-linux-tdep.h: Add include guard.
13218         * mi/mi-parse.h: Rename include guard.
13219         * mi/mi-out.h: Rename include guard.
13220         * mi/mi-main.h: Rename include guard.
13221         * mi/mi-interp.h: Rename include guard.
13222         * mi/mi-getopt.h: Rename include guard.
13223         * mi/mi-console.h: Rename include guard.
13224         * mi/mi-common.h: Rename include guard.
13225         * mi/mi-cmds.h: Rename include guard.
13226         * mi/mi-cmd-break.h: Rename include guard.
13227         * m2-lang.h: Add include guard.
13228         * location.h: Rename include guard.
13229         * linux-record.h: Rename include guard.
13230         * linux-nat.h: Add include guard.
13231         * linux-fork.h: Add include guard.
13232         * i386-darwin-tdep.h: Rename include guard.
13233         * hppa-linux-offsets.h: Add include guard.
13234         * guile/guile.h: Rename include guard.
13235         * guile/guile-internal.h: Rename include guard.
13236         * gnu-nat.h: Rename include guard.
13237         * gdb-stabs.h: Rename include guard.
13238         * frv-tdep.h: Add include guard.
13239         * f-lang.h: Add include guard.
13240         * event-loop.h: Add include guard.
13241         * darwin-nat.h: Rename include guard.
13242         * cp-abi.h: Rename include guard.
13243         * config/sparc/nm-sol2.h: Rename include guard.
13244         * config/nm-nto.h: Rename include guard.
13245         * config/nm-linux.h: Add include guard.
13246         * config/i386/nm-i386gnu.h: Rename include guard.
13247         * config/djgpp/nl_types.h: Rename include guard.
13248         * config/djgpp/langinfo.h: Rename include guard.
13249         * compile/gcc-cp-plugin.h: Add include guard.
13250         * compile/gcc-c-plugin.h: Add include guard.
13251         * compile/compile.h: Rename include guard.
13252         * compile/compile-object-run.h: Rename include guard.
13253         * compile/compile-object-load.h: Rename include guard.
13254         * compile/compile-internal.h: Rename include guard.
13255         * compile/compile-cplus.h: Rename include guard.
13256         * compile/compile-c.h: Rename include guard.
13257         * common/xml-utils.h: Rename include guard.
13258         * common/x86-xstate.h: Rename include guard.
13259         * common/version.h: Rename include guard.
13260         * common/vec.h: Rename include guard.
13261         * common/tdesc.h: Rename include guard.
13262         * common/selftest.h: Rename include guard.
13263         * common/scoped_restore.h: Rename include guard.
13264         * common/scoped_mmap.h: Rename include guard.
13265         * common/scoped_fd.h: Rename include guard.
13266         * common/safe-iterator.h: Rename include guard.
13267         * common/run-time-clock.h: Rename include guard.
13268         * common/refcounted-object.h: Rename include guard.
13269         * common/queue.h: Rename include guard.
13270         * common/ptid.h: Rename include guard.
13271         * common/print-utils.h: Rename include guard.
13272         * common/preprocessor.h: Rename include guard.
13273         * common/pathstuff.h: Rename include guard.
13274         * common/observable.h: Rename include guard.
13275         * common/netstuff.h: Rename include guard.
13276         * common/job-control.h: Rename include guard.
13277         * common/host-defs.h: Rename include guard.
13278         * common/gdb_wait.h: Rename include guard.
13279         * common/gdb_vecs.h: Rename include guard.
13280         * common/gdb_unlinker.h: Rename include guard.
13281         * common/gdb_unique_ptr.h: Rename include guard.
13282         * common/gdb_tilde_expand.h: Rename include guard.
13283         * common/gdb_sys_time.h: Rename include guard.
13284         * common/gdb_string_view.h: Rename include guard.
13285         * common/gdb_splay_tree.h: Rename include guard.
13286         * common/gdb_setjmp.h: Rename include guard.
13287         * common/gdb_ref_ptr.h: Rename include guard.
13288         * common/gdb_optional.h: Rename include guard.
13289         * common/gdb_locale.h: Rename include guard.
13290         * common/gdb_assert.h: Rename include guard.
13291         * common/filtered-iterator.h: Rename include guard.
13292         * common/filestuff.h: Rename include guard.
13293         * common/fileio.h: Rename include guard.
13294         * common/environ.h: Rename include guard.
13295         * common/common-utils.h: Rename include guard.
13296         * common/common-types.h: Rename include guard.
13297         * common/common-regcache.h: Rename include guard.
13298         * common/common-inferior.h: Rename include guard.
13299         * common/common-gdbthread.h: Rename include guard.
13300         * common/common-exceptions.h: Rename include guard.
13301         * common/common-defs.h: Rename include guard.
13302         * common/common-debug.h: Rename include guard.
13303         * common/cleanups.h: Rename include guard.
13304         * common/buffer.h: Rename include guard.
13305         * common/btrace-common.h: Rename include guard.
13306         * common/break-common.h: Rename include guard.
13307         * cli/cli-utils.h: Rename include guard.
13308         * cli/cli-style.h: Rename include guard.
13309         * cli/cli-setshow.h: Rename include guard.
13310         * cli/cli-script.h: Rename include guard.
13311         * cli/cli-interp.h: Rename include guard.
13312         * cli/cli-decode.h: Rename include guard.
13313         * cli/cli-cmds.h: Rename include guard.
13314         * charset-list.h: Add include guard.
13315         * buildsym-legacy.h: Rename include guard.
13316         * bfin-tdep.h: Add include guard.
13317         * ax.h: Rename include guard.
13318         * arm-linux-tdep.h: Add include guard.
13319         * arm-fbsd-tdep.h: Add include guard.
13320         * arch/xtensa.h: Rename include guard.
13321         * arch/tic6x.h: Add include guard.
13322         * arch/i386.h: Add include guard.
13323         * arch/arm.h: Rename include guard.
13324         * arch/arm-linux.h: Rename include guard.
13325         * arch/arm-get-next-pcs.h: Rename include guard.
13326         * arch/amd64.h: Add include guard.
13327         * arch/aarch64-insn.h: Rename include guard.
13328         * arch-utils.h: Rename include guard.
13329         * annotate.h: Add include guard.
13330         * amd64-darwin-tdep.h: Rename include guard.
13331         * aarch64-linux-tdep.h: Add include guard.
13332         * aarch64-fbsd-tdep.h: Add include guard.
13333         * aarch32-linux-nat.h: Add include guard.
13334
13335 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13336
13337         * macrotab.c (macro_define_internal): New function that
13338         factorizes macro_define_object_internal and macro_define_function
13339         code.
13340         (macro_define_object_internal): Use macro_define_internal.
13341         (macro_define_function): Likewise.
13342
13343 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13344
13345         * macrocmd.c (extract_identifier): Return
13346         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13347         callers.
13348
13349 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13350
13351         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13352
13353 2019-02-05  Tom Tromey  <tom@tromey.com>
13354
13355         * target.c (target_stack::unpush): Move assertion earlier.
13356
13357 2019-01-30  Tom Tromey  <tom@tromey.com>
13358
13359         PR python/23615:
13360         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13361         (gdbpy_parse_and_eval): Likewise.
13362         * python/python-internal.h (gdbpy_allow_threads): New class.
13363
13364 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13365
13366         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13367         (aarch64_fbsd_fpregmap): Move earlier.
13368         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13369         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13370         instead of individual calls to trad_frame_set_reg_addr.
13371         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13372         earlier.
13373         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13374         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13375         instead of individual calls to trad_frame_set_reg_addr.
13376
13377 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13378
13379         * CONTRIBUTE: Replace contribution list with wiki link.
13380
13381 2019-01-25  Tom Tromey  <tom@tromey.com>
13382
13383         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13384
13385 2019-01-25  Tom Tromey  <tom@tromey.com>
13386
13387         * xtensa-linux-nat.c: Fix common/ includes.
13388         * xml-support.h: Fix common/ includes.
13389         * xml-support.c: Fix common/ includes.
13390         * x86-linux-nat.c: Fix common/ includes.
13391         * windows-nat.c: Fix common/ includes.
13392         * varobj.h: Fix common/ includes.
13393         * varobj.c: Fix common/ includes.
13394         * value.c: Fix common/ includes.
13395         * valops.c: Fix common/ includes.
13396         * utils.c: Fix common/ includes.
13397         * unittests/xml-utils-selftests.c: Fix common/ includes.
13398         * unittests/utils-selftests.c: Fix common/ includes.
13399         * unittests/unpack-selftests.c: Fix common/ includes.
13400         * unittests/tracepoint-selftests.c: Fix common/ includes.
13401         * unittests/style-selftests.c: Fix common/ includes.
13402         * unittests/string_view-selftests.c: Fix common/ includes.
13403         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13404         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13405         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13406         * unittests/rsp-low-selftests.c: Fix common/ includes.
13407         * unittests/parse-connection-spec-selftests.c: Fix common/
13408         includes.
13409         * unittests/optional-selftests.c: Fix common/ includes.
13410         * unittests/offset-type-selftests.c: Fix common/ includes.
13411         * unittests/observable-selftests.c: Fix common/ includes.
13412         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13413         * unittests/memrange-selftests.c: Fix common/ includes.
13414         * unittests/memory-map-selftests.c: Fix common/ includes.
13415         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13416         * unittests/function-view-selftests.c: Fix common/ includes.
13417         * unittests/environ-selftests.c: Fix common/ includes.
13418         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13419         * unittests/common-utils-selftests.c: Fix common/ includes.
13420         * unittests/cli-utils-selftests.c: Fix common/ includes.
13421         * unittests/array-view-selftests.c: Fix common/ includes.
13422         * ui-file.c: Fix common/ includes.
13423         * tui/tui-io.c: Fix common/ includes.
13424         * tracepoint.h: Fix common/ includes.
13425         * tracepoint.c: Fix common/ includes.
13426         * tracefile-tfile.c: Fix common/ includes.
13427         * top.h: Fix common/ includes.
13428         * top.c: Fix common/ includes.
13429         * thread.c: Fix common/ includes.
13430         * target/waitstatus.h: Fix common/ includes.
13431         * target/waitstatus.c: Fix common/ includes.
13432         * target.h: Fix common/ includes.
13433         * target.c: Fix common/ includes.
13434         * target-memory.c: Fix common/ includes.
13435         * target-descriptions.c: Fix common/ includes.
13436         * symtab.h: Fix common/ includes.
13437         * symfile.c: Fix common/ includes.
13438         * stap-probe.c: Fix common/ includes.
13439         * spu-linux-nat.c: Fix common/ includes.
13440         * sparc-nat.c: Fix common/ includes.
13441         * source.c: Fix common/ includes.
13442         * solib.c: Fix common/ includes.
13443         * solib-target.c: Fix common/ includes.
13444         * ser-unix.c: Fix common/ includes.
13445         * ser-tcp.c: Fix common/ includes.
13446         * ser-pipe.c: Fix common/ includes.
13447         * ser-base.c: Fix common/ includes.
13448         * selftest-arch.c: Fix common/ includes.
13449         * s12z-tdep.c: Fix common/ includes.
13450         * rust-exp.y: Fix common/ includes.
13451         * rs6000-aix-tdep.c: Fix common/ includes.
13452         * riscv-tdep.c: Fix common/ includes.
13453         * remote.c: Fix common/ includes.
13454         * remote-notif.h: Fix common/ includes.
13455         * remote-fileio.h: Fix common/ includes.
13456         * remote-fileio.c: Fix common/ includes.
13457         * regcache.h: Fix common/ includes.
13458         * regcache.c: Fix common/ includes.
13459         * record-btrace.c: Fix common/ includes.
13460         * python/python.c: Fix common/ includes.
13461         * python/py-type.c: Fix common/ includes.
13462         * python/py-inferior.c: Fix common/ includes.
13463         * progspace.h: Fix common/ includes.
13464         * producer.c: Fix common/ includes.
13465         * procfs.c: Fix common/ includes.
13466         * proc-api.c: Fix common/ includes.
13467         * printcmd.c: Fix common/ includes.
13468         * ppc-linux-nat.c: Fix common/ includes.
13469         * parser-defs.h: Fix common/ includes.
13470         * osdata.c: Fix common/ includes.
13471         * obsd-nat.c: Fix common/ includes.
13472         * nat/x86-linux.c: Fix common/ includes.
13473         * nat/x86-linux-dregs.c: Fix common/ includes.
13474         * nat/x86-dregs.h: Fix common/ includes.
13475         * nat/x86-dregs.c: Fix common/ includes.
13476         * nat/ppc-linux.c: Fix common/ includes.
13477         * nat/mips-linux-watch.h: Fix common/ includes.
13478         * nat/mips-linux-watch.c: Fix common/ includes.
13479         * nat/linux-waitpid.c: Fix common/ includes.
13480         * nat/linux-ptrace.h: Fix common/ includes.
13481         * nat/linux-ptrace.c: Fix common/ includes.
13482         * nat/linux-procfs.c: Fix common/ includes.
13483         * nat/linux-personality.c: Fix common/ includes.
13484         * nat/linux-osdata.c: Fix common/ includes.
13485         * nat/linux-namespaces.c: Fix common/ includes.
13486         * nat/linux-btrace.h: Fix common/ includes.
13487         * nat/linux-btrace.c: Fix common/ includes.
13488         * nat/fork-inferior.c: Fix common/ includes.
13489         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13490         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13491         * nat/aarch64-linux.c: Fix common/ includes.
13492         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13493         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13494         * namespace.h: Fix common/ includes.
13495         * mips-linux-tdep.c: Fix common/ includes.
13496         * minsyms.c: Fix common/ includes.
13497         * mi/mi-parse.h: Fix common/ includes.
13498         * mi/mi-main.c: Fix common/ includes.
13499         * mi/mi-cmd-env.c: Fix common/ includes.
13500         * memrange.h: Fix common/ includes.
13501         * memattr.c: Fix common/ includes.
13502         * maint.h: Fix common/ includes.
13503         * maint.c: Fix common/ includes.
13504         * main.c: Fix common/ includes.
13505         * machoread.c: Fix common/ includes.
13506         * location.c: Fix common/ includes.
13507         * linux-thread-db.c: Fix common/ includes.
13508         * linux-nat.c: Fix common/ includes.
13509         * linux-fork.c: Fix common/ includes.
13510         * inline-frame.c: Fix common/ includes.
13511         * infrun.c: Fix common/ includes.
13512         * inflow.c: Fix common/ includes.
13513         * inferior.h: Fix common/ includes.
13514         * inferior.c: Fix common/ includes.
13515         * infcmd.c: Fix common/ includes.
13516         * inf-ptrace.c: Fix common/ includes.
13517         * inf-child.c: Fix common/ includes.
13518         * ia64-linux-nat.c: Fix common/ includes.
13519         * i387-tdep.c: Fix common/ includes.
13520         * i386-tdep.c: Fix common/ includes.
13521         * i386-linux-tdep.c: Fix common/ includes.
13522         * i386-linux-nat.c: Fix common/ includes.
13523         * i386-go32-tdep.c: Fix common/ includes.
13524         * i386-fbsd-tdep.c: Fix common/ includes.
13525         * i386-fbsd-nat.c: Fix common/ includes.
13526         * guile/scm-type.c: Fix common/ includes.
13527         * guile/guile.c: Fix common/ includes.
13528         * go32-nat.c: Fix common/ includes.
13529         * gnu-nat.c: Fix common/ includes.
13530         * gdbthread.h: Fix common/ includes.
13531         * gdbarch-selftests.c: Fix common/ includes.
13532         * gdb_usleep.c: Fix common/ includes.
13533         * gdb_select.h: Fix common/ includes.
13534         * gdb_bfd.c: Fix common/ includes.
13535         * gcore.c: Fix common/ includes.
13536         * fork-child.c: Fix common/ includes.
13537         * findvar.c: Fix common/ includes.
13538         * fbsd-nat.c: Fix common/ includes.
13539         * event-top.c: Fix common/ includes.
13540         * event-loop.c: Fix common/ includes.
13541         * dwarf2read.c: Fix common/ includes.
13542         * dwarf2loc.c: Fix common/ includes.
13543         * dwarf2-frame.c: Fix common/ includes.
13544         * dwarf-index-cache.c: Fix common/ includes.
13545         * dtrace-probe.c: Fix common/ includes.
13546         * disasm-selftests.c: Fix common/ includes.
13547         * defs.h: Fix common/ includes.
13548         * csky-tdep.c: Fix common/ includes.
13549         * cp-valprint.c: Fix common/ includes.
13550         * cp-support.h: Fix common/ includes.
13551         * cp-support.c: Fix common/ includes.
13552         * corelow.c: Fix common/ includes.
13553         * completer.h: Fix common/ includes.
13554         * completer.c: Fix common/ includes.
13555         * compile/compile.c: Fix common/ includes.
13556         * compile/compile-loc2c.c: Fix common/ includes.
13557         * compile/compile-cplus-types.c: Fix common/ includes.
13558         * compile/compile-cplus-symbols.c: Fix common/ includes.
13559         * command.h: Fix common/ includes.
13560         * cli/cli-dump.c: Fix common/ includes.
13561         * cli/cli-cmds.c: Fix common/ includes.
13562         * charset.c: Fix common/ includes.
13563         * build-id.c: Fix common/ includes.
13564         * btrace.h: Fix common/ includes.
13565         * btrace.c: Fix common/ includes.
13566         * breakpoint.h: Fix common/ includes.
13567         * breakpoint.c: Fix common/ includes.
13568         * ax.h:
13569         (enum agent_op): Fix common/ includes.
13570         * ax-general.c (struct aop_map): Fix common/ includes.
13571         * ax-gdb.c: Fix common/ includes.
13572         * auxv.c: Fix common/ includes.
13573         * auto-load.c: Fix common/ includes.
13574         * arm-tdep.c: Fix common/ includes.
13575         * arch/riscv.c: Fix common/ includes.
13576         * arch/ppc-linux-common.c: Fix common/ includes.
13577         * arch/i386.c: Fix common/ includes.
13578         * arch/arm.c: Fix common/ includes.
13579         * arch/arm-linux.c: Fix common/ includes.
13580         * arch/arm-get-next-pcs.c: Fix common/ includes.
13581         * arch/amd64.c: Fix common/ includes.
13582         * arch/aarch64.c: Fix common/ includes.
13583         * arch/aarch64-insn.c: Fix common/ includes.
13584         * arch-utils.c: Fix common/ includes.
13585         * amd64-windows-tdep.c: Fix common/ includes.
13586         * amd64-tdep.c: Fix common/ includes.
13587         * amd64-sol2-tdep.c: Fix common/ includes.
13588         * amd64-obsd-tdep.c: Fix common/ includes.
13589         * amd64-nbsd-tdep.c: Fix common/ includes.
13590         * amd64-linux-tdep.c: Fix common/ includes.
13591         * amd64-linux-nat.c: Fix common/ includes.
13592         * amd64-fbsd-tdep.c: Fix common/ includes.
13593         * amd64-fbsd-nat.c: Fix common/ includes.
13594         * amd64-dicos-tdep.c: Fix common/ includes.
13595         * amd64-darwin-tdep.c: Fix common/ includes.
13596         * agent.c: Fix common/ includes.
13597         * ada-lang.h: Fix common/ includes.
13598         * ada-lang.c: Fix common/ includes.
13599         * aarch64-tdep.c: Fix common/ includes.
13600
13601 2019-01-25  Tom Tromey  <tom@tromey.com>
13602
13603         * common/create-version.sh: Use common/version.h.
13604
13605 2019-01-24  Pedro Alves  <palves@redhat.com>
13606
13607         * infrun.c (signal_stop, signal_print, signal_program)
13608         (signal_catch, signal_pass): Now arrays instead of pointers.
13609         (update_signals_program_target, do_target_resume)
13610         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13611         * linux-nat.c (linux_nat_target::pass_signals)
13612         (linux_nat_target::create_inferior, linux_nat_target::attach):
13613         Adjust.
13614         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13615         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13616         * procfs.c (procfs_target::pass_signals): Adjust.
13617         * record-full.c (record_full_target::resume): Adjust.
13618         * remote.c (remote_target::pass_signals)
13619         (remote_target::program_signals): Adjust.
13620         * target-debug.h (target_debug_print_signals): Now takes a
13621         gdb::array_view as parameter.  Adjust.
13622         * target.h (target_ops) <pass_signals, program_signals>: Replace
13623         pointer and length parameters with gdb::array_view.
13624         (target_pass_signals, target_program_signals): Likewise.
13625         * target-delegates.c: Regenerate.
13626
13627 2019-01-24  Pedro Alves  <palves@redhat.com>
13628
13629         * common/forward-scope-exit.h
13630         (forward_scope_exit::forward_scope_exit): Pass arguments to
13631         m_bind_function directly, instead of creating a std::bind and
13632         copying that.
13633
13634 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13635
13636         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13637         for static members.
13638         (pass_in_v_vfp_candidate): Likewise.
13639
13640 2019-01-23  Tom Tromey  <tom@tromey.com>
13641             Pedro Alves  <palves@redhat.com>
13642
13643         * regcache.c (class regcache_invalidator): Remove.
13644         (regcache::raw_write): Use make_scope_exit.
13645
13646 2019-01-23  Tom Tromey  <tom@tromey.com>
13647
13648         * ui-out.h (class ui_out_emit_type): Update comment.
13649
13650 2019-01-23  Tom Tromey  <tom@tromey.com>
13651
13652         * infrun.c (fetch_inferior_event): Update comment.
13653
13654 2019-01-23  Tom Tromey  <tom@tromey.com>
13655             Pedro Alves  <palves@redhat.com>
13656
13657         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13658         parameter.
13659         (fetch_inferior_event): Use SCOPE_EXIT.
13660
13661
13662 2019-01-23  Tom Tromey  <tom@tromey.com>
13663             Pedro Alves  <palves@redhat.com>
13664
13665         * infrun.c (disable_thread_events): Delete.
13666         (stop_all_threads): Use SCOPE_EXIT.
13667
13668 2019-01-23  Tom Tromey  <tom@tromey.com>
13669             Pedro Alves  <palves@redhat.com>
13670
13671         * symfile.c: Include forward-scope-exit.h.
13672         (clear_symtab_users_cleanup): Replace forward declaration with
13673         a FORWARD_SCOPE_EXIT.
13674         (syms_from_objfile_1): Use the forward_scope_exit and
13675         gdb::optional instead of cleanup_function.
13676         (reread_symbols): Use the forward_scope_exit instead of
13677         cleanup_function.
13678         (clear_symtab_users_cleanup): Remove function.
13679
13680 2019-01-23  Tom Tromey  <tom@tromey.com>
13681             Pedro Alves  <palves@redhat.com>
13682
13683         * linux-nat.c: Include scope-exit.h.
13684         (cleanup_target_stop): Remove.
13685         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13686         SCOPE_EXIT.
13687
13688 2019-01-23  Tom Tromey  <tom@tromey.com>
13689             Pedro Alves  <palves@redhat.com>
13690
13691         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13692         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13693
13694 2019-01-23  Tom Tromey  <tom@tromey.com>
13695             Andrew Burgess  <andrew.burgess@embecosm.com>
13696             Pedro Alves  <palves@redhat.com>
13697
13698         * infrun.c (fetch_inferior_event): Use scope_exit.
13699         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13700         * top.c (execute_command): Use scope_exit.
13701         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13702         * utils.c (do_bpstat_clear_actions_cleanup)
13703         (make_bpstat_clear_actions_cleanup): Remove.
13704
13705 2019-01-23  Tom Tromey  <tom@tromey.com>
13706             Pedro Alves  <palves@redhat.com>
13707
13708         * infrun.c: Include "common/scope-exit.h"
13709         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13710         (wait_for_inferior): Use SCOPE_EXIT.
13711         (fetch_inferior_event): Use scope_exit.
13712
13713 2019-01-23  Tom Tromey  <tom@tromey.com>
13714             Pedro Alves  <palves@redhat.com>
13715
13716         * breakpoint.c (create_breakpoint): Remove cleanup.
13717
13718 2019-01-23  Tom Tromey  <tom@tromey.com>
13719             Andrew Burgess  <andrew.burgess@embecosm.com>
13720             Pedro Alves  <palves@redhat.com>
13721
13722 2019-01-23  Pedro Alves  <palves@redhat.com>
13723
13724         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13725
13726 2019-01-23  Pedro Alves  <palves@redhat.com>
13727             Andrew Burgess  <andrew.burgess@embecosm.com>
13728
13729         * gdbthread.h: Include "common/forward-scope-exit.h".
13730         (scoped_finish_thread_state): Redefine custom class in terms of
13731         forward_scope_exit.
13732
13733 2019-01-23  Pedro Alves  <palves@redhat.com>
13734             Andrew Burgess  <andrew.burgess@embecosm.com>
13735
13736         * common/forward-scope-exit.h: New file.
13737
13738 2019-01-23  Pedro Alves  <palves@redhat.com>
13739             Andrew Burgess  <andrew.burgess@embecosm.com>
13740             Tom Tromey  <tom@tromey.com>
13741
13742         * common/scope-exit.h: New file.
13743
13744 2019-01-23  Pedro Alves  <palves@redhat.com>
13745
13746         * common/preprocessor.h (ESC): Rename to ...
13747         (ESC_PARENS): ... this.
13748         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13749         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13750
13751 2019-01-23  Tom Tromey  <tom@tromey.com>
13752
13753         * language.h (class scoped_switch_to_sym_language_if_auto):
13754         Initialize m_lang in both cases.
13755
13756 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13757
13758         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13759         with XCNEW.
13760
13761 2019-01-22  Tom Tromey  <tom@tromey.com>
13762
13763         * corelow.c: Do not include sys/file.h.
13764
13765 2019-01-22  Tom Tromey  <tom@tromey.com>
13766
13767         * tui/tui-wingeneral.h: Include gdb_curses.h.
13768
13769 2019-01-22  Tom Tromey  <tom@tromey.com>
13770
13771         * source-cache.h (class source_cache) <get_source_lines,
13772         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13773
13774 2019-01-22  Tom Tromey  <tom@tromey.com>
13775
13776         * remote-fileio.h (struct remote_target): Declare.
13777
13778 2019-01-22  Tom Tromey  <tom@tromey.com>
13779
13780         * python/py-arch.c: Do not include py-ref.h.
13781         * python/py-bpevent.c: Do not include py-ref.h.
13782         * python/py-cmd.c: Do not include py-ref.h.
13783         * python/py-continueevent.c: Do not include py-ref.h.
13784         * python/py-event.h: Do not include py-ref.h.
13785         * python/py-evtregistry.c: Do not include py-ref.h.
13786         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13787         * python/py-frame.c: Do not include py-ref.h.
13788         * python/py-framefilter.c: Do not include py-ref.h.
13789         * python/py-function.c: Do not include py-ref.h.
13790         * python/py-infevents.c: Do not include py-ref.h.
13791         * python/py-linetable.c: Do not include py-ref.h.
13792         * python/py-objfile.c: Do not include py-ref.h.
13793         * python/py-param.c: Do not include py-ref.h.
13794         * python/py-prettyprint.c: Do not include py-ref.h.
13795         * python/py-progspace.c: Do not include py-ref.h.
13796         * python/py-symbol.c: Do not include py-ref.h.
13797         * python/py-symtab.c: Do not include py-ref.h.
13798         * python/py-type.c: Do not include py-ref.h.
13799         * python/py-unwind.c: Do not include py-ref.h.
13800         * python/py-utils.c: Do not include py-ref.h.
13801         * python/py-value.c: Do not include py-ref.h.
13802         * python/py-varobj.c: Do not include py-ref.h.
13803         * python/py-xmethods.c: Do not include py-ref.h.
13804         * python/python.c: Do not include py-ref.h.
13805         * varobj.c: Do not include py-ref.h.
13806
13807 2019-01-22  Tom Tromey  <tom@tromey.com>
13808
13809         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13810         keyword for bcache.
13811
13812 2019-01-22  Tom Tromey  <tom@tromey.com>
13813
13814         * compile/compile-cplus-types.c: Remove a comment by #include.
13815
13816 2019-01-22  Tom Tromey  <tom@tromey.com>
13817
13818         * compile/gcc-c-plugin.h: Include compile-internal.h.
13819
13820 2019-01-22  Tom Tromey  <tom@tromey.com>
13821
13822         * stabsread.c (EXTERN): Do not define.
13823         (symnum, next_symbol_text_func, processing_gcc_compilation)
13824         (within_function, global_sym_chain, global_stabs)
13825         (previous_stab_code, this_object_header_files)
13826         (n_this_object_header_files)
13827         (n_allocated_this_object_header_files): Define.
13828         * stabsread.h (EXTERN): Never define.  Use "extern".
13829
13830 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13831
13832         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13833         history_value.
13834
13835 2019-01-21  Tom Tromey  <tom@tromey.com>
13836
13837         * ui-out.c: Fix includes.
13838         * tui/tui-source.c: Fix includes.
13839         * target.c: Fix includes.
13840         * remote.c: Fix includes.
13841         * regcache.c: Fix includes.
13842         * python/py-block.c: Fix includes.
13843         * printcmd.c: Fix includes.
13844         * or1k-tdep.c: Fix includes.
13845         * mi/mi-main.c: Fix includes.
13846         * m32r-tdep.c: Fix includes.
13847         * csky-tdep.c: Fix includes.
13848         * compile/compile-cplus-types.c: Fix includes.
13849         * cli/cli-interp.c: Fix includes.
13850
13851 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13852
13853         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13854         for padding.
13855
13856 2019-01-16  Tom Tromey  <tom@tromey.com>
13857
13858         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13859         earlier.
13860         (struct objfile) <msymbols_range>: Move from top level.
13861         <msymbols>: New method.
13862         (class objfile_msymbols): Remove.
13863         * symtab.c (default_collect_symbol_completion_matches_break_on):
13864         Update.
13865         * symmisc.c (dump_msymbols): Update.
13866         * stabsread.c (scan_file_globals): Update.
13867         * objc-lang.c (info_selectors_command, info_classes_command)
13868         (find_methods): Update.
13869         * minsyms.c (find_solib_trampoline_target): Update.
13870         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13871         * coffread.c (coff_symfile_read): Update.
13872         * ada-lang.c (ada_lookup_simple_minsym)
13873         (ada_collect_symbol_completion_matches): Update.
13874
13875 2019-01-16  Tom Tromey  <tom@tromey.com>
13876
13877         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13878         type.  Remove no-argument constructor.
13879         <iterator::operator++>: Simplify.
13880         <begin>: Update.
13881         <end>: Use minimal_symbol_count.
13882
13883 2019-01-16  Tom Tromey  <tom@tromey.com>
13884
13885         * objfiles.h (struct objfile) <psymtabs>: New method.
13886         (class objfile_psymtabs): Remove.
13887         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13888         typedef.
13889         <range>: New method.
13890         (require_partial_symbols): Change return type.
13891         * psymtab.c (require_partial_symbols)
13892         (psym_expand_symtabs_matching): Update.
13893         * mdebugread.c (parse_partial_symbols): Update.
13894         * dbxread.c (dbx_end_psymtab): Update.
13895
13896 2019-01-15  Tom Tromey  <tom@tromey.com>
13897
13898         * symtab.c (lookup_objfile_from_block)
13899         (lookup_symbol_in_objfile_symtabs)
13900         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13901         (find_line_symtab, info_sources_command)
13902         (default_collect_symbol_completion_matches_break_on)
13903         (make_source_files_completion_list): Update.
13904         * symmisc.c (print_objfile_statistics, dump_objfile)
13905         (maintenance_print_symbols, maintenance_info_symtabs)
13906         (maintenance_check_symtabs, maintenance_info_line_tables):
13907         Update.
13908         * source.c (select_source_symtab)
13909         (forget_cached_source_info_for_objfile): Update.
13910         * objfiles.h (class objfile_compunits): Remove.
13911         (struct objfile) <compunits_range>: New typedef.
13912         (compunits): New method.
13913         * objfiles.c (objfile_relocate1): Update.
13914         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13915         * maint.c (count_symtabs_and_blocks): Update.
13916         * linespec.c (iterate_over_all_matching_symtabs): Update.
13917         * cp-support.c (add_symbol_overload_list_qualified): Update.
13918         * coffread.c (coff_symtab_read): Update.
13919         * ada-lang.c (add_nonlocal_symbols)
13920         (ada_collect_symbol_completion_matches)
13921         (ada_add_global_exceptions): Update.
13922
13923 2019-01-15  Tom Tromey  <tom@tromey.com>
13924
13925         * progspace.h (program_space) <objfiles_safe_range>: New
13926         typedef.
13927         <objfiles_safe>: New method.
13928         * objfiles.h (class all_objfiles_safe): Remove.
13929         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13930         * jit.c (jit_inferior_exit_hook): Update.
13931
13932 2019-01-17  Tom Tromey  <tom@tromey.com>
13933
13934         * progspace.h (program_space) <objfiles_range>: New typedef.
13935         <objfiles>: New method.
13936         <objfiles_head>: Rename from objfiles.
13937         (object_files): Update.
13938         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13939         * guile/scm-pretty-print.c
13940         (ppscm_find_pretty_printer_from_objfiles): Update.
13941         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13942         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13943         Update.
13944         * python/py-progspace.c (pspy_get_objfiles): Update.
13945         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13946         Update.
13947         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13948         (objfpy_lookup_objfile_by_build_id): Update.
13949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13950         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13951         Update.
13952         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13953         (expand_symtab_containing_pc, lookup_objfile_from_block)
13954         (lookup_static_symbol, basic_lookup_transparent_type)
13955         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13956         (find_line_symtab, info_sources_command)
13957         (default_collect_symbol_completion_matches_break_on)
13958         (make_source_files_completion_list, find_main_name): Update.
13959         * symmisc.c (print_symbol_bcache_statistics)
13960         (print_objfile_statistics, maintenance_print_symbols)
13961         (maintenance_print_msymbols, maintenance_print_objfiles)
13962         (maintenance_info_symtabs, maintenance_check_symtabs)
13963         (maintenance_expand_symtabs, maintenance_info_line_tables):
13964         Update.
13965         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13966         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13967         (map_overlay_command, unmap_overlay_command)
13968         (simple_overlay_update, expand_symtabs_matching)
13969         (map_symbol_filenames): Update.
13970         * symfile-debug.c (set_debug_symfile): Update.
13971         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13972         Update.
13973         * source.c (select_source_symtab, forget_cached_source_info):
13974         Update.
13975         * solib.c (solib_read_symbols): Update.
13976         * solib-spu.c (append_ocl_sos): Update.
13977         * psymtab.c (maintenance_print_psymbols)
13978         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13979         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13980         * printcmd.c (info_symbol_command): Update.
13981         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13982         Update.
13983         * objfiles.h (class all_objfiles): Remove.
13984         * objfiles.c (have_partial_symbols, have_full_symbols)
13985         (have_minimal_symbols, qsort_cmp, update_section_map)
13986         (shared_objfile_contains_address_p)
13987         (default_iterate_over_objfiles_in_search_order): Update.
13988         * objc-lang.c (info_selectors_command, info_classes_command)
13989         (find_methods): Update.
13990         * minsyms.c (find_solib_trampoline_target): Update.
13991         * maint.c (maintenance_info_sections)
13992         (maintenance_translate_address, count_symtabs_and_blocks):
13993         Update.
13994         * main.c (captured_main_1): Update.
13995         * linux-thread-db.c (try_thread_db_load_from_pdir)
13996         (has_libpthread): Update.
13997         * linespec.c (iterate_over_all_matching_symtabs)
13998         (search_minsyms_for_name): Update.
13999         * jit.c (jit_find_objf_with_entry_addr): Update.
14000         * hppa-tdep.c (find_unwind_entry)
14001         (hppa_lookup_stub_minimal_symbol): Update.
14002         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14003         Update.
14004         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14005         (elf_gnu_ifunc_resolve_by_got): Update.
14006         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14007         * dwarf-index-write.c (save_gdb_index_command): Update.
14008         * cp-support.c (add_symbol_overload_list_qualified): Update.
14009         * breakpoint.c (create_overlay_event_breakpoint)
14010         (create_longjmp_master_breakpoint)
14011         (create_std_terminate_master_breakpoint)
14012         (create_exception_master_breakpoint): Update.
14013         * blockframe.c (find_pc_partial_function): Update.
14014         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14015         (ada_collect_symbol_completion_matches)
14016         (ada_add_global_exceptions): Update.
14017
14018 2019-01-17  Tom Tromey  <tom@tromey.com>
14019
14020         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14021         declare VEC.
14022         (solib_target_parse_libraries): Change return type.
14023         (library_list_start_segment, library_list_start_section)
14024         (library_list_end_library, library_list_start_library); Update.
14025         (solib_target_free_library_list): Remove.
14026         (solib_target_parse_libraries): Remove cleanup.  Change return
14027         type.
14028         (solib_target_current_sos): Update.
14029
14030 2019-01-17  Tom Tromey  <tromey@bapiya>
14031
14032         * valprint.c: Replace "the the" with "the".
14033         * symtab.c: Replace "the the" with "the".
14034         * solib.c: Replace "the the" with "the".
14035         * solib-dsbt.c: Replace "the the" with "the".
14036         * linespec.c: Replace "the the" with "the".
14037         * dwarf2loc.h: Replace "the the" with "the".
14038         * amd64-windows-tdep.c: Replace "the the" with "the".
14039         * aarch64-tdep.c: Replace "the the" with "the".
14040
14041 2019-01-16  Keith Seitz  <keiths@redhat.com>
14042
14043         PR gdb/23773
14044         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14045         <builder>: Rename to ..
14046         <m_builder>: ... this and make private.
14047         (dwarf2_cu::get_builder): New method.  Change all users of
14048         `builder' to use this method.
14049         (dwarf2_start_symtab): Move to ...
14050         (dwarf2_cu::start_symtab): ... here.  Update all callers
14051         (setup_type_unit_groups): Move to ...
14052         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14053         callers.
14054         (dwarf2_cu::reset_builder): New method.
14055         (process_full_compunit, process_full_type_unit): Use
14056         dwarf2_cu::reset_builder.
14057         (follow_die_offset): Record the ancestor CU if it is different
14058         from the followed DIE's CU.
14059         (follow_die_sig_1): Likewise.
14060
14061 2019-01-15  Tom Tromey  <tom@tromey.com>
14062
14063         * remote.c (class remote_state) <buf>: Now a char_vector.
14064         <buf_size>: Remove.
14065         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14066         parameter.
14067         (remote_target::getpkt_or_notif_sane_1)
14068         (remote_target::getpkt_sane)
14069         (remote_target::getpkt_or_notif_sane): Likewise.
14070         (class remote_target) <putpkt>: New overload.
14071         (remote_target::read_frame): Change type of "buf_p".  Remove
14072         sizeof_p parameter.
14073         (packet_ok): New overload.
14074         (packet_check_result): New overload.
14075         Update all uses.
14076
14077 2019-01-14  Tom Tromey  <tom@tromey.com>
14078
14079         * remote-notif.c (handle_notification, remote_notif_ack)
14080         (remote_notif_parse): Make "buf" const.
14081         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14082         const.
14083         (remote_notif_parse, remote_notif_ack, handle_notification):
14084         Likewise.
14085         * remote.c (remote_notif_stop_parse): Make "buf" const.
14086         (remote_target::remote_parse_stop_reply): Make "buf" const.
14087         (remote_notif_stop_ack): Make "buf" const.
14088
14089 2019-01-14  Tom Tromey  <tom@tromey.com>
14090
14091         * remote.c (remote_console_output): Make parameter const.
14092
14093 2019-01-14  Tom Tromey  <tom@tromey.com>
14094
14095         * target-debug.h (target_debug_print_signals): Constify.
14096         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14097         * procfs.c (procfs_target::pass_signals): Update.
14098         * linux-nat.c (linux_nat_target::pass_signals): Update.
14099         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14100         * target-delegates.c: Rebuild.
14101         * remote.c (remote_target::program_signals): Update.
14102         (remote_target::pass_signals): Update.
14103         * target.c (target_pass_signals): Constify argument.
14104         (target_program_signals): Likewise.
14105         * target.h (struct target_ops) <pass_signals, program_signals>:
14106         Constify argument.
14107         (target_pass_signals, target_program_signals): Constify argument.
14108
14109 2019-01-14  Tom Tromey  <tom@tromey.com>
14110
14111         PR tui/28819:
14112         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14113
14114 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14115
14116         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14117         field.
14118         * rs6000-tdep.c: Include reggroups.h.
14119         (IS_V_ALIAS_PSEUDOREG): Define.
14120         (rs6000_register_name): Return names for the "vX" aliases.
14121         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14122         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14123         aliases.  Call default_register_reggroup_p for all other
14124         pseudo-registers.
14125         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14126         New functions.
14127         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14128         Handle "vX" aliases.
14129         (v_alias_pseudo_register_collect): New function.
14130         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14131         (rs6000_gdbarch_init): Initialize "vX" aliases as
14132         pseudo-registers.  Restore registration of
14133         rs6000_pseudo_register_reggroup_p with
14134         set_tdesc_pseudo_register_reggroup_p.
14135
14136 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14137
14138         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14139         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14140         set_gdbarch_num_pseudo_regs.
14141
14142 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14143
14144         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14145         Remove arg prefixname, add do_set and do_show.
14146         Add member functions set_list and show_list.
14147         * cli/cli-style.c (class cli_style_option): Update accordingly.
14148         (style_set_list): Move to file scope.
14149         (style_show_list): Likewise.
14150         (set_style): Call help_list.
14151         (show_style): Call cmd_show_list.
14152         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14153         Update to use the new macro.
14154
14155 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14156
14157         * ada-lang.c (_initialize_ada_language): Expand the help text
14158         for the "catch exception" command.
14159
14160 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14161
14162         * symtab.c (matching_obj_sections): Initialize obj,
14163         declare it closer to its usage.
14164
14165 2019-01-10  Tom Tromey  <tom@tromey.com>
14166
14167         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14168         (basic_inf_threads_range): Remove.
14169         (inf_threads_range, inf_non_exited_threads_range)
14170         (safe_inf_threads_range): Use next_adapter.
14171
14172 2019-01-10  Keith Seitz  <keiths@redhat.com>
14173
14174         PR gdb/23712
14175         PR symtab/23010
14176         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14177         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14178
14179 2019-01-10  Keith Seitz  <keiths@redhat.com>
14180
14181         PR gdb/23712
14182         PR symtab/23010
14183         * dictionary.c (pending_to_vector): Remove.
14184         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14185         Remove _1 suffix, replacing functions of the same name.  Update
14186         all callers.
14187         (dict_create_hashed, dict_create_hashed_expandable)
14188         (dict_create_linear, dict_create_linear_expandable, dict_free)
14189         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14190         Make functions static.
14191
14192 2019-01-10  Keith Seitz  <keiths@redhat.com>
14193
14194         PR gdb/23712
14195         PR symtab/23010
14196         * dictionary.h (struct dictionary): Replace declaration with
14197         multidictionary.
14198         (dict_create_hashed, dict_create_hashed_expandable)
14199         (dict_create_linear, dict_create_linear_expandable)
14200         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14201         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14202         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14203         taking multidictionary argument.
14204         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14205         * block.h (struct block) <dict>: Change to multidictionary
14206         and rename `multidict'.
14207         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14208         symmisc.c: Update all dictionary references to multidictionary.
14209
14210 2019-01-10  Keith Seitz  <keiths@redhat.com>
14211
14212         PR gdb/23712
14213         PR symtab/23010
14214         * dictionary.c: Include unordered_map.
14215         (pending_to_vector): New function.
14216         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14217         Rewrite the non-"_1" functions to take vector instead
14218         of linked list.
14219         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14220         "new" _1 versions of the same name.
14221         (multidictionary): Define.
14222         (std::hash<enum language): New definition.
14223         (collate_pending_symbols_by_language, mdict_create_hashed)
14224         (mdict_create_hashed_expandable, mdict_create_linear)
14225         (mdict_create_linear_expandable, mdict_free)
14226         (find_language_dictionary, create_new_language_dictionary)
14227         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14228         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14229         (mdict_size, mdict_empty): New functions.
14230         * dictionary.h (mdict_iterator): Define.
14231
14232 2019-01-10  Pedro Alves  <palves@redhat.com>
14233
14234         * breakpoint.c (read_uploaded_action)
14235         (create_tracepoint_from_upload): Adjust to use
14236         gdb::unique_xmalloc_ptr.
14237         * ctf.c (ctf_write_uploaded_tp):
14238         (SET_ARRAY_FIELD): Use emplace_back.
14239         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14240         * tracefile-tfile.c (tfile_write_uploaded_tp):
14241         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14242         gdb::unique_xmalloc_ptr.
14243         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14244         at_string, cond_string, cmd_strings>: Replace char pointers
14245         with gdb::unique_xmalloc_ptr.
14246
14247 2019-01-10  Pedro Alves  <palves@redhat.com>
14248
14249         * solib-target.c (library_list_start_library): Don't xstrdup name.
14250
14251 2019-01-10  Pedro Alves  <palves@redhat.com>
14252
14253         * mdebugread.c (parse_partial_symbols): Use
14254         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14255
14256 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14257
14258         * linux-fork.c (scoped_switch_fork_info)
14259         <~scoped_switch_fork_info>: Fix incorrect variable name.
14260
14261 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14262
14263         * linux-fork.c (scoped_switch_fork_info)
14264         <scoped_switch_fork_info>: Make explicit.
14265         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14266
14267 2019-01-10  Tom Tromey  <tom@tromey.com>
14268
14269         * objfiles.h (objfile::reset_psymtabs): Update.
14270         * objfiles.c (objfile::objfile): Update.
14271         * psymtab.h (psymtab_storage::obstack): Update.
14272         (psymtab_storage::m_obstack): Use gdb::optional.
14273         (class psymtab_storage): Update comment.  Remove objfile
14274         parameter.
14275         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14276
14277 2019-01-10  Tom Tromey  <tom@tromey.com>
14278
14279         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14280         <free_psymtabs>: Now private.
14281         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14282         (allocate_psymtab): Use new method.
14283
14284 2019-01-10  Tom Tromey  <tom@tromey.com>
14285
14286         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14287         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14288         * mdebugread.c (parse_partial_symbols): Use
14289         allocate_dependencies.
14290         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14291         allocate_dependencies.
14292         (process_psymtab_comp_unit_reader)
14293         (build_type_psymtab_dependencies): Likewise.
14294         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14295
14296 2019-01-10  Tom Tromey  <tom@tromey.com>
14297
14298         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14299         PSYMBOL_SET_LANGUAGE.
14300         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14301
14302 2019-01-10  Tom Tromey  <tom@tromey.com>
14303
14304         * psymtab.h (psymtab_storage::obstack): New method.
14305         <m_obstack>: Rename from obstack; now private.
14306         * psymtab.c (psymtab_storage): Update.
14307         * dwarf2read.c (create_addrmap_from_index)
14308         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14309         Update.
14310
14311 2019-01-10  Tom Tromey  <tom@tromey.com>
14312
14313         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14314         * objfiles.h (objfile::reset_psymtabs): New method.
14315
14316 2019-01-10  Tom Tromey  <tom@tromey.com>
14317
14318         * symmisc.c (print_symbol_bcache_statistics): Update.
14319         (print_objfile_statistics): Update.
14320         * symfile.c (reread_symbols): Update.
14321         * psymtab.h (class psymtab_storage): New.
14322         * psymtab.c (psymtab_storage): New constructor.
14323         (~psymtab_storage): New destructor.
14324         (require_partial_symbols): Update.
14325         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14326         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14327         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14328         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14329         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14330         (start_psymtab_common, end_psymtab_common)
14331         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14332         (allocate_psymtab): Update.
14333         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14334         Update.
14335         (dump_psymtab_addrmap, maintenance_print_psymbols)
14336         (maintenance_check_psymtabs): Update.
14337         (class objfile_psymtabs): Move to objfiles.h.
14338         * psympriv.h (discard_psymtab): Now inline.
14339         (psymtab_discarder::psymtab_discarder): Update.
14340         (psymtab_discarder::~psymtab_discarder): Update.
14341         (ALL_OBJFILE_PSYMTABS): Rewrite.
14342         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14343         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14344         Remove fields.
14345         <partial_symtabs>: New field.
14346         (class objfile_psymtabs): Move from psymtab.h.  Update.
14347         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14348         psymbol_cache.
14349         (objfile::~objfile): Don't destroy psymbol_cache.
14350         * mdebugread.c (parse_partial_symbols): Update.
14351         * dwarf2read.c (create_addrmap_from_index)
14352         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14353         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14354         (add_partial_subprogram, dwarf2_ranges_read): Update.
14355         * dwarf-index-write.c (write_address_map)
14356         (write_one_signatured_type, recursively_write_psymbols)
14357         (class debug_names, class debug_names, write_psymtabs_to_index):
14358         Update.
14359
14360 2019-01-10  Tom Tromey  <tom@tromey.com>
14361
14362         * symtab.h (SYMBOL_SET_NAMES): Update.
14363         (symbol_set_names): Update.
14364         (MSYMBOL_SET_NAMES): Update.
14365         * symtab.c (symbol_set_names): Change argument to be an
14366         objfile_per_bfd_storage.
14367         * psymtab.c (add_psymbol_to_bcache): Update.
14368         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14369
14370 2019-01-10  Tom Tromey  <tom@tromey.com>
14371
14372         * symtab.c (create_demangled_names_hash): Change argument to be an
14373         objfile_per_bfd_storage.
14374         (symbol_set_names): Update.
14375
14376 2019-01-10  Tom Tromey  <tom@tromey.com>
14377
14378         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14379         init_psymbol_list.
14380         * psymtab.c (init_psymbol_list): Do nothing if already called.
14381         * psympriv.h (init_psymbol_list): Add comment.
14382         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14383         init_psymbol_list.
14384         * dbxread.c (dbx_symfile_read): Unconditionally call
14385         init_psymbol_list.
14386
14387 2019-01-10  Tom Tromey  <tom@tromey.com>
14388
14389         * xcoffread.c (scan_xcoff_symtab): Update.
14390         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14391         "where".
14392         * mdebugread.c (parse_partial_symbols)
14393         (handle_psymbol_enumerators): Update.
14394         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14395         * dbxread.c (read_dbx_symtab): Update.
14396         * psympriv.h (psymbol_placement): New enum.
14397         (add_psymbol_to_list): Update.
14398
14399 2019-01-10  Tom Tromey  <tom@tromey.com>
14400
14401         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14402         static_psymbols parameters.
14403         (scan_xcoff_symtab): Update.
14404         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14405         static_psymbols parameters.
14406         * psympriv.h (start_psymtab_common): Update.
14407         * mdebugread.c (parse_partial_symbols): Update.
14408         * dwarf2read.c (create_partial_symtab): Update.
14409         * dbxread.c (read_dbx_symtab): Update.
14410         (start_psymtab): Remove global_psymbols and static_psymbols
14411         parameters.
14412
14413 2019-01-10  Tom Tromey  <tom@tromey.com>
14414
14415         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14416         * psymtab.c (allocate_psymtab): Add comment.
14417         * psympriv.h (allocate_psymtab): Add comment.
14418         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14419         initializations.
14420         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14421
14422 2019-01-10  Tom Tromey  <tom@tromey.com>
14423
14424         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14425         Don't declare.
14426         * mipsread.c: Include mdebugread.h.
14427         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14428         Declare.
14429         * elfread.c: Include mdebugread.h.
14430
14431 2019-01-09  Tom Tromey  <tom@tromey.com>
14432
14433         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14434         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14435         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14436         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14437         (psym_lookup_symbol, psym_find_last_source_symtab)
14438         (psym_forget_cached_source_info, psym_print_stats)
14439         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14440         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14441         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14442         (psym_find_compunit_symtab_by_address)
14443         (maintenance_print_psymbols, maintenance_info_psymtabs)
14444         (maintenance_check_psymtabs): Use ranged for.
14445         * psymtab.h (class objfile_psymtabs): New.
14446         (require_partial_symbols): Return objfile_psymtabs.
14447         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14448
14449 2019-01-09  Tom Tromey  <tom@tromey.com>
14450
14451         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14452         (find_pc_mapped_section, list_overlays_command)
14453         (map_overlay_command, unmap_overlay_command)
14454         (simple_overlay_update): Use all_objfiles.
14455         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14456         * printcmd.c (info_symbol_command): Use all_objfiles.
14457         * objfiles.h (ALL_OBJSECTIONS): Remove.
14458         * maint.c (maintenance_translate_address): Use all_objfiles.
14459         * gcore.c (gcore_create_callback): Use all_objfiles.
14460         (objfile_find_memory_regions): Likewise.
14461
14462 2019-01-09  Tom Tromey  <tom@tromey.com>
14463
14464         * symtab.c (find_line_symtab, info_sources_command)
14465         (make_source_files_completion_list): Use objfile_compunits.
14466         * source.c (select_source_symtab): Use objfile_compunits.
14467         * objfiles.h (struct objfile): Update comment.
14468         (ALL_OBJFILES): Remove.
14469         (ALL_FILETABS): Remove.
14470         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14471         objfile_compunits.
14472
14473 2019-01-09  Tom Tromey  <tom@tromey.com>
14474
14475         * symmisc.c (print_objfile_statistics, dump_objfile)
14476         (maintenance_print_symbols): Use compunit_filetabs.
14477         * source.c (forget_cached_source_info_for_objfile): Use
14478         compunit_filetabs.
14479         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14480         (ALL_FILETABS): Use compunit_filetabs.
14481         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14482         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14483
14484 2019-01-09  Tom Tromey  <tom@tromey.com>
14485
14486         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14487         (compunit_filetabs): New.
14488         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14489         compunit_filetabs.
14490         (info_sources_command, make_source_files_completion_list): Remove
14491         declaration.
14492         * symmisc.c (print_objfile_statistics, dump_objfile)
14493         (maintenance_print_symbols): Remove declaration.
14494         (maintenance_info_symtabs): Use compunit_filetabs.
14495         (maintenance_info_line_tables): Likewise.
14496         * source.c (select_source_symtab): Change local variable name.
14497         (forget_cached_source_info_for_objfile): Remove declaration.
14498         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14499         * objfiles.c (objfile_relocate1): Remove declaration.
14500         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14501         declaration.
14502         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14503         * coffread.c (coff_symtab_read): Remove declaration.
14504         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14505         compunit_filetabs.
14506
14507 2019-01-09  Tom Tromey  <tom@tromey.com>
14508
14509         * symtab.c (lookup_objfile_from_block)
14510         (find_pc_sect_compunit_symtab, search_symbols)
14511         (default_collect_symbol_completion_matches_break_on): Use
14512         objfile_compunits.
14513         * objfiles.h (ALL_COMPUNITS): Remove.
14514         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14515         * cp-support.c (add_symbol_overload_list_qualified): Use
14516         objfile_compunits.
14517         * ada-lang.c (ada_collect_symbol_completion_matches)
14518         (ada_add_global_exceptions): Use objfile_compunits.
14519
14520 2019-01-09  Tom Tromey  <tom@tromey.com>
14521
14522         * source.c (select_source_symtab)
14523         (forget_cached_source_info_for_objfile): Remove declaration.
14524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14525         declaration.
14526         * maint.c (count_symtabs_and_blocks): Remove declaration.
14527         * cp-support.c (add_symbol_overload_list_qualified): Remove
14528         declaration.
14529         * coffread.c (coff_symtab_read): Remove declaration.
14530         * symtab.c (lookup_symbol_in_objfile_symtabs)
14531         (basic_lookup_transparent_type_1): Use objfile_compunits.
14532         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14533         (info_sources_command, search_symbols)
14534         (default_collect_symbol_completion_matches_break_on)
14535         (make_source_files_completion_list): Remove declaration.
14536         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14537         (ada_collect_symbol_completion_matches)
14538         (ada_add_global_exceptions): Remove declaration.
14539         * linespec.c (iterate_over_all_matching_symtabs): Use
14540         objfile_compunits.
14541         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14542         (class objfile_compunits): New.
14543         (ALL_COMPUNITS): Use objfile_compunits.
14544         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14545         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14546         objfile_compunits.
14547         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14548
14549 2019-01-09  Tom Tromey  <tom@tromey.com>
14550
14551         * symtab.c (search_symbols)
14552         (default_collect_symbol_completion_matches_break_on): Use
14553         objfile_msymbols.
14554         * ada-lang.c (ada_lookup_simple_minsym)
14555         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14556         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14557         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14558         objfile_msymbols.
14559         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14560         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14561         * objc-lang.c (find_methods): Use objfile_msymbols.
14562         (info_selectors_command, info_classes_command): Likewise.
14563         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14564         * objfiles.h (class objfile_msymbols): New.
14565         (ALL_OBJFILE_MSYMBOLS): Remove.
14566         (ALL_MSYMBOLS): Remove.
14567
14568 2019-01-09  Tom Tromey  <tom@tromey.com>
14569
14570         * common/next-iterator.h (next_adapter): Add Iterator template
14571         parameter.
14572         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14573         (class all_objfiles_safe): New.
14574         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14575         * objfiles.c (put_objfile_before): Update comment.
14576         (add_separate_debug_objfile): Likewise.
14577         (free_all_objfiles): Use all_objfiles_safe.
14578         (objfile_purge_solibs): Likewise.
14579
14580 2019-01-09  Tom Tromey  <tom@tromey.com>
14581
14582         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14583         (expand_symtab_containing_pc, lookup_static_symbol)
14584         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14585         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14586         all_objfiles.
14587         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14588         * breakpoint.c (create_overlay_event_breakpoint)
14589         (create_longjmp_master_breakpoint)
14590         (create_std_terminate_master_breakpoint)
14591         (create_exception_master_breakpoint): Use all_objfiles.
14592         * linux-thread-db.c (try_thread_db_load_from_pdir)
14593         (has_libpthread): Use all_objfiles.
14594         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14595         * linespec.c (iterate_over_all_matching_symtabs)
14596         (search_minsyms_for_name): Use all_objfiles.
14597         * maint.c (maintenance_info_sections): Use all_objfiles.
14598         * main.c (captured_main_1): Use all_objfiles.
14599         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14600         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14601         * guile/scm-pretty-print.c
14602         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14603         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14604         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14605         (maintenance_print_msymbols): Use all_objfiles.
14606         * source.c (select_source_symtab): Use all_objfiles.
14607         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14608         * symfile.c (remove_symbol_file_command)
14609         (expand_symtabs_matching, map_symbol_filenames): Use
14610         all_objfiles.
14611         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14612         all_objfiles.
14613         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14614         * objc-lang.c (find_methods): Use all_objfiles.
14615         * objfiles.c (have_partial_symbols, have_full_symbols)
14616         (have_minimal_symbols, qsort_cmp)
14617         (default_iterate_over_objfiles_in_search_order): Use
14618         all_objfiles.
14619         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14620         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14621         (maintenance_check_psymtabs): Use all_objfiles.
14622         (ALL_PSYMTABS): Remove.
14623         * compile/compile-object-run.c (do_module_cleanup): Use
14624         all_objfiles.
14625         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14626         * cp-support.c (add_symbol_overload_list_qualified): Use
14627         all_objfiles.
14628         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14629         Use all_objfiles.
14630         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14631         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14632         all_objfiles.
14633         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14634         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14635         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14636         Uses all_objfiles.
14637         * solib.c (solib_read_symbols): Use all_objfiles
14638
14639 2019-01-09  Tom Tromey  <tom@tromey.com>
14640
14641         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14642         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14643         all_objfiles.
14644         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14645         * symmisc.c (print_symbol_bcache_statistics)
14646         (print_objfile_statistics, maintenance_print_objfiles)
14647         (maintenance_info_symtabs, maintenance_check_symtabs)
14648         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14649         all_objfiles.
14650         * source.c (forget_cached_source_info): Use all_objfiles.
14651         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14652         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14653         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14654         * objfiles.c (update_section_map): Use all_objfiles.
14655         (shared_objfile_contains_address_p): Likewise.
14656         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14657         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14658
14659 2019-01-09  Tom Tromey  <tom@tromey.com>
14660
14661         * common/next-iterator.h: New file.
14662         * objfiles.h (class all_objfiles): New.
14663         (struct objfile_iterator): New.
14664
14665 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14666
14667         * NEWS: Move the description of the changed "frame", "select-frame",
14668          and "info frame" commands to the Changed commands section.
14669
14670 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14671
14672         * gdbtypes.c (check_stub_method_group): Remove handling of old
14673         mangling schemes.
14674         * linespec.c (find_methods): Likewise.
14675         * stabsread.c (read_member_functions): Likewise.
14676         * valops.c (search_struct_method): Likewise.
14677         (value_struct_elt_for_reference): Likewise.
14678         * NEWS: Mention this change.
14679
14680 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14681
14682         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14683         print_source_lines.
14684         * source.c (print_source_lines_base): Update line number check.
14685         (print_source_lines): New function.
14686         (source_lines_range::source_lines_range): New function.
14687         * source.h (class source_lines_range): New class.
14688         (print_source_lines): New declaration.
14689
14690 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14691
14692         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14693
14694 2019-01-08  Tom Tromey  <tom@tromey.com>
14695             Simon Marchi  <simon.marchi@ericsson.com>
14696
14697         PR gdb/24060
14698         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14699         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14700         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14701         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14702         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14703         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14704
14705 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14706
14707         * source.c (select_source_symtab): Move header comment to
14708         declaration in source.h.
14709         (forget_cached_source_info_for_objfile): Likewise.
14710         (forget_cached_source_info): Likewise.
14711         (identify_source_line): Likewise.
14712         * source.h (identify_source_line): Move declaration from symtab.h
14713         and add comment from source.c
14714         (print_source_lines): Likewise.
14715         (forget_cached_source_info_for_objfile): Likewise.
14716         (forget_cached_source_info): Likewise.
14717         (select_source_symtab): Likewise.
14718         (enum print_source_lines_flag): Move definition from symtab.h.
14719         * symtab.h (identify_source_line): Move declaration to source.h.
14720         (print_source_lines): Likewise.
14721         (forget_cached_source_info_for_objfile): Likewise.
14722         (forget_cached_source_info): Likewise.
14723         (select_source_symtab): Likewise.
14724         (enum print_source_lines_flag): Move definition to source.h.
14725         * tui/tui-hooks.c: Add 'source.h' include.
14726
14727 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14728
14729         * source.c (print_source_lines_base): Handle requests to print
14730         reverse line number sequences, and guard against empty lines
14731         string.
14732
14733 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14734
14735         * source.c (print_source_lines_base): Fix skip of '\r' if next
14736         character is '\n'.
14737
14738 2019-01-06  Tom Tromey  <tom@tromey.com>
14739
14740         * c-exp.y (struct c_parse_state) <macro_original_text,
14741         expansion_obstack>: New member.
14742         (macro_original_text, expansion_obstack): Remove globals.
14743         (scan_macro_expansion, scanning_macro_expansion)
14744         (finished_macro_expansion): Update.
14745         (scan_macro_cleanup): Remove.
14746         (yylex, c_parse): Update.
14747
14748 2019-01-06  Tom Tromey  <tom@tromey.com>
14749
14750         * c-exp.y (struct c_parse_state) <strings>: New member.
14751         (operator_stoken): Update.
14752
14753 2019-01-06  Tom Tromey  <tom@tromey.com>
14754
14755         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14756         (union type_stack_elt) <typelist_val>: Now a pointer to
14757         std::vector.
14758         (type_stack_cleanup): Don't declare.
14759         (push_typelist): Update.
14760         * parse.c (pop_typelist): Return a std::vector.
14761         (push_typelist): Take a std::vector.
14762         (follow_types): Update.  Do not free args.
14763         (type_stack_cleanup): Remove.
14764         * c-exp.y (struct c_parse_state): New.
14765         (cpstate): New global.
14766         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14767         (nonempty_typelist): Update.
14768         (func_mod): Create a new vector.
14769         (c_parse): Create a c_parse_state.
14770         (check_parameter_typelist): Do not delete params.
14771         (function_method): Update.  Do not delete type_list.
14772
14773 2019-01-06  Tom Tromey  <tom@tromey.com>
14774
14775         PR gdb/28155:
14776         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14777         check_typedef.
14778         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14779         (print_return_value): Likewise.
14780
14781 2019-01-05  Tom Tromey  <tom@tromey.com>
14782
14783         * contrib/cleanup_check.py: Remove.
14784         * contrib/gcc-with-excheck: Remove.
14785         * contrib/exsummary.py: Remove.
14786         * contrib/excheck.py: Remove.
14787
14788 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14789
14790         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14791         NULL. Initialize tpprev to NULL instead of assigning it
14792         to NULL on the next statement.
14793         * windows-nat.c (windows_delete_thread): Remove check for
14794         main_thread_id before printing thread exit notifications.
14795         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14796         Remove thread ID check against main_thread_id.
14797         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14798         windows_delete_thread.
14799         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14800
14801 2019-01-04  Tom Tromey  <tom@tromey.com>
14802
14803         * compile/compile.c (_initialize_compile): Use upper case for
14804         metasyntactic variables.
14805         * symmisc.c (_initialize_symmisc): Use upper case for
14806         metasyntactic variables.
14807         * psymtab.c (_initialize_psymtab): Use upper case for
14808         metasyntactic variables.
14809         * demangle.c (demangle_command): Use upper case for metasyntactic
14810         variables.
14811         (_initialize_demangler): Likewise.
14812         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14813         variables.
14814
14815 2019-01-03  Tom Tromey  <tom@tromey.com>
14816
14817         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14818
14819 2019-01-03  Tom Tromey  <tom@tromey.com>
14820
14821         * python/py-symtab.c (salpy_str): Update.
14822         (struct salpy_sal_object) <symtab>: Now a PyObject.
14823         (salpy_dealloc): Update.
14824         (del_objfile_sal): Use gdbpy_ref.
14825
14826 2019-01-03  Tom Tromey  <tom@tromey.com>
14827
14828         * python/py-type.c (convert_field): Use new_reference.  Return
14829         gdbpy_ref.
14830         (make_fielditem): Return gdbpy_ref.
14831         (typy_fields): Update.
14832         (typy_getitem): Update.
14833         (field_name): Return gdbpy_ref.  Use new_reference.
14834         (typy_iterator_iternext): Update.
14835
14836 2019-01-03  Tom Tromey  <tom@tromey.com>
14837
14838         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14839
14840 2019-01-03  Tom Tromey  <tom@tromey.com>
14841
14842         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14843         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14844         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14845         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14846         (pspy_set_type_printers): Likewise.
14847         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14848         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14849         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14850         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14851         (objfpy_set_type_printers): Likewise.
14852
14853 2019-01-03  Tom Tromey  <tom@tromey.com>
14854
14855         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14856         (gdbpy_print_stack): Use gdbpy_err_fetch.
14857         * python/python-internal.h (class gdbpy_err_fetch): New class.
14858         (class gdbpy_enter) <m_error_type, m_error_value,
14859         m_error_traceback>: Remove.
14860         <m_error>: New member.
14861         (gdbpy_exception_to_string): Don't declare.
14862         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14863         * python/py-value.c (convert_value_from_python): Use
14864         gdbpy_err_fetch.
14865         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14866         gdbpy_exception_to_string.
14867         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14868         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14869         gdbpy_err_fetch.
14870
14871 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14872
14873         * linux-nat.c (delete_lwp_cleanup): Delete.
14874         (struct lwp_deleter): New struct.
14875         (lwp_info_up): New typedef.
14876         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14877         lwp_info_up.
14878
14879 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14880
14881         * linux-fork.c (class scoped_switch_fork_info): New class.
14882         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14883
14884 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14885
14886         * valops.c (find_overload_match): Remove use of null_cleanup, and
14887         calls to do_cleanups.
14888
14889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14890
14891         * compile/compile-cplus-types.c
14892         (compile_cplus_instance::decl_name): Handle changes to
14893         cp_func_name.
14894         * cp-support.c (cp_func_name): Update header comment, update
14895         return type.
14896         * cp-support.h (cp_func_name): Update return type in declaration.
14897         * valops.c (find_overload_match): Move temp_func local to top
14898         level of function and change its type.  Use temp_func to hold and
14899         delete temporary string obtained from cp_func_name.
14900
14901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14902
14903         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14904         gdb::char_vector, remove cleanup, and update uses of `msg`.
14905
14906 2019-01-03  Jim Wilson  <jimw@sifive.com>
14907
14908         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14909
14910 2019-01-02  Tom Tromey  <tom@tromey.com>
14911
14912         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14913         (tdesc_parse_xml): Remove cleanups.
14914         * target-descriptions.h (make_cleanup_free_target_description):
14915         Don't declare.
14916         (target_desc_deleter): New struct.
14917         (target_desc_up): New typedef.
14918         * target-descriptions.c (target_desc_deleter::operator()): Rename
14919         from free_target_description.
14920         (make_cleanup_free_target_description): Remove.
14921
14922 2019-01-02  Tom Tromey  <tom@tromey.com>
14923
14924         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14925         constructor, destructor.
14926         (linespec_parser): Remove typedef.
14927         (~linespec_parser): Rename from linespec_parser_delete.
14928         (linespec_lex_to_end, linespec_complete_label)
14929         (linespec_complete): Update.
14930         (decode_line_full): Remove cleanups.
14931         (decode_line_1): Update.
14932
14933 2019-01-02  Tom Tromey  <tom@tromey.com>
14934
14935         * python/python-internal.h (inferior_to_inferior_object): Change
14936         return type.
14937         * python/py-exitedevent.c (create_exited_event_object): Update.
14938         * python/py-inferior.c (inferior_to_inferior_object): Return
14939         gdbpy_ref.
14940         (python_new_inferior, python_inferior_deleted)
14941         (thread_to_thread_object, delete_thread_object)
14942         (build_inferior_list, gdbpy_selected_inferior): Update.
14943         * python/py-infthread.c (create_thread_object): Update.  Also fail
14944         if inferior_to_inferior_object fails.
14945
14946 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14947
14948         * inferior.h (class inferior) <displaced_step_state>: New field.
14949         * infrun.h (struct displaced_step_state): Move here from
14950         infrun.c.  Initialize fields, add constructor.
14951         <inf>: Remove field.
14952         <reset>: New method.
14953         * infrun.c (struct displaced_step_inferior_state): Move to
14954         infrun.h.
14955         (displaced_step_inferior_states): Remove.
14956         (get_displaced_stepping_state): Adust.
14957         (displaced_step_in_progress_any_inferior): Adjust.
14958         (displaced_step_in_progress_thread): Adjust.
14959         (displaced_step_in_progress): Adjust.
14960         (add_displaced_stepping_state): Remove.
14961         (get_displaced_step_closure_by_addr): Adjust.
14962         (remove_displaced_stepping_state): Remove.
14963         (infrun_inferior_exit): Call displaced_step_state.reset.
14964         (use_displaced_stepping): Don't check for NULL.
14965         (displaced_step_prepare_throw): Call
14966         get_displaced_stepping_state.
14967         (displaced_step_fixup): Don't check for NULL.
14968         (prepare_for_detach): Don't check for NULL.
14969
14970 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14971
14972         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14973          in case of call that did not complete.
14974
14975 2019-01-02  Andrey Utkin  <autkin@undo.io>
14976
14977         * symfile.c (find_separate_debug_file): Fix search of debug files for
14978         remote debuggee.
14979
14980 2019-01-02  Tom Tromey  <tom@tromey.com>
14981
14982         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14983         indentation.
14984         * python/py-frame.c (frapy_older): Remove cast.
14985         (frapy_newer): Likewise.
14986         * python/py-breakpoint.c (local_setattro): Remove cast.
14987         * python/py-arch.c (archpy_name): Remove local variable.
14988         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14989
14990 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14991
14992         * unittests/basic_string_view/element_access/char/empty.cc:
14993         Fix year range in copyright header.
14994
14995 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14996
14997         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14998         Delete.
14999         <operator==>: Update with for removed field.
15000         <hash>: Likewise.
15001         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15002         <isa_features>: ...this.
15003         <abi_features>: New field.
15004         (riscv_isa_flen): Update comment.
15005         (riscv_abi_xlen): New declaration.
15006         (riscv_abi_flen): New declaration.
15007         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15008         isa_features.
15009         (riscv_abi_xlen): New function.
15010         (riscv_isa_flen): Update to get answer from isa_features.
15011         (riscv_abi_flen): New function.
15012         (riscv_has_fp_abi): Update to get answer from abi_features.
15013         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15014         xlen and flen.
15015         (riscv_call_info) <xlen, flen>: Update comment.
15016         (riscv_call_arg_struct): Remove invalid assertions
15017         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15018         is removed.
15019         (riscv_gdbarch_init): Gather isa features and abi features
15020         separately, ensure both match on the gdbarch when reusing an old
15021         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15022         a target with 64-bit float hardware.
15023
15024 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15025
15026         * source.c (search_command_helper): Stop reverse search
15027         when line 1 has been searched.
15028
15029 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15030
15031         * record-full.c (record_full_base_target::close): Rewrite
15032         record_full_core_buf_list free logic.
15033
15034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15035
15036         * break-catch-syscall.c (print_one_catch_syscall): xfree
15037         the last text.
15038
15039 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15040
15041         * top.c (print_gdb_version): Update Copyright year in version
15042         message.
15043
15044 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15045
15046         Update copyright year range in all GDB files.
15047
15048 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15049
15050         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15051
15052 For older changes see ChangeLog-2018.
15053 \f
15054 Local Variables:
15055 mode: change-log
15056 left-margin: 8
15057 fill-column: 74
15058 version-control: never
15059 coding: utf-8
15060 End:
15061