gdb/ChangeLog

   1 2019-10-21  Tom Tromey  <tom@tromey.com>
   2
   3         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
   4         NM_H.   Use AC_CONFIG_LINKS.
   5         * configure: Rebuild.
   6         * Makefile.in (NM_H): New variable.
   7         (generated_files): Add NM_H.  Remove gcore.
   8         (nm.h, stamp-nmh): New targets.
   9
  10 2019-10-20  Tom Tromey  <tom@tromey.com>
  11
  12         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
  13         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
  14         obsolete comment.
  15         (put_objfile_before): Now static.
  16
  17 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
  18
  19         * gdbsupport/common-utils.h (startswith): Change return type to
  20         bool.
  21
  22 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
  25         * breakpoint.c (bp_locations_compare): Rename to...
  26         (bp_location_is_less_than): ...this, and change to std::sort semantics.
  27         (update_global_location_list): Use std::sort instead of qsort.
  28         * buildsym.c (compare_line_numbers): Rename to...
  29         (lte_is_less_than): ...this, and change to std::sort semantics.
  30         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
  31         instead of qsort.
  32         * disasm.c (compare_lines): Rename to...
  33         (line_is_less_than): ...this, and change to std::sort semantics.
  34         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
  35         of qsort.
  36         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
  37         (fde_is_less_than): ...this, and change to std::sort semantics.
  38         (dwarf2_build_frame_info): Call std::sort instead of qsort.
  39         * mdebugread.c (compare_blocks):
  40         (block_is_less_than): ...this, and change to std::sort semantics.
  41         (sort_blocks): Call std::sort instead of qsort.
  42         * objfiles.c (qsort_cmp): Rename to...
  43         (sort_cmp): ...this, and change to std::sort semantics.
  44         (update_section_map): Call std::sort instead of qsort.
  45         * remote.c (compare_pnums): Remove.
  46         (map_regcache_remote_table): Call std::sort instead of qsort.
  47         * utils.c (compare_positive_ints): Remove.
  48         * utils.h (compare_positive_ints): Remove.
  49         * xcoffread.c (compare_lte): Remove.
  50         (arrange_linetable): Call std::sort instead of qsort.
  51
  52 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
  53
  54         * symfile.c (init_entry_point_info): Fix typo.
  55         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
  56
  57 2019-10-18  Tom de Vries  <tdevries@suse.de>
  58
  59         * aarch64-tdep.c: Fix typos in comments.
  60         * ada-lang.c: Same.
  61         * ada-tasks.c: Same.
  62         * alpha-tdep.c: Same.
  63         * alpha-tdep.h: Same.
  64         * amd64-nat.c: Same.
  65         * amd64-windows-tdep.c: Same.
  66         * arc-tdep.c: Same.
  67         * arc-tdep.h: Same.
  68         * arch-utils.c: Same.
  69         * arm-nbsd-tdep.c: Same.
  70         * arm-tdep.c: Same.
  71         * ax-gdb.c: Same.
  72         * blockframe.c: Same.
  73         * btrace.c: Same.
  74         * c-varobj.c: Same.
  75         * coff-pe-read.c: Same.
  76         * coffread.c: Same.
  77         * cris-tdep.c: Same.
  78         * darwin-nat.c: Same.
  79         * dbxread.c: Same.
  80         * dcache.c: Same.
  81         * disasm.c: Same.
  82         * dtrace-probe.c: Same.
  83         * dwarf-index-write.c: Same.
  84         * dwarf2-frame-tailcall.c: Same.
  85         * dwarf2-frame.c: Same.
  86         * dwarf2read.c: Same.
  87         * eval.c: Same.
  88         * exceptions.c: Same.
  89         * fbsd-tdep.c: Same.
  90         * findvar.c: Same.
  91         * frame.c: Same.
  92         * frv-tdep.c: Same.
  93         * gnu-v3-abi.c: Same.
  94         * go32-nat.c: Same.
  95         * h8300-tdep.c: Same.
  96         * hppa-tdep.c: Same.
  97         * i386-linux-tdep.c: Same.
  98         * i386-tdep.c: Same.
  99         * ia64-libunwind-tdep.c: Same.
 100         * ia64-tdep.c: Same.
 101         * infcmd.c: Same.
 102         * infrun.c: Same.
 103         * linespec.c: Same.
 104         * linux-nat.c: Same.
 105         * linux-thread-db.c: Same.
 106         * machoread.c: Same.
 107         * mdebugread.c: Same.
 108         * mep-tdep.c: Same.
 109         * mn10300-tdep.c: Same.
 110         * namespace.c: Same.
 111         * objfiles.c: Same.
 112         * opencl-lang.c: Same.
 113         * or1k-tdep.c: Same.
 114         * osabi.c: Same.
 115         * ppc-linux-nat.c: Same.
 116         * ppc-linux-tdep.c: Same.
 117         * ppc-sysv-tdep.c: Same.
 118         * printcmd.c: Same.
 119         * procfs.c: Same.
 120         * record-btrace.c: Same.
 121         * record-full.c: Same.
 122         * remote-fileio.c: Same.
 123         * remote.c: Same.
 124         * rs6000-tdep.c: Same.
 125         * s12z-tdep.c: Same.
 126         * score-tdep.c: Same.
 127         * ser-base.c: Same.
 128         * ser-go32.c: Same.
 129         * skip.c: Same.
 130         * sol-thread.c: Same.
 131         * solib-svr4.c: Same.
 132         * solib.c: Same.
 133         * source.c: Same.
 134         * sparc-nat.c: Same.
 135         * sparc-sol2-tdep.c: Same.
 136         * sparc-tdep.c: Same.
 137         * sparc64-tdep.c: Same.
 138         * stabsread.c: Same.
 139         * stack.c: Same.
 140         * symfile.c: Same.
 141         * symtab.c: Same.
 142         * target-descriptions.c: Same.
 143         * target-float.c: Same.
 144         * thread.c: Same.
 145         * utils.c: Same.
 146         * valops.c: Same.
 147         * valprint.c: Same.
 148         * value.c: Same.
 149         * varobj.c: Same.
 150         * windows-nat.c: Same.
 151         * xcoffread.c: Same.
 152         * xstormy16-tdep.c: Same.
 153         * xtensa-tdep.c: Same.
 154
 155 2019-10-17  Tom Tromey  <tromey@adacore.com>
 156
 157         * configure: Rebuild.
 158         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 159         in AC_CONFIG_FILES invocation.
 160         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 161         new-style config.status invocation.
 162
 163 2019-10-17  Tom de Vries  <tdevries@suse.de>
 164
 165         * arm-nbsd-nat.c: Fix typos in comments.
 166         * arm-tdep.c: Same.
 167         * darwin-nat-info.c: Same.
 168         * dwarf2read.c: Same.
 169         * elfread.c: Same.
 170         * event-top.c: Same.
 171         * findvar.c: Same.
 172         * gdbtypes.c: Same.
 173         * hppa-tdep.c: Same.
 174         * i386-tdep.c: Same.
 175         * jit.c: Same.
 176         * main.c: Same.
 177         * mdebugread.c: Same.
 178         * moxie-tdep.c: Same.
 179         * nto-procfs.c: Same.
 180         * osabi.c: Same.
 181         * ppc-linux-tdep.c: Same.
 182         * remote.c: Same.
 183         * riscv-tdep.c: Same.
 184         * s390-tdep.c: Same.
 185         * sh-tdep.c: Same.
 186         * sparc-linux-tdep.c: Same.
 187         * sparc-nat.c: Same.
 188         * stack.c: Same.
 189         * target-descriptions.c: Same.
 190         * top.c: Same.
 191         * varobj.c: Same.
 192
 193 2019-10-16  Tom Tromey  <tom@tromey.com>
 194
 195         * objfiles.h (struct objfile) <original_name>: Now const.
 196
 197 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 198
 199         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 200         pass on to sigsetjmp's second argument.
 201         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 202
 203 2019-10-16  Keith Seitz  <keiths@redhat.com>
 204
 205         PR gdb/23567
 206         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 207         sections whose size is greater than the file size.
 208
 209 2019-10-16  Jim Wilson  <jimw@sifive.com>
 210
 211         * riscv-tdep.c (riscv_gcc_target_options): New.
 212         (riscv_gnu_triplet_regexp): New.
 213         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 214         set_gdbarch_gnu_triplet_regexp.
 215
 216 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 217
 218         * Makefile.in: Add xml-builtin.h.
 219         * features/feature_to_c.sh: Add an include for xml-builtin.h
 220         to ensure that the compiler checks that the types match.
 221         * xml-builtin.h: New file.
 222         * xml-support.c (fetch_xml_builtin): Add missing const.
 223         * xml-support.h: Remove declaration of xml_builtins.
 224
 225 2019-10-16  Tom de Vries  <tdevries@suse.de>
 226
 227         PR tdep/25096
 228         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 229         (amd64_classify_aggregate): ... here.
 230         (amd64_classify_aggregate_field): Handled fiels of nested structs
 231         recursively.
 232
 233 2019-10-16  Tom de Vries  <tdevries@suse.de>
 234
 235         PR tdep/24104
 236         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 237         that handles 'theclass'.
 238
 239 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * linespec.c (decode_digits_ordinary): Update comment.
 242         * make-target-delegates: No longer need to handle VEC case.
 243         * memrange.c (normalize_mem_ranges): Update comment.
 244         * namespace.c (add_using_directive): Update comment.
 245         * objc-lang.c (uniquify_strings): Update comment.
 246         * ppc-linux-nat.c (struct thread_points): Update comment.
 247         * probe.h (find_probes_in_objfile): Update comment.
 248         * target.h (enum flash_preserve_mode): Update comment.
 249         * varobj.c (varobj_restrict_range): Update comment.
 250         * varobj.h (varobj_list_children): Update comment.
 251
 252 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 253
 254         * Makefile.in: Remove references to vec.h and vec.c.
 255         * aarch64-tdep.c: No longer include vec.h.
 256         * ada-lang.c: Likewise.
 257         * ada-lang.h: Likewise.
 258         * arm-tdep.c: Likewise.
 259         * ax.h: Likewise.
 260         * breakpoint.h: Likewise.
 261         * charset.c: Likewise.
 262         * cp-support.h: Likewise.
 263         * dtrace-probe.c: Likewise.
 264         * dwarf2read.c: Likewise.
 265         * extension.h: Likewise.
 266         * gdb_bfd.c: Likewise.
 267         * gdbsupport/gdb_vecs.h: Likewise.
 268         * gdbsupport/vec.c: Remove.
 269         * gdbsupport/vec.h: Remove.
 270         * gdbthread.h: Likewise.
 271         * guile/scm-type.c: Likewise.
 272         * inline-frame.c: Likewise.
 273         * machoread.c: Likewise.
 274         * memattr.c: Likewise.
 275         * memrange.h: Likewise.
 276         * namespace.h: Likewise.
 277         * nat/linux-btrace.h: Likewise.
 278         * osdata.c: Likewise.
 279         * parser-defs.h: Likewise.
 280         * progspace.h: Likewise.
 281         * python/py-type.c: Likewise.
 282         * record-btrace.c: Likewise.
 283         * rust-exp.y: Likewise.
 284         * solib-target.c: Likewise.
 285         * stap-probe.c: Likewise.
 286         * target-descriptions.c: Likewise.
 287         * target-memory.c: Likewise.
 288         * target.h: Likewise.
 289         * varobj.c: Likewise.
 290         * varobj.h: Likewise.
 291         * xml-support.h: Likewise.
 292
 293 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 296         Update for new std::vector based implementation.
 297         (process_psymtab_comp_unit_reader): Likewise.
 298         (scan_partial_symbols): Likewise.
 299         (recursively_compute_inclusions): Likewise.
 300         (compute_compunit_symtab_includes): Likewise.
 301         (process_imported_unit_die): Likewise.
 302         (queue_and_load_dwo_tu): Likewise.
 303         (follow_die_sig_1): Likewise.
 304         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 305         (typedef dwarf2_per_cu_ptr): Remove.
 306         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 307         function.
 308         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 309         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 310         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 311         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 312         std::vector.
 313
 314 2019-10-15  Tom Tromey  <tromey@adacore.com>
 315
 316         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 317         TID.
 318
 319 2019-10-15  Tom Tromey  <tromey@adacore.com>
 320
 321         * windows-nat.c (windows_nat_target::fetch_registers)
 322         (windows_nat_target::store_registers): Rename "pid" to "tid".
 323
 324 2019-10-15  Tom Tromey  <tromey@adacore.com>
 325
 326         * gdbarch.h, gdbarch.c: Rebuild.
 327         * gdbarch.sh (gcc_target_options): Change return type to
 328         std::string.
 329         * compile/compile.c (get_args): Update.
 330         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 331         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 332         std::string.
 333         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 334         std::string.
 335         * arch-utils.c (default_gcc_target_options): Return std::string.
 336         * arch-utils.h (default_gcc_target_options): Return std::string.
 337         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 338
 339 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 340
 341         * breakpoint.c (breakpoint_chain): Make static.
 342         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 343         of accessing breakpoint_chain.
 344
 345 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 346
 347         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 348         to a gdb::function_view and return value to bool.
 349         * breakpoint.h (iterate_over_breakpoints): Likewise.
 350         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 351         (pop_dummy_frame): Update.
 352         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 353         (gdbscm_breakpoints): Update.
 354         * python/py-breakpoint.c (build_bp_list): Update.
 355         (gdbpy_breakpoints): Update.
 356         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 357         Update.
 358         (bpfinishpy_handle_stop): Update.
 359         (bpfinishpy_handle_exit): Update.
 360         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 361         (svr4_update_solib_event_breakpoints): Update.
 362
 363 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 364
 365         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 366         when unwrapping single-field structs.
 367
 368 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 369
 370         * dwarf2read.c: Remove includes.
 371
 372 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 373
 374         * ui-out.c (ui_out::call_do_message): Silence
 375         -Wformat-nonliteral warning.
 376
 377 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 378
 379         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 380         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 381         include: readline/tilde.h.
 382
 383 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 384
 385         * remote.c (remote_target::get_trace_status): Remove declaration of
 386         trace_regblock_size.
 387
 388 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 389
 390         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 391         (show_user): Remove declaration of cmdlist.
 392         * cli/cli-cmds.h (max_user_call_depth): Declare.
 393         * cli/cli-script.c (execute_user_command): Remove declaration
 394         of max_user_call_depth.
 395
 396 2019-10-11  Jim Wilson  <jimw@sifive.com>
 397
 398         * gdbsupport/print-utils.h (pulongest): Fix comment.
 399         (plongest): Likewise.
 400         (phex): Add missing comment, mention leading zeros.
 401         (phex_nz): Add mention of no leading zeros to comment.
 402
 403         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 404         plongest instead of unsigned long long cast.
 405
 406 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 407
 408         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 409         for external_editor_command and gdbtk_test.
 410
 411 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 412
 413         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 414         * varobj.c (varobjdebug): Move comment to...
 415         * varobj.h (varobjdebug): ...here, and declare.
 416
 417 2019-10-09  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 420         erase_data_content.
 421
 422 2019-10-09  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 425         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 426         * tui/tui-command.c (tui_cmd_window::resize)
 427         (tui_refresh_cmd_win): Update.
 428         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 429         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 430         * tui/tui-data.c (~tui_gen_win_info): Remove.
 431         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 432         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 433         (tui_redisplay_readline, tui_mld_flush)
 434         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 435         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 436         (tui_data_window::erase_data_content)
 437         (tui_data_item_window::rerender)
 438         (tui_data_item_window::refresh_window): Update.
 439         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 440         (box_win, tui_gen_win_info::make_window)
 441         (tui_gen_win_info::make_visible): Update.
 442         (tui_delete_win): Remove.
 443         * tui/tui-winsource.c
 444         (tui_source_window_base::do_erase_source_content): Update.
 445         (tui_show_source_line, tui_source_window_base::update_tab_width)
 446         (tui_source_window_base::update_exec_info): Update.
 447         * tui/tui-data.h (struct curses_deleter): New.
 448         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 449         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 450
 451 2019-10-09  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 454
 455 2019-10-09  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 458         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 459
 460 2019-10-09  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 463         window height directly.
 464         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 465         declare.
 466         * tui/tui-layout.c (tui_default_win_height): Remove.
 467         (tui_default_win_viewport_height): Remove.
 468
 469 2019-10-09  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui.h: Remove comments.
 472
 473 2019-10-09  Tom de Vries  <tdevries@suse.de>
 474
 475         * python/lib/gdb/printer/bound_registers.py: Use
 476         '^builtin_type_bound128' as regexp argument for
 477         add_builtin_pretty_printer.
 478
 479 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * guile/guile.c (guile_extension_script_ops): Remove forward
 482         declaration and mark as static.
 483         (guile_script_ops): Likewise.
 484         (extension_language_guile): Move further down in the file so
 485         it can reference the definitions for guile_{extension_,}script_ops.
 486
 487 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 488
 489         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 490         except SORTL, DFLTCC, and KDSA.
 491
 492 2019-10-08  Tom Tromey  <tromey@adacore.com>
 493
 494         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 495         (struct safe_symbol_file_add_args): Remove.
 496
 497 2019-10-08  Tom Tromey  <tromey@adacore.com>
 498
 499         * windows-nat.c: Don't include buildsym-legacy.h.
 500
 501 2019-10-08  Tom Tromey  <tromey@adacore.com>
 502
 503         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 504
 505 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 506
 507         * gdbtypes.c (overload_debug): Move comment to header.
 508         * gdbtypes.h (overload_debug): Declare.
 509         * valops.c: Remove declaration of overload_debug, instead
 510         include gdbtypes.h.
 511
 512 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 513
 514         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 515         through _().
 516         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 517         move comment...
 518         * language.h (lang_frame_mismatch_warn): ... here. Also add
 519         declaration.
 520         * top.c (lang_frame_mismatch_warn): Remove declaration.
 521         (check_frame_language_change): Pass lang_frame_mismatch_warn
 522         through _().
 523
 524 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 525
 526         * c-lang.h (vtbl_ptr_name): Declare.
 527         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 528         it from the header.
 529         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 530
 531 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 532
 533         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 534         gdb_static_assert.
 535
 536 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 537
 538         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 539         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 540         * ctfread.c: New file.
 541         * ctfread.h: New file.
 542         * elfread.c: Include ctfread.h.
 543         (struct elfinfo text_p): New member ctfsect.
 544         (elf_locate_sections): Mark CTF section.
 545         (elf_symfile_read): Call elfctf_build_psymtabs.
 546         * Makefile.in (LIBCTF): Add.
 547         (CLIBS): Use it.
 548         (CDEPS): Likewise.
 549         (DIST): Add ctfread.c.
 550
 551 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 552
 553         * ctfread.c (struct nextfield): Renamed to ...
 554         (struct ctf_nextfield): ... this.
 555         (struct field_info): Renamed to ...
 556         (strut ctf_field_info): ... this.
 557         (attach_fields_to_type): Update for renamed structures.
 558         (ctf_add_member_cb): Likewise.
 559         (ctf_add_enum_member_cb): Likewise.
 560         (process_struct_members): Likewise.
 561         (process_enum_type): Likewise.
 562
 563 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 564
 565         * tracectf.h: Rename, was ctf.h.
 566         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 567         * tracefile.c: Likewise.
 568         * tracepoint.c: Remove unused include ctf.h.
 569         * mi/mi-main.c: Likewise.
 570         * Makefile.in Replace ctf.c with tracectf.c.
 571
 572 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 573
 574         * version.in: Change version number to "9.0.50.DATE-git".
 575
 576 2019-10-03  Tom Tromey  <tom@tromey.com>
 577
 578         PR rust/24976:
 579         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 580
 581 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 584         cp_search_name_hash.
 585         * NEWS: Add entry about nested function support.
 586
 587 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 588             Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 591         for nested static variables when searchin VAR_DOMAIN.
 592         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 593         global scope, update comment.
 594         (add_partial_subprogram): Call add_partial_subprogram recursively
 595         for nested subroutines when processinng Fortran.
 596         (load_partial_dies): Process the child entities of a subprogram
 597         when processing Fortran.
 598         (partial_die_parent_scope): Handle building scope
 599         for Fortran nested functions.
 600         (process_die): Record that nested functions have a scope.
 601         (new_symbol): Always record Fortran subprograms on the global
 602         symbol list.
 603         (determine_prefix): How to build the prefix for Fortran
 604         subprograms.
 605
 606 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 609         have just sent the thread a SIGSTOP and are waiting for it to
 610         arrive.
 611
 612 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * btrace.c (btrace_add_pc): Remove whitespace before the template
 615         parameter in 'std::vector <...>'.
 616         (parse_xml_btrace_block): Likewise.
 617         (btrace_maint_decode_pt): Likewise.
 618         (btrace_maint_update_packets): Likewise.
 619         (btrace_maint_print_packets): Likewise.
 620         * btrace.h (struct btrace_maint_info): Likewise.
 621         * dwarf2read.c (struct type_unit_group): Likewise.
 622         (build_type_psymtabs_reader): Likewise.
 623         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 624         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 625         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 626
 627 2019-10-03  Tom de Vries  <tdevries@suse.de>
 628
 629         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 630         the first line of the help text for set/show style metadata.
 631
 632 2019-10-02  Tom Tromey  <tromey@adacore.com>
 633
 634         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 635         * gdbsupport/common-inferior.c: New file.
 636         * infcmd.c (startup_with_shell): Don't define.
 637         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 638         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 639         * inferior.h (startup_with_shell): Don't declare.
 640
 641 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 642
 643         * gdbsupport/gdb_assert.h: Include errors.h.
 644         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 645
 646 2019-10-02  Tom Tromey  <tromey@adacore.com>
 647
 648         * NEWS: Add $_ada_exception entry.
 649         * ada-lang.c (struct ada_catchpoint): Add constructor.
 650         <m_kind>: New member.
 651         (allocate_location_exception, re_set_exception): Remove
 652         "ex" parameter.
 653         (should_stop_exception): Compute $_ada_exception.
 654         (check_status_exception, print_it_exception)
 655         (print_one_exception, print_mention_exception): Remove
 656         "ex" parameter.
 657         (allocate_location_catch_exception, re_set_catch_exception)
 658         (check_status_exception, print_it_catch_exception)
 659         (print_one_catch_exception, print_mention_catch_exception)
 660         (print_recreate_catch_exception)
 661         (allocate_location_catch_exception_unhandled)
 662         (re_set_catch_exception_unhandled)
 663         (check_status_exception, print_it_catch_exception_unhandled)
 664         (print_one_catch_exception_unhandled)
 665         (print_mention_catch_exception_unhandled)
 666         (print_recreate_catch_exception_unhandled)
 667         (allocate_location_catch_assert, re_set_catch_assert)
 668         (check_status_assert, print_it_catch_assert)
 669         (print_one_catch_assert, print_mention_catch_assert)
 670         (print_recreate_catch_assert)
 671         (allocate_location_catch_handlers, re_set_catch_handlers)
 672         (check_status_handlers, print_it_catch_handlers)
 673         (print_one_catch_handlers, print_mention_catch_handlers)
 674         (print_recreate_catch_handlers): Remove.
 675         (create_ada_exception_catchpoint): Update.
 676         (initialize_ada_catchpoint_ops): Update.
 677
 678 2019-10-02  Tom Tromey  <tromey@adacore.com>
 679
 680         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 681         (create_excep_cond_exprs): Simplify exception string computation.
 682         (ada_exception_catchpoint_cond_string): Likewise.
 683
 684 2019-10-02  Tom Tromey  <tromey@adacore.com>
 685
 686         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 687         * ada-lang.c (lesseq_defined_than): Handle
 688         LOC_STATIC.
 689         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 690         parameter.
 691         (dwarf2_has_info): Likewise.
 692         (new_symbol): Set maybe_copied on symbol when
 693         appropriate.
 694         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 695         parameter.
 696         <can_copy>: New member.
 697         * elfread.c (record_minimal_symbol): Set maybe_copied
 698         on symbol when appropriate.
 699         (elf_symfile_read): Update call to dwarf2_has_info.
 700         * minsyms.c (lookup_minimal_symbol_linkage): New
 701         function.
 702         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 703         * symtab.c (get_symbol_address, get_msymbol_address):
 704         New functions.
 705         * symtab.h (get_symbol_address, get_msymbol_address):
 706         Declare.
 707         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 708         maybe_copied.
 709         (struct symbol, struct minimal_symbol) <maybe_copied>:
 710         New member.
 711
 712 2019-10-02  Tom Tromey  <tromey@adacore.com>
 713
 714         * source.c (struct current_source_location): New.
 715         (current_source_key): New global.
 716         (current_source_symtab, current_source_line)
 717         (current_source_pspace): Remove.
 718         (get_source_location): New function.
 719         (get_current_source_symtab_and_line)
 720         (set_default_source_symtab_and_line)
 721         (set_current_source_symtab_and_line)
 722         (clear_current_source_symtab_and_line, select_source_symtab)
 723         (info_source_command, print_source_lines_base)
 724         (info_line_command, search_command_helper, _initialize_source):
 725         Update.
 726
 727 2019-10-02  Tom Tromey  <tromey@adacore.com>
 728
 729         * source.c (select_source_symtab): Don't call
 730         decode_line_with_current_source.
 731
 732 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * symtab.c (lookup_global_symbol): Search global block.
 735
 736 2019-10-02  Tom Tromey  <tromey@adacore.com>
 737
 738         * coffread.c (process_coff_symbol): Update.
 739         * dwarf2read.c (var_decode_location, new_symbol): Update.
 740         * mdebugread.c (parse_symbol): Update.
 741         * objfiles.c (relocate_one_symbol): Update.
 742         * stabsread.c (define_symbol, fix_common_block)
 743         (scan_file_globals): Update.
 744         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 745         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 746         * xcoffread.c (process_xcoff_symbol): Update.
 747
 748 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 749
 750         * MAINTAINERS: Update my email address.
 751
 752 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 753
 754         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 755         std::vector.
 756         (build_type_psymtabs_reader): Update for std::vector.
 757         (build_type_psymtab_dependencies): Likewise.
 758         * dwarf2read.h: Remove use of DEF_VEC_P.
 759         (typedef sig_type_ptr): Delete.
 760
 761 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 764         to std::vector.
 765         (btrace_maint_decode_pt): Likewise, and move allocation of the
 766         vector outside of the loop.
 767         (btrace_maint_update_packets): Update to handle change from VEC to
 768         std::vector.
 769         (btrace_maint_print_packets): Likewise.
 770         (maint_info_btrace_cmd): Likewise.
 771         * btrace.h: Remove use of DEF_VEC_O.
 772         (typedef btrace_pt_packet_s): Delete.
 773         (struct btrace_maint_info) <packets>: Change fromm VEC to
 774         std::vector.
 775         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 776
 777 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 780         make accesses into the vector constant references.
 781         (btrace_add_pc): Update for std::vector.
 782         (btrace_stitch_bts): Likewise.
 783         (parse_xml_btrace_block): Likewise.
 784         (btrace_maint_update_packets): Likewise.
 785         (btrace_maint_print_packets): Likewise.
 786         (maint_info_btrace_cmd): Likewise.
 787         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 788         std::vector.
 789         (btrace_data::empty): Likewise.
 790         (btrace_data_append): Likewise.
 791         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 792         (typedef btrace_block_s): Delete.
 793         (struct btrace_block): Add constructor.
 794         (struct btrace_data_bts) <blocks>: Change to std::vector.
 795         * nat/linux-btrace.c (perf_event_read_bts): Update for
 796         std::vector.
 797         (linux_read_bts): Likewise.
 798
 799 2019-10-01  Tom Tromey  <tom@tromey.com>
 800
 801         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 802
 803 2019-10-01  Tom Tromey  <tom@tromey.com>
 804
 805         * stack.c (print_frame, info_frame_command_core): Use
 806         styled_string.
 807         * linux-thread-db.c (try_thread_db_load_1)
 808         (try_thread_db_load_from_pdir_1): Use styled_string.
 809         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 810         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 811         (maybe_print_unsupported_script_warning)
 812         (maybe_print_script_not_found_warning): Use styled_string.
 813         * ada-lang.c (user_select_syms): Use styled_string.
 814
 815 2019-10-01  Tom Tromey  <tom@tromey.com>
 816
 817         * p-lang.c (pascal_printstr): Use metadata style.
 818         * value.c (show_convenience): Use metadata style.
 819         * valprint.c (valprint_check_validity, val_print_optimized_out)
 820         (val_print_not_saved, val_print_unavailable)
 821         (val_print_invalid_address, generic_val_print, val_print)
 822         (value_check_printable, val_print_array_elements): Use metadata
 823         style.
 824         * ui-out.h (class ui_out) <field_fmt>: New overload.
 825         <do_field_fmt>: Add style parameter.
 826         * ui-out.c (ui_out::field_fmt): New overload.
 827         * typeprint.c (type_print_unknown_return_type)
 828         (val_print_not_allocated, val_print_not_associated): Use metadata
 829         style.
 830         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 831         parameter.
 832         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 833         * tracepoint.c (tvariables_info_1): Use metadata style.
 834         * stack.c (print_frame_arg, print_frame_info, print_frame)
 835         (info_frame_command_core): Use metadata style.
 836         * skip.c (info_skip_command): Use metadata style.
 837         * rust-lang.c (rust_print_enum): Use metadata style.
 838         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 839         metadata style.
 840         * python/py-framefilter.c (py_print_single_arg): Use metadata
 841         style.
 842         * printcmd.c (do_one_display, print_variable_and_value): Use
 843         metadata style.
 844         * p-valprint.c (pascal_val_print)
 845         (pascal_object_print_value_fields): Use metadata style.
 846         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 847         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 848         parameter.
 849         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 850         * m2-valprint.c (m2_print_long_set): Use metadata style.
 851         * m2-typeprint.c (m2_print_type): Use metadata style.
 852         * infcmd.c (print_return_value_1): Use metadata style.
 853         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 854         * f-valprint.c (info_common_command_for_block): Use metadata
 855         style.
 856         * f-typeprint.c (f_type_print_base): Use metadata style.
 857         * expprint.c (print_subexp_standard): Use metadata style.
 858         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 859         * cli/cli-style.h (class cli_style_option): Add constructor.
 860         (metadata_style): Declare.
 861         * cli/cli-style.c (metadata_style): New global.
 862         (_initialize_cli_style): Register metadata style.
 863         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 864         parameter.
 865         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 866         * c-typeprint.c (c_type_print_base_struct_union)
 867         (c_type_print_base_1): Use metadata style.
 868         * breakpoint.c (watchpoint_value_print)
 869         (print_one_breakpoint_location): Use metadata style.
 870         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 871         style.
 872         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 873         style.
 874         * ada-valprint.c (val_print_packed_array_elements, printstr)
 875         (print_field_values, ada_val_print_ref, ada_val_print): Use
 876         metadata style.
 877         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 878         style.
 879         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 880         style.
 881         * ada-lang.c (user_select_syms): Use metadata style.
 882
 883 2019-10-01  Tom Tromey  <tom@tromey.com>
 884
 885         * cli/cli-cmds.c (pwd_command): Style output.
 886
 887 2019-10-01  Pedro Alves  <palves@redhat.com>
 888             Tom Tromey  <tom@tromey.com>
 889
 890         * symtab.c (print_symbol_info): Use %ps.
 891         (print_msymbol_info): Use %ps.
 892         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 893         * printcmd.c (print_variable_and_value): Use %ps.
 894         * macrocmd.c (show_pp_source_pos): Use %ps.
 895         * infrun.c (print_exited_reason): Use ui_out::message.
 896         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 897         (describe_other_breakpoints): Use ui_out::message and new
 898         formats.
 899         (say_where): Use new formats.
 900         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 901         and new formats.
 902
 903 2019-10-01  Pedro Alves  <palves@redhat.com>
 904             Tom Tromey  <tom@tromey.com>
 905
 906         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 907         (test_gdb_formats): New function.
 908         (run_tests): Call it.
 909         (test_format_specifier): Update.
 910         * utils.h (fputs_filtered): Update comment.
 911         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 912         (fputs_styled_unfiltered): Declare.
 913         * utils.c (fputs_styled_unfiltered): New function.
 914         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 915         (vfprintf_filtered): Update.
 916         (vfprintf_unfiltered, vprintf_filtered): Update.
 917         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 918         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 919         disallow_ui_out_field>: New constants.
 920         (enum class field_kind): New.
 921         (struct base_field_s, struct signed_field_s): New.
 922         (signed_field): New function.
 923         (struct string_field_s): New.
 924         (string_field): New function.
 925         (struct styled_string_s): New.
 926         (styled_string): New function.
 927         (class ui_out) <message>: Add comment.
 928         <vmessage, call_do_message>: New methods.
 929         <do_message>: Add style parameter.
 930         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 931         methods.
 932         (ui_out::message): Rewrite.
 933         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 934         parameter.
 935         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 936         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 937         gdb_extensions parameter.
 938         (class format_piece): Add parameter to constructor.
 939         (n_int_args): New field.
 940         * gdbsupport/format.c (format_pieces::format_pieces): Add
 941         gdb_extensions parameter.  Handle '*'.
 942         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 943         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 944         vfprintf_styled_no_gdbfmt.
 945         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 946         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 947         unfiltered output.
 948         * ui-style.h (struct ui_file_style) <ptr>: New method.
 949
 950 2019-10-01  Tom Tromey  <tom@tromey.com>
 951
 952         * unittests/format_pieces-selftests.c: Update.  Add final format.
 953         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 954         empty literal pieces.
 955
 956 2019-10-01  Tom Tromey  <tom@tromey.com>
 957
 958         * ui-out.h (enum class ui_out_style_kind): Remove.
 959         (class ui_out) <field_string, field_stsream, do_field_string>:
 960         Change type of "style".
 961         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 962         (ui_out::field_string): Update.
 963         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 964         of "style".
 965         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 966         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 967         * stack.c (print_frame_arg, print_frame_info, print_frame):
 968         Update.
 969         * source.c (print_source_lines_base): Update.
 970         * solib.c (info_sharedlibrary_command): Update.
 971         * skip.c (info_skip_command): Update.
 972         * record-btrace.c (btrace_call_history_src_line)
 973         (btrace_call_history): Update.
 974         * python/py-framefilter.c (py_print_frame): Update.
 975         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 976         "style".
 977         * mi/mi-out.c (mi_ui_out::do_table_header)
 978         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 979         (mi_ui_out::do_field_string): Update.
 980         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 981         Update.
 982         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 983         "style".
 984         * cli-out.c (cli_ui_out::do_table_header)
 985         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 986         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 987         (cli_ui_out::do_field_fmt): Update.
 988         * breakpoint.c (print_breakpoint_location): Update.
 989         (update_static_tracepoint): Update.
 990
 991 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 992
 993         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 994         conversion of gdb_datadir.
 995         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 996         remove not needed c_str ().
 997
 998 2019-09-30  Ali Tamur <tamur@google.com>
 999
1000         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1001         (dwarf2_string_attr): Likewise.
1002
1003 2019-09-30  Ali Tamur <tamur@google.com>
1004
1005         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1006         (process_full_type_unit): Likewise.
1007         (dump_die_shallow): Likewise.
1008         (cu_debug_loc_section): Likewise.
1009
1010 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1011
1012         * minsyms.c (compare_minimal_symbols): Rename to...
1013         (minimal_symbol_is_less_than): ...this, and adjust to STL
1014         conventions (return bool, take arguments as references)
1015         (minimal_symbol_reader::install): Call std::sort instead
1016         of qsort.
1017
1018 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1019
1020         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1021         hash and why.
1022         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1023         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1024
1025 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1026
1027         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1028         * psympriv.h (add_psymbol_to_list): Move comment here and update
1029         it.
1030
1031 2019-09-29  Tom de Vries  <tdevries@suse.de>
1032
1033         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1034         Use $tmpdir/$(basename "$output_file").dwz instead of
1035         "${output_file}.dwz".
1036
1037 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1038
1039         PR gdb/25045
1040         * hppa-linux-nat.c: Include gdbarch.h.
1041
1042 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1043
1044         * blockframe.c (find_pc_partial_function): Change return type to bool.
1045         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1046         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1047         (stub_gnu_ifunc_resolve_name): Likewise.
1048         * symtab.c (compare_filenames_for_search): Likewise.
1049         (compare_glob_filenames_for_search): Likewise.
1050         (matching_obj_sections): Likewise.
1051         (symbol_matches_domain): Likewise.
1052         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1053         (find_line_pc): Change return type to bool.
1054         (find_line_pc_range): Likewise.
1055         (producer_is_realview): Likewise.
1056         * symtab.h (symbol_matches_domain): Likewise.
1057         (find_pc_partial_function): Likewise.
1058         (find_pc_line_pc_range): Likewise.
1059         (in_gnu_ifunc_stub): Likewise.
1060         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1061         (find_line_pc): Likewise.
1062         (find_line_pc_range): Likewise.
1063         (matching_obj_sections): Likewise.
1064         (find_line_symtab): Change out parameter to bool.
1065         (producer_is_realview): Change return type to bool.
1066         (compare_filenames_for_search): Likewise.
1067         (compare_glob_filenames_for_search): Likewise.
1068
1069 2019-09-26  Tom Tromey  <tom@tromey.com>
1070
1071         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1072         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1073         * gdb_usleep.h: Remove.
1074         * gdb_usleep.c: Remove.
1075         * utils.c: Don't include gdb_usleep.h.
1076
1077 2019-09-26  Tom Tromey  <tromey@adacore.com>
1078
1079         * python/py-type.c (type_to_type_object): Call check_typedef
1080         for stub types.
1081
1082 2019-09-26  Tom Tromey  <tom@tromey.com>
1083
1084         * utils.h (initialize_utils): Don't declare.
1085         * top.c (gdb_init): Don't call initialize_utils.
1086         * utils.c (initialize_utils): Remove.  Move contents...
1087         (_initialize_utils): ... here.
1088
1089 2019-09-25  Tom Tromey  <tom@tromey.com>
1090
1091         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1092         * utils.h (make_hex_string): Don't declare.
1093         * utils.c (make_hex_string): Remove.
1094
1095 2019-09-24  Tom de Vries  <tdevries@suse.de>
1096
1097         PR gdb/23815
1098         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1099         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1100
1101 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1102
1103         * NEWS: Mention new simulator port for PRU.
1104
1105 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1106
1107         * ada-exp.y (write_object_remaining): Update.
1108         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1109         and eliminate the static buffer.
1110         (ada_decode_symbol): Update.
1111         (ada_la_decode): Update.
1112         (ada_sniff_from_mangled_name): Update.
1113         (is_valid_name_for_wild_match): Update.
1114         (ada_lookup_name_info::matches): Update and simplify.
1115         (name_matches_regex): Update.
1116         (ada_add_global_exceptions): Update.
1117         * ada-lang.h (ada_decode): Update signature.
1118         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1119         * dwarf-index-write.c (debug_names::insert): Update.
1120
1121 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1122
1123         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1124         formatting.
1125
1126 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1127
1128         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1129         Change "nonzero" to "true" in documentation.
1130
1131 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1132
1133         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1134         (_initialize_darwin_solib): Don't set
1135         darwin_so_ops.lookup_lib_global_symbol.
1136         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1137         set_gdbarch_iterate_over_objfiles_in_search_order.
1138         (elf_lookup_lib_symbol): Rename to...
1139         (svr4_iterate_over_objfiles_in_search_order): this, and update
1140         to iterate semantics.
1141         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1142         * solib.c (solib_global_lookup): Remove.
1143         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1144         (solib_global_lookup): Remove.
1145         * symtab.c (lookup_global_or_static_symbol): Remove call to
1146         solib_global_lookup.
1147
1148 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1149
1150         * NEWS: Move entries about default MI version now being
1151         version 3, and about the GDB/MI fix for multi-location
1152         breakpoints to the "since GDB 8.3" section.
1153
1154 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1155
1156         GDB 8.3.1 released.
1157
1158 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1159
1160         * NEWS: Mention that Cell/B.E. debugging support was removed.
1161         * MAINTAINERS: Remove spu target.
1162
1163         * config/djgpp/fnchange.lst: Remove entries for removed files.
1164
1165         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1166         spu-multiarch.o, and spu-tdep.o.
1167         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1168         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1169         spu-multiarch.c, and spu-tdep.c.
1170         * spu-linux-nat.c: Remove file.
1171         * spu-multiarch.c: Remove file.
1172         * spu-tdep.c: Remove file.
1173         * spu-tdep.h: Remove file.
1174         * solib-spu.c: Remove file.
1175         * solib-spu.h: Remove file.
1176
1177         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1178         * configure.nat (spu-linux): Remove.
1179         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1180         solib-multiarch.o from gdb_target_obs.
1181         (spu*-*-*): Remove.
1182
1183         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1184         feature flag.
1185         (ppc_linux_no_features): Update.
1186         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1187         Cell/B.E. support.
1188         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1189         (tdesc_powerpc_cell64l): Likewise.
1190         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1191         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1192         Cell/B.E. support.
1193         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1194         Do not include "features/rs6000/powerpc-cell32l.c" or
1195         "features/rs6000/powerpc-cell64l.c".
1196         (ppc_linux_spu_section): Remove.
1197         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1198         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1199         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1200         (ppc_linux_spe_context_lookup): Remove.
1201         (ppc_linux_spe_context_inferior_created): Remove.
1202         (ppc_linux_spe_context_solib_loaded): Remove.
1203         (ppc_linux_spe_context_solib_unloaded): Remove.
1204         (ppc_linux_spe_context): Remove.
1205         (struct ppu2spu_cache): Remove.
1206         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1207         (struct ppu2spu_data): Remove.
1208         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1209         ppu2spu_unwind): Remove.
1210         (ppc_linux_init_abi): Remove Cell/B.E. support.
1211         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1212
1213         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1214         (rs6000/powerpc-cell64l-expedite): Likewise
1215         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1216         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1217         rs6000/powerpc-cell64l.xml.
1218         * features/rs6000/powerpc-cell32l.xml: Remove.
1219         * features/rs6000/powerpc-cell64l.xml: Likewise.
1220         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1221         * features/rs6000/powerpc-cell64l.c: Likewise.
1222         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1223         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1224         * regformats/reg-spu.dat: Remove.
1225
1226         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1227         * corelow.c (struct spuid_list): Remove.
1228         (add_to_spuid_list): Remove.
1229         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1230         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1231         (remote_protocol_features): Remove associated entries.
1232         (_initialize_remote): No longer initialize them.
1233         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1234         * linux-nat.c (SPUFS_MAGIC): Remove.
1235         (linux_proc_xfer_spu): Remove.
1236         (spu_enumerate_spu_ids): Remove.
1237         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1238         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1239         (linux_make_corefile_notes): No longer call it.
1240
1241         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1242         (cooked_write_test): Likewise.
1243
1244 2019-09-20  Tom Tromey  <tom@tromey.com>
1245
1246         * NEWS: Mention case-sensitivity of TUI commands.
1247         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1248         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1249         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1250
1251 2019-09-20  Tom Tromey  <tom@tromey.com>
1252
1253         * tui/tui-source.c (tui_source_window::set_contents): Use
1254         make_unique_xstrdup.
1255         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1256         make_unique_xstrdup.
1257
1258 2019-09-20  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-data.c: Remove separator comments.
1261         * tui/tui-layout.c: Remove separator comments.
1262         * tui/tui-win.c: Remove separator comments.
1263         * tui/tui-wingeneral.c: Remove separator comments.
1264
1265 2019-09-20  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui.h (strcat_to_buf): Don't declare.
1268         * tui/tui.c (strcat_to_buf): Remove.
1269
1270 2019-09-20  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1273         from "fullname".
1274         * tui/tui-source.c (tui_source_window::set_contents)
1275         (tui_source_window::location_matches_p)
1276         (tui_source_window::maybe_update): Update.
1277
1278 2019-09-20  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1281         Update.
1282         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1283         prefix.
1284         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1285         (tui_data_window::line_from_reg_element_no)
1286         (tui_data_window::first_reg_element_no_inline)
1287         (tui_data_window::show_registers)
1288         (tui_data_window::show_register_group)
1289         (tui_data_window::display_registers_from)
1290         (tui_data_window::display_registers_from_line)
1291         (tui_data_window::first_data_item_displayed)
1292         (tui_data_window::delete_data_content_windows)
1293         (tui_data_window::erase_data_content)
1294         (tui_data_window::do_scroll_vertical)
1295         (tui_data_window::refresh_window)
1296         (tui_data_window::check_register_values): Update.
1297
1298 2019-09-20  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1301         (struct tui_locator_window) <full_name, proc_name>: Now
1302         std::string.
1303         * tui/tui-stack.c (tui_locator_window::make_status_line)
1304         (tui_locator_window::set_locator_fullname)
1305         (tui_locator_window::set_locator_info): Update.
1306         * tui/tui-source.c (tui_source_window::set_contents)
1307         (tui_source_window::showing_source_p): Update.
1308
1309 2019-09-20  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1312         Don't call tui_locator_win_info_ptr.
1313
1314 2019-09-20  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1317
1318 2019-09-20  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1321         height for locator.
1322         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1323         * tui/tui-layout.c (show_source_disasm_command, show_data)
1324         (show_source_or_disasm_and_command): Use 1 as height for locator.
1325
1326 2019-09-20  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui.c (tui_enable): Update.
1329         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1330         Update.
1331         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1332         Update.
1333         * tui/tui-data.c (win_resized): Now bool.
1334         (tui_win_resized): Return bool.
1335         (tui_set_win_resized_to): Accept a bool.
1336
1337 2019-09-20  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1340         Change type of "refresh_values_only".
1341         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1342         type of "refresh_values_only".
1343
1344 2019-09-20  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1347         std::string.
1348         (tui_disassemble): Add "pos" parameter.
1349         (tui_disasm_window::set_contents): Simplify.
1350
1351 2019-09-20  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-winsource.h (struct tui_source_window_base)
1354         <show_source_content>: Now private.
1355         * tui/tui-winsource.c
1356         (tui_source_window_base::show_source_content): Don't handle empty
1357         content case.
1358
1359 2019-09-20  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-layout.c (show_source_disasm_command)
1362         (show_source_or_disasm_and_command): Don't call
1363         show_source_content.
1364
1365 2019-09-20  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1368         Declare.
1369         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1370         from tui_make_status_line.
1371         (tui_locator_window::rerender): Update.
1372
1373 2019-09-20  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1376         (tui_locator_window::rerender): Update.
1377
1378 2019-09-20  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-winsource.h (struct tui_source_window_base)
1381         <~tui_source_window_base>: Don't declare.
1382         <fullname>: Remove.
1383         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1384         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1385         member.
1386         * tui/tui-source.c (tui_source_window::set_contents): Update.
1387         (tui_source_window::location_matches_p)
1388         (tui_source_window::maybe_update): Update.
1389
1390 2019-09-20  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-winsource.h (~tui_source_element): Remove.
1393         (tui_source_element): Update.
1394         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1395         * tui/tui-winsource.c (tui_show_source_line): Update.
1396         * tui/tui-source.c (tui_source_window::set_contents): Update.
1397         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1398
1399 2019-09-20  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1402         declare.
1403         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1404         tui_clear_source_windows_detail.
1405         * tui/tui-winsource.h (struct tui_source_window_base)
1406         <clear_detail>: Don't declare.
1407         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1408         Remove.
1409         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1410
1411 2019-09-20  Tom Tromey  <tromey@adacore.com>
1412
1413         PR ada/24919:
1414         * block.c (contained_in): Fix final return value.
1415
1416 2019-09-20  Alan Modra  <amodra@gmail.com>
1417
1418         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1419         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1420         (read_indirect_string_from_dwz): Use bfd accessor.
1421         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1422         * machoread.c (macho_symfile_read_all_oso): Likewise.
1423         * solib.c (solib_bfd_open): Likewise.
1424
1425 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1426
1427         * eval.c: Move declaration of overload_resolution to...
1428         * value.h: ...here.
1429
1430 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1431
1432         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1433         * arm-linux-tdep.c: Likewise.
1434         * arm-nbsd-nat.c: Likewise.
1435         * arm-tdep.h: Declare arm_apcs_32.
1436         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1437
1438 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1439
1440         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1441         * dwarf2read.h: Declare dwarf_always_disassemble.
1442
1443 2019-09-19  Tom de Vries  <tdevries@suse.de>
1444
1445         PR gdb/25009
1446         * source-cache.c (source_cache::ensure): Catch exception thrown during
1447         construction of the highlighter.
1448
1449 2019-09-18  Alan Modra  <amodra@gmail.com>
1450
1451         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1452         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1453         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1454         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1455         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1456         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1457         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1458         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1459         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1460         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1461         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1462         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1463         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1464         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1465         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1466         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1467         * mi/mi-interp.c: Update throughout for bfd section macro and
1468         function changes.
1469         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1470         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1471
1472 2019-09-18  Tom Tromey  <tom@tromey.com>
1473
1474         * NEWS: Add entry.
1475         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1476         call rl_initialize.
1477         (tui_enable): Do not call rl_initialize.
1478
1479 2019-09-18  Christian Groessler  <chris@groessler.org>
1480
1481         * alpha-linux-nat.c: Include gdbarch.h.
1482
1483 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1484
1485         * ui-file.c: Include cli/cli-style.h.
1486         (term_cli_styling): Remove cli_styling declaration.
1487
1488 2019-09-18  Alan Modra  <amodra@gmail.com>
1489
1490         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1491         to bfd_asymbol_section.
1492
1493 2019-09-18  Alan Modra  <amodra@gmail.com>
1494
1495         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1496         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1497         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1498
1499 2019-09-18  Alan Modra  <amodra@gmail.com>
1500
1501         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1502         * spu-linux-nat.c (spu_bfd_open): Likewise.
1503
1504 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1505
1506         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1507         to bool to match definition in dwarf2read.c.
1508
1509 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1510
1511         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1512         (print_signatures): Likewise.
1513         (trust_pad_over_xvs): Likewise.
1514         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1515         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1516         * arm-linux-nat.c (arm_apcs_32): Likewise.
1517         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1518         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1519         * arm-tdep.c (arm_debug): Likewise.
1520         (arm_apcs_32): Likewise.
1521         * auto-load.c (debug_auto_load): Likewise.
1522         (auto_load_gdb_scripts): Likewise.
1523         (global_auto_load): Likewise.
1524         (auto_load_local_gdbinit): Likewise.
1525         (auto_load_local_gdbinit_loaded): Likewise.
1526         * auto-load.h (global_auto_load): Likewise.
1527         (auto_load_local_gdbinit): Likewise.
1528         (auto_load_local_gdbinit_loaded): Likewise.
1529         * breakpoint.c (disconnected_dprintf): Likewise.
1530         (breakpoint_proceeded): Likewise.
1531         (automatic_hardware_breakpoints): Likewise.
1532         (always_inserted_mode): Likewise.
1533         (target_exact_watchpoints): Likewise.
1534         (_initialize_breakpoint): Update.
1535         * breakpoint.h (target_exact_watchpoints): Change to bool.
1536         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1537         * cli/cli-cmds.c (trace_commands): Likewise.
1538         * cli/cli-cmds.h (trace_commands): Likewise.
1539         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1540         to bool*.
1541         * cli/cli-logging.c (logging_overwrite): Change to bool.
1542         (logging_redirect): Likewise.
1543         (debug_redirect): Likewise.
1544         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1545         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1546         to bool.
1547         <boolean_option_def>: Update.
1548         (struct flag_option_def): Change default type of Context to bool
1549         from int.
1550         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1551         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1552         (get_setshow_command_value_string): Likewise.
1553         * cli/cli-style.c (cli_styling): Change to bool.
1554         (source_styling): Likewise.
1555         * cli/cli-style.h (source_styling): Likewise.
1556         (cli_styling): Likewise.
1557         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1558         to bool.
1559         * command.h (var_types): Update comment.
1560         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1561         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1562         bool.
1563         (debug_compile_cplus_scopes): Likewise.
1564         * compile/compile-internal.h (compile_debug): Likewise.
1565         * compile/compile.c (compile_debug): Likewise.
1566         (struct compile_options) <raw>: Likewise.
1567         * cp-support.c (catch_demangler_crashes): Likewise.
1568         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1569         (usr_cmd_cris_dwarf2_cfi): Likewise.
1570         * csky-tdep.c (csky_debug): Likewise.
1571         * darwin-nat.c (enable_mach_exceptions): Likewise.
1572         * dcache.c (dcache_enabled_p): Likewise.
1573         * defs.h (info_verbose): Likewise.
1574         * demangle.c (demangle): Likewise.
1575         (asm_demangle): Likewise.
1576         * dwarf-index-cache.c (debug_index_cache): Likewise.
1577         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1578         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1579         * dwarf2read.c (check_physname): Likewise.
1580         (use_deprecated_index_sections): Likewise.
1581         (dwarf_always_disassemble): Likewise.
1582         * eval.c (overload_resolution): Likewise.
1583         * event-top.c (set_editing_cmd_var): Likewise.
1584         (exec_done_display_p): Likewise.
1585         * event-top.h (set_editing_cmd_var): Likewise.
1586         (exec_done_display_p): Likewise.
1587         * exec.c (write_files): Likewise.
1588         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1589         (debug_fbsd_nat): Likewise.
1590         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1591         Likewise.
1592         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1593         <backtrace_past_entry> Likewise.
1594         * gdb-demangle.h (demangle): Likewise.
1595         (asm_demangle): Likewise.
1596         * gdb_bfd.c (bfd_sharing): Likewise.
1597         * gdbcore.h (write_files): Likewise.
1598         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1599         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1600         * gdbthread.h (print_thread_events): Likewise.
1601         * gdbtypes.c (opaque_type_resolution): Likewise.
1602         (strict_type_checking): Likewise.
1603         * gnu-nat.c (gnu_debug_flag): Likewise.
1604         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1605         * guile/scm-param.c (pascm_variable): Add boolval.
1606         (add_setshow_generic): Update.
1607         (pascm_param_value): Update.
1608         (pascm_set_param_value_x): Update.
1609         * hppa-tdep.c (hppa_debug): Change to bool..
1610         * infcall.c (may_call_functions_p): Likewise.
1611         (coerce_float_to_double_p): Likewise.
1612         (unwind_on_signal_p): Likewise.
1613         (unwind_on_terminating_exception_p): Likewise.
1614         * infcmd.c (startup_with_shell): Likewise.
1615         * inferior.c (print_inferior_events): Likewise.
1616         * inferior.h (startup_with_shell): Likewise.
1617         (print_inferior_events): Likewise.
1618         * infrun.c (step_stop_if_no_debug): Likewise.
1619         (detach_fork): Likewise.
1620         (debug_displaced): Likewise.
1621         (disable_randomization): Likewise.
1622         (non_stop): Likewise.
1623         (non_stop_1): Likewise.
1624         (observer_mode): Likewise.
1625         (observer_mode_1): Likewise.
1626         (set_observer_mode): Update.
1627         (sched_multi): Change to bool.
1628         * infrun.h (debug_displaced): Likewise.
1629         (sched_multi): Likewise.
1630         (step_stop_if_no_debug): Likewise.
1631         (non_stop): Likewise.
1632         (disable_randomization): Likewise.
1633         * linux-tdep.c (use_coredump_filter): Likewise.
1634         (dump_excluded_mappings): Likewise.
1635         * linux-thread-db.c (auto_load_thread_db): Likewise.
1636         (check_thread_db_on_load): Likewise.
1637         * main.c (captured_main_1): Update.
1638         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1639         xx2_opt, boolean_opt>: Change to bool.
1640         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1641         * maint.c (maintenance_profile_p): Likewise.
1642         (per_command_time): Likewise.
1643         (per_command_space): Likewise.
1644         (per_command_symtab): Likewise.
1645         * memattr.c (inaccessible_by_default): Likewise.
1646         * mi/mi-main.c (mi_async): Likewise.
1647         (mi_async_1): Likewise.
1648         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1649         * nat/fork-inferior.h (startup_with_shell): Likewise.
1650         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1651         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1652         * nios2-tdep.c (nios2_debug): Likewise.
1653         * or1k-tdep.c (or1k_debug): Likewise.
1654         * parse.c (parser_debug): Likewise.
1655         * parser-defs.h (parser_debug): Likewise.
1656         * printcmd.c (print_symbol_filename): Likewise.
1657         * proc-api.c (procfs_trace): Likewise.
1658         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1659         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1660         (set_parameter_value): Update.
1661         (add_setshow_generic): Update.
1662         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1663         to bool*.
1664         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1665         int*.
1666         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1667         * record-btrace.c (record_btrace_target::store_registers): Update.
1668         * record-full.c (record_full_memory_query): Change to bool.
1669         (record_full_stop_at_limit): Likewise.
1670         * record-full.h (record_full_memory_query): Likewise.
1671         * remote-notif.c (notif_debug): Likewise.
1672         * remote-notif.h (notif_debug): Likewise.
1673         * remote.c (use_range_stepping): Likewise.
1674         (interrupt_on_connect): Likewise.
1675         (remote_break): Likewise.
1676         * ser-tcp.c (tcp_auto_retry): Likewise.
1677         * ser-unix.c (serial_hwflow): Likewise.
1678         * skip.c (debug_skip): Likewise.
1679         * solib-aix.c (solib_aix_debug): Likewise.
1680         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1681         (spu_auto_flush_cache_p): Likewise.
1682         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1683         Likewise.
1684         (struct info_print_options) <quiet>: Likewise.
1685         * symfile-debug.c (debug_symfile): Likewise.
1686         * symfile.c (auto_solib_add): Likewise.
1687         (separate_debug_file_debug): Likewise.
1688         * symfile.h (auto_solib_add): Likewise.
1689         (separate_debug_file_debug): Likewise.
1690         * symtab.c (basenames_may_differ): Likewise.
1691         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1692         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1693         (struct info_types_options) <quiet>: Likewise.
1694         * symtab.h (demangle): Likewise.
1695         (basenames_may_differ): Likewise.
1696         * target-dcache.c (stack_cache_enabled_1): Likewise.
1697         (code_cache_enabled_1): Likewise.
1698         * target.c (trust_readonly): Likewise.
1699         (may_write_registers): Likewise.
1700         (may_write_memory): Likewise.
1701         (may_insert_breakpoints): Likewise.
1702         (may_insert_tracepoints): Likewise.
1703         (may_insert_fast_tracepoints): Likewise.
1704         (may_stop): Likewise.
1705         (auto_connect_native_target): Likewise.
1706         (target_stop_and_wait): Update.
1707         (target_async_permitted): Change to bool.
1708         (target_async_permitted_1): Likewise.
1709         (may_write_registers_1): Likewise.
1710         (may_write_memory_1): Likewise.
1711         (may_insert_breakpoints_1): Likewise.
1712         (may_insert_tracepoints_1): Likewise.
1713         (may_insert_fast_tracepoints_1): Likewise.
1714         (may_stop_1): Likewise.
1715         * target.h (target_async_permitted): Likewise.
1716         (may_write_registers): Likewise.
1717         (may_write_memory): Likewise.
1718         (may_insert_breakpoints): Likewise.
1719         (may_insert_tracepoints): Likewise.
1720         (may_insert_fast_tracepoints): Likewise.
1721         (may_stop): Likewise.
1722         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1723         (make_thread_apply_all_options_def_group): Change argument from int*
1724         to bool*.
1725         (thread_apply_all_command): Update.
1726         (print_thread_events): Change to bool.
1727         * top.c (confirm): Likewise.
1728         (command_editing_p): Likewise.
1729         (history_expansion_p): Likewise.
1730         (write_history_p): Likewise.
1731         (info_verbose): Likewise.
1732         * top.h (confirm): Likewise.
1733         (history_expansion_p): Likewise.
1734         * tracepoint.c (disconnected_tracing): Likewise.
1735         (circular_trace_buffer): Likewise.
1736         * typeprint.c (print_methods): Likewise.
1737         (print_typedefs): Likewise.
1738         * utils.c (debug_timestamp): Likewise.
1739         (sevenbit_strings): Likewise.
1740         (pagination_enabled): Likewise.
1741         * utils.h (sevenbit_strings): Likewise.
1742         (pagination_enabled): Likewise.
1743         * valops.c (overload_resolution): Likewise.
1744         * valprint.h (struct value_print_options) <prettyformat_arrays,
1745         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1746         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1747         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1748         Likewise.
1749         * windows-nat.c (new_console): Likewise.
1750         (cygwin_exceptions): Likewise.
1751         (new_group): Likewise.
1752         (debug_exec): Likewise.
1753         (debug_events): Likewise.
1754         (debug_memory): Likewise.
1755         (debug_exceptions): Likewise.
1756         (useshell): Likewise.
1757         * windows-tdep.c (maint_display_all_tib): Likewise.
1758         * xml-support.c (debug_xml): Likewise.
1759
1760 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1761
1762         * source.c (prepare_path_for_appending): New function.
1763         (openp): Make use of new function.
1764         (find_and_open_source): Search for the compilation directory and
1765         source file as a relative path beneath the directory search path.
1766
1767 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * source-cache.c (source_cache::get_line_charpos): Catch
1770         exceptions and return false, this matches the behaviour documented
1771         in the header file.
1772
1773 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1774
1775         * ada-tasks.c (info_task): Remove quoting of the task's name.
1776
1777 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1778
1779         * symfile.c (auto_solib_add): Replace comment with a reference
1780         to the header file.
1781
1782 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1783
1784         * NEWS: Mention that gdb can now be compiled with Python 3
1785         on Windows.
1786
1787 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * maint.c (maint_print_section_data::maint_print_section_data):
1790         Force use of 'float log10 (float)' by casting the argument to
1791         float.
1792
1793 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * maint.c: Add 'cmath' include.
1796         (struct maint_print_section_data): New structure.
1797         (print_section_index): New function.
1798         (print_bfd_section_info): Add header comment, small whitespace
1799         cleanup, and update to call new print_section_index function.
1800         (print_objfile_section_info): Likewise.
1801         (maint_obj_section_from_bfd_section): New function.
1802         (print_bfd_section_info_maybe_relocated): New function.
1803         (maintenance_info_sections): Add header comment, always use
1804         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1805
1806 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1809         inner scope, add check that the objfile has psymtabs before
1810         checking psymtabs_addrmap.
1811         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1812
1813 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1814
1815         * NEWS: Announce that Ada task names are now shown at more places,
1816         and between quotes (except in info task output).
1817         * gdb/ada-tasks.c (task_to_str): New function.
1818         (display_current_task_id): Call task_to_str.
1819         (task_command_1): Likewise.
1820         (print_ada_task_info): In non-mi mode, Properly align headers and data
1821         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1822
1823 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1824
1825         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1826         prstatus.pr_lwp.pr_info instead of making it up.
1827
1828 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1829
1830         * auto-load.c (auto_load_expand_dir_vars): Update.
1831         * defs.h (gdb_datadir): Change to std::string.
1832         (python_libdir): Likewise.
1833         (relocate_gdb_directory): Change return type to std::string.
1834         * guile/guile.c (gdbscm_data_directory): Update.
1835         (initialize_scheme_side): Update.
1836         * jit.c (jit_reader_dir): Change to std::string.
1837         (jit_reader_load_command): Update.
1838         * main.c (gdb_datadir): Change to std::string.
1839         (python_libdir): Likewise.
1840         (set_gdb_data_directory): Update.
1841         (relocate_path): Change to return std::string.
1842         (relocate_gdb_directory): Change to return std::string.
1843         (relocate_gdbinit_path_maybe_in_datadir): Update.
1844         (captured_main_1): Update.
1845         * python/python.c (do_start_initialization): Update.
1846         * top.c (show_gdb_datadir): Update.
1847         * xml-syscall.c (xml_init_syscalls_info): Update.
1848         (init_syscalls_info): Update.
1849
1850 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1851
1852         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1853         out of get_init_files.
1854         (get_init_files): Update.
1855
1856 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1857
1858         * main.c (get_init_files): Change to use std::string.
1859         (captured_main_1): Update.
1860         (print_gdb_help): Update.
1861
1862 2019-09-11  Ali Tamur  <tamur@google.com>
1863
1864         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1865         implementation.
1866
1867 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1868
1869         * dbxread.c (read_dbx_symtab): Update.
1870         * dwarf2read.c (load_partial_dies): Update.
1871         * mdebugread.c (parse_partial_symbols): Update.
1872         (handle_psymbol_enumerators): Update.
1873         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1874         * psymtab.c (add_psymbol_to_bcache): Likewise.
1875         (add_psymbol_to_list): Likewise.
1876         * symtab.c (symbol_set_names): Likewise.
1877         * symtab.h (symbol_set_names): Likewise.
1878         * xcoffread.c (scan_xcoff_symtab): Update.
1879
1880 2019-09-11  Tom Tromey  <tom@tromey.com>
1881
1882         * symfile-mem.c (symbol_file_add_from_memory): Use
1883         bfd_set_filename.
1884         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1885         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1886
1887 2019-09-10  Tom Tromey  <tromey@adacore.com>
1888
1889         * dwarf-index-write.c (write_psymbols): Extend error message.
1890         (debug_names::insert): Add Ada code.
1891         (debug_names::write_psymbols): Remove Ada check.
1892         (debug_names) <m_string_obstack>: New member.
1893         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1894         (gdb_index_symbol_name_matcher::matches): Remove.
1895         (mapped_index_base::find_name_components_bounds): Add "lang"
1896         parameter.
1897         (mapped_index_base::build_name_components): Also split names
1898         according to Ada syntax.
1899         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1900         type of "match_callback".
1901         (check_match, check_find_bounds_finds)
1902         (dw2_expand_symtabs_matching): Update.
1903         (dw2_debug_names_iterator): Add new constructor.
1904         (dw2_debug_names_map_matching_symbols): New function.
1905         (dw2_debug_names_expand_symtabs_matching): Update.
1906         (dwarf2_debug_names_functions): Use
1907         dw2_debug_names_map_matching_symbols.
1908
1909 2019-09-10  Tom Tromey  <tromey@adacore.com>
1910
1911         * dwarf2read.c (dw2_get_file_names_reader): Add the
1912         CU's file name to the results.
1913
1914 2019-09-10  Tom Tromey  <tromey@adacore.com>
1915
1916         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1917         map_matching_symbols.  Update.
1918         * dwarf2read.c (dw2_map_matching_symbols): Update.
1919         * psymtab.c (match_partial_symbol): Change type; update.
1920         (psym_map_matching_symbols): Likewise.
1921         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1922         type; update.
1923         * symfile.h (struct quick_symbol_functions)
1924         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1925         Remove "match".
1926
1927 2019-09-10  Tom Tromey  <tromey@adacore.com>
1928
1929         * psymtab.c (map_block): Remove.
1930         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1931         * symtab.c (iterate_over_symbols_terminated): New function.
1932         * symtab.c (iterate_over_symbols_terminated): Declare.
1933
1934 2019-09-10  Tom Tromey  <tromey@adacore.com>
1935
1936         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1937         * language.h (struct language_defn) <la_iterate_over_symbols>:
1938         Return bool.
1939         * symtab.c (iterate_over_symbols): Return bool.
1940         * symtab.h (iterate_over_symbols): Return bool.
1941
1942 2019-09-10  Tom Tromey  <tromey@adacore.com>
1943
1944         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1945         (add_nonlocal_symbols): Update.
1946         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1947         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1948         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1949         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1950         Change type of "callback".  Remove "data".
1951
1952
1953 2019-09-09  Ali Tamur  <tamur@google.com>
1954
1955         * dwarf2read.c (comp_unit_head): Update comment.
1956         (dwarf2_dwo_name): New function declaration.
1957         (dwarf_unit_type_name): New function declaration.
1958         (read_comp_unit_head): Add support for new compilation units,
1959         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1960         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1961         (currently named as "signature") in their header. Also clarify error
1962         messages.
1963         (lookup_dwo_id): New function. Returns the dwo id of the given
1964         compile unit.
1965         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1966         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1967         functions.
1968         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1969         (dwarf2_dwo_name): Get the dwo name if present.
1970         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1971         purposes.
1972
1973 2019-09-09  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1976
1977 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1978
1979         * python/python.c (do_start_initialization): Make progname_copy static,
1980         to avoid a leak report.
1981
1982 2019-09-08  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1985
1986 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1987
1988         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1989         Change type to gdb::optional<block_enum>.
1990         (dw2_symtab_iter_init): Change block_index parameter type
1991         to gdb::optional<block_enum>.
1992         (dw2_lookup_symbol): Change block_index parameter
1993         type to block_enum.c
1994         (dw2_debug_names_lookup_symbol): Likewise.
1995         * psymtab.c (psym_lookup_symbol): Likewise.
1996         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1997         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1998         Likewise.
1999
2000 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2001
2002         * defs.h (relocate_gdb_directory): Change int to bool in
2003         signature and rename flag to relocatable.
2004         * main.c (relocate_path): Likewise.
2005         (relocate_gdb_directory): Likewise.
2006
2007 2019-09-06  Alan Modra  <amodra@gmail.com>
2008
2009         * coffread.c (coff_symfile_read): Constify filename variable.
2010         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2011         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2012         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2013         * solib.c (reload_shared_libraries_1): Likewise.
2014         * symfile.c (reread_symbols): Likewise.
2015         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2016         * solib-darwin.c (darwin_bfd_open): Likewise.
2017         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2018
2019 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2022         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2023
2024 2019-09-03  Tom Tromey  <tromey@adacore.com>
2025
2026         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2027         types.
2028         (has_negatives): Unbias a range type bound.
2029         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2030         * gdbtypes.c (operator==): Handle new field.
2031         (create_range_type): Add "bias" parameter.
2032         (create_static_range_type, resolve_dynamic_range): Update.
2033         * gdbtypes.h (struct range_bounds) <bias>: New member.
2034         (create_range_type): Add bias parameter.
2035         * printcmd.c (print_scalar_formatted): Unbias range types.
2036         * value.c (unpack_long): Unbias range types.
2037         (pack_long): Bias range types.
2038
2039 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2040
2041         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2042         probe arguments.
2043
2044 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2045
2046         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2047         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2048         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2049         (compile_probe_arg): Likewise.
2050         * probe.h (get_argument_count): Likewise.
2051         * solib-svr4.c (solib_event_probe_action): Likewise.
2052         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2053
2054 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2055
2056         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2057         code to here...
2058         (svr4_create_solib_event_breakpoints): ...from here.
2059
2060 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2061
2062         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2063         suffix from warning message.
2064
2065 2019-08-30  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-winsource.h (struct tui_source_window_base)
2068         <refresh_all>: Don't declare.
2069         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2070         Remove.
2071         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2072         tui_show_locator_content.
2073         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2074         declare.
2075         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2076         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2077         declare.
2078
2079 2019-08-30  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2082
2083 2019-08-30  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2086         Remove unnecessary forward declarations.
2087
2088 2019-08-30  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2091         rerender.
2092         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2093         tui_show_locator_content.
2094
2095 2019-08-30  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2098         (tui_locator_window::rerender): Rewrite using body of previous
2099         tui_show_locator_content.
2100
2101 2019-08-30  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2104         set_locator_fullname>: New methods.
2105         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2106         Rename from tui_set_locator_fullname.
2107         (tui_locator_window::set_locator_info): Rename from
2108         tui_set_locator_info.  Return bool.
2109         (tui_update_locator_fullname, tui_show_frame_info): Update.
2110
2111 2019-08-30  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2114
2115 2019-08-30  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2118         call touchwin.
2119
2120 2019-08-30  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-wingeneral.c (box_win): Assume win_info and
2123         win_info->handle cannot be NULL.
2124
2125 2019-08-30  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2128         refresh_window>: Declare.
2129         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2130         resize.
2131         (tui_data_item_window::rerender): Rename from
2132         tui_display_register.
2133         (tui_data_item_window::refresh_window): New method.
2134         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2135         no-op.
2136
2137 2019-08-30  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2140         regs_column_count, current_group>: Move later.  Now private.
2141         <get_current_group>: New method.
2142         * tui/tui-regs.c (tui_reg_command): Update.
2143         * tui/tui-layout.c (tui_set_layout): Update.
2144
2145 2019-08-30  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2148         (tui_data_window::rerender): Don't call
2149         check_and_display_highlight_if_needed.
2150         (tui_data_window::refresh_all): Remove call to
2151         erase_data_content.
2152
2153 2019-08-30  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2156         (tui_data_window::display_registers_from)
2157         (tui_data_window::display_reg_element_at_line)
2158         (tui_data_window::display_registers_from_line): Remove checks of
2159         "empty".
2160
2161 2019-08-30  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2164         Don't declare.
2165         * tui/tui-regs.c (tui_data_window::show_registers): Call
2166         rerender.
2167         (tui_data_window::rerender): Rename from display_all_data.
2168         (tui_data_window::rerender): Remove old implementation.
2169
2170 2019-08-30  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2173         text.
2174         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2175
2176 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2177             Sergio Durigan Junior  <sergiodj@redhat.com>
2178
2179         PR win32/24284
2180         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2181
2182 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2183
2184         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2185         when searching for types.
2186
2187 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2188
2189         * f-lang.c (f_language_defn): Use f_print_typedef.
2190         * f-lang.h (f_print_typedef): Declare.
2191         * f-typeprint.c (f_print_typedef): Define.
2192
2193 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2194
2195         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2196
2197 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * cli/cli-utils.c (info_print_options_defs): Delete.
2200         (make_info_print_options_def_group): Delete.
2201         (extract_info_print_options): Delete.
2202         (info_print_command_completer): Delete.
2203         (info_print_args_help): Add extra parameter, and optionally
2204         include text about -n flag.
2205         * cli/cli-utils.h (struct info_print_options): Delete.
2206         (extract_info_print_options): Delete declaration.
2207         (info_print_command_completer): Delete declaration.
2208         (info_print_args_help): Add extra parameter, extend header
2209         comment.
2210         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2211         search_symbols.
2212         * stack.c (struct info_print_options): New type.
2213         (info_print_options_defs): New file scoped variable.
2214         (make_info_print_options_def_group): New static function.
2215         (info_print_command_completer): New static function.
2216         (info_locals_command): Update to use new local functions.
2217         (info_args_command): Likewise.
2218         (_initialize_stack): Add extra parameter to calls to
2219         info_print_args_help.
2220         * symtab.c (search_symbols): Add extra parameter, use this to
2221         possibly excluse non-debug symbols.
2222         (symtab_symbol_info): Add extra parameter, which is passed on to
2223         search_symbols.
2224         (struct info_print_options): New type.
2225         (info_print_options_defs): New file scoped variable.
2226         (make_info_print_options_def_group): New static function.
2227         (info_print_command_completer): New static function.
2228         (info_variables_command): Update to use local functions, and pass
2229         extra parameter through to symtab_symbol_info.
2230         (info_functions_command): Likewise.
2231         (info_types_command): Pass additional argument through to
2232         symtab_symbol_info.
2233         (rbreak_command): Pass extra argument to search_symbols.
2234         (_initialize_symtab): Add extra arguments for calls to
2235         info_print_args_help, and update help text for 'info variables',
2236         'whereis', and 'info functions' commands.
2237         * symtab.h (search_symbols): Add extra argument to declaration.
2238         * NEWS: Mention new flags.
2239
2240 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2241
2242         * symtab.c (lookup_static_symbol): Call the new function (and move
2243         it down to be next to lookup_global_symbol).
2244         (struct global_sym_lookup_data): Add block_enum member and rename to...
2245         (struct global_or_static_sym_lookup_data): ...this.
2246         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2247         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2248         (lookup_symbol_global_or_static_iterator_cb): ...this.
2249         (lookup_global_or_static_symbol): New function.
2250         (lookup_global_symbol): Call new function.
2251
2252 2019-08-26  Tom de Vries  <tdevries@suse.de>
2253
2254         PR c++/24852
2255         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2256         when pc_probe.prob == NULL.
2257
2258 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2259
2260         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2261         variable symbol_linkage to symbol_linkage_.
2262
2263 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2264
2265         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2266         represent whether the symbol is static, dynamic, or we don't
2267         know.
2268
2269 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2270
2271         * gdb/rx-tdep.c (rx_register_names): New.
2272         (rx_register_name): Delete.
2273         (rx_psw_type): Delete.
2274         (rx_fpsw_type): Delete.
2275         (rx_register_type): Delete.
2276         (rx_gdbarch_init): Convert target-descriptions.
2277         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2278         * gdb/features/Makefile: Add rx.xml.
2279         * gdb/features/rx.xml: New.
2280         * gdb/features/rx.c: Generated.
2281         * gdb/NEWS: Mention target description support.
2282
2283 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2286         *slot_ptr.
2287
2288 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2289
2290         * configure.ac: Don't check for 'dlfcn.h' (moved to
2291         gdbsupport/common.m4).
2292         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2293         'gdbsupport/'.
2294         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2295         * compile/compile-c-support.c: Include
2296         'gdbsupport/gdb-dlfcn.h'.
2297         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2298         * gdb-dlfcn.c: Move to...
2299         * gdbsupport/gdb-dlfcn.c: ... here.
2300         * gdb-dlfcn.h: Move to...
2301         * gdbsupport/gdb-dlfcn.h: ... here.
2302
2303 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2304
2305         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2306         the offset field signed.
2307
2308 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2309
2310         * python/lib/gdb/__init__.py (_execute_file): New function.
2311         * python/python.c (python_run_simple_file): Call gdb._execute_file
2312         on Windows.
2313
2314 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2317         all uses as this was never set to anything but a zero value.
2318
2319 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2320
2321         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2322
2323 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2324
2325         * tui/tui-data.h (tui_gen_win_info): Add an =default
2326         move constructor, required by some GCC versions.
2327
2328 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2329
2330         * go32-nat.c (go32_sysinfo): Add hygon_p.
2331
2332 2019-08-20  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2335         line_from_reg_element_no, first_reg_element_no_inline,
2336         display_all_data, delete_data_content_windows,
2337         erase_data_content>: Now private.
2338
2339 2019-08-20  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2342         (tui_unhighlight_win, tui_highlight_win)
2343         (tui_win_info::make_window): Update.
2344         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2345
2346 2019-08-20  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2349         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2350         (MAX_PID_WIDTH): Move to tui-stack.c.
2351         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2352         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2353         (MAX_PID_WIDTH): Move from tui-data.h.
2354
2355 2019-08-20  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2358         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2359         (box_win): Update.
2360         (tui_gen_win_info::make_window): Rename from tui_make_window.
2361         (tui_win_info::make_window): New method.
2362         (tui_gen_win_info::make_visible): Update.
2363         * tui/tui-source.c (tui_source_window::set_contents): Update.
2364         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2365         (tui_data_window::display_registers_from): Update.
2366         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2367         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2368         Declare.
2369         <can_box>: Remove.
2370         <title>: Remove.
2371         (struct tui_win_info) <make_window>: Declare.
2372         <can_box>: Now virtual.
2373         <title>: New member.
2374         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2375         * tui/tui-command.c (tui_cmd_window::resize): Update.
2376
2377 2019-08-20  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2380         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2381         (tui_data_window::check_register_values): Update.
2382
2383 2019-08-20  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-regs.h (struct tui_data_window): Use
2386         DISABLE_COPY_AND_ASSIGN.
2387         <regs_content>: Change type, removing unique_ptr.
2388         <tui_data_window>: Add move constructor.
2389         * tui/tui-regs.c (tui_data_window::show_registers)
2390         (tui_data_window::show_register_group)
2391         (tui_data_window::display_registers_from)
2392         (tui_data_window::display_registers_from)
2393         (tui_data_window::first_data_item_displayed)
2394         (tui_data_window::delete_data_content_windows)
2395         (tui_data_window::rerender, tui_data_window::refresh_window)
2396         (tui_data_window::check_register_values): Update.
2397
2398 2019-08-20  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2401         show_register_group>: Declare.
2402         (tui_show_register_group): Don't declare.
2403         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2404         tui_show_registers.
2405         (tui_data_window::show_register_group): Rename from
2406         tui_show_register_group.
2407         (tui_data_window::check_register_values, tui_reg_command):
2408         Update.
2409         * tui/tui-layout.c (tui_set_layout): Update.
2410
2411 2019-08-20  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2414         Declare.
2415         (tui_check_register_values): Don't declare.
2416         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2417         from tui_check_register_values.
2418         * tui/tui-hooks.c (tui_register_changed): Update.
2419
2420 2019-08-20  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-regs.c (tui_reg_layout): Move later.
2423         (tui_show_registers): Don't enable TUI mode or change layout.
2424
2425 2019-08-20  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-regs.h (struct tui_data_item_window)
2428         <~tui_data_item_window>: Remove.
2429         <content>: Now a unique_xmalloc_ptr.
2430         * tui/tui-regs.c (tui_register_format): Return a
2431         unique_xmalloc_ptr.
2432         (tui_get_register): Update.
2433         (~tui_data_item_window): Remove.
2434         (tui_data_window::display_registers_from, tui_display_register):
2435         Update.
2436         * tui/tui-io.h (tui_expand_tabs): Update.
2437         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2438         Remove "col" parameter.
2439
2440 2019-08-20  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2443         field.
2444         * tui/tui-regs.c (~tui_data_item_window): Update.
2445
2446 2019-08-20  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2449         earlier.
2450
2451 2019-08-20  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2454
2455 2019-08-20  Tom Tromey  <tom@tromey.com>
2456
2457         * tui/tui-source.h (struct tui_source_window): Update.
2458         * tui/tui-regs.c (tui_show_registers): Update.
2459         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2460         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2461         (NO_REGS_STRING): Remove defines.
2462
2463 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2464
2465         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2466         unnecessary thread walk if remote doesn't support the packet.
2467
2468 2019-08-19  Tom Tromey  <tromey@adacore.com>
2469
2470         * python/py-value.c (value_has_field): Fix indentation.
2471
2472 2019-08-19  Tom Tromey  <tromey@adacore.com>
2473
2474         * printcmd.c (do_one_display, info_display_command): Update.
2475         * block.h (contained_in): Return bool.  Add allow_nested
2476         parameter.
2477         * block.c (contained_in): Return bool.  Add allow_nested
2478         parameter.
2479
2480 2019-08-19  Tom Tromey  <tom@tromey.com>
2481
2482         * configure: Rebuild.
2483         * configure.ac: Disallow the combination of -static-libstdc++ and
2484         source highlight.
2485         * source-cache.c (get_language_name): Handle rust.
2486         (source_cache::get_source_lines): Ignore highlighting exceptions.
2487
2488 2019-08-16  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2491         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2492         (struct tui_source_window_base) <make_visible, refresh_window,
2493         resize>: Remove methods.
2494         <execution_info>: Remove field.
2495         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2496         (tui_show_source_line, tui_source_window_base)
2497         (~tui_source_window_base): Update.
2498         (tui_source_window_base::resize)
2499         (tui_source_window_base::make_visible)
2500         (tui_source_window_base::refresh_window): Remove.
2501         (tui_source_window_base::update_exec_info): Update.
2502         * tui/tui-source.c (tui_source_window::set_contents): Update.
2503         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2504
2505 2019-08-16  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2508         deprecated_query_hook.
2509
2510 2019-08-16  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2513         (tui_update_source_windows_with_line): Update.
2514         * tui/tui-source.h (struct tui_source_window)
2515         <show_symtab_source>: Declare.
2516         (tui_show_symtab_source): Don't declare.
2517         * tui/tui-source.c (tui_show_symtab_source): Rename from
2518         tui_show_symtab_source.
2519
2520 2019-08-16  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-winsource.h (struct tui_source_window_base)
2523         <set_contents>: Declare.
2524         * tui/tui-winsource.c
2525         (tui_source_window_base::update_source_window_as_is): Update.
2526         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2527         Declare.
2528         (tui_set_source_content): Don't declare.
2529         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2530         tui_set_source_content.
2531         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2532         Declare.
2533         (tui_set_disassem_content): Don't declare.
2534         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2535         tui_set_disassem_content.
2536
2537 2019-08-16  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-winsource.h (struct tui_source_window_base)
2540         <update_breakpoint_info>: Declare.
2541         (tui_update_breakpoint_info): Don't declare.
2542         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2543         (tui_update_all_breakpoint_info): Update.
2544         (tui_source_window_base::update_breakpoint_info): Rename from
2545         tui_update_breakpoint_info.
2546         (tui_source_window_base::update_exec_info): Update.
2547
2548 2019-08-16  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-winsource.h (struct tui_source_window_base)
2551         <update_source_window>: Declare.
2552         (tui_update_source_window): Don't declare.
2553         * tui/tui-winsource.c
2554         (tui_source_window_base::update_source_window): Rename from
2555         tui_update_source_window.
2556         (tui_source_window_base::rerender): Update.
2557         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2558         * tui/tui-disasm.c (tui_show_disassem)
2559         (tui_show_disassem_and_update_source)
2560         (tui_disasm_window::maybe_update): Update.
2561
2562 2019-08-16  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-winsource.h (struct tui_source_window_base)
2565         <update_source_window_as_is>: Declare.
2566         (tui_update_source_window_as_is): Don't declare.
2567         * tui/tui-winsource.c (tui_update_source_window): Update
2568         (tui_source_window_base::update_source_window_as_is): Rename from
2569         tui_update_source_window_as_is.
2570         (tui_source_window_base::refill): Update.
2571         * tui/tui-source.c (tui_show_symtab_source): Update.
2572         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2573         Update.
2574
2575 2019-08-16  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-winsource.h (tui_update_source_window)
2578         (tui_update_source_window_as_is): Remove "noerror" parameter.
2579         * tui/tui-winsource.c (tui_update_source_window)
2580         (tui_update_source_window_as_is): Remove "noerror" parameter.
2581         (tui_update_source_windows_with_addr)
2582         (tui_update_source_windows_with_line)
2583         (tui_source_window_base::rerender)
2584         (tui_source_window_base::refill): Update.
2585         * tui/tui-source.h (tui_set_source_content)
2586         (tui_show_symtab_source): Remove "noerror" parameter.
2587         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2588         parameter.
2589         (tui_show_symtab_source): Likewise.
2590         (tui_source_window::maybe_update): Update.
2591         * tui/tui-disasm.c (tui_show_disassem)
2592         (tui_show_disassem_and_update_source)
2593         (tui_disasm_window::do_scroll_vertical)
2594         (tui_disasm_window::maybe_update): Update.
2595
2596 2019-08-16  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui.c (tui_is_window_visible): Update.
2599         * tui/tui-wingeneral.c (tui_make_window)
2600         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2601         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2602         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2603         (tui_set_win_height_command, parse_scrolling_args): Update.
2604         * tui/tui-source.c (tui_source_window::style_changed): Update.
2605         * tui/tui-regs.c (tui_show_registers)
2606         (tui_data_window::first_data_item_displayed)
2607         (tui_data_window::delete_data_content_windows)
2608         (tui_check_register_values, tui_reg_command): Update.
2609         * tui/tui-disasm.c (tui_show_disassem): Update.
2610         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2611         method.
2612         <is_visible>: Remove field.
2613         * tui/tui-data.c (tui_next_win, tui_prev_win)
2614         (tui_delete_invisible_windows): Update.
2615
2616 2019-08-16  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-winsource.h (struct tui_source_window_base)
2619         <m_has_locator>: Remove.
2620         * tui/tui-layout.c (show_source_disasm_command, show_data)
2621         (show_source_or_disasm_and_command): Update.
2622
2623 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2624
2625         * NEWS (Other MI changes): New subsection.
2626         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2627         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2628         * arch-utils.c (default_get_pc_address_flags): New function.
2629         * arch-utils.h (default_get_pc_address_flags): New declaration.
2630         * gdbarch.sh: Add get_pc_address_flags.
2631         * gdbarch.c: Regenerate.
2632         * gdbarch.h: Likewise.
2633         * stack.c (print_pc): New function.
2634         (print_frame_info) (print_frame): Call print_pc.
2635
2636 2019-08-16  Tom de Vries  <tdevries@suse.de>
2637
2638         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2639         print_objfile_section_info.
2640
2641 2019-08-15  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2644         calling update_cmdwin_start_line.
2645         * tui/tui-winsource.h (struct tui_source_window_base)
2646         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2647         <rerender>: Declare.
2648         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2649         Call rerender.
2650         (tui_source_window_base::set_new_height): Remove.
2651         (tui_source_window_base::rerender): Rename from
2652         do_make_visible_with_new_height.
2653         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2654         resize method.
2655         (tui_win_info::make_invisible_and_set_new_height)
2656         (tui_win_info::make_visible_with_new_height): Remove.
2657         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2658         Declare.
2659         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2660         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2661         do_make_visible_with_new_height>: Don't declare.
2662         <rerender>: Declare.
2663         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2664         set_new_height.
2665         (tui_data_window::do_make_visible_with_new_height): Remove.
2666         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2667         call tui_show_locator_content.
2668         (tui_gen_win_info::resize): Call rerender.
2669         (show_source_or_disasm_and_command): Don't call
2670         tui_show_locator_content.
2671         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2672         method.
2673         (struct tui_win_info) <rerender>: Declare.
2674         <set_new_height, make_invisible_and_set_new_height,
2675         make_visible_with_new_height>: Don't declare.
2676         * tui/tui-data.c (tui_win_list::rerender): New method.
2677         * tui/tui-command.h (struct tui_cmd_window)
2678         <do_make_visible_with_new_height>: Don't declare.
2679         * tui/tui-command.c
2680         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2681
2682 2019-08-15  Tom Tromey  <tromey@adacore.com>
2683
2684         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2685         * ada-lang.c (ada_enum_name): Likewise.
2686
2687 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2688
2689         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2690         leading underscore.
2691         (GdbOutputErrorFile): Likewise.
2692         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2693         accordingly.
2694         (execute_unwinders): Rename to have a leading underscore.
2695         (auto_load_packages): Likewise.
2696         (global scope): Adjust call to auto_load_packages accordingly.
2697         (GdbSetPythonDirectory): Likewise.
2698         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2699         instead of execute_unwinders.
2700
2701 2019-08-15  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2704         (show_data): Don't change window visibility.
2705         (tui_gen_win_info::resize): Remove special case for command
2706         window.  Use wresize, when available.
2707         (show_source_or_disasm_and_command): Don't change window
2708         visibility.
2709         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2710         <make_visible>: New method.
2711         * tui/tui-command.c (tui_cmd_window::resize): New method.
2712
2713 2019-08-15  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2716         (struct tui_source_windows): New.
2717         * tui/tui-winsource.c (tui_display_main): Update.
2718         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2719         (new_height_ok, parse_scrolling_args): Update.
2720         * tui/tui-layout.c (show_layout, show_data): Update.
2721         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2722         (tui_add_to_source_windows): Don't declare.
2723         * tui/tui-data.c (source_windows, tui_source_windows)
2724         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2725
2726 2019-08-15  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2729         Rename from reset.
2730         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2731         * tui/tui-layout.c (show_source_disasm_command, show_data):
2732         Update.
2733         (tui_gen_win_info::resize): Rename.
2734         (show_source_or_disasm_and_command): Update.
2735         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2736         reset.
2737
2738 2019-08-15  Tom Tromey  <tom@tromey.com>
2739
2740         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2741         * tui/tui-interp.c (tui_interp::init): Don't call
2742         tui_initialize_static_data.
2743         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2744
2745 2019-08-15  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2748         examine tui_win_list.
2749
2750 2019-08-15  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2753         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2754         tui_clear_source_content.
2755         (tui_clear_source_content): Remove.
2756         (tui_source_window_base::do_erase_source_content): Hoist call to
2757         content.clear().
2758         * tui/tui-stack.c (tui_show_frame_info): Don't call
2759         tui_clear_source_content.
2760
2761 2019-08-15  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-winsource.h (struct tui_source_window_base)
2764         <do_erase_source_content>: New method.
2765         <erase_source_content>: New method.
2766         (tui_erase_source_content): Don't declare.
2767         * tui/tui-winsource.c (tui_clear_source_content): Update.
2768         (tui_source_window_base::do_erase_source_content): Rename from
2769         tui_erase_source_content.
2770         (tui_source_window_base::show_source_content): Update.
2771         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2772         * tui/tui-source.h (struct tui_source_window)
2773         <erase_source_content>: New method.
2774         * tui/tui-disasm.h (struct tui_disasm_window)
2775         <erase_source_content>: New method.
2776
2777 2019-08-15  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2780         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2781         constructor.
2782         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2783         * tui/tui-source.c (tui_set_source_content): Update.
2784         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2785
2786 2019-08-15  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2789         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2790         tui-source.c.
2791         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2792         Declare.
2793         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2794         method.
2795         (tui_source_window::maybe_update): Update.
2796
2797 2019-08-15  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2800         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2801         tui-disasm.c.
2802         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2803         Declare.
2804         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2805         method.
2806         (tui_disasm_window::maybe_update): Update.
2807
2808 2019-08-15  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-winsource.h (struct tui_source_window_base)
2811         <maybe_update>: Declare.
2812         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2813         method.
2814         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2815         Declare.
2816         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2817         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2818         Declare.
2819         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2820
2821 2019-08-15  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2824
2825 2019-08-15  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-wingeneral.c: Include tui-stack.h.
2828         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2829         (struct tui_locator_window): Move from tui-data.h.
2830         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2831         (tui_initialize_static_data): Move from tui-data.c.
2832         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2833         (struct tui_locator_window): Move to tui-stack.c.
2834         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2835         (tui_initialize_static_data): Move to tui-stack.c.
2836
2837 2019-08-15  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-layout.c (show_source_disasm_command)
2840         (show_source_or_disasm_and_command): Use make_visible method, not
2841         tui_make_window.
2842         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2843         Remove.
2844
2845 2019-08-15  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-wingeneral.h (tui_make_window): Update.
2848         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2849         parameter.
2850         (tui_gen_win_info::make_visible): Update.
2851         * tui/tui-regs.c (tui_data_window::display_registers_from):
2852         Update.
2853         * tui/tui-layout.c (show_source_disasm_command)
2854         (show_source_or_disasm_and_command): Update.
2855         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2856         (enum tui_box): Remove.
2857         (struct tui_win_info) <can_box>: New method.
2858         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2859         method.
2860
2861 2019-08-15  Tom de Vries  <tdevries@suse.de>
2862
2863         * linux-nat-trad.c: Include gdbarch.h.
2864
2865 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2866
2867         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2868         register sizes.
2869
2870 2019-08-14  Tom Tromey  <tromey@adacore.com>
2871
2872         * darwin-nat.c: Include gdbarch.h.
2873         * darwin-nat-info.c: Include gdbarch.h.
2874
2875 2019-08-13  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2878         Remove.
2879         * tui/tui-data.c (tui_initialize_static_data): Update.
2880
2881 2019-08-13  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-winsource.h (struct tui_exec_info_window)
2884         <~tui_exec_info_window, maybe_allocate_content, get_content,
2885         m_content>: Remove.
2886         (struct tui_source_window_base) <set_exec_info_content,
2887         show_exec_info_content>: Don't declare.
2888         * tui/tui-winsource.c
2889         (tui_exec_info_window::maybe_allocate_content): Remove.
2890         (tui_source_window_base::update_exec_info): Rename from
2891         set_exec_info_content.
2892         (tui_source_window_base::show_exec_info_content)
2893         (tui_source_window_base::update_exec_info): Remove.
2894
2895 2019-08-13  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2898         declare.
2899         * tui/tui-winsource.c (tui_update_source_window_as_is)
2900         (tui_update_source_windows_with_addr, tui_erase_source_content):
2901         Update.
2902         (tui_clear_exec_info_content): Remove.
2903
2904 2019-08-13  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2907         declare.
2908         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2909         call tui_erase_exec_info_content.
2910         (tui_clear_exec_info_content): Rename from
2911         tui_erase_exec_info_content.
2912         (tui_clear_exec_info_content): Delete.
2913
2914 2019-08-13  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-winsource.h (struct tui_source_window_base)
2917         <show_exec_info_content>: Declare.
2918         (tui_show_exec_info_content): Don't declare.
2919         * tui/tui-winsource.c
2920         (tui_source_window_base::show_exec_info_content): Rename from
2921         tui_show_exec_info_content.
2922         (tui_source_window_base::update_exec_info): Update.
2923
2924 2019-08-13  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2927         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2928         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2929         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2930         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2931         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2932         ... here.
2933
2934 2019-08-13  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-winsource.h (struct tui_source_window_base)
2937         <update_exec_info>: Declare.
2938         (tui_update_exec_info): Don't declare.
2939         * tui/tui-winsource.c (tui_update_source_window_as_is)
2940         (tui_source_window_base::refresh_all)
2941         (tui_update_all_breakpoint_info): Update.
2942         (tui_source_window_base::update_exec_info): Rename from
2943         tui_update_exec_info.
2944         * tui/tui-stack.c (tui_show_frame_info): Update.
2945
2946 2019-08-13  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-winsource.h (struct tui_source_window_base)
2949         <set_exec_info_content>: Declare.
2950         (tui_set_exec_info_content): Don't declare.
2951         * tui/tui-winsource.c
2952         (tui_source_window_base::set_exec_info_content): Rename from
2953         tui_set_exec_info_content.
2954         (tui_update_exec_info): Update.
2955
2956 2019-08-13  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-winsource.h (struct tui_source_window_base)
2959         <show_source_content>: Declare.
2960         (tui_show_source_content): Don't declare.
2961         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2962         (tui_source_window_base::show_source_content): Rename from
2963         tui_show_source_content.
2964         (tui_source_window_base::refresh_all): Update.
2965         * tui/tui-layout.c (show_source_disasm_command)
2966         (show_source_or_disasm_and_command): Update.
2967
2968 2019-08-13  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-winsource.c (tui_erase_source_content)
2971         (tui_show_source_content, tui_source_window_base::refresh_all):
2972         Update.
2973         * tui/tui-wingeneral.h
2974         (tui_check_and_display_highlight_if_needed): Don't declare.
2975         * tui/tui-wingeneral.c
2976         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2977         check_and_display_highlight_if_needed.
2978         * tui/tui-win.c (tui_rehighlight_all)
2979         (tui_win_info::make_visible_with_new_height): Update.
2980         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2981         (tui_data_window::erase_data_content)
2982         (tui_data_window::display_all_data): Update.
2983         * tui/tui-data.h (struct tui_win_info)
2984         <check_and_display_highlight_if_needed>: Declare.
2985
2986 2019-08-13  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-win.c (tui_resize_all): Call
2989         tui_delete_invisible_windows.
2990         * tui/tui-layout.c (show_layout): Call
2991         tui_delete_invisible_windows.
2992         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2993         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2994
2995 2019-08-13  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2998         tui_add_win_to_layout.
2999
3000 2019-08-13  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3003         * tui/tui-layout.c (tui_default_win_height): Now static.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3008         single switch.
3009         (show_source_disasm_command, show_source_or_disasm_and_command):
3010         Don't check current layout.
3011
3012 2019-08-13  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-wingeneral.c (make_all_visible): Remove.
3015         (tui_make_all_invisible): Simplify.
3016         * tui/tui-layout.c (tui_make_all_invisible): Move from
3017         tui-wingeneral.c; simplify.
3018         (show_layout): Hoist call to tui_make_all_invisible.
3019         (show_data): Don't call tui_make_all_invisible.
3020
3021 2019-08-13  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3024         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3025
3026 2019-08-13  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3029         tui-data.c.
3030         (show_source_disasm_command, show_data)
3031         (show_source_or_disasm_and_command): Don't use
3032         tui_set_current_layout_to.
3033         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3034         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3035         tui-layout.c.
3036         (tui_set_current_layout_to): Remove.
3037
3038 2019-08-13  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-layout.c (tui_set_layout): Update.
3041         * tui/tui-data.h (struct tui_layout_def): Remove.
3042         (tui_layout_def): Don't declare.
3043         * tui/tui-data.c (layout_def): Remove.
3044         (tui_layout_def): Remove.
3045
3046 2019-08-13  Tom Tromey  <tom@tromey.com>
3047
3048         * tui/tui-winsource.h (struct tui_source_window_base)
3049         <clear_detail>: No longer "override".
3050         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3051         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3052         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3053         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3054         Remove.
3055         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3056
3057 2019-08-13  Tom Tromey  <tromey@adacore.com>
3058
3059         * tracepoint.c: Don't include readline.h or history.h.
3060
3061 2019-08-12  Tom Tromey  <tom@tromey.com>
3062
3063         * configure: Rebuild.
3064         * configure.ac: Check for readline 7.
3065         * NEWS: Mention readline 7 requirement.
3066         * README: Update.
3067
3068 2019-08-12  Tom Tromey  <tom@tromey.com>
3069
3070         * mingw-hdep.c (gdb_select): Remove readline hack.
3071
3072 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3073
3074         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3075         when the function fails.
3076
3077 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3078
3079         * s390-tdep.c (s390_type_align): New function.
3080         (s390_gdbarch_init): Set it as type_align gdbarch method.
3081
3082 2019-08-09  Tom de Vries  <tdevries@suse.de>
3083
3084         PR gdb/24591
3085         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3086         pc_low with relocation offset.
3087
3088 2019-08-07  Tom Tromey  <tromey@adacore.com>
3089
3090         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3091         (print_frame_args): Update.
3092         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3093         Update.
3094         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3095         * frame.h (struct frame_arg): Add initializers.
3096         <error>: Now a unique_xmalloc_ptr.
3097
3098 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3099
3100         * NEWS: Expand the Pointer Authentication entry.
3101         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3102         (aarch64_frame_unmask_lr): ... to this.
3103         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3104         Call aarch64_frame_unmask_lr.
3105         * frame.c (struct frame_info): Add "masked" variable.
3106         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3107         (fprint_frame): Check for masked pc.
3108         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3109         declarations.
3110         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3111         * stack.c (print_frame): Check for masked pc.
3112
3113 2019-08-06  Tom Tromey  <tom@tromey.com>
3114
3115         * stabsread.c (patch_block_stabs, read_one_struct_field)
3116         (read_enum_type): Use obstack_strndup.
3117         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3118         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3119         * dwarf2read.c (guess_full_die_structure_name)
3120         (anonymous_struct_prefix): Use obstack_strndup.
3121         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3122         * c-exp.y (yylex): Use obstack_strndup.
3123         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3124         (write_var_or_type): Use obstack_strndup.
3125
3126 2019-08-06  Tom Tromey  <tom@tromey.com>
3127
3128         * symfile.c (reread_symbols): Use obstack_strdup.
3129         * stabsread.c (read_type): Use obstack_strdup.
3130         * gdb_obstack.h (obstack_strdup): New overload.
3131         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3132         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3133         (dwarf2_canonicalize_name): Use obstack_strdup.
3134         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3135         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3136         Use obstack_strdup.
3137
3138 2019-08-06  Tom Tromey  <tom@tromey.com>
3139
3140         * gdb_obstack.h (obstack_strdup): Define.
3141         * gdb_obstack.c (obstack_strdup): Don't define.
3142
3143 2019-08-06  Tom Tromey  <tom@tromey.com>
3144
3145         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3146         obstack_strdup.
3147         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3148         obstack_strdup.
3149         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3150         * stabsread.c (common_block_start): Use obstack_strdup.
3151         * objfiles.c (set_objfile_main_name, objfile): Use
3152         obstack_strdup.
3153         * namespace.c (add_using_directive): Use obstack_strdup.
3154         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3155         * jit.c (finalize_symtab): Use obstack_strdup.
3156         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3157         (guess_partial_die_structure_name, partial_die_info::fixup)
3158         (dwarf2_name): Use obstack_strdup.
3159         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3160         obstack_strdup.
3161         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3162         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3163         obstack_strdup.
3164         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3165
3166 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3167
3168         * unittests/help-doc-selftests.c: New file.
3169         * Makefile.in: Add the new file.
3170
3171 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3172
3173         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3174         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3175         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3176         the trailing '.' is not output, and the first character is uppercased.
3177         (print_help_for_command): Update call to print_doc_line.
3178         (print_doc_of_command): Likewise.
3179         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3180         * cli/cli-option.c (append_indented_doc): Do not append newline.
3181         (build_help_option): Append newline after first appended_indented_doc
3182         only if a second call is done.
3183         (build_help): Append 2 new lines before each option, except the first
3184         one.
3185         * compile/compile.c (_initialize_compile): Add new lines after
3186         %OPTIONS%, when not at the end of the help.
3187         Change help doc or code
3188         producing the help doc to respect the invariants.
3189         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3190         Also removed the new line after 'Options:', as all other commands
3191         do not put an empty line between 'Options:' and the first option.
3192         * printcmd.c (_initialize_printcmd): Likewise.
3193         * stack.c (_initialize_stack): Likewise.
3194         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3195         incorrectly telling COMMAND is optional.
3196         * ada-lang.c (_initialize_ada_language): Change help doc or code
3197         producing the help doc to respect the invariants.
3198         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3199         * breakpoint.c (_initialize_breakpoint): Likewise.
3200         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3201         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3202         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3203         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3204         _initialize_cli_style): Likewise.
3205         * corelow.c (core_target_info): Likewise.
3206         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3207         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3208         * filesystem.c (_initialize_filesystem): Likewise.
3209         * frame.c (_initialize_frame): Likewise.
3210         * gnu-nat.c (add_task_commands): Likewise.
3211         * infcall.c (_initialize_infcall): Likewise.
3212         * infcmd.c (_initialize_infcmd): Likewise.
3213         * interps.c (_initialize_interpreter): Likewise.
3214         * language.c (_initialize_language): Likewise.
3215         * linux-fork.c (_initialize_linux_fork): Likewise.
3216         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3217         * maint.c (_initialize_maint_cmds): Likewise.
3218         * memattr.c (_initialize_mem): Likewise.
3219         * printcmd.c (_initialize_printcmd): Likewise.
3220         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3221         _RegEx): Likewise.
3222         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3223         * record-btrace.c (_initialize_record_btrace): Likewise.
3224         * record-full.c (_initialize_record_full): Likewise.
3225         * record.c (_initialize_record): Likewise.
3226         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3227         * regcache.c (_initialize_regcache): Likewise.
3228         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3229         _initialize_remote): Likewise.
3230         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3231         * serial.c (_initialize_serial): Likewise.
3232         * skip.c (_initialize_step_skip): Likewise.
3233         * source.c (_initialize_source): Likewise.
3234         * stack.c (_initialize_stack): Likewise.
3235         * symfile.c (_initialize_symfile): Likewise.
3236         * symtab.c (_initialize_symtab): Likewise.
3237         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3238         * top.c (init_main): Likewise.
3239         * tracefile-tfile.c (tfile_target_info): Likewise.
3240         * tracepoint.c (_initialize_tracepoint): Likewise.
3241         * tui/tui-win.c (_initialize_tui_win): Likewise.
3242         * utils.c (add_internal_problem_command): Likewise.
3243         * valprint.c (value_print_option_defs): Likewise.
3244
3245 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3246
3247         PR build/24886
3248         * configure.ac: Drop enable-libmcheck support.
3249         * configure, config.in: Rebuild.
3250         * libmcheck.m4: Remove.
3251         * acinclude.m4: Don't include it.
3252         * Makefile.in: Don't distribute it.
3253         * top.c (print_gdb_configuration): Don't mention it.
3254
3255 2019-08-06  Tom Tromey  <tom@tromey.com>
3256
3257         * utils.c (set_output_style): Sometimes pass stream to
3258         emit_style_escape.
3259         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3260         * record-btrace.c (btrace_insn_history): Update.
3261         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3262         method.
3263         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3264         Update initializers.
3265         <m_uiout>: New field.
3266         <m_di>: Move lower.
3267         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3268         Remove "uiout" parameter.
3269         (dump_insns): Update.
3270         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3271         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3272
3273 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3274
3275         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3276         (error_in_psymtab_expansion): Likewise.
3277         (lookup_symbol_via_quick_fns): Likewise.
3278         (basic_lookup_transparent_type_quick): Likewise.
3279         (basic_lookup_transparent_type_1): Likewise.
3280
3281 2019-08-06  Tom Tromey  <tromey@adacore.com>
3282
3283         * source.c (last_source_error): Now bool.
3284         (print_source_lines_base): Make "noprint" bool.  Only open
3285         source file when last_source_visited changes.
3286
3287 2019-08-06  Tom Tromey  <tromey@adacore.com>
3288
3289         * annotate.c (annotate_source_line): Use g_source_cache.
3290         * source-cache.c (source_cache::get_plain_source_lines): Change
3291         parameters.  Populate m_offset_cache.
3292         (source_cache::ensure): New method.
3293         (source_cache::get_line_charpos): New method.
3294         (extract_lines): Move lower.  Change parameters.
3295         (source_cache::get_source_lines): Move lower.
3296         * source-cache.h (class source_cache): Update comment.
3297         <get_line_charpos>: New method.
3298         <get_source_lines>: Update comment.
3299         <clear>: Clear m_offset_cache.
3300         <get_plain_source_lines>: Change parameters.
3301         <ensure>: New method
3302         <m_offset_cache>: New member.
3303         * source.c (forget_cached_source_info_for_objfile): Update.
3304         (info_source_command): Use g_source_cache.
3305         (find_source_lines, open_source_file_with_line_charpos): Remove.
3306         (print_source_lines_base, search_command_helper): Use g_source_cache.
3307         * source.h (open_source_file_with_line_charpos): Don't declare.
3308         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3309         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3310         Use g_source_cache.
3311
3312 2019-08-06  Tom Tromey  <tromey@adacore.com>
3313
3314         * source-cache.c (source_cache::get_plain_source_lines):
3315         Remove "first_line" and "last_line" parameters.
3316         (source_cache::get_source_lines): Cache plain text.
3317         * source-cache.h (class source_cache)
3318         <get_plain_source_lines>: Update.
3319
3320 2019-08-06  Tom Tromey  <tromey@adacore.com>
3321
3322         * source-cache.c (extract_lines): No longer a method.
3323         Changed type of parameter.  Include final newline.
3324         (selftests::extract_lines_test): New function.
3325         (_initialize_source_cache): Likewise.
3326         * source-cache.h (class source_cache)
3327         <extract_lines>: Don't declare.
3328
3329 2019-08-06  Tom Tromey  <tromey@adacore.com>
3330
3331         * breakpoint.c (init_breakpoint_sal): Update.
3332         (breakpoint): Update.
3333         * breakpoint.h (struct breakpoint) <filter>: Now a
3334         unique_xmalloc_ptr.
3335
3336 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3337
3338         * NEWS: Mention dictionary access on blocks.
3339         * python/py-block.c (blpy_getitem): New function.
3340         (block_object_as_mapping): New struct.
3341         (block_object_type): Use new struct for tp_as_mapping field.
3342
3343 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3344
3345         * objfiles.h (objfile): Add a comment describing partial symbols.
3346
3347 2019-08-05  Tom Tromey  <tromey@adacore.com>
3348
3349         * compile/compile.c (_initialize_compile): Use _(), not N_().
3350         * thread.c (_initialize_thread): Use _(), not N_().
3351         * stack.c (_initialize_stack): Use _(), not N_().
3352         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3353
3354 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3355
3356         * dwarf2read.c (struct dw2_symtab_iterator):
3357         <want_specific_block>: Remove.
3358         <block_index>: Change type to gdb::optional.
3359         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3360         change type of BLOCK_INDEX parameter to gdb::optional.
3361         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3362         (dw2_lookup_symbol): Don't pass argument for
3363         WANT_SPECIFIC_BLOCK.
3364         (dw2_expand_symtabs_for_function): Don't pass argument for
3365         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3366         (class dw2_debug_names_iterator)
3367         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3368         parameter, change BLOCK_INDEX type to gdb::optional.
3369         <m_want_specific_block>: Remove.
3370         <m_block_index>: Change type to gdb::optional.
3371         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3372         gdb::optional.  Re-write in function of gdb::optional.
3373         (dw2_debug_names_lookup_symbol): Don't pass argument for
3374         WANT_SPECIFIC_BLOCK.
3375         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3376         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3377         BLOCK_INDEX.
3378
3379 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3380
3381         * NEWS: Mention changes to "info sources" command.
3382
3383 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3384
3385         * symtab.c (filename_partial_match_opts): New struct type.
3386         (struct output_source_filename_data): New members
3387         regexp, c_regexp, partial_match.
3388         (output_source_filename): Use new members to decide to print file.
3389         (info_sources_option_defs): New variable.
3390         (make_info_sources_options_def_group, print_info_sources_header,
3391         info_sources_command_completer):
3392         New functions.
3393         (info_sources_command): Read new optional arguments.
3394         (_initialize_symtab): Update info sources help.
3395
3396 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3397
3398         * ada-lang.c (exception_support_info_v0): Renamed from...
3399         (default_exception_support_info): ... this.  Create new
3400         definition for v1.
3401         (ada_has_this_exception_support): Look up catch_handlers_sym.
3402         (ada_exception_support_info_sniffer): Try v0 after default.
3403
3404 2019-08-01  Tom Tromey  <tromey@adacore.com>
3405
3406         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3407         gdbarch.h.
3408
3409 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3410
3411         * s12z-tdep.c: Fix include path for s12z-opc.h.
3412
3413 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3414
3415         * NEWS: Require GNU make 3.82.
3416
3417 2019-07-16  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3420         declare.
3421
3422 2019-07-30  Tom Tromey  <tromey@adacore.com>
3423
3424         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3425
3426 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3427
3428         * printcmd.c (print_address_symbolic): Print negative offsets.
3429         (build_address_symbolic): Force signed arithmetic when computing
3430         offset.
3431
3432 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3433
3434         PR/24474: Add a function to lookup static variables.
3435         * NEWS: Mention this new function.
3436         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3437         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3438         * python/python.c (python_GdbMethods): Add new function.
3439
3440 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3441
3442         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3443         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3444         (objfpy_lookup_static_symbol): New function.
3445         (objfile_object_methods): Add new functions.
3446
3447 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3448
3449         * NEWS: Mention 'set|show print frame-info'.  Mention new
3450         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3451         backtrace argument.  Mention that python frame filtering code
3452         is now consistent with what 'backtrace' command prints.
3453
3454 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3455
3456         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3457         comments.
3458         (print_frame_info_auto, print_frame_info_source_line,
3459         print_frame_info_location, print_frame_info_source_and_location,
3460         print_frame_info_location_and_address, print_frame_info_short_location):
3461         New declarations.
3462         (struct frame_print_options): New member print_frame_info.
3463         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3464         * stack.h (get_user_print_what_frame_info): New declaration.
3465         (frame_show_address): New declaration.
3466         * stack.c (print_frame_arguments_choices): New value 'presence'.
3467         (print_frame_info_auto, print_frame_info_source_line,
3468         print_frame_info_location, print_frame_info_source_and_location,
3469         print_frame_info_location_and_address, print_frame_info_short_location,
3470         print_frame_info_choices, print_frame_info_print_what): New definitions.
3471         (print_frame_args): Only print dots for args if print frame-arguments
3472         is 'presence'.
3473         (frame_print_option_defs): New element for "frame-info".
3474         (get_user_print_what_frame_info): New function.
3475         (frame_show_address): Make non static.  Move comment to stack.h.
3476         (print_frame_info_to_print_what): New function.
3477         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3478         to decide what to print.
3479         (backtrace_command_1): Handle the new print_frame_arguments_presence
3480         value.
3481         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3482         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3483         (py_print_frame): In non-mi mode, use LOCATION as default for
3484         print_what, similarly to frame information printed directly by
3485         backtrace command. Handle frame-info user option in non MI mode.
3486
3487 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3488
3489         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3490         Add case for debugging 32-bit target on 64-bit host.  Revise
3491         comment.
3492
3493 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3494
3495         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3496         instead of find_function_entry_range_from_pc.
3497
3498 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3499
3500         * stack.c (find_frame_funname): Remove code which preferred
3501         minsym over symtab sym in "certain pathological cases".
3502
3503         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3504         parameter.  Change type of "do_demangle" to bool.
3505         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3506         Pass suitable "prefer_sym_over_minsym" flag to
3507         build_address_symbolic().  Don't output "+" for negative offsets.
3508         * printcmd.c (print_address_symbolic): Update invocation of
3509         build_address_symbolic to include a "prefer_sym_over_minsym"
3510         flag.
3511         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3512         Restrict cases in which use of minimal symbol is preferred to that
3513         of a found symbol.  Update comments.
3514
3515         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3516         for entry pc when entry pc is out of range for that FDE.
3517
3518 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3519
3520         PR gdb/24839:
3521         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3522         type.
3523
3524 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3525
3526         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3527         this function's Python signature.
3528
3529
3530 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3531
3532         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3533         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3534         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3535         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3536         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3537
3538
3539 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3540
3541         * h8300-tdep.c (h8300_register_name_common): New.
3542         h8300_register_name): Use h8300_register_name_common.
3543         (h8300s_register_name): Likewise.
3544         (h8300sx_register_name): Likewise.
3545         (h8300h_register_nam): New.
3546         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3547
3548
3549 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3550
3551         * arm-tdep.c (arm_skip_cmse_entry): New function.
3552         (arm_is_sgstubs_section): New function.
3553         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3554
3555 2019-07-22  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3558         Don't self-assign.
3559
3560 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3561
3562         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3563         type_print.
3564
3565 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3568         so that GDB doesn't match any msymbols when searching in the
3569         TYPES_DOMAIN.
3570         (print_symbol_info): Print using typedef_print or type_print based
3571         on the type of the symbol.  Add updated FIXME comment moved from...
3572         (_initialize_symtab): ... move and update FIXME comment to above.
3573
3574 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * NEWS: Mention adding -q option to "info types".
3577         * symtab.c (struct info_types_options): New struct.
3578         (info_types_options_defs): New variable.
3579         (make_info_types_options_def_group): New function.
3580         (info_types_command): Use gdb::option framework to parse options.
3581         (info_types_command_completer): New function.
3582         (_initialize_symtab): Extend the help text on "info types" and
3583         register command completer.
3584
3585 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3586
3587         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3588         (lookup_symbol_in_objfile): Change int to block_enum and add a
3589         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3590
3591 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3592
3593         * MAINTAINERS (Write After Approval): Add self.
3594
3595 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3596
3597         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3598         instruction to the dummy code region.
3599
3600 2019-07-19  Tom Tromey  <tromey@adacore.com>
3601
3602         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3603         (ARGSUSED, PARAMS, __func__): Remove rules.
3604
3605 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3606
3607         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3608         * features/arm/arm-with-iwmmxt.c: Remove.
3609         * features/arm/arm-with-iwmmxt.xml: Remove.
3610         * features/arm/arm-with-m-fpa-layout.c: Remove.
3611         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3612         * features/arm/arm-with-m-vfp-d16.c: Remove.
3613         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3614         * features/arm/arm-with-m.c: Remove.
3615         * features/arm/arm-with-m.xml: Remove.
3616         * features/arm/arm-with-neon.c: Remove.
3617         * features/arm/arm-with-neon.xml: Remove.
3618         * features/arm/arm-with-vfpv2.c: Remove.
3619         * features/arm/arm-with-vfpv2.xml: Remove.
3620         * features/arm/arm-with-vfpv3.c: Remove.
3621         * features/arm/arm-with-vfpv3.xml: Remove.
3622
3623 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3624
3625         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3626
3627 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3628
3629         * arch/aarch32.c (aarch32_create_target_description): Create
3630         target descriptions using features.
3631         * arch/arm.c (arm_create_target_description)
3632         (arm_create_mprofile_target_description): Likewise.
3633         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3634
3635 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3636
3637         * Makefile.in: Add new files.
3638         * aarch32-tdep.c: New file.
3639         * aarch32-tdep.h: New file.
3640         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3641         Call aarch32_read_description.
3642         * arch/aarch32.c: New file.
3643         * arch/aarch32.h: New file.
3644         * arch/arm.c (arm_create_target_description)
3645         (arm_create_mprofile_target_description): New function.
3646         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3647         (arm_create_target_description)
3648         (arm_create_mprofile_target_description): New declaration.
3649         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3650         read_description functions.
3651         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3652         Likewise.
3653         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3654         * arm-tdep.c (tdesc_arm_list): New variable.
3655         (arm_register_g_packet_guesses): Call create description functions.
3656         (arm_read_description) (arm_read_mprofile_description): New
3657         function.
3658         * arm-tdep.h (arm_read_description)
3659         (arm_read_mprofile_description): Add declaration.
3660         * configure.tgt: Add new files.
3661
3662 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3663
3664         * top.c (new_ui_command): Open specified terminal just once.
3665
3666 2019-07-18  Tom Tromey  <tromey@adacore.com>
3667
3668         * symtab.c (main_name): Constify return type.
3669         * symfile.c (set_initial_language): Update.
3670         * symtab.h (main_name): Constify return type.
3671
3672 2019-07-17  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-winsource.c (tui_update_source_window)
3675         (tui_update_source_window_as_is)
3676         (tui_update_source_windows_with_line): Remove return.
3677         * tui/tui-disasm.c (tui_show_disassem)
3678         (tui_show_disassem_and_update_source): Remove return.
3679         * tui/tui.c (tui_reset): Remove return.
3680         * tui/tui-wingeneral.c
3681         (tui_check_and_display_highlight_if_needed): Remove return.
3682
3683 2019-07-17  Tom Tromey  <tom@tromey.com>
3684
3685         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3686
3687 2019-07-17  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-winsource.h (struct tui_exec_info_window)
3690         (struct tui_source_window_base): Move from tui-data.h.
3691         * tui/tui-winsource.c: Move many method definitions from
3692         elsewhere.  Remove "structuring" comments.
3693         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3694         (tui_source_window_base::refresh_window): Move to
3695         tui-winsource.c.
3696         * tui/tui-win.c (tui_source_window_base::refresh_all)
3697         (tui_source_window_base::update_tab_width)
3698         (tui_source_window_base::set_new_height)
3699         (tui_source_window_base::do_make_visible_with_new_height): Move to
3700         tui-winsource.c.
3701         * tui/tui-source.h: Update.
3702         * tui/tui-source.c (tui_source_window_base::reset): Move to
3703         tui-winsource.c.
3704         * tui/tui-disasm.h: Update.
3705         * tui/tui-data.h (struct tui_exec_info_window): Move to
3706         tui-winsource.h.
3707         (struct tui_source_window_base): Likewise.
3708         * tui/tui-data.c (tui_source_window_base::clear_detail)
3709         (tui_source_window_base, ~tui_source_window_base): Move to
3710         tui-winsource.c.
3711
3712 2019-07-17  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-win.c (tui_resize_all)
3715         (tui_source_window_base::update_tab_width)
3716         (tui_adjust_win_heights): Update.
3717         (tui_win_info::make_invisible_and_set_new_height): Rename from
3718         make_invisible_and_set_new_height.
3719         * tui/tui-data.h (struct tui_win_info)
3720         <make_invisible_and_set_new_height>: New method.
3721
3722 2019-07-17  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui.c: Update.
3725         * tui/tui-source.h (struct tui_source_window): Move from
3726         tui-data.h.
3727         * tui/tui-layout.c: Update.
3728         * tui/tui-disasm.c: Update.
3729         * tui/tui-data.h (struct tui_source_window): Move to
3730         tui-source.h.
3731
3732 2019-07-17  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3735         tui-data.h.
3736         * tui/tui-data.h (struct tui_disasm_window): Move to
3737         tui-disasm.h.
3738
3739 2019-07-17  Tom Tromey  <tom@tromey.com>
3740
3741         * tui/tui-regs.h (struct tui_data_item_window): Move from
3742         tui-data.h.
3743         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3744         * tui/tui-data.h (struct tui_data_item_window): Move to
3745         tui-regs.h.
3746         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3747
3748 2019-07-17  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui.c: Update.
3751         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3752         (tui_cmd_window::max_height): Move to tui-command.c.
3753         * tui/tui-layout.c: Update.
3754         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3755         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3756         tui-command.c.
3757         * tui/tui-command.h (struct tui_cmd_window): Move from
3758         tui-data.h.
3759         * tui/tui-command.c: Remove "structuring" comments.
3760         (tui_cmd_window::clear_detail)
3761         (tui_cmd_window::do_make_visible_with_new_height)
3762         (tui_cmd_window::max_height): Move from elsewhere.
3763
3764 2019-07-17  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3767         Now static.
3768         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3769         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3770
3771 2019-07-17  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui.c: Update.
3774         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3775         tui-regs.c.
3776         * tui/tui-windata.h: Remove file.
3777         * tui/tui-windata.c: Remove file.
3778         * tui/tui-win.c (tui_data_window::set_new_height)
3779         (tui_data_window::do_make_visible_with_new_height): Move to
3780         tui-regs.c.
3781         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3782         * tui/tui-regs.c: Remove "structuring" comments.
3783         (tui_data_window::first_data_item_displayed)
3784         (tui_data_window::delete_data_content_windows)
3785         (tui_data_window::erase_data_content)
3786         (tui_data_window::display_all_data)
3787         (tui_data_window::refresh_all)
3788         (tui_data_window::do_scroll_vertical)
3789         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3790         (tui_data_window::do_make_visible_with_new_height)
3791         (tui_data_window::refresh_window): Move from elsewhere.
3792         (_initialize_tui_regs): Move to end of file.
3793         * tui/tui-layout.c: Update.
3794         * tui/tui-hooks.c: Update.
3795         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3796         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3797         tui-regs.c.
3798         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3799
3800 2019-07-17  Tom Tromey  <tom@tromey.com>
3801
3802         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3803         seen.
3804
3805 2019-07-17  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-win.c (tui_source_window_base::set_new_height)
3808         (tui_source_window_base::do_make_visible_with_new_height): Use
3809         m_has_locator field directly.
3810         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3811         method.
3812         (struct tui_source_window_base) <has_locator>: Likewise.
3813
3814 2019-07-17  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3817         Don't declare.
3818         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3819         Remove.
3820         * tui/tui-win.c (tui_source_window_base::set_new_height)
3821         (tui_source_window_base::set_new_height)
3822         (make_invisible_and_set_new_height)
3823         (tui_source_window_base::do_make_visible_with_new_height)
3824         (tui_source_window_base::do_make_visible_with_new_height):
3825         Update.
3826         * tui/tui-layout.c (show_source_disasm_command, show_data)
3827         (show_source_or_disasm_and_command): Update.
3828         * tui/tui-layout.c (show_layout): Update.
3829
3830 2019-07-17  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-layout.c (make_data_window): Remove.
3833         (show_data): Unify creation and re-initialization cases.
3834
3835 2019-07-17  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-layout.c (make_source_window, make_disasm_window):
3838         Remove.
3839         (show_data): Unify creation and re-initialization cases.
3840
3841 2019-07-17  Tom Tromey  <tom@tromey.com>
3842
3843         * tui/tui-layout.c (make_command_window): Remove.
3844         (show_source_disasm_command, show_source_or_disasm_and_command):
3845         Unify creation and re-initialization cases.
3846
3847 2019-07-17  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3850         creation and re-initialization cases.
3851
3852 2019-07-17  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-regs.c (tui_get_register): Return void.
3855
3856 2019-07-17  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3859         Simplify.
3860
3861 2019-07-17  Tom Tromey  <tom@tromey.com>
3862
3863         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3864         resetting.
3865
3866 2019-07-17  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3869         * tui/tui-regs.c (tui_reg_layout): New function.
3870         (tui_show_registers, tui_reg_command): Use it.
3871         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3872         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3873         parameters.
3874         (tui_layout_command): Remove.
3875
3876 2019-07-17  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui-layout.h (tui/tui-layout): Return void.
3879         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3880
3881 2019-07-17  Tom Tromey  <tom@tromey.com>
3882
3883         * tui/tui-layout.c (show_source_disasm_command, show_data):
3884         Update.
3885         (reset_locator): Remove.
3886         (show_source_or_disasm_and_command): Update.
3887
3888 2019-07-17  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-source.c (tui_source_window_base::reset): Remove
3891         win_type parameter.
3892         * tui/tui-layout.c (make_command_window, make_source_window)
3893         (make_disasm_window, make_data_window)
3894         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3895         (reset_locator, show_source_or_disasm_and_command): Update.
3896         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3897         win_type parameter.
3898         (struct tui_source_window_base) <reset>: Likewise.
3899
3900 2019-07-17  Tom Tromey  <tom@tromey.com>
3901
3902         * tui/tui-layout.c (show_source_disasm_command): Use
3903         reset_locator.
3904         (reset_locator): New function.
3905         (init_and_make_win): Remove.
3906         (show_source_or_disasm_and_command): Use reset_locator.
3907
3908 2019-07-17  Tom Tromey  <tom@tromey.com>
3909
3910         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3911         condition.
3912         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3913         Remove condition.
3914         * tui/tui-source.c (tui_source_window_base::reset): New method.
3915         * tui/tui-layout.c (make_command_window): Don't call
3916         init_and_make_win.
3917         (make_source_window, make_disasm_window): Don't call
3918         make_source_or_disasm_window.
3919         (make_data_window): Don't call init_and_make_win.  Change calling
3920         convention.
3921         (show_source_disasm_command, show_data): Simplify.
3922         (make_source_or_disasm_window): Remove.
3923         (show_source_or_disasm_and_command): Simplify.
3924         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3925         (struct tui_source_window_base) <reset>: Likewise.
3926         <execution_info>: Remove initializer.
3927         * tui/tui-data.c (tui_source_window_base): Initialize
3928         execution_info.
3929
3930 2019-07-17  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3933         variable.
3934
3935 2019-07-17  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui.c (tui_rl_other_window): Update.
3938         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3939         superclass method first.  Always iterate over regs_content.
3940         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3941         method.
3942         * tui/tui-win.c (tui_set_focus_command): Update.
3943
3944 2019-07-17  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-win.c (tui_set_focus_command): Rename from
3947         tui_set_focus.  Call tui_enable.
3948         (tui_set_focus_command): Remove.
3949
3950 2019-07-17  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3953         refresh_window.
3954         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3955         touchwin.
3956         (tui_data_window::refresh_window): Call refresh_window on data
3957         items.  Always call superclass refresh_window.
3958         (tui_win_info::refresh): Remove.
3959         (tui_source_window_base::refresh_window): Update.
3960         (tui_refresh_all): Update.
3961         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3962         refresh_window.
3963         (show_source_or_disasm_and_command): Likewise.
3964         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3965         (struct tui_source_window_base) <refresh>: Likewise.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-winsource.c (tui_clear_source_content)
3970         (tui_show_source_content): Update.
3971         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3972         whether content is empty.
3973         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3974         Remove.
3975
3976 2019-07-17  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3979         window's contents.
3980         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3981         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3982
3983 2019-07-17  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3986         (struct tui_data_item_window): Update.
3987
3988 2019-07-17  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3991         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3992         defines.
3993
3994 2019-07-17  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-winsource.h (tui_erase_source_content)
3997         (tui_clear_source_content): Remove "display_prompt" parameter.
3998         * tui/tui-winsource.c (tui_update_source_window_as_is)
3999         (tui_update_source_windows_with_addr): Update.
4000         (tui_clear_source_content): Remove "display_prompt" parameter.
4001         (tui_erase_source_content): Likewise.  Simplify.
4002         (tui_show_source_content): Update.
4003         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4004         * tui/tui-stack.c (tui_show_frame_info): Update.
4005         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4006         Remove defines.
4007
4008 2019-07-17  Tom Tromey  <tom@tromey.com>
4009
4010         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4011         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4012         parameter.
4013         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4014         parameter.
4015
4016 2019-07-17  Tom Tromey  <tom@tromey.com>
4017
4018         * tui/tui-winsource.c (tui_clear_source_content)
4019         (tui_show_source_content, tui_show_exec_info_content)
4020         (tui_clear_exec_info_content): Update.
4021         * tui/tui-stack.c (tui_show_locator_content): Update.
4022         (tui_show_frame_info): Update.
4023         * tui/tui-source.h (tui_source_window): Don't declare.
4024         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4025         from tui_source_is_displayed.
4026         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4027         Remove field.
4028         (struct tui_source_window_base) <content_in_use>: New field.  Now
4029         bool.
4030         (struct tui_source_window) <showing_source_p>: New method.
4031         (TUI_SRC_WIN): Change cast.
4032         * tui/tui-data.c (tui_initialize_static_data): Update.
4033
4034 2019-07-17  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4037         location_matches_p.
4038         * tui/tui-source.c (tui_source_window::location_matches_p): New
4039         method.
4040         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4041         method.
4042         * tui/tui-data.h (struct tui_source_window_base)
4043         <location_matches_p>: New method.
4044         (struct tui_source_window, struct tui_disasm_window)
4045         <location_matches_p>: Likewise.
4046
4047 2019-07-17  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-win.c (tui_set_win_height_command): Rename from
4050         tui_set_win_height.
4051         (tui_set_win_height_command): Remove.
4052
4053 2019-07-17  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-source.c (tui_source_window): New constructor.  Add
4056         observer.
4057         (~tui_source_window): New destructor.
4058         (tui_source_window::style_changed): New method.
4059         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4060         (tui_attach_detach_observers): Update.
4061         * tui/tui-data.h (struct tui_source_window): Make constructor not
4062         inline.  Add destructor.
4063         (struct tui_source_window) <style_changed>: New method.
4064         <m_observable>: New member.
4065
4066 2019-07-17  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4069         * tui/tui-win.c (tui_resize_all): Fix typo.
4070
4071 2019-07-17  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4074         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4075         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4076         * tui/tui-win.c (window_name_completer): Use foreach.
4077         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4078         (update_tab_width): Likewise.
4079         * tui/tui-layout.c (show_layout): Update.
4080         * tui/tui-data.h (class tui_window_iterator): New.
4081         (struct all_tui_windows): New.
4082         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4083
4084 2019-07-17  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4087         parameter.  Don't reference globals.
4088         (tui_reg_command): Update.
4089
4090 2019-07-17  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-regs.c (tui_show_registers): Simplify.
4093
4094 2019-07-17  Tom Tromey  <tom@tromey.com>
4095
4096         * tui/tui-regs.c (tui_show_registers): Update.
4097         (tui_show_register_group): Add win_info parameter.
4098
4099 2019-07-17  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4102         Rename from tui_display_reg_element_at_line.
4103         (tui_data_window::display_registers_from_line): Update.
4104         * tui/tui-data.h (struct tui_data_window)
4105         <display_reg_element_at_line>: New method.
4106
4107 2019-07-17  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui-regs.h (tui_display_registers_from)
4110         (tui_display_registers_from_line): Don't declare.
4111         * tui/tui-windata.c (tui_data_window::display_all_data)
4112         (tui_data_window::refresh_all)
4113         (tui_data_window::do_scroll_vertical): Update.
4114         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4115         from tui_display_registers_from.
4116         (tui_display_reg_element_at_line): Update.
4117         (tui_data_window::display_registers_from_line): Rename from
4118         tui_display_registers_from_line.
4119         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4120         display_registers_from_line>: New methods.
4121
4122 2019-07-17  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4125         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4126         from tui_erase_data_content.
4127         (tui_data_window::display_all_data)
4128         (tui_data_window::refresh_all)
4129         (tui_data_window::do_scroll_vertical): Update.
4130         * tui/tui-regs.c (tui_show_registers): Update.
4131         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4132         New method.
4133
4134 2019-07-17  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4137         declare.
4138         * tui/tui-windata.c
4139         (tui_data_window::delete_data_content_windows): Rename from
4140         tui_delete_data_content_windows.
4141         (tui_data_window::display_all_data)
4142         (tui_data_window::do_scroll_vertical): Update.
4143         * tui/tui-data.h (struct tui_data_window)
4144         <delete_data_content_windows>: New method.
4145
4146 2019-07-17  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4149         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4150
4151 2019-07-17  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4154         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4155         from tui_display_all_data.
4156         * tui/tui-win.c
4157         (tui_data_window::do_make_visible_with_new_height): Update.
4158         * tui/tui-regs.c (tui_show_registers): Update.
4159         * tui/tui-layout.c (tui_set_layout): Update.
4160         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4161         method.
4162
4163 2019-07-17  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4166         * tui/tui-windata.c (tui_display_data_from): Remove.
4167         (tui_data_window::refresh_all): Update.
4168
4169 2019-07-17  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4172         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4173         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4174         tui_display_registers_from_line.
4175         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4176         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4177         "force_display" parameter.
4178
4179 2019-07-17  Tom Tromey  <tom@tromey.com>
4180
4181         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4182         declare.
4183         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4184         Rename from tui_first_reg_element_no_inline.
4185         (tui_display_reg_element_at_line)
4186         (tui_display_registers_from_line): Update.
4187         * tui/tui-data.h (struct tui_data_window)
4188         <first_reg_element_no_inline>: New method.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-windata.c (tui_display_data_from)
4193         (tui_data_window::do_scroll_vertical): Update.
4194         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4195         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4196         Rename from tui_line_from_reg_element_no.
4197         (tui_display_registers_from_line): Update.
4198         * tui/tui-data.h (struct tui_data_window)
4199         <line_from_reg_element_no>: New method.
4200
4201 2019-07-17  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4204         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4205         tui_last_regs_line_no.
4206         (tui_display_reg_element_at_line)
4207         (tui_display_registers_from_line): Update.
4208         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4209         method.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         PR tui/24722:
4214         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4215         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4216         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4217         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4218         (tui_update_breakpoint_info): Likewise.
4219         * tui/tui-hooks.c (tui_event_create_breakpoint)
4220         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4221         Update.
4222
4223 2019-07-17  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4226
4227 2019-07-17  Tom Tromey  <tom@tromey.com>
4228
4229         * tui/tui-winsource.c (tui_update_source_window_as_is)
4230         (tui_update_source_windows_with_addr): Update.
4231         * tui/tui-source.h (tui_set_source_content)
4232         (tui_show_symtab_source): Add "win_info" parameter.
4233         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4234         parameter.
4235         (tui_show_symtab_source): Likewise.
4236
4237 2019-07-17  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-wingeneral.c
4240         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4241
4242 2019-07-17  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4245         (struct tui_cmd_window) <can_scroll>: New method.
4246         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4247         method.
4248
4249 2019-07-17  Tom Tromey  <tromey@adacore.com>
4250
4251         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4252         do_field_signed>: Rename.  Change type of "value".
4253         * ui-out.c (ui_out::field_signed): Rename from field_int.
4254         Change type of "value".
4255         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4256         type of "value".
4257         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4258         do_field_int.  Change type of "value".
4259         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4260         do_field_int.  Change type of "value".
4261         * tracepoint.c (trace_status_mi, tfind_1)
4262         (print_one_static_tracepoint_marker): Update.
4263         * thread.c (print_thread_info_1, print_selected_thread_frame):
4264         Update.
4265         * stack.c (print_frame, print_frame_info): Update.
4266         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4267         Update.
4268         * source.c (print_source_lines_base): Update.
4269         * skip.c (info_skip_command): Update.
4270         * record-btrace.c (btrace_ui_out_decode_error)
4271         (btrace_call_history_src_line): Update.
4272         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4273         Update.
4274         * progspace.c (print_program_space): Update.
4275         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4276         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4277         do_field_int.  Change type of "value".
4278         * mi/mi-out.c (mi_ui_out::do_table_begin)
4279         (mi_ui_out::do_table_header): Update.
4280         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4281         type of "value".
4282         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4283         (mi_cmd_data_list_changed_registers, output_register)
4284         (mi_cmd_data_read_memory, mi_load_progress)
4285         (mi_cmd_trace_frame_collected): Update.
4286         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4287         Update.
4288         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4289         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4290         (mi_cmd_var_list_children, varobj_update_one): Update.
4291         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4292         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4293         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4294         * inferior.c (print_inferior): Update.
4295         * gdb_bfd.c (print_one_bfd): Update.
4296         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4297         Update.
4298         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4299         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4300         do_field_int.  Change type of "value".
4301         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4302         do_field_int.  Change type of "value".
4303         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4304         (print_one_breakpoint_location, print_it_catch_fork)
4305         (print_one_catch_fork, print_it_catch_vfork)
4306         (print_one_catch_vfork, print_it_catch_solib)
4307         (print_it_catch_exec, print_it_ranged_breakpoint)
4308         (print_mention_watchpoint, print_mention_masked_watchpoint)
4309         (bkpt_print_it, update_static_tracepoint): Update.
4310         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4311         * break-catch-syscall.c (print_it_catch_syscall): Update.
4312         * ada-tasks.c (print_ada_task_info): Update.
4313         * ada-lang.c (print_it_exception, print_mention_exception):
4314         Update.
4315
4316 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         PR breakpoints/24541
4319         * gdbarch.c: Regenerate.
4320         * gdbarch.h: Regenerate.
4321         * gdbarch.sh: Adjust return type and parameter types for
4322         'stap_adjust_register'.
4323         (i386_stap_adjust_register): Adjust signature and return new
4324         register name.
4325         * stap-probe.c (stap_parse_register_operand): Adjust use of
4326         'gdbarch_stap_adjust_register'.
4327
4328 2019-07-17  Tom Tromey  <tromey@adacore.com>
4329
4330         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4331         declare VEC.
4332         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4333         std::vector.
4334         (struct s390_process_info): Add initializers.
4335         (s390_add_process): Use new.
4336         (s390_linux_nat_target::low_forget_process): Use delete.
4337         (s390_linux_nat_target::low_new_fork)
4338         (s390_linux_nat_target::stopped_by_watchpoint)
4339         (s390_linux_nat_target::low_prepare_to_resume)
4340         (s390_linux_nat_target::insert_watchpoint)
4341         (s390_linux_nat_target::insert_hw_breakpoint)
4342         (s390_linux_nat_target::remove_watchpoint)
4343         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4344
4345 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4346
4347         * aarch64-fbsd-nat.c: Include regcache.h.
4348         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4349         argument.
4350         (aarch64_fbsd_nat_target::fetch_registers)
4351         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4352         variable.
4353         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4354
4355 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4356
4357         * fbsd-nat.c: Include gdbarch.h.
4358
4359 2019-07-15  Tom Tromey  <tromey@adacore.com>
4360
4361         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4362
4363 2019-07-15  Tom Tromey  <tromey@adacore.com>
4364
4365         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4366         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4367         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4368         * cli-out.c (cli_ui_out::do_field_int): New method.
4369         * ui-out.c (ui_out::field_unsigned): New method.
4370         * symfile.c (generic_load): Use field_unsigned.
4371         (print_transfer_performance): Likewise.
4372         * record-btrace.c (ui_out_field_uint): Remove.
4373         (btrace_call_history_insn_range, btrace_call_history): Use
4374         field_unsigned.
4375         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4376         field_unsigned.
4377         * ui-out.h (class ui_out) <field_unsigned>: New method.
4378         <do_field_unsigned>: Likewise.
4379
4380 2019-07-15  Tom Tromey  <tromey@adacore.com>
4381
4382         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4383         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4384         * target.c (flash_erase_command): Use field_string.
4385         * infrun.c (print_signal_received_reason): Use field_string.
4386         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4387         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4388         field_string.
4389         * ada-tasks.c (print_ada_task_info): Use field_string.
4390
4391 2019-07-15  Tom Tromey  <tromey@adacore.com>
4392
4393         * target.c (flash_erase_command): Use field_core_addr.
4394         * symfile.c (generic_load): Use field_core_addr.
4395         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4396         Use field_core_addr.
4397         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4398         field_core_addr.
4399
4400 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4401
4402         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4403         value if its desired type is smaller than a CORE_ADDR and signed.
4404
4405 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4408         of changes to field names, and use new is_reference field to
4409         decide if a property is a reference or not.
4410         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4411         field.
4412         (struct dwarf2_property_baton): Update header comment, rename
4413         'referenced_type' to 'property_type' and update comments.
4414         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4415         default property type, store in property baton, update to take
4416         accound of renamed field.
4417         (read_func_scope): Update call to attr_to_dynamic_prop.
4418         (read_array_type): Likewise.
4419         (dwarf2_per_cu_addr_sized_int_type): New function.
4420         (read_subrange_index_type): Move type finding code to
4421         dwarf2_per_cu_addr_sized_int_type.
4422         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4423         (dwarf2_per_cu_addr_type): New function.
4424         (set_die_type): Update calls to attr_to_dynamic_prop.
4425
4426 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * dwarf2read.c (read_subrange_index_type): New function.
4429         (read_subrange_type): Move code into new function and call it.
4430         * gdbtypes.c (create_range_type): Add some asserts.
4431
4432 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4433
4434         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4435         update return statements.
4436         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4437         declaration, and update comment to match.
4438         * gdbtypes.c (resolve_dynamic_array): Update call to
4439         dwarf2_evaluate_property to match new return type.
4440
4441 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * valarith.c (value_subscripted_rvalue): Change lowerbound
4444         parameter type from int to LONGEST.
4445         * value.h (value_subscripted_rvalue): Likewise in declaration.
4446
4447 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * cli/cli-utils.c (info_print_command_completer): New function.
4450         * cli/cli-utils.h: Add 'completer.h' include, and forward
4451         declaration for 'struct cmd_list_element'.
4452         (info_print_command_completer): Declare.
4453         * stack.c (_initialize_stack): Add completer for 'info locals' and
4454         'info args'.
4455         * symtab.c (_initialize_symtab): Add completer for 'info
4456         variables' and 'info functions'.
4457         * NEWS: Mention completion for additional info commands.
4458
4459 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * cli/cli-utils.c (extract_info_print_args): Delete.
4462         (extract_arg_maybe_quoted): Delete.
4463         (info_print_options_defs): New variable.
4464         (make_info_print_options_def_group): New function.
4465         (extract_info_print_options): Define new function.
4466         * cli/cli-utils.h (extract_info_print_args): Delete.
4467         (struct info_print_options): New structure.
4468         (extract_info_print_options): Declare new function.
4469         * stack.c (info_locals_command): Update to use new
4470         extract_info_print_options, also add a header comment.
4471         (info_args_command): Likewise.
4472         * symtab.c (info_variables_command): Likewise.
4473         (info_functions_command): Likewise.
4474
4475 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4476
4477         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4478         to extract string arguments.
4479         * common/common-utils.c (extract_string_maybe_quoted): New function.
4480         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4481
4482 2019-07-11  Tom Tromey  <tromey@adacore.com>
4483
4484         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4485         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4486         * top.h (gdbinit): Don't declare.
4487         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4488         into...
4489         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4490         * top.c (gdb_init): Don't call init_cli_cmds.
4491         (gdbinit): Remove.
4492         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4493
4494 2019-07-11  Tom Tromey  <tromey@adacore.com>
4495
4496         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4497         after it has been moved.
4498
4499 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4500
4501         * valops.c (value_must_coerce_to_target): Change return type to
4502         bool.
4503         * value.h (value_must_coerce_to_target): Likewise.
4504
4505 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4506
4507         * breakpoint.c (is_hardware_watchpoint): Remove
4508         forward-declaration.
4509         (is_masked_watchpoint): Change return type to bool.
4510         (is_tracepoint): Likewise.
4511         (is_breakpoint): Likewise.
4512         (is_hardware_watchpoint): Likewise.
4513         (is_watchpoint): Likewise.
4514         (is_no_memory_software_watchpoint): Likewise.
4515         (is_catchpoint): Likewise.
4516         (breakpoint_1): Make FILTER parameter's return type bool.
4517         is_masked_watchpoint): Change return type to bool.
4518         (save_breakpoints): Make FILTER parameter's return type bool.
4519         * breakpoint.h (is_breakpoint): Change return type to bool.
4520         (is_watchpoint): Likewise.
4521         (is_catchpoint): Likewise.
4522         (is_tracepoint): Likewise.
4523
4524 2019-07-10  Tom Tromey  <tom@tromey.com>
4525
4526         * defs.h: Don't include gdbarch.h.
4527         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4528         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4529         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4530         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4531         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4532         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4533         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4534         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4535         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4536         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4537         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4538         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4539         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4540         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4541         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4542         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4543         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4544         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4545         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4546         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4547         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4548         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4549         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4550         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4551         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4552         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4553         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4554
4555 2019-07-10  Tom Tromey  <tromey@adacore.com>
4556
4557         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4558         * breakpoint.c (init_ada_exception_breakpoint): Register as
4559         bp_catchpoint.
4560         (print_one_breakpoint_location, print_one_breakpoint): Use
4561         is_ada_exception_catchpoint.
4562         * ada-lang.c (class ada_catchpoint_location): Pass
4563         bp_loc_software_breakpoint to bp_location constructor.
4564         (is_ada_exception_catchpoint): New function.
4565
4566 2019-07-10  Tom Tromey  <tromey@adacore.com>
4567
4568         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4569         VEC.
4570         (struct arm_exidx_entry): New method operator<.
4571         (struct arm_exidx_data) <section_maps>: Change type.
4572         (arm_exidx_data_free): Remove.
4573         (arm_exidx_data_key): Change type.  Move lower.
4574         (arm_exidx_new_objfile): Update.
4575         (arm_compare_exidx_entries): Remove.
4576         (arm_find_exidx_entry, _initialize_arm_tdep)
4577
4578 2019-07-10  Tom Tromey  <tromey@adacore.com>
4579
4580         * solib-spu.c (ocl_program_data_key): Change type.
4581         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4582         Update.
4583
4584 2019-07-10  Tom Tromey  <tromey@adacore.com>
4585
4586         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4587         (struct solib_aix_inferior_data) <library_list>: Change type.
4588         (solib_aix_inferior_data_handle): Change type.
4589         (get_solib_aix_inferior_data): Update.
4590         (solib_aix_free_library_list): Remove.
4591         (library_list_start_library): Update.
4592         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4593         return type.
4594         (solib_aix_get_library_list)
4595         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4596         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4597
4598 2019-07-10  Tom Tromey  <tromey@adacore.com>
4599
4600         * solib-dsbt.c (struct dsbt_info): Add initializers.
4601         (solib_dsbt_pspace_data): Change type.
4602         (dsbt_pspace_data_cleanup): Remove.
4603         (get_dsbt_info, _initialize_dsbt_solib): Update.
4604
4605 2019-07-10  Tom Tromey  <tromey@adacore.com>
4606
4607         * spu-tdep.c (spu_overlay_data): Change type.
4608         (spu_get_overlay_table, spu_overlay_new_objfile)
4609         (_initialize_spu_tdep): Update.
4610
4611 2019-07-10  Tom Tromey  <tromey@adacore.com>
4612
4613         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4614         destructor.
4615         (dbx_objfile_data_key): Change type and declare later.
4616         (DBX_SYMFILE_INFO): Rewrite.
4617         * dbxread.c (dbx_objfile_data_key): Change type.
4618         (dbx_symfile_init): Update.
4619         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4620         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4621         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4622
4623 2019-07-10  Tom Tromey  <tromey@adacore.com>
4624
4625         * jit.c (jit_program_space_key): Change type.  Move lower.
4626         (get_jit_program_space_data): Update.
4627         (jit_program_space_data_cleanup): Remove.
4628         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4629         Update.
4630         (struct jit_program_space_data): Add initializers.
4631
4632 2019-07-10  Tom Tromey  <tromey@adacore.com>
4633
4634         * solib-darwin.c (struct darwin_info): Add initializers.
4635         (solib_darwin_pspace_data): Change type.
4636         (darwin_pspace_data_cleanup): Remove.
4637         (get_darwin_info, _initialize_darwin_solib): Update.
4638
4639 2019-07-10  Tom Tromey  <tromey@adacore.com>
4640
4641         * remote-sim.c (struct sim_inferior_data): Add initializers,
4642         constructor, and destructor.
4643         (sim_inferior_data_key): Change type.  Move lower.
4644         (check_for_duplicate_sim_descriptor): Update.
4645         (get_sim_inferior_data): Use new.  Update.
4646         (~sim_inferior_data_cleanup): Rename from
4647         sim_inferior_data_cleanup.  Simplify.
4648         (gdbsim_close_inferior, simulator_command)
4649         (sim_command_completer, _initialize_remote_sim): Update.
4650         (next_pid, INITIAL_PID): Move earlier.
4651
4652 2019-07-10  Tom Tromey  <tromey@adacore.com>
4653
4654         * python/python-internal.h (create_thread_object): Return
4655         gdbpy_ref.
4656         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4657         * python/py-inferior.c (struct threadlist_entry): Add
4658         constructor.
4659         <thread_obj>: Now a gdbpy_ref.
4660         (thread_to_thread_object): Update.
4661         (add_thread_object): Use new.
4662         (delete_thread_object): Use delete.
4663         (infpy_threads): Update.
4664         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4665         GIL.
4666
4667 2019-07-10  Tom Tromey  <tromey@adacore.com>
4668
4669         * valops.c (value_cast): Specialize error message for Ada.
4670
4671 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4672
4673         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4674
4675 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4676
4677         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4678         bpstat_should_step): Return bool, adjust comments.
4679         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4680         bpstat_should_step): Likewise.
4681
4682 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4683
4684         * features/Makefile: Use feature target descriptions for Arm.
4685         * features/arm/arm-core.c: Generate new file.
4686         * features/arm/arm-fpa.c: Likewise.
4687         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4688         * features/arm/arm-m-profile.c: Likewise.
4689         * features/arm/arm-vfpv2.c: Likewise.
4690         * features/arm/arm-vfpv3.c: Likewise.
4691         * features/arm/xscale-iwmmxt.c: Likewise.
4692         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4693
4694 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4695
4696         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4697         ptrace earlier.
4698
4699 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4700
4701         * features/aarch64-pauth.c: Regenerate.
4702
4703 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4704
4705         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4706         bool.
4707         (bpstat_what): Use false instead of 0.
4708
4709 2019-07-09  Pedro Alves  <palves@redhat.com>
4710
4711         * break-catch-throw.c (is_exception_catchpoint): New.
4712         * breakpoint.c (print_one_breakpoint_location): New parameter
4713         'raw_loc'.  Handle it.  Use
4714         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4715         looking at the breakpoint's type.
4716         (print_one_breakpoint): If handling "maint info breakpoints", also
4717         print locations of exception catchpoints.
4718         * breakpoint.h (is_exception_catchpoint): Declare.
4719
4720 2019-07-09  Pedro Alves  <palves@redhat.com>
4721
4722         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4723         "addr" field.
4724         (allocate_location_exception_catchpoint): New.
4725         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4726         (initialize_throw_catchpoint_ops): Install
4727         allocate_location_exception_catchpoint as allocate_location
4728         method.
4729         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4730         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4731         bp_loc_other.
4732         (breakpoint_address_is_meaningful): Delete.
4733         (bl_address_is_meaningful): New.
4734         (breakpoint_locations_match): Adjust comment.
4735         (bp_location_from_bp_type): New, factored out of...
4736         (bp_location::bp_location(breakpoint *)): ... this.
4737         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4738         factored out of...
4739         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4740         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4741         breakpoint_address_is_meaningful.
4742         (bp_locations_compare): Adjust comment.
4743         (update_global_location_list): Use bl_address_is_meaningful
4744         instead of breakpoint_address_is_meaningful.
4745         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4746         explicit.
4747         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4748         * python/py-breakpoint.c (bppy_get_location): No longer check
4749         whether location is null.
4750
4751 2019-07-09  Pedro Alves  <palves@redhat.com>
4752
4753         PR c++/15468
4754         * breakpoint.c (print_one_breakpoint_location): Remove
4755         single-location assert.
4756
4757 2019-07-09  Tom Tromey  <tom@tromey.com>
4758
4759         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4760         * configure: Rebuild.
4761         * configure.ac: Change common to gdbsupport.
4762         * gdbsupport: Rename from common.
4763         * acinclude.m4: Change common to gdbsupport.
4764         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4765         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4766         gdbsupport.
4767         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4768         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4769         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4770         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4771         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4772         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4773         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4774         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4775         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4776         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4777         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4778         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4779         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4780         coff-pe-read.c, command.h, compile/compile-c-support.c,
4781         compile/compile-c.h, compile/compile-cplus-symbols.c,
4782         compile/compile-cplus-types.c, compile/compile-cplus.h,
4783         compile/compile-loc2c.c, compile/compile.c, completer.c,
4784         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4785         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4786         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4787         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4788         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4789         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4790         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4791         features/aarch64-core.c, features/aarch64-fpu.c,
4792         features/aarch64-pauth.c, features/aarch64-sve.c,
4793         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4794         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4795         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4796         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4797         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4798         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4799         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4800         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4801         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4802         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4803         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4804         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4805         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4806         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4807         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4808         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4809         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4810         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4811         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4812         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4813         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4814         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4815         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4816         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4817         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4818         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4819         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4820         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4821         minsyms.c, mips-linux-tdep.c, namespace.h,
4822         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4823         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4824         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4825         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4826         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4827         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4828         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4829         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4830         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4831         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4832         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4833         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4834         procfs.c, producer.c, progspace.h, psymtab.h,
4835         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4836         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4837         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4838         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4839         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4840         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4841         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4842         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4843         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4844         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4845         target-memory.c, target.c, target.h, target/waitstatus.c,
4846         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4847         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4848         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4849         unittests/array-view-selftests.c,
4850         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4851         unittests/common-utils-selftests.c,
4852         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4853         unittests/format_pieces-selftests.c,
4854         unittests/function-view-selftests.c,
4855         unittests/lookup_name_info-selftests.c,
4856         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4857         unittests/mkdir-recursive-selftests.c,
4858         unittests/observable-selftests.c,
4859         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4860         unittests/parse-connection-spec-selftests.c,
4861         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4862         unittests/scoped_fd-selftests.c,
4863         unittests/scoped_mmap-selftests.c,
4864         unittests/scoped_restore-selftests.c,
4865         unittests/string_view-selftests.c, unittests/style-selftests.c,
4866         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4867         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4868         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4869         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4870         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4871         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4872
4873 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4876         bool value.
4877         (decode_digits_ordinary): Set explicit_line field in sal.
4878         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4879         symtab_and_line that was set on an explicit line number in
4880         assembler code.  Do always update the recorded symtab and line if
4881         we do skip the prologue.
4882
4883 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * breakpoint.c (set_breakpoint_location_function): Remove
4886         explicit_loc parameter.
4887         (momentary_breakpoint_from_master): Update call to
4888         set_breakpoint_location_function.
4889         (add_location_to_breakpoint): Likewise.
4890
4891 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4894         required features based on default bfd type when no specific bfd
4895         is present.
4896
4897 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4898
4899         * NEWS: Mention that GDB printf and eval commands can now print
4900         C-style and Ada-style convenience var strings without
4901         calling the inferior.
4902         * printcmd.c (printf_c_string): Locally print GDB internal var
4903         instead of transiting via the inferior.
4904         (printf_wide_c_string): Likewise.
4905
4906 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4907
4908         PR breakpoints/25011
4909         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4910
4911 2019-07-04  Tom Tromey  <tom@tromey.com>
4912
4913         PR tui/24724:
4914         * tui/tui-winsource.c (tui_clear_source_content): Update.
4915         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4916         (tui_update_breakpoint_info): Update.
4917         (tui_set_exec_info_content): Update.
4918         * tui/tui-source.c (tui_set_source_content_nil): Update.
4919         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4920         has_break.
4921         * tui/tui-data.h (enum tui_bp_flag): New.
4922         (tui_bp_flags): New enum flags type.
4923         (struct tui_source_element) <break_mode>: Change type.  Rename
4924         from has_break.
4925         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4926         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4927         constants.
4928         * tui/tui-winsource.h: Fix comment.
4929
4930 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4933         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4934         (store_fpregs_to_thread)
4935         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4936         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4937         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4938         (IWMMXT_REGS_SIZE): Add define.
4939         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4940         (fetch_vfp_regs, store_vfp_regs)
4941         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4942         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4943
4944 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4945
4946         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4947         defines.
4948         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4949         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4950         (ARM_INT_REGISTER_SIZE): ...to this.
4951         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4952         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4953         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4954         (arm_linux_collect_gregset, supply_nwfpe_register)
4955         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4956         defines.
4957         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4958         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4959         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4960         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4961         (arm_return_in_memory, arm_store_return_value)
4962         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4963         (arm_record_ld_st_multiple): Likewise.
4964         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4965         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4966
4967 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4968
4969         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4970         AARCH64_DISPLACED_MODIFIED_INSNS.
4971         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4972         (aarch64_displaced_step_copy_insn): Likewise.
4973         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4974         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4975         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4976         ARM_DISPLACED_MODIFIED_INSNS.
4977         * arm-tdep.c (arm_gdbarch_init): Likewise.
4978         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4979         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4980         (struct arm_displaced_step_closure): Use
4981         ARM_DISPLACED_MODIFIED_INSNS.
4982
4983 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4984
4985         * features/Makefile: Remove unused xml files.
4986         * features/aarch64.xml: Remove.
4987         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4988         * features/i386/amd64-avx-avx512.xml: Remove.
4989         * features/i386/amd64-avx-linux.xml: Remove.
4990         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4991         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4992         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4993         * features/i386/amd64-avx-mpx.xml: Remove.
4994         * features/i386/amd64-avx.xml: Remove.
4995         * features/i386/amd64-linux.xml: Remove.
4996         * features/i386/amd64-mpx-linux.xml: Remove.
4997         * features/i386/amd64-mpx.xml: Remove.
4998         * features/i386/amd64.xml: Remove.
4999         * features/i386/i386-avx-avx512-linux.xml: Remove.
5000         * features/i386/i386-avx-avx512.xml: Remove.
5001         * features/i386/i386-avx-linux.xml: Remove.
5002         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5003         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5004         * features/i386/i386-avx-mpx-linux.xml: Remove.
5005         * features/i386/i386-avx-mpx.xml: Remove.
5006         * features/i386/i386-avx.xml: Remove.
5007         * features/i386/i386-linux.xml: Remove.
5008         * features/i386/i386-mmx-linux.xml: Remove.
5009         * features/i386/i386-mmx.xml: Remove.
5010         * features/i386/i386-mpx-linux.xml: Remove.
5011         * features/i386/i386-mpx.xml: Remove.
5012         * features/i386/i386.xml: Remove.
5013         * features/i386/x32-avx-avx512-linux.xml: Remove.
5014         * features/i386/x32-avx-linux.xml: Remove.
5015         * features/i386/x32-linux.xml: Remove.
5016
5017 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5018
5019         * regformats/aarch64.dat: Remove.
5020         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5021         * regformats/i386/amd64-avx-linux.dat: Remove.
5022         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5023         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5024         * regformats/i386/amd64-linux.dat: Remove.
5025         * regformats/i386/amd64-mpx-linux.dat: Remove.
5026         * regformats/i386/amd64.dat: Remove.
5027         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5028         * regformats/i386/i386-avx-linux.dat: Remove.
5029         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5030         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5031         * regformats/i386/i386-linux.dat: Remove.
5032         * regformats/i386/i386-mmx-linux.dat: Remove.
5033         * regformats/i386/i386-mpx-linux.dat: Remove.
5034         * regformats/i386/i386.dat: Remove.
5035         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5036         * regformats/i386/x32-avx-linux.dat: Remove.
5037         * regformats/i386/x32-linux.dat: Remove.
5038
5039 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5040
5041         * aarch64-tdep.c: Remove xml self tests.
5042         * amd64-linux-tdep.c: Likewise.
5043         * amd64-tdep.c: Likewise.
5044         * i386-linux-tdep.c: Likewise.
5045         * i386-tdep.c: Likewise.
5046
5047 2019-07-03  Pedro Alves  <palves@redhat.com>
5048
5049         PR cli/24732
5050         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5051         (pipe_cmd_option_defs): New.
5052         (make_pipe_cmd_options_def_group): New.
5053         (pipe_command): Use gdb::option::process_options.
5054         (pipe_command_completer): New function.
5055         (_initialize_cli_cmds): Install completer for "pipe" command.
5056
5057 2019-07-03  Pedro Alves  <palves@redhat.com>
5058
5059         * cli/cli-option.c (union option_value) <string>: New field.
5060         (struct option_def_and_value): Add ctor, move ctor, dtor and
5061         use DISABLE_COPY_AND_ASSIGN.
5062         (option_def_and_value::clear_value): New.
5063         (parse_option, save_option_value_in_ctx, get_val_type_str)
5064         (add_setshow_cmds_for_options): Handle var_string.
5065         * cli-option.h (union option_def::var_address) <string>: New
5066         field.
5067         (struct string_option_def): New.
5068         * maint-test-options.c (struct test_options_opts): Add default
5069         ctor and use DISABLE_COPY_AND_ASSIGN.
5070         <string_opt>: New field.
5071         (test_options_opts::~test_options_opts): New.
5072         (test_options_opts::dump): Also dump "-string".
5073         (test_options_option_defs): Install "string.
5074
5075 2019-07-03  Pedro Alves  <palves@redhat.com>
5076
5077         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5078         option_value with a null enumeration.
5079         (complete_options): Save the option values in the context.
5080         (save_option_value_in_ctx): New, factored out from ...
5081         (process_options): ... here.
5082         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5083         of the function.
5084         * maint-test-options.c (test_options_opts::dump): New, factored
5085         out from ...
5086         (maintenance_test_options_command_mode): ... here.
5087         (maintenance_test_options_command_completion_result): Delete.
5088         (maintenance_test_options_command_completion_text): Update
5089         comment.
5090         (maintenance_show_test_options_completion_result): Change
5091         prototype.  Just print
5092         maintenance_test_options_command_completion_text.
5093         (save_completion_result): New.
5094         (maintenance_test_options_completer_mode): Pass options context to
5095         complete_options, and then save a dump.
5096         (_initialize_maint_test_options): Use add_cmd to install "maint
5097         show test-options-completion-result".
5098
5099 2019-07-03  Pedro Alves  <palves@redhat.com>
5100
5101         * NEWS (New commands): Mention "with" and "maint with".
5102         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5103         (with_command, with_command_completer): New.
5104         (pipe_command): Adjust to new repeat_previous
5105         interface.
5106         (_initialize_cli_cmds): Install the "with" command and its "w"
5107         alias.
5108         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5109         declarations.
5110         * cli/cli-setshow.c (parse_cli_var_uinteger)
5111         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5112         argument strings for all var_types.
5113         (get_setshow_command_value_string): New, factored out from ...
5114         (do_show_command): ... this.
5115         * cli/cli-setshow.h: Include <string>.
5116         (get_setshow_command_value_string): Declare.
5117         * command.h (repeat_previous): Now returns const char *.  Adjust
5118         comment.
5119         * maint.c: Include "cli/cli-cmds.h".
5120         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5121         (_initialize_maint_cmds): Register the "maintenance with" command.
5122         * top.c (repeat_previous): Move bits from pipe_command here:
5123         Return the saved command line, if any; error out if there's no
5124         command to relaunch.
5125
5126 2019-07-03  Pedro Alves  <palves@redhat.com>
5127
5128         * NEWS (New commands): Mention "maint set/show test-settings"
5129         instead of "maint test-settings".
5130         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5131         (maintenance_test_settings_set_list): Rename to ...
5132         (maintenance_set_test_settings_list): ... this.
5133         (maintenance_test_settings_show_list): Rename to  ...
5134         (maintenance_show_test_settings_list): ... this.
5135         (maintenance_test_settings_cmd): Delete.
5136         (maintenance_test_settings_set_cmd): ...
5137         (maintenance_set_test_settings_cmd): ... this.
5138         (maintenance_test_settings_show_cmd): ...
5139         (maintenance_show_test_settings_cmd): ... this.
5140         (maintenance_test_settings_show_value_cmd):
5141         (maintenance_show_test_settings_value_cmd): ... this.
5142         (_initialize_maint_test_settings): No longer install the "maint
5143         test-settings" prefix command.  Rename "maint test-settings set"
5144         to "maint set test-settings", and "maint test-settings show" to
5145         "maint show test-settings".  Adjust all subcommands.
5146
5147 2019-07-03  Pedro Alves  <palves@redhat.com>
5148
5149         * maint-test-settings.c: Fix file's intro comment.  Replace all
5150         references to "test-options" with references to "test-settings",
5151         in comments.
5152
5153 2019-07-03  Pedro Alves  <palves@redhat.com>
5154
5155         * maint-test-settings.c (maintenance_test_settings_xxx)
5156         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5157         New.
5158         (maintenance_test_settings_enums): Use them.
5159         (maintenance_test_settings_enum): Default to
5160         maintenance_test_settings_xxx.
5161         (_initialize_maint_test_settings): Initialize
5162         MAINTENANCE_TEST_SETTINGS_FILENAME.
5163
5164 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5165
5166         * breakpoint.h (remove_breakpoints_inf): Change return type to
5167         void, move function documentation here.
5168         * breakpoint.c (remove_breakpoints_inf): Change return type to
5169         void, move function documentation to header.
5170
5171 2019-07-02  Pedro Alves  <palves@redhat.com>
5172
5173         * NEWS (Completion improvements): Mention "info threads".
5174         * thread.c (struct info_threads_opts, info_threads_option_defs)
5175         (make_info_threads_options_def_group): New.
5176         (info_threads_command): Use gdb::option::process_options.
5177         (info_threads_command_completer): New.
5178         (_initialize_thread): Use gdb::option::build_help to build the
5179         help text for "info threads".
5180
5181 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5182
5183         * defs.h (generic_load): Move from here...
5184         * symfile.h (generic_load): ... to here.  Rename name parameter
5185         to args.
5186         * symfile.c (generic_load): Add comment.
5187
5188 2019-07-01  Tom Tromey  <tromey@adacore.com>
5189
5190         * dwarf2read.c
5191         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5192         declaration of without_params.  Fix formatting.
5193
5194 2019-07-01  Tom Tromey  <tromey@adacore.com>
5195
5196         * ada-exp.y (find_primitive_type): Update.
5197         * ada-lang.h (ada_lookup_symbol): Update.
5198         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5199         parameter.
5200         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5201
5202 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5203
5204         PR breakpoints/24541
5205         * gdbarch.c: Regenerate.
5206         * gdbarch.h: Regenerate.
5207         * gdbarch.sh: Add 'stap_adjust_register'.
5208         * i386-tdep.c: Include '<unordered_set>'.
5209         (i386_stap_adjust_register): New function.
5210         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5211         * stap-probe.c (stap_parse_register_operand): Call
5212         'gdbarch_stap_adjust_register'.
5213
5214 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5215
5216         PR python/24742
5217         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5218         * python/python.c (do_start_initialization): Use 'xmalloc'
5219         instead of 'PyMem_Malloc'.
5220
5221 2019-06-28  Tom Tromey  <tromey@adacore.com>
5222
5223         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5224         for Ada.
5225
5226 2019-06-27  Tom Tromey  <tromey@adacore.com>
5227
5228         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5229         objfile_key.
5230         (arm_find_mapping_symbol, arm_record_special_symbol)
5231         (_initialize_arm_tdep): Update.
5232         (arm_objfile_data_free): Remove.
5233
5234 2019-06-27  Tom Tromey  <tromey@adacore.com>
5235
5236         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5237         to cp_print_static_field.
5238
5239 2019-06-26  Tom Tromey  <tromey@adacore.com>
5240
5241         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5242         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5243         declare.
5244
5245 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * features/aarch64-core.c (create_feature_aarch64_core):
5248         Regenerate.
5249         * features/aarch64-core.xml: Add cpsr flags.
5250
5251 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5252
5253         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5254         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5255
5256 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5257
5258         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5259         field.
5260         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5261         use.
5262         (arm_record_special_symbol): Don't insert new symbol in sorted
5263         position, push it at the end.
5264
5265 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5266
5267         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5268         (arm_mapping_symbol_s): Remove.
5269         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5270         (arm_mapping_symbol_vec): New typedef.
5271         (struct arm_per_objfile): Add constructor.
5272         <section_maps>: Change type to
5273         std::unique_ptr<arm_mapping_symbol_vec[]>.
5274         (arm_compare_mapping_symbols): Remove.
5275         (arm_find_mapping_symbol): Adjust to section_maps type change.
5276         (arm_objfile_data_free): Call delete on arm_per_objfile.
5277         (arm_record_special_symbol): Adjust to section_maps type change.
5278         Allocate arm_per_objfile with new.
5279
5280 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5281
5282         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5283         with the command prefix.
5284
5285 2019-06-25  Tom Tromey  <tom@tromey.com>
5286
5287         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5288         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5289
5290 2019-06-25  Tom Tromey  <tom@tromey.com>
5291
5292         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5293         type.
5294         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5295         protected.
5296
5297 2019-06-25  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui-winsource.c
5300         (tui_source_window_base::set_is_exec_point_at): Add check against
5301         LOA_ADDRESS.
5302
5303 2019-06-25  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-source.c (tui_set_source_content): Don't check before
5306         xfree.
5307         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5308
5309 2019-06-25  Tom Tromey  <tom@tromey.com>
5310
5311         * tui/tui-winsource.h (tui_update_source_window_as_is)
5312         (tui_alloc_source_buffer, tui_line_is_displayed)
5313         (tui_addr_is_displayed): Change type of win_info.
5314         * tui/tui-winsource.c (tui_update_source_window_as_is)
5315         (tui_clear_source_content, tui_show_source_line)
5316         (tui_show_source_content, tui_source_window_base::refill)
5317         (tui_source_window_base::set_is_exec_point_at)
5318         (tui_source_window_base::set_is_exec_point_at)
5319         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5320         (tui_alloc_source_buffer, tui_line_is_displayed)
5321         (tui_addr_is_displayed): Change type of win_info.  Update.
5322         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5323         (tui_source_window_base::do_make_visible_with_new_height):
5324         Update.
5325         * tui/tui-source.c (tui_set_source_content)
5326         (tui_set_source_content_nil)
5327         (tui_source_window::do_scroll_vertical): Update.
5328         * tui/tui-layout.c (show_layout): Update.
5329         * tui/tui-disasm.c (tui_set_disassem_content)
5330         (tui_disasm_window::do_scroll_vertical): Update.
5331         * tui/tui-data.h (tui_win_content): Remove.
5332         (struct tui_gen_win_info) <content, content_size>: Remove.
5333         (struct tui_source_element): Add initializers and destructor.
5334         (union tui_which_element, struct tui_win_element): Remove.
5335         (struct tui_source_window_base) <content>: New field.
5336         (struct tui_data_window): Remove destructor.
5337         (tui_alloc_content, tui_free_win_content)
5338         (tui_free_all_source_wins_content): Don't declare.
5339         * tui/tui-data.c (tui_initialize_static_data): Update.
5340         (init_content_element, tui_alloc_content): Remove.
5341         (~tui_gen_win_info): Update.
5342         (~tui_data_window, tui_free_all_source_wins_content)
5343         (tui_free_win_content, free_content, free_content_elements):
5344         Remove.
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-winsource.h (tui_clear_source_content)
5349         (tui_erase_source_content, tui_show_source_content): Change type
5350         of win_info.
5351         * tui/tui-winsource.c (tui_clear_source_content)
5352         (tui_erase_source_content, tui_show_source_content): Change type
5353         of win_info.
5354         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5355         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5356         win_info.
5357         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5358         win_info.
5359         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5360
5361 2019-06-25  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-winsource.c (tui_clear_source_content)
5364         (tui_source_window_base::set_is_exec_point_at): Update.
5365         * tui/tui-source.c (tui_set_source_content_nil): Update.
5366         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5367         a bool.
5368         * tui/tui-data.c (init_content_element): Update.
5369
5370 2019-06-25  Tom Tromey  <tom@tromey.com>
5371
5372         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5373         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5374         * tui/tui-layout.c (init_and_make_win): Update.
5375         * tui/tui.h (enum tui_win_type): Update.
5376         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5377         tui_win_is_auxillary.
5378         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5379         tui_win_is_auxillary.
5380
5381 2019-06-25  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5384         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5385         (tui_delete_data_content_windows, tui_display_all_data)
5386         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5387         Update.
5388         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5389         * tui/tui-regs.c (tui_last_regs_line_no)
5390         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5391         (tui_show_registers): Update.
5392         (tui_show_register_group): Return void.  Update.
5393         (tui_display_registers_from, tui_display_reg_element_at_line)
5394         (tui_display_registers_from_line, tui_check_register_values):
5395         Update.
5396         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5397         member.
5398         (struct tui_data_window) <regs_content>: Now a std::vector.
5399         <regs_content_count>: Remove.
5400         (tui_add_content_elements, tui_free_data_content): Don't declare.
5401         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5402         (init_content_element): Remove DATA_WIN case.  Add assert.
5403         (tui_add_content_elements): Remove.
5404         (tui_data_window): Update.
5405         (tui_free_data_content): Remove.
5406         (free_content_elements): Remove DATA_WIN case.
5407
5408 2019-06-25  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-data.c (tui_data_item_window): Update.
5411         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5412         * tui/tui-windata.c (tui_display_all_data)
5413         (tui_display_data_from_line): Update.
5414         (tui_check_data_values): Remove.
5415         * tui/tui-regs.c (tui_show_register_group)
5416         (tui_display_reg_element_at_line): Update.
5417         * tui/tui-hooks.c (tui_register_changed)
5418         (tui_refresh_frame_and_register_information): Call
5419         tui_check_register_values.
5420         * tui/tui-data.h (struct tui_data_window) <data_content,
5421         data_content_count, data_type>: Remove.
5422         (enum tui_data_type): Remove.
5423
5424         * tui/tui-data.c (tui_data_window::clear_detail)
5425         (~tui_data_window): Update.
5426
5427 2019-06-25  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5430         declare.
5431         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5432         Rename from tui_first_data_item_displayed.  Update.
5433         (tui_data_window::refresh_all)
5434         (tui_data_window::do_scroll_vertical): Update.
5435         * tui/tui-data.h (struct tui_data_window)
5436         <first_data_item_displayed>: Declare new method.
5437
5438 2019-06-25  Tom Tromey  <tom@tromey.com>
5439
5440         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5441         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5442         contents...
5443         (tui_initialize_static_data): ...here.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5448         (tui_display_registers_from, tui_check_register_values): Update.
5449         (tui_display_register): Remove win_info parameter; update.
5450         (tui_get_register): Change type of parameters.
5451         * tui/tui-data.h (struct tui_data_element): Remove.
5452         (union tui_which_element) <data>: Remove.
5453         <data_window>: Change type.
5454         (struct tui_data_item_window): New.
5455         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5456         case.  Add assert.
5457         (~tui_data_item_window): New destructor.
5458         (free_content_elements): Remove DATA_ITEM_WIN case.
5459
5460 2019-06-25  Tom Tromey  <tom@tromey.com>
5461
5462         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5463         Remove.
5464
5465 2019-06-25  Tom Tromey  <tom@tromey.com>
5466
5467         * tui/tui-data.h (struct tui_command_element): Remove.
5468         (union tui_which_element) <command>: Remove.
5469         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5470         assert.
5471         (free_content_elements): Remove CMD_WIN case.
5472
5473 2019-06-25  Tom Tromey  <tom@tromey.com>
5474
5475         * tui/tui-layout.c (tui_set_layout): Update.
5476         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5477         * tui/tui-data.c (layout_def): Update.
5478
5479 2019-06-25  Tom Tromey  <tom@tromey.com>
5480
5481         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5482         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5483         (tui_source_window_base::set_new_height): Update.
5484         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5485         Update.
5486         (tui_set_locator_fullname, tui_set_locator_info)
5487         (tui_show_frame_info): Update.
5488         * tui/tui-source.c (tui_set_source_content)
5489         (tui_source_is_displayed): Update.
5490         * tui/tui-layout.c (show_source_disasm_command, show_data)
5491         (show_source_or_disasm_and_command): Update.
5492         * tui/tui-disasm.c (tui_set_disassem_content)
5493         (tui_get_begin_asm_address): Update.
5494         * tui/tui-data.h (struct tui_locator_element): Remove.
5495         (union tui_which_element) <locator>: Remove.
5496         (struct tui_locator_window): New.
5497         (tui_locator_win_info_ptr): Change return type.
5498         * tui/tui-data.c (_locator): Change type.
5499         (tui_locator_win_info_ptr): Change return type.
5500         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5501         (tui_alloc_content): Add assert.
5502
5503 2019-06-25  Tom Tromey  <tom@tromey.com>
5504
5505         * tui/tui-winsource.c
5506         (tui_exec_info_window::maybe_allocate_content): New method.
5507         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5508         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5509         (make_source_or_disasm_window): Add cast.
5510         * tui/tui-data.h (union tui_which_element) <simple_string>:
5511         Remove.
5512         (struct tui_source_info): New.
5513         (struct tui_source_window_base) <execution_info>: Change type.
5514         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5515         case, and add assert.
5516         (tui_alloc_content): Add assert.
5517
5518 2019-06-25  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5521         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5522         * tui/tui-data.c (tui_alloc_win_info): Remove.
5523
5524 2019-06-25  Tom Tromey  <tom@tromey.com>
5525
5526         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5527         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5528         can_highlight.
5529
5530 2019-06-25  Tom Tromey  <tom@tromey.com>
5531
5532         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5533         make_visible_with_new_height method.
5534         (tui_win_info::make_visible_with_new_height): New method.
5535         (tui_source_window_base::do_make_visible_with_new_height)
5536         (tui_data_window::do_make_visible_with_new_height)
5537         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5538         (make_visible_with_new_height): Remove.
5539         (tui_resize_all, tui_adjust_win_heights): Use
5540         make_visible_with_new_height method.
5541         * tui/tui-data.h (struct tui_win_info)
5542         <do_make_visible_with_new_height, make_visible_with_new_height>:
5543         New methods.
5544         (struct tui_source_window_base, struct tui_data_window)
5545         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5546         methods.
5547
5548 2019-06-25  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5551         method.
5552         (update_tab_width): Call update_tab_width method.
5553         * tui/tui-data.h (struct tui_win_info)
5554         (struct tui_source_window_base) <update_tab_width>: New methods.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5559         parameter.
5560         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5561         parameter.
5562         (tui_gen_win_info::make_visible): Update.
5563         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5564         parameter.
5565         * tui/tui-data.h (enum tui_box): New enum.
5566         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5567
5568 2019-06-25  Tom Tromey  <tom@tromey.com>
5569
5570         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5571         init_and_make_win for EXEC_INFO_WIN.
5572         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5573         longer inline.
5574         (struct tui_win_info) <~tui_win_info>: Inline.
5575         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5576         Don't declare.
5577         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5578         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5579         Remove.
5580         (tui_initialize_static_data): Update.
5581         (~tui_gen_win_info): Handle more cleanup here.
5582         (~tui_source_window_base): Delete "execution_info".
5583         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5584
5585 2019-06-25  Tom Tromey  <tom@tromey.com>
5586
5587         * tui/tui-layout.c (make_command_window): Don't set
5588         can_highlight.
5589         (show_source_disasm_command): Call the reset method.
5590         (show_data): Don't set can_highlight.  Call the reset method.
5591         (tui_gen_win_info::reset): Rename from init_gen_win_info
5592         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5593         (show_source_or_disasm_and_command): Call the reset method.
5594         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5595         (struct tui_cmd_window): Set can_highlight.
5596
5597 2019-06-25  Tom Tromey  <tom@tromey.com>
5598
5599         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5600         from make_visible.
5601         (tui_make_visible, tui_make_invisible): Rewrite.
5602         (tui_win_info::make_visible): Remove.
5603         (tui_source_window_base::make_visible): Update.
5604         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5605         method.  Moved from...
5606         (struct tui_win_info) <make_visible>: ...here.
5607
5608 2019-06-25  Tom Tromey  <tom@tromey.com>
5609
5610         * tui/tui-winsource.c
5611         (tui_source_window_base::do_scroll_horizontal): Remove direction
5612         parameter.
5613         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5614         direction parameter.
5615         * tui/tui-win.c (tui_win_info::forward_scroll)
5616         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5617         (tui_win_info::right_scroll): Update.
5618         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5619         direction parameter.
5620         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5621         direction parameter.
5622         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5623         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5624         Remove direction parameter.
5625         (struct tui_source_window_base, struct tui_source_window)
5626         (struct tui_disasm_window, struct tui_data_window)
5627         (struct tui_cmd_window): Update.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-winsource.h (tui_set_exec_info_content)
5632         (tui_show_exec_info_content, tui_erase_exec_info_content)
5633         (tui_clear_exec_info_content, tui_update_exec_info): Change
5634         argument to tui_source_window_base.
5635         * tui/tui-winsource.c (tui_set_exec_info_content)
5636         (tui_show_exec_info_content, tui_erase_exec_info_content)
5637         (tui_clear_exec_info_content, tui_update_exec_info): Change
5638         argument to tui_source_window_base.
5639
5640 2019-06-25  Tom Tromey  <tom@tromey.com>
5641
5642         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5643         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5648         check.
5649
5650 2019-06-25  Tom Tromey  <tom@tromey.com>
5651
5652         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5653         type to void.
5654         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5655         type to void.
5656         * tui/tui-source.c (tui_set_source_content): Update.
5657         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5658
5659 2019-06-25  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-win.c (window_name_completer, tui_set_focus)
5662         (tui_all_windows_info): Use name method.
5663         * tui/tui-data.h (struct tui_gen_win_info)
5664         (struct tui_source_window, struct tui_disasm_window)
5665         (struct tui_data_window, struct tui_cmd_window) <name>: New
5666         method.
5667         (tui_win_name): Don't declare.
5668         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5669         (tui_win_name): Remove.
5670
5671 2019-06-25  Tom Tromey  <tom@tromey.com>
5672
5673         * tui/tui-winsource.h (tui_update_source_window)
5674         (tui_update_source_window_as_is): Change parameter type.
5675         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5676         to be a tui_source_window_base.
5677         (tui_update_source_window_as_is): Likewise.
5678         * tui/tui-win.c (make_visible_with_new_height): Update.
5679
5680 2019-06-25  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui-winsource.c (tui_erase_source_content)
5683         (tui_show_source_content, tui_show_exec_info_content)
5684         (tui_erase_exec_info_content): Use refresh_window method.
5685         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5686         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5687         from tui_refresh_win.
5688         (tui_data_window::refresh_window): New method.
5689         (tui_win_info::refresh, tui_source_window_base::refresh)
5690         (tui_refresh_all): Use refresh_window method.
5691         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5692         method.
5693         * tui/tui-regs.c (tui_display_register): Call refresh_window
5694         method.
5695         * tui/tui-layout.c (show_source_disasm_command)
5696         (show_source_or_disasm_and_command): Call refresh_window method.
5697         * tui/tui-data.h (struct tui_gen_win_info)
5698         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5699         New method.
5700
5701 2019-06-25  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui.c (tui_rl_other_window, tui_enable)
5704         (tui_is_window_visible, tui_get_command_dimension): Update.
5705         * tui/tui-winsource.c (tui_update_source_window_as_is)
5706         (tui_clear_source_content, tui_erase_source_content)
5707         (tui_show_source_line, tui_source_window_base::refill)
5708         (tui_source_window_base::do_scroll_horizontal)
5709         (tui_source_window_base::set_is_exec_point_at)
5710         (tui_update_breakpoint_info, tui_set_exec_info_content)
5711         (tui_alloc_source_buffer, tui_line_is_displayed)
5712         (tui_addr_is_displayed): Update.
5713         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5714         (tui_check_and_display_highlight_if_needed)
5715         (tui_win_info::make_visible, tui_win_info::refresh)
5716         (tui_refresh_all): Update.
5717         * tui/tui-windata.c (tui_first_data_item_displayed)
5718         (tui_delete_data_content_windows, tui_erase_data_content)
5719         (tui_display_all_data, tui_data_window::refresh_all)
5720         (tui_check_data_values): Update.
5721         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5722         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5723         (tui_win_info::backward_scroll, tui_refresh_all_win)
5724         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5725         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5726         (tui_source_window_base::set_new_height)
5727         (tui_data_window::set_new_height)
5728         (make_invisible_and_set_new_height)
5729         (make_visible_with_new_height, new_height_ok)
5730         (parse_scrolling_args): Update.
5731         * tui/tui-stack.c (tui_show_frame_info): Update.
5732         * tui/tui-source.c (tui_set_source_content)
5733         (tui_set_source_content_nil, tui_source_is_displayed)
5734         (tui_source_window::do_scroll_vertical): Update.
5735         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5736         (tui_display_registers_from, tui_display_reg_element_at_line)
5737         (tui_check_register_values, tui_reg_command): Update.
5738         * tui/tui-layout.c (tui_default_win_height)
5739         (show_source_disasm_command, show_data, init_and_make_win)
5740         (show_source_or_disasm_and_command): Update.
5741         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5742         (tui_redisplay_readline, tui_mld_flush)
5743         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5744         (tui_getc): Update.
5745         * tui/tui-disasm.c (tui_set_disassem_content)
5746         (tui_disasm_window::do_scroll_vertical): Update.
5747         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5748         Now virtual.
5749         (struct tui_win_info): Derive from tui_gen_win_info.
5750         <~tui_win_info>: Mark as override.
5751         <generic>: Remove member.
5752         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5753         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5754         (~tui_data_window, ~tui_win_info)
5755         (tui_free_all_source_wins_content): Update.
5756         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5757
5758 2019-06-25  Tom Tromey  <tom@tromey.com>
5759
5760         * tui/tui-layout.c (init_and_make_win): Use new.
5761         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5762         destructor, initializers.
5763         (tui_alloc_generic_win_info): Don't declare.
5764         * tui/tui-data.c (_locator): Add argument to constructor.
5765         (source_win, disasm_win): New globals.
5766         (exec_info): Remove.
5767         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5768         Update.
5769         (tui_alloc_generic_win_info): Remove.
5770         (init_content_element): Use new.
5771         (tui_win_info::tui_win_info): Update.
5772         (free_content_elements) <case DATA_WIN>: Use delete.
5773
5774 2019-06-25  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5777         * tui/tui-windata.c (tui_first_data_item_displayed)
5778         (tui_delete_data_content_windows): Update.
5779         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5780         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5781         (tui_display_registers_from, tui_check_register_values): Update.
5782         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5783         pointer.
5784         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5785         window.
5786         (tui_free_data_content): Update.
5787         (free_content_elements) <case DATA_WIN>: Free the window.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5792         Update.
5793         * tui/tui-layout.c (make_command_window)
5794         (show_source_disasm_command, show_data, init_and_make_win)
5795         (show_source_or_disasm_and_command): Update.
5796         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5797         method.
5798         <can_highight, is_highlighted>: Now bool.
5799         (tui_set_win_highlight): Don't declare.
5800         * tui/tui-data.c (tui_set_win_highlight): Remove.
5801
5802 2019-06-25  Tom Tromey  <tom@tromey.com>
5803
5804         * tui/tui-wingeneral.c (make_visible): Remove check of window
5805         type.
5806
5807 2019-06-25  Tom Tromey  <tom@tromey.com>
5808
5809         * tui/tui-win.c (tui_win_info::max_height)
5810         (tui_cmd_window::max_height): New methods.
5811         (new_height_ok): Call max_height.
5812         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5813         <max_height>: New method.
5814
5815 2019-06-25  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui-win.c (tui_source_window_base::set_new_height)
5818         (tui_data_window::set_new_height): New methods.
5819         (make_invisible_and_set_new_height): Call set_new_height method.
5820         * tui/tui-data.h (struct tui_win_info)
5821         (struct tui_source_window_base, struct tui_data_window)
5822         <set_new_height>: New method.
5823
5824 2019-06-25  Tom Tromey  <tom@tromey.com>
5825
5826         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5827         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5828         tui_refresh_data_win.
5829         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5830         method.
5831         (tui_refresh_all_win): Call the refresh_all method.
5832         (tui_set_focus): Likewise.
5833         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5834         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5835         Likewise.
5836
5837 2019-06-25  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-winsource.h (tui_refill_source_window)
5840         (tui_set_is_exec_point_at): Don't declare.
5841         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5842         (tui_source_window_base::refill): Rename from
5843         tui_refill_source_window.
5844         (tui_source_window_base::do_scroll_horizontal): Update.
5845         (tui_source_window_base::set_is_exec_point_at): Rename from
5846         tui_set_is_exec_point_at.
5847         (tui_update_all_breakpoint_info): Update.
5848         * tui/tui-stack.c (tui_show_frame_info): Update.
5849         * tui/tui-layout.c (show_data): Add cast.
5850         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5851         * tui/tui-data.h (struct tui_source_window_base) <refill,
5852         set_is_exec_point_at>: New methods.
5853         (tui_source_windows, tui_add_to_source_windows): Update types.
5854         (tui_add_to_source_windows): Remove redundant declaration.
5855         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5856         (tui_source_windows): Change return type.
5857         (tui_clear_source_windows_detail): Update.
5858         (tui_add_to_source_windows): Change type of parameter.
5859         (tui_free_all_source_wins_content): Update.
5860
5861 2019-06-25  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-wingeneral.c (tui_win_info::refresh)
5864         (tui_source_window_base::refresh): New methods.
5865         (tui_refresh_all): Call the refresh method.
5866         * tui/tui-data.h (struct tui_win_info)
5867         (struct tui_source_window_base) <refresh>: New method.
5868
5869 2019-06-25  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui.h (tui_is_window_visible): Return bool.
5872         * tui/tui.c (tui_is_window_visible): Return bool.
5873         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5874         (tui_make_visible, tui_make_invisible)
5875         (tui_win_info::make_visible)
5876         (tui_source_window_base::make_visible, make_all_visible)
5877         (tui_make_all_visible, tui_make_all_invisible): Update.
5878         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5879         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5880         bool.
5881         (struct tui_win_info, struct tui_source_window_base)
5882         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5883         * tui/tui-data.c (tui_init_generic_part): Update.
5884
5885 2019-06-25  Tom Tromey  <tom@tromey.com>
5886
5887         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5888         (tui_source_window_base::make_visible): New methods.
5889         (make_all_visible): Make method call.
5890         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5891         (struct tui_source_window_base, struct tui_cmd_window): Override
5892         make_visible.
5893         (tui_win_is_source_type): Don't declare.
5894         * tui/tui-data.c (tui_win_is_source_type): Remove.
5895
5896 2019-06-25  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5899         NULL check.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5904         Inline constructor.  Add initializers for members.
5905         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5906         constructors; now inline in class.
5907
5908 2019-06-25  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-regs.c (tui_show_registers): Update.
5911         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5912         bool.
5913         * tui/tui-data.c (tui_data_window::clear_detail)
5914         (tui_data_window): Update.
5915
5916 2019-06-25  Tom Tromey  <tom@tromey.com>
5917
5918         * tui/tui-windata.c (tui_display_all_data)
5919         (tui_display_data_from_line, tui_display_data_from)
5920         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5921         Update.
5922         * tui/tui-regs.c (tui_last_regs_line_no)
5923         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5924         (tui_show_registers, tui_show_register_group)
5925         (tui_display_registers_from, tui_display_reg_element_at_line)
5926         (tui_display_registers_from_line, tui_check_register_values)
5927         (tui_reg_next, tui_reg_prev): Update.
5928         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5929         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5930         tui_data_window.
5931         (struct tui_win_info) <detail>: Remove.  Add new fields from
5932         tui_data_info.
5933         (TUI_DATA_WIN): Add cast.
5934         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5935         (~tui_data_window): Simplify.
5936
5937 2019-06-25  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-layout.c (show_source_disasm_command)
5940         (show_source_or_disasm_and_command): Update.
5941         * tui/tui-io.c (update_cmdwin_start_line)
5942         (tui_redisplay_readline): Update.
5943         * tui/tui-data.h (struct tui_command_info): Remove.
5944         (struct tui_win_info) <detail>: Remove command_info member.
5945         (struct tui_data_window) <start_line>: New member, from
5946         tui_command_info.
5947         (TUI_CMD_WIN): Add casts.
5948
5949 2019-06-25  Tom Tromey  <tom@tromey.com>
5950
5951         * tui/tui-winsource.c (tui_update_source_window)
5952         (tui_refill_source_window)
5953         (tui_source_window_base::do_scroll_horizontal)
5954         (tui_update_breakpoint_info, tui_set_exec_info_content)
5955         (tui_show_exec_info_content, tui_erase_exec_info_content)
5956         (tui_clear_exec_info_content): Update.
5957         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5958         Update.
5959         * tui/tui-win.c (make_invisible_and_set_new_height)
5960         (make_visible_with_new_height): Update.
5961         * tui/tui-source.c (tui_set_source_content)
5962         (tui_show_symtab_source): Update.
5963         * tui/tui-layout.c (extract_display_start_addr)
5964         (show_source_disasm_command, show_data)
5965         (make_source_or_disasm_window)
5966         (show_source_or_disasm_and_command): Update.
5967         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5968         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5969         "gdbarch".
5970         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5971         to tui_source_window_base.
5972         (struct tui_win_info) <detail>: Remove source_info member.
5973         (struct tui_source_window_base) <has_locator>: Inline.
5974         Move contents from tui_source_info; rename has_locator member to
5975         m_has_locator.
5976         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5977         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5978         header file.
5979         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5980         Simplify.
5981         (tui_free_all_source_wins_content): Cast to
5982         tui_source_window_base.
5983
5984 2019-06-25  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-win.c (make_invisible_and_set_new_height)
5987         (make_visible_with_new_height): Call has_locator method.
5988         * tui/tui-layout.c (show_source_disasm_command, show_data)
5989         (show_source_or_disasm_and_command): Update for bool change.
5990         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5991         (tui_win_info) <has_locator>: New method.
5992         (struct tui_source_window_base) <has_locator>: New method.
5993         (tui_win_has_locator): Don't declare.
5994         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5995         from tui_win_has_locator.
5996         (tui_source_window_base): Use false, not FALSE.
5997
5998 2019-06-25  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6001         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6002         clear_detail method directly.
6003         (tui_clear_win_detail): Remove.
6004
6005 2019-06-25  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6008         "this", not TUI_DISASM_WIN.
6009
6010 2019-06-25  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6013         declare.
6014         * tui/tui-winsource.c
6015         (tui_source_window_base::do_scroll_horizontal): Rename from
6016         tui_horizontal_source_scroll.
6017         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6018         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6019         from tui_vertical_data_scroll.
6020         * tui/tui-win.h (tui_scroll): Don't declare.
6021         * tui/tui-win.c (tui_win_info::forward_scroll)
6022         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6023         (tui_win_info::right_scroll): Rename and update.
6024         (tui_scroll_forward_command, tui_scroll_backward_command)
6025         (tui_scroll_left_command, tui_scroll_right_command): Update.
6026         (tui_scroll): Remove.
6027         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6028         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6029         from tui_vertical_source_scroll.
6030         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6031         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6032         from tui_vertical_disassem_scroll.
6033         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6034         do_scroll_horizontal>: New methods.
6035         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6036         Likewise.
6037         (struct tui_source_window_base): Add do_scroll_horizontal.
6038         (struct tui_source_window, struct tui_disasm_window): Add
6039         do_scroll_vertical.
6040         (struct tui_data_window, struct tui_cmd_window): Add
6041         do_scroll_horizontal and do_scroll_vertical.
6042         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6043
6044 2019-06-25  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-data.h (struct tui_source_window_base): New struct.
6047         (struct tui_source_window): Derive from tui_source_window_base.
6048         (struct tui_disasm_window): New struct.
6049         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6050         from tui_source_window::clear_detail.
6051         (tui_source_window_base): Rename from tui_source_window.
6052         (~tui_source_window_base): Rename from ~tui_source_window.
6053         (tui_alloc_win_info): Create a tui_disasm_window.
6054
6055 2019-06-25  Tom Tromey  <tom@tromey.com>
6056
6057         * tui/tui-data.h (struct tui_source_window)
6058         (struct tui_data_window): Declare destructors.
6059         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6060         destructors.
6061         (tui_win_info): Simplify.
6062
6063 2019-06-25  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-winsource.c (tui_display_main)
6066         (tui_update_source_windows_with_addr)
6067         (tui_update_all_breakpoint_info): Update.
6068         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6069         (new_height_ok, parse_scrolling_args): Update.
6070         * tui/tui-stack.c (tui_show_frame_info): Update.
6071         * tui/tui-data.h (struct tui_list): Remove.
6072         (tui_source_windows): Return a reference to a std::vector.
6073         * tui/tui-data.c (source_windows): Now a std::vector.
6074         (tui_source_windows): Change return type.
6075         (tui_clear_source_windows): Rewrite.
6076         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6077         (tui_free_all_source_wins_content): Rewrite.
6078
6079 2019-06-25  Tom Tromey  <tom@tromey.com>
6080
6081         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6082         (struct tui_data_window, struct tui_cmd_window): Declare
6083         clear_detail method.
6084         * tui/tui-data.c (tui_source_window::clear_detail)
6085         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6086         methods.
6087         (tui_clear_win_detail): Simplify.
6088
6089 2019-06-25  Tom Tromey  <tom@tromey.com>
6090
6091         * tui/tui-layout.c (make_source_window, make_disasm_window)
6092         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6093         Return the new window.
6094         (show_source_disasm_command, show_data)
6095         (show_source_or_disasm_and_command): Update.
6096
6097 2019-06-25  Tom Tromey  <tom@tromey.com>
6098
6099         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6100         parameter.  Return the new window.
6101         (show_source_disasm_command): Update and remove NULL check.
6102         (show_source_or_disasm_and_command): Update.
6103
6104 2019-06-25  Tom Tromey  <tom@tromey.com>
6105
6106         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6107
6108 2019-06-25  Tom Tromey  <tom@tromey.com>
6109
6110         * tui/tui-data.h (struct tui_win_info): Make constructor
6111         protected.  Make destructor virtual.  Add initializers.
6112         (tui_source_window, tui_data_window, tui_cmd_window): New
6113         classes.
6114         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6115         constructor.  Add "type" parameter.
6116         (tui_source_window, tui_data_window, tui_cmd_window): New
6117         constructors.
6118         (tui_alloc_win_info): Instantiate the appropriate subclass.
6119
6120 2019-06-25  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-win.c (tui_resize_all): Use delete.
6123         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6124         destructor.
6125         (tui_free_window): Don't declare.
6126         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6127         Update.
6128
6129 2019-06-25  Tom Tromey  <tom@tromey.com>
6130
6131         * tui/tui-data.h (struct tui_win_info): Add constructor.
6132         * tui/tui-data.c (tui_alloc_win_info): Use new.
6133         (tui_free_window): Use delete.
6134
6135 2019-06-22  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6138         declare.
6139         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6140
6141 2019-06-22  Tom Tromey  <tom@tromey.com>
6142
6143         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6144         declare.
6145         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6146
6147 2019-06-22  Tom de Vries  <tdevries@suse.de>
6148
6149         * dwarf2read.c (create_addrmap_from_aranges)
6150         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6151         instead of '%zu'.
6152
6153 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6154
6155         * dwarf2read.h (dwarf2_section_info_def): Remove.
6156         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6157         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6158         std::vector<dwarf2_section_info>.
6159         (struct dwo_file) <~dwo_file>: Remove.
6160         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6161         types field.
6162         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6163         (dwarf2_read_debug_names): Likewise.
6164         (create_debug_types_hash_table): Change parameter type to
6165         array_view, adjust code accordingly.
6166         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6167         (partial_die_info::fixup): Likewise.
6168         (determine_prefix): Likewise.
6169         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6170
6171 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6172
6173         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6174         gdb_bfd_ref_ptr.
6175         <~dwo_file>: Remove call to gdb_bfd_unref.
6176         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6177         gdb_bfd_ref_ptr::get.
6178
6179 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6180
6181         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6182         type to htab_up.
6183         * dwarf2read.c (struct dwo_file): Initialize fields.
6184         <~dwo_file>: New.
6185         (free_dwo_file): Remove, move content to ~dwo_file.
6186         (struct dwo_file_deleter): Remove.
6187         (dwo_file_up>: Remove custom deleter.
6188         (free_dwo_files): Remove.
6189         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6190         dwo_files.
6191         (process_skeletonless_type_units): Call unique_ptr::get.
6192         (allocate_dwo_file_hash_table): Add deleter to created hash
6193         table.  Change return type to htab_up.
6194         (lookup_dwo_file_slot): Don't memset dwo_file, call
6195         unique_ptr::get.
6196         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6197         (create_dwo_unit_in_dwp_v2): Likewise.
6198         (open_and_init_dwo_file): Likewise.
6199         (free_dwo_file_from_slot): Remove.
6200
6201 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6202
6203         * dwarf2read.h (struct dwarf2_section_info) <readin,
6204         is_virtual>: Change type to bool.
6205         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6206         true instead of 1.
6207
6208 2019-06-19  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui-data.h (tui_init_content_element): Don't declare.
6211
6212 2019-06-19  Tom Tromey  <tom@tromey.com>
6213
6214         * tui/tui-data.h (tui_init_win_info): Don't declare.
6215
6216 2019-06-19  Tom de Vries  <tdevries@suse.de>
6217
6218         * dwarf2read.h (abstract_to_concrete): Change type to
6219         std::unordered_map<sect_offset, std::vector<sect_offset>,
6220         gdb::hash_enum<sect_offset>>.
6221
6222 2019-06-19  Tom Tromey  <tromey@adacore.com>
6223
6224         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6225         EVAL_AVOID_SIDE_EFFECTS specially.
6226
6227 2019-06-19  Tom Tromey  <tromey@adacore.com>
6228
6229         * source-cache.c (highlighter): New global.
6230         (source_cache::get_source_lines): Create a highlighter on demand.
6231
6232 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * defs.h (deprecated_interactive_hook): Delete declaration.
6235         * interps.c (clear_interpreter_hooks): Remove use of
6236         deprecated_interactive_hook.
6237         * top.c (deprecated_interactive_hook): Delete definition.
6238         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6239
6240 2019-06-18  Tom de Vries  <tdevries@suse.de>
6241
6242         PR gdb/24515
6243         * dwarf2read.h (abstract_to_concrete): Change type from
6244         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6245         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6246         * dwarf2read.c (read_variable): Update.
6247         (dwarf2_fetch_die_loc_sect_off): Update.
6248
6249 2019-06-17  Tom de Vries  <tdevries@suse.de>
6250
6251         PR gdb/24617
6252         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6253         accessing parent[parent_len - 1].
6254
6255 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6256
6257         PR gdb/24364
6258         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6259         call dtrace_process_dof with NULL dof.
6260
6261 2019-06-16  Tom de Vries  <tdevries@suse.de>
6262
6263         PR gdb/24445
6264         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6265
6266 2019-06-16  Tom Tromey  <tom@tromey.com>
6267
6268         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6269         (make_all_visible): Use address of member.
6270
6271 2019-06-16  Tom Tromey  <tom@tromey.com>
6272
6273         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6274         (tui_free_window, free_content, free_content_elements): Remove
6275         unnecessary cast.
6276         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6277         cast.
6278         * tui/tui-regs.c (tui_show_register_group)
6279         (tui_display_registers_from, tui_display_reg_element_at_line):
6280         Remove unnecessary cast.
6281
6282 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * linux-nat.c (normal_mask): Delete.
6285         (_initialize_linux_nat): Don't initialise normal_mask.
6286
6287 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6288
6289         PR gdb/24445
6290         * dwarf-index-write.h (write_psymtabs_to_index): Add
6291         dwz_basename parameter.
6292         * dwarf-index-write.c (write_gdbindex): Move file writing to
6293         write_gdbindex_1.  Change return type void.
6294         (assert_file_size): Move up, remove filename parameter.
6295         (write_gdbindex_1): New function.
6296         (write_debug_names): Change return type to void, call
6297         assert_file_size.
6298         (struct index_wip_file): New struct.
6299         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6300         file logic to index_wip_file.  Write index for dwz file if
6301         needed.
6302         (save_gdb_index_command): Pass basename of dwz file, if present.
6303         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6304         build-id of dwz file, if present.
6305         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6306         (dwarf2_get_dwz_file): Likewise.
6307         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6308         (dwarf2_get_dwz_file): Likewise.
6309
6310 2019-06-16  Tom Tromey  <tom@tromey.com>
6311
6312         * coffread.c (process_coff_symbol): Use xstrdup.
6313         * value.c (create_internalvar): Use xstrdup.
6314
6315 2019-06-16  Tom Tromey  <tom@tromey.com>
6316
6317         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6318         * breakpoint.c (stopin_command, stopat_command)
6319         (until_break_command, decode_location_default): Remove unnecessary
6320         cast.
6321         * utils.c (subset_compare): Remove unnecessary cast.
6322         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6323         cast.
6324         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6325         cast.
6326         * infcmd.c (path_command): Remove unnecessary cast.
6327         * coffread.c (decode_type): Remove unnecessary cast.
6328         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6329         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6330         * tui/tui-stack.c (tui_show_locator_content)
6331         (tui_show_frame_info): Remove unnecessary cast.
6332         * tui/tui-win.c (tui_scroll_forward_command)
6333         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6334         (parse_scrolling_args): Remove unnecessary cast.
6335         * tui/tui-data.c (init_win_info, tui_del_window)
6336         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6337         (free_content_elements): Remove unnecessary cast.
6338         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6339         unnecessary cast.
6340         * tui/tui-source.c (tui_set_source_content)
6341         (tui_vertical_source_scroll): Remove unnecessary cast.
6342         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6343         cast.
6344         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6345         * tui/tui-regs.c (tui_display_registers_from)
6346         (tui_display_register): Remove unnecessary cast.
6347         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6348         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6349         (make_visible): Remove unnecessary cast.
6350         * tui/tui-winsource.c (tui_erase_source_content)
6351         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6352         unnecessary cast.
6353         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6354         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6355         * stabsread.c (read_type, read_array_type, read_range_type):
6356         Remove unnecessary cast.
6357         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6358         (parse_symbol, parse_type, upgrade_type, parse_external)
6359         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6360         unnecessary cast.
6361         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6362
6363 2019-06-16  Tom Tromey  <tom@tromey.com>
6364
6365         * tui/tui-data.c (tui_alloc_generic_win_info)
6366         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6367         checks.
6368
6369 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6370             Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * f-typeprint.c (f_print_type): Don't return early for not
6373         associated or not allocated types.
6374         (f_type_print_varspec_suffix): Add print_rank parameter and print
6375         ranks of array types in case they dangling.
6376         (f_type_print_base): Add print_rank parameter.
6377
6378 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * NEWS: Mention new MI commands.
6381         * break-catch-throw.c (enum exception_event_kind): Move to
6382         breakpoint.h.
6383         (print_mention_exception_catchpoint): Output text as a single
6384         message.
6385         (catch_exception_command_1): Rename to...
6386         (catch_exception_event): ...this, make non-static, update header
6387         command, and change some parameter types.
6388         (catch_catch_command): Update for changes to
6389         catch_exception_command_1.
6390         (catch_throw_command): Likewise.
6391         (catch_rethrow_command): Likewise.
6392         * breakpoint.c (enum exception_event_kind): Delete.
6393         * breakpoint.h (enum exception_event_kind): Moved here from
6394         break-catch-throw.c.
6395         (catch_exception_event): Declare.
6396         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6397         (mi_cmd_catch_throw): New function.
6398         (mi_cmd_catch_rethrow): New function.
6399         (mi_cmd_catch_catch): New function.
6400         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6401         'catch-catch' entries.
6402         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6403         (mi_cmd_catch_rethrow): Declare.
6404         (mi_cmd_catch_catch): Declare.
6405
6406 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * annotate.c (annotate_source_line): Change return type to void,
6409         update implementation to match.
6410         * annotate.h (annotate_source_line): Change return type to void,
6411         update header comment.
6412         * stack.c (print_frame_info): Don't change what frame information
6413         is printed based on whether annotations are on or not.
6414
6415 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6418         (annotate_source): Make static.
6419         (annotate_source_line): Moved from source.c and renamed from
6420         identify_source_line.  Update the return type.
6421         * annotate.h (annotate_source): Delete declaration.
6422         (annotate_source_line): Declaration moved from source.h, and
6423         renamed from identify_source_line.  Return type updated.
6424         * source.c (identify_source_line): Moved to annotate.c and renamed
6425         to annotate_source_line.
6426         (info_line_command): Remove check of annotation_level.
6427         * source.h (identify_source_line): Move declaration to annotate.h
6428         and rename to annotate_source_line.
6429         * stack.c: Add 'annotate.h' include.
6430         (print_frame_info): Remove check of annotation_level before
6431         calling annotate_source_line.
6432
6433 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * source-cache.c (source_cache::get_plain_source_lines): Use
6436         open_source_file_with_line_charpos instead of just
6437         open_source_file, remove call to find_source_lines.
6438         (source_cache::get_source_lines): Likewise.
6439         * source.c (find_source_lines): Make static.
6440         (get_filename_and_charpos): Renamed into...
6441         (open_source_file_with_line_charpos): ..this along with changes to
6442         return a scoped_fd, and some other minor clean ups.
6443         (identify_source_line): Use open_source_file_with_line_charpos.
6444         (search_command_helper): Use open_source_file_with_line_charpos
6445         instead of just open_source_file, remove call to
6446         find_source_lines.
6447         * source.h (open_source_file_with_line_charpos): Declare new
6448         function.
6449         (find_source_lines): Delete declaration.
6450
6451 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * source.c (get_filename_and_charpos): Remove fullname
6454         parameter.
6455         (identify_source_line): Update call to get_filename_and_charpos.
6456
6457 2019-06-14  Tom Tromey  <tromey@adacore.com>
6458
6459         PR gdb/24502:
6460         * ui-style.h (skip_ansi_escape): Update comment.
6461         * ui-file.h (class no_terminal_escape_file): New class.
6462         * ui-file.c (no_terminal_escape_file::write)
6463         (no_terminal_escape_file::puts): New methods.
6464         * cli/cli-logging.c (handle_redirections): Use
6465         no_terminal_escape_file.
6466
6467 2019-06-14  Tom Tromey  <tromey@adacore.com>
6468
6469         * NEWS: Move convenience variable news above Python news.
6470
6471 2019-06-14  Tom Tromey  <tom@tromey.com>
6472
6473         * gnulib: Move directory to top-level.
6474         * configure.ac: Don't configure gnulib.
6475         * configure: Rebuild.
6476         * common/common-defs.h: Use new path to gnulib.
6477         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6478         (GNULIB_H): Remove.
6479         (INCGNU): Look in new gnulib location.
6480         (HFILES_NO_SRCDIR): Remove gnulib files.
6481         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6482         (generated_files): Remove GNULIB_H.
6483         ($(LIBGNU), all-lib): Remove targets.
6484         (distclean): Don't mention GNULIB_BUILDDIR.
6485         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6486
6487 2019-06-14  Tom Tromey  <tromey@adacore.com>
6488
6489         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6490         Warn if symbol file does not provide any symbols.
6491
6492 2019-06-14  Tom Tromey  <tromey@adacore.com>
6493
6494         * source.c (find_and_open_source): Respect basenames_may_differ.
6495
6496 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * annotate.c (annotate_breakpoints_invalid): Make use of
6499         scoped_restore_terminal_state.
6500         (annotate_frames_invalid): Likewise.
6501
6502 2019-06-14  Tom Tromey  <tromey@adacore.com>
6503
6504         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6505         allow assignment to an internalvar.
6506
6507 2019-06-14  Tom Tromey  <tromey@adacore.com>
6508
6509         * ada-lex.l: Allow "_" in attribute names.
6510
6511 2019-06-14  Tom Tromey  <tromey@adacore.com>
6512
6513         PR gdb/24653:
6514         * regcache.c (registers_changed): Don't call alloca.
6515         * top.c (execute_command): Don't call alloca.
6516
6517 2019-06-13  Pedro Alves  <palves@redhat.com>
6518
6519         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6520         'expression'.  When parsing an expression, error out if there's
6521         junk after "unlimited".
6522         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6523         (do_set_command): Adjust calls to is_unlimited_literal.
6524
6525 2019-06-13  Pedro Alves  <palves@redhat.com>
6526
6527         * compile/compile.c (make_compile_options_def_group): Add braces
6528         around array_view initializer.
6529         * thread.c (make_thread_apply_all_options_def_group)
6530         (make_thread_apply_all_options_def_group): Likewise.
6531
6532 2019-06-13  Pedro Alves  <palves@redhat.com>
6533
6534         * NEWS (New commands): Mention "maint test-options
6535         require-delimiter", "maint test-options unknown-is-error", "maint
6536         test-options unknown-is-operand" and "maint show
6537         test-options-completion-result".
6538         (New command options, command completion): New section.
6539         (Completion improvements): New section.
6540         Mention that you can abbreviate "unlimited".
6541
6542 2019-06-13  Pedro Alves  <palves@redhat.com>
6543
6544         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6545         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6546         * unittests/cli-utils-selftests.c (test_parse_flags)
6547         (test_parse_flags_qcs): Delete.
6548         (test_cli_utils): Don't call deleted functions.
6549
6550 2019-06-13  Pedro Alves  <palves@redhat.com>
6551
6552         * thread.c: Include "cli/cli-option.h".
6553         (tp_array_compar_ascending): Global.
6554         (tp_array_compar): Delete function.
6555         (tp_array_compar_ascending, tp_array_compar_descending): New
6556         functions.
6557         (ascending_option_def, qcs_flag_option_def)
6558         (thr_qcs_flags_option_defs)
6559         (make_thread_apply_all_options_def_group)
6560         (make_thread_apply_options_def_group): New.
6561         (thread_apply_all_command): Use gdb::option::process_options.
6562         (thread_apply_command_completer)
6563         (thread_apply_all_command_completer): New.
6564         (thread_apply_command): Use gdb::option::process_options.
6565         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6566         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6567         to generate help text of "thread apply".  Adjust "taas"'s help.
6568         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6569         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6570
6571 2019-06-13  Pedro Alves  <palves@redhat.com>
6572
6573         * thread.c (thread_apply_command): Check for invalid TID with
6574         isdigit instead of !isalpha.
6575
6576 2019-06-13  Pedro Alves  <palves@redhat.com>
6577
6578         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6579         (validate_flags_qcs): New.
6580         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6581         (validate_flags_qcs): Declare.
6582         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6583         (make_frame_apply_options_def_group): New.
6584         (frame_apply_command_count): Process options with
6585         gdb::option::process_options.
6586         (frame_apply_completer): New.
6587         (frame_apply_level_completer, frame_apply_all_completer)
6588         (frame_apply_completer): New.
6589         (_initialize_stack): Update help of "frame apply", "frame apply
6590         level", "frame apply all" and "faas" to mention supported options
6591         and install command completers.
6592         * stack.h (frame_apply_all_completer): Declare.
6593         * thread.c: Include "stack.h".
6594         (tfaas_command): Add "--".
6595         (_initialize_thread): Update help "tfaas" to mention supported
6596         options and install command completer.
6597
6598 2019-06-13  Pedro Alves  <palves@redhat.com>
6599
6600         * completer.c (complete_nested_command_line): New.
6601         (gdb_completion_word_break_characters_throw): Add assertion.
6602         * completer.h (complete_nested_command_line): Declare.
6603
6604 2019-06-13  Pedro Alves  <palves@redhat.com>
6605
6606         * stack.c (parse_backtrace_qualifiers): New.
6607         (backtrace_command): Use it.
6608         (backtrace_command_completer): Complete on qualifiers.
6609
6610 2019-06-13  Pedro Alves  <palves@redhat.com>
6611
6612         * frame.c: Include "cli/cli-option.h.
6613         (user_set_backtrace_options): New.
6614         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6615         Delete.
6616         (get_prev_frame): Adjust.
6617         (boolean_option_def, uinteger_option_def)
6618         (set_backtrace_option_defs): New.
6619         (_initialize_frame): Adjust and use
6620         gdb::option::add_setshow_cmds_for_options to install "set
6621         backtrace past-main" and "set backtrace past-entry".
6622         * frame.h: Include "cli/cli-option.h".
6623         (struct frame_print_options): Forward declare.
6624         (print_frame_arguments_all, print_frame_arguments_scalars)
6625         (print_frame_arguments_none): Declare.
6626         (print_entry_values): Delete declaration.
6627         (struct frame_print_options, user_frame_print_options): New.
6628         (struct set_backtrace_options): New.
6629         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6630         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6631         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6632         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6633         (list_args_or_locals): Add frame_print_options parameter.
6634         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6635         * python/py-framefilter.c (enumerate_args): Pass down
6636         USER_FRAME_PRINT_OPTIONS.
6637         * stack.c: Include "cli/cli-option.h".
6638         (print_frame_arguments_all, print_frame_arguments_scalars)
6639         (print_frame_arguments_none): Declare.
6640         (print_raw_frame_arguments, print_entry_values): Delete.
6641         (user_frame_print_options): New.
6642         (boolean_option_def, enum_option_def, frame_print_option_defs):
6643         New.
6644         (struct backtrace_cmd_options): New.
6645         (bt_flag_option_def): New.
6646         (backtrace_command_option_defs): New.
6647         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6648         (print_frame_arg, read_frame_arg, print_frame_args)
6649         (print_frame_info, print_frame): Add frame_print_options parameter
6650         and use it.
6651         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6652         (backtrace_command_1): Add frame_print_options and
6653         backtrace_cmd_options parameters and use them.
6654         (make_backtrace_options_def_group): New.
6655         (backtrace_command): Process command options with
6656         gdb::option::process_options.
6657         (backtrace_command_completer): New.
6658         (_initialize_stack): Extend "backtrace"'s help to mention
6659         supported options.  Install completer for "backtrace".
6660         Install some settings commands with add_setshow_cmds_for_options.
6661
6662 2019-06-13  Pedro Alves  <palves@redhat.com>
6663
6664         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6665         and that "set/show print raw frame-arguments" are now deprecated.
6666
6667         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6668         command.
6669         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6670         * stack.c (_initialize_stack): Install "set/show print
6671         raw-frame-arguments", and deprecate "set/show print raw
6672         frame-arguments".
6673         * valprint.c (_initialize_valprint): Deprecate "set/show print
6674         raw".
6675
6676 2019-06-13  Pedro Alves  <palves@redhat.com>
6677
6678         * compile/compile.c (struct compile_options): New.
6679         (compile_flag_option_def, compile_command_option_defs)
6680         (make_compile_options_def_group): New.
6681         (compile_file_command): Handle options with
6682         gdb::option::process_options.
6683         (compile_file_command_completer): New function.
6684         (compile_code_command): Handle options with
6685         gdb::option::process_options.
6686         (compile_code_command_completer): New function.
6687         (_initialize_compiler): Install completers for "compile code" and
6688         "compile file".  Mention available options in "compile code" and
6689         "compile code"'s help.
6690         * completer.c (advance_to_completion_word): New, factored out from
6691         ...
6692         (advance_to_expression_complete_word_point): ... this.
6693         (advance_to_filename_complete_word_point): New.
6694         * completer.h (advance_to_filename_complete_word_point): New
6695         declaration.
6696
6697 2019-06-13  Pedro Alves  <palves@redhat.com>
6698
6699         * compile/compile.c: Include "cli/cli-option.h".
6700         (compile_print_value): Scope data pointer is now a
6701         value_print_options pointer; adjust.
6702         (compile_print_command): Process options.  Scope data pointer is
6703         now a value_print_options pointer; adjust.
6704         (_initialize_compile): Update "compile print"'s help to include
6705         supported options.  Install a completer for "compile print".
6706         * cp-valprint.c (show_vtblprint, show_objectprint)
6707         (show_static_field_print): Delete.
6708         (_initialize_cp_valprint): Don't install "set print
6709         static-members", "set print vtbl", "set print object" here.
6710         * printcmd.c: Include "cli/cli-option.h" and
6711         "common/gdb_optional.h".
6712         (print_command_parse_format): Rework to fill in a
6713         value_print_options instead of a format_data.
6714         (print_value): Change parameter type from format_data pointer to
6715         value_print_options reference.  Adjust.
6716         (print_command_1): Process options.  Adjust to pass down a
6717         value_print_options.
6718         (print_command_completer): New.
6719         (_initialize_printcmd): Install print_command_completer as
6720         handle_brkchars completer for the "print" command.  Update
6721         "print"'s help to include supported options.
6722         * valprint.c: Include "cli/cli-option.h".
6723         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6724         here from cp-valprint.c.
6725         (boolean_option_def, uinteger_option_def)
6726         (value_print_option_defs, make_value_print_options_def_group):
6727         New.  Use gdb::option::add_setshow_cmds_for_options to install
6728         "set print elements", "set print null-stop", "set print repeats",
6729         "set print pretty", "set print union", "set print array", "set
6730         print address", "set print symbol", "set print array-indexes".
6731         * valprint.h: Include <string> and "cli/cli-option.h".
6732         (make_value_print_options_def_group): Declare.
6733         (print_value): Change parameter type from format_data pointer to
6734         value_print_options reference.
6735         (print_command_completer): Declare.
6736
6737 2019-06-13  Pedro Alves  <palves@redhat.com>
6738
6739         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6740         (COMMON_SFILES): Add maint-test-settings.c.
6741         * cli/cli-decode.c (boolean_enums): New global, factored out from
6742         ...
6743         (add_setshow_boolean_cmd): ... here.
6744         * cli/cli-decode.h (boolean_enums): Declare.
6745         * cli/cli-option.c: New file.
6746         * cli/cli-option.h: New file.
6747         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6748         factored out from ...
6749         (parse_cli_boolean_value(const char *)): ... this.
6750         (is_unlimited_literal): Change parameter type to pointer to
6751         pointer.  Adjust and advance ARG pointer.
6752         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6753         (parse_cli_var_enum): New, factored out from ...
6754         (do_set_command): ... this.  Adjust.
6755         * cli/cli-setshow.h (parse_cli_boolean_value)
6756         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6757         (parse_cli_var_enum): Declare.
6758         * cli/cli-utils.c: Include "cli/cli-option.h".
6759         (get_ulongest): New.
6760         * cli/cli-utils.h (get_ulongest): Declare.
6761         (check_for_argument): New overloads.
6762         * maint-test-options.c: New file.
6763
6764 2019-06-13  Pedro Alves  <palves@redhat.com>
6765
6766         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6767         parse a range if "-" is at the end of the string.
6768
6769 2019-06-13  Pedro Alves  <palves@redhat.com>
6770
6771         * cli/cli-setshow.c (parse_auto_binary_operation)
6772         (parse_cli_boolean_value): Don't allow "o".
6773
6774 2019-06-13  Pedro Alves  <palves@redhat.com>
6775
6776         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6777         * NEWS: Mention maint test-settings KIND.
6778         * maint-test-settings.c: New file.
6779
6780 2019-06-13  Pedro Alves  <palves@redhat.com>
6781
6782         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6783         completer.
6784         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6785         "set" completers.
6786
6787 2019-06-13  Pedro Alves  <palves@redhat.com>
6788
6789         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6790         after item.
6791
6792 2019-06-13  Pedro Alves  <palves@redhat.com>
6793
6794         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6795
6796 2019-06-13  Pedro Alves <palves@redhat.com>
6797
6798         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6799         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6800         call.
6801         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6802         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6803         calls.
6804         (check_for_argument): Skip spaces after argument.
6805
6806 2019-06-13  Pedro Alves  <palves@redhat.com>
6807
6808         * thread.c (thread_apply_command): Adjust TID parsing.
6809         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6810         detected before end of string.
6811         (tid_is_in_list): Error out if LIST is invalid.
6812
6813 2019-06-13  Pedro Alves  <palves@redhat.com>
6814
6815         * completer.c (complete_line_internal_1): Rewind completion word
6816         point.
6817         (completion_tracker::advance_custom_word_point_by): Change
6818         parameter type to int.
6819         * completer.h (completion_tracker::advance_custom_word_point_by):
6820         Likewise.
6821
6822 2019-06-13  Pedro Alves  <palves@redhat.com>
6823
6824         * completer.c (advance_to_completion_word): Handle delimiters.
6825
6826 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6827
6828         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6829
6830 2019-06-11  Tom Tromey  <tom@tromey.com>
6831
6832         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6833         (xmalloc_failed): Move to alloc.c.
6834         * alloc.c: New file.
6835         * Makefile.in (COMMON_SFILES): Add alloc.c.
6836
6837 2019-06-11  Tom Tromey  <tom@tromey.com>
6838
6839         * nat/linux-waitpid.c: Don't include server.h.
6840         (linux_debug): Remove.
6841         (my_waitpid): Update.
6842
6843 2019-06-11  Tom Tromey  <tromey@adacore.com>
6844
6845         * infcall.c (_initialize_infcall): Remove trailing newline from
6846         help.
6847         * user-regs.c (_initialize_user_regs): Remove trailing newline
6848         from help.
6849         * typeprint.c (_initialize_typeprint): Remove trailing newline
6850         from help.
6851         * reverse.c (_initialize_reverse): Remove trailing newlines from
6852         help.
6853         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6854         from help.
6855         * language.c (add_set_language_command): Remove trailing newline
6856         from help.
6857         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6858         help.
6859         * disasm.c (_initialize_disasm): Remove trailing newline from
6860         help.
6861         * top.c (init_main): Remove trailing newline from help.
6862         * interps.c (_initialize_interpreter): Remove trailing newline
6863         from help.
6864         * btrace.c (_initialize_btrace): Remove trailing newlines from
6865         help.
6866         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6867         from help.
6868         * python/python.c (_initialize_python): Remove trailing newline
6869         from help.
6870         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6871         help.
6872         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6873         from help.  Reformat some text.
6874         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6875         from help.
6876         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6877         newline from help.
6878
6879 2019-06-11  Tom Tromey  <tromey@adacore.com>
6880
6881         * darwin-nat.c (darwin_decode_exception_message)
6882         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6883
6884 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6885
6886         * valops.c (value_slice): Check for not allocated or not
6887         associated values.
6888
6889 2019-06-10  Tom de Vries  <tdevries@suse.de>
6890
6891         PR gdb/24618
6892         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6893         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6894         invalid.
6895
6896 2019-06-10  Tom de Vries  <tdevries@suse.de>
6897
6898         PR gdb/24611
6899         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6900         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6901
6902 2019-06-10  Tom de Vries  <tdevries@suse.de>
6903
6904         PR symtab/24545
6905         * symtab.c (struct demangled_name_entry): Add language field.
6906         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6907         static minimal symbol".  Set and use language field.
6908
6909 2019-06-10  Tom Tromey  <tromey@adacore.com>
6910
6911         * ada-lang.c (_initialize_ada_language): Update help text.
6912
6913 2019-06-10  Tom Tromey  <tromey@adacore.com>
6914
6915         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6916         with a newline.
6917         * guile/guile.c (handle_boot_error): Don't end warning with a
6918         newline.
6919         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6920         warning with a newline.
6921         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6922         newline.
6923         (s12z_frame_cache): Likewise.
6924         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6925         a newline.
6926         * solib-svr4.c (disable_probes_interface): Don't end warning with
6927         a newline.
6928         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6929         newline.
6930         * python/python.c (do_finish_initialization): Don't end warning
6931         with a newline.
6932
6933 2019-06-10  Tom Tromey  <tom@tromey.com>
6934
6935         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6936         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6937         gdbpy_enter.
6938
6939 2019-06-10  Tom Tromey  <tromey@adacore.com>
6940
6941         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6942         data.
6943         (elf_new_init): Don't call stabsread_new_init.
6944         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6945         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6946         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6947
6948 2019-06-10  Tom de Vries  <tdevries@suse.de>
6949
6950         PR symtab/16264
6951         PR symtab/24517
6952         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6953
6954 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6955
6956         * source.c (find_and_open_source): Also rewrite relative file
6957         names.
6958
6959 2019-04-26  Amos Bird  <amosbird@gmail.com>
6960
6961         * annotate.c (annotate_thread_exited): Add "thread-exited"
6962         annotation.
6963
6964 2019-06-06  Tom Tromey  <tromey@adacore.com>
6965
6966         * maint.h (class scoped_command_stats): Use
6967         DISABLE_COPY_AND_ASSIGN.
6968         <print_time>: New method.
6969         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6970         print_time.
6971         (scoped_command_stats::print_time): New method.
6972
6973 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6974
6975         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6976         instructions of lengths 6 or 8 bytes.
6977
6978 2019-06-04  Pedro Alves  <palves@redhat.com>
6979
6980         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6981
6982         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6983         * breakpoint.c (condition_completer): Likewise.
6984         * cli/cli-dump.c (scan_expression): Likewise.
6985         * common/filestuff.c (mkdir_recursive): Likewise.
6986         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6987         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6988         (gdb_abspath): Likewise.
6989         * compile/compile-cplus-types.c
6990         (compile_cplus_instance::decl_name): Likewise.
6991         * completer.c (complete_explicit_location):
6992         (signal_completer, reg_or_group_completer_1): Likewise.
6993         * cp-support.c (cp_remove_params_if_any): Likewise.
6994         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6995         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6996         * infcmd.c (strip_bg_char): Likewise.
6997         * linespec.c (copy_token_string): Likewise.
6998         * mi/mi-main.c (output_cores): Likewise.
6999         * psymtab.c (psymtab_search_name):
7000         * symfile.c (test_set_ext_lang_command): Likewise.
7001         * target.c (target_fileio_read_stralloc): Likewise.
7002         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7003         * value.c (complete_internalvar): Likewise.
7004
7005 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7006
7007         Add objfile property to gdb.Type.
7008         * NEWS: Mention Python API addition.
7009         * python/py-type.c (typy_get_objfile): New method.
7010
7011 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7012
7013         * NEWS: Mention the new set|show style [title|highlight].
7014         Mention changes to "show style", "help" and "apropos".
7015
7016 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7017
7018         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7019         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7020         instead of print_help_for_command.
7021         (print_doc_of_command): New function.
7022         (help_list): Add 'apropos -v word' suggestion.
7023         (print_help_for_command): Style the command name using title style.
7024         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7025         (_initialize_cli_cmds): Describe -v in apropos_command help.
7026
7027 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7028
7029         * cli/cli-style.h (cli_style_option): Add name in constructor,
7030         add m_name class member, add constructor with intensity,
7031         add name class function.
7032         (cli_style_option::add_setshow_commands): Remove name argument.
7033         (highlight_style, title_style): New styles.
7034         * cli/cli-style.c (do_show): New function that shows a style
7035         characteristic styling the style name with itself.
7036         (set_style_name): New function.
7037         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7038         Update all callers according to the changes in cli/cli-style.h.
7039         * utils.h (fputs_highlighted): New function.
7040         * utils.c (fputs_highlighted): Likewise.
7041
7042 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7043
7044         * NEWS: Mention new pipe command and new convenience variables.
7045
7046 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7047
7048         * cli/cli-cmds.c (pipe_command): New function.
7049         (_initialize_cli_cmds): Call add_com for pipe_command.
7050         Define | as an alias for pipe.
7051         (exit_status_set_internal_vars): New function.
7052         (shell_escape): Call exit_status_set_internal_vars.
7053         cli/cli-decode.c (find_command_name_length): Recognize | as
7054         a single character command.
7055
7056 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7057
7058         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7059         top.c (execute_command_to_ui_file): New function, mostly a copy
7060         of execute_command_to_string.
7061         (execute_command_to_string): Implement by calling
7062         execute_command_to_ui_file.
7063
7064 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7065
7066         * top.h (saved_command_line): Remove declaration.
7067         * top.c (previous_saved_command_line, previous_repeat_arguments):
7068         New variables.
7069         (saved_command_line): Make static, define together with other
7070         'repeat variables'.
7071         (dont_repeat): Clear repeat_arguments.
7072         (repeat_previous, get_saved_command_line, save_command_line):
7073         New functions.
7074         (gdb_init): Initialize saved_command_line
7075         and previous_saved_command_line.
7076         * main.c (captured_main_1): Remove saved_command_line initialization.
7077         * event-top.c (handle_line_of_input): Update to use
7078         the new 'repeat' related functions instead of direct access to
7079         saved_command_line.
7080         * command.h (repeat_previous, get_saved_command_line,
7081         save_command_line): New declarations.
7082         (dont_repeat): Add comment.
7083
7084 2019-05-30  Tom Tromey  <tromey@adacore.com>
7085
7086         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7087         Fix comment.
7088         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7089
7090 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7091
7092         PR cli/24587
7093         * completer.c (complete): Initialize variable word.
7094
7095 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7096
7097         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7098         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7099         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7100         'body' is NULL to the outter 'if', protecting the '!is_define'
7101         situation as well.
7102
7103 2019-05-29  Tom Tromey  <tromey@adacore.com>
7104
7105         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7106         (dwarf_unknown): New function.
7107         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7108         (dwarf_type_encoding_name): Use dwarf_unknown.
7109
7110 2019-05-29  Tom Tromey  <tromey@adacore.com>
7111
7112         PR c++/20020:
7113         * cp-valprint.c (cp_print_value_fields): Call
7114         cp_print_static_field inside "try".
7115
7116 2019-05-29  Tom Tromey  <tromey@adacore.com>
7117
7118         * inflow.c (struct terminal_info): Add default operator=.
7119         * configure: Rebuild.
7120         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7121         -Wdeprecated-copy-dtor, -Wredundant-move.
7122
7123 2019-05-29  Tom Tromey  <tromey@adacore.com>
7124
7125         * NEWS: Add entry.
7126         * infcmd.c (print_return_value_1): Handle finish_print
7127         option.
7128         (show_print_finish): New function.
7129         (_initialize_infcmd): Add "set/show print finish" commands.
7130         * valprint.c (user_print_options): Initialize new member.
7131         * valprint.h (struct value_print_options) <finish_print>: New
7132         member.
7133
7134 2019-05-28  Tom Tromey  <tromey@adacore.com>
7135
7136         * ada-lang.c (ada_remove_Xbn_suffix)
7137         (find_old_style_renaming_symbol)
7138         (parse_old_style_renaming): Remove.
7139         (ada_find_renaming_symbol): Don't call
7140         find_old_style_renaming_symbol.
7141         (ada_is_renaming_symbol): Rename from
7142         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7143         bool.  Now static.
7144         (ada_read_var_value): Update and simplify.
7145         * ada-exp.y (write_var_or_type): Remove old code.
7146
7147 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7148
7149         PR gdb/25010
7150         * event-top.c: Remove include comment.
7151         * inflow.c (class scoped_ignore_sigttou): Move from here...
7152         * inflow.h (class scoped_ignore_sigttou): ...to here.
7153         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7154         * top.c:  Remove include comment.
7155
7156 2019-05-27  Tom Tromey  <tom@tromey.com>
7157
7158         * NEWS: Fix typo.
7159
7160 2019-05-22  Tom Tromey  <tromey@adacore.com>
7161
7162         * target.c (target_follow_exec): Constify parameter.
7163         * target-delegates.c: Rebuild.
7164         * remote.c (remote_target::follow_exec): Constify parameter.
7165         * infrun.c (follow_exec): Constify parameter.
7166         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7167         (target_follow_exec): Likewise.
7168
7169 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7170
7171         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7172         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7173
7174 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7175
7176         * NEWS: Add debugredirect and testsuite sections.
7177
7178 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7179
7180         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7181         target descriptions using exclusively floating point register name
7182         aliases.
7183
7184 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         PR gdb/18644:
7187         * f-lang.c (build_fortran_types): Handle the case where
7188         gdbarch_floatformat_for_type returns a nullptr.
7189
7190 2019-05-21  Tom de Vries  <tdevries@suse.de>
7191
7192         PR cli/24587
7193         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7194
7195 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         PR gdb/18644:
7198         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7199         16-byte floats.
7200         * i386-tdep.c (i386_floatformat_for_type): Use
7201         floatformats_ia64_quad for the 16-byte floating point component
7202         within a fortran 32-byte complex number.
7203
7204 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7207         delete default constructor.
7208         (find_partial_die): Update to return const struct.
7209         (partial_die_parent_scope): Move variable declaration into scope
7210         of its use and change its type to auto.
7211         (guess_partial_die_structure_name): Likewise.
7212         (partial_die_info::fixup): Likewise.
7213
7214 2019-05-17  Tom Tromey  <tromey@adacore.com>
7215
7216         * source.c (find_and_open_source): Remove cast.
7217
7218 2019-05-17  Tom Tromey  <tromey@adacore.com>
7219
7220         * annotate.c (annotate_source): Make "filename" const.
7221         * annotate.h (annotate_source): Use const.
7222
7223 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7224
7225         * disasm.c (set_disassembler_options): Send errors to stderr.
7226
7227 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7228
7229         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7230         (cli_interp_base::set_logging): Check debug_redirect.
7231         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7232         * cli/cli-logging.c (debug_redirect): Add static variable.
7233         (pop_output_files): Add default param.
7234         (handle_redirections): Print debug setting.
7235         (show_logging_command): Likewise.
7236         (_initialize_cli_logging): Add debugredirect command.
7237         * interps.c (current_interp_set_logging): Add debug_redirect
7238         parameter.
7239         * interps.h (set_logging): Add debug_redirect parameter.
7240         (current_interp_set_logging): Likewise.
7241         * mi/mi-common.h: Likewise.
7242         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7243
7244 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7245             Tom Tromey  <tromey@adacore.com>
7246
7247         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7248         directly.
7249         * cli/cli-interp.h (make_logging_output): Remove declaration.
7250         * cli/cli-logging.c (make_logging_output): Remove function.
7251         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7252         directly.
7253         * ui-file.c (tee_file::tee_file): Remove bools.
7254         (tee_file::~tee_file): Remove deletes.
7255         * ui-file.h (tee_file): Remove bools.
7256
7257 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7258
7259         * mi/mi-cmds.h (mi_cmd_complete): New function.
7260         * mi/mi-main.c (mi_cmd_complete): Likewise.
7261         * mi/mi-cmds.c: Define new MI command -complete.
7262         * NEWS: Mention new -complete command.
7263
7264 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7265
7266         * completer.h (complete): New function.
7267         * completer.c (complete): Likewise.
7268         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7269         function defined in completer.h.
7270
7271 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7272
7273         * MAINTAINERS (Write After Approval): Add myself.
7274
7275 2019-05-17  Tom de Vries  <tdevries@suse.de>
7276
7277         PR gdb/24094
7278         * dwarf2read.c (struct cu_partial_die_info): New struct.
7279         (find_partial_die): Return cu_partial_die_info.
7280         (partial_die_parent_scope, guess_partial_die_structure_name)
7281         (partial_die_info::fixup): Handle new return type of find_partial_die.
7282
7283 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7284
7285         PR breakpoints/24541
7286         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7287         "std::string", simplifying the algorithm.
7288
7289 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7290
7291         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7292         (stap_static_probe_ops::get_probes): Likewise.
7293
7294 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7295
7296         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7297         '-')" and "else if".
7298         (stap_parse_single_operand): Join checks for
7299         "gdbarch_stap_parse_special_token_p" and
7300         "gdbarch_stap_parse_special_token" in the same "if" statement.
7301         Invert check when verifying for operation on register
7302         displacement.
7303
7304 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7305
7306         * stap-probe.c (stap_get_opcode): Update comment.
7307         (stap_get_expected_argument_type): Likewise.
7308         (handle_stap_probe): Likewise.
7309
7310 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7311
7312         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7313         return type to 'bool'.  Adjust comment.  Use 'bool' when
7314         appropriate.
7315         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7316         * stap-probe.c (stap_parse_argument_1): Likewise.
7317         (stap_is_operator): Likewise.
7318         (stap_is_generic_prefix): Likewise.
7319         (stap_is_register_prefix): Likewise.
7320         (stap_is_register_indirection_prefix): Likewise.
7321         (stap_is_integer_prefix): Likewise.
7322         (stap_generic_check_suffix): Likewise.
7323         (stap_check_integer_suffix): Likewise.
7324         (stap_check_register_suffix): Likewise.
7325         (stap_check_register_indirection_suffix): Likewise.
7326         (stap_parse_register_operand): Likewise.
7327         (stap_parse_single_operand): Likewise.
7328         (stap_parse_argument_1): Likewise.
7329         (stap_probe::get_argument_count): Likewise.
7330         (stap_is_operator): Likewise.
7331
7332 2019-05-16  Tom Tromey  <tromey@adacore.com>
7333
7334         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7335         keyword to foreach.
7336
7337 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7338
7339         * linux-thread-db.c (try_thread_db_load_1): Change return type
7340         to bool.
7341         (try_thread_db_load): Likewise.
7342         (try_thread_db_load_from_pdir_1): Likewise.
7343         (try_thread_db_load_from_pdir): Likewise.
7344         (try_thread_db_load_from_sdir): Likewise.
7345         (try_thread_db_load_from_dir): Likewise.
7346         (thread_db_load_search): Likewise.
7347         (has_libpthread): Likewise.
7348         (thread_db_load): Likewise.
7349
7350 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7351
7352         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7353         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7354         NULL, and complain/return if that's the case.
7355
7356 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7357
7358         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7359         (advance, posn, abstract_read_memory): New functions.
7360         [struct mem_read_abstraction]: New struct.
7361         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7362
7363 2019-05-14  Tom Tromey  <tromey@adacore.com>
7364
7365         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7366         value is not lval_memory.
7367
7368 2019-05-14  Tom Tromey  <tromey@adacore.com>
7369
7370         * solib.c (info_sharedlibrary_command): Style the file name.
7371
7372 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7373
7374         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7375         (aarch64_vnv_type): Likewise.
7376         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7377         * common/tdesc.c: Likewise.
7378         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7379         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7380         * features/aarch64-fpu.xml: Add ieee half view.
7381         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7382         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7383         * gdbtypes.h (struct builtin_type): Likewise.
7384         (struct objfile_type): Likewise.
7385
7386 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7387
7388         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7389         typo.
7390         * location.h (string_to_event_location): Likewise.
7391
7392 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7393
7394         GDB 8.3 released.
7395
7396 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7397
7398         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7399         New variable declaration.
7400         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7401         New variable.
7402         (print_one_breakpoint): Use ui_out::test_flags and new global
7403         variable to compute use_fixed_output.
7404         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7405         Remove.
7406         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7407         (mi_multi_location_breakpoint_output_fixed): Remove.
7408         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7409         new variable.
7410         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7411         fix_multi_location_breakpoint_output flag if version >= 3.
7412         * ui-out.h (enum ui_out_flag)
7413         <fix_multi_location_breakpoint_output>: New enumerator.
7414
7415 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7416
7417         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7418
7419 2019-05-10  Tom Tromey  <tromey@adacore.com>
7420
7421         * ada-lang.c (catch_ada_completer): New function.
7422         (_initialize_ada_language): Use it.
7423
7424 2019-05-10  Tom Tromey  <tromey@adacore.com>
7425
7426         * thread.c (print_thread_info): Make "requested_threads" const.
7427         * gdbthread.h (print_thread_info): Make "requested_threads"
7428         const.
7429         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7430         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7431
7432 2019-05-08  Tom Tromey  <tom@tromey.com>
7433
7434         * gdbtypes.c (objfile_type_data): Change type.
7435         (objfile_type, _initialize_gdbtypes): Update.
7436
7437 2019-05-08  Tom Tromey  <tom@tromey.com>
7438
7439         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7440         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7441         (_initialize_dwarf2_frame): Update.
7442
7443 2019-05-08  Tom Tromey  <tom@tromey.com>
7444
7445         * objc-lang.c (objc_objfile_data): Change type.
7446         (find_methods): Update.
7447         (_initialize_objc_lang): Remove.
7448
7449 2019-05-08  Tom Tromey  <tom@tromey.com>
7450
7451         * stabsread.c (rs6000_builtin_type_data): Change type.
7452         (rs6000_builtin_type, _initialize_stabsread): Update.
7453
7454 2019-05-08  Tom Tromey  <tom@tromey.com>
7455
7456         * mips-tdep.c (mips_pdr_data): Remove.
7457         (_initialize_mips_tdep): Update.
7458
7459 2019-05-08  Tom Tromey  <tom@tromey.com>
7460
7461         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7462         (hppa_init_objfile_priv_data, read_unwind_info)
7463         (find_unwind_entry, _initialize_hppa_tdep): Update.
7464
7465 2019-05-08  Tom Tromey  <tom@tromey.com>
7466
7467         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7468         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7469         on obstack.
7470         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7471
7472 2019-05-08  Tom Tromey  <tom@tromey.com>
7473
7474         * mdebugread.c (basic_type_data): Change type.
7475         (basic_type, _initialize_mdebugread): Update.
7476
7477 2019-05-08  Tom Tromey  <tom@tromey.com>
7478
7479         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7480
7481 2019-05-08  Tom Tromey  <tom@tromey.com>
7482
7483         * nto-tdep.c (nto_inferior_data_reg): Change type.
7484         (nto_inferior_data): Update.
7485         (nto_inferior_data_cleanup, nto_new_inferior_data)
7486         (_initialize_nto_tdep): Remove.
7487         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7488
7489 2019-05-08  Tom Tromey  <tom@tromey.com>
7490
7491         * ada-lang.c (struct ada_inferior_data): Add initializers.
7492         (ada_inferior_data): Change type.
7493         (ada_inferior_data_cleanup): Remove.
7494         (get_ada_inferior_data, ada_inferior_exit)
7495         (struct ada_pspace_data): Add initializers, destructor.
7496         (ada_pspace_data_handle): Change type.
7497         (get_ada_pspace_data): Update.
7498         (ada_pspace_data_cleanup): Remove.
7499
7500 2019-05-08  Tom Tromey  <tom@tromey.com>
7501
7502         * coffread.c (struct coff_symfile_info): Add initializers.
7503         (coff_objfile_data_key): Move lower.  Change type.
7504         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7505         Update.
7506         (coff_free_info): Remove.
7507
7508 2019-05-08  Tom Tromey  <tom@tromey.com>
7509
7510         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7511         (fbsd_pspace_data_handle): Move lower.  Change type.
7512         (get_fbsd_pspace_data): Update.
7513         (fbsd_pspace_data_cleanup): Remove.
7514         (_initialize_fbsd_tdep): Update.
7515
7516 2019-05-08  Tom Tromey  <tom@tromey.com>
7517
7518         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7519         (get_ada_tasks_pspace_data): Update.
7520         (ada_tasks_pspace_data_cleanup): Remove.
7521         (_initialize_tasks): Update.
7522         (ada_tasks_inferior_data_handle): Change type.
7523         (get_ada_tasks_inferior_data): Update.
7524         (ada_tasks_inferior_data_cleanup): Remove.
7525         (struct ada_tasks_pspace_data): Add initializers.
7526
7527 2019-05-08  Tom Tromey  <tom@tromey.com>
7528
7529         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7530         * symfile-debug.c (debug_sym_get_probes): Change type.
7531         * stap-probe.c (handle_stap_probe):
7532         (stap_static_probe_ops::get_probes): Change type.
7533         * probe.h (class static_probe_ops) <get_probes>: Change type.
7534         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7535         (parse_probes_in_pspace): Update.
7536         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7537         Update.
7538         (any_static_probe_ops::get_probes): Change type.
7539         * elfread.c (elfread_data): New typedef.
7540         (probe_key): Change type.
7541         (elf_get_probes): Likewise.  Update.
7542         (probe_key_free): Remove.
7543         (_initialize_elfread): Update.
7544         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7545         Change type.
7546         (dtrace_process_dof_probe, dtrace_process_dof)
7547         (dtrace_static_probe_ops::get_probe): Change type.
7548
7549 2019-05-08  Tom Tromey  <tom@tromey.com>
7550
7551         * xcoffread.c (struct xcoff_symfile_info): Rename from
7552         coff_symfile_info.  Add initializers.
7553         (xcoff_objfile_data_key): Move lower.  Change type.
7554         (XCOFF_DATA): Rewrite.
7555         (xcoff_free_info): Remove.
7556         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7557         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7558         (xcoff_initial_scan): Update.
7559
7560 2019-05-08  Tom Tromey  <tom@tromey.com>
7561
7562         * solib-svr4.c (struct svr4_info): Add initializers and
7563         destructor.
7564         <probes_table>: Now an htab_up.
7565         (solib_svr4_pspace_data): Change type.
7566         (free_probes_table): Simplify.
7567         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7568         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7569         (probes_table_remove_objfile_probes, register_solib_event_probe)
7570         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7571         (_initialize_svr4_solib): Update.
7572
7573 2019-05-08  Tom Tromey  <tom@tromey.com>
7574
7575         * remote.c (remote_pspace_data): Change type.
7576         (remote_pspace_data_cleanup): Remove.
7577         (get_remote_exec_file, set_pspace_remote_exec_file)
7578         (_initialize_remote): Update.
7579
7580 2019-05-08  Tom Tromey  <tom@tromey.com>
7581
7582         * breakpoint.c (breakpoint_objfile_key): Change type.
7583         (get_breakpoint_objfile_data): Update.
7584         (free_breakpoint_objfile_data): Remove.
7585         (_initialize_breakpoint): Update.
7586
7587 2019-05-08  Tom Tromey  <tom@tromey.com>
7588
7589         * linux-tdep.c (struct linux_info): Add initializers.
7590         (linux_inferior_data): Move.  Change type.
7591         (invalidate_linux_cache_inf): Update.
7592         (linux_inferior_data_cleanup): Remove.
7593         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7594
7595 2019-05-08  Tom Tromey  <tom@tromey.com>
7596
7597         * auxv.c (auxv_inferior_data): Move.  Change type.
7598         (auxv_inferior_data_cleanup): Remove.
7599         (invalidate_auxv_cache_inf): Rewrite.
7600         (get_auxv_inferior_data, _initialize_auxv): Update.
7601
7602 2019-05-08  Tom Tromey  <tom@tromey.com>
7603
7604         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7605         (symfile_debug_objfile_data_key): Change type.
7606         (symfile_debug_installed, debug_qf_has_symbols)
7607         (debug_qf_find_last_source_symtab)
7608         (debug_qf_forget_cached_source_info)
7609         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7610         (debug_qf_print_stats, debug_qf_dump)
7611         (debug_qf_expand_symtabs_for_function)
7612         (debug_qf_expand_all_symtabs)
7613         (debug_qf_expand_symtabs_with_fullname)
7614         (debug_qf_map_matching_symbols)
7615         (debug_qf_expand_symtabs_matching)
7616         (debug_qf_find_pc_sect_compunit_symtab)
7617         (debug_qf_map_symbol_filenames)
7618         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7619         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7620         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7621         (debug_sym_read_linetable, debug_sym_relocate): Update.
7622         (symfile_debug_free_objfile): Remove.
7623         (install_symfile_debug_logging, _initialize_symfile_debug):
7624         Update.
7625
7626 2019-05-08  Tom Tromey  <tom@tromey.com>
7627
7628         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7629         allocate_on_obstack.
7630         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7631         (get_dwarf2_per_objfile): Update.
7632         (set_dwarf2_per_objfile): Remove.
7633         (dwarf2_has_info, dwarf2_get_section_info): Update.
7634         (dwarf2_free_objfile): Remove.
7635         (_initialize_dwarf2_read): Update.
7636
7637 2019-05-08  Tom Tromey  <tom@tromey.com>
7638
7639         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7640         initializers.
7641         <unsupported_script_warning_printed,
7642         script_not_found_warning_printed>: Now bool.
7643         (auto_load_pspace_data): Change type.
7644         (~auto_load_pspace_info): Rename from
7645         auto_load_pspace_data_cleanup.
7646         (get_auto_load_pspace_data, init_loaded_scripts_info)
7647         (clear_section_scripts, maybe_print_unsupported_script_warning)
7648         (maybe_print_script_not_found_warning, _initialize_auto_load):
7649         Update.
7650
7651 2019-05-08  Tom Tromey  <tom@tromey.com>
7652
7653         * objfiles.c (objfile_pspace_info): Add destructor and
7654         initializers.
7655         (objfiles_pspace_data): Change type.
7656         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7657         (get_objfile_pspace_data): Update.
7658         (objfiles_bfd_data): Change type.
7659         (get_objfile_bfd_data): Update.
7660         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7661
7662 2019-05-08  Tom Tromey  <tom@tromey.com>
7663
7664         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7665         Change type.
7666         (get_catch_syscall_inferior_data): Update.
7667         (catch_syscall_inferior_data_cleanup): Remove.
7668         (_initialize_break_catch_syscall): Update.
7669
7670 2019-05-08  Tom Tromey  <tom@tromey.com>
7671
7672         * inflow.c (struct terminal_info): Add destructor and
7673         initializers.
7674         (inflow_inferior_data): Change type.
7675         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7676         (get_inflow_inferior_data, inflow_inferior_exit)
7677         (swap_terminal_info, _initialize_inflow): Update.
7678
7679 2019-05-08  Tom Tromey  <tom@tromey.com>
7680
7681         * target-dcache.c (target_dcache_cleanup): Remove.
7682         (target_dcache_aspace_key): Change type.
7683         (target_dcache_init_p, target_dcache_invalidate)
7684         (target_dcache_get, target_dcache_get_or_init)
7685         (_initialize_target_dcache): Update.
7686         * dcache.h (struct dcache_deleter): New.
7687
7688 2019-05-08  Tom Tromey  <tom@tromey.com>
7689
7690         * symtab.c (struct symbol_cache): Add destructor and
7691         initializers.
7692         (symbol_cache_key): Move.  Change type.
7693         (make_symbol_cache, free_symbol_cache): Remove.
7694         (get_symbol_cache): Update.
7695         (symbol_cache_cleanup): Remove.
7696         (ALL_PSPACES, symbol_cache_flush)
7697         (maintenance_print_symbol_cache)
7698         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7699         Update.
7700
7701 2019-05-08  Tom Tromey  <tom@tromey.com>
7702
7703         * symtab.c (struct main_info): Add destructor and initializers.
7704         (main_progspace_key): Move.  Change type.
7705         (get_main_info): Update.
7706         (main_info_cleanup): Remove.
7707         (_initialize_symtab): Update.
7708
7709 2019-05-08  Tom Tromey  <tom@tromey.com>
7710
7711         * registry.h (DECLARE_REGISTRY): Define the _key class.
7712
7713 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * NEWS: Merge two 'New commands' sections.
7716
7717 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7718
7719         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7720         parameter and use Ada language definition instead.
7721         (ada_val_print_ptr): Remove unused language parameter.
7722         (ada_val_print_num): Remove language parameter and use Ada language
7723         definition instead.
7724         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7725         parameter.
7726         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7727         parameter and use Ada language definition instead.
7728         (ada_val_print_1): Update all ada_val_print_xxx calls.
7729         Remove language parameter.
7730         (ada_val_print): Update ada_val_print_1 call.
7731
7732 2019-05-08  Tom Tromey  <tromey@adacore.com>
7733
7734         * remote.c (remote_hw_watchpoint_limit)
7735         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7736         Now static.
7737
7738 2019-05-08  Tom Tromey  <tromey@adacore.com>
7739
7740         * maint.c (_initialize_maint_cmds): Move initialization code to
7741         remote.c.
7742         (watchdog, show_watchdog): Move to remote.c.
7743         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7744         "watchdog" static.
7745         (_initialize_remote): Move initialization code from maint.c.
7746         * defs.h (watchdog): Don't declare.
7747
7748 2019-05-08  Tom Tromey  <tromey@adacore.com>
7749
7750         * tui/tui-interp.c: Include main.h.
7751         * interps.c: Include main.h.
7752         * main.h (interpreter_p): Declare.
7753         * defs.h (interpreter_p): Don't declare.
7754
7755 2019-05-08  Tom Tromey  <tromey@adacore.com>
7756
7757         * dwarf2loc.c: Include dwarf2read.h.
7758         * defs.h (read_unsigned_leb128): Don't declare.
7759         * dwarf2read.h (read_unsigned_leb128): Declare.
7760
7761 2019-05-08  Tom Tromey  <tromey@adacore.com>
7762
7763         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7764         method.
7765
7766 2019-05-08  Tom Tromey  <tromey@adacore.com>
7767
7768         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7769         when no wrap column is set.
7770
7771 2019-05-08  Tom Tromey  <tromey@adacore.com>
7772
7773         * c-lang.c (c_get_string): Handle non-C-style arrays.
7774
7775 2019-05-08  Tom Tromey  <tromey@adacore.com>
7776
7777         * typeprint.c (print_offset_data::update): Print the bit offset,
7778         not the number of bits remaining.
7779
7780 2019-05-08  Tom Tromey  <tromey@adacore.com>
7781
7782         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7783         padding at end of comment.
7784
7785 2019-05-08  Tom Tromey  <tromey@adacore.com>
7786
7787         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7788         Compare main types.
7789
7790 2019-05-06  Tom Tromey  <tom@tromey.com>
7791
7792         * common/scoped_mmap.c: Include common-defs.h.
7793         * common/scoped_mmap.h: Don't include config.h.
7794
7795 2019-05-04  Tom Tromey  <tom@tromey.com>
7796
7797         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7798         (struct aarch64_call_info): Add initializers.
7799         <si>: Now a std::vector.
7800         (pass_on_stack, aarch64_push_dummy_call): Update.
7801
7802 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7803             Tom Tromey  <tom@tromey.com>
7804
7805         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7806         (ppc_threads): Now a std::vector.  Now static.
7807         (hwdebug_find_thread_points_by_tid)
7808         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7809         Update.
7810
7811 2019-05-04  Tom Tromey  <tom@tromey.com>
7812
7813         * arc-tdep.c (arc_tdesc_init): Return bool.
7814
7815 2019-05-04  Tom Tromey  <tom@tromey.com>
7816
7817         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7818         Use gdb_assert_not_reached.
7819
7820 2019-05-04  Tom Tromey  <tom@tromey.com>
7821
7822         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7823         "false".
7824
7825 2019-05-04  Tom Tromey  <tom@tromey.com>
7826
7827         * arc-tdep.c (arc_tdesc_init): Use bool.
7828
7829 2019-05-04  Tom Tromey  <tom@tromey.com>
7830
7831         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7832
7833 2019-05-04  Tom Tromey  <tom@tromey.com>
7834
7835         * cli/cli-cmds.c (valid_command_p): Return bool.
7836
7837 2019-05-04  Tom Tromey  <tom@tromey.com>
7838
7839         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7840         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7841
7842 2019-05-04  Raul Tambre  <raul@tambre.ee>
7843
7844         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7845         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7846         operator for comparison.
7847
7848 2019-05-04  Tom Tromey  <tom@tromey.com>
7849
7850         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7851         (lookup_partial_symbol, print_partial_symbols)
7852         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7853         (psymbol_compare): Update.
7854         (add_psymbol_to_bcache): Clear the entire psymbol.
7855         (maintenance_check_psymtabs): Update.
7856         * psympriv.h (struct partial_symbol): Don't derive from
7857         general_symbol_info.
7858         <obj_section, unrelocated_address, address,
7859         set_unrelocated_address>: Update.
7860         <ginfo>: New member.
7861         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7862         (debug_names::write_psymbols): Update.
7863
7864 2019-05-04  Tom de Vries  <tdevries@suse.de>
7865
7866         * contrib/cc-with-tweaks.sh: Support -n arg.
7867
7868 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7869
7870         * corelow.c (core_target::detach): Ensure frame cache and
7871         register caches are cleared.
7872         inferior.c (exit_inferior_1): Likewise.
7873
7874 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7875             Tom Tromey  <tom@tromey.com>
7876
7877         * dictionary.c (collate_pending_symbols_by_language): Remove
7878         "struct" from foreach.
7879         * symtab.c (lookup_global_symbol_from_objfile)
7880         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7881         foreach.
7882         * ser-tcp.c (net_open): Remove "struct" from foreach.
7883         * objfiles.c (objfile_relocate, objfile_rebase)
7884         (objfile_has_symbols): Remove "struct" from foreach.
7885         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7886         from foreach.
7887         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7888         foreach.
7889         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7890         "struct" from foreach.
7891         * ada-lang.c (create_excep_cond_exprs)
7892         (ada_exception_catchpoint_cond_string): Remove "struct" from
7893         foreach.
7894
7895 2019-05-03  Tom Tromey  <tromey@adacore.com>
7896
7897         * ada-exp.y (convert_char_literal): Check suffix of each
7898         enumerator.
7899
7900 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7901
7902         PR ada/21406:
7903         * ada-exp.y (yywrap): Don't define.
7904         * ada-lex.l (%option): Add noyywrap
7905         (yywrap): Remove.
7906
7907 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7908
7909         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7910         _WIN32_WINNT to the XP level, unless already defined to a higher
7911         level.
7912
7913         * unittests/parse-connection-spec-selftests.c:
7914         * ser-tcp.c:
7915         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7916         override.
7917
7918         * symfile.c (find_separate_debug_file): Remove colon from the
7919         drive spec of DOS/Windows file names of the target, so that the
7920         file name produced from DEBUGDIR and the target's directory will
7921         be valid on DOS/Windows systems.
7922
7923 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * rust-lang.c (val_print_struct): Handle printing structures
7926         containing strings.
7927
7928 2019-05-02  Tom Tromey  <tromey@adacore.com>
7929
7930         * valarith.c (_initialize_valarith): Remove.
7931
7932 2019-05-01  Tom Tromey  <tromey@adacore.com>
7933
7934         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7935         bitfields.
7936
7937 2019-05-01  Tom Tromey  <tromey@adacore.com>
7938
7939         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7940         for big-endian copies.
7941
7942 2019-04-30  Ali Tamur  <tamur@google.com>
7943         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7944         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7945         (read_3_bytes): New function.
7946
7947 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7948
7949         * windows-nat.c (main_thread_id): Delete.
7950         (handle_output_debug_string): Replace main_thread_id by
7951         current_event.dwThreadId.
7952         (fake_create_process): Likewise.
7953         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7954         Do not set main_thread_id.
7955         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7956         current_event.dwThreadId.
7957         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7958
7959 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7960
7961         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7962         Use current_event.dwThreadId instead of main_thread_id.
7963
7964 2019-04-30  Tom Tromey  <tromey@adacore.com>
7965
7966         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7967         (create_excep_cond_exprs): Iterate over program spaces.
7968         (ada_exception_catchpoint_cond_string): Examine all minimal
7969         symbols for exception types.
7970
7971 2019-04-30  Tom Tromey  <tromey@adacore.com>
7972
7973         PR c++/24470:
7974         * dwarf2read.c (process_structure_scope): Handle case where type
7975         has template parameters but no symbol was created.
7976
7977 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7978             Chris January  <chris.january@arm.com>
7979
7980         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7981         qualifier.
7982         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7983
7984 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7985
7986         * f-typeprint.c (f_print_type): Update rules for printing
7987         whitespace.
7988         (f_type_print_varspec_suffix): Likewise.
7989
7990 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7991             Chris January  <chris.january@arm.com>
7992
7993         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7994         function arguments.
7995
7996 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * f-lang.c (build_fortran_types): Change name of void type to
7999         lower case.
8000         * f-typeprint.c (f_type_print_base): Print the name of the void
8001         type, rather than a fixed string.
8002         * f-valprint.c (f_decorations): Use lower case void string.
8003
8004 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8005             Chris January  <chris.january@arm.com>
8006
8007         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8008         types for Fortran.
8009
8010 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8011             Chris January  <chris.january@arm.com>
8012             David Lecomber  <david.lecomber@arm.com>
8013
8014         * f-exp.y (BINOP_INTRINSIC): New token.
8015         (exp): New parser rule handling BINOP_INTRINSIC.
8016         (f77_keywords): Add new builtin procedures.
8017         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8018         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8019         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8020         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8021         (print_unop_subexp_f): New function.
8022         (print_binop_subexp_f): New function.
8023         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8024         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8025         (dump_subexp_body_f): Likewise.
8026         (operator_check_f): Likewise.
8027         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8028         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8029
8030 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8031
8032         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8033         UNOP_KIND.
8034         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8035         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8036         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8037         (operator_length_f): New fuction.
8038         (print_subexp_f): New function.
8039         (op_name_f): New function.
8040         (dump_subexp_body_f): New function.
8041         (operator_check_f): New function.
8042         (exp_descriptor_f): Replace standard expression handling functions
8043         with new functions.
8044         * gdb/fortran-operator.def: New file.
8045         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8046         * gdb/std-operator.def: Remove UNOP_KIND.
8047
8048 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * std-operator.def: Remove unbalanced, stray double quote
8051         character.
8052
8053 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8054             Chris January  <chris.january@arm.com>
8055             Daniel Everett  <daniel.everett@arm.com>
8056             Nick Forrington  <nick.forrington@arm.com>
8057             Richard Bunt  <richard.bunt@arm.com>
8058
8059         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8060         of depth when printing anonymous structs or unions.
8061         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8062         Don't print either the top-level value, or the children if the
8063         max-depth is exceeded.
8064         (ppscm_print_children): When printing the key of a map, allow one
8065         extra level of depth.
8066         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8067         print either the top-level value, or the children if the max-depth
8068         is exceeded.
8069         (print_children): When printing the key of a map, allow one extra
8070         level of depth.
8071         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8072         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8073         (user_print_options): Initialise max_depth field.
8074         (val_print_scalar_or_string_type_p): New function.
8075         (val_print): Check to see if the max depth has been reached.
8076         (val_print_check_max_depth): Define new function.
8077         (show_print_max_depth): New function.
8078         (_initialize_valprint): Add 'print max-depth' option.
8079         * valprint.h (struct value_print_options) <max_depth>: New field.
8080         (val_print_check_max_depth): Declare new function.
8081         * NEWS: Document new feature.
8082
8083 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * ada-lang.c (ada_language_defn): Initialise new field.
8086         * c-lang.c (c_is_string_type_p): New function.
8087         (c_language_defn): Initialise new field.
8088         (cplus_language_defn): Initialise new field.
8089         (asm_language_defn): Initialise new field.
8090         (minimal_language_defn): Initialise new field.
8091         * c-lang.h (c_is_string_type_p): Declare new function.
8092         * d-lang.c (d_language_defn): Initialise new field.
8093         * f-lang.c (f_is_string_type_p): New function.
8094         (f_language_defn): Initialise new field.
8095         * go-lang.c (go_is_string_type_p): New function.
8096         (go_language_defn): Initialise new field.
8097         * language.c (default_is_string_type_p): New function.
8098         (unknown_language_defn): Initialise new field.
8099         (auto_language_defn): Initialise new field.
8100         * language.h (struct language_defn) <la_is_string_type_p>: New
8101         member variable.
8102         (default_is_string_type_p): Declare new function.
8103         * m2-lang.c (m2_language_defn): Initialise new field.
8104         * objc-lang.c (objc_language_defn): Initialise new field.
8105         * opencl-lang.c (opencl_language_defn): Initialise new field.
8106         * p-lang.c (pascal_is_string_type_p): New function.
8107         (pascal_language_defn): Initialise new field.
8108         * rust-lang.c (rust_is_string_type_p): New function.
8109         (rust_language_defn): Initialise new field.
8110
8111 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8114         New field.
8115         * ada-lang.c (ada_language_defn): Initialise new field.
8116         * c-lang.c (c_language_defn): Likewise.
8117         (cplus_language_defn): Likewise.
8118         (asm_language_defn): Likewise.
8119         (minimal_language_defn): Likewise.
8120         * d-lang.c (d_language_defn): Likewise.
8121         * f-lang.c (f_language_defn): Likewise.
8122         * go-lang.c (go_language_defn): Likewise.
8123         * language.c (unknown_language_defn): Likewise.
8124         (auto_language_defn): Likewise.
8125         * m2-lang.c (m2_language_defn): Likewise.
8126         * objc-lang.c (objc_language_defn): Likewise.
8127         * opencl-lang.c (opencl_language_defn): Likewise.
8128         * p-lang.c (pascal_language_defn): Likewise.
8129         * rust-lang.c (rust_language_defn): Likewise.
8130
8131 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8132
8133         * ada-lang.c (ada_is_character_type): Change return type to bool.
8134         (ada_is_string_type): Likewise.
8135         * ada-lang.h (ada_is_character_type): Update declaration
8136         (ada_is_string_type): Likewise.
8137
8138 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8139
8140         Support style in 'frame|thread apply'
8141
8142         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8143         * record.c (record_start, record_stop): Update callers of
8144         execute_command_to_string with false.
8145         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8146         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8147         methods.
8148         (class string_file): New constructor with term_out parameter.
8149         Override methods term_out and can_emit_style_escape.  New member
8150         term_out.
8151         (class stdio_file): Override can_emit_style_escape.
8152         (class tee_file): Override term_out and can_emit_style_escape.
8153         * utils.h (can_emit_style_escape): Remove.
8154         * utils.c (can_emit_style_escape): Likewise.
8155         Update all callers of can_emit_style_escape (SOMESTREAM) to
8156         SOMESTREAM->can_emit_style_escape.
8157         * source-cache.c (source_cache::get_source_lines): Likewise.
8158         * stack.c (frame_apply_command_count): Call execute_command_to_string
8159         passing the term_out characteristic of the current gdb_stdout.
8160         * thread.c (thr_try_catch_cmd): Likewise.
8161         * top.c (execute_command_to_string): pass term_out parameter
8162         to construct the string_file for the command output.
8163         * ui-file.c (term_cli_styling): New function (most code moved
8164         from utils.c can_emit_style_escape).
8165         (string_file::string_file, string_file::can_emit_style_escape,
8166         stdio_file::can_emit_style_escape, tee_file::term_out,
8167         tee_file::can_emit_style_escape): New functions.
8168
8169 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8170
8171         * NEWS: Mention the new set|show may-call-functions.
8172         * infcall.c (may_call_functions_p): New variable.
8173         (show_may_call_functions_p): New function.
8174         (call_function_by_hand_dummy): Throws an error if not
8175         may-call-functions.
8176         (_initialize_infcall): Call add_setshow_boolean_cmd for
8177         may-call-functions.
8178
8179 2019-04-25  Keith Seitz  <keiths@redhat.com>
8180
8181         PR c++/24367
8182         * cp-support.c (inspect_type): Don't attempt substitutions
8183         of symbol with the same name.
8184
8185 2019-04-25  Tom Tromey  <tromey@adacore.com>
8186
8187         PR gdb/24475:
8188         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8189         static.
8190
8191 2019-04-25  Tom Tromey  <tromey@adacore.com>
8192
8193         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8194         rvalue reference.
8195         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8196         (gdb_xml_parser::parse): Use std::move.
8197         * python/python-internal.h (gdbpy_convert_exception): Take a const
8198         reference.
8199         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8200         std::move.
8201         * python/py-utils.c (gdbpy_convert_exception): Take a const
8202         reference.
8203         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8204         Use std::move.
8205         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8206         Use std::move.
8207         * mi/mi-main.c (mi_print_exception): Take a const reference.
8208         * main.c (handle_command_errors): Take a const reference.
8209         * linespec.c (parse_linespec): Use std::move.
8210         * infcall.c (run_inferior_call): Use std::move.
8211         (call_function_by_hand_dummy): Use std::move.
8212         * exec.c (try_open_exec_file): Use std::move.
8213         * exceptions.h (exception_print, exception_fprintf)
8214         (exception_print_same): Update.
8215         * exceptions.c (print_exception, exception_print)
8216         (exception_fprintf, exception_print_same): Change parameters to
8217         const reference.
8218         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8219         * common/new-op.c: Use std::move.
8220         * common/common-exceptions.h (struct gdb_exception): Add move
8221         constructor.
8222         (struct gdb_exception_error, struct gdb_exception_quit, struct
8223         gdb_quit_bad_alloc): Change constructor to move constructor.
8224         (throw_exception): Change parameter to rvalue reference.
8225         * common/common-exceptions.c (throw_exception): Take rvalue
8226         reference.
8227         * cli/cli-interp.c (safe_execute_command): Use std::move.
8228         * breakpoint.c (insert_bp_location, location_to_sals): Use
8229         std::move.
8230
8231 2019-04-25  Tom Tromey  <tromey@adacore.com>
8232
8233         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8234         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8235         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8236         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8237         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8238         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8239         guile/scm-value.c: Use unpack.
8240         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8241         gdbscm_gdb_exception.
8242         (gdbscm_throw_gdb_exception): Likewise.
8243         (struct gdbscm_gdb_exception): New.
8244         (unpack): New function.
8245         (gdbscm_wrap): Use unpack.
8246
8247 2019-04-25  Tom Tromey  <tromey@adacore.com>
8248
8249         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8250         (gdb_rl_callback_handler): Use std::move.
8251         * common/common-exceptions.h (struct gdb_exception): Add move
8252         assignment operator.
8253         (throw_exception_sjlj): Change "exception" to const reference.
8254         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8255         (throw_exception_sjlj): Change "exception" to const reference.
8256
8257 2019-04-25  Tom Tromey  <tromey@adacore.com>
8258
8259         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8260         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8261         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8262         Update.
8263         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8264         Update.
8265         * mi/mi-interp.c (mi_interp::exec): Update.
8266         * linespec.c (parse_linespec): Update.
8267         * infcall.c (run_inferior_call): Update.
8268         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8269         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8270         (gdbscm_lookup_global_symbol): Update.
8271         * guile/scm-param.c (gdbscm_parameter_value): Update.
8272         * guile/scm-frame.c (gdbscm_frame_read_register)
8273         (gdbscm_frame_read_var): Update.
8274         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8275         * exec.c (try_open_exec_file): Update.
8276         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8277         (gdb_rl_callback_handler): Update.
8278         * common/common-exceptions.h (exception_none): Don't declare.
8279         * common/common-exceptions.c (exception_none): Don't define.
8280         (struct catcher) <exception>: Update.
8281         * cli/cli-interp.c (safe_execute_command): Update.
8282         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8283
8284 2019-04-25  Ali Tamur  <tamur@google.com>
8285
8286         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8287         (read_attribute_value): Likewise.
8288         (dwarf2_read_addr_index): Update comment.
8289         (read_str_index): Add DW_FORM_strx.
8290         (dwarf2_string_attr): Likewise.
8291         (dwarf2_const_value_attr): Likewise.
8292         (dump_die_shallow): Likewise.
8293         (dwarf2_fetch_constant_bytes): Likewise.
8294         (skip_form_bytes): Likewise.
8295         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8296
8297 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8298
8299         PR corefiles/11608
8300         PR corefiles/18187
8301         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8302         OFFSET.  Verify if current mapping contains an ELF header.
8303         (linux_find_memory_regions_full): Adjust call to
8304         dump_mapping_p.
8305
8306 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8307             Kang Li <kanglictf@gmail.com>
8308
8309         PR gdb/21600
8310
8311         * dwarf2-frame.c (read_initial_length): Be consistent about using
8312         unsigned representation of length.
8313         (decode_frame_entry_1): Likewise.  Check for wraparound of
8314         end pointer as well as buffer overflow.
8315
8316 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8317
8318         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8319         "vq".
8320
8321 2019-04-24  Tom Tromey  <tromey@adacore.com>
8322
8323         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8324
8325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8326
8327         * s12z-tdep.c (s12z_unwind_pc): Delete.
8328         (s12z_unwind_sp): Delete.
8329         (s12z_gdbarch_init): Don't register deleted functions with
8330         gdbarch.
8331
8332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * rl78-tdep.c (rl78_unwind_sp): Delete.
8335         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8336
8337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8338
8339         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8340         (xstormy16_unwind_pc): Delete.
8341         (xstormy16_dummy_id): Delete.
8342         (xstormy16_gdbarch_init): Don't register deleted functions with
8343         gdbarch.
8344
8345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8346
8347         * vax-tdep.c (vax_unwind_pc): Delete.
8348         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8349
8350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8351
8352         * v850-tdep.c (v850_unwind_sp): Delete.
8353         (v850_unwind_pc): Delete.
8354         (v850_dummy_id): Delete.
8355         (v850_gdbarch_init): Don't register deleted functions with
8356         gdbarch.
8357
8358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8359
8360         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8361         (tilegx_unwind_pc): Delete.
8362         (tilegx_unwind_dummy_id): Delete.
8363         (tilegx_gdbarch_init): Don't register deleted functions with
8364         gdbarch.
8365
8366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8367
8368         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8369         (tic6x_dummy_id): Delete.
8370         (tic6x_gdbarch_init): Don't register deleted functions with
8371         gdbarch.
8372
8373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8374
8375         * sparc-tdep.c (sparc_unwind_pc): Delete.
8376         (sparc32_gdbarch_init): Don't register deleted function with
8377         gdbarch.
8378
8379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * sh-tdep.c (sh_unwind_sp): Delete.
8382         (sh_unwind_pc): Delete.
8383         (sh_dummy_id): Delete.
8384         (sh_gdbarch_init): Don't register deleted functions with
8385         gdbarch.
8386
8387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8388
8389         * score-tdep.c (score_unwind_sp): Delete.
8390         (score_unwind_pc): Delete.
8391         (score_dummy_id): Delete.
8392         (score_gdbarch_init): Don't register deleted functions with
8393         gdbarch.
8394
8395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8396
8397         * rx-tdep.c (rx_unwind_pc): Delete.
8398         (rx_unwind_sp): Delete.
8399         (rx_dummy_id): Delete.
8400         (rx_gdbarch_init): Don't register deleted functions with
8401         gdbarch.  Update comment.
8402
8403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8404
8405         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8406         (rs6000_dummy_id): Delete.
8407         (rs6000_gdbarch_init): Don't register deleted functions with
8408         gdbarch.
8409
8410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * or1k-tdep.c (or1k_dummy_id): Delete.
8413         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8414
8415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8416
8417         * nios2-tdep.c (nios2_dummy_id): Delete.
8418         (nios2_unwind_sp): Delete.
8419         (nios2_gdbarch_init): Don't register deleted functions with
8420         gdbarch.
8421
8422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * nds32-tdep.c (nds32_dummy_id): Delete.
8425         (nds32_unwind_pc): Delete.
8426         (nds32_unwind_sp): Delete.
8427         (nds32_gdbarch_init): Don't register deleted functions with
8428         gdbarch.
8429
8430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * msp430-tdep.c (msp430_unwind_pc): Delete.
8433         (msp430_unwind_sp): Delete.
8434         (msp430_dummy_id): Delete.
8435         (msp430_gdbarch_init): Don't register deleted functions with
8436         gdbarch.
8437
8438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8439
8440         * moxie-tdep.c (moxie_unwind_sp): Delete.
8441         (moxie_unwind_pc): Delete.
8442         (moxie_dummy_id): Delete.
8443         (moxie_gdbarch_init): Don't register deleted functions with
8444         gdbarch.
8445
8446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8447
8448         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8449         (mn10300_unwind_pc): Delete.
8450         (mn10300_unwind_sp): Delete.
8451         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8452         mn10300_unwind_sp.
8453         (mn10300_frame_unwind_init): Don't register deleted functions with
8454         gdbarch.
8455
8456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8457
8458         * mep-tdep.c (mep_unwind_pc): Delete.
8459         (mep_unwind_sp): Delete.
8460         (mep_dummy_id): Delete.
8461         (mep_gdbarch_init): Don't register deleted functions with
8462         gdbarch.
8463
8464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8467         (m68hc11_unwind_sp): Delete.
8468         (m68hc11_gdbarch_init): Don't register deleted functions with
8469         gdbarch.
8470
8471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * m32r-tdep.c (m32r_unwind_sp): Delete.
8474         (m32r_unwind_pc): Delete.
8475         (m32r_dummy_id): Delete.
8476         (m32r_gdbarch_init): Don't register deleted functions with
8477         gdbarch.
8478
8479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8480
8481         * m32c-tdep.c (m32c_unwind_pc): Delete.
8482         (m32c_unwind_sp): Delete.
8483         (m32c_dummy_id): Delete.
8484         (m32c_gdbarch_init): Don't register deleted functions with
8485         gdbarch.
8486
8487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8490         (lm32_unwind_pc): Delete.
8491         (lm32_dummy_id): Delete.
8492         (lm32_gdbarch_init): Don't register deleted functions with
8493         gdbarch.
8494
8495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8496
8497         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8498         (iq2000_unwind_pc): Delete.
8499         (iq2000_dummy_id): Delete.
8500         (iq2000_gdbarch_init): Don't register deleted functions with
8501         gdbarch.
8502
8503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * nds32-tdep.c (nds32_type_align): Delete.
8506         (nds32_push_dummy_call): Use type_align instead.
8507
8508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * arm-tdep.c (arm_type_align): Only handle vector override case.
8511         (arm_push_dummy_call): Use type_align.
8512         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8513
8514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8515
8516         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8517         case.
8518         (pass_on_stack): Use type_align.
8519         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8520         function.
8521
8522 2019-04-23  Tom Tromey  <tromey@adacore.com>
8523
8524         * dwarf2read.c (line_header::file_name_at): Remove unused
8525         overload.
8526
8527 2019-04-23  Tom de Vries  <tdevries@suse.de>
8528
8529         PR gdb/24438
8530         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8531         invocation.
8532
8533
8534 2019-03-27  Ali Tamur  <tamur@google.com>
8535
8536         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8537         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8538         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8539         (dwarf_expr_context::get_addr_index): Likewise
8540         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8541         (symbol_needs_eval_context::get_addr_index): Likewise
8542         (disassemble_dwarf_expression): Add DW_OP_addrx
8543         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8544         (read_cutu_die_from_dwo): Update comment
8545         (skip_one_die): Add DW_FORM_addrx
8546         (read_attribute_value): Likewise
8547         (var_decode_location): Add DW_OP_addrx
8548         (dwarf2_const_value_attr): Add DW_FORM_addrx
8549         (dump_die_shallow): Likewise
8550         (dwarf2_fetch_constant_bytes): Likewise
8551         (decode_locdesc): Add DW_OP_addrx
8552         (skip_form_bytes): Add DW_FORM_addrx
8553
8554 2019-04-22  Ali Tamur  <tamur@google.com>
8555
8556         * MAINTAINERS (Write After Approval): Add self.
8557
8558 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8559
8560         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8561         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8562         (open_symbol_file_object): Likewise.
8563         (svr4_default_sos): Add info parameter.
8564         (svr4_read_so_list): Likewise.
8565         (svr4_current_sos_direct): Adjust functions calls to pass down
8566         info.
8567         (svr4_current_sos_1): Add info parameter.
8568         (svr4_current_sos): Call get_svr4_info, pass info down to
8569         svr4_current_sos_1.
8570         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8571         get_svr4_info.
8572         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8573         get_svr4_info.
8574         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8575         to get_svr4_info.
8576         (probes_table_remove_objfile_probes): Likewise.
8577         (register_solib_event_probe): Add info parameter.
8578         (solist_update_incremental): Pass info parameter down to
8579         svr4_read_so_list.
8580         (disable_probes_interface): Add info parameter.
8581         (svr4_handle_solib_event): Pass current_program_space to
8582         get_svr4_info.  Adjust disable_probes_interface cleanup.
8583         (svr4_create_probe_breakpoints): Add info parameter, pass it
8584         down to register_solib_event_probe.
8585         (svr4_create_solib_event_breakpoints): Add info parameter,
8586         pass it down to svr4_create_probe_breakpoints.
8587         (enable_break): Pass info down to
8588         svr4_create_solib_event_breakpoints.
8589         (svr4_solib_create_inferior_hook): Pass current_program_space to
8590         get_svr4_info.
8591         (svr4_clear_solib): Likewise.
8592
8593 2019-04-22  Pedro Alves  <palves@redhat.com>
8594
8595         * solib-svr4.c (svr4_free_objfile_observer): New.
8596         (probe_and_action::objfile): New field.
8597         (probes_table_htab_remove_objfile_probes)
8598         (probes_table_remove_objfile_probes): New functions.
8599         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8600         in the new probe_and_action.  Don't store the probe in 'lookup'.
8601         (svr4_create_probe_breakpoints): Pass objfile to
8602         register_solib_event_probe.
8603         (_initialize_svr4_solib): Register a free_objfile observer.
8604
8605 2019-04-19  Tom Tromey  <tom@tromey.com>
8606
8607         * common/queue.h: Remove.
8608
8609 2019-04-19  Tom Tromey  <tom@tromey.com>
8610
8611         * event-loop.c: Don't include "common/queue.h".
8612
8613 2019-04-19  Tom Tromey  <tom@tromey.com>
8614
8615         * remote.c (remote_target): Use delete.
8616         * remote-notif.h: Include <list>, not "common/queue.h".
8617         (notif_client_p): Remove typedef.
8618         (remote_notif_state): Add constructor, destructor, initializer.
8619         <notif_queue>: Now a std::list.
8620         (remote_notif_state_xfree): Don't declare.
8621         * remote-notif.c (remote_notif_process, handle_notification)
8622         (remote_notif_state_allocate): Update.
8623         (~remote_notif_state): Rename from remote_notif_state_xfree.
8624
8625 2019-04-19  Tom Tromey  <tom@tromey.com>
8626
8627         * symfile.c (reread_symbols): Update.
8628         * objfiles.c (objfile_register_static_link)
8629         (objfile_lookup_static_link): Update
8630         (~objfile) Don't delete static_links.
8631         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8632
8633 2019-04-19  Tom Tromey  <tom@tromey.com>
8634
8635         * type-stack.h (struct type_stack) <insert>: Constify string.
8636         * type-stack.c (type_stack::insert): Constify string.
8637         * gdbtypes.h (lookup_template_type): Update.
8638         (address_space_name_to_int): Update.
8639         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8640         const.
8641         (lookup_template_type): Make name const.
8642         * c-exp.y: Update rules.
8643         (lex_one_token, classify_name, classify_inner_name)
8644         (c_print_token): Update.
8645         * p-exp.y: Update rules.
8646         (yylex): Update.
8647         * f-exp.y: Update rules.
8648         (yylex): Update.
8649         * d-exp.y: Update rules.
8650         (lex_one_token, classify_name, classify_inner_name): Update.
8651         * parse.c (write_dollar_variable, copy_name): Return std::string.
8652         * parser-defs.h (copy_name): Change return type.
8653         * m2-exp.y: Update rules.
8654         (yylex): Update.
8655         * go-exp.y (lex_one_token): Update.
8656         Update rules.
8657         (classify_unsafe_function, classify_packaged_name)
8658         (classify_name, yylex): Update.
8659
8660 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8661
8662         * configure.ac: add --enable-source-highlight switch.
8663         * configure: Regenerate.
8664         * top.c (print_gdb_version): plumb --enable-source-highlight
8665         status to "show configuration".
8666
8667 2019-04-19  Tom Tromey  <tromey@adacore.com>
8668
8669         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8670         Check ADA_TYPE_P.
8671         (empty_record, ada_template_to_fixed_record_type_1)
8672         (template_to_static_fixed_type)
8673         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8674         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8675         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8676         macros.
8677
8678 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8679
8680         PR symtab/24423:
8681         * source.c (print_source_lines_base): Advance "iter" when a
8682         control character is seen.
8683
8684 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8685
8686         * inferior.h (struct infcall_suspend_state_deleter):
8687         Catch exception in destructor to avoid crash.
8688
8689 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8690
8691         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8692         close to the add_com "shell".
8693
8694 2019-04-18  Tom Tromey  <tromey@adacore.com>
8695
8696         * process-stratum-target.h (class process_stratum_target)
8697         <stratum>: Add "final".
8698
8699 2019-04-17  Tom Tromey  <tromey@adacore.com>
8700
8701         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8702         against nullptr before use.
8703
8704 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8705
8706         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8707
8708 2019-04-17  Jim Wilson  <jimw@sifive.com>
8709             Andrew Burgess  <andrew.burgess@embecosm.com>
8710
8711         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8712         code read might fail, assume 4-byte breakpoint in that case.
8713
8714 2019-04-15  Leszek Swirski  <leszeks@google.com>
8715
8716         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8717         rather than a hand-rolled POD check when checking for forced MEMORY
8718         classification.
8719
8720 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8721
8722         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8723         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8724         function.
8725         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8726         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8727         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8728         declaration.
8729
8730 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8731
8732         * aarch64-linux-nat.c
8733         (aarch64_linux_nat_target::thread_architecture): Add override.
8734         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8735         each VQ.
8736
8737 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8738
8739         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8740
8741 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8742
8743         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8744         target types of size 96-bits, add some additional comments, and
8745         check that the builtin type we found was the correct size.
8746
8747 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8748
8749         * utils.c (prompt_for_continue): Don't restore the styling at the
8750         end, as applied_style has the wrong value.  This fixes styling in
8751         long lists of file names that are interrupted by the "Continue?"
8752         prompt.
8753
8754 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8755
8756         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8757         * c-lang.c (c_language_defn): Likewise.
8758         (cplus_language_defn): Likewise.
8759         (asm_language_defn): Likewise.
8760         (minimal_language_defn): Likewise.
8761         * d-lang.c (d_language_defn): Likewise.
8762         * f-lang.c (f_language_defn): Likewise.
8763         * go-lang.c (go_language_defn): Likewise.
8764         * language.c (unknown_language_defn): Likewise.
8765         (auto_language_defn): Likewise.
8766         * language.h (struct language_defn): Remove la_magic field.
8767         (LANG_MAGIC): Delete.
8768         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8769         * objc-lang.c (objc_language_defn): Likewise.
8770         * opencl-lang.c (opencl_language_defn): Likewise.
8771         * p-lang.c (pascal_language_defn): Likewise.
8772         * rust-lang.c (rust_language_defn): Likewise.
8773
8774 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8775
8776         * riscv-tdep.c (riscv_type_align): New function.
8777         (riscv_type_alignment): Delete.
8778         (riscv_arg_location): Use 'type_align'.
8779         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8780
8781 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8782
8783         * gdbtypes.c (type_align): A struct with no non-static fields also
8784         has alignment of 1.
8785
8786 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8789         component to 0.
8790         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8791         member.
8792         (riscv_struct_info::analyse): New implementation using new
8793         analyse_inner member function.
8794         (riscv_struct_info::field_offset): New member function.
8795         (riscv_struct_info::m_offsets): New member variable.
8796         (riscv_struct_info::analyse_inner): New private member function,
8797         takes the old implementation of riscv_struct_info::analyse but
8798         extended to track field offsets.
8799         (riscv_call_arg_struct): Update the struct folding special cases
8800         to handle cases where empty C++ structs, which are non-zero
8801         length, are found.
8802         (riscv_arg_location): Initialise the length of each location, a
8803         non-zero length now indicates the location is in use.
8804         (riscv_push_dummy_call): Allow for the first location having a
8805         non-zero offset when setting up arguments.
8806         (riscv_return_value): Likewise, but for return values.
8807
8808 2019-04-11  Tom Tromey  <tromey@adacore.com>
8809
8810         * utils.c (internal_vproblem): Make "msg" const.
8811
8812 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8813
8814         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8815         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8816         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8817         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8818
8819 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8820
8821         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8822         function.
8823         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8824         of amd64_collect_native_gregset.
8825         (amd64_linux_nat_target::store_registers): Likewise.
8826
8827 2019-04-10  Tom Tromey  <tom@tromey.com>
8828
8829         * symtab.c (lookup_global_symbol_from_objfile)
8830         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8831         * objfiles.h (class separate_debug_iterator): New.
8832         (class separate_debug_range): New.
8833         (struct objfile) <separate_debug_objfiles>: New method.
8834         (objfile_separate_debug_iterate): Don't declare.
8835         * objfiles.c (separate_debug_iterator::operator++): Rename from
8836         objfile_separate_debug_iterate.
8837         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8838         iterator.
8839         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8840         iterator.
8841
8842 2019-04-10  Tom Tromey  <tom@tromey.com>
8843
8844         * symfile.c (reread_symbols): Remove old comment.
8845         * objfiles.c (free_all_objfiles): Fix a typo.
8846
8847 2019-04-10  Tom Tromey  <tom@tromey.com>
8848
8849         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8850         * minsyms.c (lookup_minimal_symbol): Use foreach.
8851         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8852         (lookup_minimal_symbol_solib_trampoline): Likewise.
8853         * symfile.c (reread_symbols): Use foreach.
8854
8855 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8856             Tom Tromey  <tromey@adacore.com>
8857
8858         PR rust/24414:
8859         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8860         (rust_lex_int_test): Change "value" to be LONGEST.
8861         (rust_lex_tests): Add test for long integer literal.
8862
8863 2019-04-09  Tom Tromey  <tromey@adacore.com>
8864
8865         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8866         to bool.
8867         (extended_remote_target::attach): Update.
8868         (remote_target::remote_notice_new_inferior): Update.
8869         (remote_target::add_current_inferior_and_thread): Update.
8870         * inferior.c (exit_inferior_1): Use "false".
8871         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8872
8873 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8874
8875         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8876         the "start" command.
8877
8878 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8879
8880         * python/py-inferior.c (infpy_thread_from_thread_handle):
8881         Adjust comments to reflect renaming of thread_from_thread_handle
8882         to thread_from_handle.  Adjust keywords.  Fix type error message.
8883         (inferior_object_methods): Add thread_from_handle.  Retain
8884         thread_from_thread_handle, but mark it as deprecated.
8885
8886 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8887
8888         * gdbthread.h (find_thread_by_handle): Revise declaration.
8889         * thread.c (find_thread_by_handle): Likewise.  Adjust
8890         implementation too.
8891         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8892         support for buffer objects as handles.
8893
8894 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8895
8896         * python/py-infthread.c (thpy_thread_handle): New function.
8897         (thread_object_methods): Register thpy_thread_handle.
8898
8899 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8900
8901         * gdbthread.h (thread_to_thread_handle): Declare.
8902         * thread.c (gdbtypes.h): Include.
8903         (thread_to_thread_handle): New function.
8904
8905         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8906         (target_thread_info_to_thread_handle): Declare.
8907         * target.c (target_thread_info_to_thread_handle): New function.
8908         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8909         * target-delegates.c: Regenerate.
8910
8911         * linux-thread-db.c (class thread_db_target): Add method
8912         thread_info_to_thread_handle.
8913         (thread_db_target::thread_info_to_thread_handle): Define.
8914         * remote.c (class remote_target): Add new method
8915         thread_info_to_thread_handle.
8916         (remote_target::thread_info_to_thread_handle): Define.
8917
8918 2019-04-08  Pedro Alves  <palves@redhat.com>
8919
8920         * common/common-exceptions.c (throw_exception): Don't create
8921         named object to throw; throw directly.
8922         (throw_it): Likewise.  Don't initialize gdb_exception::message
8923         here, with new; pass FMT and AP to the ctor instead.
8924         * common/common-exceptions.h: Include <string>.
8925         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8926         const char *, va_list)): New ctor.  Use std::make_shared.
8927         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8928         errors)): Delete.
8929         (gdb_exception_error::gdb_exception_error(enum errors, const char
8930         *, va_list)): New.
8931         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8932         Add assertion.
8933         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8934         errors)): Delete.
8935         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8936         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8937         Add assertion.
8938
8939 2019-04-08  Tom Tromey  <tom@tromey.com>
8940
8941         * valops.c (value_rtti_indirect_type): Replace throw_exception
8942         with throw.
8943         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8944         with throw.
8945         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8946         throw.
8947         * target.c (target_translate_tls_address): Replace throw_exception
8948         with throw.
8949         * stack.c (frame_apply_command_count): Replace throw_exception
8950         with throw.
8951         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8952         throw.
8953         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8954         with throw.
8955         * rs6000-tdep.c (rs6000_frame_cache)
8956         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8957         * remote.c: Replace throw_exception with throw.
8958         * record-full.c (record_full_message, record_full_wait_1)
8959         (record_full_restore): Replace throw_exception with throw.
8960         * record-btrace.c:
8961         (get_thread_current_frame_id, record_btrace_start_replaying)
8962         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8963         (cmd_record_btrace_start): Replace throw_exception with throw.
8964         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8965         throw.
8966         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8967         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8968         * linespec.c:
8969         (find_linespec_symbols): Replace throw_exception with throw.
8970         * infrun.c (displaced_step_prepare, resume): Replace
8971         throw_exception with throw.
8972         * infcmd.c (post_create_inferior): Replace throw_exception with
8973         throw.
8974         * inf-loop.c (inferior_event_handler): Replace throw_exception
8975         with throw.
8976         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8977         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8978         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8979         (get_prev_frame_always, get_frame_pc_if_available)
8980         (get_frame_address_in_block_if_available, get_frame_language):
8981         Replace throw_exception with throw.
8982         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8983         throw_exception with throw.
8984         * eval.c (fetch_subexp_value, evaluate_var_value)
8985         (evaluate_funcall, evaluate_subexp_standard): Replace
8986         throw_exception with throw.
8987         * dwarf2loc.c (call_site_find_chain)
8988         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8989         Replace throw_exception with throw.
8990         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8991         with throw.
8992         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8993         throw.
8994         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8995         * completer.c (complete_line_internal): Replace throw_exception
8996         with throw.
8997         * compile/compile-object-run.c (compile_object_run): Replace
8998         throw_exception with throw.
8999         * cli/cli-script.c (process_next_line): Replace throw_exception
9000         with throw.
9001         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9002         (btrace_enable, btrace_maint_update_pt_packets): Replace
9003         throw_exception with throw.
9004         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9005         throw_exception with throw.
9006         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9007         throw_exception with throw.
9008         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9009         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9010         * aarch64-tdep.c (aarch64_make_prologue_cache)
9011         (aarch64_make_stub_cache): Replace throw_exception with throw.
9012
9013 2019-04-08  Tom Tromey  <tom@tromey.com>
9014
9015         * common/common-exceptions.c (throw_exception): Rename from
9016         throw_exception_cxx.  Remove old copy.  Make argument const.
9017         (throw_it): Create and throw exception objects directly.
9018         * common/common-exceptions.h (throw_exception): Make argument
9019         const.
9020         (struct gdb_exception_error): Add constructor.
9021         (struct gdb_exception_quit): Add constructor.
9022
9023 2019-04-08  Tom Tromey  <tom@tromey.com>
9024
9025         * common/common-exceptions.h (exception_rethrow): Don't declare.
9026         (TRY_SJLJ): Update comment.
9027         (TRY, CATCH, END_CATCH): Remove.
9028         * common/common-exceptions.c (exception_rethrow): Remove.
9029
9030 2019-04-08  Tom Tromey  <tom@tromey.com>
9031
9032         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9033         Remove.
9034         (gdb_exception_error): Rename from
9035         gdb_exception_RETURN_MASK_ERROR.
9036         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9037         (gdb_quit_bad_alloc): Update.
9038         * aarch64-tdep.c: Update.
9039         * ada-lang.c: Update.
9040         * ada-typeprint.c: Update.
9041         * ada-valprint.c: Update.
9042         * amd64-tdep.c: Update.
9043         * arch-utils.c: Update.
9044         * break-catch-throw.c: Update.
9045         * breakpoint.c: Update.
9046         * btrace.c: Update.
9047         * c-varobj.c: Update.
9048         * cli/cli-cmds.c: Update.
9049         * cli/cli-interp.c: Update.
9050         * cli/cli-script.c: Update.
9051         * common/common-exceptions.c: Update.
9052         * common/new-op.c: Update.
9053         * common/selftest.c: Update.
9054         * compile/compile-c-symbols.c: Update.
9055         * compile/compile-cplus-symbols.c: Update.
9056         * compile/compile-object-load.c: Update.
9057         * compile/compile-object-run.c: Update.
9058         * completer.c: Update.
9059         * corelow.c: Update.
9060         * cp-abi.c: Update.
9061         * cp-support.c: Update.
9062         * cp-valprint.c: Update.
9063         * darwin-nat.c: Update.
9064         * disasm-selftests.c: Update.
9065         * dtrace-probe.c: Update.
9066         * dwarf-index-cache.c: Update.
9067         * dwarf-index-write.c: Update.
9068         * dwarf2-frame-tailcall.c: Update.
9069         * dwarf2-frame.c: Update.
9070         * dwarf2loc.c: Update.
9071         * dwarf2read.c: Update.
9072         * eval.c: Update.
9073         * event-loop.c: Update.
9074         * event-top.c: Update.
9075         * exec.c: Update.
9076         * f-valprint.c: Update.
9077         * fbsd-tdep.c: Update.
9078         * frame-unwind.c: Update.
9079         * frame.c: Update.
9080         * gdbtypes.c: Update.
9081         * gnu-v3-abi.c: Update.
9082         * guile/guile-internal.h: Update.
9083         * guile/scm-block.c: Update.
9084         * guile/scm-breakpoint.c: Update.
9085         * guile/scm-cmd.c: Update.
9086         * guile/scm-disasm.c: Update.
9087         * guile/scm-frame.c: Update.
9088         * guile/scm-lazy-string.c: Update.
9089         * guile/scm-math.c: Update.
9090         * guile/scm-param.c: Update.
9091         * guile/scm-ports.c: Update.
9092         * guile/scm-pretty-print.c: Update.
9093         * guile/scm-symbol.c: Update.
9094         * guile/scm-symtab.c: Update.
9095         * guile/scm-type.c: Update.
9096         * guile/scm-value.c: Update.
9097         * i386-linux-tdep.c: Update.
9098         * i386-tdep.c: Update.
9099         * inf-loop.c: Update.
9100         * infcall.c: Update.
9101         * infcmd.c: Update.
9102         * infrun.c: Update.
9103         * jit.c: Update.
9104         * language.c: Update.
9105         * linespec.c: Update.
9106         * linux-fork.c: Update.
9107         * linux-nat.c: Update.
9108         * linux-tdep.c: Update.
9109         * linux-thread-db.c: Update.
9110         * main.c: Update.
9111         * mi/mi-cmd-break.c: Update.
9112         * mi/mi-cmd-stack.c: Update.
9113         * mi/mi-interp.c: Update.
9114         * mi/mi-main.c: Update.
9115         * objc-lang.c: Update.
9116         * p-valprint.c: Update.
9117         * parse.c: Update.
9118         * ppc-linux-tdep.c: Update.
9119         * printcmd.c: Update.
9120         * python/py-arch.c: Update.
9121         * python/py-breakpoint.c: Update.
9122         * python/py-cmd.c: Update.
9123         * python/py-finishbreakpoint.c: Update.
9124         * python/py-frame.c: Update.
9125         * python/py-framefilter.c: Update.
9126         * python/py-gdb-readline.c: Update.
9127         * python/py-inferior.c: Update.
9128         * python/py-infthread.c: Update.
9129         * python/py-lazy-string.c: Update.
9130         * python/py-linetable.c: Update.
9131         * python/py-objfile.c: Update.
9132         * python/py-param.c: Update.
9133         * python/py-prettyprint.c: Update.
9134         * python/py-progspace.c: Update.
9135         * python/py-record-btrace.c: Update.
9136         * python/py-record.c: Update.
9137         * python/py-symbol.c: Update.
9138         * python/py-type.c: Update.
9139         * python/py-unwind.c: Update.
9140         * python/py-utils.c: Update.
9141         * python/py-value.c: Update.
9142         * python/python.c: Update.
9143         * record-btrace.c: Update.
9144         * record-full.c: Update.
9145         * remote-fileio.c: Update.
9146         * remote.c: Update.
9147         * riscv-tdep.c: Update.
9148         * rs6000-aix-tdep.c: Update.
9149         * rs6000-tdep.c: Update.
9150         * rust-exp.y: Update.
9151         * rust-lang.c: Update.
9152         * s390-tdep.c: Update.
9153         * selftest-arch.c: Update.
9154         * solib-dsbt.c: Update.
9155         * solib-frv.c: Update.
9156         * solib-spu.c: Update.
9157         * solib-svr4.c: Update.
9158         * solib.c: Update.
9159         * sparc64-linux-tdep.c: Update.
9160         * stack.c: Update.
9161         * symfile-mem.c: Update.
9162         * symmisc.c: Update.
9163         * target.c: Update.
9164         * thread.c: Update.
9165         * top.c: Update.
9166         * tracefile-tfile.c: Update.
9167         * tui/tui.c: Update.
9168         * typeprint.c: Update.
9169         * unittests/cli-utils-selftests.c: Update.
9170         * unittests/parse-connection-spec-selftests.c: Update.
9171         * valops.c: Update.
9172         * valprint.c: Update.
9173         * value.c: Update.
9174         * varobj.c: Update.
9175         * windows-nat.c: Update.
9176         * x86-linux-nat.c: Update.
9177         * xml-support.c: Update.
9178
9179 2019-04-08  Tom Tromey  <tom@tromey.com>
9180
9181         * xml-support.c: Use C++ exception handling.
9182         * x86-linux-nat.c: Use C++ exception handling.
9183         * windows-nat.c: Use C++ exception handling.
9184         * varobj.c: Use C++ exception handling.
9185         * value.c: Use C++ exception handling.
9186         * valprint.c: Use C++ exception handling.
9187         * valops.c: Use C++ exception handling.
9188         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9189         handling.
9190         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9191         * typeprint.c: Use C++ exception handling.
9192         * tui/tui.c: Use C++ exception handling.
9193         * tracefile-tfile.c: Use C++ exception handling.
9194         * top.c: Use C++ exception handling.
9195         * thread.c: Use C++ exception handling.
9196         * target.c: Use C++ exception handling.
9197         * symmisc.c: Use C++ exception handling.
9198         * symfile-mem.c: Use C++ exception handling.
9199         * stack.c: Use C++ exception handling.
9200         * sparc64-linux-tdep.c: Use C++ exception handling.
9201         * solib.c: Use C++ exception handling.
9202         * solib-svr4.c: Use C++ exception handling.
9203         * solib-spu.c: Use C++ exception handling.
9204         * solib-frv.c: Use C++ exception handling.
9205         * solib-dsbt.c: Use C++ exception handling.
9206         * selftest-arch.c: Use C++ exception handling.
9207         * s390-tdep.c: Use C++ exception handling.
9208         * rust-lang.c: Use C++ exception handling.
9209         * rust-exp.y: Use C++ exception handling.
9210         * rs6000-tdep.c: Use C++ exception handling.
9211         * rs6000-aix-tdep.c: Use C++ exception handling.
9212         * riscv-tdep.c: Use C++ exception handling.
9213         * remote.c: Use C++ exception handling.
9214         * remote-fileio.c: Use C++ exception handling.
9215         * record-full.c: Use C++ exception handling.
9216         * record-btrace.c: Use C++ exception handling.
9217         * python/python.c: Use C++ exception handling.
9218         * python/py-value.c: Use C++ exception handling.
9219         * python/py-utils.c: Use C++ exception handling.
9220         * python/py-unwind.c: Use C++ exception handling.
9221         * python/py-type.c: Use C++ exception handling.
9222         * python/py-symbol.c: Use C++ exception handling.
9223         * python/py-record.c: Use C++ exception handling.
9224         * python/py-record-btrace.c: Use C++ exception handling.
9225         * python/py-progspace.c: Use C++ exception handling.
9226         * python/py-prettyprint.c: Use C++ exception handling.
9227         * python/py-param.c: Use C++ exception handling.
9228         * python/py-objfile.c: Use C++ exception handling.
9229         * python/py-linetable.c: Use C++ exception handling.
9230         * python/py-lazy-string.c: Use C++ exception handling.
9231         * python/py-infthread.c: Use C++ exception handling.
9232         * python/py-inferior.c: Use C++ exception handling.
9233         * python/py-gdb-readline.c: Use C++ exception handling.
9234         * python/py-framefilter.c: Use C++ exception handling.
9235         * python/py-frame.c: Use C++ exception handling.
9236         * python/py-finishbreakpoint.c: Use C++ exception handling.
9237         * python/py-cmd.c: Use C++ exception handling.
9238         * python/py-breakpoint.c: Use C++ exception handling.
9239         * python/py-arch.c: Use C++ exception handling.
9240         * printcmd.c: Use C++ exception handling.
9241         * ppc-linux-tdep.c: Use C++ exception handling.
9242         * parse.c: Use C++ exception handling.
9243         * p-valprint.c: Use C++ exception handling.
9244         * objc-lang.c: Use C++ exception handling.
9245         * mi/mi-main.c: Use C++ exception handling.
9246         * mi/mi-interp.c: Use C++ exception handling.
9247         * mi/mi-cmd-stack.c: Use C++ exception handling.
9248         * mi/mi-cmd-break.c: Use C++ exception handling.
9249         * main.c: Use C++ exception handling.
9250         * linux-thread-db.c: Use C++ exception handling.
9251         * linux-tdep.c: Use C++ exception handling.
9252         * linux-nat.c: Use C++ exception handling.
9253         * linux-fork.c: Use C++ exception handling.
9254         * linespec.c: Use C++ exception handling.
9255         * language.c: Use C++ exception handling.
9256         * jit.c: Use C++ exception handling.
9257         * infrun.c: Use C++ exception handling.
9258         * infcmd.c: Use C++ exception handling.
9259         * infcall.c: Use C++ exception handling.
9260         * inf-loop.c: Use C++ exception handling.
9261         * i386-tdep.c: Use C++ exception handling.
9262         * i386-linux-tdep.c: Use C++ exception handling.
9263         * guile/scm-value.c: Use C++ exception handling.
9264         * guile/scm-type.c: Use C++ exception handling.
9265         * guile/scm-symtab.c: Use C++ exception handling.
9266         * guile/scm-symbol.c: Use C++ exception handling.
9267         * guile/scm-pretty-print.c: Use C++ exception handling.
9268         * guile/scm-ports.c: Use C++ exception handling.
9269         * guile/scm-param.c: Use C++ exception handling.
9270         * guile/scm-math.c: Use C++ exception handling.
9271         * guile/scm-lazy-string.c: Use C++ exception handling.
9272         * guile/scm-frame.c: Use C++ exception handling.
9273         * guile/scm-disasm.c: Use C++ exception handling.
9274         * guile/scm-cmd.c: Use C++ exception handling.
9275         * guile/scm-breakpoint.c: Use C++ exception handling.
9276         * guile/scm-block.c: Use C++ exception handling.
9277         * guile/guile-internal.h: Use C++ exception handling.
9278         * gnu-v3-abi.c: Use C++ exception handling.
9279         * gdbtypes.c: Use C++ exception handling.
9280         * frame.c: Use C++ exception handling.
9281         * frame-unwind.c: Use C++ exception handling.
9282         * fbsd-tdep.c: Use C++ exception handling.
9283         * f-valprint.c: Use C++ exception handling.
9284         * exec.c: Use C++ exception handling.
9285         * event-top.c: Use C++ exception handling.
9286         * event-loop.c: Use C++ exception handling.
9287         * eval.c: Use C++ exception handling.
9288         * dwarf2read.c: Use C++ exception handling.
9289         * dwarf2loc.c: Use C++ exception handling.
9290         * dwarf2-frame.c: Use C++ exception handling.
9291         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9292         * dwarf-index-write.c: Use C++ exception handling.
9293         * dwarf-index-cache.c: Use C++ exception handling.
9294         * dtrace-probe.c: Use C++ exception handling.
9295         * disasm-selftests.c: Use C++ exception handling.
9296         * darwin-nat.c: Use C++ exception handling.
9297         * cp-valprint.c: Use C++ exception handling.
9298         * cp-support.c: Use C++ exception handling.
9299         * cp-abi.c: Use C++ exception handling.
9300         * corelow.c: Use C++ exception handling.
9301         * completer.c: Use C++ exception handling.
9302         * compile/compile-object-run.c: Use C++ exception handling.
9303         * compile/compile-object-load.c: Use C++ exception handling.
9304         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9305         * compile/compile-c-symbols.c: Use C++ exception handling.
9306         * common/selftest.c: Use C++ exception handling.
9307         * common/new-op.c: Use C++ exception handling.
9308         * cli/cli-script.c: Use C++ exception handling.
9309         * cli/cli-interp.c: Use C++ exception handling.
9310         * cli/cli-cmds.c: Use C++ exception handling.
9311         * c-varobj.c: Use C++ exception handling.
9312         * btrace.c: Use C++ exception handling.
9313         * breakpoint.c: Use C++ exception handling.
9314         * break-catch-throw.c: Use C++ exception handling.
9315         * arch-utils.c: Use C++ exception handling.
9316         * amd64-tdep.c: Use C++ exception handling.
9317         * ada-valprint.c: Use C++ exception handling.
9318         * ada-typeprint.c: Use C++ exception handling.
9319         * ada-lang.c: Use C++ exception handling.
9320         * aarch64-tdep.c: Use C++ exception handling.
9321
9322 2019-04-08  Tom Tromey  <tom@tromey.com>
9323
9324         * xml-support.c (gdb_xml_parser::parse): Update.
9325         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9326         * value.c (show_convenience): Update.
9327         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9328         (test_parse_flags_qcs): Update.
9329         * thread.c (thr_try_catch_cmd): Update.
9330         * target.c (target_translate_tls_address): Update.
9331         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9332         (info_frame_command_core, frame_apply_command_count): Update.
9333         * rust-exp.y (rust_lex_exception_test): Update.
9334         * riscv-tdep.c (riscv_print_one_register_info): Update.
9335         * remote.c (remote_target::enable_btrace): Update.
9336         * record-btrace.c (record_btrace_enable_warn): Update.
9337         * python/py-utils.c (gdbpy_convert_exception): Update.
9338         * printcmd.c (do_one_display, print_variable_and_value): Update.
9339         * mi/mi-main.c (mi_print_exception): Update.
9340         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9341         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9342         * linux-nat.c (linux_nat_target::attach): Update.
9343         * linux-fork.c (class scoped_switch_fork_info): Update.
9344         * infrun.c (displaced_step_prepare): Update.
9345         * infcall.c (call_function_by_hand_dummy): Update.
9346         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9347         * gnu-v3-abi.c (print_one_vtable): Update.
9348         * frame.c (get_prev_frame_always): Update.
9349         * f-valprint.c (info_common_command_for_block): Update.
9350         * exec.c (try_open_exec_file): Update.
9351         * exceptions.c (print_exception, exception_print)
9352         (exception_fprintf, exception_print_same): Update.
9353         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9354         * dwarf-index-cache.c (index_cache::store)
9355         (index_cache::lookup_gdb_index): Update.
9356         * darwin-nat.c (maybe_cache_shell): Update.
9357         * cp-valprint.c (cp_print_value_fields): Update.
9358         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9359         (gcc_cplus_symbol_address): Update.
9360         * compile/compile-c-symbols.c (gcc_convert_symbol)
9361         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9362         * common/selftest.c: Update.
9363         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9364         a std::string.
9365         (exception_try_scope_entry, exception_try_scope_exit): Don't
9366         declare.
9367         (struct exception_try_scope): Remove.
9368         (TRY): Don't use exception_try_scope.
9369         (struct gdb_exception): Add constructor, operator=.
9370         <what>: New method.
9371         (struct gdb_exception_RETURN_MASK_ALL)
9372         (struct gdb_exception_RETURN_MASK_ERROR)
9373         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9374         (struct gdb_quit_bad_alloc): Update.
9375         * common/common-exceptions.c (exception_none): Change
9376         initializer.
9377         (struct catcher) <state, exception>: Initialize inline.
9378         <prev>: Remove member.
9379         (current_catcher): Remove.
9380         (catchers): New global.
9381         (exceptions_state_mc_init): Simplify.
9382         (catcher_pop): Remove.
9383         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9384         (try_scope_depth, exception_try_scope_entry)
9385         (exception_try_scope_exit): Remove.
9386         (throw_exception_sjlj): Update.
9387         (exception_messages, exception_messages_size): Remove.
9388         (throw_it): Simplify.
9389         (gdb_exception_sliced_copy): Remove.
9390         (throw_exception_cxx): Update.
9391         * cli/cli-script.c (script_from_file): Update.
9392         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9393         Update.
9394         * ada-valprint.c (ada_val_print): Update.
9395         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9396         (create_excep_cond_exprs): Update.
9397
9398 2019-04-08  Tom Tromey  <tom@tromey.com>
9399
9400         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9401         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9402         (TRY, CATCH, END_CATCH): Remove some definitions.
9403         * common/common-exceptions.c: Don't use GDB_XCPT.
9404         (catcher_list_size): Remove.
9405         (throw_exception, throw_it): Simplify.
9406
9407 2019-04-05  Tom Tromey  <tom@tromey.com>
9408
9409         Revert the header-sorting patch.
9410         * ft32-tdep.c: Revert.
9411         * frv-tdep.c: Revert.
9412         * frv-linux-tdep.c: Revert.
9413         * frame.c: Revert.
9414         * frame-unwind.c: Revert.
9415         * frame-base.c: Revert.
9416         * fork-child.c: Revert.
9417         * findvar.c: Revert.
9418         * findcmd.c: Revert.
9419         * filesystem.c: Revert.
9420         * filename-seen-cache.h: Revert.
9421         * filename-seen-cache.c: Revert.
9422         * fbsd-tdep.c: Revert.
9423         * fbsd-nat.h: Revert.
9424         * fbsd-nat.c: Revert.
9425         * f-valprint.c: Revert.
9426         * f-typeprint.c: Revert.
9427         * f-lang.c: Revert.
9428         * extension.h: Revert.
9429         * extension.c: Revert.
9430         * extension-priv.h: Revert.
9431         * expprint.c: Revert.
9432         * exec.h: Revert.
9433         * exec.c: Revert.
9434         * exceptions.c: Revert.
9435         * event-top.c: Revert.
9436         * event-loop.c: Revert.
9437         * eval.c: Revert.
9438         * elfread.c: Revert.
9439         * dwarf2read.h: Revert.
9440         * dwarf2read.c: Revert.
9441         * dwarf2loc.c: Revert.
9442         * dwarf2expr.h: Revert.
9443         * dwarf2expr.c: Revert.
9444         * dwarf2-frame.c: Revert.
9445         * dwarf2-frame-tailcall.c: Revert.
9446         * dwarf-index-write.h: Revert.
9447         * dwarf-index-write.c: Revert.
9448         * dwarf-index-common.c: Revert.
9449         * dwarf-index-cache.h: Revert.
9450         * dwarf-index-cache.c: Revert.
9451         * dummy-frame.c: Revert.
9452         * dtrace-probe.c: Revert.
9453         * disasm.h: Revert.
9454         * disasm.c: Revert.
9455         * disasm-selftests.c: Revert.
9456         * dictionary.c: Revert.
9457         * dicos-tdep.c: Revert.
9458         * demangle.c: Revert.
9459         * dcache.h: Revert.
9460         * dcache.c: Revert.
9461         * darwin-nat.h: Revert.
9462         * darwin-nat.c: Revert.
9463         * darwin-nat-info.c: Revert.
9464         * d-valprint.c: Revert.
9465         * d-namespace.c: Revert.
9466         * d-lang.c: Revert.
9467         * ctf.c: Revert.
9468         * csky-tdep.c: Revert.
9469         * csky-linux-tdep.c: Revert.
9470         * cris-tdep.c: Revert.
9471         * cris-linux-tdep.c: Revert.
9472         * cp-valprint.c: Revert.
9473         * cp-support.c: Revert.
9474         * cp-namespace.c: Revert.
9475         * cp-abi.c: Revert.
9476         * corelow.c: Revert.
9477         * corefile.c: Revert.
9478         * continuations.c: Revert.
9479         * completer.h: Revert.
9480         * completer.c: Revert.
9481         * complaints.c: Revert.
9482         * coffread.c: Revert.
9483         * coff-pe-read.c: Revert.
9484         * cli-out.h: Revert.
9485         * cli-out.c: Revert.
9486         * charset.c: Revert.
9487         * c-varobj.c: Revert.
9488         * c-valprint.c: Revert.
9489         * c-typeprint.c: Revert.
9490         * c-lang.c: Revert.
9491         * buildsym.c: Revert.
9492         * buildsym-legacy.c: Revert.
9493         * build-id.h: Revert.
9494         * build-id.c: Revert.
9495         * btrace.c: Revert.
9496         * bsd-uthread.c: Revert.
9497         * breakpoint.h: Revert.
9498         * breakpoint.c: Revert.
9499         * break-catch-throw.c: Revert.
9500         * break-catch-syscall.c: Revert.
9501         * break-catch-sig.c: Revert.
9502         * blockframe.c: Revert.
9503         * block.c: Revert.
9504         * bfin-tdep.c: Revert.
9505         * bfin-linux-tdep.c: Revert.
9506         * bfd-target.c: Revert.
9507         * bcache.c: Revert.
9508         * ax-general.c: Revert.
9509         * ax-gdb.h: Revert.
9510         * ax-gdb.c: Revert.
9511         * avr-tdep.c: Revert.
9512         * auxv.c: Revert.
9513         * auto-load.c: Revert.
9514         * arm-wince-tdep.c: Revert.
9515         * arm-tdep.c: Revert.
9516         * arm-symbian-tdep.c: Revert.
9517         * arm-pikeos-tdep.c: Revert.
9518         * arm-obsd-tdep.c: Revert.
9519         * arm-nbsd-tdep.c: Revert.
9520         * arm-nbsd-nat.c: Revert.
9521         * arm-linux-tdep.c: Revert.
9522         * arm-linux-nat.c: Revert.
9523         * arm-fbsd-tdep.c: Revert.
9524         * arm-fbsd-nat.c: Revert.
9525         * arm-bsd-tdep.c: Revert.
9526         * arch-utils.c: Revert.
9527         * arc-tdep.c: Revert.
9528         * arc-newlib-tdep.c: Revert.
9529         * annotate.h: Revert.
9530         * annotate.c: Revert.
9531         * amd64-windows-tdep.c: Revert.
9532         * amd64-windows-nat.c: Revert.
9533         * amd64-tdep.c: Revert.
9534         * amd64-sol2-tdep.c: Revert.
9535         * amd64-obsd-tdep.c: Revert.
9536         * amd64-obsd-nat.c: Revert.
9537         * amd64-nbsd-tdep.c: Revert.
9538         * amd64-nbsd-nat.c: Revert.
9539         * amd64-nat.c: Revert.
9540         * amd64-linux-tdep.c: Revert.
9541         * amd64-linux-nat.c: Revert.
9542         * amd64-fbsd-tdep.c: Revert.
9543         * amd64-fbsd-nat.c: Revert.
9544         * amd64-dicos-tdep.c: Revert.
9545         * amd64-darwin-tdep.c: Revert.
9546         * amd64-bsd-nat.c: Revert.
9547         * alpha-tdep.c: Revert.
9548         * alpha-obsd-tdep.c: Revert.
9549         * alpha-nbsd-tdep.c: Revert.
9550         * alpha-mdebug-tdep.c: Revert.
9551         * alpha-linux-tdep.c: Revert.
9552         * alpha-linux-nat.c: Revert.
9553         * alpha-bsd-tdep.c: Revert.
9554         * alpha-bsd-nat.c: Revert.
9555         * aix-thread.c: Revert.
9556         * agent.c: Revert.
9557         * addrmap.c: Revert.
9558         * ada-varobj.c: Revert.
9559         * ada-valprint.c: Revert.
9560         * ada-typeprint.c: Revert.
9561         * ada-tasks.c: Revert.
9562         * ada-lang.c: Revert.
9563         * aarch64-tdep.c: Revert.
9564         * aarch64-ravenscar-thread.c: Revert.
9565         * aarch64-newlib-tdep.c: Revert.
9566         * aarch64-linux-tdep.c: Revert.
9567         * aarch64-linux-nat.c: Revert.
9568         * aarch64-fbsd-tdep.c: Revert.
9569         * aarch64-fbsd-nat.c: Revert.
9570         * aarch32-linux-nat.c: Revert.
9571
9572 2019-04-05  Tom Tromey  <tom@tromey.com>
9573
9574         * ft32-tdep.c: Sort headers.
9575         * frv-tdep.c: Sort headers.
9576         * frv-linux-tdep.c: Sort headers.
9577         * frame.c: Sort headers.
9578         * frame-unwind.c: Sort headers.
9579         * frame-base.c: Sort headers.
9580         * fork-child.c: Sort headers.
9581         * findvar.c: Sort headers.
9582         * findcmd.c: Sort headers.
9583         * filesystem.c: Sort headers.
9584         * filename-seen-cache.h: Sort headers.
9585         * filename-seen-cache.c: Sort headers.
9586         * fbsd-tdep.c: Sort headers.
9587         * fbsd-nat.h: Sort headers.
9588         * fbsd-nat.c: Sort headers.
9589         * f-valprint.c: Sort headers.
9590         * f-typeprint.c: Sort headers.
9591         * f-lang.c: Sort headers.
9592         * extension.h: Sort headers.
9593         * extension.c: Sort headers.
9594         * extension-priv.h: Sort headers.
9595         * expprint.c: Sort headers.
9596         * exec.h: Sort headers.
9597         * exec.c: Sort headers.
9598         * exceptions.c: Sort headers.
9599         * event-top.c: Sort headers.
9600         * event-loop.c: Sort headers.
9601         * eval.c: Sort headers.
9602         * elfread.c: Sort headers.
9603         * dwarf2read.h: Sort headers.
9604         * dwarf2read.c: Sort headers.
9605         * dwarf2loc.c: Sort headers.
9606         * dwarf2expr.h: Sort headers.
9607         * dwarf2expr.c: Sort headers.
9608         * dwarf2-frame.c: Sort headers.
9609         * dwarf2-frame-tailcall.c: Sort headers.
9610         * dwarf-index-write.h: Sort headers.
9611         * dwarf-index-write.c: Sort headers.
9612         * dwarf-index-common.c: Sort headers.
9613         * dwarf-index-cache.h: Sort headers.
9614         * dwarf-index-cache.c: Sort headers.
9615         * dummy-frame.c: Sort headers.
9616         * dtrace-probe.c: Sort headers.
9617         * disasm.h: Sort headers.
9618         * disasm.c: Sort headers.
9619         * disasm-selftests.c: Sort headers.
9620         * dictionary.c: Sort headers.
9621         * dicos-tdep.c: Sort headers.
9622         * demangle.c: Sort headers.
9623         * dcache.h: Sort headers.
9624         * dcache.c: Sort headers.
9625         * darwin-nat.h: Sort headers.
9626         * darwin-nat.c: Sort headers.
9627         * darwin-nat-info.c: Sort headers.
9628         * d-valprint.c: Sort headers.
9629         * d-namespace.c: Sort headers.
9630         * d-lang.c: Sort headers.
9631         * ctf.c: Sort headers.
9632         * csky-tdep.c: Sort headers.
9633         * csky-linux-tdep.c: Sort headers.
9634         * cris-tdep.c: Sort headers.
9635         * cris-linux-tdep.c: Sort headers.
9636         * cp-valprint.c: Sort headers.
9637         * cp-support.c: Sort headers.
9638         * cp-namespace.c: Sort headers.
9639         * cp-abi.c: Sort headers.
9640         * corelow.c: Sort headers.
9641         * corefile.c: Sort headers.
9642         * continuations.c: Sort headers.
9643         * completer.h: Sort headers.
9644         * completer.c: Sort headers.
9645         * complaints.c: Sort headers.
9646         * coffread.c: Sort headers.
9647         * coff-pe-read.c: Sort headers.
9648         * cli-out.h: Sort headers.
9649         * cli-out.c: Sort headers.
9650         * charset.c: Sort headers.
9651         * c-varobj.c: Sort headers.
9652         * c-valprint.c: Sort headers.
9653         * c-typeprint.c: Sort headers.
9654         * c-lang.c: Sort headers.
9655         * buildsym.c: Sort headers.
9656         * buildsym-legacy.c: Sort headers.
9657         * build-id.h: Sort headers.
9658         * build-id.c: Sort headers.
9659         * btrace.c: Sort headers.
9660         * bsd-uthread.c: Sort headers.
9661         * breakpoint.h: Sort headers.
9662         * breakpoint.c: Sort headers.
9663         * break-catch-throw.c: Sort headers.
9664         * break-catch-syscall.c: Sort headers.
9665         * break-catch-sig.c: Sort headers.
9666         * blockframe.c: Sort headers.
9667         * block.c: Sort headers.
9668         * bfin-tdep.c: Sort headers.
9669         * bfin-linux-tdep.c: Sort headers.
9670         * bfd-target.c: Sort headers.
9671         * bcache.c: Sort headers.
9672         * ax-general.c: Sort headers.
9673         * ax-gdb.h: Sort headers.
9674         * ax-gdb.c: Sort headers.
9675         * avr-tdep.c: Sort headers.
9676         * auxv.c: Sort headers.
9677         * auto-load.c: Sort headers.
9678         * arm-wince-tdep.c: Sort headers.
9679         * arm-tdep.c: Sort headers.
9680         * arm-symbian-tdep.c: Sort headers.
9681         * arm-pikeos-tdep.c: Sort headers.
9682         * arm-obsd-tdep.c: Sort headers.
9683         * arm-nbsd-tdep.c: Sort headers.
9684         * arm-nbsd-nat.c: Sort headers.
9685         * arm-linux-tdep.c: Sort headers.
9686         * arm-linux-nat.c: Sort headers.
9687         * arm-fbsd-tdep.c: Sort headers.
9688         * arm-fbsd-nat.c: Sort headers.
9689         * arm-bsd-tdep.c: Sort headers.
9690         * arch-utils.c: Sort headers.
9691         * arc-tdep.c: Sort headers.
9692         * arc-newlib-tdep.c: Sort headers.
9693         * annotate.h: Sort headers.
9694         * annotate.c: Sort headers.
9695         * amd64-windows-tdep.c: Sort headers.
9696         * amd64-windows-nat.c: Sort headers.
9697         * amd64-tdep.c: Sort headers.
9698         * amd64-sol2-tdep.c: Sort headers.
9699         * amd64-obsd-tdep.c: Sort headers.
9700         * amd64-obsd-nat.c: Sort headers.
9701         * amd64-nbsd-tdep.c: Sort headers.
9702         * amd64-nbsd-nat.c: Sort headers.
9703         * amd64-nat.c: Sort headers.
9704         * amd64-linux-tdep.c: Sort headers.
9705         * amd64-linux-nat.c: Sort headers.
9706         * amd64-fbsd-tdep.c: Sort headers.
9707         * amd64-fbsd-nat.c: Sort headers.
9708         * amd64-dicos-tdep.c: Sort headers.
9709         * amd64-darwin-tdep.c: Sort headers.
9710         * amd64-bsd-nat.c: Sort headers.
9711         * alpha-tdep.c: Sort headers.
9712         * alpha-obsd-tdep.c: Sort headers.
9713         * alpha-nbsd-tdep.c: Sort headers.
9714         * alpha-mdebug-tdep.c: Sort headers.
9715         * alpha-linux-tdep.c: Sort headers.
9716         * alpha-linux-nat.c: Sort headers.
9717         * alpha-bsd-tdep.c: Sort headers.
9718         * alpha-bsd-nat.c: Sort headers.
9719         * aix-thread.c: Sort headers.
9720         * agent.c: Sort headers.
9721         * addrmap.c: Sort headers.
9722         * ada-varobj.c: Sort headers.
9723         * ada-valprint.c: Sort headers.
9724         * ada-typeprint.c: Sort headers.
9725         * ada-tasks.c: Sort headers.
9726         * ada-lang.c: Sort headers.
9727         * aarch64-tdep.c: Sort headers.
9728         * aarch64-ravenscar-thread.c: Sort headers.
9729         * aarch64-newlib-tdep.c: Sort headers.
9730         * aarch64-linux-tdep.c: Sort headers.
9731         * aarch64-linux-nat.c: Sort headers.
9732         * aarch64-fbsd-tdep.c: Sort headers.
9733         * aarch64-fbsd-nat.c: Sort headers.
9734         * aarch32-linux-nat.c: Sort headers.
9735
9736 2019-04-04  Tom Tromey  <tom@tromey.com>
9737
9738         * varobj.c (varobj_create): Update.
9739         * rust-exp.y (struct rust_parser) <update_innermost_block,
9740         lookup_symbol>: New methods.
9741         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9742         Rename.
9743         (rust_parser::rust_lookup_type)
9744         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9745         * printcmd.c (display_command, do_one_display): Update.
9746         * parser-defs.h (struct parser_state) <parser_state>: Add
9747         "tracker" parameter.
9748         (block_tracker): New member.
9749         (class innermost_block_tracker) <innermost_block_tracker>: Add
9750         "types" parameter.
9751         <reset>: Remove method.
9752         (innermost_block): Don't declare.
9753         (null_post_parser): Update.
9754         * parse.c (innermost_block): Remove global.
9755         (write_dollar_variable): Update.
9756         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9757         Remove "tracker_types" parameter.
9758         (parse_expression): Add "tracker" parameter.
9759         (parse_expression_for_completion): Update.
9760         (null_post_parser): Add "tracker" parameter.
9761         * p-exp.y: Update rules.
9762         * m2-exp.y: Update rules.
9763         * language.h (struct language_defn) <la_post_parser>: Add
9764         "tracker" parameter.
9765         * go-exp.y: Update rules.
9766         * f-exp.y: Update rules.
9767         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9768         parameter.
9769         * d-exp.y: Update rules.
9770         * c-exp.y: Update rules.
9771         * breakpoint.c (set_breakpoint_condition): Create an
9772         innermost_block_tracker.
9773         (watch_command_1): Likewise.
9774         * ada-lang.c (resolve): Add "tracker" parameter.
9775         (resolve_subexp): Likewise.
9776         * ada-exp.y (write_var_from_sym): Update.
9777
9778 2019-04-04  Tom Tromey  <tom@tromey.com>
9779
9780         * type-stack.h: New file.
9781         * type-stack.c: New file.
9782         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9783         type-stack.h.
9784         (insert_into_type_stack, insert_type, push_type, push_type_int)
9785         (insert_type_address_space, pop_type, pop_type_int)
9786         (pop_typelist, pop_type_stack, append_type_stack)
9787         (push_type_stack, get_type_stack, push_typelist)
9788         (follow_type_instance_flags, follow_types): Don't declare.
9789         * parse.c (type_stack): Remove global.
9790         (parse_exp_in_context): Update.
9791         (insert_into_type_stack, insert_type, push_type, push_type_int)
9792         (insert_type_address_space, pop_type, pop_type_int)
9793         (pop_typelist, pop_type_stack, append_type_stack)
9794         (push_type_stack, get_type_stack, push_typelist)
9795         (follow_type_instance_flags, follow_types): Remove (moved to
9796         type-stack.c).
9797         * f-exp.y (type_stack): New global.
9798         Update rules.
9799         (push_kind_type, f_parse): Update.
9800         * d-exp.y (type_stack): New global.
9801         Update rules.
9802         (d_parse): Update.
9803         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9804         Update rules.
9805         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9806         (HFILES_NO_SRCDIR): Add type-stack.h.
9807
9808 2019-04-04  Tom Tromey  <tom@tromey.com>
9809
9810         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9811         (rust_parser::convert_ast_to_expression, rust_parse)
9812         (rust_lex_test_completion, rust_lex_tests): Update.
9813         * parser-defs.h (struct expr_completion_state): New.
9814         (struct parser_state) <parser_state>: Add completion parameter.
9815         <mark_struct_expression, mark_completion_tag>: New methods.
9816         <parse_completion, m_completion_state>: New members.
9817         (prefixify_expression, null_post_parser): Update.
9818         (mark_struct_expression, mark_completion_tag): Don't declare.
9819         * parse.c (parse_completion, expout_last_struct)
9820         (expout_tag_completion_type, expout_completion_name): Remove
9821         globals.
9822         (parser_state::mark_struct_expression)
9823         (parser_state::mark_completion_tag): Now methods.
9824         (prefixify_expression): Add last_struct parameter.
9825         (prefixify_subexp): Likewise.
9826         (parse_exp_1): Update.
9827         (parse_exp_in_context): Add cstate parameter.  Update.
9828         (parse_expression_for_completion): Create an
9829         expr_completion_state.
9830         (null_post_parser): Add "completion" parameter.
9831         * p-exp.y: Update rules.
9832         (yylex): Update.
9833         * language.h (struct language_defn) <la_post_parser>: Add
9834         "completing" parameter.
9835         * go-exp.y: Update rules.
9836         (lex_one_token): Update.
9837         * expression.h (parse_completion): Don't declare.
9838         * d-exp.y: Update rules.
9839         (lex_one_token): Update rules.
9840         * c-exp.y: Update rules.
9841         (lex_one_token): Update.
9842         * ada-lang.c (resolve): Add "parse_completion" parameter.
9843         (resolve_subexp): Likewise.
9844         (ada_resolve_function): Likewise.
9845
9846 2019-04-04  Tom Tromey  <tom@tromey.com>
9847
9848         * parser-defs.h (struct parser_state) <start_arglist,
9849         end_arglist>: New methods.
9850         <arglist_len, m_funcall_chain>: New members.
9851         (arglist_len, start_arglist, end_arglist): Don't declare.
9852         * parse.c (arglist_len, funcall_chain): Remove global.
9853         (start_arglist, end_arglist): Remove functions.
9854         (parse_exp_in_context): Update.
9855         * p-exp.y: Update rules.
9856         * m2-exp.y: Update rules.
9857         * go-exp.y: Update rules.
9858         * f-exp.y: Update rules.
9859         * d-exp.y: Update rules.
9860         * c-exp.y: Update rules.
9861
9862 2019-04-04  Tom Tromey  <tom@tromey.com>
9863
9864         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9865         lex_operator, push_back>: New methods.
9866         Update all rules.
9867         (rust_parser::lex_hex, lex_escape): Rename and update.
9868         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9869         (rust_parser::lex_operator): Rename and update.
9870         (rust_parser::lex_number, rustyylex, rustyyerror)
9871         (rust_lex_test_init, rust_lex_test_sequence)
9872         (rust_lex_test_push_back, rust_lex_tests): Update.
9873         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9874         parameter.
9875         <lexptr, prev_lexptr>: New members.
9876         (lexptr, prev_lexptr): Don't declare.
9877         * parse.c (lexptr, prev_lexptr): Remove globals.
9878         (parse_exp_in_context): Update.
9879         * p-exp.y (yylex, yyerror): Update.
9880         * m2-exp.y (parse_number, yylex, yyerror): Update.
9881         * go-exp.y (lex_one_token, yyerror): Update.
9882         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9883         * d-exp.y (lex_one_token, yyerror): Update.
9884         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9885         (lex_one_token, yyerror): Update.
9886         * ada-lex.l (YY_INPUT): Update.
9887         (rewind_to_char): Update.
9888         * ada-exp.y (yyerror): Update.
9889
9890 2019-04-04  Tom Tromey  <tom@tromey.com>
9891
9892         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9893         * parser-defs.h (struct parser_state) <parser_state>: Add new
9894         parameter.
9895         <comma_terminates>: New member.
9896         (comma_terminates): Don't declare global.
9897         * parse.c (comma_terminates): Remove global.
9898         (parse_exp_in_context): Update.
9899         * p-exp.y (yylex): Update.
9900         * m2-exp.y (yylex): Update.
9901         * go-exp.y (lex_one_token): Update.
9902         * f-exp.y (yylex): Update.
9903         * d-exp.y (lex_one_token): Update.
9904         * c-exp.y (lex_one_token): Update.
9905         * ada-lex.l: Update.
9906
9907 2019-04-04  Tom Tromey  <tom@tromey.com>
9908
9909         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9910         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9911         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9912         * parser-defs.h (paren_depth): Don't declare.
9913         * parse.c (paren_depth): Remove global.
9914         (parse_exp_in_context): Update.
9915         * p-exp.y (paren_depth): New global.
9916         (pascal_parse): Initialize it.
9917         * m2-exp.y (paren_depth): New global.
9918         (m2_parse): Initialize it.
9919         * go-exp.y (paren_depth): New global.
9920         (go_parse): Initialize it.
9921         * f-exp.y (paren_depth): New global.
9922         (f_parse): Initialize it.
9923         * d-exp.y (paren_depth): New global.
9924         (d_parse): Initialize it.
9925         * c-exp.y (paren_depth): New global.
9926         (c_parse): Initialize it.
9927         * ada-lex.l (paren_depth): New global.
9928         (lexer_init): Initialize it.
9929
9930 2019-04-04  Tom Tromey  <tom@tromey.com>
9931
9932         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9933         (rust_parser::convert_ast_to_type)
9934         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9935         * parser-defs.h (struct parser_state) <parser_state>: Add
9936         parameters.  Initialize new members.
9937         <expression_context_block, expression_context_pc>: New members.
9938         * parse.c (expression_context_block, expression_context_pc):
9939         Remove globals.
9940         (parse_exp_in_context): Update.
9941         * p-exp.y: Update all rules.
9942         (yylex): Update.
9943         * m2-exp.y: Update all rules.
9944         (yylex): Update.
9945         * go-exp.y (yylex): Update.
9946         * f-exp.y (yylex): Update.
9947         * d-exp.y: Update all rules.
9948         (yylex): Update.
9949         * c-exp.y: Update all rules.
9950         (lex_one_token, classify_name, yylex, c_parse): Update.
9951         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9952
9953 2019-04-04  Tom Tromey  <tom@tromey.com>
9954
9955         * gdbarch.h, gdbarch.c: Rebuild.
9956         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9957         * stap-probe.h:
9958         (struct stap_parse_info): Replace "parser_state" with
9959         "expr_builder".
9960         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9961         (parser_state): New class.
9962         * parse.c (expr_builder): Rename.
9963         (expr_builder::release): Rename.
9964         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9965         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9966         (write_exp_elt_longcst, write_exp_elt_floatcst)
9967         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9968         (write_exp_string_vector, write_exp_bitstring)
9969         (write_exp_msymbol, mark_struct_expression)
9970         (write_dollar_variable)
9971         (insert_type_address_space, increase_expout_size): Replace
9972         "parser_state" with "expr_builder".
9973         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9974         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9975         "parser_state" with "expr_builder".
9976
9977 2019-04-04  Tom Tromey  <tom@tromey.com>
9978
9979         * rust-exp.y: Replace "parse_language" with method call.
9980         * p-exp.y:
9981         (yylex): Replace "parse_language" with method call.
9982         * m2-exp.y:
9983         (yylex): Replace "parse_language" with method call.
9984         * go-exp.y (classify_name): Replace "parse_language" with method
9985         call.
9986         * f-exp.y (yylex): Replace "parse_language" with method call.
9987         * d-exp.y (lex_one_token): Replace "parse_language" with method
9988         call.
9989         * c-exp.y:
9990         (lex_one_token, classify_name, yylex): Replace "parse_language"
9991         with method call.
9992         * ada-exp.y (find_primitive_type, type_char)
9993         (type_system_address): Replace "parse_language" with method call.
9994
9995 2019-04-04  Tom Tromey  <tom@tromey.com>
9996
9997         * rust-exp.y: Replace "parse_gdbarch" with method call.
9998         * parse.c (write_dollar_variable, insert_type_address_space):
9999         Replace "parse_gdbarch" with method call.
10000         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10001         call.
10002         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10003         call.
10004         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10005         "parse_gdbarch" with method call.
10006         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10007         with method call.
10008         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10009         "parse_gdbarch" with method call.
10010         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10011         "parse_gdbarch" with method call.
10012         * c-exp.y (parse_type, parse_number, classify_name): Replace
10013         "parse_gdbarch" with method call.
10014         * ada-lex.l: Replace "parse_gdbarch" with method call.
10015         * ada-exp.y (parse_type, find_primitive_type, type_char)
10016         (type_system_address): Replace "parse_gdbarch" with method call.
10017
10018 2019-04-04  Tom Tromey  <tom@tromey.com>
10019
10020         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10021         * stap-probe.c (stap_parse_argument): Update.
10022         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10023         initial_size parameter.
10024         * rust-exp.y (rust_lex_tests): Update.
10025         * parse.c (parser_state): Update.
10026         (parse_exp_in_context): Update.
10027         * parser-defs.h (struct parser_state) <parser_state>: Remove
10028         "initial_size" parameter.
10029
10030 2019-04-04  Tom Tromey  <tom@tromey.com>
10031
10032         * parser-defs.h (increase_expout_size): Don't declare.
10033         * parse.c (increase_expout_size): Now static.
10034
10035 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10036
10037         * gnu-nat.c (gnu_nat_target::wait): Fix
10038         target_waitstatus_to_string call.
10039
10040 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * eval.c (evaluate_subexp_standard): Handle internal functions
10043         during Fortran function call handling.
10044
10045 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10046
10047         * NEWS: Mention new internal functions.
10048         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10049         (read_base_type): Use dwarf2_init_complex_target_type.
10050         * value.c (creal_internal_fn): New function.
10051         (cimag_internal_fn): New function.
10052         (_initialize_values): Register new internal functions.
10053
10054 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10055
10056         * infrun.c (stop_all_threads): If debug_infrun, always
10057         trace the wait status after wait_one, using
10058         target_waitstatus_to_string and target_pid_to_str.
10059         (handle_inferior_event): Replace various trace of
10060         wait status kind by a single trace.
10061         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10062         wait status kind image by target_waitstatus_to_string.
10063         * target/waitstatus.c (target_waitstatus_to_string): Fix
10064         obsolete comment.
10065
10066 2019-04-01  Tom Tromey  <tromey@adacore.com>
10067
10068         PR symtab/23331:
10069         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10070
10071 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10072             Pedro Alves  <palves@redhat.com>
10073
10074         * top.c (quit_force): Call 'finalize_values'.
10075         * value.c (finalize_values): New function.
10076         * value.h (finalize_values): Declare.
10077
10078 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10079
10080         * NEWS: Announce $_gdb_major and $_gdb_minor.
10081
10082         * top.c (init_gdb_version_vars): New function.
10083         (gdb_init): Call init_gdb_version_vars.
10084
10085 2019-03-29  Tom Tromey  <tromey@adacore.com>
10086
10087         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10088         help text.  Remove dead code.
10089
10090 2019-03-29  Keith Seitz  <keiths@redhat.com>
10091
10092         From Siddhesh Poyarekar:
10093         * f-lang.h (f77_get_upperbound): Return LONGEST.
10094         (f77_get_lowerbound): Likewise.
10095         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10096         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10097         print them.
10098         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10099         plongest to format print it.
10100         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10101         (f77_get_upperbound): Likewise.
10102         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10103         LOWER_BOUND to LONGEST.
10104         (f77_create_arrayprint_offset_tbl): Likewise.
10105
10106 2019-03-29  Keith Seitz  <keiths@redhat.com>
10107
10108         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10109         %s/pulongest for TYPE_LENGTH instead of %d in format
10110         strings.
10111         * ada-typerint.c (ada_print_type): Likewise.
10112         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10113         * compile/compile-c-support.c (generate_register_struct): Likewise.
10114         * gdbtypes.c (recursive_dump_type): Likewise.
10115         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10116         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10117         instead of %d in format strings.
10118         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10119         to std::min to ULONGEST.
10120         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10121         instead of %d in format strings.
10122         * tracepoint.c (info_scope_command): Likewise.
10123         * typeprint.c (print_offset_data::update)
10124         (print_offset_data::finish): Likewise.
10125         * xtensa-tdep.c (xtensa_store_return_value)
10126         (xtensa_push_dummy_call): Likewise.
10127
10128 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10129
10130         * windows-nat.c (display_selector): Fixed format specifications
10131         for 64-bit Cygwin.
10132
10133 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10134
10135         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10136
10137 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10138
10139         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10140         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10141         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10142         (nios2_linux_init_abi): Install it.
10143
10144 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10145
10146         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10147
10148 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10149
10150         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10151
10152 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10153             Tom Tromey  <tromey@adacore.com>
10154
10155         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10156
10157 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10158
10159         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10160         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10161         method to compute the bounds of range types. Also print "[evaluated]"
10162         if the bounds' values come from a dynamic evaluation.
10163
10164 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10165
10166         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10167         whitespace when pretty printing is on.
10168
10169 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10170
10171         * ppc-linux-nat.c: Add include.
10172
10173 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10174
10175         * NEWS: Mention AArch64 Pointer Authentication.
10176
10177 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10178
10179         * arm-linux-nat.c: Add include.
10180
10181 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10182
10183         * source-cache.c (source_cache::get_source_lines): Re-read
10184         fullname after calling open_source_file.
10185
10186 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10187
10188         * NEWS: Mention TLS support for FreeBSD.
10189
10190 2019-03-25  Tom Tromey  <tromey@adacore.com>
10191
10192         * minsyms.c (BUNCH_SIZE): Update comment.
10193         (~minimal_symbol_reader): Remove old comment.
10194         (compact_minimal_symbols): Update comment.
10195         (minimal_symbol_reader::install): Remove old comment.  Update
10196         other comments.
10197
10198 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10199
10200         * s390-linux-nat.c: Add include.
10201
10202 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10203
10204         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10205         Call linux_get_hwcap.
10206         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10207         Likewise.
10208         (aarch64_linux_get_hwcap): Remove function.
10209         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10210         declaration.
10211         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10212         linux_get_hwcap.
10213         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10214         * linux-tdep.c (linux_get_hwcap): Add function.
10215         (linux_get_hwcap2): Likewise.
10216         * linux-tdep.h (linux_get_hwcap): Add declaration.
10217         (linux_get_hwcap2): Likewise.
10218         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10219         (ppc_linux_get_hwcap2): Likewise.
10220         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10221         linux_get_hwcap.
10222         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10223         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10224         (ppc_linux_nat_target::read_description): Likewise.
10225         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10226         * s390-linux-nat.c: Likewise.
10227         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10228
10229 2019-03-24  Tom Tromey  <tom@tromey.com>
10230
10231         * ada-lang.c (standard_lookup): Simplify initialization.
10232         (ada_lookup_symbol_nonlocal): Simplify return.
10233         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10234         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10235         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10236         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10237         initialization.
10238         * solib.c (solib_global_lookup): Simplify.
10239         * symtab.c (null_block_symbol): Remove.
10240         (symbol_cache_lookup): Simplify returns.
10241         (lookup_language_this): Simplify returns.
10242         (lookup_symbol_aux): Simplify return.
10243         (lookup_local_symbol): Simplify returns.
10244         (lookup_global_symbol_from_objfile): Simplify return.
10245         (lookup_symbol_in_objfile_symtabs)
10246         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10247         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10248         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10249         * cp-namespace.c (cp_lookup_bare_symbol)
10250         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10251         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10252         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10253         (cp_lookup_symbol_via_imports): Simplify initialization.
10254         (find_symbol_in_baseclass): Likewise.
10255         * symtab.h (null_block_symbol): Remove.
10256         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10257         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10258         (d_lookup_symbol_module): Likewise.
10259         (find_symbol_in_baseclass): Simplify initialization.
10260
10261 2019-03-24  Tom Tromey  <tom@tromey.com>
10262
10263         * expression.h: Don't include symtab.h.
10264         (struct block): Forward declare.
10265
10266 2019-03-24  Tom Tromey  <tom@tromey.com>
10267
10268         * c-exp.y (typebase): Remove casts.
10269         * gdbtypes.c (lookup_unsigned_typename, )
10270         (lookup_signed_typename): Remove cast.
10271         * eval.c (parse_to_comma_and_eval): Remove cast.
10272         * parse.c (write_dollar_variable): Remove cast.
10273         * block.h (struct block) <superblock>: Now const.
10274         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10275         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10276         (map_block): Make "block" const.
10277         * symfile.h (struct quick_symbol_functions)
10278         <map_matching_symbols>: Constify block argument to "callback".
10279         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10280         const.
10281         (find_pc_sect_compunit_symtab): Make "b" const.
10282         (find_symbol_at_address): Likewise.
10283         (search_symbols): Likewise.
10284         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10285         (dw2_debug_names_lookup_symbol): Likewise.
10286         (dw2_map_matching_symbols): Update.
10287         * p-valprint.c (pascal_val_print): Remove "block".
10288         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10289         (aux_add_nonlocal_symbols): Make "block" const.
10290         (resolve_subexp): Remove cast.
10291         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10292         const.
10293         (iterate_over_file_blocks): Likewise.
10294         * f-exp.y (%union) <bval>: Remove.
10295         * coffread.c (patch_opaque_types): Make "b" const.
10296         * spu-tdep.c (spu_catch_start): Make "block" const.
10297         * c-valprint.c (print_unpacked_pointer): Remove "block".
10298         * symmisc.c (dump_symtab_1): Make "b" const.
10299         (block_depth): Make "block" const.
10300         * d-exp.y (%union) <bval>: Remove.
10301         * cp-support.h (cp_lookup_rtti_type): Update.
10302         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10303         * psymtab.c (psym_lookup_symbol): Make "block" const.
10304         (maintenance_check_psymtabs): Make "b" const.
10305         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10306         (enumerate_locals, enumerate_args): Update.
10307         * python/py-symtab.c (stpy_global_block): Make "block" const.
10308         (stpy_static_block): Likewise.
10309         * inline-frame.c (block_starting_point_at): Make "new_block"
10310         const.
10311         * block.c (find_block_in_blockvector): Make return type const.
10312         (blockvector_for_pc_sect): Make "b" const.
10313         (find_block_in_blockvector): Make "b" const.
10314
10315 2019-03-23  Tom Tromey  <tom@tromey.com>
10316
10317         * varobj.c (varobj_create): Update.
10318         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10319         * printcmd.c (display_command, do_one_display): Don't reset
10320         innermost_block.
10321         * parser-defs.h (enum innermost_block_tracker_type): Move to
10322         expression.h.
10323         (innermost_block): Update comment.
10324         * parse.c (parse_exp_1): Add tracker_types parameter.
10325         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10326         tracker_types parameter.  Reset innermost_block.
10327         (parse_exp_in_context): Remove.
10328         (parse_expression_for_completion): Update.
10329         * objfiles.c (~objfile): Don't reset expression_context_block or
10330         innermost_block.
10331         * expression.h (enum innermost_block_tracker_type): Move from
10332         parser-defs.h.
10333         (parse_exp_1): Add tracker_types parameter.
10334         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10335         reset innermost_block.
10336
10337 2019-03-23  Tom Tromey  <tom@tromey.com>
10338
10339         * objfiles.h: Include bcache.h.
10340
10341 2019-03-23  Tom Tromey  <tom@tromey.com>
10342
10343         * linespec.c (get_current_search_block): Use
10344         scoped_restore_current_language.
10345         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10346
10347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10348             Jiong Wang  <jiong.wang@arm.com>
10349
10350         * aarch64-linux-tdep.c
10351         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10352         section.
10353         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10354
10355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10356             Jiong Wang  <jiong.wang@arm.com>
10357
10358         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10359         instructions.
10360         (aarch64_analyze_prologue_test): Add PACIASP test.
10361         (aarch64_prologue_prev_register): Unmask PC value.
10362
10363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10364             Jiong Wang  <jiong.wang@arm.com>
10365
10366         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10367         (aarch64_dwarf2_prev_register): Unmask PC value.
10368         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10369         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10370         DW_CFA_AARCH64_negate_ra_state.
10371         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10372
10373 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10374             Jiong Wang  <jiong.wang@arm.com>
10375
10376         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10377         registers.
10378         (aarch64_pseudo_register_name): Likewise.
10379         (aarch64_pseudo_register_type): Likewise.
10380         (aarch64_pseudo_register_reggroup_p): Likewise.
10381         (aarch64_gdbarch_init): Add pauth registers.
10382         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10383         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10384         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10385         (struct gdbarch_tdep): Add regnum for ra_state.
10386
10387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10388             Jiong Wang  <jiong.wang@arm.com>
10389
10390         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10391
10392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10393             Jiong Wang  <jiong.wang@arm.com>
10394
10395         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10396         function.
10397         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10398         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10399         (aarch64_gdbarch_init): Add puth registers.
10400         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10401         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10402         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10403
10404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10405             Jiong Wang  <jiong.wang@arm.com>
10406
10407         * aarch64-linux-nat.c
10408         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10409         * aarch64-linux-tdep.c
10410         (aarch64_linux_core_read_description): Likewise.
10411         (aarch64_linux_get_hwcap): New function.
10412         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10413         (aarch64_linux_get_hwcap): New declaration.
10414
10415 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10416             Jiong Wang  <jiong.wang@arm.com>
10417
10418         * aarch64-linux-nat.c
10419         (aarch64_linux_nat_target::read_description): Add pauth param.
10420         * aarch64-linux-tdep.c
10421         (aarch64_linux_core_read_description): Likewise.
10422         * aarch64-tdep.c (struct target_desc): Add in pauth.
10423         (aarch64_read_description): Add pauth param.
10424         (aarch64_gdbarch_init): Likewise.
10425         * aarch64-tdep.h (aarch64_read_description): Likewise.
10426         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10427         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10428         * features/Makefile: Add new files.
10429         * features/aarch64-pauth.c: New file.
10430         * features/aarch64-pauth.xml: New file.
10431
10432 2019-03-20  Tom Tromey  <tromey@adacore.com>
10433
10434         * infrun.c (handle_inferior_event): Rename from
10435         handle_inferior_event_1.  Create a scoped_value_mark.
10436         (handle_inferior_event): Remove.
10437
10438 2019-03-19  Tom Tromey  <tromey@adacore.com>
10439
10440         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10441         * infrun.h (print_stop_event): Add "displays" parameter.
10442         * infrun.c (print_stop_event): Add "displays" parameter.
10443
10444 2019-03-19  Pedro Alves  <palves@redhat.com>
10445
10446         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10447         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10448         to -1.  Fix TABs vs spaces.
10449         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10450         * tui/tui-out.h (tui_ui_out) Add intro comments.
10451         <m_line, m_start_of_line>: In-class initialize, and add describing
10452         comment.
10453
10454 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10455
10456         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10457         variable names.
10458         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10459
10460 2019-03-18  Pedro Alves  <palves@redhat.com>
10461             Eli Zaretskii <eliz@gnu.org>
10462
10463         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10464         m_line and m_start_of_line.
10465
10466 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10467
10468         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10469         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10470         it returns a newline.  This fixes a regression in TU mode, whereby
10471         the next line is output on the same screen line as the user input.
10472
10473 2019-03-18  Tom Tromey  <tromey@adacore.com>
10474
10475         * minsyms.c (minimal_symbol_reader::install): Remove call to
10476         obstack_blank.
10477
10478 2019-03-18  Pedro Alves  <palves@redhat.com>
10479
10480         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10481         New globals.
10482         (apply_style): New, factored out from ...
10483         (apply_ansi_escape): ... this.  Handle reverse video mode.
10484         (tui_set_reverse_mode): New function.
10485         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10486         * tui/tui-winsource.c (tui_show_source_line): Use
10487         tui_set_reverse_mode instead of setting A_STANDOUT.
10488         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10489         New setter methods.
10490
10491 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10492
10493         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10494         Handle tabs.
10495
10496 2019-03-18  Tom Tromey  <tromey@adacore.com>
10497
10498         * ada-lang.c (empty_array): Add "high" parameter.
10499         (ada_evaluate_subexp): Update.
10500
10501 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10502
10503         * unittests/string_view-selftests.c: Define
10504         _initialize_string_view_selftests unconditionally.
10505
10506 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10507
10508         PR gdb/24350
10509         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10510
10511 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10512
10513         PR gdb/24351
10514         * windows-nat.c (display_selector): Fix format specifiers.
10515
10516 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10517
10518         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10519         tui_refill_source_window instead of tui_refresh_win, to update the
10520         current execution line.  This fixes redisplay of the current line
10521         when stepping through the code with "next" or "step".
10522
10523 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10524
10525         * source-cache.c (source_cache::get_source_lines): Call
10526         find_source_lines to initialize s->nlines.  This fixes vertical
10527         scrolling of TUI source window when the DOWN arrow is pressed.
10528
10529 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10530
10531         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10532         linux-thread-db.c (_initialize_thread_db): Likewise.
10533
10534 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10535
10536         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10537         wclrtoeol in tui_show_source_line".  This reverts changes made in
10538         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10539
10540 2019-03-15  Tom Tromey  <tom@tromey.com>
10541
10542         * symtab.h (struct minimal_symbol): Derive from
10543         general_symbol_info.
10544         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10545         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10546         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10547         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10548         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10549         (MSYMBOL_SEARCH_NAME): Update.
10550         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10551         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10552         * minsyms.c (minimal_symbol_reader::record_full): Update.
10553
10554 2019-03-15  Tom Tromey  <tom@tromey.com>
10555
10556         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10557
10558 2019-03-15  Tom Tromey  <tom@tromey.com>
10559
10560         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10561         unique_xmalloc_ptr.
10562         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10563         Update.
10564         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10565         (build_minimal_symbol_hash_tables)
10566         (minimal_symbol_reader::install): Update.
10567
10568 2019-03-15  Tom Tromey  <tom@tromey.com>
10569
10570         * symtab.c (create_demangled_names_hash): Update.
10571         (symbol_set_names): Update.
10572         * objfiles.h (struct objfile_per_bfd_storage)
10573         <demangled_names_hash>: Now an htab_up.
10574         * objfiles.c (objfile_per_bfd_storage): Simplify.
10575
10576 2019-03-15  Tom Tromey  <tom@tromey.com>
10577
10578         * objfiles.h (struct objfile_per_bfd_storage): Declare
10579         destructor.
10580         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10581         New.
10582         (get_objfile_bfd_data): Use new.  Don't initialize
10583         language_of_main.
10584         (free_objfile_per_bfd_storage): Remove.
10585         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10586
10587 2019-03-15  Tom Tromey  <tom@tromey.com>
10588
10589         * symfile.c (reread_symbols): Update.
10590         * objfiles.c (objfile::objfile): Update.
10591         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10592         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10593         comment.
10594         (minimal_symbol_reader::install): Update.
10595         (terminate_minimal_symbol_table): Remove.
10596         * jit.c (jit_object_close_impl): Update.
10597
10598 2019-03-15  Tom Tromey  <tom@tromey.com>
10599
10600         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10601         initializations.
10602
10603 2019-03-15  Tom Tromey  <tom@tromey.com>
10604
10605         * objfiles.h (struct objfile_per_bfd_storage)
10606         <demangled_hash_languages>: Now a bitset.
10607         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10608         (lookup_minimal_symbol): Update.
10609
10610 2019-03-15  Tom Tromey  <tom@tromey.com>
10611
10612         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10613         Don't return the symbol.
10614         * coffread.c (record_minimal_symbol): Use record_full.
10615
10616 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10617
10618         The MS-Windows port of ncurses fails to switch to a color pair if
10619         one or both of the colors are the implicit default colors.  This
10620         change records the default colors when TUI is initialized, and
10621         then specifies them explicitly when a color pair uses the default
10622         colors.  This allows color styling in TUI mode on MS-Windows.
10623
10624         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10625         ncurses_norm_attr.
10626         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10627         colors in ncurses_norm_attr.
10628         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10629         "none", replace it with the default color recorded in
10630         ncurses_norm_attr.
10631
10632 2019-03-14  Tom Tromey  <tromey@adacore.com>
10633
10634         * source-cache.h (class source_cache) <get_source_lines>: Return
10635         std::string.
10636         * source-cache.c (source_cache::extract_lines): Handle case where
10637         first_pos==npos.  Return std::string.
10638         (source_cache::get_source_lines): Update.
10639
10640 2019-03-14  Tom Tromey  <tromey@adacore.com>
10641
10642         * NEWS: Add item for "style sources" commands.
10643         * source-cache.c (source_cache::get_source_lines): Check
10644         source_styling.
10645         * cli/cli-style.c (source_styling): New global.
10646         (_initialize_cli_style): Add "style sources" commands.
10647         (show_style_sources): New function.
10648         * cli/cli-style.h (source_styling): Declare.
10649
10650 2019-03-14  Pedro Alves  <palves@redhat.com>
10651             Tom Tromey  <tromey@adacore.com>
10652
10653         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10654         * tui/tui-winsource.c (tui_refill_source_window): New function,
10655         from...
10656         (tui_horizontal_source_scroll): ... here.  Move some logic.
10657         * cli/cli-style.c (set_style_enabled): Notify new observable.
10658         * tui/tui-hooks.c (tui_redisplay_source): New function.
10659         (tui_attach_detach_observers): Attach or detach
10660         tui_redisplay_source.
10661         * observable.h (source_styling_changed): New observable.
10662         * observable.c: Define source_styling_changed observable.
10663
10664 2019-03-13  Tom Tromey  <tromey@adacore.com>
10665
10666         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10667         (i386_gnu_nat_target::store_registers): Update.
10668         * target-debug.h (target_debug_print_std_string): New macro.
10669         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10670         * windows-tdep.c (display_one_tib): Update.
10671         * tui/tui-stack.c (tui_make_status_line): Update.
10672         * top.c (print_inferior_quit_action): Update.
10673         * thread.c (thr_try_catch_cmd): Update.
10674         (add_thread_with_info): Update.
10675         (thread_target_id_str): Update.
10676         (thr_try_catch_cmd): Update.
10677         (thread_command): Update.
10678         (thread_find_command): Update.
10679         * record-btrace.c (record_btrace_target::info_record)
10680         (record_btrace_resume_thread, record_btrace_target::resume)
10681         (record_btrace_cancel_resume, record_btrace_step_thread)
10682         (record_btrace_target::wait, record_btrace_target::wait)
10683         (record_btrace_target::wait, record_btrace_target::stop): Update.
10684         * progspace.c (print_program_space): Update.
10685         * process-stratum-target.c
10686         (process_stratum_target::thread_address_space): Update.
10687         * linux-fork.c (linux_fork_mourn_inferior)
10688         (detach_checkpoint_command, info_checkpoints_command)
10689         (linux_fork_context): Update.
10690         (linux_fork_detach): Update.
10691         (class scoped_switch_fork_info): Update.
10692         (delete_checkpoint_command): Update.
10693         * infrun.c (follow_fork_inferior): Update.
10694         (follow_fork_inferior): Update.
10695         (proceed_after_vfork_done): Update.
10696         (handle_vfork_child_exec_or_exit): Update.
10697         (follow_exec): Update.
10698         (displaced_step_prepare_throw): Update.
10699         (displaced_step_restore): Update.
10700         (start_step_over): Update.
10701         (resume_1): Update.
10702         (clear_proceed_status_thread): Update.
10703         (proceed): Update.
10704         (print_target_wait_results): Update.
10705         (do_target_wait): Update.
10706         (context_switch): Update.
10707         (stop_all_threads): Update.
10708         (restart_threads): Update.
10709         (finish_step_over): Update.
10710         (handle_signal_stop): Update.
10711         (switch_back_to_stepped_thread): Update.
10712         (keep_going_pass_signal): Update.
10713         (print_exited_reason): Update.
10714         (normal_stop): Update.
10715         * inferior.c (inferior_pid_to_str): Change return type.
10716         (print_selected_inferior): Update.
10717         (add_inferior): Update.
10718         (detach_inferior): Update.
10719         * dummy-frame.c (fprint_dummy_frames): Update.
10720         * dcache.c (dcache_info_1): Update.
10721         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10722         (btrace_fetch, btrace_clear): Update.
10723         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10724         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10725         type.
10726         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10727         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10728         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10729         * gdbarch.c, gdbarch.h: Rebuild.
10730         * gdbarch.sh (core_pid_to_str): Change return type.
10731         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10732         return type.
10733         (windows_nat_target::pid_to_str): Change return type.
10734         (windows_delete_thread): Update.
10735         (windows_nat_target::attach): Update.
10736         (windows_nat_target::files_info): Update.
10737         * target-delegates.c: Rebuild.
10738         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10739         return type.
10740         (sol_thread_target::pid_to_str): Change return type.
10741         * remote.c (class remote_target) <pid_to_str>: Change return
10742         type.
10743         (remote_target::pid_to_str): Change return type.
10744         (extended_remote_target::attach, remote_target::remote_stop_ns)
10745         (remote_target::remote_notif_remove_queued_reply)
10746         (remote_target::push_stop_reply, remote_target::disable_btrace):
10747         Update.
10748         (extended_remote_target::attach): Update.
10749         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10750         type.
10751         (gdbsim_target::pid_to_str): Change return type.
10752         * ravenscar-thread.c (struct ravenscar_thread_target)
10753         <pid_to_str>: Change return type.
10754         (ravenscar_thread_target::pid_to_str): Change return type.
10755         * procfs.c (class procfs_target) <pid_to_str>: Change return
10756         type.
10757         (procfs_target::pid_to_str): Change return type.
10758         (procfs_target::attach): Update.
10759         (procfs_target::detach): Update.
10760         (procfs_target::fetch_registers): Update.
10761         (procfs_target::store_registers): Update.
10762         (procfs_target::wait): Update.
10763         (procfs_target::files_info): Update.
10764         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10765         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10766         return type.
10767         (nto_procfs_target::pid_to_str): Change return type.
10768         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10769         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10770         return type.
10771         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10772         (exit_lwp): Update.
10773         (attach_proc_task_lwp_callback, get_detach_signal)
10774         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10775         (linux_nat_target::resume, wait_lwp, stop_callback)
10776         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10777         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10778         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10779         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10780         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10781         type.
10782         (inf_ptrace_target::attach): Update.
10783         (inf_ptrace_target::files_info): Update.
10784         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10785         type.
10786         (go32_nat_target::pid_to_str): Change return type.
10787         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10788         (gnu_nat_target::wait): Update.
10789         (gnu_nat_target::wait): Update.
10790         (gnu_nat_target::resume): Update.
10791         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10792         (fbsd_nat_target::wait): Update.
10793         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10794         type.
10795         (darwin_nat_target::attach): Update.
10796         * corelow.c (class core_target) <pid_to_str>: Change return type.
10797         (core_target::pid_to_str): Change return type.
10798         * target.c (normal_pid_to_str): Change return type.
10799         (default_pid_to_str): Likewise.
10800         (target_pid_to_str): Change return type.
10801         (target_translate_tls_address): Update.
10802         (target_announce_detach): Update.
10803         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10804         return type.
10805         (bsd_uthread_target::pid_to_str): Change return type.
10806         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10807         type.
10808         (bsd_kvm_target::pid_to_str): Change return type.
10809         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10810         return type.
10811         (aix_thread_target::pid_to_str): Change return type.
10812         * target.h (struct target_ops) <pid_to_str>: Change return type.
10813         (target_pid_to_str, normal_pid_to_str): Likewise.
10814         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10815         type.
10816         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10817         type.
10818         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10819         return type.
10820         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10821         type.
10822         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10823         type.
10824         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10825         return type.
10826
10827 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10828
10829         * NEWS: Mention that the new default MI version is 3.  Mention
10830         changes to the output of commands and events that deal with
10831         multi-location breakpoints.
10832         * breakpoint.c: Include "mi/mi-out.h".
10833         (print_one_breakpoint): Change output syntax if using MI version
10834         >= 3.
10835         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10836         New.
10837         (mi_multi_location_breakpoint_output_fixed): New.
10838         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10839         (mi_cmd_fix_multi_location_breakpoint_output): New.
10840         (mi_multi_location_breakpoint_output_fixed): New.
10841         * mi/mi-cmds.c (mi_cmds): Register command
10842         -fix-multi-location-breakpoint-output.
10843         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10844         interpreter "mi".
10845
10846 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10847
10848         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10849         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10850         instantiate mi_ui_out based on interpreter name.
10851         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10852         * mi/mi-main.c (mi_load_progress): Likewise.
10853
10854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10855
10856         * NEWS: Combine separate "New targets" sections for 8.3.
10857
10858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10859
10860         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10861         (ppcfbsd_init_abi): Install gdbarch
10862         "fetch_tls_load_module_address" and "get_thread_local_address"
10863         methods.
10864
10865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10866
10867         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10868         (riscv_fbsd_init_abi): Install gdbarch
10869         "fetch_tls_load_module_address" and "get_thread_local_address"
10870         methods.
10871
10872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10873
10874         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10875         (i386fbsd_init_abi): Install gdbarch
10876         "fetch_tls_load_module_address" and "get_thread_local_address"
10877         methods.
10878
10879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10880
10881         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10882         (amd64fbsd_init_abi): Install gdbarch
10883         "fetch_tls_load_module_address" and "get_thread_local_address"
10884         methods.
10885
10886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10887
10888         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10889         (struct fbsd_pspace_data): New type.
10890         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10891         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10892         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10893         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10894         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10895
10896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10897
10898         * gdbtypes.c (lookup_struct_elt): New function.
10899         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10900         * gdbtypes.h (struct struct_elt): New type.
10901         (lookup_struct_elt): New prototype.
10902
10903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10904
10905         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10906         remove disabled code block.
10907
10908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10909
10910         * gdbarch.sh (get_thread_local_address): New method.
10911         * gdbarch.h, gdbarch.c: Regenerate.
10912         * target.c (target_translate_tls_address): Use
10913         gdbarch_get_thread_local_address if present instead of
10914         target::get_thread_local_address.
10915
10916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10917
10918         * target.h (target::get_thread_local_address): Update comment.
10919
10920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10921
10922         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10923         objfile->separate_debug_objfile_backlink if not NULL.
10924
10925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10926
10927         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10928         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10929         (amd64bsd_store_inferior_registers): Likewise.
10930         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10931         Enable segment base registers.
10932         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10933         PT_GETFSBASE and PT_GETGSBASE.
10934         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10935         PT_SETGSBASE.
10936         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10937         segment base registers.
10938         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10939
10940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10941
10942         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10943         Update calls to i386_target_description to add 'segments'
10944         parameter.
10945         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10946         add segment base registers.
10947         * arch/i386.c (i386_create_target_description): Add 'segments'
10948         parameter to enable segment base registers.
10949         * arch/i386.h (i386_create_target_description): Likewise.
10950         * features/i386/32bit-segments.xml: New file.
10951         * features/i386/32bit-segments.c: Generate.
10952         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10953         call to i386_target_description to add 'segments' parameter.
10954         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10955         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10956         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10957         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10958         if feature is present.
10959         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10960         Add 'segments' parameter to call to i386_target_description.
10961         (i386_target_description): Add 'segments' parameter to enable
10962         segment base registers.
10963         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10964         to call to i386_target_description.
10965         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10966         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10967         Define I386_NUM_REGS.
10968         (i386_target_description): Add 'segments' parameter to enable
10969         segment base registers.
10970
10971 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10972
10973         PR/24325
10974         * source-cache.c: #undef open and close, to avoid unresolved
10975         externals during linking.
10976
10977 2019-03-12  Tom Tromey  <tromey@adacore.com>
10978
10979         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10980         const.  Add initializers.
10981         (_initialize_remote): Don't initialize ptid globals.
10982
10983 2019-03-12  Pedro Alves  <palves@redhat.com>
10984
10985         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10986
10987 2019-03-12  Pedro Alves  <palves@redhat.com>
10988
10989         * cp-name-parser.y (main): Remove unused 'len' variable.
10990
10991 2019-03-12  Tom Tromey  <tromey@adacore.com>
10992
10993         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10994         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10995
10996 2019-03-12  Tom Tromey  <tromey@adacore.com>
10997
10998         * linux-nat.c (iterate_over_lwps): Update.
10999         (stop_callback): Remove parameter.
11000         (stop_wait_callback, detach_callback, resume_set_callback)
11001         (select_singlestep_lwp_callback, set_ignore_sigint)
11002         (status_callback, resumed_callback, resume_clear_callback)
11003         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11004         data parameter.
11005         (linux_nat_target::detach, linux_nat_target::resume)
11006         (linux_stop_and_wait_all_lwps, select_event_lwp)
11007         (linux_nat_filter_event, linux_nat_wait_1)
11008         (linux_nat_target::kill, linux_nat_target::stop)
11009         (linux_nat_target::stop): Update.
11010         (linux_nat_resume_callback): Change type.
11011         (resume_stopped_resumed_lwps, count_events_callback)
11012         (select_event_lwp_callback): Likewise.
11013         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11014         * arm-linux-nat.c (struct update_registers_data): Remove.
11015         (update_registers_callback): Change type.
11016         (arm_linux_insert_hw_breakpoint1): Update.
11017         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11018         parameter.
11019         (x86_linux_dr_set_addr): Update.
11020         (x86_linux_dr_set_control): Update.
11021         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11022         (iterate_over_lwps): Use gdb::function_view.
11023         * nat/aarch64-linux-hw-point.c (struct
11024         aarch64_dr_update_callback_param): Remove.
11025         (debug_reg_change_callback): Change type.
11026         (aarch64_notify_debug_reg_change): Update.
11027         * s390-linux-nat.c (s390_refresh_per_info): Update.
11028
11029 2019-03-11  Tom Tromey  <tromey@adacore.com>
11030
11031         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11032         redundant assignment to "this_cu".
11033
11034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11035
11036         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11037
11038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11039
11040         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11041         from...
11042         (rank_one_type): ... this.
11043
11044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11045
11046         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11047         from...
11048         (rank_one_type): ... this.
11049
11050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11051
11052         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11053         from...
11054         (rank_one_type): ... this.
11055
11056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11057
11058         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11059         from...
11060         (rank_one_type): ... this.
11061
11062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11063
11064         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11065         from...
11066         (rank_one_type): ... this.
11067
11068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11069
11070         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11071         from...
11072         (rank_one_type): ... this.
11073
11074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11075
11076         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11077         from...
11078         (rank_one_type): ... this.
11079
11080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11081
11082         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11083         from...
11084         (rank_one_type): ... this.
11085
11086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11087
11088         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11089         from...
11090         (rank_one_type): ... this.
11091
11092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11093
11094         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11095         from...
11096         (rank_one_type): ... this.
11097
11098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11099
11100         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11101         from...
11102         (rank_one_type): ... this.
11103
11104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11105
11106         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11107         from...
11108         (rank_one_type): ... this.
11109
11110 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11111
11112         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11113         inferior-events' shows the example events.
11114
11115 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11116
11117         Support styling on native MS-Windows console
11118
11119         PR/24315
11120         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11121         on MS-Windows if $TERM is not defined.
11122
11123         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11124
11125         * posix-hdep.c (gdb_console_fputs):
11126         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11127         functions.
11128         * ui-file.h (gdb_console_fputs): Add prototype.
11129
11130         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11131         back to fputs only if the former returns zero.
11132
11133 2019-03-07  Tom Tromey  <tom@tromey.com>
11134
11135         * symmisc.c (print_symbol_bcache_statistics): Update.
11136         (print_objfile_statistics): Update.
11137         * symfile.c (allocate_symtab): Update.
11138         * stabsread.c: Don't include bcache.h.
11139         * psymtab.h (struct psymbol_bcache): Don't declare.
11140         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11141         (psymbol_bcache_init, psymbol_bcache_free)
11142         (psymbol_bcache_get_bcache): Don't declare.
11143         * psymtab.c (struct psymbol_bcache): Remove.
11144         (psymtab_storage::psymtab_storage): Update.
11145         (psymtab_storage::~psymtab_storage): Update.
11146         (psymbol_bcache_init, psymbol_bcache_free)
11147         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11148         (add_psymbol_to_bcache): Update.
11149         (allocate_psymtab): Update.
11150         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11151         macro_cache>: No longer pointers.
11152         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11153         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11154         * macrotab.c (macro_bcache): Update.
11155         * macroexp.c: Don't include bcache.h.
11156         * gdbtypes.c (check_types_worklist): Update.
11157         (types_deeply_equal): Remove TRY/CATCH.  Update.
11158         * elfread.c (elf_symtab_read): Update.
11159         * dwarf2read.c: Don't include bcache.h.
11160         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11161         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11162         (print_bcache_statistics, bcache_memory_used): Don't declare.
11163         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11164         methods.  Rename all data members.
11165         * bcache.c (struct bcache): Move to bcache.h.
11166         (bcache::expand_hash_table): Rename from expand_hash_table.
11167         (bcache): Remove.
11168         (bcache::insert): Rename from bcache_full.
11169         (bcache::compare): Rename from bcache_compare.
11170         (bcache_xmalloc): Remove.
11171         (bcache::~bcache): Rename from bcache_xfree.
11172         (bcache::print_statistics): Rename from print_bcache_statistics.
11173         (bcache::memory_used): Rename from bcache_memory_used.
11174
11175 2019-03-07  Pedro Alves  <palves@redhat.com>
11176
11177         * infrun.c (normal_stop): Also check for
11178         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11179
11180 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * f-lang.c (value_from_host_double): Moved to...
11183         * value.c (value_from_host_double): ...here.
11184         * value.h (value_from_host_double): Declare.
11185         * guile/scm-math.c (vlscm_convert_typed_number): Use
11186         value_from_host_double.
11187         (vlscm_convert_number): Likewise.
11188         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11189         * python/py-value.c (convert_value_from_python): Likewise.
11190
11191 2019-03-06  Tom Tromey  <tom@tromey.com>
11192
11193         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11194
11195 2019-03-06  Tom Tromey  <tom@tromey.com>
11196
11197         * utils.h (free_current_contents): Don't declare.
11198         * utils.c (free_current_contents): Remove.
11199
11200 2019-03-06  Tom Tromey  <tom@tromey.com>
11201
11202         * top.c (quit_force): Update.
11203         * main.c (captured_command_loop): Update.
11204         * common/new-op.c (operator new): Update.
11205         * common/common-exceptions.c (struct catcher)
11206         <save_cleanup_chain>: Remove member.
11207         (exceptions_state_mc_init): Update.
11208         (exception_try_scope_entry): Return nullptr.
11209         (exception_try_scope_exit, exception_rethrow)
11210         (throw_exception_sjlj, throw_exception_cxx): Update.
11211         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11212         (all_cleanups, do_cleanups, discard_cleanups)
11213         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11214         (restore_cleanups, restore_final_cleanups): Don't declare.
11215         (do_final_cleanups): Remove parameter.
11216         * common/cleanups.c (cleanup_chain, make_cleanup)
11217         (make_cleanup_dtor, all_cleanups, do_cleanups)
11218         (discard_my_cleanups, discard_cleanups)
11219         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11220         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11221         (null_cleanup): Remove.
11222         (do_final_cleanups): Remove parameter.
11223
11224 2019-03-06  Tom Tromey  <tom@tromey.com>
11225
11226         * remote.c (remote_target::remote_parse_stop_reply): Use
11227         unique_xmalloc_ptr.
11228
11229 2019-03-06  Tom Tromey  <tom@tromey.com>
11230
11231         * stabsread.c (struct stabs_field_info): Rename from field_info.
11232         <list, fnlist>: Add initializers.
11233         <obstack>: New member.
11234         (read_member_functions, read_struct_fields, read_baseclasses):
11235         Allocate on obstack.  Don't use cleanups.
11236         (read_one_struct_field, read_member_functions, read_struct_fields)
11237         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11238         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11239         (read_struct_type): Update.
11240
11241 2019-03-06  Tom Tromey  <tom@tromey.com>
11242
11243         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11244         * common/filestuff.h (make_cleanup_close): Don't declare.
11245         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11246         Remove.
11247
11248 2019-03-06  Tom Tromey  <tom@tromey.com>
11249
11250         * solib-aix.c: Use make_scope_exit.
11251
11252 2019-03-06  Tom Tromey  <tom@tromey.com>
11253
11254         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11255         Use make_scope_exit.
11256
11257 2019-03-06  Tom Tromey  <tom@tromey.com>
11258
11259         * solib-svr4.c (disable_probes_interface): Remove parameter.
11260         (svr4_handle_solib_event): Use make_scope_exit.
11261
11262 2019-03-06  Tom Tromey  <tom@tromey.com>
11263
11264         * remote.c (struct stop_reply_deleter): Remove.
11265         (stop_reply_up): Update.
11266         (struct stop_reply): Derive from notif_event.  Don't typedef.
11267         <regcache>: Now a std::vector.
11268         (stop_reply_xfree): Remove.
11269         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11270         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11271         (remote_target::discard_pending_stop_replies): Use delete.
11272         (remote_target::remote_parse_stop_reply): Update.
11273         (remote_target::process_stop_reply): Update.
11274         * remote-notif.h (struct notif_event): Add virtual destructor.
11275         Remove "dtr" member.
11276         (struct notif_client) <alloc_event>: Return a unique_ptr.
11277         (notif_event_xfree): Don't declare.
11278         (notif_event_up): New typedef.
11279         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11280         (notif_event_xfree, do_notif_event_xfree): Remove.
11281         (remote_notif_state_xfree): Update.
11282
11283 2019-03-06  Tom Tromey  <tom@tromey.com>
11284
11285         * infrun.c (displaced_step_clear_cleanup): Now a
11286         forward_scope_exit type.
11287         (displaced_step_prepare_throw): Update.
11288         (displaced_step_fixup): Update.
11289
11290 2019-03-06  Tom Tromey  <tom@tromey.com>
11291
11292         * inferior.h (class inferior): Update comment.
11293         * gdbthread.h (class thread_info): Update comment.
11294
11295 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11296             Tom Tromey  <tom@tromey.com>
11297
11298         * stabsread.h (struct stab_section_list): Remove.
11299         (coffstab_build_psymtabs): Update.
11300         * dbxread.c (symbuf_sections): Now a std::vector.
11301         (sect_idx): New global.
11302         (fill_symbuf): Update.
11303         (coffstab_build_psymtabs): Change type of stabsects parameter.
11304         Update.
11305         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11306         std::vector.
11307         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11308         (coff_locate_sections): Update.
11309         (coff_symfile_read): Remove cleanups.  Update.
11310         (init_stringtab): Add storage parameter.
11311         (free_stringtab, free_stringtab_cleanup): Remove.
11312         (init_lineno): Add storage parameter.
11313         (free_linetab, free_linetab_cleanup): Remove.
11314
11315 2019-03-06  Pedro Alves  <palves@redhat.com>
11316
11317         * linux-fork.c (fork_info::clobber_regs): Delete.
11318         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11319         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11320         comment.  Adjust.
11321         (scoped_switch_fork_info::scoped_switch_fork_info)
11322         (checkpoint_command, linux_fork_context): Adjust
11323         fork_save_infrun_state calls.
11324
11325 2019-03-06  Pedro Alves  <palves@redhat.com>
11326
11327         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11328         (inf_has_multiple_threads): Return 'bool' and rewrite using
11329         inferior_info::threads().
11330
11331 2019-03-06  Pedro Alves  <palves@redhat.com>
11332
11333         * linux-fork.c: Include <list>.
11334         (fork_list): Now a std::list instance.
11335         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11336         (forks_exist_p, find_last_fork): Adjust.
11337         (new_fork): Delete.
11338         (one_fork_p): New.
11339         (add_fork): Adjust.
11340         (free_fork): Delete, folded into fork_info::~fork_info().
11341         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11342         Adjust.
11343         (init_fork_list): Delete.
11344         (linux_fork_killall, linux_fork_mourn_inferior)
11345         (linux_fork_detach, info_checkpoints_command): Adjust.
11346         (_initialize_linux_fork): No longer call init_fork_list.
11347
11348 2019-03-06  Pedro Alves  <palves@redhat.com>
11349
11350         * linux-fork.c (new_fork): New, split out of ...
11351         (add_fork): ... this.  Return void.  Move "first fork" special
11352         case from here, to ...
11353         (checkpoint_command): ... here.
11354         * linux-linux.h (add_fork): Return void.
11355
11356 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11357
11358         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11359
11360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11361             Chris January  <chris.january@arm.com>
11362             David Lecomber  <david.lecomber@arm.com>
11363
11364         * f-exp.y: New token, UNOP_INTRINSIC.
11365         (exp): New pattern using UNOP_INTRINSIC token.
11366         (f77_keywords): Add 'abs' keyword.
11367         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11368         (value_from_host_double): New function.
11369         (evaluate_subexp_f): Support UNOP_ABS.
11370
11371 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11372
11373         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11374         types.
11375
11376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11377
11378         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11379         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11380         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11381
11382 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11383
11384         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11385
11386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11387             Chris January  <chris.january@arm.com>
11388
11389         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11390         * f-exp.y: Define 'KIND' token.
11391         (exp): New pattern for KIND expressions.
11392         (ptype): Handle types with a kind extension.
11393         (direct_abs_decl): Extend to spot kind extensions.
11394         (f77_keywords): Add 'kind' to the list.
11395         (push_kind_type): New function.
11396         (convert_to_kind_type): New function.
11397         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11398         * parse.c (operator_length_standard): Likewise.
11399         * parser-defs.h (enum type_pieces): Add tp_kind.
11400         * std-operator.def: Add UNOP_KIND.
11401
11402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11403
11404         * f-exp.y (f_parse): Set yydebug.
11405
11406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11407
11408         * f-lang.c (evaluate_subexp_f): New function.
11409         (exp_descriptor_f): New global.
11410         (f_language_defn): Use exp_descriptor_f instead of
11411         exp_descriptor_standard.
11412
11413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * f-exp.y (struct token): Add comments.
11416         (dot_ops): Remove uppercase versions and the end marker.
11417         (f77_keywords): Likewise.
11418         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11419         entries in the dot_ops array are case insensitive, and use
11420         strncasecmp to compare strings.  Also some whitespace cleanup in
11421         this area.  Similar for the f77_keywords array, except entries in
11422         this list might be case sensitive.
11423
11424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11425
11426         * f-exp.y (struct f77_boolean_val): Add comments.
11427         (boolean_values): Remove uppercase versions, and end marker.
11428         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11429         and use strncasecmp to achieve case insensitivity.  Additionally,
11430         perform whitespace cleanup around this code.
11431
11432 2019-03-06  Tom Tromey  <tromey@adacore.com>
11433
11434         * remote-sim.c (gdbsim_target_open): Use result of
11435         gdb_argv::release.
11436
11437 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11438         Dirk Schubert  <dirk.schubert@arm.com>
11439         Chris January  <chris.january@arm.com>
11440
11441         * eval.c (evaluate_subexp_standard): Call Fortran argument
11442         wrapping logic.
11443         * f-lang.c (struct value): A value which can be passed into a
11444         Fortran function call.
11445         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11446         where appropriate.
11447         (struct type): Value ready for a Fortran function call.
11448         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11449         is needed.
11450         * f-lang.h (fortran_argument_convert): Declaration.
11451         (fortran_preserve_arg_pointer): Declaration.
11452         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11453
11454 2019-03-05  Tom Tromey  <tromey@adacore.com>
11455
11456         * python/py-prettyprint.c (print_string_repr): Remove #if.
11457         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11458
11459 2019-03-05  Tom Tromey  <tromey@adacore.com>
11460
11461         * target.c (the_dummy_target): Move later.  Change type to
11462         "dummy_target".
11463         (initialize_targets): Don't initialize the_dummy_target.
11464
11465 2019-03-05  Tom Tromey  <tromey@adacore.com>
11466
11467         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11468         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11469
11470 2019-03-05  Tom Tromey  <tromey@adacore.com>
11471
11472         * windows-nat.c (windows_nat_target::attach)
11473         (windows_nat_target::detach): Don't call gdb_flush.
11474         * valprint.c (generic_val_print, val_print, val_print_string):
11475         Don't call gdb_flush.
11476         * utils.c (defaulted_query): Don't call gdb_flush.
11477         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11478         * target.c (target_announce_detach): Don't call gdb_flush.
11479         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11480         * remote.c (extended_remote_target::attach): Don't call
11481         gdb_flush.
11482         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11483         * printcmd.c (do_examine): Don't call gdb_flush.
11484         (info_display_command): Don't call gdb_flush.
11485         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11486         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11487         * memattr.c (info_mem_command): Don't call gdb_flush.
11488         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11489         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11490         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11491         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11492         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11493         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11494         (gnu_nat_target::detach): Don't call gdb_flush.
11495         * f-valprint.c (f_val_print): Don't call gdb_flush.
11496         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11497         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11498         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11499         gdb_flush.
11500         * c-valprint.c (c_val_print): Don't call gdb_flush.
11501         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11502
11503 2019-03-05  Tom Tromey  <tromey@adacore.com>
11504
11505         * varobj.c (update_dynamic_varobj_children): Update.
11506         (install_default_visualizer): Use reset, not release.
11507         * value.c (set_internalvar): Update.
11508         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11509         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11510         ATTRIBUTE_UNUSED_RESULT.
11511
11512 2019-03-05  Tom Tromey  <tromey@adacore.com>
11513
11514         * remote.c (class scoped_remote_fd) <release>: Add
11515         ATTRIBUTE_UNUSED_RESULT.
11516
11517 2019-03-05  Tom Tromey  <tromey@adacore.com>
11518
11519         * macroexp.c (struct macro_buffer) <release>: Add
11520         ATTRIBUTE_UNUSED_RESULT.
11521
11522 2019-03-05  Tom Tromey  <tromey@adacore.com>
11523
11524         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11525         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11526         ATTRIBUTE_UNUSED_RESULT.
11527
11528 2019-03-05  Tom Tromey  <tromey@adacore.com>
11529
11530         * common/scoped_fd.h (class scoped_fd) <release>: Add
11531         ATTRIBUTE_UNUSED_RESULT.
11532
11533 2019-03-05  Tom Tromey  <tromey@adacore.com>
11534
11535         * parser-defs.h (struct parser_state) <release>: Add
11536         ATTRIBUTE_UNUSED_RESULT.
11537
11538 2019-03-05  Tom Tromey  <tromey@adacore.com>
11539
11540         * utils.h (class gdb_argv) <release>: Add
11541         ATTRIBUTE_UNUSED_RESULT.
11542         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11543
11544 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11545
11546         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11547         for-loop range, to avoid compiler warnings.
11548
11549         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11550         avoid compiler warnings about unused variables.
11551
11552         * NEWS: Mention end of support for native debugging on MS-Windows
11553         before XP.
11554
11555         PR gdb/24292
11556         * common/netstuff.c:
11557         * gdbserver/gdbreplay.c
11558         * gdbserver/remote-utils.c:
11559         * ser-tcp.c:
11560         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11561         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11562         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11563         'getaddrinfo' and 'freeaddrinfo' were not available before
11564         Windows XP, and mingw.org's MinGW headers by default define
11565         _WIN32_WINNT to 0x500.
11566
11567 2019-03-01  Gary Benson <gbenson@redhat.com>
11568
11569         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11570
11571 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11572             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11573
11574         PR gdb/8527
11575         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11576         set_sigint_trap, clear_sigint_trap.
11577
11578 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11579
11580         * target.c (target_detach): Clear the regcache and the
11581         frame cache.
11582
11583 2019-02-27  Pedro Alves  <palves@redhat.com>
11584
11585         * utils.c (set_screen_size): When we cap the height/width sizes,
11586         tweak the corresponding command variable to show "unlimited":
11587
11588 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11589             Pedro Alves  <palves@redhat.com>
11590
11591         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11592         before calling rl_set_screen_size.
11593
11594 2019-02-27  Tom Tromey  <tromey@adacore.com>
11595
11596         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11597         define.
11598         * python/py-value.c: Remove Python 2.4 workaround.
11599         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11600         workaround.
11601         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11602         Python 2.4 workaround.
11603         * python/python-internal.h: Remove Python 2.4 comment.
11604         (Py_ssize_t): Don't define.
11605         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11606         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11607         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11608         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11609         * python/python.c (do_start_initialization): Remove Python 2.4
11610         workaround.
11611         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11612         (print_children): Remove Python 2.4 workaround.
11613         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11614         workaround.
11615         (CHARBUFFERPROC_NAME): Remove.
11616         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11617         Python 2.4 workaround.
11618
11619 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11620
11621         * NEWS: Note minimum Python version.
11622
11623 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11624
11625         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11626         code from these functions.  Remove corresponding ifdefs.  Use
11627         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11628         Remove gotos and target of gotos.
11629         (infpy_search_memory): Likewise.
11630
11631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11634         (hppa_gdbarch_init): Don't register deleted functions with
11635         gdbarch.
11636
11637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11638
11639         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11640         (h8300_unwind_sp): Delete.
11641         (h8300_dummy_id): Delete.
11642         (h8300_gdbarch_init): Don't register deleted functions with
11643         gdbarch.
11644
11645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11648         (ft32_unwind_pc): Delete.
11649         (ft32_unwind_sp): Delete.
11650         (ft32_gdbarch_init): Don't register deleted functions with
11651         gdbarch.
11652
11653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11654
11655         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11656         (frv_unwind_pc): Delete.
11657         (frv_unwind_sp): Delete.
11658         (frv_gdbarch_init): Don't register deleted functions with
11659         gdbarch.
11660
11661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11662
11663         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11664         (riscv_unwind_pc): Delete.
11665         (riscv_unwind_sp): Delete.
11666         (riscv_gdbarch_init): Don't register deleted functions with
11667         gdbarch.
11668
11669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11670
11671         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11672         (csky_unwind_pc): Delete.
11673         (csky_unwind_sp): Delete.
11674         (csky_gdbarch_init): Don't register deleted functions with
11675         gdbarch.
11676
11677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11678
11679         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11680         (cris_unwind_pc): Delete.
11681         (cris_unwind_sp): Delete.
11682         (cris_gdbarch_init): Don't register deleted functions with
11683         gdbarch.
11684
11685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11686
11687         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11688         (bfin_unwind_pc): Delete.
11689         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11690
11691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11692
11693         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11694         (arm_unwind_pc): Delete.
11695         (arm_unwind_sp): Delete.
11696         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11697
11698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11699
11700         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11701         (arc_unwind_pc): Delete.
11702         (arc_unwind_sp): Delete.
11703         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11704
11705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11706
11707         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11708         (alpha_unwind_pc): Delete.
11709         (alpha_gdbarch_init): Don't register deleted functions with
11710         gdbarch.
11711
11712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11713
11714         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11715         (aarch64_unwind_pc): Delete.
11716         (aarch64_unwind_sp): Delete.
11717         (aarch64_gdbarch_init): Don't register deleted functions with
11718         gdbarch.
11719
11720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11721
11722         * gdbtypes.c (type_align): Don't consider static members when
11723         computing structure alignment.
11724
11725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11728         return 0 for other types.
11729         * arch-utils.c (default_type_align): Always return 0.
11730         * gdbarch.h: Regenerate.
11731         * gdbarch.sh (type_align): Extend comment.
11732         * gdbtypes.c (type_align): Add additional comments, always call
11733         gdbarch_type_align before applying the default rules.
11734         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11735         generic code will then apply a suitable default.
11736         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11737         types, return 0 for other types.
11738
11739 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11740
11741         * NEWS: Create a new section for the next release branch.
11742         Rename the section of the current branch, now that it has
11743         been cut.
11744
11745 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11746
11747         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11748         * version.in: Bump version to 8.3.50.DATE-git.
11749
11750 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11751
11752         * aix-thread.c (ptid_cmp): Remove unused variable.
11753         (get_signaled_thread): Likewise.
11754         (store_regs_user_thread): Likewise.
11755         (store_regs_kernel_thread): Likewise.
11756         (fetch_regs_kernel_thread): Remove shadowed variable.
11757
11758 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11759
11760         * features/riscv/32bit-cpu.xml: Add register numbers.
11761         * features/riscv/32bit-fpu.c: Regenerate.
11762         * features/riscv/32bit-fpu.xml: Add register numbers.
11763         * features/riscv/64bit-cpu.xml: Add register numbers.
11764         * features/riscv/64bit-fpu.c: Regenerate.
11765         * features/riscv/64bit-fpu.xml: Add register numbers.
11766
11767 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11768
11769         * NEWS: Mention two argument form of gdb.Value constructor.
11770         * python/py-value.c (convert_buffer_and_type_to_value): New
11771         function.
11772         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11773         Add support for handling an optional second argument.  Call
11774         convert_buffer_and_type_to_value as appropriate.
11775         * python/python-internal.h (Py_buffer_deleter): New struct.
11776         (Py_buffer_up): New typedef.
11777
11778 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11779
11780         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11781         instead of releasing ownership.
11782
11783 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11784
11785         * dwarf2read.c (open_and_init_dwp_file): Call
11786         elf_numsections instead of bfd_count_sections to initialize
11787         dwp_file->num_sections.
11788
11789 2019-02-25  Tom Tromey  <tromey@adacore.com>
11790
11791         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11792
11793 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11794
11795         * gcore.in: Add '--readnever' option when invoking GDB.
11796
11797 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11798
11799         * MAINTAINERS: Update my email address.
11800
11801 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11802
11803         * build-id.c (build_id_to_debug_bfd_1): New function.
11804         (build_id_to_debug_bfd): Look for separate debug file in
11805         sysroot.
11806
11807 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11808
11809         * gdbarch.sh: Update the copyright year range that is placed into
11810         generated files.
11811
11812 2019-02-22  Keith Seitz  <keiths@redhat.com>
11813
11814         PR symtab/23853
11815         * linespec.c (create_sals_line_offset): Search for the default
11816         symtab's filename instead of its fullname.
11817
11818 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11819
11820         * NEWS: Update style defaults.
11821
11822 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11823
11824         * main.c (captured_main_1): Disable styling in batch mode.
11825
11826 2019-02-20  Tom Tromey  <tom@tromey.com>
11827
11828         * symtab.c (symtab_symbol_info): Fix typos.
11829
11830 2019-02-20  Tom Tromey  <tromey@adacore.com>
11831
11832         * findcmd.c (_initialize_mem_search): Use upper case for
11833         metasyntactic variables.
11834
11835 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11836
11837         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11838         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11839
11840 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11841
11842         * top.h (source_file_name): Change to std::string.
11843         * top.c (source_file_name): Likewise.
11844         (command_line_input): Adjust.
11845         * cli/cli-script.c (script_from_file): Adjust.
11846
11847 2019-02-19  Tom Tromey  <tromey@adacore.com>
11848
11849         * ravenscar-thread.c
11850         (ravenscar_thread_target::update_thread_list): Don't call
11851         ada_build_task_list.
11852         * ada-lang.h (ada_build_task_list): Don't declare.
11853         * ada-tasks.c (struct ada_tasks_inferior_data)
11854         <task_list_valid_p>: Now bool.
11855         (read_known_tasks, ada_task_list_changed)
11856         (ada_tasks_invalidate_inferior_data): Update.
11857         (read_known_tasks_array): Return bool.
11858         (read_known_tasks_list): Likewise.
11859         (read_known_tasks): Return void.
11860         (ada_build_task_list): Now static.
11861
11862 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11865         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11866
11867 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11868
11869         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11870         variant for ada_tasks_pspace_data_handle and
11871         ada_tasks_inferior_data_handle.
11872         (ada_tasks_pspace_data_cleanup): New function.
11873         (ada_tasks_inferior_data_cleanup): New function.
11874
11875 2019-02-17  Tom Tromey  <tom@tromey.com>
11876
11877         * macrotab.h (macro_source_fullname): Return a std::string.
11878         * macrotab.c (macro_include, check_for_redefinition)
11879         (macro_undef, macro_lookup_definition, foreach_macro)
11880         (foreach_macro_in_scope): Update.
11881         (macro_source_fullname): Return a std::string.
11882         * macrocmd.c (show_pp_source_pos): Update.
11883
11884 2019-02-17  Tom Tromey  <tom@tromey.com>
11885
11886         * macrocmd.c (show_pp_source_pos): Style the file names.
11887
11888 2019-02-17  Tom Tromey  <tom@tromey.com>
11889
11890         PR tui/24197:
11891         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11892
11893 2019-02-17  Tom Tromey  <tom@tromey.com>
11894
11895         * ada-lang.c (user_select_syms): Use filtered printing.
11896         * utils.c (wrap_style): New global.
11897         (desired_style): Remove.
11898         (emit_style_escape): Add stream parameter.
11899         (set_output_style, reset_terminal_style, prompt_for_continue):
11900         Update.
11901         (flush_wrap_buffer): Only flush gdb_stdout.
11902         (wrap_here): Set wrap_style.
11903         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11904         treat escape sequences as a character.  Change when wrap buffer is
11905         flushed.
11906         (fputs_styled): Do not set the output style when the default is
11907         requested.
11908         * ui-style.h (struct ui_file_style) <is_default>: New method.
11909         * source.c (print_source_lines_base): Emit escape sequences in one
11910         piece.
11911
11912 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11913
11914         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11915         integers and enumeration types.
11916
11917 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11918
11919         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11920         instead of lookup_symbol_in_language
11921         (do_exact_match): New function.
11922         (ada_get_symbol_name_matcher): Return do_exact_match when
11923         doing a verbatim match.
11924
11925 2019-02-15  Tom Tromey  <tromey@adacore.com>
11926
11927         * ravenscar-thread.c (ravenscar_thread_target::resume)
11928         (ravenscar_thread_target::wait): Special case wildcard requests.
11929
11930 2019-02-15  Tom Tromey  <tromey@adacore.com>
11931
11932         * ravenscar-thread.c (base_ptid): Remove.
11933         (struct ravenscar_thread_target) <close>: New method.
11934         <m_base_ptid>: New member.
11935         <update_inferior_ptid, active_task, task_is_currently_active,
11936         runtime_initialized>: Declare methods.
11937         <ravenscar_thread_target>: Add constructor.
11938         (ravenscar_thread_target::task_is_currently_active)
11939         (ravenscar_thread_target::update_inferior_ptid)
11940         (ravenscar_runtime_initialized): Rename.  Now methods.
11941         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11942         (ravenscar_thread_target::update_thread_list): Update.
11943         (ravenscar_thread_target::active_task): Now method.
11944         (ravenscar_thread_target::store_registers)
11945         (ravenscar_thread_target::prepare_to_store)
11946         (ravenscar_thread_target::prepare_to_store)
11947         (ravenscar_thread_target::mourn_inferior): Update.
11948         (ravenscar_inferior_created): Use "new" to create target.
11949         (ravenscar_thread_target::get_ada_task_ptid): Update.
11950         (_initialize_ravenscar): Don't initialize base_ptid.
11951         (ravenscar_ops): Remove global.
11952
11953 2019-02-15  Tom Tromey  <tromey@adacore.com>
11954
11955         * target.h (push_target): Declare new overload.
11956         * target.c (push_target): New overload, taking an rvalue reference.
11957         * remote.c (remote_target::open_1): Use push_target overload.
11958         * corelow.c (core_target_open): Use push_target overload.
11959
11960 2019-02-15  Tom Tromey  <tromey@adacore.com>
11961
11962         * ravenscar-thread.c (is_ravenscar_task)
11963         (ravenscar_task_is_currently_active): Return bool.
11964         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11965         (_initialize_ravenscar): Remove "(void)".
11966         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11967         Return bool.
11968
11969 2019-02-15  Tom Tromey  <tromey@adacore.com>
11970
11971         * ravenscar-thread.c (ravenscar_runtime_initializer)
11972         (has_ravenscar_runtime, get_running_thread_id)
11973         (ravenscar_thread_target::resume): Fix indentation.
11974
11975 2019-02-15  Tom Tromey  <tromey@adacore.com>
11976
11977         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11978         from ravenscar_arch_ops.
11979         (sparc_ravenscar_ops::fetch_registers)
11980         (sparc_ravenscar_ops::store_registers): Now methods.
11981         (sparc_ravenscar_prepare_to_store): Remove.
11982         (sparc_ravenscar_ops): Redefine.
11983         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11984         methods and destructor.  Remove members.
11985         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11986         (ravenscar_thread_target::store_registers)
11987         (ravenscar_thread_target::prepare_to_store): Update.
11988         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11989         Remove.
11990         (struct ppc_ravenscar_powerpc_ops): Derive from
11991         ravenscar_arch_ops.
11992         (ppc_ravenscar_powerpc_ops::fetch_registers)
11993         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11994         (ppc_ravenscar_powerpc_ops): Redefine.
11995         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11996         (ppc_ravenscar_e500_ops::fetch_registers)
11997         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11998         (ppc_ravenscar_e500_ops): Redefine.
11999         * aarch64-ravenscar-thread.c
12000         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12001         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12002         (aarch64_ravenscar_fetch_registers)
12003         (aarch64_ravenscar_store_registers): Now methods.
12004         (aarch64_ravenscar_ops): Redefine.
12005
12006 2019-02-15  Tom Tromey  <tromey@adacore.com>
12007
12008         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12009         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12010         (ravenscar_thread_target::stopped_by_watchpoint)
12011         (ravenscar_thread_target::stopped_data_address)
12012         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12013
12014 2019-02-15  Tom Tromey  <tromey@adacore.com>
12015
12016         * ravenscar-thread.c: Fix some typos.
12017
12018 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12019             Tom Tromey  <tromey@adacore.com>
12020
12021         * ada-lang.c (ada_exception_sal): Change addr_string to a
12022         std::string.
12023         (create_ada_exception_catchpoint): Update.
12024
12025 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12026             Tom Tromey  <tromey@adacore.com>
12027
12028         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12029         (bp_location_ops): Remove.
12030         (base_breakpoint_allocate_location): Update.
12031         (free_bp_location): Update.
12032         * ada-lang.c (class ada_catchpoint_location)
12033         <ada_catchpoint_location>: Remove ops parameter.
12034         (ada_catchpoint_location_dtor): Remove.
12035         (ada_catchpoint_location_ops): Remove.
12036         (allocate_location_exception): Update.
12037         * breakpoint.h (struct bp_location_ops): Remove.
12038         (class bp_location) <bp_location>: Remove bp_location_ops
12039         parameter.
12040         <~bp_location>: Add destructor.
12041         <ops>: Remove.
12042
12043 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12044             Pedro Alves  <palves@redhat.com>
12045
12046         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12047         'PATH_MAX'.
12048
12049 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12050             Samuel Thibault  <samuel.thibault@gnu.org>
12051             Thomas Schwinge  <thomas@codesourcery.com>
12052
12053         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12054         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12055
12056 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12057
12058         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12059         (check_empty): Use "const char *".
12060
12061         * gnu-nat.c (gnu_nat_target::detach): Instead of
12062         'detach_inferior (pid)' call
12063         'detach_inferior (find_inferior_pid (pid))'.
12064
12065         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12066         'nat/fork-inferior.o'.
12067         * gnu-nat.c: #include "nat/fork-inferior.h".
12068
12069         * gnu-nat.c (gnu_nat_target::detach): Instead of
12070         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12071         * gnu-nat.h: #include "inf-child.h".
12072         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12073         'i386_gnu_nat_target::fetch_registers'.
12074         (gnu_store_registers): Rename/move to
12075         'i386_gnu_nat_target::store_registers'.
12076
12077         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12078         * gnu-nat.h (mach_thread_info): New function.
12079         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12080
12081         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12082
12083 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12084
12085         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12086
12087 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12088
12089         * windows-nat.c (windows_add_thread): Add new parameter
12090         "main_thread_p" with default value set to false.  Update
12091         function documentation as well as all callers.
12092         (windows_delete_thread): Likewise.
12093         (fake_create_process): Update call to windows_add_thread.
12094         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12095         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12096         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12097         call to windows_delete_thread.
12098
12099 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12100
12101         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12102
12103 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12104
12105         * symfile.c (find_separate_debug_file): Use canonical path of
12106         sysroot with child_path instead of gdb_sysroot if it is valid.
12107
12108 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12109
12110         * symfile.c (find_separate_debug_file): Use child_path to
12111         determine if an object file is under a sysroot.
12112
12113 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12114
12115         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12116         unittests/child-path-selftests.c.
12117         * common/pathstuff.c (child_path): New function.
12118         * common/pathstuff.h (child_path): New prototype.
12119         * unittests/child-path-selftests.c: New file.
12120
12121 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12122
12123         * symfile.c (find_separate_debug_file): Look for separate debug
12124         files in debug directories under the sysroot.
12125
12126 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12127
12128         * symtab.h (struct minimal_symbol data_p): New const method.
12129         (struct minimal_symbol text_p): Likewise.
12130         * symtab.c (output_source_filename): Use file name style
12131         to print file name.
12132         (print_symbol_info): Likewise.
12133         (print_msymbol_info): Use address style to print addresses.
12134         Use function name style to print executable text symbols.
12135         (expand_symtab_containing_pc): Use data_p.
12136         (find_pc_sect_compunit_symtab): Likewise.
12137
12138 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12139
12140         * breakpoint.c (describe_other_breakpoints): Use address style
12141         to print addresses.
12142         (say_where): Likewise.
12143
12144 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12145
12146         * ada-typeprint.c (print_func_type): Print function name
12147         style to print function name.
12148         * c-typeprint.c (c_print_type_1): Likewise.
12149
12150 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12151
12152         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12153         for execve.
12154
12155 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12156
12157         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12158         type_stack.
12159
12160 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12161
12162         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12163         TYPE_CODE_REF types.
12164
12165 2019-02-08  Jim Wilson  <jimw@sifive.com>
12166
12167         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12168         (riscv_linux_fregset): New.
12169         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12170
12171 2019-02-07  Tom Tromey  <tom@tromey.com>
12172
12173         * thread.c (thread_cancel_execution_command): Update.
12174         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12175         methods.
12176         (struct thread_fsm_ops): Remove.
12177         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12178         (thread_fsm_should_stop, thread_fsm_return_value)
12179         (thread_fsm_set_finished, thread_fsm_finished_p)
12180         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12181         Don't declare.
12182         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12183         * infrun.c (clear_proceed_status_thread)
12184         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12185         (print_stop_event): Update.
12186         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12187         Add constructor.
12188         (step_command_fsm_ops): Remove.
12189         (new_step_command_fsm): Remove.
12190         (step_1): Update.
12191         (step_command_fsm::should_stop): Rename from
12192         step_command_fsm_should_stop.
12193         (step_command_fsm::clean_up): Rename from
12194         step_command_fsm_clean_up.
12195         (step_command_fsm::do_async_reply_reason): Rename from
12196         step_command_fsm_async_reply_reason.
12197         (struct until_next_fsm): Inherit from thread_fsm.  Add
12198         constructor.
12199         (until_next_fsm_ops): Remove.
12200         (new_until_next_fsm): Remove.
12201         (until_next_fsm::should_stop): Rename from
12202         until_next_fsm_should_stop.
12203         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12204         (until_next_fsm::do_async_reply_reason): Rename from
12205         until_next_fsm_async_reply_reason.
12206         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12207         constructor.  Change type of breakpoint.
12208         (finish_command_fsm_ops): Remove.
12209         (new_finish_command_fsm): Remove.
12210         (finish_command_fsm::should_stop): Rename from
12211         finish_command_fsm_should_stop.
12212         (finish_command_fsm::clean_up): Rename from
12213         finish_command_fsm_clean_up.
12214         (finish_command_fsm::return_value): Rename from
12215         finish_command_fsm_return_value.
12216         (finish_command_fsm::do_async_reply_reason): Rename from
12217         finish_command_fsm_async_reply_reason.
12218         (finish_command): Update.
12219         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12220         Add constructor.
12221         (call_thread_fsm_ops): Remove.
12222         (call_thread_fsm::call_thread_fsm): Rename from
12223         new_call_thread_fsm.
12224         (call_thread_fsm::should_stop): Rename from
12225         call_thread_fsm_should_stop.
12226         (call_thread_fsm::should_notify_stop): Rename from
12227         call_thread_fsm_should_notify_stop.
12228         (run_inferior_call, call_function_by_hand_dummy): Update.
12229         * cli/cli-interp.c (should_print_stop_to_console): Update.
12230         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12231         Add constructor.  Change type of location_breakpoint,
12232         caller_breakpoint.
12233         (until_break_fsm_ops): Remove.
12234         (new_until_break_fsm): Remove.
12235         (until_break_fsm::should_stop): Rename from
12236         until_break_fsm_should_stop.
12237         (until_break_fsm::clean_up): Rename from
12238         until_break_fsm_clean_up.
12239         (until_break_fsm::do_async_reply_reason): Rename from
12240         until_break_fsm_async_reply_reason.
12241         (until_break_command): Update.
12242         * thread-fsm.c: Remove.
12243         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12244
12245 2019-02-07  Tom Tromey  <tom@tromey.com>
12246
12247         * yy-remap.h: Add include guard.
12248         * xtensa-tdep.h: Add include guard.
12249         * xcoffread.h: Rename include guard.
12250         * varobj-iter.h: Add include guard.
12251         * tui/tui.h: Rename include guard.
12252         * tui/tui-winsource.h: Rename include guard.
12253         * tui/tui-wingeneral.h: Rename include guard.
12254         * tui/tui-windata.h: Rename include guard.
12255         * tui/tui-win.h: Rename include guard.
12256         * tui/tui-stack.h: Rename include guard.
12257         * tui/tui-source.h: Rename include guard.
12258         * tui/tui-regs.h: Rename include guard.
12259         * tui/tui-out.h: Rename include guard.
12260         * tui/tui-layout.h: Rename include guard.
12261         * tui/tui-io.h: Rename include guard.
12262         * tui/tui-hooks.h: Rename include guard.
12263         * tui/tui-file.h: Rename include guard.
12264         * tui/tui-disasm.h: Rename include guard.
12265         * tui/tui-data.h: Rename include guard.
12266         * tui/tui-command.h: Rename include guard.
12267         * tic6x-tdep.h: Add include guard.
12268         * target/waitstatus.h: Rename include guard.
12269         * target/wait.h: Rename include guard.
12270         * target/target.h: Rename include guard.
12271         * target/resume.h: Rename include guard.
12272         * target-float.h: Rename include guard.
12273         * stabsread.h: Add include guard.
12274         * rs6000-tdep.h: Add include guard.
12275         * riscv-fbsd-tdep.h: Add include guard.
12276         * regformats/regdef.h: Rename include guard.
12277         * record.h: Rename include guard.
12278         * python/python.h: Rename include guard.
12279         * python/python-internal.h: Rename include guard.
12280         * python/py-stopevent.h: Rename include guard.
12281         * python/py-ref.h: Rename include guard.
12282         * python/py-record.h: Rename include guard.
12283         * python/py-record-full.h: Rename include guard.
12284         * python/py-record-btrace.h: Rename include guard.
12285         * python/py-instruction.h: Rename include guard.
12286         * python/py-events.h: Rename include guard.
12287         * python/py-event.h: Rename include guard.
12288         * procfs.h: Add include guard.
12289         * proc-utils.h: Add include guard.
12290         * p-lang.h: Add include guard.
12291         * or1k-tdep.h: Rename include guard.
12292         * observable.h: Rename include guard.
12293         * nto-tdep.h: Rename include guard.
12294         * nat/x86-linux.h: Rename include guard.
12295         * nat/x86-linux-dregs.h: Rename include guard.
12296         * nat/x86-gcc-cpuid.h: Add include guard.
12297         * nat/x86-dregs.h: Rename include guard.
12298         * nat/x86-cpuid.h: Rename include guard.
12299         * nat/ppc-linux.h: Rename include guard.
12300         * nat/mips-linux-watch.h: Rename include guard.
12301         * nat/linux-waitpid.h: Rename include guard.
12302         * nat/linux-ptrace.h: Rename include guard.
12303         * nat/linux-procfs.h: Rename include guard.
12304         * nat/linux-osdata.h: Rename include guard.
12305         * nat/linux-nat.h: Rename include guard.
12306         * nat/linux-namespaces.h: Rename include guard.
12307         * nat/linux-btrace.h: Rename include guard.
12308         * nat/glibc_thread_db.h: Rename include guard.
12309         * nat/gdb_thread_db.h: Rename include guard.
12310         * nat/gdb_ptrace.h: Rename include guard.
12311         * nat/fork-inferior.h: Rename include guard.
12312         * nat/amd64-linux-siginfo.h: Rename include guard.
12313         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12314         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12315         * nat/aarch64-linux.h: Rename include guard.
12316         * nat/aarch64-linux-hw-point.h: Rename include guard.
12317         * mn10300-tdep.h: Add include guard.
12318         * mips-linux-tdep.h: Add include guard.
12319         * mi/mi-parse.h: Rename include guard.
12320         * mi/mi-out.h: Rename include guard.
12321         * mi/mi-main.h: Rename include guard.
12322         * mi/mi-interp.h: Rename include guard.
12323         * mi/mi-getopt.h: Rename include guard.
12324         * mi/mi-console.h: Rename include guard.
12325         * mi/mi-common.h: Rename include guard.
12326         * mi/mi-cmds.h: Rename include guard.
12327         * mi/mi-cmd-break.h: Rename include guard.
12328         * m2-lang.h: Add include guard.
12329         * location.h: Rename include guard.
12330         * linux-record.h: Rename include guard.
12331         * linux-nat.h: Add include guard.
12332         * linux-fork.h: Add include guard.
12333         * i386-darwin-tdep.h: Rename include guard.
12334         * hppa-linux-offsets.h: Add include guard.
12335         * guile/guile.h: Rename include guard.
12336         * guile/guile-internal.h: Rename include guard.
12337         * gnu-nat.h: Rename include guard.
12338         * gdb-stabs.h: Rename include guard.
12339         * frv-tdep.h: Add include guard.
12340         * f-lang.h: Add include guard.
12341         * event-loop.h: Add include guard.
12342         * darwin-nat.h: Rename include guard.
12343         * cp-abi.h: Rename include guard.
12344         * config/sparc/nm-sol2.h: Rename include guard.
12345         * config/nm-nto.h: Rename include guard.
12346         * config/nm-linux.h: Add include guard.
12347         * config/i386/nm-i386gnu.h: Rename include guard.
12348         * config/djgpp/nl_types.h: Rename include guard.
12349         * config/djgpp/langinfo.h: Rename include guard.
12350         * compile/gcc-cp-plugin.h: Add include guard.
12351         * compile/gcc-c-plugin.h: Add include guard.
12352         * compile/compile.h: Rename include guard.
12353         * compile/compile-object-run.h: Rename include guard.
12354         * compile/compile-object-load.h: Rename include guard.
12355         * compile/compile-internal.h: Rename include guard.
12356         * compile/compile-cplus.h: Rename include guard.
12357         * compile/compile-c.h: Rename include guard.
12358         * common/xml-utils.h: Rename include guard.
12359         * common/x86-xstate.h: Rename include guard.
12360         * common/version.h: Rename include guard.
12361         * common/vec.h: Rename include guard.
12362         * common/tdesc.h: Rename include guard.
12363         * common/selftest.h: Rename include guard.
12364         * common/scoped_restore.h: Rename include guard.
12365         * common/scoped_mmap.h: Rename include guard.
12366         * common/scoped_fd.h: Rename include guard.
12367         * common/safe-iterator.h: Rename include guard.
12368         * common/run-time-clock.h: Rename include guard.
12369         * common/refcounted-object.h: Rename include guard.
12370         * common/queue.h: Rename include guard.
12371         * common/ptid.h: Rename include guard.
12372         * common/print-utils.h: Rename include guard.
12373         * common/preprocessor.h: Rename include guard.
12374         * common/pathstuff.h: Rename include guard.
12375         * common/observable.h: Rename include guard.
12376         * common/netstuff.h: Rename include guard.
12377         * common/job-control.h: Rename include guard.
12378         * common/host-defs.h: Rename include guard.
12379         * common/gdb_wait.h: Rename include guard.
12380         * common/gdb_vecs.h: Rename include guard.
12381         * common/gdb_unlinker.h: Rename include guard.
12382         * common/gdb_unique_ptr.h: Rename include guard.
12383         * common/gdb_tilde_expand.h: Rename include guard.
12384         * common/gdb_sys_time.h: Rename include guard.
12385         * common/gdb_string_view.h: Rename include guard.
12386         * common/gdb_splay_tree.h: Rename include guard.
12387         * common/gdb_setjmp.h: Rename include guard.
12388         * common/gdb_ref_ptr.h: Rename include guard.
12389         * common/gdb_optional.h: Rename include guard.
12390         * common/gdb_locale.h: Rename include guard.
12391         * common/gdb_assert.h: Rename include guard.
12392         * common/filtered-iterator.h: Rename include guard.
12393         * common/filestuff.h: Rename include guard.
12394         * common/fileio.h: Rename include guard.
12395         * common/environ.h: Rename include guard.
12396         * common/common-utils.h: Rename include guard.
12397         * common/common-types.h: Rename include guard.
12398         * common/common-regcache.h: Rename include guard.
12399         * common/common-inferior.h: Rename include guard.
12400         * common/common-gdbthread.h: Rename include guard.
12401         * common/common-exceptions.h: Rename include guard.
12402         * common/common-defs.h: Rename include guard.
12403         * common/common-debug.h: Rename include guard.
12404         * common/cleanups.h: Rename include guard.
12405         * common/buffer.h: Rename include guard.
12406         * common/btrace-common.h: Rename include guard.
12407         * common/break-common.h: Rename include guard.
12408         * cli/cli-utils.h: Rename include guard.
12409         * cli/cli-style.h: Rename include guard.
12410         * cli/cli-setshow.h: Rename include guard.
12411         * cli/cli-script.h: Rename include guard.
12412         * cli/cli-interp.h: Rename include guard.
12413         * cli/cli-decode.h: Rename include guard.
12414         * cli/cli-cmds.h: Rename include guard.
12415         * charset-list.h: Add include guard.
12416         * buildsym-legacy.h: Rename include guard.
12417         * bfin-tdep.h: Add include guard.
12418         * ax.h: Rename include guard.
12419         * arm-linux-tdep.h: Add include guard.
12420         * arm-fbsd-tdep.h: Add include guard.
12421         * arch/xtensa.h: Rename include guard.
12422         * arch/tic6x.h: Add include guard.
12423         * arch/i386.h: Add include guard.
12424         * arch/arm.h: Rename include guard.
12425         * arch/arm-linux.h: Rename include guard.
12426         * arch/arm-get-next-pcs.h: Rename include guard.
12427         * arch/amd64.h: Add include guard.
12428         * arch/aarch64-insn.h: Rename include guard.
12429         * arch-utils.h: Rename include guard.
12430         * annotate.h: Add include guard.
12431         * amd64-darwin-tdep.h: Rename include guard.
12432         * aarch64-linux-tdep.h: Add include guard.
12433         * aarch64-fbsd-tdep.h: Add include guard.
12434         * aarch32-linux-nat.h: Add include guard.
12435
12436 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12437
12438         * macrotab.c (macro_define_internal): New function that
12439         factorizes macro_define_object_internal and macro_define_function
12440         code.
12441         (macro_define_object_internal): Use macro_define_internal.
12442         (macro_define_function): Likewise.
12443
12444 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12445
12446         * macrocmd.c (extract_identifier): Return
12447         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12448         callers.
12449
12450 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12451
12452         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12453
12454 2019-02-05  Tom Tromey  <tom@tromey.com>
12455
12456         * target.c (target_stack::unpush): Move assertion earlier.
12457
12458 2019-01-30  Tom Tromey  <tom@tromey.com>
12459
12460         PR python/23615:
12461         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12462         (gdbpy_parse_and_eval): Likewise.
12463         * python/python-internal.h (gdbpy_allow_threads): New class.
12464
12465 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12466
12467         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12468         (aarch64_fbsd_fpregmap): Move earlier.
12469         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12470         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12471         instead of individual calls to trad_frame_set_reg_addr.
12472         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12473         earlier.
12474         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12475         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12476         instead of individual calls to trad_frame_set_reg_addr.
12477
12478 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12479
12480         * CONTRIBUTE: Replace contribution list with wiki link.
12481
12482 2019-01-25  Tom Tromey  <tom@tromey.com>
12483
12484         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12485
12486 2019-01-25  Tom Tromey  <tom@tromey.com>
12487
12488         * xtensa-linux-nat.c: Fix common/ includes.
12489         * xml-support.h: Fix common/ includes.
12490         * xml-support.c: Fix common/ includes.
12491         * x86-linux-nat.c: Fix common/ includes.
12492         * windows-nat.c: Fix common/ includes.
12493         * varobj.h: Fix common/ includes.
12494         * varobj.c: Fix common/ includes.
12495         * value.c: Fix common/ includes.
12496         * valops.c: Fix common/ includes.
12497         * utils.c: Fix common/ includes.
12498         * unittests/xml-utils-selftests.c: Fix common/ includes.
12499         * unittests/utils-selftests.c: Fix common/ includes.
12500         * unittests/unpack-selftests.c: Fix common/ includes.
12501         * unittests/tracepoint-selftests.c: Fix common/ includes.
12502         * unittests/style-selftests.c: Fix common/ includes.
12503         * unittests/string_view-selftests.c: Fix common/ includes.
12504         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12505         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12506         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12507         * unittests/rsp-low-selftests.c: Fix common/ includes.
12508         * unittests/parse-connection-spec-selftests.c: Fix common/
12509         includes.
12510         * unittests/optional-selftests.c: Fix common/ includes.
12511         * unittests/offset-type-selftests.c: Fix common/ includes.
12512         * unittests/observable-selftests.c: Fix common/ includes.
12513         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12514         * unittests/memrange-selftests.c: Fix common/ includes.
12515         * unittests/memory-map-selftests.c: Fix common/ includes.
12516         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12517         * unittests/function-view-selftests.c: Fix common/ includes.
12518         * unittests/environ-selftests.c: Fix common/ includes.
12519         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12520         * unittests/common-utils-selftests.c: Fix common/ includes.
12521         * unittests/cli-utils-selftests.c: Fix common/ includes.
12522         * unittests/array-view-selftests.c: Fix common/ includes.
12523         * ui-file.c: Fix common/ includes.
12524         * tui/tui-io.c: Fix common/ includes.
12525         * tracepoint.h: Fix common/ includes.
12526         * tracepoint.c: Fix common/ includes.
12527         * tracefile-tfile.c: Fix common/ includes.
12528         * top.h: Fix common/ includes.
12529         * top.c: Fix common/ includes.
12530         * thread.c: Fix common/ includes.
12531         * target/waitstatus.h: Fix common/ includes.
12532         * target/waitstatus.c: Fix common/ includes.
12533         * target.h: Fix common/ includes.
12534         * target.c: Fix common/ includes.
12535         * target-memory.c: Fix common/ includes.
12536         * target-descriptions.c: Fix common/ includes.
12537         * symtab.h: Fix common/ includes.
12538         * symfile.c: Fix common/ includes.
12539         * stap-probe.c: Fix common/ includes.
12540         * spu-linux-nat.c: Fix common/ includes.
12541         * sparc-nat.c: Fix common/ includes.
12542         * source.c: Fix common/ includes.
12543         * solib.c: Fix common/ includes.
12544         * solib-target.c: Fix common/ includes.
12545         * ser-unix.c: Fix common/ includes.
12546         * ser-tcp.c: Fix common/ includes.
12547         * ser-pipe.c: Fix common/ includes.
12548         * ser-base.c: Fix common/ includes.
12549         * selftest-arch.c: Fix common/ includes.
12550         * s12z-tdep.c: Fix common/ includes.
12551         * rust-exp.y: Fix common/ includes.
12552         * rs6000-aix-tdep.c: Fix common/ includes.
12553         * riscv-tdep.c: Fix common/ includes.
12554         * remote.c: Fix common/ includes.
12555         * remote-notif.h: Fix common/ includes.
12556         * remote-fileio.h: Fix common/ includes.
12557         * remote-fileio.c: Fix common/ includes.
12558         * regcache.h: Fix common/ includes.
12559         * regcache.c: Fix common/ includes.
12560         * record-btrace.c: Fix common/ includes.
12561         * python/python.c: Fix common/ includes.
12562         * python/py-type.c: Fix common/ includes.
12563         * python/py-inferior.c: Fix common/ includes.
12564         * progspace.h: Fix common/ includes.
12565         * producer.c: Fix common/ includes.
12566         * procfs.c: Fix common/ includes.
12567         * proc-api.c: Fix common/ includes.
12568         * printcmd.c: Fix common/ includes.
12569         * ppc-linux-nat.c: Fix common/ includes.
12570         * parser-defs.h: Fix common/ includes.
12571         * osdata.c: Fix common/ includes.
12572         * obsd-nat.c: Fix common/ includes.
12573         * nat/x86-linux.c: Fix common/ includes.
12574         * nat/x86-linux-dregs.c: Fix common/ includes.
12575         * nat/x86-dregs.h: Fix common/ includes.
12576         * nat/x86-dregs.c: Fix common/ includes.
12577         * nat/ppc-linux.c: Fix common/ includes.
12578         * nat/mips-linux-watch.h: Fix common/ includes.
12579         * nat/mips-linux-watch.c: Fix common/ includes.
12580         * nat/linux-waitpid.c: Fix common/ includes.
12581         * nat/linux-ptrace.h: Fix common/ includes.
12582         * nat/linux-ptrace.c: Fix common/ includes.
12583         * nat/linux-procfs.c: Fix common/ includes.
12584         * nat/linux-personality.c: Fix common/ includes.
12585         * nat/linux-osdata.c: Fix common/ includes.
12586         * nat/linux-namespaces.c: Fix common/ includes.
12587         * nat/linux-btrace.h: Fix common/ includes.
12588         * nat/linux-btrace.c: Fix common/ includes.
12589         * nat/fork-inferior.c: Fix common/ includes.
12590         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12591         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12592         * nat/aarch64-linux.c: Fix common/ includes.
12593         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12594         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12595         * namespace.h: Fix common/ includes.
12596         * mips-linux-tdep.c: Fix common/ includes.
12597         * minsyms.c: Fix common/ includes.
12598         * mi/mi-parse.h: Fix common/ includes.
12599         * mi/mi-main.c: Fix common/ includes.
12600         * mi/mi-cmd-env.c: Fix common/ includes.
12601         * memrange.h: Fix common/ includes.
12602         * memattr.c: Fix common/ includes.
12603         * maint.h: Fix common/ includes.
12604         * maint.c: Fix common/ includes.
12605         * main.c: Fix common/ includes.
12606         * machoread.c: Fix common/ includes.
12607         * location.c: Fix common/ includes.
12608         * linux-thread-db.c: Fix common/ includes.
12609         * linux-nat.c: Fix common/ includes.
12610         * linux-fork.c: Fix common/ includes.
12611         * inline-frame.c: Fix common/ includes.
12612         * infrun.c: Fix common/ includes.
12613         * inflow.c: Fix common/ includes.
12614         * inferior.h: Fix common/ includes.
12615         * inferior.c: Fix common/ includes.
12616         * infcmd.c: Fix common/ includes.
12617         * inf-ptrace.c: Fix common/ includes.
12618         * inf-child.c: Fix common/ includes.
12619         * ia64-linux-nat.c: Fix common/ includes.
12620         * i387-tdep.c: Fix common/ includes.
12621         * i386-tdep.c: Fix common/ includes.
12622         * i386-linux-tdep.c: Fix common/ includes.
12623         * i386-linux-nat.c: Fix common/ includes.
12624         * i386-go32-tdep.c: Fix common/ includes.
12625         * i386-fbsd-tdep.c: Fix common/ includes.
12626         * i386-fbsd-nat.c: Fix common/ includes.
12627         * guile/scm-type.c: Fix common/ includes.
12628         * guile/guile.c: Fix common/ includes.
12629         * go32-nat.c: Fix common/ includes.
12630         * gnu-nat.c: Fix common/ includes.
12631         * gdbthread.h: Fix common/ includes.
12632         * gdbarch-selftests.c: Fix common/ includes.
12633         * gdb_usleep.c: Fix common/ includes.
12634         * gdb_select.h: Fix common/ includes.
12635         * gdb_bfd.c: Fix common/ includes.
12636         * gcore.c: Fix common/ includes.
12637         * fork-child.c: Fix common/ includes.
12638         * findvar.c: Fix common/ includes.
12639         * fbsd-nat.c: Fix common/ includes.
12640         * event-top.c: Fix common/ includes.
12641         * event-loop.c: Fix common/ includes.
12642         * dwarf2read.c: Fix common/ includes.
12643         * dwarf2loc.c: Fix common/ includes.
12644         * dwarf2-frame.c: Fix common/ includes.
12645         * dwarf-index-cache.c: Fix common/ includes.
12646         * dtrace-probe.c: Fix common/ includes.
12647         * disasm-selftests.c: Fix common/ includes.
12648         * defs.h: Fix common/ includes.
12649         * csky-tdep.c: Fix common/ includes.
12650         * cp-valprint.c: Fix common/ includes.
12651         * cp-support.h: Fix common/ includes.
12652         * cp-support.c: Fix common/ includes.
12653         * corelow.c: Fix common/ includes.
12654         * completer.h: Fix common/ includes.
12655         * completer.c: Fix common/ includes.
12656         * compile/compile.c: Fix common/ includes.
12657         * compile/compile-loc2c.c: Fix common/ includes.
12658         * compile/compile-cplus-types.c: Fix common/ includes.
12659         * compile/compile-cplus-symbols.c: Fix common/ includes.
12660         * command.h: Fix common/ includes.
12661         * cli/cli-dump.c: Fix common/ includes.
12662         * cli/cli-cmds.c: Fix common/ includes.
12663         * charset.c: Fix common/ includes.
12664         * build-id.c: Fix common/ includes.
12665         * btrace.h: Fix common/ includes.
12666         * btrace.c: Fix common/ includes.
12667         * breakpoint.h: Fix common/ includes.
12668         * breakpoint.c: Fix common/ includes.
12669         * ax.h:
12670         (enum agent_op): Fix common/ includes.
12671         * ax-general.c (struct aop_map): Fix common/ includes.
12672         * ax-gdb.c: Fix common/ includes.
12673         * auxv.c: Fix common/ includes.
12674         * auto-load.c: Fix common/ includes.
12675         * arm-tdep.c: Fix common/ includes.
12676         * arch/riscv.c: Fix common/ includes.
12677         * arch/ppc-linux-common.c: Fix common/ includes.
12678         * arch/i386.c: Fix common/ includes.
12679         * arch/arm.c: Fix common/ includes.
12680         * arch/arm-linux.c: Fix common/ includes.
12681         * arch/arm-get-next-pcs.c: Fix common/ includes.
12682         * arch/amd64.c: Fix common/ includes.
12683         * arch/aarch64.c: Fix common/ includes.
12684         * arch/aarch64-insn.c: Fix common/ includes.
12685         * arch-utils.c: Fix common/ includes.
12686         * amd64-windows-tdep.c: Fix common/ includes.
12687         * amd64-tdep.c: Fix common/ includes.
12688         * amd64-sol2-tdep.c: Fix common/ includes.
12689         * amd64-obsd-tdep.c: Fix common/ includes.
12690         * amd64-nbsd-tdep.c: Fix common/ includes.
12691         * amd64-linux-tdep.c: Fix common/ includes.
12692         * amd64-linux-nat.c: Fix common/ includes.
12693         * amd64-fbsd-tdep.c: Fix common/ includes.
12694         * amd64-fbsd-nat.c: Fix common/ includes.
12695         * amd64-dicos-tdep.c: Fix common/ includes.
12696         * amd64-darwin-tdep.c: Fix common/ includes.
12697         * agent.c: Fix common/ includes.
12698         * ada-lang.h: Fix common/ includes.
12699         * ada-lang.c: Fix common/ includes.
12700         * aarch64-tdep.c: Fix common/ includes.
12701
12702 2019-01-25  Tom Tromey  <tom@tromey.com>
12703
12704         * common/create-version.sh: Use common/version.h.
12705
12706 2019-01-24  Pedro Alves  <palves@redhat.com>
12707
12708         * infrun.c (signal_stop, signal_print, signal_program)
12709         (signal_catch, signal_pass): Now arrays instead of pointers.
12710         (update_signals_program_target, do_target_resume)
12711         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12712         * linux-nat.c (linux_nat_target::pass_signals)
12713         (linux_nat_target::create_inferior, linux_nat_target::attach):
12714         Adjust.
12715         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12716         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12717         * procfs.c (procfs_target::pass_signals): Adjust.
12718         * record-full.c (record_full_target::resume): Adjust.
12719         * remote.c (remote_target::pass_signals)
12720         (remote_target::program_signals): Adjust.
12721         * target-debug.h (target_debug_print_signals): Now takes a
12722         gdb::array_view as parameter.  Adjust.
12723         * target.h (target_ops) <pass_signals, program_signals>: Replace
12724         pointer and length parameters with gdb::array_view.
12725         (target_pass_signals, target_program_signals): Likewise.
12726         * target-delegates.c: Regenerate.
12727
12728 2019-01-24  Pedro Alves  <palves@redhat.com>
12729
12730         * common/forward-scope-exit.h
12731         (forward_scope_exit::forward_scope_exit): Pass arguments to
12732         m_bind_function directly, instead of creating a std::bind and
12733         copying that.
12734
12735 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12736
12737         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12738         for static members.
12739         (pass_in_v_vfp_candidate): Likewise.
12740
12741 2019-01-23  Tom Tromey  <tom@tromey.com>
12742             Pedro Alves  <palves@redhat.com>
12743
12744         * regcache.c (class regcache_invalidator): Remove.
12745         (regcache::raw_write): Use make_scope_exit.
12746
12747 2019-01-23  Tom Tromey  <tom@tromey.com>
12748
12749         * ui-out.h (class ui_out_emit_type): Update comment.
12750
12751 2019-01-23  Tom Tromey  <tom@tromey.com>
12752
12753         * infrun.c (fetch_inferior_event): Update comment.
12754
12755 2019-01-23  Tom Tromey  <tom@tromey.com>
12756             Pedro Alves  <palves@redhat.com>
12757
12758         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12759         parameter.
12760         (fetch_inferior_event): Use SCOPE_EXIT.
12761
12762
12763 2019-01-23  Tom Tromey  <tom@tromey.com>
12764             Pedro Alves  <palves@redhat.com>
12765
12766         * infrun.c (disable_thread_events): Delete.
12767         (stop_all_threads): Use SCOPE_EXIT.
12768
12769 2019-01-23  Tom Tromey  <tom@tromey.com>
12770             Pedro Alves  <palves@redhat.com>
12771
12772         * symfile.c: Include forward-scope-exit.h.
12773         (clear_symtab_users_cleanup): Replace forward declaration with
12774         a FORWARD_SCOPE_EXIT.
12775         (syms_from_objfile_1): Use the forward_scope_exit and
12776         gdb::optional instead of cleanup_function.
12777         (reread_symbols): Use the forward_scope_exit instead of
12778         cleanup_function.
12779         (clear_symtab_users_cleanup): Remove function.
12780
12781 2019-01-23  Tom Tromey  <tom@tromey.com>
12782             Pedro Alves  <palves@redhat.com>
12783
12784         * linux-nat.c: Include scope-exit.h.
12785         (cleanup_target_stop): Remove.
12786         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12787         SCOPE_EXIT.
12788
12789 2019-01-23  Tom Tromey  <tom@tromey.com>
12790             Pedro Alves  <palves@redhat.com>
12791
12792         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12793         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12794
12795 2019-01-23  Tom Tromey  <tom@tromey.com>
12796             Andrew Burgess  <andrew.burgess@embecosm.com>
12797             Pedro Alves  <palves@redhat.com>
12798
12799         * infrun.c (fetch_inferior_event): Use scope_exit.
12800         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12801         * top.c (execute_command): Use scope_exit.
12802         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12803         * utils.c (do_bpstat_clear_actions_cleanup)
12804         (make_bpstat_clear_actions_cleanup): Remove.
12805
12806 2019-01-23  Tom Tromey  <tom@tromey.com>
12807             Pedro Alves  <palves@redhat.com>
12808
12809         * infrun.c: Include "common/scope-exit.h"
12810         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12811         (wait_for_inferior): Use SCOPE_EXIT.
12812         (fetch_inferior_event): Use scope_exit.
12813
12814 2019-01-23  Tom Tromey  <tom@tromey.com>
12815             Pedro Alves  <palves@redhat.com>
12816
12817         * breakpoint.c (create_breakpoint): Remove cleanup.
12818
12819 2019-01-23  Tom Tromey  <tom@tromey.com>
12820             Andrew Burgess  <andrew.burgess@embecosm.com>
12821             Pedro Alves  <palves@redhat.com>
12822
12823 2019-01-23  Pedro Alves  <palves@redhat.com>
12824
12825         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12826
12827 2019-01-23  Pedro Alves  <palves@redhat.com>
12828             Andrew Burgess  <andrew.burgess@embecosm.com>
12829
12830         * gdbthread.h: Include "common/forward-scope-exit.h".
12831         (scoped_finish_thread_state): Redefine custom class in terms of
12832         forward_scope_exit.
12833
12834 2019-01-23  Pedro Alves  <palves@redhat.com>
12835             Andrew Burgess  <andrew.burgess@embecosm.com>
12836
12837         * common/forward-scope-exit.h: New file.
12838
12839 2019-01-23  Pedro Alves  <palves@redhat.com>
12840             Andrew Burgess  <andrew.burgess@embecosm.com>
12841             Tom Tromey  <tom@tromey.com>
12842
12843         * common/scope-exit.h: New file.
12844
12845 2019-01-23  Pedro Alves  <palves@redhat.com>
12846
12847         * common/preprocessor.h (ESC): Rename to ...
12848         (ESC_PARENS): ... this.
12849         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12850         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12851
12852 2019-01-23  Tom Tromey  <tom@tromey.com>
12853
12854         * language.h (class scoped_switch_to_sym_language_if_auto):
12855         Initialize m_lang in both cases.
12856
12857 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12858
12859         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12860         with XCNEW.
12861
12862 2019-01-22  Tom Tromey  <tom@tromey.com>
12863
12864         * corelow.c: Do not include sys/file.h.
12865
12866 2019-01-22  Tom Tromey  <tom@tromey.com>
12867
12868         * tui/tui-wingeneral.h: Include gdb_curses.h.
12869
12870 2019-01-22  Tom Tromey  <tom@tromey.com>
12871
12872         * source-cache.h (class source_cache) <get_source_lines,
12873         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12874
12875 2019-01-22  Tom Tromey  <tom@tromey.com>
12876
12877         * remote-fileio.h (struct remote_target): Declare.
12878
12879 2019-01-22  Tom Tromey  <tom@tromey.com>
12880
12881         * python/py-arch.c: Do not include py-ref.h.
12882         * python/py-bpevent.c: Do not include py-ref.h.
12883         * python/py-cmd.c: Do not include py-ref.h.
12884         * python/py-continueevent.c: Do not include py-ref.h.
12885         * python/py-event.h: Do not include py-ref.h.
12886         * python/py-evtregistry.c: Do not include py-ref.h.
12887         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12888         * python/py-frame.c: Do not include py-ref.h.
12889         * python/py-framefilter.c: Do not include py-ref.h.
12890         * python/py-function.c: Do not include py-ref.h.
12891         * python/py-infevents.c: Do not include py-ref.h.
12892         * python/py-linetable.c: Do not include py-ref.h.
12893         * python/py-objfile.c: Do not include py-ref.h.
12894         * python/py-param.c: Do not include py-ref.h.
12895         * python/py-prettyprint.c: Do not include py-ref.h.
12896         * python/py-progspace.c: Do not include py-ref.h.
12897         * python/py-symbol.c: Do not include py-ref.h.
12898         * python/py-symtab.c: Do not include py-ref.h.
12899         * python/py-type.c: Do not include py-ref.h.
12900         * python/py-unwind.c: Do not include py-ref.h.
12901         * python/py-utils.c: Do not include py-ref.h.
12902         * python/py-value.c: Do not include py-ref.h.
12903         * python/py-varobj.c: Do not include py-ref.h.
12904         * python/py-xmethods.c: Do not include py-ref.h.
12905         * python/python.c: Do not include py-ref.h.
12906         * varobj.c: Do not include py-ref.h.
12907
12908 2019-01-22  Tom Tromey  <tom@tromey.com>
12909
12910         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12911         keyword for bcache.
12912
12913 2019-01-22  Tom Tromey  <tom@tromey.com>
12914
12915         * compile/compile-cplus-types.c: Remove a comment by #include.
12916
12917 2019-01-22  Tom Tromey  <tom@tromey.com>
12918
12919         * compile/gcc-c-plugin.h: Include compile-internal.h.
12920
12921 2019-01-22  Tom Tromey  <tom@tromey.com>
12922
12923         * stabsread.c (EXTERN): Do not define.
12924         (symnum, next_symbol_text_func, processing_gcc_compilation)
12925         (within_function, global_sym_chain, global_stabs)
12926         (previous_stab_code, this_object_header_files)
12927         (n_this_object_header_files)
12928         (n_allocated_this_object_header_files): Define.
12929         * stabsread.h (EXTERN): Never define.  Use "extern".
12930
12931 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12932
12933         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12934         history_value.
12935
12936 2019-01-21  Tom Tromey  <tom@tromey.com>
12937
12938         * ui-out.c: Fix includes.
12939         * tui/tui-source.c: Fix includes.
12940         * target.c: Fix includes.
12941         * remote.c: Fix includes.
12942         * regcache.c: Fix includes.
12943         * python/py-block.c: Fix includes.
12944         * printcmd.c: Fix includes.
12945         * or1k-tdep.c: Fix includes.
12946         * mi/mi-main.c: Fix includes.
12947         * m32r-tdep.c: Fix includes.
12948         * csky-tdep.c: Fix includes.
12949         * compile/compile-cplus-types.c: Fix includes.
12950         * cli/cli-interp.c: Fix includes.
12951
12952 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12953
12954         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12955         for padding.
12956
12957 2019-01-16  Tom Tromey  <tom@tromey.com>
12958
12959         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12960         earlier.
12961         (struct objfile) <msymbols_range>: Move from top level.
12962         <msymbols>: New method.
12963         (class objfile_msymbols): Remove.
12964         * symtab.c (default_collect_symbol_completion_matches_break_on):
12965         Update.
12966         * symmisc.c (dump_msymbols): Update.
12967         * stabsread.c (scan_file_globals): Update.
12968         * objc-lang.c (info_selectors_command, info_classes_command)
12969         (find_methods): Update.
12970         * minsyms.c (find_solib_trampoline_target): Update.
12971         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12972         * coffread.c (coff_symfile_read): Update.
12973         * ada-lang.c (ada_lookup_simple_minsym)
12974         (ada_collect_symbol_completion_matches): Update.
12975
12976 2019-01-16  Tom Tromey  <tom@tromey.com>
12977
12978         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12979         type.  Remove no-argument constructor.
12980         <iterator::operator++>: Simplify.
12981         <begin>: Update.
12982         <end>: Use minimal_symbol_count.
12983
12984 2019-01-16  Tom Tromey  <tom@tromey.com>
12985
12986         * objfiles.h (struct objfile) <psymtabs>: New method.
12987         (class objfile_psymtabs): Remove.
12988         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12989         typedef.
12990         <range>: New method.
12991         (require_partial_symbols): Change return type.
12992         * psymtab.c (require_partial_symbols)
12993         (psym_expand_symtabs_matching): Update.
12994         * mdebugread.c (parse_partial_symbols): Update.
12995         * dbxread.c (dbx_end_psymtab): Update.
12996
12997 2019-01-15  Tom Tromey  <tom@tromey.com>
12998
12999         * symtab.c (lookup_objfile_from_block)
13000         (lookup_symbol_in_objfile_symtabs)
13001         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13002         (find_line_symtab, info_sources_command)
13003         (default_collect_symbol_completion_matches_break_on)
13004         (make_source_files_completion_list): Update.
13005         * symmisc.c (print_objfile_statistics, dump_objfile)
13006         (maintenance_print_symbols, maintenance_info_symtabs)
13007         (maintenance_check_symtabs, maintenance_info_line_tables):
13008         Update.
13009         * source.c (select_source_symtab)
13010         (forget_cached_source_info_for_objfile): Update.
13011         * objfiles.h (class objfile_compunits): Remove.
13012         (struct objfile) <compunits_range>: New typedef.
13013         (compunits): New method.
13014         * objfiles.c (objfile_relocate1): Update.
13015         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13016         * maint.c (count_symtabs_and_blocks): Update.
13017         * linespec.c (iterate_over_all_matching_symtabs): Update.
13018         * cp-support.c (add_symbol_overload_list_qualified): Update.
13019         * coffread.c (coff_symtab_read): Update.
13020         * ada-lang.c (add_nonlocal_symbols)
13021         (ada_collect_symbol_completion_matches)
13022         (ada_add_global_exceptions): Update.
13023
13024 2019-01-15  Tom Tromey  <tom@tromey.com>
13025
13026         * progspace.h (program_space) <objfiles_safe_range>: New
13027         typedef.
13028         <objfiles_safe>: New method.
13029         * objfiles.h (class all_objfiles_safe): Remove.
13030         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13031         * jit.c (jit_inferior_exit_hook): Update.
13032
13033 2019-01-17  Tom Tromey  <tom@tromey.com>
13034
13035         * progspace.h (program_space) <objfiles_range>: New typedef.
13036         <objfiles>: New method.
13037         <objfiles_head>: Rename from objfiles.
13038         (object_files): Update.
13039         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13040         * guile/scm-pretty-print.c
13041         (ppscm_find_pretty_printer_from_objfiles): Update.
13042         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13043         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13044         Update.
13045         * python/py-progspace.c (pspy_get_objfiles): Update.
13046         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13047         Update.
13048         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13049         (objfpy_lookup_objfile_by_build_id): Update.
13050         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13051         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13052         Update.
13053         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13054         (expand_symtab_containing_pc, lookup_objfile_from_block)
13055         (lookup_static_symbol, basic_lookup_transparent_type)
13056         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13057         (find_line_symtab, info_sources_command)
13058         (default_collect_symbol_completion_matches_break_on)
13059         (make_source_files_completion_list, find_main_name): Update.
13060         * symmisc.c (print_symbol_bcache_statistics)
13061         (print_objfile_statistics, maintenance_print_symbols)
13062         (maintenance_print_msymbols, maintenance_print_objfiles)
13063         (maintenance_info_symtabs, maintenance_check_symtabs)
13064         (maintenance_expand_symtabs, maintenance_info_line_tables):
13065         Update.
13066         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13067         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13068         (map_overlay_command, unmap_overlay_command)
13069         (simple_overlay_update, expand_symtabs_matching)
13070         (map_symbol_filenames): Update.
13071         * symfile-debug.c (set_debug_symfile): Update.
13072         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13073         Update.
13074         * source.c (select_source_symtab, forget_cached_source_info):
13075         Update.
13076         * solib.c (solib_read_symbols): Update.
13077         * solib-spu.c (append_ocl_sos): Update.
13078         * psymtab.c (maintenance_print_psymbols)
13079         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13080         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13081         * printcmd.c (info_symbol_command): Update.
13082         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13083         Update.
13084         * objfiles.h (class all_objfiles): Remove.
13085         * objfiles.c (have_partial_symbols, have_full_symbols)
13086         (have_minimal_symbols, qsort_cmp, update_section_map)
13087         (shared_objfile_contains_address_p)
13088         (default_iterate_over_objfiles_in_search_order): Update.
13089         * objc-lang.c (info_selectors_command, info_classes_command)
13090         (find_methods): Update.
13091         * minsyms.c (find_solib_trampoline_target): Update.
13092         * maint.c (maintenance_info_sections)
13093         (maintenance_translate_address, count_symtabs_and_blocks):
13094         Update.
13095         * main.c (captured_main_1): Update.
13096         * linux-thread-db.c (try_thread_db_load_from_pdir)
13097         (has_libpthread): Update.
13098         * linespec.c (iterate_over_all_matching_symtabs)
13099         (search_minsyms_for_name): Update.
13100         * jit.c (jit_find_objf_with_entry_addr): Update.
13101         * hppa-tdep.c (find_unwind_entry)
13102         (hppa_lookup_stub_minimal_symbol): Update.
13103         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13104         Update.
13105         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13106         (elf_gnu_ifunc_resolve_by_got): Update.
13107         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13108         * dwarf-index-write.c (save_gdb_index_command): Update.
13109         * cp-support.c (add_symbol_overload_list_qualified): Update.
13110         * breakpoint.c (create_overlay_event_breakpoint)
13111         (create_longjmp_master_breakpoint)
13112         (create_std_terminate_master_breakpoint)
13113         (create_exception_master_breakpoint): Update.
13114         * blockframe.c (find_pc_partial_function): Update.
13115         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13116         (ada_collect_symbol_completion_matches)
13117         (ada_add_global_exceptions): Update.
13118
13119 2019-01-17  Tom Tromey  <tom@tromey.com>
13120
13121         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13122         declare VEC.
13123         (solib_target_parse_libraries): Change return type.
13124         (library_list_start_segment, library_list_start_section)
13125         (library_list_end_library, library_list_start_library); Update.
13126         (solib_target_free_library_list): Remove.
13127         (solib_target_parse_libraries): Remove cleanup.  Change return
13128         type.
13129         (solib_target_current_sos): Update.
13130
13131 2019-01-17  Tom Tromey  <tromey@bapiya>
13132
13133         * valprint.c: Replace "the the" with "the".
13134         * symtab.c: Replace "the the" with "the".
13135         * solib.c: Replace "the the" with "the".
13136         * solib-dsbt.c: Replace "the the" with "the".
13137         * linespec.c: Replace "the the" with "the".
13138         * dwarf2loc.h: Replace "the the" with "the".
13139         * amd64-windows-tdep.c: Replace "the the" with "the".
13140         * aarch64-tdep.c: Replace "the the" with "the".
13141
13142 2019-01-16  Keith Seitz  <keiths@redhat.com>
13143
13144         PR gdb/23773
13145         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13146         <builder>: Rename to ..
13147         <m_builder>: ... this and make private.
13148         (dwarf2_cu::get_builder): New method.  Change all users of
13149         `builder' to use this method.
13150         (dwarf2_start_symtab): Move to ...
13151         (dwarf2_cu::start_symtab): ... here.  Update all callers
13152         (setup_type_unit_groups): Move to ...
13153         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13154         callers.
13155         (dwarf2_cu::reset_builder): New method.
13156         (process_full_compunit, process_full_type_unit): Use
13157         dwarf2_cu::reset_builder.
13158         (follow_die_offset): Record the ancestor CU if it is different
13159         from the followed DIE's CU.
13160         (follow_die_sig_1): Likewise.
13161
13162 2019-01-15  Tom Tromey  <tom@tromey.com>
13163
13164         * remote.c (class remote_state) <buf>: Now a char_vector.
13165         <buf_size>: Remove.
13166         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13167         parameter.
13168         (remote_target::getpkt_or_notif_sane_1)
13169         (remote_target::getpkt_sane)
13170         (remote_target::getpkt_or_notif_sane): Likewise.
13171         (class remote_target) <putpkt>: New overload.
13172         (remote_target::read_frame): Change type of "buf_p".  Remove
13173         sizeof_p parameter.
13174         (packet_ok): New overload.
13175         (packet_check_result): New overload.
13176         Update all uses.
13177
13178 2019-01-14  Tom Tromey  <tom@tromey.com>
13179
13180         * remote-notif.c (handle_notification, remote_notif_ack)
13181         (remote_notif_parse): Make "buf" const.
13182         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13183         const.
13184         (remote_notif_parse, remote_notif_ack, handle_notification):
13185         Likewise.
13186         * remote.c (remote_notif_stop_parse): Make "buf" const.
13187         (remote_target::remote_parse_stop_reply): Make "buf" const.
13188         (remote_notif_stop_ack): Make "buf" const.
13189
13190 2019-01-14  Tom Tromey  <tom@tromey.com>
13191
13192         * remote.c (remote_console_output): Make parameter const.
13193
13194 2019-01-14  Tom Tromey  <tom@tromey.com>
13195
13196         * target-debug.h (target_debug_print_signals): Constify.
13197         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13198         * procfs.c (procfs_target::pass_signals): Update.
13199         * linux-nat.c (linux_nat_target::pass_signals): Update.
13200         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13201         * target-delegates.c: Rebuild.
13202         * remote.c (remote_target::program_signals): Update.
13203         (remote_target::pass_signals): Update.
13204         * target.c (target_pass_signals): Constify argument.
13205         (target_program_signals): Likewise.
13206         * target.h (struct target_ops) <pass_signals, program_signals>:
13207         Constify argument.
13208         (target_pass_signals, target_program_signals): Constify argument.
13209
13210 2019-01-14  Tom Tromey  <tom@tromey.com>
13211
13212         PR tui/28819:
13213         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13214
13215 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13216
13217         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13218         field.
13219         * rs6000-tdep.c: Include reggroups.h.
13220         (IS_V_ALIAS_PSEUDOREG): Define.
13221         (rs6000_register_name): Return names for the "vX" aliases.
13222         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13223         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13224         aliases.  Call default_register_reggroup_p for all other
13225         pseudo-registers.
13226         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13227         New functions.
13228         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13229         Handle "vX" aliases.
13230         (v_alias_pseudo_register_collect): New function.
13231         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13232         (rs6000_gdbarch_init): Initialize "vX" aliases as
13233         pseudo-registers.  Restore registration of
13234         rs6000_pseudo_register_reggroup_p with
13235         set_tdesc_pseudo_register_reggroup_p.
13236
13237 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13238
13239         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13240         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13241         set_gdbarch_num_pseudo_regs.
13242
13243 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13244
13245         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13246         Remove arg prefixname, add do_set and do_show.
13247         Add member functions set_list and show_list.
13248         * cli/cli-style.c (class cli_style_option): Update accordingly.
13249         (style_set_list): Move to file scope.
13250         (style_show_list): Likewise.
13251         (set_style): Call help_list.
13252         (show_style): Call cmd_show_list.
13253         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13254         Update to use the new macro.
13255
13256 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13257
13258         * ada-lang.c (_initialize_ada_language): Expand the help text
13259         for the "catch exception" command.
13260
13261 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13262
13263         * symtab.c (matching_obj_sections): Initialize obj,
13264         declare it closer to its usage.
13265
13266 2019-01-10  Tom Tromey  <tom@tromey.com>
13267
13268         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13269         (basic_inf_threads_range): Remove.
13270         (inf_threads_range, inf_non_exited_threads_range)
13271         (safe_inf_threads_range): Use next_adapter.
13272
13273 2019-01-10  Keith Seitz  <keiths@redhat.com>
13274
13275         PR gdb/23712
13276         PR symtab/23010
13277         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13278         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13279
13280 2019-01-10  Keith Seitz  <keiths@redhat.com>
13281
13282         PR gdb/23712
13283         PR symtab/23010
13284         * dictionary.c (pending_to_vector): Remove.
13285         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13286         Remove _1 suffix, replacing functions of the same name.  Update
13287         all callers.
13288         (dict_create_hashed, dict_create_hashed_expandable)
13289         (dict_create_linear, dict_create_linear_expandable, dict_free)
13290         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13291         Make functions static.
13292
13293 2019-01-10  Keith Seitz  <keiths@redhat.com>
13294
13295         PR gdb/23712
13296         PR symtab/23010
13297         * dictionary.h (struct dictionary): Replace declaration with
13298         multidictionary.
13299         (dict_create_hashed, dict_create_hashed_expandable)
13300         (dict_create_linear, dict_create_linear_expandable)
13301         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13302         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13303         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13304         taking multidictionary argument.
13305         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13306         * block.h (struct block) <dict>: Change to multidictionary
13307         and rename `multidict'.
13308         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13309         symmisc.c: Update all dictionary references to multidictionary.
13310
13311 2019-01-10  Keith Seitz  <keiths@redhat.com>
13312
13313         PR gdb/23712
13314         PR symtab/23010
13315         * dictionary.c: Include unordered_map.
13316         (pending_to_vector): New function.
13317         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13318         Rewrite the non-"_1" functions to take vector instead
13319         of linked list.
13320         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13321         "new" _1 versions of the same name.
13322         (multidictionary): Define.
13323         (std::hash<enum language): New definition.
13324         (collate_pending_symbols_by_language, mdict_create_hashed)
13325         (mdict_create_hashed_expandable, mdict_create_linear)
13326         (mdict_create_linear_expandable, mdict_free)
13327         (find_language_dictionary, create_new_language_dictionary)
13328         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13329         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13330         (mdict_size, mdict_empty): New functions.
13331         * dictionary.h (mdict_iterator): Define.
13332
13333 2019-01-10  Pedro Alves  <palves@redhat.com>
13334
13335         * breakpoint.c (read_uploaded_action)
13336         (create_tracepoint_from_upload): Adjust to use
13337         gdb::unique_xmalloc_ptr.
13338         * ctf.c (ctf_write_uploaded_tp):
13339         (SET_ARRAY_FIELD): Use emplace_back.
13340         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13341         * tracefile-tfile.c (tfile_write_uploaded_tp):
13342         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13343         gdb::unique_xmalloc_ptr.
13344         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13345         at_string, cond_string, cmd_strings>: Replace char pointers
13346         with gdb::unique_xmalloc_ptr.
13347
13348 2019-01-10  Pedro Alves  <palves@redhat.com>
13349
13350         * solib-target.c (library_list_start_library): Don't xstrdup name.
13351
13352 2019-01-10  Pedro Alves  <palves@redhat.com>
13353
13354         * mdebugread.c (parse_partial_symbols): Use
13355         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13356
13357 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13358
13359         * linux-fork.c (scoped_switch_fork_info)
13360         <~scoped_switch_fork_info>: Fix incorrect variable name.
13361
13362 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13363
13364         * linux-fork.c (scoped_switch_fork_info)
13365         <scoped_switch_fork_info>: Make explicit.
13366         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13367
13368 2019-01-10  Tom Tromey  <tom@tromey.com>
13369
13370         * objfiles.h (objfile::reset_psymtabs): Update.
13371         * objfiles.c (objfile::objfile): Update.
13372         * psymtab.h (psymtab_storage::obstack): Update.
13373         (psymtab_storage::m_obstack): Use gdb::optional.
13374         (class psymtab_storage): Update comment.  Remove objfile
13375         parameter.
13376         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13377
13378 2019-01-10  Tom Tromey  <tom@tromey.com>
13379
13380         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13381         <free_psymtabs>: Now private.
13382         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13383         (allocate_psymtab): Use new method.
13384
13385 2019-01-10  Tom Tromey  <tom@tromey.com>
13386
13387         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13388         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13389         * mdebugread.c (parse_partial_symbols): Use
13390         allocate_dependencies.
13391         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13392         allocate_dependencies.
13393         (process_psymtab_comp_unit_reader)
13394         (build_type_psymtab_dependencies): Likewise.
13395         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13396
13397 2019-01-10  Tom Tromey  <tom@tromey.com>
13398
13399         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13400         PSYMBOL_SET_LANGUAGE.
13401         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13402
13403 2019-01-10  Tom Tromey  <tom@tromey.com>
13404
13405         * psymtab.h (psymtab_storage::obstack): New method.
13406         <m_obstack>: Rename from obstack; now private.
13407         * psymtab.c (psymtab_storage): Update.
13408         * dwarf2read.c (create_addrmap_from_index)
13409         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13410         Update.
13411
13412 2019-01-10  Tom Tromey  <tom@tromey.com>
13413
13414         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13415         * objfiles.h (objfile::reset_psymtabs): New method.
13416
13417 2019-01-10  Tom Tromey  <tom@tromey.com>
13418
13419         * symmisc.c (print_symbol_bcache_statistics): Update.
13420         (print_objfile_statistics): Update.
13421         * symfile.c (reread_symbols): Update.
13422         * psymtab.h (class psymtab_storage): New.
13423         * psymtab.c (psymtab_storage): New constructor.
13424         (~psymtab_storage): New destructor.
13425         (require_partial_symbols): Update.
13426         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13427         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13428         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13429         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13430         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13431         (start_psymtab_common, end_psymtab_common)
13432         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13433         (allocate_psymtab): Update.
13434         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13435         Update.
13436         (dump_psymtab_addrmap, maintenance_print_psymbols)
13437         (maintenance_check_psymtabs): Update.
13438         (class objfile_psymtabs): Move to objfiles.h.
13439         * psympriv.h (discard_psymtab): Now inline.
13440         (psymtab_discarder::psymtab_discarder): Update.
13441         (psymtab_discarder::~psymtab_discarder): Update.
13442         (ALL_OBJFILE_PSYMTABS): Rewrite.
13443         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13444         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13445         Remove fields.
13446         <partial_symtabs>: New field.
13447         (class objfile_psymtabs): Move from psymtab.h.  Update.
13448         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13449         psymbol_cache.
13450         (objfile::~objfile): Don't destroy psymbol_cache.
13451         * mdebugread.c (parse_partial_symbols): Update.
13452         * dwarf2read.c (create_addrmap_from_index)
13453         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13454         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13455         (add_partial_subprogram, dwarf2_ranges_read): Update.
13456         * dwarf-index-write.c (write_address_map)
13457         (write_one_signatured_type, recursively_write_psymbols)
13458         (class debug_names, class debug_names, write_psymtabs_to_index):
13459         Update.
13460
13461 2019-01-10  Tom Tromey  <tom@tromey.com>
13462
13463         * symtab.h (SYMBOL_SET_NAMES): Update.
13464         (symbol_set_names): Update.
13465         (MSYMBOL_SET_NAMES): Update.
13466         * symtab.c (symbol_set_names): Change argument to be an
13467         objfile_per_bfd_storage.
13468         * psymtab.c (add_psymbol_to_bcache): Update.
13469         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13470
13471 2019-01-10  Tom Tromey  <tom@tromey.com>
13472
13473         * symtab.c (create_demangled_names_hash): Change argument to be an
13474         objfile_per_bfd_storage.
13475         (symbol_set_names): Update.
13476
13477 2019-01-10  Tom Tromey  <tom@tromey.com>
13478
13479         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13480         init_psymbol_list.
13481         * psymtab.c (init_psymbol_list): Do nothing if already called.
13482         * psympriv.h (init_psymbol_list): Add comment.
13483         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13484         init_psymbol_list.
13485         * dbxread.c (dbx_symfile_read): Unconditionally call
13486         init_psymbol_list.
13487
13488 2019-01-10  Tom Tromey  <tom@tromey.com>
13489
13490         * xcoffread.c (scan_xcoff_symtab): Update.
13491         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13492         "where".
13493         * mdebugread.c (parse_partial_symbols)
13494         (handle_psymbol_enumerators): Update.
13495         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13496         * dbxread.c (read_dbx_symtab): Update.
13497         * psympriv.h (psymbol_placement): New enum.
13498         (add_psymbol_to_list): Update.
13499
13500 2019-01-10  Tom Tromey  <tom@tromey.com>
13501
13502         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13503         static_psymbols parameters.
13504         (scan_xcoff_symtab): Update.
13505         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13506         static_psymbols parameters.
13507         * psympriv.h (start_psymtab_common): Update.
13508         * mdebugread.c (parse_partial_symbols): Update.
13509         * dwarf2read.c (create_partial_symtab): Update.
13510         * dbxread.c (read_dbx_symtab): Update.
13511         (start_psymtab): Remove global_psymbols and static_psymbols
13512         parameters.
13513
13514 2019-01-10  Tom Tromey  <tom@tromey.com>
13515
13516         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13517         * psymtab.c (allocate_psymtab): Add comment.
13518         * psympriv.h (allocate_psymtab): Add comment.
13519         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13520         initializations.
13521         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13522
13523 2019-01-10  Tom Tromey  <tom@tromey.com>
13524
13525         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13526         Don't declare.
13527         * mipsread.c: Include mdebugread.h.
13528         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13529         Declare.
13530         * elfread.c: Include mdebugread.h.
13531
13532 2019-01-09  Tom Tromey  <tom@tromey.com>
13533
13534         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13535         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13536         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13537         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13538         (psym_lookup_symbol, psym_find_last_source_symtab)
13539         (psym_forget_cached_source_info, psym_print_stats)
13540         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13541         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13542         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13543         (psym_find_compunit_symtab_by_address)
13544         (maintenance_print_psymbols, maintenance_info_psymtabs)
13545         (maintenance_check_psymtabs): Use ranged for.
13546         * psymtab.h (class objfile_psymtabs): New.
13547         (require_partial_symbols): Return objfile_psymtabs.
13548         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13549
13550 2019-01-09  Tom Tromey  <tom@tromey.com>
13551
13552         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13553         (find_pc_mapped_section, list_overlays_command)
13554         (map_overlay_command, unmap_overlay_command)
13555         (simple_overlay_update): Use all_objfiles.
13556         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13557         * printcmd.c (info_symbol_command): Use all_objfiles.
13558         * objfiles.h (ALL_OBJSECTIONS): Remove.
13559         * maint.c (maintenance_translate_address): Use all_objfiles.
13560         * gcore.c (gcore_create_callback): Use all_objfiles.
13561         (objfile_find_memory_regions): Likewise.
13562
13563 2019-01-09  Tom Tromey  <tom@tromey.com>
13564
13565         * symtab.c (find_line_symtab, info_sources_command)
13566         (make_source_files_completion_list): Use objfile_compunits.
13567         * source.c (select_source_symtab): Use objfile_compunits.
13568         * objfiles.h (struct objfile): Update comment.
13569         (ALL_OBJFILES): Remove.
13570         (ALL_FILETABS): Remove.
13571         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13572         objfile_compunits.
13573
13574 2019-01-09  Tom Tromey  <tom@tromey.com>
13575
13576         * symmisc.c (print_objfile_statistics, dump_objfile)
13577         (maintenance_print_symbols): Use compunit_filetabs.
13578         * source.c (forget_cached_source_info_for_objfile): Use
13579         compunit_filetabs.
13580         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13581         (ALL_FILETABS): Use compunit_filetabs.
13582         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13583         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13584
13585 2019-01-09  Tom Tromey  <tom@tromey.com>
13586
13587         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13588         (compunit_filetabs): New.
13589         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13590         compunit_filetabs.
13591         (info_sources_command, make_source_files_completion_list): Remove
13592         declaration.
13593         * symmisc.c (print_objfile_statistics, dump_objfile)
13594         (maintenance_print_symbols): Remove declaration.
13595         (maintenance_info_symtabs): Use compunit_filetabs.
13596         (maintenance_info_line_tables): Likewise.
13597         * source.c (select_source_symtab): Change local variable name.
13598         (forget_cached_source_info_for_objfile): Remove declaration.
13599         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13600         * objfiles.c (objfile_relocate1): Remove declaration.
13601         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13602         declaration.
13603         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13604         * coffread.c (coff_symtab_read): Remove declaration.
13605         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13606         compunit_filetabs.
13607
13608 2019-01-09  Tom Tromey  <tom@tromey.com>
13609
13610         * symtab.c (lookup_objfile_from_block)
13611         (find_pc_sect_compunit_symtab, search_symbols)
13612         (default_collect_symbol_completion_matches_break_on): Use
13613         objfile_compunits.
13614         * objfiles.h (ALL_COMPUNITS): Remove.
13615         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13616         * cp-support.c (add_symbol_overload_list_qualified): Use
13617         objfile_compunits.
13618         * ada-lang.c (ada_collect_symbol_completion_matches)
13619         (ada_add_global_exceptions): Use objfile_compunits.
13620
13621 2019-01-09  Tom Tromey  <tom@tromey.com>
13622
13623         * source.c (select_source_symtab)
13624         (forget_cached_source_info_for_objfile): Remove declaration.
13625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13626         declaration.
13627         * maint.c (count_symtabs_and_blocks): Remove declaration.
13628         * cp-support.c (add_symbol_overload_list_qualified): Remove
13629         declaration.
13630         * coffread.c (coff_symtab_read): Remove declaration.
13631         * symtab.c (lookup_symbol_in_objfile_symtabs)
13632         (basic_lookup_transparent_type_1): Use objfile_compunits.
13633         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13634         (info_sources_command, search_symbols)
13635         (default_collect_symbol_completion_matches_break_on)
13636         (make_source_files_completion_list): Remove declaration.
13637         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13638         (ada_collect_symbol_completion_matches)
13639         (ada_add_global_exceptions): Remove declaration.
13640         * linespec.c (iterate_over_all_matching_symtabs): Use
13641         objfile_compunits.
13642         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13643         (class objfile_compunits): New.
13644         (ALL_COMPUNITS): Use objfile_compunits.
13645         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13646         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13647         objfile_compunits.
13648         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13649
13650 2019-01-09  Tom Tromey  <tom@tromey.com>
13651
13652         * symtab.c (search_symbols)
13653         (default_collect_symbol_completion_matches_break_on): Use
13654         objfile_msymbols.
13655         * ada-lang.c (ada_lookup_simple_minsym)
13656         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13657         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13658         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13659         objfile_msymbols.
13660         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13661         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13662         * objc-lang.c (find_methods): Use objfile_msymbols.
13663         (info_selectors_command, info_classes_command): Likewise.
13664         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13665         * objfiles.h (class objfile_msymbols): New.
13666         (ALL_OBJFILE_MSYMBOLS): Remove.
13667         (ALL_MSYMBOLS): Remove.
13668
13669 2019-01-09  Tom Tromey  <tom@tromey.com>
13670
13671         * common/next-iterator.h (next_adapter): Add Iterator template
13672         parameter.
13673         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13674         (class all_objfiles_safe): New.
13675         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13676         * objfiles.c (put_objfile_before): Update comment.
13677         (add_separate_debug_objfile): Likewise.
13678         (free_all_objfiles): Use all_objfiles_safe.
13679         (objfile_purge_solibs): Likewise.
13680
13681 2019-01-09  Tom Tromey  <tom@tromey.com>
13682
13683         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13684         (expand_symtab_containing_pc, lookup_static_symbol)
13685         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13686         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13687         all_objfiles.
13688         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13689         * breakpoint.c (create_overlay_event_breakpoint)
13690         (create_longjmp_master_breakpoint)
13691         (create_std_terminate_master_breakpoint)
13692         (create_exception_master_breakpoint): Use all_objfiles.
13693         * linux-thread-db.c (try_thread_db_load_from_pdir)
13694         (has_libpthread): Use all_objfiles.
13695         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13696         * linespec.c (iterate_over_all_matching_symtabs)
13697         (search_minsyms_for_name): Use all_objfiles.
13698         * maint.c (maintenance_info_sections): Use all_objfiles.
13699         * main.c (captured_main_1): Use all_objfiles.
13700         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13701         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13702         * guile/scm-pretty-print.c
13703         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13704         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13705         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13706         (maintenance_print_msymbols): Use all_objfiles.
13707         * source.c (select_source_symtab): Use all_objfiles.
13708         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13709         * symfile.c (remove_symbol_file_command)
13710         (expand_symtabs_matching, map_symbol_filenames): Use
13711         all_objfiles.
13712         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13713         all_objfiles.
13714         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13715         * objc-lang.c (find_methods): Use all_objfiles.
13716         * objfiles.c (have_partial_symbols, have_full_symbols)
13717         (have_minimal_symbols, qsort_cmp)
13718         (default_iterate_over_objfiles_in_search_order): Use
13719         all_objfiles.
13720         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13721         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13722         (maintenance_check_psymtabs): Use all_objfiles.
13723         (ALL_PSYMTABS): Remove.
13724         * compile/compile-object-run.c (do_module_cleanup): Use
13725         all_objfiles.
13726         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13727         * cp-support.c (add_symbol_overload_list_qualified): Use
13728         all_objfiles.
13729         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13730         Use all_objfiles.
13731         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13732         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13733         all_objfiles.
13734         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13735         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13736         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13737         Uses all_objfiles.
13738         * solib.c (solib_read_symbols): Use all_objfiles
13739
13740 2019-01-09  Tom Tromey  <tom@tromey.com>
13741
13742         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13743         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13744         all_objfiles.
13745         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13746         * symmisc.c (print_symbol_bcache_statistics)
13747         (print_objfile_statistics, maintenance_print_objfiles)
13748         (maintenance_info_symtabs, maintenance_check_symtabs)
13749         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13750         all_objfiles.
13751         * source.c (forget_cached_source_info): Use all_objfiles.
13752         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13753         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13754         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13755         * objfiles.c (update_section_map): Use all_objfiles.
13756         (shared_objfile_contains_address_p): Likewise.
13757         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13758         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13759
13760 2019-01-09  Tom Tromey  <tom@tromey.com>
13761
13762         * common/next-iterator.h: New file.
13763         * objfiles.h (class all_objfiles): New.
13764         (struct objfile_iterator): New.
13765
13766 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13767
13768         * NEWS: Move the description of the changed "frame", "select-frame",
13769          and "info frame" commands to the Changed commands section.
13770
13771 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13772
13773         * gdbtypes.c (check_stub_method_group): Remove handling of old
13774         mangling schemes.
13775         * linespec.c (find_methods): Likewise.
13776         * stabsread.c (read_member_functions): Likewise.
13777         * valops.c (search_struct_method): Likewise.
13778         (value_struct_elt_for_reference): Likewise.
13779         * NEWS: Mention this change.
13780
13781 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13782
13783         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13784         print_source_lines.
13785         * source.c (print_source_lines_base): Update line number check.
13786         (print_source_lines): New function.
13787         (source_lines_range::source_lines_range): New function.
13788         * source.h (class source_lines_range): New class.
13789         (print_source_lines): New declaration.
13790
13791 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13792
13793         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13794
13795 2019-01-08  Tom Tromey  <tom@tromey.com>
13796             Simon Marchi  <simon.marchi@ericsson.com>
13797
13798         PR gdb/24060
13799         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13800         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13801         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13802         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13803         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13804         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13805
13806 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13807
13808         * source.c (select_source_symtab): Move header comment to
13809         declaration in source.h.
13810         (forget_cached_source_info_for_objfile): Likewise.
13811         (forget_cached_source_info): Likewise.
13812         (identify_source_line): Likewise.
13813         * source.h (identify_source_line): Move declaration from symtab.h
13814         and add comment from source.c
13815         (print_source_lines): Likewise.
13816         (forget_cached_source_info_for_objfile): Likewise.
13817         (forget_cached_source_info): Likewise.
13818         (select_source_symtab): Likewise.
13819         (enum print_source_lines_flag): Move definition from symtab.h.
13820         * symtab.h (identify_source_line): Move declaration to source.h.
13821         (print_source_lines): Likewise.
13822         (forget_cached_source_info_for_objfile): Likewise.
13823         (forget_cached_source_info): Likewise.
13824         (select_source_symtab): Likewise.
13825         (enum print_source_lines_flag): Move definition to source.h.
13826         * tui/tui-hooks.c: Add 'source.h' include.
13827
13828 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13829
13830         * source.c (print_source_lines_base): Handle requests to print
13831         reverse line number sequences, and guard against empty lines
13832         string.
13833
13834 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13835
13836         * source.c (print_source_lines_base): Fix skip of '\r' if next
13837         character is '\n'.
13838
13839 2019-01-06  Tom Tromey  <tom@tromey.com>
13840
13841         * c-exp.y (struct c_parse_state) <macro_original_text,
13842         expansion_obstack>: New member.
13843         (macro_original_text, expansion_obstack): Remove globals.
13844         (scan_macro_expansion, scanning_macro_expansion)
13845         (finished_macro_expansion): Update.
13846         (scan_macro_cleanup): Remove.
13847         (yylex, c_parse): Update.
13848
13849 2019-01-06  Tom Tromey  <tom@tromey.com>
13850
13851         * c-exp.y (struct c_parse_state) <strings>: New member.
13852         (operator_stoken): Update.
13853
13854 2019-01-06  Tom Tromey  <tom@tromey.com>
13855
13856         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13857         (union type_stack_elt) <typelist_val>: Now a pointer to
13858         std::vector.
13859         (type_stack_cleanup): Don't declare.
13860         (push_typelist): Update.
13861         * parse.c (pop_typelist): Return a std::vector.
13862         (push_typelist): Take a std::vector.
13863         (follow_types): Update.  Do not free args.
13864         (type_stack_cleanup): Remove.
13865         * c-exp.y (struct c_parse_state): New.
13866         (cpstate): New global.
13867         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13868         (nonempty_typelist): Update.
13869         (func_mod): Create a new vector.
13870         (c_parse): Create a c_parse_state.
13871         (check_parameter_typelist): Do not delete params.
13872         (function_method): Update.  Do not delete type_list.
13873
13874 2019-01-06  Tom Tromey  <tom@tromey.com>
13875
13876         PR gdb/28155:
13877         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13878         check_typedef.
13879         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13880         (print_return_value): Likewise.
13881
13882 2019-01-05  Tom Tromey  <tom@tromey.com>
13883
13884         * contrib/cleanup_check.py: Remove.
13885         * contrib/gcc-with-excheck: Remove.
13886         * contrib/exsummary.py: Remove.
13887         * contrib/excheck.py: Remove.
13888
13889 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13890
13891         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13892         NULL. Initialize tpprev to NULL instead of assigning it
13893         to NULL on the next statement.
13894         * windows-nat.c (windows_delete_thread): Remove check for
13895         main_thread_id before printing thread exit notifications.
13896         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13897         Remove thread ID check against main_thread_id.
13898         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13899         windows_delete_thread.
13900         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13901
13902 2019-01-04  Tom Tromey  <tom@tromey.com>
13903
13904         * compile/compile.c (_initialize_compile): Use upper case for
13905         metasyntactic variables.
13906         * symmisc.c (_initialize_symmisc): Use upper case for
13907         metasyntactic variables.
13908         * psymtab.c (_initialize_psymtab): Use upper case for
13909         metasyntactic variables.
13910         * demangle.c (demangle_command): Use upper case for metasyntactic
13911         variables.
13912         (_initialize_demangler): Likewise.
13913         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13914         variables.
13915
13916 2019-01-03  Tom Tromey  <tom@tromey.com>
13917
13918         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13919
13920 2019-01-03  Tom Tromey  <tom@tromey.com>
13921
13922         * python/py-symtab.c (salpy_str): Update.
13923         (struct salpy_sal_object) <symtab>: Now a PyObject.
13924         (salpy_dealloc): Update.
13925         (del_objfile_sal): Use gdbpy_ref.
13926
13927 2019-01-03  Tom Tromey  <tom@tromey.com>
13928
13929         * python/py-type.c (convert_field): Use new_reference.  Return
13930         gdbpy_ref.
13931         (make_fielditem): Return gdbpy_ref.
13932         (typy_fields): Update.
13933         (typy_getitem): Update.
13934         (field_name): Return gdbpy_ref.  Use new_reference.
13935         (typy_iterator_iternext): Update.
13936
13937 2019-01-03  Tom Tromey  <tom@tromey.com>
13938
13939         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13940
13941 2019-01-03  Tom Tromey  <tom@tromey.com>
13942
13943         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13944         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13945         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13946         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13947         (pspy_set_type_printers): Likewise.
13948         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13949         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13950         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13951         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13952         (objfpy_set_type_printers): Likewise.
13953
13954 2019-01-03  Tom Tromey  <tom@tromey.com>
13955
13956         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13957         (gdbpy_print_stack): Use gdbpy_err_fetch.
13958         * python/python-internal.h (class gdbpy_err_fetch): New class.
13959         (class gdbpy_enter) <m_error_type, m_error_value,
13960         m_error_traceback>: Remove.
13961         <m_error>: New member.
13962         (gdbpy_exception_to_string): Don't declare.
13963         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13964         * python/py-value.c (convert_value_from_python): Use
13965         gdbpy_err_fetch.
13966         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13967         gdbpy_exception_to_string.
13968         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13969         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13970         gdbpy_err_fetch.
13971
13972 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13973
13974         * linux-nat.c (delete_lwp_cleanup): Delete.
13975         (struct lwp_deleter): New struct.
13976         (lwp_info_up): New typedef.
13977         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13978         lwp_info_up.
13979
13980 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13981
13982         * linux-fork.c (class scoped_switch_fork_info): New class.
13983         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13984
13985 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13986
13987         * valops.c (find_overload_match): Remove use of null_cleanup, and
13988         calls to do_cleanups.
13989
13990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13991
13992         * compile/compile-cplus-types.c
13993         (compile_cplus_instance::decl_name): Handle changes to
13994         cp_func_name.
13995         * cp-support.c (cp_func_name): Update header comment, update
13996         return type.
13997         * cp-support.h (cp_func_name): Update return type in declaration.
13998         * valops.c (find_overload_match): Move temp_func local to top
13999         level of function and change its type.  Use temp_func to hold and
14000         delete temporary string obtained from cp_func_name.
14001
14002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14003
14004         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14005         gdb::char_vector, remove cleanup, and update uses of `msg`.
14006
14007 2019-01-03  Jim Wilson  <jimw@sifive.com>
14008
14009         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14010
14011 2019-01-02  Tom Tromey  <tom@tromey.com>
14012
14013         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14014         (tdesc_parse_xml): Remove cleanups.
14015         * target-descriptions.h (make_cleanup_free_target_description):
14016         Don't declare.
14017         (target_desc_deleter): New struct.
14018         (target_desc_up): New typedef.
14019         * target-descriptions.c (target_desc_deleter::operator()): Rename
14020         from free_target_description.
14021         (make_cleanup_free_target_description): Remove.
14022
14023 2019-01-02  Tom Tromey  <tom@tromey.com>
14024
14025         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14026         constructor, destructor.
14027         (linespec_parser): Remove typedef.
14028         (~linespec_parser): Rename from linespec_parser_delete.
14029         (linespec_lex_to_end, linespec_complete_label)
14030         (linespec_complete): Update.
14031         (decode_line_full): Remove cleanups.
14032         (decode_line_1): Update.
14033
14034 2019-01-02  Tom Tromey  <tom@tromey.com>
14035
14036         * python/python-internal.h (inferior_to_inferior_object): Change
14037         return type.
14038         * python/py-exitedevent.c (create_exited_event_object): Update.
14039         * python/py-inferior.c (inferior_to_inferior_object): Return
14040         gdbpy_ref.
14041         (python_new_inferior, python_inferior_deleted)
14042         (thread_to_thread_object, delete_thread_object)
14043         (build_inferior_list, gdbpy_selected_inferior): Update.
14044         * python/py-infthread.c (create_thread_object): Update.  Also fail
14045         if inferior_to_inferior_object fails.
14046
14047 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14048
14049         * inferior.h (class inferior) <displaced_step_state>: New field.
14050         * infrun.h (struct displaced_step_state): Move here from
14051         infrun.c.  Initialize fields, add constructor.
14052         <inf>: Remove field.
14053         <reset>: New method.
14054         * infrun.c (struct displaced_step_inferior_state): Move to
14055         infrun.h.
14056         (displaced_step_inferior_states): Remove.
14057         (get_displaced_stepping_state): Adust.
14058         (displaced_step_in_progress_any_inferior): Adjust.
14059         (displaced_step_in_progress_thread): Adjust.
14060         (displaced_step_in_progress): Adjust.
14061         (add_displaced_stepping_state): Remove.
14062         (get_displaced_step_closure_by_addr): Adjust.
14063         (remove_displaced_stepping_state): Remove.
14064         (infrun_inferior_exit): Call displaced_step_state.reset.
14065         (use_displaced_stepping): Don't check for NULL.
14066         (displaced_step_prepare_throw): Call
14067         get_displaced_stepping_state.
14068         (displaced_step_fixup): Don't check for NULL.
14069         (prepare_for_detach): Don't check for NULL.
14070
14071 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14072
14073         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14074          in case of call that did not complete.
14075
14076 2019-01-02  Andrey Utkin  <autkin@undo.io>
14077
14078         * symfile.c (find_separate_debug_file): Fix search of debug files for
14079         remote debuggee.
14080
14081 2019-01-02  Tom Tromey  <tom@tromey.com>
14082
14083         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14084         indentation.
14085         * python/py-frame.c (frapy_older): Remove cast.
14086         (frapy_newer): Likewise.
14087         * python/py-breakpoint.c (local_setattro): Remove cast.
14088         * python/py-arch.c (archpy_name): Remove local variable.
14089         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14090
14091 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14092
14093         * unittests/basic_string_view/element_access/char/empty.cc:
14094         Fix year range in copyright header.
14095
14096 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14097
14098         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14099         Delete.
14100         <operator==>: Update with for removed field.
14101         <hash>: Likewise.
14102         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14103         <isa_features>: ...this.
14104         <abi_features>: New field.
14105         (riscv_isa_flen): Update comment.
14106         (riscv_abi_xlen): New declaration.
14107         (riscv_abi_flen): New declaration.
14108         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14109         isa_features.
14110         (riscv_abi_xlen): New function.
14111         (riscv_isa_flen): Update to get answer from isa_features.
14112         (riscv_abi_flen): New function.
14113         (riscv_has_fp_abi): Update to get answer from abi_features.
14114         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14115         xlen and flen.
14116         (riscv_call_info) <xlen, flen>: Update comment.
14117         (riscv_call_arg_struct): Remove invalid assertions
14118         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14119         is removed.
14120         (riscv_gdbarch_init): Gather isa features and abi features
14121         separately, ensure both match on the gdbarch when reusing an old
14122         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14123         a target with 64-bit float hardware.
14124
14125 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14126
14127         * source.c (search_command_helper): Stop reverse search
14128         when line 1 has been searched.
14129
14130 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14131
14132         * record-full.c (record_full_base_target::close): Rewrite
14133         record_full_core_buf_list free logic.
14134
14135 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14136
14137         * break-catch-syscall.c (print_one_catch_syscall): xfree
14138         the last text.
14139
14140 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14141
14142         * top.c (print_gdb_version): Update Copyright year in version
14143         message.
14144
14145 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14146
14147         Update copyright year range in all GDB files.
14148
14149 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14150
14151         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14152
14153 For older changes see ChangeLog-2018.
14154 \f
14155 Local Variables:
14156 mode: change-log
14157 left-margin: 8
14158 fill-column: 74
14159 version-control: never
14160 coding: utf-8
14161 End:
14162