gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * source.c (struct current_source_location) <set, symtab, line>:
   4         New methods.
   5         <m_symtab, m_line>: Rename.  Now private.
   6         (get_current_source_symtab_and_line)
   7         (set_default_source_symtab_and_line)
   8         (set_current_source_symtab_and_line)
   9         (clear_current_source_symtab_and_line, select_source_symtab)
  10         (info_source_command, print_source_lines_base)
  11         (info_line_command, search_command_helper): Update.
  12         * observable.h (current_source_symtab_and_line_changed): Declare
  13         observable.
  14         * observable.c (current_source_symtab_and_line_changed): Define
  15         observable.
  16
  17 2019-12-20  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
  20         (tui_before_prompt, tui_normal_stop): Update.
  21
  22 2019-12-20  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-winsource.c
  25         (tui_source_window_base::update_source_window_as_is): Don't call
  26         set_current_source_symtab_and_line.
  27
  28 2019-12-20  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
  31         Take a symtab_and_line.
  32         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
  33         symtab_and_line.
  34         (tui_show_frame_info): Update.
  35
  36 2019-12-20  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-stack.c (tui_show_frame_info): Don't call
  39         update_exec_info.
  40
  41 2019-12-20  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui.c (tui_enable): Call tui_display_main.
  44
  45 2019-12-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
  48         get_current_source_symtab_and_line, and main_name.
  49
  50 2019-12-20  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui.c (tui_show_source): Update.
  53         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
  54         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
  55         a symtab_symbol_info, not a separate symtab and line.  Simplify.
  56
  57 2019-12-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
  60         Simplify.
  61
  62 2019-12-20  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-winsource.h (struct tui_source_window_base)
  65         <set_contents, update_source_window_as_is, update_source_window>:
  66         Take a sal, not a separate symtab and tui_line_or_address.
  67         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  68         (tui_source_window_base::update_source_window_as_is): Take a sal,
  69         not a separate symtab and tui_line_or_address.
  70         (tui_update_source_windows_with_addr)
  71         (tui_update_source_windows_with_line)
  72         (tui_source_window_base::rerender)
  73         (tui_source_window_base::refill): Update.
  74         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
  75         a sal, not a separate symtab and tui_line_or_address.
  76         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
  77         not a separate symtab and tui_line_or_address.
  78         (tui_source_window::maybe_update): Update.
  79         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
  80         a sal, not a separate symtab and tui_line_or_address.
  81         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
  82         not a separate symtab and tui_line_or_address.
  83         (tui_disasm_window::do_scroll_vertical)
  84         (tui_disasm_window::maybe_update): Update.
  85
  86 2019-12-20  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-winsource.c (tui_source_window_base::refill): Use
  89         start_line_or_addr.
  90         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
  91         start_line_or_addr.
  92         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  93         start_line_or_addr.
  94
  95 2019-12-20  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.h (struct tui_source_window_base)
  98         <set_contents>: Return bool.
  99         * tui/tui-winsource.c
 100         (tui_source_window_base::update_source_window_as_is): Update.
 101         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 102         Return bool.
 103         * tui/tui-source.c (tui_source_window::set_contents): Return
 104         bool.  Simplify.
 105         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 106         Return bool.
 107         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 108         bool.
 109
 110 2019-12-20  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 113         (tui_update_source_windows_with_line): Call update_source_window.
 114         * tui/tui-source.h (struct tui_source_window)
 115         <show_symtab_source>: Don't declare.
 116         * tui/tui-source.c (tui_source_window::show_symtab_source):
 117         Remove.
 118
 119 2019-12-20  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 122         update_source_window directly.
 123         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 124         * tui/tui-disasm.c (tui_show_disassem): Remove.
 125
 126 2019-12-20  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-winsource.c
 129         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 130         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 131
 132 2019-12-20  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-winsource.h (struct tui_source_window_base)
 135         <maybe_update>: Remove line_no and addr parameters.
 136         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 137         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 138         Update.
 139         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 140         line_no and addr parameters.
 141         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 142         Update.
 143         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 144         line_no and addr parameters.
 145
 146 2019-12-20  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 149         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 150
 151 2019-12-20  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 154         tui_show_disassem.
 155         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 156         declare.
 157         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 158
 159 2019-12-20  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui.h (tui_show_source): Remove parameters.
 162         * tui/tui.c (tui_show_source): Remove parameters.
 163         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 164
 165 2019-12-20  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui.c (tui_show_source): Update.
 168         * tui/tui-winsource.c (tui_display_main): Update.
 169         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 170         to symtab.
 171         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 172         to symtab.
 173         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 174
 175 2019-12-20  Tom Tromey  <tom@tromey.com>
 176
 177         PR tui/23619:
 178         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 179         (tui_redisplay_readline): Use rl_display_prompt.
 180         (tui_prep_terminal): Update.
 181
 182 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 183
 184         * configure: Regenerate.
 185         * configure.ac: Quote variable arguments of test.
 186         * gdbsupport/common.m4: Likewise.
 187
 188 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 189
 190         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 191         2 to pow ().
 192
 193 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 194
 195         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 196         log10 to double to fix Solaris 11 with gcc 5.5.
 197
 198 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 199
 200         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 201         "sun" to "saddr_un".
 202
 203 2019-12-19  Tom Tromey  <tromey@adacore.com>
 204
 205         * ui-out.h (enum class field_kind): Fix comment.
 206
 207 2019-12-11  Tom Tromey  <tromey@adacore.com>
 208
 209         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 210
 211 2019-12-18  Tom Tromey  <tromey@adacore.com>
 212
 213         PR build/25268:
 214         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 215         type on macOS.  Add comment.
 216
 217 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 218
 219         * c-lang.c (c_get_string, asm_language_defn): Remove space
 220         before tab.
 221
 222 2019-12-18  Tom Tromey  <tromey@adacore.com>
 223
 224         PR build/25250:
 225         * ui-out.c (ui_out::vmessage): Update.
 226         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 227         Rename.
 228         (string_field): Update.
 229         (signed_field): Update.
 230
 231 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 232
 233         * top.c (print_gdb_configuration): Adjust indentation.
 234
 235 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 236
 237         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 238
 239 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         * tui/tui-layout.h (class tui_layout_base): Add virtual
 242         destructor.
 243
 244 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 245
 246         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 247         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 248         (process_event_stop_test): Keep stepping over skipped inline functions.
 249
 250 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 251
 252         * jit.c (struct gdb_block) <next>: Remove field.
 253         (struct gdb_symtab) <~gdb_symtab>: Remove.
 254         <blocks>: Change type to std::forward_list<gdb_block>.
 255         (compare_block): Remove.
 256         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 257         block at the beginning, don't mind about sorting.
 258         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 259         before using it.
 260
 261 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 262
 263         * jit.c (struct gdb_block): Add constructor, initialize
 264         real_block and next fields.
 265         <name>: Change type to gdb::unique_xmalloc_ptr.
 266         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 267         (jit_block_open_impl): Allocate gdb_block with new.
 268         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 269
 270 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 271
 272         * jit.c: Include forward_list.
 273         (struct gdb_symtab) <next>: Remove field.
 274         (struct gdb_object) <symtabs>: Change type to
 275         std::forward_list<gdb_symtab>.
 276         (jit_object_open_impl): Allocate gdb_object with new.
 277         (jit_symtab_open_impl): Adjust to std::forward_list.
 278         (finalize_symtab): Don't delete symtab.
 279         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 280         gdb_object with delete.
 281
 282 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 283
 284         * jit.c (struct gdb_symtab): Add constructor, destructor,
 285         initialize fields.
 286         <linetable>: Change type to unique_xmalloc_ptr.
 287         <file_name>: Change type to std::string.
 288         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 289         (jit_symtab_line_mapping_add_impl): Adjust.
 290         (finalize_symtab): Adjust, call delete on stab.
 291
 292 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 293
 294         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 295
 296 2019-12-16  Tom Tromey  <tromey@adacore.com>
 297
 298         * windows-nat.c (windows_nat_target::attach): Update.
 299         * remote.c (extended_remote_target::attach): Update.
 300         * procfs.c (procfs_target::attach): Update.
 301         * nto-procfs.c (nto_procfs_target::attach): Update.
 302         (nto_procfs_target::create_inferior): Update.
 303         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 304         * gnu-nat.c (gnu_nat_target::attach): Update.
 305         (gnu_nat_target::detach): Update.
 306         * darwin-nat.c (darwin_nat_target::attach): Update.
 307         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 308         return.
 309         * bsd-kvm.c (bsd_kvm_target_open): Update.
 310         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 311
 312 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 313
 314         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 315         (we no longer need to include time.h before pathmax.h)
 316
 317 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 318
 319         * ada-exp.y (write_ambiguous_var): Update.
 320         * coffread.c (process_coff_symbol): Update.
 321         * ctfread.c (ctf_add_enum_member_cb): Update.
 322         (new_symbol): Update.
 323         * dwarf2read.c (fixup_go_packaging): Update.
 324         (new_symbol): Update.
 325         * language.c (language_alloc_type_symbol): Update.
 326         * mdebugread.c (new_symbol): Update.
 327         * minsyms.c (minimal_symbol_reader::record_full): Update.
 328         * psymtab.c (add_psymbol_to_bcache): Update.
 329         * stabsread.c (define_symbol): Update.
 330         (read_enum_type): Update.
 331         * symtab.c (symbol_set_language): Make this a member function...
 332         (general_symbol_info::set_language): ... here.
 333         * symtab.h (struct general_symbol_info) <set_language>: New function.
 334         (SYMBOL_SET_LANGUAGE): Remove.
 335         (symbol_set_language): Remove.
 336
 337 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 338
 339         * ada-lang.c (ada_add_block_symbols): Update.
 340         (ada_collect_symbol_completion_matches): Update.
 341         * ax-gdb.c (gen_expr): Update.
 342         * block.c (block_lookup_symbol): Update.
 343         (block_lookup_symbol_primary): Update.
 344         (block_find_symbol): Update.
 345         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 346         * dbxread.c (process_one_symbol): Update.
 347         * dictionary.c (insert_symbol_hashed): Update.
 348         (collate_pending_symbols_by_language): Update.
 349         (mdict_add_symbol): Update.
 350         * dwarf-index-write.c (write_psymbols): Update.
 351         * dwarf2read.c (fixup_go_packaging): Update.
 352         * findvar.c (read_var_value): Update.
 353         * ft32-tdep.c (ft32_skip_prologue): Update.
 354         * go-lang.c (go_symbol_package_name): Update.
 355         * language.h (scoped_switch_to_sym_language_if_auto::
 356         scoped_switch_to_sym_language_if_auto): Update.
 357         * linespec.c (find_method): Update.
 358         (find_label_symbols_in_block): Update.
 359         * mdebugread.c (parse_symbol): Update.
 360         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 361         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 362         (minimal_symbol_reader::install): Update.
 363         * moxie-tdep.c (moxie_skip_prologue): Update.
 364         * parse.c (parse_exp_in_context): Update.
 365         * psymtab.c (psymbol_name_matches): Update.
 366         (match_partial_symbol): Update.
 367         (lookup_partial_symbol): Update.
 368         (psymbol_hash): Update.
 369         (psymbol_compare): Update.
 370         * python/py-framefilter.c (extract_sym): Update.
 371         (py_print_single_arg): Update.
 372         * stabsread.c (define_symbol): Update.
 373         * stack.c (print_frame_arg): Update.
 374         (find_frame_funname): Update.
 375         (info_frame_command_core): Update.
 376         * symfile.c (set_initial_language): Update.
 377         * symtab.c (symbol_set_demangled_name): Update.
 378         (symbol_get_demangled_name): Update.
 379         (symbol_set_language): Update.
 380         (symbol_find_demangled_name): Update.
 381         (symbol_set_names): Update.
 382         (general_symbol_info::natural_name): Update.
 383         (general_symbol_info::demangled_name): Update.
 384         (general_symbol_info::search_name): Update.
 385         (symbol_matches_search_name): Update.
 386         (eq_symbol_entry): Update.
 387         (iterate_over_symbols): Update.
 388         (completion_list_add_symbol): Update.
 389         (completion_list_add_msymbol): Update.
 390         (completion_list_add_fields): Update.
 391         * symtab.h (struct general_symbol_info) <language>: New function.
 392         <language>: Rename to...
 393         <m_language>: ...this.
 394         (SYMBOL_LANGUAGE): Remove.
 395         (MSYMBOL_LANGUAGE): Remove.
 396         (struct symbol) <ctor>: Update.
 397         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 398
 399 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 400
 401         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 402         set the language of sym.
 403         * language.c (language_alloc_type_symbol): Likewise.
 404
 405 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 406
 407         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 408         PR gdb/23613
 409         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 410         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 411         (core_target_open): Use 'gdb_abspath'.
 412         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 413         'current_directory == NULL' case.
 414         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 415         explain what happens when 'current_directory' is NULL.
 416         * go32-nat.c (go32_nat_target::wait): Check if
 417         'current_directory' is NULL before call to 'chdir'.
 418         * source.c (add_path): Use 'gdb_abspath'.
 419         * top.c: Include 'gdbsupport/pathstuff.h'.
 420         (init_history): Use 'gdb_abspath'.
 421         (set_history_filename): Likewise.
 422         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 423         (tfile_target_open): Use 'gdb_abspath'.
 424
 425 2019-12-13  Tom Tromey  <tromey@adacore.com>
 426
 427         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 428         warning or error.
 429
 430 2019-12-13  Tom Tromey  <tromey@adacore.com>
 431
 432         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 433
 434 2019-12-13  Tom Tromey  <tromey@adacore.com>
 435
 436         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 437
 438 2019-12-13  Tom Tromey  <tromey@adacore.com>
 439
 440         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 441
 442 2019-12-13  Tom Tromey  <tromey@adacore.com>
 443
 444         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 445         (string_vappendf): Add ARI comment.
 446
 447 2019-12-13  Tom Tromey  <tromey@adacore.com>
 448
 449         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 450         floatformat_to_double.
 451         * target-float.c (host_float_ops<T>::from_target): Add ARI
 452         comment.
 453
 454 2019-12-13  Tom Tromey  <tromey@adacore.com>
 455
 456         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 457         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 458         ARI marker to abort.
 459         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 460
 461 2019-12-13  Tom Tromey  <tromey@adacore.com>
 462
 463         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 464
 465 2019-12-13  Tom Tromey  <tromey@adacore.com>
 466
 467         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 468
 469 2019-12-13  Tom Tromey  <tromey@adacore.com>
 470
 471         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 472         checks.
 473
 474 2019-12-13  Tom Tromey  <tromey@adacore.com>
 475
 476         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 477         end>: No longer "const".
 478
 479 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 480
 481         * jit.c: Fix indentation, replace spaces with tabs where
 482         applicable.
 483
 484 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 485
 486         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 487
 488 2019-12-12  Tom Tromey  <tom@tromey.com>
 489
 490         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 491         unique_ptr.
 492
 493 2019-12-12  Tom Tromey  <tom@tromey.com>
 494
 495         * progspace.h (objfile_list): New typedef.
 496         (class unwrapping_objfile_iterator)
 497         (struct unwrapping_objfile_range): Newl
 498         (struct program_space) <objfiles_range>: Change type.
 499         <objfiles>: Change return type.
 500         <add_objfile>: Change type of "objfile" parameter.
 501         <objfiles_list>: Now a list of shared_ptr.
 502         * progspace.c (program_space::add_objfile): Change type of
 503         "objfile".  Update.
 504         (program_space::remove_objfile): Update.
 505         * objfiles.h (struct objfile) <~objfile>: Make public.
 506         * objfiles.c (objfile::make): Update.
 507         (objfile::unlink): Don't call delete.
 508
 509 2019-12-12  Tom Tromey  <tom@tromey.com>
 510
 511         * symfile.c (symbol_file_clear): Update.
 512         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 513         method.
 514         * progspace.c (program_space::free_all_objfiles): New method.
 515         * objfiles.h (free_all_objfiles): Don't declare.
 516         * objfiles.c (free_all_objfiles): Move to program_space.
 517
 518 2019-12-12  Tom Tromey  <tom@tromey.com>
 519
 520         * progspace.c (program_space::add_objfile)
 521         (program_space::remove_objfile): Update.
 522         (program_space::multi_objfile_p): Remove.
 523         * objfiles.h (struct objfile) <next>: Remove.
 524         * objfiles.c (objfile::objfile): Update.
 525         (put_objfile_before): Update.
 526         (unlink_objfile): Update.
 527         * progspace.h (object_files): Remove.
 528         (struct program_space) <objfiles_head>: Remove.
 529         <objfiles_list>: New member.
 530         <objfiles_range, objfiles_safe_range>: Change type.
 531         (objfiles): Change return type.
 532         (objfiles_safe): Update.
 533         (multi_objfile_p): Rewrite and inline.
 534         (object_files): Remove macro.
 535
 536 2019-12-12  Tom Tromey  <tom@tromey.com>
 537
 538         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 539         second constructor.
 540         (basic_safe_range): New class.
 541
 542 2019-12-12  Tom Tromey  <tom@tromey.com>
 543
 544         * progspace.c (program_space::multi_objfile_p): New method.
 545         * printcmd.c (info_symbol_command): Update.
 546         * maint.c (maintenance_translate_address): Update.
 547         * objfiles.h (MULTI_OBJFILE_P): Remove.
 548         * progspace.h (struct program_space) <multi_objfile_p>: New
 549         method.
 550
 551 2019-12-12  Tom Tromey  <tom@tromey.com>
 552
 553         * progspace.h (struct program_space) <remove_objfile>: Declare.
 554         * progspace.c (program_space::remove_objfile): New method.
 555         * objfiles.c (unlink_objfile): Remove.
 556         (objfile::unlink): Call remove_objfile.
 557         (objfile): Don't call unlink_objfile.
 558
 559 2019-12-12  Tom Tromey  <tom@tromey.com>
 560
 561         * progspace.h (struct program_space) <add_objfile>: Declare
 562         method.
 563         * progspace.c (program_space::add_objfile): New method.
 564         * objfiles.c (~objfile): Don't unlink objfile.
 565         (put_objfile_before): Remove.
 566         (add_separate_debug_objfile): Don't call put_objfile_before.
 567         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 568         the per-program-space data.
 569
 570 2019-12-12  Tom Tromey  <tom@tromey.com>
 571
 572         * symfile.c (syms_from_objfile_1): Use objfile_up.
 573         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 574         method.
 575         (reread_symbols): Use objfile_up.
 576         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 577         unlink method.
 578         * objfiles.h (struct objfile) <~objfile>: Now private.
 579         <unlink>: New method.
 580         (struct objfile_deleter): New.
 581         (objfile_up): New typedef.
 582         * objfiles.c (objfile::unlink): New method.
 583         (free_objfile_separate_debug, free_all_objfiles)
 584         (objfile_purge_solibs): Use it.
 585         * jit.c (jit_unregister_code): Remove.
 586         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 587         objfile.
 588         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 589         objfile.
 590         * compile/compile-object-load.c (compile_object_load): Use
 591         objfile_up.
 592
 593 2019-12-12  Tom Tromey  <tom@tromey.com>
 594
 595         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 596         objfile::make.
 597         * objfiles.h (struct objjfile) <make>: No longer inline.
 598         (add_separate_debug_objfile): Don't declare.
 599         * objfiles.c (add_separate_debug_objfile): Now static.
 600         (objfile::make): Move from objfiles.h.  Call
 601         add_separate_debug_objfile.  Add "parent" parameter.
 602
 603 2019-12-12  Tom Tromey  <tom@tromey.com>
 604
 605         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 606         * objfiles.h (struct objfile): Make constructor private.
 607         <make>: New static method.
 608         * jit.c (jit_object_close_impl): Update.
 609
 610 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 611
 612         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 613         gdb::byte_vector.
 614
 615 2019-12-12  Tom Tromey  <tromey@adacore.com>
 616
 617         * xml-support.c (xml_fetch_content_from_file): Don't call
 618         malloc_failure.
 619         * utils.h (class gdb_argv): Remove malloc_failure comment.
 620         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 621
 622 2019-12-12  Tom Tromey  <tromey@adacore.com>
 623
 624         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 625         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 626         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 627         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 628         * riscv-ravenscar-thread.c: New file.
 629         * riscv-ravenscar-thread.h: New file.
 630         * riscv-tdep.c (riscv_gdbarch_init): Call
 631         register_riscv_ravenscar_ops.
 632
 633 2019-12-12  Tom Tromey  <tromey@adacore.com>
 634
 635         * gdbsupport/thread-pool.c (set_thread_name): Use
 636         ATTRIBUTE_UNUSED.
 637
 638 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 639
 640         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 641         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 642         macros.
 643
 644 2019-12-11  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-win.c (tui_set_win_height_command): Call
 647         tui_adjust_window_height.
 648         (tui_adjust_win_heights, new_height_ok): Remove.
 649         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 650         * tui/tui-layout.c (tui_adjust_window_height): New function.
 651
 652 2019-12-11  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-win.c (tui_resize_all): Remove code, call
 655         tui_apply_current_layout.
 656
 657 2019-12-11  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 660         * tui/tui-layout.c (standard_layouts, applied_layout): New
 661         globals.
 662         (tui_apply_current_layout): New function.
 663         (show_layout): Set applied_layout.  Call
 664         tui_apply_current_layout.
 665         (show_source_command, show_disasm_command)
 666         (show_source_disasm_command, show_data)
 667         (show_source_or_disasm_and_command): Remove.
 668         (initialize_layouts): New function.
 669         (_initialize_tui_layout): Call initialize_layouts.
 670
 671 2019-12-11  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-layout.h (class tui_layout_base)
 674         (class tui_layout_window, class tui_layout_split): New.
 675         * tui/tui-layout.c (tui_get_window_by_name)
 676         (tui_layout_window::clone, tui_layout_window::apply)
 677         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 678         (tui_layout_split::add_window, tui_layout_split::clone)
 679         (tui_layout_split::get_sizes)
 680         (tui_layout_split::set_weights_from_heights)
 681         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 682         functions.
 683         (tui_layout_split::add_split, tui_layout_split::add_split)
 684         (tui_layout_split::set_weights_from_heights)
 685         (tui_layout_split::set_weights_from_heights): New functions.
 686
 687 2019-12-11  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 690         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 691         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 692         * tui/tui-data.h (struct tui_point): Remove.
 693         (struct tui_gen_win_info) <origin>: Remove.
 694         <x, y>: New fields.
 695         * tui/tui-command.c (tui_cmd_window::resize): Update.
 696
 697 2019-12-11  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 700         Implement.
 701         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 702         Implement.
 703         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 704         method.
 705         (struct tui_win_info) <min_height>: Implement.
 706
 707 2019-12-11  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 710         (struct tui_win_info) <can_box>: Update.
 711
 712 2019-12-11  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 715         method.
 716         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 717         method.
 718         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 719         method.
 720         (struct tui_win_info) <max_height>: Now override.
 721
 722 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 723
 724         * NEWS: Create a new section for the next release branch.
 725         Rename the section of the current branch, now that it has
 726         been cut.
 727
 728 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 729
 730         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 731         * version.in: Bump version to 10.0.50.DATE-git.
 732
 733 2019-12-11  Tom Tromey  <tromey@adacore.com>
 734
 735         PR build/25268:
 736         * gdbsupport/thread-pool.c (set_thread_name): New function.
 737         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 738         (thread_pool::thread_function): Call set_thread_name.
 739
 740 2019-12-11  Tom Tromey  <tromey@adacore.com>
 741
 742         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 743         bfd_get_signed_8.
 744
 745 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 746
 747         * NEWS: Document -raw-values option and the related setting commands.
 748         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 749         only set it on when /r is given.
 750         * valprint.c (value_print_option_defs): New element raw-values.
 751         * Makefile.in: Add the new file.
 752
 753 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 754
 755         * gdbsupport/safe-strerror.c: Supress the unused function warning
 756         for select_strerror_r.
 757
 758 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 759
 760         * config.in: Regenerate.
 761         * configure: Regenerate.
 762         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 763         safe_strerror instead of strerror.
 764         * gdbsupport/common.m4: Don't check for strerror.
 765         * gdbsupport/safe-strerror.c: Support both the glibc version
 766         of strerror_r and the XSI version.
 767
 768 2019-12-10  Tom Tromey  <tromey@adacore.com>
 769
 770         * ada-typeprint.c (print_choices): Use a single "?".
 771         (print_variant_part): Print "?" if the discriminant name
 772         is not known.
 773
 774 2019-12-10  George Barrett  <bob@bob131.so>
 775
 776         Fix scripted probe breakpoints.
 777         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 778         declaration forward.
 779         (breakpoint_ops_for_event_location_type)
 780         (breakpoint_ops_for_event_location): Add function definitions.
 781         (break_command_1, trace_command): Use
 782         breakpoint_ops_for_event_location.
 783         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 784         declarations.
 785         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 786         breakpoint_ops_for_event_location.
 787         * python/py-breakpoint.c (bppy_init): Use
 788         breakpoint_ops_for_event_location.
 789
 790 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 791
 792         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 793         when ranking an lvalue argument for an rvalue parameter.
 794
 795 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 796
 797         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 798         template argument for scoped_restore_tmpl from bool to int.
 799
 800 2019-12-07  Keith Seitz  <keiths@redhat.com>
 801
 802         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 803         (build_id_to_debug_bfd): Make static, rewriting to use
 804         build_id_to_bfd_suffix.
 805         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 806         adding `suffix' parameter. Append SUFFIX to file names
 807         when searching for matching files.
 808         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 809         (build_id_to_exec_bfd): Likewise.
 810         * build-id.h (build_id_to_debug_bfd): Clarify that function
 811         searches for BFD of debug info file.
 812         (build_id_to_exec_bfd): Declare.
 813         * corelow.c: Include build-id.h.
 814         (locate_exec_from_corefile_build_id): New function.
 815         (core_target_open): If no executable BFD is found,
 816         search for a core file BFD using build-id.
 817
 818 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 819
 820         * bcache.c: Put in namespace gdb.
 821         * bcache.h: Likewise.
 822         * gdbtypes.c (check_types_worklist): Update.
 823         (types_deeply_equal): Update.
 824         * macrotab.c (struct macro_table) <bcache>: Update.
 825         (new_macro_table): Update.
 826         * macrotab.h (struct bcache): Put this forward declaration
 827         inside namespace gdb.
 828         (new_macro_table): Update.
 829         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 830         Update.
 831         <macro_cache>: Update.
 832         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 833
 834 2019-12-06  Tom de Vries  <tdevries@suse.de>
 835
 836         PR symtab/24971
 837         * block.c (best_symbol, better_symbol): New function.
 838         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 839         decl.
 840
 841 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 842
 843         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 844         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 845         for ranking see-through reference cases.
 846
 847 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 848         * stack.c (faas_command): Check a command is provided.
 849         * thread.c (taas_command, tfaas_command): Likewise.
 850
 851 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 852         * inferior.c (prune_inferiors):  Only call delete_inferior,
 853         Do not modify the inferior list.
 854
 855 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 856
 857         * c-exp.y: Update calls to lookup_typename,
 858         lookup_signed_typename and lookup_unsigned_typename.
 859         * c-lang.c (evaluate_subexp_c): Likewise.
 860         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 861         Likewise.
 862         * eval.c (binop_promote): Likewise.
 863         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 864         (lookup_unsigned_typename): Likewise.
 865         (lookup_signed_typename): Likewise.
 866         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 867         (lookup_signed_typename): Likewise.
 868         (lookup_typename): Likewise.
 869         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 870         lookup_typename, lookup_signed_typename,
 871         lookup_unsigned_typename.
 872         * m2-exp.y: Likewise.
 873         * printcmd.c (printf_wide_c_string): Likewise.
 874         (ui_printf): Likewise.
 875         * python/py-type.c (typy_lookup_typename): Likewise.
 876         * python/py-xmethods.c (python_xmethod_worker::invoke):
 877         Likewise.
 878         * rust-exp.y: Likewise.
 879
 880 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 881
 882         * configure.nat (obsd64): Add missing files x86-nat.o and
 883         nat/x86-dregs.o.
 884
 885 2019-12-04  Tom Tromey  <tom@tromey.com>
 886
 887         * valprint.c (val_print_string): Use metadata_style.
 888         * go-valprint.c (print_go_string): Use metadata style.
 889         * p-valprint.c (pascal_object_print_static_field): Use metadata
 890         style.
 891         * cp-valprint.c (cp_print_static_field): Use metadata style.
 892
 893 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 894             Chris January  <chris.january@arm.com>
 895
 896         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 897         tokens.
 898         (typebase): New patterns for complex, single/double precision, and
 899         single/double complex.
 900         (f77_keywords): Change token for complex keyword, and add single,
 901         double, and precision keywords.
 902
 903 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 904
 905         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 906         "info io_registers".
 907
 908 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 909
 910         * regcache.c (cooked_read_test): Initialize thread list of
 911         mock_inferior.
 912
 913 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 914
 915         * aarch64-linux-tdep.c: Remove includes.
 916
 917 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 918
 919         * aarch64-tdep.c: Remove includes.
 920
 921 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 922
 923         * filtered-iterator.h (filtered_iterator) <operator==,
 924         operator!=>: Compare wrapped iterators, not wrapped pointers.
 925         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 926         unittests/filtered_iterator-selftests.c.
 927         * unittests/filtered_iterator-selftests.c: New file.
 928
 929 2019-12-04  Tom Tromey  <tromey@adacore.com>
 930
 931         * gdbtypes.c (create_range_type): Inherit endianity
 932         from base type.
 933
 934 2019-12-04  Tom Tromey  <tromey@adacore.com>
 935
 936         * ada-lang.c (decode_constrained_packed_array)
 937         (ada_value_assign, value_assign_to_component): Update.
 938         * dwarf2loc.c (rw_pieced_value, access_memory)
 939         (dwarf2_compile_expr_to_ax): Update.
 940         * dwarf2read.c (dwarf2_add_field): Update.
 941         * eval.c (evaluate_subexp_standard): Update.
 942         * gdbarch.c, gdbarch.h: Rebuild.
 943         * gdbarch.sh (bits_big_endian): Remove.
 944         * gdbtypes.h (union field_location): Update comment.
 945         * target-descriptions.c (make_gdb_type): Update.
 946         * valarith.c (value_bit_index): Update.
 947         * value.c (struct value) <bitpos>: Update comment.
 948         (unpack_bits_as_long, modify_field): Update.
 949         * value.h (value_bitpos): Update comment.
 950
 951 2019-12-04  Tom Tromey  <tromey@adacore.com>
 952
 953         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 954         endian-ness.
 955
 956 2019-12-04  Tom Tromey  <tromey@adacore.com>
 957
 958         * dwarf2read.c (dwarf2_init_float_type)
 959         (dwarf2_init_complex_target_type): Add byte_order parameter.
 960         (read_base_type): Compute byte order earlier.
 961         * gdbtypes.c (init_float_type): Add byte_order parameter.
 962         * gdbtypes.h (init_float_type): Add byte_order parameter.
 963
 964 2019-12-04  Tom Tromey  <tromey@adacore.com>
 965
 966         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 967
 968 2019-12-04  Tom Tromey  <tromey@adacore.com>
 969
 970         * dwarf2read.c (process_structure_scope): Initialize
 971         "discr_offset".
 972
 973 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 976         add it into the search spec.
 977         (parse_max_results_option): New function.
 978         (mi_info_functions_or_variables): Parse -max-results flag and pass
 979         it to mi_symbol_info.
 980         (mi_cmd_symbol_info_modules): Likewise.
 981         (mi_cmd_symbol_info_types): Likewise.
 982         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 983         return type to bool, change result container into a set, and don't
 984         add new results if we have enough already.
 985         (global_symbol_searcher::add_matching_msymbols): Change return
 986         type to bool, and don't add new results if we have enough already.
 987         (sort_search_symbols_remove_dups): Delete.
 988         (global_symbol_searcher::search): Early exit from search loop when
 989         we have enough results.  Use a std::set to collect the results
 990         from calling add_matching_symbols.
 991         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 992         member function.
 993         (global_symbol_searcher) <m_max_search_results>: New member
 994         variable.
 995         (global_symbol_searcher) <add_matching_symbols>: Update header
 996         comment and change return type to bool.
 997         (global_symbol_searcher) <add_matching_msymbols>: Update header
 998         comment and change return type to bool.
 999
1000 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * symtab.c (symbol_search::compare_search_syms): Update header
1003         comment.
1004         (global_symbol_searcher::is_suitable_msymbol): New function.
1005         (global_symbol_searcher::expand_symtabs): New function.
1006         (global_symbol_searcher::add_matching_symbols): New function.
1007         (global_symbol_searcher::add_matching_msymbols): New function.
1008         (global_symbol_searcher::search): Move most of the content
1009         into the new functions above, and call them as needed.
1010         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1011         function.
1012         (global_symbol_searcher) <add_matching_symbols>: New member
1013         function.
1014         (global_symbol_searcher) <add_matching_msymbols>: New member
1015         function.
1016         (global_symbol_searcher) <is_suitable_msymbol>: New member
1017         function.
1018
1019 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1020
1021         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1022         -symbol-info-module-variables entries.
1023         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1024         (mi_cmd_symbol_info_module_variables): Declare.
1025         * mi/mi-symbol-cmds.c
1026         (module_symbol_search_iterator): New typedef.
1027         (output_module_symbols_in_single_module_and_file): New function.
1028         (output_module_symbols_in_single_module): New function.
1029         (mi_info_module_functions_or_variables): New function.
1030         (mi_cmd_symbol_info_module_functions): New function.
1031         (mi_cmd_symbol_info_module_variables): New function.
1032         * NEWS: Mention new MI command.
1033
1034 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * bcache.c (hash): Remove.
1037         (hash_continue): Remove.
1038         * bcache.h (hash): Remove.
1039         (hash_continue): Remove.
1040         (struct bcache) <ctor>: Update.
1041         * psymtab.c (psymbol_hash): Update.
1042         * stabsread.c (hashname): Update.
1043         * utils.h (fast_hash): Add an argument for a start value,
1044         defaulting to zero.
1045
1046 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1047         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1048         (destroy_block_symbol_cache): New function.
1049         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1050         (resize_symbol_cache): Likewise.
1051
1052 2019-12-02  Tom Tromey  <tom@tromey.com>
1053
1054         * unittests/tui-selftests.c (run_tests): Make conditional.
1055         (_initialize_tui_selftest): Make conditional.
1056
1057 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1058
1059         * aix-thread.c (debug_aix_thread): Change type to bool.
1060
1061 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1062
1063         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1064
1065 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * dwarf2read.c (read_tag_string_type): Read the fields required to
1068         make a dynamic string, and possibly create a dynamic range for the
1069         string.
1070         (attr_to_dynamic_prop): Setup is_reference based on the type of
1071         attribute being processed.
1072         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1073         (resolve_dynamic_array): Rename to...
1074         (resolve_dynamic_array_or_string): ...this, update header comment,
1075         and accept TYPE_CODE_STRING.
1076         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1077
1078 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1081         of its implementation from...
1082         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1083         the new function.
1084
1085 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1088         create a range with stride where appropriate.
1089         * f-valprint.c: Include 'gdbarch.h'.
1090         (f77_print_array_1): Take the stride into account when walking the
1091         array.  Also convert the stride into addressable units.
1092         * gdbtypes.c (create_range_type): Initialise the stride to
1093         constant zero.
1094         (create_range_type_with_stride): New function, initialise the
1095         range as normal, and then setup the stride.
1096         (has_static_range): Include the stride here.  Also change the
1097         return type to bool.
1098         (create_array_type_with_stride): Consider the range stride if the
1099         array isn't given its own stride.
1100         (resolve_dynamic_range): Resolve the stride if needed.
1101         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1102         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1103         (TYPE_BIT_STRIDE): Define.
1104         (TYPE_ARRAY_BIT_STRIDE): Define.
1105         (create_range_type_with_stride): Declare.
1106         * valarith.c (value_subscripted_rvalue): Take range stride into
1107         account when walking the array.
1108
1109 2019-12-01  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1112         specially.
1113
1114 2019-12-01  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1117         \0.
1118         * unittests/tui-selftests.c: New file.
1119         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1120
1121 2019-12-01  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1124
1125 2019-12-01  Tom Tromey  <tom@tromey.com>
1126
1127         * NEWS: Document new settings.
1128         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1129         * tui/tui-win.c (_initialize_tui_win): Add border style
1130         observers.
1131         * tui/tui-io.h (tui_apply_style): Declare.
1132         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1133         longer static.
1134         (apply_ansi_escape, tui_set_reverse_mode): Update.
1135         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1136         Add "skip_intensity" parameter.
1137         <changed>: New member.
1138         <do_set_value>: Declare.
1139         (tui_border_style, tui_active_border_style): Declare.
1140         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1141         globals.
1142         (cli_style_option): Initialize "changed".
1143         (cli_style_option::do_set_value): New function.
1144         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1145         parameter.  Update.
1146         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1147         (_initialize_cli_style): Update.  Create TUI border style
1148         commands.
1149
1150 2019-12-01  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1153         parameter.
1154         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1155         parameter.
1156         * tui/tui-win.h (compact_source): Declare.
1157         * tui/tui-win.c (compact_source): New global.
1158         (tui_set_compact_source, tui_show_compact_source): New functions.
1159         (_initialize_tui_win): Add "compact-source" setting.
1160         * tui/tui-source.c (tui_source_window::set_contents): Handle
1161         compact_source setting.
1162         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1163         * NEWS: Document new setting.
1164
1165 2019-11-30  Tom Tromey  <tom@tromey.com>
1166
1167         * dwarf2read.c (dwarf2_add_field): Include field offset when
1168         computing variant part length.
1169
1170 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1171         * NEWS:  Mention define-prefix.  Tell that command names can now
1172         contain a . character.
1173
1174 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1175
1176         * command.h (valid_cmd_char_p): Declare.
1177         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1178         the check of valid command char.
1179         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1180         valid_cmd_char_p.
1181         * cli/cli-script.c (validate_comname): Likewise.
1182         * completer.c (gdb_completer_command_word_break_characters):
1183         Do not remove . from the word break char, update comments.
1184         (complete_line_internal_1): Use valid_cmd_char_p.
1185         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1186         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1187
1188 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1189
1190         * cli/cli-script.c (do_define_command): Ensure a redefined
1191         prefix command is kept as a prefix command.
1192         (define_prefix_command): New function.
1193         (show_user_1): Report user defined prefixes.
1194         (_initialize_cli_script):  Create the new 'define-prefix' command.
1195         Add completers for 'define' and 'document'.
1196         * top.c (execute_command):  If command is a user-defined prefix only
1197         command, report the list of commands for this prefix command.
1198
1199 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1200
1201         * valops.c (find_oload_champ): Improve debug output.
1202
1203 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1204
1205         * valops.c (find_oload_champ): Print part of debug messages
1206         before the badness vector is std::move'd.
1207
1208 2019-11-28  Tom Tromey  <tom@tromey.com>
1209
1210         * value.c (creal_internal_fn): Fix comment.
1211
1212 2019-11-28  Tom Tromey  <tom@tromey.com>
1213
1214         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1215         flag_bound_evaluated>: Now unsigned.
1216
1217 2019-11-28  Tom Tromey  <tom@tromey.com>
1218
1219         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1220         declare.
1221
1222 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1223
1224         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1225         debug output.
1226         * jit.c (jit_unregister_code): Add debug print to match
1227         `jit_register_code`.
1228
1229 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1230
1231         * NEWS: Mention the new multithreaded symbol loading.
1232
1233 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1234
1235         * maint.c (n_worker_threads): Default to 0.
1236         (worker_threads_disabled): New function.
1237         * maint.h (worker_threads_disabled): New function.
1238         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1239         here if worker_threads_disabled () is true.
1240         (minimal_symbol_reader::install): Skip all threading if
1241         worker_threads_disabled () is true.
1242
1243 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1244
1245         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1246         hash code if possible.
1247         (add_minsym_to_demangled_hash_table): Likewise.
1248         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1249         on the background thread.
1250         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1251         Add these fields.
1252
1253 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1254
1255         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1256         of the mangled name on the background thread.
1257         * symtab.c (symbol_set_names): Allow passing in the hash of the
1258         linkage_name.
1259         * symtab.h (symbol_set_names): Likewise.
1260
1261 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1262
1263         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1264         physnames are computed for inherited DIEs.
1265
1266 2019-11-27  Tom Tromey  <tromey@adacore.com>
1267
1268         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1269         backslashes.
1270         * cp-support.c: Remove unnecessary backslashes.
1271
1272 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1273
1274         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1275         with sym->set_linkage_name.
1276         * coffread.c (coff_read_enum_type): Likewise.
1277         * mdebugread.c (parse_symbol): Likewise.
1278         * stabsread.c (patch_block_stabs): Likewise.
1279         (define_symbol): Likewise.
1280         (read_enum_type): Likewise.
1281         (common_block_end): Likewise.
1282         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1283         function.
1284         (SYMBOL_SET_LINKAGE_NAME): Remove.
1285         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1286         with sym->set_linkage_name.
1287
1288 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1291         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1292         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1293         * NEWS: Mention new MI command.
1294
1295 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1298         '-symbol-info-types', and '-symbol-info-variables'.
1299         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1300         (mi_cmd_symbol_info_types): Declare.
1301         (mi_cmd_symbol_info_variables): Declare.
1302         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1303         (output_debug_symbol): New function.
1304         (output_nondebug_symbol): New function.
1305         (mi_symbol_info): New function.
1306         (mi_info_functions_or_variables): New function.
1307         (mi_cmd_symbol_info_functions): New function.
1308         (mi_cmd_symbol_info_types): New function.
1309         (mi_cmd_symbol_info_variables): New function.
1310         * NEWS: Mention new commands.
1311
1312 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * symtab.c (symbol_to_info_string): New function, most content
1315         moved from print_symbol_info, but updated to return a std::string.
1316         (print_symbol_info): Update to use symbol_to_info_string and print
1317         returned string.
1318         * symtab.h (symbol_to_info_string): Declare new function.
1319
1320 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1321
1322         * python/python.c (gdbpy_rbreak): Convert to using
1323         global_symbol_searcher.
1324         * symtab.c (file_matches): Convert return type to bool, change
1325         file list to std::vector, update header comment.
1326         (search_symbols): Rename to...
1327         (global_symbol_searcher::search): ...this and update now its
1328         a member function of global_symbol_searcher.  Take account of the
1329         changes to file_matches.
1330         (symtab_symbol_info): Convert to using global_symbol_searcher.
1331         (rbreak_command): Likewise.
1332         (search_module_symbols): Likewise.
1333         * symtab.h (enum symbol_search): Update comment.
1334         (search_symbols): Remove declaration.
1335         (class global_symbol_searcher): New class.
1336
1337 2019-11-26  Tom Tromey  <tromey@adacore.com>
1338
1339         * cp-support.c (_initialize_cp_support): Conditionally initialize
1340         gdb_demangle_attempt_core_dump.
1341
1342 2019-11-26  Tom Tromey  <tom@tromey.com>
1343
1344         * python/py-function.c (fnpy_init): Update.
1345         * value.h (add_internal_function): Adjust declaration.
1346         * value.c (function_destroyer): Remove.
1347         (do_add_internal_function): Don't set destroyer or copy name.
1348         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1349         Set name_allocated.
1350         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1351         (cmdpy_init): Set name_allocated.
1352         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1353         member.
1354         (~cmd_list_element): Free "name" if needed.
1355
1356 2019-11-26  Tom Tromey  <tom@tromey.com>
1357
1358         * value.h (add_internal_function): Add new overload.  Move
1359         documentation from value.h.
1360         * value.c (do_add_internal_function): New function.
1361         (add_internal_function): Use it.  Add new overload.
1362         (function_destroyer): Don't free doc.
1363         * python/py-function.c (fnpy_init): Update.
1364
1365 2019-11-26  Tom Tromey  <tom@tromey.com>
1366
1367         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1368         (cmdpy_init): Set "doc_allocated".
1369
1370 2019-11-26  Tom Tromey  <tom@tromey.com>
1371
1372         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1373         name of worker thread.
1374         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1375         pthread_setname_np.
1376         * configure, config.in: Rebuild.
1377
1378 2019-11-26  Tom Tromey  <tom@tromey.com>
1379
1380         * python/python.c (class gdbpy_gil): New.
1381         (struct gdbpy_event): Add constructor, destructor, operator().
1382         (gdbpy_post_event): Use run_on_main_thread.
1383         (gdbpy_initialize_events): Remove.
1384         (do_start_initialization): Update.
1385
1386 2019-11-26  Tom Tromey  <tom@tromey.com>
1387
1388         * NEWS: Add entry.
1389         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1390         commands.  Call update_thread_pool_size.
1391         (update_thread_pool_size, maintenance_set_worker_threads): New
1392         functions.
1393         (n_worker_threads): New global.
1394
1395 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1396             Tom Tromey  <tom@tromey.com>
1397
1398         * minsyms.c (minimal_symbol_reader::install): Use
1399         parallel_for_each.
1400         * gdbsupport/parallel-for.h: New file.
1401         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1402
1403 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1404             Tom Tromey  <tom@tromey.com>
1405
1406         * gdbsupport/thread-pool.h: New file.
1407         * gdbsupport/thread-pool.c: New file.
1408         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1409         (HFILES_NO_SRCDIR): Add thread-pool.h.
1410
1411 2019-11-26  Tom Tromey  <tom@tromey.com>
1412
1413         * event-top.h (thread_local_segv_handler): Declare.
1414         * event-top.c (thread_local_segv_handler): New global.
1415         (install_handle_sigsegv, handle_sigsegv): New functions.
1416         (async_init_signals): Install SIGSEGV handler.
1417         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1418         thread-local.
1419         (report_failed_demangle): New function.
1420         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1421         handler-setting code, instead use segv_handler.  Run warning code
1422         on main thread.
1423
1424 2019-11-26  Tom Tromey  <tom@tromey.com>
1425
1426         * run-on-main-thread.c: New file.
1427         * run-on-main-thread.h: New file.
1428         * unittests/main-thread-selftests.c: New file.
1429         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1430         main-thread-selftests.c.
1431         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1432         (COMMON_SFILES): Add run-on-main-thread.c.
1433
1434 2019-11-26  Tom Tromey  <tom@tromey.com>
1435
1436         * main.c (setup_alternate_signal_stack): Remove.
1437         (captured_main_1): Use gdb::alternate_signal_stack.
1438         * gdbsupport/alt-stack.h: New file.
1439
1440 2019-11-26  Tom Tromey  <tom@tromey.com>
1441
1442         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1443         Remove comment.
1444         (save_original_signals_state, restore_original_signals_state): Use
1445         gdb_sigmask.
1446         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1447         (_initialize_linux_nat): Use gdb_sigmask.
1448         * guile/guile.c (_initialize_guile): Use block_signals.
1449         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1450         * gdbsupport/gdb-sigmask.h: New file.
1451         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1452         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1453         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1454         pthread_sigmask.
1455         * configure, config.in: Rebuild.
1456         * gdbsupport/block-signals.h: New file.
1457
1458 2019-11-26  Tom Tromey  <tom@tromey.com>
1459
1460         * acinclude.m4: Include ax_pthread.m4.
1461         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1462         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1463         (CLIBS): Use PTHREAD_LIBS.
1464         (aclocal_m4_deps): Add ax_pthread.m4.
1465         * config.in, configure: Rebuild.
1466         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1467
1468 2019-11-26  Tom Tromey  <tom@tromey.com>
1469
1470         * symtab.h (struct minimal_symbol) <name_set>: New member.
1471         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1472         Don't call symbol_set_names.
1473         (minimal_symbol_reader::install): Call symbol_set_names.
1474
1475 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1478         restore_active_ext_lang, as GIL is needed for (indirectly)
1479         called PyOS_InterruptOccurred.
1480
1481 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1482
1483         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1484         definition.
1485
1486 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * remote-sim.c (simulator_command): Make static, remove
1489         declaration.
1490
1491 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1492
1493         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1494         static.
1495         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1496         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1497         (main): Likewise.
1498         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1499         (main): Likewise.
1500         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1501         (main): Likewise.
1502         * unittests/basic_string_view/element_access/char/1.cc (test01):
1503         Likewise.
1504         (main): Likewise.
1505         * unittests/basic_string_view/element_access/char/empty.cc (main):
1506         Likewise.
1507         * unittests/basic_string_view/element_access/char/front_back.cc
1508         (test01): Likewise.
1509         (main): Likewise.
1510         * unittests/basic_string_view/inserters/char/2.cc (test05):
1511         Likewise.
1512         (main): Likewise.
1513         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1514         (test01): Likewise.
1515         (main): Likewise.
1516         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1517         (test01): Likewise.
1518         (main): Likewise.
1519         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1520         Likewise.
1521         * unittests/basic_string_view/operations/compare/char/1.cc
1522         (test01): Likewise.
1523         (main): Likewise.
1524         * unittests/basic_string_view/operations/compare/char/13650.cc
1525         (test01): Likewise.
1526         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1527         Likewise.
1528         (main): Likewise.
1529         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1530         Likewise.
1531         (main): Likewise.
1532         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1533         Likewise.
1534         (main): Likewise.
1535         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1536         Likewise.
1537         (main): Likewise.
1538         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1539         Likewise.
1540         (main): Likewise.
1541         * unittests/basic_string_view/operations/find/char/4.cc (main):
1542         Likewise.
1543         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1544         Likewise.
1545         (main): Likewise.
1546         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1547         Likewise.
1548         (main): Likewise.
1549         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1550         Likewise.
1551         (main): Likewise.
1552         * unittests/basic_string_view/operations/substr/char/1.cc
1553         (test01): Likewise.
1554         (main): Likewise.
1555         * unittests/basic_string_view/operators/char/2.cc (main):
1556         Likewise.
1557         * unittests/optional/assignment/1.cc (test): Likewise.
1558         * unittests/optional/assignment/2.cc (test): Likewise.
1559         * unittests/optional/assignment/3.cc (test): Likewise.
1560         * unittests/optional/assignment/4.cc (test): Likewise.
1561         * unittests/optional/assignment/5.cc (test): Likewise.
1562         * unittests/optional/assignment/6.cc (test): Likewise.
1563         * unittests/optional/assignment/7.cc (test): Likewise.
1564         * unittests/optional/cons/copy.cc (test): Likewise.
1565         * unittests/optional/cons/default.cc (test): Likewise.
1566         * unittests/optional/cons/move.cc (test): Likewise.
1567         * unittests/optional/cons/value.cc (test): Likewise.
1568         * unittests/optional/in_place.cc (test): Likewise.
1569         * unittests/optional/observers/1.cc (test): Likewise.
1570         * unittests/optional/observers/2.cc (test): Likewise.
1571
1572 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1573
1574         * tui-win.h (tui_set_var_cmd): Remove.
1575         * tui-win.c (tui_set_var_cmd): Make static.
1576
1577 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1578
1579         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1580         rbreak_command_wrapper): Remove.
1581         * symtab.c (rbreak_command_wrapper): Remove.
1582
1583 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1584
1585         * inferior.h (info_terminal_command): Remove declaration.
1586         * inflow.c (info_terminal_command): Make static.
1587
1588 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1589
1590         * inferior.c (exit_inferior_silent): Remove.
1591
1592 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1593
1594         * dictionary.c (dict_empty, mdict_empty): Remove.
1595         * dictionary.c (mdict_empty): Remove.
1596
1597 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1598
1599          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1600          (arc_insn_get_memory_offset): Likewise.
1601          (arc_insn_dump): Likewise.
1602          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1603          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1604          * dictionary.c (dict_iterator_next): Likewise.
1605          (dict_iter_match_first): Likewise.
1606          (dict_iter_match_next): Likewise.
1607          * f-lang.c (evaluate_subexp_f): Likewise.
1608          * hppa-tdep.c (hppa_read_pc): Likewise.
1609          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1610          * parse.c (write_exp_elt_msym): Likewise.
1611          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1612          * remote.c (remote_packet_size): Likewise.
1613          (remote_notif_stop_parse): Likewise.
1614          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1615          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1616          * source.c (prepare_path_for_appending): Likewise.
1617          * sparc64-linux-tdep.c
1618          (sparc64_linux_handle_segmentation_fault); Likewise.
1619          * stack.c (frame_selection_by_function_completer): Likewise.
1620
1621 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1622
1623         * completer.c (set_gdb_completion_word_break_characters):
1624         Remove.
1625
1626 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1627
1628         * dwarf-index-write.c: Include dwarf-index-write.h.
1629         * mi/mi-interp.c: Include mi/mi-interp.h.
1630
1631 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1632
1633         * aarch32-tdep.c: Include aarch32-tdep.h.
1634         * aarch32-tdep.h: Forward-declare struct target_desc.
1635
1636 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1637
1638         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1639         strerror.
1640         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1641         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1642
1643 2019-11-25  Tom de Vries  <tdevries@suse.de>
1644
1645         * contrib/words.sh: Add -c option.
1646
1647 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1648
1649         * solib.c (solib_find_1): Change int to bool.
1650         (exec_file_find): Change int to bool.
1651         (solib_find): Change int to bool.
1652         (solib_read_symbols): Change int to bool.
1653         (solib_used): Change int to bool.
1654         (solib_add): Change int to bool.
1655         (info_sharedlibrary_command): Change int to bool.
1656         (solib_contains_address_p): Change int to bool.
1657         (solib_keep_data_in_core): Change int to bool.
1658         (in_solib_dynsym_resolve_code): Change int to bool.
1659         (reload_shared_libraries_1): Change int to bool.
1660         (gdb_sysroot_changed): Change int to bool.
1661         * solib.h (solib_read_symbols): Change int to bool.
1662         (solib_contains_address_p): Change int to bool.
1663         (solib_keep_data_in_core): Change int to bool.
1664         (in_solib_dynsym_resolve_code): Change int to bool.
1665         (libpthread_name_p): Change int to bool.
1666
1667 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1668
1669         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1670         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1671         (remote_packet_max_chars): New static global.
1672         (show_remote_packet_max_chars): New function.
1673         (remote_target::putpkt_binary): Adjust to use new
1674         remote_packet_max_chars option.
1675         (remote_target::getpkt_or_notif_sane_1): Likewise.
1676         (_initialize_remote): Register new remote-packet-max-chars option.
1677
1678 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1679
1680         * m68k-linux-nat.c: Include gdbarch.h.
1681
1682 2019-11-24  Tom Tromey  <tom@tromey.com>
1683
1684         * symfile.c (read_symbols): Update.
1685         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1686         bool.
1687         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1688         (psym_lookup_symbol, psym_find_last_source_symtab)
1689         (psym_forget_cached_source_info, psym_print_stats)
1690         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1691         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1692         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1693         (psym_find_compunit_symtab_by_address)
1694         (maintenance_print_psymbols, maintenance_info_psymtabs)
1695         (maintenance_check_psymtabs): Update.
1696         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1697         bool.
1698
1699 2019-11-22  Tom Tromey  <tom@tromey.com>
1700
1701         * observable.h: Update comments.
1702
1703 2019-11-22  Tom Tromey  <tromey@adacore.com>
1704
1705         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1706         (print_ada_task_info): Don't try to fetch thread id if task is not
1707         alive.
1708
1709 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1710
1711         * ada-exp.y: Update.
1712         * ada-lang.c (sort_choices): Update.
1713         (ada_print_symbol_signature): Update.
1714         (resolve_subexp): Update.
1715         (ada_parse_renaming): Update.
1716         (ada_read_renaming_var_value): Update.
1717         (lesseq_defined_than): Update.
1718         (remove_extra_symbols): Update.
1719         (remove_irrelevant_renamings): Update.
1720         (ada_add_block_symbols): Update.
1721         (ada_collect_symbol_completion_matches): Update.
1722         (ada_is_renaming_symbol): Update.
1723         (aggregate_assign_from_choices): Update.
1724         (ada_evaluate_subexp): Update.
1725         (ada_has_this_exception_support): Update.
1726         (ada_is_non_standard_exception_sym): Update.
1727         (ada_add_exceptions_from_frame): Update.
1728         (ada_add_global_exceptions): Update.
1729         (ada_print_subexp): Update.
1730         * ax-gdb.c (gen_var_ref): Update.
1731         (gen_maybe_namespace_elt): Update.
1732         (gen_expr_for_cast): Update.
1733         (gen_expr): Update.
1734         * block.h: Update.
1735         * blockframe.c (find_pc_partial_function): Update.
1736         * breakpoint.c (print_breakpoint_location): Update.
1737         (update_static_tracepoint): Update.
1738         * btrace.c (ftrace_print_function_name): Update.
1739         (ftrace_function_switched): Update.
1740         * buildsym.c (find_symbol_in_list): Update.
1741         * c-exp.y: Update.
1742         * c-typeprint.c (c_print_typedef): Update.
1743         (c_type_print_template_args): Update.
1744         * cli/cli-cmds.c (edit_command): Update.
1745         (list_command): Update.
1746         (print_sal_location): Update.
1747         * coffread.c (patch_opaque_types): Update.
1748         (process_coff_symbol): Update.
1749         (coff_read_enum_type): Update.
1750         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1751         (convert_one_symbol): Update.
1752         (hash_symname): Update.
1753         (eq_symname): Update.
1754         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1755         * compile/compile-cplus-types.c (debug_print_scope): Update.
1756         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1757         * compile/compile-object-load.c (get_out_value_type): Update.
1758         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1759         (search_symbol_list): Update.
1760         (cp_lookup_symbol_imports_or_template): Update.
1761         * cp-support.c (overload_list_add_symbol): Update.
1762         * ctfread.c (psymtab_to_symtab): Update.
1763         * dbxread.c (cp_set_block_scope): Update.
1764         * dictionary.c (iter_match_first_hashed): Update.
1765         (iter_match_next_hashed): Update.
1766         (insert_symbol_hashed): Update.
1767         (iter_match_next_linear): Update.
1768         * dictionary.h: Update.
1769         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1770         (locexpr_describe_location_piece): Update.
1771         (locexpr_describe_location_1): Update.
1772         (locexpr_generate_c_location): Update.
1773         (loclist_describe_location): Update.
1774         (loclist_generate_c_location): Update.
1775         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1776         (read_func_scope): Update.
1777         (process_enumeration_scope): Update.
1778         (new_symbol): Update.
1779         (dwarf2_const_value): Update.
1780         (dwarf2_symbol_mark_computed): Update.
1781         * eval.c (evaluate_funcall): Update.
1782         (evaluate_subexp_standard): Update.
1783         * expprint.c (print_subexp_standard): Update.
1784         (dump_subexp_body_standard): Update.
1785         * f-valprint.c (info_common_command_for_block): Update.
1786         * findvar.c (get_hosting_frame): Update.
1787         (default_read_var_value): Update.
1788         * go-lang.c (go_symbol_package_name): Update.
1789         * guile/scm-block.c (bkscm_print_block_smob): Update.
1790         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1791         (gdbscm_symbol_name): Update.
1792         (gdbscm_symbol_linkage_name): Update.
1793         (gdbscm_symbol_print_name): Update.
1794         * infcall.c (get_function_name): Update.
1795         * infcmd.c (jump_command): Update.
1796         (finish_command): Update.
1797         * infrun.c (insert_exception_resume_breakpoint): Update.
1798         * linespec.c (canonicalize_linespec): Update.
1799         (create_sals_line_offset): Update.
1800         (convert_linespec_to_sals): Update.
1801         (complete_label): Update.
1802         (find_label_symbols_in_block): Update.
1803         * m2-typeprint.c (m2_print_typedef): Update.
1804         * mdebugread.c (mdebug_reg_to_regnum): Update.
1805         (parse_symbol): Update.
1806         (mylookup_symbol): Update.
1807         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1808         (list_args_or_locals): Update.
1809         * objc-lang.c (compare_selectors): Update.
1810         (info_selectors_command): Update.
1811         (compare_classes): Update.
1812         (info_classes_command): Update.
1813         (find_imps): Update.
1814         * p-typeprint.c (pascal_print_typedef): Update.
1815         * printcmd.c (build_address_symbolic): Update.
1816         (info_address_command): Update.
1817         (print_variable_and_value): Update.
1818         * python/py-framefilter.c (extract_sym): Update.
1819         (py_print_single_arg): Update.
1820         * python/py-symbol.c (sympy_str): Update.
1821         (sympy_get_name): Update.
1822         (sympy_get_linkage_name): Update.
1823         * python/python.c (gdbpy_rbreak): Update.
1824         * record-btrace.c (btrace_get_bfun_name): Update.
1825         (btrace_call_history): Update.
1826         * rust-lang.c (rust_print_typedef): Update.
1827         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1828         * stabsread.c (stab_reg_to_regnum): Update.
1829         (define_symbol): Update.
1830         (read_enum_type): Update.
1831         (common_block_end): Update.
1832         (cleanup_undefined_types_1): Update.
1833         (scan_file_globals): Update.
1834         * stack.c (print_frame_arg): Update.
1835         (print_frame_args): Update.
1836         (find_frame_funname): Update.
1837         (info_frame_command_core): Update.
1838         (iterate_over_block_locals): Update.
1839         (print_block_frame_labels): Update.
1840         (do_print_variable_and_value): Update.
1841         (iterate_over_block_arg_vars): Update.
1842         (return_command): Update.
1843         * symmisc.c (dump_symtab_1): Update.
1844         (print_symbol): Update.
1845         * symtab.c (eq_symbol_entry): Update.
1846         (symbol_cache_dump): Update.
1847         (lookup_language_this): Update.
1848         (find_pc_sect_line): Update.
1849         (skip_prologue_sal): Update.
1850         (symbol_search::compare_search_syms): Update.
1851         (treg_matches_sym_type_name): Update.
1852         (search_symbols): Update.
1853         (print_symbol_info): Update.
1854         (rbreak_command): Update.
1855         (completion_list_add_symbol): Update.
1856         (find_gnu_ifunc): Update.
1857         (get_symbol_address): Update.
1858         (search_module_symbols): Update.
1859         (info_module_subcommand): Update.
1860         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1861         (SYMBOL_LINKAGE_NAME): Remove.
1862         (SYMBOL_DEMANGLED_NAME): Remove.
1863         (SYMBOL_PRINT_NAME): Remove.
1864         (SYMBOL_SEARCH_NAME): Remove.
1865         * tracepoint.c (set_traceframe_context): Update.
1866         (validate_actionline): Update.
1867         (collection_list::collect_symbol): Update.
1868         (encode_actions_1): Update.
1869         (info_scope_command): Update.
1870         (print_one_static_tracepoint_marker): Update.
1871         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1872         * valops.c (address_of_variable): Update.
1873         (find_overload_match): Update.
1874         (find_oload_champ): Update.
1875
1876 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1877
1878         * ada-lang.c (ada_lookup_simple_minsym): Update.
1879         (ada_collect_symbol_completion_matches): Update.
1880         * ada-tasks.c (read_atcb): Update.
1881         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1882         (amd64_windows_skip_trampoline_code): Update.
1883         * arm-tdep.c (skip_prologue_function): Update.
1884         (arm_skip_stack_protector): Update.
1885         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1886         (arm_wince_skip_main_prologue): Update.
1887         * ax-gdb.c (gen_expr): Update.
1888         * block.c (call_site_for_pc): Update.
1889         * blockframe.c (find_pc_partial_function): Update.
1890         * breakpoint.c (set_breakpoint_location_function): Update.
1891         * btrace.c (ftrace_print_function_name): Update.
1892         (ftrace_function_switched): Update.
1893         * c-valprint.c (print_unpacked_pointer): Update.
1894         * coffread.c (coff_symfile_read): Update.
1895         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1896         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1897         * dwarf-index-write.c (write_psymbols): Update.
1898         * dwarf2loc.c (call_site_to_target_addr): Update.
1899         (func_verify_no_selftailcall): Update.
1900         (tailcall_dump): Update.
1901         (call_site_find_chain_1): Update.
1902         (dwarf_expr_reg_to_entry_parameter): Update.
1903         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1904         * eval.c (evaluate_funcall): Update.
1905         (evaluate_subexp_standard): Update.
1906         (evaluate_subexp_for_sizeof): Update.
1907         * expprint.c (print_subexp_standard): Update.
1908         (dump_subexp_body_standard): Update.
1909         * frame.c (get_prev_frame_always_1): Update.
1910         * frv-tdep.c (frv_skip_main_prologue): Update.
1911         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1912         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1913         (gnuv3_get_typename_from_type_info): Update.
1914         (gnuv3_skip_trampoline): Update.
1915         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1916         * i386-tdep.c (i386_skip_main_prologue): Update.
1917         (i386_pe_skip_trampoline_code): Update.
1918         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1919         * infcall.c (get_function_name): Update.
1920         * linespec.c (minsym_found): Update.
1921         * linux-fork.c (info_checkpoints_command): Update.
1922         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1923         (m32c_m16c_pointer_to_address): Update.
1924         * maint.c (maintenance_translate_address): Update.
1925         * minsyms.c (add_minsym_to_hash_table): Update.
1926         (add_minsym_to_demangled_hash_table): Update.
1927         (lookup_minimal_symbol_mangled): Update.
1928         (lookup_minimal_symbol_demangled): Update.
1929         (lookup_minimal_symbol_linkage): Update.
1930         (lookup_minimal_symbol_text): Update.
1931         (lookup_minimal_symbol_by_pc_name): Update.
1932         (minimal_symbol_is_less_than): Update.
1933         (compact_minimal_symbols): Update.
1934         (build_minimal_symbol_hash_tables): Update.
1935         (find_solib_trampoline_target): Update.
1936         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1937         (mips_skip_pic_trampoline_code): Update.
1938         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1939         * objc-lang.c (info_selectors_command): Update.
1940         (info_classes_command): Update.
1941         (find_methods): Update.
1942         (find_imps): Update.
1943         * p-valprint.c (pascal_val_print): Update.
1944         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1945         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1946         * printcmd.c (build_address_symbolic): Update.
1947         (info_symbol_command): Update.
1948         * psymtab.c (psymbol_name_matches): Update.
1949         (match_partial_symbol): Update.
1950         (lookup_partial_symbol): Update.
1951         (print_partial_symbols): Update.
1952         (sort_pst_symbols): Update.
1953         (maintenance_check_psymtabs): Update.
1954         * python/py-framefilter.c (py_print_frame): Update.
1955         * python/python.c (gdbpy_rbreak): Update.
1956         * record-btrace.c (btrace_get_bfun_name): Update.
1957         (btrace_call_history): Update.
1958         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1959         (rs6000_skip_trampoline_code): Update.
1960         * sol-thread.c (info_cb): Update.
1961         * stabsread.c (scan_file_globals): Update.
1962         * stack.c (find_frame_funname): Update.
1963         (info_frame_command_core): Update.
1964         * symmisc.c (dump_msymbols): Update.
1965         * symtab.c (symbol_natural_name): Rename to..,
1966         (general_symbol_info::natural_name): ...this.
1967         (symbol_demangled_name): Rename to...
1968         (general_symbol_info::demangled_name): ...this.
1969         (symbol_search_name): Rename to...
1970         (general_symbol_info::search_name): ...this.
1971         (symbol_matches_search_name): Update.
1972         (find_pc_sect_line): Update.
1973         (skip_prologue_sal): Update.
1974         (search_symbols): Update.
1975         (print_msymbol_info): Update.
1976         (rbreak_command): Update.
1977         (completion_list_add_msymbol): Update.
1978         (completion_list_objc_symbol): Update.
1979         (get_msymbol_address): Update.
1980         * symtab.h (struct general_symbol_info): Add member functions
1981         natural_name (), linkage_name (), print_name (), demangled_name (),
1982         and search_name ().
1983         (SYMBOL_NATURAL_NAME): Update.
1984         (symbol_natural_name): Move to a member function on general_symbol_info.
1985         (SYMBOL_DEMANGLED_NAME): Update.
1986         (symbol_demangled_name): Move to a member function on
1987         general_symbol_info.
1988         (SYMBOL_SEARCH_NAME): Update.
1989         (symbol_search_name): Move to a member function on general_symbol_info.
1990         (MSYMBOL_NATURAL_NAME): Remove.
1991         (MSYMBOL_LINKAGE_NAME): Remove.
1992         (MSYMBOL_PRINT_NAME): Remove.
1993         (MSYMBOL_DEMANGLED_NAME): Remove.
1994         (MSYMBOL_SEARCH_NAME): Remove.
1995         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1996
1997 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1998
1999         * symtab.c (create_demangled_names_hash): Use per_bfd->
2000         minimal_symbol_count for computing the initial size, if greater
2001         than our default size.
2002
2003 2019-11-22  Tom de Vries  <tdevries@suse.de>
2004
2005         * contrib/words.sh: Improve words extraction.
2006
2007 2019-11-22  Tom de Vries  <tdevries@suse.de>
2008
2009         * contrib/words.sh: Combine sed invocations.
2010
2011 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2012
2013         * Makefile.in: Update.
2014         * demangle.c: Rename to...
2015         * gdb-demangle.c: ..this.
2016         (is_cplus_marker): Change return type to bool.
2017         (_initialize_demangler): Rename to...
2018         (_initialize_gdb_demangle): ...this.
2019         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2020         * symtab.h (demangle): Remove declaration; instead include
2021         gdb-demangle.h.
2022
2023 2019-11-21  Tom Tromey  <tromey@adacore.com>
2024
2025         * gdbsupport/format.c (format_pieces): Parse %I64d.
2026         * unittests/format_pieces-selftests.c (test_windows_formats): New
2027         function.
2028         (run_tests): Call it.
2029
2030 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2031
2032         Byte reverse display of variables with DW_END_big, DW_END_little
2033         (DW_AT_endianity) dwarf attributes if different than the native
2034         byte order.
2035         * ada-lang.c (ada_value_binop):
2036         Use type_byte_order instead of gdbarch_byte_order.
2037         * ada-valprint.c (printstr):
2038         (ada_val_print_string):
2039         * ada-lang.c (value_pointer):
2040         (ada_value_binop):
2041         Use type_byte_order instead of gdbarch_byte_order.
2042         * c-lang.c (c_get_string):
2043         Use type_byte_order instead of gdbarch_byte_order.
2044         * c-valprint.c (c_val_print_array):
2045         Use type_byte_order instead of gdbarch_byte_order.
2046         * cp-valprint.c (cp_print_class_member):
2047         Use type_byte_order instead of gdbarch_byte_order.
2048         * dwarf2loc.c (rw_pieced_value):
2049         Use type_byte_order instead of gdbarch_byte_order.
2050         * dwarf2read.c (read_base_type): Handle DW_END_big,
2051         DW_END_little
2052         * f-lang.c (f_get_encoding):
2053         Use type_byte_order instead of gdbarch_byte_order.
2054         * findvar.c (default_read_var_value):
2055         Use type_byte_order instead of gdbarch_byte_order.
2056         * gdbtypes.c (check_types_equal):
2057         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2058         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2059         and TYPE_ENDIANITY_LITTLE if set.
2060         (type_byte_order): new function.
2061         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2062         (struct main_type) <flag_endianity_not_default>:
2063         New field.
2064         (type_byte_order): New function.
2065         * infcmd.c (default_print_one_register_info):
2066         Use type_byte_order instead of gdbarch_byte_order.
2067         * p-lang.c (pascal_printstr):
2068         Use type_byte_order instead of gdbarch_byte_order.
2069         * p-valprint.c (pascal_val_print):
2070         Use type_byte_order instead of gdbarch_byte_order.
2071         * printcmd.c (print_scalar_formatted):
2072         Use type_byte_order instead of gdbarch_byte_order.
2073         * solib-darwin.c (darwin_current_sos):
2074         Use type_byte_order instead of gdbarch_byte_order.
2075         * solib-svr4.c (solib_svr4_r_ldsomap):
2076         Use type_byte_order instead of gdbarch_byte_order.
2077         * stap-probe.c (stap_modify_semaphore):
2078         Use type_byte_order instead of gdbarch_byte_order.
2079         * target-float.c (target_float_same_format_p):
2080         Use type_byte_order instead of gdbarch_byte_order.
2081         * valarith.c (scalar_binop):
2082         (value_bit_index):
2083         Use type_byte_order instead of gdbarch_byte_order.
2084         * valops.c (value_cast):
2085         Use type_byte_order instead of gdbarch_byte_order.
2086         * valprint.c (generic_emit_char):
2087         (generic_printstr):
2088         (val_print_string):
2089         Use type_byte_order instead of gdbarch_byte_order.
2090         * value.c (unpack_long):
2091         (unpack_bits_as_long):
2092         (unpack_value_bitfield):
2093         (modify_field):
2094         (pack_long):
2095         (pack_unsigned_long):
2096         Use type_byte_order instead of gdbarch_byte_order.
2097         * findvar.c (unsigned_pointer_to_address):
2098         (signed_pointer_to_address):
2099         (unsigned_address_to_pointer):
2100         (address_to_signed_pointer):
2101         (default_read_var_value):
2102         (default_value_from_register):
2103         Use type_byte_order instead of gdbarch_byte_order.
2104         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2105         Use type_byte_order instead of gdbarch_byte_order.
2106         * riscv-tdep.c (riscv_print_one_register_info):
2107         Use type_byte_order instead of gdbarch_byte_order.
2108
2109 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2110
2111         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2112         (current_ui_gdb_stdin_ptr): Likewise.
2113         (current_ui_gdb_stderr_ptr): Likewise.
2114         (current_ui_gdb_stdlog_ptr): Likewise.
2115         (current_ui_current_uiout_ptr): Likewise.
2116         (gen_ret_current_ui_field_ptr): Remove.
2117
2118 2019-11-21  Tom de Vries  <tdevries@suse.de>
2119
2120         PR gdb/24956
2121         * cli/cli-script.c (execute_control_command): Only switch to
2122         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2123
2124 2019-11-19  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2127         Now static.  Change type of "name".
2128         (tui_set_win_height_command): Don't copy "arg".
2129         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2130         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2131
2132 2019-11-19  Ali Tamur <tamur@google.com>
2133
2134         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2135         "if (attr != nullptr)".
2136         (dwarf2_find_base_address): Likewise.
2137         (dwarf2_build_include_psymtabs): Likewise.
2138         (read_cutu_die_from_dwo): Likewise.
2139         (read_func_scope): Likewise.
2140         (read_call_site_scope): Likewise.
2141         (dwarf2_get_pc_bounds): Likewise.
2142         (dwarf2_record_block_ranges): Likewise.
2143         (dwarf2_add_field): Likewise.
2144         (dwarf2_add_member_fn): Likewise.
2145         (read_structure_type): Likewise.
2146         (read_enumeration_type): Likewise.
2147         (read_array_type): Likewise.
2148         (read_array_order): Likewise.
2149         (read_set_type): Likewise.
2150         (read_common_block): Likewise.
2151         (read_tag_reference_type): Likewise.
2152         (read_tag_string_type): Likewise.
2153         (read_subroutine_type): Likewise.
2154         (read_base_type): Likewise.
2155         (read_subrange_type): Likewise.
2156         (new_symbol): Likewise.
2157         (prepare_one_comp_unit): Likewise.
2158
2159 2019-11-19  Tom Tromey  <tromey@adacore.com>
2160
2161         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2162         result in error when DebugActiveProcess fails.
2163
2164 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2165             Pedro Alves  <palves@redhat.com>
2166
2167         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2168         * target.c (target_stack::push): Call 'unpush' if there's a
2169         target on top of the stack.
2170
2171 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2172
2173         * python/py-block.c (blpy_dealloc): Call tp_free.
2174         (blpy_block_syms_dealloc): Likewise.
2175         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2176         * python/py-inferior.c (infpy_dealloc): Likewise.
2177         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2178         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2179         * python/py-symbol.c (sympy_dealloc): Likewise.
2180         * python/py-symtab.c (stpy_dealloc): Likewise.
2181         * python/py-type.c (typy_iterator_dealloc): Likewise.
2182
2183 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2184
2185         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2186         constructor instead of using a class initializer.
2187
2188 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2189
2190         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2191         * configure: Regenerate.
2192         * configure.ac: Don't source common.host.
2193         * gdbsupport/common.host: Remove.
2194         * gdbsupport/mingw-strerror.c: Remove.
2195         * gdbsupport/posix-strerror.c: Rename to...
2196         * gdbsupport/safe-strerror.c: ...this.
2197
2198 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2199
2200         * maint.c (scoped_command_stats::print_time): Use localtime_r
2201         instead of localtime (provided through gnulib if necessary).
2202         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2203         of ctime.
2204
2205 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2206
2207         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2208         avoid compile errors.
2209
2210 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * config.in: Regenerate.
2213         * configure: Regenerate.
2214         * gdbsupport/common.m4: No longer check for strerror_r.
2215         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2216         POSIX version of strerror_r, now that gnulib provides it if
2217         necessary.
2218
2219 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2220
2221         * README (`configure' options): Update.
2222
2223 2019-11-14  Tom Tromey  <tromey@adacore.com>
2224
2225         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2226         expected type for the RHS if the LHS is a convenience variable.
2227
2228 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2229
2230         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2231         Provide explicit default and copy constructor.
2232
2233 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2234
2235         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2236         only call Py_INCREF (newbp) in the bppy_pending_object case.
2237
2238 2019-11-13  Tom Tromey  <tromey@adacore.com>
2239
2240         PR build/25182:
2241         * psympriv.h (partial_symbol): Remove static assert.
2242         * symtab.h (general_symbol_info, symbol): Remove static assert.
2243
2244 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * gdbsupport/format.c (format_pieces::format_pieces): Support
2247         printf 'z' size modifier.
2248         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2249         * printcmd.c (ui_printf):  Handle size_t_arg.
2250         * ui-out.c (ui_out::vmessage): Likewise.
2251         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2252         function.
2253         (run_tests): Call test_format_int_sizes.
2254
2255 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2256
2257         * ada-exp.y (write_ambiguous_var): Update.
2258         * buildsym.c (add_symbol_to_list): Update.
2259         * dwarf2read.c (read_variable): Update.
2260         (new_symbol): Update.
2261         * jit.c (finalize_symtab): Update.
2262         * language.c (language_alloc_type_symbol): Update.
2263         * symtab.c (fixup_symbol_section): Update.
2264         (initialize_objfile_symbol_1): Move code to...
2265         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2266         (allocate_symbol): Update.
2267         (allocate_template_symbol): Update.
2268         (get_symbol_address): Update.
2269         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2270         of having as a field, and add a constructor.
2271         (SYMBOL_VALUE): Update.
2272         (SYMBOL_VALUE_ADDRESS): Update.
2273         (SET_SYMBOL_VALUE_ADDRESS): Update.
2274         (SYMBOL_VALUE_BYTES): Update.
2275         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2276         (SYMBOL_BLOCK_VALUE): Update.
2277         (SYMBOL_VALUE_CHAIN): Update.
2278         (SYMBOL_LANGUAGE): Update.
2279         (SYMBOL_SECTION): Update.
2280         (SYMBOL_OBJ_SECTION): Update.
2281         (SYMBOL_SET_LANGUAGE): Update.
2282         (SYMBOL_SET_LINKAGE_NAME): Update.
2283         (SYMBOL_SET_NAMES): Update.
2284         (SYMBOL_NATURAL_NAME): Update.
2285         (SYMBOL_LINKAGE_NAME): Update.
2286         (SYMBOL_DEMANGLED_NAME): Update.
2287         (SYMBOL_SEARCH_NAME): Update.
2288         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2289         (struct symbol): Update.
2290         (struct template_symbol): Update.
2291         (struct rust_vtable_symbol): Update.
2292         * xcoffread.c (SYMBOL_DUP): Update.
2293
2294 2019-11-12  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-layout.c (show_layout): Set current_layout.
2297         (show_source_disasm_command, show_data)
2298         (show_source_or_disasm_and_command): Don't set current_layout.
2299
2300 2019-11-12  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2303
2304 2019-11-12  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-win.c (resize_message): New global.
2307         (show_tui_resize_message): New function.
2308         (tui_async_resize_screen): Print message if requested.
2309         (_initialize_tui_win): Add tui-resize-message setting.
2310         * NEWS: Add entry for new commands.
2311
2312 2019-11-11  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2315         functions.
2316
2317 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2318
2319         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2320
2321 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2324         function.
2325         * python/python-internal.h (gdbpy_lookup_static_symbols):
2326         Declare new function.
2327         * python/python.c (python_GdbMethods): Add
2328         gdb.lookup_static_symbols method.
2329         * NEWS: Mention gdb.lookup_static_symbols.
2330
2331 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2334         static block of current object file first.  Also fix typo in
2335         header comment.
2336
2337 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * stack.c (set_last_displayed_sal): Delete.
2340         (last_displayed_sal_valid): Delete.
2341         (last_displayed_pspace): Delete.
2342         (last_displayed_addr): Delete.
2343         (last_displayed_symtab): Delete.
2344         (last_displayed_line): Delete.
2345         (class last_displayed_symtab_info_type): New.
2346         (last_displayed_symtab_info): New static global variable.
2347         (print_frame_info): Call methods on last_displayed_symtab_info.
2348         (clear_last_displayed_sal): Update header comment, and make use of
2349         last_displayed_symtab_info.
2350         (last_displayed_sal_is_valid): Likewise.
2351         (get_last_displayed_pspace): Likewise.
2352         (get_last_displayed_addr): Likewise.
2353         (get_last_displayed_symtab): Likewise.
2354         (get_last_displayed_line): Likewise.
2355         (get_last_displayed_sal): Likewise.
2356         * stack.h (clear_last_displayed_sal): Update header comment.
2357         (last_displayed_sal_is_valid): Likewise.
2358         (get_last_displayed_pspace): Likewise.
2359         (get_last_displayed_addr): Likewise.
2360         (get_last_displayed_symtab): Likewise.
2361         (get_last_displayed_line): Likewise.
2362         (get_last_displayed_sal): Likewise.
2363
2364 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * stack.c (frame_show_address): Convert return type to bool.
2367         * stack.h (frame_show_address): Likewise, and update header
2368         comment.
2369
2370 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2373         * unittests/vec-utils-selftests.c: New file.
2374         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2375
2376 2019-11-10  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2379         (tui_highlight_win): Likewise.
2380         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2381         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2382         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2383         Don't set can_highlight.
2384
2385 2019-11-10  Tom Tromey  <tom@tromey.com>
2386
2387         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2388         Remove unused declaration.
2389
2390 2019-11-08  Tom Tromey  <tromey@adacore.com>
2391
2392         * top.c (read_command_file): Update.
2393         (command_line_input): Make return type const.
2394         * python/py-gdb-readline.c: Update.
2395         * linespec.c (decode_line_2): Update.
2396         * defs.h (command_line_input): Make return type const.
2397         * cli/cli-script.c (read_next_line): Make return type const.
2398         * ada-lang.c (get_selections): Update.
2399
2400 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2401
2402         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2403         * mi/mi-main.c (output_cores): Likewise.
2404         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2405         (linux_xfer_osdata_modules): Likewise.
2406         * remote.c (register_remote_support_xml): Likewise.
2407         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2408         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2409
2410 2019-11-06  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-interp.c: Don't include readline.h.
2413         * tui/tui-hooks.c: Don't include readline.h.
2414         * symmisc.c: Include tilde.h, not readline.h.
2415         * symfile.c: Include tilde.h, not readline.h.
2416         * source.c: Include tilde.h, not readline.h.
2417         * solib.c: Include tilde.h, not readline.h.
2418         * psymtab.c: Include tilde.h, not readline.h.
2419         * exec.c: Include tilde.h, not readline.h.
2420         * corelow.c: Include tilde.h, not readline.h.
2421         * cli/cli-dump.c: Include tilde.h, not readline.h.
2422         * cli/cli-cmds.c: Don't include readline.h.
2423
2424 2019-11-05  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2427         (tui_disassemble): Set addr_size.
2428         (tui_disasm_window::set_contents): Use addr_size.
2429
2430 2019-11-05  Tom Tromey  <tom@tromey.com>
2431
2432         * rust-lang.c (rust_language_defn): Update.
2433         * python/py-value.c (valpy_string): Call c_get_string.
2434         * p-lang.c (pascal_language_defn): Update.
2435         * opencl-lang.c (opencl_language_defn): Update.
2436         * objc-lang.c (objc_language_defn): Update.
2437         * m2-lang.c (m2_language_defn): Update.
2438         * language.c (unknown_language_defn, auto_language_defn): Update.
2439         (default_get_string): Remove.
2440         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2441         * go-lang.c (go_language_defn): Update.
2442         * f-lang.c (f_language_defn): Update.
2443         * d-lang.c (d_language_defn): Update.
2444         * c-lang.c (c_language_defn, cplus_language_defn)
2445         (asm_language_defn, minimal_language_defn): Update.
2446         * ada-lang.c (ada_language_defn): Update.
2447         * language.h (struct language_defn) <la_get_string>: Remove.
2448         (LA_GET_STRING): Remove.
2449         (default_get_string): Don't declare.
2450
2451 2019-11-05  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-source.h (struct tui_source_window): Inline
2454         constructor.  Remove destructor.
2455         <style_changed, m_observable>: Move to superclass.
2456         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2457         (struct tui_source_window_base): Move private members to end.
2458         <style_changed, m_observable>: Move from tui_source_window.
2459         * tui/tui-winsource.c (tui_copy_source_line): Move from
2460         tui-source.c.  Rename from copy_source_line.  Add special handling
2461         for negative line number.
2462         (tui_source_window_base::style_changed): Move from
2463         tui_source_window.
2464         (tui_source_window_base): Register observer.
2465         (~tui_source_window_base): New.
2466         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2467         rename.
2468         (tui_source_window::set_contents): Use tui_copy_source_line.
2469         (tui_source_window::tui_source_window): Move to tui-source.h.
2470         (tui_source_window::~tui_source_window): Remove.
2471         (tui_source_window::style_changed): Move to superclass.
2472         * tui/tui-disasm.c (tui_disassemble): Create string file with
2473         styling, when possible.  Add "addr_size" parameter.
2474         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2475         Don't compute maximum size.
2476         (len_without_escapes): New function
2477
2478 2019-11-05  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2481         std::string.
2482         * tui/tui-winsource.c (tui_show_source_line): Update.
2483         * tui/tui-source.c (tui_source_window::set_contents): Update.
2484         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2485
2486 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2487
2488         * symtab.h (gdb_static_assert): Put && operator at the beginning
2489         of the line instead of the end.
2490
2491 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2492
2493         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2494         and sizeof (symbol).
2495         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2496
2497 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2498
2499         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2500         * configure.host: Mark *-*-solaris2.10* obsolete.
2501         * configure.tgt: Mark Solaris < 11 obsolete.
2502         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2503         Update target triplet.
2504
2505 2019-11-01  Tom Tromey  <tromey@adacore.com>
2506
2507         * utils.c (print_sys_errmsg): Simplify.
2508
2509 2019-11-01  Tom Tromey  <tromey@adacore.com>
2510
2511         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2512
2513 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2514
2515         * configure: Regenerate.
2516         * configure.ac: Remove check for strerror_r.
2517         * gdbsupport/common.m4: Check for strerror_r.
2518
2519 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2520
2521         PR gdb/25124
2522
2523         * arm-tdep.c (arm_per_objfile): Rename to ...
2524         (arm_per_bfd): ... this.
2525         (arm_objfile_data_key): Rename to ...
2526         (arm_bfd_data_key): ... this.
2527         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2528         data.
2529         (arm_record_special_symbol): Likewise.
2530
2531 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2534         end.
2535         * c-typeprint.c (c_print_typedef): Likewise.
2536         * f-typeprint.c (f_print_typedef): Likewise.
2537         * m2-typeprint.c (m2_print_typedef): Likewise.
2538         * p-typeprint.c (pascal_print_typedef): Likewise.
2539         * rust-lang.c (rust_print_typedef): Likewise.
2540         * symtab.c (print_symbol_info): Print a newline after calling
2541         typedef_print.
2542
2543 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * symtab.c (info_module_cmdlist): New variable.
2546         (info_module_command): New function.
2547         (search_module_symbols): New function.
2548         (info_module_subcommand): New function.
2549         (struct info_modules_var_func_options): New struct.
2550         (info_modules_var_func_options_defs): New variable.
2551         (make_info_modules_var_func_options_def_group): New function.
2552         (info_module_functions_command): New function.
2553         (info_module_variables_command): New function.
2554         (info_module_var_func_command_completer): New function.
2555         (_initialize_symtab): Register new 'info module functions' and
2556         'info module variables' commands.
2557         * symtab.h (typedef symbol_search_in_module): New typedef.
2558         (search_module_symbols): Declare new function.
2559         * NEWS: Mention new commands.
2560
2561 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2564         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2565         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2566         MODULES_DOMAIN.
2567         (scan_partial_symbols): Only create partial module symbols for non
2568         declarations.
2569         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2570         and MODULES_DOMAIN.
2571         * symtab.c (search_domain_name): Likewise.
2572         (search_symbols): Likewise.
2573         (print_symbol_info): Likewise.
2574         (symtab_symbol_info): Likewise.
2575         (info_modules_command): New function.
2576         (_initialize_symtab): Register 'info modules' command.
2577         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2578         * NEWS: Mention new 'info modules' command.
2579
2580 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2581
2582         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2583         and $_gdb_maint_setting_str.
2584
2585 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2586
2587         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2588         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2589         (str_value_from_setting, gdb_setting_str_internal_fn)
2590         (gdb_maint_setting_str_internal_fn): New functions.
2591         (_initialize_cli_cmds): Define the new convenience functions.
2592         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2593         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2594
2595 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2596
2597         * agent.c (set_can_use_agent): When the setting is turned on,
2598         look up agent symbols if we don't have them yet.
2599         (agent_new_objfile): Don't look up agent symbols when the agent
2600         setting is off.
2601
2602 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2603
2604         * config.in: Regenerate.
2605
2606 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2607
2608         * configure: Regenerate.
2609         * configure.ac: Check for strerror_r.
2610         * gdbsupport/common-utils.h (safe_strerror): Change return value
2611         to const char * and document that this function is now threadsafe.
2612         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2613         thread_local and call strerror_r, if available.
2614         * utils.c (perror_string): Update.
2615         (print_sys_errmsg): Update.
2616
2617 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2618
2619         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2620         objfile_key.
2621         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2622         objfile to fetch per-bfd data.
2623         (arm_find_exidx_entry): Likewise.
2624
2625 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2626
2627         * gdbsupport/agent.c (debug_agent): Change type to bool.
2628         (use_agent): Likewise.
2629         (all_agent_symbols_look_up): Likewise.
2630         (agent_loaded_p): Change return value to bool.
2631         (agent_look_up_symbols): Update.
2632         (agent_capability_check): Change return value to bool.
2633         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2634         (debug_agent): Change type to bool.
2635         (use_agent): Likewise.
2636         (agent_capability_check): Change return value to bool.
2637
2638 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2639
2640         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2641         (build_minimal_symbol_hash_tables): Code to clear the table moved
2642         to clear_minimal_symbol_hash_tables.
2643         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2644         when needed.
2645
2646 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2647
2648         * infcmd.c: Remove includes.
2649         * infrun.c: Remove includes.
2650
2651 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2652
2653         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2654         (grow_vect): Remove declaration.
2655         (ada_type_of_array): Remove declaration.
2656         (ada_update_initial_language): Remove declaration.
2657         (ada_fold_name): Remove declaration.
2658         (ada_fill_in_ada_prototype): Remove declaration.
2659         (user_select_syms): Remove declaration.
2660         (get_selections): Remove declaration.
2661         (ada_tag_type): Remove declaration.
2662         (ada_value_tag): Remove declaration.
2663         (ada_is_others_clause): Remove declaration.
2664         (ada_in_variant): Remove declaration.
2665         (ada_value_struct_elt): Remove declaration.
2666         (ada_attribute_name): Remove declaration.
2667         (ada_system_address_type): Remove declaration.
2668         * ada-lang.c (ada_watch_location_expression): Make static.
2669         (GROW_VECT): Move here from ada-lang.h.
2670         (grow_vect): Make static.
2671         (ada_update_initial_language): Make static.
2672         (ada_fold_name): Make static.
2673         (ada_type_of_array): Make static.
2674         (encoded_ordered_before): Move up.
2675         (sort_choices): Move up.
2676         (print_signatures): Move up.
2677         (ada_print_symbol_signature): Move up.
2678         (get_selections): Move up and make static.
2679         (user_select_syms): Move up and make static.
2680         (ada_value_struct_elt): Move up and make static.
2681         (ada_tag_type): Make static.
2682         (ada_value_tag): Make static.
2683         (ada_is_others_clause): Make static.
2684         (ada_in_variant): Make static.
2685         (ada_attribute_name): Make static.
2686
2687 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2688
2689         * ada-lang.c: Remove includes.
2690         * ada-typeprint.c: Remove includes.
2691         * ada-valprint.c: Remove includes.
2692
2693 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2694
2695         * addrmap.c: Add static assertions of type size, moved from
2696         _initialize_addrmap.
2697         (_initialize_addrmap): Remove.
2698
2699 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2700
2701         * coffread.c (record_minimal_symbol): Update.
2702         (process_coff_symbol): Update.
2703         * dbxread.c (read_dbx_symtab): Update.
2704         * dwarf2read.c (add_partial_symbol): Update.
2705         (fixup_go_packaging): Update.
2706         (load_partial_dies): Update.
2707         (new_symbol): Update.
2708         * elfread.c (record_minimal_symbol): Change signature to use
2709         gdb::string_view instead of name+len.
2710         (elf_symtab_read): Update.
2711         (elf_rel_plt_read): Update.
2712         * mdebugread.c (parse_partial_symbols): Update.
2713         (handle_psymbol_enumerators): Update.
2714         (new_symbol): Update.
2715         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2716         to use gdb::string_view instead of name+len.
2717         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2718         * psympriv.h (add_psymbol_to_list): Likewise.
2719         * psymtab.c (add_psymbol_to_bcache): Likewise.
2720         (add_psymbol_to_list): Likewise.
2721         * stabsread.c (define_symbol): Update.
2722         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2723         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2724         (symbol_set_names): Likewise.
2725         * xcoffread.c (scan_xcoff_symtab): Update.
2726
2727 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2728
2729         * symtab.h (symbol_set_names): Document that copy_name must be
2730         set to true for non-nullterminated strings.
2731         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2732         linkage_name if the entry was not found and we need to demangle.
2733
2734 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2735
2736         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2737         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2738         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2739         * gdbsupport/gdb_binary_search.h: New file.
2740
2741 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2742
2743         * NEWS: Mention new --with-system-gdbinit-dir option.
2744         * config.in: Regenerate.
2745         * configure: Regenerate.
2746         * configure.ac: Add new option --with-system-gdbinit-dir.
2747         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2748         for a ".gdb" suffix.
2749         * main.c (get_init_files): Change system_gdbinit argument to
2750         a vector and return the files in SYSTEM_GDBINIT_DIR in
2751         addition to SYSTEM_GDBINIT.
2752         (captured_main_1): Update.
2753         (print_gdb_help): Update.
2754         * top.c (print_gdb_configuration): Also print the value of
2755         SYSTEM_GDBINIT_DIR.
2756
2757 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2758
2759         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2760         that takes gdb::string_view arguments.
2761
2762 2019-10-26  Tom de Vries  <tdevries@suse.de>
2763
2764         * aarch64-linux-tdep.c: Fix typos in comments.
2765         * aarch64-tdep.c: Same.
2766         * ada-lang.c: Same.
2767         * amd64-nat.c: Same.
2768         * arc-tdep.c: Same.
2769         * arch/aarch64-insn.c: Same.
2770         * block.c: Same.
2771         * breakpoint.h: Same.
2772         * btrace.h: Same.
2773         * c-varobj.c: Same.
2774         * cli/cli-decode.c: Same.
2775         * cli/cli-script.c: Same.
2776         * cli/cli-utils.h: Same.
2777         * coff-pe-read.c: Same.
2778         * coffread.c: Same.
2779         * compile/compile-cplus-symbols.c: Same.
2780         * compile/compile-object-run.c: Same.
2781         * completer.c: Same.
2782         * corelow.c: Same.
2783         * cp-support.c: Same.
2784         * demangle.c: Same.
2785         * dwarf-index-write.c: Same.
2786         * dwarf2-frame.c: Same.
2787         * dwarf2-frame.h: Same.
2788         * eval.c: Same.
2789         * frame-base.h: Same.
2790         * frame.h: Same.
2791         * gdbcmd.h: Same.
2792         * gdbtypes.h: Same.
2793         * gnu-nat.c: Same.
2794         * guile/scm-objfile.c: Same.
2795         * i386-tdep.c: Same.
2796         * i386-tdep.h: Same.
2797         * infcall.c: Same.
2798         * infcall.h: Same.
2799         * linux-nat.c: Same.
2800         * m68k-tdep.c: Same.
2801         * macroexp.c: Same.
2802         * memattr.c: Same.
2803         * mi/mi-cmd-disas.c: Same.
2804         * mi/mi-getopt.h: Same.
2805         * mi/mi-main.c: Same.
2806         * minsyms.c: Same.
2807         * nat/aarch64-sve-linux-sigcontext.h: Same.
2808         * objfiles.h: Same.
2809         * ppc-linux-nat.c: Same.
2810         * ppc-linux-tdep.c: Same.
2811         * ppc-tdep.h: Same.
2812         * progspace.h: Same.
2813         * prologue-value.h: Same.
2814         * python/py-evtregistry.c: Same.
2815         * python/py-instruction.h: Same.
2816         * record-btrace.c: Same.
2817         * record-full.c: Same.
2818         * remote.c: Same.
2819         * rs6000-tdep.c: Same.
2820         * ser-tcp.c: Same.
2821         * sol-thread.c: Same.
2822         * sparc-sol2-tdep.c: Same.
2823         * sparc64-tdep.c: Same.
2824         * stabsread.c: Same.
2825         * symfile.c: Same.
2826         * symtab.h: Same.
2827         * target.c: Same.
2828         * tracepoint.c: Same.
2829         * tui/tui-data.h: Same.
2830         * tui/tui-io.c: Same.
2831         * tui/tui-win.c: Same.
2832         * tui/tui.c: Same.
2833         * unittests/rsp-low-selftests.c: Same.
2834         * user-regs.h: Same.
2835         * utils.c: Same.
2836         * utils.h: Same.
2837         * valarith.c: Same.
2838         * valops.c: Same.
2839         * valprint.c: Same.
2840         * valprint.h: Same.
2841         * value.c: Same.
2842         * value.h: Same.
2843         * varobj.c: Same.
2844         * x86-nat.h: Same.
2845         * xtensa-tdep.c: Same.
2846
2847 2019-10-25  Ali Tamur <tamur@google.com>
2848
2849         * charset.c (find_charset_names): Reflect API change.
2850
2851 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2852
2853         * symtab.c (struct demangled_name_entry): Change demangled name
2854         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2855         part of the struct anymore.
2856         (symbol_set_names): No longer obstack allocate + copy the demangled
2857         name, just store the allocated name from bfd.
2858
2859 2019-10-25  Tom Tromey  <tromey@adacore.com>
2860
2861         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2862         (bsearch_cie_cmp, add_cie): Remove.
2863         (find_cie): Reimplement.
2864         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2865         (dwarf2_build_frame_info): Update.
2866
2867 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2868
2869         PR gdb/25126
2870         * symfile.c (reread_symbols): Call forget_cached_source_info to
2871         clear the stale source cache.
2872
2873 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2874
2875         * configure: Regenerate.
2876         * configure.ac: Remove code that sets python_has_threads.
2877
2878 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2879
2880         * config.in: Regenerate.
2881         * configure: Regenerate.
2882         * configure.ac: Remove the code that uses sed to get the python
2883         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2884
2885 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2888         error paths.
2889
2890 2019-10-23  Tom Tromey  <tom@tromey.com>
2891
2892         * arc-tdep.c: Remove ".." from include.
2893         * frv-tdep.c: Remove ".." from include.
2894         * lm32-tdep.c: Remove ".." from include.
2895         * microblaze-tdep.c: Remove ".." from include.
2896         * or1k-tdep.h: Remove ".." from include.
2897         * s12z-tdep.c: Remove ".." from include.
2898         * Makefile.in (OPCODES_CFLAGS): Add comment.
2899         (TOP_CFLAGS): New variable.
2900         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2901
2902 2019-10-23  Tom Tromey  <tom@tromey.com>
2903
2904         * Makefile.in (READLINE_DIR): Update.
2905
2906 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2907
2908         * infcall.c (call_function_by_hand_dummy): Fix the function
2909         comment.  And extract out a code section into...
2910         (reserve_stack_space): ...this new function.
2911
2912 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2913
2914         * infcall.c (value_arg_coerce): Remove an unused parameter.
2915         (call_function_by_hand_dummy): Update the call to
2916         'value_arg_coerce'.
2917
2918 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2919
2920         * infcall.c (call_function_by_hand_dummy): Refactor.
2921
2922 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2923
2924         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2925
2926 2019-10-23  Tom Tromey  <tom@tromey.com>
2927
2928         * configure: Rebuild.
2929         * configure.ac: Don't check for sigprocmask.
2930         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2931
2932 2019-10-23  Tom Tromey  <tom@tromey.com>
2933
2934         * configure: Rebuild.
2935         * acinclude.m4: Use m4_include, not sinclude.
2936
2937 2019-10-23  Tom de Vries  <tdevries@suse.de>
2938
2939         PR breakpoints/24687
2940         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2941
2942 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2943
2944         * symtab.c (struct demangled_name_entry) <language>: Change from
2945         bitfield to regular variable.
2946
2947 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2948
2949         * symtab.c (struct demangled_name_entry): Add a constructor.
2950         (free_demangled_name_entry): New function to call the destructor
2951         for demangled_name_entry.
2952         (create_demangled_names_hash): Pass free_demangled_name_entry to
2953         htab_create_alloc.
2954         (symbol_set_names): Call placement new for demangled_name_entry.
2955         * utils.c: No longer include xxhash.h here, now that fast_hash
2956         is inlined in the header.
2957         * utils.h: Instead, include it here.
2958
2959 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2960
2961         * Makefile.in: Link with libxxhash.
2962         * config.in: Regenerate.
2963         * configure: Regenerate.
2964         * configure.ac: Search for libxxhash.
2965         * utils.c (fast_hash): Use xxhash if present.
2966
2967 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2968
2969         * utils.h (fast_hash): New function.
2970         * symtab.c (hash_demangled_name_entry): Call new function
2971         fast_hash.
2972
2973 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2974
2975         * symtab.c (struct demangled_name_entry): Change type of mangled
2976         to gdb::string_view. Also adds a constructor that takes the
2977         mangled name.
2978         (hash_demangled_name_entry): Update.
2979         (eq_demangled_name_entry): Update.
2980         (free_demangled_name_entry): New function to call the destructor
2981         now that this is not a POD anymore.
2982         (create_demangled_names_hash): Pass free_demangled_name_entry to
2983         htab_create_alloc.
2984         (symbol_set_names): Update.
2985
2986 2019-10-21  Ali Tamur  <tamu@google.com>
2987
2988         * dwarf2read.c (dir_index): Change type.
2989         (file_name_index): Likewise.
2990         (line_header::include_dir_at): Change comment and implementation on
2991         whether it is DWARF 5.
2992         (line_header::is_valid_file_index): New function.
2993         (line_header::file_name_at): Change comment and implementation on
2994         whether it is DWARF 5.
2995         (line_header::file_names): Change to private field renamed as
2996         m_file_names and introduce a new accessor method.
2997         (line_header::file_names_size): New method.
2998         (line_header::include_dirs): Change to private field and rename as
2999         m_include_dirs.
3000         (dw2_get_file_names_reader): Define local var at a smaller scope and
3001         reflect API change.
3002         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3003         (process_structure_scope): Likewise.
3004         (line_header::add_include_dir): Change message and reflect renaming.
3005         (line_header::add_file_name): Likewise.
3006         (read_formatted_entries): Handle DW_FORM_data16.
3007         (dwarf_decode_line_header): Fix line header length calculation.
3008         (psymtab_include_file_name): Change comment and API.
3009         (lnp_state_machine::m_file): Update comment and reflect type change.
3010         (lnp_state_machine::record_line): Reflect type change.
3011         (dwarf_decode_lines): Reflect API change.
3012         (file_file_name): Likewise.
3013         (file_full_name): Likewise.
3014
3015 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3016
3017         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3018
3019 2019-10-21  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3022
3023 2019-10-21  Tom Tromey  <tom@tromey.com>
3024
3025         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3026         NM_H.   Use AC_CONFIG_LINKS.
3027         * configure: Rebuild.
3028         * Makefile.in (NM_H): New variable.
3029         (generated_files): Add NM_H.  Remove gcore.
3030         (nm.h, stamp-nmh): New targets.
3031
3032 2019-10-20  Tom Tromey  <tom@tromey.com>
3033
3034         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3035         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3036         obsolete comment.
3037         (put_objfile_before): Now static.
3038
3039 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3040
3041         * gdbsupport/common-utils.h (startswith): Change return type to
3042         bool.
3043
3044 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3045
3046         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3047         * breakpoint.c (bp_locations_compare): Rename to...
3048         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3049         (update_global_location_list): Use std::sort instead of qsort.
3050         * buildsym.c (compare_line_numbers): Rename to...
3051         (lte_is_less_than): ...this, and change to std::sort semantics.
3052         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3053         instead of qsort.
3054         * disasm.c (compare_lines): Rename to...
3055         (line_is_less_than): ...this, and change to std::sort semantics.
3056         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3057         of qsort.
3058         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3059         (fde_is_less_than): ...this, and change to std::sort semantics.
3060         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3061         * mdebugread.c (compare_blocks):
3062         (block_is_less_than): ...this, and change to std::sort semantics.
3063         (sort_blocks): Call std::sort instead of qsort.
3064         * objfiles.c (qsort_cmp): Rename to...
3065         (sort_cmp): ...this, and change to std::sort semantics.
3066         (update_section_map): Call std::sort instead of qsort.
3067         * remote.c (compare_pnums): Remove.
3068         (map_regcache_remote_table): Call std::sort instead of qsort.
3069         * utils.c (compare_positive_ints): Remove.
3070         * utils.h (compare_positive_ints): Remove.
3071         * xcoffread.c (compare_lte): Remove.
3072         (arrange_linetable): Call std::sort instead of qsort.
3073
3074 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3075
3076         * symfile.c (init_entry_point_info): Fix typo.
3077         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3078
3079 2019-10-18  Tom de Vries  <tdevries@suse.de>
3080
3081         * aarch64-tdep.c: Fix typos in comments.
3082         * ada-lang.c: Same.
3083         * ada-tasks.c: Same.
3084         * alpha-tdep.c: Same.
3085         * alpha-tdep.h: Same.
3086         * amd64-nat.c: Same.
3087         * amd64-windows-tdep.c: Same.
3088         * arc-tdep.c: Same.
3089         * arc-tdep.h: Same.
3090         * arch-utils.c: Same.
3091         * arm-nbsd-tdep.c: Same.
3092         * arm-tdep.c: Same.
3093         * ax-gdb.c: Same.
3094         * blockframe.c: Same.
3095         * btrace.c: Same.
3096         * c-varobj.c: Same.
3097         * coff-pe-read.c: Same.
3098         * coffread.c: Same.
3099         * cris-tdep.c: Same.
3100         * darwin-nat.c: Same.
3101         * dbxread.c: Same.
3102         * dcache.c: Same.
3103         * disasm.c: Same.
3104         * dtrace-probe.c: Same.
3105         * dwarf-index-write.c: Same.
3106         * dwarf2-frame-tailcall.c: Same.
3107         * dwarf2-frame.c: Same.
3108         * dwarf2read.c: Same.
3109         * eval.c: Same.
3110         * exceptions.c: Same.
3111         * fbsd-tdep.c: Same.
3112         * findvar.c: Same.
3113         * frame.c: Same.
3114         * frv-tdep.c: Same.
3115         * gnu-v3-abi.c: Same.
3116         * go32-nat.c: Same.
3117         * h8300-tdep.c: Same.
3118         * hppa-tdep.c: Same.
3119         * i386-linux-tdep.c: Same.
3120         * i386-tdep.c: Same.
3121         * ia64-libunwind-tdep.c: Same.
3122         * ia64-tdep.c: Same.
3123         * infcmd.c: Same.
3124         * infrun.c: Same.
3125         * linespec.c: Same.
3126         * linux-nat.c: Same.
3127         * linux-thread-db.c: Same.
3128         * machoread.c: Same.
3129         * mdebugread.c: Same.
3130         * mep-tdep.c: Same.
3131         * mn10300-tdep.c: Same.
3132         * namespace.c: Same.
3133         * objfiles.c: Same.
3134         * opencl-lang.c: Same.
3135         * or1k-tdep.c: Same.
3136         * osabi.c: Same.
3137         * ppc-linux-nat.c: Same.
3138         * ppc-linux-tdep.c: Same.
3139         * ppc-sysv-tdep.c: Same.
3140         * printcmd.c: Same.
3141         * procfs.c: Same.
3142         * record-btrace.c: Same.
3143         * record-full.c: Same.
3144         * remote-fileio.c: Same.
3145         * remote.c: Same.
3146         * rs6000-tdep.c: Same.
3147         * s12z-tdep.c: Same.
3148         * score-tdep.c: Same.
3149         * ser-base.c: Same.
3150         * ser-go32.c: Same.
3151         * skip.c: Same.
3152         * sol-thread.c: Same.
3153         * solib-svr4.c: Same.
3154         * solib.c: Same.
3155         * source.c: Same.
3156         * sparc-nat.c: Same.
3157         * sparc-sol2-tdep.c: Same.
3158         * sparc-tdep.c: Same.
3159         * sparc64-tdep.c: Same.
3160         * stabsread.c: Same.
3161         * stack.c: Same.
3162         * symfile.c: Same.
3163         * symtab.c: Same.
3164         * target-descriptions.c: Same.
3165         * target-float.c: Same.
3166         * thread.c: Same.
3167         * utils.c: Same.
3168         * valops.c: Same.
3169         * valprint.c: Same.
3170         * value.c: Same.
3171         * varobj.c: Same.
3172         * windows-nat.c: Same.
3173         * xcoffread.c: Same.
3174         * xstormy16-tdep.c: Same.
3175         * xtensa-tdep.c: Same.
3176
3177 2019-10-17  Tom Tromey  <tromey@adacore.com>
3178
3179         * configure: Rebuild.
3180         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3181         in AC_CONFIG_FILES invocation.
3182         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3183         new-style config.status invocation.
3184
3185 2019-10-17  Tom de Vries  <tdevries@suse.de>
3186
3187         * arm-nbsd-nat.c: Fix typos in comments.
3188         * arm-tdep.c: Same.
3189         * darwin-nat-info.c: Same.
3190         * dwarf2read.c: Same.
3191         * elfread.c: Same.
3192         * event-top.c: Same.
3193         * findvar.c: Same.
3194         * gdbtypes.c: Same.
3195         * hppa-tdep.c: Same.
3196         * i386-tdep.c: Same.
3197         * jit.c: Same.
3198         * main.c: Same.
3199         * mdebugread.c: Same.
3200         * moxie-tdep.c: Same.
3201         * nto-procfs.c: Same.
3202         * osabi.c: Same.
3203         * ppc-linux-tdep.c: Same.
3204         * remote.c: Same.
3205         * riscv-tdep.c: Same.
3206         * s390-tdep.c: Same.
3207         * sh-tdep.c: Same.
3208         * sparc-linux-tdep.c: Same.
3209         * sparc-nat.c: Same.
3210         * stack.c: Same.
3211         * target-descriptions.c: Same.
3212         * top.c: Same.
3213         * varobj.c: Same.
3214
3215 2019-10-16  Tom Tromey  <tom@tromey.com>
3216
3217         * objfiles.h (struct objfile) <original_name>: Now const.
3218
3219 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3220
3221         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3222         pass on to sigsetjmp's second argument.
3223         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3224
3225 2019-10-16  Keith Seitz  <keiths@redhat.com>
3226
3227         PR gdb/23567
3228         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3229         sections whose size is greater than the file size.
3230
3231 2019-10-16  Jim Wilson  <jimw@sifive.com>
3232
3233         * riscv-tdep.c (riscv_gcc_target_options): New.
3234         (riscv_gnu_triplet_regexp): New.
3235         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3236         set_gdbarch_gnu_triplet_regexp.
3237
3238 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3239
3240         * Makefile.in: Add xml-builtin.h.
3241         * features/feature_to_c.sh: Add an include for xml-builtin.h
3242         to ensure that the compiler checks that the types match.
3243         * xml-builtin.h: New file.
3244         * xml-support.c (fetch_xml_builtin): Add missing const.
3245         * xml-support.h: Remove declaration of xml_builtins.
3246
3247 2019-10-16  Tom de Vries  <tdevries@suse.de>
3248
3249         PR tdep/25096
3250         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3251         (amd64_classify_aggregate): ... here.
3252         (amd64_classify_aggregate_field): Handled fiels of nested structs
3253         recursively.
3254
3255 2019-10-16  Tom de Vries  <tdevries@suse.de>
3256
3257         PR tdep/24104
3258         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3259         that handles 'theclass'.
3260
3261 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * linespec.c (decode_digits_ordinary): Update comment.
3264         * make-target-delegates: No longer need to handle VEC case.
3265         * memrange.c (normalize_mem_ranges): Update comment.
3266         * namespace.c (add_using_directive): Update comment.
3267         * objc-lang.c (uniquify_strings): Update comment.
3268         * ppc-linux-nat.c (struct thread_points): Update comment.
3269         * probe.h (find_probes_in_objfile): Update comment.
3270         * target.h (enum flash_preserve_mode): Update comment.
3271         * varobj.c (varobj_restrict_range): Update comment.
3272         * varobj.h (varobj_list_children): Update comment.
3273
3274 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * Makefile.in: Remove references to vec.h and vec.c.
3277         * aarch64-tdep.c: No longer include vec.h.
3278         * ada-lang.c: Likewise.
3279         * ada-lang.h: Likewise.
3280         * arm-tdep.c: Likewise.
3281         * ax.h: Likewise.
3282         * breakpoint.h: Likewise.
3283         * charset.c: Likewise.
3284         * cp-support.h: Likewise.
3285         * dtrace-probe.c: Likewise.
3286         * dwarf2read.c: Likewise.
3287         * extension.h: Likewise.
3288         * gdb_bfd.c: Likewise.
3289         * gdbsupport/gdb_vecs.h: Likewise.
3290         * gdbsupport/vec.c: Remove.
3291         * gdbsupport/vec.h: Remove.
3292         * gdbthread.h: Likewise.
3293         * guile/scm-type.c: Likewise.
3294         * inline-frame.c: Likewise.
3295         * machoread.c: Likewise.
3296         * memattr.c: Likewise.
3297         * memrange.h: Likewise.
3298         * namespace.h: Likewise.
3299         * nat/linux-btrace.h: Likewise.
3300         * osdata.c: Likewise.
3301         * parser-defs.h: Likewise.
3302         * progspace.h: Likewise.
3303         * python/py-type.c: Likewise.
3304         * record-btrace.c: Likewise.
3305         * rust-exp.y: Likewise.
3306         * solib-target.c: Likewise.
3307         * stap-probe.c: Likewise.
3308         * target-descriptions.c: Likewise.
3309         * target-memory.c: Likewise.
3310         * target.h: Likewise.
3311         * varobj.c: Likewise.
3312         * varobj.h: Likewise.
3313         * xml-support.h: Likewise.
3314
3315 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3318         Update for new std::vector based implementation.
3319         (process_psymtab_comp_unit_reader): Likewise.
3320         (scan_partial_symbols): Likewise.
3321         (recursively_compute_inclusions): Likewise.
3322         (compute_compunit_symtab_includes): Likewise.
3323         (process_imported_unit_die): Likewise.
3324         (queue_and_load_dwo_tu): Likewise.
3325         (follow_die_sig_1): Likewise.
3326         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3327         (typedef dwarf2_per_cu_ptr): Remove.
3328         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3329         function.
3330         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3331         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3332         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3333         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3334         std::vector.
3335
3336 2019-10-15  Tom Tromey  <tromey@adacore.com>
3337
3338         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3339         TID.
3340
3341 2019-10-15  Tom Tromey  <tromey@adacore.com>
3342
3343         * windows-nat.c (windows_nat_target::fetch_registers)
3344         (windows_nat_target::store_registers): Rename "pid" to "tid".
3345
3346 2019-10-15  Tom Tromey  <tromey@adacore.com>
3347
3348         * gdbarch.h, gdbarch.c: Rebuild.
3349         * gdbarch.sh (gcc_target_options): Change return type to
3350         std::string.
3351         * compile/compile.c (get_args): Update.
3352         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3353         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3354         std::string.
3355         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3356         std::string.
3357         * arch-utils.c (default_gcc_target_options): Return std::string.
3358         * arch-utils.h (default_gcc_target_options): Return std::string.
3359         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3360
3361 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3362
3363         * breakpoint.c (breakpoint_chain): Make static.
3364         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3365         of accessing breakpoint_chain.
3366
3367 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3368
3369         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3370         to a gdb::function_view and return value to bool.
3371         * breakpoint.h (iterate_over_breakpoints): Likewise.
3372         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3373         (pop_dummy_frame): Update.
3374         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3375         (gdbscm_breakpoints): Update.
3376         * python/py-breakpoint.c (build_bp_list): Update.
3377         (gdbpy_breakpoints): Update.
3378         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3379         Update.
3380         (bpfinishpy_handle_stop): Update.
3381         (bpfinishpy_handle_exit): Update.
3382         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3383         (svr4_update_solib_event_breakpoints): Update.
3384
3385 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3386
3387         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3388         when unwrapping single-field structs.
3389
3390 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3391
3392         * dwarf2read.c: Remove includes.
3393
3394 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3395
3396         * ui-out.c (ui_out::call_do_message): Silence
3397         -Wformat-nonliteral warning.
3398
3399 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3400
3401         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3402         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3403         include: readline/tilde.h.
3404
3405 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3406
3407         * remote.c (remote_target::get_trace_status): Remove declaration of
3408         trace_regblock_size.
3409
3410 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3411
3412         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3413         (show_user): Remove declaration of cmdlist.
3414         * cli/cli-cmds.h (max_user_call_depth): Declare.
3415         * cli/cli-script.c (execute_user_command): Remove declaration
3416         of max_user_call_depth.
3417
3418 2019-10-11  Jim Wilson  <jimw@sifive.com>
3419
3420         * gdbsupport/print-utils.h (pulongest): Fix comment.
3421         (plongest): Likewise.
3422         (phex): Add missing comment, mention leading zeros.
3423         (phex_nz): Add mention of no leading zeros to comment.
3424
3425         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3426         plongest instead of unsigned long long cast.
3427
3428 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3429
3430         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3431         for external_editor_command and gdbtk_test.
3432
3433 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3434
3435         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3436         * varobj.c (varobjdebug): Move comment to...
3437         * varobj.h (varobjdebug): ...here, and declare.
3438
3439 2019-10-09  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3442         erase_data_content.
3443
3444 2019-10-09  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3447         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3448         * tui/tui-command.c (tui_cmd_window::resize)
3449         (tui_refresh_cmd_win): Update.
3450         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3451         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3452         * tui/tui-data.c (~tui_gen_win_info): Remove.
3453         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3454         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3455         (tui_redisplay_readline, tui_mld_flush)
3456         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3457         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3458         (tui_data_window::erase_data_content)
3459         (tui_data_item_window::rerender)
3460         (tui_data_item_window::refresh_window): Update.
3461         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3462         (box_win, tui_gen_win_info::make_window)
3463         (tui_gen_win_info::make_visible): Update.
3464         (tui_delete_win): Remove.
3465         * tui/tui-winsource.c
3466         (tui_source_window_base::do_erase_source_content): Update.
3467         (tui_show_source_line, tui_source_window_base::update_tab_width)
3468         (tui_source_window_base::update_exec_info): Update.
3469         * tui/tui-data.h (struct curses_deleter): New.
3470         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3471         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3472
3473 2019-10-09  Tom Tromey  <tom@tromey.com>
3474
3475         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3476
3477 2019-10-09  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3480         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3481
3482 2019-10-09  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3485         window height directly.
3486         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3487         declare.
3488         * tui/tui-layout.c (tui_default_win_height): Remove.
3489         (tui_default_win_viewport_height): Remove.
3490
3491 2019-10-09  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui.h: Remove comments.
3494
3495 2019-10-09  Tom de Vries  <tdevries@suse.de>
3496
3497         * python/lib/gdb/printer/bound_registers.py: Use
3498         '^builtin_type_bound128' as regexp argument for
3499         add_builtin_pretty_printer.
3500
3501 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3502
3503         * guile/guile.c (guile_extension_script_ops): Remove forward
3504         declaration and mark as static.
3505         (guile_script_ops): Likewise.
3506         (extension_language_guile): Move further down in the file so
3507         it can reference the definitions for guile_{extension_,}script_ops.
3508
3509 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3510
3511         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3512         except SORTL, DFLTCC, and KDSA.
3513
3514 2019-10-08  Tom Tromey  <tromey@adacore.com>
3515
3516         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3517         (struct safe_symbol_file_add_args): Remove.
3518
3519 2019-10-08  Tom Tromey  <tromey@adacore.com>
3520
3521         * windows-nat.c: Don't include buildsym-legacy.h.
3522
3523 2019-10-08  Tom Tromey  <tromey@adacore.com>
3524
3525         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3526
3527 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3528
3529         * gdbtypes.c (overload_debug): Move comment to header.
3530         * gdbtypes.h (overload_debug): Declare.
3531         * valops.c: Remove declaration of overload_debug, instead
3532         include gdbtypes.h.
3533
3534 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3535
3536         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3537         through _().
3538         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3539         move comment...
3540         * language.h (lang_frame_mismatch_warn): ... here. Also add
3541         declaration.
3542         * top.c (lang_frame_mismatch_warn): Remove declaration.
3543         (check_frame_language_change): Pass lang_frame_mismatch_warn
3544         through _().
3545
3546 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3547
3548         * c-lang.h (vtbl_ptr_name): Declare.
3549         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3550         it from the header.
3551         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3552
3553 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3554
3555         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3556         gdb_static_assert.
3557
3558 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3559
3560         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3561         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3562         * ctfread.c: New file.
3563         * ctfread.h: New file.
3564         * elfread.c: Include ctfread.h.
3565         (struct elfinfo text_p): New member ctfsect.
3566         (elf_locate_sections): Mark CTF section.
3567         (elf_symfile_read): Call elfctf_build_psymtabs.
3568         * Makefile.in (LIBCTF): Add.
3569         (CLIBS): Use it.
3570         (CDEPS): Likewise.
3571         (DIST): Add ctfread.c.
3572
3573 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3574
3575         * ctfread.c (struct nextfield): Renamed to ...
3576         (struct ctf_nextfield): ... this.
3577         (struct field_info): Renamed to ...
3578         (strut ctf_field_info): ... this.
3579         (attach_fields_to_type): Update for renamed structures.
3580         (ctf_add_member_cb): Likewise.
3581         (ctf_add_enum_member_cb): Likewise.
3582         (process_struct_members): Likewise.
3583         (process_enum_type): Likewise.
3584
3585 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3586
3587         * tracectf.h: Rename, was ctf.h.
3588         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3589         * tracefile.c: Likewise.
3590         * tracepoint.c: Remove unused include ctf.h.
3591         * mi/mi-main.c: Likewise.
3592         * Makefile.in Replace ctf.c with tracectf.c.
3593
3594 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3595
3596         * version.in: Change version number to "9.0.50.DATE-git".
3597
3598 2019-10-03  Tom Tromey  <tom@tromey.com>
3599
3600         PR rust/24976:
3601         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3602
3603 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3604
3605         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3606         cp_search_name_hash.
3607         * NEWS: Add entry about nested function support.
3608
3609 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3610             Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3613         for nested static variables when searchin VAR_DOMAIN.
3614         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3615         global scope, update comment.
3616         (add_partial_subprogram): Call add_partial_subprogram recursively
3617         for nested subroutines when processinng Fortran.
3618         (load_partial_dies): Process the child entities of a subprogram
3619         when processing Fortran.
3620         (partial_die_parent_scope): Handle building scope
3621         for Fortran nested functions.
3622         (process_die): Record that nested functions have a scope.
3623         (new_symbol): Always record Fortran subprograms on the global
3624         symbol list.
3625         (determine_prefix): How to build the prefix for Fortran
3626         subprograms.
3627
3628 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3631         have just sent the thread a SIGSTOP and are waiting for it to
3632         arrive.
3633
3634 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3635
3636         * btrace.c (btrace_add_pc): Remove whitespace before the template
3637         parameter in 'std::vector <...>'.
3638         (parse_xml_btrace_block): Likewise.
3639         (btrace_maint_decode_pt): Likewise.
3640         (btrace_maint_update_packets): Likewise.
3641         (btrace_maint_print_packets): Likewise.
3642         * btrace.h (struct btrace_maint_info): Likewise.
3643         * dwarf2read.c (struct type_unit_group): Likewise.
3644         (build_type_psymtabs_reader): Likewise.
3645         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3646         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3647         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3648
3649 2019-10-03  Tom de Vries  <tdevries@suse.de>
3650
3651         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3652         the first line of the help text for set/show style metadata.
3653
3654 2019-10-02  Tom Tromey  <tromey@adacore.com>
3655
3656         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3657         * gdbsupport/common-inferior.c: New file.
3658         * infcmd.c (startup_with_shell): Don't define.
3659         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3660         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3661         * inferior.h (startup_with_shell): Don't declare.
3662
3663 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3664
3665         * gdbsupport/gdb_assert.h: Include errors.h.
3666         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3667
3668 2019-10-02  Tom Tromey  <tromey@adacore.com>
3669
3670         * NEWS: Add $_ada_exception entry.
3671         * ada-lang.c (struct ada_catchpoint): Add constructor.
3672         <m_kind>: New member.
3673         (allocate_location_exception, re_set_exception): Remove
3674         "ex" parameter.
3675         (should_stop_exception): Compute $_ada_exception.
3676         (check_status_exception, print_it_exception)
3677         (print_one_exception, print_mention_exception): Remove
3678         "ex" parameter.
3679         (allocate_location_catch_exception, re_set_catch_exception)
3680         (check_status_exception, print_it_catch_exception)
3681         (print_one_catch_exception, print_mention_catch_exception)
3682         (print_recreate_catch_exception)
3683         (allocate_location_catch_exception_unhandled)
3684         (re_set_catch_exception_unhandled)
3685         (check_status_exception, print_it_catch_exception_unhandled)
3686         (print_one_catch_exception_unhandled)
3687         (print_mention_catch_exception_unhandled)
3688         (print_recreate_catch_exception_unhandled)
3689         (allocate_location_catch_assert, re_set_catch_assert)
3690         (check_status_assert, print_it_catch_assert)
3691         (print_one_catch_assert, print_mention_catch_assert)
3692         (print_recreate_catch_assert)
3693         (allocate_location_catch_handlers, re_set_catch_handlers)
3694         (check_status_handlers, print_it_catch_handlers)
3695         (print_one_catch_handlers, print_mention_catch_handlers)
3696         (print_recreate_catch_handlers): Remove.
3697         (create_ada_exception_catchpoint): Update.
3698         (initialize_ada_catchpoint_ops): Update.
3699
3700 2019-10-02  Tom Tromey  <tromey@adacore.com>
3701
3702         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3703         (create_excep_cond_exprs): Simplify exception string computation.
3704         (ada_exception_catchpoint_cond_string): Likewise.
3705
3706 2019-10-02  Tom Tromey  <tromey@adacore.com>
3707
3708         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3709         * ada-lang.c (lesseq_defined_than): Handle
3710         LOC_STATIC.
3711         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3712         parameter.
3713         (dwarf2_has_info): Likewise.
3714         (new_symbol): Set maybe_copied on symbol when
3715         appropriate.
3716         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3717         parameter.
3718         <can_copy>: New member.
3719         * elfread.c (record_minimal_symbol): Set maybe_copied
3720         on symbol when appropriate.
3721         (elf_symfile_read): Update call to dwarf2_has_info.
3722         * minsyms.c (lookup_minimal_symbol_linkage): New
3723         function.
3724         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3725         * symtab.c (get_symbol_address, get_msymbol_address):
3726         New functions.
3727         * symtab.h (get_symbol_address, get_msymbol_address):
3728         Declare.
3729         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3730         maybe_copied.
3731         (struct symbol, struct minimal_symbol) <maybe_copied>:
3732         New member.
3733
3734 2019-10-02  Tom Tromey  <tromey@adacore.com>
3735
3736         * source.c (struct current_source_location): New.
3737         (current_source_key): New global.
3738         (current_source_symtab, current_source_line)
3739         (current_source_pspace): Remove.
3740         (get_source_location): New function.
3741         (get_current_source_symtab_and_line)
3742         (set_default_source_symtab_and_line)
3743         (set_current_source_symtab_and_line)
3744         (clear_current_source_symtab_and_line, select_source_symtab)
3745         (info_source_command, print_source_lines_base)
3746         (info_line_command, search_command_helper, _initialize_source):
3747         Update.
3748
3749 2019-10-02  Tom Tromey  <tromey@adacore.com>
3750
3751         * source.c (select_source_symtab): Don't call
3752         decode_line_with_current_source.
3753
3754 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * symtab.c (lookup_global_symbol): Search global block.
3757
3758 2019-10-02  Tom Tromey  <tromey@adacore.com>
3759
3760         * coffread.c (process_coff_symbol): Update.
3761         * dwarf2read.c (var_decode_location, new_symbol): Update.
3762         * mdebugread.c (parse_symbol): Update.
3763         * objfiles.c (relocate_one_symbol): Update.
3764         * stabsread.c (define_symbol, fix_common_block)
3765         (scan_file_globals): Update.
3766         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3767         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3768         * xcoffread.c (process_xcoff_symbol): Update.
3769
3770 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3771
3772         * MAINTAINERS: Update my email address.
3773
3774 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3777         std::vector.
3778         (build_type_psymtabs_reader): Update for std::vector.
3779         (build_type_psymtab_dependencies): Likewise.
3780         * dwarf2read.h: Remove use of DEF_VEC_P.
3781         (typedef sig_type_ptr): Delete.
3782
3783 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3786         to std::vector.
3787         (btrace_maint_decode_pt): Likewise, and move allocation of the
3788         vector outside of the loop.
3789         (btrace_maint_update_packets): Update to handle change from VEC to
3790         std::vector.
3791         (btrace_maint_print_packets): Likewise.
3792         (maint_info_btrace_cmd): Likewise.
3793         * btrace.h: Remove use of DEF_VEC_O.
3794         (typedef btrace_pt_packet_s): Delete.
3795         (struct btrace_maint_info) <packets>: Change fromm VEC to
3796         std::vector.
3797         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3798
3799 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3802         make accesses into the vector constant references.
3803         (btrace_add_pc): Update for std::vector.
3804         (btrace_stitch_bts): Likewise.
3805         (parse_xml_btrace_block): Likewise.
3806         (btrace_maint_update_packets): Likewise.
3807         (btrace_maint_print_packets): Likewise.
3808         (maint_info_btrace_cmd): Likewise.
3809         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3810         std::vector.
3811         (btrace_data::empty): Likewise.
3812         (btrace_data_append): Likewise.
3813         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3814         (typedef btrace_block_s): Delete.
3815         (struct btrace_block): Add constructor.
3816         (struct btrace_data_bts) <blocks>: Change to std::vector.
3817         * nat/linux-btrace.c (perf_event_read_bts): Update for
3818         std::vector.
3819         (linux_read_bts): Likewise.
3820
3821 2019-10-01  Tom Tromey  <tom@tromey.com>
3822
3823         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3824
3825 2019-10-01  Tom Tromey  <tom@tromey.com>
3826
3827         * stack.c (print_frame, info_frame_command_core): Use
3828         styled_string.
3829         * linux-thread-db.c (try_thread_db_load_1)
3830         (try_thread_db_load_from_pdir_1): Use styled_string.
3831         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3832         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3833         (maybe_print_unsupported_script_warning)
3834         (maybe_print_script_not_found_warning): Use styled_string.
3835         * ada-lang.c (user_select_syms): Use styled_string.
3836
3837 2019-10-01  Tom Tromey  <tom@tromey.com>
3838
3839         * p-lang.c (pascal_printstr): Use metadata style.
3840         * value.c (show_convenience): Use metadata style.
3841         * valprint.c (valprint_check_validity, val_print_optimized_out)
3842         (val_print_not_saved, val_print_unavailable)
3843         (val_print_invalid_address, generic_val_print, val_print)
3844         (value_check_printable, val_print_array_elements): Use metadata
3845         style.
3846         * ui-out.h (class ui_out) <field_fmt>: New overload.
3847         <do_field_fmt>: Add style parameter.
3848         * ui-out.c (ui_out::field_fmt): New overload.
3849         * typeprint.c (type_print_unknown_return_type)
3850         (val_print_not_allocated, val_print_not_associated): Use metadata
3851         style.
3852         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3853         parameter.
3854         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3855         * tracepoint.c (tvariables_info_1): Use metadata style.
3856         * stack.c (print_frame_arg, print_frame_info, print_frame)
3857         (info_frame_command_core): Use metadata style.
3858         * skip.c (info_skip_command): Use metadata style.
3859         * rust-lang.c (rust_print_enum): Use metadata style.
3860         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3861         metadata style.
3862         * python/py-framefilter.c (py_print_single_arg): Use metadata
3863         style.
3864         * printcmd.c (do_one_display, print_variable_and_value): Use
3865         metadata style.
3866         * p-valprint.c (pascal_val_print)
3867         (pascal_object_print_value_fields): Use metadata style.
3868         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3869         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3870         parameter.
3871         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3872         * m2-valprint.c (m2_print_long_set): Use metadata style.
3873         * m2-typeprint.c (m2_print_type): Use metadata style.
3874         * infcmd.c (print_return_value_1): Use metadata style.
3875         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3876         * f-valprint.c (info_common_command_for_block): Use metadata
3877         style.
3878         * f-typeprint.c (f_type_print_base): Use metadata style.
3879         * expprint.c (print_subexp_standard): Use metadata style.
3880         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3881         * cli/cli-style.h (class cli_style_option): Add constructor.
3882         (metadata_style): Declare.
3883         * cli/cli-style.c (metadata_style): New global.
3884         (_initialize_cli_style): Register metadata style.
3885         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3886         parameter.
3887         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3888         * c-typeprint.c (c_type_print_base_struct_union)
3889         (c_type_print_base_1): Use metadata style.
3890         * breakpoint.c (watchpoint_value_print)
3891         (print_one_breakpoint_location): Use metadata style.
3892         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3893         style.
3894         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3895         style.
3896         * ada-valprint.c (val_print_packed_array_elements, printstr)
3897         (print_field_values, ada_val_print_ref, ada_val_print): Use
3898         metadata style.
3899         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3900         style.
3901         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3902         style.
3903         * ada-lang.c (user_select_syms): Use metadata style.
3904
3905 2019-10-01  Tom Tromey  <tom@tromey.com>
3906
3907         * cli/cli-cmds.c (pwd_command): Style output.
3908
3909 2019-10-01  Pedro Alves  <palves@redhat.com>
3910             Tom Tromey  <tom@tromey.com>
3911
3912         * symtab.c (print_symbol_info): Use %ps.
3913         (print_msymbol_info): Use %ps.
3914         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3915         * printcmd.c (print_variable_and_value): Use %ps.
3916         * macrocmd.c (show_pp_source_pos): Use %ps.
3917         * infrun.c (print_exited_reason): Use ui_out::message.
3918         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3919         (describe_other_breakpoints): Use ui_out::message and new
3920         formats.
3921         (say_where): Use new formats.
3922         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3923         and new formats.
3924
3925 2019-10-01  Pedro Alves  <palves@redhat.com>
3926             Tom Tromey  <tom@tromey.com>
3927
3928         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3929         (test_gdb_formats): New function.
3930         (run_tests): Call it.
3931         (test_format_specifier): Update.
3932         * utils.h (fputs_filtered): Update comment.
3933         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3934         (fputs_styled_unfiltered): Declare.
3935         * utils.c (fputs_styled_unfiltered): New function.
3936         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3937         (vfprintf_filtered): Update.
3938         (vfprintf_unfiltered, vprintf_filtered): Update.
3939         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3940         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3941         disallow_ui_out_field>: New constants.
3942         (enum class field_kind): New.
3943         (struct base_field_s, struct signed_field_s): New.
3944         (signed_field): New function.
3945         (struct string_field_s): New.
3946         (string_field): New function.
3947         (struct styled_string_s): New.
3948         (styled_string): New function.
3949         (class ui_out) <message>: Add comment.
3950         <vmessage, call_do_message>: New methods.
3951         <do_message>: Add style parameter.
3952         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3953         methods.
3954         (ui_out::message): Rewrite.
3955         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3956         parameter.
3957         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3958         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3959         gdb_extensions parameter.
3960         (class format_piece): Add parameter to constructor.
3961         (n_int_args): New field.
3962         * gdbsupport/format.c (format_pieces::format_pieces): Add
3963         gdb_extensions parameter.  Handle '*'.
3964         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3965         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3966         vfprintf_styled_no_gdbfmt.
3967         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3968         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3969         unfiltered output.
3970         * ui-style.h (struct ui_file_style) <ptr>: New method.
3971
3972 2019-10-01  Tom Tromey  <tom@tromey.com>
3973
3974         * unittests/format_pieces-selftests.c: Update.  Add final format.
3975         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3976         empty literal pieces.
3977
3978 2019-10-01  Tom Tromey  <tom@tromey.com>
3979
3980         * ui-out.h (enum class ui_out_style_kind): Remove.
3981         (class ui_out) <field_string, field_stsream, do_field_string>:
3982         Change type of "style".
3983         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3984         (ui_out::field_string): Update.
3985         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3986         of "style".
3987         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3988         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3989         * stack.c (print_frame_arg, print_frame_info, print_frame):
3990         Update.
3991         * source.c (print_source_lines_base): Update.
3992         * solib.c (info_sharedlibrary_command): Update.
3993         * skip.c (info_skip_command): Update.
3994         * record-btrace.c (btrace_call_history_src_line)
3995         (btrace_call_history): Update.
3996         * python/py-framefilter.c (py_print_frame): Update.
3997         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3998         "style".
3999         * mi/mi-out.c (mi_ui_out::do_table_header)
4000         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4001         (mi_ui_out::do_field_string): Update.
4002         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4003         Update.
4004         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4005         "style".
4006         * cli-out.c (cli_ui_out::do_table_header)
4007         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4008         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4009         (cli_ui_out::do_field_fmt): Update.
4010         * breakpoint.c (print_breakpoint_location): Update.
4011         (update_static_tracepoint): Update.
4012
4013 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4014
4015         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4016         conversion of gdb_datadir.
4017         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4018         remove not needed c_str ().
4019
4020 2019-09-30  Ali Tamur <tamur@google.com>
4021
4022         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4023         (dwarf2_string_attr): Likewise.
4024
4025 2019-09-30  Ali Tamur <tamur@google.com>
4026
4027         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4028         (process_full_type_unit): Likewise.
4029         (dump_die_shallow): Likewise.
4030         (cu_debug_loc_section): Likewise.
4031
4032 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4033
4034         * minsyms.c (compare_minimal_symbols): Rename to...
4035         (minimal_symbol_is_less_than): ...this, and adjust to STL
4036         conventions (return bool, take arguments as references)
4037         (minimal_symbol_reader::install): Call std::sort instead
4038         of qsort.
4039
4040 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4041
4042         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4043         hash and why.
4044         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4045         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4046
4047 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4048
4049         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4050         * psympriv.h (add_psymbol_to_list): Move comment here and update
4051         it.
4052
4053 2019-09-29  Tom de Vries  <tdevries@suse.de>
4054
4055         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4056         Use $tmpdir/$(basename "$output_file").dwz instead of
4057         "${output_file}.dwz".
4058
4059 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4060
4061         PR gdb/25045
4062         * hppa-linux-nat.c: Include gdbarch.h.
4063
4064 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4065
4066         * blockframe.c (find_pc_partial_function): Change return type to bool.
4067         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4068         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4069         (stub_gnu_ifunc_resolve_name): Likewise.
4070         * symtab.c (compare_filenames_for_search): Likewise.
4071         (compare_glob_filenames_for_search): Likewise.
4072         (matching_obj_sections): Likewise.
4073         (symbol_matches_domain): Likewise.
4074         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4075         (find_line_pc): Change return type to bool.
4076         (find_line_pc_range): Likewise.
4077         (producer_is_realview): Likewise.
4078         * symtab.h (symbol_matches_domain): Likewise.
4079         (find_pc_partial_function): Likewise.
4080         (find_pc_line_pc_range): Likewise.
4081         (in_gnu_ifunc_stub): Likewise.
4082         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4083         (find_line_pc): Likewise.
4084         (find_line_pc_range): Likewise.
4085         (matching_obj_sections): Likewise.
4086         (find_line_symtab): Change out parameter to bool.
4087         (producer_is_realview): Change return type to bool.
4088         (compare_filenames_for_search): Likewise.
4089         (compare_glob_filenames_for_search): Likewise.
4090
4091 2019-09-26  Tom Tromey  <tom@tromey.com>
4092
4093         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4094         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4095         * gdb_usleep.h: Remove.
4096         * gdb_usleep.c: Remove.
4097         * utils.c: Don't include gdb_usleep.h.
4098
4099 2019-09-26  Tom Tromey  <tromey@adacore.com>
4100
4101         * python/py-type.c (type_to_type_object): Call check_typedef
4102         for stub types.
4103
4104 2019-09-26  Tom Tromey  <tom@tromey.com>
4105
4106         * utils.h (initialize_utils): Don't declare.
4107         * top.c (gdb_init): Don't call initialize_utils.
4108         * utils.c (initialize_utils): Remove.  Move contents...
4109         (_initialize_utils): ... here.
4110
4111 2019-09-25  Tom Tromey  <tom@tromey.com>
4112
4113         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4114         * utils.h (make_hex_string): Don't declare.
4115         * utils.c (make_hex_string): Remove.
4116
4117 2019-09-24  Tom de Vries  <tdevries@suse.de>
4118
4119         PR gdb/23815
4120         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4121         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4122
4123 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4124
4125         * NEWS: Mention new simulator port for PRU.
4126
4127 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4128
4129         * ada-exp.y (write_object_remaining): Update.
4130         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4131         and eliminate the static buffer.
4132         (ada_decode_symbol): Update.
4133         (ada_la_decode): Update.
4134         (ada_sniff_from_mangled_name): Update.
4135         (is_valid_name_for_wild_match): Update.
4136         (ada_lookup_name_info::matches): Update and simplify.
4137         (name_matches_regex): Update.
4138         (ada_add_global_exceptions): Update.
4139         * ada-lang.h (ada_decode): Update signature.
4140         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4141         * dwarf-index-write.c (debug_names::insert): Update.
4142
4143 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4144
4145         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4146         formatting.
4147
4148 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4149
4150         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4151         Change "nonzero" to "true" in documentation.
4152
4153 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4154
4155         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4156         (_initialize_darwin_solib): Don't set
4157         darwin_so_ops.lookup_lib_global_symbol.
4158         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4159         set_gdbarch_iterate_over_objfiles_in_search_order.
4160         (elf_lookup_lib_symbol): Rename to...
4161         (svr4_iterate_over_objfiles_in_search_order): this, and update
4162         to iterate semantics.
4163         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4164         * solib.c (solib_global_lookup): Remove.
4165         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4166         (solib_global_lookup): Remove.
4167         * symtab.c (lookup_global_or_static_symbol): Remove call to
4168         solib_global_lookup.
4169
4170 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4171
4172         * NEWS: Move entries about default MI version now being
4173         version 3, and about the GDB/MI fix for multi-location
4174         breakpoints to the "since GDB 8.3" section.
4175
4176 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4177
4178         GDB 8.3.1 released.
4179
4180 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4181
4182         * NEWS: Mention that Cell/B.E. debugging support was removed.
4183         * MAINTAINERS: Remove spu target.
4184
4185         * config/djgpp/fnchange.lst: Remove entries for removed files.
4186
4187         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4188         spu-multiarch.o, and spu-tdep.o.
4189         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4190         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4191         spu-multiarch.c, and spu-tdep.c.
4192         * spu-linux-nat.c: Remove file.
4193         * spu-multiarch.c: Remove file.
4194         * spu-tdep.c: Remove file.
4195         * spu-tdep.h: Remove file.
4196         * solib-spu.c: Remove file.
4197         * solib-spu.h: Remove file.
4198
4199         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4200         * configure.nat (spu-linux): Remove.
4201         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4202         solib-multiarch.o from gdb_target_obs.
4203         (spu*-*-*): Remove.
4204
4205         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4206         feature flag.
4207         (ppc_linux_no_features): Update.
4208         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4209         Cell/B.E. support.
4210         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4211         (tdesc_powerpc_cell64l): Likewise.
4212         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4213         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4214         Cell/B.E. support.
4215         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4216         Do not include "features/rs6000/powerpc-cell32l.c" or
4217         "features/rs6000/powerpc-cell64l.c".
4218         (ppc_linux_spu_section): Remove.
4219         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4220         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4221         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4222         (ppc_linux_spe_context_lookup): Remove.
4223         (ppc_linux_spe_context_inferior_created): Remove.
4224         (ppc_linux_spe_context_solib_loaded): Remove.
4225         (ppc_linux_spe_context_solib_unloaded): Remove.
4226         (ppc_linux_spe_context): Remove.
4227         (struct ppu2spu_cache): Remove.
4228         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4229         (struct ppu2spu_data): Remove.
4230         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4231         ppu2spu_unwind): Remove.
4232         (ppc_linux_init_abi): Remove Cell/B.E. support.
4233         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4234
4235         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4236         (rs6000/powerpc-cell64l-expedite): Likewise
4237         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4238         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4239         rs6000/powerpc-cell64l.xml.
4240         * features/rs6000/powerpc-cell32l.xml: Remove.
4241         * features/rs6000/powerpc-cell64l.xml: Likewise.
4242         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4243         * features/rs6000/powerpc-cell64l.c: Likewise.
4244         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4245         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4246         * regformats/reg-spu.dat: Remove.
4247
4248         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4249         * corelow.c (struct spuid_list): Remove.
4250         (add_to_spuid_list): Remove.
4251         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4252         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4253         (remote_protocol_features): Remove associated entries.
4254         (_initialize_remote): No longer initialize them.
4255         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4256         * linux-nat.c (SPUFS_MAGIC): Remove.
4257         (linux_proc_xfer_spu): Remove.
4258         (spu_enumerate_spu_ids): Remove.
4259         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4260         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4261         (linux_make_corefile_notes): No longer call it.
4262
4263         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4264         (cooked_write_test): Likewise.
4265
4266 2019-09-20  Tom Tromey  <tom@tromey.com>
4267
4268         * NEWS: Mention case-sensitivity of TUI commands.
4269         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4270         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4271         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4272
4273 2019-09-20  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-source.c (tui_source_window::set_contents): Use
4276         make_unique_xstrdup.
4277         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4278         make_unique_xstrdup.
4279
4280 2019-09-20  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-data.c: Remove separator comments.
4283         * tui/tui-layout.c: Remove separator comments.
4284         * tui/tui-win.c: Remove separator comments.
4285         * tui/tui-wingeneral.c: Remove separator comments.
4286
4287 2019-09-20  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui.h (strcat_to_buf): Don't declare.
4290         * tui/tui.c (strcat_to_buf): Remove.
4291
4292 2019-09-20  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4295         from "fullname".
4296         * tui/tui-source.c (tui_source_window::set_contents)
4297         (tui_source_window::location_matches_p)
4298         (tui_source_window::maybe_update): Update.
4299
4300 2019-09-20  Tom Tromey  <tom@tromey.com>
4301
4302         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4303         Update.
4304         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4305         prefix.
4306         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4307         (tui_data_window::line_from_reg_element_no)
4308         (tui_data_window::first_reg_element_no_inline)
4309         (tui_data_window::show_registers)
4310         (tui_data_window::show_register_group)
4311         (tui_data_window::display_registers_from)
4312         (tui_data_window::display_registers_from_line)
4313         (tui_data_window::first_data_item_displayed)
4314         (tui_data_window::delete_data_content_windows)
4315         (tui_data_window::erase_data_content)
4316         (tui_data_window::do_scroll_vertical)
4317         (tui_data_window::refresh_window)
4318         (tui_data_window::check_register_values): Update.
4319
4320 2019-09-20  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4323         (struct tui_locator_window) <full_name, proc_name>: Now
4324         std::string.
4325         * tui/tui-stack.c (tui_locator_window::make_status_line)
4326         (tui_locator_window::set_locator_fullname)
4327         (tui_locator_window::set_locator_info): Update.
4328         * tui/tui-source.c (tui_source_window::set_contents)
4329         (tui_source_window::showing_source_p): Update.
4330
4331 2019-09-20  Tom Tromey  <tom@tromey.com>
4332
4333         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4334         Don't call tui_locator_win_info_ptr.
4335
4336 2019-09-20  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4339
4340 2019-09-20  Tom Tromey  <tom@tromey.com>
4341
4342         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4343         height for locator.
4344         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4345         * tui/tui-layout.c (show_source_disasm_command, show_data)
4346         (show_source_or_disasm_and_command): Use 1 as height for locator.
4347
4348 2019-09-20  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui.c (tui_enable): Update.
4351         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4352         Update.
4353         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4354         Update.
4355         * tui/tui-data.c (win_resized): Now bool.
4356         (tui_win_resized): Return bool.
4357         (tui_set_win_resized_to): Accept a bool.
4358
4359 2019-09-20  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4362         Change type of "refresh_values_only".
4363         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4364         type of "refresh_values_only".
4365
4366 2019-09-20  Tom Tromey  <tom@tromey.com>
4367
4368         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4369         std::string.
4370         (tui_disassemble): Add "pos" parameter.
4371         (tui_disasm_window::set_contents): Simplify.
4372
4373 2019-09-20  Tom Tromey  <tom@tromey.com>
4374
4375         * tui/tui-winsource.h (struct tui_source_window_base)
4376         <show_source_content>: Now private.
4377         * tui/tui-winsource.c
4378         (tui_source_window_base::show_source_content): Don't handle empty
4379         content case.
4380
4381 2019-09-20  Tom Tromey  <tom@tromey.com>
4382
4383         * tui/tui-layout.c (show_source_disasm_command)
4384         (show_source_or_disasm_and_command): Don't call
4385         show_source_content.
4386
4387 2019-09-20  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4390         Declare.
4391         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4392         from tui_make_status_line.
4393         (tui_locator_window::rerender): Update.
4394
4395 2019-09-20  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4398         (tui_locator_window::rerender): Update.
4399
4400 2019-09-20  Tom Tromey  <tom@tromey.com>
4401
4402         * tui/tui-winsource.h (struct tui_source_window_base)
4403         <~tui_source_window_base>: Don't declare.
4404         <fullname>: Remove.
4405         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4406         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4407         member.
4408         * tui/tui-source.c (tui_source_window::set_contents): Update.
4409         (tui_source_window::location_matches_p)
4410         (tui_source_window::maybe_update): Update.
4411
4412 2019-09-20  Tom Tromey  <tom@tromey.com>
4413
4414         * tui/tui-winsource.h (~tui_source_element): Remove.
4415         (tui_source_element): Update.
4416         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4417         * tui/tui-winsource.c (tui_show_source_line): Update.
4418         * tui/tui-source.c (tui_source_window::set_contents): Update.
4419         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4420
4421 2019-09-20  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4424         declare.
4425         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4426         tui_clear_source_windows_detail.
4427         * tui/tui-winsource.h (struct tui_source_window_base)
4428         <clear_detail>: Don't declare.
4429         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4430         Remove.
4431         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4432
4433 2019-09-20  Tom Tromey  <tromey@adacore.com>
4434
4435         PR ada/24919:
4436         * block.c (contained_in): Fix final return value.
4437
4438 2019-09-20  Alan Modra  <amodra@gmail.com>
4439
4440         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4441         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4442         (read_indirect_string_from_dwz): Use bfd accessor.
4443         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4444         * machoread.c (macho_symfile_read_all_oso): Likewise.
4445         * solib.c (solib_bfd_open): Likewise.
4446
4447 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4448
4449         * eval.c: Move declaration of overload_resolution to...
4450         * value.h: ...here.
4451
4452 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4453
4454         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4455         * arm-linux-tdep.c: Likewise.
4456         * arm-nbsd-nat.c: Likewise.
4457         * arm-tdep.h: Declare arm_apcs_32.
4458         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4459
4460 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4461
4462         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4463         * dwarf2read.h: Declare dwarf_always_disassemble.
4464
4465 2019-09-19  Tom de Vries  <tdevries@suse.de>
4466
4467         PR gdb/25009
4468         * source-cache.c (source_cache::ensure): Catch exception thrown during
4469         construction of the highlighter.
4470
4471 2019-09-18  Alan Modra  <amodra@gmail.com>
4472
4473         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4474         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4475         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4476         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4477         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4478         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4479         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4480         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4481         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4482         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4483         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4484         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4485         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4486         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4487         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4488         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4489         * mi/mi-interp.c: Update throughout for bfd section macro and
4490         function changes.
4491         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4492         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4493
4494 2019-09-18  Tom Tromey  <tom@tromey.com>
4495
4496         * NEWS: Add entry.
4497         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4498         call rl_initialize.
4499         (tui_enable): Do not call rl_initialize.
4500
4501 2019-09-18  Christian Groessler  <chris@groessler.org>
4502
4503         * alpha-linux-nat.c: Include gdbarch.h.
4504
4505 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4506
4507         * ui-file.c: Include cli/cli-style.h.
4508         (term_cli_styling): Remove cli_styling declaration.
4509
4510 2019-09-18  Alan Modra  <amodra@gmail.com>
4511
4512         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4513         to bfd_asymbol_section.
4514
4515 2019-09-18  Alan Modra  <amodra@gmail.com>
4516
4517         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4518         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4519         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4520
4521 2019-09-18  Alan Modra  <amodra@gmail.com>
4522
4523         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4524         * spu-linux-nat.c (spu_bfd_open): Likewise.
4525
4526 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4527
4528         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4529         to bool to match definition in dwarf2read.c.
4530
4531 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4532
4533         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4534         (print_signatures): Likewise.
4535         (trust_pad_over_xvs): Likewise.
4536         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4537         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4538         * arm-linux-nat.c (arm_apcs_32): Likewise.
4539         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4540         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4541         * arm-tdep.c (arm_debug): Likewise.
4542         (arm_apcs_32): Likewise.
4543         * auto-load.c (debug_auto_load): Likewise.
4544         (auto_load_gdb_scripts): Likewise.
4545         (global_auto_load): Likewise.
4546         (auto_load_local_gdbinit): Likewise.
4547         (auto_load_local_gdbinit_loaded): Likewise.
4548         * auto-load.h (global_auto_load): Likewise.
4549         (auto_load_local_gdbinit): Likewise.
4550         (auto_load_local_gdbinit_loaded): Likewise.
4551         * breakpoint.c (disconnected_dprintf): Likewise.
4552         (breakpoint_proceeded): Likewise.
4553         (automatic_hardware_breakpoints): Likewise.
4554         (always_inserted_mode): Likewise.
4555         (target_exact_watchpoints): Likewise.
4556         (_initialize_breakpoint): Update.
4557         * breakpoint.h (target_exact_watchpoints): Change to bool.
4558         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4559         * cli/cli-cmds.c (trace_commands): Likewise.
4560         * cli/cli-cmds.h (trace_commands): Likewise.
4561         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4562         to bool*.
4563         * cli/cli-logging.c (logging_overwrite): Change to bool.
4564         (logging_redirect): Likewise.
4565         (debug_redirect): Likewise.
4566         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4567         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4568         to bool.
4569         <boolean_option_def>: Update.
4570         (struct flag_option_def): Change default type of Context to bool
4571         from int.
4572         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4573         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4574         (get_setshow_command_value_string): Likewise.
4575         * cli/cli-style.c (cli_styling): Change to bool.
4576         (source_styling): Likewise.
4577         * cli/cli-style.h (source_styling): Likewise.
4578         (cli_styling): Likewise.
4579         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4580         to bool.
4581         * command.h (var_types): Update comment.
4582         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4583         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4584         bool.
4585         (debug_compile_cplus_scopes): Likewise.
4586         * compile/compile-internal.h (compile_debug): Likewise.
4587         * compile/compile.c (compile_debug): Likewise.
4588         (struct compile_options) <raw>: Likewise.
4589         * cp-support.c (catch_demangler_crashes): Likewise.
4590         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4591         (usr_cmd_cris_dwarf2_cfi): Likewise.
4592         * csky-tdep.c (csky_debug): Likewise.
4593         * darwin-nat.c (enable_mach_exceptions): Likewise.
4594         * dcache.c (dcache_enabled_p): Likewise.
4595         * defs.h (info_verbose): Likewise.
4596         * demangle.c (demangle): Likewise.
4597         (asm_demangle): Likewise.
4598         * dwarf-index-cache.c (debug_index_cache): Likewise.
4599         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4600         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4601         * dwarf2read.c (check_physname): Likewise.
4602         (use_deprecated_index_sections): Likewise.
4603         (dwarf_always_disassemble): Likewise.
4604         * eval.c (overload_resolution): Likewise.
4605         * event-top.c (set_editing_cmd_var): Likewise.
4606         (exec_done_display_p): Likewise.
4607         * event-top.h (set_editing_cmd_var): Likewise.
4608         (exec_done_display_p): Likewise.
4609         * exec.c (write_files): Likewise.
4610         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4611         (debug_fbsd_nat): Likewise.
4612         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4613         Likewise.
4614         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4615         <backtrace_past_entry> Likewise.
4616         * gdb-demangle.h (demangle): Likewise.
4617         (asm_demangle): Likewise.
4618         * gdb_bfd.c (bfd_sharing): Likewise.
4619         * gdbcore.h (write_files): Likewise.
4620         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4621         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4622         * gdbthread.h (print_thread_events): Likewise.
4623         * gdbtypes.c (opaque_type_resolution): Likewise.
4624         (strict_type_checking): Likewise.
4625         * gnu-nat.c (gnu_debug_flag): Likewise.
4626         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4627         * guile/scm-param.c (pascm_variable): Add boolval.
4628         (add_setshow_generic): Update.
4629         (pascm_param_value): Update.
4630         (pascm_set_param_value_x): Update.
4631         * hppa-tdep.c (hppa_debug): Change to bool..
4632         * infcall.c (may_call_functions_p): Likewise.
4633         (coerce_float_to_double_p): Likewise.
4634         (unwind_on_signal_p): Likewise.
4635         (unwind_on_terminating_exception_p): Likewise.
4636         * infcmd.c (startup_with_shell): Likewise.
4637         * inferior.c (print_inferior_events): Likewise.
4638         * inferior.h (startup_with_shell): Likewise.
4639         (print_inferior_events): Likewise.
4640         * infrun.c (step_stop_if_no_debug): Likewise.
4641         (detach_fork): Likewise.
4642         (debug_displaced): Likewise.
4643         (disable_randomization): Likewise.
4644         (non_stop): Likewise.
4645         (non_stop_1): Likewise.
4646         (observer_mode): Likewise.
4647         (observer_mode_1): Likewise.
4648         (set_observer_mode): Update.
4649         (sched_multi): Change to bool.
4650         * infrun.h (debug_displaced): Likewise.
4651         (sched_multi): Likewise.
4652         (step_stop_if_no_debug): Likewise.
4653         (non_stop): Likewise.
4654         (disable_randomization): Likewise.
4655         * linux-tdep.c (use_coredump_filter): Likewise.
4656         (dump_excluded_mappings): Likewise.
4657         * linux-thread-db.c (auto_load_thread_db): Likewise.
4658         (check_thread_db_on_load): Likewise.
4659         * main.c (captured_main_1): Update.
4660         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4661         xx2_opt, boolean_opt>: Change to bool.
4662         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4663         * maint.c (maintenance_profile_p): Likewise.
4664         (per_command_time): Likewise.
4665         (per_command_space): Likewise.
4666         (per_command_symtab): Likewise.
4667         * memattr.c (inaccessible_by_default): Likewise.
4668         * mi/mi-main.c (mi_async): Likewise.
4669         (mi_async_1): Likewise.
4670         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4671         * nat/fork-inferior.h (startup_with_shell): Likewise.
4672         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4673         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4674         * nios2-tdep.c (nios2_debug): Likewise.
4675         * or1k-tdep.c (or1k_debug): Likewise.
4676         * parse.c (parser_debug): Likewise.
4677         * parser-defs.h (parser_debug): Likewise.
4678         * printcmd.c (print_symbol_filename): Likewise.
4679         * proc-api.c (procfs_trace): Likewise.
4680         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4681         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4682         (set_parameter_value): Update.
4683         (add_setshow_generic): Update.
4684         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4685         to bool*.
4686         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4687         int*.
4688         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4689         * record-btrace.c (record_btrace_target::store_registers): Update.
4690         * record-full.c (record_full_memory_query): Change to bool.
4691         (record_full_stop_at_limit): Likewise.
4692         * record-full.h (record_full_memory_query): Likewise.
4693         * remote-notif.c (notif_debug): Likewise.
4694         * remote-notif.h (notif_debug): Likewise.
4695         * remote.c (use_range_stepping): Likewise.
4696         (interrupt_on_connect): Likewise.
4697         (remote_break): Likewise.
4698         * ser-tcp.c (tcp_auto_retry): Likewise.
4699         * ser-unix.c (serial_hwflow): Likewise.
4700         * skip.c (debug_skip): Likewise.
4701         * solib-aix.c (solib_aix_debug): Likewise.
4702         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4703         (spu_auto_flush_cache_p): Likewise.
4704         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4705         Likewise.
4706         (struct info_print_options) <quiet>: Likewise.
4707         * symfile-debug.c (debug_symfile): Likewise.
4708         * symfile.c (auto_solib_add): Likewise.
4709         (separate_debug_file_debug): Likewise.
4710         * symfile.h (auto_solib_add): Likewise.
4711         (separate_debug_file_debug): Likewise.
4712         * symtab.c (basenames_may_differ): Likewise.
4713         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4714         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4715         (struct info_types_options) <quiet>: Likewise.
4716         * symtab.h (demangle): Likewise.
4717         (basenames_may_differ): Likewise.
4718         * target-dcache.c (stack_cache_enabled_1): Likewise.
4719         (code_cache_enabled_1): Likewise.
4720         * target.c (trust_readonly): Likewise.
4721         (may_write_registers): Likewise.
4722         (may_write_memory): Likewise.
4723         (may_insert_breakpoints): Likewise.
4724         (may_insert_tracepoints): Likewise.
4725         (may_insert_fast_tracepoints): Likewise.
4726         (may_stop): Likewise.
4727         (auto_connect_native_target): Likewise.
4728         (target_stop_and_wait): Update.
4729         (target_async_permitted): Change to bool.
4730         (target_async_permitted_1): Likewise.
4731         (may_write_registers_1): Likewise.
4732         (may_write_memory_1): Likewise.
4733         (may_insert_breakpoints_1): Likewise.
4734         (may_insert_tracepoints_1): Likewise.
4735         (may_insert_fast_tracepoints_1): Likewise.
4736         (may_stop_1): Likewise.
4737         * target.h (target_async_permitted): Likewise.
4738         (may_write_registers): Likewise.
4739         (may_write_memory): Likewise.
4740         (may_insert_breakpoints): Likewise.
4741         (may_insert_tracepoints): Likewise.
4742         (may_insert_fast_tracepoints): Likewise.
4743         (may_stop): Likewise.
4744         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4745         (make_thread_apply_all_options_def_group): Change argument from int*
4746         to bool*.
4747         (thread_apply_all_command): Update.
4748         (print_thread_events): Change to bool.
4749         * top.c (confirm): Likewise.
4750         (command_editing_p): Likewise.
4751         (history_expansion_p): Likewise.
4752         (write_history_p): Likewise.
4753         (info_verbose): Likewise.
4754         * top.h (confirm): Likewise.
4755         (history_expansion_p): Likewise.
4756         * tracepoint.c (disconnected_tracing): Likewise.
4757         (circular_trace_buffer): Likewise.
4758         * typeprint.c (print_methods): Likewise.
4759         (print_typedefs): Likewise.
4760         * utils.c (debug_timestamp): Likewise.
4761         (sevenbit_strings): Likewise.
4762         (pagination_enabled): Likewise.
4763         * utils.h (sevenbit_strings): Likewise.
4764         (pagination_enabled): Likewise.
4765         * valops.c (overload_resolution): Likewise.
4766         * valprint.h (struct value_print_options) <prettyformat_arrays,
4767         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4768         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4769         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4770         Likewise.
4771         * windows-nat.c (new_console): Likewise.
4772         (cygwin_exceptions): Likewise.
4773         (new_group): Likewise.
4774         (debug_exec): Likewise.
4775         (debug_events): Likewise.
4776         (debug_memory): Likewise.
4777         (debug_exceptions): Likewise.
4778         (useshell): Likewise.
4779         * windows-tdep.c (maint_display_all_tib): Likewise.
4780         * xml-support.c (debug_xml): Likewise.
4781
4782 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4783
4784         * source.c (prepare_path_for_appending): New function.
4785         (openp): Make use of new function.
4786         (find_and_open_source): Search for the compilation directory and
4787         source file as a relative path beneath the directory search path.
4788
4789 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * source-cache.c (source_cache::get_line_charpos): Catch
4792         exceptions and return false, this matches the behaviour documented
4793         in the header file.
4794
4795 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4796
4797         * ada-tasks.c (info_task): Remove quoting of the task's name.
4798
4799 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4800
4801         * symfile.c (auto_solib_add): Replace comment with a reference
4802         to the header file.
4803
4804 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4805
4806         * NEWS: Mention that gdb can now be compiled with Python 3
4807         on Windows.
4808
4809 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * maint.c (maint_print_section_data::maint_print_section_data):
4812         Force use of 'float log10 (float)' by casting the argument to
4813         float.
4814
4815 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * maint.c: Add 'cmath' include.
4818         (struct maint_print_section_data): New structure.
4819         (print_section_index): New function.
4820         (print_bfd_section_info): Add header comment, small whitespace
4821         cleanup, and update to call new print_section_index function.
4822         (print_objfile_section_info): Likewise.
4823         (maint_obj_section_from_bfd_section): New function.
4824         (print_bfd_section_info_maybe_relocated): New function.
4825         (maintenance_info_sections): Add header comment, always use
4826         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4827
4828 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4831         inner scope, add check that the objfile has psymtabs before
4832         checking psymtabs_addrmap.
4833         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4834
4835 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * NEWS: Announce that Ada task names are now shown at more places,
4838         and between quotes (except in info task output).
4839         * gdb/ada-tasks.c (task_to_str): New function.
4840         (display_current_task_id): Call task_to_str.
4841         (task_command_1): Likewise.
4842         (print_ada_task_info): In non-mi mode, Properly align headers and data
4843         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4844
4845 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4846
4847         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4848         prstatus.pr_lwp.pr_info instead of making it up.
4849
4850 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4851
4852         * auto-load.c (auto_load_expand_dir_vars): Update.
4853         * defs.h (gdb_datadir): Change to std::string.
4854         (python_libdir): Likewise.
4855         (relocate_gdb_directory): Change return type to std::string.
4856         * guile/guile.c (gdbscm_data_directory): Update.
4857         (initialize_scheme_side): Update.
4858         * jit.c (jit_reader_dir): Change to std::string.
4859         (jit_reader_load_command): Update.
4860         * main.c (gdb_datadir): Change to std::string.
4861         (python_libdir): Likewise.
4862         (set_gdb_data_directory): Update.
4863         (relocate_path): Change to return std::string.
4864         (relocate_gdb_directory): Change to return std::string.
4865         (relocate_gdbinit_path_maybe_in_datadir): Update.
4866         (captured_main_1): Update.
4867         * python/python.c (do_start_initialization): Update.
4868         * top.c (show_gdb_datadir): Update.
4869         * xml-syscall.c (xml_init_syscalls_info): Update.
4870         (init_syscalls_info): Update.
4871
4872 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4873
4874         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4875         out of get_init_files.
4876         (get_init_files): Update.
4877
4878 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4879
4880         * main.c (get_init_files): Change to use std::string.
4881         (captured_main_1): Update.
4882         (print_gdb_help): Update.
4883
4884 2019-09-11  Ali Tamur  <tamur@google.com>
4885
4886         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4887         implementation.
4888
4889 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4890
4891         * dbxread.c (read_dbx_symtab): Update.
4892         * dwarf2read.c (load_partial_dies): Update.
4893         * mdebugread.c (parse_partial_symbols): Update.
4894         (handle_psymbol_enumerators): Update.
4895         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4896         * psymtab.c (add_psymbol_to_bcache): Likewise.
4897         (add_psymbol_to_list): Likewise.
4898         * symtab.c (symbol_set_names): Likewise.
4899         * symtab.h (symbol_set_names): Likewise.
4900         * xcoffread.c (scan_xcoff_symtab): Update.
4901
4902 2019-09-11  Tom Tromey  <tom@tromey.com>
4903
4904         * symfile-mem.c (symbol_file_add_from_memory): Use
4905         bfd_set_filename.
4906         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4907         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4908
4909 2019-09-10  Tom Tromey  <tromey@adacore.com>
4910
4911         * dwarf-index-write.c (write_psymbols): Extend error message.
4912         (debug_names::insert): Add Ada code.
4913         (debug_names::write_psymbols): Remove Ada check.
4914         (debug_names) <m_string_obstack>: New member.
4915         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4916         (gdb_index_symbol_name_matcher::matches): Remove.
4917         (mapped_index_base::find_name_components_bounds): Add "lang"
4918         parameter.
4919         (mapped_index_base::build_name_components): Also split names
4920         according to Ada syntax.
4921         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4922         type of "match_callback".
4923         (check_match, check_find_bounds_finds)
4924         (dw2_expand_symtabs_matching): Update.
4925         (dw2_debug_names_iterator): Add new constructor.
4926         (dw2_debug_names_map_matching_symbols): New function.
4927         (dw2_debug_names_expand_symtabs_matching): Update.
4928         (dwarf2_debug_names_functions): Use
4929         dw2_debug_names_map_matching_symbols.
4930
4931 2019-09-10  Tom Tromey  <tromey@adacore.com>
4932
4933         * dwarf2read.c (dw2_get_file_names_reader): Add the
4934         CU's file name to the results.
4935
4936 2019-09-10  Tom Tromey  <tromey@adacore.com>
4937
4938         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4939         map_matching_symbols.  Update.
4940         * dwarf2read.c (dw2_map_matching_symbols): Update.
4941         * psymtab.c (match_partial_symbol): Change type; update.
4942         (psym_map_matching_symbols): Likewise.
4943         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4944         type; update.
4945         * symfile.h (struct quick_symbol_functions)
4946         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4947         Remove "match".
4948
4949 2019-09-10  Tom Tromey  <tromey@adacore.com>
4950
4951         * psymtab.c (map_block): Remove.
4952         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4953         * symtab.c (iterate_over_symbols_terminated): New function.
4954         * symtab.c (iterate_over_symbols_terminated): Declare.
4955
4956 2019-09-10  Tom Tromey  <tromey@adacore.com>
4957
4958         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4959         * language.h (struct language_defn) <la_iterate_over_symbols>:
4960         Return bool.
4961         * symtab.c (iterate_over_symbols): Return bool.
4962         * symtab.h (iterate_over_symbols): Return bool.
4963
4964 2019-09-10  Tom Tromey  <tromey@adacore.com>
4965
4966         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4967         (add_nonlocal_symbols): Update.
4968         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4969         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4970         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4971         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4972         Change type of "callback".  Remove "data".
4973
4974
4975 2019-09-09  Ali Tamur  <tamur@google.com>
4976
4977         * dwarf2read.c (comp_unit_head): Update comment.
4978         (dwarf2_dwo_name): New function declaration.
4979         (dwarf_unit_type_name): New function declaration.
4980         (read_comp_unit_head): Add support for new compilation units,
4981         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4982         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4983         (currently named as "signature") in their header. Also clarify error
4984         messages.
4985         (lookup_dwo_id): New function. Returns the dwo id of the given
4986         compile unit.
4987         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4988         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4989         functions.
4990         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4991         (dwarf2_dwo_name): Get the dwo name if present.
4992         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4993         purposes.
4994
4995 2019-09-09  Tom Tromey  <tom@tromey.com>
4996
4997         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4998
4999 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5000
5001         * python/python.c (do_start_initialization): Make progname_copy static,
5002         to avoid a leak report.
5003
5004 2019-09-08  Tom Tromey  <tom@tromey.com>
5005
5006         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5007
5008 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5009
5010         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5011         Change type to gdb::optional<block_enum>.
5012         (dw2_symtab_iter_init): Change block_index parameter type
5013         to gdb::optional<block_enum>.
5014         (dw2_lookup_symbol): Change block_index parameter
5015         type to block_enum.c
5016         (dw2_debug_names_lookup_symbol): Likewise.
5017         * psymtab.c (psym_lookup_symbol): Likewise.
5018         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5019         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5020         Likewise.
5021
5022 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5023
5024         * defs.h (relocate_gdb_directory): Change int to bool in
5025         signature and rename flag to relocatable.
5026         * main.c (relocate_path): Likewise.
5027         (relocate_gdb_directory): Likewise.
5028
5029 2019-09-06  Alan Modra  <amodra@gmail.com>
5030
5031         * coffread.c (coff_symfile_read): Constify filename variable.
5032         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5033         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5034         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5035         * solib.c (reload_shared_libraries_1): Likewise.
5036         * symfile.c (reread_symbols): Likewise.
5037         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5038         * solib-darwin.c (darwin_bfd_open): Likewise.
5039         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5040
5041 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5044         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5045
5046 2019-09-03  Tom Tromey  <tromey@adacore.com>
5047
5048         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5049         types.
5050         (has_negatives): Unbias a range type bound.
5051         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5052         * gdbtypes.c (operator==): Handle new field.
5053         (create_range_type): Add "bias" parameter.
5054         (create_static_range_type, resolve_dynamic_range): Update.
5055         * gdbtypes.h (struct range_bounds) <bias>: New member.
5056         (create_range_type): Add bias parameter.
5057         * printcmd.c (print_scalar_formatted): Unbias range types.
5058         * value.c (unpack_long): Unbias range types.
5059         (pack_long): Bias range types.
5060
5061 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5062
5063         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5064         probe arguments.
5065
5066 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5067
5068         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5069         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5070         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5071         (compile_probe_arg): Likewise.
5072         * probe.h (get_argument_count): Likewise.
5073         * solib-svr4.c (solib_event_probe_action): Likewise.
5074         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5075
5076 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5077
5078         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5079         code to here...
5080         (svr4_create_solib_event_breakpoints): ...from here.
5081
5082 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5083
5084         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5085         suffix from warning message.
5086
5087 2019-08-30  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-winsource.h (struct tui_source_window_base)
5090         <refresh_all>: Don't declare.
5091         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5092         Remove.
5093         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5094         tui_show_locator_content.
5095         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5096         declare.
5097         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5098         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5099         declare.
5100
5101 2019-08-30  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5104
5105 2019-08-30  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5108         Remove unnecessary forward declarations.
5109
5110 2019-08-30  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5113         rerender.
5114         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5115         tui_show_locator_content.
5116
5117 2019-08-30  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5120         (tui_locator_window::rerender): Rewrite using body of previous
5121         tui_show_locator_content.
5122
5123 2019-08-30  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5126         set_locator_fullname>: New methods.
5127         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5128         Rename from tui_set_locator_fullname.
5129         (tui_locator_window::set_locator_info): Rename from
5130         tui_set_locator_info.  Return bool.
5131         (tui_update_locator_fullname, tui_show_frame_info): Update.
5132
5133 2019-08-30  Tom Tromey  <tom@tromey.com>
5134
5135         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5136
5137 2019-08-30  Tom Tromey  <tom@tromey.com>
5138
5139         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5140         call touchwin.
5141
5142 2019-08-30  Tom Tromey  <tom@tromey.com>
5143
5144         * tui/tui-wingeneral.c (box_win): Assume win_info and
5145         win_info->handle cannot be NULL.
5146
5147 2019-08-30  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5150         refresh_window>: Declare.
5151         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5152         resize.
5153         (tui_data_item_window::rerender): Rename from
5154         tui_display_register.
5155         (tui_data_item_window::refresh_window): New method.
5156         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5157         no-op.
5158
5159 2019-08-30  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5162         regs_column_count, current_group>: Move later.  Now private.
5163         <get_current_group>: New method.
5164         * tui/tui-regs.c (tui_reg_command): Update.
5165         * tui/tui-layout.c (tui_set_layout): Update.
5166
5167 2019-08-30  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5170         (tui_data_window::rerender): Don't call
5171         check_and_display_highlight_if_needed.
5172         (tui_data_window::refresh_all): Remove call to
5173         erase_data_content.
5174
5175 2019-08-30  Tom Tromey  <tom@tromey.com>
5176
5177         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5178         (tui_data_window::display_registers_from)
5179         (tui_data_window::display_reg_element_at_line)
5180         (tui_data_window::display_registers_from_line): Remove checks of
5181         "empty".
5182
5183 2019-08-30  Tom Tromey  <tom@tromey.com>
5184
5185         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5186         Don't declare.
5187         * tui/tui-regs.c (tui_data_window::show_registers): Call
5188         rerender.
5189         (tui_data_window::rerender): Rename from display_all_data.
5190         (tui_data_window::rerender): Remove old implementation.
5191
5192 2019-08-30  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5195         text.
5196         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5197
5198 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5199             Sergio Durigan Junior  <sergiodj@redhat.com>
5200
5201         PR win32/24284
5202         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5203
5204 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5205
5206         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5207         when searching for types.
5208
5209 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * f-lang.c (f_language_defn): Use f_print_typedef.
5212         * f-lang.h (f_print_typedef): Declare.
5213         * f-typeprint.c (f_print_typedef): Define.
5214
5215 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5216
5217         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5218
5219 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * cli/cli-utils.c (info_print_options_defs): Delete.
5222         (make_info_print_options_def_group): Delete.
5223         (extract_info_print_options): Delete.
5224         (info_print_command_completer): Delete.
5225         (info_print_args_help): Add extra parameter, and optionally
5226         include text about -n flag.
5227         * cli/cli-utils.h (struct info_print_options): Delete.
5228         (extract_info_print_options): Delete declaration.
5229         (info_print_command_completer): Delete declaration.
5230         (info_print_args_help): Add extra parameter, extend header
5231         comment.
5232         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5233         search_symbols.
5234         * stack.c (struct info_print_options): New type.
5235         (info_print_options_defs): New file scoped variable.
5236         (make_info_print_options_def_group): New static function.
5237         (info_print_command_completer): New static function.
5238         (info_locals_command): Update to use new local functions.
5239         (info_args_command): Likewise.
5240         (_initialize_stack): Add extra parameter to calls to
5241         info_print_args_help.
5242         * symtab.c (search_symbols): Add extra parameter, use this to
5243         possibly excluse non-debug symbols.
5244         (symtab_symbol_info): Add extra parameter, which is passed on to
5245         search_symbols.
5246         (struct info_print_options): New type.
5247         (info_print_options_defs): New file scoped variable.
5248         (make_info_print_options_def_group): New static function.
5249         (info_print_command_completer): New static function.
5250         (info_variables_command): Update to use local functions, and pass
5251         extra parameter through to symtab_symbol_info.
5252         (info_functions_command): Likewise.
5253         (info_types_command): Pass additional argument through to
5254         symtab_symbol_info.
5255         (rbreak_command): Pass extra argument to search_symbols.
5256         (_initialize_symtab): Add extra arguments for calls to
5257         info_print_args_help, and update help text for 'info variables',
5258         'whereis', and 'info functions' commands.
5259         * symtab.h (search_symbols): Add extra argument to declaration.
5260         * NEWS: Mention new flags.
5261
5262 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5263
5264         * symtab.c (lookup_static_symbol): Call the new function (and move
5265         it down to be next to lookup_global_symbol).
5266         (struct global_sym_lookup_data): Add block_enum member and rename to...
5267         (struct global_or_static_sym_lookup_data): ...this.
5268         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5269         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5270         (lookup_symbol_global_or_static_iterator_cb): ...this.
5271         (lookup_global_or_static_symbol): New function.
5272         (lookup_global_symbol): Call new function.
5273
5274 2019-08-26  Tom de Vries  <tdevries@suse.de>
5275
5276         PR c++/24852
5277         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5278         when pc_probe.prob == NULL.
5279
5280 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5281
5282         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5283         variable symbol_linkage to symbol_linkage_.
5284
5285 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5286
5287         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5288         represent whether the symbol is static, dynamic, or we don't
5289         know.
5290
5291 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5292
5293         * gdb/rx-tdep.c (rx_register_names): New.
5294         (rx_register_name): Delete.
5295         (rx_psw_type): Delete.
5296         (rx_fpsw_type): Delete.
5297         (rx_register_type): Delete.
5298         (rx_gdbarch_init): Convert target-descriptions.
5299         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5300         * gdb/features/Makefile: Add rx.xml.
5301         * gdb/features/rx.xml: New.
5302         * gdb/features/rx.c: Generated.
5303         * gdb/NEWS: Mention target description support.
5304
5305 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5306
5307         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5308         *slot_ptr.
5309
5310 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5311
5312         * configure.ac: Don't check for 'dlfcn.h' (moved to
5313         gdbsupport/common.m4).
5314         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5315         'gdbsupport/'.
5316         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5317         * compile/compile-c-support.c: Include
5318         'gdbsupport/gdb-dlfcn.h'.
5319         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5320         * gdb-dlfcn.c: Move to...
5321         * gdbsupport/gdb-dlfcn.c: ... here.
5322         * gdb-dlfcn.h: Move to...
5323         * gdbsupport/gdb-dlfcn.h: ... here.
5324
5325 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5326
5327         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5328         the offset field signed.
5329
5330 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5331
5332         * python/lib/gdb/__init__.py (_execute_file): New function.
5333         * python/python.c (python_run_simple_file): Call gdb._execute_file
5334         on Windows.
5335
5336 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5339         all uses as this was never set to anything but a zero value.
5340
5341 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5342
5343         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5344
5345 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5346
5347         * tui/tui-data.h (tui_gen_win_info): Add an =default
5348         move constructor, required by some GCC versions.
5349
5350 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5351
5352         * go32-nat.c (go32_sysinfo): Add hygon_p.
5353
5354 2019-08-20  Tom Tromey  <tom@tromey.com>
5355
5356         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5357         line_from_reg_element_no, first_reg_element_no_inline,
5358         display_all_data, delete_data_content_windows,
5359         erase_data_content>: Now private.
5360
5361 2019-08-20  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5364         (tui_unhighlight_win, tui_highlight_win)
5365         (tui_win_info::make_window): Update.
5366         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5367
5368 2019-08-20  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5371         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5372         (MAX_PID_WIDTH): Move to tui-stack.c.
5373         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5374         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5375         (MAX_PID_WIDTH): Move from tui-data.h.
5376
5377 2019-08-20  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5380         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5381         (box_win): Update.
5382         (tui_gen_win_info::make_window): Rename from tui_make_window.
5383         (tui_win_info::make_window): New method.
5384         (tui_gen_win_info::make_visible): Update.
5385         * tui/tui-source.c (tui_source_window::set_contents): Update.
5386         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5387         (tui_data_window::display_registers_from): Update.
5388         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5389         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5390         Declare.
5391         <can_box>: Remove.
5392         <title>: Remove.
5393         (struct tui_win_info) <make_window>: Declare.
5394         <can_box>: Now virtual.
5395         <title>: New member.
5396         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5397         * tui/tui-command.c (tui_cmd_window::resize): Update.
5398
5399 2019-08-20  Tom Tromey  <tom@tromey.com>
5400
5401         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5402         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5403         (tui_data_window::check_register_values): Update.
5404
5405 2019-08-20  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-regs.h (struct tui_data_window): Use
5408         DISABLE_COPY_AND_ASSIGN.
5409         <regs_content>: Change type, removing unique_ptr.
5410         <tui_data_window>: Add move constructor.
5411         * tui/tui-regs.c (tui_data_window::show_registers)
5412         (tui_data_window::show_register_group)
5413         (tui_data_window::display_registers_from)
5414         (tui_data_window::display_registers_from)
5415         (tui_data_window::first_data_item_displayed)
5416         (tui_data_window::delete_data_content_windows)
5417         (tui_data_window::rerender, tui_data_window::refresh_window)
5418         (tui_data_window::check_register_values): Update.
5419
5420 2019-08-20  Tom Tromey  <tom@tromey.com>
5421
5422         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5423         show_register_group>: Declare.
5424         (tui_show_register_group): Don't declare.
5425         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5426         tui_show_registers.
5427         (tui_data_window::show_register_group): Rename from
5428         tui_show_register_group.
5429         (tui_data_window::check_register_values, tui_reg_command):
5430         Update.
5431         * tui/tui-layout.c (tui_set_layout): Update.
5432
5433 2019-08-20  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5436         Declare.
5437         (tui_check_register_values): Don't declare.
5438         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5439         from tui_check_register_values.
5440         * tui/tui-hooks.c (tui_register_changed): Update.
5441
5442 2019-08-20  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-regs.c (tui_reg_layout): Move later.
5445         (tui_show_registers): Don't enable TUI mode or change layout.
5446
5447 2019-08-20  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-regs.h (struct tui_data_item_window)
5450         <~tui_data_item_window>: Remove.
5451         <content>: Now a unique_xmalloc_ptr.
5452         * tui/tui-regs.c (tui_register_format): Return a
5453         unique_xmalloc_ptr.
5454         (tui_get_register): Update.
5455         (~tui_data_item_window): Remove.
5456         (tui_data_window::display_registers_from, tui_display_register):
5457         Update.
5458         * tui/tui-io.h (tui_expand_tabs): Update.
5459         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5460         Remove "col" parameter.
5461
5462 2019-08-20  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5465         field.
5466         * tui/tui-regs.c (~tui_data_item_window): Update.
5467
5468 2019-08-20  Tom Tromey  <tom@tromey.com>
5469
5470         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5471         earlier.
5472
5473 2019-08-20  Tom Tromey  <tom@tromey.com>
5474
5475         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5476
5477 2019-08-20  Tom Tromey  <tom@tromey.com>
5478
5479         * tui/tui-source.h (struct tui_source_window): Update.
5480         * tui/tui-regs.c (tui_show_registers): Update.
5481         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5482         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5483         (NO_REGS_STRING): Remove defines.
5484
5485 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5486
5487         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5488         unnecessary thread walk if remote doesn't support the packet.
5489
5490 2019-08-19  Tom Tromey  <tromey@adacore.com>
5491
5492         * python/py-value.c (value_has_field): Fix indentation.
5493
5494 2019-08-19  Tom Tromey  <tromey@adacore.com>
5495
5496         * printcmd.c (do_one_display, info_display_command): Update.
5497         * block.h (contained_in): Return bool.  Add allow_nested
5498         parameter.
5499         * block.c (contained_in): Return bool.  Add allow_nested
5500         parameter.
5501
5502 2019-08-19  Tom Tromey  <tom@tromey.com>
5503
5504         * configure: Rebuild.
5505         * configure.ac: Disallow the combination of -static-libstdc++ and
5506         source highlight.
5507         * source-cache.c (get_language_name): Handle rust.
5508         (source_cache::get_source_lines): Ignore highlighting exceptions.
5509
5510 2019-08-16  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5513         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5514         (struct tui_source_window_base) <make_visible, refresh_window,
5515         resize>: Remove methods.
5516         <execution_info>: Remove field.
5517         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5518         (tui_show_source_line, tui_source_window_base)
5519         (~tui_source_window_base): Update.
5520         (tui_source_window_base::resize)
5521         (tui_source_window_base::make_visible)
5522         (tui_source_window_base::refresh_window): Remove.
5523         (tui_source_window_base::update_exec_info): Update.
5524         * tui/tui-source.c (tui_source_window::set_contents): Update.
5525         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5526
5527 2019-08-16  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5530         deprecated_query_hook.
5531
5532 2019-08-16  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5535         (tui_update_source_windows_with_line): Update.
5536         * tui/tui-source.h (struct tui_source_window)
5537         <show_symtab_source>: Declare.
5538         (tui_show_symtab_source): Don't declare.
5539         * tui/tui-source.c (tui_show_symtab_source): Rename from
5540         tui_show_symtab_source.
5541
5542 2019-08-16  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-winsource.h (struct tui_source_window_base)
5545         <set_contents>: Declare.
5546         * tui/tui-winsource.c
5547         (tui_source_window_base::update_source_window_as_is): Update.
5548         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5549         Declare.
5550         (tui_set_source_content): Don't declare.
5551         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5552         tui_set_source_content.
5553         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5554         Declare.
5555         (tui_set_disassem_content): Don't declare.
5556         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5557         tui_set_disassem_content.
5558
5559 2019-08-16  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-winsource.h (struct tui_source_window_base)
5562         <update_breakpoint_info>: Declare.
5563         (tui_update_breakpoint_info): Don't declare.
5564         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5565         (tui_update_all_breakpoint_info): Update.
5566         (tui_source_window_base::update_breakpoint_info): Rename from
5567         tui_update_breakpoint_info.
5568         (tui_source_window_base::update_exec_info): Update.
5569
5570 2019-08-16  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-winsource.h (struct tui_source_window_base)
5573         <update_source_window>: Declare.
5574         (tui_update_source_window): Don't declare.
5575         * tui/tui-winsource.c
5576         (tui_source_window_base::update_source_window): Rename from
5577         tui_update_source_window.
5578         (tui_source_window_base::rerender): Update.
5579         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5580         * tui/tui-disasm.c (tui_show_disassem)
5581         (tui_show_disassem_and_update_source)
5582         (tui_disasm_window::maybe_update): Update.
5583
5584 2019-08-16  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-winsource.h (struct tui_source_window_base)
5587         <update_source_window_as_is>: Declare.
5588         (tui_update_source_window_as_is): Don't declare.
5589         * tui/tui-winsource.c (tui_update_source_window): Update
5590         (tui_source_window_base::update_source_window_as_is): Rename from
5591         tui_update_source_window_as_is.
5592         (tui_source_window_base::refill): Update.
5593         * tui/tui-source.c (tui_show_symtab_source): Update.
5594         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5595         Update.
5596
5597 2019-08-16  Tom Tromey  <tom@tromey.com>
5598
5599         * tui/tui-winsource.h (tui_update_source_window)
5600         (tui_update_source_window_as_is): Remove "noerror" parameter.
5601         * tui/tui-winsource.c (tui_update_source_window)
5602         (tui_update_source_window_as_is): Remove "noerror" parameter.
5603         (tui_update_source_windows_with_addr)
5604         (tui_update_source_windows_with_line)
5605         (tui_source_window_base::rerender)
5606         (tui_source_window_base::refill): Update.
5607         * tui/tui-source.h (tui_set_source_content)
5608         (tui_show_symtab_source): Remove "noerror" parameter.
5609         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5610         parameter.
5611         (tui_show_symtab_source): Likewise.
5612         (tui_source_window::maybe_update): Update.
5613         * tui/tui-disasm.c (tui_show_disassem)
5614         (tui_show_disassem_and_update_source)
5615         (tui_disasm_window::do_scroll_vertical)
5616         (tui_disasm_window::maybe_update): Update.
5617
5618 2019-08-16  Tom Tromey  <tom@tromey.com>
5619
5620         * tui/tui.c (tui_is_window_visible): Update.
5621         * tui/tui-wingeneral.c (tui_make_window)
5622         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5623         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5624         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5625         (tui_set_win_height_command, parse_scrolling_args): Update.
5626         * tui/tui-source.c (tui_source_window::style_changed): Update.
5627         * tui/tui-regs.c (tui_show_registers)
5628         (tui_data_window::first_data_item_displayed)
5629         (tui_data_window::delete_data_content_windows)
5630         (tui_check_register_values, tui_reg_command): Update.
5631         * tui/tui-disasm.c (tui_show_disassem): Update.
5632         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5633         method.
5634         <is_visible>: Remove field.
5635         * tui/tui-data.c (tui_next_win, tui_prev_win)
5636         (tui_delete_invisible_windows): Update.
5637
5638 2019-08-16  Tom Tromey  <tom@tromey.com>
5639
5640         * tui/tui-winsource.h (struct tui_source_window_base)
5641         <m_has_locator>: Remove.
5642         * tui/tui-layout.c (show_source_disasm_command, show_data)
5643         (show_source_or_disasm_and_command): Update.
5644
5645 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5646
5647         * NEWS (Other MI changes): New subsection.
5648         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5649         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5650         * arch-utils.c (default_get_pc_address_flags): New function.
5651         * arch-utils.h (default_get_pc_address_flags): New declaration.
5652         * gdbarch.sh: Add get_pc_address_flags.
5653         * gdbarch.c: Regenerate.
5654         * gdbarch.h: Likewise.
5655         * stack.c (print_pc): New function.
5656         (print_frame_info) (print_frame): Call print_pc.
5657
5658 2019-08-16  Tom de Vries  <tdevries@suse.de>
5659
5660         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5661         print_objfile_section_info.
5662
5663 2019-08-15  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5666         calling update_cmdwin_start_line.
5667         * tui/tui-winsource.h (struct tui_source_window_base)
5668         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5669         <rerender>: Declare.
5670         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5671         Call rerender.
5672         (tui_source_window_base::set_new_height): Remove.
5673         (tui_source_window_base::rerender): Rename from
5674         do_make_visible_with_new_height.
5675         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5676         resize method.
5677         (tui_win_info::make_invisible_and_set_new_height)
5678         (tui_win_info::make_visible_with_new_height): Remove.
5679         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5680         Declare.
5681         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5682         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5683         do_make_visible_with_new_height>: Don't declare.
5684         <rerender>: Declare.
5685         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5686         set_new_height.
5687         (tui_data_window::do_make_visible_with_new_height): Remove.
5688         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5689         call tui_show_locator_content.
5690         (tui_gen_win_info::resize): Call rerender.
5691         (show_source_or_disasm_and_command): Don't call
5692         tui_show_locator_content.
5693         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5694         method.
5695         (struct tui_win_info) <rerender>: Declare.
5696         <set_new_height, make_invisible_and_set_new_height,
5697         make_visible_with_new_height>: Don't declare.
5698         * tui/tui-data.c (tui_win_list::rerender): New method.
5699         * tui/tui-command.h (struct tui_cmd_window)
5700         <do_make_visible_with_new_height>: Don't declare.
5701         * tui/tui-command.c
5702         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5703
5704 2019-08-15  Tom Tromey  <tromey@adacore.com>
5705
5706         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5707         * ada-lang.c (ada_enum_name): Likewise.
5708
5709 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5710
5711         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5712         leading underscore.
5713         (GdbOutputErrorFile): Likewise.
5714         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5715         accordingly.
5716         (execute_unwinders): Rename to have a leading underscore.
5717         (auto_load_packages): Likewise.
5718         (global scope): Adjust call to auto_load_packages accordingly.
5719         (GdbSetPythonDirectory): Likewise.
5720         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5721         instead of execute_unwinders.
5722
5723 2019-08-15  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5726         (show_data): Don't change window visibility.
5727         (tui_gen_win_info::resize): Remove special case for command
5728         window.  Use wresize, when available.
5729         (show_source_or_disasm_and_command): Don't change window
5730         visibility.
5731         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5732         <make_visible>: New method.
5733         * tui/tui-command.c (tui_cmd_window::resize): New method.
5734
5735 2019-08-15  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5738         (struct tui_source_windows): New.
5739         * tui/tui-winsource.c (tui_display_main): Update.
5740         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5741         (new_height_ok, parse_scrolling_args): Update.
5742         * tui/tui-layout.c (show_layout, show_data): Update.
5743         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5744         (tui_add_to_source_windows): Don't declare.
5745         * tui/tui-data.c (source_windows, tui_source_windows)
5746         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5747
5748 2019-08-15  Tom Tromey  <tom@tromey.com>
5749
5750         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5751         Rename from reset.
5752         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5753         * tui/tui-layout.c (show_source_disasm_command, show_data):
5754         Update.
5755         (tui_gen_win_info::resize): Rename.
5756         (show_source_or_disasm_and_command): Update.
5757         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5758         reset.
5759
5760 2019-08-15  Tom Tromey  <tom@tromey.com>
5761
5762         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5763         * tui/tui-interp.c (tui_interp::init): Don't call
5764         tui_initialize_static_data.
5765         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5766
5767 2019-08-15  Tom Tromey  <tom@tromey.com>
5768
5769         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5770         examine tui_win_list.
5771
5772 2019-08-15  Tom Tromey  <tom@tromey.com>
5773
5774         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5775         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5776         tui_clear_source_content.
5777         (tui_clear_source_content): Remove.
5778         (tui_source_window_base::do_erase_source_content): Hoist call to
5779         content.clear().
5780         * tui/tui-stack.c (tui_show_frame_info): Don't call
5781         tui_clear_source_content.
5782
5783 2019-08-15  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-winsource.h (struct tui_source_window_base)
5786         <do_erase_source_content>: New method.
5787         <erase_source_content>: New method.
5788         (tui_erase_source_content): Don't declare.
5789         * tui/tui-winsource.c (tui_clear_source_content): Update.
5790         (tui_source_window_base::do_erase_source_content): Rename from
5791         tui_erase_source_content.
5792         (tui_source_window_base::show_source_content): Update.
5793         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5794         * tui/tui-source.h (struct tui_source_window)
5795         <erase_source_content>: New method.
5796         * tui/tui-disasm.h (struct tui_disasm_window)
5797         <erase_source_content>: New method.
5798
5799 2019-08-15  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5802         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5803         constructor.
5804         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5805         * tui/tui-source.c (tui_set_source_content): Update.
5806         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5807
5808 2019-08-15  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5811         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5812         tui-source.c.
5813         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5814         Declare.
5815         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5816         method.
5817         (tui_source_window::maybe_update): Update.
5818
5819 2019-08-15  Tom Tromey  <tom@tromey.com>
5820
5821         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5822         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5823         tui-disasm.c.
5824         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5825         Declare.
5826         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5827         method.
5828         (tui_disasm_window::maybe_update): Update.
5829
5830 2019-08-15  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-winsource.h (struct tui_source_window_base)
5833         <maybe_update>: Declare.
5834         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5835         method.
5836         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5837         Declare.
5838         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5839         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5840         Declare.
5841         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5842
5843 2019-08-15  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5846
5847 2019-08-15  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-wingeneral.c: Include tui-stack.h.
5850         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5851         (struct tui_locator_window): Move from tui-data.h.
5852         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5853         (tui_initialize_static_data): Move from tui-data.c.
5854         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5855         (struct tui_locator_window): Move to tui-stack.c.
5856         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5857         (tui_initialize_static_data): Move to tui-stack.c.
5858
5859 2019-08-15  Tom Tromey  <tom@tromey.com>
5860
5861         * tui/tui-layout.c (show_source_disasm_command)
5862         (show_source_or_disasm_and_command): Use make_visible method, not
5863         tui_make_window.
5864         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5865         Remove.
5866
5867 2019-08-15  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-wingeneral.h (tui_make_window): Update.
5870         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5871         parameter.
5872         (tui_gen_win_info::make_visible): Update.
5873         * tui/tui-regs.c (tui_data_window::display_registers_from):
5874         Update.
5875         * tui/tui-layout.c (show_source_disasm_command)
5876         (show_source_or_disasm_and_command): Update.
5877         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5878         (enum tui_box): Remove.
5879         (struct tui_win_info) <can_box>: New method.
5880         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5881         method.
5882
5883 2019-08-15  Tom de Vries  <tdevries@suse.de>
5884
5885         * linux-nat-trad.c: Include gdbarch.h.
5886
5887 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5888
5889         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5890         register sizes.
5891
5892 2019-08-14  Tom Tromey  <tromey@adacore.com>
5893
5894         * darwin-nat.c: Include gdbarch.h.
5895         * darwin-nat-info.c: Include gdbarch.h.
5896
5897 2019-08-13  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5900         Remove.
5901         * tui/tui-data.c (tui_initialize_static_data): Update.
5902
5903 2019-08-13  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-winsource.h (struct tui_exec_info_window)
5906         <~tui_exec_info_window, maybe_allocate_content, get_content,
5907         m_content>: Remove.
5908         (struct tui_source_window_base) <set_exec_info_content,
5909         show_exec_info_content>: Don't declare.
5910         * tui/tui-winsource.c
5911         (tui_exec_info_window::maybe_allocate_content): Remove.
5912         (tui_source_window_base::update_exec_info): Rename from
5913         set_exec_info_content.
5914         (tui_source_window_base::show_exec_info_content)
5915         (tui_source_window_base::update_exec_info): Remove.
5916
5917 2019-08-13  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5920         declare.
5921         * tui/tui-winsource.c (tui_update_source_window_as_is)
5922         (tui_update_source_windows_with_addr, tui_erase_source_content):
5923         Update.
5924         (tui_clear_exec_info_content): Remove.
5925
5926 2019-08-13  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5929         declare.
5930         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5931         call tui_erase_exec_info_content.
5932         (tui_clear_exec_info_content): Rename from
5933         tui_erase_exec_info_content.
5934         (tui_clear_exec_info_content): Delete.
5935
5936 2019-08-13  Tom Tromey  <tom@tromey.com>
5937
5938         * tui/tui-winsource.h (struct tui_source_window_base)
5939         <show_exec_info_content>: Declare.
5940         (tui_show_exec_info_content): Don't declare.
5941         * tui/tui-winsource.c
5942         (tui_source_window_base::show_exec_info_content): Rename from
5943         tui_show_exec_info_content.
5944         (tui_source_window_base::update_exec_info): Update.
5945
5946 2019-08-13  Tom Tromey  <tom@tromey.com>
5947
5948         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5949         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5950         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5951         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5952         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5953         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5954         ... here.
5955
5956 2019-08-13  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-winsource.h (struct tui_source_window_base)
5959         <update_exec_info>: Declare.
5960         (tui_update_exec_info): Don't declare.
5961         * tui/tui-winsource.c (tui_update_source_window_as_is)
5962         (tui_source_window_base::refresh_all)
5963         (tui_update_all_breakpoint_info): Update.
5964         (tui_source_window_base::update_exec_info): Rename from
5965         tui_update_exec_info.
5966         * tui/tui-stack.c (tui_show_frame_info): Update.
5967
5968 2019-08-13  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-winsource.h (struct tui_source_window_base)
5971         <set_exec_info_content>: Declare.
5972         (tui_set_exec_info_content): Don't declare.
5973         * tui/tui-winsource.c
5974         (tui_source_window_base::set_exec_info_content): Rename from
5975         tui_set_exec_info_content.
5976         (tui_update_exec_info): Update.
5977
5978 2019-08-13  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui-winsource.h (struct tui_source_window_base)
5981         <show_source_content>: Declare.
5982         (tui_show_source_content): Don't declare.
5983         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5984         (tui_source_window_base::show_source_content): Rename from
5985         tui_show_source_content.
5986         (tui_source_window_base::refresh_all): Update.
5987         * tui/tui-layout.c (show_source_disasm_command)
5988         (show_source_or_disasm_and_command): Update.
5989
5990 2019-08-13  Tom Tromey  <tom@tromey.com>
5991
5992         * tui/tui-winsource.c (tui_erase_source_content)
5993         (tui_show_source_content, tui_source_window_base::refresh_all):
5994         Update.
5995         * tui/tui-wingeneral.h
5996         (tui_check_and_display_highlight_if_needed): Don't declare.
5997         * tui/tui-wingeneral.c
5998         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5999         check_and_display_highlight_if_needed.
6000         * tui/tui-win.c (tui_rehighlight_all)
6001         (tui_win_info::make_visible_with_new_height): Update.
6002         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6003         (tui_data_window::erase_data_content)
6004         (tui_data_window::display_all_data): Update.
6005         * tui/tui-data.h (struct tui_win_info)
6006         <check_and_display_highlight_if_needed>: Declare.
6007
6008 2019-08-13  Tom Tromey  <tom@tromey.com>
6009
6010         * tui/tui-win.c (tui_resize_all): Call
6011         tui_delete_invisible_windows.
6012         * tui/tui-layout.c (show_layout): Call
6013         tui_delete_invisible_windows.
6014         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6015         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6016
6017 2019-08-13  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6020         tui_add_win_to_layout.
6021
6022 2019-08-13  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6025         * tui/tui-layout.c (tui_default_win_height): Now static.
6026
6027 2019-08-13  Tom Tromey  <tom@tromey.com>
6028
6029         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6030         single switch.
6031         (show_source_disasm_command, show_source_or_disasm_and_command):
6032         Don't check current layout.
6033
6034 2019-08-13  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-wingeneral.c (make_all_visible): Remove.
6037         (tui_make_all_invisible): Simplify.
6038         * tui/tui-layout.c (tui_make_all_invisible): Move from
6039         tui-wingeneral.c; simplify.
6040         (show_layout): Hoist call to tui_make_all_invisible.
6041         (show_data): Don't call tui_make_all_invisible.
6042
6043 2019-08-13  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6046         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6047
6048 2019-08-13  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6051         tui-data.c.
6052         (show_source_disasm_command, show_data)
6053         (show_source_or_disasm_and_command): Don't use
6054         tui_set_current_layout_to.
6055         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6056         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6057         tui-layout.c.
6058         (tui_set_current_layout_to): Remove.
6059
6060 2019-08-13  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-layout.c (tui_set_layout): Update.
6063         * tui/tui-data.h (struct tui_layout_def): Remove.
6064         (tui_layout_def): Don't declare.
6065         * tui/tui-data.c (layout_def): Remove.
6066         (tui_layout_def): Remove.
6067
6068 2019-08-13  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-winsource.h (struct tui_source_window_base)
6071         <clear_detail>: No longer "override".
6072         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6073         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6074         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6075         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6076         Remove.
6077         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6078
6079 2019-08-13  Tom Tromey  <tromey@adacore.com>
6080
6081         * tracepoint.c: Don't include readline.h or history.h.
6082
6083 2019-08-12  Tom Tromey  <tom@tromey.com>
6084
6085         * configure: Rebuild.
6086         * configure.ac: Check for readline 7.
6087         * NEWS: Mention readline 7 requirement.
6088         * README: Update.
6089
6090 2019-08-12  Tom Tromey  <tom@tromey.com>
6091
6092         * mingw-hdep.c (gdb_select): Remove readline hack.
6093
6094 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6095
6096         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6097         when the function fails.
6098
6099 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6100
6101         * s390-tdep.c (s390_type_align): New function.
6102         (s390_gdbarch_init): Set it as type_align gdbarch method.
6103
6104 2019-08-09  Tom de Vries  <tdevries@suse.de>
6105
6106         PR gdb/24591
6107         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6108         pc_low with relocation offset.
6109
6110 2019-08-07  Tom Tromey  <tromey@adacore.com>
6111
6112         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6113         (print_frame_args): Update.
6114         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6115         Update.
6116         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6117         * frame.h (struct frame_arg): Add initializers.
6118         <error>: Now a unique_xmalloc_ptr.
6119
6120 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6121
6122         * NEWS: Expand the Pointer Authentication entry.
6123         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6124         (aarch64_frame_unmask_lr): ... to this.
6125         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6126         Call aarch64_frame_unmask_lr.
6127         * frame.c (struct frame_info): Add "masked" variable.
6128         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6129         (fprint_frame): Check for masked pc.
6130         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6131         declarations.
6132         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6133         * stack.c (print_frame): Check for masked pc.
6134
6135 2019-08-06  Tom Tromey  <tom@tromey.com>
6136
6137         * stabsread.c (patch_block_stabs, read_one_struct_field)
6138         (read_enum_type): Use obstack_strndup.
6139         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6140         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6141         * dwarf2read.c (guess_full_die_structure_name)
6142         (anonymous_struct_prefix): Use obstack_strndup.
6143         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6144         * c-exp.y (yylex): Use obstack_strndup.
6145         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6146         (write_var_or_type): Use obstack_strndup.
6147
6148 2019-08-06  Tom Tromey  <tom@tromey.com>
6149
6150         * symfile.c (reread_symbols): Use obstack_strdup.
6151         * stabsread.c (read_type): Use obstack_strdup.
6152         * gdb_obstack.h (obstack_strdup): New overload.
6153         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6154         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6155         (dwarf2_canonicalize_name): Use obstack_strdup.
6156         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6157         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6158         Use obstack_strdup.
6159
6160 2019-08-06  Tom Tromey  <tom@tromey.com>
6161
6162         * gdb_obstack.h (obstack_strdup): Define.
6163         * gdb_obstack.c (obstack_strdup): Don't define.
6164
6165 2019-08-06  Tom Tromey  <tom@tromey.com>
6166
6167         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6168         obstack_strdup.
6169         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6170         obstack_strdup.
6171         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6172         * stabsread.c (common_block_start): Use obstack_strdup.
6173         * objfiles.c (set_objfile_main_name, objfile): Use
6174         obstack_strdup.
6175         * namespace.c (add_using_directive): Use obstack_strdup.
6176         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6177         * jit.c (finalize_symtab): Use obstack_strdup.
6178         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6179         (guess_partial_die_structure_name, partial_die_info::fixup)
6180         (dwarf2_name): Use obstack_strdup.
6181         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6182         obstack_strdup.
6183         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6184         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6185         obstack_strdup.
6186         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6187
6188 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6189
6190         * unittests/help-doc-selftests.c: New file.
6191         * Makefile.in: Add the new file.
6192
6193 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6194
6195         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6196         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6197         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6198         the trailing '.' is not output, and the first character is uppercased.
6199         (print_help_for_command): Update call to print_doc_line.
6200         (print_doc_of_command): Likewise.
6201         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6202         * cli/cli-option.c (append_indented_doc): Do not append newline.
6203         (build_help_option): Append newline after first appended_indented_doc
6204         only if a second call is done.
6205         (build_help): Append 2 new lines before each option, except the first
6206         one.
6207         * compile/compile.c (_initialize_compile): Add new lines after
6208         %OPTIONS%, when not at the end of the help.
6209         Change help doc or code
6210         producing the help doc to respect the invariants.
6211         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6212         Also removed the new line after 'Options:', as all other commands
6213         do not put an empty line between 'Options:' and the first option.
6214         * printcmd.c (_initialize_printcmd): Likewise.
6215         * stack.c (_initialize_stack): Likewise.
6216         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6217         incorrectly telling COMMAND is optional.
6218         * ada-lang.c (_initialize_ada_language): Change help doc or code
6219         producing the help doc to respect the invariants.
6220         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6221         * breakpoint.c (_initialize_breakpoint): Likewise.
6222         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6223         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6224         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6225         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6226         _initialize_cli_style): Likewise.
6227         * corelow.c (core_target_info): Likewise.
6228         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6229         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6230         * filesystem.c (_initialize_filesystem): Likewise.
6231         * frame.c (_initialize_frame): Likewise.
6232         * gnu-nat.c (add_task_commands): Likewise.
6233         * infcall.c (_initialize_infcall): Likewise.
6234         * infcmd.c (_initialize_infcmd): Likewise.
6235         * interps.c (_initialize_interpreter): Likewise.
6236         * language.c (_initialize_language): Likewise.
6237         * linux-fork.c (_initialize_linux_fork): Likewise.
6238         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6239         * maint.c (_initialize_maint_cmds): Likewise.
6240         * memattr.c (_initialize_mem): Likewise.
6241         * printcmd.c (_initialize_printcmd): Likewise.
6242         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6243         _RegEx): Likewise.
6244         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6245         * record-btrace.c (_initialize_record_btrace): Likewise.
6246         * record-full.c (_initialize_record_full): Likewise.
6247         * record.c (_initialize_record): Likewise.
6248         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6249         * regcache.c (_initialize_regcache): Likewise.
6250         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6251         _initialize_remote): Likewise.
6252         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6253         * serial.c (_initialize_serial): Likewise.
6254         * skip.c (_initialize_step_skip): Likewise.
6255         * source.c (_initialize_source): Likewise.
6256         * stack.c (_initialize_stack): Likewise.
6257         * symfile.c (_initialize_symfile): Likewise.
6258         * symtab.c (_initialize_symtab): Likewise.
6259         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6260         * top.c (init_main): Likewise.
6261         * tracefile-tfile.c (tfile_target_info): Likewise.
6262         * tracepoint.c (_initialize_tracepoint): Likewise.
6263         * tui/tui-win.c (_initialize_tui_win): Likewise.
6264         * utils.c (add_internal_problem_command): Likewise.
6265         * valprint.c (value_print_option_defs): Likewise.
6266
6267 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6268
6269         PR build/24886
6270         * configure.ac: Drop enable-libmcheck support.
6271         * configure, config.in: Rebuild.
6272         * libmcheck.m4: Remove.
6273         * acinclude.m4: Don't include it.
6274         * Makefile.in: Don't distribute it.
6275         * top.c (print_gdb_configuration): Don't mention it.
6276
6277 2019-08-06  Tom Tromey  <tom@tromey.com>
6278
6279         * utils.c (set_output_style): Sometimes pass stream to
6280         emit_style_escape.
6281         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6282         * record-btrace.c (btrace_insn_history): Update.
6283         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6284         method.
6285         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6286         Update initializers.
6287         <m_uiout>: New field.
6288         <m_di>: Move lower.
6289         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6290         Remove "uiout" parameter.
6291         (dump_insns): Update.
6292         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6293         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6294
6295 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6296
6297         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6298         (error_in_psymtab_expansion): Likewise.
6299         (lookup_symbol_via_quick_fns): Likewise.
6300         (basic_lookup_transparent_type_quick): Likewise.
6301         (basic_lookup_transparent_type_1): Likewise.
6302
6303 2019-08-06  Tom Tromey  <tromey@adacore.com>
6304
6305         * source.c (last_source_error): Now bool.
6306         (print_source_lines_base): Make "noprint" bool.  Only open
6307         source file when last_source_visited changes.
6308
6309 2019-08-06  Tom Tromey  <tromey@adacore.com>
6310
6311         * annotate.c (annotate_source_line): Use g_source_cache.
6312         * source-cache.c (source_cache::get_plain_source_lines): Change
6313         parameters.  Populate m_offset_cache.
6314         (source_cache::ensure): New method.
6315         (source_cache::get_line_charpos): New method.
6316         (extract_lines): Move lower.  Change parameters.
6317         (source_cache::get_source_lines): Move lower.
6318         * source-cache.h (class source_cache): Update comment.
6319         <get_line_charpos>: New method.
6320         <get_source_lines>: Update comment.
6321         <clear>: Clear m_offset_cache.
6322         <get_plain_source_lines>: Change parameters.
6323         <ensure>: New method
6324         <m_offset_cache>: New member.
6325         * source.c (forget_cached_source_info_for_objfile): Update.
6326         (info_source_command): Use g_source_cache.
6327         (find_source_lines, open_source_file_with_line_charpos): Remove.
6328         (print_source_lines_base, search_command_helper): Use g_source_cache.
6329         * source.h (open_source_file_with_line_charpos): Don't declare.
6330         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6331         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6332         Use g_source_cache.
6333
6334 2019-08-06  Tom Tromey  <tromey@adacore.com>
6335
6336         * source-cache.c (source_cache::get_plain_source_lines):
6337         Remove "first_line" and "last_line" parameters.
6338         (source_cache::get_source_lines): Cache plain text.
6339         * source-cache.h (class source_cache)
6340         <get_plain_source_lines>: Update.
6341
6342 2019-08-06  Tom Tromey  <tromey@adacore.com>
6343
6344         * source-cache.c (extract_lines): No longer a method.
6345         Changed type of parameter.  Include final newline.
6346         (selftests::extract_lines_test): New function.
6347         (_initialize_source_cache): Likewise.
6348         * source-cache.h (class source_cache)
6349         <extract_lines>: Don't declare.
6350
6351 2019-08-06  Tom Tromey  <tromey@adacore.com>
6352
6353         * breakpoint.c (init_breakpoint_sal): Update.
6354         (breakpoint): Update.
6355         * breakpoint.h (struct breakpoint) <filter>: Now a
6356         unique_xmalloc_ptr.
6357
6358 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6359
6360         * NEWS: Mention dictionary access on blocks.
6361         * python/py-block.c (blpy_getitem): New function.
6362         (block_object_as_mapping): New struct.
6363         (block_object_type): Use new struct for tp_as_mapping field.
6364
6365 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6366
6367         * objfiles.h (objfile): Add a comment describing partial symbols.
6368
6369 2019-08-05  Tom Tromey  <tromey@adacore.com>
6370
6371         * compile/compile.c (_initialize_compile): Use _(), not N_().
6372         * thread.c (_initialize_thread): Use _(), not N_().
6373         * stack.c (_initialize_stack): Use _(), not N_().
6374         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6375
6376 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6377
6378         * dwarf2read.c (struct dw2_symtab_iterator):
6379         <want_specific_block>: Remove.
6380         <block_index>: Change type to gdb::optional.
6381         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6382         change type of BLOCK_INDEX parameter to gdb::optional.
6383         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6384         (dw2_lookup_symbol): Don't pass argument for
6385         WANT_SPECIFIC_BLOCK.
6386         (dw2_expand_symtabs_for_function): Don't pass argument for
6387         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6388         (class dw2_debug_names_iterator)
6389         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6390         parameter, change BLOCK_INDEX type to gdb::optional.
6391         <m_want_specific_block>: Remove.
6392         <m_block_index>: Change type to gdb::optional.
6393         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6394         gdb::optional.  Re-write in function of gdb::optional.
6395         (dw2_debug_names_lookup_symbol): Don't pass argument for
6396         WANT_SPECIFIC_BLOCK.
6397         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6398         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6399         BLOCK_INDEX.
6400
6401 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6402
6403         * NEWS: Mention changes to "info sources" command.
6404
6405 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6406
6407         * symtab.c (filename_partial_match_opts): New struct type.
6408         (struct output_source_filename_data): New members
6409         regexp, c_regexp, partial_match.
6410         (output_source_filename): Use new members to decide to print file.
6411         (info_sources_option_defs): New variable.
6412         (make_info_sources_options_def_group, print_info_sources_header,
6413         info_sources_command_completer):
6414         New functions.
6415         (info_sources_command): Read new optional arguments.
6416         (_initialize_symtab): Update info sources help.
6417
6418 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6419
6420         * ada-lang.c (exception_support_info_v0): Renamed from...
6421         (default_exception_support_info): ... this.  Create new
6422         definition for v1.
6423         (ada_has_this_exception_support): Look up catch_handlers_sym.
6424         (ada_exception_support_info_sniffer): Try v0 after default.
6425
6426 2019-08-01  Tom Tromey  <tromey@adacore.com>
6427
6428         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6429         gdbarch.h.
6430
6431 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6432
6433         * s12z-tdep.c: Fix include path for s12z-opc.h.
6434
6435 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6436
6437         * NEWS: Require GNU make 3.82.
6438
6439 2019-07-16  Tom Tromey  <tom@tromey.com>
6440
6441         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6442         declare.
6443
6444 2019-07-30  Tom Tromey  <tromey@adacore.com>
6445
6446         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6447
6448 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6449
6450         * printcmd.c (print_address_symbolic): Print negative offsets.
6451         (build_address_symbolic): Force signed arithmetic when computing
6452         offset.
6453
6454 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6455
6456         PR/24474: Add a function to lookup static variables.
6457         * NEWS: Mention this new function.
6458         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6459         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6460         * python/python.c (python_GdbMethods): Add new function.
6461
6462 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6463
6464         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6465         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6466         (objfpy_lookup_static_symbol): New function.
6467         (objfile_object_methods): Add new functions.
6468
6469 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6470
6471         * NEWS: Mention 'set|show print frame-info'.  Mention new
6472         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6473         backtrace argument.  Mention that python frame filtering code
6474         is now consistent with what 'backtrace' command prints.
6475
6476 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6477
6478         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6479         comments.
6480         (print_frame_info_auto, print_frame_info_source_line,
6481         print_frame_info_location, print_frame_info_source_and_location,
6482         print_frame_info_location_and_address, print_frame_info_short_location):
6483         New declarations.
6484         (struct frame_print_options): New member print_frame_info.
6485         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6486         * stack.h (get_user_print_what_frame_info): New declaration.
6487         (frame_show_address): New declaration.
6488         * stack.c (print_frame_arguments_choices): New value 'presence'.
6489         (print_frame_info_auto, print_frame_info_source_line,
6490         print_frame_info_location, print_frame_info_source_and_location,
6491         print_frame_info_location_and_address, print_frame_info_short_location,
6492         print_frame_info_choices, print_frame_info_print_what): New definitions.
6493         (print_frame_args): Only print dots for args if print frame-arguments
6494         is 'presence'.
6495         (frame_print_option_defs): New element for "frame-info".
6496         (get_user_print_what_frame_info): New function.
6497         (frame_show_address): Make non static.  Move comment to stack.h.
6498         (print_frame_info_to_print_what): New function.
6499         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6500         to decide what to print.
6501         (backtrace_command_1): Handle the new print_frame_arguments_presence
6502         value.
6503         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6504         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6505         (py_print_frame): In non-mi mode, use LOCATION as default for
6506         print_what, similarly to frame information printed directly by
6507         backtrace command. Handle frame-info user option in non MI mode.
6508
6509 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6510
6511         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6512         Add case for debugging 32-bit target on 64-bit host.  Revise
6513         comment.
6514
6515 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6516
6517         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6518         instead of find_function_entry_range_from_pc.
6519
6520 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6521
6522         * stack.c (find_frame_funname): Remove code which preferred
6523         minsym over symtab sym in "certain pathological cases".
6524
6525         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6526         parameter.  Change type of "do_demangle" to bool.
6527         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6528         Pass suitable "prefer_sym_over_minsym" flag to
6529         build_address_symbolic().  Don't output "+" for negative offsets.
6530         * printcmd.c (print_address_symbolic): Update invocation of
6531         build_address_symbolic to include a "prefer_sym_over_minsym"
6532         flag.
6533         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6534         Restrict cases in which use of minimal symbol is preferred to that
6535         of a found symbol.  Update comments.
6536
6537         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6538         for entry pc when entry pc is out of range for that FDE.
6539
6540 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6541
6542         PR gdb/24839:
6543         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6544         type.
6545
6546 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6547
6548         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6549         this function's Python signature.
6550
6551
6552 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6553
6554         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6555         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6556         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6557         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6558         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6559
6560
6561 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6562
6563         * h8300-tdep.c (h8300_register_name_common): New.
6564         h8300_register_name): Use h8300_register_name_common.
6565         (h8300s_register_name): Likewise.
6566         (h8300sx_register_name): Likewise.
6567         (h8300h_register_nam): New.
6568         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6569
6570
6571 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6572
6573         * arm-tdep.c (arm_skip_cmse_entry): New function.
6574         (arm_is_sgstubs_section): New function.
6575         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6576
6577 2019-07-22  Tom Tromey  <tom@tromey.com>
6578
6579         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6580         Don't self-assign.
6581
6582 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6585         type_print.
6586
6587 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6590         so that GDB doesn't match any msymbols when searching in the
6591         TYPES_DOMAIN.
6592         (print_symbol_info): Print using typedef_print or type_print based
6593         on the type of the symbol.  Add updated FIXME comment moved from...
6594         (_initialize_symtab): ... move and update FIXME comment to above.
6595
6596 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * NEWS: Mention adding -q option to "info types".
6599         * symtab.c (struct info_types_options): New struct.
6600         (info_types_options_defs): New variable.
6601         (make_info_types_options_def_group): New function.
6602         (info_types_command): Use gdb::option framework to parse options.
6603         (info_types_command_completer): New function.
6604         (_initialize_symtab): Extend the help text on "info types" and
6605         register command completer.
6606
6607 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6608
6609         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6610         (lookup_symbol_in_objfile): Change int to block_enum and add a
6611         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6612
6613 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6614
6615         * MAINTAINERS (Write After Approval): Add self.
6616
6617 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6620         instruction to the dummy code region.
6621
6622 2019-07-19  Tom Tromey  <tromey@adacore.com>
6623
6624         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6625         (ARGSUSED, PARAMS, __func__): Remove rules.
6626
6627 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6628
6629         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6630         * features/arm/arm-with-iwmmxt.c: Remove.
6631         * features/arm/arm-with-iwmmxt.xml: Remove.
6632         * features/arm/arm-with-m-fpa-layout.c: Remove.
6633         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6634         * features/arm/arm-with-m-vfp-d16.c: Remove.
6635         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6636         * features/arm/arm-with-m.c: Remove.
6637         * features/arm/arm-with-m.xml: Remove.
6638         * features/arm/arm-with-neon.c: Remove.
6639         * features/arm/arm-with-neon.xml: Remove.
6640         * features/arm/arm-with-vfpv2.c: Remove.
6641         * features/arm/arm-with-vfpv2.xml: Remove.
6642         * features/arm/arm-with-vfpv3.c: Remove.
6643         * features/arm/arm-with-vfpv3.xml: Remove.
6644
6645 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6648
6649 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6650
6651         * arch/aarch32.c (aarch32_create_target_description): Create
6652         target descriptions using features.
6653         * arch/arm.c (arm_create_target_description)
6654         (arm_create_mprofile_target_description): Likewise.
6655         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6656
6657 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6658
6659         * Makefile.in: Add new files.
6660         * aarch32-tdep.c: New file.
6661         * aarch32-tdep.h: New file.
6662         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6663         Call aarch32_read_description.
6664         * arch/aarch32.c: New file.
6665         * arch/aarch32.h: New file.
6666         * arch/arm.c (arm_create_target_description)
6667         (arm_create_mprofile_target_description): New function.
6668         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6669         (arm_create_target_description)
6670         (arm_create_mprofile_target_description): New declaration.
6671         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6672         read_description functions.
6673         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6674         Likewise.
6675         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6676         * arm-tdep.c (tdesc_arm_list): New variable.
6677         (arm_register_g_packet_guesses): Call create description functions.
6678         (arm_read_description) (arm_read_mprofile_description): New
6679         function.
6680         * arm-tdep.h (arm_read_description)
6681         (arm_read_mprofile_description): Add declaration.
6682         * configure.tgt: Add new files.
6683
6684 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6685
6686         * top.c (new_ui_command): Open specified terminal just once.
6687
6688 2019-07-18  Tom Tromey  <tromey@adacore.com>
6689
6690         * symtab.c (main_name): Constify return type.
6691         * symfile.c (set_initial_language): Update.
6692         * symtab.h (main_name): Constify return type.
6693
6694 2019-07-17  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-winsource.c (tui_update_source_window)
6697         (tui_update_source_window_as_is)
6698         (tui_update_source_windows_with_line): Remove return.
6699         * tui/tui-disasm.c (tui_show_disassem)
6700         (tui_show_disassem_and_update_source): Remove return.
6701         * tui/tui.c (tui_reset): Remove return.
6702         * tui/tui-wingeneral.c
6703         (tui_check_and_display_highlight_if_needed): Remove return.
6704
6705 2019-07-17  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6708
6709 2019-07-17  Tom Tromey  <tom@tromey.com>
6710
6711         * tui/tui-winsource.h (struct tui_exec_info_window)
6712         (struct tui_source_window_base): Move from tui-data.h.
6713         * tui/tui-winsource.c: Move many method definitions from
6714         elsewhere.  Remove "structuring" comments.
6715         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6716         (tui_source_window_base::refresh_window): Move to
6717         tui-winsource.c.
6718         * tui/tui-win.c (tui_source_window_base::refresh_all)
6719         (tui_source_window_base::update_tab_width)
6720         (tui_source_window_base::set_new_height)
6721         (tui_source_window_base::do_make_visible_with_new_height): Move to
6722         tui-winsource.c.
6723         * tui/tui-source.h: Update.
6724         * tui/tui-source.c (tui_source_window_base::reset): Move to
6725         tui-winsource.c.
6726         * tui/tui-disasm.h: Update.
6727         * tui/tui-data.h (struct tui_exec_info_window): Move to
6728         tui-winsource.h.
6729         (struct tui_source_window_base): Likewise.
6730         * tui/tui-data.c (tui_source_window_base::clear_detail)
6731         (tui_source_window_base, ~tui_source_window_base): Move to
6732         tui-winsource.c.
6733
6734 2019-07-17  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-win.c (tui_resize_all)
6737         (tui_source_window_base::update_tab_width)
6738         (tui_adjust_win_heights): Update.
6739         (tui_win_info::make_invisible_and_set_new_height): Rename from
6740         make_invisible_and_set_new_height.
6741         * tui/tui-data.h (struct tui_win_info)
6742         <make_invisible_and_set_new_height>: New method.
6743
6744 2019-07-17  Tom Tromey  <tom@tromey.com>
6745
6746         * tui/tui.c: Update.
6747         * tui/tui-source.h (struct tui_source_window): Move from
6748         tui-data.h.
6749         * tui/tui-layout.c: Update.
6750         * tui/tui-disasm.c: Update.
6751         * tui/tui-data.h (struct tui_source_window): Move to
6752         tui-source.h.
6753
6754 2019-07-17  Tom Tromey  <tom@tromey.com>
6755
6756         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6757         tui-data.h.
6758         * tui/tui-data.h (struct tui_disasm_window): Move to
6759         tui-disasm.h.
6760
6761 2019-07-17  Tom Tromey  <tom@tromey.com>
6762
6763         * tui/tui-regs.h (struct tui_data_item_window): Move from
6764         tui-data.h.
6765         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6766         * tui/tui-data.h (struct tui_data_item_window): Move to
6767         tui-regs.h.
6768         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6769
6770 2019-07-17  Tom Tromey  <tom@tromey.com>
6771
6772         * tui/tui.c: Update.
6773         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6774         (tui_cmd_window::max_height): Move to tui-command.c.
6775         * tui/tui-layout.c: Update.
6776         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6777         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6778         tui-command.c.
6779         * tui/tui-command.h (struct tui_cmd_window): Move from
6780         tui-data.h.
6781         * tui/tui-command.c: Remove "structuring" comments.
6782         (tui_cmd_window::clear_detail)
6783         (tui_cmd_window::do_make_visible_with_new_height)
6784         (tui_cmd_window::max_height): Move from elsewhere.
6785
6786 2019-07-17  Tom Tromey  <tom@tromey.com>
6787
6788         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6789         Now static.
6790         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6791         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6792
6793 2019-07-17  Tom Tromey  <tom@tromey.com>
6794
6795         * tui/tui.c: Update.
6796         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6797         tui-regs.c.
6798         * tui/tui-windata.h: Remove file.
6799         * tui/tui-windata.c: Remove file.
6800         * tui/tui-win.c (tui_data_window::set_new_height)
6801         (tui_data_window::do_make_visible_with_new_height): Move to
6802         tui-regs.c.
6803         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6804         * tui/tui-regs.c: Remove "structuring" comments.
6805         (tui_data_window::first_data_item_displayed)
6806         (tui_data_window::delete_data_content_windows)
6807         (tui_data_window::erase_data_content)
6808         (tui_data_window::display_all_data)
6809         (tui_data_window::refresh_all)
6810         (tui_data_window::do_scroll_vertical)
6811         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6812         (tui_data_window::do_make_visible_with_new_height)
6813         (tui_data_window::refresh_window): Move from elsewhere.
6814         (_initialize_tui_regs): Move to end of file.
6815         * tui/tui-layout.c: Update.
6816         * tui/tui-hooks.c: Update.
6817         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6818         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6819         tui-regs.c.
6820         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6821
6822 2019-07-17  Tom Tromey  <tom@tromey.com>
6823
6824         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6825         seen.
6826
6827 2019-07-17  Tom Tromey  <tom@tromey.com>
6828
6829         * tui/tui-win.c (tui_source_window_base::set_new_height)
6830         (tui_source_window_base::do_make_visible_with_new_height): Use
6831         m_has_locator field directly.
6832         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6833         method.
6834         (struct tui_source_window_base) <has_locator>: Likewise.
6835
6836 2019-07-17  Tom Tromey  <tom@tromey.com>
6837
6838         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6839         Don't declare.
6840         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6841         Remove.
6842         * tui/tui-win.c (tui_source_window_base::set_new_height)
6843         (tui_source_window_base::set_new_height)
6844         (make_invisible_and_set_new_height)
6845         (tui_source_window_base::do_make_visible_with_new_height)
6846         (tui_source_window_base::do_make_visible_with_new_height):
6847         Update.
6848         * tui/tui-layout.c (show_source_disasm_command, show_data)
6849         (show_source_or_disasm_and_command): Update.
6850         * tui/tui-layout.c (show_layout): Update.
6851
6852 2019-07-17  Tom Tromey  <tom@tromey.com>
6853
6854         * tui/tui-layout.c (make_data_window): Remove.
6855         (show_data): Unify creation and re-initialization cases.
6856
6857 2019-07-17  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-layout.c (make_source_window, make_disasm_window):
6860         Remove.
6861         (show_data): Unify creation and re-initialization cases.
6862
6863 2019-07-17  Tom Tromey  <tom@tromey.com>
6864
6865         * tui/tui-layout.c (make_command_window): Remove.
6866         (show_source_disasm_command, show_source_or_disasm_and_command):
6867         Unify creation and re-initialization cases.
6868
6869 2019-07-17  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6872         creation and re-initialization cases.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-regs.c (tui_get_register): Return void.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6881         Simplify.
6882
6883 2019-07-17  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6886         resetting.
6887
6888 2019-07-17  Tom Tromey  <tom@tromey.com>
6889
6890         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6891         * tui/tui-regs.c (tui_reg_layout): New function.
6892         (tui_show_registers, tui_reg_command): Use it.
6893         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6894         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6895         parameters.
6896         (tui_layout_command): Remove.
6897
6898 2019-07-17  Tom Tromey  <tom@tromey.com>
6899
6900         * tui/tui-layout.h (tui/tui-layout): Return void.
6901         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6902
6903 2019-07-17  Tom Tromey  <tom@tromey.com>
6904
6905         * tui/tui-layout.c (show_source_disasm_command, show_data):
6906         Update.
6907         (reset_locator): Remove.
6908         (show_source_or_disasm_and_command): Update.
6909
6910 2019-07-17  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-source.c (tui_source_window_base::reset): Remove
6913         win_type parameter.
6914         * tui/tui-layout.c (make_command_window, make_source_window)
6915         (make_disasm_window, make_data_window)
6916         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6917         (reset_locator, show_source_or_disasm_and_command): Update.
6918         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6919         win_type parameter.
6920         (struct tui_source_window_base) <reset>: Likewise.
6921
6922 2019-07-17  Tom Tromey  <tom@tromey.com>
6923
6924         * tui/tui-layout.c (show_source_disasm_command): Use
6925         reset_locator.
6926         (reset_locator): New function.
6927         (init_and_make_win): Remove.
6928         (show_source_or_disasm_and_command): Use reset_locator.
6929
6930 2019-07-17  Tom Tromey  <tom@tromey.com>
6931
6932         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6933         condition.
6934         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6935         Remove condition.
6936         * tui/tui-source.c (tui_source_window_base::reset): New method.
6937         * tui/tui-layout.c (make_command_window): Don't call
6938         init_and_make_win.
6939         (make_source_window, make_disasm_window): Don't call
6940         make_source_or_disasm_window.
6941         (make_data_window): Don't call init_and_make_win.  Change calling
6942         convention.
6943         (show_source_disasm_command, show_data): Simplify.
6944         (make_source_or_disasm_window): Remove.
6945         (show_source_or_disasm_and_command): Simplify.
6946         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6947         (struct tui_source_window_base) <reset>: Likewise.
6948         <execution_info>: Remove initializer.
6949         * tui/tui-data.c (tui_source_window_base): Initialize
6950         execution_info.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6955         variable.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui.c (tui_rl_other_window): Update.
6960         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6961         superclass method first.  Always iterate over regs_content.
6962         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6963         method.
6964         * tui/tui-win.c (tui_set_focus_command): Update.
6965
6966 2019-07-17  Tom Tromey  <tom@tromey.com>
6967
6968         * tui/tui-win.c (tui_set_focus_command): Rename from
6969         tui_set_focus.  Call tui_enable.
6970         (tui_set_focus_command): Remove.
6971
6972 2019-07-17  Tom Tromey  <tom@tromey.com>
6973
6974         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6975         refresh_window.
6976         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6977         touchwin.
6978         (tui_data_window::refresh_window): Call refresh_window on data
6979         items.  Always call superclass refresh_window.
6980         (tui_win_info::refresh): Remove.
6981         (tui_source_window_base::refresh_window): Update.
6982         (tui_refresh_all): Update.
6983         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6984         refresh_window.
6985         (show_source_or_disasm_and_command): Likewise.
6986         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6987         (struct tui_source_window_base) <refresh>: Likewise.
6988
6989 2019-07-17  Tom Tromey  <tom@tromey.com>
6990
6991         * tui/tui-winsource.c (tui_clear_source_content)
6992         (tui_show_source_content): Update.
6993         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6994         whether content is empty.
6995         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6996         Remove.
6997
6998 2019-07-17  Tom Tromey  <tom@tromey.com>
6999
7000         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7001         window's contents.
7002         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7003         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7004
7005 2019-07-17  Tom Tromey  <tom@tromey.com>
7006
7007         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7008         (struct tui_data_item_window): Update.
7009
7010 2019-07-17  Tom Tromey  <tom@tromey.com>
7011
7012         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7013         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7014         defines.
7015
7016 2019-07-17  Tom Tromey  <tom@tromey.com>
7017
7018         * tui/tui-winsource.h (tui_erase_source_content)
7019         (tui_clear_source_content): Remove "display_prompt" parameter.
7020         * tui/tui-winsource.c (tui_update_source_window_as_is)
7021         (tui_update_source_windows_with_addr): Update.
7022         (tui_clear_source_content): Remove "display_prompt" parameter.
7023         (tui_erase_source_content): Likewise.  Simplify.
7024         (tui_show_source_content): Update.
7025         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7026         * tui/tui-stack.c (tui_show_frame_info): Update.
7027         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7028         Remove defines.
7029
7030 2019-07-17  Tom Tromey  <tom@tromey.com>
7031
7032         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7033         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7034         parameter.
7035         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7036         parameter.
7037
7038 2019-07-17  Tom Tromey  <tom@tromey.com>
7039
7040         * tui/tui-winsource.c (tui_clear_source_content)
7041         (tui_show_source_content, tui_show_exec_info_content)
7042         (tui_clear_exec_info_content): Update.
7043         * tui/tui-stack.c (tui_show_locator_content): Update.
7044         (tui_show_frame_info): Update.
7045         * tui/tui-source.h (tui_source_window): Don't declare.
7046         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7047         from tui_source_is_displayed.
7048         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7049         Remove field.
7050         (struct tui_source_window_base) <content_in_use>: New field.  Now
7051         bool.
7052         (struct tui_source_window) <showing_source_p>: New method.
7053         (TUI_SRC_WIN): Change cast.
7054         * tui/tui-data.c (tui_initialize_static_data): Update.
7055
7056 2019-07-17  Tom Tromey  <tom@tromey.com>
7057
7058         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7059         location_matches_p.
7060         * tui/tui-source.c (tui_source_window::location_matches_p): New
7061         method.
7062         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7063         method.
7064         * tui/tui-data.h (struct tui_source_window_base)
7065         <location_matches_p>: New method.
7066         (struct tui_source_window, struct tui_disasm_window)
7067         <location_matches_p>: Likewise.
7068
7069 2019-07-17  Tom Tromey  <tom@tromey.com>
7070
7071         * tui/tui-win.c (tui_set_win_height_command): Rename from
7072         tui_set_win_height.
7073         (tui_set_win_height_command): Remove.
7074
7075 2019-07-17  Tom Tromey  <tom@tromey.com>
7076
7077         * tui/tui-source.c (tui_source_window): New constructor.  Add
7078         observer.
7079         (~tui_source_window): New destructor.
7080         (tui_source_window::style_changed): New method.
7081         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7082         (tui_attach_detach_observers): Update.
7083         * tui/tui-data.h (struct tui_source_window): Make constructor not
7084         inline.  Add destructor.
7085         (struct tui_source_window) <style_changed>: New method.
7086         <m_observable>: New member.
7087
7088 2019-07-17  Tom Tromey  <tom@tromey.com>
7089
7090         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7091         * tui/tui-win.c (tui_resize_all): Fix typo.
7092
7093 2019-07-17  Tom Tromey  <tom@tromey.com>
7094
7095         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7096         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7097         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7098         * tui/tui-win.c (window_name_completer): Use foreach.
7099         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7100         (update_tab_width): Likewise.
7101         * tui/tui-layout.c (show_layout): Update.
7102         * tui/tui-data.h (class tui_window_iterator): New.
7103         (struct all_tui_windows): New.
7104         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7105
7106 2019-07-17  Tom Tromey  <tom@tromey.com>
7107
7108         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7109         parameter.  Don't reference globals.
7110         (tui_reg_command): Update.
7111
7112 2019-07-17  Tom Tromey  <tom@tromey.com>
7113
7114         * tui/tui-regs.c (tui_show_registers): Simplify.
7115
7116 2019-07-17  Tom Tromey  <tom@tromey.com>
7117
7118         * tui/tui-regs.c (tui_show_registers): Update.
7119         (tui_show_register_group): Add win_info parameter.
7120
7121 2019-07-17  Tom Tromey  <tom@tromey.com>
7122
7123         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7124         Rename from tui_display_reg_element_at_line.
7125         (tui_data_window::display_registers_from_line): Update.
7126         * tui/tui-data.h (struct tui_data_window)
7127         <display_reg_element_at_line>: New method.
7128
7129 2019-07-17  Tom Tromey  <tom@tromey.com>
7130
7131         * tui/tui-regs.h (tui_display_registers_from)
7132         (tui_display_registers_from_line): Don't declare.
7133         * tui/tui-windata.c (tui_data_window::display_all_data)
7134         (tui_data_window::refresh_all)
7135         (tui_data_window::do_scroll_vertical): Update.
7136         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7137         from tui_display_registers_from.
7138         (tui_display_reg_element_at_line): Update.
7139         (tui_data_window::display_registers_from_line): Rename from
7140         tui_display_registers_from_line.
7141         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7142         display_registers_from_line>: New methods.
7143
7144 2019-07-17  Tom Tromey  <tom@tromey.com>
7145
7146         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7147         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7148         from tui_erase_data_content.
7149         (tui_data_window::display_all_data)
7150         (tui_data_window::refresh_all)
7151         (tui_data_window::do_scroll_vertical): Update.
7152         * tui/tui-regs.c (tui_show_registers): Update.
7153         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7154         New method.
7155
7156 2019-07-17  Tom Tromey  <tom@tromey.com>
7157
7158         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7159         declare.
7160         * tui/tui-windata.c
7161         (tui_data_window::delete_data_content_windows): Rename from
7162         tui_delete_data_content_windows.
7163         (tui_data_window::display_all_data)
7164         (tui_data_window::do_scroll_vertical): Update.
7165         * tui/tui-data.h (struct tui_data_window)
7166         <delete_data_content_windows>: New method.
7167
7168 2019-07-17  Tom Tromey  <tom@tromey.com>
7169
7170         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7171         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7172
7173 2019-07-17  Tom Tromey  <tom@tromey.com>
7174
7175         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7176         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7177         from tui_display_all_data.
7178         * tui/tui-win.c
7179         (tui_data_window::do_make_visible_with_new_height): Update.
7180         * tui/tui-regs.c (tui_show_registers): Update.
7181         * tui/tui-layout.c (tui_set_layout): Update.
7182         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7183         method.
7184
7185 2019-07-17  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7188         * tui/tui-windata.c (tui_display_data_from): Remove.
7189         (tui_data_window::refresh_all): Update.
7190
7191 2019-07-17  Tom Tromey  <tom@tromey.com>
7192
7193         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7194         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7195         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7196         tui_display_registers_from_line.
7197         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7198         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7199         "force_display" parameter.
7200
7201 2019-07-17  Tom Tromey  <tom@tromey.com>
7202
7203         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7204         declare.
7205         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7206         Rename from tui_first_reg_element_no_inline.
7207         (tui_display_reg_element_at_line)
7208         (tui_display_registers_from_line): Update.
7209         * tui/tui-data.h (struct tui_data_window)
7210         <first_reg_element_no_inline>: New method.
7211
7212 2019-07-17  Tom Tromey  <tom@tromey.com>
7213
7214         * tui/tui-windata.c (tui_display_data_from)
7215         (tui_data_window::do_scroll_vertical): Update.
7216         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7217         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7218         Rename from tui_line_from_reg_element_no.
7219         (tui_display_registers_from_line): Update.
7220         * tui/tui-data.h (struct tui_data_window)
7221         <line_from_reg_element_no>: New method.
7222
7223 2019-07-17  Tom Tromey  <tom@tromey.com>
7224
7225         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7226         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7227         tui_last_regs_line_no.
7228         (tui_display_reg_element_at_line)
7229         (tui_display_registers_from_line): Update.
7230         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7231         method.
7232
7233 2019-07-17  Tom Tromey  <tom@tromey.com>
7234
7235         PR tui/24722:
7236         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7237         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7238         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7239         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7240         (tui_update_breakpoint_info): Likewise.
7241         * tui/tui-hooks.c (tui_event_create_breakpoint)
7242         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7243         Update.
7244
7245 2019-07-17  Tom Tromey  <tom@tromey.com>
7246
7247         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7248
7249 2019-07-17  Tom Tromey  <tom@tromey.com>
7250
7251         * tui/tui-winsource.c (tui_update_source_window_as_is)
7252         (tui_update_source_windows_with_addr): Update.
7253         * tui/tui-source.h (tui_set_source_content)
7254         (tui_show_symtab_source): Add "win_info" parameter.
7255         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7256         parameter.
7257         (tui_show_symtab_source): Likewise.
7258
7259 2019-07-17  Tom Tromey  <tom@tromey.com>
7260
7261         * tui/tui-wingeneral.c
7262         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7263
7264 2019-07-17  Tom Tromey  <tom@tromey.com>
7265
7266         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7267         (struct tui_cmd_window) <can_scroll>: New method.
7268         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7269         method.
7270
7271 2019-07-17  Tom Tromey  <tromey@adacore.com>
7272
7273         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7274         do_field_signed>: Rename.  Change type of "value".
7275         * ui-out.c (ui_out::field_signed): Rename from field_int.
7276         Change type of "value".
7277         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7278         type of "value".
7279         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7280         do_field_int.  Change type of "value".
7281         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7282         do_field_int.  Change type of "value".
7283         * tracepoint.c (trace_status_mi, tfind_1)
7284         (print_one_static_tracepoint_marker): Update.
7285         * thread.c (print_thread_info_1, print_selected_thread_frame):
7286         Update.
7287         * stack.c (print_frame, print_frame_info): Update.
7288         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7289         Update.
7290         * source.c (print_source_lines_base): Update.
7291         * skip.c (info_skip_command): Update.
7292         * record-btrace.c (btrace_ui_out_decode_error)
7293         (btrace_call_history_src_line): Update.
7294         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7295         Update.
7296         * progspace.c (print_program_space): Update.
7297         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7298         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7299         do_field_int.  Change type of "value".
7300         * mi/mi-out.c (mi_ui_out::do_table_begin)
7301         (mi_ui_out::do_table_header): Update.
7302         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7303         type of "value".
7304         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7305         (mi_cmd_data_list_changed_registers, output_register)
7306         (mi_cmd_data_read_memory, mi_load_progress)
7307         (mi_cmd_trace_frame_collected): Update.
7308         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7309         Update.
7310         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7311         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7312         (mi_cmd_var_list_children, varobj_update_one): Update.
7313         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7314         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7316         * inferior.c (print_inferior): Update.
7317         * gdb_bfd.c (print_one_bfd): Update.
7318         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7319         Update.
7320         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7321         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7322         do_field_int.  Change type of "value".
7323         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7324         do_field_int.  Change type of "value".
7325         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7326         (print_one_breakpoint_location, print_it_catch_fork)
7327         (print_one_catch_fork, print_it_catch_vfork)
7328         (print_one_catch_vfork, print_it_catch_solib)
7329         (print_it_catch_exec, print_it_ranged_breakpoint)
7330         (print_mention_watchpoint, print_mention_masked_watchpoint)
7331         (bkpt_print_it, update_static_tracepoint): Update.
7332         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7333         * break-catch-syscall.c (print_it_catch_syscall): Update.
7334         * ada-tasks.c (print_ada_task_info): Update.
7335         * ada-lang.c (print_it_exception, print_mention_exception):
7336         Update.
7337
7338 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7339
7340         PR breakpoints/24541
7341         * gdbarch.c: Regenerate.
7342         * gdbarch.h: Regenerate.
7343         * gdbarch.sh: Adjust return type and parameter types for
7344         'stap_adjust_register'.
7345         (i386_stap_adjust_register): Adjust signature and return new
7346         register name.
7347         * stap-probe.c (stap_parse_register_operand): Adjust use of
7348         'gdbarch_stap_adjust_register'.
7349
7350 2019-07-17  Tom Tromey  <tromey@adacore.com>
7351
7352         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7353         declare VEC.
7354         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7355         std::vector.
7356         (struct s390_process_info): Add initializers.
7357         (s390_add_process): Use new.
7358         (s390_linux_nat_target::low_forget_process): Use delete.
7359         (s390_linux_nat_target::low_new_fork)
7360         (s390_linux_nat_target::stopped_by_watchpoint)
7361         (s390_linux_nat_target::low_prepare_to_resume)
7362         (s390_linux_nat_target::insert_watchpoint)
7363         (s390_linux_nat_target::insert_hw_breakpoint)
7364         (s390_linux_nat_target::remove_watchpoint)
7365         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7366
7367 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7368
7369         * aarch64-fbsd-nat.c: Include regcache.h.
7370         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7371         argument.
7372         (aarch64_fbsd_nat_target::fetch_registers)
7373         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7374         variable.
7375         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7376
7377 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7378
7379         * fbsd-nat.c: Include gdbarch.h.
7380
7381 2019-07-15  Tom Tromey  <tromey@adacore.com>
7382
7383         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7384
7385 2019-07-15  Tom Tromey  <tromey@adacore.com>
7386
7387         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7388         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7389         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7390         * cli-out.c (cli_ui_out::do_field_int): New method.
7391         * ui-out.c (ui_out::field_unsigned): New method.
7392         * symfile.c (generic_load): Use field_unsigned.
7393         (print_transfer_performance): Likewise.
7394         * record-btrace.c (ui_out_field_uint): Remove.
7395         (btrace_call_history_insn_range, btrace_call_history): Use
7396         field_unsigned.
7397         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7398         field_unsigned.
7399         * ui-out.h (class ui_out) <field_unsigned>: New method.
7400         <do_field_unsigned>: Likewise.
7401
7402 2019-07-15  Tom Tromey  <tromey@adacore.com>
7403
7404         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7405         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7406         * target.c (flash_erase_command): Use field_string.
7407         * infrun.c (print_signal_received_reason): Use field_string.
7408         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7409         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7410         field_string.
7411         * ada-tasks.c (print_ada_task_info): Use field_string.
7412
7413 2019-07-15  Tom Tromey  <tromey@adacore.com>
7414
7415         * target.c (flash_erase_command): Use field_core_addr.
7416         * symfile.c (generic_load): Use field_core_addr.
7417         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7418         Use field_core_addr.
7419         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7420         field_core_addr.
7421
7422 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7423
7424         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7425         value if its desired type is smaller than a CORE_ADDR and signed.
7426
7427 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7428
7429         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7430         of changes to field names, and use new is_reference field to
7431         decide if a property is a reference or not.
7432         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7433         field.
7434         (struct dwarf2_property_baton): Update header comment, rename
7435         'referenced_type' to 'property_type' and update comments.
7436         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7437         default property type, store in property baton, update to take
7438         accound of renamed field.
7439         (read_func_scope): Update call to attr_to_dynamic_prop.
7440         (read_array_type): Likewise.
7441         (dwarf2_per_cu_addr_sized_int_type): New function.
7442         (read_subrange_index_type): Move type finding code to
7443         dwarf2_per_cu_addr_sized_int_type.
7444         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7445         (dwarf2_per_cu_addr_type): New function.
7446         (set_die_type): Update calls to attr_to_dynamic_prop.
7447
7448 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * dwarf2read.c (read_subrange_index_type): New function.
7451         (read_subrange_type): Move code into new function and call it.
7452         * gdbtypes.c (create_range_type): Add some asserts.
7453
7454 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7457         update return statements.
7458         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7459         declaration, and update comment to match.
7460         * gdbtypes.c (resolve_dynamic_array): Update call to
7461         dwarf2_evaluate_property to match new return type.
7462
7463 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7464
7465         * valarith.c (value_subscripted_rvalue): Change lowerbound
7466         parameter type from int to LONGEST.
7467         * value.h (value_subscripted_rvalue): Likewise in declaration.
7468
7469 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * cli/cli-utils.c (info_print_command_completer): New function.
7472         * cli/cli-utils.h: Add 'completer.h' include, and forward
7473         declaration for 'struct cmd_list_element'.
7474         (info_print_command_completer): Declare.
7475         * stack.c (_initialize_stack): Add completer for 'info locals' and
7476         'info args'.
7477         * symtab.c (_initialize_symtab): Add completer for 'info
7478         variables' and 'info functions'.
7479         * NEWS: Mention completion for additional info commands.
7480
7481 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * cli/cli-utils.c (extract_info_print_args): Delete.
7484         (extract_arg_maybe_quoted): Delete.
7485         (info_print_options_defs): New variable.
7486         (make_info_print_options_def_group): New function.
7487         (extract_info_print_options): Define new function.
7488         * cli/cli-utils.h (extract_info_print_args): Delete.
7489         (struct info_print_options): New structure.
7490         (extract_info_print_options): Declare new function.
7491         * stack.c (info_locals_command): Update to use new
7492         extract_info_print_options, also add a header comment.
7493         (info_args_command): Likewise.
7494         * symtab.c (info_variables_command): Likewise.
7495         (info_functions_command): Likewise.
7496
7497 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7498
7499         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7500         to extract string arguments.
7501         * common/common-utils.c (extract_string_maybe_quoted): New function.
7502         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7503
7504 2019-07-11  Tom Tromey  <tromey@adacore.com>
7505
7506         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7507         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7508         * top.h (gdbinit): Don't declare.
7509         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7510         into...
7511         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7512         * top.c (gdb_init): Don't call init_cli_cmds.
7513         (gdbinit): Remove.
7514         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7515
7516 2019-07-11  Tom Tromey  <tromey@adacore.com>
7517
7518         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7519         after it has been moved.
7520
7521 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7522
7523         * valops.c (value_must_coerce_to_target): Change return type to
7524         bool.
7525         * value.h (value_must_coerce_to_target): Likewise.
7526
7527 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7528
7529         * breakpoint.c (is_hardware_watchpoint): Remove
7530         forward-declaration.
7531         (is_masked_watchpoint): Change return type to bool.
7532         (is_tracepoint): Likewise.
7533         (is_breakpoint): Likewise.
7534         (is_hardware_watchpoint): Likewise.
7535         (is_watchpoint): Likewise.
7536         (is_no_memory_software_watchpoint): Likewise.
7537         (is_catchpoint): Likewise.
7538         (breakpoint_1): Make FILTER parameter's return type bool.
7539         is_masked_watchpoint): Change return type to bool.
7540         (save_breakpoints): Make FILTER parameter's return type bool.
7541         * breakpoint.h (is_breakpoint): Change return type to bool.
7542         (is_watchpoint): Likewise.
7543         (is_catchpoint): Likewise.
7544         (is_tracepoint): Likewise.
7545
7546 2019-07-10  Tom Tromey  <tom@tromey.com>
7547
7548         * defs.h: Don't include gdbarch.h.
7549         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7550         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7551         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7552         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7553         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7554         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7555         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7556         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7557         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7558         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7559         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7560         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7561         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7562         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7563         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7564         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7565         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7566         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7567         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7568         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7569         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7570         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7571         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7572         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7573         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7574         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7575         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7576
7577 2019-07-10  Tom Tromey  <tromey@adacore.com>
7578
7579         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7580         * breakpoint.c (init_ada_exception_breakpoint): Register as
7581         bp_catchpoint.
7582         (print_one_breakpoint_location, print_one_breakpoint): Use
7583         is_ada_exception_catchpoint.
7584         * ada-lang.c (class ada_catchpoint_location): Pass
7585         bp_loc_software_breakpoint to bp_location constructor.
7586         (is_ada_exception_catchpoint): New function.
7587
7588 2019-07-10  Tom Tromey  <tromey@adacore.com>
7589
7590         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7591         VEC.
7592         (struct arm_exidx_entry): New method operator<.
7593         (struct arm_exidx_data) <section_maps>: Change type.
7594         (arm_exidx_data_free): Remove.
7595         (arm_exidx_data_key): Change type.  Move lower.
7596         (arm_exidx_new_objfile): Update.
7597         (arm_compare_exidx_entries): Remove.
7598         (arm_find_exidx_entry, _initialize_arm_tdep)
7599
7600 2019-07-10  Tom Tromey  <tromey@adacore.com>
7601
7602         * solib-spu.c (ocl_program_data_key): Change type.
7603         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7604         Update.
7605
7606 2019-07-10  Tom Tromey  <tromey@adacore.com>
7607
7608         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7609         (struct solib_aix_inferior_data) <library_list>: Change type.
7610         (solib_aix_inferior_data_handle): Change type.
7611         (get_solib_aix_inferior_data): Update.
7612         (solib_aix_free_library_list): Remove.
7613         (library_list_start_library): Update.
7614         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7615         return type.
7616         (solib_aix_get_library_list)
7617         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7618         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7619
7620 2019-07-10  Tom Tromey  <tromey@adacore.com>
7621
7622         * solib-dsbt.c (struct dsbt_info): Add initializers.
7623         (solib_dsbt_pspace_data): Change type.
7624         (dsbt_pspace_data_cleanup): Remove.
7625         (get_dsbt_info, _initialize_dsbt_solib): Update.
7626
7627 2019-07-10  Tom Tromey  <tromey@adacore.com>
7628
7629         * spu-tdep.c (spu_overlay_data): Change type.
7630         (spu_get_overlay_table, spu_overlay_new_objfile)
7631         (_initialize_spu_tdep): Update.
7632
7633 2019-07-10  Tom Tromey  <tromey@adacore.com>
7634
7635         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7636         destructor.
7637         (dbx_objfile_data_key): Change type and declare later.
7638         (DBX_SYMFILE_INFO): Rewrite.
7639         * dbxread.c (dbx_objfile_data_key): Change type.
7640         (dbx_symfile_init): Update.
7641         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7642         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7643         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7644
7645 2019-07-10  Tom Tromey  <tromey@adacore.com>
7646
7647         * jit.c (jit_program_space_key): Change type.  Move lower.
7648         (get_jit_program_space_data): Update.
7649         (jit_program_space_data_cleanup): Remove.
7650         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7651         Update.
7652         (struct jit_program_space_data): Add initializers.
7653
7654 2019-07-10  Tom Tromey  <tromey@adacore.com>
7655
7656         * solib-darwin.c (struct darwin_info): Add initializers.
7657         (solib_darwin_pspace_data): Change type.
7658         (darwin_pspace_data_cleanup): Remove.
7659         (get_darwin_info, _initialize_darwin_solib): Update.
7660
7661 2019-07-10  Tom Tromey  <tromey@adacore.com>
7662
7663         * remote-sim.c (struct sim_inferior_data): Add initializers,
7664         constructor, and destructor.
7665         (sim_inferior_data_key): Change type.  Move lower.
7666         (check_for_duplicate_sim_descriptor): Update.
7667         (get_sim_inferior_data): Use new.  Update.
7668         (~sim_inferior_data_cleanup): Rename from
7669         sim_inferior_data_cleanup.  Simplify.
7670         (gdbsim_close_inferior, simulator_command)
7671         (sim_command_completer, _initialize_remote_sim): Update.
7672         (next_pid, INITIAL_PID): Move earlier.
7673
7674 2019-07-10  Tom Tromey  <tromey@adacore.com>
7675
7676         * python/python-internal.h (create_thread_object): Return
7677         gdbpy_ref.
7678         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7679         * python/py-inferior.c (struct threadlist_entry): Add
7680         constructor.
7681         <thread_obj>: Now a gdbpy_ref.
7682         (thread_to_thread_object): Update.
7683         (add_thread_object): Use new.
7684         (delete_thread_object): Use delete.
7685         (infpy_threads): Update.
7686         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7687         GIL.
7688
7689 2019-07-10  Tom Tromey  <tromey@adacore.com>
7690
7691         * valops.c (value_cast): Specialize error message for Ada.
7692
7693 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7694
7695         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7696
7697 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7698
7699         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7700         bpstat_should_step): Return bool, adjust comments.
7701         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7702         bpstat_should_step): Likewise.
7703
7704 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7705
7706         * features/Makefile: Use feature target descriptions for Arm.
7707         * features/arm/arm-core.c: Generate new file.
7708         * features/arm/arm-fpa.c: Likewise.
7709         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7710         * features/arm/arm-m-profile.c: Likewise.
7711         * features/arm/arm-vfpv2.c: Likewise.
7712         * features/arm/arm-vfpv3.c: Likewise.
7713         * features/arm/xscale-iwmmxt.c: Likewise.
7714         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7715
7716 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7717
7718         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7719         ptrace earlier.
7720
7721 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7722
7723         * features/aarch64-pauth.c: Regenerate.
7724
7725 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7726
7727         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7728         bool.
7729         (bpstat_what): Use false instead of 0.
7730
7731 2019-07-09  Pedro Alves  <palves@redhat.com>
7732
7733         * break-catch-throw.c (is_exception_catchpoint): New.
7734         * breakpoint.c (print_one_breakpoint_location): New parameter
7735         'raw_loc'.  Handle it.  Use
7736         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7737         looking at the breakpoint's type.
7738         (print_one_breakpoint): If handling "maint info breakpoints", also
7739         print locations of exception catchpoints.
7740         * breakpoint.h (is_exception_catchpoint): Declare.
7741
7742 2019-07-09  Pedro Alves  <palves@redhat.com>
7743
7744         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7745         "addr" field.
7746         (allocate_location_exception_catchpoint): New.
7747         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7748         (initialize_throw_catchpoint_ops): Install
7749         allocate_location_exception_catchpoint as allocate_location
7750         method.
7751         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7752         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7753         bp_loc_other.
7754         (breakpoint_address_is_meaningful): Delete.
7755         (bl_address_is_meaningful): New.
7756         (breakpoint_locations_match): Adjust comment.
7757         (bp_location_from_bp_type): New, factored out of...
7758         (bp_location::bp_location(breakpoint *)): ... this.
7759         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7760         factored out of...
7761         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7762         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7763         breakpoint_address_is_meaningful.
7764         (bp_locations_compare): Adjust comment.
7765         (update_global_location_list): Use bl_address_is_meaningful
7766         instead of breakpoint_address_is_meaningful.
7767         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7768         explicit.
7769         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7770         * python/py-breakpoint.c (bppy_get_location): No longer check
7771         whether location is null.
7772
7773 2019-07-09  Pedro Alves  <palves@redhat.com>
7774
7775         PR c++/15468
7776         * breakpoint.c (print_one_breakpoint_location): Remove
7777         single-location assert.
7778
7779 2019-07-09  Tom Tromey  <tom@tromey.com>
7780
7781         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7782         * configure: Rebuild.
7783         * configure.ac: Change common to gdbsupport.
7784         * gdbsupport: Rename from common.
7785         * acinclude.m4: Change common to gdbsupport.
7786         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7787         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7788         gdbsupport.
7789         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7790         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7791         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7792         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7793         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7794         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7795         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7796         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7797         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7798         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7799         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7800         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7801         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7802         coff-pe-read.c, command.h, compile/compile-c-support.c,
7803         compile/compile-c.h, compile/compile-cplus-symbols.c,
7804         compile/compile-cplus-types.c, compile/compile-cplus.h,
7805         compile/compile-loc2c.c, compile/compile.c, completer.c,
7806         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7807         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7808         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7809         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7810         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7811         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7812         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7813         features/aarch64-core.c, features/aarch64-fpu.c,
7814         features/aarch64-pauth.c, features/aarch64-sve.c,
7815         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7816         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7817         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7818         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7819         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7820         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7821         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7822         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7823         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7824         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7825         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7826         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7827         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7828         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7829         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7830         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7831         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7832         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7833         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7834         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7835         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7836         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7837         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7838         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7839         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7840         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7841         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7842         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7843         minsyms.c, mips-linux-tdep.c, namespace.h,
7844         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7845         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7846         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7847         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7848         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7849         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7850         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7851         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7852         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7853         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7854         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7855         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7856         procfs.c, producer.c, progspace.h, psymtab.h,
7857         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7858         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7859         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7860         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7861         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7862         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7863         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7864         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7865         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7866         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7867         target-memory.c, target.c, target.h, target/waitstatus.c,
7868         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7869         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7870         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7871         unittests/array-view-selftests.c,
7872         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7873         unittests/common-utils-selftests.c,
7874         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7875         unittests/format_pieces-selftests.c,
7876         unittests/function-view-selftests.c,
7877         unittests/lookup_name_info-selftests.c,
7878         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7879         unittests/mkdir-recursive-selftests.c,
7880         unittests/observable-selftests.c,
7881         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7882         unittests/parse-connection-spec-selftests.c,
7883         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7884         unittests/scoped_fd-selftests.c,
7885         unittests/scoped_mmap-selftests.c,
7886         unittests/scoped_restore-selftests.c,
7887         unittests/string_view-selftests.c, unittests/style-selftests.c,
7888         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7889         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7890         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7891         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7892         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7893         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7894
7895 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7898         bool value.
7899         (decode_digits_ordinary): Set explicit_line field in sal.
7900         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7901         symtab_and_line that was set on an explicit line number in
7902         assembler code.  Do always update the recorded symtab and line if
7903         we do skip the prologue.
7904
7905 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * breakpoint.c (set_breakpoint_location_function): Remove
7908         explicit_loc parameter.
7909         (momentary_breakpoint_from_master): Update call to
7910         set_breakpoint_location_function.
7911         (add_location_to_breakpoint): Likewise.
7912
7913 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7914
7915         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7916         required features based on default bfd type when no specific bfd
7917         is present.
7918
7919 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7920
7921         * NEWS: Mention that GDB printf and eval commands can now print
7922         C-style and Ada-style convenience var strings without
7923         calling the inferior.
7924         * printcmd.c (printf_c_string): Locally print GDB internal var
7925         instead of transiting via the inferior.
7926         (printf_wide_c_string): Likewise.
7927
7928 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7929
7930         PR breakpoints/25011
7931         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7932
7933 2019-07-04  Tom Tromey  <tom@tromey.com>
7934
7935         PR tui/24724:
7936         * tui/tui-winsource.c (tui_clear_source_content): Update.
7937         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7938         (tui_update_breakpoint_info): Update.
7939         (tui_set_exec_info_content): Update.
7940         * tui/tui-source.c (tui_set_source_content_nil): Update.
7941         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7942         has_break.
7943         * tui/tui-data.h (enum tui_bp_flag): New.
7944         (tui_bp_flags): New enum flags type.
7945         (struct tui_source_element) <break_mode>: Change type.  Rename
7946         from has_break.
7947         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7948         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7949         constants.
7950         * tui/tui-winsource.h: Fix comment.
7951
7952 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7953
7954         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7955         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7956         (store_fpregs_to_thread)
7957         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7958         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7959         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7960         (IWMMXT_REGS_SIZE): Add define.
7961         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7962         (fetch_vfp_regs, store_vfp_regs)
7963         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7964         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7965
7966 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7967
7968         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7969         defines.
7970         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7971         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7972         (ARM_INT_REGISTER_SIZE): ...to this.
7973         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7974         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7975         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7976         (arm_linux_collect_gregset, supply_nwfpe_register)
7977         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7978         defines.
7979         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7980         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7981         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7982         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7983         (arm_return_in_memory, arm_store_return_value)
7984         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7985         (arm_record_ld_st_multiple): Likewise.
7986         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7987         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7988
7989 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7990
7991         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7992         AARCH64_DISPLACED_MODIFIED_INSNS.
7993         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7994         (aarch64_displaced_step_copy_insn): Likewise.
7995         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7996         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7997         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7998         ARM_DISPLACED_MODIFIED_INSNS.
7999         * arm-tdep.c (arm_gdbarch_init): Likewise.
8000         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8001         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8002         (struct arm_displaced_step_closure): Use
8003         ARM_DISPLACED_MODIFIED_INSNS.
8004
8005 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8006
8007         * features/Makefile: Remove unused xml files.
8008         * features/aarch64.xml: Remove.
8009         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8010         * features/i386/amd64-avx-avx512.xml: Remove.
8011         * features/i386/amd64-avx-linux.xml: Remove.
8012         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8013         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8014         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8015         * features/i386/amd64-avx-mpx.xml: Remove.
8016         * features/i386/amd64-avx.xml: Remove.
8017         * features/i386/amd64-linux.xml: Remove.
8018         * features/i386/amd64-mpx-linux.xml: Remove.
8019         * features/i386/amd64-mpx.xml: Remove.
8020         * features/i386/amd64.xml: Remove.
8021         * features/i386/i386-avx-avx512-linux.xml: Remove.
8022         * features/i386/i386-avx-avx512.xml: Remove.
8023         * features/i386/i386-avx-linux.xml: Remove.
8024         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8025         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8026         * features/i386/i386-avx-mpx-linux.xml: Remove.
8027         * features/i386/i386-avx-mpx.xml: Remove.
8028         * features/i386/i386-avx.xml: Remove.
8029         * features/i386/i386-linux.xml: Remove.
8030         * features/i386/i386-mmx-linux.xml: Remove.
8031         * features/i386/i386-mmx.xml: Remove.
8032         * features/i386/i386-mpx-linux.xml: Remove.
8033         * features/i386/i386-mpx.xml: Remove.
8034         * features/i386/i386.xml: Remove.
8035         * features/i386/x32-avx-avx512-linux.xml: Remove.
8036         * features/i386/x32-avx-linux.xml: Remove.
8037         * features/i386/x32-linux.xml: Remove.
8038
8039 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8040
8041         * regformats/aarch64.dat: Remove.
8042         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8043         * regformats/i386/amd64-avx-linux.dat: Remove.
8044         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8045         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8046         * regformats/i386/amd64-linux.dat: Remove.
8047         * regformats/i386/amd64-mpx-linux.dat: Remove.
8048         * regformats/i386/amd64.dat: Remove.
8049         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8050         * regformats/i386/i386-avx-linux.dat: Remove.
8051         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8052         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8053         * regformats/i386/i386-linux.dat: Remove.
8054         * regformats/i386/i386-mmx-linux.dat: Remove.
8055         * regformats/i386/i386-mpx-linux.dat: Remove.
8056         * regformats/i386/i386.dat: Remove.
8057         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8058         * regformats/i386/x32-avx-linux.dat: Remove.
8059         * regformats/i386/x32-linux.dat: Remove.
8060
8061 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8062
8063         * aarch64-tdep.c: Remove xml self tests.
8064         * amd64-linux-tdep.c: Likewise.
8065         * amd64-tdep.c: Likewise.
8066         * i386-linux-tdep.c: Likewise.
8067         * i386-tdep.c: Likewise.
8068
8069 2019-07-03  Pedro Alves  <palves@redhat.com>
8070
8071         PR cli/24732
8072         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8073         (pipe_cmd_option_defs): New.
8074         (make_pipe_cmd_options_def_group): New.
8075         (pipe_command): Use gdb::option::process_options.
8076         (pipe_command_completer): New function.
8077         (_initialize_cli_cmds): Install completer for "pipe" command.
8078
8079 2019-07-03  Pedro Alves  <palves@redhat.com>
8080
8081         * cli/cli-option.c (union option_value) <string>: New field.
8082         (struct option_def_and_value): Add ctor, move ctor, dtor and
8083         use DISABLE_COPY_AND_ASSIGN.
8084         (option_def_and_value::clear_value): New.
8085         (parse_option, save_option_value_in_ctx, get_val_type_str)
8086         (add_setshow_cmds_for_options): Handle var_string.
8087         * cli-option.h (union option_def::var_address) <string>: New
8088         field.
8089         (struct string_option_def): New.
8090         * maint-test-options.c (struct test_options_opts): Add default
8091         ctor and use DISABLE_COPY_AND_ASSIGN.
8092         <string_opt>: New field.
8093         (test_options_opts::~test_options_opts): New.
8094         (test_options_opts::dump): Also dump "-string".
8095         (test_options_option_defs): Install "string.
8096
8097 2019-07-03  Pedro Alves  <palves@redhat.com>
8098
8099         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8100         option_value with a null enumeration.
8101         (complete_options): Save the option values in the context.
8102         (save_option_value_in_ctx): New, factored out from ...
8103         (process_options): ... here.
8104         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8105         of the function.
8106         * maint-test-options.c (test_options_opts::dump): New, factored
8107         out from ...
8108         (maintenance_test_options_command_mode): ... here.
8109         (maintenance_test_options_command_completion_result): Delete.
8110         (maintenance_test_options_command_completion_text): Update
8111         comment.
8112         (maintenance_show_test_options_completion_result): Change
8113         prototype.  Just print
8114         maintenance_test_options_command_completion_text.
8115         (save_completion_result): New.
8116         (maintenance_test_options_completer_mode): Pass options context to
8117         complete_options, and then save a dump.
8118         (_initialize_maint_test_options): Use add_cmd to install "maint
8119         show test-options-completion-result".
8120
8121 2019-07-03  Pedro Alves  <palves@redhat.com>
8122
8123         * NEWS (New commands): Mention "with" and "maint with".
8124         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8125         (with_command, with_command_completer): New.
8126         (pipe_command): Adjust to new repeat_previous
8127         interface.
8128         (_initialize_cli_cmds): Install the "with" command and its "w"
8129         alias.
8130         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8131         declarations.
8132         * cli/cli-setshow.c (parse_cli_var_uinteger)
8133         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8134         argument strings for all var_types.
8135         (get_setshow_command_value_string): New, factored out from ...
8136         (do_show_command): ... this.
8137         * cli/cli-setshow.h: Include <string>.
8138         (get_setshow_command_value_string): Declare.
8139         * command.h (repeat_previous): Now returns const char *.  Adjust
8140         comment.
8141         * maint.c: Include "cli/cli-cmds.h".
8142         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8143         (_initialize_maint_cmds): Register the "maintenance with" command.
8144         * top.c (repeat_previous): Move bits from pipe_command here:
8145         Return the saved command line, if any; error out if there's no
8146         command to relaunch.
8147
8148 2019-07-03  Pedro Alves  <palves@redhat.com>
8149
8150         * NEWS (New commands): Mention "maint set/show test-settings"
8151         instead of "maint test-settings".
8152         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8153         (maintenance_test_settings_set_list): Rename to ...
8154         (maintenance_set_test_settings_list): ... this.
8155         (maintenance_test_settings_show_list): Rename to  ...
8156         (maintenance_show_test_settings_list): ... this.
8157         (maintenance_test_settings_cmd): Delete.
8158         (maintenance_test_settings_set_cmd): ...
8159         (maintenance_set_test_settings_cmd): ... this.
8160         (maintenance_test_settings_show_cmd): ...
8161         (maintenance_show_test_settings_cmd): ... this.
8162         (maintenance_test_settings_show_value_cmd):
8163         (maintenance_show_test_settings_value_cmd): ... this.
8164         (_initialize_maint_test_settings): No longer install the "maint
8165         test-settings" prefix command.  Rename "maint test-settings set"
8166         to "maint set test-settings", and "maint test-settings show" to
8167         "maint show test-settings".  Adjust all subcommands.
8168
8169 2019-07-03  Pedro Alves  <palves@redhat.com>
8170
8171         * maint-test-settings.c: Fix file's intro comment.  Replace all
8172         references to "test-options" with references to "test-settings",
8173         in comments.
8174
8175 2019-07-03  Pedro Alves  <palves@redhat.com>
8176
8177         * maint-test-settings.c (maintenance_test_settings_xxx)
8178         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8179         New.
8180         (maintenance_test_settings_enums): Use them.
8181         (maintenance_test_settings_enum): Default to
8182         maintenance_test_settings_xxx.
8183         (_initialize_maint_test_settings): Initialize
8184         MAINTENANCE_TEST_SETTINGS_FILENAME.
8185
8186 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8187
8188         * breakpoint.h (remove_breakpoints_inf): Change return type to
8189         void, move function documentation here.
8190         * breakpoint.c (remove_breakpoints_inf): Change return type to
8191         void, move function documentation to header.
8192
8193 2019-07-02  Pedro Alves  <palves@redhat.com>
8194
8195         * NEWS (Completion improvements): Mention "info threads".
8196         * thread.c (struct info_threads_opts, info_threads_option_defs)
8197         (make_info_threads_options_def_group): New.
8198         (info_threads_command): Use gdb::option::process_options.
8199         (info_threads_command_completer): New.
8200         (_initialize_thread): Use gdb::option::build_help to build the
8201         help text for "info threads".
8202
8203 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8204
8205         * defs.h (generic_load): Move from here...
8206         * symfile.h (generic_load): ... to here.  Rename name parameter
8207         to args.
8208         * symfile.c (generic_load): Add comment.
8209
8210 2019-07-01  Tom Tromey  <tromey@adacore.com>
8211
8212         * dwarf2read.c
8213         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8214         declaration of without_params.  Fix formatting.
8215
8216 2019-07-01  Tom Tromey  <tromey@adacore.com>
8217
8218         * ada-exp.y (find_primitive_type): Update.
8219         * ada-lang.h (ada_lookup_symbol): Update.
8220         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8221         parameter.
8222         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8223
8224 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8225
8226         PR breakpoints/24541
8227         * gdbarch.c: Regenerate.
8228         * gdbarch.h: Regenerate.
8229         * gdbarch.sh: Add 'stap_adjust_register'.
8230         * i386-tdep.c: Include '<unordered_set>'.
8231         (i386_stap_adjust_register): New function.
8232         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8233         * stap-probe.c (stap_parse_register_operand): Call
8234         'gdbarch_stap_adjust_register'.
8235
8236 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8237
8238         PR python/24742
8239         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8240         * python/python.c (do_start_initialization): Use 'xmalloc'
8241         instead of 'PyMem_Malloc'.
8242
8243 2019-06-28  Tom Tromey  <tromey@adacore.com>
8244
8245         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8246         for Ada.
8247
8248 2019-06-27  Tom Tromey  <tromey@adacore.com>
8249
8250         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8251         objfile_key.
8252         (arm_find_mapping_symbol, arm_record_special_symbol)
8253         (_initialize_arm_tdep): Update.
8254         (arm_objfile_data_free): Remove.
8255
8256 2019-06-27  Tom Tromey  <tromey@adacore.com>
8257
8258         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8259         to cp_print_static_field.
8260
8261 2019-06-26  Tom Tromey  <tromey@adacore.com>
8262
8263         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8264         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8265         declare.
8266
8267 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8268
8269         * features/aarch64-core.c (create_feature_aarch64_core):
8270         Regenerate.
8271         * features/aarch64-core.xml: Add cpsr flags.
8272
8273 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8274
8275         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8276         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8277
8278 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8279
8280         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8281         field.
8282         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8283         use.
8284         (arm_record_special_symbol): Don't insert new symbol in sorted
8285         position, push it at the end.
8286
8287 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8288
8289         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8290         (arm_mapping_symbol_s): Remove.
8291         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8292         (arm_mapping_symbol_vec): New typedef.
8293         (struct arm_per_objfile): Add constructor.
8294         <section_maps>: Change type to
8295         std::unique_ptr<arm_mapping_symbol_vec[]>.
8296         (arm_compare_mapping_symbols): Remove.
8297         (arm_find_mapping_symbol): Adjust to section_maps type change.
8298         (arm_objfile_data_free): Call delete on arm_per_objfile.
8299         (arm_record_special_symbol): Adjust to section_maps type change.
8300         Allocate arm_per_objfile with new.
8301
8302 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8303
8304         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8305         with the command prefix.
8306
8307 2019-06-25  Tom Tromey  <tom@tromey.com>
8308
8309         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8310         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8315         type.
8316         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8317         protected.
8318
8319 2019-06-25  Tom Tromey  <tom@tromey.com>
8320
8321         * tui/tui-winsource.c
8322         (tui_source_window_base::set_is_exec_point_at): Add check against
8323         LOA_ADDRESS.
8324
8325 2019-06-25  Tom Tromey  <tom@tromey.com>
8326
8327         * tui/tui-source.c (tui_set_source_content): Don't check before
8328         xfree.
8329         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8330
8331 2019-06-25  Tom Tromey  <tom@tromey.com>
8332
8333         * tui/tui-winsource.h (tui_update_source_window_as_is)
8334         (tui_alloc_source_buffer, tui_line_is_displayed)
8335         (tui_addr_is_displayed): Change type of win_info.
8336         * tui/tui-winsource.c (tui_update_source_window_as_is)
8337         (tui_clear_source_content, tui_show_source_line)
8338         (tui_show_source_content, tui_source_window_base::refill)
8339         (tui_source_window_base::set_is_exec_point_at)
8340         (tui_source_window_base::set_is_exec_point_at)
8341         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8342         (tui_alloc_source_buffer, tui_line_is_displayed)
8343         (tui_addr_is_displayed): Change type of win_info.  Update.
8344         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8345         (tui_source_window_base::do_make_visible_with_new_height):
8346         Update.
8347         * tui/tui-source.c (tui_set_source_content)
8348         (tui_set_source_content_nil)
8349         (tui_source_window::do_scroll_vertical): Update.
8350         * tui/tui-layout.c (show_layout): Update.
8351         * tui/tui-disasm.c (tui_set_disassem_content)
8352         (tui_disasm_window::do_scroll_vertical): Update.
8353         * tui/tui-data.h (tui_win_content): Remove.
8354         (struct tui_gen_win_info) <content, content_size>: Remove.
8355         (struct tui_source_element): Add initializers and destructor.
8356         (union tui_which_element, struct tui_win_element): Remove.
8357         (struct tui_source_window_base) <content>: New field.
8358         (struct tui_data_window): Remove destructor.
8359         (tui_alloc_content, tui_free_win_content)
8360         (tui_free_all_source_wins_content): Don't declare.
8361         * tui/tui-data.c (tui_initialize_static_data): Update.
8362         (init_content_element, tui_alloc_content): Remove.
8363         (~tui_gen_win_info): Update.
8364         (~tui_data_window, tui_free_all_source_wins_content)
8365         (tui_free_win_content, free_content, free_content_elements):
8366         Remove.
8367
8368 2019-06-25  Tom Tromey  <tom@tromey.com>
8369
8370         * tui/tui-winsource.h (tui_clear_source_content)
8371         (tui_erase_source_content, tui_show_source_content): Change type
8372         of win_info.
8373         * tui/tui-winsource.c (tui_clear_source_content)
8374         (tui_erase_source_content, tui_show_source_content): Change type
8375         of win_info.
8376         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8377         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8378         win_info.
8379         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8380         win_info.
8381         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8382
8383 2019-06-25  Tom Tromey  <tom@tromey.com>
8384
8385         * tui/tui-winsource.c (tui_clear_source_content)
8386         (tui_source_window_base::set_is_exec_point_at): Update.
8387         * tui/tui-source.c (tui_set_source_content_nil): Update.
8388         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8389         a bool.
8390         * tui/tui-data.c (init_content_element): Update.
8391
8392 2019-06-25  Tom Tromey  <tom@tromey.com>
8393
8394         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8395         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8396         * tui/tui-layout.c (init_and_make_win): Update.
8397         * tui/tui.h (enum tui_win_type): Update.
8398         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8399         tui_win_is_auxillary.
8400         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8401         tui_win_is_auxillary.
8402
8403 2019-06-25  Tom Tromey  <tom@tromey.com>
8404
8405         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8406         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8407         (tui_delete_data_content_windows, tui_display_all_data)
8408         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8409         Update.
8410         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8411         * tui/tui-regs.c (tui_last_regs_line_no)
8412         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8413         (tui_show_registers): Update.
8414         (tui_show_register_group): Return void.  Update.
8415         (tui_display_registers_from, tui_display_reg_element_at_line)
8416         (tui_display_registers_from_line, tui_check_register_values):
8417         Update.
8418         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8419         member.
8420         (struct tui_data_window) <regs_content>: Now a std::vector.
8421         <regs_content_count>: Remove.
8422         (tui_add_content_elements, tui_free_data_content): Don't declare.
8423         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8424         (init_content_element): Remove DATA_WIN case.  Add assert.
8425         (tui_add_content_elements): Remove.
8426         (tui_data_window): Update.
8427         (tui_free_data_content): Remove.
8428         (free_content_elements): Remove DATA_WIN case.
8429
8430 2019-06-25  Tom Tromey  <tom@tromey.com>
8431
8432         * tui/tui-data.c (tui_data_item_window): Update.
8433         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8434         * tui/tui-windata.c (tui_display_all_data)
8435         (tui_display_data_from_line): Update.
8436         (tui_check_data_values): Remove.
8437         * tui/tui-regs.c (tui_show_register_group)
8438         (tui_display_reg_element_at_line): Update.
8439         * tui/tui-hooks.c (tui_register_changed)
8440         (tui_refresh_frame_and_register_information): Call
8441         tui_check_register_values.
8442         * tui/tui-data.h (struct tui_data_window) <data_content,
8443         data_content_count, data_type>: Remove.
8444         (enum tui_data_type): Remove.
8445
8446         * tui/tui-data.c (tui_data_window::clear_detail)
8447         (~tui_data_window): Update.
8448
8449 2019-06-25  Tom Tromey  <tom@tromey.com>
8450
8451         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8452         declare.
8453         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8454         Rename from tui_first_data_item_displayed.  Update.
8455         (tui_data_window::refresh_all)
8456         (tui_data_window::do_scroll_vertical): Update.
8457         * tui/tui-data.h (struct tui_data_window)
8458         <first_data_item_displayed>: Declare new method.
8459
8460 2019-06-25  Tom Tromey  <tom@tromey.com>
8461
8462         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8463         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8464         contents...
8465         (tui_initialize_static_data): ...here.
8466
8467 2019-06-25  Tom Tromey  <tom@tromey.com>
8468
8469         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8470         (tui_display_registers_from, tui_check_register_values): Update.
8471         (tui_display_register): Remove win_info parameter; update.
8472         (tui_get_register): Change type of parameters.
8473         * tui/tui-data.h (struct tui_data_element): Remove.
8474         (union tui_which_element) <data>: Remove.
8475         <data_window>: Change type.
8476         (struct tui_data_item_window): New.
8477         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8478         case.  Add assert.
8479         (~tui_data_item_window): New destructor.
8480         (free_content_elements): Remove DATA_ITEM_WIN case.
8481
8482 2019-06-25  Tom Tromey  <tom@tromey.com>
8483
8484         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8485         Remove.
8486
8487 2019-06-25  Tom Tromey  <tom@tromey.com>
8488
8489         * tui/tui-data.h (struct tui_command_element): Remove.
8490         (union tui_which_element) <command>: Remove.
8491         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8492         assert.
8493         (free_content_elements): Remove CMD_WIN case.
8494
8495 2019-06-25  Tom Tromey  <tom@tromey.com>
8496
8497         * tui/tui-layout.c (tui_set_layout): Update.
8498         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8499         * tui/tui-data.c (layout_def): Update.
8500
8501 2019-06-25  Tom Tromey  <tom@tromey.com>
8502
8503         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8504         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8505         (tui_source_window_base::set_new_height): Update.
8506         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8507         Update.
8508         (tui_set_locator_fullname, tui_set_locator_info)
8509         (tui_show_frame_info): Update.
8510         * tui/tui-source.c (tui_set_source_content)
8511         (tui_source_is_displayed): Update.
8512         * tui/tui-layout.c (show_source_disasm_command, show_data)
8513         (show_source_or_disasm_and_command): Update.
8514         * tui/tui-disasm.c (tui_set_disassem_content)
8515         (tui_get_begin_asm_address): Update.
8516         * tui/tui-data.h (struct tui_locator_element): Remove.
8517         (union tui_which_element) <locator>: Remove.
8518         (struct tui_locator_window): New.
8519         (tui_locator_win_info_ptr): Change return type.
8520         * tui/tui-data.c (_locator): Change type.
8521         (tui_locator_win_info_ptr): Change return type.
8522         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8523         (tui_alloc_content): Add assert.
8524
8525 2019-06-25  Tom Tromey  <tom@tromey.com>
8526
8527         * tui/tui-winsource.c
8528         (tui_exec_info_window::maybe_allocate_content): New method.
8529         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8530         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8531         (make_source_or_disasm_window): Add cast.
8532         * tui/tui-data.h (union tui_which_element) <simple_string>:
8533         Remove.
8534         (struct tui_source_info): New.
8535         (struct tui_source_window_base) <execution_info>: Change type.
8536         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8537         case, and add assert.
8538         (tui_alloc_content): Add assert.
8539
8540 2019-06-25  Tom Tromey  <tom@tromey.com>
8541
8542         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8543         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8544         * tui/tui-data.c (tui_alloc_win_info): Remove.
8545
8546 2019-06-25  Tom Tromey  <tom@tromey.com>
8547
8548         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8549         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8550         can_highlight.
8551
8552 2019-06-25  Tom Tromey  <tom@tromey.com>
8553
8554         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8555         make_visible_with_new_height method.
8556         (tui_win_info::make_visible_with_new_height): New method.
8557         (tui_source_window_base::do_make_visible_with_new_height)
8558         (tui_data_window::do_make_visible_with_new_height)
8559         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8560         (make_visible_with_new_height): Remove.
8561         (tui_resize_all, tui_adjust_win_heights): Use
8562         make_visible_with_new_height method.
8563         * tui/tui-data.h (struct tui_win_info)
8564         <do_make_visible_with_new_height, make_visible_with_new_height>:
8565         New methods.
8566         (struct tui_source_window_base, struct tui_data_window)
8567         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8568         methods.
8569
8570 2019-06-25  Tom Tromey  <tom@tromey.com>
8571
8572         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8573         method.
8574         (update_tab_width): Call update_tab_width method.
8575         * tui/tui-data.h (struct tui_win_info)
8576         (struct tui_source_window_base) <update_tab_width>: New methods.
8577
8578 2019-06-25  Tom Tromey  <tom@tromey.com>
8579
8580         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8581         parameter.
8582         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8583         parameter.
8584         (tui_gen_win_info::make_visible): Update.
8585         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8586         parameter.
8587         * tui/tui-data.h (enum tui_box): New enum.
8588         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8589
8590 2019-06-25  Tom Tromey  <tom@tromey.com>
8591
8592         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8593         init_and_make_win for EXEC_INFO_WIN.
8594         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8595         longer inline.
8596         (struct tui_win_info) <~tui_win_info>: Inline.
8597         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8598         Don't declare.
8599         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8600         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8601         Remove.
8602         (tui_initialize_static_data): Update.
8603         (~tui_gen_win_info): Handle more cleanup here.
8604         (~tui_source_window_base): Delete "execution_info".
8605         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8606
8607 2019-06-25  Tom Tromey  <tom@tromey.com>
8608
8609         * tui/tui-layout.c (make_command_window): Don't set
8610         can_highlight.
8611         (show_source_disasm_command): Call the reset method.
8612         (show_data): Don't set can_highlight.  Call the reset method.
8613         (tui_gen_win_info::reset): Rename from init_gen_win_info
8614         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8615         (show_source_or_disasm_and_command): Call the reset method.
8616         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8617         (struct tui_cmd_window): Set can_highlight.
8618
8619 2019-06-25  Tom Tromey  <tom@tromey.com>
8620
8621         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8622         from make_visible.
8623         (tui_make_visible, tui_make_invisible): Rewrite.
8624         (tui_win_info::make_visible): Remove.
8625         (tui_source_window_base::make_visible): Update.
8626         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8627         method.  Moved from...
8628         (struct tui_win_info) <make_visible>: ...here.
8629
8630 2019-06-25  Tom Tromey  <tom@tromey.com>
8631
8632         * tui/tui-winsource.c
8633         (tui_source_window_base::do_scroll_horizontal): Remove direction
8634         parameter.
8635         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8636         direction parameter.
8637         * tui/tui-win.c (tui_win_info::forward_scroll)
8638         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8639         (tui_win_info::right_scroll): Update.
8640         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8641         direction parameter.
8642         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8643         direction parameter.
8644         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8645         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8646         Remove direction parameter.
8647         (struct tui_source_window_base, struct tui_source_window)
8648         (struct tui_disasm_window, struct tui_data_window)
8649         (struct tui_cmd_window): Update.
8650
8651 2019-06-25  Tom Tromey  <tom@tromey.com>
8652
8653         * tui/tui-winsource.h (tui_set_exec_info_content)
8654         (tui_show_exec_info_content, tui_erase_exec_info_content)
8655         (tui_clear_exec_info_content, tui_update_exec_info): Change
8656         argument to tui_source_window_base.
8657         * tui/tui-winsource.c (tui_set_exec_info_content)
8658         (tui_show_exec_info_content, tui_erase_exec_info_content)
8659         (tui_clear_exec_info_content, tui_update_exec_info): Change
8660         argument to tui_source_window_base.
8661
8662 2019-06-25  Tom Tromey  <tom@tromey.com>
8663
8664         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8665         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8666
8667 2019-06-25  Tom Tromey  <tom@tromey.com>
8668
8669         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8670         check.
8671
8672 2019-06-25  Tom Tromey  <tom@tromey.com>
8673
8674         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8675         type to void.
8676         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8677         type to void.
8678         * tui/tui-source.c (tui_set_source_content): Update.
8679         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8680
8681 2019-06-25  Tom Tromey  <tom@tromey.com>
8682
8683         * tui/tui-win.c (window_name_completer, tui_set_focus)
8684         (tui_all_windows_info): Use name method.
8685         * tui/tui-data.h (struct tui_gen_win_info)
8686         (struct tui_source_window, struct tui_disasm_window)
8687         (struct tui_data_window, struct tui_cmd_window) <name>: New
8688         method.
8689         (tui_win_name): Don't declare.
8690         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8691         (tui_win_name): Remove.
8692
8693 2019-06-25  Tom Tromey  <tom@tromey.com>
8694
8695         * tui/tui-winsource.h (tui_update_source_window)
8696         (tui_update_source_window_as_is): Change parameter type.
8697         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8698         to be a tui_source_window_base.
8699         (tui_update_source_window_as_is): Likewise.
8700         * tui/tui-win.c (make_visible_with_new_height): Update.
8701
8702 2019-06-25  Tom Tromey  <tom@tromey.com>
8703
8704         * tui/tui-winsource.c (tui_erase_source_content)
8705         (tui_show_source_content, tui_show_exec_info_content)
8706         (tui_erase_exec_info_content): Use refresh_window method.
8707         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8708         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8709         from tui_refresh_win.
8710         (tui_data_window::refresh_window): New method.
8711         (tui_win_info::refresh, tui_source_window_base::refresh)
8712         (tui_refresh_all): Use refresh_window method.
8713         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8714         method.
8715         * tui/tui-regs.c (tui_display_register): Call refresh_window
8716         method.
8717         * tui/tui-layout.c (show_source_disasm_command)
8718         (show_source_or_disasm_and_command): Call refresh_window method.
8719         * tui/tui-data.h (struct tui_gen_win_info)
8720         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8721         New method.
8722
8723 2019-06-25  Tom Tromey  <tom@tromey.com>
8724
8725         * tui/tui.c (tui_rl_other_window, tui_enable)
8726         (tui_is_window_visible, tui_get_command_dimension): Update.
8727         * tui/tui-winsource.c (tui_update_source_window_as_is)
8728         (tui_clear_source_content, tui_erase_source_content)
8729         (tui_show_source_line, tui_source_window_base::refill)
8730         (tui_source_window_base::do_scroll_horizontal)
8731         (tui_source_window_base::set_is_exec_point_at)
8732         (tui_update_breakpoint_info, tui_set_exec_info_content)
8733         (tui_alloc_source_buffer, tui_line_is_displayed)
8734         (tui_addr_is_displayed): Update.
8735         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8736         (tui_check_and_display_highlight_if_needed)
8737         (tui_win_info::make_visible, tui_win_info::refresh)
8738         (tui_refresh_all): Update.
8739         * tui/tui-windata.c (tui_first_data_item_displayed)
8740         (tui_delete_data_content_windows, tui_erase_data_content)
8741         (tui_display_all_data, tui_data_window::refresh_all)
8742         (tui_check_data_values): Update.
8743         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8744         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8745         (tui_win_info::backward_scroll, tui_refresh_all_win)
8746         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8747         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8748         (tui_source_window_base::set_new_height)
8749         (tui_data_window::set_new_height)
8750         (make_invisible_and_set_new_height)
8751         (make_visible_with_new_height, new_height_ok)
8752         (parse_scrolling_args): Update.
8753         * tui/tui-stack.c (tui_show_frame_info): Update.
8754         * tui/tui-source.c (tui_set_source_content)
8755         (tui_set_source_content_nil, tui_source_is_displayed)
8756         (tui_source_window::do_scroll_vertical): Update.
8757         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8758         (tui_display_registers_from, tui_display_reg_element_at_line)
8759         (tui_check_register_values, tui_reg_command): Update.
8760         * tui/tui-layout.c (tui_default_win_height)
8761         (show_source_disasm_command, show_data, init_and_make_win)
8762         (show_source_or_disasm_and_command): Update.
8763         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8764         (tui_redisplay_readline, tui_mld_flush)
8765         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8766         (tui_getc): Update.
8767         * tui/tui-disasm.c (tui_set_disassem_content)
8768         (tui_disasm_window::do_scroll_vertical): Update.
8769         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8770         Now virtual.
8771         (struct tui_win_info): Derive from tui_gen_win_info.
8772         <~tui_win_info>: Mark as override.
8773         <generic>: Remove member.
8774         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8775         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8776         (~tui_data_window, ~tui_win_info)
8777         (tui_free_all_source_wins_content): Update.
8778         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8779
8780 2019-06-25  Tom Tromey  <tom@tromey.com>
8781
8782         * tui/tui-layout.c (init_and_make_win): Use new.
8783         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8784         destructor, initializers.
8785         (tui_alloc_generic_win_info): Don't declare.
8786         * tui/tui-data.c (_locator): Add argument to constructor.
8787         (source_win, disasm_win): New globals.
8788         (exec_info): Remove.
8789         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8790         Update.
8791         (tui_alloc_generic_win_info): Remove.
8792         (init_content_element): Use new.
8793         (tui_win_info::tui_win_info): Update.
8794         (free_content_elements) <case DATA_WIN>: Use delete.
8795
8796 2019-06-25  Tom Tromey  <tom@tromey.com>
8797
8798         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8799         * tui/tui-windata.c (tui_first_data_item_displayed)
8800         (tui_delete_data_content_windows): Update.
8801         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8802         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8803         (tui_display_registers_from, tui_check_register_values): Update.
8804         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8805         pointer.
8806         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8807         window.
8808         (tui_free_data_content): Update.
8809         (free_content_elements) <case DATA_WIN>: Free the window.
8810
8811 2019-06-25  Tom Tromey  <tom@tromey.com>
8812
8813         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8814         Update.
8815         * tui/tui-layout.c (make_command_window)
8816         (show_source_disasm_command, show_data, init_and_make_win)
8817         (show_source_or_disasm_and_command): Update.
8818         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8819         method.
8820         <can_highight, is_highlighted>: Now bool.
8821         (tui_set_win_highlight): Don't declare.
8822         * tui/tui-data.c (tui_set_win_highlight): Remove.
8823
8824 2019-06-25  Tom Tromey  <tom@tromey.com>
8825
8826         * tui/tui-wingeneral.c (make_visible): Remove check of window
8827         type.
8828
8829 2019-06-25  Tom Tromey  <tom@tromey.com>
8830
8831         * tui/tui-win.c (tui_win_info::max_height)
8832         (tui_cmd_window::max_height): New methods.
8833         (new_height_ok): Call max_height.
8834         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8835         <max_height>: New method.
8836
8837 2019-06-25  Tom Tromey  <tom@tromey.com>
8838
8839         * tui/tui-win.c (tui_source_window_base::set_new_height)
8840         (tui_data_window::set_new_height): New methods.
8841         (make_invisible_and_set_new_height): Call set_new_height method.
8842         * tui/tui-data.h (struct tui_win_info)
8843         (struct tui_source_window_base, struct tui_data_window)
8844         <set_new_height>: New method.
8845
8846 2019-06-25  Tom Tromey  <tom@tromey.com>
8847
8848         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8849         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8850         tui_refresh_data_win.
8851         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8852         method.
8853         (tui_refresh_all_win): Call the refresh_all method.
8854         (tui_set_focus): Likewise.
8855         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8856         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8857         Likewise.
8858
8859 2019-06-25  Tom Tromey  <tom@tromey.com>
8860
8861         * tui/tui-winsource.h (tui_refill_source_window)
8862         (tui_set_is_exec_point_at): Don't declare.
8863         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8864         (tui_source_window_base::refill): Rename from
8865         tui_refill_source_window.
8866         (tui_source_window_base::do_scroll_horizontal): Update.
8867         (tui_source_window_base::set_is_exec_point_at): Rename from
8868         tui_set_is_exec_point_at.
8869         (tui_update_all_breakpoint_info): Update.
8870         * tui/tui-stack.c (tui_show_frame_info): Update.
8871         * tui/tui-layout.c (show_data): Add cast.
8872         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8873         * tui/tui-data.h (struct tui_source_window_base) <refill,
8874         set_is_exec_point_at>: New methods.
8875         (tui_source_windows, tui_add_to_source_windows): Update types.
8876         (tui_add_to_source_windows): Remove redundant declaration.
8877         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8878         (tui_source_windows): Change return type.
8879         (tui_clear_source_windows_detail): Update.
8880         (tui_add_to_source_windows): Change type of parameter.
8881         (tui_free_all_source_wins_content): Update.
8882
8883 2019-06-25  Tom Tromey  <tom@tromey.com>
8884
8885         * tui/tui-wingeneral.c (tui_win_info::refresh)
8886         (tui_source_window_base::refresh): New methods.
8887         (tui_refresh_all): Call the refresh method.
8888         * tui/tui-data.h (struct tui_win_info)
8889         (struct tui_source_window_base) <refresh>: New method.
8890
8891 2019-06-25  Tom Tromey  <tom@tromey.com>
8892
8893         * tui/tui.h (tui_is_window_visible): Return bool.
8894         * tui/tui.c (tui_is_window_visible): Return bool.
8895         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8896         (tui_make_visible, tui_make_invisible)
8897         (tui_win_info::make_visible)
8898         (tui_source_window_base::make_visible, make_all_visible)
8899         (tui_make_all_visible, tui_make_all_invisible): Update.
8900         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8901         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8902         bool.
8903         (struct tui_win_info, struct tui_source_window_base)
8904         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8905         * tui/tui-data.c (tui_init_generic_part): Update.
8906
8907 2019-06-25  Tom Tromey  <tom@tromey.com>
8908
8909         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8910         (tui_source_window_base::make_visible): New methods.
8911         (make_all_visible): Make method call.
8912         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8913         (struct tui_source_window_base, struct tui_cmd_window): Override
8914         make_visible.
8915         (tui_win_is_source_type): Don't declare.
8916         * tui/tui-data.c (tui_win_is_source_type): Remove.
8917
8918 2019-06-25  Tom Tromey  <tom@tromey.com>
8919
8920         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8921         NULL check.
8922
8923 2019-06-25  Tom Tromey  <tom@tromey.com>
8924
8925         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8926         Inline constructor.  Add initializers for members.
8927         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8928         constructors; now inline in class.
8929
8930 2019-06-25  Tom Tromey  <tom@tromey.com>
8931
8932         * tui/tui-regs.c (tui_show_registers): Update.
8933         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8934         bool.
8935         * tui/tui-data.c (tui_data_window::clear_detail)
8936         (tui_data_window): Update.
8937
8938 2019-06-25  Tom Tromey  <tom@tromey.com>
8939
8940         * tui/tui-windata.c (tui_display_all_data)
8941         (tui_display_data_from_line, tui_display_data_from)
8942         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8943         Update.
8944         * tui/tui-regs.c (tui_last_regs_line_no)
8945         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8946         (tui_show_registers, tui_show_register_group)
8947         (tui_display_registers_from, tui_display_reg_element_at_line)
8948         (tui_display_registers_from_line, tui_check_register_values)
8949         (tui_reg_next, tui_reg_prev): Update.
8950         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8951         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8952         tui_data_window.
8953         (struct tui_win_info) <detail>: Remove.  Add new fields from
8954         tui_data_info.
8955         (TUI_DATA_WIN): Add cast.
8956         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8957         (~tui_data_window): Simplify.
8958
8959 2019-06-25  Tom Tromey  <tom@tromey.com>
8960
8961         * tui/tui-layout.c (show_source_disasm_command)
8962         (show_source_or_disasm_and_command): Update.
8963         * tui/tui-io.c (update_cmdwin_start_line)
8964         (tui_redisplay_readline): Update.
8965         * tui/tui-data.h (struct tui_command_info): Remove.
8966         (struct tui_win_info) <detail>: Remove command_info member.
8967         (struct tui_data_window) <start_line>: New member, from
8968         tui_command_info.
8969         (TUI_CMD_WIN): Add casts.
8970
8971 2019-06-25  Tom Tromey  <tom@tromey.com>
8972
8973         * tui/tui-winsource.c (tui_update_source_window)
8974         (tui_refill_source_window)
8975         (tui_source_window_base::do_scroll_horizontal)
8976         (tui_update_breakpoint_info, tui_set_exec_info_content)
8977         (tui_show_exec_info_content, tui_erase_exec_info_content)
8978         (tui_clear_exec_info_content): Update.
8979         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8980         Update.
8981         * tui/tui-win.c (make_invisible_and_set_new_height)
8982         (make_visible_with_new_height): Update.
8983         * tui/tui-source.c (tui_set_source_content)
8984         (tui_show_symtab_source): Update.
8985         * tui/tui-layout.c (extract_display_start_addr)
8986         (show_source_disasm_command, show_data)
8987         (make_source_or_disasm_window)
8988         (show_source_or_disasm_and_command): Update.
8989         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8990         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8991         "gdbarch".
8992         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8993         to tui_source_window_base.
8994         (struct tui_win_info) <detail>: Remove source_info member.
8995         (struct tui_source_window_base) <has_locator>: Inline.
8996         Move contents from tui_source_info; rename has_locator member to
8997         m_has_locator.
8998         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8999         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9000         header file.
9001         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9002         Simplify.
9003         (tui_free_all_source_wins_content): Cast to
9004         tui_source_window_base.
9005
9006 2019-06-25  Tom Tromey  <tom@tromey.com>
9007
9008         * tui/tui-win.c (make_invisible_and_set_new_height)
9009         (make_visible_with_new_height): Call has_locator method.
9010         * tui/tui-layout.c (show_source_disasm_command, show_data)
9011         (show_source_or_disasm_and_command): Update for bool change.
9012         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9013         (tui_win_info) <has_locator>: New method.
9014         (struct tui_source_window_base) <has_locator>: New method.
9015         (tui_win_has_locator): Don't declare.
9016         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9017         from tui_win_has_locator.
9018         (tui_source_window_base): Use false, not FALSE.
9019
9020 2019-06-25  Tom Tromey  <tom@tromey.com>
9021
9022         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9023         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9024         clear_detail method directly.
9025         (tui_clear_win_detail): Remove.
9026
9027 2019-06-25  Tom Tromey  <tom@tromey.com>
9028
9029         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9030         "this", not TUI_DISASM_WIN.
9031
9032 2019-06-25  Tom Tromey  <tom@tromey.com>
9033
9034         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9035         declare.
9036         * tui/tui-winsource.c
9037         (tui_source_window_base::do_scroll_horizontal): Rename from
9038         tui_horizontal_source_scroll.
9039         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9040         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9041         from tui_vertical_data_scroll.
9042         * tui/tui-win.h (tui_scroll): Don't declare.
9043         * tui/tui-win.c (tui_win_info::forward_scroll)
9044         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9045         (tui_win_info::right_scroll): Rename and update.
9046         (tui_scroll_forward_command, tui_scroll_backward_command)
9047         (tui_scroll_left_command, tui_scroll_right_command): Update.
9048         (tui_scroll): Remove.
9049         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9050         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9051         from tui_vertical_source_scroll.
9052         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9053         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9054         from tui_vertical_disassem_scroll.
9055         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9056         do_scroll_horizontal>: New methods.
9057         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9058         Likewise.
9059         (struct tui_source_window_base): Add do_scroll_horizontal.
9060         (struct tui_source_window, struct tui_disasm_window): Add
9061         do_scroll_vertical.
9062         (struct tui_data_window, struct tui_cmd_window): Add
9063         do_scroll_horizontal and do_scroll_vertical.
9064         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9065
9066 2019-06-25  Tom Tromey  <tom@tromey.com>
9067
9068         * tui/tui-data.h (struct tui_source_window_base): New struct.
9069         (struct tui_source_window): Derive from tui_source_window_base.
9070         (struct tui_disasm_window): New struct.
9071         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9072         from tui_source_window::clear_detail.
9073         (tui_source_window_base): Rename from tui_source_window.
9074         (~tui_source_window_base): Rename from ~tui_source_window.
9075         (tui_alloc_win_info): Create a tui_disasm_window.
9076
9077 2019-06-25  Tom Tromey  <tom@tromey.com>
9078
9079         * tui/tui-data.h (struct tui_source_window)
9080         (struct tui_data_window): Declare destructors.
9081         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9082         destructors.
9083         (tui_win_info): Simplify.
9084
9085 2019-06-25  Tom Tromey  <tom@tromey.com>
9086
9087         * tui/tui-winsource.c (tui_display_main)
9088         (tui_update_source_windows_with_addr)
9089         (tui_update_all_breakpoint_info): Update.
9090         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9091         (new_height_ok, parse_scrolling_args): Update.
9092         * tui/tui-stack.c (tui_show_frame_info): Update.
9093         * tui/tui-data.h (struct tui_list): Remove.
9094         (tui_source_windows): Return a reference to a std::vector.
9095         * tui/tui-data.c (source_windows): Now a std::vector.
9096         (tui_source_windows): Change return type.
9097         (tui_clear_source_windows): Rewrite.
9098         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9099         (tui_free_all_source_wins_content): Rewrite.
9100
9101 2019-06-25  Tom Tromey  <tom@tromey.com>
9102
9103         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9104         (struct tui_data_window, struct tui_cmd_window): Declare
9105         clear_detail method.
9106         * tui/tui-data.c (tui_source_window::clear_detail)
9107         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9108         methods.
9109         (tui_clear_win_detail): Simplify.
9110
9111 2019-06-25  Tom Tromey  <tom@tromey.com>
9112
9113         * tui/tui-layout.c (make_source_window, make_disasm_window)
9114         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9115         Return the new window.
9116         (show_source_disasm_command, show_data)
9117         (show_source_or_disasm_and_command): Update.
9118
9119 2019-06-25  Tom Tromey  <tom@tromey.com>
9120
9121         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9122         parameter.  Return the new window.
9123         (show_source_disasm_command): Update and remove NULL check.
9124         (show_source_or_disasm_and_command): Update.
9125
9126 2019-06-25  Tom Tromey  <tom@tromey.com>
9127
9128         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9129
9130 2019-06-25  Tom Tromey  <tom@tromey.com>
9131
9132         * tui/tui-data.h (struct tui_win_info): Make constructor
9133         protected.  Make destructor virtual.  Add initializers.
9134         (tui_source_window, tui_data_window, tui_cmd_window): New
9135         classes.
9136         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9137         constructor.  Add "type" parameter.
9138         (tui_source_window, tui_data_window, tui_cmd_window): New
9139         constructors.
9140         (tui_alloc_win_info): Instantiate the appropriate subclass.
9141
9142 2019-06-25  Tom Tromey  <tom@tromey.com>
9143
9144         * tui/tui-win.c (tui_resize_all): Use delete.
9145         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9146         destructor.
9147         (tui_free_window): Don't declare.
9148         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9149         Update.
9150
9151 2019-06-25  Tom Tromey  <tom@tromey.com>
9152
9153         * tui/tui-data.h (struct tui_win_info): Add constructor.
9154         * tui/tui-data.c (tui_alloc_win_info): Use new.
9155         (tui_free_window): Use delete.
9156
9157 2019-06-22  Tom Tromey  <tom@tromey.com>
9158
9159         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9160         declare.
9161         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9162
9163 2019-06-22  Tom Tromey  <tom@tromey.com>
9164
9165         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9166         declare.
9167         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9168
9169 2019-06-22  Tom de Vries  <tdevries@suse.de>
9170
9171         * dwarf2read.c (create_addrmap_from_aranges)
9172         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9173         instead of '%zu'.
9174
9175 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9176
9177         * dwarf2read.h (dwarf2_section_info_def): Remove.
9178         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9179         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9180         std::vector<dwarf2_section_info>.
9181         (struct dwo_file) <~dwo_file>: Remove.
9182         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9183         types field.
9184         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9185         (dwarf2_read_debug_names): Likewise.
9186         (create_debug_types_hash_table): Change parameter type to
9187         array_view, adjust code accordingly.
9188         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9189         (partial_die_info::fixup): Likewise.
9190         (determine_prefix): Likewise.
9191         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9192
9193 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9194
9195         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9196         gdb_bfd_ref_ptr.
9197         <~dwo_file>: Remove call to gdb_bfd_unref.
9198         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9199         gdb_bfd_ref_ptr::get.
9200
9201 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9202
9203         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9204         type to htab_up.
9205         * dwarf2read.c (struct dwo_file): Initialize fields.
9206         <~dwo_file>: New.
9207         (free_dwo_file): Remove, move content to ~dwo_file.
9208         (struct dwo_file_deleter): Remove.
9209         (dwo_file_up>: Remove custom deleter.
9210         (free_dwo_files): Remove.
9211         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9212         dwo_files.
9213         (process_skeletonless_type_units): Call unique_ptr::get.
9214         (allocate_dwo_file_hash_table): Add deleter to created hash
9215         table.  Change return type to htab_up.
9216         (lookup_dwo_file_slot): Don't memset dwo_file, call
9217         unique_ptr::get.
9218         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9219         (create_dwo_unit_in_dwp_v2): Likewise.
9220         (open_and_init_dwo_file): Likewise.
9221         (free_dwo_file_from_slot): Remove.
9222
9223 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9224
9225         * dwarf2read.h (struct dwarf2_section_info) <readin,
9226         is_virtual>: Change type to bool.
9227         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9228         true instead of 1.
9229
9230 2019-06-19  Tom Tromey  <tom@tromey.com>
9231
9232         * tui/tui-data.h (tui_init_content_element): Don't declare.
9233
9234 2019-06-19  Tom Tromey  <tom@tromey.com>
9235
9236         * tui/tui-data.h (tui_init_win_info): Don't declare.
9237
9238 2019-06-19  Tom de Vries  <tdevries@suse.de>
9239
9240         * dwarf2read.h (abstract_to_concrete): Change type to
9241         std::unordered_map<sect_offset, std::vector<sect_offset>,
9242         gdb::hash_enum<sect_offset>>.
9243
9244 2019-06-19  Tom Tromey  <tromey@adacore.com>
9245
9246         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9247         EVAL_AVOID_SIDE_EFFECTS specially.
9248
9249 2019-06-19  Tom Tromey  <tromey@adacore.com>
9250
9251         * source-cache.c (highlighter): New global.
9252         (source_cache::get_source_lines): Create a highlighter on demand.
9253
9254 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * defs.h (deprecated_interactive_hook): Delete declaration.
9257         * interps.c (clear_interpreter_hooks): Remove use of
9258         deprecated_interactive_hook.
9259         * top.c (deprecated_interactive_hook): Delete definition.
9260         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9261
9262 2019-06-18  Tom de Vries  <tdevries@suse.de>
9263
9264         PR gdb/24515
9265         * dwarf2read.h (abstract_to_concrete): Change type from
9266         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9267         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9268         * dwarf2read.c (read_variable): Update.
9269         (dwarf2_fetch_die_loc_sect_off): Update.
9270
9271 2019-06-17  Tom de Vries  <tdevries@suse.de>
9272
9273         PR gdb/24617
9274         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9275         accessing parent[parent_len - 1].
9276
9277 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9278
9279         PR gdb/24364
9280         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9281         call dtrace_process_dof with NULL dof.
9282
9283 2019-06-16  Tom de Vries  <tdevries@suse.de>
9284
9285         PR gdb/24445
9286         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9287
9288 2019-06-16  Tom Tromey  <tom@tromey.com>
9289
9290         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9291         (make_all_visible): Use address of member.
9292
9293 2019-06-16  Tom Tromey  <tom@tromey.com>
9294
9295         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9296         (tui_free_window, free_content, free_content_elements): Remove
9297         unnecessary cast.
9298         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9299         cast.
9300         * tui/tui-regs.c (tui_show_register_group)
9301         (tui_display_registers_from, tui_display_reg_element_at_line):
9302         Remove unnecessary cast.
9303
9304 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * linux-nat.c (normal_mask): Delete.
9307         (_initialize_linux_nat): Don't initialise normal_mask.
9308
9309 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9310
9311         PR gdb/24445
9312         * dwarf-index-write.h (write_psymtabs_to_index): Add
9313         dwz_basename parameter.
9314         * dwarf-index-write.c (write_gdbindex): Move file writing to
9315         write_gdbindex_1.  Change return type void.
9316         (assert_file_size): Move up, remove filename parameter.
9317         (write_gdbindex_1): New function.
9318         (write_debug_names): Change return type to void, call
9319         assert_file_size.
9320         (struct index_wip_file): New struct.
9321         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9322         file logic to index_wip_file.  Write index for dwz file if
9323         needed.
9324         (save_gdb_index_command): Pass basename of dwz file, if present.
9325         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9326         build-id of dwz file, if present.
9327         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9328         (dwarf2_get_dwz_file): Likewise.
9329         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9330         (dwarf2_get_dwz_file): Likewise.
9331
9332 2019-06-16  Tom Tromey  <tom@tromey.com>
9333
9334         * coffread.c (process_coff_symbol): Use xstrdup.
9335         * value.c (create_internalvar): Use xstrdup.
9336
9337 2019-06-16  Tom Tromey  <tom@tromey.com>
9338
9339         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9340         * breakpoint.c (stopin_command, stopat_command)
9341         (until_break_command, decode_location_default): Remove unnecessary
9342         cast.
9343         * utils.c (subset_compare): Remove unnecessary cast.
9344         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9345         cast.
9346         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9347         cast.
9348         * infcmd.c (path_command): Remove unnecessary cast.
9349         * coffread.c (decode_type): Remove unnecessary cast.
9350         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9351         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9352         * tui/tui-stack.c (tui_show_locator_content)
9353         (tui_show_frame_info): Remove unnecessary cast.
9354         * tui/tui-win.c (tui_scroll_forward_command)
9355         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9356         (parse_scrolling_args): Remove unnecessary cast.
9357         * tui/tui-data.c (init_win_info, tui_del_window)
9358         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9359         (free_content_elements): Remove unnecessary cast.
9360         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9361         unnecessary cast.
9362         * tui/tui-source.c (tui_set_source_content)
9363         (tui_vertical_source_scroll): Remove unnecessary cast.
9364         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9365         cast.
9366         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9367         * tui/tui-regs.c (tui_display_registers_from)
9368         (tui_display_register): Remove unnecessary cast.
9369         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9370         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9371         (make_visible): Remove unnecessary cast.
9372         * tui/tui-winsource.c (tui_erase_source_content)
9373         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9374         unnecessary cast.
9375         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9376         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9377         * stabsread.c (read_type, read_array_type, read_range_type):
9378         Remove unnecessary cast.
9379         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9380         (parse_symbol, parse_type, upgrade_type, parse_external)
9381         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9382         unnecessary cast.
9383         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9384
9385 2019-06-16  Tom Tromey  <tom@tromey.com>
9386
9387         * tui/tui-data.c (tui_alloc_generic_win_info)
9388         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9389         checks.
9390
9391 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9392             Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * f-typeprint.c (f_print_type): Don't return early for not
9395         associated or not allocated types.
9396         (f_type_print_varspec_suffix): Add print_rank parameter and print
9397         ranks of array types in case they dangling.
9398         (f_type_print_base): Add print_rank parameter.
9399
9400 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * NEWS: Mention new MI commands.
9403         * break-catch-throw.c (enum exception_event_kind): Move to
9404         breakpoint.h.
9405         (print_mention_exception_catchpoint): Output text as a single
9406         message.
9407         (catch_exception_command_1): Rename to...
9408         (catch_exception_event): ...this, make non-static, update header
9409         command, and change some parameter types.
9410         (catch_catch_command): Update for changes to
9411         catch_exception_command_1.
9412         (catch_throw_command): Likewise.
9413         (catch_rethrow_command): Likewise.
9414         * breakpoint.c (enum exception_event_kind): Delete.
9415         * breakpoint.h (enum exception_event_kind): Moved here from
9416         break-catch-throw.c.
9417         (catch_exception_event): Declare.
9418         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9419         (mi_cmd_catch_throw): New function.
9420         (mi_cmd_catch_rethrow): New function.
9421         (mi_cmd_catch_catch): New function.
9422         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9423         'catch-catch' entries.
9424         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9425         (mi_cmd_catch_rethrow): Declare.
9426         (mi_cmd_catch_catch): Declare.
9427
9428 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9429
9430         * annotate.c (annotate_source_line): Change return type to void,
9431         update implementation to match.
9432         * annotate.h (annotate_source_line): Change return type to void,
9433         update header comment.
9434         * stack.c (print_frame_info): Don't change what frame information
9435         is printed based on whether annotations are on or not.
9436
9437 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9438
9439         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9440         (annotate_source): Make static.
9441         (annotate_source_line): Moved from source.c and renamed from
9442         identify_source_line.  Update the return type.
9443         * annotate.h (annotate_source): Delete declaration.
9444         (annotate_source_line): Declaration moved from source.h, and
9445         renamed from identify_source_line.  Return type updated.
9446         * source.c (identify_source_line): Moved to annotate.c and renamed
9447         to annotate_source_line.
9448         (info_line_command): Remove check of annotation_level.
9449         * source.h (identify_source_line): Move declaration to annotate.h
9450         and rename to annotate_source_line.
9451         * stack.c: Add 'annotate.h' include.
9452         (print_frame_info): Remove check of annotation_level before
9453         calling annotate_source_line.
9454
9455 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9456
9457         * source-cache.c (source_cache::get_plain_source_lines): Use
9458         open_source_file_with_line_charpos instead of just
9459         open_source_file, remove call to find_source_lines.
9460         (source_cache::get_source_lines): Likewise.
9461         * source.c (find_source_lines): Make static.
9462         (get_filename_and_charpos): Renamed into...
9463         (open_source_file_with_line_charpos): ..this along with changes to
9464         return a scoped_fd, and some other minor clean ups.
9465         (identify_source_line): Use open_source_file_with_line_charpos.
9466         (search_command_helper): Use open_source_file_with_line_charpos
9467         instead of just open_source_file, remove call to
9468         find_source_lines.
9469         * source.h (open_source_file_with_line_charpos): Declare new
9470         function.
9471         (find_source_lines): Delete declaration.
9472
9473 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * source.c (get_filename_and_charpos): Remove fullname
9476         parameter.
9477         (identify_source_line): Update call to get_filename_and_charpos.
9478
9479 2019-06-14  Tom Tromey  <tromey@adacore.com>
9480
9481         PR gdb/24502:
9482         * ui-style.h (skip_ansi_escape): Update comment.
9483         * ui-file.h (class no_terminal_escape_file): New class.
9484         * ui-file.c (no_terminal_escape_file::write)
9485         (no_terminal_escape_file::puts): New methods.
9486         * cli/cli-logging.c (handle_redirections): Use
9487         no_terminal_escape_file.
9488
9489 2019-06-14  Tom Tromey  <tromey@adacore.com>
9490
9491         * NEWS: Move convenience variable news above Python news.
9492
9493 2019-06-14  Tom Tromey  <tom@tromey.com>
9494
9495         * gnulib: Move directory to top-level.
9496         * configure.ac: Don't configure gnulib.
9497         * configure: Rebuild.
9498         * common/common-defs.h: Use new path to gnulib.
9499         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9500         (GNULIB_H): Remove.
9501         (INCGNU): Look in new gnulib location.
9502         (HFILES_NO_SRCDIR): Remove gnulib files.
9503         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9504         (generated_files): Remove GNULIB_H.
9505         ($(LIBGNU), all-lib): Remove targets.
9506         (distclean): Don't mention GNULIB_BUILDDIR.
9507         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9508
9509 2019-06-14  Tom Tromey  <tromey@adacore.com>
9510
9511         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9512         Warn if symbol file does not provide any symbols.
9513
9514 2019-06-14  Tom Tromey  <tromey@adacore.com>
9515
9516         * source.c (find_and_open_source): Respect basenames_may_differ.
9517
9518 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9519
9520         * annotate.c (annotate_breakpoints_invalid): Make use of
9521         scoped_restore_terminal_state.
9522         (annotate_frames_invalid): Likewise.
9523
9524 2019-06-14  Tom Tromey  <tromey@adacore.com>
9525
9526         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9527         allow assignment to an internalvar.
9528
9529 2019-06-14  Tom Tromey  <tromey@adacore.com>
9530
9531         * ada-lex.l: Allow "_" in attribute names.
9532
9533 2019-06-14  Tom Tromey  <tromey@adacore.com>
9534
9535         PR gdb/24653:
9536         * regcache.c (registers_changed): Don't call alloca.
9537         * top.c (execute_command): Don't call alloca.
9538
9539 2019-06-13  Pedro Alves  <palves@redhat.com>
9540
9541         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9542         'expression'.  When parsing an expression, error out if there's
9543         junk after "unlimited".
9544         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9545         (do_set_command): Adjust calls to is_unlimited_literal.
9546
9547 2019-06-13  Pedro Alves  <palves@redhat.com>
9548
9549         * compile/compile.c (make_compile_options_def_group): Add braces
9550         around array_view initializer.
9551         * thread.c (make_thread_apply_all_options_def_group)
9552         (make_thread_apply_all_options_def_group): Likewise.
9553
9554 2019-06-13  Pedro Alves  <palves@redhat.com>
9555
9556         * NEWS (New commands): Mention "maint test-options
9557         require-delimiter", "maint test-options unknown-is-error", "maint
9558         test-options unknown-is-operand" and "maint show
9559         test-options-completion-result".
9560         (New command options, command completion): New section.
9561         (Completion improvements): New section.
9562         Mention that you can abbreviate "unlimited".
9563
9564 2019-06-13  Pedro Alves  <palves@redhat.com>
9565
9566         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9567         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9568         * unittests/cli-utils-selftests.c (test_parse_flags)
9569         (test_parse_flags_qcs): Delete.
9570         (test_cli_utils): Don't call deleted functions.
9571
9572 2019-06-13  Pedro Alves  <palves@redhat.com>
9573
9574         * thread.c: Include "cli/cli-option.h".
9575         (tp_array_compar_ascending): Global.
9576         (tp_array_compar): Delete function.
9577         (tp_array_compar_ascending, tp_array_compar_descending): New
9578         functions.
9579         (ascending_option_def, qcs_flag_option_def)
9580         (thr_qcs_flags_option_defs)
9581         (make_thread_apply_all_options_def_group)
9582         (make_thread_apply_options_def_group): New.
9583         (thread_apply_all_command): Use gdb::option::process_options.
9584         (thread_apply_command_completer)
9585         (thread_apply_all_command_completer): New.
9586         (thread_apply_command): Use gdb::option::process_options.
9587         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9588         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9589         to generate help text of "thread apply".  Adjust "taas"'s help.
9590         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9591         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9592
9593 2019-06-13  Pedro Alves  <palves@redhat.com>
9594
9595         * thread.c (thread_apply_command): Check for invalid TID with
9596         isdigit instead of !isalpha.
9597
9598 2019-06-13  Pedro Alves  <palves@redhat.com>
9599
9600         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9601         (validate_flags_qcs): New.
9602         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9603         (validate_flags_qcs): Declare.
9604         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9605         (make_frame_apply_options_def_group): New.
9606         (frame_apply_command_count): Process options with
9607         gdb::option::process_options.
9608         (frame_apply_completer): New.
9609         (frame_apply_level_completer, frame_apply_all_completer)
9610         (frame_apply_completer): New.
9611         (_initialize_stack): Update help of "frame apply", "frame apply
9612         level", "frame apply all" and "faas" to mention supported options
9613         and install command completers.
9614         * stack.h (frame_apply_all_completer): Declare.
9615         * thread.c: Include "stack.h".
9616         (tfaas_command): Add "--".
9617         (_initialize_thread): Update help "tfaas" to mention supported
9618         options and install command completer.
9619
9620 2019-06-13  Pedro Alves  <palves@redhat.com>
9621
9622         * completer.c (complete_nested_command_line): New.
9623         (gdb_completion_word_break_characters_throw): Add assertion.
9624         * completer.h (complete_nested_command_line): Declare.
9625
9626 2019-06-13  Pedro Alves  <palves@redhat.com>
9627
9628         * stack.c (parse_backtrace_qualifiers): New.
9629         (backtrace_command): Use it.
9630         (backtrace_command_completer): Complete on qualifiers.
9631
9632 2019-06-13  Pedro Alves  <palves@redhat.com>
9633
9634         * frame.c: Include "cli/cli-option.h.
9635         (user_set_backtrace_options): New.
9636         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9637         Delete.
9638         (get_prev_frame): Adjust.
9639         (boolean_option_def, uinteger_option_def)
9640         (set_backtrace_option_defs): New.
9641         (_initialize_frame): Adjust and use
9642         gdb::option::add_setshow_cmds_for_options to install "set
9643         backtrace past-main" and "set backtrace past-entry".
9644         * frame.h: Include "cli/cli-option.h".
9645         (struct frame_print_options): Forward declare.
9646         (print_frame_arguments_all, print_frame_arguments_scalars)
9647         (print_frame_arguments_none): Declare.
9648         (print_entry_values): Delete declaration.
9649         (struct frame_print_options, user_frame_print_options): New.
9650         (struct set_backtrace_options): New.
9651         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9652         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9653         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9654         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9655         (list_args_or_locals): Add frame_print_options parameter.
9656         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9657         * python/py-framefilter.c (enumerate_args): Pass down
9658         USER_FRAME_PRINT_OPTIONS.
9659         * stack.c: Include "cli/cli-option.h".
9660         (print_frame_arguments_all, print_frame_arguments_scalars)
9661         (print_frame_arguments_none): Declare.
9662         (print_raw_frame_arguments, print_entry_values): Delete.
9663         (user_frame_print_options): New.
9664         (boolean_option_def, enum_option_def, frame_print_option_defs):
9665         New.
9666         (struct backtrace_cmd_options): New.
9667         (bt_flag_option_def): New.
9668         (backtrace_command_option_defs): New.
9669         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9670         (print_frame_arg, read_frame_arg, print_frame_args)
9671         (print_frame_info, print_frame): Add frame_print_options parameter
9672         and use it.
9673         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9674         (backtrace_command_1): Add frame_print_options and
9675         backtrace_cmd_options parameters and use them.
9676         (make_backtrace_options_def_group): New.
9677         (backtrace_command): Process command options with
9678         gdb::option::process_options.
9679         (backtrace_command_completer): New.
9680         (_initialize_stack): Extend "backtrace"'s help to mention
9681         supported options.  Install completer for "backtrace".
9682         Install some settings commands with add_setshow_cmds_for_options.
9683
9684 2019-06-13  Pedro Alves  <palves@redhat.com>
9685
9686         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9687         and that "set/show print raw frame-arguments" are now deprecated.
9688
9689         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9690         command.
9691         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9692         * stack.c (_initialize_stack): Install "set/show print
9693         raw-frame-arguments", and deprecate "set/show print raw
9694         frame-arguments".
9695         * valprint.c (_initialize_valprint): Deprecate "set/show print
9696         raw".
9697
9698 2019-06-13  Pedro Alves  <palves@redhat.com>
9699
9700         * compile/compile.c (struct compile_options): New.
9701         (compile_flag_option_def, compile_command_option_defs)
9702         (make_compile_options_def_group): New.
9703         (compile_file_command): Handle options with
9704         gdb::option::process_options.
9705         (compile_file_command_completer): New function.
9706         (compile_code_command): Handle options with
9707         gdb::option::process_options.
9708         (compile_code_command_completer): New function.
9709         (_initialize_compiler): Install completers for "compile code" and
9710         "compile file".  Mention available options in "compile code" and
9711         "compile code"'s help.
9712         * completer.c (advance_to_completion_word): New, factored out from
9713         ...
9714         (advance_to_expression_complete_word_point): ... this.
9715         (advance_to_filename_complete_word_point): New.
9716         * completer.h (advance_to_filename_complete_word_point): New
9717         declaration.
9718
9719 2019-06-13  Pedro Alves  <palves@redhat.com>
9720
9721         * compile/compile.c: Include "cli/cli-option.h".
9722         (compile_print_value): Scope data pointer is now a
9723         value_print_options pointer; adjust.
9724         (compile_print_command): Process options.  Scope data pointer is
9725         now a value_print_options pointer; adjust.
9726         (_initialize_compile): Update "compile print"'s help to include
9727         supported options.  Install a completer for "compile print".
9728         * cp-valprint.c (show_vtblprint, show_objectprint)
9729         (show_static_field_print): Delete.
9730         (_initialize_cp_valprint): Don't install "set print
9731         static-members", "set print vtbl", "set print object" here.
9732         * printcmd.c: Include "cli/cli-option.h" and
9733         "common/gdb_optional.h".
9734         (print_command_parse_format): Rework to fill in a
9735         value_print_options instead of a format_data.
9736         (print_value): Change parameter type from format_data pointer to
9737         value_print_options reference.  Adjust.
9738         (print_command_1): Process options.  Adjust to pass down a
9739         value_print_options.
9740         (print_command_completer): New.
9741         (_initialize_printcmd): Install print_command_completer as
9742         handle_brkchars completer for the "print" command.  Update
9743         "print"'s help to include supported options.
9744         * valprint.c: Include "cli/cli-option.h".
9745         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9746         here from cp-valprint.c.
9747         (boolean_option_def, uinteger_option_def)
9748         (value_print_option_defs, make_value_print_options_def_group):
9749         New.  Use gdb::option::add_setshow_cmds_for_options to install
9750         "set print elements", "set print null-stop", "set print repeats",
9751         "set print pretty", "set print union", "set print array", "set
9752         print address", "set print symbol", "set print array-indexes".
9753         * valprint.h: Include <string> and "cli/cli-option.h".
9754         (make_value_print_options_def_group): Declare.
9755         (print_value): Change parameter type from format_data pointer to
9756         value_print_options reference.
9757         (print_command_completer): Declare.
9758
9759 2019-06-13  Pedro Alves  <palves@redhat.com>
9760
9761         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9762         (COMMON_SFILES): Add maint-test-settings.c.
9763         * cli/cli-decode.c (boolean_enums): New global, factored out from
9764         ...
9765         (add_setshow_boolean_cmd): ... here.
9766         * cli/cli-decode.h (boolean_enums): Declare.
9767         * cli/cli-option.c: New file.
9768         * cli/cli-option.h: New file.
9769         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9770         factored out from ...
9771         (parse_cli_boolean_value(const char *)): ... this.
9772         (is_unlimited_literal): Change parameter type to pointer to
9773         pointer.  Adjust and advance ARG pointer.
9774         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9775         (parse_cli_var_enum): New, factored out from ...
9776         (do_set_command): ... this.  Adjust.
9777         * cli/cli-setshow.h (parse_cli_boolean_value)
9778         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9779         (parse_cli_var_enum): Declare.
9780         * cli/cli-utils.c: Include "cli/cli-option.h".
9781         (get_ulongest): New.
9782         * cli/cli-utils.h (get_ulongest): Declare.
9783         (check_for_argument): New overloads.
9784         * maint-test-options.c: New file.
9785
9786 2019-06-13  Pedro Alves  <palves@redhat.com>
9787
9788         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9789         parse a range if "-" is at the end of the string.
9790
9791 2019-06-13  Pedro Alves  <palves@redhat.com>
9792
9793         * cli/cli-setshow.c (parse_auto_binary_operation)
9794         (parse_cli_boolean_value): Don't allow "o".
9795
9796 2019-06-13  Pedro Alves  <palves@redhat.com>
9797
9798         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9799         * NEWS: Mention maint test-settings KIND.
9800         * maint-test-settings.c: New file.
9801
9802 2019-06-13  Pedro Alves  <palves@redhat.com>
9803
9804         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9805         completer.
9806         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9807         "set" completers.
9808
9809 2019-06-13  Pedro Alves  <palves@redhat.com>
9810
9811         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9812         after item.
9813
9814 2019-06-13  Pedro Alves  <palves@redhat.com>
9815
9816         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9817
9818 2019-06-13  Pedro Alves <palves@redhat.com>
9819
9820         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9821         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9822         call.
9823         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9824         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9825         calls.
9826         (check_for_argument): Skip spaces after argument.
9827
9828 2019-06-13  Pedro Alves  <palves@redhat.com>
9829
9830         * thread.c (thread_apply_command): Adjust TID parsing.
9831         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9832         detected before end of string.
9833         (tid_is_in_list): Error out if LIST is invalid.
9834
9835 2019-06-13  Pedro Alves  <palves@redhat.com>
9836
9837         * completer.c (complete_line_internal_1): Rewind completion word
9838         point.
9839         (completion_tracker::advance_custom_word_point_by): Change
9840         parameter type to int.
9841         * completer.h (completion_tracker::advance_custom_word_point_by):
9842         Likewise.
9843
9844 2019-06-13  Pedro Alves  <palves@redhat.com>
9845
9846         * completer.c (advance_to_completion_word): Handle delimiters.
9847
9848 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9849
9850         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9851
9852 2019-06-11  Tom Tromey  <tom@tromey.com>
9853
9854         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9855         (xmalloc_failed): Move to alloc.c.
9856         * alloc.c: New file.
9857         * Makefile.in (COMMON_SFILES): Add alloc.c.
9858
9859 2019-06-11  Tom Tromey  <tom@tromey.com>
9860
9861         * nat/linux-waitpid.c: Don't include server.h.
9862         (linux_debug): Remove.
9863         (my_waitpid): Update.
9864
9865 2019-06-11  Tom Tromey  <tromey@adacore.com>
9866
9867         * infcall.c (_initialize_infcall): Remove trailing newline from
9868         help.
9869         * user-regs.c (_initialize_user_regs): Remove trailing newline
9870         from help.
9871         * typeprint.c (_initialize_typeprint): Remove trailing newline
9872         from help.
9873         * reverse.c (_initialize_reverse): Remove trailing newlines from
9874         help.
9875         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9876         from help.
9877         * language.c (add_set_language_command): Remove trailing newline
9878         from help.
9879         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9880         help.
9881         * disasm.c (_initialize_disasm): Remove trailing newline from
9882         help.
9883         * top.c (init_main): Remove trailing newline from help.
9884         * interps.c (_initialize_interpreter): Remove trailing newline
9885         from help.
9886         * btrace.c (_initialize_btrace): Remove trailing newlines from
9887         help.
9888         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9889         from help.
9890         * python/python.c (_initialize_python): Remove trailing newline
9891         from help.
9892         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9893         help.
9894         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9895         from help.  Reformat some text.
9896         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9897         from help.
9898         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9899         newline from help.
9900
9901 2019-06-11  Tom Tromey  <tromey@adacore.com>
9902
9903         * darwin-nat.c (darwin_decode_exception_message)
9904         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9905
9906 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9907
9908         * valops.c (value_slice): Check for not allocated or not
9909         associated values.
9910
9911 2019-06-10  Tom de Vries  <tdevries@suse.de>
9912
9913         PR gdb/24618
9914         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9915         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9916         invalid.
9917
9918 2019-06-10  Tom de Vries  <tdevries@suse.de>
9919
9920         PR gdb/24611
9921         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9922         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9923
9924 2019-06-10  Tom de Vries  <tdevries@suse.de>
9925
9926         PR symtab/24545
9927         * symtab.c (struct demangled_name_entry): Add language field.
9928         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9929         static minimal symbol".  Set and use language field.
9930
9931 2019-06-10  Tom Tromey  <tromey@adacore.com>
9932
9933         * ada-lang.c (_initialize_ada_language): Update help text.
9934
9935 2019-06-10  Tom Tromey  <tromey@adacore.com>
9936
9937         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9938         with a newline.
9939         * guile/guile.c (handle_boot_error): Don't end warning with a
9940         newline.
9941         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9942         warning with a newline.
9943         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9944         newline.
9945         (s12z_frame_cache): Likewise.
9946         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9947         a newline.
9948         * solib-svr4.c (disable_probes_interface): Don't end warning with
9949         a newline.
9950         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9951         newline.
9952         * python/python.c (do_finish_initialization): Don't end warning
9953         with a newline.
9954
9955 2019-06-10  Tom Tromey  <tom@tromey.com>
9956
9957         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9958         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9959         gdbpy_enter.
9960
9961 2019-06-10  Tom Tromey  <tromey@adacore.com>
9962
9963         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9964         data.
9965         (elf_new_init): Don't call stabsread_new_init.
9966         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9967         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9968         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9969
9970 2019-06-10  Tom de Vries  <tdevries@suse.de>
9971
9972         PR symtab/16264
9973         PR symtab/24517
9974         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9975
9976 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9977
9978         * source.c (find_and_open_source): Also rewrite relative file
9979         names.
9980
9981 2019-04-26  Amos Bird  <amosbird@gmail.com>
9982
9983         * annotate.c (annotate_thread_exited): Add "thread-exited"
9984         annotation.
9985
9986 2019-06-06  Tom Tromey  <tromey@adacore.com>
9987
9988         * maint.h (class scoped_command_stats): Use
9989         DISABLE_COPY_AND_ASSIGN.
9990         <print_time>: New method.
9991         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9992         print_time.
9993         (scoped_command_stats::print_time): New method.
9994
9995 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9996
9997         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9998         instructions of lengths 6 or 8 bytes.
9999
10000 2019-06-04  Pedro Alves  <palves@redhat.com>
10001
10002         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10003
10004         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10005         * breakpoint.c (condition_completer): Likewise.
10006         * cli/cli-dump.c (scan_expression): Likewise.
10007         * common/filestuff.c (mkdir_recursive): Likewise.
10008         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10009         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10010         (gdb_abspath): Likewise.
10011         * compile/compile-cplus-types.c
10012         (compile_cplus_instance::decl_name): Likewise.
10013         * completer.c (complete_explicit_location):
10014         (signal_completer, reg_or_group_completer_1): Likewise.
10015         * cp-support.c (cp_remove_params_if_any): Likewise.
10016         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10017         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10018         * infcmd.c (strip_bg_char): Likewise.
10019         * linespec.c (copy_token_string): Likewise.
10020         * mi/mi-main.c (output_cores): Likewise.
10021         * psymtab.c (psymtab_search_name):
10022         * symfile.c (test_set_ext_lang_command): Likewise.
10023         * target.c (target_fileio_read_stralloc): Likewise.
10024         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10025         * value.c (complete_internalvar): Likewise.
10026
10027 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10028
10029         Add objfile property to gdb.Type.
10030         * NEWS: Mention Python API addition.
10031         * python/py-type.c (typy_get_objfile): New method.
10032
10033 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10034
10035         * NEWS: Mention the new set|show style [title|highlight].
10036         Mention changes to "show style", "help" and "apropos".
10037
10038 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10039
10040         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10041         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10042         instead of print_help_for_command.
10043         (print_doc_of_command): New function.
10044         (help_list): Add 'apropos -v word' suggestion.
10045         (print_help_for_command): Style the command name using title style.
10046         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10047         (_initialize_cli_cmds): Describe -v in apropos_command help.
10048
10049 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10050
10051         * cli/cli-style.h (cli_style_option): Add name in constructor,
10052         add m_name class member, add constructor with intensity,
10053         add name class function.
10054         (cli_style_option::add_setshow_commands): Remove name argument.
10055         (highlight_style, title_style): New styles.
10056         * cli/cli-style.c (do_show): New function that shows a style
10057         characteristic styling the style name with itself.
10058         (set_style_name): New function.
10059         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10060         Update all callers according to the changes in cli/cli-style.h.
10061         * utils.h (fputs_highlighted): New function.
10062         * utils.c (fputs_highlighted): Likewise.
10063
10064 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10065
10066         * NEWS: Mention new pipe command and new convenience variables.
10067
10068 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10069
10070         * cli/cli-cmds.c (pipe_command): New function.
10071         (_initialize_cli_cmds): Call add_com for pipe_command.
10072         Define | as an alias for pipe.
10073         (exit_status_set_internal_vars): New function.
10074         (shell_escape): Call exit_status_set_internal_vars.
10075         cli/cli-decode.c (find_command_name_length): Recognize | as
10076         a single character command.
10077
10078 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10079
10080         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10081         top.c (execute_command_to_ui_file): New function, mostly a copy
10082         of execute_command_to_string.
10083         (execute_command_to_string): Implement by calling
10084         execute_command_to_ui_file.
10085
10086 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10087
10088         * top.h (saved_command_line): Remove declaration.
10089         * top.c (previous_saved_command_line, previous_repeat_arguments):
10090         New variables.
10091         (saved_command_line): Make static, define together with other
10092         'repeat variables'.
10093         (dont_repeat): Clear repeat_arguments.
10094         (repeat_previous, get_saved_command_line, save_command_line):
10095         New functions.
10096         (gdb_init): Initialize saved_command_line
10097         and previous_saved_command_line.
10098         * main.c (captured_main_1): Remove saved_command_line initialization.
10099         * event-top.c (handle_line_of_input): Update to use
10100         the new 'repeat' related functions instead of direct access to
10101         saved_command_line.
10102         * command.h (repeat_previous, get_saved_command_line,
10103         save_command_line): New declarations.
10104         (dont_repeat): Add comment.
10105
10106 2019-05-30  Tom Tromey  <tromey@adacore.com>
10107
10108         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10109         Fix comment.
10110         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10111
10112 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10113
10114         PR cli/24587
10115         * completer.c (complete): Initialize variable word.
10116
10117 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10118
10119         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10120         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10121         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10122         'body' is NULL to the outter 'if', protecting the '!is_define'
10123         situation as well.
10124
10125 2019-05-29  Tom Tromey  <tromey@adacore.com>
10126
10127         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10128         (dwarf_unknown): New function.
10129         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10130         (dwarf_type_encoding_name): Use dwarf_unknown.
10131
10132 2019-05-29  Tom Tromey  <tromey@adacore.com>
10133
10134         PR c++/20020:
10135         * cp-valprint.c (cp_print_value_fields): Call
10136         cp_print_static_field inside "try".
10137
10138 2019-05-29  Tom Tromey  <tromey@adacore.com>
10139
10140         * inflow.c (struct terminal_info): Add default operator=.
10141         * configure: Rebuild.
10142         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10143         -Wdeprecated-copy-dtor, -Wredundant-move.
10144
10145 2019-05-29  Tom Tromey  <tromey@adacore.com>
10146
10147         * NEWS: Add entry.
10148         * infcmd.c (print_return_value_1): Handle finish_print
10149         option.
10150         (show_print_finish): New function.
10151         (_initialize_infcmd): Add "set/show print finish" commands.
10152         * valprint.c (user_print_options): Initialize new member.
10153         * valprint.h (struct value_print_options) <finish_print>: New
10154         member.
10155
10156 2019-05-28  Tom Tromey  <tromey@adacore.com>
10157
10158         * ada-lang.c (ada_remove_Xbn_suffix)
10159         (find_old_style_renaming_symbol)
10160         (parse_old_style_renaming): Remove.
10161         (ada_find_renaming_symbol): Don't call
10162         find_old_style_renaming_symbol.
10163         (ada_is_renaming_symbol): Rename from
10164         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10165         bool.  Now static.
10166         (ada_read_var_value): Update and simplify.
10167         * ada-exp.y (write_var_or_type): Remove old code.
10168
10169 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10170
10171         PR gdb/25010
10172         * event-top.c: Remove include comment.
10173         * inflow.c (class scoped_ignore_sigttou): Move from here...
10174         * inflow.h (class scoped_ignore_sigttou): ...to here.
10175         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10176         * top.c:  Remove include comment.
10177
10178 2019-05-27  Tom Tromey  <tom@tromey.com>
10179
10180         * NEWS: Fix typo.
10181
10182 2019-05-22  Tom Tromey  <tromey@adacore.com>
10183
10184         * target.c (target_follow_exec): Constify parameter.
10185         * target-delegates.c: Rebuild.
10186         * remote.c (remote_target::follow_exec): Constify parameter.
10187         * infrun.c (follow_exec): Constify parameter.
10188         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10189         (target_follow_exec): Likewise.
10190
10191 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10192
10193         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10194         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10195
10196 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10197
10198         * NEWS: Add debugredirect and testsuite sections.
10199
10200 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10201
10202         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10203         target descriptions using exclusively floating point register name
10204         aliases.
10205
10206 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10207
10208         PR gdb/18644:
10209         * f-lang.c (build_fortran_types): Handle the case where
10210         gdbarch_floatformat_for_type returns a nullptr.
10211
10212 2019-05-21  Tom de Vries  <tdevries@suse.de>
10213
10214         PR cli/24587
10215         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10216
10217 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         PR gdb/18644:
10220         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10221         16-byte floats.
10222         * i386-tdep.c (i386_floatformat_for_type): Use
10223         floatformats_ia64_quad for the 16-byte floating point component
10224         within a fortran 32-byte complex number.
10225
10226 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10227
10228         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10229         delete default constructor.
10230         (find_partial_die): Update to return const struct.
10231         (partial_die_parent_scope): Move variable declaration into scope
10232         of its use and change its type to auto.
10233         (guess_partial_die_structure_name): Likewise.
10234         (partial_die_info::fixup): Likewise.
10235
10236 2019-05-17  Tom Tromey  <tromey@adacore.com>
10237
10238         * source.c (find_and_open_source): Remove cast.
10239
10240 2019-05-17  Tom Tromey  <tromey@adacore.com>
10241
10242         * annotate.c (annotate_source): Make "filename" const.
10243         * annotate.h (annotate_source): Use const.
10244
10245 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10246
10247         * disasm.c (set_disassembler_options): Send errors to stderr.
10248
10249 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10250
10251         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10252         (cli_interp_base::set_logging): Check debug_redirect.
10253         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10254         * cli/cli-logging.c (debug_redirect): Add static variable.
10255         (pop_output_files): Add default param.
10256         (handle_redirections): Print debug setting.
10257         (show_logging_command): Likewise.
10258         (_initialize_cli_logging): Add debugredirect command.
10259         * interps.c (current_interp_set_logging): Add debug_redirect
10260         parameter.
10261         * interps.h (set_logging): Add debug_redirect parameter.
10262         (current_interp_set_logging): Likewise.
10263         * mi/mi-common.h: Likewise.
10264         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10265
10266 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10267             Tom Tromey  <tromey@adacore.com>
10268
10269         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10270         directly.
10271         * cli/cli-interp.h (make_logging_output): Remove declaration.
10272         * cli/cli-logging.c (make_logging_output): Remove function.
10273         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10274         directly.
10275         * ui-file.c (tee_file::tee_file): Remove bools.
10276         (tee_file::~tee_file): Remove deletes.
10277         * ui-file.h (tee_file): Remove bools.
10278
10279 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10280
10281         * mi/mi-cmds.h (mi_cmd_complete): New function.
10282         * mi/mi-main.c (mi_cmd_complete): Likewise.
10283         * mi/mi-cmds.c: Define new MI command -complete.
10284         * NEWS: Mention new -complete command.
10285
10286 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10287
10288         * completer.h (complete): New function.
10289         * completer.c (complete): Likewise.
10290         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10291         function defined in completer.h.
10292
10293 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10294
10295         * MAINTAINERS (Write After Approval): Add myself.
10296
10297 2019-05-17  Tom de Vries  <tdevries@suse.de>
10298
10299         PR gdb/24094
10300         * dwarf2read.c (struct cu_partial_die_info): New struct.
10301         (find_partial_die): Return cu_partial_die_info.
10302         (partial_die_parent_scope, guess_partial_die_structure_name)
10303         (partial_die_info::fixup): Handle new return type of find_partial_die.
10304
10305 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10306
10307         PR breakpoints/24541
10308         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10309         "std::string", simplifying the algorithm.
10310
10311 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10312
10313         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10314         (stap_static_probe_ops::get_probes): Likewise.
10315
10316 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10317
10318         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10319         '-')" and "else if".
10320         (stap_parse_single_operand): Join checks for
10321         "gdbarch_stap_parse_special_token_p" and
10322         "gdbarch_stap_parse_special_token" in the same "if" statement.
10323         Invert check when verifying for operation on register
10324         displacement.
10325
10326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10327
10328         * stap-probe.c (stap_get_opcode): Update comment.
10329         (stap_get_expected_argument_type): Likewise.
10330         (handle_stap_probe): Likewise.
10331
10332 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10333
10334         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10335         return type to 'bool'.  Adjust comment.  Use 'bool' when
10336         appropriate.
10337         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10338         * stap-probe.c (stap_parse_argument_1): Likewise.
10339         (stap_is_operator): Likewise.
10340         (stap_is_generic_prefix): Likewise.
10341         (stap_is_register_prefix): Likewise.
10342         (stap_is_register_indirection_prefix): Likewise.
10343         (stap_is_integer_prefix): Likewise.
10344         (stap_generic_check_suffix): Likewise.
10345         (stap_check_integer_suffix): Likewise.
10346         (stap_check_register_suffix): Likewise.
10347         (stap_check_register_indirection_suffix): Likewise.
10348         (stap_parse_register_operand): Likewise.
10349         (stap_parse_single_operand): Likewise.
10350         (stap_parse_argument_1): Likewise.
10351         (stap_probe::get_argument_count): Likewise.
10352         (stap_is_operator): Likewise.
10353
10354 2019-05-16  Tom Tromey  <tromey@adacore.com>
10355
10356         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10357         keyword to foreach.
10358
10359 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10360
10361         * linux-thread-db.c (try_thread_db_load_1): Change return type
10362         to bool.
10363         (try_thread_db_load): Likewise.
10364         (try_thread_db_load_from_pdir_1): Likewise.
10365         (try_thread_db_load_from_pdir): Likewise.
10366         (try_thread_db_load_from_sdir): Likewise.
10367         (try_thread_db_load_from_dir): Likewise.
10368         (thread_db_load_search): Likewise.
10369         (has_libpthread): Likewise.
10370         (thread_db_load): Likewise.
10371
10372 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10373
10374         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10375         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10376         NULL, and complain/return if that's the case.
10377
10378 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10379
10380         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10381         (advance, posn, abstract_read_memory): New functions.
10382         [struct mem_read_abstraction]: New struct.
10383         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10384
10385 2019-05-14  Tom Tromey  <tromey@adacore.com>
10386
10387         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10388         value is not lval_memory.
10389
10390 2019-05-14  Tom Tromey  <tromey@adacore.com>
10391
10392         * solib.c (info_sharedlibrary_command): Style the file name.
10393
10394 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10395
10396         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10397         (aarch64_vnv_type): Likewise.
10398         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10399         * common/tdesc.c: Likewise.
10400         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10401         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10402         * features/aarch64-fpu.xml: Add ieee half view.
10403         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10404         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10405         * gdbtypes.h (struct builtin_type): Likewise.
10406         (struct objfile_type): Likewise.
10407
10408 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10409
10410         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10411         typo.
10412         * location.h (string_to_event_location): Likewise.
10413
10414 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10415
10416         GDB 8.3 released.
10417
10418 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10419
10420         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10421         New variable declaration.
10422         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10423         New variable.
10424         (print_one_breakpoint): Use ui_out::test_flags and new global
10425         variable to compute use_fixed_output.
10426         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10427         Remove.
10428         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10429         (mi_multi_location_breakpoint_output_fixed): Remove.
10430         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10431         new variable.
10432         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10433         fix_multi_location_breakpoint_output flag if version >= 3.
10434         * ui-out.h (enum ui_out_flag)
10435         <fix_multi_location_breakpoint_output>: New enumerator.
10436
10437 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10438
10439         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10440
10441 2019-05-10  Tom Tromey  <tromey@adacore.com>
10442
10443         * ada-lang.c (catch_ada_completer): New function.
10444         (_initialize_ada_language): Use it.
10445
10446 2019-05-10  Tom Tromey  <tromey@adacore.com>
10447
10448         * thread.c (print_thread_info): Make "requested_threads" const.
10449         * gdbthread.h (print_thread_info): Make "requested_threads"
10450         const.
10451         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10452         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10453
10454 2019-05-08  Tom Tromey  <tom@tromey.com>
10455
10456         * gdbtypes.c (objfile_type_data): Change type.
10457         (objfile_type, _initialize_gdbtypes): Update.
10458
10459 2019-05-08  Tom Tromey  <tom@tromey.com>
10460
10461         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10462         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10463         (_initialize_dwarf2_frame): Update.
10464
10465 2019-05-08  Tom Tromey  <tom@tromey.com>
10466
10467         * objc-lang.c (objc_objfile_data): Change type.
10468         (find_methods): Update.
10469         (_initialize_objc_lang): Remove.
10470
10471 2019-05-08  Tom Tromey  <tom@tromey.com>
10472
10473         * stabsread.c (rs6000_builtin_type_data): Change type.
10474         (rs6000_builtin_type, _initialize_stabsread): Update.
10475
10476 2019-05-08  Tom Tromey  <tom@tromey.com>
10477
10478         * mips-tdep.c (mips_pdr_data): Remove.
10479         (_initialize_mips_tdep): Update.
10480
10481 2019-05-08  Tom Tromey  <tom@tromey.com>
10482
10483         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10484         (hppa_init_objfile_priv_data, read_unwind_info)
10485         (find_unwind_entry, _initialize_hppa_tdep): Update.
10486
10487 2019-05-08  Tom Tromey  <tom@tromey.com>
10488
10489         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10490         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10491         on obstack.
10492         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10493
10494 2019-05-08  Tom Tromey  <tom@tromey.com>
10495
10496         * mdebugread.c (basic_type_data): Change type.
10497         (basic_type, _initialize_mdebugread): Update.
10498
10499 2019-05-08  Tom Tromey  <tom@tromey.com>
10500
10501         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10502
10503 2019-05-08  Tom Tromey  <tom@tromey.com>
10504
10505         * nto-tdep.c (nto_inferior_data_reg): Change type.
10506         (nto_inferior_data): Update.
10507         (nto_inferior_data_cleanup, nto_new_inferior_data)
10508         (_initialize_nto_tdep): Remove.
10509         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10510
10511 2019-05-08  Tom Tromey  <tom@tromey.com>
10512
10513         * ada-lang.c (struct ada_inferior_data): Add initializers.
10514         (ada_inferior_data): Change type.
10515         (ada_inferior_data_cleanup): Remove.
10516         (get_ada_inferior_data, ada_inferior_exit)
10517         (struct ada_pspace_data): Add initializers, destructor.
10518         (ada_pspace_data_handle): Change type.
10519         (get_ada_pspace_data): Update.
10520         (ada_pspace_data_cleanup): Remove.
10521
10522 2019-05-08  Tom Tromey  <tom@tromey.com>
10523
10524         * coffread.c (struct coff_symfile_info): Add initializers.
10525         (coff_objfile_data_key): Move lower.  Change type.
10526         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10527         Update.
10528         (coff_free_info): Remove.
10529
10530 2019-05-08  Tom Tromey  <tom@tromey.com>
10531
10532         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10533         (fbsd_pspace_data_handle): Move lower.  Change type.
10534         (get_fbsd_pspace_data): Update.
10535         (fbsd_pspace_data_cleanup): Remove.
10536         (_initialize_fbsd_tdep): Update.
10537
10538 2019-05-08  Tom Tromey  <tom@tromey.com>
10539
10540         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10541         (get_ada_tasks_pspace_data): Update.
10542         (ada_tasks_pspace_data_cleanup): Remove.
10543         (_initialize_tasks): Update.
10544         (ada_tasks_inferior_data_handle): Change type.
10545         (get_ada_tasks_inferior_data): Update.
10546         (ada_tasks_inferior_data_cleanup): Remove.
10547         (struct ada_tasks_pspace_data): Add initializers.
10548
10549 2019-05-08  Tom Tromey  <tom@tromey.com>
10550
10551         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10552         * symfile-debug.c (debug_sym_get_probes): Change type.
10553         * stap-probe.c (handle_stap_probe):
10554         (stap_static_probe_ops::get_probes): Change type.
10555         * probe.h (class static_probe_ops) <get_probes>: Change type.
10556         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10557         (parse_probes_in_pspace): Update.
10558         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10559         Update.
10560         (any_static_probe_ops::get_probes): Change type.
10561         * elfread.c (elfread_data): New typedef.
10562         (probe_key): Change type.
10563         (elf_get_probes): Likewise.  Update.
10564         (probe_key_free): Remove.
10565         (_initialize_elfread): Update.
10566         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10567         Change type.
10568         (dtrace_process_dof_probe, dtrace_process_dof)
10569         (dtrace_static_probe_ops::get_probe): Change type.
10570
10571 2019-05-08  Tom Tromey  <tom@tromey.com>
10572
10573         * xcoffread.c (struct xcoff_symfile_info): Rename from
10574         coff_symfile_info.  Add initializers.
10575         (xcoff_objfile_data_key): Move lower.  Change type.
10576         (XCOFF_DATA): Rewrite.
10577         (xcoff_free_info): Remove.
10578         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10579         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10580         (xcoff_initial_scan): Update.
10581
10582 2019-05-08  Tom Tromey  <tom@tromey.com>
10583
10584         * solib-svr4.c (struct svr4_info): Add initializers and
10585         destructor.
10586         <probes_table>: Now an htab_up.
10587         (solib_svr4_pspace_data): Change type.
10588         (free_probes_table): Simplify.
10589         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10590         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10591         (probes_table_remove_objfile_probes, register_solib_event_probe)
10592         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10593         (_initialize_svr4_solib): Update.
10594
10595 2019-05-08  Tom Tromey  <tom@tromey.com>
10596
10597         * remote.c (remote_pspace_data): Change type.
10598         (remote_pspace_data_cleanup): Remove.
10599         (get_remote_exec_file, set_pspace_remote_exec_file)
10600         (_initialize_remote): Update.
10601
10602 2019-05-08  Tom Tromey  <tom@tromey.com>
10603
10604         * breakpoint.c (breakpoint_objfile_key): Change type.
10605         (get_breakpoint_objfile_data): Update.
10606         (free_breakpoint_objfile_data): Remove.
10607         (_initialize_breakpoint): Update.
10608
10609 2019-05-08  Tom Tromey  <tom@tromey.com>
10610
10611         * linux-tdep.c (struct linux_info): Add initializers.
10612         (linux_inferior_data): Move.  Change type.
10613         (invalidate_linux_cache_inf): Update.
10614         (linux_inferior_data_cleanup): Remove.
10615         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10616
10617 2019-05-08  Tom Tromey  <tom@tromey.com>
10618
10619         * auxv.c (auxv_inferior_data): Move.  Change type.
10620         (auxv_inferior_data_cleanup): Remove.
10621         (invalidate_auxv_cache_inf): Rewrite.
10622         (get_auxv_inferior_data, _initialize_auxv): Update.
10623
10624 2019-05-08  Tom Tromey  <tom@tromey.com>
10625
10626         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10627         (symfile_debug_objfile_data_key): Change type.
10628         (symfile_debug_installed, debug_qf_has_symbols)
10629         (debug_qf_find_last_source_symtab)
10630         (debug_qf_forget_cached_source_info)
10631         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10632         (debug_qf_print_stats, debug_qf_dump)
10633         (debug_qf_expand_symtabs_for_function)
10634         (debug_qf_expand_all_symtabs)
10635         (debug_qf_expand_symtabs_with_fullname)
10636         (debug_qf_map_matching_symbols)
10637         (debug_qf_expand_symtabs_matching)
10638         (debug_qf_find_pc_sect_compunit_symtab)
10639         (debug_qf_map_symbol_filenames)
10640         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10641         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10642         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10643         (debug_sym_read_linetable, debug_sym_relocate): Update.
10644         (symfile_debug_free_objfile): Remove.
10645         (install_symfile_debug_logging, _initialize_symfile_debug):
10646         Update.
10647
10648 2019-05-08  Tom Tromey  <tom@tromey.com>
10649
10650         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10651         allocate_on_obstack.
10652         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10653         (get_dwarf2_per_objfile): Update.
10654         (set_dwarf2_per_objfile): Remove.
10655         (dwarf2_has_info, dwarf2_get_section_info): Update.
10656         (dwarf2_free_objfile): Remove.
10657         (_initialize_dwarf2_read): Update.
10658
10659 2019-05-08  Tom Tromey  <tom@tromey.com>
10660
10661         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10662         initializers.
10663         <unsupported_script_warning_printed,
10664         script_not_found_warning_printed>: Now bool.
10665         (auto_load_pspace_data): Change type.
10666         (~auto_load_pspace_info): Rename from
10667         auto_load_pspace_data_cleanup.
10668         (get_auto_load_pspace_data, init_loaded_scripts_info)
10669         (clear_section_scripts, maybe_print_unsupported_script_warning)
10670         (maybe_print_script_not_found_warning, _initialize_auto_load):
10671         Update.
10672
10673 2019-05-08  Tom Tromey  <tom@tromey.com>
10674
10675         * objfiles.c (objfile_pspace_info): Add destructor and
10676         initializers.
10677         (objfiles_pspace_data): Change type.
10678         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10679         (get_objfile_pspace_data): Update.
10680         (objfiles_bfd_data): Change type.
10681         (get_objfile_bfd_data): Update.
10682         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10683
10684 2019-05-08  Tom Tromey  <tom@tromey.com>
10685
10686         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10687         Change type.
10688         (get_catch_syscall_inferior_data): Update.
10689         (catch_syscall_inferior_data_cleanup): Remove.
10690         (_initialize_break_catch_syscall): Update.
10691
10692 2019-05-08  Tom Tromey  <tom@tromey.com>
10693
10694         * inflow.c (struct terminal_info): Add destructor and
10695         initializers.
10696         (inflow_inferior_data): Change type.
10697         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10698         (get_inflow_inferior_data, inflow_inferior_exit)
10699         (swap_terminal_info, _initialize_inflow): Update.
10700
10701 2019-05-08  Tom Tromey  <tom@tromey.com>
10702
10703         * target-dcache.c (target_dcache_cleanup): Remove.
10704         (target_dcache_aspace_key): Change type.
10705         (target_dcache_init_p, target_dcache_invalidate)
10706         (target_dcache_get, target_dcache_get_or_init)
10707         (_initialize_target_dcache): Update.
10708         * dcache.h (struct dcache_deleter): New.
10709
10710 2019-05-08  Tom Tromey  <tom@tromey.com>
10711
10712         * symtab.c (struct symbol_cache): Add destructor and
10713         initializers.
10714         (symbol_cache_key): Move.  Change type.
10715         (make_symbol_cache, free_symbol_cache): Remove.
10716         (get_symbol_cache): Update.
10717         (symbol_cache_cleanup): Remove.
10718         (ALL_PSPACES, symbol_cache_flush)
10719         (maintenance_print_symbol_cache)
10720         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10721         Update.
10722
10723 2019-05-08  Tom Tromey  <tom@tromey.com>
10724
10725         * symtab.c (struct main_info): Add destructor and initializers.
10726         (main_progspace_key): Move.  Change type.
10727         (get_main_info): Update.
10728         (main_info_cleanup): Remove.
10729         (_initialize_symtab): Update.
10730
10731 2019-05-08  Tom Tromey  <tom@tromey.com>
10732
10733         * registry.h (DECLARE_REGISTRY): Define the _key class.
10734
10735 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10736
10737         * NEWS: Merge two 'New commands' sections.
10738
10739 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10740
10741         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10742         parameter and use Ada language definition instead.
10743         (ada_val_print_ptr): Remove unused language parameter.
10744         (ada_val_print_num): Remove language parameter and use Ada language
10745         definition instead.
10746         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10747         parameter.
10748         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10749         parameter and use Ada language definition instead.
10750         (ada_val_print_1): Update all ada_val_print_xxx calls.
10751         Remove language parameter.
10752         (ada_val_print): Update ada_val_print_1 call.
10753
10754 2019-05-08  Tom Tromey  <tromey@adacore.com>
10755
10756         * remote.c (remote_hw_watchpoint_limit)
10757         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10758         Now static.
10759
10760 2019-05-08  Tom Tromey  <tromey@adacore.com>
10761
10762         * maint.c (_initialize_maint_cmds): Move initialization code to
10763         remote.c.
10764         (watchdog, show_watchdog): Move to remote.c.
10765         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10766         "watchdog" static.
10767         (_initialize_remote): Move initialization code from maint.c.
10768         * defs.h (watchdog): Don't declare.
10769
10770 2019-05-08  Tom Tromey  <tromey@adacore.com>
10771
10772         * tui/tui-interp.c: Include main.h.
10773         * interps.c: Include main.h.
10774         * main.h (interpreter_p): Declare.
10775         * defs.h (interpreter_p): Don't declare.
10776
10777 2019-05-08  Tom Tromey  <tromey@adacore.com>
10778
10779         * dwarf2loc.c: Include dwarf2read.h.
10780         * defs.h (read_unsigned_leb128): Don't declare.
10781         * dwarf2read.h (read_unsigned_leb128): Declare.
10782
10783 2019-05-08  Tom Tromey  <tromey@adacore.com>
10784
10785         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10786         method.
10787
10788 2019-05-08  Tom Tromey  <tromey@adacore.com>
10789
10790         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10791         when no wrap column is set.
10792
10793 2019-05-08  Tom Tromey  <tromey@adacore.com>
10794
10795         * c-lang.c (c_get_string): Handle non-C-style arrays.
10796
10797 2019-05-08  Tom Tromey  <tromey@adacore.com>
10798
10799         * typeprint.c (print_offset_data::update): Print the bit offset,
10800         not the number of bits remaining.
10801
10802 2019-05-08  Tom Tromey  <tromey@adacore.com>
10803
10804         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10805         padding at end of comment.
10806
10807 2019-05-08  Tom Tromey  <tromey@adacore.com>
10808
10809         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10810         Compare main types.
10811
10812 2019-05-06  Tom Tromey  <tom@tromey.com>
10813
10814         * common/scoped_mmap.c: Include common-defs.h.
10815         * common/scoped_mmap.h: Don't include config.h.
10816
10817 2019-05-04  Tom Tromey  <tom@tromey.com>
10818
10819         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10820         (struct aarch64_call_info): Add initializers.
10821         <si>: Now a std::vector.
10822         (pass_on_stack, aarch64_push_dummy_call): Update.
10823
10824 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10825             Tom Tromey  <tom@tromey.com>
10826
10827         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10828         (ppc_threads): Now a std::vector.  Now static.
10829         (hwdebug_find_thread_points_by_tid)
10830         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10831         Update.
10832
10833 2019-05-04  Tom Tromey  <tom@tromey.com>
10834
10835         * arc-tdep.c (arc_tdesc_init): Return bool.
10836
10837 2019-05-04  Tom Tromey  <tom@tromey.com>
10838
10839         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10840         Use gdb_assert_not_reached.
10841
10842 2019-05-04  Tom Tromey  <tom@tromey.com>
10843
10844         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10845         "false".
10846
10847 2019-05-04  Tom Tromey  <tom@tromey.com>
10848
10849         * arc-tdep.c (arc_tdesc_init): Use bool.
10850
10851 2019-05-04  Tom Tromey  <tom@tromey.com>
10852
10853         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10854
10855 2019-05-04  Tom Tromey  <tom@tromey.com>
10856
10857         * cli/cli-cmds.c (valid_command_p): Return bool.
10858
10859 2019-05-04  Tom Tromey  <tom@tromey.com>
10860
10861         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10862         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10863
10864 2019-05-04  Raul Tambre  <raul@tambre.ee>
10865
10866         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10867         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10868         operator for comparison.
10869
10870 2019-05-04  Tom Tromey  <tom@tromey.com>
10871
10872         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10873         (lookup_partial_symbol, print_partial_symbols)
10874         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10875         (psymbol_compare): Update.
10876         (add_psymbol_to_bcache): Clear the entire psymbol.
10877         (maintenance_check_psymtabs): Update.
10878         * psympriv.h (struct partial_symbol): Don't derive from
10879         general_symbol_info.
10880         <obj_section, unrelocated_address, address,
10881         set_unrelocated_address>: Update.
10882         <ginfo>: New member.
10883         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10884         (debug_names::write_psymbols): Update.
10885
10886 2019-05-04  Tom de Vries  <tdevries@suse.de>
10887
10888         * contrib/cc-with-tweaks.sh: Support -n arg.
10889
10890 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10891
10892         * corelow.c (core_target::detach): Ensure frame cache and
10893         register caches are cleared.
10894         inferior.c (exit_inferior_1): Likewise.
10895
10896 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10897             Tom Tromey  <tom@tromey.com>
10898
10899         * dictionary.c (collate_pending_symbols_by_language): Remove
10900         "struct" from foreach.
10901         * symtab.c (lookup_global_symbol_from_objfile)
10902         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10903         foreach.
10904         * ser-tcp.c (net_open): Remove "struct" from foreach.
10905         * objfiles.c (objfile_relocate, objfile_rebase)
10906         (objfile_has_symbols): Remove "struct" from foreach.
10907         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10908         from foreach.
10909         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10910         foreach.
10911         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10912         "struct" from foreach.
10913         * ada-lang.c (create_excep_cond_exprs)
10914         (ada_exception_catchpoint_cond_string): Remove "struct" from
10915         foreach.
10916
10917 2019-05-03  Tom Tromey  <tromey@adacore.com>
10918
10919         * ada-exp.y (convert_char_literal): Check suffix of each
10920         enumerator.
10921
10922 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10923
10924         PR ada/21406:
10925         * ada-exp.y (yywrap): Don't define.
10926         * ada-lex.l (%option): Add noyywrap
10927         (yywrap): Remove.
10928
10929 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10930
10931         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10932         _WIN32_WINNT to the XP level, unless already defined to a higher
10933         level.
10934
10935         * unittests/parse-connection-spec-selftests.c:
10936         * ser-tcp.c:
10937         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10938         override.
10939
10940         * symfile.c (find_separate_debug_file): Remove colon from the
10941         drive spec of DOS/Windows file names of the target, so that the
10942         file name produced from DEBUGDIR and the target's directory will
10943         be valid on DOS/Windows systems.
10944
10945 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10946
10947         * rust-lang.c (val_print_struct): Handle printing structures
10948         containing strings.
10949
10950 2019-05-02  Tom Tromey  <tromey@adacore.com>
10951
10952         * valarith.c (_initialize_valarith): Remove.
10953
10954 2019-05-01  Tom Tromey  <tromey@adacore.com>
10955
10956         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10957         bitfields.
10958
10959 2019-05-01  Tom Tromey  <tromey@adacore.com>
10960
10961         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10962         for big-endian copies.
10963
10964 2019-04-30  Ali Tamur  <tamur@google.com>
10965         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10966         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10967         (read_3_bytes): New function.
10968
10969 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10970
10971         * windows-nat.c (main_thread_id): Delete.
10972         (handle_output_debug_string): Replace main_thread_id by
10973         current_event.dwThreadId.
10974         (fake_create_process): Likewise.
10975         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10976         Do not set main_thread_id.
10977         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10978         current_event.dwThreadId.
10979         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10980
10981 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10982
10983         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10984         Use current_event.dwThreadId instead of main_thread_id.
10985
10986 2019-04-30  Tom Tromey  <tromey@adacore.com>
10987
10988         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10989         (create_excep_cond_exprs): Iterate over program spaces.
10990         (ada_exception_catchpoint_cond_string): Examine all minimal
10991         symbols for exception types.
10992
10993 2019-04-30  Tom Tromey  <tromey@adacore.com>
10994
10995         PR c++/24470:
10996         * dwarf2read.c (process_structure_scope): Handle case where type
10997         has template parameters but no symbol was created.
10998
10999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11000             Chris January  <chris.january@arm.com>
11001
11002         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11003         qualifier.
11004         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11005
11006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11007
11008         * f-typeprint.c (f_print_type): Update rules for printing
11009         whitespace.
11010         (f_type_print_varspec_suffix): Likewise.
11011
11012 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11013             Chris January  <chris.january@arm.com>
11014
11015         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11016         function arguments.
11017
11018 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11019
11020         * f-lang.c (build_fortran_types): Change name of void type to
11021         lower case.
11022         * f-typeprint.c (f_type_print_base): Print the name of the void
11023         type, rather than a fixed string.
11024         * f-valprint.c (f_decorations): Use lower case void string.
11025
11026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11027             Chris January  <chris.january@arm.com>
11028
11029         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11030         types for Fortran.
11031
11032 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11033             Chris January  <chris.january@arm.com>
11034             David Lecomber  <david.lecomber@arm.com>
11035
11036         * f-exp.y (BINOP_INTRINSIC): New token.
11037         (exp): New parser rule handling BINOP_INTRINSIC.
11038         (f77_keywords): Add new builtin procedures.
11039         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11040         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11041         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11042         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11043         (print_unop_subexp_f): New function.
11044         (print_binop_subexp_f): New function.
11045         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11046         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11047         (dump_subexp_body_f): Likewise.
11048         (operator_check_f): Likewise.
11049         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11050         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11051
11052 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11053
11054         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11055         UNOP_KIND.
11056         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11057         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11058         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11059         (operator_length_f): New fuction.
11060         (print_subexp_f): New function.
11061         (op_name_f): New function.
11062         (dump_subexp_body_f): New function.
11063         (operator_check_f): New function.
11064         (exp_descriptor_f): Replace standard expression handling functions
11065         with new functions.
11066         * gdb/fortran-operator.def: New file.
11067         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11068         * gdb/std-operator.def: Remove UNOP_KIND.
11069
11070 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11071
11072         * std-operator.def: Remove unbalanced, stray double quote
11073         character.
11074
11075 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11076             Chris January  <chris.january@arm.com>
11077             Daniel Everett  <daniel.everett@arm.com>
11078             Nick Forrington  <nick.forrington@arm.com>
11079             Richard Bunt  <richard.bunt@arm.com>
11080
11081         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11082         of depth when printing anonymous structs or unions.
11083         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11084         Don't print either the top-level value, or the children if the
11085         max-depth is exceeded.
11086         (ppscm_print_children): When printing the key of a map, allow one
11087         extra level of depth.
11088         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11089         print either the top-level value, or the children if the max-depth
11090         is exceeded.
11091         (print_children): When printing the key of a map, allow one extra
11092         level of depth.
11093         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11094         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11095         (user_print_options): Initialise max_depth field.
11096         (val_print_scalar_or_string_type_p): New function.
11097         (val_print): Check to see if the max depth has been reached.
11098         (val_print_check_max_depth): Define new function.
11099         (show_print_max_depth): New function.
11100         (_initialize_valprint): Add 'print max-depth' option.
11101         * valprint.h (struct value_print_options) <max_depth>: New field.
11102         (val_print_check_max_depth): Declare new function.
11103         * NEWS: Document new feature.
11104
11105 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11106
11107         * ada-lang.c (ada_language_defn): Initialise new field.
11108         * c-lang.c (c_is_string_type_p): New function.
11109         (c_language_defn): Initialise new field.
11110         (cplus_language_defn): Initialise new field.
11111         (asm_language_defn): Initialise new field.
11112         (minimal_language_defn): Initialise new field.
11113         * c-lang.h (c_is_string_type_p): Declare new function.
11114         * d-lang.c (d_language_defn): Initialise new field.
11115         * f-lang.c (f_is_string_type_p): New function.
11116         (f_language_defn): Initialise new field.
11117         * go-lang.c (go_is_string_type_p): New function.
11118         (go_language_defn): Initialise new field.
11119         * language.c (default_is_string_type_p): New function.
11120         (unknown_language_defn): Initialise new field.
11121         (auto_language_defn): Initialise new field.
11122         * language.h (struct language_defn) <la_is_string_type_p>: New
11123         member variable.
11124         (default_is_string_type_p): Declare new function.
11125         * m2-lang.c (m2_language_defn): Initialise new field.
11126         * objc-lang.c (objc_language_defn): Initialise new field.
11127         * opencl-lang.c (opencl_language_defn): Initialise new field.
11128         * p-lang.c (pascal_is_string_type_p): New function.
11129         (pascal_language_defn): Initialise new field.
11130         * rust-lang.c (rust_is_string_type_p): New function.
11131         (rust_language_defn): Initialise new field.
11132
11133 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11134
11135         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11136         New field.
11137         * ada-lang.c (ada_language_defn): Initialise new field.
11138         * c-lang.c (c_language_defn): Likewise.
11139         (cplus_language_defn): Likewise.
11140         (asm_language_defn): Likewise.
11141         (minimal_language_defn): Likewise.
11142         * d-lang.c (d_language_defn): Likewise.
11143         * f-lang.c (f_language_defn): Likewise.
11144         * go-lang.c (go_language_defn): Likewise.
11145         * language.c (unknown_language_defn): Likewise.
11146         (auto_language_defn): Likewise.
11147         * m2-lang.c (m2_language_defn): Likewise.
11148         * objc-lang.c (objc_language_defn): Likewise.
11149         * opencl-lang.c (opencl_language_defn): Likewise.
11150         * p-lang.c (pascal_language_defn): Likewise.
11151         * rust-lang.c (rust_language_defn): Likewise.
11152
11153 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11154
11155         * ada-lang.c (ada_is_character_type): Change return type to bool.
11156         (ada_is_string_type): Likewise.
11157         * ada-lang.h (ada_is_character_type): Update declaration
11158         (ada_is_string_type): Likewise.
11159
11160 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11161
11162         Support style in 'frame|thread apply'
11163
11164         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11165         * record.c (record_start, record_stop): Update callers of
11166         execute_command_to_string with false.
11167         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11168         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11169         methods.
11170         (class string_file): New constructor with term_out parameter.
11171         Override methods term_out and can_emit_style_escape.  New member
11172         term_out.
11173         (class stdio_file): Override can_emit_style_escape.
11174         (class tee_file): Override term_out and can_emit_style_escape.
11175         * utils.h (can_emit_style_escape): Remove.
11176         * utils.c (can_emit_style_escape): Likewise.
11177         Update all callers of can_emit_style_escape (SOMESTREAM) to
11178         SOMESTREAM->can_emit_style_escape.
11179         * source-cache.c (source_cache::get_source_lines): Likewise.
11180         * stack.c (frame_apply_command_count): Call execute_command_to_string
11181         passing the term_out characteristic of the current gdb_stdout.
11182         * thread.c (thr_try_catch_cmd): Likewise.
11183         * top.c (execute_command_to_string): pass term_out parameter
11184         to construct the string_file for the command output.
11185         * ui-file.c (term_cli_styling): New function (most code moved
11186         from utils.c can_emit_style_escape).
11187         (string_file::string_file, string_file::can_emit_style_escape,
11188         stdio_file::can_emit_style_escape, tee_file::term_out,
11189         tee_file::can_emit_style_escape): New functions.
11190
11191 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11192
11193         * NEWS: Mention the new set|show may-call-functions.
11194         * infcall.c (may_call_functions_p): New variable.
11195         (show_may_call_functions_p): New function.
11196         (call_function_by_hand_dummy): Throws an error if not
11197         may-call-functions.
11198         (_initialize_infcall): Call add_setshow_boolean_cmd for
11199         may-call-functions.
11200
11201 2019-04-25  Keith Seitz  <keiths@redhat.com>
11202
11203         PR c++/24367
11204         * cp-support.c (inspect_type): Don't attempt substitutions
11205         of symbol with the same name.
11206
11207 2019-04-25  Tom Tromey  <tromey@adacore.com>
11208
11209         PR gdb/24475:
11210         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11211         static.
11212
11213 2019-04-25  Tom Tromey  <tromey@adacore.com>
11214
11215         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11216         rvalue reference.
11217         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11218         (gdb_xml_parser::parse): Use std::move.
11219         * python/python-internal.h (gdbpy_convert_exception): Take a const
11220         reference.
11221         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11222         std::move.
11223         * python/py-utils.c (gdbpy_convert_exception): Take a const
11224         reference.
11225         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11226         Use std::move.
11227         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11228         Use std::move.
11229         * mi/mi-main.c (mi_print_exception): Take a const reference.
11230         * main.c (handle_command_errors): Take a const reference.
11231         * linespec.c (parse_linespec): Use std::move.
11232         * infcall.c (run_inferior_call): Use std::move.
11233         (call_function_by_hand_dummy): Use std::move.
11234         * exec.c (try_open_exec_file): Use std::move.
11235         * exceptions.h (exception_print, exception_fprintf)
11236         (exception_print_same): Update.
11237         * exceptions.c (print_exception, exception_print)
11238         (exception_fprintf, exception_print_same): Change parameters to
11239         const reference.
11240         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11241         * common/new-op.c: Use std::move.
11242         * common/common-exceptions.h (struct gdb_exception): Add move
11243         constructor.
11244         (struct gdb_exception_error, struct gdb_exception_quit, struct
11245         gdb_quit_bad_alloc): Change constructor to move constructor.
11246         (throw_exception): Change parameter to rvalue reference.
11247         * common/common-exceptions.c (throw_exception): Take rvalue
11248         reference.
11249         * cli/cli-interp.c (safe_execute_command): Use std::move.
11250         * breakpoint.c (insert_bp_location, location_to_sals): Use
11251         std::move.
11252
11253 2019-04-25  Tom Tromey  <tromey@adacore.com>
11254
11255         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11256         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11257         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11258         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11259         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11260         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11261         guile/scm-value.c: Use unpack.
11262         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11263         gdbscm_gdb_exception.
11264         (gdbscm_throw_gdb_exception): Likewise.
11265         (struct gdbscm_gdb_exception): New.
11266         (unpack): New function.
11267         (gdbscm_wrap): Use unpack.
11268
11269 2019-04-25  Tom Tromey  <tromey@adacore.com>
11270
11271         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11272         (gdb_rl_callback_handler): Use std::move.
11273         * common/common-exceptions.h (struct gdb_exception): Add move
11274         assignment operator.
11275         (throw_exception_sjlj): Change "exception" to const reference.
11276         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11277         (throw_exception_sjlj): Change "exception" to const reference.
11278
11279 2019-04-25  Tom Tromey  <tromey@adacore.com>
11280
11281         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11282         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11283         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11284         Update.
11285         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11286         Update.
11287         * mi/mi-interp.c (mi_interp::exec): Update.
11288         * linespec.c (parse_linespec): Update.
11289         * infcall.c (run_inferior_call): Update.
11290         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11291         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11292         (gdbscm_lookup_global_symbol): Update.
11293         * guile/scm-param.c (gdbscm_parameter_value): Update.
11294         * guile/scm-frame.c (gdbscm_frame_read_register)
11295         (gdbscm_frame_read_var): Update.
11296         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11297         * exec.c (try_open_exec_file): Update.
11298         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11299         (gdb_rl_callback_handler): Update.
11300         * common/common-exceptions.h (exception_none): Don't declare.
11301         * common/common-exceptions.c (exception_none): Don't define.
11302         (struct catcher) <exception>: Update.
11303         * cli/cli-interp.c (safe_execute_command): Update.
11304         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11305
11306 2019-04-25  Ali Tamur  <tamur@google.com>
11307
11308         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11309         (read_attribute_value): Likewise.
11310         (dwarf2_read_addr_index): Update comment.
11311         (read_str_index): Add DW_FORM_strx.
11312         (dwarf2_string_attr): Likewise.
11313         (dwarf2_const_value_attr): Likewise.
11314         (dump_die_shallow): Likewise.
11315         (dwarf2_fetch_constant_bytes): Likewise.
11316         (skip_form_bytes): Likewise.
11317         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11318
11319 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11320
11321         PR corefiles/11608
11322         PR corefiles/18187
11323         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11324         OFFSET.  Verify if current mapping contains an ELF header.
11325         (linux_find_memory_regions_full): Adjust call to
11326         dump_mapping_p.
11327
11328 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11329             Kang Li <kanglictf@gmail.com>
11330
11331         PR gdb/21600
11332
11333         * dwarf2-frame.c (read_initial_length): Be consistent about using
11334         unsigned representation of length.
11335         (decode_frame_entry_1): Likewise.  Check for wraparound of
11336         end pointer as well as buffer overflow.
11337
11338 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11339
11340         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11341         "vq".
11342
11343 2019-04-24  Tom Tromey  <tromey@adacore.com>
11344
11345         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11346
11347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * s12z-tdep.c (s12z_unwind_pc): Delete.
11350         (s12z_unwind_sp): Delete.
11351         (s12z_gdbarch_init): Don't register deleted functions with
11352         gdbarch.
11353
11354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * rl78-tdep.c (rl78_unwind_sp): Delete.
11357         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11358
11359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11360
11361         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11362         (xstormy16_unwind_pc): Delete.
11363         (xstormy16_dummy_id): Delete.
11364         (xstormy16_gdbarch_init): Don't register deleted functions with
11365         gdbarch.
11366
11367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11368
11369         * vax-tdep.c (vax_unwind_pc): Delete.
11370         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11371
11372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11373
11374         * v850-tdep.c (v850_unwind_sp): Delete.
11375         (v850_unwind_pc): Delete.
11376         (v850_dummy_id): Delete.
11377         (v850_gdbarch_init): Don't register deleted functions with
11378         gdbarch.
11379
11380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11381
11382         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11383         (tilegx_unwind_pc): Delete.
11384         (tilegx_unwind_dummy_id): Delete.
11385         (tilegx_gdbarch_init): Don't register deleted functions with
11386         gdbarch.
11387
11388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11389
11390         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11391         (tic6x_dummy_id): Delete.
11392         (tic6x_gdbarch_init): Don't register deleted functions with
11393         gdbarch.
11394
11395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11396
11397         * sparc-tdep.c (sparc_unwind_pc): Delete.
11398         (sparc32_gdbarch_init): Don't register deleted function with
11399         gdbarch.
11400
11401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11402
11403         * sh-tdep.c (sh_unwind_sp): Delete.
11404         (sh_unwind_pc): Delete.
11405         (sh_dummy_id): Delete.
11406         (sh_gdbarch_init): Don't register deleted functions with
11407         gdbarch.
11408
11409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11410
11411         * score-tdep.c (score_unwind_sp): Delete.
11412         (score_unwind_pc): Delete.
11413         (score_dummy_id): Delete.
11414         (score_gdbarch_init): Don't register deleted functions with
11415         gdbarch.
11416
11417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11418
11419         * rx-tdep.c (rx_unwind_pc): Delete.
11420         (rx_unwind_sp): Delete.
11421         (rx_dummy_id): Delete.
11422         (rx_gdbarch_init): Don't register deleted functions with
11423         gdbarch.  Update comment.
11424
11425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11426
11427         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11428         (rs6000_dummy_id): Delete.
11429         (rs6000_gdbarch_init): Don't register deleted functions with
11430         gdbarch.
11431
11432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * or1k-tdep.c (or1k_dummy_id): Delete.
11435         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11436
11437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * nios2-tdep.c (nios2_dummy_id): Delete.
11440         (nios2_unwind_sp): Delete.
11441         (nios2_gdbarch_init): Don't register deleted functions with
11442         gdbarch.
11443
11444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11445
11446         * nds32-tdep.c (nds32_dummy_id): Delete.
11447         (nds32_unwind_pc): Delete.
11448         (nds32_unwind_sp): Delete.
11449         (nds32_gdbarch_init): Don't register deleted functions with
11450         gdbarch.
11451
11452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * msp430-tdep.c (msp430_unwind_pc): Delete.
11455         (msp430_unwind_sp): Delete.
11456         (msp430_dummy_id): Delete.
11457         (msp430_gdbarch_init): Don't register deleted functions with
11458         gdbarch.
11459
11460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11461
11462         * moxie-tdep.c (moxie_unwind_sp): Delete.
11463         (moxie_unwind_pc): Delete.
11464         (moxie_dummy_id): Delete.
11465         (moxie_gdbarch_init): Don't register deleted functions with
11466         gdbarch.
11467
11468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11471         (mn10300_unwind_pc): Delete.
11472         (mn10300_unwind_sp): Delete.
11473         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11474         mn10300_unwind_sp.
11475         (mn10300_frame_unwind_init): Don't register deleted functions with
11476         gdbarch.
11477
11478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11479
11480         * mep-tdep.c (mep_unwind_pc): Delete.
11481         (mep_unwind_sp): Delete.
11482         (mep_dummy_id): Delete.
11483         (mep_gdbarch_init): Don't register deleted functions with
11484         gdbarch.
11485
11486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11487
11488         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11489         (m68hc11_unwind_sp): Delete.
11490         (m68hc11_gdbarch_init): Don't register deleted functions with
11491         gdbarch.
11492
11493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * m32r-tdep.c (m32r_unwind_sp): Delete.
11496         (m32r_unwind_pc): Delete.
11497         (m32r_dummy_id): Delete.
11498         (m32r_gdbarch_init): Don't register deleted functions with
11499         gdbarch.
11500
11501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11502
11503         * m32c-tdep.c (m32c_unwind_pc): Delete.
11504         (m32c_unwind_sp): Delete.
11505         (m32c_dummy_id): Delete.
11506         (m32c_gdbarch_init): Don't register deleted functions with
11507         gdbarch.
11508
11509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11510
11511         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11512         (lm32_unwind_pc): Delete.
11513         (lm32_dummy_id): Delete.
11514         (lm32_gdbarch_init): Don't register deleted functions with
11515         gdbarch.
11516
11517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11518
11519         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11520         (iq2000_unwind_pc): Delete.
11521         (iq2000_dummy_id): Delete.
11522         (iq2000_gdbarch_init): Don't register deleted functions with
11523         gdbarch.
11524
11525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11526
11527         * nds32-tdep.c (nds32_type_align): Delete.
11528         (nds32_push_dummy_call): Use type_align instead.
11529
11530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11531
11532         * arm-tdep.c (arm_type_align): Only handle vector override case.
11533         (arm_push_dummy_call): Use type_align.
11534         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11535
11536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11537
11538         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11539         case.
11540         (pass_on_stack): Use type_align.
11541         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11542         function.
11543
11544 2019-04-23  Tom Tromey  <tromey@adacore.com>
11545
11546         * dwarf2read.c (line_header::file_name_at): Remove unused
11547         overload.
11548
11549 2019-04-23  Tom de Vries  <tdevries@suse.de>
11550
11551         PR gdb/24438
11552         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11553         invocation.
11554
11555
11556 2019-03-27  Ali Tamur  <tamur@google.com>
11557
11558         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11559         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11560         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11561         (dwarf_expr_context::get_addr_index): Likewise
11562         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11563         (symbol_needs_eval_context::get_addr_index): Likewise
11564         (disassemble_dwarf_expression): Add DW_OP_addrx
11565         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11566         (read_cutu_die_from_dwo): Update comment
11567         (skip_one_die): Add DW_FORM_addrx
11568         (read_attribute_value): Likewise
11569         (var_decode_location): Add DW_OP_addrx
11570         (dwarf2_const_value_attr): Add DW_FORM_addrx
11571         (dump_die_shallow): Likewise
11572         (dwarf2_fetch_constant_bytes): Likewise
11573         (decode_locdesc): Add DW_OP_addrx
11574         (skip_form_bytes): Add DW_FORM_addrx
11575
11576 2019-04-22  Ali Tamur  <tamur@google.com>
11577
11578         * MAINTAINERS (Write After Approval): Add self.
11579
11580 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11581
11582         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11583         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11584         (open_symbol_file_object): Likewise.
11585         (svr4_default_sos): Add info parameter.
11586         (svr4_read_so_list): Likewise.
11587         (svr4_current_sos_direct): Adjust functions calls to pass down
11588         info.
11589         (svr4_current_sos_1): Add info parameter.
11590         (svr4_current_sos): Call get_svr4_info, pass info down to
11591         svr4_current_sos_1.
11592         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11593         get_svr4_info.
11594         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11595         get_svr4_info.
11596         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11597         to get_svr4_info.
11598         (probes_table_remove_objfile_probes): Likewise.
11599         (register_solib_event_probe): Add info parameter.
11600         (solist_update_incremental): Pass info parameter down to
11601         svr4_read_so_list.
11602         (disable_probes_interface): Add info parameter.
11603         (svr4_handle_solib_event): Pass current_program_space to
11604         get_svr4_info.  Adjust disable_probes_interface cleanup.
11605         (svr4_create_probe_breakpoints): Add info parameter, pass it
11606         down to register_solib_event_probe.
11607         (svr4_create_solib_event_breakpoints): Add info parameter,
11608         pass it down to svr4_create_probe_breakpoints.
11609         (enable_break): Pass info down to
11610         svr4_create_solib_event_breakpoints.
11611         (svr4_solib_create_inferior_hook): Pass current_program_space to
11612         get_svr4_info.
11613         (svr4_clear_solib): Likewise.
11614
11615 2019-04-22  Pedro Alves  <palves@redhat.com>
11616
11617         * solib-svr4.c (svr4_free_objfile_observer): New.
11618         (probe_and_action::objfile): New field.
11619         (probes_table_htab_remove_objfile_probes)
11620         (probes_table_remove_objfile_probes): New functions.
11621         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11622         in the new probe_and_action.  Don't store the probe in 'lookup'.
11623         (svr4_create_probe_breakpoints): Pass objfile to
11624         register_solib_event_probe.
11625         (_initialize_svr4_solib): Register a free_objfile observer.
11626
11627 2019-04-19  Tom Tromey  <tom@tromey.com>
11628
11629         * common/queue.h: Remove.
11630
11631 2019-04-19  Tom Tromey  <tom@tromey.com>
11632
11633         * event-loop.c: Don't include "common/queue.h".
11634
11635 2019-04-19  Tom Tromey  <tom@tromey.com>
11636
11637         * remote.c (remote_target): Use delete.
11638         * remote-notif.h: Include <list>, not "common/queue.h".
11639         (notif_client_p): Remove typedef.
11640         (remote_notif_state): Add constructor, destructor, initializer.
11641         <notif_queue>: Now a std::list.
11642         (remote_notif_state_xfree): Don't declare.
11643         * remote-notif.c (remote_notif_process, handle_notification)
11644         (remote_notif_state_allocate): Update.
11645         (~remote_notif_state): Rename from remote_notif_state_xfree.
11646
11647 2019-04-19  Tom Tromey  <tom@tromey.com>
11648
11649         * symfile.c (reread_symbols): Update.
11650         * objfiles.c (objfile_register_static_link)
11651         (objfile_lookup_static_link): Update
11652         (~objfile) Don't delete static_links.
11653         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11654
11655 2019-04-19  Tom Tromey  <tom@tromey.com>
11656
11657         * type-stack.h (struct type_stack) <insert>: Constify string.
11658         * type-stack.c (type_stack::insert): Constify string.
11659         * gdbtypes.h (lookup_template_type): Update.
11660         (address_space_name_to_int): Update.
11661         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11662         const.
11663         (lookup_template_type): Make name const.
11664         * c-exp.y: Update rules.
11665         (lex_one_token, classify_name, classify_inner_name)
11666         (c_print_token): Update.
11667         * p-exp.y: Update rules.
11668         (yylex): Update.
11669         * f-exp.y: Update rules.
11670         (yylex): Update.
11671         * d-exp.y: Update rules.
11672         (lex_one_token, classify_name, classify_inner_name): Update.
11673         * parse.c (write_dollar_variable, copy_name): Return std::string.
11674         * parser-defs.h (copy_name): Change return type.
11675         * m2-exp.y: Update rules.
11676         (yylex): Update.
11677         * go-exp.y (lex_one_token): Update.
11678         Update rules.
11679         (classify_unsafe_function, classify_packaged_name)
11680         (classify_name, yylex): Update.
11681
11682 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11683
11684         * configure.ac: add --enable-source-highlight switch.
11685         * configure: Regenerate.
11686         * top.c (print_gdb_version): plumb --enable-source-highlight
11687         status to "show configuration".
11688
11689 2019-04-19  Tom Tromey  <tromey@adacore.com>
11690
11691         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11692         Check ADA_TYPE_P.
11693         (empty_record, ada_template_to_fixed_record_type_1)
11694         (template_to_static_fixed_type)
11695         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11696         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11697         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11698         macros.
11699
11700 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11701
11702         PR symtab/24423:
11703         * source.c (print_source_lines_base): Advance "iter" when a
11704         control character is seen.
11705
11706 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11707
11708         * inferior.h (struct infcall_suspend_state_deleter):
11709         Catch exception in destructor to avoid crash.
11710
11711 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11712
11713         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11714         close to the add_com "shell".
11715
11716 2019-04-18  Tom Tromey  <tromey@adacore.com>
11717
11718         * process-stratum-target.h (class process_stratum_target)
11719         <stratum>: Add "final".
11720
11721 2019-04-17  Tom Tromey  <tromey@adacore.com>
11722
11723         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11724         against nullptr before use.
11725
11726 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11727
11728         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11729
11730 2019-04-17  Jim Wilson  <jimw@sifive.com>
11731             Andrew Burgess  <andrew.burgess@embecosm.com>
11732
11733         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11734         code read might fail, assume 4-byte breakpoint in that case.
11735
11736 2019-04-15  Leszek Swirski  <leszeks@google.com>
11737
11738         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11739         rather than a hand-rolled POD check when checking for forced MEMORY
11740         classification.
11741
11742 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11743
11744         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11745         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11746         function.
11747         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11748         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11749         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11750         declaration.
11751
11752 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11753
11754         * aarch64-linux-nat.c
11755         (aarch64_linux_nat_target::thread_architecture): Add override.
11756         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11757         each VQ.
11758
11759 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11760
11761         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11762
11763 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11764
11765         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11766         target types of size 96-bits, add some additional comments, and
11767         check that the builtin type we found was the correct size.
11768
11769 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11770
11771         * utils.c (prompt_for_continue): Don't restore the styling at the
11772         end, as applied_style has the wrong value.  This fixes styling in
11773         long lists of file names that are interrupted by the "Continue?"
11774         prompt.
11775
11776 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11777
11778         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11779         * c-lang.c (c_language_defn): Likewise.
11780         (cplus_language_defn): Likewise.
11781         (asm_language_defn): Likewise.
11782         (minimal_language_defn): Likewise.
11783         * d-lang.c (d_language_defn): Likewise.
11784         * f-lang.c (f_language_defn): Likewise.
11785         * go-lang.c (go_language_defn): Likewise.
11786         * language.c (unknown_language_defn): Likewise.
11787         (auto_language_defn): Likewise.
11788         * language.h (struct language_defn): Remove la_magic field.
11789         (LANG_MAGIC): Delete.
11790         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11791         * objc-lang.c (objc_language_defn): Likewise.
11792         * opencl-lang.c (opencl_language_defn): Likewise.
11793         * p-lang.c (pascal_language_defn): Likewise.
11794         * rust-lang.c (rust_language_defn): Likewise.
11795
11796 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * riscv-tdep.c (riscv_type_align): New function.
11799         (riscv_type_alignment): Delete.
11800         (riscv_arg_location): Use 'type_align'.
11801         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11802
11803 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11804
11805         * gdbtypes.c (type_align): A struct with no non-static fields also
11806         has alignment of 1.
11807
11808 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11809
11810         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11811         component to 0.
11812         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11813         member.
11814         (riscv_struct_info::analyse): New implementation using new
11815         analyse_inner member function.
11816         (riscv_struct_info::field_offset): New member function.
11817         (riscv_struct_info::m_offsets): New member variable.
11818         (riscv_struct_info::analyse_inner): New private member function,
11819         takes the old implementation of riscv_struct_info::analyse but
11820         extended to track field offsets.
11821         (riscv_call_arg_struct): Update the struct folding special cases
11822         to handle cases where empty C++ structs, which are non-zero
11823         length, are found.
11824         (riscv_arg_location): Initialise the length of each location, a
11825         non-zero length now indicates the location is in use.
11826         (riscv_push_dummy_call): Allow for the first location having a
11827         non-zero offset when setting up arguments.
11828         (riscv_return_value): Likewise, but for return values.
11829
11830 2019-04-11  Tom Tromey  <tromey@adacore.com>
11831
11832         * utils.c (internal_vproblem): Make "msg" const.
11833
11834 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11835
11836         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11837         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11838         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11839         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11840
11841 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11842
11843         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11844         function.
11845         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11846         of amd64_collect_native_gregset.
11847         (amd64_linux_nat_target::store_registers): Likewise.
11848
11849 2019-04-10  Tom Tromey  <tom@tromey.com>
11850
11851         * symtab.c (lookup_global_symbol_from_objfile)
11852         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11853         * objfiles.h (class separate_debug_iterator): New.
11854         (class separate_debug_range): New.
11855         (struct objfile) <separate_debug_objfiles>: New method.
11856         (objfile_separate_debug_iterate): Don't declare.
11857         * objfiles.c (separate_debug_iterator::operator++): Rename from
11858         objfile_separate_debug_iterate.
11859         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11860         iterator.
11861         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11862         iterator.
11863
11864 2019-04-10  Tom Tromey  <tom@tromey.com>
11865
11866         * symfile.c (reread_symbols): Remove old comment.
11867         * objfiles.c (free_all_objfiles): Fix a typo.
11868
11869 2019-04-10  Tom Tromey  <tom@tromey.com>
11870
11871         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11872         * minsyms.c (lookup_minimal_symbol): Use foreach.
11873         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11874         (lookup_minimal_symbol_solib_trampoline): Likewise.
11875         * symfile.c (reread_symbols): Use foreach.
11876
11877 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11878             Tom Tromey  <tromey@adacore.com>
11879
11880         PR rust/24414:
11881         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11882         (rust_lex_int_test): Change "value" to be LONGEST.
11883         (rust_lex_tests): Add test for long integer literal.
11884
11885 2019-04-09  Tom Tromey  <tromey@adacore.com>
11886
11887         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11888         to bool.
11889         (extended_remote_target::attach): Update.
11890         (remote_target::remote_notice_new_inferior): Update.
11891         (remote_target::add_current_inferior_and_thread): Update.
11892         * inferior.c (exit_inferior_1): Use "false".
11893         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11894
11895 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11896
11897         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11898         the "start" command.
11899
11900 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11901
11902         * python/py-inferior.c (infpy_thread_from_thread_handle):
11903         Adjust comments to reflect renaming of thread_from_thread_handle
11904         to thread_from_handle.  Adjust keywords.  Fix type error message.
11905         (inferior_object_methods): Add thread_from_handle.  Retain
11906         thread_from_thread_handle, but mark it as deprecated.
11907
11908 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11909
11910         * gdbthread.h (find_thread_by_handle): Revise declaration.
11911         * thread.c (find_thread_by_handle): Likewise.  Adjust
11912         implementation too.
11913         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11914         support for buffer objects as handles.
11915
11916 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11917
11918         * python/py-infthread.c (thpy_thread_handle): New function.
11919         (thread_object_methods): Register thpy_thread_handle.
11920
11921 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11922
11923         * gdbthread.h (thread_to_thread_handle): Declare.
11924         * thread.c (gdbtypes.h): Include.
11925         (thread_to_thread_handle): New function.
11926
11927         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11928         (target_thread_info_to_thread_handle): Declare.
11929         * target.c (target_thread_info_to_thread_handle): New function.
11930         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11931         * target-delegates.c: Regenerate.
11932
11933         * linux-thread-db.c (class thread_db_target): Add method
11934         thread_info_to_thread_handle.
11935         (thread_db_target::thread_info_to_thread_handle): Define.
11936         * remote.c (class remote_target): Add new method
11937         thread_info_to_thread_handle.
11938         (remote_target::thread_info_to_thread_handle): Define.
11939
11940 2019-04-08  Pedro Alves  <palves@redhat.com>
11941
11942         * common/common-exceptions.c (throw_exception): Don't create
11943         named object to throw; throw directly.
11944         (throw_it): Likewise.  Don't initialize gdb_exception::message
11945         here, with new; pass FMT and AP to the ctor instead.
11946         * common/common-exceptions.h: Include <string>.
11947         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11948         const char *, va_list)): New ctor.  Use std::make_shared.
11949         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11950         errors)): Delete.
11951         (gdb_exception_error::gdb_exception_error(enum errors, const char
11952         *, va_list)): New.
11953         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11954         Add assertion.
11955         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11956         errors)): Delete.
11957         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11958         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11959         Add assertion.
11960
11961 2019-04-08  Tom Tromey  <tom@tromey.com>
11962
11963         * valops.c (value_rtti_indirect_type): Replace throw_exception
11964         with throw.
11965         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11966         with throw.
11967         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11968         throw.
11969         * target.c (target_translate_tls_address): Replace throw_exception
11970         with throw.
11971         * stack.c (frame_apply_command_count): Replace throw_exception
11972         with throw.
11973         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11974         throw.
11975         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11976         with throw.
11977         * rs6000-tdep.c (rs6000_frame_cache)
11978         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11979         * remote.c: Replace throw_exception with throw.
11980         * record-full.c (record_full_message, record_full_wait_1)
11981         (record_full_restore): Replace throw_exception with throw.
11982         * record-btrace.c:
11983         (get_thread_current_frame_id, record_btrace_start_replaying)
11984         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11985         (cmd_record_btrace_start): Replace throw_exception with throw.
11986         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11987         throw.
11988         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11989         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11990         * linespec.c:
11991         (find_linespec_symbols): Replace throw_exception with throw.
11992         * infrun.c (displaced_step_prepare, resume): Replace
11993         throw_exception with throw.
11994         * infcmd.c (post_create_inferior): Replace throw_exception with
11995         throw.
11996         * inf-loop.c (inferior_event_handler): Replace throw_exception
11997         with throw.
11998         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11999         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12000         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12001         (get_prev_frame_always, get_frame_pc_if_available)
12002         (get_frame_address_in_block_if_available, get_frame_language):
12003         Replace throw_exception with throw.
12004         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12005         throw_exception with throw.
12006         * eval.c (fetch_subexp_value, evaluate_var_value)
12007         (evaluate_funcall, evaluate_subexp_standard): Replace
12008         throw_exception with throw.
12009         * dwarf2loc.c (call_site_find_chain)
12010         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12011         Replace throw_exception with throw.
12012         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12013         with throw.
12014         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12015         throw.
12016         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12017         * completer.c (complete_line_internal): Replace throw_exception
12018         with throw.
12019         * compile/compile-object-run.c (compile_object_run): Replace
12020         throw_exception with throw.
12021         * cli/cli-script.c (process_next_line): Replace throw_exception
12022         with throw.
12023         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12024         (btrace_enable, btrace_maint_update_pt_packets): Replace
12025         throw_exception with throw.
12026         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12027         throw_exception with throw.
12028         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12029         throw_exception with throw.
12030         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12031         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12032         * aarch64-tdep.c (aarch64_make_prologue_cache)
12033         (aarch64_make_stub_cache): Replace throw_exception with throw.
12034
12035 2019-04-08  Tom Tromey  <tom@tromey.com>
12036
12037         * common/common-exceptions.c (throw_exception): Rename from
12038         throw_exception_cxx.  Remove old copy.  Make argument const.
12039         (throw_it): Create and throw exception objects directly.
12040         * common/common-exceptions.h (throw_exception): Make argument
12041         const.
12042         (struct gdb_exception_error): Add constructor.
12043         (struct gdb_exception_quit): Add constructor.
12044
12045 2019-04-08  Tom Tromey  <tom@tromey.com>
12046
12047         * common/common-exceptions.h (exception_rethrow): Don't declare.
12048         (TRY_SJLJ): Update comment.
12049         (TRY, CATCH, END_CATCH): Remove.
12050         * common/common-exceptions.c (exception_rethrow): Remove.
12051
12052 2019-04-08  Tom Tromey  <tom@tromey.com>
12053
12054         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12055         Remove.
12056         (gdb_exception_error): Rename from
12057         gdb_exception_RETURN_MASK_ERROR.
12058         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12059         (gdb_quit_bad_alloc): Update.
12060         * aarch64-tdep.c: Update.
12061         * ada-lang.c: Update.
12062         * ada-typeprint.c: Update.
12063         * ada-valprint.c: Update.
12064         * amd64-tdep.c: Update.
12065         * arch-utils.c: Update.
12066         * break-catch-throw.c: Update.
12067         * breakpoint.c: Update.
12068         * btrace.c: Update.
12069         * c-varobj.c: Update.
12070         * cli/cli-cmds.c: Update.
12071         * cli/cli-interp.c: Update.
12072         * cli/cli-script.c: Update.
12073         * common/common-exceptions.c: Update.
12074         * common/new-op.c: Update.
12075         * common/selftest.c: Update.
12076         * compile/compile-c-symbols.c: Update.
12077         * compile/compile-cplus-symbols.c: Update.
12078         * compile/compile-object-load.c: Update.
12079         * compile/compile-object-run.c: Update.
12080         * completer.c: Update.
12081         * corelow.c: Update.
12082         * cp-abi.c: Update.
12083         * cp-support.c: Update.
12084         * cp-valprint.c: Update.
12085         * darwin-nat.c: Update.
12086         * disasm-selftests.c: Update.
12087         * dtrace-probe.c: Update.
12088         * dwarf-index-cache.c: Update.
12089         * dwarf-index-write.c: Update.
12090         * dwarf2-frame-tailcall.c: Update.
12091         * dwarf2-frame.c: Update.
12092         * dwarf2loc.c: Update.
12093         * dwarf2read.c: Update.
12094         * eval.c: Update.
12095         * event-loop.c: Update.
12096         * event-top.c: Update.
12097         * exec.c: Update.
12098         * f-valprint.c: Update.
12099         * fbsd-tdep.c: Update.
12100         * frame-unwind.c: Update.
12101         * frame.c: Update.
12102         * gdbtypes.c: Update.
12103         * gnu-v3-abi.c: Update.
12104         * guile/guile-internal.h: Update.
12105         * guile/scm-block.c: Update.
12106         * guile/scm-breakpoint.c: Update.
12107         * guile/scm-cmd.c: Update.
12108         * guile/scm-disasm.c: Update.
12109         * guile/scm-frame.c: Update.
12110         * guile/scm-lazy-string.c: Update.
12111         * guile/scm-math.c: Update.
12112         * guile/scm-param.c: Update.
12113         * guile/scm-ports.c: Update.
12114         * guile/scm-pretty-print.c: Update.
12115         * guile/scm-symbol.c: Update.
12116         * guile/scm-symtab.c: Update.
12117         * guile/scm-type.c: Update.
12118         * guile/scm-value.c: Update.
12119         * i386-linux-tdep.c: Update.
12120         * i386-tdep.c: Update.
12121         * inf-loop.c: Update.
12122         * infcall.c: Update.
12123         * infcmd.c: Update.
12124         * infrun.c: Update.
12125         * jit.c: Update.
12126         * language.c: Update.
12127         * linespec.c: Update.
12128         * linux-fork.c: Update.
12129         * linux-nat.c: Update.
12130         * linux-tdep.c: Update.
12131         * linux-thread-db.c: Update.
12132         * main.c: Update.
12133         * mi/mi-cmd-break.c: Update.
12134         * mi/mi-cmd-stack.c: Update.
12135         * mi/mi-interp.c: Update.
12136         * mi/mi-main.c: Update.
12137         * objc-lang.c: Update.
12138         * p-valprint.c: Update.
12139         * parse.c: Update.
12140         * ppc-linux-tdep.c: Update.
12141         * printcmd.c: Update.
12142         * python/py-arch.c: Update.
12143         * python/py-breakpoint.c: Update.
12144         * python/py-cmd.c: Update.
12145         * python/py-finishbreakpoint.c: Update.
12146         * python/py-frame.c: Update.
12147         * python/py-framefilter.c: Update.
12148         * python/py-gdb-readline.c: Update.
12149         * python/py-inferior.c: Update.
12150         * python/py-infthread.c: Update.
12151         * python/py-lazy-string.c: Update.
12152         * python/py-linetable.c: Update.
12153         * python/py-objfile.c: Update.
12154         * python/py-param.c: Update.
12155         * python/py-prettyprint.c: Update.
12156         * python/py-progspace.c: Update.
12157         * python/py-record-btrace.c: Update.
12158         * python/py-record.c: Update.
12159         * python/py-symbol.c: Update.
12160         * python/py-type.c: Update.
12161         * python/py-unwind.c: Update.
12162         * python/py-utils.c: Update.
12163         * python/py-value.c: Update.
12164         * python/python.c: Update.
12165         * record-btrace.c: Update.
12166         * record-full.c: Update.
12167         * remote-fileio.c: Update.
12168         * remote.c: Update.
12169         * riscv-tdep.c: Update.
12170         * rs6000-aix-tdep.c: Update.
12171         * rs6000-tdep.c: Update.
12172         * rust-exp.y: Update.
12173         * rust-lang.c: Update.
12174         * s390-tdep.c: Update.
12175         * selftest-arch.c: Update.
12176         * solib-dsbt.c: Update.
12177         * solib-frv.c: Update.
12178         * solib-spu.c: Update.
12179         * solib-svr4.c: Update.
12180         * solib.c: Update.
12181         * sparc64-linux-tdep.c: Update.
12182         * stack.c: Update.
12183         * symfile-mem.c: Update.
12184         * symmisc.c: Update.
12185         * target.c: Update.
12186         * thread.c: Update.
12187         * top.c: Update.
12188         * tracefile-tfile.c: Update.
12189         * tui/tui.c: Update.
12190         * typeprint.c: Update.
12191         * unittests/cli-utils-selftests.c: Update.
12192         * unittests/parse-connection-spec-selftests.c: Update.
12193         * valops.c: Update.
12194         * valprint.c: Update.
12195         * value.c: Update.
12196         * varobj.c: Update.
12197         * windows-nat.c: Update.
12198         * x86-linux-nat.c: Update.
12199         * xml-support.c: Update.
12200
12201 2019-04-08  Tom Tromey  <tom@tromey.com>
12202
12203         * xml-support.c: Use C++ exception handling.
12204         * x86-linux-nat.c: Use C++ exception handling.
12205         * windows-nat.c: Use C++ exception handling.
12206         * varobj.c: Use C++ exception handling.
12207         * value.c: Use C++ exception handling.
12208         * valprint.c: Use C++ exception handling.
12209         * valops.c: Use C++ exception handling.
12210         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12211         handling.
12212         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12213         * typeprint.c: Use C++ exception handling.
12214         * tui/tui.c: Use C++ exception handling.
12215         * tracefile-tfile.c: Use C++ exception handling.
12216         * top.c: Use C++ exception handling.
12217         * thread.c: Use C++ exception handling.
12218         * target.c: Use C++ exception handling.
12219         * symmisc.c: Use C++ exception handling.
12220         * symfile-mem.c: Use C++ exception handling.
12221         * stack.c: Use C++ exception handling.
12222         * sparc64-linux-tdep.c: Use C++ exception handling.
12223         * solib.c: Use C++ exception handling.
12224         * solib-svr4.c: Use C++ exception handling.
12225         * solib-spu.c: Use C++ exception handling.
12226         * solib-frv.c: Use C++ exception handling.
12227         * solib-dsbt.c: Use C++ exception handling.
12228         * selftest-arch.c: Use C++ exception handling.
12229         * s390-tdep.c: Use C++ exception handling.
12230         * rust-lang.c: Use C++ exception handling.
12231         * rust-exp.y: Use C++ exception handling.
12232         * rs6000-tdep.c: Use C++ exception handling.
12233         * rs6000-aix-tdep.c: Use C++ exception handling.
12234         * riscv-tdep.c: Use C++ exception handling.
12235         * remote.c: Use C++ exception handling.
12236         * remote-fileio.c: Use C++ exception handling.
12237         * record-full.c: Use C++ exception handling.
12238         * record-btrace.c: Use C++ exception handling.
12239         * python/python.c: Use C++ exception handling.
12240         * python/py-value.c: Use C++ exception handling.
12241         * python/py-utils.c: Use C++ exception handling.
12242         * python/py-unwind.c: Use C++ exception handling.
12243         * python/py-type.c: Use C++ exception handling.
12244         * python/py-symbol.c: Use C++ exception handling.
12245         * python/py-record.c: Use C++ exception handling.
12246         * python/py-record-btrace.c: Use C++ exception handling.
12247         * python/py-progspace.c: Use C++ exception handling.
12248         * python/py-prettyprint.c: Use C++ exception handling.
12249         * python/py-param.c: Use C++ exception handling.
12250         * python/py-objfile.c: Use C++ exception handling.
12251         * python/py-linetable.c: Use C++ exception handling.
12252         * python/py-lazy-string.c: Use C++ exception handling.
12253         * python/py-infthread.c: Use C++ exception handling.
12254         * python/py-inferior.c: Use C++ exception handling.
12255         * python/py-gdb-readline.c: Use C++ exception handling.
12256         * python/py-framefilter.c: Use C++ exception handling.
12257         * python/py-frame.c: Use C++ exception handling.
12258         * python/py-finishbreakpoint.c: Use C++ exception handling.
12259         * python/py-cmd.c: Use C++ exception handling.
12260         * python/py-breakpoint.c: Use C++ exception handling.
12261         * python/py-arch.c: Use C++ exception handling.
12262         * printcmd.c: Use C++ exception handling.
12263         * ppc-linux-tdep.c: Use C++ exception handling.
12264         * parse.c: Use C++ exception handling.
12265         * p-valprint.c: Use C++ exception handling.
12266         * objc-lang.c: Use C++ exception handling.
12267         * mi/mi-main.c: Use C++ exception handling.
12268         * mi/mi-interp.c: Use C++ exception handling.
12269         * mi/mi-cmd-stack.c: Use C++ exception handling.
12270         * mi/mi-cmd-break.c: Use C++ exception handling.
12271         * main.c: Use C++ exception handling.
12272         * linux-thread-db.c: Use C++ exception handling.
12273         * linux-tdep.c: Use C++ exception handling.
12274         * linux-nat.c: Use C++ exception handling.
12275         * linux-fork.c: Use C++ exception handling.
12276         * linespec.c: Use C++ exception handling.
12277         * language.c: Use C++ exception handling.
12278         * jit.c: Use C++ exception handling.
12279         * infrun.c: Use C++ exception handling.
12280         * infcmd.c: Use C++ exception handling.
12281         * infcall.c: Use C++ exception handling.
12282         * inf-loop.c: Use C++ exception handling.
12283         * i386-tdep.c: Use C++ exception handling.
12284         * i386-linux-tdep.c: Use C++ exception handling.
12285         * guile/scm-value.c: Use C++ exception handling.
12286         * guile/scm-type.c: Use C++ exception handling.
12287         * guile/scm-symtab.c: Use C++ exception handling.
12288         * guile/scm-symbol.c: Use C++ exception handling.
12289         * guile/scm-pretty-print.c: Use C++ exception handling.
12290         * guile/scm-ports.c: Use C++ exception handling.
12291         * guile/scm-param.c: Use C++ exception handling.
12292         * guile/scm-math.c: Use C++ exception handling.
12293         * guile/scm-lazy-string.c: Use C++ exception handling.
12294         * guile/scm-frame.c: Use C++ exception handling.
12295         * guile/scm-disasm.c: Use C++ exception handling.
12296         * guile/scm-cmd.c: Use C++ exception handling.
12297         * guile/scm-breakpoint.c: Use C++ exception handling.
12298         * guile/scm-block.c: Use C++ exception handling.
12299         * guile/guile-internal.h: Use C++ exception handling.
12300         * gnu-v3-abi.c: Use C++ exception handling.
12301         * gdbtypes.c: Use C++ exception handling.
12302         * frame.c: Use C++ exception handling.
12303         * frame-unwind.c: Use C++ exception handling.
12304         * fbsd-tdep.c: Use C++ exception handling.
12305         * f-valprint.c: Use C++ exception handling.
12306         * exec.c: Use C++ exception handling.
12307         * event-top.c: Use C++ exception handling.
12308         * event-loop.c: Use C++ exception handling.
12309         * eval.c: Use C++ exception handling.
12310         * dwarf2read.c: Use C++ exception handling.
12311         * dwarf2loc.c: Use C++ exception handling.
12312         * dwarf2-frame.c: Use C++ exception handling.
12313         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12314         * dwarf-index-write.c: Use C++ exception handling.
12315         * dwarf-index-cache.c: Use C++ exception handling.
12316         * dtrace-probe.c: Use C++ exception handling.
12317         * disasm-selftests.c: Use C++ exception handling.
12318         * darwin-nat.c: Use C++ exception handling.
12319         * cp-valprint.c: Use C++ exception handling.
12320         * cp-support.c: Use C++ exception handling.
12321         * cp-abi.c: Use C++ exception handling.
12322         * corelow.c: Use C++ exception handling.
12323         * completer.c: Use C++ exception handling.
12324         * compile/compile-object-run.c: Use C++ exception handling.
12325         * compile/compile-object-load.c: Use C++ exception handling.
12326         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12327         * compile/compile-c-symbols.c: Use C++ exception handling.
12328         * common/selftest.c: Use C++ exception handling.
12329         * common/new-op.c: Use C++ exception handling.
12330         * cli/cli-script.c: Use C++ exception handling.
12331         * cli/cli-interp.c: Use C++ exception handling.
12332         * cli/cli-cmds.c: Use C++ exception handling.
12333         * c-varobj.c: Use C++ exception handling.
12334         * btrace.c: Use C++ exception handling.
12335         * breakpoint.c: Use C++ exception handling.
12336         * break-catch-throw.c: Use C++ exception handling.
12337         * arch-utils.c: Use C++ exception handling.
12338         * amd64-tdep.c: Use C++ exception handling.
12339         * ada-valprint.c: Use C++ exception handling.
12340         * ada-typeprint.c: Use C++ exception handling.
12341         * ada-lang.c: Use C++ exception handling.
12342         * aarch64-tdep.c: Use C++ exception handling.
12343
12344 2019-04-08  Tom Tromey  <tom@tromey.com>
12345
12346         * xml-support.c (gdb_xml_parser::parse): Update.
12347         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12348         * value.c (show_convenience): Update.
12349         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12350         (test_parse_flags_qcs): Update.
12351         * thread.c (thr_try_catch_cmd): Update.
12352         * target.c (target_translate_tls_address): Update.
12353         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12354         (info_frame_command_core, frame_apply_command_count): Update.
12355         * rust-exp.y (rust_lex_exception_test): Update.
12356         * riscv-tdep.c (riscv_print_one_register_info): Update.
12357         * remote.c (remote_target::enable_btrace): Update.
12358         * record-btrace.c (record_btrace_enable_warn): Update.
12359         * python/py-utils.c (gdbpy_convert_exception): Update.
12360         * printcmd.c (do_one_display, print_variable_and_value): Update.
12361         * mi/mi-main.c (mi_print_exception): Update.
12362         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12363         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12364         * linux-nat.c (linux_nat_target::attach): Update.
12365         * linux-fork.c (class scoped_switch_fork_info): Update.
12366         * infrun.c (displaced_step_prepare): Update.
12367         * infcall.c (call_function_by_hand_dummy): Update.
12368         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12369         * gnu-v3-abi.c (print_one_vtable): Update.
12370         * frame.c (get_prev_frame_always): Update.
12371         * f-valprint.c (info_common_command_for_block): Update.
12372         * exec.c (try_open_exec_file): Update.
12373         * exceptions.c (print_exception, exception_print)
12374         (exception_fprintf, exception_print_same): Update.
12375         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12376         * dwarf-index-cache.c (index_cache::store)
12377         (index_cache::lookup_gdb_index): Update.
12378         * darwin-nat.c (maybe_cache_shell): Update.
12379         * cp-valprint.c (cp_print_value_fields): Update.
12380         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12381         (gcc_cplus_symbol_address): Update.
12382         * compile/compile-c-symbols.c (gcc_convert_symbol)
12383         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12384         * common/selftest.c: Update.
12385         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12386         a std::string.
12387         (exception_try_scope_entry, exception_try_scope_exit): Don't
12388         declare.
12389         (struct exception_try_scope): Remove.
12390         (TRY): Don't use exception_try_scope.
12391         (struct gdb_exception): Add constructor, operator=.
12392         <what>: New method.
12393         (struct gdb_exception_RETURN_MASK_ALL)
12394         (struct gdb_exception_RETURN_MASK_ERROR)
12395         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12396         (struct gdb_quit_bad_alloc): Update.
12397         * common/common-exceptions.c (exception_none): Change
12398         initializer.
12399         (struct catcher) <state, exception>: Initialize inline.
12400         <prev>: Remove member.
12401         (current_catcher): Remove.
12402         (catchers): New global.
12403         (exceptions_state_mc_init): Simplify.
12404         (catcher_pop): Remove.
12405         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12406         (try_scope_depth, exception_try_scope_entry)
12407         (exception_try_scope_exit): Remove.
12408         (throw_exception_sjlj): Update.
12409         (exception_messages, exception_messages_size): Remove.
12410         (throw_it): Simplify.
12411         (gdb_exception_sliced_copy): Remove.
12412         (throw_exception_cxx): Update.
12413         * cli/cli-script.c (script_from_file): Update.
12414         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12415         Update.
12416         * ada-valprint.c (ada_val_print): Update.
12417         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12418         (create_excep_cond_exprs): Update.
12419
12420 2019-04-08  Tom Tromey  <tom@tromey.com>
12421
12422         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12423         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12424         (TRY, CATCH, END_CATCH): Remove some definitions.
12425         * common/common-exceptions.c: Don't use GDB_XCPT.
12426         (catcher_list_size): Remove.
12427         (throw_exception, throw_it): Simplify.
12428
12429 2019-04-05  Tom Tromey  <tom@tromey.com>
12430
12431         Revert the header-sorting patch.
12432         * ft32-tdep.c: Revert.
12433         * frv-tdep.c: Revert.
12434         * frv-linux-tdep.c: Revert.
12435         * frame.c: Revert.
12436         * frame-unwind.c: Revert.
12437         * frame-base.c: Revert.
12438         * fork-child.c: Revert.
12439         * findvar.c: Revert.
12440         * findcmd.c: Revert.
12441         * filesystem.c: Revert.
12442         * filename-seen-cache.h: Revert.
12443         * filename-seen-cache.c: Revert.
12444         * fbsd-tdep.c: Revert.
12445         * fbsd-nat.h: Revert.
12446         * fbsd-nat.c: Revert.
12447         * f-valprint.c: Revert.
12448         * f-typeprint.c: Revert.
12449         * f-lang.c: Revert.
12450         * extension.h: Revert.
12451         * extension.c: Revert.
12452         * extension-priv.h: Revert.
12453         * expprint.c: Revert.
12454         * exec.h: Revert.
12455         * exec.c: Revert.
12456         * exceptions.c: Revert.
12457         * event-top.c: Revert.
12458         * event-loop.c: Revert.
12459         * eval.c: Revert.
12460         * elfread.c: Revert.
12461         * dwarf2read.h: Revert.
12462         * dwarf2read.c: Revert.
12463         * dwarf2loc.c: Revert.
12464         * dwarf2expr.h: Revert.
12465         * dwarf2expr.c: Revert.
12466         * dwarf2-frame.c: Revert.
12467         * dwarf2-frame-tailcall.c: Revert.
12468         * dwarf-index-write.h: Revert.
12469         * dwarf-index-write.c: Revert.
12470         * dwarf-index-common.c: Revert.
12471         * dwarf-index-cache.h: Revert.
12472         * dwarf-index-cache.c: Revert.
12473         * dummy-frame.c: Revert.
12474         * dtrace-probe.c: Revert.
12475         * disasm.h: Revert.
12476         * disasm.c: Revert.
12477         * disasm-selftests.c: Revert.
12478         * dictionary.c: Revert.
12479         * dicos-tdep.c: Revert.
12480         * demangle.c: Revert.
12481         * dcache.h: Revert.
12482         * dcache.c: Revert.
12483         * darwin-nat.h: Revert.
12484         * darwin-nat.c: Revert.
12485         * darwin-nat-info.c: Revert.
12486         * d-valprint.c: Revert.
12487         * d-namespace.c: Revert.
12488         * d-lang.c: Revert.
12489         * ctf.c: Revert.
12490         * csky-tdep.c: Revert.
12491         * csky-linux-tdep.c: Revert.
12492         * cris-tdep.c: Revert.
12493         * cris-linux-tdep.c: Revert.
12494         * cp-valprint.c: Revert.
12495         * cp-support.c: Revert.
12496         * cp-namespace.c: Revert.
12497         * cp-abi.c: Revert.
12498         * corelow.c: Revert.
12499         * corefile.c: Revert.
12500         * continuations.c: Revert.
12501         * completer.h: Revert.
12502         * completer.c: Revert.
12503         * complaints.c: Revert.
12504         * coffread.c: Revert.
12505         * coff-pe-read.c: Revert.
12506         * cli-out.h: Revert.
12507         * cli-out.c: Revert.
12508         * charset.c: Revert.
12509         * c-varobj.c: Revert.
12510         * c-valprint.c: Revert.
12511         * c-typeprint.c: Revert.
12512         * c-lang.c: Revert.
12513         * buildsym.c: Revert.
12514         * buildsym-legacy.c: Revert.
12515         * build-id.h: Revert.
12516         * build-id.c: Revert.
12517         * btrace.c: Revert.
12518         * bsd-uthread.c: Revert.
12519         * breakpoint.h: Revert.
12520         * breakpoint.c: Revert.
12521         * break-catch-throw.c: Revert.
12522         * break-catch-syscall.c: Revert.
12523         * break-catch-sig.c: Revert.
12524         * blockframe.c: Revert.
12525         * block.c: Revert.
12526         * bfin-tdep.c: Revert.
12527         * bfin-linux-tdep.c: Revert.
12528         * bfd-target.c: Revert.
12529         * bcache.c: Revert.
12530         * ax-general.c: Revert.
12531         * ax-gdb.h: Revert.
12532         * ax-gdb.c: Revert.
12533         * avr-tdep.c: Revert.
12534         * auxv.c: Revert.
12535         * auto-load.c: Revert.
12536         * arm-wince-tdep.c: Revert.
12537         * arm-tdep.c: Revert.
12538         * arm-symbian-tdep.c: Revert.
12539         * arm-pikeos-tdep.c: Revert.
12540         * arm-obsd-tdep.c: Revert.
12541         * arm-nbsd-tdep.c: Revert.
12542         * arm-nbsd-nat.c: Revert.
12543         * arm-linux-tdep.c: Revert.
12544         * arm-linux-nat.c: Revert.
12545         * arm-fbsd-tdep.c: Revert.
12546         * arm-fbsd-nat.c: Revert.
12547         * arm-bsd-tdep.c: Revert.
12548         * arch-utils.c: Revert.
12549         * arc-tdep.c: Revert.
12550         * arc-newlib-tdep.c: Revert.
12551         * annotate.h: Revert.
12552         * annotate.c: Revert.
12553         * amd64-windows-tdep.c: Revert.
12554         * amd64-windows-nat.c: Revert.
12555         * amd64-tdep.c: Revert.
12556         * amd64-sol2-tdep.c: Revert.
12557         * amd64-obsd-tdep.c: Revert.
12558         * amd64-obsd-nat.c: Revert.
12559         * amd64-nbsd-tdep.c: Revert.
12560         * amd64-nbsd-nat.c: Revert.
12561         * amd64-nat.c: Revert.
12562         * amd64-linux-tdep.c: Revert.
12563         * amd64-linux-nat.c: Revert.
12564         * amd64-fbsd-tdep.c: Revert.
12565         * amd64-fbsd-nat.c: Revert.
12566         * amd64-dicos-tdep.c: Revert.
12567         * amd64-darwin-tdep.c: Revert.
12568         * amd64-bsd-nat.c: Revert.
12569         * alpha-tdep.c: Revert.
12570         * alpha-obsd-tdep.c: Revert.
12571         * alpha-nbsd-tdep.c: Revert.
12572         * alpha-mdebug-tdep.c: Revert.
12573         * alpha-linux-tdep.c: Revert.
12574         * alpha-linux-nat.c: Revert.
12575         * alpha-bsd-tdep.c: Revert.
12576         * alpha-bsd-nat.c: Revert.
12577         * aix-thread.c: Revert.
12578         * agent.c: Revert.
12579         * addrmap.c: Revert.
12580         * ada-varobj.c: Revert.
12581         * ada-valprint.c: Revert.
12582         * ada-typeprint.c: Revert.
12583         * ada-tasks.c: Revert.
12584         * ada-lang.c: Revert.
12585         * aarch64-tdep.c: Revert.
12586         * aarch64-ravenscar-thread.c: Revert.
12587         * aarch64-newlib-tdep.c: Revert.
12588         * aarch64-linux-tdep.c: Revert.
12589         * aarch64-linux-nat.c: Revert.
12590         * aarch64-fbsd-tdep.c: Revert.
12591         * aarch64-fbsd-nat.c: Revert.
12592         * aarch32-linux-nat.c: Revert.
12593
12594 2019-04-05  Tom Tromey  <tom@tromey.com>
12595
12596         * ft32-tdep.c: Sort headers.
12597         * frv-tdep.c: Sort headers.
12598         * frv-linux-tdep.c: Sort headers.
12599         * frame.c: Sort headers.
12600         * frame-unwind.c: Sort headers.
12601         * frame-base.c: Sort headers.
12602         * fork-child.c: Sort headers.
12603         * findvar.c: Sort headers.
12604         * findcmd.c: Sort headers.
12605         * filesystem.c: Sort headers.
12606         * filename-seen-cache.h: Sort headers.
12607         * filename-seen-cache.c: Sort headers.
12608         * fbsd-tdep.c: Sort headers.
12609         * fbsd-nat.h: Sort headers.
12610         * fbsd-nat.c: Sort headers.
12611         * f-valprint.c: Sort headers.
12612         * f-typeprint.c: Sort headers.
12613         * f-lang.c: Sort headers.
12614         * extension.h: Sort headers.
12615         * extension.c: Sort headers.
12616         * extension-priv.h: Sort headers.
12617         * expprint.c: Sort headers.
12618         * exec.h: Sort headers.
12619         * exec.c: Sort headers.
12620         * exceptions.c: Sort headers.
12621         * event-top.c: Sort headers.
12622         * event-loop.c: Sort headers.
12623         * eval.c: Sort headers.
12624         * elfread.c: Sort headers.
12625         * dwarf2read.h: Sort headers.
12626         * dwarf2read.c: Sort headers.
12627         * dwarf2loc.c: Sort headers.
12628         * dwarf2expr.h: Sort headers.
12629         * dwarf2expr.c: Sort headers.
12630         * dwarf2-frame.c: Sort headers.
12631         * dwarf2-frame-tailcall.c: Sort headers.
12632         * dwarf-index-write.h: Sort headers.
12633         * dwarf-index-write.c: Sort headers.
12634         * dwarf-index-common.c: Sort headers.
12635         * dwarf-index-cache.h: Sort headers.
12636         * dwarf-index-cache.c: Sort headers.
12637         * dummy-frame.c: Sort headers.
12638         * dtrace-probe.c: Sort headers.
12639         * disasm.h: Sort headers.
12640         * disasm.c: Sort headers.
12641         * disasm-selftests.c: Sort headers.
12642         * dictionary.c: Sort headers.
12643         * dicos-tdep.c: Sort headers.
12644         * demangle.c: Sort headers.
12645         * dcache.h: Sort headers.
12646         * dcache.c: Sort headers.
12647         * darwin-nat.h: Sort headers.
12648         * darwin-nat.c: Sort headers.
12649         * darwin-nat-info.c: Sort headers.
12650         * d-valprint.c: Sort headers.
12651         * d-namespace.c: Sort headers.
12652         * d-lang.c: Sort headers.
12653         * ctf.c: Sort headers.
12654         * csky-tdep.c: Sort headers.
12655         * csky-linux-tdep.c: Sort headers.
12656         * cris-tdep.c: Sort headers.
12657         * cris-linux-tdep.c: Sort headers.
12658         * cp-valprint.c: Sort headers.
12659         * cp-support.c: Sort headers.
12660         * cp-namespace.c: Sort headers.
12661         * cp-abi.c: Sort headers.
12662         * corelow.c: Sort headers.
12663         * corefile.c: Sort headers.
12664         * continuations.c: Sort headers.
12665         * completer.h: Sort headers.
12666         * completer.c: Sort headers.
12667         * complaints.c: Sort headers.
12668         * coffread.c: Sort headers.
12669         * coff-pe-read.c: Sort headers.
12670         * cli-out.h: Sort headers.
12671         * cli-out.c: Sort headers.
12672         * charset.c: Sort headers.
12673         * c-varobj.c: Sort headers.
12674         * c-valprint.c: Sort headers.
12675         * c-typeprint.c: Sort headers.
12676         * c-lang.c: Sort headers.
12677         * buildsym.c: Sort headers.
12678         * buildsym-legacy.c: Sort headers.
12679         * build-id.h: Sort headers.
12680         * build-id.c: Sort headers.
12681         * btrace.c: Sort headers.
12682         * bsd-uthread.c: Sort headers.
12683         * breakpoint.h: Sort headers.
12684         * breakpoint.c: Sort headers.
12685         * break-catch-throw.c: Sort headers.
12686         * break-catch-syscall.c: Sort headers.
12687         * break-catch-sig.c: Sort headers.
12688         * blockframe.c: Sort headers.
12689         * block.c: Sort headers.
12690         * bfin-tdep.c: Sort headers.
12691         * bfin-linux-tdep.c: Sort headers.
12692         * bfd-target.c: Sort headers.
12693         * bcache.c: Sort headers.
12694         * ax-general.c: Sort headers.
12695         * ax-gdb.h: Sort headers.
12696         * ax-gdb.c: Sort headers.
12697         * avr-tdep.c: Sort headers.
12698         * auxv.c: Sort headers.
12699         * auto-load.c: Sort headers.
12700         * arm-wince-tdep.c: Sort headers.
12701         * arm-tdep.c: Sort headers.
12702         * arm-symbian-tdep.c: Sort headers.
12703         * arm-pikeos-tdep.c: Sort headers.
12704         * arm-obsd-tdep.c: Sort headers.
12705         * arm-nbsd-tdep.c: Sort headers.
12706         * arm-nbsd-nat.c: Sort headers.
12707         * arm-linux-tdep.c: Sort headers.
12708         * arm-linux-nat.c: Sort headers.
12709         * arm-fbsd-tdep.c: Sort headers.
12710         * arm-fbsd-nat.c: Sort headers.
12711         * arm-bsd-tdep.c: Sort headers.
12712         * arch-utils.c: Sort headers.
12713         * arc-tdep.c: Sort headers.
12714         * arc-newlib-tdep.c: Sort headers.
12715         * annotate.h: Sort headers.
12716         * annotate.c: Sort headers.
12717         * amd64-windows-tdep.c: Sort headers.
12718         * amd64-windows-nat.c: Sort headers.
12719         * amd64-tdep.c: Sort headers.
12720         * amd64-sol2-tdep.c: Sort headers.
12721         * amd64-obsd-tdep.c: Sort headers.
12722         * amd64-obsd-nat.c: Sort headers.
12723         * amd64-nbsd-tdep.c: Sort headers.
12724         * amd64-nbsd-nat.c: Sort headers.
12725         * amd64-nat.c: Sort headers.
12726         * amd64-linux-tdep.c: Sort headers.
12727         * amd64-linux-nat.c: Sort headers.
12728         * amd64-fbsd-tdep.c: Sort headers.
12729         * amd64-fbsd-nat.c: Sort headers.
12730         * amd64-dicos-tdep.c: Sort headers.
12731         * amd64-darwin-tdep.c: Sort headers.
12732         * amd64-bsd-nat.c: Sort headers.
12733         * alpha-tdep.c: Sort headers.
12734         * alpha-obsd-tdep.c: Sort headers.
12735         * alpha-nbsd-tdep.c: Sort headers.
12736         * alpha-mdebug-tdep.c: Sort headers.
12737         * alpha-linux-tdep.c: Sort headers.
12738         * alpha-linux-nat.c: Sort headers.
12739         * alpha-bsd-tdep.c: Sort headers.
12740         * alpha-bsd-nat.c: Sort headers.
12741         * aix-thread.c: Sort headers.
12742         * agent.c: Sort headers.
12743         * addrmap.c: Sort headers.
12744         * ada-varobj.c: Sort headers.
12745         * ada-valprint.c: Sort headers.
12746         * ada-typeprint.c: Sort headers.
12747         * ada-tasks.c: Sort headers.
12748         * ada-lang.c: Sort headers.
12749         * aarch64-tdep.c: Sort headers.
12750         * aarch64-ravenscar-thread.c: Sort headers.
12751         * aarch64-newlib-tdep.c: Sort headers.
12752         * aarch64-linux-tdep.c: Sort headers.
12753         * aarch64-linux-nat.c: Sort headers.
12754         * aarch64-fbsd-tdep.c: Sort headers.
12755         * aarch64-fbsd-nat.c: Sort headers.
12756         * aarch32-linux-nat.c: Sort headers.
12757
12758 2019-04-04  Tom Tromey  <tom@tromey.com>
12759
12760         * varobj.c (varobj_create): Update.
12761         * rust-exp.y (struct rust_parser) <update_innermost_block,
12762         lookup_symbol>: New methods.
12763         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12764         Rename.
12765         (rust_parser::rust_lookup_type)
12766         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12767         * printcmd.c (display_command, do_one_display): Update.
12768         * parser-defs.h (struct parser_state) <parser_state>: Add
12769         "tracker" parameter.
12770         (block_tracker): New member.
12771         (class innermost_block_tracker) <innermost_block_tracker>: Add
12772         "types" parameter.
12773         <reset>: Remove method.
12774         (innermost_block): Don't declare.
12775         (null_post_parser): Update.
12776         * parse.c (innermost_block): Remove global.
12777         (write_dollar_variable): Update.
12778         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12779         Remove "tracker_types" parameter.
12780         (parse_expression): Add "tracker" parameter.
12781         (parse_expression_for_completion): Update.
12782         (null_post_parser): Add "tracker" parameter.
12783         * p-exp.y: Update rules.
12784         * m2-exp.y: Update rules.
12785         * language.h (struct language_defn) <la_post_parser>: Add
12786         "tracker" parameter.
12787         * go-exp.y: Update rules.
12788         * f-exp.y: Update rules.
12789         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12790         parameter.
12791         * d-exp.y: Update rules.
12792         * c-exp.y: Update rules.
12793         * breakpoint.c (set_breakpoint_condition): Create an
12794         innermost_block_tracker.
12795         (watch_command_1): Likewise.
12796         * ada-lang.c (resolve): Add "tracker" parameter.
12797         (resolve_subexp): Likewise.
12798         * ada-exp.y (write_var_from_sym): Update.
12799
12800 2019-04-04  Tom Tromey  <tom@tromey.com>
12801
12802         * type-stack.h: New file.
12803         * type-stack.c: New file.
12804         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12805         type-stack.h.
12806         (insert_into_type_stack, insert_type, push_type, push_type_int)
12807         (insert_type_address_space, pop_type, pop_type_int)
12808         (pop_typelist, pop_type_stack, append_type_stack)
12809         (push_type_stack, get_type_stack, push_typelist)
12810         (follow_type_instance_flags, follow_types): Don't declare.
12811         * parse.c (type_stack): Remove global.
12812         (parse_exp_in_context): Update.
12813         (insert_into_type_stack, insert_type, push_type, push_type_int)
12814         (insert_type_address_space, pop_type, pop_type_int)
12815         (pop_typelist, pop_type_stack, append_type_stack)
12816         (push_type_stack, get_type_stack, push_typelist)
12817         (follow_type_instance_flags, follow_types): Remove (moved to
12818         type-stack.c).
12819         * f-exp.y (type_stack): New global.
12820         Update rules.
12821         (push_kind_type, f_parse): Update.
12822         * d-exp.y (type_stack): New global.
12823         Update rules.
12824         (d_parse): Update.
12825         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12826         Update rules.
12827         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12828         (HFILES_NO_SRCDIR): Add type-stack.h.
12829
12830 2019-04-04  Tom Tromey  <tom@tromey.com>
12831
12832         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12833         (rust_parser::convert_ast_to_expression, rust_parse)
12834         (rust_lex_test_completion, rust_lex_tests): Update.
12835         * parser-defs.h (struct expr_completion_state): New.
12836         (struct parser_state) <parser_state>: Add completion parameter.
12837         <mark_struct_expression, mark_completion_tag>: New methods.
12838         <parse_completion, m_completion_state>: New members.
12839         (prefixify_expression, null_post_parser): Update.
12840         (mark_struct_expression, mark_completion_tag): Don't declare.
12841         * parse.c (parse_completion, expout_last_struct)
12842         (expout_tag_completion_type, expout_completion_name): Remove
12843         globals.
12844         (parser_state::mark_struct_expression)
12845         (parser_state::mark_completion_tag): Now methods.
12846         (prefixify_expression): Add last_struct parameter.
12847         (prefixify_subexp): Likewise.
12848         (parse_exp_1): Update.
12849         (parse_exp_in_context): Add cstate parameter.  Update.
12850         (parse_expression_for_completion): Create an
12851         expr_completion_state.
12852         (null_post_parser): Add "completion" parameter.
12853         * p-exp.y: Update rules.
12854         (yylex): Update.
12855         * language.h (struct language_defn) <la_post_parser>: Add
12856         "completing" parameter.
12857         * go-exp.y: Update rules.
12858         (lex_one_token): Update.
12859         * expression.h (parse_completion): Don't declare.
12860         * d-exp.y: Update rules.
12861         (lex_one_token): Update rules.
12862         * c-exp.y: Update rules.
12863         (lex_one_token): Update.
12864         * ada-lang.c (resolve): Add "parse_completion" parameter.
12865         (resolve_subexp): Likewise.
12866         (ada_resolve_function): Likewise.
12867
12868 2019-04-04  Tom Tromey  <tom@tromey.com>
12869
12870         * parser-defs.h (struct parser_state) <start_arglist,
12871         end_arglist>: New methods.
12872         <arglist_len, m_funcall_chain>: New members.
12873         (arglist_len, start_arglist, end_arglist): Don't declare.
12874         * parse.c (arglist_len, funcall_chain): Remove global.
12875         (start_arglist, end_arglist): Remove functions.
12876         (parse_exp_in_context): Update.
12877         * p-exp.y: Update rules.
12878         * m2-exp.y: Update rules.
12879         * go-exp.y: Update rules.
12880         * f-exp.y: Update rules.
12881         * d-exp.y: Update rules.
12882         * c-exp.y: Update rules.
12883
12884 2019-04-04  Tom Tromey  <tom@tromey.com>
12885
12886         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12887         lex_operator, push_back>: New methods.
12888         Update all rules.
12889         (rust_parser::lex_hex, lex_escape): Rename and update.
12890         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12891         (rust_parser::lex_operator): Rename and update.
12892         (rust_parser::lex_number, rustyylex, rustyyerror)
12893         (rust_lex_test_init, rust_lex_test_sequence)
12894         (rust_lex_test_push_back, rust_lex_tests): Update.
12895         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12896         parameter.
12897         <lexptr, prev_lexptr>: New members.
12898         (lexptr, prev_lexptr): Don't declare.
12899         * parse.c (lexptr, prev_lexptr): Remove globals.
12900         (parse_exp_in_context): Update.
12901         * p-exp.y (yylex, yyerror): Update.
12902         * m2-exp.y (parse_number, yylex, yyerror): Update.
12903         * go-exp.y (lex_one_token, yyerror): Update.
12904         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12905         * d-exp.y (lex_one_token, yyerror): Update.
12906         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12907         (lex_one_token, yyerror): Update.
12908         * ada-lex.l (YY_INPUT): Update.
12909         (rewind_to_char): Update.
12910         * ada-exp.y (yyerror): Update.
12911
12912 2019-04-04  Tom Tromey  <tom@tromey.com>
12913
12914         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12915         * parser-defs.h (struct parser_state) <parser_state>: Add new
12916         parameter.
12917         <comma_terminates>: New member.
12918         (comma_terminates): Don't declare global.
12919         * parse.c (comma_terminates): Remove global.
12920         (parse_exp_in_context): Update.
12921         * p-exp.y (yylex): Update.
12922         * m2-exp.y (yylex): Update.
12923         * go-exp.y (lex_one_token): Update.
12924         * f-exp.y (yylex): Update.
12925         * d-exp.y (lex_one_token): Update.
12926         * c-exp.y (lex_one_token): Update.
12927         * ada-lex.l: Update.
12928
12929 2019-04-04  Tom Tromey  <tom@tromey.com>
12930
12931         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12932         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12933         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12934         * parser-defs.h (paren_depth): Don't declare.
12935         * parse.c (paren_depth): Remove global.
12936         (parse_exp_in_context): Update.
12937         * p-exp.y (paren_depth): New global.
12938         (pascal_parse): Initialize it.
12939         * m2-exp.y (paren_depth): New global.
12940         (m2_parse): Initialize it.
12941         * go-exp.y (paren_depth): New global.
12942         (go_parse): Initialize it.
12943         * f-exp.y (paren_depth): New global.
12944         (f_parse): Initialize it.
12945         * d-exp.y (paren_depth): New global.
12946         (d_parse): Initialize it.
12947         * c-exp.y (paren_depth): New global.
12948         (c_parse): Initialize it.
12949         * ada-lex.l (paren_depth): New global.
12950         (lexer_init): Initialize it.
12951
12952 2019-04-04  Tom Tromey  <tom@tromey.com>
12953
12954         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12955         (rust_parser::convert_ast_to_type)
12956         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12957         * parser-defs.h (struct parser_state) <parser_state>: Add
12958         parameters.  Initialize new members.
12959         <expression_context_block, expression_context_pc>: New members.
12960         * parse.c (expression_context_block, expression_context_pc):
12961         Remove globals.
12962         (parse_exp_in_context): Update.
12963         * p-exp.y: Update all rules.
12964         (yylex): Update.
12965         * m2-exp.y: Update all rules.
12966         (yylex): Update.
12967         * go-exp.y (yylex): Update.
12968         * f-exp.y (yylex): Update.
12969         * d-exp.y: Update all rules.
12970         (yylex): Update.
12971         * c-exp.y: Update all rules.
12972         (lex_one_token, classify_name, yylex, c_parse): Update.
12973         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12974
12975 2019-04-04  Tom Tromey  <tom@tromey.com>
12976
12977         * gdbarch.h, gdbarch.c: Rebuild.
12978         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12979         * stap-probe.h:
12980         (struct stap_parse_info): Replace "parser_state" with
12981         "expr_builder".
12982         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12983         (parser_state): New class.
12984         * parse.c (expr_builder): Rename.
12985         (expr_builder::release): Rename.
12986         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12987         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12988         (write_exp_elt_longcst, write_exp_elt_floatcst)
12989         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12990         (write_exp_string_vector, write_exp_bitstring)
12991         (write_exp_msymbol, mark_struct_expression)
12992         (write_dollar_variable)
12993         (insert_type_address_space, increase_expout_size): Replace
12994         "parser_state" with "expr_builder".
12995         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12996         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12997         "parser_state" with "expr_builder".
12998
12999 2019-04-04  Tom Tromey  <tom@tromey.com>
13000
13001         * rust-exp.y: Replace "parse_language" with method call.
13002         * p-exp.y:
13003         (yylex): Replace "parse_language" with method call.
13004         * m2-exp.y:
13005         (yylex): Replace "parse_language" with method call.
13006         * go-exp.y (classify_name): Replace "parse_language" with method
13007         call.
13008         * f-exp.y (yylex): Replace "parse_language" with method call.
13009         * d-exp.y (lex_one_token): Replace "parse_language" with method
13010         call.
13011         * c-exp.y:
13012         (lex_one_token, classify_name, yylex): Replace "parse_language"
13013         with method call.
13014         * ada-exp.y (find_primitive_type, type_char)
13015         (type_system_address): Replace "parse_language" with method call.
13016
13017 2019-04-04  Tom Tromey  <tom@tromey.com>
13018
13019         * rust-exp.y: Replace "parse_gdbarch" with method call.
13020         * parse.c (write_dollar_variable, insert_type_address_space):
13021         Replace "parse_gdbarch" with method call.
13022         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13023         call.
13024         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13025         call.
13026         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13027         "parse_gdbarch" with method call.
13028         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13029         with method call.
13030         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13031         "parse_gdbarch" with method call.
13032         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13033         "parse_gdbarch" with method call.
13034         * c-exp.y (parse_type, parse_number, classify_name): Replace
13035         "parse_gdbarch" with method call.
13036         * ada-lex.l: Replace "parse_gdbarch" with method call.
13037         * ada-exp.y (parse_type, find_primitive_type, type_char)
13038         (type_system_address): Replace "parse_gdbarch" with method call.
13039
13040 2019-04-04  Tom Tromey  <tom@tromey.com>
13041
13042         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13043         * stap-probe.c (stap_parse_argument): Update.
13044         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13045         initial_size parameter.
13046         * rust-exp.y (rust_lex_tests): Update.
13047         * parse.c (parser_state): Update.
13048         (parse_exp_in_context): Update.
13049         * parser-defs.h (struct parser_state) <parser_state>: Remove
13050         "initial_size" parameter.
13051
13052 2019-04-04  Tom Tromey  <tom@tromey.com>
13053
13054         * parser-defs.h (increase_expout_size): Don't declare.
13055         * parse.c (increase_expout_size): Now static.
13056
13057 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13058
13059         * gnu-nat.c (gnu_nat_target::wait): Fix
13060         target_waitstatus_to_string call.
13061
13062 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13063
13064         * eval.c (evaluate_subexp_standard): Handle internal functions
13065         during Fortran function call handling.
13066
13067 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13068
13069         * NEWS: Mention new internal functions.
13070         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13071         (read_base_type): Use dwarf2_init_complex_target_type.
13072         * value.c (creal_internal_fn): New function.
13073         (cimag_internal_fn): New function.
13074         (_initialize_values): Register new internal functions.
13075
13076 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13077
13078         * infrun.c (stop_all_threads): If debug_infrun, always
13079         trace the wait status after wait_one, using
13080         target_waitstatus_to_string and target_pid_to_str.
13081         (handle_inferior_event): Replace various trace of
13082         wait status kind by a single trace.
13083         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13084         wait status kind image by target_waitstatus_to_string.
13085         * target/waitstatus.c (target_waitstatus_to_string): Fix
13086         obsolete comment.
13087
13088 2019-04-01  Tom Tromey  <tromey@adacore.com>
13089
13090         PR symtab/23331:
13091         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13092
13093 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13094             Pedro Alves  <palves@redhat.com>
13095
13096         * top.c (quit_force): Call 'finalize_values'.
13097         * value.c (finalize_values): New function.
13098         * value.h (finalize_values): Declare.
13099
13100 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13101
13102         * NEWS: Announce $_gdb_major and $_gdb_minor.
13103
13104         * top.c (init_gdb_version_vars): New function.
13105         (gdb_init): Call init_gdb_version_vars.
13106
13107 2019-03-29  Tom Tromey  <tromey@adacore.com>
13108
13109         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13110         help text.  Remove dead code.
13111
13112 2019-03-29  Keith Seitz  <keiths@redhat.com>
13113
13114         From Siddhesh Poyarekar:
13115         * f-lang.h (f77_get_upperbound): Return LONGEST.
13116         (f77_get_lowerbound): Likewise.
13117         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13118         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13119         print them.
13120         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13121         plongest to format print it.
13122         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13123         (f77_get_upperbound): Likewise.
13124         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13125         LOWER_BOUND to LONGEST.
13126         (f77_create_arrayprint_offset_tbl): Likewise.
13127
13128 2019-03-29  Keith Seitz  <keiths@redhat.com>
13129
13130         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13131         %s/pulongest for TYPE_LENGTH instead of %d in format
13132         strings.
13133         * ada-typerint.c (ada_print_type): Likewise.
13134         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13135         * compile/compile-c-support.c (generate_register_struct): Likewise.
13136         * gdbtypes.c (recursive_dump_type): Likewise.
13137         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13138         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13139         instead of %d in format strings.
13140         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13141         to std::min to ULONGEST.
13142         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13143         instead of %d in format strings.
13144         * tracepoint.c (info_scope_command): Likewise.
13145         * typeprint.c (print_offset_data::update)
13146         (print_offset_data::finish): Likewise.
13147         * xtensa-tdep.c (xtensa_store_return_value)
13148         (xtensa_push_dummy_call): Likewise.
13149
13150 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13151
13152         * windows-nat.c (display_selector): Fixed format specifications
13153         for 64-bit Cygwin.
13154
13155 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13156
13157         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13158
13159 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13160
13161         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13162         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13163         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13164         (nios2_linux_init_abi): Install it.
13165
13166 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13167
13168         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13169
13170 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13171
13172         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13173
13174 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13175             Tom Tromey  <tromey@adacore.com>
13176
13177         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13178
13179 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13180
13181         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13182         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13183         method to compute the bounds of range types. Also print "[evaluated]"
13184         if the bounds' values come from a dynamic evaluation.
13185
13186 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13187
13188         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13189         whitespace when pretty printing is on.
13190
13191 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13192
13193         * ppc-linux-nat.c: Add include.
13194
13195 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13196
13197         * NEWS: Mention AArch64 Pointer Authentication.
13198
13199 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13200
13201         * arm-linux-nat.c: Add include.
13202
13203 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13204
13205         * source-cache.c (source_cache::get_source_lines): Re-read
13206         fullname after calling open_source_file.
13207
13208 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13209
13210         * NEWS: Mention TLS support for FreeBSD.
13211
13212 2019-03-25  Tom Tromey  <tromey@adacore.com>
13213
13214         * minsyms.c (BUNCH_SIZE): Update comment.
13215         (~minimal_symbol_reader): Remove old comment.
13216         (compact_minimal_symbols): Update comment.
13217         (minimal_symbol_reader::install): Remove old comment.  Update
13218         other comments.
13219
13220 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13221
13222         * s390-linux-nat.c: Add include.
13223
13224 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13225
13226         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13227         Call linux_get_hwcap.
13228         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13229         Likewise.
13230         (aarch64_linux_get_hwcap): Remove function.
13231         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13232         declaration.
13233         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13234         linux_get_hwcap.
13235         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13236         * linux-tdep.c (linux_get_hwcap): Add function.
13237         (linux_get_hwcap2): Likewise.
13238         * linux-tdep.h (linux_get_hwcap): Add declaration.
13239         (linux_get_hwcap2): Likewise.
13240         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13241         (ppc_linux_get_hwcap2): Likewise.
13242         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13243         linux_get_hwcap.
13244         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13245         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13246         (ppc_linux_nat_target::read_description): Likewise.
13247         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13248         * s390-linux-nat.c: Likewise.
13249         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13250
13251 2019-03-24  Tom Tromey  <tom@tromey.com>
13252
13253         * ada-lang.c (standard_lookup): Simplify initialization.
13254         (ada_lookup_symbol_nonlocal): Simplify return.
13255         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13256         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13257         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13258         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13259         initialization.
13260         * solib.c (solib_global_lookup): Simplify.
13261         * symtab.c (null_block_symbol): Remove.
13262         (symbol_cache_lookup): Simplify returns.
13263         (lookup_language_this): Simplify returns.
13264         (lookup_symbol_aux): Simplify return.
13265         (lookup_local_symbol): Simplify returns.
13266         (lookup_global_symbol_from_objfile): Simplify return.
13267         (lookup_symbol_in_objfile_symtabs)
13268         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13269         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13270         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13271         * cp-namespace.c (cp_lookup_bare_symbol)
13272         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13273         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13274         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13275         (cp_lookup_symbol_via_imports): Simplify initialization.
13276         (find_symbol_in_baseclass): Likewise.
13277         * symtab.h (null_block_symbol): Remove.
13278         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13279         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13280         (d_lookup_symbol_module): Likewise.
13281         (find_symbol_in_baseclass): Simplify initialization.
13282
13283 2019-03-24  Tom Tromey  <tom@tromey.com>
13284
13285         * expression.h: Don't include symtab.h.
13286         (struct block): Forward declare.
13287
13288 2019-03-24  Tom Tromey  <tom@tromey.com>
13289
13290         * c-exp.y (typebase): Remove casts.
13291         * gdbtypes.c (lookup_unsigned_typename, )
13292         (lookup_signed_typename): Remove cast.
13293         * eval.c (parse_to_comma_and_eval): Remove cast.
13294         * parse.c (write_dollar_variable): Remove cast.
13295         * block.h (struct block) <superblock>: Now const.
13296         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13297         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13298         (map_block): Make "block" const.
13299         * symfile.h (struct quick_symbol_functions)
13300         <map_matching_symbols>: Constify block argument to "callback".
13301         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13302         const.
13303         (find_pc_sect_compunit_symtab): Make "b" const.
13304         (find_symbol_at_address): Likewise.
13305         (search_symbols): Likewise.
13306         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13307         (dw2_debug_names_lookup_symbol): Likewise.
13308         (dw2_map_matching_symbols): Update.
13309         * p-valprint.c (pascal_val_print): Remove "block".
13310         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13311         (aux_add_nonlocal_symbols): Make "block" const.
13312         (resolve_subexp): Remove cast.
13313         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13314         const.
13315         (iterate_over_file_blocks): Likewise.
13316         * f-exp.y (%union) <bval>: Remove.
13317         * coffread.c (patch_opaque_types): Make "b" const.
13318         * spu-tdep.c (spu_catch_start): Make "block" const.
13319         * c-valprint.c (print_unpacked_pointer): Remove "block".
13320         * symmisc.c (dump_symtab_1): Make "b" const.
13321         (block_depth): Make "block" const.
13322         * d-exp.y (%union) <bval>: Remove.
13323         * cp-support.h (cp_lookup_rtti_type): Update.
13324         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13325         * psymtab.c (psym_lookup_symbol): Make "block" const.
13326         (maintenance_check_psymtabs): Make "b" const.
13327         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13328         (enumerate_locals, enumerate_args): Update.
13329         * python/py-symtab.c (stpy_global_block): Make "block" const.
13330         (stpy_static_block): Likewise.
13331         * inline-frame.c (block_starting_point_at): Make "new_block"
13332         const.
13333         * block.c (find_block_in_blockvector): Make return type const.
13334         (blockvector_for_pc_sect): Make "b" const.
13335         (find_block_in_blockvector): Make "b" const.
13336
13337 2019-03-23  Tom Tromey  <tom@tromey.com>
13338
13339         * varobj.c (varobj_create): Update.
13340         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13341         * printcmd.c (display_command, do_one_display): Don't reset
13342         innermost_block.
13343         * parser-defs.h (enum innermost_block_tracker_type): Move to
13344         expression.h.
13345         (innermost_block): Update comment.
13346         * parse.c (parse_exp_1): Add tracker_types parameter.
13347         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13348         tracker_types parameter.  Reset innermost_block.
13349         (parse_exp_in_context): Remove.
13350         (parse_expression_for_completion): Update.
13351         * objfiles.c (~objfile): Don't reset expression_context_block or
13352         innermost_block.
13353         * expression.h (enum innermost_block_tracker_type): Move from
13354         parser-defs.h.
13355         (parse_exp_1): Add tracker_types parameter.
13356         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13357         reset innermost_block.
13358
13359 2019-03-23  Tom Tromey  <tom@tromey.com>
13360
13361         * objfiles.h: Include bcache.h.
13362
13363 2019-03-23  Tom Tromey  <tom@tromey.com>
13364
13365         * linespec.c (get_current_search_block): Use
13366         scoped_restore_current_language.
13367         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13368
13369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13370             Jiong Wang  <jiong.wang@arm.com>
13371
13372         * aarch64-linux-tdep.c
13373         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13374         section.
13375         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13376
13377 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13378             Jiong Wang  <jiong.wang@arm.com>
13379
13380         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13381         instructions.
13382         (aarch64_analyze_prologue_test): Add PACIASP test.
13383         (aarch64_prologue_prev_register): Unmask PC value.
13384
13385 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13386             Jiong Wang  <jiong.wang@arm.com>
13387
13388         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13389         (aarch64_dwarf2_prev_register): Unmask PC value.
13390         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13391         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13392         DW_CFA_AARCH64_negate_ra_state.
13393         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13394
13395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13396             Jiong Wang  <jiong.wang@arm.com>
13397
13398         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13399         registers.
13400         (aarch64_pseudo_register_name): Likewise.
13401         (aarch64_pseudo_register_type): Likewise.
13402         (aarch64_pseudo_register_reggroup_p): Likewise.
13403         (aarch64_gdbarch_init): Add pauth registers.
13404         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13405         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13406         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13407         (struct gdbarch_tdep): Add regnum for ra_state.
13408
13409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13410             Jiong Wang  <jiong.wang@arm.com>
13411
13412         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13413
13414 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13415             Jiong Wang  <jiong.wang@arm.com>
13416
13417         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13418         function.
13419         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13420         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13421         (aarch64_gdbarch_init): Add puth registers.
13422         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13423         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13424         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13425
13426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13427             Jiong Wang  <jiong.wang@arm.com>
13428
13429         * aarch64-linux-nat.c
13430         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13431         * aarch64-linux-tdep.c
13432         (aarch64_linux_core_read_description): Likewise.
13433         (aarch64_linux_get_hwcap): New function.
13434         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13435         (aarch64_linux_get_hwcap): New declaration.
13436
13437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13438             Jiong Wang  <jiong.wang@arm.com>
13439
13440         * aarch64-linux-nat.c
13441         (aarch64_linux_nat_target::read_description): Add pauth param.
13442         * aarch64-linux-tdep.c
13443         (aarch64_linux_core_read_description): Likewise.
13444         * aarch64-tdep.c (struct target_desc): Add in pauth.
13445         (aarch64_read_description): Add pauth param.
13446         (aarch64_gdbarch_init): Likewise.
13447         * aarch64-tdep.h (aarch64_read_description): Likewise.
13448         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13449         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13450         * features/Makefile: Add new files.
13451         * features/aarch64-pauth.c: New file.
13452         * features/aarch64-pauth.xml: New file.
13453
13454 2019-03-20  Tom Tromey  <tromey@adacore.com>
13455
13456         * infrun.c (handle_inferior_event): Rename from
13457         handle_inferior_event_1.  Create a scoped_value_mark.
13458         (handle_inferior_event): Remove.
13459
13460 2019-03-19  Tom Tromey  <tromey@adacore.com>
13461
13462         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13463         * infrun.h (print_stop_event): Add "displays" parameter.
13464         * infrun.c (print_stop_event): Add "displays" parameter.
13465
13466 2019-03-19  Pedro Alves  <palves@redhat.com>
13467
13468         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13469         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13470         to -1.  Fix TABs vs spaces.
13471         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13472         * tui/tui-out.h (tui_ui_out) Add intro comments.
13473         <m_line, m_start_of_line>: In-class initialize, and add describing
13474         comment.
13475
13476 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13477
13478         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13479         variable names.
13480         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13481
13482 2019-03-18  Pedro Alves  <palves@redhat.com>
13483             Eli Zaretskii <eliz@gnu.org>
13484
13485         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13486         m_line and m_start_of_line.
13487
13488 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13489
13490         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13491         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13492         it returns a newline.  This fixes a regression in TU mode, whereby
13493         the next line is output on the same screen line as the user input.
13494
13495 2019-03-18  Tom Tromey  <tromey@adacore.com>
13496
13497         * minsyms.c (minimal_symbol_reader::install): Remove call to
13498         obstack_blank.
13499
13500 2019-03-18  Pedro Alves  <palves@redhat.com>
13501
13502         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13503         New globals.
13504         (apply_style): New, factored out from ...
13505         (apply_ansi_escape): ... this.  Handle reverse video mode.
13506         (tui_set_reverse_mode): New function.
13507         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13508         * tui/tui-winsource.c (tui_show_source_line): Use
13509         tui_set_reverse_mode instead of setting A_STANDOUT.
13510         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13511         New setter methods.
13512
13513 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13514
13515         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13516         Handle tabs.
13517
13518 2019-03-18  Tom Tromey  <tromey@adacore.com>
13519
13520         * ada-lang.c (empty_array): Add "high" parameter.
13521         (ada_evaluate_subexp): Update.
13522
13523 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13524
13525         * unittests/string_view-selftests.c: Define
13526         _initialize_string_view_selftests unconditionally.
13527
13528 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13529
13530         PR gdb/24350
13531         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13532
13533 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13534
13535         PR gdb/24351
13536         * windows-nat.c (display_selector): Fix format specifiers.
13537
13538 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13539
13540         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13541         tui_refill_source_window instead of tui_refresh_win, to update the
13542         current execution line.  This fixes redisplay of the current line
13543         when stepping through the code with "next" or "step".
13544
13545 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13546
13547         * source-cache.c (source_cache::get_source_lines): Call
13548         find_source_lines to initialize s->nlines.  This fixes vertical
13549         scrolling of TUI source window when the DOWN arrow is pressed.
13550
13551 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13552
13553         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13554         linux-thread-db.c (_initialize_thread_db): Likewise.
13555
13556 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13557
13558         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13559         wclrtoeol in tui_show_source_line".  This reverts changes made in
13560         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13561
13562 2019-03-15  Tom Tromey  <tom@tromey.com>
13563
13564         * symtab.h (struct minimal_symbol): Derive from
13565         general_symbol_info.
13566         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13567         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13568         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13569         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13570         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13571         (MSYMBOL_SEARCH_NAME): Update.
13572         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13573         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13574         * minsyms.c (minimal_symbol_reader::record_full): Update.
13575
13576 2019-03-15  Tom Tromey  <tom@tromey.com>
13577
13578         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13579
13580 2019-03-15  Tom Tromey  <tom@tromey.com>
13581
13582         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13583         unique_xmalloc_ptr.
13584         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13585         Update.
13586         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13587         (build_minimal_symbol_hash_tables)
13588         (minimal_symbol_reader::install): Update.
13589
13590 2019-03-15  Tom Tromey  <tom@tromey.com>
13591
13592         * symtab.c (create_demangled_names_hash): Update.
13593         (symbol_set_names): Update.
13594         * objfiles.h (struct objfile_per_bfd_storage)
13595         <demangled_names_hash>: Now an htab_up.
13596         * objfiles.c (objfile_per_bfd_storage): Simplify.
13597
13598 2019-03-15  Tom Tromey  <tom@tromey.com>
13599
13600         * objfiles.h (struct objfile_per_bfd_storage): Declare
13601         destructor.
13602         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13603         New.
13604         (get_objfile_bfd_data): Use new.  Don't initialize
13605         language_of_main.
13606         (free_objfile_per_bfd_storage): Remove.
13607         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13608
13609 2019-03-15  Tom Tromey  <tom@tromey.com>
13610
13611         * symfile.c (reread_symbols): Update.
13612         * objfiles.c (objfile::objfile): Update.
13613         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13614         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13615         comment.
13616         (minimal_symbol_reader::install): Update.
13617         (terminate_minimal_symbol_table): Remove.
13618         * jit.c (jit_object_close_impl): Update.
13619
13620 2019-03-15  Tom Tromey  <tom@tromey.com>
13621
13622         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13623         initializations.
13624
13625 2019-03-15  Tom Tromey  <tom@tromey.com>
13626
13627         * objfiles.h (struct objfile_per_bfd_storage)
13628         <demangled_hash_languages>: Now a bitset.
13629         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13630         (lookup_minimal_symbol): Update.
13631
13632 2019-03-15  Tom Tromey  <tom@tromey.com>
13633
13634         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13635         Don't return the symbol.
13636         * coffread.c (record_minimal_symbol): Use record_full.
13637
13638 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13639
13640         The MS-Windows port of ncurses fails to switch to a color pair if
13641         one or both of the colors are the implicit default colors.  This
13642         change records the default colors when TUI is initialized, and
13643         then specifies them explicitly when a color pair uses the default
13644         colors.  This allows color styling in TUI mode on MS-Windows.
13645
13646         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13647         ncurses_norm_attr.
13648         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13649         colors in ncurses_norm_attr.
13650         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13651         "none", replace it with the default color recorded in
13652         ncurses_norm_attr.
13653
13654 2019-03-14  Tom Tromey  <tromey@adacore.com>
13655
13656         * source-cache.h (class source_cache) <get_source_lines>: Return
13657         std::string.
13658         * source-cache.c (source_cache::extract_lines): Handle case where
13659         first_pos==npos.  Return std::string.
13660         (source_cache::get_source_lines): Update.
13661
13662 2019-03-14  Tom Tromey  <tromey@adacore.com>
13663
13664         * NEWS: Add item for "style sources" commands.
13665         * source-cache.c (source_cache::get_source_lines): Check
13666         source_styling.
13667         * cli/cli-style.c (source_styling): New global.
13668         (_initialize_cli_style): Add "style sources" commands.
13669         (show_style_sources): New function.
13670         * cli/cli-style.h (source_styling): Declare.
13671
13672 2019-03-14  Pedro Alves  <palves@redhat.com>
13673             Tom Tromey  <tromey@adacore.com>
13674
13675         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13676         * tui/tui-winsource.c (tui_refill_source_window): New function,
13677         from...
13678         (tui_horizontal_source_scroll): ... here.  Move some logic.
13679         * cli/cli-style.c (set_style_enabled): Notify new observable.
13680         * tui/tui-hooks.c (tui_redisplay_source): New function.
13681         (tui_attach_detach_observers): Attach or detach
13682         tui_redisplay_source.
13683         * observable.h (source_styling_changed): New observable.
13684         * observable.c: Define source_styling_changed observable.
13685
13686 2019-03-13  Tom Tromey  <tromey@adacore.com>
13687
13688         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13689         (i386_gnu_nat_target::store_registers): Update.
13690         * target-debug.h (target_debug_print_std_string): New macro.
13691         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13692         * windows-tdep.c (display_one_tib): Update.
13693         * tui/tui-stack.c (tui_make_status_line): Update.
13694         * top.c (print_inferior_quit_action): Update.
13695         * thread.c (thr_try_catch_cmd): Update.
13696         (add_thread_with_info): Update.
13697         (thread_target_id_str): Update.
13698         (thr_try_catch_cmd): Update.
13699         (thread_command): Update.
13700         (thread_find_command): Update.
13701         * record-btrace.c (record_btrace_target::info_record)
13702         (record_btrace_resume_thread, record_btrace_target::resume)
13703         (record_btrace_cancel_resume, record_btrace_step_thread)
13704         (record_btrace_target::wait, record_btrace_target::wait)
13705         (record_btrace_target::wait, record_btrace_target::stop): Update.
13706         * progspace.c (print_program_space): Update.
13707         * process-stratum-target.c
13708         (process_stratum_target::thread_address_space): Update.
13709         * linux-fork.c (linux_fork_mourn_inferior)
13710         (detach_checkpoint_command, info_checkpoints_command)
13711         (linux_fork_context): Update.
13712         (linux_fork_detach): Update.
13713         (class scoped_switch_fork_info): Update.
13714         (delete_checkpoint_command): Update.
13715         * infrun.c (follow_fork_inferior): Update.
13716         (follow_fork_inferior): Update.
13717         (proceed_after_vfork_done): Update.
13718         (handle_vfork_child_exec_or_exit): Update.
13719         (follow_exec): Update.
13720         (displaced_step_prepare_throw): Update.
13721         (displaced_step_restore): Update.
13722         (start_step_over): Update.
13723         (resume_1): Update.
13724         (clear_proceed_status_thread): Update.
13725         (proceed): Update.
13726         (print_target_wait_results): Update.
13727         (do_target_wait): Update.
13728         (context_switch): Update.
13729         (stop_all_threads): Update.
13730         (restart_threads): Update.
13731         (finish_step_over): Update.
13732         (handle_signal_stop): Update.
13733         (switch_back_to_stepped_thread): Update.
13734         (keep_going_pass_signal): Update.
13735         (print_exited_reason): Update.
13736         (normal_stop): Update.
13737         * inferior.c (inferior_pid_to_str): Change return type.
13738         (print_selected_inferior): Update.
13739         (add_inferior): Update.
13740         (detach_inferior): Update.
13741         * dummy-frame.c (fprint_dummy_frames): Update.
13742         * dcache.c (dcache_info_1): Update.
13743         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13744         (btrace_fetch, btrace_clear): Update.
13745         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13746         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13747         type.
13748         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13749         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13750         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13751         * gdbarch.c, gdbarch.h: Rebuild.
13752         * gdbarch.sh (core_pid_to_str): Change return type.
13753         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13754         return type.
13755         (windows_nat_target::pid_to_str): Change return type.
13756         (windows_delete_thread): Update.
13757         (windows_nat_target::attach): Update.
13758         (windows_nat_target::files_info): Update.
13759         * target-delegates.c: Rebuild.
13760         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13761         return type.
13762         (sol_thread_target::pid_to_str): Change return type.
13763         * remote.c (class remote_target) <pid_to_str>: Change return
13764         type.
13765         (remote_target::pid_to_str): Change return type.
13766         (extended_remote_target::attach, remote_target::remote_stop_ns)
13767         (remote_target::remote_notif_remove_queued_reply)
13768         (remote_target::push_stop_reply, remote_target::disable_btrace):
13769         Update.
13770         (extended_remote_target::attach): Update.
13771         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13772         type.
13773         (gdbsim_target::pid_to_str): Change return type.
13774         * ravenscar-thread.c (struct ravenscar_thread_target)
13775         <pid_to_str>: Change return type.
13776         (ravenscar_thread_target::pid_to_str): Change return type.
13777         * procfs.c (class procfs_target) <pid_to_str>: Change return
13778         type.
13779         (procfs_target::pid_to_str): Change return type.
13780         (procfs_target::attach): Update.
13781         (procfs_target::detach): Update.
13782         (procfs_target::fetch_registers): Update.
13783         (procfs_target::store_registers): Update.
13784         (procfs_target::wait): Update.
13785         (procfs_target::files_info): Update.
13786         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13787         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13788         return type.
13789         (nto_procfs_target::pid_to_str): Change return type.
13790         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13791         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13792         return type.
13793         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13794         (exit_lwp): Update.
13795         (attach_proc_task_lwp_callback, get_detach_signal)
13796         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13797         (linux_nat_target::resume, wait_lwp, stop_callback)
13798         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13799         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13800         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13801         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13802         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13803         type.
13804         (inf_ptrace_target::attach): Update.
13805         (inf_ptrace_target::files_info): Update.
13806         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13807         type.
13808         (go32_nat_target::pid_to_str): Change return type.
13809         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13810         (gnu_nat_target::wait): Update.
13811         (gnu_nat_target::wait): Update.
13812         (gnu_nat_target::resume): Update.
13813         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13814         (fbsd_nat_target::wait): Update.
13815         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13816         type.
13817         (darwin_nat_target::attach): Update.
13818         * corelow.c (class core_target) <pid_to_str>: Change return type.
13819         (core_target::pid_to_str): Change return type.
13820         * target.c (normal_pid_to_str): Change return type.
13821         (default_pid_to_str): Likewise.
13822         (target_pid_to_str): Change return type.
13823         (target_translate_tls_address): Update.
13824         (target_announce_detach): Update.
13825         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13826         return type.
13827         (bsd_uthread_target::pid_to_str): Change return type.
13828         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13829         type.
13830         (bsd_kvm_target::pid_to_str): Change return type.
13831         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13832         return type.
13833         (aix_thread_target::pid_to_str): Change return type.
13834         * target.h (struct target_ops) <pid_to_str>: Change return type.
13835         (target_pid_to_str, normal_pid_to_str): Likewise.
13836         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13837         type.
13838         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13839         type.
13840         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13841         return type.
13842         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13843         type.
13844         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13845         type.
13846         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13847         return type.
13848
13849 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13850
13851         * NEWS: Mention that the new default MI version is 3.  Mention
13852         changes to the output of commands and events that deal with
13853         multi-location breakpoints.
13854         * breakpoint.c: Include "mi/mi-out.h".
13855         (print_one_breakpoint): Change output syntax if using MI version
13856         >= 3.
13857         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13858         New.
13859         (mi_multi_location_breakpoint_output_fixed): New.
13860         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13861         (mi_cmd_fix_multi_location_breakpoint_output): New.
13862         (mi_multi_location_breakpoint_output_fixed): New.
13863         * mi/mi-cmds.c (mi_cmds): Register command
13864         -fix-multi-location-breakpoint-output.
13865         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13866         interpreter "mi".
13867
13868 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13869
13870         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13871         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13872         instantiate mi_ui_out based on interpreter name.
13873         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13874         * mi/mi-main.c (mi_load_progress): Likewise.
13875
13876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13877
13878         * NEWS: Combine separate "New targets" sections for 8.3.
13879
13880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13881
13882         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13883         (ppcfbsd_init_abi): Install gdbarch
13884         "fetch_tls_load_module_address" and "get_thread_local_address"
13885         methods.
13886
13887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13888
13889         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13890         (riscv_fbsd_init_abi): Install gdbarch
13891         "fetch_tls_load_module_address" and "get_thread_local_address"
13892         methods.
13893
13894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13895
13896         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13897         (i386fbsd_init_abi): Install gdbarch
13898         "fetch_tls_load_module_address" and "get_thread_local_address"
13899         methods.
13900
13901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13902
13903         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13904         (amd64fbsd_init_abi): Install gdbarch
13905         "fetch_tls_load_module_address" and "get_thread_local_address"
13906         methods.
13907
13908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13909
13910         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13911         (struct fbsd_pspace_data): New type.
13912         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13913         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13914         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13915         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13916         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13917
13918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13919
13920         * gdbtypes.c (lookup_struct_elt): New function.
13921         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13922         * gdbtypes.h (struct struct_elt): New type.
13923         (lookup_struct_elt): New prototype.
13924
13925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13926
13927         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13928         remove disabled code block.
13929
13930 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13931
13932         * gdbarch.sh (get_thread_local_address): New method.
13933         * gdbarch.h, gdbarch.c: Regenerate.
13934         * target.c (target_translate_tls_address): Use
13935         gdbarch_get_thread_local_address if present instead of
13936         target::get_thread_local_address.
13937
13938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13939
13940         * target.h (target::get_thread_local_address): Update comment.
13941
13942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13943
13944         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13945         objfile->separate_debug_objfile_backlink if not NULL.
13946
13947 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13948
13949         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13950         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13951         (amd64bsd_store_inferior_registers): Likewise.
13952         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13953         Enable segment base registers.
13954         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13955         PT_GETFSBASE and PT_GETGSBASE.
13956         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13957         PT_SETGSBASE.
13958         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13959         segment base registers.
13960         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13961
13962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13963
13964         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13965         Update calls to i386_target_description to add 'segments'
13966         parameter.
13967         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13968         add segment base registers.
13969         * arch/i386.c (i386_create_target_description): Add 'segments'
13970         parameter to enable segment base registers.
13971         * arch/i386.h (i386_create_target_description): Likewise.
13972         * features/i386/32bit-segments.xml: New file.
13973         * features/i386/32bit-segments.c: Generate.
13974         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13975         call to i386_target_description to add 'segments' parameter.
13976         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13977         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13978         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13979         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13980         if feature is present.
13981         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13982         Add 'segments' parameter to call to i386_target_description.
13983         (i386_target_description): Add 'segments' parameter to enable
13984         segment base registers.
13985         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13986         to call to i386_target_description.
13987         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13988         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13989         Define I386_NUM_REGS.
13990         (i386_target_description): Add 'segments' parameter to enable
13991         segment base registers.
13992
13993 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13994
13995         PR/24325
13996         * source-cache.c: #undef open and close, to avoid unresolved
13997         externals during linking.
13998
13999 2019-03-12  Tom Tromey  <tromey@adacore.com>
14000
14001         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14002         const.  Add initializers.
14003         (_initialize_remote): Don't initialize ptid globals.
14004
14005 2019-03-12  Pedro Alves  <palves@redhat.com>
14006
14007         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14008
14009 2019-03-12  Pedro Alves  <palves@redhat.com>
14010
14011         * cp-name-parser.y (main): Remove unused 'len' variable.
14012
14013 2019-03-12  Tom Tromey  <tromey@adacore.com>
14014
14015         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14016         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14017
14018 2019-03-12  Tom Tromey  <tromey@adacore.com>
14019
14020         * linux-nat.c (iterate_over_lwps): Update.
14021         (stop_callback): Remove parameter.
14022         (stop_wait_callback, detach_callback, resume_set_callback)
14023         (select_singlestep_lwp_callback, set_ignore_sigint)
14024         (status_callback, resumed_callback, resume_clear_callback)
14025         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14026         data parameter.
14027         (linux_nat_target::detach, linux_nat_target::resume)
14028         (linux_stop_and_wait_all_lwps, select_event_lwp)
14029         (linux_nat_filter_event, linux_nat_wait_1)
14030         (linux_nat_target::kill, linux_nat_target::stop)
14031         (linux_nat_target::stop): Update.
14032         (linux_nat_resume_callback): Change type.
14033         (resume_stopped_resumed_lwps, count_events_callback)
14034         (select_event_lwp_callback): Likewise.
14035         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14036         * arm-linux-nat.c (struct update_registers_data): Remove.
14037         (update_registers_callback): Change type.
14038         (arm_linux_insert_hw_breakpoint1): Update.
14039         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14040         parameter.
14041         (x86_linux_dr_set_addr): Update.
14042         (x86_linux_dr_set_control): Update.
14043         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14044         (iterate_over_lwps): Use gdb::function_view.
14045         * nat/aarch64-linux-hw-point.c (struct
14046         aarch64_dr_update_callback_param): Remove.
14047         (debug_reg_change_callback): Change type.
14048         (aarch64_notify_debug_reg_change): Update.
14049         * s390-linux-nat.c (s390_refresh_per_info): Update.
14050
14051 2019-03-11  Tom Tromey  <tromey@adacore.com>
14052
14053         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14054         redundant assignment to "this_cu".
14055
14056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14057
14058         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14059
14060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14061
14062         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14063         from...
14064         (rank_one_type): ... this.
14065
14066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14067
14068         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14069         from...
14070         (rank_one_type): ... this.
14071
14072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14073
14074         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14075         from...
14076         (rank_one_type): ... this.
14077
14078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14079
14080         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14081         from...
14082         (rank_one_type): ... this.
14083
14084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14085
14086         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14087         from...
14088         (rank_one_type): ... this.
14089
14090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14091
14092         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14093         from...
14094         (rank_one_type): ... this.
14095
14096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14097
14098         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14099         from...
14100         (rank_one_type): ... this.
14101
14102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14103
14104         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14105         from...
14106         (rank_one_type): ... this.
14107
14108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14109
14110         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14111         from...
14112         (rank_one_type): ... this.
14113
14114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14115
14116         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14117         from...
14118         (rank_one_type): ... this.
14119
14120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14121
14122         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14123         from...
14124         (rank_one_type): ... this.
14125
14126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14127
14128         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14129         from...
14130         (rank_one_type): ... this.
14131
14132 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14133
14134         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14135         inferior-events' shows the example events.
14136
14137 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14138
14139         Support styling on native MS-Windows console
14140
14141         PR/24315
14142         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14143         on MS-Windows if $TERM is not defined.
14144
14145         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14146
14147         * posix-hdep.c (gdb_console_fputs):
14148         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14149         functions.
14150         * ui-file.h (gdb_console_fputs): Add prototype.
14151
14152         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14153         back to fputs only if the former returns zero.
14154
14155 2019-03-07  Tom Tromey  <tom@tromey.com>
14156
14157         * symmisc.c (print_symbol_bcache_statistics): Update.
14158         (print_objfile_statistics): Update.
14159         * symfile.c (allocate_symtab): Update.
14160         * stabsread.c: Don't include bcache.h.
14161         * psymtab.h (struct psymbol_bcache): Don't declare.
14162         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14163         (psymbol_bcache_init, psymbol_bcache_free)
14164         (psymbol_bcache_get_bcache): Don't declare.
14165         * psymtab.c (struct psymbol_bcache): Remove.
14166         (psymtab_storage::psymtab_storage): Update.
14167         (psymtab_storage::~psymtab_storage): Update.
14168         (psymbol_bcache_init, psymbol_bcache_free)
14169         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14170         (add_psymbol_to_bcache): Update.
14171         (allocate_psymtab): Update.
14172         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14173         macro_cache>: No longer pointers.
14174         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14175         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14176         * macrotab.c (macro_bcache): Update.
14177         * macroexp.c: Don't include bcache.h.
14178         * gdbtypes.c (check_types_worklist): Update.
14179         (types_deeply_equal): Remove TRY/CATCH.  Update.
14180         * elfread.c (elf_symtab_read): Update.
14181         * dwarf2read.c: Don't include bcache.h.
14182         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14183         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14184         (print_bcache_statistics, bcache_memory_used): Don't declare.
14185         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14186         methods.  Rename all data members.
14187         * bcache.c (struct bcache): Move to bcache.h.
14188         (bcache::expand_hash_table): Rename from expand_hash_table.
14189         (bcache): Remove.
14190         (bcache::insert): Rename from bcache_full.
14191         (bcache::compare): Rename from bcache_compare.
14192         (bcache_xmalloc): Remove.
14193         (bcache::~bcache): Rename from bcache_xfree.
14194         (bcache::print_statistics): Rename from print_bcache_statistics.
14195         (bcache::memory_used): Rename from bcache_memory_used.
14196
14197 2019-03-07  Pedro Alves  <palves@redhat.com>
14198
14199         * infrun.c (normal_stop): Also check for
14200         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14201
14202 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14203
14204         * f-lang.c (value_from_host_double): Moved to...
14205         * value.c (value_from_host_double): ...here.
14206         * value.h (value_from_host_double): Declare.
14207         * guile/scm-math.c (vlscm_convert_typed_number): Use
14208         value_from_host_double.
14209         (vlscm_convert_number): Likewise.
14210         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14211         * python/py-value.c (convert_value_from_python): Likewise.
14212
14213 2019-03-06  Tom Tromey  <tom@tromey.com>
14214
14215         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14216
14217 2019-03-06  Tom Tromey  <tom@tromey.com>
14218
14219         * utils.h (free_current_contents): Don't declare.
14220         * utils.c (free_current_contents): Remove.
14221
14222 2019-03-06  Tom Tromey  <tom@tromey.com>
14223
14224         * top.c (quit_force): Update.
14225         * main.c (captured_command_loop): Update.
14226         * common/new-op.c (operator new): Update.
14227         * common/common-exceptions.c (struct catcher)
14228         <save_cleanup_chain>: Remove member.
14229         (exceptions_state_mc_init): Update.
14230         (exception_try_scope_entry): Return nullptr.
14231         (exception_try_scope_exit, exception_rethrow)
14232         (throw_exception_sjlj, throw_exception_cxx): Update.
14233         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14234         (all_cleanups, do_cleanups, discard_cleanups)
14235         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14236         (restore_cleanups, restore_final_cleanups): Don't declare.
14237         (do_final_cleanups): Remove parameter.
14238         * common/cleanups.c (cleanup_chain, make_cleanup)
14239         (make_cleanup_dtor, all_cleanups, do_cleanups)
14240         (discard_my_cleanups, discard_cleanups)
14241         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14242         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14243         (null_cleanup): Remove.
14244         (do_final_cleanups): Remove parameter.
14245
14246 2019-03-06  Tom Tromey  <tom@tromey.com>
14247
14248         * remote.c (remote_target::remote_parse_stop_reply): Use
14249         unique_xmalloc_ptr.
14250
14251 2019-03-06  Tom Tromey  <tom@tromey.com>
14252
14253         * stabsread.c (struct stabs_field_info): Rename from field_info.
14254         <list, fnlist>: Add initializers.
14255         <obstack>: New member.
14256         (read_member_functions, read_struct_fields, read_baseclasses):
14257         Allocate on obstack.  Don't use cleanups.
14258         (read_one_struct_field, read_member_functions, read_struct_fields)
14259         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14260         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14261         (read_struct_type): Update.
14262
14263 2019-03-06  Tom Tromey  <tom@tromey.com>
14264
14265         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14266         * common/filestuff.h (make_cleanup_close): Don't declare.
14267         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14268         Remove.
14269
14270 2019-03-06  Tom Tromey  <tom@tromey.com>
14271
14272         * solib-aix.c: Use make_scope_exit.
14273
14274 2019-03-06  Tom Tromey  <tom@tromey.com>
14275
14276         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14277         Use make_scope_exit.
14278
14279 2019-03-06  Tom Tromey  <tom@tromey.com>
14280
14281         * solib-svr4.c (disable_probes_interface): Remove parameter.
14282         (svr4_handle_solib_event): Use make_scope_exit.
14283
14284 2019-03-06  Tom Tromey  <tom@tromey.com>
14285
14286         * remote.c (struct stop_reply_deleter): Remove.
14287         (stop_reply_up): Update.
14288         (struct stop_reply): Derive from notif_event.  Don't typedef.
14289         <regcache>: Now a std::vector.
14290         (stop_reply_xfree): Remove.
14291         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14292         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14293         (remote_target::discard_pending_stop_replies): Use delete.
14294         (remote_target::remote_parse_stop_reply): Update.
14295         (remote_target::process_stop_reply): Update.
14296         * remote-notif.h (struct notif_event): Add virtual destructor.
14297         Remove "dtr" member.
14298         (struct notif_client) <alloc_event>: Return a unique_ptr.
14299         (notif_event_xfree): Don't declare.
14300         (notif_event_up): New typedef.
14301         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14302         (notif_event_xfree, do_notif_event_xfree): Remove.
14303         (remote_notif_state_xfree): Update.
14304
14305 2019-03-06  Tom Tromey  <tom@tromey.com>
14306
14307         * infrun.c (displaced_step_clear_cleanup): Now a
14308         forward_scope_exit type.
14309         (displaced_step_prepare_throw): Update.
14310         (displaced_step_fixup): Update.
14311
14312 2019-03-06  Tom Tromey  <tom@tromey.com>
14313
14314         * inferior.h (class inferior): Update comment.
14315         * gdbthread.h (class thread_info): Update comment.
14316
14317 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14318             Tom Tromey  <tom@tromey.com>
14319
14320         * stabsread.h (struct stab_section_list): Remove.
14321         (coffstab_build_psymtabs): Update.
14322         * dbxread.c (symbuf_sections): Now a std::vector.
14323         (sect_idx): New global.
14324         (fill_symbuf): Update.
14325         (coffstab_build_psymtabs): Change type of stabsects parameter.
14326         Update.
14327         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14328         std::vector.
14329         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14330         (coff_locate_sections): Update.
14331         (coff_symfile_read): Remove cleanups.  Update.
14332         (init_stringtab): Add storage parameter.
14333         (free_stringtab, free_stringtab_cleanup): Remove.
14334         (init_lineno): Add storage parameter.
14335         (free_linetab, free_linetab_cleanup): Remove.
14336
14337 2019-03-06  Pedro Alves  <palves@redhat.com>
14338
14339         * linux-fork.c (fork_info::clobber_regs): Delete.
14340         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14341         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14342         comment.  Adjust.
14343         (scoped_switch_fork_info::scoped_switch_fork_info)
14344         (checkpoint_command, linux_fork_context): Adjust
14345         fork_save_infrun_state calls.
14346
14347 2019-03-06  Pedro Alves  <palves@redhat.com>
14348
14349         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14350         (inf_has_multiple_threads): Return 'bool' and rewrite using
14351         inferior_info::threads().
14352
14353 2019-03-06  Pedro Alves  <palves@redhat.com>
14354
14355         * linux-fork.c: Include <list>.
14356         (fork_list): Now a std::list instance.
14357         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14358         (forks_exist_p, find_last_fork): Adjust.
14359         (new_fork): Delete.
14360         (one_fork_p): New.
14361         (add_fork): Adjust.
14362         (free_fork): Delete, folded into fork_info::~fork_info().
14363         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14364         Adjust.
14365         (init_fork_list): Delete.
14366         (linux_fork_killall, linux_fork_mourn_inferior)
14367         (linux_fork_detach, info_checkpoints_command): Adjust.
14368         (_initialize_linux_fork): No longer call init_fork_list.
14369
14370 2019-03-06  Pedro Alves  <palves@redhat.com>
14371
14372         * linux-fork.c (new_fork): New, split out of ...
14373         (add_fork): ... this.  Return void.  Move "first fork" special
14374         case from here, to ...
14375         (checkpoint_command): ... here.
14376         * linux-linux.h (add_fork): Return void.
14377
14378 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14379
14380         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14381
14382 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14383             Chris January  <chris.january@arm.com>
14384             David Lecomber  <david.lecomber@arm.com>
14385
14386         * f-exp.y: New token, UNOP_INTRINSIC.
14387         (exp): New pattern using UNOP_INTRINSIC token.
14388         (f77_keywords): Add 'abs' keyword.
14389         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14390         (value_from_host_double): New function.
14391         (evaluate_subexp_f): Support UNOP_ABS.
14392
14393 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14394
14395         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14396         types.
14397
14398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14399
14400         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14401         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14402         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14403
14404 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14405
14406         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14407
14408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14409             Chris January  <chris.january@arm.com>
14410
14411         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14412         * f-exp.y: Define 'KIND' token.
14413         (exp): New pattern for KIND expressions.
14414         (ptype): Handle types with a kind extension.
14415         (direct_abs_decl): Extend to spot kind extensions.
14416         (f77_keywords): Add 'kind' to the list.
14417         (push_kind_type): New function.
14418         (convert_to_kind_type): New function.
14419         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14420         * parse.c (operator_length_standard): Likewise.
14421         * parser-defs.h (enum type_pieces): Add tp_kind.
14422         * std-operator.def: Add UNOP_KIND.
14423
14424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14425
14426         * f-exp.y (f_parse): Set yydebug.
14427
14428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14429
14430         * f-lang.c (evaluate_subexp_f): New function.
14431         (exp_descriptor_f): New global.
14432         (f_language_defn): Use exp_descriptor_f instead of
14433         exp_descriptor_standard.
14434
14435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14436
14437         * f-exp.y (struct token): Add comments.
14438         (dot_ops): Remove uppercase versions and the end marker.
14439         (f77_keywords): Likewise.
14440         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14441         entries in the dot_ops array are case insensitive, and use
14442         strncasecmp to compare strings.  Also some whitespace cleanup in
14443         this area.  Similar for the f77_keywords array, except entries in
14444         this list might be case sensitive.
14445
14446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14447
14448         * f-exp.y (struct f77_boolean_val): Add comments.
14449         (boolean_values): Remove uppercase versions, and end marker.
14450         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14451         and use strncasecmp to achieve case insensitivity.  Additionally,
14452         perform whitespace cleanup around this code.
14453
14454 2019-03-06  Tom Tromey  <tromey@adacore.com>
14455
14456         * remote-sim.c (gdbsim_target_open): Use result of
14457         gdb_argv::release.
14458
14459 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14460         Dirk Schubert  <dirk.schubert@arm.com>
14461         Chris January  <chris.january@arm.com>
14462
14463         * eval.c (evaluate_subexp_standard): Call Fortran argument
14464         wrapping logic.
14465         * f-lang.c (struct value): A value which can be passed into a
14466         Fortran function call.
14467         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14468         where appropriate.
14469         (struct type): Value ready for a Fortran function call.
14470         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14471         is needed.
14472         * f-lang.h (fortran_argument_convert): Declaration.
14473         (fortran_preserve_arg_pointer): Declaration.
14474         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14475
14476 2019-03-05  Tom Tromey  <tromey@adacore.com>
14477
14478         * python/py-prettyprint.c (print_string_repr): Remove #if.
14479         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14480
14481 2019-03-05  Tom Tromey  <tromey@adacore.com>
14482
14483         * target.c (the_dummy_target): Move later.  Change type to
14484         "dummy_target".
14485         (initialize_targets): Don't initialize the_dummy_target.
14486
14487 2019-03-05  Tom Tromey  <tromey@adacore.com>
14488
14489         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14490         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14491
14492 2019-03-05  Tom Tromey  <tromey@adacore.com>
14493
14494         * windows-nat.c (windows_nat_target::attach)
14495         (windows_nat_target::detach): Don't call gdb_flush.
14496         * valprint.c (generic_val_print, val_print, val_print_string):
14497         Don't call gdb_flush.
14498         * utils.c (defaulted_query): Don't call gdb_flush.
14499         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14500         * target.c (target_announce_detach): Don't call gdb_flush.
14501         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14502         * remote.c (extended_remote_target::attach): Don't call
14503         gdb_flush.
14504         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14505         * printcmd.c (do_examine): Don't call gdb_flush.
14506         (info_display_command): Don't call gdb_flush.
14507         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14508         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14509         * memattr.c (info_mem_command): Don't call gdb_flush.
14510         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14511         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14512         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14513         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14514         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14515         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14516         (gnu_nat_target::detach): Don't call gdb_flush.
14517         * f-valprint.c (f_val_print): Don't call gdb_flush.
14518         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14519         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14520         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14521         gdb_flush.
14522         * c-valprint.c (c_val_print): Don't call gdb_flush.
14523         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14524
14525 2019-03-05  Tom Tromey  <tromey@adacore.com>
14526
14527         * varobj.c (update_dynamic_varobj_children): Update.
14528         (install_default_visualizer): Use reset, not release.
14529         * value.c (set_internalvar): Update.
14530         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14531         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14532         ATTRIBUTE_UNUSED_RESULT.
14533
14534 2019-03-05  Tom Tromey  <tromey@adacore.com>
14535
14536         * remote.c (class scoped_remote_fd) <release>: Add
14537         ATTRIBUTE_UNUSED_RESULT.
14538
14539 2019-03-05  Tom Tromey  <tromey@adacore.com>
14540
14541         * macroexp.c (struct macro_buffer) <release>: Add
14542         ATTRIBUTE_UNUSED_RESULT.
14543
14544 2019-03-05  Tom Tromey  <tromey@adacore.com>
14545
14546         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14547         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14548         ATTRIBUTE_UNUSED_RESULT.
14549
14550 2019-03-05  Tom Tromey  <tromey@adacore.com>
14551
14552         * common/scoped_fd.h (class scoped_fd) <release>: Add
14553         ATTRIBUTE_UNUSED_RESULT.
14554
14555 2019-03-05  Tom Tromey  <tromey@adacore.com>
14556
14557         * parser-defs.h (struct parser_state) <release>: Add
14558         ATTRIBUTE_UNUSED_RESULT.
14559
14560 2019-03-05  Tom Tromey  <tromey@adacore.com>
14561
14562         * utils.h (class gdb_argv) <release>: Add
14563         ATTRIBUTE_UNUSED_RESULT.
14564         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14565
14566 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14567
14568         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14569         for-loop range, to avoid compiler warnings.
14570
14571         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14572         avoid compiler warnings about unused variables.
14573
14574         * NEWS: Mention end of support for native debugging on MS-Windows
14575         before XP.
14576
14577         PR gdb/24292
14578         * common/netstuff.c:
14579         * gdbserver/gdbreplay.c
14580         * gdbserver/remote-utils.c:
14581         * ser-tcp.c:
14582         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14583         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14584         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14585         'getaddrinfo' and 'freeaddrinfo' were not available before
14586         Windows XP, and mingw.org's MinGW headers by default define
14587         _WIN32_WINNT to 0x500.
14588
14589 2019-03-01  Gary Benson <gbenson@redhat.com>
14590
14591         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14592
14593 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14594             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14595
14596         PR gdb/8527
14597         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14598         set_sigint_trap, clear_sigint_trap.
14599
14600 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14601
14602         * target.c (target_detach): Clear the regcache and the
14603         frame cache.
14604
14605 2019-02-27  Pedro Alves  <palves@redhat.com>
14606
14607         * utils.c (set_screen_size): When we cap the height/width sizes,
14608         tweak the corresponding command variable to show "unlimited":
14609
14610 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14611             Pedro Alves  <palves@redhat.com>
14612
14613         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14614         before calling rl_set_screen_size.
14615
14616 2019-02-27  Tom Tromey  <tromey@adacore.com>
14617
14618         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14619         define.
14620         * python/py-value.c: Remove Python 2.4 workaround.
14621         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14622         workaround.
14623         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14624         Python 2.4 workaround.
14625         * python/python-internal.h: Remove Python 2.4 comment.
14626         (Py_ssize_t): Don't define.
14627         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14628         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14629         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14630         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14631         * python/python.c (do_start_initialization): Remove Python 2.4
14632         workaround.
14633         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14634         (print_children): Remove Python 2.4 workaround.
14635         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14636         workaround.
14637         (CHARBUFFERPROC_NAME): Remove.
14638         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14639         Python 2.4 workaround.
14640
14641 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14642
14643         * NEWS: Note minimum Python version.
14644
14645 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14646
14647         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14648         code from these functions.  Remove corresponding ifdefs.  Use
14649         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14650         Remove gotos and target of gotos.
14651         (infpy_search_memory): Likewise.
14652
14653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14654
14655         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14656         (hppa_gdbarch_init): Don't register deleted functions with
14657         gdbarch.
14658
14659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14660
14661         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14662         (h8300_unwind_sp): Delete.
14663         (h8300_dummy_id): Delete.
14664         (h8300_gdbarch_init): Don't register deleted functions with
14665         gdbarch.
14666
14667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14668
14669         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14670         (ft32_unwind_pc): Delete.
14671         (ft32_unwind_sp): Delete.
14672         (ft32_gdbarch_init): Don't register deleted functions with
14673         gdbarch.
14674
14675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14676
14677         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14678         (frv_unwind_pc): Delete.
14679         (frv_unwind_sp): Delete.
14680         (frv_gdbarch_init): Don't register deleted functions with
14681         gdbarch.
14682
14683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14684
14685         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14686         (riscv_unwind_pc): Delete.
14687         (riscv_unwind_sp): Delete.
14688         (riscv_gdbarch_init): Don't register deleted functions with
14689         gdbarch.
14690
14691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14692
14693         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14694         (csky_unwind_pc): Delete.
14695         (csky_unwind_sp): Delete.
14696         (csky_gdbarch_init): Don't register deleted functions with
14697         gdbarch.
14698
14699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14700
14701         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14702         (cris_unwind_pc): Delete.
14703         (cris_unwind_sp): Delete.
14704         (cris_gdbarch_init): Don't register deleted functions with
14705         gdbarch.
14706
14707 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14708
14709         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14710         (bfin_unwind_pc): Delete.
14711         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14712
14713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14714
14715         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14716         (arm_unwind_pc): Delete.
14717         (arm_unwind_sp): Delete.
14718         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14719
14720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14721
14722         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14723         (arc_unwind_pc): Delete.
14724         (arc_unwind_sp): Delete.
14725         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14726
14727 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14728
14729         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14730         (alpha_unwind_pc): Delete.
14731         (alpha_gdbarch_init): Don't register deleted functions with
14732         gdbarch.
14733
14734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14735
14736         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14737         (aarch64_unwind_pc): Delete.
14738         (aarch64_unwind_sp): Delete.
14739         (aarch64_gdbarch_init): Don't register deleted functions with
14740         gdbarch.
14741
14742 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14743
14744         * gdbtypes.c (type_align): Don't consider static members when
14745         computing structure alignment.
14746
14747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14748
14749         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14750         return 0 for other types.
14751         * arch-utils.c (default_type_align): Always return 0.
14752         * gdbarch.h: Regenerate.
14753         * gdbarch.sh (type_align): Extend comment.
14754         * gdbtypes.c (type_align): Add additional comments, always call
14755         gdbarch_type_align before applying the default rules.
14756         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14757         generic code will then apply a suitable default.
14758         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14759         types, return 0 for other types.
14760
14761 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14762
14763         * NEWS: Create a new section for the next release branch.
14764         Rename the section of the current branch, now that it has
14765         been cut.
14766
14767 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14768
14769         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14770         * version.in: Bump version to 8.3.50.DATE-git.
14771
14772 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14773
14774         * aix-thread.c (ptid_cmp): Remove unused variable.
14775         (get_signaled_thread): Likewise.
14776         (store_regs_user_thread): Likewise.
14777         (store_regs_kernel_thread): Likewise.
14778         (fetch_regs_kernel_thread): Remove shadowed variable.
14779
14780 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14781
14782         * features/riscv/32bit-cpu.xml: Add register numbers.
14783         * features/riscv/32bit-fpu.c: Regenerate.
14784         * features/riscv/32bit-fpu.xml: Add register numbers.
14785         * features/riscv/64bit-cpu.xml: Add register numbers.
14786         * features/riscv/64bit-fpu.c: Regenerate.
14787         * features/riscv/64bit-fpu.xml: Add register numbers.
14788
14789 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14790
14791         * NEWS: Mention two argument form of gdb.Value constructor.
14792         * python/py-value.c (convert_buffer_and_type_to_value): New
14793         function.
14794         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14795         Add support for handling an optional second argument.  Call
14796         convert_buffer_and_type_to_value as appropriate.
14797         * python/python-internal.h (Py_buffer_deleter): New struct.
14798         (Py_buffer_up): New typedef.
14799
14800 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14801
14802         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14803         instead of releasing ownership.
14804
14805 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14806
14807         * dwarf2read.c (open_and_init_dwp_file): Call
14808         elf_numsections instead of bfd_count_sections to initialize
14809         dwp_file->num_sections.
14810
14811 2019-02-25  Tom Tromey  <tromey@adacore.com>
14812
14813         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14814
14815 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14816
14817         * gcore.in: Add '--readnever' option when invoking GDB.
14818
14819 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14820
14821         * MAINTAINERS: Update my email address.
14822
14823 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14824
14825         * build-id.c (build_id_to_debug_bfd_1): New function.
14826         (build_id_to_debug_bfd): Look for separate debug file in
14827         sysroot.
14828
14829 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14830
14831         * gdbarch.sh: Update the copyright year range that is placed into
14832         generated files.
14833
14834 2019-02-22  Keith Seitz  <keiths@redhat.com>
14835
14836         PR symtab/23853
14837         * linespec.c (create_sals_line_offset): Search for the default
14838         symtab's filename instead of its fullname.
14839
14840 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14841
14842         * NEWS: Update style defaults.
14843
14844 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14845
14846         * main.c (captured_main_1): Disable styling in batch mode.
14847
14848 2019-02-20  Tom Tromey  <tom@tromey.com>
14849
14850         * symtab.c (symtab_symbol_info): Fix typos.
14851
14852 2019-02-20  Tom Tromey  <tromey@adacore.com>
14853
14854         * findcmd.c (_initialize_mem_search): Use upper case for
14855         metasyntactic variables.
14856
14857 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14858
14859         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14860         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14861
14862 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14863
14864         * top.h (source_file_name): Change to std::string.
14865         * top.c (source_file_name): Likewise.
14866         (command_line_input): Adjust.
14867         * cli/cli-script.c (script_from_file): Adjust.
14868
14869 2019-02-19  Tom Tromey  <tromey@adacore.com>
14870
14871         * ravenscar-thread.c
14872         (ravenscar_thread_target::update_thread_list): Don't call
14873         ada_build_task_list.
14874         * ada-lang.h (ada_build_task_list): Don't declare.
14875         * ada-tasks.c (struct ada_tasks_inferior_data)
14876         <task_list_valid_p>: Now bool.
14877         (read_known_tasks, ada_task_list_changed)
14878         (ada_tasks_invalidate_inferior_data): Update.
14879         (read_known_tasks_array): Return bool.
14880         (read_known_tasks_list): Likewise.
14881         (read_known_tasks): Return void.
14882         (ada_build_task_list): Now static.
14883
14884 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14885
14886         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14887         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14888
14889 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14890
14891         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14892         variant for ada_tasks_pspace_data_handle and
14893         ada_tasks_inferior_data_handle.
14894         (ada_tasks_pspace_data_cleanup): New function.
14895         (ada_tasks_inferior_data_cleanup): New function.
14896
14897 2019-02-17  Tom Tromey  <tom@tromey.com>
14898
14899         * macrotab.h (macro_source_fullname): Return a std::string.
14900         * macrotab.c (macro_include, check_for_redefinition)
14901         (macro_undef, macro_lookup_definition, foreach_macro)
14902         (foreach_macro_in_scope): Update.
14903         (macro_source_fullname): Return a std::string.
14904         * macrocmd.c (show_pp_source_pos): Update.
14905
14906 2019-02-17  Tom Tromey  <tom@tromey.com>
14907
14908         * macrocmd.c (show_pp_source_pos): Style the file names.
14909
14910 2019-02-17  Tom Tromey  <tom@tromey.com>
14911
14912         PR tui/24197:
14913         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14914
14915 2019-02-17  Tom Tromey  <tom@tromey.com>
14916
14917         * ada-lang.c (user_select_syms): Use filtered printing.
14918         * utils.c (wrap_style): New global.
14919         (desired_style): Remove.
14920         (emit_style_escape): Add stream parameter.
14921         (set_output_style, reset_terminal_style, prompt_for_continue):
14922         Update.
14923         (flush_wrap_buffer): Only flush gdb_stdout.
14924         (wrap_here): Set wrap_style.
14925         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14926         treat escape sequences as a character.  Change when wrap buffer is
14927         flushed.
14928         (fputs_styled): Do not set the output style when the default is
14929         requested.
14930         * ui-style.h (struct ui_file_style) <is_default>: New method.
14931         * source.c (print_source_lines_base): Emit escape sequences in one
14932         piece.
14933
14934 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14935
14936         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14937         integers and enumeration types.
14938
14939 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14940
14941         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14942         instead of lookup_symbol_in_language
14943         (do_exact_match): New function.
14944         (ada_get_symbol_name_matcher): Return do_exact_match when
14945         doing a verbatim match.
14946
14947 2019-02-15  Tom Tromey  <tromey@adacore.com>
14948
14949         * ravenscar-thread.c (ravenscar_thread_target::resume)
14950         (ravenscar_thread_target::wait): Special case wildcard requests.
14951
14952 2019-02-15  Tom Tromey  <tromey@adacore.com>
14953
14954         * ravenscar-thread.c (base_ptid): Remove.
14955         (struct ravenscar_thread_target) <close>: New method.
14956         <m_base_ptid>: New member.
14957         <update_inferior_ptid, active_task, task_is_currently_active,
14958         runtime_initialized>: Declare methods.
14959         <ravenscar_thread_target>: Add constructor.
14960         (ravenscar_thread_target::task_is_currently_active)
14961         (ravenscar_thread_target::update_inferior_ptid)
14962         (ravenscar_runtime_initialized): Rename.  Now methods.
14963         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14964         (ravenscar_thread_target::update_thread_list): Update.
14965         (ravenscar_thread_target::active_task): Now method.
14966         (ravenscar_thread_target::store_registers)
14967         (ravenscar_thread_target::prepare_to_store)
14968         (ravenscar_thread_target::prepare_to_store)
14969         (ravenscar_thread_target::mourn_inferior): Update.
14970         (ravenscar_inferior_created): Use "new" to create target.
14971         (ravenscar_thread_target::get_ada_task_ptid): Update.
14972         (_initialize_ravenscar): Don't initialize base_ptid.
14973         (ravenscar_ops): Remove global.
14974
14975 2019-02-15  Tom Tromey  <tromey@adacore.com>
14976
14977         * target.h (push_target): Declare new overload.
14978         * target.c (push_target): New overload, taking an rvalue reference.
14979         * remote.c (remote_target::open_1): Use push_target overload.
14980         * corelow.c (core_target_open): Use push_target overload.
14981
14982 2019-02-15  Tom Tromey  <tromey@adacore.com>
14983
14984         * ravenscar-thread.c (is_ravenscar_task)
14985         (ravenscar_task_is_currently_active): Return bool.
14986         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14987         (_initialize_ravenscar): Remove "(void)".
14988         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14989         Return bool.
14990
14991 2019-02-15  Tom Tromey  <tromey@adacore.com>
14992
14993         * ravenscar-thread.c (ravenscar_runtime_initializer)
14994         (has_ravenscar_runtime, get_running_thread_id)
14995         (ravenscar_thread_target::resume): Fix indentation.
14996
14997 2019-02-15  Tom Tromey  <tromey@adacore.com>
14998
14999         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15000         from ravenscar_arch_ops.
15001         (sparc_ravenscar_ops::fetch_registers)
15002         (sparc_ravenscar_ops::store_registers): Now methods.
15003         (sparc_ravenscar_prepare_to_store): Remove.
15004         (sparc_ravenscar_ops): Redefine.
15005         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15006         methods and destructor.  Remove members.
15007         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15008         (ravenscar_thread_target::store_registers)
15009         (ravenscar_thread_target::prepare_to_store): Update.
15010         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15011         Remove.
15012         (struct ppc_ravenscar_powerpc_ops): Derive from
15013         ravenscar_arch_ops.
15014         (ppc_ravenscar_powerpc_ops::fetch_registers)
15015         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15016         (ppc_ravenscar_powerpc_ops): Redefine.
15017         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15018         (ppc_ravenscar_e500_ops::fetch_registers)
15019         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15020         (ppc_ravenscar_e500_ops): Redefine.
15021         * aarch64-ravenscar-thread.c
15022         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15023         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15024         (aarch64_ravenscar_fetch_registers)
15025         (aarch64_ravenscar_store_registers): Now methods.
15026         (aarch64_ravenscar_ops): Redefine.
15027
15028 2019-02-15  Tom Tromey  <tromey@adacore.com>
15029
15030         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15031         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15032         (ravenscar_thread_target::stopped_by_watchpoint)
15033         (ravenscar_thread_target::stopped_data_address)
15034         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15035
15036 2019-02-15  Tom Tromey  <tromey@adacore.com>
15037
15038         * ravenscar-thread.c: Fix some typos.
15039
15040 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15041             Tom Tromey  <tromey@adacore.com>
15042
15043         * ada-lang.c (ada_exception_sal): Change addr_string to a
15044         std::string.
15045         (create_ada_exception_catchpoint): Update.
15046
15047 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15048             Tom Tromey  <tromey@adacore.com>
15049
15050         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15051         (bp_location_ops): Remove.
15052         (base_breakpoint_allocate_location): Update.
15053         (free_bp_location): Update.
15054         * ada-lang.c (class ada_catchpoint_location)
15055         <ada_catchpoint_location>: Remove ops parameter.
15056         (ada_catchpoint_location_dtor): Remove.
15057         (ada_catchpoint_location_ops): Remove.
15058         (allocate_location_exception): Update.
15059         * breakpoint.h (struct bp_location_ops): Remove.
15060         (class bp_location) <bp_location>: Remove bp_location_ops
15061         parameter.
15062         <~bp_location>: Add destructor.
15063         <ops>: Remove.
15064
15065 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15066             Pedro Alves  <palves@redhat.com>
15067
15068         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15069         'PATH_MAX'.
15070
15071 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15072             Samuel Thibault  <samuel.thibault@gnu.org>
15073             Thomas Schwinge  <thomas@codesourcery.com>
15074
15075         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15076         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15077
15078 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15079
15080         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15081         (check_empty): Use "const char *".
15082
15083         * gnu-nat.c (gnu_nat_target::detach): Instead of
15084         'detach_inferior (pid)' call
15085         'detach_inferior (find_inferior_pid (pid))'.
15086
15087         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15088         'nat/fork-inferior.o'.
15089         * gnu-nat.c: #include "nat/fork-inferior.h".
15090
15091         * gnu-nat.c (gnu_nat_target::detach): Instead of
15092         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15093         * gnu-nat.h: #include "inf-child.h".
15094         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15095         'i386_gnu_nat_target::fetch_registers'.
15096         (gnu_store_registers): Rename/move to
15097         'i386_gnu_nat_target::store_registers'.
15098
15099         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15100         * gnu-nat.h (mach_thread_info): New function.
15101         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15102
15103         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15104
15105 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15106
15107         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15108
15109 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15110
15111         * windows-nat.c (windows_add_thread): Add new parameter
15112         "main_thread_p" with default value set to false.  Update
15113         function documentation as well as all callers.
15114         (windows_delete_thread): Likewise.
15115         (fake_create_process): Update call to windows_add_thread.
15116         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15117         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15118         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15119         call to windows_delete_thread.
15120
15121 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15122
15123         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15124
15125 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15126
15127         * symfile.c (find_separate_debug_file): Use canonical path of
15128         sysroot with child_path instead of gdb_sysroot if it is valid.
15129
15130 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15131
15132         * symfile.c (find_separate_debug_file): Use child_path to
15133         determine if an object file is under a sysroot.
15134
15135 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15136
15137         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15138         unittests/child-path-selftests.c.
15139         * common/pathstuff.c (child_path): New function.
15140         * common/pathstuff.h (child_path): New prototype.
15141         * unittests/child-path-selftests.c: New file.
15142
15143 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15144
15145         * symfile.c (find_separate_debug_file): Look for separate debug
15146         files in debug directories under the sysroot.
15147
15148 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15149
15150         * symtab.h (struct minimal_symbol data_p): New const method.
15151         (struct minimal_symbol text_p): Likewise.
15152         * symtab.c (output_source_filename): Use file name style
15153         to print file name.
15154         (print_symbol_info): Likewise.
15155         (print_msymbol_info): Use address style to print addresses.
15156         Use function name style to print executable text symbols.
15157         (expand_symtab_containing_pc): Use data_p.
15158         (find_pc_sect_compunit_symtab): Likewise.
15159
15160 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15161
15162         * breakpoint.c (describe_other_breakpoints): Use address style
15163         to print addresses.
15164         (say_where): Likewise.
15165
15166 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15167
15168         * ada-typeprint.c (print_func_type): Print function name
15169         style to print function name.
15170         * c-typeprint.c (c_print_type_1): Likewise.
15171
15172 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15173
15174         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15175         for execve.
15176
15177 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15178
15179         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15180         type_stack.
15181
15182 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15183
15184         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15185         TYPE_CODE_REF types.
15186
15187 2019-02-08  Jim Wilson  <jimw@sifive.com>
15188
15189         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15190         (riscv_linux_fregset): New.
15191         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15192
15193 2019-02-07  Tom Tromey  <tom@tromey.com>
15194
15195         * thread.c (thread_cancel_execution_command): Update.
15196         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15197         methods.
15198         (struct thread_fsm_ops): Remove.
15199         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15200         (thread_fsm_should_stop, thread_fsm_return_value)
15201         (thread_fsm_set_finished, thread_fsm_finished_p)
15202         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15203         Don't declare.
15204         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15205         * infrun.c (clear_proceed_status_thread)
15206         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15207         (print_stop_event): Update.
15208         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15209         Add constructor.
15210         (step_command_fsm_ops): Remove.
15211         (new_step_command_fsm): Remove.
15212         (step_1): Update.
15213         (step_command_fsm::should_stop): Rename from
15214         step_command_fsm_should_stop.
15215         (step_command_fsm::clean_up): Rename from
15216         step_command_fsm_clean_up.
15217         (step_command_fsm::do_async_reply_reason): Rename from
15218         step_command_fsm_async_reply_reason.
15219         (struct until_next_fsm): Inherit from thread_fsm.  Add
15220         constructor.
15221         (until_next_fsm_ops): Remove.
15222         (new_until_next_fsm): Remove.
15223         (until_next_fsm::should_stop): Rename from
15224         until_next_fsm_should_stop.
15225         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15226         (until_next_fsm::do_async_reply_reason): Rename from
15227         until_next_fsm_async_reply_reason.
15228         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15229         constructor.  Change type of breakpoint.
15230         (finish_command_fsm_ops): Remove.
15231         (new_finish_command_fsm): Remove.
15232         (finish_command_fsm::should_stop): Rename from
15233         finish_command_fsm_should_stop.
15234         (finish_command_fsm::clean_up): Rename from
15235         finish_command_fsm_clean_up.
15236         (finish_command_fsm::return_value): Rename from
15237         finish_command_fsm_return_value.
15238         (finish_command_fsm::do_async_reply_reason): Rename from
15239         finish_command_fsm_async_reply_reason.
15240         (finish_command): Update.
15241         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15242         Add constructor.
15243         (call_thread_fsm_ops): Remove.
15244         (call_thread_fsm::call_thread_fsm): Rename from
15245         new_call_thread_fsm.
15246         (call_thread_fsm::should_stop): Rename from
15247         call_thread_fsm_should_stop.
15248         (call_thread_fsm::should_notify_stop): Rename from
15249         call_thread_fsm_should_notify_stop.
15250         (run_inferior_call, call_function_by_hand_dummy): Update.
15251         * cli/cli-interp.c (should_print_stop_to_console): Update.
15252         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15253         Add constructor.  Change type of location_breakpoint,
15254         caller_breakpoint.
15255         (until_break_fsm_ops): Remove.
15256         (new_until_break_fsm): Remove.
15257         (until_break_fsm::should_stop): Rename from
15258         until_break_fsm_should_stop.
15259         (until_break_fsm::clean_up): Rename from
15260         until_break_fsm_clean_up.
15261         (until_break_fsm::do_async_reply_reason): Rename from
15262         until_break_fsm_async_reply_reason.
15263         (until_break_command): Update.
15264         * thread-fsm.c: Remove.
15265         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15266
15267 2019-02-07  Tom Tromey  <tom@tromey.com>
15268
15269         * yy-remap.h: Add include guard.
15270         * xtensa-tdep.h: Add include guard.
15271         * xcoffread.h: Rename include guard.
15272         * varobj-iter.h: Add include guard.
15273         * tui/tui.h: Rename include guard.
15274         * tui/tui-winsource.h: Rename include guard.
15275         * tui/tui-wingeneral.h: Rename include guard.
15276         * tui/tui-windata.h: Rename include guard.
15277         * tui/tui-win.h: Rename include guard.
15278         * tui/tui-stack.h: Rename include guard.
15279         * tui/tui-source.h: Rename include guard.
15280         * tui/tui-regs.h: Rename include guard.
15281         * tui/tui-out.h: Rename include guard.
15282         * tui/tui-layout.h: Rename include guard.
15283         * tui/tui-io.h: Rename include guard.
15284         * tui/tui-hooks.h: Rename include guard.
15285         * tui/tui-file.h: Rename include guard.
15286         * tui/tui-disasm.h: Rename include guard.
15287         * tui/tui-data.h: Rename include guard.
15288         * tui/tui-command.h: Rename include guard.
15289         * tic6x-tdep.h: Add include guard.
15290         * target/waitstatus.h: Rename include guard.
15291         * target/wait.h: Rename include guard.
15292         * target/target.h: Rename include guard.
15293         * target/resume.h: Rename include guard.
15294         * target-float.h: Rename include guard.
15295         * stabsread.h: Add include guard.
15296         * rs6000-tdep.h: Add include guard.
15297         * riscv-fbsd-tdep.h: Add include guard.
15298         * regformats/regdef.h: Rename include guard.
15299         * record.h: Rename include guard.
15300         * python/python.h: Rename include guard.
15301         * python/python-internal.h: Rename include guard.
15302         * python/py-stopevent.h: Rename include guard.
15303         * python/py-ref.h: Rename include guard.
15304         * python/py-record.h: Rename include guard.
15305         * python/py-record-full.h: Rename include guard.
15306         * python/py-record-btrace.h: Rename include guard.
15307         * python/py-instruction.h: Rename include guard.
15308         * python/py-events.h: Rename include guard.
15309         * python/py-event.h: Rename include guard.
15310         * procfs.h: Add include guard.
15311         * proc-utils.h: Add include guard.
15312         * p-lang.h: Add include guard.
15313         * or1k-tdep.h: Rename include guard.
15314         * observable.h: Rename include guard.
15315         * nto-tdep.h: Rename include guard.
15316         * nat/x86-linux.h: Rename include guard.
15317         * nat/x86-linux-dregs.h: Rename include guard.
15318         * nat/x86-gcc-cpuid.h: Add include guard.
15319         * nat/x86-dregs.h: Rename include guard.
15320         * nat/x86-cpuid.h: Rename include guard.
15321         * nat/ppc-linux.h: Rename include guard.
15322         * nat/mips-linux-watch.h: Rename include guard.
15323         * nat/linux-waitpid.h: Rename include guard.
15324         * nat/linux-ptrace.h: Rename include guard.
15325         * nat/linux-procfs.h: Rename include guard.
15326         * nat/linux-osdata.h: Rename include guard.
15327         * nat/linux-nat.h: Rename include guard.
15328         * nat/linux-namespaces.h: Rename include guard.
15329         * nat/linux-btrace.h: Rename include guard.
15330         * nat/glibc_thread_db.h: Rename include guard.
15331         * nat/gdb_thread_db.h: Rename include guard.
15332         * nat/gdb_ptrace.h: Rename include guard.
15333         * nat/fork-inferior.h: Rename include guard.
15334         * nat/amd64-linux-siginfo.h: Rename include guard.
15335         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15336         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15337         * nat/aarch64-linux.h: Rename include guard.
15338         * nat/aarch64-linux-hw-point.h: Rename include guard.
15339         * mn10300-tdep.h: Add include guard.
15340         * mips-linux-tdep.h: Add include guard.
15341         * mi/mi-parse.h: Rename include guard.
15342         * mi/mi-out.h: Rename include guard.
15343         * mi/mi-main.h: Rename include guard.
15344         * mi/mi-interp.h: Rename include guard.
15345         * mi/mi-getopt.h: Rename include guard.
15346         * mi/mi-console.h: Rename include guard.
15347         * mi/mi-common.h: Rename include guard.
15348         * mi/mi-cmds.h: Rename include guard.
15349         * mi/mi-cmd-break.h: Rename include guard.
15350         * m2-lang.h: Add include guard.
15351         * location.h: Rename include guard.
15352         * linux-record.h: Rename include guard.
15353         * linux-nat.h: Add include guard.
15354         * linux-fork.h: Add include guard.
15355         * i386-darwin-tdep.h: Rename include guard.
15356         * hppa-linux-offsets.h: Add include guard.
15357         * guile/guile.h: Rename include guard.
15358         * guile/guile-internal.h: Rename include guard.
15359         * gnu-nat.h: Rename include guard.
15360         * gdb-stabs.h: Rename include guard.
15361         * frv-tdep.h: Add include guard.
15362         * f-lang.h: Add include guard.
15363         * event-loop.h: Add include guard.
15364         * darwin-nat.h: Rename include guard.
15365         * cp-abi.h: Rename include guard.
15366         * config/sparc/nm-sol2.h: Rename include guard.
15367         * config/nm-nto.h: Rename include guard.
15368         * config/nm-linux.h: Add include guard.
15369         * config/i386/nm-i386gnu.h: Rename include guard.
15370         * config/djgpp/nl_types.h: Rename include guard.
15371         * config/djgpp/langinfo.h: Rename include guard.
15372         * compile/gcc-cp-plugin.h: Add include guard.
15373         * compile/gcc-c-plugin.h: Add include guard.
15374         * compile/compile.h: Rename include guard.
15375         * compile/compile-object-run.h: Rename include guard.
15376         * compile/compile-object-load.h: Rename include guard.
15377         * compile/compile-internal.h: Rename include guard.
15378         * compile/compile-cplus.h: Rename include guard.
15379         * compile/compile-c.h: Rename include guard.
15380         * common/xml-utils.h: Rename include guard.
15381         * common/x86-xstate.h: Rename include guard.
15382         * common/version.h: Rename include guard.
15383         * common/vec.h: Rename include guard.
15384         * common/tdesc.h: Rename include guard.
15385         * common/selftest.h: Rename include guard.
15386         * common/scoped_restore.h: Rename include guard.
15387         * common/scoped_mmap.h: Rename include guard.
15388         * common/scoped_fd.h: Rename include guard.
15389         * common/safe-iterator.h: Rename include guard.
15390         * common/run-time-clock.h: Rename include guard.
15391         * common/refcounted-object.h: Rename include guard.
15392         * common/queue.h: Rename include guard.
15393         * common/ptid.h: Rename include guard.
15394         * common/print-utils.h: Rename include guard.
15395         * common/preprocessor.h: Rename include guard.
15396         * common/pathstuff.h: Rename include guard.
15397         * common/observable.h: Rename include guard.
15398         * common/netstuff.h: Rename include guard.
15399         * common/job-control.h: Rename include guard.
15400         * common/host-defs.h: Rename include guard.
15401         * common/gdb_wait.h: Rename include guard.
15402         * common/gdb_vecs.h: Rename include guard.
15403         * common/gdb_unlinker.h: Rename include guard.
15404         * common/gdb_unique_ptr.h: Rename include guard.
15405         * common/gdb_tilde_expand.h: Rename include guard.
15406         * common/gdb_sys_time.h: Rename include guard.
15407         * common/gdb_string_view.h: Rename include guard.
15408         * common/gdb_splay_tree.h: Rename include guard.
15409         * common/gdb_setjmp.h: Rename include guard.
15410         * common/gdb_ref_ptr.h: Rename include guard.
15411         * common/gdb_optional.h: Rename include guard.
15412         * common/gdb_locale.h: Rename include guard.
15413         * common/gdb_assert.h: Rename include guard.
15414         * common/filtered-iterator.h: Rename include guard.
15415         * common/filestuff.h: Rename include guard.
15416         * common/fileio.h: Rename include guard.
15417         * common/environ.h: Rename include guard.
15418         * common/common-utils.h: Rename include guard.
15419         * common/common-types.h: Rename include guard.
15420         * common/common-regcache.h: Rename include guard.
15421         * common/common-inferior.h: Rename include guard.
15422         * common/common-gdbthread.h: Rename include guard.
15423         * common/common-exceptions.h: Rename include guard.
15424         * common/common-defs.h: Rename include guard.
15425         * common/common-debug.h: Rename include guard.
15426         * common/cleanups.h: Rename include guard.
15427         * common/buffer.h: Rename include guard.
15428         * common/btrace-common.h: Rename include guard.
15429         * common/break-common.h: Rename include guard.
15430         * cli/cli-utils.h: Rename include guard.
15431         * cli/cli-style.h: Rename include guard.
15432         * cli/cli-setshow.h: Rename include guard.
15433         * cli/cli-script.h: Rename include guard.
15434         * cli/cli-interp.h: Rename include guard.
15435         * cli/cli-decode.h: Rename include guard.
15436         * cli/cli-cmds.h: Rename include guard.
15437         * charset-list.h: Add include guard.
15438         * buildsym-legacy.h: Rename include guard.
15439         * bfin-tdep.h: Add include guard.
15440         * ax.h: Rename include guard.
15441         * arm-linux-tdep.h: Add include guard.
15442         * arm-fbsd-tdep.h: Add include guard.
15443         * arch/xtensa.h: Rename include guard.
15444         * arch/tic6x.h: Add include guard.
15445         * arch/i386.h: Add include guard.
15446         * arch/arm.h: Rename include guard.
15447         * arch/arm-linux.h: Rename include guard.
15448         * arch/arm-get-next-pcs.h: Rename include guard.
15449         * arch/amd64.h: Add include guard.
15450         * arch/aarch64-insn.h: Rename include guard.
15451         * arch-utils.h: Rename include guard.
15452         * annotate.h: Add include guard.
15453         * amd64-darwin-tdep.h: Rename include guard.
15454         * aarch64-linux-tdep.h: Add include guard.
15455         * aarch64-fbsd-tdep.h: Add include guard.
15456         * aarch32-linux-nat.h: Add include guard.
15457
15458 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15459
15460         * macrotab.c (macro_define_internal): New function that
15461         factorizes macro_define_object_internal and macro_define_function
15462         code.
15463         (macro_define_object_internal): Use macro_define_internal.
15464         (macro_define_function): Likewise.
15465
15466 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15467
15468         * macrocmd.c (extract_identifier): Return
15469         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15470         callers.
15471
15472 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15473
15474         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15475
15476 2019-02-05  Tom Tromey  <tom@tromey.com>
15477
15478         * target.c (target_stack::unpush): Move assertion earlier.
15479
15480 2019-01-30  Tom Tromey  <tom@tromey.com>
15481
15482         PR python/23615:
15483         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15484         (gdbpy_parse_and_eval): Likewise.
15485         * python/python-internal.h (gdbpy_allow_threads): New class.
15486
15487 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15488
15489         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15490         (aarch64_fbsd_fpregmap): Move earlier.
15491         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15492         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15493         instead of individual calls to trad_frame_set_reg_addr.
15494         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15495         earlier.
15496         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15497         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15498         instead of individual calls to trad_frame_set_reg_addr.
15499
15500 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15501
15502         * CONTRIBUTE: Replace contribution list with wiki link.
15503
15504 2019-01-25  Tom Tromey  <tom@tromey.com>
15505
15506         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15507
15508 2019-01-25  Tom Tromey  <tom@tromey.com>
15509
15510         * xtensa-linux-nat.c: Fix common/ includes.
15511         * xml-support.h: Fix common/ includes.
15512         * xml-support.c: Fix common/ includes.
15513         * x86-linux-nat.c: Fix common/ includes.
15514         * windows-nat.c: Fix common/ includes.
15515         * varobj.h: Fix common/ includes.
15516         * varobj.c: Fix common/ includes.
15517         * value.c: Fix common/ includes.
15518         * valops.c: Fix common/ includes.
15519         * utils.c: Fix common/ includes.
15520         * unittests/xml-utils-selftests.c: Fix common/ includes.
15521         * unittests/utils-selftests.c: Fix common/ includes.
15522         * unittests/unpack-selftests.c: Fix common/ includes.
15523         * unittests/tracepoint-selftests.c: Fix common/ includes.
15524         * unittests/style-selftests.c: Fix common/ includes.
15525         * unittests/string_view-selftests.c: Fix common/ includes.
15526         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15527         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15528         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15529         * unittests/rsp-low-selftests.c: Fix common/ includes.
15530         * unittests/parse-connection-spec-selftests.c: Fix common/
15531         includes.
15532         * unittests/optional-selftests.c: Fix common/ includes.
15533         * unittests/offset-type-selftests.c: Fix common/ includes.
15534         * unittests/observable-selftests.c: Fix common/ includes.
15535         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15536         * unittests/memrange-selftests.c: Fix common/ includes.
15537         * unittests/memory-map-selftests.c: Fix common/ includes.
15538         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15539         * unittests/function-view-selftests.c: Fix common/ includes.
15540         * unittests/environ-selftests.c: Fix common/ includes.
15541         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15542         * unittests/common-utils-selftests.c: Fix common/ includes.
15543         * unittests/cli-utils-selftests.c: Fix common/ includes.
15544         * unittests/array-view-selftests.c: Fix common/ includes.
15545         * ui-file.c: Fix common/ includes.
15546         * tui/tui-io.c: Fix common/ includes.
15547         * tracepoint.h: Fix common/ includes.
15548         * tracepoint.c: Fix common/ includes.
15549         * tracefile-tfile.c: Fix common/ includes.
15550         * top.h: Fix common/ includes.
15551         * top.c: Fix common/ includes.
15552         * thread.c: Fix common/ includes.
15553         * target/waitstatus.h: Fix common/ includes.
15554         * target/waitstatus.c: Fix common/ includes.
15555         * target.h: Fix common/ includes.
15556         * target.c: Fix common/ includes.
15557         * target-memory.c: Fix common/ includes.
15558         * target-descriptions.c: Fix common/ includes.
15559         * symtab.h: Fix common/ includes.
15560         * symfile.c: Fix common/ includes.
15561         * stap-probe.c: Fix common/ includes.
15562         * spu-linux-nat.c: Fix common/ includes.
15563         * sparc-nat.c: Fix common/ includes.
15564         * source.c: Fix common/ includes.
15565         * solib.c: Fix common/ includes.
15566         * solib-target.c: Fix common/ includes.
15567         * ser-unix.c: Fix common/ includes.
15568         * ser-tcp.c: Fix common/ includes.
15569         * ser-pipe.c: Fix common/ includes.
15570         * ser-base.c: Fix common/ includes.
15571         * selftest-arch.c: Fix common/ includes.
15572         * s12z-tdep.c: Fix common/ includes.
15573         * rust-exp.y: Fix common/ includes.
15574         * rs6000-aix-tdep.c: Fix common/ includes.
15575         * riscv-tdep.c: Fix common/ includes.
15576         * remote.c: Fix common/ includes.
15577         * remote-notif.h: Fix common/ includes.
15578         * remote-fileio.h: Fix common/ includes.
15579         * remote-fileio.c: Fix common/ includes.
15580         * regcache.h: Fix common/ includes.
15581         * regcache.c: Fix common/ includes.
15582         * record-btrace.c: Fix common/ includes.
15583         * python/python.c: Fix common/ includes.
15584         * python/py-type.c: Fix common/ includes.
15585         * python/py-inferior.c: Fix common/ includes.
15586         * progspace.h: Fix common/ includes.
15587         * producer.c: Fix common/ includes.
15588         * procfs.c: Fix common/ includes.
15589         * proc-api.c: Fix common/ includes.
15590         * printcmd.c: Fix common/ includes.
15591         * ppc-linux-nat.c: Fix common/ includes.
15592         * parser-defs.h: Fix common/ includes.
15593         * osdata.c: Fix common/ includes.
15594         * obsd-nat.c: Fix common/ includes.
15595         * nat/x86-linux.c: Fix common/ includes.
15596         * nat/x86-linux-dregs.c: Fix common/ includes.
15597         * nat/x86-dregs.h: Fix common/ includes.
15598         * nat/x86-dregs.c: Fix common/ includes.
15599         * nat/ppc-linux.c: Fix common/ includes.
15600         * nat/mips-linux-watch.h: Fix common/ includes.
15601         * nat/mips-linux-watch.c: Fix common/ includes.
15602         * nat/linux-waitpid.c: Fix common/ includes.
15603         * nat/linux-ptrace.h: Fix common/ includes.
15604         * nat/linux-ptrace.c: Fix common/ includes.
15605         * nat/linux-procfs.c: Fix common/ includes.
15606         * nat/linux-personality.c: Fix common/ includes.
15607         * nat/linux-osdata.c: Fix common/ includes.
15608         * nat/linux-namespaces.c: Fix common/ includes.
15609         * nat/linux-btrace.h: Fix common/ includes.
15610         * nat/linux-btrace.c: Fix common/ includes.
15611         * nat/fork-inferior.c: Fix common/ includes.
15612         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15613         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15614         * nat/aarch64-linux.c: Fix common/ includes.
15615         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15616         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15617         * namespace.h: Fix common/ includes.
15618         * mips-linux-tdep.c: Fix common/ includes.
15619         * minsyms.c: Fix common/ includes.
15620         * mi/mi-parse.h: Fix common/ includes.
15621         * mi/mi-main.c: Fix common/ includes.
15622         * mi/mi-cmd-env.c: Fix common/ includes.
15623         * memrange.h: Fix common/ includes.
15624         * memattr.c: Fix common/ includes.
15625         * maint.h: Fix common/ includes.
15626         * maint.c: Fix common/ includes.
15627         * main.c: Fix common/ includes.
15628         * machoread.c: Fix common/ includes.
15629         * location.c: Fix common/ includes.
15630         * linux-thread-db.c: Fix common/ includes.
15631         * linux-nat.c: Fix common/ includes.
15632         * linux-fork.c: Fix common/ includes.
15633         * inline-frame.c: Fix common/ includes.
15634         * infrun.c: Fix common/ includes.
15635         * inflow.c: Fix common/ includes.
15636         * inferior.h: Fix common/ includes.
15637         * inferior.c: Fix common/ includes.
15638         * infcmd.c: Fix common/ includes.
15639         * inf-ptrace.c: Fix common/ includes.
15640         * inf-child.c: Fix common/ includes.
15641         * ia64-linux-nat.c: Fix common/ includes.
15642         * i387-tdep.c: Fix common/ includes.
15643         * i386-tdep.c: Fix common/ includes.
15644         * i386-linux-tdep.c: Fix common/ includes.
15645         * i386-linux-nat.c: Fix common/ includes.
15646         * i386-go32-tdep.c: Fix common/ includes.
15647         * i386-fbsd-tdep.c: Fix common/ includes.
15648         * i386-fbsd-nat.c: Fix common/ includes.
15649         * guile/scm-type.c: Fix common/ includes.
15650         * guile/guile.c: Fix common/ includes.
15651         * go32-nat.c: Fix common/ includes.
15652         * gnu-nat.c: Fix common/ includes.
15653         * gdbthread.h: Fix common/ includes.
15654         * gdbarch-selftests.c: Fix common/ includes.
15655         * gdb_usleep.c: Fix common/ includes.
15656         * gdb_select.h: Fix common/ includes.
15657         * gdb_bfd.c: Fix common/ includes.
15658         * gcore.c: Fix common/ includes.
15659         * fork-child.c: Fix common/ includes.
15660         * findvar.c: Fix common/ includes.
15661         * fbsd-nat.c: Fix common/ includes.
15662         * event-top.c: Fix common/ includes.
15663         * event-loop.c: Fix common/ includes.
15664         * dwarf2read.c: Fix common/ includes.
15665         * dwarf2loc.c: Fix common/ includes.
15666         * dwarf2-frame.c: Fix common/ includes.
15667         * dwarf-index-cache.c: Fix common/ includes.
15668         * dtrace-probe.c: Fix common/ includes.
15669         * disasm-selftests.c: Fix common/ includes.
15670         * defs.h: Fix common/ includes.
15671         * csky-tdep.c: Fix common/ includes.
15672         * cp-valprint.c: Fix common/ includes.
15673         * cp-support.h: Fix common/ includes.
15674         * cp-support.c: Fix common/ includes.
15675         * corelow.c: Fix common/ includes.
15676         * completer.h: Fix common/ includes.
15677         * completer.c: Fix common/ includes.
15678         * compile/compile.c: Fix common/ includes.
15679         * compile/compile-loc2c.c: Fix common/ includes.
15680         * compile/compile-cplus-types.c: Fix common/ includes.
15681         * compile/compile-cplus-symbols.c: Fix common/ includes.
15682         * command.h: Fix common/ includes.
15683         * cli/cli-dump.c: Fix common/ includes.
15684         * cli/cli-cmds.c: Fix common/ includes.
15685         * charset.c: Fix common/ includes.
15686         * build-id.c: Fix common/ includes.
15687         * btrace.h: Fix common/ includes.
15688         * btrace.c: Fix common/ includes.
15689         * breakpoint.h: Fix common/ includes.
15690         * breakpoint.c: Fix common/ includes.
15691         * ax.h:
15692         (enum agent_op): Fix common/ includes.
15693         * ax-general.c (struct aop_map): Fix common/ includes.
15694         * ax-gdb.c: Fix common/ includes.
15695         * auxv.c: Fix common/ includes.
15696         * auto-load.c: Fix common/ includes.
15697         * arm-tdep.c: Fix common/ includes.
15698         * arch/riscv.c: Fix common/ includes.
15699         * arch/ppc-linux-common.c: Fix common/ includes.
15700         * arch/i386.c: Fix common/ includes.
15701         * arch/arm.c: Fix common/ includes.
15702         * arch/arm-linux.c: Fix common/ includes.
15703         * arch/arm-get-next-pcs.c: Fix common/ includes.
15704         * arch/amd64.c: Fix common/ includes.
15705         * arch/aarch64.c: Fix common/ includes.
15706         * arch/aarch64-insn.c: Fix common/ includes.
15707         * arch-utils.c: Fix common/ includes.
15708         * amd64-windows-tdep.c: Fix common/ includes.
15709         * amd64-tdep.c: Fix common/ includes.
15710         * amd64-sol2-tdep.c: Fix common/ includes.
15711         * amd64-obsd-tdep.c: Fix common/ includes.
15712         * amd64-nbsd-tdep.c: Fix common/ includes.
15713         * amd64-linux-tdep.c: Fix common/ includes.
15714         * amd64-linux-nat.c: Fix common/ includes.
15715         * amd64-fbsd-tdep.c: Fix common/ includes.
15716         * amd64-fbsd-nat.c: Fix common/ includes.
15717         * amd64-dicos-tdep.c: Fix common/ includes.
15718         * amd64-darwin-tdep.c: Fix common/ includes.
15719         * agent.c: Fix common/ includes.
15720         * ada-lang.h: Fix common/ includes.
15721         * ada-lang.c: Fix common/ includes.
15722         * aarch64-tdep.c: Fix common/ includes.
15723
15724 2019-01-25  Tom Tromey  <tom@tromey.com>
15725
15726         * common/create-version.sh: Use common/version.h.
15727
15728 2019-01-24  Pedro Alves  <palves@redhat.com>
15729
15730         * infrun.c (signal_stop, signal_print, signal_program)
15731         (signal_catch, signal_pass): Now arrays instead of pointers.
15732         (update_signals_program_target, do_target_resume)
15733         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15734         * linux-nat.c (linux_nat_target::pass_signals)
15735         (linux_nat_target::create_inferior, linux_nat_target::attach):
15736         Adjust.
15737         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15738         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15739         * procfs.c (procfs_target::pass_signals): Adjust.
15740         * record-full.c (record_full_target::resume): Adjust.
15741         * remote.c (remote_target::pass_signals)
15742         (remote_target::program_signals): Adjust.
15743         * target-debug.h (target_debug_print_signals): Now takes a
15744         gdb::array_view as parameter.  Adjust.
15745         * target.h (target_ops) <pass_signals, program_signals>: Replace
15746         pointer and length parameters with gdb::array_view.
15747         (target_pass_signals, target_program_signals): Likewise.
15748         * target-delegates.c: Regenerate.
15749
15750 2019-01-24  Pedro Alves  <palves@redhat.com>
15751
15752         * common/forward-scope-exit.h
15753         (forward_scope_exit::forward_scope_exit): Pass arguments to
15754         m_bind_function directly, instead of creating a std::bind and
15755         copying that.
15756
15757 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15758
15759         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15760         for static members.
15761         (pass_in_v_vfp_candidate): Likewise.
15762
15763 2019-01-23  Tom Tromey  <tom@tromey.com>
15764             Pedro Alves  <palves@redhat.com>
15765
15766         * regcache.c (class regcache_invalidator): Remove.
15767         (regcache::raw_write): Use make_scope_exit.
15768
15769 2019-01-23  Tom Tromey  <tom@tromey.com>
15770
15771         * ui-out.h (class ui_out_emit_type): Update comment.
15772
15773 2019-01-23  Tom Tromey  <tom@tromey.com>
15774
15775         * infrun.c (fetch_inferior_event): Update comment.
15776
15777 2019-01-23  Tom Tromey  <tom@tromey.com>
15778             Pedro Alves  <palves@redhat.com>
15779
15780         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15781         parameter.
15782         (fetch_inferior_event): Use SCOPE_EXIT.
15783
15784
15785 2019-01-23  Tom Tromey  <tom@tromey.com>
15786             Pedro Alves  <palves@redhat.com>
15787
15788         * infrun.c (disable_thread_events): Delete.
15789         (stop_all_threads): Use SCOPE_EXIT.
15790
15791 2019-01-23  Tom Tromey  <tom@tromey.com>
15792             Pedro Alves  <palves@redhat.com>
15793
15794         * symfile.c: Include forward-scope-exit.h.
15795         (clear_symtab_users_cleanup): Replace forward declaration with
15796         a FORWARD_SCOPE_EXIT.
15797         (syms_from_objfile_1): Use the forward_scope_exit and
15798         gdb::optional instead of cleanup_function.
15799         (reread_symbols): Use the forward_scope_exit instead of
15800         cleanup_function.
15801         (clear_symtab_users_cleanup): Remove function.
15802
15803 2019-01-23  Tom Tromey  <tom@tromey.com>
15804             Pedro Alves  <palves@redhat.com>
15805
15806         * linux-nat.c: Include scope-exit.h.
15807         (cleanup_target_stop): Remove.
15808         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15809         SCOPE_EXIT.
15810
15811 2019-01-23  Tom Tromey  <tom@tromey.com>
15812             Pedro Alves  <palves@redhat.com>
15813
15814         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15815         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15816
15817 2019-01-23  Tom Tromey  <tom@tromey.com>
15818             Andrew Burgess  <andrew.burgess@embecosm.com>
15819             Pedro Alves  <palves@redhat.com>
15820
15821         * infrun.c (fetch_inferior_event): Use scope_exit.
15822         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15823         * top.c (execute_command): Use scope_exit.
15824         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15825         * utils.c (do_bpstat_clear_actions_cleanup)
15826         (make_bpstat_clear_actions_cleanup): Remove.
15827
15828 2019-01-23  Tom Tromey  <tom@tromey.com>
15829             Pedro Alves  <palves@redhat.com>
15830
15831         * infrun.c: Include "common/scope-exit.h"
15832         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15833         (wait_for_inferior): Use SCOPE_EXIT.
15834         (fetch_inferior_event): Use scope_exit.
15835
15836 2019-01-23  Tom Tromey  <tom@tromey.com>
15837             Pedro Alves  <palves@redhat.com>
15838
15839         * breakpoint.c (create_breakpoint): Remove cleanup.
15840
15841 2019-01-23  Tom Tromey  <tom@tromey.com>
15842             Andrew Burgess  <andrew.burgess@embecosm.com>
15843             Pedro Alves  <palves@redhat.com>
15844
15845 2019-01-23  Pedro Alves  <palves@redhat.com>
15846
15847         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15848
15849 2019-01-23  Pedro Alves  <palves@redhat.com>
15850             Andrew Burgess  <andrew.burgess@embecosm.com>
15851
15852         * gdbthread.h: Include "common/forward-scope-exit.h".
15853         (scoped_finish_thread_state): Redefine custom class in terms of
15854         forward_scope_exit.
15855
15856 2019-01-23  Pedro Alves  <palves@redhat.com>
15857             Andrew Burgess  <andrew.burgess@embecosm.com>
15858
15859         * common/forward-scope-exit.h: New file.
15860
15861 2019-01-23  Pedro Alves  <palves@redhat.com>
15862             Andrew Burgess  <andrew.burgess@embecosm.com>
15863             Tom Tromey  <tom@tromey.com>
15864
15865         * common/scope-exit.h: New file.
15866
15867 2019-01-23  Pedro Alves  <palves@redhat.com>
15868
15869         * common/preprocessor.h (ESC): Rename to ...
15870         (ESC_PARENS): ... this.
15871         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15872         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15873
15874 2019-01-23  Tom Tromey  <tom@tromey.com>
15875
15876         * language.h (class scoped_switch_to_sym_language_if_auto):
15877         Initialize m_lang in both cases.
15878
15879 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15880
15881         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15882         with XCNEW.
15883
15884 2019-01-22  Tom Tromey  <tom@tromey.com>
15885
15886         * corelow.c: Do not include sys/file.h.
15887
15888 2019-01-22  Tom Tromey  <tom@tromey.com>
15889
15890         * tui/tui-wingeneral.h: Include gdb_curses.h.
15891
15892 2019-01-22  Tom Tromey  <tom@tromey.com>
15893
15894         * source-cache.h (class source_cache) <get_source_lines,
15895         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15896
15897 2019-01-22  Tom Tromey  <tom@tromey.com>
15898
15899         * remote-fileio.h (struct remote_target): Declare.
15900
15901 2019-01-22  Tom Tromey  <tom@tromey.com>
15902
15903         * python/py-arch.c: Do not include py-ref.h.
15904         * python/py-bpevent.c: Do not include py-ref.h.
15905         * python/py-cmd.c: Do not include py-ref.h.
15906         * python/py-continueevent.c: Do not include py-ref.h.
15907         * python/py-event.h: Do not include py-ref.h.
15908         * python/py-evtregistry.c: Do not include py-ref.h.
15909         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15910         * python/py-frame.c: Do not include py-ref.h.
15911         * python/py-framefilter.c: Do not include py-ref.h.
15912         * python/py-function.c: Do not include py-ref.h.
15913         * python/py-infevents.c: Do not include py-ref.h.
15914         * python/py-linetable.c: Do not include py-ref.h.
15915         * python/py-objfile.c: Do not include py-ref.h.
15916         * python/py-param.c: Do not include py-ref.h.
15917         * python/py-prettyprint.c: Do not include py-ref.h.
15918         * python/py-progspace.c: Do not include py-ref.h.
15919         * python/py-symbol.c: Do not include py-ref.h.
15920         * python/py-symtab.c: Do not include py-ref.h.
15921         * python/py-type.c: Do not include py-ref.h.
15922         * python/py-unwind.c: Do not include py-ref.h.
15923         * python/py-utils.c: Do not include py-ref.h.
15924         * python/py-value.c: Do not include py-ref.h.
15925         * python/py-varobj.c: Do not include py-ref.h.
15926         * python/py-xmethods.c: Do not include py-ref.h.
15927         * python/python.c: Do not include py-ref.h.
15928         * varobj.c: Do not include py-ref.h.
15929
15930 2019-01-22  Tom Tromey  <tom@tromey.com>
15931
15932         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15933         keyword for bcache.
15934
15935 2019-01-22  Tom Tromey  <tom@tromey.com>
15936
15937         * compile/compile-cplus-types.c: Remove a comment by #include.
15938
15939 2019-01-22  Tom Tromey  <tom@tromey.com>
15940
15941         * compile/gcc-c-plugin.h: Include compile-internal.h.
15942
15943 2019-01-22  Tom Tromey  <tom@tromey.com>
15944
15945         * stabsread.c (EXTERN): Do not define.
15946         (symnum, next_symbol_text_func, processing_gcc_compilation)
15947         (within_function, global_sym_chain, global_stabs)
15948         (previous_stab_code, this_object_header_files)
15949         (n_this_object_header_files)
15950         (n_allocated_this_object_header_files): Define.
15951         * stabsread.h (EXTERN): Never define.  Use "extern".
15952
15953 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15954
15955         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15956         history_value.
15957
15958 2019-01-21  Tom Tromey  <tom@tromey.com>
15959
15960         * ui-out.c: Fix includes.
15961         * tui/tui-source.c: Fix includes.
15962         * target.c: Fix includes.
15963         * remote.c: Fix includes.
15964         * regcache.c: Fix includes.
15965         * python/py-block.c: Fix includes.
15966         * printcmd.c: Fix includes.
15967         * or1k-tdep.c: Fix includes.
15968         * mi/mi-main.c: Fix includes.
15969         * m32r-tdep.c: Fix includes.
15970         * csky-tdep.c: Fix includes.
15971         * compile/compile-cplus-types.c: Fix includes.
15972         * cli/cli-interp.c: Fix includes.
15973
15974 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15975
15976         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15977         for padding.
15978
15979 2019-01-16  Tom Tromey  <tom@tromey.com>
15980
15981         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15982         earlier.
15983         (struct objfile) <msymbols_range>: Move from top level.
15984         <msymbols>: New method.
15985         (class objfile_msymbols): Remove.
15986         * symtab.c (default_collect_symbol_completion_matches_break_on):
15987         Update.
15988         * symmisc.c (dump_msymbols): Update.
15989         * stabsread.c (scan_file_globals): Update.
15990         * objc-lang.c (info_selectors_command, info_classes_command)
15991         (find_methods): Update.
15992         * minsyms.c (find_solib_trampoline_target): Update.
15993         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15994         * coffread.c (coff_symfile_read): Update.
15995         * ada-lang.c (ada_lookup_simple_minsym)
15996         (ada_collect_symbol_completion_matches): Update.
15997
15998 2019-01-16  Tom Tromey  <tom@tromey.com>
15999
16000         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16001         type.  Remove no-argument constructor.
16002         <iterator::operator++>: Simplify.
16003         <begin>: Update.
16004         <end>: Use minimal_symbol_count.
16005
16006 2019-01-16  Tom Tromey  <tom@tromey.com>
16007
16008         * objfiles.h (struct objfile) <psymtabs>: New method.
16009         (class objfile_psymtabs): Remove.
16010         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16011         typedef.
16012         <range>: New method.
16013         (require_partial_symbols): Change return type.
16014         * psymtab.c (require_partial_symbols)
16015         (psym_expand_symtabs_matching): Update.
16016         * mdebugread.c (parse_partial_symbols): Update.
16017         * dbxread.c (dbx_end_psymtab): Update.
16018
16019 2019-01-15  Tom Tromey  <tom@tromey.com>
16020
16021         * symtab.c (lookup_objfile_from_block)
16022         (lookup_symbol_in_objfile_symtabs)
16023         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16024         (find_line_symtab, info_sources_command)
16025         (default_collect_symbol_completion_matches_break_on)
16026         (make_source_files_completion_list): Update.
16027         * symmisc.c (print_objfile_statistics, dump_objfile)
16028         (maintenance_print_symbols, maintenance_info_symtabs)
16029         (maintenance_check_symtabs, maintenance_info_line_tables):
16030         Update.
16031         * source.c (select_source_symtab)
16032         (forget_cached_source_info_for_objfile): Update.
16033         * objfiles.h (class objfile_compunits): Remove.
16034         (struct objfile) <compunits_range>: New typedef.
16035         (compunits): New method.
16036         * objfiles.c (objfile_relocate1): Update.
16037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16038         * maint.c (count_symtabs_and_blocks): Update.
16039         * linespec.c (iterate_over_all_matching_symtabs): Update.
16040         * cp-support.c (add_symbol_overload_list_qualified): Update.
16041         * coffread.c (coff_symtab_read): Update.
16042         * ada-lang.c (add_nonlocal_symbols)
16043         (ada_collect_symbol_completion_matches)
16044         (ada_add_global_exceptions): Update.
16045
16046 2019-01-15  Tom Tromey  <tom@tromey.com>
16047
16048         * progspace.h (program_space) <objfiles_safe_range>: New
16049         typedef.
16050         <objfiles_safe>: New method.
16051         * objfiles.h (class all_objfiles_safe): Remove.
16052         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16053         * jit.c (jit_inferior_exit_hook): Update.
16054
16055 2019-01-17  Tom Tromey  <tom@tromey.com>
16056
16057         * progspace.h (program_space) <objfiles_range>: New typedef.
16058         <objfiles>: New method.
16059         <objfiles_head>: Rename from objfiles.
16060         (object_files): Update.
16061         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16062         * guile/scm-pretty-print.c
16063         (ppscm_find_pretty_printer_from_objfiles): Update.
16064         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16065         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16066         Update.
16067         * python/py-progspace.c (pspy_get_objfiles): Update.
16068         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16069         Update.
16070         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16071         (objfpy_lookup_objfile_by_build_id): Update.
16072         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16073         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16074         Update.
16075         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16076         (expand_symtab_containing_pc, lookup_objfile_from_block)
16077         (lookup_static_symbol, basic_lookup_transparent_type)
16078         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16079         (find_line_symtab, info_sources_command)
16080         (default_collect_symbol_completion_matches_break_on)
16081         (make_source_files_completion_list, find_main_name): Update.
16082         * symmisc.c (print_symbol_bcache_statistics)
16083         (print_objfile_statistics, maintenance_print_symbols)
16084         (maintenance_print_msymbols, maintenance_print_objfiles)
16085         (maintenance_info_symtabs, maintenance_check_symtabs)
16086         (maintenance_expand_symtabs, maintenance_info_line_tables):
16087         Update.
16088         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16089         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16090         (map_overlay_command, unmap_overlay_command)
16091         (simple_overlay_update, expand_symtabs_matching)
16092         (map_symbol_filenames): Update.
16093         * symfile-debug.c (set_debug_symfile): Update.
16094         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16095         Update.
16096         * source.c (select_source_symtab, forget_cached_source_info):
16097         Update.
16098         * solib.c (solib_read_symbols): Update.
16099         * solib-spu.c (append_ocl_sos): Update.
16100         * psymtab.c (maintenance_print_psymbols)
16101         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16102         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16103         * printcmd.c (info_symbol_command): Update.
16104         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16105         Update.
16106         * objfiles.h (class all_objfiles): Remove.
16107         * objfiles.c (have_partial_symbols, have_full_symbols)
16108         (have_minimal_symbols, qsort_cmp, update_section_map)
16109         (shared_objfile_contains_address_p)
16110         (default_iterate_over_objfiles_in_search_order): Update.
16111         * objc-lang.c (info_selectors_command, info_classes_command)
16112         (find_methods): Update.
16113         * minsyms.c (find_solib_trampoline_target): Update.
16114         * maint.c (maintenance_info_sections)
16115         (maintenance_translate_address, count_symtabs_and_blocks):
16116         Update.
16117         * main.c (captured_main_1): Update.
16118         * linux-thread-db.c (try_thread_db_load_from_pdir)
16119         (has_libpthread): Update.
16120         * linespec.c (iterate_over_all_matching_symtabs)
16121         (search_minsyms_for_name): Update.
16122         * jit.c (jit_find_objf_with_entry_addr): Update.
16123         * hppa-tdep.c (find_unwind_entry)
16124         (hppa_lookup_stub_minimal_symbol): Update.
16125         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16126         Update.
16127         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16128         (elf_gnu_ifunc_resolve_by_got): Update.
16129         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16130         * dwarf-index-write.c (save_gdb_index_command): Update.
16131         * cp-support.c (add_symbol_overload_list_qualified): Update.
16132         * breakpoint.c (create_overlay_event_breakpoint)
16133         (create_longjmp_master_breakpoint)
16134         (create_std_terminate_master_breakpoint)
16135         (create_exception_master_breakpoint): Update.
16136         * blockframe.c (find_pc_partial_function): Update.
16137         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16138         (ada_collect_symbol_completion_matches)
16139         (ada_add_global_exceptions): Update.
16140
16141 2019-01-17  Tom Tromey  <tom@tromey.com>
16142
16143         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16144         declare VEC.
16145         (solib_target_parse_libraries): Change return type.
16146         (library_list_start_segment, library_list_start_section)
16147         (library_list_end_library, library_list_start_library); Update.
16148         (solib_target_free_library_list): Remove.
16149         (solib_target_parse_libraries): Remove cleanup.  Change return
16150         type.
16151         (solib_target_current_sos): Update.
16152
16153 2019-01-17  Tom Tromey  <tromey@bapiya>
16154
16155         * valprint.c: Replace "the the" with "the".
16156         * symtab.c: Replace "the the" with "the".
16157         * solib.c: Replace "the the" with "the".
16158         * solib-dsbt.c: Replace "the the" with "the".
16159         * linespec.c: Replace "the the" with "the".
16160         * dwarf2loc.h: Replace "the the" with "the".
16161         * amd64-windows-tdep.c: Replace "the the" with "the".
16162         * aarch64-tdep.c: Replace "the the" with "the".
16163
16164 2019-01-16  Keith Seitz  <keiths@redhat.com>
16165
16166         PR gdb/23773
16167         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16168         <builder>: Rename to ..
16169         <m_builder>: ... this and make private.
16170         (dwarf2_cu::get_builder): New method.  Change all users of
16171         `builder' to use this method.
16172         (dwarf2_start_symtab): Move to ...
16173         (dwarf2_cu::start_symtab): ... here.  Update all callers
16174         (setup_type_unit_groups): Move to ...
16175         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16176         callers.
16177         (dwarf2_cu::reset_builder): New method.
16178         (process_full_compunit, process_full_type_unit): Use
16179         dwarf2_cu::reset_builder.
16180         (follow_die_offset): Record the ancestor CU if it is different
16181         from the followed DIE's CU.
16182         (follow_die_sig_1): Likewise.
16183
16184 2019-01-15  Tom Tromey  <tom@tromey.com>
16185
16186         * remote.c (class remote_state) <buf>: Now a char_vector.
16187         <buf_size>: Remove.
16188         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16189         parameter.
16190         (remote_target::getpkt_or_notif_sane_1)
16191         (remote_target::getpkt_sane)
16192         (remote_target::getpkt_or_notif_sane): Likewise.
16193         (class remote_target) <putpkt>: New overload.
16194         (remote_target::read_frame): Change type of "buf_p".  Remove
16195         sizeof_p parameter.
16196         (packet_ok): New overload.
16197         (packet_check_result): New overload.
16198         Update all uses.
16199
16200 2019-01-14  Tom Tromey  <tom@tromey.com>
16201
16202         * remote-notif.c (handle_notification, remote_notif_ack)
16203         (remote_notif_parse): Make "buf" const.
16204         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16205         const.
16206         (remote_notif_parse, remote_notif_ack, handle_notification):
16207         Likewise.
16208         * remote.c (remote_notif_stop_parse): Make "buf" const.
16209         (remote_target::remote_parse_stop_reply): Make "buf" const.
16210         (remote_notif_stop_ack): Make "buf" const.
16211
16212 2019-01-14  Tom Tromey  <tom@tromey.com>
16213
16214         * remote.c (remote_console_output): Make parameter const.
16215
16216 2019-01-14  Tom Tromey  <tom@tromey.com>
16217
16218         * target-debug.h (target_debug_print_signals): Constify.
16219         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16220         * procfs.c (procfs_target::pass_signals): Update.
16221         * linux-nat.c (linux_nat_target::pass_signals): Update.
16222         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16223         * target-delegates.c: Rebuild.
16224         * remote.c (remote_target::program_signals): Update.
16225         (remote_target::pass_signals): Update.
16226         * target.c (target_pass_signals): Constify argument.
16227         (target_program_signals): Likewise.
16228         * target.h (struct target_ops) <pass_signals, program_signals>:
16229         Constify argument.
16230         (target_pass_signals, target_program_signals): Constify argument.
16231
16232 2019-01-14  Tom Tromey  <tom@tromey.com>
16233
16234         PR tui/28819:
16235         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16236
16237 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16238
16239         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16240         field.
16241         * rs6000-tdep.c: Include reggroups.h.
16242         (IS_V_ALIAS_PSEUDOREG): Define.
16243         (rs6000_register_name): Return names for the "vX" aliases.
16244         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16245         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16246         aliases.  Call default_register_reggroup_p for all other
16247         pseudo-registers.
16248         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16249         New functions.
16250         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16251         Handle "vX" aliases.
16252         (v_alias_pseudo_register_collect): New function.
16253         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16254         (rs6000_gdbarch_init): Initialize "vX" aliases as
16255         pseudo-registers.  Restore registration of
16256         rs6000_pseudo_register_reggroup_p with
16257         set_tdesc_pseudo_register_reggroup_p.
16258
16259 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16260
16261         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16262         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16263         set_gdbarch_num_pseudo_regs.
16264
16265 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16266
16267         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16268         Remove arg prefixname, add do_set and do_show.
16269         Add member functions set_list and show_list.
16270         * cli/cli-style.c (class cli_style_option): Update accordingly.
16271         (style_set_list): Move to file scope.
16272         (style_show_list): Likewise.
16273         (set_style): Call help_list.
16274         (show_style): Call cmd_show_list.
16275         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16276         Update to use the new macro.
16277
16278 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16279
16280         * ada-lang.c (_initialize_ada_language): Expand the help text
16281         for the "catch exception" command.
16282
16283 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16284
16285         * symtab.c (matching_obj_sections): Initialize obj,
16286         declare it closer to its usage.
16287
16288 2019-01-10  Tom Tromey  <tom@tromey.com>
16289
16290         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16291         (basic_inf_threads_range): Remove.
16292         (inf_threads_range, inf_non_exited_threads_range)
16293         (safe_inf_threads_range): Use next_adapter.
16294
16295 2019-01-10  Keith Seitz  <keiths@redhat.com>
16296
16297         PR gdb/23712
16298         PR symtab/23010
16299         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16300         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16301
16302 2019-01-10  Keith Seitz  <keiths@redhat.com>
16303
16304         PR gdb/23712
16305         PR symtab/23010
16306         * dictionary.c (pending_to_vector): Remove.
16307         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16308         Remove _1 suffix, replacing functions of the same name.  Update
16309         all callers.
16310         (dict_create_hashed, dict_create_hashed_expandable)
16311         (dict_create_linear, dict_create_linear_expandable, dict_free)
16312         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16313         Make functions static.
16314
16315 2019-01-10  Keith Seitz  <keiths@redhat.com>
16316
16317         PR gdb/23712
16318         PR symtab/23010
16319         * dictionary.h (struct dictionary): Replace declaration with
16320         multidictionary.
16321         (dict_create_hashed, dict_create_hashed_expandable)
16322         (dict_create_linear, dict_create_linear_expandable)
16323         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16324         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16325         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16326         taking multidictionary argument.
16327         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16328         * block.h (struct block) <dict>: Change to multidictionary
16329         and rename `multidict'.
16330         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16331         symmisc.c: Update all dictionary references to multidictionary.
16332
16333 2019-01-10  Keith Seitz  <keiths@redhat.com>
16334
16335         PR gdb/23712
16336         PR symtab/23010
16337         * dictionary.c: Include unordered_map.
16338         (pending_to_vector): New function.
16339         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16340         Rewrite the non-"_1" functions to take vector instead
16341         of linked list.
16342         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16343         "new" _1 versions of the same name.
16344         (multidictionary): Define.
16345         (std::hash<enum language): New definition.
16346         (collate_pending_symbols_by_language, mdict_create_hashed)
16347         (mdict_create_hashed_expandable, mdict_create_linear)
16348         (mdict_create_linear_expandable, mdict_free)
16349         (find_language_dictionary, create_new_language_dictionary)
16350         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16351         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16352         (mdict_size, mdict_empty): New functions.
16353         * dictionary.h (mdict_iterator): Define.
16354
16355 2019-01-10  Pedro Alves  <palves@redhat.com>
16356
16357         * breakpoint.c (read_uploaded_action)
16358         (create_tracepoint_from_upload): Adjust to use
16359         gdb::unique_xmalloc_ptr.
16360         * ctf.c (ctf_write_uploaded_tp):
16361         (SET_ARRAY_FIELD): Use emplace_back.
16362         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16363         * tracefile-tfile.c (tfile_write_uploaded_tp):
16364         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16365         gdb::unique_xmalloc_ptr.
16366         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16367         at_string, cond_string, cmd_strings>: Replace char pointers
16368         with gdb::unique_xmalloc_ptr.
16369
16370 2019-01-10  Pedro Alves  <palves@redhat.com>
16371
16372         * solib-target.c (library_list_start_library): Don't xstrdup name.
16373
16374 2019-01-10  Pedro Alves  <palves@redhat.com>
16375
16376         * mdebugread.c (parse_partial_symbols): Use
16377         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16378
16379 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16380
16381         * linux-fork.c (scoped_switch_fork_info)
16382         <~scoped_switch_fork_info>: Fix incorrect variable name.
16383
16384 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16385
16386         * linux-fork.c (scoped_switch_fork_info)
16387         <scoped_switch_fork_info>: Make explicit.
16388         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16389
16390 2019-01-10  Tom Tromey  <tom@tromey.com>
16391
16392         * objfiles.h (objfile::reset_psymtabs): Update.
16393         * objfiles.c (objfile::objfile): Update.
16394         * psymtab.h (psymtab_storage::obstack): Update.
16395         (psymtab_storage::m_obstack): Use gdb::optional.
16396         (class psymtab_storage): Update comment.  Remove objfile
16397         parameter.
16398         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16399
16400 2019-01-10  Tom Tromey  <tom@tromey.com>
16401
16402         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16403         <free_psymtabs>: Now private.
16404         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16405         (allocate_psymtab): Use new method.
16406
16407 2019-01-10  Tom Tromey  <tom@tromey.com>
16408
16409         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16410         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16411         * mdebugread.c (parse_partial_symbols): Use
16412         allocate_dependencies.
16413         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16414         allocate_dependencies.
16415         (process_psymtab_comp_unit_reader)
16416         (build_type_psymtab_dependencies): Likewise.
16417         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16418
16419 2019-01-10  Tom Tromey  <tom@tromey.com>
16420
16421         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16422         PSYMBOL_SET_LANGUAGE.
16423         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16424
16425 2019-01-10  Tom Tromey  <tom@tromey.com>
16426
16427         * psymtab.h (psymtab_storage::obstack): New method.
16428         <m_obstack>: Rename from obstack; now private.
16429         * psymtab.c (psymtab_storage): Update.
16430         * dwarf2read.c (create_addrmap_from_index)
16431         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16432         Update.
16433
16434 2019-01-10  Tom Tromey  <tom@tromey.com>
16435
16436         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16437         * objfiles.h (objfile::reset_psymtabs): New method.
16438
16439 2019-01-10  Tom Tromey  <tom@tromey.com>
16440
16441         * symmisc.c (print_symbol_bcache_statistics): Update.
16442         (print_objfile_statistics): Update.
16443         * symfile.c (reread_symbols): Update.
16444         * psymtab.h (class psymtab_storage): New.
16445         * psymtab.c (psymtab_storage): New constructor.
16446         (~psymtab_storage): New destructor.
16447         (require_partial_symbols): Update.
16448         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16449         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16450         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16451         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16452         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16453         (start_psymtab_common, end_psymtab_common)
16454         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16455         (allocate_psymtab): Update.
16456         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16457         Update.
16458         (dump_psymtab_addrmap, maintenance_print_psymbols)
16459         (maintenance_check_psymtabs): Update.
16460         (class objfile_psymtabs): Move to objfiles.h.
16461         * psympriv.h (discard_psymtab): Now inline.
16462         (psymtab_discarder::psymtab_discarder): Update.
16463         (psymtab_discarder::~psymtab_discarder): Update.
16464         (ALL_OBJFILE_PSYMTABS): Rewrite.
16465         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16466         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16467         Remove fields.
16468         <partial_symtabs>: New field.
16469         (class objfile_psymtabs): Move from psymtab.h.  Update.
16470         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16471         psymbol_cache.
16472         (objfile::~objfile): Don't destroy psymbol_cache.
16473         * mdebugread.c (parse_partial_symbols): Update.
16474         * dwarf2read.c (create_addrmap_from_index)
16475         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16476         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16477         (add_partial_subprogram, dwarf2_ranges_read): Update.
16478         * dwarf-index-write.c (write_address_map)
16479         (write_one_signatured_type, recursively_write_psymbols)
16480         (class debug_names, class debug_names, write_psymtabs_to_index):
16481         Update.
16482
16483 2019-01-10  Tom Tromey  <tom@tromey.com>
16484
16485         * symtab.h (SYMBOL_SET_NAMES): Update.
16486         (symbol_set_names): Update.
16487         (MSYMBOL_SET_NAMES): Update.
16488         * symtab.c (symbol_set_names): Change argument to be an
16489         objfile_per_bfd_storage.
16490         * psymtab.c (add_psymbol_to_bcache): Update.
16491         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16492
16493 2019-01-10  Tom Tromey  <tom@tromey.com>
16494
16495         * symtab.c (create_demangled_names_hash): Change argument to be an
16496         objfile_per_bfd_storage.
16497         (symbol_set_names): Update.
16498
16499 2019-01-10  Tom Tromey  <tom@tromey.com>
16500
16501         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16502         init_psymbol_list.
16503         * psymtab.c (init_psymbol_list): Do nothing if already called.
16504         * psympriv.h (init_psymbol_list): Add comment.
16505         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16506         init_psymbol_list.
16507         * dbxread.c (dbx_symfile_read): Unconditionally call
16508         init_psymbol_list.
16509
16510 2019-01-10  Tom Tromey  <tom@tromey.com>
16511
16512         * xcoffread.c (scan_xcoff_symtab): Update.
16513         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16514         "where".
16515         * mdebugread.c (parse_partial_symbols)
16516         (handle_psymbol_enumerators): Update.
16517         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16518         * dbxread.c (read_dbx_symtab): Update.
16519         * psympriv.h (psymbol_placement): New enum.
16520         (add_psymbol_to_list): Update.
16521
16522 2019-01-10  Tom Tromey  <tom@tromey.com>
16523
16524         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16525         static_psymbols parameters.
16526         (scan_xcoff_symtab): Update.
16527         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16528         static_psymbols parameters.
16529         * psympriv.h (start_psymtab_common): Update.
16530         * mdebugread.c (parse_partial_symbols): Update.
16531         * dwarf2read.c (create_partial_symtab): Update.
16532         * dbxread.c (read_dbx_symtab): Update.
16533         (start_psymtab): Remove global_psymbols and static_psymbols
16534         parameters.
16535
16536 2019-01-10  Tom Tromey  <tom@tromey.com>
16537
16538         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16539         * psymtab.c (allocate_psymtab): Add comment.
16540         * psympriv.h (allocate_psymtab): Add comment.
16541         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16542         initializations.
16543         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16544
16545 2019-01-10  Tom Tromey  <tom@tromey.com>
16546
16547         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16548         Don't declare.
16549         * mipsread.c: Include mdebugread.h.
16550         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16551         Declare.
16552         * elfread.c: Include mdebugread.h.
16553
16554 2019-01-09  Tom Tromey  <tom@tromey.com>
16555
16556         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16557         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16558         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16559         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16560         (psym_lookup_symbol, psym_find_last_source_symtab)
16561         (psym_forget_cached_source_info, psym_print_stats)
16562         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16563         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16564         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16565         (psym_find_compunit_symtab_by_address)
16566         (maintenance_print_psymbols, maintenance_info_psymtabs)
16567         (maintenance_check_psymtabs): Use ranged for.
16568         * psymtab.h (class objfile_psymtabs): New.
16569         (require_partial_symbols): Return objfile_psymtabs.
16570         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16571
16572 2019-01-09  Tom Tromey  <tom@tromey.com>
16573
16574         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16575         (find_pc_mapped_section, list_overlays_command)
16576         (map_overlay_command, unmap_overlay_command)
16577         (simple_overlay_update): Use all_objfiles.
16578         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16579         * printcmd.c (info_symbol_command): Use all_objfiles.
16580         * objfiles.h (ALL_OBJSECTIONS): Remove.
16581         * maint.c (maintenance_translate_address): Use all_objfiles.
16582         * gcore.c (gcore_create_callback): Use all_objfiles.
16583         (objfile_find_memory_regions): Likewise.
16584
16585 2019-01-09  Tom Tromey  <tom@tromey.com>
16586
16587         * symtab.c (find_line_symtab, info_sources_command)
16588         (make_source_files_completion_list): Use objfile_compunits.
16589         * source.c (select_source_symtab): Use objfile_compunits.
16590         * objfiles.h (struct objfile): Update comment.
16591         (ALL_OBJFILES): Remove.
16592         (ALL_FILETABS): Remove.
16593         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16594         objfile_compunits.
16595
16596 2019-01-09  Tom Tromey  <tom@tromey.com>
16597
16598         * symmisc.c (print_objfile_statistics, dump_objfile)
16599         (maintenance_print_symbols): Use compunit_filetabs.
16600         * source.c (forget_cached_source_info_for_objfile): Use
16601         compunit_filetabs.
16602         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16603         (ALL_FILETABS): Use compunit_filetabs.
16604         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16605         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16606
16607 2019-01-09  Tom Tromey  <tom@tromey.com>
16608
16609         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16610         (compunit_filetabs): New.
16611         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16612         compunit_filetabs.
16613         (info_sources_command, make_source_files_completion_list): Remove
16614         declaration.
16615         * symmisc.c (print_objfile_statistics, dump_objfile)
16616         (maintenance_print_symbols): Remove declaration.
16617         (maintenance_info_symtabs): Use compunit_filetabs.
16618         (maintenance_info_line_tables): Likewise.
16619         * source.c (select_source_symtab): Change local variable name.
16620         (forget_cached_source_info_for_objfile): Remove declaration.
16621         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16622         * objfiles.c (objfile_relocate1): Remove declaration.
16623         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16624         declaration.
16625         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16626         * coffread.c (coff_symtab_read): Remove declaration.
16627         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16628         compunit_filetabs.
16629
16630 2019-01-09  Tom Tromey  <tom@tromey.com>
16631
16632         * symtab.c (lookup_objfile_from_block)
16633         (find_pc_sect_compunit_symtab, search_symbols)
16634         (default_collect_symbol_completion_matches_break_on): Use
16635         objfile_compunits.
16636         * objfiles.h (ALL_COMPUNITS): Remove.
16637         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16638         * cp-support.c (add_symbol_overload_list_qualified): Use
16639         objfile_compunits.
16640         * ada-lang.c (ada_collect_symbol_completion_matches)
16641         (ada_add_global_exceptions): Use objfile_compunits.
16642
16643 2019-01-09  Tom Tromey  <tom@tromey.com>
16644
16645         * source.c (select_source_symtab)
16646         (forget_cached_source_info_for_objfile): Remove declaration.
16647         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16648         declaration.
16649         * maint.c (count_symtabs_and_blocks): Remove declaration.
16650         * cp-support.c (add_symbol_overload_list_qualified): Remove
16651         declaration.
16652         * coffread.c (coff_symtab_read): Remove declaration.
16653         * symtab.c (lookup_symbol_in_objfile_symtabs)
16654         (basic_lookup_transparent_type_1): Use objfile_compunits.
16655         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16656         (info_sources_command, search_symbols)
16657         (default_collect_symbol_completion_matches_break_on)
16658         (make_source_files_completion_list): Remove declaration.
16659         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16660         (ada_collect_symbol_completion_matches)
16661         (ada_add_global_exceptions): Remove declaration.
16662         * linespec.c (iterate_over_all_matching_symtabs): Use
16663         objfile_compunits.
16664         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16665         (class objfile_compunits): New.
16666         (ALL_COMPUNITS): Use objfile_compunits.
16667         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16668         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16669         objfile_compunits.
16670         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16671
16672 2019-01-09  Tom Tromey  <tom@tromey.com>
16673
16674         * symtab.c (search_symbols)
16675         (default_collect_symbol_completion_matches_break_on): Use
16676         objfile_msymbols.
16677         * ada-lang.c (ada_lookup_simple_minsym)
16678         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16679         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16680         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16681         objfile_msymbols.
16682         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16683         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16684         * objc-lang.c (find_methods): Use objfile_msymbols.
16685         (info_selectors_command, info_classes_command): Likewise.
16686         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16687         * objfiles.h (class objfile_msymbols): New.
16688         (ALL_OBJFILE_MSYMBOLS): Remove.
16689         (ALL_MSYMBOLS): Remove.
16690
16691 2019-01-09  Tom Tromey  <tom@tromey.com>
16692
16693         * common/next-iterator.h (next_adapter): Add Iterator template
16694         parameter.
16695         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16696         (class all_objfiles_safe): New.
16697         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16698         * objfiles.c (put_objfile_before): Update comment.
16699         (add_separate_debug_objfile): Likewise.
16700         (free_all_objfiles): Use all_objfiles_safe.
16701         (objfile_purge_solibs): Likewise.
16702
16703 2019-01-09  Tom Tromey  <tom@tromey.com>
16704
16705         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16706         (expand_symtab_containing_pc, lookup_static_symbol)
16707         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16708         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16709         all_objfiles.
16710         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16711         * breakpoint.c (create_overlay_event_breakpoint)
16712         (create_longjmp_master_breakpoint)
16713         (create_std_terminate_master_breakpoint)
16714         (create_exception_master_breakpoint): Use all_objfiles.
16715         * linux-thread-db.c (try_thread_db_load_from_pdir)
16716         (has_libpthread): Use all_objfiles.
16717         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16718         * linespec.c (iterate_over_all_matching_symtabs)
16719         (search_minsyms_for_name): Use all_objfiles.
16720         * maint.c (maintenance_info_sections): Use all_objfiles.
16721         * main.c (captured_main_1): Use all_objfiles.
16722         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16723         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16724         * guile/scm-pretty-print.c
16725         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16726         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16727         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16728         (maintenance_print_msymbols): Use all_objfiles.
16729         * source.c (select_source_symtab): Use all_objfiles.
16730         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16731         * symfile.c (remove_symbol_file_command)
16732         (expand_symtabs_matching, map_symbol_filenames): Use
16733         all_objfiles.
16734         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16735         all_objfiles.
16736         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16737         * objc-lang.c (find_methods): Use all_objfiles.
16738         * objfiles.c (have_partial_symbols, have_full_symbols)
16739         (have_minimal_symbols, qsort_cmp)
16740         (default_iterate_over_objfiles_in_search_order): Use
16741         all_objfiles.
16742         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16743         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16744         (maintenance_check_psymtabs): Use all_objfiles.
16745         (ALL_PSYMTABS): Remove.
16746         * compile/compile-object-run.c (do_module_cleanup): Use
16747         all_objfiles.
16748         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16749         * cp-support.c (add_symbol_overload_list_qualified): Use
16750         all_objfiles.
16751         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16752         Use all_objfiles.
16753         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16754         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16755         all_objfiles.
16756         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16757         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16758         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16759         Uses all_objfiles.
16760         * solib.c (solib_read_symbols): Use all_objfiles
16761
16762 2019-01-09  Tom Tromey  <tom@tromey.com>
16763
16764         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16765         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16766         all_objfiles.
16767         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16768         * symmisc.c (print_symbol_bcache_statistics)
16769         (print_objfile_statistics, maintenance_print_objfiles)
16770         (maintenance_info_symtabs, maintenance_check_symtabs)
16771         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16772         all_objfiles.
16773         * source.c (forget_cached_source_info): Use all_objfiles.
16774         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16775         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16776         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16777         * objfiles.c (update_section_map): Use all_objfiles.
16778         (shared_objfile_contains_address_p): Likewise.
16779         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16780         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16781
16782 2019-01-09  Tom Tromey  <tom@tromey.com>
16783
16784         * common/next-iterator.h: New file.
16785         * objfiles.h (class all_objfiles): New.
16786         (struct objfile_iterator): New.
16787
16788 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16789
16790         * NEWS: Move the description of the changed "frame", "select-frame",
16791          and "info frame" commands to the Changed commands section.
16792
16793 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16794
16795         * gdbtypes.c (check_stub_method_group): Remove handling of old
16796         mangling schemes.
16797         * linespec.c (find_methods): Likewise.
16798         * stabsread.c (read_member_functions): Likewise.
16799         * valops.c (search_struct_method): Likewise.
16800         (value_struct_elt_for_reference): Likewise.
16801         * NEWS: Mention this change.
16802
16803 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16804
16805         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16806         print_source_lines.
16807         * source.c (print_source_lines_base): Update line number check.
16808         (print_source_lines): New function.
16809         (source_lines_range::source_lines_range): New function.
16810         * source.h (class source_lines_range): New class.
16811         (print_source_lines): New declaration.
16812
16813 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16814
16815         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16816
16817 2019-01-08  Tom Tromey  <tom@tromey.com>
16818             Simon Marchi  <simon.marchi@ericsson.com>
16819
16820         PR gdb/24060
16821         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16822         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16823         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16824         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16825         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16826         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16827
16828 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16829
16830         * source.c (select_source_symtab): Move header comment to
16831         declaration in source.h.
16832         (forget_cached_source_info_for_objfile): Likewise.
16833         (forget_cached_source_info): Likewise.
16834         (identify_source_line): Likewise.
16835         * source.h (identify_source_line): Move declaration from symtab.h
16836         and add comment from source.c
16837         (print_source_lines): Likewise.
16838         (forget_cached_source_info_for_objfile): Likewise.
16839         (forget_cached_source_info): Likewise.
16840         (select_source_symtab): Likewise.
16841         (enum print_source_lines_flag): Move definition from symtab.h.
16842         * symtab.h (identify_source_line): Move declaration to source.h.
16843         (print_source_lines): Likewise.
16844         (forget_cached_source_info_for_objfile): Likewise.
16845         (forget_cached_source_info): Likewise.
16846         (select_source_symtab): Likewise.
16847         (enum print_source_lines_flag): Move definition to source.h.
16848         * tui/tui-hooks.c: Add 'source.h' include.
16849
16850 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16851
16852         * source.c (print_source_lines_base): Handle requests to print
16853         reverse line number sequences, and guard against empty lines
16854         string.
16855
16856 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16857
16858         * source.c (print_source_lines_base): Fix skip of '\r' if next
16859         character is '\n'.
16860
16861 2019-01-06  Tom Tromey  <tom@tromey.com>
16862
16863         * c-exp.y (struct c_parse_state) <macro_original_text,
16864         expansion_obstack>: New member.
16865         (macro_original_text, expansion_obstack): Remove globals.
16866         (scan_macro_expansion, scanning_macro_expansion)
16867         (finished_macro_expansion): Update.
16868         (scan_macro_cleanup): Remove.
16869         (yylex, c_parse): Update.
16870
16871 2019-01-06  Tom Tromey  <tom@tromey.com>
16872
16873         * c-exp.y (struct c_parse_state) <strings>: New member.
16874         (operator_stoken): Update.
16875
16876 2019-01-06  Tom Tromey  <tom@tromey.com>
16877
16878         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16879         (union type_stack_elt) <typelist_val>: Now a pointer to
16880         std::vector.
16881         (type_stack_cleanup): Don't declare.
16882         (push_typelist): Update.
16883         * parse.c (pop_typelist): Return a std::vector.
16884         (push_typelist): Take a std::vector.
16885         (follow_types): Update.  Do not free args.
16886         (type_stack_cleanup): Remove.
16887         * c-exp.y (struct c_parse_state): New.
16888         (cpstate): New global.
16889         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16890         (nonempty_typelist): Update.
16891         (func_mod): Create a new vector.
16892         (c_parse): Create a c_parse_state.
16893         (check_parameter_typelist): Do not delete params.
16894         (function_method): Update.  Do not delete type_list.
16895
16896 2019-01-06  Tom Tromey  <tom@tromey.com>
16897
16898         PR gdb/28155:
16899         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16900         check_typedef.
16901         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16902         (print_return_value): Likewise.
16903
16904 2019-01-05  Tom Tromey  <tom@tromey.com>
16905
16906         * contrib/cleanup_check.py: Remove.
16907         * contrib/gcc-with-excheck: Remove.
16908         * contrib/exsummary.py: Remove.
16909         * contrib/excheck.py: Remove.
16910
16911 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16912
16913         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16914         NULL. Initialize tpprev to NULL instead of assigning it
16915         to NULL on the next statement.
16916         * windows-nat.c (windows_delete_thread): Remove check for
16917         main_thread_id before printing thread exit notifications.
16918         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16919         Remove thread ID check against main_thread_id.
16920         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16921         windows_delete_thread.
16922         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16923
16924 2019-01-04  Tom Tromey  <tom@tromey.com>
16925
16926         * compile/compile.c (_initialize_compile): Use upper case for
16927         metasyntactic variables.
16928         * symmisc.c (_initialize_symmisc): Use upper case for
16929         metasyntactic variables.
16930         * psymtab.c (_initialize_psymtab): Use upper case for
16931         metasyntactic variables.
16932         * demangle.c (demangle_command): Use upper case for metasyntactic
16933         variables.
16934         (_initialize_demangler): Likewise.
16935         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16936         variables.
16937
16938 2019-01-03  Tom Tromey  <tom@tromey.com>
16939
16940         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16941
16942 2019-01-03  Tom Tromey  <tom@tromey.com>
16943
16944         * python/py-symtab.c (salpy_str): Update.
16945         (struct salpy_sal_object) <symtab>: Now a PyObject.
16946         (salpy_dealloc): Update.
16947         (del_objfile_sal): Use gdbpy_ref.
16948
16949 2019-01-03  Tom Tromey  <tom@tromey.com>
16950
16951         * python/py-type.c (convert_field): Use new_reference.  Return
16952         gdbpy_ref.
16953         (make_fielditem): Return gdbpy_ref.
16954         (typy_fields): Update.
16955         (typy_getitem): Update.
16956         (field_name): Return gdbpy_ref.  Use new_reference.
16957         (typy_iterator_iternext): Update.
16958
16959 2019-01-03  Tom Tromey  <tom@tromey.com>
16960
16961         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16962
16963 2019-01-03  Tom Tromey  <tom@tromey.com>
16964
16965         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16966         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16967         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16968         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16969         (pspy_set_type_printers): Likewise.
16970         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16971         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16972         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16973         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16974         (objfpy_set_type_printers): Likewise.
16975
16976 2019-01-03  Tom Tromey  <tom@tromey.com>
16977
16978         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16979         (gdbpy_print_stack): Use gdbpy_err_fetch.
16980         * python/python-internal.h (class gdbpy_err_fetch): New class.
16981         (class gdbpy_enter) <m_error_type, m_error_value,
16982         m_error_traceback>: Remove.
16983         <m_error>: New member.
16984         (gdbpy_exception_to_string): Don't declare.
16985         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16986         * python/py-value.c (convert_value_from_python): Use
16987         gdbpy_err_fetch.
16988         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16989         gdbpy_exception_to_string.
16990         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16991         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16992         gdbpy_err_fetch.
16993
16994 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16995
16996         * linux-nat.c (delete_lwp_cleanup): Delete.
16997         (struct lwp_deleter): New struct.
16998         (lwp_info_up): New typedef.
16999         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17000         lwp_info_up.
17001
17002 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17003
17004         * linux-fork.c (class scoped_switch_fork_info): New class.
17005         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17006
17007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17008
17009         * valops.c (find_overload_match): Remove use of null_cleanup, and
17010         calls to do_cleanups.
17011
17012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17013
17014         * compile/compile-cplus-types.c
17015         (compile_cplus_instance::decl_name): Handle changes to
17016         cp_func_name.
17017         * cp-support.c (cp_func_name): Update header comment, update
17018         return type.
17019         * cp-support.h (cp_func_name): Update return type in declaration.
17020         * valops.c (find_overload_match): Move temp_func local to top
17021         level of function and change its type.  Use temp_func to hold and
17022         delete temporary string obtained from cp_func_name.
17023
17024 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17025
17026         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17027         gdb::char_vector, remove cleanup, and update uses of `msg`.
17028
17029 2019-01-03  Jim Wilson  <jimw@sifive.com>
17030
17031         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17032
17033 2019-01-02  Tom Tromey  <tom@tromey.com>
17034
17035         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17036         (tdesc_parse_xml): Remove cleanups.
17037         * target-descriptions.h (make_cleanup_free_target_description):
17038         Don't declare.
17039         (target_desc_deleter): New struct.
17040         (target_desc_up): New typedef.
17041         * target-descriptions.c (target_desc_deleter::operator()): Rename
17042         from free_target_description.
17043         (make_cleanup_free_target_description): Remove.
17044
17045 2019-01-02  Tom Tromey  <tom@tromey.com>
17046
17047         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17048         constructor, destructor.
17049         (linespec_parser): Remove typedef.
17050         (~linespec_parser): Rename from linespec_parser_delete.
17051         (linespec_lex_to_end, linespec_complete_label)
17052         (linespec_complete): Update.
17053         (decode_line_full): Remove cleanups.
17054         (decode_line_1): Update.
17055
17056 2019-01-02  Tom Tromey  <tom@tromey.com>
17057
17058         * python/python-internal.h (inferior_to_inferior_object): Change
17059         return type.
17060         * python/py-exitedevent.c (create_exited_event_object): Update.
17061         * python/py-inferior.c (inferior_to_inferior_object): Return
17062         gdbpy_ref.
17063         (python_new_inferior, python_inferior_deleted)
17064         (thread_to_thread_object, delete_thread_object)
17065         (build_inferior_list, gdbpy_selected_inferior): Update.
17066         * python/py-infthread.c (create_thread_object): Update.  Also fail
17067         if inferior_to_inferior_object fails.
17068
17069 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17070
17071         * inferior.h (class inferior) <displaced_step_state>: New field.
17072         * infrun.h (struct displaced_step_state): Move here from
17073         infrun.c.  Initialize fields, add constructor.
17074         <inf>: Remove field.
17075         <reset>: New method.
17076         * infrun.c (struct displaced_step_inferior_state): Move to
17077         infrun.h.
17078         (displaced_step_inferior_states): Remove.
17079         (get_displaced_stepping_state): Adust.
17080         (displaced_step_in_progress_any_inferior): Adjust.
17081         (displaced_step_in_progress_thread): Adjust.
17082         (displaced_step_in_progress): Adjust.
17083         (add_displaced_stepping_state): Remove.
17084         (get_displaced_step_closure_by_addr): Adjust.
17085         (remove_displaced_stepping_state): Remove.
17086         (infrun_inferior_exit): Call displaced_step_state.reset.
17087         (use_displaced_stepping): Don't check for NULL.
17088         (displaced_step_prepare_throw): Call
17089         get_displaced_stepping_state.
17090         (displaced_step_fixup): Don't check for NULL.
17091         (prepare_for_detach): Don't check for NULL.
17092
17093 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17094
17095         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17096          in case of call that did not complete.
17097
17098 2019-01-02  Andrey Utkin  <autkin@undo.io>
17099
17100         * symfile.c (find_separate_debug_file): Fix search of debug files for
17101         remote debuggee.
17102
17103 2019-01-02  Tom Tromey  <tom@tromey.com>
17104
17105         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17106         indentation.
17107         * python/py-frame.c (frapy_older): Remove cast.
17108         (frapy_newer): Likewise.
17109         * python/py-breakpoint.c (local_setattro): Remove cast.
17110         * python/py-arch.c (archpy_name): Remove local variable.
17111         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17112
17113 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17114
17115         * unittests/basic_string_view/element_access/char/empty.cc:
17116         Fix year range in copyright header.
17117
17118 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17119
17120         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17121         Delete.
17122         <operator==>: Update with for removed field.
17123         <hash>: Likewise.
17124         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17125         <isa_features>: ...this.
17126         <abi_features>: New field.
17127         (riscv_isa_flen): Update comment.
17128         (riscv_abi_xlen): New declaration.
17129         (riscv_abi_flen): New declaration.
17130         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17131         isa_features.
17132         (riscv_abi_xlen): New function.
17133         (riscv_isa_flen): Update to get answer from isa_features.
17134         (riscv_abi_flen): New function.
17135         (riscv_has_fp_abi): Update to get answer from abi_features.
17136         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17137         xlen and flen.
17138         (riscv_call_info) <xlen, flen>: Update comment.
17139         (riscv_call_arg_struct): Remove invalid assertions
17140         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17141         is removed.
17142         (riscv_gdbarch_init): Gather isa features and abi features
17143         separately, ensure both match on the gdbarch when reusing an old
17144         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17145         a target with 64-bit float hardware.
17146
17147 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17148
17149         * source.c (search_command_helper): Stop reverse search
17150         when line 1 has been searched.
17151
17152 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17153
17154         * record-full.c (record_full_base_target::close): Rewrite
17155         record_full_core_buf_list free logic.
17156
17157 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17158
17159         * break-catch-syscall.c (print_one_catch_syscall): xfree
17160         the last text.
17161
17162 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17163
17164         * top.c (print_gdb_version): Update Copyright year in version
17165         message.
17166
17167 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17168
17169         Update copyright year range in all GDB files.
17170
17171 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17172
17173         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17174
17175 For older changes see ChangeLog-2018.
17176 \f
17177 Local Variables:
17178 mode: change-log
17179 left-margin: 8
17180 fill-column: 74
17181 version-control: never
17182 coding: utf-8
17183 End:
17184