gdb/ChangeLog

   1 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * dictionary.c (dict_empty, mdict_empty): Remove.
   4         * dictionary.c (mdict_empty): Remove.
   5
   6 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
   7
   8          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
   9          (arc_insn_get_memory_offset): Likewise.
  10          (arc_insn_dump): Likewise.
  11          * cp-support.c (test_cp_symbol_name_matches): Likewise.
  12          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
  13          * dictionary.c (dict_iterator_next): Likewise.
  14          (dict_iter_match_first): Likewise.
  15          (dict_iter_match_next): Likewise.
  16          * f-lang.c (evaluate_subexp_f): Likewise.
  17          * hppa-tdep.c (hppa_read_pc): Likewise.
  18          * i386-tdep.c (i386_floatformat_for_type): Likewise.
  19          * parse.c (write_exp_elt_msym): Likewise.
  20          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
  21          * remote.c (remote_packet_size): Likewise.
  22          (remote_notif_stop_parse): Likewise.
  23          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
  24          * s12z-tdep.c (s12z_disassemble_info): Likewise.
  25          * source.c (prepare_path_for_appending): Likewise.
  26          * sparc64-linux-tdep.c
  27          (sparc64_linux_handle_segmentation_fault); Likewise.
  28          * stack.c (frame_selection_by_function_completer): Likewise.
  29
  30 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
  31
  32         * completer.c (set_gdb_completion_word_break_characters):
  33         Remove.
  34
  35 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
  36
  37         * dwarf-index-write.c: Include dwarf-index-write.h.
  38         * mi/mi-interp.c: Include mi/mi-interp.h.
  39
  40 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
  41
  42         * aarch32-tdep.c: Include aarch32-tdep.h.
  43         * aarch32-tdep.h: Forward-declare struct target_desc.
  44
  45 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
  46
  47         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
  48         strerror.
  49         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
  50         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
  51
  52 2019-11-25  Tom de Vries  <tdevries@suse.de>
  53
  54         * contrib/words.sh: Add -c option.
  55
  56 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * solib.c (solib_find_1): Change int to bool.
  59         (exec_file_find): Change int to bool.
  60         (solib_find): Change int to bool.
  61         (solib_read_symbols): Change int to bool.
  62         (solib_used): Change int to bool.
  63         (solib_add): Change int to bool.
  64         (info_sharedlibrary_command): Change int to bool.
  65         (solib_contains_address_p): Change int to bool.
  66         (solib_keep_data_in_core): Change int to bool.
  67         (in_solib_dynsym_resolve_code): Change int to bool.
  68         (reload_shared_libraries_1): Change int to bool.
  69         (gdb_sysroot_changed): Change int to bool.
  70         * solib.h (solib_read_symbols): Change int to bool.
  71         (solib_contains_address_p): Change int to bool.
  72         (solib_keep_data_in_core): Change int to bool.
  73         (in_solib_dynsym_resolve_code): Change int to bool.
  74         (libpthread_name_p): Change int to bool.
  75
  76 2019-11-25  Luis Machado  <luis.machado@linaro.org>
  77
  78         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
  79         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
  80         (remote_packet_max_chars): New static global.
  81         (show_remote_packet_max_chars): New function.
  82         (remote_target::putpkt_binary): Adjust to use new
  83         remote_packet_max_chars option.
  84         (remote_target::getpkt_or_notif_sane_1): Likewise.
  85         (_initialize_remote): Register new remote-packet-max-chars option.
  86
  87 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
  88
  89         * m68k-linux-nat.c: Include gdbarch.h.
  90
  91 2019-11-24  Tom Tromey  <tom@tromey.com>
  92
  93         * symfile.c (read_symbols): Update.
  94         * psymtab.c (require_partial_symbols): Change type of "verbose" to
  95         bool.
  96         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
  97         (psym_lookup_symbol, psym_find_last_source_symtab)
  98         (psym_forget_cached_source_info, psym_print_stats)
  99         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 100         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 101         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 102         (psym_find_compunit_symtab_by_address)
 103         (maintenance_print_psymbols, maintenance_info_psymtabs)
 104         (maintenance_check_psymtabs): Update.
 105         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 106         bool.
 107
 108 2019-11-22  Tom Tromey  <tom@tromey.com>
 109
 110         * observable.h: Update comments.
 111
 112 2019-11-22  Tom Tromey  <tromey@adacore.com>
 113
 114         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 115         (print_ada_task_info): Don't try to fetch thread id if task is not
 116         alive.
 117
 118 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 119
 120         * ada-exp.y: Update.
 121         * ada-lang.c (sort_choices): Update.
 122         (ada_print_symbol_signature): Update.
 123         (resolve_subexp): Update.
 124         (ada_parse_renaming): Update.
 125         (ada_read_renaming_var_value): Update.
 126         (lesseq_defined_than): Update.
 127         (remove_extra_symbols): Update.
 128         (remove_irrelevant_renamings): Update.
 129         (ada_add_block_symbols): Update.
 130         (ada_collect_symbol_completion_matches): Update.
 131         (ada_is_renaming_symbol): Update.
 132         (aggregate_assign_from_choices): Update.
 133         (ada_evaluate_subexp): Update.
 134         (ada_has_this_exception_support): Update.
 135         (ada_is_non_standard_exception_sym): Update.
 136         (ada_add_exceptions_from_frame): Update.
 137         (ada_add_global_exceptions): Update.
 138         (ada_print_subexp): Update.
 139         * ax-gdb.c (gen_var_ref): Update.
 140         (gen_maybe_namespace_elt): Update.
 141         (gen_expr_for_cast): Update.
 142         (gen_expr): Update.
 143         * block.h: Update.
 144         * blockframe.c (find_pc_partial_function): Update.
 145         * breakpoint.c (print_breakpoint_location): Update.
 146         (update_static_tracepoint): Update.
 147         * btrace.c (ftrace_print_function_name): Update.
 148         (ftrace_function_switched): Update.
 149         * buildsym.c (find_symbol_in_list): Update.
 150         * c-exp.y: Update.
 151         * c-typeprint.c (c_print_typedef): Update.
 152         (c_type_print_template_args): Update.
 153         * cli/cli-cmds.c (edit_command): Update.
 154         (list_command): Update.
 155         (print_sal_location): Update.
 156         * coffread.c (patch_opaque_types): Update.
 157         (process_coff_symbol): Update.
 158         (coff_read_enum_type): Update.
 159         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 160         (convert_one_symbol): Update.
 161         (hash_symname): Update.
 162         (eq_symname): Update.
 163         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 164         * compile/compile-cplus-types.c (debug_print_scope): Update.
 165         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 166         * compile/compile-object-load.c (get_out_value_type): Update.
 167         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 168         (search_symbol_list): Update.
 169         (cp_lookup_symbol_imports_or_template): Update.
 170         * cp-support.c (overload_list_add_symbol): Update.
 171         * ctfread.c (psymtab_to_symtab): Update.
 172         * dbxread.c (cp_set_block_scope): Update.
 173         * dictionary.c (iter_match_first_hashed): Update.
 174         (iter_match_next_hashed): Update.
 175         (insert_symbol_hashed): Update.
 176         (iter_match_next_linear): Update.
 177         * dictionary.h: Update.
 178         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 179         (locexpr_describe_location_piece): Update.
 180         (locexpr_describe_location_1): Update.
 181         (locexpr_generate_c_location): Update.
 182         (loclist_describe_location): Update.
 183         (loclist_generate_c_location): Update.
 184         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 185         (read_func_scope): Update.
 186         (process_enumeration_scope): Update.
 187         (new_symbol): Update.
 188         (dwarf2_const_value): Update.
 189         (dwarf2_symbol_mark_computed): Update.
 190         * eval.c (evaluate_funcall): Update.
 191         (evaluate_subexp_standard): Update.
 192         * expprint.c (print_subexp_standard): Update.
 193         (dump_subexp_body_standard): Update.
 194         * f-valprint.c (info_common_command_for_block): Update.
 195         * findvar.c (get_hosting_frame): Update.
 196         (default_read_var_value): Update.
 197         * go-lang.c (go_symbol_package_name): Update.
 198         * guile/scm-block.c (bkscm_print_block_smob): Update.
 199         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 200         (gdbscm_symbol_name): Update.
 201         (gdbscm_symbol_linkage_name): Update.
 202         (gdbscm_symbol_print_name): Update.
 203         * infcall.c (get_function_name): Update.
 204         * infcmd.c (jump_command): Update.
 205         (finish_command): Update.
 206         * infrun.c (insert_exception_resume_breakpoint): Update.
 207         * linespec.c (canonicalize_linespec): Update.
 208         (create_sals_line_offset): Update.
 209         (convert_linespec_to_sals): Update.
 210         (complete_label): Update.
 211         (find_label_symbols_in_block): Update.
 212         * m2-typeprint.c (m2_print_typedef): Update.
 213         * mdebugread.c (mdebug_reg_to_regnum): Update.
 214         (parse_symbol): Update.
 215         (mylookup_symbol): Update.
 216         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 217         (list_args_or_locals): Update.
 218         * objc-lang.c (compare_selectors): Update.
 219         (info_selectors_command): Update.
 220         (compare_classes): Update.
 221         (info_classes_command): Update.
 222         (find_imps): Update.
 223         * p-typeprint.c (pascal_print_typedef): Update.
 224         * printcmd.c (build_address_symbolic): Update.
 225         (info_address_command): Update.
 226         (print_variable_and_value): Update.
 227         * python/py-framefilter.c (extract_sym): Update.
 228         (py_print_single_arg): Update.
 229         * python/py-symbol.c (sympy_str): Update.
 230         (sympy_get_name): Update.
 231         (sympy_get_linkage_name): Update.
 232         * python/python.c (gdbpy_rbreak): Update.
 233         * record-btrace.c (btrace_get_bfun_name): Update.
 234         (btrace_call_history): Update.
 235         * rust-lang.c (rust_print_typedef): Update.
 236         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 237         * stabsread.c (stab_reg_to_regnum): Update.
 238         (define_symbol): Update.
 239         (read_enum_type): Update.
 240         (common_block_end): Update.
 241         (cleanup_undefined_types_1): Update.
 242         (scan_file_globals): Update.
 243         * stack.c (print_frame_arg): Update.
 244         (print_frame_args): Update.
 245         (find_frame_funname): Update.
 246         (info_frame_command_core): Update.
 247         (iterate_over_block_locals): Update.
 248         (print_block_frame_labels): Update.
 249         (do_print_variable_and_value): Update.
 250         (iterate_over_block_arg_vars): Update.
 251         (return_command): Update.
 252         * symmisc.c (dump_symtab_1): Update.
 253         (print_symbol): Update.
 254         * symtab.c (eq_symbol_entry): Update.
 255         (symbol_cache_dump): Update.
 256         (lookup_language_this): Update.
 257         (find_pc_sect_line): Update.
 258         (skip_prologue_sal): Update.
 259         (symbol_search::compare_search_syms): Update.
 260         (treg_matches_sym_type_name): Update.
 261         (search_symbols): Update.
 262         (print_symbol_info): Update.
 263         (rbreak_command): Update.
 264         (completion_list_add_symbol): Update.
 265         (find_gnu_ifunc): Update.
 266         (get_symbol_address): Update.
 267         (search_module_symbols): Update.
 268         (info_module_subcommand): Update.
 269         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 270         (SYMBOL_LINKAGE_NAME): Remove.
 271         (SYMBOL_DEMANGLED_NAME): Remove.
 272         (SYMBOL_PRINT_NAME): Remove.
 273         (SYMBOL_SEARCH_NAME): Remove.
 274         * tracepoint.c (set_traceframe_context): Update.
 275         (validate_actionline): Update.
 276         (collection_list::collect_symbol): Update.
 277         (encode_actions_1): Update.
 278         (info_scope_command): Update.
 279         (print_one_static_tracepoint_marker): Update.
 280         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 281         * valops.c (address_of_variable): Update.
 282         (find_overload_match): Update.
 283         (find_oload_champ): Update.
 284
 285 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 286
 287         * ada-lang.c (ada_lookup_simple_minsym): Update.
 288         (ada_collect_symbol_completion_matches): Update.
 289         * ada-tasks.c (read_atcb): Update.
 290         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 291         (amd64_windows_skip_trampoline_code): Update.
 292         * arm-tdep.c (skip_prologue_function): Update.
 293         (arm_skip_stack_protector): Update.
 294         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 295         (arm_wince_skip_main_prologue): Update.
 296         * ax-gdb.c (gen_expr): Update.
 297         * block.c (call_site_for_pc): Update.
 298         * blockframe.c (find_pc_partial_function): Update.
 299         * breakpoint.c (set_breakpoint_location_function): Update.
 300         * btrace.c (ftrace_print_function_name): Update.
 301         (ftrace_function_switched): Update.
 302         * c-valprint.c (print_unpacked_pointer): Update.
 303         * coffread.c (coff_symfile_read): Update.
 304         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 305         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 306         * dwarf-index-write.c (write_psymbols): Update.
 307         * dwarf2loc.c (call_site_to_target_addr): Update.
 308         (func_verify_no_selftailcall): Update.
 309         (tailcall_dump): Update.
 310         (call_site_find_chain_1): Update.
 311         (dwarf_expr_reg_to_entry_parameter): Update.
 312         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 313         * eval.c (evaluate_funcall): Update.
 314         (evaluate_subexp_standard): Update.
 315         (evaluate_subexp_for_sizeof): Update.
 316         * expprint.c (print_subexp_standard): Update.
 317         (dump_subexp_body_standard): Update.
 318         * frame.c (get_prev_frame_always_1): Update.
 319         * frv-tdep.c (frv_skip_main_prologue): Update.
 320         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 321         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 322         (gnuv3_get_typename_from_type_info): Update.
 323         (gnuv3_skip_trampoline): Update.
 324         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 325         * i386-tdep.c (i386_skip_main_prologue): Update.
 326         (i386_pe_skip_trampoline_code): Update.
 327         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 328         * infcall.c (get_function_name): Update.
 329         * linespec.c (minsym_found): Update.
 330         * linux-fork.c (info_checkpoints_command): Update.
 331         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 332         (m32c_m16c_pointer_to_address): Update.
 333         * maint.c (maintenance_translate_address): Update.
 334         * minsyms.c (add_minsym_to_hash_table): Update.
 335         (add_minsym_to_demangled_hash_table): Update.
 336         (lookup_minimal_symbol_mangled): Update.
 337         (lookup_minimal_symbol_demangled): Update.
 338         (lookup_minimal_symbol_linkage): Update.
 339         (lookup_minimal_symbol_text): Update.
 340         (lookup_minimal_symbol_by_pc_name): Update.
 341         (minimal_symbol_is_less_than): Update.
 342         (compact_minimal_symbols): Update.
 343         (build_minimal_symbol_hash_tables): Update.
 344         (find_solib_trampoline_target): Update.
 345         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 346         (mips_skip_pic_trampoline_code): Update.
 347         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 348         * objc-lang.c (info_selectors_command): Update.
 349         (info_classes_command): Update.
 350         (find_methods): Update.
 351         (find_imps): Update.
 352         * p-valprint.c (pascal_val_print): Update.
 353         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 354         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 355         * printcmd.c (build_address_symbolic): Update.
 356         (info_symbol_command): Update.
 357         * psymtab.c (psymbol_name_matches): Update.
 358         (match_partial_symbol): Update.
 359         (lookup_partial_symbol): Update.
 360         (print_partial_symbols): Update.
 361         (sort_pst_symbols): Update.
 362         (maintenance_check_psymtabs): Update.
 363         * python/py-framefilter.c (py_print_frame): Update.
 364         * python/python.c (gdbpy_rbreak): Update.
 365         * record-btrace.c (btrace_get_bfun_name): Update.
 366         (btrace_call_history): Update.
 367         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 368         (rs6000_skip_trampoline_code): Update.
 369         * sol-thread.c (info_cb): Update.
 370         * stabsread.c (scan_file_globals): Update.
 371         * stack.c (find_frame_funname): Update.
 372         (info_frame_command_core): Update.
 373         * symmisc.c (dump_msymbols): Update.
 374         * symtab.c (symbol_natural_name): Rename to..,
 375         (general_symbol_info::natural_name): ...this.
 376         (symbol_demangled_name): Rename to...
 377         (general_symbol_info::demangled_name): ...this.
 378         (symbol_search_name): Rename to...
 379         (general_symbol_info::search_name): ...this.
 380         (symbol_matches_search_name): Update.
 381         (find_pc_sect_line): Update.
 382         (skip_prologue_sal): Update.
 383         (search_symbols): Update.
 384         (print_msymbol_info): Update.
 385         (rbreak_command): Update.
 386         (completion_list_add_msymbol): Update.
 387         (completion_list_objc_symbol): Update.
 388         (get_msymbol_address): Update.
 389         * symtab.h (struct general_symbol_info): Add member functions
 390         natural_name (), linkage_name (), print_name (), demangled_name (),
 391         and search_name ().
 392         (SYMBOL_NATURAL_NAME): Update.
 393         (symbol_natural_name): Move to a member function on general_symbol_info.
 394         (SYMBOL_DEMANGLED_NAME): Update.
 395         (symbol_demangled_name): Move to a member function on
 396         general_symbol_info.
 397         (SYMBOL_SEARCH_NAME): Update.
 398         (symbol_search_name): Move to a member function on general_symbol_info.
 399         (MSYMBOL_NATURAL_NAME): Remove.
 400         (MSYMBOL_LINKAGE_NAME): Remove.
 401         (MSYMBOL_PRINT_NAME): Remove.
 402         (MSYMBOL_DEMANGLED_NAME): Remove.
 403         (MSYMBOL_SEARCH_NAME): Remove.
 404         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 405
 406 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 407
 408         * symtab.c (create_demangled_names_hash): Use per_bfd->
 409         minimal_symbol_count for computing the initial size, if greater
 410         than our default size.
 411
 412 2019-11-22  Tom de Vries  <tdevries@suse.de>
 413
 414         * contrib/words.sh: Improve words extraction.
 415
 416 2019-11-22  Tom de Vries  <tdevries@suse.de>
 417
 418         * contrib/words.sh: Combine sed invocations.
 419
 420 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 421
 422         * Makefile.in: Update.
 423         * demangle.c: Rename to...
 424         * gdb-demangle.c: ..this.
 425         (is_cplus_marker): Change return type to bool.
 426         (_initialize_demangler): Rename to...
 427         (_initialize_gdb_demangle): ...this.
 428         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 429         * symtab.h (demangle): Remove declaration; instead include
 430         gdb-demangle.h.
 431
 432 2019-11-21  Tom Tromey  <tromey@adacore.com>
 433
 434         * gdbsupport/format.c (format_pieces): Parse %I64d.
 435         * unittests/format_pieces-selftests.c (test_windows_formats): New
 436         function.
 437         (run_tests): Call it.
 438
 439 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 440
 441         Byte reverse display of variables with DW_END_big, DW_END_little
 442         (DW_AT_endianity) dwarf attributes if different than the native
 443         byte order.
 444         * ada-lang.c (ada_value_binop):
 445         Use type_byte_order instead of gdbarch_byte_order.
 446         * ada-valprint.c (printstr):
 447         (ada_val_print_string):
 448         * ada-lang.c (value_pointer):
 449         (ada_value_binop):
 450         Use type_byte_order instead of gdbarch_byte_order.
 451         * c-lang.c (c_get_string):
 452         Use type_byte_order instead of gdbarch_byte_order.
 453         * c-valprint.c (c_val_print_array):
 454         Use type_byte_order instead of gdbarch_byte_order.
 455         * cp-valprint.c (cp_print_class_member):
 456         Use type_byte_order instead of gdbarch_byte_order.
 457         * dwarf2loc.c (rw_pieced_value):
 458         Use type_byte_order instead of gdbarch_byte_order.
 459         * dwarf2read.c (read_base_type): Handle DW_END_big,
 460         DW_END_little
 461         * f-lang.c (f_get_encoding):
 462         Use type_byte_order instead of gdbarch_byte_order.
 463         * findvar.c (default_read_var_value):
 464         Use type_byte_order instead of gdbarch_byte_order.
 465         * gdbtypes.c (check_types_equal):
 466         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 467         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 468         and TYPE_ENDIANITY_LITTLE if set.
 469         (type_byte_order): new function.
 470         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 471         (struct main_type) <flag_endianity_not_default>:
 472         New field.
 473         (type_byte_order): New function.
 474         * infcmd.c (default_print_one_register_info):
 475         Use type_byte_order instead of gdbarch_byte_order.
 476         * p-lang.c (pascal_printstr):
 477         Use type_byte_order instead of gdbarch_byte_order.
 478         * p-valprint.c (pascal_val_print):
 479         Use type_byte_order instead of gdbarch_byte_order.
 480         * printcmd.c (print_scalar_formatted):
 481         Use type_byte_order instead of gdbarch_byte_order.
 482         * solib-darwin.c (darwin_current_sos):
 483         Use type_byte_order instead of gdbarch_byte_order.
 484         * solib-svr4.c (solib_svr4_r_ldsomap):
 485         Use type_byte_order instead of gdbarch_byte_order.
 486         * stap-probe.c (stap_modify_semaphore):
 487         Use type_byte_order instead of gdbarch_byte_order.
 488         * target-float.c (target_float_same_format_p):
 489         Use type_byte_order instead of gdbarch_byte_order.
 490         * valarith.c (scalar_binop):
 491         (value_bit_index):
 492         Use type_byte_order instead of gdbarch_byte_order.
 493         * valops.c (value_cast):
 494         Use type_byte_order instead of gdbarch_byte_order.
 495         * valprint.c (generic_emit_char):
 496         (generic_printstr):
 497         (val_print_string):
 498         Use type_byte_order instead of gdbarch_byte_order.
 499         * value.c (unpack_long):
 500         (unpack_bits_as_long):
 501         (unpack_value_bitfield):
 502         (modify_field):
 503         (pack_long):
 504         (pack_unsigned_long):
 505         Use type_byte_order instead of gdbarch_byte_order.
 506         * findvar.c (unsigned_pointer_to_address):
 507         (signed_pointer_to_address):
 508         (unsigned_address_to_pointer):
 509         (address_to_signed_pointer):
 510         (default_read_var_value):
 511         (default_value_from_register):
 512         Use type_byte_order instead of gdbarch_byte_order.
 513         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 514         Use type_byte_order instead of gdbarch_byte_order.
 515         * riscv-tdep.c (riscv_print_one_register_info):
 516         Use type_byte_order instead of gdbarch_byte_order.
 517
 518 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 519
 520         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 521         (current_ui_gdb_stdin_ptr): Likewise.
 522         (current_ui_gdb_stderr_ptr): Likewise.
 523         (current_ui_gdb_stdlog_ptr): Likewise.
 524         (current_ui_current_uiout_ptr): Likewise.
 525         (gen_ret_current_ui_field_ptr): Remove.
 526
 527 2019-11-21  Tom de Vries  <tdevries@suse.de>
 528
 529         PR gdb/24956
 530         * cli/cli-script.c (execute_control_command): Only switch to
 531         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 532
 533 2019-11-19  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 536         Now static.  Change type of "name".
 537         (tui_set_win_height_command): Don't copy "arg".
 538         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 539         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 540
 541 2019-11-19  Ali Tamur <tamur@google.com>
 542
 543         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 544         "if (attr != nullptr)".
 545         (dwarf2_find_base_address): Likewise.
 546         (dwarf2_build_include_psymtabs): Likewise.
 547         (read_cutu_die_from_dwo): Likewise.
 548         (read_func_scope): Likewise.
 549         (read_call_site_scope): Likewise.
 550         (dwarf2_get_pc_bounds): Likewise.
 551         (dwarf2_record_block_ranges): Likewise.
 552         (dwarf2_add_field): Likewise.
 553         (dwarf2_add_member_fn): Likewise.
 554         (read_structure_type): Likewise.
 555         (read_enumeration_type): Likewise.
 556         (read_array_type): Likewise.
 557         (read_array_order): Likewise.
 558         (read_set_type): Likewise.
 559         (read_common_block): Likewise.
 560         (read_tag_reference_type): Likewise.
 561         (read_tag_string_type): Likewise.
 562         (read_subroutine_type): Likewise.
 563         (read_base_type): Likewise.
 564         (read_subrange_type): Likewise.
 565         (new_symbol): Likewise.
 566         (prepare_one_comp_unit): Likewise.
 567
 568 2019-11-19  Tom Tromey  <tromey@adacore.com>
 569
 570         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 571         result in error when DebugActiveProcess fails.
 572
 573 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 574             Pedro Alves  <palves@redhat.com>
 575
 576         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 577         * target.c (target_stack::push): Call 'unpush' if there's a
 578         target on top of the stack.
 579
 580 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 581
 582         * python/py-block.c (blpy_dealloc): Call tp_free.
 583         (blpy_block_syms_dealloc): Likewise.
 584         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
 585         * python/py-inferior.c (infpy_dealloc): Likewise.
 586         * python/py-lazy-string.c (stpy_dealloc): Likewise.
 587         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
 588         * python/py-symbol.c (sympy_dealloc): Likewise.
 589         * python/py-symtab.c (stpy_dealloc): Likewise.
 590         * python/py-type.c (typy_iterator_dealloc): Likewise.
 591
 592 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
 593
 594         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
 595         constructor instead of using a class initializer.
 596
 597 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 598
 599         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
 600         * configure: Regenerate.
 601         * configure.ac: Don't source common.host.
 602         * gdbsupport/common.host: Remove.
 603         * gdbsupport/mingw-strerror.c: Remove.
 604         * gdbsupport/posix-strerror.c: Rename to...
 605         * gdbsupport/safe-strerror.c: ...this.
 606
 607 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 608
 609         * maint.c (scoped_command_stats::print_time): Use localtime_r
 610         instead of localtime (provided through gnulib if necessary).
 611         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
 612         of ctime.
 613
 614 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 615
 616         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
 617         avoid compile errors.
 618
 619 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 620
 621         * config.in: Regenerate.
 622         * configure: Regenerate.
 623         * gdbsupport/common.m4: No longer check for strerror_r.
 624         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
 625         POSIX version of strerror_r, now that gnulib provides it if
 626         necessary.
 627
 628 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
 629
 630         * README (`configure' options): Update.
 631
 632 2019-11-14  Tom Tromey  <tromey@adacore.com>
 633
 634         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
 635         expected type for the RHS if the LHS is a convenience variable.
 636
 637 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
 638
 639         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
 640         Provide explicit default and copy constructor.
 641
 642 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 643
 644         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
 645         only call Py_INCREF (newbp) in the bppy_pending_object case.
 646
 647 2019-11-13  Tom Tromey  <tromey@adacore.com>
 648
 649         PR build/25182:
 650         * psympriv.h (partial_symbol): Remove static assert.
 651         * symtab.h (general_symbol_info, symbol): Remove static assert.
 652
 653 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 654
 655         * gdbsupport/format.c (format_pieces::format_pieces): Support
 656         printf 'z' size modifier.
 657         * gdbsupport/format.h (enum argclass): Add size_t_arg.
 658         * printcmd.c (ui_printf):  Handle size_t_arg.
 659         * ui-out.c (ui_out::vmessage): Likewise.
 660         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
 661         function.
 662         (run_tests): Call test_format_int_sizes.
 663
 664 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * ada-exp.y (write_ambiguous_var): Update.
 667         * buildsym.c (add_symbol_to_list): Update.
 668         * dwarf2read.c (read_variable): Update.
 669         (new_symbol): Update.
 670         * jit.c (finalize_symtab): Update.
 671         * language.c (language_alloc_type_symbol): Update.
 672         * symtab.c (fixup_symbol_section): Update.
 673         (initialize_objfile_symbol_1): Move code to...
 674         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 675         (allocate_symbol): Update.
 676         (allocate_template_symbol): Update.
 677         (get_symbol_address): Update.
 678         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 679         of having as a field, and add a constructor.
 680         (SYMBOL_VALUE): Update.
 681         (SYMBOL_VALUE_ADDRESS): Update.
 682         (SET_SYMBOL_VALUE_ADDRESS): Update.
 683         (SYMBOL_VALUE_BYTES): Update.
 684         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 685         (SYMBOL_BLOCK_VALUE): Update.
 686         (SYMBOL_VALUE_CHAIN): Update.
 687         (SYMBOL_LANGUAGE): Update.
 688         (SYMBOL_SECTION): Update.
 689         (SYMBOL_OBJ_SECTION): Update.
 690         (SYMBOL_SET_LANGUAGE): Update.
 691         (SYMBOL_SET_LINKAGE_NAME): Update.
 692         (SYMBOL_SET_NAMES): Update.
 693         (SYMBOL_NATURAL_NAME): Update.
 694         (SYMBOL_LINKAGE_NAME): Update.
 695         (SYMBOL_DEMANGLED_NAME): Update.
 696         (SYMBOL_SEARCH_NAME): Update.
 697         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 698         (struct symbol): Update.
 699         (struct template_symbol): Update.
 700         (struct rust_vtable_symbol): Update.
 701         * xcoffread.c (SYMBOL_DUP): Update.
 702
 703 2019-11-12  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-layout.c (show_layout): Set current_layout.
 706         (show_source_disasm_command, show_data)
 707         (show_source_or_disasm_and_command): Don't set current_layout.
 708
 709 2019-11-12  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 712
 713 2019-11-12  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-win.c (resize_message): New global.
 716         (show_tui_resize_message): New function.
 717         (tui_async_resize_screen): Print message if requested.
 718         (_initialize_tui_win): Add tui-resize-message setting.
 719         * NEWS: Add entry for new commands.
 720
 721 2019-11-11  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 724         functions.
 725
 726 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 727
 728         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 729
 730 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 733         function.
 734         * python/python-internal.h (gdbpy_lookup_static_symbols):
 735         Declare new function.
 736         * python/python.c (python_GdbMethods): Add
 737         gdb.lookup_static_symbols method.
 738         * NEWS: Mention gdb.lookup_static_symbols.
 739
 740 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 743         static block of current object file first.  Also fix typo in
 744         header comment.
 745
 746 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * stack.c (set_last_displayed_sal): Delete.
 749         (last_displayed_sal_valid): Delete.
 750         (last_displayed_pspace): Delete.
 751         (last_displayed_addr): Delete.
 752         (last_displayed_symtab): Delete.
 753         (last_displayed_line): Delete.
 754         (class last_displayed_symtab_info_type): New.
 755         (last_displayed_symtab_info): New static global variable.
 756         (print_frame_info): Call methods on last_displayed_symtab_info.
 757         (clear_last_displayed_sal): Update header comment, and make use of
 758         last_displayed_symtab_info.
 759         (last_displayed_sal_is_valid): Likewise.
 760         (get_last_displayed_pspace): Likewise.
 761         (get_last_displayed_addr): Likewise.
 762         (get_last_displayed_symtab): Likewise.
 763         (get_last_displayed_line): Likewise.
 764         (get_last_displayed_sal): Likewise.
 765         * stack.h (clear_last_displayed_sal): Update header comment.
 766         (last_displayed_sal_is_valid): Likewise.
 767         (get_last_displayed_pspace): Likewise.
 768         (get_last_displayed_addr): Likewise.
 769         (get_last_displayed_symtab): Likewise.
 770         (get_last_displayed_line): Likewise.
 771         (get_last_displayed_sal): Likewise.
 772
 773 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * stack.c (frame_show_address): Convert return type to bool.
 776         * stack.h (frame_show_address): Likewise, and update header
 777         comment.
 778
 779 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
 782         * unittests/vec-utils-selftests.c: New file.
 783         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
 784
 785 2019-11-10  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
 788         (tui_highlight_win): Likewise.
 789         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
 790         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
 791         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 792         Don't set can_highlight.
 793
 794 2019-11-10  Tom Tromey  <tom@tromey.com>
 795
 796         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
 797         Remove unused declaration.
 798
 799 2019-11-08  Tom Tromey  <tromey@adacore.com>
 800
 801         * top.c (read_command_file): Update.
 802         (command_line_input): Make return type const.
 803         * python/py-gdb-readline.c: Update.
 804         * linespec.c (decode_line_2): Update.
 805         * defs.h (command_line_input): Make return type const.
 806         * cli/cli-script.c (read_next_line): Make return type const.
 807         * ada-lang.c (get_selections): Update.
 808
 809 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
 810
 811         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
 812         * mi/mi-main.c (output_cores): Likewise.
 813         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
 814         (linux_xfer_osdata_modules): Likewise.
 815         * remote.c (register_remote_support_xml): Likewise.
 816         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
 817         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
 818
 819 2019-11-06  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-interp.c: Don't include readline.h.
 822         * tui/tui-hooks.c: Don't include readline.h.
 823         * symmisc.c: Include tilde.h, not readline.h.
 824         * symfile.c: Include tilde.h, not readline.h.
 825         * source.c: Include tilde.h, not readline.h.
 826         * solib.c: Include tilde.h, not readline.h.
 827         * psymtab.c: Include tilde.h, not readline.h.
 828         * exec.c: Include tilde.h, not readline.h.
 829         * corelow.c: Include tilde.h, not readline.h.
 830         * cli/cli-dump.c: Include tilde.h, not readline.h.
 831         * cli/cli-cmds.c: Don't include readline.h.
 832
 833 2019-11-05  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
 836         (tui_disassemble): Set addr_size.
 837         (tui_disasm_window::set_contents): Use addr_size.
 838
 839 2019-11-05  Tom Tromey  <tom@tromey.com>
 840
 841         * rust-lang.c (rust_language_defn): Update.
 842         * python/py-value.c (valpy_string): Call c_get_string.
 843         * p-lang.c (pascal_language_defn): Update.
 844         * opencl-lang.c (opencl_language_defn): Update.
 845         * objc-lang.c (objc_language_defn): Update.
 846         * m2-lang.c (m2_language_defn): Update.
 847         * language.c (unknown_language_defn, auto_language_defn): Update.
 848         (default_get_string): Remove.
 849         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
 850         * go-lang.c (go_language_defn): Update.
 851         * f-lang.c (f_language_defn): Update.
 852         * d-lang.c (d_language_defn): Update.
 853         * c-lang.c (c_language_defn, cplus_language_defn)
 854         (asm_language_defn, minimal_language_defn): Update.
 855         * ada-lang.c (ada_language_defn): Update.
 856         * language.h (struct language_defn) <la_get_string>: Remove.
 857         (LA_GET_STRING): Remove.
 858         (default_get_string): Don't declare.
 859
 860 2019-11-05  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-source.h (struct tui_source_window): Inline
 863         constructor.  Remove destructor.
 864         <style_changed, m_observable>: Move to superclass.
 865         * tui/tui-winsource.h (tui_copy_source_line): Declare.
 866         (struct tui_source_window_base): Move private members to end.
 867         <style_changed, m_observable>: Move from tui_source_window.
 868         * tui/tui-winsource.c (tui_copy_source_line): Move from
 869         tui-source.c.  Rename from copy_source_line.  Add special handling
 870         for negative line number.
 871         (tui_source_window_base::style_changed): Move from
 872         tui_source_window.
 873         (tui_source_window_base): Register observer.
 874         (~tui_source_window_base): New.
 875         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
 876         rename.
 877         (tui_source_window::set_contents): Use tui_copy_source_line.
 878         (tui_source_window::tui_source_window): Move to tui-source.h.
 879         (tui_source_window::~tui_source_window): Remove.
 880         (tui_source_window::style_changed): Move to superclass.
 881         * tui/tui-disasm.c (tui_disassemble): Create string file with
 882         styling, when possible.  Add "addr_size" parameter.
 883         (tui_disasm_window::set_contents): Use tui_copy_source_line.
 884         Don't compute maximum size.
 885         (len_without_escapes): New function
 886
 887 2019-11-05  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
 890         std::string.
 891         * tui/tui-winsource.c (tui_show_source_line): Update.
 892         * tui/tui-source.c (tui_source_window::set_contents): Update.
 893         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 894
 895 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * symtab.h (gdb_static_assert): Put && operator at the beginning
 898         of the line instead of the end.
 899
 900 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
 901
 902         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
 903         and sizeof (symbol).
 904         * symtab.h: Add a static_assert for sizeof (partial_symbol).
 905
 906 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 907
 908         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
 909         * configure.host: Mark *-*-solaris2.10* obsolete.
 910         * configure.tgt: Mark Solaris < 11 obsolete.
 911         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
 912         Update target triplet.
 913
 914 2019-11-01  Tom Tromey  <tromey@adacore.com>
 915
 916         * utils.c (print_sys_errmsg): Simplify.
 917
 918 2019-11-01  Tom Tromey  <tromey@adacore.com>
 919
 920         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
 921
 922 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
 923
 924         * configure: Regenerate.
 925         * configure.ac: Remove check for strerror_r.
 926         * gdbsupport/common.m4: Check for strerror_r.
 927
 928 2019-11-01  Luis Machado  <luis.machado@linaro.org>
 929
 930         PR gdb/25124
 931
 932         * arm-tdep.c (arm_per_objfile): Rename to ...
 933         (arm_per_bfd): ... this.
 934         (arm_objfile_data_key): Rename to ...
 935         (arm_bfd_data_key): ... this.
 936         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
 937         data.
 938         (arm_record_special_symbol): Likewise.
 939
 940 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
 943         end.
 944         * c-typeprint.c (c_print_typedef): Likewise.
 945         * f-typeprint.c (f_print_typedef): Likewise.
 946         * m2-typeprint.c (m2_print_typedef): Likewise.
 947         * p-typeprint.c (pascal_print_typedef): Likewise.
 948         * rust-lang.c (rust_print_typedef): Likewise.
 949         * symtab.c (print_symbol_info): Print a newline after calling
 950         typedef_print.
 951
 952 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * symtab.c (info_module_cmdlist): New variable.
 955         (info_module_command): New function.
 956         (search_module_symbols): New function.
 957         (info_module_subcommand): New function.
 958         (struct info_modules_var_func_options): New struct.
 959         (info_modules_var_func_options_defs): New variable.
 960         (make_info_modules_var_func_options_def_group): New function.
 961         (info_module_functions_command): New function.
 962         (info_module_variables_command): New function.
 963         (info_module_var_func_command_completer): New function.
 964         (_initialize_symtab): Register new 'info module functions' and
 965         'info module variables' commands.
 966         * symtab.h (typedef symbol_search_in_module): New typedef.
 967         (search_module_symbols): Declare new function.
 968         * NEWS: Mention new commands.
 969
 970 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
 973         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
 974         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
 975         MODULES_DOMAIN.
 976         (scan_partial_symbols): Only create partial module symbols for non
 977         declarations.
 978         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
 979         and MODULES_DOMAIN.
 980         * symtab.c (search_domain_name): Likewise.
 981         (search_symbols): Likewise.
 982         (print_symbol_info): Likewise.
 983         (symtab_symbol_info): Likewise.
 984         (info_modules_command): New function.
 985         (_initialize_symtab): Register 'info modules' command.
 986         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 987         * NEWS: Mention new 'info modules' command.
 988
 989 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 990
 991         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 992         and $_gdb_maint_setting_str.
 993
 994 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 995
 996         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 997         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 998         (str_value_from_setting, gdb_setting_str_internal_fn)
 999         (gdb_maint_setting_str_internal_fn): New functions.
1000         (_initialize_cli_cmds): Define the new convenience functions.
1001         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1002         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1003
1004 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * agent.c (set_can_use_agent): When the setting is turned on,
1007         look up agent symbols if we don't have them yet.
1008         (agent_new_objfile): Don't look up agent symbols when the agent
1009         setting is off.
1010
1011 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1012
1013         * config.in: Regenerate.
1014
1015 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * configure: Regenerate.
1018         * configure.ac: Check for strerror_r.
1019         * gdbsupport/common-utils.h (safe_strerror): Change return value
1020         to const char * and document that this function is now threadsafe.
1021         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1022         thread_local and call strerror_r, if available.
1023         * utils.c (perror_string): Update.
1024         (print_sys_errmsg): Update.
1025
1026 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1027
1028         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1029         objfile_key.
1030         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1031         objfile to fetch per-bfd data.
1032         (arm_find_exidx_entry): Likewise.
1033
1034 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * gdbsupport/agent.c (debug_agent): Change type to bool.
1037         (use_agent): Likewise.
1038         (all_agent_symbols_look_up): Likewise.
1039         (agent_loaded_p): Change return value to bool.
1040         (agent_look_up_symbols): Update.
1041         (agent_capability_check): Change return value to bool.
1042         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1043         (debug_agent): Change type to bool.
1044         (use_agent): Likewise.
1045         (agent_capability_check): Change return value to bool.
1046
1047 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1048
1049         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1050         (build_minimal_symbol_hash_tables): Code to clear the table moved
1051         to clear_minimal_symbol_hash_tables.
1052         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1053         when needed.
1054
1055 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1056
1057         * infcmd.c: Remove includes.
1058         * infrun.c: Remove includes.
1059
1060 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1061
1062         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1063         (grow_vect): Remove declaration.
1064         (ada_type_of_array): Remove declaration.
1065         (ada_update_initial_language): Remove declaration.
1066         (ada_fold_name): Remove declaration.
1067         (ada_fill_in_ada_prototype): Remove declaration.
1068         (user_select_syms): Remove declaration.
1069         (get_selections): Remove declaration.
1070         (ada_tag_type): Remove declaration.
1071         (ada_value_tag): Remove declaration.
1072         (ada_is_others_clause): Remove declaration.
1073         (ada_in_variant): Remove declaration.
1074         (ada_value_struct_elt): Remove declaration.
1075         (ada_attribute_name): Remove declaration.
1076         (ada_system_address_type): Remove declaration.
1077         * ada-lang.c (ada_watch_location_expression): Make static.
1078         (GROW_VECT): Move here from ada-lang.h.
1079         (grow_vect): Make static.
1080         (ada_update_initial_language): Make static.
1081         (ada_fold_name): Make static.
1082         (ada_type_of_array): Make static.
1083         (encoded_ordered_before): Move up.
1084         (sort_choices): Move up.
1085         (print_signatures): Move up.
1086         (ada_print_symbol_signature): Move up.
1087         (get_selections): Move up and make static.
1088         (user_select_syms): Move up and make static.
1089         (ada_value_struct_elt): Move up and make static.
1090         (ada_tag_type): Make static.
1091         (ada_value_tag): Make static.
1092         (ada_is_others_clause): Make static.
1093         (ada_in_variant): Make static.
1094         (ada_attribute_name): Make static.
1095
1096 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * ada-lang.c: Remove includes.
1099         * ada-typeprint.c: Remove includes.
1100         * ada-valprint.c: Remove includes.
1101
1102 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1103
1104         * addrmap.c: Add static assertions of type size, moved from
1105         _initialize_addrmap.
1106         (_initialize_addrmap): Remove.
1107
1108 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1109
1110         * coffread.c (record_minimal_symbol): Update.
1111         (process_coff_symbol): Update.
1112         * dbxread.c (read_dbx_symtab): Update.
1113         * dwarf2read.c (add_partial_symbol): Update.
1114         (fixup_go_packaging): Update.
1115         (load_partial_dies): Update.
1116         (new_symbol): Update.
1117         * elfread.c (record_minimal_symbol): Change signature to use
1118         gdb::string_view instead of name+len.
1119         (elf_symtab_read): Update.
1120         (elf_rel_plt_read): Update.
1121         * mdebugread.c (parse_partial_symbols): Update.
1122         (handle_psymbol_enumerators): Update.
1123         (new_symbol): Update.
1124         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1125         to use gdb::string_view instead of name+len.
1126         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1127         * psympriv.h (add_psymbol_to_list): Likewise.
1128         * psymtab.c (add_psymbol_to_bcache): Likewise.
1129         (add_psymbol_to_list): Likewise.
1130         * stabsread.c (define_symbol): Update.
1131         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1132         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1133         (symbol_set_names): Likewise.
1134         * xcoffread.c (scan_xcoff_symtab): Update.
1135
1136 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1137
1138         * symtab.h (symbol_set_names): Document that copy_name must be
1139         set to true for non-nullterminated strings.
1140         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1141         linkage_name if the entry was not found and we need to demangle.
1142
1143 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1144
1145         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1146         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1147         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1148         * gdbsupport/gdb_binary_search.h: New file.
1149
1150 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1151
1152         * NEWS: Mention new --with-system-gdbinit-dir option.
1153         * config.in: Regenerate.
1154         * configure: Regenerate.
1155         * configure.ac: Add new option --with-system-gdbinit-dir.
1156         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1157         for a ".gdb" suffix.
1158         * main.c (get_init_files): Change system_gdbinit argument to
1159         a vector and return the files in SYSTEM_GDBINIT_DIR in
1160         addition to SYSTEM_GDBINIT.
1161         (captured_main_1): Update.
1162         (print_gdb_help): Update.
1163         * top.c (print_gdb_configuration): Also print the value of
1164         SYSTEM_GDBINIT_DIR.
1165
1166 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1167
1168         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1169         that takes gdb::string_view arguments.
1170
1171 2019-10-26  Tom de Vries  <tdevries@suse.de>
1172
1173         * aarch64-linux-tdep.c: Fix typos in comments.
1174         * aarch64-tdep.c: Same.
1175         * ada-lang.c: Same.
1176         * amd64-nat.c: Same.
1177         * arc-tdep.c: Same.
1178         * arch/aarch64-insn.c: Same.
1179         * block.c: Same.
1180         * breakpoint.h: Same.
1181         * btrace.h: Same.
1182         * c-varobj.c: Same.
1183         * cli/cli-decode.c: Same.
1184         * cli/cli-script.c: Same.
1185         * cli/cli-utils.h: Same.
1186         * coff-pe-read.c: Same.
1187         * coffread.c: Same.
1188         * compile/compile-cplus-symbols.c: Same.
1189         * compile/compile-object-run.c: Same.
1190         * completer.c: Same.
1191         * corelow.c: Same.
1192         * cp-support.c: Same.
1193         * demangle.c: Same.
1194         * dwarf-index-write.c: Same.
1195         * dwarf2-frame.c: Same.
1196         * dwarf2-frame.h: Same.
1197         * eval.c: Same.
1198         * frame-base.h: Same.
1199         * frame.h: Same.
1200         * gdbcmd.h: Same.
1201         * gdbtypes.h: Same.
1202         * gnu-nat.c: Same.
1203         * guile/scm-objfile.c: Same.
1204         * i386-tdep.c: Same.
1205         * i386-tdep.h: Same.
1206         * infcall.c: Same.
1207         * infcall.h: Same.
1208         * linux-nat.c: Same.
1209         * m68k-tdep.c: Same.
1210         * macroexp.c: Same.
1211         * memattr.c: Same.
1212         * mi/mi-cmd-disas.c: Same.
1213         * mi/mi-getopt.h: Same.
1214         * mi/mi-main.c: Same.
1215         * minsyms.c: Same.
1216         * nat/aarch64-sve-linux-sigcontext.h: Same.
1217         * objfiles.h: Same.
1218         * ppc-linux-nat.c: Same.
1219         * ppc-linux-tdep.c: Same.
1220         * ppc-tdep.h: Same.
1221         * progspace.h: Same.
1222         * prologue-value.h: Same.
1223         * python/py-evtregistry.c: Same.
1224         * python/py-instruction.h: Same.
1225         * record-btrace.c: Same.
1226         * record-full.c: Same.
1227         * remote.c: Same.
1228         * rs6000-tdep.c: Same.
1229         * ser-tcp.c: Same.
1230         * sol-thread.c: Same.
1231         * sparc-sol2-tdep.c: Same.
1232         * sparc64-tdep.c: Same.
1233         * stabsread.c: Same.
1234         * symfile.c: Same.
1235         * symtab.h: Same.
1236         * target.c: Same.
1237         * tracepoint.c: Same.
1238         * tui/tui-data.h: Same.
1239         * tui/tui-io.c: Same.
1240         * tui/tui-win.c: Same.
1241         * tui/tui.c: Same.
1242         * unittests/rsp-low-selftests.c: Same.
1243         * user-regs.h: Same.
1244         * utils.c: Same.
1245         * utils.h: Same.
1246         * valarith.c: Same.
1247         * valops.c: Same.
1248         * valprint.c: Same.
1249         * valprint.h: Same.
1250         * value.c: Same.
1251         * value.h: Same.
1252         * varobj.c: Same.
1253         * x86-nat.h: Same.
1254         * xtensa-tdep.c: Same.
1255
1256 2019-10-25  Ali Tamur <tamur@google.com>
1257
1258         * charset.c (find_charset_names): Reflect API change.
1259
1260 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1261
1262         * symtab.c (struct demangled_name_entry): Change demangled name
1263         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1264         part of the struct anymore.
1265         (symbol_set_names): No longer obstack allocate + copy the demangled
1266         name, just store the allocated name from bfd.
1267
1268 2019-10-25  Tom Tromey  <tromey@adacore.com>
1269
1270         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1271         (bsearch_cie_cmp, add_cie): Remove.
1272         (find_cie): Reimplement.
1273         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1274         (dwarf2_build_frame_info): Update.
1275
1276 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1277
1278         PR gdb/25126
1279         * symfile.c (reread_symbols): Call forget_cached_source_info to
1280         clear the stale source cache.
1281
1282 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1283
1284         * configure: Regenerate.
1285         * configure.ac: Remove code that sets python_has_threads.
1286
1287 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1288
1289         * config.in: Regenerate.
1290         * configure: Regenerate.
1291         * configure.ac: Remove the code that uses sed to get the python
1292         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1293
1294 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1297         error paths.
1298
1299 2019-10-23  Tom Tromey  <tom@tromey.com>
1300
1301         * arc-tdep.c: Remove ".." from include.
1302         * frv-tdep.c: Remove ".." from include.
1303         * lm32-tdep.c: Remove ".." from include.
1304         * microblaze-tdep.c: Remove ".." from include.
1305         * or1k-tdep.h: Remove ".." from include.
1306         * s12z-tdep.c: Remove ".." from include.
1307         * Makefile.in (OPCODES_CFLAGS): Add comment.
1308         (TOP_CFLAGS): New variable.
1309         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1310
1311 2019-10-23  Tom Tromey  <tom@tromey.com>
1312
1313         * Makefile.in (READLINE_DIR): Update.
1314
1315 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1316
1317         * infcall.c (call_function_by_hand_dummy): Fix the function
1318         comment.  And extract out a code section into...
1319         (reserve_stack_space): ...this new function.
1320
1321 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1322
1323         * infcall.c (value_arg_coerce): Remove an unused parameter.
1324         (call_function_by_hand_dummy): Update the call to
1325         'value_arg_coerce'.
1326
1327 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1328
1329         * infcall.c (call_function_by_hand_dummy): Refactor.
1330
1331 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1332
1333         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1334
1335 2019-10-23  Tom Tromey  <tom@tromey.com>
1336
1337         * configure: Rebuild.
1338         * configure.ac: Don't check for sigprocmask.
1339         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1340
1341 2019-10-23  Tom Tromey  <tom@tromey.com>
1342
1343         * configure: Rebuild.
1344         * acinclude.m4: Use m4_include, not sinclude.
1345
1346 2019-10-23  Tom de Vries  <tdevries@suse.de>
1347
1348         PR breakpoints/24687
1349         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1350
1351 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1352
1353         * symtab.c (struct demangled_name_entry) <language>: Change from
1354         bitfield to regular variable.
1355
1356 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1357
1358         * symtab.c (struct demangled_name_entry): Add a constructor.
1359         (free_demangled_name_entry): New function to call the destructor
1360         for demangled_name_entry.
1361         (create_demangled_names_hash): Pass free_demangled_name_entry to
1362         htab_create_alloc.
1363         (symbol_set_names): Call placement new for demangled_name_entry.
1364         * utils.c: No longer include xxhash.h here, now that fast_hash
1365         is inlined in the header.
1366         * utils.h: Instead, include it here.
1367
1368 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1369
1370         * Makefile.in: Link with libxxhash.
1371         * config.in: Regenerate.
1372         * configure: Regenerate.
1373         * configure.ac: Search for libxxhash.
1374         * utils.c (fast_hash): Use xxhash if present.
1375
1376 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1377
1378         * utils.h (fast_hash): New function.
1379         * symtab.c (hash_demangled_name_entry): Call new function
1380         fast_hash.
1381
1382 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1383
1384         * symtab.c (struct demangled_name_entry): Change type of mangled
1385         to gdb::string_view. Also adds a constructor that takes the
1386         mangled name.
1387         (hash_demangled_name_entry): Update.
1388         (eq_demangled_name_entry): Update.
1389         (free_demangled_name_entry): New function to call the destructor
1390         now that this is not a POD anymore.
1391         (create_demangled_names_hash): Pass free_demangled_name_entry to
1392         htab_create_alloc.
1393         (symbol_set_names): Update.
1394
1395 2019-10-21  Ali Tamur  <tamu@google.com>
1396
1397         * dwarf2read.c (dir_index): Change type.
1398         (file_name_index): Likewise.
1399         (line_header::include_dir_at): Change comment and implementation on
1400         whether it is DWARF 5.
1401         (line_header::is_valid_file_index): New function.
1402         (line_header::file_name_at): Change comment and implementation on
1403         whether it is DWARF 5.
1404         (line_header::file_names): Change to private field renamed as
1405         m_file_names and introduce a new accessor method.
1406         (line_header::file_names_size): New method.
1407         (line_header::include_dirs): Change to private field and rename as
1408         m_include_dirs.
1409         (dw2_get_file_names_reader): Define local var at a smaller scope and
1410         reflect API change.
1411         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1412         (process_structure_scope): Likewise.
1413         (line_header::add_include_dir): Change message and reflect renaming.
1414         (line_header::add_file_name): Likewise.
1415         (read_formatted_entries): Handle DW_FORM_data16.
1416         (dwarf_decode_line_header): Fix line header length calculation.
1417         (psymtab_include_file_name): Change comment and API.
1418         (lnp_state_machine::m_file): Update comment and reflect type change.
1419         (lnp_state_machine::record_line): Reflect type change.
1420         (dwarf_decode_lines): Reflect API change.
1421         (file_file_name): Likewise.
1422         (file_full_name): Likewise.
1423
1424 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1427
1428 2019-10-21  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1431
1432 2019-10-21  Tom Tromey  <tom@tromey.com>
1433
1434         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1435         NM_H.   Use AC_CONFIG_LINKS.
1436         * configure: Rebuild.
1437         * Makefile.in (NM_H): New variable.
1438         (generated_files): Add NM_H.  Remove gcore.
1439         (nm.h, stamp-nmh): New targets.
1440
1441 2019-10-20  Tom Tromey  <tom@tromey.com>
1442
1443         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1444         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1445         obsolete comment.
1446         (put_objfile_before): Now static.
1447
1448 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1449
1450         * gdbsupport/common-utils.h (startswith): Change return type to
1451         bool.
1452
1453 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1454
1455         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1456         * breakpoint.c (bp_locations_compare): Rename to...
1457         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1458         (update_global_location_list): Use std::sort instead of qsort.
1459         * buildsym.c (compare_line_numbers): Rename to...
1460         (lte_is_less_than): ...this, and change to std::sort semantics.
1461         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1462         instead of qsort.
1463         * disasm.c (compare_lines): Rename to...
1464         (line_is_less_than): ...this, and change to std::sort semantics.
1465         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1466         of qsort.
1467         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1468         (fde_is_less_than): ...this, and change to std::sort semantics.
1469         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1470         * mdebugread.c (compare_blocks):
1471         (block_is_less_than): ...this, and change to std::sort semantics.
1472         (sort_blocks): Call std::sort instead of qsort.
1473         * objfiles.c (qsort_cmp): Rename to...
1474         (sort_cmp): ...this, and change to std::sort semantics.
1475         (update_section_map): Call std::sort instead of qsort.
1476         * remote.c (compare_pnums): Remove.
1477         (map_regcache_remote_table): Call std::sort instead of qsort.
1478         * utils.c (compare_positive_ints): Remove.
1479         * utils.h (compare_positive_ints): Remove.
1480         * xcoffread.c (compare_lte): Remove.
1481         (arrange_linetable): Call std::sort instead of qsort.
1482
1483 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1484
1485         * symfile.c (init_entry_point_info): Fix typo.
1486         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1487
1488 2019-10-18  Tom de Vries  <tdevries@suse.de>
1489
1490         * aarch64-tdep.c: Fix typos in comments.
1491         * ada-lang.c: Same.
1492         * ada-tasks.c: Same.
1493         * alpha-tdep.c: Same.
1494         * alpha-tdep.h: Same.
1495         * amd64-nat.c: Same.
1496         * amd64-windows-tdep.c: Same.
1497         * arc-tdep.c: Same.
1498         * arc-tdep.h: Same.
1499         * arch-utils.c: Same.
1500         * arm-nbsd-tdep.c: Same.
1501         * arm-tdep.c: Same.
1502         * ax-gdb.c: Same.
1503         * blockframe.c: Same.
1504         * btrace.c: Same.
1505         * c-varobj.c: Same.
1506         * coff-pe-read.c: Same.
1507         * coffread.c: Same.
1508         * cris-tdep.c: Same.
1509         * darwin-nat.c: Same.
1510         * dbxread.c: Same.
1511         * dcache.c: Same.
1512         * disasm.c: Same.
1513         * dtrace-probe.c: Same.
1514         * dwarf-index-write.c: Same.
1515         * dwarf2-frame-tailcall.c: Same.
1516         * dwarf2-frame.c: Same.
1517         * dwarf2read.c: Same.
1518         * eval.c: Same.
1519         * exceptions.c: Same.
1520         * fbsd-tdep.c: Same.
1521         * findvar.c: Same.
1522         * frame.c: Same.
1523         * frv-tdep.c: Same.
1524         * gnu-v3-abi.c: Same.
1525         * go32-nat.c: Same.
1526         * h8300-tdep.c: Same.
1527         * hppa-tdep.c: Same.
1528         * i386-linux-tdep.c: Same.
1529         * i386-tdep.c: Same.
1530         * ia64-libunwind-tdep.c: Same.
1531         * ia64-tdep.c: Same.
1532         * infcmd.c: Same.
1533         * infrun.c: Same.
1534         * linespec.c: Same.
1535         * linux-nat.c: Same.
1536         * linux-thread-db.c: Same.
1537         * machoread.c: Same.
1538         * mdebugread.c: Same.
1539         * mep-tdep.c: Same.
1540         * mn10300-tdep.c: Same.
1541         * namespace.c: Same.
1542         * objfiles.c: Same.
1543         * opencl-lang.c: Same.
1544         * or1k-tdep.c: Same.
1545         * osabi.c: Same.
1546         * ppc-linux-nat.c: Same.
1547         * ppc-linux-tdep.c: Same.
1548         * ppc-sysv-tdep.c: Same.
1549         * printcmd.c: Same.
1550         * procfs.c: Same.
1551         * record-btrace.c: Same.
1552         * record-full.c: Same.
1553         * remote-fileio.c: Same.
1554         * remote.c: Same.
1555         * rs6000-tdep.c: Same.
1556         * s12z-tdep.c: Same.
1557         * score-tdep.c: Same.
1558         * ser-base.c: Same.
1559         * ser-go32.c: Same.
1560         * skip.c: Same.
1561         * sol-thread.c: Same.
1562         * solib-svr4.c: Same.
1563         * solib.c: Same.
1564         * source.c: Same.
1565         * sparc-nat.c: Same.
1566         * sparc-sol2-tdep.c: Same.
1567         * sparc-tdep.c: Same.
1568         * sparc64-tdep.c: Same.
1569         * stabsread.c: Same.
1570         * stack.c: Same.
1571         * symfile.c: Same.
1572         * symtab.c: Same.
1573         * target-descriptions.c: Same.
1574         * target-float.c: Same.
1575         * thread.c: Same.
1576         * utils.c: Same.
1577         * valops.c: Same.
1578         * valprint.c: Same.
1579         * value.c: Same.
1580         * varobj.c: Same.
1581         * windows-nat.c: Same.
1582         * xcoffread.c: Same.
1583         * xstormy16-tdep.c: Same.
1584         * xtensa-tdep.c: Same.
1585
1586 2019-10-17  Tom Tromey  <tromey@adacore.com>
1587
1588         * configure: Rebuild.
1589         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1590         in AC_CONFIG_FILES invocation.
1591         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1592         new-style config.status invocation.
1593
1594 2019-10-17  Tom de Vries  <tdevries@suse.de>
1595
1596         * arm-nbsd-nat.c: Fix typos in comments.
1597         * arm-tdep.c: Same.
1598         * darwin-nat-info.c: Same.
1599         * dwarf2read.c: Same.
1600         * elfread.c: Same.
1601         * event-top.c: Same.
1602         * findvar.c: Same.
1603         * gdbtypes.c: Same.
1604         * hppa-tdep.c: Same.
1605         * i386-tdep.c: Same.
1606         * jit.c: Same.
1607         * main.c: Same.
1608         * mdebugread.c: Same.
1609         * moxie-tdep.c: Same.
1610         * nto-procfs.c: Same.
1611         * osabi.c: Same.
1612         * ppc-linux-tdep.c: Same.
1613         * remote.c: Same.
1614         * riscv-tdep.c: Same.
1615         * s390-tdep.c: Same.
1616         * sh-tdep.c: Same.
1617         * sparc-linux-tdep.c: Same.
1618         * sparc-nat.c: Same.
1619         * stack.c: Same.
1620         * target-descriptions.c: Same.
1621         * top.c: Same.
1622         * varobj.c: Same.
1623
1624 2019-10-16  Tom Tromey  <tom@tromey.com>
1625
1626         * objfiles.h (struct objfile) <original_name>: Now const.
1627
1628 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1629
1630         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1631         pass on to sigsetjmp's second argument.
1632         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1633
1634 2019-10-16  Keith Seitz  <keiths@redhat.com>
1635
1636         PR gdb/23567
1637         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1638         sections whose size is greater than the file size.
1639
1640 2019-10-16  Jim Wilson  <jimw@sifive.com>
1641
1642         * riscv-tdep.c (riscv_gcc_target_options): New.
1643         (riscv_gnu_triplet_regexp): New.
1644         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1645         set_gdbarch_gnu_triplet_regexp.
1646
1647 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1648
1649         * Makefile.in: Add xml-builtin.h.
1650         * features/feature_to_c.sh: Add an include for xml-builtin.h
1651         to ensure that the compiler checks that the types match.
1652         * xml-builtin.h: New file.
1653         * xml-support.c (fetch_xml_builtin): Add missing const.
1654         * xml-support.h: Remove declaration of xml_builtins.
1655
1656 2019-10-16  Tom de Vries  <tdevries@suse.de>
1657
1658         PR tdep/25096
1659         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1660         (amd64_classify_aggregate): ... here.
1661         (amd64_classify_aggregate_field): Handled fiels of nested structs
1662         recursively.
1663
1664 2019-10-16  Tom de Vries  <tdevries@suse.de>
1665
1666         PR tdep/24104
1667         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1668         that handles 'theclass'.
1669
1670 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1671
1672         * linespec.c (decode_digits_ordinary): Update comment.
1673         * make-target-delegates: No longer need to handle VEC case.
1674         * memrange.c (normalize_mem_ranges): Update comment.
1675         * namespace.c (add_using_directive): Update comment.
1676         * objc-lang.c (uniquify_strings): Update comment.
1677         * ppc-linux-nat.c (struct thread_points): Update comment.
1678         * probe.h (find_probes_in_objfile): Update comment.
1679         * target.h (enum flash_preserve_mode): Update comment.
1680         * varobj.c (varobj_restrict_range): Update comment.
1681         * varobj.h (varobj_list_children): Update comment.
1682
1683 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * Makefile.in: Remove references to vec.h and vec.c.
1686         * aarch64-tdep.c: No longer include vec.h.
1687         * ada-lang.c: Likewise.
1688         * ada-lang.h: Likewise.
1689         * arm-tdep.c: Likewise.
1690         * ax.h: Likewise.
1691         * breakpoint.h: Likewise.
1692         * charset.c: Likewise.
1693         * cp-support.h: Likewise.
1694         * dtrace-probe.c: Likewise.
1695         * dwarf2read.c: Likewise.
1696         * extension.h: Likewise.
1697         * gdb_bfd.c: Likewise.
1698         * gdbsupport/gdb_vecs.h: Likewise.
1699         * gdbsupport/vec.c: Remove.
1700         * gdbsupport/vec.h: Remove.
1701         * gdbthread.h: Likewise.
1702         * guile/scm-type.c: Likewise.
1703         * inline-frame.c: Likewise.
1704         * machoread.c: Likewise.
1705         * memattr.c: Likewise.
1706         * memrange.h: Likewise.
1707         * namespace.h: Likewise.
1708         * nat/linux-btrace.h: Likewise.
1709         * osdata.c: Likewise.
1710         * parser-defs.h: Likewise.
1711         * progspace.h: Likewise.
1712         * python/py-type.c: Likewise.
1713         * record-btrace.c: Likewise.
1714         * rust-exp.y: Likewise.
1715         * solib-target.c: Likewise.
1716         * stap-probe.c: Likewise.
1717         * target-descriptions.c: Likewise.
1718         * target-memory.c: Likewise.
1719         * target.h: Likewise.
1720         * varobj.c: Likewise.
1721         * varobj.h: Likewise.
1722         * xml-support.h: Likewise.
1723
1724 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1727         Update for new std::vector based implementation.
1728         (process_psymtab_comp_unit_reader): Likewise.
1729         (scan_partial_symbols): Likewise.
1730         (recursively_compute_inclusions): Likewise.
1731         (compute_compunit_symtab_includes): Likewise.
1732         (process_imported_unit_die): Likewise.
1733         (queue_and_load_dwo_tu): Likewise.
1734         (follow_die_sig_1): Likewise.
1735         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1736         (typedef dwarf2_per_cu_ptr): Remove.
1737         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1738         function.
1739         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1740         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1741         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1742         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1743         std::vector.
1744
1745 2019-10-15  Tom Tromey  <tromey@adacore.com>
1746
1747         * windows-nat.c (windows_nat_target::resume): Use %x when logging
1748         TID.
1749
1750 2019-10-15  Tom Tromey  <tromey@adacore.com>
1751
1752         * windows-nat.c (windows_nat_target::fetch_registers)
1753         (windows_nat_target::store_registers): Rename "pid" to "tid".
1754
1755 2019-10-15  Tom Tromey  <tromey@adacore.com>
1756
1757         * gdbarch.h, gdbarch.c: Rebuild.
1758         * gdbarch.sh (gcc_target_options): Change return type to
1759         std::string.
1760         * compile/compile.c (get_args): Update.
1761         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1762         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1763         std::string.
1764         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1765         std::string.
1766         * arch-utils.c (default_gcc_target_options): Return std::string.
1767         * arch-utils.h (default_gcc_target_options): Return std::string.
1768         * s390-tdep.c (s390_gcc_target_options): Return std::string.
1769
1770 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1771
1772         * breakpoint.c (breakpoint_chain): Make static.
1773         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1774         of accessing breakpoint_chain.
1775
1776 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
1777
1778         * breakpoint.c (iterate_over_breakpoints): Change function pointer
1779         to a gdb::function_view and return value to bool.
1780         * breakpoint.h (iterate_over_breakpoints): Likewise.
1781         * dummy-frame.c (pop_dummy_frame_bpt): Update.
1782         (pop_dummy_frame): Update.
1783         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1784         (gdbscm_breakpoints): Update.
1785         * python/py-breakpoint.c (build_bp_list): Update.
1786         (gdbpy_breakpoints): Update.
1787         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1788         Update.
1789         (bpfinishpy_handle_stop): Update.
1790         (bpfinishpy_handle_exit): Update.
1791         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1792         (svr4_update_solib_event_breakpoints): Update.
1793
1794 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
1795
1796         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1797         when unwrapping single-field structs.
1798
1799 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
1800
1801         * dwarf2read.c: Remove includes.
1802
1803 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
1804
1805         * ui-out.c (ui_out::call_do_message): Silence
1806         -Wformat-nonliteral warning.
1807
1808 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
1809
1810         * breakpoint.c: Remove some includes: continuations.h, skip.h,
1811         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
1812         include: readline/tilde.h.
1813
1814 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1815
1816         * remote.c (remote_target::get_trace_status): Remove declaration of
1817         trace_regblock_size.
1818
1819 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
1820
1821         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1822         (show_user): Remove declaration of cmdlist.
1823         * cli/cli-cmds.h (max_user_call_depth): Declare.
1824         * cli/cli-script.c (execute_user_command): Remove declaration
1825         of max_user_call_depth.
1826
1827 2019-10-11  Jim Wilson  <jimw@sifive.com>
1828
1829         * gdbsupport/print-utils.h (pulongest): Fix comment.
1830         (plongest): Likewise.
1831         (phex): Add missing comment, mention leading zeros.
1832         (phex_nz): Add mention of no leading zeros to comment.
1833
1834         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1835         plongest instead of unsigned long long cast.
1836
1837 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1838
1839         * main.c (captured_main_1): Include gdbtk.h and remove declarations
1840         for external_editor_command and gdbtk_test.
1841
1842 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
1843
1844         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1845         * varobj.c (varobjdebug): Move comment to...
1846         * varobj.h (varobjdebug): ...here, and declare.
1847
1848 2019-10-09  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1851         erase_data_content.
1852
1853 2019-10-09  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1856         * tui/tui-stack.c (tui_locator_window::rerender): Update.
1857         * tui/tui-command.c (tui_cmd_window::resize)
1858         (tui_refresh_cmd_win): Update.
1859         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1860         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1861         * tui/tui-data.c (~tui_gen_win_info): Remove.
1862         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1863         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1864         (tui_redisplay_readline, tui_mld_flush)
1865         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1866         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1867         (tui_data_window::erase_data_content)
1868         (tui_data_item_window::rerender)
1869         (tui_data_item_window::refresh_window): Update.
1870         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1871         (box_win, tui_gen_win_info::make_window)
1872         (tui_gen_win_info::make_visible): Update.
1873         (tui_delete_win): Remove.
1874         * tui/tui-winsource.c
1875         (tui_source_window_base::do_erase_source_content): Update.
1876         (tui_show_source_line, tui_source_window_base::update_tab_width)
1877         (tui_source_window_base::update_exec_info): Update.
1878         * tui/tui-data.h (struct curses_deleter): New.
1879         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1880         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1881
1882 2019-10-09  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1885
1886 2019-10-09  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1889         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1890
1891 2019-10-09  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1894         window height directly.
1895         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1896         declare.
1897         * tui/tui-layout.c (tui_default_win_height): Remove.
1898         (tui_default_win_viewport_height): Remove.
1899
1900 2019-10-09  Tom Tromey  <tom@tromey.com>
1901
1902         * tui/tui.h: Remove comments.
1903
1904 2019-10-09  Tom de Vries  <tdevries@suse.de>
1905
1906         * python/lib/gdb/printer/bound_registers.py: Use
1907         '^builtin_type_bound128' as regexp argument for
1908         add_builtin_pretty_printer.
1909
1910 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1911
1912         * guile/guile.c (guile_extension_script_ops): Remove forward
1913         declaration and mark as static.
1914         (guile_script_ops): Likewise.
1915         (extension_language_guile): Move further down in the file so
1916         it can reference the definitions for guile_{extension_,}script_ops.
1917
1918 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1919
1920         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1921         except SORTL, DFLTCC, and KDSA.
1922
1923 2019-10-08  Tom Tromey  <tromey@adacore.com>
1924
1925         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1926         (struct safe_symbol_file_add_args): Remove.
1927
1928 2019-10-08  Tom Tromey  <tromey@adacore.com>
1929
1930         * windows-nat.c: Don't include buildsym-legacy.h.
1931
1932 2019-10-08  Tom Tromey  <tromey@adacore.com>
1933
1934         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1935
1936 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1937
1938         * gdbtypes.c (overload_debug): Move comment to header.
1939         * gdbtypes.h (overload_debug): Declare.
1940         * valops.c: Remove declaration of overload_debug, instead
1941         include gdbtypes.h.
1942
1943 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1944
1945         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1946         through _().
1947         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1948         move comment...
1949         * language.h (lang_frame_mismatch_warn): ... here. Also add
1950         declaration.
1951         * top.c (lang_frame_mismatch_warn): Remove declaration.
1952         (check_frame_language_change): Pass lang_frame_mismatch_warn
1953         through _().
1954
1955 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1956
1957         * c-lang.h (vtbl_ptr_name): Declare.
1958         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1959         it from the header.
1960         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1961
1962 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1963
1964         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1965         gdb_static_assert.
1966
1967 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1968
1969         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1970         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1971         * ctfread.c: New file.
1972         * ctfread.h: New file.
1973         * elfread.c: Include ctfread.h.
1974         (struct elfinfo text_p): New member ctfsect.
1975         (elf_locate_sections): Mark CTF section.
1976         (elf_symfile_read): Call elfctf_build_psymtabs.
1977         * Makefile.in (LIBCTF): Add.
1978         (CLIBS): Use it.
1979         (CDEPS): Likewise.
1980         (DIST): Add ctfread.c.
1981
1982 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * ctfread.c (struct nextfield): Renamed to ...
1985         (struct ctf_nextfield): ... this.
1986         (struct field_info): Renamed to ...
1987         (strut ctf_field_info): ... this.
1988         (attach_fields_to_type): Update for renamed structures.
1989         (ctf_add_member_cb): Likewise.
1990         (ctf_add_enum_member_cb): Likewise.
1991         (process_struct_members): Likewise.
1992         (process_enum_type): Likewise.
1993
1994 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1995
1996         * tracectf.h: Rename, was ctf.h.
1997         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1998         * tracefile.c: Likewise.
1999         * tracepoint.c: Remove unused include ctf.h.
2000         * mi/mi-main.c: Likewise.
2001         * Makefile.in Replace ctf.c with tracectf.c.
2002
2003 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2004
2005         * version.in: Change version number to "9.0.50.DATE-git".
2006
2007 2019-10-03  Tom Tromey  <tom@tromey.com>
2008
2009         PR rust/24976:
2010         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2011
2012 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2013
2014         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2015         cp_search_name_hash.
2016         * NEWS: Add entry about nested function support.
2017
2018 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2019             Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2022         for nested static variables when searchin VAR_DOMAIN.
2023         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2024         global scope, update comment.
2025         (add_partial_subprogram): Call add_partial_subprogram recursively
2026         for nested subroutines when processinng Fortran.
2027         (load_partial_dies): Process the child entities of a subprogram
2028         when processing Fortran.
2029         (partial_die_parent_scope): Handle building scope
2030         for Fortran nested functions.
2031         (process_die): Record that nested functions have a scope.
2032         (new_symbol): Always record Fortran subprograms on the global
2033         symbol list.
2034         (determine_prefix): How to build the prefix for Fortran
2035         subprograms.
2036
2037 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2040         have just sent the thread a SIGSTOP and are waiting for it to
2041         arrive.
2042
2043 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * btrace.c (btrace_add_pc): Remove whitespace before the template
2046         parameter in 'std::vector <...>'.
2047         (parse_xml_btrace_block): Likewise.
2048         (btrace_maint_decode_pt): Likewise.
2049         (btrace_maint_update_packets): Likewise.
2050         (btrace_maint_print_packets): Likewise.
2051         * btrace.h (struct btrace_maint_info): Likewise.
2052         * dwarf2read.c (struct type_unit_group): Likewise.
2053         (build_type_psymtabs_reader): Likewise.
2054         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2055         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2056         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2057
2058 2019-10-03  Tom de Vries  <tdevries@suse.de>
2059
2060         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2061         the first line of the help text for set/show style metadata.
2062
2063 2019-10-02  Tom Tromey  <tromey@adacore.com>
2064
2065         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2066         * gdbsupport/common-inferior.c: New file.
2067         * infcmd.c (startup_with_shell): Don't define.
2068         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2069         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2070         * inferior.h (startup_with_shell): Don't declare.
2071
2072 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2073
2074         * gdbsupport/gdb_assert.h: Include errors.h.
2075         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2076
2077 2019-10-02  Tom Tromey  <tromey@adacore.com>
2078
2079         * NEWS: Add $_ada_exception entry.
2080         * ada-lang.c (struct ada_catchpoint): Add constructor.
2081         <m_kind>: New member.
2082         (allocate_location_exception, re_set_exception): Remove
2083         "ex" parameter.
2084         (should_stop_exception): Compute $_ada_exception.
2085         (check_status_exception, print_it_exception)
2086         (print_one_exception, print_mention_exception): Remove
2087         "ex" parameter.
2088         (allocate_location_catch_exception, re_set_catch_exception)
2089         (check_status_exception, print_it_catch_exception)
2090         (print_one_catch_exception, print_mention_catch_exception)
2091         (print_recreate_catch_exception)
2092         (allocate_location_catch_exception_unhandled)
2093         (re_set_catch_exception_unhandled)
2094         (check_status_exception, print_it_catch_exception_unhandled)
2095         (print_one_catch_exception_unhandled)
2096         (print_mention_catch_exception_unhandled)
2097         (print_recreate_catch_exception_unhandled)
2098         (allocate_location_catch_assert, re_set_catch_assert)
2099         (check_status_assert, print_it_catch_assert)
2100         (print_one_catch_assert, print_mention_catch_assert)
2101         (print_recreate_catch_assert)
2102         (allocate_location_catch_handlers, re_set_catch_handlers)
2103         (check_status_handlers, print_it_catch_handlers)
2104         (print_one_catch_handlers, print_mention_catch_handlers)
2105         (print_recreate_catch_handlers): Remove.
2106         (create_ada_exception_catchpoint): Update.
2107         (initialize_ada_catchpoint_ops): Update.
2108
2109 2019-10-02  Tom Tromey  <tromey@adacore.com>
2110
2111         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2112         (create_excep_cond_exprs): Simplify exception string computation.
2113         (ada_exception_catchpoint_cond_string): Likewise.
2114
2115 2019-10-02  Tom Tromey  <tromey@adacore.com>
2116
2117         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2118         * ada-lang.c (lesseq_defined_than): Handle
2119         LOC_STATIC.
2120         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2121         parameter.
2122         (dwarf2_has_info): Likewise.
2123         (new_symbol): Set maybe_copied on symbol when
2124         appropriate.
2125         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2126         parameter.
2127         <can_copy>: New member.
2128         * elfread.c (record_minimal_symbol): Set maybe_copied
2129         on symbol when appropriate.
2130         (elf_symfile_read): Update call to dwarf2_has_info.
2131         * minsyms.c (lookup_minimal_symbol_linkage): New
2132         function.
2133         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2134         * symtab.c (get_symbol_address, get_msymbol_address):
2135         New functions.
2136         * symtab.h (get_symbol_address, get_msymbol_address):
2137         Declare.
2138         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2139         maybe_copied.
2140         (struct symbol, struct minimal_symbol) <maybe_copied>:
2141         New member.
2142
2143 2019-10-02  Tom Tromey  <tromey@adacore.com>
2144
2145         * source.c (struct current_source_location): New.
2146         (current_source_key): New global.
2147         (current_source_symtab, current_source_line)
2148         (current_source_pspace): Remove.
2149         (get_source_location): New function.
2150         (get_current_source_symtab_and_line)
2151         (set_default_source_symtab_and_line)
2152         (set_current_source_symtab_and_line)
2153         (clear_current_source_symtab_and_line, select_source_symtab)
2154         (info_source_command, print_source_lines_base)
2155         (info_line_command, search_command_helper, _initialize_source):
2156         Update.
2157
2158 2019-10-02  Tom Tromey  <tromey@adacore.com>
2159
2160         * source.c (select_source_symtab): Don't call
2161         decode_line_with_current_source.
2162
2163 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * symtab.c (lookup_global_symbol): Search global block.
2166
2167 2019-10-02  Tom Tromey  <tromey@adacore.com>
2168
2169         * coffread.c (process_coff_symbol): Update.
2170         * dwarf2read.c (var_decode_location, new_symbol): Update.
2171         * mdebugread.c (parse_symbol): Update.
2172         * objfiles.c (relocate_one_symbol): Update.
2173         * stabsread.c (define_symbol, fix_common_block)
2174         (scan_file_globals): Update.
2175         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2176         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2177         * xcoffread.c (process_xcoff_symbol): Update.
2178
2179 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2180
2181         * MAINTAINERS: Update my email address.
2182
2183 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2186         std::vector.
2187         (build_type_psymtabs_reader): Update for std::vector.
2188         (build_type_psymtab_dependencies): Likewise.
2189         * dwarf2read.h: Remove use of DEF_VEC_P.
2190         (typedef sig_type_ptr): Delete.
2191
2192 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2195         to std::vector.
2196         (btrace_maint_decode_pt): Likewise, and move allocation of the
2197         vector outside of the loop.
2198         (btrace_maint_update_packets): Update to handle change from VEC to
2199         std::vector.
2200         (btrace_maint_print_packets): Likewise.
2201         (maint_info_btrace_cmd): Likewise.
2202         * btrace.h: Remove use of DEF_VEC_O.
2203         (typedef btrace_pt_packet_s): Delete.
2204         (struct btrace_maint_info) <packets>: Change fromm VEC to
2205         std::vector.
2206         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2207
2208 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2211         make accesses into the vector constant references.
2212         (btrace_add_pc): Update for std::vector.
2213         (btrace_stitch_bts): Likewise.
2214         (parse_xml_btrace_block): Likewise.
2215         (btrace_maint_update_packets): Likewise.
2216         (btrace_maint_print_packets): Likewise.
2217         (maint_info_btrace_cmd): Likewise.
2218         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2219         std::vector.
2220         (btrace_data::empty): Likewise.
2221         (btrace_data_append): Likewise.
2222         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2223         (typedef btrace_block_s): Delete.
2224         (struct btrace_block): Add constructor.
2225         (struct btrace_data_bts) <blocks>: Change to std::vector.
2226         * nat/linux-btrace.c (perf_event_read_bts): Update for
2227         std::vector.
2228         (linux_read_bts): Likewise.
2229
2230 2019-10-01  Tom Tromey  <tom@tromey.com>
2231
2232         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2233
2234 2019-10-01  Tom Tromey  <tom@tromey.com>
2235
2236         * stack.c (print_frame, info_frame_command_core): Use
2237         styled_string.
2238         * linux-thread-db.c (try_thread_db_load_1)
2239         (try_thread_db_load_from_pdir_1): Use styled_string.
2240         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2241         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2242         (maybe_print_unsupported_script_warning)
2243         (maybe_print_script_not_found_warning): Use styled_string.
2244         * ada-lang.c (user_select_syms): Use styled_string.
2245
2246 2019-10-01  Tom Tromey  <tom@tromey.com>
2247
2248         * p-lang.c (pascal_printstr): Use metadata style.
2249         * value.c (show_convenience): Use metadata style.
2250         * valprint.c (valprint_check_validity, val_print_optimized_out)
2251         (val_print_not_saved, val_print_unavailable)
2252         (val_print_invalid_address, generic_val_print, val_print)
2253         (value_check_printable, val_print_array_elements): Use metadata
2254         style.
2255         * ui-out.h (class ui_out) <field_fmt>: New overload.
2256         <do_field_fmt>: Add style parameter.
2257         * ui-out.c (ui_out::field_fmt): New overload.
2258         * typeprint.c (type_print_unknown_return_type)
2259         (val_print_not_allocated, val_print_not_associated): Use metadata
2260         style.
2261         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2262         parameter.
2263         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2264         * tracepoint.c (tvariables_info_1): Use metadata style.
2265         * stack.c (print_frame_arg, print_frame_info, print_frame)
2266         (info_frame_command_core): Use metadata style.
2267         * skip.c (info_skip_command): Use metadata style.
2268         * rust-lang.c (rust_print_enum): Use metadata style.
2269         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2270         metadata style.
2271         * python/py-framefilter.c (py_print_single_arg): Use metadata
2272         style.
2273         * printcmd.c (do_one_display, print_variable_and_value): Use
2274         metadata style.
2275         * p-valprint.c (pascal_val_print)
2276         (pascal_object_print_value_fields): Use metadata style.
2277         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2278         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2279         parameter.
2280         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2281         * m2-valprint.c (m2_print_long_set): Use metadata style.
2282         * m2-typeprint.c (m2_print_type): Use metadata style.
2283         * infcmd.c (print_return_value_1): Use metadata style.
2284         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2285         * f-valprint.c (info_common_command_for_block): Use metadata
2286         style.
2287         * f-typeprint.c (f_type_print_base): Use metadata style.
2288         * expprint.c (print_subexp_standard): Use metadata style.
2289         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2290         * cli/cli-style.h (class cli_style_option): Add constructor.
2291         (metadata_style): Declare.
2292         * cli/cli-style.c (metadata_style): New global.
2293         (_initialize_cli_style): Register metadata style.
2294         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2295         parameter.
2296         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2297         * c-typeprint.c (c_type_print_base_struct_union)
2298         (c_type_print_base_1): Use metadata style.
2299         * breakpoint.c (watchpoint_value_print)
2300         (print_one_breakpoint_location): Use metadata style.
2301         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2302         style.
2303         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2304         style.
2305         * ada-valprint.c (val_print_packed_array_elements, printstr)
2306         (print_field_values, ada_val_print_ref, ada_val_print): Use
2307         metadata style.
2308         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2309         style.
2310         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2311         style.
2312         * ada-lang.c (user_select_syms): Use metadata style.
2313
2314 2019-10-01  Tom Tromey  <tom@tromey.com>
2315
2316         * cli/cli-cmds.c (pwd_command): Style output.
2317
2318 2019-10-01  Pedro Alves  <palves@redhat.com>
2319             Tom Tromey  <tom@tromey.com>
2320
2321         * symtab.c (print_symbol_info): Use %ps.
2322         (print_msymbol_info): Use %ps.
2323         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2324         * printcmd.c (print_variable_and_value): Use %ps.
2325         * macrocmd.c (show_pp_source_pos): Use %ps.
2326         * infrun.c (print_exited_reason): Use ui_out::message.
2327         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2328         (describe_other_breakpoints): Use ui_out::message and new
2329         formats.
2330         (say_where): Use new formats.
2331         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2332         and new formats.
2333
2334 2019-10-01  Pedro Alves  <palves@redhat.com>
2335             Tom Tromey  <tom@tromey.com>
2336
2337         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2338         (test_gdb_formats): New function.
2339         (run_tests): Call it.
2340         (test_format_specifier): Update.
2341         * utils.h (fputs_filtered): Update comment.
2342         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2343         (fputs_styled_unfiltered): Declare.
2344         * utils.c (fputs_styled_unfiltered): New function.
2345         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2346         (vfprintf_filtered): Update.
2347         (vfprintf_unfiltered, vprintf_filtered): Update.
2348         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2349         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2350         disallow_ui_out_field>: New constants.
2351         (enum class field_kind): New.
2352         (struct base_field_s, struct signed_field_s): New.
2353         (signed_field): New function.
2354         (struct string_field_s): New.
2355         (string_field): New function.
2356         (struct styled_string_s): New.
2357         (styled_string): New function.
2358         (class ui_out) <message>: Add comment.
2359         <vmessage, call_do_message>: New methods.
2360         <do_message>: Add style parameter.
2361         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2362         methods.
2363         (ui_out::message): Rewrite.
2364         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2365         parameter.
2366         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2367         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2368         gdb_extensions parameter.
2369         (class format_piece): Add parameter to constructor.
2370         (n_int_args): New field.
2371         * gdbsupport/format.c (format_pieces::format_pieces): Add
2372         gdb_extensions parameter.  Handle '*'.
2373         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2374         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2375         vfprintf_styled_no_gdbfmt.
2376         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2377         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2378         unfiltered output.
2379         * ui-style.h (struct ui_file_style) <ptr>: New method.
2380
2381 2019-10-01  Tom Tromey  <tom@tromey.com>
2382
2383         * unittests/format_pieces-selftests.c: Update.  Add final format.
2384         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2385         empty literal pieces.
2386
2387 2019-10-01  Tom Tromey  <tom@tromey.com>
2388
2389         * ui-out.h (enum class ui_out_style_kind): Remove.
2390         (class ui_out) <field_string, field_stsream, do_field_string>:
2391         Change type of "style".
2392         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2393         (ui_out::field_string): Update.
2394         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2395         of "style".
2396         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2397         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2398         * stack.c (print_frame_arg, print_frame_info, print_frame):
2399         Update.
2400         * source.c (print_source_lines_base): Update.
2401         * solib.c (info_sharedlibrary_command): Update.
2402         * skip.c (info_skip_command): Update.
2403         * record-btrace.c (btrace_call_history_src_line)
2404         (btrace_call_history): Update.
2405         * python/py-framefilter.c (py_print_frame): Update.
2406         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2407         "style".
2408         * mi/mi-out.c (mi_ui_out::do_table_header)
2409         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2410         (mi_ui_out::do_field_string): Update.
2411         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2412         Update.
2413         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2414         "style".
2415         * cli-out.c (cli_ui_out::do_table_header)
2416         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2417         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2418         (cli_ui_out::do_field_fmt): Update.
2419         * breakpoint.c (print_breakpoint_location): Update.
2420         (update_static_tracepoint): Update.
2421
2422 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2423
2424         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2425         conversion of gdb_datadir.
2426         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2427         remove not needed c_str ().
2428
2429 2019-09-30  Ali Tamur <tamur@google.com>
2430
2431         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2432         (dwarf2_string_attr): Likewise.
2433
2434 2019-09-30  Ali Tamur <tamur@google.com>
2435
2436         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2437         (process_full_type_unit): Likewise.
2438         (dump_die_shallow): Likewise.
2439         (cu_debug_loc_section): Likewise.
2440
2441 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2442
2443         * minsyms.c (compare_minimal_symbols): Rename to...
2444         (minimal_symbol_is_less_than): ...this, and adjust to STL
2445         conventions (return bool, take arguments as references)
2446         (minimal_symbol_reader::install): Call std::sort instead
2447         of qsort.
2448
2449 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2450
2451         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2452         hash and why.
2453         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2454         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2455
2456 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2457
2458         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2459         * psympriv.h (add_psymbol_to_list): Move comment here and update
2460         it.
2461
2462 2019-09-29  Tom de Vries  <tdevries@suse.de>
2463
2464         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2465         Use $tmpdir/$(basename "$output_file").dwz instead of
2466         "${output_file}.dwz".
2467
2468 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2469
2470         PR gdb/25045
2471         * hppa-linux-nat.c: Include gdbarch.h.
2472
2473 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2474
2475         * blockframe.c (find_pc_partial_function): Change return type to bool.
2476         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2477         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2478         (stub_gnu_ifunc_resolve_name): Likewise.
2479         * symtab.c (compare_filenames_for_search): Likewise.
2480         (compare_glob_filenames_for_search): Likewise.
2481         (matching_obj_sections): Likewise.
2482         (symbol_matches_domain): Likewise.
2483         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2484         (find_line_pc): Change return type to bool.
2485         (find_line_pc_range): Likewise.
2486         (producer_is_realview): Likewise.
2487         * symtab.h (symbol_matches_domain): Likewise.
2488         (find_pc_partial_function): Likewise.
2489         (find_pc_line_pc_range): Likewise.
2490         (in_gnu_ifunc_stub): Likewise.
2491         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2492         (find_line_pc): Likewise.
2493         (find_line_pc_range): Likewise.
2494         (matching_obj_sections): Likewise.
2495         (find_line_symtab): Change out parameter to bool.
2496         (producer_is_realview): Change return type to bool.
2497         (compare_filenames_for_search): Likewise.
2498         (compare_glob_filenames_for_search): Likewise.
2499
2500 2019-09-26  Tom Tromey  <tom@tromey.com>
2501
2502         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2503         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2504         * gdb_usleep.h: Remove.
2505         * gdb_usleep.c: Remove.
2506         * utils.c: Don't include gdb_usleep.h.
2507
2508 2019-09-26  Tom Tromey  <tromey@adacore.com>
2509
2510         * python/py-type.c (type_to_type_object): Call check_typedef
2511         for stub types.
2512
2513 2019-09-26  Tom Tromey  <tom@tromey.com>
2514
2515         * utils.h (initialize_utils): Don't declare.
2516         * top.c (gdb_init): Don't call initialize_utils.
2517         * utils.c (initialize_utils): Remove.  Move contents...
2518         (_initialize_utils): ... here.
2519
2520 2019-09-25  Tom Tromey  <tom@tromey.com>
2521
2522         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2523         * utils.h (make_hex_string): Don't declare.
2524         * utils.c (make_hex_string): Remove.
2525
2526 2019-09-24  Tom de Vries  <tdevries@suse.de>
2527
2528         PR gdb/23815
2529         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2530         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2531
2532 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2533
2534         * NEWS: Mention new simulator port for PRU.
2535
2536 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2537
2538         * ada-exp.y (write_object_remaining): Update.
2539         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2540         and eliminate the static buffer.
2541         (ada_decode_symbol): Update.
2542         (ada_la_decode): Update.
2543         (ada_sniff_from_mangled_name): Update.
2544         (is_valid_name_for_wild_match): Update.
2545         (ada_lookup_name_info::matches): Update and simplify.
2546         (name_matches_regex): Update.
2547         (ada_add_global_exceptions): Update.
2548         * ada-lang.h (ada_decode): Update signature.
2549         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2550         * dwarf-index-write.c (debug_names::insert): Update.
2551
2552 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2553
2554         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2555         formatting.
2556
2557 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2558
2559         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2560         Change "nonzero" to "true" in documentation.
2561
2562 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2563
2564         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2565         (_initialize_darwin_solib): Don't set
2566         darwin_so_ops.lookup_lib_global_symbol.
2567         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2568         set_gdbarch_iterate_over_objfiles_in_search_order.
2569         (elf_lookup_lib_symbol): Rename to...
2570         (svr4_iterate_over_objfiles_in_search_order): this, and update
2571         to iterate semantics.
2572         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2573         * solib.c (solib_global_lookup): Remove.
2574         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2575         (solib_global_lookup): Remove.
2576         * symtab.c (lookup_global_or_static_symbol): Remove call to
2577         solib_global_lookup.
2578
2579 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2580
2581         * NEWS: Move entries about default MI version now being
2582         version 3, and about the GDB/MI fix for multi-location
2583         breakpoints to the "since GDB 8.3" section.
2584
2585 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2586
2587         GDB 8.3.1 released.
2588
2589 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2590
2591         * NEWS: Mention that Cell/B.E. debugging support was removed.
2592         * MAINTAINERS: Remove spu target.
2593
2594         * config/djgpp/fnchange.lst: Remove entries for removed files.
2595
2596         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2597         spu-multiarch.o, and spu-tdep.o.
2598         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2599         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2600         spu-multiarch.c, and spu-tdep.c.
2601         * spu-linux-nat.c: Remove file.
2602         * spu-multiarch.c: Remove file.
2603         * spu-tdep.c: Remove file.
2604         * spu-tdep.h: Remove file.
2605         * solib-spu.c: Remove file.
2606         * solib-spu.h: Remove file.
2607
2608         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2609         * configure.nat (spu-linux): Remove.
2610         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2611         solib-multiarch.o from gdb_target_obs.
2612         (spu*-*-*): Remove.
2613
2614         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2615         feature flag.
2616         (ppc_linux_no_features): Update.
2617         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2618         Cell/B.E. support.
2619         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2620         (tdesc_powerpc_cell64l): Likewise.
2621         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2622         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2623         Cell/B.E. support.
2624         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2625         Do not include "features/rs6000/powerpc-cell32l.c" or
2626         "features/rs6000/powerpc-cell64l.c".
2627         (ppc_linux_spu_section): Remove.
2628         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2629         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2630         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2631         (ppc_linux_spe_context_lookup): Remove.
2632         (ppc_linux_spe_context_inferior_created): Remove.
2633         (ppc_linux_spe_context_solib_loaded): Remove.
2634         (ppc_linux_spe_context_solib_unloaded): Remove.
2635         (ppc_linux_spe_context): Remove.
2636         (struct ppu2spu_cache): Remove.
2637         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2638         (struct ppu2spu_data): Remove.
2639         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2640         ppu2spu_unwind): Remove.
2641         (ppc_linux_init_abi): Remove Cell/B.E. support.
2642         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2643
2644         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2645         (rs6000/powerpc-cell64l-expedite): Likewise
2646         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2647         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2648         rs6000/powerpc-cell64l.xml.
2649         * features/rs6000/powerpc-cell32l.xml: Remove.
2650         * features/rs6000/powerpc-cell64l.xml: Likewise.
2651         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2652         * features/rs6000/powerpc-cell64l.c: Likewise.
2653         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2654         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2655         * regformats/reg-spu.dat: Remove.
2656
2657         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2658         * corelow.c (struct spuid_list): Remove.
2659         (add_to_spuid_list): Remove.
2660         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2661         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2662         (remote_protocol_features): Remove associated entries.
2663         (_initialize_remote): No longer initialize them.
2664         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2665         * linux-nat.c (SPUFS_MAGIC): Remove.
2666         (linux_proc_xfer_spu): Remove.
2667         (spu_enumerate_spu_ids): Remove.
2668         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2669         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2670         (linux_make_corefile_notes): No longer call it.
2671
2672         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2673         (cooked_write_test): Likewise.
2674
2675 2019-09-20  Tom Tromey  <tom@tromey.com>
2676
2677         * NEWS: Mention case-sensitivity of TUI commands.
2678         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2679         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2680         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2681
2682 2019-09-20  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-source.c (tui_source_window::set_contents): Use
2685         make_unique_xstrdup.
2686         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2687         make_unique_xstrdup.
2688
2689 2019-09-20  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui-data.c: Remove separator comments.
2692         * tui/tui-layout.c: Remove separator comments.
2693         * tui/tui-win.c: Remove separator comments.
2694         * tui/tui-wingeneral.c: Remove separator comments.
2695
2696 2019-09-20  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui.h (strcat_to_buf): Don't declare.
2699         * tui/tui.c (strcat_to_buf): Remove.
2700
2701 2019-09-20  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2704         from "fullname".
2705         * tui/tui-source.c (tui_source_window::set_contents)
2706         (tui_source_window::location_matches_p)
2707         (tui_source_window::maybe_update): Update.
2708
2709 2019-09-20  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2712         Update.
2713         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2714         prefix.
2715         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2716         (tui_data_window::line_from_reg_element_no)
2717         (tui_data_window::first_reg_element_no_inline)
2718         (tui_data_window::show_registers)
2719         (tui_data_window::show_register_group)
2720         (tui_data_window::display_registers_from)
2721         (tui_data_window::display_registers_from_line)
2722         (tui_data_window::first_data_item_displayed)
2723         (tui_data_window::delete_data_content_windows)
2724         (tui_data_window::erase_data_content)
2725         (tui_data_window::do_scroll_vertical)
2726         (tui_data_window::refresh_window)
2727         (tui_data_window::check_register_values): Update.
2728
2729 2019-09-20  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2732         (struct tui_locator_window) <full_name, proc_name>: Now
2733         std::string.
2734         * tui/tui-stack.c (tui_locator_window::make_status_line)
2735         (tui_locator_window::set_locator_fullname)
2736         (tui_locator_window::set_locator_info): Update.
2737         * tui/tui-source.c (tui_source_window::set_contents)
2738         (tui_source_window::showing_source_p): Update.
2739
2740 2019-09-20  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2743         Don't call tui_locator_win_info_ptr.
2744
2745 2019-09-20  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-win.c (tui_resize_all): Don't call refresh.
2748
2749 2019-09-20  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2752         height for locator.
2753         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2754         * tui/tui-layout.c (show_source_disasm_command, show_data)
2755         (show_source_or_disasm_and_command): Use 1 as height for locator.
2756
2757 2019-09-20  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui.c (tui_enable): Update.
2760         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2761         Update.
2762         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2763         Update.
2764         * tui/tui-data.c (win_resized): Now bool.
2765         (tui_win_resized): Return bool.
2766         (tui_set_win_resized_to): Accept a bool.
2767
2768 2019-09-20  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2771         Change type of "refresh_values_only".
2772         * tui/tui-regs.c (tui_data_window::show_register_group): Change
2773         type of "refresh_values_only".
2774
2775 2019-09-20  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2778         std::string.
2779         (tui_disassemble): Add "pos" parameter.
2780         (tui_disasm_window::set_contents): Simplify.
2781
2782 2019-09-20  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-winsource.h (struct tui_source_window_base)
2785         <show_source_content>: Now private.
2786         * tui/tui-winsource.c
2787         (tui_source_window_base::show_source_content): Don't handle empty
2788         content case.
2789
2790 2019-09-20  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-layout.c (show_source_disasm_command)
2793         (show_source_or_disasm_and_command): Don't call
2794         show_source_content.
2795
2796 2019-09-20  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2799         Declare.
2800         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2801         from tui_make_status_line.
2802         (tui_locator_window::rerender): Update.
2803
2804 2019-09-20  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-stack.c (tui_make_status_line): Return std::string.
2807         (tui_locator_window::rerender): Update.
2808
2809 2019-09-20  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-winsource.h (struct tui_source_window_base)
2812         <~tui_source_window_base>: Don't declare.
2813         <fullname>: Remove.
2814         * tui/tui-winsource.c (~tui_source_window_base): Remove.
2815         * tui/tui-source.h (struct tui_source_window) <fullname>: New
2816         member.
2817         * tui/tui-source.c (tui_source_window::set_contents): Update.
2818         (tui_source_window::location_matches_p)
2819         (tui_source_window::maybe_update): Update.
2820
2821 2019-09-20  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-winsource.h (~tui_source_element): Remove.
2824         (tui_source_element): Update.
2825         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2826         * tui/tui-winsource.c (tui_show_source_line): Update.
2827         * tui/tui-source.c (tui_source_window::set_contents): Update.
2828         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2829
2830 2019-09-20  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2833         declare.
2834         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2835         tui_clear_source_windows_detail.
2836         * tui/tui-winsource.h (struct tui_source_window_base)
2837         <clear_detail>: Don't declare.
2838         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2839         Remove.
2840         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2841
2842 2019-09-20  Tom Tromey  <tromey@adacore.com>
2843
2844         PR ada/24919:
2845         * block.c (contained_in): Fix final return value.
2846
2847 2019-09-20  Alan Modra  <amodra@gmail.com>
2848
2849         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2850         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2851         (read_indirect_string_from_dwz): Use bfd accessor.
2852         * dwarf2read.h (struct dwz_file <filename>): Likewise.
2853         * machoread.c (macho_symfile_read_all_oso): Likewise.
2854         * solib.c (solib_bfd_open): Likewise.
2855
2856 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2857
2858         * eval.c: Move declaration of overload_resolution to...
2859         * value.h: ...here.
2860
2861 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2862
2863         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2864         * arm-linux-tdep.c: Likewise.
2865         * arm-nbsd-nat.c: Likewise.
2866         * arm-tdep.h: Declare arm_apcs_32.
2867         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2868
2869 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
2870
2871         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2872         * dwarf2read.h: Declare dwarf_always_disassemble.
2873
2874 2019-09-19  Tom de Vries  <tdevries@suse.de>
2875
2876         PR gdb/25009
2877         * source-cache.c (source_cache::ensure): Catch exception thrown during
2878         construction of the highlighter.
2879
2880 2019-09-18  Alan Modra  <amodra@gmail.com>
2881
2882         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2883         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2884         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2885         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2886         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2887         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2888         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2889         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2890         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2891         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2892         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2893         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2894         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2895         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2896         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2897         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2898         * mi/mi-interp.c: Update throughout for bfd section macro and
2899         function changes.
2900         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2901         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2902
2903 2019-09-18  Tom Tromey  <tom@tromey.com>
2904
2905         * NEWS: Add entry.
2906         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2907         call rl_initialize.
2908         (tui_enable): Do not call rl_initialize.
2909
2910 2019-09-18  Christian Groessler  <chris@groessler.org>
2911
2912         * alpha-linux-nat.c: Include gdbarch.h.
2913
2914 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2915
2916         * ui-file.c: Include cli/cli-style.h.
2917         (term_cli_styling): Remove cli_styling declaration.
2918
2919 2019-09-18  Alan Modra  <amodra@gmail.com>
2920
2921         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2922         to bfd_asymbol_section.
2923
2924 2019-09-18  Alan Modra  <amodra@gmail.com>
2925
2926         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2927         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2928         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2929
2930 2019-09-18  Alan Modra  <amodra@gmail.com>
2931
2932         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2933         * spu-linux-nat.c (spu_bfd_open): Likewise.
2934
2935 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2936
2937         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2938         to bool to match definition in dwarf2read.c.
2939
2940 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2941
2942         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2943         (print_signatures): Likewise.
2944         (trust_pad_over_xvs): Likewise.
2945         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2946         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2947         * arm-linux-nat.c (arm_apcs_32): Likewise.
2948         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2949         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2950         * arm-tdep.c (arm_debug): Likewise.
2951         (arm_apcs_32): Likewise.
2952         * auto-load.c (debug_auto_load): Likewise.
2953         (auto_load_gdb_scripts): Likewise.
2954         (global_auto_load): Likewise.
2955         (auto_load_local_gdbinit): Likewise.
2956         (auto_load_local_gdbinit_loaded): Likewise.
2957         * auto-load.h (global_auto_load): Likewise.
2958         (auto_load_local_gdbinit): Likewise.
2959         (auto_load_local_gdbinit_loaded): Likewise.
2960         * breakpoint.c (disconnected_dprintf): Likewise.
2961         (breakpoint_proceeded): Likewise.
2962         (automatic_hardware_breakpoints): Likewise.
2963         (always_inserted_mode): Likewise.
2964         (target_exact_watchpoints): Likewise.
2965         (_initialize_breakpoint): Update.
2966         * breakpoint.h (target_exact_watchpoints): Change to bool.
2967         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2968         * cli/cli-cmds.c (trace_commands): Likewise.
2969         * cli/cli-cmds.h (trace_commands): Likewise.
2970         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2971         to bool*.
2972         * cli/cli-logging.c (logging_overwrite): Change to bool.
2973         (logging_redirect): Likewise.
2974         (debug_redirect): Likewise.
2975         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2976         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2977         to bool.
2978         <boolean_option_def>: Update.
2979         (struct flag_option_def): Change default type of Context to bool
2980         from int.
2981         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2982         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2983         (get_setshow_command_value_string): Likewise.
2984         * cli/cli-style.c (cli_styling): Change to bool.
2985         (source_styling): Likewise.
2986         * cli/cli-style.h (source_styling): Likewise.
2987         (cli_styling): Likewise.
2988         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2989         to bool.
2990         * command.h (var_types): Update comment.
2991         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2992         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2993         bool.
2994         (debug_compile_cplus_scopes): Likewise.
2995         * compile/compile-internal.h (compile_debug): Likewise.
2996         * compile/compile.c (compile_debug): Likewise.
2997         (struct compile_options) <raw>: Likewise.
2998         * cp-support.c (catch_demangler_crashes): Likewise.
2999         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3000         (usr_cmd_cris_dwarf2_cfi): Likewise.
3001         * csky-tdep.c (csky_debug): Likewise.
3002         * darwin-nat.c (enable_mach_exceptions): Likewise.
3003         * dcache.c (dcache_enabled_p): Likewise.
3004         * defs.h (info_verbose): Likewise.
3005         * demangle.c (demangle): Likewise.
3006         (asm_demangle): Likewise.
3007         * dwarf-index-cache.c (debug_index_cache): Likewise.
3008         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3009         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3010         * dwarf2read.c (check_physname): Likewise.
3011         (use_deprecated_index_sections): Likewise.
3012         (dwarf_always_disassemble): Likewise.
3013         * eval.c (overload_resolution): Likewise.
3014         * event-top.c (set_editing_cmd_var): Likewise.
3015         (exec_done_display_p): Likewise.
3016         * event-top.h (set_editing_cmd_var): Likewise.
3017         (exec_done_display_p): Likewise.
3018         * exec.c (write_files): Likewise.
3019         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3020         (debug_fbsd_nat): Likewise.
3021         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3022         Likewise.
3023         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3024         <backtrace_past_entry> Likewise.
3025         * gdb-demangle.h (demangle): Likewise.
3026         (asm_demangle): Likewise.
3027         * gdb_bfd.c (bfd_sharing): Likewise.
3028         * gdbcore.h (write_files): Likewise.
3029         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3030         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3031         * gdbthread.h (print_thread_events): Likewise.
3032         * gdbtypes.c (opaque_type_resolution): Likewise.
3033         (strict_type_checking): Likewise.
3034         * gnu-nat.c (gnu_debug_flag): Likewise.
3035         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3036         * guile/scm-param.c (pascm_variable): Add boolval.
3037         (add_setshow_generic): Update.
3038         (pascm_param_value): Update.
3039         (pascm_set_param_value_x): Update.
3040         * hppa-tdep.c (hppa_debug): Change to bool..
3041         * infcall.c (may_call_functions_p): Likewise.
3042         (coerce_float_to_double_p): Likewise.
3043         (unwind_on_signal_p): Likewise.
3044         (unwind_on_terminating_exception_p): Likewise.
3045         * infcmd.c (startup_with_shell): Likewise.
3046         * inferior.c (print_inferior_events): Likewise.
3047         * inferior.h (startup_with_shell): Likewise.
3048         (print_inferior_events): Likewise.
3049         * infrun.c (step_stop_if_no_debug): Likewise.
3050         (detach_fork): Likewise.
3051         (debug_displaced): Likewise.
3052         (disable_randomization): Likewise.
3053         (non_stop): Likewise.
3054         (non_stop_1): Likewise.
3055         (observer_mode): Likewise.
3056         (observer_mode_1): Likewise.
3057         (set_observer_mode): Update.
3058         (sched_multi): Change to bool.
3059         * infrun.h (debug_displaced): Likewise.
3060         (sched_multi): Likewise.
3061         (step_stop_if_no_debug): Likewise.
3062         (non_stop): Likewise.
3063         (disable_randomization): Likewise.
3064         * linux-tdep.c (use_coredump_filter): Likewise.
3065         (dump_excluded_mappings): Likewise.
3066         * linux-thread-db.c (auto_load_thread_db): Likewise.
3067         (check_thread_db_on_load): Likewise.
3068         * main.c (captured_main_1): Update.
3069         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3070         xx2_opt, boolean_opt>: Change to bool.
3071         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3072         * maint.c (maintenance_profile_p): Likewise.
3073         (per_command_time): Likewise.
3074         (per_command_space): Likewise.
3075         (per_command_symtab): Likewise.
3076         * memattr.c (inaccessible_by_default): Likewise.
3077         * mi/mi-main.c (mi_async): Likewise.
3078         (mi_async_1): Likewise.
3079         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3080         * nat/fork-inferior.h (startup_with_shell): Likewise.
3081         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3082         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3083         * nios2-tdep.c (nios2_debug): Likewise.
3084         * or1k-tdep.c (or1k_debug): Likewise.
3085         * parse.c (parser_debug): Likewise.
3086         * parser-defs.h (parser_debug): Likewise.
3087         * printcmd.c (print_symbol_filename): Likewise.
3088         * proc-api.c (procfs_trace): Likewise.
3089         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3090         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3091         (set_parameter_value): Update.
3092         (add_setshow_generic): Update.
3093         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3094         to bool*.
3095         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3096         int*.
3097         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3098         * record-btrace.c (record_btrace_target::store_registers): Update.
3099         * record-full.c (record_full_memory_query): Change to bool.
3100         (record_full_stop_at_limit): Likewise.
3101         * record-full.h (record_full_memory_query): Likewise.
3102         * remote-notif.c (notif_debug): Likewise.
3103         * remote-notif.h (notif_debug): Likewise.
3104         * remote.c (use_range_stepping): Likewise.
3105         (interrupt_on_connect): Likewise.
3106         (remote_break): Likewise.
3107         * ser-tcp.c (tcp_auto_retry): Likewise.
3108         * ser-unix.c (serial_hwflow): Likewise.
3109         * skip.c (debug_skip): Likewise.
3110         * solib-aix.c (solib_aix_debug): Likewise.
3111         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3112         (spu_auto_flush_cache_p): Likewise.
3113         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3114         Likewise.
3115         (struct info_print_options) <quiet>: Likewise.
3116         * symfile-debug.c (debug_symfile): Likewise.
3117         * symfile.c (auto_solib_add): Likewise.
3118         (separate_debug_file_debug): Likewise.
3119         * symfile.h (auto_solib_add): Likewise.
3120         (separate_debug_file_debug): Likewise.
3121         * symtab.c (basenames_may_differ): Likewise.
3122         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3123         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3124         (struct info_types_options) <quiet>: Likewise.
3125         * symtab.h (demangle): Likewise.
3126         (basenames_may_differ): Likewise.
3127         * target-dcache.c (stack_cache_enabled_1): Likewise.
3128         (code_cache_enabled_1): Likewise.
3129         * target.c (trust_readonly): Likewise.
3130         (may_write_registers): Likewise.
3131         (may_write_memory): Likewise.
3132         (may_insert_breakpoints): Likewise.
3133         (may_insert_tracepoints): Likewise.
3134         (may_insert_fast_tracepoints): Likewise.
3135         (may_stop): Likewise.
3136         (auto_connect_native_target): Likewise.
3137         (target_stop_and_wait): Update.
3138         (target_async_permitted): Change to bool.
3139         (target_async_permitted_1): Likewise.
3140         (may_write_registers_1): Likewise.
3141         (may_write_memory_1): Likewise.
3142         (may_insert_breakpoints_1): Likewise.
3143         (may_insert_tracepoints_1): Likewise.
3144         (may_insert_fast_tracepoints_1): Likewise.
3145         (may_stop_1): Likewise.
3146         * target.h (target_async_permitted): Likewise.
3147         (may_write_registers): Likewise.
3148         (may_write_memory): Likewise.
3149         (may_insert_breakpoints): Likewise.
3150         (may_insert_tracepoints): Likewise.
3151         (may_insert_fast_tracepoints): Likewise.
3152         (may_stop): Likewise.
3153         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3154         (make_thread_apply_all_options_def_group): Change argument from int*
3155         to bool*.
3156         (thread_apply_all_command): Update.
3157         (print_thread_events): Change to bool.
3158         * top.c (confirm): Likewise.
3159         (command_editing_p): Likewise.
3160         (history_expansion_p): Likewise.
3161         (write_history_p): Likewise.
3162         (info_verbose): Likewise.
3163         * top.h (confirm): Likewise.
3164         (history_expansion_p): Likewise.
3165         * tracepoint.c (disconnected_tracing): Likewise.
3166         (circular_trace_buffer): Likewise.
3167         * typeprint.c (print_methods): Likewise.
3168         (print_typedefs): Likewise.
3169         * utils.c (debug_timestamp): Likewise.
3170         (sevenbit_strings): Likewise.
3171         (pagination_enabled): Likewise.
3172         * utils.h (sevenbit_strings): Likewise.
3173         (pagination_enabled): Likewise.
3174         * valops.c (overload_resolution): Likewise.
3175         * valprint.h (struct value_print_options) <prettyformat_arrays,
3176         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3177         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3178         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3179         Likewise.
3180         * windows-nat.c (new_console): Likewise.
3181         (cygwin_exceptions): Likewise.
3182         (new_group): Likewise.
3183         (debug_exec): Likewise.
3184         (debug_events): Likewise.
3185         (debug_memory): Likewise.
3186         (debug_exceptions): Likewise.
3187         (useshell): Likewise.
3188         * windows-tdep.c (maint_display_all_tib): Likewise.
3189         * xml-support.c (debug_xml): Likewise.
3190
3191 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3192
3193         * source.c (prepare_path_for_appending): New function.
3194         (openp): Make use of new function.
3195         (find_and_open_source): Search for the compilation directory and
3196         source file as a relative path beneath the directory search path.
3197
3198 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * source-cache.c (source_cache::get_line_charpos): Catch
3201         exceptions and return false, this matches the behaviour documented
3202         in the header file.
3203
3204 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3205
3206         * ada-tasks.c (info_task): Remove quoting of the task's name.
3207
3208 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3209
3210         * symfile.c (auto_solib_add): Replace comment with a reference
3211         to the header file.
3212
3213 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3214
3215         * NEWS: Mention that gdb can now be compiled with Python 3
3216         on Windows.
3217
3218 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * maint.c (maint_print_section_data::maint_print_section_data):
3221         Force use of 'float log10 (float)' by casting the argument to
3222         float.
3223
3224 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * maint.c: Add 'cmath' include.
3227         (struct maint_print_section_data): New structure.
3228         (print_section_index): New function.
3229         (print_bfd_section_info): Add header comment, small whitespace
3230         cleanup, and update to call new print_section_index function.
3231         (print_objfile_section_info): Likewise.
3232         (maint_obj_section_from_bfd_section): New function.
3233         (print_bfd_section_info_maybe_relocated): New function.
3234         (maintenance_info_sections): Add header comment, always use
3235         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3236
3237 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3240         inner scope, add check that the objfile has psymtabs before
3241         checking psymtabs_addrmap.
3242         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3243
3244 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3245
3246         * NEWS: Announce that Ada task names are now shown at more places,
3247         and between quotes (except in info task output).
3248         * gdb/ada-tasks.c (task_to_str): New function.
3249         (display_current_task_id): Call task_to_str.
3250         (task_command_1): Likewise.
3251         (print_ada_task_info): In non-mi mode, Properly align headers and data
3252         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3253
3254 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3255
3256         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3257         prstatus.pr_lwp.pr_info instead of making it up.
3258
3259 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3260
3261         * auto-load.c (auto_load_expand_dir_vars): Update.
3262         * defs.h (gdb_datadir): Change to std::string.
3263         (python_libdir): Likewise.
3264         (relocate_gdb_directory): Change return type to std::string.
3265         * guile/guile.c (gdbscm_data_directory): Update.
3266         (initialize_scheme_side): Update.
3267         * jit.c (jit_reader_dir): Change to std::string.
3268         (jit_reader_load_command): Update.
3269         * main.c (gdb_datadir): Change to std::string.
3270         (python_libdir): Likewise.
3271         (set_gdb_data_directory): Update.
3272         (relocate_path): Change to return std::string.
3273         (relocate_gdb_directory): Change to return std::string.
3274         (relocate_gdbinit_path_maybe_in_datadir): Update.
3275         (captured_main_1): Update.
3276         * python/python.c (do_start_initialization): Update.
3277         * top.c (show_gdb_datadir): Update.
3278         * xml-syscall.c (xml_init_syscalls_info): Update.
3279         (init_syscalls_info): Update.
3280
3281 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3282
3283         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3284         out of get_init_files.
3285         (get_init_files): Update.
3286
3287 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3288
3289         * main.c (get_init_files): Change to use std::string.
3290         (captured_main_1): Update.
3291         (print_gdb_help): Update.
3292
3293 2019-09-11  Ali Tamur  <tamur@google.com>
3294
3295         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3296         implementation.
3297
3298 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3299
3300         * dbxread.c (read_dbx_symtab): Update.
3301         * dwarf2read.c (load_partial_dies): Update.
3302         * mdebugread.c (parse_partial_symbols): Update.
3303         (handle_psymbol_enumerators): Update.
3304         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3305         * psymtab.c (add_psymbol_to_bcache): Likewise.
3306         (add_psymbol_to_list): Likewise.
3307         * symtab.c (symbol_set_names): Likewise.
3308         * symtab.h (symbol_set_names): Likewise.
3309         * xcoffread.c (scan_xcoff_symtab): Update.
3310
3311 2019-09-11  Tom Tromey  <tom@tromey.com>
3312
3313         * symfile-mem.c (symbol_file_add_from_memory): Use
3314         bfd_set_filename.
3315         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3316         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3317
3318 2019-09-10  Tom Tromey  <tromey@adacore.com>
3319
3320         * dwarf-index-write.c (write_psymbols): Extend error message.
3321         (debug_names::insert): Add Ada code.
3322         (debug_names::write_psymbols): Remove Ada check.
3323         (debug_names) <m_string_obstack>: New member.
3324         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3325         (gdb_index_symbol_name_matcher::matches): Remove.
3326         (mapped_index_base::find_name_components_bounds): Add "lang"
3327         parameter.
3328         (mapped_index_base::build_name_components): Also split names
3329         according to Ada syntax.
3330         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3331         type of "match_callback".
3332         (check_match, check_find_bounds_finds)
3333         (dw2_expand_symtabs_matching): Update.
3334         (dw2_debug_names_iterator): Add new constructor.
3335         (dw2_debug_names_map_matching_symbols): New function.
3336         (dw2_debug_names_expand_symtabs_matching): Update.
3337         (dwarf2_debug_names_functions): Use
3338         dw2_debug_names_map_matching_symbols.
3339
3340 2019-09-10  Tom Tromey  <tromey@adacore.com>
3341
3342         * dwarf2read.c (dw2_get_file_names_reader): Add the
3343         CU's file name to the results.
3344
3345 2019-09-10  Tom Tromey  <tromey@adacore.com>
3346
3347         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3348         map_matching_symbols.  Update.
3349         * dwarf2read.c (dw2_map_matching_symbols): Update.
3350         * psymtab.c (match_partial_symbol): Change type; update.
3351         (psym_map_matching_symbols): Likewise.
3352         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3353         type; update.
3354         * symfile.h (struct quick_symbol_functions)
3355         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3356         Remove "match".
3357
3358 2019-09-10  Tom Tromey  <tromey@adacore.com>
3359
3360         * psymtab.c (map_block): Remove.
3361         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3362         * symtab.c (iterate_over_symbols_terminated): New function.
3363         * symtab.c (iterate_over_symbols_terminated): Declare.
3364
3365 2019-09-10  Tom Tromey  <tromey@adacore.com>
3366
3367         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3368         * language.h (struct language_defn) <la_iterate_over_symbols>:
3369         Return bool.
3370         * symtab.c (iterate_over_symbols): Return bool.
3371         * symtab.h (iterate_over_symbols): Return bool.
3372
3373 2019-09-10  Tom Tromey  <tromey@adacore.com>
3374
3375         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3376         (add_nonlocal_symbols): Update.
3377         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3378         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3379         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3380         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3381         Change type of "callback".  Remove "data".
3382
3383
3384 2019-09-09  Ali Tamur  <tamur@google.com>
3385
3386         * dwarf2read.c (comp_unit_head): Update comment.
3387         (dwarf2_dwo_name): New function declaration.
3388         (dwarf_unit_type_name): New function declaration.
3389         (read_comp_unit_head): Add support for new compilation units,
3390         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3391         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3392         (currently named as "signature") in their header. Also clarify error
3393         messages.
3394         (lookup_dwo_id): New function. Returns the dwo id of the given
3395         compile unit.
3396         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3397         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3398         functions.
3399         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3400         (dwarf2_dwo_name): Get the dwo name if present.
3401         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3402         purposes.
3403
3404 2019-09-09  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3407
3408 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3409
3410         * python/python.c (do_start_initialization): Make progname_copy static,
3411         to avoid a leak report.
3412
3413 2019-09-08  Tom Tromey  <tom@tromey.com>
3414
3415         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3416
3417 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3418
3419         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3420         Change type to gdb::optional<block_enum>.
3421         (dw2_symtab_iter_init): Change block_index parameter type
3422         to gdb::optional<block_enum>.
3423         (dw2_lookup_symbol): Change block_index parameter
3424         type to block_enum.c
3425         (dw2_debug_names_lookup_symbol): Likewise.
3426         * psymtab.c (psym_lookup_symbol): Likewise.
3427         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3428         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3429         Likewise.
3430
3431 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3432
3433         * defs.h (relocate_gdb_directory): Change int to bool in
3434         signature and rename flag to relocatable.
3435         * main.c (relocate_path): Likewise.
3436         (relocate_gdb_directory): Likewise.
3437
3438 2019-09-06  Alan Modra  <amodra@gmail.com>
3439
3440         * coffread.c (coff_symfile_read): Constify filename variable.
3441         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3442         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3443         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3444         * solib.c (reload_shared_libraries_1): Likewise.
3445         * symfile.c (reread_symbols): Likewise.
3446         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3447         * solib-darwin.c (darwin_bfd_open): Likewise.
3448         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3449
3450 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3453         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3454
3455 2019-09-03  Tom Tromey  <tromey@adacore.com>
3456
3457         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3458         types.
3459         (has_negatives): Unbias a range type bound.
3460         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3461         * gdbtypes.c (operator==): Handle new field.
3462         (create_range_type): Add "bias" parameter.
3463         (create_static_range_type, resolve_dynamic_range): Update.
3464         * gdbtypes.h (struct range_bounds) <bias>: New member.
3465         (create_range_type): Add bias parameter.
3466         * printcmd.c (print_scalar_formatted): Unbias range types.
3467         * value.c (unpack_long): Unbias range types.
3468         (pack_long): Bias range types.
3469
3470 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3471
3472         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3473         probe arguments.
3474
3475 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3476
3477         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3478         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3479         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3480         (compile_probe_arg): Likewise.
3481         * probe.h (get_argument_count): Likewise.
3482         * solib-svr4.c (solib_event_probe_action): Likewise.
3483         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3484
3485 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3488         code to here...
3489         (svr4_create_solib_event_breakpoints): ...from here.
3490
3491 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3492
3493         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3494         suffix from warning message.
3495
3496 2019-08-30  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-winsource.h (struct tui_source_window_base)
3499         <refresh_all>: Don't declare.
3500         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3501         Remove.
3502         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3503         tui_show_locator_content.
3504         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3505         declare.
3506         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3507         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3508         declare.
3509
3510 2019-08-30  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3513
3514 2019-08-30  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3517         Remove unnecessary forward declarations.
3518
3519 2019-08-30  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3522         rerender.
3523         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3524         tui_show_locator_content.
3525
3526 2019-08-30  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3529         (tui_locator_window::rerender): Rewrite using body of previous
3530         tui_show_locator_content.
3531
3532 2019-08-30  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3535         set_locator_fullname>: New methods.
3536         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3537         Rename from tui_set_locator_fullname.
3538         (tui_locator_window::set_locator_info): Rename from
3539         tui_set_locator_info.  Return bool.
3540         (tui_update_locator_fullname, tui_show_frame_info): Update.
3541
3542 2019-08-30  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3545
3546 2019-08-30  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3549         call touchwin.
3550
3551 2019-08-30  Tom Tromey  <tom@tromey.com>
3552
3553         * tui/tui-wingeneral.c (box_win): Assume win_info and
3554         win_info->handle cannot be NULL.
3555
3556 2019-08-30  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3559         refresh_window>: Declare.
3560         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3561         resize.
3562         (tui_data_item_window::rerender): Rename from
3563         tui_display_register.
3564         (tui_data_item_window::refresh_window): New method.
3565         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3566         no-op.
3567
3568 2019-08-30  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3571         regs_column_count, current_group>: Move later.  Now private.
3572         <get_current_group>: New method.
3573         * tui/tui-regs.c (tui_reg_command): Update.
3574         * tui/tui-layout.c (tui_set_layout): Update.
3575
3576 2019-08-30  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3579         (tui_data_window::rerender): Don't call
3580         check_and_display_highlight_if_needed.
3581         (tui_data_window::refresh_all): Remove call to
3582         erase_data_content.
3583
3584 2019-08-30  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3587         (tui_data_window::display_registers_from)
3588         (tui_data_window::display_reg_element_at_line)
3589         (tui_data_window::display_registers_from_line): Remove checks of
3590         "empty".
3591
3592 2019-08-30  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3595         Don't declare.
3596         * tui/tui-regs.c (tui_data_window::show_registers): Call
3597         rerender.
3598         (tui_data_window::rerender): Rename from display_all_data.
3599         (tui_data_window::rerender): Remove old implementation.
3600
3601 2019-08-30  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3604         text.
3605         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3606
3607 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3608             Sergio Durigan Junior  <sergiodj@redhat.com>
3609
3610         PR win32/24284
3611         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3612
3613 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3614
3615         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3616         when searching for types.
3617
3618 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * f-lang.c (f_language_defn): Use f_print_typedef.
3621         * f-lang.h (f_print_typedef): Declare.
3622         * f-typeprint.c (f_print_typedef): Define.
3623
3624 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3625
3626         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3627
3628 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * cli/cli-utils.c (info_print_options_defs): Delete.
3631         (make_info_print_options_def_group): Delete.
3632         (extract_info_print_options): Delete.
3633         (info_print_command_completer): Delete.
3634         (info_print_args_help): Add extra parameter, and optionally
3635         include text about -n flag.
3636         * cli/cli-utils.h (struct info_print_options): Delete.
3637         (extract_info_print_options): Delete declaration.
3638         (info_print_command_completer): Delete declaration.
3639         (info_print_args_help): Add extra parameter, extend header
3640         comment.
3641         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3642         search_symbols.
3643         * stack.c (struct info_print_options): New type.
3644         (info_print_options_defs): New file scoped variable.
3645         (make_info_print_options_def_group): New static function.
3646         (info_print_command_completer): New static function.
3647         (info_locals_command): Update to use new local functions.
3648         (info_args_command): Likewise.
3649         (_initialize_stack): Add extra parameter to calls to
3650         info_print_args_help.
3651         * symtab.c (search_symbols): Add extra parameter, use this to
3652         possibly excluse non-debug symbols.
3653         (symtab_symbol_info): Add extra parameter, which is passed on to
3654         search_symbols.
3655         (struct info_print_options): New type.
3656         (info_print_options_defs): New file scoped variable.
3657         (make_info_print_options_def_group): New static function.
3658         (info_print_command_completer): New static function.
3659         (info_variables_command): Update to use local functions, and pass
3660         extra parameter through to symtab_symbol_info.
3661         (info_functions_command): Likewise.
3662         (info_types_command): Pass additional argument through to
3663         symtab_symbol_info.
3664         (rbreak_command): Pass extra argument to search_symbols.
3665         (_initialize_symtab): Add extra arguments for calls to
3666         info_print_args_help, and update help text for 'info variables',
3667         'whereis', and 'info functions' commands.
3668         * symtab.h (search_symbols): Add extra argument to declaration.
3669         * NEWS: Mention new flags.
3670
3671 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3672
3673         * symtab.c (lookup_static_symbol): Call the new function (and move
3674         it down to be next to lookup_global_symbol).
3675         (struct global_sym_lookup_data): Add block_enum member and rename to...
3676         (struct global_or_static_sym_lookup_data): ...this.
3677         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3678         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3679         (lookup_symbol_global_or_static_iterator_cb): ...this.
3680         (lookup_global_or_static_symbol): New function.
3681         (lookup_global_symbol): Call new function.
3682
3683 2019-08-26  Tom de Vries  <tdevries@suse.de>
3684
3685         PR c++/24852
3686         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3687         when pc_probe.prob == NULL.
3688
3689 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3690
3691         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3692         variable symbol_linkage to symbol_linkage_.
3693
3694 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3695
3696         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3697         represent whether the symbol is static, dynamic, or we don't
3698         know.
3699
3700 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3701
3702         * gdb/rx-tdep.c (rx_register_names): New.
3703         (rx_register_name): Delete.
3704         (rx_psw_type): Delete.
3705         (rx_fpsw_type): Delete.
3706         (rx_register_type): Delete.
3707         (rx_gdbarch_init): Convert target-descriptions.
3708         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3709         * gdb/features/Makefile: Add rx.xml.
3710         * gdb/features/rx.xml: New.
3711         * gdb/features/rx.c: Generated.
3712         * gdb/NEWS: Mention target description support.
3713
3714 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3715
3716         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3717         *slot_ptr.
3718
3719 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3720
3721         * configure.ac: Don't check for 'dlfcn.h' (moved to
3722         gdbsupport/common.m4).
3723         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3724         'gdbsupport/'.
3725         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3726         * compile/compile-c-support.c: Include
3727         'gdbsupport/gdb-dlfcn.h'.
3728         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3729         * gdb-dlfcn.c: Move to...
3730         * gdbsupport/gdb-dlfcn.c: ... here.
3731         * gdb-dlfcn.h: Move to...
3732         * gdbsupport/gdb-dlfcn.h: ... here.
3733
3734 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3735
3736         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3737         the offset field signed.
3738
3739 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3740
3741         * python/lib/gdb/__init__.py (_execute_file): New function.
3742         * python/python.c (python_run_simple_file): Call gdb._execute_file
3743         on Windows.
3744
3745 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3748         all uses as this was never set to anything but a zero value.
3749
3750 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
3751
3752         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3753
3754 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
3755
3756         * tui/tui-data.h (tui_gen_win_info): Add an =default
3757         move constructor, required by some GCC versions.
3758
3759 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
3760
3761         * go32-nat.c (go32_sysinfo): Add hygon_p.
3762
3763 2019-08-20  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3766         line_from_reg_element_no, first_reg_element_no_inline,
3767         display_all_data, delete_data_content_windows,
3768         erase_data_content>: Now private.
3769
3770 2019-08-20  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3773         (tui_unhighlight_win, tui_highlight_win)
3774         (tui_win_info::make_window): Update.
3775         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3776
3777 2019-08-20  Tom Tromey  <tom@tromey.com>
3778
3779         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3780         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3781         (MAX_PID_WIDTH): Move to tui-stack.c.
3782         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3783         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3784         (MAX_PID_WIDTH): Move from tui-data.h.
3785
3786 2019-08-20  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3789         * tui/tui-wingeneral.c (box_win): Change type of win_info.
3790         (box_win): Update.
3791         (tui_gen_win_info::make_window): Rename from tui_make_window.
3792         (tui_win_info::make_window): New method.
3793         (tui_gen_win_info::make_visible): Update.
3794         * tui/tui-source.c (tui_source_window::set_contents): Update.
3795         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3796         (tui_data_window::display_registers_from): Update.
3797         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3798         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3799         Declare.
3800         <can_box>: Remove.
3801         <title>: Remove.
3802         (struct tui_win_info) <make_window>: Declare.
3803         <can_box>: Now virtual.
3804         <title>: New member.
3805         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3806         * tui/tui-command.c (tui_cmd_window::resize): Update.
3807
3808 2019-08-20  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3811         * tui/tui-regs.c (tui_data_window::show_registers): Update.
3812         (tui_data_window::check_register_values): Update.
3813
3814 2019-08-20  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-regs.h (struct tui_data_window): Use
3817         DISABLE_COPY_AND_ASSIGN.
3818         <regs_content>: Change type, removing unique_ptr.
3819         <tui_data_window>: Add move constructor.
3820         * tui/tui-regs.c (tui_data_window::show_registers)
3821         (tui_data_window::show_register_group)
3822         (tui_data_window::display_registers_from)
3823         (tui_data_window::display_registers_from)
3824         (tui_data_window::first_data_item_displayed)
3825         (tui_data_window::delete_data_content_windows)
3826         (tui_data_window::rerender, tui_data_window::refresh_window)
3827         (tui_data_window::check_register_values): Update.
3828
3829 2019-08-20  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-regs.h (struct tui_data_window) <show_registers,
3832         show_register_group>: Declare.
3833         (tui_show_register_group): Don't declare.
3834         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3835         tui_show_registers.
3836         (tui_data_window::show_register_group): Rename from
3837         tui_show_register_group.
3838         (tui_data_window::check_register_values, tui_reg_command):
3839         Update.
3840         * tui/tui-layout.c (tui_set_layout): Update.
3841
3842 2019-08-20  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3845         Declare.
3846         (tui_check_register_values): Don't declare.
3847         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3848         from tui_check_register_values.
3849         * tui/tui-hooks.c (tui_register_changed): Update.
3850
3851 2019-08-20  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-regs.c (tui_reg_layout): Move later.
3854         (tui_show_registers): Don't enable TUI mode or change layout.
3855
3856 2019-08-20  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-regs.h (struct tui_data_item_window)
3859         <~tui_data_item_window>: Remove.
3860         <content>: Now a unique_xmalloc_ptr.
3861         * tui/tui-regs.c (tui_register_format): Return a
3862         unique_xmalloc_ptr.
3863         (tui_get_register): Update.
3864         (~tui_data_item_window): Remove.
3865         (tui_data_window::display_registers_from, tui_display_register):
3866         Update.
3867         * tui/tui-io.h (tui_expand_tabs): Update.
3868         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3869         Remove "col" parameter.
3870
3871 2019-08-20  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3874         field.
3875         * tui/tui-regs.c (~tui_data_item_window): Update.
3876
3877 2019-08-20  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3880         earlier.
3881
3882 2019-08-20  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3885
3886 2019-08-20  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-source.h (struct tui_source_window): Update.
3889         * tui/tui-regs.c (tui_show_registers): Update.
3890         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3891         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3892         (NO_REGS_STRING): Remove defines.
3893
3894 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3895
3896         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3897         unnecessary thread walk if remote doesn't support the packet.
3898
3899 2019-08-19  Tom Tromey  <tromey@adacore.com>
3900
3901         * python/py-value.c (value_has_field): Fix indentation.
3902
3903 2019-08-19  Tom Tromey  <tromey@adacore.com>
3904
3905         * printcmd.c (do_one_display, info_display_command): Update.
3906         * block.h (contained_in): Return bool.  Add allow_nested
3907         parameter.
3908         * block.c (contained_in): Return bool.  Add allow_nested
3909         parameter.
3910
3911 2019-08-19  Tom Tromey  <tom@tromey.com>
3912
3913         * configure: Rebuild.
3914         * configure.ac: Disallow the combination of -static-libstdc++ and
3915         source highlight.
3916         * source-cache.c (get_language_name): Handle rust.
3917         (source_cache::get_source_lines): Ignore highlighting exceptions.
3918
3919 2019-08-16  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3922         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3923         (struct tui_source_window_base) <make_visible, refresh_window,
3924         resize>: Remove methods.
3925         <execution_info>: Remove field.
3926         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3927         (tui_show_source_line, tui_source_window_base)
3928         (~tui_source_window_base): Update.
3929         (tui_source_window_base::resize)
3930         (tui_source_window_base::make_visible)
3931         (tui_source_window_base::refresh_window): Remove.
3932         (tui_source_window_base::update_exec_info): Update.
3933         * tui/tui-source.c (tui_source_window::set_contents): Update.
3934         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3935
3936 2019-08-16  Tom Tromey  <tom@tromey.com>
3937
3938         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3939         deprecated_query_hook.
3940
3941 2019-08-16  Tom Tromey  <tom@tromey.com>
3942
3943         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3944         (tui_update_source_windows_with_line): Update.
3945         * tui/tui-source.h (struct tui_source_window)
3946         <show_symtab_source>: Declare.
3947         (tui_show_symtab_source): Don't declare.
3948         * tui/tui-source.c (tui_show_symtab_source): Rename from
3949         tui_show_symtab_source.
3950
3951 2019-08-16  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-winsource.h (struct tui_source_window_base)
3954         <set_contents>: Declare.
3955         * tui/tui-winsource.c
3956         (tui_source_window_base::update_source_window_as_is): Update.
3957         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3958         Declare.
3959         (tui_set_source_content): Don't declare.
3960         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3961         tui_set_source_content.
3962         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3963         Declare.
3964         (tui_set_disassem_content): Don't declare.
3965         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3966         tui_set_disassem_content.
3967
3968 2019-08-16  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-winsource.h (struct tui_source_window_base)
3971         <update_breakpoint_info>: Declare.
3972         (tui_update_breakpoint_info): Don't declare.
3973         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3974         (tui_update_all_breakpoint_info): Update.
3975         (tui_source_window_base::update_breakpoint_info): Rename from
3976         tui_update_breakpoint_info.
3977         (tui_source_window_base::update_exec_info): Update.
3978
3979 2019-08-16  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-winsource.h (struct tui_source_window_base)
3982         <update_source_window>: Declare.
3983         (tui_update_source_window): Don't declare.
3984         * tui/tui-winsource.c
3985         (tui_source_window_base::update_source_window): Rename from
3986         tui_update_source_window.
3987         (tui_source_window_base::rerender): Update.
3988         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3989         * tui/tui-disasm.c (tui_show_disassem)
3990         (tui_show_disassem_and_update_source)
3991         (tui_disasm_window::maybe_update): Update.
3992
3993 2019-08-16  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-winsource.h (struct tui_source_window_base)
3996         <update_source_window_as_is>: Declare.
3997         (tui_update_source_window_as_is): Don't declare.
3998         * tui/tui-winsource.c (tui_update_source_window): Update
3999         (tui_source_window_base::update_source_window_as_is): Rename from
4000         tui_update_source_window_as_is.
4001         (tui_source_window_base::refill): Update.
4002         * tui/tui-source.c (tui_show_symtab_source): Update.
4003         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4004         Update.
4005
4006 2019-08-16  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-winsource.h (tui_update_source_window)
4009         (tui_update_source_window_as_is): Remove "noerror" parameter.
4010         * tui/tui-winsource.c (tui_update_source_window)
4011         (tui_update_source_window_as_is): Remove "noerror" parameter.
4012         (tui_update_source_windows_with_addr)
4013         (tui_update_source_windows_with_line)
4014         (tui_source_window_base::rerender)
4015         (tui_source_window_base::refill): Update.
4016         * tui/tui-source.h (tui_set_source_content)
4017         (tui_show_symtab_source): Remove "noerror" parameter.
4018         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4019         parameter.
4020         (tui_show_symtab_source): Likewise.
4021         (tui_source_window::maybe_update): Update.
4022         * tui/tui-disasm.c (tui_show_disassem)
4023         (tui_show_disassem_and_update_source)
4024         (tui_disasm_window::do_scroll_vertical)
4025         (tui_disasm_window::maybe_update): Update.
4026
4027 2019-08-16  Tom Tromey  <tom@tromey.com>
4028
4029         * tui/tui.c (tui_is_window_visible): Update.
4030         * tui/tui-wingeneral.c (tui_make_window)
4031         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4032         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4033         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4034         (tui_set_win_height_command, parse_scrolling_args): Update.
4035         * tui/tui-source.c (tui_source_window::style_changed): Update.
4036         * tui/tui-regs.c (tui_show_registers)
4037         (tui_data_window::first_data_item_displayed)
4038         (tui_data_window::delete_data_content_windows)
4039         (tui_check_register_values, tui_reg_command): Update.
4040         * tui/tui-disasm.c (tui_show_disassem): Update.
4041         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4042         method.
4043         <is_visible>: Remove field.
4044         * tui/tui-data.c (tui_next_win, tui_prev_win)
4045         (tui_delete_invisible_windows): Update.
4046
4047 2019-08-16  Tom Tromey  <tom@tromey.com>
4048
4049         * tui/tui-winsource.h (struct tui_source_window_base)
4050         <m_has_locator>: Remove.
4051         * tui/tui-layout.c (show_source_disasm_command, show_data)
4052         (show_source_or_disasm_and_command): Update.
4053
4054 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4055
4056         * NEWS (Other MI changes): New subsection.
4057         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4058         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4059         * arch-utils.c (default_get_pc_address_flags): New function.
4060         * arch-utils.h (default_get_pc_address_flags): New declaration.
4061         * gdbarch.sh: Add get_pc_address_flags.
4062         * gdbarch.c: Regenerate.
4063         * gdbarch.h: Likewise.
4064         * stack.c (print_pc): New function.
4065         (print_frame_info) (print_frame): Call print_pc.
4066
4067 2019-08-16  Tom de Vries  <tdevries@suse.de>
4068
4069         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4070         print_objfile_section_info.
4071
4072 2019-08-15  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4075         calling update_cmdwin_start_line.
4076         * tui/tui-winsource.h (struct tui_source_window_base)
4077         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4078         <rerender>: Declare.
4079         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4080         Call rerender.
4081         (tui_source_window_base::set_new_height): Remove.
4082         (tui_source_window_base::rerender): Rename from
4083         do_make_visible_with_new_height.
4084         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4085         resize method.
4086         (tui_win_info::make_invisible_and_set_new_height)
4087         (tui_win_info::make_visible_with_new_height): Remove.
4088         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4089         Declare.
4090         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4091         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4092         do_make_visible_with_new_height>: Don't declare.
4093         <rerender>: Declare.
4094         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4095         set_new_height.
4096         (tui_data_window::do_make_visible_with_new_height): Remove.
4097         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4098         call tui_show_locator_content.
4099         (tui_gen_win_info::resize): Call rerender.
4100         (show_source_or_disasm_and_command): Don't call
4101         tui_show_locator_content.
4102         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4103         method.
4104         (struct tui_win_info) <rerender>: Declare.
4105         <set_new_height, make_invisible_and_set_new_height,
4106         make_visible_with_new_height>: Don't declare.
4107         * tui/tui-data.c (tui_win_list::rerender): New method.
4108         * tui/tui-command.h (struct tui_cmd_window)
4109         <do_make_visible_with_new_height>: Don't declare.
4110         * tui/tui-command.c
4111         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4112
4113 2019-08-15  Tom Tromey  <tromey@adacore.com>
4114
4115         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4116         * ada-lang.c (ada_enum_name): Likewise.
4117
4118 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4119
4120         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4121         leading underscore.
4122         (GdbOutputErrorFile): Likewise.
4123         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4124         accordingly.
4125         (execute_unwinders): Rename to have a leading underscore.
4126         (auto_load_packages): Likewise.
4127         (global scope): Adjust call to auto_load_packages accordingly.
4128         (GdbSetPythonDirectory): Likewise.
4129         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4130         instead of execute_unwinders.
4131
4132 2019-08-15  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4135         (show_data): Don't change window visibility.
4136         (tui_gen_win_info::resize): Remove special case for command
4137         window.  Use wresize, when available.
4138         (show_source_or_disasm_and_command): Don't change window
4139         visibility.
4140         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4141         <make_visible>: New method.
4142         * tui/tui-command.c (tui_cmd_window::resize): New method.
4143
4144 2019-08-15  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4147         (struct tui_source_windows): New.
4148         * tui/tui-winsource.c (tui_display_main): Update.
4149         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4150         (new_height_ok, parse_scrolling_args): Update.
4151         * tui/tui-layout.c (show_layout, show_data): Update.
4152         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4153         (tui_add_to_source_windows): Don't declare.
4154         * tui/tui-data.c (source_windows, tui_source_windows)
4155         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4156
4157 2019-08-15  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4160         Rename from reset.
4161         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4162         * tui/tui-layout.c (show_source_disasm_command, show_data):
4163         Update.
4164         (tui_gen_win_info::resize): Rename.
4165         (show_source_or_disasm_and_command): Update.
4166         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4167         reset.
4168
4169 2019-08-15  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4172         * tui/tui-interp.c (tui_interp::init): Don't call
4173         tui_initialize_static_data.
4174         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4175
4176 2019-08-15  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4179         examine tui_win_list.
4180
4181 2019-08-15  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4184         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4185         tui_clear_source_content.
4186         (tui_clear_source_content): Remove.
4187         (tui_source_window_base::do_erase_source_content): Hoist call to
4188         content.clear().
4189         * tui/tui-stack.c (tui_show_frame_info): Don't call
4190         tui_clear_source_content.
4191
4192 2019-08-15  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-winsource.h (struct tui_source_window_base)
4195         <do_erase_source_content>: New method.
4196         <erase_source_content>: New method.
4197         (tui_erase_source_content): Don't declare.
4198         * tui/tui-winsource.c (tui_clear_source_content): Update.
4199         (tui_source_window_base::do_erase_source_content): Rename from
4200         tui_erase_source_content.
4201         (tui_source_window_base::show_source_content): Update.
4202         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4203         * tui/tui-source.h (struct tui_source_window)
4204         <erase_source_content>: New method.
4205         * tui/tui-disasm.h (struct tui_disasm_window)
4206         <erase_source_content>: New method.
4207
4208 2019-08-15  Tom Tromey  <tom@tromey.com>
4209
4210         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4211         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4212         constructor.
4213         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4214         * tui/tui-source.c (tui_set_source_content): Update.
4215         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4216
4217 2019-08-15  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4220         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4221         tui-source.c.
4222         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4223         Declare.
4224         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4225         method.
4226         (tui_source_window::maybe_update): Update.
4227
4228 2019-08-15  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4231         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4232         tui-disasm.c.
4233         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4234         Declare.
4235         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4236         method.
4237         (tui_disasm_window::maybe_update): Update.
4238
4239 2019-08-15  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-winsource.h (struct tui_source_window_base)
4242         <maybe_update>: Declare.
4243         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4244         method.
4245         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4246         Declare.
4247         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4248         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4249         Declare.
4250         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4251
4252 2019-08-15  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4255
4256 2019-08-15  Tom Tromey  <tom@tromey.com>
4257
4258         * tui/tui-wingeneral.c: Include tui-stack.h.
4259         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4260         (struct tui_locator_window): Move from tui-data.h.
4261         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4262         (tui_initialize_static_data): Move from tui-data.c.
4263         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4264         (struct tui_locator_window): Move to tui-stack.c.
4265         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4266         (tui_initialize_static_data): Move to tui-stack.c.
4267
4268 2019-08-15  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-layout.c (show_source_disasm_command)
4271         (show_source_or_disasm_and_command): Use make_visible method, not
4272         tui_make_window.
4273         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4274         Remove.
4275
4276 2019-08-15  Tom Tromey  <tom@tromey.com>
4277
4278         * tui/tui-wingeneral.h (tui_make_window): Update.
4279         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4280         parameter.
4281         (tui_gen_win_info::make_visible): Update.
4282         * tui/tui-regs.c (tui_data_window::display_registers_from):
4283         Update.
4284         * tui/tui-layout.c (show_source_disasm_command)
4285         (show_source_or_disasm_and_command): Update.
4286         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4287         (enum tui_box): Remove.
4288         (struct tui_win_info) <can_box>: New method.
4289         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4290         method.
4291
4292 2019-08-15  Tom de Vries  <tdevries@suse.de>
4293
4294         * linux-nat-trad.c: Include gdbarch.h.
4295
4296 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4297
4298         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4299         register sizes.
4300
4301 2019-08-14  Tom Tromey  <tromey@adacore.com>
4302
4303         * darwin-nat.c: Include gdbarch.h.
4304         * darwin-nat-info.c: Include gdbarch.h.
4305
4306 2019-08-13  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4309         Remove.
4310         * tui/tui-data.c (tui_initialize_static_data): Update.
4311
4312 2019-08-13  Tom Tromey  <tom@tromey.com>
4313
4314         * tui/tui-winsource.h (struct tui_exec_info_window)
4315         <~tui_exec_info_window, maybe_allocate_content, get_content,
4316         m_content>: Remove.
4317         (struct tui_source_window_base) <set_exec_info_content,
4318         show_exec_info_content>: Don't declare.
4319         * tui/tui-winsource.c
4320         (tui_exec_info_window::maybe_allocate_content): Remove.
4321         (tui_source_window_base::update_exec_info): Rename from
4322         set_exec_info_content.
4323         (tui_source_window_base::show_exec_info_content)
4324         (tui_source_window_base::update_exec_info): Remove.
4325
4326 2019-08-13  Tom Tromey  <tom@tromey.com>
4327
4328         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4329         declare.
4330         * tui/tui-winsource.c (tui_update_source_window_as_is)
4331         (tui_update_source_windows_with_addr, tui_erase_source_content):
4332         Update.
4333         (tui_clear_exec_info_content): Remove.
4334
4335 2019-08-13  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4338         declare.
4339         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4340         call tui_erase_exec_info_content.
4341         (tui_clear_exec_info_content): Rename from
4342         tui_erase_exec_info_content.
4343         (tui_clear_exec_info_content): Delete.
4344
4345 2019-08-13  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-winsource.h (struct tui_source_window_base)
4348         <show_exec_info_content>: Declare.
4349         (tui_show_exec_info_content): Don't declare.
4350         * tui/tui-winsource.c
4351         (tui_source_window_base::show_exec_info_content): Rename from
4352         tui_show_exec_info_content.
4353         (tui_source_window_base::update_exec_info): Update.
4354
4355 2019-08-13  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4358         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4359         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4360         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4361         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4362         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4363         ... here.
4364
4365 2019-08-13  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-winsource.h (struct tui_source_window_base)
4368         <update_exec_info>: Declare.
4369         (tui_update_exec_info): Don't declare.
4370         * tui/tui-winsource.c (tui_update_source_window_as_is)
4371         (tui_source_window_base::refresh_all)
4372         (tui_update_all_breakpoint_info): Update.
4373         (tui_source_window_base::update_exec_info): Rename from
4374         tui_update_exec_info.
4375         * tui/tui-stack.c (tui_show_frame_info): Update.
4376
4377 2019-08-13  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-winsource.h (struct tui_source_window_base)
4380         <set_exec_info_content>: Declare.
4381         (tui_set_exec_info_content): Don't declare.
4382         * tui/tui-winsource.c
4383         (tui_source_window_base::set_exec_info_content): Rename from
4384         tui_set_exec_info_content.
4385         (tui_update_exec_info): Update.
4386
4387 2019-08-13  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-winsource.h (struct tui_source_window_base)
4390         <show_source_content>: Declare.
4391         (tui_show_source_content): Don't declare.
4392         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4393         (tui_source_window_base::show_source_content): Rename from
4394         tui_show_source_content.
4395         (tui_source_window_base::refresh_all): Update.
4396         * tui/tui-layout.c (show_source_disasm_command)
4397         (show_source_or_disasm_and_command): Update.
4398
4399 2019-08-13  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-winsource.c (tui_erase_source_content)
4402         (tui_show_source_content, tui_source_window_base::refresh_all):
4403         Update.
4404         * tui/tui-wingeneral.h
4405         (tui_check_and_display_highlight_if_needed): Don't declare.
4406         * tui/tui-wingeneral.c
4407         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4408         check_and_display_highlight_if_needed.
4409         * tui/tui-win.c (tui_rehighlight_all)
4410         (tui_win_info::make_visible_with_new_height): Update.
4411         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4412         (tui_data_window::erase_data_content)
4413         (tui_data_window::display_all_data): Update.
4414         * tui/tui-data.h (struct tui_win_info)
4415         <check_and_display_highlight_if_needed>: Declare.
4416
4417 2019-08-13  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-win.c (tui_resize_all): Call
4420         tui_delete_invisible_windows.
4421         * tui/tui-layout.c (show_layout): Call
4422         tui_delete_invisible_windows.
4423         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4424         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4425
4426 2019-08-13  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4429         tui_add_win_to_layout.
4430
4431 2019-08-13  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4434         * tui/tui-layout.c (tui_default_win_height): Now static.
4435
4436 2019-08-13  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4439         single switch.
4440         (show_source_disasm_command, show_source_or_disasm_and_command):
4441         Don't check current layout.
4442
4443 2019-08-13  Tom Tromey  <tom@tromey.com>
4444
4445         * tui/tui-wingeneral.c (make_all_visible): Remove.
4446         (tui_make_all_invisible): Simplify.
4447         * tui/tui-layout.c (tui_make_all_invisible): Move from
4448         tui-wingeneral.c; simplify.
4449         (show_layout): Hoist call to tui_make_all_invisible.
4450         (show_data): Don't call tui_make_all_invisible.
4451
4452 2019-08-13  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4455         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4456
4457 2019-08-13  Tom Tromey  <tom@tromey.com>
4458
4459         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4460         tui-data.c.
4461         (show_source_disasm_command, show_data)
4462         (show_source_or_disasm_and_command): Don't use
4463         tui_set_current_layout_to.
4464         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4465         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4466         tui-layout.c.
4467         (tui_set_current_layout_to): Remove.
4468
4469 2019-08-13  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui-layout.c (tui_set_layout): Update.
4472         * tui/tui-data.h (struct tui_layout_def): Remove.
4473         (tui_layout_def): Don't declare.
4474         * tui/tui-data.c (layout_def): Remove.
4475         (tui_layout_def): Remove.
4476
4477 2019-08-13  Tom Tromey  <tom@tromey.com>
4478
4479         * tui/tui-winsource.h (struct tui_source_window_base)
4480         <clear_detail>: No longer "override".
4481         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4482         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4483         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4484         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4485         Remove.
4486         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4487
4488 2019-08-13  Tom Tromey  <tromey@adacore.com>
4489
4490         * tracepoint.c: Don't include readline.h or history.h.
4491
4492 2019-08-12  Tom Tromey  <tom@tromey.com>
4493
4494         * configure: Rebuild.
4495         * configure.ac: Check for readline 7.
4496         * NEWS: Mention readline 7 requirement.
4497         * README: Update.
4498
4499 2019-08-12  Tom Tromey  <tom@tromey.com>
4500
4501         * mingw-hdep.c (gdb_select): Remove readline hack.
4502
4503 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4504
4505         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4506         when the function fails.
4507
4508 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4509
4510         * s390-tdep.c (s390_type_align): New function.
4511         (s390_gdbarch_init): Set it as type_align gdbarch method.
4512
4513 2019-08-09  Tom de Vries  <tdevries@suse.de>
4514
4515         PR gdb/24591
4516         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4517         pc_low with relocation offset.
4518
4519 2019-08-07  Tom Tromey  <tromey@adacore.com>
4520
4521         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4522         (print_frame_args): Update.
4523         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4524         Update.
4525         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4526         * frame.h (struct frame_arg): Add initializers.
4527         <error>: Now a unique_xmalloc_ptr.
4528
4529 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4530
4531         * NEWS: Expand the Pointer Authentication entry.
4532         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4533         (aarch64_frame_unmask_lr): ... to this.
4534         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4535         Call aarch64_frame_unmask_lr.
4536         * frame.c (struct frame_info): Add "masked" variable.
4537         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4538         (fprint_frame): Check for masked pc.
4539         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4540         declarations.
4541         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4542         * stack.c (print_frame): Check for masked pc.
4543
4544 2019-08-06  Tom Tromey  <tom@tromey.com>
4545
4546         * stabsread.c (patch_block_stabs, read_one_struct_field)
4547         (read_enum_type): Use obstack_strndup.
4548         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4549         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4550         * dwarf2read.c (guess_full_die_structure_name)
4551         (anonymous_struct_prefix): Use obstack_strndup.
4552         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4553         * c-exp.y (yylex): Use obstack_strndup.
4554         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4555         (write_var_or_type): Use obstack_strndup.
4556
4557 2019-08-06  Tom Tromey  <tom@tromey.com>
4558
4559         * symfile.c (reread_symbols): Use obstack_strdup.
4560         * stabsread.c (read_type): Use obstack_strdup.
4561         * gdb_obstack.h (obstack_strdup): New overload.
4562         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4563         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4564         (dwarf2_canonicalize_name): Use obstack_strdup.
4565         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4566         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4567         Use obstack_strdup.
4568
4569 2019-08-06  Tom Tromey  <tom@tromey.com>
4570
4571         * gdb_obstack.h (obstack_strdup): Define.
4572         * gdb_obstack.c (obstack_strdup): Don't define.
4573
4574 2019-08-06  Tom Tromey  <tom@tromey.com>
4575
4576         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4577         obstack_strdup.
4578         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4579         obstack_strdup.
4580         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4581         * stabsread.c (common_block_start): Use obstack_strdup.
4582         * objfiles.c (set_objfile_main_name, objfile): Use
4583         obstack_strdup.
4584         * namespace.c (add_using_directive): Use obstack_strdup.
4585         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4586         * jit.c (finalize_symtab): Use obstack_strdup.
4587         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4588         (guess_partial_die_structure_name, partial_die_info::fixup)
4589         (dwarf2_name): Use obstack_strdup.
4590         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4591         obstack_strdup.
4592         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4593         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4594         obstack_strdup.
4595         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4596
4597 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         * unittests/help-doc-selftests.c: New file.
4600         * Makefile.in: Add the new file.
4601
4602 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4603
4604         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4605         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4606         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4607         the trailing '.' is not output, and the first character is uppercased.
4608         (print_help_for_command): Update call to print_doc_line.
4609         (print_doc_of_command): Likewise.
4610         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4611         * cli/cli-option.c (append_indented_doc): Do not append newline.
4612         (build_help_option): Append newline after first appended_indented_doc
4613         only if a second call is done.
4614         (build_help): Append 2 new lines before each option, except the first
4615         one.
4616         * compile/compile.c (_initialize_compile): Add new lines after
4617         %OPTIONS%, when not at the end of the help.
4618         Change help doc or code
4619         producing the help doc to respect the invariants.
4620         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4621         Also removed the new line after 'Options:', as all other commands
4622         do not put an empty line between 'Options:' and the first option.
4623         * printcmd.c (_initialize_printcmd): Likewise.
4624         * stack.c (_initialize_stack): Likewise.
4625         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4626         incorrectly telling COMMAND is optional.
4627         * ada-lang.c (_initialize_ada_language): Change help doc or code
4628         producing the help doc to respect the invariants.
4629         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4630         * breakpoint.c (_initialize_breakpoint): Likewise.
4631         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4632         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4633         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4634         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4635         _initialize_cli_style): Likewise.
4636         * corelow.c (core_target_info): Likewise.
4637         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4638         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4639         * filesystem.c (_initialize_filesystem): Likewise.
4640         * frame.c (_initialize_frame): Likewise.
4641         * gnu-nat.c (add_task_commands): Likewise.
4642         * infcall.c (_initialize_infcall): Likewise.
4643         * infcmd.c (_initialize_infcmd): Likewise.
4644         * interps.c (_initialize_interpreter): Likewise.
4645         * language.c (_initialize_language): Likewise.
4646         * linux-fork.c (_initialize_linux_fork): Likewise.
4647         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4648         * maint.c (_initialize_maint_cmds): Likewise.
4649         * memattr.c (_initialize_mem): Likewise.
4650         * printcmd.c (_initialize_printcmd): Likewise.
4651         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4652         _RegEx): Likewise.
4653         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4654         * record-btrace.c (_initialize_record_btrace): Likewise.
4655         * record-full.c (_initialize_record_full): Likewise.
4656         * record.c (_initialize_record): Likewise.
4657         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4658         * regcache.c (_initialize_regcache): Likewise.
4659         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4660         _initialize_remote): Likewise.
4661         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4662         * serial.c (_initialize_serial): Likewise.
4663         * skip.c (_initialize_step_skip): Likewise.
4664         * source.c (_initialize_source): Likewise.
4665         * stack.c (_initialize_stack): Likewise.
4666         * symfile.c (_initialize_symfile): Likewise.
4667         * symtab.c (_initialize_symtab): Likewise.
4668         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4669         * top.c (init_main): Likewise.
4670         * tracefile-tfile.c (tfile_target_info): Likewise.
4671         * tracepoint.c (_initialize_tracepoint): Likewise.
4672         * tui/tui-win.c (_initialize_tui_win): Likewise.
4673         * utils.c (add_internal_problem_command): Likewise.
4674         * valprint.c (value_print_option_defs): Likewise.
4675
4676 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4677
4678         PR build/24886
4679         * configure.ac: Drop enable-libmcheck support.
4680         * configure, config.in: Rebuild.
4681         * libmcheck.m4: Remove.
4682         * acinclude.m4: Don't include it.
4683         * Makefile.in: Don't distribute it.
4684         * top.c (print_gdb_configuration): Don't mention it.
4685
4686 2019-08-06  Tom Tromey  <tom@tromey.com>
4687
4688         * utils.c (set_output_style): Sometimes pass stream to
4689         emit_style_escape.
4690         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4691         * record-btrace.c (btrace_insn_history): Update.
4692         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4693         method.
4694         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4695         Update initializers.
4696         <m_uiout>: New field.
4697         <m_di>: Move lower.
4698         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4699         Remove "uiout" parameter.
4700         (dump_insns): Update.
4701         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4702         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4703
4704 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4705
4706         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4707         (error_in_psymtab_expansion): Likewise.
4708         (lookup_symbol_via_quick_fns): Likewise.
4709         (basic_lookup_transparent_type_quick): Likewise.
4710         (basic_lookup_transparent_type_1): Likewise.
4711
4712 2019-08-06  Tom Tromey  <tromey@adacore.com>
4713
4714         * source.c (last_source_error): Now bool.
4715         (print_source_lines_base): Make "noprint" bool.  Only open
4716         source file when last_source_visited changes.
4717
4718 2019-08-06  Tom Tromey  <tromey@adacore.com>
4719
4720         * annotate.c (annotate_source_line): Use g_source_cache.
4721         * source-cache.c (source_cache::get_plain_source_lines): Change
4722         parameters.  Populate m_offset_cache.
4723         (source_cache::ensure): New method.
4724         (source_cache::get_line_charpos): New method.
4725         (extract_lines): Move lower.  Change parameters.
4726         (source_cache::get_source_lines): Move lower.
4727         * source-cache.h (class source_cache): Update comment.
4728         <get_line_charpos>: New method.
4729         <get_source_lines>: Update comment.
4730         <clear>: Clear m_offset_cache.
4731         <get_plain_source_lines>: Change parameters.
4732         <ensure>: New method
4733         <m_offset_cache>: New member.
4734         * source.c (forget_cached_source_info_for_objfile): Update.
4735         (info_source_command): Use g_source_cache.
4736         (find_source_lines, open_source_file_with_line_charpos): Remove.
4737         (print_source_lines_base, search_command_helper): Use g_source_cache.
4738         * source.h (open_source_file_with_line_charpos): Don't declare.
4739         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4740         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4741         Use g_source_cache.
4742
4743 2019-08-06  Tom Tromey  <tromey@adacore.com>
4744
4745         * source-cache.c (source_cache::get_plain_source_lines):
4746         Remove "first_line" and "last_line" parameters.
4747         (source_cache::get_source_lines): Cache plain text.
4748         * source-cache.h (class source_cache)
4749         <get_plain_source_lines>: Update.
4750
4751 2019-08-06  Tom Tromey  <tromey@adacore.com>
4752
4753         * source-cache.c (extract_lines): No longer a method.
4754         Changed type of parameter.  Include final newline.
4755         (selftests::extract_lines_test): New function.
4756         (_initialize_source_cache): Likewise.
4757         * source-cache.h (class source_cache)
4758         <extract_lines>: Don't declare.
4759
4760 2019-08-06  Tom Tromey  <tromey@adacore.com>
4761
4762         * breakpoint.c (init_breakpoint_sal): Update.
4763         (breakpoint): Update.
4764         * breakpoint.h (struct breakpoint) <filter>: Now a
4765         unique_xmalloc_ptr.
4766
4767 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4768
4769         * NEWS: Mention dictionary access on blocks.
4770         * python/py-block.c (blpy_getitem): New function.
4771         (block_object_as_mapping): New struct.
4772         (block_object_type): Use new struct for tp_as_mapping field.
4773
4774 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
4775
4776         * objfiles.h (objfile): Add a comment describing partial symbols.
4777
4778 2019-08-05  Tom Tromey  <tromey@adacore.com>
4779
4780         * compile/compile.c (_initialize_compile): Use _(), not N_().
4781         * thread.c (_initialize_thread): Use _(), not N_().
4782         * stack.c (_initialize_stack): Use _(), not N_().
4783         * printcmd.c (_initialize_printcmd): Use _(), not N_().
4784
4785 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
4786
4787         * dwarf2read.c (struct dw2_symtab_iterator):
4788         <want_specific_block>: Remove.
4789         <block_index>: Change type to gdb::optional.
4790         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4791         change type of BLOCK_INDEX parameter to gdb::optional.
4792         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4793         (dw2_lookup_symbol): Don't pass argument for
4794         WANT_SPECIFIC_BLOCK.
4795         (dw2_expand_symtabs_for_function): Don't pass argument for
4796         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4797         (class dw2_debug_names_iterator)
4798         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4799         parameter, change BLOCK_INDEX type to gdb::optional.
4800         <m_want_specific_block>: Remove.
4801         <m_block_index>: Change type to gdb::optional.
4802         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4803         gdb::optional.  Re-write in function of gdb::optional.
4804         (dw2_debug_names_lookup_symbol): Don't pass argument for
4805         WANT_SPECIFIC_BLOCK.
4806         (dw2_debug_names_expand_symtabs_for_function): Don't pass
4807         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4808         BLOCK_INDEX.
4809
4810 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4811
4812         * NEWS: Mention changes to "info sources" command.
4813
4814 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4815
4816         * symtab.c (filename_partial_match_opts): New struct type.
4817         (struct output_source_filename_data): New members
4818         regexp, c_regexp, partial_match.
4819         (output_source_filename): Use new members to decide to print file.
4820         (info_sources_option_defs): New variable.
4821         (make_info_sources_options_def_group, print_info_sources_header,
4822         info_sources_command_completer):
4823         New functions.
4824         (info_sources_command): Read new optional arguments.
4825         (_initialize_symtab): Update info sources help.
4826
4827 2019-08-02  Alexandre Oliva <oliva@adacore.com>
4828
4829         * ada-lang.c (exception_support_info_v0): Renamed from...
4830         (default_exception_support_info): ... this.  Create new
4831         definition for v1.
4832         (ada_has_this_exception_support): Look up catch_handlers_sym.
4833         (ada_exception_support_info_sniffer): Try v0 after default.
4834
4835 2019-08-01  Tom Tromey  <tromey@adacore.com>
4836
4837         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4838         gdbarch.h.
4839
4840 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
4841
4842         * s12z-tdep.c: Fix include path for s12z-opc.h.
4843
4844 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
4845
4846         * NEWS: Require GNU make 3.82.
4847
4848 2019-07-16  Tom Tromey  <tom@tromey.com>
4849
4850         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4851         declare.
4852
4853 2019-07-30  Tom Tromey  <tromey@adacore.com>
4854
4855         * block.c (contained_in): Remove BLOCK_FUNCTION check.
4856
4857 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
4858
4859         * printcmd.c (print_address_symbolic): Print negative offsets.
4860         (build_address_symbolic): Force signed arithmetic when computing
4861         offset.
4862
4863 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
4864
4865         PR/24474: Add a function to lookup static variables.
4866         * NEWS: Mention this new function.
4867         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4868         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4869         * python/python.c (python_GdbMethods): Add new function.
4870
4871 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
4872
4873         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4874         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4875         (objfpy_lookup_static_symbol): New function.
4876         (objfile_object_methods): Add new functions.
4877
4878 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4879
4880         * NEWS: Mention 'set|show print frame-info'.  Mention new
4881         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
4882         backtrace argument.  Mention that python frame filtering code
4883         is now consistent with what 'backtrace' command prints.
4884
4885 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4886
4887         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4888         comments.
4889         (print_frame_info_auto, print_frame_info_source_line,
4890         print_frame_info_location, print_frame_info_source_and_location,
4891         print_frame_info_location_and_address, print_frame_info_short_location):
4892         New declarations.
4893         (struct frame_print_options): New member print_frame_info.
4894         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4895         * stack.h (get_user_print_what_frame_info): New declaration.
4896         (frame_show_address): New declaration.
4897         * stack.c (print_frame_arguments_choices): New value 'presence'.
4898         (print_frame_info_auto, print_frame_info_source_line,
4899         print_frame_info_location, print_frame_info_source_and_location,
4900         print_frame_info_location_and_address, print_frame_info_short_location,
4901         print_frame_info_choices, print_frame_info_print_what): New definitions.
4902         (print_frame_args): Only print dots for args if print frame-arguments
4903         is 'presence'.
4904         (frame_print_option_defs): New element for "frame-info".
4905         (get_user_print_what_frame_info): New function.
4906         (frame_show_address): Make non static.  Move comment to stack.h.
4907         (print_frame_info_to_print_what): New function.
4908         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4909         to decide what to print.
4910         (backtrace_command_1): Handle the new print_frame_arguments_presence
4911         value.
4912         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4913         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4914         (py_print_frame): In non-mi mode, use LOCATION as default for
4915         print_what, similarly to frame information printed directly by
4916         backtrace command. Handle frame-info user option in non MI mode.
4917
4918 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4919
4920         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4921         Add case for debugging 32-bit target on 64-bit host.  Revise
4922         comment.
4923
4924 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4925
4926         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4927         instead of find_function_entry_range_from_pc.
4928
4929 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4930
4931         * stack.c (find_frame_funname): Remove code which preferred
4932         minsym over symtab sym in "certain pathological cases".
4933
4934         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4935         parameter.  Change type of "do_demangle" to bool.
4936         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4937         Pass suitable "prefer_sym_over_minsym" flag to
4938         build_address_symbolic().  Don't output "+" for negative offsets.
4939         * printcmd.c (print_address_symbolic): Update invocation of
4940         build_address_symbolic to include a "prefer_sym_over_minsym"
4941         flag.
4942         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4943         Restrict cases in which use of minimal symbol is preferred to that
4944         of a found symbol.  Update comments.
4945
4946         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4947         for entry pc when entry pc is out of range for that FDE.
4948
4949 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4950
4951         PR gdb/24839:
4952         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4953         type.
4954
4955 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4956
4957         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4958         this function's Python signature.
4959
4960
4961 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4962
4963         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4964         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4965         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4966         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4967         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4968
4969
4970 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4971
4972         * h8300-tdep.c (h8300_register_name_common): New.
4973         h8300_register_name): Use h8300_register_name_common.
4974         (h8300s_register_name): Likewise.
4975         (h8300sx_register_name): Likewise.
4976         (h8300h_register_nam): New.
4977         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4978
4979
4980 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4981
4982         * arm-tdep.c (arm_skip_cmse_entry): New function.
4983         (arm_is_sgstubs_section): New function.
4984         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4985
4986 2019-07-22  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4989         Don't self-assign.
4990
4991 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4992
4993         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4994         type_print.
4995
4996 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4997
4998         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4999         so that GDB doesn't match any msymbols when searching in the
5000         TYPES_DOMAIN.
5001         (print_symbol_info): Print using typedef_print or type_print based
5002         on the type of the symbol.  Add updated FIXME comment moved from...
5003         (_initialize_symtab): ... move and update FIXME comment to above.
5004
5005 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5006
5007         * NEWS: Mention adding -q option to "info types".
5008         * symtab.c (struct info_types_options): New struct.
5009         (info_types_options_defs): New variable.
5010         (make_info_types_options_def_group): New function.
5011         (info_types_command): Use gdb::option framework to parse options.
5012         (info_types_command_completer): New function.
5013         (_initialize_symtab): Extend the help text on "info types" and
5014         register command completer.
5015
5016 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5017
5018         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5019         (lookup_symbol_in_objfile): Change int to block_enum and add a
5020         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5021
5022 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5023
5024         * MAINTAINERS (Write After Approval): Add self.
5025
5026 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5029         instruction to the dummy code region.
5030
5031 2019-07-19  Tom Tromey  <tromey@adacore.com>
5032
5033         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5034         (ARGSUSED, PARAMS, __func__): Remove rules.
5035
5036 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5039         * features/arm/arm-with-iwmmxt.c: Remove.
5040         * features/arm/arm-with-iwmmxt.xml: Remove.
5041         * features/arm/arm-with-m-fpa-layout.c: Remove.
5042         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5043         * features/arm/arm-with-m-vfp-d16.c: Remove.
5044         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5045         * features/arm/arm-with-m.c: Remove.
5046         * features/arm/arm-with-m.xml: Remove.
5047         * features/arm/arm-with-neon.c: Remove.
5048         * features/arm/arm-with-neon.xml: Remove.
5049         * features/arm/arm-with-vfpv2.c: Remove.
5050         * features/arm/arm-with-vfpv2.xml: Remove.
5051         * features/arm/arm-with-vfpv3.c: Remove.
5052         * features/arm/arm-with-vfpv3.xml: Remove.
5053
5054 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5055
5056         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5057
5058 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5059
5060         * arch/aarch32.c (aarch32_create_target_description): Create
5061         target descriptions using features.
5062         * arch/arm.c (arm_create_target_description)
5063         (arm_create_mprofile_target_description): Likewise.
5064         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5065
5066 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5067
5068         * Makefile.in: Add new files.
5069         * aarch32-tdep.c: New file.
5070         * aarch32-tdep.h: New file.
5071         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5072         Call aarch32_read_description.
5073         * arch/aarch32.c: New file.
5074         * arch/aarch32.h: New file.
5075         * arch/arm.c (arm_create_target_description)
5076         (arm_create_mprofile_target_description): New function.
5077         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5078         (arm_create_target_description)
5079         (arm_create_mprofile_target_description): New declaration.
5080         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5081         read_description functions.
5082         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5083         Likewise.
5084         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5085         * arm-tdep.c (tdesc_arm_list): New variable.
5086         (arm_register_g_packet_guesses): Call create description functions.
5087         (arm_read_description) (arm_read_mprofile_description): New
5088         function.
5089         * arm-tdep.h (arm_read_description)
5090         (arm_read_mprofile_description): Add declaration.
5091         * configure.tgt: Add new files.
5092
5093 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5094
5095         * top.c (new_ui_command): Open specified terminal just once.
5096
5097 2019-07-18  Tom Tromey  <tromey@adacore.com>
5098
5099         * symtab.c (main_name): Constify return type.
5100         * symfile.c (set_initial_language): Update.
5101         * symtab.h (main_name): Constify return type.
5102
5103 2019-07-17  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-winsource.c (tui_update_source_window)
5106         (tui_update_source_window_as_is)
5107         (tui_update_source_windows_with_line): Remove return.
5108         * tui/tui-disasm.c (tui_show_disassem)
5109         (tui_show_disassem_and_update_source): Remove return.
5110         * tui/tui.c (tui_reset): Remove return.
5111         * tui/tui-wingeneral.c
5112         (tui_check_and_display_highlight_if_needed): Remove return.
5113
5114 2019-07-17  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5117
5118 2019-07-17  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-winsource.h (struct tui_exec_info_window)
5121         (struct tui_source_window_base): Move from tui-data.h.
5122         * tui/tui-winsource.c: Move many method definitions from
5123         elsewhere.  Remove "structuring" comments.
5124         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5125         (tui_source_window_base::refresh_window): Move to
5126         tui-winsource.c.
5127         * tui/tui-win.c (tui_source_window_base::refresh_all)
5128         (tui_source_window_base::update_tab_width)
5129         (tui_source_window_base::set_new_height)
5130         (tui_source_window_base::do_make_visible_with_new_height): Move to
5131         tui-winsource.c.
5132         * tui/tui-source.h: Update.
5133         * tui/tui-source.c (tui_source_window_base::reset): Move to
5134         tui-winsource.c.
5135         * tui/tui-disasm.h: Update.
5136         * tui/tui-data.h (struct tui_exec_info_window): Move to
5137         tui-winsource.h.
5138         (struct tui_source_window_base): Likewise.
5139         * tui/tui-data.c (tui_source_window_base::clear_detail)
5140         (tui_source_window_base, ~tui_source_window_base): Move to
5141         tui-winsource.c.
5142
5143 2019-07-17  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-win.c (tui_resize_all)
5146         (tui_source_window_base::update_tab_width)
5147         (tui_adjust_win_heights): Update.
5148         (tui_win_info::make_invisible_and_set_new_height): Rename from
5149         make_invisible_and_set_new_height.
5150         * tui/tui-data.h (struct tui_win_info)
5151         <make_invisible_and_set_new_height>: New method.
5152
5153 2019-07-17  Tom Tromey  <tom@tromey.com>
5154
5155         * tui/tui.c: Update.
5156         * tui/tui-source.h (struct tui_source_window): Move from
5157         tui-data.h.
5158         * tui/tui-layout.c: Update.
5159         * tui/tui-disasm.c: Update.
5160         * tui/tui-data.h (struct tui_source_window): Move to
5161         tui-source.h.
5162
5163 2019-07-17  Tom Tromey  <tom@tromey.com>
5164
5165         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5166         tui-data.h.
5167         * tui/tui-data.h (struct tui_disasm_window): Move to
5168         tui-disasm.h.
5169
5170 2019-07-17  Tom Tromey  <tom@tromey.com>
5171
5172         * tui/tui-regs.h (struct tui_data_item_window): Move from
5173         tui-data.h.
5174         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5175         * tui/tui-data.h (struct tui_data_item_window): Move to
5176         tui-regs.h.
5177         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5178
5179 2019-07-17  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui.c: Update.
5182         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5183         (tui_cmd_window::max_height): Move to tui-command.c.
5184         * tui/tui-layout.c: Update.
5185         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5186         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5187         tui-command.c.
5188         * tui/tui-command.h (struct tui_cmd_window): Move from
5189         tui-data.h.
5190         * tui/tui-command.c: Remove "structuring" comments.
5191         (tui_cmd_window::clear_detail)
5192         (tui_cmd_window::do_make_visible_with_new_height)
5193         (tui_cmd_window::max_height): Move from elsewhere.
5194
5195 2019-07-17  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5198         Now static.
5199         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5200         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5201
5202 2019-07-17  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui.c: Update.
5205         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5206         tui-regs.c.
5207         * tui/tui-windata.h: Remove file.
5208         * tui/tui-windata.c: Remove file.
5209         * tui/tui-win.c (tui_data_window::set_new_height)
5210         (tui_data_window::do_make_visible_with_new_height): Move to
5211         tui-regs.c.
5212         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5213         * tui/tui-regs.c: Remove "structuring" comments.
5214         (tui_data_window::first_data_item_displayed)
5215         (tui_data_window::delete_data_content_windows)
5216         (tui_data_window::erase_data_content)
5217         (tui_data_window::display_all_data)
5218         (tui_data_window::refresh_all)
5219         (tui_data_window::do_scroll_vertical)
5220         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5221         (tui_data_window::do_make_visible_with_new_height)
5222         (tui_data_window::refresh_window): Move from elsewhere.
5223         (_initialize_tui_regs): Move to end of file.
5224         * tui/tui-layout.c: Update.
5225         * tui/tui-hooks.c: Update.
5226         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5227         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5228         tui-regs.c.
5229         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5230
5231 2019-07-17  Tom Tromey  <tom@tromey.com>
5232
5233         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5234         seen.
5235
5236 2019-07-17  Tom Tromey  <tom@tromey.com>
5237
5238         * tui/tui-win.c (tui_source_window_base::set_new_height)
5239         (tui_source_window_base::do_make_visible_with_new_height): Use
5240         m_has_locator field directly.
5241         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5242         method.
5243         (struct tui_source_window_base) <has_locator>: Likewise.
5244
5245 2019-07-17  Tom Tromey  <tom@tromey.com>
5246
5247         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5248         Don't declare.
5249         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5250         Remove.
5251         * tui/tui-win.c (tui_source_window_base::set_new_height)
5252         (tui_source_window_base::set_new_height)
5253         (make_invisible_and_set_new_height)
5254         (tui_source_window_base::do_make_visible_with_new_height)
5255         (tui_source_window_base::do_make_visible_with_new_height):
5256         Update.
5257         * tui/tui-layout.c (show_source_disasm_command, show_data)
5258         (show_source_or_disasm_and_command): Update.
5259         * tui/tui-layout.c (show_layout): Update.
5260
5261 2019-07-17  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-layout.c (make_data_window): Remove.
5264         (show_data): Unify creation and re-initialization cases.
5265
5266 2019-07-17  Tom Tromey  <tom@tromey.com>
5267
5268         * tui/tui-layout.c (make_source_window, make_disasm_window):
5269         Remove.
5270         (show_data): Unify creation and re-initialization cases.
5271
5272 2019-07-17  Tom Tromey  <tom@tromey.com>
5273
5274         * tui/tui-layout.c (make_command_window): Remove.
5275         (show_source_disasm_command, show_source_or_disasm_and_command):
5276         Unify creation and re-initialization cases.
5277
5278 2019-07-17  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5281         creation and re-initialization cases.
5282
5283 2019-07-17  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-regs.c (tui_get_register): Return void.
5286
5287 2019-07-17  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5290         Simplify.
5291
5292 2019-07-17  Tom Tromey  <tom@tromey.com>
5293
5294         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5295         resetting.
5296
5297 2019-07-17  Tom Tromey  <tom@tromey.com>
5298
5299         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5300         * tui/tui-regs.c (tui_reg_layout): New function.
5301         (tui_show_registers, tui_reg_command): Use it.
5302         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5303         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5304         parameters.
5305         (tui_layout_command): Remove.
5306
5307 2019-07-17  Tom Tromey  <tom@tromey.com>
5308
5309         * tui/tui-layout.h (tui/tui-layout): Return void.
5310         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5311
5312 2019-07-17  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-layout.c (show_source_disasm_command, show_data):
5315         Update.
5316         (reset_locator): Remove.
5317         (show_source_or_disasm_and_command): Update.
5318
5319 2019-07-17  Tom Tromey  <tom@tromey.com>
5320
5321         * tui/tui-source.c (tui_source_window_base::reset): Remove
5322         win_type parameter.
5323         * tui/tui-layout.c (make_command_window, make_source_window)
5324         (make_disasm_window, make_data_window)
5325         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5326         (reset_locator, show_source_or_disasm_and_command): Update.
5327         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5328         win_type parameter.
5329         (struct tui_source_window_base) <reset>: Likewise.
5330
5331 2019-07-17  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-layout.c (show_source_disasm_command): Use
5334         reset_locator.
5335         (reset_locator): New function.
5336         (init_and_make_win): Remove.
5337         (show_source_or_disasm_and_command): Use reset_locator.
5338
5339 2019-07-17  Tom Tromey  <tom@tromey.com>
5340
5341         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5342         condition.
5343         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5344         Remove condition.
5345         * tui/tui-source.c (tui_source_window_base::reset): New method.
5346         * tui/tui-layout.c (make_command_window): Don't call
5347         init_and_make_win.
5348         (make_source_window, make_disasm_window): Don't call
5349         make_source_or_disasm_window.
5350         (make_data_window): Don't call init_and_make_win.  Change calling
5351         convention.
5352         (show_source_disasm_command, show_data): Simplify.
5353         (make_source_or_disasm_window): Remove.
5354         (show_source_or_disasm_and_command): Simplify.
5355         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5356         (struct tui_source_window_base) <reset>: Likewise.
5357         <execution_info>: Remove initializer.
5358         * tui/tui-data.c (tui_source_window_base): Initialize
5359         execution_info.
5360
5361 2019-07-17  Tom Tromey  <tom@tromey.com>
5362
5363         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5364         variable.
5365
5366 2019-07-17  Tom Tromey  <tom@tromey.com>
5367
5368         * tui/tui.c (tui_rl_other_window): Update.
5369         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5370         superclass method first.  Always iterate over regs_content.
5371         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5372         method.
5373         * tui/tui-win.c (tui_set_focus_command): Update.
5374
5375 2019-07-17  Tom Tromey  <tom@tromey.com>
5376
5377         * tui/tui-win.c (tui_set_focus_command): Rename from
5378         tui_set_focus.  Call tui_enable.
5379         (tui_set_focus_command): Remove.
5380
5381 2019-07-17  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5384         refresh_window.
5385         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5386         touchwin.
5387         (tui_data_window::refresh_window): Call refresh_window on data
5388         items.  Always call superclass refresh_window.
5389         (tui_win_info::refresh): Remove.
5390         (tui_source_window_base::refresh_window): Update.
5391         (tui_refresh_all): Update.
5392         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5393         refresh_window.
5394         (show_source_or_disasm_and_command): Likewise.
5395         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5396         (struct tui_source_window_base) <refresh>: Likewise.
5397
5398 2019-07-17  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-winsource.c (tui_clear_source_content)
5401         (tui_show_source_content): Update.
5402         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5403         whether content is empty.
5404         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5405         Remove.
5406
5407 2019-07-17  Tom Tromey  <tom@tromey.com>
5408
5409         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5410         window's contents.
5411         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5412         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5413
5414 2019-07-17  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5417         (struct tui_data_item_window): Update.
5418
5419 2019-07-17  Tom Tromey  <tom@tromey.com>
5420
5421         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5422         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5423         defines.
5424
5425 2019-07-17  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui-winsource.h (tui_erase_source_content)
5428         (tui_clear_source_content): Remove "display_prompt" parameter.
5429         * tui/tui-winsource.c (tui_update_source_window_as_is)
5430         (tui_update_source_windows_with_addr): Update.
5431         (tui_clear_source_content): Remove "display_prompt" parameter.
5432         (tui_erase_source_content): Likewise.  Simplify.
5433         (tui_show_source_content): Update.
5434         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5435         * tui/tui-stack.c (tui_show_frame_info): Update.
5436         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5437         Remove defines.
5438
5439 2019-07-17  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5442         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5443         parameter.
5444         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5445         parameter.
5446
5447 2019-07-17  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-winsource.c (tui_clear_source_content)
5450         (tui_show_source_content, tui_show_exec_info_content)
5451         (tui_clear_exec_info_content): Update.
5452         * tui/tui-stack.c (tui_show_locator_content): Update.
5453         (tui_show_frame_info): Update.
5454         * tui/tui-source.h (tui_source_window): Don't declare.
5455         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5456         from tui_source_is_displayed.
5457         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5458         Remove field.
5459         (struct tui_source_window_base) <content_in_use>: New field.  Now
5460         bool.
5461         (struct tui_source_window) <showing_source_p>: New method.
5462         (TUI_SRC_WIN): Change cast.
5463         * tui/tui-data.c (tui_initialize_static_data): Update.
5464
5465 2019-07-17  Tom Tromey  <tom@tromey.com>
5466
5467         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5468         location_matches_p.
5469         * tui/tui-source.c (tui_source_window::location_matches_p): New
5470         method.
5471         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5472         method.
5473         * tui/tui-data.h (struct tui_source_window_base)
5474         <location_matches_p>: New method.
5475         (struct tui_source_window, struct tui_disasm_window)
5476         <location_matches_p>: Likewise.
5477
5478 2019-07-17  Tom Tromey  <tom@tromey.com>
5479
5480         * tui/tui-win.c (tui_set_win_height_command): Rename from
5481         tui_set_win_height.
5482         (tui_set_win_height_command): Remove.
5483
5484 2019-07-17  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-source.c (tui_source_window): New constructor.  Add
5487         observer.
5488         (~tui_source_window): New destructor.
5489         (tui_source_window::style_changed): New method.
5490         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5491         (tui_attach_detach_observers): Update.
5492         * tui/tui-data.h (struct tui_source_window): Make constructor not
5493         inline.  Add destructor.
5494         (struct tui_source_window) <style_changed>: New method.
5495         <m_observable>: New member.
5496
5497 2019-07-17  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5500         * tui/tui-win.c (tui_resize_all): Fix typo.
5501
5502 2019-07-17  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5505         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5506         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5507         * tui/tui-win.c (window_name_completer): Use foreach.
5508         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5509         (update_tab_width): Likewise.
5510         * tui/tui-layout.c (show_layout): Update.
5511         * tui/tui-data.h (class tui_window_iterator): New.
5512         (struct all_tui_windows): New.
5513         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5514
5515 2019-07-17  Tom Tromey  <tom@tromey.com>
5516
5517         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5518         parameter.  Don't reference globals.
5519         (tui_reg_command): Update.
5520
5521 2019-07-17  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-regs.c (tui_show_registers): Simplify.
5524
5525 2019-07-17  Tom Tromey  <tom@tromey.com>
5526
5527         * tui/tui-regs.c (tui_show_registers): Update.
5528         (tui_show_register_group): Add win_info parameter.
5529
5530 2019-07-17  Tom Tromey  <tom@tromey.com>
5531
5532         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5533         Rename from tui_display_reg_element_at_line.
5534         (tui_data_window::display_registers_from_line): Update.
5535         * tui/tui-data.h (struct tui_data_window)
5536         <display_reg_element_at_line>: New method.
5537
5538 2019-07-17  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-regs.h (tui_display_registers_from)
5541         (tui_display_registers_from_line): Don't declare.
5542         * tui/tui-windata.c (tui_data_window::display_all_data)
5543         (tui_data_window::refresh_all)
5544         (tui_data_window::do_scroll_vertical): Update.
5545         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5546         from tui_display_registers_from.
5547         (tui_display_reg_element_at_line): Update.
5548         (tui_data_window::display_registers_from_line): Rename from
5549         tui_display_registers_from_line.
5550         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5551         display_registers_from_line>: New methods.
5552
5553 2019-07-17  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5556         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5557         from tui_erase_data_content.
5558         (tui_data_window::display_all_data)
5559         (tui_data_window::refresh_all)
5560         (tui_data_window::do_scroll_vertical): Update.
5561         * tui/tui-regs.c (tui_show_registers): Update.
5562         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5563         New method.
5564
5565 2019-07-17  Tom Tromey  <tom@tromey.com>
5566
5567         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5568         declare.
5569         * tui/tui-windata.c
5570         (tui_data_window::delete_data_content_windows): Rename from
5571         tui_delete_data_content_windows.
5572         (tui_data_window::display_all_data)
5573         (tui_data_window::do_scroll_vertical): Update.
5574         * tui/tui-data.h (struct tui_data_window)
5575         <delete_data_content_windows>: New method.
5576
5577 2019-07-17  Tom Tromey  <tom@tromey.com>
5578
5579         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5580         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5581
5582 2019-07-17  Tom Tromey  <tom@tromey.com>
5583
5584         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5585         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5586         from tui_display_all_data.
5587         * tui/tui-win.c
5588         (tui_data_window::do_make_visible_with_new_height): Update.
5589         * tui/tui-regs.c (tui_show_registers): Update.
5590         * tui/tui-layout.c (tui_set_layout): Update.
5591         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5592         method.
5593
5594 2019-07-17  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5597         * tui/tui-windata.c (tui_display_data_from): Remove.
5598         (tui_data_window::refresh_all): Update.
5599
5600 2019-07-17  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5603         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5604         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5605         tui_display_registers_from_line.
5606         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5607         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5608         "force_display" parameter.
5609
5610 2019-07-17  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5613         declare.
5614         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5615         Rename from tui_first_reg_element_no_inline.
5616         (tui_display_reg_element_at_line)
5617         (tui_display_registers_from_line): Update.
5618         * tui/tui-data.h (struct tui_data_window)
5619         <first_reg_element_no_inline>: New method.
5620
5621 2019-07-17  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-windata.c (tui_display_data_from)
5624         (tui_data_window::do_scroll_vertical): Update.
5625         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5626         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5627         Rename from tui_line_from_reg_element_no.
5628         (tui_display_registers_from_line): Update.
5629         * tui/tui-data.h (struct tui_data_window)
5630         <line_from_reg_element_no>: New method.
5631
5632 2019-07-17  Tom Tromey  <tom@tromey.com>
5633
5634         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5635         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5636         tui_last_regs_line_no.
5637         (tui_display_reg_element_at_line)
5638         (tui_display_registers_from_line): Update.
5639         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5640         method.
5641
5642 2019-07-17  Tom Tromey  <tom@tromey.com>
5643
5644         PR tui/24722:
5645         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5646         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5647         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5648         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5649         (tui_update_breakpoint_info): Likewise.
5650         * tui/tui-hooks.c (tui_event_create_breakpoint)
5651         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5652         Update.
5653
5654 2019-07-17  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5657
5658 2019-07-17  Tom Tromey  <tom@tromey.com>
5659
5660         * tui/tui-winsource.c (tui_update_source_window_as_is)
5661         (tui_update_source_windows_with_addr): Update.
5662         * tui/tui-source.h (tui_set_source_content)
5663         (tui_show_symtab_source): Add "win_info" parameter.
5664         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5665         parameter.
5666         (tui_show_symtab_source): Likewise.
5667
5668 2019-07-17  Tom Tromey  <tom@tromey.com>
5669
5670         * tui/tui-wingeneral.c
5671         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5672
5673 2019-07-17  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5676         (struct tui_cmd_window) <can_scroll>: New method.
5677         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5678         method.
5679
5680 2019-07-17  Tom Tromey  <tromey@adacore.com>
5681
5682         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5683         do_field_signed>: Rename.  Change type of "value".
5684         * ui-out.c (ui_out::field_signed): Rename from field_int.
5685         Change type of "value".
5686         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5687         type of "value".
5688         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5689         do_field_int.  Change type of "value".
5690         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5691         do_field_int.  Change type of "value".
5692         * tracepoint.c (trace_status_mi, tfind_1)
5693         (print_one_static_tracepoint_marker): Update.
5694         * thread.c (print_thread_info_1, print_selected_thread_frame):
5695         Update.
5696         * stack.c (print_frame, print_frame_info): Update.
5697         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5698         Update.
5699         * source.c (print_source_lines_base): Update.
5700         * skip.c (info_skip_command): Update.
5701         * record-btrace.c (btrace_ui_out_decode_error)
5702         (btrace_call_history_src_line): Update.
5703         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5704         Update.
5705         * progspace.c (print_program_space): Update.
5706         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5707         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5708         do_field_int.  Change type of "value".
5709         * mi/mi-out.c (mi_ui_out::do_table_begin)
5710         (mi_ui_out::do_table_header): Update.
5711         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5712         type of "value".
5713         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5714         (mi_cmd_data_list_changed_registers, output_register)
5715         (mi_cmd_data_read_memory, mi_load_progress)
5716         (mi_cmd_trace_frame_collected): Update.
5717         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5718         Update.
5719         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5720         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5721         (mi_cmd_var_list_children, varobj_update_one): Update.
5722         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5723         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5724         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5725         * inferior.c (print_inferior): Update.
5726         * gdb_bfd.c (print_one_bfd): Update.
5727         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5728         Update.
5729         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5730         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5731         do_field_int.  Change type of "value".
5732         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5733         do_field_int.  Change type of "value".
5734         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5735         (print_one_breakpoint_location, print_it_catch_fork)
5736         (print_one_catch_fork, print_it_catch_vfork)
5737         (print_one_catch_vfork, print_it_catch_solib)
5738         (print_it_catch_exec, print_it_ranged_breakpoint)
5739         (print_mention_watchpoint, print_mention_masked_watchpoint)
5740         (bkpt_print_it, update_static_tracepoint): Update.
5741         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5742         * break-catch-syscall.c (print_it_catch_syscall): Update.
5743         * ada-tasks.c (print_ada_task_info): Update.
5744         * ada-lang.c (print_it_exception, print_mention_exception):
5745         Update.
5746
5747 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
5748
5749         PR breakpoints/24541
5750         * gdbarch.c: Regenerate.
5751         * gdbarch.h: Regenerate.
5752         * gdbarch.sh: Adjust return type and parameter types for
5753         'stap_adjust_register'.
5754         (i386_stap_adjust_register): Adjust signature and return new
5755         register name.
5756         * stap-probe.c (stap_parse_register_operand): Adjust use of
5757         'gdbarch_stap_adjust_register'.
5758
5759 2019-07-17  Tom Tromey  <tromey@adacore.com>
5760
5761         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
5762         declare VEC.
5763         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5764         std::vector.
5765         (struct s390_process_info): Add initializers.
5766         (s390_add_process): Use new.
5767         (s390_linux_nat_target::low_forget_process): Use delete.
5768         (s390_linux_nat_target::low_new_fork)
5769         (s390_linux_nat_target::stopped_by_watchpoint)
5770         (s390_linux_nat_target::low_prepare_to_resume)
5771         (s390_linux_nat_target::insert_watchpoint)
5772         (s390_linux_nat_target::insert_hw_breakpoint)
5773         (s390_linux_nat_target::remove_watchpoint)
5774         (s390_linux_nat_target::remove_hw_breakpoint): Update.
5775
5776 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5777
5778         * aarch64-fbsd-nat.c: Include regcache.h.
5779         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5780         argument.
5781         (aarch64_fbsd_nat_target::fetch_registers)
5782         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5783         variable.
5784         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5785
5786 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
5787
5788         * fbsd-nat.c: Include gdbarch.h.
5789
5790 2019-07-15  Tom Tromey  <tromey@adacore.com>
5791
5792         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5793
5794 2019-07-15  Tom Tromey  <tromey@adacore.com>
5795
5796         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5797         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5798         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5799         * cli-out.c (cli_ui_out::do_field_int): New method.
5800         * ui-out.c (ui_out::field_unsigned): New method.
5801         * symfile.c (generic_load): Use field_unsigned.
5802         (print_transfer_performance): Likewise.
5803         * record-btrace.c (ui_out_field_uint): Remove.
5804         (btrace_call_history_insn_range, btrace_call_history): Use
5805         field_unsigned.
5806         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5807         field_unsigned.
5808         * ui-out.h (class ui_out) <field_unsigned>: New method.
5809         <do_field_unsigned>: Likewise.
5810
5811 2019-07-15  Tom Tromey  <tromey@adacore.com>
5812
5813         * mi/mi-main.c (list_available_thread_groups): Use field_string.
5814         * mi/mi-interp.c (mi_memory_changed): Use field_string.
5815         * target.c (flash_erase_command): Use field_string.
5816         * infrun.c (print_signal_received_reason): Use field_string.
5817         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5818         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5819         field_string.
5820         * ada-tasks.c (print_ada_task_info): Use field_string.
5821
5822 2019-07-15  Tom Tromey  <tromey@adacore.com>
5823
5824         * target.c (flash_erase_command): Use field_core_addr.
5825         * symfile.c (generic_load): Use field_core_addr.
5826         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5827         Use field_core_addr.
5828         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5829         field_core_addr.
5830
5831 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5832
5833         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5834         value if its desired type is smaller than a CORE_ADDR and signed.
5835
5836 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5837
5838         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5839         of changes to field names, and use new is_reference field to
5840         decide if a property is a reference or not.
5841         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5842         field.
5843         (struct dwarf2_property_baton): Update header comment, rename
5844         'referenced_type' to 'property_type' and update comments.
5845         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5846         default property type, store in property baton, update to take
5847         accound of renamed field.
5848         (read_func_scope): Update call to attr_to_dynamic_prop.
5849         (read_array_type): Likewise.
5850         (dwarf2_per_cu_addr_sized_int_type): New function.
5851         (read_subrange_index_type): Move type finding code to
5852         dwarf2_per_cu_addr_sized_int_type.
5853         (read_subrange_type): Update calls to attr_to_dynamic_prop.
5854         (dwarf2_per_cu_addr_type): New function.
5855         (set_die_type): Update calls to attr_to_dynamic_prop.
5856
5857 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * dwarf2read.c (read_subrange_index_type): New function.
5860         (read_subrange_type): Move code into new function and call it.
5861         * gdbtypes.c (create_range_type): Add some asserts.
5862
5863 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5864
5865         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5866         update return statements.
5867         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5868         declaration, and update comment to match.
5869         * gdbtypes.c (resolve_dynamic_array): Update call to
5870         dwarf2_evaluate_property to match new return type.
5871
5872 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * valarith.c (value_subscripted_rvalue): Change lowerbound
5875         parameter type from int to LONGEST.
5876         * value.h (value_subscripted_rvalue): Likewise in declaration.
5877
5878 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5879
5880         * cli/cli-utils.c (info_print_command_completer): New function.
5881         * cli/cli-utils.h: Add 'completer.h' include, and forward
5882         declaration for 'struct cmd_list_element'.
5883         (info_print_command_completer): Declare.
5884         * stack.c (_initialize_stack): Add completer for 'info locals' and
5885         'info args'.
5886         * symtab.c (_initialize_symtab): Add completer for 'info
5887         variables' and 'info functions'.
5888         * NEWS: Mention completion for additional info commands.
5889
5890 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5891
5892         * cli/cli-utils.c (extract_info_print_args): Delete.
5893         (extract_arg_maybe_quoted): Delete.
5894         (info_print_options_defs): New variable.
5895         (make_info_print_options_def_group): New function.
5896         (extract_info_print_options): Define new function.
5897         * cli/cli-utils.h (extract_info_print_args): Delete.
5898         (struct info_print_options): New structure.
5899         (extract_info_print_options): Declare new function.
5900         * stack.c (info_locals_command): Update to use new
5901         extract_info_print_options, also add a header comment.
5902         (info_args_command): Likewise.
5903         * symtab.c (info_variables_command): Likewise.
5904         (info_functions_command): Likewise.
5905
5906 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5907
5908         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5909         to extract string arguments.
5910         * common/common-utils.c (extract_string_maybe_quoted): New function.
5911         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5912
5913 2019-07-11  Tom Tromey  <tromey@adacore.com>
5914
5915         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5916         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5917         * top.h (gdbinit): Don't declare.
5918         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5919         into...
5920         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5921         * top.c (gdb_init): Don't call init_cli_cmds.
5922         (gdbinit): Remove.
5923         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5924
5925 2019-07-11  Tom Tromey  <tromey@adacore.com>
5926
5927         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5928         after it has been moved.
5929
5930 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5931
5932         * valops.c (value_must_coerce_to_target): Change return type to
5933         bool.
5934         * value.h (value_must_coerce_to_target): Likewise.
5935
5936 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5937
5938         * breakpoint.c (is_hardware_watchpoint): Remove
5939         forward-declaration.
5940         (is_masked_watchpoint): Change return type to bool.
5941         (is_tracepoint): Likewise.
5942         (is_breakpoint): Likewise.
5943         (is_hardware_watchpoint): Likewise.
5944         (is_watchpoint): Likewise.
5945         (is_no_memory_software_watchpoint): Likewise.
5946         (is_catchpoint): Likewise.
5947         (breakpoint_1): Make FILTER parameter's return type bool.
5948         is_masked_watchpoint): Change return type to bool.
5949         (save_breakpoints): Make FILTER parameter's return type bool.
5950         * breakpoint.h (is_breakpoint): Change return type to bool.
5951         (is_watchpoint): Likewise.
5952         (is_catchpoint): Likewise.
5953         (is_tracepoint): Likewise.
5954
5955 2019-07-10  Tom Tromey  <tom@tromey.com>
5956
5957         * defs.h: Don't include gdbarch.h.
5958         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5959         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5960         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5961         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5962         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5963         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5964         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5965         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5966         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5967         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5968         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5969         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5970         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5971         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5972         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5973         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5974         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5975         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5976         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5977         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5978         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5979         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5980         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5981         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5982         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5983         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5984         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5985
5986 2019-07-10  Tom Tromey  <tromey@adacore.com>
5987
5988         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5989         * breakpoint.c (init_ada_exception_breakpoint): Register as
5990         bp_catchpoint.
5991         (print_one_breakpoint_location, print_one_breakpoint): Use
5992         is_ada_exception_catchpoint.
5993         * ada-lang.c (class ada_catchpoint_location): Pass
5994         bp_loc_software_breakpoint to bp_location constructor.
5995         (is_ada_exception_catchpoint): New function.
5996
5997 2019-07-10  Tom Tromey  <tromey@adacore.com>
5998
5999         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6000         VEC.
6001         (struct arm_exidx_entry): New method operator<.
6002         (struct arm_exidx_data) <section_maps>: Change type.
6003         (arm_exidx_data_free): Remove.
6004         (arm_exidx_data_key): Change type.  Move lower.
6005         (arm_exidx_new_objfile): Update.
6006         (arm_compare_exidx_entries): Remove.
6007         (arm_find_exidx_entry, _initialize_arm_tdep)
6008
6009 2019-07-10  Tom Tromey  <tromey@adacore.com>
6010
6011         * solib-spu.c (ocl_program_data_key): Change type.
6012         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6013         Update.
6014
6015 2019-07-10  Tom Tromey  <tromey@adacore.com>
6016
6017         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6018         (struct solib_aix_inferior_data) <library_list>: Change type.
6019         (solib_aix_inferior_data_handle): Change type.
6020         (get_solib_aix_inferior_data): Update.
6021         (solib_aix_free_library_list): Remove.
6022         (library_list_start_library): Update.
6023         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6024         return type.
6025         (solib_aix_get_library_list)
6026         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6027         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6028
6029 2019-07-10  Tom Tromey  <tromey@adacore.com>
6030
6031         * solib-dsbt.c (struct dsbt_info): Add initializers.
6032         (solib_dsbt_pspace_data): Change type.
6033         (dsbt_pspace_data_cleanup): Remove.
6034         (get_dsbt_info, _initialize_dsbt_solib): Update.
6035
6036 2019-07-10  Tom Tromey  <tromey@adacore.com>
6037
6038         * spu-tdep.c (spu_overlay_data): Change type.
6039         (spu_get_overlay_table, spu_overlay_new_objfile)
6040         (_initialize_spu_tdep): Update.
6041
6042 2019-07-10  Tom Tromey  <tromey@adacore.com>
6043
6044         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6045         destructor.
6046         (dbx_objfile_data_key): Change type and declare later.
6047         (DBX_SYMFILE_INFO): Rewrite.
6048         * dbxread.c (dbx_objfile_data_key): Change type.
6049         (dbx_symfile_init): Update.
6050         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6051         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6052         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6053
6054 2019-07-10  Tom Tromey  <tromey@adacore.com>
6055
6056         * jit.c (jit_program_space_key): Change type.  Move lower.
6057         (get_jit_program_space_data): Update.
6058         (jit_program_space_data_cleanup): Remove.
6059         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6060         Update.
6061         (struct jit_program_space_data): Add initializers.
6062
6063 2019-07-10  Tom Tromey  <tromey@adacore.com>
6064
6065         * solib-darwin.c (struct darwin_info): Add initializers.
6066         (solib_darwin_pspace_data): Change type.
6067         (darwin_pspace_data_cleanup): Remove.
6068         (get_darwin_info, _initialize_darwin_solib): Update.
6069
6070 2019-07-10  Tom Tromey  <tromey@adacore.com>
6071
6072         * remote-sim.c (struct sim_inferior_data): Add initializers,
6073         constructor, and destructor.
6074         (sim_inferior_data_key): Change type.  Move lower.
6075         (check_for_duplicate_sim_descriptor): Update.
6076         (get_sim_inferior_data): Use new.  Update.
6077         (~sim_inferior_data_cleanup): Rename from
6078         sim_inferior_data_cleanup.  Simplify.
6079         (gdbsim_close_inferior, simulator_command)
6080         (sim_command_completer, _initialize_remote_sim): Update.
6081         (next_pid, INITIAL_PID): Move earlier.
6082
6083 2019-07-10  Tom Tromey  <tromey@adacore.com>
6084
6085         * python/python-internal.h (create_thread_object): Return
6086         gdbpy_ref.
6087         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6088         * python/py-inferior.c (struct threadlist_entry): Add
6089         constructor.
6090         <thread_obj>: Now a gdbpy_ref.
6091         (thread_to_thread_object): Update.
6092         (add_thread_object): Use new.
6093         (delete_thread_object): Use delete.
6094         (infpy_threads): Update.
6095         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6096         GIL.
6097
6098 2019-07-10  Tom Tromey  <tromey@adacore.com>
6099
6100         * valops.c (value_cast): Specialize error message for Ada.
6101
6102 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6103
6104         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6105
6106 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6107
6108         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6109         bpstat_should_step): Return bool, adjust comments.
6110         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6111         bpstat_should_step): Likewise.
6112
6113 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6114
6115         * features/Makefile: Use feature target descriptions for Arm.
6116         * features/arm/arm-core.c: Generate new file.
6117         * features/arm/arm-fpa.c: Likewise.
6118         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6119         * features/arm/arm-m-profile.c: Likewise.
6120         * features/arm/arm-vfpv2.c: Likewise.
6121         * features/arm/arm-vfpv3.c: Likewise.
6122         * features/arm/xscale-iwmmxt.c: Likewise.
6123         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6124
6125 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6126
6127         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6128         ptrace earlier.
6129
6130 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6131
6132         * features/aarch64-pauth.c: Regenerate.
6133
6134 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6135
6136         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6137         bool.
6138         (bpstat_what): Use false instead of 0.
6139
6140 2019-07-09  Pedro Alves  <palves@redhat.com>
6141
6142         * break-catch-throw.c (is_exception_catchpoint): New.
6143         * breakpoint.c (print_one_breakpoint_location): New parameter
6144         'raw_loc'.  Handle it.  Use
6145         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6146         looking at the breakpoint's type.
6147         (print_one_breakpoint): If handling "maint info breakpoints", also
6148         print locations of exception catchpoints.
6149         * breakpoint.h (is_exception_catchpoint): Declare.
6150
6151 2019-07-09  Pedro Alves  <palves@redhat.com>
6152
6153         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6154         "addr" field.
6155         (allocate_location_exception_catchpoint): New.
6156         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6157         (initialize_throw_catchpoint_ops): Install
6158         allocate_location_exception_catchpoint as allocate_location
6159         method.
6160         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6161         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6162         bp_loc_other.
6163         (breakpoint_address_is_meaningful): Delete.
6164         (bl_address_is_meaningful): New.
6165         (breakpoint_locations_match): Adjust comment.
6166         (bp_location_from_bp_type): New, factored out of...
6167         (bp_location::bp_location(breakpoint *)): ... this.
6168         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6169         factored out of...
6170         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6171         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6172         breakpoint_address_is_meaningful.
6173         (bp_locations_compare): Adjust comment.
6174         (update_global_location_list): Use bl_address_is_meaningful
6175         instead of breakpoint_address_is_meaningful.
6176         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6177         explicit.
6178         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6179         * python/py-breakpoint.c (bppy_get_location): No longer check
6180         whether location is null.
6181
6182 2019-07-09  Pedro Alves  <palves@redhat.com>
6183
6184         PR c++/15468
6185         * breakpoint.c (print_one_breakpoint_location): Remove
6186         single-location assert.
6187
6188 2019-07-09  Tom Tromey  <tom@tromey.com>
6189
6190         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6191         * configure: Rebuild.
6192         * configure.ac: Change common to gdbsupport.
6193         * gdbsupport: Rename from common.
6194         * acinclude.m4: Change common to gdbsupport.
6195         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6196         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6197         gdbsupport.
6198         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6199         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6200         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6201         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6202         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6203         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6204         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6205         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6206         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6207         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6208         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6209         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6210         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6211         coff-pe-read.c, command.h, compile/compile-c-support.c,
6212         compile/compile-c.h, compile/compile-cplus-symbols.c,
6213         compile/compile-cplus-types.c, compile/compile-cplus.h,
6214         compile/compile-loc2c.c, compile/compile.c, completer.c,
6215         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6216         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6217         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6218         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6219         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6220         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6221         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6222         features/aarch64-core.c, features/aarch64-fpu.c,
6223         features/aarch64-pauth.c, features/aarch64-sve.c,
6224         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6225         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6226         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6227         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6228         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6229         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6230         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6231         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6232         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6233         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6234         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6235         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6236         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6237         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6238         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6239         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6240         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6241         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6242         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6243         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6244         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6245         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6246         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6247         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6248         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6249         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6250         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6251         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6252         minsyms.c, mips-linux-tdep.c, namespace.h,
6253         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6254         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6255         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6256         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6257         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6258         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6259         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6260         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6261         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6262         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6263         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6264         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6265         procfs.c, producer.c, progspace.h, psymtab.h,
6266         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6267         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6268         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6269         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6270         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6271         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6272         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6273         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6274         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6275         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6276         target-memory.c, target.c, target.h, target/waitstatus.c,
6277         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6278         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6279         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6280         unittests/array-view-selftests.c,
6281         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6282         unittests/common-utils-selftests.c,
6283         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6284         unittests/format_pieces-selftests.c,
6285         unittests/function-view-selftests.c,
6286         unittests/lookup_name_info-selftests.c,
6287         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6288         unittests/mkdir-recursive-selftests.c,
6289         unittests/observable-selftests.c,
6290         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6291         unittests/parse-connection-spec-selftests.c,
6292         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6293         unittests/scoped_fd-selftests.c,
6294         unittests/scoped_mmap-selftests.c,
6295         unittests/scoped_restore-selftests.c,
6296         unittests/string_view-selftests.c, unittests/style-selftests.c,
6297         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6298         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6299         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6300         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6301         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6302         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6303
6304 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6307         bool value.
6308         (decode_digits_ordinary): Set explicit_line field in sal.
6309         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6310         symtab_and_line that was set on an explicit line number in
6311         assembler code.  Do always update the recorded symtab and line if
6312         we do skip the prologue.
6313
6314 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * breakpoint.c (set_breakpoint_location_function): Remove
6317         explicit_loc parameter.
6318         (momentary_breakpoint_from_master): Update call to
6319         set_breakpoint_location_function.
6320         (add_location_to_breakpoint): Likewise.
6321
6322 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6325         required features based on default bfd type when no specific bfd
6326         is present.
6327
6328 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6329
6330         * NEWS: Mention that GDB printf and eval commands can now print
6331         C-style and Ada-style convenience var strings without
6332         calling the inferior.
6333         * printcmd.c (printf_c_string): Locally print GDB internal var
6334         instead of transiting via the inferior.
6335         (printf_wide_c_string): Likewise.
6336
6337 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6338
6339         PR breakpoints/25011
6340         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6341
6342 2019-07-04  Tom Tromey  <tom@tromey.com>
6343
6344         PR tui/24724:
6345         * tui/tui-winsource.c (tui_clear_source_content): Update.
6346         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6347         (tui_update_breakpoint_info): Update.
6348         (tui_set_exec_info_content): Update.
6349         * tui/tui-source.c (tui_set_source_content_nil): Update.
6350         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6351         has_break.
6352         * tui/tui-data.h (enum tui_bp_flag): New.
6353         (tui_bp_flags): New enum flags type.
6354         (struct tui_source_element) <break_mode>: Change type.  Rename
6355         from has_break.
6356         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6357         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6358         constants.
6359         * tui/tui-winsource.h: Fix comment.
6360
6361 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6362
6363         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6364         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6365         (store_fpregs_to_thread)
6366         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6367         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6368         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6369         (IWMMXT_REGS_SIZE): Add define.
6370         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6371         (fetch_vfp_regs, store_vfp_regs)
6372         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6373         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6374
6375 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6376
6377         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6378         defines.
6379         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6380         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6381         (ARM_INT_REGISTER_SIZE): ...to this.
6382         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6383         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6384         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6385         (arm_linux_collect_gregset, supply_nwfpe_register)
6386         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6387         defines.
6388         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6389         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6390         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6391         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6392         (arm_return_in_memory, arm_store_return_value)
6393         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6394         (arm_record_ld_st_multiple): Likewise.
6395         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6396         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6397
6398 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6399
6400         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6401         AARCH64_DISPLACED_MODIFIED_INSNS.
6402         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6403         (aarch64_displaced_step_copy_insn): Likewise.
6404         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6405         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6406         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6407         ARM_DISPLACED_MODIFIED_INSNS.
6408         * arm-tdep.c (arm_gdbarch_init): Likewise.
6409         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6410         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6411         (struct arm_displaced_step_closure): Use
6412         ARM_DISPLACED_MODIFIED_INSNS.
6413
6414 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6415
6416         * features/Makefile: Remove unused xml files.
6417         * features/aarch64.xml: Remove.
6418         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6419         * features/i386/amd64-avx-avx512.xml: Remove.
6420         * features/i386/amd64-avx-linux.xml: Remove.
6421         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6422         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6423         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6424         * features/i386/amd64-avx-mpx.xml: Remove.
6425         * features/i386/amd64-avx.xml: Remove.
6426         * features/i386/amd64-linux.xml: Remove.
6427         * features/i386/amd64-mpx-linux.xml: Remove.
6428         * features/i386/amd64-mpx.xml: Remove.
6429         * features/i386/amd64.xml: Remove.
6430         * features/i386/i386-avx-avx512-linux.xml: Remove.
6431         * features/i386/i386-avx-avx512.xml: Remove.
6432         * features/i386/i386-avx-linux.xml: Remove.
6433         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6434         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6435         * features/i386/i386-avx-mpx-linux.xml: Remove.
6436         * features/i386/i386-avx-mpx.xml: Remove.
6437         * features/i386/i386-avx.xml: Remove.
6438         * features/i386/i386-linux.xml: Remove.
6439         * features/i386/i386-mmx-linux.xml: Remove.
6440         * features/i386/i386-mmx.xml: Remove.
6441         * features/i386/i386-mpx-linux.xml: Remove.
6442         * features/i386/i386-mpx.xml: Remove.
6443         * features/i386/i386.xml: Remove.
6444         * features/i386/x32-avx-avx512-linux.xml: Remove.
6445         * features/i386/x32-avx-linux.xml: Remove.
6446         * features/i386/x32-linux.xml: Remove.
6447
6448 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6449
6450         * regformats/aarch64.dat: Remove.
6451         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6452         * regformats/i386/amd64-avx-linux.dat: Remove.
6453         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6454         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6455         * regformats/i386/amd64-linux.dat: Remove.
6456         * regformats/i386/amd64-mpx-linux.dat: Remove.
6457         * regformats/i386/amd64.dat: Remove.
6458         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6459         * regformats/i386/i386-avx-linux.dat: Remove.
6460         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6461         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6462         * regformats/i386/i386-linux.dat: Remove.
6463         * regformats/i386/i386-mmx-linux.dat: Remove.
6464         * regformats/i386/i386-mpx-linux.dat: Remove.
6465         * regformats/i386/i386.dat: Remove.
6466         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6467         * regformats/i386/x32-avx-linux.dat: Remove.
6468         * regformats/i386/x32-linux.dat: Remove.
6469
6470 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6471
6472         * aarch64-tdep.c: Remove xml self tests.
6473         * amd64-linux-tdep.c: Likewise.
6474         * amd64-tdep.c: Likewise.
6475         * i386-linux-tdep.c: Likewise.
6476         * i386-tdep.c: Likewise.
6477
6478 2019-07-03  Pedro Alves  <palves@redhat.com>
6479
6480         PR cli/24732
6481         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6482         (pipe_cmd_option_defs): New.
6483         (make_pipe_cmd_options_def_group): New.
6484         (pipe_command): Use gdb::option::process_options.
6485         (pipe_command_completer): New function.
6486         (_initialize_cli_cmds): Install completer for "pipe" command.
6487
6488 2019-07-03  Pedro Alves  <palves@redhat.com>
6489
6490         * cli/cli-option.c (union option_value) <string>: New field.
6491         (struct option_def_and_value): Add ctor, move ctor, dtor and
6492         use DISABLE_COPY_AND_ASSIGN.
6493         (option_def_and_value::clear_value): New.
6494         (parse_option, save_option_value_in_ctx, get_val_type_str)
6495         (add_setshow_cmds_for_options): Handle var_string.
6496         * cli-option.h (union option_def::var_address) <string>: New
6497         field.
6498         (struct string_option_def): New.
6499         * maint-test-options.c (struct test_options_opts): Add default
6500         ctor and use DISABLE_COPY_AND_ASSIGN.
6501         <string_opt>: New field.
6502         (test_options_opts::~test_options_opts): New.
6503         (test_options_opts::dump): Also dump "-string".
6504         (test_options_option_defs): Install "string.
6505
6506 2019-07-03  Pedro Alves  <palves@redhat.com>
6507
6508         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6509         option_value with a null enumeration.
6510         (complete_options): Save the option values in the context.
6511         (save_option_value_in_ctx): New, factored out from ...
6512         (process_options): ... here.
6513         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6514         of the function.
6515         * maint-test-options.c (test_options_opts::dump): New, factored
6516         out from ...
6517         (maintenance_test_options_command_mode): ... here.
6518         (maintenance_test_options_command_completion_result): Delete.
6519         (maintenance_test_options_command_completion_text): Update
6520         comment.
6521         (maintenance_show_test_options_completion_result): Change
6522         prototype.  Just print
6523         maintenance_test_options_command_completion_text.
6524         (save_completion_result): New.
6525         (maintenance_test_options_completer_mode): Pass options context to
6526         complete_options, and then save a dump.
6527         (_initialize_maint_test_options): Use add_cmd to install "maint
6528         show test-options-completion-result".
6529
6530 2019-07-03  Pedro Alves  <palves@redhat.com>
6531
6532         * NEWS (New commands): Mention "with" and "maint with".
6533         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6534         (with_command, with_command_completer): New.
6535         (pipe_command): Adjust to new repeat_previous
6536         interface.
6537         (_initialize_cli_cmds): Install the "with" command and its "w"
6538         alias.
6539         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6540         declarations.
6541         * cli/cli-setshow.c (parse_cli_var_uinteger)
6542         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6543         argument strings for all var_types.
6544         (get_setshow_command_value_string): New, factored out from ...
6545         (do_show_command): ... this.
6546         * cli/cli-setshow.h: Include <string>.
6547         (get_setshow_command_value_string): Declare.
6548         * command.h (repeat_previous): Now returns const char *.  Adjust
6549         comment.
6550         * maint.c: Include "cli/cli-cmds.h".
6551         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6552         (_initialize_maint_cmds): Register the "maintenance with" command.
6553         * top.c (repeat_previous): Move bits from pipe_command here:
6554         Return the saved command line, if any; error out if there's no
6555         command to relaunch.
6556
6557 2019-07-03  Pedro Alves  <palves@redhat.com>
6558
6559         * NEWS (New commands): Mention "maint set/show test-settings"
6560         instead of "maint test-settings".
6561         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6562         (maintenance_test_settings_set_list): Rename to ...
6563         (maintenance_set_test_settings_list): ... this.
6564         (maintenance_test_settings_show_list): Rename to  ...
6565         (maintenance_show_test_settings_list): ... this.
6566         (maintenance_test_settings_cmd): Delete.
6567         (maintenance_test_settings_set_cmd): ...
6568         (maintenance_set_test_settings_cmd): ... this.
6569         (maintenance_test_settings_show_cmd): ...
6570         (maintenance_show_test_settings_cmd): ... this.
6571         (maintenance_test_settings_show_value_cmd):
6572         (maintenance_show_test_settings_value_cmd): ... this.
6573         (_initialize_maint_test_settings): No longer install the "maint
6574         test-settings" prefix command.  Rename "maint test-settings set"
6575         to "maint set test-settings", and "maint test-settings show" to
6576         "maint show test-settings".  Adjust all subcommands.
6577
6578 2019-07-03  Pedro Alves  <palves@redhat.com>
6579
6580         * maint-test-settings.c: Fix file's intro comment.  Replace all
6581         references to "test-options" with references to "test-settings",
6582         in comments.
6583
6584 2019-07-03  Pedro Alves  <palves@redhat.com>
6585
6586         * maint-test-settings.c (maintenance_test_settings_xxx)
6587         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6588         New.
6589         (maintenance_test_settings_enums): Use them.
6590         (maintenance_test_settings_enum): Default to
6591         maintenance_test_settings_xxx.
6592         (_initialize_maint_test_settings): Initialize
6593         MAINTENANCE_TEST_SETTINGS_FILENAME.
6594
6595 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6596
6597         * breakpoint.h (remove_breakpoints_inf): Change return type to
6598         void, move function documentation here.
6599         * breakpoint.c (remove_breakpoints_inf): Change return type to
6600         void, move function documentation to header.
6601
6602 2019-07-02  Pedro Alves  <palves@redhat.com>
6603
6604         * NEWS (Completion improvements): Mention "info threads".
6605         * thread.c (struct info_threads_opts, info_threads_option_defs)
6606         (make_info_threads_options_def_group): New.
6607         (info_threads_command): Use gdb::option::process_options.
6608         (info_threads_command_completer): New.
6609         (_initialize_thread): Use gdb::option::build_help to build the
6610         help text for "info threads".
6611
6612 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6613
6614         * defs.h (generic_load): Move from here...
6615         * symfile.h (generic_load): ... to here.  Rename name parameter
6616         to args.
6617         * symfile.c (generic_load): Add comment.
6618
6619 2019-07-01  Tom Tromey  <tromey@adacore.com>
6620
6621         * dwarf2read.c
6622         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6623         declaration of without_params.  Fix formatting.
6624
6625 2019-07-01  Tom Tromey  <tromey@adacore.com>
6626
6627         * ada-exp.y (find_primitive_type): Update.
6628         * ada-lang.h (ada_lookup_symbol): Update.
6629         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6630         parameter.
6631         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6632
6633 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6634
6635         PR breakpoints/24541
6636         * gdbarch.c: Regenerate.
6637         * gdbarch.h: Regenerate.
6638         * gdbarch.sh: Add 'stap_adjust_register'.
6639         * i386-tdep.c: Include '<unordered_set>'.
6640         (i386_stap_adjust_register): New function.
6641         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6642         * stap-probe.c (stap_parse_register_operand): Call
6643         'gdbarch_stap_adjust_register'.
6644
6645 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6646
6647         PR python/24742
6648         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6649         * python/python.c (do_start_initialization): Use 'xmalloc'
6650         instead of 'PyMem_Malloc'.
6651
6652 2019-06-28  Tom Tromey  <tromey@adacore.com>
6653
6654         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6655         for Ada.
6656
6657 2019-06-27  Tom Tromey  <tromey@adacore.com>
6658
6659         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6660         objfile_key.
6661         (arm_find_mapping_symbol, arm_record_special_symbol)
6662         (_initialize_arm_tdep): Update.
6663         (arm_objfile_data_free): Remove.
6664
6665 2019-06-27  Tom Tromey  <tromey@adacore.com>
6666
6667         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6668         to cp_print_static_field.
6669
6670 2019-06-26  Tom Tromey  <tromey@adacore.com>
6671
6672         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6673         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6674         declare.
6675
6676 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6677
6678         * features/aarch64-core.c (create_feature_aarch64_core):
6679         Regenerate.
6680         * features/aarch64-core.xml: Add cpsr flags.
6681
6682 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6683
6684         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6685         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6686
6687 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6688
6689         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6690         field.
6691         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6692         use.
6693         (arm_record_special_symbol): Don't insert new symbol in sorted
6694         position, push it at the end.
6695
6696 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6697
6698         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6699         (arm_mapping_symbol_s): Remove.
6700         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6701         (arm_mapping_symbol_vec): New typedef.
6702         (struct arm_per_objfile): Add constructor.
6703         <section_maps>: Change type to
6704         std::unique_ptr<arm_mapping_symbol_vec[]>.
6705         (arm_compare_mapping_symbols): Remove.
6706         (arm_find_mapping_symbol): Adjust to section_maps type change.
6707         (arm_objfile_data_free): Call delete on arm_per_objfile.
6708         (arm_record_special_symbol): Adjust to section_maps type change.
6709         Allocate arm_per_objfile with new.
6710
6711 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6712
6713         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6714         with the command prefix.
6715
6716 2019-06-25  Tom Tromey  <tom@tromey.com>
6717
6718         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6719         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6720
6721 2019-06-25  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6724         type.
6725         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6726         protected.
6727
6728 2019-06-25  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui-winsource.c
6731         (tui_source_window_base::set_is_exec_point_at): Add check against
6732         LOA_ADDRESS.
6733
6734 2019-06-25  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-source.c (tui_set_source_content): Don't check before
6737         xfree.
6738         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6739
6740 2019-06-25  Tom Tromey  <tom@tromey.com>
6741
6742         * tui/tui-winsource.h (tui_update_source_window_as_is)
6743         (tui_alloc_source_buffer, tui_line_is_displayed)
6744         (tui_addr_is_displayed): Change type of win_info.
6745         * tui/tui-winsource.c (tui_update_source_window_as_is)
6746         (tui_clear_source_content, tui_show_source_line)
6747         (tui_show_source_content, tui_source_window_base::refill)
6748         (tui_source_window_base::set_is_exec_point_at)
6749         (tui_source_window_base::set_is_exec_point_at)
6750         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6751         (tui_alloc_source_buffer, tui_line_is_displayed)
6752         (tui_addr_is_displayed): Change type of win_info.  Update.
6753         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6754         (tui_source_window_base::do_make_visible_with_new_height):
6755         Update.
6756         * tui/tui-source.c (tui_set_source_content)
6757         (tui_set_source_content_nil)
6758         (tui_source_window::do_scroll_vertical): Update.
6759         * tui/tui-layout.c (show_layout): Update.
6760         * tui/tui-disasm.c (tui_set_disassem_content)
6761         (tui_disasm_window::do_scroll_vertical): Update.
6762         * tui/tui-data.h (tui_win_content): Remove.
6763         (struct tui_gen_win_info) <content, content_size>: Remove.
6764         (struct tui_source_element): Add initializers and destructor.
6765         (union tui_which_element, struct tui_win_element): Remove.
6766         (struct tui_source_window_base) <content>: New field.
6767         (struct tui_data_window): Remove destructor.
6768         (tui_alloc_content, tui_free_win_content)
6769         (tui_free_all_source_wins_content): Don't declare.
6770         * tui/tui-data.c (tui_initialize_static_data): Update.
6771         (init_content_element, tui_alloc_content): Remove.
6772         (~tui_gen_win_info): Update.
6773         (~tui_data_window, tui_free_all_source_wins_content)
6774         (tui_free_win_content, free_content, free_content_elements):
6775         Remove.
6776
6777 2019-06-25  Tom Tromey  <tom@tromey.com>
6778
6779         * tui/tui-winsource.h (tui_clear_source_content)
6780         (tui_erase_source_content, tui_show_source_content): Change type
6781         of win_info.
6782         * tui/tui-winsource.c (tui_clear_source_content)
6783         (tui_erase_source_content, tui_show_source_content): Change type
6784         of win_info.
6785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6786         * tui/tui-source.h (tui_set_source_content_nil): Change type of
6787         win_info.
6788         * tui/tui-source.c (tui_set_source_content_nil): Change type of
6789         win_info.
6790         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6791
6792 2019-06-25  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-winsource.c (tui_clear_source_content)
6795         (tui_source_window_base::set_is_exec_point_at): Update.
6796         * tui/tui-source.c (tui_set_source_content_nil): Update.
6797         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6798         a bool.
6799         * tui/tui-data.c (init_content_element): Update.
6800
6801 2019-06-25  Tom Tromey  <tom@tromey.com>
6802
6803         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6804         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6805         * tui/tui-layout.c (init_and_make_win): Update.
6806         * tui/tui.h (enum tui_win_type): Update.
6807         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6808         tui_win_is_auxillary.
6809         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6810         tui_win_is_auxillary.
6811
6812 2019-06-25  Tom Tromey  <tom@tromey.com>
6813
6814         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6815         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6816         (tui_delete_data_content_windows, tui_display_all_data)
6817         (tui_data_window::do_scroll_vertical, tui_display_data_from):
6818         Update.
6819         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6820         * tui/tui-regs.c (tui_last_regs_line_no)
6821         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6822         (tui_show_registers): Update.
6823         (tui_show_register_group): Return void.  Update.
6824         (tui_display_registers_from, tui_display_reg_element_at_line)
6825         (tui_display_registers_from_line, tui_check_register_values):
6826         Update.
6827         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6828         member.
6829         (struct tui_data_window) <regs_content>: Now a std::vector.
6830         <regs_content_count>: Remove.
6831         (tui_add_content_elements, tui_free_data_content): Don't declare.
6832         * tui/tui-data.c (tui_data_window::clear_detail): Update.
6833         (init_content_element): Remove DATA_WIN case.  Add assert.
6834         (tui_add_content_elements): Remove.
6835         (tui_data_window): Update.
6836         (tui_free_data_content): Remove.
6837         (free_content_elements): Remove DATA_WIN case.
6838
6839 2019-06-25  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-data.c (tui_data_item_window): Update.
6842         * tui/tui-windata.h (tui_check_data_values): Don't declare.
6843         * tui/tui-windata.c (tui_display_all_data)
6844         (tui_display_data_from_line): Update.
6845         (tui_check_data_values): Remove.
6846         * tui/tui-regs.c (tui_show_register_group)
6847         (tui_display_reg_element_at_line): Update.
6848         * tui/tui-hooks.c (tui_register_changed)
6849         (tui_refresh_frame_and_register_information): Call
6850         tui_check_register_values.
6851         * tui/tui-data.h (struct tui_data_window) <data_content,
6852         data_content_count, data_type>: Remove.
6853         (enum tui_data_type): Remove.
6854
6855         * tui/tui-data.c (tui_data_window::clear_detail)
6856         (~tui_data_window): Update.
6857
6858 2019-06-25  Tom Tromey  <tom@tromey.com>
6859
6860         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6861         declare.
6862         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6863         Rename from tui_first_data_item_displayed.  Update.
6864         (tui_data_window::refresh_all)
6865         (tui_data_window::do_scroll_vertical): Update.
6866         * tui/tui-data.h (struct tui_data_window)
6867         <first_data_item_displayed>: Declare new method.
6868
6869 2019-06-25  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-data.h (tui_init_generic_part): Don't declare.
6872         * tui/tui-data.c (tui_init_generic_part): Remove, moving
6873         contents...
6874         (tui_initialize_static_data): ...here.
6875
6876 2019-06-25  Tom Tromey  <tom@tromey.com>
6877
6878         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6879         (tui_display_registers_from, tui_check_register_values): Update.
6880         (tui_display_register): Remove win_info parameter; update.
6881         (tui_get_register): Change type of parameters.
6882         * tui/tui-data.h (struct tui_data_element): Remove.
6883         (union tui_which_element) <data>: Remove.
6884         <data_window>: Change type.
6885         (struct tui_data_item_window): New.
6886         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6887         case.  Add assert.
6888         (~tui_data_item_window): New destructor.
6889         (free_content_elements): Remove DATA_ITEM_WIN case.
6890
6891 2019-06-25  Tom Tromey  <tom@tromey.com>
6892
6893         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6894         Remove.
6895
6896 2019-06-25  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-data.h (struct tui_command_element): Remove.
6899         (union tui_which_element) <command>: Remove.
6900         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6901         assert.
6902         (free_content_elements): Remove CMD_WIN case.
6903
6904 2019-06-25  Tom Tromey  <tom@tromey.com>
6905
6906         * tui/tui-layout.c (tui_set_layout): Update.
6907         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6908         * tui/tui-data.c (layout_def): Update.
6909
6910 2019-06-25  Tom Tromey  <tom@tromey.com>
6911
6912         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6913         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6914         (tui_source_window_base::set_new_height): Update.
6915         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6916         Update.
6917         (tui_set_locator_fullname, tui_set_locator_info)
6918         (tui_show_frame_info): Update.
6919         * tui/tui-source.c (tui_set_source_content)
6920         (tui_source_is_displayed): Update.
6921         * tui/tui-layout.c (show_source_disasm_command, show_data)
6922         (show_source_or_disasm_and_command): Update.
6923         * tui/tui-disasm.c (tui_set_disassem_content)
6924         (tui_get_begin_asm_address): Update.
6925         * tui/tui-data.h (struct tui_locator_element): Remove.
6926         (union tui_which_element) <locator>: Remove.
6927         (struct tui_locator_window): New.
6928         (tui_locator_win_info_ptr): Change return type.
6929         * tui/tui-data.c (_locator): Change type.
6930         (tui_locator_win_info_ptr): Change return type.
6931         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6932         (tui_alloc_content): Add assert.
6933
6934 2019-06-25  Tom Tromey  <tom@tromey.com>
6935
6936         * tui/tui-winsource.c
6937         (tui_exec_info_window::maybe_allocate_content): New method.
6938         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6939         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6940         (make_source_or_disasm_window): Add cast.
6941         * tui/tui-data.h (union tui_which_element) <simple_string>:
6942         Remove.
6943         (struct tui_source_info): New.
6944         (struct tui_source_window_base) <execution_info>: Change type.
6945         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6946         case, and add assert.
6947         (tui_alloc_content): Add assert.
6948
6949 2019-06-25  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6952         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6953         * tui/tui-data.c (tui_alloc_win_info): Remove.
6954
6955 2019-06-25  Tom Tromey  <tom@tromey.com>
6956
6957         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6958         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6959         can_highlight.
6960
6961 2019-06-25  Tom Tromey  <tom@tromey.com>
6962
6963         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6964         make_visible_with_new_height method.
6965         (tui_win_info::make_visible_with_new_height): New method.
6966         (tui_source_window_base::do_make_visible_with_new_height)
6967         (tui_data_window::do_make_visible_with_new_height)
6968         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6969         (make_visible_with_new_height): Remove.
6970         (tui_resize_all, tui_adjust_win_heights): Use
6971         make_visible_with_new_height method.
6972         * tui/tui-data.h (struct tui_win_info)
6973         <do_make_visible_with_new_height, make_visible_with_new_height>:
6974         New methods.
6975         (struct tui_source_window_base, struct tui_data_window)
6976         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6977         methods.
6978
6979 2019-06-25  Tom Tromey  <tom@tromey.com>
6980
6981         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6982         method.
6983         (update_tab_width): Call update_tab_width method.
6984         * tui/tui-data.h (struct tui_win_info)
6985         (struct tui_source_window_base) <update_tab_width>: New methods.
6986
6987 2019-06-25  Tom Tromey  <tom@tromey.com>
6988
6989         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6990         parameter.
6991         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6992         parameter.
6993         (tui_gen_win_info::make_visible): Update.
6994         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6995         parameter.
6996         * tui/tui-data.h (enum tui_box): New enum.
6997         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6998
6999 2019-06-25  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7002         init_and_make_win for EXEC_INFO_WIN.
7003         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7004         longer inline.
7005         (struct tui_win_info) <~tui_win_info>: Inline.
7006         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7007         Don't declare.
7008         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7009         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7010         Remove.
7011         (tui_initialize_static_data): Update.
7012         (~tui_gen_win_info): Handle more cleanup here.
7013         (~tui_source_window_base): Delete "execution_info".
7014         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7015
7016 2019-06-25  Tom Tromey  <tom@tromey.com>
7017
7018         * tui/tui-layout.c (make_command_window): Don't set
7019         can_highlight.
7020         (show_source_disasm_command): Call the reset method.
7021         (show_data): Don't set can_highlight.  Call the reset method.
7022         (tui_gen_win_info::reset): Rename from init_gen_win_info
7023         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7024         (show_source_or_disasm_and_command): Call the reset method.
7025         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7026         (struct tui_cmd_window): Set can_highlight.
7027
7028 2019-06-25  Tom Tromey  <tom@tromey.com>
7029
7030         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7031         from make_visible.
7032         (tui_make_visible, tui_make_invisible): Rewrite.
7033         (tui_win_info::make_visible): Remove.
7034         (tui_source_window_base::make_visible): Update.
7035         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7036         method.  Moved from...
7037         (struct tui_win_info) <make_visible>: ...here.
7038
7039 2019-06-25  Tom Tromey  <tom@tromey.com>
7040
7041         * tui/tui-winsource.c
7042         (tui_source_window_base::do_scroll_horizontal): Remove direction
7043         parameter.
7044         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7045         direction parameter.
7046         * tui/tui-win.c (tui_win_info::forward_scroll)
7047         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7048         (tui_win_info::right_scroll): Update.
7049         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7050         direction parameter.
7051         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7052         direction parameter.
7053         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7054         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7055         Remove direction parameter.
7056         (struct tui_source_window_base, struct tui_source_window)
7057         (struct tui_disasm_window, struct tui_data_window)
7058         (struct tui_cmd_window): Update.
7059
7060 2019-06-25  Tom Tromey  <tom@tromey.com>
7061
7062         * tui/tui-winsource.h (tui_set_exec_info_content)
7063         (tui_show_exec_info_content, tui_erase_exec_info_content)
7064         (tui_clear_exec_info_content, tui_update_exec_info): Change
7065         argument to tui_source_window_base.
7066         * tui/tui-winsource.c (tui_set_exec_info_content)
7067         (tui_show_exec_info_content, tui_erase_exec_info_content)
7068         (tui_clear_exec_info_content, tui_update_exec_info): Change
7069         argument to tui_source_window_base.
7070
7071 2019-06-25  Tom Tromey  <tom@tromey.com>
7072
7073         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7074         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7075
7076 2019-06-25  Tom Tromey  <tom@tromey.com>
7077
7078         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7079         check.
7080
7081 2019-06-25  Tom Tromey  <tom@tromey.com>
7082
7083         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7084         type to void.
7085         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7086         type to void.
7087         * tui/tui-source.c (tui_set_source_content): Update.
7088         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7089
7090 2019-06-25  Tom Tromey  <tom@tromey.com>
7091
7092         * tui/tui-win.c (window_name_completer, tui_set_focus)
7093         (tui_all_windows_info): Use name method.
7094         * tui/tui-data.h (struct tui_gen_win_info)
7095         (struct tui_source_window, struct tui_disasm_window)
7096         (struct tui_data_window, struct tui_cmd_window) <name>: New
7097         method.
7098         (tui_win_name): Don't declare.
7099         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7100         (tui_win_name): Remove.
7101
7102 2019-06-25  Tom Tromey  <tom@tromey.com>
7103
7104         * tui/tui-winsource.h (tui_update_source_window)
7105         (tui_update_source_window_as_is): Change parameter type.
7106         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7107         to be a tui_source_window_base.
7108         (tui_update_source_window_as_is): Likewise.
7109         * tui/tui-win.c (make_visible_with_new_height): Update.
7110
7111 2019-06-25  Tom Tromey  <tom@tromey.com>
7112
7113         * tui/tui-winsource.c (tui_erase_source_content)
7114         (tui_show_source_content, tui_show_exec_info_content)
7115         (tui_erase_exec_info_content): Use refresh_window method.
7116         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7117         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7118         from tui_refresh_win.
7119         (tui_data_window::refresh_window): New method.
7120         (tui_win_info::refresh, tui_source_window_base::refresh)
7121         (tui_refresh_all): Use refresh_window method.
7122         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7123         method.
7124         * tui/tui-regs.c (tui_display_register): Call refresh_window
7125         method.
7126         * tui/tui-layout.c (show_source_disasm_command)
7127         (show_source_or_disasm_and_command): Call refresh_window method.
7128         * tui/tui-data.h (struct tui_gen_win_info)
7129         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7130         New method.
7131
7132 2019-06-25  Tom Tromey  <tom@tromey.com>
7133
7134         * tui/tui.c (tui_rl_other_window, tui_enable)
7135         (tui_is_window_visible, tui_get_command_dimension): Update.
7136         * tui/tui-winsource.c (tui_update_source_window_as_is)
7137         (tui_clear_source_content, tui_erase_source_content)
7138         (tui_show_source_line, tui_source_window_base::refill)
7139         (tui_source_window_base::do_scroll_horizontal)
7140         (tui_source_window_base::set_is_exec_point_at)
7141         (tui_update_breakpoint_info, tui_set_exec_info_content)
7142         (tui_alloc_source_buffer, tui_line_is_displayed)
7143         (tui_addr_is_displayed): Update.
7144         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7145         (tui_check_and_display_highlight_if_needed)
7146         (tui_win_info::make_visible, tui_win_info::refresh)
7147         (tui_refresh_all): Update.
7148         * tui/tui-windata.c (tui_first_data_item_displayed)
7149         (tui_delete_data_content_windows, tui_erase_data_content)
7150         (tui_display_all_data, tui_data_window::refresh_all)
7151         (tui_check_data_values): Update.
7152         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7153         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7154         (tui_win_info::backward_scroll, tui_refresh_all_win)
7155         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7156         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7157         (tui_source_window_base::set_new_height)
7158         (tui_data_window::set_new_height)
7159         (make_invisible_and_set_new_height)
7160         (make_visible_with_new_height, new_height_ok)
7161         (parse_scrolling_args): Update.
7162         * tui/tui-stack.c (tui_show_frame_info): Update.
7163         * tui/tui-source.c (tui_set_source_content)
7164         (tui_set_source_content_nil, tui_source_is_displayed)
7165         (tui_source_window::do_scroll_vertical): Update.
7166         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7167         (tui_display_registers_from, tui_display_reg_element_at_line)
7168         (tui_check_register_values, tui_reg_command): Update.
7169         * tui/tui-layout.c (tui_default_win_height)
7170         (show_source_disasm_command, show_data, init_and_make_win)
7171         (show_source_or_disasm_and_command): Update.
7172         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7173         (tui_redisplay_readline, tui_mld_flush)
7174         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7175         (tui_getc): Update.
7176         * tui/tui-disasm.c (tui_set_disassem_content)
7177         (tui_disasm_window::do_scroll_vertical): Update.
7178         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7179         Now virtual.
7180         (struct tui_win_info): Derive from tui_gen_win_info.
7181         <~tui_win_info>: Mark as override.
7182         <generic>: Remove member.
7183         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7184         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7185         (~tui_data_window, ~tui_win_info)
7186         (tui_free_all_source_wins_content): Update.
7187         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7188
7189 2019-06-25  Tom Tromey  <tom@tromey.com>
7190
7191         * tui/tui-layout.c (init_and_make_win): Use new.
7192         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7193         destructor, initializers.
7194         (tui_alloc_generic_win_info): Don't declare.
7195         * tui/tui-data.c (_locator): Add argument to constructor.
7196         (source_win, disasm_win): New globals.
7197         (exec_info): Remove.
7198         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7199         Update.
7200         (tui_alloc_generic_win_info): Remove.
7201         (init_content_element): Use new.
7202         (tui_win_info::tui_win_info): Update.
7203         (free_content_elements) <case DATA_WIN>: Use delete.
7204
7205 2019-06-25  Tom Tromey  <tom@tromey.com>
7206
7207         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7208         * tui/tui-windata.c (tui_first_data_item_displayed)
7209         (tui_delete_data_content_windows): Update.
7210         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7211         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7212         (tui_display_registers_from, tui_check_register_values): Update.
7213         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7214         pointer.
7215         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7216         window.
7217         (tui_free_data_content): Update.
7218         (free_content_elements) <case DATA_WIN>: Free the window.
7219
7220 2019-06-25  Tom Tromey  <tom@tromey.com>
7221
7222         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7223         Update.
7224         * tui/tui-layout.c (make_command_window)
7225         (show_source_disasm_command, show_data, init_and_make_win)
7226         (show_source_or_disasm_and_command): Update.
7227         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7228         method.
7229         <can_highight, is_highlighted>: Now bool.
7230         (tui_set_win_highlight): Don't declare.
7231         * tui/tui-data.c (tui_set_win_highlight): Remove.
7232
7233 2019-06-25  Tom Tromey  <tom@tromey.com>
7234
7235         * tui/tui-wingeneral.c (make_visible): Remove check of window
7236         type.
7237
7238 2019-06-25  Tom Tromey  <tom@tromey.com>
7239
7240         * tui/tui-win.c (tui_win_info::max_height)
7241         (tui_cmd_window::max_height): New methods.
7242         (new_height_ok): Call max_height.
7243         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7244         <max_height>: New method.
7245
7246 2019-06-25  Tom Tromey  <tom@tromey.com>
7247
7248         * tui/tui-win.c (tui_source_window_base::set_new_height)
7249         (tui_data_window::set_new_height): New methods.
7250         (make_invisible_and_set_new_height): Call set_new_height method.
7251         * tui/tui-data.h (struct tui_win_info)
7252         (struct tui_source_window_base, struct tui_data_window)
7253         <set_new_height>: New method.
7254
7255 2019-06-25  Tom Tromey  <tom@tromey.com>
7256
7257         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7258         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7259         tui_refresh_data_win.
7260         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7261         method.
7262         (tui_refresh_all_win): Call the refresh_all method.
7263         (tui_set_focus): Likewise.
7264         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7265         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7266         Likewise.
7267
7268 2019-06-25  Tom Tromey  <tom@tromey.com>
7269
7270         * tui/tui-winsource.h (tui_refill_source_window)
7271         (tui_set_is_exec_point_at): Don't declare.
7272         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7273         (tui_source_window_base::refill): Rename from
7274         tui_refill_source_window.
7275         (tui_source_window_base::do_scroll_horizontal): Update.
7276         (tui_source_window_base::set_is_exec_point_at): Rename from
7277         tui_set_is_exec_point_at.
7278         (tui_update_all_breakpoint_info): Update.
7279         * tui/tui-stack.c (tui_show_frame_info): Update.
7280         * tui/tui-layout.c (show_data): Add cast.
7281         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7282         * tui/tui-data.h (struct tui_source_window_base) <refill,
7283         set_is_exec_point_at>: New methods.
7284         (tui_source_windows, tui_add_to_source_windows): Update types.
7285         (tui_add_to_source_windows): Remove redundant declaration.
7286         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7287         (tui_source_windows): Change return type.
7288         (tui_clear_source_windows_detail): Update.
7289         (tui_add_to_source_windows): Change type of parameter.
7290         (tui_free_all_source_wins_content): Update.
7291
7292 2019-06-25  Tom Tromey  <tom@tromey.com>
7293
7294         * tui/tui-wingeneral.c (tui_win_info::refresh)
7295         (tui_source_window_base::refresh): New methods.
7296         (tui_refresh_all): Call the refresh method.
7297         * tui/tui-data.h (struct tui_win_info)
7298         (struct tui_source_window_base) <refresh>: New method.
7299
7300 2019-06-25  Tom Tromey  <tom@tromey.com>
7301
7302         * tui/tui.h (tui_is_window_visible): Return bool.
7303         * tui/tui.c (tui_is_window_visible): Return bool.
7304         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7305         (tui_make_visible, tui_make_invisible)
7306         (tui_win_info::make_visible)
7307         (tui_source_window_base::make_visible, make_all_visible)
7308         (tui_make_all_visible, tui_make_all_invisible): Update.
7309         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7310         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7311         bool.
7312         (struct tui_win_info, struct tui_source_window_base)
7313         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7314         * tui/tui-data.c (tui_init_generic_part): Update.
7315
7316 2019-06-25  Tom Tromey  <tom@tromey.com>
7317
7318         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7319         (tui_source_window_base::make_visible): New methods.
7320         (make_all_visible): Make method call.
7321         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7322         (struct tui_source_window_base, struct tui_cmd_window): Override
7323         make_visible.
7324         (tui_win_is_source_type): Don't declare.
7325         * tui/tui-data.c (tui_win_is_source_type): Remove.
7326
7327 2019-06-25  Tom Tromey  <tom@tromey.com>
7328
7329         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7330         NULL check.
7331
7332 2019-06-25  Tom Tromey  <tom@tromey.com>
7333
7334         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7335         Inline constructor.  Add initializers for members.
7336         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7337         constructors; now inline in class.
7338
7339 2019-06-25  Tom Tromey  <tom@tromey.com>
7340
7341         * tui/tui-regs.c (tui_show_registers): Update.
7342         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7343         bool.
7344         * tui/tui-data.c (tui_data_window::clear_detail)
7345         (tui_data_window): Update.
7346
7347 2019-06-25  Tom Tromey  <tom@tromey.com>
7348
7349         * tui/tui-windata.c (tui_display_all_data)
7350         (tui_display_data_from_line, tui_display_data_from)
7351         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7352         Update.
7353         * tui/tui-regs.c (tui_last_regs_line_no)
7354         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7355         (tui_show_registers, tui_show_register_group)
7356         (tui_display_registers_from, tui_display_reg_element_at_line)
7357         (tui_display_registers_from_line, tui_check_register_values)
7358         (tui_reg_next, tui_reg_prev): Update.
7359         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7360         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7361         tui_data_window.
7362         (struct tui_win_info) <detail>: Remove.  Add new fields from
7363         tui_data_info.
7364         (TUI_DATA_WIN): Add cast.
7365         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7366         (~tui_data_window): Simplify.
7367
7368 2019-06-25  Tom Tromey  <tom@tromey.com>
7369
7370         * tui/tui-layout.c (show_source_disasm_command)
7371         (show_source_or_disasm_and_command): Update.
7372         * tui/tui-io.c (update_cmdwin_start_line)
7373         (tui_redisplay_readline): Update.
7374         * tui/tui-data.h (struct tui_command_info): Remove.
7375         (struct tui_win_info) <detail>: Remove command_info member.
7376         (struct tui_data_window) <start_line>: New member, from
7377         tui_command_info.
7378         (TUI_CMD_WIN): Add casts.
7379
7380 2019-06-25  Tom Tromey  <tom@tromey.com>
7381
7382         * tui/tui-winsource.c (tui_update_source_window)
7383         (tui_refill_source_window)
7384         (tui_source_window_base::do_scroll_horizontal)
7385         (tui_update_breakpoint_info, tui_set_exec_info_content)
7386         (tui_show_exec_info_content, tui_erase_exec_info_content)
7387         (tui_clear_exec_info_content): Update.
7388         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7389         Update.
7390         * tui/tui-win.c (make_invisible_and_set_new_height)
7391         (make_visible_with_new_height): Update.
7392         * tui/tui-source.c (tui_set_source_content)
7393         (tui_show_symtab_source): Update.
7394         * tui/tui-layout.c (extract_display_start_addr)
7395         (show_source_disasm_command, show_data)
7396         (make_source_or_disasm_window)
7397         (show_source_or_disasm_and_command): Update.
7398         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7399         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7400         "gdbarch".
7401         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7402         to tui_source_window_base.
7403         (struct tui_win_info) <detail>: Remove source_info member.
7404         (struct tui_source_window_base) <has_locator>: Inline.
7405         Move contents from tui_source_info; rename has_locator member to
7406         m_has_locator.
7407         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7408         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7409         header file.
7410         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7411         Simplify.
7412         (tui_free_all_source_wins_content): Cast to
7413         tui_source_window_base.
7414
7415 2019-06-25  Tom Tromey  <tom@tromey.com>
7416
7417         * tui/tui-win.c (make_invisible_and_set_new_height)
7418         (make_visible_with_new_height): Call has_locator method.
7419         * tui/tui-layout.c (show_source_disasm_command, show_data)
7420         (show_source_or_disasm_and_command): Update for bool change.
7421         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7422         (tui_win_info) <has_locator>: New method.
7423         (struct tui_source_window_base) <has_locator>: New method.
7424         (tui_win_has_locator): Don't declare.
7425         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7426         from tui_win_has_locator.
7427         (tui_source_window_base): Use false, not FALSE.
7428
7429 2019-06-25  Tom Tromey  <tom@tromey.com>
7430
7431         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7432         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7433         clear_detail method directly.
7434         (tui_clear_win_detail): Remove.
7435
7436 2019-06-25  Tom Tromey  <tom@tromey.com>
7437
7438         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7439         "this", not TUI_DISASM_WIN.
7440
7441 2019-06-25  Tom Tromey  <tom@tromey.com>
7442
7443         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7444         declare.
7445         * tui/tui-winsource.c
7446         (tui_source_window_base::do_scroll_horizontal): Rename from
7447         tui_horizontal_source_scroll.
7448         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7449         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7450         from tui_vertical_data_scroll.
7451         * tui/tui-win.h (tui_scroll): Don't declare.
7452         * tui/tui-win.c (tui_win_info::forward_scroll)
7453         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7454         (tui_win_info::right_scroll): Rename and update.
7455         (tui_scroll_forward_command, tui_scroll_backward_command)
7456         (tui_scroll_left_command, tui_scroll_right_command): Update.
7457         (tui_scroll): Remove.
7458         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7459         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7460         from tui_vertical_source_scroll.
7461         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7462         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7463         from tui_vertical_disassem_scroll.
7464         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7465         do_scroll_horizontal>: New methods.
7466         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7467         Likewise.
7468         (struct tui_source_window_base): Add do_scroll_horizontal.
7469         (struct tui_source_window, struct tui_disasm_window): Add
7470         do_scroll_vertical.
7471         (struct tui_data_window, struct tui_cmd_window): Add
7472         do_scroll_horizontal and do_scroll_vertical.
7473         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7474
7475 2019-06-25  Tom Tromey  <tom@tromey.com>
7476
7477         * tui/tui-data.h (struct tui_source_window_base): New struct.
7478         (struct tui_source_window): Derive from tui_source_window_base.
7479         (struct tui_disasm_window): New struct.
7480         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7481         from tui_source_window::clear_detail.
7482         (tui_source_window_base): Rename from tui_source_window.
7483         (~tui_source_window_base): Rename from ~tui_source_window.
7484         (tui_alloc_win_info): Create a tui_disasm_window.
7485
7486 2019-06-25  Tom Tromey  <tom@tromey.com>
7487
7488         * tui/tui-data.h (struct tui_source_window)
7489         (struct tui_data_window): Declare destructors.
7490         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7491         destructors.
7492         (tui_win_info): Simplify.
7493
7494 2019-06-25  Tom Tromey  <tom@tromey.com>
7495
7496         * tui/tui-winsource.c (tui_display_main)
7497         (tui_update_source_windows_with_addr)
7498         (tui_update_all_breakpoint_info): Update.
7499         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7500         (new_height_ok, parse_scrolling_args): Update.
7501         * tui/tui-stack.c (tui_show_frame_info): Update.
7502         * tui/tui-data.h (struct tui_list): Remove.
7503         (tui_source_windows): Return a reference to a std::vector.
7504         * tui/tui-data.c (source_windows): Now a std::vector.
7505         (tui_source_windows): Change return type.
7506         (tui_clear_source_windows): Rewrite.
7507         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7508         (tui_free_all_source_wins_content): Rewrite.
7509
7510 2019-06-25  Tom Tromey  <tom@tromey.com>
7511
7512         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7513         (struct tui_data_window, struct tui_cmd_window): Declare
7514         clear_detail method.
7515         * tui/tui-data.c (tui_source_window::clear_detail)
7516         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7517         methods.
7518         (tui_clear_win_detail): Simplify.
7519
7520 2019-06-25  Tom Tromey  <tom@tromey.com>
7521
7522         * tui/tui-layout.c (make_source_window, make_disasm_window)
7523         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7524         Return the new window.
7525         (show_source_disasm_command, show_data)
7526         (show_source_or_disasm_and_command): Update.
7527
7528 2019-06-25  Tom Tromey  <tom@tromey.com>
7529
7530         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7531         parameter.  Return the new window.
7532         (show_source_disasm_command): Update and remove NULL check.
7533         (show_source_or_disasm_and_command): Update.
7534
7535 2019-06-25  Tom Tromey  <tom@tromey.com>
7536
7537         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7538
7539 2019-06-25  Tom Tromey  <tom@tromey.com>
7540
7541         * tui/tui-data.h (struct tui_win_info): Make constructor
7542         protected.  Make destructor virtual.  Add initializers.
7543         (tui_source_window, tui_data_window, tui_cmd_window): New
7544         classes.
7545         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7546         constructor.  Add "type" parameter.
7547         (tui_source_window, tui_data_window, tui_cmd_window): New
7548         constructors.
7549         (tui_alloc_win_info): Instantiate the appropriate subclass.
7550
7551 2019-06-25  Tom Tromey  <tom@tromey.com>
7552
7553         * tui/tui-win.c (tui_resize_all): Use delete.
7554         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7555         destructor.
7556         (tui_free_window): Don't declare.
7557         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7558         Update.
7559
7560 2019-06-25  Tom Tromey  <tom@tromey.com>
7561
7562         * tui/tui-data.h (struct tui_win_info): Add constructor.
7563         * tui/tui-data.c (tui_alloc_win_info): Use new.
7564         (tui_free_window): Use delete.
7565
7566 2019-06-22  Tom Tromey  <tom@tromey.com>
7567
7568         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7569         declare.
7570         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7571
7572 2019-06-22  Tom Tromey  <tom@tromey.com>
7573
7574         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7575         declare.
7576         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7577
7578 2019-06-22  Tom de Vries  <tdevries@suse.de>
7579
7580         * dwarf2read.c (create_addrmap_from_aranges)
7581         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7582         instead of '%zu'.
7583
7584 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7585
7586         * dwarf2read.h (dwarf2_section_info_def): Remove.
7587         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7588         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7589         std::vector<dwarf2_section_info>.
7590         (struct dwo_file) <~dwo_file>: Remove.
7591         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7592         types field.
7593         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7594         (dwarf2_read_debug_names): Likewise.
7595         (create_debug_types_hash_table): Change parameter type to
7596         array_view, adjust code accordingly.
7597         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7598         (partial_die_info::fixup): Likewise.
7599         (determine_prefix): Likewise.
7600         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7601
7602 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7603
7604         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7605         gdb_bfd_ref_ptr.
7606         <~dwo_file>: Remove call to gdb_bfd_unref.
7607         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7608         gdb_bfd_ref_ptr::get.
7609
7610 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7611
7612         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7613         type to htab_up.
7614         * dwarf2read.c (struct dwo_file): Initialize fields.
7615         <~dwo_file>: New.
7616         (free_dwo_file): Remove, move content to ~dwo_file.
7617         (struct dwo_file_deleter): Remove.
7618         (dwo_file_up>: Remove custom deleter.
7619         (free_dwo_files): Remove.
7620         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7621         dwo_files.
7622         (process_skeletonless_type_units): Call unique_ptr::get.
7623         (allocate_dwo_file_hash_table): Add deleter to created hash
7624         table.  Change return type to htab_up.
7625         (lookup_dwo_file_slot): Don't memset dwo_file, call
7626         unique_ptr::get.
7627         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7628         (create_dwo_unit_in_dwp_v2): Likewise.
7629         (open_and_init_dwo_file): Likewise.
7630         (free_dwo_file_from_slot): Remove.
7631
7632 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7633
7634         * dwarf2read.h (struct dwarf2_section_info) <readin,
7635         is_virtual>: Change type to bool.
7636         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7637         true instead of 1.
7638
7639 2019-06-19  Tom Tromey  <tom@tromey.com>
7640
7641         * tui/tui-data.h (tui_init_content_element): Don't declare.
7642
7643 2019-06-19  Tom Tromey  <tom@tromey.com>
7644
7645         * tui/tui-data.h (tui_init_win_info): Don't declare.
7646
7647 2019-06-19  Tom de Vries  <tdevries@suse.de>
7648
7649         * dwarf2read.h (abstract_to_concrete): Change type to
7650         std::unordered_map<sect_offset, std::vector<sect_offset>,
7651         gdb::hash_enum<sect_offset>>.
7652
7653 2019-06-19  Tom Tromey  <tromey@adacore.com>
7654
7655         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7656         EVAL_AVOID_SIDE_EFFECTS specially.
7657
7658 2019-06-19  Tom Tromey  <tromey@adacore.com>
7659
7660         * source-cache.c (highlighter): New global.
7661         (source_cache::get_source_lines): Create a highlighter on demand.
7662
7663 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7664
7665         * defs.h (deprecated_interactive_hook): Delete declaration.
7666         * interps.c (clear_interpreter_hooks): Remove use of
7667         deprecated_interactive_hook.
7668         * top.c (deprecated_interactive_hook): Delete definition.
7669         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7670
7671 2019-06-18  Tom de Vries  <tdevries@suse.de>
7672
7673         PR gdb/24515
7674         * dwarf2read.h (abstract_to_concrete): Change type from
7675         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7676         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7677         * dwarf2read.c (read_variable): Update.
7678         (dwarf2_fetch_die_loc_sect_off): Update.
7679
7680 2019-06-17  Tom de Vries  <tdevries@suse.de>
7681
7682         PR gdb/24617
7683         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7684         accessing parent[parent_len - 1].
7685
7686 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7687
7688         PR gdb/24364
7689         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7690         call dtrace_process_dof with NULL dof.
7691
7692 2019-06-16  Tom de Vries  <tdevries@suse.de>
7693
7694         PR gdb/24445
7695         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7696
7697 2019-06-16  Tom Tromey  <tom@tromey.com>
7698
7699         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7700         (make_all_visible): Use address of member.
7701
7702 2019-06-16  Tom Tromey  <tom@tromey.com>
7703
7704         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7705         (tui_free_window, free_content, free_content_elements): Remove
7706         unnecessary cast.
7707         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7708         cast.
7709         * tui/tui-regs.c (tui_show_register_group)
7710         (tui_display_registers_from, tui_display_reg_element_at_line):
7711         Remove unnecessary cast.
7712
7713 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * linux-nat.c (normal_mask): Delete.
7716         (_initialize_linux_nat): Don't initialise normal_mask.
7717
7718 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7719
7720         PR gdb/24445
7721         * dwarf-index-write.h (write_psymtabs_to_index): Add
7722         dwz_basename parameter.
7723         * dwarf-index-write.c (write_gdbindex): Move file writing to
7724         write_gdbindex_1.  Change return type void.
7725         (assert_file_size): Move up, remove filename parameter.
7726         (write_gdbindex_1): New function.
7727         (write_debug_names): Change return type to void, call
7728         assert_file_size.
7729         (struct index_wip_file): New struct.
7730         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7731         file logic to index_wip_file.  Write index for dwz file if
7732         needed.
7733         (save_gdb_index_command): Pass basename of dwz file, if present.
7734         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7735         build-id of dwz file, if present.
7736         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7737         (dwarf2_get_dwz_file): Likewise.
7738         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7739         (dwarf2_get_dwz_file): Likewise.
7740
7741 2019-06-16  Tom Tromey  <tom@tromey.com>
7742
7743         * coffread.c (process_coff_symbol): Use xstrdup.
7744         * value.c (create_internalvar): Use xstrdup.
7745
7746 2019-06-16  Tom Tromey  <tom@tromey.com>
7747
7748         * valops.c (value_cast, value_slice): Remove unnecessary cast.
7749         * breakpoint.c (stopin_command, stopat_command)
7750         (until_break_command, decode_location_default): Remove unnecessary
7751         cast.
7752         * utils.c (subset_compare): Remove unnecessary cast.
7753         * ada-lang.c (ada_update_initial_language): Remove unnecessary
7754         cast.
7755         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7756         cast.
7757         * infcmd.c (path_command): Remove unnecessary cast.
7758         * coffread.c (decode_type): Remove unnecessary cast.
7759         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7760         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7761         * tui/tui-stack.c (tui_show_locator_content)
7762         (tui_show_frame_info): Remove unnecessary cast.
7763         * tui/tui-win.c (tui_scroll_forward_command)
7764         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7765         (parse_scrolling_args): Remove unnecessary cast.
7766         * tui/tui-data.c (init_win_info, tui_del_window)
7767         (tui_free_window, tui_del_data_windows, tui_free_data_content)
7768         (free_content_elements): Remove unnecessary cast.
7769         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7770         unnecessary cast.
7771         * tui/tui-source.c (tui_set_source_content)
7772         (tui_vertical_source_scroll): Remove unnecessary cast.
7773         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7774         cast.
7775         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7776         * tui/tui-regs.c (tui_display_registers_from)
7777         (tui_display_register): Remove unnecessary cast.
7778         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7779         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7780         (make_visible): Remove unnecessary cast.
7781         * tui/tui-winsource.c (tui_erase_source_content)
7782         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7783         unnecessary cast.
7784         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7785         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7786         * stabsread.c (read_type, read_array_type, read_range_type):
7787         Remove unnecessary cast.
7788         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7789         (parse_symbol, parse_type, upgrade_type, parse_external)
7790         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7791         unnecessary cast.
7792         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7793
7794 2019-06-16  Tom Tromey  <tom@tromey.com>
7795
7796         * tui/tui-data.c (tui_alloc_generic_win_info)
7797         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7798         checks.
7799
7800 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
7801             Andrew Burgess  <andrew.burgess@embecosm.com>
7802
7803         * f-typeprint.c (f_print_type): Don't return early for not
7804         associated or not allocated types.
7805         (f_type_print_varspec_suffix): Add print_rank parameter and print
7806         ranks of array types in case they dangling.
7807         (f_type_print_base): Add print_rank parameter.
7808
7809 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * NEWS: Mention new MI commands.
7812         * break-catch-throw.c (enum exception_event_kind): Move to
7813         breakpoint.h.
7814         (print_mention_exception_catchpoint): Output text as a single
7815         message.
7816         (catch_exception_command_1): Rename to...
7817         (catch_exception_event): ...this, make non-static, update header
7818         command, and change some parameter types.
7819         (catch_catch_command): Update for changes to
7820         catch_exception_command_1.
7821         (catch_throw_command): Likewise.
7822         (catch_rethrow_command): Likewise.
7823         * breakpoint.c (enum exception_event_kind): Delete.
7824         * breakpoint.h (enum exception_event_kind): Moved here from
7825         break-catch-throw.c.
7826         (catch_exception_event): Declare.
7827         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7828         (mi_cmd_catch_throw): New function.
7829         (mi_cmd_catch_rethrow): New function.
7830         (mi_cmd_catch_catch): New function.
7831         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7832         'catch-catch' entries.
7833         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7834         (mi_cmd_catch_rethrow): Declare.
7835         (mi_cmd_catch_catch): Declare.
7836
7837 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * annotate.c (annotate_source_line): Change return type to void,
7840         update implementation to match.
7841         * annotate.h (annotate_source_line): Change return type to void,
7842         update header comment.
7843         * stack.c (print_frame_info): Don't change what frame information
7844         is printed based on whether annotations are on or not.
7845
7846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7849         (annotate_source): Make static.
7850         (annotate_source_line): Moved from source.c and renamed from
7851         identify_source_line.  Update the return type.
7852         * annotate.h (annotate_source): Delete declaration.
7853         (annotate_source_line): Declaration moved from source.h, and
7854         renamed from identify_source_line.  Return type updated.
7855         * source.c (identify_source_line): Moved to annotate.c and renamed
7856         to annotate_source_line.
7857         (info_line_command): Remove check of annotation_level.
7858         * source.h (identify_source_line): Move declaration to annotate.h
7859         and rename to annotate_source_line.
7860         * stack.c: Add 'annotate.h' include.
7861         (print_frame_info): Remove check of annotation_level before
7862         calling annotate_source_line.
7863
7864 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7865
7866         * source-cache.c (source_cache::get_plain_source_lines): Use
7867         open_source_file_with_line_charpos instead of just
7868         open_source_file, remove call to find_source_lines.
7869         (source_cache::get_source_lines): Likewise.
7870         * source.c (find_source_lines): Make static.
7871         (get_filename_and_charpos): Renamed into...
7872         (open_source_file_with_line_charpos): ..this along with changes to
7873         return a scoped_fd, and some other minor clean ups.
7874         (identify_source_line): Use open_source_file_with_line_charpos.
7875         (search_command_helper): Use open_source_file_with_line_charpos
7876         instead of just open_source_file, remove call to
7877         find_source_lines.
7878         * source.h (open_source_file_with_line_charpos): Declare new
7879         function.
7880         (find_source_lines): Delete declaration.
7881
7882 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * source.c (get_filename_and_charpos): Remove fullname
7885         parameter.
7886         (identify_source_line): Update call to get_filename_and_charpos.
7887
7888 2019-06-14  Tom Tromey  <tromey@adacore.com>
7889
7890         PR gdb/24502:
7891         * ui-style.h (skip_ansi_escape): Update comment.
7892         * ui-file.h (class no_terminal_escape_file): New class.
7893         * ui-file.c (no_terminal_escape_file::write)
7894         (no_terminal_escape_file::puts): New methods.
7895         * cli/cli-logging.c (handle_redirections): Use
7896         no_terminal_escape_file.
7897
7898 2019-06-14  Tom Tromey  <tromey@adacore.com>
7899
7900         * NEWS: Move convenience variable news above Python news.
7901
7902 2019-06-14  Tom Tromey  <tom@tromey.com>
7903
7904         * gnulib: Move directory to top-level.
7905         * configure.ac: Don't configure gnulib.
7906         * configure: Rebuild.
7907         * common/common-defs.h: Use new path to gnulib.
7908         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7909         (GNULIB_H): Remove.
7910         (INCGNU): Look in new gnulib location.
7911         (HFILES_NO_SRCDIR): Remove gnulib files.
7912         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7913         (generated_files): Remove GNULIB_H.
7914         ($(LIBGNU), all-lib): Remove targets.
7915         (distclean): Don't mention GNULIB_BUILDDIR.
7916         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7917
7918 2019-06-14  Tom Tromey  <tromey@adacore.com>
7919
7920         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7921         Warn if symbol file does not provide any symbols.
7922
7923 2019-06-14  Tom Tromey  <tromey@adacore.com>
7924
7925         * source.c (find_and_open_source): Respect basenames_may_differ.
7926
7927 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * annotate.c (annotate_breakpoints_invalid): Make use of
7930         scoped_restore_terminal_state.
7931         (annotate_frames_invalid): Likewise.
7932
7933 2019-06-14  Tom Tromey  <tromey@adacore.com>
7934
7935         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7936         allow assignment to an internalvar.
7937
7938 2019-06-14  Tom Tromey  <tromey@adacore.com>
7939
7940         * ada-lex.l: Allow "_" in attribute names.
7941
7942 2019-06-14  Tom Tromey  <tromey@adacore.com>
7943
7944         PR gdb/24653:
7945         * regcache.c (registers_changed): Don't call alloca.
7946         * top.c (execute_command): Don't call alloca.
7947
7948 2019-06-13  Pedro Alves  <palves@redhat.com>
7949
7950         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7951         'expression'.  When parsing an expression, error out if there's
7952         junk after "unlimited".
7953         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7954         (do_set_command): Adjust calls to is_unlimited_literal.
7955
7956 2019-06-13  Pedro Alves  <palves@redhat.com>
7957
7958         * compile/compile.c (make_compile_options_def_group): Add braces
7959         around array_view initializer.
7960         * thread.c (make_thread_apply_all_options_def_group)
7961         (make_thread_apply_all_options_def_group): Likewise.
7962
7963 2019-06-13  Pedro Alves  <palves@redhat.com>
7964
7965         * NEWS (New commands): Mention "maint test-options
7966         require-delimiter", "maint test-options unknown-is-error", "maint
7967         test-options unknown-is-operand" and "maint show
7968         test-options-completion-result".
7969         (New command options, command completion): New section.
7970         (Completion improvements): New section.
7971         Mention that you can abbreviate "unlimited".
7972
7973 2019-06-13  Pedro Alves  <palves@redhat.com>
7974
7975         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7976         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7977         * unittests/cli-utils-selftests.c (test_parse_flags)
7978         (test_parse_flags_qcs): Delete.
7979         (test_cli_utils): Don't call deleted functions.
7980
7981 2019-06-13  Pedro Alves  <palves@redhat.com>
7982
7983         * thread.c: Include "cli/cli-option.h".
7984         (tp_array_compar_ascending): Global.
7985         (tp_array_compar): Delete function.
7986         (tp_array_compar_ascending, tp_array_compar_descending): New
7987         functions.
7988         (ascending_option_def, qcs_flag_option_def)
7989         (thr_qcs_flags_option_defs)
7990         (make_thread_apply_all_options_def_group)
7991         (make_thread_apply_options_def_group): New.
7992         (thread_apply_all_command): Use gdb::option::process_options.
7993         (thread_apply_command_completer)
7994         (thread_apply_all_command_completer): New.
7995         (thread_apply_command): Use gdb::option::process_options.
7996         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7997         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7998         to generate help text of "thread apply".  Adjust "taas"'s help.
7999         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8000         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8001
8002 2019-06-13  Pedro Alves  <palves@redhat.com>
8003
8004         * thread.c (thread_apply_command): Check for invalid TID with
8005         isdigit instead of !isalpha.
8006
8007 2019-06-13  Pedro Alves  <palves@redhat.com>
8008
8009         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8010         (validate_flags_qcs): New.
8011         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8012         (validate_flags_qcs): Declare.
8013         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8014         (make_frame_apply_options_def_group): New.
8015         (frame_apply_command_count): Process options with
8016         gdb::option::process_options.
8017         (frame_apply_completer): New.
8018         (frame_apply_level_completer, frame_apply_all_completer)
8019         (frame_apply_completer): New.
8020         (_initialize_stack): Update help of "frame apply", "frame apply
8021         level", "frame apply all" and "faas" to mention supported options
8022         and install command completers.
8023         * stack.h (frame_apply_all_completer): Declare.
8024         * thread.c: Include "stack.h".
8025         (tfaas_command): Add "--".
8026         (_initialize_thread): Update help "tfaas" to mention supported
8027         options and install command completer.
8028
8029 2019-06-13  Pedro Alves  <palves@redhat.com>
8030
8031         * completer.c (complete_nested_command_line): New.
8032         (gdb_completion_word_break_characters_throw): Add assertion.
8033         * completer.h (complete_nested_command_line): Declare.
8034
8035 2019-06-13  Pedro Alves  <palves@redhat.com>
8036
8037         * stack.c (parse_backtrace_qualifiers): New.
8038         (backtrace_command): Use it.
8039         (backtrace_command_completer): Complete on qualifiers.
8040
8041 2019-06-13  Pedro Alves  <palves@redhat.com>
8042
8043         * frame.c: Include "cli/cli-option.h.
8044         (user_set_backtrace_options): New.
8045         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8046         Delete.
8047         (get_prev_frame): Adjust.
8048         (boolean_option_def, uinteger_option_def)
8049         (set_backtrace_option_defs): New.
8050         (_initialize_frame): Adjust and use
8051         gdb::option::add_setshow_cmds_for_options to install "set
8052         backtrace past-main" and "set backtrace past-entry".
8053         * frame.h: Include "cli/cli-option.h".
8054         (struct frame_print_options): Forward declare.
8055         (print_frame_arguments_all, print_frame_arguments_scalars)
8056         (print_frame_arguments_none): Declare.
8057         (print_entry_values): Delete declaration.
8058         (struct frame_print_options, user_frame_print_options): New.
8059         (struct set_backtrace_options): New.
8060         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8061         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8062         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8063         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8064         (list_args_or_locals): Add frame_print_options parameter.
8065         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8066         * python/py-framefilter.c (enumerate_args): Pass down
8067         USER_FRAME_PRINT_OPTIONS.
8068         * stack.c: Include "cli/cli-option.h".
8069         (print_frame_arguments_all, print_frame_arguments_scalars)
8070         (print_frame_arguments_none): Declare.
8071         (print_raw_frame_arguments, print_entry_values): Delete.
8072         (user_frame_print_options): New.
8073         (boolean_option_def, enum_option_def, frame_print_option_defs):
8074         New.
8075         (struct backtrace_cmd_options): New.
8076         (bt_flag_option_def): New.
8077         (backtrace_command_option_defs): New.
8078         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8079         (print_frame_arg, read_frame_arg, print_frame_args)
8080         (print_frame_info, print_frame): Add frame_print_options parameter
8081         and use it.
8082         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8083         (backtrace_command_1): Add frame_print_options and
8084         backtrace_cmd_options parameters and use them.
8085         (make_backtrace_options_def_group): New.
8086         (backtrace_command): Process command options with
8087         gdb::option::process_options.
8088         (backtrace_command_completer): New.
8089         (_initialize_stack): Extend "backtrace"'s help to mention
8090         supported options.  Install completer for "backtrace".
8091         Install some settings commands with add_setshow_cmds_for_options.
8092
8093 2019-06-13  Pedro Alves  <palves@redhat.com>
8094
8095         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8096         and that "set/show print raw frame-arguments" are now deprecated.
8097
8098         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8099         command.
8100         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8101         * stack.c (_initialize_stack): Install "set/show print
8102         raw-frame-arguments", and deprecate "set/show print raw
8103         frame-arguments".
8104         * valprint.c (_initialize_valprint): Deprecate "set/show print
8105         raw".
8106
8107 2019-06-13  Pedro Alves  <palves@redhat.com>
8108
8109         * compile/compile.c (struct compile_options): New.
8110         (compile_flag_option_def, compile_command_option_defs)
8111         (make_compile_options_def_group): New.
8112         (compile_file_command): Handle options with
8113         gdb::option::process_options.
8114         (compile_file_command_completer): New function.
8115         (compile_code_command): Handle options with
8116         gdb::option::process_options.
8117         (compile_code_command_completer): New function.
8118         (_initialize_compiler): Install completers for "compile code" and
8119         "compile file".  Mention available options in "compile code" and
8120         "compile code"'s help.
8121         * completer.c (advance_to_completion_word): New, factored out from
8122         ...
8123         (advance_to_expression_complete_word_point): ... this.
8124         (advance_to_filename_complete_word_point): New.
8125         * completer.h (advance_to_filename_complete_word_point): New
8126         declaration.
8127
8128 2019-06-13  Pedro Alves  <palves@redhat.com>
8129
8130         * compile/compile.c: Include "cli/cli-option.h".
8131         (compile_print_value): Scope data pointer is now a
8132         value_print_options pointer; adjust.
8133         (compile_print_command): Process options.  Scope data pointer is
8134         now a value_print_options pointer; adjust.
8135         (_initialize_compile): Update "compile print"'s help to include
8136         supported options.  Install a completer for "compile print".
8137         * cp-valprint.c (show_vtblprint, show_objectprint)
8138         (show_static_field_print): Delete.
8139         (_initialize_cp_valprint): Don't install "set print
8140         static-members", "set print vtbl", "set print object" here.
8141         * printcmd.c: Include "cli/cli-option.h" and
8142         "common/gdb_optional.h".
8143         (print_command_parse_format): Rework to fill in a
8144         value_print_options instead of a format_data.
8145         (print_value): Change parameter type from format_data pointer to
8146         value_print_options reference.  Adjust.
8147         (print_command_1): Process options.  Adjust to pass down a
8148         value_print_options.
8149         (print_command_completer): New.
8150         (_initialize_printcmd): Install print_command_completer as
8151         handle_brkchars completer for the "print" command.  Update
8152         "print"'s help to include supported options.
8153         * valprint.c: Include "cli/cli-option.h".
8154         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8155         here from cp-valprint.c.
8156         (boolean_option_def, uinteger_option_def)
8157         (value_print_option_defs, make_value_print_options_def_group):
8158         New.  Use gdb::option::add_setshow_cmds_for_options to install
8159         "set print elements", "set print null-stop", "set print repeats",
8160         "set print pretty", "set print union", "set print array", "set
8161         print address", "set print symbol", "set print array-indexes".
8162         * valprint.h: Include <string> and "cli/cli-option.h".
8163         (make_value_print_options_def_group): Declare.
8164         (print_value): Change parameter type from format_data pointer to
8165         value_print_options reference.
8166         (print_command_completer): Declare.
8167
8168 2019-06-13  Pedro Alves  <palves@redhat.com>
8169
8170         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8171         (COMMON_SFILES): Add maint-test-settings.c.
8172         * cli/cli-decode.c (boolean_enums): New global, factored out from
8173         ...
8174         (add_setshow_boolean_cmd): ... here.
8175         * cli/cli-decode.h (boolean_enums): Declare.
8176         * cli/cli-option.c: New file.
8177         * cli/cli-option.h: New file.
8178         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8179         factored out from ...
8180         (parse_cli_boolean_value(const char *)): ... this.
8181         (is_unlimited_literal): Change parameter type to pointer to
8182         pointer.  Adjust and advance ARG pointer.
8183         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8184         (parse_cli_var_enum): New, factored out from ...
8185         (do_set_command): ... this.  Adjust.
8186         * cli/cli-setshow.h (parse_cli_boolean_value)
8187         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8188         (parse_cli_var_enum): Declare.
8189         * cli/cli-utils.c: Include "cli/cli-option.h".
8190         (get_ulongest): New.
8191         * cli/cli-utils.h (get_ulongest): Declare.
8192         (check_for_argument): New overloads.
8193         * maint-test-options.c: New file.
8194
8195 2019-06-13  Pedro Alves  <palves@redhat.com>
8196
8197         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8198         parse a range if "-" is at the end of the string.
8199
8200 2019-06-13  Pedro Alves  <palves@redhat.com>
8201
8202         * cli/cli-setshow.c (parse_auto_binary_operation)
8203         (parse_cli_boolean_value): Don't allow "o".
8204
8205 2019-06-13  Pedro Alves  <palves@redhat.com>
8206
8207         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8208         * NEWS: Mention maint test-settings KIND.
8209         * maint-test-settings.c: New file.
8210
8211 2019-06-13  Pedro Alves  <palves@redhat.com>
8212
8213         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8214         completer.
8215         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8216         "set" completers.
8217
8218 2019-06-13  Pedro Alves  <palves@redhat.com>
8219
8220         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8221         after item.
8222
8223 2019-06-13  Pedro Alves  <palves@redhat.com>
8224
8225         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8226
8227 2019-06-13  Pedro Alves <palves@redhat.com>
8228
8229         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8230         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8231         call.
8232         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8233         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8234         calls.
8235         (check_for_argument): Skip spaces after argument.
8236
8237 2019-06-13  Pedro Alves  <palves@redhat.com>
8238
8239         * thread.c (thread_apply_command): Adjust TID parsing.
8240         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8241         detected before end of string.
8242         (tid_is_in_list): Error out if LIST is invalid.
8243
8244 2019-06-13  Pedro Alves  <palves@redhat.com>
8245
8246         * completer.c (complete_line_internal_1): Rewind completion word
8247         point.
8248         (completion_tracker::advance_custom_word_point_by): Change
8249         parameter type to int.
8250         * completer.h (completion_tracker::advance_custom_word_point_by):
8251         Likewise.
8252
8253 2019-06-13  Pedro Alves  <palves@redhat.com>
8254
8255         * completer.c (advance_to_completion_word): Handle delimiters.
8256
8257 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8258
8259         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8260
8261 2019-06-11  Tom Tromey  <tom@tromey.com>
8262
8263         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8264         (xmalloc_failed): Move to alloc.c.
8265         * alloc.c: New file.
8266         * Makefile.in (COMMON_SFILES): Add alloc.c.
8267
8268 2019-06-11  Tom Tromey  <tom@tromey.com>
8269
8270         * nat/linux-waitpid.c: Don't include server.h.
8271         (linux_debug): Remove.
8272         (my_waitpid): Update.
8273
8274 2019-06-11  Tom Tromey  <tromey@adacore.com>
8275
8276         * infcall.c (_initialize_infcall): Remove trailing newline from
8277         help.
8278         * user-regs.c (_initialize_user_regs): Remove trailing newline
8279         from help.
8280         * typeprint.c (_initialize_typeprint): Remove trailing newline
8281         from help.
8282         * reverse.c (_initialize_reverse): Remove trailing newlines from
8283         help.
8284         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8285         from help.
8286         * language.c (add_set_language_command): Remove trailing newline
8287         from help.
8288         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8289         help.
8290         * disasm.c (_initialize_disasm): Remove trailing newline from
8291         help.
8292         * top.c (init_main): Remove trailing newline from help.
8293         * interps.c (_initialize_interpreter): Remove trailing newline
8294         from help.
8295         * btrace.c (_initialize_btrace): Remove trailing newlines from
8296         help.
8297         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8298         from help.
8299         * python/python.c (_initialize_python): Remove trailing newline
8300         from help.
8301         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8302         help.
8303         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8304         from help.  Reformat some text.
8305         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8306         from help.
8307         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8308         newline from help.
8309
8310 2019-06-11  Tom Tromey  <tromey@adacore.com>
8311
8312         * darwin-nat.c (darwin_decode_exception_message)
8313         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8314
8315 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8316
8317         * valops.c (value_slice): Check for not allocated or not
8318         associated values.
8319
8320 2019-06-10  Tom de Vries  <tdevries@suse.de>
8321
8322         PR gdb/24618
8323         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8324         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8325         invalid.
8326
8327 2019-06-10  Tom de Vries  <tdevries@suse.de>
8328
8329         PR gdb/24611
8330         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8331         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8332
8333 2019-06-10  Tom de Vries  <tdevries@suse.de>
8334
8335         PR symtab/24545
8336         * symtab.c (struct demangled_name_entry): Add language field.
8337         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8338         static minimal symbol".  Set and use language field.
8339
8340 2019-06-10  Tom Tromey  <tromey@adacore.com>
8341
8342         * ada-lang.c (_initialize_ada_language): Update help text.
8343
8344 2019-06-10  Tom Tromey  <tromey@adacore.com>
8345
8346         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8347         with a newline.
8348         * guile/guile.c (handle_boot_error): Don't end warning with a
8349         newline.
8350         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8351         warning with a newline.
8352         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8353         newline.
8354         (s12z_frame_cache): Likewise.
8355         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8356         a newline.
8357         * solib-svr4.c (disable_probes_interface): Don't end warning with
8358         a newline.
8359         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8360         newline.
8361         * python/python.c (do_finish_initialization): Don't end warning
8362         with a newline.
8363
8364 2019-06-10  Tom Tromey  <tom@tromey.com>
8365
8366         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8367         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8368         gdbpy_enter.
8369
8370 2019-06-10  Tom Tromey  <tromey@adacore.com>
8371
8372         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8373         data.
8374         (elf_new_init): Don't call stabsread_new_init.
8375         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8376         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8377         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8378
8379 2019-06-10  Tom de Vries  <tdevries@suse.de>
8380
8381         PR symtab/16264
8382         PR symtab/24517
8383         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8384
8385 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8386
8387         * source.c (find_and_open_source): Also rewrite relative file
8388         names.
8389
8390 2019-04-26  Amos Bird  <amosbird@gmail.com>
8391
8392         * annotate.c (annotate_thread_exited): Add "thread-exited"
8393         annotation.
8394
8395 2019-06-06  Tom Tromey  <tromey@adacore.com>
8396
8397         * maint.h (class scoped_command_stats): Use
8398         DISABLE_COPY_AND_ASSIGN.
8399         <print_time>: New method.
8400         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8401         print_time.
8402         (scoped_command_stats::print_time): New method.
8403
8404 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8405
8406         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8407         instructions of lengths 6 or 8 bytes.
8408
8409 2019-06-04  Pedro Alves  <palves@redhat.com>
8410
8411         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8412
8413         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8414         * breakpoint.c (condition_completer): Likewise.
8415         * cli/cli-dump.c (scan_expression): Likewise.
8416         * common/filestuff.c (mkdir_recursive): Likewise.
8417         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8418         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8419         (gdb_abspath): Likewise.
8420         * compile/compile-cplus-types.c
8421         (compile_cplus_instance::decl_name): Likewise.
8422         * completer.c (complete_explicit_location):
8423         (signal_completer, reg_or_group_completer_1): Likewise.
8424         * cp-support.c (cp_remove_params_if_any): Likewise.
8425         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8426         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8427         * infcmd.c (strip_bg_char): Likewise.
8428         * linespec.c (copy_token_string): Likewise.
8429         * mi/mi-main.c (output_cores): Likewise.
8430         * psymtab.c (psymtab_search_name):
8431         * symfile.c (test_set_ext_lang_command): Likewise.
8432         * target.c (target_fileio_read_stralloc): Likewise.
8433         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8434         * value.c (complete_internalvar): Likewise.
8435
8436 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8437
8438         Add objfile property to gdb.Type.
8439         * NEWS: Mention Python API addition.
8440         * python/py-type.c (typy_get_objfile): New method.
8441
8442 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8443
8444         * NEWS: Mention the new set|show style [title|highlight].
8445         Mention changes to "show style", "help" and "apropos".
8446
8447 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8448
8449         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8450         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8451         instead of print_help_for_command.
8452         (print_doc_of_command): New function.
8453         (help_list): Add 'apropos -v word' suggestion.
8454         (print_help_for_command): Style the command name using title style.
8455         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8456         (_initialize_cli_cmds): Describe -v in apropos_command help.
8457
8458 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8459
8460         * cli/cli-style.h (cli_style_option): Add name in constructor,
8461         add m_name class member, add constructor with intensity,
8462         add name class function.
8463         (cli_style_option::add_setshow_commands): Remove name argument.
8464         (highlight_style, title_style): New styles.
8465         * cli/cli-style.c (do_show): New function that shows a style
8466         characteristic styling the style name with itself.
8467         (set_style_name): New function.
8468         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8469         Update all callers according to the changes in cli/cli-style.h.
8470         * utils.h (fputs_highlighted): New function.
8471         * utils.c (fputs_highlighted): Likewise.
8472
8473 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8474
8475         * NEWS: Mention new pipe command and new convenience variables.
8476
8477 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8478
8479         * cli/cli-cmds.c (pipe_command): New function.
8480         (_initialize_cli_cmds): Call add_com for pipe_command.
8481         Define | as an alias for pipe.
8482         (exit_status_set_internal_vars): New function.
8483         (shell_escape): Call exit_status_set_internal_vars.
8484         cli/cli-decode.c (find_command_name_length): Recognize | as
8485         a single character command.
8486
8487 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8488
8489         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8490         top.c (execute_command_to_ui_file): New function, mostly a copy
8491         of execute_command_to_string.
8492         (execute_command_to_string): Implement by calling
8493         execute_command_to_ui_file.
8494
8495 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8496
8497         * top.h (saved_command_line): Remove declaration.
8498         * top.c (previous_saved_command_line, previous_repeat_arguments):
8499         New variables.
8500         (saved_command_line): Make static, define together with other
8501         'repeat variables'.
8502         (dont_repeat): Clear repeat_arguments.
8503         (repeat_previous, get_saved_command_line, save_command_line):
8504         New functions.
8505         (gdb_init): Initialize saved_command_line
8506         and previous_saved_command_line.
8507         * main.c (captured_main_1): Remove saved_command_line initialization.
8508         * event-top.c (handle_line_of_input): Update to use
8509         the new 'repeat' related functions instead of direct access to
8510         saved_command_line.
8511         * command.h (repeat_previous, get_saved_command_line,
8512         save_command_line): New declarations.
8513         (dont_repeat): Add comment.
8514
8515 2019-05-30  Tom Tromey  <tromey@adacore.com>
8516
8517         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8518         Fix comment.
8519         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8520
8521 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8522
8523         PR cli/24587
8524         * completer.c (complete): Initialize variable word.
8525
8526 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8527
8528         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8529         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8530         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8531         'body' is NULL to the outter 'if', protecting the '!is_define'
8532         situation as well.
8533
8534 2019-05-29  Tom Tromey  <tromey@adacore.com>
8535
8536         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8537         (dwarf_unknown): New function.
8538         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8539         (dwarf_type_encoding_name): Use dwarf_unknown.
8540
8541 2019-05-29  Tom Tromey  <tromey@adacore.com>
8542
8543         PR c++/20020:
8544         * cp-valprint.c (cp_print_value_fields): Call
8545         cp_print_static_field inside "try".
8546
8547 2019-05-29  Tom Tromey  <tromey@adacore.com>
8548
8549         * inflow.c (struct terminal_info): Add default operator=.
8550         * configure: Rebuild.
8551         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8552         -Wdeprecated-copy-dtor, -Wredundant-move.
8553
8554 2019-05-29  Tom Tromey  <tromey@adacore.com>
8555
8556         * NEWS: Add entry.
8557         * infcmd.c (print_return_value_1): Handle finish_print
8558         option.
8559         (show_print_finish): New function.
8560         (_initialize_infcmd): Add "set/show print finish" commands.
8561         * valprint.c (user_print_options): Initialize new member.
8562         * valprint.h (struct value_print_options) <finish_print>: New
8563         member.
8564
8565 2019-05-28  Tom Tromey  <tromey@adacore.com>
8566
8567         * ada-lang.c (ada_remove_Xbn_suffix)
8568         (find_old_style_renaming_symbol)
8569         (parse_old_style_renaming): Remove.
8570         (ada_find_renaming_symbol): Don't call
8571         find_old_style_renaming_symbol.
8572         (ada_is_renaming_symbol): Rename from
8573         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8574         bool.  Now static.
8575         (ada_read_var_value): Update and simplify.
8576         * ada-exp.y (write_var_or_type): Remove old code.
8577
8578 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8579
8580         PR gdb/25010
8581         * event-top.c: Remove include comment.
8582         * inflow.c (class scoped_ignore_sigttou): Move from here...
8583         * inflow.h (class scoped_ignore_sigttou): ...to here.
8584         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8585         * top.c:  Remove include comment.
8586
8587 2019-05-27  Tom Tromey  <tom@tromey.com>
8588
8589         * NEWS: Fix typo.
8590
8591 2019-05-22  Tom Tromey  <tromey@adacore.com>
8592
8593         * target.c (target_follow_exec): Constify parameter.
8594         * target-delegates.c: Rebuild.
8595         * remote.c (remote_target::follow_exec): Constify parameter.
8596         * infrun.c (follow_exec): Constify parameter.
8597         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8598         (target_follow_exec): Likewise.
8599
8600 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8601
8602         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8603         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8604
8605 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8606
8607         * NEWS: Add debugredirect and testsuite sections.
8608
8609 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8610
8611         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8612         target descriptions using exclusively floating point register name
8613         aliases.
8614
8615 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8616
8617         PR gdb/18644:
8618         * f-lang.c (build_fortran_types): Handle the case where
8619         gdbarch_floatformat_for_type returns a nullptr.
8620
8621 2019-05-21  Tom de Vries  <tdevries@suse.de>
8622
8623         PR cli/24587
8624         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8625
8626 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8627
8628         PR gdb/18644:
8629         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8630         16-byte floats.
8631         * i386-tdep.c (i386_floatformat_for_type): Use
8632         floatformats_ia64_quad for the 16-byte floating point component
8633         within a fortran 32-byte complex number.
8634
8635 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8638         delete default constructor.
8639         (find_partial_die): Update to return const struct.
8640         (partial_die_parent_scope): Move variable declaration into scope
8641         of its use and change its type to auto.
8642         (guess_partial_die_structure_name): Likewise.
8643         (partial_die_info::fixup): Likewise.
8644
8645 2019-05-17  Tom Tromey  <tromey@adacore.com>
8646
8647         * source.c (find_and_open_source): Remove cast.
8648
8649 2019-05-17  Tom Tromey  <tromey@adacore.com>
8650
8651         * annotate.c (annotate_source): Make "filename" const.
8652         * annotate.h (annotate_source): Use const.
8653
8654 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8655
8656         * disasm.c (set_disassembler_options): Send errors to stderr.
8657
8658 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8659
8660         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8661         (cli_interp_base::set_logging): Check debug_redirect.
8662         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8663         * cli/cli-logging.c (debug_redirect): Add static variable.
8664         (pop_output_files): Add default param.
8665         (handle_redirections): Print debug setting.
8666         (show_logging_command): Likewise.
8667         (_initialize_cli_logging): Add debugredirect command.
8668         * interps.c (current_interp_set_logging): Add debug_redirect
8669         parameter.
8670         * interps.h (set_logging): Add debug_redirect parameter.
8671         (current_interp_set_logging): Likewise.
8672         * mi/mi-common.h: Likewise.
8673         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8674
8675 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8676             Tom Tromey  <tromey@adacore.com>
8677
8678         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8679         directly.
8680         * cli/cli-interp.h (make_logging_output): Remove declaration.
8681         * cli/cli-logging.c (make_logging_output): Remove function.
8682         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8683         directly.
8684         * ui-file.c (tee_file::tee_file): Remove bools.
8685         (tee_file::~tee_file): Remove deletes.
8686         * ui-file.h (tee_file): Remove bools.
8687
8688 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8689
8690         * mi/mi-cmds.h (mi_cmd_complete): New function.
8691         * mi/mi-main.c (mi_cmd_complete): Likewise.
8692         * mi/mi-cmds.c: Define new MI command -complete.
8693         * NEWS: Mention new -complete command.
8694
8695 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8696
8697         * completer.h (complete): New function.
8698         * completer.c (complete): Likewise.
8699         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8700         function defined in completer.h.
8701
8702 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8703
8704         * MAINTAINERS (Write After Approval): Add myself.
8705
8706 2019-05-17  Tom de Vries  <tdevries@suse.de>
8707
8708         PR gdb/24094
8709         * dwarf2read.c (struct cu_partial_die_info): New struct.
8710         (find_partial_die): Return cu_partial_die_info.
8711         (partial_die_parent_scope, guess_partial_die_structure_name)
8712         (partial_die_info::fixup): Handle new return type of find_partial_die.
8713
8714 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8715
8716         PR breakpoints/24541
8717         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8718         "std::string", simplifying the algorithm.
8719
8720 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8721
8722         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8723         (stap_static_probe_ops::get_probes): Likewise.
8724
8725 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8726
8727         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8728         '-')" and "else if".
8729         (stap_parse_single_operand): Join checks for
8730         "gdbarch_stap_parse_special_token_p" and
8731         "gdbarch_stap_parse_special_token" in the same "if" statement.
8732         Invert check when verifying for operation on register
8733         displacement.
8734
8735 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8736
8737         * stap-probe.c (stap_get_opcode): Update comment.
8738         (stap_get_expected_argument_type): Likewise.
8739         (handle_stap_probe): Likewise.
8740
8741 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8742
8743         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8744         return type to 'bool'.  Adjust comment.  Use 'bool' when
8745         appropriate.
8746         (i386_stap_parse_special_token_three_arg_disp): Likewise.
8747         * stap-probe.c (stap_parse_argument_1): Likewise.
8748         (stap_is_operator): Likewise.
8749         (stap_is_generic_prefix): Likewise.
8750         (stap_is_register_prefix): Likewise.
8751         (stap_is_register_indirection_prefix): Likewise.
8752         (stap_is_integer_prefix): Likewise.
8753         (stap_generic_check_suffix): Likewise.
8754         (stap_check_integer_suffix): Likewise.
8755         (stap_check_register_suffix): Likewise.
8756         (stap_check_register_indirection_suffix): Likewise.
8757         (stap_parse_register_operand): Likewise.
8758         (stap_parse_single_operand): Likewise.
8759         (stap_parse_argument_1): Likewise.
8760         (stap_probe::get_argument_count): Likewise.
8761         (stap_is_operator): Likewise.
8762
8763 2019-05-16  Tom Tromey  <tromey@adacore.com>
8764
8765         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8766         keyword to foreach.
8767
8768 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
8769
8770         * linux-thread-db.c (try_thread_db_load_1): Change return type
8771         to bool.
8772         (try_thread_db_load): Likewise.
8773         (try_thread_db_load_from_pdir_1): Likewise.
8774         (try_thread_db_load_from_pdir): Likewise.
8775         (try_thread_db_load_from_sdir): Likewise.
8776         (try_thread_db_load_from_dir): Likewise.
8777         (thread_db_load_search): Likewise.
8778         (has_libpthread): Likewise.
8779         (thread_db_load): Likewise.
8780
8781 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
8782
8783         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8784         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8785         NULL, and complain/return if that's the case.
8786
8787 2019-05-15  John Darrington <john@darrington.wattle.id.au>
8788
8789         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8790         (advance, posn, abstract_read_memory): New functions.
8791         [struct mem_read_abstraction]: New struct.
8792         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8793
8794 2019-05-14  Tom Tromey  <tromey@adacore.com>
8795
8796         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8797         value is not lval_memory.
8798
8799 2019-05-14  Tom Tromey  <tromey@adacore.com>
8800
8801         * solib.c (info_sharedlibrary_command): Style the file name.
8802
8803 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
8804
8805         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8806         (aarch64_vnv_type): Likewise.
8807         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8808         * common/tdesc.c: Likewise.
8809         * common/tdesc.h (enum tdesc_type_kind): Likewise.
8810         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8811         * features/aarch64-fpu.xml: Add ieee half view.
8812         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8813         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8814         * gdbtypes.h (struct builtin_type): Likewise.
8815         (struct objfile_type): Likewise.
8816
8817 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
8818
8819         * language.c (language_sniff_from_mangled_name): Fix "langauge"
8820         typo.
8821         * location.h (string_to_event_location): Likewise.
8822
8823 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
8824
8825         GDB 8.3 released.
8826
8827 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8828
8829         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8830         New variable declaration.
8831         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8832         New variable.
8833         (print_one_breakpoint): Use ui_out::test_flags and new global
8834         variable to compute use_fixed_output.
8835         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8836         Remove.
8837         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8838         (mi_multi_location_breakpoint_output_fixed): Remove.
8839         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8840         new variable.
8841         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8842         fix_multi_location_breakpoint_output flag if version >= 3.
8843         * ui-out.h (enum ui_out_flag)
8844         <fix_multi_location_breakpoint_output>: New enumerator.
8845
8846 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
8847
8848         * contrib/cc-with-tweaks.sh: Validate dwz's work.
8849
8850 2019-05-10  Tom Tromey  <tromey@adacore.com>
8851
8852         * ada-lang.c (catch_ada_completer): New function.
8853         (_initialize_ada_language): Use it.
8854
8855 2019-05-10  Tom Tromey  <tromey@adacore.com>
8856
8857         * thread.c (print_thread_info): Make "requested_threads" const.
8858         * gdbthread.h (print_thread_info): Make "requested_threads"
8859         const.
8860         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8861         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8862
8863 2019-05-08  Tom Tromey  <tom@tromey.com>
8864
8865         * gdbtypes.c (objfile_type_data): Change type.
8866         (objfile_type, _initialize_gdbtypes): Update.
8867
8868 2019-05-08  Tom Tromey  <tom@tromey.com>
8869
8870         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8871         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8872         (_initialize_dwarf2_frame): Update.
8873
8874 2019-05-08  Tom Tromey  <tom@tromey.com>
8875
8876         * objc-lang.c (objc_objfile_data): Change type.
8877         (find_methods): Update.
8878         (_initialize_objc_lang): Remove.
8879
8880 2019-05-08  Tom Tromey  <tom@tromey.com>
8881
8882         * stabsread.c (rs6000_builtin_type_data): Change type.
8883         (rs6000_builtin_type, _initialize_stabsread): Update.
8884
8885 2019-05-08  Tom Tromey  <tom@tromey.com>
8886
8887         * mips-tdep.c (mips_pdr_data): Remove.
8888         (_initialize_mips_tdep): Update.
8889
8890 2019-05-08  Tom Tromey  <tom@tromey.com>
8891
8892         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8893         (hppa_init_objfile_priv_data, read_unwind_info)
8894         (find_unwind_entry, _initialize_hppa_tdep): Update.
8895
8896 2019-05-08  Tom Tromey  <tom@tromey.com>
8897
8898         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8899         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8900         on obstack.
8901         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8902
8903 2019-05-08  Tom Tromey  <tom@tromey.com>
8904
8905         * mdebugread.c (basic_type_data): Change type.
8906         (basic_type, _initialize_mdebugread): Update.
8907
8908 2019-05-08  Tom Tromey  <tom@tromey.com>
8909
8910         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8911
8912 2019-05-08  Tom Tromey  <tom@tromey.com>
8913
8914         * nto-tdep.c (nto_inferior_data_reg): Change type.
8915         (nto_inferior_data): Update.
8916         (nto_inferior_data_cleanup, nto_new_inferior_data)
8917         (_initialize_nto_tdep): Remove.
8918         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8919
8920 2019-05-08  Tom Tromey  <tom@tromey.com>
8921
8922         * ada-lang.c (struct ada_inferior_data): Add initializers.
8923         (ada_inferior_data): Change type.
8924         (ada_inferior_data_cleanup): Remove.
8925         (get_ada_inferior_data, ada_inferior_exit)
8926         (struct ada_pspace_data): Add initializers, destructor.
8927         (ada_pspace_data_handle): Change type.
8928         (get_ada_pspace_data): Update.
8929         (ada_pspace_data_cleanup): Remove.
8930
8931 2019-05-08  Tom Tromey  <tom@tromey.com>
8932
8933         * coffread.c (struct coff_symfile_info): Add initializers.
8934         (coff_objfile_data_key): Move lower.  Change type.
8935         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8936         Update.
8937         (coff_free_info): Remove.
8938
8939 2019-05-08  Tom Tromey  <tom@tromey.com>
8940
8941         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8942         (fbsd_pspace_data_handle): Move lower.  Change type.
8943         (get_fbsd_pspace_data): Update.
8944         (fbsd_pspace_data_cleanup): Remove.
8945         (_initialize_fbsd_tdep): Update.
8946
8947 2019-05-08  Tom Tromey  <tom@tromey.com>
8948
8949         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8950         (get_ada_tasks_pspace_data): Update.
8951         (ada_tasks_pspace_data_cleanup): Remove.
8952         (_initialize_tasks): Update.
8953         (ada_tasks_inferior_data_handle): Change type.
8954         (get_ada_tasks_inferior_data): Update.
8955         (ada_tasks_inferior_data_cleanup): Remove.
8956         (struct ada_tasks_pspace_data): Add initializers.
8957
8958 2019-05-08  Tom Tromey  <tom@tromey.com>
8959
8960         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8961         * symfile-debug.c (debug_sym_get_probes): Change type.
8962         * stap-probe.c (handle_stap_probe):
8963         (stap_static_probe_ops::get_probes): Change type.
8964         * probe.h (class static_probe_ops) <get_probes>: Change type.
8965         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8966         (parse_probes_in_pspace): Update.
8967         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8968         Update.
8969         (any_static_probe_ops::get_probes): Change type.
8970         * elfread.c (elfread_data): New typedef.
8971         (probe_key): Change type.
8972         (elf_get_probes): Likewise.  Update.
8973         (probe_key_free): Remove.
8974         (_initialize_elfread): Update.
8975         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8976         Change type.
8977         (dtrace_process_dof_probe, dtrace_process_dof)
8978         (dtrace_static_probe_ops::get_probe): Change type.
8979
8980 2019-05-08  Tom Tromey  <tom@tromey.com>
8981
8982         * xcoffread.c (struct xcoff_symfile_info): Rename from
8983         coff_symfile_info.  Add initializers.
8984         (xcoff_objfile_data_key): Move lower.  Change type.
8985         (XCOFF_DATA): Rewrite.
8986         (xcoff_free_info): Remove.
8987         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8988         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8989         (xcoff_initial_scan): Update.
8990
8991 2019-05-08  Tom Tromey  <tom@tromey.com>
8992
8993         * solib-svr4.c (struct svr4_info): Add initializers and
8994         destructor.
8995         <probes_table>: Now an htab_up.
8996         (solib_svr4_pspace_data): Change type.
8997         (free_probes_table): Simplify.
8998         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8999         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9000         (probes_table_remove_objfile_probes, register_solib_event_probe)
9001         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9002         (_initialize_svr4_solib): Update.
9003
9004 2019-05-08  Tom Tromey  <tom@tromey.com>
9005
9006         * remote.c (remote_pspace_data): Change type.
9007         (remote_pspace_data_cleanup): Remove.
9008         (get_remote_exec_file, set_pspace_remote_exec_file)
9009         (_initialize_remote): Update.
9010
9011 2019-05-08  Tom Tromey  <tom@tromey.com>
9012
9013         * breakpoint.c (breakpoint_objfile_key): Change type.
9014         (get_breakpoint_objfile_data): Update.
9015         (free_breakpoint_objfile_data): Remove.
9016         (_initialize_breakpoint): Update.
9017
9018 2019-05-08  Tom Tromey  <tom@tromey.com>
9019
9020         * linux-tdep.c (struct linux_info): Add initializers.
9021         (linux_inferior_data): Move.  Change type.
9022         (invalidate_linux_cache_inf): Update.
9023         (linux_inferior_data_cleanup): Remove.
9024         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9025
9026 2019-05-08  Tom Tromey  <tom@tromey.com>
9027
9028         * auxv.c (auxv_inferior_data): Move.  Change type.
9029         (auxv_inferior_data_cleanup): Remove.
9030         (invalidate_auxv_cache_inf): Rewrite.
9031         (get_auxv_inferior_data, _initialize_auxv): Update.
9032
9033 2019-05-08  Tom Tromey  <tom@tromey.com>
9034
9035         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9036         (symfile_debug_objfile_data_key): Change type.
9037         (symfile_debug_installed, debug_qf_has_symbols)
9038         (debug_qf_find_last_source_symtab)
9039         (debug_qf_forget_cached_source_info)
9040         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9041         (debug_qf_print_stats, debug_qf_dump)
9042         (debug_qf_expand_symtabs_for_function)
9043         (debug_qf_expand_all_symtabs)
9044         (debug_qf_expand_symtabs_with_fullname)
9045         (debug_qf_map_matching_symbols)
9046         (debug_qf_expand_symtabs_matching)
9047         (debug_qf_find_pc_sect_compunit_symtab)
9048         (debug_qf_map_symbol_filenames)
9049         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9050         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9051         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9052         (debug_sym_read_linetable, debug_sym_relocate): Update.
9053         (symfile_debug_free_objfile): Remove.
9054         (install_symfile_debug_logging, _initialize_symfile_debug):
9055         Update.
9056
9057 2019-05-08  Tom Tromey  <tom@tromey.com>
9058
9059         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9060         allocate_on_obstack.
9061         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9062         (get_dwarf2_per_objfile): Update.
9063         (set_dwarf2_per_objfile): Remove.
9064         (dwarf2_has_info, dwarf2_get_section_info): Update.
9065         (dwarf2_free_objfile): Remove.
9066         (_initialize_dwarf2_read): Update.
9067
9068 2019-05-08  Tom Tromey  <tom@tromey.com>
9069
9070         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9071         initializers.
9072         <unsupported_script_warning_printed,
9073         script_not_found_warning_printed>: Now bool.
9074         (auto_load_pspace_data): Change type.
9075         (~auto_load_pspace_info): Rename from
9076         auto_load_pspace_data_cleanup.
9077         (get_auto_load_pspace_data, init_loaded_scripts_info)
9078         (clear_section_scripts, maybe_print_unsupported_script_warning)
9079         (maybe_print_script_not_found_warning, _initialize_auto_load):
9080         Update.
9081
9082 2019-05-08  Tom Tromey  <tom@tromey.com>
9083
9084         * objfiles.c (objfile_pspace_info): Add destructor and
9085         initializers.
9086         (objfiles_pspace_data): Change type.
9087         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9088         (get_objfile_pspace_data): Update.
9089         (objfiles_bfd_data): Change type.
9090         (get_objfile_bfd_data): Update.
9091         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9092
9093 2019-05-08  Tom Tromey  <tom@tromey.com>
9094
9095         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9096         Change type.
9097         (get_catch_syscall_inferior_data): Update.
9098         (catch_syscall_inferior_data_cleanup): Remove.
9099         (_initialize_break_catch_syscall): Update.
9100
9101 2019-05-08  Tom Tromey  <tom@tromey.com>
9102
9103         * inflow.c (struct terminal_info): Add destructor and
9104         initializers.
9105         (inflow_inferior_data): Change type.
9106         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9107         (get_inflow_inferior_data, inflow_inferior_exit)
9108         (swap_terminal_info, _initialize_inflow): Update.
9109
9110 2019-05-08  Tom Tromey  <tom@tromey.com>
9111
9112         * target-dcache.c (target_dcache_cleanup): Remove.
9113         (target_dcache_aspace_key): Change type.
9114         (target_dcache_init_p, target_dcache_invalidate)
9115         (target_dcache_get, target_dcache_get_or_init)
9116         (_initialize_target_dcache): Update.
9117         * dcache.h (struct dcache_deleter): New.
9118
9119 2019-05-08  Tom Tromey  <tom@tromey.com>
9120
9121         * symtab.c (struct symbol_cache): Add destructor and
9122         initializers.
9123         (symbol_cache_key): Move.  Change type.
9124         (make_symbol_cache, free_symbol_cache): Remove.
9125         (get_symbol_cache): Update.
9126         (symbol_cache_cleanup): Remove.
9127         (ALL_PSPACES, symbol_cache_flush)
9128         (maintenance_print_symbol_cache)
9129         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9130         Update.
9131
9132 2019-05-08  Tom Tromey  <tom@tromey.com>
9133
9134         * symtab.c (struct main_info): Add destructor and initializers.
9135         (main_progspace_key): Move.  Change type.
9136         (get_main_info): Update.
9137         (main_info_cleanup): Remove.
9138         (_initialize_symtab): Update.
9139
9140 2019-05-08  Tom Tromey  <tom@tromey.com>
9141
9142         * registry.h (DECLARE_REGISTRY): Define the _key class.
9143
9144 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9145
9146         * NEWS: Merge two 'New commands' sections.
9147
9148 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9149
9150         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9151         parameter and use Ada language definition instead.
9152         (ada_val_print_ptr): Remove unused language parameter.
9153         (ada_val_print_num): Remove language parameter and use Ada language
9154         definition instead.
9155         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9156         parameter.
9157         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9158         parameter and use Ada language definition instead.
9159         (ada_val_print_1): Update all ada_val_print_xxx calls.
9160         Remove language parameter.
9161         (ada_val_print): Update ada_val_print_1 call.
9162
9163 2019-05-08  Tom Tromey  <tromey@adacore.com>
9164
9165         * remote.c (remote_hw_watchpoint_limit)
9166         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9167         Now static.
9168
9169 2019-05-08  Tom Tromey  <tromey@adacore.com>
9170
9171         * maint.c (_initialize_maint_cmds): Move initialization code to
9172         remote.c.
9173         (watchdog, show_watchdog): Move to remote.c.
9174         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9175         "watchdog" static.
9176         (_initialize_remote): Move initialization code from maint.c.
9177         * defs.h (watchdog): Don't declare.
9178
9179 2019-05-08  Tom Tromey  <tromey@adacore.com>
9180
9181         * tui/tui-interp.c: Include main.h.
9182         * interps.c: Include main.h.
9183         * main.h (interpreter_p): Declare.
9184         * defs.h (interpreter_p): Don't declare.
9185
9186 2019-05-08  Tom Tromey  <tromey@adacore.com>
9187
9188         * dwarf2loc.c: Include dwarf2read.h.
9189         * defs.h (read_unsigned_leb128): Don't declare.
9190         * dwarf2read.h (read_unsigned_leb128): Declare.
9191
9192 2019-05-08  Tom Tromey  <tromey@adacore.com>
9193
9194         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9195         method.
9196
9197 2019-05-08  Tom Tromey  <tromey@adacore.com>
9198
9199         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9200         when no wrap column is set.
9201
9202 2019-05-08  Tom Tromey  <tromey@adacore.com>
9203
9204         * c-lang.c (c_get_string): Handle non-C-style arrays.
9205
9206 2019-05-08  Tom Tromey  <tromey@adacore.com>
9207
9208         * typeprint.c (print_offset_data::update): Print the bit offset,
9209         not the number of bits remaining.
9210
9211 2019-05-08  Tom Tromey  <tromey@adacore.com>
9212
9213         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9214         padding at end of comment.
9215
9216 2019-05-08  Tom Tromey  <tromey@adacore.com>
9217
9218         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9219         Compare main types.
9220
9221 2019-05-06  Tom Tromey  <tom@tromey.com>
9222
9223         * common/scoped_mmap.c: Include common-defs.h.
9224         * common/scoped_mmap.h: Don't include config.h.
9225
9226 2019-05-04  Tom Tromey  <tom@tromey.com>
9227
9228         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9229         (struct aarch64_call_info): Add initializers.
9230         <si>: Now a std::vector.
9231         (pass_on_stack, aarch64_push_dummy_call): Update.
9232
9233 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9234             Tom Tromey  <tom@tromey.com>
9235
9236         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9237         (ppc_threads): Now a std::vector.  Now static.
9238         (hwdebug_find_thread_points_by_tid)
9239         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9240         Update.
9241
9242 2019-05-04  Tom Tromey  <tom@tromey.com>
9243
9244         * arc-tdep.c (arc_tdesc_init): Return bool.
9245
9246 2019-05-04  Tom Tromey  <tom@tromey.com>
9247
9248         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9249         Use gdb_assert_not_reached.
9250
9251 2019-05-04  Tom Tromey  <tom@tromey.com>
9252
9253         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9254         "false".
9255
9256 2019-05-04  Tom Tromey  <tom@tromey.com>
9257
9258         * arc-tdep.c (arc_tdesc_init): Use bool.
9259
9260 2019-05-04  Tom Tromey  <tom@tromey.com>
9261
9262         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9263
9264 2019-05-04  Tom Tromey  <tom@tromey.com>
9265
9266         * cli/cli-cmds.c (valid_command_p): Return bool.
9267
9268 2019-05-04  Tom Tromey  <tom@tromey.com>
9269
9270         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9271         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9272
9273 2019-05-04  Raul Tambre  <raul@tambre.ee>
9274
9275         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9276         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9277         operator for comparison.
9278
9279 2019-05-04  Tom Tromey  <tom@tromey.com>
9280
9281         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9282         (lookup_partial_symbol, print_partial_symbols)
9283         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9284         (psymbol_compare): Update.
9285         (add_psymbol_to_bcache): Clear the entire psymbol.
9286         (maintenance_check_psymtabs): Update.
9287         * psympriv.h (struct partial_symbol): Don't derive from
9288         general_symbol_info.
9289         <obj_section, unrelocated_address, address,
9290         set_unrelocated_address>: Update.
9291         <ginfo>: New member.
9292         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9293         (debug_names::write_psymbols): Update.
9294
9295 2019-05-04  Tom de Vries  <tdevries@suse.de>
9296
9297         * contrib/cc-with-tweaks.sh: Support -n arg.
9298
9299 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9300
9301         * corelow.c (core_target::detach): Ensure frame cache and
9302         register caches are cleared.
9303         inferior.c (exit_inferior_1): Likewise.
9304
9305 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9306             Tom Tromey  <tom@tromey.com>
9307
9308         * dictionary.c (collate_pending_symbols_by_language): Remove
9309         "struct" from foreach.
9310         * symtab.c (lookup_global_symbol_from_objfile)
9311         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9312         foreach.
9313         * ser-tcp.c (net_open): Remove "struct" from foreach.
9314         * objfiles.c (objfile_relocate, objfile_rebase)
9315         (objfile_has_symbols): Remove "struct" from foreach.
9316         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9317         from foreach.
9318         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9319         foreach.
9320         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9321         "struct" from foreach.
9322         * ada-lang.c (create_excep_cond_exprs)
9323         (ada_exception_catchpoint_cond_string): Remove "struct" from
9324         foreach.
9325
9326 2019-05-03  Tom Tromey  <tromey@adacore.com>
9327
9328         * ada-exp.y (convert_char_literal): Check suffix of each
9329         enumerator.
9330
9331 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9332
9333         PR ada/21406:
9334         * ada-exp.y (yywrap): Don't define.
9335         * ada-lex.l (%option): Add noyywrap
9336         (yywrap): Remove.
9337
9338 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9339
9340         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9341         _WIN32_WINNT to the XP level, unless already defined to a higher
9342         level.
9343
9344         * unittests/parse-connection-spec-selftests.c:
9345         * ser-tcp.c:
9346         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9347         override.
9348
9349         * symfile.c (find_separate_debug_file): Remove colon from the
9350         drive spec of DOS/Windows file names of the target, so that the
9351         file name produced from DEBUGDIR and the target's directory will
9352         be valid on DOS/Windows systems.
9353
9354 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9355
9356         * rust-lang.c (val_print_struct): Handle printing structures
9357         containing strings.
9358
9359 2019-05-02  Tom Tromey  <tromey@adacore.com>
9360
9361         * valarith.c (_initialize_valarith): Remove.
9362
9363 2019-05-01  Tom Tromey  <tromey@adacore.com>
9364
9365         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9366         bitfields.
9367
9368 2019-05-01  Tom Tromey  <tromey@adacore.com>
9369
9370         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9371         for big-endian copies.
9372
9373 2019-04-30  Ali Tamur  <tamur@google.com>
9374         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9375         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9376         (read_3_bytes): New function.
9377
9378 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9379
9380         * windows-nat.c (main_thread_id): Delete.
9381         (handle_output_debug_string): Replace main_thread_id by
9382         current_event.dwThreadId.
9383         (fake_create_process): Likewise.
9384         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9385         Do not set main_thread_id.
9386         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9387         current_event.dwThreadId.
9388         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9389
9390 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9391
9392         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9393         Use current_event.dwThreadId instead of main_thread_id.
9394
9395 2019-04-30  Tom Tromey  <tromey@adacore.com>
9396
9397         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9398         (create_excep_cond_exprs): Iterate over program spaces.
9399         (ada_exception_catchpoint_cond_string): Examine all minimal
9400         symbols for exception types.
9401
9402 2019-04-30  Tom Tromey  <tromey@adacore.com>
9403
9404         PR c++/24470:
9405         * dwarf2read.c (process_structure_scope): Handle case where type
9406         has template parameters but no symbol was created.
9407
9408 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9409             Chris January  <chris.january@arm.com>
9410
9411         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9412         qualifier.
9413         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9414
9415 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9416
9417         * f-typeprint.c (f_print_type): Update rules for printing
9418         whitespace.
9419         (f_type_print_varspec_suffix): Likewise.
9420
9421 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9422             Chris January  <chris.january@arm.com>
9423
9424         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9425         function arguments.
9426
9427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * f-lang.c (build_fortran_types): Change name of void type to
9430         lower case.
9431         * f-typeprint.c (f_type_print_base): Print the name of the void
9432         type, rather than a fixed string.
9433         * f-valprint.c (f_decorations): Use lower case void string.
9434
9435 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9436             Chris January  <chris.january@arm.com>
9437
9438         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9439         types for Fortran.
9440
9441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9442             Chris January  <chris.january@arm.com>
9443             David Lecomber  <david.lecomber@arm.com>
9444
9445         * f-exp.y (BINOP_INTRINSIC): New token.
9446         (exp): New parser rule handling BINOP_INTRINSIC.
9447         (f77_keywords): Add new builtin procedures.
9448         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9449         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9450         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9451         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9452         (print_unop_subexp_f): New function.
9453         (print_binop_subexp_f): New function.
9454         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9455         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9456         (dump_subexp_body_f): Likewise.
9457         (operator_check_f): Likewise.
9458         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9459         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9460
9461 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9462
9463         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9464         UNOP_KIND.
9465         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9466         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9467         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9468         (operator_length_f): New fuction.
9469         (print_subexp_f): New function.
9470         (op_name_f): New function.
9471         (dump_subexp_body_f): New function.
9472         (operator_check_f): New function.
9473         (exp_descriptor_f): Replace standard expression handling functions
9474         with new functions.
9475         * gdb/fortran-operator.def: New file.
9476         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9477         * gdb/std-operator.def: Remove UNOP_KIND.
9478
9479 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * std-operator.def: Remove unbalanced, stray double quote
9482         character.
9483
9484 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9485             Chris January  <chris.january@arm.com>
9486             Daniel Everett  <daniel.everett@arm.com>
9487             Nick Forrington  <nick.forrington@arm.com>
9488             Richard Bunt  <richard.bunt@arm.com>
9489
9490         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9491         of depth when printing anonymous structs or unions.
9492         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9493         Don't print either the top-level value, or the children if the
9494         max-depth is exceeded.
9495         (ppscm_print_children): When printing the key of a map, allow one
9496         extra level of depth.
9497         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9498         print either the top-level value, or the children if the max-depth
9499         is exceeded.
9500         (print_children): When printing the key of a map, allow one extra
9501         level of depth.
9502         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9503         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9504         (user_print_options): Initialise max_depth field.
9505         (val_print_scalar_or_string_type_p): New function.
9506         (val_print): Check to see if the max depth has been reached.
9507         (val_print_check_max_depth): Define new function.
9508         (show_print_max_depth): New function.
9509         (_initialize_valprint): Add 'print max-depth' option.
9510         * valprint.h (struct value_print_options) <max_depth>: New field.
9511         (val_print_check_max_depth): Declare new function.
9512         * NEWS: Document new feature.
9513
9514 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * ada-lang.c (ada_language_defn): Initialise new field.
9517         * c-lang.c (c_is_string_type_p): New function.
9518         (c_language_defn): Initialise new field.
9519         (cplus_language_defn): Initialise new field.
9520         (asm_language_defn): Initialise new field.
9521         (minimal_language_defn): Initialise new field.
9522         * c-lang.h (c_is_string_type_p): Declare new function.
9523         * d-lang.c (d_language_defn): Initialise new field.
9524         * f-lang.c (f_is_string_type_p): New function.
9525         (f_language_defn): Initialise new field.
9526         * go-lang.c (go_is_string_type_p): New function.
9527         (go_language_defn): Initialise new field.
9528         * language.c (default_is_string_type_p): New function.
9529         (unknown_language_defn): Initialise new field.
9530         (auto_language_defn): Initialise new field.
9531         * language.h (struct language_defn) <la_is_string_type_p>: New
9532         member variable.
9533         (default_is_string_type_p): Declare new function.
9534         * m2-lang.c (m2_language_defn): Initialise new field.
9535         * objc-lang.c (objc_language_defn): Initialise new field.
9536         * opencl-lang.c (opencl_language_defn): Initialise new field.
9537         * p-lang.c (pascal_is_string_type_p): New function.
9538         (pascal_language_defn): Initialise new field.
9539         * rust-lang.c (rust_is_string_type_p): New function.
9540         (rust_language_defn): Initialise new field.
9541
9542 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9545         New field.
9546         * ada-lang.c (ada_language_defn): Initialise new field.
9547         * c-lang.c (c_language_defn): Likewise.
9548         (cplus_language_defn): Likewise.
9549         (asm_language_defn): Likewise.
9550         (minimal_language_defn): Likewise.
9551         * d-lang.c (d_language_defn): Likewise.
9552         * f-lang.c (f_language_defn): Likewise.
9553         * go-lang.c (go_language_defn): Likewise.
9554         * language.c (unknown_language_defn): Likewise.
9555         (auto_language_defn): Likewise.
9556         * m2-lang.c (m2_language_defn): Likewise.
9557         * objc-lang.c (objc_language_defn): Likewise.
9558         * opencl-lang.c (opencl_language_defn): Likewise.
9559         * p-lang.c (pascal_language_defn): Likewise.
9560         * rust-lang.c (rust_language_defn): Likewise.
9561
9562 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9563
9564         * ada-lang.c (ada_is_character_type): Change return type to bool.
9565         (ada_is_string_type): Likewise.
9566         * ada-lang.h (ada_is_character_type): Update declaration
9567         (ada_is_string_type): Likewise.
9568
9569 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9570
9571         Support style in 'frame|thread apply'
9572
9573         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9574         * record.c (record_start, record_stop): Update callers of
9575         execute_command_to_string with false.
9576         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9577         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9578         methods.
9579         (class string_file): New constructor with term_out parameter.
9580         Override methods term_out and can_emit_style_escape.  New member
9581         term_out.
9582         (class stdio_file): Override can_emit_style_escape.
9583         (class tee_file): Override term_out and can_emit_style_escape.
9584         * utils.h (can_emit_style_escape): Remove.
9585         * utils.c (can_emit_style_escape): Likewise.
9586         Update all callers of can_emit_style_escape (SOMESTREAM) to
9587         SOMESTREAM->can_emit_style_escape.
9588         * source-cache.c (source_cache::get_source_lines): Likewise.
9589         * stack.c (frame_apply_command_count): Call execute_command_to_string
9590         passing the term_out characteristic of the current gdb_stdout.
9591         * thread.c (thr_try_catch_cmd): Likewise.
9592         * top.c (execute_command_to_string): pass term_out parameter
9593         to construct the string_file for the command output.
9594         * ui-file.c (term_cli_styling): New function (most code moved
9595         from utils.c can_emit_style_escape).
9596         (string_file::string_file, string_file::can_emit_style_escape,
9597         stdio_file::can_emit_style_escape, tee_file::term_out,
9598         tee_file::can_emit_style_escape): New functions.
9599
9600 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9601
9602         * NEWS: Mention the new set|show may-call-functions.
9603         * infcall.c (may_call_functions_p): New variable.
9604         (show_may_call_functions_p): New function.
9605         (call_function_by_hand_dummy): Throws an error if not
9606         may-call-functions.
9607         (_initialize_infcall): Call add_setshow_boolean_cmd for
9608         may-call-functions.
9609
9610 2019-04-25  Keith Seitz  <keiths@redhat.com>
9611
9612         PR c++/24367
9613         * cp-support.c (inspect_type): Don't attempt substitutions
9614         of symbol with the same name.
9615
9616 2019-04-25  Tom Tromey  <tromey@adacore.com>
9617
9618         PR gdb/24475:
9619         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9620         static.
9621
9622 2019-04-25  Tom Tromey  <tromey@adacore.com>
9623
9624         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9625         rvalue reference.
9626         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9627         (gdb_xml_parser::parse): Use std::move.
9628         * python/python-internal.h (gdbpy_convert_exception): Take a const
9629         reference.
9630         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9631         std::move.
9632         * python/py-utils.c (gdbpy_convert_exception): Take a const
9633         reference.
9634         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9635         Use std::move.
9636         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9637         Use std::move.
9638         * mi/mi-main.c (mi_print_exception): Take a const reference.
9639         * main.c (handle_command_errors): Take a const reference.
9640         * linespec.c (parse_linespec): Use std::move.
9641         * infcall.c (run_inferior_call): Use std::move.
9642         (call_function_by_hand_dummy): Use std::move.
9643         * exec.c (try_open_exec_file): Use std::move.
9644         * exceptions.h (exception_print, exception_fprintf)
9645         (exception_print_same): Update.
9646         * exceptions.c (print_exception, exception_print)
9647         (exception_fprintf, exception_print_same): Change parameters to
9648         const reference.
9649         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9650         * common/new-op.c: Use std::move.
9651         * common/common-exceptions.h (struct gdb_exception): Add move
9652         constructor.
9653         (struct gdb_exception_error, struct gdb_exception_quit, struct
9654         gdb_quit_bad_alloc): Change constructor to move constructor.
9655         (throw_exception): Change parameter to rvalue reference.
9656         * common/common-exceptions.c (throw_exception): Take rvalue
9657         reference.
9658         * cli/cli-interp.c (safe_execute_command): Use std::move.
9659         * breakpoint.c (insert_bp_location, location_to_sals): Use
9660         std::move.
9661
9662 2019-04-25  Tom Tromey  <tromey@adacore.com>
9663
9664         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9665         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9666         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9667         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9668         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9669         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9670         guile/scm-value.c: Use unpack.
9671         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9672         gdbscm_gdb_exception.
9673         (gdbscm_throw_gdb_exception): Likewise.
9674         (struct gdbscm_gdb_exception): New.
9675         (unpack): New function.
9676         (gdbscm_wrap): Use unpack.
9677
9678 2019-04-25  Tom Tromey  <tromey@adacore.com>
9679
9680         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9681         (gdb_rl_callback_handler): Use std::move.
9682         * common/common-exceptions.h (struct gdb_exception): Add move
9683         assignment operator.
9684         (throw_exception_sjlj): Change "exception" to const reference.
9685         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9686         (throw_exception_sjlj): Change "exception" to const reference.
9687
9688 2019-04-25  Tom Tromey  <tromey@adacore.com>
9689
9690         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9691         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9692         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9693         Update.
9694         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9695         Update.
9696         * mi/mi-interp.c (mi_interp::exec): Update.
9697         * linespec.c (parse_linespec): Update.
9698         * infcall.c (run_inferior_call): Update.
9699         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9700         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9701         (gdbscm_lookup_global_symbol): Update.
9702         * guile/scm-param.c (gdbscm_parameter_value): Update.
9703         * guile/scm-frame.c (gdbscm_frame_read_register)
9704         (gdbscm_frame_read_var): Update.
9705         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9706         * exec.c (try_open_exec_file): Update.
9707         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9708         (gdb_rl_callback_handler): Update.
9709         * common/common-exceptions.h (exception_none): Don't declare.
9710         * common/common-exceptions.c (exception_none): Don't define.
9711         (struct catcher) <exception>: Update.
9712         * cli/cli-interp.c (safe_execute_command): Update.
9713         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9714
9715 2019-04-25  Ali Tamur  <tamur@google.com>
9716
9717         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9718         (read_attribute_value): Likewise.
9719         (dwarf2_read_addr_index): Update comment.
9720         (read_str_index): Add DW_FORM_strx.
9721         (dwarf2_string_attr): Likewise.
9722         (dwarf2_const_value_attr): Likewise.
9723         (dump_die_shallow): Likewise.
9724         (dwarf2_fetch_constant_bytes): Likewise.
9725         (skip_form_bytes): Likewise.
9726         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9727
9728 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9729
9730         PR corefiles/11608
9731         PR corefiles/18187
9732         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9733         OFFSET.  Verify if current mapping contains an ELF header.
9734         (linux_find_memory_regions_full): Adjust call to
9735         dump_mapping_p.
9736
9737 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9738             Kang Li <kanglictf@gmail.com>
9739
9740         PR gdb/21600
9741
9742         * dwarf2-frame.c (read_initial_length): Be consistent about using
9743         unsigned representation of length.
9744         (decode_frame_entry_1): Likewise.  Check for wraparound of
9745         end pointer as well as buffer overflow.
9746
9747 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
9748
9749         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9750         "vq".
9751
9752 2019-04-24  Tom Tromey  <tromey@adacore.com>
9753
9754         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9755
9756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9757
9758         * s12z-tdep.c (s12z_unwind_pc): Delete.
9759         (s12z_unwind_sp): Delete.
9760         (s12z_gdbarch_init): Don't register deleted functions with
9761         gdbarch.
9762
9763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9764
9765         * rl78-tdep.c (rl78_unwind_sp): Delete.
9766         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9767
9768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9769
9770         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9771         (xstormy16_unwind_pc): Delete.
9772         (xstormy16_dummy_id): Delete.
9773         (xstormy16_gdbarch_init): Don't register deleted functions with
9774         gdbarch.
9775
9776 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * vax-tdep.c (vax_unwind_pc): Delete.
9779         (vax_gdbarch_init): Don't register deleted function with gdbarch.
9780
9781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9782
9783         * v850-tdep.c (v850_unwind_sp): Delete.
9784         (v850_unwind_pc): Delete.
9785         (v850_dummy_id): Delete.
9786         (v850_gdbarch_init): Don't register deleted functions with
9787         gdbarch.
9788
9789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9792         (tilegx_unwind_pc): Delete.
9793         (tilegx_unwind_dummy_id): Delete.
9794         (tilegx_gdbarch_init): Don't register deleted functions with
9795         gdbarch.
9796
9797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9798
9799         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9800         (tic6x_dummy_id): Delete.
9801         (tic6x_gdbarch_init): Don't register deleted functions with
9802         gdbarch.
9803
9804 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9805
9806         * sparc-tdep.c (sparc_unwind_pc): Delete.
9807         (sparc32_gdbarch_init): Don't register deleted function with
9808         gdbarch.
9809
9810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9811
9812         * sh-tdep.c (sh_unwind_sp): Delete.
9813         (sh_unwind_pc): Delete.
9814         (sh_dummy_id): Delete.
9815         (sh_gdbarch_init): Don't register deleted functions with
9816         gdbarch.
9817
9818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9819
9820         * score-tdep.c (score_unwind_sp): Delete.
9821         (score_unwind_pc): Delete.
9822         (score_dummy_id): Delete.
9823         (score_gdbarch_init): Don't register deleted functions with
9824         gdbarch.
9825
9826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9827
9828         * rx-tdep.c (rx_unwind_pc): Delete.
9829         (rx_unwind_sp): Delete.
9830         (rx_dummy_id): Delete.
9831         (rx_gdbarch_init): Don't register deleted functions with
9832         gdbarch.  Update comment.
9833
9834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9835
9836         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9837         (rs6000_dummy_id): Delete.
9838         (rs6000_gdbarch_init): Don't register deleted functions with
9839         gdbarch.
9840
9841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9842
9843         * or1k-tdep.c (or1k_dummy_id): Delete.
9844         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9845
9846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9847
9848         * nios2-tdep.c (nios2_dummy_id): Delete.
9849         (nios2_unwind_sp): Delete.
9850         (nios2_gdbarch_init): Don't register deleted functions with
9851         gdbarch.
9852
9853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9854
9855         * nds32-tdep.c (nds32_dummy_id): Delete.
9856         (nds32_unwind_pc): Delete.
9857         (nds32_unwind_sp): Delete.
9858         (nds32_gdbarch_init): Don't register deleted functions with
9859         gdbarch.
9860
9861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * msp430-tdep.c (msp430_unwind_pc): Delete.
9864         (msp430_unwind_sp): Delete.
9865         (msp430_dummy_id): Delete.
9866         (msp430_gdbarch_init): Don't register deleted functions with
9867         gdbarch.
9868
9869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * moxie-tdep.c (moxie_unwind_sp): Delete.
9872         (moxie_unwind_pc): Delete.
9873         (moxie_dummy_id): Delete.
9874         (moxie_gdbarch_init): Don't register deleted functions with
9875         gdbarch.
9876
9877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9878
9879         * mn10300-tdep.c (mn10300_dummy_id): Delete.
9880         (mn10300_unwind_pc): Delete.
9881         (mn10300_unwind_sp): Delete.
9882         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9883         mn10300_unwind_sp.
9884         (mn10300_frame_unwind_init): Don't register deleted functions with
9885         gdbarch.
9886
9887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9888
9889         * mep-tdep.c (mep_unwind_pc): Delete.
9890         (mep_unwind_sp): Delete.
9891         (mep_dummy_id): Delete.
9892         (mep_gdbarch_init): Don't register deleted functions with
9893         gdbarch.
9894
9895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9896
9897         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9898         (m68hc11_unwind_sp): Delete.
9899         (m68hc11_gdbarch_init): Don't register deleted functions with
9900         gdbarch.
9901
9902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9903
9904         * m32r-tdep.c (m32r_unwind_sp): Delete.
9905         (m32r_unwind_pc): Delete.
9906         (m32r_dummy_id): Delete.
9907         (m32r_gdbarch_init): Don't register deleted functions with
9908         gdbarch.
9909
9910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * m32c-tdep.c (m32c_unwind_pc): Delete.
9913         (m32c_unwind_sp): Delete.
9914         (m32c_dummy_id): Delete.
9915         (m32c_gdbarch_init): Don't register deleted functions with
9916         gdbarch.
9917
9918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9919
9920         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9921         (lm32_unwind_pc): Delete.
9922         (lm32_dummy_id): Delete.
9923         (lm32_gdbarch_init): Don't register deleted functions with
9924         gdbarch.
9925
9926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9927
9928         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9929         (iq2000_unwind_pc): Delete.
9930         (iq2000_dummy_id): Delete.
9931         (iq2000_gdbarch_init): Don't register deleted functions with
9932         gdbarch.
9933
9934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9935
9936         * nds32-tdep.c (nds32_type_align): Delete.
9937         (nds32_push_dummy_call): Use type_align instead.
9938
9939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9940
9941         * arm-tdep.c (arm_type_align): Only handle vector override case.
9942         (arm_push_dummy_call): Use type_align.
9943         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9944
9945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9946
9947         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9948         case.
9949         (pass_on_stack): Use type_align.
9950         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9951         function.
9952
9953 2019-04-23  Tom Tromey  <tromey@adacore.com>
9954
9955         * dwarf2read.c (line_header::file_name_at): Remove unused
9956         overload.
9957
9958 2019-04-23  Tom de Vries  <tdevries@suse.de>
9959
9960         PR gdb/24438
9961         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9962         invocation.
9963
9964
9965 2019-03-27  Ali Tamur  <tamur@google.com>
9966
9967         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9968         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9969         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9970         (dwarf_expr_context::get_addr_index): Likewise
9971         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9972         (symbol_needs_eval_context::get_addr_index): Likewise
9973         (disassemble_dwarf_expression): Add DW_OP_addrx
9974         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9975         (read_cutu_die_from_dwo): Update comment
9976         (skip_one_die): Add DW_FORM_addrx
9977         (read_attribute_value): Likewise
9978         (var_decode_location): Add DW_OP_addrx
9979         (dwarf2_const_value_attr): Add DW_FORM_addrx
9980         (dump_die_shallow): Likewise
9981         (dwarf2_fetch_constant_bytes): Likewise
9982         (decode_locdesc): Add DW_OP_addrx
9983         (skip_form_bytes): Add DW_FORM_addrx
9984
9985 2019-04-22  Ali Tamur  <tamur@google.com>
9986
9987         * MAINTAINERS (Write After Approval): Add self.
9988
9989 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9990
9991         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9992         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9993         (open_symbol_file_object): Likewise.
9994         (svr4_default_sos): Add info parameter.
9995         (svr4_read_so_list): Likewise.
9996         (svr4_current_sos_direct): Adjust functions calls to pass down
9997         info.
9998         (svr4_current_sos_1): Add info parameter.
9999         (svr4_current_sos): Call get_svr4_info, pass info down to
10000         svr4_current_sos_1.
10001         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10002         get_svr4_info.
10003         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10004         get_svr4_info.
10005         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10006         to get_svr4_info.
10007         (probes_table_remove_objfile_probes): Likewise.
10008         (register_solib_event_probe): Add info parameter.
10009         (solist_update_incremental): Pass info parameter down to
10010         svr4_read_so_list.
10011         (disable_probes_interface): Add info parameter.
10012         (svr4_handle_solib_event): Pass current_program_space to
10013         get_svr4_info.  Adjust disable_probes_interface cleanup.
10014         (svr4_create_probe_breakpoints): Add info parameter, pass it
10015         down to register_solib_event_probe.
10016         (svr4_create_solib_event_breakpoints): Add info parameter,
10017         pass it down to svr4_create_probe_breakpoints.
10018         (enable_break): Pass info down to
10019         svr4_create_solib_event_breakpoints.
10020         (svr4_solib_create_inferior_hook): Pass current_program_space to
10021         get_svr4_info.
10022         (svr4_clear_solib): Likewise.
10023
10024 2019-04-22  Pedro Alves  <palves@redhat.com>
10025
10026         * solib-svr4.c (svr4_free_objfile_observer): New.
10027         (probe_and_action::objfile): New field.
10028         (probes_table_htab_remove_objfile_probes)
10029         (probes_table_remove_objfile_probes): New functions.
10030         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10031         in the new probe_and_action.  Don't store the probe in 'lookup'.
10032         (svr4_create_probe_breakpoints): Pass objfile to
10033         register_solib_event_probe.
10034         (_initialize_svr4_solib): Register a free_objfile observer.
10035
10036 2019-04-19  Tom Tromey  <tom@tromey.com>
10037
10038         * common/queue.h: Remove.
10039
10040 2019-04-19  Tom Tromey  <tom@tromey.com>
10041
10042         * event-loop.c: Don't include "common/queue.h".
10043
10044 2019-04-19  Tom Tromey  <tom@tromey.com>
10045
10046         * remote.c (remote_target): Use delete.
10047         * remote-notif.h: Include <list>, not "common/queue.h".
10048         (notif_client_p): Remove typedef.
10049         (remote_notif_state): Add constructor, destructor, initializer.
10050         <notif_queue>: Now a std::list.
10051         (remote_notif_state_xfree): Don't declare.
10052         * remote-notif.c (remote_notif_process, handle_notification)
10053         (remote_notif_state_allocate): Update.
10054         (~remote_notif_state): Rename from remote_notif_state_xfree.
10055
10056 2019-04-19  Tom Tromey  <tom@tromey.com>
10057
10058         * symfile.c (reread_symbols): Update.
10059         * objfiles.c (objfile_register_static_link)
10060         (objfile_lookup_static_link): Update
10061         (~objfile) Don't delete static_links.
10062         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10063
10064 2019-04-19  Tom Tromey  <tom@tromey.com>
10065
10066         * type-stack.h (struct type_stack) <insert>: Constify string.
10067         * type-stack.c (type_stack::insert): Constify string.
10068         * gdbtypes.h (lookup_template_type): Update.
10069         (address_space_name_to_int): Update.
10070         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10071         const.
10072         (lookup_template_type): Make name const.
10073         * c-exp.y: Update rules.
10074         (lex_one_token, classify_name, classify_inner_name)
10075         (c_print_token): Update.
10076         * p-exp.y: Update rules.
10077         (yylex): Update.
10078         * f-exp.y: Update rules.
10079         (yylex): Update.
10080         * d-exp.y: Update rules.
10081         (lex_one_token, classify_name, classify_inner_name): Update.
10082         * parse.c (write_dollar_variable, copy_name): Return std::string.
10083         * parser-defs.h (copy_name): Change return type.
10084         * m2-exp.y: Update rules.
10085         (yylex): Update.
10086         * go-exp.y (lex_one_token): Update.
10087         Update rules.
10088         (classify_unsafe_function, classify_packaged_name)
10089         (classify_name, yylex): Update.
10090
10091 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10092
10093         * configure.ac: add --enable-source-highlight switch.
10094         * configure: Regenerate.
10095         * top.c (print_gdb_version): plumb --enable-source-highlight
10096         status to "show configuration".
10097
10098 2019-04-19  Tom Tromey  <tromey@adacore.com>
10099
10100         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10101         Check ADA_TYPE_P.
10102         (empty_record, ada_template_to_fixed_record_type_1)
10103         (template_to_static_fixed_type)
10104         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10105         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10106         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10107         macros.
10108
10109 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10110
10111         PR symtab/24423:
10112         * source.c (print_source_lines_base): Advance "iter" when a
10113         control character is seen.
10114
10115 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10116
10117         * inferior.h (struct infcall_suspend_state_deleter):
10118         Catch exception in destructor to avoid crash.
10119
10120 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10121
10122         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10123         close to the add_com "shell".
10124
10125 2019-04-18  Tom Tromey  <tromey@adacore.com>
10126
10127         * process-stratum-target.h (class process_stratum_target)
10128         <stratum>: Add "final".
10129
10130 2019-04-17  Tom Tromey  <tromey@adacore.com>
10131
10132         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10133         against nullptr before use.
10134
10135 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10136
10137         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10138
10139 2019-04-17  Jim Wilson  <jimw@sifive.com>
10140             Andrew Burgess  <andrew.burgess@embecosm.com>
10141
10142         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10143         code read might fail, assume 4-byte breakpoint in that case.
10144
10145 2019-04-15  Leszek Swirski  <leszeks@google.com>
10146
10147         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10148         rather than a hand-rolled POD check when checking for forced MEMORY
10149         classification.
10150
10151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10152
10153         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10154         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10155         function.
10156         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10157         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10158         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10159         declaration.
10160
10161 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10162
10163         * aarch64-linux-nat.c
10164         (aarch64_linux_nat_target::thread_architecture): Add override.
10165         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10166         each VQ.
10167
10168 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10169
10170         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10171
10172 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10173
10174         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10175         target types of size 96-bits, add some additional comments, and
10176         check that the builtin type we found was the correct size.
10177
10178 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10179
10180         * utils.c (prompt_for_continue): Don't restore the styling at the
10181         end, as applied_style has the wrong value.  This fixes styling in
10182         long lists of file names that are interrupted by the "Continue?"
10183         prompt.
10184
10185 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10186
10187         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10188         * c-lang.c (c_language_defn): Likewise.
10189         (cplus_language_defn): Likewise.
10190         (asm_language_defn): Likewise.
10191         (minimal_language_defn): Likewise.
10192         * d-lang.c (d_language_defn): Likewise.
10193         * f-lang.c (f_language_defn): Likewise.
10194         * go-lang.c (go_language_defn): Likewise.
10195         * language.c (unknown_language_defn): Likewise.
10196         (auto_language_defn): Likewise.
10197         * language.h (struct language_defn): Remove la_magic field.
10198         (LANG_MAGIC): Delete.
10199         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10200         * objc-lang.c (objc_language_defn): Likewise.
10201         * opencl-lang.c (opencl_language_defn): Likewise.
10202         * p-lang.c (pascal_language_defn): Likewise.
10203         * rust-lang.c (rust_language_defn): Likewise.
10204
10205 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10206
10207         * riscv-tdep.c (riscv_type_align): New function.
10208         (riscv_type_alignment): Delete.
10209         (riscv_arg_location): Use 'type_align'.
10210         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10211
10212 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10213
10214         * gdbtypes.c (type_align): A struct with no non-static fields also
10215         has alignment of 1.
10216
10217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10220         component to 0.
10221         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10222         member.
10223         (riscv_struct_info::analyse): New implementation using new
10224         analyse_inner member function.
10225         (riscv_struct_info::field_offset): New member function.
10226         (riscv_struct_info::m_offsets): New member variable.
10227         (riscv_struct_info::analyse_inner): New private member function,
10228         takes the old implementation of riscv_struct_info::analyse but
10229         extended to track field offsets.
10230         (riscv_call_arg_struct): Update the struct folding special cases
10231         to handle cases where empty C++ structs, which are non-zero
10232         length, are found.
10233         (riscv_arg_location): Initialise the length of each location, a
10234         non-zero length now indicates the location is in use.
10235         (riscv_push_dummy_call): Allow for the first location having a
10236         non-zero offset when setting up arguments.
10237         (riscv_return_value): Likewise, but for return values.
10238
10239 2019-04-11  Tom Tromey  <tromey@adacore.com>
10240
10241         * utils.c (internal_vproblem): Make "msg" const.
10242
10243 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10244
10245         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10246         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10247         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10248         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10249
10250 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10251
10252         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10253         function.
10254         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10255         of amd64_collect_native_gregset.
10256         (amd64_linux_nat_target::store_registers): Likewise.
10257
10258 2019-04-10  Tom Tromey  <tom@tromey.com>
10259
10260         * symtab.c (lookup_global_symbol_from_objfile)
10261         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10262         * objfiles.h (class separate_debug_iterator): New.
10263         (class separate_debug_range): New.
10264         (struct objfile) <separate_debug_objfiles>: New method.
10265         (objfile_separate_debug_iterate): Don't declare.
10266         * objfiles.c (separate_debug_iterator::operator++): Rename from
10267         objfile_separate_debug_iterate.
10268         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10269         iterator.
10270         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10271         iterator.
10272
10273 2019-04-10  Tom Tromey  <tom@tromey.com>
10274
10275         * symfile.c (reread_symbols): Remove old comment.
10276         * objfiles.c (free_all_objfiles): Fix a typo.
10277
10278 2019-04-10  Tom Tromey  <tom@tromey.com>
10279
10280         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10281         * minsyms.c (lookup_minimal_symbol): Use foreach.
10282         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10283         (lookup_minimal_symbol_solib_trampoline): Likewise.
10284         * symfile.c (reread_symbols): Use foreach.
10285
10286 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10287             Tom Tromey  <tromey@adacore.com>
10288
10289         PR rust/24414:
10290         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10291         (rust_lex_int_test): Change "value" to be LONGEST.
10292         (rust_lex_tests): Add test for long integer literal.
10293
10294 2019-04-09  Tom Tromey  <tromey@adacore.com>
10295
10296         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10297         to bool.
10298         (extended_remote_target::attach): Update.
10299         (remote_target::remote_notice_new_inferior): Update.
10300         (remote_target::add_current_inferior_and_thread): Update.
10301         * inferior.c (exit_inferior_1): Use "false".
10302         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10303
10304 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10305
10306         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10307         the "start" command.
10308
10309 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10310
10311         * python/py-inferior.c (infpy_thread_from_thread_handle):
10312         Adjust comments to reflect renaming of thread_from_thread_handle
10313         to thread_from_handle.  Adjust keywords.  Fix type error message.
10314         (inferior_object_methods): Add thread_from_handle.  Retain
10315         thread_from_thread_handle, but mark it as deprecated.
10316
10317 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10318
10319         * gdbthread.h (find_thread_by_handle): Revise declaration.
10320         * thread.c (find_thread_by_handle): Likewise.  Adjust
10321         implementation too.
10322         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10323         support for buffer objects as handles.
10324
10325 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10326
10327         * python/py-infthread.c (thpy_thread_handle): New function.
10328         (thread_object_methods): Register thpy_thread_handle.
10329
10330 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10331
10332         * gdbthread.h (thread_to_thread_handle): Declare.
10333         * thread.c (gdbtypes.h): Include.
10334         (thread_to_thread_handle): New function.
10335
10336         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10337         (target_thread_info_to_thread_handle): Declare.
10338         * target.c (target_thread_info_to_thread_handle): New function.
10339         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10340         * target-delegates.c: Regenerate.
10341
10342         * linux-thread-db.c (class thread_db_target): Add method
10343         thread_info_to_thread_handle.
10344         (thread_db_target::thread_info_to_thread_handle): Define.
10345         * remote.c (class remote_target): Add new method
10346         thread_info_to_thread_handle.
10347         (remote_target::thread_info_to_thread_handle): Define.
10348
10349 2019-04-08  Pedro Alves  <palves@redhat.com>
10350
10351         * common/common-exceptions.c (throw_exception): Don't create
10352         named object to throw; throw directly.
10353         (throw_it): Likewise.  Don't initialize gdb_exception::message
10354         here, with new; pass FMT and AP to the ctor instead.
10355         * common/common-exceptions.h: Include <string>.
10356         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10357         const char *, va_list)): New ctor.  Use std::make_shared.
10358         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10359         errors)): Delete.
10360         (gdb_exception_error::gdb_exception_error(enum errors, const char
10361         *, va_list)): New.
10362         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10363         Add assertion.
10364         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10365         errors)): Delete.
10366         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10367         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10368         Add assertion.
10369
10370 2019-04-08  Tom Tromey  <tom@tromey.com>
10371
10372         * valops.c (value_rtti_indirect_type): Replace throw_exception
10373         with throw.
10374         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10375         with throw.
10376         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10377         throw.
10378         * target.c (target_translate_tls_address): Replace throw_exception
10379         with throw.
10380         * stack.c (frame_apply_command_count): Replace throw_exception
10381         with throw.
10382         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10383         throw.
10384         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10385         with throw.
10386         * rs6000-tdep.c (rs6000_frame_cache)
10387         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10388         * remote.c: Replace throw_exception with throw.
10389         * record-full.c (record_full_message, record_full_wait_1)
10390         (record_full_restore): Replace throw_exception with throw.
10391         * record-btrace.c:
10392         (get_thread_current_frame_id, record_btrace_start_replaying)
10393         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10394         (cmd_record_btrace_start): Replace throw_exception with throw.
10395         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10396         throw.
10397         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10398         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10399         * linespec.c:
10400         (find_linespec_symbols): Replace throw_exception with throw.
10401         * infrun.c (displaced_step_prepare, resume): Replace
10402         throw_exception with throw.
10403         * infcmd.c (post_create_inferior): Replace throw_exception with
10404         throw.
10405         * inf-loop.c (inferior_event_handler): Replace throw_exception
10406         with throw.
10407         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10408         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10409         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10410         (get_prev_frame_always, get_frame_pc_if_available)
10411         (get_frame_address_in_block_if_available, get_frame_language):
10412         Replace throw_exception with throw.
10413         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10414         throw_exception with throw.
10415         * eval.c (fetch_subexp_value, evaluate_var_value)
10416         (evaluate_funcall, evaluate_subexp_standard): Replace
10417         throw_exception with throw.
10418         * dwarf2loc.c (call_site_find_chain)
10419         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10420         Replace throw_exception with throw.
10421         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10422         with throw.
10423         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10424         throw.
10425         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10426         * completer.c (complete_line_internal): Replace throw_exception
10427         with throw.
10428         * compile/compile-object-run.c (compile_object_run): Replace
10429         throw_exception with throw.
10430         * cli/cli-script.c (process_next_line): Replace throw_exception
10431         with throw.
10432         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10433         (btrace_enable, btrace_maint_update_pt_packets): Replace
10434         throw_exception with throw.
10435         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10436         throw_exception with throw.
10437         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10438         throw_exception with throw.
10439         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10440         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10441         * aarch64-tdep.c (aarch64_make_prologue_cache)
10442         (aarch64_make_stub_cache): Replace throw_exception with throw.
10443
10444 2019-04-08  Tom Tromey  <tom@tromey.com>
10445
10446         * common/common-exceptions.c (throw_exception): Rename from
10447         throw_exception_cxx.  Remove old copy.  Make argument const.
10448         (throw_it): Create and throw exception objects directly.
10449         * common/common-exceptions.h (throw_exception): Make argument
10450         const.
10451         (struct gdb_exception_error): Add constructor.
10452         (struct gdb_exception_quit): Add constructor.
10453
10454 2019-04-08  Tom Tromey  <tom@tromey.com>
10455
10456         * common/common-exceptions.h (exception_rethrow): Don't declare.
10457         (TRY_SJLJ): Update comment.
10458         (TRY, CATCH, END_CATCH): Remove.
10459         * common/common-exceptions.c (exception_rethrow): Remove.
10460
10461 2019-04-08  Tom Tromey  <tom@tromey.com>
10462
10463         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10464         Remove.
10465         (gdb_exception_error): Rename from
10466         gdb_exception_RETURN_MASK_ERROR.
10467         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10468         (gdb_quit_bad_alloc): Update.
10469         * aarch64-tdep.c: Update.
10470         * ada-lang.c: Update.
10471         * ada-typeprint.c: Update.
10472         * ada-valprint.c: Update.
10473         * amd64-tdep.c: Update.
10474         * arch-utils.c: Update.
10475         * break-catch-throw.c: Update.
10476         * breakpoint.c: Update.
10477         * btrace.c: Update.
10478         * c-varobj.c: Update.
10479         * cli/cli-cmds.c: Update.
10480         * cli/cli-interp.c: Update.
10481         * cli/cli-script.c: Update.
10482         * common/common-exceptions.c: Update.
10483         * common/new-op.c: Update.
10484         * common/selftest.c: Update.
10485         * compile/compile-c-symbols.c: Update.
10486         * compile/compile-cplus-symbols.c: Update.
10487         * compile/compile-object-load.c: Update.
10488         * compile/compile-object-run.c: Update.
10489         * completer.c: Update.
10490         * corelow.c: Update.
10491         * cp-abi.c: Update.
10492         * cp-support.c: Update.
10493         * cp-valprint.c: Update.
10494         * darwin-nat.c: Update.
10495         * disasm-selftests.c: Update.
10496         * dtrace-probe.c: Update.
10497         * dwarf-index-cache.c: Update.
10498         * dwarf-index-write.c: Update.
10499         * dwarf2-frame-tailcall.c: Update.
10500         * dwarf2-frame.c: Update.
10501         * dwarf2loc.c: Update.
10502         * dwarf2read.c: Update.
10503         * eval.c: Update.
10504         * event-loop.c: Update.
10505         * event-top.c: Update.
10506         * exec.c: Update.
10507         * f-valprint.c: Update.
10508         * fbsd-tdep.c: Update.
10509         * frame-unwind.c: Update.
10510         * frame.c: Update.
10511         * gdbtypes.c: Update.
10512         * gnu-v3-abi.c: Update.
10513         * guile/guile-internal.h: Update.
10514         * guile/scm-block.c: Update.
10515         * guile/scm-breakpoint.c: Update.
10516         * guile/scm-cmd.c: Update.
10517         * guile/scm-disasm.c: Update.
10518         * guile/scm-frame.c: Update.
10519         * guile/scm-lazy-string.c: Update.
10520         * guile/scm-math.c: Update.
10521         * guile/scm-param.c: Update.
10522         * guile/scm-ports.c: Update.
10523         * guile/scm-pretty-print.c: Update.
10524         * guile/scm-symbol.c: Update.
10525         * guile/scm-symtab.c: Update.
10526         * guile/scm-type.c: Update.
10527         * guile/scm-value.c: Update.
10528         * i386-linux-tdep.c: Update.
10529         * i386-tdep.c: Update.
10530         * inf-loop.c: Update.
10531         * infcall.c: Update.
10532         * infcmd.c: Update.
10533         * infrun.c: Update.
10534         * jit.c: Update.
10535         * language.c: Update.
10536         * linespec.c: Update.
10537         * linux-fork.c: Update.
10538         * linux-nat.c: Update.
10539         * linux-tdep.c: Update.
10540         * linux-thread-db.c: Update.
10541         * main.c: Update.
10542         * mi/mi-cmd-break.c: Update.
10543         * mi/mi-cmd-stack.c: Update.
10544         * mi/mi-interp.c: Update.
10545         * mi/mi-main.c: Update.
10546         * objc-lang.c: Update.
10547         * p-valprint.c: Update.
10548         * parse.c: Update.
10549         * ppc-linux-tdep.c: Update.
10550         * printcmd.c: Update.
10551         * python/py-arch.c: Update.
10552         * python/py-breakpoint.c: Update.
10553         * python/py-cmd.c: Update.
10554         * python/py-finishbreakpoint.c: Update.
10555         * python/py-frame.c: Update.
10556         * python/py-framefilter.c: Update.
10557         * python/py-gdb-readline.c: Update.
10558         * python/py-inferior.c: Update.
10559         * python/py-infthread.c: Update.
10560         * python/py-lazy-string.c: Update.
10561         * python/py-linetable.c: Update.
10562         * python/py-objfile.c: Update.
10563         * python/py-param.c: Update.
10564         * python/py-prettyprint.c: Update.
10565         * python/py-progspace.c: Update.
10566         * python/py-record-btrace.c: Update.
10567         * python/py-record.c: Update.
10568         * python/py-symbol.c: Update.
10569         * python/py-type.c: Update.
10570         * python/py-unwind.c: Update.
10571         * python/py-utils.c: Update.
10572         * python/py-value.c: Update.
10573         * python/python.c: Update.
10574         * record-btrace.c: Update.
10575         * record-full.c: Update.
10576         * remote-fileio.c: Update.
10577         * remote.c: Update.
10578         * riscv-tdep.c: Update.
10579         * rs6000-aix-tdep.c: Update.
10580         * rs6000-tdep.c: Update.
10581         * rust-exp.y: Update.
10582         * rust-lang.c: Update.
10583         * s390-tdep.c: Update.
10584         * selftest-arch.c: Update.
10585         * solib-dsbt.c: Update.
10586         * solib-frv.c: Update.
10587         * solib-spu.c: Update.
10588         * solib-svr4.c: Update.
10589         * solib.c: Update.
10590         * sparc64-linux-tdep.c: Update.
10591         * stack.c: Update.
10592         * symfile-mem.c: Update.
10593         * symmisc.c: Update.
10594         * target.c: Update.
10595         * thread.c: Update.
10596         * top.c: Update.
10597         * tracefile-tfile.c: Update.
10598         * tui/tui.c: Update.
10599         * typeprint.c: Update.
10600         * unittests/cli-utils-selftests.c: Update.
10601         * unittests/parse-connection-spec-selftests.c: Update.
10602         * valops.c: Update.
10603         * valprint.c: Update.
10604         * value.c: Update.
10605         * varobj.c: Update.
10606         * windows-nat.c: Update.
10607         * x86-linux-nat.c: Update.
10608         * xml-support.c: Update.
10609
10610 2019-04-08  Tom Tromey  <tom@tromey.com>
10611
10612         * xml-support.c: Use C++ exception handling.
10613         * x86-linux-nat.c: Use C++ exception handling.
10614         * windows-nat.c: Use C++ exception handling.
10615         * varobj.c: Use C++ exception handling.
10616         * value.c: Use C++ exception handling.
10617         * valprint.c: Use C++ exception handling.
10618         * valops.c: Use C++ exception handling.
10619         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10620         handling.
10621         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10622         * typeprint.c: Use C++ exception handling.
10623         * tui/tui.c: Use C++ exception handling.
10624         * tracefile-tfile.c: Use C++ exception handling.
10625         * top.c: Use C++ exception handling.
10626         * thread.c: Use C++ exception handling.
10627         * target.c: Use C++ exception handling.
10628         * symmisc.c: Use C++ exception handling.
10629         * symfile-mem.c: Use C++ exception handling.
10630         * stack.c: Use C++ exception handling.
10631         * sparc64-linux-tdep.c: Use C++ exception handling.
10632         * solib.c: Use C++ exception handling.
10633         * solib-svr4.c: Use C++ exception handling.
10634         * solib-spu.c: Use C++ exception handling.
10635         * solib-frv.c: Use C++ exception handling.
10636         * solib-dsbt.c: Use C++ exception handling.
10637         * selftest-arch.c: Use C++ exception handling.
10638         * s390-tdep.c: Use C++ exception handling.
10639         * rust-lang.c: Use C++ exception handling.
10640         * rust-exp.y: Use C++ exception handling.
10641         * rs6000-tdep.c: Use C++ exception handling.
10642         * rs6000-aix-tdep.c: Use C++ exception handling.
10643         * riscv-tdep.c: Use C++ exception handling.
10644         * remote.c: Use C++ exception handling.
10645         * remote-fileio.c: Use C++ exception handling.
10646         * record-full.c: Use C++ exception handling.
10647         * record-btrace.c: Use C++ exception handling.
10648         * python/python.c: Use C++ exception handling.
10649         * python/py-value.c: Use C++ exception handling.
10650         * python/py-utils.c: Use C++ exception handling.
10651         * python/py-unwind.c: Use C++ exception handling.
10652         * python/py-type.c: Use C++ exception handling.
10653         * python/py-symbol.c: Use C++ exception handling.
10654         * python/py-record.c: Use C++ exception handling.
10655         * python/py-record-btrace.c: Use C++ exception handling.
10656         * python/py-progspace.c: Use C++ exception handling.
10657         * python/py-prettyprint.c: Use C++ exception handling.
10658         * python/py-param.c: Use C++ exception handling.
10659         * python/py-objfile.c: Use C++ exception handling.
10660         * python/py-linetable.c: Use C++ exception handling.
10661         * python/py-lazy-string.c: Use C++ exception handling.
10662         * python/py-infthread.c: Use C++ exception handling.
10663         * python/py-inferior.c: Use C++ exception handling.
10664         * python/py-gdb-readline.c: Use C++ exception handling.
10665         * python/py-framefilter.c: Use C++ exception handling.
10666         * python/py-frame.c: Use C++ exception handling.
10667         * python/py-finishbreakpoint.c: Use C++ exception handling.
10668         * python/py-cmd.c: Use C++ exception handling.
10669         * python/py-breakpoint.c: Use C++ exception handling.
10670         * python/py-arch.c: Use C++ exception handling.
10671         * printcmd.c: Use C++ exception handling.
10672         * ppc-linux-tdep.c: Use C++ exception handling.
10673         * parse.c: Use C++ exception handling.
10674         * p-valprint.c: Use C++ exception handling.
10675         * objc-lang.c: Use C++ exception handling.
10676         * mi/mi-main.c: Use C++ exception handling.
10677         * mi/mi-interp.c: Use C++ exception handling.
10678         * mi/mi-cmd-stack.c: Use C++ exception handling.
10679         * mi/mi-cmd-break.c: Use C++ exception handling.
10680         * main.c: Use C++ exception handling.
10681         * linux-thread-db.c: Use C++ exception handling.
10682         * linux-tdep.c: Use C++ exception handling.
10683         * linux-nat.c: Use C++ exception handling.
10684         * linux-fork.c: Use C++ exception handling.
10685         * linespec.c: Use C++ exception handling.
10686         * language.c: Use C++ exception handling.
10687         * jit.c: Use C++ exception handling.
10688         * infrun.c: Use C++ exception handling.
10689         * infcmd.c: Use C++ exception handling.
10690         * infcall.c: Use C++ exception handling.
10691         * inf-loop.c: Use C++ exception handling.
10692         * i386-tdep.c: Use C++ exception handling.
10693         * i386-linux-tdep.c: Use C++ exception handling.
10694         * guile/scm-value.c: Use C++ exception handling.
10695         * guile/scm-type.c: Use C++ exception handling.
10696         * guile/scm-symtab.c: Use C++ exception handling.
10697         * guile/scm-symbol.c: Use C++ exception handling.
10698         * guile/scm-pretty-print.c: Use C++ exception handling.
10699         * guile/scm-ports.c: Use C++ exception handling.
10700         * guile/scm-param.c: Use C++ exception handling.
10701         * guile/scm-math.c: Use C++ exception handling.
10702         * guile/scm-lazy-string.c: Use C++ exception handling.
10703         * guile/scm-frame.c: Use C++ exception handling.
10704         * guile/scm-disasm.c: Use C++ exception handling.
10705         * guile/scm-cmd.c: Use C++ exception handling.
10706         * guile/scm-breakpoint.c: Use C++ exception handling.
10707         * guile/scm-block.c: Use C++ exception handling.
10708         * guile/guile-internal.h: Use C++ exception handling.
10709         * gnu-v3-abi.c: Use C++ exception handling.
10710         * gdbtypes.c: Use C++ exception handling.
10711         * frame.c: Use C++ exception handling.
10712         * frame-unwind.c: Use C++ exception handling.
10713         * fbsd-tdep.c: Use C++ exception handling.
10714         * f-valprint.c: Use C++ exception handling.
10715         * exec.c: Use C++ exception handling.
10716         * event-top.c: Use C++ exception handling.
10717         * event-loop.c: Use C++ exception handling.
10718         * eval.c: Use C++ exception handling.
10719         * dwarf2read.c: Use C++ exception handling.
10720         * dwarf2loc.c: Use C++ exception handling.
10721         * dwarf2-frame.c: Use C++ exception handling.
10722         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10723         * dwarf-index-write.c: Use C++ exception handling.
10724         * dwarf-index-cache.c: Use C++ exception handling.
10725         * dtrace-probe.c: Use C++ exception handling.
10726         * disasm-selftests.c: Use C++ exception handling.
10727         * darwin-nat.c: Use C++ exception handling.
10728         * cp-valprint.c: Use C++ exception handling.
10729         * cp-support.c: Use C++ exception handling.
10730         * cp-abi.c: Use C++ exception handling.
10731         * corelow.c: Use C++ exception handling.
10732         * completer.c: Use C++ exception handling.
10733         * compile/compile-object-run.c: Use C++ exception handling.
10734         * compile/compile-object-load.c: Use C++ exception handling.
10735         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10736         * compile/compile-c-symbols.c: Use C++ exception handling.
10737         * common/selftest.c: Use C++ exception handling.
10738         * common/new-op.c: Use C++ exception handling.
10739         * cli/cli-script.c: Use C++ exception handling.
10740         * cli/cli-interp.c: Use C++ exception handling.
10741         * cli/cli-cmds.c: Use C++ exception handling.
10742         * c-varobj.c: Use C++ exception handling.
10743         * btrace.c: Use C++ exception handling.
10744         * breakpoint.c: Use C++ exception handling.
10745         * break-catch-throw.c: Use C++ exception handling.
10746         * arch-utils.c: Use C++ exception handling.
10747         * amd64-tdep.c: Use C++ exception handling.
10748         * ada-valprint.c: Use C++ exception handling.
10749         * ada-typeprint.c: Use C++ exception handling.
10750         * ada-lang.c: Use C++ exception handling.
10751         * aarch64-tdep.c: Use C++ exception handling.
10752
10753 2019-04-08  Tom Tromey  <tom@tromey.com>
10754
10755         * xml-support.c (gdb_xml_parser::parse): Update.
10756         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10757         * value.c (show_convenience): Update.
10758         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10759         (test_parse_flags_qcs): Update.
10760         * thread.c (thr_try_catch_cmd): Update.
10761         * target.c (target_translate_tls_address): Update.
10762         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10763         (info_frame_command_core, frame_apply_command_count): Update.
10764         * rust-exp.y (rust_lex_exception_test): Update.
10765         * riscv-tdep.c (riscv_print_one_register_info): Update.
10766         * remote.c (remote_target::enable_btrace): Update.
10767         * record-btrace.c (record_btrace_enable_warn): Update.
10768         * python/py-utils.c (gdbpy_convert_exception): Update.
10769         * printcmd.c (do_one_display, print_variable_and_value): Update.
10770         * mi/mi-main.c (mi_print_exception): Update.
10771         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10772         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10773         * linux-nat.c (linux_nat_target::attach): Update.
10774         * linux-fork.c (class scoped_switch_fork_info): Update.
10775         * infrun.c (displaced_step_prepare): Update.
10776         * infcall.c (call_function_by_hand_dummy): Update.
10777         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10778         * gnu-v3-abi.c (print_one_vtable): Update.
10779         * frame.c (get_prev_frame_always): Update.
10780         * f-valprint.c (info_common_command_for_block): Update.
10781         * exec.c (try_open_exec_file): Update.
10782         * exceptions.c (print_exception, exception_print)
10783         (exception_fprintf, exception_print_same): Update.
10784         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10785         * dwarf-index-cache.c (index_cache::store)
10786         (index_cache::lookup_gdb_index): Update.
10787         * darwin-nat.c (maybe_cache_shell): Update.
10788         * cp-valprint.c (cp_print_value_fields): Update.
10789         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10790         (gcc_cplus_symbol_address): Update.
10791         * compile/compile-c-symbols.c (gcc_convert_symbol)
10792         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10793         * common/selftest.c: Update.
10794         * common/common-exceptions.h (struct gdb_exception) <message>: Now
10795         a std::string.
10796         (exception_try_scope_entry, exception_try_scope_exit): Don't
10797         declare.
10798         (struct exception_try_scope): Remove.
10799         (TRY): Don't use exception_try_scope.
10800         (struct gdb_exception): Add constructor, operator=.
10801         <what>: New method.
10802         (struct gdb_exception_RETURN_MASK_ALL)
10803         (struct gdb_exception_RETURN_MASK_ERROR)
10804         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10805         (struct gdb_quit_bad_alloc): Update.
10806         * common/common-exceptions.c (exception_none): Change
10807         initializer.
10808         (struct catcher) <state, exception>: Initialize inline.
10809         <prev>: Remove member.
10810         (current_catcher): Remove.
10811         (catchers): New global.
10812         (exceptions_state_mc_init): Simplify.
10813         (catcher_pop): Remove.
10814         (exceptions_state_mc, exceptions_state_mc_catch): Update.
10815         (try_scope_depth, exception_try_scope_entry)
10816         (exception_try_scope_exit): Remove.
10817         (throw_exception_sjlj): Update.
10818         (exception_messages, exception_messages_size): Remove.
10819         (throw_it): Simplify.
10820         (gdb_exception_sliced_copy): Remove.
10821         (throw_exception_cxx): Update.
10822         * cli/cli-script.c (script_from_file): Update.
10823         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10824         Update.
10825         * ada-valprint.c (ada_val_print): Update.
10826         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10827         (create_excep_cond_exprs): Update.
10828
10829 2019-04-08  Tom Tromey  <tom@tromey.com>
10830
10831         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10832         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10833         (TRY, CATCH, END_CATCH): Remove some definitions.
10834         * common/common-exceptions.c: Don't use GDB_XCPT.
10835         (catcher_list_size): Remove.
10836         (throw_exception, throw_it): Simplify.
10837
10838 2019-04-05  Tom Tromey  <tom@tromey.com>
10839
10840         Revert the header-sorting patch.
10841         * ft32-tdep.c: Revert.
10842         * frv-tdep.c: Revert.
10843         * frv-linux-tdep.c: Revert.
10844         * frame.c: Revert.
10845         * frame-unwind.c: Revert.
10846         * frame-base.c: Revert.
10847         * fork-child.c: Revert.
10848         * findvar.c: Revert.
10849         * findcmd.c: Revert.
10850         * filesystem.c: Revert.
10851         * filename-seen-cache.h: Revert.
10852         * filename-seen-cache.c: Revert.
10853         * fbsd-tdep.c: Revert.
10854         * fbsd-nat.h: Revert.
10855         * fbsd-nat.c: Revert.
10856         * f-valprint.c: Revert.
10857         * f-typeprint.c: Revert.
10858         * f-lang.c: Revert.
10859         * extension.h: Revert.
10860         * extension.c: Revert.
10861         * extension-priv.h: Revert.
10862         * expprint.c: Revert.
10863         * exec.h: Revert.
10864         * exec.c: Revert.
10865         * exceptions.c: Revert.
10866         * event-top.c: Revert.
10867         * event-loop.c: Revert.
10868         * eval.c: Revert.
10869         * elfread.c: Revert.
10870         * dwarf2read.h: Revert.
10871         * dwarf2read.c: Revert.
10872         * dwarf2loc.c: Revert.
10873         * dwarf2expr.h: Revert.
10874         * dwarf2expr.c: Revert.
10875         * dwarf2-frame.c: Revert.
10876         * dwarf2-frame-tailcall.c: Revert.
10877         * dwarf-index-write.h: Revert.
10878         * dwarf-index-write.c: Revert.
10879         * dwarf-index-common.c: Revert.
10880         * dwarf-index-cache.h: Revert.
10881         * dwarf-index-cache.c: Revert.
10882         * dummy-frame.c: Revert.
10883         * dtrace-probe.c: Revert.
10884         * disasm.h: Revert.
10885         * disasm.c: Revert.
10886         * disasm-selftests.c: Revert.
10887         * dictionary.c: Revert.
10888         * dicos-tdep.c: Revert.
10889         * demangle.c: Revert.
10890         * dcache.h: Revert.
10891         * dcache.c: Revert.
10892         * darwin-nat.h: Revert.
10893         * darwin-nat.c: Revert.
10894         * darwin-nat-info.c: Revert.
10895         * d-valprint.c: Revert.
10896         * d-namespace.c: Revert.
10897         * d-lang.c: Revert.
10898         * ctf.c: Revert.
10899         * csky-tdep.c: Revert.
10900         * csky-linux-tdep.c: Revert.
10901         * cris-tdep.c: Revert.
10902         * cris-linux-tdep.c: Revert.
10903         * cp-valprint.c: Revert.
10904         * cp-support.c: Revert.
10905         * cp-namespace.c: Revert.
10906         * cp-abi.c: Revert.
10907         * corelow.c: Revert.
10908         * corefile.c: Revert.
10909         * continuations.c: Revert.
10910         * completer.h: Revert.
10911         * completer.c: Revert.
10912         * complaints.c: Revert.
10913         * coffread.c: Revert.
10914         * coff-pe-read.c: Revert.
10915         * cli-out.h: Revert.
10916         * cli-out.c: Revert.
10917         * charset.c: Revert.
10918         * c-varobj.c: Revert.
10919         * c-valprint.c: Revert.
10920         * c-typeprint.c: Revert.
10921         * c-lang.c: Revert.
10922         * buildsym.c: Revert.
10923         * buildsym-legacy.c: Revert.
10924         * build-id.h: Revert.
10925         * build-id.c: Revert.
10926         * btrace.c: Revert.
10927         * bsd-uthread.c: Revert.
10928         * breakpoint.h: Revert.
10929         * breakpoint.c: Revert.
10930         * break-catch-throw.c: Revert.
10931         * break-catch-syscall.c: Revert.
10932         * break-catch-sig.c: Revert.
10933         * blockframe.c: Revert.
10934         * block.c: Revert.
10935         * bfin-tdep.c: Revert.
10936         * bfin-linux-tdep.c: Revert.
10937         * bfd-target.c: Revert.
10938         * bcache.c: Revert.
10939         * ax-general.c: Revert.
10940         * ax-gdb.h: Revert.
10941         * ax-gdb.c: Revert.
10942         * avr-tdep.c: Revert.
10943         * auxv.c: Revert.
10944         * auto-load.c: Revert.
10945         * arm-wince-tdep.c: Revert.
10946         * arm-tdep.c: Revert.
10947         * arm-symbian-tdep.c: Revert.
10948         * arm-pikeos-tdep.c: Revert.
10949         * arm-obsd-tdep.c: Revert.
10950         * arm-nbsd-tdep.c: Revert.
10951         * arm-nbsd-nat.c: Revert.
10952         * arm-linux-tdep.c: Revert.
10953         * arm-linux-nat.c: Revert.
10954         * arm-fbsd-tdep.c: Revert.
10955         * arm-fbsd-nat.c: Revert.
10956         * arm-bsd-tdep.c: Revert.
10957         * arch-utils.c: Revert.
10958         * arc-tdep.c: Revert.
10959         * arc-newlib-tdep.c: Revert.
10960         * annotate.h: Revert.
10961         * annotate.c: Revert.
10962         * amd64-windows-tdep.c: Revert.
10963         * amd64-windows-nat.c: Revert.
10964         * amd64-tdep.c: Revert.
10965         * amd64-sol2-tdep.c: Revert.
10966         * amd64-obsd-tdep.c: Revert.
10967         * amd64-obsd-nat.c: Revert.
10968         * amd64-nbsd-tdep.c: Revert.
10969         * amd64-nbsd-nat.c: Revert.
10970         * amd64-nat.c: Revert.
10971         * amd64-linux-tdep.c: Revert.
10972         * amd64-linux-nat.c: Revert.
10973         * amd64-fbsd-tdep.c: Revert.
10974         * amd64-fbsd-nat.c: Revert.
10975         * amd64-dicos-tdep.c: Revert.
10976         * amd64-darwin-tdep.c: Revert.
10977         * amd64-bsd-nat.c: Revert.
10978         * alpha-tdep.c: Revert.
10979         * alpha-obsd-tdep.c: Revert.
10980         * alpha-nbsd-tdep.c: Revert.
10981         * alpha-mdebug-tdep.c: Revert.
10982         * alpha-linux-tdep.c: Revert.
10983         * alpha-linux-nat.c: Revert.
10984         * alpha-bsd-tdep.c: Revert.
10985         * alpha-bsd-nat.c: Revert.
10986         * aix-thread.c: Revert.
10987         * agent.c: Revert.
10988         * addrmap.c: Revert.
10989         * ada-varobj.c: Revert.
10990         * ada-valprint.c: Revert.
10991         * ada-typeprint.c: Revert.
10992         * ada-tasks.c: Revert.
10993         * ada-lang.c: Revert.
10994         * aarch64-tdep.c: Revert.
10995         * aarch64-ravenscar-thread.c: Revert.
10996         * aarch64-newlib-tdep.c: Revert.
10997         * aarch64-linux-tdep.c: Revert.
10998         * aarch64-linux-nat.c: Revert.
10999         * aarch64-fbsd-tdep.c: Revert.
11000         * aarch64-fbsd-nat.c: Revert.
11001         * aarch32-linux-nat.c: Revert.
11002
11003 2019-04-05  Tom Tromey  <tom@tromey.com>
11004
11005         * ft32-tdep.c: Sort headers.
11006         * frv-tdep.c: Sort headers.
11007         * frv-linux-tdep.c: Sort headers.
11008         * frame.c: Sort headers.
11009         * frame-unwind.c: Sort headers.
11010         * frame-base.c: Sort headers.
11011         * fork-child.c: Sort headers.
11012         * findvar.c: Sort headers.
11013         * findcmd.c: Sort headers.
11014         * filesystem.c: Sort headers.
11015         * filename-seen-cache.h: Sort headers.
11016         * filename-seen-cache.c: Sort headers.
11017         * fbsd-tdep.c: Sort headers.
11018         * fbsd-nat.h: Sort headers.
11019         * fbsd-nat.c: Sort headers.
11020         * f-valprint.c: Sort headers.
11021         * f-typeprint.c: Sort headers.
11022         * f-lang.c: Sort headers.
11023         * extension.h: Sort headers.
11024         * extension.c: Sort headers.
11025         * extension-priv.h: Sort headers.
11026         * expprint.c: Sort headers.
11027         * exec.h: Sort headers.
11028         * exec.c: Sort headers.
11029         * exceptions.c: Sort headers.
11030         * event-top.c: Sort headers.
11031         * event-loop.c: Sort headers.
11032         * eval.c: Sort headers.
11033         * elfread.c: Sort headers.
11034         * dwarf2read.h: Sort headers.
11035         * dwarf2read.c: Sort headers.
11036         * dwarf2loc.c: Sort headers.
11037         * dwarf2expr.h: Sort headers.
11038         * dwarf2expr.c: Sort headers.
11039         * dwarf2-frame.c: Sort headers.
11040         * dwarf2-frame-tailcall.c: Sort headers.
11041         * dwarf-index-write.h: Sort headers.
11042         * dwarf-index-write.c: Sort headers.
11043         * dwarf-index-common.c: Sort headers.
11044         * dwarf-index-cache.h: Sort headers.
11045         * dwarf-index-cache.c: Sort headers.
11046         * dummy-frame.c: Sort headers.
11047         * dtrace-probe.c: Sort headers.
11048         * disasm.h: Sort headers.
11049         * disasm.c: Sort headers.
11050         * disasm-selftests.c: Sort headers.
11051         * dictionary.c: Sort headers.
11052         * dicos-tdep.c: Sort headers.
11053         * demangle.c: Sort headers.
11054         * dcache.h: Sort headers.
11055         * dcache.c: Sort headers.
11056         * darwin-nat.h: Sort headers.
11057         * darwin-nat.c: Sort headers.
11058         * darwin-nat-info.c: Sort headers.
11059         * d-valprint.c: Sort headers.
11060         * d-namespace.c: Sort headers.
11061         * d-lang.c: Sort headers.
11062         * ctf.c: Sort headers.
11063         * csky-tdep.c: Sort headers.
11064         * csky-linux-tdep.c: Sort headers.
11065         * cris-tdep.c: Sort headers.
11066         * cris-linux-tdep.c: Sort headers.
11067         * cp-valprint.c: Sort headers.
11068         * cp-support.c: Sort headers.
11069         * cp-namespace.c: Sort headers.
11070         * cp-abi.c: Sort headers.
11071         * corelow.c: Sort headers.
11072         * corefile.c: Sort headers.
11073         * continuations.c: Sort headers.
11074         * completer.h: Sort headers.
11075         * completer.c: Sort headers.
11076         * complaints.c: Sort headers.
11077         * coffread.c: Sort headers.
11078         * coff-pe-read.c: Sort headers.
11079         * cli-out.h: Sort headers.
11080         * cli-out.c: Sort headers.
11081         * charset.c: Sort headers.
11082         * c-varobj.c: Sort headers.
11083         * c-valprint.c: Sort headers.
11084         * c-typeprint.c: Sort headers.
11085         * c-lang.c: Sort headers.
11086         * buildsym.c: Sort headers.
11087         * buildsym-legacy.c: Sort headers.
11088         * build-id.h: Sort headers.
11089         * build-id.c: Sort headers.
11090         * btrace.c: Sort headers.
11091         * bsd-uthread.c: Sort headers.
11092         * breakpoint.h: Sort headers.
11093         * breakpoint.c: Sort headers.
11094         * break-catch-throw.c: Sort headers.
11095         * break-catch-syscall.c: Sort headers.
11096         * break-catch-sig.c: Sort headers.
11097         * blockframe.c: Sort headers.
11098         * block.c: Sort headers.
11099         * bfin-tdep.c: Sort headers.
11100         * bfin-linux-tdep.c: Sort headers.
11101         * bfd-target.c: Sort headers.
11102         * bcache.c: Sort headers.
11103         * ax-general.c: Sort headers.
11104         * ax-gdb.h: Sort headers.
11105         * ax-gdb.c: Sort headers.
11106         * avr-tdep.c: Sort headers.
11107         * auxv.c: Sort headers.
11108         * auto-load.c: Sort headers.
11109         * arm-wince-tdep.c: Sort headers.
11110         * arm-tdep.c: Sort headers.
11111         * arm-symbian-tdep.c: Sort headers.
11112         * arm-pikeos-tdep.c: Sort headers.
11113         * arm-obsd-tdep.c: Sort headers.
11114         * arm-nbsd-tdep.c: Sort headers.
11115         * arm-nbsd-nat.c: Sort headers.
11116         * arm-linux-tdep.c: Sort headers.
11117         * arm-linux-nat.c: Sort headers.
11118         * arm-fbsd-tdep.c: Sort headers.
11119         * arm-fbsd-nat.c: Sort headers.
11120         * arm-bsd-tdep.c: Sort headers.
11121         * arch-utils.c: Sort headers.
11122         * arc-tdep.c: Sort headers.
11123         * arc-newlib-tdep.c: Sort headers.
11124         * annotate.h: Sort headers.
11125         * annotate.c: Sort headers.
11126         * amd64-windows-tdep.c: Sort headers.
11127         * amd64-windows-nat.c: Sort headers.
11128         * amd64-tdep.c: Sort headers.
11129         * amd64-sol2-tdep.c: Sort headers.
11130         * amd64-obsd-tdep.c: Sort headers.
11131         * amd64-obsd-nat.c: Sort headers.
11132         * amd64-nbsd-tdep.c: Sort headers.
11133         * amd64-nbsd-nat.c: Sort headers.
11134         * amd64-nat.c: Sort headers.
11135         * amd64-linux-tdep.c: Sort headers.
11136         * amd64-linux-nat.c: Sort headers.
11137         * amd64-fbsd-tdep.c: Sort headers.
11138         * amd64-fbsd-nat.c: Sort headers.
11139         * amd64-dicos-tdep.c: Sort headers.
11140         * amd64-darwin-tdep.c: Sort headers.
11141         * amd64-bsd-nat.c: Sort headers.
11142         * alpha-tdep.c: Sort headers.
11143         * alpha-obsd-tdep.c: Sort headers.
11144         * alpha-nbsd-tdep.c: Sort headers.
11145         * alpha-mdebug-tdep.c: Sort headers.
11146         * alpha-linux-tdep.c: Sort headers.
11147         * alpha-linux-nat.c: Sort headers.
11148         * alpha-bsd-tdep.c: Sort headers.
11149         * alpha-bsd-nat.c: Sort headers.
11150         * aix-thread.c: Sort headers.
11151         * agent.c: Sort headers.
11152         * addrmap.c: Sort headers.
11153         * ada-varobj.c: Sort headers.
11154         * ada-valprint.c: Sort headers.
11155         * ada-typeprint.c: Sort headers.
11156         * ada-tasks.c: Sort headers.
11157         * ada-lang.c: Sort headers.
11158         * aarch64-tdep.c: Sort headers.
11159         * aarch64-ravenscar-thread.c: Sort headers.
11160         * aarch64-newlib-tdep.c: Sort headers.
11161         * aarch64-linux-tdep.c: Sort headers.
11162         * aarch64-linux-nat.c: Sort headers.
11163         * aarch64-fbsd-tdep.c: Sort headers.
11164         * aarch64-fbsd-nat.c: Sort headers.
11165         * aarch32-linux-nat.c: Sort headers.
11166
11167 2019-04-04  Tom Tromey  <tom@tromey.com>
11168
11169         * varobj.c (varobj_create): Update.
11170         * rust-exp.y (struct rust_parser) <update_innermost_block,
11171         lookup_symbol>: New methods.
11172         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11173         Rename.
11174         (rust_parser::rust_lookup_type)
11175         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11176         * printcmd.c (display_command, do_one_display): Update.
11177         * parser-defs.h (struct parser_state) <parser_state>: Add
11178         "tracker" parameter.
11179         (block_tracker): New member.
11180         (class innermost_block_tracker) <innermost_block_tracker>: Add
11181         "types" parameter.
11182         <reset>: Remove method.
11183         (innermost_block): Don't declare.
11184         (null_post_parser): Update.
11185         * parse.c (innermost_block): Remove global.
11186         (write_dollar_variable): Update.
11187         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11188         Remove "tracker_types" parameter.
11189         (parse_expression): Add "tracker" parameter.
11190         (parse_expression_for_completion): Update.
11191         (null_post_parser): Add "tracker" parameter.
11192         * p-exp.y: Update rules.
11193         * m2-exp.y: Update rules.
11194         * language.h (struct language_defn) <la_post_parser>: Add
11195         "tracker" parameter.
11196         * go-exp.y: Update rules.
11197         * f-exp.y: Update rules.
11198         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11199         parameter.
11200         * d-exp.y: Update rules.
11201         * c-exp.y: Update rules.
11202         * breakpoint.c (set_breakpoint_condition): Create an
11203         innermost_block_tracker.
11204         (watch_command_1): Likewise.
11205         * ada-lang.c (resolve): Add "tracker" parameter.
11206         (resolve_subexp): Likewise.
11207         * ada-exp.y (write_var_from_sym): Update.
11208
11209 2019-04-04  Tom Tromey  <tom@tromey.com>
11210
11211         * type-stack.h: New file.
11212         * type-stack.c: New file.
11213         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11214         type-stack.h.
11215         (insert_into_type_stack, insert_type, push_type, push_type_int)
11216         (insert_type_address_space, pop_type, pop_type_int)
11217         (pop_typelist, pop_type_stack, append_type_stack)
11218         (push_type_stack, get_type_stack, push_typelist)
11219         (follow_type_instance_flags, follow_types): Don't declare.
11220         * parse.c (type_stack): Remove global.
11221         (parse_exp_in_context): Update.
11222         (insert_into_type_stack, insert_type, push_type, push_type_int)
11223         (insert_type_address_space, pop_type, pop_type_int)
11224         (pop_typelist, pop_type_stack, append_type_stack)
11225         (push_type_stack, get_type_stack, push_typelist)
11226         (follow_type_instance_flags, follow_types): Remove (moved to
11227         type-stack.c).
11228         * f-exp.y (type_stack): New global.
11229         Update rules.
11230         (push_kind_type, f_parse): Update.
11231         * d-exp.y (type_stack): New global.
11232         Update rules.
11233         (d_parse): Update.
11234         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11235         Update rules.
11236         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11237         (HFILES_NO_SRCDIR): Add type-stack.h.
11238
11239 2019-04-04  Tom Tromey  <tom@tromey.com>
11240
11241         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11242         (rust_parser::convert_ast_to_expression, rust_parse)
11243         (rust_lex_test_completion, rust_lex_tests): Update.
11244         * parser-defs.h (struct expr_completion_state): New.
11245         (struct parser_state) <parser_state>: Add completion parameter.
11246         <mark_struct_expression, mark_completion_tag>: New methods.
11247         <parse_completion, m_completion_state>: New members.
11248         (prefixify_expression, null_post_parser): Update.
11249         (mark_struct_expression, mark_completion_tag): Don't declare.
11250         * parse.c (parse_completion, expout_last_struct)
11251         (expout_tag_completion_type, expout_completion_name): Remove
11252         globals.
11253         (parser_state::mark_struct_expression)
11254         (parser_state::mark_completion_tag): Now methods.
11255         (prefixify_expression): Add last_struct parameter.
11256         (prefixify_subexp): Likewise.
11257         (parse_exp_1): Update.
11258         (parse_exp_in_context): Add cstate parameter.  Update.
11259         (parse_expression_for_completion): Create an
11260         expr_completion_state.
11261         (null_post_parser): Add "completion" parameter.
11262         * p-exp.y: Update rules.
11263         (yylex): Update.
11264         * language.h (struct language_defn) <la_post_parser>: Add
11265         "completing" parameter.
11266         * go-exp.y: Update rules.
11267         (lex_one_token): Update.
11268         * expression.h (parse_completion): Don't declare.
11269         * d-exp.y: Update rules.
11270         (lex_one_token): Update rules.
11271         * c-exp.y: Update rules.
11272         (lex_one_token): Update.
11273         * ada-lang.c (resolve): Add "parse_completion" parameter.
11274         (resolve_subexp): Likewise.
11275         (ada_resolve_function): Likewise.
11276
11277 2019-04-04  Tom Tromey  <tom@tromey.com>
11278
11279         * parser-defs.h (struct parser_state) <start_arglist,
11280         end_arglist>: New methods.
11281         <arglist_len, m_funcall_chain>: New members.
11282         (arglist_len, start_arglist, end_arglist): Don't declare.
11283         * parse.c (arglist_len, funcall_chain): Remove global.
11284         (start_arglist, end_arglist): Remove functions.
11285         (parse_exp_in_context): Update.
11286         * p-exp.y: Update rules.
11287         * m2-exp.y: Update rules.
11288         * go-exp.y: Update rules.
11289         * f-exp.y: Update rules.
11290         * d-exp.y: Update rules.
11291         * c-exp.y: Update rules.
11292
11293 2019-04-04  Tom Tromey  <tom@tromey.com>
11294
11295         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11296         lex_operator, push_back>: New methods.
11297         Update all rules.
11298         (rust_parser::lex_hex, lex_escape): Rename and update.
11299         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11300         (rust_parser::lex_operator): Rename and update.
11301         (rust_parser::lex_number, rustyylex, rustyyerror)
11302         (rust_lex_test_init, rust_lex_test_sequence)
11303         (rust_lex_test_push_back, rust_lex_tests): Update.
11304         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11305         parameter.
11306         <lexptr, prev_lexptr>: New members.
11307         (lexptr, prev_lexptr): Don't declare.
11308         * parse.c (lexptr, prev_lexptr): Remove globals.
11309         (parse_exp_in_context): Update.
11310         * p-exp.y (yylex, yyerror): Update.
11311         * m2-exp.y (parse_number, yylex, yyerror): Update.
11312         * go-exp.y (lex_one_token, yyerror): Update.
11313         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11314         * d-exp.y (lex_one_token, yyerror): Update.
11315         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11316         (lex_one_token, yyerror): Update.
11317         * ada-lex.l (YY_INPUT): Update.
11318         (rewind_to_char): Update.
11319         * ada-exp.y (yyerror): Update.
11320
11321 2019-04-04  Tom Tromey  <tom@tromey.com>
11322
11323         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11324         * parser-defs.h (struct parser_state) <parser_state>: Add new
11325         parameter.
11326         <comma_terminates>: New member.
11327         (comma_terminates): Don't declare global.
11328         * parse.c (comma_terminates): Remove global.
11329         (parse_exp_in_context): Update.
11330         * p-exp.y (yylex): Update.
11331         * m2-exp.y (yylex): Update.
11332         * go-exp.y (lex_one_token): Update.
11333         * f-exp.y (yylex): Update.
11334         * d-exp.y (lex_one_token): Update.
11335         * c-exp.y (lex_one_token): Update.
11336         * ada-lex.l: Update.
11337
11338 2019-04-04  Tom Tromey  <tom@tromey.com>
11339
11340         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11341         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11342         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11343         * parser-defs.h (paren_depth): Don't declare.
11344         * parse.c (paren_depth): Remove global.
11345         (parse_exp_in_context): Update.
11346         * p-exp.y (paren_depth): New global.
11347         (pascal_parse): Initialize it.
11348         * m2-exp.y (paren_depth): New global.
11349         (m2_parse): Initialize it.
11350         * go-exp.y (paren_depth): New global.
11351         (go_parse): Initialize it.
11352         * f-exp.y (paren_depth): New global.
11353         (f_parse): Initialize it.
11354         * d-exp.y (paren_depth): New global.
11355         (d_parse): Initialize it.
11356         * c-exp.y (paren_depth): New global.
11357         (c_parse): Initialize it.
11358         * ada-lex.l (paren_depth): New global.
11359         (lexer_init): Initialize it.
11360
11361 2019-04-04  Tom Tromey  <tom@tromey.com>
11362
11363         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11364         (rust_parser::convert_ast_to_type)
11365         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11366         * parser-defs.h (struct parser_state) <parser_state>: Add
11367         parameters.  Initialize new members.
11368         <expression_context_block, expression_context_pc>: New members.
11369         * parse.c (expression_context_block, expression_context_pc):
11370         Remove globals.
11371         (parse_exp_in_context): Update.
11372         * p-exp.y: Update all rules.
11373         (yylex): Update.
11374         * m2-exp.y: Update all rules.
11375         (yylex): Update.
11376         * go-exp.y (yylex): Update.
11377         * f-exp.y (yylex): Update.
11378         * d-exp.y: Update all rules.
11379         (yylex): Update.
11380         * c-exp.y: Update all rules.
11381         (lex_one_token, classify_name, yylex, c_parse): Update.
11382         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11383
11384 2019-04-04  Tom Tromey  <tom@tromey.com>
11385
11386         * gdbarch.h, gdbarch.c: Rebuild.
11387         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11388         * stap-probe.h:
11389         (struct stap_parse_info): Replace "parser_state" with
11390         "expr_builder".
11391         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11392         (parser_state): New class.
11393         * parse.c (expr_builder): Rename.
11394         (expr_builder::release): Rename.
11395         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11396         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11397         (write_exp_elt_longcst, write_exp_elt_floatcst)
11398         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11399         (write_exp_string_vector, write_exp_bitstring)
11400         (write_exp_msymbol, mark_struct_expression)
11401         (write_dollar_variable)
11402         (insert_type_address_space, increase_expout_size): Replace
11403         "parser_state" with "expr_builder".
11404         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11405         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11406         "parser_state" with "expr_builder".
11407
11408 2019-04-04  Tom Tromey  <tom@tromey.com>
11409
11410         * rust-exp.y: Replace "parse_language" with method call.
11411         * p-exp.y:
11412         (yylex): Replace "parse_language" with method call.
11413         * m2-exp.y:
11414         (yylex): Replace "parse_language" with method call.
11415         * go-exp.y (classify_name): Replace "parse_language" with method
11416         call.
11417         * f-exp.y (yylex): Replace "parse_language" with method call.
11418         * d-exp.y (lex_one_token): Replace "parse_language" with method
11419         call.
11420         * c-exp.y:
11421         (lex_one_token, classify_name, yylex): Replace "parse_language"
11422         with method call.
11423         * ada-exp.y (find_primitive_type, type_char)
11424         (type_system_address): Replace "parse_language" with method call.
11425
11426 2019-04-04  Tom Tromey  <tom@tromey.com>
11427
11428         * rust-exp.y: Replace "parse_gdbarch" with method call.
11429         * parse.c (write_dollar_variable, insert_type_address_space):
11430         Replace "parse_gdbarch" with method call.
11431         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11432         call.
11433         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11434         call.
11435         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11436         "parse_gdbarch" with method call.
11437         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11438         with method call.
11439         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11440         "parse_gdbarch" with method call.
11441         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11442         "parse_gdbarch" with method call.
11443         * c-exp.y (parse_type, parse_number, classify_name): Replace
11444         "parse_gdbarch" with method call.
11445         * ada-lex.l: Replace "parse_gdbarch" with method call.
11446         * ada-exp.y (parse_type, find_primitive_type, type_char)
11447         (type_system_address): Replace "parse_gdbarch" with method call.
11448
11449 2019-04-04  Tom Tromey  <tom@tromey.com>
11450
11451         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11452         * stap-probe.c (stap_parse_argument): Update.
11453         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11454         initial_size parameter.
11455         * rust-exp.y (rust_lex_tests): Update.
11456         * parse.c (parser_state): Update.
11457         (parse_exp_in_context): Update.
11458         * parser-defs.h (struct parser_state) <parser_state>: Remove
11459         "initial_size" parameter.
11460
11461 2019-04-04  Tom Tromey  <tom@tromey.com>
11462
11463         * parser-defs.h (increase_expout_size): Don't declare.
11464         * parse.c (increase_expout_size): Now static.
11465
11466 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11467
11468         * gnu-nat.c (gnu_nat_target::wait): Fix
11469         target_waitstatus_to_string call.
11470
11471 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11472
11473         * eval.c (evaluate_subexp_standard): Handle internal functions
11474         during Fortran function call handling.
11475
11476 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11477
11478         * NEWS: Mention new internal functions.
11479         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11480         (read_base_type): Use dwarf2_init_complex_target_type.
11481         * value.c (creal_internal_fn): New function.
11482         (cimag_internal_fn): New function.
11483         (_initialize_values): Register new internal functions.
11484
11485 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11486
11487         * infrun.c (stop_all_threads): If debug_infrun, always
11488         trace the wait status after wait_one, using
11489         target_waitstatus_to_string and target_pid_to_str.
11490         (handle_inferior_event): Replace various trace of
11491         wait status kind by a single trace.
11492         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11493         wait status kind image by target_waitstatus_to_string.
11494         * target/waitstatus.c (target_waitstatus_to_string): Fix
11495         obsolete comment.
11496
11497 2019-04-01  Tom Tromey  <tromey@adacore.com>
11498
11499         PR symtab/23331:
11500         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11501
11502 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11503             Pedro Alves  <palves@redhat.com>
11504
11505         * top.c (quit_force): Call 'finalize_values'.
11506         * value.c (finalize_values): New function.
11507         * value.h (finalize_values): Declare.
11508
11509 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11510
11511         * NEWS: Announce $_gdb_major and $_gdb_minor.
11512
11513         * top.c (init_gdb_version_vars): New function.
11514         (gdb_init): Call init_gdb_version_vars.
11515
11516 2019-03-29  Tom Tromey  <tromey@adacore.com>
11517
11518         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11519         help text.  Remove dead code.
11520
11521 2019-03-29  Keith Seitz  <keiths@redhat.com>
11522
11523         From Siddhesh Poyarekar:
11524         * f-lang.h (f77_get_upperbound): Return LONGEST.
11525         (f77_get_lowerbound): Likewise.
11526         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11527         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11528         print them.
11529         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11530         plongest to format print it.
11531         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11532         (f77_get_upperbound): Likewise.
11533         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11534         LOWER_BOUND to LONGEST.
11535         (f77_create_arrayprint_offset_tbl): Likewise.
11536
11537 2019-03-29  Keith Seitz  <keiths@redhat.com>
11538
11539         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11540         %s/pulongest for TYPE_LENGTH instead of %d in format
11541         strings.
11542         * ada-typerint.c (ada_print_type): Likewise.
11543         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11544         * compile/compile-c-support.c (generate_register_struct): Likewise.
11545         * gdbtypes.c (recursive_dump_type): Likewise.
11546         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11547         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11548         instead of %d in format strings.
11549         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11550         to std::min to ULONGEST.
11551         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11552         instead of %d in format strings.
11553         * tracepoint.c (info_scope_command): Likewise.
11554         * typeprint.c (print_offset_data::update)
11555         (print_offset_data::finish): Likewise.
11556         * xtensa-tdep.c (xtensa_store_return_value)
11557         (xtensa_push_dummy_call): Likewise.
11558
11559 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11560
11561         * windows-nat.c (display_selector): Fixed format specifications
11562         for 64-bit Cygwin.
11563
11564 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11565
11566         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11567
11568 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11569
11570         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11571         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11572         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11573         (nios2_linux_init_abi): Install it.
11574
11575 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11576
11577         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11578
11579 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11580
11581         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11582
11583 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11584             Tom Tromey  <tromey@adacore.com>
11585
11586         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11587
11588 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11589
11590         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11591         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11592         method to compute the bounds of range types. Also print "[evaluated]"
11593         if the bounds' values come from a dynamic evaluation.
11594
11595 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11596
11597         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11598         whitespace when pretty printing is on.
11599
11600 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11601
11602         * ppc-linux-nat.c: Add include.
11603
11604 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11605
11606         * NEWS: Mention AArch64 Pointer Authentication.
11607
11608 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11609
11610         * arm-linux-nat.c: Add include.
11611
11612 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11613
11614         * source-cache.c (source_cache::get_source_lines): Re-read
11615         fullname after calling open_source_file.
11616
11617 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11618
11619         * NEWS: Mention TLS support for FreeBSD.
11620
11621 2019-03-25  Tom Tromey  <tromey@adacore.com>
11622
11623         * minsyms.c (BUNCH_SIZE): Update comment.
11624         (~minimal_symbol_reader): Remove old comment.
11625         (compact_minimal_symbols): Update comment.
11626         (minimal_symbol_reader::install): Remove old comment.  Update
11627         other comments.
11628
11629 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11630
11631         * s390-linux-nat.c: Add include.
11632
11633 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11634
11635         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11636         Call linux_get_hwcap.
11637         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11638         Likewise.
11639         (aarch64_linux_get_hwcap): Remove function.
11640         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11641         declaration.
11642         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11643         linux_get_hwcap.
11644         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11645         * linux-tdep.c (linux_get_hwcap): Add function.
11646         (linux_get_hwcap2): Likewise.
11647         * linux-tdep.h (linux_get_hwcap): Add declaration.
11648         (linux_get_hwcap2): Likewise.
11649         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11650         (ppc_linux_get_hwcap2): Likewise.
11651         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11652         linux_get_hwcap.
11653         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11654         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11655         (ppc_linux_nat_target::read_description): Likewise.
11656         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11657         * s390-linux-nat.c: Likewise.
11658         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11659
11660 2019-03-24  Tom Tromey  <tom@tromey.com>
11661
11662         * ada-lang.c (standard_lookup): Simplify initialization.
11663         (ada_lookup_symbol_nonlocal): Simplify return.
11664         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11665         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11666         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11667         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11668         initialization.
11669         * solib.c (solib_global_lookup): Simplify.
11670         * symtab.c (null_block_symbol): Remove.
11671         (symbol_cache_lookup): Simplify returns.
11672         (lookup_language_this): Simplify returns.
11673         (lookup_symbol_aux): Simplify return.
11674         (lookup_local_symbol): Simplify returns.
11675         (lookup_global_symbol_from_objfile): Simplify return.
11676         (lookup_symbol_in_objfile_symtabs)
11677         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11678         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11679         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11680         * cp-namespace.c (cp_lookup_bare_symbol)
11681         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11682         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11683         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11684         (cp_lookup_symbol_via_imports): Simplify initialization.
11685         (find_symbol_in_baseclass): Likewise.
11686         * symtab.h (null_block_symbol): Remove.
11687         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11688         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11689         (d_lookup_symbol_module): Likewise.
11690         (find_symbol_in_baseclass): Simplify initialization.
11691
11692 2019-03-24  Tom Tromey  <tom@tromey.com>
11693
11694         * expression.h: Don't include symtab.h.
11695         (struct block): Forward declare.
11696
11697 2019-03-24  Tom Tromey  <tom@tromey.com>
11698
11699         * c-exp.y (typebase): Remove casts.
11700         * gdbtypes.c (lookup_unsigned_typename, )
11701         (lookup_signed_typename): Remove cast.
11702         * eval.c (parse_to_comma_and_eval): Remove cast.
11703         * parse.c (write_dollar_variable): Remove cast.
11704         * block.h (struct block) <superblock>: Now const.
11705         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11706         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11707         (map_block): Make "block" const.
11708         * symfile.h (struct quick_symbol_functions)
11709         <map_matching_symbols>: Constify block argument to "callback".
11710         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11711         const.
11712         (find_pc_sect_compunit_symtab): Make "b" const.
11713         (find_symbol_at_address): Likewise.
11714         (search_symbols): Likewise.
11715         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11716         (dw2_debug_names_lookup_symbol): Likewise.
11717         (dw2_map_matching_symbols): Update.
11718         * p-valprint.c (pascal_val_print): Remove "block".
11719         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11720         (aux_add_nonlocal_symbols): Make "block" const.
11721         (resolve_subexp): Remove cast.
11722         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11723         const.
11724         (iterate_over_file_blocks): Likewise.
11725         * f-exp.y (%union) <bval>: Remove.
11726         * coffread.c (patch_opaque_types): Make "b" const.
11727         * spu-tdep.c (spu_catch_start): Make "block" const.
11728         * c-valprint.c (print_unpacked_pointer): Remove "block".
11729         * symmisc.c (dump_symtab_1): Make "b" const.
11730         (block_depth): Make "block" const.
11731         * d-exp.y (%union) <bval>: Remove.
11732         * cp-support.h (cp_lookup_rtti_type): Update.
11733         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11734         * psymtab.c (psym_lookup_symbol): Make "block" const.
11735         (maintenance_check_psymtabs): Make "b" const.
11736         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11737         (enumerate_locals, enumerate_args): Update.
11738         * python/py-symtab.c (stpy_global_block): Make "block" const.
11739         (stpy_static_block): Likewise.
11740         * inline-frame.c (block_starting_point_at): Make "new_block"
11741         const.
11742         * block.c (find_block_in_blockvector): Make return type const.
11743         (blockvector_for_pc_sect): Make "b" const.
11744         (find_block_in_blockvector): Make "b" const.
11745
11746 2019-03-23  Tom Tromey  <tom@tromey.com>
11747
11748         * varobj.c (varobj_create): Update.
11749         * symfile.c (clear_symtab_users): Don't reset innermost_block.
11750         * printcmd.c (display_command, do_one_display): Don't reset
11751         innermost_block.
11752         * parser-defs.h (enum innermost_block_tracker_type): Move to
11753         expression.h.
11754         (innermost_block): Update comment.
11755         * parse.c (parse_exp_1): Add tracker_types parameter.
11756         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
11757         tracker_types parameter.  Reset innermost_block.
11758         (parse_exp_in_context): Remove.
11759         (parse_expression_for_completion): Update.
11760         * objfiles.c (~objfile): Don't reset expression_context_block or
11761         innermost_block.
11762         * expression.h (enum innermost_block_tracker_type): Move from
11763         parser-defs.h.
11764         (parse_exp_1): Add tracker_types parameter.
11765         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11766         reset innermost_block.
11767
11768 2019-03-23  Tom Tromey  <tom@tromey.com>
11769
11770         * objfiles.h: Include bcache.h.
11771
11772 2019-03-23  Tom Tromey  <tom@tromey.com>
11773
11774         * linespec.c (get_current_search_block): Use
11775         scoped_restore_current_language.
11776         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11777
11778 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11779             Jiong Wang  <jiong.wang@arm.com>
11780
11781         * aarch64-linux-tdep.c
11782         (aarch64_linux_iterate_over_regset_sections): Check for pauth
11783         section.
11784         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11785
11786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11787             Jiong Wang  <jiong.wang@arm.com>
11788
11789         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11790         instructions.
11791         (aarch64_analyze_prologue_test): Add PACIASP test.
11792         (aarch64_prologue_prev_register): Unmask PC value.
11793
11794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11795             Jiong Wang  <jiong.wang@arm.com>
11796
11797         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11798         (aarch64_dwarf2_prev_register): Unmask PC value.
11799         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11800         (aarch64_execute_dwarf_cfa_vendor_op): Check for
11801         DW_CFA_AARCH64_negate_ra_state.
11802         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11803
11804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11805             Jiong Wang  <jiong.wang@arm.com>
11806
11807         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11808         registers.
11809         (aarch64_pseudo_register_name): Likewise.
11810         (aarch64_pseudo_register_type): Likewise.
11811         (aarch64_pseudo_register_reggroup_p): Likewise.
11812         (aarch64_gdbarch_init): Add pauth registers.
11813         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11814         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11815         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11816         (struct gdbarch_tdep): Add regnum for ra_state.
11817
11818 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11819             Jiong Wang  <jiong.wang@arm.com>
11820
11821         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11822
11823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11824             Jiong Wang  <jiong.wang@arm.com>
11825
11826         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11827         function.
11828         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11829         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11830         (aarch64_gdbarch_init): Add puth registers.
11831         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11832         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11833         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11834
11835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11836             Jiong Wang  <jiong.wang@arm.com>
11837
11838         * aarch64-linux-nat.c
11839         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11840         * aarch64-linux-tdep.c
11841         (aarch64_linux_core_read_description): Likewise.
11842         (aarch64_linux_get_hwcap): New function.
11843         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11844         (aarch64_linux_get_hwcap): New declaration.
11845
11846 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
11847             Jiong Wang  <jiong.wang@arm.com>
11848
11849         * aarch64-linux-nat.c
11850         (aarch64_linux_nat_target::read_description): Add pauth param.
11851         * aarch64-linux-tdep.c
11852         (aarch64_linux_core_read_description): Likewise.
11853         * aarch64-tdep.c (struct target_desc): Add in pauth.
11854         (aarch64_read_description): Add pauth param.
11855         (aarch64_gdbarch_init): Likewise.
11856         * aarch64-tdep.h (aarch64_read_description): Likewise.
11857         * arch/aarch64.c (aarch64_create_target_description): Likewise.
11858         * arch/aarch64.h (aarch64_create_target_description): Likewise.
11859         * features/Makefile: Add new files.
11860         * features/aarch64-pauth.c: New file.
11861         * features/aarch64-pauth.xml: New file.
11862
11863 2019-03-20  Tom Tromey  <tromey@adacore.com>
11864
11865         * infrun.c (handle_inferior_event): Rename from
11866         handle_inferior_event_1.  Create a scoped_value_mark.
11867         (handle_inferior_event): Remove.
11868
11869 2019-03-19  Tom Tromey  <tromey@adacore.com>
11870
11871         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11872         * infrun.h (print_stop_event): Add "displays" parameter.
11873         * infrun.c (print_stop_event): Add "displays" parameter.
11874
11875 2019-03-19  Pedro Alves  <palves@redhat.com>
11876
11877         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11878         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
11879         to -1.  Fix TABs vs spaces.
11880         (tui_ui_out::tui_ui_out): Don't initialize fields here.
11881         * tui/tui-out.h (tui_ui_out) Add intro comments.
11882         <m_line, m_start_of_line>: In-class initialize, and add describing
11883         comment.
11884
11885 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11886
11887         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11888         variable names.
11889         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11890
11891 2019-03-18  Pedro Alves  <palves@redhat.com>
11892             Eli Zaretskii <eliz@gnu.org>
11893
11894         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11895         m_line and m_start_of_line.
11896
11897 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11898
11899         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11900         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11901         it returns a newline.  This fixes a regression in TU mode, whereby
11902         the next line is output on the same screen line as the user input.
11903
11904 2019-03-18  Tom Tromey  <tromey@adacore.com>
11905
11906         * minsyms.c (minimal_symbol_reader::install): Remove call to
11907         obstack_blank.
11908
11909 2019-03-18  Pedro Alves  <palves@redhat.com>
11910
11911         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11912         New globals.
11913         (apply_style): New, factored out from ...
11914         (apply_ansi_escape): ... this.  Handle reverse video mode.
11915         (tui_set_reverse_mode): New function.
11916         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11917         * tui/tui-winsource.c (tui_show_source_line): Use
11918         tui_set_reverse_mode instead of setting A_STANDOUT.
11919         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11920         New setter methods.
11921
11922 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11923
11924         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11925         Handle tabs.
11926
11927 2019-03-18  Tom Tromey  <tromey@adacore.com>
11928
11929         * ada-lang.c (empty_array): Add "high" parameter.
11930         (ada_evaluate_subexp): Update.
11931
11932 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11933
11934         * unittests/string_view-selftests.c: Define
11935         _initialize_string_view_selftests unconditionally.
11936
11937 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11938
11939         PR gdb/24350
11940         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11941
11942 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11943
11944         PR gdb/24351
11945         * windows-nat.c (display_selector): Fix format specifiers.
11946
11947 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11948
11949         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11950         tui_refill_source_window instead of tui_refresh_win, to update the
11951         current execution line.  This fixes redisplay of the current line
11952         when stepping through the code with "next" or "step".
11953
11954 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11955
11956         * source-cache.c (source_cache::get_source_lines): Call
11957         find_source_lines to initialize s->nlines.  This fixes vertical
11958         scrolling of TUI source window when the DOWN arrow is pressed.
11959
11960 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11961
11962         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11963         linux-thread-db.c (_initialize_thread_db): Likewise.
11964
11965 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11966
11967         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11968         wclrtoeol in tui_show_source_line".  This reverts changes made in
11969         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11970
11971 2019-03-15  Tom Tromey  <tom@tromey.com>
11972
11973         * symtab.h (struct minimal_symbol): Derive from
11974         general_symbol_info.
11975         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11976         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11977         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11978         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11979         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11980         (MSYMBOL_SEARCH_NAME): Update.
11981         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11982         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11983         * minsyms.c (minimal_symbol_reader::record_full): Update.
11984
11985 2019-03-15  Tom Tromey  <tom@tromey.com>
11986
11987         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11988
11989 2019-03-15  Tom Tromey  <tom@tromey.com>
11990
11991         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11992         unique_xmalloc_ptr.
11993         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11994         Update.
11995         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11996         (build_minimal_symbol_hash_tables)
11997         (minimal_symbol_reader::install): Update.
11998
11999 2019-03-15  Tom Tromey  <tom@tromey.com>
12000
12001         * symtab.c (create_demangled_names_hash): Update.
12002         (symbol_set_names): Update.
12003         * objfiles.h (struct objfile_per_bfd_storage)
12004         <demangled_names_hash>: Now an htab_up.
12005         * objfiles.c (objfile_per_bfd_storage): Simplify.
12006
12007 2019-03-15  Tom Tromey  <tom@tromey.com>
12008
12009         * objfiles.h (struct objfile_per_bfd_storage): Declare
12010         destructor.
12011         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12012         New.
12013         (get_objfile_bfd_data): Use new.  Don't initialize
12014         language_of_main.
12015         (free_objfile_per_bfd_storage): Remove.
12016         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12017
12018 2019-03-15  Tom Tromey  <tom@tromey.com>
12019
12020         * symfile.c (reread_symbols): Update.
12021         * objfiles.c (objfile::objfile): Update.
12022         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12023         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12024         comment.
12025         (minimal_symbol_reader::install): Update.
12026         (terminate_minimal_symbol_table): Remove.
12027         * jit.c (jit_object_close_impl): Update.
12028
12029 2019-03-15  Tom Tromey  <tom@tromey.com>
12030
12031         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12032         initializations.
12033
12034 2019-03-15  Tom Tromey  <tom@tromey.com>
12035
12036         * objfiles.h (struct objfile_per_bfd_storage)
12037         <demangled_hash_languages>: Now a bitset.
12038         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12039         (lookup_minimal_symbol): Update.
12040
12041 2019-03-15  Tom Tromey  <tom@tromey.com>
12042
12043         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12044         Don't return the symbol.
12045         * coffread.c (record_minimal_symbol): Use record_full.
12046
12047 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12048
12049         The MS-Windows port of ncurses fails to switch to a color pair if
12050         one or both of the colors are the implicit default colors.  This
12051         change records the default colors when TUI is initialized, and
12052         then specifies them explicitly when a color pair uses the default
12053         colors.  This allows color styling in TUI mode on MS-Windows.
12054
12055         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12056         ncurses_norm_attr.
12057         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12058         colors in ncurses_norm_attr.
12059         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12060         "none", replace it with the default color recorded in
12061         ncurses_norm_attr.
12062
12063 2019-03-14  Tom Tromey  <tromey@adacore.com>
12064
12065         * source-cache.h (class source_cache) <get_source_lines>: Return
12066         std::string.
12067         * source-cache.c (source_cache::extract_lines): Handle case where
12068         first_pos==npos.  Return std::string.
12069         (source_cache::get_source_lines): Update.
12070
12071 2019-03-14  Tom Tromey  <tromey@adacore.com>
12072
12073         * NEWS: Add item for "style sources" commands.
12074         * source-cache.c (source_cache::get_source_lines): Check
12075         source_styling.
12076         * cli/cli-style.c (source_styling): New global.
12077         (_initialize_cli_style): Add "style sources" commands.
12078         (show_style_sources): New function.
12079         * cli/cli-style.h (source_styling): Declare.
12080
12081 2019-03-14  Pedro Alves  <palves@redhat.com>
12082             Tom Tromey  <tromey@adacore.com>
12083
12084         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12085         * tui/tui-winsource.c (tui_refill_source_window): New function,
12086         from...
12087         (tui_horizontal_source_scroll): ... here.  Move some logic.
12088         * cli/cli-style.c (set_style_enabled): Notify new observable.
12089         * tui/tui-hooks.c (tui_redisplay_source): New function.
12090         (tui_attach_detach_observers): Attach or detach
12091         tui_redisplay_source.
12092         * observable.h (source_styling_changed): New observable.
12093         * observable.c: Define source_styling_changed observable.
12094
12095 2019-03-13  Tom Tromey  <tromey@adacore.com>
12096
12097         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12098         (i386_gnu_nat_target::store_registers): Update.
12099         * target-debug.h (target_debug_print_std_string): New macro.
12100         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12101         * windows-tdep.c (display_one_tib): Update.
12102         * tui/tui-stack.c (tui_make_status_line): Update.
12103         * top.c (print_inferior_quit_action): Update.
12104         * thread.c (thr_try_catch_cmd): Update.
12105         (add_thread_with_info): Update.
12106         (thread_target_id_str): Update.
12107         (thr_try_catch_cmd): Update.
12108         (thread_command): Update.
12109         (thread_find_command): Update.
12110         * record-btrace.c (record_btrace_target::info_record)
12111         (record_btrace_resume_thread, record_btrace_target::resume)
12112         (record_btrace_cancel_resume, record_btrace_step_thread)
12113         (record_btrace_target::wait, record_btrace_target::wait)
12114         (record_btrace_target::wait, record_btrace_target::stop): Update.
12115         * progspace.c (print_program_space): Update.
12116         * process-stratum-target.c
12117         (process_stratum_target::thread_address_space): Update.
12118         * linux-fork.c (linux_fork_mourn_inferior)
12119         (detach_checkpoint_command, info_checkpoints_command)
12120         (linux_fork_context): Update.
12121         (linux_fork_detach): Update.
12122         (class scoped_switch_fork_info): Update.
12123         (delete_checkpoint_command): Update.
12124         * infrun.c (follow_fork_inferior): Update.
12125         (follow_fork_inferior): Update.
12126         (proceed_after_vfork_done): Update.
12127         (handle_vfork_child_exec_or_exit): Update.
12128         (follow_exec): Update.
12129         (displaced_step_prepare_throw): Update.
12130         (displaced_step_restore): Update.
12131         (start_step_over): Update.
12132         (resume_1): Update.
12133         (clear_proceed_status_thread): Update.
12134         (proceed): Update.
12135         (print_target_wait_results): Update.
12136         (do_target_wait): Update.
12137         (context_switch): Update.
12138         (stop_all_threads): Update.
12139         (restart_threads): Update.
12140         (finish_step_over): Update.
12141         (handle_signal_stop): Update.
12142         (switch_back_to_stepped_thread): Update.
12143         (keep_going_pass_signal): Update.
12144         (print_exited_reason): Update.
12145         (normal_stop): Update.
12146         * inferior.c (inferior_pid_to_str): Change return type.
12147         (print_selected_inferior): Update.
12148         (add_inferior): Update.
12149         (detach_inferior): Update.
12150         * dummy-frame.c (fprint_dummy_frames): Update.
12151         * dcache.c (dcache_info_1): Update.
12152         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12153         (btrace_fetch, btrace_clear): Update.
12154         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12155         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12156         type.
12157         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12158         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12159         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12160         * gdbarch.c, gdbarch.h: Rebuild.
12161         * gdbarch.sh (core_pid_to_str): Change return type.
12162         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12163         return type.
12164         (windows_nat_target::pid_to_str): Change return type.
12165         (windows_delete_thread): Update.
12166         (windows_nat_target::attach): Update.
12167         (windows_nat_target::files_info): Update.
12168         * target-delegates.c: Rebuild.
12169         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12170         return type.
12171         (sol_thread_target::pid_to_str): Change return type.
12172         * remote.c (class remote_target) <pid_to_str>: Change return
12173         type.
12174         (remote_target::pid_to_str): Change return type.
12175         (extended_remote_target::attach, remote_target::remote_stop_ns)
12176         (remote_target::remote_notif_remove_queued_reply)
12177         (remote_target::push_stop_reply, remote_target::disable_btrace):
12178         Update.
12179         (extended_remote_target::attach): Update.
12180         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12181         type.
12182         (gdbsim_target::pid_to_str): Change return type.
12183         * ravenscar-thread.c (struct ravenscar_thread_target)
12184         <pid_to_str>: Change return type.
12185         (ravenscar_thread_target::pid_to_str): Change return type.
12186         * procfs.c (class procfs_target) <pid_to_str>: Change return
12187         type.
12188         (procfs_target::pid_to_str): Change return type.
12189         (procfs_target::attach): Update.
12190         (procfs_target::detach): Update.
12191         (procfs_target::fetch_registers): Update.
12192         (procfs_target::store_registers): Update.
12193         (procfs_target::wait): Update.
12194         (procfs_target::files_info): Update.
12195         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12196         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12197         return type.
12198         (nto_procfs_target::pid_to_str): Change return type.
12199         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12200         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12201         return type.
12202         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12203         (exit_lwp): Update.
12204         (attach_proc_task_lwp_callback, get_detach_signal)
12205         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12206         (linux_nat_target::resume, wait_lwp, stop_callback)
12207         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12208         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12209         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12210         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12211         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12212         type.
12213         (inf_ptrace_target::attach): Update.
12214         (inf_ptrace_target::files_info): Update.
12215         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12216         type.
12217         (go32_nat_target::pid_to_str): Change return type.
12218         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12219         (gnu_nat_target::wait): Update.
12220         (gnu_nat_target::wait): Update.
12221         (gnu_nat_target::resume): Update.
12222         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12223         (fbsd_nat_target::wait): Update.
12224         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12225         type.
12226         (darwin_nat_target::attach): Update.
12227         * corelow.c (class core_target) <pid_to_str>: Change return type.
12228         (core_target::pid_to_str): Change return type.
12229         * target.c (normal_pid_to_str): Change return type.
12230         (default_pid_to_str): Likewise.
12231         (target_pid_to_str): Change return type.
12232         (target_translate_tls_address): Update.
12233         (target_announce_detach): Update.
12234         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12235         return type.
12236         (bsd_uthread_target::pid_to_str): Change return type.
12237         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12238         type.
12239         (bsd_kvm_target::pid_to_str): Change return type.
12240         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12241         return type.
12242         (aix_thread_target::pid_to_str): Change return type.
12243         * target.h (struct target_ops) <pid_to_str>: Change return type.
12244         (target_pid_to_str, normal_pid_to_str): Likewise.
12245         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12246         type.
12247         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12248         type.
12249         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12250         return type.
12251         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12252         type.
12253         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12254         type.
12255         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12256         return type.
12257
12258 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12259
12260         * NEWS: Mention that the new default MI version is 3.  Mention
12261         changes to the output of commands and events that deal with
12262         multi-location breakpoints.
12263         * breakpoint.c: Include "mi/mi-out.h".
12264         (print_one_breakpoint): Change output syntax if using MI version
12265         >= 3.
12266         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12267         New.
12268         (mi_multi_location_breakpoint_output_fixed): New.
12269         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12270         (mi_cmd_fix_multi_location_breakpoint_output): New.
12271         (mi_multi_location_breakpoint_output_fixed): New.
12272         * mi/mi-cmds.c (mi_cmds): Register command
12273         -fix-multi-location-breakpoint-output.
12274         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12275         interpreter "mi".
12276
12277 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12278
12279         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12280         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12281         instantiate mi_ui_out based on interpreter name.
12282         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12283         * mi/mi-main.c (mi_load_progress): Likewise.
12284
12285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12286
12287         * NEWS: Combine separate "New targets" sections for 8.3.
12288
12289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12290
12291         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12292         (ppcfbsd_init_abi): Install gdbarch
12293         "fetch_tls_load_module_address" and "get_thread_local_address"
12294         methods.
12295
12296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12297
12298         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12299         (riscv_fbsd_init_abi): Install gdbarch
12300         "fetch_tls_load_module_address" and "get_thread_local_address"
12301         methods.
12302
12303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12304
12305         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12306         (i386fbsd_init_abi): Install gdbarch
12307         "fetch_tls_load_module_address" and "get_thread_local_address"
12308         methods.
12309
12310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12311
12312         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12313         (amd64fbsd_init_abi): Install gdbarch
12314         "fetch_tls_load_module_address" and "get_thread_local_address"
12315         methods.
12316
12317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12318
12319         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12320         (struct fbsd_pspace_data): New type.
12321         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12322         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12323         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12324         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12325         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12326
12327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12328
12329         * gdbtypes.c (lookup_struct_elt): New function.
12330         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12331         * gdbtypes.h (struct struct_elt): New type.
12332         (lookup_struct_elt): New prototype.
12333
12334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12335
12336         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12337         remove disabled code block.
12338
12339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12340
12341         * gdbarch.sh (get_thread_local_address): New method.
12342         * gdbarch.h, gdbarch.c: Regenerate.
12343         * target.c (target_translate_tls_address): Use
12344         gdbarch_get_thread_local_address if present instead of
12345         target::get_thread_local_address.
12346
12347 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12348
12349         * target.h (target::get_thread_local_address): Update comment.
12350
12351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12352
12353         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12354         objfile->separate_debug_objfile_backlink if not NULL.
12355
12356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12357
12358         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12359         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12360         (amd64bsd_store_inferior_registers): Likewise.
12361         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12362         Enable segment base registers.
12363         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12364         PT_GETFSBASE and PT_GETGSBASE.
12365         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12366         PT_SETGSBASE.
12367         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12368         segment base registers.
12369         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12370
12371 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12372
12373         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12374         Update calls to i386_target_description to add 'segments'
12375         parameter.
12376         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12377         add segment base registers.
12378         * arch/i386.c (i386_create_target_description): Add 'segments'
12379         parameter to enable segment base registers.
12380         * arch/i386.h (i386_create_target_description): Likewise.
12381         * features/i386/32bit-segments.xml: New file.
12382         * features/i386/32bit-segments.c: Generate.
12383         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12384         call to i386_target_description to add 'segments' parameter.
12385         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12386         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12387         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12388         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12389         if feature is present.
12390         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12391         Add 'segments' parameter to call to i386_target_description.
12392         (i386_target_description): Add 'segments' parameter to enable
12393         segment base registers.
12394         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12395         to call to i386_target_description.
12396         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12397         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12398         Define I386_NUM_REGS.
12399         (i386_target_description): Add 'segments' parameter to enable
12400         segment base registers.
12401
12402 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12403
12404         PR/24325
12405         * source-cache.c: #undef open and close, to avoid unresolved
12406         externals during linking.
12407
12408 2019-03-12  Tom Tromey  <tromey@adacore.com>
12409
12410         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12411         const.  Add initializers.
12412         (_initialize_remote): Don't initialize ptid globals.
12413
12414 2019-03-12  Pedro Alves  <palves@redhat.com>
12415
12416         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12417
12418 2019-03-12  Pedro Alves  <palves@redhat.com>
12419
12420         * cp-name-parser.y (main): Remove unused 'len' variable.
12421
12422 2019-03-12  Tom Tromey  <tromey@adacore.com>
12423
12424         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12425         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12426
12427 2019-03-12  Tom Tromey  <tromey@adacore.com>
12428
12429         * linux-nat.c (iterate_over_lwps): Update.
12430         (stop_callback): Remove parameter.
12431         (stop_wait_callback, detach_callback, resume_set_callback)
12432         (select_singlestep_lwp_callback, set_ignore_sigint)
12433         (status_callback, resumed_callback, resume_clear_callback)
12434         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12435         data parameter.
12436         (linux_nat_target::detach, linux_nat_target::resume)
12437         (linux_stop_and_wait_all_lwps, select_event_lwp)
12438         (linux_nat_filter_event, linux_nat_wait_1)
12439         (linux_nat_target::kill, linux_nat_target::stop)
12440         (linux_nat_target::stop): Update.
12441         (linux_nat_resume_callback): Change type.
12442         (resume_stopped_resumed_lwps, count_events_callback)
12443         (select_event_lwp_callback): Likewise.
12444         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12445         * arm-linux-nat.c (struct update_registers_data): Remove.
12446         (update_registers_callback): Change type.
12447         (arm_linux_insert_hw_breakpoint1): Update.
12448         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12449         parameter.
12450         (x86_linux_dr_set_addr): Update.
12451         (x86_linux_dr_set_control): Update.
12452         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12453         (iterate_over_lwps): Use gdb::function_view.
12454         * nat/aarch64-linux-hw-point.c (struct
12455         aarch64_dr_update_callback_param): Remove.
12456         (debug_reg_change_callback): Change type.
12457         (aarch64_notify_debug_reg_change): Update.
12458         * s390-linux-nat.c (s390_refresh_per_info): Update.
12459
12460 2019-03-11  Tom Tromey  <tromey@adacore.com>
12461
12462         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12463         redundant assignment to "this_cu".
12464
12465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12466
12467         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12468
12469 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12470
12471         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12472         from...
12473         (rank_one_type): ... this.
12474
12475 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12476
12477         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12478         from...
12479         (rank_one_type): ... this.
12480
12481 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12482
12483         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12484         from...
12485         (rank_one_type): ... this.
12486
12487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12488
12489         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12490         from...
12491         (rank_one_type): ... this.
12492
12493 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12494
12495         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12496         from...
12497         (rank_one_type): ... this.
12498
12499 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12500
12501         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12502         from...
12503         (rank_one_type): ... this.
12504
12505 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12506
12507         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12508         from...
12509         (rank_one_type): ... this.
12510
12511 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12512
12513         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12514         from...
12515         (rank_one_type): ... this.
12516
12517 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12518
12519         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12520         from...
12521         (rank_one_type): ... this.
12522
12523 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12524
12525         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12526         from...
12527         (rank_one_type): ... this.
12528
12529 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12530
12531         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12532         from...
12533         (rank_one_type): ... this.
12534
12535 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12536
12537         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12538         from...
12539         (rank_one_type): ... this.
12540
12541 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12542
12543         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12544         inferior-events' shows the example events.
12545
12546 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12547
12548         Support styling on native MS-Windows console
12549
12550         PR/24315
12551         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12552         on MS-Windows if $TERM is not defined.
12553
12554         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12555
12556         * posix-hdep.c (gdb_console_fputs):
12557         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12558         functions.
12559         * ui-file.h (gdb_console_fputs): Add prototype.
12560
12561         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12562         back to fputs only if the former returns zero.
12563
12564 2019-03-07  Tom Tromey  <tom@tromey.com>
12565
12566         * symmisc.c (print_symbol_bcache_statistics): Update.
12567         (print_objfile_statistics): Update.
12568         * symfile.c (allocate_symtab): Update.
12569         * stabsread.c: Don't include bcache.h.
12570         * psymtab.h (struct psymbol_bcache): Don't declare.
12571         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12572         (psymbol_bcache_init, psymbol_bcache_free)
12573         (psymbol_bcache_get_bcache): Don't declare.
12574         * psymtab.c (struct psymbol_bcache): Remove.
12575         (psymtab_storage::psymtab_storage): Update.
12576         (psymtab_storage::~psymtab_storage): Update.
12577         (psymbol_bcache_init, psymbol_bcache_free)
12578         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12579         (add_psymbol_to_bcache): Update.
12580         (allocate_psymtab): Update.
12581         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12582         macro_cache>: No longer pointers.
12583         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12584         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12585         * macrotab.c (macro_bcache): Update.
12586         * macroexp.c: Don't include bcache.h.
12587         * gdbtypes.c (check_types_worklist): Update.
12588         (types_deeply_equal): Remove TRY/CATCH.  Update.
12589         * elfread.c (elf_symtab_read): Update.
12590         * dwarf2read.c: Don't include bcache.h.
12591         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12592         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12593         (print_bcache_statistics, bcache_memory_used): Don't declare.
12594         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12595         methods.  Rename all data members.
12596         * bcache.c (struct bcache): Move to bcache.h.
12597         (bcache::expand_hash_table): Rename from expand_hash_table.
12598         (bcache): Remove.
12599         (bcache::insert): Rename from bcache_full.
12600         (bcache::compare): Rename from bcache_compare.
12601         (bcache_xmalloc): Remove.
12602         (bcache::~bcache): Rename from bcache_xfree.
12603         (bcache::print_statistics): Rename from print_bcache_statistics.
12604         (bcache::memory_used): Rename from bcache_memory_used.
12605
12606 2019-03-07  Pedro Alves  <palves@redhat.com>
12607
12608         * infrun.c (normal_stop): Also check for
12609         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12610
12611 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12612
12613         * f-lang.c (value_from_host_double): Moved to...
12614         * value.c (value_from_host_double): ...here.
12615         * value.h (value_from_host_double): Declare.
12616         * guile/scm-math.c (vlscm_convert_typed_number): Use
12617         value_from_host_double.
12618         (vlscm_convert_number): Likewise.
12619         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12620         * python/py-value.c (convert_value_from_python): Likewise.
12621
12622 2019-03-06  Tom Tromey  <tom@tromey.com>
12623
12624         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12625
12626 2019-03-06  Tom Tromey  <tom@tromey.com>
12627
12628         * utils.h (free_current_contents): Don't declare.
12629         * utils.c (free_current_contents): Remove.
12630
12631 2019-03-06  Tom Tromey  <tom@tromey.com>
12632
12633         * top.c (quit_force): Update.
12634         * main.c (captured_command_loop): Update.
12635         * common/new-op.c (operator new): Update.
12636         * common/common-exceptions.c (struct catcher)
12637         <save_cleanup_chain>: Remove member.
12638         (exceptions_state_mc_init): Update.
12639         (exception_try_scope_entry): Return nullptr.
12640         (exception_try_scope_exit, exception_rethrow)
12641         (throw_exception_sjlj, throw_exception_cxx): Update.
12642         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12643         (all_cleanups, do_cleanups, discard_cleanups)
12644         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12645         (restore_cleanups, restore_final_cleanups): Don't declare.
12646         (do_final_cleanups): Remove parameter.
12647         * common/cleanups.c (cleanup_chain, make_cleanup)
12648         (make_cleanup_dtor, all_cleanups, do_cleanups)
12649         (discard_my_cleanups, discard_cleanups)
12650         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12651         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12652         (null_cleanup): Remove.
12653         (do_final_cleanups): Remove parameter.
12654
12655 2019-03-06  Tom Tromey  <tom@tromey.com>
12656
12657         * remote.c (remote_target::remote_parse_stop_reply): Use
12658         unique_xmalloc_ptr.
12659
12660 2019-03-06  Tom Tromey  <tom@tromey.com>
12661
12662         * stabsread.c (struct stabs_field_info): Rename from field_info.
12663         <list, fnlist>: Add initializers.
12664         <obstack>: New member.
12665         (read_member_functions, read_struct_fields, read_baseclasses):
12666         Allocate on obstack.  Don't use cleanups.
12667         (read_one_struct_field, read_member_functions, read_struct_fields)
12668         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12669         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12670         (read_struct_type): Update.
12671
12672 2019-03-06  Tom Tromey  <tom@tromey.com>
12673
12674         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12675         * common/filestuff.h (make_cleanup_close): Don't declare.
12676         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12677         Remove.
12678
12679 2019-03-06  Tom Tromey  <tom@tromey.com>
12680
12681         * solib-aix.c: Use make_scope_exit.
12682
12683 2019-03-06  Tom Tromey  <tom@tromey.com>
12684
12685         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12686         Use make_scope_exit.
12687
12688 2019-03-06  Tom Tromey  <tom@tromey.com>
12689
12690         * solib-svr4.c (disable_probes_interface): Remove parameter.
12691         (svr4_handle_solib_event): Use make_scope_exit.
12692
12693 2019-03-06  Tom Tromey  <tom@tromey.com>
12694
12695         * remote.c (struct stop_reply_deleter): Remove.
12696         (stop_reply_up): Update.
12697         (struct stop_reply): Derive from notif_event.  Don't typedef.
12698         <regcache>: Now a std::vector.
12699         (stop_reply_xfree): Remove.
12700         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12701         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12702         (remote_target::discard_pending_stop_replies): Use delete.
12703         (remote_target::remote_parse_stop_reply): Update.
12704         (remote_target::process_stop_reply): Update.
12705         * remote-notif.h (struct notif_event): Add virtual destructor.
12706         Remove "dtr" member.
12707         (struct notif_client) <alloc_event>: Return a unique_ptr.
12708         (notif_event_xfree): Don't declare.
12709         (notif_event_up): New typedef.
12710         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12711         (notif_event_xfree, do_notif_event_xfree): Remove.
12712         (remote_notif_state_xfree): Update.
12713
12714 2019-03-06  Tom Tromey  <tom@tromey.com>
12715
12716         * infrun.c (displaced_step_clear_cleanup): Now a
12717         forward_scope_exit type.
12718         (displaced_step_prepare_throw): Update.
12719         (displaced_step_fixup): Update.
12720
12721 2019-03-06  Tom Tromey  <tom@tromey.com>
12722
12723         * inferior.h (class inferior): Update comment.
12724         * gdbthread.h (class thread_info): Update comment.
12725
12726 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12727             Tom Tromey  <tom@tromey.com>
12728
12729         * stabsread.h (struct stab_section_list): Remove.
12730         (coffstab_build_psymtabs): Update.
12731         * dbxread.c (symbuf_sections): Now a std::vector.
12732         (sect_idx): New global.
12733         (fill_symbuf): Update.
12734         (coffstab_build_psymtabs): Change type of stabsects parameter.
12735         Update.
12736         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12737         std::vector.
12738         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12739         (coff_locate_sections): Update.
12740         (coff_symfile_read): Remove cleanups.  Update.
12741         (init_stringtab): Add storage parameter.
12742         (free_stringtab, free_stringtab_cleanup): Remove.
12743         (init_lineno): Add storage parameter.
12744         (free_linetab, free_linetab_cleanup): Remove.
12745
12746 2019-03-06  Pedro Alves  <palves@redhat.com>
12747
12748         * linux-fork.c (fork_info::clobber_regs): Delete.
12749         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12750         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
12751         comment.  Adjust.
12752         (scoped_switch_fork_info::scoped_switch_fork_info)
12753         (checkpoint_command, linux_fork_context): Adjust
12754         fork_save_infrun_state calls.
12755
12756 2019-03-06  Pedro Alves  <palves@redhat.com>
12757
12758         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12759         (inf_has_multiple_threads): Return 'bool' and rewrite using
12760         inferior_info::threads().
12761
12762 2019-03-06  Pedro Alves  <palves@redhat.com>
12763
12764         * linux-fork.c: Include <list>.
12765         (fork_list): Now a std::list instance.
12766         (fork_info): Add ctor, dtor, and in-class initialize all fields.
12767         (forks_exist_p, find_last_fork): Adjust.
12768         (new_fork): Delete.
12769         (one_fork_p): New.
12770         (add_fork): Adjust.
12771         (free_fork): Delete, folded into fork_info::~fork_info().
12772         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12773         Adjust.
12774         (init_fork_list): Delete.
12775         (linux_fork_killall, linux_fork_mourn_inferior)
12776         (linux_fork_detach, info_checkpoints_command): Adjust.
12777         (_initialize_linux_fork): No longer call init_fork_list.
12778
12779 2019-03-06  Pedro Alves  <palves@redhat.com>
12780
12781         * linux-fork.c (new_fork): New, split out of ...
12782         (add_fork): ... this.  Return void.  Move "first fork" special
12783         case from here, to ...
12784         (checkpoint_command): ... here.
12785         * linux-linux.h (add_fork): Return void.
12786
12787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12788
12789         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12790
12791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12792             Chris January  <chris.january@arm.com>
12793             David Lecomber  <david.lecomber@arm.com>
12794
12795         * f-exp.y: New token, UNOP_INTRINSIC.
12796         (exp): New pattern using UNOP_INTRINSIC token.
12797         (f77_keywords): Add 'abs' keyword.
12798         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12799         (value_from_host_double): New function.
12800         (evaluate_subexp_f): Support UNOP_ABS.
12801
12802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12803
12804         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12805         types.
12806
12807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12808
12809         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12810         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12811         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12812
12813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12814
12815         * f-exp.y (convert_to_kind_type): Handle more type kinds.
12816
12817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12818             Chris January  <chris.january@arm.com>
12819
12820         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12821         * f-exp.y: Define 'KIND' token.
12822         (exp): New pattern for KIND expressions.
12823         (ptype): Handle types with a kind extension.
12824         (direct_abs_decl): Extend to spot kind extensions.
12825         (f77_keywords): Add 'kind' to the list.
12826         (push_kind_type): New function.
12827         (convert_to_kind_type): New function.
12828         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12829         * parse.c (operator_length_standard): Likewise.
12830         * parser-defs.h (enum type_pieces): Add tp_kind.
12831         * std-operator.def: Add UNOP_KIND.
12832
12833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12834
12835         * f-exp.y (f_parse): Set yydebug.
12836
12837 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12838
12839         * f-lang.c (evaluate_subexp_f): New function.
12840         (exp_descriptor_f): New global.
12841         (f_language_defn): Use exp_descriptor_f instead of
12842         exp_descriptor_standard.
12843
12844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12845
12846         * f-exp.y (struct token): Add comments.
12847         (dot_ops): Remove uppercase versions and the end marker.
12848         (f77_keywords): Likewise.
12849         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12850         entries in the dot_ops array are case insensitive, and use
12851         strncasecmp to compare strings.  Also some whitespace cleanup in
12852         this area.  Similar for the f77_keywords array, except entries in
12853         this list might be case sensitive.
12854
12855 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12856
12857         * f-exp.y (struct f77_boolean_val): Add comments.
12858         (boolean_values): Remove uppercase versions, and end marker.
12859         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12860         and use strncasecmp to achieve case insensitivity.  Additionally,
12861         perform whitespace cleanup around this code.
12862
12863 2019-03-06  Tom Tromey  <tromey@adacore.com>
12864
12865         * remote-sim.c (gdbsim_target_open): Use result of
12866         gdb_argv::release.
12867
12868 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
12869         Dirk Schubert  <dirk.schubert@arm.com>
12870         Chris January  <chris.january@arm.com>
12871
12872         * eval.c (evaluate_subexp_standard): Call Fortran argument
12873         wrapping logic.
12874         * f-lang.c (struct value): A value which can be passed into a
12875         Fortran function call.
12876         (fortran_argument_convert): Wrap Fortran arguments in a pointer
12877         where appropriate.
12878         (struct type): Value ready for a Fortran function call.
12879         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12880         is needed.
12881         * f-lang.h (fortran_argument_convert): Declaration.
12882         (fortran_preserve_arg_pointer): Declaration.
12883         * infcall.c (value_arg_coerce): Call Fortran argument logic.
12884
12885 2019-03-05  Tom Tromey  <tromey@adacore.com>
12886
12887         * python/py-prettyprint.c (print_string_repr): Remove #if.
12888         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12889
12890 2019-03-05  Tom Tromey  <tromey@adacore.com>
12891
12892         * target.c (the_dummy_target): Move later.  Change type to
12893         "dummy_target".
12894         (initialize_targets): Don't initialize the_dummy_target.
12895
12896 2019-03-05  Tom Tromey  <tromey@adacore.com>
12897
12898         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12899         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12900
12901 2019-03-05  Tom Tromey  <tromey@adacore.com>
12902
12903         * windows-nat.c (windows_nat_target::attach)
12904         (windows_nat_target::detach): Don't call gdb_flush.
12905         * valprint.c (generic_val_print, val_print, val_print_string):
12906         Don't call gdb_flush.
12907         * utils.c (defaulted_query): Don't call gdb_flush.
12908         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12909         * target.c (target_announce_detach): Don't call gdb_flush.
12910         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12911         * remote.c (extended_remote_target::attach): Don't call
12912         gdb_flush.
12913         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12914         * printcmd.c (do_examine): Don't call gdb_flush.
12915         (info_display_command): Don't call gdb_flush.
12916         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12917         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12918         * memattr.c (info_mem_command): Don't call gdb_flush.
12919         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12920         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12921         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12922         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12923         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12924         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12925         (gnu_nat_target::detach): Don't call gdb_flush.
12926         * f-valprint.c (f_val_print): Don't call gdb_flush.
12927         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12928         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12929         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12930         gdb_flush.
12931         * c-valprint.c (c_val_print): Don't call gdb_flush.
12932         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12933
12934 2019-03-05  Tom Tromey  <tromey@adacore.com>
12935
12936         * varobj.c (update_dynamic_varobj_children): Update.
12937         (install_default_visualizer): Use reset, not release.
12938         * value.c (set_internalvar): Update.
12939         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12940         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12941         ATTRIBUTE_UNUSED_RESULT.
12942
12943 2019-03-05  Tom Tromey  <tromey@adacore.com>
12944
12945         * remote.c (class scoped_remote_fd) <release>: Add
12946         ATTRIBUTE_UNUSED_RESULT.
12947
12948 2019-03-05  Tom Tromey  <tromey@adacore.com>
12949
12950         * macroexp.c (struct macro_buffer) <release>: Add
12951         ATTRIBUTE_UNUSED_RESULT.
12952
12953 2019-03-05  Tom Tromey  <tromey@adacore.com>
12954
12955         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12956         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12957         ATTRIBUTE_UNUSED_RESULT.
12958
12959 2019-03-05  Tom Tromey  <tromey@adacore.com>
12960
12961         * common/scoped_fd.h (class scoped_fd) <release>: Add
12962         ATTRIBUTE_UNUSED_RESULT.
12963
12964 2019-03-05  Tom Tromey  <tromey@adacore.com>
12965
12966         * parser-defs.h (struct parser_state) <release>: Add
12967         ATTRIBUTE_UNUSED_RESULT.
12968
12969 2019-03-05  Tom Tromey  <tromey@adacore.com>
12970
12971         * utils.h (class gdb_argv) <release>: Add
12972         ATTRIBUTE_UNUSED_RESULT.
12973         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12974
12975 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12976
12977         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12978         for-loop range, to avoid compiler warnings.
12979
12980         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12981         avoid compiler warnings about unused variables.
12982
12983         * NEWS: Mention end of support for native debugging on MS-Windows
12984         before XP.
12985
12986         PR gdb/24292
12987         * common/netstuff.c:
12988         * gdbserver/gdbreplay.c
12989         * gdbserver/remote-utils.c:
12990         * ser-tcp.c:
12991         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12992         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12993         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12994         'getaddrinfo' and 'freeaddrinfo' were not available before
12995         Windows XP, and mingw.org's MinGW headers by default define
12996         _WIN32_WINNT to 0x500.
12997
12998 2019-03-01  Gary Benson <gbenson@redhat.com>
12999
13000         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13001
13002 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13003             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13004
13005         PR gdb/8527
13006         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13007         set_sigint_trap, clear_sigint_trap.
13008
13009 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13010
13011         * target.c (target_detach): Clear the regcache and the
13012         frame cache.
13013
13014 2019-02-27  Pedro Alves  <palves@redhat.com>
13015
13016         * utils.c (set_screen_size): When we cap the height/width sizes,
13017         tweak the corresponding command variable to show "unlimited":
13018
13019 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13020             Pedro Alves  <palves@redhat.com>
13021
13022         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13023         before calling rl_set_screen_size.
13024
13025 2019-02-27  Tom Tromey  <tromey@adacore.com>
13026
13027         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13028         define.
13029         * python/py-value.c: Remove Python 2.4 workaround.
13030         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13031         workaround.
13032         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13033         Python 2.4 workaround.
13034         * python/python-internal.h: Remove Python 2.4 comment.
13035         (Py_ssize_t): Don't define.
13036         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13037         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13038         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13039         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13040         * python/python.c (do_start_initialization): Remove Python 2.4
13041         workaround.
13042         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13043         (print_children): Remove Python 2.4 workaround.
13044         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13045         workaround.
13046         (CHARBUFFERPROC_NAME): Remove.
13047         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13048         Python 2.4 workaround.
13049
13050 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13051
13052         * NEWS: Note minimum Python version.
13053
13054 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13055
13056         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13057         code from these functions.  Remove corresponding ifdefs.  Use
13058         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13059         Remove gotos and target of gotos.
13060         (infpy_search_memory): Likewise.
13061
13062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13063
13064         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13065         (hppa_gdbarch_init): Don't register deleted functions with
13066         gdbarch.
13067
13068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13069
13070         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13071         (h8300_unwind_sp): Delete.
13072         (h8300_dummy_id): Delete.
13073         (h8300_gdbarch_init): Don't register deleted functions with
13074         gdbarch.
13075
13076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13077
13078         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13079         (ft32_unwind_pc): Delete.
13080         (ft32_unwind_sp): Delete.
13081         (ft32_gdbarch_init): Don't register deleted functions with
13082         gdbarch.
13083
13084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13085
13086         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13087         (frv_unwind_pc): Delete.
13088         (frv_unwind_sp): Delete.
13089         (frv_gdbarch_init): Don't register deleted functions with
13090         gdbarch.
13091
13092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13093
13094         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13095         (riscv_unwind_pc): Delete.
13096         (riscv_unwind_sp): Delete.
13097         (riscv_gdbarch_init): Don't register deleted functions with
13098         gdbarch.
13099
13100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13101
13102         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13103         (csky_unwind_pc): Delete.
13104         (csky_unwind_sp): Delete.
13105         (csky_gdbarch_init): Don't register deleted functions with
13106         gdbarch.
13107
13108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13109
13110         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13111         (cris_unwind_pc): Delete.
13112         (cris_unwind_sp): Delete.
13113         (cris_gdbarch_init): Don't register deleted functions with
13114         gdbarch.
13115
13116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13117
13118         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13119         (bfin_unwind_pc): Delete.
13120         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13121
13122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13123
13124         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13125         (arm_unwind_pc): Delete.
13126         (arm_unwind_sp): Delete.
13127         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13128
13129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13130
13131         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13132         (arc_unwind_pc): Delete.
13133         (arc_unwind_sp): Delete.
13134         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13135
13136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13137
13138         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13139         (alpha_unwind_pc): Delete.
13140         (alpha_gdbarch_init): Don't register deleted functions with
13141         gdbarch.
13142
13143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13144
13145         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13146         (aarch64_unwind_pc): Delete.
13147         (aarch64_unwind_sp): Delete.
13148         (aarch64_gdbarch_init): Don't register deleted functions with
13149         gdbarch.
13150
13151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13152
13153         * gdbtypes.c (type_align): Don't consider static members when
13154         computing structure alignment.
13155
13156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13157
13158         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13159         return 0 for other types.
13160         * arch-utils.c (default_type_align): Always return 0.
13161         * gdbarch.h: Regenerate.
13162         * gdbarch.sh (type_align): Extend comment.
13163         * gdbtypes.c (type_align): Add additional comments, always call
13164         gdbarch_type_align before applying the default rules.
13165         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13166         generic code will then apply a suitable default.
13167         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13168         types, return 0 for other types.
13169
13170 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13171
13172         * NEWS: Create a new section for the next release branch.
13173         Rename the section of the current branch, now that it has
13174         been cut.
13175
13176 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13177
13178         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13179         * version.in: Bump version to 8.3.50.DATE-git.
13180
13181 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13182
13183         * aix-thread.c (ptid_cmp): Remove unused variable.
13184         (get_signaled_thread): Likewise.
13185         (store_regs_user_thread): Likewise.
13186         (store_regs_kernel_thread): Likewise.
13187         (fetch_regs_kernel_thread): Remove shadowed variable.
13188
13189 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13190
13191         * features/riscv/32bit-cpu.xml: Add register numbers.
13192         * features/riscv/32bit-fpu.c: Regenerate.
13193         * features/riscv/32bit-fpu.xml: Add register numbers.
13194         * features/riscv/64bit-cpu.xml: Add register numbers.
13195         * features/riscv/64bit-fpu.c: Regenerate.
13196         * features/riscv/64bit-fpu.xml: Add register numbers.
13197
13198 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13199
13200         * NEWS: Mention two argument form of gdb.Value constructor.
13201         * python/py-value.c (convert_buffer_and_type_to_value): New
13202         function.
13203         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13204         Add support for handling an optional second argument.  Call
13205         convert_buffer_and_type_to_value as appropriate.
13206         * python/python-internal.h (Py_buffer_deleter): New struct.
13207         (Py_buffer_up): New typedef.
13208
13209 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13210
13211         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13212         instead of releasing ownership.
13213
13214 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13215
13216         * dwarf2read.c (open_and_init_dwp_file): Call
13217         elf_numsections instead of bfd_count_sections to initialize
13218         dwp_file->num_sections.
13219
13220 2019-02-25  Tom Tromey  <tromey@adacore.com>
13221
13222         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13223
13224 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13225
13226         * gcore.in: Add '--readnever' option when invoking GDB.
13227
13228 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13229
13230         * MAINTAINERS: Update my email address.
13231
13232 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13233
13234         * build-id.c (build_id_to_debug_bfd_1): New function.
13235         (build_id_to_debug_bfd): Look for separate debug file in
13236         sysroot.
13237
13238 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13239
13240         * gdbarch.sh: Update the copyright year range that is placed into
13241         generated files.
13242
13243 2019-02-22  Keith Seitz  <keiths@redhat.com>
13244
13245         PR symtab/23853
13246         * linespec.c (create_sals_line_offset): Search for the default
13247         symtab's filename instead of its fullname.
13248
13249 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13250
13251         * NEWS: Update style defaults.
13252
13253 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13254
13255         * main.c (captured_main_1): Disable styling in batch mode.
13256
13257 2019-02-20  Tom Tromey  <tom@tromey.com>
13258
13259         * symtab.c (symtab_symbol_info): Fix typos.
13260
13261 2019-02-20  Tom Tromey  <tromey@adacore.com>
13262
13263         * findcmd.c (_initialize_mem_search): Use upper case for
13264         metasyntactic variables.
13265
13266 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13267
13268         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13269         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13270
13271 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13272
13273         * top.h (source_file_name): Change to std::string.
13274         * top.c (source_file_name): Likewise.
13275         (command_line_input): Adjust.
13276         * cli/cli-script.c (script_from_file): Adjust.
13277
13278 2019-02-19  Tom Tromey  <tromey@adacore.com>
13279
13280         * ravenscar-thread.c
13281         (ravenscar_thread_target::update_thread_list): Don't call
13282         ada_build_task_list.
13283         * ada-lang.h (ada_build_task_list): Don't declare.
13284         * ada-tasks.c (struct ada_tasks_inferior_data)
13285         <task_list_valid_p>: Now bool.
13286         (read_known_tasks, ada_task_list_changed)
13287         (ada_tasks_invalidate_inferior_data): Update.
13288         (read_known_tasks_array): Return bool.
13289         (read_known_tasks_list): Likewise.
13290         (read_known_tasks): Return void.
13291         (ada_build_task_list): Now static.
13292
13293 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13294
13295         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13296         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13297
13298 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13299
13300         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13301         variant for ada_tasks_pspace_data_handle and
13302         ada_tasks_inferior_data_handle.
13303         (ada_tasks_pspace_data_cleanup): New function.
13304         (ada_tasks_inferior_data_cleanup): New function.
13305
13306 2019-02-17  Tom Tromey  <tom@tromey.com>
13307
13308         * macrotab.h (macro_source_fullname): Return a std::string.
13309         * macrotab.c (macro_include, check_for_redefinition)
13310         (macro_undef, macro_lookup_definition, foreach_macro)
13311         (foreach_macro_in_scope): Update.
13312         (macro_source_fullname): Return a std::string.
13313         * macrocmd.c (show_pp_source_pos): Update.
13314
13315 2019-02-17  Tom Tromey  <tom@tromey.com>
13316
13317         * macrocmd.c (show_pp_source_pos): Style the file names.
13318
13319 2019-02-17  Tom Tromey  <tom@tromey.com>
13320
13321         PR tui/24197:
13322         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13323
13324 2019-02-17  Tom Tromey  <tom@tromey.com>
13325
13326         * ada-lang.c (user_select_syms): Use filtered printing.
13327         * utils.c (wrap_style): New global.
13328         (desired_style): Remove.
13329         (emit_style_escape): Add stream parameter.
13330         (set_output_style, reset_terminal_style, prompt_for_continue):
13331         Update.
13332         (flush_wrap_buffer): Only flush gdb_stdout.
13333         (wrap_here): Set wrap_style.
13334         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13335         treat escape sequences as a character.  Change when wrap buffer is
13336         flushed.
13337         (fputs_styled): Do not set the output style when the default is
13338         requested.
13339         * ui-style.h (struct ui_file_style) <is_default>: New method.
13340         * source.c (print_source_lines_base): Emit escape sequences in one
13341         piece.
13342
13343 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13344
13345         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13346         integers and enumeration types.
13347
13348 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13349
13350         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13351         instead of lookup_symbol_in_language
13352         (do_exact_match): New function.
13353         (ada_get_symbol_name_matcher): Return do_exact_match when
13354         doing a verbatim match.
13355
13356 2019-02-15  Tom Tromey  <tromey@adacore.com>
13357
13358         * ravenscar-thread.c (ravenscar_thread_target::resume)
13359         (ravenscar_thread_target::wait): Special case wildcard requests.
13360
13361 2019-02-15  Tom Tromey  <tromey@adacore.com>
13362
13363         * ravenscar-thread.c (base_ptid): Remove.
13364         (struct ravenscar_thread_target) <close>: New method.
13365         <m_base_ptid>: New member.
13366         <update_inferior_ptid, active_task, task_is_currently_active,
13367         runtime_initialized>: Declare methods.
13368         <ravenscar_thread_target>: Add constructor.
13369         (ravenscar_thread_target::task_is_currently_active)
13370         (ravenscar_thread_target::update_inferior_ptid)
13371         (ravenscar_runtime_initialized): Rename.  Now methods.
13372         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13373         (ravenscar_thread_target::update_thread_list): Update.
13374         (ravenscar_thread_target::active_task): Now method.
13375         (ravenscar_thread_target::store_registers)
13376         (ravenscar_thread_target::prepare_to_store)
13377         (ravenscar_thread_target::prepare_to_store)
13378         (ravenscar_thread_target::mourn_inferior): Update.
13379         (ravenscar_inferior_created): Use "new" to create target.
13380         (ravenscar_thread_target::get_ada_task_ptid): Update.
13381         (_initialize_ravenscar): Don't initialize base_ptid.
13382         (ravenscar_ops): Remove global.
13383
13384 2019-02-15  Tom Tromey  <tromey@adacore.com>
13385
13386         * target.h (push_target): Declare new overload.
13387         * target.c (push_target): New overload, taking an rvalue reference.
13388         * remote.c (remote_target::open_1): Use push_target overload.
13389         * corelow.c (core_target_open): Use push_target overload.
13390
13391 2019-02-15  Tom Tromey  <tromey@adacore.com>
13392
13393         * ravenscar-thread.c (is_ravenscar_task)
13394         (ravenscar_task_is_currently_active): Return bool.
13395         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13396         (_initialize_ravenscar): Remove "(void)".
13397         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13398         Return bool.
13399
13400 2019-02-15  Tom Tromey  <tromey@adacore.com>
13401
13402         * ravenscar-thread.c (ravenscar_runtime_initializer)
13403         (has_ravenscar_runtime, get_running_thread_id)
13404         (ravenscar_thread_target::resume): Fix indentation.
13405
13406 2019-02-15  Tom Tromey  <tromey@adacore.com>
13407
13408         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13409         from ravenscar_arch_ops.
13410         (sparc_ravenscar_ops::fetch_registers)
13411         (sparc_ravenscar_ops::store_registers): Now methods.
13412         (sparc_ravenscar_prepare_to_store): Remove.
13413         (sparc_ravenscar_ops): Redefine.
13414         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13415         methods and destructor.  Remove members.
13416         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13417         (ravenscar_thread_target::store_registers)
13418         (ravenscar_thread_target::prepare_to_store): Update.
13419         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13420         Remove.
13421         (struct ppc_ravenscar_powerpc_ops): Derive from
13422         ravenscar_arch_ops.
13423         (ppc_ravenscar_powerpc_ops::fetch_registers)
13424         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13425         (ppc_ravenscar_powerpc_ops): Redefine.
13426         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13427         (ppc_ravenscar_e500_ops::fetch_registers)
13428         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13429         (ppc_ravenscar_e500_ops): Redefine.
13430         * aarch64-ravenscar-thread.c
13431         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13432         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13433         (aarch64_ravenscar_fetch_registers)
13434         (aarch64_ravenscar_store_registers): Now methods.
13435         (aarch64_ravenscar_ops): Redefine.
13436
13437 2019-02-15  Tom Tromey  <tromey@adacore.com>
13438
13439         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13440         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13441         (ravenscar_thread_target::stopped_by_watchpoint)
13442         (ravenscar_thread_target::stopped_data_address)
13443         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13444
13445 2019-02-15  Tom Tromey  <tromey@adacore.com>
13446
13447         * ravenscar-thread.c: Fix some typos.
13448
13449 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13450             Tom Tromey  <tromey@adacore.com>
13451
13452         * ada-lang.c (ada_exception_sal): Change addr_string to a
13453         std::string.
13454         (create_ada_exception_catchpoint): Update.
13455
13456 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13457             Tom Tromey  <tromey@adacore.com>
13458
13459         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13460         (bp_location_ops): Remove.
13461         (base_breakpoint_allocate_location): Update.
13462         (free_bp_location): Update.
13463         * ada-lang.c (class ada_catchpoint_location)
13464         <ada_catchpoint_location>: Remove ops parameter.
13465         (ada_catchpoint_location_dtor): Remove.
13466         (ada_catchpoint_location_ops): Remove.
13467         (allocate_location_exception): Update.
13468         * breakpoint.h (struct bp_location_ops): Remove.
13469         (class bp_location) <bp_location>: Remove bp_location_ops
13470         parameter.
13471         <~bp_location>: Add destructor.
13472         <ops>: Remove.
13473
13474 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13475             Pedro Alves  <palves@redhat.com>
13476
13477         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13478         'PATH_MAX'.
13479
13480 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13481             Samuel Thibault  <samuel.thibault@gnu.org>
13482             Thomas Schwinge  <thomas@codesourcery.com>
13483
13484         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13485         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13486
13487 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13488
13489         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13490         (check_empty): Use "const char *".
13491
13492         * gnu-nat.c (gnu_nat_target::detach): Instead of
13493         'detach_inferior (pid)' call
13494         'detach_inferior (find_inferior_pid (pid))'.
13495
13496         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13497         'nat/fork-inferior.o'.
13498         * gnu-nat.c: #include "nat/fork-inferior.h".
13499
13500         * gnu-nat.c (gnu_nat_target::detach): Instead of
13501         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13502         * gnu-nat.h: #include "inf-child.h".
13503         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13504         'i386_gnu_nat_target::fetch_registers'.
13505         (gnu_store_registers): Rename/move to
13506         'i386_gnu_nat_target::store_registers'.
13507
13508         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13509         * gnu-nat.h (mach_thread_info): New function.
13510         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13511
13512         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13513
13514 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13515
13516         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13517
13518 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13519
13520         * windows-nat.c (windows_add_thread): Add new parameter
13521         "main_thread_p" with default value set to false.  Update
13522         function documentation as well as all callers.
13523         (windows_delete_thread): Likewise.
13524         (fake_create_process): Update call to windows_add_thread.
13525         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13526         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13527         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13528         call to windows_delete_thread.
13529
13530 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13531
13532         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13533
13534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13535
13536         * symfile.c (find_separate_debug_file): Use canonical path of
13537         sysroot with child_path instead of gdb_sysroot if it is valid.
13538
13539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13540
13541         * symfile.c (find_separate_debug_file): Use child_path to
13542         determine if an object file is under a sysroot.
13543
13544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13545
13546         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13547         unittests/child-path-selftests.c.
13548         * common/pathstuff.c (child_path): New function.
13549         * common/pathstuff.h (child_path): New prototype.
13550         * unittests/child-path-selftests.c: New file.
13551
13552 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13553
13554         * symfile.c (find_separate_debug_file): Look for separate debug
13555         files in debug directories under the sysroot.
13556
13557 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13558
13559         * symtab.h (struct minimal_symbol data_p): New const method.
13560         (struct minimal_symbol text_p): Likewise.
13561         * symtab.c (output_source_filename): Use file name style
13562         to print file name.
13563         (print_symbol_info): Likewise.
13564         (print_msymbol_info): Use address style to print addresses.
13565         Use function name style to print executable text symbols.
13566         (expand_symtab_containing_pc): Use data_p.
13567         (find_pc_sect_compunit_symtab): Likewise.
13568
13569 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13570
13571         * breakpoint.c (describe_other_breakpoints): Use address style
13572         to print addresses.
13573         (say_where): Likewise.
13574
13575 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13576
13577         * ada-typeprint.c (print_func_type): Print function name
13578         style to print function name.
13579         * c-typeprint.c (c_print_type_1): Likewise.
13580
13581 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13582
13583         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13584         for execve.
13585
13586 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13587
13588         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13589         type_stack.
13590
13591 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13592
13593         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13594         TYPE_CODE_REF types.
13595
13596 2019-02-08  Jim Wilson  <jimw@sifive.com>
13597
13598         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13599         (riscv_linux_fregset): New.
13600         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13601
13602 2019-02-07  Tom Tromey  <tom@tromey.com>
13603
13604         * thread.c (thread_cancel_execution_command): Update.
13605         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13606         methods.
13607         (struct thread_fsm_ops): Remove.
13608         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13609         (thread_fsm_should_stop, thread_fsm_return_value)
13610         (thread_fsm_set_finished, thread_fsm_finished_p)
13611         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13612         Don't declare.
13613         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13614         * infrun.c (clear_proceed_status_thread)
13615         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13616         (print_stop_event): Update.
13617         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13618         Add constructor.
13619         (step_command_fsm_ops): Remove.
13620         (new_step_command_fsm): Remove.
13621         (step_1): Update.
13622         (step_command_fsm::should_stop): Rename from
13623         step_command_fsm_should_stop.
13624         (step_command_fsm::clean_up): Rename from
13625         step_command_fsm_clean_up.
13626         (step_command_fsm::do_async_reply_reason): Rename from
13627         step_command_fsm_async_reply_reason.
13628         (struct until_next_fsm): Inherit from thread_fsm.  Add
13629         constructor.
13630         (until_next_fsm_ops): Remove.
13631         (new_until_next_fsm): Remove.
13632         (until_next_fsm::should_stop): Rename from
13633         until_next_fsm_should_stop.
13634         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13635         (until_next_fsm::do_async_reply_reason): Rename from
13636         until_next_fsm_async_reply_reason.
13637         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13638         constructor.  Change type of breakpoint.
13639         (finish_command_fsm_ops): Remove.
13640         (new_finish_command_fsm): Remove.
13641         (finish_command_fsm::should_stop): Rename from
13642         finish_command_fsm_should_stop.
13643         (finish_command_fsm::clean_up): Rename from
13644         finish_command_fsm_clean_up.
13645         (finish_command_fsm::return_value): Rename from
13646         finish_command_fsm_return_value.
13647         (finish_command_fsm::do_async_reply_reason): Rename from
13648         finish_command_fsm_async_reply_reason.
13649         (finish_command): Update.
13650         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13651         Add constructor.
13652         (call_thread_fsm_ops): Remove.
13653         (call_thread_fsm::call_thread_fsm): Rename from
13654         new_call_thread_fsm.
13655         (call_thread_fsm::should_stop): Rename from
13656         call_thread_fsm_should_stop.
13657         (call_thread_fsm::should_notify_stop): Rename from
13658         call_thread_fsm_should_notify_stop.
13659         (run_inferior_call, call_function_by_hand_dummy): Update.
13660         * cli/cli-interp.c (should_print_stop_to_console): Update.
13661         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13662         Add constructor.  Change type of location_breakpoint,
13663         caller_breakpoint.
13664         (until_break_fsm_ops): Remove.
13665         (new_until_break_fsm): Remove.
13666         (until_break_fsm::should_stop): Rename from
13667         until_break_fsm_should_stop.
13668         (until_break_fsm::clean_up): Rename from
13669         until_break_fsm_clean_up.
13670         (until_break_fsm::do_async_reply_reason): Rename from
13671         until_break_fsm_async_reply_reason.
13672         (until_break_command): Update.
13673         * thread-fsm.c: Remove.
13674         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13675
13676 2019-02-07  Tom Tromey  <tom@tromey.com>
13677
13678         * yy-remap.h: Add include guard.
13679         * xtensa-tdep.h: Add include guard.
13680         * xcoffread.h: Rename include guard.
13681         * varobj-iter.h: Add include guard.
13682         * tui/tui.h: Rename include guard.
13683         * tui/tui-winsource.h: Rename include guard.
13684         * tui/tui-wingeneral.h: Rename include guard.
13685         * tui/tui-windata.h: Rename include guard.
13686         * tui/tui-win.h: Rename include guard.
13687         * tui/tui-stack.h: Rename include guard.
13688         * tui/tui-source.h: Rename include guard.
13689         * tui/tui-regs.h: Rename include guard.
13690         * tui/tui-out.h: Rename include guard.
13691         * tui/tui-layout.h: Rename include guard.
13692         * tui/tui-io.h: Rename include guard.
13693         * tui/tui-hooks.h: Rename include guard.
13694         * tui/tui-file.h: Rename include guard.
13695         * tui/tui-disasm.h: Rename include guard.
13696         * tui/tui-data.h: Rename include guard.
13697         * tui/tui-command.h: Rename include guard.
13698         * tic6x-tdep.h: Add include guard.
13699         * target/waitstatus.h: Rename include guard.
13700         * target/wait.h: Rename include guard.
13701         * target/target.h: Rename include guard.
13702         * target/resume.h: Rename include guard.
13703         * target-float.h: Rename include guard.
13704         * stabsread.h: Add include guard.
13705         * rs6000-tdep.h: Add include guard.
13706         * riscv-fbsd-tdep.h: Add include guard.
13707         * regformats/regdef.h: Rename include guard.
13708         * record.h: Rename include guard.
13709         * python/python.h: Rename include guard.
13710         * python/python-internal.h: Rename include guard.
13711         * python/py-stopevent.h: Rename include guard.
13712         * python/py-ref.h: Rename include guard.
13713         * python/py-record.h: Rename include guard.
13714         * python/py-record-full.h: Rename include guard.
13715         * python/py-record-btrace.h: Rename include guard.
13716         * python/py-instruction.h: Rename include guard.
13717         * python/py-events.h: Rename include guard.
13718         * python/py-event.h: Rename include guard.
13719         * procfs.h: Add include guard.
13720         * proc-utils.h: Add include guard.
13721         * p-lang.h: Add include guard.
13722         * or1k-tdep.h: Rename include guard.
13723         * observable.h: Rename include guard.
13724         * nto-tdep.h: Rename include guard.
13725         * nat/x86-linux.h: Rename include guard.
13726         * nat/x86-linux-dregs.h: Rename include guard.
13727         * nat/x86-gcc-cpuid.h: Add include guard.
13728         * nat/x86-dregs.h: Rename include guard.
13729         * nat/x86-cpuid.h: Rename include guard.
13730         * nat/ppc-linux.h: Rename include guard.
13731         * nat/mips-linux-watch.h: Rename include guard.
13732         * nat/linux-waitpid.h: Rename include guard.
13733         * nat/linux-ptrace.h: Rename include guard.
13734         * nat/linux-procfs.h: Rename include guard.
13735         * nat/linux-osdata.h: Rename include guard.
13736         * nat/linux-nat.h: Rename include guard.
13737         * nat/linux-namespaces.h: Rename include guard.
13738         * nat/linux-btrace.h: Rename include guard.
13739         * nat/glibc_thread_db.h: Rename include guard.
13740         * nat/gdb_thread_db.h: Rename include guard.
13741         * nat/gdb_ptrace.h: Rename include guard.
13742         * nat/fork-inferior.h: Rename include guard.
13743         * nat/amd64-linux-siginfo.h: Rename include guard.
13744         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13745         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13746         * nat/aarch64-linux.h: Rename include guard.
13747         * nat/aarch64-linux-hw-point.h: Rename include guard.
13748         * mn10300-tdep.h: Add include guard.
13749         * mips-linux-tdep.h: Add include guard.
13750         * mi/mi-parse.h: Rename include guard.
13751         * mi/mi-out.h: Rename include guard.
13752         * mi/mi-main.h: Rename include guard.
13753         * mi/mi-interp.h: Rename include guard.
13754         * mi/mi-getopt.h: Rename include guard.
13755         * mi/mi-console.h: Rename include guard.
13756         * mi/mi-common.h: Rename include guard.
13757         * mi/mi-cmds.h: Rename include guard.
13758         * mi/mi-cmd-break.h: Rename include guard.
13759         * m2-lang.h: Add include guard.
13760         * location.h: Rename include guard.
13761         * linux-record.h: Rename include guard.
13762         * linux-nat.h: Add include guard.
13763         * linux-fork.h: Add include guard.
13764         * i386-darwin-tdep.h: Rename include guard.
13765         * hppa-linux-offsets.h: Add include guard.
13766         * guile/guile.h: Rename include guard.
13767         * guile/guile-internal.h: Rename include guard.
13768         * gnu-nat.h: Rename include guard.
13769         * gdb-stabs.h: Rename include guard.
13770         * frv-tdep.h: Add include guard.
13771         * f-lang.h: Add include guard.
13772         * event-loop.h: Add include guard.
13773         * darwin-nat.h: Rename include guard.
13774         * cp-abi.h: Rename include guard.
13775         * config/sparc/nm-sol2.h: Rename include guard.
13776         * config/nm-nto.h: Rename include guard.
13777         * config/nm-linux.h: Add include guard.
13778         * config/i386/nm-i386gnu.h: Rename include guard.
13779         * config/djgpp/nl_types.h: Rename include guard.
13780         * config/djgpp/langinfo.h: Rename include guard.
13781         * compile/gcc-cp-plugin.h: Add include guard.
13782         * compile/gcc-c-plugin.h: Add include guard.
13783         * compile/compile.h: Rename include guard.
13784         * compile/compile-object-run.h: Rename include guard.
13785         * compile/compile-object-load.h: Rename include guard.
13786         * compile/compile-internal.h: Rename include guard.
13787         * compile/compile-cplus.h: Rename include guard.
13788         * compile/compile-c.h: Rename include guard.
13789         * common/xml-utils.h: Rename include guard.
13790         * common/x86-xstate.h: Rename include guard.
13791         * common/version.h: Rename include guard.
13792         * common/vec.h: Rename include guard.
13793         * common/tdesc.h: Rename include guard.
13794         * common/selftest.h: Rename include guard.
13795         * common/scoped_restore.h: Rename include guard.
13796         * common/scoped_mmap.h: Rename include guard.
13797         * common/scoped_fd.h: Rename include guard.
13798         * common/safe-iterator.h: Rename include guard.
13799         * common/run-time-clock.h: Rename include guard.
13800         * common/refcounted-object.h: Rename include guard.
13801         * common/queue.h: Rename include guard.
13802         * common/ptid.h: Rename include guard.
13803         * common/print-utils.h: Rename include guard.
13804         * common/preprocessor.h: Rename include guard.
13805         * common/pathstuff.h: Rename include guard.
13806         * common/observable.h: Rename include guard.
13807         * common/netstuff.h: Rename include guard.
13808         * common/job-control.h: Rename include guard.
13809         * common/host-defs.h: Rename include guard.
13810         * common/gdb_wait.h: Rename include guard.
13811         * common/gdb_vecs.h: Rename include guard.
13812         * common/gdb_unlinker.h: Rename include guard.
13813         * common/gdb_unique_ptr.h: Rename include guard.
13814         * common/gdb_tilde_expand.h: Rename include guard.
13815         * common/gdb_sys_time.h: Rename include guard.
13816         * common/gdb_string_view.h: Rename include guard.
13817         * common/gdb_splay_tree.h: Rename include guard.
13818         * common/gdb_setjmp.h: Rename include guard.
13819         * common/gdb_ref_ptr.h: Rename include guard.
13820         * common/gdb_optional.h: Rename include guard.
13821         * common/gdb_locale.h: Rename include guard.
13822         * common/gdb_assert.h: Rename include guard.
13823         * common/filtered-iterator.h: Rename include guard.
13824         * common/filestuff.h: Rename include guard.
13825         * common/fileio.h: Rename include guard.
13826         * common/environ.h: Rename include guard.
13827         * common/common-utils.h: Rename include guard.
13828         * common/common-types.h: Rename include guard.
13829         * common/common-regcache.h: Rename include guard.
13830         * common/common-inferior.h: Rename include guard.
13831         * common/common-gdbthread.h: Rename include guard.
13832         * common/common-exceptions.h: Rename include guard.
13833         * common/common-defs.h: Rename include guard.
13834         * common/common-debug.h: Rename include guard.
13835         * common/cleanups.h: Rename include guard.
13836         * common/buffer.h: Rename include guard.
13837         * common/btrace-common.h: Rename include guard.
13838         * common/break-common.h: Rename include guard.
13839         * cli/cli-utils.h: Rename include guard.
13840         * cli/cli-style.h: Rename include guard.
13841         * cli/cli-setshow.h: Rename include guard.
13842         * cli/cli-script.h: Rename include guard.
13843         * cli/cli-interp.h: Rename include guard.
13844         * cli/cli-decode.h: Rename include guard.
13845         * cli/cli-cmds.h: Rename include guard.
13846         * charset-list.h: Add include guard.
13847         * buildsym-legacy.h: Rename include guard.
13848         * bfin-tdep.h: Add include guard.
13849         * ax.h: Rename include guard.
13850         * arm-linux-tdep.h: Add include guard.
13851         * arm-fbsd-tdep.h: Add include guard.
13852         * arch/xtensa.h: Rename include guard.
13853         * arch/tic6x.h: Add include guard.
13854         * arch/i386.h: Add include guard.
13855         * arch/arm.h: Rename include guard.
13856         * arch/arm-linux.h: Rename include guard.
13857         * arch/arm-get-next-pcs.h: Rename include guard.
13858         * arch/amd64.h: Add include guard.
13859         * arch/aarch64-insn.h: Rename include guard.
13860         * arch-utils.h: Rename include guard.
13861         * annotate.h: Add include guard.
13862         * amd64-darwin-tdep.h: Rename include guard.
13863         * aarch64-linux-tdep.h: Add include guard.
13864         * aarch64-fbsd-tdep.h: Add include guard.
13865         * aarch32-linux-nat.h: Add include guard.
13866
13867 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13868
13869         * macrotab.c (macro_define_internal): New function that
13870         factorizes macro_define_object_internal and macro_define_function
13871         code.
13872         (macro_define_object_internal): Use macro_define_internal.
13873         (macro_define_function): Likewise.
13874
13875 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13876
13877         * macrocmd.c (extract_identifier): Return
13878         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13879         callers.
13880
13881 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
13882
13883         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13884
13885 2019-02-05  Tom Tromey  <tom@tromey.com>
13886
13887         * target.c (target_stack::unpush): Move assertion earlier.
13888
13889 2019-01-30  Tom Tromey  <tom@tromey.com>
13890
13891         PR python/23615:
13892         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13893         (gdbpy_parse_and_eval): Likewise.
13894         * python/python-internal.h (gdbpy_allow_threads): New class.
13895
13896 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13897
13898         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13899         (aarch64_fbsd_fpregmap): Move earlier.
13900         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13901         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13902         instead of individual calls to trad_frame_set_reg_addr.
13903         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13904         earlier.
13905         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13906         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13907         instead of individual calls to trad_frame_set_reg_addr.
13908
13909 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13910
13911         * CONTRIBUTE: Replace contribution list with wiki link.
13912
13913 2019-01-25  Tom Tromey  <tom@tromey.com>
13914
13915         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13916
13917 2019-01-25  Tom Tromey  <tom@tromey.com>
13918
13919         * xtensa-linux-nat.c: Fix common/ includes.
13920         * xml-support.h: Fix common/ includes.
13921         * xml-support.c: Fix common/ includes.
13922         * x86-linux-nat.c: Fix common/ includes.
13923         * windows-nat.c: Fix common/ includes.
13924         * varobj.h: Fix common/ includes.
13925         * varobj.c: Fix common/ includes.
13926         * value.c: Fix common/ includes.
13927         * valops.c: Fix common/ includes.
13928         * utils.c: Fix common/ includes.
13929         * unittests/xml-utils-selftests.c: Fix common/ includes.
13930         * unittests/utils-selftests.c: Fix common/ includes.
13931         * unittests/unpack-selftests.c: Fix common/ includes.
13932         * unittests/tracepoint-selftests.c: Fix common/ includes.
13933         * unittests/style-selftests.c: Fix common/ includes.
13934         * unittests/string_view-selftests.c: Fix common/ includes.
13935         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13936         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13937         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13938         * unittests/rsp-low-selftests.c: Fix common/ includes.
13939         * unittests/parse-connection-spec-selftests.c: Fix common/
13940         includes.
13941         * unittests/optional-selftests.c: Fix common/ includes.
13942         * unittests/offset-type-selftests.c: Fix common/ includes.
13943         * unittests/observable-selftests.c: Fix common/ includes.
13944         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13945         * unittests/memrange-selftests.c: Fix common/ includes.
13946         * unittests/memory-map-selftests.c: Fix common/ includes.
13947         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13948         * unittests/function-view-selftests.c: Fix common/ includes.
13949         * unittests/environ-selftests.c: Fix common/ includes.
13950         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13951         * unittests/common-utils-selftests.c: Fix common/ includes.
13952         * unittests/cli-utils-selftests.c: Fix common/ includes.
13953         * unittests/array-view-selftests.c: Fix common/ includes.
13954         * ui-file.c: Fix common/ includes.
13955         * tui/tui-io.c: Fix common/ includes.
13956         * tracepoint.h: Fix common/ includes.
13957         * tracepoint.c: Fix common/ includes.
13958         * tracefile-tfile.c: Fix common/ includes.
13959         * top.h: Fix common/ includes.
13960         * top.c: Fix common/ includes.
13961         * thread.c: Fix common/ includes.
13962         * target/waitstatus.h: Fix common/ includes.
13963         * target/waitstatus.c: Fix common/ includes.
13964         * target.h: Fix common/ includes.
13965         * target.c: Fix common/ includes.
13966         * target-memory.c: Fix common/ includes.
13967         * target-descriptions.c: Fix common/ includes.
13968         * symtab.h: Fix common/ includes.
13969         * symfile.c: Fix common/ includes.
13970         * stap-probe.c: Fix common/ includes.
13971         * spu-linux-nat.c: Fix common/ includes.
13972         * sparc-nat.c: Fix common/ includes.
13973         * source.c: Fix common/ includes.
13974         * solib.c: Fix common/ includes.
13975         * solib-target.c: Fix common/ includes.
13976         * ser-unix.c: Fix common/ includes.
13977         * ser-tcp.c: Fix common/ includes.
13978         * ser-pipe.c: Fix common/ includes.
13979         * ser-base.c: Fix common/ includes.
13980         * selftest-arch.c: Fix common/ includes.
13981         * s12z-tdep.c: Fix common/ includes.
13982         * rust-exp.y: Fix common/ includes.
13983         * rs6000-aix-tdep.c: Fix common/ includes.
13984         * riscv-tdep.c: Fix common/ includes.
13985         * remote.c: Fix common/ includes.
13986         * remote-notif.h: Fix common/ includes.
13987         * remote-fileio.h: Fix common/ includes.
13988         * remote-fileio.c: Fix common/ includes.
13989         * regcache.h: Fix common/ includes.
13990         * regcache.c: Fix common/ includes.
13991         * record-btrace.c: Fix common/ includes.
13992         * python/python.c: Fix common/ includes.
13993         * python/py-type.c: Fix common/ includes.
13994         * python/py-inferior.c: Fix common/ includes.
13995         * progspace.h: Fix common/ includes.
13996         * producer.c: Fix common/ includes.
13997         * procfs.c: Fix common/ includes.
13998         * proc-api.c: Fix common/ includes.
13999         * printcmd.c: Fix common/ includes.
14000         * ppc-linux-nat.c: Fix common/ includes.
14001         * parser-defs.h: Fix common/ includes.
14002         * osdata.c: Fix common/ includes.
14003         * obsd-nat.c: Fix common/ includes.
14004         * nat/x86-linux.c: Fix common/ includes.
14005         * nat/x86-linux-dregs.c: Fix common/ includes.
14006         * nat/x86-dregs.h: Fix common/ includes.
14007         * nat/x86-dregs.c: Fix common/ includes.
14008         * nat/ppc-linux.c: Fix common/ includes.
14009         * nat/mips-linux-watch.h: Fix common/ includes.
14010         * nat/mips-linux-watch.c: Fix common/ includes.
14011         * nat/linux-waitpid.c: Fix common/ includes.
14012         * nat/linux-ptrace.h: Fix common/ includes.
14013         * nat/linux-ptrace.c: Fix common/ includes.
14014         * nat/linux-procfs.c: Fix common/ includes.
14015         * nat/linux-personality.c: Fix common/ includes.
14016         * nat/linux-osdata.c: Fix common/ includes.
14017         * nat/linux-namespaces.c: Fix common/ includes.
14018         * nat/linux-btrace.h: Fix common/ includes.
14019         * nat/linux-btrace.c: Fix common/ includes.
14020         * nat/fork-inferior.c: Fix common/ includes.
14021         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14022         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14023         * nat/aarch64-linux.c: Fix common/ includes.
14024         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14025         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14026         * namespace.h: Fix common/ includes.
14027         * mips-linux-tdep.c: Fix common/ includes.
14028         * minsyms.c: Fix common/ includes.
14029         * mi/mi-parse.h: Fix common/ includes.
14030         * mi/mi-main.c: Fix common/ includes.
14031         * mi/mi-cmd-env.c: Fix common/ includes.
14032         * memrange.h: Fix common/ includes.
14033         * memattr.c: Fix common/ includes.
14034         * maint.h: Fix common/ includes.
14035         * maint.c: Fix common/ includes.
14036         * main.c: Fix common/ includes.
14037         * machoread.c: Fix common/ includes.
14038         * location.c: Fix common/ includes.
14039         * linux-thread-db.c: Fix common/ includes.
14040         * linux-nat.c: Fix common/ includes.
14041         * linux-fork.c: Fix common/ includes.
14042         * inline-frame.c: Fix common/ includes.
14043         * infrun.c: Fix common/ includes.
14044         * inflow.c: Fix common/ includes.
14045         * inferior.h: Fix common/ includes.
14046         * inferior.c: Fix common/ includes.
14047         * infcmd.c: Fix common/ includes.
14048         * inf-ptrace.c: Fix common/ includes.
14049         * inf-child.c: Fix common/ includes.
14050         * ia64-linux-nat.c: Fix common/ includes.
14051         * i387-tdep.c: Fix common/ includes.
14052         * i386-tdep.c: Fix common/ includes.
14053         * i386-linux-tdep.c: Fix common/ includes.
14054         * i386-linux-nat.c: Fix common/ includes.
14055         * i386-go32-tdep.c: Fix common/ includes.
14056         * i386-fbsd-tdep.c: Fix common/ includes.
14057         * i386-fbsd-nat.c: Fix common/ includes.
14058         * guile/scm-type.c: Fix common/ includes.
14059         * guile/guile.c: Fix common/ includes.
14060         * go32-nat.c: Fix common/ includes.
14061         * gnu-nat.c: Fix common/ includes.
14062         * gdbthread.h: Fix common/ includes.
14063         * gdbarch-selftests.c: Fix common/ includes.
14064         * gdb_usleep.c: Fix common/ includes.
14065         * gdb_select.h: Fix common/ includes.
14066         * gdb_bfd.c: Fix common/ includes.
14067         * gcore.c: Fix common/ includes.
14068         * fork-child.c: Fix common/ includes.
14069         * findvar.c: Fix common/ includes.
14070         * fbsd-nat.c: Fix common/ includes.
14071         * event-top.c: Fix common/ includes.
14072         * event-loop.c: Fix common/ includes.
14073         * dwarf2read.c: Fix common/ includes.
14074         * dwarf2loc.c: Fix common/ includes.
14075         * dwarf2-frame.c: Fix common/ includes.
14076         * dwarf-index-cache.c: Fix common/ includes.
14077         * dtrace-probe.c: Fix common/ includes.
14078         * disasm-selftests.c: Fix common/ includes.
14079         * defs.h: Fix common/ includes.
14080         * csky-tdep.c: Fix common/ includes.
14081         * cp-valprint.c: Fix common/ includes.
14082         * cp-support.h: Fix common/ includes.
14083         * cp-support.c: Fix common/ includes.
14084         * corelow.c: Fix common/ includes.
14085         * completer.h: Fix common/ includes.
14086         * completer.c: Fix common/ includes.
14087         * compile/compile.c: Fix common/ includes.
14088         * compile/compile-loc2c.c: Fix common/ includes.
14089         * compile/compile-cplus-types.c: Fix common/ includes.
14090         * compile/compile-cplus-symbols.c: Fix common/ includes.
14091         * command.h: Fix common/ includes.
14092         * cli/cli-dump.c: Fix common/ includes.
14093         * cli/cli-cmds.c: Fix common/ includes.
14094         * charset.c: Fix common/ includes.
14095         * build-id.c: Fix common/ includes.
14096         * btrace.h: Fix common/ includes.
14097         * btrace.c: Fix common/ includes.
14098         * breakpoint.h: Fix common/ includes.
14099         * breakpoint.c: Fix common/ includes.
14100         * ax.h:
14101         (enum agent_op): Fix common/ includes.
14102         * ax-general.c (struct aop_map): Fix common/ includes.
14103         * ax-gdb.c: Fix common/ includes.
14104         * auxv.c: Fix common/ includes.
14105         * auto-load.c: Fix common/ includes.
14106         * arm-tdep.c: Fix common/ includes.
14107         * arch/riscv.c: Fix common/ includes.
14108         * arch/ppc-linux-common.c: Fix common/ includes.
14109         * arch/i386.c: Fix common/ includes.
14110         * arch/arm.c: Fix common/ includes.
14111         * arch/arm-linux.c: Fix common/ includes.
14112         * arch/arm-get-next-pcs.c: Fix common/ includes.
14113         * arch/amd64.c: Fix common/ includes.
14114         * arch/aarch64.c: Fix common/ includes.
14115         * arch/aarch64-insn.c: Fix common/ includes.
14116         * arch-utils.c: Fix common/ includes.
14117         * amd64-windows-tdep.c: Fix common/ includes.
14118         * amd64-tdep.c: Fix common/ includes.
14119         * amd64-sol2-tdep.c: Fix common/ includes.
14120         * amd64-obsd-tdep.c: Fix common/ includes.
14121         * amd64-nbsd-tdep.c: Fix common/ includes.
14122         * amd64-linux-tdep.c: Fix common/ includes.
14123         * amd64-linux-nat.c: Fix common/ includes.
14124         * amd64-fbsd-tdep.c: Fix common/ includes.
14125         * amd64-fbsd-nat.c: Fix common/ includes.
14126         * amd64-dicos-tdep.c: Fix common/ includes.
14127         * amd64-darwin-tdep.c: Fix common/ includes.
14128         * agent.c: Fix common/ includes.
14129         * ada-lang.h: Fix common/ includes.
14130         * ada-lang.c: Fix common/ includes.
14131         * aarch64-tdep.c: Fix common/ includes.
14132
14133 2019-01-25  Tom Tromey  <tom@tromey.com>
14134
14135         * common/create-version.sh: Use common/version.h.
14136
14137 2019-01-24  Pedro Alves  <palves@redhat.com>
14138
14139         * infrun.c (signal_stop, signal_print, signal_program)
14140         (signal_catch, signal_pass): Now arrays instead of pointers.
14141         (update_signals_program_target, do_target_resume)
14142         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14143         * linux-nat.c (linux_nat_target::pass_signals)
14144         (linux_nat_target::create_inferior, linux_nat_target::attach):
14145         Adjust.
14146         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14147         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14148         * procfs.c (procfs_target::pass_signals): Adjust.
14149         * record-full.c (record_full_target::resume): Adjust.
14150         * remote.c (remote_target::pass_signals)
14151         (remote_target::program_signals): Adjust.
14152         * target-debug.h (target_debug_print_signals): Now takes a
14153         gdb::array_view as parameter.  Adjust.
14154         * target.h (target_ops) <pass_signals, program_signals>: Replace
14155         pointer and length parameters with gdb::array_view.
14156         (target_pass_signals, target_program_signals): Likewise.
14157         * target-delegates.c: Regenerate.
14158
14159 2019-01-24  Pedro Alves  <palves@redhat.com>
14160
14161         * common/forward-scope-exit.h
14162         (forward_scope_exit::forward_scope_exit): Pass arguments to
14163         m_bind_function directly, instead of creating a std::bind and
14164         copying that.
14165
14166 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14167
14168         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14169         for static members.
14170         (pass_in_v_vfp_candidate): Likewise.
14171
14172 2019-01-23  Tom Tromey  <tom@tromey.com>
14173             Pedro Alves  <palves@redhat.com>
14174
14175         * regcache.c (class regcache_invalidator): Remove.
14176         (regcache::raw_write): Use make_scope_exit.
14177
14178 2019-01-23  Tom Tromey  <tom@tromey.com>
14179
14180         * ui-out.h (class ui_out_emit_type): Update comment.
14181
14182 2019-01-23  Tom Tromey  <tom@tromey.com>
14183
14184         * infrun.c (fetch_inferior_event): Update comment.
14185
14186 2019-01-23  Tom Tromey  <tom@tromey.com>
14187             Pedro Alves  <palves@redhat.com>
14188
14189         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14190         parameter.
14191         (fetch_inferior_event): Use SCOPE_EXIT.
14192
14193
14194 2019-01-23  Tom Tromey  <tom@tromey.com>
14195             Pedro Alves  <palves@redhat.com>
14196
14197         * infrun.c (disable_thread_events): Delete.
14198         (stop_all_threads): Use SCOPE_EXIT.
14199
14200 2019-01-23  Tom Tromey  <tom@tromey.com>
14201             Pedro Alves  <palves@redhat.com>
14202
14203         * symfile.c: Include forward-scope-exit.h.
14204         (clear_symtab_users_cleanup): Replace forward declaration with
14205         a FORWARD_SCOPE_EXIT.
14206         (syms_from_objfile_1): Use the forward_scope_exit and
14207         gdb::optional instead of cleanup_function.
14208         (reread_symbols): Use the forward_scope_exit instead of
14209         cleanup_function.
14210         (clear_symtab_users_cleanup): Remove function.
14211
14212 2019-01-23  Tom Tromey  <tom@tromey.com>
14213             Pedro Alves  <palves@redhat.com>
14214
14215         * linux-nat.c: Include scope-exit.h.
14216         (cleanup_target_stop): Remove.
14217         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14218         SCOPE_EXIT.
14219
14220 2019-01-23  Tom Tromey  <tom@tromey.com>
14221             Pedro Alves  <palves@redhat.com>
14222
14223         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14224         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14225
14226 2019-01-23  Tom Tromey  <tom@tromey.com>
14227             Andrew Burgess  <andrew.burgess@embecosm.com>
14228             Pedro Alves  <palves@redhat.com>
14229
14230         * infrun.c (fetch_inferior_event): Use scope_exit.
14231         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14232         * top.c (execute_command): Use scope_exit.
14233         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14234         * utils.c (do_bpstat_clear_actions_cleanup)
14235         (make_bpstat_clear_actions_cleanup): Remove.
14236
14237 2019-01-23  Tom Tromey  <tom@tromey.com>
14238             Pedro Alves  <palves@redhat.com>
14239
14240         * infrun.c: Include "common/scope-exit.h"
14241         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14242         (wait_for_inferior): Use SCOPE_EXIT.
14243         (fetch_inferior_event): Use scope_exit.
14244
14245 2019-01-23  Tom Tromey  <tom@tromey.com>
14246             Pedro Alves  <palves@redhat.com>
14247
14248         * breakpoint.c (create_breakpoint): Remove cleanup.
14249
14250 2019-01-23  Tom Tromey  <tom@tromey.com>
14251             Andrew Burgess  <andrew.burgess@embecosm.com>
14252             Pedro Alves  <palves@redhat.com>
14253
14254 2019-01-23  Pedro Alves  <palves@redhat.com>
14255
14256         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14257
14258 2019-01-23  Pedro Alves  <palves@redhat.com>
14259             Andrew Burgess  <andrew.burgess@embecosm.com>
14260
14261         * gdbthread.h: Include "common/forward-scope-exit.h".
14262         (scoped_finish_thread_state): Redefine custom class in terms of
14263         forward_scope_exit.
14264
14265 2019-01-23  Pedro Alves  <palves@redhat.com>
14266             Andrew Burgess  <andrew.burgess@embecosm.com>
14267
14268         * common/forward-scope-exit.h: New file.
14269
14270 2019-01-23  Pedro Alves  <palves@redhat.com>
14271             Andrew Burgess  <andrew.burgess@embecosm.com>
14272             Tom Tromey  <tom@tromey.com>
14273
14274         * common/scope-exit.h: New file.
14275
14276 2019-01-23  Pedro Alves  <palves@redhat.com>
14277
14278         * common/preprocessor.h (ESC): Rename to ...
14279         (ESC_PARENS): ... this.
14280         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14281         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14282
14283 2019-01-23  Tom Tromey  <tom@tromey.com>
14284
14285         * language.h (class scoped_switch_to_sym_language_if_auto):
14286         Initialize m_lang in both cases.
14287
14288 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14289
14290         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14291         with XCNEW.
14292
14293 2019-01-22  Tom Tromey  <tom@tromey.com>
14294
14295         * corelow.c: Do not include sys/file.h.
14296
14297 2019-01-22  Tom Tromey  <tom@tromey.com>
14298
14299         * tui/tui-wingeneral.h: Include gdb_curses.h.
14300
14301 2019-01-22  Tom Tromey  <tom@tromey.com>
14302
14303         * source-cache.h (class source_cache) <get_source_lines,
14304         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14305
14306 2019-01-22  Tom Tromey  <tom@tromey.com>
14307
14308         * remote-fileio.h (struct remote_target): Declare.
14309
14310 2019-01-22  Tom Tromey  <tom@tromey.com>
14311
14312         * python/py-arch.c: Do not include py-ref.h.
14313         * python/py-bpevent.c: Do not include py-ref.h.
14314         * python/py-cmd.c: Do not include py-ref.h.
14315         * python/py-continueevent.c: Do not include py-ref.h.
14316         * python/py-event.h: Do not include py-ref.h.
14317         * python/py-evtregistry.c: Do not include py-ref.h.
14318         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14319         * python/py-frame.c: Do not include py-ref.h.
14320         * python/py-framefilter.c: Do not include py-ref.h.
14321         * python/py-function.c: Do not include py-ref.h.
14322         * python/py-infevents.c: Do not include py-ref.h.
14323         * python/py-linetable.c: Do not include py-ref.h.
14324         * python/py-objfile.c: Do not include py-ref.h.
14325         * python/py-param.c: Do not include py-ref.h.
14326         * python/py-prettyprint.c: Do not include py-ref.h.
14327         * python/py-progspace.c: Do not include py-ref.h.
14328         * python/py-symbol.c: Do not include py-ref.h.
14329         * python/py-symtab.c: Do not include py-ref.h.
14330         * python/py-type.c: Do not include py-ref.h.
14331         * python/py-unwind.c: Do not include py-ref.h.
14332         * python/py-utils.c: Do not include py-ref.h.
14333         * python/py-value.c: Do not include py-ref.h.
14334         * python/py-varobj.c: Do not include py-ref.h.
14335         * python/py-xmethods.c: Do not include py-ref.h.
14336         * python/python.c: Do not include py-ref.h.
14337         * varobj.c: Do not include py-ref.h.
14338
14339 2019-01-22  Tom Tromey  <tom@tromey.com>
14340
14341         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14342         keyword for bcache.
14343
14344 2019-01-22  Tom Tromey  <tom@tromey.com>
14345
14346         * compile/compile-cplus-types.c: Remove a comment by #include.
14347
14348 2019-01-22  Tom Tromey  <tom@tromey.com>
14349
14350         * compile/gcc-c-plugin.h: Include compile-internal.h.
14351
14352 2019-01-22  Tom Tromey  <tom@tromey.com>
14353
14354         * stabsread.c (EXTERN): Do not define.
14355         (symnum, next_symbol_text_func, processing_gcc_compilation)
14356         (within_function, global_sym_chain, global_stabs)
14357         (previous_stab_code, this_object_header_files)
14358         (n_this_object_header_files)
14359         (n_allocated_this_object_header_files): Define.
14360         * stabsread.h (EXTERN): Never define.  Use "extern".
14361
14362 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14363
14364         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14365         history_value.
14366
14367 2019-01-21  Tom Tromey  <tom@tromey.com>
14368
14369         * ui-out.c: Fix includes.
14370         * tui/tui-source.c: Fix includes.
14371         * target.c: Fix includes.
14372         * remote.c: Fix includes.
14373         * regcache.c: Fix includes.
14374         * python/py-block.c: Fix includes.
14375         * printcmd.c: Fix includes.
14376         * or1k-tdep.c: Fix includes.
14377         * mi/mi-main.c: Fix includes.
14378         * m32r-tdep.c: Fix includes.
14379         * csky-tdep.c: Fix includes.
14380         * compile/compile-cplus-types.c: Fix includes.
14381         * cli/cli-interp.c: Fix includes.
14382
14383 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14384
14385         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14386         for padding.
14387
14388 2019-01-16  Tom Tromey  <tom@tromey.com>
14389
14390         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14391         earlier.
14392         (struct objfile) <msymbols_range>: Move from top level.
14393         <msymbols>: New method.
14394         (class objfile_msymbols): Remove.
14395         * symtab.c (default_collect_symbol_completion_matches_break_on):
14396         Update.
14397         * symmisc.c (dump_msymbols): Update.
14398         * stabsread.c (scan_file_globals): Update.
14399         * objc-lang.c (info_selectors_command, info_classes_command)
14400         (find_methods): Update.
14401         * minsyms.c (find_solib_trampoline_target): Update.
14402         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14403         * coffread.c (coff_symfile_read): Update.
14404         * ada-lang.c (ada_lookup_simple_minsym)
14405         (ada_collect_symbol_completion_matches): Update.
14406
14407 2019-01-16  Tom Tromey  <tom@tromey.com>
14408
14409         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14410         type.  Remove no-argument constructor.
14411         <iterator::operator++>: Simplify.
14412         <begin>: Update.
14413         <end>: Use minimal_symbol_count.
14414
14415 2019-01-16  Tom Tromey  <tom@tromey.com>
14416
14417         * objfiles.h (struct objfile) <psymtabs>: New method.
14418         (class objfile_psymtabs): Remove.
14419         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14420         typedef.
14421         <range>: New method.
14422         (require_partial_symbols): Change return type.
14423         * psymtab.c (require_partial_symbols)
14424         (psym_expand_symtabs_matching): Update.
14425         * mdebugread.c (parse_partial_symbols): Update.
14426         * dbxread.c (dbx_end_psymtab): Update.
14427
14428 2019-01-15  Tom Tromey  <tom@tromey.com>
14429
14430         * symtab.c (lookup_objfile_from_block)
14431         (lookup_symbol_in_objfile_symtabs)
14432         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14433         (find_line_symtab, info_sources_command)
14434         (default_collect_symbol_completion_matches_break_on)
14435         (make_source_files_completion_list): Update.
14436         * symmisc.c (print_objfile_statistics, dump_objfile)
14437         (maintenance_print_symbols, maintenance_info_symtabs)
14438         (maintenance_check_symtabs, maintenance_info_line_tables):
14439         Update.
14440         * source.c (select_source_symtab)
14441         (forget_cached_source_info_for_objfile): Update.
14442         * objfiles.h (class objfile_compunits): Remove.
14443         (struct objfile) <compunits_range>: New typedef.
14444         (compunits): New method.
14445         * objfiles.c (objfile_relocate1): Update.
14446         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14447         * maint.c (count_symtabs_and_blocks): Update.
14448         * linespec.c (iterate_over_all_matching_symtabs): Update.
14449         * cp-support.c (add_symbol_overload_list_qualified): Update.
14450         * coffread.c (coff_symtab_read): Update.
14451         * ada-lang.c (add_nonlocal_symbols)
14452         (ada_collect_symbol_completion_matches)
14453         (ada_add_global_exceptions): Update.
14454
14455 2019-01-15  Tom Tromey  <tom@tromey.com>
14456
14457         * progspace.h (program_space) <objfiles_safe_range>: New
14458         typedef.
14459         <objfiles_safe>: New method.
14460         * objfiles.h (class all_objfiles_safe): Remove.
14461         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14462         * jit.c (jit_inferior_exit_hook): Update.
14463
14464 2019-01-17  Tom Tromey  <tom@tromey.com>
14465
14466         * progspace.h (program_space) <objfiles_range>: New typedef.
14467         <objfiles>: New method.
14468         <objfiles_head>: Rename from objfiles.
14469         (object_files): Update.
14470         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14471         * guile/scm-pretty-print.c
14472         (ppscm_find_pretty_printer_from_objfiles): Update.
14473         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14474         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14475         Update.
14476         * python/py-progspace.c (pspy_get_objfiles): Update.
14477         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14478         Update.
14479         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14480         (objfpy_lookup_objfile_by_build_id): Update.
14481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14482         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14483         Update.
14484         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14485         (expand_symtab_containing_pc, lookup_objfile_from_block)
14486         (lookup_static_symbol, basic_lookup_transparent_type)
14487         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14488         (find_line_symtab, info_sources_command)
14489         (default_collect_symbol_completion_matches_break_on)
14490         (make_source_files_completion_list, find_main_name): Update.
14491         * symmisc.c (print_symbol_bcache_statistics)
14492         (print_objfile_statistics, maintenance_print_symbols)
14493         (maintenance_print_msymbols, maintenance_print_objfiles)
14494         (maintenance_info_symtabs, maintenance_check_symtabs)
14495         (maintenance_expand_symtabs, maintenance_info_line_tables):
14496         Update.
14497         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14498         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14499         (map_overlay_command, unmap_overlay_command)
14500         (simple_overlay_update, expand_symtabs_matching)
14501         (map_symbol_filenames): Update.
14502         * symfile-debug.c (set_debug_symfile): Update.
14503         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14504         Update.
14505         * source.c (select_source_symtab, forget_cached_source_info):
14506         Update.
14507         * solib.c (solib_read_symbols): Update.
14508         * solib-spu.c (append_ocl_sos): Update.
14509         * psymtab.c (maintenance_print_psymbols)
14510         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14511         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14512         * printcmd.c (info_symbol_command): Update.
14513         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14514         Update.
14515         * objfiles.h (class all_objfiles): Remove.
14516         * objfiles.c (have_partial_symbols, have_full_symbols)
14517         (have_minimal_symbols, qsort_cmp, update_section_map)
14518         (shared_objfile_contains_address_p)
14519         (default_iterate_over_objfiles_in_search_order): Update.
14520         * objc-lang.c (info_selectors_command, info_classes_command)
14521         (find_methods): Update.
14522         * minsyms.c (find_solib_trampoline_target): Update.
14523         * maint.c (maintenance_info_sections)
14524         (maintenance_translate_address, count_symtabs_and_blocks):
14525         Update.
14526         * main.c (captured_main_1): Update.
14527         * linux-thread-db.c (try_thread_db_load_from_pdir)
14528         (has_libpthread): Update.
14529         * linespec.c (iterate_over_all_matching_symtabs)
14530         (search_minsyms_for_name): Update.
14531         * jit.c (jit_find_objf_with_entry_addr): Update.
14532         * hppa-tdep.c (find_unwind_entry)
14533         (hppa_lookup_stub_minimal_symbol): Update.
14534         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14535         Update.
14536         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14537         (elf_gnu_ifunc_resolve_by_got): Update.
14538         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14539         * dwarf-index-write.c (save_gdb_index_command): Update.
14540         * cp-support.c (add_symbol_overload_list_qualified): Update.
14541         * breakpoint.c (create_overlay_event_breakpoint)
14542         (create_longjmp_master_breakpoint)
14543         (create_std_terminate_master_breakpoint)
14544         (create_exception_master_breakpoint): Update.
14545         * blockframe.c (find_pc_partial_function): Update.
14546         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14547         (ada_collect_symbol_completion_matches)
14548         (ada_add_global_exceptions): Update.
14549
14550 2019-01-17  Tom Tromey  <tom@tromey.com>
14551
14552         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14553         declare VEC.
14554         (solib_target_parse_libraries): Change return type.
14555         (library_list_start_segment, library_list_start_section)
14556         (library_list_end_library, library_list_start_library); Update.
14557         (solib_target_free_library_list): Remove.
14558         (solib_target_parse_libraries): Remove cleanup.  Change return
14559         type.
14560         (solib_target_current_sos): Update.
14561
14562 2019-01-17  Tom Tromey  <tromey@bapiya>
14563
14564         * valprint.c: Replace "the the" with "the".
14565         * symtab.c: Replace "the the" with "the".
14566         * solib.c: Replace "the the" with "the".
14567         * solib-dsbt.c: Replace "the the" with "the".
14568         * linespec.c: Replace "the the" with "the".
14569         * dwarf2loc.h: Replace "the the" with "the".
14570         * amd64-windows-tdep.c: Replace "the the" with "the".
14571         * aarch64-tdep.c: Replace "the the" with "the".
14572
14573 2019-01-16  Keith Seitz  <keiths@redhat.com>
14574
14575         PR gdb/23773
14576         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14577         <builder>: Rename to ..
14578         <m_builder>: ... this and make private.
14579         (dwarf2_cu::get_builder): New method.  Change all users of
14580         `builder' to use this method.
14581         (dwarf2_start_symtab): Move to ...
14582         (dwarf2_cu::start_symtab): ... here.  Update all callers
14583         (setup_type_unit_groups): Move to ...
14584         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14585         callers.
14586         (dwarf2_cu::reset_builder): New method.
14587         (process_full_compunit, process_full_type_unit): Use
14588         dwarf2_cu::reset_builder.
14589         (follow_die_offset): Record the ancestor CU if it is different
14590         from the followed DIE's CU.
14591         (follow_die_sig_1): Likewise.
14592
14593 2019-01-15  Tom Tromey  <tom@tromey.com>
14594
14595         * remote.c (class remote_state) <buf>: Now a char_vector.
14596         <buf_size>: Remove.
14597         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14598         parameter.
14599         (remote_target::getpkt_or_notif_sane_1)
14600         (remote_target::getpkt_sane)
14601         (remote_target::getpkt_or_notif_sane): Likewise.
14602         (class remote_target) <putpkt>: New overload.
14603         (remote_target::read_frame): Change type of "buf_p".  Remove
14604         sizeof_p parameter.
14605         (packet_ok): New overload.
14606         (packet_check_result): New overload.
14607         Update all uses.
14608
14609 2019-01-14  Tom Tromey  <tom@tromey.com>
14610
14611         * remote-notif.c (handle_notification, remote_notif_ack)
14612         (remote_notif_parse): Make "buf" const.
14613         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14614         const.
14615         (remote_notif_parse, remote_notif_ack, handle_notification):
14616         Likewise.
14617         * remote.c (remote_notif_stop_parse): Make "buf" const.
14618         (remote_target::remote_parse_stop_reply): Make "buf" const.
14619         (remote_notif_stop_ack): Make "buf" const.
14620
14621 2019-01-14  Tom Tromey  <tom@tromey.com>
14622
14623         * remote.c (remote_console_output): Make parameter const.
14624
14625 2019-01-14  Tom Tromey  <tom@tromey.com>
14626
14627         * target-debug.h (target_debug_print_signals): Constify.
14628         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14629         * procfs.c (procfs_target::pass_signals): Update.
14630         * linux-nat.c (linux_nat_target::pass_signals): Update.
14631         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14632         * target-delegates.c: Rebuild.
14633         * remote.c (remote_target::program_signals): Update.
14634         (remote_target::pass_signals): Update.
14635         * target.c (target_pass_signals): Constify argument.
14636         (target_program_signals): Likewise.
14637         * target.h (struct target_ops) <pass_signals, program_signals>:
14638         Constify argument.
14639         (target_pass_signals, target_program_signals): Constify argument.
14640
14641 2019-01-14  Tom Tromey  <tom@tromey.com>
14642
14643         PR tui/28819:
14644         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14645
14646 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14647
14648         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14649         field.
14650         * rs6000-tdep.c: Include reggroups.h.
14651         (IS_V_ALIAS_PSEUDOREG): Define.
14652         (rs6000_register_name): Return names for the "vX" aliases.
14653         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14654         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14655         aliases.  Call default_register_reggroup_p for all other
14656         pseudo-registers.
14657         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14658         New functions.
14659         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14660         Handle "vX" aliases.
14661         (v_alias_pseudo_register_collect): New function.
14662         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14663         (rs6000_gdbarch_init): Initialize "vX" aliases as
14664         pseudo-registers.  Restore registration of
14665         rs6000_pseudo_register_reggroup_p with
14666         set_tdesc_pseudo_register_reggroup_p.
14667
14668 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14669
14670         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14671         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14672         set_gdbarch_num_pseudo_regs.
14673
14674 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14675
14676         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14677         Remove arg prefixname, add do_set and do_show.
14678         Add member functions set_list and show_list.
14679         * cli/cli-style.c (class cli_style_option): Update accordingly.
14680         (style_set_list): Move to file scope.
14681         (style_show_list): Likewise.
14682         (set_style): Call help_list.
14683         (show_style): Call cmd_show_list.
14684         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14685         Update to use the new macro.
14686
14687 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14688
14689         * ada-lang.c (_initialize_ada_language): Expand the help text
14690         for the "catch exception" command.
14691
14692 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14693
14694         * symtab.c (matching_obj_sections): Initialize obj,
14695         declare it closer to its usage.
14696
14697 2019-01-10  Tom Tromey  <tom@tromey.com>
14698
14699         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14700         (basic_inf_threads_range): Remove.
14701         (inf_threads_range, inf_non_exited_threads_range)
14702         (safe_inf_threads_range): Use next_adapter.
14703
14704 2019-01-10  Keith Seitz  <keiths@redhat.com>
14705
14706         PR gdb/23712
14707         PR symtab/23010
14708         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14709         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14710
14711 2019-01-10  Keith Seitz  <keiths@redhat.com>
14712
14713         PR gdb/23712
14714         PR symtab/23010
14715         * dictionary.c (pending_to_vector): Remove.
14716         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14717         Remove _1 suffix, replacing functions of the same name.  Update
14718         all callers.
14719         (dict_create_hashed, dict_create_hashed_expandable)
14720         (dict_create_linear, dict_create_linear_expandable, dict_free)
14721         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14722         Make functions static.
14723
14724 2019-01-10  Keith Seitz  <keiths@redhat.com>
14725
14726         PR gdb/23712
14727         PR symtab/23010
14728         * dictionary.h (struct dictionary): Replace declaration with
14729         multidictionary.
14730         (dict_create_hashed, dict_create_hashed_expandable)
14731         (dict_create_linear, dict_create_linear_expandable)
14732         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14733         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14734         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14735         taking multidictionary argument.
14736         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14737         * block.h (struct block) <dict>: Change to multidictionary
14738         and rename `multidict'.
14739         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14740         symmisc.c: Update all dictionary references to multidictionary.
14741
14742 2019-01-10  Keith Seitz  <keiths@redhat.com>
14743
14744         PR gdb/23712
14745         PR symtab/23010
14746         * dictionary.c: Include unordered_map.
14747         (pending_to_vector): New function.
14748         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14749         Rewrite the non-"_1" functions to take vector instead
14750         of linked list.
14751         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14752         "new" _1 versions of the same name.
14753         (multidictionary): Define.
14754         (std::hash<enum language): New definition.
14755         (collate_pending_symbols_by_language, mdict_create_hashed)
14756         (mdict_create_hashed_expandable, mdict_create_linear)
14757         (mdict_create_linear_expandable, mdict_free)
14758         (find_language_dictionary, create_new_language_dictionary)
14759         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14760         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14761         (mdict_size, mdict_empty): New functions.
14762         * dictionary.h (mdict_iterator): Define.
14763
14764 2019-01-10  Pedro Alves  <palves@redhat.com>
14765
14766         * breakpoint.c (read_uploaded_action)
14767         (create_tracepoint_from_upload): Adjust to use
14768         gdb::unique_xmalloc_ptr.
14769         * ctf.c (ctf_write_uploaded_tp):
14770         (SET_ARRAY_FIELD): Use emplace_back.
14771         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14772         * tracefile-tfile.c (tfile_write_uploaded_tp):
14773         * tracepoint.c (parse_tracepoint_definition): Adjust to use
14774         gdb::unique_xmalloc_ptr.
14775         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14776         at_string, cond_string, cmd_strings>: Replace char pointers
14777         with gdb::unique_xmalloc_ptr.
14778
14779 2019-01-10  Pedro Alves  <palves@redhat.com>
14780
14781         * solib-target.c (library_list_start_library): Don't xstrdup name.
14782
14783 2019-01-10  Pedro Alves  <palves@redhat.com>
14784
14785         * mdebugread.c (parse_partial_symbols): Use
14786         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14787
14788 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14789
14790         * linux-fork.c (scoped_switch_fork_info)
14791         <~scoped_switch_fork_info>: Fix incorrect variable name.
14792
14793 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
14794
14795         * linux-fork.c (scoped_switch_fork_info)
14796         <scoped_switch_fork_info>: Make explicit.
14797         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14798
14799 2019-01-10  Tom Tromey  <tom@tromey.com>
14800
14801         * objfiles.h (objfile::reset_psymtabs): Update.
14802         * objfiles.c (objfile::objfile): Update.
14803         * psymtab.h (psymtab_storage::obstack): Update.
14804         (psymtab_storage::m_obstack): Use gdb::optional.
14805         (class psymtab_storage): Update comment.  Remove objfile
14806         parameter.
14807         * psymtab.c (psymtab_storage::psymtab_storage): Update.
14808
14809 2019-01-10  Tom Tromey  <tom@tromey.com>
14810
14811         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14812         <free_psymtabs>: Now private.
14813         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14814         (allocate_psymtab): Use new method.
14815
14816 2019-01-10  Tom Tromey  <tom@tromey.com>
14817
14818         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14819         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14820         * mdebugread.c (parse_partial_symbols): Use
14821         allocate_dependencies.
14822         * dwarf2read.c (dwarf2_create_include_psymtab): Use
14823         allocate_dependencies.
14824         (process_psymtab_comp_unit_reader)
14825         (build_type_psymtab_dependencies): Likewise.
14826         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14827
14828 2019-01-10  Tom Tromey  <tom@tromey.com>
14829
14830         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14831         PSYMBOL_SET_LANGUAGE.
14832         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14833
14834 2019-01-10  Tom Tromey  <tom@tromey.com>
14835
14836         * psymtab.h (psymtab_storage::obstack): New method.
14837         <m_obstack>: Rename from obstack; now private.
14838         * psymtab.c (psymtab_storage): Update.
14839         * dwarf2read.c (create_addrmap_from_index)
14840         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14841         Update.
14842
14843 2019-01-10  Tom Tromey  <tom@tromey.com>
14844
14845         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14846         * objfiles.h (objfile::reset_psymtabs): New method.
14847
14848 2019-01-10  Tom Tromey  <tom@tromey.com>
14849
14850         * symmisc.c (print_symbol_bcache_statistics): Update.
14851         (print_objfile_statistics): Update.
14852         * symfile.c (reread_symbols): Update.
14853         * psymtab.h (class psymtab_storage): New.
14854         * psymtab.c (psymtab_storage): New constructor.
14855         (~psymtab_storage): New destructor.
14856         (require_partial_symbols): Update.
14857         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14858         (find_pc_sect_psymtab, find_pc_sect_psymbol)
14859         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14860         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14861         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14862         (start_psymtab_common, end_psymtab_common)
14863         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14864         (allocate_psymtab): Update.
14865         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14866         Update.
14867         (dump_psymtab_addrmap, maintenance_print_psymbols)
14868         (maintenance_check_psymtabs): Update.
14869         (class objfile_psymtabs): Move to objfiles.h.
14870         * psympriv.h (discard_psymtab): Now inline.
14871         (psymtab_discarder::psymtab_discarder): Update.
14872         (psymtab_discarder::~psymtab_discarder): Update.
14873         (ALL_OBJFILE_PSYMTABS): Rewrite.
14874         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14875         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14876         Remove fields.
14877         <partial_symtabs>: New field.
14878         (class objfile_psymtabs): Move from psymtab.h.  Update.
14879         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14880         psymbol_cache.
14881         (objfile::~objfile): Don't destroy psymbol_cache.
14882         * mdebugread.c (parse_partial_symbols): Update.
14883         * dwarf2read.c (create_addrmap_from_index)
14884         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14885         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14886         (add_partial_subprogram, dwarf2_ranges_read): Update.
14887         * dwarf-index-write.c (write_address_map)
14888         (write_one_signatured_type, recursively_write_psymbols)
14889         (class debug_names, class debug_names, write_psymtabs_to_index):
14890         Update.
14891
14892 2019-01-10  Tom Tromey  <tom@tromey.com>
14893
14894         * symtab.h (SYMBOL_SET_NAMES): Update.
14895         (symbol_set_names): Update.
14896         (MSYMBOL_SET_NAMES): Update.
14897         * symtab.c (symbol_set_names): Change argument to be an
14898         objfile_per_bfd_storage.
14899         * psymtab.c (add_psymbol_to_bcache): Update.
14900         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14901
14902 2019-01-10  Tom Tromey  <tom@tromey.com>
14903
14904         * symtab.c (create_demangled_names_hash): Change argument to be an
14905         objfile_per_bfd_storage.
14906         (symbol_set_names): Update.
14907
14908 2019-01-10  Tom Tromey  <tom@tromey.com>
14909
14910         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14911         init_psymbol_list.
14912         * psymtab.c (init_psymbol_list): Do nothing if already called.
14913         * psympriv.h (init_psymbol_list): Add comment.
14914         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14915         init_psymbol_list.
14916         * dbxread.c (dbx_symfile_read): Unconditionally call
14917         init_psymbol_list.
14918
14919 2019-01-10  Tom Tromey  <tom@tromey.com>
14920
14921         * xcoffread.c (scan_xcoff_symtab): Update.
14922         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14923         "where".
14924         * mdebugread.c (parse_partial_symbols)
14925         (handle_psymbol_enumerators): Update.
14926         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14927         * dbxread.c (read_dbx_symtab): Update.
14928         * psympriv.h (psymbol_placement): New enum.
14929         (add_psymbol_to_list): Update.
14930
14931 2019-01-10  Tom Tromey  <tom@tromey.com>
14932
14933         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14934         static_psymbols parameters.
14935         (scan_xcoff_symtab): Update.
14936         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14937         static_psymbols parameters.
14938         * psympriv.h (start_psymtab_common): Update.
14939         * mdebugread.c (parse_partial_symbols): Update.
14940         * dwarf2read.c (create_partial_symtab): Update.
14941         * dbxread.c (read_dbx_symtab): Update.
14942         (start_psymtab): Remove global_psymbols and static_psymbols
14943         parameters.
14944
14945 2019-01-10  Tom Tromey  <tom@tromey.com>
14946
14947         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14948         * psymtab.c (allocate_psymtab): Add comment.
14949         * psympriv.h (allocate_psymtab): Add comment.
14950         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14951         initializations.
14952         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14953
14954 2019-01-10  Tom Tromey  <tom@tromey.com>
14955
14956         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14957         Don't declare.
14958         * mipsread.c: Include mdebugread.h.
14959         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14960         Declare.
14961         * elfread.c: Include mdebugread.h.
14962
14963 2019-01-09  Tom Tromey  <tom@tromey.com>
14964
14965         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14966         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14967         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14968         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14969         (psym_lookup_symbol, psym_find_last_source_symtab)
14970         (psym_forget_cached_source_info, psym_print_stats)
14971         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14972         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14973         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14974         (psym_find_compunit_symtab_by_address)
14975         (maintenance_print_psymbols, maintenance_info_psymtabs)
14976         (maintenance_check_psymtabs): Use ranged for.
14977         * psymtab.h (class objfile_psymtabs): New.
14978         (require_partial_symbols): Return objfile_psymtabs.
14979         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14980
14981 2019-01-09  Tom Tromey  <tom@tromey.com>
14982
14983         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14984         (find_pc_mapped_section, list_overlays_command)
14985         (map_overlay_command, unmap_overlay_command)
14986         (simple_overlay_update): Use all_objfiles.
14987         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14988         * printcmd.c (info_symbol_command): Use all_objfiles.
14989         * objfiles.h (ALL_OBJSECTIONS): Remove.
14990         * maint.c (maintenance_translate_address): Use all_objfiles.
14991         * gcore.c (gcore_create_callback): Use all_objfiles.
14992         (objfile_find_memory_regions): Likewise.
14993
14994 2019-01-09  Tom Tromey  <tom@tromey.com>
14995
14996         * symtab.c (find_line_symtab, info_sources_command)
14997         (make_source_files_completion_list): Use objfile_compunits.
14998         * source.c (select_source_symtab): Use objfile_compunits.
14999         * objfiles.h (struct objfile): Update comment.
15000         (ALL_OBJFILES): Remove.
15001         (ALL_FILETABS): Remove.
15002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15003         objfile_compunits.
15004
15005 2019-01-09  Tom Tromey  <tom@tromey.com>
15006
15007         * symmisc.c (print_objfile_statistics, dump_objfile)
15008         (maintenance_print_symbols): Use compunit_filetabs.
15009         * source.c (forget_cached_source_info_for_objfile): Use
15010         compunit_filetabs.
15011         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15012         (ALL_FILETABS): Use compunit_filetabs.
15013         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15014         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15015
15016 2019-01-09  Tom Tromey  <tom@tromey.com>
15017
15018         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15019         (compunit_filetabs): New.
15020         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15021         compunit_filetabs.
15022         (info_sources_command, make_source_files_completion_list): Remove
15023         declaration.
15024         * symmisc.c (print_objfile_statistics, dump_objfile)
15025         (maintenance_print_symbols): Remove declaration.
15026         (maintenance_info_symtabs): Use compunit_filetabs.
15027         (maintenance_info_line_tables): Likewise.
15028         * source.c (select_source_symtab): Change local variable name.
15029         (forget_cached_source_info_for_objfile): Remove declaration.
15030         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15031         * objfiles.c (objfile_relocate1): Remove declaration.
15032         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15033         declaration.
15034         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15035         * coffread.c (coff_symtab_read): Remove declaration.
15036         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15037         compunit_filetabs.
15038
15039 2019-01-09  Tom Tromey  <tom@tromey.com>
15040
15041         * symtab.c (lookup_objfile_from_block)
15042         (find_pc_sect_compunit_symtab, search_symbols)
15043         (default_collect_symbol_completion_matches_break_on): Use
15044         objfile_compunits.
15045         * objfiles.h (ALL_COMPUNITS): Remove.
15046         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15047         * cp-support.c (add_symbol_overload_list_qualified): Use
15048         objfile_compunits.
15049         * ada-lang.c (ada_collect_symbol_completion_matches)
15050         (ada_add_global_exceptions): Use objfile_compunits.
15051
15052 2019-01-09  Tom Tromey  <tom@tromey.com>
15053
15054         * source.c (select_source_symtab)
15055         (forget_cached_source_info_for_objfile): Remove declaration.
15056         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15057         declaration.
15058         * maint.c (count_symtabs_and_blocks): Remove declaration.
15059         * cp-support.c (add_symbol_overload_list_qualified): Remove
15060         declaration.
15061         * coffread.c (coff_symtab_read): Remove declaration.
15062         * symtab.c (lookup_symbol_in_objfile_symtabs)
15063         (basic_lookup_transparent_type_1): Use objfile_compunits.
15064         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15065         (info_sources_command, search_symbols)
15066         (default_collect_symbol_completion_matches_break_on)
15067         (make_source_files_completion_list): Remove declaration.
15068         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15069         (ada_collect_symbol_completion_matches)
15070         (ada_add_global_exceptions): Remove declaration.
15071         * linespec.c (iterate_over_all_matching_symtabs): Use
15072         objfile_compunits.
15073         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15074         (class objfile_compunits): New.
15075         (ALL_COMPUNITS): Use objfile_compunits.
15076         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15077         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15078         objfile_compunits.
15079         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15080
15081 2019-01-09  Tom Tromey  <tom@tromey.com>
15082
15083         * symtab.c (search_symbols)
15084         (default_collect_symbol_completion_matches_break_on): Use
15085         objfile_msymbols.
15086         * ada-lang.c (ada_lookup_simple_minsym)
15087         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15088         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15089         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15090         objfile_msymbols.
15091         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15092         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15093         * objc-lang.c (find_methods): Use objfile_msymbols.
15094         (info_selectors_command, info_classes_command): Likewise.
15095         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15096         * objfiles.h (class objfile_msymbols): New.
15097         (ALL_OBJFILE_MSYMBOLS): Remove.
15098         (ALL_MSYMBOLS): Remove.
15099
15100 2019-01-09  Tom Tromey  <tom@tromey.com>
15101
15102         * common/next-iterator.h (next_adapter): Add Iterator template
15103         parameter.
15104         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15105         (class all_objfiles_safe): New.
15106         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15107         * objfiles.c (put_objfile_before): Update comment.
15108         (add_separate_debug_objfile): Likewise.
15109         (free_all_objfiles): Use all_objfiles_safe.
15110         (objfile_purge_solibs): Likewise.
15111
15112 2019-01-09  Tom Tromey  <tom@tromey.com>
15113
15114         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15115         (expand_symtab_containing_pc, lookup_static_symbol)
15116         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15117         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15118         all_objfiles.
15119         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15120         * breakpoint.c (create_overlay_event_breakpoint)
15121         (create_longjmp_master_breakpoint)
15122         (create_std_terminate_master_breakpoint)
15123         (create_exception_master_breakpoint): Use all_objfiles.
15124         * linux-thread-db.c (try_thread_db_load_from_pdir)
15125         (has_libpthread): Use all_objfiles.
15126         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15127         * linespec.c (iterate_over_all_matching_symtabs)
15128         (search_minsyms_for_name): Use all_objfiles.
15129         * maint.c (maintenance_info_sections): Use all_objfiles.
15130         * main.c (captured_main_1): Use all_objfiles.
15131         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15132         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15133         * guile/scm-pretty-print.c
15134         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15135         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15136         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15137         (maintenance_print_msymbols): Use all_objfiles.
15138         * source.c (select_source_symtab): Use all_objfiles.
15139         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15140         * symfile.c (remove_symbol_file_command)
15141         (expand_symtabs_matching, map_symbol_filenames): Use
15142         all_objfiles.
15143         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15144         all_objfiles.
15145         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15146         * objc-lang.c (find_methods): Use all_objfiles.
15147         * objfiles.c (have_partial_symbols, have_full_symbols)
15148         (have_minimal_symbols, qsort_cmp)
15149         (default_iterate_over_objfiles_in_search_order): Use
15150         all_objfiles.
15151         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15152         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15153         (maintenance_check_psymtabs): Use all_objfiles.
15154         (ALL_PSYMTABS): Remove.
15155         * compile/compile-object-run.c (do_module_cleanup): Use
15156         all_objfiles.
15157         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15158         * cp-support.c (add_symbol_overload_list_qualified): Use
15159         all_objfiles.
15160         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15161         Use all_objfiles.
15162         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15163         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15164         all_objfiles.
15165         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15166         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15167         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15168         Uses all_objfiles.
15169         * solib.c (solib_read_symbols): Use all_objfiles
15170
15171 2019-01-09  Tom Tromey  <tom@tromey.com>
15172
15173         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15174         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15175         all_objfiles.
15176         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15177         * symmisc.c (print_symbol_bcache_statistics)
15178         (print_objfile_statistics, maintenance_print_objfiles)
15179         (maintenance_info_symtabs, maintenance_check_symtabs)
15180         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15181         all_objfiles.
15182         * source.c (forget_cached_source_info): Use all_objfiles.
15183         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15184         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15185         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15186         * objfiles.c (update_section_map): Use all_objfiles.
15187         (shared_objfile_contains_address_p): Likewise.
15188         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15189         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15190
15191 2019-01-09  Tom Tromey  <tom@tromey.com>
15192
15193         * common/next-iterator.h: New file.
15194         * objfiles.h (class all_objfiles): New.
15195         (struct objfile_iterator): New.
15196
15197 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15198
15199         * NEWS: Move the description of the changed "frame", "select-frame",
15200          and "info frame" commands to the Changed commands section.
15201
15202 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15203
15204         * gdbtypes.c (check_stub_method_group): Remove handling of old
15205         mangling schemes.
15206         * linespec.c (find_methods): Likewise.
15207         * stabsread.c (read_member_functions): Likewise.
15208         * valops.c (search_struct_method): Likewise.
15209         (value_struct_elt_for_reference): Likewise.
15210         * NEWS: Mention this change.
15211
15212 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15213
15214         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15215         print_source_lines.
15216         * source.c (print_source_lines_base): Update line number check.
15217         (print_source_lines): New function.
15218         (source_lines_range::source_lines_range): New function.
15219         * source.h (class source_lines_range): New class.
15220         (print_source_lines): New declaration.
15221
15222 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15223
15224         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15225
15226 2019-01-08  Tom Tromey  <tom@tromey.com>
15227             Simon Marchi  <simon.marchi@ericsson.com>
15228
15229         PR gdb/24060
15230         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15231         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15232         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15233         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15234         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15235         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15236
15237 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15238
15239         * source.c (select_source_symtab): Move header comment to
15240         declaration in source.h.
15241         (forget_cached_source_info_for_objfile): Likewise.
15242         (forget_cached_source_info): Likewise.
15243         (identify_source_line): Likewise.
15244         * source.h (identify_source_line): Move declaration from symtab.h
15245         and add comment from source.c
15246         (print_source_lines): Likewise.
15247         (forget_cached_source_info_for_objfile): Likewise.
15248         (forget_cached_source_info): Likewise.
15249         (select_source_symtab): Likewise.
15250         (enum print_source_lines_flag): Move definition from symtab.h.
15251         * symtab.h (identify_source_line): Move declaration to source.h.
15252         (print_source_lines): Likewise.
15253         (forget_cached_source_info_for_objfile): Likewise.
15254         (forget_cached_source_info): Likewise.
15255         (select_source_symtab): Likewise.
15256         (enum print_source_lines_flag): Move definition to source.h.
15257         * tui/tui-hooks.c: Add 'source.h' include.
15258
15259 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15260
15261         * source.c (print_source_lines_base): Handle requests to print
15262         reverse line number sequences, and guard against empty lines
15263         string.
15264
15265 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15266
15267         * source.c (print_source_lines_base): Fix skip of '\r' if next
15268         character is '\n'.
15269
15270 2019-01-06  Tom Tromey  <tom@tromey.com>
15271
15272         * c-exp.y (struct c_parse_state) <macro_original_text,
15273         expansion_obstack>: New member.
15274         (macro_original_text, expansion_obstack): Remove globals.
15275         (scan_macro_expansion, scanning_macro_expansion)
15276         (finished_macro_expansion): Update.
15277         (scan_macro_cleanup): Remove.
15278         (yylex, c_parse): Update.
15279
15280 2019-01-06  Tom Tromey  <tom@tromey.com>
15281
15282         * c-exp.y (struct c_parse_state) <strings>: New member.
15283         (operator_stoken): Update.
15284
15285 2019-01-06  Tom Tromey  <tom@tromey.com>
15286
15287         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15288         (union type_stack_elt) <typelist_val>: Now a pointer to
15289         std::vector.
15290         (type_stack_cleanup): Don't declare.
15291         (push_typelist): Update.
15292         * parse.c (pop_typelist): Return a std::vector.
15293         (push_typelist): Take a std::vector.
15294         (follow_types): Update.  Do not free args.
15295         (type_stack_cleanup): Remove.
15296         * c-exp.y (struct c_parse_state): New.
15297         (cpstate): New global.
15298         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15299         (nonempty_typelist): Update.
15300         (func_mod): Create a new vector.
15301         (c_parse): Create a c_parse_state.
15302         (check_parameter_typelist): Do not delete params.
15303         (function_method): Update.  Do not delete type_list.
15304
15305 2019-01-06  Tom Tromey  <tom@tromey.com>
15306
15307         PR gdb/28155:
15308         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15309         check_typedef.
15310         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15311         (print_return_value): Likewise.
15312
15313 2019-01-05  Tom Tromey  <tom@tromey.com>
15314
15315         * contrib/cleanup_check.py: Remove.
15316         * contrib/gcc-with-excheck: Remove.
15317         * contrib/exsummary.py: Remove.
15318         * contrib/excheck.py: Remove.
15319
15320 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15321
15322         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15323         NULL. Initialize tpprev to NULL instead of assigning it
15324         to NULL on the next statement.
15325         * windows-nat.c (windows_delete_thread): Remove check for
15326         main_thread_id before printing thread exit notifications.
15327         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15328         Remove thread ID check against main_thread_id.
15329         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15330         windows_delete_thread.
15331         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15332
15333 2019-01-04  Tom Tromey  <tom@tromey.com>
15334
15335         * compile/compile.c (_initialize_compile): Use upper case for
15336         metasyntactic variables.
15337         * symmisc.c (_initialize_symmisc): Use upper case for
15338         metasyntactic variables.
15339         * psymtab.c (_initialize_psymtab): Use upper case for
15340         metasyntactic variables.
15341         * demangle.c (demangle_command): Use upper case for metasyntactic
15342         variables.
15343         (_initialize_demangler): Likewise.
15344         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15345         variables.
15346
15347 2019-01-03  Tom Tromey  <tom@tromey.com>
15348
15349         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15350
15351 2019-01-03  Tom Tromey  <tom@tromey.com>
15352
15353         * python/py-symtab.c (salpy_str): Update.
15354         (struct salpy_sal_object) <symtab>: Now a PyObject.
15355         (salpy_dealloc): Update.
15356         (del_objfile_sal): Use gdbpy_ref.
15357
15358 2019-01-03  Tom Tromey  <tom@tromey.com>
15359
15360         * python/py-type.c (convert_field): Use new_reference.  Return
15361         gdbpy_ref.
15362         (make_fielditem): Return gdbpy_ref.
15363         (typy_fields): Update.
15364         (typy_getitem): Update.
15365         (field_name): Return gdbpy_ref.  Use new_reference.
15366         (typy_iterator_iternext): Update.
15367
15368 2019-01-03  Tom Tromey  <tom@tromey.com>
15369
15370         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15371
15372 2019-01-03  Tom Tromey  <tom@tromey.com>
15373
15374         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15375         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15376         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15377         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15378         (pspy_set_type_printers): Likewise.
15379         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15380         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15381         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15382         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15383         (objfpy_set_type_printers): Likewise.
15384
15385 2019-01-03  Tom Tromey  <tom@tromey.com>
15386
15387         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15388         (gdbpy_print_stack): Use gdbpy_err_fetch.
15389         * python/python-internal.h (class gdbpy_err_fetch): New class.
15390         (class gdbpy_enter) <m_error_type, m_error_value,
15391         m_error_traceback>: Remove.
15392         <m_error>: New member.
15393         (gdbpy_exception_to_string): Don't declare.
15394         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15395         * python/py-value.c (convert_value_from_python): Use
15396         gdbpy_err_fetch.
15397         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15398         gdbpy_exception_to_string.
15399         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15400         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15401         gdbpy_err_fetch.
15402
15403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15404
15405         * linux-nat.c (delete_lwp_cleanup): Delete.
15406         (struct lwp_deleter): New struct.
15407         (lwp_info_up): New typedef.
15408         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15409         lwp_info_up.
15410
15411 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15412
15413         * linux-fork.c (class scoped_switch_fork_info): New class.
15414         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15415
15416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15417
15418         * valops.c (find_overload_match): Remove use of null_cleanup, and
15419         calls to do_cleanups.
15420
15421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15422
15423         * compile/compile-cplus-types.c
15424         (compile_cplus_instance::decl_name): Handle changes to
15425         cp_func_name.
15426         * cp-support.c (cp_func_name): Update header comment, update
15427         return type.
15428         * cp-support.h (cp_func_name): Update return type in declaration.
15429         * valops.c (find_overload_match): Move temp_func local to top
15430         level of function and change its type.  Use temp_func to hold and
15431         delete temporary string obtained from cp_func_name.
15432
15433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15434
15435         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15436         gdb::char_vector, remove cleanup, and update uses of `msg`.
15437
15438 2019-01-03  Jim Wilson  <jimw@sifive.com>
15439
15440         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15441
15442 2019-01-02  Tom Tromey  <tom@tromey.com>
15443
15444         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15445         (tdesc_parse_xml): Remove cleanups.
15446         * target-descriptions.h (make_cleanup_free_target_description):
15447         Don't declare.
15448         (target_desc_deleter): New struct.
15449         (target_desc_up): New typedef.
15450         * target-descriptions.c (target_desc_deleter::operator()): Rename
15451         from free_target_description.
15452         (make_cleanup_free_target_description): Remove.
15453
15454 2019-01-02  Tom Tromey  <tom@tromey.com>
15455
15456         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15457         constructor, destructor.
15458         (linespec_parser): Remove typedef.
15459         (~linespec_parser): Rename from linespec_parser_delete.
15460         (linespec_lex_to_end, linespec_complete_label)
15461         (linespec_complete): Update.
15462         (decode_line_full): Remove cleanups.
15463         (decode_line_1): Update.
15464
15465 2019-01-02  Tom Tromey  <tom@tromey.com>
15466
15467         * python/python-internal.h (inferior_to_inferior_object): Change
15468         return type.
15469         * python/py-exitedevent.c (create_exited_event_object): Update.
15470         * python/py-inferior.c (inferior_to_inferior_object): Return
15471         gdbpy_ref.
15472         (python_new_inferior, python_inferior_deleted)
15473         (thread_to_thread_object, delete_thread_object)
15474         (build_inferior_list, gdbpy_selected_inferior): Update.
15475         * python/py-infthread.c (create_thread_object): Update.  Also fail
15476         if inferior_to_inferior_object fails.
15477
15478 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15479
15480         * inferior.h (class inferior) <displaced_step_state>: New field.
15481         * infrun.h (struct displaced_step_state): Move here from
15482         infrun.c.  Initialize fields, add constructor.
15483         <inf>: Remove field.
15484         <reset>: New method.
15485         * infrun.c (struct displaced_step_inferior_state): Move to
15486         infrun.h.
15487         (displaced_step_inferior_states): Remove.
15488         (get_displaced_stepping_state): Adust.
15489         (displaced_step_in_progress_any_inferior): Adjust.
15490         (displaced_step_in_progress_thread): Adjust.
15491         (displaced_step_in_progress): Adjust.
15492         (add_displaced_stepping_state): Remove.
15493         (get_displaced_step_closure_by_addr): Adjust.
15494         (remove_displaced_stepping_state): Remove.
15495         (infrun_inferior_exit): Call displaced_step_state.reset.
15496         (use_displaced_stepping): Don't check for NULL.
15497         (displaced_step_prepare_throw): Call
15498         get_displaced_stepping_state.
15499         (displaced_step_fixup): Don't check for NULL.
15500         (prepare_for_detach): Don't check for NULL.
15501
15502 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15503
15504         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15505          in case of call that did not complete.
15506
15507 2019-01-02  Andrey Utkin  <autkin@undo.io>
15508
15509         * symfile.c (find_separate_debug_file): Fix search of debug files for
15510         remote debuggee.
15511
15512 2019-01-02  Tom Tromey  <tom@tromey.com>
15513
15514         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15515         indentation.
15516         * python/py-frame.c (frapy_older): Remove cast.
15517         (frapy_newer): Likewise.
15518         * python/py-breakpoint.c (local_setattro): Remove cast.
15519         * python/py-arch.c (archpy_name): Remove local variable.
15520         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15521
15522 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15523
15524         * unittests/basic_string_view/element_access/char/empty.cc:
15525         Fix year range in copyright header.
15526
15527 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15528
15529         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15530         Delete.
15531         <operator==>: Update with for removed field.
15532         <hash>: Likewise.
15533         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15534         <isa_features>: ...this.
15535         <abi_features>: New field.
15536         (riscv_isa_flen): Update comment.
15537         (riscv_abi_xlen): New declaration.
15538         (riscv_abi_flen): New declaration.
15539         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15540         isa_features.
15541         (riscv_abi_xlen): New function.
15542         (riscv_isa_flen): Update to get answer from isa_features.
15543         (riscv_abi_flen): New function.
15544         (riscv_has_fp_abi): Update to get answer from abi_features.
15545         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15546         xlen and flen.
15547         (riscv_call_info) <xlen, flen>: Update comment.
15548         (riscv_call_arg_struct): Remove invalid assertions
15549         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15550         is removed.
15551         (riscv_gdbarch_init): Gather isa features and abi features
15552         separately, ensure both match on the gdbarch when reusing an old
15553         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15554         a target with 64-bit float hardware.
15555
15556 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15557
15558         * source.c (search_command_helper): Stop reverse search
15559         when line 1 has been searched.
15560
15561 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15562
15563         * record-full.c (record_full_base_target::close): Rewrite
15564         record_full_core_buf_list free logic.
15565
15566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15567
15568         * break-catch-syscall.c (print_one_catch_syscall): xfree
15569         the last text.
15570
15571 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15572
15573         * top.c (print_gdb_version): Update Copyright year in version
15574         message.
15575
15576 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15577
15578         Update copyright year range in all GDB files.
15579
15580 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15581
15582         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15583
15584 For older changes see ChangeLog-2018.
15585 \f
15586 Local Variables:
15587 mode: change-log
15588 left-margin: 8
15589 fill-column: 74
15590 version-control: never
15591 coding: utf-8
15592 End:
15593