gdb/ChangeLog

   1 2020-05-08  Tom de Vries  <tdevries@suse.de>
   2
   3         * infrun.c (follow_fork): Copy current_line and current_symtab to
   4         child thread.
   5
   6 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
   7
   8         * async-event.c (struct async_signal_handler, struct
   9         async_event_handler): Reformat, remove typedef.
  10
  11 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
  12
  13         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
  14         access thistype->main_type->dyn_prop_list directly.
  15
  16 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
  17
  18         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
  19         (remove_dyn_prop): Remove.  Update all users to use
  20         type::remove_dyn_prop.
  21         * gdbtypes.c (remove_dyn_prop): Rename to...
  22         (type::remove_dyn_prop): ... this.
  23
  24 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
  25
  26         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
  27         (add_dyn_prop): Remove.  Update all users to use
  28         type::add_dyn_prop.
  29         * gdbtypes.c (add_dyn_prop): Rename to...
  30         (type::add_dyn_prop): ... this.
  31
  32 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
  33
  34         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
  35         (get_dyn_prop): Remove.  Update all users to use
  36         type::dyn_prop.
  37         * gdbtypes.c (get_dyn_prop): Rename to...
  38         (type::dyn_prop): ... this.
  39
  40 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  41
  42         * gdbtypes.h (struct main_type) <flag_static>: Remove.
  43
  44 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  45
  46         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
  47         instruction, skip it if it's there.
  48
  49 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
  50
  51         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
  52
  53 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
  54
  55         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
  56         * gdbtypes.c (recursive_dump_type): Remove use of
  57         TYPE_INCOMPLETE.
  58
  59 2020-05-03  Tom Tromey  <tom@tromey.com>
  60
  61         * breakpoint.c (catch_command, tcatch_command): Remove.
  62         (_initialize_breakpoint): Use add_basic_prefix_cmd,
  63         add_show_prefix_cmd.
  64         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
  65         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
  66         Remove.
  67         (add_internal_problem_command): Use add_basic_prefix_cmd,
  68         add_show_prefix_cmd.
  69         * mips-tdep.c (set_mipsfpu_command): Remove.
  70         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
  71         * dwarf2/index-cache.c (set_index_cache_command): Remove.
  72         (_initialize_index_cache): Use add_basic_prefix_cmd.
  73         * memattr.c (dummy_cmd): Remove.
  74         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
  75         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
  76         (_initialize_tui_win): Use add_basic_prefix_cmd,
  77         add_show_prefix_cmd.
  78         * cli/cli-logging.c (set_logging_command): Remove.
  79         (_initialize_cli_logging): Use add_basic_prefix_cmd,
  80         add_show_prefix_cmd.
  81         (show_logging_command): Remove.
  82         * target.c (target_command): Remove.
  83         (add_target): Use add_basic_prefix_cmd.
  84
  85 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
  86
  87         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
  88
  89 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
  92         info_command.
  93
  94 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
  95
  96         * nbsd-nat.c (nbsd_enable_proc_events)
  97         (nbsd_nat_target::post_startup_inferior): Add.
  98         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
  99         (nbsd_nat_target::update_thread_list): Rewrite.
 100         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
 101         "PTRACE_LWP_CREATE".
 102         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
 103
 104 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 105
 106         * stack.c (_initialize_stack): Remove duplicated creation
 107         of "frame" command and "f" alias.
 108
 109 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 110
 111         PR gdb/18706
 112         * gdbtypes.c (check_typedef): Calculate size of array of
 113         stubbed type.
 114
 115 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 116
 117         PR gdb/15559
 118         * i386-tdep.c (i386_push_dummy_call): Call
 119         i386_thiscall_push_dummy_call.
 120         (i386_thiscall_push_dummy_call): New function.
 121         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 122         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 123         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 124
 125 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 126
 127         * gdbarch.sh (do_read): Add shellcheck disable directive for
 128         warning SC2162.
 129
 130 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 131
 132         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 133         "referenced but not assigned" warning.
 134
 135 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 136
 137         * gdbarch.sh: Remove code that sets fallbackdefault.
 138
 139 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 140
 141         * gdbarch.sh: Use shell operators && and || instead of
 142         -a and -o.
 143
 144 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 145
 146         * gdbarch.sh: Use $(...) instead of `...`.
 147
 148 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 149
 150         * gdbarch.sh: Use double quotes around variables.
 151
 152 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 153
 154         * gdbarch.sh: Use %s with printf, instead of variables in the
 155         format string.
 156
 157 2020-04-29  Tom Tromey  <tromey@adacore.com>
 158
 159         PR ada/25875:
 160         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 161         type fields here.
 162         (read_enumeration_type): Call
 163         update_enumeration_type_from_children later.  Update comments.
 164         (process_enumeration_scope): Don't create type fields.
 165
 166 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 167
 168         * nbsd-tdep.c: Include "xml-syscall.h".
 169         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 170
 171 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 172
 173         * nbsd-nat.c: Include "sys/wait.h".
 174         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 175         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 176         (nbsd_nat_target::remove_exec_catchpoint)
 177         (nbsd_nat_target::set_syscall_catchpoint): Add.
 178         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 179         (nbsd_nat_target::insert_exec_catchpoint)
 180         (nbsd_nat_target::remove_exec_catchpoint)
 181         (nbsd_nat_target::set_syscall_catchpoint): Add.
 182         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 183         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 184         `nbsd_get_syscall_number'.
 185
 186 2020-04-29  Tom Tromey  <tom@tromey.com>
 187
 188         * stack.c (print_block_frame_labels): Remove.
 189
 190 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 191
 192         PR gdb/17320
 193         * ada-valprint.c (val_print_packed_array_elements): Move array
 194         end bracket to new line.
 195         (ada_val_print_string): Remove extra spaces before first array
 196         element.
 197         * c-valprint.c (c_value_print_array): Likewise.
 198         * m2-valprint.c (m2_print_array_contents): Likewise.
 199         (m2_value_print_inner): Likewise.
 200         * p-valprint.c (pascal_value_print_inner): Likewise.
 201         * valprint.c (generic_val_print_array): Likewise.
 202         (value_print_array_elements): Move first array element and array
 203         end bracket to new line.
 204
 205 2020-04-29  Tom de Vries  <tdevries@suse.de>
 206
 207         PR symtab/25889
 208         * linespec.c (find_method): Fix ix calculation.
 209
 210 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 211
 212         * syscalls/update-netbsd.sh: New file.
 213         * syscalls/netbsd.xml: Regenerate.
 214         * data-directory/Makefile.in: Register `netbsd.xml' in
 215         `SYSCALLS_FILES'.
 216
 217 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 218
 219         * syscalls/update-freebsd.sh: Add double quotes.
 220
 221 2020-04-28  Tom Tromey  <tom@tromey.com>
 222
 223         * NEWS: Update.
 224         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 225         (cmdpy_init): Allow class_tui.
 226
 227 2020-04-28 Mark Williams <mark@myosotissp.com>
 228
 229         PR gdb/24480
 230         * dwarf2read.c: Add missing assingments to list_in_scope when
 231         start_symtab was already called.
 232
 233 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 234
 235         PR gdb/25881
 236         * dwarf2/read.c (offset_map_type): Use
 237         gdb:hash_enum<sect_offset> as hash function.
 238
 239 2020-04-28  Tom de Vries  <tdevries@suse.de>
 240
 241         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 242         with DW_AT_signature.
 243
 244 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 245
 246         * configure.ac: Remove check for fs_base/gs_base in
 247         user_regs_struct.
 248         * configure: Re-generate.
 249         * config.in: Re-generate.
 250         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 251         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 252         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 253
 254 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 255
 256         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 257         problematic inline frame unwinding situation.
 258         * frame.c (frame_id_computed_p): New function.
 259         * frame.h (frame_id_computed_p): New prototype.
 260
 261 2020-04-26  Tom Tromey  <tom@tromey.com>
 262
 263         * command.h (enum command_class) <class_pseudo>: Remove.
 264
 265 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 268         and whitespace.
 269
 270 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 271
 272        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 273        `PT_GET_PROCESS_STATE' block.
 274
 275 2020-04-24  Tom Tromey  <tom@tromey.com>
 276
 277         * symtab.h (symbol_get_demangled_name): Don't declare.
 278         * symtab.c (symbol_get_demangled_name): Remove.
 279         (general_symbol_info::natural_name)
 280         (general_symbol_info::demangled_name): Update.
 281
 282 2020-04-24  Tom Tromey  <tom@tromey.com>
 283
 284         PR rust/25025:
 285         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 286
 287 2020-04-24  Tom Tromey  <tom@tromey.com>
 288
 289         PR symtab/12707:
 290         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 291         exists.
 292         (new_symbol): Likewise.
 293         * compile/compile-object-load.c (get_out_value_type): Use
 294         symbol_matches_search_name.
 295
 296 2020-04-24  Tom Tromey  <tom@tromey.com>
 297
 298         * dwarf2/read.c (add_partial_symbol): Do not call
 299         compute_and_set_names.
 300
 301 2020-04-24  Tom Tromey  <tom@tromey.com>
 302
 303         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 304         overload.
 305
 306 2020-04-24  Tom Tromey  <tom@tromey.com>
 307
 308         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 309         (add_psymbol_to_list): New overload.  Make old overload call new
 310         one.
 311         * psympriv.h (add_psymbol_to_list): New overload.
 312
 313 2020-04-24  Tom Tromey  <tom@tromey.com>
 314
 315         * dwarf2/read.c (partial_die_info::read) <case
 316         DW_AT_linkage_name>: Use value_as_string.
 317         (dwarf2_string_attr): Use value_as_string.
 318         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 319         method.
 320         * dwarf2/attribute.c (attribute::value_as_string): New method.
 321
 322 2020-04-24  Tom Tromey  <tom@tromey.com>
 323
 324         * symtab.c (general_symbol_info::natural_name)
 325         (general_symbol_info::demangled_name): Check for language_rust.
 326
 327 2020-04-24  Tom Tromey  <tom@tromey.com>
 328
 329         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 330         (dwarf2_physname): ... from here.
 331         (partial_die_info::read): Add Rust "{" hack.
 332
 333 2020-04-24  Tom Tromey  <tom@tromey.com>
 334
 335         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 336         method.
 337         (symbol_set_demangled_name): Don't declare.
 338         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 339         symbol_set_demangled_name.
 340         (general_symbol_info::set_language)
 341         (general_symbol_info::compute_and_set_names): Update.
 342         * minsyms.c (minimal_symbol_reader::install): Update.
 343         * dwarf2/read.c (new_symbol): Update.
 344
 345 2020-04-24  Tom Tromey  <tromey@adacore.com>
 346
 347         PR python/23662:
 348         * python/py-type.c (convert_field): Handle
 349         FIELD_LOC_KIND_DWARF_BLOCK.
 350         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 351         (typy_get_dynamic): Nw function.
 352         (type_object_getset): Add "dynamic".
 353         * NEWS: Add entry.
 354
 355 2020-04-24  Tom Tromey  <tromey@adacore.com>
 356
 357         * ada-typeprint.c (print_choices, print_variant_part)
 358         (print_record_field_types_dynamic): New functions.
 359         (print_record_field_types): Use print_record_field_types_dynamic.
 360
 361 2020-04-24  Tom Tromey  <tromey@adacore.com>
 362
 363         * dwarf2/read.c (handle_data_member_location): New overload.
 364         (dwarf2_add_field): Use it.
 365         (decode_locdesc): Add "computed" parameter.  Update comment.
 366         * gdbtypes.c (is_dynamic_type_internal): Also look for
 367         FIELD_LOC_KIND_DWARF_BLOCK.
 368         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 369         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 370         virtual base classes.
 371         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 372         FIELD_LOC_KIND_DWARF_BLOCK.
 373
 374 2020-04-24  Tom Tromey  <tromey@adacore.com>
 375
 376         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 377         * gdbtypes.c (is_dynamic_type_internal): Check
 378         TYPE_HAS_DYNAMIC_LENGTH.
 379         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 380         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 381         New macros.
 382         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 383         constant.
 384
 385 2020-04-24  Tom Tromey  <tromey@adacore.com>
 386
 387         * dwarf2/read.c (struct variant_field): Rewrite.
 388         (struct variant_part_builder): New.
 389         (struct nextfield): Remove "variant" field.  Add "offset".
 390         (struct field_info): Add "current_variant_part" and
 391         "variant_parts".
 392         (alloc_discriminant_info): Remove.
 393         (alloc_rust_variant): New function.
 394         (quirk_rust_enum): Update.
 395         (dwarf2_add_field): Set "offset" member.  Don't handle
 396         DW_TAG_variant_part.
 397         (offset_map_type): New typedef.
 398         (convert_variant_range, create_one_variant)
 399         (create_one_variant_part, create_variant_parts)
 400         (add_variant_property): New functions.
 401         (dwarf2_attach_fields_to_type): Call add_variant_property.
 402         (read_structure_type): Don't handle DW_TAG_variant_part.
 403         (handle_variant_part, handle_variant): New functions.
 404         (handle_struct_member_die): Use them.
 405         (process_structure_scope): Don't handle variant parts.
 406         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 407         (struct discriminant_info): Remove.
 408         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 409         (struct main_type) <flag_discriminated_union>: Remove.
 410         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 411         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 412         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 413         Update.
 414         * valops.c (value_union_variant): Remove.
 415         * value.h (value_union_variant): Don't declare.
 416
 417 2020-04-24  Tom Tromey  <tromey@adacore.com>
 418
 419         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 420         (ada_value_primitive_packed_val): Update.
 421         * ada-valprint.c (ada_value_print_1): Update.
 422         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 423         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 424         just an address.  Use evaluate_for_locexpr_baton.
 425         (dwarf2_evaluate_property): Update.
 426         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 427         array_view.
 428         * findvar.c (default_read_var_value): Update.
 429         * gdbtypes.c (compute_variant_fields_inner)
 430         (resolve_dynamic_type_internal): Update.
 431         (resolve_dynamic_type): Change type of valaddr parameter.
 432         * gdbtypes.h (resolve_dynamic_type): Update.
 433         * valarith.c (value_subscripted_rvalue): Update.
 434         * value.c (value_from_contents_and_address): Update.
 435
 436 2020-04-24  Tom Tromey  <tromey@adacore.com>
 437
 438         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 439         "push_initial_value" parameter.
 440         (dwarf2_evaluate_property): Likewise.
 441         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 442
 443 2020-04-24  Tom Tromey  <tromey@adacore.com>
 444
 445         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 446         (variant::matches, compute_variant_fields_recurse)
 447         (compute_variant_fields_inner, compute_variant_fields): New
 448         functions.
 449         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 450         Use resolved_type after type is made.
 451         (operator==): Add new cases.
 452         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 453         (struct discriminant_range, struct variant, struct variant_part):
 454         New.
 455         (union dynamic_prop_data) <variant_parts, original_type>: New
 456         members.
 457         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 458         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 459         constants.
 460         * value.c (unpack_bits_as_long): Now public.
 461         * value.h (unpack_bits_as_long): Declare.
 462
 463 2020-04-24  Tom Tromey  <tromey@adacore.com>
 464
 465         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 466         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 467
 468 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 469
 470         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 471
 472 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 473
 474         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 475         (remove_fork_catchpoint, post_startup_inferior)
 476         (post_attach): Move...
 477         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 478         (remove_fork_catchpoint, post_startup_inferior)
 479         (post_attach): ...here.
 480         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 481         (remove_fork_catchpoint, post_startup_inferior)
 482         (post_attach): Move...
 483         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 484         (remove_fork_catchpoint, post_startup_inferior)
 485         (post_attach): ...here.
 486
 487 2020-04-24  Tom Tromey  <tromey@adacore.com>
 488
 489         * nat/windows-nat.h (struct windows_thread_info)
 490         <pc_adjusted>: New member.
 491         * windows-nat.c (windows_fetch_one_register): Check
 492         pc_adjusted.
 493         (windows_nat_target::get_windows_debug_event)
 494         (windows_nat_target::wait): Set pc_adjusted.
 495
 496 2020-04-24  Tom de Vries  <tdevries@suse.de>
 497
 498         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 499         Run gdb-add-index inside temp dir.
 500
 501 2020-04-23  Tom Tromey  <tromey@adacore.com>
 502
 503         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 504         in loop.
 505
 506 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 507
 508         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 509         get_frame_register instead of gdbarch_unwind_pc.
 510
 511 2020-04-23  Tom de Vries  <tdevries@suse.de>
 512
 513         * symtab.c (lookup_global_symbol): Prefer def over decl.
 514
 515 2020-04-23  Tom de Vries  <tdevries@suse.de>
 516
 517         PR symtab/25807
 518         * block.c (best_symbol, better_symbol): Promote to external.
 519         * block.h (best_symbol, better_symbol): Declare.
 520         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 521         decl.
 522
 523 2020-04-23  Tom Tromey  <tromey@adacore.com>
 524
 525         PR ada/25837:
 526         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 527         "const char *", not a "const std::string &".
 528         <name_and_matcher::operator==>: Update.
 529         * unittests/lookup_name_info-selftests.c: Change type of
 530         "result".
 531
 532 2020-04-23  Tom Tromey  <tom@tromey.com>
 533
 534         * inferior.h (iterate_over_inferiors): Don't declare.
 535         * inferior.c (iterate_over_inferiors): Remove.
 536         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 537         Remove.
 538         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 539         use iterate_over_inferiors.
 540         (darwin_resume_inferior_it)
 541         (struct resume_inferior_threads_param)
 542         (darwin_resume_inferior_threads_it): Remove.
 543         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 544
 545 2020-04-23  Tom de Vries  <tdevries@suse.de>
 546
 547         * blockframe.c (find_pc_partial_function): Use
 548         find_pc_sect_compunit_symtab rather than
 549         objfile->sf->qf->find_pc_sect_compunit_symtab.
 550
 551 2020-04-22  Tom de Vries  <tdevries@suse.de>
 552
 553         PR symtab/25764
 554         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 555         in psymtabs.
 556
 557 2020-04-22  Tom de Vries  <tdevries@suse.de>
 558
 559         PR symtab/25801
 560         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 561         symtabs.
 562
 563 2020-04-22  Tom de Vries  <tdevries@suse.de>
 564
 565         PR symtab/25700
 566         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 567         CU if already created.
 568
 569 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 570
 571         * infrun.c (displaced_step_fixup): Switch to the event_thread
 572         before calling displaced_step_restore, not after.
 573
 574 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 575
 576         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 577         its inferior is not recorded by us.
 578         (record_btrace_target_open): Replace call to
 579         all_non_exited_threads () with call to current_inferior
 580         ()->non_exited_threads ().
 581         (record_btrace_target::stop_recording): Likewise.
 582         (record_btrace_target::close): Likewise.
 583         (record_btrace_target::wait): Likewise.
 584         (record_btrace_target::record_stop_replaying): Likewise.
 585
 586 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 587
 588         * btrace.c (btrace_enable): Throw an error on double enables and
 589         when enabling recording fails.
 590         (btrace_disable): Throw an error if the thread is not recorded.
 591
 592 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 593
 594         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 595         request if we do not have a thread_info.
 596
 597 2020-04-21  Tom de Vries  <tdevries@suse.de>
 598
 599         PR gdb/25471
 600         * thread.c
 601         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 602         exception in get_frame_id.
 603
 604 2020-04-20  Tom Tromey  <tromey@adacore.com>
 605
 606         * python/python.c (struct gdbpy_event): Mark move constructor as
 607         noexcept.
 608         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 609         constructor as noexcept.
 610         * completer.h (struct completion_result): Mark move constructor as
 611         noexcept.
 612         * completer.c (completion_result::completion_result): Use
 613         initialization style.  Don't call reset_match_list.
 614
 615 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 616
 617         * MAINTAINERS (Write After Approval): Add myself.
 618
 619 2020-04-18  Tom Tromey  <tom@tromey.com>
 620
 621         * windows-tdep.c (init_w32_command_list)
 622         (w32_prefix_command_valid): Restore.
 623         (_initialize_windows_tdep): Call init_w32_command_list.
 624
 625 2020-04-18  Tom Tromey  <tom@tromey.com>
 626
 627         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 628         * value.c (value_fn_field): Update.
 629         * valops.c (find_function_in_inferior)
 630         (value_allocate_space_in_inferior): Update.
 631         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 632         Update.
 633         * tui/tui-source.c (tui_source_window::set_contents): Update.
 634         * symtab.c (lookup_global_or_static_symbol)
 635         (find_function_start_sal_1, skip_prologue_sal)
 636         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 637         * symmisc.c (dump_msymbols, dump_symtab_1)
 638         (maintenance_print_one_line_table): Update.
 639         * symfile.c (init_entry_point_info, section_is_mapped)
 640         (list_overlays_command, simple_read_overlay_table)
 641         (simple_overlay_update_1): Update.
 642         * stap-probe.c (handle_stap_probe): Update.
 643         * stabsread.c (dbx_init_float_type, define_symbol)
 644         (read_one_struct_field, read_enum_type, read_range_type): Update.
 645         * source.c (info_line_command): Update.
 646         * python/python.c (gdbpy_source_objfile_script)
 647         (gdbpy_execute_objfile_script): Update.
 648         * python/py-type.c (save_objfile_types): Update.
 649         * python/py-objfile.c (py_free_objfile): Update.
 650         * python/py-inferior.c (python_new_objfile): Update.
 651         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 652         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 653         (maintenance_check_psymtabs): Update.
 654         * printcmd.c (info_address_command): Update.
 655         * objfiles.h (struct objfile) <arch>: New method, from
 656         get_objfile_arch.
 657         (get_objfile_arch): Don't declare.
 658         * objfiles.c (get_objfile_arch): Remove.
 659         (filter_overlapping_sections): Update.
 660         * minsyms.c (msymbol_is_function): Update.
 661         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 662         (output_nondebug_symbol): Update.
 663         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 664         (mdebug_expand_psymtab): Update.
 665         * machoread.c (macho_add_oso_symfile): Update.
 666         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 667         Update.
 668         * linux-fork.c (checkpoint_command): Update.
 669         * linespec.c (convert_linespec_to_sals): Update.
 670         * jit.c (finalize_symtab): Update.
 671         * infrun.c (insert_exception_resume_from_probe): Update.
 672         * ia64-tdep.c (ia64_find_unwind_table): Update.
 673         * hppa-tdep.c (internalize_unwinds): Update.
 674         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 675         Update.
 676         * gcore.c (call_target_sbrk): Update.
 677         * elfread.c (record_minimal_symbol, elf_symtab_read)
 678         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 679         (elf_gnu_ifunc_resolve_by_got): Update.
 680         * dwarf2/read.c (create_addrmap_from_index)
 681         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 682         (read_debug_names_from_section)
 683         (process_psymtab_comp_unit_reader, add_partial_symbol)
 684         (add_partial_subprogram, process_full_comp_unit)
 685         (read_file_scope, read_func_scope, read_lexical_block_scope)
 686         (read_call_site_scope, dwarf2_ranges_read)
 687         (dwarf2_record_block_ranges, dwarf2_add_field)
 688         (mark_common_block_symbol_computed, read_tag_pointer_type)
 689         (read_tag_string_type, dwarf2_init_float_type)
 690         (dwarf2_init_complex_target_type, read_base_type)
 691         (partial_die_info::read, partial_die_info::read)
 692         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 693         (dwarf2_fetch_die_loc_sect_off): Update.
 694         * dwarf2/loc.c (dwarf2_find_location_expression)
 695         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 696         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 697         (dwarf2_loc_desc_get_symbol_read_needs)
 698         (locexpr_describe_location_piece, locexpr_describe_location_1)
 699         (loclist_describe_location): Update.
 700         * dwarf2/index-write.c (write_debug_names): Update.
 701         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 702         * dtrace-probe.c (dtrace_process_dof): Update.
 703         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 704         (process_one_symbol): Update.
 705         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 706         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 707         (coff_read_enum_type): Update.
 708         * cli/cli-cmds.c (edit_command, list_command): Update.
 709         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 710         * breakpoint.c (create_overlay_event_breakpoint)
 711         (create_longjmp_master_breakpoint)
 712         (create_std_terminate_master_breakpoint)
 713         (create_exception_master_breakpoint, get_sal_arch): Update.
 714         * block.c (block_gdbarch): Update.
 715         * annotate.c (annotate_source_line): Update.
 716
 717 2020-04-17  Tom Tromey  <tromey@adacore.com>
 718
 719         * auto-load.c (show_auto_load_cmd): Remove.
 720         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 721         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 722         (maintenance_print_arc_command): Remove.
 723         * tui/tui-win.c (tui_command): Remove.
 724         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 725         * tui/tui-layout.c (tui_layout_command): Remove.
 726         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 727         * python/python.c (user_set_python, user_show_python): Remove.
 728         (_initialize_python): Use add_basic_prefix_cmd,
 729         add_show_prefix_cmd.
 730         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 731         (install_gdb_commands): Use add_basic_prefix_cmd,
 732         add_show_prefix_cmd.
 733         (info_guile_command): Remove.
 734         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 735         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 736         add_show_prefix_cmd.
 737         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 738         Remove do_set and do_show parameters.
 739         * cli/cli-style.c (set_style, show_style): Remove.
 740         (_initialize_cli_style): Use add_basic_prefix_cmd,
 741         add_show_prefix_cmd.
 742         (cli_style_option::add_setshow_commands): Remove do_set and
 743         do_show parameters.
 744         (cli_style_option::add_setshow_commands): Use
 745         add_basic_prefix_cmd, add_show_prefix_cmd.
 746         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 747         (set_style_name): Remove.
 748         * cli/cli-dump.c (dump_command, append_command): Remove.
 749         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 750         (tekhex_dump_command, binary_dump_command)
 751         (binary_append_command): Remove.
 752         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 753         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 754         (init_w32_command_list): Remove; move into ...
 755         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 756         * valprint.c (set_print, show_print, set_print_raw)
 757         (show_print_raw): Remove.
 758         (_initialize_valprint): Use add_basic_prefix_cmd,
 759         add_show_prefix_cmd.
 760         * typeprint.c (set_print_type, show_print_type): Remove.
 761         (_initialize_typeprint): Use add_basic_prefix_cmd,
 762         add_show_prefix_cmd.
 763         * record.c (set_record_command, show_record_command): Remove.
 764         (_initialize_record): Use add_basic_prefix_cmd,
 765         add_show_prefix_cmd.
 766         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 767         add_show_prefix_cmd.
 768         (info_command, show_command, set_debug, show_debug): Remove.
 769         * top.h (set_history, show_history): Don't declare.
 770         * top.c (set_history, show_history): Remove.
 771         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 772         (unset_tdesc_cmd): Remove.
 773         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 774         add_show_prefix_cmd.
 775         * symtab.c (info_module_command): Remove.
 776         (_initialize_symtab): Use add_basic_prefix_cmd.
 777         * symfile.c (overlay_command): Remove.
 778         (_initialize_symfile): Use add_basic_prefix_cmd.
 779         * sparc64-tdep.c (info_adi_command): Remove.
 780         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 781         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 782         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 783         add_show_prefix_cmd.
 784         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 785         (_initialize_serial): Use add_basic_prefix_cmd,
 786         add_show_prefix_cmd.
 787         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 788         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 789         add_show_prefix_cmd.
 790         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 791         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 792         add_show_prefix_cmd.
 793         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 794         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 795         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 796         add_show_prefix_cmd.
 797         * remote.c (remote_command, set_remote_cmd): Remove.
 798         (_initialize_remote): Use add_basic_prefix_cmd.
 799         * record-full.c (set_record_full_command)
 800         (show_record_full_command): Remove.
 801         (_initialize_record_full): Use add_basic_prefix_cmd,
 802         add_show_prefix_cmd.
 803         * record-btrace.c (cmd_set_record_btrace)
 804         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 805         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 806         (cmd_show_record_btrace_pt): Remove.
 807         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 808         add_show_prefix_cmd.
 809         * ravenscar-thread.c (set_ravenscar_command)
 810         (show_ravenscar_command): Remove.
 811         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 812         add_show_prefix_cmd.
 813         * mips-tdep.c (show_mips_command, set_mips_command)
 814         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 815         add_show_prefix_cmd.
 816         * maint.c (maintenance_command, maintenance_info_command)
 817         (maintenance_check_command, maintenance_print_command)
 818         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 819         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 820         add_show_prefix_cmd.
 821         (show_per_command_cmd): Remove.
 822         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 823         Remove.
 824         (maintenance_show_test_settings_cmd): Remove.
 825         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 826         add_show_prefix_cmd.
 827         * maint-test-options.c (maintenance_test_options_command):
 828         Remove.
 829         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 830         * macrocmd.c (macro_command): Remove
 831         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 832         * language.c (set_check, show_check): Remove.
 833         (_initialize_language): Use add_basic_prefix_cmd,
 834         add_show_prefix_cmd.
 835         * infcmd.c (unset_command): Remove.
 836         (_initialize_infcmd): Use add_basic_prefix_cmd.
 837         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 838         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 839         add_show_prefix_cmd.
 840         * go32-nat.c (go32_info_dos_command): Remove.
 841         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 842         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 843         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 844         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 845         (_initialize_frame): Use add_basic_prefix_cmd,
 846         add_show_prefix_cmd.
 847         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 848         (_initialize_dcache): Use add_basic_prefix_cmd,
 849         add_show_prefix_cmd.
 850         * cp-support.c (maint_cplus_command): Remove.
 851         (_initialize_cp_support): Use add_basic_prefix_cmd.
 852         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 853         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 854         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 855         add_basic_prefix_cmd, add_show_prefix_cmd.
 856         * breakpoint.c (save_command): Remove.
 857         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 858         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 859         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 860         add_show_prefix_cmd.
 861         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 862         (set_ada_command, show_ada_command): Remove.
 863         (_initialize_ada_language): Use add_basic_prefix_cmd,
 864         add_show_prefix_cmd.
 865         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 866
 867 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 868
 869         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 870         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 871
 872 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 873
 874         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 875         warning messages.
 876
 877 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 878
 879         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 880         import table is not at beginning of .idata section.
 881
 882 2020-04-16  Pedro Alves  <palves@redhat.com>
 883
 884         * inferior.c (delete_inferior): Use delete operator directly
 885         instead of delete_program_space.
 886         * progspace.c (add_program_space): New, factored out from
 887         program_space::program_space.
 888         (remove_program_space): New, factored out from
 889         delete_program_space.
 890         (program_space::program_space): Remove intro comment.  Rewrite.
 891         (program_space::~program_space): Remove intro comment.  Call
 892         remove_program_space.
 893         (delete_program_space): Delete.
 894         * progspace.h (program_space::program_space): Make explicit.  Move
 895         intro comment here, adjusted.
 896         (program_space::~program_space): Move intro comment here,
 897         adjusted.
 898         (delete_program_space): Remove.
 899
 900 2020-04-16  Tom Tromey  <tromey@adacore.com>
 901
 902         * windows-nat.c (windows_nat::handle_access_violation): New
 903         function.
 904         * nat/windows-nat.h (handle_access_violation): Declare.
 905         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 906         windows-nat.c.  Call handle_access_violation.
 907
 908 2020-04-16  Tom de Vries  <tdevries@suse.de>
 909
 910         PR symtab/25791
 911         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 912         CUs without psymtab.
 913
 914 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 915
 916         * python/python.c (do_start_initialization): Don't call
 917         PyEval_InitThreads for Python 3.9 and beyond.
 918
 919 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 920
 921         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 922         thread functions.
 923         (obsd_nat_target::wait): Likewise.
 924
 925 2020-04-15  Tom Tromey  <tromey@adacore.com>
 926
 927         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 928         (DEBUG_EXCEPT): Use debug_printf.
 929
 930 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * completer.c (class completion_tracker::completion_hash_entry)
 933         <hash_name>: New member function.
 934         (completion_tracker::discard_completions): New callback to hash a
 935         completion_hash_entry, pass this to htab_create_alloc.
 936
 937 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 938
 939         * windows-nat.c (windows_make_so): Warn rather than stopping with
 940         an error if realpath() fails.
 941
 942 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 943
 944         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 945         (nbsd_nat_target::info_proc): Add do_status.
 946
 947 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 948             Tom de Vries  <tdevries@suse.de>
 949
 950         PR symtab/25718
 951         * psympriv.h (struct partial_symtab::read_symtab)
 952         (struct partial_symtab::expand_psymtab)
 953         (struct partial_symtab::read_dependencies): Update comments.
 954         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 955         read_symtab for includer.
 956         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 957         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 958         (struct dwarf2_include_psymtab::m_readin): Remove.
 959         (struct dwarf2_include_psymtab::includer): New member function.
 960         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 961
 962 2020-04-14  Tom de Vries  <tdevries@suse.de>
 963
 964         PR symtab/25720
 965         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 966         with NULL symbol_matcher and lookup_name.
 967         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 968         and lookup_name.
 969         * dwarf2/read.c (dw2_expand_symtabs_matching)
 970         (dw2_debug_names_expand_symtabs_matching): Same.
 971         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 972         Make lookup_name a pointer.  Update comment.
 973         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 974         lookup_name being a pointer.
 975         * symfile.c (expand_symtabs_matching): Same.
 976         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 977         * linespec.c (iterate_over_all_matching_symtabs): Same.
 978
 979 2020-04-13  Tom Tromey  <tom@tromey.com>
 980
 981         * run-on-main-thread.c: Update include.
 982         * unittests/main-thread-selftests.c: Update include.
 983         * tui/tui-win.c: Update include.
 984         * tui/tui-io.c: Update include.
 985         * tui/tui-interp.c: Update include.
 986         * tui/tui-hooks.c: Update include.
 987         * top.h: Update include.
 988         * top.c: Update include.
 989         * ser-base.c: Update include.
 990         * remote.c: Update include.
 991         * remote-notif.c: Update include.
 992         * remote-fileio.c: Update include.
 993         * record-full.c: Update include.
 994         * record-btrace.c: Update include.
 995         * python/python.c: Update include.
 996         * posix-hdep.c: Update include.
 997         * mingw-hdep.c: Update include.
 998         * mi/mi-main.c: Update include.
 999         * mi/mi-interp.c: Update include.
1000         * main.c: Update include.
1001         * linux-nat.c: Update include.
1002         * interps.c: Update include.
1003         * infrun.c: Update include.
1004         * inf-loop.c: Update include.
1005         * event-top.c: Update include.
1006         * event-loop.c: Move to ../gdbsupport/.
1007         * event-loop.h: Move to ../gdbsupport/.
1008         * async-event.h: Update include.
1009         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1010
1011 2020-04-13  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-win.c: Include async-event.h.
1014         * remote.c: Include async-event.h.
1015         * remote-notif.c: Include async-event.h.
1016         * record-full.c: Include async-event.h.
1017         * record-btrace.c: Include async-event.h.
1018         * infrun.c: Include async-event.h.
1019         * event-top.c: Include async-event.h.
1020         * event-loop.h: Move some declarations to async-event.h.
1021         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1022         code to async-event.c.
1023         * async-event.h: New file.
1024         * async-event.c: New file.
1025         * Makefile.in (COMMON_SFILES): Add async-event.c.
1026         (HFILES_NO_SRCDIR): Add async-event.h.
1027
1028 2020-04-13  Tom Tromey  <tom@tromey.com>
1029
1030         * utils.c (flush_streams): New function.
1031         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1032
1033 2020-04-13  Tom Tromey  <tom@tromey.com>
1034
1035         * event-loop.c (handle_file_event): Use warning, not
1036         printf_unfiltered.
1037
1038 2020-04-13  Tom Tromey  <tom@tromey.com>
1039
1040         * event-loop.c: Include <chrono>.
1041
1042 2020-04-13  Tom Tromey  <tom@tromey.com>
1043
1044         * gdb_select.h: Move to ../gdbsupport/.
1045         * event-loop.c: Update include path.
1046         * top.c: Update include path.
1047         * ser-base.c: Update include path.
1048         * ui-file.c: Update include path.
1049         * ser-tcp.c: Update include path.
1050         * guile/scm-ports.c: Update include path.
1051         * posix-hdep.c: Update include path.
1052         * ser-unix.c: Update include path.
1053         * gdb_usleep.c: Update include path.
1054         * mingw-hdep.c: Update include path.
1055         * inflow.c: Update include path.
1056         * infrun.c: Update include path.
1057         * event-top.c: Update include path.
1058
1059 2020-04-13  Tom Tromey  <tom@tromey.com>
1060
1061         * configure: Rebuild.
1062         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1063
1064 2020-04-13  Tom Tromey  <tom@tromey.com>
1065
1066         * event-loop.h (start_event_loop): Don't declare.
1067         * event-loop.c (start_event_loop): Move...
1068         * main.c (start_event_loop): ...here.  Now static.
1069
1070 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1071
1072         * MAINTAINERS: Update my email address.
1073
1074 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1075
1076         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1077         IP_ALL.
1078
1079 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1080
1081         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1082         (nbsd_nat_target::info_proc): Add do_cmdline.
1083
1084 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1085
1086         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1087         (nbsd_nat_target::info_proc): Add do_cwd.
1088
1089 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1090
1091         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1092
1093 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1094
1095         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1096         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1097         (nbsd_nat_target::info_proc): New functions.
1098         * nbsd-nat.c (kinfo_get_vmmap): New function.
1099         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1100         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1101         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1102         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1103         functions.
1104         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1105         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1106         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1107         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1108         (KINFO_VME_FLAG_GROWS_DOWN): New.
1109
1110 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1111
1112         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1113         bit shift.
1114
1115 2020-04-10  Tom Tromey  <tromey@adacore.com>
1116
1117         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1118
1119 2020-04-10  Tom Tromey  <tromey@adacore.com>
1120
1121         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1122         separate debug files.
1123
1124 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1125
1126         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1127         Move to...
1128         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1129         ... here.
1130         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1131         Check for STATUS_WX86_BREAKPOINT.
1132         (windows_nat_target::wait): Same.
1133
1134 2020-04-10  Tom de Vries  <tdevries@suse.de>
1135
1136         PR cli/25808
1137         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1138
1139 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1140
1141         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1142         (Write After Approval): Remove Tom de Vries.
1143
1144 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1145
1146         revert partially:
1147         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1148
1149         * buildsym.c (record_line): Fix undefined behavior and preserve
1150         lines at eof.
1151
1152 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1153
1154         * auxv.h (svr4_auxv_parse): New.
1155         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1156         and generic_auxv_parse.
1157         (svr4_auxv_parse): Add.
1158         * obsd-tdep.c: Include "auxv.h".
1159         (obsd_auxv_parse): Remove.
1160         (obsd_init_abi): Remove comment.
1161         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1162         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1163         * nbsd-tdep.c: Include "auxv.h".
1164         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1165
1166 2020-04-08  Tom Tromey  <tromey@adacore.com>
1167
1168         * nat/windows-nat.h (last_wait_event): Don't declare.
1169         (wait_for_debug_event): Update comment.
1170         * nat/windows-nat.c (last_wait_event): Now static.
1171
1172 2020-04-08  Tom Tromey  <tromey@adacore.com>
1173
1174         * windows-nat.c (wait_for_debug_event): Move to
1175         nat/windows-nat.c.
1176         * nat/windows-nat.h (wait_for_debug_event): Declare.
1177         * nat/windows-nat.c (wait_for_debug_event): Move from
1178         windows-nat.c.  No longer static.
1179
1180 2020-04-08  Tom Tromey  <tromey@adacore.com>
1181
1182         * windows-nat.c (get_windows_debug_event): Use
1183         fetch_pending_stop.
1184         * nat/windows-nat.h (fetch_pending_stop): Declare.
1185         * nat/windows-nat.c (fetch_pending_stop): New function.
1186
1187 2020-04-08  Tom Tromey  <tromey@adacore.com>
1188
1189         * windows-nat.c (windows_continue): Use matching_pending_stop and
1190         continue_last_debug_event.
1191         * nat/windows-nat.h (matching_pending_stop)
1192         (continue_last_debug_event): Declare.
1193         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1194         (matching_pending_stop, continue_last_debug_event): New
1195         functions.
1196
1197 2020-04-08  Tom Tromey  <tromey@adacore.com>
1198
1199         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1200         (handle_exception_result): Move to nat/windows-nat.h.
1201         (DEBUG_EXCEPTION_SIMPLE): Remove.
1202         (windows_nat::handle_ms_vc_exception): New function.
1203         (handle_exception): Move to nat/windows-nat.c.
1204         (get_windows_debug_event): Update.
1205         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1206         nat/windows-nat.c.
1207         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1208         (handle_exception_result): Move from windows-nat.c.
1209         (handle_exception): Declare.
1210         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1211         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1212         windows-nat.c.
1213
1214 2020-04-08  Tom Tromey  <tromey@adacore.com>
1215
1216         * windows-nat.c (exception_count, event_count): Remove.
1217         (handle_exception, get_windows_debug_event)
1218         (do_initial_windows_stuff): Update.
1219
1220 2020-04-08  Tom Tromey  <tromey@adacore.com>
1221
1222         * windows-nat.c (windows_nat::handle_load_dll)
1223         (windows_nat::handle_unload_dll): Rename.  No longer static.
1224         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1225         Declare.
1226
1227 2020-04-08  Tom Tromey  <tromey@adacore.com>
1228
1229         * complaints.h (stop_whining): Declare at top-level.
1230         (complaint): Don't declare stop_whining.
1231
1232 2020-04-08  Tom Tromey  <tromey@adacore.com>
1233
1234         * windows-nat.c (windows_nat::handle_output_debug_string):
1235         Rename.  No longer static.
1236         * nat/windows-nat.h (handle_output_debug_string): Declare.
1237
1238 2020-04-08  Tom Tromey  <tromey@adacore.com>
1239
1240         * windows-nat.c (current_process_handle, current_process_id)
1241         (main_thread_id, last_sig, current_event, last_wait_event)
1242         (current_windows_thread, desired_stop_thread_id, pending_stops)
1243         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1244         (display_selectors, fake_create_process)
1245         (get_windows_debug_event): Update.
1246         * nat/windows-nat.h (current_process_handle, current_process_id)
1247         (main_thread_id, last_sig, current_event, last_wait_event)
1248         (current_windows_thread, desired_stop_thread_id, pending_stops)
1249         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1250         * nat/windows-nat.c (current_process_handle, current_process_id)
1251         (main_thread_id, last_sig, current_event, last_wait_event)
1252         (current_windows_thread, desired_stop_thread_id, pending_stops)
1253         (siginfo_er): New globals.  Move from windows-nat.c.
1254
1255 2020-04-08  Tom Tromey  <tromey@adacore.com>
1256
1257         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1258         (handle_load_dll): Update.
1259         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1260
1261 2020-04-08  Tom Tromey  <tromey@adacore.com>
1262
1263         * windows-nat.c (enum thread_disposition_type): Move to
1264         nat/windows-nat.h.
1265         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1266         static.
1267         (windows_add_thread, windows_nat_target::fetch_registers)
1268         (windows_nat_target::store_registers, handle_exception)
1269         (windows_nat_target::resume, get_windows_debug_event)
1270         (windows_nat_target::get_tib_address)
1271         (windows_nat_target::thread_name)
1272         (windows_nat_target::thread_alive): Update.
1273         * nat/windows-nat.h (enum thread_disposition_type): Move from
1274         windows-nat.c.
1275         (thread_rec): Declare.
1276
1277 2020-04-08  Tom Tromey  <tromey@adacore.com>
1278
1279         * windows-nat.c: Add "using namespace".
1280         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1281         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1282
1283 2020-04-08  Tom Tromey  <tromey@adacore.com>
1284
1285         * nat/windows-nat.h (struct windows_thread_info): Declare
1286         destructor.
1287         * nat/windows-nat.c (~windows_thread_info): New.
1288
1289 2020-04-08  Tom Tromey  <tromey@adacore.com>
1290
1291         PR gdb/22992
1292         * windows-nat.c (current_event): Update comment.
1293         (last_wait_event, desired_stop_thread_id): New globals.
1294         (struct pending_stop): New.
1295         (pending_stops): New global.
1296         (windows_nat_target) <stopped_by_sw_breakpoint>
1297         <supports_stopped_by_sw_breakpoint>: New methods.
1298         (windows_fetch_one_register): Add assertions.  Adjust PC.
1299         (windows_continue): Handle pending stops.  Suspend other threads
1300         when stepping.  Use last_wait_event
1301         (wait_for_debug_event): New function.
1302         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1303         pending stops.  Queue spurious stops.
1304         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1305         (windows_nat_target::kill): Use wait_for_debug_event.
1306         * nat/windows-nat.h (struct windows_thread_info)
1307         <stopped_at_software_breakpoint>: New field.
1308         * nat/windows-nat.c (windows_thread_info::resume): Clear
1309         stopped_at_software_breakpoint.
1310
1311 2020-04-08  Tom Tromey  <tromey@adacore.com>
1312
1313         * windows-nat.c (enum thread_disposition_type): New.
1314         (thread_rec): Replace "get_context" parameter with "disposition";
1315         change type.
1316         (windows_add_thread, windows_nat_target::fetch_registers)
1317         (windows_nat_target::store_registers, handle_exception)
1318         (windows_nat_target::resume, get_windows_debug_event)
1319         (windows_nat_target::get_tib_address)
1320         (windows_nat_target::thread_name)
1321         (windows_nat_target::thread_alive): Update.
1322
1323 2020-04-08  Tom Tromey  <tromey@adacore.com>
1324
1325         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1326         (windows_continue): Use windows_continue::resume.
1327         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1328         resume>: Declare new methods.
1329         * nat/windows-nat.c: New file.
1330         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1331
1332 2020-04-08  Tom Tromey  <tromey@adacore.com>
1333
1334         * windows-nat.c (windows_add_thread, windows_delete_thread)
1335         (windows_nat_target::fetch_registers)
1336         (windows_nat_target::store_registers, fake_create_process)
1337         (windows_nat_target::resume, windows_nat_target::resume)
1338         (get_windows_debug_event, windows_nat_target::wait)
1339         (windows_nat_target::pid_to_str)
1340         (windows_nat_target::get_tib_address)
1341         (windows_nat_target::get_ada_task_ptid)
1342         (windows_nat_target::thread_name)
1343         (windows_nat_target::thread_alive): Use lwp, not tid.
1344
1345 2020-04-08  Tom Tromey  <tromey@adacore.com>
1346
1347         * windows-nat.c (handle_exception)
1348         (windows_nat_target::thread_name): Update.
1349         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1350         <name>: Now unique_xmalloc_ptr.
1351
1352 2020-04-08  Tom Tromey  <tromey@adacore.com>
1353
1354         * windows-nat.c (thread_rec)
1355         (windows_nat_target::fetch_registers): Update.
1356         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1357         Update comment.
1358         <debug_registers_changed, reload_context>: Now bool.
1359
1360 2020-04-08  Tom Tromey  <tromey@adacore.com>
1361
1362         * windows-nat.c (windows_add_thread): Use new.
1363         (windows_init_thread_list, windows_delete_thread): Use delete.
1364         (get_windows_debug_event): Update.
1365         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1366         destructor, and initializers.
1367
1368 2020-04-08  Tom Tromey  <tromey@adacore.com>
1369
1370         * windows-nat.c (struct windows_thread_info): Remove.
1371         * nat/windows-nat.h: New file.
1372
1373 2020-04-08  Tom Tromey  <tromey@adacore.com>
1374
1375         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1376         (thread_rec, windows_add_thread, windows_delete_thread)
1377         (windows_continue): Update.
1378
1379 2020-04-08  Tom Tromey  <tromey@adacore.com>
1380
1381         * windows-nat.c (struct windows_thread_info): Remove typedef.
1382         (thread_head): Remove.
1383         (thread_list): New global.
1384         (thread_rec, windows_add_thread, windows_init_thread_list)
1385         (windows_delete_thread, windows_continue): Update.
1386
1387 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1388
1389         * windows-tdep.h (windows_init_abi): Add comment.
1390         (cygwin_init_abi): New declaration.
1391         * windows-tdep.c: Split signal enumeration in two, one for
1392         Windows and one for Cygwin.
1393         (windows_gdb_signal_to_target): Only deal with signal of the
1394         Windows OS ABI.
1395         (cygwin_gdb_signal_to_target): New function.
1396         (windows_init_abi): Rename to windows_init_abi_common, don't set
1397         gdb_signal_to_target gdbarch method.  Add new new function with
1398         this name.
1399         (cygwin_init_abi): New function.
1400         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1401         comment.  Don't call windows_init_abi.
1402         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1403         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1404         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1405         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1406         a new function of this name.
1407         (i386_cygwin_init_abi): New function.
1408         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1409         OS ABI Cygwin.
1410
1411 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1412
1413         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1414         parameter.c.
1415         (dwarf2_read_gdb_index): Update.
1416
1417 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1418
1419         * nbsd-tdep.c: Include "objfiles.h".
1420         (nbsd_skip_solib_resolver): New.
1421         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1422
1423 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1424
1425         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1426         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1427         with DW_LLE_base_addressx are being emitted in DWARFv5.
1428         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1429         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1430         unsigned integer.
1431
1432 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1433
1434         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1435         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1436         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1437         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1438         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1439         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1440         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1441
1442
1443 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1444
1445         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1446         (read_loclist_index): New function definition.
1447         (lookup_loclist_base): New function definition.
1448         (read_loclist_header): New function definition.
1449         (dwarf2_cu): Add loclist_base and loclist_header field.
1450         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1451         (read_full_die_1): Read the value of DW_AT_loclists_base.
1452         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1453         (read_attribute_value): Handle DW_FORM_loclistx.
1454         (skip_one_die): Handle DW_FORM_loclistx.
1455         (loclist_header): New structure declaration.
1456         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1457
1458 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1459
1460         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1461         constructor.  Remove `addr` parameter from other constructor and
1462         add `per_cu` parameter.
1463         * dwarf2/read.c (create_partial_symtab): Update.
1464
1465 2020-04-07  Tom de Vries  <tdevries@suse.de>
1466
1467         PR symtab/25796
1468         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1469         (partial_die_info::fixup): Inherit has_const_value.
1470
1471 2020-04-07  Tom de Vries  <tdevries@suse.de>
1472
1473         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1474         symbols without address.
1475
1476 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1477
1478         * nbsd-nat.h (struct thread_info): Add forward declaration.
1479         (nbsd_nat_target::thread_alive): Add.
1480         (nbsd_nat_target::thread_name): Likewise.
1481         (nbsd_nat_target::update_thread_list): Likewise.
1482         (update_thread_list::post_attach): Likewise.
1483         (post_attach::pid_to_str): Likewise.
1484         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1485         (nbsd_thread_lister): Add.
1486         (nbsd_nat_target::thread_alive): Likewise.
1487         (nbsd_nat_target::thread_name): Likewise.
1488         (nbsd_add_threads): Likewise.
1489         (update_thread_list::post_attach): Likewise.
1490         (nbsd_nat_target::update_thread_list): Likewise.
1491         (post_attach::pid_to_str): Likewise.
1492
1493 2020-04-06  Tom Tromey  <tromey@adacore.com>
1494
1495         * ada-valprint.c (print_variant_part): Extract the variant field.
1496         (print_field_values): Use the field as the outer value when
1497         recursing.
1498
1499 2020-04-06  Tom Tromey  <tromey@adacore.com>
1500
1501         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1502         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1503         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1504         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1505         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1506
1507 2020-04-06  Tom Tromey  <tromey@adacore.com>
1508
1509         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1510         TYPE_CODE_ERROR.
1511
1512 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1513
1514         * nbsd-tdep.c: Include "gdbarch.h".
1515         Define enum with NetBSD signal numbers.
1516         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1517         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1518         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1519         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1520         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1521         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1522         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1523         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1524         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1525         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1526         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1527         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1528
1529 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1530
1531         PR gdb/25325
1532         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1533
1534 2020-04-03  Tom Tromey  <tromey@adacore.com>
1535
1536         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1537         Read constant block.
1538
1539 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1540
1541         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1542         (gdb_bfd_get_full_section_contents): New declaration.
1543         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1544         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1545         gdb_bfd_get_full_section_contents.
1546
1547 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1548
1549         * exec.c (build_section_table): Replace internal_error with
1550         gdb_assert.
1551         (section_table_xfer_memory_partial): Likewise.
1552         * mdebugread.c (parse_partial_symbols): Likewise.
1553         * psymtab.c (lookup_partial_symbol): Likewise.
1554         * utils.c (wrap_here): Likewise.
1555
1556 2020-04-02  Tom Tromey  <tromey@adacore.com>
1557
1558         * f-lang.c (build_fortran_types): Use arch_type to initialize
1559         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1560
1561 2020-04-02  Tom Tromey  <tromey@adacore.com>
1562
1563         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1564         of attributes.
1565
1566 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1567             Bernd Edlinger <bernd.edlinger@hotmail.de>
1568             Tom Tromey  <tromey@adacore.com>
1569
1570         * buildsym.c (buildsym_compunit::record_line): Remove
1571         deduplication code.
1572
1573 2020-04-02  Tom de Vries  <tdevries@suse.de>
1574
1575         PR ada/24671
1576         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1577
1578 2020-04-02  Tom de Vries  <tdevries@suse.de>
1579
1580         * dwarf2/read.c (dwarf2_gdb_index_functions,
1581         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1582         NULL.
1583         * psymtab.c (psym_lookup_global_symbol_language): New function.
1584         (psym_functions): Init psym_lookup_global_symbol_language with
1585         psym_lookup_global_symbol_language.
1586         * symfile-debug.c (debug_sym_quick_functions): Init
1587         lookup_global_symbol_language with NULL.
1588         * symfile.c (set_initial_language): Remove fixme comment.
1589         * symfile.h (struct quick_symbol_functions): Add
1590         lookup_global_symbol_language.
1591         * symtab.c (find_quick_global_symbol_language): New function.
1592         (find_main_name): Use find_quick_global_symbol_language.
1593
1594 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1595
1596         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1597
1598 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1599
1600         * buildsym.c (record_line): Fix undefined behavior and preserve
1601         lines at eof.
1602
1603 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1604
1605         * buildsym.c (record_line): Fix the resizing condition.
1606
1607 2020-04-01  Tom Tromey  <tom@tromey.com>
1608
1609         * value.h (value_literal_complex): Add comment.
1610         * valops.c (value_literal_complex): Refer to value.h.
1611
1612 2020-04-01  Tom Tromey  <tom@tromey.com>
1613
1614         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1615         (scalar_type): New rule, from typebase.
1616         (typebase): Use scalar_type.  Recognize complex types.
1617         (field_name): Handle FLOAT_KEYWORD.
1618         (ident_tokens): Add _Complex and __complex__.
1619
1620 2020-04-01  Tom Tromey  <tom@tromey.com>
1621
1622         PR exp/25299:
1623         * valarith.c (promotion_type, complex_binop): New functions.
1624         (scalar_binop): Handle complex numbers.  Use promotion_type.
1625         (value_pos, value_neg, value_complement): Handle complex numbers.
1626
1627 2020-04-01  Tom Tromey  <tom@tromey.com>
1628
1629         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1630         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1631         (parse_number): Handle complex numbers.
1632
1633 2020-04-01  Tom Tromey  <tom@tromey.com>
1634
1635         * c-valprint.c (c_decorations): Change complex suffix to "i".
1636
1637 2020-04-01  Tom Tromey  <tom@tromey.com>
1638
1639         * valprint.c (generic_value_print_complex): Use accessors.
1640         * value.h (value_real_part, value_imaginary_part): Declare.
1641         * valops.c (value_real_part, value_imaginary_part): New
1642         functions.
1643         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1644
1645 2020-04-01  Tom Tromey  <tom@tromey.com>
1646
1647         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1648         (read_range_type): Update.
1649         * mdebugread.c (basic_type): Update.
1650         * go-lang.c (build_go_types): Use init_complex_type.
1651         * gdbtypes.h (struct main_type) <complex_type>: New member.
1652         (init_complex_type): Update.
1653         (arch_complex_type): Don't declare.
1654         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1655         Make name if none given.  Use alloc_type_copy.  Look for cached
1656         complex type.
1657         (arch_complex_type): Remove.
1658         (gdbtypes_post_init): Use init_complex_type.
1659         * f-lang.c (build_fortran_types): Use init_complex_type.
1660         * dwarf2/read.c (read_base_type): Update.
1661         * d-lang.c (build_d_types): Use init_complex_type.
1662         * ctfread.c (read_base_type): Update.
1663
1664 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1665
1666         * infrun.c (stop_all_threads): Update assertion, plus when
1667         stopping threads, take into account that we might be trying
1668         to stop an all-stop target.
1669         (stop_waiting): Call 'stop_all_threads' if there exists a
1670         non-stop target.
1671
1672 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1673
1674         * target.h (exists_non_stop_target): New function declaration.
1675         * target.c (exists_non_stop_target): New function.
1676
1677 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1678
1679         PR gdb/24789
1680         * eval.c (is_integral_or_integral_reference): New function.
1681         (evaluate_subexp_standard): Allow integer references in
1682         pointer arithmetic.
1683
1684 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1685
1686         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1687         check for no ptid in the stop reply when the target is non-stop.
1688
1689 2020-04-01  Tom Tromey  <tromey@adacore.com>
1690
1691         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1692         "name" parameter to rvalue reference.  Initialize m_name_holder.
1693         <lookup_name_info>: New overloads.
1694         <name>: Return gdb::string_view.
1695         <c_str>: New method.
1696         <make_ignore_params>: Update.
1697         <search_name_hash>: Update.
1698         <language_lookup_name>: Return const char *.
1699         <m_name>: Change type.
1700         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1701         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1702         (lookup_name_info::match_any): Update.
1703         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1704         Update.
1705         * minsyms.c (linkage_name_str): Update.
1706         * language.c (default_symbol_name_matcher): Update.
1707         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1708         Update.
1709         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1710         (ada_lookup_name_info::ada_lookup_name_info): Update.
1711         (literal_symbol_name_matcher): Update.
1712
1713 2020-04-01  Tom Tromey  <tromey@adacore.com>
1714
1715         * psymtab.c (psymtab_search_name): Remove function.
1716         (psym_lookup_symbol): Create search name and lookup name here.
1717         (lookup_partial_symbol): Remove "name" parameter; add
1718         lookup_name.
1719         (psym_expand_symtabs_for_function): Update.
1720
1721 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1722
1723         PR tui/25597:
1724         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1725
1726 2020-03-31  Tom Tromey  <tromey@adacore.com>
1727
1728         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1729         memcpy.
1730
1731 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1732
1733         * features/riscv/32bit-csr.xml: Regenerated.
1734         * features/riscv/64bit-csr.xml: Regenerated.
1735
1736 2020-03-30  Tom Tromey  <tromey@adacore.com>
1737
1738         * ada-valprint.c (print_variant_part): Update.
1739         * ada-lang.h (ada_which_variant_applies): Update.
1740         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1741         outer_valaddr parameters; replace with "outer" value parameter.
1742         (to_fixed_variant_branch_type): Update.
1743
1744 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1745
1746         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1747         <list>.  Remove inclusion of observable.h.
1748         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1749         (struct arch_lwp_info): New struct.
1750         (class ppc_linux_dreg_interface): New class.
1751         (struct ppc_linux_process_info): New struct.
1752         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1753         <low_new_clone, low_forget_process, low_prepare_to_resume>
1754         <copy_thread_dreg_state, mark_thread_stale>
1755         <mark_debug_registers_changed, register_hw_breakpoint>
1756         <clear_hw_breakpoint, register_wp, clear_wp>
1757         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1758         <num_memory_accesses, get_trigger_type>
1759         <create_watchpoint_request, hwdebug_point_cmp>
1760         <init_arch_lwp_info, get_arch_lwp_info>
1761         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1762         methods.
1763         <struct ptid_hash>: New inner struct.
1764         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1765         members.
1766         (saved_dabr_value, hwdebug_info, max_slots_number)
1767         (struct hw_break_tuple, struct thread_points, ppc_threads)
1768         (have_ptrace_hwdebug_interface)
1769         (hwdebug_find_thread_points_by_tid)
1770         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1771         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1772         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1773         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1774         use m_dreg_interface.
1775         (hwdebug_point_cmp): Change to...
1776         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1777         reference arguments instead of pointers.
1778         (ppc_linux_nat_target::ranged_break_num_registers): Use
1779         m_dreg_interface.
1780         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1781         m_dreg_interface.  Call register_hw_breakpoint.
1782         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1783         m_dreg_interface.  Call clear_hw_breakpoint.
1784         (get_trigger_type): Change to...
1785         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1786         comment.
1787         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1788         use m_dreg_interface.  Call register_hw_breakpoint.
1789         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1790         use m_dreg_interface.  Call clear_hw_breakpoint.
1791         (can_use_watchpoint_cond_accel): Change to...
1792         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1793         method.  Update comment, use m_dreg_interface and
1794         m_process_info.
1795         (calculate_dvc): Change to...
1796         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1797         m_dreg_interface.
1798         (num_memory_accesses): Change to...
1799         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1800         (check_condition): Change to...
1801         (ppc_linux_nat_target::check_condition): ...this method.
1802         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1803         comment, use m_dreg_interface.
1804         (create_watchpoint_request): Change to...
1805         (ppc_linux_nat_target::create_watchpoint_request): ...this
1806         method.  Use m_dreg_interface.
1807         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1808         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1809         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1810         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1811         (ppc_linux_nat_target::low_forget_process)
1812         (ppc_linux_nat_target::low_new_fork)
1813         (ppc_linux_nat_target::low_new_clone)
1814         (ppc_linux_nat_target::low_delete_thread)
1815         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1816         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1817         only call mark_thread_stale.
1818         (ppc_linux_thread_exit): Remove.
1819         (ppc_linux_nat_target::stopped_data_address): Change to...
1820         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1821         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1822         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1823         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1824         comment.  Call low_stopped_data_address.
1825         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1826         m_dreg_interface.
1827         (ppc_linux_nat_target::masked_watch_num_registers): Use
1828         m_dreg_interface.
1829         (ppc_linux_nat_target::copy_thread_dreg_state)
1830         (ppc_linux_nat_target::mark_thread_stale)
1831         (ppc_linux_nat_target::mark_debug_registers_changed)
1832         (ppc_linux_nat_target::register_hw_breakpoint)
1833         (ppc_linux_nat_target::clear_hw_breakpoint)
1834         (ppc_linux_nat_target::register_wp)
1835         (ppc_linux_nat_target::clear_wp)
1836         (ppc_linux_nat_target::init_arch_lwp_info)
1837         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1838         (_initialize_ppc_linux_nat): Remove observer callback.
1839
1840 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1841
1842         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1843         (ppc_linux_nat_target::auxv_parse)
1844         (ppc_linux_nat_target::read_description)
1845         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1846         Move up.
1847
1848 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1849
1850         * linux-nat.h (low_new_clone): New method.
1851         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1852
1853 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1854
1855         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1856         (dbx_expand_psymtab): ... this.
1857         (start_psymtab): Update.
1858         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1859         (mdebug_expand_psymtab): ... this.
1860         (parse_partial_symbols): Update.
1861         (new_psymtab): Update.
1862         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1863         (xcoff_expand_psymtab): ... this.
1864         (xcoff_start_psymtab): Update.
1865
1866 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1867
1868         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1869         <expand_dependencies>: ... this.
1870         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1871         (partial_symtab::expand_dependencies): ... this.
1872         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1873         Update.
1874         (dwarf2_psymtab::expand_psymtab): Update.
1875         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1876         * mdebugread.c (psymtab_to_symtab_1): Update.
1877         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1878
1879 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1880
1881         * psympriv.h (discard_psymtab): Remove.
1882         * dbxread.c (dbx_end_psymtab): Update.
1883         * xcoffread.c (xcoff_end_psymtab): Update.
1884
1885 2020-03-28  Tom Tromey  <tom@tromey.com>
1886
1887         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1888         comment.
1889
1890 2020-03-28  Tom Tromey  <tom@tromey.com>
1891
1892         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1893
1894 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1895
1896         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1897
1898 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1899
1900         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1901
1902 2020-03-26  Tom Tromey  <tom@tromey.com>
1903
1904         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1905         (mark_common_block_symbol_computed, read_tag_string_type)
1906         (attr_to_dynamic_prop, read_subrange_type): Update.
1907         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1908         to be methods on struct attribute.
1909         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1910         (read_call_site_scope, partial_die_info::read)
1911         (partial_die_info::read, lookup_die_type, follow_die_ref):
1912         Update.
1913         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1914         from dwarf2_get_ref_die_offset.
1915         (attribute::constant_value): New method, from
1916         dwarf2_get_attr_constant_value.
1917         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1918         Declare method.
1919         <constant_value>: New method.
1920
1921 2020-03-26  Tom Tromey  <tom@tromey.com>
1922
1923         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1924         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1925         (dwarf_type_encoding_name): Move to stringify.c.
1926         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1927         * dwarf2/stringify.c: New file.
1928         * dwarf2/stringify.h: New file.
1929
1930 2020-03-26  Tom Tromey  <tom@tromey.com>
1931
1932         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1933         Rewrite.
1934
1935 2020-03-26  Tom Tromey  <tom@tromey.com>
1936
1937         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1938         methods.
1939         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1940         (lookup_ranges_base): Likewise.
1941         (read_cutu_die_from_dwo, read_full_die_1): Update.
1942
1943 2020-03-26  Tom Tromey  <tom@tromey.com>
1944
1945         * dwarf2/read.c (read_import_statement, read_file_scope)
1946         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1947         (read_lexical_block_scope, read_call_site_scope)
1948         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1949         (handle_struct_member_die, process_structure_scope)
1950         (update_enumeration_type_from_children)
1951         (process_enumeration_scope, read_array_type, read_common_block)
1952         (read_namespace, read_module, read_subroutine_type): Update.
1953         (sibling_die): Remove.
1954
1955 2020-03-26  Tom Tromey  <tom@tromey.com>
1956
1957         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1958         (build_type_psymtabs_reader, read_structure_type)
1959         (read_enumeration_type, read_full_die_1): Update.
1960         (dwarf2_attr_no_follow): Move to die.h.
1961         * dwarf2/die.h (struct die_info) <attr>: New method.
1962
1963 2020-03-26  Tom Tromey  <tom@tromey.com>
1964
1965         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1966         <base_address>: Now an optional.
1967         (dwarf2_find_base_address, dwarf2_rnglists_process)
1968         (dwarf2_ranges_process, fill_in_loclist_baton)
1969         (dwarf2_symbol_mark_computed): Update.
1970
1971 2020-03-26  Tom Tromey  <tom@tromey.com>
1972
1973         * dwarf2/read.c (struct die_info): Move to die.h.
1974         * dwarf2/die.h: New file.
1975
1976 2020-03-26  Tom Tromey  <tom@tromey.com>
1977
1978         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1979         * dwarf2/read.c
1980         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1981         Move to line-header.c.
1982         (read_checked_initial_length_and_offset, read_formatted_entries):
1983         Likewise.
1984         (dwarf_decode_line_header): Split into two.
1985         * dwarf2/line-header.c
1986         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1987         Move from read.c.
1988         (read_checked_initial_length_and_offset, read_formatted_entries):
1989         Likewise.
1990         (dwarf_decode_line_header): New function, split from read.c.
1991
1992 2020-03-26  Tom Tromey  <tom@tromey.com>
1993
1994         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1995         Declare method.
1996         * dwarf2/read.c (read_attribute_value): Update.
1997         (dwarf2_per_objfile::read_line_string): Rename from
1998         read_indirect_line_string.
1999         (read_formatted_entries): Update.
2000
2001 2020-03-26  Tom Tromey  <tom@tromey.com>
2002
2003         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2004         variable.
2005
2006 2020-03-26  Tom Tromey  <tom@tromey.com>
2007
2008         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2009         const.
2010         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2011         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2012         parameter const.
2013
2014 2020-03-26  Tom Tromey  <tom@tromey.com>
2015
2016         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2017         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2018         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2019         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2020
2021 2020-03-26  Tom Tromey  <tom@tromey.com>
2022
2023         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2024         file_names_size, file_full_name, file_file_name>: Use const.
2025         <file_name_at, file_names>: Add const overload.
2026         * dwarf2/line-header.c (line_header::file_file_name)
2027         (line_header::file_full_name): Update.
2028
2029 2020-03-26  Tom Tromey  <tom@tromey.com>
2030
2031         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2032         (macro_start_file, consume_improper_spaces)
2033         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2034         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2035         (dwarf_decode_macros): Move to macro.c.
2036         * dwarf2/macro.c: New file.
2037         * dwarf2/macro.h: New file.
2038         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2039
2040 2020-03-26  Tom Tromey  <tom@tromey.com>
2041
2042         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2043         method.
2044         * dwarf2/section.c: New method.  From
2045         read_indirect_string_at_offset_from.
2046         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2047         (read_indirect_string_at_offset_from): Move to section.c.
2048         (read_indirect_string_at_offset): Rewrite.
2049         (read_indirect_line_string_at_offset): Remove.
2050         (read_indirect_string, read_indirect_line_string)
2051         (dwarf_decode_macro_bytes): Update.
2052
2053 2020-03-26  Tom Tromey  <tom@tromey.com>
2054
2055         * dwarf2/section.h (struct dwarf2_section_info)
2056         <overload_complaint>: Declare.
2057         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2058         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2059         Rename from dwarf2_section_buffer_overflow_complaint.
2060         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2061         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2062
2063 2020-03-26  Tom Tromey  <tom@tromey.com>
2064
2065         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2066         Declare.
2067         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2068         Move from read.c.
2069         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2070         to section.c.
2071
2072 2020-03-26  Tom Tromey  <tom@tromey.com>
2073
2074         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2075
2076 2020-03-26  Tom Tromey  <tom@tromey.com>
2077
2078         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2079         "builder".
2080         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2081         parameter.
2082         (dwarf_decode_macros): Update.
2083
2084 2020-03-26  Tom Tromey  <tom@tromey.com>
2085
2086         * dwarf2/read.c (read_attribute_value): Update.
2087         (read_indirect_string_from_dwz): Move to dwz.c; change into
2088         method.
2089         (dwarf_decode_macro_bytes): Update.
2090         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2091         * dwarf2/dwz.c: New file.
2092         * Makefile.in (COMMON_SFILES): Add dwz.c.
2093
2094 2020-03-26  Tom Tromey  <tom@tromey.com>
2095
2096         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2097         * dwarf2/read.c: Add include.
2098         * dwarf2/index-write.c: Add include.
2099         * dwarf2/index-cache.c: Add include.
2100         * dwarf2/dwz.h: New file.
2101
2102 2020-03-25  Tom Tromey  <tom@tromey.com>
2103
2104         * compile/compile-object-load.c (get_out_value_type): Mention
2105         correct symbol name in error message.
2106
2107 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2108
2109         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2110
2111 2020-03-25  Tom de Vries  <tdevries@suse.de>
2112
2113         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2114         * symmisc.c (dump_symtab_1): Print user and includes fields.
2115         (maintenance_info_symtabs): Same.
2116
2117 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         PR gdb/25534
2120         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2121         (riscv_regcache_cooked_write): New function.
2122         (riscv_push_dummy_call): Use new function.
2123         (riscv_return_value): Likewise.
2124
2125 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2126
2127         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2128         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2129         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2130         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2131         * infrun.c (follow_fork): Likewise.
2132         (follow_fork_inferior): Likewise.
2133         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2134         * linux-nat.h (class linux_nat_target): Likewise.
2135         * remote.c (class remote_target) <follow_fork>: Likewise.
2136         (remote_target::follow_fork): Likewise.
2137         * target-delegates.c: Re-generate.
2138         * target.c (default_follow_fork): Likewise.
2139         (target_follow_fork): Likewise.
2140         * target.h (struct target_ops) <follow_fork>: Likewise.
2141         (target_follow_fork): Likewise.
2142
2143 2020-03-24  Tom de Vries  <tdevries@suse.de>
2144
2145         * psymtab.c (maintenance_info_psymtabs): Print user field.
2146
2147 2020-03-20  Tom Tromey  <tromey@adacore.com>
2148
2149         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2150         const.
2151         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2152         const.
2153
2154 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2155
2156         * ptrace.m4: Don't check for ptrace declaration.
2157         * config.in: Re-generate.
2158         * configure: Re-generate.
2159         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2160         not defined.
2161
2162 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2163
2164         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2165         `PTRACE_TYPE_RET'.
2166         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2167         * sparc-nat.c (gdb_ptrace): Likewise.
2168         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2169
2170 2020-03-20  Tom Tromey  <tromey@adacore.com>
2171
2172         * c-exp.y (lex_one_token): Fix assert.
2173
2174 2020-03-20  Tom Tromey  <tromey@adacore.com>
2175
2176         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2177         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2178         strncpy call.
2179
2180 2020-03-20  Tom Tromey  <tromey@adacore.com>
2181
2182         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2183
2184 2020-03-20  Tom Tromey  <tromey@adacore.com>
2185
2186         * ada-valprint.c (print_variant_part): Remove parameters; switch
2187         to value-based API.
2188         (print_field_values): Likewise.
2189         (ada_val_print_struct_union): Likewise.
2190         (ada_value_print_1): Update.
2191
2192 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2193
2194         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2195         nbsd_nat_target instead of inf_ptrace_target.
2196         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2197         nbsd_nat_target.
2198
2199 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2200
2201         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2202         it to the ptrace call.
2203         * (store_registers): Likewise.
2204
2205 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2206
2207         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2208         it to the ptrace call.
2209         * (store_registers): Likewise.
2210
2211 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2212
2213         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2214         valid, fetch vg value from ptrace.
2215
2216 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2217         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2218         * inf-ptrace.c: Likewise.
2219         * (gdb_ptrace): Add.
2220         * (inf_ptrace_target::resume): Update.
2221         * (inf_ptrace_target::xfer_partial): Likewise.
2222         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2223         * (inf_ptrace_peek_poke): Update.
2224
2225 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2226
2227         * x86-bsd-nat.c (gdb_ptrace): New.
2228         * (x86bsd_dr_set): Add new argument `ptid'.
2229         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2230         x86bsd_dr_set_addr): Update.
2231
2232 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * remote.c (remote_target::process_stop_reply): Handle events for
2235         all threads differently.
2236
2237 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * completer.c (completion_tracker::remove_completion): Define new
2240         function.
2241         * completer.h (completion_tracker::remove_completion): Declare new
2242         function.
2243         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2244         when adding a C++ function symbol.
2245
2246 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * completer.c (completion_tracker::completion_hash_entry): Define
2249         new class.
2250         (advance_to_filename_complete_word_point): Call
2251         recompute_lowest_common_denominator.
2252         (completion_tracker::completion_tracker): Call discard_completions
2253         to setup the hash table.
2254         (completion_tracker::discard_completions): Allow for being called
2255         from the constructor, pass new equal function, and element deleter
2256         when constructing the hash table.  Initialise new class member
2257         variables.
2258         (completion_tracker::maybe_add_completion): Remove use of
2259         m_entries_vec, and store more information into m_entries_hash.
2260         (completion_tracker::recompute_lcd_visitor): New function, most
2261         content taken from...
2262         (completion_tracker::recompute_lowest_common_denominator):
2263         ...here, this now just visits each item in the hash calling the
2264         above visitor.
2265         (completion_tracker::build_completion_result): Remove use of
2266         m_entries_vec, call recompute_lowest_common_denominator.
2267         * completer.h (completion_tracker::have_completions): Remove use
2268         of m_entries_vec.
2269         (completion_tracker::completion_hash_entry): Declare new class.
2270         (completion_tracker::recompute_lowest_common_denominator): Change
2271         function signature.
2272         (completion_tracker::recompute_lcd_visitor): Declare new function.
2273         (completion_tracker::m_entries_vec): Delete.
2274         (completion_tracker::m_entries_hash): Initialize to NULL.
2275         (completion_tracker::m_lowest_common_denominator_valid): New
2276         member variable.
2277         (completion_tracker::m_lowest_common_denominator_max_length): New
2278         member variable.
2279
2280 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2281
2282         * regformats/regdef.h: Put reg in gdb namespace.
2283
2284 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2285
2286         * i386-bsd-nat.c (gdb_ptrace): New.
2287         * (i386bsd_fetch_inferior_registers,
2288         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2289         * (i386bsd_fetch_inferior_registers,
2290         i386bsd_store_inferior_registers) Use gdb_ptrace.
2291
2292 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2293
2294         * amd64-bsd-nat.c (gdb_ptrace): New.
2295         * (amd64bsd_fetch_inferior_registers,
2296         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2297         * (amd64bsd_fetch_inferior_registers,
2298         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2299
2300 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2301
2302         * user-regs.c (user_reg::read): Rename to...
2303         (user_reg::xread): ...this.
2304         * (append_user_reg): Rename argument `read' to `xread'.
2305         * (user_reg_add_builtin): Likewise.
2306         * (user_reg_add): Likewise.
2307         * (value_of_user_reg): Likewise.
2308
2309 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2310
2311         * sparc-nat.c (gdb_ptrace): New.
2312         * sparc-nat.c (sparc_fetch_inferior_registers)
2313         (sparc_store_inferior_registers) Remove obsolete comment.
2314         * sparc-nat.c (sparc_fetch_inferior_registers)
2315         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2316         * sparc-nat.c (sparc_fetch_inferior_registers)
2317         (sparc_store_inferior_registers) Use gdb_ptrace.
2318
2319 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2320
2321         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2322         it to the ptrace call.
2323         * sh-nbsd-nat.c (store_registers): Likewise.
2324
2325 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2326
2327         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2328         nbsd_nat_target instead of inf_ptrace_target.
2329         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2330         nbsd_nat_target.
2331
2332 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2333
2334         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2335
2336 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2337
2338         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2339         <sys/sysctl.h>.
2340         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2341
2342 2020-03-17  Tom de Vries  <tdevries@suse.de>
2343
2344         PR gdb/23710
2345         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2346         fields.
2347         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2348         fields.
2349         (process_imported_unit_die): Skip import of c++ CUs.
2350
2351 2020-03-16  Tom Tromey  <tom@tromey.com>
2352
2353         * p-valprint.c (pascal_object_print_value): Initialize
2354         base_value.
2355
2356 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2357             Shahab Vahedi  <shahab@synopsys.com>
2358
2359         * Makefile.in: Add arch/arc.o
2360         * configure.tgt: Likewise.
2361         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2362         (_initialize_arc_tdep): Don't initialize old target descriptions.
2363         (arc_read_description): New function to cache target descriptions.
2364         * arc-tdep.h (arc_read_description): Add proto type.
2365         * arch/arc.c: New file.
2366         * arch/arc.h: Likewise.
2367         * features/Makefile: Replace old target descriptions with new.
2368         * features/arc-arcompact.c: Remove.
2369         * features/arc-arcompact.xml: Likewise.
2370         * features/arc-v2.c: Likewise
2371         * features/arc-v2.xml: Likewise
2372         * features/arc/aux-arcompact.xml: New file.
2373         * features/arc/aux-v2.xml: Likewise.
2374         * features/arc/core-arcompact.xml: Likewise.
2375         * features/arc/core-v2.xml: Likewise.
2376         * features/arc/aux-arcompact.c: Generate.
2377         * features/arc/aux-v2.c: Likewise.
2378         * features/arc/core-arcompact.c: Likewise.
2379         * features/arc/core-v2.c: Likewise.
2380         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2381
2382 2020-03-16  Tom Tromey  <tromey@adacore.com>
2383
2384         PR gdb/25663:
2385         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2386         putting value into bcache.
2387
2388 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2389
2390         PR gdb/21500
2391         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2392         to...
2393         (amd64_windows_init_abi_common): ... this.  Don't set size of
2394         long type.
2395         (amd64_windows_init_abi): New function.
2396         (amd64_cygwin_init_abi): New function.
2397         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2398         the Cygwin OS ABI.
2399         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2400         comment.
2401
2402 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2403
2404         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2405         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2406         (pe_import_directory_entry): New struct type.
2407         (is_linked_with_cygwin_dll): New function.
2408         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2409         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2410         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2411
2412 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2413
2414         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2415         i386_cygwin_core_osabi_sniffer.
2416
2417 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2418
2419         * i386-cygwin-tdep.c: Rename to...
2420         * i386-windows-tdep.c: ... this.
2421         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2422         i386-windows-tdep.c.
2423         * configure.tgt: Likewise.
2424
2425 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2426
2427         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2428         * osabi.c (gdb_osabi_names): Add "Windows".
2429         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2430         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2431         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2432         i386_cygwin_osabi_sniffer.
2433         (_initialize_i386_cygwin_tdep): Register OS ABI
2434         GDB_OSABI_WINDOWS for i386.
2435         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2436         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2437         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2438         for x86-64.
2439         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2440         when the target matches '*-*-mingw*'.
2441
2442 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2443
2444         * defs.h (enum gdb_osabi): Move to...
2445         * osabi.h (enum gdb_osabi): ... here.
2446         * gdbarch.sh: Include osabi.h in gdbarch.h.
2447         * gdbarch.h: Re-generate.
2448
2449 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2450
2451         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2452         function.
2453         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2454
2455 2020-03-14  Tom Tromey  <tom@tromey.com>
2456
2457         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2458         for C++.
2459         (c_type_print_modifier): Likewise.  Add "language" parameter.
2460         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2461         (c_type_print_base_1): Update.
2462         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2463         constants.
2464         * type-stack.c (type_stack::insert): Handle tp_atomic and
2465         tp_restrict.
2466         (type_stack::follow_type_instance_flags): Likewise.
2467         (type_stack::follow_types): Likewise.  Merge type-following code.
2468         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2469         (space_identifier, cv_with_space_id)
2470         (const_or_volatile_or_space_identifier_noopt)
2471         (const_or_volatile_or_space_identifier): Remove.
2472         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2473         rules.
2474         (ptr_operator, typebase): Update.
2475         (enum token_flag) <FLAG_C>: New constant.
2476         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2477         "_Atomic".
2478         (lex_one_token): Handle FLAG_C.
2479
2480 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2481
2482         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2483         it to the ptrace call.
2484         * m68k-bsd-nat.c (store_registers): Likewise.
2485
2486 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2487
2488         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2489         gdb_byte *.
2490         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2491         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2492         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2493
2494 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2495
2496         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2497         nbsd_nat_target instead of inf_ptrace_target.
2498         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2499         nbsd_nat_target.
2500
2501 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2502
2503         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2504         register_t.
2505
2506 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2507
2508         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2509         it to the ptrace call.
2510         * alpha-bsd-nat.c (store_registers): Likewise.
2511
2512 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2513
2514         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2515         includes.
2516         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2517         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2518         fill_fpregset): Likewise.
2519
2520 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2521
2522         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2523         nbsd_nat_target instead of inf_ptrace_target.
2524         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2525         nbsd_nat_target.
2526
2527 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2528
2529         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2530         register_t.
2531
2532 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2533
2534         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2535         it to the ptrace call.
2536         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2537         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2538         * arm-nbsd-nat.c (store_register): Likewise.
2539         * arm-nbsd-nat.c (store_regs): Likewise.
2540         * arm-nbsd-nat.c (store_fp_register): Likewise.
2541         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2542
2543 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2544
2545         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2546         nbsd_nat_target instead of inf_ptrace_target.
2547         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2548         nbsd_nat_target.
2549
2550 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2551
2552         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2553         it to the ptrace call.
2554         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2555
2556 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2557
2558         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2559         it to the ptrace call.
2560         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2561
2562 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2563
2564         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2565         gdb_byte *.
2566         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2567
2568 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2569
2570         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2571         instead of inf_ptrace_target.
2572         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2573         nbsd_nat_target.
2574
2575 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2576
2577         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2578         register_t.
2579
2580 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2581
2582         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2583         register_t.
2584
2585 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2586
2587         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2588         register_t.
2589
2590 2020-03-13  Tom Tromey  <tom@tromey.com>
2591
2592         * value.h (val_print): Don't declare.
2593         * valprint.h (val_print_array_elements)
2594         (val_print_scalar_formatted, generic_val_print): Don't declare.
2595         * valprint.c (generic_val_print_array): Take a struct value.
2596         (generic_val_print_ptr, generic_val_print_memberptr)
2597         (generic_val_print_bool, generic_val_print_int)
2598         (generic_val_print_char, generic_val_print_complex)
2599         (generic_val_print): Remove.
2600         (generic_value_print): Update.
2601         (do_val_print): Remove unused parameters.  Don't call
2602         la_val_print.
2603         (val_print): Remove.
2604         (common_val_print): Update.  Don't call value_check_printable.
2605         (val_print_scalar_formatted, val_print_array_elements): Remove.
2606         * rust-lang.c (rust_val_print): Remove.
2607         (rust_language_defn): Update.
2608         * p-valprint.c (pascal_val_print): Remove.
2609         (pascal_value_print_inner): Update.
2610         (pascal_object_print_val_fields, pascal_object_print_val):
2611         Remove.
2612         (pascal_object_print_static_field): Update.
2613         * p-lang.h (pascal_val_print): Don't declare.
2614         * p-lang.c (pascal_language_defn): Update.
2615         * opencl-lang.c (opencl_language_defn): Update.
2616         * objc-lang.c (objc_language_defn): Update.
2617         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2618         * m2-lang.h (m2_val_print): Don't declare.
2619         * m2-lang.c (m2_language_defn): Update.
2620         * language.h (struct language_defn) <la_val_print>: Remove.
2621         * language.c (unk_lang_value_print_inner): Rename.  Change
2622         argument types.
2623         (unknown_language_defn, auto_language_defn): Update.
2624         * go-valprint.c (go_val_print): Remove.
2625         * go-lang.h (go_val_print): Don't declare.
2626         * go-lang.c (go_language_defn): Update.
2627         * f-valprint.c (f_val_print): Remove.
2628         * f-lang.h (f_value_print): Don't declare.
2629         * f-lang.c (f_language_defn): Update.
2630         * d-valprint.c (d_val_print): Remove.
2631         * d-lang.h (d_value_print): Don't declare.
2632         * d-lang.c (d_language_defn): Update.
2633         * cp-valprint.c (cp_print_value_fields)
2634         (cp_print_value_fields_rtti, cp_print_value): Remove.
2635         (cp_print_static_field): Update.
2636         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2637         (c_val_print_struct, c_val_print_union, c_val_print_int)
2638         (c_val_print_memberptr, c_val_print): Remove.
2639         * c-lang.h (c_val_print_array, cp_print_value_fields)
2640         (cp_print_value_fields_rtti): Don't declare.
2641         * c-lang.c (c_language_defn, cplus_language_defn)
2642         (asm_language_defn, minimal_language_defn): Update.
2643         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2644         (ada_val_print_enum): Take a struct value.
2645         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2646         (ada_val_print): Remove.
2647         (ada_value_print_1): Update.
2648         (printable_val_type): Remove.
2649         * ada-lang.h (ada_val_print): Don't declare.
2650         * ada-lang.c (ada_language_defn): Update.
2651
2652 2020-03-13  Tom Tromey  <tom@tromey.com>
2653
2654         * valprint.c (do_val_print): Update.
2655         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2656         a struct value.
2657         (value_to_value_object_no_release): Declare.
2658         * python/py-value.c (value_to_value_object_no_release): New
2659         function.
2660         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2661         struct value.
2662         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2663         function.
2664         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2665         a struct value.
2666         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2667         Declare.
2668         (gdbscm_apply_val_pretty_printer): Take a struct value.
2669         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2670         value.
2671         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2672         value.
2673         * extension-priv.h (struct extension_language_ops)
2674         <apply_val_pretty_printer>: Take a struct value.
2675         * cp-valprint.c (cp_print_value): Create a struct value.
2676         (cp_print_value): Update.
2677
2678 2020-03-13  Tom Tromey  <tom@tromey.com>
2679
2680         * ada-valprint.c (print_field_values): Call common_val_print.
2681
2682 2020-03-13  Tom Tromey  <tom@tromey.com>
2683
2684         * ada-valprint.c (val_print_packed_array_elements): Remove
2685         bitoffset and val parameters.  Call common_val_print.
2686         (ada_val_print_string): Remove offset, address, and original_value
2687         parameters.
2688         (ada_val_print_array): Update.
2689         (ada_value_print_array): New function.
2690         (ada_value_print_1): Call it.
2691
2692 2020-03-13  Tom Tromey  <tom@tromey.com>
2693
2694         * ada-valprint.c (ada_value_print): Use common_val_print.
2695
2696 2020-03-13  Tom Tromey  <tom@tromey.com>
2697
2698         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2699
2700 2020-03-13  Tom Tromey  <tom@tromey.com>
2701
2702         * ada-valprint.c (ada_value_print_num): New function.
2703         (ada_value_print_1): Use it.
2704
2705 2020-03-13  Tom Tromey  <tom@tromey.com>
2706
2707         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2708
2709 2020-03-13  Tom Tromey  <tom@tromey.com>
2710
2711         * ada-valprint.c (ada_value_print_ptr): New function.
2712         (ada_value_print_1): Use it.
2713
2714 2020-03-13  Tom Tromey  <tom@tromey.com>
2715
2716         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2717         call common_val_print.
2718         (ada_val_print_1): Update.
2719         (ada_value_print_1): New function.
2720         (ada_value_print_inner): Rewrite.
2721
2722 2020-03-13  Tom Tromey  <tom@tromey.com>
2723
2724         * cp-valprint.c (cp_print_value_fields): Update.
2725         (cp_print_value): New function.
2726
2727 2020-03-13  Tom Tromey  <tom@tromey.com>
2728
2729         * m2-valprint.c (m2_value_print_inner): Use
2730         cp_print_value_fields.
2731         * cp-valprint.c (cp_print_value_fields): New function.
2732         * c-valprint.c (c_value_print_struct): New function.
2733         (c_value_print_inner): Use c_value_print_struct.
2734         * c-lang.h (cp_print_value_fields): Declare.
2735
2736 2020-03-13  Tom Tromey  <tom@tromey.com>
2737
2738         * c-valprint.c (c_value_print_array): New function.
2739         (c_value_print_inner): Use it.
2740
2741 2020-03-13  Tom Tromey  <tom@tromey.com>
2742
2743         * c-valprint.c (c_value_print_memberptr): New function.
2744         (c_value_print_inner): Use it.
2745
2746 2020-03-13  Tom Tromey  <tom@tromey.com>
2747
2748         * c-valprint.c (c_value_print_int): New function.
2749         (c_value_print_inner): Use it.
2750
2751 2020-03-13  Tom Tromey  <tom@tromey.com>
2752
2753         * c-valprint.c (c_value_print_ptr): New function.
2754         (c_value_print_inner): Use it.
2755
2756 2020-03-13  Tom Tromey  <tom@tromey.com>
2757
2758         * c-valprint.c (c_value_print_inner): Rewrite.
2759
2760 2020-03-13  Tom Tromey  <tom@tromey.com>
2761
2762         * valprint.c (generic_value_print_complex): New function.
2763         (generic_value_print): Use it.
2764
2765 2020-03-13  Tom Tromey  <tom@tromey.com>
2766
2767         * valprint.c (generic_val_print_float): Don't call
2768         val_print_scalar_formatted.
2769         (generic_val_print, generic_value_print): Update.
2770
2771 2020-03-13  Tom Tromey  <tom@tromey.com>
2772
2773         * valprint.c (generic_value_print_char): New function
2774         (generic_value_print): Use it.
2775
2776 2020-03-13  Tom Tromey  <tom@tromey.com>
2777
2778         * valprint.c (generic_value_print_int): New function.
2779         (generic_value_print): Use it.
2780
2781 2020-03-13  Tom Tromey  <tom@tromey.com>
2782
2783         * valprint.c (generic_value_print_bool): New function.
2784         (generic_value_print): Use it.
2785
2786 2020-03-13  Tom Tromey  <tom@tromey.com>
2787
2788         * valprint.c (generic_val_print_func): Simplify.
2789         (generic_val_print, generic_value_print): Update.
2790
2791 2020-03-13  Tom Tromey  <tom@tromey.com>
2792
2793         * valprint.c (generic_val_print_flags): Remove.
2794         (generic_val_print, generic_value_print): Update.
2795         (val_print_type_code_flags): Add original_value parameter.
2796
2797 2020-03-13  Tom Tromey  <tom@tromey.com>
2798
2799         * valprint.c (generic_val_print): Update.
2800         (generic_value_print): Update.
2801         * valprint.c (generic_val_print_enum): Don't call
2802         val_print_scalar_formatted.
2803
2804 2020-03-13  Tom Tromey  <tom@tromey.com>
2805
2806         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2807         * valprint.c (generic_value_print_ptr): New function.
2808
2809 2020-03-13  Tom Tromey  <tom@tromey.com>
2810
2811         * valprint.c (generic_value_print): Rewrite.
2812
2813 2020-03-13  Tom Tromey  <tom@tromey.com>
2814
2815         * p-valprint.c (pascal_object_print_value_fields)
2816         (pascal_object_print_value): New functions.
2817
2818 2020-03-13  Tom Tromey  <tom@tromey.com>
2819
2820         * p-valprint.c (pascal_value_print_inner): Rewrite.
2821
2822 2020-03-13  Tom Tromey  <tom@tromey.com>
2823
2824         * f-valprint.c (f_value_print_innner): Rewrite.
2825
2826 2020-03-13  Tom Tromey  <tom@tromey.com>
2827
2828         * m2-valprint.c (m2_print_unbounded_array): New overload.
2829         (m2_print_unbounded_array): Update.
2830         (m2_print_array_contents): Take a struct value.
2831         (m2_value_print_inner): Rewrite.
2832
2833 2020-03-13  Tom Tromey  <tom@tromey.com>
2834
2835         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2836         (d_value_print_inner): New function.
2837         * d-lang.h (d_value_print_inner): Declare.
2838         * d-lang.c (d_language_defn): Use d_value_print_inner.
2839
2840 2020-03-13  Tom Tromey  <tom@tromey.com>
2841
2842         * go-valprint.c (go_value_print_inner): New function.
2843         * go-lang.h (go_value_print_inner): Declare.
2844         * go-lang.c (go_language_defn): Use go_value_print_inner.
2845
2846 2020-03-13  Tom Tromey  <tom@tromey.com>
2847
2848         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2849         API.
2850         (rust_val_print): Rewrite.
2851         (rust_value_print_inner): New function, from rust_val_print.
2852         (rust_language_defn): Use rust_value_print_inner.
2853
2854 2020-03-13  Tom Tromey  <tom@tromey.com>
2855
2856         * ada-valprint.c (ada_value_print_inner): New function.
2857         * ada-lang.h (ada_value_print_inner): Declare.
2858         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2859
2860 2020-03-13  Tom Tromey  <tom@tromey.com>
2861
2862         * f-valprint.c (f_value_print_innner): New function.
2863         * f-lang.h (f_value_print_innner): Declare.
2864         * f-lang.c (f_language_defn): Use f_value_print_innner.
2865
2866 2020-03-13  Tom Tromey  <tom@tromey.com>
2867
2868         * p-valprint.c (pascal_value_print_inner): New function.
2869         * p-lang.h (pascal_value_print_inner): Declare.
2870         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2871
2872 2020-03-13  Tom Tromey  <tom@tromey.com>
2873
2874         * m2-valprint.c (m2_value_print_inner): New function.
2875         * m2-lang.h (m2_value_print_inner): Declare.
2876         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2877
2878 2020-03-13  Tom Tromey  <tom@tromey.com>
2879
2880         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2881         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2882         * c-valprint.c (c_value_print_inner): New function.
2883         * c-lang.h (c_value_print_inner): Declare.
2884         * c-lang.c (c_language_defn, cplus_language_defn)
2885         (asm_language_defn, minimal_language_defn): Use
2886         c_value_print_inner.
2887
2888 2020-03-13  Tom Tromey  <tom@tromey.com>
2889
2890         * p-valprint.c (pascal_object_print_value_fields): Now static.
2891         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2892
2893 2020-03-13  Tom Tromey  <tom@tromey.com>
2894
2895         * c-valprint.c (c_val_print_array): Simplify.
2896
2897 2020-03-13  Tom Tromey  <tom@tromey.com>
2898
2899         * valprint.c (value_print_array_elements): New function.
2900         * valprint.h (value_print_array_elements): Declare.
2901
2902 2020-03-13  Tom Tromey  <tom@tromey.com>
2903
2904         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2905         * mips-tdep.c (mips_print_register): Use
2906         value_print_scalar_formatted.
2907
2908 2020-03-13  Tom Tromey  <tom@tromey.com>
2909
2910         * valprint.h (value_print_scalar_formatted): Declare.
2911         * valprint.c (value_print_scalar_formatted): New function.
2912
2913 2020-03-13  Tom Tromey  <tom@tromey.com>
2914
2915         * valprint.h (generic_value_print): Declare.
2916         * valprint.c (generic_value_print): New function.
2917
2918 2020-03-13  Tom Tromey  <tom@tromey.com>
2919
2920         * valprint.c (do_val_print): Call la_value_print_inner, if
2921         available.
2922         * rust-lang.c (rust_language_defn): Update.
2923         * p-lang.c (pascal_language_defn): Update.
2924         * opencl-lang.c (opencl_language_defn): Update.
2925         * objc-lang.c (objc_language_defn): Update.
2926         * m2-lang.c (m2_language_defn): Update.
2927         * language.h (struct language_defn) <la_value_print_inner>: New
2928         member.
2929         * language.c (unknown_language_defn, auto_language_defn): Update.
2930         * go-lang.c (go_language_defn): Update.
2931         * f-lang.c (f_language_defn): Update.
2932         * d-lang.c (d_language_defn): Update.
2933         * c-lang.c (c_language_defn, cplus_language_defn)
2934         (asm_language_defn, minimal_language_defn): Update.
2935         * ada-lang.c (ada_language_defn): Update.
2936
2937 2020-03-13  Tom Tromey  <tom@tromey.com>
2938
2939         * c-valprint.c (c_value_print): Use common_val_print.
2940
2941 2020-03-13  Tom Tromey  <tom@tromey.com>
2942
2943         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2944
2945 2020-03-13  Tom Tromey  <tom@tromey.com>
2946
2947         * f-valprint.c (f77_print_array_1, f_val_print): Use
2948         common_val_print.
2949
2950 2020-03-13  Tom Tromey  <tom@tromey.com>
2951
2952         * riscv-tdep.c (riscv_print_one_register_info): Use
2953         common_val_print.
2954
2955 2020-03-13  Tom Tromey  <tom@tromey.com>
2956
2957         * mi/mi-main.c (output_register): Use common_val_print.
2958
2959 2020-03-13  Tom Tromey  <tom@tromey.com>
2960
2961         * infcmd.c (default_print_one_register_info): Use
2962         common_val_print.
2963
2964 2020-03-13  Tom Tromey  <tom@tromey.com>
2965
2966         * valprint.h (common_val_print_checked): Declare.
2967         * valprint.c (common_val_print_checked): New function.
2968         * stack.c (print_frame_arg): Use common_val_print_checked.
2969
2970 2020-03-13  Tom Tromey  <tom@tromey.com>
2971
2972         * valprint.c (do_val_print): New function, from val_print.
2973         (val_print): Use do_val_print.
2974         (common_val_print): Use do_val_print.
2975
2976 2020-03-13  Tom Tromey  <tom@tromey.com>
2977
2978         * valprint.c (value_print): Use scoped_value_mark.
2979
2980 2020-03-13  Tom de Vries  <tdevries@suse.de>
2981
2982         PR symtab/25646
2983         * psymtab.c (partial_symtab::partial_symtab): Don't set
2984         globals_offset and statics_offset.  Push element onto
2985         current_global_psymbols and current_static_psymbols stacks.
2986         (concat): New function.
2987         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2988         element from current_global_psymbols and current_static_psymbols
2989         stacks.  Concat popped elements to global_psymbols and
2990         static_symbols.
2991         (add_psymbol_to_list): Use current_global_psymbols and
2992         current_static_psymbols stacks.
2993         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2994         current_static_psymbols fields.
2995
2996 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2997
2998         * corelow.c (sniff_core_bfd): Remove.
2999         (class core_target) <m_core_vec>: Remove.
3000         (core_target::core_target): Update.
3001         (core_file_fns): Remove.
3002         (deprecated_add_core_fns): Remove.
3003         (default_core_sniffer): Remove.
3004         (sniff_core_bfd): Remove.
3005         (default_check_format): Remove.
3006         (gdb_check_format): Remove.
3007         (core_target_open): Update.
3008         (core_target::get_core_register_section): Update.
3009         (get_core_registers_cb): Update.
3010         (core_target::fetch_registers): Update.
3011         * gdbcore.h (struct core_fns): Remove.
3012         (deprecated_add_core_fns): Remove.
3013         (default_core_sniffer): Remove.
3014         (default_check_format): Remove.
3015
3016 2020-03-12  Tom Tromey  <tom@tromey.com>
3017
3018         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3019         CORE_ADDR.
3020         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3021
3022 2020-03-12  Tom Tromey  <tom@tromey.com>
3023
3024         * remote.c (remote_target::download_tracepoint)
3025         (remote_target::enable_tracepoint)
3026         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3027         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3028         sprintf_vma.
3029
3030 2020-03-12  Tom Tromey  <tom@tromey.com>
3031
3032         * symfile-mem.c: Update CORE_ADDR size assert.
3033
3034 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3035
3036         * selftest.m4: Move to gdbsupport/.
3037         * acinclude.m4: Update path to selftest.m4.
3038
3039 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3040
3041         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3042         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3043         gdbarch-selfselftests.c and selftest-arch.c.
3044         (SUBDIR_UNITTESTS_OBS): Rename to...
3045         (SELFTESTS_OBS): ... this.
3046         (COMMON_SFILES): Remove disasm-selftests.c and
3047         gdbarch-selftests.c.
3048         * configure.ac: Don't add selftest-arch.{c,o} to
3049         CONFIG_{SRCS,OBS}.
3050         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3051         preprocessor conditions.
3052
3053 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3054
3055         * configure.ac: Don't source bfd/development.sh.
3056         * selftest.m4: Modify comment.
3057         * configure: Re-generate.
3058
3059 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3060
3061         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3062         not "true" or "false".
3063         * configure: Re-generate.
3064
3065 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3066
3067         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3068         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3069         renamed to arm_nbsd_supply_gregset.
3070         (fetch_register): Update to call arm_nbsd_supply_gregset.
3071         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3072         (arm_netbsd_nat_target::fetch_registers): Update.
3073         (fetch_elfcore_registers): Removed.
3074         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3075         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3076         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3077         not require NetBSD system headers.
3078         (arm_nbsd_regset): New struct.
3079         (arm_nbsd_iterate_over_regset_sections): New function.
3080         (arm_netbsd_init_abi_common): Updated to call
3081         set_gdbarch_iterate_over_regset_sections.
3082         * arm-nbsd-tdep.h: New file.
3083
3084 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3085
3086         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3087         recursion.
3088
3089 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3090
3091         * configure: Re-generate.
3092
3093 2020-03-11  Tom Tromey  <tromey@adacore.com>
3094
3095         * ada-typeprint.c (print_choices): Fix comment.
3096
3097 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3100         previous item in the list, when the list has no items.
3101
3102 2020-03-11  Tom de Vries  <tdevries@suse.de>
3103
3104         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3105         PROP_LOCLIST handling code.
3106
3107 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3108
3109         * buildsym-legacy.c (record_line): Pass extra parameter to
3110         record_line.
3111         * buildsym.c (buildsym_compunit::record_line): Take an extra
3112         parameter, reduce duplication in the line table, and record the
3113         is_stmt flag in the line table.
3114         * buildsym.h (buildsym_compunit::record_line): Add extra
3115         parameter.
3116         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3117         non-statement lines.
3118         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3119         this to the symtab builder.
3120         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3121         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3122         through to dwarf_record_line_1.
3123         * infrun.c (process_event_stop_test): When stepping, don't stop at
3124         a non-statement instruction, and only refresh the step info when
3125         we land in the middle of a line's range.  Also add an extra
3126         comment.
3127         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3128         field.
3129         * record-btrace.c (btrace_find_line_range): Only record lines
3130         marked as is-statement.
3131         * stack.c (frame_show_address): Show the frame address if we are
3132         in a non-statement sal.
3133         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3134         (maintenance_print_one_line_table): Print a header for the is_stmt
3135         column, and include is_stmt information in the output.
3136         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3137         preference to non-statements.
3138         (find_pcs_for_symtab_line): Prefer is-statement entries.
3139         (find_line_common): Likewise.
3140         * symtab.h (struct linetable_entry): Add is_stmt field.
3141         (struct symtab_and_line): Likewise.
3142         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3143         arranging the line table.
3144
3145 2020-03-07  Tom de Vries  <tdevries@suse.de>
3146
3147         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3148         DIE.
3149
3150 2020-03-07  Tom Tromey  <tom@tromey.com>
3151
3152         * valops.c (value_literal_complex): Remove obsolete comment.
3153         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3154         comment.
3155
3156 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3157
3158         * infrun.h: Forward-declare thread_info.
3159         (set_step_info): Add thread_info parameter, add doc.
3160         * infrun.c (set_step_info): Add thread_info parameter, move doc
3161         to header.
3162         * infrun.c (process_event_stop_test): Pass thread to
3163         set_step_info call.
3164         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3165         set_step_info.
3166         (prepare_one_step): Add thread_info parameter, pass it to
3167         set_step_frame and prepare_one_step (recursive) call.
3168         (step_1): Pass thread to prepare_one_step call.
3169         (step_command_fsm::should_stop): Pass thread to
3170         prepare_one_step.
3171         (until_next_fsm): Pass thread to set_step_frame call.
3172         (finish_command): Pass thread to set_step_info call.
3173
3174 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3175
3176         * windows-tdep.c (windows_solib_create_inferior_hook):
3177         Check if inferior is running.
3178
3179 2020-03-06  Tom de Vries  <tdevries@suse.de>
3180
3181         * NEWS: Fix "the the".
3182         * ctfread.c: Same.
3183
3184 2020-03-06  Tom de Vries  <tdevries@suse.de>
3185
3186         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3187
3188 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * .dir-locals.el: Add a comment referencing the other copies of
3191         this file.
3192
3193 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3194
3195         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3196         psargs.
3197
3198 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3199
3200         * .gitattributes: New file.
3201
3202 2020-03-04  Tom Tromey  <tom@tromey.com>
3203
3204         * symmisc.c (print_symbol_bcache_statistics)
3205         (print_objfile_statistics): Update.
3206         * symfile.c (allocate_symtab): Use intern.
3207         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3208         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3209         macro_cache>: Remove.
3210         <string_cache>: New member.
3211         (struct objfile) <intern>: New methods.
3212         * elfread.c (elf_symtab_read): Use intern.
3213         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3214         (dwarf2_compute_name, dwarf2_physname)
3215         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3216         names.
3217         (guess_partial_die_structure_name): Update.
3218         (partial_die_info::fixup): Intern name.
3219         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3220         name.
3221         (dwarf2_name): Intern name.  Update.
3222         * buildsym.c (buildsym_compunit::get_macro_table): Use
3223         string_cache.
3224
3225 2020-03-04  Tom Tromey  <tom@tromey.com>
3226
3227         * jit.c (bfd_open_from_target_memory): Make "target" const.
3228         * corefile.c (gnutarget): Now const.
3229         * gdbcore.h (gnutarget): Now const.
3230
3231 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3232
3233         * NEWS: Mention support for WOW64 processes.
3234         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3235         (amd64_windows_segment_register_p): Remove static.
3236         (_initialize_amd64_windows_nat): Update.
3237         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3238         * i386-windows-nat.c (context_offset): Update.
3239         (i386_mappings): Rename and remove static.
3240         (i386_windows_segment_register_p): Remove static.
3241         (_initialize_i386_windows_nat): Update.
3242         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3243         (STATUS_WX86_SINGLE_STEP): New macro.
3244         (EnumProcessModulesEx): New macro.
3245         (Wow64SuspendThread): New macro.
3246         (Wow64GetThreadContext): New macro.
3247         (Wow64SetThreadContext): New macro.
3248         (Wow64GetThreadSelectorEntry): New macro.
3249         (windows_set_context_register_offsets): Add static.
3250         (windows_set_segment_register_p): Likewise.
3251         (windows_add_thread): Adapt for WOW64 processes.
3252         (windows_fetch_one_register): Likewise.
3253         (windows_nat_target::fetch_registers): Likewise.
3254         (windows_store_one_register): Likewise.
3255         (display_selector): Likewise.
3256         (display_selectors): Likewise.
3257         (handle_exception): Likewise.
3258         (windows_continue): Likewise.
3259         (windows_nat_target::resume): Likewise.
3260         (windows_add_all_dlls): Likewise.
3261         (do_initial_windows_stuff): Likewise.
3262         (windows_nat_target::attach): Likewise.
3263         (windows_get_exec_module_filename): Likewise.
3264         (windows_nat_target::create_inferior): Likewise.
3265         (windows_xfer_siginfo): Likewise.
3266         (_initialize_loadable): Initialize Wow64SuspendThread,
3267         Wow64GetThreadContext, Wow64SetThreadContext,
3268         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3269         * windows-nat.h (windows_set_context_register_offsets):
3270         Remove declaration.
3271         (windows_set_segment_register_p): Likewise.
3272         (i386_windows_segment_register_p): Add declaration.
3273         (amd64_windows_segment_register_p): Likewise.
3274
3275 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3276
3277         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3278         in "info registers" for AArch64/ARM.
3279
3280         The change caused "info registers" to not print GPR's.
3281
3282         gdb/ChangeLog:
3283
3284         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3285
3286         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3287         when reg->group is empty and reggroup is not.
3288
3289 2020-03-03  Tom Tromey  <tromey@adacore.com>
3290
3291         * dwarf2/frame.c (struct dwarf2_frame_cache)
3292         <checked_tailcall_bottom, entry_cfa_sp_offset,
3293         entry_cfa_sp_offset_p>: Remove members.
3294         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3295         (dwarf2_frame_prev_register): Don't call
3296         dwarf2_tailcall_sniffer_first.
3297         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3298         * frame-unwind.c (add_unwinder): New fuction.
3299         (frame_unwind_init): Use it.  Add tailcall unwinder.
3300
3301 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3302             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3303
3304         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3305         value should be printed as true.
3306
3307 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3308
3309         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3310         (windows_init_abi): Set and use windows_so_ops.
3311
3312 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3313
3314         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3315         when verifying if dealing with a convenience variable.
3316
3317 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3318
3319         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3320
3321 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3322
3323         * infrun.c (gdbarch_supports_displaced_stepping): New.
3324         (use_displaced_stepping): Break up conditions in smaller pieces.
3325         Use gdbarch_supports_displaced_stepping.
3326         (displaced_step_prepare_throw): Use
3327         gdbarch_supports_displaced_stepping.
3328
3329 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * NEWS: Mention new behaviour of the history filename.
3332         * top.c (write_history_p): Add comment.
3333         (show_write_history_p): Add header comment, give a different
3334         message when history writing is on, but the history filename is
3335         empty.
3336         (history_filename): Add comment.
3337         (history_filename_empty): New function.
3338         (show_history_filename): Add header comment, give a different
3339         message when the filename is empty.
3340         (init_history): Compare history_filename against nullptr, and only
3341         read history if the filename is not empty.
3342         (set_history_filename): Add header comment, and only make
3343         non-empty filenames absolute.
3344         (init_main): Make the filename argument to 'set history filename'
3345         optional.
3346
3347 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3348
3349         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3350         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3351         (fetch_fp_register): Update.
3352         (fetch_fp_regs): Update.
3353         (store_fp_register): Update.
3354         (store_fp_regs): Update.
3355         (arm_netbsd_nat_target::read_description): New function.
3356         (fetch_elfcore_registers): Update.
3357
3358 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3361         general_thread if the stop reply is missing a thread-id.
3362         (remote_target::process_stop_reply): Use the first non-exited
3363         thread if the target didn't pass a thread-id.
3364         * infrun.c (do_target_wait): Move call to
3365         switch_to_inferior_no_thread to ....
3366         (do_target_wait_1): ... here.
3367
3368 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3369
3370         * debuginfod-support.c: Include defs.h first.
3371
3372 2020-02-28  Tom de Vries  <tdevries@suse.de>
3373
3374         * symfile.c (set_initial_language): Use default language for lookup.
3375
3376 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3377
3378         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3379         reader variable, pass `this` to read_cutu_die_from_dwo.
3380
3381 2020-02-27  Aaron Merey  <amerey@redhat.com>
3382
3383         * source.c (open_source_file): Check for nullptr when computing
3384         srcpath.
3385
3386 2020-02-27  Tom Tromey  <tromey@adacore.com>
3387
3388         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3389         member.
3390         (dwarf2_add_field): Don't update nfields.
3391         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3392
3393 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3396         abs.
3397
3398 2020-02-26  Tom Tromey  <tom@tromey.com>
3399
3400         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3401         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3402         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3403         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3404         per_cu_data.
3405
3406 2020-02-26  Tom Tromey  <tom@tromey.com>
3407
3408         * dwarf2/index-write.c (psym_index_map): Change type.
3409         (add_address_entry_worker, write_one_signatured_type)
3410         (recursively_count_psymbols, recursively_write_psymbols)
3411         (class debug_names, psyms_seen_size, write_gdbindex)
3412         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3413
3414 2020-02-26  Aaron Merey  <amerey@redhat.com>
3415
3416         * Makefile.in: Handle optional debuginfod support.
3417         * NEWS: Update.
3418         * README: Add --with-debuginfod summary.
3419         * config.in: Regenerate.
3420         * configure: Regenerate.
3421         * configure.ac: Handle optional debuginfod support.
3422         * debuginfod-support.c: debuginfod helper functions.
3423         * debuginfod-support.h: Ditto.
3424         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3425         summary.
3426         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3427         when a dwz file cannot be found.
3428         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3429         debuginfo file cannot be found.
3430         * source.c (open_source_file): Query debuginfod servers when a
3431         source file cannot be found.
3432         * top.c (print_gdb_configuration): Include
3433         --{with,without}-debuginfod in the output.
3434
3435 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3436
3437         * thread.c (thr_try_catch_cmd): Print thread name.
3438
3439 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3440
3441         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3442         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3443         dwarf2_fetch_die_type_sect_off): Move to...
3444         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3445         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3446         dwarf2_fetch_die_type_sect_off): ... here.
3447         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3448         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3449         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3450
3451 2020-02-26  Tom de Vries  <tdevries@suse.de>
3452
3453         PR gdb/25603
3454         * symfile.c (set_initial_language): Exit-early if
3455         language_mode == language_mode_manual.
3456
3457 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3458
3459         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3460         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3461         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3462
3463 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * gdbtypes.c (create_array_type_with_stride): Handle negative
3466         array strides.
3467         * valarith.c (value_subscripted_rvalue): Likewise.
3468
3469 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3470
3471         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3472
3473 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3474
3475         * loc.h (dwarf2_get_die_type): Move to...
3476         * read.h (dwarf2_get_die_type): ... here.
3477         * read.c (dwarf2_get_die_type): Move doc to header.
3478
3479 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3480
3481         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3482         'gnulib/Makefile.in' to the list.
3483
3484 2020-02-24  Tom Tromey  <tom@tromey.com>
3485
3486         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3487         Remove.
3488         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3489         XOBNEWVEC.
3490
3491 2020-02-24  Tom Tromey  <tom@tromey.com>
3492
3493         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3494         New method.
3495         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3496         (dw2_do_instantiate_symtab, dw2_get_file_names)
3497         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3498
3499 2020-02-24  Tom Tromey  <tom@tromey.com>
3500
3501         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3502         make_scoped_restore.
3503         (dwarf2_psymtab::read_symtab): Don't clear
3504         reading_partial_symbols.
3505
3506 2020-02-24  Tom de Vries  <tdevries@suse.de>
3507
3508         PR gdb/25592
3509         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3510
3511 2020-02-24  Tom de Vries  <tdevries@suse.de>
3512
3513         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3514         commands layout next/prev/regs.
3515
3516 2020-02-22  Tom Tromey  <tom@tromey.com>
3517
3518         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3519         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3520
3521 2020-02-22  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3524
3525 2020-02-22  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3528         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3529         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3530         * tui/tui.c (_initialize_tui): Add usage text.
3531
3532 2020-02-22  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-win.c (tui_set_focus_command)
3535         (tui_set_win_height_command): Use error_no_arg.
3536         (_initialize_tui_win): Update help text.
3537         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3538
3539 2020-02-22  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3542         * tui/tui-disasm.h (struct tui_disasm_window)
3543         <display_start_addr>: Declare.
3544         * tui/tui-source.h (struct tui_source_window)
3545         <display_start_addr>: Declare.
3546         * tui/tui-winsource.h (struct tui_source_window_base)
3547         <show_source_line, display_start_addr>: New methods.
3548         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3549         Rename and move to protected section.
3550         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3551         (tui_source_window_base::do_erase_source_content): Update.
3552         (tui_source_window_base::show_source_line): Now a method.
3553         (tui_source_window_base::show_source_content)
3554         (tui_source_window_base::tui_source_window_base)
3555         (tui_source_window_base::rerender)
3556         (tui_source_window_base::refill)
3557         (tui_source_window_base::do_scroll_horizontal)
3558         (tui_source_window_base::set_is_exec_point_at)
3559         (tui_source_window_base::update_breakpoint_info)
3560         (tui_source_window_base::update_exec_info): Update.
3561         * tui/tui-source.c (tui_source_window::set_contents)
3562         (tui_source_window::showing_source_p)
3563         (tui_source_window::do_scroll_vertical)
3564         (tui_source_window::location_matches_p)
3565         (tui_source_window::line_is_displayed): Update.
3566         (tui_source_window::display_start_addr): New method.
3567         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3568         (tui_disasm_window::do_scroll_vertical)
3569         (tui_disasm_window::location_matches_p): Update.
3570         (tui_disasm_window::display_start_addr): New method.
3571
3572 2020-02-22  Tom Tromey  <tom@tromey.com>
3573
3574         * NEWS: Add entry for gdb.register_window_type.
3575         * tui/tui-layout.h (window_factory): New typedef.
3576         (tui_register_window): Declare.
3577         * tui/tui-layout.c (saved_tui_windows): New global.
3578         (tui_apply_current_layout): Use it.
3579         (tui_register_window): New function.
3580         * python/python.c (do_start_initialization): Call
3581         gdbpy_initialize_tui.
3582         (python_GdbMethods): Add "register_window_type" function.
3583         * python/python-internal.h (gdbpy_register_tui_window)
3584         (gdbpy_initialize_tui): Declare.
3585         * python/py-tui.c: New file.
3586         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3587
3588 2020-02-22  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3591
3592 2020-02-22  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3595         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3596         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3597         (tui_set_win_focus_to): Move from tui-win.c.
3598
3599 2020-02-22  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3602         functions.
3603         (known_window_types): New global.
3604         (tui_get_window_by_name): Reimplement.
3605         (initialize_known_windows): New function.
3606         (validate_window_name): Rewrite.
3607         (_initialize_tui_layout): Call initialize_known_windows.
3608
3609 2020-02-22  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3612         Remove constants.
3613         * tui/tui-winsource.h (struct tui_source_window_base)
3614         <tui_source_window_base>: Remove parameter.
3615         * tui/tui-winsource.c
3616         (tui_source_window_base::tui_source_window_base): Remove
3617         parameter.
3618         (tui_source_window_base::refill): Update.
3619         * tui/tui-stack.h (struct tui_locator_window)
3620         <tui_locator_window>: Update.
3621         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3622         Default the constructor.
3623         * tui/tui-regs.h (struct tui_data_item_window)
3624         <tui_data_item_window>: Default the constructor.
3625         (struct tui_data_window) <tui_data_window>: Likewise.
3626         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3627         Default the constructor.
3628         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3629         Default the constructor.
3630         <type>: Remove.
3631         (struct tui_win_info) <tui_win_info>: Default the constructor.
3632         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3633         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3634         Default the constructor.
3635
3636 2020-02-22  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3639         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3640         * tui/tui-win.c (tui_resize_all): Don't call
3641         tui_delete_invisible_windows.
3642         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3643         done.
3644         (tui_set_layout): Update.
3645         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3646         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3647         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3648
3649 2020-02-22  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3652         correctly.
3653
3654 2020-02-22  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3657
3658 2020-02-22  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-winsource.h (struct tui_source_window_iterator)
3661         <inner_iterator>: New etytypedef.
3662         <tui_source_window_iterator>: Take "end" parameter.
3663         <tui_source_window_iterator>: Take iterator.
3664         <operator*, advance>: Update.
3665         <m_iter>: Change type.
3666         <m_end>: New field.
3667         (struct tui_source_windows) <begin, end>: Update.
3668         * tui/tui-layout.c (tui_windows): New global.
3669         (tui_apply_current_layout): Clear tui_windows.
3670         (tui_layout_window::apply): Update tui_windows.
3671         * tui/tui-data.h (tui_windows): Declare.
3672         (all_tui_windows): Now inline function.
3673         (class tui_window_iterator, struct all_tui_windows): Remove.
3674
3675 2020-02-22  Tom Tromey  <tom@tromey.com>
3676
3677         PR tui/17850:
3678         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3679         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3680         "height" argument.
3681         (class tui_layout_window) <get_sizes>: Likewise.
3682         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3683         argument.
3684         <get_sizes>: Add "height" argument.
3685         <m_vertical>: New field.
3686         * tui/tui-layout.c (tui_layout_split::clone): Update.
3687         (tui_layout_split::get_sizes): Add "height" argument.
3688         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3689         (tui_new_layout_command): Parse "-horizontal".
3690         (_initialize_tui_layout): Update help string.
3691         (tui_layout_split::specification): Add "-horizontal" when needed.
3692         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3693         argument.
3694         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3695         New methods.
3696
3697 2020-02-22  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-layout.h (enum tui_adjust_result): New.
3700         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3701         (class tui_layout_window) <adjust_size>: Return
3702         tui_adjust_result.  Rewrite.
3703         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3704         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3705
3706 2020-02-22  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3709         parameter and return types.
3710         (class tui_layout_base) <specification>: Add "depth".
3711         (class tui_layout_window) <specification>: Add "depth".
3712         (class tui_layout_split) <specification>: Add "depth".
3713         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3714         and return types.
3715         (tui_new_layout_command): Parse sub-layouts.
3716         (_initialize_tui_layout): Update help string.
3717         (tui_layout_window::specification): Add "depth".
3718         (add_layout_command): Update.
3719
3720 2020-02-22  Tom Tromey  <tom@tromey.com>
3721
3722         * NEWS: Add "tui new-layout" item.
3723         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3724         Add new-layout command to help text.
3725         (validate_window_name): New function.
3726         (tui_new_layout_command): New function.
3727         (_initialize_tui_layout): Register "new-layout".
3728         (tui_layout_window::specification): New method.
3729         (tui_layout_window::specification): New method.
3730         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3731         method.
3732         (class tui_layout_window) <specification>: New method.
3733         (class tui_layout_split) <specification>: New method.
3734
3735 2020-02-22  Tom Tromey  <tom@tromey.com>
3736
3737         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3738         * tui/tui-win.c (window_name_completer): Update comment.
3739         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3740         Declare method.
3741         (class tui_layout_window) <replace_window>: Likewise.
3742         (class tui_layout_split) <replace_window>: Likewise.
3743         (tui_set_layout): Don't declare.
3744         (tui_set_initial_layout): Declare function.
3745         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3746         (asm_regs_layout): New globals.
3747         (tui_current_layout, show_layout): Remove.
3748         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3749         (find_layout, tui_apply_layout): New function.
3750         (layout_completer): Remove.
3751         (tui_next_layout): Reimplement.
3752         (tui_next_layout_command): New function.
3753         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3754         (tui_regs_layout): Reimplement.
3755         (tui_regs_layout_command): New function.
3756         (extract_display_start_addr): Rewrite.
3757         (next_layout, prev_layout): Remove.
3758         (tui_layout_window::replace_window): New method.
3759         (tui_layout_split::replace_window): New method.
3760         (destroy_layout): New function.
3761         (layout_list): New global.
3762         (add_layout_command): New function.
3763         (initialize_layouts): Update.
3764         (tui_layout_command): New function.
3765         (_initialize_tui_layout): Install "layout" commands.
3766         * tui/tui-data.h (enum tui_layout_type): Remove.
3767         (tui_current_layout): Don't declare.
3768
3769 2020-02-22  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-regs.c (tui_reg_layout): Remove.
3772         (tui_reg_command): Use tui_regs_layout.
3773         * tui/tui-layout.h (tui_reg_command): Declare.
3774         * tui/tui-layout.c (tui_reg_command): New function.
3775
3776 2020-02-22  Tom Tromey  <tom@tromey.com>
3777
3778         * tui/tui.c (tui_rl_delete_other_windows): Call
3779         tui_remove_some_windows.
3780         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3781         Declare method.
3782         (class tui_layout_window) <remove_windows>: New method.
3783         (class tui_layout_split) <remove_windows>: Declare.
3784         (tui_remove_some_windows): Declare.
3785         * tui/tui-layout.c (tui_remove_some_windows): New function.
3786         (tui_layout_split::remove_windows): New method.
3787
3788 2020-02-22  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3791         * tui/tui-layout.h (tui_next_layout): Declare.
3792         * tui/tui-layout.c (tui_next_layout): New function.
3793
3794 2020-02-22  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3797         correct coordinates.
3798
3799 2020-02-22  Tom Tromey  <tom@tromey.com>
3800
3801         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3802         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3803         DATA_WIN case.
3804
3805 2020-02-22  Tom Tromey  <tom@tromey.com>
3806
3807         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3808         TUI_DISASM_WIN, not tui_win_list.
3809
3810 2020-02-22  Tom Tromey  <tom@tromey.com>
3811
3812         * valprint.c (generic_val_print_enum_1)
3813         (val_print_type_code_flags): Style member names.
3814         * rust-lang.c (val_print_struct, rust_print_enum)
3815         (rust_print_struct_def, rust_internal_print_type): Style member
3816         names.
3817         * p-valprint.c (pascal_object_print_value_fields): Style member
3818         names.  Only call fprintf_symbol_filtered for static members.
3819         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3820         * f-valprint.c (f_val_print): Style member names.
3821         * f-typeprint.c (f_type_print_base): Style member names.
3822         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3823         call fprintf_symbol_filtered for static members.
3824         (cp_print_class_member): Style member names.
3825         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3826         member names.
3827         * ada-valprint.c (ada_print_scalar): Style enum names.
3828         (ada_val_print_enum): Likewise.
3829         * ada-typeprint.c (print_enum_type): Style enum names.
3830
3831 2020-02-21  Tom Tromey  <tom@tromey.com>
3832
3833         * psympriv.h (struct partial_symtab): Update comment.
3834
3835 2020-02-21  Tom Tromey  <tromey@adacore.com>
3836
3837         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3838         type is CORE_ADDR.
3839
3840 2020-02-21  Tom de Vries  <tdevries@suse.de>
3841
3842         PR gdb/25534
3843         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3844         if dependencies[i]->user != NULL.
3845
3846 2020-02-21  Ali Tamur  <tamur@google.com>
3847
3848         * dwarf2/read.c (dwarf2_name): Add null check.
3849
3850 2020-02-20  Tom Tromey  <tom@tromey.com>
3851
3852         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3853         ">=", in binary search.
3854         (dwarf2_find_containing_comp_unit): New overload.
3855         (run_test): New self-test.
3856         (_initialize_dwarf2_read): Register new test.
3857
3858 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3859
3860         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3861         * riscv-tdep.h: Likewise.
3862         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3863         rv32-only CSR.
3864         * features/riscv/64bit-csr.xml: Regenerated.
3865
3866 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3867             Tom Tromey  <tom@tromey.com>
3868
3869         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3870         of 'fputc_unfiltered'.
3871         (putchar_unfiltered): Call 'fputc_unfiltered'.
3872         (fputc_unfiltered): Call 'fputs_unfiltered'.
3873
3874 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * config.in: Regenerate.
3877         * configure: Regenerate.
3878         * configure.ac: Add --with-python-libdir option.
3879         * main.c: Use WITH_PYTHON_LIBDIR.
3880
3881 2020-02-19  Tom Tromey  <tom@tromey.com>
3882
3883         * symtab.c (general_symbol_info::compute_and_set_names): Use
3884         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3885
3886 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3887
3888         * dwarf2/read.c (allocate_signatured_type_table,
3889         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3890         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3891         Remove objfile parameter, update all callers.
3892
3893 2020-02-19  Doug Evans  <dje@google.com>
3894
3895         PR rust/25535
3896         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3897         rust_enum_variant calculation.
3898
3899 2020-02-19  Tom Tromey  <tromey@adacore.com>
3900
3901         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3902
3903 2020-02-19  Tom Tromey  <tromey@adacore.com>
3904
3905         * ada-lang.c (cache_symbol): Use obstack_strdup.
3906
3907 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * configure: Regenerate.
3910
3911 2020-02-19  Tom Tromey  <tromey@adacore.com>
3912
3913         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3914         NULL check.
3915
3916 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3917
3918         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3919
3920 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3923         if GDBSERVER is not defined.
3924         (riscv_tdesc_cache): Likewise, also store const target_desc.
3925         (STATIC_IN_GDB): Define.
3926         (riscv_create_target_description): Update declaration with
3927         STATIC_IN_GDB.
3928         (riscv_lookup_target_description): New function, only define if
3929         GDBSERVER is not defined.
3930         * arch/riscv.h (riscv_create_target_description): Declare only
3931         when GDBSERVER is defined.
3932         (riscv_lookup_target_description): New declaration when GDBSERVER
3933         is not defined.
3934         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3935         (riscv_linux_read_features): ...this, and return
3936         riscv_gdbarch_features instead of target_desc.
3937         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3938         (riscv_linux_read_description): Rename to...
3939         (riscv_linux_read_features): ...this.
3940         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3941         Update to use riscv_gdbarch_features and
3942         riscv_lookup_target_description.
3943         * riscv-tdep.c (riscv_find_default_target_description): Use
3944         riscv_lookup_target_description instead of
3945         riscv_create_target_description.
3946
3947 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3948
3949         * valprint.c (generic_val_print_enum_1): When printing a flag
3950         enum with value 0 and there is no enumerator with value 0, print
3951         just "0" instead of "(unknown: 0x0)".
3952
3953 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3954
3955         * valprint.c (generic_val_print_enum_1): Print unknown part of
3956         flag enum in hex.
3957
3958 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3959
3960         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3961         flag enums to contain duplicate enumerators.
3962         * valprint.c (generic_val_print_enum_1): Update comment.
3963
3964 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3965
3966         * dwarf2/read.c: Include "count-one-bits.h".
3967         (update_enumeration_type_from_children): If an enumerator has
3968         multiple bits set, don't treat the enumeration as a "flag enum".
3969         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3970         of flag enums have 0 or 1 bit set.
3971
3972 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3973
3974         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3975         conversion.
3976         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3977         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3978         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3979         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3980         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3981
3982 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3983
3984         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3985
3986 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3987
3988         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3989         displaced_step_closure_up.
3990         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3991         (struct displaced_step_closure_up):
3992         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3993         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3994         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3995         Likewise.
3996         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3997         * gdbarch.c, gdbarch.h: Re-generate.
3998         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3999         displaced_step_closure_up.
4000         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4001         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4002         * infrun.h (displaced_step_closure_up): New type alias.
4003         (struct displaced_step_inferior_state) <step_closure>: Change
4004         type to displaced_step_closure_up.
4005         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4006         displaced_step_closure_up.
4007         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4008
4009 2020-02-14  Tom Tromey  <tom@tromey.com>
4010
4011         * minidebug.c (gnu_debug_key): New global.
4012         (find_separate_debug_file_in_section): Use it.
4013
4014 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4015
4016         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4017         std::unique_ptr.
4018         * gdbarch.c: Re-generate.
4019         * gdbarch.h: Re-generate.
4020         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4021         change.
4022         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4023         type to std::unique_ptr.
4024         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4025         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4026         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4027         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4028         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4029         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4030         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4031         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4032         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4033
4034 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4035
4036         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4037         std::unique_ptr.
4038         (displaced_step_clear): Rename to...
4039         (displaced_step_reset): ... this.  Just call displaced->reset ().
4040         (displaced_step_clear_cleanup): Rename to...
4041         (displaced_step_reset_cleanup): ... this.
4042         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4043         (displaced_step_fixup): Likewise.
4044         (resume_1): Likewise.
4045         (handle_inferior_event): Restore child's memory before calling
4046         displaced_step_fixup on the parent.
4047         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4048         to std::unique_ptr.
4049         <step_closure>: Change type to std::unique_ptr.
4050
4051 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4052
4053         * arm-tdep.c: Include count-one-bits.h.
4054         (cleanup_block_store_pc): Use count_one_bits.
4055         (cleanup_block_load_pc): Use count_one_bits.
4056         (arm_copy_block_xfer): Use count_one_bits.
4057         (thumb2_copy_block_xfer): Use count_one_bits.
4058         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4059         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4060         (thumb_get_next_pcs_raw): Use count_one_bits.
4061         (arm_get_next_pcs_raw): Use count_one_bits_l.
4062         * arch/arm.c (bitcount): Remove.
4063         * arch/arm.h (bitcount): Remove.
4064
4065 2020-02-14  Tom Tromey  <tromey@adacore.com>
4066
4067         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4068         Update.
4069         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4070         * dwarf2/loc.c (call_site_find_chain_1): Return
4071         unique_xmalloc_ptr.
4072         (call_site_find_chain): Likewise.
4073
4074 2020-02-14  Richard Biener  <rguenther@suse.de>
4075
4076         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4077         on expression with division operators.
4078
4079 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4080
4081         * MAINTAINERS (Write After Approval): Adding myself.
4082
4083 2020-02-12  Tom Tromey  <tom@tromey.com>
4084
4085         * event-loop.c (event_data, gdb_event, event_handler_func):
4086         Remove.
4087
4088 2020-02-12  Tom Tromey  <tom@tromey.com>
4089
4090         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4091         (dwarf2_frame_objfile_data): Add comment.
4092         (find_comp_unit, set_comp_unit): New functions.
4093         (dwarf2_frame_find_fde): Use find_comp_unit.
4094         (dwarf2_build_frame_info): Use set_comp_unit.
4095
4096 2020-02-12  Tom Tromey  <tom@tromey.com>
4097
4098         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4099         (comp_unit): Don't initialize objfile.
4100         (execute_cfa_program): Add text_offset parameter.
4101         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4102         (dwarf2_frame_cache): Update.
4103         (dwarf2_build_frame_info): Don't set "objfile" member.
4104
4105 2020-02-12  Tom Tromey  <tom@tromey.com>
4106
4107         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4108         (decode_frame_entry): Likewise.
4109         (dwarf2_build_frame_info): Update.
4110
4111 2020-02-12  Tom Tromey  <tom@tromey.com>
4112
4113         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4114         (decode_frame_entry_1): Use the comp_unit obstack.
4115
4116 2020-02-12  Tom Tromey  <tom@tromey.com>
4117
4118         * dwarf2/frame.c (struct comp_unit): Add initializers and
4119         constructor.
4120         (dwarf2_frame_objfile_data): Store a comp_unit.
4121         (dwarf2_frame_find_fde): Update.
4122         (dwarf2_build_frame_info): Use "new".
4123
4124 2020-02-12  Tom Tromey  <tom@tromey.com>
4125
4126         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4127         (dwarf2_fde_table): Typedef for std::vector.
4128         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4129         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4130         (decode_frame_entry): Update.
4131         (dwarf2_build_frame_info): Use "new".
4132
4133 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4134
4135         * arm-tdep.c (arm_gdbarch_init): Update.
4136         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4137         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4138         have_neon, is_m>: Change to bool.
4139
4140 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4141
4142         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4143
4144 2020-02-12  Tom Tromey  <tom@tromey.com>
4145
4146         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4147
4148 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4149
4150         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4151         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4152
4153 2020-02-11  Tom Tromey  <tom@tromey.com>
4154
4155         * psymtab.h: Update comment.
4156
4157 2020-02-11  Tom Tromey  <tom@tromey.com>
4158
4159         * gdb_obstack.h (struct auto_obstack): Use
4160         DISABLE_COPY_AND_ASSIGN.
4161
4162 2020-02-11  Tom Tromey  <tom@tromey.com>
4163
4164         * dwarf2/frame.h (struct objfile): Don't forward declare.
4165
4166 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4167
4168         * cris-tdep.c (cris_supply_gregset): Change signature to match
4169         what struct regset expects.
4170         (cris_regset): New struct.
4171         (fetch_core_registers): Remove.
4172         (cris_iterate_over_regset_sections): New function.
4173         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4174         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4175
4176 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4177
4178         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4179         registers.
4180
4181 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4182
4183         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4184
4185 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4186
4187         * configure: Re-generate.
4188
4189 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4190
4191         * configure: Re-generate.
4192
4193 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4194
4195         * acinclude: Update warning.m4 path.
4196         * warning.m4: Move to gdbsupport.
4197
4198 2020-02-11  Tom Tromey  <tromey@adacore.com>
4199
4200         * remote.c (remote_console_output): Update.
4201         * printcmd.c (printf_command): Update.
4202         * event-loop.c (gdb_wait_for_event): Update.
4203         * linux-nat.c (sigchld_handler): Update.
4204         * remote-sim.c (gdb_os_write_stdout): Update.
4205         (gdb_os_flush_stdout): Update.
4206         (gdb_os_flush_stderr): Update.
4207         (gdb_os_write_stderr): Update.
4208         * exceptions.c (print_exception): Update.
4209         * remote-fileio.c (remote_fileio_func_read): Update.
4210         (remote_fileio_func_write): Update.
4211         * tui/tui.c (tui_enable): Update.
4212         * tui/tui-interp.c (tui_interp::init): Update.
4213         * utils.c (init_page_info): Update.
4214         (putchar_unfiltered, fputc_unfiltered): Update.
4215         (gdb_flush): Update.
4216         (emit_style_escape): Update.
4217         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4218         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4219         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4220         (stderr_file::write): Update.
4221         (stderr_file::puts): Update.
4222         * ui-file.h (ui_file_isatty, ui_file_write)
4223         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4224         (ui_file_puts): Don't declare.
4225
4226 2020-02-10  Tom de Vries  <tdevries@suse.de>
4227
4228         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4229         sentinel to char *.
4230
4231 2020-02-09  Tom de Vries  <tdevries@suse.de>
4232
4233         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4234         filename if it matches "<artificial>".
4235
4236 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4237
4238         * windows-tdep.c (struct enum_value_name): New struct.
4239         (create_enum): New function.
4240         (windows_get_siginfo_type): Create and use enum types.
4241
4242 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4243
4244         * NEWS: Mention $_siginfo support for Windows.
4245         * windows-nat.c (handle_exception): Set siginfo_er.
4246         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4247         (windows_xfer_siginfo): New function.
4248         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4249         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4250         (init_windows_gdbarch_data): New function.
4251         (get_windows_gdbarch_data): New function.
4252         (windows_get_siginfo_type): New function.
4253         (windows_init_abi): Register windows_get_siginfo_type.
4254         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4255
4256 2020-02-08  Tom Tromey  <tom@tromey.com>
4257
4258         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4259         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4260         <keep>: Declare method.
4261         <m_keep>: Remove member.
4262         <~cutu_reader>: Remove.
4263         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4264         (cutu_reader::cutu_reader): Update.
4265         (cutu_reader::keep): Rename from ~cutu_reader.
4266         (process_psymtab_comp_unit, build_type_psymtabs_1)
4267         (process_skeletonless_type_unit, load_partial_comp_unit)
4268         (load_full_comp_unit, dwarf2_read_addr_index)
4269         (read_signatured_type): Update.
4270
4271 2020-02-08  Tom Tromey  <tom@tromey.com>
4272
4273         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4274         "want_partial_unit" parameter.
4275         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4276         Inline check for DW_TAG_partial_unit.
4277         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4278
4279 2020-02-08  Tom Tromey  <tom@tromey.com>
4280
4281         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4282         read.c.
4283         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4284         read.c.
4285
4286 2020-02-08  Tom Tromey  <tom@tromey.com>
4287
4288         * dwarf2/read.c (read_address): Move to comp-unit.c.
4289         (dwarf2_rnglists_process, dwarf2_ranges_process)
4290         (read_attribute_value, dwarf_decode_lines_1)
4291         (var_decode_location, decode_locdesc): Update.
4292         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4293         read.c.  Remove "cu" parameter.
4294         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4295         method.
4296
4297 2020-02-08  Tom Tromey  <tom@tromey.com>
4298
4299         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4300         (read_indirect_line_string): Update.
4301         * dwarf2/comp-unit.c (read_offset): Remove.
4302         (read_comp_unit_head): Update.
4303         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4304         method.
4305         (read_offset): Don't declare.
4306
4307 2020-02-08  Tom Tromey  <tom@tromey.com>
4308
4309         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4310         * dwarf2/read.c (struct comp_unit_head): Move to
4311         dwarf2/comp-unit.h.
4312         (enum class rcuh_kind): Move to comp-unit.h.
4313         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4314         (read_comp_unit_head, error_check_comp_unit_head)
4315         (read_and_check_comp_unit_head): Move to comp-unit.c.
4316         (read_offset, dwarf_unit_type_name): Likewise.
4317         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4318         (cutu_reader::cutu_reader, read_call_site_scope)
4319         (find_partial_die, follow_die_offset): Update.
4320         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4321
4322 2020-02-08  Tom Tromey  <tom@tromey.com>
4323
4324         * dwarf2/read.c (read_offset_1): Move to leb.c.
4325         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4326         (dwarf_decode_macro_bytes): Update.
4327         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4328         * dwarf2/leb.h (read_offset): Declare.
4329
4330 2020-02-08  Tom Tromey  <tom@tromey.com>
4331
4332         * dwarf2/read.c (dwarf2_section_size): Remove.
4333         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4334         Update.
4335         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4336
4337 2020-02-08  Tom Tromey  <tom@tromey.com>
4338
4339         * dwarf2/read.c (read_initial_length): Move to leb.c.
4340         * dwarf2/leb.h (read_initial_length): Declare.
4341         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4342         handle_nonstd parameter.
4343         * dwarf2/frame.c (read_initial_length): Remove.
4344         (decode_frame_entry_1): Update.
4345
4346 2020-02-08  Tom Tromey  <tom@tromey.com>
4347
4348         * dwarf2/loc.c (dwarf2_find_location_expression)
4349         (dwarf_evaluate_loc_desc::get_tls_address)
4350         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4351         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4352         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4353         (dwarf2_compile_property_to_c)
4354         (dwarf2_loc_desc_get_symbol_read_needs)
4355         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4356         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4357         (loclist_describe_location, loclist_tracepoint_var_ref)
4358         (loclist_generate_c_location): Update.
4359         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4360         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4361         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4362         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4363         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4364         (dwarf2_per_cu_data::addr_size)
4365         (dwarf2_per_cu_data::ref_addr_size)
4366         (dwarf2_per_cu_data::text_offset)
4367         (dwarf2_per_cu_data::addr_type): Now methods.
4368         (per_cu_header_read_in): Make per_cu "const".
4369         (dwarf2_version): Remove.
4370         (dwarf2_per_cu_data::int_type): Now a method.
4371         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4372         (set_die_type, read_array_type, read_subrange_index_type)
4373         (read_tag_string_type, read_subrange_type): Update.
4374         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4375         offset_size, ref_addr_size, text_offset, addr_type, version,
4376         objfile, int_type, addr_sized_int_type>: Declare methods.
4377
4378 2020-02-08  Tom Tromey  <tom@tromey.com>
4379
4380         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4381         Move earlier.
4382
4383 2020-02-08  Tom Tromey  <tom@tromey.com>
4384
4385         * dwarf2/read.h (dwarf_line_debug): Declare.
4386         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4387         * dwarf2/read.c: Move line_header code to new files.
4388         (dwarf_line_debug): No longer static.
4389         * dwarf2/line-header.c: New file.
4390         * dwarf2/line-header.h: New file.
4391
4392 2020-02-08  Tom Tromey  <tom@tromey.com>
4393
4394         * dwarf2/read.c (struct line_header) <file_full_name,
4395         file_file_name>: Return unique_xmalloc_ptr.
4396         (line_header::file_file_name): Update.
4397         (line_header::file_full_name): Update.
4398         (dw2_get_file_names_reader): Update.
4399         (macro_start_file): Update.
4400
4401 2020-02-08  Tom Tromey  <tom@tromey.com>
4402
4403         * dwarf2/read.c (struct line_header) <file_full_name,
4404         file_file_name>: Declare methods.
4405         (dw2_get_file_names_reader): Update.
4406         (file_file_name): Now a method.
4407         (file_full_name): Likewise.
4408         (macro_start_file): Update.
4409
4410 2020-02-08  Tom Tromey  <tom@tromey.com>
4411
4412         * dwarf2/read.c (dwarf_always_disassemble)
4413         (show_dwarf_always_disassemble): Move to loc.c.
4414         (_initialize_dwarf2_read): Move "always-disassemble" registration
4415         to loc.c.
4416         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4417         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4418         static.
4419         (show_dwarf_always_disassemble): Move from read.c.
4420         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4421
4422 2020-02-08  Tom Tromey  <tom@tromey.com>
4423
4424         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4425         (create_quick_file_names_table): Return htab_up.
4426         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4427         Update.
4428         * dwarf2/read.h (struct dwarf2_per_objfile)
4429         <quick_file_names_table>: Now htab_up.
4430
4431 2020-02-08  Tom Tromey  <tom@tromey.com>
4432
4433         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4434
4435 2020-02-08  Tom Tromey  <tom@tromey.com>
4436
4437         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4438         Rewrite.
4439         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4440         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4441         (abbrev_table::abbrev_table): No longer inline.
4442         (ABBREV_HASH_SIZE): Remove.
4443         (abbrev_table::m_abbrevs): Now an htab_up.
4444
4445 2020-02-08  Tom Tromey  <tom@tromey.com>
4446
4447         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4448         (cutu_reader): Update.
4449         (build_type_psymtabs_1): Update.
4450         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4451         (abbrev_table::alloc_abbrev): Update.
4452         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4453         (abbrev_table::read): New static method, renamed from
4454         abbrev_table_read_table.
4455         (abbrev_table::alloc_abbrev)
4456         (abbrev_table::add_abbrev): Now private.
4457         (abbrev_table::abbrev_table): Now private.
4458         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4459
4460 2020-02-08  Tom Tromey  <tom@tromey.com>
4461
4462         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4463         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4464         htab_up.
4465
4466 2020-02-08  Tom Tromey  <tom@tromey.com>
4467
4468         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4469         htab_up.
4470         (lookup_dwo_unit_in_dwp): Update.
4471         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4472         on obstack.
4473
4474 2020-02-08  Tom Tromey  <tom@tromey.com>
4475
4476         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4477         obstack.
4478
4479 2020-02-08  Tom Tromey  <tom@tromey.com>
4480
4481         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4482         line_header_hash.
4483         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4484         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4485         Change type to htab_up.
4486
4487 2020-02-08  Tom Tromey  <tom@tromey.com>
4488
4489         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4490         htab_up.  Don't allocate on obstack.
4491         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4492         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4493         Change type to htab_up.
4494
4495 2020-02-08  Tom Tromey  <tom@tromey.com>
4496
4497         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4498         Change type to htab_up.
4499         * dwarf2/read.c (create_signatured_type_table_from_index)
4500         (create_signatured_type_table_from_debug_names)
4501         (create_all_type_units, add_type_unit)
4502         (lookup_dwo_signatured_type, lookup_signatured_type)
4503         (process_skeletonless_type_unit): Update.
4504         (create_debug_type_hash_table, create_debug_types_hash_table):
4505         Change type of types_htab.
4506         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4507         htab_up.  Don't allocate on obstack.
4508         (create_cus_hash_table): Change type of cus_htab parameter.
4509         (struct dwo_file) <cus, tus>: Now htab_up.
4510         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4511         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4512         (queue_and_load_all_dwo_tus): Update.
4513         * dwarf2/index-write.c (write_gdbindex): Update.
4514         (write_debug_names): Update.
4515
4516 2020-02-08  Tom Tromey  <tom@tromey.com>
4517
4518         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4519         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4520         destructor.
4521         (struct dwarf2_per_objfile) <queue>: New member.
4522         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4523         dwarf2/read.h.
4524         (dwarf2_queue, dwarf2_queue_tail): Remove.
4525         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4526         DISABLE_COPY_AND_ASSIGN.
4527         <m_per_objfile>: New member.
4528         <~dwarf2_queue_guard>: Rewrite.
4529         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4530         Update.
4531         (~dwarf2_queue_item): New.
4532
4533 2020-02-08  Tom Tromey  <tom@tromey.com>
4534
4535         * dwarf2/read.c (struct die_info) <has_children>: New member.
4536         (dw2_get_file_names_reader): Remove has_children.
4537         (dw2_get_file_names): Update.
4538         (read_cutu_die_from_dwo): Remove has_children.
4539         (cutu_reader::init_tu_and_read_dwo_dies)
4540         (cutu_reader::cutu_reader): Update.
4541         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4542         Remove has_children.
4543         (build_type_psymtabs_1, process_skeletonless_type_unit)
4544         (load_partial_comp_unit, load_full_comp_unit): Update.
4545         (create_dwo_cu_reader): Remove has_children.
4546         (create_cus_hash_table, read_die_and_children): Update.
4547         (read_full_die_1,read_full_die): Remove has_children.
4548         (read_signatured_type): Update.
4549         (class cutu_reader) <has_children>: Remove.
4550
4551 2020-02-08  Tom Tromey  <tom@tromey.com>
4552
4553         * dwarf2/expr.c: Rename from dwarf2expr.c.
4554         * dwarf2/expr.h: Rename from dwarf2expr.h.
4555         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4556         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4557         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4558         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4559         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4560         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4561         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4562         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4563         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4564         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4565         * dwarf2/loc.c: Rename from dwarf2loc.c.
4566         * dwarf2/loc.h: Rename from dwarf2loc.h.
4567         * dwarf2/read.c: Rename from dwarf2read.c.
4568         * dwarf2/read.h: Rename from dwarf2read.h.
4569         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4570         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4571         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4572         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4573         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4574         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4575         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4576         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4577         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4578         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4579         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4580         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4581         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4582         Update.
4583         * Makefile.in (COMMON_SFILES): Update.
4584         (HFILES_NO_SRCDIR): Update.
4585
4586 2020-02-08  Tom Tromey  <tom@tromey.com>
4587
4588         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4589         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4590
4591 2020-02-08  Tom Tromey  <tom@tromey.com>
4592
4593         * dwarf2read.h (struct die_info): Don't declare.
4594
4595 2020-02-08  Tom Tromey  <tom@tromey.com>
4596
4597         * dwarf2read.h (die_info_ptr): Remove typedef.
4598
4599 2020-02-08  Tom Tromey  <tom@tromey.com>
4600
4601         * dwarf2read.c (read_call_site_scope)
4602         (handle_data_member_location, dwarf2_add_member_fn)
4603         (mark_common_block_symbol_computed, read_common_block)
4604         (attr_to_dynamic_prop, partial_die_info::read)
4605         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4606         (dwarf2_symbol_mark_computed, set_die_type): Update.
4607         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4608         method.
4609         (attr_form_is_block): Don't declare.
4610         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4611
4612 2020-02-08  Tom Tromey  <tom@tromey.com>
4613
4614         * dwarf2read.c (dwarf2_find_base_address, )
4615         (read_call_site_scope, rust_containing_type)
4616         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4617         (handle_data_member_location, dwarf2_add_member_fn)
4618         (get_alignment, read_structure_type, process_structure_scope)
4619         (mark_common_block_symbol_computed, read_common_block)
4620         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4621         (partial_die_info::read, read_attribute_value, new_symbol)
4622         (lookup_die_type, dwarf2_get_ref_die_offset)
4623         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4624         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4625         (dwarf2_symbol_mark_computed): Update.
4626         * dwarf2/attribute.h (struct attribute) <value_as_address,
4627         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4628         methods.
4629         (value_as_address, attr_form_is_section_offset)
4630         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4631         * dwarf2/attribute.c (attribute::value_as_address)
4632         (attribute::form_is_section_offset, attribute::form_is_constant)
4633         (attribute::form_is_ref): Now methods.
4634
4635 2020-02-08  Tom Tromey  <tom@tromey.com>
4636
4637         * dwarf2read.c (struct attribute, DW_STRING)
4638         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4639         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4640         (attr_form_is_block, attr_form_is_section_offset)
4641         (attr_form_is_constant, attr_form_is_ref): Move.
4642         * dwarf2/attribute.h: New file.
4643         * dwarf2/attribute.c: New file, from dwarf2read.c.
4644         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4645
4646 2020-02-08  Tom Tromey  <tom@tromey.com>
4647
4648         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4649         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4650         Move.
4651         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4652         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4653         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4654         abbrev.c.
4655         * dwarf2/abbrev.h: New file.
4656         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4657         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4658
4659 2020-02-08  Tom Tromey  <tom@tromey.com>
4660
4661         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4662         (dwarf2_section_size, dwarf2_get_section_info)
4663         (create_signatured_type_table_from_debug_names)
4664         (create_addrmap_from_aranges, read_debug_names_from_section)
4665         (get_gdb_index_contents_from_section, read_comp_unit_head)
4666         (error_check_comp_unit_head, read_abbrev_offset)
4667         (create_debug_type_hash_table, init_cu_die_reader)
4668         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4669         (read_comp_units_from_section, create_cus_hash_table)
4670         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4671         (create_dwp_v2_section, dwarf2_rnglists_process)
4672         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4673         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4674         (read_indirect_string_from_dwz, read_addr_index_1)
4675         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4676         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4677         (fill_in_loclist_baton): Update.
4678         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4679         get_containing_section, get_bfd_owner, get_bfd_section,
4680         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4681         (dwarf2_read_section, get_section_name, get_section_file_name)
4682         (get_containing_section, get_section_bfd_owner)
4683         (get_section_bfd_section, get_section_name, get_section_file_name)
4684         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4685         declare.
4686         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4687         (dwarf2_section_info::get_bfd_owner)
4688         (dwarf2_section_info::get_bfd_section)
4689         (dwarf2_section_info::get_name)
4690         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4691         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4692         (dwarf2_section_info::read): Now methods.
4693         * dwarf-index-write.c (class debug_names): Update.
4694
4695 2020-02-08  Tom Tromey  <tom@tromey.com>
4696
4697         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4698         Move to dwarf2/section.h.
4699         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4700         (get_section_bfd_section, get_section_name)
4701         (get_section_file_name, get_section_id, get_section_flags)
4702         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4703         dwarf2/section.c.
4704         * dwarf2/section.h: New file.
4705         * dwarf2/section.c: New file, from dwarf2read.c.
4706         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4707
4708 2020-02-08  Tom Tromey  <tom@tromey.com>
4709
4710         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4711         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4712         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4713         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4714         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4715         * dwarf2/leb.h: New file, from dwarf2read.c.
4716         * dwarf2/leb.c: New file, from dwarf2read.c.
4717         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4718         Remove.
4719         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4720         (COMMON_SFILES): Add dwarf2/leb.c.
4721
4722 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4723
4724         GDB 9.1 released.
4725
4726 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4727
4728         PR gdb/25190:
4729         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4730         * gdb/remote.c (remote_console_output): Update.
4731         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4732         (ui_file_puts): ...this.
4733         * gdb/ui-file.h (ui_file_puts): Add declaration.
4734         * gdb/utils.c (emit_style_escape): Update.
4735         (flush_wrap_buffer): Update.
4736         (fputs_maybe_filtered): Update.
4737         (fputs_unfiltered): Add function.
4738
4739 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4740
4741         * gdb/event-loop.c (gdb_wait_for_event): Update.
4742         * gdb/printcmd.c (printf_command): Update.
4743         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4744         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4745         (gdb_os_flush_stderr): Update.
4746         * gdb/remote.c (remote_console_output): Update.
4747         * gdb/ui-file.c (gdb_flush): Rename to...
4748         (ui_file_flush): ...this.
4749         (stderr_file::write): Update.
4750         (stderr_file::puts): Update.
4751         * gdb/ui-file.h (gdb_flush): Rename to...
4752         (ui_file_flush): ...this.
4753         * gdb/utils.c (gdb_flush): Add function.
4754         * gdb/utils.h (gdb_flush): Add declaration.
4755
4756 2020-02-07  Tom Tromey  <tromey@adacore.com>
4757
4758         PR breakpoints/24915:
4759         * source.c (find_and_open_source): Do not check basenames_may_differ.
4760
4761 2020-02-07  Tom Tromey  <tom@tromey.com>
4762
4763         * README: Update gdbserver documentation.
4764         * gdbserver: Move to top level.
4765         * configure.tgt (build_gdbserver): Remove.
4766         * configure.ac: Remove --enable-gdbserver.
4767         * configure: Rebuild.
4768         * Makefile.in (distclean): Don't mention gdbserver.
4769
4770 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4771
4772         * source-cache.c (source_cache::ensure): Surround
4773         get_plain_source_lines with a try/catch.
4774         (source_cache::get_line_charpos): Get rid of try/catch
4775         and only check for the return value of "ensure".
4776         * tui/tui-source.c (tui_source_window::set_contents):
4777         Simplify "nlines" calculation.
4778
4779 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4780
4781         * MAINTAINERS (Write After Approval): Add myself.
4782
4783 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4784
4785         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4786         function call.
4787
4788 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4789
4790         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4791
4792 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4793
4794         * nat/riscv-linux-tdesc.h: New file.
4795         * nat/riscv-linux-tdesc.c: New file, taking code from...
4796         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4797         ... here.
4798         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4799         NATDEPFILES.
4800
4801 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4804         we don't set the fake simulator ptid to the null_ptid.
4805
4806 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4807
4808         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4809         * gdbthread.h (class thread_info) <resumed>: Likewise.
4810         * infrun.c (resume_1): Likewise.
4811         (proceed): Likewise.
4812         (infrun_thread_stop_requested): Likewise.
4813         (stop_all_threads): Likewise.
4814         (handle_inferior_event): Likewise.
4815         (restart_threads): Likewise.
4816         (finish_step_over): Likewise.
4817         (keep_going_stepped_thread): Likewise.
4818         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4819         (linux_handle_extended_wait): Likewise.
4820         * record-btrace.c (get_thread_current_frame_id): Likewise.
4821         * record-full.c (record_full_wait_1): Likewise.
4822         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4823         * target.c (target_resume): Likewise.
4824         * thread.c (set_running_thread): Likewise.
4825
4826 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4827
4828         * f-valprint.c (f77_print_array_1): Changed datatype of index
4829         variable to LONGEST from int to enable it to contain bound
4830         values correctly.
4831
4832 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4833
4834         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4835         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4836         offsets according to FLEN determined.
4837         (riscv_linux_nat_target::read_description): Determine FLEN
4838         dynamically.
4839         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4840         according to FLEN determined.
4841         (riscv_linux_nat_target::store_registers): Likewise.
4842
4843 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4844
4845         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4846         when reg->group is empty and reggroup is not.
4847
4848 2020-01-31  Tom Tromey  <tromey@adacore.com>
4849
4850         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4851         Call beneath target's mourn_inferior after unpushing.
4852
4853 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         PR tui/9765
4856         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4857         have enough lines to fill the screen, still return the lowest
4858         address we found.
4859
4860 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4863         '-', '<', and '>' commands.
4864
4865 2020-01-29  Pedro Alves  <palves@redhat.com>
4866             Sergio Durigan Junior  <sergiodj@redhat.com>
4867
4868         * infcmd.c (construct_inferior_arguments): Assert that
4869         'argc' is greater than 0.
4870
4871 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4872
4873         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4874         (BRK_INSN_MASK): Define to 0xd4200000.
4875         (aarch64_program_breakpoint_here_p): New function.
4876         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4877         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4878         breakpoint.c.
4879         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4880         breakpoint.h
4881         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4882         call gdbarch_program_breakpoint_here_p.
4883         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4884         default_program_breakpoint_here_p, changed return type to bool and
4885         simplified.
4886         * breakpoint.h (program_breakpoint_here): Moved prototype to
4887         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4888         return type to bool.
4889         * gdbarch.c: Regenerate.
4890         * gdbarch.h: Regenerate.
4891         * gdbarch.sh (program_breakpoint_here_p): New method.
4892         * infrun.c (handle_signal_stop): Call
4893         gdbarch_program_breakpoint_here_p.
4894
4895 2020-01-26  Tom Tromey  <tom@tromey.com>
4896
4897         * ctfread.c (struct ctf_fp_info): Reindent.
4898         (_initialize_ctfread): Remove.
4899
4900 2020-01-26  Tom Tromey  <tom@tromey.com>
4901
4902         * psymtab.c (partial_map_expand_apply)
4903         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4904         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4905         (psym_print_stats, psym_expand_symtabs_for_function)
4906         (psym_map_symbol_filenames, psym_map_matching_symbols)
4907         (psym_expand_symtabs_matching)
4908         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4909         (maintenance_check_psymtabs): Use new methods.
4910         * psympriv.h (struct partial_symtab) <readin_p,
4911         get_compunit_symtab>: New methods.
4912         <readin, compunit_symtab>: Remove members.
4913         (struct standard_psymtab): New.
4914         (struct legacy_psymtab): Derive from standard_psymtab.
4915         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4916         standard_psymtab.
4917         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4918
4919 2020-01-26  Tom Tromey  <tom@tromey.com>
4920
4921         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4922         read_dependencies.  Add assert.
4923         * psymtab.c (partial_symtab::read_dependencies): New method.
4924         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4925         method.
4926         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4927         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4928         read_dependencies.
4929         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4930         Add assert.
4931
4932 2020-01-26  Tom Tromey  <tom@tromey.com>
4933
4934         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4935         Call expand_psymtab.
4936         (xcoff_read_symtab): Call expand_psymtab.
4937         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4938         legacy_expand_psymtab.
4939         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4940         method.
4941         (struct legacy_psymtab) <expand_psymtab>: Implement.
4942         <legacy_expand_psymtab>: New member.
4943         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4944         (parse_partial_symbols): Set legacy_expand_psymtab.
4945         (psymtab_to_symtab_1): Change argument order.  Call
4946         expand_psymtab.
4947         (new_psymtab): Set legacy_expand_psymtab.
4948         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4949         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4950         expand_psymtab.
4951         (dwarf2_psymtab::expand_psymtab): Rename from
4952         psymtab_to_symtab_1.  Call expand_psymtab.
4953         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4954         (dbx_end_psymtab): Likewise.
4955         (dbx_psymtab_to_symtab_1): Change argument order. Call
4956         expand_psymtab.
4957         (dbx_read_symtab): Call expand_psymtab.
4958         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4959         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4960         (ctf_psymtab::read_symtab): Call expand_psymtab.
4961
4962 2020-01-26  Tom Tromey  <tom@tromey.com>
4963
4964         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4965         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4966         messages.
4967         * mdebugread.c (mdebug_read_symtab): Remove prints.
4968         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4969         assert.
4970         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4971
4972 2020-01-26  Tom Tromey  <tom@tromey.com>
4973
4974         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4975         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4976         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4977         legacy_symtab.
4978         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4979         * psymtab.c (psymtab_to_symtab): Call method.
4980         (dump_psymtab): Update.
4981         * psympriv.h (struct partial_symtab): Add virtual destructor.
4982         <read_symtab>: New method.
4983         (struct legacy_symtab): New.
4984         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4985         (struct pst_map) <pst>: Now a legacy_psymtab.
4986         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4987         (new_psymtab): Use legacy_psymtab.
4988         * dwarf2read.h (struct dwarf2_psymtab): New.
4989         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4990         * dwarf2read.c (dwarf2_create_include_psymtab)
4991         (dwarf2_build_include_psymtabs, create_type_unit_group)
4992         (create_partial_symtab, process_psymtab_comp_unit_reader)
4993         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4994         (set_partial_user): Use dwarf2_psymtab.
4995         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4996         (psymtab_to_symtab_1, process_full_comp_unit)
4997         (process_full_type_unit, dwarf2_ranges_read)
4998         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4999         (dwarf_decode_lines): Use dwarf2_psymtab.
5000         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5001         (add_address_entry_worker, write_one_signatured_type)
5002         (recursively_count_psymbols, recursively_write_psymbols)
5003         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5004         (write_debug_names): Likewise.
5005         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5006         <pst>: Now a legacy_psymtab.
5007         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5008         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5009         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5010         * ctfread.c (struct ctf_psymtab): New.
5011         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5012         ctf_psymtab.
5013         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5014         (create_partial_symtab): Return a ctf_psymtab.
5015         (scan_partial_symbols): Update.
5016
5017 2020-01-26  Tom Tromey  <tom@tromey.com>
5018
5019         * xcoffread.c (xcoff_start_psymtab): Use new.
5020         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5021         renamed from start_psymtab_common.
5022         * psympriv.h (struct partial_symtab): Add new constructor.
5023         (start_psymtab_common): Don't declare.
5024         * mdebugread.c (parse_partial_symbols): Use new.
5025         * dwarf2read.c (create_partial_symtab): Use new.
5026         * dbxread.c (start_psymtab): Use new.
5027         * ctfread.c (create_partial_symtab): Use new.
5028
5029 2020-01-26  Tom Tromey  <tom@tromey.com>
5030
5031         * xcoffread.c (xcoff_end_psymtab): Use new.
5032         * psymtab.c (start_psymtab_common): Use new.
5033         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5034         Update.
5035         * psympriv.h (struct partial_symtab): Add parameters to
5036         constructor.  Don't inline.
5037         (allocate_psymtab): Don't declare.
5038         * mdebugread.c (new_psymtab): Use new.
5039         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5040         * dbxread.c (dbx_end_psymtab): Use new.
5041
5042 2020-01-26  Tom Tromey  <tom@tromey.com>
5043
5044         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5045         allocate_psymtab.  Update documentation.
5046         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5047         allocate_psymtab.  Do not use new.
5048         (allocate_psymtab): Use new.  Update.
5049
5050 2020-01-26  Tom Tromey  <tom@tromey.com>
5051
5052         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5053         * psymtab.c (psym_print_stats): Update.
5054         * psympriv.h (struct partial_symtab) <readin,
5055         psymtabs_addrmap_supported, anonymous>: Now bool.
5056         * mdebugread.c (psymtab_to_symtab_1): Update.
5057         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5058         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5059         (process_full_comp_unit, process_full_type_unit): Update.
5060         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5061         * ctfread.c (psymtab_to_symtab): Update.
5062
5063 2020-01-26  Tom Tromey  <tom@tromey.com>
5064
5065         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5066         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5067         * psymtab.c (psymtab_storage): Delete psymtabs.
5068         (psymtab_storage::allocate_psymtab): Use new.
5069         (psymtab_storage::discard_psymtab): Use delete.
5070         * psympriv.h (struct partial_symtab): Add constructor and
5071         initializers.
5072
5073 2020-01-26  Tom Tromey  <tom@tromey.com>
5074
5075         * machoread.c: Do not include psympriv.h.
5076
5077 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5078
5079         * NEWS: Mention the new option and the set/show commands.
5080
5081 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5082
5083         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5084         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5085         (validate_exec_file): New variables, enums, functions.
5086         (exec_file_locate_attach, print_section_info): Style the filenames.
5087         (_initialize_exec): Install show_exec_file_mismatch_command and
5088          set_exec_file_mismatch_command.
5089         * gdbcore.h (validate_exec_file): Declare.
5090         * infcmd.c (attach_command): Call validate_exec_file.
5091         * remote.c ( remote_target::remote_add_inferior): Likewise.
5092
5093 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * frame.c (find_frame_sal): Move call to get_next_frame into more
5096         inner scope.
5097         * inline-frame.c (inilne_state) <inline_state>: Update argument
5098         types.
5099         (inilne_state) <skipped_symbol>: Rename to...
5100         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5101         (skip_inline_frames): Build vector of skipped symbols and use this
5102         to reate the inline_state.
5103         (inline_skipped_symbol): Add a comment and some assertions, fetch
5104         skipped symbol from the list.
5105
5106 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * buildsym.c (lte_is_less_than): Delete.
5109         (buildsym_compunit::end_symtab_with_blockvector): Create local
5110         lambda function to sort line table entries, and use
5111         std::stable_sort instead of std::sort.
5112         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5113         markers when looking for a previous line.
5114
5115 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * dwarf2read.c (lnp_state_machine::record_line): Include
5118         end_sequence parameter in debug print out.  Record the line if we
5119         are at an end_sequence marker even if it's not the start of a
5120         statement.
5121         * symmisc.c (maintenance_print_one_line_table): Print end of
5122         sequence markers with 'END' not '0'.
5123
5124 2020-01-24  Pedro Alves  <palves@redhat.com>
5125
5126         PR gdb/25410
5127         * thread.c (scoped_restore_current_thread::restore): Use
5128         switch_to_inferior_no_thread.
5129         * exec.c: Include "progspace-and-thread.h".
5130         (add_target_sections, remove_target_sections):
5131         scoped_restore_current_pspace_and_thread instead of
5132         scoped_restore_current_thread.
5133         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5134         and aspace to the inferior before calling clone_program_space.
5135         Remove stale comment.
5136
5137 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5138
5139         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5140         (arm_netbsd_nat_target::fetch_registers): ...this.
5141         (arm_nbsd_nat_target::store_registers): Rename to...
5142         (arm_netbsd_nat_target::store_registers): ...this.
5143
5144 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5145
5146         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5147         register_t.
5148
5149 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5150
5151         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5152         Update comment.
5153         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5154         Likewise.
5155         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5156         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5157         the correct replacement (iterate_over_regset_sections).
5158         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5159         Update comment.
5160
5161 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5162
5163         PR gdb/23718
5164         * gdb/python/python.c (execute_gdb_command): Call
5165         async_enable_stdin in catch block.
5166
5167 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5170         SWITCH_THRU_ALL_UIS.
5171
5172 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         PR tui/9765
5175         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5176         comment, add extra parameter, and update to store previous symbol
5177         when appropriate.
5178         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5179         add extra parameter.
5180         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5181         remove unneeded parameter, add try/catch around gdb_print_insn,
5182         rewrite to add items to asm_lines vector.
5183         (tui_find_backward_disassembly_start_address): New function.
5184         (tui_find_disassembly_address): Updated throughout.
5185         (tui_disasm_window::set_contents): Update for changes to
5186         tui_disassemble.
5187         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5188         number of lines to scroll.
5189
5190 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5191
5192         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5193         (SECT_OFF_DATA): Likewise.
5194         (SECT_OFF_RODATA): Likewise.
5195         (SECT_OFF_TEXT): Likewise.
5196         (SECT_OFF_BSS): Likewise.
5197         (struct objfile) <text_section_offset, data_section_offset>: New
5198         methods.
5199         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5200         objfile::text_section_offset.
5201         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5202         * coffread.c (coff_symtab_read): Likewise.
5203         (enter_linenos): Likewise.
5204         (process_coff_symbol): Likewise.
5205         * ctfread.c (get_objfile_text_range): Likewise.
5206         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5207         Use objfile::data_section_offset.
5208         * dwarf2-frame.c (execute_cfa_program): Use
5209         objfile::text_section_offset.
5210         (dwarf2_frame_find_fde): Likewise.
5211         * dwarf2read.c (create_addrmap_from_index): Likewise.
5212         (create_addrmap_from_aranges): Likewise.
5213         (dw2_find_pc_sect_compunit_symtab): Likewise.
5214         (process_psymtab_comp_unit_reader): Likewise.
5215         (add_partial_symbol): Likewise.
5216         (add_partial_subprogram): Likewise.
5217         (process_full_comp_unit): Likewise.
5218         (read_file_scope): Likewise.
5219         (read_func_scope): Likewise.
5220         (read_lexical_block_scope): Likewise.
5221         (read_call_site_scope): Likewise.
5222         (dwarf2_rnglists_process): Likewise.
5223         (dwarf2_ranges_process): Likewise.
5224         (dwarf2_ranges_read): Likewise.
5225         (dwarf_decode_lines_1): Likewise.
5226         (new_symbol): Likewise.
5227         (dwarf2_fetch_die_loc_sect_off): Likewise.
5228         (dwarf2_per_cu_text_offset): Likewise.
5229         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5230         * hppa-tdep.c (read_unwind_info): Likewise.
5231         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5232         * psympriv.h (struct partial_symtab): Likewise.
5233         * psymtab.c (find_pc_sect_psymtab): Likewise.
5234         * solib-svr4.c (enable_break): Likewise.
5235         * stap-probe.c (relocate_address): Use
5236         objfile::data_section_offset.
5237         * xcoffread.c (enter_line_range): Use
5238         objfile::text_section_offset.
5239         (read_xcoff_symtab): Likewise.
5240
5241 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5242
5243         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5244         declaration to narrower scopes.
5245
5246 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5247
5248         * darwin-nat.h (struct darwin_exception_msg, enum
5249         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5250         Move up.
5251         (class darwin_nat_target) <wait_1, check_new_threads,
5252         decode_exception_message, decode_message, stop_inferior,
5253         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5254         * darwin-nat.c (darwin_check_new_threads): Rename to...
5255         (darwin_nat_target::check_new_threads): ... this.
5256         (darwin_suspend_inferior_it): Remove.
5257         (darwin_decode_exception_message): Rename to...
5258         (darwin_nat_target::decode_exception_message): ... this.
5259         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5260         (darwin_decode_message): Rename to...
5261         (darwin_nat_target::decode_message): ... this.
5262         (cancel_breakpoint): Rename to...
5263         (darwin_nat_target::cancel_breakpoint): ... this.
5264         (darwin_wait): Rename to...
5265         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5266         instead of iterate_over_inferiors.
5267         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5268         (darwin_stop_inferior): Rename to...
5269         (darwin_nat_target::stop_inferior): ... this.
5270         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5271         (darwin_init_thread_list): Rename to...
5272         (darwin_nat_target::init_thread_list): ... this.
5273         (darwin_ptrace_him): Rename to...
5274         (darwin_nat_target::ptrace_him): ... this.
5275         (darwin_nat_target::create_inferior): Pass lambda function to
5276         fork_inferior.
5277         (darwin_nat_target::detach): Call stop_inferior instead of
5278         darwin_stop_inferior.
5279         * fork-inferior.h (fork_inferior): Change init_trace_fun
5280         parameter to gdb::function_view.
5281         * fork-inferior.c (fork_inferior): Likewise.
5282
5283 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5284
5285         * i386-cygwin-tdep.c (core_process_module_section): Update.
5286         * windows-nat.c (struct lm_info_windows): Add text_offset.
5287         (windows_xfer_shared_libraries): Update.
5288         * windows-tdep.c (windows_xfer_shared_library):
5289         Add text_offset_cached argument.
5290         * windows-tdep.h (windows_xfer_shared_library): Update.
5291
5292 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5293
5294         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5295
5296 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5297
5298         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5299         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5300         replace with range-based for.
5301         (gdbsim_interrupt_inferior): Remove.
5302         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5303         with a range-based for.  Inline code from
5304         gdbsim_interrupt_inferior.
5305
5306 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5307
5308         * infrun.c (proceed): Fix indentation.
5309
5310 2020-01-21  Tom Tromey  <tromey@adacore.com>
5311
5312         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5313         * python/python.c (python_extension_ops): Update.
5314         (gdbpy_colorize): New function.
5315         * python/lib/gdb/__init__.py (colorize): New function.
5316         * extension.h (ext_lang_colorize): Declare.
5317         * extension.c (ext_lang_colorize): New function.
5318         * extension-priv.h (struct extension_language_ops) <colorize>: New
5319         member.
5320         * cli/cli-style.c (_initialize_cli_style): Update help text.
5321
5322 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5323
5324         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5325         <cond>: Change type to bool.
5326         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5327         (aarch64_displaced_step_cb): Likewise.
5328         (aarch64_displaced_step_tb): Likewise.
5329
5330 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5331
5332         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5333         output.
5334
5335 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5336
5337         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5338         <pc_adjust>: Adjust the documentation.
5339         (aarch64_displaced_step_fixup): Check if PC really moved before
5340         adjusting it.
5341
5342 2020-01-19  Tom Tromey  <tom@tromey.com>
5343
5344         * disasm.c (~gdb_disassembler): New destructor.
5345         (gdb_buffered_insn_length): Call disassemble_free_target.
5346         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5347         DISABLE_COPY_AND_ASSIGN.
5348
5349 2020-01-19  Tom Tromey  <tom@tromey.com>
5350
5351         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5352         (die_reader_func_ftype): Remove.
5353         (cutu_reader): New class.
5354         (dw2_get_file_names_reader): Remove "data" parameter.
5355         (dw2_get_file_names): Use cutu_reader.
5356         (create_debug_type_hash_table): Update.
5357         (read_cutu_die_from_dwo): Update comment.
5358         (lookup_dwo_unit): Add dwo_name parameter.
5359         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5360         die_reader_func_ftype and data parameters.
5361         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5362         Remove die_reader_func_ftype and data parameters.
5363         (~cutu_reader): New; from init_cutu_and_read_dies.
5364         (cutu_reader::cutu_reader): Rename from
5365         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5366         and data parameters.
5367         (init_cutu_and_read_dies_simple): Remove.
5368         (struct process_psymtab_comp_unit_data): Remove.
5369         (process_psymtab_comp_unit_reader): Remove data parameter; add
5370         want_partial_unit and pretend_language parameters.
5371         (process_psymtab_comp_unit): Use cutu_reader.
5372         (build_type_psymtabs_reader): Remove data parameter.
5373         (build_type_psymtabs_1): Use cutu_reader.
5374         (process_skeletonless_type_unit): Likewise.
5375         (load_partial_comp_unit_reader): Remove.
5376         (load_partial_comp_unit): Use cutu_reader.
5377         (load_full_comp_unit_reader): Remove.
5378         (load_full_comp_unit): Use cutu_reader.
5379         (struct create_dwo_cu_data): Remove.
5380         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5381         dwo_unit parameters.
5382         (create_cus_hash_table): Use cutu_reader.
5383         (struct dwarf2_read_addr_index_data): Remove.
5384         (dwarf2_read_addr_index_reader): Remove.
5385         (dwarf2_read_addr_index): Use cutu_reader.
5386         (read_signatured_type_reader): Remove.
5387         (read_signatured_type): Use cutu_reader.
5388
5389 2020-01-19  Tom Tromey  <tom@tromey.com>
5390
5391         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5392         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5393         (tui_wrefresh): Declare.
5394         * tui/tui-wingeneral.c (suppress_output): New global.
5395         (tui_suppress_output, ~tui_suppress_output): New constructor and
5396         destructor.
5397         (tui_wrefresh): New function.
5398         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5399         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5400         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5401         method.
5402         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5403         tui_wrefresh.
5404         (tui_data_window::no_refresh): New method.
5405         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5406         (tui_reg_command): Use tui_suppress_output
5407         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5408         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5409         method.
5410         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5411
5412 2020-01-19  Tom Tromey  <tom@tromey.com>
5413
5414         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5415         Handle case where symtab is null.
5416
5417 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5418
5419         * linux-fork.c (one_fork_p): Simplify.
5420
5421 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * top.c (struct qt_args): Remove.
5424         (kill_or_detach): Change return type to void, replace `void *`
5425         parameter with a proper one.
5426         (print_inferior_quit_action):  Likewise.
5427         (quit_confirm): Use range-based for loop to iterate over inferiors.
5428         (quit_force): Likewise.
5429
5430 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5431
5432         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5433         `void *` parameter with proper parameters.
5434         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5435         (print_one_inferior): Change return type to void, replace `void *`
5436         parameter with proper parameters.
5437         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5438         inferiors.
5439         (get_other_inferior): Remove.
5440         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5441         inferiors.
5442
5443 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5444
5445         * mi/mi-interp.c (report_initial_inferior): Remove.
5446         (mi_interp::init): Use range-based for to iterate over inferiors.
5447
5448 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5449
5450         * python/py-inferior.c (build_inferior_list): Remove.
5451         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5452
5453 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5454
5455         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5456         (btrace_stitch_trace): Likewise.
5457         * charset.c (intermediate_encoding): Likewise (vaild).
5458         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5459         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5460         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5461
5462 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5463
5464         * windows-tdep.c (windows_get_tlb_type):
5465         Add rtl_user_process_parameters type.
5466
5467 2020-01-16  Pedro Alves  <palves@redhat.com>
5468             Norbert Lange  <nolange79@gmail.com>
5469
5470         PR build/24805
5471         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5472         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5473         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5474         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5475         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5476         (ps_plog): Redeclare exported functions with default visibility.
5477
5478 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5479
5480         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5481         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5482
5483 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5484
5485         * infcmd.c (post_create_inferior): Use get_thread_regcache
5486         instead of get_current_regcache.
5487
5488 2020-01-14  Tom Tromey  <tom@tromey.com>
5489
5490         PR symtab/12535:
5491         * python/python.c (gdbpy_decode_line): Treat empty string the same
5492         as no argument.
5493
5494 2020-01-14  Tom Tromey  <tom@tromey.com>
5495
5496         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5497
5498 2020-01-14  Tom Tromey  <tom@tromey.com>
5499
5500         * nat/linux-btrace.c: Don't include <config.h>.
5501         * nat/linux-ptrace.c: Don't include <config.h>.
5502         * nat/x86-linux-dregs.c: Don't include <config.h>.
5503
5504 2020-01-14  Tom Tromey  <tom@tromey.com>
5505
5506         * configure: Rebuild.
5507         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5508
5509 2020-01-14  Tom Tromey  <tom@tromey.com>
5510
5511         * nat/x86-linux-dregs.c: Include configh.h.
5512         * nat/linux-ptrace.c: Include configh.h.
5513         * nat/linux-btrace.c: Include configh.h.
5514         * defs.h: Include config.h, bfd.h.
5515         * configure.ac: Don't source common.host.
5516         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5517         * configure: Rebuild.
5518         * acinclude.m4: Update path.
5519         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5520         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5521         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5522         (CLIBS): Add LIBSUPPORT.
5523         (CDEPS): Likewise.
5524         (COMMON_SFILES): Remove gdbsupport files.
5525         (HFILES_NO_SRCDIR): Likewise.
5526         (stamp-version): Update path to create-version.sh.
5527         (ALLDEPFILES): Remove gdbsupport files.
5528
5529 2020-01-14  Tom Tromey  <tom@tromey.com>
5530
5531         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5532         USE_WIN32API when needed.
5533         * configure.ac (USE_WIN32API): Don't define.
5534         (WIN32LIBS): Use WIN32APILIBS.
5535         * configure: Rebuild.
5536
5537 2020-01-14  Tom Tromey  <tom@tromey.com>
5538
5539         * configure: Rebuild.
5540         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5541
5542 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5543
5544         * skip.c (skip_function_command): Make skip w/o arguments use the
5545         name of the inlined function if pc is inside any inlined function.
5546
5547 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5548
5549         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5550         * infrun.c (resume_1): Likewise.
5551         (handle_inferior_event): Remove stale comment.
5552         * linux-nat.c (linux_nat_target::resume): Update comments.
5553         (save_stop_reason): Likewise.
5554         (linux_nat_filter_event): Likewise.
5555         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5556
5557 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * elfread.c (record_minimal_symbol): Set section index to 0 for
5560         non-allocatable sections.
5561
5562
5563 2020-01-13  Ali Tamur <tamur@google.com>
5564
5565         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5566         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5567         to gdb::optional.  Update comments.
5568         (dwo_file): Update comments.
5569         (read_attribute): Update API to take an additional out parameter,
5570         need_reprocess.  This is used to mark attributes that need other
5571         attributes (e.g. str_offsets_base) for correct computation which may not
5572         have been read yet.
5573         (read_attribute_reprocess): New function declaration.
5574         (read_addr_index): Likewise.
5575         (read_dwo_str_index): Likewise.
5576         (read_stub_str_index): Likewise.
5577         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5578         (lookup_addr_base): New function definition.
5579         (lookup_ranges_base): Likewise.
5580         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5581         lookup_ranges_base.
5582         (init_cutu_and_read_dies): Update comments.
5583         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5584         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5585         Update comments.
5586         (init_cutu_and_read_dies_simple): Reflect API changes.
5587         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5588         (create_cus_hash_table): Change API to take parent compile unit.
5589         Reflect API changes.
5590         (open_and_init_dwo_file): Reflect API changes.
5591         (dwarf2_get_pc_bounds): Update comments.
5592         (dwarf2_record_block_ranges): Likewise.
5593         (read_full_die_1): Change implementation to reprocess attributes that
5594         need str_offsets_base and addr_base.
5595         (partial_die_info::read): Likewise.
5596         (read_attribute_reprocess): New function definition.
5597         (read_attribute_value): Change API to take an additional out parameter,
5598         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5599         when a non-dwo compile unit has index based attributes.
5600         (read_attribute): Reflect API changes.
5601         (read_addr_index_1): Reflect API changes.  Update comments.
5602         (dwarf2_read_addr_index_data): Reflect API changes.
5603         (dwarf2_read_addr_index): Likewise.
5604         (read_str_index): Change API and implementation.  This becomes a helper
5605         to be used by the new string index related methods.  Update error
5606         message and comments.
5607         (read_dwo_str_index): New function definition.
5608         (read_stub_str_index): Likewise.
5609         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5610         * symfile.h (dwarf2_debug_sections): Likewise.
5611         * xcoffread.c (dwarf2_debug_sections): Likewise.
5612
5613 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5614
5615         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5616         core_reg_sect type to gdb_byte *.
5617         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5618         * cris-tdep.c (fetch_core_registers): Likewise.
5619         * corelow.c (core_target::get_core_register_section): Change
5620         type of `contents` to gdb::byte_vector.
5621
5622 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5623
5624         * tui/tui-wingeneral.c (box_win): Position the title in the center
5625         of the border.
5626
5627 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5628
5629         * corelow.c (core_target::get_core_register_section): Use
5630           std::vector instead of alloca.
5631
5632 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5633
5634         * warning.m4: Add -Wmissing-declarations to build_warnings.
5635         * configure: Re-generate.
5636
5637 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5638
5639         * python/python.c (init__gdb_module): Add declaration.
5640
5641 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5642
5643         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5644         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5645         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5646         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5647         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5648         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5649         * ada-exp.y (_initialize_ada_exp): Add declaration.
5650         * ada-lang.c (_initialize_ada_language): Add declaration.
5651         * ada-tasks.c (_initialize_tasks): Add declaration.
5652         * agent.c (_initialize_agent): Add declaration.
5653         * aix-thread.c (_initialize_aix_thread): Add declaration.
5654         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5655         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5656         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5657         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5658         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5659         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5660         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5661         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5662         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5663         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5664         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5665         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5666         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5667         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5668         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5669         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5670         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5671         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5672         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5673         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5674         * annotate.c (_initialize_annotate): Add declaration.
5675         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5676         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5677         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5678         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5679         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5680         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5681         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5682         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5683         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5684         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5685         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5686         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5687         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5688         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5689         * auto-load.c (_initialize_auto_load): Add declaration.
5690         * auxv.c (_initialize_auxv): Add declaration.
5691         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5692         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5693         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5694         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5695         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5696         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5697         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5698         * breakpoint.c (_initialize_breakpoint): Add declaration.
5699         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5700         * btrace.c (_initialize_btrace): Add declaration.
5701         * charset.c (_initialize_charset): Add declaration.
5702         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5703         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5704         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5705         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5706         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5707         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5708         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5709         * coffread.c (_initialize_coffread): Add declaration.
5710         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5711         * compile/compile.c (_initialize_compile): Add declaration.
5712         * complaints.c (_initialize_complaints): Add declaration.
5713         * completer.c (_initialize_completer): Add declaration.
5714         * copying.c (_initialize_copying): Add declaration.
5715         * corefile.c (_initialize_core): Add declaration.
5716         * corelow.c (_initialize_corelow): Add declaration.
5717         * cp-abi.c (_initialize_cp_abi): Add declaration.
5718         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5719         * cp-support.c (_initialize_cp_support): Add declaration.
5720         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5721         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5722         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5723         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5724         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5725         * ctfread.c (_initialize_ctfread): Add declaration.
5726         * d-lang.c (_initialize_d_language): Add declaration.
5727         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5728         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5729         * dbxread.c (_initialize_dbxread): Add declaration.
5730         * dcache.c (_initialize_dcache): Add declaration.
5731         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5732         * disasm.c (_initialize_disasm): Add declaration.
5733         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5734         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5735         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5736         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5737         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5738         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5739         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5740         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5741         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5742         * elfread.c (_initialize_elfread): Add declaration.
5743         * exec.c (_initialize_exec): Add declaration.
5744         * extension.c (_initialize_extension): Add declaration.
5745         * f-lang.c (_initialize_f_language): Add declaration.
5746         * f-valprint.c (_initialize_f_valprint): Add declaration.
5747         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5748         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5749         * filesystem.c (_initialize_filesystem): Add declaration.
5750         * findcmd.c (_initialize_mem_search): Add declaration.
5751         * findvar.c (_initialize_findvar): Add declaration.
5752         * fork-child.c (_initialize_fork_child): Add declaration.
5753         * frame-base.c (_initialize_frame_base): Add declaration.
5754         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5755         * frame.c (_initialize_frame): Add declaration.
5756         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5757         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5758         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5759         * gcore.c (_initialize_gcore): Add declaration.
5760         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5761         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5762         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5763         * gdbarch.c (_initialize_gdbarch): Add declaration.
5764         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5765         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5766         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5767         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5768         * go-lang.c (_initialize_go_language): Add declaration.
5769         * go32-nat.c (_initialize_go32_nat): Add declaration.
5770         * guile/guile.c (_initialize_guile): Add declaration.
5771         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5772         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5773         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5774         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5775         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5776         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5777         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5778         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5779         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5780         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5781         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5782         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5783         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5784         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5785         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5786         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5787         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5788         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5789         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5790         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5791         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5792         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5793         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5794         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5795         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5796         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5797         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5798         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5799         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5800         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5801         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5802         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5803         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5804         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5805         * infcall.c (_initialize_infcall): Add declaration.
5806         * infcmd.c (_initialize_infcmd): Add declaration.
5807         * inflow.c (_initialize_inflow): Add declaration.
5808         * infrun.c (_initialize_infrun): Add declaration.
5809         * interps.c (_initialize_interpreter): Add declaration.
5810         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5811         * jit.c (_initialize_jit): Add declaration.
5812         * language.c (_initialize_language): Add declaration.
5813         * linux-fork.c (_initialize_linux_fork): Add declaration.
5814         * linux-nat.c (_initialize_linux_nat): Add declaration.
5815         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5816         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5817         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5818         * m2-lang.c (_initialize_m2_language): Add declaration.
5819         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5820         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5821         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5822         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5823         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5824         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5825         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5826         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5827         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5828         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5829         * machoread.c (_initialize_machoread): Add declaration.
5830         * macrocmd.c (_initialize_macrocmd): Add declaration.
5831         * macroscope.c (_initialize_macroscope): Add declaration.
5832         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5833         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5834         * maint.c (_initialize_maint_cmds): Add declaration.
5835         * mdebugread.c (_initialize_mdebugread): Add declaration.
5836         * memattr.c (_initialize_mem): Add declaration.
5837         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5838         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5839         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5840         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5841         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5842         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5843         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5844         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5845         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5846         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5847         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5848         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5849         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5850         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5851         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5852         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5853         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5854         * mipsread.c (_initialize_mipsread): Add declaration.
5855         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5856         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5857         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5858         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5859         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5860         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5861         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5862         * nto-procfs.c (_initialize_procfs): Add declaration.
5863         * objc-lang.c (_initialize_objc_language): Add declaration.
5864         * observable.c (_initialize_observer): Add declaration.
5865         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5866         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5867         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5868         * osabi.c (_initialize_gdb_osabi): Add declaration.
5869         * osdata.c (_initialize_osdata): Add declaration.
5870         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5871         * parse.c (_initialize_parse): Add declaration.
5872         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5873         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5874         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5875         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5876         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5877         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5878         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5879         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5880         * printcmd.c (_initialize_printcmd): Add declaration.
5881         * probe.c (_initialize_probe): Add declaration.
5882         * proc-api.c (_initialize_proc_api): Add declaration.
5883         * proc-events.c (_initialize_proc_events): Add declaration.
5884         * proc-service.c (_initialize_proc_service): Add declaration.
5885         * procfs.c (_initialize_procfs): Add declaration.
5886         * producer.c (_initialize_producer): Add declaration.
5887         * psymtab.c (_initialize_psymtab): Add declaration.
5888         * python/python.c (_initialize_python): Add declaration.
5889         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5890         * record-btrace.c (_initialize_record_btrace): Add declaration.
5891         * record-full.c (_initialize_record_full): Add declaration.
5892         * record.c (_initialize_record): Add declaration.
5893         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5894         * regcache.c (_initialize_regcache): Add declaration.
5895         * reggroups.c (_initialize_reggroup): Add declaration.
5896         * remote-notif.c (_initialize_notif): Add declaration.
5897         * remote-sim.c (_initialize_remote_sim): Add declaration.
5898         * remote.c (_initialize_remote): Add declaration.
5899         * reverse.c (_initialize_reverse): Add declaration.
5900         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5901         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5902         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5903         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5904         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5905         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5906         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5907         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5908         Add declaration.
5909         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5910         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5911         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5912         * rust-exp.y (_initialize_rust_exp): Add declaration.
5913         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5914         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5915         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5916         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5917         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5918         * score-tdep.c (_initialize_score_tdep): Add declaration.
5919         * ser-go32.c (_initialize_ser_dos): Add declaration.
5920         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5921         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5922         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5923         * ser-uds.c (_initialize_ser_socket): Add declaration.
5924         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5925         * serial.c (_initialize_serial): Add declaration.
5926         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5927         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5928         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5929         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5930         * skip.c (_initialize_step_skip): Add declaration.
5931         * sol-thread.c (_initialize_sol_thread): Add declaration.
5932         * solib-aix.c (_initialize_solib_aix): Add declaration.
5933         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5934         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5935         * solib-frv.c (_initialize_frv_solib): Add declaration.
5936         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5937         * solib-target.c (_initialize_solib_target): Add declaration.
5938         * solib.c (_initialize_solib): Add declaration.
5939         * source-cache.c (_initialize_source_cache): Add declaration.
5940         * source.c (_initialize_source): Add declaration.
5941         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5942         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5943         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5944         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5945         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5946         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5947         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5948         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5949         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5950         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5951         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5952         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5953         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5954         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5955         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5956         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5957         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5958         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5959         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5960         * stabsread.c (_initialize_stabsread): Add declaration.
5961         * stack.c (_initialize_stack): Add declaration.
5962         * stap-probe.c (_initialize_stap_probe): Add declaration.
5963         * std-regs.c (_initialize_frame_reg): Add declaration.
5964         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5965         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5966         * symfile.c (_initialize_symfile): Add declaration.
5967         * symmisc.c (_initialize_symmisc): Add declaration.
5968         * symtab.c (_initialize_symtab): Add declaration.
5969         * target.c (_initialize_target): Add declaration.
5970         * target-connection.c (_initialize_target_connection): Add
5971         declaration.
5972         * target-dcache.c (_initialize_target_dcache): Add declaration.
5973         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5974         * thread.c (_initialize_thread): Add declaration.
5975         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5976         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5977         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5978         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5979         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5980         * tracectf.c (_initialize_ctf): Add declaration.
5981         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5982         * tracefile.c (_initialize_tracefile): Add declaration.
5983         * tracepoint.c (_initialize_tracepoint): Add declaration.
5984         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5985         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5986         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5987         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5988         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5989         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5990         * tui/tui.c (_initialize_tui): Add declaration.
5991         * typeprint.c (_initialize_typeprint): Add declaration.
5992         * ui-style.c (_initialize_ui_style): Add declaration.
5993         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5994         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5995         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5996         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5997         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5998         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5999         * unittests/filtered_iterator-selftests.c
6000         (_initialize_filtered_iterator_selftests): Add declaration.
6001         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6002         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6003         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6004         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6005         * unittests/main-thread-selftests.c
6006         (_initialize_main_thread_selftests): Add declaration.
6007         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6008         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6009         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6010         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6011         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6012         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6013         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6014         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6015         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6016         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6017         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6018         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6019         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6020         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6021         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6022         declaration.
6023         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6024         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6025         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6026         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6027         * user-regs.c (_initialize_user_regs): Add declaration.
6028         * utils.c (_initialize_utils): Add declaration.
6029         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6030         * valops.c (_initialize_valops): Add declaration.
6031         * valprint.c (_initialize_valprint): Add declaration.
6032         * value.c (_initialize_values): Add declaration.
6033         * varobj.c (_initialize_varobj): Add declaration.
6034         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6035         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6036         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6037         * windows-nat.c (_initialize_windows_nat): Add declaration.
6038         (_initialize_check_for_gdb_ini): Add declaration.
6039         (_initialize_loadable): Add declaration.
6040         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6041         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6042         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6043         * xcoffread.c (_initialize_xcoffread): Add declaration.
6044         * xml-support.c (_initialize_xml_support): Add declaration.
6045         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6046         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6047         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6048         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6049
6050 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6051
6052         * regformats/regdat.sh: Generate declaration for init function.
6053
6054 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6055
6056         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6057         up.
6058         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6059         close_one_inferior>: New methods.
6060         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6061         pass down target to find_inferior_pid.
6062         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6063         Pass down target to find_inferior_ptid.
6064         (gdbsim_target::create_inferior): Pass down target to
6065         add_thread_silent.
6066         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6067         target down to find_inferior_ptid and switch_to_thread.
6068         (gdbsim_target::close): Update to call close_one_inferior.
6069         (struct resume_data): Remove.
6070         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6071         directly, rather than through a void pointer.
6072         (gdbsim_target::resume): Update to call resume_one_inferior.
6073
6074 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6075
6076         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6077
6078 2020-01-12  Pedro Alves  <palves@redhat.com>
6079
6080         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6081         directly for the current inferior instead of
6082         discard_all_inferiors.
6083         (discard_all_inferiors): Delete.
6084
6085 2020-01-11  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6088         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6089         deprecated_safe_get_selected_frame.
6090
6091 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6092
6093         * inferior.c (print_inferior): Switch inferior before printing it.
6094
6095 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6096             Pedro Alves  <palves@redhat.com>
6097
6098         * progspace-and-thread.c (switch_to_program_space_and_thread):
6099         Assert there's an inferior for PSPACE.  Use
6100         switch_to_inferior_no_thread to switch the inferior too.
6101         * progspace.c (program_space::~program_space): Call
6102         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6103         (program_space::free_all_objfiles): Don't call clear_symtab_users
6104         here.
6105         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6106
6107 2020-01-10  Pedro Alves  <palves@redhat.com>
6108
6109         * NEWS: Mention multi-target debugging, "info connections", and
6110         "add-inferior -no-connection".
6111
6112 2020-01-10  Pedro Alves  <palves@redhat.com>
6113
6114         * infrun.c: Include "target-connection.h".
6115         (check_multi_target_resumption): New.
6116         (proceed): Call it.
6117         * target-connection.c (make_target_connection_string): Make
6118         extern.
6119         * target-connection.h (make_target_connection_string): Declare.
6120
6121 2020-01-10  Pedro Alves  <palves@redhat.com>
6122
6123         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6124         * inferior.c (uiout_field_connection): New function.
6125         (print_inferior): Add new "connection-id" column.
6126         (add_inferior_command): Show connection number/string of added
6127         inferior.
6128         * process-stratum-target.h
6129         (process_stratum_target::connection_string): New virtual method.
6130         (process_stratum_target::connection_number): New field.
6131         * remote.c (remote_target::connection_string): New override.
6132         * target-connection.c: New file.
6133         * target-connection.h: New file.
6134         * target.c (decref_target): Remove process_stratum targets from
6135         the connection list.
6136         (target_stack::push): Add process_stratum targets to the
6137         connection list.
6138
6139 2020-01-10  Pedro Alves  <palves@redhat.com>
6140
6141         Revert:
6142         2016-04-12  Pedro Alves  <palves@redhat.com>
6143         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6144         Remove references to name.
6145         * serial.h (struct serial) <name>: Delete.
6146
6147 2020-01-10  Pedro Alves  <palves@redhat.com>
6148
6149         * gdbarch-selftests.c (register_to_value_test): Remove "target
6150         already pushed" check.
6151
6152 2020-01-10  Pedro Alves  <palves@redhat.com>
6153             John Baldwin  <jhb@FreeBSD.org>
6154
6155         * aarch64-linux-nat.c
6156         (aarch64_linux_nat_target::thread_architecture): Adjust.
6157         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6158         (task_command_1): Likewise.
6159         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6160         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6161         (aix_thread_target::store_registers)
6162         (aix_thread_target::thread_alive): Adjust.
6163         * amd64-fbsd-tdep.c: Include "inferior.h".
6164         (amd64fbsd_get_thread_local_address): Pass down target.
6165         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6166         thread's gdbarch instead of target_gdbarch.
6167         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6168         get_last_target_status.
6169         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6170         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6171         inferiors.
6172         (update_inserted_breakpoint_locations): Skip if inferiors with no
6173         execution.
6174         (update_global_location_list): When handling moribund locations,
6175         find representative inferior for location's pspace, and use thread
6176         count of its process_stratum target.
6177         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6178         * bsd-uthread.c (bsd_uthread_target::wait): Use
6179         as_process_stratum_target and adjust thread_change_ptid and
6180         add_thread calls.
6181         (bsd_uthread_target::update_thread_list): Use
6182         as_process_stratum_target and adjust find_thread_ptid,
6183         thread_change_ptid and add_thread calls.
6184         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6185         find_thread_ptid call.
6186         * corelow.c (add_to_thread_list): Adjust add_thread call.
6187         (core_target_open): Adjust add_thread_silent and thread_count
6188         calls.
6189         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6190         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6191         * event-top.c (async_disconnect): Pop targets from all inferiors.
6192         * exec.c (add_target_sections): Push exec target on all inferiors
6193         sharing the program space.
6194         (remove_target_sections): Remove the exec target from all
6195         inferiors sharing the program space.
6196         (exec_on_vfork): New.
6197         * exec.h (exec_on_vfork): Declare.
6198         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6199         Pass it down.
6200         (fbsd_nat_target::update_thread_list): Adjust.
6201         (fbsd_nat_target::resume): Adjust.
6202         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6203         down.
6204         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6205         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6206         get_thread_arch_regcache call.
6207         * fork-child.c (gdb_startup_inferior): Pass target down to
6208         startup_inferior and set_executing.
6209         * gdbthread.h (struct process_stratum_target): Forward declare.
6210         (add_thread, add_thread_silent, add_thread_with_info)
6211         (in_thread_list): Add process_stratum_target parameter.
6212         (find_thread_ptid(inferior*, ptid_t)): New overload.
6213         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6214         parameter.
6215         (all_threads()): Delete overload.
6216         (all_threads, all_non_exited_threads): Add process_stratum_target
6217         parameter.
6218         (all_threads_safe): Use brace initialization.
6219         (thread_count): Add process_stratum_target parameter.
6220         (set_resumed, set_running, set_stop_requested, set_executing)
6221         (threads_are_executing, finish_thread_state): Add
6222         process_stratum_target parameter.
6223         (switch_to_thread): Use is_current_thread.
6224         * i386-fbsd-tdep.c: Include "inferior.h".
6225         (i386fbsd_get_thread_local_address): Pass down target.
6226         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6227         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6228         have_inferiors check.
6229         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6230         (inf_ptrace_target::attach): Adjust.
6231         * infcall.c (run_inferior_call): Adjust.
6232         * infcmd.c (run_command_1): Pass target to
6233         scoped_finish_thread_state.
6234         (proceed_thread_callback): Skip inferiors with no execution.
6235         (continue_command): Rename 'all_threads' local to avoid hiding
6236         'all_threads' function.  Adjust get_last_target_status call.
6237         (prepare_one_step): Adjust set_running call.
6238         (signal_command): Use user_visible_resume_target.  Compare thread
6239         pointers instead of inferior_ptid.
6240         (info_program_command): Adjust to pass down target.
6241         (attach_command): Mark target's 'thread_executing' flag.
6242         (stop_current_target_threads_ns): New, factored out from ...
6243         (interrupt_target_1): ... this.  Switch inferior before making
6244         target calls.
6245         * inferior-iter.h
6246         (struct all_inferiors_iterator, struct all_inferiors_range)
6247         (struct all_inferiors_safe_range)
6248         (struct all_non_exited_inferiors_range): Filter on
6249         process_stratum_target too.  Remove explicit.
6250         * inferior.c (inferior::inferior): Push dummy target on target
6251         stack.
6252         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6253         Add process_stratum_target parameter, and pass it down.
6254         (have_live_inferiors): Adjust.
6255         (switch_to_inferior_and_push_target): New.
6256         (add_inferior_command, clone_inferior_command): Handle
6257         "-no-connection" parameter.  Use
6258         switch_to_inferior_and_push_target.
6259         (_initialize_inferior): Mention "-no-connection" option in
6260         the help of "add-inferior" and "clone-inferior" commands.
6261         * inferior.h: Include "process-stratum-target.h".
6262         (interrupt_target_1): Use bool.
6263         (struct inferior) <push_target, unpush_target, target_is_pushed,
6264         find_target_beneath, top_target, process_target, target_at,
6265         m_stack>: New.
6266         (discard_all_inferiors): Delete.
6267         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6268         (all_inferiors, all_non_exited_inferiors): Add
6269         process_stratum_target parameter.
6270         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6271         (target_last_proc_target): New global.
6272         (follow_fork_inferior): Push target on new inferior.  Pass target
6273         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6274         reference count.
6275         (follow_fork): Adjust get_last_target_status call.  Also consider
6276         target.
6277         (follow_exec): Push target on new inferior.
6278         (struct execution_control_state) <target>: New field.
6279         (user_visible_resume_target): New.
6280         (do_target_resume): Call target_async.
6281         (resume_1): Set target's threads_executing flag.  Consider resume
6282         target.
6283         (commit_resume_all_targets): New.
6284         (proceed): Also consider resume target.  Skip threads of inferiors
6285         with no execution.  Commit resumtion in all targets.
6286         (start_remote): Pass current inferior to wait_for_inferior.
6287         (infrun_thread_stop_requested): Consider target as well.  Pass
6288         thread_info pointer to clear_inline_frame_state instead of ptid.
6289         (infrun_thread_thread_exit): Consider target as well.
6290         (random_pending_event_thread): New inferior parameter.  Use it.
6291         (do_target_wait): Rename to ...
6292         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6293         down.
6294         (threads_are_resumed_pending_p, do_target_wait): New.
6295         (prepare_for_detach): Adjust calls.
6296         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6297         do_target_wait_1 instead of do_target_wait.
6298         (fetch_inferior_event): Adjust.  Switch to representative
6299         inferior.  Pass target down.
6300         (set_last_target_status): Add process_stratum_target parameter.
6301         Save target in global.
6302         (get_last_target_status): Add process_stratum_target parameter and
6303         handle it.
6304         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6305         (context_switch): Check inferior_ptid == null_ptid before calling
6306         inferior_thread().
6307         (get_inferior_stop_soon): Pass down target.
6308         (wait_one): Rename to ...
6309         (poll_one_curr_target): ... this.
6310         (struct wait_one_event): New.
6311         (wait_one): New.
6312         (stop_all_threads): Adjust.
6313         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6314         event's target.
6315         (switch_back_to_stepped_thread): Also consider target.
6316         (print_stop_event): Update.
6317         (normal_stop): Update.  Also consider the resume target.
6318         * infrun.h (wait_for_inferior): Remove declaration.
6319         (user_visible_resume_target): New declaration.
6320         (get_last_target_status, set_last_target_status): New
6321         process_stratum_target parameter.
6322         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6323         process_stratum_target parameter, and use it.
6324         (clear_inline_frame_state (thread_info*)): New.
6325         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6326         process_stratum_target parameter.
6327         (clear_inline_frame_state (thread_info*)): Declare.
6328         * linux-fork.c (delete_checkpoint_command): Pass target down to
6329         find_thread_ptid.
6330         (checkpoint_command): Adjust.
6331         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6332         instead of just tweaking inferior_ptid.
6333         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6334         (exit_lwp): Pass target down to find_thread_ptid.
6335         (attach_proc_task_lwp_callback): Pass target down to
6336         add_thread/set_running/set_executing.
6337         (linux_nat_target::attach): Pass target down to
6338         thread_change_ptid.
6339         (get_detach_signal): Pass target down to find_thread_ptid.
6340         Consider last target status's target.
6341         (linux_resume_one_lwp_throw, resume_lwp)
6342         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6343         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6344         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6345         (linux_nat_target::async_wait_fd): New.
6346         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6347         target down.
6348         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6349         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6350         * linux-thread-db.c (struct thread_db_info::process_target): New
6351         field.
6352         (add_thread_db_info): Save target.
6353         (get_thread_db_info): New process_stratum_target parameter.  Also
6354         match target.
6355         (delete_thread_db_info): New process_stratum_target parameter.
6356         Also match target.
6357         (thread_from_lwp): Adjust to pass down target.
6358         (thread_db_notice_clone): Pass down target.
6359         (check_thread_db_callback): Pass down target.
6360         (try_thread_db_load_1): Always push the thread_db target.
6361         (try_thread_db_load, record_thread): Pass target down.
6362         (thread_db_target::detach): Pass target down.  Always unpush the
6363         thread_db target.
6364         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6365         target down.  Always unpush the thread_db target.
6366         (find_new_threads_callback, thread_db_find_new_threads_2)
6367         (thread_db_target::update_thread_list): Pass target down.
6368         (thread_db_target::pid_to_str): Pass current inferior down.
6369         (thread_db_target::get_thread_local_address): Pass target down.
6370         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6371         target down.
6372         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6373         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6374         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6375         (procfs_init_inferior): Rename to ...
6376         (procfs_target::procfs_init_inferior): ... this and adjust.
6377         (procfs_target::create_inferior, procfs_notice_thread)
6378         (procfs_do_thread_registers): Adjust.
6379         * ppc-fbsd-tdep.c: Include "inferior.h".
6380         (ppcfbsd_get_thread_local_address): Pass down target.
6381         * proc-service.c (ps_xfer_memory): Switch current inferior and
6382         program space as well.
6383         (get_ps_regcache): Pass target down.
6384         * process-stratum-target.c
6385         (process_stratum_target::thread_address_space)
6386         (process_stratum_target::thread_architecture): Pass target down.
6387         * process-stratum-target.h
6388         (process_stratum_target::threads_executing): New field.
6389         (as_process_stratum_target): New.
6390         * ravenscar-thread.c
6391         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6392         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6393         down.
6394         * record-btrace.c (record_btrace_target::info_record): Adjust.
6395         (record_btrace_target::record_method)
6396         (record_btrace_target::record_is_replaying)
6397         (record_btrace_target::fetch_registers)
6398         (get_thread_current_frame_id, record_btrace_target::resume)
6399         (record_btrace_target::wait, record_btrace_target::stop): Pass
6400         target down.
6401         * record-full.c (record_full_wait_1): Switch to event thread.
6402         Pass target down.
6403         * regcache.c (regcache::regcache)
6404         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6405         process_stratum_target parameter and handle it.
6406         (current_thread_target): New global.
6407         (get_thread_regcache): Add process_stratum_target parameter and
6408         handle it.  Switch inferior before calling target method.
6409         (get_thread_regcache): Pass target down.
6410         (get_thread_regcache_for_ptid): Pass target down.
6411         (registers_changed_ptid): Add process_stratum_target parameter and
6412         handle it.
6413         (registers_changed_thread, registers_changed): Pass target down.
6414         (test_get_thread_arch_aspace_regcache): New.
6415         (current_regcache_test): Define a couple local test_target_ops
6416         instances and use them for testing.
6417         (readwrite_regcache): Pass process_stratum_target parameter.
6418         (cooked_read_test, cooked_write_test): Pass mock_target down.
6419         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6420         (get_thread_arch_aspace_regcache): Add process_stratum_target
6421         parameter.
6422         (regcache::target): New method.
6423         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6424         (regcache::registers_changed_ptid): Add process_stratum_target
6425         parameter.
6426         (regcache::m_target): New field.
6427         (registers_changed_ptid): Add process_stratum_target parameter.
6428         * remote.c (remote_state::supports_vCont_probed): New field.
6429         (remote_target::async_wait_fd): New method.
6430         (remote_unpush_and_throw): Add remote_target parameter.
6431         (get_current_remote_target): Adjust.
6432         (remote_target::remote_add_inferior): Push target.
6433         (remote_target::remote_add_thread)
6434         (remote_target::remote_notice_new_inferior)
6435         (get_remote_thread_info): Pass target down.
6436         (remote_target::update_thread_list): Skip threads of inferiors
6437         bound to other targets.  (remote_target::close): Don't discard
6438         inferiors.  (remote_target::add_current_inferior_and_thread)
6439         (remote_target::process_initial_stop_replies)
6440         (remote_target::start_remote)
6441         (remote_target::remote_serial_quit_handler): Pass down target.
6442         (remote_target::remote_unpush_target): New remote_target
6443         parameter.  Unpush the target from all inferiors.
6444         (remote_target::remote_unpush_and_throw): New remote_target
6445         parameter.  Pass it down.
6446         (remote_target::open_1): Check whether the current inferior has
6447         execution instead of checking whether any inferior is live.  Pass
6448         target down.
6449         (remote_target::remote_detach_1): Pass down target.  Use
6450         remote_unpush_target.
6451         (extended_remote_target::attach): Pass down target.
6452         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6453         (remote_target::append_resumption): Pass down target.
6454         (remote_target::append_pending_thread_resumptions)
6455         (remote_target::remote_resume_with_hc, remote_target::resume)
6456         (remote_target::commit_resume): Pass down target.
6457         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6458         (remote_target::interrupt_query)
6459         (remote_target::remove_new_fork_children)
6460         (remote_target::check_pending_events_prevent_wildcard_vcont)
6461         (remote_target::remote_parse_stop_reply)
6462         (remote_target::process_stop_reply): Pass down target.
6463         (first_remote_resumed_thread): New remote_target parameter.  Pass
6464         it down.
6465         (remote_target::wait_as): Pass down target.
6466         (unpush_and_perror): New remote_target parameter.  Pass it down.
6467         (remote_target::readchar, remote_target::remote_serial_write)
6468         (remote_target::getpkt_or_notif_sane_1)
6469         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6470         down target.
6471         (remote_target::mourn_inferior): Pass down target.  Use
6472         remote_unpush_target.
6473         (remote_target::core_of_thread)
6474         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6475         (remote_target::pid_to_exec_file)
6476         (remote_target::thread_handle_to_thread_info): Pass down target.
6477         (remote_target::async_wait_fd): New.
6478         * riscv-fbsd-tdep.c: Include "inferior.h".
6479         (riscv_fbsd_get_thread_local_address): Pass down target.
6480         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6481         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6482         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6483         Adjust.
6484         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6485         * solib-svr4.c (enable_break): Pass down target.
6486         * spu-multiarch.c (parse_spufs_run): Pass down target.
6487         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6488         * target-delegates.c: Regenerate.
6489         * target.c (g_target_stack): Delete.
6490         (current_top_target): Return the current inferior's top target.
6491         (target_has_execution_1): Refer to the passed-in inferior's top
6492         target.
6493         (target_supports_terminal_ours): Check whether the initial
6494         inferior was already created.
6495         (decref_target): New.
6496         (target_stack::push): Incref/decref the target.
6497         (push_target, push_target, unpush_target): Adjust.
6498         (target_stack::unpush): Defref target.
6499         (target_is_pushed): Return bool.  Adjust to refer to the current
6500         inferior's target stack.
6501         (dispose_inferior): Delete, and inline parts ...
6502         (target_preopen): ... here.  Only dispose of the current inferior.
6503         (target_detach): Hold strong target reference while detaching.
6504         Pass target down.
6505         (target_thread_name): Add assertion.
6506         (target_resume): Pass down target.
6507         (target_ops::beneath, find_target_at): Adjust to refer to the
6508         current inferior's target stack.
6509         (get_dummy_target): New.
6510         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6511         has a thread running.
6512         (initialize_targets): Rename to ...
6513         (_initialize_target): ... this.
6514         * target.h: Include "gdbsupport/refcounted-object.h".
6515         (struct target_ops): Inherit refcounted_object.
6516         (target_ops::shortname, target_ops::longname): Make const.
6517         (target_ops::async_wait_fd): New method.
6518         (decref_target): Declare.
6519         (struct target_ops_ref_policy): New.
6520         (target_ops_ref): New typedef.
6521         (get_dummy_target): Declare function.
6522         (target_is_pushed): Return bool.
6523         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6524         (all_matching_threads_iterator::all_matching_threads_iterator):
6525         Handle filter target.
6526         * thread-iter.h (struct all_matching_threads_iterator, struct
6527         all_matching_threads_range, class all_non_exited_threads_range):
6528         Filter by target too.  Remove explicit.
6529         * thread.c (threads_executing): Delete.
6530         (inferior_thread): Pass down current inferior.
6531         (clear_thread_inferior_resources): Pass down thread pointer
6532         instead of ptid_t.
6533         (add_thread_silent, add_thread_with_info, add_thread): Add
6534         process_stratum_target parameter.  Use it for thread and inferior
6535         searches.
6536         (is_current_thread): New.
6537         (thread_info::deletable): Use it.
6538         (find_thread_ptid, thread_count, in_thread_list)
6539         (thread_change_ptid, set_resumed, set_running): New
6540         process_stratum_target parameter.  Pass it down.
6541         (set_executing): New process_stratum_target parameter.  Pass it
6542         down.  Adjust reference to 'threads_executing'.
6543         (threads_are_executing): New process_stratum_target parameter.
6544         Adjust reference to 'threads_executing'.
6545         (set_stop_requested, finish_thread_state): New
6546         process_stratum_target parameter.  Pass it down.
6547         (switch_to_thread): Also match inferior.
6548         (switch_to_thread): New process_stratum_target parameter.  Pass it
6549         down.
6550         (update_threads_executing): Reimplement.
6551         * top.c (quit_force): Pop targets from all inferior.
6552         (gdb_init): Don't call initialize_targets.
6553         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6554         Declare.
6555         (windows_add_thread, windows_delete_thread): Adjust.
6556         (get_windows_debug_event): Rename to ...
6557         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6558         * tracefile-tfile.c (tfile_target_open): Pass down target.
6559         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6560         Forward declare.
6561         (switch_to_thread): Add process_stratum_target parameter.
6562         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6563         parameter.  Use it.
6564         (mi_on_resume): Pass target down.
6565         * nat/fork-inferior.c (startup_inferior): Add
6566         process_stratum_target parameter.  Pass it down.
6567         * nat/fork-inferior.h (startup_inferior): Add
6568         process_stratum_target parameter.
6569         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6570
6571 2020-01-10  Pedro Alves  <palves@redhat.com>
6572
6573         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6574         directly.  Instead find the first thread in the thread list and
6575         use switch_to_thread.
6576
6577 2020-01-10  Pedro Alves  <palves@redhat.com>
6578
6579         * remote.c (remote_target::remote_add_inferior): Don't bind a
6580         process to the current inferior if the current inferior is already
6581         bound to a process.
6582
6583 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6584             Pedro Alves  <palves@redhat.com>
6585
6586         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6587         If no process is specified, return null_ptid instead of
6588         inferior_ptid.
6589         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6590         TARGET_WAITKIND_SIGNALLED with no pid.
6591
6592 2020-01-10  Pedro Alves  <palves@redhat.com>
6593
6594         * remote.c (first_remote_resumed_thread): New.
6595         (remote_target::wait_as): Use it as default event_ptid instead of
6596         inferior_ptid.
6597
6598 2020-01-10  Pedro Alves  <palves@redhat.com>
6599
6600         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6601
6602 2020-01-10  Pedro Alves  <palves@redhat.com>
6603
6604         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6605         not -1.
6606
6607 2020-01-10  Pedro Alves  <palves@redhat.com>
6608
6609         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6610         ptid to get_last_target_status.
6611         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6612         ptid to get_last_target_status.
6613         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6614         get_last_target_status.
6615         (info_program_command): Don't pass a target_waitstatus to
6616         get_last_target_status.
6617         * infrun.c (init_wait_for_inferior): Use
6618         nullify_last_target_wait_ptid.
6619         (get_last_target_status): Handle nullptr arguments.
6620         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6621         (print_stop_event): Don't pass a ptid to get_last_target_status.
6622         (normal_stop): Don't pass a ptid to get_last_target_status.
6623         * infrun.h (get_last_target_status, set_last_target_status): Move
6624         comments here and update.
6625         (nullify_last_target_wait_ptid): Declare.
6626         * linux-fork.c (fork_load_infrun_state): Remove local extern
6627         declaration of nullify_last_target_wait_ptid.
6628         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6629         to get_last_target_status.
6630
6631 2020-01-10  Pedro Alves  <palves@redhat.com>
6632
6633         * gdbthread.h (scoped_restore_current_thread)
6634         <dont_restore, restore, m_dont_restore>: Declare.
6635         * thread.c (thread_alive): Add assertion.  Return bool.
6636         (switch_to_thread_if_alive): New.
6637         (prune_threads): Switch inferior/thread.
6638         (print_thread_info_1): Switch thread before calling target methods.
6639         (scoped_restore_current_thread::restore): New, factored out from
6640         ...
6641         (scoped_restore_current_thread::~scoped_restore_current_thread):
6642         ... this.
6643         (scoped_restore_current_thread::scoped_restore_current_thread):
6644         Add assertion.
6645         (thread_apply_all_command, thread_select): Use
6646         switch_to_thread_if_alive.
6647         * infrun.c (proceed, restart_threads, handle_signal_stop)
6648         (switch_back_to_stepped_thread): Switch current thread before
6649         calling target methods.
6650
6651 2020-01-10  Pedro Alves <palves@redhat.com>
6652
6653         * inferior.c (switch_to_inferior_no_thread): New function,
6654         factored out from ...
6655         (inferior_command): ... here.
6656         * inferior.h (switch_to_inferior_no_thread): Declare.
6657         * mi/mi-main.c (run_one_inferior): Use
6658         switch_to_inferior_no_thread.
6659
6660 2020-01-10  Pedro Alves  <palves@redhat.com>
6661
6662         * infcmd.c (kill_command): Remove dead code.
6663
6664 2020-01-10  Pedro Alves  <palves@redhat.com>
6665
6666         * remote.c (remote_target::mourn_inferior): No longer check
6667         whether the target is running.
6668
6669 2020-01-10  Pedro Alves  <palves@redhat.com>
6670
6671         * corelow.c (core_target::has_execution): Change parameter type to
6672         inferior pointer.
6673         * inferior.c (number_of_live_inferiors): Use
6674         inferior::has_execution instead of target_has_execution_1.
6675         * inferior.h (inferior::has_execution): New.
6676         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6677         inferior::has_execution instead of target_has_execution_1.
6678         * process-stratum-target.c
6679         (process_stratum_target::has_execution): Change parameter type to
6680         inferior pointer.  Check the inferior's PID instead of
6681         inferior_ptid.
6682         * process-stratum-target.h
6683         (process_stratum_target::has_execution): Change parameter type to
6684         inferior pointer.
6685         * record-full.c (record_full_core_target::has_execution): Change
6686         parameter type to inferior pointer.
6687         * target.c (target_has_execution_1): Change parameter type to
6688         inferior pointer.
6689         (target_has_execution_current): Adjust.
6690         * target.h (target_ops::has_execution): Change parameter type to
6691         inferior pointer.
6692         (target_has_execution_1): Change parameter type to inferior
6693         pointer.  Change return type to bool.
6694         * tracefile.h (tracefile_target::has_execution): Change parameter
6695         type to inferior pointer.
6696
6697 2020-01-10  Pedro Alves  <palves@redhat.com>
6698
6699         * exceptions.c (print_flush): Remove current_top_target() check.
6700
6701 2020-01-10  Pedro Alves  <palves@redhat.com>
6702
6703         * remote.c (show_remote_exec_file): Show the current inferior's
6704         exec-file instead of the command variable's value.
6705
6706 2020-01-10  Pedro Alves  <palves@redhat.com>
6707
6708         * record-full.c (record_full_resume_ptid): New global.
6709         (record_full_target::resume): Set it.
6710         (record_full_wait_1): Use record_full_resume_ptid instead of
6711         inferior_ptid.
6712
6713 2020-01-10  Pedro Alves  <palves@redhat.com>
6714
6715         * gdbthread.h (scoped_restore_current_thread)
6716         <dont_restore, restore, m_dont_restore>: Declare.
6717         * thread.c (thread_alive): Add assertion.  Return bool.
6718         (switch_to_thread_if_alive): New.
6719         (prune_threads): Switch inferior/thread.
6720         (print_thread_info_1): Switch thread before calling target methods.
6721         (scoped_restore_current_thread::restore): New, factored out from
6722         ...
6723         (scoped_restore_current_thread::~scoped_restore_current_thread):
6724         ... this.
6725         (scoped_restore_current_thread::scoped_restore_current_thread):
6726         Add assertion.
6727         (thread_apply_all_command, thread_select): Use
6728         switch_to_thread_if_alive.
6729
6730 2020-01-10  George Barrett  <bob@bob131.so>
6731
6732         * stap-probe.c (stap_modify_semaphore): Don't check for null
6733         semaphores.
6734         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6735         for null semaphores.
6736
6737 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6740         all source windows, and maintain horizontal scroll status while
6741         doing so.
6742
6743 2020-01-09  Tom Tromey  <tom@tromey.com>
6744
6745         PR tui/18932:
6746         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6747         update_source_window, not print_source_lines.
6748
6749 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * tui/tui.c (tui_enable): Register tui hooks after calling
6752         tui_display_main.
6753
6754 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6755
6756         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6757
6758 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6759
6760         * thread.c (print_thread_info_1): Fix indentation.
6761
6762 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6763
6764         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6765         unique_xmalloc_ptr outside the if to always free the demangled name.
6766
6767 2020-01-08  Tom Tromey  <tromey@adacore.com>
6768
6769         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6770         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6771         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6772         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6773         Remove.
6774         (section_offsets): New typedef.
6775         * symtab.c (fixup_section, get_msymbol_address): Update.
6776         * symmisc.c (dump_msymbols): Update.
6777         * symfile.h (relative_addr_info_to_section_offsets)
6778         (symfile_map_offsets_to_segments): Update.
6779         * symfile.c (build_section_addr_info_from_objfile)
6780         (init_objfile_sect_indices): Update.
6781         (struct place_section_arg): Change type of "offsets".
6782         (place_section): Update.
6783         (relative_addr_info_to_section_offsets): Change type of
6784         "section_offsets".  Remove "num_sections" parameter.
6785         (default_symfile_offsets, syms_from_objfile_1)
6786         (set_objfile_default_section_offset): Update.
6787         (reread_symbols): No need to preserve section offsets by hand.
6788         (symfile_map_offsets_to_segments): Change type of "offsets".
6789         * stap-probe.c (relocate_address): Update.
6790         * stabsread.h (process_one_symbol): Update.
6791         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6792         (solib_target_relocate_section_addresses): Update.
6793         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6794         Update.
6795         * solib-frv.c (frv_relocate_main_executable): Update.
6796         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6797         * solib-aix.c (solib_aix_get_section_offsets): Change return
6798         type.
6799         (solib_aix_solib_create_inferior_hook): Update.
6800         * remote.c (remote_target::get_offsets): Update.
6801         * psymtab.c (find_pc_sect_psymtab): Update.
6802         * psympriv.h (struct partial_symbol) <address, text_low,
6803         text_high>: Update.
6804         * objfiles.h (obj_section_offset): Update.
6805         (struct objfile) <section_offsets>: Change type.
6806         <num_sections>: Remove.
6807         (objfile_relocate): Update.
6808         * objfiles.c (entry_point_address_query): Update
6809         (relocate_one_symbol): Change type of "section_offsets".
6810         (objfile_relocate1, objfile_relocate1): Change type of
6811         "new_offsets".
6812         (objfile_rebase1): Update.
6813         * mipsread.c (mipscoff_symfile_read): Update.
6814         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6815         parameter.
6816         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6817         (parse_external, psymtab_to_symtab_1): Update.
6818         * machoread.c (macho_symfile_offsets): Update.
6819         * ia64-tdep.c (ia64_find_unwind_table): Update.
6820         * hppa-tdep.c (read_unwind_info): Update.
6821         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6822         * dwarf2read.c (create_addrmap_from_index)
6823         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6824         (process_psymtab_comp_unit_reader, add_partial_symbol)
6825         (add_partial_subprogram, process_full_comp_unit)
6826         (read_file_scope, read_func_scope, read_lexical_block_scope)
6827         (read_call_site_scope, dwarf2_rnglists_process)
6828         (dwarf2_ranges_process, dwarf2_ranges_read)
6829         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6830         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6831         Update.
6832         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6833         Update.
6834         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6835         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6836         (process_one_symbol): Change type of "section_offsets".
6837         * ctfread.c (get_objfile_text_range): Update.
6838         * coffread.c (coff_symtab_read, enter_linenos)
6839         (process_coff_symbol): Update.
6840         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6841         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6842
6843 2020-01-08  Tom Tromey  <tromey@adacore.com>
6844
6845         * dwarf2read.c (parse_macro_definition): Use std::string.
6846         (parse_macro_definition): Likewise.
6847
6848 2020-01-08  Tom Tromey  <tromey@adacore.com>
6849
6850         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6851         (ATTR_ALLOC_CHUNK): Remove.
6852
6853 2020-01-08  Tom Tromey  <tromey@adacore.com>
6854
6855         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6856
6857 2020-01-08  Tom Tromey  <tromey@adacore.com>
6858
6859         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6860         (dwarf2_compute_name, open_dwo_file): Likewise.
6861         (process_enumeration_scope): Use std::vector.
6862         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6863         (partial_die_info::fixup, dwarf2_start_subfile)
6864         (guess_full_die_structure_name, dwarf2_name): Likewise.
6865         (determine_prefix): Update.
6866         (guess_full_die_structure_name): Make return type const.
6867         (partial_die_full_name): Return unique_xmalloc_ptr.
6868         (DW_FIELD_ALLOC_CHUNK): Remove.
6869
6870 2020-01-07  Tom Tromey  <tromey@adacore.com>
6871
6872         PR build/24937:
6873         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6874
6875 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6876
6877         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6878
6879 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6880
6881         * stack.c (print_frame_info): Move disassemble_next_line code
6882         inside source_print block.
6883
6884 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6885
6886         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6887         gdb/signals.h, as we are now using native signal symbols.
6888
6889 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6890
6891         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6892         overflow by an early check of content vs threshold.
6893         * tui/tui-source.c (tui_source_window::line_is_displayed):
6894         Likewise.
6895
6896 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6897
6898         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6899
6900 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6901
6902         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6903         export table if no section contains it's RVA.
6904
6905 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6906
6907         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6908
6909 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6910
6911         * source.c (print_source_lines_base): Set last_line_listed.
6912
6913 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6914
6915         * tui/tui-disasm.c: Remove trailing spaces.
6916
6917 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6918             Pedro Alves  <palves@redhat.com>
6919
6920         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6921         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6922         (windows_gdb_signal_to_target): New function, uses the above
6923         enumeration to convert GDB internal signal codes to equivalent
6924         Windows codes.
6925         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6926         * windows-nat.c: Include "gdb_wait.h".
6927         (get_windows_debug_event): Extract the fatal exception from the
6928         exit status and convert to the equivalent Posix signal number.
6929         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6930         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6931         * gdbsupport/gdb_wait.c: New file, implements
6932         windows_status_to_termsig.
6933         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6934         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6935
6936 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6939         show_layout.
6940
6941 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6942
6943         * aarch64-linux-nat.c
6944         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6945         and bfd_mach_aarch64.
6946
6947 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6948
6949         * ui-file.c (stdio_file::can_emit_style_escape)
6950         (tee_file::can_emit_style_escape): Ensure style is used also on
6951         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6952         to gdb_stdout.
6953         * main.c (set_gdb_data_directory): Use file style to output the
6954         warning that the given pathname is not a directory.
6955         * top.c (show_history_filename, gdb_safe_append_history)
6956         (show_gdb_datadir): Use file style.
6957
6958 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6959
6960         * solib-target.c (struct lm_info_target):
6961         Change offsets to be a unique_xmalloc_ptr.
6962         (solib_target_relocate_section_addresses): Update.
6963
6964 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6965
6966         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6967
6968 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6969
6970         * MAINTAINERS (Write After Approval): Add myself.
6971
6972 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6973
6974         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6975         Cell BE architecture.
6976         * target.h (struct target_ops) <thread_architecture>: Likewise.
6977
6978 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6979
6980         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6981
6982 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6983
6984         * MAINTAINERS (Write After Approval): Add myself.
6985
6986 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6987
6988         * gdbarch.sh: Update copyright year range of generated files.
6989
6990 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6991
6992         Update copyright year range in all GDB files.
6993
6994 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6995
6996         * copyright.py: Convert to Python 3.
6997
6998 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6999
7000         * copyright.py: Adapt after move of gnulib directory from gdb
7001         directory to toplevel directory.
7002
7003 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7004
7005         * copyright.py (main): Exit if run from the wrong directory.
7006
7007 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7008
7009         * top.c (print_gdb_version): Change copyright year to 2020.
7010
7011 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7012
7013         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7014
7015 For older changes see ChangeLog-2019.
7016 \f
7017 Local Variables:
7018 mode: change-log
7019 left-margin: 8
7020 fill-column: 74
7021 version-control: never
7022 coding: utf-8
7023 End: