gdb/ChangeLog

   1 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         PR gdb/24445
   4         * dwarf-index-write.h (write_psymtabs_to_index): Add
   5         dwz_basename parameter.
   6         * dwarf-index-write.c (write_gdbindex): Move file writing to
   7         write_gdbindex_1.  Change return type void.
   8         (assert_file_size): Move up, remove filename parameter.
   9         (write_gdbindex_1): New function.
  10         (write_debug_names): Change return type to void, call
  11         assert_file_size.
  12         (struct index_wip_file): New struct.
  13         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  14         file logic to index_wip_file.  Write index for dwz file if
  15         needed.
  16         (save_gdb_index_command): Pass basename of dwz file, if present.
  17         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  18         build-id of dwz file, if present.
  19         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  20         (dwarf2_get_dwz_file): Likewise.
  21         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  22         (dwarf2_get_dwz_file): Likewise.
  23
  24 2019-06-16  Tom Tromey  <tom@tromey.com>
  25
  26         * coffread.c (process_coff_symbol): Use xstrdup.
  27         * value.c (create_internalvar): Use xstrdup.
  28
  29 2019-06-16  Tom Tromey  <tom@tromey.com>
  30
  31         * valops.c (value_cast, value_slice): Remove unnecessary cast.
  32         * breakpoint.c (stopin_command, stopat_command)
  33         (until_break_command, decode_location_default): Remove unnecessary
  34         cast.
  35         * utils.c (subset_compare): Remove unnecessary cast.
  36         * ada-lang.c (ada_update_initial_language): Remove unnecessary
  37         cast.
  38         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
  39         cast.
  40         * infcmd.c (path_command): Remove unnecessary cast.
  41         * coffread.c (decode_type): Remove unnecessary cast.
  42         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
  43         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
  44         * tui/tui-stack.c (tui_show_locator_content)
  45         (tui_show_frame_info): Remove unnecessary cast.
  46         * tui/tui-win.c (tui_scroll_forward_command)
  47         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
  48         (parse_scrolling_args): Remove unnecessary cast.
  49         * tui/tui-data.c (init_win_info, tui_del_window)
  50         (tui_free_window, tui_del_data_windows, tui_free_data_content)
  51         (free_content_elements): Remove unnecessary cast.
  52         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
  53         unnecessary cast.
  54         * tui/tui-source.c (tui_set_source_content)
  55         (tui_vertical_source_scroll): Remove unnecessary cast.
  56         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
  57         cast.
  58         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
  59         * tui/tui-regs.c (tui_display_registers_from)
  60         (tui_display_register): Remove unnecessary cast.
  61         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
  62         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
  63         (make_visible): Remove unnecessary cast.
  64         * tui/tui-winsource.c (tui_erase_source_content)
  65         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
  66         unnecessary cast.
  67         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
  68         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
  69         * stabsread.c (read_type, read_array_type, read_range_type):
  70         Remove unnecessary cast.
  71         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
  72         (parse_symbol, parse_type, upgrade_type, parse_external)
  73         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
  74         unnecessary cast.
  75         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
  76
  77 2019-06-16  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-data.c (tui_alloc_generic_win_info)
  80         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
  81         checks.
  82
  83 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
  84             Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * f-typeprint.c (f_print_type): Don't return early for not
  87         associated or not allocated types.
  88         (f_type_print_varspec_suffix): Add print_rank parameter and print
  89         ranks of array types in case they dangling.
  90         (f_type_print_base): Add print_rank parameter.
  91
  92 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * NEWS: Mention new MI commands.
  95         * break-catch-throw.c (enum exception_event_kind): Move to
  96         breakpoint.h.
  97         (print_mention_exception_catchpoint): Output text as a single
  98         message.
  99         (catch_exception_command_1): Rename to...
 100         (catch_exception_event): ...this, make non-static, update header
 101         command, and change some parameter types.
 102         (catch_catch_command): Update for changes to
 103         catch_exception_command_1.
 104         (catch_throw_command): Likewise.
 105         (catch_rethrow_command): Likewise.
 106         * breakpoint.c (enum exception_event_kind): Delete.
 107         * breakpoint.h (enum exception_event_kind): Moved here from
 108         break-catch-throw.c.
 109         (catch_exception_event): Declare.
 110         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 111         (mi_cmd_catch_throw): New function.
 112         (mi_cmd_catch_rethrow): New function.
 113         (mi_cmd_catch_catch): New function.
 114         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 115         'catch-catch' entries.
 116         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 117         (mi_cmd_catch_rethrow): Declare.
 118         (mi_cmd_catch_catch): Declare.
 119
 120 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 121
 122         * annotate.c (annotate_source_line): Change return type to void,
 123         update implementation to match.
 124         * annotate.h (annotate_source_line): Change return type to void,
 125         update header comment.
 126         * stack.c (print_frame_info): Don't change what frame information
 127         is printed based on whether annotations are on or not.
 128
 129 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 130
 131         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 132         (annotate_source): Make static.
 133         (annotate_source_line): Moved from source.c and renamed from
 134         identify_source_line.  Update the return type.
 135         * annotate.h (annotate_source): Delete declaration.
 136         (annotate_source_line): Declaration moved from source.h, and
 137         renamed from identify_source_line.  Return type updated.
 138         * source.c (identify_source_line): Moved to annotate.c and renamed
 139         to annotate_source_line.
 140         (info_line_command): Remove check of annotation_level.
 141         * source.h (identify_source_line): Move declaration to annotate.h
 142         and rename to annotate_source_line.
 143         * stack.c: Add 'annotate.h' include.
 144         (print_frame_info): Remove check of annotation_level before
 145         calling annotate_source_line.
 146
 147 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 148
 149         * source-cache.c (source_cache::get_plain_source_lines): Use
 150         open_source_file_with_line_charpos instead of just
 151         open_source_file, remove call to find_source_lines.
 152         (source_cache::get_source_lines): Likewise.
 153         * source.c (find_source_lines): Make static.
 154         (get_filename_and_charpos): Renamed into...
 155         (open_source_file_with_line_charpos): ..this along with changes to
 156         return a scoped_fd, and some other minor clean ups.
 157         (identify_source_line): Use open_source_file_with_line_charpos.
 158         (search_command_helper): Use open_source_file_with_line_charpos
 159         instead of just open_source_file, remove call to
 160         find_source_lines.
 161         * source.h (open_source_file_with_line_charpos): Declare new
 162         function.
 163         (find_source_lines): Delete declaration.
 164
 165 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * source.c (get_filename_and_charpos): Remove fullname
 168         parameter.
 169         (identify_source_line): Update call to get_filename_and_charpos.
 170
 171 2019-06-14  Tom Tromey  <tromey@adacore.com>
 172
 173         PR gdb/24502:
 174         * ui-style.h (skip_ansi_escape): Update comment.
 175         * ui-file.h (class no_terminal_escape_file): New class.
 176         * ui-file.c (no_terminal_escape_file::write)
 177         (no_terminal_escape_file::puts): New methods.
 178         * cli/cli-logging.c (handle_redirections): Use
 179         no_terminal_escape_file.
 180
 181 2019-06-14  Tom Tromey  <tromey@adacore.com>
 182
 183         * NEWS: Move convenience variable news above Python news.
 184
 185 2019-06-14  Tom Tromey  <tom@tromey.com>
 186
 187         * gnulib: Move directory to top-level.
 188         * configure.ac: Don't configure gnulib.
 189         * configure: Rebuild.
 190         * common/common-defs.h: Use new path to gnulib.
 191         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 192         (GNULIB_H): Remove.
 193         (INCGNU): Look in new gnulib location.
 194         (HFILES_NO_SRCDIR): Remove gnulib files.
 195         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 196         (generated_files): Remove GNULIB_H.
 197         ($(LIBGNU), all-lib): Remove targets.
 198         (distclean): Don't mention GNULIB_BUILDDIR.
 199         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 200
 201 2019-06-14  Tom Tromey  <tromey@adacore.com>
 202
 203         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 204         Warn if symbol file does not provide any symbols.
 205
 206 2019-06-14  Tom Tromey  <tromey@adacore.com>
 207
 208         * source.c (find_and_open_source): Respect basenames_may_differ.
 209
 210 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * annotate.c (annotate_breakpoints_invalid): Make use of
 213         scoped_restore_terminal_state.
 214         (annotate_frames_invalid): Likewise.
 215
 216 2019-06-14  Tom Tromey  <tromey@adacore.com>
 217
 218         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 219         allow assignment to an internalvar.
 220
 221 2019-06-14  Tom Tromey  <tromey@adacore.com>
 222
 223         * ada-lex.l: Allow "_" in attribute names.
 224
 225 2019-06-14  Tom Tromey  <tromey@adacore.com>
 226
 227         PR gdb/24653:
 228         * regcache.c (registers_changed): Don't call alloca.
 229         * top.c (execute_command): Don't call alloca.
 230
 231 2019-06-13  Pedro Alves  <palves@redhat.com>
 232
 233         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 234         'expression'.  When parsing an expression, error out if there's
 235         junk after "unlimited".
 236         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 237         (do_set_command): Adjust calls to is_unlimited_literal.
 238
 239 2019-06-13  Pedro Alves  <palves@redhat.com>
 240
 241         * compile/compile.c (make_compile_options_def_group): Add braces
 242         around array_view initializer.
 243         * thread.c (make_thread_apply_all_options_def_group)
 244         (make_thread_apply_all_options_def_group): Likewise.
 245
 246 2019-06-13  Pedro Alves  <palves@redhat.com>
 247
 248         * NEWS (New commands): Mention "maint test-options
 249         require-delimiter", "maint test-options unknown-is-error", "maint
 250         test-options unknown-is-operand" and "maint show
 251         test-options-completion-result".
 252         (New command options, command completion): New section.
 253         (Completion improvements): New section.
 254         Mention that you can abbreviate "unlimited".
 255
 256 2019-06-13  Pedro Alves  <palves@redhat.com>
 257
 258         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 259         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 260         * unittests/cli-utils-selftests.c (test_parse_flags)
 261         (test_parse_flags_qcs): Delete.
 262         (test_cli_utils): Don't call deleted functions.
 263
 264 2019-06-13  Pedro Alves  <palves@redhat.com>
 265
 266         * thread.c: Include "cli/cli-option.h".
 267         (tp_array_compar_ascending): Global.
 268         (tp_array_compar): Delete function.
 269         (tp_array_compar_ascending, tp_array_compar_descending): New
 270         functions.
 271         (ascending_option_def, qcs_flag_option_def)
 272         (thr_qcs_flags_option_defs)
 273         (make_thread_apply_all_options_def_group)
 274         (make_thread_apply_options_def_group): New.
 275         (thread_apply_all_command): Use gdb::option::process_options.
 276         (thread_apply_command_completer)
 277         (thread_apply_all_command_completer): New.
 278         (thread_apply_command): Use gdb::option::process_options.
 279         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 280         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 281         to generate help text of "thread apply".  Adjust "taas"'s help.
 282         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 283         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 284
 285 2019-06-13  Pedro Alves  <palves@redhat.com>
 286
 287         * thread.c (thread_apply_command): Check for invalid TID with
 288         isdigit instead of !isalpha.
 289
 290 2019-06-13  Pedro Alves  <palves@redhat.com>
 291
 292         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 293         (validate_flags_qcs): New.
 294         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 295         (validate_flags_qcs): Declare.
 296         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 297         (make_frame_apply_options_def_group): New.
 298         (frame_apply_command_count): Process options with
 299         gdb::option::process_options.
 300         (frame_apply_completer): New.
 301         (frame_apply_level_completer, frame_apply_all_completer)
 302         (frame_apply_completer): New.
 303         (_initialize_stack): Update help of "frame apply", "frame apply
 304         level", "frame apply all" and "faas" to mention supported options
 305         and install command completers.
 306         * stack.h (frame_apply_all_completer): Declare.
 307         * thread.c: Include "stack.h".
 308         (tfaas_command): Add "--".
 309         (_initialize_thread): Update help "tfaas" to mention supported
 310         options and install command completer.
 311
 312 2019-06-13  Pedro Alves  <palves@redhat.com>
 313
 314         * completer.c (complete_nested_command_line): New.
 315         (gdb_completion_word_break_characters_throw): Add assertion.
 316         * completer.h (complete_nested_command_line): Declare.
 317
 318 2019-06-13  Pedro Alves  <palves@redhat.com>
 319
 320         * stack.c (parse_backtrace_qualifiers): New.
 321         (backtrace_command): Use it.
 322         (backtrace_command_completer): Complete on qualifiers.
 323
 324 2019-06-13  Pedro Alves  <palves@redhat.com>
 325
 326         * frame.c: Include "cli/cli-option.h.
 327         (user_set_backtrace_options): New.
 328         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 329         Delete.
 330         (get_prev_frame): Adjust.
 331         (boolean_option_def, uinteger_option_def)
 332         (set_backtrace_option_defs): New.
 333         (_initialize_frame): Adjust and use
 334         gdb::option::add_setshow_cmds_for_options to install "set
 335         backtrace past-main" and "set backtrace past-entry".
 336         * frame.h: Include "cli/cli-option.h".
 337         (struct frame_print_options): Forward declare.
 338         (print_frame_arguments_all, print_frame_arguments_scalars)
 339         (print_frame_arguments_none): Declare.
 340         (print_entry_values): Delete declaration.
 341         (struct frame_print_options, user_frame_print_options): New.
 342         (struct set_backtrace_options): New.
 343         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 344         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 345         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 346         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 347         (list_args_or_locals): Add frame_print_options parameter.
 348         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 349         * python/py-framefilter.c (enumerate_args): Pass down
 350         USER_FRAME_PRINT_OPTIONS.
 351         * stack.c: Include "cli/cli-option.h".
 352         (print_frame_arguments_all, print_frame_arguments_scalars)
 353         (print_frame_arguments_none): Declare.
 354         (print_raw_frame_arguments, print_entry_values): Delete.
 355         (user_frame_print_options): New.
 356         (boolean_option_def, enum_option_def, frame_print_option_defs):
 357         New.
 358         (struct backtrace_cmd_options): New.
 359         (bt_flag_option_def): New.
 360         (backtrace_command_option_defs): New.
 361         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 362         (print_frame_arg, read_frame_arg, print_frame_args)
 363         (print_frame_info, print_frame): Add frame_print_options parameter
 364         and use it.
 365         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 366         (backtrace_command_1): Add frame_print_options and
 367         backtrace_cmd_options parameters and use them.
 368         (make_backtrace_options_def_group): New.
 369         (backtrace_command): Process command options with
 370         gdb::option::process_options.
 371         (backtrace_command_completer): New.
 372         (_initialize_stack): Extend "backtrace"'s help to mention
 373         supported options.  Install completer for "backtrace".
 374         Install some settings commands with add_setshow_cmds_for_options.
 375
 376 2019-06-13  Pedro Alves  <palves@redhat.com>
 377
 378         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 379         and that "set/show print raw frame-arguments" are now deprecated.
 380
 381         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 382         command.
 383         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 384         * stack.c (_initialize_stack): Install "set/show print
 385         raw-frame-arguments", and deprecate "set/show print raw
 386         frame-arguments".
 387         * valprint.c (_initialize_valprint): Deprecate "set/show print
 388         raw".
 389
 390 2019-06-13  Pedro Alves  <palves@redhat.com>
 391
 392         * compile/compile.c (struct compile_options): New.
 393         (compile_flag_option_def, compile_command_option_defs)
 394         (make_compile_options_def_group): New.
 395         (compile_file_command): Handle options with
 396         gdb::option::process_options.
 397         (compile_file_command_completer): New function.
 398         (compile_code_command): Handle options with
 399         gdb::option::process_options.
 400         (compile_code_command_completer): New function.
 401         (_initialize_compiler): Install completers for "compile code" and
 402         "compile file".  Mention available options in "compile code" and
 403         "compile code"'s help.
 404         * completer.c (advance_to_completion_word): New, factored out from
 405         ...
 406         (advance_to_expression_complete_word_point): ... this.
 407         (advance_to_filename_complete_word_point): New.
 408         * completer.h (advance_to_filename_complete_word_point): New
 409         declaration.
 410
 411 2019-06-13  Pedro Alves  <palves@redhat.com>
 412
 413         * compile/compile.c: Include "cli/cli-option.h".
 414         (compile_print_value): Scope data pointer is now a
 415         value_print_options pointer; adjust.
 416         (compile_print_command): Process options.  Scope data pointer is
 417         now a value_print_options pointer; adjust.
 418         (_initialize_compile): Update "compile print"'s help to include
 419         supported options.  Install a completer for "compile print".
 420         * cp-valprint.c (show_vtblprint, show_objectprint)
 421         (show_static_field_print): Delete.
 422         (_initialize_cp_valprint): Don't install "set print
 423         static-members", "set print vtbl", "set print object" here.
 424         * printcmd.c: Include "cli/cli-option.h" and
 425         "common/gdb_optional.h".
 426         (print_command_parse_format): Rework to fill in a
 427         value_print_options instead of a format_data.
 428         (print_value): Change parameter type from format_data pointer to
 429         value_print_options reference.  Adjust.
 430         (print_command_1): Process options.  Adjust to pass down a
 431         value_print_options.
 432         (print_command_completer): New.
 433         (_initialize_printcmd): Install print_command_completer as
 434         handle_brkchars completer for the "print" command.  Update
 435         "print"'s help to include supported options.
 436         * valprint.c: Include "cli/cli-option.h".
 437         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 438         here from cp-valprint.c.
 439         (boolean_option_def, uinteger_option_def)
 440         (value_print_option_defs, make_value_print_options_def_group):
 441         New.  Use gdb::option::add_setshow_cmds_for_options to install
 442         "set print elements", "set print null-stop", "set print repeats",
 443         "set print pretty", "set print union", "set print array", "set
 444         print address", "set print symbol", "set print array-indexes".
 445         * valprint.h: Include <string> and "cli/cli-option.h".
 446         (make_value_print_options_def_group): Declare.
 447         (print_value): Change parameter type from format_data pointer to
 448         value_print_options reference.
 449         (print_command_completer): Declare.
 450
 451 2019-06-13  Pedro Alves  <palves@redhat.com>
 452
 453         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 454         (COMMON_SFILES): Add maint-test-settings.c.
 455         * cli/cli-decode.c (boolean_enums): New global, factored out from
 456         ...
 457         (add_setshow_boolean_cmd): ... here.
 458         * cli/cli-decode.h (boolean_enums): Declare.
 459         * cli/cli-option.c: New file.
 460         * cli/cli-option.h: New file.
 461         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 462         factored out from ...
 463         (parse_cli_boolean_value(const char *)): ... this.
 464         (is_unlimited_literal): Change parameter type to pointer to
 465         pointer.  Adjust and advance ARG pointer.
 466         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 467         (parse_cli_var_enum): New, factored out from ...
 468         (do_set_command): ... this.  Adjust.
 469         * cli/cli-setshow.h (parse_cli_boolean_value)
 470         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 471         (parse_cli_var_enum): Declare.
 472         * cli/cli-utils.c: Include "cli/cli-option.h".
 473         (get_ulongest): New.
 474         * cli/cli-utils.h (get_ulongest): Declare.
 475         (check_for_argument): New overloads.
 476         * maint-test-options.c: New file.
 477
 478 2019-06-13  Pedro Alves  <palves@redhat.com>
 479
 480         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 481         parse a range if "-" is at the end of the string.
 482
 483 2019-06-13  Pedro Alves  <palves@redhat.com>
 484
 485         * cli/cli-setshow.c (parse_auto_binary_operation)
 486         (parse_cli_boolean_value): Don't allow "o".
 487
 488 2019-06-13  Pedro Alves  <palves@redhat.com>
 489
 490         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 491         * NEWS: Mention maint test-settings KIND.
 492         * maint-test-settings.c: New file.
 493
 494 2019-06-13  Pedro Alves  <palves@redhat.com>
 495
 496         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 497         completer.
 498         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 499         "set" completers.
 500
 501 2019-06-13  Pedro Alves  <palves@redhat.com>
 502
 503         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 504         after item.
 505
 506 2019-06-13  Pedro Alves  <palves@redhat.com>
 507
 508         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 509
 510 2019-06-13  Pedro Alves <palves@redhat.com>
 511
 512         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 513         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 514         call.
 515         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 516         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 517         calls.
 518         (check_for_argument): Skip spaces after argument.
 519
 520 2019-06-13  Pedro Alves  <palves@redhat.com>
 521
 522         * thread.c (thread_apply_command): Adjust TID parsing.
 523         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 524         detected before end of string.
 525         (tid_is_in_list): Error out if LIST is invalid.
 526
 527 2019-06-13  Pedro Alves  <palves@redhat.com>
 528
 529         * completer.c (complete_line_internal_1): Rewind completion word
 530         point.
 531         (completion_tracker::advance_custom_word_point_by): Change
 532         parameter type to int.
 533         * completer.h (completion_tracker::advance_custom_word_point_by):
 534         Likewise.
 535
 536 2019-06-13  Pedro Alves  <palves@redhat.com>
 537
 538         * completer.c (advance_to_completion_word): Handle delimiters.
 539
 540 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 541
 542         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 543
 544 2019-06-11  Tom Tromey  <tom@tromey.com>
 545
 546         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 547         (xmalloc_failed): Move to alloc.c.
 548         * alloc.c: New file.
 549         * Makefile.in (COMMON_SFILES): Add alloc.c.
 550
 551 2019-06-11  Tom Tromey  <tom@tromey.com>
 552
 553         * nat/linux-waitpid.c: Don't include server.h.
 554         (linux_debug): Remove.
 555         (my_waitpid): Update.
 556
 557 2019-06-11  Tom Tromey  <tromey@adacore.com>
 558
 559         * infcall.c (_initialize_infcall): Remove trailing newline from
 560         help.
 561         * user-regs.c (_initialize_user_regs): Remove trailing newline
 562         from help.
 563         * typeprint.c (_initialize_typeprint): Remove trailing newline
 564         from help.
 565         * reverse.c (_initialize_reverse): Remove trailing newlines from
 566         help.
 567         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 568         from help.
 569         * language.c (add_set_language_command): Remove trailing newline
 570         from help.
 571         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 572         help.
 573         * disasm.c (_initialize_disasm): Remove trailing newline from
 574         help.
 575         * top.c (init_main): Remove trailing newline from help.
 576         * interps.c (_initialize_interpreter): Remove trailing newline
 577         from help.
 578         * btrace.c (_initialize_btrace): Remove trailing newlines from
 579         help.
 580         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 581         from help.
 582         * python/python.c (_initialize_python): Remove trailing newline
 583         from help.
 584         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 585         help.
 586         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 587         from help.  Reformat some text.
 588         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 589         from help.
 590         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 591         newline from help.
 592
 593 2019-06-11  Tom Tromey  <tromey@adacore.com>
 594
 595         * darwin-nat.c (darwin_decode_exception_message)
 596         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 597
 598 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * valops.c (value_slice): Check for not allocated or not
 601         associated values.
 602
 603 2019-06-10  Tom de Vries  <tdevries@suse.de>
 604
 605         PR gdb/24618
 606         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 607         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 608         invalid.
 609
 610 2019-06-10  Tom de Vries  <tdevries@suse.de>
 611
 612         PR gdb/24611
 613         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 614         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 615
 616 2019-06-10  Tom de Vries  <tdevries@suse.de>
 617
 618         PR symtab/24545
 619         * symtab.c (struct demangled_name_entry): Add language field.
 620         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 621         static minimal symbol".  Set and use language field.
 622
 623 2019-06-10  Tom Tromey  <tromey@adacore.com>
 624
 625         * ada-lang.c (_initialize_ada_language): Update help text.
 626
 627 2019-06-10  Tom Tromey  <tromey@adacore.com>
 628
 629         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 630         with a newline.
 631         * guile/guile.c (handle_boot_error): Don't end warning with a
 632         newline.
 633         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 634         warning with a newline.
 635         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 636         newline.
 637         (s12z_frame_cache): Likewise.
 638         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 639         a newline.
 640         * solib-svr4.c (disable_probes_interface): Don't end warning with
 641         a newline.
 642         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 643         newline.
 644         * python/python.c (do_finish_initialization): Don't end warning
 645         with a newline.
 646
 647 2019-06-10  Tom Tromey  <tom@tromey.com>
 648
 649         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 650         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 651         gdbpy_enter.
 652
 653 2019-06-10  Tom Tromey  <tromey@adacore.com>
 654
 655         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 656         data.
 657         (elf_new_init): Don't call stabsread_new_init.
 658         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 659         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 660         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 661
 662 2019-06-10  Tom de Vries  <tdevries@suse.de>
 663
 664         PR symtab/16264
 665         PR symtab/24517
 666         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 667
 668 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 669
 670         * source.c (find_and_open_source): Also rewrite relative file
 671         names.
 672
 673 2019-04-26  Amos Bird  <amosbird@gmail.com>
 674
 675         * annotate.c (annotate_thread_exited): Add "thread-exited"
 676         annotation.
 677
 678 2019-06-06  Tom Tromey  <tromey@adacore.com>
 679
 680         * maint.h (class scoped_command_stats): Use
 681         DISABLE_COPY_AND_ASSIGN.
 682         <print_time>: New method.
 683         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 684         print_time.
 685         (scoped_command_stats::print_time): New method.
 686
 687 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 688
 689         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 690         instructions of lengths 6 or 8 bytes.
 691
 692 2019-06-04  Pedro Alves  <palves@redhat.com>
 693
 694         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 695
 696         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 697         * breakpoint.c (condition_completer): Likewise.
 698         * cli/cli-dump.c (scan_expression): Likewise.
 699         * common/filestuff.c (mkdir_recursive): Likewise.
 700         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 701         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 702         (gdb_abspath): Likewise.
 703         * compile/compile-cplus-types.c
 704         (compile_cplus_instance::decl_name): Likewise.
 705         * completer.c (complete_explicit_location):
 706         (signal_completer, reg_or_group_completer_1): Likewise.
 707         * cp-support.c (cp_remove_params_if_any): Likewise.
 708         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 709         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 710         * infcmd.c (strip_bg_char): Likewise.
 711         * linespec.c (copy_token_string): Likewise.
 712         * mi/mi-main.c (output_cores): Likewise.
 713         * psymtab.c (psymtab_search_name):
 714         * symfile.c (test_set_ext_lang_command): Likewise.
 715         * target.c (target_fileio_read_stralloc): Likewise.
 716         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 717         * value.c (complete_internalvar): Likewise.
 718
 719 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 720
 721         Add objfile property to gdb.Type.
 722         * NEWS: Mention Python API addition.
 723         * python/py-type.c (typy_get_objfile): New method.
 724
 725 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 726
 727         * NEWS: Mention the new set|show style [title|highlight].
 728         Mention changes to "show style", "help" and "apropos".
 729
 730 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 731
 732         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 733         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 734         instead of print_help_for_command.
 735         (print_doc_of_command): New function.
 736         (help_list): Add 'apropos -v word' suggestion.
 737         (print_help_for_command): Style the command name using title style.
 738         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 739         (_initialize_cli_cmds): Describe -v in apropos_command help.
 740
 741 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 742
 743         * cli/cli-style.h (cli_style_option): Add name in constructor,
 744         add m_name class member, add constructor with intensity,
 745         add name class function.
 746         (cli_style_option::add_setshow_commands): Remove name argument.
 747         (highlight_style, title_style): New styles.
 748         * cli/cli-style.c (do_show): New function that shows a style
 749         characteristic styling the style name with itself.
 750         (set_style_name): New function.
 751         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 752         Update all callers according to the changes in cli/cli-style.h.
 753         * utils.h (fputs_highlighted): New function.
 754         * utils.c (fputs_highlighted): Likewise.
 755
 756 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 757
 758         * NEWS: Mention new pipe command and new convenience variables.
 759
 760 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 761
 762         * cli/cli-cmds.c (pipe_command): New function.
 763         (_initialize_cli_cmds): Call add_com for pipe_command.
 764         Define | as an alias for pipe.
 765         (exit_status_set_internal_vars): New function.
 766         (shell_escape): Call exit_status_set_internal_vars.
 767         cli/cli-decode.c (find_command_name_length): Recognize | as
 768         a single character command.
 769
 770 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 771
 772         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 773         top.c (execute_command_to_ui_file): New function, mostly a copy
 774         of execute_command_to_string.
 775         (execute_command_to_string): Implement by calling
 776         execute_command_to_ui_file.
 777
 778 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 779
 780         * top.h (saved_command_line): Remove declaration.
 781         * top.c (previous_saved_command_line, previous_repeat_arguments):
 782         New variables.
 783         (saved_command_line): Make static, define together with other
 784         'repeat variables'.
 785         (dont_repeat): Clear repeat_arguments.
 786         (repeat_previous, get_saved_command_line, save_command_line):
 787         New functions.
 788         (gdb_init): Initialize saved_command_line
 789         and previous_saved_command_line.
 790         * main.c (captured_main_1): Remove saved_command_line initialization.
 791         * event-top.c (handle_line_of_input): Update to use
 792         the new 'repeat' related functions instead of direct access to
 793         saved_command_line.
 794         * command.h (repeat_previous, get_saved_command_line,
 795         save_command_line): New declarations.
 796         (dont_repeat): Add comment.
 797
 798 2019-05-30  Tom Tromey  <tromey@adacore.com>
 799
 800         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 801         Fix comment.
 802         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 803
 804 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 805
 806         PR cli/24587
 807         * completer.c (complete): Initialize variable word.
 808
 809 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 810
 811         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 812         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 813         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 814         'body' is NULL to the outter 'if', protecting the '!is_define'
 815         situation as well.
 816
 817 2019-05-29  Tom Tromey  <tromey@adacore.com>
 818
 819         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 820         (dwarf_unknown): New function.
 821         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 822         (dwarf_type_encoding_name): Use dwarf_unknown.
 823
 824 2019-05-29  Tom Tromey  <tromey@adacore.com>
 825
 826         PR c++/20020:
 827         * cp-valprint.c (cp_print_value_fields): Call
 828         cp_print_static_field inside "try".
 829
 830 2019-05-29  Tom Tromey  <tromey@adacore.com>
 831
 832         * inflow.c (struct terminal_info): Add default operator=.
 833         * configure: Rebuild.
 834         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 835         -Wdeprecated-copy-dtor, -Wredundant-move.
 836
 837 2019-05-29  Tom Tromey  <tromey@adacore.com>
 838
 839         * NEWS: Add entry.
 840         * infcmd.c (print_return_value_1): Handle finish_print
 841         option.
 842         (show_print_finish): New function.
 843         (_initialize_infcmd): Add "set/show print finish" commands.
 844         * valprint.c (user_print_options): Initialize new member.
 845         * valprint.h (struct value_print_options) <finish_print>: New
 846         member.
 847
 848 2019-05-28  Tom Tromey  <tromey@adacore.com>
 849
 850         * ada-lang.c (ada_remove_Xbn_suffix)
 851         (find_old_style_renaming_symbol)
 852         (parse_old_style_renaming): Remove.
 853         (ada_find_renaming_symbol): Don't call
 854         find_old_style_renaming_symbol.
 855         (ada_is_renaming_symbol): Rename from
 856         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 857         bool.  Now static.
 858         (ada_read_var_value): Update and simplify.
 859         * ada-exp.y (write_var_or_type): Remove old code.
 860
 861 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 862
 863         * event-top.c: Remove include comment.
 864         * inflow.c (class scoped_ignore_sigttou): Move from here...
 865         * inflow.h (class scoped_ignore_sigttou): ...to here.
 866         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 867         * top.c:  Remove include comment.
 868
 869 2019-05-27  Tom Tromey  <tom@tromey.com>
 870
 871         * NEWS: Fix typo.
 872
 873 2019-05-22  Tom Tromey  <tromey@adacore.com>
 874
 875         * target.c (target_follow_exec): Constify parameter.
 876         * target-delegates.c: Rebuild.
 877         * remote.c (remote_target::follow_exec): Constify parameter.
 878         * infrun.c (follow_exec): Constify parameter.
 879         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 880         (target_follow_exec): Likewise.
 881
 882 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 883
 884         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 885         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 886
 887 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 888
 889         * NEWS: Add debugredirect and testsuite sections.
 890
 891 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 892
 893         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 894         target descriptions using exclusively floating point register name
 895         aliases.
 896
 897 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         PR gdb/18644:
 900         * f-lang.c (build_fortran_types): Handle the case where
 901         gdbarch_floatformat_for_type returns a nullptr.
 902
 903 2019-05-21  Tom de Vries  <tdevries@suse.de>
 904
 905         PR cli/24587
 906         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 907
 908 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         PR gdb/18644:
 911         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 912         16-byte floats.
 913         * i386-tdep.c (i386_floatformat_for_type): Use
 914         floatformats_ia64_quad for the 16-byte floating point component
 915         within a fortran 32-byte complex number.
 916
 917 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 920         delete default constructor.
 921         (find_partial_die): Update to return const struct.
 922         (partial_die_parent_scope): Move variable declaration into scope
 923         of its use and change its type to auto.
 924         (guess_partial_die_structure_name): Likewise.
 925         (partial_die_info::fixup): Likewise.
 926
 927 2019-05-17  Tom Tromey  <tromey@adacore.com>
 928
 929         * source.c (find_and_open_source): Remove cast.
 930
 931 2019-05-17  Tom Tromey  <tromey@adacore.com>
 932
 933         * annotate.c (annotate_source): Make "filename" const.
 934         * annotate.h (annotate_source): Use const.
 935
 936 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * disasm.c (set_disassembler_options): Send errors to stderr.
 939
 940 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 941
 942         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 943         (cli_interp_base::set_logging): Check debug_redirect.
 944         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 945         * cli/cli-logging.c (debug_redirect): Add static variable.
 946         (pop_output_files): Add default param.
 947         (handle_redirections): Print debug setting.
 948         (show_logging_command): Likewise.
 949         (_initialize_cli_logging): Add debugredirect command.
 950         * interps.c (current_interp_set_logging): Add debug_redirect
 951         parameter.
 952         * interps.h (set_logging): Add debug_redirect parameter.
 953         (current_interp_set_logging): Likewise.
 954         * mi/mi-common.h: Likewise.
 955         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 956
 957 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 958             Tom Tromey  <tromey@adacore.com>
 959
 960         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 961         directly.
 962         * cli/cli-interp.h (make_logging_output): Remove declaration.
 963         * cli/cli-logging.c (make_logging_output): Remove function.
 964         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 965         directly.
 966         * ui-file.c (tee_file::tee_file): Remove bools.
 967         (tee_file::~tee_file): Remove deletes.
 968         * ui-file.h (tee_file): Remove bools.
 969
 970 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 971
 972         * mi/mi-cmds.h (mi_cmd_complete): New function.
 973         * mi/mi-main.c (mi_cmd_complete): Likewise.
 974         * mi/mi-cmds.c: Define new MI command -complete.
 975         * NEWS: Mention new -complete command.
 976
 977 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 978
 979         * completer.h (complete): New function.
 980         * completer.c (complete): Likewise.
 981         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 982         function defined in completer.h.
 983
 984 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 985
 986         * MAINTAINERS (Write After Approval): Add myself.
 987
 988 2019-05-17  Tom de Vries  <tdevries@suse.de>
 989
 990         PR gdb/24094
 991         * dwarf2read.c (struct cu_partial_die_info): New struct.
 992         (find_partial_die): Return cu_partial_die_info.
 993         (partial_die_parent_scope, guess_partial_die_structure_name)
 994         (partial_die_info::fixup): Handle new return type of find_partial_die.
 995
 996 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 997
 998         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 999         "std::string", simplifying the algorithm.
1000
1001 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1002
1003         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1004         (stap_static_probe_ops::get_probes): Likewise.
1005
1006 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1007
1008         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1009         '-')" and "else if".
1010         (stap_parse_single_operand): Join checks for
1011         "gdbarch_stap_parse_special_token_p" and
1012         "gdbarch_stap_parse_special_token" in the same "if" statement.
1013         Invert check when verifying for operation on register
1014         displacement.
1015
1016 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1017
1018         * stap-probe.c (stap_get_opcode): Update comment.
1019         (stap_get_expected_argument_type): Likewise.
1020         (handle_stap_probe): Likewise.
1021
1022 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1023
1024         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1025         return type to 'bool'.  Adjust comment.  Use 'bool' when
1026         appropriate.
1027         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1028         * stap-probe.c (stap_parse_argument_1): Likewise.
1029         (stap_is_operator): Likewise.
1030         (stap_is_generic_prefix): Likewise.
1031         (stap_is_register_prefix): Likewise.
1032         (stap_is_register_indirection_prefix): Likewise.
1033         (stap_is_integer_prefix): Likewise.
1034         (stap_generic_check_suffix): Likewise.
1035         (stap_check_integer_suffix): Likewise.
1036         (stap_check_register_suffix): Likewise.
1037         (stap_check_register_indirection_suffix): Likewise.
1038         (stap_parse_register_operand): Likewise.
1039         (stap_parse_single_operand): Likewise.
1040         (stap_parse_argument_1): Likewise.
1041         (stap_probe::get_argument_count): Likewise.
1042         (stap_is_operator): Likewise.
1043
1044 2019-05-16  Tom Tromey  <tromey@adacore.com>
1045
1046         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1047         keyword to foreach.
1048
1049 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1050
1051         * linux-thread-db.c (try_thread_db_load_1): Change return type
1052         to bool.
1053         (try_thread_db_load): Likewise.
1054         (try_thread_db_load_from_pdir_1): Likewise.
1055         (try_thread_db_load_from_pdir): Likewise.
1056         (try_thread_db_load_from_sdir): Likewise.
1057         (try_thread_db_load_from_dir): Likewise.
1058         (thread_db_load_search): Likewise.
1059         (has_libpthread): Likewise.
1060         (thread_db_load): Likewise.
1061
1062 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1063
1064         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1065         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1066         NULL, and complain/return if that's the case.
1067
1068 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1069
1070         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1071         (advance, posn, abstract_read_memory): New functions.
1072         [struct mem_read_abstraction]: New struct.
1073         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1074
1075 2019-05-14  Tom Tromey  <tromey@adacore.com>
1076
1077         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1078         value is not lval_memory.
1079
1080 2019-05-14  Tom Tromey  <tromey@adacore.com>
1081
1082         * solib.c (info_sharedlibrary_command): Style the file name.
1083
1084 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1085
1086         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1087         (aarch64_vnv_type): Likewise.
1088         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1089         * common/tdesc.c: Likewise.
1090         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1091         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1092         * features/aarch64-fpu.xml: Add ieee half view.
1093         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1094         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1095         * gdbtypes.h (struct builtin_type): Likewise.
1096         (struct objfile_type): Likewise.
1097
1098 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1099
1100         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1101         typo.
1102         * location.h (string_to_event_location): Likewise.
1103
1104 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1105
1106         GDB 8.3 released.
1107
1108 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1109
1110         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1111         New variable declaration.
1112         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1113         New variable.
1114         (print_one_breakpoint): Use ui_out::test_flags and new global
1115         variable to compute use_fixed_output.
1116         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1117         Remove.
1118         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1119         (mi_multi_location_breakpoint_output_fixed): Remove.
1120         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1121         new variable.
1122         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1123         fix_multi_location_breakpoint_output flag if version >= 3.
1124         * ui-out.h (enum ui_out_flag)
1125         <fix_multi_location_breakpoint_output>: New enumerator.
1126
1127 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1128
1129         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1130
1131 2019-05-10  Tom Tromey  <tromey@adacore.com>
1132
1133         * ada-lang.c (catch_ada_completer): New function.
1134         (_initialize_ada_language): Use it.
1135
1136 2019-05-10  Tom Tromey  <tromey@adacore.com>
1137
1138         * thread.c (print_thread_info): Make "requested_threads" const.
1139         * gdbthread.h (print_thread_info): Make "requested_threads"
1140         const.
1141         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1142         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1143
1144 2019-05-08  Tom Tromey  <tom@tromey.com>
1145
1146         * gdbtypes.c (objfile_type_data): Change type.
1147         (objfile_type, _initialize_gdbtypes): Update.
1148
1149 2019-05-08  Tom Tromey  <tom@tromey.com>
1150
1151         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1152         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1153         (_initialize_dwarf2_frame): Update.
1154
1155 2019-05-08  Tom Tromey  <tom@tromey.com>
1156
1157         * objc-lang.c (objc_objfile_data): Change type.
1158         (find_methods): Update.
1159         (_initialize_objc_lang): Remove.
1160
1161 2019-05-08  Tom Tromey  <tom@tromey.com>
1162
1163         * stabsread.c (rs6000_builtin_type_data): Change type.
1164         (rs6000_builtin_type, _initialize_stabsread): Update.
1165
1166 2019-05-08  Tom Tromey  <tom@tromey.com>
1167
1168         * mips-tdep.c (mips_pdr_data): Remove.
1169         (_initialize_mips_tdep): Update.
1170
1171 2019-05-08  Tom Tromey  <tom@tromey.com>
1172
1173         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1174         (hppa_init_objfile_priv_data, read_unwind_info)
1175         (find_unwind_entry, _initialize_hppa_tdep): Update.
1176
1177 2019-05-08  Tom Tromey  <tom@tromey.com>
1178
1179         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1180         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1181         on obstack.
1182         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1183
1184 2019-05-08  Tom Tromey  <tom@tromey.com>
1185
1186         * mdebugread.c (basic_type_data): Change type.
1187         (basic_type, _initialize_mdebugread): Update.
1188
1189 2019-05-08  Tom Tromey  <tom@tromey.com>
1190
1191         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1192
1193 2019-05-08  Tom Tromey  <tom@tromey.com>
1194
1195         * nto-tdep.c (nto_inferior_data_reg): Change type.
1196         (nto_inferior_data): Update.
1197         (nto_inferior_data_cleanup, nto_new_inferior_data)
1198         (_initialize_nto_tdep): Remove.
1199         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1200
1201 2019-05-08  Tom Tromey  <tom@tromey.com>
1202
1203         * ada-lang.c (struct ada_inferior_data): Add initializers.
1204         (ada_inferior_data): Change type.
1205         (ada_inferior_data_cleanup): Remove.
1206         (get_ada_inferior_data, ada_inferior_exit)
1207         (struct ada_pspace_data): Add initializers, destructor.
1208         (ada_pspace_data_handle): Change type.
1209         (get_ada_pspace_data): Update.
1210         (ada_pspace_data_cleanup): Remove.
1211
1212 2019-05-08  Tom Tromey  <tom@tromey.com>
1213
1214         * coffread.c (struct coff_symfile_info): Add initializers.
1215         (coff_objfile_data_key): Move lower.  Change type.
1216         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1217         Update.
1218         (coff_free_info): Remove.
1219
1220 2019-05-08  Tom Tromey  <tom@tromey.com>
1221
1222         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1223         (fbsd_pspace_data_handle): Move lower.  Change type.
1224         (get_fbsd_pspace_data): Update.
1225         (fbsd_pspace_data_cleanup): Remove.
1226         (_initialize_fbsd_tdep): Update.
1227
1228 2019-05-08  Tom Tromey  <tom@tromey.com>
1229
1230         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1231         (get_ada_tasks_pspace_data): Update.
1232         (ada_tasks_pspace_data_cleanup): Remove.
1233         (_initialize_tasks): Update.
1234         (ada_tasks_inferior_data_handle): Change type.
1235         (get_ada_tasks_inferior_data): Update.
1236         (ada_tasks_inferior_data_cleanup): Remove.
1237         (struct ada_tasks_pspace_data): Add initializers.
1238
1239 2019-05-08  Tom Tromey  <tom@tromey.com>
1240
1241         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1242         * symfile-debug.c (debug_sym_get_probes): Change type.
1243         * stap-probe.c (handle_stap_probe):
1244         (stap_static_probe_ops::get_probes): Change type.
1245         * probe.h (class static_probe_ops) <get_probes>: Change type.
1246         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1247         (parse_probes_in_pspace): Update.
1248         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1249         Update.
1250         (any_static_probe_ops::get_probes): Change type.
1251         * elfread.c (elfread_data): New typedef.
1252         (probe_key): Change type.
1253         (elf_get_probes): Likewise.  Update.
1254         (probe_key_free): Remove.
1255         (_initialize_elfread): Update.
1256         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1257         Change type.
1258         (dtrace_process_dof_probe, dtrace_process_dof)
1259         (dtrace_static_probe_ops::get_probe): Change type.
1260
1261 2019-05-08  Tom Tromey  <tom@tromey.com>
1262
1263         * xcoffread.c (struct xcoff_symfile_info): Rename from
1264         coff_symfile_info.  Add initializers.
1265         (xcoff_objfile_data_key): Move lower.  Change type.
1266         (XCOFF_DATA): Rewrite.
1267         (xcoff_free_info): Remove.
1268         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1269         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1270         (xcoff_initial_scan): Update.
1271
1272 2019-05-08  Tom Tromey  <tom@tromey.com>
1273
1274         * solib-svr4.c (struct svr4_info): Add initializers and
1275         destructor.
1276         <probes_table>: Now an htab_up.
1277         (solib_svr4_pspace_data): Change type.
1278         (free_probes_table): Simplify.
1279         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1280         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1281         (probes_table_remove_objfile_probes, register_solib_event_probe)
1282         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1283         (_initialize_svr4_solib): Update.
1284
1285 2019-05-08  Tom Tromey  <tom@tromey.com>
1286
1287         * remote.c (remote_pspace_data): Change type.
1288         (remote_pspace_data_cleanup): Remove.
1289         (get_remote_exec_file, set_pspace_remote_exec_file)
1290         (_initialize_remote): Update.
1291
1292 2019-05-08  Tom Tromey  <tom@tromey.com>
1293
1294         * breakpoint.c (breakpoint_objfile_key): Change type.
1295         (get_breakpoint_objfile_data): Update.
1296         (free_breakpoint_objfile_data): Remove.
1297         (_initialize_breakpoint): Update.
1298
1299 2019-05-08  Tom Tromey  <tom@tromey.com>
1300
1301         * linux-tdep.c (struct linux_info): Add initializers.
1302         (linux_inferior_data): Move.  Change type.
1303         (invalidate_linux_cache_inf): Update.
1304         (linux_inferior_data_cleanup): Remove.
1305         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1306
1307 2019-05-08  Tom Tromey  <tom@tromey.com>
1308
1309         * auxv.c (auxv_inferior_data): Move.  Change type.
1310         (auxv_inferior_data_cleanup): Remove.
1311         (invalidate_auxv_cache_inf): Rewrite.
1312         (get_auxv_inferior_data, _initialize_auxv): Update.
1313
1314 2019-05-08  Tom Tromey  <tom@tromey.com>
1315
1316         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1317         (symfile_debug_objfile_data_key): Change type.
1318         (symfile_debug_installed, debug_qf_has_symbols)
1319         (debug_qf_find_last_source_symtab)
1320         (debug_qf_forget_cached_source_info)
1321         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1322         (debug_qf_print_stats, debug_qf_dump)
1323         (debug_qf_expand_symtabs_for_function)
1324         (debug_qf_expand_all_symtabs)
1325         (debug_qf_expand_symtabs_with_fullname)
1326         (debug_qf_map_matching_symbols)
1327         (debug_qf_expand_symtabs_matching)
1328         (debug_qf_find_pc_sect_compunit_symtab)
1329         (debug_qf_map_symbol_filenames)
1330         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1331         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1332         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1333         (debug_sym_read_linetable, debug_sym_relocate): Update.
1334         (symfile_debug_free_objfile): Remove.
1335         (install_symfile_debug_logging, _initialize_symfile_debug):
1336         Update.
1337
1338 2019-05-08  Tom Tromey  <tom@tromey.com>
1339
1340         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1341         allocate_on_obstack.
1342         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1343         (get_dwarf2_per_objfile): Update.
1344         (set_dwarf2_per_objfile): Remove.
1345         (dwarf2_has_info, dwarf2_get_section_info): Update.
1346         (dwarf2_free_objfile): Remove.
1347         (_initialize_dwarf2_read): Update.
1348
1349 2019-05-08  Tom Tromey  <tom@tromey.com>
1350
1351         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1352         initializers.
1353         <unsupported_script_warning_printed,
1354         script_not_found_warning_printed>: Now bool.
1355         (auto_load_pspace_data): Change type.
1356         (~auto_load_pspace_info): Rename from
1357         auto_load_pspace_data_cleanup.
1358         (get_auto_load_pspace_data, init_loaded_scripts_info)
1359         (clear_section_scripts, maybe_print_unsupported_script_warning)
1360         (maybe_print_script_not_found_warning, _initialize_auto_load):
1361         Update.
1362
1363 2019-05-08  Tom Tromey  <tom@tromey.com>
1364
1365         * objfiles.c (objfile_pspace_info): Add destructor and
1366         initializers.
1367         (objfiles_pspace_data): Change type.
1368         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1369         (get_objfile_pspace_data): Update.
1370         (objfiles_bfd_data): Change type.
1371         (get_objfile_bfd_data): Update.
1372         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1373
1374 2019-05-08  Tom Tromey  <tom@tromey.com>
1375
1376         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1377         Change type.
1378         (get_catch_syscall_inferior_data): Update.
1379         (catch_syscall_inferior_data_cleanup): Remove.
1380         (_initialize_break_catch_syscall): Update.
1381
1382 2019-05-08  Tom Tromey  <tom@tromey.com>
1383
1384         * inflow.c (struct terminal_info): Add destructor and
1385         initializers.
1386         (inflow_inferior_data): Change type.
1387         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1388         (get_inflow_inferior_data, inflow_inferior_exit)
1389         (swap_terminal_info, _initialize_inflow): Update.
1390
1391 2019-05-08  Tom Tromey  <tom@tromey.com>
1392
1393         * target-dcache.c (target_dcache_cleanup): Remove.
1394         (target_dcache_aspace_key): Change type.
1395         (target_dcache_init_p, target_dcache_invalidate)
1396         (target_dcache_get, target_dcache_get_or_init)
1397         (_initialize_target_dcache): Update.
1398         * dcache.h (struct dcache_deleter): New.
1399
1400 2019-05-08  Tom Tromey  <tom@tromey.com>
1401
1402         * symtab.c (struct symbol_cache): Add destructor and
1403         initializers.
1404         (symbol_cache_key): Move.  Change type.
1405         (make_symbol_cache, free_symbol_cache): Remove.
1406         (get_symbol_cache): Update.
1407         (symbol_cache_cleanup): Remove.
1408         (ALL_PSPACES, symbol_cache_flush)
1409         (maintenance_print_symbol_cache)
1410         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1411         Update.
1412
1413 2019-05-08  Tom Tromey  <tom@tromey.com>
1414
1415         * symtab.c (struct main_info): Add destructor and initializers.
1416         (main_progspace_key): Move.  Change type.
1417         (get_main_info): Update.
1418         (main_info_cleanup): Remove.
1419         (_initialize_symtab): Update.
1420
1421 2019-05-08  Tom Tromey  <tom@tromey.com>
1422
1423         * registry.h (DECLARE_REGISTRY): Define the _key class.
1424
1425 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * NEWS: Merge two 'New commands' sections.
1428
1429 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1430
1431         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1432         parameter and use Ada language definition instead.
1433         (ada_val_print_ptr): Remove unused language parameter.
1434         (ada_val_print_num): Remove language parameter and use Ada language
1435         definition instead.
1436         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1437         parameter.
1438         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1439         parameter and use Ada language definition instead.
1440         (ada_val_print_1): Update all ada_val_print_xxx calls.
1441         Remove language parameter.
1442         (ada_val_print): Update ada_val_print_1 call.
1443
1444 2019-05-08  Tom Tromey  <tromey@adacore.com>
1445
1446         * remote.c (remote_hw_watchpoint_limit)
1447         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1448         Now static.
1449
1450 2019-05-08  Tom Tromey  <tromey@adacore.com>
1451
1452         * maint.c (_initialize_maint_cmds): Move initialization code to
1453         remote.c.
1454         (watchdog, show_watchdog): Move to remote.c.
1455         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1456         "watchdog" static.
1457         (_initialize_remote): Move initialization code from maint.c.
1458         * defs.h (watchdog): Don't declare.
1459
1460 2019-05-08  Tom Tromey  <tromey@adacore.com>
1461
1462         * tui/tui-interp.c: Include main.h.
1463         * interps.c: Include main.h.
1464         * main.h (interpreter_p): Declare.
1465         * defs.h (interpreter_p): Don't declare.
1466
1467 2019-05-08  Tom Tromey  <tromey@adacore.com>
1468
1469         * dwarf2loc.c: Include dwarf2read.h.
1470         * defs.h (read_unsigned_leb128): Don't declare.
1471         * dwarf2read.h (read_unsigned_leb128): Declare.
1472
1473 2019-05-08  Tom Tromey  <tromey@adacore.com>
1474
1475         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1476         method.
1477
1478 2019-05-08  Tom Tromey  <tromey@adacore.com>
1479
1480         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1481         when no wrap column is set.
1482
1483 2019-05-08  Tom Tromey  <tromey@adacore.com>
1484
1485         * c-lang.c (c_get_string): Handle non-C-style arrays.
1486
1487 2019-05-08  Tom Tromey  <tromey@adacore.com>
1488
1489         * typeprint.c (print_offset_data::update): Print the bit offset,
1490         not the number of bits remaining.
1491
1492 2019-05-08  Tom Tromey  <tromey@adacore.com>
1493
1494         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1495         padding at end of comment.
1496
1497 2019-05-08  Tom Tromey  <tromey@adacore.com>
1498
1499         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1500         Compare main types.
1501
1502 2019-05-06  Tom Tromey  <tom@tromey.com>
1503
1504         * common/scoped_mmap.c: Include common-defs.h.
1505         * common/scoped_mmap.h: Don't include config.h.
1506
1507 2019-05-04  Tom Tromey  <tom@tromey.com>
1508
1509         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1510         (struct aarch64_call_info): Add initializers.
1511         <si>: Now a std::vector.
1512         (pass_on_stack, aarch64_push_dummy_call): Update.
1513
1514 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1515             Tom Tromey  <tom@tromey.com>
1516
1517         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1518         (ppc_threads): Now a std::vector.  Now static.
1519         (hwdebug_find_thread_points_by_tid)
1520         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1521         Update.
1522
1523 2019-05-04  Tom Tromey  <tom@tromey.com>
1524
1525         * arc-tdep.c (arc_tdesc_init): Return bool.
1526
1527 2019-05-04  Tom Tromey  <tom@tromey.com>
1528
1529         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1530         Use gdb_assert_not_reached.
1531
1532 2019-05-04  Tom Tromey  <tom@tromey.com>
1533
1534         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1535         "false".
1536
1537 2019-05-04  Tom Tromey  <tom@tromey.com>
1538
1539         * arc-tdep.c (arc_tdesc_init): Use bool.
1540
1541 2019-05-04  Tom Tromey  <tom@tromey.com>
1542
1543         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1544
1545 2019-05-04  Tom Tromey  <tom@tromey.com>
1546
1547         * cli/cli-cmds.c (valid_command_p): Return bool.
1548
1549 2019-05-04  Tom Tromey  <tom@tromey.com>
1550
1551         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1552         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1553
1554 2019-05-04  Raul Tambre  <raul@tambre.ee>
1555
1556         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1557         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1558         operator for comparison.
1559
1560 2019-05-04  Tom Tromey  <tom@tromey.com>
1561
1562         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1563         (lookup_partial_symbol, print_partial_symbols)
1564         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1565         (psymbol_compare): Update.
1566         (add_psymbol_to_bcache): Clear the entire psymbol.
1567         (maintenance_check_psymtabs): Update.
1568         * psympriv.h (struct partial_symbol): Don't derive from
1569         general_symbol_info.
1570         <obj_section, unrelocated_address, address,
1571         set_unrelocated_address>: Update.
1572         <ginfo>: New member.
1573         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1574         (debug_names::write_psymbols): Update.
1575
1576 2019-05-04  Tom de Vries  <tdevries@suse.de>
1577
1578         * contrib/cc-with-tweaks.sh: Support -n arg.
1579
1580 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1581
1582         * corelow.c (core_target::detach): Ensure frame cache and
1583         register caches are cleared.
1584         inferior.c (exit_inferior_1): Likewise.
1585
1586 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1587             Tom Tromey  <tom@tromey.com>
1588
1589         * dictionary.c (collate_pending_symbols_by_language): Remove
1590         "struct" from foreach.
1591         * symtab.c (lookup_global_symbol_from_objfile)
1592         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1593         foreach.
1594         * ser-tcp.c (net_open): Remove "struct" from foreach.
1595         * objfiles.c (objfile_relocate, objfile_rebase)
1596         (objfile_has_symbols): Remove "struct" from foreach.
1597         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1598         from foreach.
1599         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1600         foreach.
1601         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1602         "struct" from foreach.
1603         * ada-lang.c (create_excep_cond_exprs)
1604         (ada_exception_catchpoint_cond_string): Remove "struct" from
1605         foreach.
1606
1607 2019-05-03  Tom Tromey  <tromey@adacore.com>
1608
1609         * ada-exp.y (convert_char_literal): Check suffix of each
1610         enumerator.
1611
1612 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1613
1614         PR ada/21406:
1615         * ada-exp.y (yywrap): Don't define.
1616         * ada-lex.l (%option): Add noyywrap
1617         (yywrap): Remove.
1618
1619 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1620
1621         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1622         _WIN32_WINNT to the XP level, unless already defined to a higher
1623         level.
1624
1625         * unittests/parse-connection-spec-selftests.c:
1626         * ser-tcp.c:
1627         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1628         override.
1629
1630         * symfile.c (find_separate_debug_file): Remove colon from the
1631         drive spec of DOS/Windows file names of the target, so that the
1632         file name produced from DEBUGDIR and the target's directory will
1633         be valid on DOS/Windows systems.
1634
1635 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * rust-lang.c (val_print_struct): Handle printing structures
1638         containing strings.
1639
1640 2019-05-02  Tom Tromey  <tromey@adacore.com>
1641
1642         * valarith.c (_initialize_valarith): Remove.
1643
1644 2019-05-01  Tom Tromey  <tromey@adacore.com>
1645
1646         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1647         bitfields.
1648
1649 2019-05-01  Tom Tromey  <tromey@adacore.com>
1650
1651         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1652         for big-endian copies.
1653
1654 2019-04-30  Ali Tamur  <tamur@google.com>
1655         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1656         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1657         (read_3_bytes): New function.
1658
1659 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1660
1661         * windows-nat.c (main_thread_id): Delete.
1662         (handle_output_debug_string): Replace main_thread_id by
1663         current_event.dwThreadId.
1664         (fake_create_process): Likewise.
1665         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1666         Do not set main_thread_id.
1667         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1668         current_event.dwThreadId.
1669         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1670
1671 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1672
1673         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1674         Use current_event.dwThreadId instead of main_thread_id.
1675
1676 2019-04-30  Tom Tromey  <tromey@adacore.com>
1677
1678         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1679         (create_excep_cond_exprs): Iterate over program spaces.
1680         (ada_exception_catchpoint_cond_string): Examine all minimal
1681         symbols for exception types.
1682
1683 2019-04-30  Tom Tromey  <tromey@adacore.com>
1684
1685         PR c++/24470:
1686         * dwarf2read.c (process_structure_scope): Handle case where type
1687         has template parameters but no symbol was created.
1688
1689 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1690             Chris January  <chris.january@arm.com>
1691
1692         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1693         qualifier.
1694         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1695
1696 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * f-typeprint.c (f_print_type): Update rules for printing
1699         whitespace.
1700         (f_type_print_varspec_suffix): Likewise.
1701
1702 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1703             Chris January  <chris.january@arm.com>
1704
1705         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1706         function arguments.
1707
1708 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * f-lang.c (build_fortran_types): Change name of void type to
1711         lower case.
1712         * f-typeprint.c (f_type_print_base): Print the name of the void
1713         type, rather than a fixed string.
1714         * f-valprint.c (f_decorations): Use lower case void string.
1715
1716 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1717             Chris January  <chris.january@arm.com>
1718
1719         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1720         types for Fortran.
1721
1722 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1723             Chris January  <chris.january@arm.com>
1724             David Lecomber  <david.lecomber@arm.com>
1725
1726         * f-exp.y (BINOP_INTRINSIC): New token.
1727         (exp): New parser rule handling BINOP_INTRINSIC.
1728         (f77_keywords): Add new builtin procedures.
1729         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1730         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1731         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1732         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1733         (print_unop_subexp_f): New function.
1734         (print_binop_subexp_f): New function.
1735         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1736         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1737         (dump_subexp_body_f): Likewise.
1738         (operator_check_f): Likewise.
1739         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1740         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1741
1742 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1743
1744         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1745         UNOP_KIND.
1746         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1747         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1748         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1749         (operator_length_f): New fuction.
1750         (print_subexp_f): New function.
1751         (op_name_f): New function.
1752         (dump_subexp_body_f): New function.
1753         (operator_check_f): New function.
1754         (exp_descriptor_f): Replace standard expression handling functions
1755         with new functions.
1756         * gdb/fortran-operator.def: New file.
1757         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1758         * gdb/std-operator.def: Remove UNOP_KIND.
1759
1760 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * std-operator.def: Remove unbalanced, stray double quote
1763         character.
1764
1765 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1766             Chris January  <chris.january@arm.com>
1767             Daniel Everett  <daniel.everett@arm.com>
1768             Nick Forrington  <nick.forrington@arm.com>
1769             Richard Bunt  <richard.bunt@arm.com>
1770
1771         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1772         of depth when printing anonymous structs or unions.
1773         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1774         Don't print either the top-level value, or the children if the
1775         max-depth is exceeded.
1776         (ppscm_print_children): When printing the key of a map, allow one
1777         extra level of depth.
1778         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1779         print either the top-level value, or the children if the max-depth
1780         is exceeded.
1781         (print_children): When printing the key of a map, allow one extra
1782         level of depth.
1783         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1784         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1785         (user_print_options): Initialise max_depth field.
1786         (val_print_scalar_or_string_type_p): New function.
1787         (val_print): Check to see if the max depth has been reached.
1788         (val_print_check_max_depth): Define new function.
1789         (show_print_max_depth): New function.
1790         (_initialize_valprint): Add 'print max-depth' option.
1791         * valprint.h (struct value_print_options) <max_depth>: New field.
1792         (val_print_check_max_depth): Declare new function.
1793         * NEWS: Document new feature.
1794
1795 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1796
1797         * ada-lang.c (ada_language_defn): Initialise new field.
1798         * c-lang.c (c_is_string_type_p): New function.
1799         (c_language_defn): Initialise new field.
1800         (cplus_language_defn): Initialise new field.
1801         (asm_language_defn): Initialise new field.
1802         (minimal_language_defn): Initialise new field.
1803         * c-lang.h (c_is_string_type_p): Declare new function.
1804         * d-lang.c (d_language_defn): Initialise new field.
1805         * f-lang.c (f_is_string_type_p): New function.
1806         (f_language_defn): Initialise new field.
1807         * go-lang.c (go_is_string_type_p): New function.
1808         (go_language_defn): Initialise new field.
1809         * language.c (default_is_string_type_p): New function.
1810         (unknown_language_defn): Initialise new field.
1811         (auto_language_defn): Initialise new field.
1812         * language.h (struct language_defn) <la_is_string_type_p>: New
1813         member variable.
1814         (default_is_string_type_p): Declare new function.
1815         * m2-lang.c (m2_language_defn): Initialise new field.
1816         * objc-lang.c (objc_language_defn): Initialise new field.
1817         * opencl-lang.c (opencl_language_defn): Initialise new field.
1818         * p-lang.c (pascal_is_string_type_p): New function.
1819         (pascal_language_defn): Initialise new field.
1820         * rust-lang.c (rust_is_string_type_p): New function.
1821         (rust_language_defn): Initialise new field.
1822
1823 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1824
1825         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1826         New field.
1827         * ada-lang.c (ada_language_defn): Initialise new field.
1828         * c-lang.c (c_language_defn): Likewise.
1829         (cplus_language_defn): Likewise.
1830         (asm_language_defn): Likewise.
1831         (minimal_language_defn): Likewise.
1832         * d-lang.c (d_language_defn): Likewise.
1833         * f-lang.c (f_language_defn): Likewise.
1834         * go-lang.c (go_language_defn): Likewise.
1835         * language.c (unknown_language_defn): Likewise.
1836         (auto_language_defn): Likewise.
1837         * m2-lang.c (m2_language_defn): Likewise.
1838         * objc-lang.c (objc_language_defn): Likewise.
1839         * opencl-lang.c (opencl_language_defn): Likewise.
1840         * p-lang.c (pascal_language_defn): Likewise.
1841         * rust-lang.c (rust_language_defn): Likewise.
1842
1843 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1844
1845         * ada-lang.c (ada_is_character_type): Change return type to bool.
1846         (ada_is_string_type): Likewise.
1847         * ada-lang.h (ada_is_character_type): Update declaration
1848         (ada_is_string_type): Likewise.
1849
1850 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         Support style in 'frame|thread apply'
1853
1854         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1855         * record.c (record_start, record_stop): Update callers of
1856         execute_command_to_string with false.
1857         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1858         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1859         methods.
1860         (class string_file): New constructor with term_out parameter.
1861         Override methods term_out and can_emit_style_escape.  New member
1862         term_out.
1863         (class stdio_file): Override can_emit_style_escape.
1864         (class tee_file): Override term_out and can_emit_style_escape.
1865         * utils.h (can_emit_style_escape): Remove.
1866         * utils.c (can_emit_style_escape): Likewise.
1867         Update all callers of can_emit_style_escape (SOMESTREAM) to
1868         SOMESTREAM->can_emit_style_escape.
1869         * source-cache.c (source_cache::get_source_lines): Likewise.
1870         * stack.c (frame_apply_command_count): Call execute_command_to_string
1871         passing the term_out characteristic of the current gdb_stdout.
1872         * thread.c (thr_try_catch_cmd): Likewise.
1873         * top.c (execute_command_to_string): pass term_out parameter
1874         to construct the string_file for the command output.
1875         * ui-file.c (term_cli_styling): New function (most code moved
1876         from utils.c can_emit_style_escape).
1877         (string_file::string_file, string_file::can_emit_style_escape,
1878         stdio_file::can_emit_style_escape, tee_file::term_out,
1879         tee_file::can_emit_style_escape): New functions.
1880
1881 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1882
1883         * NEWS: Mention the new set|show may-call-functions.
1884         * infcall.c (may_call_functions_p): New variable.
1885         (show_may_call_functions_p): New function.
1886         (call_function_by_hand_dummy): Throws an error if not
1887         may-call-functions.
1888         (_initialize_infcall): Call add_setshow_boolean_cmd for
1889         may-call-functions.
1890
1891 2019-04-25  Keith Seitz  <keiths@redhat.com>
1892
1893         PR c++/24367
1894         * cp-support.c (inspect_type): Don't attempt substitutions
1895         of symbol with the same name.
1896
1897 2019-04-25  Tom Tromey  <tromey@adacore.com>
1898
1899         PR gdb/24475:
1900         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1901         static.
1902
1903 2019-04-25  Tom Tromey  <tromey@adacore.com>
1904
1905         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1906         rvalue reference.
1907         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1908         (gdb_xml_parser::parse): Use std::move.
1909         * python/python-internal.h (gdbpy_convert_exception): Take a const
1910         reference.
1911         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1912         std::move.
1913         * python/py-utils.c (gdbpy_convert_exception): Take a const
1914         reference.
1915         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1916         Use std::move.
1917         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1918         Use std::move.
1919         * mi/mi-main.c (mi_print_exception): Take a const reference.
1920         * main.c (handle_command_errors): Take a const reference.
1921         * linespec.c (parse_linespec): Use std::move.
1922         * infcall.c (run_inferior_call): Use std::move.
1923         (call_function_by_hand_dummy): Use std::move.
1924         * exec.c (try_open_exec_file): Use std::move.
1925         * exceptions.h (exception_print, exception_fprintf)
1926         (exception_print_same): Update.
1927         * exceptions.c (print_exception, exception_print)
1928         (exception_fprintf, exception_print_same): Change parameters to
1929         const reference.
1930         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1931         * common/new-op.c: Use std::move.
1932         * common/common-exceptions.h (struct gdb_exception): Add move
1933         constructor.
1934         (struct gdb_exception_error, struct gdb_exception_quit, struct
1935         gdb_quit_bad_alloc): Change constructor to move constructor.
1936         (throw_exception): Change parameter to rvalue reference.
1937         * common/common-exceptions.c (throw_exception): Take rvalue
1938         reference.
1939         * cli/cli-interp.c (safe_execute_command): Use std::move.
1940         * breakpoint.c (insert_bp_location, location_to_sals): Use
1941         std::move.
1942
1943 2019-04-25  Tom Tromey  <tromey@adacore.com>
1944
1945         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1946         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1947         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1948         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1949         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1950         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1951         guile/scm-value.c: Use unpack.
1952         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1953         gdbscm_gdb_exception.
1954         (gdbscm_throw_gdb_exception): Likewise.
1955         (struct gdbscm_gdb_exception): New.
1956         (unpack): New function.
1957         (gdbscm_wrap): Use unpack.
1958
1959 2019-04-25  Tom Tromey  <tromey@adacore.com>
1960
1961         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1962         (gdb_rl_callback_handler): Use std::move.
1963         * common/common-exceptions.h (struct gdb_exception): Add move
1964         assignment operator.
1965         (throw_exception_sjlj): Change "exception" to const reference.
1966         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1967         (throw_exception_sjlj): Change "exception" to const reference.
1968
1969 2019-04-25  Tom Tromey  <tromey@adacore.com>
1970
1971         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1972         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1973         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1974         Update.
1975         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1976         Update.
1977         * mi/mi-interp.c (mi_interp::exec): Update.
1978         * linespec.c (parse_linespec): Update.
1979         * infcall.c (run_inferior_call): Update.
1980         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1981         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1982         (gdbscm_lookup_global_symbol): Update.
1983         * guile/scm-param.c (gdbscm_parameter_value): Update.
1984         * guile/scm-frame.c (gdbscm_frame_read_register)
1985         (gdbscm_frame_read_var): Update.
1986         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1987         * exec.c (try_open_exec_file): Update.
1988         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1989         (gdb_rl_callback_handler): Update.
1990         * common/common-exceptions.h (exception_none): Don't declare.
1991         * common/common-exceptions.c (exception_none): Don't define.
1992         (struct catcher) <exception>: Update.
1993         * cli/cli-interp.c (safe_execute_command): Update.
1994         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1995
1996 2019-04-25  Ali Tamur  <tamur@google.com>
1997
1998         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1999         (read_attribute_value): Likewise.
2000         (dwarf2_read_addr_index): Update comment.
2001         (read_str_index): Add DW_FORM_strx.
2002         (dwarf2_string_attr): Likewise.
2003         (dwarf2_const_value_attr): Likewise.
2004         (dump_die_shallow): Likewise.
2005         (dwarf2_fetch_constant_bytes): Likewise.
2006         (skip_form_bytes): Likewise.
2007         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2008
2009 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2010
2011         PR corefiles/11608
2012         PR corefiles/18187
2013         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2014         OFFSET.  Verify if current mapping contains an ELF header.
2015         (linux_find_memory_regions_full): Adjust call to
2016         dump_mapping_p.
2017
2018 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2019             Kang Li <kanglictf@gmail.com>
2020
2021         PR gdb/21600
2022
2023         * dwarf2-frame.c (read_initial_length): Be consistent about using
2024         unsigned representation of length.
2025         (decode_frame_entry_1): Likewise.  Check for wraparound of
2026         end pointer as well as buffer overflow.
2027
2028 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2029
2030         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2031         "vq".
2032
2033 2019-04-24  Tom Tromey  <tromey@adacore.com>
2034
2035         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2036
2037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * s12z-tdep.c (s12z_unwind_pc): Delete.
2040         (s12z_unwind_sp): Delete.
2041         (s12z_gdbarch_init): Don't register deleted functions with
2042         gdbarch.
2043
2044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2045
2046         * rl78-tdep.c (rl78_unwind_sp): Delete.
2047         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2048
2049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2052         (xstormy16_unwind_pc): Delete.
2053         (xstormy16_dummy_id): Delete.
2054         (xstormy16_gdbarch_init): Don't register deleted functions with
2055         gdbarch.
2056
2057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * vax-tdep.c (vax_unwind_pc): Delete.
2060         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2061
2062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * v850-tdep.c (v850_unwind_sp): Delete.
2065         (v850_unwind_pc): Delete.
2066         (v850_dummy_id): Delete.
2067         (v850_gdbarch_init): Don't register deleted functions with
2068         gdbarch.
2069
2070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2071
2072         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2073         (tilegx_unwind_pc): Delete.
2074         (tilegx_unwind_dummy_id): Delete.
2075         (tilegx_gdbarch_init): Don't register deleted functions with
2076         gdbarch.
2077
2078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2081         (tic6x_dummy_id): Delete.
2082         (tic6x_gdbarch_init): Don't register deleted functions with
2083         gdbarch.
2084
2085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * sparc-tdep.c (sparc_unwind_pc): Delete.
2088         (sparc32_gdbarch_init): Don't register deleted function with
2089         gdbarch.
2090
2091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * sh-tdep.c (sh_unwind_sp): Delete.
2094         (sh_unwind_pc): Delete.
2095         (sh_dummy_id): Delete.
2096         (sh_gdbarch_init): Don't register deleted functions with
2097         gdbarch.
2098
2099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * score-tdep.c (score_unwind_sp): Delete.
2102         (score_unwind_pc): Delete.
2103         (score_dummy_id): Delete.
2104         (score_gdbarch_init): Don't register deleted functions with
2105         gdbarch.
2106
2107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         * rx-tdep.c (rx_unwind_pc): Delete.
2110         (rx_unwind_sp): Delete.
2111         (rx_dummy_id): Delete.
2112         (rx_gdbarch_init): Don't register deleted functions with
2113         gdbarch.  Update comment.
2114
2115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2118         (rs6000_dummy_id): Delete.
2119         (rs6000_gdbarch_init): Don't register deleted functions with
2120         gdbarch.
2121
2122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * or1k-tdep.c (or1k_dummy_id): Delete.
2125         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2126
2127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * nios2-tdep.c (nios2_dummy_id): Delete.
2130         (nios2_unwind_sp): Delete.
2131         (nios2_gdbarch_init): Don't register deleted functions with
2132         gdbarch.
2133
2134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * nds32-tdep.c (nds32_dummy_id): Delete.
2137         (nds32_unwind_pc): Delete.
2138         (nds32_unwind_sp): Delete.
2139         (nds32_gdbarch_init): Don't register deleted functions with
2140         gdbarch.
2141
2142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2143
2144         * msp430-tdep.c (msp430_unwind_pc): Delete.
2145         (msp430_unwind_sp): Delete.
2146         (msp430_dummy_id): Delete.
2147         (msp430_gdbarch_init): Don't register deleted functions with
2148         gdbarch.
2149
2150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * moxie-tdep.c (moxie_unwind_sp): Delete.
2153         (moxie_unwind_pc): Delete.
2154         (moxie_dummy_id): Delete.
2155         (moxie_gdbarch_init): Don't register deleted functions with
2156         gdbarch.
2157
2158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2159
2160         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2161         (mn10300_unwind_pc): Delete.
2162         (mn10300_unwind_sp): Delete.
2163         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2164         mn10300_unwind_sp.
2165         (mn10300_frame_unwind_init): Don't register deleted functions with
2166         gdbarch.
2167
2168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * mep-tdep.c (mep_unwind_pc): Delete.
2171         (mep_unwind_sp): Delete.
2172         (mep_dummy_id): Delete.
2173         (mep_gdbarch_init): Don't register deleted functions with
2174         gdbarch.
2175
2176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2179         (m68hc11_unwind_sp): Delete.
2180         (m68hc11_gdbarch_init): Don't register deleted functions with
2181         gdbarch.
2182
2183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * m32r-tdep.c (m32r_unwind_sp): Delete.
2186         (m32r_unwind_pc): Delete.
2187         (m32r_dummy_id): Delete.
2188         (m32r_gdbarch_init): Don't register deleted functions with
2189         gdbarch.
2190
2191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2192
2193         * m32c-tdep.c (m32c_unwind_pc): Delete.
2194         (m32c_unwind_sp): Delete.
2195         (m32c_dummy_id): Delete.
2196         (m32c_gdbarch_init): Don't register deleted functions with
2197         gdbarch.
2198
2199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2202         (lm32_unwind_pc): Delete.
2203         (lm32_dummy_id): Delete.
2204         (lm32_gdbarch_init): Don't register deleted functions with
2205         gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2210         (iq2000_unwind_pc): Delete.
2211         (iq2000_dummy_id): Delete.
2212         (iq2000_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * nds32-tdep.c (nds32_type_align): Delete.
2218         (nds32_push_dummy_call): Use type_align instead.
2219
2220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * arm-tdep.c (arm_type_align): Only handle vector override case.
2223         (arm_push_dummy_call): Use type_align.
2224         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2225
2226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2229         case.
2230         (pass_on_stack): Use type_align.
2231         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2232         function.
2233
2234 2019-04-23  Tom Tromey  <tromey@adacore.com>
2235
2236         * dwarf2read.c (line_header::file_name_at): Remove unused
2237         overload.
2238
2239 2019-04-23  Tom de Vries  <tdevries@suse.de>
2240
2241         PR gdb/24438
2242         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2243         invocation.
2244
2245
2246 2019-03-27  Ali Tamur  <tamur@google.com>
2247
2248         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2249         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2250         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2251         (dwarf_expr_context::get_addr_index): Likewise
2252         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2253         (symbol_needs_eval_context::get_addr_index): Likewise
2254         (disassemble_dwarf_expression): Add DW_OP_addrx
2255         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2256         (read_cutu_die_from_dwo): Update comment
2257         (skip_one_die): Add DW_FORM_addrx
2258         (read_attribute_value): Likewise
2259         (var_decode_location): Add DW_OP_addrx
2260         (dwarf2_const_value_attr): Add DW_FORM_addrx
2261         (dump_die_shallow): Likewise
2262         (dwarf2_fetch_constant_bytes): Likewise
2263         (decode_locdesc): Add DW_OP_addrx
2264         (skip_form_bytes): Add DW_FORM_addrx
2265
2266 2019-04-22  Ali Tamur  <tamur@google.com>
2267
2268         * MAINTAINERS (Write After Approval): Add self.
2269
2270 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2271
2272         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2273         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2274         (open_symbol_file_object): Likewise.
2275         (svr4_default_sos): Add info parameter.
2276         (svr4_read_so_list): Likewise.
2277         (svr4_current_sos_direct): Adjust functions calls to pass down
2278         info.
2279         (svr4_current_sos_1): Add info parameter.
2280         (svr4_current_sos): Call get_svr4_info, pass info down to
2281         svr4_current_sos_1.
2282         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2283         get_svr4_info.
2284         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2285         get_svr4_info.
2286         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2287         to get_svr4_info.
2288         (probes_table_remove_objfile_probes): Likewise.
2289         (register_solib_event_probe): Add info parameter.
2290         (solist_update_incremental): Pass info parameter down to
2291         svr4_read_so_list.
2292         (disable_probes_interface): Add info parameter.
2293         (svr4_handle_solib_event): Pass current_program_space to
2294         get_svr4_info.  Adjust disable_probes_interface cleanup.
2295         (svr4_create_probe_breakpoints): Add info parameter, pass it
2296         down to register_solib_event_probe.
2297         (svr4_create_solib_event_breakpoints): Add info parameter,
2298         pass it down to svr4_create_probe_breakpoints.
2299         (enable_break): Pass info down to
2300         svr4_create_solib_event_breakpoints.
2301         (svr4_solib_create_inferior_hook): Pass current_program_space to
2302         get_svr4_info.
2303         (svr4_clear_solib): Likewise.
2304
2305 2019-04-22  Pedro Alves  <palves@redhat.com>
2306
2307         * solib-svr4.c (svr4_free_objfile_observer): New.
2308         (probe_and_action::objfile): New field.
2309         (probes_table_htab_remove_objfile_probes)
2310         (probes_table_remove_objfile_probes): New functions.
2311         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2312         in the new probe_and_action.  Don't store the probe in 'lookup'.
2313         (svr4_create_probe_breakpoints): Pass objfile to
2314         register_solib_event_probe.
2315         (_initialize_svr4_solib): Register a free_objfile observer.
2316
2317 2019-04-19  Tom Tromey  <tom@tromey.com>
2318
2319         * common/queue.h: Remove.
2320
2321 2019-04-19  Tom Tromey  <tom@tromey.com>
2322
2323         * event-loop.c: Don't include "common/queue.h".
2324
2325 2019-04-19  Tom Tromey  <tom@tromey.com>
2326
2327         * remote.c (remote_target): Use delete.
2328         * remote-notif.h: Include <list>, not "common/queue.h".
2329         (notif_client_p): Remove typedef.
2330         (remote_notif_state): Add constructor, destructor, initializer.
2331         <notif_queue>: Now a std::list.
2332         (remote_notif_state_xfree): Don't declare.
2333         * remote-notif.c (remote_notif_process, handle_notification)
2334         (remote_notif_state_allocate): Update.
2335         (~remote_notif_state): Rename from remote_notif_state_xfree.
2336
2337 2019-04-19  Tom Tromey  <tom@tromey.com>
2338
2339         * symfile.c (reread_symbols): Update.
2340         * objfiles.c (objfile_register_static_link)
2341         (objfile_lookup_static_link): Update
2342         (~objfile) Don't delete static_links.
2343         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2344
2345 2019-04-19  Tom Tromey  <tom@tromey.com>
2346
2347         * type-stack.h (struct type_stack) <insert>: Constify string.
2348         * type-stack.c (type_stack::insert): Constify string.
2349         * gdbtypes.h (lookup_template_type): Update.
2350         (address_space_name_to_int): Update.
2351         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2352         const.
2353         (lookup_template_type): Make name const.
2354         * c-exp.y: Update rules.
2355         (lex_one_token, classify_name, classify_inner_name)
2356         (c_print_token): Update.
2357         * p-exp.y: Update rules.
2358         (yylex): Update.
2359         * f-exp.y: Update rules.
2360         (yylex): Update.
2361         * d-exp.y: Update rules.
2362         (lex_one_token, classify_name, classify_inner_name): Update.
2363         * parse.c (write_dollar_variable, copy_name): Return std::string.
2364         * parser-defs.h (copy_name): Change return type.
2365         * m2-exp.y: Update rules.
2366         (yylex): Update.
2367         * go-exp.y (lex_one_token): Update.
2368         Update rules.
2369         (classify_unsafe_function, classify_packaged_name)
2370         (classify_name, yylex): Update.
2371
2372 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2373
2374         * configure.ac: add --enable-source-highlight switch.
2375         * configure: Regenerate.
2376         * top.c (print_gdb_version): plumb --enable-source-highlight
2377         status to "show configuration".
2378
2379 2019-04-19  Tom Tromey  <tromey@adacore.com>
2380
2381         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2382         Check ADA_TYPE_P.
2383         (empty_record, ada_template_to_fixed_record_type_1)
2384         (template_to_static_fixed_type)
2385         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2386         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2387         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2388         macros.
2389
2390 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2391
2392         PR symtab/24423:
2393         * source.c (print_source_lines_base): Advance "iter" when a
2394         control character is seen.
2395
2396 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2397
2398         * inferior.h (struct infcall_suspend_state_deleter):
2399         Catch exception in destructor to avoid crash.
2400
2401 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2402
2403         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2404         close to the add_com "shell".
2405
2406 2019-04-18  Tom Tromey  <tromey@adacore.com>
2407
2408         * process-stratum-target.h (class process_stratum_target)
2409         <stratum>: Add "final".
2410
2411 2019-04-17  Tom Tromey  <tromey@adacore.com>
2412
2413         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2414         against nullptr before use.
2415
2416 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2417
2418         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2419
2420 2019-04-17  Jim Wilson  <jimw@sifive.com>
2421             Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2424         code read might fail, assume 4-byte breakpoint in that case.
2425
2426 2019-04-15  Leszek Swirski  <leszeks@google.com>
2427
2428         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2429         rather than a hand-rolled POD check when checking for forced MEMORY
2430         classification.
2431
2432 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2433
2434         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2435         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2436         function.
2437         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2438         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2439         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2440         declaration.
2441
2442 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * aarch64-linux-nat.c
2445         (aarch64_linux_nat_target::thread_architecture): Add override.
2446         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2447         each VQ.
2448
2449 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2450
2451         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2452
2453 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2456         target types of size 96-bits, add some additional comments, and
2457         check that the builtin type we found was the correct size.
2458
2459 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2460
2461         * utils.c (prompt_for_continue): Don't restore the styling at the
2462         end, as applied_style has the wrong value.  This fixes styling in
2463         long lists of file names that are interrupted by the "Continue?"
2464         prompt.
2465
2466 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2467
2468         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2469         * c-lang.c (c_language_defn): Likewise.
2470         (cplus_language_defn): Likewise.
2471         (asm_language_defn): Likewise.
2472         (minimal_language_defn): Likewise.
2473         * d-lang.c (d_language_defn): Likewise.
2474         * f-lang.c (f_language_defn): Likewise.
2475         * go-lang.c (go_language_defn): Likewise.
2476         * language.c (unknown_language_defn): Likewise.
2477         (auto_language_defn): Likewise.
2478         * language.h (struct language_defn): Remove la_magic field.
2479         (LANG_MAGIC): Delete.
2480         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2481         * objc-lang.c (objc_language_defn): Likewise.
2482         * opencl-lang.c (opencl_language_defn): Likewise.
2483         * p-lang.c (pascal_language_defn): Likewise.
2484         * rust-lang.c (rust_language_defn): Likewise.
2485
2486 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * riscv-tdep.c (riscv_type_align): New function.
2489         (riscv_type_alignment): Delete.
2490         (riscv_arg_location): Use 'type_align'.
2491         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2492
2493 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * gdbtypes.c (type_align): A struct with no non-static fields also
2496         has alignment of 1.
2497
2498 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2501         component to 0.
2502         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2503         member.
2504         (riscv_struct_info::analyse): New implementation using new
2505         analyse_inner member function.
2506         (riscv_struct_info::field_offset): New member function.
2507         (riscv_struct_info::m_offsets): New member variable.
2508         (riscv_struct_info::analyse_inner): New private member function,
2509         takes the old implementation of riscv_struct_info::analyse but
2510         extended to track field offsets.
2511         (riscv_call_arg_struct): Update the struct folding special cases
2512         to handle cases where empty C++ structs, which are non-zero
2513         length, are found.
2514         (riscv_arg_location): Initialise the length of each location, a
2515         non-zero length now indicates the location is in use.
2516         (riscv_push_dummy_call): Allow for the first location having a
2517         non-zero offset when setting up arguments.
2518         (riscv_return_value): Likewise, but for return values.
2519
2520 2019-04-11  Tom Tromey  <tromey@adacore.com>
2521
2522         * utils.c (internal_vproblem): Make "msg" const.
2523
2524 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2527         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2528         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2529         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2530
2531 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2532
2533         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2534         function.
2535         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2536         of amd64_collect_native_gregset.
2537         (amd64_linux_nat_target::store_registers): Likewise.
2538
2539 2019-04-10  Tom Tromey  <tom@tromey.com>
2540
2541         * symtab.c (lookup_global_symbol_from_objfile)
2542         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2543         * objfiles.h (class separate_debug_iterator): New.
2544         (class separate_debug_range): New.
2545         (struct objfile) <separate_debug_objfiles>: New method.
2546         (objfile_separate_debug_iterate): Don't declare.
2547         * objfiles.c (separate_debug_iterator::operator++): Rename from
2548         objfile_separate_debug_iterate.
2549         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2550         iterator.
2551         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2552         iterator.
2553
2554 2019-04-10  Tom Tromey  <tom@tromey.com>
2555
2556         * symfile.c (reread_symbols): Remove old comment.
2557         * objfiles.c (free_all_objfiles): Fix a typo.
2558
2559 2019-04-10  Tom Tromey  <tom@tromey.com>
2560
2561         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2562         * minsyms.c (lookup_minimal_symbol): Use foreach.
2563         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2564         (lookup_minimal_symbol_solib_trampoline): Likewise.
2565         * symfile.c (reread_symbols): Use foreach.
2566
2567 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2568             Tom Tromey  <tromey@adacore.com>
2569
2570         PR rust/24414:
2571         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2572         (rust_lex_int_test): Change "value" to be LONGEST.
2573         (rust_lex_tests): Add test for long integer literal.
2574
2575 2019-04-09  Tom Tromey  <tromey@adacore.com>
2576
2577         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2578         to bool.
2579         (extended_remote_target::attach): Update.
2580         (remote_target::remote_notice_new_inferior): Update.
2581         (remote_target::add_current_inferior_and_thread): Update.
2582         * inferior.c (exit_inferior_1): Use "false".
2583         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2584
2585 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2586
2587         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2588         the "start" command.
2589
2590 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2591
2592         * python/py-inferior.c (infpy_thread_from_thread_handle):
2593         Adjust comments to reflect renaming of thread_from_thread_handle
2594         to thread_from_handle.  Adjust keywords.  Fix type error message.
2595         (inferior_object_methods): Add thread_from_handle.  Retain
2596         thread_from_thread_handle, but mark it as deprecated.
2597
2598 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2599
2600         * gdbthread.h (find_thread_by_handle): Revise declaration.
2601         * thread.c (find_thread_by_handle): Likewise.  Adjust
2602         implementation too.
2603         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2604         support for buffer objects as handles.
2605
2606 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2607
2608         * python/py-infthread.c (thpy_thread_handle): New function.
2609         (thread_object_methods): Register thpy_thread_handle.
2610
2611 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2612
2613         * gdbthread.h (thread_to_thread_handle): Declare.
2614         * thread.c (gdbtypes.h): Include.
2615         (thread_to_thread_handle): New function.
2616
2617         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2618         (target_thread_info_to_thread_handle): Declare.
2619         * target.c (target_thread_info_to_thread_handle): New function.
2620         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2621         * target-delegates.c: Regenerate.
2622
2623         * linux-thread-db.c (class thread_db_target): Add method
2624         thread_info_to_thread_handle.
2625         (thread_db_target::thread_info_to_thread_handle): Define.
2626         * remote.c (class remote_target): Add new method
2627         thread_info_to_thread_handle.
2628         (remote_target::thread_info_to_thread_handle): Define.
2629
2630 2019-04-08  Pedro Alves  <palves@redhat.com>
2631
2632         * common/common-exceptions.c (throw_exception): Don't create
2633         named object to throw; throw directly.
2634         (throw_it): Likewise.  Don't initialize gdb_exception::message
2635         here, with new; pass FMT and AP to the ctor instead.
2636         * common/common-exceptions.h: Include <string>.
2637         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2638         const char *, va_list)): New ctor.  Use std::make_shared.
2639         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2640         errors)): Delete.
2641         (gdb_exception_error::gdb_exception_error(enum errors, const char
2642         *, va_list)): New.
2643         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2644         Add assertion.
2645         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2646         errors)): Delete.
2647         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2648         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2649         Add assertion.
2650
2651 2019-04-08  Tom Tromey  <tom@tromey.com>
2652
2653         * valops.c (value_rtti_indirect_type): Replace throw_exception
2654         with throw.
2655         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2656         with throw.
2657         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2658         throw.
2659         * target.c (target_translate_tls_address): Replace throw_exception
2660         with throw.
2661         * stack.c (frame_apply_command_count): Replace throw_exception
2662         with throw.
2663         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2664         throw.
2665         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2666         with throw.
2667         * rs6000-tdep.c (rs6000_frame_cache)
2668         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2669         * remote.c: Replace throw_exception with throw.
2670         * record-full.c (record_full_message, record_full_wait_1)
2671         (record_full_restore): Replace throw_exception with throw.
2672         * record-btrace.c:
2673         (get_thread_current_frame_id, record_btrace_start_replaying)
2674         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2675         (cmd_record_btrace_start): Replace throw_exception with throw.
2676         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2677         throw.
2678         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2679         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2680         * linespec.c:
2681         (find_linespec_symbols): Replace throw_exception with throw.
2682         * infrun.c (displaced_step_prepare, resume): Replace
2683         throw_exception with throw.
2684         * infcmd.c (post_create_inferior): Replace throw_exception with
2685         throw.
2686         * inf-loop.c (inferior_event_handler): Replace throw_exception
2687         with throw.
2688         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2689         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2690         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2691         (get_prev_frame_always, get_frame_pc_if_available)
2692         (get_frame_address_in_block_if_available, get_frame_language):
2693         Replace throw_exception with throw.
2694         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2695         throw_exception with throw.
2696         * eval.c (fetch_subexp_value, evaluate_var_value)
2697         (evaluate_funcall, evaluate_subexp_standard): Replace
2698         throw_exception with throw.
2699         * dwarf2loc.c (call_site_find_chain)
2700         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2701         Replace throw_exception with throw.
2702         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2703         with throw.
2704         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2705         throw.
2706         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2707         * completer.c (complete_line_internal): Replace throw_exception
2708         with throw.
2709         * compile/compile-object-run.c (compile_object_run): Replace
2710         throw_exception with throw.
2711         * cli/cli-script.c (process_next_line): Replace throw_exception
2712         with throw.
2713         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2714         (btrace_enable, btrace_maint_update_pt_packets): Replace
2715         throw_exception with throw.
2716         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2717         throw_exception with throw.
2718         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2719         throw_exception with throw.
2720         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2721         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2722         * aarch64-tdep.c (aarch64_make_prologue_cache)
2723         (aarch64_make_stub_cache): Replace throw_exception with throw.
2724
2725 2019-04-08  Tom Tromey  <tom@tromey.com>
2726
2727         * common/common-exceptions.c (throw_exception): Rename from
2728         throw_exception_cxx.  Remove old copy.  Make argument const.
2729         (throw_it): Create and throw exception objects directly.
2730         * common/common-exceptions.h (throw_exception): Make argument
2731         const.
2732         (struct gdb_exception_error): Add constructor.
2733         (struct gdb_exception_quit): Add constructor.
2734
2735 2019-04-08  Tom Tromey  <tom@tromey.com>
2736
2737         * common/common-exceptions.h (exception_rethrow): Don't declare.
2738         (TRY_SJLJ): Update comment.
2739         (TRY, CATCH, END_CATCH): Remove.
2740         * common/common-exceptions.c (exception_rethrow): Remove.
2741
2742 2019-04-08  Tom Tromey  <tom@tromey.com>
2743
2744         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2745         Remove.
2746         (gdb_exception_error): Rename from
2747         gdb_exception_RETURN_MASK_ERROR.
2748         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2749         (gdb_quit_bad_alloc): Update.
2750         * aarch64-tdep.c: Update.
2751         * ada-lang.c: Update.
2752         * ada-typeprint.c: Update.
2753         * ada-valprint.c: Update.
2754         * amd64-tdep.c: Update.
2755         * arch-utils.c: Update.
2756         * break-catch-throw.c: Update.
2757         * breakpoint.c: Update.
2758         * btrace.c: Update.
2759         * c-varobj.c: Update.
2760         * cli/cli-cmds.c: Update.
2761         * cli/cli-interp.c: Update.
2762         * cli/cli-script.c: Update.
2763         * common/common-exceptions.c: Update.
2764         * common/new-op.c: Update.
2765         * common/selftest.c: Update.
2766         * compile/compile-c-symbols.c: Update.
2767         * compile/compile-cplus-symbols.c: Update.
2768         * compile/compile-object-load.c: Update.
2769         * compile/compile-object-run.c: Update.
2770         * completer.c: Update.
2771         * corelow.c: Update.
2772         * cp-abi.c: Update.
2773         * cp-support.c: Update.
2774         * cp-valprint.c: Update.
2775         * darwin-nat.c: Update.
2776         * disasm-selftests.c: Update.
2777         * dtrace-probe.c: Update.
2778         * dwarf-index-cache.c: Update.
2779         * dwarf-index-write.c: Update.
2780         * dwarf2-frame-tailcall.c: Update.
2781         * dwarf2-frame.c: Update.
2782         * dwarf2loc.c: Update.
2783         * dwarf2read.c: Update.
2784         * eval.c: Update.
2785         * event-loop.c: Update.
2786         * event-top.c: Update.
2787         * exec.c: Update.
2788         * f-valprint.c: Update.
2789         * fbsd-tdep.c: Update.
2790         * frame-unwind.c: Update.
2791         * frame.c: Update.
2792         * gdbtypes.c: Update.
2793         * gnu-v3-abi.c: Update.
2794         * guile/guile-internal.h: Update.
2795         * guile/scm-block.c: Update.
2796         * guile/scm-breakpoint.c: Update.
2797         * guile/scm-cmd.c: Update.
2798         * guile/scm-disasm.c: Update.
2799         * guile/scm-frame.c: Update.
2800         * guile/scm-lazy-string.c: Update.
2801         * guile/scm-math.c: Update.
2802         * guile/scm-param.c: Update.
2803         * guile/scm-ports.c: Update.
2804         * guile/scm-pretty-print.c: Update.
2805         * guile/scm-symbol.c: Update.
2806         * guile/scm-symtab.c: Update.
2807         * guile/scm-type.c: Update.
2808         * guile/scm-value.c: Update.
2809         * i386-linux-tdep.c: Update.
2810         * i386-tdep.c: Update.
2811         * inf-loop.c: Update.
2812         * infcall.c: Update.
2813         * infcmd.c: Update.
2814         * infrun.c: Update.
2815         * jit.c: Update.
2816         * language.c: Update.
2817         * linespec.c: Update.
2818         * linux-fork.c: Update.
2819         * linux-nat.c: Update.
2820         * linux-tdep.c: Update.
2821         * linux-thread-db.c: Update.
2822         * main.c: Update.
2823         * mi/mi-cmd-break.c: Update.
2824         * mi/mi-cmd-stack.c: Update.
2825         * mi/mi-interp.c: Update.
2826         * mi/mi-main.c: Update.
2827         * objc-lang.c: Update.
2828         * p-valprint.c: Update.
2829         * parse.c: Update.
2830         * ppc-linux-tdep.c: Update.
2831         * printcmd.c: Update.
2832         * python/py-arch.c: Update.
2833         * python/py-breakpoint.c: Update.
2834         * python/py-cmd.c: Update.
2835         * python/py-finishbreakpoint.c: Update.
2836         * python/py-frame.c: Update.
2837         * python/py-framefilter.c: Update.
2838         * python/py-gdb-readline.c: Update.
2839         * python/py-inferior.c: Update.
2840         * python/py-infthread.c: Update.
2841         * python/py-lazy-string.c: Update.
2842         * python/py-linetable.c: Update.
2843         * python/py-objfile.c: Update.
2844         * python/py-param.c: Update.
2845         * python/py-prettyprint.c: Update.
2846         * python/py-progspace.c: Update.
2847         * python/py-record-btrace.c: Update.
2848         * python/py-record.c: Update.
2849         * python/py-symbol.c: Update.
2850         * python/py-type.c: Update.
2851         * python/py-unwind.c: Update.
2852         * python/py-utils.c: Update.
2853         * python/py-value.c: Update.
2854         * python/python.c: Update.
2855         * record-btrace.c: Update.
2856         * record-full.c: Update.
2857         * remote-fileio.c: Update.
2858         * remote.c: Update.
2859         * riscv-tdep.c: Update.
2860         * rs6000-aix-tdep.c: Update.
2861         * rs6000-tdep.c: Update.
2862         * rust-exp.y: Update.
2863         * rust-lang.c: Update.
2864         * s390-tdep.c: Update.
2865         * selftest-arch.c: Update.
2866         * solib-dsbt.c: Update.
2867         * solib-frv.c: Update.
2868         * solib-spu.c: Update.
2869         * solib-svr4.c: Update.
2870         * solib.c: Update.
2871         * sparc64-linux-tdep.c: Update.
2872         * stack.c: Update.
2873         * symfile-mem.c: Update.
2874         * symmisc.c: Update.
2875         * target.c: Update.
2876         * thread.c: Update.
2877         * top.c: Update.
2878         * tracefile-tfile.c: Update.
2879         * tui/tui.c: Update.
2880         * typeprint.c: Update.
2881         * unittests/cli-utils-selftests.c: Update.
2882         * unittests/parse-connection-spec-selftests.c: Update.
2883         * valops.c: Update.
2884         * valprint.c: Update.
2885         * value.c: Update.
2886         * varobj.c: Update.
2887         * windows-nat.c: Update.
2888         * x86-linux-nat.c: Update.
2889         * xml-support.c: Update.
2890
2891 2019-04-08  Tom Tromey  <tom@tromey.com>
2892
2893         * xml-support.c: Use C++ exception handling.
2894         * x86-linux-nat.c: Use C++ exception handling.
2895         * windows-nat.c: Use C++ exception handling.
2896         * varobj.c: Use C++ exception handling.
2897         * value.c: Use C++ exception handling.
2898         * valprint.c: Use C++ exception handling.
2899         * valops.c: Use C++ exception handling.
2900         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2901         handling.
2902         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2903         * typeprint.c: Use C++ exception handling.
2904         * tui/tui.c: Use C++ exception handling.
2905         * tracefile-tfile.c: Use C++ exception handling.
2906         * top.c: Use C++ exception handling.
2907         * thread.c: Use C++ exception handling.
2908         * target.c: Use C++ exception handling.
2909         * symmisc.c: Use C++ exception handling.
2910         * symfile-mem.c: Use C++ exception handling.
2911         * stack.c: Use C++ exception handling.
2912         * sparc64-linux-tdep.c: Use C++ exception handling.
2913         * solib.c: Use C++ exception handling.
2914         * solib-svr4.c: Use C++ exception handling.
2915         * solib-spu.c: Use C++ exception handling.
2916         * solib-frv.c: Use C++ exception handling.
2917         * solib-dsbt.c: Use C++ exception handling.
2918         * selftest-arch.c: Use C++ exception handling.
2919         * s390-tdep.c: Use C++ exception handling.
2920         * rust-lang.c: Use C++ exception handling.
2921         * rust-exp.y: Use C++ exception handling.
2922         * rs6000-tdep.c: Use C++ exception handling.
2923         * rs6000-aix-tdep.c: Use C++ exception handling.
2924         * riscv-tdep.c: Use C++ exception handling.
2925         * remote.c: Use C++ exception handling.
2926         * remote-fileio.c: Use C++ exception handling.
2927         * record-full.c: Use C++ exception handling.
2928         * record-btrace.c: Use C++ exception handling.
2929         * python/python.c: Use C++ exception handling.
2930         * python/py-value.c: Use C++ exception handling.
2931         * python/py-utils.c: Use C++ exception handling.
2932         * python/py-unwind.c: Use C++ exception handling.
2933         * python/py-type.c: Use C++ exception handling.
2934         * python/py-symbol.c: Use C++ exception handling.
2935         * python/py-record.c: Use C++ exception handling.
2936         * python/py-record-btrace.c: Use C++ exception handling.
2937         * python/py-progspace.c: Use C++ exception handling.
2938         * python/py-prettyprint.c: Use C++ exception handling.
2939         * python/py-param.c: Use C++ exception handling.
2940         * python/py-objfile.c: Use C++ exception handling.
2941         * python/py-linetable.c: Use C++ exception handling.
2942         * python/py-lazy-string.c: Use C++ exception handling.
2943         * python/py-infthread.c: Use C++ exception handling.
2944         * python/py-inferior.c: Use C++ exception handling.
2945         * python/py-gdb-readline.c: Use C++ exception handling.
2946         * python/py-framefilter.c: Use C++ exception handling.
2947         * python/py-frame.c: Use C++ exception handling.
2948         * python/py-finishbreakpoint.c: Use C++ exception handling.
2949         * python/py-cmd.c: Use C++ exception handling.
2950         * python/py-breakpoint.c: Use C++ exception handling.
2951         * python/py-arch.c: Use C++ exception handling.
2952         * printcmd.c: Use C++ exception handling.
2953         * ppc-linux-tdep.c: Use C++ exception handling.
2954         * parse.c: Use C++ exception handling.
2955         * p-valprint.c: Use C++ exception handling.
2956         * objc-lang.c: Use C++ exception handling.
2957         * mi/mi-main.c: Use C++ exception handling.
2958         * mi/mi-interp.c: Use C++ exception handling.
2959         * mi/mi-cmd-stack.c: Use C++ exception handling.
2960         * mi/mi-cmd-break.c: Use C++ exception handling.
2961         * main.c: Use C++ exception handling.
2962         * linux-thread-db.c: Use C++ exception handling.
2963         * linux-tdep.c: Use C++ exception handling.
2964         * linux-nat.c: Use C++ exception handling.
2965         * linux-fork.c: Use C++ exception handling.
2966         * linespec.c: Use C++ exception handling.
2967         * language.c: Use C++ exception handling.
2968         * jit.c: Use C++ exception handling.
2969         * infrun.c: Use C++ exception handling.
2970         * infcmd.c: Use C++ exception handling.
2971         * infcall.c: Use C++ exception handling.
2972         * inf-loop.c: Use C++ exception handling.
2973         * i386-tdep.c: Use C++ exception handling.
2974         * i386-linux-tdep.c: Use C++ exception handling.
2975         * guile/scm-value.c: Use C++ exception handling.
2976         * guile/scm-type.c: Use C++ exception handling.
2977         * guile/scm-symtab.c: Use C++ exception handling.
2978         * guile/scm-symbol.c: Use C++ exception handling.
2979         * guile/scm-pretty-print.c: Use C++ exception handling.
2980         * guile/scm-ports.c: Use C++ exception handling.
2981         * guile/scm-param.c: Use C++ exception handling.
2982         * guile/scm-math.c: Use C++ exception handling.
2983         * guile/scm-lazy-string.c: Use C++ exception handling.
2984         * guile/scm-frame.c: Use C++ exception handling.
2985         * guile/scm-disasm.c: Use C++ exception handling.
2986         * guile/scm-cmd.c: Use C++ exception handling.
2987         * guile/scm-breakpoint.c: Use C++ exception handling.
2988         * guile/scm-block.c: Use C++ exception handling.
2989         * guile/guile-internal.h: Use C++ exception handling.
2990         * gnu-v3-abi.c: Use C++ exception handling.
2991         * gdbtypes.c: Use C++ exception handling.
2992         * frame.c: Use C++ exception handling.
2993         * frame-unwind.c: Use C++ exception handling.
2994         * fbsd-tdep.c: Use C++ exception handling.
2995         * f-valprint.c: Use C++ exception handling.
2996         * exec.c: Use C++ exception handling.
2997         * event-top.c: Use C++ exception handling.
2998         * event-loop.c: Use C++ exception handling.
2999         * eval.c: Use C++ exception handling.
3000         * dwarf2read.c: Use C++ exception handling.
3001         * dwarf2loc.c: Use C++ exception handling.
3002         * dwarf2-frame.c: Use C++ exception handling.
3003         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3004         * dwarf-index-write.c: Use C++ exception handling.
3005         * dwarf-index-cache.c: Use C++ exception handling.
3006         * dtrace-probe.c: Use C++ exception handling.
3007         * disasm-selftests.c: Use C++ exception handling.
3008         * darwin-nat.c: Use C++ exception handling.
3009         * cp-valprint.c: Use C++ exception handling.
3010         * cp-support.c: Use C++ exception handling.
3011         * cp-abi.c: Use C++ exception handling.
3012         * corelow.c: Use C++ exception handling.
3013         * completer.c: Use C++ exception handling.
3014         * compile/compile-object-run.c: Use C++ exception handling.
3015         * compile/compile-object-load.c: Use C++ exception handling.
3016         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3017         * compile/compile-c-symbols.c: Use C++ exception handling.
3018         * common/selftest.c: Use C++ exception handling.
3019         * common/new-op.c: Use C++ exception handling.
3020         * cli/cli-script.c: Use C++ exception handling.
3021         * cli/cli-interp.c: Use C++ exception handling.
3022         * cli/cli-cmds.c: Use C++ exception handling.
3023         * c-varobj.c: Use C++ exception handling.
3024         * btrace.c: Use C++ exception handling.
3025         * breakpoint.c: Use C++ exception handling.
3026         * break-catch-throw.c: Use C++ exception handling.
3027         * arch-utils.c: Use C++ exception handling.
3028         * amd64-tdep.c: Use C++ exception handling.
3029         * ada-valprint.c: Use C++ exception handling.
3030         * ada-typeprint.c: Use C++ exception handling.
3031         * ada-lang.c: Use C++ exception handling.
3032         * aarch64-tdep.c: Use C++ exception handling.
3033
3034 2019-04-08  Tom Tromey  <tom@tromey.com>
3035
3036         * xml-support.c (gdb_xml_parser::parse): Update.
3037         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3038         * value.c (show_convenience): Update.
3039         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3040         (test_parse_flags_qcs): Update.
3041         * thread.c (thr_try_catch_cmd): Update.
3042         * target.c (target_translate_tls_address): Update.
3043         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3044         (info_frame_command_core, frame_apply_command_count): Update.
3045         * rust-exp.y (rust_lex_exception_test): Update.
3046         * riscv-tdep.c (riscv_print_one_register_info): Update.
3047         * remote.c (remote_target::enable_btrace): Update.
3048         * record-btrace.c (record_btrace_enable_warn): Update.
3049         * python/py-utils.c (gdbpy_convert_exception): Update.
3050         * printcmd.c (do_one_display, print_variable_and_value): Update.
3051         * mi/mi-main.c (mi_print_exception): Update.
3052         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3053         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3054         * linux-nat.c (linux_nat_target::attach): Update.
3055         * linux-fork.c (class scoped_switch_fork_info): Update.
3056         * infrun.c (displaced_step_prepare): Update.
3057         * infcall.c (call_function_by_hand_dummy): Update.
3058         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3059         * gnu-v3-abi.c (print_one_vtable): Update.
3060         * frame.c (get_prev_frame_always): Update.
3061         * f-valprint.c (info_common_command_for_block): Update.
3062         * exec.c (try_open_exec_file): Update.
3063         * exceptions.c (print_exception, exception_print)
3064         (exception_fprintf, exception_print_same): Update.
3065         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3066         * dwarf-index-cache.c (index_cache::store)
3067         (index_cache::lookup_gdb_index): Update.
3068         * darwin-nat.c (maybe_cache_shell): Update.
3069         * cp-valprint.c (cp_print_value_fields): Update.
3070         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3071         (gcc_cplus_symbol_address): Update.
3072         * compile/compile-c-symbols.c (gcc_convert_symbol)
3073         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3074         * common/selftest.c: Update.
3075         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3076         a std::string.
3077         (exception_try_scope_entry, exception_try_scope_exit): Don't
3078         declare.
3079         (struct exception_try_scope): Remove.
3080         (TRY): Don't use exception_try_scope.
3081         (struct gdb_exception): Add constructor, operator=.
3082         <what>: New method.
3083         (struct gdb_exception_RETURN_MASK_ALL)
3084         (struct gdb_exception_RETURN_MASK_ERROR)
3085         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3086         (struct gdb_quit_bad_alloc): Update.
3087         * common/common-exceptions.c (exception_none): Change
3088         initializer.
3089         (struct catcher) <state, exception>: Initialize inline.
3090         <prev>: Remove member.
3091         (current_catcher): Remove.
3092         (catchers): New global.
3093         (exceptions_state_mc_init): Simplify.
3094         (catcher_pop): Remove.
3095         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3096         (try_scope_depth, exception_try_scope_entry)
3097         (exception_try_scope_exit): Remove.
3098         (throw_exception_sjlj): Update.
3099         (exception_messages, exception_messages_size): Remove.
3100         (throw_it): Simplify.
3101         (gdb_exception_sliced_copy): Remove.
3102         (throw_exception_cxx): Update.
3103         * cli/cli-script.c (script_from_file): Update.
3104         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3105         Update.
3106         * ada-valprint.c (ada_val_print): Update.
3107         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3108         (create_excep_cond_exprs): Update.
3109
3110 2019-04-08  Tom Tromey  <tom@tromey.com>
3111
3112         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3113         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3114         (TRY, CATCH, END_CATCH): Remove some definitions.
3115         * common/common-exceptions.c: Don't use GDB_XCPT.
3116         (catcher_list_size): Remove.
3117         (throw_exception, throw_it): Simplify.
3118
3119 2019-04-05  Tom Tromey  <tom@tromey.com>
3120
3121         Revert the header-sorting patch.
3122         * ft32-tdep.c: Revert.
3123         * frv-tdep.c: Revert.
3124         * frv-linux-tdep.c: Revert.
3125         * frame.c: Revert.
3126         * frame-unwind.c: Revert.
3127         * frame-base.c: Revert.
3128         * fork-child.c: Revert.
3129         * findvar.c: Revert.
3130         * findcmd.c: Revert.
3131         * filesystem.c: Revert.
3132         * filename-seen-cache.h: Revert.
3133         * filename-seen-cache.c: Revert.
3134         * fbsd-tdep.c: Revert.
3135         * fbsd-nat.h: Revert.
3136         * fbsd-nat.c: Revert.
3137         * f-valprint.c: Revert.
3138         * f-typeprint.c: Revert.
3139         * f-lang.c: Revert.
3140         * extension.h: Revert.
3141         * extension.c: Revert.
3142         * extension-priv.h: Revert.
3143         * expprint.c: Revert.
3144         * exec.h: Revert.
3145         * exec.c: Revert.
3146         * exceptions.c: Revert.
3147         * event-top.c: Revert.
3148         * event-loop.c: Revert.
3149         * eval.c: Revert.
3150         * elfread.c: Revert.
3151         * dwarf2read.h: Revert.
3152         * dwarf2read.c: Revert.
3153         * dwarf2loc.c: Revert.
3154         * dwarf2expr.h: Revert.
3155         * dwarf2expr.c: Revert.
3156         * dwarf2-frame.c: Revert.
3157         * dwarf2-frame-tailcall.c: Revert.
3158         * dwarf-index-write.h: Revert.
3159         * dwarf-index-write.c: Revert.
3160         * dwarf-index-common.c: Revert.
3161         * dwarf-index-cache.h: Revert.
3162         * dwarf-index-cache.c: Revert.
3163         * dummy-frame.c: Revert.
3164         * dtrace-probe.c: Revert.
3165         * disasm.h: Revert.
3166         * disasm.c: Revert.
3167         * disasm-selftests.c: Revert.
3168         * dictionary.c: Revert.
3169         * dicos-tdep.c: Revert.
3170         * demangle.c: Revert.
3171         * dcache.h: Revert.
3172         * dcache.c: Revert.
3173         * darwin-nat.h: Revert.
3174         * darwin-nat.c: Revert.
3175         * darwin-nat-info.c: Revert.
3176         * d-valprint.c: Revert.
3177         * d-namespace.c: Revert.
3178         * d-lang.c: Revert.
3179         * ctf.c: Revert.
3180         * csky-tdep.c: Revert.
3181         * csky-linux-tdep.c: Revert.
3182         * cris-tdep.c: Revert.
3183         * cris-linux-tdep.c: Revert.
3184         * cp-valprint.c: Revert.
3185         * cp-support.c: Revert.
3186         * cp-namespace.c: Revert.
3187         * cp-abi.c: Revert.
3188         * corelow.c: Revert.
3189         * corefile.c: Revert.
3190         * continuations.c: Revert.
3191         * completer.h: Revert.
3192         * completer.c: Revert.
3193         * complaints.c: Revert.
3194         * coffread.c: Revert.
3195         * coff-pe-read.c: Revert.
3196         * cli-out.h: Revert.
3197         * cli-out.c: Revert.
3198         * charset.c: Revert.
3199         * c-varobj.c: Revert.
3200         * c-valprint.c: Revert.
3201         * c-typeprint.c: Revert.
3202         * c-lang.c: Revert.
3203         * buildsym.c: Revert.
3204         * buildsym-legacy.c: Revert.
3205         * build-id.h: Revert.
3206         * build-id.c: Revert.
3207         * btrace.c: Revert.
3208         * bsd-uthread.c: Revert.
3209         * breakpoint.h: Revert.
3210         * breakpoint.c: Revert.
3211         * break-catch-throw.c: Revert.
3212         * break-catch-syscall.c: Revert.
3213         * break-catch-sig.c: Revert.
3214         * blockframe.c: Revert.
3215         * block.c: Revert.
3216         * bfin-tdep.c: Revert.
3217         * bfin-linux-tdep.c: Revert.
3218         * bfd-target.c: Revert.
3219         * bcache.c: Revert.
3220         * ax-general.c: Revert.
3221         * ax-gdb.h: Revert.
3222         * ax-gdb.c: Revert.
3223         * avr-tdep.c: Revert.
3224         * auxv.c: Revert.
3225         * auto-load.c: Revert.
3226         * arm-wince-tdep.c: Revert.
3227         * arm-tdep.c: Revert.
3228         * arm-symbian-tdep.c: Revert.
3229         * arm-pikeos-tdep.c: Revert.
3230         * arm-obsd-tdep.c: Revert.
3231         * arm-nbsd-tdep.c: Revert.
3232         * arm-nbsd-nat.c: Revert.
3233         * arm-linux-tdep.c: Revert.
3234         * arm-linux-nat.c: Revert.
3235         * arm-fbsd-tdep.c: Revert.
3236         * arm-fbsd-nat.c: Revert.
3237         * arm-bsd-tdep.c: Revert.
3238         * arch-utils.c: Revert.
3239         * arc-tdep.c: Revert.
3240         * arc-newlib-tdep.c: Revert.
3241         * annotate.h: Revert.
3242         * annotate.c: Revert.
3243         * amd64-windows-tdep.c: Revert.
3244         * amd64-windows-nat.c: Revert.
3245         * amd64-tdep.c: Revert.
3246         * amd64-sol2-tdep.c: Revert.
3247         * amd64-obsd-tdep.c: Revert.
3248         * amd64-obsd-nat.c: Revert.
3249         * amd64-nbsd-tdep.c: Revert.
3250         * amd64-nbsd-nat.c: Revert.
3251         * amd64-nat.c: Revert.
3252         * amd64-linux-tdep.c: Revert.
3253         * amd64-linux-nat.c: Revert.
3254         * amd64-fbsd-tdep.c: Revert.
3255         * amd64-fbsd-nat.c: Revert.
3256         * amd64-dicos-tdep.c: Revert.
3257         * amd64-darwin-tdep.c: Revert.
3258         * amd64-bsd-nat.c: Revert.
3259         * alpha-tdep.c: Revert.
3260         * alpha-obsd-tdep.c: Revert.
3261         * alpha-nbsd-tdep.c: Revert.
3262         * alpha-mdebug-tdep.c: Revert.
3263         * alpha-linux-tdep.c: Revert.
3264         * alpha-linux-nat.c: Revert.
3265         * alpha-bsd-tdep.c: Revert.
3266         * alpha-bsd-nat.c: Revert.
3267         * aix-thread.c: Revert.
3268         * agent.c: Revert.
3269         * addrmap.c: Revert.
3270         * ada-varobj.c: Revert.
3271         * ada-valprint.c: Revert.
3272         * ada-typeprint.c: Revert.
3273         * ada-tasks.c: Revert.
3274         * ada-lang.c: Revert.
3275         * aarch64-tdep.c: Revert.
3276         * aarch64-ravenscar-thread.c: Revert.
3277         * aarch64-newlib-tdep.c: Revert.
3278         * aarch64-linux-tdep.c: Revert.
3279         * aarch64-linux-nat.c: Revert.
3280         * aarch64-fbsd-tdep.c: Revert.
3281         * aarch64-fbsd-nat.c: Revert.
3282         * aarch32-linux-nat.c: Revert.
3283
3284 2019-04-05  Tom Tromey  <tom@tromey.com>
3285
3286         * ft32-tdep.c: Sort headers.
3287         * frv-tdep.c: Sort headers.
3288         * frv-linux-tdep.c: Sort headers.
3289         * frame.c: Sort headers.
3290         * frame-unwind.c: Sort headers.
3291         * frame-base.c: Sort headers.
3292         * fork-child.c: Sort headers.
3293         * findvar.c: Sort headers.
3294         * findcmd.c: Sort headers.
3295         * filesystem.c: Sort headers.
3296         * filename-seen-cache.h: Sort headers.
3297         * filename-seen-cache.c: Sort headers.
3298         * fbsd-tdep.c: Sort headers.
3299         * fbsd-nat.h: Sort headers.
3300         * fbsd-nat.c: Sort headers.
3301         * f-valprint.c: Sort headers.
3302         * f-typeprint.c: Sort headers.
3303         * f-lang.c: Sort headers.
3304         * extension.h: Sort headers.
3305         * extension.c: Sort headers.
3306         * extension-priv.h: Sort headers.
3307         * expprint.c: Sort headers.
3308         * exec.h: Sort headers.
3309         * exec.c: Sort headers.
3310         * exceptions.c: Sort headers.
3311         * event-top.c: Sort headers.
3312         * event-loop.c: Sort headers.
3313         * eval.c: Sort headers.
3314         * elfread.c: Sort headers.
3315         * dwarf2read.h: Sort headers.
3316         * dwarf2read.c: Sort headers.
3317         * dwarf2loc.c: Sort headers.
3318         * dwarf2expr.h: Sort headers.
3319         * dwarf2expr.c: Sort headers.
3320         * dwarf2-frame.c: Sort headers.
3321         * dwarf2-frame-tailcall.c: Sort headers.
3322         * dwarf-index-write.h: Sort headers.
3323         * dwarf-index-write.c: Sort headers.
3324         * dwarf-index-common.c: Sort headers.
3325         * dwarf-index-cache.h: Sort headers.
3326         * dwarf-index-cache.c: Sort headers.
3327         * dummy-frame.c: Sort headers.
3328         * dtrace-probe.c: Sort headers.
3329         * disasm.h: Sort headers.
3330         * disasm.c: Sort headers.
3331         * disasm-selftests.c: Sort headers.
3332         * dictionary.c: Sort headers.
3333         * dicos-tdep.c: Sort headers.
3334         * demangle.c: Sort headers.
3335         * dcache.h: Sort headers.
3336         * dcache.c: Sort headers.
3337         * darwin-nat.h: Sort headers.
3338         * darwin-nat.c: Sort headers.
3339         * darwin-nat-info.c: Sort headers.
3340         * d-valprint.c: Sort headers.
3341         * d-namespace.c: Sort headers.
3342         * d-lang.c: Sort headers.
3343         * ctf.c: Sort headers.
3344         * csky-tdep.c: Sort headers.
3345         * csky-linux-tdep.c: Sort headers.
3346         * cris-tdep.c: Sort headers.
3347         * cris-linux-tdep.c: Sort headers.
3348         * cp-valprint.c: Sort headers.
3349         * cp-support.c: Sort headers.
3350         * cp-namespace.c: Sort headers.
3351         * cp-abi.c: Sort headers.
3352         * corelow.c: Sort headers.
3353         * corefile.c: Sort headers.
3354         * continuations.c: Sort headers.
3355         * completer.h: Sort headers.
3356         * completer.c: Sort headers.
3357         * complaints.c: Sort headers.
3358         * coffread.c: Sort headers.
3359         * coff-pe-read.c: Sort headers.
3360         * cli-out.h: Sort headers.
3361         * cli-out.c: Sort headers.
3362         * charset.c: Sort headers.
3363         * c-varobj.c: Sort headers.
3364         * c-valprint.c: Sort headers.
3365         * c-typeprint.c: Sort headers.
3366         * c-lang.c: Sort headers.
3367         * buildsym.c: Sort headers.
3368         * buildsym-legacy.c: Sort headers.
3369         * build-id.h: Sort headers.
3370         * build-id.c: Sort headers.
3371         * btrace.c: Sort headers.
3372         * bsd-uthread.c: Sort headers.
3373         * breakpoint.h: Sort headers.
3374         * breakpoint.c: Sort headers.
3375         * break-catch-throw.c: Sort headers.
3376         * break-catch-syscall.c: Sort headers.
3377         * break-catch-sig.c: Sort headers.
3378         * blockframe.c: Sort headers.
3379         * block.c: Sort headers.
3380         * bfin-tdep.c: Sort headers.
3381         * bfin-linux-tdep.c: Sort headers.
3382         * bfd-target.c: Sort headers.
3383         * bcache.c: Sort headers.
3384         * ax-general.c: Sort headers.
3385         * ax-gdb.h: Sort headers.
3386         * ax-gdb.c: Sort headers.
3387         * avr-tdep.c: Sort headers.
3388         * auxv.c: Sort headers.
3389         * auto-load.c: Sort headers.
3390         * arm-wince-tdep.c: Sort headers.
3391         * arm-tdep.c: Sort headers.
3392         * arm-symbian-tdep.c: Sort headers.
3393         * arm-pikeos-tdep.c: Sort headers.
3394         * arm-obsd-tdep.c: Sort headers.
3395         * arm-nbsd-tdep.c: Sort headers.
3396         * arm-nbsd-nat.c: Sort headers.
3397         * arm-linux-tdep.c: Sort headers.
3398         * arm-linux-nat.c: Sort headers.
3399         * arm-fbsd-tdep.c: Sort headers.
3400         * arm-fbsd-nat.c: Sort headers.
3401         * arm-bsd-tdep.c: Sort headers.
3402         * arch-utils.c: Sort headers.
3403         * arc-tdep.c: Sort headers.
3404         * arc-newlib-tdep.c: Sort headers.
3405         * annotate.h: Sort headers.
3406         * annotate.c: Sort headers.
3407         * amd64-windows-tdep.c: Sort headers.
3408         * amd64-windows-nat.c: Sort headers.
3409         * amd64-tdep.c: Sort headers.
3410         * amd64-sol2-tdep.c: Sort headers.
3411         * amd64-obsd-tdep.c: Sort headers.
3412         * amd64-obsd-nat.c: Sort headers.
3413         * amd64-nbsd-tdep.c: Sort headers.
3414         * amd64-nbsd-nat.c: Sort headers.
3415         * amd64-nat.c: Sort headers.
3416         * amd64-linux-tdep.c: Sort headers.
3417         * amd64-linux-nat.c: Sort headers.
3418         * amd64-fbsd-tdep.c: Sort headers.
3419         * amd64-fbsd-nat.c: Sort headers.
3420         * amd64-dicos-tdep.c: Sort headers.
3421         * amd64-darwin-tdep.c: Sort headers.
3422         * amd64-bsd-nat.c: Sort headers.
3423         * alpha-tdep.c: Sort headers.
3424         * alpha-obsd-tdep.c: Sort headers.
3425         * alpha-nbsd-tdep.c: Sort headers.
3426         * alpha-mdebug-tdep.c: Sort headers.
3427         * alpha-linux-tdep.c: Sort headers.
3428         * alpha-linux-nat.c: Sort headers.
3429         * alpha-bsd-tdep.c: Sort headers.
3430         * alpha-bsd-nat.c: Sort headers.
3431         * aix-thread.c: Sort headers.
3432         * agent.c: Sort headers.
3433         * addrmap.c: Sort headers.
3434         * ada-varobj.c: Sort headers.
3435         * ada-valprint.c: Sort headers.
3436         * ada-typeprint.c: Sort headers.
3437         * ada-tasks.c: Sort headers.
3438         * ada-lang.c: Sort headers.
3439         * aarch64-tdep.c: Sort headers.
3440         * aarch64-ravenscar-thread.c: Sort headers.
3441         * aarch64-newlib-tdep.c: Sort headers.
3442         * aarch64-linux-tdep.c: Sort headers.
3443         * aarch64-linux-nat.c: Sort headers.
3444         * aarch64-fbsd-tdep.c: Sort headers.
3445         * aarch64-fbsd-nat.c: Sort headers.
3446         * aarch32-linux-nat.c: Sort headers.
3447
3448 2019-04-04  Tom Tromey  <tom@tromey.com>
3449
3450         * varobj.c (varobj_create): Update.
3451         * rust-exp.y (struct rust_parser) <update_innermost_block,
3452         lookup_symbol>: New methods.
3453         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3454         Rename.
3455         (rust_parser::rust_lookup_type)
3456         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3457         * printcmd.c (display_command, do_one_display): Update.
3458         * parser-defs.h (struct parser_state) <parser_state>: Add
3459         "tracker" parameter.
3460         (block_tracker): New member.
3461         (class innermost_block_tracker) <innermost_block_tracker>: Add
3462         "types" parameter.
3463         <reset>: Remove method.
3464         (innermost_block): Don't declare.
3465         (null_post_parser): Update.
3466         * parse.c (innermost_block): Remove global.
3467         (write_dollar_variable): Update.
3468         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3469         Remove "tracker_types" parameter.
3470         (parse_expression): Add "tracker" parameter.
3471         (parse_expression_for_completion): Update.
3472         (null_post_parser): Add "tracker" parameter.
3473         * p-exp.y: Update rules.
3474         * m2-exp.y: Update rules.
3475         * language.h (struct language_defn) <la_post_parser>: Add
3476         "tracker" parameter.
3477         * go-exp.y: Update rules.
3478         * f-exp.y: Update rules.
3479         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3480         parameter.
3481         * d-exp.y: Update rules.
3482         * c-exp.y: Update rules.
3483         * breakpoint.c (set_breakpoint_condition): Create an
3484         innermost_block_tracker.
3485         (watch_command_1): Likewise.
3486         * ada-lang.c (resolve): Add "tracker" parameter.
3487         (resolve_subexp): Likewise.
3488         * ada-exp.y (write_var_from_sym): Update.
3489
3490 2019-04-04  Tom Tromey  <tom@tromey.com>
3491
3492         * type-stack.h: New file.
3493         * type-stack.c: New file.
3494         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3495         type-stack.h.
3496         (insert_into_type_stack, insert_type, push_type, push_type_int)
3497         (insert_type_address_space, pop_type, pop_type_int)
3498         (pop_typelist, pop_type_stack, append_type_stack)
3499         (push_type_stack, get_type_stack, push_typelist)
3500         (follow_type_instance_flags, follow_types): Don't declare.
3501         * parse.c (type_stack): Remove global.
3502         (parse_exp_in_context): Update.
3503         (insert_into_type_stack, insert_type, push_type, push_type_int)
3504         (insert_type_address_space, pop_type, pop_type_int)
3505         (pop_typelist, pop_type_stack, append_type_stack)
3506         (push_type_stack, get_type_stack, push_typelist)
3507         (follow_type_instance_flags, follow_types): Remove (moved to
3508         type-stack.c).
3509         * f-exp.y (type_stack): New global.
3510         Update rules.
3511         (push_kind_type, f_parse): Update.
3512         * d-exp.y (type_stack): New global.
3513         Update rules.
3514         (d_parse): Update.
3515         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3516         Update rules.
3517         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3518         (HFILES_NO_SRCDIR): Add type-stack.h.
3519
3520 2019-04-04  Tom Tromey  <tom@tromey.com>
3521
3522         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3523         (rust_parser::convert_ast_to_expression, rust_parse)
3524         (rust_lex_test_completion, rust_lex_tests): Update.
3525         * parser-defs.h (struct expr_completion_state): New.
3526         (struct parser_state) <parser_state>: Add completion parameter.
3527         <mark_struct_expression, mark_completion_tag>: New methods.
3528         <parse_completion, m_completion_state>: New members.
3529         (prefixify_expression, null_post_parser): Update.
3530         (mark_struct_expression, mark_completion_tag): Don't declare.
3531         * parse.c (parse_completion, expout_last_struct)
3532         (expout_tag_completion_type, expout_completion_name): Remove
3533         globals.
3534         (parser_state::mark_struct_expression)
3535         (parser_state::mark_completion_tag): Now methods.
3536         (prefixify_expression): Add last_struct parameter.
3537         (prefixify_subexp): Likewise.
3538         (parse_exp_1): Update.
3539         (parse_exp_in_context): Add cstate parameter.  Update.
3540         (parse_expression_for_completion): Create an
3541         expr_completion_state.
3542         (null_post_parser): Add "completion" parameter.
3543         * p-exp.y: Update rules.
3544         (yylex): Update.
3545         * language.h (struct language_defn) <la_post_parser>: Add
3546         "completing" parameter.
3547         * go-exp.y: Update rules.
3548         (lex_one_token): Update.
3549         * expression.h (parse_completion): Don't declare.
3550         * d-exp.y: Update rules.
3551         (lex_one_token): Update rules.
3552         * c-exp.y: Update rules.
3553         (lex_one_token): Update.
3554         * ada-lang.c (resolve): Add "parse_completion" parameter.
3555         (resolve_subexp): Likewise.
3556         (ada_resolve_function): Likewise.
3557
3558 2019-04-04  Tom Tromey  <tom@tromey.com>
3559
3560         * parser-defs.h (struct parser_state) <start_arglist,
3561         end_arglist>: New methods.
3562         <arglist_len, m_funcall_chain>: New members.
3563         (arglist_len, start_arglist, end_arglist): Don't declare.
3564         * parse.c (arglist_len, funcall_chain): Remove global.
3565         (start_arglist, end_arglist): Remove functions.
3566         (parse_exp_in_context): Update.
3567         * p-exp.y: Update rules.
3568         * m2-exp.y: Update rules.
3569         * go-exp.y: Update rules.
3570         * f-exp.y: Update rules.
3571         * d-exp.y: Update rules.
3572         * c-exp.y: Update rules.
3573
3574 2019-04-04  Tom Tromey  <tom@tromey.com>
3575
3576         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3577         lex_operator, push_back>: New methods.
3578         Update all rules.
3579         (rust_parser::lex_hex, lex_escape): Rename and update.
3580         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3581         (rust_parser::lex_operator): Rename and update.
3582         (rust_parser::lex_number, rustyylex, rustyyerror)
3583         (rust_lex_test_init, rust_lex_test_sequence)
3584         (rust_lex_test_push_back, rust_lex_tests): Update.
3585         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3586         parameter.
3587         <lexptr, prev_lexptr>: New members.
3588         (lexptr, prev_lexptr): Don't declare.
3589         * parse.c (lexptr, prev_lexptr): Remove globals.
3590         (parse_exp_in_context): Update.
3591         * p-exp.y (yylex, yyerror): Update.
3592         * m2-exp.y (parse_number, yylex, yyerror): Update.
3593         * go-exp.y (lex_one_token, yyerror): Update.
3594         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3595         * d-exp.y (lex_one_token, yyerror): Update.
3596         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3597         (lex_one_token, yyerror): Update.
3598         * ada-lex.l (YY_INPUT): Update.
3599         (rewind_to_char): Update.
3600         * ada-exp.y (yyerror): Update.
3601
3602 2019-04-04  Tom Tromey  <tom@tromey.com>
3603
3604         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3605         * parser-defs.h (struct parser_state) <parser_state>: Add new
3606         parameter.
3607         <comma_terminates>: New member.
3608         (comma_terminates): Don't declare global.
3609         * parse.c (comma_terminates): Remove global.
3610         (parse_exp_in_context): Update.
3611         * p-exp.y (yylex): Update.
3612         * m2-exp.y (yylex): Update.
3613         * go-exp.y (lex_one_token): Update.
3614         * f-exp.y (yylex): Update.
3615         * d-exp.y (lex_one_token): Update.
3616         * c-exp.y (lex_one_token): Update.
3617         * ada-lex.l: Update.
3618
3619 2019-04-04  Tom Tromey  <tom@tromey.com>
3620
3621         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3622         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3623         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3624         * parser-defs.h (paren_depth): Don't declare.
3625         * parse.c (paren_depth): Remove global.
3626         (parse_exp_in_context): Update.
3627         * p-exp.y (paren_depth): New global.
3628         (pascal_parse): Initialize it.
3629         * m2-exp.y (paren_depth): New global.
3630         (m2_parse): Initialize it.
3631         * go-exp.y (paren_depth): New global.
3632         (go_parse): Initialize it.
3633         * f-exp.y (paren_depth): New global.
3634         (f_parse): Initialize it.
3635         * d-exp.y (paren_depth): New global.
3636         (d_parse): Initialize it.
3637         * c-exp.y (paren_depth): New global.
3638         (c_parse): Initialize it.
3639         * ada-lex.l (paren_depth): New global.
3640         (lexer_init): Initialize it.
3641
3642 2019-04-04  Tom Tromey  <tom@tromey.com>
3643
3644         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3645         (rust_parser::convert_ast_to_type)
3646         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3647         * parser-defs.h (struct parser_state) <parser_state>: Add
3648         parameters.  Initialize new members.
3649         <expression_context_block, expression_context_pc>: New members.
3650         * parse.c (expression_context_block, expression_context_pc):
3651         Remove globals.
3652         (parse_exp_in_context): Update.
3653         * p-exp.y: Update all rules.
3654         (yylex): Update.
3655         * m2-exp.y: Update all rules.
3656         (yylex): Update.
3657         * go-exp.y (yylex): Update.
3658         * f-exp.y (yylex): Update.
3659         * d-exp.y: Update all rules.
3660         (yylex): Update.
3661         * c-exp.y: Update all rules.
3662         (lex_one_token, classify_name, yylex, c_parse): Update.
3663         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3664
3665 2019-04-04  Tom Tromey  <tom@tromey.com>
3666
3667         * gdbarch.h, gdbarch.c: Rebuild.
3668         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3669         * stap-probe.h:
3670         (struct stap_parse_info): Replace "parser_state" with
3671         "expr_builder".
3672         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3673         (parser_state): New class.
3674         * parse.c (expr_builder): Rename.
3675         (expr_builder::release): Rename.
3676         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3677         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3678         (write_exp_elt_longcst, write_exp_elt_floatcst)
3679         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3680         (write_exp_string_vector, write_exp_bitstring)
3681         (write_exp_msymbol, mark_struct_expression)
3682         (write_dollar_variable)
3683         (insert_type_address_space, increase_expout_size): Replace
3684         "parser_state" with "expr_builder".
3685         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3686         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3687         "parser_state" with "expr_builder".
3688
3689 2019-04-04  Tom Tromey  <tom@tromey.com>
3690
3691         * rust-exp.y: Replace "parse_language" with method call.
3692         * p-exp.y:
3693         (yylex): Replace "parse_language" with method call.
3694         * m2-exp.y:
3695         (yylex): Replace "parse_language" with method call.
3696         * go-exp.y (classify_name): Replace "parse_language" with method
3697         call.
3698         * f-exp.y (yylex): Replace "parse_language" with method call.
3699         * d-exp.y (lex_one_token): Replace "parse_language" with method
3700         call.
3701         * c-exp.y:
3702         (lex_one_token, classify_name, yylex): Replace "parse_language"
3703         with method call.
3704         * ada-exp.y (find_primitive_type, type_char)
3705         (type_system_address): Replace "parse_language" with method call.
3706
3707 2019-04-04  Tom Tromey  <tom@tromey.com>
3708
3709         * rust-exp.y: Replace "parse_gdbarch" with method call.
3710         * parse.c (write_dollar_variable, insert_type_address_space):
3711         Replace "parse_gdbarch" with method call.
3712         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3713         call.
3714         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3715         call.
3716         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3717         "parse_gdbarch" with method call.
3718         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3719         with method call.
3720         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3721         "parse_gdbarch" with method call.
3722         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3723         "parse_gdbarch" with method call.
3724         * c-exp.y (parse_type, parse_number, classify_name): Replace
3725         "parse_gdbarch" with method call.
3726         * ada-lex.l: Replace "parse_gdbarch" with method call.
3727         * ada-exp.y (parse_type, find_primitive_type, type_char)
3728         (type_system_address): Replace "parse_gdbarch" with method call.
3729
3730 2019-04-04  Tom Tromey  <tom@tromey.com>
3731
3732         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3733         * stap-probe.c (stap_parse_argument): Update.
3734         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3735         initial_size parameter.
3736         * rust-exp.y (rust_lex_tests): Update.
3737         * parse.c (parser_state): Update.
3738         (parse_exp_in_context): Update.
3739         * parser-defs.h (struct parser_state) <parser_state>: Remove
3740         "initial_size" parameter.
3741
3742 2019-04-04  Tom Tromey  <tom@tromey.com>
3743
3744         * parser-defs.h (increase_expout_size): Don't declare.
3745         * parse.c (increase_expout_size): Now static.
3746
3747 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3748
3749         * gnu-nat.c (gnu_nat_target::wait): Fix
3750         target_waitstatus_to_string call.
3751
3752 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * eval.c (evaluate_subexp_standard): Handle internal functions
3755         during Fortran function call handling.
3756
3757 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * NEWS: Mention new internal functions.
3760         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3761         (read_base_type): Use dwarf2_init_complex_target_type.
3762         * value.c (creal_internal_fn): New function.
3763         (cimag_internal_fn): New function.
3764         (_initialize_values): Register new internal functions.
3765
3766 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3767
3768         * infrun.c (stop_all_threads): If debug_infrun, always
3769         trace the wait status after wait_one, using
3770         target_waitstatus_to_string and target_pid_to_str.
3771         (handle_inferior_event): Replace various trace of
3772         wait status kind by a single trace.
3773         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3774         wait status kind image by target_waitstatus_to_string.
3775         * target/waitstatus.c (target_waitstatus_to_string): Fix
3776         obsolete comment.
3777
3778 2019-04-01  Tom Tromey  <tromey@adacore.com>
3779
3780         PR symtab/23331:
3781         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3782
3783 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3784             Pedro Alves  <palves@redhat.com>
3785
3786         * top.c (quit_force): Call 'finalize_values'.
3787         * value.c (finalize_values): New function.
3788         * value.h (finalize_values): Declare.
3789
3790 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3791
3792         * NEWS: Announce $_gdb_major and $_gdb_minor.
3793
3794         * top.c (init_gdb_version_vars): New function.
3795         (gdb_init): Call init_gdb_version_vars.
3796
3797 2019-03-29  Tom Tromey  <tromey@adacore.com>
3798
3799         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3800         help text.  Remove dead code.
3801
3802 2019-03-29  Keith Seitz  <keiths@redhat.com>
3803
3804         From Siddhesh Poyarekar:
3805         * f-lang.h (f77_get_upperbound): Return LONGEST.
3806         (f77_get_lowerbound): Likewise.
3807         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3808         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3809         print them.
3810         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3811         plongest to format print it.
3812         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3813         (f77_get_upperbound): Likewise.
3814         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3815         LOWER_BOUND to LONGEST.
3816         (f77_create_arrayprint_offset_tbl): Likewise.
3817
3818 2019-03-29  Keith Seitz  <keiths@redhat.com>
3819
3820         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3821         %s/pulongest for TYPE_LENGTH instead of %d in format
3822         strings.
3823         * ada-typerint.c (ada_print_type): Likewise.
3824         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3825         * compile/compile-c-support.c (generate_register_struct): Likewise.
3826         * gdbtypes.c (recursive_dump_type): Likewise.
3827         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3828         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3829         instead of %d in format strings.
3830         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3831         to std::min to ULONGEST.
3832         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3833         instead of %d in format strings.
3834         * tracepoint.c (info_scope_command): Likewise.
3835         * typeprint.c (print_offset_data::update)
3836         (print_offset_data::finish): Likewise.
3837         * xtensa-tdep.c (xtensa_store_return_value)
3838         (xtensa_push_dummy_call): Likewise.
3839
3840 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3841
3842         * windows-nat.c (display_selector): Fixed format specifications
3843         for 64-bit Cygwin.
3844
3845 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3846
3847         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3848
3849 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3850
3851         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3852         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3853         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3854         (nios2_linux_init_abi): Install it.
3855
3856 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3857
3858         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3859
3860 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3861
3862         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3863
3864 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3865             Tom Tromey  <tromey@adacore.com>
3866
3867         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3868
3869 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3870
3871         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3872         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3873         method to compute the bounds of range types. Also print "[evaluated]"
3874         if the bounds' values come from a dynamic evaluation.
3875
3876 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3879         whitespace when pretty printing is on.
3880
3881 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * ppc-linux-nat.c: Add include.
3884
3885 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3886
3887         * NEWS: Mention AArch64 Pointer Authentication.
3888
3889 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3890
3891         * arm-linux-nat.c: Add include.
3892
3893 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3894
3895         * source-cache.c (source_cache::get_source_lines): Re-read
3896         fullname after calling open_source_file.
3897
3898 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3899
3900         * NEWS: Mention TLS support for FreeBSD.
3901
3902 2019-03-25  Tom Tromey  <tromey@adacore.com>
3903
3904         * minsyms.c (BUNCH_SIZE): Update comment.
3905         (~minimal_symbol_reader): Remove old comment.
3906         (compact_minimal_symbols): Update comment.
3907         (minimal_symbol_reader::install): Remove old comment.  Update
3908         other comments.
3909
3910 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3911
3912         * s390-linux-nat.c: Add include.
3913
3914 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3915
3916         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3917         Call linux_get_hwcap.
3918         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3919         Likewise.
3920         (aarch64_linux_get_hwcap): Remove function.
3921         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3922         declaration.
3923         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3924         linux_get_hwcap.
3925         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3926         * linux-tdep.c (linux_get_hwcap): Add function.
3927         (linux_get_hwcap2): Likewise.
3928         * linux-tdep.h (linux_get_hwcap): Add declaration.
3929         (linux_get_hwcap2): Likewise.
3930         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3931         (ppc_linux_get_hwcap2): Likewise.
3932         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3933         linux_get_hwcap.
3934         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3935         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3936         (ppc_linux_nat_target::read_description): Likewise.
3937         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3938         * s390-linux-nat.c: Likewise.
3939         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3940
3941 2019-03-24  Tom Tromey  <tom@tromey.com>
3942
3943         * ada-lang.c (standard_lookup): Simplify initialization.
3944         (ada_lookup_symbol_nonlocal): Simplify return.
3945         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3946         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3947         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3948         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3949         initialization.
3950         * solib.c (solib_global_lookup): Simplify.
3951         * symtab.c (null_block_symbol): Remove.
3952         (symbol_cache_lookup): Simplify returns.
3953         (lookup_language_this): Simplify returns.
3954         (lookup_symbol_aux): Simplify return.
3955         (lookup_local_symbol): Simplify returns.
3956         (lookup_global_symbol_from_objfile): Simplify return.
3957         (lookup_symbol_in_objfile_symtabs)
3958         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3959         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3960         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3961         * cp-namespace.c (cp_lookup_bare_symbol)
3962         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3963         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3964         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3965         (cp_lookup_symbol_via_imports): Simplify initialization.
3966         (find_symbol_in_baseclass): Likewise.
3967         * symtab.h (null_block_symbol): Remove.
3968         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3969         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3970         (d_lookup_symbol_module): Likewise.
3971         (find_symbol_in_baseclass): Simplify initialization.
3972
3973 2019-03-24  Tom Tromey  <tom@tromey.com>
3974
3975         * expression.h: Don't include symtab.h.
3976         (struct block): Forward declare.
3977
3978 2019-03-24  Tom Tromey  <tom@tromey.com>
3979
3980         * c-exp.y (typebase): Remove casts.
3981         * gdbtypes.c (lookup_unsigned_typename, )
3982         (lookup_signed_typename): Remove cast.
3983         * eval.c (parse_to_comma_and_eval): Remove cast.
3984         * parse.c (write_dollar_variable): Remove cast.
3985         * block.h (struct block) <superblock>: Now const.
3986         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3987         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3988         (map_block): Make "block" const.
3989         * symfile.h (struct quick_symbol_functions)
3990         <map_matching_symbols>: Constify block argument to "callback".
3991         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3992         const.
3993         (find_pc_sect_compunit_symtab): Make "b" const.
3994         (find_symbol_at_address): Likewise.
3995         (search_symbols): Likewise.
3996         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3997         (dw2_debug_names_lookup_symbol): Likewise.
3998         (dw2_map_matching_symbols): Update.
3999         * p-valprint.c (pascal_val_print): Remove "block".
4000         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4001         (aux_add_nonlocal_symbols): Make "block" const.
4002         (resolve_subexp): Remove cast.
4003         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4004         const.
4005         (iterate_over_file_blocks): Likewise.
4006         * f-exp.y (%union) <bval>: Remove.
4007         * coffread.c (patch_opaque_types): Make "b" const.
4008         * spu-tdep.c (spu_catch_start): Make "block" const.
4009         * c-valprint.c (print_unpacked_pointer): Remove "block".
4010         * symmisc.c (dump_symtab_1): Make "b" const.
4011         (block_depth): Make "block" const.
4012         * d-exp.y (%union) <bval>: Remove.
4013         * cp-support.h (cp_lookup_rtti_type): Update.
4014         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4015         * psymtab.c (psym_lookup_symbol): Make "block" const.
4016         (maintenance_check_psymtabs): Make "b" const.
4017         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4018         (enumerate_locals, enumerate_args): Update.
4019         * python/py-symtab.c (stpy_global_block): Make "block" const.
4020         (stpy_static_block): Likewise.
4021         * inline-frame.c (block_starting_point_at): Make "new_block"
4022         const.
4023         * block.c (find_block_in_blockvector): Make return type const.
4024         (blockvector_for_pc_sect): Make "b" const.
4025         (find_block_in_blockvector): Make "b" const.
4026
4027 2019-03-23  Tom Tromey  <tom@tromey.com>
4028
4029         * varobj.c (varobj_create): Update.
4030         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4031         * printcmd.c (display_command, do_one_display): Don't reset
4032         innermost_block.
4033         * parser-defs.h (enum innermost_block_tracker_type): Move to
4034         expression.h.
4035         (innermost_block): Update comment.
4036         * parse.c (parse_exp_1): Add tracker_types parameter.
4037         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4038         tracker_types parameter.  Reset innermost_block.
4039         (parse_exp_in_context): Remove.
4040         (parse_expression_for_completion): Update.
4041         * objfiles.c (~objfile): Don't reset expression_context_block or
4042         innermost_block.
4043         * expression.h (enum innermost_block_tracker_type): Move from
4044         parser-defs.h.
4045         (parse_exp_1): Add tracker_types parameter.
4046         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4047         reset innermost_block.
4048
4049 2019-03-23  Tom Tromey  <tom@tromey.com>
4050
4051         * objfiles.h: Include bcache.h.
4052
4053 2019-03-23  Tom Tromey  <tom@tromey.com>
4054
4055         * linespec.c (get_current_search_block): Use
4056         scoped_restore_current_language.
4057         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4058
4059 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4060             Jiong Wang  <jiong.wang@arm.com>
4061
4062         * aarch64-linux-tdep.c
4063         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4064         section.
4065         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4066
4067 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4068             Jiong Wang  <jiong.wang@arm.com>
4069
4070         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4071         instructions.
4072         (aarch64_analyze_prologue_test): Add PACIASP test.
4073         (aarch64_prologue_prev_register): Unmask PC value.
4074
4075 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4076             Jiong Wang  <jiong.wang@arm.com>
4077
4078         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4079         (aarch64_dwarf2_prev_register): Unmask PC value.
4080         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4081         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4082         DW_CFA_AARCH64_negate_ra_state.
4083         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4084
4085 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4086             Jiong Wang  <jiong.wang@arm.com>
4087
4088         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4089         registers.
4090         (aarch64_pseudo_register_name): Likewise.
4091         (aarch64_pseudo_register_type): Likewise.
4092         (aarch64_pseudo_register_reggroup_p): Likewise.
4093         (aarch64_gdbarch_init): Add pauth registers.
4094         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4095         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4096         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4097         (struct gdbarch_tdep): Add regnum for ra_state.
4098
4099 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4100             Jiong Wang  <jiong.wang@arm.com>
4101
4102         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4103
4104 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4105             Jiong Wang  <jiong.wang@arm.com>
4106
4107         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4108         function.
4109         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4110         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4111         (aarch64_gdbarch_init): Add puth registers.
4112         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4113         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4114         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4115
4116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4117             Jiong Wang  <jiong.wang@arm.com>
4118
4119         * aarch64-linux-nat.c
4120         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4121         * aarch64-linux-tdep.c
4122         (aarch64_linux_core_read_description): Likewise.
4123         (aarch64_linux_get_hwcap): New function.
4124         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4125         (aarch64_linux_get_hwcap): New declaration.
4126
4127 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4128             Jiong Wang  <jiong.wang@arm.com>
4129
4130         * aarch64-linux-nat.c
4131         (aarch64_linux_nat_target::read_description): Add pauth param.
4132         * aarch64-linux-tdep.c
4133         (aarch64_linux_core_read_description): Likewise.
4134         * aarch64-tdep.c (struct target_desc): Add in pauth.
4135         (aarch64_read_description): Add pauth param.
4136         (aarch64_gdbarch_init): Likewise.
4137         * aarch64-tdep.h (aarch64_read_description): Likewise.
4138         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4139         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4140         * features/Makefile: Add new files.
4141         * features/aarch64-pauth.c: New file.
4142         * features/aarch64-pauth.xml: New file.
4143
4144 2019-03-20  Tom Tromey  <tromey@adacore.com>
4145
4146         * infrun.c (handle_inferior_event): Rename from
4147         handle_inferior_event_1.  Create a scoped_value_mark.
4148         (handle_inferior_event): Remove.
4149
4150 2019-03-19  Tom Tromey  <tromey@adacore.com>
4151
4152         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4153         * infrun.h (print_stop_event): Add "displays" parameter.
4154         * infrun.c (print_stop_event): Add "displays" parameter.
4155
4156 2019-03-19  Pedro Alves  <palves@redhat.com>
4157
4158         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4159         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4160         to -1.  Fix TABs vs spaces.
4161         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4162         * tui/tui-out.h (tui_ui_out) Add intro comments.
4163         <m_line, m_start_of_line>: In-class initialize, and add describing
4164         comment.
4165
4166 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4167
4168         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4169         variable names.
4170         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4171
4172 2019-03-18  Pedro Alves  <palves@redhat.com>
4173             Eli Zaretskii <eliz@gnu.org>
4174
4175         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4176         m_line and m_start_of_line.
4177
4178 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4179
4180         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4181         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4182         it returns a newline.  This fixes a regression in TU mode, whereby
4183         the next line is output on the same screen line as the user input.
4184
4185 2019-03-18  Tom Tromey  <tromey@adacore.com>
4186
4187         * minsyms.c (minimal_symbol_reader::install): Remove call to
4188         obstack_blank.
4189
4190 2019-03-18  Pedro Alves  <palves@redhat.com>
4191
4192         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4193         New globals.
4194         (apply_style): New, factored out from ...
4195         (apply_ansi_escape): ... this.  Handle reverse video mode.
4196         (tui_set_reverse_mode): New function.
4197         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4198         * tui/tui-winsource.c (tui_show_source_line): Use
4199         tui_set_reverse_mode instead of setting A_STANDOUT.
4200         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4201         New setter methods.
4202
4203 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4204
4205         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4206         Handle tabs.
4207
4208 2019-03-18  Tom Tromey  <tromey@adacore.com>
4209
4210         * ada-lang.c (empty_array): Add "high" parameter.
4211         (ada_evaluate_subexp): Update.
4212
4213 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4214
4215         * unittests/string_view-selftests.c: Define
4216         _initialize_string_view_selftests unconditionally.
4217
4218 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4219
4220         PR gdb/24350
4221         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4222
4223 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4224
4225         PR gdb/24351
4226         * windows-nat.c (display_selector): Fix format specifiers.
4227
4228 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4229
4230         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4231         tui_refill_source_window instead of tui_refresh_win, to update the
4232         current execution line.  This fixes redisplay of the current line
4233         when stepping through the code with "next" or "step".
4234
4235 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4236
4237         * source-cache.c (source_cache::get_source_lines): Call
4238         find_source_lines to initialize s->nlines.  This fixes vertical
4239         scrolling of TUI source window when the DOWN arrow is pressed.
4240
4241 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4242
4243         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4244         linux-thread-db.c (_initialize_thread_db): Likewise.
4245
4246 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4247
4248         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4249         wclrtoeol in tui_show_source_line".  This reverts changes made in
4250         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4251
4252 2019-03-15  Tom Tromey  <tom@tromey.com>
4253
4254         * symtab.h (struct minimal_symbol): Derive from
4255         general_symbol_info.
4256         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4257         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4258         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4259         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4260         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4261         (MSYMBOL_SEARCH_NAME): Update.
4262         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4263         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4264         * minsyms.c (minimal_symbol_reader::record_full): Update.
4265
4266 2019-03-15  Tom Tromey  <tom@tromey.com>
4267
4268         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4269
4270 2019-03-15  Tom Tromey  <tom@tromey.com>
4271
4272         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4273         unique_xmalloc_ptr.
4274         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4275         Update.
4276         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4277         (build_minimal_symbol_hash_tables)
4278         (minimal_symbol_reader::install): Update.
4279
4280 2019-03-15  Tom Tromey  <tom@tromey.com>
4281
4282         * symtab.c (create_demangled_names_hash): Update.
4283         (symbol_set_names): Update.
4284         * objfiles.h (struct objfile_per_bfd_storage)
4285         <demangled_names_hash>: Now an htab_up.
4286         * objfiles.c (objfile_per_bfd_storage): Simplify.
4287
4288 2019-03-15  Tom Tromey  <tom@tromey.com>
4289
4290         * objfiles.h (struct objfile_per_bfd_storage): Declare
4291         destructor.
4292         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4293         New.
4294         (get_objfile_bfd_data): Use new.  Don't initialize
4295         language_of_main.
4296         (free_objfile_per_bfd_storage): Remove.
4297         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4298
4299 2019-03-15  Tom Tromey  <tom@tromey.com>
4300
4301         * symfile.c (reread_symbols): Update.
4302         * objfiles.c (objfile::objfile): Update.
4303         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4304         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4305         comment.
4306         (minimal_symbol_reader::install): Update.
4307         (terminate_minimal_symbol_table): Remove.
4308         * jit.c (jit_object_close_impl): Update.
4309
4310 2019-03-15  Tom Tromey  <tom@tromey.com>
4311
4312         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4313         initializations.
4314
4315 2019-03-15  Tom Tromey  <tom@tromey.com>
4316
4317         * objfiles.h (struct objfile_per_bfd_storage)
4318         <demangled_hash_languages>: Now a bitset.
4319         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4320         (lookup_minimal_symbol): Update.
4321
4322 2019-03-15  Tom Tromey  <tom@tromey.com>
4323
4324         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4325         Don't return the symbol.
4326         * coffread.c (record_minimal_symbol): Use record_full.
4327
4328 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4329
4330         The MS-Windows port of ncurses fails to switch to a color pair if
4331         one or both of the colors are the implicit default colors.  This
4332         change records the default colors when TUI is initialized, and
4333         then specifies them explicitly when a color pair uses the default
4334         colors.  This allows color styling in TUI mode on MS-Windows.
4335
4336         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4337         ncurses_norm_attr.
4338         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4339         colors in ncurses_norm_attr.
4340         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4341         "none", replace it with the default color recorded in
4342         ncurses_norm_attr.
4343
4344 2019-03-14  Tom Tromey  <tromey@adacore.com>
4345
4346         * source-cache.h (class source_cache) <get_source_lines>: Return
4347         std::string.
4348         * source-cache.c (source_cache::extract_lines): Handle case where
4349         first_pos==npos.  Return std::string.
4350         (source_cache::get_source_lines): Update.
4351
4352 2019-03-14  Tom Tromey  <tromey@adacore.com>
4353
4354         * NEWS: Add item for "style sources" commands.
4355         * source-cache.c (source_cache::get_source_lines): Check
4356         source_styling.
4357         * cli/cli-style.c (source_styling): New global.
4358         (_initialize_cli_style): Add "style sources" commands.
4359         (show_style_sources): New function.
4360         * cli/cli-style.h (source_styling): Declare.
4361
4362 2019-03-14  Pedro Alves  <palves@redhat.com>
4363             Tom Tromey  <tromey@adacore.com>
4364
4365         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4366         * tui/tui-winsource.c (tui_refill_source_window): New function,
4367         from...
4368         (tui_horizontal_source_scroll): ... here.  Move some logic.
4369         * cli/cli-style.c (set_style_enabled): Notify new observable.
4370         * tui/tui-hooks.c (tui_redisplay_source): New function.
4371         (tui_attach_detach_observers): Attach or detach
4372         tui_redisplay_source.
4373         * observable.h (source_styling_changed): New observable.
4374         * observable.c: Define source_styling_changed observable.
4375
4376 2019-03-13  Tom Tromey  <tromey@adacore.com>
4377
4378         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4379         (i386_gnu_nat_target::store_registers): Update.
4380         * target-debug.h (target_debug_print_std_string): New macro.
4381         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4382         * windows-tdep.c (display_one_tib): Update.
4383         * tui/tui-stack.c (tui_make_status_line): Update.
4384         * top.c (print_inferior_quit_action): Update.
4385         * thread.c (thr_try_catch_cmd): Update.
4386         (add_thread_with_info): Update.
4387         (thread_target_id_str): Update.
4388         (thr_try_catch_cmd): Update.
4389         (thread_command): Update.
4390         (thread_find_command): Update.
4391         * record-btrace.c (record_btrace_target::info_record)
4392         (record_btrace_resume_thread, record_btrace_target::resume)
4393         (record_btrace_cancel_resume, record_btrace_step_thread)
4394         (record_btrace_target::wait, record_btrace_target::wait)
4395         (record_btrace_target::wait, record_btrace_target::stop): Update.
4396         * progspace.c (print_program_space): Update.
4397         * process-stratum-target.c
4398         (process_stratum_target::thread_address_space): Update.
4399         * linux-fork.c (linux_fork_mourn_inferior)
4400         (detach_checkpoint_command, info_checkpoints_command)
4401         (linux_fork_context): Update.
4402         (linux_fork_detach): Update.
4403         (class scoped_switch_fork_info): Update.
4404         (delete_checkpoint_command): Update.
4405         * infrun.c (follow_fork_inferior): Update.
4406         (follow_fork_inferior): Update.
4407         (proceed_after_vfork_done): Update.
4408         (handle_vfork_child_exec_or_exit): Update.
4409         (follow_exec): Update.
4410         (displaced_step_prepare_throw): Update.
4411         (displaced_step_restore): Update.
4412         (start_step_over): Update.
4413         (resume_1): Update.
4414         (clear_proceed_status_thread): Update.
4415         (proceed): Update.
4416         (print_target_wait_results): Update.
4417         (do_target_wait): Update.
4418         (context_switch): Update.
4419         (stop_all_threads): Update.
4420         (restart_threads): Update.
4421         (finish_step_over): Update.
4422         (handle_signal_stop): Update.
4423         (switch_back_to_stepped_thread): Update.
4424         (keep_going_pass_signal): Update.
4425         (print_exited_reason): Update.
4426         (normal_stop): Update.
4427         * inferior.c (inferior_pid_to_str): Change return type.
4428         (print_selected_inferior): Update.
4429         (add_inferior): Update.
4430         (detach_inferior): Update.
4431         * dummy-frame.c (fprint_dummy_frames): Update.
4432         * dcache.c (dcache_info_1): Update.
4433         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4434         (btrace_fetch, btrace_clear): Update.
4435         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4436         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4437         type.
4438         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4439         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4440         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4441         * gdbarch.c, gdbarch.h: Rebuild.
4442         * gdbarch.sh (core_pid_to_str): Change return type.
4443         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4444         return type.
4445         (windows_nat_target::pid_to_str): Change return type.
4446         (windows_delete_thread): Update.
4447         (windows_nat_target::attach): Update.
4448         (windows_nat_target::files_info): Update.
4449         * target-delegates.c: Rebuild.
4450         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4451         return type.
4452         (sol_thread_target::pid_to_str): Change return type.
4453         * remote.c (class remote_target) <pid_to_str>: Change return
4454         type.
4455         (remote_target::pid_to_str): Change return type.
4456         (extended_remote_target::attach, remote_target::remote_stop_ns)
4457         (remote_target::remote_notif_remove_queued_reply)
4458         (remote_target::push_stop_reply, remote_target::disable_btrace):
4459         Update.
4460         (extended_remote_target::attach): Update.
4461         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4462         type.
4463         (gdbsim_target::pid_to_str): Change return type.
4464         * ravenscar-thread.c (struct ravenscar_thread_target)
4465         <pid_to_str>: Change return type.
4466         (ravenscar_thread_target::pid_to_str): Change return type.
4467         * procfs.c (class procfs_target) <pid_to_str>: Change return
4468         type.
4469         (procfs_target::pid_to_str): Change return type.
4470         (procfs_target::attach): Update.
4471         (procfs_target::detach): Update.
4472         (procfs_target::fetch_registers): Update.
4473         (procfs_target::store_registers): Update.
4474         (procfs_target::wait): Update.
4475         (procfs_target::files_info): Update.
4476         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4477         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4478         return type.
4479         (nto_procfs_target::pid_to_str): Change return type.
4480         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4481         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4482         return type.
4483         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4484         (exit_lwp): Update.
4485         (attach_proc_task_lwp_callback, get_detach_signal)
4486         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4487         (linux_nat_target::resume, wait_lwp, stop_callback)
4488         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4489         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4490         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4491         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4492         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4493         type.
4494         (inf_ptrace_target::attach): Update.
4495         (inf_ptrace_target::files_info): Update.
4496         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4497         type.
4498         (go32_nat_target::pid_to_str): Change return type.
4499         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4500         (gnu_nat_target::wait): Update.
4501         (gnu_nat_target::wait): Update.
4502         (gnu_nat_target::resume): Update.
4503         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4504         (fbsd_nat_target::wait): Update.
4505         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4506         type.
4507         (darwin_nat_target::attach): Update.
4508         * corelow.c (class core_target) <pid_to_str>: Change return type.
4509         (core_target::pid_to_str): Change return type.
4510         * target.c (normal_pid_to_str): Change return type.
4511         (default_pid_to_str): Likewise.
4512         (target_pid_to_str): Change return type.
4513         (target_translate_tls_address): Update.
4514         (target_announce_detach): Update.
4515         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4516         return type.
4517         (bsd_uthread_target::pid_to_str): Change return type.
4518         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4519         type.
4520         (bsd_kvm_target::pid_to_str): Change return type.
4521         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4522         return type.
4523         (aix_thread_target::pid_to_str): Change return type.
4524         * target.h (struct target_ops) <pid_to_str>: Change return type.
4525         (target_pid_to_str, normal_pid_to_str): Likewise.
4526         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4527         type.
4528         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4529         type.
4530         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4531         return type.
4532         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4533         type.
4534         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4535         type.
4536         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4537         return type.
4538
4539 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4540
4541         * NEWS: Mention that the new default MI version is 3.  Mention
4542         changes to the output of commands and events that deal with
4543         multi-location breakpoints.
4544         * breakpoint.c: Include "mi/mi-out.h".
4545         (print_one_breakpoint): Change output syntax if using MI version
4546         >= 3.
4547         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4548         New.
4549         (mi_multi_location_breakpoint_output_fixed): New.
4550         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4551         (mi_cmd_fix_multi_location_breakpoint_output): New.
4552         (mi_multi_location_breakpoint_output_fixed): New.
4553         * mi/mi-cmds.c (mi_cmds): Register command
4554         -fix-multi-location-breakpoint-output.
4555         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4556         interpreter "mi".
4557
4558 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4559
4560         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4561         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4562         instantiate mi_ui_out based on interpreter name.
4563         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4564         * mi/mi-main.c (mi_load_progress): Likewise.
4565
4566 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4567
4568         * NEWS: Combine separate "New targets" sections for 8.3.
4569
4570 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4571
4572         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4573         (ppcfbsd_init_abi): Install gdbarch
4574         "fetch_tls_load_module_address" and "get_thread_local_address"
4575         methods.
4576
4577 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4578
4579         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4580         (riscv_fbsd_init_abi): Install gdbarch
4581         "fetch_tls_load_module_address" and "get_thread_local_address"
4582         methods.
4583
4584 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4585
4586         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4587         (i386fbsd_init_abi): Install gdbarch
4588         "fetch_tls_load_module_address" and "get_thread_local_address"
4589         methods.
4590
4591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4592
4593         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4594         (amd64fbsd_init_abi): Install gdbarch
4595         "fetch_tls_load_module_address" and "get_thread_local_address"
4596         methods.
4597
4598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4599
4600         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4601         (struct fbsd_pspace_data): New type.
4602         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4603         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4604         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4605         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4606         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4607
4608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4609
4610         * gdbtypes.c (lookup_struct_elt): New function.
4611         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4612         * gdbtypes.h (struct struct_elt): New type.
4613         (lookup_struct_elt): New prototype.
4614
4615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4616
4617         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4618         remove disabled code block.
4619
4620 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4621
4622         * gdbarch.sh (get_thread_local_address): New method.
4623         * gdbarch.h, gdbarch.c: Regenerate.
4624         * target.c (target_translate_tls_address): Use
4625         gdbarch_get_thread_local_address if present instead of
4626         target::get_thread_local_address.
4627
4628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4629
4630         * target.h (target::get_thread_local_address): Update comment.
4631
4632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4633
4634         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4635         objfile->separate_debug_objfile_backlink if not NULL.
4636
4637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4638
4639         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4640         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4641         (amd64bsd_store_inferior_registers): Likewise.
4642         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4643         Enable segment base registers.
4644         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4645         PT_GETFSBASE and PT_GETGSBASE.
4646         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4647         PT_SETGSBASE.
4648         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4649         segment base registers.
4650         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4651
4652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4653
4654         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4655         Update calls to i386_target_description to add 'segments'
4656         parameter.
4657         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4658         add segment base registers.
4659         * arch/i386.c (i386_create_target_description): Add 'segments'
4660         parameter to enable segment base registers.
4661         * arch/i386.h (i386_create_target_description): Likewise.
4662         * features/i386/32bit-segments.xml: New file.
4663         * features/i386/32bit-segments.c: Generate.
4664         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4665         call to i386_target_description to add 'segments' parameter.
4666         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4667         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4668         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4669         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4670         if feature is present.
4671         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4672         Add 'segments' parameter to call to i386_target_description.
4673         (i386_target_description): Add 'segments' parameter to enable
4674         segment base registers.
4675         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4676         to call to i386_target_description.
4677         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4678         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4679         Define I386_NUM_REGS.
4680         (i386_target_description): Add 'segments' parameter to enable
4681         segment base registers.
4682
4683 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4684
4685         PR/24325
4686         * source-cache.c: #undef open and close, to avoid unresolved
4687         externals during linking.
4688
4689 2019-03-12  Tom Tromey  <tromey@adacore.com>
4690
4691         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4692         const.  Add initializers.
4693         (_initialize_remote): Don't initialize ptid globals.
4694
4695 2019-03-12  Pedro Alves  <palves@redhat.com>
4696
4697         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4698
4699 2019-03-12  Pedro Alves  <palves@redhat.com>
4700
4701         * cp-name-parser.y (main): Remove unused 'len' variable.
4702
4703 2019-03-12  Tom Tromey  <tromey@adacore.com>
4704
4705         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4706         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4707
4708 2019-03-12  Tom Tromey  <tromey@adacore.com>
4709
4710         * linux-nat.c (iterate_over_lwps): Update.
4711         (stop_callback): Remove parameter.
4712         (stop_wait_callback, detach_callback, resume_set_callback)
4713         (select_singlestep_lwp_callback, set_ignore_sigint)
4714         (status_callback, resumed_callback, resume_clear_callback)
4715         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4716         data parameter.
4717         (linux_nat_target::detach, linux_nat_target::resume)
4718         (linux_stop_and_wait_all_lwps, select_event_lwp)
4719         (linux_nat_filter_event, linux_nat_wait_1)
4720         (linux_nat_target::kill, linux_nat_target::stop)
4721         (linux_nat_target::stop): Update.
4722         (linux_nat_resume_callback): Change type.
4723         (resume_stopped_resumed_lwps, count_events_callback)
4724         (select_event_lwp_callback): Likewise.
4725         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4726         * arm-linux-nat.c (struct update_registers_data): Remove.
4727         (update_registers_callback): Change type.
4728         (arm_linux_insert_hw_breakpoint1): Update.
4729         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4730         parameter.
4731         (x86_linux_dr_set_addr): Update.
4732         (x86_linux_dr_set_control): Update.
4733         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4734         (iterate_over_lwps): Use gdb::function_view.
4735         * nat/aarch64-linux-hw-point.c (struct
4736         aarch64_dr_update_callback_param): Remove.
4737         (debug_reg_change_callback): Change type.
4738         (aarch64_notify_debug_reg_change): Update.
4739         * s390-linux-nat.c (s390_refresh_per_info): Update.
4740
4741 2019-03-11  Tom Tromey  <tromey@adacore.com>
4742
4743         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4744         redundant assignment to "this_cu".
4745
4746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4747
4748         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4749
4750 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4751
4752         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4753         from...
4754         (rank_one_type): ... this.
4755
4756 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4757
4758         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4759         from...
4760         (rank_one_type): ... this.
4761
4762 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4763
4764         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4765         from...
4766         (rank_one_type): ... this.
4767
4768 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4769
4770         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4771         from...
4772         (rank_one_type): ... this.
4773
4774 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4775
4776         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4777         from...
4778         (rank_one_type): ... this.
4779
4780 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4781
4782         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4783         from...
4784         (rank_one_type): ... this.
4785
4786 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4787
4788         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4789         from...
4790         (rank_one_type): ... this.
4791
4792 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4793
4794         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4795         from...
4796         (rank_one_type): ... this.
4797
4798 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4799
4800         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4801         from...
4802         (rank_one_type): ... this.
4803
4804 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4805
4806         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4807         from...
4808         (rank_one_type): ... this.
4809
4810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4811
4812         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4813         from...
4814         (rank_one_type): ... this.
4815
4816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4817
4818         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4819         from...
4820         (rank_one_type): ... this.
4821
4822 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4823
4824         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4825         inferior-events' shows the example events.
4826
4827 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4828
4829         Support styling on native MS-Windows console
4830
4831         PR/24315
4832         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4833         on MS-Windows if $TERM is not defined.
4834
4835         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4836
4837         * posix-hdep.c (gdb_console_fputs):
4838         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4839         functions.
4840         * ui-file.h (gdb_console_fputs): Add prototype.
4841
4842         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4843         back to fputs only if the former returns zero.
4844
4845 2019-03-07  Tom Tromey  <tom@tromey.com>
4846
4847         * symmisc.c (print_symbol_bcache_statistics): Update.
4848         (print_objfile_statistics): Update.
4849         * symfile.c (allocate_symtab): Update.
4850         * stabsread.c: Don't include bcache.h.
4851         * psymtab.h (struct psymbol_bcache): Don't declare.
4852         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4853         (psymbol_bcache_init, psymbol_bcache_free)
4854         (psymbol_bcache_get_bcache): Don't declare.
4855         * psymtab.c (struct psymbol_bcache): Remove.
4856         (psymtab_storage::psymtab_storage): Update.
4857         (psymtab_storage::~psymtab_storage): Update.
4858         (psymbol_bcache_init, psymbol_bcache_free)
4859         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4860         (add_psymbol_to_bcache): Update.
4861         (allocate_psymtab): Update.
4862         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4863         macro_cache>: No longer pointers.
4864         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4865         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4866         * macrotab.c (macro_bcache): Update.
4867         * macroexp.c: Don't include bcache.h.
4868         * gdbtypes.c (check_types_worklist): Update.
4869         (types_deeply_equal): Remove TRY/CATCH.  Update.
4870         * elfread.c (elf_symtab_read): Update.
4871         * dwarf2read.c: Don't include bcache.h.
4872         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4873         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4874         (print_bcache_statistics, bcache_memory_used): Don't declare.
4875         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4876         methods.  Rename all data members.
4877         * bcache.c (struct bcache): Move to bcache.h.
4878         (bcache::expand_hash_table): Rename from expand_hash_table.
4879         (bcache): Remove.
4880         (bcache::insert): Rename from bcache_full.
4881         (bcache::compare): Rename from bcache_compare.
4882         (bcache_xmalloc): Remove.
4883         (bcache::~bcache): Rename from bcache_xfree.
4884         (bcache::print_statistics): Rename from print_bcache_statistics.
4885         (bcache::memory_used): Rename from bcache_memory_used.
4886
4887 2019-03-07  Pedro Alves  <palves@redhat.com>
4888
4889         * infrun.c (normal_stop): Also check for
4890         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4891
4892 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * f-lang.c (value_from_host_double): Moved to...
4895         * value.c (value_from_host_double): ...here.
4896         * value.h (value_from_host_double): Declare.
4897         * guile/scm-math.c (vlscm_convert_typed_number): Use
4898         value_from_host_double.
4899         (vlscm_convert_number): Likewise.
4900         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4901         * python/py-value.c (convert_value_from_python): Likewise.
4902
4903 2019-03-06  Tom Tromey  <tom@tromey.com>
4904
4905         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4906
4907 2019-03-06  Tom Tromey  <tom@tromey.com>
4908
4909         * utils.h (free_current_contents): Don't declare.
4910         * utils.c (free_current_contents): Remove.
4911
4912 2019-03-06  Tom Tromey  <tom@tromey.com>
4913
4914         * top.c (quit_force): Update.
4915         * main.c (captured_command_loop): Update.
4916         * common/new-op.c (operator new): Update.
4917         * common/common-exceptions.c (struct catcher)
4918         <save_cleanup_chain>: Remove member.
4919         (exceptions_state_mc_init): Update.
4920         (exception_try_scope_entry): Return nullptr.
4921         (exception_try_scope_exit, exception_rethrow)
4922         (throw_exception_sjlj, throw_exception_cxx): Update.
4923         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4924         (all_cleanups, do_cleanups, discard_cleanups)
4925         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4926         (restore_cleanups, restore_final_cleanups): Don't declare.
4927         (do_final_cleanups): Remove parameter.
4928         * common/cleanups.c (cleanup_chain, make_cleanup)
4929         (make_cleanup_dtor, all_cleanups, do_cleanups)
4930         (discard_my_cleanups, discard_cleanups)
4931         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4932         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4933         (null_cleanup): Remove.
4934         (do_final_cleanups): Remove parameter.
4935
4936 2019-03-06  Tom Tromey  <tom@tromey.com>
4937
4938         * remote.c (remote_target::remote_parse_stop_reply): Use
4939         unique_xmalloc_ptr.
4940
4941 2019-03-06  Tom Tromey  <tom@tromey.com>
4942
4943         * stabsread.c (struct stabs_field_info): Rename from field_info.
4944         <list, fnlist>: Add initializers.
4945         <obstack>: New member.
4946         (read_member_functions, read_struct_fields, read_baseclasses):
4947         Allocate on obstack.  Don't use cleanups.
4948         (read_one_struct_field, read_member_functions, read_struct_fields)
4949         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4950         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4951         (read_struct_type): Update.
4952
4953 2019-03-06  Tom Tromey  <tom@tromey.com>
4954
4955         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4956         * common/filestuff.h (make_cleanup_close): Don't declare.
4957         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4958         Remove.
4959
4960 2019-03-06  Tom Tromey  <tom@tromey.com>
4961
4962         * solib-aix.c: Use make_scope_exit.
4963
4964 2019-03-06  Tom Tromey  <tom@tromey.com>
4965
4966         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4967         Use make_scope_exit.
4968
4969 2019-03-06  Tom Tromey  <tom@tromey.com>
4970
4971         * solib-svr4.c (disable_probes_interface): Remove parameter.
4972         (svr4_handle_solib_event): Use make_scope_exit.
4973
4974 2019-03-06  Tom Tromey  <tom@tromey.com>
4975
4976         * remote.c (struct stop_reply_deleter): Remove.
4977         (stop_reply_up): Update.
4978         (struct stop_reply): Derive from notif_event.  Don't typedef.
4979         <regcache>: Now a std::vector.
4980         (stop_reply_xfree): Remove.
4981         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4982         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4983         (remote_target::discard_pending_stop_replies): Use delete.
4984         (remote_target::remote_parse_stop_reply): Update.
4985         (remote_target::process_stop_reply): Update.
4986         * remote-notif.h (struct notif_event): Add virtual destructor.
4987         Remove "dtr" member.
4988         (struct notif_client) <alloc_event>: Return a unique_ptr.
4989         (notif_event_xfree): Don't declare.
4990         (notif_event_up): New typedef.
4991         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4992         (notif_event_xfree, do_notif_event_xfree): Remove.
4993         (remote_notif_state_xfree): Update.
4994
4995 2019-03-06  Tom Tromey  <tom@tromey.com>
4996
4997         * infrun.c (displaced_step_clear_cleanup): Now a
4998         forward_scope_exit type.
4999         (displaced_step_prepare_throw): Update.
5000         (displaced_step_fixup): Update.
5001
5002 2019-03-06  Tom Tromey  <tom@tromey.com>
5003
5004         * inferior.h (class inferior): Update comment.
5005         * gdbthread.h (class thread_info): Update comment.
5006
5007 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5008             Tom Tromey  <tom@tromey.com>
5009
5010         * stabsread.h (struct stab_section_list): Remove.
5011         (coffstab_build_psymtabs): Update.
5012         * dbxread.c (symbuf_sections): Now a std::vector.
5013         (sect_idx): New global.
5014         (fill_symbuf): Update.
5015         (coffstab_build_psymtabs): Change type of stabsects parameter.
5016         Update.
5017         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5018         std::vector.
5019         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5020         (coff_locate_sections): Update.
5021         (coff_symfile_read): Remove cleanups.  Update.
5022         (init_stringtab): Add storage parameter.
5023         (free_stringtab, free_stringtab_cleanup): Remove.
5024         (init_lineno): Add storage parameter.
5025         (free_linetab, free_linetab_cleanup): Remove.
5026
5027 2019-03-06  Pedro Alves  <palves@redhat.com>
5028
5029         * linux-fork.c (fork_info::clobber_regs): Delete.
5030         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5031         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5032         comment.  Adjust.
5033         (scoped_switch_fork_info::scoped_switch_fork_info)
5034         (checkpoint_command, linux_fork_context): Adjust
5035         fork_save_infrun_state calls.
5036
5037 2019-03-06  Pedro Alves  <palves@redhat.com>
5038
5039         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5040         (inf_has_multiple_threads): Return 'bool' and rewrite using
5041         inferior_info::threads().
5042
5043 2019-03-06  Pedro Alves  <palves@redhat.com>
5044
5045         * linux-fork.c: Include <list>.
5046         (fork_list): Now a std::list instance.
5047         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5048         (forks_exist_p, find_last_fork): Adjust.
5049         (new_fork): Delete.
5050         (one_fork_p): New.
5051         (add_fork): Adjust.
5052         (free_fork): Delete, folded into fork_info::~fork_info().
5053         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5054         Adjust.
5055         (init_fork_list): Delete.
5056         (linux_fork_killall, linux_fork_mourn_inferior)
5057         (linux_fork_detach, info_checkpoints_command): Adjust.
5058         (_initialize_linux_fork): No longer call init_fork_list.
5059
5060 2019-03-06  Pedro Alves  <palves@redhat.com>
5061
5062         * linux-fork.c (new_fork): New, split out of ...
5063         (add_fork): ... this.  Return void.  Move "first fork" special
5064         case from here, to ...
5065         (checkpoint_command): ... here.
5066         * linux-linux.h (add_fork): Return void.
5067
5068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5071
5072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5073             Chris January  <chris.january@arm.com>
5074             David Lecomber  <david.lecomber@arm.com>
5075
5076         * f-exp.y: New token, UNOP_INTRINSIC.
5077         (exp): New pattern using UNOP_INTRINSIC token.
5078         (f77_keywords): Add 'abs' keyword.
5079         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5080         (value_from_host_double): New function.
5081         (evaluate_subexp_f): Support UNOP_ABS.
5082
5083 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5084
5085         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5086         types.
5087
5088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5091         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5092         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5093
5094 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5097
5098 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5099             Chris January  <chris.january@arm.com>
5100
5101         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5102         * f-exp.y: Define 'KIND' token.
5103         (exp): New pattern for KIND expressions.
5104         (ptype): Handle types with a kind extension.
5105         (direct_abs_decl): Extend to spot kind extensions.
5106         (f77_keywords): Add 'kind' to the list.
5107         (push_kind_type): New function.
5108         (convert_to_kind_type): New function.
5109         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5110         * parse.c (operator_length_standard): Likewise.
5111         * parser-defs.h (enum type_pieces): Add tp_kind.
5112         * std-operator.def: Add UNOP_KIND.
5113
5114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * f-exp.y (f_parse): Set yydebug.
5117
5118 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * f-lang.c (evaluate_subexp_f): New function.
5121         (exp_descriptor_f): New global.
5122         (f_language_defn): Use exp_descriptor_f instead of
5123         exp_descriptor_standard.
5124
5125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         * f-exp.y (struct token): Add comments.
5128         (dot_ops): Remove uppercase versions and the end marker.
5129         (f77_keywords): Likewise.
5130         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5131         entries in the dot_ops array are case insensitive, and use
5132         strncasecmp to compare strings.  Also some whitespace cleanup in
5133         this area.  Similar for the f77_keywords array, except entries in
5134         this list might be case sensitive.
5135
5136 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * f-exp.y (struct f77_boolean_val): Add comments.
5139         (boolean_values): Remove uppercase versions, and end marker.
5140         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5141         and use strncasecmp to achieve case insensitivity.  Additionally,
5142         perform whitespace cleanup around this code.
5143
5144 2019-03-06  Tom Tromey  <tromey@adacore.com>
5145
5146         * remote-sim.c (gdbsim_target_open): Use result of
5147         gdb_argv::release.
5148
5149 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5150         Dirk Schubert  <dirk.schubert@arm.com>
5151         Chris January  <chris.january@arm.com>
5152
5153         * eval.c (evaluate_subexp_standard): Call Fortran argument
5154         wrapping logic.
5155         * f-lang.c (struct value): A value which can be passed into a
5156         Fortran function call.
5157         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5158         where appropriate.
5159         (struct type): Value ready for a Fortran function call.
5160         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5161         is needed.
5162         * f-lang.h (fortran_argument_convert): Declaration.
5163         (fortran_preserve_arg_pointer): Declaration.
5164         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5165
5166 2019-03-05  Tom Tromey  <tromey@adacore.com>
5167
5168         * python/py-prettyprint.c (print_string_repr): Remove #if.
5169         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5170
5171 2019-03-05  Tom Tromey  <tromey@adacore.com>
5172
5173         * target.c (the_dummy_target): Move later.  Change type to
5174         "dummy_target".
5175         (initialize_targets): Don't initialize the_dummy_target.
5176
5177 2019-03-05  Tom Tromey  <tromey@adacore.com>
5178
5179         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5180         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5181
5182 2019-03-05  Tom Tromey  <tromey@adacore.com>
5183
5184         * windows-nat.c (windows_nat_target::attach)
5185         (windows_nat_target::detach): Don't call gdb_flush.
5186         * valprint.c (generic_val_print, val_print, val_print_string):
5187         Don't call gdb_flush.
5188         * utils.c (defaulted_query): Don't call gdb_flush.
5189         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5190         * target.c (target_announce_detach): Don't call gdb_flush.
5191         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5192         * remote.c (extended_remote_target::attach): Don't call
5193         gdb_flush.
5194         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5195         * printcmd.c (do_examine): Don't call gdb_flush.
5196         (info_display_command): Don't call gdb_flush.
5197         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5198         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5199         * memattr.c (info_mem_command): Don't call gdb_flush.
5200         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5201         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5202         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5203         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5204         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5205         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5206         (gnu_nat_target::detach): Don't call gdb_flush.
5207         * f-valprint.c (f_val_print): Don't call gdb_flush.
5208         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5209         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5210         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5211         gdb_flush.
5212         * c-valprint.c (c_val_print): Don't call gdb_flush.
5213         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5214
5215 2019-03-05  Tom Tromey  <tromey@adacore.com>
5216
5217         * varobj.c (update_dynamic_varobj_children): Update.
5218         (install_default_visualizer): Use reset, not release.
5219         * value.c (set_internalvar): Update.
5220         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5221         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5222         ATTRIBUTE_UNUSED_RESULT.
5223
5224 2019-03-05  Tom Tromey  <tromey@adacore.com>
5225
5226         * remote.c (class scoped_remote_fd) <release>: Add
5227         ATTRIBUTE_UNUSED_RESULT.
5228
5229 2019-03-05  Tom Tromey  <tromey@adacore.com>
5230
5231         * macroexp.c (struct macro_buffer) <release>: Add
5232         ATTRIBUTE_UNUSED_RESULT.
5233
5234 2019-03-05  Tom Tromey  <tromey@adacore.com>
5235
5236         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5237         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5238         ATTRIBUTE_UNUSED_RESULT.
5239
5240 2019-03-05  Tom Tromey  <tromey@adacore.com>
5241
5242         * common/scoped_fd.h (class scoped_fd) <release>: Add
5243         ATTRIBUTE_UNUSED_RESULT.
5244
5245 2019-03-05  Tom Tromey  <tromey@adacore.com>
5246
5247         * parser-defs.h (struct parser_state) <release>: Add
5248         ATTRIBUTE_UNUSED_RESULT.
5249
5250 2019-03-05  Tom Tromey  <tromey@adacore.com>
5251
5252         * utils.h (class gdb_argv) <release>: Add
5253         ATTRIBUTE_UNUSED_RESULT.
5254         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5255
5256 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5257
5258         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5259         for-loop range, to avoid compiler warnings.
5260
5261         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5262         avoid compiler warnings about unused variables.
5263
5264         * NEWS: Mention end of support for native debugging on MS-Windows
5265         before XP.
5266
5267         PR gdb/24292
5268         * common/netstuff.c:
5269         * gdbserver/gdbreplay.c
5270         * gdbserver/remote-utils.c:
5271         * ser-tcp.c:
5272         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5273         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5274         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5275         'getaddrinfo' and 'freeaddrinfo' were not available before
5276         Windows XP, and mingw.org's MinGW headers by default define
5277         _WIN32_WINNT to 0x500.
5278
5279 2019-03-01  Gary Benson <gbenson@redhat.com>
5280
5281         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5282
5283 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5284             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5285
5286         PR gdb/8527
5287         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5288         set_sigint_trap, clear_sigint_trap.
5289
5290 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5291
5292         * target.c (target_detach): Clear the regcache and the
5293         frame cache.
5294
5295 2019-02-27  Pedro Alves  <palves@redhat.com>
5296
5297         * utils.c (set_screen_size): When we cap the height/width sizes,
5298         tweak the corresponding command variable to show "unlimited":
5299
5300 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5301             Pedro Alves  <palves@redhat.com>
5302
5303         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5304         before calling rl_set_screen_size.
5305
5306 2019-02-27  Tom Tromey  <tromey@adacore.com>
5307
5308         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5309         define.
5310         * python/py-value.c: Remove Python 2.4 workaround.
5311         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5312         workaround.
5313         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5314         Python 2.4 workaround.
5315         * python/python-internal.h: Remove Python 2.4 comment.
5316         (Py_ssize_t): Don't define.
5317         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5318         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5319         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5320         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5321         * python/python.c (do_start_initialization): Remove Python 2.4
5322         workaround.
5323         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5324         (print_children): Remove Python 2.4 workaround.
5325         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5326         workaround.
5327         (CHARBUFFERPROC_NAME): Remove.
5328         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5329         Python 2.4 workaround.
5330
5331 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5332
5333         * NEWS: Note minimum Python version.
5334
5335 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5336
5337         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5338         code from these functions.  Remove corresponding ifdefs.  Use
5339         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5340         Remove gotos and target of gotos.
5341         (infpy_search_memory): Likewise.
5342
5343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5346         (hppa_gdbarch_init): Don't register deleted functions with
5347         gdbarch.
5348
5349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5352         (h8300_unwind_sp): Delete.
5353         (h8300_dummy_id): Delete.
5354         (h8300_gdbarch_init): Don't register deleted functions with
5355         gdbarch.
5356
5357 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5360         (ft32_unwind_pc): Delete.
5361         (ft32_unwind_sp): Delete.
5362         (ft32_gdbarch_init): Don't register deleted functions with
5363         gdbarch.
5364
5365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5368         (frv_unwind_pc): Delete.
5369         (frv_unwind_sp): Delete.
5370         (frv_gdbarch_init): Don't register deleted functions with
5371         gdbarch.
5372
5373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5376         (riscv_unwind_pc): Delete.
5377         (riscv_unwind_sp): Delete.
5378         (riscv_gdbarch_init): Don't register deleted functions with
5379         gdbarch.
5380
5381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5384         (csky_unwind_pc): Delete.
5385         (csky_unwind_sp): Delete.
5386         (csky_gdbarch_init): Don't register deleted functions with
5387         gdbarch.
5388
5389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5392         (cris_unwind_pc): Delete.
5393         (cris_unwind_sp): Delete.
5394         (cris_gdbarch_init): Don't register deleted functions with
5395         gdbarch.
5396
5397 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5400         (bfin_unwind_pc): Delete.
5401         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5402
5403 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5406         (arm_unwind_pc): Delete.
5407         (arm_unwind_sp): Delete.
5408         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5409
5410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5413         (arc_unwind_pc): Delete.
5414         (arc_unwind_sp): Delete.
5415         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5416
5417 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5418
5419         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5420         (alpha_unwind_pc): Delete.
5421         (alpha_gdbarch_init): Don't register deleted functions with
5422         gdbarch.
5423
5424 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5427         (aarch64_unwind_pc): Delete.
5428         (aarch64_unwind_sp): Delete.
5429         (aarch64_gdbarch_init): Don't register deleted functions with
5430         gdbarch.
5431
5432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * gdbtypes.c (type_align): Don't consider static members when
5435         computing structure alignment.
5436
5437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5440         return 0 for other types.
5441         * arch-utils.c (default_type_align): Always return 0.
5442         * gdbarch.h: Regenerate.
5443         * gdbarch.sh (type_align): Extend comment.
5444         * gdbtypes.c (type_align): Add additional comments, always call
5445         gdbarch_type_align before applying the default rules.
5446         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5447         generic code will then apply a suitable default.
5448         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5449         types, return 0 for other types.
5450
5451 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5452
5453         * NEWS: Create a new section for the next release branch.
5454         Rename the section of the current branch, now that it has
5455         been cut.
5456
5457 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5458
5459         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5460         * version.in: Bump version to 8.3.50.DATE-git.
5461
5462 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5463
5464         * aix-thread.c (ptid_cmp): Remove unused variable.
5465         (get_signaled_thread): Likewise.
5466         (store_regs_user_thread): Likewise.
5467         (store_regs_kernel_thread): Likewise.
5468         (fetch_regs_kernel_thread): Remove shadowed variable.
5469
5470 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5471
5472         * features/riscv/32bit-cpu.xml: Add register numbers.
5473         * features/riscv/32bit-fpu.c: Regenerate.
5474         * features/riscv/32bit-fpu.xml: Add register numbers.
5475         * features/riscv/64bit-cpu.xml: Add register numbers.
5476         * features/riscv/64bit-fpu.c: Regenerate.
5477         * features/riscv/64bit-fpu.xml: Add register numbers.
5478
5479 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5480
5481         * NEWS: Mention two argument form of gdb.Value constructor.
5482         * python/py-value.c (convert_buffer_and_type_to_value): New
5483         function.
5484         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5485         Add support for handling an optional second argument.  Call
5486         convert_buffer_and_type_to_value as appropriate.
5487         * python/python-internal.h (Py_buffer_deleter): New struct.
5488         (Py_buffer_up): New typedef.
5489
5490 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5491
5492         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5493         instead of releasing ownership.
5494
5495 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5496
5497         * dwarf2read.c (open_and_init_dwp_file): Call
5498         elf_numsections instead of bfd_count_sections to initialize
5499         dwp_file->num_sections.
5500
5501 2019-02-25  Tom Tromey  <tromey@adacore.com>
5502
5503         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5504
5505 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5506
5507         * gcore.in: Add '--readnever' option when invoking GDB.
5508
5509 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5510
5511         * MAINTAINERS: Update my email address.
5512
5513 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5514
5515         * build-id.c (build_id_to_debug_bfd_1): New function.
5516         (build_id_to_debug_bfd): Look for separate debug file in
5517         sysroot.
5518
5519 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * gdbarch.sh: Update the copyright year range that is placed into
5522         generated files.
5523
5524 2019-02-22  Keith Seitz  <keiths@redhat.com>
5525
5526         PR symtab/23853
5527         * linespec.c (create_sals_line_offset): Search for the default
5528         symtab's filename instead of its fullname.
5529
5530 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5531
5532         * NEWS: Update style defaults.
5533
5534 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5535
5536         * main.c (captured_main_1): Disable styling in batch mode.
5537
5538 2019-02-20  Tom Tromey  <tom@tromey.com>
5539
5540         * symtab.c (symtab_symbol_info): Fix typos.
5541
5542 2019-02-20  Tom Tromey  <tromey@adacore.com>
5543
5544         * findcmd.c (_initialize_mem_search): Use upper case for
5545         metasyntactic variables.
5546
5547 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5548
5549         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5550         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5551
5552 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5553
5554         * top.h (source_file_name): Change to std::string.
5555         * top.c (source_file_name): Likewise.
5556         (command_line_input): Adjust.
5557         * cli/cli-script.c (script_from_file): Adjust.
5558
5559 2019-02-19  Tom Tromey  <tromey@adacore.com>
5560
5561         * ravenscar-thread.c
5562         (ravenscar_thread_target::update_thread_list): Don't call
5563         ada_build_task_list.
5564         * ada-lang.h (ada_build_task_list): Don't declare.
5565         * ada-tasks.c (struct ada_tasks_inferior_data)
5566         <task_list_valid_p>: Now bool.
5567         (read_known_tasks, ada_task_list_changed)
5568         (ada_tasks_invalidate_inferior_data): Update.
5569         (read_known_tasks_array): Return bool.
5570         (read_known_tasks_list): Likewise.
5571         (read_known_tasks): Return void.
5572         (ada_build_task_list): Now static.
5573
5574 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5575
5576         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5577         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5578
5579 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5580
5581         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5582         variant for ada_tasks_pspace_data_handle and
5583         ada_tasks_inferior_data_handle.
5584         (ada_tasks_pspace_data_cleanup): New function.
5585         (ada_tasks_inferior_data_cleanup): New function.
5586
5587 2019-02-17  Tom Tromey  <tom@tromey.com>
5588
5589         * macrotab.h (macro_source_fullname): Return a std::string.
5590         * macrotab.c (macro_include, check_for_redefinition)
5591         (macro_undef, macro_lookup_definition, foreach_macro)
5592         (foreach_macro_in_scope): Update.
5593         (macro_source_fullname): Return a std::string.
5594         * macrocmd.c (show_pp_source_pos): Update.
5595
5596 2019-02-17  Tom Tromey  <tom@tromey.com>
5597
5598         * macrocmd.c (show_pp_source_pos): Style the file names.
5599
5600 2019-02-17  Tom Tromey  <tom@tromey.com>
5601
5602         PR tui/24197:
5603         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5604
5605 2019-02-17  Tom Tromey  <tom@tromey.com>
5606
5607         * ada-lang.c (user_select_syms): Use filtered printing.
5608         * utils.c (wrap_style): New global.
5609         (desired_style): Remove.
5610         (emit_style_escape): Add stream parameter.
5611         (set_output_style, reset_terminal_style, prompt_for_continue):
5612         Update.
5613         (flush_wrap_buffer): Only flush gdb_stdout.
5614         (wrap_here): Set wrap_style.
5615         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5616         treat escape sequences as a character.  Change when wrap buffer is
5617         flushed.
5618         (fputs_styled): Do not set the output style when the default is
5619         requested.
5620         * ui-style.h (struct ui_file_style) <is_default>: New method.
5621         * source.c (print_source_lines_base): Emit escape sequences in one
5622         piece.
5623
5624 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5625
5626         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5627         integers and enumeration types.
5628
5629 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5630
5631         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5632         instead of lookup_symbol_in_language
5633         (do_exact_match): New function.
5634         (ada_get_symbol_name_matcher): Return do_exact_match when
5635         doing a verbatim match.
5636
5637 2019-02-15  Tom Tromey  <tromey@adacore.com>
5638
5639         * ravenscar-thread.c (ravenscar_thread_target::resume)
5640         (ravenscar_thread_target::wait): Special case wildcard requests.
5641
5642 2019-02-15  Tom Tromey  <tromey@adacore.com>
5643
5644         * ravenscar-thread.c (base_ptid): Remove.
5645         (struct ravenscar_thread_target) <close>: New method.
5646         <m_base_ptid>: New member.
5647         <update_inferior_ptid, active_task, task_is_currently_active,
5648         runtime_initialized>: Declare methods.
5649         <ravenscar_thread_target>: Add constructor.
5650         (ravenscar_thread_target::task_is_currently_active)
5651         (ravenscar_thread_target::update_inferior_ptid)
5652         (ravenscar_runtime_initialized): Rename.  Now methods.
5653         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5654         (ravenscar_thread_target::update_thread_list): Update.
5655         (ravenscar_thread_target::active_task): Now method.
5656         (ravenscar_thread_target::store_registers)
5657         (ravenscar_thread_target::prepare_to_store)
5658         (ravenscar_thread_target::prepare_to_store)
5659         (ravenscar_thread_target::mourn_inferior): Update.
5660         (ravenscar_inferior_created): Use "new" to create target.
5661         (ravenscar_thread_target::get_ada_task_ptid): Update.
5662         (_initialize_ravenscar): Don't initialize base_ptid.
5663         (ravenscar_ops): Remove global.
5664
5665 2019-02-15  Tom Tromey  <tromey@adacore.com>
5666
5667         * target.h (push_target): Declare new overload.
5668         * target.c (push_target): New overload, taking an rvalue reference.
5669         * remote.c (remote_target::open_1): Use push_target overload.
5670         * corelow.c (core_target_open): Use push_target overload.
5671
5672 2019-02-15  Tom Tromey  <tromey@adacore.com>
5673
5674         * ravenscar-thread.c (is_ravenscar_task)
5675         (ravenscar_task_is_currently_active): Return bool.
5676         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5677         (_initialize_ravenscar): Remove "(void)".
5678         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5679         Return bool.
5680
5681 2019-02-15  Tom Tromey  <tromey@adacore.com>
5682
5683         * ravenscar-thread.c (ravenscar_runtime_initializer)
5684         (has_ravenscar_runtime, get_running_thread_id)
5685         (ravenscar_thread_target::resume): Fix indentation.
5686
5687 2019-02-15  Tom Tromey  <tromey@adacore.com>
5688
5689         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5690         from ravenscar_arch_ops.
5691         (sparc_ravenscar_ops::fetch_registers)
5692         (sparc_ravenscar_ops::store_registers): Now methods.
5693         (sparc_ravenscar_prepare_to_store): Remove.
5694         (sparc_ravenscar_ops): Redefine.
5695         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5696         methods and destructor.  Remove members.
5697         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5698         (ravenscar_thread_target::store_registers)
5699         (ravenscar_thread_target::prepare_to_store): Update.
5700         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5701         Remove.
5702         (struct ppc_ravenscar_powerpc_ops): Derive from
5703         ravenscar_arch_ops.
5704         (ppc_ravenscar_powerpc_ops::fetch_registers)
5705         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5706         (ppc_ravenscar_powerpc_ops): Redefine.
5707         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5708         (ppc_ravenscar_e500_ops::fetch_registers)
5709         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5710         (ppc_ravenscar_e500_ops): Redefine.
5711         * aarch64-ravenscar-thread.c
5712         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5713         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5714         (aarch64_ravenscar_fetch_registers)
5715         (aarch64_ravenscar_store_registers): Now methods.
5716         (aarch64_ravenscar_ops): Redefine.
5717
5718 2019-02-15  Tom Tromey  <tromey@adacore.com>
5719
5720         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5721         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5722         (ravenscar_thread_target::stopped_by_watchpoint)
5723         (ravenscar_thread_target::stopped_data_address)
5724         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5725
5726 2019-02-15  Tom Tromey  <tromey@adacore.com>
5727
5728         * ravenscar-thread.c: Fix some typos.
5729
5730 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5731             Tom Tromey  <tromey@adacore.com>
5732
5733         * ada-lang.c (ada_exception_sal): Change addr_string to a
5734         std::string.
5735         (create_ada_exception_catchpoint): Update.
5736
5737 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5738             Tom Tromey  <tromey@adacore.com>
5739
5740         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5741         (bp_location_ops): Remove.
5742         (base_breakpoint_allocate_location): Update.
5743         (free_bp_location): Update.
5744         * ada-lang.c (class ada_catchpoint_location)
5745         <ada_catchpoint_location>: Remove ops parameter.
5746         (ada_catchpoint_location_dtor): Remove.
5747         (ada_catchpoint_location_ops): Remove.
5748         (allocate_location_exception): Update.
5749         * breakpoint.h (struct bp_location_ops): Remove.
5750         (class bp_location) <bp_location>: Remove bp_location_ops
5751         parameter.
5752         <~bp_location>: Add destructor.
5753         <ops>: Remove.
5754
5755 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5756             Pedro Alves  <palves@redhat.com>
5757
5758         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5759         'PATH_MAX'.
5760
5761 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5762             Samuel Thibault  <samuel.thibault@gnu.org>
5763             Thomas Schwinge  <thomas@codesourcery.com>
5764
5765         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5766         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5767
5768 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5769
5770         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5771         (check_empty): Use "const char *".
5772
5773         * gnu-nat.c (gnu_nat_target::detach): Instead of
5774         'detach_inferior (pid)' call
5775         'detach_inferior (find_inferior_pid (pid))'.
5776
5777         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5778         'nat/fork-inferior.o'.
5779         * gnu-nat.c: #include "nat/fork-inferior.h".
5780
5781         * gnu-nat.c (gnu_nat_target::detach): Instead of
5782         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5783         * gnu-nat.h: #include "inf-child.h".
5784         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5785         'i386_gnu_nat_target::fetch_registers'.
5786         (gnu_store_registers): Rename/move to
5787         'i386_gnu_nat_target::store_registers'.
5788
5789         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5790         * gnu-nat.h (mach_thread_info): New function.
5791         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5792
5793         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5794
5795 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5796
5797         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5798
5799 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5800
5801         * windows-nat.c (windows_add_thread): Add new parameter
5802         "main_thread_p" with default value set to false.  Update
5803         function documentation as well as all callers.
5804         (windows_delete_thread): Likewise.
5805         (fake_create_process): Update call to windows_add_thread.
5806         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5807         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5808         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5809         call to windows_delete_thread.
5810
5811 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5812
5813         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5814
5815 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5816
5817         * symfile.c (find_separate_debug_file): Use canonical path of
5818         sysroot with child_path instead of gdb_sysroot if it is valid.
5819
5820 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5821
5822         * symfile.c (find_separate_debug_file): Use child_path to
5823         determine if an object file is under a sysroot.
5824
5825 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5826
5827         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5828         unittests/child-path-selftests.c.
5829         * common/pathstuff.c (child_path): New function.
5830         * common/pathstuff.h (child_path): New prototype.
5831         * unittests/child-path-selftests.c: New file.
5832
5833 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5834
5835         * symfile.c (find_separate_debug_file): Look for separate debug
5836         files in debug directories under the sysroot.
5837
5838 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5839
5840         * symtab.h (struct minimal_symbol data_p): New const method.
5841         (struct minimal_symbol text_p): Likewise.
5842         * symtab.c (output_source_filename): Use file name style
5843         to print file name.
5844         (print_symbol_info): Likewise.
5845         (print_msymbol_info): Use address style to print addresses.
5846         Use function name style to print executable text symbols.
5847         (expand_symtab_containing_pc): Use data_p.
5848         (find_pc_sect_compunit_symtab): Likewise.
5849
5850 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5851
5852         * breakpoint.c (describe_other_breakpoints): Use address style
5853         to print addresses.
5854         (say_where): Likewise.
5855
5856 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5857
5858         * ada-typeprint.c (print_func_type): Print function name
5859         style to print function name.
5860         * c-typeprint.c (c_print_type_1): Likewise.
5861
5862 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5863
5864         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5865         for execve.
5866
5867 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5868
5869         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5870         type_stack.
5871
5872 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5873
5874         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5875         TYPE_CODE_REF types.
5876
5877 2019-02-08  Jim Wilson  <jimw@sifive.com>
5878
5879         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5880         (riscv_linux_fregset): New.
5881         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5882
5883 2019-02-07  Tom Tromey  <tom@tromey.com>
5884
5885         * thread.c (thread_cancel_execution_command): Update.
5886         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5887         methods.
5888         (struct thread_fsm_ops): Remove.
5889         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5890         (thread_fsm_should_stop, thread_fsm_return_value)
5891         (thread_fsm_set_finished, thread_fsm_finished_p)
5892         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5893         Don't declare.
5894         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5895         * infrun.c (clear_proceed_status_thread)
5896         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5897         (print_stop_event): Update.
5898         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5899         Add constructor.
5900         (step_command_fsm_ops): Remove.
5901         (new_step_command_fsm): Remove.
5902         (step_1): Update.
5903         (step_command_fsm::should_stop): Rename from
5904         step_command_fsm_should_stop.
5905         (step_command_fsm::clean_up): Rename from
5906         step_command_fsm_clean_up.
5907         (step_command_fsm::do_async_reply_reason): Rename from
5908         step_command_fsm_async_reply_reason.
5909         (struct until_next_fsm): Inherit from thread_fsm.  Add
5910         constructor.
5911         (until_next_fsm_ops): Remove.
5912         (new_until_next_fsm): Remove.
5913         (until_next_fsm::should_stop): Rename from
5914         until_next_fsm_should_stop.
5915         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5916         (until_next_fsm::do_async_reply_reason): Rename from
5917         until_next_fsm_async_reply_reason.
5918         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5919         constructor.  Change type of breakpoint.
5920         (finish_command_fsm_ops): Remove.
5921         (new_finish_command_fsm): Remove.
5922         (finish_command_fsm::should_stop): Rename from
5923         finish_command_fsm_should_stop.
5924         (finish_command_fsm::clean_up): Rename from
5925         finish_command_fsm_clean_up.
5926         (finish_command_fsm::return_value): Rename from
5927         finish_command_fsm_return_value.
5928         (finish_command_fsm::do_async_reply_reason): Rename from
5929         finish_command_fsm_async_reply_reason.
5930         (finish_command): Update.
5931         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5932         Add constructor.
5933         (call_thread_fsm_ops): Remove.
5934         (call_thread_fsm::call_thread_fsm): Rename from
5935         new_call_thread_fsm.
5936         (call_thread_fsm::should_stop): Rename from
5937         call_thread_fsm_should_stop.
5938         (call_thread_fsm::should_notify_stop): Rename from
5939         call_thread_fsm_should_notify_stop.
5940         (run_inferior_call, call_function_by_hand_dummy): Update.
5941         * cli/cli-interp.c (should_print_stop_to_console): Update.
5942         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5943         Add constructor.  Change type of location_breakpoint,
5944         caller_breakpoint.
5945         (until_break_fsm_ops): Remove.
5946         (new_until_break_fsm): Remove.
5947         (until_break_fsm::should_stop): Rename from
5948         until_break_fsm_should_stop.
5949         (until_break_fsm::clean_up): Rename from
5950         until_break_fsm_clean_up.
5951         (until_break_fsm::do_async_reply_reason): Rename from
5952         until_break_fsm_async_reply_reason.
5953         (until_break_command): Update.
5954         * thread-fsm.c: Remove.
5955         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5956
5957 2019-02-07  Tom Tromey  <tom@tromey.com>
5958
5959         * yy-remap.h: Add include guard.
5960         * xtensa-tdep.h: Add include guard.
5961         * xcoffread.h: Rename include guard.
5962         * varobj-iter.h: Add include guard.
5963         * tui/tui.h: Rename include guard.
5964         * tui/tui-winsource.h: Rename include guard.
5965         * tui/tui-wingeneral.h: Rename include guard.
5966         * tui/tui-windata.h: Rename include guard.
5967         * tui/tui-win.h: Rename include guard.
5968         * tui/tui-stack.h: Rename include guard.
5969         * tui/tui-source.h: Rename include guard.
5970         * tui/tui-regs.h: Rename include guard.
5971         * tui/tui-out.h: Rename include guard.
5972         * tui/tui-layout.h: Rename include guard.
5973         * tui/tui-io.h: Rename include guard.
5974         * tui/tui-hooks.h: Rename include guard.
5975         * tui/tui-file.h: Rename include guard.
5976         * tui/tui-disasm.h: Rename include guard.
5977         * tui/tui-data.h: Rename include guard.
5978         * tui/tui-command.h: Rename include guard.
5979         * tic6x-tdep.h: Add include guard.
5980         * target/waitstatus.h: Rename include guard.
5981         * target/wait.h: Rename include guard.
5982         * target/target.h: Rename include guard.
5983         * target/resume.h: Rename include guard.
5984         * target-float.h: Rename include guard.
5985         * stabsread.h: Add include guard.
5986         * rs6000-tdep.h: Add include guard.
5987         * riscv-fbsd-tdep.h: Add include guard.
5988         * regformats/regdef.h: Rename include guard.
5989         * record.h: Rename include guard.
5990         * python/python.h: Rename include guard.
5991         * python/python-internal.h: Rename include guard.
5992         * python/py-stopevent.h: Rename include guard.
5993         * python/py-ref.h: Rename include guard.
5994         * python/py-record.h: Rename include guard.
5995         * python/py-record-full.h: Rename include guard.
5996         * python/py-record-btrace.h: Rename include guard.
5997         * python/py-instruction.h: Rename include guard.
5998         * python/py-events.h: Rename include guard.
5999         * python/py-event.h: Rename include guard.
6000         * procfs.h: Add include guard.
6001         * proc-utils.h: Add include guard.
6002         * p-lang.h: Add include guard.
6003         * or1k-tdep.h: Rename include guard.
6004         * observable.h: Rename include guard.
6005         * nto-tdep.h: Rename include guard.
6006         * nat/x86-linux.h: Rename include guard.
6007         * nat/x86-linux-dregs.h: Rename include guard.
6008         * nat/x86-gcc-cpuid.h: Add include guard.
6009         * nat/x86-dregs.h: Rename include guard.
6010         * nat/x86-cpuid.h: Rename include guard.
6011         * nat/ppc-linux.h: Rename include guard.
6012         * nat/mips-linux-watch.h: Rename include guard.
6013         * nat/linux-waitpid.h: Rename include guard.
6014         * nat/linux-ptrace.h: Rename include guard.
6015         * nat/linux-procfs.h: Rename include guard.
6016         * nat/linux-osdata.h: Rename include guard.
6017         * nat/linux-nat.h: Rename include guard.
6018         * nat/linux-namespaces.h: Rename include guard.
6019         * nat/linux-btrace.h: Rename include guard.
6020         * nat/glibc_thread_db.h: Rename include guard.
6021         * nat/gdb_thread_db.h: Rename include guard.
6022         * nat/gdb_ptrace.h: Rename include guard.
6023         * nat/fork-inferior.h: Rename include guard.
6024         * nat/amd64-linux-siginfo.h: Rename include guard.
6025         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6026         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6027         * nat/aarch64-linux.h: Rename include guard.
6028         * nat/aarch64-linux-hw-point.h: Rename include guard.
6029         * mn10300-tdep.h: Add include guard.
6030         * mips-linux-tdep.h: Add include guard.
6031         * mi/mi-parse.h: Rename include guard.
6032         * mi/mi-out.h: Rename include guard.
6033         * mi/mi-main.h: Rename include guard.
6034         * mi/mi-interp.h: Rename include guard.
6035         * mi/mi-getopt.h: Rename include guard.
6036         * mi/mi-console.h: Rename include guard.
6037         * mi/mi-common.h: Rename include guard.
6038         * mi/mi-cmds.h: Rename include guard.
6039         * mi/mi-cmd-break.h: Rename include guard.
6040         * m2-lang.h: Add include guard.
6041         * location.h: Rename include guard.
6042         * linux-record.h: Rename include guard.
6043         * linux-nat.h: Add include guard.
6044         * linux-fork.h: Add include guard.
6045         * i386-darwin-tdep.h: Rename include guard.
6046         * hppa-linux-offsets.h: Add include guard.
6047         * guile/guile.h: Rename include guard.
6048         * guile/guile-internal.h: Rename include guard.
6049         * gnu-nat.h: Rename include guard.
6050         * gdb-stabs.h: Rename include guard.
6051         * frv-tdep.h: Add include guard.
6052         * f-lang.h: Add include guard.
6053         * event-loop.h: Add include guard.
6054         * darwin-nat.h: Rename include guard.
6055         * cp-abi.h: Rename include guard.
6056         * config/sparc/nm-sol2.h: Rename include guard.
6057         * config/nm-nto.h: Rename include guard.
6058         * config/nm-linux.h: Add include guard.
6059         * config/i386/nm-i386gnu.h: Rename include guard.
6060         * config/djgpp/nl_types.h: Rename include guard.
6061         * config/djgpp/langinfo.h: Rename include guard.
6062         * compile/gcc-cp-plugin.h: Add include guard.
6063         * compile/gcc-c-plugin.h: Add include guard.
6064         * compile/compile.h: Rename include guard.
6065         * compile/compile-object-run.h: Rename include guard.
6066         * compile/compile-object-load.h: Rename include guard.
6067         * compile/compile-internal.h: Rename include guard.
6068         * compile/compile-cplus.h: Rename include guard.
6069         * compile/compile-c.h: Rename include guard.
6070         * common/xml-utils.h: Rename include guard.
6071         * common/x86-xstate.h: Rename include guard.
6072         * common/version.h: Rename include guard.
6073         * common/vec.h: Rename include guard.
6074         * common/tdesc.h: Rename include guard.
6075         * common/selftest.h: Rename include guard.
6076         * common/scoped_restore.h: Rename include guard.
6077         * common/scoped_mmap.h: Rename include guard.
6078         * common/scoped_fd.h: Rename include guard.
6079         * common/safe-iterator.h: Rename include guard.
6080         * common/run-time-clock.h: Rename include guard.
6081         * common/refcounted-object.h: Rename include guard.
6082         * common/queue.h: Rename include guard.
6083         * common/ptid.h: Rename include guard.
6084         * common/print-utils.h: Rename include guard.
6085         * common/preprocessor.h: Rename include guard.
6086         * common/pathstuff.h: Rename include guard.
6087         * common/observable.h: Rename include guard.
6088         * common/netstuff.h: Rename include guard.
6089         * common/job-control.h: Rename include guard.
6090         * common/host-defs.h: Rename include guard.
6091         * common/gdb_wait.h: Rename include guard.
6092         * common/gdb_vecs.h: Rename include guard.
6093         * common/gdb_unlinker.h: Rename include guard.
6094         * common/gdb_unique_ptr.h: Rename include guard.
6095         * common/gdb_tilde_expand.h: Rename include guard.
6096         * common/gdb_sys_time.h: Rename include guard.
6097         * common/gdb_string_view.h: Rename include guard.
6098         * common/gdb_splay_tree.h: Rename include guard.
6099         * common/gdb_setjmp.h: Rename include guard.
6100         * common/gdb_ref_ptr.h: Rename include guard.
6101         * common/gdb_optional.h: Rename include guard.
6102         * common/gdb_locale.h: Rename include guard.
6103         * common/gdb_assert.h: Rename include guard.
6104         * common/filtered-iterator.h: Rename include guard.
6105         * common/filestuff.h: Rename include guard.
6106         * common/fileio.h: Rename include guard.
6107         * common/environ.h: Rename include guard.
6108         * common/common-utils.h: Rename include guard.
6109         * common/common-types.h: Rename include guard.
6110         * common/common-regcache.h: Rename include guard.
6111         * common/common-inferior.h: Rename include guard.
6112         * common/common-gdbthread.h: Rename include guard.
6113         * common/common-exceptions.h: Rename include guard.
6114         * common/common-defs.h: Rename include guard.
6115         * common/common-debug.h: Rename include guard.
6116         * common/cleanups.h: Rename include guard.
6117         * common/buffer.h: Rename include guard.
6118         * common/btrace-common.h: Rename include guard.
6119         * common/break-common.h: Rename include guard.
6120         * cli/cli-utils.h: Rename include guard.
6121         * cli/cli-style.h: Rename include guard.
6122         * cli/cli-setshow.h: Rename include guard.
6123         * cli/cli-script.h: Rename include guard.
6124         * cli/cli-interp.h: Rename include guard.
6125         * cli/cli-decode.h: Rename include guard.
6126         * cli/cli-cmds.h: Rename include guard.
6127         * charset-list.h: Add include guard.
6128         * buildsym-legacy.h: Rename include guard.
6129         * bfin-tdep.h: Add include guard.
6130         * ax.h: Rename include guard.
6131         * arm-linux-tdep.h: Add include guard.
6132         * arm-fbsd-tdep.h: Add include guard.
6133         * arch/xtensa.h: Rename include guard.
6134         * arch/tic6x.h: Add include guard.
6135         * arch/i386.h: Add include guard.
6136         * arch/arm.h: Rename include guard.
6137         * arch/arm-linux.h: Rename include guard.
6138         * arch/arm-get-next-pcs.h: Rename include guard.
6139         * arch/amd64.h: Add include guard.
6140         * arch/aarch64-insn.h: Rename include guard.
6141         * arch-utils.h: Rename include guard.
6142         * annotate.h: Add include guard.
6143         * amd64-darwin-tdep.h: Rename include guard.
6144         * aarch64-linux-tdep.h: Add include guard.
6145         * aarch64-fbsd-tdep.h: Add include guard.
6146         * aarch32-linux-nat.h: Add include guard.
6147
6148 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6149
6150         * macrotab.c (macro_define_internal): New function that
6151         factorizes macro_define_object_internal and macro_define_function
6152         code.
6153         (macro_define_object_internal): Use macro_define_internal.
6154         (macro_define_function): Likewise.
6155
6156 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6157
6158         * macrocmd.c (extract_identifier): Return
6159         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6160         callers.
6161
6162 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6163
6164         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6165
6166 2019-02-05  Tom Tromey  <tom@tromey.com>
6167
6168         * target.c (target_stack::unpush): Move assertion earlier.
6169
6170 2019-01-30  Tom Tromey  <tom@tromey.com>
6171
6172         PR python/23615:
6173         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6174         (gdbpy_parse_and_eval): Likewise.
6175         * python/python-internal.h (gdbpy_allow_threads): New class.
6176
6177 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6178
6179         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6180         (aarch64_fbsd_fpregmap): Move earlier.
6181         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6182         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6183         instead of individual calls to trad_frame_set_reg_addr.
6184         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6185         earlier.
6186         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6187         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6188         instead of individual calls to trad_frame_set_reg_addr.
6189
6190 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6191
6192         * CONTRIBUTE: Replace contribution list with wiki link.
6193
6194 2019-01-25  Tom Tromey  <tom@tromey.com>
6195
6196         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6197
6198 2019-01-25  Tom Tromey  <tom@tromey.com>
6199
6200         * xtensa-linux-nat.c: Fix common/ includes.
6201         * xml-support.h: Fix common/ includes.
6202         * xml-support.c: Fix common/ includes.
6203         * x86-linux-nat.c: Fix common/ includes.
6204         * windows-nat.c: Fix common/ includes.
6205         * varobj.h: Fix common/ includes.
6206         * varobj.c: Fix common/ includes.
6207         * value.c: Fix common/ includes.
6208         * valops.c: Fix common/ includes.
6209         * utils.c: Fix common/ includes.
6210         * unittests/xml-utils-selftests.c: Fix common/ includes.
6211         * unittests/utils-selftests.c: Fix common/ includes.
6212         * unittests/unpack-selftests.c: Fix common/ includes.
6213         * unittests/tracepoint-selftests.c: Fix common/ includes.
6214         * unittests/style-selftests.c: Fix common/ includes.
6215         * unittests/string_view-selftests.c: Fix common/ includes.
6216         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6217         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6218         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6219         * unittests/rsp-low-selftests.c: Fix common/ includes.
6220         * unittests/parse-connection-spec-selftests.c: Fix common/
6221         includes.
6222         * unittests/optional-selftests.c: Fix common/ includes.
6223         * unittests/offset-type-selftests.c: Fix common/ includes.
6224         * unittests/observable-selftests.c: Fix common/ includes.
6225         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6226         * unittests/memrange-selftests.c: Fix common/ includes.
6227         * unittests/memory-map-selftests.c: Fix common/ includes.
6228         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6229         * unittests/function-view-selftests.c: Fix common/ includes.
6230         * unittests/environ-selftests.c: Fix common/ includes.
6231         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6232         * unittests/common-utils-selftests.c: Fix common/ includes.
6233         * unittests/cli-utils-selftests.c: Fix common/ includes.
6234         * unittests/array-view-selftests.c: Fix common/ includes.
6235         * ui-file.c: Fix common/ includes.
6236         * tui/tui-io.c: Fix common/ includes.
6237         * tracepoint.h: Fix common/ includes.
6238         * tracepoint.c: Fix common/ includes.
6239         * tracefile-tfile.c: Fix common/ includes.
6240         * top.h: Fix common/ includes.
6241         * top.c: Fix common/ includes.
6242         * thread.c: Fix common/ includes.
6243         * target/waitstatus.h: Fix common/ includes.
6244         * target/waitstatus.c: Fix common/ includes.
6245         * target.h: Fix common/ includes.
6246         * target.c: Fix common/ includes.
6247         * target-memory.c: Fix common/ includes.
6248         * target-descriptions.c: Fix common/ includes.
6249         * symtab.h: Fix common/ includes.
6250         * symfile.c: Fix common/ includes.
6251         * stap-probe.c: Fix common/ includes.
6252         * spu-linux-nat.c: Fix common/ includes.
6253         * sparc-nat.c: Fix common/ includes.
6254         * source.c: Fix common/ includes.
6255         * solib.c: Fix common/ includes.
6256         * solib-target.c: Fix common/ includes.
6257         * ser-unix.c: Fix common/ includes.
6258         * ser-tcp.c: Fix common/ includes.
6259         * ser-pipe.c: Fix common/ includes.
6260         * ser-base.c: Fix common/ includes.
6261         * selftest-arch.c: Fix common/ includes.
6262         * s12z-tdep.c: Fix common/ includes.
6263         * rust-exp.y: Fix common/ includes.
6264         * rs6000-aix-tdep.c: Fix common/ includes.
6265         * riscv-tdep.c: Fix common/ includes.
6266         * remote.c: Fix common/ includes.
6267         * remote-notif.h: Fix common/ includes.
6268         * remote-fileio.h: Fix common/ includes.
6269         * remote-fileio.c: Fix common/ includes.
6270         * regcache.h: Fix common/ includes.
6271         * regcache.c: Fix common/ includes.
6272         * record-btrace.c: Fix common/ includes.
6273         * python/python.c: Fix common/ includes.
6274         * python/py-type.c: Fix common/ includes.
6275         * python/py-inferior.c: Fix common/ includes.
6276         * progspace.h: Fix common/ includes.
6277         * producer.c: Fix common/ includes.
6278         * procfs.c: Fix common/ includes.
6279         * proc-api.c: Fix common/ includes.
6280         * printcmd.c: Fix common/ includes.
6281         * ppc-linux-nat.c: Fix common/ includes.
6282         * parser-defs.h: Fix common/ includes.
6283         * osdata.c: Fix common/ includes.
6284         * obsd-nat.c: Fix common/ includes.
6285         * nat/x86-linux.c: Fix common/ includes.
6286         * nat/x86-linux-dregs.c: Fix common/ includes.
6287         * nat/x86-dregs.h: Fix common/ includes.
6288         * nat/x86-dregs.c: Fix common/ includes.
6289         * nat/ppc-linux.c: Fix common/ includes.
6290         * nat/mips-linux-watch.h: Fix common/ includes.
6291         * nat/mips-linux-watch.c: Fix common/ includes.
6292         * nat/linux-waitpid.c: Fix common/ includes.
6293         * nat/linux-ptrace.h: Fix common/ includes.
6294         * nat/linux-ptrace.c: Fix common/ includes.
6295         * nat/linux-procfs.c: Fix common/ includes.
6296         * nat/linux-personality.c: Fix common/ includes.
6297         * nat/linux-osdata.c: Fix common/ includes.
6298         * nat/linux-namespaces.c: Fix common/ includes.
6299         * nat/linux-btrace.h: Fix common/ includes.
6300         * nat/linux-btrace.c: Fix common/ includes.
6301         * nat/fork-inferior.c: Fix common/ includes.
6302         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6303         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6304         * nat/aarch64-linux.c: Fix common/ includes.
6305         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6306         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6307         * namespace.h: Fix common/ includes.
6308         * mips-linux-tdep.c: Fix common/ includes.
6309         * minsyms.c: Fix common/ includes.
6310         * mi/mi-parse.h: Fix common/ includes.
6311         * mi/mi-main.c: Fix common/ includes.
6312         * mi/mi-cmd-env.c: Fix common/ includes.
6313         * memrange.h: Fix common/ includes.
6314         * memattr.c: Fix common/ includes.
6315         * maint.h: Fix common/ includes.
6316         * maint.c: Fix common/ includes.
6317         * main.c: Fix common/ includes.
6318         * machoread.c: Fix common/ includes.
6319         * location.c: Fix common/ includes.
6320         * linux-thread-db.c: Fix common/ includes.
6321         * linux-nat.c: Fix common/ includes.
6322         * linux-fork.c: Fix common/ includes.
6323         * inline-frame.c: Fix common/ includes.
6324         * infrun.c: Fix common/ includes.
6325         * inflow.c: Fix common/ includes.
6326         * inferior.h: Fix common/ includes.
6327         * inferior.c: Fix common/ includes.
6328         * infcmd.c: Fix common/ includes.
6329         * inf-ptrace.c: Fix common/ includes.
6330         * inf-child.c: Fix common/ includes.
6331         * ia64-linux-nat.c: Fix common/ includes.
6332         * i387-tdep.c: Fix common/ includes.
6333         * i386-tdep.c: Fix common/ includes.
6334         * i386-linux-tdep.c: Fix common/ includes.
6335         * i386-linux-nat.c: Fix common/ includes.
6336         * i386-go32-tdep.c: Fix common/ includes.
6337         * i386-fbsd-tdep.c: Fix common/ includes.
6338         * i386-fbsd-nat.c: Fix common/ includes.
6339         * guile/scm-type.c: Fix common/ includes.
6340         * guile/guile.c: Fix common/ includes.
6341         * go32-nat.c: Fix common/ includes.
6342         * gnu-nat.c: Fix common/ includes.
6343         * gdbthread.h: Fix common/ includes.
6344         * gdbarch-selftests.c: Fix common/ includes.
6345         * gdb_usleep.c: Fix common/ includes.
6346         * gdb_select.h: Fix common/ includes.
6347         * gdb_bfd.c: Fix common/ includes.
6348         * gcore.c: Fix common/ includes.
6349         * fork-child.c: Fix common/ includes.
6350         * findvar.c: Fix common/ includes.
6351         * fbsd-nat.c: Fix common/ includes.
6352         * event-top.c: Fix common/ includes.
6353         * event-loop.c: Fix common/ includes.
6354         * dwarf2read.c: Fix common/ includes.
6355         * dwarf2loc.c: Fix common/ includes.
6356         * dwarf2-frame.c: Fix common/ includes.
6357         * dwarf-index-cache.c: Fix common/ includes.
6358         * dtrace-probe.c: Fix common/ includes.
6359         * disasm-selftests.c: Fix common/ includes.
6360         * defs.h: Fix common/ includes.
6361         * csky-tdep.c: Fix common/ includes.
6362         * cp-valprint.c: Fix common/ includes.
6363         * cp-support.h: Fix common/ includes.
6364         * cp-support.c: Fix common/ includes.
6365         * corelow.c: Fix common/ includes.
6366         * completer.h: Fix common/ includes.
6367         * completer.c: Fix common/ includes.
6368         * compile/compile.c: Fix common/ includes.
6369         * compile/compile-loc2c.c: Fix common/ includes.
6370         * compile/compile-cplus-types.c: Fix common/ includes.
6371         * compile/compile-cplus-symbols.c: Fix common/ includes.
6372         * command.h: Fix common/ includes.
6373         * cli/cli-dump.c: Fix common/ includes.
6374         * cli/cli-cmds.c: Fix common/ includes.
6375         * charset.c: Fix common/ includes.
6376         * build-id.c: Fix common/ includes.
6377         * btrace.h: Fix common/ includes.
6378         * btrace.c: Fix common/ includes.
6379         * breakpoint.h: Fix common/ includes.
6380         * breakpoint.c: Fix common/ includes.
6381         * ax.h:
6382         (enum agent_op): Fix common/ includes.
6383         * ax-general.c (struct aop_map): Fix common/ includes.
6384         * ax-gdb.c: Fix common/ includes.
6385         * auxv.c: Fix common/ includes.
6386         * auto-load.c: Fix common/ includes.
6387         * arm-tdep.c: Fix common/ includes.
6388         * arch/riscv.c: Fix common/ includes.
6389         * arch/ppc-linux-common.c: Fix common/ includes.
6390         * arch/i386.c: Fix common/ includes.
6391         * arch/arm.c: Fix common/ includes.
6392         * arch/arm-linux.c: Fix common/ includes.
6393         * arch/arm-get-next-pcs.c: Fix common/ includes.
6394         * arch/amd64.c: Fix common/ includes.
6395         * arch/aarch64.c: Fix common/ includes.
6396         * arch/aarch64-insn.c: Fix common/ includes.
6397         * arch-utils.c: Fix common/ includes.
6398         * amd64-windows-tdep.c: Fix common/ includes.
6399         * amd64-tdep.c: Fix common/ includes.
6400         * amd64-sol2-tdep.c: Fix common/ includes.
6401         * amd64-obsd-tdep.c: Fix common/ includes.
6402         * amd64-nbsd-tdep.c: Fix common/ includes.
6403         * amd64-linux-tdep.c: Fix common/ includes.
6404         * amd64-linux-nat.c: Fix common/ includes.
6405         * amd64-fbsd-tdep.c: Fix common/ includes.
6406         * amd64-fbsd-nat.c: Fix common/ includes.
6407         * amd64-dicos-tdep.c: Fix common/ includes.
6408         * amd64-darwin-tdep.c: Fix common/ includes.
6409         * agent.c: Fix common/ includes.
6410         * ada-lang.h: Fix common/ includes.
6411         * ada-lang.c: Fix common/ includes.
6412         * aarch64-tdep.c: Fix common/ includes.
6413
6414 2019-01-25  Tom Tromey  <tom@tromey.com>
6415
6416         * common/create-version.sh: Use common/version.h.
6417
6418 2019-01-24  Pedro Alves  <palves@redhat.com>
6419
6420         * infrun.c (signal_stop, signal_print, signal_program)
6421         (signal_catch, signal_pass): Now arrays instead of pointers.
6422         (update_signals_program_target, do_target_resume)
6423         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6424         * linux-nat.c (linux_nat_target::pass_signals)
6425         (linux_nat_target::create_inferior, linux_nat_target::attach):
6426         Adjust.
6427         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6428         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6429         * procfs.c (procfs_target::pass_signals): Adjust.
6430         * record-full.c (record_full_target::resume): Adjust.
6431         * remote.c (remote_target::pass_signals)
6432         (remote_target::program_signals): Adjust.
6433         * target-debug.h (target_debug_print_signals): Now takes a
6434         gdb::array_view as parameter.  Adjust.
6435         * target.h (target_ops) <pass_signals, program_signals>: Replace
6436         pointer and length parameters with gdb::array_view.
6437         (target_pass_signals, target_program_signals): Likewise.
6438         * target-delegates.c: Regenerate.
6439
6440 2019-01-24  Pedro Alves  <palves@redhat.com>
6441
6442         * common/forward-scope-exit.h
6443         (forward_scope_exit::forward_scope_exit): Pass arguments to
6444         m_bind_function directly, instead of creating a std::bind and
6445         copying that.
6446
6447 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6448
6449         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6450         for static members.
6451         (pass_in_v_vfp_candidate): Likewise.
6452
6453 2019-01-23  Tom Tromey  <tom@tromey.com>
6454             Pedro Alves  <palves@redhat.com>
6455
6456         * regcache.c (class regcache_invalidator): Remove.
6457         (regcache::raw_write): Use make_scope_exit.
6458
6459 2019-01-23  Tom Tromey  <tom@tromey.com>
6460
6461         * ui-out.h (class ui_out_emit_type): Update comment.
6462
6463 2019-01-23  Tom Tromey  <tom@tromey.com>
6464
6465         * infrun.c (fetch_inferior_event): Update comment.
6466
6467 2019-01-23  Tom Tromey  <tom@tromey.com>
6468             Pedro Alves  <palves@redhat.com>
6469
6470         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6471         parameter.
6472         (fetch_inferior_event): Use SCOPE_EXIT.
6473
6474
6475 2019-01-23  Tom Tromey  <tom@tromey.com>
6476             Pedro Alves  <palves@redhat.com>
6477
6478         * infrun.c (disable_thread_events): Delete.
6479         (stop_all_threads): Use SCOPE_EXIT.
6480
6481 2019-01-23  Tom Tromey  <tom@tromey.com>
6482             Pedro Alves  <palves@redhat.com>
6483
6484         * symfile.c: Include forward-scope-exit.h.
6485         (clear_symtab_users_cleanup): Replace forward declaration with
6486         a FORWARD_SCOPE_EXIT.
6487         (syms_from_objfile_1): Use the forward_scope_exit and
6488         gdb::optional instead of cleanup_function.
6489         (reread_symbols): Use the forward_scope_exit instead of
6490         cleanup_function.
6491         (clear_symtab_users_cleanup): Remove function.
6492
6493 2019-01-23  Tom Tromey  <tom@tromey.com>
6494             Pedro Alves  <palves@redhat.com>
6495
6496         * linux-nat.c: Include scope-exit.h.
6497         (cleanup_target_stop): Remove.
6498         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6499         SCOPE_EXIT.
6500
6501 2019-01-23  Tom Tromey  <tom@tromey.com>
6502             Pedro Alves  <palves@redhat.com>
6503
6504         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6505         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6506
6507 2019-01-23  Tom Tromey  <tom@tromey.com>
6508             Andrew Burgess  <andrew.burgess@embecosm.com>
6509             Pedro Alves  <palves@redhat.com>
6510
6511         * infrun.c (fetch_inferior_event): Use scope_exit.
6512         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6513         * top.c (execute_command): Use scope_exit.
6514         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6515         * utils.c (do_bpstat_clear_actions_cleanup)
6516         (make_bpstat_clear_actions_cleanup): Remove.
6517
6518 2019-01-23  Tom Tromey  <tom@tromey.com>
6519             Pedro Alves  <palves@redhat.com>
6520
6521         * infrun.c: Include "common/scope-exit.h"
6522         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6523         (wait_for_inferior): Use SCOPE_EXIT.
6524         (fetch_inferior_event): Use scope_exit.
6525
6526 2019-01-23  Tom Tromey  <tom@tromey.com>
6527             Pedro Alves  <palves@redhat.com>
6528
6529         * breakpoint.c (create_breakpoint): Remove cleanup.
6530
6531 2019-01-23  Tom Tromey  <tom@tromey.com>
6532             Andrew Burgess  <andrew.burgess@embecosm.com>
6533             Pedro Alves  <palves@redhat.com>
6534
6535 2019-01-23  Pedro Alves  <palves@redhat.com>
6536
6537         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6538
6539 2019-01-23  Pedro Alves  <palves@redhat.com>
6540             Andrew Burgess  <andrew.burgess@embecosm.com>
6541
6542         * gdbthread.h: Include "common/forward-scope-exit.h".
6543         (scoped_finish_thread_state): Redefine custom class in terms of
6544         forward_scope_exit.
6545
6546 2019-01-23  Pedro Alves  <palves@redhat.com>
6547             Andrew Burgess  <andrew.burgess@embecosm.com>
6548
6549         * common/forward-scope-exit.h: New file.
6550
6551 2019-01-23  Pedro Alves  <palves@redhat.com>
6552             Andrew Burgess  <andrew.burgess@embecosm.com>
6553             Tom Tromey  <tom@tromey.com>
6554
6555         * common/scope-exit.h: New file.
6556
6557 2019-01-23  Pedro Alves  <palves@redhat.com>
6558
6559         * common/preprocessor.h (ESC): Rename to ...
6560         (ESC_PARENS): ... this.
6561         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6562         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6563
6564 2019-01-23  Tom Tromey  <tom@tromey.com>
6565
6566         * language.h (class scoped_switch_to_sym_language_if_auto):
6567         Initialize m_lang in both cases.
6568
6569 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6570
6571         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6572         with XCNEW.
6573
6574 2019-01-22  Tom Tromey  <tom@tromey.com>
6575
6576         * corelow.c: Do not include sys/file.h.
6577
6578 2019-01-22  Tom Tromey  <tom@tromey.com>
6579
6580         * tui/tui-wingeneral.h: Include gdb_curses.h.
6581
6582 2019-01-22  Tom Tromey  <tom@tromey.com>
6583
6584         * source-cache.h (class source_cache) <get_source_lines,
6585         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6586
6587 2019-01-22  Tom Tromey  <tom@tromey.com>
6588
6589         * remote-fileio.h (struct remote_target): Declare.
6590
6591 2019-01-22  Tom Tromey  <tom@tromey.com>
6592
6593         * python/py-arch.c: Do not include py-ref.h.
6594         * python/py-bpevent.c: Do not include py-ref.h.
6595         * python/py-cmd.c: Do not include py-ref.h.
6596         * python/py-continueevent.c: Do not include py-ref.h.
6597         * python/py-event.h: Do not include py-ref.h.
6598         * python/py-evtregistry.c: Do not include py-ref.h.
6599         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6600         * python/py-frame.c: Do not include py-ref.h.
6601         * python/py-framefilter.c: Do not include py-ref.h.
6602         * python/py-function.c: Do not include py-ref.h.
6603         * python/py-infevents.c: Do not include py-ref.h.
6604         * python/py-linetable.c: Do not include py-ref.h.
6605         * python/py-objfile.c: Do not include py-ref.h.
6606         * python/py-param.c: Do not include py-ref.h.
6607         * python/py-prettyprint.c: Do not include py-ref.h.
6608         * python/py-progspace.c: Do not include py-ref.h.
6609         * python/py-symbol.c: Do not include py-ref.h.
6610         * python/py-symtab.c: Do not include py-ref.h.
6611         * python/py-type.c: Do not include py-ref.h.
6612         * python/py-unwind.c: Do not include py-ref.h.
6613         * python/py-utils.c: Do not include py-ref.h.
6614         * python/py-value.c: Do not include py-ref.h.
6615         * python/py-varobj.c: Do not include py-ref.h.
6616         * python/py-xmethods.c: Do not include py-ref.h.
6617         * python/python.c: Do not include py-ref.h.
6618         * varobj.c: Do not include py-ref.h.
6619
6620 2019-01-22  Tom Tromey  <tom@tromey.com>
6621
6622         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6623         keyword for bcache.
6624
6625 2019-01-22  Tom Tromey  <tom@tromey.com>
6626
6627         * compile/compile-cplus-types.c: Remove a comment by #include.
6628
6629 2019-01-22  Tom Tromey  <tom@tromey.com>
6630
6631         * compile/gcc-c-plugin.h: Include compile-internal.h.
6632
6633 2019-01-22  Tom Tromey  <tom@tromey.com>
6634
6635         * stabsread.c (EXTERN): Do not define.
6636         (symnum, next_symbol_text_func, processing_gcc_compilation)
6637         (within_function, global_sym_chain, global_stabs)
6638         (previous_stab_code, this_object_header_files)
6639         (n_this_object_header_files)
6640         (n_allocated_this_object_header_files): Define.
6641         * stabsread.h (EXTERN): Never define.  Use "extern".
6642
6643 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6644
6645         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6646         history_value.
6647
6648 2019-01-21  Tom Tromey  <tom@tromey.com>
6649
6650         * ui-out.c: Fix includes.
6651         * tui/tui-source.c: Fix includes.
6652         * target.c: Fix includes.
6653         * remote.c: Fix includes.
6654         * regcache.c: Fix includes.
6655         * python/py-block.c: Fix includes.
6656         * printcmd.c: Fix includes.
6657         * or1k-tdep.c: Fix includes.
6658         * mi/mi-main.c: Fix includes.
6659         * m32r-tdep.c: Fix includes.
6660         * csky-tdep.c: Fix includes.
6661         * compile/compile-cplus-types.c: Fix includes.
6662         * cli/cli-interp.c: Fix includes.
6663
6664 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6665
6666         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6667         for padding.
6668
6669 2019-01-16  Tom Tromey  <tom@tromey.com>
6670
6671         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6672         earlier.
6673         (struct objfile) <msymbols_range>: Move from top level.
6674         <msymbols>: New method.
6675         (class objfile_msymbols): Remove.
6676         * symtab.c (default_collect_symbol_completion_matches_break_on):
6677         Update.
6678         * symmisc.c (dump_msymbols): Update.
6679         * stabsread.c (scan_file_globals): Update.
6680         * objc-lang.c (info_selectors_command, info_classes_command)
6681         (find_methods): Update.
6682         * minsyms.c (find_solib_trampoline_target): Update.
6683         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6684         * coffread.c (coff_symfile_read): Update.
6685         * ada-lang.c (ada_lookup_simple_minsym)
6686         (ada_collect_symbol_completion_matches): Update.
6687
6688 2019-01-16  Tom Tromey  <tom@tromey.com>
6689
6690         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6691         type.  Remove no-argument constructor.
6692         <iterator::operator++>: Simplify.
6693         <begin>: Update.
6694         <end>: Use minimal_symbol_count.
6695
6696 2019-01-16  Tom Tromey  <tom@tromey.com>
6697
6698         * objfiles.h (struct objfile) <psymtabs>: New method.
6699         (class objfile_psymtabs): Remove.
6700         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6701         typedef.
6702         <range>: New method.
6703         (require_partial_symbols): Change return type.
6704         * psymtab.c (require_partial_symbols)
6705         (psym_expand_symtabs_matching): Update.
6706         * mdebugread.c (parse_partial_symbols): Update.
6707         * dbxread.c (dbx_end_psymtab): Update.
6708
6709 2019-01-15  Tom Tromey  <tom@tromey.com>
6710
6711         * symtab.c (lookup_objfile_from_block)
6712         (lookup_symbol_in_objfile_symtabs)
6713         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6714         (find_line_symtab, info_sources_command)
6715         (default_collect_symbol_completion_matches_break_on)
6716         (make_source_files_completion_list): Update.
6717         * symmisc.c (print_objfile_statistics, dump_objfile)
6718         (maintenance_print_symbols, maintenance_info_symtabs)
6719         (maintenance_check_symtabs, maintenance_info_line_tables):
6720         Update.
6721         * source.c (select_source_symtab)
6722         (forget_cached_source_info_for_objfile): Update.
6723         * objfiles.h (class objfile_compunits): Remove.
6724         (struct objfile) <compunits_range>: New typedef.
6725         (compunits): New method.
6726         * objfiles.c (objfile_relocate1): Update.
6727         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6728         * maint.c (count_symtabs_and_blocks): Update.
6729         * linespec.c (iterate_over_all_matching_symtabs): Update.
6730         * cp-support.c (add_symbol_overload_list_qualified): Update.
6731         * coffread.c (coff_symtab_read): Update.
6732         * ada-lang.c (add_nonlocal_symbols)
6733         (ada_collect_symbol_completion_matches)
6734         (ada_add_global_exceptions): Update.
6735
6736 2019-01-15  Tom Tromey  <tom@tromey.com>
6737
6738         * progspace.h (program_space) <objfiles_safe_range>: New
6739         typedef.
6740         <objfiles_safe>: New method.
6741         * objfiles.h (class all_objfiles_safe): Remove.
6742         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6743         * jit.c (jit_inferior_exit_hook): Update.
6744
6745 2019-01-17  Tom Tromey  <tom@tromey.com>
6746
6747         * progspace.h (program_space) <objfiles_range>: New typedef.
6748         <objfiles>: New method.
6749         <objfiles_head>: Rename from objfiles.
6750         (object_files): Update.
6751         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6752         * guile/scm-pretty-print.c
6753         (ppscm_find_pretty_printer_from_objfiles): Update.
6754         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6755         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6756         Update.
6757         * python/py-progspace.c (pspy_get_objfiles): Update.
6758         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6759         Update.
6760         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6761         (objfpy_lookup_objfile_by_build_id): Update.
6762         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6763         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6764         Update.
6765         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6766         (expand_symtab_containing_pc, lookup_objfile_from_block)
6767         (lookup_static_symbol, basic_lookup_transparent_type)
6768         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6769         (find_line_symtab, info_sources_command)
6770         (default_collect_symbol_completion_matches_break_on)
6771         (make_source_files_completion_list, find_main_name): Update.
6772         * symmisc.c (print_symbol_bcache_statistics)
6773         (print_objfile_statistics, maintenance_print_symbols)
6774         (maintenance_print_msymbols, maintenance_print_objfiles)
6775         (maintenance_info_symtabs, maintenance_check_symtabs)
6776         (maintenance_expand_symtabs, maintenance_info_line_tables):
6777         Update.
6778         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6779         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6780         (map_overlay_command, unmap_overlay_command)
6781         (simple_overlay_update, expand_symtabs_matching)
6782         (map_symbol_filenames): Update.
6783         * symfile-debug.c (set_debug_symfile): Update.
6784         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6785         Update.
6786         * source.c (select_source_symtab, forget_cached_source_info):
6787         Update.
6788         * solib.c (solib_read_symbols): Update.
6789         * solib-spu.c (append_ocl_sos): Update.
6790         * psymtab.c (maintenance_print_psymbols)
6791         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6792         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6793         * printcmd.c (info_symbol_command): Update.
6794         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6795         Update.
6796         * objfiles.h (class all_objfiles): Remove.
6797         * objfiles.c (have_partial_symbols, have_full_symbols)
6798         (have_minimal_symbols, qsort_cmp, update_section_map)
6799         (shared_objfile_contains_address_p)
6800         (default_iterate_over_objfiles_in_search_order): Update.
6801         * objc-lang.c (info_selectors_command, info_classes_command)
6802         (find_methods): Update.
6803         * minsyms.c (find_solib_trampoline_target): Update.
6804         * maint.c (maintenance_info_sections)
6805         (maintenance_translate_address, count_symtabs_and_blocks):
6806         Update.
6807         * main.c (captured_main_1): Update.
6808         * linux-thread-db.c (try_thread_db_load_from_pdir)
6809         (has_libpthread): Update.
6810         * linespec.c (iterate_over_all_matching_symtabs)
6811         (search_minsyms_for_name): Update.
6812         * jit.c (jit_find_objf_with_entry_addr): Update.
6813         * hppa-tdep.c (find_unwind_entry)
6814         (hppa_lookup_stub_minimal_symbol): Update.
6815         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6816         Update.
6817         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6818         (elf_gnu_ifunc_resolve_by_got): Update.
6819         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6820         * dwarf-index-write.c (save_gdb_index_command): Update.
6821         * cp-support.c (add_symbol_overload_list_qualified): Update.
6822         * breakpoint.c (create_overlay_event_breakpoint)
6823         (create_longjmp_master_breakpoint)
6824         (create_std_terminate_master_breakpoint)
6825         (create_exception_master_breakpoint): Update.
6826         * blockframe.c (find_pc_partial_function): Update.
6827         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6828         (ada_collect_symbol_completion_matches)
6829         (ada_add_global_exceptions): Update.
6830
6831 2019-01-17  Tom Tromey  <tom@tromey.com>
6832
6833         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6834         declare VEC.
6835         (solib_target_parse_libraries): Change return type.
6836         (library_list_start_segment, library_list_start_section)
6837         (library_list_end_library, library_list_start_library); Update.
6838         (solib_target_free_library_list): Remove.
6839         (solib_target_parse_libraries): Remove cleanup.  Change return
6840         type.
6841         (solib_target_current_sos): Update.
6842
6843 2019-01-17  Tom Tromey  <tromey@bapiya>
6844
6845         * valprint.c: Replace "the the" with "the".
6846         * symtab.c: Replace "the the" with "the".
6847         * solib.c: Replace "the the" with "the".
6848         * solib-dsbt.c: Replace "the the" with "the".
6849         * linespec.c: Replace "the the" with "the".
6850         * dwarf2loc.h: Replace "the the" with "the".
6851         * amd64-windows-tdep.c: Replace "the the" with "the".
6852         * aarch64-tdep.c: Replace "the the" with "the".
6853
6854 2019-01-16  Keith Seitz  <keiths@redhat.com>
6855
6856         PR gdb/23773
6857         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6858         <builder>: Rename to ..
6859         <m_builder>: ... this and make private.
6860         (dwarf2_cu::get_builder): New method.  Change all users of
6861         `builder' to use this method.
6862         (dwarf2_start_symtab): Move to ...
6863         (dwarf2_cu::start_symtab): ... here.  Update all callers
6864         (setup_type_unit_groups): Move to ...
6865         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6866         callers.
6867         (dwarf2_cu::reset_builder): New method.
6868         (process_full_compunit, process_full_type_unit): Use
6869         dwarf2_cu::reset_builder.
6870         (follow_die_offset): Record the ancestor CU if it is different
6871         from the followed DIE's CU.
6872         (follow_die_sig_1): Likewise.
6873
6874 2019-01-15  Tom Tromey  <tom@tromey.com>
6875
6876         * remote.c (class remote_state) <buf>: Now a char_vector.
6877         <buf_size>: Remove.
6878         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6879         parameter.
6880         (remote_target::getpkt_or_notif_sane_1)
6881         (remote_target::getpkt_sane)
6882         (remote_target::getpkt_or_notif_sane): Likewise.
6883         (class remote_target) <putpkt>: New overload.
6884         (remote_target::read_frame): Change type of "buf_p".  Remove
6885         sizeof_p parameter.
6886         (packet_ok): New overload.
6887         (packet_check_result): New overload.
6888         Update all uses.
6889
6890 2019-01-14  Tom Tromey  <tom@tromey.com>
6891
6892         * remote-notif.c (handle_notification, remote_notif_ack)
6893         (remote_notif_parse): Make "buf" const.
6894         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6895         const.
6896         (remote_notif_parse, remote_notif_ack, handle_notification):
6897         Likewise.
6898         * remote.c (remote_notif_stop_parse): Make "buf" const.
6899         (remote_target::remote_parse_stop_reply): Make "buf" const.
6900         (remote_notif_stop_ack): Make "buf" const.
6901
6902 2019-01-14  Tom Tromey  <tom@tromey.com>
6903
6904         * remote.c (remote_console_output): Make parameter const.
6905
6906 2019-01-14  Tom Tromey  <tom@tromey.com>
6907
6908         * target-debug.h (target_debug_print_signals): Constify.
6909         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6910         * procfs.c (procfs_target::pass_signals): Update.
6911         * linux-nat.c (linux_nat_target::pass_signals): Update.
6912         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6913         * target-delegates.c: Rebuild.
6914         * remote.c (remote_target::program_signals): Update.
6915         (remote_target::pass_signals): Update.
6916         * target.c (target_pass_signals): Constify argument.
6917         (target_program_signals): Likewise.
6918         * target.h (struct target_ops) <pass_signals, program_signals>:
6919         Constify argument.
6920         (target_pass_signals, target_program_signals): Constify argument.
6921
6922 2019-01-14  Tom Tromey  <tom@tromey.com>
6923
6924         PR tui/28819:
6925         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6926
6927 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6928
6929         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6930         field.
6931         * rs6000-tdep.c: Include reggroups.h.
6932         (IS_V_ALIAS_PSEUDOREG): Define.
6933         (rs6000_register_name): Return names for the "vX" aliases.
6934         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6935         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6936         aliases.  Call default_register_reggroup_p for all other
6937         pseudo-registers.
6938         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6939         New functions.
6940         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6941         Handle "vX" aliases.
6942         (v_alias_pseudo_register_collect): New function.
6943         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6944         (rs6000_gdbarch_init): Initialize "vX" aliases as
6945         pseudo-registers.  Restore registration of
6946         rs6000_pseudo_register_reggroup_p with
6947         set_tdesc_pseudo_register_reggroup_p.
6948
6949 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6950
6951         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6952         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6953         set_gdbarch_num_pseudo_regs.
6954
6955 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6956
6957         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6958         Remove arg prefixname, add do_set and do_show.
6959         Add member functions set_list and show_list.
6960         * cli/cli-style.c (class cli_style_option): Update accordingly.
6961         (style_set_list): Move to file scope.
6962         (style_show_list): Likewise.
6963         (set_style): Call help_list.
6964         (show_style): Call cmd_show_list.
6965         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6966         Update to use the new macro.
6967
6968 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6969
6970         * ada-lang.c (_initialize_ada_language): Expand the help text
6971         for the "catch exception" command.
6972
6973 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6974
6975         * symtab.c (matching_obj_sections): Initialize obj,
6976         declare it closer to its usage.
6977
6978 2019-01-10  Tom Tromey  <tom@tromey.com>
6979
6980         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6981         (basic_inf_threads_range): Remove.
6982         (inf_threads_range, inf_non_exited_threads_range)
6983         (safe_inf_threads_range): Use next_adapter.
6984
6985 2019-01-10  Keith Seitz  <keiths@redhat.com>
6986
6987         PR gdb/23712
6988         PR symtab/23010
6989         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6990         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6991
6992 2019-01-10  Keith Seitz  <keiths@redhat.com>
6993
6994         PR gdb/23712
6995         PR symtab/23010
6996         * dictionary.c (pending_to_vector): Remove.
6997         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6998         Remove _1 suffix, replacing functions of the same name.  Update
6999         all callers.
7000         (dict_create_hashed, dict_create_hashed_expandable)
7001         (dict_create_linear, dict_create_linear_expandable, dict_free)
7002         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7003         Make functions static.
7004
7005 2019-01-10  Keith Seitz  <keiths@redhat.com>
7006
7007         PR gdb/23712
7008         PR symtab/23010
7009         * dictionary.h (struct dictionary): Replace declaration with
7010         multidictionary.
7011         (dict_create_hashed, dict_create_hashed_expandable)
7012         (dict_create_linear, dict_create_linear_expandable)
7013         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7014         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7015         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7016         taking multidictionary argument.
7017         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7018         * block.h (struct block) <dict>: Change to multidictionary
7019         and rename `multidict'.
7020         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7021         symmisc.c: Update all dictionary references to multidictionary.
7022
7023 2019-01-10  Keith Seitz  <keiths@redhat.com>
7024
7025         PR gdb/23712
7026         PR symtab/23010
7027         * dictionary.c: Include unordered_map.
7028         (pending_to_vector): New function.
7029         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7030         Rewrite the non-"_1" functions to take vector instead
7031         of linked list.
7032         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7033         "new" _1 versions of the same name.
7034         (multidictionary): Define.
7035         (std::hash<enum language): New definition.
7036         (collate_pending_symbols_by_language, mdict_create_hashed)
7037         (mdict_create_hashed_expandable, mdict_create_linear)
7038         (mdict_create_linear_expandable, mdict_free)
7039         (find_language_dictionary, create_new_language_dictionary)
7040         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7041         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7042         (mdict_size, mdict_empty): New functions.
7043         * dictionary.h (mdict_iterator): Define.
7044
7045 2019-01-10  Pedro Alves  <palves@redhat.com>
7046
7047         * breakpoint.c (read_uploaded_action)
7048         (create_tracepoint_from_upload): Adjust to use
7049         gdb::unique_xmalloc_ptr.
7050         * ctf.c (ctf_write_uploaded_tp):
7051         (SET_ARRAY_FIELD): Use emplace_back.
7052         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7053         * tracefile-tfile.c (tfile_write_uploaded_tp):
7054         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7055         gdb::unique_xmalloc_ptr.
7056         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7057         at_string, cond_string, cmd_strings>: Replace char pointers
7058         with gdb::unique_xmalloc_ptr.
7059
7060 2019-01-10  Pedro Alves  <palves@redhat.com>
7061
7062         * solib-target.c (library_list_start_library): Don't xstrdup name.
7063
7064 2019-01-10  Pedro Alves  <palves@redhat.com>
7065
7066         * mdebugread.c (parse_partial_symbols): Use
7067         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7068
7069 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * linux-fork.c (scoped_switch_fork_info)
7072         <~scoped_switch_fork_info>: Fix incorrect variable name.
7073
7074 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7075
7076         * linux-fork.c (scoped_switch_fork_info)
7077         <scoped_switch_fork_info>: Make explicit.
7078         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7079
7080 2019-01-10  Tom Tromey  <tom@tromey.com>
7081
7082         * objfiles.h (objfile::reset_psymtabs): Update.
7083         * objfiles.c (objfile::objfile): Update.
7084         * psymtab.h (psymtab_storage::obstack): Update.
7085         (psymtab_storage::m_obstack): Use gdb::optional.
7086         (class psymtab_storage): Update comment.  Remove objfile
7087         parameter.
7088         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7089
7090 2019-01-10  Tom Tromey  <tom@tromey.com>
7091
7092         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7093         <free_psymtabs>: Now private.
7094         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7095         (allocate_psymtab): Use new method.
7096
7097 2019-01-10  Tom Tromey  <tom@tromey.com>
7098
7099         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7100         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7101         * mdebugread.c (parse_partial_symbols): Use
7102         allocate_dependencies.
7103         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7104         allocate_dependencies.
7105         (process_psymtab_comp_unit_reader)
7106         (build_type_psymtab_dependencies): Likewise.
7107         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7108
7109 2019-01-10  Tom Tromey  <tom@tromey.com>
7110
7111         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7112         PSYMBOL_SET_LANGUAGE.
7113         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7114
7115 2019-01-10  Tom Tromey  <tom@tromey.com>
7116
7117         * psymtab.h (psymtab_storage::obstack): New method.
7118         <m_obstack>: Rename from obstack; now private.
7119         * psymtab.c (psymtab_storage): Update.
7120         * dwarf2read.c (create_addrmap_from_index)
7121         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7122         Update.
7123
7124 2019-01-10  Tom Tromey  <tom@tromey.com>
7125
7126         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7127         * objfiles.h (objfile::reset_psymtabs): New method.
7128
7129 2019-01-10  Tom Tromey  <tom@tromey.com>
7130
7131         * symmisc.c (print_symbol_bcache_statistics): Update.
7132         (print_objfile_statistics): Update.
7133         * symfile.c (reread_symbols): Update.
7134         * psymtab.h (class psymtab_storage): New.
7135         * psymtab.c (psymtab_storage): New constructor.
7136         (~psymtab_storage): New destructor.
7137         (require_partial_symbols): Update.
7138         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7139         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7140         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7141         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7142         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7143         (start_psymtab_common, end_psymtab_common)
7144         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7145         (allocate_psymtab): Update.
7146         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7147         Update.
7148         (dump_psymtab_addrmap, maintenance_print_psymbols)
7149         (maintenance_check_psymtabs): Update.
7150         (class objfile_psymtabs): Move to objfiles.h.
7151         * psympriv.h (discard_psymtab): Now inline.
7152         (psymtab_discarder::psymtab_discarder): Update.
7153         (psymtab_discarder::~psymtab_discarder): Update.
7154         (ALL_OBJFILE_PSYMTABS): Rewrite.
7155         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7156         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7157         Remove fields.
7158         <partial_symtabs>: New field.
7159         (class objfile_psymtabs): Move from psymtab.h.  Update.
7160         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7161         psymbol_cache.
7162         (objfile::~objfile): Don't destroy psymbol_cache.
7163         * mdebugread.c (parse_partial_symbols): Update.
7164         * dwarf2read.c (create_addrmap_from_index)
7165         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7166         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7167         (add_partial_subprogram, dwarf2_ranges_read): Update.
7168         * dwarf-index-write.c (write_address_map)
7169         (write_one_signatured_type, recursively_write_psymbols)
7170         (class debug_names, class debug_names, write_psymtabs_to_index):
7171         Update.
7172
7173 2019-01-10  Tom Tromey  <tom@tromey.com>
7174
7175         * symtab.h (SYMBOL_SET_NAMES): Update.
7176         (symbol_set_names): Update.
7177         (MSYMBOL_SET_NAMES): Update.
7178         * symtab.c (symbol_set_names): Change argument to be an
7179         objfile_per_bfd_storage.
7180         * psymtab.c (add_psymbol_to_bcache): Update.
7181         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7182
7183 2019-01-10  Tom Tromey  <tom@tromey.com>
7184
7185         * symtab.c (create_demangled_names_hash): Change argument to be an
7186         objfile_per_bfd_storage.
7187         (symbol_set_names): Update.
7188
7189 2019-01-10  Tom Tromey  <tom@tromey.com>
7190
7191         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7192         init_psymbol_list.
7193         * psymtab.c (init_psymbol_list): Do nothing if already called.
7194         * psympriv.h (init_psymbol_list): Add comment.
7195         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7196         init_psymbol_list.
7197         * dbxread.c (dbx_symfile_read): Unconditionally call
7198         init_psymbol_list.
7199
7200 2019-01-10  Tom Tromey  <tom@tromey.com>
7201
7202         * xcoffread.c (scan_xcoff_symtab): Update.
7203         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7204         "where".
7205         * mdebugread.c (parse_partial_symbols)
7206         (handle_psymbol_enumerators): Update.
7207         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7208         * dbxread.c (read_dbx_symtab): Update.
7209         * psympriv.h (psymbol_placement): New enum.
7210         (add_psymbol_to_list): Update.
7211
7212 2019-01-10  Tom Tromey  <tom@tromey.com>
7213
7214         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7215         static_psymbols parameters.
7216         (scan_xcoff_symtab): Update.
7217         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7218         static_psymbols parameters.
7219         * psympriv.h (start_psymtab_common): Update.
7220         * mdebugread.c (parse_partial_symbols): Update.
7221         * dwarf2read.c (create_partial_symtab): Update.
7222         * dbxread.c (read_dbx_symtab): Update.
7223         (start_psymtab): Remove global_psymbols and static_psymbols
7224         parameters.
7225
7226 2019-01-10  Tom Tromey  <tom@tromey.com>
7227
7228         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7229         * psymtab.c (allocate_psymtab): Add comment.
7230         * psympriv.h (allocate_psymtab): Add comment.
7231         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7232         initializations.
7233         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7234
7235 2019-01-10  Tom Tromey  <tom@tromey.com>
7236
7237         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7238         Don't declare.
7239         * mipsread.c: Include mdebugread.h.
7240         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7241         Declare.
7242         * elfread.c: Include mdebugread.h.
7243
7244 2019-01-09  Tom Tromey  <tom@tromey.com>
7245
7246         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7247         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7248         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7249         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7250         (psym_lookup_symbol, psym_find_last_source_symtab)
7251         (psym_forget_cached_source_info, psym_print_stats)
7252         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7253         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7254         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7255         (psym_find_compunit_symtab_by_address)
7256         (maintenance_print_psymbols, maintenance_info_psymtabs)
7257         (maintenance_check_psymtabs): Use ranged for.
7258         * psymtab.h (class objfile_psymtabs): New.
7259         (require_partial_symbols): Return objfile_psymtabs.
7260         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7261
7262 2019-01-09  Tom Tromey  <tom@tromey.com>
7263
7264         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7265         (find_pc_mapped_section, list_overlays_command)
7266         (map_overlay_command, unmap_overlay_command)
7267         (simple_overlay_update): Use all_objfiles.
7268         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7269         * printcmd.c (info_symbol_command): Use all_objfiles.
7270         * objfiles.h (ALL_OBJSECTIONS): Remove.
7271         * maint.c (maintenance_translate_address): Use all_objfiles.
7272         * gcore.c (gcore_create_callback): Use all_objfiles.
7273         (objfile_find_memory_regions): Likewise.
7274
7275 2019-01-09  Tom Tromey  <tom@tromey.com>
7276
7277         * symtab.c (find_line_symtab, info_sources_command)
7278         (make_source_files_completion_list): Use objfile_compunits.
7279         * source.c (select_source_symtab): Use objfile_compunits.
7280         * objfiles.h (struct objfile): Update comment.
7281         (ALL_OBJFILES): Remove.
7282         (ALL_FILETABS): Remove.
7283         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7284         objfile_compunits.
7285
7286 2019-01-09  Tom Tromey  <tom@tromey.com>
7287
7288         * symmisc.c (print_objfile_statistics, dump_objfile)
7289         (maintenance_print_symbols): Use compunit_filetabs.
7290         * source.c (forget_cached_source_info_for_objfile): Use
7291         compunit_filetabs.
7292         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7293         (ALL_FILETABS): Use compunit_filetabs.
7294         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7295         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7296
7297 2019-01-09  Tom Tromey  <tom@tromey.com>
7298
7299         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7300         (compunit_filetabs): New.
7301         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7302         compunit_filetabs.
7303         (info_sources_command, make_source_files_completion_list): Remove
7304         declaration.
7305         * symmisc.c (print_objfile_statistics, dump_objfile)
7306         (maintenance_print_symbols): Remove declaration.
7307         (maintenance_info_symtabs): Use compunit_filetabs.
7308         (maintenance_info_line_tables): Likewise.
7309         * source.c (select_source_symtab): Change local variable name.
7310         (forget_cached_source_info_for_objfile): Remove declaration.
7311         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7312         * objfiles.c (objfile_relocate1): Remove declaration.
7313         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7314         declaration.
7315         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7316         * coffread.c (coff_symtab_read): Remove declaration.
7317         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7318         compunit_filetabs.
7319
7320 2019-01-09  Tom Tromey  <tom@tromey.com>
7321
7322         * symtab.c (lookup_objfile_from_block)
7323         (find_pc_sect_compunit_symtab, search_symbols)
7324         (default_collect_symbol_completion_matches_break_on): Use
7325         objfile_compunits.
7326         * objfiles.h (ALL_COMPUNITS): Remove.
7327         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7328         * cp-support.c (add_symbol_overload_list_qualified): Use
7329         objfile_compunits.
7330         * ada-lang.c (ada_collect_symbol_completion_matches)
7331         (ada_add_global_exceptions): Use objfile_compunits.
7332
7333 2019-01-09  Tom Tromey  <tom@tromey.com>
7334
7335         * source.c (select_source_symtab)
7336         (forget_cached_source_info_for_objfile): Remove declaration.
7337         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7338         declaration.
7339         * maint.c (count_symtabs_and_blocks): Remove declaration.
7340         * cp-support.c (add_symbol_overload_list_qualified): Remove
7341         declaration.
7342         * coffread.c (coff_symtab_read): Remove declaration.
7343         * symtab.c (lookup_symbol_in_objfile_symtabs)
7344         (basic_lookup_transparent_type_1): Use objfile_compunits.
7345         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7346         (info_sources_command, search_symbols)
7347         (default_collect_symbol_completion_matches_break_on)
7348         (make_source_files_completion_list): Remove declaration.
7349         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7350         (ada_collect_symbol_completion_matches)
7351         (ada_add_global_exceptions): Remove declaration.
7352         * linespec.c (iterate_over_all_matching_symtabs): Use
7353         objfile_compunits.
7354         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7355         (class objfile_compunits): New.
7356         (ALL_COMPUNITS): Use objfile_compunits.
7357         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7358         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7359         objfile_compunits.
7360         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7361
7362 2019-01-09  Tom Tromey  <tom@tromey.com>
7363
7364         * symtab.c (search_symbols)
7365         (default_collect_symbol_completion_matches_break_on): Use
7366         objfile_msymbols.
7367         * ada-lang.c (ada_lookup_simple_minsym)
7368         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7369         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7370         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7371         objfile_msymbols.
7372         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7373         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7374         * objc-lang.c (find_methods): Use objfile_msymbols.
7375         (info_selectors_command, info_classes_command): Likewise.
7376         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7377         * objfiles.h (class objfile_msymbols): New.
7378         (ALL_OBJFILE_MSYMBOLS): Remove.
7379         (ALL_MSYMBOLS): Remove.
7380
7381 2019-01-09  Tom Tromey  <tom@tromey.com>
7382
7383         * common/next-iterator.h (next_adapter): Add Iterator template
7384         parameter.
7385         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7386         (class all_objfiles_safe): New.
7387         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7388         * objfiles.c (put_objfile_before): Update comment.
7389         (add_separate_debug_objfile): Likewise.
7390         (free_all_objfiles): Use all_objfiles_safe.
7391         (objfile_purge_solibs): Likewise.
7392
7393 2019-01-09  Tom Tromey  <tom@tromey.com>
7394
7395         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7396         (expand_symtab_containing_pc, lookup_static_symbol)
7397         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7398         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7399         all_objfiles.
7400         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7401         * breakpoint.c (create_overlay_event_breakpoint)
7402         (create_longjmp_master_breakpoint)
7403         (create_std_terminate_master_breakpoint)
7404         (create_exception_master_breakpoint): Use all_objfiles.
7405         * linux-thread-db.c (try_thread_db_load_from_pdir)
7406         (has_libpthread): Use all_objfiles.
7407         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7408         * linespec.c (iterate_over_all_matching_symtabs)
7409         (search_minsyms_for_name): Use all_objfiles.
7410         * maint.c (maintenance_info_sections): Use all_objfiles.
7411         * main.c (captured_main_1): Use all_objfiles.
7412         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7413         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7414         * guile/scm-pretty-print.c
7415         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7416         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7417         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7418         (maintenance_print_msymbols): Use all_objfiles.
7419         * source.c (select_source_symtab): Use all_objfiles.
7420         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7421         * symfile.c (remove_symbol_file_command)
7422         (expand_symtabs_matching, map_symbol_filenames): Use
7423         all_objfiles.
7424         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7425         all_objfiles.
7426         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7427         * objc-lang.c (find_methods): Use all_objfiles.
7428         * objfiles.c (have_partial_symbols, have_full_symbols)
7429         (have_minimal_symbols, qsort_cmp)
7430         (default_iterate_over_objfiles_in_search_order): Use
7431         all_objfiles.
7432         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7433         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7434         (maintenance_check_psymtabs): Use all_objfiles.
7435         (ALL_PSYMTABS): Remove.
7436         * compile/compile-object-run.c (do_module_cleanup): Use
7437         all_objfiles.
7438         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7439         * cp-support.c (add_symbol_overload_list_qualified): Use
7440         all_objfiles.
7441         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7442         Use all_objfiles.
7443         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7444         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7445         all_objfiles.
7446         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7447         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7448         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7449         Uses all_objfiles.
7450         * solib.c (solib_read_symbols): Use all_objfiles
7451
7452 2019-01-09  Tom Tromey  <tom@tromey.com>
7453
7454         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7455         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7456         all_objfiles.
7457         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7458         * symmisc.c (print_symbol_bcache_statistics)
7459         (print_objfile_statistics, maintenance_print_objfiles)
7460         (maintenance_info_symtabs, maintenance_check_symtabs)
7461         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7462         all_objfiles.
7463         * source.c (forget_cached_source_info): Use all_objfiles.
7464         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7465         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7466         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7467         * objfiles.c (update_section_map): Use all_objfiles.
7468         (shared_objfile_contains_address_p): Likewise.
7469         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7470         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7471
7472 2019-01-09  Tom Tromey  <tom@tromey.com>
7473
7474         * common/next-iterator.h: New file.
7475         * objfiles.h (class all_objfiles): New.
7476         (struct objfile_iterator): New.
7477
7478 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7479
7480         * NEWS: Move the description of the changed "frame", "select-frame",
7481          and "info frame" commands to the Changed commands section.
7482
7483 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7484
7485         * gdbtypes.c (check_stub_method_group): Remove handling of old
7486         mangling schemes.
7487         * linespec.c (find_methods): Likewise.
7488         * stabsread.c (read_member_functions): Likewise.
7489         * valops.c (search_struct_method): Likewise.
7490         (value_struct_elt_for_reference): Likewise.
7491         * NEWS: Mention this change.
7492
7493 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7494
7495         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7496         print_source_lines.
7497         * source.c (print_source_lines_base): Update line number check.
7498         (print_source_lines): New function.
7499         (source_lines_range::source_lines_range): New function.
7500         * source.h (class source_lines_range): New class.
7501         (print_source_lines): New declaration.
7502
7503 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7504
7505         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7506
7507 2019-01-08  Tom Tromey  <tom@tromey.com>
7508             Simon Marchi  <simon.marchi@ericsson.com>
7509
7510         PR gdb/24060
7511         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7512         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7513         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7514         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7515         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7516         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7517
7518 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * source.c (select_source_symtab): Move header comment to
7521         declaration in source.h.
7522         (forget_cached_source_info_for_objfile): Likewise.
7523         (forget_cached_source_info): Likewise.
7524         (identify_source_line): Likewise.
7525         * source.h (identify_source_line): Move declaration from symtab.h
7526         and add comment from source.c
7527         (print_source_lines): Likewise.
7528         (forget_cached_source_info_for_objfile): Likewise.
7529         (forget_cached_source_info): Likewise.
7530         (select_source_symtab): Likewise.
7531         (enum print_source_lines_flag): Move definition from symtab.h.
7532         * symtab.h (identify_source_line): Move declaration to source.h.
7533         (print_source_lines): Likewise.
7534         (forget_cached_source_info_for_objfile): Likewise.
7535         (forget_cached_source_info): Likewise.
7536         (select_source_symtab): Likewise.
7537         (enum print_source_lines_flag): Move definition to source.h.
7538         * tui/tui-hooks.c: Add 'source.h' include.
7539
7540 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7541
7542         * source.c (print_source_lines_base): Handle requests to print
7543         reverse line number sequences, and guard against empty lines
7544         string.
7545
7546 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * source.c (print_source_lines_base): Fix skip of '\r' if next
7549         character is '\n'.
7550
7551 2019-01-06  Tom Tromey  <tom@tromey.com>
7552
7553         * c-exp.y (struct c_parse_state) <macro_original_text,
7554         expansion_obstack>: New member.
7555         (macro_original_text, expansion_obstack): Remove globals.
7556         (scan_macro_expansion, scanning_macro_expansion)
7557         (finished_macro_expansion): Update.
7558         (scan_macro_cleanup): Remove.
7559         (yylex, c_parse): Update.
7560
7561 2019-01-06  Tom Tromey  <tom@tromey.com>
7562
7563         * c-exp.y (struct c_parse_state) <strings>: New member.
7564         (operator_stoken): Update.
7565
7566 2019-01-06  Tom Tromey  <tom@tromey.com>
7567
7568         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7569         (union type_stack_elt) <typelist_val>: Now a pointer to
7570         std::vector.
7571         (type_stack_cleanup): Don't declare.
7572         (push_typelist): Update.
7573         * parse.c (pop_typelist): Return a std::vector.
7574         (push_typelist): Take a std::vector.
7575         (follow_types): Update.  Do not free args.
7576         (type_stack_cleanup): Remove.
7577         * c-exp.y (struct c_parse_state): New.
7578         (cpstate): New global.
7579         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7580         (nonempty_typelist): Update.
7581         (func_mod): Create a new vector.
7582         (c_parse): Create a c_parse_state.
7583         (check_parameter_typelist): Do not delete params.
7584         (function_method): Update.  Do not delete type_list.
7585
7586 2019-01-06  Tom Tromey  <tom@tromey.com>
7587
7588         PR gdb/28155:
7589         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7590         check_typedef.
7591         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7592         (print_return_value): Likewise.
7593
7594 2019-01-05  Tom Tromey  <tom@tromey.com>
7595
7596         * contrib/cleanup_check.py: Remove.
7597         * contrib/gcc-with-excheck: Remove.
7598         * contrib/exsummary.py: Remove.
7599         * contrib/excheck.py: Remove.
7600
7601 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7602
7603         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7604         NULL. Initialize tpprev to NULL instead of assigning it
7605         to NULL on the next statement.
7606         * windows-nat.c (windows_delete_thread): Remove check for
7607         main_thread_id before printing thread exit notifications.
7608         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7609         Remove thread ID check against main_thread_id.
7610         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7611         windows_delete_thread.
7612         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7613
7614 2019-01-04  Tom Tromey  <tom@tromey.com>
7615
7616         * compile/compile.c (_initialize_compile): Use upper case for
7617         metasyntactic variables.
7618         * symmisc.c (_initialize_symmisc): Use upper case for
7619         metasyntactic variables.
7620         * psymtab.c (_initialize_psymtab): Use upper case for
7621         metasyntactic variables.
7622         * demangle.c (demangle_command): Use upper case for metasyntactic
7623         variables.
7624         (_initialize_demangler): Likewise.
7625         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7626         variables.
7627
7628 2019-01-03  Tom Tromey  <tom@tromey.com>
7629
7630         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7631
7632 2019-01-03  Tom Tromey  <tom@tromey.com>
7633
7634         * python/py-symtab.c (salpy_str): Update.
7635         (struct salpy_sal_object) <symtab>: Now a PyObject.
7636         (salpy_dealloc): Update.
7637         (del_objfile_sal): Use gdbpy_ref.
7638
7639 2019-01-03  Tom Tromey  <tom@tromey.com>
7640
7641         * python/py-type.c (convert_field): Use new_reference.  Return
7642         gdbpy_ref.
7643         (make_fielditem): Return gdbpy_ref.
7644         (typy_fields): Update.
7645         (typy_getitem): Update.
7646         (field_name): Return gdbpy_ref.  Use new_reference.
7647         (typy_iterator_iternext): Update.
7648
7649 2019-01-03  Tom Tromey  <tom@tromey.com>
7650
7651         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7652
7653 2019-01-03  Tom Tromey  <tom@tromey.com>
7654
7655         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7656         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7657         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7658         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7659         (pspy_set_type_printers): Likewise.
7660         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7661         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7662         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7663         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7664         (objfpy_set_type_printers): Likewise.
7665
7666 2019-01-03  Tom Tromey  <tom@tromey.com>
7667
7668         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7669         (gdbpy_print_stack): Use gdbpy_err_fetch.
7670         * python/python-internal.h (class gdbpy_err_fetch): New class.
7671         (class gdbpy_enter) <m_error_type, m_error_value,
7672         m_error_traceback>: Remove.
7673         <m_error>: New member.
7674         (gdbpy_exception_to_string): Don't declare.
7675         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7676         * python/py-value.c (convert_value_from_python): Use
7677         gdbpy_err_fetch.
7678         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7679         gdbpy_exception_to_string.
7680         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7681         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7682         gdbpy_err_fetch.
7683
7684 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * linux-nat.c (delete_lwp_cleanup): Delete.
7687         (struct lwp_deleter): New struct.
7688         (lwp_info_up): New typedef.
7689         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7690         lwp_info_up.
7691
7692 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * linux-fork.c (class scoped_switch_fork_info): New class.
7695         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7696
7697 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * valops.c (find_overload_match): Remove use of null_cleanup, and
7700         calls to do_cleanups.
7701
7702 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * compile/compile-cplus-types.c
7705         (compile_cplus_instance::decl_name): Handle changes to
7706         cp_func_name.
7707         * cp-support.c (cp_func_name): Update header comment, update
7708         return type.
7709         * cp-support.h (cp_func_name): Update return type in declaration.
7710         * valops.c (find_overload_match): Move temp_func local to top
7711         level of function and change its type.  Use temp_func to hold and
7712         delete temporary string obtained from cp_func_name.
7713
7714 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7717         gdb::char_vector, remove cleanup, and update uses of `msg`.
7718
7719 2019-01-03  Jim Wilson  <jimw@sifive.com>
7720
7721         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7722
7723 2019-01-02  Tom Tromey  <tom@tromey.com>
7724
7725         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7726         (tdesc_parse_xml): Remove cleanups.
7727         * target-descriptions.h (make_cleanup_free_target_description):
7728         Don't declare.
7729         (target_desc_deleter): New struct.
7730         (target_desc_up): New typedef.
7731         * target-descriptions.c (target_desc_deleter::operator()): Rename
7732         from free_target_description.
7733         (make_cleanup_free_target_description): Remove.
7734
7735 2019-01-02  Tom Tromey  <tom@tromey.com>
7736
7737         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7738         constructor, destructor.
7739         (linespec_parser): Remove typedef.
7740         (~linespec_parser): Rename from linespec_parser_delete.
7741         (linespec_lex_to_end, linespec_complete_label)
7742         (linespec_complete): Update.
7743         (decode_line_full): Remove cleanups.
7744         (decode_line_1): Update.
7745
7746 2019-01-02  Tom Tromey  <tom@tromey.com>
7747
7748         * python/python-internal.h (inferior_to_inferior_object): Change
7749         return type.
7750         * python/py-exitedevent.c (create_exited_event_object): Update.
7751         * python/py-inferior.c (inferior_to_inferior_object): Return
7752         gdbpy_ref.
7753         (python_new_inferior, python_inferior_deleted)
7754         (thread_to_thread_object, delete_thread_object)
7755         (build_inferior_list, gdbpy_selected_inferior): Update.
7756         * python/py-infthread.c (create_thread_object): Update.  Also fail
7757         if inferior_to_inferior_object fails.
7758
7759 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7760
7761         * inferior.h (class inferior) <displaced_step_state>: New field.
7762         * infrun.h (struct displaced_step_state): Move here from
7763         infrun.c.  Initialize fields, add constructor.
7764         <inf>: Remove field.
7765         <reset>: New method.
7766         * infrun.c (struct displaced_step_inferior_state): Move to
7767         infrun.h.
7768         (displaced_step_inferior_states): Remove.
7769         (get_displaced_stepping_state): Adust.
7770         (displaced_step_in_progress_any_inferior): Adjust.
7771         (displaced_step_in_progress_thread): Adjust.
7772         (displaced_step_in_progress): Adjust.
7773         (add_displaced_stepping_state): Remove.
7774         (get_displaced_step_closure_by_addr): Adjust.
7775         (remove_displaced_stepping_state): Remove.
7776         (infrun_inferior_exit): Call displaced_step_state.reset.
7777         (use_displaced_stepping): Don't check for NULL.
7778         (displaced_step_prepare_throw): Call
7779         get_displaced_stepping_state.
7780         (displaced_step_fixup): Don't check for NULL.
7781         (prepare_for_detach): Don't check for NULL.
7782
7783 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7784
7785         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7786          in case of call that did not complete.
7787
7788 2019-01-02  Andrey Utkin  <autkin@undo.io>
7789
7790         * symfile.c (find_separate_debug_file): Fix search of debug files for
7791         remote debuggee.
7792
7793 2019-01-02  Tom Tromey  <tom@tromey.com>
7794
7795         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7796         indentation.
7797         * python/py-frame.c (frapy_older): Remove cast.
7798         (frapy_newer): Likewise.
7799         * python/py-breakpoint.c (local_setattro): Remove cast.
7800         * python/py-arch.c (archpy_name): Remove local variable.
7801         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7802
7803 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7804
7805         * unittests/basic_string_view/element_access/char/empty.cc:
7806         Fix year range in copyright header.
7807
7808 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7811         Delete.
7812         <operator==>: Update with for removed field.
7813         <hash>: Likewise.
7814         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7815         <isa_features>: ...this.
7816         <abi_features>: New field.
7817         (riscv_isa_flen): Update comment.
7818         (riscv_abi_xlen): New declaration.
7819         (riscv_abi_flen): New declaration.
7820         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7821         isa_features.
7822         (riscv_abi_xlen): New function.
7823         (riscv_isa_flen): Update to get answer from isa_features.
7824         (riscv_abi_flen): New function.
7825         (riscv_has_fp_abi): Update to get answer from abi_features.
7826         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7827         xlen and flen.
7828         (riscv_call_info) <xlen, flen>: Update comment.
7829         (riscv_call_arg_struct): Remove invalid assertions
7830         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7831         is removed.
7832         (riscv_gdbarch_init): Gather isa features and abi features
7833         separately, ensure both match on the gdbarch when reusing an old
7834         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7835         a target with 64-bit float hardware.
7836
7837 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7838
7839         * source.c (search_command_helper): Stop reverse search
7840         when line 1 has been searched.
7841
7842 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7843
7844         * record-full.c (record_full_base_target::close): Rewrite
7845         record_full_core_buf_list free logic.
7846
7847 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7848
7849         * break-catch-syscall.c (print_one_catch_syscall): xfree
7850         the last text.
7851
7852 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7853
7854         * top.c (print_gdb_version): Update Copyright year in version
7855         message.
7856
7857 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7858
7859         Update copyright year range in all GDB files.
7860
7861 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7862
7863         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7864
7865 For older changes see ChangeLog-2018.
7866 \f
7867 Local Variables:
7868 mode: change-log
7869 left-margin: 8
7870 fill-column: 74
7871 version-control: never
7872 coding: utf-8
7873 End:
7874